* xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d89eb65e
PE
12011-05-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4
78eb494e
PE
52011-05-11 Paul Eggert <eggert@cs.ucla.edu>
6
5235bd3e
PE
7 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8 Before, the code was not consistent. These values cannot exceed
9 2**31 - 1 so there's no need to make them unsigned.
10 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13 as modifiers.
14 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15
bc827e23
PE
16 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
17 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
18 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
19 presumably because the widths might not match.
20
78eb494e
PE
21 * window.c (size_window): Avoid needless test at loop start.
22
2f142cc5
JB
232011-05-10 Juanma Barranquero <lekktu@gmail.com>
24
25 * image.c (Finit_image_library): Return t for built-in image types,
26 like pbm and xbm. (Bug#8640)
27
57679c86
AS
282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
29
30 * w32menu.c (set_frame_menubar): Fix submenu allocation.
31
888c9e86
EZ
322011-05-07 Eli Zaretskii <eliz@gnu.org>
33
b0512a1d
EZ
34 * w32console.c (Fset_screen_color): Doc fix.
35 (Fget_screen_color): New function.
36 (syms_of_ntterm): Defsubr it.
37
888c9e86
EZ
38 * callproc.c (call_process_cleanup): Don't close and unlink the
39 temporary file if Fcall_process didn't create it in the first
40 place.
41 (Fcall_process): Don't create tempfile if stdout of the child
42 process will be redirected to a file specified with `:file'.
43 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
44 cue to call_process_cleanup not to close that handle.
45
4d3fcc8e
BK
462011-05-07 Ben Key <bkey76@gmail.com>
47
48 * makefile.w32-in: The bootstrap-temacs rule now makes use of
49 one of two shell specific rules, either bootstrap-temacs-CMD or
50 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
51 to the previous implementation of the bootstrap-temacs rule.
52 The bootstrap-temacs-CMD rule is similar to the previous
53 implementation of the bootstrap-temacs rule except that it
54 makes use of the ESC_CFLAGS variable instead of the CFLAGS
55 variable.
56
57 These changes, along with some changes to nt/configure.bat,
58 nt/gmake.defs, and nt/nmake.defs, are required to extend my
59 earlier fix to add support for --cflags and --ldflags options
60 that include quotes so that it works whether make uses cmd or
61 sh as the shell.
62
b4289b64
MA
632011-05-06 Michael Albinus <michael.albinus@gmx.de>
64
65 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
66 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
67 is a constant.
68 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
69 a string. Handle both cases.
70 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
71 (Fdbus_register_method): Use Qinvalid_function.
72
af4c0e28
JB
732011-05-06 Juanma Barranquero <lekktu@gmail.com>
74
75 * makefile.w32-in: Update dependencies.
76 (LISP_H): Add inttypes.h and stdin.h.
77 (PROCESS_H): Add unistd.h.
78
c51453d9
EZ
792011-05-06 Eli Zaretskii <eliz@gnu.org>
80
81 * lread.c: Include limits.h (fixes the MS-Windows build broken by
82 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
83
8ff0ac3c 842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 85
4c4b566b
PE
86 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
87
aab2b9b5
PE
88 * term.c (vfatal): Remove stray call to va_end.
89 It's not needed and the C Standard doesn't allow it here anyway.
90
c378da0b
PE
91 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
92 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
93
288b08c7
PE
94 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
95 bytes.
96
e3601888
PE
97 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
98
db6c0e74
PE
99 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
100
dd5963ea
PE
101 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
102
88c9450f
PE
103 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
104
2f9442b8
PE
105 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
106
c032b5f8
PE
107 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
108 * charset.c (Fdefine_charset_internal): Don't initialize
109 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 110 32-bit int (Bug#8600).
a108c10b
PE
111
112 * lread.c (read_integer): Be more consistent with string-to-number.
113 Use string_to_number to do the actual conversion; this avoids
114 rounding errors and fixes some other screwups. Without this fix,
115 for example, #x1fffffffffffffff was misread as -2305843009213693952.
116 (digit_to_number): Move earlier, for benefit of read_integer.
117 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 118 not a digit in any supported base. (Bug#8602)
a108c10b 119
ad5f9eea
PE
120 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
121
aec1708a
PE
122 * dispnew.c (scrolling_window): Return 1 if we scrolled,
123 to match comment at start of function. This also removes a
124 GCC warning about overflow in a 32+64-bit port.
125
47be4ab5
PE
126 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
127
371cac43
PE
128 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
129 Reported by Stefan Monnier in
130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
131 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
132 SYMBOLP-guarded XSYMBOL, not XPNTR.
133
d01a7826
PE
134 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
135 (EMACS_UINTPTR): Likewise, with uintptr_t.
136
7fd47d5c
PE
137 * lisp.h: Prefer 64-bit EMACS_INT if available.
138 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
139 on 32-bit hosts that have 64-bit int, so that they can access
140 large files.
122b0c86
PE
141 However, temporarily disable this change unless the temporary
142 symbol WIDE_EMACS_INT is defined.
7fd47d5c 143
8727937b
PE
144 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
145
8ac068ac
PE
146 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
147 This removes an assumption that EMACS_INT and long are the same
148 width as pointers. The assumption is true for Emacs porting targets
149 now, but we want to make other targets possible.
150 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
151 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
152 In the rest of the code, change types of integers that hold casted
153 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
154 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
155 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
156 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
157 No need to cast type when ORing.
158 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
159 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
160 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
161 assume EMACS_INT is the same width as char *.
162 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
163 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
164 Remove no-longer-needed casts.
165 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
166 (xg_tool_bar_help_callback, xg_make_tool_item):
167 Use EMACS_INTPTR to hold an integer
168 that will be cast to void *; this can avoid a GCC warning
169 if EMACS_INT is not the same width as void *.
170 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
171 * xdisp.c (display_echo_area_1, resize_mini_window_1):
172 (current_message_1, set_message_1):
173 Use a local to convert to proper width without a cast.
174 * xmenu.c (dialog_selection_callback): Likewise.
175
ede49d71
PE
176 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
177 Also, don't assume VALBITS / RAND_BITS is less than 5,
178 and don't rely on undefined behavior when shifting a 1 left into
179 the sign bit.
180 * lisp.h (get_random): Change signature to match.
181
2f30ecd0
PE
182 * lread.c (hash_string): Use size_t, not int, for hash computation.
183 Normally we prefer signed values; but hashing is special, because
184 it's better to use unsigned division on hash table sizes so that
185 the remainder is nonnegative. Also, size_t is the natural width
186 for hashing into memory. The previous code used 'int', which doesn't
187 retain enough info to hash well into very large tables.
188 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
189
2a866e7b
PE
190 * dbusbind.c: Don't possibly lose pointer info when converting.
191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
192 Use XPNTR rather than XHASH, so that the high-order bits of
193 the pointer aren't lost when converting through void *.
194
51639eac
PE
195 * eval.c (Fautoload): Don't double-shift a pointer.
196
92394119
PE
197 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
198
dbdb9a7c
JB
1992011-05-06 Juanma Barranquero <lekktu@gmail.com>
200
201 * gnutls.c (DEF_GNUTLS_FN):
202 * image.c (DEF_IMGLIB_FN): Make function pointers static.
203
db7a0b4f
AS
2042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
205
206 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
207 marker. (Bug#8610)
208
f7ff1b0f 2092011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
210
211 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
212 New version that can reserve upto 2GB of heap space.
213
f7ff1b0f 2142011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
215
216 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
217
639c109b
TZ
2182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
219
220 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
221 `gnutls_certificate_set_x509_key_file'.
222
d2127135
JB
2232011-05-05 Juanma Barranquero <lekktu@gmail.com>
224
225 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
226 Update dependencies.
227
e968f4f3
JB
2282011-05-04 Juanma Barranquero <lekktu@gmail.com>
229
230 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
231 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
232 Remove unused parameter `fildes'.
233 * process.c (read_process_output, send_process): Don't pass it.
234
84d358f0
JB
2352011-05-04 Juanma Barranquero <lekktu@gmail.com>
236
237 Fix previous change: the library cache is defined in w32.c.
238 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
239 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
240
0898ca10
JB
2412011-05-04 Juanma Barranquero <lekktu@gmail.com>
242
243 Implement dynamic loading of GnuTLS on Windows.
244
245 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
246 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
247 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
248 Declare.
249
250 * gnutls.c (Qgnutls_dll): Define.
251 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
252 (gnutls_*): Declare function pointers.
253 (init_gnutls_functions): New function to initialize function pointers.
254 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
255 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
256 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
257 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
258 (emacs_gnutls_write, emacs_gnutls_read)
259 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
260 (Fgnutls_available_p): New function.
261 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
262 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
263 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
264
265 * image.c: Include w32.h.
266 (Vimage_type_cache): Delete.
267 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
268 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
269 (w32_delayed_load): Move to w32.c.
270
271 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
272
273 * w32.c (QCloaded_from, Vlibrary_cache): Define.
274 (w32_delayed_load): Move from image.c. When loading a library, record
275 its filename in the :loaded-from property of the library id.
276 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
277 Initialize and staticpro them.
278 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
279
280 * process.c: Include lisp.h before w32.h, not after.
281 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
282 instead of gnutls_record_check_pending.
283
284 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
285
ff4de4aa
TZ
2862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
287
288 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
289 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
290 as passed in.
291
abe95abb
JD
2922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
293
294 * xterm.c (x_set_frame_alpha): Do not set property on anything
295 else than FRAME_X_OUTER_WINDOW (Bug#8608).
296
e16e55d4
JB
2972011-05-02 Juanma Barranquero <lekktu@gmail.com>
298
299 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
300
bafcf6a5
JB
3012011-05-02 Juanma Barranquero <lekktu@gmail.com>
302
303 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
304 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
305 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
306 (gnutls_global_initialized, Qgnutls_bootprop_priority)
307 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
308 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
309 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
310 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
311 (Qgnutls_bootprop_callbacks_verify): Make static.
312
e7a6747f
AS
3132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
314
19ed11ba
AS
315 * callproc.c: Indentation fixup.
316
e7a6747f
AS
317 * sysdep.c (wait_for_termination_1): Make static.
318 (wait_for_termination, interruptible_wait_for_termination): Move
319 after wait_for_termination_1.
320
1ef14cb4
LMI
3212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
322
323 * sysdep.c (interruptible_wait_for_termination): New function
324 which is like wait_for_termination, but allows keyboard
325 interruptions.
326
327 * callproc.c (Fcall_process): Add (:file "file") as an option for
328 the STDOUT buffer.
329 (Fcall_process_region): Ditto.
330
330d880c
EZ
3312011-04-30 Eli Zaretskii <eliz@gnu.org>
332
8db90b73
EZ
333 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
334 rather than `XVECTOR (FOO)->size'.
335
330d880c
EZ
336 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
337 inttypes.h, as a gnulib replacement is used if it not available in
338 system headers.
339
15cbd324
EZ
3402011-04-21 Eli Zaretskii <eliz@gnu.org>
341
342 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
343 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
344 of MOST_POSITIVE_FIXNUM. (Bug#8528)
345
346 * coding.c (coding_alloc_by_realloc): Error out if destination
347 will grow beyond MOST_POSITIVE_FIXNUM.
348 (decode_coding_emacs_mule): Abort if there isn't enough place in
349 charbuf for the composition carryover bytes. Reserve an extra
350 space for up to 2 characters produced in a loop.
351 (decode_coding_iso_2022): Abort if there isn't enough place in
352 charbuf for the composition carryover bytes.
353
3542011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 355
ae940cca
EZ
356 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
357 aborting when %lld or %lll format is passed.
358 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
359 %llo or %llx format is passed. (Bug#8545)
360
03ab8921
EZ
361 * window.c (window_scroll_line_based): Use a marker instead of
362 simple variables to record original value of point. (Bug#7952)
363
afda1437
EZ
364 * doprnt.c (doprnt): Fix the case where a multibyte sequence
365 produced by %s or %c overflows available buffer space. (Bug#8545)
366
f76dee0c
PE
3672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
368
369 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 370 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 371
fdc5744d
JB
3722011-04-28 Juanma Barranquero <lekktu@gmail.com>
373
374 * w32.c (init_environment): Warn about defaulting HOME to C:\.
375
638f053a
JB
3762011-04-28 Juanma Barranquero <lekktu@gmail.com>
377
378 * keyboard.c (Qdelayed_warnings_hook): Define.
379 (command_loop_1): Run `delayed-warnings-hook'
380 if Vdelayed_warnings_list is non-nil.
381 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
382 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
383
d178f871
EZ
3842011-04-28 Eli Zaretskii <eliz@gnu.org>
385
386 * doprnt.c (doprnt): Don't return value smaller than the buffer
387 size if the message was truncated. (Bug#8545).
388
b124fd93
JB
3892011-04-28 Juanma Barranquero <lekktu@gmail.com>
390
391 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
392 (Fx_window_property): #if-0 the whole functions, not just the bodies.
393
e810457d
PE
3942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
395
396 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
397
ea51cceb
JB
3982011-04-27 Juanma Barranquero <lekktu@gmail.com>
399
400 * makefile.w32-in: Update dependencies.
401
94dcfacf
EZ
4022011-04-27 Eli Zaretskii <eliz@gnu.org>
403
404 Improve `doprnt' and its usage. (Bug#8545)
405 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
406 `format_end'. Remove support for %l as a conversion specifier.
407 Don't use xrealloc. Improve diagnostics when the %l size modifier
408 is used. Update the commentary.
409
410 * eval.c (verror): Simplify calculation of size_t.
411
412 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
413 messages.
414
f61f41d7
PE
4152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
416
417 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
418 change.
419
96fb4434
PE
4202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
421
422 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
423 This makes this file independent of the recent pseudovector change.
424
671875da 4252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 426
69e9b5a3
PE
427 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
428
b5f869a7 429 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 430 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 431 Remove unused local.
c8926152 432 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 433
841a1577 434 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
435 GCC 4.6.0 optimizes based on type-based alias analysis. For
436 example, if b is of type struct buffer * and v of type struct
437 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
438 != &v->size, and therefore "v->size = 1; b->size = 2; return
439 v->size;" must therefore return 1. This assumption is incorrect
440 for Emacs, since it type-puns struct Lisp_Vector * with many other
441 types. To fix this problem, this patch adds a new type struct
f904488f 442 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
443 and pseudovectors, and helps optimizing compilers not get fooled
444 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
445 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
446 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
447 the size member.
eab3844f
PE
448 (XSETPVECTYPE): Rewrite in terms of new macro.
449 (XSETPVECTYPESIZE): New macro, specifying both type and size.
450 This is a bit clearer, and further avoids the possibility of
451 undesirable aliasing.
452 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 453 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
454 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
455 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
456 (ASIZE): Now uses header.size rather than size. All
457 previous uses of XVECTOR (foo)->size replaced to use this macro,
458 to avoid the hassle of writing XVECTOR (foo)->header.size.
459 (struct vectorlike_header): New type.
eab3844f
PE
460 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
461 object, to help avoid aliasing.
462 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
463 (SUBRP): Likewise, since Lisp_Subr is a special case.
464 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
465 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
466 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 467 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
468 changed to be "header.size" and "header.next".
469 * buffer.h (struct buffer): Likewise.
470 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
471 * frame.h (struct frame): Likewise.
472 * process.h (struct Lisp_Process): Likewise.
473 * termhooks.h (struct terminal): Likewise.
474 * window.c (struct save_window_data, struct saved_window): Likewise.
475 * window.h (struct window): Likewise.
476 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
477 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
478 * buffer.c (init_buffer_once): Likewise.
479 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
480 special case.
481 * process.c (Fformat_network_address): Use local var for size,
482 for brevity.
483
0df1eac5
PE
484 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
485
847ab9d1 486 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
487 * data.c (atof): Remove decl; no longer used or needed.
488 (digit_to_number): Move to lread.c.
489 (Fstring_to_number): Use new string_to_number function, to be
490 consistent with how the Lisp reader treats infinities and NaNs.
491 Do not assume that floating-point numbers represent EMACS_INT
492 without losing information; this is not true on most 64-bit hosts.
493 Avoid double-rounding errors, by insisting on integers when
494 parsing non-base-10 numbers, as the documentation specifies.
495 * lisp.h (string_to_number): New decl, replacing ...
496 (isfloat_string): Remove.
bc0a5c13 497 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 498 (read1): Do not accept +. and -. as integers; this
452f4150
PE
499 appears to have been a coding error. Similarly, do not accept
500 strings like +-1e0 as floating point numbers. Do not report
501 overflow for integer overflows unless the base is not 10 which
502 means we have no simple and reliable way to continue.
503 Break out the floating-point parsing into a new
504 function string_to_number, so that Fstring_to_number parses
505 floating point numbers consistently with the Lisp reader.
506 (digit_to_number): Moved here from data.c. Make it static inline.
507 (E_CHAR, EXP_INT): Remove, replacing with ...
508 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
509 (string_to_number): New function, replacing isfloat_string.
510 This function checks for valid syntax and produces the resulting
511 Lisp float number too. Rework it so that string-to-number
bc0a5c13 512 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
513 so that overflow for non-base-10 numbers is reported only when
514 there's no portable and simple way to convert to floating point.
452f4150 515
67769ffc
PE
516 * textprop.c (set_text_properties_1): Rewrite for clarity,
517 and to avoid GCC warning about integer overflow.
518
c20db43f
PE
519 * intervals.h (struct interval): Use EMACS_INT for members
520 where EMACS_UINT might cause problems. See
521 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
522 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
523 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
524 All uses changed.
37aa2f85
PE
525 (offset_intervals): Tell GCC not to worry about length overflow
526 when negating a negative length.
c20db43f 527
2538aa2f
PE
528 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
529 (overrun_check_free): Likewise.
530
f2d3008d
PE
531 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
532 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
533 word size.
534
ec8df744
PE
535 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
536 (gnutls_make_error): Rename local to avoid shadowing.
537 (gnutls_emacs_global_deinit): ifdef out; not used.
538 (Fgnutls_boot): Use const for pointer to readonly storage.
539 Comment out unused local. Fix pointer signedness problems.
540
640ee02d
PE
541 * lread.c (openp): Don't stuff size_t into an 'int'.
542 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
543 about possible signed overflow.
544
6048fb2a
PE
545 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
546 (GDK_KEY_g): Don't define if already defined.
547 (xg_prepare_tooltip): Avoid pointer signedness problem.
548 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
549
fa3c87e1
PE
550 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
551 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
552
2172544b
PE
553 * xfns.c (Fx_window_property): Simplify a bit,
554 to make a bit faster and to avoid GCC 4.6.0 warning.
555 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
556
9b821a21
PE
557 * fns.c (internal_equal): Don't assume size_t fits in int.
558
3c616cfa
PE
559 * alloc.c (compact_small_strings): Tighten assertion a little.
560
c2982e87
PE
561 Replace pEd with more-general pI, and fix some printf arg casts.
562 * lisp.h (pI): New macro, generalizing old pEd macro to other
563 conversion specifiers. For example, use "...%"pI"d..." rather
564 than "...%"pEd"...".
565 (pEd): Remove. All uses replaced with similar uses of pI.
566 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
567 * alloc.c (check_pure_size): Don't overflow by converting size to int.
568 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
569 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
570 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
571 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
572 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
573 64-bit hosts.
574 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
575 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
576 * print.c (safe_debug_print, print_object): Likewise.
577 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
578 to int.
6f04d126
PE
579 Use pI instead of if-then-else-abort. Use %p to avoid casts,
580 avoiding the 0 flag, which is not portable.
c2982e87
PE
581 * process.c (Fmake_network_process): Use pI to avoid cast.
582 * region-cache.c (pp_cache): Likewise.
583 * xdisp.c (decode_mode_spec): Likewise.
584 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
585 behavior on 64-bit hosts with printf arg.
6f04d126 586 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
587 (x_stop_queuing_selection_requests): Likewise.
588 (x_get_window_property): Don't truncate byte count to an 'int'
589 when tracing.
0b432f21 590
5e073ec7
PE
591 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
592 here, since it parses constructs like leading '-' and spaces,
593 which are not wanted; and it overflows with large numbers.
594 Instead, simply match F[0-9]+, which is what is wanted anyway.
595
36372bf9
PE
596 * alloc.c: Remove unportable assumptions about struct layout.
597 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
598 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
599 (allocate_vectorlike, make_pure_vector): Use the new macros,
600 plus offsetof, to remove unportable assumptions about struct layout.
601 These assumptions hold on all porting targets that I know of, but
602 they are not guaranteed, they're easy to remove, and removing them
603 makes further changes easier.
604
0b432f21
PE
605 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
606 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
607 (string_overrun_cookie): Now const. Use initializers that
608 don't formally overflow signed char, to avoid warnings.
000098c1
PE
609 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
610 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
611 (allocate_buffer): Don't assume sizeof (struct buffer) is a
612 multiple of sizeof (EMACS_INT); it need not be, if
613 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 614 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 615
895009e1
JB
6162011-04-26 Juanma Barranquero <lekktu@gmail.com>
617
618 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
619
6a7a1b0b
TZ
6202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
621
622 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 623 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
624 Reported by Paul Eggert <eggert@cs.ucla.edu>.
625
841a1577 6262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
627
628 * lisp.h (Qdebug): List symbol.
895009e1 629 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
630 * keyboard.c (debug-on-event): New variable.
631 (handle_user_signal): Break into debugger when debug-on-event
632 matches the current signal symbol.
633
f2d3ba6f
DN
6342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
635
636 * alloc.c (check_sblock, check_string_bytes)
637 (check_string_free_list): Convert to standard C.
638
42ce4c63
TZ
6392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
640
641 * w32.c (emacs_gnutls_push): Fix typo.
642
825cd63c
EZ
6432011-04-25 Eli Zaretskii <eliz@gnu.org>
644
fb11d64d
EZ
645 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
646 "cast to pointer from integer of different size".
647
825cd63c
EZ
648 Improve doprnt and its use in verror. (Bug#8545)
649 * doprnt.c (doprnt): Document the set of format control sequences
650 supported by the function. Use SAFE_ALLOCA instead of always
651 using `alloca'.
652
653 * eval.c (verror): Don't limit the buffer size at size_max-1, that
654 is one byte too soon. Don't use xrealloc; instead xfree and
655 xmalloc anew.
656
e061a11b
TZ
6572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
658
659 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
660 callbacks stage.
661
662 * gnutls.c: Renamed global_initialized to
663 gnutls_global_initialized. Added internals for the
664 :verify-hostname-error, :verify-error, and :verify-flags
665 parameters of `gnutls-boot' and documented those parameters in the
666 docstring. Start callback support.
667 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
668 unless a fatal error occured. Call gnutls_alert_send_appropriate
669 on error. Return error code.
670 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
671 (emacs_gnutls_read): Likewise.
672 (Fgnutls_boot): Return handshake error code.
673 (emacs_gnutls_handle_error): New function.
674 (wsaerror_to_errno): Likewise.
675
676 * w32.h (emacs_gnutls_pull): Add prototype.
677 (emacs_gnutls_push): Likewise.
678
679 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
680 (emacs_gnutls_push): Likewise.
681
6822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
683
684 * process.c (wait_reading_process_output): Check if GnuTLS
685 buffered some data internally if no FDs are set for TLS
686 connections.
687
688 * makefile.w32-in (OBJ2): Add gnutls.$(O).
689 (LIBS): Link to USER_LIBS.
690 ($(BLD)/gnutls.$(0)): New target.
691
fa6996bc
EZ
6922011-04-24 Eli Zaretskii <eliz@gnu.org>
693
eb35682e
EZ
694 * xdisp.c (handle_single_display_spec): Rename the
695 display_replaced_before_p argument into display_replaced_p, to
696 make it consistent with the commentary. Fix typos in the
697 commentary.
698
e2ad650c
EZ
699 * textprop.c (syms_of_textprop): Remove dead code.
700 (copy_text_properties): Delete obsolete commentary about an
701 interface that was deleted long ago. Fix typos in the description
702 of arguments.
703
1b2de274
EZ
704 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
705 to changes in oldXMenu/XMenu.h from 2011-04-16.
706 <menu_help_message, prev_menu_help_message>: Constify.
707 (IT_menu_make_room): menu->help_text is now `const char **';
708 adjust.
709
710 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
711 to changes in oldXMenu/XMenu.h from 2011-04-16.
712 (struct XMenu): Declare `help_text' `const char **'.
713
714 * xfaces.c <Qunspecified>: Make extern again.
715
716 * syntax.c: Include sys/types.h before including regex.h, as
717 required by Posix.
718
762b15be
EZ
719 * doc.c (get_doc_string): Improve the format passed to `error'.
720
721 * doprnt.c (doprnt): Improve commentary.
722
723 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
724
725 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
726 them with etags.
727
f1052e5d
EZ
728 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
729 changes in globals.h immediately force recompilation.
762b15be
EZ
730 (TAGS): Depend on $(CURDIR)/m/intel386.h and
731 $(CURDIR)/s/ms-w32.h.
732 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 733
fa6996bc
EZ
734 * character.c (Fchar_direction): Function deleted.
735 (syms_of_character): Don't defsubr it.
736 <char-direction-table>: Deleted.
737
e6c3da20
EZ
7382011-04-23 Eli Zaretskii <eliz@gnu.org>
739
740 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
741 * doprnt.c: Include limits.h.
742 (SIZE_MAX): New macro.
743 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
744 local variables are now size_t instead of int or unsigned.
745 Improve overflow protection. Support `l' modifier for integer
746 conversions. Support %l conversion. Don't assume an EMACS_INT
747 argument for integer conversions and for %c.
748
749 * lisp.h (doprnt): Restore prototype.
750
751 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
752 $(SRC)/character.h.
753
754 * Makefile.in (base_obj): Add back doprnt.o.
755
756 * deps.mk (doprnt.o): Add back prerequisites.
757 (callint.o): Depend on character.h.
758
759 * eval.c (internal_lisp_condition_case): Include the handler
760 representation in the error message.
761 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
762 when breaking from the loop.
763
764 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
765
766 * callint.c (Fcall_interactively): When displaying error message
767 about invalid control letter, pass the character's codepoint, not
768 a pointer to its multibyte form. Improve display of the character
769 in octal and display also its hex code.
770
771 * character.c (char_string): Use %x to display the (unsigned)
772 codepoint of an invalid character, to avoid displaying a bogus
773 negative value.
774
775 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
776 `error', not SYMBOL_NAME itself.
777
778 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
779 character arguments to `error'.
780
781 * charset.c (check_iso_charset_parameter): Fix incorrect argument
782 to `error' in error message about FINAL_CHAR argument. Make sure
783 FINAL_CHAR is a character, and use %c when it is passed as
784 argument to `error'.
785
4ffd0d6b 7862011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
787
788 * s/ms-w32.h (localtime): Redirect to sys_localtime.
789
790 * w32.c: Include <time.h>.
791 (sys_localtime): New function.
792
4ffd0d6b 7932011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
794
795 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
796
4ffd0d6b 797 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 798
4ffd0d6b 7992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 800
4ffd0d6b
GM
801 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
802 zombies (Bug#8467).
aac0c6e3 803
04c56954
EZ
8042011-04-19 Eli Zaretskii <eliz@gnu.org>
805
806 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
807 gl_state.e_property when gl_state.object is Qt.
808
809 * insdel.c (make_gap_larger): Remove limitation of buffer size
810 to <= INT_MAX.
811
16a43933
CY
8122011-04-18 Chong Yidong <cyd@stupidchicken.com>
813
814 * xdisp.c (lookup_glyphless_char_display)
815 (produce_glyphless_glyph): Handle cons cell entry in
816 glyphless-char-display.
817 (Vglyphless_char_display): Document it.
818
819 * term.c (produce_glyphless_glyph): Handle cons cell entry in
820 glyphless-char-display.
821
4581706e
CY
8222011-04-17 Chong Yidong <cyd@stupidchicken.com>
823
824 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
825
826 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
827
828 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
829 definition for no-X builds.
830
4887c6e2 8312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 832
fd35b6f9
PE
833 Static checks with GCC 4.6.0 and non-default toolkits.
834
5c1ccb01
PE
835 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
836
006c5daa
PE
837 * process.c (keyboard_bit_set): Define only if SIGIO.
838 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
839 (send_process): Repair possible setjmp clobbering.
840
efc736d3
PE
841 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
842
4e2fe2e6
PE
843 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
844
f97334a2
PE
845 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
846
4e75f29d
PE
847 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
848 Define only if needed.
849
90efadd1
PE
850 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
851 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 852 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 853
3c647824
PE
854 * dispextern.h (struct redisplay_interface): Rename param
855 to avoid shadowing.
e264f262 856 * termhooks.h (struct terminal): Likewise.
761383f4 857 * xterm.c (xembed_send_message): Likewise.
3c647824 858
b58c5c4a
PE
859 * insdel.c (make_gap_smaller): Define only if
860 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
861
cad59032
PE
862 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
863 it.
864
c339dc2e
PE
865 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
866 so that we aren't warned about unused symbols.
867
91a3e27b
PE
868 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
869
399c71d3 870 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 871
8ffc96f5
PE
872 * xfns.c (x_real_positions): Mark locals as initialized.
873
eef9bc79
PE
874 * xmenu.c (xmenu_show): Don't use uninitialized vars.
875
098db9dd
PE
876 * xterm.c: Fix problems found by static analysis with other toolkits.
877 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
878 (x_dispatch_event): Declare static if USE_GTK, and
879 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 880 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 881 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
882 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
883 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 884
eb18f6cc
PE
885 * xmenu.c (menu_help_callback): Pointer type fixes.
886 Use const pointers when pointing at readonly data. Avoid pointer
887 signedness clashes.
888 (FALSE): Remove unused macro.
889 (update_frame_menubar): Remove unused decl.
890
1fe72bf8
PE
891 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
892
60d9e1db
PE
893 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
894 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
895 (single_menu_item): Rename local to avoid shadowing.
896
39261c26
PE
897 * keyboard.c (make_lispy_event): Remove unused local var.
898
018c5e19
PE
899 * frame.c, frame.h (x_get_resource_string): Bring this back, but
900 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
901
63d2b86e
PE
902 * bitmaps: Change bitmaps from unsigned char back to the X11
903 compatible char. Avoid the old compiler warnings about
904 out-of-range initializers by using, for example, '\xab' rather
905 than 0xab.
906
aefd87e1
PE
907 * xgselect.c (xgselect_initialize): Check vs interface
908 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
909
bf501fb9
PE
910 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
911
e9829fdf
PE
912 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
913 to read-only memory.
914
1086c095
PE
915 * fns.c (vector): Remove; this old hack is no longer needed.
916
2baccd04 917 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 918 Remove unused var.
dde42981 919 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 920
72391843 921 * xrdb.c (x_load_resources): Omit unused local.
3565b346 922
436c16df 923 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 924 (x_window): Rename locals to avoid shadowing.
dc5ddd85 925 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 926
92bb796d 927 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 928 (x_term_init): Remove local to avoid shadowing.
92bb796d 929
764430a3 930 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
931
932 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
933 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
934
d1dfb56c
EZ
9352011-04-16 Eli Zaretskii <eliz@gnu.org>
936
c4354cb4
EZ
937 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
938
d1dfb56c
EZ
939 Fix regex.c, syntax.c and friends for buffers > 2GB.
940 * syntax.h (struct gl_state_s): Declare character position members
941 EMACS_INT.
942
943 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
944
945 * textprop.c (verify_interval_modification, interval_of): Declare
946 arguments EMACS_INT.
947
948 * intervals.c (adjust_intervals_for_insertion): Declare arguments
949 EMACS_INT.
950
951 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
952
953 * indent.c (Fvertical_motion): Local variable it_start is now
954 EMACS_INT.
955
956 * regex.c (re_match, re_match_2, re_match_2_internal)
957 (bcmp_translate, regcomp, regexec, print_double_string)
958 (group_in_compile_stack, re_search, re_search_2, regex_compile)
959 (re_compile_pattern, re_exec): Declare arguments and local
960 variables `size_t' and `ssize_t' and return values `regoff_t', as
961 appropriate.
962 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
963 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
964 <compile_stack_type>: `size' and `avail' are now `size_t'.
965
966 * regex.h <regoff_t>: Use ssize_t, not int.
967 (re_search, re_search_2, re_match, re_match_2): Arguments that
968 specify buffer/string position and length are now ssize_t and
969 size_t. Return type is regoff_t.
970
613052cd
BK
9712011-04-16 Ben Key <bkey76@gmail.com>
972
973 * nsfont.m: Fixed bugs in ns_get_family and
974 ns_descriptor_to_entity that were caused by using free to
975 deallocate memory blocks that were allocated by xmalloc (via
976 xstrdup). This caused Emacs to crash when compiled with
977 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
978 --enable-checking=xmallocoverrun). xfree is now used to
979 deallocate these memory blocks.
980
4170f62f 9812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 982
71b41406
PE
983 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
984
9587a89d
PE
985 emacs_write: Accept and return EMACS_INT for sizes.
986 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
987 et seq.
988 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
989 Accept and return EMACS_INT.
990 (emacs_gnutls_write): Return the number of bytes written on
991 partial writes.
992 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
993 (emacs_read, emacs_write): Remove check for negative size, as the
994 Emacs source code has been audited now.
9587a89d
PE
995 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
996 (emacs_read, emacs_write): Use it.
273a5f82
PE
997 * process.c (send_process): Adjust to the new signatures of
998 emacs_write and emacs_gnutls_write. Do not attempt to store
999 a byte offset into an 'int'; it might overflow.
9587a89d 1000 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1001
3e047f51
PE
1002 * sound.c: Don't assume sizes fit in 'int'.
1003 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1004 Return EMACS_INT, not int.
3e047f51 1005 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1006 Accept EMACS_INT, not int.
1007 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1008 record read return values.
1009
cc39a9db
BK
10102011-04-15 Ben Key <bkey76@gmail.com>
1011
c9d0ec6d
JB
1012 * keyboard.c (Qundefined): Don't declare static since it is used
1013 in nsfns.m.
1014 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1015 static since they are used in nsfont.m.
cc39a9db 1016
6c60eb9f
SM
10172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1018
1019 * process.c (Qprocessp): Don't declare static.
1020 * lisp.h (Qprocessp): Declare again.
1021
7990b61a
JB
10222011-04-15 Juanma Barranquero <lekktu@gmail.com>
1023
1024 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1025
5d4cb038
PE
10262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1027
8bd7b830 1028 Improve C-level modularity by making more things 'static'.
cd64ea1d 1029
e3b27b31
PE
1030 Don't publish debugger-only interfaces to other modules.
1031 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1032 (verify_bytepos, count_markers): Move decls to the only modules
1033 that need them.
1034 * region-cache.h (pp_cache): Likewise.
1035 * window.h (check_all_windows): Likewise.
1036 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1037
5d4cb038
PE
1038 * sysdep.c (croak): Now static, if
1039 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1040 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1041
1042 * alloc.c (refill_memory_reserve): Now static if
1043 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1044 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1045
e87b6180
PE
1046 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1047 Define only if USE_LUCID.
1048
ac64929e
PE
1049 * xrdb.c (x_customization_string, x_rm_string): Now static.
1050
6f37259d
PE
1051 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1052 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1053
1683e3ab
PE
1054 * xdisp.c (draw_row_with_mouse_face): Now static.
1055 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1056
de9c2632
PE
1057 * window.h (check_all_windows): Mark externally visible.
1058
2b96acb7
PE
1059 * window.c (window_deletion_count): Now static.
1060
1061 * undo.c: Make symbols static if they're not exported.
1062 (last_undo_buffer, last_boundary_position, pending_boundary):
1063 Now static.
1064
50436f33
PE
1065 * textprop.c (interval_insert_behind_hooks): Now static.
1066 (interval_insert_in_front_hooks): Likewise.
1067
64520e5c
PE
1068 * term.c: Make symbols static if they're not exported.
1069 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1070 (max_frame_lines, tty_set_terminal_modes):
1071 (tty_reset_terminal_modes, tty_turn_off_highlight):
1072 (get_tty_terminal): Now static.
1073 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1074 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1075 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1076 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1077 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1078
1fa53021
PE
1079 * sysdep.c: Make symbols static if they're not exported.
1080 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1081 Now static.
1082 (sigprocmask_set, full_mask): Remove; unused.
1083 (wait_debugging): Mark as visible.
1084 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1085 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1086
d4b43b22
PE
1087 * syntax.c (syntax_temp): Define only if !__GNUC__.
1088
b7c513d0
PE
1089 * sound.c (current_sound_device, current_sound): Now static.
1090
989b29ad
PE
1091 * search.c (searchbufs, searchbuf_head): Now static.
1092
13a55a78
PE
1093 * scroll.c (scroll_cost): Remove; unused.
1094 * dispextern.h (scroll_cost): Remove decl.
1095
de68a1fc
PE
1096 * region-cache.h (pp_cache): Mark as externally visible.
1097
40ccffa6
PE
1098 * process.c: Make symbols static if they're not exported.
1099 (process_tick, update_tick, create_process, chan_process):
1100 (Vprocess_alist, proc_buffered_char, datagram_access):
1101 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1102 (deactivate_process): Mark defn as static, as well as decl.
1103 * lisp.h (create_process): Remove decl.
1104 * process.h (chan_process, Vprocess_alist): Remove decls.
1105
ad64fc97
PE
1106 * print.c: Make symbols static if they're not exported.
1107 (print_depth, new_backquote_output, being_printed, print_buffer):
1108 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1109 (print_interval, print_number_index, initial_stderr_stream):
1110 Now static.
1111 * lisp.h (Fprinc): Remove decl.
1112 (debug_output_compilation_hack): Mark as externally visible.
1113
adddb265
PE
1114 * sysdep.c (croak): Move decl from here to syssignal.h.
1115 * syssignal.h (croak): Put it here, so the API can be checked when
1116 'croak' is called from dissociate_if_controlling_tty.
1117
1717ede2
PE
1118 * minibuf.c: Make symbols static if they're not exported.
1119 (minibuf_save_list, choose_minibuf_frame): Now static.
1120 * lisp.h (choose_minibuf_frame): Remove decl.
1121
fa5fb2bc
PE
1122 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1123
1e3890d1
PE
1124 * lread.c: Make symbols static if they're not exported.
1125 (read_objects, initial_obarray, oblookup_last_bucket_number):
1126 Now static.
1127 (make_symbol): Remove; unused.
1128 * lisp.h (initial_obarray, make_symbol): Remove decls.
1129
8a1414fa
PE
1130 * keyboard.c: Make symbols static if they're not exported.
1131 (single_kboard, recent_keys_index, total_keys, recent_keys):
1132 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1133 (this_single_command_key_start, echoing, last_auto_save):
1134 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1135 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1136 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1137 (Vlispy_mouse_stem, double_click_count):
1138 Now static.
1139 (force_auto_save_soon): Define only if SIGDANGER.
1140 (ignore_mouse_drag_p): Now static if
1141 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1142 (print_help): Remove; unused.
1143 (stop_character, last_timer_event): Mark as externally visible.
1144 * keyboard.h (ignore_mouse_drag_p): Declare only if
1145 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1146 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1147 * lisp.h (echoing): Remove decl.
1148 (force_auto_save_soon): Declare only if SIGDANGER.
1149 * xdisp.c (redisplay_window): Simplify code, to make it more
1150 obvious that ignore_mouse_drag_p is not accessed if !defined
1151 USE_GTK && !defined HAVE_NS.
1152
93ea6e8f
PE
1153 * intervals.c: Make symbols static if they're not exported.
1154 (merge_properties_sticky, merge_interval_right, delete_interval):
1155 Now static.
1156 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1157
77382fcc
PE
1158 * insdel.c: Make symbols static if they're not exported.
1159 However, leave prepare_to_modify_buffer alone. It's never
1160 called from outside this function, but that appears to be a bug.
1161 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1162 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1163 (adjust_after_replace_noundo): Remove; unused.
1164 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1165 (signal_before_change): Remove decls.
77382fcc 1166
9306c32e
PE
1167 * indent.c (val_compute_motion, val_vmotion): Now static.
1168
cd44d2eb
PE
1169 * image.c: Make symbols static if they're not exported.
1170 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1171 if USE_GTK.
1172 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1173 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1174
ad9a7a06
PE
1175 * fringe.c (standard_bitmaps): Now static.
1176 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1177
81626931
PE
1178 * frame.c: Make symbols static if they're not exported.
1179 (x_report_frame_params, make_terminal_frame): Now static.
1180 (get_frame_param): Now static, unless HAVE_NS.
1181 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1182 (x_get_resource_string): Remove; not used.
1183 * frame.h (make_terminal_frame, x_report_frame_params):
1184 (x_get_resource_string); Remove decls.
1185 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1186 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1187
239f9db9
PE
1188 * font.c, fontset.c: Make symbols static if they're not exported.
1189 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1190 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1191 * font.c (font_close_object): Now static.
1192 * font.h (font_close_object): Remove.
1193 * fontset.c (FONTSET_OBJLIST): Remove.
1194 (free_realized_fontset) #if-0 the body, which does nothing.
1195 (face_suitable_for_char_p): #if-0, as it's never called.
1196 * fontset.h (face_suitable_for_char_p): Remove decl.
1197 * xfaces.c (face_at_string_position): Use
1198 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1199 since 0 is always ASCII.
1200
dfcf3579
PE
1201 * fns.c (weak_hash_tables): Now static.
1202
5045092b
PE
1203 * fileio.c: Make symbols static if they're not exported.
1204 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1205 (Vwrite_region_annotation_buffers): Now static.
1206
57a96f5c
PE
1207 * eval.c: Make symbols static if they're not exported.
1208 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1209 * lisp.h (backtrace_list): Remove decl.
1210
35f08c38
PE
1211 * emacs.c: Make symbols static if they're not exported.
1212 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1213 (fatal_error_code, fatal_error_signal_hook, standard_args):
1214 Now static.
1215 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1216 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1217 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1218 * lisp.h (fatal_error_signal_hook): Remove decl.
1219 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1220
f44bd759
PE
1221 * editfns.c: Move a (normally-unused) function to its only use.
1222 * editfns.c, lisp.h (get_operating_system_release): Remove.
1223 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1224 worth the hassle of breaking this out.
1225
b532497d
PE
1226 * xterm.c: Make symbols static if they're not exported.
1227 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1228 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1229 (x_destroy_window, x_delete_display):
1230 Now static.
1231 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1232 (x_mouse_leave): Remove; unused.
1233 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1234 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1235 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1236 Remove decls.
1237 (x_mouse_leave): Declare only if WINDOWSNT.
1238 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1239 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1240 USE_X_TOOLKIT.
1241
1675728f
PE
1242 * ftxfont.c: Make symbols static if they're not exported.
1243 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1244 HAVE_FREETYPE.
1245 * font.h (ftxfont_driver): Likewise.
1246
e4cebfca
PE
1247 * xfns.c: Make symbols static if they're not exported.
1248 (x_last_font_name, x_display_info_for_name):
1249 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1250 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1251 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1252 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1253 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1254 (last_show_tip_args): Now static.
1255 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1256 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1257 (x_screen_planes): Remove; unused.
1258 * dispextern.h (x_screen_planes): Remove decl.
1259
5bf46f05
PE
1260 * dispnew.c: Make symbols static if they're not exported.
1261 * dispextern.h (redraw_garbaged_frames, scrolling):
1262 (increment_row_positions): Remove.
1263 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1264 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1265 Now static.
1266 (redraw_garbaged_frames): Remove; unused.
1267
435f4c28
PE
1268 * xfaces.c: Make symbols static if they're not exported.
1269 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1270 Remove decls.
1271 * xterm.h (defined_color): Remove decls.
1272 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1273 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1274 (menu_face_changed_default, defined_color, free_realized_face):
1275 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1276 (ascii_face_of_lisp_face): Remove; unused.
1277
8524aef3
PE
1278 * xdisp.c: Make symbols static if they're not exported.
1279 * dispextern.h (scratch_glyph_row, window_box_edges):
1280 (glyph_to_pixel_coords, set_cursor_from_row):
1281 (get_next_display_element, set_iterator_to_next):
1282 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1283 (show_mouse_face): Remove decls
1284 * frame.h (message_buf_print): Likewise.
1285 * lisp.h (pop_message, set_message, check_point_in_composition):
1286 Likewise.
1287 * xterm.h (set_vertical_scroll_bar): Likewise.
1288 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1289 (message_buf_print, scratch_glyph_row, displayed_buffer):
1290 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1291 (get_next_display_element, show_mouse_face, window_box_edges):
1292 (frame_to_window_pixel_xy, check_point_in_composition):
1293 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1294 (glyph_to_pixel_coords): Remove; unused.
1295
16390cd2
PE
1296 * dired.c (file_name_completion): Now static.
1297
1298 * dbusbind.c (xd_in_read_queued_messages): Now static.
1299
a25f4dfa
PE
1300 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1301 * data.c (circular_list_error): Remove.
1302
14a9c8df
PE
1303 * commands.h (last_point_position, last_point_position_buffer):
1304 (last_point_position_window): Remove decls.
1305 * keyboard.c: Make these variables static.
1306
74ab6df5
PE
1307 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1308 decls.
1309 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1310 (iso_code_class, detect_coding, code_convert_region): Now static.
1311 (encode_coding_gap): Remove; unused.
1312
38dfbee1
PE
1313 * chartab.c (chartab_chars, chartab_bits): Now static.
1314
a2cb4e63
PE
1315 * charset.h (charset_iso_8859_1): Remove decl.
1316 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1317 Now static.
1318
127198fd
PE
1319 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1320 * ccl.c (Vccl_program_table): Now static.
1321 (check_ccl_update): Remove; unused.
1322
d85b608f
PE
1323 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1324 * category.h: ... from here.
1325 * category.c (check_category_table, set_category_set): Now static.
1326
31cd66f3
PE
1327 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1328 * lisp.h: Remove these decls.
1329
c358e587
PE
1330 * buffer.c (buffer_count): Remove unused var.
1331
e78aecca
PE
1332 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1333 so that it's not optimized away.
1334 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1335 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1336 exported only to the debugger.
1337
e192d7d3
PE
1338 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1339 * atimer.h (run_all_atimers): Removed; not exported.
1340
92470028
PE
1341 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1342 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1343 was inaccessible from Lisp.
1344 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1345 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1346
244ed907
PE
1347 alloc.c: Import and export fewer symbols, and remove unused items.
1348 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1349 is defined.
1350 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1351 it's not optimized away by whole-program optimization.
1352 (message_enable_multibyte, free_misc): Remove.
1353 (catchlist, handlerlist, mark_backtrace):
1354 Declare only if BYTE_MARK_STACK.
1355 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1356 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1357 (message_enable_multibyte): Remove decl.
1358 (free_misc, interval_free_list, float_block, float_block_index):
1359 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1360 (cons_free_list, last_marked_index):
1361 Now static.
1362 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1363 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1364 (mark_backtrace): Define only if BYTE_MARK_STACK.
1365 * xdisp.c (message_enable_multibyte): Now static.
1366
61c2b50e 1367 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1368 This makes it easier for human readers (and static analyzers)
1369 to see whether these variables are used from other modules.
1370 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1371 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1372 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1373 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1374 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1375 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1376 * xmenu.c, xselect.c:
1377 Declare Q* vars static if they are not used in other modules.
1378 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1379 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1380 Remove decls of unexported vars.
1381 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1382
95c82688
PE
1383 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1384
16a97296
PE
1385 Make Emacs functions such as Fatom 'static' by default.
1386 This makes it easier for human readers (and static analyzers)
1387 to see whether these functions can be called from other modules.
1388 DEFUN now defines a static function. To make the function external
1389 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1390 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1391 (Finit_image_library):
16a97296
PE
1392 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1393 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1394 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1395 Remove decls, since these functions are now static.
1396 (Funintern, Fget_internal_run_time): New decls, since these functions
1397 were already external.
95c82688 1398
16a97296
PE
1399 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1400 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1401 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1402 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1403 * keyboard.c, keymap.c, lread.c:
1404 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1405 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1406 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1407 Mark functions with DEFUE instead of DEFUN,
1408 if they are used in other modules.
1409 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1410 decls for now-static functions.
1411 * buffer.h (Fdelete_overlay): Remove decl.
1412 * callproc.c (Fgetenv_internal): Mark as internal.
1413 * composite.c (Fremove_list_of_text_properties): Remove decl.
1414 (Fcomposition_get_gstring): New forward static decl.
1415 * composite.h (Fcomposite_get_gstring): Remove decl.
1416 * dired.c (Ffile_attributes): New forward static decl.
1417 * doc.c (Fdocumntation_property): New forward static decl.
1418 * eval.c (Ffetch_bytecode): New forward static decl.
1419 (Funintern): Remove extern decl; now in .h file where it belongs.
1420 * fileio.c (Fmake_symbolic_link): New forward static decl.
1421 * image.c (Finit_image_library): New forward static decl.
1422 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1423 * intervals.h (Fprevious_property_change):
1424 (Fremove_list_of_text_properties): Remove decls.
1425 * keyboard.c (Fthis_command_keys): Remove decl.
1426 (Fcommand_execute): New forward static decl.
1427 * keymap.c (Flookup_key): New forward static decl.
1428 (Fcopy_keymap): Now static.
1429 * keymap.h (Flookup_key): Remove decl.
1430 * process.c (Fget_process): New forward static decl.
1431 (Fprocess_datagram_address): Mark as internal.
1432 * syntax.c (Fsyntax_table_p): New forward static decl.
1433 (skip_chars): Remove duplicate decl.
1434 * textprop.c (Fprevious_property_change): New forward static decl.
1435 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1436 Now internal.
1437 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1438 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1439
785bbd42
PE
1440 * editfns.c (Fformat): Remove unreachable code.
1441
8b913b57
AS
14422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1443
1444 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1445 change. (Bug#8496)
1446
a6744a35
EZ
14472011-04-13 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1450 when at ZV. (Bug#8487)
1451
e7974947
AS
14522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1453
baad03f0
AS
1454 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1455 (Bug#8437)
1456 * keyboard.c (parse_tool_bar_item): Likewise.
1457 * sound.c (sound_cleanup, alsa_close): Likewise.
1458 * termcap.c (tgetent): Likewise.
1459 * xfns.c (x_default_font_parameter): Likewise.
1460 * xsettings.c (read_and_apply_settings): Likewise.
1461
e7974947
AS
1462 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1463 (overrun_check_free): Protoize.
1464
28272684
PE
14652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1468 since callers should never pass a negative size.
1469 Change the signature to match that of plain 'read' and 'write'; see
1470 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1471 * lisp.h: Update prototypes of emacs_write and emacs_read.
1472
11997c76
EZ
14732011-04-11 Eli Zaretskii <eliz@gnu.org>
1474
1475 * xdisp.c (redisplay_window): Don't try to determine the character
1476 position of the scroll margin if the window start point w->startp
e896f03c 1477 is outside the buffer's accessible region. (Bug#8468)
11997c76 1478
8a2cbd72
EZ
14792011-04-10 Eli Zaretskii <eliz@gnu.org>
1480
1481 Fix write-region and its subroutines for buffers > 2GB.
1482 * fileio.c (a_write, e_write): Modify declaration of arguments and
1483 local variables to support buffers larger than 2GB.
1484 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1485
1486 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1487 argument, local variables, and return value.
1488
1489 * lisp.h: Update prototypes of emacs_write and emacs_read.
1490
1491 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1492
4073e537 14932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1494
1ebfdcb6
PE
1495 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1496
b2ded58d
PE
1497 Fix more problems found by GCC 4.6.0's static checks.
1498
7d66342c
PE
1499 * xdisp.c (vmessage): Use a better test for character truncation.
1500
bbf47d44
PE
1501 * charset.c (load_charset_map): <, not <=, for optimization,
1502 and to avoid potential problems with integer overflow.
9248994d 1503 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1504 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1505 * editfns.c (Fformat): Likewise.
1e69125e 1506 * syntax.c (skip_chars): Likewise.
3befa583 1507
e3019616
PE
1508 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1509 This also lets GCC 4.6.0 generate slightly better loop code.
1510
becfa255
PE
1511 * callint.c (Fcall_interactively): <, not <=, for optimization.
1512 (Fcall_interactively): Count the number of arguments produced,
1513 not the number of arguments given. This is simpler and lets GCC
1514 4.6.0 generate slightly better code.
1515
dae0cd48
PE
1516 * ftfont.c: Distingish more carefully between FcChar8 and char.
1517 The previous code passed unsigned char * to a functions like
1518 strlen and xstrcasecmp that expect char *, which does not
1519 conform to the C standard.
1520 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1521 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1522 char * when the C standard requires it.
1523
76032d70
PE
1524 * keyboard.c (read_char): Remove unused var.
1525
eb3f1cc8
PE
1526 * eval.c: Port to Windows vsnprintf (Bug#8435).
1527 Include <limits.h>.
1528 (SIZE_MAX): Define if the headers do not.
1529 (verror): Do not give up if vsnprintf returns a negative count.
1530 Instead, grow the buffer. This ports to Windows vsnprintf, which
1531 does not conform to C99. Problem reported by Eli Zaretskii.
1532 Also, simplify the allocation scheme, by avoiding the need for
1533 calling realloc, and removing the ALLOCATED variable.
1534
70476b54
PE
1535 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1536
12020a9e
PE
1537 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1538 But keep the doprint source code for now, as we might revamp it
1539 and use it again (Bug#8435).
ea6c7ae6
PE
1540 * lisp.h (doprnt): Remove.
1541 * Makefile.in (base_obj): Remove doprnt.o.
1542 * deps.mk (doprnt.o): Remove.
1543
5fdb398c
PE
1544 error: Print 32- and 64-bit integers portably (Bug#8435).
1545 Without this change, on typical 64-bit hosts error ("...%d...", N)
1546 was used to print both 32- and 64-bit integers N, which relied on
1547 undefined behavior.
1548 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1549 New macro.
1550 * lisp.h (error, verror): Mark as printf-like functions.
1551 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1552 Report overflow in size calculations when allocating printf buffer.
1553 Do not truncate output string at its first null byte.
1554 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1555 Truncate the output at a character boundary, since vsnprintf does not
1556 do that.
1557 * charset.c (check_iso_charset_parameter): Convert internal
1558 character to string before calling 'error', since %c now has the
1559 printf meaning.
1560 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1561 overflow when computing char to be passed to 'error'. Do not
1562 pass Lisp_Object to 'error'; pass the integer instead.
1563 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1564 formatted with plain %d.
1565
b189fa66
PE
1566 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1567
bff87ef0
PE
1568 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1569
7e2cac20
PE
1570 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1571
ce4d90b5
PE
1572 * xterm.c (x_catch_errors): Remove duplicate declaration.
1573
266c9547
PE
1574 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1575
79c49ad2
PE
1576 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1577
368f4090
JM
15782011-04-10 Jim Meyering <meyering@redhat.com>
1579
1580 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1581 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1582 return ssize_t not "int", and use size_t as the buffer length.
1583 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1584 * gnutls.h: Update declarations.
1585 * process.c (read_process_output): Use ssize_t, to match.
1586 (send_process): Likewise.
1587
a32d4040
CY
15882011-04-09 Chong Yidong <cyd@stupidchicken.com>
1589
1590 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1591
8546720e 15922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1593
8546720e
GM
1594 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1595 unsigned char, to match FcChar8 type definition.
aac0c6e3 1596
8546720e
GM
1597 * xterm.c (handle_one_xevent):
1598 * xmenu.c (create_and_show_popup_menu):
1599 * xselect.c (x_decline_selection_request)
1600 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1601
0a2f5c1a 16022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1603
1604 Fix some uses of `int' instead of EMACS_INT.
1605 * search.c (string_match_1, fast_string_match)
1606 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1607 (scan_buffer, find_next_newline_no_quit)
1608 (find_before_next_newline, search_command, Freplace_match)
1609 (Fmatch_data): Make some `int' variables be EMACS_INT.
1610
1611 * xdisp.c (display_count_lines): 3rd argument and return value now
1612 EMACS_INT. All callers changed.
1613 (pint2hrstr): Last argument is now EMACS_INT.
1614
1615 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1616 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1617 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1618 (decode_coding_utf_16, decode_coding_emacs_mule)
1619 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1620 (decode_coding_ccl, decode_coding_charset)
1621 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1622 (decode_coding_iso_2022, decode_coding_emacs_mule)
1623 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1624 <char_offset, last_offset>: Declare EMACS_INT.
1625 (encode_coding_utf_8, encode_coding_utf_16)
1626 (encode_coding_emacs_mule, encode_invocation_designation)
1627 (encode_designation_at_bol, encode_coding_iso_2022)
1628 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1629 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1630 Declare EMACS_INT.
1631 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1632 (encode_invocation_designation): Last argument P_NCHARS is now
1633 EMACS_INT.
1634 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1635 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1636
1637 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1638 All users changed.
1639
1640 * ccl.c (Fccl_execute_on_string): Declare some variables
1641 EMACS_INT.
1642
8546720e 16432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1644
1645 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1646
4e19a977
CS
16472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1648
1649 * process.c (Fformat_network_address): Doc fix.
1650
87302331
R
16512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1652
1653 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1654
cbb59342
CY
16552011-04-08 Chong Yidong <cyd@stupidchicken.com>
1656
1657 * keyboard.c (read_char): Call Lisp function help-form-show,
1658 instead of using internal_with_output_to_temp_buffer.
1659 (Qhelp_form_show): New var.
e0d38eeb 1660 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1661
1662 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1663
1664 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1665
e67a13ab
CY
16662011-04-06 Chong Yidong <cyd@stupidchicken.com>
1667
1668 * process.c (Flist_processes): Removed to Lisp.
1669 (list_processes_1): Deleted.
1670
973f782d
EZ
16712011-04-06 Eli Zaretskii <eliz@gnu.org>
1672
7c106b1e
EZ
1673 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1674
973f782d
EZ
1675 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1676
41cf7d1a 16772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1678
ca23cc88
PE
1679 Fix more problems found by GCC 4.6.0's static checks.
1680
f390e2d5
PE
1681 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1682
42eea0d0
PE
1683 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1684
b69769da 1685 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1686
f9541e84
PE
1687 * xdisp.c (vmessage): Mark as a printf-like function.
1688
13841b55
PE
1689 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1690
c136c10f
PE
1691 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1692
5e2d4a30
PE
1693 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1694 printf-like functions.
1695 (tiff_load): Add casts to remove these marks before passing them
1696 to system-supplied API.
1697
583f48b9
PE
1698 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1699
b25d760e
PE
1700 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1701 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1702 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1703 directly, rather than having caller test rule sign. This avoids
1704 some unnecessary tests.
1705 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1706 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1707 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1708
bc7b6697 1709 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1710 (xfont_open): Avoid unnecessary tests.
bc7b6697 1711
27ccc379
PE
1712 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1713
dcd5c89a
PE
1714 * composite.h, composite.c (composition_gstring_put_cache):
1715 Use EMACS_INT, not int, for length.
1716
b13a45c6
PE
1717 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1718 breaking out part of COMPOSITION_DECODE_RULE.
1719 (COMPOSITION_DECODE_RULE): Use it.
1720 * composite.c (get_composition_id): Remove unused local vars,
1721 by using the new macro.
1722
1e792e4d
PE
1723 * textprop.c (set_text_properties_1): Change while to do-while,
1724 since the condition is always true at first.
1725
dc6c6455 1726 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1727 (interval_deletion_adjustment): Return unsigned value.
1728 All uses changed.
dc6c6455 1729
aba7731a
PE
1730 * process.c (list_processes_1, create_pty, read_process_output):
1731 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1732 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1733 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1734 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1735 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1736
fdfc4bf3
PE
1737 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1738
fca8fe46 1739 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1740 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1741
06a0259a 1742 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1743 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1744 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1745
e7b9e80f
PE
1746 * print.c (print_error_message): Avoid int overflow.
1747
56201685
PE
1748 * font.c (font_list_entities): Redo for clarity,
1749 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1750
78834453 1751 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1752 (font_score): Avoid potential overflow in diff calculation.
78834453 1753
0bc0b309 1754 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1755 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1756
e610eaca
PE
1757 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1758
b895abce
PE
1759 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1760 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1761 can always succeed if overflow has undefined behavior.
1762
1f1d9321 1763 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1764 (wordify): Omit three unnecessary tests.
1f1d9321 1765
c59478bc
PE
1766 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1767 All callers changed. This avoids the need for an unused var.
1768
79b73827
PE
1769 * casefiddle.c (casify_region): Remove var that is set but not used.
1770
a4db5dfe
PE
1771 * dired.c (file_name_completion): Remove var that is set but not used.
1772
43aae36e
PE
1773 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1774
2a47c44d 1775 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1776 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1777
a37c69bf
PE
1778 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1779 Check for integer overflow on size calculations.
1780
328ab8e7
PE
1781 * buffer.c (Fprevious_overlay_change): Remove var that is set
1782 but not used.
1783
e5a2a5cb
PE
1784 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1785 Remove vars that are set but not used.
8d84a6eb 1786 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1787 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1788
a60e5f68
PE
1789 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1790
f661cb61 1791 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1792 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1793
f0397f5a
PE
1794 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1795 that are set but not used.
1796
8664db06 1797 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1798 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1799
6abdaa4a
PE
1800 * xselect.c (x_get_local_selection, x_handle_property_notify):
1801 Remove vars that are set but not used.
1802
0ce7538d 1803 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1804 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1805
9ae848fc
PE
1806 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1807 Remove var that is set but not used.
0b918413
PE
1808 (scroll_bar_windows_size): Now size_t, not int.
1809 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1810 Check for overflow.
9ae848fc 1811
a5a62657
PE
1812 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1813 (map_tty_color) [!defined MSDOS]: Likewise.
1814
5c5cdd39
PE
1815 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1816
66ebf983
PE
1817 * coding.c: Remove vars that are set but not used.
1818 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1819 All callers changed.
1820 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1821 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1822 (decode_coding_charset): Remove vars that are set but not used.
1823
1be4d761
PE
1824 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1825 that is set but not used.
1826
47553fa8
PE
1827 * print.c (print_object): Remove var that is set but not used.
1828
1f7196bf 1829 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1830 The gnulib version avoids calling malloc in the usual case,
1831 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1832 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1833 * filelock.c (current_lock_owner): Likewise.
1834 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1835 * sysdep.c: Include allocator.h, careadlinkat.h.
1836 (emacs_no_realloc_allocator): New static constant.
1837 (emacs_readlink): New function.
fdb61804
PE
1838 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1839 ../lib/careadlinkat.h.
d1fdcab7 1840
f84c17c7
SM
18412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1842
1843 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1844 first non-nil return value).
1845
ef3862ad
JD
18462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1847
1848 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1849 if not defined (Bug#8403).
1850
376a7006
JB
18512011-04-02 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * xdisp.c (display_count_lines): Remove parameter `start',
1854 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1855 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1856 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1857 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1858 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1859 and thereabouts. All callers changed.
1860 (get_per_char_metric): Remove parameter `f', unused since
1861 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1862
6ca3801d
JM
18632011-04-02 Jim Meyering <meyering@redhat.com>
1864
1865 do not dereference NULL upon failed strdup
1866 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1867 (ns_get_family): Likewise.
1868
d8e2b5ba
JB
18692011-04-02 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1872
8c74fcbd
JD
18732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1876 later (Bug#8403).
1877
7200d79c
SM
18782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1879
03408648 1880 Add lexical binding.
7200d79c 1881
03408648
SM
1882 * window.c (Ftemp_output_buffer_show): New fun.
1883 (Fsave_window_excursion):
1884 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1885
1886 * lread.c (lisp_file_lexically_bound_p): New function.
1887 (Fload): Bind Qlexical_binding.
1888 (readevalloop): Remove `evalfun' arg.
1889 Bind Qinternal_interpreter_environment.
1890 (Feval_buffer): Bind Qlexical_binding.
1891 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1892 Mark as dynamic.
1893 (syms_of_lread): Declare `lexical-binding'.
1894
1895 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1896
1897 * keyboard.c (eval_dyn): New fun.
1898 (menu_item_eval_property): Use it.
ca105506
SM
1899
1900 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1901
03408648
SM
1902 * fns.c (concat, mapcar1): Accept byte-code-functions.
1903
1904 * eval.c (Fsetq): Handle lexical vars.
1905 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1906 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1907 (FletX, Flet): Obey lexical binding.
1908 (Fcommandp): Handle closures.
1909 (Feval): New `lexical' arg.
1910 (eval_sub): New function extracted from Feval. Use it almost
1911 everywhere where Feval was used. Look up vars in lexical env.
1912 Handle closures.
1913 (Ffunctionp): Move from subr.el.
1914 (Ffuncall): Handle closures.
1915 (apply_lambda): Remove `eval_flags'.
1916 (funcall_lambda): Handle closures and new byte-code-functions.
1917 (Fspecial_variable_p): New function.
1918 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1919 but without exporting it to Lisp.
23aba0ea 1920
23aba0ea 1921 * doc.c (Fdocumentation, store_function_docstring):
03408648 1922 * data.c (Finteractive_form): Handle closures.
23aba0ea 1923
03408648
SM
1924 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1925 interactive spec.
ba83908c 1926
03408648
SM
1927 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1928 byte-codes.
1929 (exec_byte_code): New function extracted from Fbyte_code to handle new
1930 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1931
03408648 1932 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1933
03408648 1934 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1935
e2abce01
JB
19362011-03-31 Juanma Barranquero <lekktu@gmail.com>
1937
1938 * xdisp.c (redisplay_internal): Fix prototype.
1939
63696a73 19402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1941
63696a73
EZ
1942 * xdisp.c (SCROLL_LIMIT): New macro.
1943 (try_scrolling): Use it when setting scroll_limit. Limit
1944 scrolling to 100 screen lines.
1945 (redisplay_window): Even when falling back on "recentering",
1946 position point in the window according to scroll-conservatively,
1947 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1948
1949 (try_scrolling): When point is above the window, allow searching
1950 as far as scroll_max, or one screenful, to compute vertical
1951 distance from PT to the scroll margin position. This prevents
1952 try_scrolling from unnecessarily failing when
1953 scroll-conservatively is set to a value slightly larger than the
1954 window height. Clean up the case of PT below the margin at bottom
1955 of window: scroll_max can no longer be INT_MAX. When aggressive
1956 scrolling is in use, don't let point enter the opposite scroll
1957 margin as result of the scroll.
1958 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1959 threshold of 100 lines for never-recentering scrolling.
1960
e4cc2dfc
JB
19612011-03-31 Juanma Barranquero <lekktu@gmail.com>
1962
1963 * dispextern.h (move_it_by_lines):
1964 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1965 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1966 (message_log_check_duplicate): Remove parameters `prev_bol' and
1967 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1968 (redisplay_internal): Remove parameter `preserve_echo_area',
1969 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1970
1971 * indent.c (Fvertical_motion):
1972 * window.c (window_scroll_pixel_based, Frecenter):
1973 Don't pass `need_y_p' to `move_it_by_lines'.
1974
1c470562
SM
19752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1976
44f230aa
SM
1977 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1978 steal a few bits to be more compact.
1979 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1980 Remove unneeded casts.
1981
1c470562
SM
1982 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1983
888adce9
ZK
19842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1985
1986 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1987 binding" message (bug#7967).
1988
f838ed7b
PE
19892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1990
77861b95
PE
1991 Fix more problems found by GCC 4.6.0's static checks.
1992
de6dbc14
PE
1993 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1994 Remove unused local var.
1995
f838ed7b
PE
1996 * editfns.c (Fmessage_box): Remove unused local var.
1997
792c7b2b
PE
1998 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1999 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2000 Omit unused local vars.
c499e557 2001 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2002 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2003 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2004 Omit unused local var.
2005
ba0165e1
PE
2006 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2007 Don't assume string length fits in int.
32ad8845 2008 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2009 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2010
3c59b4c9
PE
2011 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2012 instead of alloca (Bug#8344).
2013
a3eed478 2014 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2015 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2016
eb4d412d
PE
2017 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2018
1658b401
PE
2019 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2020 concerns.
2021
2022 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2023
2024 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2025
9a2c6e05
PE
2026 * keyboard.c (syms_of_keyboard): Use the same style as later
2027 in this function when indexing through an array. This also
2028 works around GCC bug 48267.
2029
03d0a109
PE
2030 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2031
44f730c8
PE
2032 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2033
fe75f926
PE
2034 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2035 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2036
ffa8c828
PE
2037 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2038 This avoids undefined behavior on integer overflow, and is a bit
2039 more convenient anyway since it is compared to a size_t variable.
2040
c5101a77
PE
2041 Variadic C functions now count arguments with size_t, not int.
2042 This avoids an unnecessary limitation on 64-bit machines, which
2043 caused (substring ...) to crash on large vectors (Bug#8344).
2044 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2045 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2046 All variadic functions and their callers changed accordingly.
c5101a77
PE
2047 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2048 * data.c (arith_driver, float_arith_driver): Likewise.
2049 * editfns.c (general_insert_function): Likewise.
2050 * eval.c (struct backtrace.nargs, interactive_p)
2051 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2052 (funcall_lambda, mark_backtrace): Likewise.
2053 * fns.c (concat): Likewise.
2054 * frame.c (x_set_frame_parameters): Likewise.
2055 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2056 0 if not found, not -1. All callers changed.
2057
dd3f25f7
PE
2058 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2059 (stack_copy_size): Now size_t, not int.
2060 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2061
461c2ab9
JB
20622011-03-28 Juanma Barranquero <lekktu@gmail.com>
2063
2064 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2065 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2066 All callers changed.
2067
2068 * lisp.h (multibyte_char_to_unibyte):
2069 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2070 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2071 * character.h (CHAR_TO_BYTE8):
2072 * cmds.c (internal_self_insert):
2073 * editfns.c (general_insert_function):
2074 * keymap.c (push_key_description):
2075 * search.c (Freplace_match):
2076 * xdisp.c (message_dolog, set_message_1): All callers changed.
2077
f6d62986
SM
20782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2079
2080 * keyboard.c (safe_run_hook_funcall): New function.
2081 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2082 don't set the hook to nil, but remove the offending function instead.
2083 (Qcommand_hook_internal): Remove, unused.
2084 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2085 Vcommand_hook_internal.
2086
2087 * eval.c (enum run_hooks_condition): Remove.
2088 (funcall_nil, funcall_not): New functions.
2089 (run_hook_with_args): Call each function through a `funcall' argument.
2090 Remove `cond' argument, now redundant.
2091 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2092 (Frun_hook_with_args_until_failure): Adjust accordingly.
2093 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2094
1db5b1ad
JB
20952011-03-28 Juanma Barranquero <lekktu@gmail.com>
2096
2097 * dispextern.h (string_buffer_position): Remove declaration.
2098
2099 * print.c (strout): Remove parameter `multibyte', unused since
2100 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2101
2102 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2103 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2104 All callers changed.
2105
2106 * w32.c (_wsa_errlist): Use braces for struct initializers.
2107
2108 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2109 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2110 All callers changed.
2111 (string_buffer_position): Likewise. Also, make static (it's never
2112 used outside xdisp.c).
2113 (cursor_row_p): Remove parameter `w', unused since
2114 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2115 (decode_mode_spec): Remove parameter `precision', introduced during
2116 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2117 All callers changed.
2118
5ffb62aa
JD
21192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2122
461c2ab9 21232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2124
2125 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2126 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2127 (ns_update_auto_hide_menu_bar): New functions.
2128 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2129 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2130 ns_constrain_all_frames.
2131 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2132 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2133
5c380ffb
JD
21342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2135
2136 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2137
9af30bdf
GM
21382011-03-27 Glenn Morris <rgm@gnu.org>
2139
2140 * syssignal.h: Replace RETSIGTYPE with void.
2141 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2142 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2143 Replace SIGTYPE with void everywhere.
2144 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2145 * s/template.h (SIGTYPE): Remove commented out definition.
2146
e2abce01
JB
21472011-03-26 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2150 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2151
f868cd8a
JB
21522011-03-26 Juanma Barranquero <lekktu@gmail.com>
2153
59eb0929
JB
2154 * w32.c (read_unc_volume): Use parameter `henum', instead of
2155 global variable `wget_enum_handle'.
2156
2157 * keymap.c (describe_vector): Remove parameters `indices' and
2158 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2159 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2160
f868cd8a
JB
2161 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2162
2163 * keyboard.c (timer_check): Remove parameter `do_it_now',
2164 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2165 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2166 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2167
2168 * keyboard.c (read_char):
2169 * w32menu.c (w32_menu_display_help):
2170 * xmenu.c (show_help_event, menu_help_callback):
2171 Adjust calls to `show_help_echo'.
2172
2173 * gtkutil.c (xg_maybe_add_timer):
2174 * keyboard.c (readable_events):
2175 * process.c (wait_reading_process_output):
2176 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2177
2178 * insdel.c (adjust_markers_gap_motion):
2179 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2180 (gap_left, gap_right): Don't call it.
2181
2ecf6fdb
CY
21822011-03-25 Chong Yidong <cyd@stupidchicken.com>
2183
2184 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2185 incurred during fontification.
2186
6b1f9ba4
JB
21872011-03-25 Juanma Barranquero <lekktu@gmail.com>
2188
2189 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2190 (DEFVAR_PER_BUFFER): Don't pass it.
2191
2192 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2193 (scrolling_window): Don't pass it.
2194
0f4a96b5
JB
21952011-03-25 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2198
2199 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2200 and `suffix'.
2201 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2202 of variables specific to SELinux and computation of `encoded_absname'.
2203
2204 * image.c (XPutPixel): Remove unused variable `height'.
2205
2206 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2207
2208 * unexw32.c (get_section_info): Remove unused variable `section'.
2209
2210 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2211 (system_process_attributes): Remove unused variable `sess'.
2212 (sys_read): Remove unused variable `err'.
2213
2214 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2215 (w32_wnd_proc): Remove unused variable `isdead'.
2216 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2217 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2218 (x_create_tip_frame): Remove unused variable `tem'.
2219
2220 * w32inevt.c (w32_console_read_socket):
2221 Remove unused variable `no_events'.
2222
2223 * w32term.c (x_draw_composite_glyph_string_foreground):
2224 Remove unused variable `width'.
2225
1149507c
JB
22262011-03-24 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * w32term.c (x_set_glyph_string_clipping):
2229 Don't pass uninitialized region to CombineRgn.
2230
9c88f339
JB
22312011-03-23 Juanma Barranquero <lekktu@gmail.com>
2232
2233 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2234 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2235 (Fx_close_connection): Remove unused variable `i'.
2236
2237 * w32font.c (w32font_draw): Return number of glyphs.
2238 (w32font_open_internal): Remove unused variable `i'.
2239 (w32font_driver): Add missing initializer.
2240
2241 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2242 (fill_in_menu): Remove unused variable `items_added'.
2243
2244 * w32term.c (last_mouse_press_frame): Remove static global variable.
2245 (w32_clip_to_row): Remove unused variable `f'.
2246 (x_delete_terminal): Remove unused variable `i'.
2247
2248 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2249 (NOTHING): Remove unused static global variable.
2250 (uniscribe_check_otf): Remove unused variable `table'.
2251 (uniscribe_font_driver): Add missing initializers.
2252
dee091a3
JD
22532011-03-23 Julien Danjou <julien@danjou.info>
2254
2255 * term.c (Fsuspend_tty, Fresume_tty):
2256 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2257 * window.c (temp_output_buffer_show):
2258 * insdel.c (signal_before_change):
2259 * frame.c (Fhandle_switch_frame):
2260 * fileio.c (Fdo_auto_save):
2261 * emacs.c (Fkill_emacs):
2262 * editfns.c (save_excursion_restore):
2263 * cmds.c (internal_self_insert):
2264 * callint.c (Fcall_interactively):
2265 * buffer.c (Fkill_all_local_variables):
2266 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2267 Use Frun_hooks.
0f4a96b5 2268 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2269 unconditionnaly since it does the check itself.
2270
2c520ab5 22712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2272
c9c49752
PE
2273 Fix more problems found by GCC 4.5.2's static checks.
2274
8abc3f12
PE
2275 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2276 the first time through the loop, since we know p0 < p1 then.
2277 This also avoids a gcc -Wstrict-overflow warning.
2278
a2d26660
PE
2279 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2280 leading to a memory leak, possible in functions like
2281 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2282 of objects (Bug#8318).
a2d26660 2283
916c72e9
PE
2284 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2285 that could (at least in theory) be that large.
2286
19ab8a18
PE
2287 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2288 This is less likely to overflow, and avoids undefined behavior if
2289 overflow does occur. All callers changed. Use strtoul to scan
2290 for the unsigned long integer.
b7cbbd6f
PE
2291 (pint2hrstr): Simplify and tune code slightly.
2292 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2293
f0641eff
PE
2294 * scroll.c (do_scrolling): Work around GCC bug 48228.
2295 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2296
7f650bb9
PE
2297 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2298 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2299 (validate_x_resource_name): Simplify count usage.
2300 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2301
37dd57d1
PE
2302 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2303 fail (Bug#8306).
81e56e61 2304
699979fc 2305 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2306
401bf9b4
PE
2307 * process.c (Fmake_network_process): Use socklen_t, not int,
2308 where POSIX says socklen_t is required in portable programs.
2309 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2310 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2311 (Fmake_network_process, server_accept_connection):
2312 (wait_reading_process_output, read_process_output):
2313 Likewise.
2314
b93aacde
PE
2315 * process.c: Rename or move locals to avoid shadowing.
2316 (list_processes_1, Fmake_network_process):
2317 (read_process_output_error_handler, exec_sentinel_error_handler):
2318 Rename or move locals.
4dc343ee 2319 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2320 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2321 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2322 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2323 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2324
af8a867c 2325 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2326 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2327 Include tparam.h instead, since it declares them.
af8a867c
PE
2328 * cm.h (PC): Remove extern decl; tparam.h now does this.
2329 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2330 * terminfo.c: Include tparam.h, to check interfaces.
2331 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2332 (tparam): Adjust signature to match interface in tparam.h;
2333 this removes some undefined behavior. Check that outstring and len
2334 are zero, which they always are with Emacs.
2335 * tparam.h (PC, BC, UP): New extern decls.
2336
0248044d 2337 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2338 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2339
8ff096c1 2340 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2341 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2342 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2343 (ftfont_list): Remove unused local.
49eaafba
PE
2344 (get_adstyle_property, ftfont_pattern_entity):
2345 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2346 Rename locals to avoid shadowing.
8ff096c1 2347
e2be39f6
PE
2348 * xfont.c (xfont_list_family): Mark var as initialized.
2349
c9735e30
PE
2350 * xml.c (make_dom): Now static.
2351
8f5201ae
PE
2352 * composite.c (composition_compute_stop_pos): Rename local to
2353 avoid shadowing.
b246f932
PE
2354 (composition_reseat_it): Remove unused locals.
2355 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2356 (composition_update_it): Mark var as initialized.
11b61122
PE
2357 (find_automatic_composition): Mark vars as initialized,
2358 with a FIXME (Bug#8290).
8f5201ae 2359
760fbc2c
PE
2360 character.h: Rename locals to avoid shadowing.
2361 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2362 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2363 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2364 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2365 to avoid shadowing.
2366
ff08eb85
PE
2367 * textprop.c (property_change_between_p): Remove; unused.
2368
fc7bf025
PE
2369 * intervals.c (interval_start_pos): Now static.
2370
235d7abc
PE
2371 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2372
44f230aa
SM
2373 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2374 Rename locals to avoid shadowing.
3e7d6594 2375
50060332
PE
2376 * sound.c (wav_play, au_play, Fplay_sound_internal):
2377 Fix pointer signedness.
d01f234b 2378 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2379 (wav_play): Initialize a variable to 0, to prevent undefined
2380 behavior (Bug#8278).
50060332 2381
c4fc4e30
PE
2382 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2383
918436ed
PE
2384 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2385
c939f91b
PE
2386 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2387 clobbering (Bug#8298).
b9c7f648
PE
2388 * sysdep.c (sys_subshell): Likewise.
2389 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2390
6bd8c144
PE
2391 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2392 This should get cleaned up, so that child_setup has the
2393 same signature on all platforms.
2394
7710357c 2395 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2396 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2397
c59da222
CY
23982011-03-22 Chong Yidong <cyd@stupidchicken.com>
2399
2400 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2401 not to be necessary, and produces flickering.
2402
66b87493
GM
24032011-03-20 Glenn Morris <rgm@gnu.org>
2404
2405 * config.in: Remove file.
2406
45b6f6d5
JB
24072011-03-20 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2410 are now in src/globals.h.
2411 (syms_of_minibuf): Remove spurious & from previous change.
2412
3ec03f7e
LL
24132011-03-20 Leo <sdl.web@gmail.com>
2414
2415 * minibuf.c (completing-read-function): New variable.
2416 (completing-read-default): Rename from completing-read.
2417 (completing-read): Call completing-read-function.
2418
b14e3e21
CY
24192011-03-19 Juanma Barranquero <lekktu@gmail.com>
2420
2421 * xfaces.c (Fx_load_color_file):
2422 Read color file from absolute filename (bug#8250).
2423
f2b726e6
JB
24242011-03-19 Juanma Barranquero <lekktu@gmail.com>
2425
2426 * makefile.w32-in: Update dependencies.
2427
09f6ff02
EZ
24282011-03-17 Eli Zaretskii <eliz@gnu.org>
2429
2430 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2431
29a6015a
PE
24322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2433
a3a6c54e
PE
2434 Fix more problems found by GCC 4.5.2's static checks.
2435
b766f867
PE
2436 * process.c (make_serial_process_unwind, send_process_trap):
2437 (sigchld_handler): Now static.
2438
be02381c
PE
2439 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2440 That way, the code declares only the vars that it needs.
2441 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2442 * s/cygwin.h (PTY_ITERATION): Likewise.
2443 * s/darwin.h (PTY_ITERATION): Likewise.
2444 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2445
57048744
PE
2446 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2447 * process.c (allocate_pty): Don't declare stb unless it's needed.
2448
7914961c 2449 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2450 (CONSTANTLIM): Remove; unused.
2451 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2452 Define only if needed.
7914961c 2453
b3967b18
PE
2454 * unexelf.c (unexec): Name an expression,
2455 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2456 Use a different way to cause a compilation error if anyone uses
2457 n rather than nn, a way that does not involve shadowing.
73366a00 2458 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2459
29a6015a
PE
2460 * deps.mk (unexalpha.o): Remove; unused.
2461
43cfc33e 2462 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2463 * unexec.h: New file.
ce701a33
PE
2464 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2465 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2466 Depend on unexec.h.
2467 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2468 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2469 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2470 Change as necessary to match prototype in unexec.h.
ce701a33 2471
01f44d5a
PE
2472 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2473 shadowing.
4f63c6bb 2474 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2475
a6670b0b
PE
2476 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2477 Rename locals to avoid shadowing.
2478
cef2010d 2479 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2480 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2481
d4d7173a
PE
2482 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2483
f08b802a
PE
2484 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2485 warning when compiling print.c.
2486
3ddb0639
PE
2487 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2488 instead of using an uninitialized var.
5ad03b97 2489 (font_sort_entities): Mark var as initialized.
3ddb0639 2490
170a2692
PE
2491 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2492
e663c700
PE
2493 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2494 pointers to constants.
89bc529a 2495 (font_parse_fcname): Remove unused vars.
7b81e2d0 2496 (font_delete_unmatched): Now static.
ea838e10 2497 (font_get_spec): Remove; unused.
13a547c6
PE
2498 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2499 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2500 Rename or move locals to avoid shadowing.
e663c700 2501
2a80c887 2502 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2503 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2504
1384fa33 2505 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2506 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2507
8b2c52e9
PE
2508 * alloc.c (mark_backtrace): Move decl from here ...
2509 * lisp.h: ... to here, so that it can be checked.
2510
475545b5 2511 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2512 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2513 (lisp_indirect_variable): Name an expression,
2514 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2515 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2516
b1349114 2517 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2518 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2519 Use const pointer when appropriate.
b1349114 2520
a2928364
PE
2521 * lisp.h (get_system_name, get_operating_system_release):
2522 Move decls here, to check interfaces.
2523 * process.c (get_operating_system_release): Move decl to lisp.h.
2524 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2525 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2526 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2527 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2528 (Fformat_time_string, Fencode_time, Finsert_char):
2529 (Ftranslate_region_internal, Fformat):
2530 Rename or remove local vars to avoid shadowing.
9710023e 2531 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2532
a415e694
PE
2533 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2534 avoid shadowing.
2535
8ef4622d
PE
2536 * lisp.h (eassert): Check that the argument compiles, even if
2537 ENABLE_CHECKING is not defined.
2538
946f9a5b
PE
2539 * data.c (Findirect_variable): Name an expression, to avoid
2540 gcc -Wbad-function-cast warning.
112396d6 2541 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2542 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2543 (Fmake_variable_buffer_local, Fmake_local_variable):
2544 Mark variables as initialized.
52746918 2545 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2546
e5aab7e7 2547 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2548 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2549 Rename locals to avoid shadowing.
dff45157
PE
2550 (mark_stack): Move local variables into the #ifdef region where
2551 they're used.
7bc26fdb
PE
2552 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2553 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2554 needed otherwise.
2555 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2556 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2557 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2558
e5aab7e7
PE
2559 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2560 avoids undefined behavior in theory.
2561
4da60324
PE
2562 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2563
88043301
PE
2564 Use functions, not macros, for up- and down-casing (Bug#8254).
2565 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2566 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2567 to use the following functions instead of these macros.
2568 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2569 EMACS_INT, since callers assume the returned value fits in int.
2570 (upcase1): Likewise, for UPCASE_TABLE.
2571 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2572 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2573 the race-condition problem in the old DOWNCASE.
88043301 2574
19ed5445
PE
2575 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2576 Rename locals to avoid shadowing.
2577 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2578 (regex_compile, re_search_2, re_match_2_internal):
2579 Remove unused local vars.
952db0d7
PE
2580 (FREE_VAR): Rewrite so as not to use empty "else",
2581 which gcc can warn about.
da053e48 2582 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2583 (RETALLOC_IF): Define only if needed.
2584 (WORDCHAR_P): Likewise. This one is never needed, but is used
2585 only in a comment talking about a compiler bug, so put inside
2586 the #if 0 of that comment.
2587 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2588 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2589 Remove; unused.
19ed5445 2590
1f3561e4 2591 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2592 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2593 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2594
ded6f8f7
PE
2595 * search.c (simple_search): Remove unused var.
2596
dbd37a95
PE
2597 * dired.c (compile_pattern): Move decl from here ...
2598 * lisp.h: ... to here, so that it can be checked.
2599 (struct re_registers): New forward decl.
2600
7e47afad
PE
2601 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2602
85f24f61
PE
2603 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2604 All uses changed.
2605 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2606 Rename locals to avoid shadowing.
5671df8f 2607 (Fvertical_motion): Mark locals as initialized.
85f24f61 2608
181aa2be 2609 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2610 (casify_region): Mark local as initialized.
181aa2be 2611
930d429c
PE
2612 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2613
7082eac6
PE
2614 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2615 New macros, so that the caller can use some names other than
2616 gcpro1, gcpro2, etc.
2617 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2618 of the new macros.
2619 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2620 argument, for consistency with GCPRO2_VAR, etc: it is now the
2621 prefix of the variable, not the variable itself. All uses
2622 changed.
38b2c076
PE
2623 * dired.c (directory_files_internal, file_name_completion):
2624 Rename locals to avoid shadowing.
2625
15206ed9
PE
2626 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2627 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2628 dired.c's scmp function, had undefined behavior.
2629 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2630 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2631 * buffer.h: ... to here, because these macros use current_buffer,
2632 and the new implementation with inline functions needs to have
2633 current_buffer in scope now, rather than later when the macros
2634 are used.
2635 (downcase, upcase1): New static inline functions.
2636 (DOWNCASE, UPCASE1): Reimplement using these functions.
2637 This avoids undefined behavior in expressions like
2638 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2639 from race conditions in accessing the global variables
2640 case_temp1 and case_temp2.
2641 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2642 * lisp.h (case_temp1, case_temp2): Remove their decls.
2643 * character.h (ASCII_CHAR_P): Move from here ...
2644 * lisp.h: ... to here, so that the inline functions mentioned
2645 above can use them.
2646
4a6bea26
PE
2647 * dired.c (directory_files_internal_unwind): Now static.
2648
f14b7e14
PE
2649 * fileio.c (file_name_as_directory, directory_file_name):
2650 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2651 Now static.
2893f146
PE
2652 (file_name_as_directory): Use const pointers when appropriate.
2653 (Fexpand_file_name): Likewise. In particular, newdir might
2654 point at constant storage, so make it a const pointer.
fd4ead52 2655 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2656 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2657 signedness issues.
f839df0c
PE
2658 (Fset_file_times, Finsert_file_contents, auto_save_error):
2659 Rename locals to avoid shadowing.
f14b7e14 2660
5716756e 2661 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2662 (Ftry_completion, Fall_completions): Rename or remove locals
2663 to avoid shadowing.
5716756e 2664
b4c3046a
PE
2665 * marker.c (bytepos_to_charpos): Remove; unused.
2666
b45db522
PE
2667 * lisp.h (verify_bytepos, count_markers): New decls,
2668 so that gcc does not warn that these functions aren't declared.
2669
85876d07
PE
2670 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2671 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2672 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2673 (copy_text): Remove unused local var.
85876d07 2674
03d78a21 2675 * filelock.c (within_one_second): Now static.
b3dd38ab 2676 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2677
5df8f01b
PE
2678 * buffer.c (fix_overlays_before): Mark locals as initialized.
2679 (fix_start_end_in_overlays): Likewise. This function should be
2680 simplified by using pointers-to-pointers, but that's a different
2681 matter.
b1d876f1 2682 (switch_to_buffer_1): Now static.
8f54f30a
PE
2683 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2684 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2685
a70072c9 2686 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2687 Fix pointer signedness issue.
edced198
PE
2688 (sys_subshell): Mark local as volatile if checking for lint,
2689 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2690 (MAXPATHLEN): Define only if needed.
a70072c9 2691
a0977c44
PE
2692 * process.c (serial_open, serial_configure): Move decls from here ...
2693 * systty.h: ... to here, so that they can be checked.
2694
a884fdcc
PE
2695 * fns.c (get_random, seed_random): Move extern decls from here ...
2696 * lisp.h: ... to here, so that they can be checked.
2697
604efe86 2698 * sysdep.c (reset_io): Now static.
b8950c94 2699 (wait_for_termination_signal): Remove; unused.
604efe86 2700
38fc62d9
PE
2701 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2702 (copy_keymap_item, append_key, push_text_char_description):
2703 Now static.
1004a21a 2704 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2705 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2706 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2707 (describe_map_tree):
2708 Rename locals to avoid shadowing.
38fc62d9 2709
2f2650da
PE
2710 * keyboard.c: Declare functions static if they are not used elsewhere.
2711 (echo_char, echo_dash, cmd_error, top_level_2):
2712 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2713 (read_char, kbd_buffer_get_event, make_lispy_position):
2714 (make_lispy_event, make_lispy_movement, apply_modifiers):
2715 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2716 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2717 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2718 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2719 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2720
a053e86c 2721 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2722 (mark_kboards): Move decl here ...
2723 * alloc.c (mark_kboards): ... from here.
a053e86c 2724
4752793e
PE
2725 * lisp.h (force_auto_save_soon): New decl.
2726
74f10ca7 2727 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2728 (DEFINE_DUMMY_FUNCTION): New macro.
2729 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2730 Use it.
c03cd23f
PE
2731 (main): Add casts to avoid warnings
2732 if GCC considers string literals to be constants.
74f10ca7 2733
022e70d4
PE
2734 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2735
59d6fe83
PE
2736 * dbusbind.c: Pointer signedness fixes.
2737 (xd_signature, xd_append_arg, xd_initialize):
2738 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2740 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2741 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2742
78320123
PE
2743 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2744 if GCC considers string literals to be constants.
49cebcca 2745 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2746
35ac2a97
SM
27472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2748
fb103ca9
SM
2749 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2750 (print_preprocess, print_object): New macro to fix last change.
2751
35ac2a97
SM
2752 * print.c (print_preprocess): Don't forget font objects.
2753
62973b41
JB
27542011-03-16 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * emacs.c (USAGE3): Doc fixes.
2757
0e48bb22
AS
27582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2759
2760 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2761 structure.
2762
7684e57b
JB
27632011-03-14 Juanma Barranquero <lekktu@gmail.com>
2764
2765 * lisp.h (VWindow_system, Qfile_name_history):
2766 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2767 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2768 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2769
2770 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2771 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2772
2773 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2774 * w32console.c (detect_input_pending, read_input_pending)
2775 (encode_terminal_code):
2776 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2777 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2778 (w32_system_caret_y, Qfile_name_history):
2779 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2780 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2781 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2782 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2783 * w32proc.c (Qlocal, report_file_error):
2784 * w32term.c (Vwindow_system, updating_frame):
2785 * w32uniscribe.c (initialized, uniscribe_font_driver):
2786 Remove unneeded extern declarations.
2787
2aa46d6c
CY
27882011-03-14 Chong Yidong <cyd@stupidchicken.com>
2789
c96bbc66 2790 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2791
cffc6f3b
CY
27922011-03-13 Chong Yidong <cyd@stupidchicken.com>
2793
2794 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2795 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2796 These macros can no longer be used for assignment.
2797
44f230aa
SM
2798 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2799 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2800 (record_buffer_markers, fetch_buffer_markers): New functions for
2801 recording and fetching special buffer markers.
2802 (set_buffer_internal_1, set_buffer_temp): Use them.
2803
2804 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2805
2806 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2807
2808 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2809 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2810
2811 * xdisp.c (hscroll_window_tree):
2812 (reconsider_clip_changes): Use PT instead of BUF_PT.
2813
d251f04b
EZ
28142011-03-13 Eli Zaretskii <eliz@gnu.org>
2815
2816 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2817 $(EMACS_ROOT)/lib/intprops.h.
2818
f0c77cd1
PE
28192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2820
3eca4629
PE
2821 Fix more problems found by GCC 4.5.2's static checks.
2822
7c86ee98
PE
2823 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2824 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2825 (xg_free_frame_widgets): Make it clear that a local variable is
2826 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2827 (gdk_window_get_screen): Make it clear that this macro is needed
2828 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2829 (int_gtk_range_get_value): New function, which avoids a diagnostic
2830 from gcc -Wbad-function-cast.
2831 (xg_set_toolkit_scroll_bar_thumb): Use it.
2832 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2833 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2834 (get_utf8_string, xg_get_file_with_chooser):
2835 Rename locals to avoid shadowing.
2836 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2837
41729b81
PE
2838 * xgselect.c (xg_select): Remove unused var.
2839
f0c77cd1
PE
2840 * image.c (four_corners_best): Mark locals as initialized.
2841 (gif_load): Initialize transparent_p to zero (Bug#8238).
2842 Mark another local as initialized.
ec6cf4c6 2843 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2844
ce0ad53d 2845 * image.c (clear_image_cache): Now static.
d5d5a617 2846 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2847 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2848 (x_edge_detection): Remove unnecessary cast that
2849 gcc -Wbad-function-cast diagnoses.
2037898d 2850 (gif_load): Fix pointer signedness.
6ae141d6
PE
2851 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2852 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2853
33383987 28542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2855
d32df629
PE
2856 Improve quality of tests for time stamp overflow.
2857 For example, without this patch (encode-time 0 0 0 1 1
2858 1152921504606846976) returns the obviously-bogus value (-948597
2859 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2860 reports time overflow. See
2861 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2862 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2863 * editfns.c: Include limits.h and intprops.h.
2864 (TIME_T_MIN, TIME_T_MAX): New macros.
2865 (time_overflow): Move earlier, to before first use.
2866 (hi_time, lo_time): New functions, for an accurate test for
2867 out-of-range times.
2868 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2869 (Fget_internal_run_time): Don't assume time_t fits in int.
2870 (make_time): Use list2 instead of Fcons twice.
2871 (Fdecode_time): More accurate test for out-of-range times.
2872 (check_tm_member): New function.
2873 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2874 (lisp_time_argument): Don't rely on undefined left-shift and
2875 right-shift behavior when checking for time stamp overflow.
8be6f318 2876
fe31d94c
PE
2877 * editfns.c (time_overflow): New function, refactoring common code.
2878 (Fformat_time_string, Fdecode_time, Fencode_time):
2879 (Fcurrent_time_string): Use it.
2880
8be6f318
PE
2881 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2882 * dired.c (make_time): Move to ...
2883 * editfns.c (make_time): ... here.
2884 * systime.h: Note the move.
2885
09d9db2c 28862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2887
126bc0dc
YM
2888 * fringe.c (update_window_fringes): Remove unused variables.
2889
c47cbdfd
YM
2890 * unexmacosx.c (copy_data_segment): Also copy __got section.
2891 (Bug#8223)
2892
7ac80be9
EZ
28932011-03-12 Eli Zaretskii <eliz@gnu.org>
2894
c96bbc66 2895 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2896 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2897 Constify `char *' arguments and their references according to
2898 prototypes in tparam.h.
2899
ecb0f94d 2900 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2901
7ac80be9
EZ
2902 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2903 Adapt all references accordingly.
2904
2905 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2906
ef1fd07e
TT
29072011-03-11 Tom Tromey <tromey@redhat.com>
2908
2909 * buffer.c (syms_of_buffer): Remove obsolete comment.
2910
7ef4b50c
EZ
29112011-03-11 Eli Zaretskii <eliz@gnu.org>
2912
2913 * termhooks.h (encode_terminal_code): Declare prototype.
2914
2915 * msdos.c (encode_terminal_code): Don't declare prototype.
2916
2917 * term.c (encode_terminal_code): Now external again, used by
2918 w32console.c and msdos.c.
2919
44f230aa
SM
2920 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2921 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2922
4b1ec863 29232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2924
1714f52b 2925 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2926
4b1ec863
PE
2927 * fringe.c (update_window_fringes): Mark locals as initialized
2928 (Bug#8227).
2929 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2930
524c7aa6
PE
2931 * alloc.c (mark_fringe_data): Move decl from here ...
2932 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2933 to check its interface.
2934 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2935
a5c0af81 2936 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2937 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2938 (fontset_font): Mark local as initialized.
a9a06e0b 2939 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2940
b4716021
PE
2941 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2942
811e9bac 2943 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2944 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2945 (x_own_selection, Fx_disown_selection_internal): Rename locals
2946 to avoid shadowing.
2947 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2948
7e3ab302
PE
2949 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2950 so that the caller can use some name other than gcpro1.
2951 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2952 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2953 (Fx_backspace_delete_keys_p):
2954 Use them to avoid shadowing, and rename vars to avoid shadowing.
2955 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2956 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2957 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2958 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2959 Remove unused locals.
7e3ab302
PE
2960 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2961 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2962 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2963 macros.
f78faa98 2964
e2b13473
PE
2965 * xterm.h (x_mouse_leave): New decl.
2966
77f23912
PE
2967 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2968 Remove unused functions.
cdf4ba58
PE
2969 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2970 (x_calc_absolute_position): Now static.
7411c686 2971 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2972 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2973 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2974 unless they are used.
38d0b34a
PE
2975 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2976 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2977 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2978 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2979 (x_error_catcher, x_connection_closed, x_error_handler):
2980 (x_error_quitter, xembed_send_message, x_iconify_frame):
2981 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2982 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2983 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2984
44f230aa
SM
2985 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2986 Rename or move locals to avoid shadowing.
6b463e58 2987 (tty_defined_color, merge_face_heights): Now static.
5967d051 2988 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2989 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2990 does not deduce is never used uninitialized.
73719eba
PE
2991 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2992 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2993
426994c3 2994 * terminal.c (store_terminal_param): Now static.
5489860b 2995
032f1620 2996 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2997 (set_frame_menubar): Remove unused local.
d4323972 2998 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2999 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3000 since they might point to immutable storage.
281585b0
PE
3001 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3002 since it's unused otherwise.
032f1620 3003
367c19e5 3004 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3005 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3006 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3007 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3008 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3009 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3010 does not deduce are never used uninitialized.
70739cbe 3011
07b48fa9
PE
3012 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3013
8868a238 3014 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3015 * window.c (window_loop, size_window):
3016 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3017
7e5cf297 3018 * window.c (display_buffer): Now static.
d6550a9f
PE
3019 (size_window): Mark variables that gcc -Wuninitialized
3020 does not deduce are never used uninitialized.
a586633d
PE
3021 * window.h (check_all_windows): New decl, to forestall
3022 gcc -Wmissing-prototypes diagnostic.
5b555da1 3023 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3024
f6095868
PE
3025 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3026 shadowing.
3027 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3028 Include <limits.h>.
3029 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3030 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3031 (load_charset_map): Mark variables that gcc -Wuninitialized
3032 does not deduce are never used uninitialized.
53df7c11 3033 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3034
f38b440c
PE
3035 * coding.c (coding_set_source, coding_set_destination):
3036 Use "else { /* comment */ }" rather than "else /* comment */;"
3037 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3038 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3039 a block, when the outer 'i' will do.
3040 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3041 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3042 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3043 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3044 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3045 Rename locals to avoid shadowing.
3046 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3047 * coding.c (emacs_mule_char, encode_invocation_designation):
3048 Now static, since they're not used elsewhere.
413bb2db 3049 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3050 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3051 (decode_coding_emacs_mule): Mark variables that gcc
3052 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3053 (detect_coding_iso_2022): Initialize a local variable that might
3054 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3055 this initialization is needed. (Bug#8211)
5f58e762
PE
3056 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3057 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3058 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3059 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3060 Remove unused macros.
f38b440c 3061
232b38b9 3062 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3063 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3064 * character.c (string_count_byte8): Likewise.
232b38b9 3065
fb90da1b
PE
3066 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3067 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3068
fb93dbc2
PE
3069 * chartab.c (copy_sub_char_table): Now static, since it's not used
3070 elsewhere.
5c156ace
PE
3071 (sub_char_table_ref_and_range, char_table_ref_and_range):
3072 Rename locals to avoid shadowing.
bbcd0949 3073 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3074
7d3b3862 3075 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3076 (BIDI_BOB): Remove unused macro.
7d3b3862 3077
6be7d3da
PE
3078 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3079 deduce are never used uninitialized.
c2ed9c8b 3080 * term.c (encode_terminal_code): Likewise.
6be7d3da 3081
75f8807f 3082 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3083
50938595
PE
3084 * tparam.h: New file.
3085 * term.c, tparam.h: Include it.
3086 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3087 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3088 Move these decls to tparam.h, and make them agree with what
3089 is actually in tparam.c. The previous trick of using incompatible
3090 decls in different modules does not conform to the C standard.
3091 All callers of tparam changed to use tparam's actual API.
3092 * tparam.c (tparam1, tparam, tgoto):
3093 Use const pointers where appropriate.
3094
fbceeba2
PE
3095 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3096 * cm.h (struct cm): Likewise.
3097 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3098 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3099 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3100 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3101 (turn_on_face, init_tty): Likewise.
3102 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3103
7f3f1250
PE
3104 * term.c (term_mouse_position): Rename local to avoid shadowing.
3105
e6ca6543
PE
3106 * alloc.c (mark_ttys): Move decl from here ...
3107 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3108
c40f8d15
AS
31092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3110
3111 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3112
cfe0661d
JB
31132011-03-09 Juanma Barranquero <lekktu@gmail.com>
3114
3115 * search.c (compile_pattern_1): Remove argument regp, unused since
3116 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3117 (compile_pattern): Don't pass it.
3118
0afb4571
J
31192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3120
3121 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3122 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3123 for ! HAVE_GTK3.
3124 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3125
3126 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3127
3128 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3129 gdk_window_get_screen, gdk_window_get_geometry,
3130 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3131 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3132 (xg_get_pixbuf_from_pixmap): New function.
3133 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3134 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3135 Call xg_get_pixbuf_from_pixmap instead of
3136 gdk_pixbuf_get_from_drawable.
3137 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3138 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3139 (xg_check_special_colors): Use GtkStyleContext and its functions
3140 for HAVE_GTK3.
3141 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3142 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3143 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3144 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3145 Call gtk_widget_get_preferred_size.
0afb4571
J
3146 (xg_frame_resized): gdk_window_get_geometry only takes 5
3147 parameters.
44f230aa
SM
3148 (xg_win_to_widget, xg_event_is_for_menubar):
3149 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3150 (xg_set_widget_bg): New function.
3151 (delete_cb): New function.
895009e1 3152 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3153 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3154 (xg_set_background_color): Call xg_set_widget_bg.
3155 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3156 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3157 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3158 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3159 if ! HAVE_GTK3.
3160 (update_frame_tool_bar): Call gtk_widget_hide.
3161 (xg_initialize): Use GDK_KEY_g.
3162
3163 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3164 if ! HAVE_GTK3
3165 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3166
3167 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3168 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3169 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3170
1c2cc4ef
JB
31712011-03-08 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * w32xfns.c (select_palette): Check success of RealizePalette against
3174 GDI_ERROR, not zero.
3175
33383987 3176See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3177
3178;; Local Variables:
3179;; coding: utf-8
aac0c6e3
MR
3180;; End:
3181
33383987 3182 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3183
3184 This file is part of GNU Emacs.
3185
3186 GNU Emacs is free software: you can redistribute it and/or modify
3187 it under the terms of the GNU General Public License as published by
3188 the Free Software Foundation, either version 3 of the License, or
3189 (at your option) any later version.
3190
3191 GNU Emacs is distributed in the hope that it will be useful,
3192 but WITHOUT ANY WARRANTY; without even the implied warranty of
3193 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3194 GNU General Public License for more details.
3195
3196 You should have received a copy of the GNU General Public License
3197 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.