Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8666506e 12011-09-01 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2
0999621a 3 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 20 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2be7d702
PE
23 * dbusbind.c (signature_cat): New function.
24 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
25 Do not overrun buffer; instead, report string overflow.
26
9d1df220
PE
27 * dispnew.c (add_window_display_history): Don't overrun buffer.
28 Truncate instead; this is OK since it's just a log.
29
33ef5c64
PE
30 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
31 even if the time zone offset is outlandishly large.
32 Don't mishandle offset == INT_MIN.
33
66c6fdd5
PE
34 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
35 when creating daemon; the previous buffer-overflow check was incorrect.
36
d749b01b
PE
37 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
38 which has the guts of the old verror function.
39
b5cd1905
PE
40 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
41 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42
6e1a67fb
PE
43 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
44 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 45 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 46 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
47 length of string rather than counting it via multiple sprintfs;
48 that's simpler and more reliable.
c21721cc
PE
49 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
50 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
51 sprintf, in case result does not fit in int.
52
c57b67fc
PE
53 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
54 (fontset_from_font): Print it.
55
8a401434
PE
56 * frame.c (tty_frame_count): Now printmax_t, not int.
57 (make_terminal_frame, set_term_frame_name): Print it.
58 (x_report_frame_params): In X, window IDs are unsigned long,
59 not signed long, so print them as unsigned.
60 (validate_x_resource_name): Check for implausibly long names,
61 and don't assume name length fits in 'int'.
62 (x_get_resource_string): Don't blindly alloca invocation name;
63 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
64 not fit in int.
65
6e1a67fb
PE
66 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
67 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
68 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
69
0df02bf3
PE
70 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
71 Use esprintf, not sprintf, in case result does not fit in int.
72
48e30793
PE
73 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
74 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
75 it as a large positive number.
76 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
77 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
78
a66ff6d8
PE
79 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
80 in case result does not fit in int.
81
aca216ff
PE
82 * print.c (float_to_string): Detect width overflow more reliably.
83 (print_object): Make sprintf buffer a bit bigger, to avoid potential
84 buffer overrun. Don't assume list length fits in 'int'. Treat
85 print length of 0 as 0, not as infinity; to be consistent with other
86 uses of print length in this function. Don't overflow print length
87 index. Don't assume hash table size fits in 'long', or that
88 vectorlike size fits in 'unsigned long'.
89
31c286f7
PE
90 * process.c (make_process): Use printmax_t, not int, to format
91 process-name gensyms.
92
55e5faa1
PE
93 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
94
80f2e268
PE
95 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
96 to avoid potential buffer overrun.
97
670741ab
PE
98 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
99 if X resource line is longer than 512 bytes.
100
b7163a50
PE
101 * xfns.c (x_window): Make sprintf buffer a bit bigger
102 to avoid potential buffer overrun.
103
ae58ff1f
PE
104 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
105
c43c8a6a
PE
106 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
107
6e20a0d4
CY
1082011-08-30 Chong Yidong <cyd@stupidchicken.com>
109
110 * syntax.c (find_defun_start): Update all cache variables if
111 exiting early (Bug#9401).
112
148ae00e
EZ
1132011-08-30 Eli Zaretskii <eliz@gnu.org>
114
f6cfbd8f
EZ
115 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
116
148ae00e
EZ
117 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
118 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
119 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
120
121 * term.c (tty_append_glyph): New function.
122 (produce_stretch_glyph): Static function and its prototype deleted.
123
124 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
125 prototypes.
126
c4a07a4c
PE
1272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
128
129 * image.c (parse_image_spec): Check for nonnegative, not for positive,
130 when checking :margin (Bug#9390).
131 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
132 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
133 so that the name doesn't mislead. All uses changed.
134
6bc8cd65
JB
1352011-08-28 Johan Bockgård <bojohan@gnu.org>
136
137 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
138 set_tty_hooks.
139
dca4927e
EZ
1402011-08-27 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (move_it_to): Don't bail out early when reaching
143 position beyond to_charpos, if we are scanning backwards.
144 (move_it_vertically_backward): When DY == 0, make sure we get to
145 the first character in the line after the newline.
146
f2cad773
PE
1472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
148
149 * ccl.c: Improve and simplify overflow checking (Bug#9196).
150 (ccl_driver): Do not generate an out-of-range pointer.
151 (Fccl_execute_on_string): Remove unnecessary check for
152 integer overflow, noted by Stefan Monnier in
153 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
154 Remove a FIXME that didn't need fixing.
155 Simplify the newly-introduced buffer reallocation code.
156
0cae2cdb
JB
1572011-08-27 Juanma Barranquero <lekktu@gmail.com>
158
159 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
160
5fc295a4 1612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 162
70c60eb2 163 Integer and memory overflow issues (Bug#9196).
726e0ab1 164
d31850da
PE
165 * doc.c (get_doc_string): Rework so that
166 get_doc_string_buffer_size is the actual buffer size, rather than
167 being 1 less than the actual buffer size; this makes xpalloc more
168 convenient.
169
a69fbedb
PE
170 * image.c (x_allocate_bitmap_record, cache_image):
171 * xselect.c (Fx_register_dnd_atom):
172 Simplify previous changes by using xpalloc.
173
fe5c5d37
PE
174 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
175 since either will do and ptrdiff_t is convenient with xpalloc.
176
0065d054
PE
177 * charset.c (charset_table_size)
178 (struct charset_sort_data.priority): Now ptrdiff_t.
179 (charset_compare): Don't overflow if priorities differ greatly.
180 (Fsort_charsets): Don't assume list length fits in int.
181 Check for size-calculation overflow when allocating sort data.
182 (syms_of_charset): Allocate an initial charset table that is
183 just under 64 KiB, to avoid problems with glibc malloc and mmap.
184
185 * cmds.c (internal_self_insert): Check for size-calculation overflow.
186
187 * composite.h (struct composition.glyph_len): Now int, not unsigned.
188 The actual value is always <= INT_MAX, and leaving it unsigned made
189 overflow checking harder.
190
191 * dispextern.h (struct glyph_matrix.rows_allocated)
192 (struct face_cache.size): Now ptrdiff_t, for convenience in use
193 with xpalloc. The values are still always <= INT_MAX.
194
195 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
196
197 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
198 (SAFE_NALLOCA): New macro.
199
200 * region-cache.c (struct boundary.pos, find_cache_boundary)
201 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
202 (set_cache_region, invalidate_region_cache)
203 (revalidate_region_cache, know_region_cache, region_cache_forward)
204 (region_cache_backward, pp_cache):
205 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
206 so that ptrdiff_t * can be passed to xpalloc.
207 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
208 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
209 (pp_cache): Don't assume cache_len fits in int.
210 * region-cache.h: Adjust extern decls to match.
211
212 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
213 EMACS_INT, since either will do, for xpalloc.
214
215 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
216 (xnmalloc, xnrealloc, xpalloc): New functions.
217
726e0ab1
PE
218 * bidi.c (bidi_shelve_header_size): New constant.
219 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
220 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
221
51f30bc5 222 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
223 * buffer.c (overlays_at, overlays_in, record_overlay_string)
224 (overlay_strings):
225 Don't update size of array until after memory allocation succeeds,
226 because xmalloc/xrealloc may not return.
0065d054
PE
227 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
228 now that we have proper integer overflow checking.
229 (record_overlay_string, overlay_strings): Catch overflows when
230 calculating size of overlay_str_buf.
726e0ab1 231
0065d054
PE
232 * callproc.c (Fcall_process): Check for size overflow when
233 calculating size of args2.
234 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
235 Normally we prefer signed values, but sticking with ptrdiff_t would
236 require adding more-complicated checks.
726e0ab1
PE
237
238 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
239 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
240 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 241 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
242
243 * character.c (Fstring): Check for size-calculation overflow.
244
245 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
246 unnecessary integer overflow. Check for size overflow.
247 (encode_coding_object): Don't update size until xmalloc succeeds.
248
249 * composite.c (get_composition_id): Check for overflow in glyph
250 length calculations.
251
252 Integer and memory overflow fixes for display code.
253 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
254 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
255 (scrolling_window): Check for overflow in size calculations.
256 (line_draw_cost, realloc_glyph_pool, add_row_entry):
257 Don't assume glyph table len fits in int.
258 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
259 (row_table_size): Now ptrdiff_t, not int.
260 (scrolling_window): Avoid overflow in size calculations.
261 Don't update size until allocation succeeds.
262 * fns.c (concat): Check for overflow in size calculations.
263 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
264 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
265 (NEXT_ALMOST_PRIME_LIMIT): New constant.
266
267 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
268 (get_doc_string): Check for size calculation overflow.
269 Don't update size until allocation succeeds.
270 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
271 EMACS_INT, where ptrdiff_t will do.
272 (Fsubstitute_command_keys): Check for string overflow.
273
274 * editfns.c (set_time_zone_rule): Don't assume environment length
275 fits in int.
276 (message_length): Now ptrdiff_t, not int.
277 (Fmessage_box): Don't update size until allocation succeeds.
278 Don't assume message length fits in int.
279 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
280
0065d054
PE
281 * emacs.c (main): Do not reallocate argv, since there is a null at
282 the end that can be overwritten, and this way there's no need to
283 worry about size-calculation overflow.
284 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
285
286 * eval.c (init_eval_once, grow_specpdl): Don't update size until
287 alloc succeeds.
288 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
289
290 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
291 (x_set_scroll_bar_width, x_figure_window_size):
292 Check for integer overflow.
293 (x_set_alpha): Do not assume XINT fits in int.
294
295 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
296 This is for the members text_lines, text_cols, total_lines, total_cols,
297 where the system imposes an 'int' limit.
298
299 * fringe.c (Fdefine_fringe_bitmap):
300 Don't update size until alloc works.
301
302 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
303 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
304
305 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
306 Check for size-calculation overflow.
307 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
308 do, as we prefer signed integers.
309 (id_to_widget.max_size, id_to_widget.used)
310 (xg_store_widget_in_map, xg_remove_widget_from_map)
311 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
312 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
313 Use and return ptrdiff_t, not int.
314 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
315 * gtkutil.h: Change prototypes to match the above.
316
317 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
318 are duplicate now that they've been promoted to lisp.h.
319 (x_allocate_bitmap_record, x_alloc_image_color)
320 (make_image_cache, cache_image, xpm_load):
321 Don't update size until alloc is done.
322 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
323 (x_detect_edges):
3256efce 324 Check for size calculation overflow.
726e0ab1
PE
325 (ct_colors_allocated_max): New constant.
326 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
327 overflow.
3256efce 328
726e0ab1
PE
329 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
330 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
331 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
332 Use ptrdiff_t, not int, to count maps.
333 (read_char_minibuf_menu_prompt): Check for overflow in size
334 calculations. Don't update size until allocation succeeds. Redo
335 calculations to avoid overflow.
336 * keyboard.h: Change prototypes to match the above.
337
338 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
339 to count maps.
340 (current_minor_maps): Check for size calculation overflow.
341 * keymap.h: Change prototypes to match the above.
342
343 * lread.c (read1, init_obarray): Don't update size until alloc done.
344
345 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
346 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
347
726e0ab1
PE
348 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
349 Now ptrdiff_t, not int.
350 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
351 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
352
353 * process.c (Fnetwork_interface_list): Check for overflow
354 in size calculation.
355
356 * region-cache.c (move_cache_gap): Check for size calculation overflow.
357
358 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
359 overflow. Don't bother calling xmalloc when xrealloc will do.
360
361 * search.c (Freplace_match): Check for size calculation overflow.
362 (Fset_match_data): Don't assume list lengths fit in 'int'.
363
364 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
365 for command line length. Do not attempt to address one before the
366 beginning of an array, as that's not portable.
367
368 * term.c (max_frame_lines): Remove; unused.
369 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
370 not int.
371 (encode_terminal_code, calculate_costs): Check for size
372 calculation overflow.
373 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
374 table lengths and related sizes. Don't update size until alloc
375 done. Redo calculations to avoid overflow.
376 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
377
378 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
379 subtracting pointers.
380 (gobble_line): Check for overflow more carefully. Don't update size
381 until alloc done.
382
383 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
384 Don't update size until alloc done.
385 Redo size calculations to avoid overflow.
386 Check for size calculation overflow.
0065d054 387 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
388
389 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
390 Use ptrdiff_t, not int, for sizes.
391 (store_mode_line_noprop_char): Don't update size until alloc done.
392
0065d054
PE
393 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
394 Use ptrdiff_t, not int, for sizes.
395 (Finternal_make_lisp_face, cache_face):
396 Check for size calculation overflow.
397 (cache_face): Treat size calculation overflows as if they were
398 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
399
400 * xfns.c (x_encode_text, x_set_name_internal)
401 (Fx_change_window_property): Use ptrdiff_t, not int, to count
402 sizes, since they can exceed INT_MAX in size. Check for size
403 calculation overflow.
404
0065d054
PE
405 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
406 (xg_select): Check for size calculation overflow.
726e0ab1
PE
407 Don't update size until alloc done.
408
0065d054 409 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 410 as sprintf is limited to int lengths.
1d526e2f 411
252c5ee1
PE
412 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
413 (X_LONG_MIN): New macros.
864d7ce7
PE
414 Use them to make the following changes clearer.
415 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
416 This change doesn't affect the value now, but it may help remind
417 future maintainers not to raise the value too much later.
418 (SELECTION_QUANTUM): Remove, replacing with ...
419 (selection_quantum): ... new function, which avoids overflow.
420 All uses changed.
421 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
422 assumption that selection length fits in 'int'.
423 (x_reply_selection_request, x_handle_selection_request)
424 (x_get_window_property, receive_incremental_selection)
425 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
426 (lisp_data_to_selection_data, clean_local_selection_data):
427 Use ptrdiff_t, not int, to record length of selection.
428 (x_reply_selection_request, x_get_window_property)
429 (receive_incremental_selection, x_property_data_to_lisp):
430 Redo calculations to avoid overflow.
431 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 432 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
433 something.
434 (x_get_window_property, receive_incremental_selection)
435 (lisp_data_to_selection_data, x_property_data_to_lisp):
436 Check for size-calculation overflow.
437 (x_get_window_property, receive_incremental_selection)
438 (lisp_data_to_selection_data, Fx_register_dnd_atom):
439 Don't store size until memory allocation succeeds.
440 (x_get_window_property): Plug memory leak on memory exhaustion.
441 Don't double-block input; malloc is safe here. Don't assume 2**34
442 - 4 fits in unsigned long. Add an xassert to check
443 XGetWindowProperty overflow. Be more careful about overflow
444 calculations, and distinguish size from memory overflow better.
445 (receive_incremental_selection): When tracing, don't assume
446 unsigned int is less than INT_MAX.
447 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
448 harmful) conversions of unsigned short to int.
449 (lisp_data_to_selection_data): Don't assume that integers
450 in the range -65535 through -1 fit in an X unsigned short.
451 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
452 result parameters unless successful. Rely on cons_to_unsigned
453 to report problems with elements; the old code wasn't right anyway.
454 (x_check_property_data): Check for int overflow; we cannot use
455 a wider type due to X limits.
456 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
457
726e0ab1 458 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 459
0065d054
PE
460 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
461 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
462 (x_color_cells): Don't store size until memory allocation succeeds.
463 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 464 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
465 (x_term_init): Don't assume length fits in int (sprintf is limited
466 to int size).
bc18e09d 467
ebfa62c0
PE
468 Use ptrdiff_t for composition IDs.
469 * character.c (lisp_string_width):
470 * composite.c (composition_table_size, n_compositions)
471 (get_composition_id, composition_gstring_from_id):
472 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
473 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
474 * window.c (Frecenter):
475 Use ptrdiff_t, not int, for composition IDs.
476 * composite.c (get_composition_id): Check for integer overflow.
477 * composite.h: Adjust prototypes to match the above changes.
478
d3411f89
PE
479 Use ptrdiff_t for hash table indexes.
480 * category.c (hash_get_category_set):
481 * ccl.c (ccl_driver):
482 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
483 * coding.c (coding_system_charset_list, detect_coding_system):
484 * coding.h (struct coding_system.id):
485 * composite.c (get_composition_id, gstring_lookup_cache):
486 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
487 * image.c (xpm_get_color_table_h):
488 * lisp.h (hash_lookup, hash_put):
489 * minibuf.c (Ftest_completion):
490 Use ptrdiff_t for hash table indexes, not int (which is too
491 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
492 32-bit --with-wide-int hosts).
493
e097a6fa
PE
494 * charset.c (Fdefine_charset_internal): Check for integer overflow.
495 Add a FIXME comment about memory leaks.
496 (syms_of_charset): Don't assume xmalloc returns.
497
5637687f
PE
498 Don't assume that stated character widths fit in int.
499 * character.c (Fchar_width, c_string_width, lisp_string_width):
500 * character.h (CHAR_WIDTH):
501 * indent.c (MULTIBYTE_BYTES_WIDTH):
502 Use sanitize_char_width to avoid undefined and/or bad behavior
503 with outlandish widths.
504 * character.h (sanitize_tab_width): Renamed from sanitize_width,
505 now that we have two such functions. All uses changed.
506 (sanitize_char_width): New inline function.
507
a2271ba2
PE
508 Don't assume that tab-width fits in int.
509 * character.h (sanitize_width): New inline function.
510 (SANE_TAB_WIDTH): New macro.
511 (ASCII_CHAR_WIDTH): Use it.
512 * indent.c (sane_tab_width): Remove. All uses replaced by
513 SANE_TAB_WIDTH (current_buffer).
514 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
515
18c52557
PE
516 * fileio.c: Integer overflow issues with file modes.
517 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
518
caeeedc1
PE
519 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
520 Remove unreachable code.
521 (read_hex, load_charset_map_from_file): Check for integer overflow.
522
50849c52
PE
523 * xterm.c: don't go over XClientMessageEvent limit
524 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
525 (x_send_scroll_bar_event): Likewise. Check that the size does not
526 exceed limits imposed by XClientMessageEvent, as well as the usual
527 ptrdiff_t and size_t limits.
528
b13995db
PE
529 * keyboard.c: Overflow, signedness and related fixes.
530 (make_lispy_movement): Use same integer type in forward decl
531 that is used in the definition.
532 (read_key_sequence, keyremap_step):
533 Change bufsize argument back to int, undoing my 2011-03-30 change.
534 We prefer signed types, and int is wide enough here.
535 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
536 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
537 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
538 length, not size_t. Use ptrdiff_t for index, not int.
539 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
540 possibility of integer overflow.
541
13464394
PE
542 Overflow, signedness and related fixes for images.
543
544 * dispextern.h (struct it.stack[0].u.image.image_id)
545 (struct_it.image_id, struct image.id, struct image_cache.size)
546 (struct image_cache.used, struct image_cache.ref_count):
547 * gtkutil.c (update_frame_tool_bar):
548 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
549 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
550 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
551 * nsmenu.m (update_frame_tool_bar):
552 * xdisp.c (calc_pixel_width_or_height):
553 * xfns.c (image_cache_refcount):
554 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
555 on typical 64-bit hosts.
556
557 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
558 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
559 Omit unnecessary casts to int.
560 (parse_image_spec): Check that integers fall into 'int' range
561 when the callers expect that.
562 (image_ascent): Redo ascent calculation to avoid int overflow.
563 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
564 (lookup_image): Remove unnecessary tests.
565 (xbm_image_p): Locals are now of int, not EMACS_INT,
566 since parse_image_check makes sure they fit into int.
567 (png_load, gif_load, svg_load_image):
568 Prefer int to unsigned where either will do.
569 (tiff_handler): New function, combining the cores of the
570 old tiff_error_handler and tiff_warning_handler. This
571 function is rewritten to use vsnprintf and thereby avoid
572 stack buffer overflows. It uses only the features of vsnprintf
573 that are common to both POSIX and native Microsoft.
574 (tiff_error_handler, tiff_warning_handler): Use it.
575 (tiff_load, gif_load, imagemagick_load_image):
576 Don't assume :index value fits in 'int'.
577 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
578 (imagemagick_load_image): Check that crop parameters fit into
579 the integer types that MagickCropImage accepts. Don't assume
580 Vimagemagick_render_type has a nonnegative value. Don't assume
581 size_t fits in 'long'.
582 (gs_load): Use printmax_t to print the widest integers possible.
583 Check for integer overflow when computing image height and width.
584
c11821d4
EZ
5852011-08-26 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (redisplay_window): Don't force window start if point
588 will be invisible in the resulting window. (Bug#9324)
589
0c95fcf7
EZ
5902011-08-25 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
593 the display spec is of the form `(space ...)'.
594 (handle_display_spec): Return the value returned by
595 handle_single_display_spec, not just 1 or zero.
596 (handle_single_display_spec): If the display spec is of the form
597 `(space ...)', and specifies display in the text area, return 2
598 rather than 1.
fee65a97 599 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
600 accurately, and prefer exact match for point under bidi. Don't
601 advance `row' beyond the last row of the window.
0c95fcf7
EZ
602
603 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
604 into disp_prop; all users changed.
605
606 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
607 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
608 for the text covered by the display property.
609
e4ed06f1
CY
6102011-08-25 Chong Yidong <cyd@stupidchicken.com>
611
612 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
613 Change return value to nil.
614 (Frecord_buffer): Delete unused function.
615
f67cdd7f
EZ
6162011-08-24 Eli Zaretskii <eliz@gnu.org>
617
5980d4c6
EZ
618 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
619 buffers, return left-to-right.
8610fe8b
EZ
620 (set_cursor_from_row): Consider candidate row a win if its glyph
621 represents a newline and point is on that newline. Fixes cursor
622 positioning on the newline at EOL of R2L text within L2R
623 paragraph, and vice versa.
624 (try_cursor_movement): Check continued rows, in addition to
625 continuation rows. Fixes unwarranted scroll when point enters a
626 continued line of R2L text within an L2R paragraph, or vice versa.
627 (cursor_row_p): Consider the case of point being equal to
628 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
629 from the end of a short line to the beginning of a continued line
630 of R2L text within L2R paragraph.
631 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
632 composed characters.
5980d4c6 633
f67cdd7f
EZ
634 * bidi.c (bidi_check_type): Use xassert.
635 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
636 members.
637
bca633fb
EZ
6382011-08-23 Eli Zaretskii <eliz@gnu.org>
639
640 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
641 a character.
642
4a5885a7
CY
6432011-08-23 Chong Yidong <cyd@stupidchicken.com>
644
645 * nsfont.m (ns_otf_to_script): Fix typo.
646
0902a04e
KH
6472011-08-22 Kenichi Handa <handa@m17n.org>
648
649 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
650 extra slot even if the purpose is char-code-property-table.
651
1a2e6670
EZ
6522011-08-23 Eli Zaretskii <eliz@gnu.org>
653
8ddde651
EZ
654 * xdisp.c (redisplay_window): When computing centering_position,
655 account for the height of the header line. (Bug#8874)
656
425cc014
EZ
657 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
658 instead of CHAR_TO_BYTE. Fixes a crash when a completion
659 candidate is selected by the mouse, and that candidate has a
660 composed character under the mouse.
661
1a2e6670
EZ
662 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
663 coordinates reported by pos-visible-in-window-p for a composed
664 character in column zero.
665
8b76d6f8
SM
6662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
667
668 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
669
dac347dd
EZ
6702011-08-22 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
673 consider it a hit if to_charpos is anywhere in the range of the
674 composed buffer positions.
675
e013fb34
CY
6762011-08-22 Chong Yidong <cyd@stupidchicken.com>
677
678 * image.c (gif_load): Don't assume that each subimage has the same
679 dimensions as the base image. Handle disposal method that is
680 "undefined" by the gif spec (Bug#9335).
681
bd1ba3e8
CY
6822011-08-20 Chong Yidong <cyd@stupidchicken.com>
683
684 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 685 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 686
54a1215b
EZ
6872011-08-19 Eli Zaretskii <eliz@gnu.org>
688
823564e5
EZ
689 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
690 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
691 from an Org mode buffer to a Speedbar frame.
692
54a1215b
EZ
693 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
694 a composition, take its buffer position from IT->cmp_it.charpos.
695 Fixes cursor positioning at the beginning of a line that begins
696 with a composed character.
697
9778ebcc
EZ
6982011-08-18 Eli Zaretskii <eliz@gnu.org>
699
0be6ee06
EZ
700 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
701 character bidirectional type, use STRONG_L instead. Fixes crashes
702 in a buffer produced by `describe-categories'.
703
9778ebcc
EZ
704 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
705 members before the level stack, so they would be saved and
706 restored when copying iterator state. Fixes incorrect reordering
707 around TABs covered by display properties.
708
156bffbe
AS
7092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
710
711 * process.c (Fnetwork_interface_list): Correctly determine buffer
712 size.
713
72ad093b
CY
7142011-08-17 Chong Yidong <cyd@stupidchicken.com>
715
716 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
717 (internal_condition_case_2, internal_condition_case_n):
718 Remove unnecessary aborts (Bug#9081).
72ad093b 719
35774242
EZ
7202011-08-17 Eli Zaretskii <eliz@gnu.org>
721
722 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
723 has no `load' handler, try opening the file locally. (Bug#9311)
724
db76dd85
KB
7252011-08-16 Ken Brown <kbrown@cornell.edu>
726
727 * gmalloc.c: Expand comment.
728
b215eee5
EZ
7292011-08-16 Eli Zaretskii <eliz@gnu.org>
730
731 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
732 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
733
a4579d33
KB
7342011-08-16 Ken Brown <kbrown@cornell.edu>
735
736 Fix memory allocation problems in Cygwin build (Bug#9273).
737
738 * unexcw.c ( __malloc_initialized): Declare external variable.
739 (fixup_executable): Force the dumped emacs to reinitialize malloc.
740
8b76d6f8
SM
741 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
742 New variables.
a4579d33
KB
743 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
744 dumped emacs.
745 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
746 in the static heap.
747 [CYGWIN] (special_realloc): New function.
748 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
749 requests to realloc storage in the static heap.
750
3ebec551
PE
7512011-08-15 Paul Eggert <eggert@cs.ucla.edu>
752
753 * bidi.c (bidi_initialize): Remove unused local.
754
9fd8be00
EZ
7552011-08-15 Eli Zaretskii <eliz@gnu.org>
756
474a8465
EZ
757 * biditype.h: File removed.
758
759 * bidimirror.h: File removed.
760
761 * deps.mk (bidi.o): Remove biditype.h and
762 bidimirror.h.
763
764 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
765 bidimirror.h.
766
767 * dispextern.h: Fix a typo in the comment to bidi_type_t.
768
769 * chartab.c: Improve commentary for the uniprop_table API.
770
32413314
EZ
771 * bidi.c (bidi_paragraph_init): Support zero value of
772 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
773 (bidi_initialize): Use uniprop_table instead of including
774 biditype.h and bidimirror.h.
32413314 775
9fd8be00
EZ
776 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
777 coordinates of the iterator when restoring from ppos_it.
778 (Bug#9296)
779
5cf2b69b
KH
7802011-08-14 Kenichi Handa <handa@m17n.org>
781
782 * process.c (create_process): Call setup_process_coding_systems
72ad093b 783 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 784
daf17d00
EZ
7852011-08-14 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (move_it_in_display_line_to): Don't invoke
788 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
789 ppos_it. Fixes vertical cursor motion when line beginning is
790 covered by an image. (Bug#9296)
791
08e3161a
JD
7922011-08-14 Jan Djärv <jan.h.d@swipnet.se>
793
794 * nsterm.h (ns_run_ascript): Declare.
795 (NSAPP_DATA2_RUNASSCRIPT): Define.
796
797 * nsfns.m (as_script, as_result, as_status): New static variables.
798 (ns_run_ascript): New function.
799 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
800 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
801 the event loop. Get status from as_status (Bug#7276).
802
803 * nsterm.m (sendEvent): If event is NSApplicationDefined and
804 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
805 the event loop (Bug#7276).
806
a3720aa2
AS
8072011-08-14 Andreas Schwab <schwab@linux-m68k.org>
808
809 * gnutls.c (QCgnutls_bootprop_priority)
810 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
811 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
812 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
813 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
814 (QCgnutls_bootprop_verify_hostname_error)
815 (QCgnutls_bootprop_callbacks_verify): Rename from
816 Qgnutls_bootprop_..., all uses changed.
817
818 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
819 uses changed.
820
0a0d27fb
PE
8212011-08-14 Paul Eggert <eggert@cs.ucla.edu>
822
19d5c50c
PE
823 * xfaces.c (Qframe_set_background_mode): Now static.
824 * dispextern.h (Qframe_set_background_mode): Remove decl.
825
0a0d27fb
PE
826 * process.c (Fnetwork_interface_info): Declare local only if needed.
827
377538cb
JD
8282011-08-13 Jan Djärv <jan.h.d@swipnet.se>
829
830 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
831 (Fnetwork_interface_list): Allocate in increments of bytes instead
832 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
833 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
834 sockaddr.
835 (struct ifflag_def): notrailers is smart on OSX.
836 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
837 Get hardware address with getifaddrs if available.
838
08fff70c
EZ
8392011-08-12 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (iterate_out_of_display_property): xassert that
842 IT->position is set to within IT->object's boundaries. Break from
843 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
844 when IT->position is set up wrongly due to some bug.
845 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
846 (push_display_prop): Allow GET_FROM_STRING as IT->method on
847 entry. Force push_it to save on the stack the current
848 buffer/string position, to be restored by pop_it. Fix flags in
849 the iterator structure wrt the object coming from a display
850 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
851 properties. (Bug#9284)
852
7be1c708 8532011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 854
7be1c708
CY
855 * fontset.c (fontset_get_font_group): Add proper type checks.
856 (Bug#9172)
aac0c6e3 857
7be1c708 8582011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 859
7be1c708
CY
860 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
861 and LC_VERSION_MIN_MACOSX.
862 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
863 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 864
97bb72a6
EZ
8652011-08-08 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
868 no-display-properties-and-no-overlays under bidi display.
869 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 870 properties and overlays.
97bb72a6 871
d5617611
CY
8722011-08-08 Chong Yidong <cyd@stupidchicken.com>
873
37e11a63
CY
874 * editfns.c (Fset_time_zone_rule): Document relationship with the
875 setenv function.
876
d5617611
CY
877 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
878 the font entity extracted from the cache (Bug#8109).
879
58872834
CY
8802011-08-07 Chong Yidong <cyd@stupidchicken.com>
881
882 * composite.c (autocmp_chars): Don't reset point. That is done by
883 restore_point_unwind (Bug#5984).
884
75bfc667
JL
8852011-08-07 Juri Linkov <juri@jurta.org>
886
887 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
888 to show the arg `TIME' instead of `TIMEVAL'.
889
d1410150
EZ
8902011-08-06 Eli Zaretskii <eliz@gnu.org>
891
892 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
893 display property strides EOL and includes a newline, as in
894 longlines-mode. (Bug#9254)
75b771e4
EZ
895 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
896 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
897
898 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
899 is non-zero, even if the data buffer is NULL. Fixes a crash in
900 vertical-motion with longlines-mode. (Bug#9254)
901
35928349
EZ
9022011-08-05 Eli Zaretskii <eliz@gnu.org>
903
ec7cc85b
EZ
904 * bidi.c <bidi_cache_total_alloc>: Now static.
905 (bidi_initialize): Initialize bidi_cache_total_alloc.
906
8b76d6f8 907 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
908 cache. (Bug#9221)
909
910 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
911 amount allocated this far in `bidi_cache_total_alloc'.
912 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
913 non-zero, only free the data buffer without restoring the cache
914 contents. All callers changed.
915
916 * dispextern.h (bidi_unshelve_cache): Update prototype.
917
918 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
919 (move_it_in_display_line, move_it_to)
920 (move_it_vertically_backward, move_it_by_lines): Replace the call
921 to xfree to an equivalent call to bidi_unshelve_cache.
922 (move_it_in_display_line_to): Fix logic of returning
412b6358 923 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 924
e2e2423b
EZ
9252011-08-05 Eli Zaretskii <eliz@gnu.org>
926
927 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
928 came from a string character with a `cursor' property. (Bug#9229)
929
ae9e757a
JD
9302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
931
932 * Makefile.in (LIB_PTHREAD): New variable.
933 (LIBES): Add LIB_PTHREAD (Bug#9216).
934
935 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
936 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
937
213bd7f2
AS
9382011-08-04 Andreas Schwab <schwab@linux-m68k.org>
939
940 * regex.c (re_iswctype): Remove some redundant boolean
941 conversions.
942
99aaf75f
JD
9432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
944
945 * xterm.c (x_find_topmost_parent): New function.
946 (x_set_frame_alpha): Find topmost parent window with
947 x_find_topmost_parent and set the property there also (bug#9181).
948 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
949
c74e9d86
PE
9502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
951
952 * callproc.c (Fcall_process): Avoid vfork clobbering
953 the local vars buffer, coding_systems, current_dir.
954
640c8776
SM
9552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
956
957 * keymap.c (Fmake_composed_keymap): Move to subr.el.
958
f26d0e4c
PE
9592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
960
8a10d76c
PE
961 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
962 so that it is not optimized away.
963
f26d0e4c
PE
964 * xdisp.c (compute_display_string_pos): Remove unused local.
965
55439c61
EZ
9662011-08-02 Eli Zaretskii <eliz@gnu.org>
967
968 Fix slow cursor motion and scrolling in large buffers with
969 selective display, like Org Mode buffers. (Bug#9218)
970
971 * dispextern.h (struct bidi_it): New member disp_prop_p.
972
973 * xdisp.c: Remove one-slot cache of display string positions.
974 (compute_display_string_pos): Accept an additional argument
975 DISP_PROP_P; callers changed. Scan at most 5K characters forward
976 for a display string or property. If found, set DISP_PROP_P
977 non-zero.
978
979 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
980 DISP_PROP_P, and pass it to compute_display_string_pos.
981 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
982 non-zero. All callers of bidi_fetch_char changed.
983
fb33fa43
SM
9842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
985
986 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
987
b099e063
DM
9882010-12-03 Don March <don@ohspite.net>
989
990 * keymap.c (Fdefine_key): Fix non-prefix key error message when
991 last character M-[char] is translated to ESC [char] (bug#7541).
992
5cc7f7af
KH
9932011-08-02 Kenichi Handa <handa@m17n.org>
994
d0fffa3f 995 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
996
997 * chartab.c (uniprop_table): Make it non-static.
998
525d5e6e
EZ
9992011-08-01 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (forward_to_next_line_start): Accept additional argument
1002 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1003 on the newline.
1004 (reseat_at_next_visible_line_start): Use the bidi iterator state
1005 returned by forward_to_next_line_start to restore the state of
1006 it->bidi_it after backing up to previous newline. (Bug#9212)
1007
31011111
AS
10082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1009
1010 * regex.c (re_comp): Protoize.
1011 (re_exec): Fix return type.
1012 (regexec): Fix type of `ret'. (Bug#9203)
1013
e5d76069
PE
10142011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1017 This is needed if max-image-size is a floating-point number.
1018
9a79b20c
AS
10192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1020
1021 * print.c (print_object): Print empty symbol as ##.
1022
1023 * lread.c (read1): Read ## as empty symbol.
1024
d8c2fa78
AA
10252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1026
1027 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1028 setting frame foreground color (Bug#9175).
1029 (x_set_background_color): Likewise.
1030
ffe57a7a
AA
1031 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1032 contents (Bug#9176).
1033 (EmacsTooltip -init): Remove bezels and add shadows to
1034 tooltip windows.
1035
bf3492a5
AA
1036 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1037 or scroll bar (Bug#8470).
1038
d55e9c53
AA
1039 * nsfont.m (nsfont_open): Remove assignment to voffset and
1040 unnecessary vars hshink, expand, hd, full_height, min_height.
1041 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1042
1043 * nsterm.h (nsfont_info): Remove voffset field.
1044
d8c2fa78 10452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1046
1047 Implement strike-through and overline on NextStep (Bug#8863).
1048
1049 * nsfont.m (nsfont_open): Use underline position provided by font,
1050 instead of hard-coded value of 2.
1051 (nsfont_draw): Call ns_draw_text_decoration instead.
1052
1053 * nsterm.h: Add declaration for ns_draw_text_decoration.
1054
1055 * nsterm.m (ns_draw_text_decoration): New function for drawing
1056 underline, overline, and strike-through.
1057 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1058 ns_draw_text_decoration. Change treatment of cursor drawing to
1059 accomodate underlining, etc.
1060
4cc60b9b
EZ
10612011-07-28 Eli Zaretskii <eliz@gnu.org>
1062
bc7ece87
EZ
1063 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1064 default.
4cc60b9b 1065
476371c4
PE
10662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1067
66606eea
PE
1068 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1069 Without this fix, if a signal arrives just after memory fills up,
1070 'malloc' might be invoked reentrantly.
1071
476371c4
PE
1072 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1073 In other words, assume that every image size is allowed, on non-X
1074 hosts. This assumption is probably wrong, but it lets Emacs compile.
1075
f3fcc40d
AS
10762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * regex.c (re_iswctype): Convert return values to boolean.
1079
350c992f
EZ
10802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1081
1082 * xdisp.c (compute_display_string_pos): Don't use cached display
1083 string position if the buffer had its restriction changed.
1084 (Bug#9184)
1085
5266b4bb
PE
10862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1089
2573a837 10902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1091
41f55ccd 1092 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1093
39e378da
PE
1094 * bidi.c: Integer size and overflow fixes.
1095 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1096 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1097 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1098 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1099 (bidi_find_other_level_edge):
1100 Use ptrdiff_t instead of EMACS_INT where either will do.
1101 This works better on 32-bit hosts configured --with-wide-int.
1102 (bidi_cache_ensure_space): Check for size-calculation overflow.
1103 Use % rather than repeated addition, for better worst-case speed.
1104 Don't set bidi_cache_size until after xrealloc returns, because it
1105 might not return.
1106 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1107 (bidi_cache_ensure_space): Also check that the bidi cache size
1108 does not exceed that of the largest Lisp string or buffer. See Eli
1109 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1110
5e927815
PE
1111 * alloc.c (__malloc_size_t): Remove.
1112 All uses replaced by size_t. See Andreas Schwab's note
1113 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1114
ca4aa935
PE
1115 * image.c: Improve checking for integer overflow.
1116 (check_image_size): Assume that f is nonnull, since
1117 it is always nonnull in practice. This is one less thing to
1118 worry about when checking for integer overflow later.
1119 (x_check_image_size): New function, which checks for integer
1120 overflow issues inside X.
1121 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1122 This removes the need for a memory_full check.
1123 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1124 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1125 (xbm_read_bitmap_data): Change locals back to 'int', since
1126 their values must fit in 'int'.
1127 (xpm_load_image, png_load, tiff_load):
1128 Invoke x_create_x_image_and_pixmap earlier,
1129 to avoid much needless work if the image is too large.
1130 (tiff_load): Treat overly large images as if
1131 x_create_x_image_and_pixmap failed, not as malloc failures.
1132 (gs_load): Use x_check_image_size.
1133
5f8f9cc2
PE
1134 * gtkutil.c: Omit integer casts.
1135 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1136 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1137
5adf60bc
PE
1138 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1139
c8907a93
PE
1140 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1141 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1142 would wrongly return t on a 64-bit host.
1143
e3c25c68
PE
1144 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1145 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1146 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1147 and therefore cause GCC to emit a bogus diagnostic in some cases.
1148
3f791afe
PE
1149 * image.c: Integer signedness and overflow and related fixes.
1150 This is not an exhaustive set of fixes, but it's time to
1151 record what I've got.
1152 (lookup_pixel_color, check_image_size): Remove redundant decls.
1153 (check_image_size): Don't assume that arbitrary EMACS_INT values
1154 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1155 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1156 (tiff_load, imagemagick_load_image):
1157 Check for overflow in size calculations.
1158 (x_create_x_image_and_pixmap): Remove unnecessary test for
1159 xmalloc returning NULL; that can't happen.
1160 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1161 (xpm_color_bucket): Use better integer hashing function.
1162 (xpm_cache_color): Don't possibly over-allocate memory.
1163 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1164 (gif_memory_source):
1165 Use ptrdiff_t, not int or size_t, to record sizes.
1166 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1167 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1168 either works, as we prefer signed integers.
1169 (tiff_read_from_memory, tiff_write_from_memory):
1170 Return tsize_t, not size_t, since that's what the TIFF API wants.
1171 (tiff_read_from_memory): Don't fail simply because the read would
1172 go past EOF; instead, return a short read.
1173 (tiff_load): Omit no-longer-needed casts.
1174 (Fimagemagick_types): Don't assume size fits into 'int'.
1175
3cc5a532
PE
1176 Improve hashing quality when configured --with-wide-int.
1177 * fns.c (hash_string): New function, taken from sxhash_string.
1178 Do not discard information about ASCII character case; this
1179 discarding is no longer needed.
1180 (sxhash-string): Use it. Change sig to match it. Caller changed.
1181 * lisp.h: Declare it.
1182 * lread.c (hash_string): Remove, since we now use fns.c's version.
1183 The fns.c version returns a wider integer if --with-wide-int is
1184 specified, so this should help the quality of the hashing a bit.
1185
b312a492
PE
1186 * emacs.c: Integer overflow minor fix.
1187 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1188 Define only if GNU_LINUX.
1189 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1190
dfd153ae
PE
1191 * dispnew.c: Integer signedness and overflow fixes.
1192 Remove unnecessary forward decls, that were a maintenance hassle.
1193 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1194 All uses changed.
1195 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1196 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1197 (prepare_desired_row, line_draw_cost):
1198 Use int, not unsigned, where either works.
1199 (save_current_matrix, restore_current_matrix):
1200 Use ptrdiff_t, not size_t, where either works.
1201 (init_display): Check for overflow more accurately, and without
1202 relying on undefined behavior.
1203
a81d11a3
PE
1204 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1205 Remove, replacing with the new symbols in lisp.h. All uses changed.
1206 * fileio.c (make_temp_name):
1207 * filelock.c (lock_file_1, lock_file):
1208 * xdisp.c (message_dolog):
1209 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1210 Use pMd etc. instead.
1211 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1212 replacing the pWIDE etc. symbols removed from editfns.c.
1213
3300e6fd
PE
1214 * keyboard.h (num_input_events): Now uintmax_t.
1215 This is (very slightly) less likely to mess up due to wraparound.
1216 All uses changed.
1217
fd05c7e9
PE
1218 * buffer.c: Integer signedness fixes.
1219 (alloc_buffer_text, enlarge_buffer_text):
1220 Use ptrdiff_t rather than size_t when either will do, as we prefer
1221 signed integers.
1222
903fe15d
PE
1223 * alloc.c: Integer signedness and overflow fixes.
1224 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1225 (__malloc_size_t): Default to size_t, not to int.
1226 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1227 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1228 Prefer ptrdiff_t to size_t when either would do, as we prefer
1229 signed integers.
1230 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1231 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1232 Now const. Initialize with values that are in range even if char
1233 is signed.
1234 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1235 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1236 These functions do the right thing with sizes > 2**32.
1237 (check_depth): Now ptrdiff_t, not int.
1238 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1239 Adjust to new way of storing sizes. Check for size overflow bugs
1240 in rest of code.
1241 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1242 slightly wrong anyway, as it missed one instance of
1243 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1244 (refill_memory_reserve): Omit needless cast to size_t.
1245 (mark_object_loop_halt): Mark as externally visible.
1246
ac82cc6a
PE
1247 * xselect.c: Integer signedness and overflow fixes.
1248 (Fx_register_dnd_atom, x_handle_dnd_message):
1249 Use ptrdiff_t, not size_t, since we prefer signed.
1250 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1251 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1252 x_dnd_atoms_size and x_dnd_atoms_length.
1253
c2d1e36d
PE
1254 * doprnt.c: Prefer signed to unsigned when either works.
1255 * eval.c (verror):
1256 * doprnt.c (doprnt):
1257 * lisp.h (doprnt):
1258 * xdisp.c (vmessage):
1259 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1260 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1261 prefer signed arithmetic to avoid comparison confusion.
1262 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1263 but is a bit tricky.
1264
0e926e56
PE
1265 Assume freestanding C89 headers, string.h, stdlib.h.
1266 * data.c, doprnt.c, floatfns.c, print.c:
1267 Include float.h unconditionally.
1268 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1269 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1270 * regex.c: Likewise for stddef.h, string.h.
1271 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1272 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1273 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1274 (STDC_HEADERS): Remove obsolete defines.
1275 * sysdep.c: Include limits.h unconditionally.
1276
9cfdb3ec
PE
1277 Assume support for memcmp, memcpy, memmove, memset.
1278 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1279 * regex.c (memcmp, memcpy):
1280 Remove; we assume C89 now.
1281
1282 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1283 (__malloc_safe_bcopy): Remove; no longer needed.
1284
cf950e6b 1285 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1286 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1287 well either way, and we prefer signed to unsigned.
1288
dbf38e02
LMI
12892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1290
1291 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1292 closes the connection while we're reading (bug#9182).
1293
d6f0886c
JD
12942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1295
1296 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1297 are specified (Bug#9168).
1298
2eb1f9e6
PE
12992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1302 Found by GCC static checking and --with-wide-int on a 32-bit host.
1303
22381272 13042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1305
1306 * xdisp.c (compute_display_string_pos): Fix logic of caching
1307 previous display string position. Initialize cached_prev_pos to
1308 -1. Fixes slow-down at the beginning of a buffer.
1309
f25e39b4
EZ
13102011-07-24 Eli Zaretskii <eliz@gnu.org>
1311
1312 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1313 for attrs[LFACE_FONTSET_INDEX].
1314
04c4b52e
PE
13152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * xml.c (parse_region): Remove unused local
1318 that was recently introduced.
1319
c1734fbd
EZ
13202011-07-23 Eli Zaretskii <eliz@gnu.org>
1321
be18c5a5
EZ
1322 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1323 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1324
c1734fbd
EZ
1325 * xdisp.c (move_it_in_display_line_to): Record the best matching
1326 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1327 exit if none of the characters scanned was an exact match.
1328 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1329 when exact match is impossible due to invisible text, and the
1330 lines are truncated.
1331
a258d627
JD
13322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1333
1334 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1335 for OSX >= 10.7.
1336
b6d5a689
EZ
13372011-07-22 Eli Zaretskii <eliz@gnu.org>
1338
0f74f785
EZ
1339 Fix a significant slow-down of cursor motion with C-n, C-p,
1340 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1341 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1342 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1343 (next_element_from_buffer): Call compute_stop_pos_backwards to
1344 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1345 base_level_stop.
1346 (reseat): Don't look for prev_stop, as that could mean a very long
1347 run.
1348 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1349 <cached_disp_overlay_modiff>: Cache for last found display string
1350 position.
551918c1 1351 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1352 about the same buffer in the same area of character positions, and
1353 the buffer wasn't changed since the time the display string
1354 position was cached.
551918c1 1355
b2d0c91a
EZ
13562011-07-22 Eli Zaretskii <eliz@gnu.org>
1357
1358 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1359 is an integer, which is important for empty lines. (Bug#9149)
1360
043604ee
CY
13612011-07-22 Chong Yidong <cyd@stupidchicken.com>
1362
1363 * frame.c (Fmodify_frame_parameters): In tty case, update the
1364 default face if necessary (Bug#4238).
1365
da4adb04
CY
13662011-07-21 Chong Yidong <cyd@stupidchicken.com>
1367
1368 * editfns.c (Fstring_to_char): No need to explain what a character
1369 is in the docstring (Bug#6576).
1370
9abd0532
LMI
13712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
1373 * xml.c (parse_region): Make sure we always return a tree.
1374
36881d16
HK
13752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1376
1377 * xml.c (parse_region): If a document contains only comments,
1378 return that, too.
1379
1e98674d
LMI
13802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1381
1382 * xml.c (make_dom): Return comments, too.
1383
590bd467
PE
13842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 Port to OpenBSD.
1387 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1388 and the surrounding thread.
1389 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1390 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1391 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1392 timer goes off.
1393 * s/openbsd.h (BROKEN_SIGIO): Define.
1394 * unexelf.c (unexec) [__OpenBSD__]:
1395 Don't update the .mdebug section of the Alpha COFF symbol table.
1396
f41628b2
LMI
13972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1398
1399 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1400 (bug#8460).
1401
b59b67c5
PE
14022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1403
15e3a074
PE
1404 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1405 This fixes some race conditions on the permissions of any newly
1406 created file.
1407
41bed37d
PE
1408 * alloc.c (valid_pointer_p): Use pipe, not open.
1409 This fixes some permissions issues when debugging.
1410
b59b67c5
PE
1411 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1412 If fchown fails to set both uid and gid, try to set just gid,
1413 as that is sometimes allowed. Adjust the file's mode to eliminate
1414 setuid or setgid bits that are inappropriate if fchown fails.
1415
925a6be7
SM
14162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1417
1418 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1419 to compare Lisp_Objects.
1420 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1421 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1422 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1423
52968808
AS
14242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1425
0a6a104b
AS
1426 * lread.c (read_integer): Unread even EOF character.
1427 (read1): Likewise. Properly record start position of symbol.
1428
52968808
AS
1429 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1430 symbol character follows.
1431
9e381cdd
PE
14322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1435 This works around a problem with the previous change to Fcopy_file.
1436 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1437 and without this change, GCC might complain about discarding
1438 fchown's return value.
1439
b5641435
JB
14402011-07-16 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1443
a8031457
PE
14442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1447
dd889327
LMI
14482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1449
750c33f7
LMI
1450 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1451 it's used from the C level.
1452
dd889327
LMI
1453 * process.c: Use the same condition for POLL_FOR_INPUT in both
1454 keyboard.c and process.c (bug#1858).
1455
87e86684
LM
14562011-07-09 Lawrence Mitchell <wence@gmx.li>
1457
1458 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1459 (Fgnutls_boot): Use it.
1460
64348f40
AS
14612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1462
1463 * doc.c (Fsubstitute_command_keys): Revert last change.
1464
1d698799
LMI
14652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1466
f863868c
LMI
1467 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1468 quotes the next character, and doesn't affect other longer
1469 sequences (bug#8935).
1470
1d698799
LMI
1471 * lread.c (syms_of_lread): Clarify that is isn't only
1472 `eval-buffer' and `eval-defun' that's affected by
1473 `lexical-binding' (bug#8460).
1474
aa4b6df6
EZ
14752011-07-15 Eli Zaretskii <eliz@gnu.org>
1476
1477 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1478 bidi redisplay when a line includes both an image and is
1479 truncated.
1480
5d856da6
PE
14812011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1482
ad6042bb
PE
1483 Fix minor problems found by static checking.
1484 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1485 (elsz): Now a signed constant, not a size_t var. We prefer signed
1486 types to unsigned, to avoid integer comparison confusion. Without
1487 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1488 "cannot optimize loop, the loop counter may overflow", a symptom
1489 of the confusion.
f00bbb22 1490 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1491 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1492
6468f31c
LMI
14932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1494
49080b10
LMI
1495 * search.c (Fre_search_backward): Mention `case-fold-search' in
1496 all the re_search_* functions (bug#8138).
1497
6468f31c
LMI
1498 * keyboard.c (Fopen_dribble_file): Document when the file is
1499 closed (bug#8056).
1500
c965adc5
EZ
15012011-07-14 Eli Zaretskii <eliz@gnu.org>
1502
df9733bf
EZ
1503 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1504 bidi_cache_idx.
1505
0bb23927
EZ
1506 Support bidi reordering of display and overlay strings.
1507 * xdisp.c (compute_display_string_pos)
1508 (compute_display_string_end): Accept additional argument STRING.
1509 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1510 (reseat_to_string): Initialize bidi_it->string.s and
1511 bidi_it->string.schars.
1512 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1513 NULL (avoids a crash in bidi_paragraph_init).
1514 Initialize itb.string.lstring.
0bb23927
EZ
1515 (init_iterator): Call bidi_init_it only of a valid
1516 buffer position was specified. Initialize paragraph_embedding to
1517 L2R.
1518 (reseat_to_string): Initialize the bidi iterator.
1519 (display_string): If we need to ignore text properties of
1520 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1521 original value of -1 will not work with bidi.)
1522 (compute_display_string_pos): First arg is now struct
1523 `text_pos *'; all callers changed. Support display properties on
1524 Lisp strings.
1525 (compute_display_string_end): Support display properties on Lisp
1526 strings.
1527 (init_iterator, reseat_1, reseat_to_string): Initialize the
1528 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1529 when iterating on a string not from display properties).
640c8776
SM
1530 (compute_display_string_pos, compute_display_string_end):
1531 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1532 arrow keys.
1533 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1534 base_level_stop; instead, set base_level_stop to BEGV.
1535 Fixes crashes in vertical-motion.
0bb23927
EZ
1536 (next_element_from_buffer): Improve commentary for when
1537 the iterator is before prev_stop.
1538 (init_iterator): Initialize bidi_p from the default value of
1539 bidi-display-reordering, not from buffer-local value. Use the
1540 buffer-local value only if initializing for buffer iteration.
1541 (handle_invisible_prop): Support invisible properties on strings
1542 that are being bidi-reordered.
1543 (set_iterator_to_next): Support bidi reordering of C strings and
1544 Lisp strings.
1545 (next_element_from_string): Support bidi reordering of Lisp
1546 strings.
1547 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1548 (display_string): Support display of R2L glyph rows.
1549 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1550 (init_iterator): Don't initialize it->bidi_p for strings
1551 here.
1552 (reseat_to_string): Initialize it->bidi_p for strings here.
1553 (next_element_from_string, next_element_from_c_string)
1554 (next_element_from_buffer): Add xassert's for correspondence
1555 between IT's object being iterated and it->bidi_it.string
1556 structure.
1557 (face_before_or_after_it_pos): Support bidi iteration.
1558 (next_element_from_c_string): Handle the case of the first string
1559 character that is not the first one in the visual order.
1560 (get_visually_first_element): New function, refactored from common
1561 parts of next_element_from_buffer, next_element_from_string, and
1562 next_element_from_c_string.
1563 (tool_bar_lines_needed, redisplay_tool_bar)
1564 (display_menu_bar): Force left-to-right direction. Add a FIXME
1565 comment for making that be controlled by a user option.
1566 (push_it, pop_it): Save and restore the state of the
1567 bidi iterator. Save and restore the bidi_p flag.
1568 (pop_it): Iterate out of display property for string iteration as
1569 well.
1570 (iterate_out_of_display_property): Support iteration over strings.
1571 (handle_single_display_spec): Set up it->bidi_it for iteration
1572 over a display string, and call bidi_init_it.
1573 (handle_single_display_spec, next_overlay_string)
1574 (get_overlay_strings_1, push_display_prop): Set up the bidi
1575 iterator for displaying display or overlay strings.
1576 (forward_to_next_line_start): Don't use the shortcut if
1577 bidi-iterating.
1578 (back_to_previous_visible_line_start): If handle_display_prop
1579 pushed the iterator stack, restore the internal state of the bidi
1580 iterator by calling bidi_pop_it same number of times.
1581 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1582 and we are bidi-iterating, don't decrement the iterator position;
1583 instead, set the first_elt flag in the bidi iterator, to produce
1584 the same effect.
1585 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1586 (push_display_prop): xassert that we are iterating a buffer.
1587 (push_it, pop_it): Save and restore paragraph_embedding member.
1588 (handle_single_display_spec, next_overlay_string)
1589 (get_overlay_strings_1, reseat_1, reseat_to_string)
1590 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1591 correctly. Don't assume unibyte strings are not bidi-reordered.
1592 (compute_display_string_pos)
1593 (compute_display_string_end): Fix handling the case of C string.
1594 (push_it, pop_it): Save and restore from_disp_prop_p.
1595 (handle_single_display_spec, push_display_prop): Set the
1596 from_disp_prop_p flag.
1597 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1598 (pop_it): Call iterate_out_of_display_property only if we are
1599 popping after iteration over a string that came from a display
1600 property. Fix a typo in popping stretch info. Add an assertion
1601 for verifying that the iterator position is in sync with the bidi
1602 iterator.
1603 (handle_single_display_spec, get_overlay_strings_1)
1604 (push_display_prop): Fix initialization of paragraph direction for
1605 string when that of the parent object is not yet determined.
1606 (reseat_1): Call bidi_init_it to resync the bidi
1607 iterator with IT's position. (Bug#7616)
1608 (find_row_edges): If ROW->start.pos gives position
1609 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1610 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1611 Reset the from_disp_prop_p flag.
1612 (SAVE_IT, RESTORE_IT): New macros.
1613 (pos_visible_p, face_before_or_after_it_pos)
1614 (back_to_previous_visible_line_start)
1615 (move_it_in_display_line_to, move_it_in_display_line)
1616 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1617 (try_scrolling, redisplay_window, display_line): Use them when
1618 saving a temporary copy of the iterator and restoring it back.
1619 (back_to_previous_visible_line_start, reseat_1)
1620 (init_iterator): Empty the bidi cache "stack".
1621 (move_it_in_display_line_to): If iterator ended up at
1622 EOL, but we never saw any buffer positions smaller than
1623 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1624 motion in bidi-reordered lines.
1625 (move_it_in_display_line_to): Record prev_method and prev_pos
1626 immediately before the call to set_iterator_to_next. Fixes cursor
1627 motion in bidi-reordered lines with stretch glyphs and strings
1628 displayed in margins. (Bug#8133) (Bug#8867)
1629 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1630 TO_CHARPOS.
640c8776
SM
1631 (pos_visible_p): Support positions in bidi-reordered lines.
1632 Save and restore bidi cache.
0bb23927
EZ
1633
1634 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1635 (bidi_paragraph_info): Delete unused struct.
1636 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1637 (bidi_cache_start): New variable.
1638 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1639 to zero.
1640 (bidi_cache_fetch_state, bidi_cache_search)
1641 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1642 (bidi_cache_find, bidi_peek_at_next_level)
1643 (bidi_level_of_next_char, bidi_find_other_level_edge)
1644 (bidi_move_to_visually_next): Compare cache index with
1645 bidi_cache_start rather than with zero.
1646 (bidi_fetch_char): Accept new argument STRING; all callers
1647 changed. Support iteration over a string. Support strings with
1648 display properties. Support unibyte strings. Fix the type of
1649 `len' according to what STRING_CHAR_AND_LENGTH expects.
1650 (bidi_paragraph_init, bidi_resolve_explicit_1)
1651 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1652 (bidi_level_of_next_char, bidi_move_to_visually_next):
1653 Support iteration over a string.
0bb23927
EZ
1654 (bidi_set_sor_type, bidi_resolve_explicit_1)
1655 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1656 can now be zero (for strings); special values 0 and -1 were
1657 changed to -1 and -2, respectively.
1658 (bidi_char_at_pos): New function.
1659 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1660 Call it instead of FETCH_MULTIBYTE_CHAR.
1661 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1662 initialized to valid values.
1663 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1664 values.
1665 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1666 the test for valid cached positions. Fix the logic for looking up
1667 the sentinel state in the cache. GCPRO the Lisp string we are
1668 iterating.
1669 (bidi_push_it, bidi_pop_it): New functions.
1670 (bidi_initialize): Initialize the bidi cache start stack pointer.
1671 (bidi_cache_ensure_space): New function, refactored from part of
1672 bidi_cache_iterator_state. Don't assume the required size is just
1673 one BIDI_CACHE_CHUNK away.
1674 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1675 (bidi_count_bytes, bidi_char_at_pos): New functions.
1676 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1677 always valid if bidi_cache_idx is valid.
1678 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1679 is valid if it's going to be used.
1680 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1681 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1682 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1683 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1684 (bidi_find_other_level_edge, bidi_cache_start_stack):
1685 All variables related to cache indices are now EMACS_INT.
c965adc5 1686
0bb23927
EZ
1687 * dispextern.h (struct bidi_string_data): New structure.
1688 (struct bidi_it): New member `string'. Make flag members be 1-bit
1689 fields, and put them last in the struct.
640c8776
SM
1690 (compute_display_string_pos, compute_display_string_end):
1691 Update prototypes.
0bb23927
EZ
1692 (bidi_push_it, bidi_pop_it): Add prototypes.
1693 (struct iterator_stack_entry): New members bidi_p,
1694 paragraph_embedding, and from_disp_prop_p.
1695 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1696 (bidi_shelve_cache, bidi_unshelve_cache):
1697 Declare prototypes.
0bb23927
EZ
1698
1699 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1700 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1701 and vector-like objects.
1702
1703 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1704 cache around display iteration.
1705
1706 * window.c (Fwindow_end, window_scroll_pixel_based)
1707 (displayed_window_lines, Frecenter): Save and restore the bidi
1708 cache around display iteration.
1709
3bbd2265
LMI
17102011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1711
1712 * editfns.c (Fdelete_region): Clarify the use of the named
1713 parameters (bug#6788).
1714
adc47434
MR
17152011-07-14 Martin Rudalics <rudalics@gmx.at>
1716
1717 * indent.c (Fvertical_motion): Set and restore w->pointm when
1718 saving and restoring the window's buffer (Bug#9006).
1719
837c31f8
LMI
17202011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1721
1722 * editfns.c (Fstring_to_char): Clarify just what is returned
1723 (bug#6576). Text by Eli Zaretskii.
1724
ac389d0c
JB
17252011-07-13 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1728
0be0ce47
EZ
17292011-07-13 Eli Zaretskii <eliz@gnu.org>
1730
1731 * buffer.c (mmap_find): Fix a typo.
1732
cd18e7e3
JB
17332011-07-13 Johan Bockgård <bojohan@gnu.org>
1734
1735 Fix execution of x selection hooks.
1736 * xselect.c (Qx_lost_selection_functions)
1737 (Qx_sent_selection_functions): New vars.
1738 (syms_of_xselect): DEFSYM them.
1739 (x_handle_selection_request): Pass Qx_sent_selection_functions
1740 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1741 (x_handle_selection_clear,x_clear_frame_selections):
1742 Pass Qx_lost_selection_functions rather than
1743 Vx_lost_selection_functions to Frun_hook_with_args.
1744
47ea7f44
PE
17452011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1746
ac389d0c 1747 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1748 The old code sometimes used this field without initializing it.
1749
47ea7f44
PE
1750 * alloc.c (gc_sweep): Don't read past end of array.
1751 In theory, the old code could also have corrupted Emacs internals,
1752 though it'd be very unlikely.
1753
bc985c87
AS
17542011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1755
1756 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1757 argument. (Bug#4026)
bc985c87 1758
0cf34688
LMI
17592011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1760
b3dadd76
LMI
1761 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1762 key" (bug#4257).
1763
0cf34688
LMI
1764 * window.c (Fset_window_start): Doc fix (bug#4199).
1765 (Fset_window_hscroll): Ditto.
1766
270768cd
PE
17672011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1768
077e3dda 1769 Fix minor new problems caught by GCC 4.6.1.
270768cd 1770 * term.c (init_tty): Remove unused local.
490011a6 1771 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1772 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1773 not used otherwise.
270768cd 1774
b1f58454
CY
17752011-07-12 Chong Yidong <cyd@stupidchicken.com>
1776
1777 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1778
22b9578d
LMI
17792011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1780
6e70ab07
LMI
1781 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1782 are the mini-buffer and the echo area (bug#3320).
1783
22b9578d
LMI
1784 * term.c (init_tty): Remove support for supdup, c10 and perq
1785 terminals, which are no longer supported (bug#1482).
1786
8974cc9f
JB
17872011-07-10 Johan Bockgård <bojohan@gnu.org>
1788
1789 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1790
a560d974
JD
17912011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1792
1793 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1794 for non-popups (Bug#3642).
1795
1dae0f0a
AS
17962011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1797
268c2c36 1798 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1799 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1800 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1801 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1802 * data.c (fmod): Likewise.
1803 * dispnew.c (swap_glyphs_in_rows): Likewise.
1804 * emacs.c (memory_warning_signal): Likewise.
1805 * floatfns.c (float_error): Likewise.
1806 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1807 (otf_open, font_otf_capability, generate_otf_features)
1808 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1809 Likewise.
1810 * image.c (pbm_read_file): Likewise.
1811 * indent.c (string_display_width): Likewise.
1812 * intervals.c (check_for_interval, search_for_interval)
1813 (inc_interval_count, count_intervals, root_interval)
1814 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1815 * lread.c (defalias): Likewise.
268c2c36 1816 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1817 * regex.c (set_image_of_range_1, set_image_of_range)
1818 (regex_grow_registers): Likewise.
1819 * sysdep.c (strerror): Likewise.
1820 * termcap.c (valid_filename_p, tprint, main): Likewise.
1821 * tparam.c (main): Likewise.
1822 * unexhp9k800.c (run_time_remap, save_data_space)
1823 (update_file_ptrs, read_header, write_header, calculate_checksum)
1824 (copy_file, copy_rest, display_header): Likewise.
1825 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1826 Likewise.
1827 * xdisp.c (check_it): Likewise.
1828 * xfaces.c (register_color, unregister_color, unregister_colors):
1829 Likewise.
1830 * xfns.c (print_fontset_result): Likewise.
1831 * xrdb.c (member, fatal, main): Likewise.
1832
99033785
PE
18332011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 Fix minor problems found by static checking (Bug#9031).
1836 * chartab.c (char_table_set_range, map_sub_char_table):
1837 Remove unused locals.
1838 (uniprop_table): Now static.
1839 * composite.c (_work_char): Remove unused static var.
1840
9cb2ac56
JB
18412011-07-09 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1844
f25661f0
JD
18452011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1846
1847 * gtkutil.c (qttip_cb): Remove code without function.
1848
8278c4fe
EZ
18492011-07-09 Eli Zaretskii <eliz@gnu.org>
1850
1851 * w32.c (pthread_sigmask): New stub.
1852
1692ae2d 18532011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1854
8a6ebd58 1855 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1856 sigprocmask is portable only for single-threaded applications, and
1857 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1858 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1859 (LIBES): Use it.
1860 * callproc.c (Fcall_process):
1861 * process.c (create_process):
1862 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1863 Use pthread_sigmask, not sigprocmask.
123403e4 1864
1b854618
JD
18652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1866
1867 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1868 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1869 wrong (Bug#8591).
1870
3fe4b549
JD
18712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1872
0ce7e563
JD
1873 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1874 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1875 (xg_hide_tooltip): Fix comment.
1876
3fe4b549
JD
1877 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1878 in registerServicesMenuSendTypes.
1879 (validRequestorForSendType): Don't check ns_return_types.
1880
1881 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1882 ns_return_type.
1883
5df75e47
JR
18842011-07-08 Jason Rumney <jasonr@gnu.org>
1885
1886 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1887 frame struct members of non-existent frames (Bug#6284).
1888
699c10bd
JD
18892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1890
4393663b
JD
1891 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1892 variable firstTime not needed on OSX >= 10.6.
1893 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1894 >= 10.5. Use setKnobProportion, setDoubleValue.
1895
1896 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1897 (MAC_OS_X_VERSION_10_5): Define if not defined.
1898 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1899 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1900 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1901
1902 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1903 cString and lossyCString on OSX >= 10.4
1904
1905 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1906 sizeToFit on OSX >= 10.2.
1907
1908 * nsimage.m (allocInitFromFile): Don't use deprecated method
1909 bestRepresentationForDevice on OSX >= 10.6.
1910
1911 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1912 to avoid warning.
1913
1914 * emacs.c: Declare unexec_init_emacs_zone.
1915
a63e0781
JD
1916 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1917
699c10bd
JD
1918 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1919
1920 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1921 on svcsMenu (Bug#8842).
1922
1923 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1924 ns_return_types.
1925 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1926
1927 * nsterm.m (QUTF8_STRING): Declare.
1928 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1929 (validRequestorForSendType): Return type is (id).
1930 Change indexOfObjectIdenticalTo to indexOfObject.
1931 Check if we have local selection before returning self (Bug#8842).
1932 (writeSelectionToPasteboard): Put local selection into paste board
1933 if we have a local selection (Bug#8842).
1934 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1935
1936 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1937 (ns_get_local_selection): Declare.
1938
54e10184
LMI
19392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940
9888ff71
LMI
1941 * keymap.c (describe_map_tree): Don't insert a double newline at
1942 the end of the buffer (bug#1169) and return whether we inserted
1943 something.
1944
54e10184
LMI
1945 * callint.c (Fcall_interactively): Change "reading args" to
1946 "providing args" to try to clarify what it does (bug#1010).
1947
15fa4783
KH
19482011-07-07 Kenichi Handa <handa@m17n.org>
1949
1950 * composite.c (composition_compute_stop_pos): Ignore a static
1951 composition starting before CHARPOS (Bug#8915).
1952
1953 * xdisp.c (handle_composition_prop): Likewise.
1954
a8815b00
EZ
19552011-07-07 Eli Zaretskii <eliz@gnu.org>
1956
1957 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1958 (Bug#9015)
1959
ef7b981d 19602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1961
1962 * character.h (unicode_category_t): New enum type.
1963
1964 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1965 (Qchar_code_property_table): New variable.
1966 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1967 (UNIPROP_COMPRESSED_FORM_P): New macros.
1968 (char_table_ascii): Uncompress the compressed values.
1969 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1970 Uncompress the compressed values.
ac389d0c 1971 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1972 (char_table_ref_and_range): Uncompress the compressed values.
1973 (sub_char_table_set): New arg is_uniprop. Callers changed.
1974 Uncompress the compressed values.
1975 (sub_char_table_set_range): Args changed. Callers changed.
1976 (char_table_set_range): Adjuted for the above change.
1977 (map_sub_char_table): Delete args default_val and parent. Add arg
1978 top. Give decoded values to a Lisp function.
640c8776 1979 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1980 values to a Lisp function. Gcpro more variables.
1981 (uniprop_table_uncompress)
1982 (uniprop_decode_value_run_length): New functions.
1983 (uniprop_decoder, uniprop_decoder_count): New variables.
1984 (uniprop_get_decoder, uniprop_encode_value_character)
1985 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1986 New functions.
1987 (uniprop_encoder, uniprop_encoder_count): New variables.
1988 (uniprop_get_encoder, uniprop_table)
1989 (Funicode_property_table_internal, Fget_unicode_property_internal)
1990 (Fput_unicode_property_internal): New functions.
1991 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1992 Sunicode_property_table_internal, Sget_unicode_property_internal,
1993 and Sput_unicode_property_internal. Defvar_lisp
1994 char-code-property-alist.
1995
640c8776 1996 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1997 Vunicode_category_table.
1998
640c8776 1999 * font.c (font_range): Adjust for the change of
c805dec0
KH
2000 Vunicode_category_table.
2001
76b397fb
DN
20022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2003
2004 * m/iris4d.h: Remove file, move contents ...
2005 * s/irix6-5.h: ... here.
2006
22b4128e
PE
20072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2010 * alloc.c (mark_buffer):
2011 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2012 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2013 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2014 This isn't true in general, and it's particularly not true
2015 if Emacs is configured with --with-wide-int.
2016 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2017 New macros, used in the buffer.c change.
2018
869795d6
JD
20192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2020
2021 * xsettings.c: Use both GConf and GSettings if both are available.
2022 (store_config_changed_event): Add comment.
2023 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2024 (store_tool_bar_style_changed): New functions.
2025 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2026 (struct xsettings): Move font inside HAVE_XFT.
2027 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2028 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2029 Move inside HAVE_XFT.
640c8776 2030 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2031 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2032 also.
2033 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2034 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2035 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2036 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2037 (parse_settings): Move check for font inside HAVE_XFT.
2038 (read_settings, apply_xft_settings): Add comment.
2039 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2040 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2041 call store_font_name_changed.
2042 (xft_settings_event): Add comment.
2043 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2044 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2045 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2046 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2047 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2048 (xsettings_get_system_font, xsettings_get_system_normal_font):
2049 Add comment.
869795d6 2050
d8ed26bd
PE
20512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 Random fixes. E.g., (random) never returned negative values.
2054 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2055 subseconds part to the entropy, as that's a bit more random.
2056 Prefer signed to unsigned, since the signedness doesn't matter and
2057 in general we prefer signed. When given a limit, use a
2058 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2059 latter isn't right if USE_2_TAGS_FOR_INTS.
2060 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2061 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2062
cabf1cac
SM
20632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2064
2065 * textprop.c (text_property_stickiness):
2066 Obey Vtext_property_default_nonsticky.
2067 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2068 * w32fns.c (syms_of_w32fns):
2069 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2070
6e9b2be9
PE
20712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2074 This is more efficient than Ffile_directory_p and avoids a minor race.
2075
90186c68
LMI
20762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2077
7c301272
LMI
2078 * buffer.c (Foverlay_put): Say what the return value is
2079 (bug#7835).
2080
c4f2d8d4
LMI
2081 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2082 is a directory before asking whether to use the file name
2083 (bug#7564).
ad637907
LMI
2084 (barf_or_query_if_file_exists): Make the "File is a directory"
2085 error be more correct.
c4f2d8d4 2086
90186c68
LMI
2087 * fns.c (Frequire): Remove the mention of the .gz files, since
2088 that's installation-specific, but keep the mention of
2089 `get-load-suffixes'.
2090
da64016e
PE
20912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2094 Report string overflow if the output is too long.
2095
7d47b580
JB
20962011-07-04 Juanma Barranquero <lekktu@gmail.com>
2097
a555cb87
JB
2098 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2099 (syms_of_gnutls): Remove duplicate DEFSYM for
2100 Qgnutls_bootprop_verify_hostname_error, an error for
2101 Qgnutls_bootprop_verify_error (which is no longer used).
2102
7d47b580
JB
2103 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2104 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2105 Also (re)move comments that are misplaced or no longer relevant.
2106
1e49bfab
LMI
21072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2108
2109 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2110
1485f4c0
CY
21112011-07-03 Chong Yidong <cyd@stupidchicken.com>
2112
2113 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2114 and background color parameters if they have been changed.
2115
a9ab721e
LMI
21162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2117
2118 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2119
cf7cff57
PE
21202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2121
2e13213d
PE
2122 * xsettings.c (SYSTEM_FONT): Define only when used.
2123 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2124
cf7cff57
PE
2125 * keymap.c (access_keymap_1): Now static.
2126
7a8e04f7
CY
21272011-07-02 Chong Yidong <cyd@stupidchicken.com>
2128
2129 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2130 leave any prefix arg for the up event (Bug#1586).
2131
61352f62
LMI
21322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2133
69bb1ef7
LMI
2134 * lread.c (syms_of_lread): Mention single symbols defined by
2135 `defvar' or `defconst' (bug#7154).
2136
61352f62 2137 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2138 (Frequire): Mention get-load-suffixes.
61352f62 2139
28545e04
MR
21402011-07-02 Martin Rudalics <rudalics@gmx.at>
2141
2142 * window.h (window): Remove clone_number slot.
2143 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2144 Remove.
2145 (make_parent_window, make_window, saved_window)
2146 (Fset_window_configuration, save_window_save): Don't deal with
2147 clone numbers.
2148 * buffer.c (Qclone_number): Remove declaration.
2149 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2150
3349e122
SM
21512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2152
2153 Add multiple inheritance to keymaps.
2154 * keymap.c (Fmake_composed_keymap): New function.
2155 (Fset_keymap_parent): Simplify.
2156 (fix_submap_inheritance): Remove.
2157 (access_keymap_1): New function extracted from access_keymap to handle
2158 embedded parents and handle lists of maps.
2159 (access_keymap): Use it.
2160 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2161 (Fcopy_keymap): Handle embedded parents.
2162 (Fcommand_remapping, define_as_prefix): Simplify.
2163 (Fkey_binding): Simplify.
2164 (syms_of_keymap): Move minibuffer-local-completion-map,
2165 minibuffer-local-filename-completion-map,
2166 minibuffer-local-must-match-map, and
2167 minibuffer-local-filename-must-match-map to Elisp.
2168 (syms_of_keymap): Defsubr make-composed-keymap.
2169 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2170 (parse_menu_item): Trivial simplification.
2171
3279eb87
GM
21722011-07-01 Glenn Morris <rgm@gnu.org>
2173
2174 * Makefile.in (SETTINGS_LIBS): Fix typo.
2175
4550efdf
KI
21762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2177
2178 * coding.c (Fencode_coding_string): Record the last coding system
2179 used, as the function doc string says (bug#8738).
2180
0949d2b6
JD
21812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2182
2183 * xsettings.c (store_monospaced_changed): Take new font as arg and
2184 check for change against current_mono_font.
2185 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2186 (emacs_settings_constructor, emacs_settings_get_property)
2187 (emacs_settings_set_property, emacs_settings_class_init)
2188 (emacs_settings_init, gsettings_obj): Remove.
2189 (something_changedCB): New function for HAVE_GSETTINGS.
2190 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2191 with value as argument.
2192 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2193 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2194 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2195 "changed".
2196
2197 * xgselect.c: Add defined (HAVE_GSETTINGS).
2198 (xgselect_initialize): Ditto.
2199
2200 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2201 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2202 xg_select.
2203
bbc6b304
PE
22042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 * eval.c (struct backtrace): Simplify and port the data structure.
2207 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2208 signed bit field, as this assumption is not portable and it makes
2209 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2210 "char debug_on_exit : 1" as this is not portable either; instead,
2211 use the portable "unsigned int debug_on_exit : 1". Remove unused
2212 member evalargs. Remove obsolete comments about cc bombing out.
2213
9851bfc5
JD
22142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2215
51bb811f 2216 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2217 Let HAVE_GSETTINGS override HAVE_GCONF.
2218 (store_monospaced_changed): New function.
2219 (EMACS_SETTINGS): A new type derived from GObject to handle
2220 GSettings notifications.
2221 (emacs_settings_constructor, emacs_settings_get_property)
2222 (emacs_settings_set_property, emacs_settings_class_init):
2223 New functions.
2224 (gsettings_client, gsettings_obj): New variables.
2225 (GSETTINGS_SCHEMA): New define.
2226 (something_changedCB): Call store_monospaced_changed.
2227 (init_gsettings): New function.
2228 (xsettings_initialize): Call init_gsettings.
2229 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2230 to NULL.
2231
640c8776 2232 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2233 GCONF_CFLAGS/LIBS.
2234
5386012d
MR
22352011-06-29 Martin Rudalics <rudalics@gmx.at>
2236
2237 * window.c (resize_root_window, grow_mini_window)
2238 (shrink_mini_window): Rename Qresize_root_window to
2239 Qwindow_resize_root_window and Qresize_root_window_vertically to
2240 Qwindow_resize_root_window_vertically.
2241
f13e0b08
PE
22422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2245
94515237
JB
22462011-06-27 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * makefile.w32-in: Redesign dependencies so they reflect more
2249 clearly which files are directly included by each source file,
2250 and not through other includes.
2251
e43b6e43
MR
22522011-06-27 Martin Rudalics <rudalics@gmx.at>
2253
2254 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2255 (sort_overlays, overlay_strings): When an overlay's clone number
2256 matches the window's clone number process the overlay even if
2257 the overlay's window property doesn't match the current window.
2258
d68443dc
MR
2259 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2260 (Fwindow_hchild): Rename to Fwindow_left_child.
2261 (Fwindow_next): Rename to Fwindow_next_sibling.
2262 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2263 (resize_window_check): Rename to window_resize_check.
2264 (resize_window_apply): Rename to window_resize_apply.
2265 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2266 (Fdelete_other_windows_internal, resize_frame_windows)
2267 (Fsplit_window_internal, Fdelete_window_internal)
2268 (grow_mini_window, shrink_mini_window)
2269 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2270
c7e73be5
JD
22712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2272
2273 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2274 (emacs_fixed_set_min_size): Remove.
2275 (emacs_fixed_new): Take frame as argument.
2276
2277 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2278 (_EmacsFixedPrivate): Remove minwidth/height.
2279 Add struct frame *f.
2280 (emacs_fixed_init): Initialize priv->f.
2281 (get_parent_class, emacs_fixed_set_min_size): Remove.
2282 (emacs_fixed_new): Set priv->f to argument.
2283 (emacs_fixed_get_preferred_width)
2284 (emacs_fixed_get_preferred_height): Use min_width/height from
2285 frames size_hint to set minimum and natural (Bug#8919).
2286 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2287 and use min_width/height from frames size_hint to set
2288 min_width/height (Bug#8919).
2289
2290 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2291 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2292 Fix indentation.
c7e73be5 2293
cf99dcf8
EZ
22942011-06-26 Eli Zaretskii <eliz@gnu.org>
2295
2296 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2297 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2298 called at ZV.
2299
029529ac
CY
23002011-06-26 Chong Yidong <cyd@stupidchicken.com>
2301
2302 * process.c (wait_reading_process_output): Bypass select if
2303 waiting for a cell while ignoring keyboard input, and input is
2304 pending. Suggested by Jan Djärv (Bug#8869).
2305
7a7ef429
PE
23062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Use gnulib's dup2 module instead of rolling our own.
2309 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2310
11fdef7d 23112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2312
2313 * dispnew.c (scrolling_window): Before scrolling, turn off a
2314 mouse-highlight in the window being scrolled.
2315
cd3520a4
JB
23162011-06-24 Juanma Barranquero <lekktu@gmail.com>
2317
2318 Move DEFSYM to lisp.h and use everywhere.
2319
2320 * character.h (DEFSYM): Move declaration...
2321 * lisp.h (DEFSYM): ...here.
2322
2323 * gnutls.c:
2324 * minibuf.c:
2325 * w32menu.c:
2326 * w32proc.c:
2327 * w32select.c: Don't include character.h.
2328
2329 * alloc.c (syms_of_alloc):
2330 * buffer.c (syms_of_buffer):
2331 * bytecode.c (syms_of_bytecode):
2332 * callint.c (syms_of_callint):
2333 * casefiddle.c (syms_of_casefiddle):
2334 * casetab.c (init_casetab_once):
2335 * category.c (init_category_once, syms_of_category):
2336 * ccl.c (syms_of_ccl):
2337 * cmds.c (syms_of_cmds):
2338 * composite.c (syms_of_composite):
2339 * dbusbind.c (syms_of_dbusbind):
2340 * dired.c (syms_of_dired):
2341 * dispnew.c (syms_of_display):
2342 * doc.c (syms_of_doc):
2343 * editfns.c (syms_of_editfns):
2344 * emacs.c (syms_of_emacs):
2345 * eval.c (syms_of_eval):
2346 * fileio.c (syms_of_fileio):
2347 * fns.c (syms_of_fns):
2348 * frame.c (syms_of_frame):
2349 * fringe.c (syms_of_fringe):
2350 * insdel.c (syms_of_insdel):
2351 * keymap.c (syms_of_keymap):
2352 * lread.c (init_obarray, syms_of_lread):
2353 * macros.c (syms_of_macros):
2354 * msdos.c (syms_of_msdos):
2355 * print.c (syms_of_print):
2356 * process.c (syms_of_process):
2357 * search.c (syms_of_search):
2358 * sound.c (syms_of_sound):
2359 * syntax.c (init_syntax_once, syms_of_syntax):
2360 * terminal.c (syms_of_terminal):
2361 * textprop.c (syms_of_textprop):
2362 * undo.c (syms_of_undo):
2363 * w32.c (globals_of_w32):
2364 * window.c (syms_of_window):
2365 * xdisp.c (syms_of_xdisp):
2366 * xfaces.c (syms_of_xfaces):
2367 * xfns.c (syms_of_xfns):
2368 * xmenu.c (syms_of_xmenu):
2369 * xsettings.c (syms_of_xsettings):
2370 * xterm.c (syms_of_xterm): Use DEFSYM.
2371
4228cf16
TZ
23722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2373
cd3520a4 2374 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2375
7fcccf1e
PE
23762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2377
7efb4e0e
PE
2378 Integer and buffer overflow fixes (Bug#8873).
2379
ff5844ad
PE
2380 * print.c (printchar, strout): Check for string overflow.
2381 (PRINTPREPARE, printchar, strout):
2382 Don't set size unless allocation succeeds.
2383
90532f02
PE
2384 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2385 for sizes. Check for string overflow more accurately.
2386 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2387
6d84508d
PE
2388 * macros.c: Integer and buffer overflow fixes.
2389 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2390 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2391 Use ptrdiff_t, not int, for sizes.
2392 Don't increment bufsize until after realloc succeeds.
2393 Check for size-calculation overflow.
2394 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2395
437b2cb4
PE
2396 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2397
8b9ac8b4
PE
2398 * lread.c: Integer overflow fixes.
2399 (read_integer): Radix is now EMACS_INT, not int,
2400 to improve quality of diagnostics for out-of-range radices.
2401 Calculate buffer size correctly for out-of-range radices.
2402 (read1): Check for integer overflow in radices, and in
2403 read-circle numbers.
82cb60d3
PE
2404 (read_escape): Avoid int overflow.
2405 (Fload, openp, read_buffer_size, read1)
2406 (substitute_object_recurse, read_vector, read_list, map_obarray):
2407 Use ptrdiff_t, not int, for sizes.
2408 (read1): Use EMACS_INT, not int, for sizes.
20270765 2409 Check for size overflow.
8b9ac8b4 2410
7fcccf1e
PE
2411 * image.c (cache_image): Check for size arithmetic overflow.
2412
bfbbd7e7
PE
2413 * lread.c: Integer overflow issues.
2414 (saved_doc_string_size, saved_doc_string_length)
2415 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2416 Now ptrdiff_t, not int.
2417 (read1): Don't assume doc string length fits in int. Check for
2418 out-of-range doc string lengths.
2419 (read_list): Don't assume file position fits in int.
39019e54 2420 (read_escape): Check for hex character overflow.
bfbbd7e7 2421
4e323265
LL
24222011-06-22 Leo Liu <sdl.web@gmail.com>
2423
2424 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2425 Move to minibuffer.el.
2426
85fece3e
PE
24272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2428
20b84ce9 2429 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2430 The following patches are for when GLYPH_DEBUG && !XASSERT.
2431 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2432 * dispnew.c (flush_stdout):
2433 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2434 Mark as externally visible.
2435 * dispnew.c (check_window_matrix_pointers): Now static.
2436 * dispnew.c (window_to_frame_vpos):
2437 * xfns.c (unwind_create_frame):
2438 * xterm.c (x_check_font): Remove unused local.
2439 * scroll.c (CHECK_BOUNDS):
2440 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2441 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2442 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2443 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2444 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2445 Now static.
2446 (debug_method_add): Use va_list and vsprintf rather than relying
2447 on undefined behavior with wrong number of arguments.
2448 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2449 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2450 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2451 since we're not interested in debugging glyphs with old libraries.
2452 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2453 GCC 4.6.0's static checking.
2454
0766b489
PE
24552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2456
31fd4b32
PE
2457 Integer overflow and signedness fixes (Bug#8873).
2458 A few related buffer overrun fixes, too.
2459
b79e8648
PE
2460 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2461
0766b489
PE
2462 * dispextern.h (struct face.stipple):
2463 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2464 (x_bitmap_mask, x_allocate_bitmap_record)
2465 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2466 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2467 (x_create_bitmap_from_xpm_data):
2468 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2469 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2470 (.bitmaps_last):
2471 * xfaces.c (load_pixmap):
2472 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2473 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2474 (.bitmaps_last, struct x_output.icon_bitmap):
2475 Use ptrdiff_t, not int, for bitmap indexes.
2476 (x_allocate_bitmap_record): Check for size overflow.
2477 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2478
b081724f
PE
2479 Use ptrdiff_t, not int, for overlay counts.
2480 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2481 * editfns.c (overlays_around, get_pos_property):
2482 * textprop.c (get_char_property_and_overlay):
2483 * xdisp.c (next_overlay_change, note_mouse_highlight):
2484 * xfaces.c (face_at_buffer_position):
21514da7
PE
2485 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2486 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2487 (Fnext_overlay_change, Fprevious_overlay_change)
2488 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2489 Use ptrdiff_t, not int, for sizes.
21514da7 2490 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2491
3de73e5e
PE
2492 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2493
2606c57b
PE
2494 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2495 (x_session_initialize): Do not assume string length fits in int.
2496
aaafe47a
PE
2497 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2498 This is unlikely, but can occur if DPI is outlandish.
2499
2674ddc8 2500 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2501 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2502
28154962
PE
2503 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2504 * xrdb.c (magic_file_p, search_magic_path):
2505 Omit last arg SUFFIX; it was always 0. All callers changed.
2506 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2507
7de51af5
PE
2508 * xfont.c (xfont_match): Avoid need for strlen.
2509
25ed6cc3
PE
2510 * xfns.c: Don't assume strlen fits in int.
2511 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2512
4eab31dd
PE
2513 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2514 not unsigned long, as we prefer signed integers. All callers changed.
2515 Detect integer overflow in repeat count.
2516 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2517 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2518
171e2a58
PE
2519 * termcap.c: Don't assume sizes fit in int and never overflow.
2520 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2521 (gobble_line): Check for size-calculation overflow.
2522
ad39faca 2523 * minibuf.c (Fread_buffer):
6e5bb2dc 2524 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2525 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2526 Don't assume string length fits in int.
2527
52c61c22 2528 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2529 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2530
b5b8c9e5
PE
2531 * font.c: Don't assume string length fits in int.
2532 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2533 Use ptrdiff_t, not int.
ccd6111c
PE
2534 (font_intern_prop): Don't assume string length fits in int.
2535 Don't assume integer property fits in fixnum.
2536 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2537
882f0d81 2538 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2539 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2540 Reformulate so as not to need the command string.
2541 Invoke gzip -cd rather than gunzip, as it's more portable.
2542 (lock_info_type, lock_file_1, lock_file):
2543 Don't assume pid_t and time_t fit in unsigned long.
2544 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2545 (current_lock_owner): Prefer signed type for sizes.
2546 Use memcpy, not strncpy, where memcpy is what is really wanted.
2547 Don't assume (via atoi) that time_t and pid_t fit in int.
2548 Check for time_t and/or pid_t out of range, e.g., via a network share.
2549 Don't alloca where an auto var works fine.
2550
93f4cf88
PE
2551 * fileio.c: Fix some integer overflow issues.
2552 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2553 Don't assume string length fits in int.
2554 (directory_file_name): Don't assume string length fits in long.
2555 (make_temp_name): Don't assume pid fits in int, or that its print
2556 length is less than 20.
2557
f3e92b69
PE
2558 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2559
1bfdaf10
PE
2560 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2561
35016e9a
PE
2562 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2563
3d1e65a1
PE
2564 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2565 We prefer signed integers, even for size calculations.
2566
0b963a93
PE
2567 * emacs.c: Don't assume string length fits in 'int'.
2568 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2569 (main): Don't invoke strlen when not needed.
2570
573f4b54
PE
2571 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2572 (XD_DEBUG_MESSAGE): Don't waste a byte.
2573
989f33ba
PE
2574 * callproc.c (getenv_internal_1, getenv_internal)
2575 (Fgetenv_internal):
965d34eb
PE
2576 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2577
e4d29b33
PE
2578 * lread.c (invalid_syntax): Omit length argument.
2579 All uses changed. This doesn't fix a bug, but it simplifies the
2580 code away from its former Hollerith-constant appearance, and it's
2581 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2582 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2583
eb49b136
PE
2584 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2585 This didn't break anything, but it didn't help either.
2586 It's confusing to put a bogus integer in a place where the actual
2587 value does not matter.
9f62aeb1 2588 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2589 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2590
15375a22
PE
2591 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2592 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2593 implementation.
b61cc01c
PE
2594 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2595 We prefer signed types, and the value cannot exceed the EMACS_INT
2596 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2597 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2598 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2599 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2600
53b2623d
PE
2601 * indent.c (sane_tab_width): New function.
2602 (current_column, scan_for_column, Findent_to, position_indentation)
2603 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2604 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2605
51cab52b 2606 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2607
f2ed8a70
PE
2608 * lisp.h (lint_assume): New macro.
2609 * composite.c (composition_gstring_put_cache):
2610 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2611
abe80cc6
PE
2612 * editfns.c, insdel.c:
2613 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2614
b02c740e
PE
2615 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2616
ebc96716
PE
2617 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2618
b4e50fa0 2619 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2620 Use much-faster test for byte-length change.
311d5d7c 2621 Don't assume string byte-length fits in 'int'.
a4cf38e4 2622 Check that character arg fits in 'int'.
85461888 2623 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2624
c0c1ee9f
PE
2625 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2626
a498d7f4
PE
2627 * fns.c (concat): Catch string overflow earlier.
2628 Do not rely on integer wraparound.
2629
51cab52b
PE
2630 * dispextern.h (struct it.overlay_strings_charpos)
2631 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2632 * xdisp.c (forward_to_next_line_start)
2633 (back_to_previous_visible_line_start)
2634 (reseat_at_next_visible_line_start, next_element_from_buffer):
2635 Don't arbitrarily truncate the value of 'selective' to int.
2636
76031fad
PE
2637 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2638
5eb55db9
PE
2639 * composite.c: Don't truncate sizes to 'int'.
2640 (composition_gstring_p, composition_reseat_it)
2641 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2642 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2643 not EMACS_UINT, for indexes.
5eb55db9 2644
0703a717
PE
2645 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2646
d6202519
PE
2647 * buffer.c: Include <verify.h>.
2648 (struct sortvec.priority, struct sortstr.priority):
8961a454 2649 Now EMACS_INT, not int.
c20998a7 2650 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2651 (struct sortstr.size, record_overlay_string)
2652 (struct sortstrlist.size, struct sortlist.used):
2653 Don't truncate size to int.
2654 (record_overlay_string): Check for size-calculation overflow.
d6202519 2655 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2656
d5a19415
JM
26572011-06-22 Jim Meyering <meyering@redhat.com>
2658
029529ac 2659 Don't leak an XBM-image-sized buffer
d5a19415
JM
2660 * image.c (xbm_load): Free the image buffer after using it.
2661
a9041e6c
PE
26622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Port to Sun C.
2665 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2666 that Sun C diagnosed.
2667 * fns.c (secure_hash): Fix pointer signedness issue.
2668 * intervals.c (static_offset_intervals): New function.
2669 (offset_intervals): Use it.
2670
7f3f739f
LL
26712011-06-21 Leo Liu <sdl.web@gmail.com>
2672
2673 * deps.mk (fns.o):
2674 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2675 sha512.h.
2676
2677 * fns.c (secure_hash): Rename from crypto_hash_function and change
2678 the first arg to accept symbols.
5b66d427 2679 (Fsecure_hash): New primitive.
7f3f739f
LL
2680 (syms_of_fns): New symbols.
2681
76147d94
DD
26822011-06-20 Deniz Dogan <deniz@dogan.se>
2683
2684 * process.c (Fset_process_buffer): Clarify return value in
2685 docstring.
2686
7d7d0045
CY
26872011-06-18 Chong Yidong <cyd@stupidchicken.com>
2688
2689 * dispnew.c (add_window_display_history): Use BVAR.
2690
2691 * xdisp.c (debug_method_add): Use BVAR.
2692 (check_window_end, dump_glyph_matrix, dump_glyph)
2693 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2694
2695 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2696 Likewise.
2697
2698 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2699 check till after the cache is created in init_frame_faces.
2700
ff2bc410
SM
27012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2702
2703 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2704
28177add
PE
27052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2706
dd3482fe
PE
2707 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2708 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2709 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2710
393d71f3 2711 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2712 * fileio.c (Finsert_file_contents):
2713 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2714 Remove the old (too-loose) buffer overflow checks.
2715 They weren't needed, since make_gap checks for buffer overflow.
2716 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2717 The old code merely checked for Emacs fixnum overflow, and relied
2718 on undefined (wraparound) behavior. The new code avoids undefined
2719 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2720
2e6813b0 2721 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2722 Tune. Don't use wider integers than needed. Don't use alloca.
2723 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2724
599a9e4f
PE
2725 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2726
99561444
PE
2727 * insdel.c, lisp.h (buffer_overflow): New function.
2728 (insert_from_buffer_1, replace_range, replace_range_2):
2729 * insdel.c (make_gap_larger):
2730 * editfns.c (Finsert_char):
2731 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2732
28177add
PE
2733 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2734
e69dafad
PE
27352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2736
a7af7fde 2737 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2738
b1c46f02
PE
2739 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2740 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2741
e69dafad
PE
2742 * fileio.c: Don't assume EMACS_INT fits in off_t.
2743 (emacs_lseek): New static function.
2744 (Finsert_file_contents, Fwrite_region): Use it.
2745 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2746
566684ea
PE
2747 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2748
e6966cd6
PE
2749 * fns.c: Don't overflow int when computing a list length.
2750 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2751 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2752 truncation on 64-bit hosts. Check for QUIT every
2753 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2754 faster and is responsive enough.
2755 (Flength): Report an error instead of overflowing an integer.
2756 (Fsafe_length): Return a float if the value is not representable
2757 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2758 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2759 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2760
dd0b0efb
PE
2761 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2762 (header_size, word_size): New constants.
2763 (allocate_vectorlike): Don't check size overflow here.
2764 (allocate_vector): Check it here instead, since this is the only
2765 caller of allocate_vectorlike that could cause overflow.
2766 Check that the new vector's length is representable as a fixnum.
2767
86fe5cfe
PE
2768 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2769 The previous code was bogus. For example, next_almost_prime (32)
2770 returned 39, which is undesirable as it is a multiple of 3; and
2771 next_almost_prime (24) returned 25, which is a multiple of 5 so
2772 why was the code bothering to check for multiples of 7?
2773
80e88859
PE
2774 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2775
4a2f0ad6
PE
2776 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2777
f66c7cf8
PE
2778 Variadic C functions now count arguments with ptrdiff_t.
2779 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2780 Back then I didn't know that the Emacs coding style prefers signed int.
2781 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2782 were being counted with int, which may truncate counts on 64-bit
2783 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2784 * lisp.h (struct Lisp_Subr.function.aMANY)
2785 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2786 Arg counts are now ptrdiff_t, not size_t.
2787 All variadic functions and their callers changed accordingly.
2788 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2789 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2790 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2791 * callint.c (Fcall_interactively): Check arg count for overflow,
2792 to avoid potential buffer overrun. Use signed char, not 'int',
2793 for 'varies' array, so that we needn't bother to check its size
2794 calculation for overflow.
2795 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2796 * eval.c (apply_lambda):
2797 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2798 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2799 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2800
a1759b76
PE
2801 * callint.c (Fcall_interactively): Don't use index var as event count.
2802
d96be9fc
PE
2803 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2804 * mem-limits.h (SIZE): Remove; no longer used.
2805
a690a978 2806 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2807
578c21e6
PE
2808 Remove unnecessary casts.
2809 * xterm.c (x_term_init):
2810 * xfns.c (x_set_border_pixel):
2811 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2812 These aren't needed now that we assume ANSI C.
2813
96f53c6c
PE
2814 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2815 It's more likely to cause problems (due to unsigned overflow)
2816 than to cure them.
2817
83c77d31
PE
2818 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2819
ee2079f1
PE
2820 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2821
6da65536
PE
2822 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2823
7147c4a4
PE
2824 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2825
193e32d9
PE
2826 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2827
e5533da6
PE
2828 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2829
9910e595
PE
2830 GLYPH_CODE_FACE returns EMACS_INT, not int.
2831 * dispextern.h (merge_faces):
2832 * xfaces.c (merge_faces):
01103c44
PE
2833 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2834 Don't assume EMACS_INT fits in int.
9910e595 2835
2638320e
PE
2836 * character.h (CHAR_VALID_P): Remove unused parameter.
2837 * fontset.c, lisp.h, xdisp.c: All uses changed.
2838
045eb8d9
PE
2839 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2840
c1f134b5
PE
2841 * fns.c (concat): Minor tuning based on overflow analysis.
2842 This doesn't fix any bugs. Use int to hold character, instead
2843 of constantly refetching from Emacs object. Use XFASTINT, not
2844 XINT, for value known to be a character. Don't bother comparing
2845 a single byte to 0400, as it's always less.
2846
395fcb93 2847 * floatfns.c (Fexpt):
327eeec8
PE
2848 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2849
abbd3d23
PE
2850 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2851 for characters.
2852
684a03ef
PE
2853 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2854
0fed43f3
PE
2855 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2856 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2857 incorrectly succeed when S was a string, because 4294967386 was
2858 truncated before it was used.
2859
8fd02eb7
PE
2860 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2861 Otherwise, an out-of-range integer could cause undefined behavior
2862 on a 64-bit host.
2863
f8c86b69
PE
2864 * composite.c: Use int, not EMACS_INT, for characters.
2865 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2866 EMACS_INT, for values that are known to be in character range.
2867 This doesn't fix any bugs but is the usual style inside Emacs and
2868 may generate better code on 32-bit machines.
2869
34206dd2
PE
2870 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2871 This is for reasons similar to the recent CHAR_STRING fix.
2872 * charset.c (Fencode_char): Check that character arg is actually
2873 a character. Pass an int to ENCODE_CHAR.
2874 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2875 wider than 'int', as a compile-time check to prevent future regressions
2876 in this area.
2877
c5958d4c 2878 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2879
2880 Make sure a 64-bit char is never passed to CHAR_STRING.
2881 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2882 by silently ignoring the top 32 bits, allowing some values
2883 that were far too large to be valid characters.
2884 * character.h: Include <verify.h>.
2885 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2886 arguments are no wider than unsigned, as a compile-time check
2887 to prevent future regressions in this area.
2888 * data.c (Faset):
01103c44 2889 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2890 (Fsubst_char_in_region):
2891 * fns.c (concat):
2892 * xdisp.c (decode_mode_spec_coding):
2893 Adjust to CHAR_STRING's new requirement.
2894 * editfns.c (Finsert_char, Fsubst_char_in_region):
2895 * fns.c (concat): Check that character args are actually
2896 characters. Without this test, these functions did the wrong
2897 thing with wildly out-of-range values on 64-bit hosts.
2898
d37ca623
PE
2899 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2900 These casts should not be needed on 32-bit hosts, either.
2901 * keyboard.c (read_char):
2902 * lread.c (Fload): Remove casts to unsigned.
2903
ea204efb
PE
2904 * lisp.h (UNSIGNED_CMP): New macro.
2905 This fixes comparison bugs on 64-bit hosts.
2906 (ASCII_CHAR_P): Use it.
2907 * casefiddle.c (casify_object):
01103c44 2908 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2909 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2910 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2911 * dispextern.h (FACE_FROM_ID):
2912 * keyboard.c (read_char): Use UNSIGNED_CMP.
2913
41cb286c
PE
2914 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2915 not to EMACS_INT, to avoid GCC warning.
2916
4a1b9832
PE
2917 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2918
55daad71
PE
2919 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2920 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2921 isn't needed on 32-bit machines.
8f95c75c 2922
01103c44
PE
2923 * buffer.c (Fgenerate_new_buffer_name):
2924 Use EMACS_INT for count, not int.
0ceccced 2925 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2926
2927 * data.c (Qcompiled_function): Now static.
2928
c6f072e7
PE
2929 * window.c (window_body_lines): Now static.
2930
20ce5912
PE
2931 * image.c (gif_load): Rename local to avoid shadowing.
2932
9c4c5f81
PE
2933 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2934 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2935 * alloc.c (make_save_value): Integer argument is now of type
2936 ptrdiff_t, not int.
2937 (mark_object): Use ptrdiff_t, not int.
2938 * lisp.h (pD): New macro.
2939 * print.c (print_object): Use it.
2940
c0c5c8ae
PE
2941 * alloc.c: Use EMACS_INT, not int, to count objects.
2942 (total_conses, total_markers, total_symbols, total_vector_size)
2943 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2944 (total_free_floats, total_floats, total_free_intervals)
2945 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2946 Now EMACS_INT, not int. All uses changed.
2947 (Fgarbage_collect): Compute overall total using a double, so that
2948 integer overflow is less likely to be a problem. Check for overflow
2949 when converting back to an integer.
5a25e253
PE
2950 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2951 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2952 These were 'int' variables that could overflow on 64-bit hosts;
2953 they were never used, so remove them instead of repairing them.
211a0b2a 2954 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2955 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2956 Previously, this ceilinged at INT_MAX, but that doesn't work on
2957 64-bit machines.
e46bb31a 2958 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2959
c78baabf 2960 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2961 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2962 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2963 when a (possibly-narrower) signed value would do just as well.
2964 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2965
c9d624c6
PE
2966 * alloc.c: Catch some string size overflows that we were missing.
2967 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2968 for convenience in STRING_BYTES_MAX.
2969 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2970 The definition here is exact; the one in lisp.h was approximate.
2971 (allocate_string_data): Check for string overflow. This catches
2972 some instances we weren't catching before. Also, it catches
2973 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2974 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2975 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2976
c9d624c6
PE
2977 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2978 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2979 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2980
353032ce
PE
2981 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2982
2bccce07
PE
2983 * alloc.c (Fmake_string): Check for out-of-range init.
2984
0ac30604
SM
29852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2986
2987 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2988
c195f2de
JD
29892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2990
2991 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2992 xg_get_default_scrollbar_width.
2993
2994 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2995 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2996 (style_changed_cb): Call update_theme_scrollbar_width and call
2997 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2998 all frames (Bug#8505).
2999 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3000 Call gtk_window_set_resizable if HAVE_GTK3.
3001 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3002 and height if HAVE_GTK3 (Bug#8505).
3003 (scroll_bar_width_for_theme): New variable.
3004 (update_theme_scrollbar_width): New function.
3005 (xg_get_default_scrollbar_width): Move code to
3006 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3007 (xg_initialize): Call update_theme_scrollbar_width.
3008
3009 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3010
3011 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3012
e10ac9f1
MR
30132011-06-12 Martin Rudalics <rudalics@gmx.at>
3014
3015 * frame.c (make_frame): Call other_buffer_safely instead of
3016 other_buffer.
3017
3018 * window.c (temp_output_buffer_show): Call display_buffer with
3019 second argument Vtemp_buffer_show_specifiers and reset latter
3020 immediately after the call.
3021 (Vtemp_buffer_show_specifiers): New variable.
3022 (auto_window_vscroll_p, next_screen_context_lines)
3023 (Vscroll_preserve_screen_position): Remove leading asterisks from
3024 doc-strings.
3025
2d3c217e 30262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3027
7b7f97e8 3028 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3029 * buffer.c (Qclone_number): Remove for now, as it's unused.
3030 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3031 (record_buffer): Remove unused local.
3032 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3033 (set_frame_buffer_list): Remove; unused.
3034 * frame.h (other_visible_frames): Remove decl.
3035 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3036 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3037 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3038 if HAVE_GPM.
3039 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3040 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3041 Define only if HAVE_GPM.
3042 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3043 (update_hints_inhibit): Remove; never set. All uses removed.
3044 * widgetprv.h (emacsFrameClassRec): Remove decl.
3045 * window.c (delete_deletable_window): Now returns void, since it
3046 wasn't returning anything.
3047 (compare_window_configurations): Remove unused locals.
3048 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3049 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3050 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3051 the same widths as pointers. This follows up on the 2011-05-06 patch.
3052 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3053 * xterm.h: Likewise.
3054 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3055
1384b89e
JB
30562011-06-12 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * makefile.w32-in: Update dependencies.
3059 (LISP_H): Add lib/intprops.h.
3060
1100a63c
CY
30612011-06-11 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * image.c (gif_load): Add animation frame delay to the metadata.
3064 (syms_of_image): Use DEFSYM. New symbol `delay'.
3065
6198ccd0
MR
30662011-06-11 Martin Rudalics <rudalics@gmx.at>
3067
3068 * window.c (delete_deletable_window): Re-add.
3069 (Fset_window_configuration): Rewrite to handle dead buffers and
3070 consequently deletable windows.
3071 (window_tree, Fwindow_tree): Remove. Supply functionality in
3072 window.el.
3073 (compare_window_configurations): Simplify code.
3074
b6e3633c
AS
30752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3076
1ab0dee5
AS
3077 * image.c (imagemagick_load_image): Fix type mismatch.
3078 (Fimagemagick_types): Likewise.
3079
b6e3633c
AS
3080 * window.h (replace_buffer_in_windows): Declare.
3081
9397e56f
MR
30822011-06-11 Martin Rudalics <rudalics@gmx.at>
3083
3084 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3085 Qclone_number. Remove external declaration of Qdelete_window.
3086 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3087 code.
640c8776
SM
3088 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3089 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3090 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3091 buffer list implementation.
3092 (other_buffer_safely): New function.
3093 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3094 calls to replace_buffer_in_windows and
3095 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3096 if allowed.
3097 (record_buffer): Inhibit quitting and rewrite using quittable
3098 functions. Run Qbuffer_list_update_hook if allowed.
3099 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3100 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3101 Move switch-to-buffer to window.el.
9397e56f
MR
3102 (bury-buffer): Move to window.el.
3103 (Vbuffer_list_update_hook): New variable.
3104
3105 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3106 section.
3107
3108 * window.h (resize_frame_windows): Move up in code.
3109 (Fwindow_frame): Remove EXFUN.
3110 (replace_buffer_in_all_windows): Remove prototype.
3111 (replace_buffer_in_windows_safely): Add prototype.
3112
3113 * window.c: Declare Qdelete_window static again. Move down
3114 declaration of select_count.
3115 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3116 (Fother_window): Move to window.el.
3117 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3118 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3119 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3120 window.el.
3121 (replace_buffer_in_windows): Implement by calling
3122 Qreplace_buffer_in_windows.
3123 (replace_buffer_in_all_windows): Remove with some functionality
3124 moved into replace_buffer_in_windows_safely.
3125 (replace_buffer_in_windows_safely): New function.
3126 (select_window_norecord, select_frame_norecord): Move in front
3127 of run_window_configuration_change_hook. Remove now obsolete
3128 declarations.
640c8776
SM
3129 (Fset_window_buffer): Rewrite doc-string.
3130 Call Qrecord_window_buffer.
9397e56f
MR
3131 (keys_of_window): Move binding for other-window to window.el.
3132
b50691aa
CY
31332011-06-11 Chong Yidong <cyd@stupidchicken.com>
3134
3135 * dispextern.h (struct image): Replace data member, whose int_val
3136 and ptr_val fields were not used by anything, with a single
3137 lisp_val object.
3138
3139 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3140 (gif_clear_image, gif_load, imagemagick_load_image)
3141 (gs_clear_image, gs_load): Callers changed.
3142
3f754b86
PE
31432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3144
cca69397
PE
3145 * buffer.h: Include <time.h>, for time_t.
3146 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3147
109e28d0
PE
3148 Fix minor problems found by static checking.
3149
60737f02
PE
3150 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3151
4b66faf3
PE
3152 Make identifiers static if they are not used in other modules.
3153 * data.c (Qcompiled_function, Qframe, Qvector):
3154 * image.c (QimageMagick, Qsvg):
3155 * minibuf.c (Qmetadata):
3156 * window.c (resize_window_check, resize_root_window): Now static.
3157 * window.h (resize_window_check, resize_root_window): Remove decls.
3158
109e28d0
PE
3159 * window.c (window_deletion_count, delete_deletable_window):
3160 Remove; unused.
46a4ce9e
PE
3161 (window_body_lines): Now static.
3162 (Fdelete_other_windows_internal): Mark vars as initialized.
3163 Make sure 'resize_failed' is initialized.
3164 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3165 (resize_window_apply): Remove unused local.
3166 * window.h (delete_deletable_window): Remove decl.
3167
109e28d0 3168 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3169 (imagemagick_load_image): Fix pointer signedness problem by changing
3170 last arg from unsigned char * to char *. All uses changed.
3171 Also, fix a local for similar reasons.
3172 Remove unused locals. Remove locals to avoid shadowing.
3173 (fn_rsvg_handle_free): Remove; unused.
3174 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3175 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3176
3f754b86
PE
3177 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3178
2547adb1
CY
31792011-06-10 Chong Yidong <cyd@stupidchicken.com>
3180
3181 * image.c (gif_load): Fix omitted cast error introduced by
3182 2011-06-06 change.
3183
2c8e37d4
MR
31842011-06-10 Martin Rudalics <rudalics@gmx.at>
3185
3186 * window.h (resize_proportionally, orig_total_lines)
3187 (orig_top_line): Remove from window structure.
3188 (set_window_height, set_window_width, change_window_heights)
3189 (Fdelete_window): Remove prototypes.
3190 (resize_frame_windows): Remove duplicate declaration.
3191
440a42e3
EZ
31922011-06-10 Eli Zaretskii <eliz@gnu.org>
3193
3194 * window.h (resize_frame_windows, resize_window_check)
3195 (delete_deletable_window, resize_root_window)
3196 (resize_frame_windows): Declare prototypes.
3197
3198 * window.c (resize_window_apply): Make definition be "static" to
3199 match the prototype.
3200
562dd5e9
MR
32012011-06-10 Martin Rudalics <rudalics@gmx.at>
3202
3203 * window.c: Remove declarations of Qwindow_size_fixed,
3204 window_min_size_1, window_min_size_2, window_min_size,
3205 size_window, window_fixed_size_p, enlarge_window, delete_window.
3206 Remove static from declaration of Qdelete_window, it's
3207 temporarily needed by Fbury_buffer.
3208 (replace_window): Don't assign orig_top_line and
3209 orig_total_lines.
3210 (Fdelete_window, delete_window): Remove. Window deletion is
3211 handled by window.el.
640c8776
SM
3212 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3213 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3214 (Fdelete_other_windows): Remove. Deleting other windows is
3215 handled by window.el.
3216 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3217 handled in window.el.
3218 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3219 Window minimum sizes are handled in window.el.
3220 (shrink_windows, size_window, set_window_height)
3221 (set_window_width, change_window_heights, window_height)
3222 (window_width, CURBEG, CURSIZE, enlarge_window)
3223 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3224 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3225 handled in window.el.
3226 (make_dummy_parent): Rename to make_parent_window and give it a
3227 second argument horflag.
3228 (make_window): Don't set resize_proportionally any more.
3229 (Fsplit_window): Remove. Windows are split in window.el.
3230 (save_restore_action, save_restore_orig_size)
3231 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3232 Resize mini windows in window.el.
3233 (grow_mini_window, shrink_mini_window): Implement by calling
3234 Qresize_root_window_vertically, resize_window_check and
3235 resize_window_apply.
640c8776
SM
3236 (saved_window, Fset_window_configuration, save_window_save):
3237 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3238 resize_proportionally.
3239 (window_min_height, window_min_width): Move to window.el.
3240 (keys_of_window): Move bindings for delete-other-windows,
3241 split-window, delete-window and enlarge-window to window.el.
3242
3243 * buffer.c: Temporarily extern Qdelete_window.
3244 (Fbury_buffer): Temporarily call Qdelete_window instead of
3245 Fdelete_window (Fbury_buffer will move to window.el soon).
3246
3247 * frame.c (set_menu_bar_lines_1): Remove code handling
3248 orig_top_line and orig_total_lines.
3249
3250 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3251 set_window_height but set heights directly.
3252 (change_frame_size_1): Use resize_frame_windows.
3253
3254 * xdisp.c (init_xdisp): Don't use set_window_height but set
3255 heights directly.
3256
640c8776
SM
3257 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3258 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3259 run_window_configuration_change_hook.
3260
3261 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3262 instead of change_window_heights and run
3263 run_window_configuration_change_hook.
3264
1a13852e
MR
32652011-06-09 Martin Rudalics <rudalics@gmx.at>
3266
3267 * window.c (replace_window): Rename second argument REPLACEMENT to
3268 NEW. New third argument SETFLAG. Rewrite.
3269 (delete_window, make_dummy_parent): Call replace_window with
3270 third argument 1.
3271 (window_list_1): Move down in code.
3272 (run_window_configuration_change_hook): Move set_buffer part
3273 before select_frame_norecord part in order to unwind correctly.
3274 Rename count1 to count.
3275 (recombine_windows, delete_deletable_window, resize_root_window)
3276 (Fdelete_other_windows_internal)
3277 (Frun_window_configuration_change_hook, make_parent_window)
3278 (resize_window_check, resize_window_apply, Fresize_window_apply)
3279 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3280 (Fdelete_window_internal, Fresize_mini_window_internal):
3281 New functions.
1a13852e
MR
3282 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3283
f3d1777e
MR
32842011-06-08 Martin Rudalics <rudalics@gmx.at>
3285
496e208e
MR
3286 * window.h (window): Add some new members to window structure -
3287 normal_lines, normal_cols, new_total, new_normal, clone_number,
3288 splits, nest, prev_buffers, next_buffers.
3289 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3290 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3291
f3d1777e
MR
3292 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3293 Remove.
496e208e
MR
3294 (make_dummy_parent): Set new members of windows structure.
3295 (make_window): Move down in code. Handle new members of window
3296 structure.
3297 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3298 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3299 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3300 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3301 (Fset_window_next_buffers, Fset_window_clone_number):
3302 New functions.
496e208e
MR
3303 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3304 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3305 Doc-string fixes.
3306 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3307 Argument WINDOW can be now internal window too.
3308 (Fwindow_use_time): Move up in code.
3309 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3310 Rewrite doc-string.
3311 (Fset_window_configuration, saved_window)
3312 (Fcurrent_window_configuration, save_window_save): Handle new
3313 members of window structure.
b9e809c2
MR
3314 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3315 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3316 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3317 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3318 Qget_mru_window, Qresize_root_window,
3319 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3320 Qauto_buffer_name; staticpro them.
f3d1777e 3321
abde8f8c
MR
33222011-06-07 Martin Rudalics <rudalics@gmx.at>
3323
3324 * window.c (Fwindow_total_size, Fwindow_left_column)
3325 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3326 (Fwindow_list_1): New functions.
3327 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3328 (Fwindow_width, Fscroll_left, Fscroll_right):
3329 Use window_body_cols instead of window_box_text_cols.
3330 (delete_window, Fset_window_configuration):
3331 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3332 (delete_all_subwindows): Take a window as argument and not a
3333 structure. Rewrite.
190b47e6
MR
3334 (window_loop): Remove handling of GET_LRU_WINDOW and
3335 GET_LARGEST_WINDOW.
3336 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3337
3338 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3339 window_box_text_cols. delete_all_subwindows now takes a
3340 Lisp_Object as argument.
abde8f8c 3341
640c8776
SM
3342 * indent.c (compute_motion, Fcompute_motion):
3343 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3344
fa8a67e6
MR
3345 * frame.c (delete_frame): Call delete_all_subwindows with root
3346 window as argument.
3347
a54e3482
DC
33482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3349
3350 * fns.c (Fputhash): Document return value.
3351
60002bf5
CY
33522011-06-06 Chong Yidong <cyd@stupidchicken.com>
3353
3354 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3355
0c671da6 33562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3357
b862a52a 3358 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3359
be44ca6c
PE
3360 Check for overflow when converting integer to cons and back.
3361 * charset.c (Fdefine_charset_internal, Fdecode_char):
3362 Use cons_to_unsigned to catch overflow.
3363 (Fencode_char): Use INTEGER_TO_CONS.
3364 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3365 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3366 * data.c (long_to_cons, cons_to_long): Remove.
3367 (cons_to_unsigned, cons_to_signed): New functions.
3368 These signal an error for invalid or out-of-range values.
3369 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3370 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3371 * font.c (Ffont_variation_glyphs):
3372 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3373 * lisp.h: Include <intprops.h>.
3374 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3375 (cons_to_signed, cons_to_unsigned): New decls.
3376 (long_to_cons, cons_to_long): Remove decls.
3377 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3378 (Fprimitive_undo): Use CONS_TO_INTEGER.
3379 * xfns.c (Fx_window_property): Likewise.
3380 * xselect.c: Include <limits.h>.
3381 (x_own_selection, selection_data_to_lisp_data):
3382 Use INTEGER_TO_CONS.
3383 (x_handle_selection_request, x_handle_selection_clear)
3384 (x_get_foreign_selection, Fx_disown_selection_internal)
3385 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3386 (lisp_data_to_selection_data): Use cons_to_unsigned.
3387 (x_fill_property_data): Use cons_to_signed.
3388 Report values out of range.
3389
d1f3d2af
PE
3390 Check for buffer and string overflow more precisely.
3391 * buffer.h (BUF_BYTES_MAX): New macro.
3392 * lisp.h (STRING_BYTES_MAX): New macro.
3393 * alloc.c (Fmake_string):
3394 * character.c (string_escape_byte8):
3395 * coding.c (coding_alloc_by_realloc):
3396 * doprnt.c (doprnt):
3397 * editfns.c (Fformat):
3398 * eval.c (verror):
3399 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3400 since they may not be the same number.
3401 * editfns.c (Finsert_char):
3402 * fileio.c (Finsert_file_contents):
3403 Likewise for BUF_BYTES_MAX.
3404
dd52fcea
PE
3405 * image.c: Use ptrdiff_t, not int, for sizes.
3406 (slurp_file): Switch from int to ptrdiff_t.
3407 All uses changed.
3408 (slurp_file): Check that file size fits in both size_t (for
3409 malloc) and ptrdiff_t (for sanity and safety).
3410
7f9bbdbb
PE
3411 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3412 if b->modtime has its maximal value.
3413
dfe18f82
PE
3414 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3415
84acfcf0
PE
3416 Don't assume time_t can fit into int.
3417 * buffer.h (struct buffer.modtime): Now time_t, not int.
3418 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3419 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3420
ccd9a01a
PE
3421 Minor fixes for signed vs unsigned integers.
3422 * character.h (MAYBE_UNIFY_CHAR):
3423 * charset.c (maybe_unify_char):
3424 * keyboard.c (read_char, reorder_modifiers):
3425 XINT -> XFASTINT, since the integer must be nonnegative.
3426 * ftfont.c (ftfont_spec_pattern):
3427 * keymap.c (access_keymap, silly_event_symbol_error):
3428 XUINT -> XFASTINT, since the integer must be nonnegative.
3429 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3430 since it makes no difference and we prefer signed.
3431 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3432 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3433 nonnegative.
3434
d6d100dd
SM
34352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 * window.h (Fwindow_frame): Declare.
3438
2b6148e4
PE
34392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3442 (SPARE_MEMORY): Always define.
3443 (LARGE_REQUEST): Remove.
3444 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3445
f230ecc9
MR
34462011-06-06 Martin Rudalics <rudalics@gmx.at>
3447
727e958e
MR
3448 * lisp.h: Move EXFUNS for Fframe_root_window,
3449 Fframe_first_window and Fset_frame_selected_window to window.h.
3450
3451 * window.h: Move EXFUNS for Fframe_root_window,
3452 Fframe_first_window and Fset_frame_selected_window here from
3453 lisp.h.
3454
3455 * frame.c (Fwindow_frame, Fframe_first_window)
3456 (Fframe_root_window, Fframe_selected_window)
3457 (Fset_frame_selected_window): Move to window.c.
3458 (Factive_minibuffer_window): Move to minibuf.c.
3459 (Fother_visible_frames_p): New function.
3460
3461 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3462
f230ecc9
MR
3463 * window.c (decode_window, decode_any_window): Move up in code.
3464 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3465 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3466 (Fwindow_buffer): Move up and rewrite doc-string.
3467 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3468 (Fwindow_prev): New functions.
727e958e
MR
3469 (Fwindow_frame): Move here from frame.c. Accept any window as
3470 argument.
3471 (Fframe_root_window, Fframe_first_window)
3472 (Fframe_selected_window): Move here from frame.c. Accept frame
3473 or arbitrary window as argument. Update doc-strings.
3474 (Fminibuffer_window): Move up in code.
3475 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3476 (Fset_frame_selected_window): Move here from frame.c.
3477 Marginal rewrite.
727e958e
MR
3478 (Fselected_window, select_window, Fselect_window): Move up in
3479 code. Minor doc-string fixes.
f230ecc9 3480
4d09bcf6
PE
34812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3484 Do not assume that spare memory exists; that assumption is valid
3485 only if SYSTEM_MALLOC.
3486 (LARGE_REQUEST): New macro, so that the issue of large requests
3487 is separated from the issue of spare memory.
3488
810928a2
AS
34892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3490
172418ad
AS
3491 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3492 format. (Bug#8806)
3493
43f862f7
AS
3494 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3495
810928a2
AS
3496 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3497 before statements.
3498
a059fe24
JD
34992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3500
3501 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3502
3503 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3504
3505 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3506 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3507
989bf368
JB
35082011-06-05 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3511
4b80f674
CY
35122011-06-04 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3515 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3516 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3517 New error handlers.
4b80f674
CY
3518 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3519 Obey Vx_select_enable_clipboard_manager. Catch errors in
3520 x_clipboard_manager_save (Bug#8779).
3521 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3522 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3523
99a33b77 35242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3525
3526 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3527
99a33b77 35282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3529
3530 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3531 in the current matrix if keep_current_p is non-zero.
3532
8264569d
EZ
35332011-06-04 Eli Zaretskii <eliz@gnu.org>
3534
3535 * bidi.c (bidi_level_of_next_char): Fix last change.
3536
57f97249
EZ
35372011-06-03 Eli Zaretskii <eliz@gnu.org>
3538
fec2107c 3539 Support bidi reordering of text covered by display properties.
57f97249 3540
fec2107c
EZ
3541 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3542 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3543 (bidi_cache_search, bidi_cache_iterator_state)
3544 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3545 (bidi_level_of_next_char, bidi_move_to_visually_next):
3546 Support character positions inside a run of characters covered by a
fec2107c
EZ
3547 display string.
3548 (bidi_paragraph_init, bidi_resolve_explicit_1)
3549 (bidi_level_of_next_char): Call bidi_fetch_char and
3550 bidi_fetch_char_advance instead of FETCH_CHAR and
3551 FETCH_CHAR_ADVANCE.
3552 (bidi_init_it): Initialize new members.
3553 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3554 definitions.
3555 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3556 instead of using explicit *_CHAR codes.
d6d100dd
SM
3557 (bidi_resolve_explicit, bidi_resolve_weak):
3558 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3559 bidirectional text is supported only in multibyte buffers.
3560 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3561 it to initialize the frame_window_p member of struct bidi_it.
3562 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3563 (bidi_resolve_explicit, bidi_resolve_weak)
3564 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3565 bidi_it->nchars is non-positive.
3566 (bidi_level_of_next_char): Don't try to lookup the cache for the
3567 next/previous character if nothing is cached there yet, or if we
3568 were just reseat()'ed to a new position.
c40e2fb2 3569
0e14fe90
EZ
3570 * xdisp.c (set_cursor_from_row): Set start and stop points
3571 according to the row's direction when priming the loop that looks
3572 for the glyph on which to display cursor.
3573 (single_display_spec_intangible_p): Function deleted.
3574 (display_prop_intangible_p): Reimplement to call
3575 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3576 Accept 3 additional arguments needed by handle_display_spec.
3577 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3578 values: lists, `(when COND...)' forms, etc.
3579 (single_display_spec_string_p): Support property values that are
3580 lists with the argument STRING its top-level element.
3581 (display_prop_string_p): Fix the condition for processing a
3582 property that is a list to be consistent with handle_display_spec.
fec2107c 3583 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3584 last portion of handle_display_prop.
3585 (compute_display_string_pos): Accept additional argument
3586 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3587 value of a `display' property is a "replacing spec".
3588 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3589 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3590 the display property, but just return a value indicating whether
3591 the display property will replace the characters it covers.
3592 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3593 frame_window_p members of struct bidi_it.
d6d100dd
SM
3594 (compute_display_string_pos, compute_display_string_end):
3595 New functions.
fec2107c
EZ
3596 (push_it): Accept second argument POSITION, where pop_it should
3597 jump to continue iteration.
3598 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3599
fec2107c
EZ
3600 * keyboard.c (adjust_point_for_property): Adjust the call to
3601 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3602
3603 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3604 (bidi_init_it): Update prototypes.
3605 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3606 (compute_display_string_pos, compute_display_string_end):
3607 Declare prototypes.
fec2107c
EZ
3608 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3609 EMACS_INT.
fc6f18ce 3610
40087514 36112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3612
57f53182
PE
3613 Malloc failure behavior now depends on size of allocation.
3614 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3615 * lisp.h: Change signatures accordingly.
3616 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3617 All callers changed. (Bug#8762)
3618
3619 * gnutls.c: Use Emacs's memory allocators.
3620 Without this change, the gnutls library would invoke malloc etc.
3621 directly, which causes problems on non-SYNC_INPUT hosts, and which
3622 runs afoul of improving memory_full behavior. (Bug#8761)
3623 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3624 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3625 xfree instead of the default malloc, realloc, free.
3626 (Fgnutls_boot): No need to check for memory allocation failure,
3627 since xmalloc does that for us.
3628
ac32cd99 3629 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3630 * category.c (hash_get_category_set):
3631 * ccl.c (ccl_driver):
3632 * charset.c (Fdefine_charset_internal):
3633 * charset.h (struct charset.hash_index):
3634 * composite.c (get_composition_id, gstring_lookup_cache)
3635 (composition_gstring_put_cache):
3636 * composite.h (struct composition.hash_index):
3637 * dispextern.h (struct image.hash):
3638 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3639 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3640 (hashfn_equal, hashfn_user_defined, make_hash_table)
3641 (maybe_resize_hash_table, hash_lookup, hash_put)
3642 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3643 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3644 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3645 * image.c (make_image, search_image_cache, lookup_image)
3646 (xpm_put_color_table_h):
3647 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3648 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3649 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3650 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3651 * alloc.c (allocate_vectorlike):
3652 Check for overflow in vector size calculations.
3653 * ccl.c (ccl_driver):
3654 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3655 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3656 need to be updated by these changes.
40087514
PE
3657 * fns.c (make_hash_table, maybe_resize_hash_table):
3658 Check for integer overflow with large hash tables.
0de4bb68
PE
3659 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3660 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3661 (SXHASH_REDUCE): New macro.
3662 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3663 Use it instead of discarding useful hash info with large hash values.
3664 (sxhash_float): New function.
3665 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3666 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3667 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3668 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3669 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3670 Adjust signatures to match updated version of code.
3671 (consing_since_gc): Now EMACS_INT, since a single hash table can
3672 use more than INT_MAX bytes.
3673
698d32e2
DN
36742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3675
3676 Make it possible to build with GCC-4.6+ -O2 -flto.
3677
3678 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3679
fd6fa53f
SM
36802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3681
3682 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3683 Call minibuffer-inactive-mode.
3684
864db017
JB
36852011-05-31 Juanma Barranquero <lekktu@gmail.com>
3686
3687 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3688 Update dependencies.
3689
2ad0baf4
DN
36902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3691
3692 * data.c (init_data): Remove code for UTS, this system is not
3693 supported anymore.
3694
4fcc2638
DN
36952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3696
3697 Don't force ./temacs to start in terminal mode.
3698
3699 * frame.c (make_initial_frame): Initialize faces in all cases, not
3700 only when CANNOT_DUMP is defined.
3701 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3702
c56e0fd5
DN
37032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3704
3705 * dispnew.c (add_window_display_history): Use const for the string
3706 pointer. Remove declaration, not needed.
3707
333d54da 37082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3709
55d4c1b2 3710 Use 'inline', not 'INLINE'.
333d54da 3711 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3712 * alloc.c, fontset.c (INLINE): Remove.
3713 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3714 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3715 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3716 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3717 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3718
738db178
DN
37192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3720
3721 Make it possible to run ./temacs.
3722
3723 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3724 syms_of_callproc does the same thing. Remove test for
3725 "initialized", do it in the caller.
3726 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3727
620c53a6
SM
37282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3729
3730 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3731 (read_minibuf): Use get_minibuffer.
3732 (syms_of_minibuf): Use DEFSYM.
3733 (Qmetadata): New var.
3734 * data.c (Qbuffer): Don't make it static.
3735 (syms_of_data): Use DEFSYM.
3736
e003a292
PE
37372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3740 (CCL_CODE_MIN): New macro.
3741
ed008a6d
PE
37422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3743
3687c2ef
PE
3744 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3745
ed008a6d
PE
3746 * eval.c (Qdebug): Now static.
3747 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3748 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3749 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3750
d66c4c7c
CY
37512011-05-29 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * image.c: Various fixes to ImageMagick code comments.
3754 (Fimagemagick_types): Doc fix.
3755
5fbc2025
PE
37562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3757
0196f88a
PE
3758 Minor fixes prompted by GCC 4.6.0 warnings.
3759
3760 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3761
5fbc2025
PE
3762 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3763 (x_clipboard_manager_save_all): Move extern decl to ...
3764 * xterm.h: ... here, so that it can be checked for consistency.
3765
1dd3c2d9
CY
37662011-05-29 Chong Yidong <cyd@stupidchicken.com>
3767
3768 * xselect.c (x_clipboard_manager_save_frame)
3769 (x_clipboard_manager_save_all): New functions.
3770 (Fx_clipboard_manager_save): Lisp function deleted.
3771
3772 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3773 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3774
3775 * xterm.h: Update prototype.
3776
5ba6571d
WX
37772011-05-28 William Xu <william.xwl@gmail.com>
3778
3779 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3780 exiting (Bug#8239).
3781
3eaff834
JM
37822011-05-28 Jim Meyering <meyering@redhat.com>
3783
e1900994 3784 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3785 * fns.c (to_uchar): Define.
3786 (crypto_hash_function): Use it to convert some newly-signed
3787 variables to unsigned, to avoid sign-extension bugs. For example,
3788 without this change, (md5 "truc") would evaluate to
3789 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3790 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3791 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3792
0f6990a7
PE
37932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 Integer overflow fixes.
c8a9ca5a 3796
08686060
PE
3797 * dbusbind.c: Serial number integer overflow fixes.
3798 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3799 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3800 to hold a serial number that is too large for a fixnum.
3801 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3802 Check for serial numbers out of range. Decode any serial number
59568bf0 3803 that was so large that it became a float. (Bug#8722)
08686060 3804
2d1fc3c7
PE
3805 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3806 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3807 Use XFASTINT rather than XUINT when numbers are nonnegative.
3808 (xd_append_arg, Fdbus_method_return_internal):
3809 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3810 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3811 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3812 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3813 (Bug#8722)
2d1fc3c7 3814
c8a9ca5a
PE
3815 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3816
519e1d69
PE
3817 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3818
30569699
PE
3819 ccl: add integer overflow checks
3820 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3821 (IN_INT_RANGE): New macros.
3822 (ccl_driver): Use them to check for integer overflow when
3823 decoding a CCL program. Many of the new checks are whether XINT (x)
3824 fits in int; it doesn't always, on 64-bit hosts. The new version
3825 doesn't catch all possible integer overflows, but it's an
847044ea 3826 improvement. (Bug#8719)
30569699 3827
c11285dc
PE
3828 * alloc.c (make_event_array): Use XINT, not XUINT.
3829 There's no need for unsigned here.
3830
fdccd48e
PE
3831 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3832 This follows up to the 2011-05-06 change that substituted uintptr_t
3833 for EMACS_INT. This case wasn't caught back then.
3834
37910ab2
PE
3835 Rework Fformat to avoid integer overflow issues.
3836 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3837 now (part of C89). Include <verify.h>.
3838 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3839 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3840 (Fformat): Avoid the prepass trying to compute sizes; it was only
3841 approximate and thus did not catch overflow reliably. Instead, walk
3842 through the format just once, formatting and computing sizes as we go,
3843 checking for integer overflow at every step, and allocating a larger
3844 buffer as needed. Keep track separately whether the format is
3845 multibyte. Keep only the most-recently calculated precision, rather
3846 than them all. Record whether each argument has been converted to
3847 string. Use EMACS_INT, not int, for byte and char and arg counts.
3848 Support field widths and precisions larger than INT_MAX. Avoid
3849 sprintf's undefined behavior with conversion specifications such as %#d
3850 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3851 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3852 formatting out-of-range floating point numbers with int
9173deec 3853 formats. (Bug#8668)
37910ab2 3854
2e6578fb
PE
3855 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3856
0ae6bdee
PE
3857 * data.c: Avoid integer truncation in expressions involving floats.
3858 * data.c: Include <intprops.h>.
3859 (arith_driver): When there's an integer overflow in an expression
3860 involving floating point, convert the integers to floating point
3861 so that the resulting value does not suffer from catastrophic
3862 integer truncation. For example, on a 64-bit host (* 4
3863 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3864 Do not rely on undefined behavior after integer overflow.
3865
de883a70
PE
3866 merge count_size_as_multibyte, parse_str_to_multibyte
3867 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3868 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3869 Check for integer overflow.
3870 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3871 since it's now a duplicate of the other. This is more of
3872 a character than a buffer op, so better that it's in character.c.
3873 * fns.c, print.c: Adjust to above changes.
3874
2ff916cb
PE
38752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3876
3877 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3878
f1b54466
PE
38792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3880
fb1ac845
PE
3881 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3882 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3883 (x_clipboard_manager_save): Now static.
3884 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3885
f1b54466
PE
3886 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3887 (crypto_hash_function): Now static.
3888 Fix pointer signedness problems. Avoid unnecessary initializations.
3889
a9f737ee
CY
38902011-05-27 Chong Yidong <cyd@stupidchicken.com>
3891
3892 * termhooks.h (Vselection_alist): Make it terminal-local.
3893
3894 * terminal.c (create_terminal): Initialize it.
3895
3896 * xselect.c: Support for clipboard managers.
3897 (Vselection_alist): Move to termhooks.h as terminal-local var.
3898 (LOCAL_SELECTION): New macro.
3899 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3900 (symbol_to_x_atom): Remove gratuitous arg.
3901 (x_handle_selection_request, lisp_data_to_selection_data)
3902 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3903 (x_own_selection, x_get_local_selection, x_convert_selection):
3904 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3905 (some_frame_on_display): Delete unused function.
3906 (Fx_own_selection_internal, Fx_get_selection_internal)
3907 (Fx_disown_selection_internal, Fx_selection_owner_p)
3908 (Fx_selection_exists_p): New optional frame arg.
3909 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3910 (x_handle_selection_clear): Don't treat other terminals with the
3911 same keyboard specially. Use the terminal-local Vselection_alist.
3912 (x_clear_frame_selections): Use Frun_hook_with_args.
3913
3914 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3915
3916 * xterm.h: Add support for those atoms.
3917
e067f0c1
CY
39182011-05-26 Chong Yidong <cyd@stupidchicken.com>
3919
3920 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3921 (converted_selections, conversion_fail_tag): New global variables.
3922 (x_selection_request_lisp_error): Free the above.
3923 (x_get_local_selection): Remove unnecessary code.
3924 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3925 of converted selections stored in converted_selections.
3926 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3927 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3928 (x_convert_selection): New function.
3929 (x_handle_selection_event): Simplify.
3930 (x_get_foreign_selection): Don't ignore incoming requests while
3931 waiting for an answer; this will fail when we implement
3932 SAVE_TARGETS, and seems unnecessary anyway.
3933 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3934 (Vx_sent_selection_functions): Doc fix.
3935
0f4aebc0
LL
39362011-05-26 Leo Liu <sdl.web@gmail.com>
3937
3938 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3939
e61124cd
YM
39402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3941
3942 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3943
3944 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3945 for fringe update if it has periodic bitmap.
ac389d0c 3946 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3947 and fringe_bitmap_periodic_p.
3948
3949 * fringe.c (get_fringe_bitmap_data): New function.
3950 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3951 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3952 row. Mark glyph row for fringe update if periodicity changed.
3953
3954 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3955 for fringe update unless it has periodic bitmap.
3956
f16d9837
KH
39572011-05-25 Kenichi Handa <handa@m17n.org>
3958
3959 * xdisp.c (get_next_display_element): Set correct it->face_id for
3960 a static composition.
3961
e1b90ef6
LL
39622011-05-24 Leo Liu <sdl.web@gmail.com>
3963
3964 * deps.mk (fns.o):
3965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3966
3967 * fns.c (crypto_hash_function, Fsha1): New function.
3968 (Fmd5): Use crypto_hash_function.
3969 (syms_of_fns): Add Ssha1.
3970
7400048f
PE
39712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 * gnutls.c: Remove unused macros.
3974 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3975 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3976 Remove macros that are defined and never used.
3977 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3978
abb71cf4
CY
39792011-05-22 Chong Yidong <cyd@stupidchicken.com>
3980
3981 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3982 (Fx_get_selection_internal): Minor cleanup.
3983 (Fx_own_selection_internal): Rename arguments for consistency with
3984 select.el.
3985
6307db39
PE
39862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3989
f3d4e0a4
CY
39902011-05-22 Chong Yidong <cyd@stupidchicken.com>
3991
3992 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3993
4d8ade89
YM
39942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3995
3996 * dispnew.c (scrolling_window): Don't exclude the case that the
3997 last enabled row in the desired matrix touches the bottom boundary.
3998
32078c8d
GM
39992011-05-21 Glenn Morris <rgm@gnu.org>
4000
4001 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4002 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4003 and add some more files.
32078c8d 4004
7285dc67
EZ
40052011-05-20 Eli Zaretskii <eliz@gnu.org>
4006
4007 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4008 report_file_error introduced by the change from 2011-05-07.
4009
89d1bd22
PE
40102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 * systime.h (Time): Define only if emacs is defined.
4013 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4014 where the include path doesn't have X11/X.h by default. See
4015 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4016
e23640bb 40172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4018
4019 * composite.c (find_automatic_composition): Fix previous change.
4020
b9704ad9
GM
40212011-05-20 Glenn Morris <rgm@gnu.org>
4022
4023 * lisp.mk: New file, split from Makefile.in.
4024 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4025 (shortlisp): Remove.
4026 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4027
4a720484
GM
40282011-05-19 Glenn Morris <rgm@gnu.org>
4029
4030 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4031 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4032 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4033 (lisp): Set the order to that of loadup.el.
4034 (shortlisp): Make it a copy of $lisp.
4035 (SOME_MACHINE_LISP): Remove.
4036 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4037 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4038
a28d4396
KH
40392011-05-18 Kenichi Handa <handa@m17n.org>
4040
4041 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4042 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4043 (find_automatic_composition): Mostly rewrite for efficiency.
4044
a2b1fa8e
JB
40452011-05-18 Juanma Barranquero <lekktu@gmail.com>
4046
4047 * makefile.w32-in: Update dependencies.
4048
8e1f5610
CS
40492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4050
4051 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4052 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4053
7025ee00 40542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4055
cdfa6eab
PE
4056 Fix some integer overflow issues, such as string length overflow.
4057
06d6db33
PE
4058 * insdel.c (count_size_as_multibyte): Check for string overflow.
4059
2b4560a8
PE
4060 * character.c (lisp_string_width): Check for string overflow.
4061 Use EMACS_INT, not int, for string indexes and lengths; in
4062 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4063 the resulting string length overflows an EMACS_INT; instead,
4064 report a string overflow if no precision given. When checking for
4065 precision exhaustion, use a check that cannot possibly have
4066 integer overflow. (Bug#8675)
4067 * character.h (lisp_string_width): Adjust to new signature.
4068
cb93f9be
PE
4069 * alloc.c (string_overflow): New function.
4070 (Fmake_string): Use it. This doesn't change behavior, but saves
4071 a few bytes and will simplify future changes.
4072 * character.c (string_escape_byte8): Likewise.
4073 * lisp.h (string_overflow): New decl.
4074
1a1f3366
PE
4075 Fixups, following up to the user-interface timestamp change.
4076 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4077 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4078 * msdos.c (mouse_get_pos): Likewise.
4079 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4080 * w32gui.h (Time): Define by including "systime.h" rather than by
4081 declaring it ourselves. (Bug#8664)
4082
d4e3e4d3
PE
4083 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4084 * image.c (clear_image_cache): Likewise.
4085
f6a24d19
PE
4086 * term.c (term_mouse_position): Don't assume time_t wraparound.
4087
08dc5ae6
PE
4088 Be more systematic about user-interface timestamps.
4089 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4090 and sometimes 'EMACS_UINT', to represent these timestamps.
4091 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4092 This makes the code easier to follow, and makes it easier to catch
4093 integer overflow bugs such as Bug#8664.
4094 * frame.c (Fmouse_position, Fmouse_pixel_position):
4095 Use Time, not unsigned long, for user-interface timestamps.
4096 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4097 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4098 * keyboard.h (last_event_timestamp): Likewise.
4099 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4100 * menu.h (xmenu_show): Likewise.
4101 * term.c (term_mouse_position): Likewise.
4102 * termhooks.h (struct input_event.timestamp): Likewise.
4103 (struct terminal.mouse_position_hook): Likewise.
4104 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4105 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4106 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4107 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4108 what it was before.
4109 * menu.h, termhooks.h: Include "systime.h", for Time.
4110
8e55734a
PE
4111 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4112 Don't assume that the difference between two unsigned long values
4113 can fit into an integer. At this point, we know button_down_time
4114 <= event->timestamp, so the difference must be nonnegative, so
4115 there's no need to cast the result if double-click-time is
4116 nonnegative, as it should be; check that it's nonnegative, just in
4117 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4118 apart (about 25 days). (Bug#8664)
8e55734a 4119
841f1b75 4120 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4121 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4122
3e26f69c
PE
4123 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4124 that always fit in int. Use a sentinel instead of a counter, to
4125 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4126 * frame.h (struct frame): Use int for menu_bar_items_used
4127 instead of EMACS_INT, since it always fits in int.
3e26f69c 4128
5cc152c0
PE
4129 * menu.c (grow_menu_items): Check for int overflow.
4130
d89eb65e
PE
4131 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4132
5235bd3e
PE
4133 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4134 Before, the code was not consistent. These values cannot exceed
4135 2**31 - 1 so there's no need to make them unsigned.
4136 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4137 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4138 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4139 as modifiers.
4140 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4141
bc827e23
PE
4142 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4143 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4144 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4145 presumably because the widths might not match.
4146
78eb494e
PE
4147 * window.c (size_window): Avoid needless test at loop start.
4148
04f2d78b
CB
41492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4150
4151 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4152
d2fc7e3d 41532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4154
4155 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4156
d2fc7e3d 41572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4158
4159 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4160 `width' to `bar_area_x' and `bar_area_width', respectively.
4161 (x_scroll_run): Take account of fringe background extension.
4162
04f2d78b
CB
4163 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4164 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4165 `bar_area_width', respectively.
4166 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4167 background extension.
4168
79b70037
GM
41692011-05-10 Jim Meyering <meyering@redhat.com>
4170
4171 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4172
2f142cc5
JB
41732011-05-10 Juanma Barranquero <lekktu@gmail.com>
4174
4175 * image.c (Finit_image_library): Return t for built-in image types,
4176 like pbm and xbm. (Bug#8640)
4177
57679c86
AS
41782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4179
4180 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4181
888c9e86
EZ
41822011-05-07 Eli Zaretskii <eliz@gnu.org>
4183
b0512a1d
EZ
4184 * w32console.c (Fset_screen_color): Doc fix.
4185 (Fget_screen_color): New function.
4186 (syms_of_ntterm): Defsubr it.
4187
7285dc67
EZ
4188 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4189 unlink the temporary file if Fcall_process didn't create it in the
4190 first place.
4191 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4192 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4193 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4194 cue to call_process_cleanup not to close that handle.
4195
4d3fcc8e
BK
41962011-05-07 Ben Key <bkey76@gmail.com>
4197
4198 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4199 one of two shell specific rules, either bootstrap-temacs-CMD or
4200 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4201 to the previous implementation of the bootstrap-temacs rule.
4202 The bootstrap-temacs-CMD rule is similar to the previous
4203 implementation of the bootstrap-temacs rule except that it
4204 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4205 variable.
4206
4207 These changes, along with some changes to nt/configure.bat,
4208 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4209 earlier fix to add support for --cflags and --ldflags options
4210 that include quotes so that it works whether make uses cmd or
4211 sh as the shell.
4212
b4289b64
MA
42132011-05-06 Michael Albinus <michael.albinus@gmx.de>
4214
4215 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4216 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4217 is a constant.
4218 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4219 a string. Handle both cases.
4220 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4221 (Fdbus_register_method): Use Qinvalid_function.
4222
af4c0e28
JB
42232011-05-06 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * makefile.w32-in: Update dependencies.
4226 (LISP_H): Add inttypes.h and stdin.h.
4227 (PROCESS_H): Add unistd.h.
4228
c51453d9
EZ
42292011-05-06 Eli Zaretskii <eliz@gnu.org>
4230
4231 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4232 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4233
8ff0ac3c 42342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4235
4c4b566b
PE
4236 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4237
aab2b9b5
PE
4238 * term.c (vfatal): Remove stray call to va_end.
4239 It's not needed and the C Standard doesn't allow it here anyway.
4240
c378da0b
PE
4241 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4242 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4243
288b08c7
PE
4244 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4245 bytes.
4246
e3601888
PE
4247 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4248
db6c0e74
PE
4249 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4250
dd5963ea
PE
4251 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4252
88c9450f
PE
4253 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4254
2f9442b8
PE
4255 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4256
c032b5f8
PE
4257 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4258 * charset.c (Fdefine_charset_internal): Don't initialize
4259 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4260 32-bit int (Bug#8600).
a108c10b
PE
4261
4262 * lread.c (read_integer): Be more consistent with string-to-number.
4263 Use string_to_number to do the actual conversion; this avoids
4264 rounding errors and fixes some other screwups. Without this fix,
4265 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4266 (digit_to_number): Move earlier, for benefit of read_integer.
4267 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4268 not a digit in any supported base. (Bug#8602)
a108c10b 4269
ad5f9eea
PE
4270 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4271
aec1708a
PE
4272 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4273 to match comment at start of function. This also removes a
4274 GCC warning about overflow in a 32+64-bit port.
4275
47be4ab5
PE
4276 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4277
371cac43
PE
4278 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4279 Reported by Stefan Monnier in
4280 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4281 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4282 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4283
d01a7826
PE
4284 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4285 (EMACS_UINTPTR): Likewise, with uintptr_t.
4286
7fd47d5c
PE
4287 * lisp.h: Prefer 64-bit EMACS_INT if available.
4288 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4289 on 32-bit hosts that have 64-bit int, so that they can access
4290 large files.
122b0c86
PE
4291 However, temporarily disable this change unless the temporary
4292 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4293
8727937b
PE
4294 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4295
8ac068ac
PE
4296 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4297 This removes an assumption that EMACS_INT and long are the same
4298 width as pointers. The assumption is true for Emacs porting targets
4299 now, but we want to make other targets possible.
4300 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4301 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4302 In the rest of the code, change types of integers that hold casted
4303 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4304 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4305 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4306 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4307 No need to cast type when ORing.
4308 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4309 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4310 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4311 assume EMACS_INT is the same width as char *.
4312 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4313 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4314 Remove no-longer-needed casts.
4315 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4316 (xg_tool_bar_help_callback, xg_make_tool_item):
4317 Use EMACS_INTPTR to hold an integer
4318 that will be cast to void *; this can avoid a GCC warning
4319 if EMACS_INT is not the same width as void *.
4320 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4321 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4322 (current_message_1, set_message_1):
4323 Use a local to convert to proper width without a cast.
4324 * xmenu.c (dialog_selection_callback): Likewise.
4325
ede49d71
PE
4326 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4327 Also, don't assume VALBITS / RAND_BITS is less than 5,
4328 and don't rely on undefined behavior when shifting a 1 left into
4329 the sign bit.
4330 * lisp.h (get_random): Change signature to match.
4331
2f30ecd0
PE
4332 * lread.c (hash_string): Use size_t, not int, for hash computation.
4333 Normally we prefer signed values; but hashing is special, because
4334 it's better to use unsigned division on hash table sizes so that
4335 the remainder is nonnegative. Also, size_t is the natural width
4336 for hashing into memory. The previous code used 'int', which doesn't
4337 retain enough info to hash well into very large tables.
4338 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4339
2a866e7b
PE
4340 * dbusbind.c: Don't possibly lose pointer info when converting.
4341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4342 Use XPNTR rather than XHASH, so that the high-order bits of
4343 the pointer aren't lost when converting through void *.
4344
51639eac
PE
4345 * eval.c (Fautoload): Don't double-shift a pointer.
4346
92394119
PE
4347 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4348
dbdb9a7c
JB
43492011-05-06 Juanma Barranquero <lekktu@gmail.com>
4350
4351 * gnutls.c (DEF_GNUTLS_FN):
4352 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4353
db7a0b4f
AS
43542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4355
4356 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4357 marker. (Bug#8610)
4358
f7ff1b0f 43592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4360
4361 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4362 New version that can reserve upto 2GB of heap space.
4363
f7ff1b0f 43642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4365
4366 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4367
639c109b
TZ
43682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4369
4370 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4371 `gnutls_certificate_set_x509_key_file'.
4372
d2127135
JB
43732011-05-05 Juanma Barranquero <lekktu@gmail.com>
4374
4375 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4376 Update dependencies.
4377
e968f4f3
JB
43782011-05-04 Juanma Barranquero <lekktu@gmail.com>
4379
4380 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4381 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4382 Remove unused parameter `fildes'.
4383 * process.c (read_process_output, send_process): Don't pass it.
4384
84d358f0
JB
43852011-05-04 Juanma Barranquero <lekktu@gmail.com>
4386
4387 Fix previous change: the library cache is defined in w32.c.
4388 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4389 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4390
0898ca10
JB
43912011-05-04 Juanma Barranquero <lekktu@gmail.com>
4392
4393 Implement dynamic loading of GnuTLS on Windows.
4394
4395 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4396 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4397 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4398 Declare.
4399
4400 * gnutls.c (Qgnutls_dll): Define.
4401 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4402 (gnutls_*): Declare function pointers.
4403 (init_gnutls_functions): New function to initialize function pointers.
4404 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4405 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4406 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4407 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4408 (emacs_gnutls_write, emacs_gnutls_read)
4409 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4410 (Fgnutls_available_p): New function.
4411 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4412 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4413 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4414
4415 * image.c: Include w32.h.
4416 (Vimage_type_cache): Delete.
4417 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4418 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4419 (w32_delayed_load): Move to w32.c.
4420
4421 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4422
4423 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4424 (w32_delayed_load): Move from image.c. When loading a library, record
4425 its filename in the :loaded-from property of the library id.
4426 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4427 Initialize and staticpro them.
4428 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4429
4430 * process.c: Include lisp.h before w32.h, not after.
4431 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4432 instead of gnutls_record_check_pending.
4433
4434 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4435
ff4de4aa
TZ
44362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4437
4438 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4439 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4440 as passed in.
4441
abe95abb
JD
44422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4443
4444 * xterm.c (x_set_frame_alpha): Do not set property on anything
4445 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4446
e16e55d4
JB
44472011-05-02 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4450
bafcf6a5
JB
44512011-05-02 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4454 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4455 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4456 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4457 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4458 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4459 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4460 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4461 (Qgnutls_bootprop_callbacks_verify): Make static.
4462
e7a6747f
AS
44632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4464
19ed11ba
AS
4465 * callproc.c: Indentation fixup.
4466
e7a6747f 4467 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4468 (wait_for_termination, interruptible_wait_for_termination):
4469 Move after wait_for_termination_1.
e7a6747f 4470
1ef14cb4
LMI
44712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4472
4473 * sysdep.c (interruptible_wait_for_termination): New function
4474 which is like wait_for_termination, but allows keyboard
4475 interruptions.
4476
4477 * callproc.c (Fcall_process): Add (:file "file") as an option for
4478 the STDOUT buffer.
4479 (Fcall_process_region): Ditto.
4480
330d880c
EZ
44812011-04-30 Eli Zaretskii <eliz@gnu.org>
4482
8db90b73
EZ
4483 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4484 rather than `XVECTOR (FOO)->size'.
4485
330d880c
EZ
4486 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4487 inttypes.h, as a gnulib replacement is used if it not available in
4488 system headers.
4489
15cbd324
EZ
44902011-04-21 Eli Zaretskii <eliz@gnu.org>
4491
4492 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4493 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4494 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4495
4496 * coding.c (coding_alloc_by_realloc): Error out if destination
4497 will grow beyond MOST_POSITIVE_FIXNUM.
4498 (decode_coding_emacs_mule): Abort if there isn't enough place in
4499 charbuf for the composition carryover bytes. Reserve an extra
4500 space for up to 2 characters produced in a loop.
4501 (decode_coding_iso_2022): Abort if there isn't enough place in
4502 charbuf for the composition carryover bytes.
4503
45042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4505
ae940cca
EZ
4506 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4507 aborting when %lld or %lll format is passed.
4508 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4509 %llo or %llx format is passed. (Bug#8545)
4510
03ab8921
EZ
4511 * window.c (window_scroll_line_based): Use a marker instead of
4512 simple variables to record original value of point. (Bug#7952)
4513
afda1437
EZ
4514 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4515 produced by %s or %c overflows available buffer space. (Bug#8545)
4516
f76dee0c
PE
45172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4520 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4521
fdc5744d
JB
45222011-04-28 Juanma Barranquero <lekktu@gmail.com>
4523
4524 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4525
638f053a
JB
45262011-04-28 Juanma Barranquero <lekktu@gmail.com>
4527
4528 * keyboard.c (Qdelayed_warnings_hook): Define.
4529 (command_loop_1): Run `delayed-warnings-hook'
4530 if Vdelayed_warnings_list is non-nil.
4531 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4532 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4533
d178f871
EZ
45342011-04-28 Eli Zaretskii <eliz@gnu.org>
4535
4536 * doprnt.c (doprnt): Don't return value smaller than the buffer
4537 size if the message was truncated. (Bug#8545).
4538
b124fd93
JB
45392011-04-28 Juanma Barranquero <lekktu@gmail.com>
4540
4541 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4542 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4543
e810457d
PE
45442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4545
4546 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4547
ea51cceb
JB
45482011-04-27 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * makefile.w32-in: Update dependencies.
4551
94dcfacf
EZ
45522011-04-27 Eli Zaretskii <eliz@gnu.org>
4553
4554 Improve `doprnt' and its usage. (Bug#8545)
4555 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4556 `format_end'. Remove support for %l as a conversion specifier.
4557 Don't use xrealloc. Improve diagnostics when the %l size modifier
4558 is used. Update the commentary.
4559
4560 * eval.c (verror): Simplify calculation of size_t.
4561
4562 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4563 messages.
4564
f61f41d7
PE
45652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4566
4567 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4568 change.
4569
96fb4434
PE
45702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4573 This makes this file independent of the recent pseudovector change.
4574
671875da 45752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4576
69e9b5a3
PE
4577 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4578
b5f869a7 4579 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4580 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4581 Remove unused local.
c8926152 4582 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4583
841a1577 4584 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4585 GCC 4.6.0 optimizes based on type-based alias analysis.
4586 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4587 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4588 != &v->size, and therefore "v->size = 1; b->size = 2; return
4589 v->size;" must therefore return 1. This assumption is incorrect
4590 for Emacs, since it type-puns struct Lisp_Vector * with many other
4591 types. To fix this problem, this patch adds a new type struct
f904488f 4592 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4593 and pseudovectors, and helps optimizing compilers not get fooled
4594 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4595 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4596 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4597 the size member.
eab3844f
PE
4598 (XSETPVECTYPE): Rewrite in terms of new macro.
4599 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4600 This is a bit clearer, and further avoids the possibility of
4601 undesirable aliasing.
4602 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4603 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4604 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4605 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4606 (ASIZE): Now uses header.size rather than size.
4607 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4608 to avoid the hassle of writing XVECTOR (foo)->header.size.
4609 (struct vectorlike_header): New type.
eab3844f
PE
4610 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4611 object, to help avoid aliasing.
4612 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4613 (SUBRP): Likewise, since Lisp_Subr is a special case.
4614 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4615 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4616 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4617 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4618 changed to be "header.size" and "header.next".
4619 * buffer.h (struct buffer): Likewise.
4620 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4621 * frame.h (struct frame): Likewise.
4622 * process.h (struct Lisp_Process): Likewise.
4623 * termhooks.h (struct terminal): Likewise.
4624 * window.c (struct save_window_data, struct saved_window): Likewise.
4625 * window.h (struct window): Likewise.
4626 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4627 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4628 * buffer.c (init_buffer_once): Likewise.
4629 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4630 special case.
4631 * process.c (Fformat_network_address): Use local var for size,
4632 for brevity.
4633
0df1eac5
PE
4634 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4635
847ab9d1 4636 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4637 * data.c (atof): Remove decl; no longer used or needed.
4638 (digit_to_number): Move to lread.c.
4639 (Fstring_to_number): Use new string_to_number function, to be
4640 consistent with how the Lisp reader treats infinities and NaNs.
4641 Do not assume that floating-point numbers represent EMACS_INT
4642 without losing information; this is not true on most 64-bit hosts.
4643 Avoid double-rounding errors, by insisting on integers when
4644 parsing non-base-10 numbers, as the documentation specifies.
4645 * lisp.h (string_to_number): New decl, replacing ...
4646 (isfloat_string): Remove.
bc0a5c13 4647 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4648 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4649 appears to have been a coding error. Similarly, do not accept
4650 strings like +-1e0 as floating point numbers. Do not report
4651 overflow for integer overflows unless the base is not 10 which
4652 means we have no simple and reliable way to continue.
4653 Break out the floating-point parsing into a new
4654 function string_to_number, so that Fstring_to_number parses
4655 floating point numbers consistently with the Lisp reader.
04f2d78b 4656 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4657 (E_CHAR, EXP_INT): Remove, replacing with ...
4658 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4659 (string_to_number): New function, replacing isfloat_string.
4660 This function checks for valid syntax and produces the resulting
4661 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4662 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4663 so that overflow for non-base-10 numbers is reported only when
4664 there's no portable and simple way to convert to floating point.
452f4150 4665
67769ffc
PE
4666 * textprop.c (set_text_properties_1): Rewrite for clarity,
4667 and to avoid GCC warning about integer overflow.
4668
c20db43f
PE
4669 * intervals.h (struct interval): Use EMACS_INT for members
4670 where EMACS_UINT might cause problems. See
4671 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4672 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4673 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4674 All uses changed.
37aa2f85
PE
4675 (offset_intervals): Tell GCC not to worry about length overflow
4676 when negating a negative length.
c20db43f 4677
2538aa2f
PE
4678 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4679 (overrun_check_free): Likewise.
4680
f2d3008d
PE
4681 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4682 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4683 word size.
4684
ec8df744
PE
4685 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4686 (gnutls_make_error): Rename local to avoid shadowing.
4687 (gnutls_emacs_global_deinit): ifdef out; not used.
4688 (Fgnutls_boot): Use const for pointer to readonly storage.
4689 Comment out unused local. Fix pointer signedness problems.
4690
640ee02d
PE
4691 * lread.c (openp): Don't stuff size_t into an 'int'.
4692 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4693 about possible signed overflow.
4694
6048fb2a
PE
4695 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4696 (GDK_KEY_g): Don't define if already defined.
4697 (xg_prepare_tooltip): Avoid pointer signedness problem.
4698 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4699
fa3c87e1
PE
4700 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4701 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4702
2172544b
PE
4703 * xfns.c (Fx_window_property): Simplify a bit,
4704 to make a bit faster and to avoid GCC 4.6.0 warning.
4705 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4706
9b821a21
PE
4707 * fns.c (internal_equal): Don't assume size_t fits in int.
4708
3c616cfa
PE
4709 * alloc.c (compact_small_strings): Tighten assertion a little.
4710
c2982e87
PE
4711 Replace pEd with more-general pI, and fix some printf arg casts.
4712 * lisp.h (pI): New macro, generalizing old pEd macro to other
4713 conversion specifiers. For example, use "...%"pI"d..." rather
4714 than "...%"pEd"...".
4715 (pEd): Remove. All uses replaced with similar uses of pI.
4716 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4717 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4718 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4719 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4720 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4721 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4722 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4723 64-bit hosts.
4724 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4725 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4726 * print.c (safe_debug_print, print_object): Likewise.
4727 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4728 to int.
6f04d126
PE
4729 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4730 avoiding the 0 flag, which is not portable.
c2982e87
PE
4731 * process.c (Fmake_network_process): Use pI to avoid cast.
4732 * region-cache.c (pp_cache): Likewise.
4733 * xdisp.c (decode_mode_spec): Likewise.
4734 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4735 behavior on 64-bit hosts with printf arg.
6f04d126 4736 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4737 (x_stop_queuing_selection_requests): Likewise.
4738 (x_get_window_property): Don't truncate byte count to an 'int'
4739 when tracing.
0b432f21 4740
5e073ec7
PE
4741 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4742 here, since it parses constructs like leading '-' and spaces,
4743 which are not wanted; and it overflows with large numbers.
4744 Instead, simply match F[0-9]+, which is what is wanted anyway.
4745
36372bf9
PE
4746 * alloc.c: Remove unportable assumptions about struct layout.
4747 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4748 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4749 (allocate_vectorlike, make_pure_vector): Use the new macros,
4750 plus offsetof, to remove unportable assumptions about struct layout.
4751 These assumptions hold on all porting targets that I know of, but
4752 they are not guaranteed, they're easy to remove, and removing them
4753 makes further changes easier.
4754
0b432f21
PE
4755 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4756 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4757 (string_overrun_cookie): Now const. Use initializers that
4758 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4759 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4760 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4761 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4762 multiple of sizeof (EMACS_INT); it need not be, if
4763 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4764 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4765
895009e1
JB
47662011-04-26 Juanma Barranquero <lekktu@gmail.com>
4767
4768 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4769
6a7a1b0b
TZ
47702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4771
4772 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4773 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4774 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4775
841a1577 47762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4777
4778 * lisp.h (Qdebug): List symbol.
895009e1 4779 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4780 * keyboard.c (debug-on-event): New variable.
4781 (handle_user_signal): Break into debugger when debug-on-event
4782 matches the current signal symbol.
4783
f2d3ba6f
DN
47842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4785
4786 * alloc.c (check_sblock, check_string_bytes)
4787 (check_string_free_list): Convert to standard C.
4788
42ce4c63
TZ
47892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4790
4791 * w32.c (emacs_gnutls_push): Fix typo.
4792
825cd63c
EZ
47932011-04-25 Eli Zaretskii <eliz@gnu.org>
4794
fb11d64d
EZ
4795 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4796 "cast to pointer from integer of different size".
4797
825cd63c
EZ
4798 Improve doprnt and its use in verror. (Bug#8545)
4799 * doprnt.c (doprnt): Document the set of format control sequences
4800 supported by the function. Use SAFE_ALLOCA instead of always
4801 using `alloca'.
4802
4803 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4804 is one byte too soon. Don't use xrealloc; instead xfree and
4805 xmalloc anew.
4806
e061a11b
TZ
48072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4808
4809 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4810 callbacks stage.
4811
4812 * gnutls.c: Renamed global_initialized to
4813 gnutls_global_initialized. Added internals for the
4814 :verify-hostname-error, :verify-error, and :verify-flags
4815 parameters of `gnutls-boot' and documented those parameters in the
4816 docstring. Start callback support.
9173deec
JB
4817 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4818 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4819 on error. Return error code.
e061a11b
TZ
4820 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4821 (emacs_gnutls_read): Likewise.
4822 (Fgnutls_boot): Return handshake error code.
4823 (emacs_gnutls_handle_error): New function.
4824 (wsaerror_to_errno): Likewise.
4825
4826 * w32.h (emacs_gnutls_pull): Add prototype.
4827 (emacs_gnutls_push): Likewise.
4828
4829 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4830 (emacs_gnutls_push): Likewise.
4831
48322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4833
4834 * process.c (wait_reading_process_output): Check if GnuTLS
4835 buffered some data internally if no FDs are set for TLS
4836 connections.
4837
4838 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4839 (LIBS): Link to USER_LIBS.
4840 ($(BLD)/gnutls.$(0)): New target.
4841
fa6996bc
EZ
48422011-04-24 Eli Zaretskii <eliz@gnu.org>
4843
eb35682e
EZ
4844 * xdisp.c (handle_single_display_spec): Rename the
4845 display_replaced_before_p argument into display_replaced_p, to
4846 make it consistent with the commentary. Fix typos in the
4847 commentary.
4848
e2ad650c
EZ
4849 * textprop.c (syms_of_textprop): Remove dead code.
4850 (copy_text_properties): Delete obsolete commentary about an
4851 interface that was deleted long ago. Fix typos in the description
4852 of arguments.
4853
1b2de274
EZ
4854 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4855 to changes in oldXMenu/XMenu.h from 2011-04-16.
4856 <menu_help_message, prev_menu_help_message>: Constify.
4857 (IT_menu_make_room): menu->help_text is now `const char **';
4858 adjust.
4859
4860 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4861 to changes in oldXMenu/XMenu.h from 2011-04-16.
4862 (struct XMenu): Declare `help_text' `const char **'.
4863
4864 * xfaces.c <Qunspecified>: Make extern again.
4865
4866 * syntax.c: Include sys/types.h before including regex.h, as
4867 required by Posix.
4868
762b15be
EZ
4869 * doc.c (get_doc_string): Improve the format passed to `error'.
4870
4871 * doprnt.c (doprnt): Improve commentary.
4872
4873 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4874
4875 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4876 them with etags.
4877
f1052e5d
EZ
4878 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4879 changes in globals.h immediately force recompilation.
762b15be
EZ
4880 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4881 $(CURDIR)/s/ms-w32.h.
4882 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4883
fa6996bc
EZ
4884 * character.c (Fchar_direction): Function deleted.
4885 (syms_of_character): Don't defsubr it.
4886 <char-direction-table>: Deleted.
4887
e6c3da20
EZ
48882011-04-23 Eli Zaretskii <eliz@gnu.org>
4889
4890 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4891 * doprnt.c: Include limits.h.
4892 (SIZE_MAX): New macro.
04f2d78b
CB
4893 (doprnt): Return a size_t value. 2nd arg is now size_t.
4894 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4895 Improve overflow protection. Support `l' modifier for integer
4896 conversions. Support %l conversion. Don't assume an EMACS_INT
4897 argument for integer conversions and for %c.
4898
4899 * lisp.h (doprnt): Restore prototype.
4900
4901 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4902 $(SRC)/character.h.
4903
4904 * Makefile.in (base_obj): Add back doprnt.o.
4905
4906 * deps.mk (doprnt.o): Add back prerequisites.
4907 (callint.o): Depend on character.h.
4908
4909 * eval.c (internal_lisp_condition_case): Include the handler
4910 representation in the error message.
4911 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4912 when breaking from the loop.
4913
4914 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4915
4916 * callint.c (Fcall_interactively): When displaying error message
4917 about invalid control letter, pass the character's codepoint, not
4918 a pointer to its multibyte form. Improve display of the character
4919 in octal and display also its hex code.
4920
4921 * character.c (char_string): Use %x to display the (unsigned)
4922 codepoint of an invalid character, to avoid displaying a bogus
4923 negative value.
4924
4925 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4926 `error', not SYMBOL_NAME itself.
4927
4928 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4929 character arguments to `error'.
4930
4931 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4932 to `error' in error message about FINAL_CHAR argument. Make sure
4933 FINAL_CHAR is a character, and use %c when it is passed as
4934 argument to `error'.
4935
4ffd0d6b 49362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4937
4938 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4939
4940 * w32.c: Include <time.h>.
4941 (sys_localtime): New function.
4942
4ffd0d6b 49432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4944
4945 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4946
4ffd0d6b 4947 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4948
4ffd0d6b 49492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4950
4ffd0d6b
GM
4951 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4952 zombies (Bug#8467).
aac0c6e3 4953
04c56954
EZ
49542011-04-19 Eli Zaretskii <eliz@gnu.org>
4955
4956 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4957 gl_state.e_property when gl_state.object is Qt.
4958
4959 * insdel.c (make_gap_larger): Remove limitation of buffer size
4960 to <= INT_MAX.
4961
16a43933
CY
49622011-04-18 Chong Yidong <cyd@stupidchicken.com>
4963
4964 * xdisp.c (lookup_glyphless_char_display)
4965 (produce_glyphless_glyph): Handle cons cell entry in
4966 glyphless-char-display.
4967 (Vglyphless_char_display): Document it.
4968
4969 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4970 glyphless-char-display.
4971
4581706e
CY
49722011-04-17 Chong Yidong <cyd@stupidchicken.com>
4973
4974 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4975
4976 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4977
4978 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4979 definition for no-X builds.
4980
4887c6e2 49812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4982
fd35b6f9
PE
4983 Static checks with GCC 4.6.0 and non-default toolkits.
4984
5c1ccb01
PE
4985 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4986
006c5daa
PE
4987 * process.c (keyboard_bit_set): Define only if SIGIO.
4988 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4989 (send_process): Repair possible setjmp clobbering.
4990
efc736d3
PE
4991 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4992
4e2fe2e6
PE
4993 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4994
f97334a2
PE
4995 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4996
4e75f29d
PE
4997 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4998 Define only if needed.
4999
90efadd1
PE
5000 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5001 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5002 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5003
3c647824
PE
5004 * dispextern.h (struct redisplay_interface): Rename param
5005 to avoid shadowing.
e264f262 5006 * termhooks.h (struct terminal): Likewise.
761383f4 5007 * xterm.c (xembed_send_message): Likewise.
3c647824 5008
b58c5c4a
PE
5009 * insdel.c (make_gap_smaller): Define only if
5010 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5011
cad59032
PE
5012 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5013 it.
5014
c339dc2e
PE
5015 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5016 so that we aren't warned about unused symbols.
5017
91a3e27b
PE
5018 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5019
399c71d3 5020 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5021
8ffc96f5
PE
5022 * xfns.c (x_real_positions): Mark locals as initialized.
5023
eef9bc79
PE
5024 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5025
098db9dd
PE
5026 * xterm.c: Fix problems found by static analysis with other toolkits.
5027 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5028 (x_dispatch_event): Declare static if USE_GTK, and
5029 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5030 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5031 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5032 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5033 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5034
eb18f6cc
PE
5035 * xmenu.c (menu_help_callback): Pointer type fixes.
5036 Use const pointers when pointing at readonly data. Avoid pointer
5037 signedness clashes.
5038 (FALSE): Remove unused macro.
5039 (update_frame_menubar): Remove unused decl.
5040
1fe72bf8
PE
5041 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5042
60d9e1db
PE
5043 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5044 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5045 (single_menu_item): Rename local to avoid shadowing.
5046
39261c26
PE
5047 * keyboard.c (make_lispy_event): Remove unused local var.
5048
018c5e19
PE
5049 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5050 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5051
63d2b86e
PE
5052 * bitmaps: Change bitmaps from unsigned char back to the X11
5053 compatible char. Avoid the old compiler warnings about
5054 out-of-range initializers by using, for example, '\xab' rather
5055 than 0xab.
5056
aefd87e1
PE
5057 * xgselect.c (xgselect_initialize): Check vs interface
5058 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5059
bf501fb9
PE
5060 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5061
e9829fdf
PE
5062 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5063 to read-only memory.
5064
1086c095
PE
5065 * fns.c (vector): Remove; this old hack is no longer needed.
5066
2baccd04 5067 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5068 Remove unused var.
dde42981 5069 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5070
72391843 5071 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5072
436c16df 5073 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5074 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5075 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5076
92bb796d 5077 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5078 (x_term_init): Remove local to avoid shadowing.
92bb796d 5079
764430a3 5080 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5081
5082 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5083 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5084
d1dfb56c
EZ
50852011-04-16 Eli Zaretskii <eliz@gnu.org>
5086
c4354cb4
EZ
5087 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5088
d1dfb56c
EZ
5089 Fix regex.c, syntax.c and friends for buffers > 2GB.
5090 * syntax.h (struct gl_state_s): Declare character position members
5091 EMACS_INT.
5092
5093 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5094
04f2d78b
CB
5095 * textprop.c (verify_interval_modification, interval_of):
5096 Declare arguments EMACS_INT.
d1dfb56c
EZ
5097
5098 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5099 EMACS_INT.
5100
5101 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5102
5103 * indent.c (Fvertical_motion): Local variable it_start is now
5104 EMACS_INT.
5105
5106 * regex.c (re_match, re_match_2, re_match_2_internal)
5107 (bcmp_translate, regcomp, regexec, print_double_string)
5108 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5109 (re_compile_pattern, re_exec): Declare arguments and local
5110 variables `size_t' and `ssize_t' and return values `regoff_t', as
5111 appropriate.
5112 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5113 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5114 <compile_stack_type>: `size' and `avail' are now `size_t'.
5115
5116 * regex.h <regoff_t>: Use ssize_t, not int.
5117 (re_search, re_search_2, re_match, re_match_2): Arguments that
5118 specify buffer/string position and length are now ssize_t and
5119 size_t. Return type is regoff_t.
5120
613052cd
BK
51212011-04-16 Ben Key <bkey76@gmail.com>
5122
5123 * nsfont.m: Fixed bugs in ns_get_family and
5124 ns_descriptor_to_entity that were caused by using free to
5125 deallocate memory blocks that were allocated by xmalloc (via
5126 xstrdup). This caused Emacs to crash when compiled with
5127 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5128 --enable-checking=xmallocoverrun). xfree is now used to
5129 deallocate these memory blocks.
5130
4170f62f 51312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5132
71b41406
PE
5133 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5134
9587a89d
PE
5135 emacs_write: Accept and return EMACS_INT for sizes.
5136 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5137 et seq.
5138 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5139 Accept and return EMACS_INT.
5140 (emacs_gnutls_write): Return the number of bytes written on
5141 partial writes.
5142 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5143 (emacs_read, emacs_write): Remove check for negative size, as the
5144 Emacs source code has been audited now.
9587a89d
PE
5145 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5146 (emacs_read, emacs_write): Use it.
273a5f82
PE
5147 * process.c (send_process): Adjust to the new signatures of
5148 emacs_write and emacs_gnutls_write. Do not attempt to store
5149 a byte offset into an 'int'; it might overflow.
9587a89d 5150 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5151
3e047f51
PE
5152 * sound.c: Don't assume sizes fit in 'int'.
5153 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5154 Return EMACS_INT, not int.
3e047f51 5155 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5156 Accept EMACS_INT, not int.
5157 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5158 record read return values.
5159
cc39a9db
BK
51602011-04-15 Ben Key <bkey76@gmail.com>
5161
c9d0ec6d
JB
5162 * keyboard.c (Qundefined): Don't declare static since it is used
5163 in nsfns.m.
5164 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5165 static since they are used in nsfont.m.
cc39a9db 5166
6c60eb9f
SM
51672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5168
5169 * process.c (Qprocessp): Don't declare static.
5170 * lisp.h (Qprocessp): Declare again.
5171
7990b61a
JB
51722011-04-15 Juanma Barranquero <lekktu@gmail.com>
5173
5174 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5175
5d4cb038
PE
51762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5177
8bd7b830 5178 Improve C-level modularity by making more things 'static'.
cd64ea1d 5179
e3b27b31
PE
5180 Don't publish debugger-only interfaces to other modules.
5181 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5182 (verify_bytepos, count_markers): Move decls to the only modules
5183 that need them.
5184 * region-cache.h (pp_cache): Likewise.
5185 * window.h (check_all_windows): Likewise.
5186 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5187
5d4cb038
PE
5188 * sysdep.c (croak): Now static, if
5189 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5190 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5191
5192 * alloc.c (refill_memory_reserve): Now static if
5193 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5194 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5195
e87b6180
PE
5196 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5197 Define only if USE_LUCID.
5198
ac64929e
PE
5199 * xrdb.c (x_customization_string, x_rm_string): Now static.
5200
6f37259d
PE
5201 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5202 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5203
1683e3ab
PE
5204 * xdisp.c (draw_row_with_mouse_face): Now static.
5205 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5206
de9c2632
PE
5207 * window.h (check_all_windows): Mark externally visible.
5208
2b96acb7
PE
5209 * window.c (window_deletion_count): Now static.
5210
5211 * undo.c: Make symbols static if they're not exported.
5212 (last_undo_buffer, last_boundary_position, pending_boundary):
5213 Now static.
5214
50436f33
PE
5215 * textprop.c (interval_insert_behind_hooks): Now static.
5216 (interval_insert_in_front_hooks): Likewise.
5217
64520e5c
PE
5218 * term.c: Make symbols static if they're not exported.
5219 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5220 (max_frame_lines, tty_set_terminal_modes):
5221 (tty_reset_terminal_modes, tty_turn_off_highlight):
5222 (get_tty_terminal): Now static.
5223 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5224 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5225 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5226 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5227 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5228
1fa53021
PE
5229 * sysdep.c: Make symbols static if they're not exported.
5230 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5231 Now static.
5232 (sigprocmask_set, full_mask): Remove; unused.
5233 (wait_debugging): Mark as visible.
5234 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5235 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5236
d4b43b22
PE
5237 * syntax.c (syntax_temp): Define only if !__GNUC__.
5238
b7c513d0
PE
5239 * sound.c (current_sound_device, current_sound): Now static.
5240
989b29ad
PE
5241 * search.c (searchbufs, searchbuf_head): Now static.
5242
13a55a78
PE
5243 * scroll.c (scroll_cost): Remove; unused.
5244 * dispextern.h (scroll_cost): Remove decl.
5245
de68a1fc
PE
5246 * region-cache.h (pp_cache): Mark as externally visible.
5247
40ccffa6
PE
5248 * process.c: Make symbols static if they're not exported.
5249 (process_tick, update_tick, create_process, chan_process):
5250 (Vprocess_alist, proc_buffered_char, datagram_access):
5251 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5252 (deactivate_process): Mark defn as static, as well as decl.
5253 * lisp.h (create_process): Remove decl.
5254 * process.h (chan_process, Vprocess_alist): Remove decls.
5255
ad64fc97
PE
5256 * print.c: Make symbols static if they're not exported.
5257 (print_depth, new_backquote_output, being_printed, print_buffer):
5258 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5259 (print_interval, print_number_index, initial_stderr_stream):
5260 Now static.
5261 * lisp.h (Fprinc): Remove decl.
5262 (debug_output_compilation_hack): Mark as externally visible.
5263
adddb265
PE
5264 * sysdep.c (croak): Move decl from here to syssignal.h.
5265 * syssignal.h (croak): Put it here, so the API can be checked when
5266 'croak' is called from dissociate_if_controlling_tty.
5267
1717ede2
PE
5268 * minibuf.c: Make symbols static if they're not exported.
5269 (minibuf_save_list, choose_minibuf_frame): Now static.
5270 * lisp.h (choose_minibuf_frame): Remove decl.
5271
fa5fb2bc
PE
5272 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5273
1e3890d1
PE
5274 * lread.c: Make symbols static if they're not exported.
5275 (read_objects, initial_obarray, oblookup_last_bucket_number):
5276 Now static.
5277 (make_symbol): Remove; unused.
5278 * lisp.h (initial_obarray, make_symbol): Remove decls.
5279
8a1414fa
PE
5280 * keyboard.c: Make symbols static if they're not exported.
5281 (single_kboard, recent_keys_index, total_keys, recent_keys):
5282 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5283 (this_single_command_key_start, echoing, last_auto_save):
5284 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5285 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5286 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5287 (Vlispy_mouse_stem, double_click_count):
5288 Now static.
5289 (force_auto_save_soon): Define only if SIGDANGER.
5290 (ignore_mouse_drag_p): Now static if
5291 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5292 (print_help): Remove; unused.
5293 (stop_character, last_timer_event): Mark as externally visible.
5294 * keyboard.h (ignore_mouse_drag_p): Declare only if
5295 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5296 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5297 * lisp.h (echoing): Remove decl.
5298 (force_auto_save_soon): Declare only if SIGDANGER.
5299 * xdisp.c (redisplay_window): Simplify code, to make it more
5300 obvious that ignore_mouse_drag_p is not accessed if !defined
5301 USE_GTK && !defined HAVE_NS.
5302
93ea6e8f
PE
5303 * intervals.c: Make symbols static if they're not exported.
5304 (merge_properties_sticky, merge_interval_right, delete_interval):
5305 Now static.
5306 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5307
77382fcc
PE
5308 * insdel.c: Make symbols static if they're not exported.
5309 However, leave prepare_to_modify_buffer alone. It's never
5310 called from outside this function, but that appears to be a bug.
5311 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5312 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5313 (adjust_after_replace_noundo): Remove; unused.
5314 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5315 (signal_before_change): Remove decls.
77382fcc 5316
9306c32e
PE
5317 * indent.c (val_compute_motion, val_vmotion): Now static.
5318
cd44d2eb
PE
5319 * image.c: Make symbols static if they're not exported.
5320 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5321 if USE_GTK.
5322 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5323 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5324
ad9a7a06
PE
5325 * fringe.c (standard_bitmaps): Now static.
5326 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5327
81626931
PE
5328 * frame.c: Make symbols static if they're not exported.
5329 (x_report_frame_params, make_terminal_frame): Now static.
5330 (get_frame_param): Now static, unless HAVE_NS.
5331 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5332 (x_get_resource_string): Remove; not used.
5333 * frame.h (make_terminal_frame, x_report_frame_params):
5334 (x_get_resource_string); Remove decls.
5335 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5336 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5337
239f9db9
PE
5338 * font.c, fontset.c: Make symbols static if they're not exported.
5339 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5340 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5341 * font.c (font_close_object): Now static.
5342 * font.h (font_close_object): Remove.
5343 * fontset.c (FONTSET_OBJLIST): Remove.
5344 (free_realized_fontset) #if-0 the body, which does nothing.
5345 (face_suitable_for_char_p): #if-0, as it's never called.
5346 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5347 * xfaces.c (face_at_string_position):
5348 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5349 since 0 is always ASCII.
5350
dfcf3579
PE
5351 * fns.c (weak_hash_tables): Now static.
5352
5045092b
PE
5353 * fileio.c: Make symbols static if they're not exported.
5354 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5355 (Vwrite_region_annotation_buffers): Now static.
5356
57a96f5c
PE
5357 * eval.c: Make symbols static if they're not exported.
5358 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5359 * lisp.h (backtrace_list): Remove decl.
5360
35f08c38
PE
5361 * emacs.c: Make symbols static if they're not exported.
5362 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5363 (fatal_error_code, fatal_error_signal_hook, standard_args):
5364 Now static.
5365 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5366 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5367 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5368 * lisp.h (fatal_error_signal_hook): Remove decl.
5369 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5370
f44bd759
PE
5371 * editfns.c: Move a (normally-unused) function to its only use.
5372 * editfns.c, lisp.h (get_operating_system_release): Remove.
5373 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5374 worth the hassle of breaking this out.
5375
b532497d
PE
5376 * xterm.c: Make symbols static if they're not exported.
5377 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5378 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5379 (x_destroy_window, x_delete_display):
5380 Now static.
5381 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5382 (x_mouse_leave): Remove; unused.
5383 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5384 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5385 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5386 Remove decls.
5387 (x_mouse_leave): Declare only if WINDOWSNT.
5388 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5389 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5390 USE_X_TOOLKIT.
5391
1675728f
PE
5392 * ftxfont.c: Make symbols static if they're not exported.
5393 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5394 HAVE_FREETYPE.
5395 * font.h (ftxfont_driver): Likewise.
5396
e4cebfca
PE
5397 * xfns.c: Make symbols static if they're not exported.
5398 (x_last_font_name, x_display_info_for_name):
5399 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5400 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5401 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5402 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5403 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5404 (last_show_tip_args): Now static.
5405 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5406 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5407 (x_screen_planes): Remove; unused.
5408 * dispextern.h (x_screen_planes): Remove decl.
5409
5bf46f05
PE
5410 * dispnew.c: Make symbols static if they're not exported.
5411 * dispextern.h (redraw_garbaged_frames, scrolling):
5412 (increment_row_positions): Remove.
5413 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5414 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5415 Now static.
5416 (redraw_garbaged_frames): Remove; unused.
5417
435f4c28
PE
5418 * xfaces.c: Make symbols static if they're not exported.
5419 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5420 Remove decls.
5421 * xterm.h (defined_color): Remove decls.
5422 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5423 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5424 (menu_face_changed_default, defined_color, free_realized_face):
5425 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5426 (ascii_face_of_lisp_face): Remove; unused.
5427
8524aef3
PE
5428 * xdisp.c: Make symbols static if they're not exported.
5429 * dispextern.h (scratch_glyph_row, window_box_edges):
5430 (glyph_to_pixel_coords, set_cursor_from_row):
5431 (get_next_display_element, set_iterator_to_next):
5432 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5433 (show_mouse_face): Remove decls
5434 * frame.h (message_buf_print): Likewise.
5435 * lisp.h (pop_message, set_message, check_point_in_composition):
5436 Likewise.
5437 * xterm.h (set_vertical_scroll_bar): Likewise.
5438 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5439 (message_buf_print, scratch_glyph_row, displayed_buffer):
5440 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5441 (get_next_display_element, show_mouse_face, window_box_edges):
5442 (frame_to_window_pixel_xy, check_point_in_composition):
5443 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5444 (glyph_to_pixel_coords): Remove; unused.
5445
16390cd2
PE
5446 * dired.c (file_name_completion): Now static.
5447
5448 * dbusbind.c (xd_in_read_queued_messages): Now static.
5449
a25f4dfa
PE
5450 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5451 * data.c (circular_list_error): Remove.
5452
14a9c8df
PE
5453 * commands.h (last_point_position, last_point_position_buffer):
5454 (last_point_position_window): Remove decls.
5455 * keyboard.c: Make these variables static.
5456
04f2d78b
CB
5457 * coding.h (coding, code_convert_region, encode_coding_gap):
5458 Remove decls.
74ab6df5
PE
5459 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5460 (iso_code_class, detect_coding, code_convert_region): Now static.
5461 (encode_coding_gap): Remove; unused.
5462
38dfbee1
PE
5463 * chartab.c (chartab_chars, chartab_bits): Now static.
5464
a2cb4e63
PE
5465 * charset.h (charset_iso_8859_1): Remove decl.
5466 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5467 Now static.
5468
127198fd
PE
5469 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5470 * ccl.c (Vccl_program_table): Now static.
5471 (check_ccl_update): Remove; unused.
5472
d85b608f
PE
5473 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5474 * category.h: ... from here.
5475 * category.c (check_category_table, set_category_set): Now static.
5476
31cd66f3
PE
5477 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5478 * lisp.h: Remove these decls.
5479
c358e587
PE
5480 * buffer.c (buffer_count): Remove unused var.
5481
e78aecca
PE
5482 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5483 so that it's not optimized away.
5484 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5485 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5486 exported only to the debugger.
5487
e192d7d3 5488 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5489 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5490
92470028
PE
5491 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5492 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5493 was inaccessible from Lisp.
5494 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5495 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5496
244ed907
PE
5497 alloc.c: Import and export fewer symbols, and remove unused items.
5498 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5499 is defined.
5500 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5501 it's not optimized away by whole-program optimization.
5502 (message_enable_multibyte, free_misc): Remove.
5503 (catchlist, handlerlist, mark_backtrace):
5504 Declare only if BYTE_MARK_STACK.
5505 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5506 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5507 (message_enable_multibyte): Remove decl.
5508 (free_misc, interval_free_list, float_block, float_block_index):
5509 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5510 (cons_free_list, last_marked_index):
5511 Now static.
5512 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5513 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5514 (mark_backtrace): Define only if BYTE_MARK_STACK.
5515 * xdisp.c (message_enable_multibyte): Now static.
5516
61c2b50e 5517 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5518 This makes it easier for human readers (and static analyzers)
5519 to see whether these variables are used from other modules.
5520 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5521 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5522 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5523 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5524 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5525 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5526 * xmenu.c, xselect.c:
5527 Declare Q* vars static if they are not used in other modules.
5528 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5529 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5530 Remove decls of unexported vars.
5531 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5532
95c82688
PE
5533 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5534
16a97296
PE
5535 Make Emacs functions such as Fatom 'static' by default.
5536 This makes it easier for human readers (and static analyzers)
5537 to see whether these functions can be called from other modules.
5538 DEFUN now defines a static function. To make the function external
5539 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5540 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5541 (Finit_image_library):
16a97296
PE
5542 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5543 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5544 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5545 Remove decls, since these functions are now static.
5546 (Funintern, Fget_internal_run_time): New decls, since these functions
5547 were already external.
95c82688 5548
16a97296
PE
5549 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5550 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5551 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5552 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5553 * keyboard.c, keymap.c, lread.c:
5554 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5555 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5556 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5557 Mark functions with DEFUE instead of DEFUN,
5558 if they are used in other modules.
5559 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5560 decls for now-static functions.
5561 * buffer.h (Fdelete_overlay): Remove decl.
5562 * callproc.c (Fgetenv_internal): Mark as internal.
5563 * composite.c (Fremove_list_of_text_properties): Remove decl.
5564 (Fcomposition_get_gstring): New forward static decl.
5565 * composite.h (Fcomposite_get_gstring): Remove decl.
5566 * dired.c (Ffile_attributes): New forward static decl.
5567 * doc.c (Fdocumntation_property): New forward static decl.
5568 * eval.c (Ffetch_bytecode): New forward static decl.
5569 (Funintern): Remove extern decl; now in .h file where it belongs.
5570 * fileio.c (Fmake_symbolic_link): New forward static decl.
5571 * image.c (Finit_image_library): New forward static decl.
5572 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5573 * intervals.h (Fprevious_property_change):
5574 (Fremove_list_of_text_properties): Remove decls.
5575 * keyboard.c (Fthis_command_keys): Remove decl.
5576 (Fcommand_execute): New forward static decl.
5577 * keymap.c (Flookup_key): New forward static decl.
5578 (Fcopy_keymap): Now static.
5579 * keymap.h (Flookup_key): Remove decl.
5580 * process.c (Fget_process): New forward static decl.
5581 (Fprocess_datagram_address): Mark as internal.
5582 * syntax.c (Fsyntax_table_p): New forward static decl.
5583 (skip_chars): Remove duplicate decl.
5584 * textprop.c (Fprevious_property_change): New forward static decl.
5585 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5586 Now internal.
5587 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5588 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5589
785bbd42
PE
5590 * editfns.c (Fformat): Remove unreachable code.
5591
8b913b57
AS
55922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5593
5594 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5595 change. (Bug#8496)
5596
a6744a35
EZ
55972011-04-13 Eli Zaretskii <eliz@gnu.org>
5598
5599 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5600 when at ZV. (Bug#8487)
5601
e7974947
AS
56022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5603
baad03f0
AS
5604 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5605 (Bug#8437)
5606 * keyboard.c (parse_tool_bar_item): Likewise.
5607 * sound.c (sound_cleanup, alsa_close): Likewise.
5608 * termcap.c (tgetent): Likewise.
5609 * xfns.c (x_default_font_parameter): Likewise.
5610 * xsettings.c (read_and_apply_settings): Likewise.
5611
e7974947
AS
5612 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5613 (overrun_check_free): Protoize.
5614
28272684
PE
56152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5616
5617 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5618 since callers should never pass a negative size.
5619 Change the signature to match that of plain 'read' and 'write'; see
5620 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5621 * lisp.h: Update prototypes of emacs_write and emacs_read.
5622
11997c76
EZ
56232011-04-11 Eli Zaretskii <eliz@gnu.org>
5624
5625 * xdisp.c (redisplay_window): Don't try to determine the character
5626 position of the scroll margin if the window start point w->startp
e896f03c 5627 is outside the buffer's accessible region. (Bug#8468)
11997c76 5628
8a2cbd72
EZ
56292011-04-10 Eli Zaretskii <eliz@gnu.org>
5630
5631 Fix write-region and its subroutines for buffers > 2GB.
5632 * fileio.c (a_write, e_write): Modify declaration of arguments and
5633 local variables to support buffers larger than 2GB.
5634 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5635
5636 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5637 argument, local variables, and return value.
5638
5639 * lisp.h: Update prototypes of emacs_write and emacs_read.
5640
5641 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5642
4073e537 56432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5644
1ebfdcb6
PE
5645 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5646
b2ded58d
PE
5647 Fix more problems found by GCC 4.6.0's static checks.
5648
7d66342c
PE
5649 * xdisp.c (vmessage): Use a better test for character truncation.
5650
bbf47d44
PE
5651 * charset.c (load_charset_map): <, not <=, for optimization,
5652 and to avoid potential problems with integer overflow.
9248994d 5653 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5654 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5655 * editfns.c (Fformat): Likewise.
1e69125e 5656 * syntax.c (skip_chars): Likewise.
3befa583 5657
e3019616
PE
5658 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5659 This also lets GCC 4.6.0 generate slightly better loop code.
5660
becfa255
PE
5661 * callint.c (Fcall_interactively): <, not <=, for optimization.
5662 (Fcall_interactively): Count the number of arguments produced,
5663 not the number of arguments given. This is simpler and lets GCC
5664 4.6.0 generate slightly better code.
5665
dae0cd48
PE
5666 * ftfont.c: Distingish more carefully between FcChar8 and char.
5667 The previous code passed unsigned char * to a functions like
5668 strlen and xstrcasecmp that expect char *, which does not
5669 conform to the C standard.
5670 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5671 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5672 char * when the C standard requires it.
5673
76032d70
PE
5674 * keyboard.c (read_char): Remove unused var.
5675
eb3f1cc8
PE
5676 * eval.c: Port to Windows vsnprintf (Bug#8435).
5677 Include <limits.h>.
5678 (SIZE_MAX): Define if the headers do not.
5679 (verror): Do not give up if vsnprintf returns a negative count.
5680 Instead, grow the buffer. This ports to Windows vsnprintf, which
5681 does not conform to C99. Problem reported by Eli Zaretskii.
5682 Also, simplify the allocation scheme, by avoiding the need for
5683 calling realloc, and removing the ALLOCATED variable.
5684
70476b54
PE
5685 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5686
12020a9e
PE
5687 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5688 But keep the doprint source code for now, as we might revamp it
5689 and use it again (Bug#8435).
ea6c7ae6
PE
5690 * lisp.h (doprnt): Remove.
5691 * Makefile.in (base_obj): Remove doprnt.o.
5692 * deps.mk (doprnt.o): Remove.
5693
5fdb398c
PE
5694 error: Print 32- and 64-bit integers portably (Bug#8435).
5695 Without this change, on typical 64-bit hosts error ("...%d...", N)
5696 was used to print both 32- and 64-bit integers N, which relied on
5697 undefined behavior.
5698 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5699 New macro.
5700 * lisp.h (error, verror): Mark as printf-like functions.
5701 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5702 Report overflow in size calculations when allocating printf buffer.
5703 Do not truncate output string at its first null byte.
5704 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5705 Truncate the output at a character boundary, since vsnprintf does not
5706 do that.
5707 * charset.c (check_iso_charset_parameter): Convert internal
5708 character to string before calling 'error', since %c now has the
5709 printf meaning.
5710 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5711 overflow when computing char to be passed to 'error'. Do not
5712 pass Lisp_Object to 'error'; pass the integer instead.
5713 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5714 formatted with plain %d.
5715
b189fa66
PE
5716 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5717
bff87ef0
PE
5718 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5719
7e2cac20
PE
5720 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5721
ce4d90b5
PE
5722 * xterm.c (x_catch_errors): Remove duplicate declaration.
5723
266c9547
PE
5724 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5725
79c49ad2
PE
5726 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5727
368f4090
JM
57282011-04-10 Jim Meyering <meyering@redhat.com>
5729
5730 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5731 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5732 return ssize_t not "int", and use size_t as the buffer length.
5733 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5734 * gnutls.h: Update declarations.
5735 * process.c (read_process_output): Use ssize_t, to match.
5736 (send_process): Likewise.
5737
a32d4040
CY
57382011-04-09 Chong Yidong <cyd@stupidchicken.com>
5739
5740 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5741
8546720e 57422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5743
04f2d78b
CB
5744 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5745 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5746
8546720e
GM
5747 * xterm.c (handle_one_xevent):
5748 * xmenu.c (create_and_show_popup_menu):
5749 * xselect.c (x_decline_selection_request)
5750 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5751
0a2f5c1a 57522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5753
5754 Fix some uses of `int' instead of EMACS_INT.
5755 * search.c (string_match_1, fast_string_match)
5756 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5757 (scan_buffer, find_next_newline_no_quit)
5758 (find_before_next_newline, search_command, Freplace_match)
5759 (Fmatch_data): Make some `int' variables be EMACS_INT.
5760
5761 * xdisp.c (display_count_lines): 3rd argument and return value now
5762 EMACS_INT. All callers changed.
5763 (pint2hrstr): Last argument is now EMACS_INT.
5764
5765 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5766 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5767 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5768 (decode_coding_utf_16, decode_coding_emacs_mule)
5769 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5770 (decode_coding_ccl, decode_coding_charset)
5771 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5772 (decode_coding_iso_2022, decode_coding_emacs_mule)
5773 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5774 <char_offset, last_offset>: Declare EMACS_INT.
5775 (encode_coding_utf_8, encode_coding_utf_16)
5776 (encode_coding_emacs_mule, encode_invocation_designation)
5777 (encode_designation_at_bol, encode_coding_iso_2022)
5778 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5779 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5780 Declare EMACS_INT.
5781 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5782 (encode_invocation_designation): Last argument P_NCHARS is now
5783 EMACS_INT.
5784 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5785 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5786
5787 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5788 All users changed.
5789
5790 * ccl.c (Fccl_execute_on_string): Declare some variables
5791 EMACS_INT.
5792
8546720e 57932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5794
5795 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5796
4e19a977
CS
57972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5798
5799 * process.c (Fformat_network_address): Doc fix.
5800
87302331
R
58012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5802
5803 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5804
cbb59342
CY
58052011-04-08 Chong Yidong <cyd@stupidchicken.com>
5806
5807 * keyboard.c (read_char): Call Lisp function help-form-show,
5808 instead of using internal_with_output_to_temp_buffer.
5809 (Qhelp_form_show): New var.
e0d38eeb 5810 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5811
5812 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5813
5814 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5815
e67a13ab
CY
58162011-04-06 Chong Yidong <cyd@stupidchicken.com>
5817
04f2d78b
CB
5818 * process.c (Flist_processes): Remove to Lisp.
5819 (list_processes_1): Delete.
e67a13ab 5820
973f782d
EZ
58212011-04-06 Eli Zaretskii <eliz@gnu.org>
5822
7c106b1e
EZ
5823 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5824
973f782d
EZ
5825 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5826
41cf7d1a 58272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5828
ca23cc88
PE
5829 Fix more problems found by GCC 4.6.0's static checks.
5830
f390e2d5
PE
5831 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5832
42eea0d0
PE
5833 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5834
b69769da 5835 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5836
f9541e84
PE
5837 * xdisp.c (vmessage): Mark as a printf-like function.
5838
13841b55
PE
5839 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5840
c136c10f
PE
5841 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5842
5e2d4a30
PE
5843 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5844 printf-like functions.
5845 (tiff_load): Add casts to remove these marks before passing them
5846 to system-supplied API.
5847
583f48b9
PE
5848 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5849
b25d760e
PE
5850 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5851 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5852 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5853 directly, rather than having caller test rule sign. This avoids
5854 some unnecessary tests.
5855 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5856 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5857 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5858
bc7b6697 5859 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5860 (xfont_open): Avoid unnecessary tests.
bc7b6697 5861
27ccc379
PE
5862 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5863
dcd5c89a
PE
5864 * composite.h, composite.c (composition_gstring_put_cache):
5865 Use EMACS_INT, not int, for length.
5866
b13a45c6
PE
5867 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5868 breaking out part of COMPOSITION_DECODE_RULE.
5869 (COMPOSITION_DECODE_RULE): Use it.
5870 * composite.c (get_composition_id): Remove unused local vars,
5871 by using the new macro.
5872
1e792e4d
PE
5873 * textprop.c (set_text_properties_1): Change while to do-while,
5874 since the condition is always true at first.
5875
dc6c6455 5876 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5877 (interval_deletion_adjustment): Return unsigned value.
5878 All uses changed.
dc6c6455 5879
aba7731a
PE
5880 * process.c (list_processes_1, create_pty, read_process_output):
5881 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5882 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5883 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5884 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5885 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5886
fdfc4bf3
PE
5887 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5888
fca8fe46 5889 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5890 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5891
06a0259a 5892 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5893 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5894 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5895
e7b9e80f
PE
5896 * print.c (print_error_message): Avoid int overflow.
5897
56201685
PE
5898 * font.c (font_list_entities): Redo for clarity,
5899 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5900
78834453 5901 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5902 (font_score): Avoid potential overflow in diff calculation.
78834453 5903
0bc0b309 5904 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5905 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5906
e610eaca
PE
5907 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5908
b895abce
PE
5909 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5910 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5911 can always succeed if overflow has undefined behavior.
5912
1f1d9321 5913 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5914 (wordify): Omit three unnecessary tests.
1f1d9321 5915
c59478bc
PE
5916 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5917 All callers changed. This avoids the need for an unused var.
5918
79b73827
PE
5919 * casefiddle.c (casify_region): Remove var that is set but not used.
5920
a4db5dfe
PE
5921 * dired.c (file_name_completion): Remove var that is set but not used.
5922
43aae36e
PE
5923 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5924
2a47c44d 5925 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5926 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5927
a37c69bf
PE
5928 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5929 Check for integer overflow on size calculations.
5930
328ab8e7
PE
5931 * buffer.c (Fprevious_overlay_change): Remove var that is set
5932 but not used.
5933
e5a2a5cb
PE
5934 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5935 Remove vars that are set but not used.
8d84a6eb 5936 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5937 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5938
a60e5f68
PE
5939 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5940
f661cb61 5941 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5942 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5943
f0397f5a
PE
5944 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5945 that are set but not used.
5946
8664db06 5947 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5948 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5949
6abdaa4a
PE
5950 * xselect.c (x_get_local_selection, x_handle_property_notify):
5951 Remove vars that are set but not used.
5952
0ce7538d 5953 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5954 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5955
9ae848fc
PE
5956 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5957 Remove var that is set but not used.
0b918413
PE
5958 (scroll_bar_windows_size): Now size_t, not int.
5959 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5960 Check for overflow.
9ae848fc 5961
a5a62657
PE
5962 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5963 (map_tty_color) [!defined MSDOS]: Likewise.
5964
5c5cdd39
PE
5965 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5966
66ebf983
PE
5967 * coding.c: Remove vars that are set but not used.
5968 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5969 All callers changed.
5970 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5971 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5972 (decode_coding_charset): Remove vars that are set but not used.
5973
1be4d761
PE
5974 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5975 that is set but not used.
5976
47553fa8
PE
5977 * print.c (print_object): Remove var that is set but not used.
5978
1f7196bf 5979 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5980 The gnulib version avoids calling malloc in the usual case,
5981 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5982 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5983 * filelock.c (current_lock_owner): Likewise.
5984 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5985 * sysdep.c: Include allocator.h, careadlinkat.h.
5986 (emacs_no_realloc_allocator): New static constant.
5987 (emacs_readlink): New function.
fdb61804
PE
5988 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5989 ../lib/careadlinkat.h.
d1fdcab7 5990
f84c17c7
SM
59912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5992
5993 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5994 first non-nil return value).
5995
ef3862ad
JD
59962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5997
5998 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5999 if not defined (Bug#8403).
6000
376a7006
JB
60012011-04-02 Juanma Barranquero <lekktu@gmail.com>
6002
6003 * xdisp.c (display_count_lines): Remove parameter `start',
6004 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6005 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6006 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6007 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6008 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6009 and thereabouts. All callers changed.
6010 (get_per_char_metric): Remove parameter `f', unused since
6011 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6012
6ca3801d
JM
60132011-04-02 Jim Meyering <meyering@redhat.com>
6014
6015 do not dereference NULL upon failed strdup
6016 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6017 (ns_get_family): Likewise.
6018
d8e2b5ba
JB
60192011-04-02 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6022
8c74fcbd
JD
60232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6024
6025 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6026 later (Bug#8403).
6027
7200d79c
SM
60282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6029
03408648 6030 Add lexical binding.
7200d79c 6031
03408648
SM
6032 * window.c (Ftemp_output_buffer_show): New fun.
6033 (Fsave_window_excursion):
6034 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6035
6036 * lread.c (lisp_file_lexically_bound_p): New function.
6037 (Fload): Bind Qlexical_binding.
6038 (readevalloop): Remove `evalfun' arg.
6039 Bind Qinternal_interpreter_environment.
6040 (Feval_buffer): Bind Qlexical_binding.
6041 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6042 Mark as dynamic.
6043 (syms_of_lread): Declare `lexical-binding'.
6044
6045 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6046
6047 * keyboard.c (eval_dyn): New fun.
6048 (menu_item_eval_property): Use it.
ca105506
SM
6049
6050 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6051
03408648
SM
6052 * fns.c (concat, mapcar1): Accept byte-code-functions.
6053
6054 * eval.c (Fsetq): Handle lexical vars.
6055 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6056 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6057 (FletX, Flet): Obey lexical binding.
6058 (Fcommandp): Handle closures.
6059 (Feval): New `lexical' arg.
6060 (eval_sub): New function extracted from Feval. Use it almost
6061 everywhere where Feval was used. Look up vars in lexical env.
6062 Handle closures.
6063 (Ffunctionp): Move from subr.el.
6064 (Ffuncall): Handle closures.
6065 (apply_lambda): Remove `eval_flags'.
6066 (funcall_lambda): Handle closures and new byte-code-functions.
6067 (Fspecial_variable_p): New function.
6068 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6069 but without exporting it to Lisp.
23aba0ea 6070
23aba0ea 6071 * doc.c (Fdocumentation, store_function_docstring):
03408648 6072 * data.c (Finteractive_form): Handle closures.
23aba0ea 6073
03408648
SM
6074 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6075 interactive spec.
ba83908c 6076
04f2d78b
CB
6077 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6078 New byte-codes.
03408648
SM
6079 (exec_byte_code): New function extracted from Fbyte_code to handle new
6080 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6081
03408648 6082 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6083
03408648 6084 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6085
e2abce01
JB
60862011-03-31 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * xdisp.c (redisplay_internal): Fix prototype.
6089
63696a73 60902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6091
63696a73 6092 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6093 (try_scrolling): Use it when setting scroll_limit.
6094 Limit scrolling to 100 screen lines.
63696a73
EZ
6095 (redisplay_window): Even when falling back on "recentering",
6096 position point in the window according to scroll-conservatively,
6097 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6098
6099 (try_scrolling): When point is above the window, allow searching
6100 as far as scroll_max, or one screenful, to compute vertical
6101 distance from PT to the scroll margin position. This prevents
6102 try_scrolling from unnecessarily failing when
6103 scroll-conservatively is set to a value slightly larger than the
6104 window height. Clean up the case of PT below the margin at bottom
6105 of window: scroll_max can no longer be INT_MAX. When aggressive
6106 scrolling is in use, don't let point enter the opposite scroll
6107 margin as result of the scroll.
6108 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6109 threshold of 100 lines for never-recentering scrolling.
6110
e4cc2dfc
JB
61112011-03-31 Juanma Barranquero <lekktu@gmail.com>
6112
6113 * dispextern.h (move_it_by_lines):
6114 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6115 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6116 (message_log_check_duplicate): Remove parameters `prev_bol' and
6117 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6118 (redisplay_internal): Remove parameter `preserve_echo_area',
6119 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6120
6121 * indent.c (Fvertical_motion):
6122 * window.c (window_scroll_pixel_based, Frecenter):
6123 Don't pass `need_y_p' to `move_it_by_lines'.
6124
1c470562
SM
61252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6126
44f230aa
SM
6127 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6128 steal a few bits to be more compact.
6129 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6130 Remove unneeded casts.
6131
1c470562
SM
6132 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6133
888adce9
ZK
61342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6135
6136 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6137 binding" message (bug#7967).
6138
f838ed7b
PE
61392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6140
77861b95
PE
6141 Fix more problems found by GCC 4.6.0's static checks.
6142
de6dbc14
PE
6143 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6144 Remove unused local var.
6145
f838ed7b
PE
6146 * editfns.c (Fmessage_box): Remove unused local var.
6147
792c7b2b
PE
6148 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6149 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6150 Omit unused local vars.
c499e557 6151 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6152 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6153 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6154 Omit unused local var.
6155
ba0165e1
PE
6156 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6157 Don't assume string length fits in int.
32ad8845 6158 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6159 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6160
3c59b4c9
PE
6161 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6162 instead of alloca (Bug#8344).
6163
a3eed478 6164 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6165 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6166
eb4d412d
PE
6167 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6168
1658b401
PE
6169 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6170 concerns.
6171
6172 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6173
6174 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6175
9a2c6e05
PE
6176 * keyboard.c (syms_of_keyboard): Use the same style as later
6177 in this function when indexing through an array. This also
6178 works around GCC bug 48267.
6179
03d0a109
PE
6180 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6181
44f730c8
PE
6182 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6183
fe75f926
PE
6184 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6185 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6186
ffa8c828
PE
6187 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6188 This avoids undefined behavior on integer overflow, and is a bit
6189 more convenient anyway since it is compared to a size_t variable.
6190
c5101a77
PE
6191 Variadic C functions now count arguments with size_t, not int.
6192 This avoids an unnecessary limitation on 64-bit machines, which
6193 caused (substring ...) to crash on large vectors (Bug#8344).
6194 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6195 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6196 All variadic functions and their callers changed accordingly.
c5101a77
PE
6197 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6198 * data.c (arith_driver, float_arith_driver): Likewise.
6199 * editfns.c (general_insert_function): Likewise.
6200 * eval.c (struct backtrace.nargs, interactive_p)
6201 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6202 (funcall_lambda, mark_backtrace): Likewise.
6203 * fns.c (concat): Likewise.
6204 * frame.c (x_set_frame_parameters): Likewise.
6205 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6206 0 if not found, not -1. All callers changed.
6207
dd3f25f7
PE
6208 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6209 (stack_copy_size): Now size_t, not int.
6210 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6211
461c2ab9
JB
62122011-03-28 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6215 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6216 All callers changed.
6217
6218 * lisp.h (multibyte_char_to_unibyte):
6219 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6220 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6221 * character.h (CHAR_TO_BYTE8):
6222 * cmds.c (internal_self_insert):
6223 * editfns.c (general_insert_function):
6224 * keymap.c (push_key_description):
6225 * search.c (Freplace_match):
6226 * xdisp.c (message_dolog, set_message_1): All callers changed.
6227
f6d62986
SM
62282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6229
6230 * keyboard.c (safe_run_hook_funcall): New function.
6231 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6232 don't set the hook to nil, but remove the offending function instead.
6233 (Qcommand_hook_internal): Remove, unused.
6234 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6235 Vcommand_hook_internal.
6236
6237 * eval.c (enum run_hooks_condition): Remove.
6238 (funcall_nil, funcall_not): New functions.
6239 (run_hook_with_args): Call each function through a `funcall' argument.
6240 Remove `cond' argument, now redundant.
6241 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6242 (Frun_hook_with_args_until_failure): Adjust accordingly.
6243 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6244
1db5b1ad
JB
62452011-03-28 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * dispextern.h (string_buffer_position): Remove declaration.
6248
6249 * print.c (strout): Remove parameter `multibyte', unused since
6250 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6251
6252 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6253 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6254 All callers changed.
6255
6256 * w32.c (_wsa_errlist): Use braces for struct initializers.
6257
6258 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6259 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6260 All callers changed.
6261 (string_buffer_position): Likewise. Also, make static (it's never
6262 used outside xdisp.c).
6263 (cursor_row_p): Remove parameter `w', unused since
6264 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6265 (decode_mode_spec): Remove parameter `precision', introduced during
6266 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6267 All callers changed.
6268
5ffb62aa
JD
62692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6270
6271 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6272
461c2ab9 62732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6274
6275 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6276 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6277 (ns_update_auto_hide_menu_bar): New functions.
6278 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6279 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6280 ns_constrain_all_frames.
6281 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6282 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6283
5c380ffb
JD
62842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6285
6286 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6287
9af30bdf
GM
62882011-03-27 Glenn Morris <rgm@gnu.org>
6289
6290 * syssignal.h: Replace RETSIGTYPE with void.
6291 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6292 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6293 Replace SIGTYPE with void everywhere.
6294 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6295 * s/template.h (SIGTYPE): Remove commented out definition.
6296
e2abce01
JB
62972011-03-26 Eli Zaretskii <eliz@gnu.org>
6298
6299 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6300 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6301
f868cd8a
JB
63022011-03-26 Juanma Barranquero <lekktu@gmail.com>
6303
59eb0929
JB
6304 * w32.c (read_unc_volume): Use parameter `henum', instead of
6305 global variable `wget_enum_handle'.
6306
6307 * keymap.c (describe_vector): Remove parameters `indices' and
6308 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6309 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6310
f868cd8a
JB
6311 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6312
6313 * keyboard.c (timer_check): Remove parameter `do_it_now',
6314 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6315 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6316 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6317
6318 * keyboard.c (read_char):
6319 * w32menu.c (w32_menu_display_help):
6320 * xmenu.c (show_help_event, menu_help_callback):
6321 Adjust calls to `show_help_echo'.
6322
6323 * gtkutil.c (xg_maybe_add_timer):
6324 * keyboard.c (readable_events):
6325 * process.c (wait_reading_process_output):
6326 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6327
6328 * insdel.c (adjust_markers_gap_motion):
6329 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6330 (gap_left, gap_right): Don't call it.
6331
2ecf6fdb
CY
63322011-03-25 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6335 incurred during fontification.
6336
6b1f9ba4
JB
63372011-03-25 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6340 (DEFVAR_PER_BUFFER): Don't pass it.
6341
6342 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6343 (scrolling_window): Don't pass it.
6344
0f4a96b5
JB
63452011-03-25 Juanma Barranquero <lekktu@gmail.com>
6346
6347 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6348
6349 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6350 and `suffix'.
6351 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6352 of variables specific to SELinux and computation of `encoded_absname'.
6353
6354 * image.c (XPutPixel): Remove unused variable `height'.
6355
6356 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6357
6358 * unexw32.c (get_section_info): Remove unused variable `section'.
6359
6360 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6361 (system_process_attributes): Remove unused variable `sess'.
6362 (sys_read): Remove unused variable `err'.
6363
6364 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6365 (w32_wnd_proc): Remove unused variable `isdead'.
6366 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6367 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6368 (x_create_tip_frame): Remove unused variable `tem'.
6369
6370 * w32inevt.c (w32_console_read_socket):
6371 Remove unused variable `no_events'.
6372
6373 * w32term.c (x_draw_composite_glyph_string_foreground):
6374 Remove unused variable `width'.
6375
1149507c
JB
63762011-03-24 Juanma Barranquero <lekktu@gmail.com>
6377
6378 * w32term.c (x_set_glyph_string_clipping):
6379 Don't pass uninitialized region to CombineRgn.
6380
9c88f339
JB
63812011-03-23 Juanma Barranquero <lekktu@gmail.com>
6382
6383 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6384 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6385 (Fx_close_connection): Remove unused variable `i'.
6386
6387 * w32font.c (w32font_draw): Return number of glyphs.
6388 (w32font_open_internal): Remove unused variable `i'.
6389 (w32font_driver): Add missing initializer.
6390
6391 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6392 (fill_in_menu): Remove unused variable `items_added'.
6393
6394 * w32term.c (last_mouse_press_frame): Remove static global variable.
6395 (w32_clip_to_row): Remove unused variable `f'.
6396 (x_delete_terminal): Remove unused variable `i'.
6397
6398 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6399 (NOTHING): Remove unused static global variable.
6400 (uniscribe_check_otf): Remove unused variable `table'.
6401 (uniscribe_font_driver): Add missing initializers.
6402
dee091a3
JD
64032011-03-23 Julien Danjou <julien@danjou.info>
6404
6405 * term.c (Fsuspend_tty, Fresume_tty):
6406 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6407 * window.c (temp_output_buffer_show):
6408 * insdel.c (signal_before_change):
6409 * frame.c (Fhandle_switch_frame):
6410 * fileio.c (Fdo_auto_save):
6411 * emacs.c (Fkill_emacs):
6412 * editfns.c (save_excursion_restore):
6413 * cmds.c (internal_self_insert):
6414 * callint.c (Fcall_interactively):
6415 * buffer.c (Fkill_all_local_variables):
6416 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6417 Use Frun_hooks.
0f4a96b5 6418 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6419 unconditionnaly since it does the check itself.
6420
2c520ab5 64212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6422
c9c49752
PE
6423 Fix more problems found by GCC 4.5.2's static checks.
6424
8abc3f12
PE
6425 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6426 the first time through the loop, since we know p0 < p1 then.
6427 This also avoids a gcc -Wstrict-overflow warning.
6428
a2d26660
PE
6429 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6430 leading to a memory leak, possible in functions like
6431 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6432 of objects (Bug#8318).
a2d26660 6433
916c72e9
PE
6434 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6435 that could (at least in theory) be that large.
6436
19ab8a18
PE
6437 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6438 This is less likely to overflow, and avoids undefined behavior if
6439 overflow does occur. All callers changed. Use strtoul to scan
6440 for the unsigned long integer.
b7cbbd6f
PE
6441 (pint2hrstr): Simplify and tune code slightly.
6442 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6443
f0641eff
PE
6444 * scroll.c (do_scrolling): Work around GCC bug 48228.
6445 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6446
7f650bb9
PE
6447 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6448 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6449 (validate_x_resource_name): Simplify count usage.
6450 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6451
37dd57d1
PE
6452 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6453 fail (Bug#8306).
81e56e61 6454
699979fc 6455 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6456
401bf9b4
PE
6457 * process.c (Fmake_network_process): Use socklen_t, not int,
6458 where POSIX says socklen_t is required in portable programs.
6459 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6460 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6461 (Fmake_network_process, server_accept_connection):
6462 (wait_reading_process_output, read_process_output):
6463 Likewise.
6464
b93aacde
PE
6465 * process.c: Rename or move locals to avoid shadowing.
6466 (list_processes_1, Fmake_network_process):
6467 (read_process_output_error_handler, exec_sentinel_error_handler):
6468 Rename or move locals.
4dc343ee 6469 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6470 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6471 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6472 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6473 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6474
af8a867c 6475 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6476 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6477 Include tparam.h instead, since it declares them.
af8a867c
PE
6478 * cm.h (PC): Remove extern decl; tparam.h now does this.
6479 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6480 * terminfo.c: Include tparam.h, to check interfaces.
6481 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6482 (tparam): Adjust signature to match interface in tparam.h;
6483 this removes some undefined behavior. Check that outstring and len
6484 are zero, which they always are with Emacs.
6485 * tparam.h (PC, BC, UP): New extern decls.
6486
0248044d 6487 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6488 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6489
8ff096c1 6490 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6491 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6492 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6493 (ftfont_list): Remove unused local.
49eaafba
PE
6494 (get_adstyle_property, ftfont_pattern_entity):
6495 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6496 Rename locals to avoid shadowing.
8ff096c1 6497
e2be39f6
PE
6498 * xfont.c (xfont_list_family): Mark var as initialized.
6499
c9735e30
PE
6500 * xml.c (make_dom): Now static.
6501
8f5201ae
PE
6502 * composite.c (composition_compute_stop_pos): Rename local to
6503 avoid shadowing.
b246f932
PE
6504 (composition_reseat_it): Remove unused locals.
6505 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6506 (composition_update_it): Mark var as initialized.
11b61122
PE
6507 (find_automatic_composition): Mark vars as initialized,
6508 with a FIXME (Bug#8290).
8f5201ae 6509
760fbc2c
PE
6510 character.h: Rename locals to avoid shadowing.
6511 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6512 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6513 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6514 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6515 to avoid shadowing.
6516
ff08eb85
PE
6517 * textprop.c (property_change_between_p): Remove; unused.
6518
fc7bf025
PE
6519 * intervals.c (interval_start_pos): Now static.
6520
235d7abc
PE
6521 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6522
44f230aa
SM
6523 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6524 Rename locals to avoid shadowing.
3e7d6594 6525
50060332
PE
6526 * sound.c (wav_play, au_play, Fplay_sound_internal):
6527 Fix pointer signedness.
d01f234b 6528 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6529 (wav_play): Initialize a variable to 0, to prevent undefined
6530 behavior (Bug#8278).
50060332 6531
c4fc4e30
PE
6532 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6533
918436ed
PE
6534 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6535
c939f91b
PE
6536 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6537 clobbering (Bug#8298).
b9c7f648
PE
6538 * sysdep.c (sys_subshell): Likewise.
6539 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6540
6bd8c144
PE
6541 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6542 This should get cleaned up, so that child_setup has the
6543 same signature on all platforms.
6544
7710357c 6545 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6546 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6547
c59da222
CY
65482011-03-22 Chong Yidong <cyd@stupidchicken.com>
6549
6550 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6551 not to be necessary, and produces flickering.
6552
66b87493
GM
65532011-03-20 Glenn Morris <rgm@gnu.org>
6554
6555 * config.in: Remove file.
6556
45b6f6d5
JB
65572011-03-20 Juanma Barranquero <lekktu@gmail.com>
6558
6559 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6560 are now in src/globals.h.
6561 (syms_of_minibuf): Remove spurious & from previous change.
6562
3ec03f7e
LL
65632011-03-20 Leo <sdl.web@gmail.com>
6564
6565 * minibuf.c (completing-read-function): New variable.
6566 (completing-read-default): Rename from completing-read.
6567 (completing-read): Call completing-read-function.
6568
b14e3e21
CY
65692011-03-19 Juanma Barranquero <lekktu@gmail.com>
6570
6571 * xfaces.c (Fx_load_color_file):
6572 Read color file from absolute filename (bug#8250).
6573
f2b726e6
JB
65742011-03-19 Juanma Barranquero <lekktu@gmail.com>
6575
6576 * makefile.w32-in: Update dependencies.
6577
09f6ff02
EZ
65782011-03-17 Eli Zaretskii <eliz@gnu.org>
6579
6580 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6581
29a6015a
PE
65822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6583
a3a6c54e
PE
6584 Fix more problems found by GCC 4.5.2's static checks.
6585
b766f867
PE
6586 * process.c (make_serial_process_unwind, send_process_trap):
6587 (sigchld_handler): Now static.
6588
be02381c
PE
6589 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6590 That way, the code declares only the vars that it needs.
6591 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6592 * s/cygwin.h (PTY_ITERATION): Likewise.
6593 * s/darwin.h (PTY_ITERATION): Likewise.
6594 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6595
57048744
PE
6596 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6597 * process.c (allocate_pty): Don't declare stb unless it's needed.
6598
7914961c 6599 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6600 (CONSTANTLIM): Remove; unused.
6601 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6602 Define only if needed.
7914961c 6603
b3967b18
PE
6604 * unexelf.c (unexec): Name an expression,
6605 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6606 Use a different way to cause a compilation error if anyone uses
6607 n rather than nn, a way that does not involve shadowing.
73366a00 6608 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6609
29a6015a
PE
6610 * deps.mk (unexalpha.o): Remove; unused.
6611
43cfc33e 6612 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6613 * unexec.h: New file.
ce701a33
PE
6614 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6615 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6616 Depend on unexec.h.
6617 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6618 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6619 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6620 Change as necessary to match prototype in unexec.h.
ce701a33 6621
01f44d5a
PE
6622 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6623 shadowing.
4f63c6bb 6624 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6625
a6670b0b
PE
6626 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6627 Rename locals to avoid shadowing.
6628
cef2010d 6629 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6630 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6631
d4d7173a
PE
6632 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6633
f08b802a
PE
6634 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6635 warning when compiling print.c.
6636
3ddb0639
PE
6637 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6638 instead of using an uninitialized var.
5ad03b97 6639 (font_sort_entities): Mark var as initialized.
3ddb0639 6640
170a2692
PE
6641 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6642
e663c700
PE
6643 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6644 pointers to constants.
89bc529a 6645 (font_parse_fcname): Remove unused vars.
7b81e2d0 6646 (font_delete_unmatched): Now static.
ea838e10 6647 (font_get_spec): Remove; unused.
13a547c6
PE
6648 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6649 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6650 Rename or move locals to avoid shadowing.
e663c700 6651
2a80c887 6652 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6653 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6654
1384fa33 6655 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6656 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6657
8b2c52e9
PE
6658 * alloc.c (mark_backtrace): Move decl from here ...
6659 * lisp.h: ... to here, so that it can be checked.
6660
475545b5 6661 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6662 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6663 (lisp_indirect_variable): Name an expression,
6664 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6665 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6666
b1349114 6667 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6668 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6669 Use const pointer when appropriate.
b1349114 6670
a2928364
PE
6671 * lisp.h (get_system_name, get_operating_system_release):
6672 Move decls here, to check interfaces.
6673 * process.c (get_operating_system_release): Move decl to lisp.h.
6674 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6675 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6676 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6677 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6678 (Fformat_time_string, Fencode_time, Finsert_char):
6679 (Ftranslate_region_internal, Fformat):
6680 Rename or remove local vars to avoid shadowing.
9710023e 6681 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6682
a415e694
PE
6683 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6684 avoid shadowing.
6685
8ef4622d
PE
6686 * lisp.h (eassert): Check that the argument compiles, even if
6687 ENABLE_CHECKING is not defined.
6688
946f9a5b
PE
6689 * data.c (Findirect_variable): Name an expression, to avoid
6690 gcc -Wbad-function-cast warning.
112396d6 6691 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6692 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6693 (Fmake_variable_buffer_local, Fmake_local_variable):
6694 Mark variables as initialized.
52746918 6695 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6696
e5aab7e7 6697 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6698 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6699 Rename locals to avoid shadowing.
dff45157
PE
6700 (mark_stack): Move local variables into the #ifdef region where
6701 they're used.
7bc26fdb
PE
6702 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6703 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6704 needed otherwise.
6705 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6706 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6707 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6708
e5aab7e7
PE
6709 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6710 avoids undefined behavior in theory.
6711
4da60324
PE
6712 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6713
88043301
PE
6714 Use functions, not macros, for up- and down-casing (Bug#8254).
6715 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6716 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6717 to use the following functions instead of these macros.
6718 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6719 EMACS_INT, since callers assume the returned value fits in int.
6720 (upcase1): Likewise, for UPCASE_TABLE.
6721 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6722 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6723 the race-condition problem in the old DOWNCASE.
88043301 6724
19ed5445
PE
6725 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6726 Rename locals to avoid shadowing.
6727 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6728 (regex_compile, re_search_2, re_match_2_internal):
6729 Remove unused local vars.
952db0d7
PE
6730 (FREE_VAR): Rewrite so as not to use empty "else",
6731 which gcc can warn about.
da053e48 6732 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6733 (RETALLOC_IF): Define only if needed.
6734 (WORDCHAR_P): Likewise. This one is never needed, but is used
6735 only in a comment talking about a compiler bug, so put inside
6736 the #if 0 of that comment.
6737 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6738 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6739 Remove; unused.
19ed5445 6740
1f3561e4 6741 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6742 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6743 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6744
ded6f8f7
PE
6745 * search.c (simple_search): Remove unused var.
6746
dbd37a95
PE
6747 * dired.c (compile_pattern): Move decl from here ...
6748 * lisp.h: ... to here, so that it can be checked.
6749 (struct re_registers): New forward decl.
6750
7e47afad
PE
6751 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6752
85f24f61
PE
6753 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6754 All uses changed.
6755 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6756 Rename locals to avoid shadowing.
5671df8f 6757 (Fvertical_motion): Mark locals as initialized.
85f24f61 6758
181aa2be 6759 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6760 (casify_region): Mark local as initialized.
181aa2be 6761
930d429c
PE
6762 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6763
7082eac6
PE
6764 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6765 New macros, so that the caller can use some names other than
6766 gcpro1, gcpro2, etc.
6767 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6768 of the new macros.
6769 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6770 argument, for consistency with GCPRO2_VAR, etc: it is now the
6771 prefix of the variable, not the variable itself. All uses
6772 changed.
38b2c076
PE
6773 * dired.c (directory_files_internal, file_name_completion):
6774 Rename locals to avoid shadowing.
6775
15206ed9
PE
6776 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6777 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6778 dired.c's scmp function, had undefined behavior.
6779 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6780 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6781 * buffer.h: ... to here, because these macros use current_buffer,
6782 and the new implementation with inline functions needs to have
6783 current_buffer in scope now, rather than later when the macros
6784 are used.
6785 (downcase, upcase1): New static inline functions.
6786 (DOWNCASE, UPCASE1): Reimplement using these functions.
6787 This avoids undefined behavior in expressions like
6788 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6789 from race conditions in accessing the global variables
6790 case_temp1 and case_temp2.
6791 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6792 * lisp.h (case_temp1, case_temp2): Remove their decls.
6793 * character.h (ASCII_CHAR_P): Move from here ...
6794 * lisp.h: ... to here, so that the inline functions mentioned
6795 above can use them.
6796
4a6bea26
PE
6797 * dired.c (directory_files_internal_unwind): Now static.
6798
f14b7e14
PE
6799 * fileio.c (file_name_as_directory, directory_file_name):
6800 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6801 Now static.
2893f146
PE
6802 (file_name_as_directory): Use const pointers when appropriate.
6803 (Fexpand_file_name): Likewise. In particular, newdir might
6804 point at constant storage, so make it a const pointer.
fd4ead52 6805 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6806 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6807 signedness issues.
f839df0c
PE
6808 (Fset_file_times, Finsert_file_contents, auto_save_error):
6809 Rename locals to avoid shadowing.
f14b7e14 6810
5716756e 6811 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6812 (Ftry_completion, Fall_completions): Rename or remove locals
6813 to avoid shadowing.
5716756e 6814
b4c3046a
PE
6815 * marker.c (bytepos_to_charpos): Remove; unused.
6816
b45db522
PE
6817 * lisp.h (verify_bytepos, count_markers): New decls,
6818 so that gcc does not warn that these functions aren't declared.
6819
85876d07
PE
6820 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6821 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6822 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6823 (copy_text): Remove unused local var.
85876d07 6824
03d78a21 6825 * filelock.c (within_one_second): Now static.
b3dd38ab 6826 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6827
5df8f01b
PE
6828 * buffer.c (fix_overlays_before): Mark locals as initialized.
6829 (fix_start_end_in_overlays): Likewise. This function should be
6830 simplified by using pointers-to-pointers, but that's a different
6831 matter.
b1d876f1 6832 (switch_to_buffer_1): Now static.
8f54f30a
PE
6833 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6834 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6835
a70072c9 6836 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6837 Fix pointer signedness issue.
edced198
PE
6838 (sys_subshell): Mark local as volatile if checking for lint,
6839 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6840 (MAXPATHLEN): Define only if needed.
a70072c9 6841
a0977c44
PE
6842 * process.c (serial_open, serial_configure): Move decls from here ...
6843 * systty.h: ... to here, so that they can be checked.
6844
a884fdcc
PE
6845 * fns.c (get_random, seed_random): Move extern decls from here ...
6846 * lisp.h: ... to here, so that they can be checked.
6847
604efe86 6848 * sysdep.c (reset_io): Now static.
b8950c94 6849 (wait_for_termination_signal): Remove; unused.
604efe86 6850
38fc62d9
PE
6851 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6852 (copy_keymap_item, append_key, push_text_char_description):
6853 Now static.
1004a21a 6854 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6855 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6856 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6857 (describe_map_tree):
6858 Rename locals to avoid shadowing.
38fc62d9 6859
2f2650da
PE
6860 * keyboard.c: Declare functions static if they are not used elsewhere.
6861 (echo_char, echo_dash, cmd_error, top_level_2):
6862 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6863 (read_char, kbd_buffer_get_event, make_lispy_position):
6864 (make_lispy_event, make_lispy_movement, apply_modifiers):
6865 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6866 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6867 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6868 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6869 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6870
a053e86c 6871 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6872 (mark_kboards): Move decl here ...
6873 * alloc.c (mark_kboards): ... from here.
a053e86c 6874
4752793e
PE
6875 * lisp.h (force_auto_save_soon): New decl.
6876
74f10ca7 6877 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6878 (DEFINE_DUMMY_FUNCTION): New macro.
6879 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6880 Use it.
c03cd23f
PE
6881 (main): Add casts to avoid warnings
6882 if GCC considers string literals to be constants.
74f10ca7 6883
022e70d4
PE
6884 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6885
59d6fe83
PE
6886 * dbusbind.c: Pointer signedness fixes.
6887 (xd_signature, xd_append_arg, xd_initialize):
6888 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6889 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6890 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6891 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6892
78320123
PE
6893 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6894 if GCC considers string literals to be constants.
49cebcca 6895 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6896
35ac2a97
SM
68972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6898
fb103ca9
SM
6899 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6900 (print_preprocess, print_object): New macro to fix last change.
6901
35ac2a97
SM
6902 * print.c (print_preprocess): Don't forget font objects.
6903
62973b41
JB
69042011-03-16 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * emacs.c (USAGE3): Doc fixes.
6907
0e48bb22
AS
69082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6909
6910 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6911 structure.
6912
7684e57b
JB
69132011-03-14 Juanma Barranquero <lekktu@gmail.com>
6914
6915 * lisp.h (VWindow_system, Qfile_name_history):
6916 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6917 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6918 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6919
6920 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6921 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6922
6923 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6924 * w32console.c (detect_input_pending, read_input_pending)
6925 (encode_terminal_code):
6926 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6927 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6928 (w32_system_caret_y, Qfile_name_history):
6929 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6930 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6931 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6932 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6933 * w32proc.c (Qlocal, report_file_error):
6934 * w32term.c (Vwindow_system, updating_frame):
6935 * w32uniscribe.c (initialized, uniscribe_font_driver):
6936 Remove unneeded extern declarations.
6937
2aa46d6c
CY
69382011-03-14 Chong Yidong <cyd@stupidchicken.com>
6939
c96bbc66 6940 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6941
cffc6f3b
CY
69422011-03-13 Chong Yidong <cyd@stupidchicken.com>
6943
6944 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6945 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6946 These macros can no longer be used for assignment.
6947
44f230aa
SM
6948 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6949 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6950 (record_buffer_markers, fetch_buffer_markers): New functions for
6951 recording and fetching special buffer markers.
6952 (set_buffer_internal_1, set_buffer_temp): Use them.
6953
6954 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6955
6956 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6957
6958 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6959 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6960
6961 * xdisp.c (hscroll_window_tree):
6962 (reconsider_clip_changes): Use PT instead of BUF_PT.
6963
d251f04b
EZ
69642011-03-13 Eli Zaretskii <eliz@gnu.org>
6965
6966 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6967 $(EMACS_ROOT)/lib/intprops.h.
6968
f0c77cd1
PE
69692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6970
3eca4629
PE
6971 Fix more problems found by GCC 4.5.2's static checks.
6972
7c86ee98
PE
6973 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6974 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6975 (xg_free_frame_widgets): Make it clear that a local variable is
6976 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6977 (gdk_window_get_screen): Make it clear that this macro is needed
6978 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6979 (int_gtk_range_get_value): New function, which avoids a diagnostic
6980 from gcc -Wbad-function-cast.
6981 (xg_set_toolkit_scroll_bar_thumb): Use it.
6982 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6983 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6984 (get_utf8_string, xg_get_file_with_chooser):
6985 Rename locals to avoid shadowing.
6986 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6987
41729b81
PE
6988 * xgselect.c (xg_select): Remove unused var.
6989
f0c77cd1
PE
6990 * image.c (four_corners_best): Mark locals as initialized.
6991 (gif_load): Initialize transparent_p to zero (Bug#8238).
6992 Mark another local as initialized.
ec6cf4c6 6993 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6994
ce0ad53d 6995 * image.c (clear_image_cache): Now static.
d5d5a617 6996 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6997 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6998 (x_edge_detection): Remove unnecessary cast that
6999 gcc -Wbad-function-cast diagnoses.
2037898d 7000 (gif_load): Fix pointer signedness.
6ae141d6
PE
7001 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7002 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7003
33383987 70042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7005
d32df629
PE
7006 Improve quality of tests for time stamp overflow.
7007 For example, without this patch (encode-time 0 0 0 1 1
7008 1152921504606846976) returns the obviously-bogus value (-948597
7009 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7010 reports time overflow. See
7011 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7012 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7013 * editfns.c: Include limits.h and intprops.h.
7014 (TIME_T_MIN, TIME_T_MAX): New macros.
7015 (time_overflow): Move earlier, to before first use.
7016 (hi_time, lo_time): New functions, for an accurate test for
7017 out-of-range times.
7018 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7019 (Fget_internal_run_time): Don't assume time_t fits in int.
7020 (make_time): Use list2 instead of Fcons twice.
7021 (Fdecode_time): More accurate test for out-of-range times.
7022 (check_tm_member): New function.
7023 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7024 (lisp_time_argument): Don't rely on undefined left-shift and
7025 right-shift behavior when checking for time stamp overflow.
8be6f318 7026
fe31d94c
PE
7027 * editfns.c (time_overflow): New function, refactoring common code.
7028 (Fformat_time_string, Fdecode_time, Fencode_time):
7029 (Fcurrent_time_string): Use it.
7030
8be6f318
PE
7031 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7032 * dired.c (make_time): Move to ...
7033 * editfns.c (make_time): ... here.
7034 * systime.h: Note the move.
7035
09d9db2c 70362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7037
126bc0dc
YM
7038 * fringe.c (update_window_fringes): Remove unused variables.
7039
c47cbdfd
YM
7040 * unexmacosx.c (copy_data_segment): Also copy __got section.
7041 (Bug#8223)
7042
7ac80be9
EZ
70432011-03-12 Eli Zaretskii <eliz@gnu.org>
7044
c96bbc66 7045 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7046 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7047 Constify `char *' arguments and their references according to
7048 prototypes in tparam.h.
7049
ecb0f94d 7050 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7051
7ac80be9
EZ
7052 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7053 Adapt all references accordingly.
7054
7055 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7056
ef1fd07e
TT
70572011-03-11 Tom Tromey <tromey@redhat.com>
7058
7059 * buffer.c (syms_of_buffer): Remove obsolete comment.
7060
7ef4b50c
EZ
70612011-03-11 Eli Zaretskii <eliz@gnu.org>
7062
7063 * termhooks.h (encode_terminal_code): Declare prototype.
7064
7065 * msdos.c (encode_terminal_code): Don't declare prototype.
7066
7067 * term.c (encode_terminal_code): Now external again, used by
7068 w32console.c and msdos.c.
7069
44f230aa
SM
7070 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7071 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7072
4b1ec863 70732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7074
1714f52b 7075 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7076
4b1ec863
PE
7077 * fringe.c (update_window_fringes): Mark locals as initialized
7078 (Bug#8227).
7079 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7080
524c7aa6
PE
7081 * alloc.c (mark_fringe_data): Move decl from here ...
7082 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7083 to check its interface.
7084 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7085
a5c0af81 7086 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7087 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7088 (fontset_font): Mark local as initialized.
a9a06e0b 7089 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7090
b4716021
PE
7091 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7092
811e9bac 7093 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7094 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7095 (x_own_selection, Fx_disown_selection_internal): Rename locals
7096 to avoid shadowing.
7097 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7098
7e3ab302
PE
7099 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7100 so that the caller can use some name other than gcpro1.
7101 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7102 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7103 (Fx_backspace_delete_keys_p):
7104 Use them to avoid shadowing, and rename vars to avoid shadowing.
7105 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7106 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7107 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7108 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7109 Remove unused locals.
7e3ab302
PE
7110 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7111 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7112 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7113 macros.
f78faa98 7114
e2b13473
PE
7115 * xterm.h (x_mouse_leave): New decl.
7116
77f23912
PE
7117 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7118 Remove unused functions.
cdf4ba58
PE
7119 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7120 (x_calc_absolute_position): Now static.
7411c686 7121 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7122 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7123 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7124 unless they are used.
38d0b34a
PE
7125 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7126 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7127 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7128 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7129 (x_error_catcher, x_connection_closed, x_error_handler):
7130 (x_error_quitter, xembed_send_message, x_iconify_frame):
7131 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7132 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7133 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7134
44f230aa
SM
7135 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7136 Rename or move locals to avoid shadowing.
6b463e58 7137 (tty_defined_color, merge_face_heights): Now static.
5967d051 7138 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7139 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7140 does not deduce is never used uninitialized.
73719eba
PE
7141 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7142 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7143
426994c3 7144 * terminal.c (store_terminal_param): Now static.
5489860b 7145
032f1620 7146 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7147 (set_frame_menubar): Remove unused local.
d4323972 7148 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7149 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7150 since they might point to immutable storage.
281585b0
PE
7151 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7152 since it's unused otherwise.
032f1620 7153
367c19e5 7154 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7155 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7156 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7157 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7158 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7159 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7160 does not deduce are never used uninitialized.
70739cbe 7161
07b48fa9
PE
7162 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7163
8868a238 7164 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7165 * window.c (window_loop, size_window):
7166 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7167
7e5cf297 7168 * window.c (display_buffer): Now static.
d6550a9f
PE
7169 (size_window): Mark variables that gcc -Wuninitialized
7170 does not deduce are never used uninitialized.
a586633d
PE
7171 * window.h (check_all_windows): New decl, to forestall
7172 gcc -Wmissing-prototypes diagnostic.
5b555da1 7173 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7174
f6095868
PE
7175 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7176 shadowing.
7177 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7178 Include <limits.h>.
7179 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7180 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7181 (load_charset_map): Mark variables that gcc -Wuninitialized
7182 does not deduce are never used uninitialized.
53df7c11 7183 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7184
f38b440c
PE
7185 * coding.c (coding_set_source, coding_set_destination):
7186 Use "else { /* comment */ }" rather than "else /* comment */;"
7187 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7188 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7189 a block, when the outer 'i' will do.
7190 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7191 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7192 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7193 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7194 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7195 Rename locals to avoid shadowing.
7196 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7197 * coding.c (emacs_mule_char, encode_invocation_designation):
7198 Now static, since they're not used elsewhere.
413bb2db 7199 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7200 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7201 (decode_coding_emacs_mule): Mark variables that gcc
7202 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7203 (detect_coding_iso_2022): Initialize a local variable that might
7204 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7205 this initialization is needed. (Bug#8211)
5f58e762
PE
7206 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7207 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7208 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7209 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7210 Remove unused macros.
f38b440c 7211
232b38b9 7212 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7213 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7214 * character.c (string_count_byte8): Likewise.
232b38b9 7215
fb90da1b
PE
7216 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7217 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7218
fb93dbc2
PE
7219 * chartab.c (copy_sub_char_table): Now static, since it's not used
7220 elsewhere.
5c156ace
PE
7221 (sub_char_table_ref_and_range, char_table_ref_and_range):
7222 Rename locals to avoid shadowing.
bbcd0949 7223 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7224
7d3b3862 7225 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7226 (BIDI_BOB): Remove unused macro.
7d3b3862 7227
6be7d3da
PE
7228 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7229 deduce are never used uninitialized.
c2ed9c8b 7230 * term.c (encode_terminal_code): Likewise.
6be7d3da 7231
75f8807f 7232 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7233
50938595
PE
7234 * tparam.h: New file.
7235 * term.c, tparam.h: Include it.
7236 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7237 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7238 Move these decls to tparam.h, and make them agree with what
7239 is actually in tparam.c. The previous trick of using incompatible
7240 decls in different modules does not conform to the C standard.
7241 All callers of tparam changed to use tparam's actual API.
7242 * tparam.c (tparam1, tparam, tgoto):
7243 Use const pointers where appropriate.
7244
fbceeba2
PE
7245 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7246 * cm.h (struct cm): Likewise.
7247 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7248 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7249 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7250 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7251 (turn_on_face, init_tty): Likewise.
7252 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7253
7f3f1250
PE
7254 * term.c (term_mouse_position): Rename local to avoid shadowing.
7255
e6ca6543
PE
7256 * alloc.c (mark_ttys): Move decl from here ...
7257 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7258
c40f8d15
AS
72592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7260
7261 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7262
cfe0661d
JB
72632011-03-09 Juanma Barranquero <lekktu@gmail.com>
7264
7265 * search.c (compile_pattern_1): Remove argument regp, unused since
7266 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7267 (compile_pattern): Don't pass it.
7268
0afb4571
J
72692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7270
7271 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7272 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7273 for ! HAVE_GTK3.
7274 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7275
7276 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7277
7278 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7279 gdk_window_get_screen, gdk_window_get_geometry,
7280 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7281 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7282 (xg_get_pixbuf_from_pixmap): New function.
7283 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7284 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7285 Call xg_get_pixbuf_from_pixmap instead of
7286 gdk_pixbuf_get_from_drawable.
7287 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7288 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7289 (xg_check_special_colors): Use GtkStyleContext and its functions
7290 for HAVE_GTK3.
7291 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7292 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7293 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7294 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7295 Call gtk_widget_get_preferred_size.
0afb4571
J
7296 (xg_frame_resized): gdk_window_get_geometry only takes 5
7297 parameters.
44f230aa
SM
7298 (xg_win_to_widget, xg_event_is_for_menubar):
7299 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7300 (xg_set_widget_bg): New function.
7301 (delete_cb): New function.
895009e1 7302 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7303 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7304 (xg_set_background_color): Call xg_set_widget_bg.
7305 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7306 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7307 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7308 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7309 if ! HAVE_GTK3.
7310 (update_frame_tool_bar): Call gtk_widget_hide.
7311 (xg_initialize): Use GDK_KEY_g.
7312
7313 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7314 if ! HAVE_GTK3
7315 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7316
7317 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7318 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7319 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7320
1c2cc4ef
JB
73212011-03-08 Juanma Barranquero <lekktu@gmail.com>
7322
7323 * w32xfns.c (select_palette): Check success of RealizePalette against
7324 GDI_ERROR, not zero.
7325
33383987 7326See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7327
7328;; Local Variables:
7329;; coding: utf-8
aac0c6e3
MR
7330;; End:
7331
33383987 7332 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7333
7334 This file is part of GNU Emacs.
7335
7336 GNU Emacs is free software: you can redistribute it and/or modify
7337 it under the terms of the GNU General Public License as published by
7338 the Free Software Foundation, either version 3 of the License, or
7339 (at your option) any later version.
7340
7341 GNU Emacs is distributed in the hope that it will be useful,
7342 but WITHOUT ANY WARRANTY; without even the implied warranty of
7343 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7344 GNU General Public License for more details.
7345
7346 You should have received a copy of the GNU General Public License
7347 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.