Mark tiny change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e16e55d4
JB
12011-05-02 Juanma Barranquero <lekktu@gmail.com>
2
3 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4
bafcf6a5
JB
52011-05-02 Juanma Barranquero <lekktu@gmail.com>
6
7 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15 (Qgnutls_bootprop_callbacks_verify): Make static.
16
e7a6747f
AS
172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
18
19ed11ba
AS
19 * callproc.c: Indentation fixup.
20
e7a6747f
AS
21 * sysdep.c (wait_for_termination_1): Make static.
22 (wait_for_termination, interruptible_wait_for_termination): Move
23 after wait_for_termination_1.
24
1ef14cb4
LMI
252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
26
27 * sysdep.c (interruptible_wait_for_termination): New function
28 which is like wait_for_termination, but allows keyboard
29 interruptions.
30
31 * callproc.c (Fcall_process): Add (:file "file") as an option for
32 the STDOUT buffer.
33 (Fcall_process_region): Ditto.
34
330d880c
EZ
352011-04-30 Eli Zaretskii <eliz@gnu.org>
36
8db90b73
EZ
37 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
38 rather than `XVECTOR (FOO)->size'.
39
330d880c
EZ
40 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
41 inttypes.h, as a gnulib replacement is used if it not available in
42 system headers.
43
15cbd324
EZ
442011-04-21 Eli Zaretskii <eliz@gnu.org>
45
46 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
47 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
48 of MOST_POSITIVE_FIXNUM. (Bug#8528)
49
50 * coding.c (coding_alloc_by_realloc): Error out if destination
51 will grow beyond MOST_POSITIVE_FIXNUM.
52 (decode_coding_emacs_mule): Abort if there isn't enough place in
53 charbuf for the composition carryover bytes. Reserve an extra
54 space for up to 2 characters produced in a loop.
55 (decode_coding_iso_2022): Abort if there isn't enough place in
56 charbuf for the composition carryover bytes.
57
582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 59
ae940cca
EZ
60 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
61 aborting when %lld or %lll format is passed.
62 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
63 %llo or %llx format is passed. (Bug#8545)
64
03ab8921
EZ
65 * window.c (window_scroll_line_based): Use a marker instead of
66 simple variables to record original value of point. (Bug#7952)
67
afda1437
EZ
68 * doprnt.c (doprnt): Fix the case where a multibyte sequence
69 produced by %s or %c overflows available buffer space. (Bug#8545)
70
f76dee0c
PE
712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
72
73 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 74 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 75
fdc5744d
JB
762011-04-28 Juanma Barranquero <lekktu@gmail.com>
77
78 * w32.c (init_environment): Warn about defaulting HOME to C:\.
79
638f053a
JB
802011-04-28 Juanma Barranquero <lekktu@gmail.com>
81
82 * keyboard.c (Qdelayed_warnings_hook): Define.
83 (command_loop_1): Run `delayed-warnings-hook'
84 if Vdelayed_warnings_list is non-nil.
85 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
86 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
87
d178f871
EZ
882011-04-28 Eli Zaretskii <eliz@gnu.org>
89
90 * doprnt.c (doprnt): Don't return value smaller than the buffer
91 size if the message was truncated. (Bug#8545).
92
b124fd93
JB
932011-04-28 Juanma Barranquero <lekktu@gmail.com>
94
95 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
96 (Fx_window_property): #if-0 the whole functions, not just the bodies.
97
e810457d
PE
982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
99
100 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
101
ea51cceb
JB
1022011-04-27 Juanma Barranquero <lekktu@gmail.com>
103
104 * makefile.w32-in: Update dependencies.
105
94dcfacf
EZ
1062011-04-27 Eli Zaretskii <eliz@gnu.org>
107
108 Improve `doprnt' and its usage. (Bug#8545)
109 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
110 `format_end'. Remove support for %l as a conversion specifier.
111 Don't use xrealloc. Improve diagnostics when the %l size modifier
112 is used. Update the commentary.
113
114 * eval.c (verror): Simplify calculation of size_t.
115
116 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
117 messages.
118
f61f41d7
PE
1192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
120
121 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
122 change.
123
96fb4434
PE
1242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
125
126 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
127 This makes this file independent of the recent pseudovector change.
128
671875da 1292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 130
69e9b5a3
PE
131 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
132
b5f869a7 133 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 134 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 135 Remove unused local.
c8926152 136 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 137
841a1577 138 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
139 GCC 4.6.0 optimizes based on type-based alias analysis. For
140 example, if b is of type struct buffer * and v of type struct
141 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
142 != &v->size, and therefore "v->size = 1; b->size = 2; return
143 v->size;" must therefore return 1. This assumption is incorrect
144 for Emacs, since it type-puns struct Lisp_Vector * with many other
145 types. To fix this problem, this patch adds a new type struct
f904488f 146 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
147 and pseudovectors, and helps optimizing compilers not get fooled
148 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
149 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
150 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
151 the size member.
eab3844f
PE
152 (XSETPVECTYPE): Rewrite in terms of new macro.
153 (XSETPVECTYPESIZE): New macro, specifying both type and size.
154 This is a bit clearer, and further avoids the possibility of
155 undesirable aliasing.
156 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 157 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
158 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
159 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
160 (ASIZE): Now uses header.size rather than size. All
161 previous uses of XVECTOR (foo)->size replaced to use this macro,
162 to avoid the hassle of writing XVECTOR (foo)->header.size.
163 (struct vectorlike_header): New type.
eab3844f
PE
164 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
165 object, to help avoid aliasing.
166 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
167 (SUBRP): Likewise, since Lisp_Subr is a special case.
168 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
169 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
170 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 171 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
172 changed to be "header.size" and "header.next".
173 * buffer.h (struct buffer): Likewise.
174 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
175 * frame.h (struct frame): Likewise.
176 * process.h (struct Lisp_Process): Likewise.
177 * termhooks.h (struct terminal): Likewise.
178 * window.c (struct save_window_data, struct saved_window): Likewise.
179 * window.h (struct window): Likewise.
180 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
181 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
182 * buffer.c (init_buffer_once): Likewise.
183 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
184 special case.
185 * process.c (Fformat_network_address): Use local var for size,
186 for brevity.
187
0df1eac5
PE
188 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
189
847ab9d1 190 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
191 * data.c (atof): Remove decl; no longer used or needed.
192 (digit_to_number): Move to lread.c.
193 (Fstring_to_number): Use new string_to_number function, to be
194 consistent with how the Lisp reader treats infinities and NaNs.
195 Do not assume that floating-point numbers represent EMACS_INT
196 without losing information; this is not true on most 64-bit hosts.
197 Avoid double-rounding errors, by insisting on integers when
198 parsing non-base-10 numbers, as the documentation specifies.
199 * lisp.h (string_to_number): New decl, replacing ...
200 (isfloat_string): Remove.
bc0a5c13 201 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 202 (read1): Do not accept +. and -. as integers; this
452f4150
PE
203 appears to have been a coding error. Similarly, do not accept
204 strings like +-1e0 as floating point numbers. Do not report
205 overflow for integer overflows unless the base is not 10 which
206 means we have no simple and reliable way to continue.
207 Break out the floating-point parsing into a new
208 function string_to_number, so that Fstring_to_number parses
209 floating point numbers consistently with the Lisp reader.
210 (digit_to_number): Moved here from data.c. Make it static inline.
211 (E_CHAR, EXP_INT): Remove, replacing with ...
212 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
213 (string_to_number): New function, replacing isfloat_string.
214 This function checks for valid syntax and produces the resulting
215 Lisp float number too. Rework it so that string-to-number
bc0a5c13 216 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
217 so that overflow for non-base-10 numbers is reported only when
218 there's no portable and simple way to convert to floating point.
452f4150 219
67769ffc
PE
220 * textprop.c (set_text_properties_1): Rewrite for clarity,
221 and to avoid GCC warning about integer overflow.
222
c20db43f
PE
223 * intervals.h (struct interval): Use EMACS_INT for members
224 where EMACS_UINT might cause problems. See
225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
226 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
227 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
228 All uses changed.
37aa2f85
PE
229 (offset_intervals): Tell GCC not to worry about length overflow
230 when negating a negative length.
c20db43f 231
2538aa2f
PE
232 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
233 (overrun_check_free): Likewise.
234
f2d3008d
PE
235 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
236 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
237 word size.
238
ec8df744
PE
239 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
240 (gnutls_make_error): Rename local to avoid shadowing.
241 (gnutls_emacs_global_deinit): ifdef out; not used.
242 (Fgnutls_boot): Use const for pointer to readonly storage.
243 Comment out unused local. Fix pointer signedness problems.
244
640ee02d
PE
245 * lread.c (openp): Don't stuff size_t into an 'int'.
246 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
247 about possible signed overflow.
248
6048fb2a
PE
249 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
250 (GDK_KEY_g): Don't define if already defined.
251 (xg_prepare_tooltip): Avoid pointer signedness problem.
252 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
253
fa3c87e1
PE
254 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
255 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
256
2172544b
PE
257 * xfns.c (Fx_window_property): Simplify a bit,
258 to make a bit faster and to avoid GCC 4.6.0 warning.
259 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
260
9b821a21
PE
261 * fns.c (internal_equal): Don't assume size_t fits in int.
262
3c616cfa
PE
263 * alloc.c (compact_small_strings): Tighten assertion a little.
264
c2982e87
PE
265 Replace pEd with more-general pI, and fix some printf arg casts.
266 * lisp.h (pI): New macro, generalizing old pEd macro to other
267 conversion specifiers. For example, use "...%"pI"d..." rather
268 than "...%"pEd"...".
269 (pEd): Remove. All uses replaced with similar uses of pI.
270 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
271 * alloc.c (check_pure_size): Don't overflow by converting size to int.
272 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
273 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
274 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
275 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
276 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
277 64-bit hosts.
278 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
279 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
280 * print.c (safe_debug_print, print_object): Likewise.
281 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
282 to int.
6f04d126
PE
283 Use pI instead of if-then-else-abort. Use %p to avoid casts,
284 avoiding the 0 flag, which is not portable.
c2982e87
PE
285 * process.c (Fmake_network_process): Use pI to avoid cast.
286 * region-cache.c (pp_cache): Likewise.
287 * xdisp.c (decode_mode_spec): Likewise.
288 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
289 behavior on 64-bit hosts with printf arg.
6f04d126 290 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
291 (x_stop_queuing_selection_requests): Likewise.
292 (x_get_window_property): Don't truncate byte count to an 'int'
293 when tracing.
0b432f21 294
5e073ec7
PE
295 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
296 here, since it parses constructs like leading '-' and spaces,
297 which are not wanted; and it overflows with large numbers.
298 Instead, simply match F[0-9]+, which is what is wanted anyway.
299
36372bf9
PE
300 * alloc.c: Remove unportable assumptions about struct layout.
301 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
302 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
303 (allocate_vectorlike, make_pure_vector): Use the new macros,
304 plus offsetof, to remove unportable assumptions about struct layout.
305 These assumptions hold on all porting targets that I know of, but
306 they are not guaranteed, they're easy to remove, and removing them
307 makes further changes easier.
308
0b432f21
PE
309 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
310 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
311 (string_overrun_cookie): Now const. Use initializers that
312 don't formally overflow signed char, to avoid warnings.
000098c1
PE
313 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
314 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
315 (allocate_buffer): Don't assume sizeof (struct buffer) is a
316 multiple of sizeof (EMACS_INT); it need not be, if
317 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 318 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 319
895009e1
JB
3202011-04-26 Juanma Barranquero <lekktu@gmail.com>
321
322 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
323
6a7a1b0b
TZ
3242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
325
326 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 327 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
328 Reported by Paul Eggert <eggert@cs.ucla.edu>.
329
841a1577 3302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
331
332 * lisp.h (Qdebug): List symbol.
895009e1 333 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
334 * keyboard.c (debug-on-event): New variable.
335 (handle_user_signal): Break into debugger when debug-on-event
336 matches the current signal symbol.
337
f2d3ba6f
DN
3382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
339
340 * alloc.c (check_sblock, check_string_bytes)
341 (check_string_free_list): Convert to standard C.
342
42ce4c63
TZ
3432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
344
345 * w32.c (emacs_gnutls_push): Fix typo.
346
825cd63c
EZ
3472011-04-25 Eli Zaretskii <eliz@gnu.org>
348
fb11d64d
EZ
349 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
350 "cast to pointer from integer of different size".
351
825cd63c
EZ
352 Improve doprnt and its use in verror. (Bug#8545)
353 * doprnt.c (doprnt): Document the set of format control sequences
354 supported by the function. Use SAFE_ALLOCA instead of always
355 using `alloca'.
356
357 * eval.c (verror): Don't limit the buffer size at size_max-1, that
358 is one byte too soon. Don't use xrealloc; instead xfree and
359 xmalloc anew.
360
e061a11b
TZ
3612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
362
363 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
364 callbacks stage.
365
366 * gnutls.c: Renamed global_initialized to
367 gnutls_global_initialized. Added internals for the
368 :verify-hostname-error, :verify-error, and :verify-flags
369 parameters of `gnutls-boot' and documented those parameters in the
370 docstring. Start callback support.
371 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
372 unless a fatal error occured. Call gnutls_alert_send_appropriate
373 on error. Return error code.
374 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
375 (emacs_gnutls_read): Likewise.
376 (Fgnutls_boot): Return handshake error code.
377 (emacs_gnutls_handle_error): New function.
378 (wsaerror_to_errno): Likewise.
379
380 * w32.h (emacs_gnutls_pull): Add prototype.
381 (emacs_gnutls_push): Likewise.
382
383 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
384 (emacs_gnutls_push): Likewise.
385
3862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
387
388 * process.c (wait_reading_process_output): Check if GnuTLS
389 buffered some data internally if no FDs are set for TLS
390 connections.
391
392 * makefile.w32-in (OBJ2): Add gnutls.$(O).
393 (LIBS): Link to USER_LIBS.
394 ($(BLD)/gnutls.$(0)): New target.
395
fa6996bc
EZ
3962011-04-24 Eli Zaretskii <eliz@gnu.org>
397
eb35682e
EZ
398 * xdisp.c (handle_single_display_spec): Rename the
399 display_replaced_before_p argument into display_replaced_p, to
400 make it consistent with the commentary. Fix typos in the
401 commentary.
402
e2ad650c
EZ
403 * textprop.c (syms_of_textprop): Remove dead code.
404 (copy_text_properties): Delete obsolete commentary about an
405 interface that was deleted long ago. Fix typos in the description
406 of arguments.
407
1b2de274
EZ
408 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
409 to changes in oldXMenu/XMenu.h from 2011-04-16.
410 <menu_help_message, prev_menu_help_message>: Constify.
411 (IT_menu_make_room): menu->help_text is now `const char **';
412 adjust.
413
414 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
415 to changes in oldXMenu/XMenu.h from 2011-04-16.
416 (struct XMenu): Declare `help_text' `const char **'.
417
418 * xfaces.c <Qunspecified>: Make extern again.
419
420 * syntax.c: Include sys/types.h before including regex.h, as
421 required by Posix.
422
762b15be
EZ
423 * doc.c (get_doc_string): Improve the format passed to `error'.
424
425 * doprnt.c (doprnt): Improve commentary.
426
427 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
428
429 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
430 them with etags.
431
f1052e5d
EZ
432 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
433 changes in globals.h immediately force recompilation.
762b15be
EZ
434 (TAGS): Depend on $(CURDIR)/m/intel386.h and
435 $(CURDIR)/s/ms-w32.h.
436 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 437
fa6996bc
EZ
438 * character.c (Fchar_direction): Function deleted.
439 (syms_of_character): Don't defsubr it.
440 <char-direction-table>: Deleted.
441
e6c3da20
EZ
4422011-04-23 Eli Zaretskii <eliz@gnu.org>
443
444 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
445 * doprnt.c: Include limits.h.
446 (SIZE_MAX): New macro.
447 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
448 local variables are now size_t instead of int or unsigned.
449 Improve overflow protection. Support `l' modifier for integer
450 conversions. Support %l conversion. Don't assume an EMACS_INT
451 argument for integer conversions and for %c.
452
453 * lisp.h (doprnt): Restore prototype.
454
455 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
456 $(SRC)/character.h.
457
458 * Makefile.in (base_obj): Add back doprnt.o.
459
460 * deps.mk (doprnt.o): Add back prerequisites.
461 (callint.o): Depend on character.h.
462
463 * eval.c (internal_lisp_condition_case): Include the handler
464 representation in the error message.
465 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
466 when breaking from the loop.
467
468 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
469
470 * callint.c (Fcall_interactively): When displaying error message
471 about invalid control letter, pass the character's codepoint, not
472 a pointer to its multibyte form. Improve display of the character
473 in octal and display also its hex code.
474
475 * character.c (char_string): Use %x to display the (unsigned)
476 codepoint of an invalid character, to avoid displaying a bogus
477 negative value.
478
479 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
480 `error', not SYMBOL_NAME itself.
481
482 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
483 character arguments to `error'.
484
485 * charset.c (check_iso_charset_parameter): Fix incorrect argument
486 to `error' in error message about FINAL_CHAR argument. Make sure
487 FINAL_CHAR is a character, and use %c when it is passed as
488 argument to `error'.
489
4ffd0d6b 4902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
491
492 * s/ms-w32.h (localtime): Redirect to sys_localtime.
493
494 * w32.c: Include <time.h>.
495 (sys_localtime): New function.
496
4ffd0d6b 4972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
498
499 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
500
4ffd0d6b 501 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 502
4ffd0d6b 5032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 504
4ffd0d6b
GM
505 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
506 zombies (Bug#8467).
aac0c6e3 507
04c56954
EZ
5082011-04-19 Eli Zaretskii <eliz@gnu.org>
509
510 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
511 gl_state.e_property when gl_state.object is Qt.
512
513 * insdel.c (make_gap_larger): Remove limitation of buffer size
514 to <= INT_MAX.
515
16a43933
CY
5162011-04-18 Chong Yidong <cyd@stupidchicken.com>
517
518 * xdisp.c (lookup_glyphless_char_display)
519 (produce_glyphless_glyph): Handle cons cell entry in
520 glyphless-char-display.
521 (Vglyphless_char_display): Document it.
522
523 * term.c (produce_glyphless_glyph): Handle cons cell entry in
524 glyphless-char-display.
525
4581706e
CY
5262011-04-17 Chong Yidong <cyd@stupidchicken.com>
527
528 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
529
530 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
531
532 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
533 definition for no-X builds.
534
4887c6e2 5352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 536
fd35b6f9
PE
537 Static checks with GCC 4.6.0 and non-default toolkits.
538
5c1ccb01
PE
539 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
540
006c5daa
PE
541 * process.c (keyboard_bit_set): Define only if SIGIO.
542 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
543 (send_process): Repair possible setjmp clobbering.
544
efc736d3
PE
545 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
546
4e2fe2e6
PE
547 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
548
f97334a2
PE
549 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
550
4e75f29d
PE
551 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
552 Define only if needed.
553
90efadd1
PE
554 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
555 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 556 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 557
3c647824
PE
558 * dispextern.h (struct redisplay_interface): Rename param
559 to avoid shadowing.
e264f262 560 * termhooks.h (struct terminal): Likewise.
761383f4 561 * xterm.c (xembed_send_message): Likewise.
3c647824 562
b58c5c4a
PE
563 * insdel.c (make_gap_smaller): Define only if
564 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
565
cad59032
PE
566 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
567 it.
568
c339dc2e
PE
569 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
570 so that we aren't warned about unused symbols.
571
91a3e27b
PE
572 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
573
399c71d3 574 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 575
8ffc96f5
PE
576 * xfns.c (x_real_positions): Mark locals as initialized.
577
eef9bc79
PE
578 * xmenu.c (xmenu_show): Don't use uninitialized vars.
579
098db9dd
PE
580 * xterm.c: Fix problems found by static analysis with other toolkits.
581 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
582 (x_dispatch_event): Declare static if USE_GTK, and
583 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 584 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 585 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
586 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
587 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 588
eb18f6cc
PE
589 * xmenu.c (menu_help_callback): Pointer type fixes.
590 Use const pointers when pointing at readonly data. Avoid pointer
591 signedness clashes.
592 (FALSE): Remove unused macro.
593 (update_frame_menubar): Remove unused decl.
594
1fe72bf8
PE
595 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
596
60d9e1db
PE
597 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
598 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
599 (single_menu_item): Rename local to avoid shadowing.
600
39261c26
PE
601 * keyboard.c (make_lispy_event): Remove unused local var.
602
018c5e19
PE
603 * frame.c, frame.h (x_get_resource_string): Bring this back, but
604 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
605
63d2b86e
PE
606 * bitmaps: Change bitmaps from unsigned char back to the X11
607 compatible char. Avoid the old compiler warnings about
608 out-of-range initializers by using, for example, '\xab' rather
609 than 0xab.
610
aefd87e1
PE
611 * xgselect.c (xgselect_initialize): Check vs interface
612 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
613
bf501fb9
PE
614 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
615
e9829fdf
PE
616 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
617 to read-only memory.
618
1086c095
PE
619 * fns.c (vector): Remove; this old hack is no longer needed.
620
2baccd04 621 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 622 Remove unused var.
dde42981 623 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 624
72391843 625 * xrdb.c (x_load_resources): Omit unused local.
3565b346 626
436c16df 627 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 628 (x_window): Rename locals to avoid shadowing.
dc5ddd85 629 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 630
92bb796d 631 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 632 (x_term_init): Remove local to avoid shadowing.
92bb796d 633
764430a3 634 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
635
636 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
637 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
638
d1dfb56c
EZ
6392011-04-16 Eli Zaretskii <eliz@gnu.org>
640
c4354cb4
EZ
641 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
642
d1dfb56c
EZ
643 Fix regex.c, syntax.c and friends for buffers > 2GB.
644 * syntax.h (struct gl_state_s): Declare character position members
645 EMACS_INT.
646
647 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
648
649 * textprop.c (verify_interval_modification, interval_of): Declare
650 arguments EMACS_INT.
651
652 * intervals.c (adjust_intervals_for_insertion): Declare arguments
653 EMACS_INT.
654
655 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
656
657 * indent.c (Fvertical_motion): Local variable it_start is now
658 EMACS_INT.
659
660 * regex.c (re_match, re_match_2, re_match_2_internal)
661 (bcmp_translate, regcomp, regexec, print_double_string)
662 (group_in_compile_stack, re_search, re_search_2, regex_compile)
663 (re_compile_pattern, re_exec): Declare arguments and local
664 variables `size_t' and `ssize_t' and return values `regoff_t', as
665 appropriate.
666 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
667 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
668 <compile_stack_type>: `size' and `avail' are now `size_t'.
669
670 * regex.h <regoff_t>: Use ssize_t, not int.
671 (re_search, re_search_2, re_match, re_match_2): Arguments that
672 specify buffer/string position and length are now ssize_t and
673 size_t. Return type is regoff_t.
674
613052cd
BK
6752011-04-16 Ben Key <bkey76@gmail.com>
676
677 * nsfont.m: Fixed bugs in ns_get_family and
678 ns_descriptor_to_entity that were caused by using free to
679 deallocate memory blocks that were allocated by xmalloc (via
680 xstrdup). This caused Emacs to crash when compiled with
681 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
682 --enable-checking=xmallocoverrun). xfree is now used to
683 deallocate these memory blocks.
684
4170f62f 6852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 686
71b41406
PE
687 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
688
9587a89d
PE
689 emacs_write: Accept and return EMACS_INT for sizes.
690 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
691 et seq.
692 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
693 Accept and return EMACS_INT.
694 (emacs_gnutls_write): Return the number of bytes written on
695 partial writes.
696 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
697 (emacs_read, emacs_write): Remove check for negative size, as the
698 Emacs source code has been audited now.
9587a89d
PE
699 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
700 (emacs_read, emacs_write): Use it.
273a5f82
PE
701 * process.c (send_process): Adjust to the new signatures of
702 emacs_write and emacs_gnutls_write. Do not attempt to store
703 a byte offset into an 'int'; it might overflow.
9587a89d 704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 705
3e047f51
PE
706 * sound.c: Don't assume sizes fit in 'int'.
707 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 708 Return EMACS_INT, not int.
3e047f51 709 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
710 Accept EMACS_INT, not int.
711 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
712 record read return values.
713
cc39a9db
BK
7142011-04-15 Ben Key <bkey76@gmail.com>
715
c9d0ec6d
JB
716 * keyboard.c (Qundefined): Don't declare static since it is used
717 in nsfns.m.
718 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
719 static since they are used in nsfont.m.
cc39a9db 720
6c60eb9f
SM
7212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * process.c (Qprocessp): Don't declare static.
724 * lisp.h (Qprocessp): Declare again.
725
7990b61a
JB
7262011-04-15 Juanma Barranquero <lekktu@gmail.com>
727
728 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
729
5d4cb038
PE
7302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
731
8bd7b830 732 Improve C-level modularity by making more things 'static'.
cd64ea1d 733
e3b27b31
PE
734 Don't publish debugger-only interfaces to other modules.
735 * lisp.h (safe_debug_print, debug_output_compilation_hack):
736 (verify_bytepos, count_markers): Move decls to the only modules
737 that need them.
738 * region-cache.h (pp_cache): Likewise.
739 * window.h (check_all_windows): Likewise.
740 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
741
5d4cb038
PE
742 * sysdep.c (croak): Now static, if
743 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
744 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
745
746 * alloc.c (refill_memory_reserve): Now static if
747 !defined REL_ALLOC || defined SYSTEM_MALLOC.
748 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 749
e87b6180
PE
750 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
751 Define only if USE_LUCID.
752
ac64929e
PE
753 * xrdb.c (x_customization_string, x_rm_string): Now static.
754
6f37259d
PE
755 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
756 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
757
1683e3ab
PE
758 * xdisp.c (draw_row_with_mouse_face): Now static.
759 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
760
de9c2632
PE
761 * window.h (check_all_windows): Mark externally visible.
762
2b96acb7
PE
763 * window.c (window_deletion_count): Now static.
764
765 * undo.c: Make symbols static if they're not exported.
766 (last_undo_buffer, last_boundary_position, pending_boundary):
767 Now static.
768
50436f33
PE
769 * textprop.c (interval_insert_behind_hooks): Now static.
770 (interval_insert_in_front_hooks): Likewise.
771
64520e5c
PE
772 * term.c: Make symbols static if they're not exported.
773 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
774 (max_frame_lines, tty_set_terminal_modes):
775 (tty_reset_terminal_modes, tty_turn_off_highlight):
776 (get_tty_terminal): Now static.
777 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
778 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 779 HAVE_WINDOW_SYSTEM.
64520e5c
PE
780 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
781 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
782
1fa53021
PE
783 * sysdep.c: Make symbols static if they're not exported.
784 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
785 Now static.
786 (sigprocmask_set, full_mask): Remove; unused.
787 (wait_debugging): Mark as visible.
788 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
789 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
790
d4b43b22
PE
791 * syntax.c (syntax_temp): Define only if !__GNUC__.
792
b7c513d0
PE
793 * sound.c (current_sound_device, current_sound): Now static.
794
989b29ad
PE
795 * search.c (searchbufs, searchbuf_head): Now static.
796
13a55a78
PE
797 * scroll.c (scroll_cost): Remove; unused.
798 * dispextern.h (scroll_cost): Remove decl.
799
de68a1fc
PE
800 * region-cache.h (pp_cache): Mark as externally visible.
801
40ccffa6
PE
802 * process.c: Make symbols static if they're not exported.
803 (process_tick, update_tick, create_process, chan_process):
804 (Vprocess_alist, proc_buffered_char, datagram_access):
805 (fd_callback_data, send_process_frame, process_sent_to): Now static.
806 (deactivate_process): Mark defn as static, as well as decl.
807 * lisp.h (create_process): Remove decl.
808 * process.h (chan_process, Vprocess_alist): Remove decls.
809
ad64fc97
PE
810 * print.c: Make symbols static if they're not exported.
811 (print_depth, new_backquote_output, being_printed, print_buffer):
812 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
813 (print_interval, print_number_index, initial_stderr_stream):
814 Now static.
815 * lisp.h (Fprinc): Remove decl.
816 (debug_output_compilation_hack): Mark as externally visible.
817
adddb265
PE
818 * sysdep.c (croak): Move decl from here to syssignal.h.
819 * syssignal.h (croak): Put it here, so the API can be checked when
820 'croak' is called from dissociate_if_controlling_tty.
821
1717ede2
PE
822 * minibuf.c: Make symbols static if they're not exported.
823 (minibuf_save_list, choose_minibuf_frame): Now static.
824 * lisp.h (choose_minibuf_frame): Remove decl.
825
fa5fb2bc
PE
826 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
827
1e3890d1
PE
828 * lread.c: Make symbols static if they're not exported.
829 (read_objects, initial_obarray, oblookup_last_bucket_number):
830 Now static.
831 (make_symbol): Remove; unused.
832 * lisp.h (initial_obarray, make_symbol): Remove decls.
833
8a1414fa
PE
834 * keyboard.c: Make symbols static if they're not exported.
835 (single_kboard, recent_keys_index, total_keys, recent_keys):
836 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
837 (this_single_command_key_start, echoing, last_auto_save):
838 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
839 (command_loop, echo_now, keyboard_init_hook, help_char_p):
840 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
841 (Vlispy_mouse_stem, double_click_count):
842 Now static.
843 (force_auto_save_soon): Define only if SIGDANGER.
844 (ignore_mouse_drag_p): Now static if
845 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
846 (print_help): Remove; unused.
847 (stop_character, last_timer_event): Mark as externally visible.
848 * keyboard.h (ignore_mouse_drag_p): Declare only if
849 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
850 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
851 * lisp.h (echoing): Remove decl.
852 (force_auto_save_soon): Declare only if SIGDANGER.
853 * xdisp.c (redisplay_window): Simplify code, to make it more
854 obvious that ignore_mouse_drag_p is not accessed if !defined
855 USE_GTK && !defined HAVE_NS.
856
93ea6e8f
PE
857 * intervals.c: Make symbols static if they're not exported.
858 (merge_properties_sticky, merge_interval_right, delete_interval):
859 Now static.
860 * intervals.h (merge_interval_right, delete_interval): Remove decls.
861
77382fcc
PE
862 * insdel.c: Make symbols static if they're not exported.
863 However, leave prepare_to_modify_buffer alone. It's never
864 called from outside this function, but that appears to be a bug.
865 (combine_after_change_list, combine_after_change_buffer):
4889fc82 866 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
867 (adjust_after_replace_noundo): Remove; unused.
868 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 869 (signal_before_change): Remove decls.
77382fcc 870
9306c32e
PE
871 * indent.c (val_compute_motion, val_vmotion): Now static.
872
cd44d2eb
PE
873 * image.c: Make symbols static if they're not exported.
874 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
875 if USE_GTK.
876 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
877 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
878
ad9a7a06
PE
879 * fringe.c (standard_bitmaps): Now static.
880 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
881
81626931
PE
882 * frame.c: Make symbols static if they're not exported.
883 (x_report_frame_params, make_terminal_frame): Now static.
884 (get_frame_param): Now static, unless HAVE_NS.
885 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
886 (x_get_resource_string): Remove; not used.
887 * frame.h (make_terminal_frame, x_report_frame_params):
888 (x_get_resource_string); Remove decls.
889 (x_fullscreen_adjust): Declare only if WINDOWSNT.
890 * lisp.h (get_frame_param): Declare only if HAVE_NS.
891
239f9db9
PE
892 * font.c, fontset.c: Make symbols static if they're not exported.
893 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
894 (FACE_SUITABLE_FOR_CHAR_P): Use it.
895 * font.c (font_close_object): Now static.
896 * font.h (font_close_object): Remove.
897 * fontset.c (FONTSET_OBJLIST): Remove.
898 (free_realized_fontset) #if-0 the body, which does nothing.
899 (face_suitable_for_char_p): #if-0, as it's never called.
900 * fontset.h (face_suitable_for_char_p): Remove decl.
901 * xfaces.c (face_at_string_position): Use
902 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
903 since 0 is always ASCII.
904
dfcf3579
PE
905 * fns.c (weak_hash_tables): Now static.
906
5045092b
PE
907 * fileio.c: Make symbols static if they're not exported.
908 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
909 (Vwrite_region_annotation_buffers): Now static.
910
57a96f5c
PE
911 * eval.c: Make symbols static if they're not exported.
912 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
913 * lisp.h (backtrace_list): Remove decl.
914
35f08c38
PE
915 * emacs.c: Make symbols static if they're not exported.
916 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
917 (fatal_error_code, fatal_error_signal_hook, standard_args):
918 Now static.
919 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
920 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
921 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
922 * lisp.h (fatal_error_signal_hook): Remove decl.
923 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
924
f44bd759
PE
925 * editfns.c: Move a (normally-unused) function to its only use.
926 * editfns.c, lisp.h (get_operating_system_release): Remove.
927 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
928 worth the hassle of breaking this out.
929
b532497d
PE
930 * xterm.c: Make symbols static if they're not exported.
931 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
932 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
933 (x_destroy_window, x_delete_display):
934 Now static.
935 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
936 (x_mouse_leave): Remove; unused.
937 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
938 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
939 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
940 Remove decls.
941 (x_mouse_leave): Declare only if WINDOWSNT.
942 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
943 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
944 USE_X_TOOLKIT.
945
1675728f
PE
946 * ftxfont.c: Make symbols static if they're not exported.
947 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
948 HAVE_FREETYPE.
949 * font.h (ftxfont_driver): Likewise.
950
e4cebfca
PE
951 * xfns.c: Make symbols static if they're not exported.
952 (x_last_font_name, x_display_info_for_name):
953 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
954 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
955 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
956 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
957 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
958 (last_show_tip_args): Now static.
959 (xic_defaut_fontset, xic_create_fontsetname): Define only if
960 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
961 (x_screen_planes): Remove; unused.
962 * dispextern.h (x_screen_planes): Remove decl.
963
5bf46f05
PE
964 * dispnew.c: Make symbols static if they're not exported.
965 * dispextern.h (redraw_garbaged_frames, scrolling):
966 (increment_row_positions): Remove.
967 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
968 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
969 Now static.
970 (redraw_garbaged_frames): Remove; unused.
971
435f4c28
PE
972 * xfaces.c: Make symbols static if they're not exported.
973 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
974 Remove decls.
975 * xterm.h (defined_color): Remove decls.
976 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
977 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
978 (menu_face_changed_default, defined_color, free_realized_face):
979 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
980 (ascii_face_of_lisp_face): Remove; unused.
981
8524aef3
PE
982 * xdisp.c: Make symbols static if they're not exported.
983 * dispextern.h (scratch_glyph_row, window_box_edges):
984 (glyph_to_pixel_coords, set_cursor_from_row):
985 (get_next_display_element, set_iterator_to_next):
986 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
987 (show_mouse_face): Remove decls
988 * frame.h (message_buf_print): Likewise.
989 * lisp.h (pop_message, set_message, check_point_in_composition):
990 Likewise.
991 * xterm.h (set_vertical_scroll_bar): Likewise.
992 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
993 (message_buf_print, scratch_glyph_row, displayed_buffer):
994 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
995 (get_next_display_element, show_mouse_face, window_box_edges):
996 (frame_to_window_pixel_xy, check_point_in_composition):
997 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
998 (glyph_to_pixel_coords): Remove; unused.
999
16390cd2
PE
1000 * dired.c (file_name_completion): Now static.
1001
1002 * dbusbind.c (xd_in_read_queued_messages): Now static.
1003
a25f4dfa
PE
1004 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1005 * data.c (circular_list_error): Remove.
1006
14a9c8df
PE
1007 * commands.h (last_point_position, last_point_position_buffer):
1008 (last_point_position_window): Remove decls.
1009 * keyboard.c: Make these variables static.
1010
74ab6df5
PE
1011 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1012 decls.
1013 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1014 (iso_code_class, detect_coding, code_convert_region): Now static.
1015 (encode_coding_gap): Remove; unused.
1016
38dfbee1
PE
1017 * chartab.c (chartab_chars, chartab_bits): Now static.
1018
a2cb4e63
PE
1019 * charset.h (charset_iso_8859_1): Remove decl.
1020 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1021 Now static.
1022
127198fd
PE
1023 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1024 * ccl.c (Vccl_program_table): Now static.
1025 (check_ccl_update): Remove; unused.
1026
d85b608f
PE
1027 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1028 * category.h: ... from here.
1029 * category.c (check_category_table, set_category_set): Now static.
1030
31cd66f3
PE
1031 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1032 * lisp.h: Remove these decls.
1033
c358e587
PE
1034 * buffer.c (buffer_count): Remove unused var.
1035
e78aecca
PE
1036 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1037 so that it's not optimized away.
1038 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1039 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1040 exported only to the debugger.
1041
e192d7d3
PE
1042 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1043 * atimer.h (run_all_atimers): Removed; not exported.
1044
92470028
PE
1045 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1046 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1047 was inaccessible from Lisp.
1048 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1049 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1050
244ed907
PE
1051 alloc.c: Import and export fewer symbols, and remove unused items.
1052 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1053 is defined.
1054 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1055 it's not optimized away by whole-program optimization.
1056 (message_enable_multibyte, free_misc): Remove.
1057 (catchlist, handlerlist, mark_backtrace):
1058 Declare only if BYTE_MARK_STACK.
1059 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1060 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1061 (message_enable_multibyte): Remove decl.
1062 (free_misc, interval_free_list, float_block, float_block_index):
1063 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1064 (cons_free_list, last_marked_index):
1065 Now static.
1066 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1067 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1068 (mark_backtrace): Define only if BYTE_MARK_STACK.
1069 * xdisp.c (message_enable_multibyte): Now static.
1070
61c2b50e 1071 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1072 This makes it easier for human readers (and static analyzers)
1073 to see whether these variables are used from other modules.
1074 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1075 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1076 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1077 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1078 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1079 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1080 * xmenu.c, xselect.c:
1081 Declare Q* vars static if they are not used in other modules.
1082 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1083 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1084 Remove decls of unexported vars.
1085 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1086
95c82688
PE
1087 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1088
16a97296
PE
1089 Make Emacs functions such as Fatom 'static' by default.
1090 This makes it easier for human readers (and static analyzers)
1091 to see whether these functions can be called from other modules.
1092 DEFUN now defines a static function. To make the function external
1093 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1094 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1095 (Finit_image_library):
16a97296
PE
1096 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1097 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1098 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1099 Remove decls, since these functions are now static.
1100 (Funintern, Fget_internal_run_time): New decls, since these functions
1101 were already external.
95c82688 1102
16a97296
PE
1103 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1104 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1105 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1106 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1107 * keyboard.c, keymap.c, lread.c:
1108 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1109 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1110 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1111 Mark functions with DEFUE instead of DEFUN,
1112 if they are used in other modules.
1113 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1114 decls for now-static functions.
1115 * buffer.h (Fdelete_overlay): Remove decl.
1116 * callproc.c (Fgetenv_internal): Mark as internal.
1117 * composite.c (Fremove_list_of_text_properties): Remove decl.
1118 (Fcomposition_get_gstring): New forward static decl.
1119 * composite.h (Fcomposite_get_gstring): Remove decl.
1120 * dired.c (Ffile_attributes): New forward static decl.
1121 * doc.c (Fdocumntation_property): New forward static decl.
1122 * eval.c (Ffetch_bytecode): New forward static decl.
1123 (Funintern): Remove extern decl; now in .h file where it belongs.
1124 * fileio.c (Fmake_symbolic_link): New forward static decl.
1125 * image.c (Finit_image_library): New forward static decl.
1126 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1127 * intervals.h (Fprevious_property_change):
1128 (Fremove_list_of_text_properties): Remove decls.
1129 * keyboard.c (Fthis_command_keys): Remove decl.
1130 (Fcommand_execute): New forward static decl.
1131 * keymap.c (Flookup_key): New forward static decl.
1132 (Fcopy_keymap): Now static.
1133 * keymap.h (Flookup_key): Remove decl.
1134 * process.c (Fget_process): New forward static decl.
1135 (Fprocess_datagram_address): Mark as internal.
1136 * syntax.c (Fsyntax_table_p): New forward static decl.
1137 (skip_chars): Remove duplicate decl.
1138 * textprop.c (Fprevious_property_change): New forward static decl.
1139 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1140 Now internal.
1141 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1142 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1143
785bbd42
PE
1144 * editfns.c (Fformat): Remove unreachable code.
1145
8b913b57
AS
11462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1147
1148 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1149 change. (Bug#8496)
1150
a6744a35
EZ
11512011-04-13 Eli Zaretskii <eliz@gnu.org>
1152
1153 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1154 when at ZV. (Bug#8487)
1155
e7974947
AS
11562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1157
baad03f0
AS
1158 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1159 (Bug#8437)
1160 * keyboard.c (parse_tool_bar_item): Likewise.
1161 * sound.c (sound_cleanup, alsa_close): Likewise.
1162 * termcap.c (tgetent): Likewise.
1163 * xfns.c (x_default_font_parameter): Likewise.
1164 * xsettings.c (read_and_apply_settings): Likewise.
1165
e7974947
AS
1166 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1167 (overrun_check_free): Protoize.
1168
28272684
PE
11692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1172 since callers should never pass a negative size.
1173 Change the signature to match that of plain 'read' and 'write'; see
1174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1175 * lisp.h: Update prototypes of emacs_write and emacs_read.
1176
11997c76
EZ
11772011-04-11 Eli Zaretskii <eliz@gnu.org>
1178
1179 * xdisp.c (redisplay_window): Don't try to determine the character
1180 position of the scroll margin if the window start point w->startp
e896f03c 1181 is outside the buffer's accessible region. (Bug#8468)
11997c76 1182
8a2cbd72
EZ
11832011-04-10 Eli Zaretskii <eliz@gnu.org>
1184
1185 Fix write-region and its subroutines for buffers > 2GB.
1186 * fileio.c (a_write, e_write): Modify declaration of arguments and
1187 local variables to support buffers larger than 2GB.
1188 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1189
1190 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1191 argument, local variables, and return value.
1192
1193 * lisp.h: Update prototypes of emacs_write and emacs_read.
1194
1195 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1196
4073e537 11972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1198
1ebfdcb6
PE
1199 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1200
b2ded58d
PE
1201 Fix more problems found by GCC 4.6.0's static checks.
1202
7d66342c
PE
1203 * xdisp.c (vmessage): Use a better test for character truncation.
1204
bbf47d44
PE
1205 * charset.c (load_charset_map): <, not <=, for optimization,
1206 and to avoid potential problems with integer overflow.
9248994d 1207 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1208 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1209 * editfns.c (Fformat): Likewise.
1e69125e 1210 * syntax.c (skip_chars): Likewise.
3befa583 1211
e3019616
PE
1212 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1213 This also lets GCC 4.6.0 generate slightly better loop code.
1214
becfa255
PE
1215 * callint.c (Fcall_interactively): <, not <=, for optimization.
1216 (Fcall_interactively): Count the number of arguments produced,
1217 not the number of arguments given. This is simpler and lets GCC
1218 4.6.0 generate slightly better code.
1219
dae0cd48
PE
1220 * ftfont.c: Distingish more carefully between FcChar8 and char.
1221 The previous code passed unsigned char * to a functions like
1222 strlen and xstrcasecmp that expect char *, which does not
1223 conform to the C standard.
1224 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1225 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1226 char * when the C standard requires it.
1227
76032d70
PE
1228 * keyboard.c (read_char): Remove unused var.
1229
eb3f1cc8
PE
1230 * eval.c: Port to Windows vsnprintf (Bug#8435).
1231 Include <limits.h>.
1232 (SIZE_MAX): Define if the headers do not.
1233 (verror): Do not give up if vsnprintf returns a negative count.
1234 Instead, grow the buffer. This ports to Windows vsnprintf, which
1235 does not conform to C99. Problem reported by Eli Zaretskii.
1236 Also, simplify the allocation scheme, by avoiding the need for
1237 calling realloc, and removing the ALLOCATED variable.
1238
70476b54
PE
1239 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1240
12020a9e
PE
1241 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1242 But keep the doprint source code for now, as we might revamp it
1243 and use it again (Bug#8435).
ea6c7ae6
PE
1244 * lisp.h (doprnt): Remove.
1245 * Makefile.in (base_obj): Remove doprnt.o.
1246 * deps.mk (doprnt.o): Remove.
1247
5fdb398c
PE
1248 error: Print 32- and 64-bit integers portably (Bug#8435).
1249 Without this change, on typical 64-bit hosts error ("...%d...", N)
1250 was used to print both 32- and 64-bit integers N, which relied on
1251 undefined behavior.
1252 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1253 New macro.
1254 * lisp.h (error, verror): Mark as printf-like functions.
1255 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1256 Report overflow in size calculations when allocating printf buffer.
1257 Do not truncate output string at its first null byte.
1258 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1259 Truncate the output at a character boundary, since vsnprintf does not
1260 do that.
1261 * charset.c (check_iso_charset_parameter): Convert internal
1262 character to string before calling 'error', since %c now has the
1263 printf meaning.
1264 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1265 overflow when computing char to be passed to 'error'. Do not
1266 pass Lisp_Object to 'error'; pass the integer instead.
1267 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1268 formatted with plain %d.
1269
b189fa66
PE
1270 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1271
bff87ef0
PE
1272 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1273
7e2cac20
PE
1274 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1275
ce4d90b5
PE
1276 * xterm.c (x_catch_errors): Remove duplicate declaration.
1277
266c9547
PE
1278 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1279
79c49ad2
PE
1280 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1281
368f4090
JM
12822011-04-10 Jim Meyering <meyering@redhat.com>
1283
1284 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1285 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1286 return ssize_t not "int", and use size_t as the buffer length.
1287 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1288 * gnutls.h: Update declarations.
1289 * process.c (read_process_output): Use ssize_t, to match.
1290 (send_process): Likewise.
1291
a32d4040
CY
12922011-04-09 Chong Yidong <cyd@stupidchicken.com>
1293
1294 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1295
8546720e 12962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1297
8546720e
GM
1298 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1299 unsigned char, to match FcChar8 type definition.
aac0c6e3 1300
8546720e
GM
1301 * xterm.c (handle_one_xevent):
1302 * xmenu.c (create_and_show_popup_menu):
1303 * xselect.c (x_decline_selection_request)
1304 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1305
0a2f5c1a 13062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1307
1308 Fix some uses of `int' instead of EMACS_INT.
1309 * search.c (string_match_1, fast_string_match)
1310 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1311 (scan_buffer, find_next_newline_no_quit)
1312 (find_before_next_newline, search_command, Freplace_match)
1313 (Fmatch_data): Make some `int' variables be EMACS_INT.
1314
1315 * xdisp.c (display_count_lines): 3rd argument and return value now
1316 EMACS_INT. All callers changed.
1317 (pint2hrstr): Last argument is now EMACS_INT.
1318
1319 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1320 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1321 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1322 (decode_coding_utf_16, decode_coding_emacs_mule)
1323 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1324 (decode_coding_ccl, decode_coding_charset)
1325 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1326 (decode_coding_iso_2022, decode_coding_emacs_mule)
1327 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1328 <char_offset, last_offset>: Declare EMACS_INT.
1329 (encode_coding_utf_8, encode_coding_utf_16)
1330 (encode_coding_emacs_mule, encode_invocation_designation)
1331 (encode_designation_at_bol, encode_coding_iso_2022)
1332 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1333 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1334 Declare EMACS_INT.
1335 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1336 (encode_invocation_designation): Last argument P_NCHARS is now
1337 EMACS_INT.
1338 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1339 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1340
1341 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1342 All users changed.
1343
1344 * ccl.c (Fccl_execute_on_string): Declare some variables
1345 EMACS_INT.
1346
8546720e 13472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1348
1349 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1350
4e19a977
CS
13512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1352
1353 * process.c (Fformat_network_address): Doc fix.
1354
87302331
R
13552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1356
1357 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1358
cbb59342
CY
13592011-04-08 Chong Yidong <cyd@stupidchicken.com>
1360
1361 * keyboard.c (read_char): Call Lisp function help-form-show,
1362 instead of using internal_with_output_to_temp_buffer.
1363 (Qhelp_form_show): New var.
e0d38eeb 1364 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1365
1366 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1367
1368 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1369
e67a13ab
CY
13702011-04-06 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * process.c (Flist_processes): Removed to Lisp.
1373 (list_processes_1): Deleted.
1374
973f782d
EZ
13752011-04-06 Eli Zaretskii <eliz@gnu.org>
1376
7c106b1e
EZ
1377 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1378
973f782d
EZ
1379 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1380
41cf7d1a 13812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1382
ca23cc88
PE
1383 Fix more problems found by GCC 4.6.0's static checks.
1384
f390e2d5
PE
1385 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1386
42eea0d0
PE
1387 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1388
b69769da 1389 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1390
f9541e84
PE
1391 * xdisp.c (vmessage): Mark as a printf-like function.
1392
13841b55
PE
1393 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1394
c136c10f
PE
1395 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1396
5e2d4a30
PE
1397 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1398 printf-like functions.
1399 (tiff_load): Add casts to remove these marks before passing them
1400 to system-supplied API.
1401
583f48b9
PE
1402 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1403
b25d760e
PE
1404 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1405 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1406 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1407 directly, rather than having caller test rule sign. This avoids
1408 some unnecessary tests.
1409 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1410 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1411 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1412
bc7b6697 1413 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1414 (xfont_open): Avoid unnecessary tests.
bc7b6697 1415
27ccc379
PE
1416 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1417
dcd5c89a
PE
1418 * composite.h, composite.c (composition_gstring_put_cache):
1419 Use EMACS_INT, not int, for length.
1420
b13a45c6
PE
1421 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1422 breaking out part of COMPOSITION_DECODE_RULE.
1423 (COMPOSITION_DECODE_RULE): Use it.
1424 * composite.c (get_composition_id): Remove unused local vars,
1425 by using the new macro.
1426
1e792e4d
PE
1427 * textprop.c (set_text_properties_1): Change while to do-while,
1428 since the condition is always true at first.
1429
dc6c6455 1430 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1431 (interval_deletion_adjustment): Return unsigned value.
1432 All uses changed.
dc6c6455 1433
aba7731a
PE
1434 * process.c (list_processes_1, create_pty, read_process_output):
1435 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1436 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1437 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1438 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1439 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1440
fdfc4bf3
PE
1441 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1442
fca8fe46 1443 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1444 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1445
06a0259a 1446 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1447 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1448 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1449
e7b9e80f
PE
1450 * print.c (print_error_message): Avoid int overflow.
1451
56201685
PE
1452 * font.c (font_list_entities): Redo for clarity,
1453 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1454
78834453 1455 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1456 (font_score): Avoid potential overflow in diff calculation.
78834453 1457
0bc0b309 1458 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1459 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1460
e610eaca
PE
1461 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1462
b895abce
PE
1463 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1464 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1465 can always succeed if overflow has undefined behavior.
1466
1f1d9321 1467 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1468 (wordify): Omit three unnecessary tests.
1f1d9321 1469
c59478bc
PE
1470 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1471 All callers changed. This avoids the need for an unused var.
1472
79b73827
PE
1473 * casefiddle.c (casify_region): Remove var that is set but not used.
1474
a4db5dfe
PE
1475 * dired.c (file_name_completion): Remove var that is set but not used.
1476
43aae36e
PE
1477 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1478
2a47c44d 1479 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1480 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1481
a37c69bf
PE
1482 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1483 Check for integer overflow on size calculations.
1484
328ab8e7
PE
1485 * buffer.c (Fprevious_overlay_change): Remove var that is set
1486 but not used.
1487
e5a2a5cb
PE
1488 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1489 Remove vars that are set but not used.
8d84a6eb 1490 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1491 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1492
a60e5f68
PE
1493 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1494
f661cb61 1495 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1496 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1497
f0397f5a
PE
1498 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1499 that are set but not used.
1500
8664db06 1501 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1502 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1503
6abdaa4a
PE
1504 * xselect.c (x_get_local_selection, x_handle_property_notify):
1505 Remove vars that are set but not used.
1506
0ce7538d 1507 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1508 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1509
9ae848fc
PE
1510 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1511 Remove var that is set but not used.
0b918413
PE
1512 (scroll_bar_windows_size): Now size_t, not int.
1513 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1514 Check for overflow.
9ae848fc 1515
a5a62657
PE
1516 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1517 (map_tty_color) [!defined MSDOS]: Likewise.
1518
5c5cdd39
PE
1519 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1520
66ebf983
PE
1521 * coding.c: Remove vars that are set but not used.
1522 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1523 All callers changed.
1524 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1525 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1526 (decode_coding_charset): Remove vars that are set but not used.
1527
1be4d761
PE
1528 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1529 that is set but not used.
1530
47553fa8
PE
1531 * print.c (print_object): Remove var that is set but not used.
1532
1f7196bf 1533 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1534 The gnulib version avoids calling malloc in the usual case,
1535 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1536 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1537 * filelock.c (current_lock_owner): Likewise.
1538 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1539 * sysdep.c: Include allocator.h, careadlinkat.h.
1540 (emacs_no_realloc_allocator): New static constant.
1541 (emacs_readlink): New function.
fdb61804
PE
1542 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1543 ../lib/careadlinkat.h.
d1fdcab7 1544
f84c17c7
SM
15452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1546
1547 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1548 first non-nil return value).
1549
ef3862ad
JD
15502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1551
1552 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1553 if not defined (Bug#8403).
1554
376a7006
JB
15552011-04-02 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * xdisp.c (display_count_lines): Remove parameter `start',
1558 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1559 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1560 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1561 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1562 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1563 and thereabouts. All callers changed.
1564 (get_per_char_metric): Remove parameter `f', unused since
1565 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1566
6ca3801d
JM
15672011-04-02 Jim Meyering <meyering@redhat.com>
1568
1569 do not dereference NULL upon failed strdup
1570 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1571 (ns_get_family): Likewise.
1572
d8e2b5ba
JB
15732011-04-02 Juanma Barranquero <lekktu@gmail.com>
1574
1575 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1576
8c74fcbd
JD
15772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1578
1579 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1580 later (Bug#8403).
1581
7200d79c
SM
15822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1583
03408648 1584 Add lexical binding.
7200d79c 1585
03408648
SM
1586 * window.c (Ftemp_output_buffer_show): New fun.
1587 (Fsave_window_excursion):
1588 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1589
1590 * lread.c (lisp_file_lexically_bound_p): New function.
1591 (Fload): Bind Qlexical_binding.
1592 (readevalloop): Remove `evalfun' arg.
1593 Bind Qinternal_interpreter_environment.
1594 (Feval_buffer): Bind Qlexical_binding.
1595 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1596 Mark as dynamic.
1597 (syms_of_lread): Declare `lexical-binding'.
1598
1599 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1600
1601 * keyboard.c (eval_dyn): New fun.
1602 (menu_item_eval_property): Use it.
ca105506
SM
1603
1604 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1605
03408648
SM
1606 * fns.c (concat, mapcar1): Accept byte-code-functions.
1607
1608 * eval.c (Fsetq): Handle lexical vars.
1609 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1610 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1611 (FletX, Flet): Obey lexical binding.
1612 (Fcommandp): Handle closures.
1613 (Feval): New `lexical' arg.
1614 (eval_sub): New function extracted from Feval. Use it almost
1615 everywhere where Feval was used. Look up vars in lexical env.
1616 Handle closures.
1617 (Ffunctionp): Move from subr.el.
1618 (Ffuncall): Handle closures.
1619 (apply_lambda): Remove `eval_flags'.
1620 (funcall_lambda): Handle closures and new byte-code-functions.
1621 (Fspecial_variable_p): New function.
1622 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1623 but without exporting it to Lisp.
23aba0ea 1624
23aba0ea 1625 * doc.c (Fdocumentation, store_function_docstring):
03408648 1626 * data.c (Finteractive_form): Handle closures.
23aba0ea 1627
03408648
SM
1628 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1629 interactive spec.
ba83908c 1630
03408648
SM
1631 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1632 byte-codes.
1633 (exec_byte_code): New function extracted from Fbyte_code to handle new
1634 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1635
03408648 1636 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1637
03408648 1638 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1639
e2abce01
JB
16402011-03-31 Juanma Barranquero <lekktu@gmail.com>
1641
1642 * xdisp.c (redisplay_internal): Fix prototype.
1643
63696a73 16442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1645
63696a73
EZ
1646 * xdisp.c (SCROLL_LIMIT): New macro.
1647 (try_scrolling): Use it when setting scroll_limit. Limit
1648 scrolling to 100 screen lines.
1649 (redisplay_window): Even when falling back on "recentering",
1650 position point in the window according to scroll-conservatively,
1651 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1652
1653 (try_scrolling): When point is above the window, allow searching
1654 as far as scroll_max, or one screenful, to compute vertical
1655 distance from PT to the scroll margin position. This prevents
1656 try_scrolling from unnecessarily failing when
1657 scroll-conservatively is set to a value slightly larger than the
1658 window height. Clean up the case of PT below the margin at bottom
1659 of window: scroll_max can no longer be INT_MAX. When aggressive
1660 scrolling is in use, don't let point enter the opposite scroll
1661 margin as result of the scroll.
1662 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1663 threshold of 100 lines for never-recentering scrolling.
1664
e4cc2dfc
JB
16652011-03-31 Juanma Barranquero <lekktu@gmail.com>
1666
1667 * dispextern.h (move_it_by_lines):
1668 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1669 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1670 (message_log_check_duplicate): Remove parameters `prev_bol' and
1671 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1672 (redisplay_internal): Remove parameter `preserve_echo_area',
1673 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1674
1675 * indent.c (Fvertical_motion):
1676 * window.c (window_scroll_pixel_based, Frecenter):
1677 Don't pass `need_y_p' to `move_it_by_lines'.
1678
1c470562
SM
16792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1680
44f230aa
SM
1681 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1682 steal a few bits to be more compact.
1683 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1684 Remove unneeded casts.
1685
1c470562
SM
1686 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1687
888adce9
ZK
16882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1689
1690 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1691 binding" message (bug#7967).
1692
f838ed7b
PE
16932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1694
77861b95
PE
1695 Fix more problems found by GCC 4.6.0's static checks.
1696
de6dbc14
PE
1697 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1698 Remove unused local var.
1699
f838ed7b
PE
1700 * editfns.c (Fmessage_box): Remove unused local var.
1701
792c7b2b
PE
1702 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1703 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1704 Omit unused local vars.
c499e557 1705 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1706 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1707 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1708 Omit unused local var.
1709
ba0165e1
PE
1710 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1711 Don't assume string length fits in int.
32ad8845 1712 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1713 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1714
3c59b4c9
PE
1715 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1716 instead of alloca (Bug#8344).
1717
a3eed478 1718 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1719 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1720
eb4d412d
PE
1721 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1722
1658b401
PE
1723 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1724 concerns.
1725
1726 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1727
1728 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1729
9a2c6e05
PE
1730 * keyboard.c (syms_of_keyboard): Use the same style as later
1731 in this function when indexing through an array. This also
1732 works around GCC bug 48267.
1733
03d0a109
PE
1734 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1735
44f730c8
PE
1736 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1737
fe75f926
PE
1738 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1739 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1740
ffa8c828
PE
1741 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1742 This avoids undefined behavior on integer overflow, and is a bit
1743 more convenient anyway since it is compared to a size_t variable.
1744
c5101a77
PE
1745 Variadic C functions now count arguments with size_t, not int.
1746 This avoids an unnecessary limitation on 64-bit machines, which
1747 caused (substring ...) to crash on large vectors (Bug#8344).
1748 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1749 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1750 All variadic functions and their callers changed accordingly.
c5101a77
PE
1751 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1752 * data.c (arith_driver, float_arith_driver): Likewise.
1753 * editfns.c (general_insert_function): Likewise.
1754 * eval.c (struct backtrace.nargs, interactive_p)
1755 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1756 (funcall_lambda, mark_backtrace): Likewise.
1757 * fns.c (concat): Likewise.
1758 * frame.c (x_set_frame_parameters): Likewise.
1759 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1760 0 if not found, not -1. All callers changed.
1761
dd3f25f7
PE
1762 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1763 (stack_copy_size): Now size_t, not int.
1764 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1765
461c2ab9
JB
17662011-03-28 Juanma Barranquero <lekktu@gmail.com>
1767
1768 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1769 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1770 All callers changed.
1771
1772 * lisp.h (multibyte_char_to_unibyte):
1773 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1774 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1775 * character.h (CHAR_TO_BYTE8):
1776 * cmds.c (internal_self_insert):
1777 * editfns.c (general_insert_function):
1778 * keymap.c (push_key_description):
1779 * search.c (Freplace_match):
1780 * xdisp.c (message_dolog, set_message_1): All callers changed.
1781
f6d62986
SM
17822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1783
1784 * keyboard.c (safe_run_hook_funcall): New function.
1785 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1786 don't set the hook to nil, but remove the offending function instead.
1787 (Qcommand_hook_internal): Remove, unused.
1788 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1789 Vcommand_hook_internal.
1790
1791 * eval.c (enum run_hooks_condition): Remove.
1792 (funcall_nil, funcall_not): New functions.
1793 (run_hook_with_args): Call each function through a `funcall' argument.
1794 Remove `cond' argument, now redundant.
1795 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1796 (Frun_hook_with_args_until_failure): Adjust accordingly.
1797 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1798
1db5b1ad
JB
17992011-03-28 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * dispextern.h (string_buffer_position): Remove declaration.
1802
1803 * print.c (strout): Remove parameter `multibyte', unused since
1804 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1805
1806 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1807 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1808 All callers changed.
1809
1810 * w32.c (_wsa_errlist): Use braces for struct initializers.
1811
1812 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1813 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1814 All callers changed.
1815 (string_buffer_position): Likewise. Also, make static (it's never
1816 used outside xdisp.c).
1817 (cursor_row_p): Remove parameter `w', unused since
1818 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1819 (decode_mode_spec): Remove parameter `precision', introduced during
1820 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1821 All callers changed.
1822
5ffb62aa
JD
18232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1824
1825 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1826
461c2ab9 18272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1828
1829 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1830 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1831 (ns_update_auto_hide_menu_bar): New functions.
1832 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1833 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1834 ns_constrain_all_frames.
1835 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1836 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1837
5c380ffb
JD
18382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1839
1840 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1841
9af30bdf
GM
18422011-03-27 Glenn Morris <rgm@gnu.org>
1843
1844 * syssignal.h: Replace RETSIGTYPE with void.
1845 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1846 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1847 Replace SIGTYPE with void everywhere.
1848 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1849 * s/template.h (SIGTYPE): Remove commented out definition.
1850
e2abce01
JB
18512011-03-26 Eli Zaretskii <eliz@gnu.org>
1852
1853 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1854 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1855
f868cd8a
JB
18562011-03-26 Juanma Barranquero <lekktu@gmail.com>
1857
59eb0929
JB
1858 * w32.c (read_unc_volume): Use parameter `henum', instead of
1859 global variable `wget_enum_handle'.
1860
1861 * keymap.c (describe_vector): Remove parameters `indices' and
1862 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1863 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1864
f868cd8a
JB
1865 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1866
1867 * keyboard.c (timer_check): Remove parameter `do_it_now',
1868 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1869 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1870 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1871
1872 * keyboard.c (read_char):
1873 * w32menu.c (w32_menu_display_help):
1874 * xmenu.c (show_help_event, menu_help_callback):
1875 Adjust calls to `show_help_echo'.
1876
1877 * gtkutil.c (xg_maybe_add_timer):
1878 * keyboard.c (readable_events):
1879 * process.c (wait_reading_process_output):
1880 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1881
1882 * insdel.c (adjust_markers_gap_motion):
1883 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1884 (gap_left, gap_right): Don't call it.
1885
2ecf6fdb
CY
18862011-03-25 Chong Yidong <cyd@stupidchicken.com>
1887
1888 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1889 incurred during fontification.
1890
6b1f9ba4
JB
18912011-03-25 Juanma Barranquero <lekktu@gmail.com>
1892
1893 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1894 (DEFVAR_PER_BUFFER): Don't pass it.
1895
1896 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1897 (scrolling_window): Don't pass it.
1898
0f4a96b5
JB
18992011-03-25 Juanma Barranquero <lekktu@gmail.com>
1900
1901 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1902
1903 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1904 and `suffix'.
1905 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1906 of variables specific to SELinux and computation of `encoded_absname'.
1907
1908 * image.c (XPutPixel): Remove unused variable `height'.
1909
1910 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1911
1912 * unexw32.c (get_section_info): Remove unused variable `section'.
1913
1914 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1915 (system_process_attributes): Remove unused variable `sess'.
1916 (sys_read): Remove unused variable `err'.
1917
1918 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1919 (w32_wnd_proc): Remove unused variable `isdead'.
1920 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1921 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1922 (x_create_tip_frame): Remove unused variable `tem'.
1923
1924 * w32inevt.c (w32_console_read_socket):
1925 Remove unused variable `no_events'.
1926
1927 * w32term.c (x_draw_composite_glyph_string_foreground):
1928 Remove unused variable `width'.
1929
1149507c
JB
19302011-03-24 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * w32term.c (x_set_glyph_string_clipping):
1933 Don't pass uninitialized region to CombineRgn.
1934
9c88f339
JB
19352011-03-23 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1938 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1939 (Fx_close_connection): Remove unused variable `i'.
1940
1941 * w32font.c (w32font_draw): Return number of glyphs.
1942 (w32font_open_internal): Remove unused variable `i'.
1943 (w32font_driver): Add missing initializer.
1944
1945 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1946 (fill_in_menu): Remove unused variable `items_added'.
1947
1948 * w32term.c (last_mouse_press_frame): Remove static global variable.
1949 (w32_clip_to_row): Remove unused variable `f'.
1950 (x_delete_terminal): Remove unused variable `i'.
1951
1952 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1953 (NOTHING): Remove unused static global variable.
1954 (uniscribe_check_otf): Remove unused variable `table'.
1955 (uniscribe_font_driver): Add missing initializers.
1956
dee091a3
JD
19572011-03-23 Julien Danjou <julien@danjou.info>
1958
1959 * term.c (Fsuspend_tty, Fresume_tty):
1960 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1961 * window.c (temp_output_buffer_show):
1962 * insdel.c (signal_before_change):
1963 * frame.c (Fhandle_switch_frame):
1964 * fileio.c (Fdo_auto_save):
1965 * emacs.c (Fkill_emacs):
1966 * editfns.c (save_excursion_restore):
1967 * cmds.c (internal_self_insert):
1968 * callint.c (Fcall_interactively):
1969 * buffer.c (Fkill_all_local_variables):
1970 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1971 Use Frun_hooks.
0f4a96b5 1972 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1973 unconditionnaly since it does the check itself.
1974
2c520ab5 19752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1976
c9c49752
PE
1977 Fix more problems found by GCC 4.5.2's static checks.
1978
8abc3f12
PE
1979 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1980 the first time through the loop, since we know p0 < p1 then.
1981 This also avoids a gcc -Wstrict-overflow warning.
1982
a2d26660
PE
1983 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1984 leading to a memory leak, possible in functions like
1985 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1986 of objects (Bug#8318).
a2d26660 1987
916c72e9
PE
1988 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1989 that could (at least in theory) be that large.
1990
19ab8a18
PE
1991 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1992 This is less likely to overflow, and avoids undefined behavior if
1993 overflow does occur. All callers changed. Use strtoul to scan
1994 for the unsigned long integer.
b7cbbd6f
PE
1995 (pint2hrstr): Simplify and tune code slightly.
1996 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1997
f0641eff
PE
1998 * scroll.c (do_scrolling): Work around GCC bug 48228.
1999 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2000
7f650bb9
PE
2001 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2002 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2003 (validate_x_resource_name): Simplify count usage.
2004 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2005
37dd57d1
PE
2006 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2007 fail (Bug#8306).
81e56e61 2008
699979fc 2009 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2010
401bf9b4
PE
2011 * process.c (Fmake_network_process): Use socklen_t, not int,
2012 where POSIX says socklen_t is required in portable programs.
2013 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2014 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2015 (Fmake_network_process, server_accept_connection):
2016 (wait_reading_process_output, read_process_output):
2017 Likewise.
2018
b93aacde
PE
2019 * process.c: Rename or move locals to avoid shadowing.
2020 (list_processes_1, Fmake_network_process):
2021 (read_process_output_error_handler, exec_sentinel_error_handler):
2022 Rename or move locals.
4dc343ee 2023 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2024 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2025 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2026 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2027 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2028
af8a867c 2029 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2030 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2031 Include tparam.h instead, since it declares them.
af8a867c
PE
2032 * cm.h (PC): Remove extern decl; tparam.h now does this.
2033 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2034 * terminfo.c: Include tparam.h, to check interfaces.
2035 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2036 (tparam): Adjust signature to match interface in tparam.h;
2037 this removes some undefined behavior. Check that outstring and len
2038 are zero, which they always are with Emacs.
2039 * tparam.h (PC, BC, UP): New extern decls.
2040
0248044d 2041 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2042 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2043
8ff096c1 2044 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2045 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2046 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2047 (ftfont_list): Remove unused local.
49eaafba
PE
2048 (get_adstyle_property, ftfont_pattern_entity):
2049 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2050 Rename locals to avoid shadowing.
8ff096c1 2051
e2be39f6
PE
2052 * xfont.c (xfont_list_family): Mark var as initialized.
2053
c9735e30
PE
2054 * xml.c (make_dom): Now static.
2055
8f5201ae
PE
2056 * composite.c (composition_compute_stop_pos): Rename local to
2057 avoid shadowing.
b246f932
PE
2058 (composition_reseat_it): Remove unused locals.
2059 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2060 (composition_update_it): Mark var as initialized.
11b61122
PE
2061 (find_automatic_composition): Mark vars as initialized,
2062 with a FIXME (Bug#8290).
8f5201ae 2063
760fbc2c
PE
2064 character.h: Rename locals to avoid shadowing.
2065 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2066 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2067 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2068 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2069 to avoid shadowing.
2070
ff08eb85
PE
2071 * textprop.c (property_change_between_p): Remove; unused.
2072
fc7bf025
PE
2073 * intervals.c (interval_start_pos): Now static.
2074
235d7abc
PE
2075 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2076
44f230aa
SM
2077 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2078 Rename locals to avoid shadowing.
3e7d6594 2079
50060332
PE
2080 * sound.c (wav_play, au_play, Fplay_sound_internal):
2081 Fix pointer signedness.
d01f234b 2082 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2083 (wav_play): Initialize a variable to 0, to prevent undefined
2084 behavior (Bug#8278).
50060332 2085
c4fc4e30
PE
2086 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2087
918436ed
PE
2088 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2089
c939f91b
PE
2090 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2091 clobbering (Bug#8298).
b9c7f648
PE
2092 * sysdep.c (sys_subshell): Likewise.
2093 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2094
6bd8c144
PE
2095 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2096 This should get cleaned up, so that child_setup has the
2097 same signature on all platforms.
2098
7710357c 2099 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2100 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2101
c59da222
CY
21022011-03-22 Chong Yidong <cyd@stupidchicken.com>
2103
2104 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2105 not to be necessary, and produces flickering.
2106
66b87493
GM
21072011-03-20 Glenn Morris <rgm@gnu.org>
2108
2109 * config.in: Remove file.
2110
45b6f6d5
JB
21112011-03-20 Juanma Barranquero <lekktu@gmail.com>
2112
2113 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2114 are now in src/globals.h.
2115 (syms_of_minibuf): Remove spurious & from previous change.
2116
3ec03f7e
LL
21172011-03-20 Leo <sdl.web@gmail.com>
2118
2119 * minibuf.c (completing-read-function): New variable.
2120 (completing-read-default): Rename from completing-read.
2121 (completing-read): Call completing-read-function.
2122
b14e3e21
CY
21232011-03-19 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * xfaces.c (Fx_load_color_file):
2126 Read color file from absolute filename (bug#8250).
2127
f2b726e6
JB
21282011-03-19 Juanma Barranquero <lekktu@gmail.com>
2129
2130 * makefile.w32-in: Update dependencies.
2131
09f6ff02
EZ
21322011-03-17 Eli Zaretskii <eliz@gnu.org>
2133
2134 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2135
29a6015a
PE
21362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2137
a3a6c54e
PE
2138 Fix more problems found by GCC 4.5.2's static checks.
2139
b766f867
PE
2140 * process.c (make_serial_process_unwind, send_process_trap):
2141 (sigchld_handler): Now static.
2142
be02381c
PE
2143 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2144 That way, the code declares only the vars that it needs.
2145 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2146 * s/cygwin.h (PTY_ITERATION): Likewise.
2147 * s/darwin.h (PTY_ITERATION): Likewise.
2148 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2149
57048744
PE
2150 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2151 * process.c (allocate_pty): Don't declare stb unless it's needed.
2152
7914961c 2153 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2154 (CONSTANTLIM): Remove; unused.
2155 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2156 Define only if needed.
7914961c 2157
b3967b18
PE
2158 * unexelf.c (unexec): Name an expression,
2159 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2160 Use a different way to cause a compilation error if anyone uses
2161 n rather than nn, a way that does not involve shadowing.
73366a00 2162 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2163
29a6015a
PE
2164 * deps.mk (unexalpha.o): Remove; unused.
2165
43cfc33e 2166 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2167 * unexec.h: New file.
ce701a33
PE
2168 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2169 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2170 Depend on unexec.h.
2171 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2172 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2173 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2174 Change as necessary to match prototype in unexec.h.
ce701a33 2175
01f44d5a
PE
2176 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2177 shadowing.
4f63c6bb 2178 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2179
a6670b0b
PE
2180 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2181 Rename locals to avoid shadowing.
2182
cef2010d 2183 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2184 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2185
d4d7173a
PE
2186 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2187
f08b802a
PE
2188 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2189 warning when compiling print.c.
2190
3ddb0639
PE
2191 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2192 instead of using an uninitialized var.
5ad03b97 2193 (font_sort_entities): Mark var as initialized.
3ddb0639 2194
170a2692
PE
2195 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2196
e663c700
PE
2197 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2198 pointers to constants.
89bc529a 2199 (font_parse_fcname): Remove unused vars.
7b81e2d0 2200 (font_delete_unmatched): Now static.
ea838e10 2201 (font_get_spec): Remove; unused.
13a547c6
PE
2202 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2203 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2204 Rename or move locals to avoid shadowing.
e663c700 2205
2a80c887 2206 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2207 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2208
1384fa33 2209 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2210 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2211
8b2c52e9
PE
2212 * alloc.c (mark_backtrace): Move decl from here ...
2213 * lisp.h: ... to here, so that it can be checked.
2214
475545b5 2215 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2216 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2217 (lisp_indirect_variable): Name an expression,
2218 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2219 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2220
b1349114 2221 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2222 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2223 Use const pointer when appropriate.
b1349114 2224
a2928364
PE
2225 * lisp.h (get_system_name, get_operating_system_release):
2226 Move decls here, to check interfaces.
2227 * process.c (get_operating_system_release): Move decl to lisp.h.
2228 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2229 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2230 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2231 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2232 (Fformat_time_string, Fencode_time, Finsert_char):
2233 (Ftranslate_region_internal, Fformat):
2234 Rename or remove local vars to avoid shadowing.
9710023e 2235 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2236
a415e694
PE
2237 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2238 avoid shadowing.
2239
8ef4622d
PE
2240 * lisp.h (eassert): Check that the argument compiles, even if
2241 ENABLE_CHECKING is not defined.
2242
946f9a5b
PE
2243 * data.c (Findirect_variable): Name an expression, to avoid
2244 gcc -Wbad-function-cast warning.
112396d6 2245 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2246 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2247 (Fmake_variable_buffer_local, Fmake_local_variable):
2248 Mark variables as initialized.
52746918 2249 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2250
e5aab7e7 2251 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2252 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2253 Rename locals to avoid shadowing.
dff45157
PE
2254 (mark_stack): Move local variables into the #ifdef region where
2255 they're used.
7bc26fdb
PE
2256 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2257 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2258 needed otherwise.
2259 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2260 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2261 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2262
e5aab7e7
PE
2263 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2264 avoids undefined behavior in theory.
2265
4da60324
PE
2266 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2267
88043301
PE
2268 Use functions, not macros, for up- and down-casing (Bug#8254).
2269 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2270 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2271 to use the following functions instead of these macros.
2272 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2273 EMACS_INT, since callers assume the returned value fits in int.
2274 (upcase1): Likewise, for UPCASE_TABLE.
2275 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2276 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2277 the race-condition problem in the old DOWNCASE.
88043301 2278
19ed5445
PE
2279 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2280 Rename locals to avoid shadowing.
2281 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2282 (regex_compile, re_search_2, re_match_2_internal):
2283 Remove unused local vars.
952db0d7
PE
2284 (FREE_VAR): Rewrite so as not to use empty "else",
2285 which gcc can warn about.
da053e48 2286 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2287 (RETALLOC_IF): Define only if needed.
2288 (WORDCHAR_P): Likewise. This one is never needed, but is used
2289 only in a comment talking about a compiler bug, so put inside
2290 the #if 0 of that comment.
2291 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2292 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2293 Remove; unused.
19ed5445 2294
1f3561e4 2295 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2296 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2297 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2298
ded6f8f7
PE
2299 * search.c (simple_search): Remove unused var.
2300
dbd37a95
PE
2301 * dired.c (compile_pattern): Move decl from here ...
2302 * lisp.h: ... to here, so that it can be checked.
2303 (struct re_registers): New forward decl.
2304
7e47afad
PE
2305 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2306
85f24f61
PE
2307 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2308 All uses changed.
2309 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2310 Rename locals to avoid shadowing.
5671df8f 2311 (Fvertical_motion): Mark locals as initialized.
85f24f61 2312
181aa2be 2313 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2314 (casify_region): Mark local as initialized.
181aa2be 2315
930d429c
PE
2316 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2317
7082eac6
PE
2318 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2319 New macros, so that the caller can use some names other than
2320 gcpro1, gcpro2, etc.
2321 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2322 of the new macros.
2323 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2324 argument, for consistency with GCPRO2_VAR, etc: it is now the
2325 prefix of the variable, not the variable itself. All uses
2326 changed.
38b2c076
PE
2327 * dired.c (directory_files_internal, file_name_completion):
2328 Rename locals to avoid shadowing.
2329
15206ed9
PE
2330 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2331 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2332 dired.c's scmp function, had undefined behavior.
2333 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2334 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2335 * buffer.h: ... to here, because these macros use current_buffer,
2336 and the new implementation with inline functions needs to have
2337 current_buffer in scope now, rather than later when the macros
2338 are used.
2339 (downcase, upcase1): New static inline functions.
2340 (DOWNCASE, UPCASE1): Reimplement using these functions.
2341 This avoids undefined behavior in expressions like
2342 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2343 from race conditions in accessing the global variables
2344 case_temp1 and case_temp2.
2345 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2346 * lisp.h (case_temp1, case_temp2): Remove their decls.
2347 * character.h (ASCII_CHAR_P): Move from here ...
2348 * lisp.h: ... to here, so that the inline functions mentioned
2349 above can use them.
2350
4a6bea26
PE
2351 * dired.c (directory_files_internal_unwind): Now static.
2352
f14b7e14
PE
2353 * fileio.c (file_name_as_directory, directory_file_name):
2354 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2355 Now static.
2893f146
PE
2356 (file_name_as_directory): Use const pointers when appropriate.
2357 (Fexpand_file_name): Likewise. In particular, newdir might
2358 point at constant storage, so make it a const pointer.
fd4ead52 2359 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2360 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2361 signedness issues.
f839df0c
PE
2362 (Fset_file_times, Finsert_file_contents, auto_save_error):
2363 Rename locals to avoid shadowing.
f14b7e14 2364
5716756e 2365 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2366 (Ftry_completion, Fall_completions): Rename or remove locals
2367 to avoid shadowing.
5716756e 2368
b4c3046a
PE
2369 * marker.c (bytepos_to_charpos): Remove; unused.
2370
b45db522
PE
2371 * lisp.h (verify_bytepos, count_markers): New decls,
2372 so that gcc does not warn that these functions aren't declared.
2373
85876d07
PE
2374 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2375 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2376 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2377 (copy_text): Remove unused local var.
85876d07 2378
03d78a21 2379 * filelock.c (within_one_second): Now static.
b3dd38ab 2380 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2381
5df8f01b
PE
2382 * buffer.c (fix_overlays_before): Mark locals as initialized.
2383 (fix_start_end_in_overlays): Likewise. This function should be
2384 simplified by using pointers-to-pointers, but that's a different
2385 matter.
b1d876f1 2386 (switch_to_buffer_1): Now static.
8f54f30a
PE
2387 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2388 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2389
a70072c9 2390 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2391 Fix pointer signedness issue.
edced198
PE
2392 (sys_subshell): Mark local as volatile if checking for lint,
2393 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2394 (MAXPATHLEN): Define only if needed.
a70072c9 2395
a0977c44
PE
2396 * process.c (serial_open, serial_configure): Move decls from here ...
2397 * systty.h: ... to here, so that they can be checked.
2398
a884fdcc
PE
2399 * fns.c (get_random, seed_random): Move extern decls from here ...
2400 * lisp.h: ... to here, so that they can be checked.
2401
604efe86 2402 * sysdep.c (reset_io): Now static.
b8950c94 2403 (wait_for_termination_signal): Remove; unused.
604efe86 2404
38fc62d9
PE
2405 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2406 (copy_keymap_item, append_key, push_text_char_description):
2407 Now static.
1004a21a 2408 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2409 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2410 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2411 (describe_map_tree):
2412 Rename locals to avoid shadowing.
38fc62d9 2413
2f2650da
PE
2414 * keyboard.c: Declare functions static if they are not used elsewhere.
2415 (echo_char, echo_dash, cmd_error, top_level_2):
2416 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2417 (read_char, kbd_buffer_get_event, make_lispy_position):
2418 (make_lispy_event, make_lispy_movement, apply_modifiers):
2419 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2420 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2421 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2422 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2423 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2424
a053e86c 2425 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2426 (mark_kboards): Move decl here ...
2427 * alloc.c (mark_kboards): ... from here.
a053e86c 2428
4752793e
PE
2429 * lisp.h (force_auto_save_soon): New decl.
2430
74f10ca7 2431 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2432 (DEFINE_DUMMY_FUNCTION): New macro.
2433 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2434 Use it.
c03cd23f
PE
2435 (main): Add casts to avoid warnings
2436 if GCC considers string literals to be constants.
74f10ca7 2437
022e70d4
PE
2438 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2439
59d6fe83
PE
2440 * dbusbind.c: Pointer signedness fixes.
2441 (xd_signature, xd_append_arg, xd_initialize):
2442 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2443 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2444 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2445 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2446
78320123
PE
2447 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2448 if GCC considers string literals to be constants.
49cebcca 2449 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2450
35ac2a97
SM
24512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2452
fb103ca9
SM
2453 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2454 (print_preprocess, print_object): New macro to fix last change.
2455
35ac2a97
SM
2456 * print.c (print_preprocess): Don't forget font objects.
2457
62973b41
JB
24582011-03-16 Juanma Barranquero <lekktu@gmail.com>
2459
2460 * emacs.c (USAGE3): Doc fixes.
2461
0e48bb22
AS
24622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2465 structure.
2466
7684e57b
JB
24672011-03-14 Juanma Barranquero <lekktu@gmail.com>
2468
2469 * lisp.h (VWindow_system, Qfile_name_history):
2470 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2471 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2472 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2473
2474 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2475 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2476
2477 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2478 * w32console.c (detect_input_pending, read_input_pending)
2479 (encode_terminal_code):
2480 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2481 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2482 (w32_system_caret_y, Qfile_name_history):
2483 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2484 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2485 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2486 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2487 * w32proc.c (Qlocal, report_file_error):
2488 * w32term.c (Vwindow_system, updating_frame):
2489 * w32uniscribe.c (initialized, uniscribe_font_driver):
2490 Remove unneeded extern declarations.
2491
2aa46d6c
CY
24922011-03-14 Chong Yidong <cyd@stupidchicken.com>
2493
c96bbc66 2494 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2495
cffc6f3b
CY
24962011-03-13 Chong Yidong <cyd@stupidchicken.com>
2497
2498 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2499 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2500 These macros can no longer be used for assignment.
2501
44f230aa
SM
2502 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2503 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2504 (record_buffer_markers, fetch_buffer_markers): New functions for
2505 recording and fetching special buffer markers.
2506 (set_buffer_internal_1, set_buffer_temp): Use them.
2507
2508 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2509
2510 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2511
2512 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2513 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2514
2515 * xdisp.c (hscroll_window_tree):
2516 (reconsider_clip_changes): Use PT instead of BUF_PT.
2517
d251f04b
EZ
25182011-03-13 Eli Zaretskii <eliz@gnu.org>
2519
2520 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2521 $(EMACS_ROOT)/lib/intprops.h.
2522
f0c77cd1
PE
25232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2524
3eca4629
PE
2525 Fix more problems found by GCC 4.5.2's static checks.
2526
7c86ee98
PE
2527 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2528 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2529 (xg_free_frame_widgets): Make it clear that a local variable is
2530 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2531 (gdk_window_get_screen): Make it clear that this macro is needed
2532 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2533 (int_gtk_range_get_value): New function, which avoids a diagnostic
2534 from gcc -Wbad-function-cast.
2535 (xg_set_toolkit_scroll_bar_thumb): Use it.
2536 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2537 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2538 (get_utf8_string, xg_get_file_with_chooser):
2539 Rename locals to avoid shadowing.
2540 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2541
41729b81
PE
2542 * xgselect.c (xg_select): Remove unused var.
2543
f0c77cd1
PE
2544 * image.c (four_corners_best): Mark locals as initialized.
2545 (gif_load): Initialize transparent_p to zero (Bug#8238).
2546 Mark another local as initialized.
ec6cf4c6 2547 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2548
ce0ad53d 2549 * image.c (clear_image_cache): Now static.
d5d5a617 2550 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2551 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2552 (x_edge_detection): Remove unnecessary cast that
2553 gcc -Wbad-function-cast diagnoses.
2037898d 2554 (gif_load): Fix pointer signedness.
6ae141d6
PE
2555 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2556 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2557
33383987 25582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2559
d32df629
PE
2560 Improve quality of tests for time stamp overflow.
2561 For example, without this patch (encode-time 0 0 0 1 1
2562 1152921504606846976) returns the obviously-bogus value (-948597
2563 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2564 reports time overflow. See
2565 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2566 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2567 * editfns.c: Include limits.h and intprops.h.
2568 (TIME_T_MIN, TIME_T_MAX): New macros.
2569 (time_overflow): Move earlier, to before first use.
2570 (hi_time, lo_time): New functions, for an accurate test for
2571 out-of-range times.
2572 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2573 (Fget_internal_run_time): Don't assume time_t fits in int.
2574 (make_time): Use list2 instead of Fcons twice.
2575 (Fdecode_time): More accurate test for out-of-range times.
2576 (check_tm_member): New function.
2577 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2578 (lisp_time_argument): Don't rely on undefined left-shift and
2579 right-shift behavior when checking for time stamp overflow.
8be6f318 2580
fe31d94c
PE
2581 * editfns.c (time_overflow): New function, refactoring common code.
2582 (Fformat_time_string, Fdecode_time, Fencode_time):
2583 (Fcurrent_time_string): Use it.
2584
8be6f318
PE
2585 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2586 * dired.c (make_time): Move to ...
2587 * editfns.c (make_time): ... here.
2588 * systime.h: Note the move.
2589
09d9db2c 25902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2591
126bc0dc
YM
2592 * fringe.c (update_window_fringes): Remove unused variables.
2593
c47cbdfd
YM
2594 * unexmacosx.c (copy_data_segment): Also copy __got section.
2595 (Bug#8223)
2596
7ac80be9
EZ
25972011-03-12 Eli Zaretskii <eliz@gnu.org>
2598
c96bbc66 2599 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2600 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2601 Constify `char *' arguments and their references according to
2602 prototypes in tparam.h.
2603
ecb0f94d 2604 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2605
7ac80be9
EZ
2606 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2607 Adapt all references accordingly.
2608
2609 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2610
ef1fd07e
TT
26112011-03-11 Tom Tromey <tromey@redhat.com>
2612
2613 * buffer.c (syms_of_buffer): Remove obsolete comment.
2614
7ef4b50c
EZ
26152011-03-11 Eli Zaretskii <eliz@gnu.org>
2616
2617 * termhooks.h (encode_terminal_code): Declare prototype.
2618
2619 * msdos.c (encode_terminal_code): Don't declare prototype.
2620
2621 * term.c (encode_terminal_code): Now external again, used by
2622 w32console.c and msdos.c.
2623
44f230aa
SM
2624 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2625 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2626
4b1ec863 26272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2628
1714f52b 2629 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2630
4b1ec863
PE
2631 * fringe.c (update_window_fringes): Mark locals as initialized
2632 (Bug#8227).
2633 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2634
524c7aa6
PE
2635 * alloc.c (mark_fringe_data): Move decl from here ...
2636 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2637 to check its interface.
2638 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2639
a5c0af81 2640 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2641 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2642 (fontset_font): Mark local as initialized.
a9a06e0b 2643 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2644
b4716021
PE
2645 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2646
811e9bac 2647 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2648 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2649 (x_own_selection, Fx_disown_selection_internal): Rename locals
2650 to avoid shadowing.
2651 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2652
7e3ab302
PE
2653 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2654 so that the caller can use some name other than gcpro1.
2655 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2656 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2657 (Fx_backspace_delete_keys_p):
2658 Use them to avoid shadowing, and rename vars to avoid shadowing.
2659 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2660 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2661 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2662 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2663 Remove unused locals.
7e3ab302
PE
2664 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2665 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2666 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2667 macros.
f78faa98 2668
e2b13473
PE
2669 * xterm.h (x_mouse_leave): New decl.
2670
77f23912
PE
2671 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2672 Remove unused functions.
cdf4ba58
PE
2673 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2674 (x_calc_absolute_position): Now static.
7411c686 2675 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2676 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2677 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2678 unless they are used.
38d0b34a
PE
2679 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2680 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2681 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2682 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2683 (x_error_catcher, x_connection_closed, x_error_handler):
2684 (x_error_quitter, xembed_send_message, x_iconify_frame):
2685 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2686 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2687 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2688
44f230aa
SM
2689 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2690 Rename or move locals to avoid shadowing.
6b463e58 2691 (tty_defined_color, merge_face_heights): Now static.
5967d051 2692 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2693 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2694 does not deduce is never used uninitialized.
73719eba
PE
2695 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2696 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2697
426994c3 2698 * terminal.c (store_terminal_param): Now static.
5489860b 2699
032f1620 2700 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2701 (set_frame_menubar): Remove unused local.
d4323972 2702 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2703 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2704 since they might point to immutable storage.
281585b0
PE
2705 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2706 since it's unused otherwise.
032f1620 2707
367c19e5 2708 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2709 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2710 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2711 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2712 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2713 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2714 does not deduce are never used uninitialized.
70739cbe 2715
07b48fa9
PE
2716 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2717
8868a238 2718 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2719 * window.c (window_loop, size_window):
2720 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2721
7e5cf297 2722 * window.c (display_buffer): Now static.
d6550a9f
PE
2723 (size_window): Mark variables that gcc -Wuninitialized
2724 does not deduce are never used uninitialized.
a586633d
PE
2725 * window.h (check_all_windows): New decl, to forestall
2726 gcc -Wmissing-prototypes diagnostic.
5b555da1 2727 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2728
f6095868
PE
2729 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2730 shadowing.
2731 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2732 Include <limits.h>.
2733 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2734 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2735 (load_charset_map): Mark variables that gcc -Wuninitialized
2736 does not deduce are never used uninitialized.
53df7c11 2737 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2738
f38b440c
PE
2739 * coding.c (coding_set_source, coding_set_destination):
2740 Use "else { /* comment */ }" rather than "else /* comment */;"
2741 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2742 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2743 a block, when the outer 'i' will do.
2744 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2745 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2746 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2747 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2748 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2749 Rename locals to avoid shadowing.
2750 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2751 * coding.c (emacs_mule_char, encode_invocation_designation):
2752 Now static, since they're not used elsewhere.
413bb2db 2753 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2754 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2755 (decode_coding_emacs_mule): Mark variables that gcc
2756 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2757 (detect_coding_iso_2022): Initialize a local variable that might
2758 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2759 this initialization is needed. (Bug#8211)
5f58e762
PE
2760 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2761 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2762 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2763 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2764 Remove unused macros.
f38b440c 2765
232b38b9 2766 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2767 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2768 * character.c (string_count_byte8): Likewise.
232b38b9 2769
fb90da1b
PE
2770 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2771 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2772
fb93dbc2
PE
2773 * chartab.c (copy_sub_char_table): Now static, since it's not used
2774 elsewhere.
5c156ace
PE
2775 (sub_char_table_ref_and_range, char_table_ref_and_range):
2776 Rename locals to avoid shadowing.
bbcd0949 2777 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2778
7d3b3862 2779 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2780 (BIDI_BOB): Remove unused macro.
7d3b3862 2781
6be7d3da
PE
2782 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2783 deduce are never used uninitialized.
c2ed9c8b 2784 * term.c (encode_terminal_code): Likewise.
6be7d3da 2785
75f8807f 2786 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2787
50938595
PE
2788 * tparam.h: New file.
2789 * term.c, tparam.h: Include it.
2790 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2791 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2792 Move these decls to tparam.h, and make them agree with what
2793 is actually in tparam.c. The previous trick of using incompatible
2794 decls in different modules does not conform to the C standard.
2795 All callers of tparam changed to use tparam's actual API.
2796 * tparam.c (tparam1, tparam, tgoto):
2797 Use const pointers where appropriate.
2798
fbceeba2
PE
2799 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2800 * cm.h (struct cm): Likewise.
2801 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2802 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2803 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2804 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2805 (turn_on_face, init_tty): Likewise.
2806 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2807
7f3f1250
PE
2808 * term.c (term_mouse_position): Rename local to avoid shadowing.
2809
e6ca6543
PE
2810 * alloc.c (mark_ttys): Move decl from here ...
2811 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2812
c40f8d15
AS
28132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2814
2815 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2816
cfe0661d
JB
28172011-03-09 Juanma Barranquero <lekktu@gmail.com>
2818
2819 * search.c (compile_pattern_1): Remove argument regp, unused since
2820 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2821 (compile_pattern): Don't pass it.
2822
0afb4571
J
28232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2824
2825 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2826 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2827 for ! HAVE_GTK3.
2828 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2829
2830 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2831
2832 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2833 gdk_window_get_screen, gdk_window_get_geometry,
2834 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2835 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2836 (xg_get_pixbuf_from_pixmap): New function.
2837 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2838 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2839 Call xg_get_pixbuf_from_pixmap instead of
2840 gdk_pixbuf_get_from_drawable.
2841 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2842 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2843 (xg_check_special_colors): Use GtkStyleContext and its functions
2844 for HAVE_GTK3.
2845 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2846 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2847 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2848 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2849 Call gtk_widget_get_preferred_size.
0afb4571
J
2850 (xg_frame_resized): gdk_window_get_geometry only takes 5
2851 parameters.
44f230aa
SM
2852 (xg_win_to_widget, xg_event_is_for_menubar):
2853 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2854 (xg_set_widget_bg): New function.
2855 (delete_cb): New function.
895009e1 2856 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2857 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2858 (xg_set_background_color): Call xg_set_widget_bg.
2859 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2860 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2861 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2862 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2863 if ! HAVE_GTK3.
2864 (update_frame_tool_bar): Call gtk_widget_hide.
2865 (xg_initialize): Use GDK_KEY_g.
2866
2867 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2868 if ! HAVE_GTK3
2869 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2870
2871 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2872 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2873 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2874
1c2cc4ef
JB
28752011-03-08 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * w32xfns.c (select_palette): Check success of RealizePalette against
2878 GDI_ERROR, not zero.
2879
33383987 2880See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2881
2882;; Local Variables:
2883;; coding: utf-8
aac0c6e3
MR
2884;; End:
2885
33383987 2886 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2887
2888 This file is part of GNU Emacs.
2889
2890 GNU Emacs is free software: you can redistribute it and/or modify
2891 it under the terms of the GNU General Public License as published by
2892 the Free Software Foundation, either version 3 of the License, or
2893 (at your option) any later version.
2894
2895 GNU Emacs is distributed in the hope that it will be useful,
2896 but WITHOUT ANY WARRANTY; without even the implied warranty of
2897 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2898 GNU General Public License for more details.
2899
2900 You should have received a copy of the GNU General Public License
2901 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.