* xfaces.c: Don't assume buffer size fits in 'int'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f162bcc3
PE
12012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2
c71f5156 3 * xfaces.c (face_at_buffer_position): Remove unused local.
56adbe62
PE
4 (face_at_buffer_position, face_for_overlay_string):
5 Don't assume buffer size fits in 'int'.
c71f5156 6
f162bcc3
PE
7 Use C99-style 'extern inline' if available.
8 * buffer.h (BUFFER_INLINE):
9 * category.h (CATEGORY_INLINE):
10 * character.h (CHARACTER_INLINE):
11 * charset.h (CHARSET_INLINE):
12 * composite.h (COMPOSITE_INLINE):
13 * dispextern.h (DISPEXTERN_INLINE):
14 * lisp.h (LISP_INLINE):
15 * systime.h (SYSTIME_INLINE):
16 New macro, replacing 'static inline' in this header.
17 * buffer.h, category.h, character.h, charset.h, composite.h:
18 * dispextern.h, lisp.h, systime.h:
19 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
20 * alloc.c (LISP_INLINE):
21 * buffer.c (BUFFER_INLINE):
22 * category.c (CATEGORY_INLINE):
23 * character.c (CHARACTER_INLINE):
24 * charset.c (CHARSET_INLINE):
25 * composite.c (COMPOSITE_INLINE):
26 * dispnew.c (DISPEXTERN_INLINE):
27 * sysdep.c (SYSTIME_INLINE):
28 Define to EXTERN_INLINE, so that the corresponding functions
29 are compiled into code.
30 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
31 (INLINE_HEADER_END): New macros.
32 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
33 since it's used in non-static inline functions now.
34
837b365b
GM
352012-08-02 Glenn Morris <rgm@gnu.org>
36
d66b744d
GM
37 * s/: Remove empty directory.
38
837b365b
GM
39 * s/ms-w32.h: Move to ../nt/inc.
40 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
41 Update for new ms-w32.h location.
42
13294f95
PE
432012-08-02 Paul Eggert <eggert@cs.ucla.edu>
44
45 Port to Solaris 8.
46 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
47
90df0db3
GM
482012-08-02 Glenn Morris <rgm@gnu.org>
49
50 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
51 hard-coding the path separator.
52
4939150c
PE
532012-08-01 Paul Eggert <eggert@cs.ucla.edu>
54
55 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
56 This how ASET and AREF are supposed to work, and makes
57 it easier to think about future improvements. See
58 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
59 * charset.h (set_charset_attr): New function.
60 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
61 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
62 (aref_addr): New function. All uses of &AREF(...) changed.
63 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
64 (set_hash_index): New functions. All lvalue-style uses of
65 HASH_KEY etc. changed.
66 * keyboard.c (set_prop): New function. All lvalue-style uses
67 of PROP changed.
68
947b2afd
AA
692012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
70
71 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
72 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
73 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
74 * nsfns.m (ns_set_name_as_filename): Likewise.
75 * nsmenu.m (ns_update_menubar): Likewise.
76 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
77
4f5d0325
EZ
782012-08-01 Eli Zaretskii <eliz@gnu.org>
79
2008beae
EZ
80 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
81 Adapt to latest changes in field names of the corresponding Lisp
288479f6 82 objects.
2008beae 83
4f5d0325
EZ
84 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
85
fe3cc771
GM
862012-08-01 Glenn Morris <rgm@gnu.org>
87
88 * s/msdos.h: Remove file.
89 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
90 * Makefile.in (S_FILE): Remove.
91 (config_h): Remove S_FILE.
92
c90acc54
JB
932012-08-01 Juanma Barranquero <lekktu@gmail.com>
94
95 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
96 Remove; moved to nt/config.nt.
97
d8a05828
DA
982012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Use INTERNAL_FIELD for conses and overlays.
101 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
102 Remove obsolete comment.
103 (MVAR): New macro.
104 (struct Lisp_Overlay): Use INTERNAL_FIELD.
105 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
106
8271d590
DA
1072012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Use INTERNAL_FIELD for symbols.
110 * lisp.h (SVAR): New macro. Adjust users.
111 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
112 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
113
3193acd2
DA
1142012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Use INTERNAL_FIELD for processes.
117 * process.h (PVAR): New macro. Adjust style.
118 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
119 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
120
3a45383a
DA
1212012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
122
123 Use INTERNAL_FIELD for windows.
124 * window.h (WVAR): New macro.
125 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
126 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
127 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
128 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
129 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
130 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
131
c1dbc63c
PE
1322012-08-01 Paul Eggert <eggert@cs.ucla.edu>
133
134 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
135
5c0c0e8a
GM
1362012-08-01 Glenn Morris <rgm@gnu.org>
137
138 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
139 Move to configure.ac.
140
552a99b4
JB
1412012-08-01 Juanma Barranquero <lekktu@gmail.com>
142
143 * makefile.w32-in (CONFIG_H): Update dependencies.
144 (CONF_POST_H): New macro.
145
146 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
147
8d8e2dfe
GM
1482012-07-31 Glenn Morris <rgm@gnu.org>
149
bc96620a
GM
150 * Makefile.in (S_FILE): No longer set by configure.
151
476b1b2d
GM
152 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
153 is available.
154 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
155
b2c7a106
GM
156 * process.h (NULL_DEVICE):
157 * emacs.c (SEPCHAR):
158 * editfns.c (USER_FULL_NAME): Let configure set them.
159
d53d062a
GM
160 * s/README, s/template.h: Remove files.
161
4515017f
GM
162 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
163
8d8e2dfe
GM
164 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
165 Move to configure.ac.
166
5b20b3cc
EZ
1672012-07-31 Eli Zaretskii <eliz@gnu.org>
168
1e0afd9a
EZ
169 * .gdbinit (xframe): Adapt to introduction of FVAR and the
170 resulting renaming of 'struct frame' members.
171
5b20b3cc
EZ
172 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
173
174 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
175 after introduction of FVAR.
176
f1310128
JD
1772012-07-31 Jan Djärv <jan.h.d@swipnet.se>
178
79e721e0
JD
179 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
180
181 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
182 instead of compositeToPoint.
183 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
184
8d7c7eed 185 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 186
e34f7f79
DA
1872012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
190 * lisp.h (INTERNAL_FIELD): New macro.
191 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
192 (BVAR): Change to use INTERNAL_FIELD.
193 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
194 (KVAR): Change to use INTERNAL_FIELD.
195 * frame.h (FVAR): New macro.
196 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
197 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
198 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
199 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
200 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
201
c09bfb2f
DA
2022012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Miscellaneous fixes for non-default X toolkits.
205 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
206 * xterm.c (x_frame_of_widget): Remove redundant prototype.
207 Move under #ifdef USE_LUCID.
208 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
209 definition and usage to avoid warnings.
210
14c114ae
JD
2112012-07-31 Jan Djärv <jan.h.d@swipnet.se>
212
213 * nsterm.m (openFiles): Fix previous checkin.
214
3bd21e82
PE
2152012-07-31 Paul Eggert <eggert@cs.ucla.edu>
216
217 * indent.c (compute_motion): Remove unused local.
218
c1529ded
GM
2192012-07-31 Glenn Morris <rgm@gnu.org>
220
400d5621
GM
221 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
222
268e2432
GM
223 * conf_post.h [USG5_4]:
224 Move remaining contents of s/usg5-4-common.h here.
225 * s/usg5-4-common.h: Remove file.
226
7552f3ee
GM
227 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
228 * s/irix6-5.h: Remove file.
229
6a381852
GM
230 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
231 * s/darwin.h: Remove file.
232
c1529ded
GM
233 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
234 * s/hpux10-20.h: Remove file, which is now empty.
235
b429a4ee
GM
2362012-07-30 Glenn Morris <rgm@gnu.org>
237
238 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
239 * Makefile.in (config_h): Add conf_post.h.
240 * makefile.w32-in (CONFIG_H): Add conf_post.h.
241
adff3182
JD
2422012-07-30 Jan Djärv <jan.h.d@swipnet.se>
243
244 * nsterm.m (ns_do_open_file): New variable.
b9031d69 245 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
246 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
247 files only if ns_do_open_file.
248
c32af1e4
PE
2492012-07-30 Paul Eggert <eggert@cs.ucla.edu>
250
7393bcbb
PE
251 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
252 This no-op macro hasn't been needed for many years.
253 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
254
c32af1e4
PE
255 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
256 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
257 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
258 gdb_make_enums_visible.
259 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
260 (DIRECTORY_SEP): Now a constant, not a macro.
261
302fc036
EZ
2622012-07-30 Eli Zaretskii <eliz@gnu.org>
263
264 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
265 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
266
267 * w32term.c <w32_keyboard_codepage>: Renamed from
268 keyboard_codepage and now external. All users changed.
269
270 * w32term.h: Add declaration of w32_keyboard_codepage.
271
272 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
273 the codepage to translate keys to Unicode. If this argument is
274 -1, use the value returned by GetConsoleCP. All callers changed.
275
88fb40b4
PE
2762012-07-30 Paul Eggert <eggert@cs.ucla.edu>
277
0aee6912
PE
278 Update .PHONY listings in makefiles.
279 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
280 bootstrap-clean, distclean, maintainer-clean, versioclean,
281 extraclean, frc.
282
88fb40b4
PE
283 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
284 This is a bit clearer. Fix some commentary typos.
285
0a763bd1
GM
2862012-07-30 Glenn Morris <rgm@gnu.org>
287
32bac6d6
GM
288 * s/netbsd.h: Let configure include signal.h if needed.
289 Remove file, which is now empty.
290
b65e7c46
GM
291 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
292 Let configure set them.
293 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
294 No more need to undefine.
0a763bd1 295
169304bd
AS
2962012-07-30 Andreas Schwab <schwab@linux-m68k.org>
297
298 * keymap.c (Fkey_description): Don't remove 0x80 bit from
299 non-single-byte char when adding meta modifier. (Bug#12090)
300
6cd7a139
DA
3012012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
302
303 Convert safe_call to use variable number of arguments.
304 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
305 (safe_call2): Fix comment.
306 * lisp.h (safe_call): Adjust prototype.
307 * coding.c (encode_coding_object): Change to use safe_call2.
308 * xfaces.c (merge_face_heights): Change to use safe_call1.
309
d34d6ffc
GM
3102012-07-30 Glenn Morris <rgm@gnu.org>
311
7b8a48e4 312 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 313 does that unconditionally. Remove file, which is now empty.
7b8a48e4 314
d34d6ffc
GM
315 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
316 Remove empty files.
317
03a660a6
PE
3182012-07-30 Paul Eggert <eggert@cs.ucla.edu>
319
320 Export to GDB most of lisp.h's remaining object-like macros.
321 * lisp.h (min, max): Move earlier, because they're used earlier now.
322 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
323 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
324 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
325 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
326 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
327 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
328 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
329 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
330 Now constants, for GDB. They need not be macros.
331 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
332 Now constants, for GDB, as well as macros, for static initializers.
333 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
334 Move to after the definition of struct Lisp_Char_Table,
335 since the former now needs that type defined.
336 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
337 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
338 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
339 New enums, for gdb_make_enums_visible.
340 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 341 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
342 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
343 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
344 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
345 enum maxargs, enum MAX_ALLOCA.
346 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
347 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
348 no longer needed, now that they are done in lisp.h.
349
e499d0ee
DA
3502012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Cleanup string bytes checking.
353 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
354 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
355 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
356 (check_sblock, compact_small_strings): Simplify.
357
d5040d2d
PE
3582012-07-29 Paul Eggert <eggert@cs.ucla.edu>
359
360 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
361 These macros are confusing and no longer need to be defined, as
362 the enum values now suffice. All uses replaced with definiens.
363 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
364
7f259ae6
JB
3652012-07-29 Juanma Barranquero <lekktu@gmail.com>
366
367 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
368 ($(BLD)/w32console.$(O)): Update dependencies.
369
7e63e0c3
DA
3702012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
371
372 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
373 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
374 time. Adjust users.
375 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
376
ffd817eb
JD
3772012-07-29 Jan Djärv <jan.h.d@swipnet.se>
378
379 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
380 setting sitelisp (Bug#12010).
381
417a7a0e
EZ
3822012-07-29 Eli Zaretskii <eliz@gnu.org>
383
384 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
385
386 * w32heap.c (cache_system_info):
387 * w32.c (sys_rename):
388 * w32proc.c (find_child_console, sys_kill): All users changed.
389
387d4d92
PE
3902012-07-29 Paul Eggert <eggert@cs.ucla.edu>
391
392 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
393
55a6cca6
EZ
3942012-07-29 Eli Zaretskii <eliz@gnu.org>
395
396 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
397
dbcf001c
DA
3982012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
399
400 Cleanup statistics calculation in Fgarbage_collect.
401 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
402 zombies percentage calculation. Simplify elapsed time calculation.
403
e2688e4a
DA
4042012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Generalize marker debugging code under MARKER_DEBUG and use eassert.
407 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
408 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
409 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
410 (replace_range, replace_range_2, del_range_2): Change to eassert.
411 * marker.c (byte_char_debug_check): Adjust style.
412
b46a6a83
PE
4132012-07-29 Paul Eggert <eggert@cs.ucla.edu>
414
415 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
416 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
417 long-ago-commented-out code that talks about "WIN32".
418 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
419 All uses changed.
420
e32a5799
PE
4212012-07-28 Paul Eggert <eggert@cs.ucla.edu>
422
423 Use Gnulib stdalign module (Bug#9772, Bug#9960).
424 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
425 Simplify by using alignof.
426 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
427 * lisp.h: Include <stdalign.h>.
428 (GCALIGNMENT): New macro and constant.
429 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
430 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
431 (stdalign): New macro, if not already defined.
432
df81cd29
EZ
4332012-07-28 Eli Zaretskii <eliz@gnu.org>
434
01bd1b0d
EZ
435 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
436 * w32inevt.c: Include w32inevt.h.
437 (w32_read_console_input): New inline function, calls either
438 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
439 w32_console_unicode_input.
440 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
441 (w32_kbd_patch_key, key_event): Use the codepage returned by
442 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
443 (key_event): use uChar.UnicodeChar only if
444 w32_console_unicode_input is non-zero.
445
446 * w32console.c: Include w32heap.h.
447 <w32_console_unicode_input>: New global variable.
448 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
449 family of Windows, zero otherwise.
450
451 * w32inevt.h: Declare w32_console_unicode_input.
452
df81cd29
EZ
453 * xdisp.c (init_iterator): Don't reference tip_frame in a build
454 --without-x. (Bug#11742)
455
c20fdd9e
PE
4562012-07-27 Paul Eggert <eggert@cs.ucla.edu>
457
458 Adjust GDB to reflect pvec_type changes (Bug#12036).
459 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
460 2012-07-04 changes to pseudovector representation. Problem
461 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
462
32770973 4632012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
464
465 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
466 bus address.
467 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
468
3438fe21
EZ
4692012-07-27 Eli Zaretskii <eliz@gnu.org>
470
bcfbc9de
EZ
471 * alloc.c (listn): Fix the order the arguments are consed onto the
472 list.
473
3438fe21
EZ
474 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
475 enumeration constants, as PURE and HEAP are too general, and clash
476 with other headers and sources, such as gmalloc.c and the
477 MS-Windows system headers. All users changed.
478
eeaea515
DA
4792012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
480
481 Revert last save_excursion_save and save_excursion_restore changes.
482 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
483 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
484
073c88c2
DA
4852012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Fix recently-introduced typos in Windows port.
488 Reported by Martin Rudalics <rudalics@gmx.at>.
489 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 490 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 491
4706125e
PE
4922012-07-27 Paul Eggert <eggert@cs.ucla.edu>
493
494 Improve GDB symbol export (Bug#12036).
495 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
496 arms of an 'if', not using conditional expressions; otherwise GDB
497 complains about the types in the unevaluated arm when the argument
498 is an integer literal.
499 (xgetint): Simplify expression.
500 * alloc.c (gdb_make_enums_visible): New constant. This ports to
501 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
502 Zaretskii in <http://bugs.gnu.org/12036#13>.
503 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
504 needed now that we have gdb_make_enums_visible.
505 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
506 (enum enum_USE_LSB_TAG):
507 New enum types, packaging up enums that need to be exported to GDB.
508
694b6c97
DA
5092012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Utility function to make a list from specified amount of objects.
512 * lisp.h (enum constype): New datatype.
513 (listn): New prototype.
514 * alloc.c (listn): New function.
515 (Fmemory_use_count, syms_of_alloc): Use it.
516 * buffer.c (syms_of_buffer): Likewise.
517 * callint.c (syms_of_callint): Likewise.
518 * charset.c (define_charset_internal): Likewise.
519 * coding.c (syms_of_coding): Likewise.
520 * keymap.c (syms_of_keymap): Likewise.
521 * search.c (syms_of_search): Likewise.
522 * syntax.c (syms_of_syntax): Likewise.
523 * w32.c (init_environment): Likewise.
524 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
525 * xdisp.c (syms_of_xdisp): Likewise.
526 * xfns.c (syms_of_xfns): Likewise.
527
6195f384
DA
5282012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
529
530 Fast save_excursion_save and save_excursion_restore.
531 * lisp.h (struct Lisp_Excursion): New data type.
532 (PVEC_EXCURSION): New pseudovector type.
533 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
534 to deal with it. Adjust comments.
535 (init_marker, attach_marker): New prototype.
536 (unchain_marker): Adjust prototype.
537 * marker.c (attach_marker): Change to global.
538 (init_marker): New function.
539 * alloc.c (Fmake_marker, build_marker): Use it.
540 (build_marker): More easserts.
541 (mark_object): Handle struct Lisp_Excursion.
542 * editfns.c (save_excursion_save, save_excursion_restore):
543 Reimplement to use struct Lisp_Excursion. Add comments.
544
5eceb8fb
PE
5452012-07-26 Paul Eggert <eggert@cs.ucla.edu>
546
547 Fix export of symbols to GDB (Bug#12036).
548 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
549 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
550 emacs.c, as this is a more-suitable home. Had this been done earlier
551 the fix for 12036 would have avoided some of the problems noted in
552 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
553 would have been more obvious.
562157c8
PE
554 * emacs.c: Do not include <verify.h>; no longer needed.
555 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
556 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
557 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
558 Remove; now done in lisp.h.
559 * lisp.h (PUBLISH_TO_GDB): New macro.
560 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
561 (DATA_SEG_BITS): Use it.
562 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
563 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
564 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
565 not be usable in #if. This simplifies things.
566
d6749401
JB
5672012-07-26 Juanma Barranquero <lekktu@gmail.com>
568
569 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
570
1781b9e9
PE
5712012-07-26 Paul Eggert <eggert@cs.ucla.edu>
572
d89518db 573 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
574 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
575 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
576 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
577 Adjust to changes in lisp.h and emacs.c, by using
578 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
579 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
580 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
581 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
582 instead of gdb_valbits.
583 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
584 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
585 instead of gdb_array_mark_flag.
586 (xboolvector): Get size from $->size, not $->header.size.
587 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
588 (xreload, hook-run, hookpost-run): Remove.
589 * emacs.c: Include <verify.h>.
590 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
591 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
592 Remove.
593 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
594 (gdb_USE_LSB_TAG): New enum constants.
595 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
596 Also define these as enum constants, so they're visible to GDB.
597 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
598 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
599 as constants, so they're visible to GDB.
600 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
601 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
602 Now enum constants, not macros, so they're visible to GDB.
603 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
604 more convenient now. All uses changed.
605 (VALMASK) [USE_LSB_TAG]: Also define in this case.
606 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
607
3628596a
DA
6082012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Explicitly free restriction data that are not needed anymore.
611 * editfns.c (save_restriction_restore): Free restriction data.
612
7abaf5cc
SM
6132012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
614
615 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
616 add argument, tune behavior, and adjust all callers.
617
71f88e00
PE
6182012-07-25 Paul Eggert <eggert@cs.ucla.edu>
619
620 Use typedef for EMACS_INT, EMACS_UINT.
621 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
622 than macros. This simplifies debugging in the usual case, since
623 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
624 and it allows expressions involving EMACS_INT casts.
625 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
626
57ec3034
JD
6272012-07-25 Jan Djärv <jan.h.d@swipnet.se>
628
629 * nsterm.m (ns_read_socket): Return early if there is a modal
630 window (Bug#12043).
631
8137e7b3
MR
6322012-07-25 Martin Rudalics <rudalics@gmx.at>
633
634 * frame.c (Fredirect_frame_focus): In doc-string don't mention
635 that FOCUS-FRAME can be omitted.
636
04e9897c
DA
6372012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
638
639 Adjust buffer text indirection counters at the end of Fkill_buffer.
640 * buffer.c (Fkill_buffer): Adjust indirection counters when the
641 buffer is definitely dead. This should really fix an issue reported
642 by Christoph Scholtes again. (Bug#12007).
643 (init_buffer_once): Initialize indirection counters of
644 buffer_defaults and buffer_local_symbols (for sanity and safety).
645
8a0484e1
EZ
6462012-07-24 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (init_iterator): Don't compute dimensions of truncation
649 and continuation glyphs on tooltip frames, leave them at zero.
650 Avoids continued lines in tooltips. (Bug#11832)
651
fa691a83
DA
6522012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
653
654 Simplify copy_overlay.
04e9897c 655 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
656 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
657
436bc8e0
EZ
6582012-07-23 Eli Zaretskii <eliz@gnu.org>
659
660 * print.c (print_object): Don't crash when a frame's name is nil
661 or invalid. (Bug#12025)
662
663 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
664 it signals an error when a tooltip frame is being created.
665
d7a7fda3
DA
6662012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Cleanup miscellaneous objects allocation and initialization.
669 * alloc.c (allocate_misc): Change to static. Add argument to
670 specify the subtype. Adjust comment and users.
671 (build_overlay): New function.
672 * buffer.c (copy_overlays, Fmake_overlay): Use it.
673 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
674 (allocate_misc): Remove prototype.
675 (build_overlay): Add prototype.
676
6772012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
678
679 Swap buffer text indirection counters in Fbuffer_swap_text.
680 * buffer.c (Fbuffer_swap_text): Swap indirections too.
681 This avoids crash reported by Christoph Scholtes at
682 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
683
9d7fa573
JD
6842012-07-22 Jan Djärv <jan.h.d@swipnet.se>
685
686 * nsmenu.m (Popdown_data): New struct.
687 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
688 free Popdown_data.
689 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
690 (initWithContentRect): Make imgView and contentView non-static
691 and autorelease them. Also autorelease img and matrix (Bug#12005).
692 (dealloc): Remove (Bug#12005).
693
0dd6d66d
DA
6942012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
695
696 Adjust consing_since_gc when objects are explicitly freed.
697 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
698 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
699 (free_cons, free_misc): Subtract object size from consing_since_gc.
700
d36d71df
DA
7012012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Simplify and cleanup markers positioning code.
704 * marker.c (attach_marker): More useful eassert.
705 (live_buffer, set_marker_internal): New function.
706 (Fset_marker, set_marker_restricted): Use set_marker_internal.
707 (set_marker_both, set_marker_restricted_both): Use live_buffer.
708
fb9ea40f
PE
7092012-07-22 Paul Eggert <eggert@cs.ucla.edu>
710
711 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
712 as it's limited by the amount of memory, not by INT_MAX.
713
2d5c5f7d
EZ
7142012-07-21 Eli Zaretskii <eliz@gnu.org>
715
07fb592e
EZ
716 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
717 in special-event-map. See the discussion at
718 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
719 for the reasons.
720
37a9eac8 721 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
722 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
723 Fabrice Popineau <fabrice.popineau@supelec.fr>.
724
c4328746
JD
7252012-07-21 Jan Djärv <jan.h.d@swipnet.se>
726
727 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 728 (conversationIdentifier): Return value is NSInteger.
784051c4 729 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 730
6e5d1c12
CY
7312012-07-21 Chong Yidong <cyd@gnu.org>
732
733 * window.c (decode_any_window): Signal an error if the window is
734 on a dead frame (Bug#11984).
735
9928463d
DA
7362012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
737
738 Add indirection counting to speed up Fkill_buffer.
739 * buffer.h (struct buffer): New member.
740 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
741 (Fmake_indirect_buffer): Set indirection counter to -1, increment
742 base buffer indirection counter.
743 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
744 (Fkill_buffer): Adjust indirection counters as needed, don't walk
745 through buffer list if indirection counter is 0.
746
f8643a6b
DA
7472012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
748
749 Extend the value returned by Fgarbage_collect with heap statistics.
750 * alloc.c (Qheap): New symbol.
751 (syms_of_alloc): DEFSYM it.
752 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
753 (Fmemory_free): Remove.
754 (syms_of_alloc): Don't defsubr it.
755 * buffer.c (Fcompact_buffer): Remove.
756 (syms_of_buffer): Don't defsubr it.
757
dac616ff
DA
7582012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Make maybe_gc inline.
761 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
762 * lisp.h (consing_since_gc, gc_relative_threshold)
763 (memory_full_cons_threshold): Revert declaration.
764 (maybe_gc): Remove prototype, define as inline.
765 * alloc.c: Remove old commented-out code.
766 (consing_since_gc, gc_relative_threshold)
767 (memory_full_cons_threshold): Revert to global.
768 (maybe_gc): Remove.
769
d7ea76b4
DA
7702012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
771
772 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
773 * lisp.h (build_unibyte_string): New function.
774 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
775 * sysdep.c, w32fns.c, xfns.c: Use it.
776 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
777 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
778 Adjust users accordingly.
779 * font.h (font_open_by_name): Adjust prototype.
780
765e61e3
DA
7812012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
782
783 Cleanup calls to Fgarbage_collect.
784 * lisp.h (maybe_gc): New prototype.
785 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
786 Remove declarations.
787 * alloc.c (maybe_gc): New function.
788 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
789 Make them static.
790 * bytecode.c (MAYBE_GC): Use maybe_gc.
791 * eval.c (eval_sub, Ffuncall): Likewise.
792 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
793 to avoid dependency from auto-save feature.
794
52b852c7
PE
7952012-07-19 Paul Eggert <eggert@cs.ucla.edu>
796
797 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
798 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
799 'for_each_per_buffer_object_at'.
800 All uses changed. It's better to use upper-case for macros that
801 cannot be implemented as functions, to give the reader a clue
802 that they're special.
803
5db81e33
SM
8042012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
805
806 * alloc.c (Fgarbage_collect): Tweak docstring.
807
5b835e1d
DA
8082012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Tweak the value returned from Fgarbage_collect again.
811 * alloc.c (Fgarbage_collect): New return value, as confirmed in
812 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
813 Adjust documentation.
814 (total_vector_bytes): Rename to total_vector_slots, adjust
815 accounting.
816 (total_free_vector_bytes): Rename to total_free_vector_slots,
817 adjust accounting.
818 (Qstring_bytes, Qvector_slots): New symbols.
819 (syms_of_alloc): DEFSYM them.
820
9cd47b72
DA
8212012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
822
823 Buffer compaction primitive which may be used from Lisp.
824 * buffer.c (compact_buffer, Fcompact_buffer): New function.
825 (syms_of_buffer): Register Fcompact_buffer.
826 * alloc.c (Fgarbage_collect): Use compact_buffer.
827 * buffer.h (compact_buffer): New prototype.
828 (struct buffer_text): New member.
829
d17337e5
DA
8302012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
831
832 New macro to iterate over all buffers, miscellaneous cleanups.
833 * lisp.h (all_buffers): Remove declaration.
834 * buffer.h (all_buffers): Add declaration, with comment.
835 (for_each_buffer): New macro.
836 * alloc.c (Fgarbage_collect, mark_object): Use it.
837 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
838 (init_buffer): Likewise.
839 * data.c (Fset_default): Likewise.
840 * coding.c (code_conversion_restore): Remove redundant check
841 for dead buffer.
842 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
843
60cfd278
AS
8442012-07-18 Andreas Schwab <schwab@linux-m68k.org>
845
846 Fix bug that created negative-length intervals.
847 * intervals.c (merge_interval_right, merge_interval_left):
848 Do not zero out this interval if it is absorbed by its children,
849 as this interval's total length doesn't change in that case. See
850 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
851
d06714cb
PE
8522012-07-18 Paul Eggert <eggert@cs.ucla.edu>
853
83713154
PE
854 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
855 when invoking (make-bool-vector N t) and N is a positive
856 multiple of 8 -- the last 8 bits were mistakenly cleared.
857
d06714cb
PE
858 Remove some struct layout assumptions in bool vectors.
859 * alloc.c (bool_header_size): New constant.
860 (header_size, word_size): Move earlier, as they're now used earlier.
861 Use 'word_size' in a few more places, where it's appropriate.
862 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
863 padding before the data member of a bool vector.
864 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
865 than doing the check by hand with an abort ().
866
464d5a5e
SM
8672012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
868
5fbc0409
SM
869 * eval.c (Fdefvar): Don't check constants since we only set the var if
870 it's not yet defined anyway (bug#11904).
871
464d5a5e
SM
872 * lisp.h (last_undo_boundary): Declare new var.
873 * keyboard.c (command_loop_1): Set it.
874 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
875 were auto-added by the command loop (bug#11774).
876
8dc2e44a
AS
8772012-07-18 Andreas Schwab <schwab@linux-m68k.org>
878
879 * w32font.c (Qsymbol): Remove local definition.
880 (syms_of_w32font): Don't DEFSYM it.
881
169925ec
DA
8822012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
883
884 Fix sweep_vectors to handle large bool vectors correctly.
885 * alloc.c (sweep_vectors): Account total_vector_bytes for
886 bool vectors larger than VBLOCK_BYTES_MAX.
887
5fbfb018
CY
8882012-07-18 Chong Yidong <cyd@gnu.org>
889
890 * frame.c (x_set_frame_parameters): Revert bogus change introduced
891 in 2012-05-25 commit by Paul Eggert (Bug#11738).
892
3ab6e069
DA
8932012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
894
895 Return more descriptive data from Fgarbage_collect.
896 Suggested by Stefan Monnier in
897 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
898 * alloc.c (bounded_number): New function.
899 (total_buffers, total_vectors): New variable.
900 (total_string_size): Rename to total_string_bytes, adjust users.
901 (total_vector_size): Rename to total_vector_bytes, adjust users.
902 (sweep_vectors): Account total_vectors and total_vector_bytes.
903 (Fgarbage_collect): New return value. Adjust documentation.
904 (gc_sweep): Account total_buffers.
905 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
906 (VECTOR_SIZE): Remove.
907 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
908 (Qinterval, Qmisc): New symbols.
909 (syms_of_data): Initialize them.
910 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
911 (Qcons, Qbuffer): New declarations.
912
6d02fe5b
PE
9132012-07-17 Paul Eggert <eggert@cs.ucla.edu>
914
915 * alloc.c (Fmemory_free): Account for memory-free's own storage.
916 Round up, not down. Improve doc.
917
b7ffe040
DA
9182012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
919
920 Restore old code in allocate_string_data to avoid Faset breakage.
921 Reported by Julien Danjou <julien@danjou.info> in
922 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
923 * alloc.c (allocate_string_data): Restore old code with minor
924 adjustments, fix comment to explain this subtle issue.
925
4dc7c8d5
SM
9262012-07-17 Eli Zaretskii <eliz@gnu.org>
927
928 Remove FILE_SYSTEM_CASE.
929 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
930
931 * fileio.c (FILE_SYSTEM_CASE): Don't define.
932 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
933 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
934 call-process-region passes it through expand-file-name.
935
936 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
937
9382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
939
940 Fix crash when creating indirect buffer (Bug#11917)
941 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
942 Don't handle unbound variables specially if non-zero.
943 (Fbuffer_local_variables): Pass zero.
944 (clone_per_buffer_values): Pass non-zero.
945
9462012-07-17 Andreas Schwab <schwab@linux-m68k.org>
947
948 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
949 to make the loop interruptible.
950
9512012-07-17 Andreas Schwab <schwab@linux-m68k.org>
952
953 * gnutls.c (emacs_gnutls_handshake): Only retry if
954 GNUTLS_E_INTERRUPTED.
955
cce7fefc
DA
9562012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
957
958 Cleanup and convert miscellaneous checks to eassert.
959 * alloc.c (mark_interval): Fix comment, partially rephrase
960 old comment from intervals.h (see below).
961 * intervals.c (find_interval, adjust_intervals_for_insertion)
962 (delete_interval, adjust_intervals_for_deletion)
963 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
964 Convert to eassert.
965 (adjust_intervals_for_insertion, make_new_interval):
966 Remove obsolete and unused code.
967 * intervals.h (struct interval): Remove obsolete comment.
968 * textprotp.c (erase_properties): Remove unused code.
969 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
970 (Fremove_list_of_text_properties): Convert to eassert.
971
9ea10cc3
CY
9722012-07-17 Chong Yidong <cyd@gnu.org>
973
974 * editfns.c (Finsert_char): Doc fix.
975
3900d5de
DA
9762012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
977
978 Fix previous change to make Fmemory_free always accurate.
979 * alloc.c (make_interval): Update total_free_intervals.
980 (make_float): Likewise for total_free_floats.
981 (free_cons, Fcons): Likewise for total_free_conses.
982 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
983 Likewise for total_free_vector_bytes.
984 (Fmake_symbol): Likewise for total_free_symbols.
985 (bytes_free): Remove.
986
7098646f
DA
9872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
988
989 Simple free memory accounting feature.
990 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
991 (sweep_vectors): Accumulate size of free vectors.
992 (Fgarbage_collect): Setup bytes_free.
993 (Fmemory_free): New function.
994 (syms_of_alloc): Register it.
995
22657b40
DA
9962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
997
998 Cleanup overlays checking.
999 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1000 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1001 eassert and OVERLAYP.
1002 (sort_overlays): Change to use OVERLAYP.
1003
ddfc8813
RK
10042012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1005
1006 * editfns.c (Finsert_char): Make it interactive, and make the
1007 second arg optional. Copy interactive spec and docstring from
1008 ucs-insert.
1009
7c26cf3c
PE
10102012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1013 Unlike the other wrapped functions, fabs has an unspecified
1014 effect on errno.
1015
5d127af9
JD
10162012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * nsterm.m (keyDown): Interpret flags without left/right bits
1019 as the left key (Bug#11670).
1020
6a0dd1d7
DA
10212012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1022
1023 Remove empty and useless init functions.
1024 * lisp.h (init_character_once, init_fns, init_image)
1025 (init_filelock, init_sound): Remove prototype.
1026 * character.c (init_character_once): Remove.
1027 * filelock.c (init_filelock): Likewise.
1028 * fns.c (init_fns): Likewise.
1029 * image.c (init_image): Likewise.
1030 * sound.c (init_sound): Likewise.
1031 * emacs.c (main): Adjust accordingly.
1032
7a6136fd
DA
10332012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1034
1035 * gtkutil.h: Tiny cleanups.
1036 (use_old_gtk_file_dialog): Remove useless declaration.
1037 (xg_uses_old_file_dialog): Add suggested const attribute.
1038
ce811ad9
EZ
10392012-07-15 Eli Zaretskii <eliz@gnu.org>
1040
1041 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1042 (bidi_paragraph_init): Use it to limit search forward for a strong
1043 directional character in abnormally large paragraphs full of
1044 neutral or weak characters. (Bug#11943)
1045
c9adfeaa
SF
10462012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1047
1048 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1049 the toolbar (Bug#9451).
1050 (xg_make_tool_item): Give the widget event box a transparent
1051 background.
1052
fff62aa9
DA
10532012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Cleanup basic allocation variables and functions.
1056 * alloc.c (ignore_warnings, init_intervals, init_float)
1057 (init_cons, init_symbol, init_marker): Remove.
1058 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1059 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1060 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1061 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1062 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1063 (staticidx, init_alloc_once, init_strings, free_ablock):
1064 Remove redundant initialization.
1065 * fns.c (init_weak_hash_tables): Remove.
1066 * lisp.h (init_weak_hash_tables): Remove prototype.
1067
9730daca
DA
10682012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1069
1070 Use zero_vector where appropriate.
1071 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1072 accordingly.
1073 * lisp.h (zero_vector): New declaration.
1074 * font.c (null_vector): Remove.
1075 (syms_of_font): Remove initialization and staticpro.
1076 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1077 * keymap.c (Faccessible_keymaps): Likewise.
1078
2e2d2a13
LL
10792012-07-15 Leo Liu <sdl.web@gmail.com>
1080
1081 * fringe.c: Fix typo in comments.
1082
cd276f6e
LL
10832012-07-14 Leo Liu <sdl.web@gmail.com>
1084
1085 * fringe.c: Add a new bitmap exclamation-mark.
1086
5a1131d9
EZ
10872012-07-14 Eli Zaretskii <eliz@gnu.org>
1088
1089 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1090
1091 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1092 (HAVE_MENUS): Don't define, defined by editing config.in with
1093 msdos/sed2v2.inp.
1094 (GMALLOC_INHIBIT_VALLOC): Don't define.
1095 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1096
22e983b7
JB
10972012-07-14 Juanma Barranquero <lekktu@gmail.com>
1098
1099 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1100
5b3f250f
GM
11012012-07-14 Glenn Morris <rgm@gnu.org>
1102
1103 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1104 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1105 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1106
33d63ff4
GM
11072012-07-13 Glenn Morris <rgm@gnu.org>
1108
5b633342
GM
1109 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1110
33d63ff4
GM
1111 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1112 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1113
b55b9f85
JD
11142012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1115
0dc8cf50
JD
1116 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1117 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1118 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1119 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1120 where appropriate.
1121 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1122 as boolean expression.
1123 (x_set_window_size): Remove unused variable toolbar.
1124 (ns_get_color_default, ns_mod_to_lisp): Remove.
1125 (ns_mouse_position): Remove unused variables xchar and ychar.
1126 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1127 (ns_set_vertical_scroll_bar): Remove unused variable count.
1128 (ns_delete_terminal): Remove unused variable i.
1129 (ns_term_init): Remove unused variables r, g and b.
1130 (mouseDown): Remove unused variable window.
1131 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1132 (initFrameFromEmacs): Remove unused variable vbextra.
1133 (mouseEntered): Remove unused variables p and dpyinfo.
1134 (mouseExited): Remove unused variables p and r.
1135 (ns_define_frame_cursor, ns_clear_frame_area)
1136 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1137 (menuDown): Assign [sender tag] to variable and cast the variable.
1138
1139 * nsterm.h (menuDown): Add id as type to argument sender.
1140 (ns_display_info_for_name): Add Lisp_Object argument.
1141 (ns_term_init): Add Lisp_Object argument.
1142 (ns_map_event_to_object): Add void argument.
1143 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1144 prototype with arguments and only declare if __OBJC__.
1145 (nxatoms_of_nsselect): Add void argument.
1146 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1147 (ns_alloc_autorelease_pool): Add void argument.
1148 (ns_release_autorelease_pool): Add void* argument.
1149 (ns_get_defaults_value): Add const char* argument.
1150
1151 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1152 (initFromContents): Use SSDATA where appropriate.
1153 (ns_update_menubar): Add braces to ambigous if-else.
1154 (initWithTitle): Put () around assignment in if statement.
1155 (ns_menu_show): Remove unused variables window and keymap.
1156 (update_frame_tool_bar): Remove unused variable selected_p.
1157 (initWithContentRect): Remove unused variable this_cmd_name.
1158
1159 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1160 appropriate.
1161 (setXBMColor): Remove unused variable len.
1162 (setPixmapData): Put () around assignment in loop statement.
1163
1164 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1165 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1166 where appropriate.
1167 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1168 around assignment in loop statement.
1169 (nsfont_open): Remove unused variable i.
1170 (nsfont_open): Remove unused variable len.
1171 (nsfont_draw): Remove unused variable cs.
1172
1173 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1174 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1175 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1176 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1177 (Fns_font_name, Fns_perform_service)
1178 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1179 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1180 (ns_set_name): Remove unused variable view.
1181 (x_set_menu_bar_lines): Remove unused variable olines.
1182 (x_set_tool_bar_lines): Remove unused variable root_window.
1183 (Fns_list_colors): Put () around assignment in while statement.
1184 (Fns_perform_service): Remove unused variable len.
1185 (Fns_display_usable_bounds): Remove unused variable top.
1186 (syms_of_nsfns): Remove unused variable i.
1187
b55b9f85
JD
1188 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1189 memcpy (Bug#11907).
1190
ed9265fc 11912012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1192
1193 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1194 and free it with DestroyExceptionInfo (Bug#11558).
1195
ef099b57
JB
11962012-07-13 Juanma Barranquero <lekktu@gmail.com>
1197
1198 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1199 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1200 Set here, not in nt/config.nt.
1201
ea814a5d
EZ
12022012-07-13 Eli Zaretskii <eliz@gnu.org>
1203
1204 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1205 cursor overflow into the last glyph on display line when the right
1206 fringe is off. (Bug#11832)
1207
1a952767
PE
12082012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 * xdisp.c (produce_special_glyphs): Now static.
1211 * dispextern.h (produce_special_glyphs): Remove decl.
1212
983188fd
GM
12132012-07-13 Glenn Morris <rgm@gnu.org>
1214
8d7c7eed 1215 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1216 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1217
983188fd
GM
1218 * s/usg5-4-common.h (USG, USG5):
1219 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1220 * s/sol2-6.h (SOLARIS2):
1221 * s/irix6-5.h (IRIX6_5):
1222 * s/hpux10-20.h (USG, USG5, HPUX):
1223 * s/gnu-linux.h (USG, GNU_LINUX):
1224 * s/freebsd.h (BSD_SYSTEM):
1225 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1226 * s/cygwin.h (CYGWIN):
1227 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1228 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1229
d1e68667 12302012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1231
1232 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1233
6de0e799
GM
12342012-07-13 Glenn Morris <rgm@gnu.org>
1235
739ae010
GM
1236 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1237
dbee5793
GM
1238 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1239
6de0e799
GM
1240 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1241 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1242
b82da769
GM
12432012-07-12 Glenn Morris <rgm@gnu.org>
1244
4fae5a7a 1245 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1246
1247 * process.c (init_process_emacs): Rename from init_process.
1248 The old name is also the name of a Mach system call.
1249 * lisp.h, emacs.c: Update for this name change.
1250 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1251 longer needed.
1252
5a979817
EZ
12532012-07-12 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1256 memmove call that removes glyphs covered by the left truncation
1257 glyph. Improve commentary.
1258 (display_line): Fix display of continuation glyphs on GUI frames
1259 when the right fringe is turned off and variable-size fonts are
1260 used in the window. Move the code that appends a stretch glyph to
1261 produce_special_glyphs, so that it could be used for truncation
1262 and continuation glyphs alike.
1263 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1264 glyph of a suitably computed width, to align the special glyphs at
1265 the window margin. Code moved from display_line. (Bug#11832)
1266
3e91a053
GM
12672012-07-12 Glenn Morris <rgm@gnu.org>
1268
ba9e4b84
GM
1269 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1270
1271 * s/gnu-linux.h, s/hpux10-20.h:
1272 Do not unconditionally define HAVE_XRMSETDATABASE.
1273
3e91a053
GM
1274 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1275
b300b1f4
PE
12762012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 Fix typos that broke OS X build.
1279 Reported by Randal L. Schwartz in
1280 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1281 * nsterm.m (ns_timeout): Add missing local decl.
1282 (ns_get_color): snprintf -> sprintf, to fix typo.
1283
6e777848
GM
12842012-07-12 Glenn Morris <rgm@gnu.org>
1285
3f922c37
GM
1286 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1287 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1288 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1289 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1290
0ab7b23a
GM
1291 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1292 Move PTY_OPEN to configure.
1293
6e777848
GM
1294 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1295 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1296 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1297
4a7edc24
DA
12982012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 Use empty_unibyte_string where applicable.
1301 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1302 * lread.c (read1): Likewise.
1303 * xsettings.c (syms_of_xsettings): Likewise.
1304
308aab79
GM
13052012-07-12 Glenn Morris <rgm@gnu.org>
1306
42bd1719
GM
1307 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1308 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1309 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1310 * s/hpux10-20.h (RUN_TIME_REMAP):
1311 * s/bsd-common.h (TABDLY): Move to configure.
1312
1313 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1314
1315 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1316
ea0bbd17 1317 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1318 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1319
1320 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1321
308aab79
GM
1322 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1323 * s/template.h: Move NARROWPROTO to configure.
1324
ee1cf5cf
GM
13252012-07-11 Glenn Morris <rgm@gnu.org>
1326
30fe9bf4
GM
1327 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1328 unused since 2011-01-17 change to systty.h.
1329
ee1cf5cf
GM
1330 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1331 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1332 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1333
63e47e07
PE
13342012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1337
c43fb4c3
GM
13382012-07-11 Glenn Morris <rgm@gnu.org>
1339
1340 * s/darwin.h, s/gnu-linux.h, s/template.h:
1341 Move INTERRUPT_INPUT to configure.
1342
e8df9267
DA
13432012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1344
1345 Minor adjustments to interning code.
1346 * lisp.h (intern, intern_c_string): Redefine as static inline
1347 wrappers for intern_1 and intern_c_string_1, respectively.
1348 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1349 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1350 Vobarray checking.
e8df9267
DA
1351 * font.c (font_intern_prop): Likewise. Adjust comment.
1352 * w32font.c (intern_font_name): Likewise.
1353
34348bd4
AS
13542012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1355
d96a1e0c
AS
1356 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1357
34348bd4
AS
1358 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1359 of Fcar/Fcdr if possible.
1360 * font.c (check_otf_features): Likewise.
1361 * fontset.c (Fnew_fontset): Likewise.
1362 * gnutls.c (Fgnutls_boot): Likewise.
1363 * minibuf.c (read_minibuf): Likewise.
1364 * msdos.c (IT_set_frame_parameters): Likewise.
1365 * xmenu.c (Fx_popup_dialog): Likewise.
1366 * w32menu.c (Fx_popup_dialog): Likewise.
1367
c8add24e
GM
13682012-07-11 Glenn Morris <rgm@gnu.org>
1369
4b575b3c
GM
1370 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1371 since nothing has defined it on these platforms.
1372
09f4e3b0
GM
1373 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1374 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1375
172bedef
GM
1376 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1377 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1378 Move CLASH_DETECTION to configure.
1379
249685df
GM
1380 * s/gnu.h: Remove file, which is now empty.
1381
c8add24e
GM
1382 * s/gnu.h, s/gnu-linux.h:
1383 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1384
b41253a3
JW
13852012-07-11 John Wiegley <johnw@newartisans.com>
1386
1387 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1388 function attribute, so we only use it if it exists in the
1389 compiler.
1390
d923b542
DA
13912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1392
1393 Avoid call to strlen in fast_c_string_match_ignore_case.
1394 * search.c (fast_c_string_match_ignore_case): Change to use
1395 length argument. Adjust users accordingly.
1396 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1397
5ebbef1d
PE
13982012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1399
bb352260
PE
1400 Assume mkdir, rmdir.
1401 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1402 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1403
57054ddd
PE
1404 Assume rename.
1405 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1406
b747d3f7
PE
1407 Assume perror.
1408 * s/hpux10-20.h (HAVE_PERROR): Remove.
1409 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1410 Remove dummy definition, as this problem was obsolete long ago.
1411
5ebbef1d
PE
1412 Assume strerror.
1413 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1414
984e7f30
DA
14152012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 Avoid calls to strlen in font processing functions.
1418 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1419 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1420 users accordingly.
d923b542
DA
1421 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1422 Adjust prototypes.
1423 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1424 Change to return ptrdiff_t.
984e7f30
DA
1425 (xfont_list_pattern, xfont_match): Use length returned by
1426 xfont_decode_coding_xlfd.
1427 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1428
20e94fdd
GM
14292012-07-11 Glenn Morris <rgm@gnu.org>
1430
9d596af3
GM
1431 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1432 Move DONT_REOPEN_PTY to configure.
1433
20e94fdd
GM
1434 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1435 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1436
e99a530f
PE
14372012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1438
22ffb973
PE
1439 Remove "#define unix" that is no longer needed (Bug#11905).
1440 * s/aix4-2.h (unix): Remove; no longer needed.
1441
e9a9ae03
PE
1442 EMACS_TIME simplification (Bug#11875).
1443 This replaces macros (which typically do not work in GDB)
1444 with functions, typedefs and enums, making the code easier to debug.
1445 The functional style also makes code easier to read and maintain.
1446 * systime.h: Include <sys/time.h> on all hosts, not just if
1447 WINDOWSNT, since 'struct timeval' is needed in general.
1448 (EMACS_TIME): Now a typedef, not a macro.
1449 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1450 not macros.
1451 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1452 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1453 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1454 (EMACS_TIME_LE): Now functions, not macros.
1455 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1456 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1457 which are not functions. All uses rewritten to use:
1458 (make_emacs_time): New function.
1459 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1460 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1461 not functions. All uses rewritten to use the following, respectively:
1462 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1463 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1464 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1465 * fileio.c (Fcopy_file):
1466 * xterm.c (XTflash): Get the current time closer to when it's used.
1467 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1468
ffacb126
PE
1469 * bytecode.c (targets): Suppress -Woverride-init warnings.
1470
e99a530f
PE
1471 Simplify by avoiding confusing use of strncpy etc.
1472 * doc.c (Fsnarf_documentation):
1473 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1474 * frame.c (Fmake_terminal_frame):
1475 * gtkutil.c (get_utf8_string):
1476 * lread.c (openp):
1477 * nsmenu.m (ns_update_menubar):
1478 * regex.c (regerror):
1479 Prefer memcpy to strncpy and strncat when either will do.
1480 * fileio.c (Fsubstitute_in_file_name):
1481 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1482 (menu_separator_name_p):
1483 * nsmenu.m (ns_update_menubar):
1484 Prefer memcmp to strncmp when either will do.
1485 * nsterm.m: Include <ftoastr.h>.
1486 (ns_get_color):
1487 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1488 Prefer snprintf to strncpy.
1489 * nsterm.m (ns_term_init):
1490 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1491 * nsterm.m (ns_term_init):
1492 Avoid the need for strncpy, by using build_string or
1493 make_unibyte_string directly. Use dtoastr, not snprintf.
1494 * process.c (Fmake_network_process): Diagnose service names that
1495 are too long, rather than silently truncating them or creating
1496 non-null-terminated names.
1497 (Fnetwork_interface_info): Likewise, for interface names.
1498 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1499 Prefer sprintf to strncat.
1500 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1501 Prefer vsnprintf to vsprintf + strncpy.
1502
c59592b3
GM
15032012-07-10 Glenn Morris <rgm@gnu.org>
1504
1505 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1506 Clarify fallback case.
1507
7d7bbefd
DA
15082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1509
1510 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1511 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1512 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1513 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1514 where argument type is known to be a Lisp_Cons.
1515
3a4c8000
TT
15162012-07-10 Tom Tromey <tromey@redhat.com>
1517
1518 * bytecode.c (BYTE_CODE_THREADED): New macro.
1519 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1520 (enum byte_code_op): New type.
1521 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1522 (exec_byte_code): Use them. Use token threading when applicable.
1523
2a0213a6
DA
15242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 Optimize pure C strings initialization.
1527 * lisp.h (make_pure_string): Fix prototype.
1528 (build_pure_c_string): New function, defined as static inline. This
1529 provides a better opportunity to optimize away calls to strlen when
1530 the function is called with compile-time constant argument.
1531 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1532 argument, adjust users accordingly. Use build_pure_c_string where
1533 appropriate.
1534 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1535 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1536 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1537
cb1caeaf
DA
15382012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Avoid calls to strlen in miscellaneous functions.
1541 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1542 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1543 * lread.c (openp): Likewise.
1544
c293e30c
DA
15452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1546
1547 Avoid calls to strlen in path processing functions.
1548 * fileio.c (file_name_as_directory): Add comment. Change to add
1549 srclen argument and return the length of result. Adjust users
1550 accordingly.
1551 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1552 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1553 users accordingly.
1554 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1555
9e059e3f
GM
15562012-07-10 Glenn Morris <rgm@gnu.org>
1557
d02eb359
GM
1558 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1559 Move PENDING_OUTPUT_COUNT definition to configure.
1560
882cf227
GM
1561 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1562 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1563 * s/gnu.h (DATA_START): Move definitions to configure.
1564
af6e839f
GM
1565 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1566 We include usg5-4-common.h, which defines them both.
1567
40289a12
GM
1568 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1569 O_RDONLY already includes it).
1570
9e059e3f
GM
1571 Stop ns builds setting the EMACSLOADPATH environment variable.
1572 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1573 Now it does not set EMACSLOADPATH, just returns the load-path string.
1574 * nsterm.h: Update accordingly.
1575 * lread.c [HAVE_NS]: Include nsterm.h.
1576 (init_lread) [HAVE_NS]: Use ns_load_path.
1577 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1578
7c4e8ec0
GM
15792012-07-09 Glenn Morris <rgm@gnu.org>
1580
d4f600ff
GM
1581 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1582 since the included bsd-common.h does so.
1583
cbb31951
GM
1584 Stop ns builds setting the EMACSPATH environment variable.
1585 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1586 (ns_init_paths): Do not set EMACSPATH.
1587 * nsterm.h (ns_exec_path): Add it.
1588 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1589 Use ns_exec_path.
1590
7c4e8ec0
GM
1591 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1592
26bccfae
PE
15932012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1594
a0bee46f
PE
1595 * process.c (wait_reading_process_output): 'waitchannels' was unset
1596 when read_kbd || !NILP (wait_for_cell); fix this.
1597
5994c183
PE
1598 Add GCC-style 'const' attribute to functions that can use it.
1599 * character.h (char_resolve_modifier_mask):
1600 * keyboard.h (make_ctrl_char):
1601 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1602 (init_character_once, next_almost_prime, init_fns, init_image)
1603 (flush_pending_output, init_sound):
1604 * mem-limits.h (start_of_data):
1605 * menu.h (finish_menu_items):
1606 Add ATTRIBUTE_CONST.
1607 * emacs.c (DEFINE_DUMMY_FUNCTION):
1608 Declare the dummy function with ATTRIBUTE_CONST.
1609 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1610 Add decls with ATTRIBUTE_CONST.
1611
26bccfae
PE
1612 Minor improvements to make_formatted_string.
1613 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1614 where int is good enough, as vsprintf returns an int.
1615 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1616
a8290ec3
DA
16172012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1618
1619 Use make_formatted_string to avoid double length calculation.
1620 * lisp.h (make_formatted_string): New prototype.
1621 * alloc.c (make_formatted_string): New function.
1622 * buffer.c (Fgenerate_new_buffer_name): Use it.
1623 * dbus.c (syms_of_dbusbind): Likewise.
1624 * editfns.c (Fcurrent_time_zone): Likewise.
1625 * filelock.c (get_boot_time): Likewise.
1626 * frame.c (make_terminal_frame, set_term_frame_name)
1627 (x_report_frame_params): Likewise.
1628 * image.c (gs_load): Likewise.
1629 * minibuf.c (get_minibuffer): Likewise.
1630 * msdos.c (dos_set_window_size): Likewise.
1631 * process.c (make_process): Likewise.
1632 * xdisp.c (ensure_echo_area_buffers): Likewise.
1633 * xsettings.c (apply_xft_settings): Likewise.
1634
d01ba2f1
GM
16352012-07-09 Glenn Morris <rgm@gnu.org>
1636
1637 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1638 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1639 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1640 * nsterm.h (ns_etc_directory): Add it.
1641 * callproc.c [HAVE_NS]: Include nsterm.h.
1642 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1643
f1f924b6
DA
16442012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1645
1646 Move marker debugging code under MARKER_DEBUG.
1647 * marker.c (MARKER_DEBUG): Move marker debugging code under
1648 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1649 for bootstrap with --enable-checking (~3x slowdown reported
1650 by Juanma Barranquero <lekktu@gmail.com>).
1651 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1652
ab531b66
PE
16532012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1656 See <http://bugs.gnu.org/11825#29>.
1657
c4b3bc8a
EZ
16582012-07-08 Eli Zaretskii <eliz@gnu.org>
1659
1660 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1661 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1662 (display_line): Add commentary about displaying truncation glyphs
1663 on GUI frames.
1664 (produce_special_glyphs): Move here from term.c.
1665
1666 * term.c (produce_special_glyphs): Move to xdisp.c.
1667
1668 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1669 section.
c4b3bc8a 1670
b676b881
AS
16712012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1672
f17c5273
AS
1673 * xdisp.c (display_line): Avoid warning about implicit declaration
1674 of FRAME_FONT.
1675
298819b9
AS
1676 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1677
b676b881
AS
1678 * lisp.h: Remove empty conditional.
1679
6045c4fd
PE
16802012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1681
b3350bf9
PE
1682 * lread.c (load_path_check): Now static.
1683
6045c4fd
PE
1684 Fix some minor --with-ns problems found by static checking.
1685 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1686 (x_set_font) [!HAVE_X_WINDOWS]:
1687 * image.c (xpm_load_image) [HAVE_NS]:
1688 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1689 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1690 Remove unused local.
1691 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1692 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1693 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1694 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1695 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1696 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1697 Fix pointer signedness problem.
1698 * xfaces.c (FRAME_X_FONT_TABLE):
1699 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1700
929e7845
GM
17012012-07-07 Glenn Morris <rgm@gnu.org>
1702
1703 * lread.c (load_path_check): New function, split from init_lread.
1704 (init_lread): Reorganize. Motivation:
1705 If EMACSLOADPATH is set, check/warn about that rather than the
1706 defaults, which we are not going to use. Hence we can remove
1707 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1708 Don't warn if site-lisp directories are missing.
1709 If not installed, start from a blank load-path, since
1710 PATH_LOADSEARCH refers to the eventual installation directories.
1711
58dd0aa4
EZ
17122012-07-07 Eli Zaretskii <eliz@gnu.org>
1713
1714 Support truncation and continuation glyphs on GUI frames, when
1715 fringes are disabled. (Bug#11832)
1716 * xdisp.c (init_iterator): Get dimensions of truncation and
1717 continuation glyphs even if on GUI frames. Adjust
1718 it->last_visible_x on GUI frames when the left or right fringes,
1719 or both, are absent.
1720 (start_display, move_it_in_display_line_to): Handle the case of a
1721 GUI frame without a fringe to display continuation or truncation
1722 glyphs.
1723 (insert_left_trunc_glyphs): Support GUI frames: make sure
1724 truncation glyphs overwrite enough glyphs from the current line to
1725 have sufficient space in pixels.
1726 (display_line): Support truncation and continuation glyphs on GUI
1727 frames. If some spare pixels are left on the line after inserting
1728 the truncation glyphs, fill that space with a stretch glyph of a
1729 suitably computed width.
1730
1731 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1732 produce_glyphs, to support GUI sessions.
1733
31571fd7
PE
17342012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1735
5a16b9bc
PE
1736 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1737
f3047c75
PE
1738 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1739
31571fd7
PE
1740 Do not require float-time's arg to fit in time_t (Bug#11825).
1741 This works better on hosts where time_t is unsigned, and where
1742 float-time is applied to the (negative) difference between two times.
1743 * editfns.c (decode_time_components): Last arg is now double *,
1744 not int *, and means to store all the result as a double, without
1745 worrying about whether the seconds part fits in time_t.
1746 All callers changed.
1747 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1748 All callers changed.
1749 (Ffloat_time): Do not fail merely because the specified time falls
1750 outside of time_t range.
1751
4516fbef
GM
17522012-07-07 Glenn Morris <rgm@gnu.org>
1753
1754 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1755 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1756 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1757
07adc2c6
JB
17582012-07-07 Juanma Barranquero <lekktu@gmail.com>
1759
1760 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1761 Update dependencies.
1762
1763 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1764
fd573f31
PE
17652012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1766
fee5959d
PE
1767 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1768 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1769 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1770 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1771 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1772 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1773
fd573f31
PE
1774 * xfont.c (compare_font_names): Redo to omit the need for casts.
1775
ddadbc0e
AS
17762012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1777
fca8d6b6
AS
1778 * xfns.c (Fx_change_window_property): Doc fix.
1779 * w32fns.c (Fx_change_window_property): Doc fix.
1780
ddadbc0e
AS
1781 * w32fns.c (Fx_window_property): Accept the same arguments as the
1782 X Windows version. Doc fix.
1783 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1784
ed9265fc 17852012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1786 Eli Zaretskii <eliz@gnu.org>
1787
1788 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1789 Windows-specific code from nt/config.nt moved here.
1790 Obsolete settings removed.
1791
216ee680
PE
17922012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * process.c: Avoid unnecessary calls to gettime.
1795 (wait_reading_process_output): Don't get the time of day
1796 when gobbling data immediately and not waiting, as there's no need
1797 for it in that case. This removes a FIXME.
1798
bdd091e4
JD
17992012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1800
1801 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1802 is defined (Bug#11768).
1803
9d44f8ce
DA
18042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 Fix marker debugging code.
1807 * marker.c (byte_char_debug_check): Do not perform the check
1808 if buffer is not multibyte.
090bd7cb
JB
1809 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1810 Call byte_char_debug_check with correct arguments.
9d44f8ce 1811
90fc4786
DA
18122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1813
1814 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1815 * marker.c (byte_char_debug_check, count_markers):
1816 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1817 (byte_debug_flag): Remove.
1818 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1819 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1820
7b7ae965
DA
18212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1822
4e57b342
DA
1823 Avoid code repetition in marker-related functions.
1824 * marker.c (attach_marker): New function.
1825 (Fset_marker, set_marker_restricted, set_marker_both)
1826 (set_marker_restricted_both): Use it.
1827 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1828 Consistently rename charno to charpos.
1829 (marker_position): Add eassert.
1830 (marker_byte_position): Convert to eassert.
1831
18322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1833
1834 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1835 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1836 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1837
657924ff
DA
18382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1839
1840 Introduce fast path for the widely used marker operation.
1841 * alloc.c (build_marker): New function.
1842 * lisp.h (build_marker): New prototype.
1843 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1844 * composite.c (autocmp_chars): Likewise.
1845 * editfns.c (buildmark): Remove.
1846 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1847 (save_restriction_save): Use build_marker.
1848 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1849 * window.c (save_window_save): Likewise.
1850
041a49a6
DA
18512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1852
1853 Do not use Fdelete_overlay in delete_all_overlays
1854 to avoid redundant calls to unchain_overlay.
1855 * buffer.c (drop_overlay): New function.
1856 (delete_all_overlays, Fdelete_overlay): Use it.
1857 * minibuf.c (get_minibuffer): Fix comment.
1858
7dca65a4
PE
18592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Port to OpenBSD 5.1 amd64.
1862 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1863 This is needed for OpenBSD, and should be harmless on all BSD systems.
1864 Also, include <sys/sysctl.h>, as it should be available on all
1865 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1866 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1867 use p_pid member, not kp_proc.pid.
1868
8eb876e2
GM
18692012-07-06 Glenn Morris <rgm@gnu.org>
1870
1871 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1872
38182d90
PE
18732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 More xmalloc and related cleanup.
1876 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1877 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1878 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1879 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1880 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1881 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1882 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1883 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1884 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1885 * xterm.c:
1886 Omit needless casts involving void * pointers and allocation.
1887 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1888 as the former is more robust if P's type is changed.
1889 Prefer xzalloc to xmalloc + memset 0.
1890 Simplify malloc-or-realloc to realloc.
1891 Don't worry about xmalloc returning a null pointer.
1892 Prefer xstrdup to xmalloc + strcpy.
1893 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1894 growing it.
1895 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1896 alloca of a constant.
1897
6dd5a677
EZ
18982012-07-05 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1901 hscroll is larger than the line width. Fixes long and futile
1902 looping inside extend_face_to_end_of_line (on a TTY) producing
1903 glyphs that are not needed and thrown away.
1904
6b312f0f
DA
19052012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 * marker.c (set_marker_restricted_both): Simplify by using
1908 clip_to_bounds.
1909
f520ef9b
PE
19102012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1913
383b7c95
JD
19142012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1915
1916 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1917 not defined (Bug#11768).
1918 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1919 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1920 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1921 followed by gtk_box_set_homogeneous (Bug#11768).
1922 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1923 (update_theme_scrollbar_width, xg_create_scroll_bar):
1924 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1925 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1926 (is_box_type): New function (Bug#11768).
1927 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1928 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1929 with default display (Bug#11768).
1930
d6e7bf45
EZ
19312012-07-05 Eli Zaretskii <eliz@gnu.org>
1932
1933 * xdisp.c (window_hscroll_limited): New function.
1934 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1935 coordinates when window's hscroll is set to insanely large
1936 values. (Bug#11857)
1937
431391ec
JB
19382012-07-05 Juanma Barranquero <lekktu@gmail.com>
1939
1940 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1941 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1942
23f86fce
DA
19432012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 Cleanup xmalloc.
1946 * lisp.h (xzalloc): New prototype. Omit needless casts.
1947 * alloc.c (xzalloc): New function. Omit needless casts.
1948 * charset.c: Omit needless casts. Convert all calls to
1949 xmalloc with following memset to xzalloc.
1950 * dispnew.c: Likewise.
1951 * fringe.c: Likewise.
1952 * image.c: Likewise.
1953 * sound.c: Likewise.
1954 * term.c: Likewise.
1955 * w32fns.c: Likewise.
1956 * w32font.c: Likewise.
1957 * w32term.c: Likewise.
1958 * xfaces.c: Likewise.
1959 * xfns.c: Likewise.
1960 * xterm.c: Likewise.
1961 * atimer.c: Omit needless casts.
1962 * buffer.c: Likewise.
1963 * callproc.c: Likewise.
1964 * ccl.c: Likewise.
1965 * coding.c: Likewise.
1966 * composite.c: Likewise.
1967 * doc.c: Likewise.
1968 * doprnt.c: Likewise.
1969 * editfns.c: Likewise.
1970 * emacs.c: Likewise.
1971 * eval.c: Likewise.
1972 * filelock.c: Likewise.
1973 * fns.c: Likewise.
1974 * gtkutil.c: Likewise.
1975 * keyboard.c: Likewise.
1976 * lisp.h: Likewise.
1977 * lread.c: Likewise.
1978 * minibuf.c: Likewise.
1979 * msdos.c: Likewise.
1980 * print.c: Likewise.
1981 * process.c: Likewise.
1982 * region-cache.c: Likewise.
1983 * search.c: Likewise.
1984 * sysdep.c: Likewise.
1985 * termcap.c: Likewise.
1986 * terminal.c: Likewise.
1987 * tparam.c: Likewise.
1988 * w16select.c: Likewise.
1989 * w32.c: Likewise.
1990 * w32reg.c: Likewise.
1991 * w32select.c: Likewise.
1992 * w32uniscribe.c: Likewise.
1993 * widget.c: Likewise.
1994 * xdisp.c: Likewise.
1995 * xmenu.c: Likewise.
1996 * xrdb.c: Likewise.
1997 * xselect.c: Likewise.
1998
0497dc44
PE
19992012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * fileio.c (time_error_value): Check the right error number.
2002 Problem reported by Troels Nielsen in
2003 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2004
356e7178
PE
20052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2006
4e71fd89
PE
2007 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2008 This should be fixed in a better way; see Eli Zaretskii in
2009 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2010 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2011
f0941253
PE
2012 * fileio.c (time_error_value): Rename from special_mtime.
2013 The old name's problems were noted by Eli Zaretskii in
2014 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2015
065c9eb4
PE
2016 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2017 This variable's comment says Emacs needs at least one GDB-visible
2018 symbol of type enum pvec_type, to work around GDB problems.
2019 The symbol's value doesn't matter.
2020
356e7178
PE
2021 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2022 that causes compilation to fail on pre-C99 compilers.
2023
ed9265fc 20242012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2025
2026 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2027 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2028
3884d954
DA
20292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2030
d209e2fb 2031 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2032 headers for buffer_defaults and buffer_local_symbols.
2033 Reported by Juanma Barranquero <lekktu@gmail.com>.
2034
ee28be33
SM
20352012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2036
2037 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2038 * lisp.h (enum pvec_type): Use fewer bits.
2039 (PSEUDOVECTOR_SIZE_BITS): New constant.
2040 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2041 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2042 change in pvec_type.
2043 (PSEUDOVECTOR_TYPEP): New macro.
2044 (TYPED_PSEUDOVECTORP): Use it.
2045 * fns.c (internal_equal): Adapt code to extract pvectype.
2046 * emacs.c (gdb_pvec_type): Update type.
2047 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2048 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2049 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2050 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2051 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2052 abusing vector->header.next.nbytes.
2053 (live_vector_p): Use PVEC_TYPE.
2054 (mark_object): Adapt code to extract pvectype. Use switch.
2055
c7f2cd7f
PE
20562012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2059 Tighten new eassert a bit.
2060
8ce70ed2
DA
20612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2062
2063 Fix compilation with --enable-gcc-warnings and -O1
2064 optimization level.
2065 * doprnt.c (doprnt): Change type of tem to int, initialize
2066 to avoid compiler warning. Add eassert.
2067 * search.c (simple_search): Initialize match_byte to avoid
2068 compiler warning. Add eassert.
2069
dea7f1e5
PE
20702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2071
24a212eb
PE
2072 Avoid weird behavior with large horizontal scrolls.
2073 Without this change, for example, large hscroll values would
2074 mess up Emacs's display on Fedora 15 x86, presumably due to
2075 overflows in int calculations in the display code.
2076 Also, if buffers had long lines, Emacs would freeze.
2077 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2078 (set_window_hscroll): New function, containing the old guts of
2079 Fset_window_hscroll. Return the clipped value.
2080 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2081 This avoids the need to check against PTRDIFF_MAX.
2082
dea7f1e5
PE
2083 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2084
76046526
DA
20852012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2088
39adff0d
PE
20892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2090
63807d47
PE
2091 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2092 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2093 since GCC 4.4.6 issues a bogus warning for them.
2094
39adff0d
PE
2095 Fix bugs in file timestamp newness comparisons.
2096 * fileio.c (Ffile_newer_than_file_p):
2097 * lread.c (Fload): Use full timestamp resolution of files,
2098 not just the 1-second resolution, so that files that are only
2099 slightly newer still count as newer.
2100 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2101 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2102
dbeed9a6
PE
21032012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * fileio.c: Improve handling of file time marker. (Bug#11852)
2106 (special_mtime): New function.
2107 (Finsert_file_contents, Fverify_visited_file_modtime):
2108 Use it to set special mtime values consistently.
2109
636334d6
AS
21102012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2111
2112 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2113 marker for non-existing file. (Bug#11852)
2114
e2017fe2
GM
21152012-07-03 Glenn Morris <rgm@gnu.org>
2116
2117 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2118 and did not make it into globals.h).
2119
404dbd37
TT
21202012-07-03 Tom Tromey <tromey@redhat.com>
2121
2122 * window.c (Fset_window_margins, Fset_window_fringes)
2123 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2124 * textprop.c (Fprevious_property_change): No longer static.
2125 * syntax.c (Fsyntax_table_p): No longer static.
2126 * process.c (Fget_process, Fprocess_datagram_address): No longer
2127 static.
2128 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2129 * keyboard.c (Fcommand_execute): No longer static.
2130 Remove EXFUN.
2131 * insdel.c (Fcombine_after_change_execute): No longer static.
2132 * image.c (Finit_image_library): No longer static.
2133 * fileio.c (Fmake_symbolic_link): No longer static.
2134 * eval.c (Ffetch_bytecode): No longer static.
2135 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2136 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2137 No longer static.
404dbd37
TT
2138 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2139 static.
2140 * dired.c (Ffile_attributes): No longer static.
2141 * composite.c (Fcomposition_get_gstring): No longer static.
2142 * callproc.c (Fgetenv_internal): No longer static.
2143
2144 * ccl.h: Remove EXFUNs.
2145 * buffer.h: Remove EXFUNs.
2146 * dispextern.h: Remove EXFUNs.
2147 * intervals.h: Remove EXFUNs.
2148 * fontset.h: Remove EXFUN.
2149 * font.h: Remove EXFUNs.
2150 * dosfns.c (system_process_attributes): Remove EXFUN.
2151 * keymap.h: Remove EXFUNs.
2152 * lisp.h: Remove EXFUNs.
2153 * w32term.h: Remove EXFUNs.
2154 * window.h: Remove EXFUNs.
2155 * xsettings.h: Remove EXFUN.
2156 * xterm.h: Remove EXFUN.
2157
8e4fd1e1
GM
21582012-07-03 Glenn Morris <rgm@gnu.org>
2159
2160 * lisp.h (Frandom): Make it visible to C.
2161 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2162 buffer for invisible buffers. (Bug#1229)
2163
ca95b3eb
DA
21642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2165
2166 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2167 values which aren't power of 2.
2168 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2169 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2170 accordingly.
2171
7555c33f
SM
21722012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2175
2176 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2177
d12e8f5a
DA
21782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2179
2180 * alloc.c (allocate_vector_block): Remove redundant
2181 calls to mallopt if DOUG_LEA_MALLOC is defined.
2182 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2183 avoid calls to mallopt if zero_vector is returned.
2184
296094c3
DA
21852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2188 is enabled, avoid dereferencing NULL current_sblock if
2189 running undumped.
2190
36429c89
DA
21912012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2192
2193 Cleanup basic buffer management.
2194 * buffer.h (struct buffer): Change layout to use generic vector
2195 marking code. Fix some comments. Change type of 'clip_changed'
2196 to bitfield. Remove unused #ifndef old.
2197 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2198 (GET_OVERLAYS_AT): Fix indentation.
2199 (for_each_per_buffer_object_at): New macro.
2200 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2201 (Fbuffer_local_variables): Use it.
2202 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2203 * alloc.c (allocate_buffer): Adjust to match new layout of
2204 struct buffer. Fix comment.
2205 (mark_overlay): New function.
2206 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2207 Lisp area of struct buffer.
2208 (mark_object): Use it. Adjust marking of misc objects
2209 and related comments.
2210
3b3e4cac
PE
22112012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2214 wrapper that is not needed because the wrapped code is a no-op (zero
2215 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2216 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2217
cf5c0175
DA
22182012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2219
2220 * alloc.c (mark_buffer): Simplify. Remove prototype.
2221 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2222 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2223 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2224 redundant calls to mark_vectorlike for bool vectors.
2225
ca26824c
GM
22262012-06-30 Glenn Morris <rgm@gnu.org>
2227
2e4c5312
GM
2228 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2229
ca26824c
GM
2230 * epaths.in (PATH_SITELOADSEARCH): New.
2231 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2232 This is rather than relying on --enable-locallisppath elements
2233 having "site-lisp" in their names. (Bug#10208#25, 11658)
2234
0d23c240
EZ
22352012-06-30 Eli Zaretskii <eliz@gnu.org>
2236
c9240d7a
EZ
2237 * w32proc.c (sys_select): Accept and ignore one more argument.
2238
2239 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2240
0d23c240 2241 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2242 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2243
2244 * sysdep.c: Don't include dos.h and dosfns.h.
2245
2246 * process.c (sys_select):
2247 * msdos.c (sys_select): Accept one more argument and ignore it.
2248
2249 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2250 adapt data types and code to that.
2251
2252 * dosfns.c:
2253 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2254 which clashes with the gnulib function of the same name.
2255
af5a5a98
AS
22562012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2257
c5e4379c
AS
2258 * font.c (font_style_to_value, font_style_symbolic)
2259 (font_prop_validate_style): Add type checks for values in
2260 font_style_table.
2261
af5a5a98
AS
2262 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2263 argument.
2264 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2265 uses.
2266
8d38f461
EZ
22672012-06-29 Eli Zaretskii <eliz@gnu.org>
2268
2e5a6631
EZ
2269 * xdisp.c (try_window_id): Undo last change.
2270
8d38f461
EZ
2271 * w32.c (getwd): Adjust commentary about startup_dir.
2272 (init_environment): Always call sys_access, even in non-MSVC
2273 builds. Don't chdir to the directory of the Emacs executable.
2274 This undoes code from 1997 which was justified by the need to
2275 "avoid conflicts when removing and renaming directories". But its
2276 downside was that every relative file name was being interpreted
2277 relative to the directory of the Emacs executable, which can never
2278 be TRT. In particular, it broke sys_access when called with
2279 relative file names.
2280 (sys_access): Map GetLastError to errno.
2281
2af3565e
DA
22822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2283
2284 * window.h (struct window): Change type of 'fringes_outside_margins'
2285 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2286 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2287 Adjust comment.
2288 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2289 to ptrdiff_t.
2290
c8d3a25c 22912012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2292
c8d3a25c
GM
2293 * gnutls.c (emacs_gnutls_handshake):
2294 Add QUIT to make the loop interruptible.
57570cd3 2295
c8d3a25c 22962012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2297
c8d3a25c
GM
2298 * charset.c (init_charset): Make lack of etc/charsets fatal.
2299
3e984ee8
DA
23002012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2301
2302 * editfns.c (region_limit): Fix type mismatch.
2303
ef884f23
DA
23042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2305
2306 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2307 undefined. Convert from xassert to eassert.
2308 * nsmenu.m: Convert from xassert to eassert.
2309 * nsterm.m: Likewise.
2310
7d7e0027
SM
23112012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2314
aa754e6a
PE
23152012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 Avoid integer overflow on scroll-left and scroll-right.
2318 * window.c (HSCROLL_MAX): New macro.
2319 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2320 overflow when requested scroll falls outside ptrdiff_t range.
2321
80b00b08
DA
23222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2323
2324 * window.h (struct window): Change type of 'hscroll',
2325 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2326 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2327 Adjust users accordingly.
2328 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2329 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2330 from EMACS_INT to ptrdiff_t.
2331 (make_window): Omit redundant initialization.
2332
62b2bcf6
JB
23332012-06-28 Juanma Barranquero <lekktu@gmail.com>
2334
2335 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2336
45942c7d
DA
23372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 * window.h (struct window): Change type of 'use_time' and
2340 'sequence_number' from Lisp_Object to int.
2341 * frame.c (make_frame): Adjust users accordingly.
2342 * print.c (print_object): Likewise.
2343 * window.c (select_window, Fwindow_use_time, make_parent_window)
2344 (make_window): Likewise.
2345
e509cfa6
DA
23462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2347
2348 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2349 enabled with --enable-checking=[all,glyphs] configure option.
2350 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2351 adjust comments accordingly.
2352 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2353 undefined, adjust comments accordingly.
2354 * image.c: Likewise.
2355 * scroll.c: Likewise.
2356 * w32fns.c: Likewise.
2357 * w32term.c: Likewise.
2358 * xdisp.c: Likewise.
2359 * xfaces.c: Likewise.
2360 * xfns.c: Likewise.
2361 * xterm.c: Likewise.
2362
a54e2c05
DA
23632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2364
2365 Generalize run-time debugging checks.
2366 * dispextern.h (XASSERTS): Remove.
2367 * fontset.c (xassert): Remove.
2368 Convert from xassert to eassert.
2369 * alloc.c: Convert from xassert to eassert.
2370 * bidi.c: Likewise.
2371 * dispnew.c: Likewise.
2372 * fns.c: Likewise.
2373 * fringe.c: Likewise.
2374 * ftfont.c: Likewise.
2375 * gtkutil.c: Likewise.
2376 * image.c: Likewise.
2377 * keyboard.c: Likewise.
2378 * menu.c: Likewise.
2379 * process.c: Likewise.
2380 * scroll.c: Likewise.
2381 * sound.c: Likewise.
2382 * term.c: Likewise.
2383 * w32console.c: Likewise.
2384 * w32fns.c: Likewise.
2385 * w32term.c: Likewise.
2386 * window.c: Likewise.
2387 * xdisp.c: Likewise.
2388 * xfaces.c: Likewise.
2389 * xfns.c: Likewise.
2390 * xselect.c: Likewise.
2391 * xterm.c: Likewise.
2392
1ec4b7b2
SM
23932012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * fns.c (maybe_resize_hash_table): Output message when growing the
2396 purify-hashtable.
2397
2014308a
DA
23982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2399
2400 * alloc.c (allocate_string_data): Remove dead code.
2401 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2402 avoid GCC warning about unused macro.
2403
246155eb
DA
24042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2405
2406 * alloc.c (allocate_string): Omit intervals initialization.
2407 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2408 as in make_pure_string and make_pure_c_string.
2409
43184b7b
DA
24102012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2411
d209e2fb 2412 * alloc.c (allocate_string): Fix last change.
43184b7b 2413
3fe6dd74
DA
24142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2415
d209e2fb 2416 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2417 to memset, add explicit initialization where appropriate.
2418
1ba6038a
GM
24192012-06-27 Glenn Morris <rgm@gnu.org>
2420
2421 * lisp.mk (lisp): Remove paths.elc.
2422
c89926a5
CY
24232012-06-27 Chong Yidong <cyd@gnu.org>
2424
2425 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2426
ed6b3510
JW
24272012-06-26 John Wiegley <johnw@newartisans.com>
2428
1ec4b7b2 2429 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2430 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2431
ed6b3510
JW
2432 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2433 when building with Clang.
2434
8edd4a2b
SM
24352012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2436
2437 * eval.c (Fapply): Allow calling it with a single argument.
2438
f6f62d1b
EZ
24392012-06-26 Eli Zaretskii <eliz@gnu.org>
2440
2441 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2442 _stricmp and _strnicmp.
2443 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2444
62efea5e
DA
24452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2448 allocated window.
2449 (allocate_process): Likewise for new process.
8edd4a2b 2450 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2451 (allocate_frame): Likewise.
2452 * frame.c (make_frame): Omit redundant initialization.
2453 * window.c (make_parent_window): Use memset.
2454 (make_window): Omit redundant initialization.
2455 * process.c (make_process): Omit redundant initialization.
2456 * terminal.c (create_terminal): Likewise.
2457
42997f4d
DA
24582012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2459
2460 * term.c (delete_tty): Remove redundant call to memset.
2461
1130ecfc
DA
24622012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2463
2464 * alloc.c: Remove build_string.
2465 * lisp.h: Define build_string as static inline. This provides
2466 a better opportunity to optimize away calls to strlen when the
2467 function is called with compile-time constant argument.
2468 * image.c (imagemagick_error): Convert to build_string.
2469 * w32proc.c (sys_spawnve): Likewise.
2470 * xterm.c (x_term_init): Likewise.
2471
cf38a720
PE
24722012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2473
99027bdd
PE
2474 Use sprintf return value instead of invoking strlen on result.
2475 In the old days this wasn't portable, since some sprintf
2476 implementations returned char *. But they died out years ago and
2477 Emacs already assumes sprintf returns int.
2478 Similarly for float_to_string.
2479 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2480 * ccl.c (ccl_driver):
2481 * character.c (string_escape_byte8):
2482 * data.c (Fnumber_to_string):
2483 * doprnt.c (doprnt):
2484 * print.c (print_object):
2485 * xdisp.c (message_dolog):
2486 * xfns.c (syms_of_xfns):
2487 Use sprintf or float_to_string result to avoid need to call strlen.
2488 * data.c (Fnumber_to_string):
2489 Use make_unibyte_string, since the string must be ASCII.
2490 * lisp.h, print.c (float_to_string): Now returns int length.
2491 * term.c (produce_glyphless_glyph):
2492 Use sprintf result rather than recomputing it.
2493
cf38a720
PE
2494 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2495 * Makefile.in (ALL_CFLAGS):
2496 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2497 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2498
3511c784
DA
24992012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2500
0a08eb21 2501 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2502 strcasecmp if available.
2503 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2504
fb7da12e
AS
25052012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2506
2507 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2508 Avoid comma operator.
2509 * menu.c (push_submenu_start, push_submenu_end)
2510 (push_left_right_boundary, push_menu_pane): Likewise.
2511 * msdos.c (dos_rawgetc): Likewise.
2512
afa2ffd8
DA
25132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2514
2515 * xfns.c (xic_create_fontsetname): Remove redundant calls
2516 to memset.
2517
b3b4476b
PE
25182012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2519
4495ff38
PE
2520 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2521 sprintf already null-terminates its output.
2522
b3b4476b
PE
2523 * xfns.c (x_window): Remove redundant cast.
2524
b00876c9
DA
25252012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2526
2527 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2528 `const char *' to `char *' to avoid compiler warning.
2529
d188e26b
PE
25302012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2531
885d1d74
PE
2532 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2533 instead of truncating it to 63 (admittedly a generous limit).
2534
d188e26b
PE
2535 * process.c: Fix spelling and caps in comments.
2536
e2f560b1
DN
25372012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2538
e86db54b 2539 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2540 * sysdep.c (setpgrp): Remove definition, not used in this file.
2541
7583a3a1
JB
25422012-06-24 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * makefile.w32-in: Update dependencies.
2545
696056c2
EZ
25462012-06-24 Eli Zaretskii <eliz@gnu.org>
2547
2548 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2549 (SYSTIME_H): Add nt/inc/sys/time.h.
2550
2551 * systime.h [WINDOWSNT]: Include sys/time.h.
2552
2553 * s/ms-w32.h (struct timespec): Definition moved from
2554 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2555
845ca893
PE
25562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2559 * buffer.h (buffer_slot_type_mismatch):
2560 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2561 * eval.c (unwind_to_catch):
2562 * image.c (my_png_error, my_error_exit):
2563 * keyboard.c (quit_throw_to_read_char, user_error)
2564 (Fexit_recursive_edit, Fabort_recursive_edit):
2565 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2566 (wrong_type_argument, buffer_overflow, __executable_start)
2567 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2568 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2569 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2570 (fatal):
2571 (child_setup) [!DOS_NT]:
2572 * lread.c (end_of_file_error, invalid_syntax):
2573 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2574 * puresize.h (pure_write_error):
2575 * search.c (matcher_overflow):
2576 * sound.c (sound_perror, alsa_sound_perror):
2577 * sysdep.c, syssignal.h (croak):
2578 * term.c (maybe_fatal, vfatal):
2579 * textprop.c (text_read_only):
2580 * undo.c (user_error):
2581 * unexmacosx.c (unexec_error):
2582 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2583 Use _Noreturn rather than NO_RETURN.
2584 No need for separate decl merely because of _Noreturn.
2585 * sound.c (sound_warning, parse_sound):
2586 Remove unnecessary forward decls.
2587
f1dd8073
PE
25882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2591 * lisp.h (WAIT_READING_MAX): New macro.
2592 * dispnew.c (Fsleep_for, sit_for):
2593 * keyboard.c (kbd_buffer_get_event):
2594 * process.c (Faccept_process_output):
2595 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2596 This improves on the previous patch, which introduced a bug
2597 when time_t is unsigned and as wide as intmax_t.
2598 See <http://bugs.gnu.org/9000#51>.
2599
b82c1755
EZ
26002012-06-23 Eli Zaretskii <eliz@gnu.org>
2601
2602 * dispnew.c (sit_for, Fsleep_for):
2603 * keyboard.c (kbd_buffer_get_event):
2604 * process.c (Faccept_process_output): Avoid compiler warnings when
2605 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2606
ca300656
JB
26072012-06-23 Juanma Barranquero <lekktu@gmail.com>
2608
049ec95b
JB
2609 * makefile.w32-in: Update dependencies.
2610
ca300656
JB
2611 * w32.c (ltime): Add return type and declare static.
2612 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2613
db7b8d06
PE
26142012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2617 Privately reported by Herbert J. Skuhra.
2618 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2619 All uses changed.
2620 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2621 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2622
0bd8297f
EZ
26232012-06-23 Eli Zaretskii <eliz@gnu.org>
2624
96512555
EZ
2625 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2626 last argument of make_unibyte_string.
2627
0bd8297f
EZ
2628 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2629 language ID in the event parameters.
2630
2631 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2632 event.code, not the obscure "character set ID".
2633
63def6b6
CY
26342012-06-23 Chong Yidong <cyd@gnu.org>
2635
2636 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2637
e8a02204
EZ
26382012-06-23 Eli Zaretskii <eliz@gnu.org>
2639
388cdec0
EZ
2640 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2641 * w32.c (fdutimens): New function.
2642
2643 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2644
2645 * s/ms-w32.h (pselect): Redirect to sys_select.
2646
2647 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2648
e8a02204
EZ
2649 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2650 in the logic of incrementing and decrementing the value of
2651 use_relocatable_buffers.
2652
d054f3fb
PE
26532012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2656 Privately reported by Herbert J. Skuhra.
2657 [__FreeBSD__]: Remove "*/" typo after "#include".
2658 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2659 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2660 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2661 Don't assume EMACS_TIME and struct timeval are the same type.
2662
d35af63c
PE
26632012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 Support higher-resolution time stamps (Bug#9000).
2666 The time stamps are only nanosecond-resolution at the C level,
2667 since that's the best that any real-world system supports now.
2668 But they are picosecond-resolution at the Lisp level, as that's
2669 easy, and leaves room for future OS improvements.
2670
2671 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2672 (LIBES): Use it.
2673
2674 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2675 Don't get current time unless it's needed.
2676
2677 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2678 now provides it if it's absent.
2679 (start_atimer): Port to higher-res time stamps.
2680 Check for time stamp overflow. Don't get current time more
2681 often than is needed.
2682
2683 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2684 Include systime.h, not time.h.
2685 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2686
2687 * dired.c: Include stat-time.h.
2688 (Ffile-attributes): File times now have higher resolution.
2689
2690 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2691 (struct image): Timestamp now has higher resolution.
2692
2693 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2694 has at least microseconds now. All uses removed.
2695 (update_frame, update_single_window, update_window, update_frame_1)
2696 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2697
2698 * editfns.c (time_overflow): Now extern.
2699 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2700 (float-time, Fformat_time_string, Fcurrent_time_string)
2701 (Fcurrent_time_zone): Accept and generate higher-resolution
2702 time stamps.
2703 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2704 (decode_time_components, lisp_seconds_argument): New functions.
2705 (make_time): Now static.
2706 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2707 Report an error if the time is invalid, rather than having the caller
2708 do that.
2709
2710 * fileio.c: Include <stat-time.h>
2711 (Fcopy_file): Copy higher-resolution time stamps.
2712 Prefer to set the time stamp via a file descriptor if that works.
2713 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2714 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2715 (Fvisited_file_modtime, Fset_visited_file_modtime):
2716 Support higher-resolution time stamps.
2717
2718 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2719
2720 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2721
2722 * image.c (prepare_image_for_display, clear_image_cache)
2723 (lookup_image): Port to higer-resolution time stamps.
2724
2725 * keyboard.c (start_polling, bind_polling_period):
2726 Check for time stamp overflow.
2727 (read_char, kbd_buffer_get_event, timer_start_idle)
2728 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2729 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2730 Port to higher-resolution time stamps. Do not assume time_t is signed.
2731 (decode_timer): New function. Timers are now vectors of length 9,
2732 not 8, to accommodate the picosecond component.
2733 (timer_check_2): Use it.
2734
2735 * nsterm.m (select_timeout, timeval_subtract): Remove.
2736 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2737 as they're a bit more accurate and handle overflow better.
2738 (ns_select): Change prototype to be compatible with pselect.
2739 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2740 * nsterm.h (ns_select): Adjust prototype.
2741
2742 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2743 us-resolution time stamps.
2744 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2745
2746 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2747
2748 * lisp.h (time_overflow): New decl.
2749 (wait_reading_process_output): First arg is now intmax_t, not int,
2750 to accommodate larger waits.
2751
2752 * process.h (struct Lisp_Process.read_output_delay):
2753 Now counts nanoseconds, not microseconds.
2754 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2755 EMACS_HAS_USECS.
2756 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2757 (wait_reading_process_output):
2758 Port to ns-resolution time stamps.
2759 (Faccept_process_output, wait_reading_process_output):
2760 Check for time stamp overflow. Do not assume time_t is signed.
2761 (select_wrapper): Remove; we now use pselect.
2762 (Fprocess_attributes): Now generates ns-resolution time stamps.
2763
2764 * sysdep.c: Include utimens.h. Don't include utime.h
2765 or worry about struct utimbuf; gnulib does that for us now.
2766 (gettimeofday): Remove; gnulib provides a substitute.
2767 (make_timeval): New function.
2768 (set_file_times): Now sets ns-resolution time stamps.
2769 New arg FD; all uses changed.
2770 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2771 (system_process_attributes):
2772 Now returns ns-resolution time stamp. All uses changed.
2773 Check for time stamp overflow.
2774
2775 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2776 provides a substitute now.
2777
2778 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2779 since it guarantees struct timespec.
2780 (EMACS_TIME): Now struct timespec, so that we can support
2781 ns-resolution time stamps.
2782 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2783 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2784 (EMACS_USECS): Remove.
2785 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2786 so multiply the arg by 1000 before storing it.
2787 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2788 New macros.
2789 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2790 Port to ns-resolution time stamps.
2791 (EMACS_TIME_NEG_P): Remove; replaced by....
2792 (EMACS_TIME_SIGN): New macro.
2793 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2794 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2795 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2796 (make_timeval, make_lisp_time, decode_time_components): New decls.
2797 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2798 that it mishandled time_t overflow. You can't compare by subtracting!
2799 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2800 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2801
2802 * term.c: Include <sys/time.h>.
2803 (timeval_to_Time): New function, for proper overflow wraparound.
2804 (term_mouse_position, term_mouse_click): Use it.
2805
2806 * undo.c (record_first_change): Support higher-resolution time stamps
2807 in the undo buffer.
2808 (Fprimitive_undo): Use them when restoring time stamps.
2809
2810 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2811 (w32_get_internal_run_time):
2812 Port to higher-resolution Emacs time stamps.
2813 (ltime): Now accepts single 64-bit integer, as that's more convenient
2814 for callers.
2815
2816 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2817
2818 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2819 for compatibility with pselect. Support ns-resolution time stamps.
2820
2821 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2822
2823 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2824 Check for time stamp overflow, and support ns-resolution time stamps.
2825
2826 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2827 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2828 (timeval_subtract): Remove; no longer needed.
2829 (XTflash, XTring_bell, x_wait_for_event):
2830 Port to ns-resolution time stamps. Don't assume time_t is signed.
2831
b6a92dfe
CY
28322012-06-22 Chong Yidong <cyd@gnu.org>
2833
2834 * xdisp.c (x_consider_frame_title): Revert last change.
2835
d251c37c
EZ
28362012-06-22 Eli Zaretskii <eliz@gnu.org>
2837
2838 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2839 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2840 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2841 staticidx goes up to 1597 out of 1600 = 0x640.)
2842
f10deafb
PE
28432012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2846 Otherwise, the umask might be mistakenly 0 while handling input signals.
2847
ec6de1e2
SM
28482012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2849
2850 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2851
28be1ada
DA
28522012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2853
2854 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2855 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2856 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2857 access to `contents' member of Lisp_Vector objects with AREF and ASET
2858 where appropriate.
2859
c6bf3022
CY
28602012-06-19 Chong Yidong <cyd@gnu.org>
2861
2862 * frame.c (delete_frame): When selecting a frame on a different
2863 text terminal, do not alter the terminal's top-frame.
2864
2865 * xdisp.c (format_mode_line_unwind_data): Record the target
2866 frame's selected window and its terminal's top-frame.
2867 (unwind_format_mode_line): Restore them.
2868 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2869 Callers changed.
2870 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2871 since tty frames can be explicitly named.
2872 (prepare_menu_bars): Likewise.
2873
2874 * term.c (Ftty_top_frame): New function.
2875
defd4196
PE
28762012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 Port byte-code-meter to modern targets.
2879 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2880 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2881 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2882 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2883 (METER_1, METER_2): Simplify.
2884
1053a871
SM
28852012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * data.c (Fdefalias): Return `symbol' (bug#11686).
2888
b7e8d081
MR
28892012-06-18 Martin Rudalics <rudalics@gmx.at>
2890
2891 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2892 gets killed during executing of this function (Bug#11665).
2893 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2894 (Vkill_buffer_query_functions): In doc-string say that functions
2895 run by this hook should not change the current buffer.
2896
7ea2b339
PE
28972012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 Fix recently-introduced process.c problems found by static checking.
2900 * process.c (write_queue_push, write_queue_pop, send_process):
2901 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2902 (write_queue_pop): Fix pointer signedness problem.
2903 (send_process): Remove unused local.
2904
96a313a1
CY
29052012-06-17 Chong Yidong <cyd@gnu.org>
2906
2907 * xdisp.c (redisplay_internal): No need to redisplay terminal
2908 frames that are not on top.
2909
20ca2e94
TN
29102012-06-17 Troels Nielsen <bn.troels@gmail.com>
2911
2912 * process.c (make_process): Initialize write_queue.
2913 (write_queue_push, write_queue_pop): New functions.
2914 (send_process): Use them to maintain correct ordering of process
2915 writes (Bug#10815).
2916
9a900ca9
PE
29172012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2918
310fbfa8
PE
2919 * lisp.h (eassert): Assume C89 or later.
2920 This removes the need for CHECK.
2921 (CHECK): Remove. Its comments about always evaluating its
2922 argument were confusing, as 'eassert' typically does not evaluate
2923 its argument.
2924
27bb1ca4
PE
2925 * coding.c (produce_chars): Use ptrdiff_t, not int.
2926
9a900ca9
PE
2927 * xterm.c (x_draw_underwave): Check for integer overflow.
2928 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2929
41b7f8bc 29302012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2931
2932 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2933 referenced (Bug#11583).
2934
9b0e3eba
AA
29352012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2936
2937 Implement wave-style variant of underlining.
2938 * dispextern.h (face_underline_type): New enum.
2939 (face): Add field for underline type.
2940 * nsterm.m (ns_draw_underwave): New function.
2941 (ns_draw_text_decoration): Use it.
2942 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2943 New functions.
2944 (x_draw_glyph_string): Use them.
2945 * xfaces.c (Qline, Qwave): New Lisp objects.
2946 (check_lface_attrs, merge_face_ref)
1053a871
SM
2947 (Finternal_set_lisp_face_attribute, realize_x_face):
2948 Handle wave-style underline face attributes.
9b0e3eba
AA
2949 * xterm.c (x_draw_underwave): New function.
2950 (x_draw_glyph_string): Use it.
2951
0fb52f11
JB
29522012-06-16 Juanma Barranquero <lekktu@gmail.com>
2953
2954 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2955 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2956 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2957 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2958 ($(BLD)/w32select.$(O)): Update dependencies.
2959
e5560ff7
AS
29602012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2963 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2964 * character.c (_fetch_multibyte_char_p): Remove.
2965 * alloc.c: Include "character.h" before "buffer.h".
2966 * bidi.c: Likewise.
2967 * buffer.c: Likewise.
2968 * bytecode.c: Likewise.
2969 * callint.c: Likewise.
2970 * callproc.c: Likewise.
2971 * casefiddle.c: Likewise.
2972 * casetab.c: Likewise.
2973 * category.c: Likewise.
2974 * cmds.c: Likewise.
2975 * coding.c: Likewise.
2976 * composite.c: Likewise.
2977 * dired.c: Likewise.
2978 * dispnew.c: Likewise.
2979 * doc.c: Likewise.
2980 * dosfns.c: Likewise.
2981 * editfns.c: Likewise.
2982 * emacs.c: Likewise.
2983 * fileio.c: Likewise.
2984 * filelock.c: Likewise.
2985 * font.c: Likewise.
2986 * fontset.c: Likewise.
2987 * fringe.c: Likewise.
2988 * indent.c: Likewise.
2989 * insdel.c: Likewise.
2990 * intervals.c: Likewise.
2991 * keyboard.c: Likewise.
2992 * keymap.c: Likewise.
2993 * lread.c: Likewise.
2994 * macros.c: Likewise.
2995 * marker.c: Likewise.
2996 * minibuf.c: Likewise.
2997 * nsfns.m: Likewise.
2998 * nsmenu.m: Likewise.
2999 * print.c: Likewise.
3000 * process.c: Likewise.
3001 * regex.c: Likewise.
3002 * region-cache.c: Likewise.
3003 * search.c: Likewise.
3004 * syntax.c: Likewise.
3005 * term.c: Likewise.
3006 * textprop.c: Likewise.
3007 * undo.c: Likewise.
3008 * unexsol.c: Likewise.
3009 * w16select.c: Likewise.
3010 * w32fns.c: Likewise.
3011 * w32menu.c: Likewise.
3012 * window.c: Likewise.
3013 * xdisp.c: Likewise.
3014 * xfns.c: Likewise.
3015 * xmenu.c: Likewise.
3016 * xml.c: Likewise.
3017 * xselect.c: Likewise.
3018
2f07e6af
EZ
30192012-06-16 Eli Zaretskii <eliz@gnu.org>
3020
1053a871
SM
3021 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3022 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3023 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3024 row.
3025 (handle_face_prop): Use chunk-relative overlay string index when
3026 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3027 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3028 the rightmost. (Bug#11720)
2f07e6af 3029
29b83cec
AS
30302012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3031
3032 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3033 (CATEGORY_MEMBER): Enforce 1/0 value.
3034 * category.c (_temp_category_set): Remove.
3035
4c5501e9
EZ
30362012-06-16 Eli Zaretskii <eliz@gnu.org>
3037
3038 * window.c (Fdelete_other_windows_internal)
3039 (Fdelete_window_internal): Don't access frame's mouse highlight
3040 info of the initial frame. (Bug#11677)
3041
2b570124
PE
30422012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3043
e93864f9
PE
3044 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3045 Assume USE_2_TAGS_FOR_INTS.
3046 (xreload): Adjust $tagmask width to match recent lisp.h change.
3047
2b570124
PE
3048 Simplify lisp.h in minor ways that should not affect code.
3049 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3050 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3051 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3052 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3053 (INTTYPEBITS): New macro, for clarity.
3054 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3055 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3056 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3057 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3058 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3059
81755f69
JB
30602012-06-13 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3063
16192a57
GM
30642012-06-13 Glenn Morris <rgm@gnu.org>
3065
3066 * s/bsd-common.h (BSD4_3):
3067 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3068
646b5f55
AS
30692012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3070
3071 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3072 instead of union.
3073 (XLI, XIL): Define.
1053a871
SM
3074 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3075 Use them.
3076 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3077 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3078 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3079 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3080 * frame.c (delete_frame): Remove outdated comment.
3081 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3082 USE_LISP_UNION_TYPE.
3083 (Fw32_unregister_hot_key): Likewise.
3084 (Fw32_toggle_lock_key): Likewise.
3085 * w32menu.c (add_menu_item): Likewise.
3086 (w32_menu_display_help): Use XIL instead of checking
3087 USE_LISP_UNION_TYPE.
3088 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3089 (init_heap): Likewise.
3090 * w32term.c (w32_read_socket): Update comment.
3091
1d3823c9
GM
30922012-06-13 Glenn Morris <rgm@gnu.org>
3093
c62ff706
GM
3094 * s/usg5-4-common.h, src/s/unixware.h:
3095 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3096
1d3823c9
GM
3097 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3098
bfe3e0a2
PE
30992012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3102 * alloc.c (make_number) [!defined make_number]:
3103 Remove, as lisp.h always defines this now.
3104 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3105 (roundup_size): Verify that it is a power of 2.
3106 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3107 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3108 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3109 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3110 USE_LSB_TAG now is always defined to be either 0 or 1.
3111 All uses changed.
3112 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3113 code works fine either way, and efficiency is not a concern here,
3114 as the union type is for debugging, not for production.
3115 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3116 Use an inline function on all platforms when using the union type,
3117 since this is simpler and 'static inline' can be used portably
3118 within Emacs now.
3119 (LISP_INITIALLY_ZERO): New macro.
3120 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3121 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3122
45fa9c0f
GM
31232012-06-12 Glenn Morris <rgm@gnu.org>
3124
b4492cba
GM
3125 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3126
3127 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3128
45fa9c0f
GM
3129 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3130 Move BROKEN_SIGIO to configure.
3131
3132 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3133 Move NO_TERMIO to configure.
3134
0e25d334
CY
31352012-06-12 Chong Yidong <cyd@gnu.org>
3136
3137 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3138 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3139 MagickExportImagePixels is undefined.
3140
43682bb6
PE
31412012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * image.c (imagemagick_load_image): Remove unused label.
3144
a9be7d2b
GM
31452012-06-11 Glenn Morris <rgm@gnu.org>
3146
3147 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3148 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3149 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3150 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3151
3017f87f
SM
31522012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3153
3154 * alloc.c (make_byte_code): New function.
3155 (Fmake_byte_code): Use it. Don't purify here.
3156 * lread.c (read1): Use it as well to avoid extra allocation.
3157
1b9b4cf4
CY
31582012-06-11 Chong Yidong <cyd@gnu.org>
3159
3160 * image.c (imagemagick_load_image): Implement transparency.
3161
95988fcf
AS
31622012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3163
3164 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3165 account for preceding backslashes. (Bug#11663)
3166
cd4eb164
CY
31672012-06-09 Chong Yidong <cyd@gnu.org>
3168
3169 * term.c: Support italics in capable terminals (Bug#9652).
3170 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3171 (turn_on_face): Output using TS_enter_italic_mode if available.
3172 Don't handle unused blinking and alt-charset cases.
3173 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3174 and tty_alt_charset_p cases.
3175 (tty_capable_p, init_tty): Support italics.
3176
3177 * termchar.h (struct tty_display_info): Add field for italics.
3178 Remove unused blink field.
3179
3180 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3181 Handle slant.
3182
3183 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3184 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3185 tty_alt_charset_p. Add tty_italic_p.
3186
ff88beb8
MA
31872012-06-09 Michael Albinus <michael.albinus@gmx.de>
3188
3189 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3190 dbus_type_is_basic if available.
3191 (xd_extract_signed, xd_extract_unsigned): Rename from
3192 extract_signed and extract_unsigned, respectively. Adapt callers.
3193
44286096
CY
31942012-06-09 Chong Yidong <cyd@gnu.org>
3195
1682701f
CY
3196 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3197
44286096
CY
3198 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3199 case (Bug#9752).
3200
d86feb17
PE
32012012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 * xdisp.c (vmessage): Treat frame message as multibyte.
3204 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3205 would generate the diagnostic "Making \302\247 buffer-local while
3206 let-bound!".
3207
d5c20fe8
EZ
32082012-06-08 Eli Zaretskii <eliz@gnu.org>
3209
3210 * dispnew.c (showing_window_margins_p): Undo last change, which
3211 was done due to an inadvertent commit.
3212 (adjust_frame_glyphs_for_frame_redisplay): Do call
3213 showing_window_margins_p.
3214
513749ee
SM
32152012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3216
3217 * eval.c (Fmake_var_non_special): New primitive.
3218 (syms_of_eval): Defsubr it.
3219 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3220
d4a8f5c1
JB
32212012-06-08 Juanma Barranquero <lekktu@gmail.com>
3222
3223 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3224 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3225
8bbbc977
EZ
32262012-06-08 Eli Zaretskii <eliz@gnu.org>
3227
3228 * alloc.c (allocate_vectorlike): Fix last change.
3229
f3372c87
DA
32302012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3231
3232 Block-based vector allocation of small vectors.
3233 * lisp.h (struct vectorlike_header): New field `nbytes',
3234 adjust comment accordingly.
3235 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3236 to denote vector blocks. Adjust users (live_vector_p,
3237 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3238 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3239 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3240 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3241 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3242 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3243 (roundup_size): New constant.
3244 (struct vector_block): New data type.
3245 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3246 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3247 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3248 (sweep_vectors): New functions.
3249 (allocate_vectorlike): Return `zero_vector' as the only vector of
3250 0 items. Allocate new vector from block if vector size is less than
3251 or equal to VBLOCK_BYTES_MAX.
3252 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3253 (init_alloc_once): Add call to init_vectors.
3254
4f18a4ed
SM
32552012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3256
3257 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3258
86f158bc
PE
32592012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3260
3261 * doprnt.c (doprnt): Truncate multibyte char correctly.
3262 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3263 would mishandle a string argument "Xc" if X was a multibyte
3264 character of length 2: it would truncate after X's first byte
3265 rather than including all of X.
3266
c5cfcbe0
CY
32672012-06-06 Chong Yidong <cyd@gnu.org>
3268
3269 * buffer.c (word_wrap): Doc fix.
3270
c05cf390
PE
32712012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3274
0c3461de
GM
32752012-06-03 Glenn Morris <rgm@gnu.org>
3276
3277 * xdisp.c (tool-bar-style): Doc fix.
3278
c71232db
UM
32792012-06-03 Ulrich Müller <ulm@gentoo.org>
3280
3281 * Makefile.in (PAXCTL): Define.
3282 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3283 binary via PaX flags if the paxctl utility is available.
3284 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3285 Restore PaX flags to their default. (Bug#11398)
3286
383f7350
CY
32872012-06-03 Chong Yidong <cyd@gnu.org>
3288
3289 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3290 buffer (Bug#11226).
3291
5f2c76c6
CY
32922012-06-03 Chong Yidong <cyd@gnu.org>
3293
3294 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3295 (note_mode_line_or_margin_highlight): If there is no help echo,
3296 use mode-line-default-help-echo. Handle the case where the mouse
3297 position is past the end of the mode line string.
3298
3299 * buffer.c (buffer_local_value_1): New function, split from
3300 Fbuffer_local_value; can return Qunbound.
3301 (Fbuffer_local_value): Use it.
3302 (Vmode_line_format): Docstring tweaks.
3303
773d47f6
PE
33042012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * sysdep.c (system_process_attributes): Improve comment.
3307
f2d6a3df
SM
33082012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3309
3310 * keyboard.c: Export real-this-command to Elisp.
3311 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3312 and DEFVAR it. Update all users.
3313
63810350
PE
33142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3315
7bd5c1f4
PE
3316 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3317
63810350
PE
3318 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3319 Convert pctcpu and pctmem to Lisp float properly.
3320 Let the compiler fold better, as 100.0/0x8000 is exact.
3321
a2821611
AS
33222012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3323
3324 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3325 cons_block.
3326
5fceba1d
PE
33272012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3328
3329 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3330
c98ff5dd
DA
33312012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3332
3333 For a 'struct window', replace some Lisp_Object fields to
3334 bitfields where appropriate, remove unused fields.
3335 * window.h (struct window): Remove unused 'last_mark_x' and
3336 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3337 change it's type from Lisp_Object to bitfield.
3338 Change type of 'force_start', 'optional_new_start',
3339 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3340 fields from Lisp_Object to bitfield. Adjust users accordingly.
3341
ca34e0be
PE
33422012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 Pacify gcc -Wdouble-precision when using Xaw.
3345 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3346 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3347 Use 'float' consistently, rather than 'float' in most places
3348 and 'double' in a couple of places.
3349
efc00ab1 33502012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3351
3352 * xdisp.c (handle_stop): Detect whether we have overlay strings
3353 loaded by testing it->current.overlay_string_index to be
3354 non-negative, instead of checking whether n_overlay_strings is
3355 positive. (Bug#11587)
3356
efc00ab1 33572012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3358
3359 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3360
3361 * doc.c (Fsubstitute_command_keys): Doc fix.
3362
efc00ab1 33632012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3364
3365 * search.c (search_buffer): Remove calls to
3366 r_alloc_inhibit_buffer_relocation, as it is now called by
3367 maybe_unify_char, which was the cause of relocation of buffer text
3368 in bug#11519.
3369
efc00ab1 33702012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3371
3372 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3373 for the duration of call to load_charset, to avoid problems with
3374 callers of maybe_unify_char that access buffer text through C
3375 pointers.
3376
3377 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3378 decrement the inhibition flag, instead of just setting or
3379 resetting it.
3380
ba93a187
PE
33812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 Remove obsolete '#define static' cruft.
3384 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3385 This #undef was "temporary" in 2000; it is no longer needed
3386 now that '#define static' has gone away.
3387 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3388 (gray_bitmap_bits): Remove; no longer needed.
3389 All uses replaced with definiens.
3390 * xterm.c: Include "bitmaps/gray.xbm".
3391
9e4bf381
PE
33922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3393
3394 Clean up __executable_start, monstartup when --enable-profiling.
3395 The following changes affect the code only when profiling.
3396 * dispnew.c (__executable_start): Rename from safe_bcopy.
3397 Define only on platforms that need it.
3398 * emacs.c: Include <sys/gmon.h> when profiling.
3399 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3400 (__executable_start): Remove decl, since lisp.h does it now.
3401 (safe_bcopy): Remove decl; no longer has that name.
3402 (main): Coalesce #if into single bit of code, for simplicity.
3403 Cast pointers to uintptr_t, since standard libraries want integers
3404 and not pointers.
3405 * lisp.h (__executable_start): New decl.
3406
32d72c2f
GM
34072012-05-31 Glenn Morris <rgm@gnu.org>
3408
3409 * image.c (Fimagemagick_types): Doc fix.
3410
baac5bc7
JM
34112012-05-30 Jim Meyering <meyering@redhat.com>
3412
3413 * callproc.c (Fcall_process_region): Include directory component
3414 in mkstemp error message (Bug#11586).
3415
72cb32cf
PE
34162012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * alloc.c, lisp.h (make_pure_vector): Now static.
3419
61b108cc
SM
34202012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3421
3422 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3423 Move to byte-run.el.
3424 (Fautoload): Do the hash-doc more carefully.
3425 * data.c (Fdefalias): Purify definition, except for keymaps.
3426 (Qdefun): Move from eval.c.
3427 * lisp.h (Qdefun): Remove.
3428 * lread.c (read1): Tiny simplification.
3429
471fe23d
TN
34302012-05-29 Troels Nielsen <bn.troels@gmail.com>
3431
934f3f58 3432 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3433 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3434 Bug#9642, but explicitly check that the buffer the overlay would
3435 be moved to is live and rearrange lines to make sure that errors
3436 will not put the overlay in an inconsistent state.
3437 (Fdelete_overlay): Cosmetics.
3438
85d0efd1
EZ
34392012-05-28 Eli Zaretskii <eliz@gnu.org>
3440
3441 * w32term.c (my_bring_window_to_top): New function.
3442 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3443 could be different from the original one.
3444 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3445 (Bug#11513)
3446
3447 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3448 by calling BringWindowToTop.
3449
3450 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3451 (WM_EMACS_END): Increase by one.
3452
da92a98c
PE
34532012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3456 This avoids undefined behavior that might cause the eassert
3457 to not catch an out-of-range value.
3458
74d1f848
JB
34592012-05-28 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3462 Update dependencies.
3463
9e1a06fc
EZ
34642012-05-27 Eli Zaretskii <eliz@gnu.org>
3465
3466 * bidi.c (bidi_mirror_char): Fix last change.
3467
f3dd7312
AS
34682012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3469
3470 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3471 when referring to sectname field in printf format.
3472
81899c91
PE
34732012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3474
57b81a9f
PE
3475 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3476 Only r_alloc_inhibit_buffer_relocation needed to be added;
3477 the others were already declared.
3478
81899c91
PE
3479 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3480 before checking whether it's out of range. Put the check inside
3481 eassert. See
3482 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3483
33017faf 34842012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3485
3486 * callproc.c (Fcall_process): Restore a line that was accidentally
3487 commented out in the 2011-02-13 change (bug#11547).
3488
33017faf 34892012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3490
3491 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3492 defined on ralloc.c.
3493
3494 * buffer.c [REL_ALLOC]: Remove prototypes of
3495 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3496 they are now on lisp.h.
3497
3498 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3499
3500 * search.c (search_buffer): Use it to inhibit relocation of buffer
3501 text while re_search_2 is doing its job, because re_search_2 is
3502 passed C pointers to buffer text. (Bug#11519)
3503
23415acf
EZ
3504 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3505 Update value to 24.
3506
44e27368
EZ
3507 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3508 state after an additional call to move_it_in_display_line_to, keep
3509 the values of it->max_ascent and it->max_descent found for the
3510 entire line.
3511 (pos_visible_p): Revert the comparison against bottom_y to what it
3512 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3513 (Bug#11464)
3514
c1892f11
PE
35152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 Fix coding-related core dumps with gcc -ftrapv.
3518 The code was computing A - B, where A and B are pointers, and B is
3519 random garbage. This can lead to core dumps on platforms that
3520 have special pointer registers, and it also leads to core dumps on
3521 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3522 A - B only when B is initialized properly.
3523 * coding.c (coding_set_source, coding_set_destination): Return void.
3524 (coding_change_source, coding_change_destinations): New functions,
3525 with the old behaviors of coding_set_source and coding_set_destination.
3526 All callers that need an offset changed to use these new functions.
3527
eb7afdad
GM
35282012-05-26 Glenn Morris <rgm@gnu.org>
3529
3530 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3531
f12fdf02
EZ
35322012-05-26 Eli Zaretskii <eliz@gnu.org>
3533
53a63be6 3534 Extend mouse support on W32 text-mode console.
61b108cc
SM
3535 * xdisp.c (draw_row_with_mouse_face):
3536 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3537
eb3f6f01 3538 * w32console.c: Include window.h.
61b108cc
SM
3539 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3540 New functions.
eb3f6f01
EZ
3541 (initialize_w32_display): Initialize mouse-highlight data.
3542
53a63be6
EZ
3543 * w32inevt.c: Include termchar.h and window.h.
3544 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3545 moves, call note_mouse_highlight. If help_echo changed, call
3546 gen_help_event to produce help-echo message in the echo area.
3547 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3548 highlight info.
3549
4cfd81f6
PE
35502012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3551
3552 * lread.c (read1): Simplify slightly to avoid an overflow warning
3553 with GCC 4.7.0 on x86-64.
3554
4446092a
EZ
35552012-05-26 Eli Zaretskii <eliz@gnu.org>
3556
3557 * bidi.c (bidi_mirror_char): Revert last change: an int is
3558 definitely wide enough here.
3559
42b2a986 35602012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3561
42b2a986 3562 Fix integer width and related bugs (Bug#9874).
eb106a49 3563 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3564 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3565 (string_bytes, check_sblock, allocate_string_data):
3566 (compact_small_strings, Fmake_bool_vector, make_string)
3567 (make_unibyte_string, make_multibyte_string)
3568 (make_string_from_bytes, make_specified_string)
3569 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3570 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3571 (mark_vectorlike):
3572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3573 (allocate_pseudovector):
3574 Use int, not EMACS_INT, where int is wide enough.
3575 (inhibit_garbage_collection, Fgarbage_collect):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3578 int might not be wide enough.
3579 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3580 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3581 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3582 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3583 (bidi_level_of_next_char, bidi_move_to_visually_next):
3584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3585 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3586 (Fkill_buffer, Fset_buffer_major_mode)
3587 (advance_to_char_boundary, Fbuffer_swap_text)
3588 (Fset_buffer_multibyte, overlays_at, overlays_in)
3589 (overlay_touches_p, struct sortvec, record_overlay_string)
3590 (overlay_strings, recenter_overlay_lists)
3591 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3592 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3593 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3594 (Foverlay_recenter, last_overlay_modification_hooks_used)
3595 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3597 (validate_region): Omit unnecessary test for b <= e,
3598 since that's guaranteed by the previous test.
d311d28c
PE
3599 (adjust_overlays_for_delete): Avoid pos + length overflow.
3600 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3601 (report_overlay_modification):
3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3603 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3604 Omit pointer cast, which isn't needed anyway, and doesn't work
3605 after the EMACS_INT -> ptrdiff_t change.
02481186 3606 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3607 * buffer.h: Adjust decls to match defn changes elsewhere.
3608 (struct buffer_text, struct buffer):
3609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3610 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3611 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3612 not int, to avoid needless 32-bit limit on 64-bit hosts.
3613 (exec_byte_code): Use tighter memory-full test, one that checks
3614 for alloca overflow. Don't compute the address of the object just
3615 before an array, as that's not portable. Use EMACS_INT, not
3616 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3617 * callint.c (Fcall_interactively):
3618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3619 * callproc.c (call_process_kill, Fcall_process):
3620 Don't assume pid_t fits into an Emacs fixnum.
3621 (call_process_cleanup, Fcall_process, child_setup):
3622 Don't assume pid_t fits into int.
3623 (call_process_cleanup, Fcall_process, delete_temp_file)
3624 (Fcall_process_region):
3625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3626 (Fcall_process): Simplify handling of volatile integers.
3627 Use int, not EMACS_INT, where int will do.
3628 * casefiddle.c (casify_object, casify_region, operate_on_word)
3629 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3631 (casify_object): Avoid integer overflow when overallocating buffer.
3632 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3633 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3634 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3635 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3636 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3637 integers are now checked earlier. All uses replaced with XINT.
3638 (ccl_driver):
3639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3640 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3641 (ccl_driver, Fregister_code_conversion_map):
3642 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3643 (resolve_symbol_ccl_program): Check that vector header is in range.
3644 Always copy the vector, so that we can check its contents reliably
3645 now rather than having to recheck each instruction as it's being
3646 executed. Check that vector words fit in 'int'.
3647 (ccl_get_compiled_code, Fregister_ccl_program)
3648 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3649 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3650 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3651 contents are in range.
3652 (Fccl_execute_on_string): Check that status is in range.
3653 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3654 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3655 Accept and return EMACS_INT, not int, because callers can pass values
3656 out of 'int' range.
3657 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3658 (multibyte_chars_in_text, parse_str_as_multibyte)
3659 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3660 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3661 (string_escape_byte8, Fget_byte):
3662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3663 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3664 avoid mishandling large integers.
3665 * character.h: Adjust decls to match defn changes elsewhere.
3666 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3667 (Ffind_charset_region):
3668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3669 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3670 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3671 Don't assume fixnum fits in int.
d311d28c
PE
3672 (load_charset_map_from_vector, Fmap_charset_chars):
3673 Remove now-unnecessary CHECK_NATNUMs.
3674 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3675 Don't rely on undefined behavior with signed left shift overflow.
3676 Don't assume unsigned int fits into fixnum, or that fixnum fits
3677 into unsigned int. Don't require max_code to be a valid fixnum;
3678 that's not true for gb10830 4-byte on a 32-bit host. Allow
3679 invalid_code to be a cons, for the same reason. Require code_offset
3680 to be a character. Avoid int overflow if max_char is close
3681 to INT_MAX.
3682 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3683 this is intended anyway and avoids some undefined behavior.
3684 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3685 INDEX_TO_CODE_POINT, as that's what it expects.
3686 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3687 * charset.h (DECODE_CHAR): Return int, not unsigned;
3688 this is what was intended anyway, and it avoids undefined behavior.
3689 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3690 integer-overflow issues.
3691 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3692 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3693 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3694 * chartab.c (Fmake_char_table, Fset_char_table_range)
3695 (uniprop_get_decoder, uniprop_get_encoder):
3696 Don't assume fixnum fits in int.
3697 * cmds.c (move_point): New function, that does the gist of
3698 Fforward_char and Fbackward_char, but does so while checking
3699 for integer overflow more accurately.
c96e5d6a 3700 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3701 (Fforward_line, Fend_of_line, internal_self_insert)
3702 (internal_self_insert):
3703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3704 Fix a FIXME, by checking for integer overflow when calculating
3705 target_clm and actual_clm.
3706 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3707 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3708 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3709 (coding_alloc_by_making_gap, alloc_destination)
3710 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3711 (encode_coding_utf_16, detect_coding_emacs_mule)
3712 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3713 (detect_coding_iso_2022, decode_coding_iso_2022)
3714 (encode_invocation_designation, encode_designation_at_bol)
3715 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3716 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3717 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3718 (encode_coding_ccl, encode_coding_raw_text)
3719 (detect_coding_charset, decode_coding_charset)
3720 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3721 (produce_composition, produce_charset, produce_annotation)
3722 (decode_coding, handle_composition_annotation)
3723 (handle_charset_annotation, consume_chars, decode_coding_gap)
3724 (decode_coding_object, encode_coding_object, detect_coding_system)
3725 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3726 (code_convert_region, code_convert_string)
8f50130c
PE
3727 (Fdefine_coding_system_internal)
3728 (coding_set_source, coding_set_destination):
d311d28c
PE
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3731 (Fdefine_coding_system_internal):
3732 Don't assume fixnums fit in int.
3733 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3734 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3735 (Funencodable_char_position, Fcheck_coding_systems_region)
3736 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3738 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3739 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3740 Don't access memory outside of the args array.
d311d28c 3741 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3742 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3743 result of ENCODE_CHAR.
d311d28c
PE
3744 * coding.h: Adjust decls to match defn changes elsewhere.
3745 (struct coding_system):
3746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3747 * composite.c (get_composition_id, find_composition)
3748 (run_composition_function, update_compositions)
3749 (compose_text, composition_gstring_put_cache)
3750 (composition_gstring_p, composition_gstring_width)
3751 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3752 (composition_compute_stop_pos, composition_reseat_it)
3753 (composition_update_it, struct position_record)
3754 (find_automatic_composition, composition_adjust_point)
3755 (Fcomposition_get_gstring, Ffind_composition_internal):
3756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3757 (update_compositions):
3758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3759 * composite.h: Adjust decls to match defn changes elsewhere.
3760 (struct composition):
3761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3762 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3763 Do not attempt to compute the address of the object just before a
3764 buffer; this is not portable.
3765 (Faref, Faset):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 (Faset): Use int, not EMACS_INT, where int is wide enough.
3768 (Fstring_to_number): Don't assume fixnums fit in int.
3769 (Frem): Don't assume arg is nonnegative.
3770 * dbusbind.c (xd_append_arg): Check for integers out of range.
3771 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3772 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3773 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3774 (xd_get_connection_references): Return ptrdiff_t, not int.
3775 All uses changed.
3776 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3777 (xd_read_message_1):
3778 Use int, not unsigned, where the dbus API uses int.
3779 (Fdbus_message_internal): Don't overflow mtype.
3780 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3781 * dired.c (directory_files_internal, file_name_completion, scmp)
3782 (file_name_completion_stat):
3783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3784 (file_name_completion): Don't overflow matchcount.
3785 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3786 * dispextern.h: Adjust decls to match defn changes elsewhere.
3787 (struct text_pos, struct glyph, struct bidi_saved_info)
3788 (struct bidi_string_data, struct bidi_it, struct composition_it)
3789 (struct it):
3790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3791 (struct display_pos, struct composition_it, struct it):
3792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3793 * dispnew.c (increment_matrix_positions)
3794 (increment_row_positions, mode_line_string)
3795 (marginal_area_string):
3796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3797 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 (duration_to_sec_usec): New function, to check for overflow better.
3800 (Fsleep_for, sit_for): Use it.
3801 * doc.c (get_doc_string, store_function_docstring):
3802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3803 (get_doc_string, Fsnarf_documentation):
3804 Use int, not EMACS_INT, where int is wide enough.
3805 (get_doc_string):
3806 Use SAFE_ALLOCA, not alloca.
3807 Check for overflow when converting EMACS_INT to off_t.
3808 * doprnt.c (doprnt):
3809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3810 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3811 Don't assume uid_t fits into fixnum.
3812 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3813 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3814 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3815 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3816 (general_insert_function)
3817 (Finsert_char, make_buffer_string, make_buffer_string_both)
3818 (update_buffer_properties, Fbuffer_substring)
3819 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3820 (Fsubst_char_in_region, check_translation)
3821 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3822 (transpose_markers, Ftranspose_regions):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3824 (clip_to_bounds): Move to lisp.h as an inline function).
3825 (Fconstrain_to_field): Don't assume integers are nonnegative.
3826 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3827 (Fsubst_char_in_region, Fsave_restriction):
3828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3829 (Femacs_pid): Don't assume pid_t fits into fixnum.
3830 (lo_time): Use int, not EMACS_INT, when int suffices.
3831 (lisp_time_argument): Check for usec out of range.
3832 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3833 (Fuser_login_name, Fuser_full_name): Signal an error
3834 if a uid argument is out of range, rather than relying on
3835 undefined behavior.
c8d5c857
PE
3836 (Fformat_time_string): Remove now-unnecessary check.
3837 lisp_time_argument checks for out-of-range usec now.
243e0530 3838 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3839 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3840 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3841 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3842 (init_cmdargs, Fdump_emacs):
3843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3844 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3845 the bottom (typically) 32 bits of the fixnum.
3846 * eval.c (specpdl_size, call_debugger):
3847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3848 (when_entered_debugger, Fbacktrace_debug):
3849 Don't assume fixnum can fit in int.
3850 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3851 the object just before a buffer; this is not portable.
3852 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3853 (grow_specpdl, unbind_to):
3854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3855 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3856 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3857 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3858 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3859 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3861 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3862 (a_write, e_write):
3863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3864 (Fcopy_file, non_regular_nbytes, read_non_regular)
3865 (Finsert_file_contents):
3866 Use int, not EMACS_INT, where int is wide enough.
3867 (READ_BUF_SIZE): Verify that it fits in int.
3868 (Finsert_file_contents): Check that counts are in proper range,
3869 rather than assuming fixnums fit into ptrdiff_t etc.
3870 Don't assume fixnums fit into int.
125b3835 3871 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3872 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3873 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3874 (string_char_to_byte, string_byte_to_char)
3875 (string_make_multibyte, string_to_multibyte)
3876 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3877 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3878 (substring_both, Fdelete, internal_equal, Ffillarray)
3879 (Fclear_string, mapcar1)
3880 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3881 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3882 (larger_vector, make_hash_table, maybe_resize_hash_table)
3883 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3884 (Fmaphash, secure_hash):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3886 (concat): Check for string index and length overflow.
3887 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3888 (Frequire):
3889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3890 (larger_vector): New API (vec, incr_min, size_max) replaces old
3891 one (vec, new_size, init). This catches size overflow.
3892 INIT was removed because it was always Qnil.
3893 All callers changed.
3894 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3895 the upper bound on a hash table index size.
3896 (make_hash_table, maybe_resize_hash_table): Use it.
3897 (secure_hash): Computer start_byte and end_byte only after
3898 they're known to be in ptrdiff_t range.
3899 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3900 (Ffont_get_glyphs, Ffont_at):
3901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3902 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3903 (Flist_fonts, Fopen_font):
3904 Don't assume fixnum can fit in int.
3905 (check_gstring): Don't assume index can fit in int.
3906 (font_match_p): Check that fixnum is a character, not a nonnegative
3907 fixnum, since the later code needs to stuff it into an int.
3908 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3909 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3910 conversion overflow issues.
3911 (Fopen_font): Check for integer out of range.
3912 (Ffont_get_glyphs): Don't assume index can fit in int.
3913 * font.h: Adjust decls to match defn changes elsewhere.
3914 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3915 integer overflow.
3916 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3917 printmax_t, where ptrdiff_t is wide enough.
3918 (Finternal_char_font):
3919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3920 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3921 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3922 (Fset_frame_position, x_set_frame_parameters)
3923 (x_set_line_spacing, x_set_border_width)
3924 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3925 Check that fixnums are in proper range for system types.
3926 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3929 Use SAFE_ALLOCA_LISP, not alloca.
3930 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3931 intptr_t is wide enough.
3932 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3933 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3934 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3935 Check for fixnum out of range.
3936 * ftfont.c (ftfont_list): Don't assume index fits in int.
3937 Check that fixnums are in proper range for system types.
3938 (ftfont_shape_by_flt):
3939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3940 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3942 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3943 Check that fixnums are in proper range for system types.
3944 * gnutls.h: Adjust decls to match defn changes elsewhere.
3945 * gtkutil.c (xg_dialog_run):
3946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 (update_frame_tool_bar):
3948 Check that fixnums are in proper range for system types.
3949 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3950 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3951 * indent.c (last_known_column, last_known_column_point):
3952 (current_column_bol_cache):
3953 (skip_invisible, current_column, check_display_width):
3954 (check_display_width, scan_for_column, current_column_1)
3955 (Findent_to, Fcurrent_indentation, position_indentation)
3956 (indented_beyond_p, Fmove_to_column, compute_motion):
3957 (Fcompute_motion, Fvertical_motion):
3958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3959 (last_known_column_modified): Use EMACS_INT, not int.
3960 (check_display_width):
3961 (Fcompute_motion):
3962 Check that fixnums and floats are in proper range for system types.
3963 (compute_motion): Don't assume index or fixnum fits in int.
3964 (compute_motion, Fcompute_motion):
3965 Use int, not EMACS_INT, when it is wide enough.
3966 (vmotion): Omit local var start_hpos that is always 0; that way
3967 we don't need to worry about overflow in expressions involving it.
3968 * indent.h: Adjust decls to match defn changes elsewhere.
3969 (struct position):
3970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3971 Use int, not EMACS_INT, where int is wide enough.
3972 Remove unused members ovstring_chars_done and tab_offset;
3973 all uses removed.
3974 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3975 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3976 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3977 (make_gap, copy_text, insert, insert_and_inherit)
3978 (insert_before_markers, insert_before_markers_and_inherit)
3979 (insert_1, count_combining_before, count_combining_after)
3980 (insert_1_both, insert_from_string)
3981 (insert_from_string_before_markers, insert_from_string_1)
3982 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3983 (adjust_after_replace, adjust_after_insert, replace_range)
3984 (replace_range_2, del_range, del_range_1, del_range_byte)
3985 (del_range_both, del_range_2, modify_region)
3986 (prepare_to_modify_buffer, signal_before_change)
3987 (signal_after_change, Fcombine_after_change_execute):
3988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3989 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3990 (balance_an_interval, split_interval_right, split_interval_left)
3991 (find_interval, next_interval, update_interval)
3992 (adjust_intervals_for_insertion, delete_node, delete_interval)
3993 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3994 (static_offset_intervals, offset_intervals)
3995 (merge_interval_right, merge_interval_left, make_new_interval)
3996 (graft_intervals_into_buffer, temp_set_point_both)
3997 (temp_set_point, set_point, adjust_for_invis_intang)
3998 (set_point_both, move_if_not_intangible, get_property_and_range)
3999 (get_local_map, copy_intervals, copy_intervals_to_string)
4000 (compare_string_intervals, set_intervals_multibyte_1):
4001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4002 * intervals.h: Adjust decls to match defn changes elsewhere.
4003 (struct interval):
4004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4005 * keyboard.c (this_command_key_count, this_single_command_key_start)
4006 (before_command_key_count, before_command_echo_length, echo_now)
4007 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4008 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4009 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4010 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4012 (last_non_minibuf_size, last_point_position, echo_truncate)
4013 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4014 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4015 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4016 (stuff_buffered_input):
4017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4018 (last_auto_save, command_loop_1, read_char):
4019 Use EMACS_INT, not int, to avoid integer overflow.
4020 (record_char): Avoid overflow in total_keys computation.
4021 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4022 * keyboard.h: Adjust decls to match defn changes elsewhere.
4023 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4024 (Fkey_description, Fdescribe_vector, Flookup_key):
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4026 (click_position): New function, to check that positions are in range.
4027 (Fcurrent_active_maps):
4028 (describe_command):
4029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4030 (Faccessible_keymaps, Fkey_description):
4031 (preferred_sequence_p):
4032 Don't assume fixnum can fit into int.
4033 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4034 Check for integer overflow in size calculations.
4035 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4036 avoid mishandling large integers.
4037 * lisp.h: Adjust decls to match defn changes elsewhere.
4038 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4039 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4040 (struct Lisp_Marker):
4041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4042 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4043 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4044 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4045 All callers changed.
4046 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4047 Assume the arg has valid form, since it always does.
4048 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4049 unsigned integer system type.
4050 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4051 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4053 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4054 (duration_to_sec_usec): New decl.
4055 * lread.c (read_from_string_index, read_from_string_index_byte)
4056 (read_from_string_limit, readchar, unreadchar, openp)
4057 (read_internal_start, read1, oblookup):
4058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4059 (Fload, readevalloop, Feval_buffer, Feval_region):
4060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4061 (openp): Check for out-of-range argument to 'access'.
4062 (read1): Use int, not EMACS_INT, where int is wide enough.
4063 Don't assume fixnum fits into int.
6efdadfd 4064 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4065 (read_filtered_event): Use duration_to_sec_usec
4066 to do proper overflow checking on durations.
d311d28c
PE
4067 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4068 in size calculation.
4069 (Fexecute_kbd_macro):
4070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4071 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4072 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4073 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4074 (set_marker_both, set_marker_restricted_both, marker_position)
4075 (marker_byte_position, Fbuffer_has_markers_at):
4076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4077 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4078 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4079 It now merely ensures that the menu is large enough, without
4080 necessarily growing it, as this avoids some integer overflow issues.
4081 All callers changed.
4082 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4084 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4085 Use SAFE_ALLOCA_LISP, not alloca.
4086 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4087 to EMACS_INT. Check that fixnums are in proper range for system types.
4088 * minibuf.c (minibuf_prompt_width, string_to_object)
4089 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4090 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (get_minibuffer, read_minibuf_unwind):
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4095 this simplifies overflow checking. All callers changed.
4096 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4097 (Ftest_completion):
4098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4099 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4100 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4101 Check that fixnums are in proper range for system types.
4102 (Fx_create_frame, Fx_show_tip):
4103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4104 * nsfont.m (ns_findfonts, nsfont_list_family):
4105 Don't assume fixnum fits in long.
4106 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4108 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4109 wide enough.
17fdb222 4110 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4112 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4113 (PRINTDECLARE, PRINTPREPARE):
4114 (strout, print_string):
4115 (print, print_preprocess, print_check_string_charset_prop)
4116 (print_object):
4117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4118 (PRINTDECLARE):
4119 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4121 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4122 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4123 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4124 (print_error_message): Use SAFE_ALLOCA, not alloca.
4125 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4126 (print_depth, new_backquote_output, print_number_index):
4127 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4128 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4129 (Fset_process_window_size, Fformat_network_address)
4130 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4131 (sigchld_handler):
d311d28c 4132 Check that fixnums are in proper range for system types.
d44287d4 4133 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4134 Check for process-ids out of pid_t range rather than relying on
4135 undefined behavior.
e4d81efc 4136 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4137 (Fformat_network_address, read_process_output, send_process)
4138 (Fprocess_send_region, status_notify):
4139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4140 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4141 (wait_reading_process_output, read_process_output, exec_sentinel):
4142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4143 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4144 (Faccept_process_output): Use duration_to_sec_usec to do proper
4145 overflow checking on durations.
dde14581
PE
4146 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4147 Don't assume pid_t fits in int.
02481186
PE
4148 * process.h (struct Lisp_Process): Members tick and update_tick
4149 are now of type EMACS_INT, not int.
b62b53e8
PE
4150 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4151 configured --with-wide-int.
d311d28c
PE
4152 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4153 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4154 * search.c (looking_at_1, string_match_1):
4155 (fast_string_match, fast_c_string_match_ignore_case)
4156 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4157 (scan_newline, find_before_next_newline, search_command)
4158 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4159 (set_search_regs, wordify):
4160 (Freplace_match):
4161 (Fmatch_data):
4162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4163 (string_match_1, search_buffer, set_search_regs):
4164 (Fmatch_data):
4165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4166 (wordify): Check for overflow in size calculation.
4167 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4168 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4169 Check that fixnums are in proper range for system types.
4170 * sound.c (struct sound_device)
4171 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4173 (Fplay_sound_internal):
4174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4175 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4176 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4177 (Fparse_partial_sexp):
4178 Don't assume fixnums can fit in int.
4179 (struct lisp_parse_state, find_start_pos, find_start_value)
4180 (find_start_value_byte, find_start_begv)
4181 (update_syntax_table, char_quoted, dec_bytepos)
4182 (find_defun_start, prev_char_comend_first, back_comment):
4183 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4184 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4186 (Finternal_describe_syntax_value): Check that match_lisp is a
4187 character, not an integer, since the code stuffs it into int.
4188 (scan_words, scan_sexps_forward):
4189 Check that fixnums are in proper range for system types.
4190 (Fforward_word):
4191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4192 (scan_sexps_forward):
4193 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4194 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4195 * syntax.h: Adjust decls to match defn changes elsewhere.
4196 (struct gl_state_s):
4197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4198 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4199 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4200 * sysdep.c (wait_for_termination_1, wait_for_termination)
4201 (interruptible_wait_for_termination, mkdir):
4202 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4203 (emacs_read, emacs_write):
4204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4205 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4206 and double all fit in int.
d311d28c
PE
4207 * term.c (set_tty_color_mode):
4208 Check that fixnums are in proper range for system types.
4209 * termhooks.h (struct input_event):
4210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4211 * textprop.c (validate_interval_range, interval_of)
4212 (Fadd_text_properties, set_text_properties_1)
4213 (Fremove_text_properties, Fremove_list_of_text_properties)
4214 (Ftext_property_any, Ftext_property_not_all)
4215 (copy_text_properties, text_property_list, extend_property_ranges)
4216 (verify_interval_modification):
4217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4218 (Fnext_single_char_property_change)
4219 (Fprevious_single_char_property_change):
4220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4221 (copy_text_properties):
4222 Check for integer overflow in index calculation.
d311d28c
PE
4223 * undo.c (last_boundary_position, record_point, record_insert)
4224 (record_delete, record_marker_adjustment, record_change)
4225 (record_property_change):
4226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4227 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4229 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4230 (Fx_hide_tip, Fx_file_dialog):
4231 * w32menu.c (set_frame_menubar):
4232 Use ptrdiff_t, not int, for consistency with rest of code.
4233 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4234 (select_window, Fdelete_other_windows_internal)
4235 (window_scroll_pixel_based, window_scroll_line_based)
4236 (Frecenter, Fset_window_configuration):
4237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4238 (Fset_window_hscroll, run_window_configuration_change_hook)
4239 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4240 (Fscroll_other_window, Frecenter):
d311d28c
PE
4241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4242 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4243 Don't assume fixnum fits in int.
4244 (Fset_window_scroll_bars):
4245 Check that fixnums are in proper range for system types.
4246 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4247 (string_pos, c_string_pos, number_of_chars, init_iterator)
4248 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4249 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4250 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4251 (face_before_or_after_it_pos, handle_invisible_prop)
4252 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4253 (display_prop_intangible_p, string_buffer_position_lim)
4254 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4255 (get_overlay_strings_1, get_overlay_strings)
4256 (iterate_out_of_display_property, forward_to_next_line_start)
4257 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4258 (get_next_display_element, set_iterator_to_next)
4259 (get_visually_first_element, compute_stop_pos_backwards)
4260 (handle_stop_backwards, next_element_from_buffer)
4261 (move_it_in_display_line_to, move_it_in_display_line)
4262 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4263 (add_to_log, message_dolog, message_log_check_duplicate)
4264 (message2, message2_nolog, message3, message3_nolog
4265 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4266 (current_message_1, truncate_echo_area, truncate_message_1)
4267 (set_message, set_message_1, store_mode_line_noprop)
4268 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4269 (text_outside_line_unchanged_p, check_point_in_composition)
4270 (reconsider_clip_changes)
4271 (redisplay_internal, set_cursor_from_row, try_scrolling)
4272 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4273 (redisplay_window, find_last_unchanged_at_beg_row)
4274 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4275 (trailing_whitespace_p, find_row_edges, display_line)
4276 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4277 (display_mode_element, store_mode_line_string)
4278 (pint2str, pint2hrstr, decode_mode_spec)
4279 (display_count_lines, display_string, draw_glyphs)
4280 (x_produce_glyphs, x_insert_glyphs)
4281 (rows_from_pos_range, mouse_face_from_buffer_pos)
4282 (fast_find_string_pos, mouse_face_from_string_pos)
4283 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4285 (safe_call, init_from_display_pos, handle_fontified_prop)
4286 (handle_single_display_spec, load_overlay_strings)
4287 (with_echo_area_buffer, setup_echo_area_for_printing)
4288 (display_echo_area, echo_area_display)
4289 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4290 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4291 (redisplay_window, dump_glyph_row, display_mode_line)
4292 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4293 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4295 (handle_single_display_spec, build_desired_tool_bar_string)
4296 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4297 (get_specified_cursor_type):
4298 Check that fixnums are in proper range for system types.
4299 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4300 (Flookup_image_map):
4301 Don't assume fixnums fit in int.
4302 (compare_overlay_entries):
4303 Avoid mishandling comparisons due to subtraction overflow.
4304 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4305 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4306 (handle_tool_bar_click):
4307 Use int, not unsigned, since we prefer signed and the signedness
4308 doesn't matter here.
4309 (get_next_display_element, next_element_from_display_vector):
4310 Use int, not EMACS_INT, when int is wide enough.
4311 (start_hourglass): Use duration_to_sec_usec to do proper
4312 overflow checking on durations.
4313 * xfaces.c (Fbitmap_spec_p):
4314 Check that fixnums are in proper range for system types.
4315 (compare_fonts_by_sort_order):
4316 Avoid mishandling comparisons due to subtraction overflow.
4317 (Fx_family_fonts, realize_basic_faces):
4318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4319 (Fx_family_fonts):
4320 Don't assume fixnum fits in int.
4321 Use SAFE_ALLOCA_LISP, not alloca.
4322 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4323 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4324 (face_at_buffer_position, face_for_overlay_string)
4325 (face_at_string_position):
4326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4327 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4328 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4329 (Fx_show_tip):
4330 Check that fixnums are in proper range for system types.
4331 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4332 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4334 (Fx_change_window_property): Don't assume fixnums fit in int.
4335 * xfont.c (xfont_chars_supported):
4336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4337 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4338 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 * xml.c (parse_region):
4341 * xrdb.c (magic_file_p):
4342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4343 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4344 (x_get_local_selection, x_reply_selection_request)
4345 (x_handle_selection_request, wait_for_property_change):
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4348 short is wide enough.
4349 (x_send_client_event): Don't assume fixnum fits in int.
4350 * xterm.c (x_x_to_emacs_modifiers):
4351 Don't assume EMACS_INT overflows nicely into int.
4352 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4353 may come from Lisp.
4354 (handle_one_xevent): NATNUMP can eval its arg twice.
4355 (x_connection_closed):
4356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4357 * xterm.h: Adjust decls to match defn changes elsewhere.
4358 (struct scroll_bar): Use struct vectorlike_header
4359 rather than rolling our own approximation.
4360 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4361
c6574eb5
GM
43622012-05-25 Glenn Morris <rgm@gnu.org>
4363
4364 * lisp.mk (lisp): Update for more files being compiled now.
4365
e8d32c7e
SM
43662012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4367
48def666
SM
4368 * lread.c: Remove `read_pure' which makes no difference.
4369 (read_pure): Remove var.
4370 (unreadpure): Remove function.
4371 (readevalloop): Don't call read_list with -1 flag.
4372 (read1, read_vector): Don't test read_pure any more.
4373 (read_list): Simplify.
4374
e8d32c7e
SM
4375 * fileio.c, character.h: Minor style tweaks.
4376
4b2addb7
DA
43772012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4378
4379 * window.h (clip_changed): Remove useless declaration.
4380
584461b2
JB
43812012-05-22 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4384 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4385
34374650
PE
43862012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4387
4388 Remove src/m/*.
4389 This directory predates autoconf and is no longer needed nowadays.
4390 Move its few remaining bits of functionality to where they're needed.
4391 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4392 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4393 * m/template.h: Remove.
4394 * Makefile.in (M_FILE): Remove. All uses removed.
4395 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4396 * lisp.h (USE_LSB_TAG):
4397 * mem-limits.h (EXCEEDS_LISP_PTR):
4398 Use VAL_MAX, not VALBITS, in #if.
4399 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4400 (EMACS_UINT): Define unconditionally now.
4401 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4402 (BITS_PER_EMACS_INT): New constants, replacing
4403 what used to be in config.h, but not useful in #if.
4404 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4405 define them any more.
4406 (VAL_MAX): New macro.
4407 (VALMASK): Use it.
4408 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4409 BITS_PER_EMACS_INT, in #if.
4410 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4411 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4412 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4413 * s/ms-w32.h (DATA_START):
4414 Move here from removed file m/intel386.h.
4415 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4416 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4417
261cb4bb
PE
44182012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4419
4420 Assume C89 or later.
4421 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4422 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4423 (xrealloc):
4424 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4425 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4426 * textprop.c, tparam.c (NULL): Remove.
4427 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4428 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4429 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4430 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4431 * xterm.c (input_signal_count): Assume volatile works.
4432
ff23cd9f
KB
44332012-05-21 Ken Brown <kbrown@cornell.edu>
4434
4435 * xgselect.c (xg_select): Fix first argument in call to 'select'
4436 (bug#11508).
4437
1b170bc6
KB
44382012-05-20 Ken Brown <kbrown@cornell.edu>
4439
4440 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4441 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4442
b2f4d39f
KB
44432012-05-19 Ken Brown <kbrown@cornell.edu>
4444
4445 * xfns.c (x_in_use): Remove `static' qualifier.
4446 * xterm.h (x_in_use): Declare.
4447 * xgselect.c: Include xterm.h.
4448 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4449 and `display_arg' (bug#9754).
4450
003fdae2
PE
44512012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4452
9232a6d9
PE
4453 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4454
003fdae2
PE
4455 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4456 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4457
784b56e2
EZ
44582012-05-18 Eli Zaretskii <eliz@gnu.org>
4459
4460 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4461
4462 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4463 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4464
4465 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4466 reference to image_cache->refcount.
4467 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4468
a0a79cde
JL
44692012-05-17 Juri Linkov <juri@jurta.org>
4470
4471 * search.c (Fword_search_regexp, Fword_search_backward)
4472 (Fword_search_forward, Fword_search_backward_lax)
4473 (Fword_search_forward_lax): Move functions to isearch.el
4474 (bug#10145, bug#11381).
4475
b0572523
PE
44762012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4479
9660f5fc
SM
44802012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4481
4482 * lread.c (init_obarray): Declare Qt and Qnil as special.
4483
4374de83
GM
44842012-05-14 Glenn Morris <rgm@gnu.org>
4485
4486 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4487 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4488
dc44c39a
PE
44892012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4490
078c97cb
PE
4491 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4492
dc44c39a
PE
4493 * unexaix.c: Port to more-recent AIX compilers.
4494 (report_error, report_error_1, make_hdr, copy_sym)
4495 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4496 Make arguments const char *, not char *, to avoid violations of C
4497 standard and to fix some AIX warnings reported by Gilles Pion.
4498
e18afed7 44992012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4500
4501 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4502 already have overlays loaded.
4503 (handle_single_display_spec): Before returning without displaying
4504 fringe bitmap, synchronize the bidi iterator with the main display
4505 iterator, by calling iterate_out_of_display_property.
4506 (iterate_out_of_display_property): Detect buffer iteration by
4507 testing that it->string is a Lisp string.
4508 (get_next_display_element): When the current object is exhausted,
4509 and there's something on it->stack, call set_iterator_to_next to
4510 proceed with what's on the stack, instead of returning zero.
4511 (set_iterator_to_next): If called at the end of a Lisp string,
4512 proceed to consider_string_end without incrementing string
4513 position. Don't increment display vector index past the end of
4514 the display vector. (Bug#11417)
c8fb9dc6
EZ
4515 (pos_visible_p): Don't report a position visible when move_it_to
4516 stopped at the last line of window, which happens to be scanned
4517 backwards by the bidi iteration. (Bug#11464)
ac268e67 4518
e18afed7 45192012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4520
4521 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4522 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4523 are on a TTY, and thus unable to display on the fringes.
4524 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4525 so we need to signal to the caller that this is a "replacing"
4526 display spec. This fixes display when the spec is invalid or we
4527 are on a TTY.
4528
e18afed7 45292012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4530
4531 * unexaix.c (make_hdr): Fix typo in prototype.
4532 This bug broke the build on AIX. Problem reported by Gilles Pion.
4533
9d0a235a
MA
45342012-05-14 Michael Albinus <michael.albinus@gmx.de>
4535
4536 * keyboard.c (kbd_buffer_get_event): Read special events also in
4537 batch mode. (Bug#11415)
4538
9e6b06ed
GM
45392012-05-12 Glenn Morris <rgm@gnu.org>
4540
4541 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4542
c1a1d7a3
EZ
45432012-05-12 Eli Zaretskii <eliz@gnu.org>
4544
4545 * lisp.mk (lisp): Add newcomment.elc.
4546
3fe7cdc8
GM
45472012-05-12 Glenn Morris <rgm@gnu.org>
4548
4549 * Makefile.in (MKDIR_P): New, set by configure.
4550 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4551
53f7d2c0
PE
45522012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 Remove unused function hourglass_started.
4555 * dispextern.h (hourglass_started):
4556 * w32fns.c (hourglass_started):
4557 * xdisp.c (hourglass_started): Remove.
4558
75aafb17
JB
45592012-05-10 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4562 Update dependencies.
4563
12959e8e
PE
45642012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4565
97107e2e
PE
4566 * xgselect.c (xg_select): Put maxfds+1 into a var.
4567 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4568
12959e8e
PE
4569 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4570
836d29b3
DA
45712012-05-10 Dave Abrahams <dave@boostpro.com>
4572
4573 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4574 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4575
5cb67954
MA
45762012-05-09 Michael Albinus <michael.albinus@gmx.de>
4577
4578 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4579 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4580 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4581 Initialize xd_registered_buses.
4582
3478ec45
PE
45832012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4584
b263a6b0
PE
4585 Untag more efficiently if USE_LSB_TAG.
4586 This is based on a proposal by YAMAMOTO Mitsuharu in
4587 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4588 For an admittedly artificial (nth 8000 longlist) benchmark on
4589 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4590 Emacs's overall text size by 1%.
4591 * lisp.h (XUNTAG): New macro.
4592 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4593 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4594 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4595 * eval.c (Fautoload):
4596 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4597 * frame.h (XFRAME): Use XUNTAG.
4598
3478ec45
PE
4599 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4600 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4601 Remove unportable assumptions about print widths of types like
4602 dbus_uint32_t.
4603 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4604 intptr_t when converting between pointer and integer, to avoid GCC
4605 warnings about wrong width.
4606
666b903b 46072012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4608
4609 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4610 stack for each reader_thread, instead of defaulting to 8MB
4611 determined by the linker. This avoids failures in creating
4612 subprocesses on Windows 7, see the discussion in this thread:
4613 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4614
b120cc17
JC
46152012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4616
4617 Fix up display of the *Minibuf-0* buffer in the mini window.
4618 * keyboard.c (read_char): Don't clear the echo area if there's no
4619 message to clear.
4620 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4621 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4622
9a4b36f8
MA
46232012-05-07 Michael Albinus <michael.albinus@gmx.de>
4624
4625 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4626 batch mode.
4627
e5f9458f
CY
46282012-05-06 Chong Yidong <cyd@gnu.org>
4629
4630 * lisp.mk (lisp): Update.
4631
eceeb5fc 46322012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4633
4634 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4635
71873e2b
SM
46362012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4637
4638 * data.c (PUT_ERROR): New macro.
4639 (syms_of_data): Use it. Add new error type `user-error'.
4640 * undo.c (user_error): New function.
4641 (Fprimitive_undo): Use it.
4642 * print.c (print_error_message): Adjust print style for `user-error'.
4643 * keyboard.c (user_error): New function.
4644 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4645
ab0fa4e4
PE
46462012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4647
4648 Do not limit current-time-string to years 1000..9999.
4649 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4650 (Fcurrent_time_string): Support any year that is supported by the
4651 underlying localtime representation. Don't use asctime, as it
4652 has undefined behavior for years outside the range -999..9999.
4653
7ed806a7
PE
46542012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4655
4656 Fix race conditions involving setenv, gmtime, localtime, asctime.
4657 Without this fix, interrupts could mess up code that uses these
4658 nonreentrant functions, since setting TZ invalidates existing
4659 tm_zone or tzname values, and since most of these functions return
4660 pointers to static storage.
4661 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4662 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4663 Grow the critical sections to include not just invoking
4664 localtime/gmtime, but also accessing these functions' results
4665 including their tm_zone values if any, and any related TZ setting.
4666 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4667 so that the struct tm is saved in the critical section.
4668 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4669 motivated by the fact that memory allocation needs to be outside
4670 the critical section.
4671
0c16dfed
DA
46722012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4673
4674 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4675 with RESET_INTERVAL.
4676
4677 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4678 Remove duplicated buffer name initialization.
4679
3f83ace8
JM
46802012-05-02 Jim Meyering <jim@meyering.net>
4681
4682 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4683
c7b8541e
JM
4684 * xfns.c (x_window): Use xstrdup (Bug#11375).
4685
90207a15 46862012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4687
4688 * xdisp.c (pos_visible_p): If already at a newline from the
4689 display string before the 'while' loop, don't walk back the glyphs
4690 from it3.glyph_row. Solves assertion violation when the display
4691 string begins with a newline (egg.el). (Bug#11367)
4692
b593d6a9
AH
46932012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4694
4695 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4696 Move to simple.el.
4697
4737362e
GM
46982012-05-01 Glenn Morris <rgm@gnu.org>
4699
99cf43f9
GM
4700 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4701 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4702 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4703 All were removed before 23.1.
4704
9311dcff
GM
4705 * dispnew.c: Remove HAVE_LIBNCURSES test;
4706 it is always true on relevant platforms.
4707
4d5c6349
GM
4708 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4709 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4710
4737362e
GM
4711 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4712
74dd3a6b
AS
47132012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4714
4715 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4716 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4717 Remove.
4718
13c379ee
PE
47192012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 Do not avoid creating empty evaporating overlays (Bug#9642).
4722 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4723 That is, do not delete an evaporating overlay if it becomes
4724 empty after its bounds are adjusted to fit within its buffer.
4725 This fix caused other problems, and I'm reverting it until we get
4726 to the bottom of them.
4727
a8e7d6d7 47282012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4729
4730 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4731
a8e7d6d7 47322012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4733
4734 * xdisp.c (pos_visible_p): If the window start position is beyond
4735 ZV, start the display from buffer beginning. Prevents assertion
4736 violation in init_iterator when the minibuffer window is scrolled
4737 via the scroll bar.
4738
4739 * window.c (window_scroll_pixel_based): Likewise.
4740
a8e7d6d7 47412012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4742
4743 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4744
a8e7d6d7 47452012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4746
4747 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4748 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4749
a8e7d6d7 47502012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4751
b593d6a9
AH
4752 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4753 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4754
1c6900d9
EZ
47552012-04-26 Eli Zaretskii <eliz@gnu.org>
4756
4c3fa1d9
EZ
4757 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4758 display element, check also the underlying string or buffer
4759 character. (Bug#11341)
4760
1c6900d9
EZ
4761 * w32menu.c: Include w32heap.h.
4762 (add_menu_item): If the call to AppendMenuW (via
4763 unicode_append_menu) fails, disable Unicode menus only if we are
4764 running on Windows 9X/Me.
4765
42bf8205
AS
47662012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4767
4768 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4769 (xgetint): Add missing shift for LSB tags.
4770
b1bac16e
MR
47712012-04-24 Martin Rudalics <rudalics@gmx.at>
4772
4773 * keyboard.c (read_char): Don't wipe echo area for select window
4774 events: These might get delayed via `mouse-autoselect-window'
4775 (Bug#11304).
4776
d69621cc
JB
47772012-04-24 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4780 manipulation of :loaded-from data.
4781
02fd101b
JB
47822012-04-23 Juanma Barranquero <lekktu@gmail.com>
4783
4784 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4785 now a cons (bug#11311).
4786
888bec30
PE
47872012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4788
89a438bd
PE
4789 Do not create empty overlays with the evaporate property (Bug#9642).
4790 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4791 if it becomes empty after its bounds are adjusted to fit within
4792 its buffer. Without this fix, in a nonempty buffer (let ((o
4793 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4794 yields an empty overlay that has the evaporate property, which is
4795 not supposed to happen.
4796
1068fe4d
PE
4797 Fix minor GTK3 problems found by static checking.
4798 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4799 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4800 (struct _EmacsFixedClass, emacs_fixed_get_type):
4801 Move decls here from emacsgtkfixed.h, since they needn't be public.
4802 (emacs_fixed_get_type): Now static.
4803 (emacs_fixed_class_init): Omit unused local.
4804 (emacs_fixed_child_type): Remove; unused.
4805 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4806 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4807 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4808 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4809 (EMACS_FIXED_GET_CLASS): Remove; unused.
4810 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4811
888bec30
PE
4812 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4813 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4814
de85e130
PE
48152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4816
d0baac98 4817 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4818 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4819 (__malloc_size_t, __malloc_ptrdiff_t):
4820 Remove. All uses removed, replaced by the definiens if needed,
4821 since we can assume C89 or better now.
4822 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4823 (protect_malloc_state, align, get_contiguous_space)
4824 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4825 (malloc_atfork_handler_child, malloc_enable_thread)
4826 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4827 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4828 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4829 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4830 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4831 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4832 Define using prototypes, not old style.
4833 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4834 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4835 (align): Don't assume that signed integer overflow wraps around.
4836 Omit unused local var.
4837 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4838 (_free_internal_nolock, memalign, mallochook, reallochook):
4839 Omit no-longer-needed casts.
4840 (valloc): Use getpagesize, not __getpagesize.
4841 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4842 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4843
de85e130
PE
4844 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4845
dcbf5805
MA
48462012-04-22 Michael Albinus <michael.albinus@gmx.de>
4847
4848 Move functions from C to Lisp. Make non-blocking method calls
4849 the default. Implement further D-Bus standard interfaces.
4850
4851 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4852 (QCdbus_request_name_allow_replacement)
4853 (QCdbus_request_name_replace_existing)
4854 (QCdbus_request_name_do_not_queue)
4855 (QCdbus_request_name_reply_primary_owner)
4856 (QCdbus_request_name_reply_in_queue)
4857 (QCdbus_request_name_reply_exists)
4858 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4859 (QCdbus_registered_serial, QCdbus_registered_method)
4860 (QCdbus_registered_signal): New Lisp objects.
4861 (XD_DEBUG_MESSAGE): Use sizeof.
4862 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4863 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4864 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4865 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4866 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4867 (xd_signature, xd_append_arg): Allow float for integer types.
4868 (xd_get_connection_references): New function.
b593d6a9
AH
4869 (xd_get_connection_address): Rename from xd_initialize.
4870 Return cached address.
dcbf5805
MA
4871 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4872 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4873 level.
4874 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4875 Return number of refcounts.
dcbf5805
MA
4876 (Fdbus_get_unique_name): Make stronger parameter check.
4877 (Fdbus_message_internal): New defun.
4878 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4879 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4880 (Fdbus_send_signal, Fdbus_register_service)
4881 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4882 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4883 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4884 (Vdbus_compiled_version, Vdbus_runtime_version)
4885 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4886 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4887 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4888 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4889 Adapt docstring.
dcbf5805 4890
52828e02
PE
48912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4892
da05bc4c
PE
4893 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4894 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4895 Do not assume ptrdiff_t is the same width as 'int'.
4896
52828e02
PE
4897 * alloc.c: Handle unusual debugging option combinations.
4898 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4899 since the two debugging options are incompatible.
4900 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4901 is defined.
4902 (mem_init, mem_insert, mem_insert_fixup):
4903 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4904 (NEED_MEM_INSERT): Remove; no longer needed.
4905
f01769f9
LL
49062012-04-22 Leo Liu <sdl.web@gmail.com>
4907
4908 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4909
5790543d
PE
49102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4911
4912 * sysdep.c [__FreeBSD__]: Minor cleanups.
4913 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4914 Use Emacs indenting style more consistently. Avoid some casts.
4915 Use 'double' consistently rather than mixing 'float' and 'double'.
4916
b91b7e4d
EW
49172012-04-21 Eduard Wiebe <usenet@pusto.de>
4918
b593d6a9
AH
4919 * sysdep.c (list_system_processes, system_process_attributes):
4920 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4921
6114eb15
AS
49222012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * lisp.mk (lisp): Update.
4925
2f38dff7
PE
49262012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4927
4928 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4929 It is never used otherwise.
4930
4ae29f89
SM
49312012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4932
4933 * print.c (print_preprocess): Only check print_depth if print-circle
4934 is nil.
4935 (print_object): Check for cycles even when print-circle is nil and
4936 print-gensym is t, but only check print_depth if print-circle is nil.
4937
f30d612a
CY
49382012-04-20 Chong Yidong <cyd@gnu.org>
4939
4940 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4941 set the status to "failed" and ensure that sentinel is run.
4942
c07a4c0b 49432012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4944
4945 * process.c (Fset_process_inherit_coding_system_flag)
4946 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4947 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4948
c07a4c0b 49492012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4950
4951 * xdisp.c (string_buffer_position_lim): Limit starting position to
4952 BEGV.
4953 (set_cursor_from_row): If called for a mode-line or header-line
4954 row, return zero immediately.
4955 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4956 farther than the first row after the header line, if any.
4957 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4958 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4959
c07a4c0b 49602012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4961
4ae29f89
SM
4962 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4963 (bug#11238).
ad3a2b41 4964
c07a4c0b 49652012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 49662012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4967
4968 configure: new option --enable-gcc-warnings (Bug#11207)
4969 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4970 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4971 (ALL_CFLAGS): Use new macros rather than old.
4972 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4973 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4974 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4975 -Wunused-result, -Wunused-variable. This should go away once
4976 the Emacs and Gnulib regex code is merged.
4977 (xmalloc, xrealloc): Now static.
4978
aba027e8
PE
49792012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4980
4981 * dired.c (Fsystem_groups): Remove unused local.
4982
e5a36063
GM
49832012-04-17 Glenn Morris <rgm@gnu.org>
4984
4985 * dired.c (Fsystem_users): Doc fix.
4986
316411f0
DA
49872012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4988
4989 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4990 (syms_of_dired): Add them.
4991
9426aba4
PE
49922012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4993
b62a57be
PE
4994 Fix minor alloc.c problems found by static checking.
4995 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4996 New extern decls, to avoid calling undeclared functions.
4997 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4998 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4999 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5000 (NEED_MEM_INSERT): New macro.
5001 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5002 Remove one incorrect comment and fix another.
b62a57be 5003
3539f31f
PE
5004 Fix minor ralloc.c problems found by static checking.
5005 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5006 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5007 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5008 (r_alloc_sbrk): Now static.
5009
a041960a
PE
5010 Improve ralloc.c interface checking.
5011 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5012 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5013 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5014 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5015 [REL_ALLOC]: ... to here, to check interface.
5016 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5017 Remove decls. This fixes an "It stinks!".
5018
9426aba4
PE
5019 * alloc.c (which_symbols): Fix alignment issue / type clash.
5020
d55c12ed
AS
50212012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5022
5023 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5024 (struct Lisp_Misc_Any): Likewise.
5025 (struct Lisp_Free): Likewise.
5026 * alloc.c (union aligned_Lisp_Symbol): Define.
5027 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5028 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5029 (union aligned_Lisp_Misc): Define.
5030 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5031 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5032 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5033
b948ce8b
PE
50342012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5035
5036 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5037 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5038 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5039 * s/netbsd.h, s/sol2-6.h:
5040 Remove definition of GC_MARK_STACK, since the default now works.
5041 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5042 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5043 no longer the default.
5044 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5045
35dc09a1 50462012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5047
35dc09a1
GM
5048 * lread.c (lisp_file_lexically_bound_p):
5049 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5050
35dc09a1
GM
50512012-04-14 Eli Zaretskii <eliz@gnu.org>
5052
5053 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5054 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5055
50562012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5057
5058 * nsterm.m (constrainFrameRect): Always constrain when there is only
5059 one screen (Bug#10962).
5060
bcd86815
KB
50612012-04-13 Ken Brown <kbrown@cornell.edu>
5062
5063 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5064
c25df26e
RT
50652012-04-13 Reuben Thomas <rrt@sc3d.org>
5066
5067 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5068
0fc59f1e
DC
50692012-04-11 Daniel Colascione <dancol@dancol.org>
5070
5071 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5072 against is gone. It's better to use vfork now so that when Cygwin
5073 gains a new, working vfork, we use it automatically (bug#10398).
5074
de8c03dc
SM
50752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5076
5077 * window.c (save_window_save): Obey window-point-insertion-type.
5078
2f097256
GM
50792012-04-11 Glenn Morris <rgm@gnu.org>
5080
5081 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5082
453b951e
SM
50832012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5084
5085 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5086
75f1671a 50872012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5088
5089 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5090 (force_quit_count): New var.
5091 (handle_interrupt): Use it.
5092
2a8ce227
JB
50932012-04-10 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * w32.c (w32_delayed_load): Record the full path of the library
5096 being loaded (bug#10424).
5097
935396c0
GM
50982012-04-09 Glenn Morris <rgm@gnu.org>
5099
05920a43
GM
5100 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5101 not just in the obarray, before snarfing them. (Bug#11036)
5102
935396c0
GM
5103 * Makefile.in ($(leimdir)/leim-list.el):
5104 Pass EMACS rather than BUILT_EMACS.
5105
a18ecafa
TZ
51062012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5107
5108 * process.c (make_process):
5109 * process.h: Add integer `gnutls_handshakes_tried' member to
5110 process struct.
5111
6bbef4e5
JC
5112 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5113 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5114
5115 * gnutls.c (gnutls_log_function2i): Convenience log function.
5116 (emacs_gnutls_read): Use new log functions,
5117 `gnutls_handshakes_tried' process member, and
5118 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5119 attempts per process (connection).
5120
b4d3bc10
CY
51212012-04-09 Chong Yidong <cyd@gnu.org>
5122
5123 * eval.c (Fuser_variable_p, user_variable_p_eh)
5124 (lisp_indirect_variable): Functions deleted.
5125 (Fdefvar): Caller changed.
5126
5127 * callint.c (Finteractive, Fcall_interactively):
5128 * minibuf.c (Fread_variable): Callers changed.
5129
70f4d973
EZ
51302012-04-09 Eli Zaretskii <eliz@gnu.org>
5131
5132 * xdisp.c (set_cursor_from_row): If the display string appears in
5133 the buffer at position that is closer to point than the position
5134 after the display string, display the cursor on the first glyph of
5135 the display string. Fixes cursor display when a 'display' text
5136 property immediately follows invisible text. (Bug#11094)
5137
cb3c2e3e
PE
51382012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 composite.c: use 'double' consistently
5141 * composite.c (get_composition_id): Use 'double' consistently
5142 instead of converting 'float' to 'double' and vice versa; this is
5143 easier to understand and avoids a GCC warning.
5144
fd06db5d
GM
51452012-04-09 Glenn Morris <rgm@gnu.org>
5146
50fe702a
GM
5147 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5148 preparation for dumping it with emacs. (Bug#4789)
5149 (leimdir): New variable.
5150 ($(leimdir)/leim-list.el): New rule.
5151 (emacs$(EXEEXT)): Depend on leim-list.el.
5152
fd06db5d
GM
5153 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5154 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5155 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5156
55c131ee
AS
51572012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5158
5159 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5160 proper alignment.
5161
9209588f
JB
51622012-04-07 Juanma Barranquero <lekktu@gmail.com>
5163
5164 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5165 Remove unused local variable.
5166
e3fb2efb
PE
51672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5170 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5171 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5172 objects, as mark_maybe_pointer will catch them otherwise.
5173 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5174 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5175
b5385551
PE
51762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 Fix typo that broke non-Windows builds.
5179 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5180
9078ead6
EZ
51812012-04-07 Eli Zaretskii <eliz@gnu.org>
5182
5183 Support building on MS-Windows with libxml2.
5184
5185 * makefile.w32-in (OBJ2): Add xml.$(O).
5186 (GLOBAL_SOURCES): Add xml.c.
5187 ($(BLD)/xml.$(O)): New dependency list.
5188
5189 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5190 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5191 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5192 [!WINDOWSNT]: New macros.
5193 (init_libxml2_functions, libxml2_loaded_p): New functions.
5194 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5195 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5196 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5197 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5198 linked in).
6bbef4e5
JC
5199 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5200 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5201 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5202
5203 * emacs.c: Don't include libxml/parser.h.
5204 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5205 xmlCleanupParser directly.
5206
5207 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5208
3811fdf3
EZ
52092012-04-07 Eli Zaretskii <eliz@gnu.org>
5210
5211 * indent.c (Fvertical_motion): If there is a display string at
5212 point, use it.vpos to compute how many lines to backtrack after
5213 move_it_to point. (Bug#11133)
5214
2f8e16b2
EZ
52152012-04-06 Eli Zaretskii <eliz@gnu.org>
5216
5217 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5218 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5219 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5220 macros related to unification of CJK characters. For the details,
5221 see the discussion following the message here:
5222 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5223
3d439cd1
CY
52242012-04-04 Chong Yidong <cyd@gnu.org>
5225
5226 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5227
8bc53d00
EZ
52282012-04-01 Eli Zaretskii <eliz@gnu.org>
5229
5230 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5231 instead of alloca. (Bug#11138)
5232
3b0512a3
AS
52332012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5234
5235 * w32menu.c (is_simple_dialog): Properly check lisp types.
5236 (Bug#11141)
5237
8427ddd2
EZ
52382012-03-31 Eli Zaretskii <eliz@gnu.org>
5239
979022ef
EZ
5240 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5241 position we get to after a call to move_it_to fails the
5242 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5243 only if we wind up in a string from display property. (Bug#11063)
5244
a6b1c7cc
EZ
5245 * window.c (Fdelete_other_windows_internal): Invalidate the row
5246 and column information about mouse highlight, so that redisplay
5247 restores it after reallocating the glyph matrices. (Bug#7464)
5248
8427ddd2
EZ
5249 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5250 string comes from a `display' text property, use the buffer
5251 position of that property as if we actually saw that position in
5252 the row's glyphs.
697ba24b
EZ
5253 (move_it_by_lines): Remove the assertion that
5254 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5255 violated when there's a before-string at the beginning of a line.
5256 (Bug#11063)
8427ddd2 5257
65a0a738
EZ
52582012-03-30 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (append_space_for_newline): If the default face was
5261 remapped, use the remapped face for the appended newline.
5262 (extend_face_to_end_of_line): Use the remapped default face for
5263 extending the face to the end of the line.
5264 (display_line): Call extend_face_to_end_of_line when the default
5265 face was remapped. (Bug#11068)
5266
581355cc
EZ
52672012-03-29 Eli Zaretskii <eliz@gnu.org>
5268
5269 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5270
e8fc049f
SM
52712012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5272
5273 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5274
4fb9a543
GM
52752012-03-27 Glenn Morris <rgm@gnu.org>
5276
5277 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5278 Doc fixes.
5279
679910f1
KH
52802012-03-26 Kenichi Handa <handa@m17n.org>
5281
5282 * dispextern.h (struct glyph): Fix previous change. Change the
5283 bit length of glyphless.ch to 25 (Bug#11082).
5284
90d49b7f
CY
52852012-03-26 Chong Yidong <cyd@gnu.org>
5286
5287 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5288 (command_loop_1): Use it; inhibit selection update for
5289 handle-select-window too (Bug#8996).
5290
f514f6f0
FP
52912012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5292
e8fc049f 5293 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5294
bf43fa51
KH
52952012-03-25 Kenichi Handa <handa@m17n.org>
5296
5297 * dispextern.h (struct glyph): Change the bit length of
5298 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5299
8a0c01dd
EZ
53002012-03-24 Eli Zaretskii <eliz@gnu.org>
5301
5302 * s/ms-w32.h (tzname): Include time.h before redirecting to
5303 _tzname. Fixes the MSVC build. (Bug#9960)
5304
7d1c3a76
AS
53052012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5306
8ed79523
AS
5307 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5308 characters.
5309
7d1c3a76
AS
5310 * xterm.c (XTread_socket): Only modify handling_signal if
5311 !SYNC_INPUT. (Bug#11080)
5312
e99a9b8b
EZ
53132012-03-23 Eli Zaretskii <eliz@gnu.org>
5314
5315 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5316 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5317 when fetching a multibyte character consumes more bytes than
5318 CHAR_BYTES returns, due to unification of CJK characters in
5319 string_char. (Bug#11073)
5320
5063c0e1
TN
53212012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5322
5323 * process.c (wait_reading_process_output): Handle pty disconnect
5324 by refraining from sending oneself a SIGCHLD (bug#10933).
5325
9f851fbd
CY
53262012-03-22 Chong Yidong <cyd@gnu.org>
5327
5328 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5329
5063c0e1 5330 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5331 Mark string as coming from a prefix property.
5332 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5333 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5334
fb5b8aca
CY
53352012-03-21 Chong Yidong <cyd@gnu.org>
5336
5337 * xfaces.c (Vface_remapping_alist): Doc fix.
5338
62356a1b
EZ
53392012-03-20 Eli Zaretskii <eliz@gnu.org>
5340
5341 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5342 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5343 Doc fixes.
62356a1b 5344
025de85b
CY
53452012-03-20 Chong Yidong <cyd@gnu.org>
5346
5347 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5348 to reflect default non-nil value of redisplay-dont-pause.
5349
4827f94e
KH
53502012-03-19 Kenichi Handa <handa@m17n.org>
5351
5352 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5353 it fit in a valid range (Bug#11003).
5354
e50a24a2
EZ
53552012-03-18 Eli Zaretskii <eliz@gnu.org>
5356
5357 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5358 that is not from display property, accept the row as a "cursor
5359 row" if one of the string's character has a non-nil `cursor'
5360 property. Fixes cursor positioning when there are newlines in
5361 overlay strings, e.g. in icomplete.el. (Bug#11035)
5362
9af5ed87
PE
53632012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5366
d1f55f16
CY
53672012-03-12 Chong Yidong <cyd@gnu.org>
5368
5369 * eval.c (inhibit_lisp_code): Rename from
5370 inhibit_window_configuration_change_hook; move from window.c.
5371
5372 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5373 * window.c (run_window_configuration_change_hook)
5374 (syms_of_window): Callers changed.
5375
66c5eebd
CY
53762012-03-11 Chong Yidong <cyd@gnu.org>
5377
413df973
CY
5378 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5379
66c5eebd
CY
5380 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5381
1de11f56
CY
53822012-03-10 Chong Yidong <cyd@gnu.org>
5383
5384 * frame.c (other_visible_frames): Don't assume the selected frame
5385 is visible (Bug#10955).
5386
cae07000
SM
53872012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5388
5389 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5390
89c94350
JD
53912012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5392
5393 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5394 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5395 zero (Bug#10954).
5396
999dd333
GM
53972012-03-03 Glenn Morris <rgm@gnu.org>
5398
01a6dcc8 5399 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5400
de0100f2
EZ
54012012-03-02 Eli Zaretskii <eliz@gnu.org>
5402
5403 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5404 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5405 (redisplay_window, next_element_from_string): Fix typos in
5406 comments.
3e441275
EZ
5407 (redisplay_window): Pass to move_it_vertically the margin in
5408 pixels, not in screen lines.
de0100f2 5409
96a72ee9
GM
54102012-03-02 Glenn Morris <rgm@gnu.org>
5411
5412 * buffer.c (buffer-list-update-hook): Doc fix.
5413
312508d7
EZ
54142012-02-29 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5417 push_it before setting up the iterator for the first overlay
5418 string, even if we have an empty string loaded.
5419 (next_overlay_string): If there's an empty string on the iterator
5420 stack, pop the stack. (Bug#10903)
5421
27f3c637
PE
54222012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5423
5424 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5425 Suggested by Stefan Monnier in
5426 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5427 * alloc.c (widen_to_Lisp_Object): New static function.
5428 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5429 and widening them to Lisp_Objects. This would work even if
5430 USE_LSB_TAG is defined and wide integers are used, which might
5431 happen in a future version of Emacs.
5432
3c9dfce6
CY
54332012-02-25 Chong Yidong <cyd@gnu.org>
5434
fa74b241
CY
5435 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5436 Doc fix.
5437
3c9dfce6
CY
5438 * xselect.c (Fx_selection_exists_p): Doc fix.
5439 (x_clipboard_manager_save_all): Print an informative message
5440 before saving to clipboard manager.
5441
9486df08
CY
54422012-02-24 Chong Yidong <cyd@gnu.org>
5443
5444 * keyboard.c (process_special_events): Handle all X selection
5445 requests in kbd_buffer, not just the next one (Bug#8869).
5446
f01d3321
CY
54472012-02-23 Chong Yidong <cyd@gnu.org>
5448
5449 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5450 call when setting menu-bar-lines and tool-bar-lines parameters.
5451 (unwind_create_frame_1): New helper function.
5452
5453 * window.c (inhibit_window_configuration_change_hook): New var.
5454 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5455 (syms_of_window): Initialize it.
f01d3321 5456
86b847b6
CY
54572012-02-22 Chong Yidong <cyd@gnu.org>
5458
5459 * xterm.c (x_draw_image_relief): Add missing type check for
5460 Vtool_bar_button_margin (Bug#10743).
5461
a59225b1
CY
54622012-02-21 Chong Yidong <cyd@gnu.org>
5463
5464 * fileio.c (Vfile_name_handler_alist): Doc fix.
5465
5466 * buffer.c (Fget_file_buffer): Protect against invalid file
5467 handler return value.
5468
310f5bd4
PE
54692012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5470
cb3a28cc
PE
5471 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5472 when computing $valmask.
5473
310f5bd4
PE
5474 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5475 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5476 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5477 It's useless in that case, and it can cause problems on hosts
5478 that allocate halves of EMACS_INT values separately.
5479 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5480 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5481 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5482 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5483 it avoids undefined behavior on hosts where shifting right by more
5484 than the word width has undefined behavior.
5485
2375c96a
CY
54862012-02-19 Chong Yidong <cyd@gnu.org>
5487
5488 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5489 (Funhandled_file_name_directory, Ffile_name_as_directory)
5490 (Fdirectory_file_name, Fexpand_file_name)
5491 (Fsubstitute_in_file_name): Protect against invalid file handler
5492 return values (Bug#10845).
5493
3eb49e71
EZ
54942012-02-18 Eli Zaretskii <eliz@gnu.org>
5495
5496 * .gdbinit (pitx): Fix incorrect references to fields of the
5497 iterator stack.
5498
7b926f3f
CY
54992012-02-17 Chong Yidong <cyd@gnu.org>
5500
5501 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5502
11273115
PE
55032012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5504
5505 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5506 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5507
c3a70e2b
CY
55082012-02-15 Chong Yidong <cyd@gnu.org>
5509
5510 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5511 marked as special. Also, starting docstrings with * is obsolete.
5512
0ca43699
AS
55132012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5514
5515 * gnutls.c (emacs_gnutls_write): Fix last change.
5516
2e8f3c56
LI
55172012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5518
5519 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5520 send_process.
5521
af70074f
SM
55222012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5523
5524 * keymap.c (Fsingle_key_description): Handle char ranges.
5525
95986d52
CY
55262012-02-12 Chong Yidong <cyd@gnu.org>
5527
afd83bd1
CY
5528 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5529 as that creates a dangerous corner case.
5530
95986d52
CY
5531 * window.c (Fdelete_window_internal): Invalidate the mouse
5532 highlight (Bug#9904).
5533
bd7da63e
GM
55342012-02-12 Glenn Morris <rgm@gnu.org>
5535
5536 * xselect.c (Fx_own_selection_internal)
5537 (Fx_get_selection_internal, Fx_disown_selection_internal)
5538 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5539 * nsselect.m (Fx_own_selection_internal)
5540 (Fx_disown_selection_internal, Fx_selection_exists_p)
5541 (Fx_selection_owner_p, Fx_get_selection_internal):
5542 Sync docs and argument specs with the xselect.c versions.
5543
77abcbc2
LI
55442012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5545
5546 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5547
90b671e2
EZ
55482012-02-11 Eli Zaretskii <eliz@gnu.org>
5549
1c0ca0b7
EZ
5550 * w32select.c (Fx_selection_exists_p): Sync doc string and
5551 argument list with xselect.c. (Bug#10783)
5552
5553 * w16select.c (Fx_selection_exists_p): Sync doc string and
5554 argument list with xselect.c. (Bug#10783)
90b671e2 5555
49241268
GM
55562012-02-10 Glenn Morris <rgm@gnu.org>
5557
5558 * fns.c (Fsecure_hash): Doc fix.
5559
f998bbe7 55602012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5561
5562 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5563
0992bd9c
CY
55642012-02-07 Chong Yidong <cyd@gnu.org>
5565
5566 * buffer.c (Fbuffer_local_variables)
5567 (buffer_lisp_local_variables): Handle unbound vars correctly;
5568 don't let Qunbound leak into Lisp.
5569
af008560
GM
55702012-02-07 Glenn Morris <rgm@gnu.org>
5571
dd605cc4
GM
5572 * image.c (Fimagemagick_types): Doc fix.
5573
af008560
GM
5574 * image.c (imagemagick-render-type): Change it from a lisp object
5575 to an integer. Move the doc here from the lisp manual.
5576 Treat all values not equal to 0 the same.
5577
1449fa1d
CY
55782012-02-06 Chong Yidong <cyd@gnu.org>
5579
5580 * doc.c (store_function_docstring): Avoid applying docstring of
5581 alias to base function (Bug#2603).
5582
3723ec07
AS
55832012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5584
5585 * .gdbinit (pp1, pv1): Remove redundant defines.
5586 (pr): Use pp.
5587
79c1cc1e
CY
55882012-02-04 Chong Yidong <cyd@gnu.org>
5589
5590 * nsterm.m: Declare a global (Bug#10694).
5591
d7f29f8e
EZ
55922012-02-04 Eli Zaretskii <eliz@gnu.org>
5593
cae07000
SM
5594 * w32.c (get_emacs_configuration_options):
5595 Include --enable-checking, if specified, in the return value.
d7f29f8e 5596
3b95a6f9
MR
55972012-02-04 Martin Rudalics <rudalics@gmx.at>
5598
5599 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5600 after rounding frame sizes. (Bug#9723)
5601
d6fa96a6
EZ
56022012-02-04 Eli Zaretskii <eliz@gnu.org>
5603
5604 * keyboard.c (adjust_point_for_property): Don't position point
5605 before BEGV. (Bug#10696)
5606
df0b2940
PE
56072012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5608
5609 Handle overflow when computing char display width (Bug#9496).
5610 * character.c (char_width): Return EMACS_INT, not int.
5611 (char_width, c_string_width): Check for overflow when
5612 computing the width; this is possible now that individual
5613 characters can have unbounded width. Problem introduced
5614 by merge from Emacs 23 on 2012-01-19.
5615
6bee44d6
MA
56162012-02-02 Michael Albinus <michael.albinus@gmx.de>
5617
5618 * dbusbind.c (Fdbus_register_method): Mention the return value
5619 :ignore in the docstring.
5620
44f92739
GM
56212012-02-02 Glenn Morris <rgm@gnu.org>
5622
1b9f60cc
GM
5623 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5624
44f92739
GM
5625 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5626 Unconditionally set to t. (Bug#10673)
5627 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5628 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5629 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5630
c5d3843c
KH
56312012-02-02 Kenichi Handa <handa@m17n.org>
5632
5633 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5634 0, do not call append_composite_glyph.
5635
159462d4 56362012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5637
5638 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5639 NULL (Bug#6988).
5640 (x_produce_glyphs): If the component of a composition is a null
5641 string, set it->pixel_width to 1 to avoid zero-width glyph.
5642
78cef877
EZ
56432012-02-01 Eli Zaretskii <eliz@gnu.org>
5644
5645 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5646 first 2 arguments are identical. This makes inserting large
5647 output from a subprocess an order of magnitude faster on
5648 MS-Windows, where all sbrk'ed memory is always contiguous.
5649
97897668
GM
56502012-01-31 Glenn Morris <rgm@gnu.org>
5651
5652 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5653 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5654 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5655
31fd3586
GM
56562012-01-29 Glenn Morris <rgm@gnu.org>
5657
5658 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5659
0e24a8b2
CY
56602012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5661
5662 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5663
cc0adcb0
CY
56642012-01-28 Chong Yidong <cyd@gnu.org>
5665
5666 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5667
acc28cb9
CY
56682012-01-26 Chong Yidong <cyd@gnu.org>
5669
9c69cfb7
CY
5670 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5671
acc28cb9
CY
5672 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5673 repeat counts (Bug#10507).
5674
48da7392
GM
56752012-01-26 Glenn Morris <rgm@gnu.org>
5676
5677 * lread.c (syms_of_lread): Doc fix.
5678
14af5f7f
CY
56792012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5680
5681 * coding.c (encode_designation_at_bol): Change return value to
5682 EMACS_INT.
5683
0b21c100
CY
56842012-01-25 Chong Yidong <cyd@gnu.org>
5685
5686 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5687
3c2907f7
CY
56882012-01-21 Chong Yidong <cyd@gnu.org>
5689
5690 * floatfns.c (Fcopysign): Make the second argument non-optional,
5691 since nil is not allowed anyway.
5692
959ad23f
AS
56932012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5694
5695 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5696 (send_process): Likewise.
5697
34a02f46
MR
56982012-01-19 Martin Rudalics <rudalics@gmx.at>
5699
5700 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5701 (Vwindow_persistent_parameters): Do not use Qstate.
5702 Rewrite doc-strings.
34a02f46 5703
1259009a 57042012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5705
5706 * character.c (char_width): New function.
70d4fdf6
GM
5707 (Fchar_width, c_string_width, lisp_string_width):
5708 Use char_width (Bug#9496).
25ed9e61 5709
6a6ee00d
MR
57102012-01-16 Martin Rudalics <rudalics@gmx.at>
5711
5712 * window.c (Vwindow_persistent_parameters): New variable.
5713 (Fset_window_configuration, save_window_save): Handle persistent
5714 window parameters.
5715
c85efaf7
EZ
57162012-01-14 Eli Zaretskii <eliz@gnu.org>
5717
5718 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5719 thrashing the stack of the thread. (Bug#9087)
5720
5944709e
PE
57212012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5724
e71f5d99
EZ
57252012-01-11 Eli Zaretskii <eliz@gnu.org>
5726
5727 * xdisp.c (rows_from_pos_range): Handle the case where the
5728 highlight ends on a newline. (Bug#10464)
5729 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5730 he end column for display of highlight that ends on a newline
5731 before a R2L line.
5732
ce316182
GM
57332012-01-11 Glenn Morris <rgm@gnu.org>
5734
5735 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5736 from load-path also when installation-directory is nil. (Bug#10208)
5737
5b43da69
GM
57382012-01-10 Glenn Morris <rgm@gnu.org>
5739
74cc8ff9
GM
5740 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5741
7d8d6e4e
GM
5742 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5743 Update template values to be closer to their typical values these days.
5b43da69 5744
a0db8d43
EZ
57452012-01-09 Eli Zaretskii <eliz@gnu.org>
5746
5747 * xdisp.c (rows_from_pos_range): Accept additional argument
5748 DISP_STRING, and accept any glyph in a row whose object is that
5749 string as eligible for mouse highlight. Fixes mouse highlight of
5750 display strings from overlays. (Bug#10464)
5751
9a0115ab 57522012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5753
b9110d6a 5754 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5755 * fileio.c (auto_saving_dir_umask): New static var.
5756 (Fmake_directory_internal): Use it.
5757 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5758 creating the directory. The old code temporarily assigns
5759 too-generous permissions to the directory.
5760 (do_auto_save_eh): Clear it.
b9110d6a 5761 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5762 that the var is always cleared.
5763
6c1bd3f3
EZ
57642012-01-07 Eli Zaretskii <eliz@gnu.org>
5765
5766 * search.c (scan_buffer): Pass character positions to
5767 know_region_cache, not byte positions. (Bug#6540)
5768
069d2b50
L
57692012-01-07 LynX <_LynX@bk.ru> (tiny change)
5770
5771 * w32.c (sys_rename): Report EXDEV when rename of a directory
5772 fails because the target is on another logical disk. (Bug#10284)
5773
75bf0d33
DB
57742012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5775
5776 * xterm.c (x_embed_request_focus): New function.
5777
5778 * xterm.h: Add prototype.
5779
5780 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5781
1c6e5a32
GM
57822012-01-05 Glenn Morris <rgm@gnu.org>
5783
5784 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5785
651e947e
EZ
57862012-01-01 Eli Zaretskii <eliz@gnu.org>
5787
5788 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5789 Load gnutls_transport_set_lowat only if GnuTLS version is below
5790 2.11.1.
5791 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5792 GnuTLS versions below 2.11.1.
5793
3778cdd8
AL
57942011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5795
5796 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5797 to the doc string advising against its use for altering the way
5798 windows are scrolled.
5799
0e5317f7
KH
58002011-12-28 Kenichi Handa <handa@m17n.org>
5801
5802 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5803 coding-system ASCII compatible only when it does not produce BOM
5804 on encoding (Bug#10383).
5805
93d5ca1f
JD
58062011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5807
5808 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5809 can scroll.
5810 (create_and_show_popup_menu): Always use menu_position_func for
5811 Gtk3 (Bug#10361).
5812
ca22b785
AS
58132011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5814
5815 * callint.c (Fcall_interactively): Don't truncate prompt string.
5816
d048e1e6
EZ
58172011-12-23 Eli Zaretskii <eliz@gnu.org>
5818
5819 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5820 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5821 resumed from there (after widening). (Bug#10360)
d048e1e6 5822
5ccaba1f
JD
58232011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5824
5825 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5826
204ee57f
JD
58272011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5828
b81d40f0
JB
5829 * nsterm.m (x_free_frame_resources):
5830 Release f->output_data.ns->miniimage.
204ee57f
JD
5831 (ns_index_color): Fix indentation. Do not retain
5832 color_table->colors[i].
5833
5834 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5835 before returning.
5836
5837 * nsfns.m (x_set_background_color): Assign return value from
5838 ns_index_color to face-background instead of NSColor*.
5839 (ns_implicitly_set_icon_type): Fix indentation.
5840 Change assignment in for loop to comparison.
5841
5842 * emacs.c (ns_pool): New variable.
5843 (main): Assign ns_pool.
5844 (Fkill_emacs): Call ns_release_autorelease_pool.
5845
5846 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5847 autorelease fdesc, release fdAttrs and tdict.
5848 (ns_get_covering_families): Release charset.
5849 (ns_findfonts): Release NSFontDescriptor created with new.
5850 (ns_uni_to_glyphs): Fix indentation.
5851 (setString): Release attrStr before assigning new value.
5852
c803b2b7
JD
58532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5854
678f4426
JD
5855 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5856 and NS_IMPL_COCOA.
5857 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5858 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5859
cd394be1 58602011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5861
5fecd5fc
JD
5862 * nsterm.m (ns_term_init): Subscribe for notifications
5863 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5864 to method trackingNotification in EmacsMenu.
5865
5866 * nsmenu.m (trackingMenu): New variable.
3771cb17 5867 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5868 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5869 from Aquamacs (Bug#7030).
678f4426
JD
5870
58712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5872
c803b2b7
JD
5873 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5874 (symbol_to_nsstring): Fix indentation.
5875 (ns_symbol_to_pb): New function.
cae07000
SM
5876 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5877 (Fns_rotate_cut_buffers_internal): Remove.
5878 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5879 Fns_store_cut_buffer_internal.
5880 (ns_get_foreign_selection, Fx_own_selection_internal)
5881 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5882 (Fns_get_selection_internal, Fns_store_selection_internal):
5883 Use ns_symbol_to_pb and check if return value is nil.
5884 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5885 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5886 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5887 renamed to Sns_store_selection_internal.
5888 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5889 and remove this function.
5890 (ns_handle_selection_clear): Remove, never used.
5891 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5892 here.
5893
e1b01a3a
KB
58942011-12-17 Ken Brown <kbrown@cornell.edu>
5895
5896 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5897 GID is unknown (Bug#10257).
5898
2adb6e85
PE
58992011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5902 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5903 which caused a build failure on GNU/Linux IA-64. This problem was
5904 introduced by my 2011-10-07 patch.
5905
d1d7b339
JL
59062011-12-15 Juri Linkov <juri@jurta.org>
5907
5908 * image.c (imagemagick_error): New function. (Bug#10112)
5909 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5910 Use `imagemagick_error' where ImageMagick functions return
5911 `MagickFalse'.
5912 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5913 proper order.
5914
100d5755
KH
59152011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5916
5917 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5918 fill background (Bug#8992).
5919
454592a6
MR
59202011-12-13 Martin Rudalics <rudalics@gmx.at>
5921
5922 * window.c (Vwindow_combination_resize)
5923 (Vwindow_combination_limit): Use t instead of non-nil in
5924 doc-strings.
61d4b438
MR
5925 (Vrecenter_redisplay): Add first sentence of doc-string on
5926 separate line.
53524d93 5927 (Frecenter): Fix doc-string typo.
454592a6 5928
3633e3aa
KH
59292011-12-11 Kenichi Handa <handa@m17n.org>
5930
5931 * coding.c (Funencodable_char_position): Pay attention to the
5932 buffer text relocation (Bug#9389).
5933
7b9d523a 59342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5935
7b9d523a
JD
5936 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5937 gtk_init (Bug#10100).
5938
b73189c6
EZ
59392011-12-10 Eli Zaretskii <eliz@gnu.org>
5940
5941 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5942 IT->string is nil. (Bug#10263)
5943
f7dfe5d6
JD
59442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5945
83faebb4
JD
5946 * nsterm.h (x_free_frame_resources): Declare.
5947
f7dfe5d6
JD
5948 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5949 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5950
5951 * nsterm.h (ns_get_defaults_value): Declare.
5952
5953 * nsterm.m (ns_default): Call ns_get_defaults_value.
5954
7cd4e72c
EZ
59552011-12-09 Eli Zaretskii <eliz@gnu.org>
5956
5957 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5958 (Bug#10170)
5959
b34d7317
YM
59602011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5961
5962 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5963 that where the value of an _OBJC_* symbol points to is in the .bss
5964 section (Bug#10240).
5965
76470ad1
KH
59662011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5967
5968 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5969 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5970
745fff94
KH
59712011-12-08 Kenichi Handa <handa@m17n.org>
5972
5973 * ftfont.c (get_adstyle_property): Fix previous change
5974 (Bug#10233).
5975
6e44397c
JB
59762011-12-07 Juanma Barranquero <lekktu@gmail.com>
5977
5978 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5979 dirs from the default value of EMACSLOADPATH (bug#10208).
5980
7efa6272
GM
59812011-12-07 Glenn Morris <rgm@gnu.org>
5982
5983 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5984 installation and source directories as well. (Bug#10208)
5985
f6fc4d87
CY
59862011-12-06 Chong Yidong <cyd@gnu.org>
5987
5988 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5989
2bf26180
GM
59902011-12-06 Glenn Morris <rgm@gnu.org>
5991
5992 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5993 as an error, not just -1. (Bug#10217)
5994
3a6ad4f0
CY
59952011-12-05 Chong Yidong <cyd@gnu.org>
5996
5997 * keyboard.c (process_special_events): New function.
5998 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5999
75a3b399
PE
60002011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6001
6002 * coding.c (encode_designation_at_bol): Don't use uninitialized
6003 local variable (Bug#9318).
6004
c3c9e25e
KH
60052011-12-05 Kenichi Handa <handa@m17n.org>
6006
6007 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6008 return Qnil (Bug#8046, Bug#10193).
6009
5eb05ea3
KH
60102011-12-05 Kenichi Handa <handa@m17n.org>
6011
6012 * coding.c (encode_designation_at_bol): New args charbuf_end and
6013 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6014 (coding_set_source): Return how many bytes coding->source was
6015 relocated.
6016 (coding_set_destination): Return how many bytes
6017 coding->destination was relocated.
6018 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6019 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6020
60212011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6022
6023 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6024 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6025 macro (Bug#9318).
6026
60272011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6028
6029 The following changes are to fix Bug#9318.
6030
a79703f5 6031 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6032 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6033 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6034 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6035
7dbda6df
JB
60362011-12-05 Juanma Barranquero <lekktu@gmail.com>
6037
6038 * lisp.h (process_quit_flag): Fix external declaration.
6039
6d5eb5b0
SM
60402011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6041
6042 Don't macro-inline non-performance-critical code.
6043 * eval.c (process_quit_flag): New function.
6044 * lisp.h (QUIT): Use it.
6045
a0c3fad0
JD
60462011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6047
6048 * nsfns.m (get_geometry_from_preferences): New function.
6049 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6050
6c07aac2
AS
60512011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6052
6053 * emacs.c (Qkill_emacs): Define.
6054 (syms_of_emacs): Initialize it.
6055 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6056 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6057 (quit_throw_to_read_char): Add parameter `from_signal'.
6058 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6059 * lisp.h (QUIT): Call Fkill_emacs if requested.
6060
c052ead4
JD
60612011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6062
6063 * widget.c (update_wm_hints): Return if wmshell is null.
6064 (widget_update_wm_size_hints): New function.
6065
6066 * widget.h (widget_update_wm_size_hints): Declare.
6067
6068 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6069 widget_update_wm_size_hints (Bug#10104).
6070
9e49252b
EZ
60712011-12-03 Eli Zaretskii <eliz@gnu.org>
6072
6073 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6074 before a newline, prepare the bidi iterator for consuming the
6075 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6076 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6077
02b16839
JL
60782011-12-02 Juri Linkov <juri@jurta.org>
6079
6080 * search.c (Fword_search_regexp): New Lisp function created from
6081 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6082 (Fword_search_backward, Fword_search_forward)
6083 (Fword_search_backward_lax, Fword_search_forward_lax):
6084 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6085 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6086
0068070e
SM
60872011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6088
6089 * fileio.c (Finsert_file_contents): Move after-change-function call
6090 to before the "handled:" label, since all "goto handled" appear in
6091 cases where the *-change-functions have already been properly called
6092 (bug#10117).
6093
3360a3fc
AS
60942011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6095
6096 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6097 waiting for input. (Bug#10169)
6098
73d6c093
EZ
60992011-11-30 Eli Zaretskii <eliz@gnu.org>
6100
6101 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6102 verifies glyph row's hash code--we have just reallocated the
6103 glyphs, so their contents can be complete garbage. (Bug#10164)
6104
febe6bea
JB
61052011-11-30 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6108
801a4313
EZ
61092011-11-30 Eli Zaretskii <eliz@gnu.org>
6110
6111 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6112 attributes are tested _before_ calling verify_row_hash, to protect
6113 against GCC re-ordering of the tests. (Bug#10164)
6114
2b56b87e
JD
61152011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6116
6117 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6118
6119 * xterm.c (handle_one_xevent): Only set async_visible and friends
6120 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6121 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6122 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6123
dbf31225
PE
61242011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6125
6126 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6127 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6128 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6129 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6130 All uses changed to use GCPRO1 etc.
6131 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6132 Revert to old implementation (i.e., before 2011-03-11).
6133
1305621b
YM
61342011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6135
6136 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6137 of scroll runs so as to avoid assigning disabled bogus rows and
6138 unnecessary graphics copy operations.
6139
8c9afb46
EZ
61402011-11-27 Eli Zaretskii <eliz@gnu.org>
6141
6142 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6143 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6144 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6145 (malloc, free, realloc, calloc): Redirect to e_* only when
6146 compiling Emacs.
6147
6148 * lisp.h (GCTYPEBITS): Move before first use.
6149 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6150 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6151 this macro definition.
6152
6153 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6154 _MSC_VER.
6155
54e9e3bf
JD
61562011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6157
6d5eb5b0
SM
6158 * gtkutil.c (xg_create_frame_widgets):
6159 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6160 present with Gtk+ 2.0.
6161
83aca1cb
PE
61622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6163
6164 * fileio.c (Finsert_file_contents): Undo previous change; see
6165 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6166
5b76caa4
PE
61672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 Rename locals to avoid shadowing.
6170 * fileio.c (Finsert_file_contents):
6171 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6172 * process.c (wait_reading_process_output):
6173 Rename inner 'proc' to 'p' to avoid shadowing.
6174 Indent for consistency with usual Emacs style.
6175
8c535114
EZ
61762011-11-25 Eli Zaretskii <eliz@gnu.org>
6177
6178 * xdisp.c (redisplay_window): If cursor row is not fully visible
6179 after recentering, and scroll-conservatively is set to a large
6180 number, scroll window by a few more lines to make the cursor fully
6181 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6182 (start_display): Don't move to the next line if the display should
6183 start at a newline that is part of a display vector or an overlay
6184 string. (Bug#10119)
8c535114 6185
fa4fdb5c
JL
61862011-11-24 Juri Linkov <juri@jurta.org>
6187
6188 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6189 after the `MagickPingImage' call. (Bug#10112)
6190
90ec88df
CY
61912011-11-23 Chong Yidong <cyd@gnu.org>
6192
6193 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6194
56e2e794
MR
61952011-11-23 Martin Rudalics <rudalics@gmx.at>
6196
6197 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6198 making another buffer current. (Bug#10114)
6199
b6e64c41
GM
62002011-11-23 Glenn Morris <rgm@gnu.org>
6201
6202 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6203
6b21de18
CY
62042011-11-23 Chong Yidong <cyd@gnu.org>
6205
6206 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6207 using it (Bug#5984).
6208
b12cd789
EZ
62092011-11-22 Eli Zaretskii <eliz@gnu.org>
6210
6211 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6212 and header-lines, as they don't have one computed for them.
6213 (Bug#10098)
6214
6215 * .gdbinit (prow): Make displayed values more self-explaining.
6216 Add row's hash code.
6217
261b6fd4
LMI
62182011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6219
6220 * process.c (wait_reading_process_output): Fix asynchrounous
6221 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6222 (wait_reading_process_output): Add comment and URL.
261b6fd4 6223
e7cfd277
JD
62242011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6225
6226 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6227
a9b9b7f5
CY
62282011-11-21 Chong Yidong <cyd@gnu.org>
6229
6230 * window.c (Fnext_window, Fprevious_window): Doc fix.
6231
b0d15b4f
SM
62322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6233
6234 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6235
fe7a3057
JB
62362011-11-20 Juanma Barranquero <lekktu@gmail.com>
6237
6238 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6239
d2999b1a
MR
62402011-11-20 Martin Rudalics <rudalics@gmx.at>
6241
6242 * window.c (Fset_window_combination_limit): Rename argument
6243 STATUS to LIMIT.
6244 (Vwindow_combination_limit): Remove "status" from doc-string.
6245
d5ff9cd0
AS
62462011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6247
6248 * m/ibms390.h: Remove.
6249 * m/ibms390x.h: Don't include "ibms390.h".
6250
a5bb9bd3
SM
62512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6252
6253 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6254 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6255
cd1181db
JB
62562011-11-20 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * casetab.c (Fset_case_table):
6259 * charset.c (Fcharset_after): Fix typos.
6260
615a3b8d 62612011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6262
17e845af
PE
6263 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6264 Otherwise, valgrind does not work on some platforms.
6265 Problem reported by Andreas Schwab in
6a0bf43d
PE
6266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6267 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6268 is set, removing the need for VIRT_ADDRESS_VARIES.
6269 (PURE_P): Use a more-efficient implementation that needs just one
6270 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6271 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6272 to 4 (xorl, subq, cmpq, setbe).
6273 * alloc.c (pure): Always extern now, since that's the
6274 VIRT_ADDR_VARIES behavior.
6275 (PURE_POINTER_P): Use a single comparison, not two, for
6276 consistency with the new puresize.h.
6277 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6278 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6279 Remove VIRT_ADDR_VARIES no longer needed.
6280
f8fe6f96
EZ
62812011-11-19 Eli Zaretskii <eliz@gnu.org>
6282
6283 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6284 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6285 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6286 behave as if the cursor position were at the window margin.
6287
6288 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6289 and the cursor position is out of bounds, behave as if the cursor
6290 position were at the window margin. (Bug#10075)
6291
df05a53c
CY
62922011-11-18 Chong Yidong <cyd@gnu.org>
6293
6294 * window.c (Fwindow_combination_limit): Make first argument
6295 non-optional, since it is meaningless for live windows like the
6296 selected window.
61ccba97 6297
2071918e
DA
62982011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6299
6300 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6301
b50a28de
SM
63022011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6303
6304 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6305 (graft_intervals_into_buffer): Simplify.
6306
015137db
EZ
63072011-11-18 Eli Zaretskii <eliz@gnu.org>
6308
6309 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6310 hash values of the two rows.
6311 (copy_row_except_pointers): Preserve the used[] arrays and the
6312 hash values of the two rows. (Bug#10035)
68c95424 6313 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6314
6315 * xdisp.c (row_hash): New function, body extracted from
6316 compute_line_metrics.
6317 (compute_line_metrics): Call row_hash, instead of computing the
6318 hash code inline.
6319
6320 * dispnew.c (verify_row_hash): Call row_hash for computing the
6321 hash code of a row, instead of duplicating code from xdisp.c.
6322
6323 * dispextern.h (row_hash): Add prototype.
6324
a2addb04
TH
63252011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6326
6327 * frame.c (delete_frame): Don't delete the terminal when the last
6328 X frame is closed if emacs is built with GTK toolkit.
6329
df85d315
JB
63302011-11-17 Juanma Barranquero <lekktu@gmail.com>
6331
6332 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6333
a0c2d0ae
MR
63342011-11-17 Martin Rudalics <rudalics@gmx.at>
6335
6336 * window.c (Vwindow_splits): Rename to
6337 Vwindow_combination_resize. Suggested by Juri Linkov.
6338 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6339 of Vwindow_splits.
6340
58179cce
JB
63412011-11-16 Juanma Barranquero <lekktu@gmail.com>
6342
7877f373
JB
6343 * nsfns.m (Fns_font_name):
6344 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6345
b6f67890
MR
63462011-11-16 Martin Rudalics <rudalics@gmx.at>
6347
6348 * window.h (window): Rename slot "nest" to "combination_limit".
6349 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6350 (Fset_window_nest): Rename to Fset_window_combination_limit.
6351 (Vwindow_nest): Rename to Vwindow_combination_limit.
6352 (recombine_windows, make_parent_window, make_window)
6353 (Fsplit_window_internal, saved_window)
6354 (Fset_window_configuration, save_window_save): Rename all
6355 occurrences of window_nest to window_combination_limit.
6356
c7015153
JB
63572011-11-15 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * image.c (imagemagick_load_image): Fix typo.
6360
322ad6ec
EZ
63612011-11-14 Eli Zaretskii <eliz@gnu.org>
6362
6363 * xdisp.c (display_line): Move the call to
6364 highlight_trailing_whitespace before the call to
6365 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6366 faces of all the glyphs to compute ROW's hash value.
6367 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6368
f067b8ec
JB
63692011-11-14 Juanma Barranquero <lekktu@gmail.com>
6370
6371 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6372 just return (bug#10044).
6373
1e5b2111
EZ
63742011-11-12 Eli Zaretskii <eliz@gnu.org>
6375
7ef3cbd5
EZ
6376 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6377 with user-defined heap size. Bump the default size of the temacs
6378 heap to 27MB, to avoid memory warning when running temacs.
6379 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6380
1e5b2111
EZ
6381 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6382 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6383 (verify_row_hash) [XASSERTS]: New function.
6384 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6385 that the hash value of glyph rows is correct.
1e5b2111 6386
89d61221
MR
63872011-11-12 Martin Rudalics <rudalics@gmx.at>
6388
6389 * window.h (window): Remove splits slot.
6390 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6391 (Fdelete_other_windows_internal, make_parent_window)
6392 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6393 (Fset_window_configuration, save_window_save): Don't deal with
6394 split status of windows.
6395 (saved_window): Remove splits slot.
6396 (Vwindow_splits): Rewrite doc-string.
6397
97f18cc8
JD
63982011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6399
6400 * xfns.c (unwind_create_frame):
6401 * nsfns.m (unwind_create_frame):
6402 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6403 Vframe_list (Bug#9999).
6404
22a648b4
DA
64052011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6406
0b381c7e 6407 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6408
659afede
KH
64092011-11-11 Kenichi Handa <handa@m17n.org>
6410
6411 * callproc.c (Fcall_process): Set the member dst_multibyte of
6412 process_coding.
6413
9ac0394b
KH
64142011-11-11 Johan Bockgård <bojohan@gnu.org>
6415
6416 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6417 avoid a crash (bug#9496).
6418
2fbdc249
CY
64192011-11-09 Chong Yidong <cyd@gnu.org>
6420
6421 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6422 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6423
ac6b1f81
PE
64242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6425
6426 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6427
09db192c
PE
64282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6429
6430 Avoid some portability problems by eschewing 'extern inline' functions.
6431 The trivial performance wins aren't worth the portability hassles; see
6432 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6433 et seq.
6434 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6435 (window_box_width, window_box_left, window_box_left_offset)
6436 (window_box_right, window_box_right_offset): Undo previous change,
6437 by removing the "extern"s.
6438 * intervals.c (adjust_intervals_for_insertion)
6439 (adjust_intervals_for_deletion): Undo previous change,
6440 making these static again.
6441 (offset_intervals, temp_set_point_both, temp_set_point)
6442 (copy_intervals_to_string): No longer inline.
6443 * xdisp.c (window_text_bottom_y, window_box_width)
6444 (window_box_height, window_box_left_offset)
6445 (window_box_right_offset, window_box_left, window_box_right)
6446 (window_box): No longer inline.
6447
105216ed
CY
64482011-11-08 Chong Yidong <cyd@gnu.org>
6449
6450 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6451 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6452 Signal an error if not a live window.
105216ed
CY
6453 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6454 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6455
ae9e237f
JB
64562011-11-07 Juanma Barranquero <lekktu@gmail.com>
6457
6458 * lisp.h (syms_of_abbrev): Remove declaration.
6459 Reported by CHENG Gao <chenggao@royau.me>.
6460
c7aa8333
EZ
64612011-11-07 Eli Zaretskii <eliz@gnu.org>
6462
6463 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6464 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6465 of temacs in GUI mode.
6466
be7f5545
MR
64672011-11-07 Martin Rudalics <rudalics@gmx.at>
6468
6469 * window.h: Declare delete_all_child_windows instead of
6470 delete_all_subwindows.
6471 * window.c (Fwindow_nest, Fset_window_nest)
6472 (Fset_window_new_total, Fset_window_new_normal)
6473 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6474 (delete_all_subwindows): Rename to delete_all_child_windows.
6475 (Fdelete_other_windows_internal, Fset_window_configuration):
6476 Call delete_all_child_windows instead of delete_all_subwindows.
6477 * frame.c (delete_frame): Call delete_all_child_windows instead
6478 of delete_all_subwindows.
6479
ca78dc43
PE
64802011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6481
6482 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6483 This is also needed for porting to any host where GC_MARK_STACK is
6484 not GC_MAKE_GCPROS_NOOPS.
6485 (which_symbols): Use it.
6486
a0241d01
KH
64872011-11-07 Kenichi Handa <handa@m17n.org>
6488
6489 * coding.c (coding_set_destination): Check coding->src_pos only
6490 when coding->src_object is a buffer (bug#9910).
6491
6492 * process.c (send_process): Set the member src_multibyte of coding
6493 to 0 (bug#9911) when sending a unibyte text.
6494
6495 * callproc.c (Fcall_process): Set the member src_multibyte of
6496 process_coding to 0 (bug#9912).
6497
a64bfdfa 64982011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6499
6500 * xmenu.c (cleanup_widget_value_tree): New function.
6501 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6502 calling free_menubar_widget_value_tree directly (Bug#9830).
6503
cb41b32a
PE
65042011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6505
6506 Fix some portability problems with 'inline'.
6507 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6508 (window_box_width, window_box_left, window_box_left_offset)
6509 (window_box_right, window_box_right_offset): Declare extern.
6510 Otherwise, these inline functions do not conform to C99 and
6511 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6512 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6513 * intervals.c (adjust_intervals_for_insertion)
6514 (adjust_intervals_for_deletion): Now extern, because otherwise the
6515 extern inline functions 'offset_intervals' couldn't refer to it.
6516 (static_offset_intervals): Remove.
6517 (offset_intervals): Rewrite using the old contents of
6518 static_offset_intervals. The old version didn't conform to C99
6519 because an extern inline function contained a reference to an
6520 identifier with static linkage.
6521
b7041366
AS
65222011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6523
6524 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6525 GC.
6526
88a37c4d
EZ
65272011-11-06 Eli Zaretskii <eliz@gnu.org>
6528
6529 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6530 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6531 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6532 return Qleft_to_right.
6533
49745b39
CY
65342011-11-06 Chong Yidong <cyd@gnu.org>
6535
6536 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6537 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6538 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6539 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6540 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6541 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6542 (Fwindow_vscroll): Doc fix.
6543 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6544 argument, since it makes no sense to pass a live window and for
6545 consistency with window-child.
6546
1f05cd82
CS
65472011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6548
6549 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6550 support MSVC.
6551
22610910
JR
65522011-11-05 Jason Rumney <jasonr@gnu.org>
6553
6554 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6555 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6556 fonts (Bug#6029).
6557 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6558 bitwise arithmetic preventing use of unicode-sip and non-truetype
6559 opentype fonts.
6560
a06776b2
EZ
65612011-11-05 Eli Zaretskii <eliz@gnu.org>
6562
3ad924ba
EZ
6563 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6564 "emacs"-only part.
6565
a06776b2
EZ
6566 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6567 initialization code to keep similarity to xfns.c after changes
6568 from 2011-11-05.
6569
c9e7db78
JD
65702011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6571
a97f8f3f
JD
6572 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6573 (unwind_create_frame): New function (Bug#9943).
6574 (Fx_create_frame): Restructure code to be more similar to the one in
6575 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6576 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6577 Move terminal->reference_count++ just before making the frame official
6578 (Bug#9943).
6579
6580 * nsterm.m (x_free_frame_resources): New function.
6581 (x_destroy_window): Move code to x_free_frame_resources.
6582
c9e7db78 6583 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6584 (Fx_create_frame, x_create_tip_frame):
6585 Move terminal->reference_count++ just before making the frame
75f1671a 6586 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6587 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6588
a6fc3b5c
EZ
65892011-11-05 Eli Zaretskii <eliz@gnu.org>
6590
6591 Support MSVC build with newer versions of Visual Studio.
6592 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6593 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6594 nt/gmake.defs.
6595
6596 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6597 which are not supported by MSVC.
6598 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6599 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6600 bitfields.
6601 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6602 types in bitfields.
6603 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6604
6605 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6606
58179cce 66072011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6608
6609 Support MSVC build with newer versions of Visual Studio.
6610 * w32.c: Don't include w32api.h for MSVC.
6611 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6612
6613 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6614 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6615 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6616 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6617 e_* cousins.
6618 (alloca) [_MSC_VER]: Define to _alloca.
6619
6620 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6621
6622 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6623
a58c13ed
EZ
66242011-11-04 Eli Zaretskii <eliz@gnu.org>
6625
6626 * xdisp.c (note_mouse_highlight): If either of
6627 previous/next-single-property-change returns nil, treat that as
6628 the beginning or the end of the buffer. (Bug#9955)
6629
fe0b6370
JD
66302011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6631
a58c13ed 6632 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6633 label is not null (Bug#9951).
6634 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6635 may be NULL.
6636
89bd5ee1
EZ
66372011-11-04 Eli Zaretskii <eliz@gnu.org>
6638
6639 * window.c (Fwindow_body_size): Mention in the doc string that the
6640 return value is in frame's canonical units. (Bug#9949)
6641
84c3edb9
EZ
66422011-11-03 Eli Zaretskii <eliz@gnu.org>
6643
4e2fb5c7
EZ
6644 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6645
84c3edb9 6646 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6647 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6648 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6649
bc17a887
EZ
66502011-11-01 Eli Zaretskii <eliz@gnu.org>
6651
6652 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6653 Don't stop backward scan on the continuation glyph, even though
6654 its CHARPOS is positive.
6d5eb5b0
SM
6655 (mouse_face_from_buffer_pos, note_mouse_highlight):
6656 Rename cover_string to disp_string.
bc17a887 6657
4ee88440
MR
66582011-11-01 Martin Rudalics <rudalics@gmx.at>
6659
6660 * window.c (temp_output_buffer_show): Don't use
6661 Vtemp_buffer_show_specifiers.
6662 (Vtemp_buffer_show_specifiers): Remove unused variable.
6663
c2ff3c02
EZ
66642011-10-30 Eli Zaretskii <eliz@gnu.org>
6665
6666 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6667 past the beginning of the current glyph matrix.
6668
58179cce 66692011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6670
6671 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6672 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6673 HAVE_GTK3 (Bug#9869).
b77a6a7f 6674
3b574623
JD
6675 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6676 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6677
b77a6a7f
JD
6678 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6679
6680 * xterm.c: Declare x_handle_net_wm_state to return int.
6681 (handle_one_xevent): Check if we are iconified but don't have
6682 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6683 (get_current_wm_state): Return non-zero if not hidden,
6684 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6685 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6686 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6687 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6688
196e41e4
PE
66892011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6690
6691 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6692 so that this new function doesn't get optimized away by a
6693 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6694
021f2e1a
AS
66952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6696
6697 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6698
8b058d44
EZ
66992011-10-29 Eli Zaretskii <eliz@gnu.org>
6700
6701 Fix the `xbytecode' command.
6702 * .gdbinit (xprintbytestr): New command.
b50a28de 6703 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6704 (xbytecode): Print the byte-code string as well.
6705
4452fb80
EZ
67062011-10-29 Kim Storm <storm@cua.dk>
6707
8b058d44
EZ
6708 * alloc.c (which_symbols): New function.
6709
21b72067
AS
67102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6711
6712 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6713 line. (Bug#9903)
6714
83ed7b5c
GM
67152011-10-29 Glenn Morris <rgm@gnu.org>
6716
6717 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6718 Not clear what it was for, and it causes various bugs. (Bug#9839)
6719
5a7a728b
EZ
67202011-10-28 Eli Zaretskii <eliz@gnu.org>
6721
6722 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6723 possible random value that matches one of those tested as
6724 condition to clear the mouse face.
6725
d3d0842f
CY
67262011-10-28 Chong Yidong <cyd@gnu.org>
6727
6728 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6729
31b39d13
DN
67302011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6731
6732 * window.c (make_window): Initialize phys_cursor_on_p.
6733
9aba6043
SM
67342011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6735
6736 * lisp.h (struct Lisp_Symbol): Update comments.
6737
c20992f4
JB
67382011-10-28 Juanma Barranquero <lekktu@gmail.com>
6739
6740 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6741
db4f02f2
EZ
67422011-10-28 Eli Zaretskii <eliz@gnu.org>
6743
6744 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6745 <oslsachem@gmail.com> for helping to debug this.
6746
6747 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6748 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6749 (g_b_init_get_glyph_outline_w): New static variables.
6750 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6751 (GetGlyphOutlineW_Proc): New typedefs.
6752 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6753 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6754 New functions.
6755 (w32font_open_internal, compute_metrics):
6756 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6757 instead of calling the "wide" APIs directly.
6758
6759 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6760
6761 * w32.h (syms_of_w32font): Add prototype.
6762
87e68db4
JB
67632011-10-27 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6766 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6767 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6768 (Fmove_to_window_line): Doc fix.
6769
435c1d67
CY
67702011-10-27 Chong Yidong <cyd@gnu.org>
6771
6772 * process.c (make_process): Set gnutls_state to NULL.
6773
6774 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6775 non-NULL, regardless of GNUTLS_INITSTAGE.
6776 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6777 an error. Set process slots as soon as we allocate them.
6778
6779 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6780
9c6c6f49
CY
67812011-10-27 Chong Yidong <cyd@gnu.org>
6782
9aba6043
SM
6783 * gnutls.c (emacs_gnutls_deinit): New function.
6784 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6785 (Fgnutls_deinit, Fgnutls_boot): Use it.
6786
6787 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6788 (deactivate_process): Call emacs_gnutls_deinit.
6789
657d08d3
JB
67902011-10-27 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * image.c (x_create_x_image_and_pixmap):
6793 * w32.c (sys_rename, w32_delayed_load):
6794 * w32font.c (fill_in_logfont):
6795 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6796
5430d399
JB
67972011-10-26 Juanma Barranquero <lekktu@gmail.com>
6798
6799 * w32fns.c (w32_default_color_map): New function,
6800 extracted from Fw32_default_color_map.
a7ef684b 6801 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6802
fe0055fa
PE
68032011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6804
6805 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6806
e6346438
SM
68072011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * keyboard.c (test_undefined): New function (bug#9751).
6810 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6811
e112cc37
ET
68122011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6813
6814 * sysdep.c (init_sys_modes): Fix the check for the controlling
6815 terminal (Bug#6649).
6816
7b5d6677
EZ
68172011-10-20 Eli Zaretskii <eliz@gnu.org>
6818
6819 * dispextern.h (struct bidi_it): New member next_en_type.
6820
6821 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6822 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6823 current character, check also for next_en_type being WEAK_EN.
6824 (bidi_resolve_weak): Don't enter the expensive loop if the current
6825 position is before next_en_pos. Record the bidi type of the first
6826 non-ET, non-BN character we find, in addition to its position.
6827 (bidi_level_of_next_char): Invalidate next_en_type when
6828 next_en_pos is over-stepped.
6829
7da0b018
PE
68302011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6831
6832 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6833 * editfns.c: Rewrite current-time-zone so that it invokes
6834 the equivalent of (format-time-string "%Z") to get the time zone name.
6835 This fixes a bug when the time zone name contains characters that
6836 need converting from the system time locale to Emacs internal format.
6837 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6838 that patch fixed format-time-string to do the conversion, but
6839 I forgot to fix current-time-zone.
6840 (format_time_string): New function, containing most of
6841 what Fformat_time_string used to contain.
6842 (Fformat_time_string): Rewrite in terms of format_time_string.
6843 This doesn't change this function's behavior.
6844 (current-time-zone): Rewrite to use format_time_string.
6845 This fixes the bug reported by Michael Schierl in
6846 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6847 Jason Rumney's 2007-06-07 change worked around this bug, but
6848 didn't fix it.
6849 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6850
8547b010
EZ
68512011-10-19 Eli Zaretskii <eliz@gnu.org>
6852
6853 * xdisp.c (start_display): If the character at POS is displayed
6854 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6855 (try_window_reusing_current_matrix): If a line ends in a display
6856 vector or the next line starts in a display vector, continue
6857 redrawing the window even though the character position of
6858 start_row was reached.
8547b010
EZ
6859 (Bug#9771, part 2)
6860
4e948d15
CY
68612011-10-18 Chong Yidong <cyd@gnu.org>
6862
6863 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6864 with nobreak-char-display too.
6865
4787455f
EZ
68662011-10-18 Eli Zaretskii <eliz@gnu.org>
6867
6868 Fix part 3 of bug#9771.
6869 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6870 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6871 non-neutral characters if the current character is a paragraph
6872 separator (a.k.a. Newline). This avoids running the same
6873 expensive loop twice, once when we consume the preceding newline
6874 and the other time when the line actually needs to be displayed.
6875 Avoid the loop when we see neutrals on the base embedding level
6876 following a character whose directionality is the same as the
6877 paragraph's. This avoids running the expensive loop when a line
6878 ends in a long sequence of neutrals, like control characters.
6879 Add assertion against STRONG_AL type. Slightly rearrange code
6880 that determines the type of a neutral given the first non-neutral
6881 that follows it.
6882 (bidi_level_of_next_char): Set next_en_pos to zero when
6883 invalidating its info.
6884
2c91f553
EZ
68852011-10-17 Eli Zaretskii <eliz@gnu.org>
6886
6887 * xdisp.c (push_display_prop): Determine whether to record string
6888 or buffer position by IT->string, not by IT->method. Allow
6889 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6890 (move_it_vertically_backward): Don't look for character position
6891 immediately after the newline when in a continuation line.
6892 (Bug#9771, part 1)
2c91f553 6893
c7b08b0d
MR
68942011-10-15 Martin Rudalics <rudalics@gmx.at>
6895
6896 * window.c (coordinates_in_window): Rewrite and delabelize
6897 vertical border check. (Bug#5357) (Bug#9618)
6898
6b02f655
SM
68992011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6900
6901 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6902 errors in XSetWindowBorder (bug#9310).
6903
81d40c92
DA
69042011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6905
6906 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6907 avoid crash when xmalloc overrun checking is enabled.
6908
d4172c3b
EZ
69092011-10-13 Eli Zaretskii <eliz@gnu.org>
6910
6911 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6912 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6913 cursor motion with <left> and <right> arrow keys.
6914
6915 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6916 some callers set that themselves.
6917
b00eea75
EZ
69182011-10-12 Eli Zaretskii <eliz@gnu.org>
6919
6920 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6921 display string and the previous row comes from the same string and
6922 is empty. (Bug#9739) (Bug#9738)
6923
8fe012c4
SM
69242011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6925
6926 * doc.c (get_doc_string): Encode file name (bug#9735).
6927
0074aef2
EZ
69282011-10-12 Eli Zaretskii <eliz@gnu.org>
6929
79beb178
EZ
6930 * bidi.c (bidi_level_of_next_char):
6931 * xdisp.c (get_visually_first_element): Remove old incorrect
6932 comments regarding the Unicode Line Separator character.
6933
0074aef2
EZ
6934 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6935
6e4b3fbe
DA
69362011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6937
6938 * alloc.c (Fgc_status): Do not access beyond zombies array
6939 boundary if nzombies > MAX_ZOMBIES.
6940 * alloc.c (dump_zombies): Add missing format specifier.
6941
0324f3af
PE
69422011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6943
b5525cac
PE
6944 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6945 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6946
0324f3af
PE
6947 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6948 Some packages use them to denote characters with modifiers.
6949
e9b5f888
AS
69502011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6951
6952 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6953 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6954 matching a pp-number. Rename parameter var to var1.
6955
127827c0
SM
69562011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6957
6958 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6959
c8fd3bd0
GM
69602011-10-08 Glenn Morris <rgm@gnu.org>
6961
6962 * callint.c (Fcall_interactively): Give a more explicit error for the
6963 'c' case with a non-character input. (Bug#8479)
6964
352ec8ff
EZ
69652011-10-08 Eli Zaretskii <eliz@gnu.org>
6966
03669ccb
EZ
6967 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6968 lines.
7061c986
EZ
6969 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6970 lines that are hscrolled on the left.
03669ccb 6971
352ec8ff
EZ
6972 * dispnew.c (buffer_posn_from_coords): Account for a possible
6973 presence of header-line. (Bug#4426)
6974
a66cfb1c
SM
69752011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6976
6b02f655
SM
6977 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6978 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6979
7c5ee88e
PE
69802011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6983 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6984 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6985 this makes Emacs dump core during garbage collection on rare
6986 occasions. sizeof is obviously inferior to offsetof here, so
6987 stick with offsetof.
6988 (GC_POINTER_ALIGNMENT): New macro.
6989 (mark_memory): Omit 3rd (offset) arg; caller changed.
6990 Don't assume EMACS_INT alignment is the same as pointer alignment.
6991
df1bbe5b
SM
69922011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6993
6994 * keyboard.c (read_key_sequence_remapped): New var.
6995 (read_key_sequence): Compute remapping in the right buffer.
6996 (command_loop_1): Use read_key_sequence's remapping directly.
6997
51553db6
SM
69982011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6999
32c1fffd
SM
7000 * dired.c (file_name_completion): Don't expand file name.
7001 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7002 before checking file name handler.
7003
51553db6
SM
7004 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7005 they've been requested explicitly (bug#9591).
7006
b6bd1599 70072011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7008
7009 * keymap.c (Fsingle_key_description): Use make_specified_string
7010 instead of build_string to build string from push_key_description.
7011 (Bug#5193)
7012
f701dc2a
PE
70132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7014
4222c55d
PE
7015 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7016 This fixes a Y2038 bug on 64-bit hosts.
7017 * buffer.c (reset_buffer):
7018 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7019 (Fclear_buffer_auto_save_failure):
7020 Use 0, not -1, to represent an unset failure time, since time_t
7021 might not be signed.
7022
f701dc2a
PE
7023 Remove dependency on glibc malloc internals.
7024 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7025 Move back here from lisp.h, but with their new implementations.
7026 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7027 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7028 * charset.c (charset_table_init): New static var.
7029 (syms_of_charset): Use it instead of xmalloc. This removes a
7030 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7031 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7032 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7033 Move back to alloc.c.
7034 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7035 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7036
9ceebf39
JD
70372011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7038
7039 * nsterm.m (windowDidResize): Call x_set_window_size only when
7040 ns_in_resize is true. Otherwise set pixelwidth/height and
7041 call change_frame_size (Bug#9628).
7042
cb993c58
PE
70432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7044
3930c88b
PE
7045 Port --enable-checking=all to Fedora 14 x86-64.
7046 * charset.c (syms_of_charset): Also account for glibc malloc's
7047 internal overhead when calculating the initial malloc maximum.
7048
cb993c58
PE
7049 Port --enable-checking=all to Fedora 14 x86.
7050 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7051 Move to lisp.h.
7052 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7053 (overrun_check_realloc, overrun_check_free):
7054 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7055 That way, xmalloc returns a properly-aligned pointer even if
7056 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7057 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7058 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7059 into account when calculating the initial malloc maximum.
7060 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7061 Move here from alloc.c, so that charset.c can use it too.
7062 Properly align; the old code wasn't right for common 32-bit hosts
7063 when configured with --enable-checking=all.
7064 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7065 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7066
31bed486
EZ
70672011-09-29 Eli Zaretskii <eliz@gnu.org>
7068
04c70788 7069 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7070 use EDOM.
7071
fbcaa2f3
EZ
70722011-09-28 Eli Zaretskii <eliz@gnu.org>
7073
7074 * xdisp.c (compute_display_string_end): If there's no display
7075 string at CHARPOS, return -1.
7076
7077 * bidi.c (bidi_fetch_char): When compute_display_string_end
7078 returns a negative value, treat the character as a normal
7079 character not covered by a display string. (Bug#9624)
7080
a239d4e9
JB
70812011-09-28 Juanma Barranquero <lekktu@gmail.com>
7082
7083 * lread.c (Fread_from_string): Fix typo in docstring.
7084
88652fd5
EZ
70852011-09-27 Eli Zaretskii <eliz@gnu.org>
7086
7087 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7088 newline, reseat the iterator instead of bidi-iterating there one
7089 character at a time. (Bug#9610)
32c1fffd
SM
7090 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7091 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7092
ed497dd4
AS
70932011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7094
7095 * lread.c (readevalloop): Use correct code for NBSP.
7096 (read1): Likewise. (Bug#9608)
7097
b2bf61aa
MA
70982011-09-25 Michael Albinus <michael.albinus@gmx.de>
7099
7100 * dbusbind.c (Fdbus_register_signal): When service is not
7101 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7102
32bbb17c
GM
71032011-09-25 Glenn Morris <rgm@gnu.org>
7104
7105 * buffer.c (truncate-lines): Doc fix.
7106
94e0933e
CY
71072011-09-24 Chong Yidong <cyd@stupidchicken.com>
7108
7109 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7110 (Fset_window_next_buffers): Doc fix.
7111
cddde921
GM
71122011-09-24 Glenn Morris <rgm@gnu.org>
7113
7114 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7115
1260aef1
PE
71162011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7117
25b4bfa0
PE
7118 Fix minor problems found by static checking.
7119 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7120 * indent.c (Fvertical_motion): Fix == vs = typo.
7121
e3cbd34b
EZ
71222011-09-24 Eli Zaretskii <eliz@gnu.org>
7123
a66cfb1c
SM
7124 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7125 Default value is now t. Doc fix.
6bf7006f 7126
e3cbd34b 7127 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7128 logic when moving up, not only when moving down. Fix the
e3cbd34b 7129 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7130 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7131
7132 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7133 CHARPOS is covered by a display string which includes newlines.
7134 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7135 is covered by a display string with embedded newlines.
7136
a3de0cbd
MA
71372011-09-24 Michael Albinus <michael.albinus@gmx.de>
7138
7139 * dbusbind.c (Fdbus_register_signal): Add match rule to
7140 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7141 (Fdbus_register_method, Vdbus_registered_objects_table):
7142 Fix docstring.
a3de0cbd 7143
b260039d
JM
71442011-09-24 Jim Meyering <meyering@redhat.com>
7145
32c1fffd 7146 do not ignore write error for any output size
b260039d
JM
7147 The previous change was incomplete.
7148 While it makes emacs --batch detect the vast majority of stdout
7149 write failures, errors were still ignored whenever the output size is
7150 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7151 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7152 && echo FAIL: ignored write error
7153 FAIL: ignored write error
7154 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7155 && echo FAIL: ignored write error
7156 FAIL: ignored write error
7157 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7158
8eca8a7c
AS
71592011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7160
7161 * emacs.c (Fkill_emacs): In noninteractive mode exit
7162 non-successfully if a write error occurred on stdout. (Bug#9574)
7163
3341db62
EZ
71642011-09-21 Eli Zaretskii <eliz@gnu.org>
7165
7166 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7167 the xassert test.
7168
7169 * dispextern.h (struct it): Update the comment documenting what
7170 can it->OBJECT be.
7171
8c203dbf
EZ
71722011-09-20 Eli Zaretskii <eliz@gnu.org>
7173
7174 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7175 a display string, extend search for cursor position to end of row.
7176 (find_row_edges): If the row ends in a newline from a display
7177 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7178 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7179 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7180 non-empty line. Fixes confusing cursor motion with arrow keys at
7181 the beginning of a line that starts with whitespace.
8c203dbf 7182
a4824228
LMI
71832011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7184
7185 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7186 (bug#9493).
7187
33ed493b
CY
71882011-09-18 Chong Yidong <cyd@stupidchicken.com>
7189
7190 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7191 boolean (Bug#9154).
7192
56cd55c8
EZ
71932011-09-18 Eli Zaretskii <eliz@gnu.org>
7194
7195 * xdisp.c (display_line): Record maximum and minimum buffer
7196 positions even if no glyphs were produced (e.g., by a zero-width
7197 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7198 buffer positions that will be removed from the glyph row because
7199 they don't fit.
c02dcedf
EZ
7200 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7201 column is beyond frame width: don't subtract 1 "pixel" when
7202 computing width of the stretch.
3e62b7e0
EZ
7203 (reseat_at_next_visible_line_start): Undo the change made on
7204 2011-09-17 that saved paragraph information and restored it after
7205 the call to `reseat'. (Bug#9545)
56cd55c8 7206
5ed99d36 72072011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7208
7209 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7210 and turn window cursor on if cleared (Bug#9415).
7211
5ed99d36 72122011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7213
7214 * search.c (boyer_moore): Take unibyte characters from pattern
7215 literally. (Bug#9458)
7216
9bade7b2
EZ
72172011-09-18 Eli Zaretskii <eliz@gnu.org>
7218
7219 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7220
e5e9d610
PE
72212011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7222
87e4427a
PE
7223 Fix minor problem found by static checking.
7224 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7225 initialized, to pacify gcc -Wuninitialized.
7226
e5e9d610
PE
7227 * fileio.c: Report proper errno when syscall falls.
7228 (Finsert_file_contents): Save and restore errno,
7229 so that report_file_error outputs the correct diagnostic.
7230 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7231
a1674f0b
EZ
72322011-09-18 Eli Zaretskii <eliz@gnu.org>
7233
7234 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7235
fbfb6dd4
EZ
72362011-09-17 Eli Zaretskii <eliz@gnu.org>
7237
7238 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7239 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7240
bb187662
EZ
72412011-09-17 Eli Zaretskii <eliz@gnu.org>
7242
1137e8b8 7243 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7244 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7245
7246 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7247 (bidi_find_paragraph_start): Search back for paragraph beginning
7248 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7249 (bidi_move_to_visually_next): Only trigger paragraph-related
7250 computations when the last character is a newline or at EOB, not
7251 just any NEUTRAL_B. (Bug#9470)
7252
bb187662
EZ
7253 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7254 truncated lines if point is covered by a display string. (Bug#9524)
7255
2e621251
PE
72562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7257
7258 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7259 (cons_to_x_long): New function.
7260 (lisp_data_to_selection_data): Use it. Correct the test for
7261 short-versus-long data; it was negated. Break out of vector
7262 loop, for efficiency, when a long datum is discovered.
7263
91a15bc6
SM
72642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7265
7266 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7267
b41c3a35
EZ
72682011-09-16 Eli Zaretskii <eliz@gnu.org>
7269
7270 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7271 GCC PR/17406) by declaring this function with external scope.
7272
7812ba2d
PE
72732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7274
7275 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7276 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7277
cf7edc2a
AS
72782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7279
7280 * editfns.c (Fformat): Correctly handle text properties on "%%".
7281
bd01620e
EZ
72822011-09-15 Eli Zaretskii <eliz@gnu.org>
7283
7284 * xterm.c (x_draw_composite_glyph_string_foreground):
7285 * w32term.c (x_draw_composite_glyph_string_foreground):
7286 * term.c (encode_terminal_code):
7287 * composite.c (composition_update_it, get_composition_id):
7288 * xdisp.c (get_next_display_element)
7289 (fill_composite_glyph_string): Add comments about special meaning
7290 of TAB characters in a composition.
7291
a02719a3
PE
72922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7293
7294 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7295 This occurs when processing a multibyte format.
7296 Problem reported by Wolfgang Jenker.
a02719a3 7297
72589a3c
JB
72982011-09-15 Johan Bockgård <bojohan@gnu.org>
7299
7300 * xdisp.c (try_cursor_movement): Only check for exact match if
7301 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7302
1c14176c
PE
73032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7304
7305 Remove unused external symbols.
7306 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7307 * xdisp.c (calc_pixel_width_or_height): Now static.
7308 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7309 * indent.c (check_display_width):
7310 * w32term.c: Fix comment to match code.
7311 * xterm.c, xterm.h (x_catching_errors): Remove.
7312
d2eea5b5
PE
73132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7314
7315 * xselect.c: Use signed conversions more consistently (Bug#9498).
7316 (selection_data_to_lisp_data): Assume incoming selection data are
7317 signed integers, not unsigned. This is to be consistent with
7318 outgoing selection data, which was modified to use signed integers
7319 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7320 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7321 expects long, not unsigned long.
7322
46888499
EZ
73232011-09-14 Eli Zaretskii <eliz@gnu.org>
7324
7325 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7326 computation of loop end. Reported by Johan Bockgård
7327 <bojohan@gnu.org>.
7328
ef8ef9fb
CY
73292011-09-13 Chong Yidong <cyd@stupidchicken.com>
7330
7331 * frame.c (Fother_visible_frames_p): Function deleted.
7332
fa819fed
EZ
73332011-09-12 Eli Zaretskii <eliz@gnu.org>
7334
7335 * indent.c (compute_motion): Process display vector front to back
7336 rather than the other way around. (Bug#2496)
7337
2ba8e008
SM
73382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7339
7340 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7341
20f53c69
CY
73422011-09-11 Chong Yidong <cyd@stupidchicken.com>
7343
7344 * minibuf.c (Fread_from_minibuffer): Doc fix.
7345
d562d7a4
EZ
73462011-09-11 Eli Zaretskii <eliz@gnu.org>
7347
7348 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7349 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7350
1c4d7f3d
LMI
73512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352
7353 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7354 value for non-existent files.
7355
b885bf36
EZ
73562011-09-11 Eli Zaretskii <eliz@gnu.org>
7357
7358 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7359 set its "size" to -1. This will set the modtime_size field of
7360 the corresponding buffer to -1, which is what
7361 verify-visited-file-modtime expects for files that do not exist.
7362 (Bug#9139)
7363
6612f0bf
PE
73642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7365
7366 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7367 here ...
7368 * lisp.h: ... from here. push_key_description is no longer
7369 defined in keyboard.c, so its declaration should not be in
7370 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7371 logically belongs with push_key_description.
7372
dfb3f755
PE
73732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7374
7375 * buffer.h: Include <sys/types.h> instead of <time.h>.
7376 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7377 Problem reported by Herbert J. Skuhra.
7378
3134906c
LMI
73792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7380
7381 * xml.c (parse_region): Make the parsing work for
7382 non-comment-starting XML files again (bug#9144).
7383
8d903f4e
AS
73842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7385
7386 * image.c (gif_load): Fix calculation of bottom and right corner.
7387 (Bug#9468)
7388
80ad64f4
EZ
73892011-09-10 Eli Zaretskii <eliz@gnu.org>
7390
7391 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7392 redisplay in small windows.
7393
208a048d
EZ
73942011-09-09 Eli Zaretskii <eliz@gnu.org>
7395
7396 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7397
9b1c252e
MR
73982011-09-08 Martin Rudalics <rudalics@gmx.at>
7399
7400 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7401 Operate on live windows only.
7402
2949f33b
JB
74032011-09-08 Juanma Barranquero <lekktu@gmail.com>
7404
7405 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7406
e08dcafd
EZ
74072011-09-07 Eli Zaretskii <eliz@gnu.org>
7408
7409 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7410 only under bidi iteration.
7411
115b96bd
JD
74122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7413
7414 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7415
c8199d0f
PE
74162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7417
7418 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7419 Without this fix, the command to link temacs failed due to an
7420 undefined symbol __builtin_isnan. This is because
7421 /usr/include/iso/math_c99.h #defines isnan(x) to
7422 __builtin_isnan(x), but the bundled gcc, which identifies itself
7423 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7424 a __builtin_isnan.
7425 * floatfns.c (isnan): #undef, and then #define to a clone of
7426 what's in data.c.
7427 (Fisnan): Always define, since it's always available now.
7428 (syms_of_floatfns): Always define isnan at the Lisp level.
7429
e39b275c 74302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7431
7432 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7433
b2db44d9 74342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7435
f4af5137 7436 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7437 The previous code assumed that file offsets (off_t values) fit in
7438 EMACS_INT variables, which is not true on typical 32-bit hosts.
7439 The code messed up by falsely reporting buffer overflow in cases
7440 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7441 when "big" contains more than 2**29 bytes, even though this
7442 inserts just one byte and does not overflow the buffer.
7443 (Finsert_file_contents): Store file offsets as off_t
7444 values, not as EMACS_INT values. Check for overflow when
7445 converting between EMACS_INT and off_t. When checking for
7446 buffer overflow or for overlap, take the offsets into account.
7447 Don't use EMACS_INT for small values where int suffices.
7448 When checking for overlap, fix a typo: ZV was used where
7449 ZV_BYTE was intended.
7450 (Fwrite_region): Don't assume off_t fits into 'long'.
7451 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7452
ecfc0a49
MA
74532011-09-05 Michael Albinus <michael.albinus@gmx.de>
7454
7455 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7456
6511acf2 74572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7458
0999621a 7459 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7460
7461 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7462 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7463 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7464 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7465 (modify_event_symbol): Do not assume that the length of
7466 name_alist_or_stem is safe to alloca and fits in int.
7467 (Fexecute_extended_command): Likewise for function name and binding.
7468 (Frecursion_depth): Wrap around reliably on integer overflow.
7469 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7470 since some callers pass EMACS_INT values.
7471 (Fsingle_key_description): Don't crash if symbol name contains more
7472 than MAX_ALLOCA bytes.
7473 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7474 (get_minibuffer): Arg is now EMACS_INT, not int.
7475 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7476 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7477 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7478
2be7d702
PE
7479 * dbusbind.c (signature_cat): New function.
7480 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7481 Do not overrun buffer; instead, report string overflow.
7482
9d1df220
PE
7483 * dispnew.c (add_window_display_history): Don't overrun buffer.
7484 Truncate instead; this is OK since it's just a log.
7485
33ef5c64
PE
7486 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7487 even if the time zone offset is outlandishly large.
7488 Don't mishandle offset == INT_MIN.
7489
66c6fdd5
PE
7490 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7491 when creating daemon; the previous buffer-overflow check was incorrect.
7492
d749b01b
PE
7493 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7494 which has the guts of the old verror function.
7495
b5cd1905
PE
7496 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7497 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7498
6e1a67fb
PE
7499 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7500 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7501 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7502 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7503 length of string rather than counting it via multiple sprintfs;
7504 that's simpler and more reliable.
c21721cc
PE
7505 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7506 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7507 sprintf, in case result does not fit in int.
7508
c57b67fc
PE
7509 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7510 (fontset_from_font): Print it.
7511
8a401434
PE
7512 * frame.c (tty_frame_count): Now printmax_t, not int.
7513 (make_terminal_frame, set_term_frame_name): Print it.
7514 (x_report_frame_params): In X, window IDs are unsigned long,
7515 not signed long, so print them as unsigned.
7516 (validate_x_resource_name): Check for implausibly long names,
7517 and don't assume name length fits in 'int'.
7518 (x_get_resource_string): Don't blindly alloca invocation name;
7519 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7520 not fit in int.
7521
6e1a67fb
PE
7522 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7523 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7524 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7525
0df02bf3
PE
7526 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7527 Use esprintf, not sprintf, in case result does not fit in int.
7528
48e30793
PE
7529 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7530 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7531 it as a large positive number.
7532 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7533 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7534
a66ff6d8
PE
7535 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7536 in case result does not fit in int.
7537
aca216ff
PE
7538 * print.c (float_to_string): Detect width overflow more reliably.
7539 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7540 buffer overrun. Don't assume list length fits in 'int'. Treat
7541 print length of 0 as 0, not as infinity; to be consistent with other
7542 uses of print length in this function. Don't overflow print length
7543 index. Don't assume hash table size fits in 'long', or that
7544 vectorlike size fits in 'unsigned long'.
7545
31c286f7
PE
7546 * process.c (make_process): Use printmax_t, not int, to format
7547 process-name gensyms.
7548
55e5faa1
PE
7549 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7550
80f2e268
PE
7551 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7552 to avoid potential buffer overrun.
7553
670741ab
PE
7554 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7555 if X resource line is longer than 512 bytes.
7556
b7163a50
PE
7557 * xfns.c (x_window): Make sprintf buffer a bit bigger
7558 to avoid potential buffer overrun.
7559
ae58ff1f
PE
7560 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7561
c43c8a6a
PE
7562 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7563
3f8236f4
PE
75642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7565
53e9fe90 7566 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7567 Without these, Emacs silently mishandles large integers sometimes.
7568 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7569 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7570
6511acf2
PE
7571 * xdisp.c (try_window_id): Check Emacs fixnum range before
7572 converting to 'int'.
806add1d 7573
6511acf2 7574 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7575 Check that an Emacs fixnum is in range before assigning it to 'int'.
7576 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7577 values converted from Emacs fixnums.
7578 (Frecenter): Don't wrap around a line count if it is out of 'int'
7579 range; instead, treat it as an extreme value.
7580 (Fset_window_configuration, compare_window_configurations):
7581 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7582
6511acf2
PE
7583 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7584 that can exceed INT_MAX. Check that EMACS_INT value is in range
7585 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7586 (match_limit): Don't assume that a fixnum can fit in 'int'.
7587
6511acf2 7588 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7589 exceed INT_MAX.
7590
6511acf2 7591 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7592 (Fvertical_motion): Don't wrap around LINES values that don't fit
7593 in 'int'. Instead, treat them as extreme values. This is good
7594 enough for windows, which can't have more than INT_MAX lines anyway.
7595
fcb901a7
LMI
75962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7597
0f2f6b6d
LMI
7598 * Require libxml/parser.h to avoid compilation warning.
7599
fcb901a7
LMI
7600 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7601
7602 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7603 since this reportedly can destroy thread storage.
7604
6e20a0d4
CY
76052011-08-30 Chong Yidong <cyd@stupidchicken.com>
7606
7607 * syntax.c (find_defun_start): Update all cache variables if
7608 exiting early (Bug#9401).
7609
148ae00e
EZ
76102011-08-30 Eli Zaretskii <eliz@gnu.org>
7611
f6cfbd8f
EZ
7612 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7613
148ae00e
EZ
7614 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7615 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7616 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7617
7618 * term.c (tty_append_glyph): New function.
7619 (produce_stretch_glyph): Static function and its prototype deleted.
7620
a66cfb1c
SM
7621 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7622 Add prototypes.
148ae00e 7623
c4a07a4c
PE
76242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7625
7626 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7627 when checking :margin (Bug#9390).
7628 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7629 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7630 so that the name doesn't mislead. All uses changed.
7631
6bc8cd65
JB
76322011-08-28 Johan Bockgård <bojohan@gnu.org>
7633
7634 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7635 set_tty_hooks.
7636
dca4927e
EZ
76372011-08-27 Eli Zaretskii <eliz@gnu.org>
7638
7639 * xdisp.c (move_it_to): Don't bail out early when reaching
7640 position beyond to_charpos, if we are scanning backwards.
7641 (move_it_vertically_backward): When DY == 0, make sure we get to
7642 the first character in the line after the newline.
7643
f2cad773
PE
76442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7645
7646 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7647 (ccl_driver): Do not generate an out-of-range pointer.
7648 (Fccl_execute_on_string): Remove unnecessary check for
7649 integer overflow, noted by Stefan Monnier in
7650 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7651 Remove a FIXME that didn't need fixing.
7652 Simplify the newly-introduced buffer reallocation code.
7653
0cae2cdb
JB
76542011-08-27 Juanma Barranquero <lekktu@gmail.com>
7655
7656 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7657
5fc295a4 76582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7659
70c60eb2 7660 Integer and memory overflow issues (Bug#9196).
726e0ab1 7661
d31850da
PE
7662 * doc.c (get_doc_string): Rework so that
7663 get_doc_string_buffer_size is the actual buffer size, rather than
7664 being 1 less than the actual buffer size; this makes xpalloc more
7665 convenient.
7666
a69fbedb
PE
7667 * image.c (x_allocate_bitmap_record, cache_image):
7668 * xselect.c (Fx_register_dnd_atom):
7669 Simplify previous changes by using xpalloc.
7670
fe5c5d37
PE
7671 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7672 since either will do and ptrdiff_t is convenient with xpalloc.
7673
0065d054
PE
7674 * charset.c (charset_table_size)
7675 (struct charset_sort_data.priority): Now ptrdiff_t.
7676 (charset_compare): Don't overflow if priorities differ greatly.
7677 (Fsort_charsets): Don't assume list length fits in int.
7678 Check for size-calculation overflow when allocating sort data.
7679 (syms_of_charset): Allocate an initial charset table that is
7680 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7681
7682 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7683
7684 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7685 The actual value is always <= INT_MAX, and leaving it unsigned made
7686 overflow checking harder.
7687
7688 * dispextern.h (struct glyph_matrix.rows_allocated)
7689 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7690 with xpalloc. The values are still always <= INT_MAX.
7691
7692 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7693
7694 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7695 (SAFE_NALLOCA): New macro.
7696
7697 * region-cache.c (struct boundary.pos, find_cache_boundary)
7698 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7699 (set_cache_region, invalidate_region_cache)
7700 (revalidate_region_cache, know_region_cache, region_cache_forward)
7701 (region_cache_backward, pp_cache):
7702 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7703 so that ptrdiff_t * can be passed to xpalloc.
7704 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7705 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7706 (pp_cache): Don't assume cache_len fits in int.
7707 * region-cache.h: Adjust extern decls to match.
7708
7709 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7710 EMACS_INT, since either will do, for xpalloc.
7711
7712 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7713 (xnmalloc, xnrealloc, xpalloc): New functions.
7714
726e0ab1
PE
7715 * bidi.c (bidi_shelve_header_size): New constant.
7716 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7717 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7718
51f30bc5 7719 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7720 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7721 (overlay_strings):
7722 Don't update size of array until after memory allocation succeeds,
7723 because xmalloc/xrealloc may not return.
0065d054
PE
7724 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7725 now that we have proper integer overflow checking.
7726 (record_overlay_string, overlay_strings): Catch overflows when
7727 calculating size of overlay_str_buf.
726e0ab1 7728
0065d054
PE
7729 * callproc.c (Fcall_process): Check for size overflow when
7730 calculating size of args2.
7731 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7732 Normally we prefer signed values, but sticking with ptrdiff_t would
7733 require adding more-complicated checks.
726e0ab1
PE
7734
7735 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7736 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7737 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7738 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7739
7740 * character.c (Fstring): Check for size-calculation overflow.
7741
7742 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7743 unnecessary integer overflow. Check for size overflow.
7744 (encode_coding_object): Don't update size until xmalloc succeeds.
7745
7746 * composite.c (get_composition_id): Check for overflow in glyph
7747 length calculations.
7748
7749 Integer and memory overflow fixes for display code.
7750 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7751 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7752 (scrolling_window): Check for overflow in size calculations.
7753 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7754 Don't assume glyph table len fits in int.
7755 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7756 (row_table_size): Now ptrdiff_t, not int.
7757 (scrolling_window): Avoid overflow in size calculations.
7758 Don't update size until allocation succeeds.
7759 * fns.c (concat): Check for overflow in size calculations.
7760 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7761 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7762 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7763
7764 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7765 (get_doc_string): Check for size calculation overflow.
7766 Don't update size until allocation succeeds.
7767 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7768 EMACS_INT, where ptrdiff_t will do.
7769 (Fsubstitute_command_keys): Check for string overflow.
7770
7771 * editfns.c (set_time_zone_rule): Don't assume environment length
7772 fits in int.
7773 (message_length): Now ptrdiff_t, not int.
7774 (Fmessage_box): Don't update size until allocation succeeds.
7775 Don't assume message length fits in int.
7776 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7777
0065d054
PE
7778 * emacs.c (main): Do not reallocate argv, since there is a null at
7779 the end that can be overwritten, and this way there's no need to
7780 worry about size-calculation overflow.
7781 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7782
7783 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7784 alloc succeeds.
7785 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7786
7787 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7788 (x_set_scroll_bar_width, x_figure_window_size):
7789 Check for integer overflow.
7790 (x_set_alpha): Do not assume XINT fits in int.
7791
7792 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7793 This is for the members text_lines, text_cols, total_lines, total_cols,
7794 where the system imposes an 'int' limit.
7795
7796 * fringe.c (Fdefine_fringe_bitmap):
7797 Don't update size until alloc works.
7798
7799 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7800 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7801
7802 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7803 Check for size-calculation overflow.
7804 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7805 do, as we prefer signed integers.
7806 (id_to_widget.max_size, id_to_widget.used)
7807 (xg_store_widget_in_map, xg_remove_widget_from_map)
7808 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7809 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7810 Use and return ptrdiff_t, not int.
7811 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7812 * gtkutil.h: Change prototypes to match the above.
7813
7814 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7815 are duplicate now that they've been promoted to lisp.h.
7816 (x_allocate_bitmap_record, x_alloc_image_color)
7817 (make_image_cache, cache_image, xpm_load):
7818 Don't update size until alloc is done.
7819 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7820 (x_detect_edges):
3256efce 7821 Check for size calculation overflow.
726e0ab1
PE
7822 (ct_colors_allocated_max): New constant.
7823 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7824 overflow.
3256efce 7825
726e0ab1
PE
7826 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7827 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7828 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7829 Use ptrdiff_t, not int, to count maps.
7830 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7831 calculations. Don't update size until allocation succeeds.
7832 Redo calculations to avoid overflow.
726e0ab1
PE
7833 * keyboard.h: Change prototypes to match the above.
7834
7835 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7836 to count maps.
7837 (current_minor_maps): Check for size calculation overflow.
7838 * keymap.h: Change prototypes to match the above.
7839
7840 * lread.c (read1, init_obarray): Don't update size until alloc done.
7841
7842 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7843 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7844
726e0ab1
PE
7845 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7846 Now ptrdiff_t, not int.
7847 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7848 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7849
7850 * process.c (Fnetwork_interface_list): Check for overflow
7851 in size calculation.
7852
7853 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7854
7855 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7856 overflow. Don't bother calling xmalloc when xrealloc will do.
7857
7858 * search.c (Freplace_match): Check for size calculation overflow.
7859 (Fset_match_data): Don't assume list lengths fit in 'int'.
7860
7861 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7862 for command line length. Do not attempt to address one before the
7863 beginning of an array, as that's not portable.
7864
7865 * term.c (max_frame_lines): Remove; unused.
7866 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7867 not int.
7868 (encode_terminal_code, calculate_costs): Check for size
7869 calculation overflow.
7870 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7871 table lengths and related sizes. Don't update size until alloc
7872 done. Redo calculations to avoid overflow.
7873 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7874
7875 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7876 subtracting pointers.
7877 (gobble_line): Check for overflow more carefully. Don't update size
7878 until alloc done.
7879
7880 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7881 Don't update size until alloc done.
7882 Redo size calculations to avoid overflow.
7883 Check for size calculation overflow.
0065d054 7884 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7885
7886 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7887 Use ptrdiff_t, not int, for sizes.
7888 (store_mode_line_noprop_char): Don't update size until alloc done.
7889
0065d054
PE
7890 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7891 Use ptrdiff_t, not int, for sizes.
7892 (Finternal_make_lisp_face, cache_face):
7893 Check for size calculation overflow.
7894 (cache_face): Treat size calculation overflows as if they were
7895 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7896
7897 * xfns.c (x_encode_text, x_set_name_internal)
7898 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7899 sizes, since they can exceed INT_MAX in size. Check for size
7900 calculation overflow.
7901
0065d054
PE
7902 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7903 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7904 Don't update size until alloc done.
7905
0065d054 7906 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7907 as sprintf is limited to int lengths.
1d526e2f 7908
252c5ee1
PE
7909 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7910 (X_LONG_MIN): New macros.
864d7ce7
PE
7911 Use them to make the following changes clearer.
7912 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7913 This change doesn't affect the value now, but it may help remind
7914 future maintainers not to raise the value too much later.
7915 (SELECTION_QUANTUM): Remove, replacing with ...
7916 (selection_quantum): ... new function, which avoids overflow.
7917 All uses changed.
7918 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7919 assumption that selection length fits in 'int'.
7920 (x_reply_selection_request, x_handle_selection_request)
7921 (x_get_window_property, receive_incremental_selection)
7922 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7923 (lisp_data_to_selection_data, clean_local_selection_data):
7924 Use ptrdiff_t, not int, to record length of selection.
7925 (x_reply_selection_request, x_get_window_property)
7926 (receive_incremental_selection, x_property_data_to_lisp):
7927 Redo calculations to avoid overflow.
7928 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7929 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7930 something.
7931 (x_get_window_property, receive_incremental_selection)
7932 (lisp_data_to_selection_data, x_property_data_to_lisp):
7933 Check for size-calculation overflow.
7934 (x_get_window_property, receive_incremental_selection)
7935 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7936 Don't store size until memory allocation succeeds.
7937 (x_get_window_property): Plug memory leak on memory exhaustion.
7938 Don't double-block input; malloc is safe here. Don't assume 2**34
7939 - 4 fits in unsigned long. Add an xassert to check
7940 XGetWindowProperty overflow. Be more careful about overflow
7941 calculations, and distinguish size from memory overflow better.
7942 (receive_incremental_selection): When tracing, don't assume
7943 unsigned int is less than INT_MAX.
7944 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7945 harmful) conversions of unsigned short to int.
7946 (lisp_data_to_selection_data): Don't assume that integers
7947 in the range -65535 through -1 fit in an X unsigned short.
7948 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7949 result parameters unless successful. Rely on cons_to_unsigned
7950 to report problems with elements; the old code wasn't right anyway.
7951 (x_check_property_data): Check for int overflow; we cannot use
7952 a wider type due to X limits.
7953 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7954
726e0ab1 7955 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7956
0065d054
PE
7957 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7958 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7959 (x_color_cells): Don't store size until memory allocation succeeds.
7960 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7961 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7962 (x_term_init): Don't assume length fits in int (sprintf is limited
7963 to int size).
bc18e09d 7964
ebfa62c0
PE
7965 Use ptrdiff_t for composition IDs.
7966 * character.c (lisp_string_width):
7967 * composite.c (composition_table_size, n_compositions)
7968 (get_composition_id, composition_gstring_from_id):
7969 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7970 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7971 * window.c (Frecenter):
7972 Use ptrdiff_t, not int, for composition IDs.
7973 * composite.c (get_composition_id): Check for integer overflow.
7974 * composite.h: Adjust prototypes to match the above changes.
7975
d3411f89
PE
7976 Use ptrdiff_t for hash table indexes.
7977 * category.c (hash_get_category_set):
7978 * ccl.c (ccl_driver):
7979 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7980 * coding.c (coding_system_charset_list, detect_coding_system):
7981 * coding.h (struct coding_system.id):
7982 * composite.c (get_composition_id, gstring_lookup_cache):
7983 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7984 * image.c (xpm_get_color_table_h):
7985 * lisp.h (hash_lookup, hash_put):
7986 * minibuf.c (Ftest_completion):
7987 Use ptrdiff_t for hash table indexes, not int (which is too
7988 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7989 32-bit --with-wide-int hosts).
7990
e097a6fa
PE
7991 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7992 Add a FIXME comment about memory leaks.
7993 (syms_of_charset): Don't assume xmalloc returns.
7994
5637687f
PE
7995 Don't assume that stated character widths fit in int.
7996 * character.c (Fchar_width, c_string_width, lisp_string_width):
7997 * character.h (CHAR_WIDTH):
7998 * indent.c (MULTIBYTE_BYTES_WIDTH):
7999 Use sanitize_char_width to avoid undefined and/or bad behavior
8000 with outlandish widths.
a66cfb1c 8001 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8002 now that we have two such functions. All uses changed.
8003 (sanitize_char_width): New inline function.
8004
a2271ba2
PE
8005 Don't assume that tab-width fits in int.
8006 * character.h (sanitize_width): New inline function.
8007 (SANE_TAB_WIDTH): New macro.
8008 (ASCII_CHAR_WIDTH): Use it.
8009 * indent.c (sane_tab_width): Remove. All uses replaced by
8010 SANE_TAB_WIDTH (current_buffer).
8011 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8012
18c52557
PE
8013 * fileio.c: Integer overflow issues with file modes.
8014 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8015
caeeedc1
PE
8016 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8017 Remove unreachable code.
8018 (read_hex, load_charset_map_from_file): Check for integer overflow.
8019
6df6ae42 8020 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8021 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8022 (x_send_scroll_bar_event): Likewise. Check that the size does not
8023 exceed limits imposed by XClientMessageEvent, as well as the usual
8024 ptrdiff_t and size_t limits.
8025
b13995db
PE
8026 * keyboard.c: Overflow, signedness and related fixes.
8027 (make_lispy_movement): Use same integer type in forward decl
8028 that is used in the definition.
8029 (read_key_sequence, keyremap_step):
8030 Change bufsize argument back to int, undoing my 2011-03-30 change.
8031 We prefer signed types, and int is wide enough here.
8032 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8033 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8034 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8035 length, not size_t. Use ptrdiff_t for index, not int.
8036 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8037 possibility of integer overflow.
8038
13464394
PE
8039 Overflow, signedness and related fixes for images.
8040
8041 * dispextern.h (struct it.stack[0].u.image.image_id)
8042 (struct_it.image_id, struct image.id, struct image_cache.size)
8043 (struct image_cache.used, struct image_cache.ref_count):
8044 * gtkutil.c (update_frame_tool_bar):
8045 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8046 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8047 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8048 * nsmenu.m (update_frame_tool_bar):
8049 * xdisp.c (calc_pixel_width_or_height):
8050 * xfns.c (image_cache_refcount):
8051 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8052 on typical 64-bit hosts.
8053
8054 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8055 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8056 Omit unnecessary casts to int.
8057 (parse_image_spec): Check that integers fall into 'int' range
8058 when the callers expect that.
8059 (image_ascent): Redo ascent calculation to avoid int overflow.
8060 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8061 (lookup_image): Remove unnecessary tests.
8062 (xbm_image_p): Locals are now of int, not EMACS_INT,
8063 since parse_image_check makes sure they fit into int.
8064 (png_load, gif_load, svg_load_image):
8065 Prefer int to unsigned where either will do.
8066 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8067 old tiff_error_handler and tiff_warning_handler.
8068 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8069 stack buffer overflows. It uses only the features of vsnprintf
8070 that are common to both POSIX and native Microsoft.
8071 (tiff_error_handler, tiff_warning_handler): Use it.
8072 (tiff_load, gif_load, imagemagick_load_image):
8073 Don't assume :index value fits in 'int'.
8074 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8075 (imagemagick_load_image): Check that crop parameters fit into
8076 the integer types that MagickCropImage accepts. Don't assume
8077 Vimagemagick_render_type has a nonnegative value. Don't assume
8078 size_t fits in 'long'.
8079 (gs_load): Use printmax_t to print the widest integers possible.
8080 Check for integer overflow when computing image height and width.
8081
c11821d4
EZ
80822011-08-26 Eli Zaretskii <eliz@gnu.org>
8083
8084 * xdisp.c (redisplay_window): Don't force window start if point
8085 will be invisible in the resulting window. (Bug#9324)
8086
0c95fcf7
EZ
80872011-08-25 Eli Zaretskii <eliz@gnu.org>
8088
8089 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8090 the display spec is of the form `(space ...)'.
8091 (handle_display_spec): Return the value returned by
8092 handle_single_display_spec, not just 1 or zero.
8093 (handle_single_display_spec): If the display spec is of the form
8094 `(space ...)', and specifies display in the text area, return 2
8095 rather than 1.
fee65a97 8096 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8097 accurately, and prefer exact match for point under bidi.
8098 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8099
8100 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8101 into disp_prop; all users changed.
8102
8103 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8104 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8105 for the text covered by the display property.
8106
e4ed06f1
CY
81072011-08-25 Chong Yidong <cyd@stupidchicken.com>
8108
8109 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8110 Change return value to nil.
8111 (Frecord_buffer): Delete unused function.
8112
f67cdd7f
EZ
81132011-08-24 Eli Zaretskii <eliz@gnu.org>
8114
5980d4c6
EZ
8115 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8116 buffers, return left-to-right.
8610fe8b
EZ
8117 (set_cursor_from_row): Consider candidate row a win if its glyph
8118 represents a newline and point is on that newline. Fixes cursor
8119 positioning on the newline at EOL of R2L text within L2R
8120 paragraph, and vice versa.
8121 (try_cursor_movement): Check continued rows, in addition to
8122 continuation rows. Fixes unwarranted scroll when point enters a
8123 continued line of R2L text within an L2R paragraph, or vice versa.
8124 (cursor_row_p): Consider the case of point being equal to
8125 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8126 from the end of a short line to the beginning of a continued line
8127 of R2L text within L2R paragraph.
8128 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8129 composed characters.
5980d4c6 8130
f67cdd7f
EZ
8131 * bidi.c (bidi_check_type): Use xassert.
8132 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8133 members.
8134
bca633fb
EZ
81352011-08-23 Eli Zaretskii <eliz@gnu.org>
8136
8137 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8138 a character.
8139
4a5885a7
CY
81402011-08-23 Chong Yidong <cyd@stupidchicken.com>
8141
8142 * nsfont.m (ns_otf_to_script): Fix typo.
8143
0902a04e
KH
81442011-08-22 Kenichi Handa <handa@m17n.org>
8145
8146 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8147 extra slot even if the purpose is char-code-property-table.
8148
1a2e6670
EZ
81492011-08-23 Eli Zaretskii <eliz@gnu.org>
8150
8ddde651
EZ
8151 * xdisp.c (redisplay_window): When computing centering_position,
8152 account for the height of the header line. (Bug#8874)
8153
425cc014
EZ
8154 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8155 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8156 candidate is selected by the mouse, and that candidate has a
8157 composed character under the mouse.
8158
1a2e6670
EZ
8159 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8160 coordinates reported by pos-visible-in-window-p for a composed
8161 character in column zero.
8162
8b76d6f8
SM
81632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8164
8165 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8166
dac347dd
EZ
81672011-08-22 Eli Zaretskii <eliz@gnu.org>
8168
8169 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8170 consider it a hit if to_charpos is anywhere in the range of the
8171 composed buffer positions.
8172
e013fb34
CY
81732011-08-22 Chong Yidong <cyd@stupidchicken.com>
8174
8175 * image.c (gif_load): Don't assume that each subimage has the same
8176 dimensions as the base image. Handle disposal method that is
8177 "undefined" by the gif spec (Bug#9335).
8178
bd1ba3e8
CY
81792011-08-20 Chong Yidong <cyd@stupidchicken.com>
8180
8181 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8182 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8183
54a1215b
EZ
81842011-08-19 Eli Zaretskii <eliz@gnu.org>
8185
823564e5
EZ
8186 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8187 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8188 from an Org mode buffer to a Speedbar frame.
8189
54a1215b
EZ
8190 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8191 a composition, take its buffer position from IT->cmp_it.charpos.
8192 Fixes cursor positioning at the beginning of a line that begins
8193 with a composed character.
8194
9778ebcc
EZ
81952011-08-18 Eli Zaretskii <eliz@gnu.org>
8196
0be6ee06
EZ
8197 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8198 character bidirectional type, use STRONG_L instead. Fixes crashes
8199 in a buffer produced by `describe-categories'.
8200
9778ebcc
EZ
8201 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8202 members before the level stack, so they would be saved and
8203 restored when copying iterator state. Fixes incorrect reordering
8204 around TABs covered by display properties.
8205
156bffbe
AS
82062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8207
6b02f655 8208 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8209
72ad093b
CY
82102011-08-17 Chong Yidong <cyd@stupidchicken.com>
8211
8212 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8213 (internal_condition_case_2, internal_condition_case_n):
8214 Remove unnecessary aborts (Bug#9081).
72ad093b 8215
35774242
EZ
82162011-08-17 Eli Zaretskii <eliz@gnu.org>
8217
8218 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8219 has no `load' handler, try opening the file locally. (Bug#9311)
8220
db76dd85
KB
82212011-08-16 Ken Brown <kbrown@cornell.edu>
8222
8223 * gmalloc.c: Expand comment.
8224
b215eee5
EZ
82252011-08-16 Eli Zaretskii <eliz@gnu.org>
8226
8227 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8228 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8229
a4579d33
KB
82302011-08-16 Ken Brown <kbrown@cornell.edu>
8231
8232 Fix memory allocation problems in Cygwin build (Bug#9273).
8233
8234 * unexcw.c ( __malloc_initialized): Declare external variable.
8235 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8236
8b76d6f8
SM
8237 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8238 New variables.
a4579d33
KB
8239 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8240 dumped emacs.
8241 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8242 in the static heap.
8243 [CYGWIN] (special_realloc): New function.
8244 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8245 requests to realloc storage in the static heap.
8246
3ebec551
PE
82472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8248
8249 * bidi.c (bidi_initialize): Remove unused local.
8250
9fd8be00
EZ
82512011-08-15 Eli Zaretskii <eliz@gnu.org>
8252
6b02f655
SM
8253 * bidimirror.h:
8254 * biditype.h: Remove file.
8255 * makefile.w32-in ($(BLD)/bidi.$(O)):
8256 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8257
8258 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8259
8260 * chartab.c: Improve commentary for the uniprop_table API.
8261
32413314
EZ
8262 * bidi.c (bidi_paragraph_init): Support zero value of
8263 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8264 (bidi_initialize): Use uniprop_table instead of including
8265 biditype.h and bidimirror.h.
32413314 8266
9fd8be00
EZ
8267 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8268 coordinates of the iterator when restoring from ppos_it.
8269 (Bug#9296)
8270
5cf2b69b
KH
82712011-08-14 Kenichi Handa <handa@m17n.org>
8272
8273 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8274 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8275
daf17d00
EZ
82762011-08-14 Eli Zaretskii <eliz@gnu.org>
8277
8278 * xdisp.c (move_it_in_display_line_to): Don't invoke
8279 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8280 ppos_it. Fixes vertical cursor motion when line beginning is
8281 covered by an image. (Bug#9296)
8282
08e3161a
JD
82832011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8284
8285 * nsterm.h (ns_run_ascript): Declare.
8286 (NSAPP_DATA2_RUNASSCRIPT): Define.
8287
8288 * nsfns.m (as_script, as_result, as_status): New static variables.
8289 (ns_run_ascript): New function.
5e617bc2 8290 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8291 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8292 the event loop. Get status from as_status (Bug#7276).
8293
8294 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8295 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8296 the event loop (Bug#7276).
8297
a3720aa2
AS
82982011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8299
8300 * gnutls.c (QCgnutls_bootprop_priority)
8301 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8302 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8303 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8304 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8305 (QCgnutls_bootprop_verify_hostname_error)
8306 (QCgnutls_bootprop_callbacks_verify): Rename from
8307 Qgnutls_bootprop_..., all uses changed.
8308
8309 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8310 uses changed.
8311
0a0d27fb
PE
83122011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8313
19d5c50c
PE
8314 * xfaces.c (Qframe_set_background_mode): Now static.
8315 * dispextern.h (Qframe_set_background_mode): Remove decl.
8316
0a0d27fb
PE
8317 * process.c (Fnetwork_interface_info): Declare local only if needed.
8318
377538cb
JD
83192011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8320
8321 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8322 (Fnetwork_interface_list): Allocate in increments of bytes instead
8323 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8324 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8325 sockaddr.
8326 (struct ifflag_def): notrailers is smart on OSX.
8327 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8328 Get hardware address with getifaddrs if available.
8329
08fff70c
EZ
83302011-08-12 Eli Zaretskii <eliz@gnu.org>
8331
8332 * xdisp.c (iterate_out_of_display_property): xassert that
8333 IT->position is set to within IT->object's boundaries. Break from
8334 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8335 when IT->position is set up wrongly due to some bug.
8336 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8337 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8338 entry. Force push_it to save on the stack the current
8339 buffer/string position, to be restored by pop_it. Fix flags in
8340 the iterator structure wrt the object coming from a display
8341 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8342 properties. (Bug#9284)
8343
7be1c708 83442011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8345
7be1c708
CY
8346 * fontset.c (fontset_get_font_group): Add proper type checks.
8347 (Bug#9172)
aac0c6e3 8348
7be1c708 83492011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8350
7be1c708
CY
8351 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8352 and LC_VERSION_MIN_MACOSX.
8353 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8354 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8355
97bb72a6
EZ
83562011-08-08 Eli Zaretskii <eliz@gnu.org>
8357
8358 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8359 no-display-properties-and-no-overlays under bidi display.
8360 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8361 properties and overlays.
97bb72a6 8362
d5617611
CY
83632011-08-08 Chong Yidong <cyd@stupidchicken.com>
8364
37e11a63
CY
8365 * editfns.c (Fset_time_zone_rule): Document relationship with the
8366 setenv function.
8367
d5617611
CY
8368 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8369 the font entity extracted from the cache (Bug#8109).
8370
58872834
CY
83712011-08-07 Chong Yidong <cyd@stupidchicken.com>
8372
8373 * composite.c (autocmp_chars): Don't reset point. That is done by
8374 restore_point_unwind (Bug#5984).
8375
75bfc667
JL
83762011-08-07 Juri Linkov <juri@jurta.org>
8377
8378 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8379 to show the arg `TIME' instead of `TIMEVAL'.
8380
d1410150
EZ
83812011-08-06 Eli Zaretskii <eliz@gnu.org>
8382
8383 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8384 display property strides EOL and includes a newline, as in
8385 longlines-mode. (Bug#9254)
75b771e4
EZ
8386 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8387 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8388
8389 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8390 is non-zero, even if the data buffer is NULL. Fixes a crash in
8391 vertical-motion with longlines-mode. (Bug#9254)
8392
35928349
EZ
83932011-08-05 Eli Zaretskii <eliz@gnu.org>
8394
ec7cc85b
EZ
8395 * bidi.c <bidi_cache_total_alloc>: Now static.
8396 (bidi_initialize): Initialize bidi_cache_total_alloc.
8397
8b76d6f8 8398 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8399 cache. (Bug#9221)
8400
8401 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8402 amount allocated this far in `bidi_cache_total_alloc'.
8403 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8404 non-zero, only free the data buffer without restoring the cache
8405 contents. All callers changed.
8406
8407 * dispextern.h (bidi_unshelve_cache): Update prototype.
8408
8409 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8410 (move_it_in_display_line, move_it_to)
8411 (move_it_vertically_backward, move_it_by_lines): Replace the call
8412 to xfree to an equivalent call to bidi_unshelve_cache.
8413 (move_it_in_display_line_to): Fix logic of returning
412b6358 8414 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8415
e2e2423b
EZ
84162011-08-05 Eli Zaretskii <eliz@gnu.org>
8417
8418 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8419 came from a string character with a `cursor' property. (Bug#9229)
8420
ae9e757a
JD
84212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8422
8423 * Makefile.in (LIB_PTHREAD): New variable.
8424 (LIBES): Add LIB_PTHREAD (Bug#9216).
8425
8426 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8427 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8428
213bd7f2
AS
84292011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8430
6b02f655 8431 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8432
99aaf75f
JD
84332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8434
8435 * xterm.c (x_find_topmost_parent): New function.
8436 (x_set_frame_alpha): Find topmost parent window with
8437 x_find_topmost_parent and set the property there also (bug#9181).
8438 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8439
c74e9d86
PE
84402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8441
8442 * callproc.c (Fcall_process): Avoid vfork clobbering
8443 the local vars buffer, coding_systems, current_dir.
8444
640c8776
SM
84452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8446
8447 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8448
f26d0e4c
PE
84492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8450
8a10d76c
PE
8451 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8452 so that it is not optimized away.
8453
f26d0e4c
PE
8454 * xdisp.c (compute_display_string_pos): Remove unused local.
8455
55439c61
EZ
84562011-08-02 Eli Zaretskii <eliz@gnu.org>
8457
8458 Fix slow cursor motion and scrolling in large buffers with
8459 selective display, like Org Mode buffers. (Bug#9218)
8460
8461 * dispextern.h (struct bidi_it): New member disp_prop_p.
8462
8463 * xdisp.c: Remove one-slot cache of display string positions.
8464 (compute_display_string_pos): Accept an additional argument
5e617bc2 8465 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8466 for a display string or property. If found, set DISP_PROP_P
8467 non-zero.
8468
8469 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8470 DISP_PROP_P, and pass it to compute_display_string_pos.
8471 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8472 non-zero. All callers of bidi_fetch_char changed.
8473
fb33fa43
SM
84742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8475
8476 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8477
b099e063
DM
84782010-12-03 Don March <don@ohspite.net>
8479
8480 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8481 last character M-[char] is translated to ESC [char] (bug#7541).
8482
5cc7f7af
KH
84832011-08-02 Kenichi Handa <handa@m17n.org>
8484
d0fffa3f 8485 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8486
8487 * chartab.c (uniprop_table): Make it non-static.
8488
525d5e6e
EZ
84892011-08-01 Eli Zaretskii <eliz@gnu.org>
8490
8491 * xdisp.c (forward_to_next_line_start): Accept additional argument
8492 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8493 on the newline.
8494 (reseat_at_next_visible_line_start): Use the bidi iterator state
8495 returned by forward_to_next_line_start to restore the state of
8496 it->bidi_it after backing up to previous newline. (Bug#9212)
8497
31011111
AS
84982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8499
8500 * regex.c (re_comp): Protoize.
8501 (re_exec): Fix return type.
8502 (regexec): Fix type of `ret'. (Bug#9203)
8503
476371c4
PE
85042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8505
e5d76069
PE
8506 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8507 This is needed if max-image-size is a floating-point number.
8508
9a79b20c
AS
85092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8510
8511 * print.c (print_object): Print empty symbol as ##.
8512
8513 * lread.c (read1): Read ## as empty symbol.
8514
d8c2fa78
AA
85152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8516
8517 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8518 setting frame foreground color (Bug#9175).
8519 (x_set_background_color): Likewise.
8520
ffe57a7a
AA
8521 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8522 contents (Bug#9176).
8523 (EmacsTooltip -init): Remove bezels and add shadows to
8524 tooltip windows.
8525
bf3492a5
AA
8526 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8527 or scroll bar (Bug#8470).
8528
d55e9c53
AA
8529 * nsfont.m (nsfont_open): Remove assignment to voffset and
8530 unnecessary vars hshink, expand, hd, full_height, min_height.
8531 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8532
8533 * nsterm.h (nsfont_info): Remove voffset field.
8534
d8c2fa78 85352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8536
8537 Implement strike-through and overline on NextStep (Bug#8863).
8538
8539 * nsfont.m (nsfont_open): Use underline position provided by font,
8540 instead of hard-coded value of 2.
8541 (nsfont_draw): Call ns_draw_text_decoration instead.
8542
8543 * nsterm.h: Add declaration for ns_draw_text_decoration.
8544
8545 * nsterm.m (ns_draw_text_decoration): New function for drawing
8546 underline, overline, and strike-through.
8547 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8548 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8549 accommodate underlining, etc.
4843aac3 8550
4cc60b9b
EZ
85512011-07-28 Eli Zaretskii <eliz@gnu.org>
8552
bc7ece87
EZ
8553 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8554 default.
4cc60b9b 8555
476371c4
PE
85562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8557
66606eea
PE
8558 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8559 Without this fix, if a signal arrives just after memory fills up,
8560 'malloc' might be invoked reentrantly.
8561
476371c4
PE
8562 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8563 In other words, assume that every image size is allowed, on non-X
8564 hosts. This assumption is probably wrong, but it lets Emacs compile.
8565
f3fcc40d
AS
85662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8567
8568 * regex.c (re_iswctype): Convert return values to boolean.
8569
350c992f
EZ
85702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8571
8572 * xdisp.c (compute_display_string_pos): Don't use cached display
8573 string position if the buffer had its restriction changed.
8574 (Bug#9184)
8575
5266b4bb
PE
85762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8577
8578 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8579
2573a837 85802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8581
41f55ccd 8582 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8583
39e378da
PE
8584 * bidi.c: Integer size and overflow fixes.
8585 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8586 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8587 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8588 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8589 (bidi_find_other_level_edge):
8590 Use ptrdiff_t instead of EMACS_INT where either will do.
8591 This works better on 32-bit hosts configured --with-wide-int.
8592 (bidi_cache_ensure_space): Check for size-calculation overflow.
8593 Use % rather than repeated addition, for better worst-case speed.
8594 Don't set bidi_cache_size until after xrealloc returns, because it
8595 might not return.
8596 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8597 (bidi_cache_ensure_space): Also check that the bidi cache size
8598 does not exceed that of the largest Lisp string or buffer. See Eli
8599 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8600
5e927815
PE
8601 * alloc.c (__malloc_size_t): Remove.
8602 All uses replaced by size_t. See Andreas Schwab's note
8603 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8604
ca4aa935
PE
8605 * image.c: Improve checking for integer overflow.
8606 (check_image_size): Assume that f is nonnull, since
8607 it is always nonnull in practice. This is one less thing to
8608 worry about when checking for integer overflow later.
8609 (x_check_image_size): New function, which checks for integer
8610 overflow issues inside X.
8611 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8612 This removes the need for a memory_full check.
8613 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8614 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8615 (xbm_read_bitmap_data): Change locals back to 'int', since
8616 their values must fit in 'int'.
8617 (xpm_load_image, png_load, tiff_load):
8618 Invoke x_create_x_image_and_pixmap earlier,
8619 to avoid much needless work if the image is too large.
8620 (tiff_load): Treat overly large images as if
8621 x_create_x_image_and_pixmap failed, not as malloc failures.
8622 (gs_load): Use x_check_image_size.
8623
5f8f9cc2
PE
8624 * gtkutil.c: Omit integer casts.
8625 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8626 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8627
5adf60bc
PE
8628 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8629
c8907a93
PE
8630 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8631 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8632 would wrongly return t on a 64-bit host.
8633
e3c25c68
PE
8634 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8635 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8636 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8637 and therefore cause GCC to emit a bogus diagnostic in some cases.
8638
3f791afe
PE
8639 * image.c: Integer signedness and overflow and related fixes.
8640 This is not an exhaustive set of fixes, but it's time to
8641 record what I've got.
8642 (lookup_pixel_color, check_image_size): Remove redundant decls.
8643 (check_image_size): Don't assume that arbitrary EMACS_INT values
8644 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8645 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8646 (tiff_load, imagemagick_load_image):
8647 Check for overflow in size calculations.
8648 (x_create_x_image_and_pixmap): Remove unnecessary test for
8649 xmalloc returning NULL; that can't happen.
8650 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8651 (xpm_color_bucket): Use better integer hashing function.
8652 (xpm_cache_color): Don't possibly over-allocate memory.
8653 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8654 (gif_memory_source):
8655 Use ptrdiff_t, not int or size_t, to record sizes.
8656 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8657 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8658 either works, as we prefer signed integers.
8659 (tiff_read_from_memory, tiff_write_from_memory):
8660 Return tsize_t, not size_t, since that's what the TIFF API wants.
8661 (tiff_read_from_memory): Don't fail simply because the read would
8662 go past EOF; instead, return a short read.
8663 (tiff_load): Omit no-longer-needed casts.
8664 (Fimagemagick_types): Don't assume size fits into 'int'.
8665
3cc5a532
PE
8666 Improve hashing quality when configured --with-wide-int.
8667 * fns.c (hash_string): New function, taken from sxhash_string.
8668 Do not discard information about ASCII character case; this
8669 discarding is no longer needed.
8670 (sxhash-string): Use it. Change sig to match it. Caller changed.
8671 * lisp.h: Declare it.
8672 * lread.c (hash_string): Remove, since we now use fns.c's version.
8673 The fns.c version returns a wider integer if --with-wide-int is
8674 specified, so this should help the quality of the hashing a bit.
8675
b312a492
PE
8676 * emacs.c: Integer overflow minor fix.
8677 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8678 Define only if GNU_LINUX.
8679 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8680
dfd153ae
PE
8681 * dispnew.c: Integer signedness and overflow fixes.
8682 Remove unnecessary forward decls, that were a maintenance hassle.
8683 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8684 All uses changed.
8685 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8686 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8687 (prepare_desired_row, line_draw_cost):
8688 Use int, not unsigned, where either works.
8689 (save_current_matrix, restore_current_matrix):
8690 Use ptrdiff_t, not size_t, where either works.
8691 (init_display): Check for overflow more accurately, and without
8692 relying on undefined behavior.
8693
a81d11a3
PE
8694 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8695 Remove, replacing with the new symbols in lisp.h. All uses changed.
8696 * fileio.c (make_temp_name):
8697 * filelock.c (lock_file_1, lock_file):
8698 * xdisp.c (message_dolog):
8699 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8700 Use pMd etc. instead.
8701 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8702 replacing the pWIDE etc. symbols removed from editfns.c.
8703
3300e6fd
PE
8704 * keyboard.h (num_input_events): Now uintmax_t.
8705 This is (very slightly) less likely to mess up due to wraparound.
8706 All uses changed.
8707
fd05c7e9
PE
8708 * buffer.c: Integer signedness fixes.
8709 (alloc_buffer_text, enlarge_buffer_text):
8710 Use ptrdiff_t rather than size_t when either will do, as we prefer
8711 signed integers.
8712
903fe15d
PE
8713 * alloc.c: Integer signedness and overflow fixes.
8714 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8715 (__malloc_size_t): Default to size_t, not to int.
8716 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8717 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8718 Prefer ptrdiff_t to size_t when either would do, as we prefer
8719 signed integers.
8720 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8721 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8722 Now const. Initialize with values that are in range even if char
8723 is signed.
8724 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8725 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8726 These functions do the right thing with sizes > 2**32.
8727 (check_depth): Now ptrdiff_t, not int.
8728 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8729 Adjust to new way of storing sizes. Check for size overflow bugs
8730 in rest of code.
8731 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8732 slightly wrong anyway, as it missed one instance of
8733 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8734 (refill_memory_reserve): Omit needless cast to size_t.
8735 (mark_object_loop_halt): Mark as externally visible.
8736
ac82cc6a
PE
8737 * xselect.c: Integer signedness and overflow fixes.
8738 (Fx_register_dnd_atom, x_handle_dnd_message):
8739 Use ptrdiff_t, not size_t, since we prefer signed.
8740 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8741 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8742 x_dnd_atoms_size and x_dnd_atoms_length.
8743
c2d1e36d
PE
8744 * doprnt.c: Prefer signed to unsigned when either works.
8745 * eval.c (verror):
8746 * doprnt.c (doprnt):
8747 * lisp.h (doprnt):
8748 * xdisp.c (vmessage):
8749 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8750 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8751 prefer signed arithmetic to avoid comparison confusion.
8752 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8753 but is a bit tricky.
8754
0e926e56
PE
8755 Assume freestanding C89 headers, string.h, stdlib.h.
8756 * data.c, doprnt.c, floatfns.c, print.c:
8757 Include float.h unconditionally.
8758 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8759 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8760 * regex.c: Likewise for stddef.h, string.h.
8761 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8762 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8763 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8764 (STDC_HEADERS): Remove obsolete defines.
8765 * sysdep.c: Include limits.h unconditionally.
8766
9cfdb3ec
PE
8767 Assume support for memcmp, memcpy, memmove, memset.
8768 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8769 * regex.c (memcmp, memcpy):
8770 Remove; we assume C89 now.
8771
8772 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8773 (__malloc_safe_bcopy): Remove; no longer needed.
8774
cf950e6b 8775 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8776 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8777 well either way, and we prefer signed to unsigned.
8778
dbf38e02
LMI
87792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8780
8781 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8782 closes the connection while we're reading (bug#9182).
8783
d6f0886c 87842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8785
d6f0886c
JD
8786 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8787 are specified (Bug#9168).
24e0f6b1 8788
2eb1f9e6
PE
87892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8790
8791 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8792 Found by GCC static checking and --with-wide-int on a 32-bit host.
8793
22381272 87942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8795
8796 * xdisp.c (compute_display_string_pos): Fix logic of caching
8797 previous display string position. Initialize cached_prev_pos to
8798 -1. Fixes slow-down at the beginning of a buffer.
8799
f25e39b4
EZ
88002011-07-24 Eli Zaretskii <eliz@gnu.org>
8801
8802 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8803 for attrs[LFACE_FONTSET_INDEX].
8804
04c4b52e
PE
88052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8806
8807 * xml.c (parse_region): Remove unused local
8808 that was recently introduced.
8809
c1734fbd
EZ
88102011-07-23 Eli Zaretskii <eliz@gnu.org>
8811
be18c5a5
EZ
8812 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8813 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8814
c1734fbd
EZ
8815 * xdisp.c (move_it_in_display_line_to): Record the best matching
8816 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8817 exit if none of the characters scanned was an exact match.
8818 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8819 when exact match is impossible due to invisible text, and the
8820 lines are truncated.
8821
a258d627
JD
88222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8823
8824 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8825 for OSX >= 10.7.
8826
b6d5a689
EZ
88272011-07-22 Eli Zaretskii <eliz@gnu.org>
8828
0f74f785
EZ
8829 Fix a significant slow-down of cursor motion with C-n, C-p,
8830 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8831 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8832 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8833 (next_element_from_buffer): Call compute_stop_pos_backwards to
8834 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8835 base_level_stop.
8836 (reseat): Don't look for prev_stop, as that could mean a very long
8837 run.
8838 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8839 <cached_disp_overlay_modiff>: Cache for last found display string
8840 position.
551918c1 8841 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8842 about the same buffer in the same area of character positions, and
8843 the buffer wasn't changed since the time the display string
8844 position was cached.
551918c1 8845
b2d0c91a
EZ
88462011-07-22 Eli Zaretskii <eliz@gnu.org>
8847
8848 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8849 is an integer, which is important for empty lines. (Bug#9149)
8850
043604ee
CY
88512011-07-22 Chong Yidong <cyd@stupidchicken.com>
8852
8853 * frame.c (Fmodify_frame_parameters): In tty case, update the
8854 default face if necessary (Bug#4238).
8855
da4adb04
CY
88562011-07-21 Chong Yidong <cyd@stupidchicken.com>
8857
8858 * editfns.c (Fstring_to_char): No need to explain what a character
8859 is in the docstring (Bug#6576).
8860
9abd0532
LMI
88612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8862
8863 * xml.c (parse_region): Make sure we always return a tree.
8864
36881d16
HK
88652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8866
8867 * xml.c (parse_region): If a document contains only comments,
8868 return that, too.
8869
1e98674d
LMI
88702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8871
8872 * xml.c (make_dom): Return comments, too.
8873
590bd467
PE
88742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8875
8876 Port to OpenBSD.
8877 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8878 and the surrounding thread.
8879 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8880 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8881 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8882 timer goes off.
8883 * s/openbsd.h (BROKEN_SIGIO): Define.
8884 * unexelf.c (unexec) [__OpenBSD__]:
8885 Don't update the .mdebug section of the Alpha COFF symbol table.
8886
f41628b2
LMI
88872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
8889 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8890 (bug#8460).
8891
b59b67c5
PE
88922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8893
15e3a074
PE
8894 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8895 This fixes some race conditions on the permissions of any newly
8896 created file.
8897
41bed37d
PE
8898 * alloc.c (valid_pointer_p): Use pipe, not open.
8899 This fixes some permissions issues when debugging.
8900
b59b67c5
PE
8901 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8902 If fchown fails to set both uid and gid, try to set just gid,
8903 as that is sometimes allowed. Adjust the file's mode to eliminate
8904 setuid or setgid bits that are inappropriate if fchown fails.
8905
925a6be7
SM
89062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8907
8908 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8909 to compare Lisp_Objects.
8910 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8911 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8912 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8913
52968808
AS
89142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8915
0a6a104b
AS
8916 * lread.c (read_integer): Unread even EOF character.
8917 (read1): Likewise. Properly record start position of symbol.
8918
52968808
AS
8919 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8920 symbol character follows.
8921
9e381cdd
PE
89222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8923
8924 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8925 This works around a problem with the previous change to Fcopy_file.
8926 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8927 and without this change, GCC might complain about discarding
8928 fchown's return value.
8929
b5641435
JB
89302011-07-16 Juanma Barranquero <lekktu@gmail.com>
8931
8932 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8933
a8031457
PE
89342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8935
8936 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8937
dd889327
LMI
89382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8939
750c33f7
LMI
8940 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8941 it's used from the C level.
8942
dd889327
LMI
8943 * process.c: Use the same condition for POLL_FOR_INPUT in both
8944 keyboard.c and process.c (bug#1858).
8945
87e86684
LM
89462011-07-09 Lawrence Mitchell <wence@gmx.li>
8947
8948 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8949 (Fgnutls_boot): Use it.
8950
64348f40
AS
89512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8952
8953 * doc.c (Fsubstitute_command_keys): Revert last change.
8954
1d698799
LMI
89552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8956
f863868c
LMI
8957 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8958 quotes the next character, and doesn't affect other longer
8959 sequences (bug#8935).
8960
1d698799
LMI
8961 * lread.c (syms_of_lread): Clarify that is isn't only
8962 `eval-buffer' and `eval-defun' that's affected by
8963 `lexical-binding' (bug#8460).
8964
aa4b6df6
EZ
89652011-07-15 Eli Zaretskii <eliz@gnu.org>
8966
8967 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8968 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8969
5d856da6
PE
89702011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8971
ad6042bb
PE
8972 Fix minor problems found by static checking.
8973 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8974 (elsz): Now a signed constant, not a size_t var. We prefer signed
8975 types to unsigned, to avoid integer comparison confusion. Without
8976 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8977 "cannot optimize loop, the loop counter may overflow", a symptom
8978 of the confusion.
f00bbb22 8979 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8980 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8981
6468f31c
LMI
89822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8983
49080b10
LMI
8984 * search.c (Fre_search_backward): Mention `case-fold-search' in
8985 all the re_search_* functions (bug#8138).
8986
6468f31c
LMI
8987 * keyboard.c (Fopen_dribble_file): Document when the file is
8988 closed (bug#8056).
8989
c965adc5
EZ
89902011-07-14 Eli Zaretskii <eliz@gnu.org>
8991
df9733bf
EZ
8992 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8993 bidi_cache_idx.
8994
0bb23927
EZ
8995 Support bidi reordering of display and overlay strings.
8996 * xdisp.c (compute_display_string_pos)
8997 (compute_display_string_end): Accept additional argument STRING.
8998 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8999 (reseat_to_string): Initialize bidi_it->string.s and
9000 bidi_it->string.schars.
9001 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9002 NULL (avoids a crash in bidi_paragraph_init).
9003 Initialize itb.string.lstring.
0bb23927
EZ
9004 (init_iterator): Call bidi_init_it only of a valid
9005 buffer position was specified. Initialize paragraph_embedding to
9006 L2R.
9007 (reseat_to_string): Initialize the bidi iterator.
9008 (display_string): If we need to ignore text properties of
9009 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9010 original value of -1 will not work with bidi.)
9011 (compute_display_string_pos): First arg is now struct
9012 `text_pos *'; all callers changed. Support display properties on
9013 Lisp strings.
9014 (compute_display_string_end): Support display properties on Lisp
9015 strings.
9016 (init_iterator, reseat_1, reseat_to_string): Initialize the
9017 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9018 when iterating on a string not from display properties).
640c8776
SM
9019 (compute_display_string_pos, compute_display_string_end):
9020 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9021 arrow keys.
9022 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9023 base_level_stop; instead, set base_level_stop to BEGV.
9024 Fixes crashes in vertical-motion.
0bb23927
EZ
9025 (next_element_from_buffer): Improve commentary for when
9026 the iterator is before prev_stop.
9027 (init_iterator): Initialize bidi_p from the default value of
9028 bidi-display-reordering, not from buffer-local value. Use the
9029 buffer-local value only if initializing for buffer iteration.
9030 (handle_invisible_prop): Support invisible properties on strings
9031 that are being bidi-reordered.
9032 (set_iterator_to_next): Support bidi reordering of C strings and
9033 Lisp strings.
9034 (next_element_from_string): Support bidi reordering of Lisp
9035 strings.
9036 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9037 (display_string): Support display of R2L glyph rows.
9038 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9039 (init_iterator): Don't initialize it->bidi_p for strings
9040 here.
9041 (reseat_to_string): Initialize it->bidi_p for strings here.
9042 (next_element_from_string, next_element_from_c_string)
9043 (next_element_from_buffer): Add xassert's for correspondence
9044 between IT's object being iterated and it->bidi_it.string
9045 structure.
9046 (face_before_or_after_it_pos): Support bidi iteration.
9047 (next_element_from_c_string): Handle the case of the first string
9048 character that is not the first one in the visual order.
9049 (get_visually_first_element): New function, refactored from common
9050 parts of next_element_from_buffer, next_element_from_string, and
9051 next_element_from_c_string.
9052 (tool_bar_lines_needed, redisplay_tool_bar)
9053 (display_menu_bar): Force left-to-right direction. Add a FIXME
9054 comment for making that be controlled by a user option.
9055 (push_it, pop_it): Save and restore the state of the
9056 bidi iterator. Save and restore the bidi_p flag.
9057 (pop_it): Iterate out of display property for string iteration as
9058 well.
9059 (iterate_out_of_display_property): Support iteration over strings.
9060 (handle_single_display_spec): Set up it->bidi_it for iteration
9061 over a display string, and call bidi_init_it.
9062 (handle_single_display_spec, next_overlay_string)
9063 (get_overlay_strings_1, push_display_prop): Set up the bidi
9064 iterator for displaying display or overlay strings.
9065 (forward_to_next_line_start): Don't use the shortcut if
9066 bidi-iterating.
9067 (back_to_previous_visible_line_start): If handle_display_prop
9068 pushed the iterator stack, restore the internal state of the bidi
9069 iterator by calling bidi_pop_it same number of times.
9070 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9071 and we are bidi-iterating, don't decrement the iterator position;
9072 instead, set the first_elt flag in the bidi iterator, to produce
9073 the same effect.
9074 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9075 (push_display_prop): xassert that we are iterating a buffer.
9076 (push_it, pop_it): Save and restore paragraph_embedding member.
9077 (handle_single_display_spec, next_overlay_string)
9078 (get_overlay_strings_1, reseat_1, reseat_to_string)
9079 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9080 correctly. Don't assume unibyte strings are not bidi-reordered.
9081 (compute_display_string_pos)
9082 (compute_display_string_end): Fix handling the case of C string.
9083 (push_it, pop_it): Save and restore from_disp_prop_p.
9084 (handle_single_display_spec, push_display_prop): Set the
9085 from_disp_prop_p flag.
9086 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9087 (pop_it): Call iterate_out_of_display_property only if we are
9088 popping after iteration over a string that came from a display
9089 property. Fix a typo in popping stretch info. Add an assertion
9090 for verifying that the iterator position is in sync with the bidi
9091 iterator.
9092 (handle_single_display_spec, get_overlay_strings_1)
9093 (push_display_prop): Fix initialization of paragraph direction for
9094 string when that of the parent object is not yet determined.
9095 (reseat_1): Call bidi_init_it to resync the bidi
9096 iterator with IT's position. (Bug#7616)
9097 (find_row_edges): If ROW->start.pos gives position
9098 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9099 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9100 Reset the from_disp_prop_p flag.
9101 (SAVE_IT, RESTORE_IT): New macros.
9102 (pos_visible_p, face_before_or_after_it_pos)
9103 (back_to_previous_visible_line_start)
9104 (move_it_in_display_line_to, move_it_in_display_line)
9105 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9106 (try_scrolling, redisplay_window, display_line): Use them when
9107 saving a temporary copy of the iterator and restoring it back.
9108 (back_to_previous_visible_line_start, reseat_1)
9109 (init_iterator): Empty the bidi cache "stack".
9110 (move_it_in_display_line_to): If iterator ended up at
9111 EOL, but we never saw any buffer positions smaller than
9112 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9113 motion in bidi-reordered lines.
9114 (move_it_in_display_line_to): Record prev_method and prev_pos
9115 immediately before the call to set_iterator_to_next. Fixes cursor
9116 motion in bidi-reordered lines with stretch glyphs and strings
9117 displayed in margins. (Bug#8133) (Bug#8867)
9118 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9119 TO_CHARPOS.
640c8776
SM
9120 (pos_visible_p): Support positions in bidi-reordered lines.
9121 Save and restore bidi cache.
0bb23927
EZ
9122
9123 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9124 (bidi_paragraph_info): Delete unused struct.
9125 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9126 (bidi_cache_start): New variable.
9127 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9128 to zero.
9129 (bidi_cache_fetch_state, bidi_cache_search)
9130 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9131 (bidi_cache_find, bidi_peek_at_next_level)
9132 (bidi_level_of_next_char, bidi_find_other_level_edge)
9133 (bidi_move_to_visually_next): Compare cache index with
9134 bidi_cache_start rather than with zero.
9135 (bidi_fetch_char): Accept new argument STRING; all callers
9136 changed. Support iteration over a string. Support strings with
9137 display properties. Support unibyte strings. Fix the type of
9138 `len' according to what STRING_CHAR_AND_LENGTH expects.
9139 (bidi_paragraph_init, bidi_resolve_explicit_1)
9140 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9141 (bidi_level_of_next_char, bidi_move_to_visually_next):
9142 Support iteration over a string.
0bb23927
EZ
9143 (bidi_set_sor_type, bidi_resolve_explicit_1)
9144 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9145 can now be zero (for strings); special values 0 and -1 were
9146 changed to -1 and -2, respectively.
9147 (bidi_char_at_pos): New function.
9148 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9149 Call it instead of FETCH_MULTIBYTE_CHAR.
9150 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9151 initialized to valid values.
9152 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9153 values.
9154 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9155 the test for valid cached positions. Fix the logic for looking up
9156 the sentinel state in the cache. GCPRO the Lisp string we are
9157 iterating.
9158 (bidi_push_it, bidi_pop_it): New functions.
9159 (bidi_initialize): Initialize the bidi cache start stack pointer.
9160 (bidi_cache_ensure_space): New function, refactored from part of
9161 bidi_cache_iterator_state. Don't assume the required size is just
9162 one BIDI_CACHE_CHUNK away.
9163 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9164 (bidi_count_bytes, bidi_char_at_pos): New functions.
9165 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9166 always valid if bidi_cache_idx is valid.
9167 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9168 is valid if it's going to be used.
9169 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9170 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9171 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9172 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9173 (bidi_find_other_level_edge, bidi_cache_start_stack):
9174 All variables related to cache indices are now EMACS_INT.
c965adc5 9175
0bb23927
EZ
9176 * dispextern.h (struct bidi_string_data): New structure.
9177 (struct bidi_it): New member `string'. Make flag members be 1-bit
9178 fields, and put them last in the struct.
640c8776
SM
9179 (compute_display_string_pos, compute_display_string_end):
9180 Update prototypes.
0bb23927
EZ
9181 (bidi_push_it, bidi_pop_it): Add prototypes.
9182 (struct iterator_stack_entry): New members bidi_p,
9183 paragraph_embedding, and from_disp_prop_p.
9184 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9185 (bidi_shelve_cache, bidi_unshelve_cache):
9186 Declare prototypes.
0bb23927
EZ
9187
9188 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9189 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9190 and vector-like objects.
9191
9192 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9193 cache around display iteration.
9194
9195 * window.c (Fwindow_end, window_scroll_pixel_based)
9196 (displayed_window_lines, Frecenter): Save and restore the bidi
9197 cache around display iteration.
9198
3bbd2265
LMI
91992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9200
9201 * editfns.c (Fdelete_region): Clarify the use of the named
9202 parameters (bug#6788).
9203
adc47434
MR
92042011-07-14 Martin Rudalics <rudalics@gmx.at>
9205
9206 * indent.c (Fvertical_motion): Set and restore w->pointm when
9207 saving and restoring the window's buffer (Bug#9006).
9208
837c31f8
LMI
92092011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9210
9211 * editfns.c (Fstring_to_char): Clarify just what is returned
9212 (bug#6576). Text by Eli Zaretskii.
9213
ac389d0c
JB
92142011-07-13 Juanma Barranquero <lekktu@gmail.com>
9215
9216 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9217
0be0ce47
EZ
92182011-07-13 Eli Zaretskii <eliz@gnu.org>
9219
9220 * buffer.c (mmap_find): Fix a typo.
9221
cd18e7e3
JB
92222011-07-13 Johan Bockgård <bojohan@gnu.org>
9223
9224 Fix execution of x selection hooks.
9225 * xselect.c (Qx_lost_selection_functions)
9226 (Qx_sent_selection_functions): New vars.
9227 (syms_of_xselect): DEFSYM them.
9228 (x_handle_selection_request): Pass Qx_sent_selection_functions
9229 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9230 (x_handle_selection_clear,x_clear_frame_selections):
9231 Pass Qx_lost_selection_functions rather than
9232 Vx_lost_selection_functions to Frun_hook_with_args.
9233
47ea7f44
PE
92342011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9235
ac389d0c 9236 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9237 The old code sometimes used this field without initializing it.
9238
47ea7f44
PE
9239 * alloc.c (gc_sweep): Don't read past end of array.
9240 In theory, the old code could also have corrupted Emacs internals,
9241 though it'd be very unlikely.
9242
bc985c87
AS
92432011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9244
9245 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9246 argument. (Bug#4026)
bc985c87 9247
0cf34688
LMI
92482011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9249
b3dadd76
LMI
9250 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9251 key" (bug#4257).
9252
0cf34688
LMI
9253 * window.c (Fset_window_start): Doc fix (bug#4199).
9254 (Fset_window_hscroll): Ditto.
9255
270768cd
PE
92562011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9257
077e3dda 9258 Fix minor new problems caught by GCC 4.6.1.
270768cd 9259 * term.c (init_tty): Remove unused local.
490011a6 9260 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9261 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9262 not used otherwise.
270768cd 9263
b1f58454
CY
92642011-07-12 Chong Yidong <cyd@stupidchicken.com>
9265
9266 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9267
22b9578d
LMI
92682011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9269
6e70ab07
LMI
9270 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9271 are the mini-buffer and the echo area (bug#3320).
9272
22b9578d
LMI
9273 * term.c (init_tty): Remove support for supdup, c10 and perq
9274 terminals, which are no longer supported (bug#1482).
9275
8974cc9f
JB
92762011-07-10 Johan Bockgård <bojohan@gnu.org>
9277
9278 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9279
a560d974
JD
92802011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9281
9282 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9283 for non-popups (Bug#3642).
9284
1dae0f0a
AS
92852011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9286
268c2c36 9287 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9288 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9289 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9290 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9291 * data.c (fmod): Likewise.
9292 * dispnew.c (swap_glyphs_in_rows): Likewise.
9293 * emacs.c (memory_warning_signal): Likewise.
9294 * floatfns.c (float_error): Likewise.
9295 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9296 (otf_open, font_otf_capability, generate_otf_features)
9297 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9298 Likewise.
9299 * image.c (pbm_read_file): Likewise.
9300 * indent.c (string_display_width): Likewise.
9301 * intervals.c (check_for_interval, search_for_interval)
9302 (inc_interval_count, count_intervals, root_interval)
9303 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9304 * lread.c (defalias): Likewise.
268c2c36 9305 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9306 * regex.c (set_image_of_range_1, set_image_of_range)
9307 (regex_grow_registers): Likewise.
9308 * sysdep.c (strerror): Likewise.
9309 * termcap.c (valid_filename_p, tprint, main): Likewise.
9310 * tparam.c (main): Likewise.
9311 * unexhp9k800.c (run_time_remap, save_data_space)
9312 (update_file_ptrs, read_header, write_header, calculate_checksum)
9313 (copy_file, copy_rest, display_header): Likewise.
9314 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9315 Likewise.
9316 * xdisp.c (check_it): Likewise.
9317 * xfaces.c (register_color, unregister_color, unregister_colors):
9318 Likewise.
9319 * xfns.c (print_fontset_result): Likewise.
9320 * xrdb.c (member, fatal, main): Likewise.
9321
99033785
PE
93222011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9323
9324 Fix minor problems found by static checking (Bug#9031).
9325 * chartab.c (char_table_set_range, map_sub_char_table):
9326 Remove unused locals.
9327 (uniprop_table): Now static.
9328 * composite.c (_work_char): Remove unused static var.
9329
9cb2ac56
JB
93302011-07-09 Juanma Barranquero <lekktu@gmail.com>
9331
9332 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9333
f25661f0
JD
93342011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9335
9336 * gtkutil.c (qttip_cb): Remove code without function.
9337
8278c4fe
EZ
93382011-07-09 Eli Zaretskii <eliz@gnu.org>
9339
9340 * w32.c (pthread_sigmask): New stub.
9341
1692ae2d 93422011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9343
8a6ebd58 9344 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9345 sigprocmask is portable only for single-threaded applications, and
9346 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9347 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9348 (LIBES): Use it.
9349 * callproc.c (Fcall_process):
9350 * process.c (create_process):
9351 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9352 Use pthread_sigmask, not sigprocmask.
123403e4 9353
1b854618
JD
93542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9355
9356 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9357 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9358 wrong (Bug#8591).
9359
3fe4b549
JD
93602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9361
0ce7e563
JD
9362 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9363 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9364 (xg_hide_tooltip): Fix comment.
9365
3fe4b549
JD
9366 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9367 in registerServicesMenuSendTypes.
9368 (validRequestorForSendType): Don't check ns_return_types.
9369
9370 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9371 ns_return_type.
9372
5df75e47
JR
93732011-07-08 Jason Rumney <jasonr@gnu.org>
9374
22610910
JR
9375 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9376 SH_SHOW for hidden windows (Bug#5482).
9377
5df75e47
JR
9378 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9379 frame struct members of non-existent frames (Bug#6284).
9380
699c10bd
JD
93812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9382
4393663b
JD
9383 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9384 variable firstTime not needed on OSX >= 10.6.
9385 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9386 >= 10.5. Use setKnobProportion, setDoubleValue.
9387
9388 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9389 (MAC_OS_X_VERSION_10_5): Define if not defined.
9390 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9391 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9392 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9393
9394 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9395 cString and lossyCString on OSX >= 10.4.
4393663b 9396
58179cce 9397 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9398 sizeToFit on OSX >= 10.2.
9399
9400 * nsimage.m (allocInitFromFile): Don't use deprecated method
9401 bestRepresentationForDevice on OSX >= 10.6.
9402
9403 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9404 to avoid warning.
9405
9406 * emacs.c: Declare unexec_init_emacs_zone.
9407
a63e0781
JD
9408 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9409
699c10bd
JD
9410 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9411
9412 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9413 on svcsMenu (Bug#8842).
9414
9415 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9416 ns_return_types.
9417 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9418
9419 * nsterm.m (QUTF8_STRING): Declare.
9420 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9421 (validRequestorForSendType): Return type is (id).
9422 Change indexOfObjectIdenticalTo to indexOfObject.
9423 Check if we have local selection before returning self (Bug#8842).
9424 (writeSelectionToPasteboard): Put local selection into paste board
9425 if we have a local selection (Bug#8842).
9426 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9427
9428 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9429 (ns_get_local_selection): Declare.
9430
54e10184
LMI
94312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9432
9888ff71
LMI
9433 * keymap.c (describe_map_tree): Don't insert a double newline at
9434 the end of the buffer (bug#1169) and return whether we inserted
9435 something.
9436
54e10184
LMI
9437 * callint.c (Fcall_interactively): Change "reading args" to
9438 "providing args" to try to clarify what it does (bug#1010).
9439
15fa4783
KH
94402011-07-07 Kenichi Handa <handa@m17n.org>
9441
9442 * composite.c (composition_compute_stop_pos): Ignore a static
9443 composition starting before CHARPOS (Bug#8915).
9444
9445 * xdisp.c (handle_composition_prop): Likewise.
9446
a8815b00
EZ
94472011-07-07 Eli Zaretskii <eliz@gnu.org>
9448
9449 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9450 (Bug#9015)
9451
ef7b981d 94522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9453
9454 * character.h (unicode_category_t): New enum type.
9455
9456 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9457 (Qchar_code_property_table): New variable.
9458 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9459 (UNIPROP_COMPRESSED_FORM_P): New macros.
9460 (char_table_ascii): Uncompress the compressed values.
9461 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9462 Uncompress the compressed values.
ac389d0c 9463 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9464 (char_table_ref_and_range): Uncompress the compressed values.
9465 (sub_char_table_set): New arg is_uniprop. Callers changed.
9466 Uncompress the compressed values.
9467 (sub_char_table_set_range): Args changed. Callers changed.
9468 (char_table_set_range): Adjuted for the above change.
9469 (map_sub_char_table): Delete args default_val and parent. Add arg
9470 top. Give decoded values to a Lisp function.
640c8776 9471 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9472 values to a Lisp function. Gcpro more variables.
9473 (uniprop_table_uncompress)
9474 (uniprop_decode_value_run_length): New functions.
9475 (uniprop_decoder, uniprop_decoder_count): New variables.
9476 (uniprop_get_decoder, uniprop_encode_value_character)
9477 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9478 New functions.
9479 (uniprop_encoder, uniprop_encoder_count): New variables.
9480 (uniprop_get_encoder, uniprop_table)
9481 (Funicode_property_table_internal, Fget_unicode_property_internal)
9482 (Fput_unicode_property_internal): New functions.
9483 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9484 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9485 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9486 char-code-property-alist.
9487
640c8776 9488 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9489 Vunicode_category_table.
9490
640c8776 9491 * font.c (font_range): Adjust for the change of
c805dec0
KH
9492 Vunicode_category_table.
9493
76b397fb
DN
94942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9495
9496 * m/iris4d.h: Remove file, move contents ...
9497 * s/irix6-5.h: ... here.
9498
22b4128e
PE
94992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9500
9501 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9502 * alloc.c (mark_buffer):
9503 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9504 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9505 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9506 This isn't true in general, and it's particularly not true
9507 if Emacs is configured with --with-wide-int.
9508 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9509 New macros, used in the buffer.c change.
9510
869795d6
JD
95112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9512
9513 * xsettings.c: Use both GConf and GSettings if both are available.
9514 (store_config_changed_event): Add comment.
9515 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9516 (store_tool_bar_style_changed): New functions.
5e617bc2 9517 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9518 (struct xsettings): Move font inside HAVE_XFT.
9519 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9520 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9521 Move inside HAVE_XFT.
640c8776 9522 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9523 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9524 also.
9525 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9526 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9527 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9528 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9529 (parse_settings): Move check for font inside HAVE_XFT.
9530 (read_settings, apply_xft_settings): Add comment.
9531 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9532 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9533 call store_font_name_changed.
9534 (xft_settings_event): Add comment.
9535 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9536 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9537 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9538 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9539 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9540 (xsettings_get_system_font, xsettings_get_system_normal_font):
9541 Add comment.
869795d6 9542
d8ed26bd
PE
95432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9544
9545 Random fixes. E.g., (random) never returned negative values.
9546 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9547 subseconds part to the entropy, as that's a bit more random.
9548 Prefer signed to unsigned, since the signedness doesn't matter and
9549 in general we prefer signed. When given a limit, use a
9550 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9551 latter isn't right if USE_2_TAGS_FOR_INTS.
9552 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9553 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9554
cabf1cac
SM
95552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9556
9557 * textprop.c (text_property_stickiness):
9558 Obey Vtext_property_default_nonsticky.
9559 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9560 * w32fns.c (syms_of_w32fns):
9561 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9562
6e9b2be9
PE
95632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9564
9565 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9566 This is more efficient than Ffile_directory_p and avoids a minor race.
9567
90186c68
LMI
95682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9569
7c301272
LMI
9570 * buffer.c (Foverlay_put): Say what the return value is
9571 (bug#7835).
9572
c4f2d8d4
LMI
9573 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9574 is a directory before asking whether to use the file name
9575 (bug#7564).
ad637907
LMI
9576 (barf_or_query_if_file_exists): Make the "File is a directory"
9577 error be more correct.
c4f2d8d4 9578
90186c68
LMI
9579 * fns.c (Frequire): Remove the mention of the .gz files, since
9580 that's installation-specific, but keep the mention of
9581 `get-load-suffixes'.
9582
da64016e
PE
95832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9584
9585 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9586 Report string overflow if the output is too long.
9587
7d47b580
JB
95882011-07-04 Juanma Barranquero <lekktu@gmail.com>
9589
a555cb87
JB
9590 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9591 (syms_of_gnutls): Remove duplicate DEFSYM for
9592 Qgnutls_bootprop_verify_hostname_error, an error for
9593 Qgnutls_bootprop_verify_error (which is no longer used).
9594
7d47b580
JB
9595 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9596 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9597 Also (re)move comments that are misplaced or no longer relevant.
9598
1e49bfab
LMI
95992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9600
9601 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9602
1485f4c0
CY
96032011-07-03 Chong Yidong <cyd@stupidchicken.com>
9604
9605 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9606 and background color parameters if they have been changed.
9607
a9ab721e
LMI
96082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9609
9610 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9611
cf7cff57
PE
96122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9613
2e13213d
PE
9614 * xsettings.c (SYSTEM_FONT): Define only when used.
9615 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9616
cf7cff57
PE
9617 * keymap.c (access_keymap_1): Now static.
9618
7a8e04f7
CY
96192011-07-02 Chong Yidong <cyd@stupidchicken.com>
9620
9621 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9622 leave any prefix arg for the up event (Bug#1586).
9623
61352f62
LMI
96242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9625
69bb1ef7
LMI
9626 * lread.c (syms_of_lread): Mention single symbols defined by
9627 `defvar' or `defconst' (bug#7154).
9628
61352f62 9629 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9630 (Frequire): Mention get-load-suffixes.
61352f62 9631
28545e04
MR
96322011-07-02 Martin Rudalics <rudalics@gmx.at>
9633
9634 * window.h (window): Remove clone_number slot.
9635 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9636 Remove.
9637 (make_parent_window, make_window, saved_window)
9638 (Fset_window_configuration, save_window_save): Don't deal with
9639 clone numbers.
9640 * buffer.c (Qclone_number): Remove declaration.
9641 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9642
3349e122
SM
96432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9644
9645 Add multiple inheritance to keymaps.
9646 * keymap.c (Fmake_composed_keymap): New function.
9647 (Fset_keymap_parent): Simplify.
9648 (fix_submap_inheritance): Remove.
9649 (access_keymap_1): New function extracted from access_keymap to handle
9650 embedded parents and handle lists of maps.
9651 (access_keymap): Use it.
9652 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9653 (Fcopy_keymap): Handle embedded parents.
9654 (Fcommand_remapping, define_as_prefix): Simplify.
9655 (Fkey_binding): Simplify.
9656 (syms_of_keymap): Move minibuffer-local-completion-map,
9657 minibuffer-local-filename-completion-map,
9658 minibuffer-local-must-match-map, and
9659 minibuffer-local-filename-must-match-map to Elisp.
9660 (syms_of_keymap): Defsubr make-composed-keymap.
9661 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9662 (parse_menu_item): Trivial simplification.
9663
3279eb87
GM
96642011-07-01 Glenn Morris <rgm@gnu.org>
9665
9666 * Makefile.in (SETTINGS_LIBS): Fix typo.
9667
4550efdf
KI
96682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9669
9670 * coding.c (Fencode_coding_string): Record the last coding system
9671 used, as the function doc string says (bug#8738).
9672
0949d2b6
JD
96732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9674
9675 * xsettings.c (store_monospaced_changed): Take new font as arg and
9676 check for change against current_mono_font.
9677 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9678 (emacs_settings_constructor, emacs_settings_get_property)
9679 (emacs_settings_set_property, emacs_settings_class_init)
9680 (emacs_settings_init, gsettings_obj): Remove.
9681 (something_changedCB): New function for HAVE_GSETTINGS.
9682 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9683 with value as argument.
9684 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9685 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9686 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9687 "changed".
9688
9689 * xgselect.c: Add defined (HAVE_GSETTINGS).
9690 (xgselect_initialize): Ditto.
9691
9692 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9693 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9694 xg_select.
9695
bbc6b304
PE
96962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9697
9698 * eval.c (struct backtrace): Simplify and port the data structure.
9699 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9700 signed bit field, as this assumption is not portable and it makes
9701 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9702 "char debug_on_exit : 1" as this is not portable either; instead,
9703 use the portable "unsigned int debug_on_exit : 1". Remove unused
9704 member evalargs. Remove obsolete comments about cc bombing out.
9705
9851bfc5
JD
97062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9707
51bb811f 9708 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9709 Let HAVE_GSETTINGS override HAVE_GCONF.
9710 (store_monospaced_changed): New function.
9711 (EMACS_SETTINGS): A new type derived from GObject to handle
9712 GSettings notifications.
9713 (emacs_settings_constructor, emacs_settings_get_property)
9714 (emacs_settings_set_property, emacs_settings_class_init):
9715 New functions.
9716 (gsettings_client, gsettings_obj): New variables.
9717 (GSETTINGS_SCHEMA): New define.
9718 (something_changedCB): Call store_monospaced_changed.
9719 (init_gsettings): New function.
9720 (xsettings_initialize): Call init_gsettings.
9721 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9722 to NULL.
9723
640c8776 9724 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9725 GCONF_CFLAGS/LIBS.
9726
5386012d
MR
97272011-06-29 Martin Rudalics <rudalics@gmx.at>
9728
9729 * window.c (resize_root_window, grow_mini_window)
9730 (shrink_mini_window): Rename Qresize_root_window to
9731 Qwindow_resize_root_window and Qresize_root_window_vertically to
9732 Qwindow_resize_root_window_vertically.
9733
f13e0b08
PE
97342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9735
9736 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9737
94515237
JB
97382011-06-27 Juanma Barranquero <lekktu@gmail.com>
9739
9740 * makefile.w32-in: Redesign dependencies so they reflect more
9741 clearly which files are directly included by each source file,
9742 and not through other includes.
9743
e43b6e43
MR
97442011-06-27 Martin Rudalics <rudalics@gmx.at>
9745
9746 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9747 (sort_overlays, overlay_strings): When an overlay's clone number
9748 matches the window's clone number process the overlay even if
9749 the overlay's window property doesn't match the current window.
9750
d68443dc
MR
9751 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9752 (Fwindow_hchild): Rename to Fwindow_left_child.
9753 (Fwindow_next): Rename to Fwindow_next_sibling.
9754 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9755 (resize_window_check): Rename to window_resize_check.
9756 (resize_window_apply): Rename to window_resize_apply.
9757 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9758 (Fdelete_other_windows_internal, resize_frame_windows)
9759 (Fsplit_window_internal, Fdelete_window_internal)
9760 (grow_mini_window, shrink_mini_window)
9761 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9762
c7e73be5
JD
97632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9764
9765 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9766 (emacs_fixed_set_min_size): Remove.
9767 (emacs_fixed_new): Take frame as argument.
9768
9769 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9770 (_EmacsFixedPrivate): Remove minwidth/height.
9771 Add struct frame *f.
9772 (emacs_fixed_init): Initialize priv->f.
9773 (get_parent_class, emacs_fixed_set_min_size): Remove.
9774 (emacs_fixed_new): Set priv->f to argument.
9775 (emacs_fixed_get_preferred_width)
9776 (emacs_fixed_get_preferred_height): Use min_width/height from
9777 frames size_hint to set minimum and natural (Bug#8919).
9778 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9779 and use min_width/height from frames size_hint to set
9780 min_width/height (Bug#8919).
9781
9782 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9783 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9784 Fix indentation.
c7e73be5 9785
cf99dcf8
EZ
97862011-06-26 Eli Zaretskii <eliz@gnu.org>
9787
9788 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9789 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9790 called at ZV.
9791
029529ac
CY
97922011-06-26 Chong Yidong <cyd@stupidchicken.com>
9793
9794 * process.c (wait_reading_process_output): Bypass select if
9795 waiting for a cell while ignoring keyboard input, and input is
9796 pending. Suggested by Jan Djärv (Bug#8869).
9797
7a7ef429
PE
97982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9799
9800 Use gnulib's dup2 module instead of rolling our own.
9801 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9802
11fdef7d 98032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9804
9805 * dispnew.c (scrolling_window): Before scrolling, turn off a
9806 mouse-highlight in the window being scrolled.
9807
cd3520a4
JB
98082011-06-24 Juanma Barranquero <lekktu@gmail.com>
9809
9810 Move DEFSYM to lisp.h and use everywhere.
9811
9812 * character.h (DEFSYM): Move declaration...
9813 * lisp.h (DEFSYM): ...here.
9814
9815 * gnutls.c:
9816 * minibuf.c:
9817 * w32menu.c:
9818 * w32proc.c:
9819 * w32select.c: Don't include character.h.
9820
9821 * alloc.c (syms_of_alloc):
9822 * buffer.c (syms_of_buffer):
9823 * bytecode.c (syms_of_bytecode):
9824 * callint.c (syms_of_callint):
9825 * casefiddle.c (syms_of_casefiddle):
9826 * casetab.c (init_casetab_once):
9827 * category.c (init_category_once, syms_of_category):
9828 * ccl.c (syms_of_ccl):
9829 * cmds.c (syms_of_cmds):
9830 * composite.c (syms_of_composite):
9831 * dbusbind.c (syms_of_dbusbind):
9832 * dired.c (syms_of_dired):
9833 * dispnew.c (syms_of_display):
9834 * doc.c (syms_of_doc):
9835 * editfns.c (syms_of_editfns):
9836 * emacs.c (syms_of_emacs):
9837 * eval.c (syms_of_eval):
9838 * fileio.c (syms_of_fileio):
9839 * fns.c (syms_of_fns):
9840 * frame.c (syms_of_frame):
9841 * fringe.c (syms_of_fringe):
9842 * insdel.c (syms_of_insdel):
9843 * keymap.c (syms_of_keymap):
9844 * lread.c (init_obarray, syms_of_lread):
9845 * macros.c (syms_of_macros):
9846 * msdos.c (syms_of_msdos):
9847 * print.c (syms_of_print):
9848 * process.c (syms_of_process):
9849 * search.c (syms_of_search):
9850 * sound.c (syms_of_sound):
9851 * syntax.c (init_syntax_once, syms_of_syntax):
9852 * terminal.c (syms_of_terminal):
9853 * textprop.c (syms_of_textprop):
9854 * undo.c (syms_of_undo):
9855 * w32.c (globals_of_w32):
9856 * window.c (syms_of_window):
9857 * xdisp.c (syms_of_xdisp):
9858 * xfaces.c (syms_of_xfaces):
9859 * xfns.c (syms_of_xfns):
9860 * xmenu.c (syms_of_xmenu):
9861 * xsettings.c (syms_of_xsettings):
9862 * xterm.c (syms_of_xterm): Use DEFSYM.
9863
4228cf16
TZ
98642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9865
cd3520a4 9866 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9867
7fcccf1e
PE
98682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9869
7efb4e0e
PE
9870 Integer and buffer overflow fixes (Bug#8873).
9871
ff5844ad
PE
9872 * print.c (printchar, strout): Check for string overflow.
9873 (PRINTPREPARE, printchar, strout):
9874 Don't set size unless allocation succeeds.
9875
90532f02
PE
9876 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9877 for sizes. Check for string overflow more accurately.
9878 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9879
6d84508d
PE
9880 * macros.c: Integer and buffer overflow fixes.
9881 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9882 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9883 Use ptrdiff_t, not int, for sizes.
9884 Don't increment bufsize until after realloc succeeds.
9885 Check for size-calculation overflow.
9886 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9887
437b2cb4
PE
9888 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9889
8b9ac8b4
PE
9890 * lread.c: Integer overflow fixes.
9891 (read_integer): Radix is now EMACS_INT, not int,
9892 to improve quality of diagnostics for out-of-range radices.
9893 Calculate buffer size correctly for out-of-range radices.
9894 (read1): Check for integer overflow in radices, and in
9895 read-circle numbers.
82cb60d3
PE
9896 (read_escape): Avoid int overflow.
9897 (Fload, openp, read_buffer_size, read1)
9898 (substitute_object_recurse, read_vector, read_list, map_obarray):
9899 Use ptrdiff_t, not int, for sizes.
9900 (read1): Use EMACS_INT, not int, for sizes.
20270765 9901 Check for size overflow.
8b9ac8b4 9902
7fcccf1e
PE
9903 * image.c (cache_image): Check for size arithmetic overflow.
9904
bfbbd7e7
PE
9905 * lread.c: Integer overflow issues.
9906 (saved_doc_string_size, saved_doc_string_length)
9907 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9908 Now ptrdiff_t, not int.
9909 (read1): Don't assume doc string length fits in int. Check for
9910 out-of-range doc string lengths.
9911 (read_list): Don't assume file position fits in int.
39019e54 9912 (read_escape): Check for hex character overflow.
bfbbd7e7 9913
4e323265
LL
99142011-06-22 Leo Liu <sdl.web@gmail.com>
9915
9916 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9917 Move to minibuffer.el.
9918
85fece3e
PE
99192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9920
20b84ce9 9921 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9922 The following patches are for when GLYPH_DEBUG && !XASSERT.
9923 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9924 * dispnew.c (flush_stdout):
9925 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9926 Mark as externally visible.
9927 * dispnew.c (check_window_matrix_pointers): Now static.
9928 * dispnew.c (window_to_frame_vpos):
9929 * xfns.c (unwind_create_frame):
9930 * xterm.c (x_check_font): Remove unused local.
9931 * scroll.c (CHECK_BOUNDS):
9932 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9933 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9934 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9935 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9936 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9937 Now static.
9938 (debug_method_add): Use va_list and vsprintf rather than relying
9939 on undefined behavior with wrong number of arguments.
9940 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9941 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9942 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9943 since we're not interested in debugging glyphs with old libraries.
9944 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9945 GCC 4.6.0's static checking.
9946
0766b489
PE
99472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9948
31fd4b32
PE
9949 Integer overflow and signedness fixes (Bug#8873).
9950 A few related buffer overrun fixes, too.
9951
b79e8648
PE
9952 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9953
0766b489
PE
9954 * dispextern.h (struct face.stipple):
9955 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9956 (x_bitmap_mask, x_allocate_bitmap_record)
9957 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9958 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9959 (x_create_bitmap_from_xpm_data):
9960 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9961 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9962 (.bitmaps_last):
9963 * xfaces.c (load_pixmap):
9964 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9965 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9966 (.bitmaps_last, struct x_output.icon_bitmap):
9967 Use ptrdiff_t, not int, for bitmap indexes.
9968 (x_allocate_bitmap_record): Check for size overflow.
9969 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9970
b081724f
PE
9971 Use ptrdiff_t, not int, for overlay counts.
9972 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9973 * editfns.c (overlays_around, get_pos_property):
9974 * textprop.c (get_char_property_and_overlay):
9975 * xdisp.c (next_overlay_change, note_mouse_highlight):
9976 * xfaces.c (face_at_buffer_position):
21514da7
PE
9977 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9978 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9979 (Fnext_overlay_change, Fprevious_overlay_change)
9980 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9981 Use ptrdiff_t, not int, for sizes.
21514da7 9982 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9983
3de73e5e
PE
9984 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9985
2606c57b
PE
9986 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9987 (x_session_initialize): Do not assume string length fits in int.
9988
aaafe47a
PE
9989 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9990 This is unlikely, but can occur if DPI is outlandish.
9991
2674ddc8 9992 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9993 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9994
28154962
PE
9995 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9996 * xrdb.c (magic_file_p, search_magic_path):
9997 Omit last arg SUFFIX; it was always 0. All callers changed.
9998 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9999
7de51af5
PE
10000 * xfont.c (xfont_match): Avoid need for strlen.
10001
25ed6cc3
PE
10002 * xfns.c: Don't assume strlen fits in int.
10003 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10004
4eab31dd
PE
10005 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10006 not unsigned long, as we prefer signed integers. All callers changed.
10007 Detect integer overflow in repeat count.
10008 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10009 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10010
171e2a58
PE
10011 * termcap.c: Don't assume sizes fit in int and never overflow.
10012 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10013 (gobble_line): Check for size-calculation overflow.
10014
ad39faca 10015 * minibuf.c (Fread_buffer):
6e5bb2dc 10016 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10017 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10018 Don't assume string length fits in int.
10019
52c61c22 10020 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10021 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10022
b5b8c9e5
PE
10023 * font.c: Don't assume string length fits in int.
10024 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10025 Use ptrdiff_t, not int.
ccd6111c
PE
10026 (font_intern_prop): Don't assume string length fits in int.
10027 Don't assume integer property fits in fixnum.
10028 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10029
882f0d81 10030 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10031 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10032 Reformulate so as not to need the command string.
10033 Invoke gzip -cd rather than gunzip, as it's more portable.
10034 (lock_info_type, lock_file_1, lock_file):
10035 Don't assume pid_t and time_t fit in unsigned long.
10036 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10037 (current_lock_owner): Prefer signed type for sizes.
10038 Use memcpy, not strncpy, where memcpy is what is really wanted.
10039 Don't assume (via atoi) that time_t and pid_t fit in int.
10040 Check for time_t and/or pid_t out of range, e.g., via a network share.
10041 Don't alloca where an auto var works fine.
10042
93f4cf88
PE
10043 * fileio.c: Fix some integer overflow issues.
10044 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10045 Don't assume string length fits in int.
10046 (directory_file_name): Don't assume string length fits in long.
10047 (make_temp_name): Don't assume pid fits in int, or that its print
10048 length is less than 20.
10049
f3e92b69
PE
10050 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10051
1bfdaf10
PE
10052 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10053
35016e9a
PE
10054 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10055
3d1e65a1
PE
10056 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10057 We prefer signed integers, even for size calculations.
10058
0b963a93
PE
10059 * emacs.c: Don't assume string length fits in 'int'.
10060 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10061 (main): Don't invoke strlen when not needed.
10062
573f4b54
PE
10063 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10064 (XD_DEBUG_MESSAGE): Don't waste a byte.
10065
989f33ba
PE
10066 * callproc.c (getenv_internal_1, getenv_internal)
10067 (Fgetenv_internal):
965d34eb
PE
10068 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10069
e4d29b33
PE
10070 * lread.c (invalid_syntax): Omit length argument.
10071 All uses changed. This doesn't fix a bug, but it simplifies the
10072 code away from its former Hollerith-constant appearance, and it's
10073 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10074 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10075
eb49b136
PE
10076 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10077 This didn't break anything, but it didn't help either.
10078 It's confusing to put a bogus integer in a place where the actual
10079 value does not matter.
9f62aeb1 10080 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10081 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10082
15375a22
PE
10083 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10084 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10085 implementation.
b61cc01c
PE
10086 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10087 We prefer signed types, and the value cannot exceed the EMACS_INT
10088 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10089 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10090 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10091 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10092
53b2623d
PE
10093 * indent.c (sane_tab_width): New function.
10094 (current_column, scan_for_column, Findent_to, position_indentation)
10095 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10096 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10097
51cab52b 10098 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10099
f2ed8a70
PE
10100 * lisp.h (lint_assume): New macro.
10101 * composite.c (composition_gstring_put_cache):
10102 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10103
abe80cc6
PE
10104 * editfns.c, insdel.c:
10105 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10106
b02c740e
PE
10107 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10108
ebc96716
PE
10109 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10110
b4e50fa0 10111 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10112 Use much-faster test for byte-length change.
311d5d7c 10113 Don't assume string byte-length fits in 'int'.
a4cf38e4 10114 Check that character arg fits in 'int'.
85461888 10115 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10116
c0c1ee9f
PE
10117 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10118
a498d7f4
PE
10119 * fns.c (concat): Catch string overflow earlier.
10120 Do not rely on integer wraparound.
10121
51cab52b
PE
10122 * dispextern.h (struct it.overlay_strings_charpos)
10123 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10124 * xdisp.c (forward_to_next_line_start)
10125 (back_to_previous_visible_line_start)
10126 (reseat_at_next_visible_line_start, next_element_from_buffer):
10127 Don't arbitrarily truncate the value of 'selective' to int.
10128
76031fad
PE
10129 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10130
5eb55db9
PE
10131 * composite.c: Don't truncate sizes to 'int'.
10132 (composition_gstring_p, composition_reseat_it)
10133 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10134 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10135 not EMACS_UINT, for indexes.
5eb55db9 10136
0703a717
PE
10137 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10138
d6202519
PE
10139 * buffer.c: Include <verify.h>.
10140 (struct sortvec.priority, struct sortstr.priority):
8961a454 10141 Now EMACS_INT, not int.
c20998a7 10142 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10143 (struct sortstr.size, record_overlay_string)
10144 (struct sortstrlist.size, struct sortlist.used):
10145 Don't truncate size to int.
10146 (record_overlay_string): Check for size-calculation overflow.
d6202519 10147 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10148
d5a19415
JM
101492011-06-22 Jim Meyering <meyering@redhat.com>
10150
029529ac 10151 Don't leak an XBM-image-sized buffer
d5a19415
JM
10152 * image.c (xbm_load): Free the image buffer after using it.
10153
a9041e6c
PE
101542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10155
10156 Port to Sun C.
10157 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10158 that Sun C diagnosed.
10159 * fns.c (secure_hash): Fix pointer signedness issue.
10160 * intervals.c (static_offset_intervals): New function.
10161 (offset_intervals): Use it.
10162
7f3f739f
LL
101632011-06-21 Leo Liu <sdl.web@gmail.com>
10164
10165 * deps.mk (fns.o):
10166 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10167 sha512.h.
10168
10169 * fns.c (secure_hash): Rename from crypto_hash_function and change
10170 the first arg to accept symbols.
5b66d427 10171 (Fsecure_hash): New primitive.
7f3f739f
LL
10172 (syms_of_fns): New symbols.
10173
76147d94
DD
101742011-06-20 Deniz Dogan <deniz@dogan.se>
10175
10176 * process.c (Fset_process_buffer): Clarify return value in
10177 docstring.
10178
7d7d0045
CY
101792011-06-18 Chong Yidong <cyd@stupidchicken.com>
10180
10181 * dispnew.c (add_window_display_history): Use BVAR.
10182
10183 * xdisp.c (debug_method_add): Use BVAR.
10184 (check_window_end, dump_glyph_matrix, dump_glyph)
10185 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10186
10187 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10188 Likewise.
10189
10190 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10191 check till after the cache is created in init_frame_faces.
10192
ff2bc410
SM
101932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10194
10195 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10196
28177add
PE
101972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10198
dd3482fe
PE
10199 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10200 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10201 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10202
393d71f3 10203 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10204 * fileio.c (Finsert_file_contents):
10205 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10206 Remove the old (too-loose) buffer overflow checks.
10207 They weren't needed, since make_gap checks for buffer overflow.
10208 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10209 The old code merely checked for Emacs fixnum overflow, and relied
10210 on undefined (wraparound) behavior. The new code avoids undefined
10211 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10212
2e6813b0 10213 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10214 Tune. Don't use wider integers than needed. Don't use alloca.
10215 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10216
599a9e4f
PE
10217 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10218
99561444
PE
10219 * insdel.c, lisp.h (buffer_overflow): New function.
10220 (insert_from_buffer_1, replace_range, replace_range_2):
10221 * insdel.c (make_gap_larger):
10222 * editfns.c (Finsert_char):
10223 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10224
28177add
PE
10225 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10226
e69dafad
PE
102272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10228
4baa020d 10229 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10230
b1c46f02
PE
10231 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10232 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10233
e69dafad
PE
10234 * fileio.c: Don't assume EMACS_INT fits in off_t.
10235 (emacs_lseek): New static function.
10236 (Finsert_file_contents, Fwrite_region): Use it.
10237 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10238
566684ea
PE
10239 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10240
e6966cd6
PE
10241 * fns.c: Don't overflow int when computing a list length.
10242 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10243 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10244 truncation on 64-bit hosts. Check for QUIT every
10245 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10246 faster and is responsive enough.
10247 (Flength): Report an error instead of overflowing an integer.
10248 (Fsafe_length): Return a float if the value is not representable
10249 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10250 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10251 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10252
dd0b0efb
PE
10253 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10254 (header_size, word_size): New constants.
10255 (allocate_vectorlike): Don't check size overflow here.
10256 (allocate_vector): Check it here instead, since this is the only
10257 caller of allocate_vectorlike that could cause overflow.
10258 Check that the new vector's length is representable as a fixnum.
10259
86fe5cfe
PE
10260 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10261 The previous code was bogus. For example, next_almost_prime (32)
10262 returned 39, which is undesirable as it is a multiple of 3; and
10263 next_almost_prime (24) returned 25, which is a multiple of 5 so
10264 why was the code bothering to check for multiples of 7?
10265
80e88859
PE
10266 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10267
4a2f0ad6
PE
10268 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10269
f66c7cf8
PE
10270 Variadic C functions now count arguments with ptrdiff_t.
10271 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10272 Back then I didn't know that the Emacs coding style prefers signed int.
10273 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10274 were being counted with int, which may truncate counts on 64-bit
10275 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10276 * lisp.h (struct Lisp_Subr.function.aMANY)
10277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10278 Arg counts are now ptrdiff_t, not size_t.
10279 All variadic functions and their callers changed accordingly.
10280 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10281 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10282 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10283 * callint.c (Fcall_interactively): Check arg count for overflow,
10284 to avoid potential buffer overrun. Use signed char, not 'int',
10285 for 'varies' array, so that we needn't bother to check its size
10286 calculation for overflow.
10287 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10288 * eval.c (apply_lambda):
10289 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10290 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10291 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10292
a1759b76
PE
10293 * callint.c (Fcall_interactively): Don't use index var as event count.
10294
d96be9fc
PE
10295 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10296 * mem-limits.h (SIZE): Remove; no longer used.
10297
a690a978 10298 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10299
578c21e6
PE
10300 Remove unnecessary casts.
10301 * xterm.c (x_term_init):
10302 * xfns.c (x_set_border_pixel):
10303 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10304 These aren't needed now that we assume ANSI C.
10305
96f53c6c
PE
10306 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10307 It's more likely to cause problems (due to unsigned overflow)
10308 than to cure them.
10309
83c77d31
PE
10310 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10311
ee2079f1
PE
10312 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10313
6da65536
PE
10314 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10315
7147c4a4
PE
10316 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10317
193e32d9
PE
10318 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10319
e5533da6
PE
10320 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10321
9910e595
PE
10322 GLYPH_CODE_FACE returns EMACS_INT, not int.
10323 * dispextern.h (merge_faces):
10324 * xfaces.c (merge_faces):
01103c44
PE
10325 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10326 Don't assume EMACS_INT fits in int.
9910e595 10327
2638320e
PE
10328 * character.h (CHAR_VALID_P): Remove unused parameter.
10329 * fontset.c, lisp.h, xdisp.c: All uses changed.
10330
045eb8d9
PE
10331 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10332
c1f134b5
PE
10333 * fns.c (concat): Minor tuning based on overflow analysis.
10334 This doesn't fix any bugs. Use int to hold character, instead
10335 of constantly refetching from Emacs object. Use XFASTINT, not
10336 XINT, for value known to be a character. Don't bother comparing
10337 a single byte to 0400, as it's always less.
10338
395fcb93 10339 * floatfns.c (Fexpt):
327eeec8
PE
10340 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10341
abbd3d23
PE
10342 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10343 for characters.
10344
684a03ef
PE
10345 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10346
0fed43f3
PE
10347 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10348 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10349 incorrectly succeed when S was a string, because 4294967386 was
10350 truncated before it was used.
10351
8fd02eb7
PE
10352 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10353 Otherwise, an out-of-range integer could cause undefined behavior
10354 on a 64-bit host.
10355
f8c86b69
PE
10356 * composite.c: Use int, not EMACS_INT, for characters.
10357 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10358 EMACS_INT, for values that are known to be in character range.
10359 This doesn't fix any bugs but is the usual style inside Emacs and
10360 may generate better code on 32-bit machines.
10361
34206dd2
PE
10362 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10363 This is for reasons similar to the recent CHAR_STRING fix.
10364 * charset.c (Fencode_char): Check that character arg is actually
10365 a character. Pass an int to ENCODE_CHAR.
10366 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10367 wider than 'int', as a compile-time check to prevent future regressions
10368 in this area.
10369
c5958d4c 10370 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10371
10372 Make sure a 64-bit char is never passed to CHAR_STRING.
10373 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10374 by silently ignoring the top 32 bits, allowing some values
10375 that were far too large to be valid characters.
10376 * character.h: Include <verify.h>.
10377 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10378 arguments are no wider than unsigned, as a compile-time check
10379 to prevent future regressions in this area.
10380 * data.c (Faset):
01103c44 10381 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10382 (Fsubst_char_in_region):
10383 * fns.c (concat):
10384 * xdisp.c (decode_mode_spec_coding):
10385 Adjust to CHAR_STRING's new requirement.
10386 * editfns.c (Finsert_char, Fsubst_char_in_region):
10387 * fns.c (concat): Check that character args are actually
10388 characters. Without this test, these functions did the wrong
10389 thing with wildly out-of-range values on 64-bit hosts.
10390
d37ca623
PE
10391 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10392 These casts should not be needed on 32-bit hosts, either.
10393 * keyboard.c (read_char):
10394 * lread.c (Fload): Remove casts to unsigned.
10395
ea204efb
PE
10396 * lisp.h (UNSIGNED_CMP): New macro.
10397 This fixes comparison bugs on 64-bit hosts.
10398 (ASCII_CHAR_P): Use it.
10399 * casefiddle.c (casify_object):
01103c44 10400 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10401 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10402 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10403 * dispextern.h (FACE_FROM_ID):
10404 * keyboard.c (read_char): Use UNSIGNED_CMP.
10405
41cb286c
PE
10406 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10407 not to EMACS_INT, to avoid GCC warning.
10408
4a1b9832
PE
10409 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10410
55daad71
PE
10411 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10412 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10413 isn't needed on 32-bit machines.
8f95c75c 10414
01103c44
PE
10415 * buffer.c (Fgenerate_new_buffer_name):
10416 Use EMACS_INT for count, not int.
0ceccced 10417 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10418
10419 * data.c (Qcompiled_function): Now static.
10420
c6f072e7
PE
10421 * window.c (window_body_lines): Now static.
10422
20ce5912
PE
10423 * image.c (gif_load): Rename local to avoid shadowing.
10424
9c4c5f81
PE
10425 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10426 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10427 * alloc.c (make_save_value): Integer argument is now of type
10428 ptrdiff_t, not int.
10429 (mark_object): Use ptrdiff_t, not int.
10430 * lisp.h (pD): New macro.
10431 * print.c (print_object): Use it.
10432
c0c5c8ae
PE
10433 * alloc.c: Use EMACS_INT, not int, to count objects.
10434 (total_conses, total_markers, total_symbols, total_vector_size)
10435 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10436 (total_free_floats, total_floats, total_free_intervals)
10437 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10438 Now EMACS_INT, not int. All uses changed.
10439 (Fgarbage_collect): Compute overall total using a double, so that
10440 integer overflow is less likely to be a problem. Check for overflow
10441 when converting back to an integer.
5a25e253
PE
10442 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10443 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10444 These were 'int' variables that could overflow on 64-bit hosts;
10445 they were never used, so remove them instead of repairing them.
211a0b2a 10446 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10447 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10448 Previously, this ceilinged at INT_MAX, but that doesn't work on
10449 64-bit machines.
e46bb31a 10450 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10451
c78baabf 10452 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10453 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10454 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10455 when a (possibly-narrower) signed value would do just as well.
10456 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10457
c9d624c6
PE
10458 * alloc.c: Catch some string size overflows that we were missing.
10459 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10460 for convenience in STRING_BYTES_MAX.
10461 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10462 The definition here is exact; the one in lisp.h was approximate.
10463 (allocate_string_data): Check for string overflow. This catches
10464 some instances we weren't catching before. Also, it catches
10465 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10466 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10467 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10468
c9d624c6
PE
10469 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10470 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10471 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10472
353032ce
PE
10473 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10474
2bccce07
PE
10475 * alloc.c (Fmake_string): Check for out-of-range init.
10476
0ac30604
SM
104772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10478
10479 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10480
c195f2de
JD
104812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10482
10483 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10484 xg_get_default_scrollbar_width.
10485
10486 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10487 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10488 (style_changed_cb): Call update_theme_scrollbar_width and call
10489 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10490 all frames (Bug#8505).
10491 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10492 Call gtk_window_set_resizable if HAVE_GTK3.
10493 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10494 and height if HAVE_GTK3 (Bug#8505).
10495 (scroll_bar_width_for_theme): New variable.
10496 (update_theme_scrollbar_width): New function.
10497 (xg_get_default_scrollbar_width): Move code to
10498 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10499 (xg_initialize): Call update_theme_scrollbar_width.
10500
10501 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10502
10503 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10504
e10ac9f1
MR
105052011-06-12 Martin Rudalics <rudalics@gmx.at>
10506
10507 * frame.c (make_frame): Call other_buffer_safely instead of
10508 other_buffer.
10509
10510 * window.c (temp_output_buffer_show): Call display_buffer with
10511 second argument Vtemp_buffer_show_specifiers and reset latter
10512 immediately after the call.
10513 (Vtemp_buffer_show_specifiers): New variable.
10514 (auto_window_vscroll_p, next_screen_context_lines)
10515 (Vscroll_preserve_screen_position): Remove leading asterisks from
10516 doc-strings.
10517
2d3c217e 105182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10519
7b7f97e8 10520 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10521 * buffer.c (Qclone_number): Remove for now, as it's unused.
10522 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10523 (record_buffer): Remove unused local.
10524 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10525 (set_frame_buffer_list): Remove; unused.
10526 * frame.h (other_visible_frames): Remove decl.
10527 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10528 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10529 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10530 if HAVE_GPM.
10531 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10532 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10533 Define only if HAVE_GPM.
10534 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10535 (update_hints_inhibit): Remove; never set. All uses removed.
10536 * widgetprv.h (emacsFrameClassRec): Remove decl.
10537 * window.c (delete_deletable_window): Now returns void, since it
10538 wasn't returning anything.
10539 (compare_window_configurations): Remove unused locals.
10540 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10541 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10542 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10543 the same widths as pointers. This follows up on the 2011-05-06 patch.
10544 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10545 * xterm.h: Likewise.
10546 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10547
1384b89e
JB
105482011-06-12 Juanma Barranquero <lekktu@gmail.com>
10549
10550 * makefile.w32-in: Update dependencies.
10551 (LISP_H): Add lib/intprops.h.
10552
1100a63c
CY
105532011-06-11 Chong Yidong <cyd@stupidchicken.com>
10554
10555 * image.c (gif_load): Add animation frame delay to the metadata.
10556 (syms_of_image): Use DEFSYM. New symbol `delay'.
10557
6198ccd0
MR
105582011-06-11 Martin Rudalics <rudalics@gmx.at>
10559
10560 * window.c (delete_deletable_window): Re-add.
10561 (Fset_window_configuration): Rewrite to handle dead buffers and
10562 consequently deletable windows.
10563 (window_tree, Fwindow_tree): Remove. Supply functionality in
10564 window.el.
10565 (compare_window_configurations): Simplify code.
10566
b6e3633c
AS
105672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10568
1ab0dee5
AS
10569 * image.c (imagemagick_load_image): Fix type mismatch.
10570 (Fimagemagick_types): Likewise.
10571
b6e3633c
AS
10572 * window.h (replace_buffer_in_windows): Declare.
10573
9397e56f
MR
105742011-06-11 Martin Rudalics <rudalics@gmx.at>
10575
10576 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10577 Qclone_number. Remove external declaration of Qdelete_window.
10578 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10579 code.
640c8776
SM
10580 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10581 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10582 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10583 buffer list implementation.
10584 (other_buffer_safely): New function.
10585 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10586 calls to replace_buffer_in_windows and
10587 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10588 if allowed.
10589 (record_buffer): Inhibit quitting and rewrite using quittable
10590 functions. Run Qbuffer_list_update_hook if allowed.
10591 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10592 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10593 Move switch-to-buffer to window.el.
9397e56f
MR
10594 (bury-buffer): Move to window.el.
10595 (Vbuffer_list_update_hook): New variable.
10596
10597 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10598 section.
10599
10600 * window.h (resize_frame_windows): Move up in code.
10601 (Fwindow_frame): Remove EXFUN.
10602 (replace_buffer_in_all_windows): Remove prototype.
10603 (replace_buffer_in_windows_safely): Add prototype.
10604
10605 * window.c: Declare Qdelete_window static again. Move down
10606 declaration of select_count.
10607 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10608 (Fother_window): Move to window.el.
10609 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10610 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10611 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10612 window.el.
10613 (replace_buffer_in_windows): Implement by calling
10614 Qreplace_buffer_in_windows.
10615 (replace_buffer_in_all_windows): Remove with some functionality
10616 moved into replace_buffer_in_windows_safely.
10617 (replace_buffer_in_windows_safely): New function.
10618 (select_window_norecord, select_frame_norecord): Move in front
10619 of run_window_configuration_change_hook. Remove now obsolete
10620 declarations.
640c8776
SM
10621 (Fset_window_buffer): Rewrite doc-string.
10622 Call Qrecord_window_buffer.
9397e56f
MR
10623 (keys_of_window): Move binding for other-window to window.el.
10624
b50691aa
CY
106252011-06-11 Chong Yidong <cyd@stupidchicken.com>
10626
10627 * dispextern.h (struct image): Replace data member, whose int_val
10628 and ptr_val fields were not used by anything, with a single
10629 lisp_val object.
10630
10631 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10632 (gif_clear_image, gif_load, imagemagick_load_image)
10633 (gs_clear_image, gs_load): Callers changed.
10634
3f754b86
PE
106352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10636
cca69397
PE
10637 * buffer.h: Include <time.h>, for time_t.
10638 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10639
109e28d0
PE
10640 Fix minor problems found by static checking.
10641
60737f02
PE
10642 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10643
4b66faf3
PE
10644 Make identifiers static if they are not used in other modules.
10645 * data.c (Qcompiled_function, Qframe, Qvector):
10646 * image.c (QimageMagick, Qsvg):
10647 * minibuf.c (Qmetadata):
10648 * window.c (resize_window_check, resize_root_window): Now static.
10649 * window.h (resize_window_check, resize_root_window): Remove decls.
10650
109e28d0
PE
10651 * window.c (window_deletion_count, delete_deletable_window):
10652 Remove; unused.
46a4ce9e
PE
10653 (window_body_lines): Now static.
10654 (Fdelete_other_windows_internal): Mark vars as initialized.
10655 Make sure 'resize_failed' is initialized.
10656 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10657 (resize_window_apply): Remove unused local.
10658 * window.h (delete_deletable_window): Remove decl.
10659
109e28d0 10660 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10661 (imagemagick_load_image): Fix pointer signedness problem by changing
10662 last arg from unsigned char * to char *. All uses changed.
10663 Also, fix a local for similar reasons.
10664 Remove unused locals. Remove locals to avoid shadowing.
10665 (fn_rsvg_handle_free): Remove; unused.
10666 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10667 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10668
3f754b86
PE
10669 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10670
2547adb1
CY
106712011-06-10 Chong Yidong <cyd@stupidchicken.com>
10672
10673 * image.c (gif_load): Fix omitted cast error introduced by
10674 2011-06-06 change.
10675
2c8e37d4
MR
106762011-06-10 Martin Rudalics <rudalics@gmx.at>
10677
10678 * window.h (resize_proportionally, orig_total_lines)
10679 (orig_top_line): Remove from window structure.
10680 (set_window_height, set_window_width, change_window_heights)
10681 (Fdelete_window): Remove prototypes.
10682 (resize_frame_windows): Remove duplicate declaration.
10683
440a42e3
EZ
106842011-06-10 Eli Zaretskii <eliz@gnu.org>
10685
10686 * window.h (resize_frame_windows, resize_window_check)
10687 (delete_deletable_window, resize_root_window)
10688 (resize_frame_windows): Declare prototypes.
10689
10690 * window.c (resize_window_apply): Make definition be "static" to
10691 match the prototype.
10692
562dd5e9
MR
106932011-06-10 Martin Rudalics <rudalics@gmx.at>
10694
10695 * window.c: Remove declarations of Qwindow_size_fixed,
10696 window_min_size_1, window_min_size_2, window_min_size,
10697 size_window, window_fixed_size_p, enlarge_window, delete_window.
10698 Remove static from declaration of Qdelete_window, it's
10699 temporarily needed by Fbury_buffer.
10700 (replace_window): Don't assign orig_top_line and
10701 orig_total_lines.
10702 (Fdelete_window, delete_window): Remove. Window deletion is
10703 handled by window.el.
640c8776
SM
10704 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10705 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10706 (Fdelete_other_windows): Remove. Deleting other windows is
10707 handled by window.el.
10708 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10709 handled in window.el.
10710 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10711 Window minimum sizes are handled in window.el.
10712 (shrink_windows, size_window, set_window_height)
10713 (set_window_width, change_window_heights, window_height)
10714 (window_width, CURBEG, CURSIZE, enlarge_window)
10715 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10716 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10717 handled in window.el.
10718 (make_dummy_parent): Rename to make_parent_window and give it a
10719 second argument horflag.
10720 (make_window): Don't set resize_proportionally any more.
10721 (Fsplit_window): Remove. Windows are split in window.el.
10722 (save_restore_action, save_restore_orig_size)
10723 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10724 Resize mini windows in window.el.
10725 (grow_mini_window, shrink_mini_window): Implement by calling
10726 Qresize_root_window_vertically, resize_window_check and
10727 resize_window_apply.
640c8776
SM
10728 (saved_window, Fset_window_configuration, save_window_save):
10729 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10730 resize_proportionally.
10731 (window_min_height, window_min_width): Move to window.el.
10732 (keys_of_window): Move bindings for delete-other-windows,
10733 split-window, delete-window and enlarge-window to window.el.
10734
10735 * buffer.c: Temporarily extern Qdelete_window.
10736 (Fbury_buffer): Temporarily call Qdelete_window instead of
10737 Fdelete_window (Fbury_buffer will move to window.el soon).
10738
10739 * frame.c (set_menu_bar_lines_1): Remove code handling
10740 orig_top_line and orig_total_lines.
10741
10742 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10743 set_window_height but set heights directly.
10744 (change_frame_size_1): Use resize_frame_windows.
10745
10746 * xdisp.c (init_xdisp): Don't use set_window_height but set
10747 heights directly.
10748
640c8776
SM
10749 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10750 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10751 run_window_configuration_change_hook.
10752
10753 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10754 instead of change_window_heights and run
10755 run_window_configuration_change_hook.
10756
1a13852e
MR
107572011-06-09 Martin Rudalics <rudalics@gmx.at>
10758
10759 * window.c (replace_window): Rename second argument REPLACEMENT to
10760 NEW. New third argument SETFLAG. Rewrite.
10761 (delete_window, make_dummy_parent): Call replace_window with
10762 third argument 1.
10763 (window_list_1): Move down in code.
10764 (run_window_configuration_change_hook): Move set_buffer part
10765 before select_frame_norecord part in order to unwind correctly.
10766 Rename count1 to count.
10767 (recombine_windows, delete_deletable_window, resize_root_window)
10768 (Fdelete_other_windows_internal)
10769 (Frun_window_configuration_change_hook, make_parent_window)
10770 (resize_window_check, resize_window_apply, Fresize_window_apply)
10771 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10772 (Fdelete_window_internal, Fresize_mini_window_internal):
10773 New functions.
1a13852e
MR
10774 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10775
f3d1777e
MR
107762011-06-08 Martin Rudalics <rudalics@gmx.at>
10777
496e208e
MR
10778 * window.h (window): Add some new members to window structure -
10779 normal_lines, normal_cols, new_total, new_normal, clone_number,
10780 splits, nest, prev_buffers, next_buffers.
10781 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10782 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10783
f3d1777e
MR
10784 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10785 Remove.
496e208e
MR
10786 (make_dummy_parent): Set new members of windows structure.
10787 (make_window): Move down in code. Handle new members of window
10788 structure.
10789 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10790 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10791 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10792 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10793 (Fset_window_next_buffers, Fset_window_clone_number):
10794 New functions.
496e208e
MR
10795 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10796 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10797 Doc-string fixes.
10798 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10799 Argument WINDOW can be now internal window too.
10800 (Fwindow_use_time): Move up in code.
10801 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10802 Rewrite doc-string.
10803 (Fset_window_configuration, saved_window)
10804 (Fcurrent_window_configuration, save_window_save): Handle new
10805 members of window structure.
b9e809c2
MR
10806 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10807 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10808 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10809 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10810 Qget_mru_window, Qresize_root_window,
10811 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10812 Qauto_buffer_name; staticpro them.
f3d1777e 10813
abde8f8c
MR
108142011-06-07 Martin Rudalics <rudalics@gmx.at>
10815
10816 * window.c (Fwindow_total_size, Fwindow_left_column)
10817 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10818 (Fwindow_list_1): New functions.
10819 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10820 (Fwindow_width, Fscroll_left, Fscroll_right):
10821 Use window_body_cols instead of window_box_text_cols.
10822 (delete_window, Fset_window_configuration):
10823 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10824 (delete_all_subwindows): Take a window as argument and not a
10825 structure. Rewrite.
190b47e6
MR
10826 (window_loop): Remove handling of GET_LRU_WINDOW and
10827 GET_LARGEST_WINDOW.
10828 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10829
10830 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10831 window_box_text_cols. delete_all_subwindows now takes a
10832 Lisp_Object as argument.
abde8f8c 10833
640c8776
SM
10834 * indent.c (compute_motion, Fcompute_motion):
10835 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10836
fa8a67e6
MR
10837 * frame.c (delete_frame): Call delete_all_subwindows with root
10838 window as argument.
10839
a54e3482
DC
108402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10841
10842 * fns.c (Fputhash): Document return value.
10843
60002bf5
CY
108442011-06-06 Chong Yidong <cyd@stupidchicken.com>
10845
10846 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10847
0c671da6 108482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10849
b862a52a 10850 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10851
be44ca6c
PE
10852 Check for overflow when converting integer to cons and back.
10853 * charset.c (Fdefine_charset_internal, Fdecode_char):
10854 Use cons_to_unsigned to catch overflow.
10855 (Fencode_char): Use INTEGER_TO_CONS.
10856 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10857 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10858 * data.c (long_to_cons, cons_to_long): Remove.
10859 (cons_to_unsigned, cons_to_signed): New functions.
10860 These signal an error for invalid or out-of-range values.
10861 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10862 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10863 * font.c (Ffont_variation_glyphs):
10864 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10865 * lisp.h: Include <intprops.h>.
10866 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10867 (cons_to_signed, cons_to_unsigned): New decls.
10868 (long_to_cons, cons_to_long): Remove decls.
10869 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10870 (Fprimitive_undo): Use CONS_TO_INTEGER.
10871 * xfns.c (Fx_window_property): Likewise.
10872 * xselect.c: Include <limits.h>.
10873 (x_own_selection, selection_data_to_lisp_data):
10874 Use INTEGER_TO_CONS.
10875 (x_handle_selection_request, x_handle_selection_clear)
10876 (x_get_foreign_selection, Fx_disown_selection_internal)
10877 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10878 (lisp_data_to_selection_data): Use cons_to_unsigned.
10879 (x_fill_property_data): Use cons_to_signed.
10880 Report values out of range.
10881
d1f3d2af
PE
10882 Check for buffer and string overflow more precisely.
10883 * buffer.h (BUF_BYTES_MAX): New macro.
10884 * lisp.h (STRING_BYTES_MAX): New macro.
10885 * alloc.c (Fmake_string):
10886 * character.c (string_escape_byte8):
10887 * coding.c (coding_alloc_by_realloc):
10888 * doprnt.c (doprnt):
10889 * editfns.c (Fformat):
10890 * eval.c (verror):
10891 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10892 since they may not be the same number.
10893 * editfns.c (Finsert_char):
10894 * fileio.c (Finsert_file_contents):
10895 Likewise for BUF_BYTES_MAX.
10896
dd52fcea
PE
10897 * image.c: Use ptrdiff_t, not int, for sizes.
10898 (slurp_file): Switch from int to ptrdiff_t.
10899 All uses changed.
10900 (slurp_file): Check that file size fits in both size_t (for
10901 malloc) and ptrdiff_t (for sanity and safety).
10902
7f9bbdbb
PE
10903 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10904 if b->modtime has its maximal value.
10905
dfe18f82
PE
10906 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10907
84acfcf0
PE
10908 Don't assume time_t can fit into int.
10909 * buffer.h (struct buffer.modtime): Now time_t, not int.
10910 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10911 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10912
ccd9a01a
PE
10913 Minor fixes for signed vs unsigned integers.
10914 * character.h (MAYBE_UNIFY_CHAR):
10915 * charset.c (maybe_unify_char):
10916 * keyboard.c (read_char, reorder_modifiers):
10917 XINT -> XFASTINT, since the integer must be nonnegative.
10918 * ftfont.c (ftfont_spec_pattern):
10919 * keymap.c (access_keymap, silly_event_symbol_error):
10920 XUINT -> XFASTINT, since the integer must be nonnegative.
10921 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10922 since it makes no difference and we prefer signed.
10923 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10924 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10925 nonnegative.
10926
d6d100dd
SM
109272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10928
10929 * window.h (Fwindow_frame): Declare.
10930
2b6148e4
PE
109312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10932
10933 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10934 (SPARE_MEMORY): Always define.
10935 (LARGE_REQUEST): Remove.
10936 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10937
f230ecc9
MR
109382011-06-06 Martin Rudalics <rudalics@gmx.at>
10939
727e958e
MR
10940 * lisp.h: Move EXFUNS for Fframe_root_window,
10941 Fframe_first_window and Fset_frame_selected_window to window.h.
10942
10943 * window.h: Move EXFUNS for Fframe_root_window,
10944 Fframe_first_window and Fset_frame_selected_window here from
10945 lisp.h.
10946
10947 * frame.c (Fwindow_frame, Fframe_first_window)
10948 (Fframe_root_window, Fframe_selected_window)
10949 (Fset_frame_selected_window): Move to window.c.
10950 (Factive_minibuffer_window): Move to minibuf.c.
10951 (Fother_visible_frames_p): New function.
10952
10953 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10954
f230ecc9
MR
10955 * window.c (decode_window, decode_any_window): Move up in code.
10956 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10957 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10958 (Fwindow_buffer): Move up and rewrite doc-string.
10959 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10960 (Fwindow_prev): New functions.
727e958e
MR
10961 (Fwindow_frame): Move here from frame.c. Accept any window as
10962 argument.
10963 (Fframe_root_window, Fframe_first_window)
10964 (Fframe_selected_window): Move here from frame.c. Accept frame
10965 or arbitrary window as argument. Update doc-strings.
10966 (Fminibuffer_window): Move up in code.
10967 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10968 (Fset_frame_selected_window): Move here from frame.c.
10969 Marginal rewrite.
727e958e
MR
10970 (Fselected_window, select_window, Fselect_window): Move up in
10971 code. Minor doc-string fixes.
f230ecc9 10972
4d09bcf6
PE
109732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10974
10975 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10976 Do not assume that spare memory exists; that assumption is valid
10977 only if SYSTEM_MALLOC.
10978 (LARGE_REQUEST): New macro, so that the issue of large requests
10979 is separated from the issue of spare memory.
10980
810928a2
AS
109812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10982
172418ad
AS
10983 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10984 format. (Bug#8806)
10985
43f862f7
AS
10986 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10987
810928a2
AS
10988 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10989 before statements.
10990
a059fe24
JD
109912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10992
10993 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10994
10995 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10996
10997 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10998 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10999
989bf368
JB
110002011-06-05 Juanma Barranquero <lekktu@gmail.com>
11001
11002 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11003
4b80f674
CY
110042011-06-04 Chong Yidong <cyd@stupidchicken.com>
11005
11006 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11007 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11008 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11009 New error handlers.
4b80f674
CY
11010 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11011 Obey Vx_select_enable_clipboard_manager. Catch errors in
11012 x_clipboard_manager_save (Bug#8779).
11013 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11014 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11015
99a33b77 110162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11017
11018 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11019
99a33b77 110202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11021
11022 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11023 in the current matrix if keep_current_p is non-zero.
11024
8264569d
EZ
110252011-06-04 Eli Zaretskii <eliz@gnu.org>
11026
11027 * bidi.c (bidi_level_of_next_char): Fix last change.
11028
57f97249
EZ
110292011-06-03 Eli Zaretskii <eliz@gnu.org>
11030
fec2107c 11031 Support bidi reordering of text covered by display properties.
57f97249 11032
fec2107c
EZ
11033 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11034 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11035 (bidi_cache_search, bidi_cache_iterator_state)
11036 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11037 (bidi_level_of_next_char, bidi_move_to_visually_next):
11038 Support character positions inside a run of characters covered by a
fec2107c
EZ
11039 display string.
11040 (bidi_paragraph_init, bidi_resolve_explicit_1)
11041 (bidi_level_of_next_char): Call bidi_fetch_char and
11042 bidi_fetch_char_advance instead of FETCH_CHAR and
11043 FETCH_CHAR_ADVANCE.
11044 (bidi_init_it): Initialize new members.
11045 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11046 definitions.
11047 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11048 instead of using explicit *_CHAR codes.
d6d100dd
SM
11049 (bidi_resolve_explicit, bidi_resolve_weak):
11050 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11051 bidirectional text is supported only in multibyte buffers.
11052 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11053 it to initialize the frame_window_p member of struct bidi_it.
11054 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11055 (bidi_resolve_explicit, bidi_resolve_weak)
11056 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11057 bidi_it->nchars is non-positive.
11058 (bidi_level_of_next_char): Don't try to lookup the cache for the
11059 next/previous character if nothing is cached there yet, or if we
11060 were just reseat()'ed to a new position.
c40e2fb2 11061
0e14fe90
EZ
11062 * xdisp.c (set_cursor_from_row): Set start and stop points
11063 according to the row's direction when priming the loop that looks
11064 for the glyph on which to display cursor.
11065 (single_display_spec_intangible_p): Function deleted.
11066 (display_prop_intangible_p): Reimplement to call
11067 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11068 Accept 3 additional arguments needed by handle_display_spec.
11069 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11070 values: lists, `(when COND...)' forms, etc.
11071 (single_display_spec_string_p): Support property values that are
11072 lists with the argument STRING its top-level element.
11073 (display_prop_string_p): Fix the condition for processing a
11074 property that is a list to be consistent with handle_display_spec.
fec2107c 11075 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11076 last portion of handle_display_prop.
11077 (compute_display_string_pos): Accept additional argument
11078 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11079 value of a `display' property is a "replacing spec".
11080 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11081 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11082 the display property, but just return a value indicating whether
11083 the display property will replace the characters it covers.
11084 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11085 frame_window_p members of struct bidi_it.
d6d100dd
SM
11086 (compute_display_string_pos, compute_display_string_end):
11087 New functions.
fec2107c
EZ
11088 (push_it): Accept second argument POSITION, where pop_it should
11089 jump to continue iteration.
11090 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11091
fec2107c
EZ
11092 * keyboard.c (adjust_point_for_property): Adjust the call to
11093 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11094
11095 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11096 (bidi_init_it): Update prototypes.
11097 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11098 (compute_display_string_pos, compute_display_string_end):
11099 Declare prototypes.
fec2107c
EZ
11100 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11101 EMACS_INT.
fc6f18ce 11102
40087514 111032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11104
57f53182
PE
11105 Malloc failure behavior now depends on size of allocation.
11106 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11107 * lisp.h: Change signatures accordingly.
11108 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11109 All callers changed. (Bug#8762)
11110
11111 * gnutls.c: Use Emacs's memory allocators.
11112 Without this change, the gnutls library would invoke malloc etc.
11113 directly, which causes problems on non-SYNC_INPUT hosts, and which
11114 runs afoul of improving memory_full behavior. (Bug#8761)
11115 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11116 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11117 xfree instead of the default malloc, realloc, free.
11118 (Fgnutls_boot): No need to check for memory allocation failure,
11119 since xmalloc does that for us.
11120
ac32cd99 11121 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11122 * category.c (hash_get_category_set):
11123 * ccl.c (ccl_driver):
11124 * charset.c (Fdefine_charset_internal):
11125 * charset.h (struct charset.hash_index):
11126 * composite.c (get_composition_id, gstring_lookup_cache)
11127 (composition_gstring_put_cache):
11128 * composite.h (struct composition.hash_index):
11129 * dispextern.h (struct image.hash):
11130 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11131 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11132 (hashfn_equal, hashfn_user_defined, make_hash_table)
11133 (maybe_resize_hash_table, hash_lookup, hash_put)
11134 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11135 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11136 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11137 * image.c (make_image, search_image_cache, lookup_image)
11138 (xpm_put_color_table_h):
11139 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11140 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11141 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11142 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11143 * alloc.c (allocate_vectorlike):
11144 Check for overflow in vector size calculations.
11145 * ccl.c (ccl_driver):
11146 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11147 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11148 need to be updated by these changes.
40087514
PE
11149 * fns.c (make_hash_table, maybe_resize_hash_table):
11150 Check for integer overflow with large hash tables.
0de4bb68
PE
11151 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11152 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11153 (SXHASH_REDUCE): New macro.
11154 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11155 Use it instead of discarding useful hash info with large hash values.
11156 (sxhash_float): New function.
11157 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11158 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11159 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11160 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11161 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11162 Adjust signatures to match updated version of code.
11163 (consing_since_gc): Now EMACS_INT, since a single hash table can
11164 use more than INT_MAX bytes.
11165
698d32e2
DN
111662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11167
11168 Make it possible to build with GCC-4.6+ -O2 -flto.
11169
11170 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11171
fd6fa53f
SM
111722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11173
11174 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11175 Call minibuffer-inactive-mode.
11176
864db017
JB
111772011-05-31 Juanma Barranquero <lekktu@gmail.com>
11178
11179 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11180 Update dependencies.
11181
2ad0baf4
DN
111822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11183
11184 * data.c (init_data): Remove code for UTS, this system is not
11185 supported anymore.
11186
4fcc2638
DN
111872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11188
11189 Don't force ./temacs to start in terminal mode.
11190
11191 * frame.c (make_initial_frame): Initialize faces in all cases, not
11192 only when CANNOT_DUMP is defined.
11193 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11194
c56e0fd5
DN
111952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11196
11197 * dispnew.c (add_window_display_history): Use const for the string
11198 pointer. Remove declaration, not needed.
11199
333d54da 112002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11201
55d4c1b2 11202 Use 'inline', not 'INLINE'.
333d54da 11203 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11204 * alloc.c, fontset.c (INLINE): Remove.
11205 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11206 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11207 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11208 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11209 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11210
738db178
DN
112112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11212
11213 Make it possible to run ./temacs.
11214
11215 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11216 syms_of_callproc does the same thing. Remove test for
11217 "initialized", do it in the caller.
11218 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11219
620c53a6
SM
112202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11221
11222 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11223 (read_minibuf): Use get_minibuffer.
11224 (syms_of_minibuf): Use DEFSYM.
11225 (Qmetadata): New var.
11226 * data.c (Qbuffer): Don't make it static.
11227 (syms_of_data): Use DEFSYM.
11228
e003a292
PE
112292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11230
11231 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11232 (CCL_CODE_MIN): New macro.
11233
ed008a6d
PE
112342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11235
3687c2ef
PE
11236 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11237
ed008a6d
PE
11238 * eval.c (Qdebug): Now static.
11239 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11240 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11241 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11242
d66c4c7c
CY
112432011-05-29 Chong Yidong <cyd@stupidchicken.com>
11244
11245 * image.c: Various fixes to ImageMagick code comments.
11246 (Fimagemagick_types): Doc fix.
11247
5fbc2025
PE
112482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11249
0196f88a
PE
11250 Minor fixes prompted by GCC 4.6.0 warnings.
11251
11252 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11253
5fbc2025
PE
11254 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11255 (x_clipboard_manager_save_all): Move extern decl to ...
11256 * xterm.h: ... here, so that it can be checked for consistency.
11257
1dd3c2d9
CY
112582011-05-29 Chong Yidong <cyd@stupidchicken.com>
11259
11260 * xselect.c (x_clipboard_manager_save_frame)
11261 (x_clipboard_manager_save_all): New functions.
11262 (Fx_clipboard_manager_save): Lisp function deleted.
11263
11264 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11265 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11266
11267 * xterm.h: Update prototype.
11268
5ba6571d
WX
112692011-05-28 William Xu <william.xwl@gmail.com>
11270
11271 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11272 exiting (Bug#8239).
11273
3eaff834
JM
112742011-05-28 Jim Meyering <meyering@redhat.com>
11275
e1900994 11276 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11277 * fns.c (to_uchar): Define.
11278 (crypto_hash_function): Use it to convert some newly-signed
11279 variables to unsigned, to avoid sign-extension bugs. For example,
11280 without this change, (md5 "truc") would evaluate to
11281 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11282 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11283 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11284
0f6990a7
PE
112852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11286
11287 Integer overflow fixes.
c8a9ca5a 11288
08686060
PE
11289 * dbusbind.c: Serial number integer overflow fixes.
11290 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11291 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11292 to hold a serial number that is too large for a fixnum.
11293 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11294 Check for serial numbers out of range. Decode any serial number
59568bf0 11295 that was so large that it became a float. (Bug#8722)
08686060 11296
2d1fc3c7
PE
11297 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11298 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11299 Use XFASTINT rather than XUINT when numbers are nonnegative.
11300 (xd_append_arg, Fdbus_method_return_internal):
11301 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11302 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11303 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11304 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11305 (Bug#8722)
2d1fc3c7 11306
c8a9ca5a
PE
11307 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11308
519e1d69
PE
11309 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11310
6df6ae42 11311 ccl: Add integer overflow checks.
30569699
PE
11312 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11313 (IN_INT_RANGE): New macros.
11314 (ccl_driver): Use them to check for integer overflow when
11315 decoding a CCL program. Many of the new checks are whether XINT (x)
11316 fits in int; it doesn't always, on 64-bit hosts. The new version
11317 doesn't catch all possible integer overflows, but it's an
847044ea 11318 improvement. (Bug#8719)
30569699 11319
c11285dc
PE
11320 * alloc.c (make_event_array): Use XINT, not XUINT.
11321 There's no need for unsigned here.
11322
fdccd48e
PE
11323 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11324 This follows up to the 2011-05-06 change that substituted uintptr_t
11325 for EMACS_INT. This case wasn't caught back then.
11326
37910ab2
PE
11327 Rework Fformat to avoid integer overflow issues.
11328 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11329 now (part of C89). Include <verify.h>.
11330 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11331 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11332 (Fformat): Avoid the prepass trying to compute sizes; it was only
11333 approximate and thus did not catch overflow reliably. Instead, walk
11334 through the format just once, formatting and computing sizes as we go,
11335 checking for integer overflow at every step, and allocating a larger
11336 buffer as needed. Keep track separately whether the format is
11337 multibyte. Keep only the most-recently calculated precision, rather
11338 than them all. Record whether each argument has been converted to
11339 string. Use EMACS_INT, not int, for byte and char and arg counts.
11340 Support field widths and precisions larger than INT_MAX. Avoid
11341 sprintf's undefined behavior with conversion specifications such as %#d
11342 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11343 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11344 formatting out-of-range floating point numbers with int
9173deec 11345 formats. (Bug#8668)
37910ab2 11346
2e6578fb
PE
11347 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11348
0ae6bdee
PE
11349 * data.c: Avoid integer truncation in expressions involving floats.
11350 * data.c: Include <intprops.h>.
11351 (arith_driver): When there's an integer overflow in an expression
11352 involving floating point, convert the integers to floating point
11353 so that the resulting value does not suffer from catastrophic
11354 integer truncation. For example, on a 64-bit host (* 4
11355 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11356 Do not rely on undefined behavior after integer overflow.
11357
de883a70
PE
11358 merge count_size_as_multibyte, parse_str_to_multibyte
11359 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11360 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11361 Check for integer overflow.
11362 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11363 since it's now a duplicate of the other. This is more of
11364 a character than a buffer op, so better that it's in character.c.
11365 * fns.c, print.c: Adjust to above changes.
11366
2ff916cb
PE
113672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11368
11369 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11370
f1b54466
PE
113712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11372
fb1ac845
PE
11373 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11374 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11375 (x_clipboard_manager_save): Now static.
11376 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11377
f1b54466
PE
11378 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11379 (crypto_hash_function): Now static.
11380 Fix pointer signedness problems. Avoid unnecessary initializations.
11381
a9f737ee
CY
113822011-05-27 Chong Yidong <cyd@stupidchicken.com>
11383
11384 * termhooks.h (Vselection_alist): Make it terminal-local.
11385
11386 * terminal.c (create_terminal): Initialize it.
11387
11388 * xselect.c: Support for clipboard managers.
11389 (Vselection_alist): Move to termhooks.h as terminal-local var.
11390 (LOCAL_SELECTION): New macro.
11391 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11392 (symbol_to_x_atom): Remove gratuitous arg.
11393 (x_handle_selection_request, lisp_data_to_selection_data)
11394 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11395 (x_own_selection, x_get_local_selection, x_convert_selection):
11396 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11397 (some_frame_on_display): Delete unused function.
11398 (Fx_own_selection_internal, Fx_get_selection_internal)
11399 (Fx_disown_selection_internal, Fx_selection_owner_p)
11400 (Fx_selection_exists_p): New optional frame arg.
11401 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11402 (x_handle_selection_clear): Don't treat other terminals with the
11403 same keyboard specially. Use the terminal-local Vselection_alist.
11404 (x_clear_frame_selections): Use Frun_hook_with_args.
11405
11406 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11407
11408 * xterm.h: Add support for those atoms.
11409
e067f0c1
CY
114102011-05-26 Chong Yidong <cyd@stupidchicken.com>
11411
11412 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11413 (converted_selections, conversion_fail_tag): New global variables.
11414 (x_selection_request_lisp_error): Free the above.
11415 (x_get_local_selection): Remove unnecessary code.
11416 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11417 of converted selections stored in converted_selections.
11418 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11419 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11420 (x_convert_selection): New function.
11421 (x_handle_selection_event): Simplify.
11422 (x_get_foreign_selection): Don't ignore incoming requests while
11423 waiting for an answer; this will fail when we implement
11424 SAVE_TARGETS, and seems unnecessary anyway.
11425 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11426 (Vx_sent_selection_functions): Doc fix.
11427
0f4aebc0
LL
114282011-05-26 Leo Liu <sdl.web@gmail.com>
11429
11430 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11431
e61124cd
YM
114322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11433
11434 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11435
11436 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11437 for fringe update if it has periodic bitmap.
ac389d0c 11438 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11439 and fringe_bitmap_periodic_p.
11440
11441 * fringe.c (get_fringe_bitmap_data): New function.
11442 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11443 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11444 row. Mark glyph row for fringe update if periodicity changed.
11445
11446 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11447 for fringe update unless it has periodic bitmap.
11448
f16d9837
KH
114492011-05-25 Kenichi Handa <handa@m17n.org>
11450
11451 * xdisp.c (get_next_display_element): Set correct it->face_id for
11452 a static composition.
11453
e1b90ef6
LL
114542011-05-24 Leo Liu <sdl.web@gmail.com>
11455
11456 * deps.mk (fns.o):
11457 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11458
11459 * fns.c (crypto_hash_function, Fsha1): New function.
11460 (Fmd5): Use crypto_hash_function.
11461 (syms_of_fns): Add Ssha1.
11462
7400048f
PE
114632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11464
11465 * gnutls.c: Remove unused macros.
11466 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11467 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11468 Remove macros that are defined and never used.
11469 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11470
abb71cf4
CY
114712011-05-22 Chong Yidong <cyd@stupidchicken.com>
11472
11473 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11474 (Fx_get_selection_internal): Minor cleanup.
11475 (Fx_own_selection_internal): Rename arguments for consistency with
11476 select.el.
11477
6307db39
PE
114782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11479
11480 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11481
f3d4e0a4
CY
114822011-05-22 Chong Yidong <cyd@stupidchicken.com>
11483
11484 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11485
4d8ade89
YM
114862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11487
11488 * dispnew.c (scrolling_window): Don't exclude the case that the
11489 last enabled row in the desired matrix touches the bottom boundary.
11490
32078c8d
GM
114912011-05-21 Glenn Morris <rgm@gnu.org>
11492
11493 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11494 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11495 and add some more files.
32078c8d 11496
7285dc67
EZ
114972011-05-20 Eli Zaretskii <eliz@gnu.org>
11498
11499 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11500 report_file_error introduced by the change from 2011-05-07.
11501
89d1bd22
PE
115022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11503
11504 * systime.h (Time): Define only if emacs is defined.
11505 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11506 where the include path doesn't have X11/X.h by default. See
11507 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11508
cd394be1 115092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11510
11511 * composite.c (find_automatic_composition): Fix previous change.
11512
b9704ad9
GM
115132011-05-20 Glenn Morris <rgm@gnu.org>
11514
11515 * lisp.mk: New file, split from Makefile.in.
11516 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11517 (shortlisp): Remove.
11518 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11519
4a720484
GM
115202011-05-19 Glenn Morris <rgm@gnu.org>
11521
11522 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11523 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11524 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11525 (lisp): Set the order to that of loadup.el.
11526 (shortlisp): Make it a copy of $lisp.
11527 (SOME_MACHINE_LISP): Remove.
11528 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11529 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11530
a28d4396
KH
115312011-05-18 Kenichi Handa <handa@m17n.org>
11532
11533 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11534 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11535 (find_automatic_composition): Mostly rewrite for efficiency.
11536
a2b1fa8e
JB
115372011-05-18 Juanma Barranquero <lekktu@gmail.com>
11538
11539 * makefile.w32-in: Update dependencies.
11540
8e1f5610
CS
115412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11542
11543 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11544 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11545
7025ee00 115462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11547
cdfa6eab
PE
11548 Fix some integer overflow issues, such as string length overflow.
11549
06d6db33
PE
11550 * insdel.c (count_size_as_multibyte): Check for string overflow.
11551
2b4560a8
PE
11552 * character.c (lisp_string_width): Check for string overflow.
11553 Use EMACS_INT, not int, for string indexes and lengths; in
11554 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11555 the resulting string length overflows an EMACS_INT; instead,
11556 report a string overflow if no precision given. When checking for
11557 precision exhaustion, use a check that cannot possibly have
11558 integer overflow. (Bug#8675)
11559 * character.h (lisp_string_width): Adjust to new signature.
11560
cb93f9be
PE
11561 * alloc.c (string_overflow): New function.
11562 (Fmake_string): Use it. This doesn't change behavior, but saves
11563 a few bytes and will simplify future changes.
11564 * character.c (string_escape_byte8): Likewise.
11565 * lisp.h (string_overflow): New decl.
11566
1a1f3366
PE
11567 Fixups, following up to the user-interface timestamp change.
11568 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11569 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11570 * msdos.c (mouse_get_pos): Likewise.
11571 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11572 * w32gui.h (Time): Define by including "systime.h" rather than by
11573 declaring it ourselves. (Bug#8664)
11574
d4e3e4d3
PE
11575 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11576 * image.c (clear_image_cache): Likewise.
11577
f6a24d19
PE
11578 * term.c (term_mouse_position): Don't assume time_t wraparound.
11579
08dc5ae6
PE
11580 Be more systematic about user-interface timestamps.
11581 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11582 and sometimes 'EMACS_UINT', to represent these timestamps.
11583 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11584 This makes the code easier to follow, and makes it easier to catch
11585 integer overflow bugs such as Bug#8664.
11586 * frame.c (Fmouse_position, Fmouse_pixel_position):
11587 Use Time, not unsigned long, for user-interface timestamps.
11588 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11589 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11590 * keyboard.h (last_event_timestamp): Likewise.
11591 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11592 * menu.h (xmenu_show): Likewise.
11593 * term.c (term_mouse_position): Likewise.
11594 * termhooks.h (struct input_event.timestamp): Likewise.
11595 (struct terminal.mouse_position_hook): Likewise.
11596 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11597 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11598 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11599 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11600 what it was before.
11601 * menu.h, termhooks.h: Include "systime.h", for Time.
11602
8e55734a
PE
11603 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11604 Don't assume that the difference between two unsigned long values
11605 can fit into an integer. At this point, we know button_down_time
11606 <= event->timestamp, so the difference must be nonnegative, so
11607 there's no need to cast the result if double-click-time is
11608 nonnegative, as it should be; check that it's nonnegative, just in
11609 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11610 apart (about 25 days). (Bug#8664)
8e55734a 11611
841f1b75 11612 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11613 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11614
3e26f69c
PE
11615 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11616 that always fit in int. Use a sentinel instead of a counter, to
11617 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11618 * frame.h (struct frame): Use int for menu_bar_items_used
11619 instead of EMACS_INT, since it always fits in int.
3e26f69c 11620
5cc152c0
PE
11621 * menu.c (grow_menu_items): Check for int overflow.
11622
d89eb65e
PE
11623 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11624
5235bd3e
PE
11625 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11626 Before, the code was not consistent. These values cannot exceed
11627 2**31 - 1 so there's no need to make them unsigned.
11628 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11629 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11630 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11631 as modifiers.
11632 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11633
bc827e23
PE
11634 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11635 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11636 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11637 presumably because the widths might not match.
11638
78eb494e
PE
11639 * window.c (size_window): Avoid needless test at loop start.
11640
04f2d78b
CB
116412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11642
11643 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11644
d2fc7e3d 116452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11646
11647 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11648
d2fc7e3d 116492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11650
11651 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11652 `width' to `bar_area_x' and `bar_area_width', respectively.
11653 (x_scroll_run): Take account of fringe background extension.
11654
04f2d78b
CB
11655 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11656 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11657 `bar_area_width', respectively.
11658 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11659 background extension.
11660
79b70037
GM
116612011-05-10 Jim Meyering <meyering@redhat.com>
11662
11663 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11664
2f142cc5
JB
116652011-05-10 Juanma Barranquero <lekktu@gmail.com>
11666
11667 * image.c (Finit_image_library): Return t for built-in image types,
11668 like pbm and xbm. (Bug#8640)
11669
57679c86
AS
116702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11671
11672 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11673
888c9e86
EZ
116742011-05-07 Eli Zaretskii <eliz@gnu.org>
11675
b0512a1d
EZ
11676 * w32console.c (Fset_screen_color): Doc fix.
11677 (Fget_screen_color): New function.
11678 (syms_of_ntterm): Defsubr it.
11679
7285dc67
EZ
11680 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11681 unlink the temporary file if Fcall_process didn't create it in the
11682 first place.
11683 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11684 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11685 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11686 cue to call_process_cleanup not to close that handle.
11687
4d3fcc8e
BK
116882011-05-07 Ben Key <bkey76@gmail.com>
11689
11690 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11691 one of two shell specific rules, either bootstrap-temacs-CMD or
11692 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11693 to the previous implementation of the bootstrap-temacs rule.
11694 The bootstrap-temacs-CMD rule is similar to the previous
11695 implementation of the bootstrap-temacs rule except that it
11696 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11697 variable.
11698
11699 These changes, along with some changes to nt/configure.bat,
11700 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11701 earlier fix to add support for --cflags and --ldflags options
11702 that include quotes so that it works whether make uses cmd or
11703 sh as the shell.
11704
b4289b64
MA
117052011-05-06 Michael Albinus <michael.albinus@gmx.de>
11706
11707 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11708 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11709 is a constant.
11710 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11711 a string. Handle both cases.
11712 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11713 (Fdbus_register_method): Use Qinvalid_function.
11714
af4c0e28
JB
117152011-05-06 Juanma Barranquero <lekktu@gmail.com>
11716
11717 * makefile.w32-in: Update dependencies.
11718 (LISP_H): Add inttypes.h and stdin.h.
11719 (PROCESS_H): Add unistd.h.
11720
c51453d9
EZ
117212011-05-06 Eli Zaretskii <eliz@gnu.org>
11722
11723 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11724 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11725
8ff0ac3c 117262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11727
4c4b566b
PE
11728 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11729
aab2b9b5
PE
11730 * term.c (vfatal): Remove stray call to va_end.
11731 It's not needed and the C Standard doesn't allow it here anyway.
11732
c378da0b
PE
11733 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11734 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11735
288b08c7
PE
11736 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11737 bytes.
11738
e3601888
PE
11739 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11740
db6c0e74
PE
11741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11742
dd5963ea
PE
11743 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11744
88c9450f
PE
11745 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11746
2f9442b8
PE
11747 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11748
c032b5f8
PE
11749 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11750 * charset.c (Fdefine_charset_internal): Don't initialize
11751 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11752 32-bit int (Bug#8600).
a108c10b
PE
11753
11754 * lread.c (read_integer): Be more consistent with string-to-number.
11755 Use string_to_number to do the actual conversion; this avoids
11756 rounding errors and fixes some other screwups. Without this fix,
11757 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11758 (digit_to_number): Move earlier, for benefit of read_integer.
11759 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11760 not a digit in any supported base. (Bug#8602)
a108c10b 11761
ad5f9eea
PE
11762 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11763
aec1708a
PE
11764 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11765 to match comment at start of function. This also removes a
11766 GCC warning about overflow in a 32+64-bit port.
11767
47be4ab5
PE
11768 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11769
371cac43
PE
11770 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11771 Reported by Stefan Monnier in
11772 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11774 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11775
d01a7826
PE
11776 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11777 (EMACS_UINTPTR): Likewise, with uintptr_t.
11778
7fd47d5c
PE
11779 * lisp.h: Prefer 64-bit EMACS_INT if available.
11780 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11781 on 32-bit hosts that have 64-bit int, so that they can access
11782 large files.
122b0c86
PE
11783 However, temporarily disable this change unless the temporary
11784 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11785
8727937b
PE
11786 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11787
8ac068ac
PE
11788 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11789 This removes an assumption that EMACS_INT and long are the same
11790 width as pointers. The assumption is true for Emacs porting targets
11791 now, but we want to make other targets possible.
11792 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11793 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11794 In the rest of the code, change types of integers that hold casted
11795 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11796 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11797 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11798 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11799 No need to cast type when ORing.
11800 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11801 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11802 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11803 assume EMACS_INT is the same width as char *.
11804 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11805 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11806 Remove no-longer-needed casts.
11807 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11808 (xg_tool_bar_help_callback, xg_make_tool_item):
11809 Use EMACS_INTPTR to hold an integer
11810 that will be cast to void *; this can avoid a GCC warning
11811 if EMACS_INT is not the same width as void *.
11812 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11813 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11814 (current_message_1, set_message_1):
11815 Use a local to convert to proper width without a cast.
11816 * xmenu.c (dialog_selection_callback): Likewise.
11817
ede49d71
PE
11818 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11819 Also, don't assume VALBITS / RAND_BITS is less than 5,
11820 and don't rely on undefined behavior when shifting a 1 left into
11821 the sign bit.
11822 * lisp.h (get_random): Change signature to match.
11823
2f30ecd0
PE
11824 * lread.c (hash_string): Use size_t, not int, for hash computation.
11825 Normally we prefer signed values; but hashing is special, because
11826 it's better to use unsigned division on hash table sizes so that
11827 the remainder is nonnegative. Also, size_t is the natural width
11828 for hashing into memory. The previous code used 'int', which doesn't
11829 retain enough info to hash well into very large tables.
11830 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11831
2a866e7b
PE
11832 * dbusbind.c: Don't possibly lose pointer info when converting.
11833 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11834 Use XPNTR rather than XHASH, so that the high-order bits of
11835 the pointer aren't lost when converting through void *.
11836
51639eac
PE
11837 * eval.c (Fautoload): Don't double-shift a pointer.
11838
92394119
PE
11839 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11840
dbdb9a7c
JB
118412011-05-06 Juanma Barranquero <lekktu@gmail.com>
11842
11843 * gnutls.c (DEF_GNUTLS_FN):
11844 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11845
db7a0b4f
AS
118462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11847
11848 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11849 marker. (Bug#8610)
11850
cd394be1 118512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11852
11853 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11854 New version that can reserve upto 2GB of heap space.
11855
f7ff1b0f 118562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11857
11858 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11859
639c109b
TZ
118602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11861
11862 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11863 `gnutls_certificate_set_x509_key_file'.
11864
d2127135
JB
118652011-05-05 Juanma Barranquero <lekktu@gmail.com>
11866
11867 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11868 Update dependencies.
11869
e968f4f3
JB
118702011-05-04 Juanma Barranquero <lekktu@gmail.com>
11871
11872 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11873 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11874 Remove unused parameter `fildes'.
11875 * process.c (read_process_output, send_process): Don't pass it.
11876
84d358f0
JB
118772011-05-04 Juanma Barranquero <lekktu@gmail.com>
11878
11879 Fix previous change: the library cache is defined in w32.c.
11880 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11881 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11882
0898ca10
JB
118832011-05-04 Juanma Barranquero <lekktu@gmail.com>
11884
11885 Implement dynamic loading of GnuTLS on Windows.
11886
11887 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11888 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11890 Declare.
11891
11892 * gnutls.c (Qgnutls_dll): Define.
11893 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11894 (gnutls_*): Declare function pointers.
11895 (init_gnutls_functions): New function to initialize function pointers.
11896 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11897 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11898 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11899 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11900 (emacs_gnutls_write, emacs_gnutls_read)
11901 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11902 (Fgnutls_available_p): New function.
11903 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11904 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11905 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11906
11907 * image.c: Include w32.h.
11908 (Vimage_type_cache): Delete.
11909 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11910 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11911 (w32_delayed_load): Move to w32.c.
11912
11913 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11914
11915 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11916 (w32_delayed_load): Move from image.c. When loading a library, record
11917 its filename in the :loaded-from property of the library id.
11918 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11919 Initialize and staticpro them.
11920 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11921
11922 * process.c: Include lisp.h before w32.h, not after.
11923 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11924 instead of gnutls_record_check_pending.
11925
11926 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11927
ff4de4aa
TZ
119282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11929
11930 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11931 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11932 as passed in.
11933
abe95abb
JD
119342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11935
11936 * xterm.c (x_set_frame_alpha): Do not set property on anything
11937 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11938
e16e55d4
JB
119392011-05-02 Juanma Barranquero <lekktu@gmail.com>
11940
11941 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11942
bafcf6a5
JB
119432011-05-02 Juanma Barranquero <lekktu@gmail.com>
11944
11945 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11946 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11947 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11948 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11949 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11950 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11951 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11952 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11953 (Qgnutls_bootprop_callbacks_verify): Make static.
11954
e7a6747f
AS
119552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11956
19ed11ba
AS
11957 * callproc.c: Indentation fixup.
11958
e7a6747f 11959 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11960 (wait_for_termination, interruptible_wait_for_termination):
11961 Move after wait_for_termination_1.
e7a6747f 11962
1ef14cb4
LMI
119632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11964
11965 * sysdep.c (interruptible_wait_for_termination): New function
11966 which is like wait_for_termination, but allows keyboard
11967 interruptions.
11968
11969 * callproc.c (Fcall_process): Add (:file "file") as an option for
11970 the STDOUT buffer.
11971 (Fcall_process_region): Ditto.
11972
330d880c
EZ
119732011-04-30 Eli Zaretskii <eliz@gnu.org>
11974
8db90b73
EZ
11975 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11976 rather than `XVECTOR (FOO)->size'.
11977
330d880c
EZ
11978 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11979 inttypes.h, as a gnulib replacement is used if it not available in
11980 system headers.
11981
15cbd324
EZ
119822011-04-21 Eli Zaretskii <eliz@gnu.org>
11983
11984 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11985 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11986 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11987
11988 * coding.c (coding_alloc_by_realloc): Error out if destination
11989 will grow beyond MOST_POSITIVE_FIXNUM.
11990 (decode_coding_emacs_mule): Abort if there isn't enough place in
11991 charbuf for the composition carryover bytes. Reserve an extra
11992 space for up to 2 characters produced in a loop.
11993 (decode_coding_iso_2022): Abort if there isn't enough place in
11994 charbuf for the composition carryover bytes.
11995
119962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11997
ae940cca
EZ
11998 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11999 aborting when %lld or %lll format is passed.
12000 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12001 %llo or %llx format is passed. (Bug#8545)
12002
03ab8921
EZ
12003 * window.c (window_scroll_line_based): Use a marker instead of
12004 simple variables to record original value of point. (Bug#7952)
12005
afda1437
EZ
12006 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12007 produced by %s or %c overflows available buffer space. (Bug#8545)
12008
f76dee0c
PE
120092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12010
12011 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12012 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12013
fdc5744d
JB
120142011-04-28 Juanma Barranquero <lekktu@gmail.com>
12015
12016 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12017
638f053a
JB
120182011-04-28 Juanma Barranquero <lekktu@gmail.com>
12019
12020 * keyboard.c (Qdelayed_warnings_hook): Define.
12021 (command_loop_1): Run `delayed-warnings-hook'
12022 if Vdelayed_warnings_list is non-nil.
12023 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12024 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12025
d178f871
EZ
120262011-04-28 Eli Zaretskii <eliz@gnu.org>
12027
12028 * doprnt.c (doprnt): Don't return value smaller than the buffer
12029 size if the message was truncated. (Bug#8545).
12030
b124fd93
JB
120312011-04-28 Juanma Barranquero <lekktu@gmail.com>
12032
12033 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12034 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12035
e810457d
PE
120362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12037
12038 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12039
ea51cceb
JB
120402011-04-27 Juanma Barranquero <lekktu@gmail.com>
12041
12042 * makefile.w32-in: Update dependencies.
12043
94dcfacf
EZ
120442011-04-27 Eli Zaretskii <eliz@gnu.org>
12045
12046 Improve `doprnt' and its usage. (Bug#8545)
12047 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12048 `format_end'. Remove support for %l as a conversion specifier.
12049 Don't use xrealloc. Improve diagnostics when the %l size modifier
12050 is used. Update the commentary.
12051
12052 * eval.c (verror): Simplify calculation of size_t.
12053
12054 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12055 messages.
12056
f61f41d7
PE
120572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12058
12059 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12060 change.
12061
96fb4434
PE
120622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12063
12064 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12065 This makes this file independent of the recent pseudovector change.
12066
671875da 120672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12068
69e9b5a3
PE
12069 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12070
b5f869a7 12071 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12072 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12073 Remove unused local.
c8926152 12074 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12075
841a1577 12076 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12077 GCC 4.6.0 optimizes based on type-based alias analysis.
12078 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12079 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12080 != &v->size, and therefore "v->size = 1; b->size = 2; return
12081 v->size;" must therefore return 1. This assumption is incorrect
12082 for Emacs, since it type-puns struct Lisp_Vector * with many other
12083 types. To fix this problem, this patch adds a new type struct
f904488f 12084 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12085 and pseudovectors, and helps optimizing compilers not get fooled
12086 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12087 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12088 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12089 the size member.
eab3844f
PE
12090 (XSETPVECTYPE): Rewrite in terms of new macro.
12091 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12092 This is a bit clearer, and further avoids the possibility of
12093 undesirable aliasing.
12094 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12095 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12096 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12097 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12098 (ASIZE): Now uses header.size rather than size.
12099 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12100 to avoid the hassle of writing XVECTOR (foo)->header.size.
12101 (struct vectorlike_header): New type.
eab3844f
PE
12102 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12103 object, to help avoid aliasing.
12104 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12105 (SUBRP): Likewise, since Lisp_Subr is a special case.
12106 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12107 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12108 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12109 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12110 changed to be "header.size" and "header.next".
12111 * buffer.h (struct buffer): Likewise.
12112 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12113 * frame.h (struct frame): Likewise.
12114 * process.h (struct Lisp_Process): Likewise.
12115 * termhooks.h (struct terminal): Likewise.
12116 * window.c (struct save_window_data, struct saved_window): Likewise.
12117 * window.h (struct window): Likewise.
12118 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12119 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12120 * buffer.c (init_buffer_once): Likewise.
12121 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12122 special case.
12123 * process.c (Fformat_network_address): Use local var for size,
12124 for brevity.
12125
0df1eac5
PE
12126 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12127
847ab9d1 12128 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12129 * data.c (atof): Remove decl; no longer used or needed.
12130 (digit_to_number): Move to lread.c.
12131 (Fstring_to_number): Use new string_to_number function, to be
12132 consistent with how the Lisp reader treats infinities and NaNs.
12133 Do not assume that floating-point numbers represent EMACS_INT
12134 without losing information; this is not true on most 64-bit hosts.
12135 Avoid double-rounding errors, by insisting on integers when
12136 parsing non-base-10 numbers, as the documentation specifies.
12137 * lisp.h (string_to_number): New decl, replacing ...
12138 (isfloat_string): Remove.
bc0a5c13 12139 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12140 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12141 appears to have been a coding error. Similarly, do not accept
12142 strings like +-1e0 as floating point numbers. Do not report
12143 overflow for integer overflows unless the base is not 10 which
12144 means we have no simple and reliable way to continue.
12145 Break out the floating-point parsing into a new
12146 function string_to_number, so that Fstring_to_number parses
12147 floating point numbers consistently with the Lisp reader.
04f2d78b 12148 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12149 (E_CHAR, EXP_INT): Remove, replacing with ...
12150 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12151 (string_to_number): New function, replacing isfloat_string.
12152 This function checks for valid syntax and produces the resulting
12153 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12154 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12155 so that overflow for non-base-10 numbers is reported only when
12156 there's no portable and simple way to convert to floating point.
452f4150 12157
67769ffc
PE
12158 * textprop.c (set_text_properties_1): Rewrite for clarity,
12159 and to avoid GCC warning about integer overflow.
12160
c20db43f
PE
12161 * intervals.h (struct interval): Use EMACS_INT for members
12162 where EMACS_UINT might cause problems. See
12163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12164 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12165 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12166 All uses changed.
37aa2f85
PE
12167 (offset_intervals): Tell GCC not to worry about length overflow
12168 when negating a negative length.
c20db43f 12169
2538aa2f
PE
12170 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12171 (overrun_check_free): Likewise.
12172
f2d3008d
PE
12173 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12174 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12175 word size.
12176
ec8df744
PE
12177 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12178 (gnutls_make_error): Rename local to avoid shadowing.
12179 (gnutls_emacs_global_deinit): ifdef out; not used.
12180 (Fgnutls_boot): Use const for pointer to readonly storage.
12181 Comment out unused local. Fix pointer signedness problems.
12182
640ee02d
PE
12183 * lread.c (openp): Don't stuff size_t into an 'int'.
12184 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12185 about possible signed overflow.
12186
6048fb2a
PE
12187 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12188 (GDK_KEY_g): Don't define if already defined.
12189 (xg_prepare_tooltip): Avoid pointer signedness problem.
12190 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12191
fa3c87e1
PE
12192 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12193 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12194
2172544b
PE
12195 * xfns.c (Fx_window_property): Simplify a bit,
12196 to make a bit faster and to avoid GCC 4.6.0 warning.
12197 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12198
9b821a21
PE
12199 * fns.c (internal_equal): Don't assume size_t fits in int.
12200
3c616cfa
PE
12201 * alloc.c (compact_small_strings): Tighten assertion a little.
12202
c2982e87
PE
12203 Replace pEd with more-general pI, and fix some printf arg casts.
12204 * lisp.h (pI): New macro, generalizing old pEd macro to other
12205 conversion specifiers. For example, use "...%"pI"d..." rather
12206 than "...%"pEd"...".
12207 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12208 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12209 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12210 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12211 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12212 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12213 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12214 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12215 64-bit hosts.
12216 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12217 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12218 * print.c (safe_debug_print, print_object): Likewise.
12219 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12220 to int.
6f04d126
PE
12221 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12222 avoiding the 0 flag, which is not portable.
c2982e87
PE
12223 * process.c (Fmake_network_process): Use pI to avoid cast.
12224 * region-cache.c (pp_cache): Likewise.
12225 * xdisp.c (decode_mode_spec): Likewise.
12226 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12227 behavior on 64-bit hosts with printf arg.
6f04d126 12228 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12229 (x_stop_queuing_selection_requests): Likewise.
12230 (x_get_window_property): Don't truncate byte count to an 'int'
12231 when tracing.
0b432f21 12232
5e073ec7
PE
12233 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12234 here, since it parses constructs like leading '-' and spaces,
12235 which are not wanted; and it overflows with large numbers.
12236 Instead, simply match F[0-9]+, which is what is wanted anyway.
12237
36372bf9
PE
12238 * alloc.c: Remove unportable assumptions about struct layout.
12239 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12240 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12241 (allocate_vectorlike, make_pure_vector): Use the new macros,
12242 plus offsetof, to remove unportable assumptions about struct layout.
12243 These assumptions hold on all porting targets that I know of, but
12244 they are not guaranteed, they're easy to remove, and removing them
12245 makes further changes easier.
12246
0b432f21
PE
12247 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12248 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12249 (string_overrun_cookie): Now const. Use initializers that
12250 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12251 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12252 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12253 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12254 multiple of sizeof (EMACS_INT); it need not be, if
12255 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12256 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12257
895009e1
JB
122582011-04-26 Juanma Barranquero <lekktu@gmail.com>
12259
12260 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12261
6a7a1b0b
TZ
122622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12263
12264 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12265 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12266 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12267
841a1577 122682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12269
12270 * lisp.h (Qdebug): List symbol.
895009e1 12271 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12272 * keyboard.c (debug-on-event): New variable.
12273 (handle_user_signal): Break into debugger when debug-on-event
12274 matches the current signal symbol.
12275
f2d3ba6f
DN
122762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12277
12278 * alloc.c (check_sblock, check_string_bytes)
12279 (check_string_free_list): Convert to standard C.
12280
42ce4c63
TZ
122812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12282
12283 * w32.c (emacs_gnutls_push): Fix typo.
12284
825cd63c
EZ
122852011-04-25 Eli Zaretskii <eliz@gnu.org>
12286
fb11d64d
EZ
12287 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12288 "cast to pointer from integer of different size".
12289
825cd63c
EZ
12290 Improve doprnt and its use in verror. (Bug#8545)
12291 * doprnt.c (doprnt): Document the set of format control sequences
12292 supported by the function. Use SAFE_ALLOCA instead of always
12293 using `alloca'.
12294
12295 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12296 is one byte too soon. Don't use xrealloc; instead xfree and
12297 xmalloc anew.
12298
e061a11b
TZ
122992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12300
12301 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12302 callbacks stage.
12303
12304 * gnutls.c: Renamed global_initialized to
12305 gnutls_global_initialized. Added internals for the
12306 :verify-hostname-error, :verify-error, and :verify-flags
12307 parameters of `gnutls-boot' and documented those parameters in the
12308 docstring. Start callback support.
9173deec
JB
12309 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12310 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12311 on error. Return error code.
e061a11b
TZ
12312 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12313 (emacs_gnutls_read): Likewise.
12314 (Fgnutls_boot): Return handshake error code.
12315 (emacs_gnutls_handle_error): New function.
12316 (wsaerror_to_errno): Likewise.
12317
12318 * w32.h (emacs_gnutls_pull): Add prototype.
12319 (emacs_gnutls_push): Likewise.
12320
12321 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12322 (emacs_gnutls_push): Likewise.
12323
123242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12325
12326 * process.c (wait_reading_process_output): Check if GnuTLS
12327 buffered some data internally if no FDs are set for TLS
12328 connections.
12329
12330 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12331 (LIBS): Link to USER_LIBS.
12332 ($(BLD)/gnutls.$(0)): New target.
12333
fa6996bc
EZ
123342011-04-24 Eli Zaretskii <eliz@gnu.org>
12335
eb35682e
EZ
12336 * xdisp.c (handle_single_display_spec): Rename the
12337 display_replaced_before_p argument into display_replaced_p, to
12338 make it consistent with the commentary. Fix typos in the
12339 commentary.
12340
e2ad650c
EZ
12341 * textprop.c (syms_of_textprop): Remove dead code.
12342 (copy_text_properties): Delete obsolete commentary about an
12343 interface that was deleted long ago. Fix typos in the description
12344 of arguments.
12345
1b2de274
EZ
12346 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12347 to changes in oldXMenu/XMenu.h from 2011-04-16.
12348 <menu_help_message, prev_menu_help_message>: Constify.
12349 (IT_menu_make_room): menu->help_text is now `const char **';
12350 adjust.
12351
12352 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12353 to changes in oldXMenu/XMenu.h from 2011-04-16.
12354 (struct XMenu): Declare `help_text' `const char **'.
12355
12356 * xfaces.c <Qunspecified>: Make extern again.
12357
12358 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12359 required by POSIX.
1b2de274 12360
762b15be
EZ
12361 * doc.c (get_doc_string): Improve the format passed to `error'.
12362
12363 * doprnt.c (doprnt): Improve commentary.
12364
12365 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12366
12367 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12368 them with etags.
12369
f1052e5d
EZ
12370 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12371 changes in globals.h immediately force recompilation.
762b15be
EZ
12372 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12373 $(CURDIR)/s/ms-w32.h.
12374 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12375
fa6996bc
EZ
12376 * character.c (Fchar_direction): Function deleted.
12377 (syms_of_character): Don't defsubr it.
12378 <char-direction-table>: Deleted.
12379
e6c3da20
EZ
123802011-04-23 Eli Zaretskii <eliz@gnu.org>
12381
12382 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12383 * doprnt.c: Include limits.h.
12384 (SIZE_MAX): New macro.
04f2d78b
CB
12385 (doprnt): Return a size_t value. 2nd arg is now size_t.
12386 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12387 Improve overflow protection. Support `l' modifier for integer
12388 conversions. Support %l conversion. Don't assume an EMACS_INT
12389 argument for integer conversions and for %c.
12390
12391 * lisp.h (doprnt): Restore prototype.
12392
12393 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12394 $(SRC)/character.h.
12395
12396 * Makefile.in (base_obj): Add back doprnt.o.
12397
12398 * deps.mk (doprnt.o): Add back prerequisites.
12399 (callint.o): Depend on character.h.
12400
12401 * eval.c (internal_lisp_condition_case): Include the handler
12402 representation in the error message.
12403 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12404 when breaking from the loop.
12405
12406 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12407
12408 * callint.c (Fcall_interactively): When displaying error message
12409 about invalid control letter, pass the character's codepoint, not
12410 a pointer to its multibyte form. Improve display of the character
12411 in octal and display also its hex code.
12412
12413 * character.c (char_string): Use %x to display the (unsigned)
12414 codepoint of an invalid character, to avoid displaying a bogus
12415 negative value.
12416
12417 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12418 `error', not SYMBOL_NAME itself.
12419
12420 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12421 character arguments to `error'.
12422
12423 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12424 to `error' in error message about FINAL_CHAR argument. Make sure
12425 FINAL_CHAR is a character, and use %c when it is passed as
12426 argument to `error'.
12427
4ffd0d6b 124282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12429
12430 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12431
12432 * w32.c: Include <time.h>.
12433 (sys_localtime): New function.
12434
4ffd0d6b 124352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12436
12437 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12438
4ffd0d6b 12439 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12440
4ffd0d6b 124412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12442
4ffd0d6b
GM
12443 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12444 zombies (Bug#8467).
aac0c6e3 12445
04c56954
EZ
124462011-04-19 Eli Zaretskii <eliz@gnu.org>
12447
12448 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12449 gl_state.e_property when gl_state.object is Qt.
12450
12451 * insdel.c (make_gap_larger): Remove limitation of buffer size
12452 to <= INT_MAX.
12453
16a43933
CY
124542011-04-18 Chong Yidong <cyd@stupidchicken.com>
12455
12456 * xdisp.c (lookup_glyphless_char_display)
12457 (produce_glyphless_glyph): Handle cons cell entry in
12458 glyphless-char-display.
12459 (Vglyphless_char_display): Document it.
12460
12461 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12462 glyphless-char-display.
12463
4581706e
CY
124642011-04-17 Chong Yidong <cyd@stupidchicken.com>
12465
12466 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12467
12468 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12469
12470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12471 definition for no-X builds.
12472
4887c6e2 124732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12474
fd35b6f9
PE
12475 Static checks with GCC 4.6.0 and non-default toolkits.
12476
5c1ccb01
PE
12477 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12478
006c5daa
PE
12479 * process.c (keyboard_bit_set): Define only if SIGIO.
12480 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12481 (send_process): Repair possible setjmp clobbering.
12482
efc736d3
PE
12483 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12484
4e2fe2e6
PE
12485 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12486
f97334a2
PE
12487 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12488
4e75f29d
PE
12489 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12490 Define only if needed.
12491
90efadd1
PE
12492 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12493 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12494 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12495
3c647824
PE
12496 * dispextern.h (struct redisplay_interface): Rename param
12497 to avoid shadowing.
e264f262 12498 * termhooks.h (struct terminal): Likewise.
761383f4 12499 * xterm.c (xembed_send_message): Likewise.
3c647824 12500
b58c5c4a
PE
12501 * insdel.c (make_gap_smaller): Define only if
12502 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12503
cad59032
PE
12504 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12505 it.
12506
c339dc2e
PE
12507 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12508 so that we aren't warned about unused symbols.
12509
91a3e27b
PE
12510 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12511
399c71d3 12512 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12513
8ffc96f5
PE
12514 * xfns.c (x_real_positions): Mark locals as initialized.
12515
eef9bc79
PE
12516 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12517
098db9dd
PE
12518 * xterm.c: Fix problems found by static analysis with other toolkits.
12519 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12520 (x_dispatch_event): Declare static if USE_GTK, and
12521 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12522 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12523 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12524 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12525 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12526
eb18f6cc
PE
12527 * xmenu.c (menu_help_callback): Pointer type fixes.
12528 Use const pointers when pointing at readonly data. Avoid pointer
12529 signedness clashes.
12530 (FALSE): Remove unused macro.
12531 (update_frame_menubar): Remove unused decl.
12532
1fe72bf8
PE
12533 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12534
60d9e1db
PE
12535 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12536 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12537 (single_menu_item): Rename local to avoid shadowing.
12538
39261c26
PE
12539 * keyboard.c (make_lispy_event): Remove unused local var.
12540
018c5e19
PE
12541 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12542 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12543
63d2b86e
PE
12544 * bitmaps: Change bitmaps from unsigned char back to the X11
12545 compatible char. Avoid the old compiler warnings about
12546 out-of-range initializers by using, for example, '\xab' rather
12547 than 0xab.
12548
aefd87e1
PE
12549 * xgselect.c (xgselect_initialize): Check vs interface
12550 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12551
bf501fb9
PE
12552 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12553
e9829fdf
PE
12554 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12555 to read-only memory.
12556
1086c095
PE
12557 * fns.c (vector): Remove; this old hack is no longer needed.
12558
2baccd04 12559 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12560 Remove unused var.
dde42981 12561 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12562
72391843 12563 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12564
436c16df 12565 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12566 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12567 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12568
92bb796d 12569 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12570 (x_term_init): Remove local to avoid shadowing.
92bb796d 12571
764430a3 12572 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12573
12574 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12575 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12576
d1dfb56c
EZ
125772011-04-16 Eli Zaretskii <eliz@gnu.org>
12578
c4354cb4
EZ
12579 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12580
d1dfb56c
EZ
12581 Fix regex.c, syntax.c and friends for buffers > 2GB.
12582 * syntax.h (struct gl_state_s): Declare character position members
12583 EMACS_INT.
12584
12585 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12586
04f2d78b
CB
12587 * textprop.c (verify_interval_modification, interval_of):
12588 Declare arguments EMACS_INT.
d1dfb56c
EZ
12589
12590 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12591 EMACS_INT.
12592
12593 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12594
12595 * indent.c (Fvertical_motion): Local variable it_start is now
12596 EMACS_INT.
12597
12598 * regex.c (re_match, re_match_2, re_match_2_internal)
12599 (bcmp_translate, regcomp, regexec, print_double_string)
12600 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12601 (re_compile_pattern, re_exec): Declare arguments and local
12602 variables `size_t' and `ssize_t' and return values `regoff_t', as
12603 appropriate.
12604 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12605 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12606 <compile_stack_type>: `size' and `avail' are now `size_t'.
12607
12608 * regex.h <regoff_t>: Use ssize_t, not int.
12609 (re_search, re_search_2, re_match, re_match_2): Arguments that
12610 specify buffer/string position and length are now ssize_t and
12611 size_t. Return type is regoff_t.
12612
613052cd
BK
126132011-04-16 Ben Key <bkey76@gmail.com>
12614
12615 * nsfont.m: Fixed bugs in ns_get_family and
12616 ns_descriptor_to_entity that were caused by using free to
12617 deallocate memory blocks that were allocated by xmalloc (via
12618 xstrdup). This caused Emacs to crash when compiled with
12619 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12620 --enable-checking=xmallocoverrun). xfree is now used to
12621 deallocate these memory blocks.
12622
4170f62f 126232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12624
71b41406
PE
12625 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12626
9587a89d
PE
12627 emacs_write: Accept and return EMACS_INT for sizes.
12628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12629 et seq.
12630 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12631 Accept and return EMACS_INT.
12632 (emacs_gnutls_write): Return the number of bytes written on
12633 partial writes.
12634 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12635 (emacs_read, emacs_write): Remove check for negative size, as the
12636 Emacs source code has been audited now.
9587a89d
PE
12637 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12638 (emacs_read, emacs_write): Use it.
273a5f82
PE
12639 * process.c (send_process): Adjust to the new signatures of
12640 emacs_write and emacs_gnutls_write. Do not attempt to store
12641 a byte offset into an 'int'; it might overflow.
9587a89d 12642 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12643
3e047f51
PE
12644 * sound.c: Don't assume sizes fit in 'int'.
12645 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12646 Return EMACS_INT, not int.
3e047f51 12647 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12648 Accept EMACS_INT, not int.
12649 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12650 record read return values.
12651
cc39a9db
BK
126522011-04-15 Ben Key <bkey76@gmail.com>
12653
c9d0ec6d
JB
12654 * keyboard.c (Qundefined): Don't declare static since it is used
12655 in nsfns.m.
12656 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12657 static since they are used in nsfont.m.
cc39a9db 12658
6c60eb9f
SM
126592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12660
12661 * process.c (Qprocessp): Don't declare static.
12662 * lisp.h (Qprocessp): Declare again.
12663
7990b61a
JB
126642011-04-15 Juanma Barranquero <lekktu@gmail.com>
12665
12666 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12667
5d4cb038
PE
126682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12669
8bd7b830 12670 Improve C-level modularity by making more things 'static'.
cd64ea1d 12671
e3b27b31
PE
12672 Don't publish debugger-only interfaces to other modules.
12673 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12674 (verify_bytepos, count_markers): Move decls to the only modules
12675 that need them.
12676 * region-cache.h (pp_cache): Likewise.
12677 * window.h (check_all_windows): Likewise.
12678 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12679
5d4cb038
PE
12680 * sysdep.c (croak): Now static, if
12681 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12682 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12683
12684 * alloc.c (refill_memory_reserve): Now static if
12685 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12686 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12687
e87b6180
PE
12688 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12689 Define only if USE_LUCID.
12690
ac64929e
PE
12691 * xrdb.c (x_customization_string, x_rm_string): Now static.
12692
6f37259d
PE
12693 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12694 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12695
1683e3ab
PE
12696 * xdisp.c (draw_row_with_mouse_face): Now static.
12697 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12698
de9c2632
PE
12699 * window.h (check_all_windows): Mark externally visible.
12700
2b96acb7
PE
12701 * window.c (window_deletion_count): Now static.
12702
12703 * undo.c: Make symbols static if they're not exported.
12704 (last_undo_buffer, last_boundary_position, pending_boundary):
12705 Now static.
12706
50436f33
PE
12707 * textprop.c (interval_insert_behind_hooks): Now static.
12708 (interval_insert_in_front_hooks): Likewise.
12709
64520e5c
PE
12710 * term.c: Make symbols static if they're not exported.
12711 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12712 (max_frame_lines, tty_set_terminal_modes):
12713 (tty_reset_terminal_modes, tty_turn_off_highlight):
12714 (get_tty_terminal): Now static.
12715 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12716 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12717 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12718 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12719 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12720
1fa53021
PE
12721 * sysdep.c: Make symbols static if they're not exported.
12722 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12723 Now static.
12724 (sigprocmask_set, full_mask): Remove; unused.
12725 (wait_debugging): Mark as visible.
12726 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12727 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12728
d4b43b22
PE
12729 * syntax.c (syntax_temp): Define only if !__GNUC__.
12730
b7c513d0
PE
12731 * sound.c (current_sound_device, current_sound): Now static.
12732
989b29ad
PE
12733 * search.c (searchbufs, searchbuf_head): Now static.
12734
13a55a78
PE
12735 * scroll.c (scroll_cost): Remove; unused.
12736 * dispextern.h (scroll_cost): Remove decl.
12737
de68a1fc
PE
12738 * region-cache.h (pp_cache): Mark as externally visible.
12739
40ccffa6
PE
12740 * process.c: Make symbols static if they're not exported.
12741 (process_tick, update_tick, create_process, chan_process):
12742 (Vprocess_alist, proc_buffered_char, datagram_access):
12743 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12744 (deactivate_process): Mark defn as static, as well as decl.
12745 * lisp.h (create_process): Remove decl.
12746 * process.h (chan_process, Vprocess_alist): Remove decls.
12747
ad64fc97
PE
12748 * print.c: Make symbols static if they're not exported.
12749 (print_depth, new_backquote_output, being_printed, print_buffer):
12750 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12751 (print_interval, print_number_index, initial_stderr_stream):
12752 Now static.
12753 * lisp.h (Fprinc): Remove decl.
12754 (debug_output_compilation_hack): Mark as externally visible.
12755
adddb265
PE
12756 * sysdep.c (croak): Move decl from here to syssignal.h.
12757 * syssignal.h (croak): Put it here, so the API can be checked when
12758 'croak' is called from dissociate_if_controlling_tty.
12759
1717ede2
PE
12760 * minibuf.c: Make symbols static if they're not exported.
12761 (minibuf_save_list, choose_minibuf_frame): Now static.
12762 * lisp.h (choose_minibuf_frame): Remove decl.
12763
fa5fb2bc
PE
12764 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12765
1e3890d1
PE
12766 * lread.c: Make symbols static if they're not exported.
12767 (read_objects, initial_obarray, oblookup_last_bucket_number):
12768 Now static.
12769 (make_symbol): Remove; unused.
12770 * lisp.h (initial_obarray, make_symbol): Remove decls.
12771
8a1414fa
PE
12772 * keyboard.c: Make symbols static if they're not exported.
12773 (single_kboard, recent_keys_index, total_keys, recent_keys):
12774 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12775 (this_single_command_key_start, echoing, last_auto_save):
12776 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12777 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12778 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12779 (Vlispy_mouse_stem, double_click_count):
12780 Now static.
12781 (force_auto_save_soon): Define only if SIGDANGER.
12782 (ignore_mouse_drag_p): Now static if
12783 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12784 (print_help): Remove; unused.
12785 (stop_character, last_timer_event): Mark as externally visible.
12786 * keyboard.h (ignore_mouse_drag_p): Declare only if
12787 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12788 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12789 * lisp.h (echoing): Remove decl.
12790 (force_auto_save_soon): Declare only if SIGDANGER.
12791 * xdisp.c (redisplay_window): Simplify code, to make it more
12792 obvious that ignore_mouse_drag_p is not accessed if !defined
12793 USE_GTK && !defined HAVE_NS.
12794
93ea6e8f
PE
12795 * intervals.c: Make symbols static if they're not exported.
12796 (merge_properties_sticky, merge_interval_right, delete_interval):
12797 Now static.
12798 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12799
77382fcc
PE
12800 * insdel.c: Make symbols static if they're not exported.
12801 However, leave prepare_to_modify_buffer alone. It's never
12802 called from outside this function, but that appears to be a bug.
12803 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12804 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12805 (adjust_after_replace_noundo): Remove; unused.
12806 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12807 (signal_before_change): Remove decls.
77382fcc 12808
9306c32e
PE
12809 * indent.c (val_compute_motion, val_vmotion): Now static.
12810
cd44d2eb
PE
12811 * image.c: Make symbols static if they're not exported.
12812 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12813 if USE_GTK.
12814 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12815 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12816
ad9a7a06
PE
12817 * fringe.c (standard_bitmaps): Now static.
12818 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12819
81626931
PE
12820 * frame.c: Make symbols static if they're not exported.
12821 (x_report_frame_params, make_terminal_frame): Now static.
12822 (get_frame_param): Now static, unless HAVE_NS.
12823 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12824 (x_get_resource_string): Remove; not used.
12825 * frame.h (make_terminal_frame, x_report_frame_params):
12826 (x_get_resource_string); Remove decls.
12827 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12828 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12829
239f9db9
PE
12830 * font.c, fontset.c: Make symbols static if they're not exported.
12831 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12832 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12833 * font.c (font_close_object): Now static.
12834 * font.h (font_close_object): Remove.
12835 * fontset.c (FONTSET_OBJLIST): Remove.
12836 (free_realized_fontset) #if-0 the body, which does nothing.
12837 (face_suitable_for_char_p): #if-0, as it's never called.
12838 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12839 * xfaces.c (face_at_string_position):
12840 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12841 since 0 is always ASCII.
12842
dfcf3579
PE
12843 * fns.c (weak_hash_tables): Now static.
12844
5045092b
PE
12845 * fileio.c: Make symbols static if they're not exported.
12846 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12847 (Vwrite_region_annotation_buffers): Now static.
12848
57a96f5c
PE
12849 * eval.c: Make symbols static if they're not exported.
12850 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12851 * lisp.h (backtrace_list): Remove decl.
12852
35f08c38
PE
12853 * emacs.c: Make symbols static if they're not exported.
12854 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12855 (fatal_error_code, fatal_error_signal_hook, standard_args):
12856 Now static.
12857 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12858 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12859 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12860 * lisp.h (fatal_error_signal_hook): Remove decl.
12861 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12862
f44bd759
PE
12863 * editfns.c: Move a (normally-unused) function to its only use.
12864 * editfns.c, lisp.h (get_operating_system_release): Remove.
12865 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12866 worth the hassle of breaking this out.
12867
b532497d
PE
12868 * xterm.c: Make symbols static if they're not exported.
12869 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12870 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12871 (x_destroy_window, x_delete_display):
12872 Now static.
12873 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12874 (x_mouse_leave): Remove; unused.
12875 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12876 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12877 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12878 Remove decls.
12879 (x_mouse_leave): Declare only if WINDOWSNT.
12880 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12881 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12882 USE_X_TOOLKIT.
12883
1675728f
PE
12884 * ftxfont.c: Make symbols static if they're not exported.
12885 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12886 HAVE_FREETYPE.
12887 * font.h (ftxfont_driver): Likewise.
12888
e4cebfca
PE
12889 * xfns.c: Make symbols static if they're not exported.
12890 (x_last_font_name, x_display_info_for_name):
12891 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12892 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12893 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12894 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12895 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12896 (last_show_tip_args): Now static.
12897 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12898 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12899 (x_screen_planes): Remove; unused.
12900 * dispextern.h (x_screen_planes): Remove decl.
12901
5bf46f05
PE
12902 * dispnew.c: Make symbols static if they're not exported.
12903 * dispextern.h (redraw_garbaged_frames, scrolling):
12904 (increment_row_positions): Remove.
12905 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12906 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12907 Now static.
12908 (redraw_garbaged_frames): Remove; unused.
12909
435f4c28
PE
12910 * xfaces.c: Make symbols static if they're not exported.
12911 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12912 Remove decls.
12913 * xterm.h (defined_color): Remove decls.
12914 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12915 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12916 (menu_face_changed_default, defined_color, free_realized_face):
12917 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12918 (ascii_face_of_lisp_face): Remove; unused.
12919
8524aef3
PE
12920 * xdisp.c: Make symbols static if they're not exported.
12921 * dispextern.h (scratch_glyph_row, window_box_edges):
12922 (glyph_to_pixel_coords, set_cursor_from_row):
12923 (get_next_display_element, set_iterator_to_next):
12924 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12925 (show_mouse_face): Remove decls
12926 * frame.h (message_buf_print): Likewise.
12927 * lisp.h (pop_message, set_message, check_point_in_composition):
12928 Likewise.
12929 * xterm.h (set_vertical_scroll_bar): Likewise.
12930 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12931 (message_buf_print, scratch_glyph_row, displayed_buffer):
12932 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12933 (get_next_display_element, show_mouse_face, window_box_edges):
12934 (frame_to_window_pixel_xy, check_point_in_composition):
12935 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12936 (glyph_to_pixel_coords): Remove; unused.
12937
16390cd2
PE
12938 * dired.c (file_name_completion): Now static.
12939
12940 * dbusbind.c (xd_in_read_queued_messages): Now static.
12941
a25f4dfa
PE
12942 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12943 * data.c (circular_list_error): Remove.
12944
14a9c8df
PE
12945 * commands.h (last_point_position, last_point_position_buffer):
12946 (last_point_position_window): Remove decls.
12947 * keyboard.c: Make these variables static.
12948
04f2d78b
CB
12949 * coding.h (coding, code_convert_region, encode_coding_gap):
12950 Remove decls.
74ab6df5
PE
12951 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12952 (iso_code_class, detect_coding, code_convert_region): Now static.
12953 (encode_coding_gap): Remove; unused.
12954
38dfbee1
PE
12955 * chartab.c (chartab_chars, chartab_bits): Now static.
12956
a2cb4e63
PE
12957 * charset.h (charset_iso_8859_1): Remove decl.
12958 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12959 Now static.
12960
127198fd
PE
12961 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12962 * ccl.c (Vccl_program_table): Now static.
12963 (check_ccl_update): Remove; unused.
12964
d85b608f
PE
12965 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12966 * category.h: ... from here.
12967 * category.c (check_category_table, set_category_set): Now static.
12968
31cd66f3
PE
12969 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12970 * lisp.h: Remove these decls.
12971
c358e587
PE
12972 * buffer.c (buffer_count): Remove unused var.
12973
e78aecca
PE
12974 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12975 so that it's not optimized away.
12976 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12977 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12978 exported only to the debugger.
12979
e192d7d3 12980 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12981 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12982
92470028
PE
12983 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12984 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12985 was inaccessible from Lisp.
12986 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12987 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12988
244ed907
PE
12989 alloc.c: Import and export fewer symbols, and remove unused items.
12990 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12991 is defined.
12992 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12993 it's not optimized away by whole-program optimization.
12994 (message_enable_multibyte, free_misc): Remove.
12995 (catchlist, handlerlist, mark_backtrace):
12996 Declare only if BYTE_MARK_STACK.
12997 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12998 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12999 (message_enable_multibyte): Remove decl.
13000 (free_misc, interval_free_list, float_block, float_block_index):
13001 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13002 (cons_free_list, last_marked_index):
13003 Now static.
13004 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13005 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13006 (mark_backtrace): Define only if BYTE_MARK_STACK.
13007 * xdisp.c (message_enable_multibyte): Now static.
13008
61c2b50e 13009 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13010 This makes it easier for human readers (and static analyzers)
13011 to see whether these variables are used from other modules.
13012 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13013 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13014 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13015 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13016 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13017 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13018 * xmenu.c, xselect.c:
13019 Declare Q* vars static if they are not used in other modules.
13020 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13021 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13022 Remove decls of unexported vars.
13023 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13024
95c82688
PE
13025 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13026
16a97296
PE
13027 Make Emacs functions such as Fatom 'static' by default.
13028 This makes it easier for human readers (and static analyzers)
13029 to see whether these functions can be called from other modules.
13030 DEFUN now defines a static function. To make the function external
13031 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13032 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13033 (Finit_image_library):
16a97296
PE
13034 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13035 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13036 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13037 Remove decls, since these functions are now static.
13038 (Funintern, Fget_internal_run_time): New decls, since these functions
13039 were already external.
95c82688 13040
16a97296
PE
13041 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13042 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13043 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13044 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13045 * keyboard.c, keymap.c, lread.c:
13046 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13047 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13048 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13049 Mark functions with DEFUE instead of DEFUN,
13050 if they are used in other modules.
13051 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13052 decls for now-static functions.
13053 * buffer.h (Fdelete_overlay): Remove decl.
13054 * callproc.c (Fgetenv_internal): Mark as internal.
13055 * composite.c (Fremove_list_of_text_properties): Remove decl.
13056 (Fcomposition_get_gstring): New forward static decl.
13057 * composite.h (Fcomposite_get_gstring): Remove decl.
13058 * dired.c (Ffile_attributes): New forward static decl.
13059 * doc.c (Fdocumntation_property): New forward static decl.
13060 * eval.c (Ffetch_bytecode): New forward static decl.
13061 (Funintern): Remove extern decl; now in .h file where it belongs.
13062 * fileio.c (Fmake_symbolic_link): New forward static decl.
13063 * image.c (Finit_image_library): New forward static decl.
13064 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13065 * intervals.h (Fprevious_property_change):
13066 (Fremove_list_of_text_properties): Remove decls.
13067 * keyboard.c (Fthis_command_keys): Remove decl.
13068 (Fcommand_execute): New forward static decl.
13069 * keymap.c (Flookup_key): New forward static decl.
13070 (Fcopy_keymap): Now static.
13071 * keymap.h (Flookup_key): Remove decl.
13072 * process.c (Fget_process): New forward static decl.
13073 (Fprocess_datagram_address): Mark as internal.
13074 * syntax.c (Fsyntax_table_p): New forward static decl.
13075 (skip_chars): Remove duplicate decl.
13076 * textprop.c (Fprevious_property_change): New forward static decl.
13077 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13078 Now internal.
13079 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13080 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13081
785bbd42
PE
13082 * editfns.c (Fformat): Remove unreachable code.
13083
8b913b57
AS
130842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13085
13086 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13087 change. (Bug#8496)
13088
a6744a35
EZ
130892011-04-13 Eli Zaretskii <eliz@gnu.org>
13090
13091 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13092 when at ZV. (Bug#8487)
13093
e7974947
AS
130942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13095
baad03f0
AS
13096 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13097 (Bug#8437)
13098 * keyboard.c (parse_tool_bar_item): Likewise.
13099 * sound.c (sound_cleanup, alsa_close): Likewise.
13100 * termcap.c (tgetent): Likewise.
13101 * xfns.c (x_default_font_parameter): Likewise.
13102 * xsettings.c (read_and_apply_settings): Likewise.
13103
e7974947
AS
13104 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13105 (overrun_check_free): Protoize.
13106
28272684
PE
131072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13108
13109 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13110 since callers should never pass a negative size.
13111 Change the signature to match that of plain 'read' and 'write'; see
13112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13113 * lisp.h: Update prototypes of emacs_write and emacs_read.
13114
11997c76
EZ
131152011-04-11 Eli Zaretskii <eliz@gnu.org>
13116
13117 * xdisp.c (redisplay_window): Don't try to determine the character
13118 position of the scroll margin if the window start point w->startp
e896f03c 13119 is outside the buffer's accessible region. (Bug#8468)
11997c76 13120
8a2cbd72
EZ
131212011-04-10 Eli Zaretskii <eliz@gnu.org>
13122
13123 Fix write-region and its subroutines for buffers > 2GB.
13124 * fileio.c (a_write, e_write): Modify declaration of arguments and
13125 local variables to support buffers larger than 2GB.
13126 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13127
13128 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13129 argument, local variables, and return value.
13130
13131 * lisp.h: Update prototypes of emacs_write and emacs_read.
13132
13133 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13134
4073e537 131352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13136
1ebfdcb6
PE
13137 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13138
b2ded58d
PE
13139 Fix more problems found by GCC 4.6.0's static checks.
13140
7d66342c
PE
13141 * xdisp.c (vmessage): Use a better test for character truncation.
13142
bbf47d44
PE
13143 * charset.c (load_charset_map): <, not <=, for optimization,
13144 and to avoid potential problems with integer overflow.
9248994d 13145 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13146 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13147 * editfns.c (Fformat): Likewise.
1e69125e 13148 * syntax.c (skip_chars): Likewise.
3befa583 13149
e3019616
PE
13150 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13151 This also lets GCC 4.6.0 generate slightly better loop code.
13152
becfa255
PE
13153 * callint.c (Fcall_interactively): <, not <=, for optimization.
13154 (Fcall_interactively): Count the number of arguments produced,
13155 not the number of arguments given. This is simpler and lets GCC
13156 4.6.0 generate slightly better code.
13157
dae0cd48
PE
13158 * ftfont.c: Distingish more carefully between FcChar8 and char.
13159 The previous code passed unsigned char * to a functions like
13160 strlen and xstrcasecmp that expect char *, which does not
13161 conform to the C standard.
13162 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13163 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13164 char * when the C standard requires it.
13165
76032d70
PE
13166 * keyboard.c (read_char): Remove unused var.
13167
eb3f1cc8
PE
13168 * eval.c: Port to Windows vsnprintf (Bug#8435).
13169 Include <limits.h>.
13170 (SIZE_MAX): Define if the headers do not.
13171 (verror): Do not give up if vsnprintf returns a negative count.
13172 Instead, grow the buffer. This ports to Windows vsnprintf, which
13173 does not conform to C99. Problem reported by Eli Zaretskii.
13174 Also, simplify the allocation scheme, by avoiding the need for
13175 calling realloc, and removing the ALLOCATED variable.
13176
70476b54
PE
13177 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13178
12020a9e
PE
13179 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13180 But keep the doprint source code for now, as we might revamp it
13181 and use it again (Bug#8435).
ea6c7ae6
PE
13182 * lisp.h (doprnt): Remove.
13183 * Makefile.in (base_obj): Remove doprnt.o.
13184 * deps.mk (doprnt.o): Remove.
13185
5fdb398c
PE
13186 error: Print 32- and 64-bit integers portably (Bug#8435).
13187 Without this change, on typical 64-bit hosts error ("...%d...", N)
13188 was used to print both 32- and 64-bit integers N, which relied on
13189 undefined behavior.
61bdb816 13190 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13191 * lisp.h (error, verror): Mark as printf-like functions.
13192 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13193 Report overflow in size calculations when allocating printf buffer.
13194 Do not truncate output string at its first null byte.
13195 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13196 Truncate the output at a character boundary, since vsnprintf does not
13197 do that.
13198 * charset.c (check_iso_charset_parameter): Convert internal
13199 character to string before calling 'error', since %c now has the
13200 printf meaning.
13201 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13202 overflow when computing char to be passed to 'error'. Do not
13203 pass Lisp_Object to 'error'; pass the integer instead.
13204 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13205 formatted with plain %d.
13206
b189fa66
PE
13207 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13208
bff87ef0
PE
13209 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13210
7e2cac20
PE
13211 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13212
ce4d90b5
PE
13213 * xterm.c (x_catch_errors): Remove duplicate declaration.
13214
266c9547
PE
13215 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13216
79c49ad2
PE
13217 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13218
368f4090
JM
132192011-04-10 Jim Meyering <meyering@redhat.com>
13220
13221 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13222 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13223 return ssize_t not "int", and use size_t as the buffer length.
13224 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13225 * gnutls.h: Update declarations.
13226 * process.c (read_process_output): Use ssize_t, to match.
13227 (send_process): Likewise.
13228
a32d4040
CY
132292011-04-09 Chong Yidong <cyd@stupidchicken.com>
13230
13231 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13232
8546720e 132332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13234
04f2d78b
CB
13235 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13236 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13237
8546720e
GM
13238 * xterm.c (handle_one_xevent):
13239 * xmenu.c (create_and_show_popup_menu):
13240 * xselect.c (x_decline_selection_request)
13241 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13242
0a2f5c1a 132432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13244
13245 Fix some uses of `int' instead of EMACS_INT.
13246 * search.c (string_match_1, fast_string_match)
13247 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13248 (scan_buffer, find_next_newline_no_quit)
13249 (find_before_next_newline, search_command, Freplace_match)
13250 (Fmatch_data): Make some `int' variables be EMACS_INT.
13251
13252 * xdisp.c (display_count_lines): 3rd argument and return value now
13253 EMACS_INT. All callers changed.
13254 (pint2hrstr): Last argument is now EMACS_INT.
13255
13256 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13257 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13258 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13259 (decode_coding_utf_16, decode_coding_emacs_mule)
13260 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13261 (decode_coding_ccl, decode_coding_charset)
13262 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13263 (decode_coding_iso_2022, decode_coding_emacs_mule)
13264 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13265 <char_offset, last_offset>: Declare EMACS_INT.
13266 (encode_coding_utf_8, encode_coding_utf_16)
13267 (encode_coding_emacs_mule, encode_invocation_designation)
13268 (encode_designation_at_bol, encode_coding_iso_2022)
13269 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13270 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13271 Declare EMACS_INT.
13272 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13273 (encode_invocation_designation): Last argument P_NCHARS is now
13274 EMACS_INT.
13275 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13276 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13277
13278 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13279 All users changed.
13280
13281 * ccl.c (Fccl_execute_on_string): Declare some variables
13282 EMACS_INT.
13283
8546720e 132842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13285
13286 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13287
4e19a977
CS
132882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13289
13290 * process.c (Fformat_network_address): Doc fix.
13291
87302331
R
132922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13293
ee7683eb 13294 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13295
cbb59342
CY
132962011-04-08 Chong Yidong <cyd@stupidchicken.com>
13297
13298 * keyboard.c (read_char): Call Lisp function help-form-show,
13299 instead of using internal_with_output_to_temp_buffer.
13300 (Qhelp_form_show): New var.
e0d38eeb 13301 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13302
13303 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13304
13305 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13306
e67a13ab
CY
133072011-04-06 Chong Yidong <cyd@stupidchicken.com>
13308
04f2d78b
CB
13309 * process.c (Flist_processes): Remove to Lisp.
13310 (list_processes_1): Delete.
e67a13ab 13311
973f782d
EZ
133122011-04-06 Eli Zaretskii <eliz@gnu.org>
13313
7c106b1e
EZ
13314 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13315
973f782d
EZ
13316 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13317
41cf7d1a 133182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13319
ca23cc88
PE
13320 Fix more problems found by GCC 4.6.0's static checks.
13321
f390e2d5
PE
13322 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13323
42eea0d0
PE
13324 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13325
b69769da 13326 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13327
f9541e84
PE
13328 * xdisp.c (vmessage): Mark as a printf-like function.
13329
13841b55
PE
13330 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13331
c136c10f
PE
13332 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13333
5e2d4a30
PE
13334 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13335 printf-like functions.
13336 (tiff_load): Add casts to remove these marks before passing them
13337 to system-supplied API.
13338
583f48b9
PE
13339 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13340
b25d760e
PE
13341 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13342 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13343 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13344 directly, rather than having caller test rule sign. This avoids
13345 some unnecessary tests.
13346 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13347 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13348 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13349
bc7b6697 13350 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13351 (xfont_open): Avoid unnecessary tests.
bc7b6697 13352
27ccc379
PE
13353 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13354
dcd5c89a
PE
13355 * composite.h, composite.c (composition_gstring_put_cache):
13356 Use EMACS_INT, not int, for length.
13357
b13a45c6
PE
13358 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13359 breaking out part of COMPOSITION_DECODE_RULE.
13360 (COMPOSITION_DECODE_RULE): Use it.
13361 * composite.c (get_composition_id): Remove unused local vars,
13362 by using the new macro.
13363
1e792e4d
PE
13364 * textprop.c (set_text_properties_1): Change while to do-while,
13365 since the condition is always true at first.
13366
dc6c6455 13367 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13368 (interval_deletion_adjustment): Return unsigned value.
13369 All uses changed.
dc6c6455 13370
aba7731a
PE
13371 * process.c (list_processes_1, create_pty, read_process_output):
13372 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13373 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13374 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13375 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13376 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13377
fdfc4bf3
PE
13378 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13379
fca8fe46 13380 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13381 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13382
06a0259a 13383 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13384 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13385 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13386
e7b9e80f
PE
13387 * print.c (print_error_message): Avoid int overflow.
13388
56201685
PE
13389 * font.c (font_list_entities): Redo for clarity,
13390 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13391
78834453 13392 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13393 (font_score): Avoid potential overflow in diff calculation.
78834453 13394
0bc0b309 13395 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13396 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13397
e610eaca
PE
13398 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13399
b895abce
PE
13400 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13401 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13402 can always succeed if overflow has undefined behavior.
13403
1f1d9321 13404 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13405 (wordify): Omit three unnecessary tests.
1f1d9321 13406
c59478bc
PE
13407 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13408 All callers changed. This avoids the need for an unused var.
13409
79b73827
PE
13410 * casefiddle.c (casify_region): Remove var that is set but not used.
13411
a4db5dfe
PE
13412 * dired.c (file_name_completion): Remove var that is set but not used.
13413
43aae36e
PE
13414 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13415
2a47c44d 13416 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13417 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13418
a37c69bf
PE
13419 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13420 Check for integer overflow on size calculations.
13421
328ab8e7
PE
13422 * buffer.c (Fprevious_overlay_change): Remove var that is set
13423 but not used.
13424
e5a2a5cb
PE
13425 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13426 Remove vars that are set but not used.
8d84a6eb 13427 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13428 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13429
a60e5f68
PE
13430 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13431
f661cb61 13432 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13433 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13434
f0397f5a
PE
13435 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13436 that are set but not used.
13437
8664db06 13438 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13439 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13440
6abdaa4a
PE
13441 * xselect.c (x_get_local_selection, x_handle_property_notify):
13442 Remove vars that are set but not used.
13443
0ce7538d 13444 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13445 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13446
9ae848fc
PE
13447 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13448 Remove var that is set but not used.
0b918413
PE
13449 (scroll_bar_windows_size): Now size_t, not int.
13450 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13451 Check for overflow.
9ae848fc 13452
a5a62657
PE
13453 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13454 (map_tty_color) [!defined MSDOS]: Likewise.
13455
5c5cdd39
PE
13456 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13457
66ebf983
PE
13458 * coding.c: Remove vars that are set but not used.
13459 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13460 All callers changed.
13461 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13462 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13463 (decode_coding_charset): Remove vars that are set but not used.
13464
1be4d761
PE
13465 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13466 that is set but not used.
13467
47553fa8
PE
13468 * print.c (print_object): Remove var that is set but not used.
13469
1f7196bf 13470 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13471 The gnulib version avoids calling malloc in the usual case,
13472 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13473 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13474 * filelock.c (current_lock_owner): Likewise.
13475 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13476 * sysdep.c: Include allocator.h, careadlinkat.h.
13477 (emacs_no_realloc_allocator): New static constant.
13478 (emacs_readlink): New function.
fdb61804
PE
13479 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13480 ../lib/careadlinkat.h.
d1fdcab7 13481
f84c17c7
SM
134822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13483
13484 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13485 first non-nil return value).
13486
ef3862ad
JD
134872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13488
13489 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13490 if not defined (Bug#8403).
13491
376a7006
JB
134922011-04-02 Juanma Barranquero <lekktu@gmail.com>
13493
13494 * xdisp.c (display_count_lines): Remove parameter `start',
13495 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13496 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13497 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13498 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13499 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13500 and thereabouts. All callers changed.
13501 (get_per_char_metric): Remove parameter `f', unused since
13502 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13503
6ca3801d
JM
135042011-04-02 Jim Meyering <meyering@redhat.com>
13505
13506 do not dereference NULL upon failed strdup
13507 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13508 (ns_get_family): Likewise.
13509
d8e2b5ba
JB
135102011-04-02 Juanma Barranquero <lekktu@gmail.com>
13511
13512 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13513
8c74fcbd
JD
135142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13515
13516 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13517 later (Bug#8403).
13518
7200d79c
SM
135192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13520
03408648 13521 Add lexical binding.
7200d79c 13522
03408648
SM
13523 * window.c (Ftemp_output_buffer_show): New fun.
13524 (Fsave_window_excursion):
13525 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13526
13527 * lread.c (lisp_file_lexically_bound_p): New function.
13528 (Fload): Bind Qlexical_binding.
13529 (readevalloop): Remove `evalfun' arg.
13530 Bind Qinternal_interpreter_environment.
13531 (Feval_buffer): Bind Qlexical_binding.
13532 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13533 Mark as dynamic.
13534 (syms_of_lread): Declare `lexical-binding'.
13535
13536 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13537
13538 * keyboard.c (eval_dyn): New fun.
13539 (menu_item_eval_property): Use it.
ca105506
SM
13540
13541 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13542
03408648
SM
13543 * fns.c (concat, mapcar1): Accept byte-code-functions.
13544
13545 * eval.c (Fsetq): Handle lexical vars.
13546 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13547 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13548 (FletX, Flet): Obey lexical binding.
13549 (Fcommandp): Handle closures.
13550 (Feval): New `lexical' arg.
13551 (eval_sub): New function extracted from Feval. Use it almost
13552 everywhere where Feval was used. Look up vars in lexical env.
13553 Handle closures.
13554 (Ffunctionp): Move from subr.el.
13555 (Ffuncall): Handle closures.
13556 (apply_lambda): Remove `eval_flags'.
13557 (funcall_lambda): Handle closures and new byte-code-functions.
13558 (Fspecial_variable_p): New function.
13559 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13560 but without exporting it to Lisp.
23aba0ea 13561
23aba0ea 13562 * doc.c (Fdocumentation, store_function_docstring):
03408648 13563 * data.c (Finteractive_form): Handle closures.
23aba0ea 13564
03408648
SM
13565 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13566 interactive spec.
ba83908c 13567
04f2d78b
CB
13568 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13569 New byte-codes.
03408648
SM
13570 (exec_byte_code): New function extracted from Fbyte_code to handle new
13571 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13572
03408648 13573 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13574
03408648 13575 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13576
e2abce01
JB
135772011-03-31 Juanma Barranquero <lekktu@gmail.com>
13578
13579 * xdisp.c (redisplay_internal): Fix prototype.
13580
63696a73 135812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13582
63696a73 13583 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13584 (try_scrolling): Use it when setting scroll_limit.
13585 Limit scrolling to 100 screen lines.
63696a73
EZ
13586 (redisplay_window): Even when falling back on "recentering",
13587 position point in the window according to scroll-conservatively,
13588 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13589
13590 (try_scrolling): When point is above the window, allow searching
13591 as far as scroll_max, or one screenful, to compute vertical
13592 distance from PT to the scroll margin position. This prevents
13593 try_scrolling from unnecessarily failing when
13594 scroll-conservatively is set to a value slightly larger than the
13595 window height. Clean up the case of PT below the margin at bottom
13596 of window: scroll_max can no longer be INT_MAX. When aggressive
13597 scrolling is in use, don't let point enter the opposite scroll
13598 margin as result of the scroll.
13599 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13600 threshold of 100 lines for never-recentering scrolling.
13601
e4cc2dfc
JB
136022011-03-31 Juanma Barranquero <lekktu@gmail.com>
13603
13604 * dispextern.h (move_it_by_lines):
13605 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13606 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13607 (message_log_check_duplicate): Remove parameters `prev_bol' and
13608 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13609 (redisplay_internal): Remove parameter `preserve_echo_area',
13610 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13611
13612 * indent.c (Fvertical_motion):
13613 * window.c (window_scroll_pixel_based, Frecenter):
13614 Don't pass `need_y_p' to `move_it_by_lines'.
13615
1c470562
SM
136162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13617
44f230aa
SM
13618 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13619 steal a few bits to be more compact.
13620 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13621 Remove unneeded casts.
13622
1c470562
SM
13623 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13624
888adce9
ZK
136252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13626
13627 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13628 binding" message (bug#7967).
13629
f838ed7b
PE
136302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13631
77861b95
PE
13632 Fix more problems found by GCC 4.6.0's static checks.
13633
de6dbc14
PE
13634 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13635 Remove unused local var.
13636
f838ed7b
PE
13637 * editfns.c (Fmessage_box): Remove unused local var.
13638
792c7b2b
PE
13639 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13640 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13641 Omit unused local vars.
c499e557 13642 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13643 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13644 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13645 Omit unused local var.
13646
ba0165e1
PE
13647 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13648 Don't assume string length fits in int.
32ad8845 13649 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13650 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13651
3c59b4c9
PE
13652 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13653 instead of alloca (Bug#8344).
13654
a3eed478 13655 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13656 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13657
eb4d412d
PE
13658 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13659
1658b401
PE
13660 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13661 concerns.
13662
13663 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13664
13665 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13666
9a2c6e05
PE
13667 * keyboard.c (syms_of_keyboard): Use the same style as later
13668 in this function when indexing through an array. This also
13669 works around GCC bug 48267.
13670
03d0a109
PE
13671 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13672
44f730c8
PE
13673 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13674
fe75f926
PE
13675 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13676 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13677
ffa8c828
PE
13678 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13679 This avoids undefined behavior on integer overflow, and is a bit
13680 more convenient anyway since it is compared to a size_t variable.
13681
c5101a77
PE
13682 Variadic C functions now count arguments with size_t, not int.
13683 This avoids an unnecessary limitation on 64-bit machines, which
13684 caused (substring ...) to crash on large vectors (Bug#8344).
13685 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13686 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13687 All variadic functions and their callers changed accordingly.
c5101a77
PE
13688 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13689 * data.c (arith_driver, float_arith_driver): Likewise.
13690 * editfns.c (general_insert_function): Likewise.
13691 * eval.c (struct backtrace.nargs, interactive_p)
13692 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13693 (funcall_lambda, mark_backtrace): Likewise.
13694 * fns.c (concat): Likewise.
13695 * frame.c (x_set_frame_parameters): Likewise.
13696 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13697 0 if not found, not -1. All callers changed.
13698
dd3f25f7
PE
13699 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13700 (stack_copy_size): Now size_t, not int.
13701 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13702
461c2ab9
JB
137032011-03-28 Juanma Barranquero <lekktu@gmail.com>
13704
13705 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13706 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13707 All callers changed.
13708
13709 * lisp.h (multibyte_char_to_unibyte):
13710 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13711 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13712 * character.h (CHAR_TO_BYTE8):
13713 * cmds.c (internal_self_insert):
13714 * editfns.c (general_insert_function):
13715 * keymap.c (push_key_description):
13716 * search.c (Freplace_match):
13717 * xdisp.c (message_dolog, set_message_1): All callers changed.
13718
f6d62986
SM
137192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13720
13721 * keyboard.c (safe_run_hook_funcall): New function.
13722 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13723 don't set the hook to nil, but remove the offending function instead.
13724 (Qcommand_hook_internal): Remove, unused.
13725 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13726 Vcommand_hook_internal.
13727
13728 * eval.c (enum run_hooks_condition): Remove.
13729 (funcall_nil, funcall_not): New functions.
13730 (run_hook_with_args): Call each function through a `funcall' argument.
13731 Remove `cond' argument, now redundant.
13732 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13733 (Frun_hook_with_args_until_failure): Adjust accordingly.
13734 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13735
1db5b1ad
JB
137362011-03-28 Juanma Barranquero <lekktu@gmail.com>
13737
13738 * dispextern.h (string_buffer_position): Remove declaration.
13739
13740 * print.c (strout): Remove parameter `multibyte', unused since
13741 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13742
13743 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13744 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13745 All callers changed.
13746
13747 * w32.c (_wsa_errlist): Use braces for struct initializers.
13748
13749 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13750 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13751 All callers changed.
13752 (string_buffer_position): Likewise. Also, make static (it's never
13753 used outside xdisp.c).
13754 (cursor_row_p): Remove parameter `w', unused since
13755 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13756 (decode_mode_spec): Remove parameter `precision', introduced during
13757 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13758 All callers changed.
13759
5ffb62aa
JD
137602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13761
13762 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13763
461c2ab9 137642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13765
13766 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13767 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13768 (ns_update_auto_hide_menu_bar): New functions.
13769 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13770 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13771 ns_constrain_all_frames.
13772 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13773 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13774
5c380ffb
JD
137752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13776
13777 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13778
9af30bdf
GM
137792011-03-27 Glenn Morris <rgm@gnu.org>
13780
13781 * syssignal.h: Replace RETSIGTYPE with void.
13782 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13783 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13784 Replace SIGTYPE with void everywhere.
13785 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13786 * s/template.h (SIGTYPE): Remove commented out definition.
13787
e2abce01
JB
137882011-03-26 Eli Zaretskii <eliz@gnu.org>
13789
13790 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13791 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13792
f868cd8a
JB
137932011-03-26 Juanma Barranquero <lekktu@gmail.com>
13794
59eb0929
JB
13795 * w32.c (read_unc_volume): Use parameter `henum', instead of
13796 global variable `wget_enum_handle'.
13797
13798 * keymap.c (describe_vector): Remove parameters `indices' and
13799 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13800 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13801
f868cd8a
JB
13802 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13803
13804 * keyboard.c (timer_check): Remove parameter `do_it_now',
13805 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13806 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13807 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13808
13809 * keyboard.c (read_char):
13810 * w32menu.c (w32_menu_display_help):
13811 * xmenu.c (show_help_event, menu_help_callback):
13812 Adjust calls to `show_help_echo'.
13813
13814 * gtkutil.c (xg_maybe_add_timer):
13815 * keyboard.c (readable_events):
13816 * process.c (wait_reading_process_output):
13817 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13818
13819 * insdel.c (adjust_markers_gap_motion):
13820 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13821 (gap_left, gap_right): Don't call it.
13822
2ecf6fdb
CY
138232011-03-25 Chong Yidong <cyd@stupidchicken.com>
13824
13825 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13826 incurred during fontification.
13827
6b1f9ba4
JB
138282011-03-25 Juanma Barranquero <lekktu@gmail.com>
13829
13830 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13831 (DEFVAR_PER_BUFFER): Don't pass it.
13832
13833 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13834 (scrolling_window): Don't pass it.
13835
0f4a96b5
JB
138362011-03-25 Juanma Barranquero <lekktu@gmail.com>
13837
13838 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13839
13840 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13841 and `suffix'.
13842 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13843 of variables specific to SELinux and computation of `encoded_absname'.
13844
13845 * image.c (XPutPixel): Remove unused variable `height'.
13846
13847 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13848
13849 * unexw32.c (get_section_info): Remove unused variable `section'.
13850
13851 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13852 (system_process_attributes): Remove unused variable `sess'.
13853 (sys_read): Remove unused variable `err'.
13854
13855 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13856 (w32_wnd_proc): Remove unused variable `isdead'.
13857 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13858 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13859 (x_create_tip_frame): Remove unused variable `tem'.
13860
13861 * w32inevt.c (w32_console_read_socket):
13862 Remove unused variable `no_events'.
13863
13864 * w32term.c (x_draw_composite_glyph_string_foreground):
13865 Remove unused variable `width'.
13866
1149507c
JB
138672011-03-24 Juanma Barranquero <lekktu@gmail.com>
13868
13869 * w32term.c (x_set_glyph_string_clipping):
13870 Don't pass uninitialized region to CombineRgn.
13871
9c88f339
JB
138722011-03-23 Juanma Barranquero <lekktu@gmail.com>
13873
13874 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13875 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13876 (Fx_close_connection): Remove unused variable `i'.
13877
13878 * w32font.c (w32font_draw): Return number of glyphs.
13879 (w32font_open_internal): Remove unused variable `i'.
13880 (w32font_driver): Add missing initializer.
13881
13882 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13883 (fill_in_menu): Remove unused variable `items_added'.
13884
13885 * w32term.c (last_mouse_press_frame): Remove static global variable.
13886 (w32_clip_to_row): Remove unused variable `f'.
13887 (x_delete_terminal): Remove unused variable `i'.
13888
13889 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13890 (NOTHING): Remove unused static global variable.
13891 (uniscribe_check_otf): Remove unused variable `table'.
13892 (uniscribe_font_driver): Add missing initializers.
13893
dee091a3
JD
138942011-03-23 Julien Danjou <julien@danjou.info>
13895
13896 * term.c (Fsuspend_tty, Fresume_tty):
13897 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13898 * window.c (temp_output_buffer_show):
13899 * insdel.c (signal_before_change):
13900 * frame.c (Fhandle_switch_frame):
13901 * fileio.c (Fdo_auto_save):
13902 * emacs.c (Fkill_emacs):
13903 * editfns.c (save_excursion_restore):
13904 * cmds.c (internal_self_insert):
13905 * callint.c (Fcall_interactively):
13906 * buffer.c (Fkill_all_local_variables):
13907 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13908 Use Frun_hooks.
0f4a96b5 13909 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13910 unconditionally since it does the check itself.
dee091a3 13911
2c520ab5 139122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13913
c9c49752
PE
13914 Fix more problems found by GCC 4.5.2's static checks.
13915
8abc3f12
PE
13916 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13917 the first time through the loop, since we know p0 < p1 then.
13918 This also avoids a gcc -Wstrict-overflow warning.
13919
a2d26660
PE
13920 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13921 leading to a memory leak, possible in functions like
13922 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13923 of objects (Bug#8318).
a2d26660 13924
916c72e9
PE
13925 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13926 that could (at least in theory) be that large.
13927
19ab8a18
PE
13928 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13929 This is less likely to overflow, and avoids undefined behavior if
13930 overflow does occur. All callers changed. Use strtoul to scan
13931 for the unsigned long integer.
b7cbbd6f
PE
13932 (pint2hrstr): Simplify and tune code slightly.
13933 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13934
f0641eff
PE
13935 * scroll.c (do_scrolling): Work around GCC bug 48228.
13936 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13937
7f650bb9
PE
13938 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13939 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13940 (validate_x_resource_name): Simplify count usage.
13941 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13942
37dd57d1
PE
13943 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13944 fail (Bug#8306).
81e56e61 13945
699979fc 13946 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13947
401bf9b4
PE
13948 * process.c (Fmake_network_process): Use socklen_t, not int,
13949 where POSIX says socklen_t is required in portable programs.
13950 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13951 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13952 (Fmake_network_process, server_accept_connection):
13953 (wait_reading_process_output, read_process_output):
13954 Likewise.
13955
b93aacde
PE
13956 * process.c: Rename or move locals to avoid shadowing.
13957 (list_processes_1, Fmake_network_process):
13958 (read_process_output_error_handler, exec_sentinel_error_handler):
13959 Rename or move locals.
4dc343ee 13960 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13961 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13962 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13963 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13964 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13965
af8a867c 13966 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13967 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13968 Include tparam.h instead, since it declares them.
af8a867c
PE
13969 * cm.h (PC): Remove extern decl; tparam.h now does this.
13970 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13971 * terminfo.c: Include tparam.h, to check interfaces.
13972 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13973 (tparam): Adjust signature to match interface in tparam.h;
13974 this removes some undefined behavior. Check that outstring and len
13975 are zero, which they always are with Emacs.
13976 * tparam.h (PC, BC, UP): New extern decls.
13977
0248044d 13978 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13979 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13980
8ff096c1 13981 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13982 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13983 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13984 (ftfont_list): Remove unused local.
49eaafba
PE
13985 (get_adstyle_property, ftfont_pattern_entity):
13986 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13987 Rename locals to avoid shadowing.
8ff096c1 13988
e2be39f6
PE
13989 * xfont.c (xfont_list_family): Mark var as initialized.
13990
c9735e30
PE
13991 * xml.c (make_dom): Now static.
13992
8f5201ae
PE
13993 * composite.c (composition_compute_stop_pos): Rename local to
13994 avoid shadowing.
b246f932
PE
13995 (composition_reseat_it): Remove unused locals.
13996 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13997 (composition_update_it): Mark var as initialized.
11b61122
PE
13998 (find_automatic_composition): Mark vars as initialized,
13999 with a FIXME (Bug#8290).
8f5201ae 14000
760fbc2c
PE
14001 character.h: Rename locals to avoid shadowing.
14002 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14003 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14004 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14005 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14006 to avoid shadowing.
14007
ff08eb85
PE
14008 * textprop.c (property_change_between_p): Remove; unused.
14009
fc7bf025
PE
14010 * intervals.c (interval_start_pos): Now static.
14011
235d7abc
PE
14012 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14013
44f230aa
SM
14014 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14015 Rename locals to avoid shadowing.
3e7d6594 14016
50060332
PE
14017 * sound.c (wav_play, au_play, Fplay_sound_internal):
14018 Fix pointer signedness.
d01f234b 14019 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14020 (wav_play): Initialize a variable to 0, to prevent undefined
14021 behavior (Bug#8278).
50060332 14022
c4fc4e30
PE
14023 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14024
918436ed
PE
14025 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14026
c939f91b
PE
14027 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14028 clobbering (Bug#8298).
b9c7f648
PE
14029 * sysdep.c (sys_subshell): Likewise.
14030 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14031
6bd8c144
PE
14032 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14033 This should get cleaned up, so that child_setup has the
14034 same signature on all platforms.
14035
7710357c 14036 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14037 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14038
c59da222
CY
140392011-03-22 Chong Yidong <cyd@stupidchicken.com>
14040
14041 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14042 not to be necessary, and produces flickering.
14043
66b87493
GM
140442011-03-20 Glenn Morris <rgm@gnu.org>
14045
14046 * config.in: Remove file.
14047
45b6f6d5
JB
140482011-03-20 Juanma Barranquero <lekktu@gmail.com>
14049
14050 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14051 are now in src/globals.h.
14052 (syms_of_minibuf): Remove spurious & from previous change.
14053
cd394be1 140542011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14055
14056 * minibuf.c (completing-read-function): New variable.
14057 (completing-read-default): Rename from completing-read.
14058 (completing-read): Call completing-read-function.
14059
b14e3e21
CY
140602011-03-19 Juanma Barranquero <lekktu@gmail.com>
14061
14062 * xfaces.c (Fx_load_color_file):
14063 Read color file from absolute filename (bug#8250).
14064
f2b726e6
JB
140652011-03-19 Juanma Barranquero <lekktu@gmail.com>
14066
14067 * makefile.w32-in: Update dependencies.
14068
09f6ff02
EZ
140692011-03-17 Eli Zaretskii <eliz@gnu.org>
14070
14071 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14072
29a6015a
PE
140732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14074
a3a6c54e
PE
14075 Fix more problems found by GCC 4.5.2's static checks.
14076
b766f867
PE
14077 * process.c (make_serial_process_unwind, send_process_trap):
14078 (sigchld_handler): Now static.
14079
be02381c
PE
14080 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14081 That way, the code declares only the vars that it needs.
14082 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14083 * s/cygwin.h (PTY_ITERATION): Likewise.
14084 * s/darwin.h (PTY_ITERATION): Likewise.
14085 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14086
57048744
PE
14087 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14088 * process.c (allocate_pty): Don't declare stb unless it's needed.
14089
7914961c 14090 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14091 (CONSTANTLIM): Remove; unused.
14092 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14093 Define only if needed.
7914961c 14094
b3967b18
PE
14095 * unexelf.c (unexec): Name an expression,
14096 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14097 Use a different way to cause a compilation error if anyone uses
14098 n rather than nn, a way that does not involve shadowing.
73366a00 14099 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14100
29a6015a
PE
14101 * deps.mk (unexalpha.o): Remove; unused.
14102
43cfc33e 14103 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14104 * unexec.h: New file.
ce701a33
PE
14105 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14106 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14107 Depend on unexec.h.
14108 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14109 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14110 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14111 Change as necessary to match prototype in unexec.h.
ce701a33 14112
01f44d5a
PE
14113 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14114 shadowing.
4f63c6bb 14115 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14116
a6670b0b
PE
14117 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14118 Rename locals to avoid shadowing.
14119
cef2010d 14120 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14121 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14122
d4d7173a
PE
14123 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14124
f08b802a
PE
14125 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14126 warning when compiling print.c.
14127
3ddb0639
PE
14128 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14129 instead of using an uninitialized var.
5ad03b97 14130 (font_sort_entities): Mark var as initialized.
3ddb0639 14131
170a2692
PE
14132 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14133
e663c700
PE
14134 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14135 pointers to constants.
89bc529a 14136 (font_parse_fcname): Remove unused vars.
7b81e2d0 14137 (font_delete_unmatched): Now static.
ea838e10 14138 (font_get_spec): Remove; unused.
13a547c6
PE
14139 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14140 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14141 Rename or move locals to avoid shadowing.
e663c700 14142
2a80c887 14143 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14144 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14145
1384fa33 14146 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14147 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14148
8b2c52e9
PE
14149 * alloc.c (mark_backtrace): Move decl from here ...
14150 * lisp.h: ... to here, so that it can be checked.
14151
475545b5 14152 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14153 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14154 (lisp_indirect_variable): Name an expression,
14155 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14156 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14157
b1349114 14158 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14159 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14160 Use const pointer when appropriate.
b1349114 14161
a2928364
PE
14162 * lisp.h (get_system_name, get_operating_system_release):
14163 Move decls here, to check interfaces.
14164 * process.c (get_operating_system_release): Move decl to lisp.h.
14165 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14166 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14167 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14168 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14169 (Fformat_time_string, Fencode_time, Finsert_char):
14170 (Ftranslate_region_internal, Fformat):
14171 Rename or remove local vars to avoid shadowing.
9710023e 14172 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14173
a415e694
PE
14174 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14175 avoid shadowing.
14176
8ef4622d
PE
14177 * lisp.h (eassert): Check that the argument compiles, even if
14178 ENABLE_CHECKING is not defined.
14179
946f9a5b
PE
14180 * data.c (Findirect_variable): Name an expression, to avoid
14181 gcc -Wbad-function-cast warning.
112396d6 14182 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14183 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14184 (Fmake_variable_buffer_local, Fmake_local_variable):
14185 Mark variables as initialized.
52746918 14186 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14187
e5aab7e7 14188 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14189 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14190 Rename locals to avoid shadowing.
dff45157
PE
14191 (mark_stack): Move local variables into the #ifdef region where
14192 they're used.
7bc26fdb
PE
14193 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14194 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14195 needed otherwise.
14196 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14197 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14198 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14199
e5aab7e7
PE
14200 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14201 avoids undefined behavior in theory.
14202
4da60324
PE
14203 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14204
88043301
PE
14205 Use functions, not macros, for up- and down-casing (Bug#8254).
14206 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14207 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14208 to use the following functions instead of these macros.
14209 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14210 EMACS_INT, since callers assume the returned value fits in int.
14211 (upcase1): Likewise, for UPCASE_TABLE.
14212 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14213 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14214 the race-condition problem in the old DOWNCASE.
88043301 14215
19ed5445
PE
14216 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14217 Rename locals to avoid shadowing.
14218 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14219 (regex_compile, re_search_2, re_match_2_internal):
14220 Remove unused local vars.
952db0d7
PE
14221 (FREE_VAR): Rewrite so as not to use empty "else",
14222 which gcc can warn about.
da053e48 14223 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14224 (RETALLOC_IF): Define only if needed.
14225 (WORDCHAR_P): Likewise. This one is never needed, but is used
14226 only in a comment talking about a compiler bug, so put inside
14227 the #if 0 of that comment.
14228 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14229 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14230 Remove; unused.
19ed5445 14231
1f3561e4 14232 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14233 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14234 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14235
ded6f8f7
PE
14236 * search.c (simple_search): Remove unused var.
14237
dbd37a95
PE
14238 * dired.c (compile_pattern): Move decl from here ...
14239 * lisp.h: ... to here, so that it can be checked.
14240 (struct re_registers): New forward decl.
14241
7e47afad
PE
14242 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14243
85f24f61
PE
14244 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14245 All uses changed.
14246 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14247 Rename locals to avoid shadowing.
5671df8f 14248 (Fvertical_motion): Mark locals as initialized.
85f24f61 14249
181aa2be 14250 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14251 (casify_region): Mark local as initialized.
181aa2be 14252
930d429c
PE
14253 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14254
7082eac6
PE
14255 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14256 New macros, so that the caller can use some names other than
14257 gcpro1, gcpro2, etc.
14258 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14259 of the new macros.
14260 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14261 argument, for consistency with GCPRO2_VAR, etc: it is now the
14262 prefix of the variable, not the variable itself. All uses
14263 changed.
38b2c076
PE
14264 * dired.c (directory_files_internal, file_name_completion):
14265 Rename locals to avoid shadowing.
14266
15206ed9
PE
14267 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14268 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14269 dired.c's scmp function, had undefined behavior.
14270 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14271 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14272 * buffer.h: ... to here, because these macros use current_buffer,
14273 and the new implementation with inline functions needs to have
14274 current_buffer in scope now, rather than later when the macros
14275 are used.
14276 (downcase, upcase1): New static inline functions.
14277 (DOWNCASE, UPCASE1): Reimplement using these functions.
14278 This avoids undefined behavior in expressions like
14279 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14280 from race conditions in accessing the global variables
14281 case_temp1 and case_temp2.
14282 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14283 * lisp.h (case_temp1, case_temp2): Remove their decls.
14284 * character.h (ASCII_CHAR_P): Move from here ...
14285 * lisp.h: ... to here, so that the inline functions mentioned
14286 above can use them.
14287
4a6bea26
PE
14288 * dired.c (directory_files_internal_unwind): Now static.
14289
f14b7e14
PE
14290 * fileio.c (file_name_as_directory, directory_file_name):
14291 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14292 Now static.
2893f146
PE
14293 (file_name_as_directory): Use const pointers when appropriate.
14294 (Fexpand_file_name): Likewise. In particular, newdir might
14295 point at constant storage, so make it a const pointer.
fd4ead52 14296 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14297 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14298 signedness issues.
f839df0c
PE
14299 (Fset_file_times, Finsert_file_contents, auto_save_error):
14300 Rename locals to avoid shadowing.
f14b7e14 14301
5716756e 14302 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14303 (Ftry_completion, Fall_completions): Rename or remove locals
14304 to avoid shadowing.
5716756e 14305
b4c3046a
PE
14306 * marker.c (bytepos_to_charpos): Remove; unused.
14307
b45db522
PE
14308 * lisp.h (verify_bytepos, count_markers): New decls,
14309 so that gcc does not warn that these functions aren't declared.
14310
85876d07
PE
14311 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14312 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14313 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14314 (copy_text): Remove unused local var.
85876d07 14315
03d78a21 14316 * filelock.c (within_one_second): Now static.
b3dd38ab 14317 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14318
5df8f01b
PE
14319 * buffer.c (fix_overlays_before): Mark locals as initialized.
14320 (fix_start_end_in_overlays): Likewise. This function should be
14321 simplified by using pointers-to-pointers, but that's a different
14322 matter.
b1d876f1 14323 (switch_to_buffer_1): Now static.
8f54f30a
PE
14324 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14325 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14326
a70072c9 14327 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14328 Fix pointer signedness issue.
edced198
PE
14329 (sys_subshell): Mark local as volatile if checking for lint,
14330 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14331 (MAXPATHLEN): Define only if needed.
a70072c9 14332
a0977c44
PE
14333 * process.c (serial_open, serial_configure): Move decls from here ...
14334 * systty.h: ... to here, so that they can be checked.
14335
a884fdcc
PE
14336 * fns.c (get_random, seed_random): Move extern decls from here ...
14337 * lisp.h: ... to here, so that they can be checked.
14338
604efe86 14339 * sysdep.c (reset_io): Now static.
b8950c94 14340 (wait_for_termination_signal): Remove; unused.
604efe86 14341
38fc62d9
PE
14342 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14343 (copy_keymap_item, append_key, push_text_char_description):
14344 Now static.
1004a21a 14345 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14346 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14347 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14348 (describe_map_tree):
14349 Rename locals to avoid shadowing.
38fc62d9 14350
2f2650da
PE
14351 * keyboard.c: Declare functions static if they are not used elsewhere.
14352 (echo_char, echo_dash, cmd_error, top_level_2):
14353 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14354 (read_char, kbd_buffer_get_event, make_lispy_position):
14355 (make_lispy_event, make_lispy_movement, apply_modifiers):
14356 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14357 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14358 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14359 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14360 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14361
a053e86c 14362 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14363 (mark_kboards): Move decl here ...
14364 * alloc.c (mark_kboards): ... from here.
a053e86c 14365
4752793e
PE
14366 * lisp.h (force_auto_save_soon): New decl.
14367
74f10ca7 14368 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14369 (DEFINE_DUMMY_FUNCTION): New macro.
14370 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14371 Use it.
c03cd23f
PE
14372 (main): Add casts to avoid warnings
14373 if GCC considers string literals to be constants.
74f10ca7 14374
022e70d4
PE
14375 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14376
59d6fe83
PE
14377 * dbusbind.c: Pointer signedness fixes.
14378 (xd_signature, xd_append_arg, xd_initialize):
14379 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14380 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14381 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14382 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14383
78320123
PE
14384 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14385 if GCC considers string literals to be constants.
49cebcca 14386 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14387
35ac2a97
SM
143882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14389
fb103ca9
SM
14390 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14391 (print_preprocess, print_object): New macro to fix last change.
14392
35ac2a97
SM
14393 * print.c (print_preprocess): Don't forget font objects.
14394
62973b41
JB
143952011-03-16 Juanma Barranquero <lekktu@gmail.com>
14396
14397 * emacs.c (USAGE3): Doc fixes.
14398
0e48bb22
AS
143992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14400
14401 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14402 structure.
14403
7684e57b
JB
144042011-03-14 Juanma Barranquero <lekktu@gmail.com>
14405
14406 * lisp.h (VWindow_system, Qfile_name_history):
14407 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14408 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14409 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14410
14411 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14412 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14413
14414 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14415 * w32console.c (detect_input_pending, read_input_pending)
14416 (encode_terminal_code):
14417 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14418 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14419 (w32_system_caret_y, Qfile_name_history):
14420 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14421 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14422 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14423 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14424 * w32proc.c (Qlocal, report_file_error):
14425 * w32term.c (Vwindow_system, updating_frame):
14426 * w32uniscribe.c (initialized, uniscribe_font_driver):
14427 Remove unneeded extern declarations.
14428
2aa46d6c
CY
144292011-03-14 Chong Yidong <cyd@stupidchicken.com>
14430
c96bbc66 14431 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14432
cffc6f3b
CY
144332011-03-13 Chong Yidong <cyd@stupidchicken.com>
14434
14435 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14436 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14437 These macros can no longer be used for assignment.
14438
44f230aa
SM
14439 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14440 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14441 (record_buffer_markers, fetch_buffer_markers): New functions for
14442 recording and fetching special buffer markers.
14443 (set_buffer_internal_1, set_buffer_temp): Use them.
14444
14445 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14446
14447 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14448
14449 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14450 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14451
14452 * xdisp.c (hscroll_window_tree):
14453 (reconsider_clip_changes): Use PT instead of BUF_PT.
14454
d251f04b
EZ
144552011-03-13 Eli Zaretskii <eliz@gnu.org>
14456
14457 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14458 $(EMACS_ROOT)/lib/intprops.h.
14459
f0c77cd1
PE
144602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14461
3eca4629
PE
14462 Fix more problems found by GCC 4.5.2's static checks.
14463
7c86ee98
PE
14464 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14465 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14466 (xg_free_frame_widgets): Make it clear that a local variable is
14467 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14468 (gdk_window_get_screen): Make it clear that this macro is needed
14469 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14470 (int_gtk_range_get_value): New function, which avoids a diagnostic
14471 from gcc -Wbad-function-cast.
14472 (xg_set_toolkit_scroll_bar_thumb): Use it.
14473 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14474 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14475 (get_utf8_string, xg_get_file_with_chooser):
14476 Rename locals to avoid shadowing.
14477 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14478
41729b81
PE
14479 * xgselect.c (xg_select): Remove unused var.
14480
f0c77cd1
PE
14481 * image.c (four_corners_best): Mark locals as initialized.
14482 (gif_load): Initialize transparent_p to zero (Bug#8238).
14483 Mark another local as initialized.
ec6cf4c6 14484 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14485
ce0ad53d 14486 * image.c (clear_image_cache): Now static.
d5d5a617 14487 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14488 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14489 (x_edge_detection): Remove unnecessary cast that
14490 gcc -Wbad-function-cast diagnoses.
2037898d 14491 (gif_load): Fix pointer signedness.
6ae141d6
PE
14492 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14493 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14494
33383987 144952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14496
d32df629
PE
14497 Improve quality of tests for time stamp overflow.
14498 For example, without this patch (encode-time 0 0 0 1 1
14499 1152921504606846976) returns the obviously-bogus value (-948597
14500 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14501 reports time overflow. See
14502 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14503 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14504 * editfns.c: Include limits.h and intprops.h.
14505 (TIME_T_MIN, TIME_T_MAX): New macros.
14506 (time_overflow): Move earlier, to before first use.
14507 (hi_time, lo_time): New functions, for an accurate test for
14508 out-of-range times.
14509 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14510 (Fget_internal_run_time): Don't assume time_t fits in int.
14511 (make_time): Use list2 instead of Fcons twice.
14512 (Fdecode_time): More accurate test for out-of-range times.
14513 (check_tm_member): New function.
14514 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14515 (lisp_time_argument): Don't rely on undefined left-shift and
14516 right-shift behavior when checking for time stamp overflow.
8be6f318 14517
fe31d94c
PE
14518 * editfns.c (time_overflow): New function, refactoring common code.
14519 (Fformat_time_string, Fdecode_time, Fencode_time):
14520 (Fcurrent_time_string): Use it.
14521
8be6f318
PE
14522 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14523 * dired.c (make_time): Move to ...
14524 * editfns.c (make_time): ... here.
14525 * systime.h: Note the move.
14526
09d9db2c 145272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14528
126bc0dc
YM
14529 * fringe.c (update_window_fringes): Remove unused variables.
14530
c47cbdfd
YM
14531 * unexmacosx.c (copy_data_segment): Also copy __got section.
14532 (Bug#8223)
14533
7ac80be9
EZ
145342011-03-12 Eli Zaretskii <eliz@gnu.org>
14535
c96bbc66 14536 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14537 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14538 Constify `char *' arguments and their references according to
14539 prototypes in tparam.h.
14540
ecb0f94d 14541 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14542
7ac80be9
EZ
14543 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14544 Adapt all references accordingly.
14545
14546 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14547
ef1fd07e
TT
145482011-03-11 Tom Tromey <tromey@redhat.com>
14549
14550 * buffer.c (syms_of_buffer): Remove obsolete comment.
14551
7ef4b50c
EZ
145522011-03-11 Eli Zaretskii <eliz@gnu.org>
14553
14554 * termhooks.h (encode_terminal_code): Declare prototype.
14555
14556 * msdos.c (encode_terminal_code): Don't declare prototype.
14557
14558 * term.c (encode_terminal_code): Now external again, used by
14559 w32console.c and msdos.c.
14560
44f230aa
SM
14561 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14562 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14563
4b1ec863 145642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14565
1714f52b 14566 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14567
4b1ec863
PE
14568 * fringe.c (update_window_fringes): Mark locals as initialized
14569 (Bug#8227).
14570 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14571
524c7aa6
PE
14572 * alloc.c (mark_fringe_data): Move decl from here ...
14573 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14574 to check its interface.
14575 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14576
a5c0af81 14577 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14578 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14579 (fontset_font): Mark local as initialized.
a9a06e0b 14580 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14581
b4716021
PE
14582 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14583
811e9bac 14584 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14585 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14586 (x_own_selection, Fx_disown_selection_internal): Rename locals
14587 to avoid shadowing.
14588 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14589
7e3ab302
PE
14590 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14591 so that the caller can use some name other than gcpro1.
14592 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14593 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14594 (Fx_backspace_delete_keys_p):
14595 Use them to avoid shadowing, and rename vars to avoid shadowing.
14596 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14597 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14598 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14599 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14600 Remove unused locals.
7e3ab302
PE
14601 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14602 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14603 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14604 macros.
f78faa98 14605
e2b13473
PE
14606 * xterm.h (x_mouse_leave): New decl.
14607
77f23912
PE
14608 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14609 Remove unused functions.
cdf4ba58
PE
14610 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14611 (x_calc_absolute_position): Now static.
7411c686 14612 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14613 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14614 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14615 unless they are used.
38d0b34a
PE
14616 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14617 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14618 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14619 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14620 (x_error_catcher, x_connection_closed, x_error_handler):
14621 (x_error_quitter, xembed_send_message, x_iconify_frame):
14622 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14623 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14624 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14625
44f230aa
SM
14626 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14627 Rename or move locals to avoid shadowing.
6b463e58 14628 (tty_defined_color, merge_face_heights): Now static.
5967d051 14629 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14630 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14631 does not deduce is never used uninitialized.
73719eba
PE
14632 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14633 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14634
426994c3 14635 * terminal.c (store_terminal_param): Now static.
5489860b 14636
032f1620 14637 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14638 (set_frame_menubar): Remove unused local.
d4323972 14639 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14640 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14641 since they might point to immutable storage.
281585b0
PE
14642 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14643 since it's unused otherwise.
032f1620 14644
367c19e5 14645 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14646 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14647 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14648 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14649 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14650 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14651 does not deduce are never used uninitialized.
70739cbe 14652
07b48fa9
PE
14653 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14654
8868a238 14655 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14656 * window.c (window_loop, size_window):
14657 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14658
7e5cf297 14659 * window.c (display_buffer): Now static.
d6550a9f
PE
14660 (size_window): Mark variables that gcc -Wuninitialized
14661 does not deduce are never used uninitialized.
a586633d
PE
14662 * window.h (check_all_windows): New decl, to forestall
14663 gcc -Wmissing-prototypes diagnostic.
5b555da1 14664 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14665
f6095868
PE
14666 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14667 shadowing.
14668 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14669 Include <limits.h>.
14670 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14671 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14672 (load_charset_map): Mark variables that gcc -Wuninitialized
14673 does not deduce are never used uninitialized.
53df7c11 14674 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14675
f38b440c
PE
14676 * coding.c (coding_set_source, coding_set_destination):
14677 Use "else { /* comment */ }" rather than "else /* comment */;"
14678 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14679 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14680 a block, when the outer 'i' will do.
14681 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14682 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14683 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14684 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14685 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14686 Rename locals to avoid shadowing.
14687 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14688 * coding.c (emacs_mule_char, encode_invocation_designation):
14689 Now static, since they're not used elsewhere.
413bb2db 14690 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14691 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14692 (decode_coding_emacs_mule): Mark variables that gcc
14693 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14694 (detect_coding_iso_2022): Initialize a local variable that might
14695 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14696 this initialization is needed. (Bug#8211)
5f58e762
PE
14697 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14698 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14699 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14700 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14701 Remove unused macros.
f38b440c 14702
232b38b9 14703 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14704 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14705 * character.c (string_count_byte8): Likewise.
232b38b9 14706
fb90da1b
PE
14707 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14708 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14709
fb93dbc2
PE
14710 * chartab.c (copy_sub_char_table): Now static, since it's not used
14711 elsewhere.
5c156ace
PE
14712 (sub_char_table_ref_and_range, char_table_ref_and_range):
14713 Rename locals to avoid shadowing.
bbcd0949 14714 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14715
7d3b3862 14716 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14717 (BIDI_BOB): Remove unused macro.
7d3b3862 14718
6be7d3da
PE
14719 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14720 deduce are never used uninitialized.
c2ed9c8b 14721 * term.c (encode_terminal_code): Likewise.
6be7d3da 14722
75f8807f 14723 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14724
50938595
PE
14725 * tparam.h: New file.
14726 * term.c, tparam.h: Include it.
14727 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14728 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14729 Move these decls to tparam.h, and make them agree with what
14730 is actually in tparam.c. The previous trick of using incompatible
14731 decls in different modules does not conform to the C standard.
14732 All callers of tparam changed to use tparam's actual API.
14733 * tparam.c (tparam1, tparam, tgoto):
14734 Use const pointers where appropriate.
14735
fbceeba2
PE
14736 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14737 * cm.h (struct cm): Likewise.
14738 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14739 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14740 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14741 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14742 (turn_on_face, init_tty): Likewise.
14743 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14744
7f3f1250
PE
14745 * term.c (term_mouse_position): Rename local to avoid shadowing.
14746
e6ca6543
PE
14747 * alloc.c (mark_ttys): Move decl from here ...
14748 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14749
c40f8d15
AS
147502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14751
14752 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14753
cfe0661d
JB
147542011-03-09 Juanma Barranquero <lekktu@gmail.com>
14755
14756 * search.c (compile_pattern_1): Remove argument regp, unused since
14757 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14758 (compile_pattern): Don't pass it.
14759
0afb4571
J
147602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14761
14762 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14763 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14764 for ! HAVE_GTK3.
14765 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14766
14767 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14768
14769 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14770 gdk_window_get_screen, gdk_window_get_geometry,
14771 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14772 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14773 (xg_get_pixbuf_from_pixmap): New function.
14774 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14775 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14776 Call xg_get_pixbuf_from_pixmap instead of
14777 gdk_pixbuf_get_from_drawable.
14778 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14779 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14780 (xg_check_special_colors): Use GtkStyleContext and its functions
14781 for HAVE_GTK3.
14782 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14783 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14784 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14785 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14786 Call gtk_widget_get_preferred_size.
0afb4571
J
14787 (xg_frame_resized): gdk_window_get_geometry only takes 5
14788 parameters.
44f230aa
SM
14789 (xg_win_to_widget, xg_event_is_for_menubar):
14790 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14791 (xg_set_widget_bg): New function.
14792 (delete_cb): New function.
895009e1 14793 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14794 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14795 (xg_set_background_color): Call xg_set_widget_bg.
14796 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14797 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14798 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14799 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14800 if ! HAVE_GTK3.
14801 (update_frame_tool_bar): Call gtk_widget_hide.
14802 (xg_initialize): Use GDK_KEY_g.
14803
14804 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14805 if ! HAVE_GTK3
14806 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14807
14808 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14809 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14810 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14811
1c2cc4ef
JB
148122011-03-08 Juanma Barranquero <lekktu@gmail.com>
14813
14814 * w32xfns.c (select_palette): Check success of RealizePalette against
14815 GDI_ERROR, not zero.
14816
33383987 14817See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14818
14819;; Local Variables:
14820;; coding: utf-8
aac0c6e3
MR
14821;; End:
14822
2f097256 14823 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14824
14825 This file is part of GNU Emacs.
14826
14827 GNU Emacs is free software: you can redistribute it and/or modify
14828 it under the terms of the GNU General Public License as published by
14829 the Free Software Foundation, either version 3 of the License, or
14830 (at your option) any later version.
14831
14832 GNU Emacs is distributed in the hope that it will be useful,
14833 but WITHOUT ANY WARRANTY; without even the implied warranty of
14834 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14835 GNU General Public License for more details.
14836
14837 You should have received a copy of the GNU General Public License
14838 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.