Preserve text properties when saving primary selection.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
25a20a3a
JB
12012-08-06 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32.c: Silence compiler warnings.
4 (map_w32_filename): Remove unused variable `is_fat'.
5 (chase_symlinks): Add parentheses around expression.
6
1c6f11f4
GM
72012-08-06 Glenn Morris <rgm@gnu.org>
8
1db4583a
GM
9 * sysdep.c: Respect BROKEN_GETWD.
10
1c6f11f4
GM
11 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
12 Let configure handle it.
13 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
14
2b90362b
DA
152012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
16
17 Use GCALIGNMENT where appropriate.
18 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
19 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
20 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
21
5f50daf2
EZ
222012-08-06 Eli Zaretskii <eliz@gnu.org>
23
24 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
25 use FRAME_MENU_BAR_ITEMS as an lvalue.
26
cbcc7007
SM
272012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
28
29 * buffer.h (struct buffer): Revert `indirections' to a simple int;
30 that should be sufficient for everyone.
31
4d365fa4
JD
322012-08-06 Jan Djärv <jan.h.d@swipnet.se>
33
34 * keyboard.c (timer_check_2): Add break so timer_check returns next
35 timeout.
36
dd86bd82
DA
372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Fix Windows build errors introduced after converting to WGET and WSET.
40 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
41 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
42
054e1668
JD
432012-08-06 Jan Djärv <jan.h.d@swipnet.se>
44
45 * nsterm.m (ns_frame_rehighlight): Use FSET.
46
47 * nsmenu.m (ns_update_menubar): Use FSET.
48
21238f11
DA
492012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Separate read and write access to Lisp_Object slots of Lisp_Process.
52 * process.h (PGET, PSET): New macros similar to AREF and ASET.
53 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
54
077288cf
DA
552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
56
57 Separate read and write access to Lisp_Object slots of struct window.
58 * window.h (WGET, WSET): New macros similar to AREF and ASET.
59 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
60 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
61 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
62 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
63 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
64 Adjust users.
65
71688bd7
DA
662012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Fix Windows build errors introduced after converting to FGET and FSET.
69 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
70 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
71 (w32_judge_scroll_bars): Change to use FSET.
72 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
73
f99bac93
DA
742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
75
76 Fix replacement typo.
77 * window.c (replace_window): Set root_window instead of
78 selected_window. This fixes a total window subsystem
79 malfunction reported by Bastien Guerry <bzg@gnu.org>.
80
8c2a0f2d
GM
812012-08-06 Glenn Morris <rgm@gnu.org>
82
83 * lisp.mk (lisp): Add language/persian.elc.
84
edd74c35
DA
852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Separate read and write access to Lisp_Object slots of struct frame.
88 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
89 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
90 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
91 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
92 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
93
8671676c
AS
942012-08-05 Andreas Schwab <schwab@linux-m68k.org>
95
96 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
97
663e2b3f
DA
982012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Generalize common compile-time constants.
101 * lisp.h (header_size, bool_header_size, word_size): Now here.
102 (struct Lisp_Vector): Add comment.
103 (struct Lisp_Bool_Vector): Move up to define handy constants.
104 (VECSIZE, PSEUDOVECSIZE): Simplify.
105 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
106 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
107 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
108 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
109 * xfont.c, xmenu.c: Use word_size where appropriate.
110
d32e47af
LM
1112012-08-05 Lawrence Mitchell <wence@gmx.li>
112
113 * search.c (Freplace_match): Treat \? in the replacement text
114 literally (Bug#8161).
115
e5d9c0d1
CY
1162012-08-05 Chong Yidong <cyd@gnu.org>
117
118 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
119 * frame.c (Vdelete_frame_functions):
120 * emacs.c (Vkill_emacs_hook): Doc fix.
121
8da0576b
EZ
1222012-08-04 Eli Zaretskii <eliz@gnu.org>
123
124 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
125 --with-x-toolkit=no builds.
126 Reported by Carsten Mattner <carstenmattner@gmail.com>.
127
02676e5d
CY
1282012-08-04 Chong Yidong <cyd@gnu.org>
129
130 * syntax.c (Fmodify_syntax_entry): Doc fix.
131
97147da9
EZ
1322012-08-04 Eli Zaretskii <eliz@gnu.org>
133
76151e2c
EZ
134 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
135 * w32.c (init_environment): Change the default values of many
136 environment variables in dflt_envvars[] to NULL, to avoid pushing
137 them into environment when they were not already defined. Remove
138 the code that deletes site-lisp subdirectories from the default
139 value of EMACSLOADPATH, as it is no longer needed.
140 (check_windows_init_file): Now external, not static. Use
141 Vload_path as is, without adding anything, as this function is now
142 called when Vload_path is already set up.
143
144 * w32.h (check_windows_init_file): Add prototype.
145
146 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
147 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
148 compatibility with Posix platforms.
149 (main): Move the call to check_windows_init_file to here from
150 w32.c.
151 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
152 any, in the DEFALT argument into the root of the Emacs build or
153 installation tree, as appropriate.
154
155 * callproc.c (init_callproc_1): Call decode_env_path instead of
156 doing its equivalent by hand.
157 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
158 the code that sets Vexec_path run on MS-Windows.
159
160 * lread.c (init_lread): Add comments to #ifdef's.
161
97147da9
EZ
162 * msdos.c (dos_set_window_size, IT_update_begin)
163 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
164 instead of direct references.
165
185ee146
PE
1662012-08-04 Paul Eggert <eggert@cs.ucla.edu>
167
168 Export DEFAULT_REHASH_* to GDB.
169 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
170 Now constants, not macros.
171
8834c57a
PE
1722012-08-03 Paul Eggert <eggert@cs.ucla.edu>
173
98c6f1e3
PE
174 Remove unnecessary casts involving pointers.
175 These casts are no longer needed now that we assume C89 or later,
176 since they involve casting to or from void *.
177 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
178 (make_pure_float, make_pure_vector):
179 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
180 * macros.c (Fstart_kbd_macro):
181 * menu.c (find_and_return_menu_selection):
182 * minibuf.c (read_minibuf_noninteractive):
183 * sysdep.c (closedir):
184 * xdisp.c (x_produce_glyphs):
185 * xfaces.c (compare_fonts_by_sort_order):
186 * xfns.c (x_real_positions, select_visual):
187 * xselect.c (x_stop_queuing_selection_requests)
188 (x_get_window_property, x_get_window_property_as_lisp_data):
189 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
190 Remove unnecessary pointer casts.
191 * alloc.c (record_xmalloc): New function.
192 * lisp.h (record_xmalloc): New decl.
193 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
194 more like a function. This is because the pointer cast is not
195 needed. All uses changed.
196 * print.c (print_string, print_error_message): Avoid length recalc.
197
8834c57a
PE
198 Improve fix for macroexp crash with debugging (Bug#12118).
199 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
200 ARRAY_MARK_FLAG when checking subscripts, because ASET is
201 not supposed to be invoked from the garbage collector.
202 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
203 (gc_aset): New function, which is like ASET but can be
204 used in the garbage collector.
205 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
206 (set_hash_index): Use it instead of ASET.
207
6dad7178
EZ
2082012-08-03 Eli Zaretskii <eliz@gnu.org>
209
210 Support symlinks on latest versions of MS-Windows.
211 * w32.c: Include winioctl.h and aclapi.h.
212 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
213 (revert_to_self): Forward declarations of static functions.
214 <static BOOL g_b_init_get_security_info>:
215 <g_b_init_create_symbolic_link>: New static flags.
216 (globals_of_w32): Initialize them to zero.
217 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
218 (map_w32_filename): Improve commentary. Simplify switch.
219 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
220 headers (most versions of MinGW w32api don't).
221 (get_security_info, create_symbolic_link)
222 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
223 New functions.
224 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
225 in the argument file name.
226 (sys_access): Call unc_volume_file_attributes only if
227 GetFileAttributes fails with network-related error codes.
228 (sys_rename): Diagnose renaming of a symlink when the user doesn't
229 have the required privileges.
230 (get_file_security_desc_by_name): Renamed from
231 get_file_security_desc.
232 (stat_worker): New function, with most of the guts of 'stat', and
233 with addition of handling of symlinks and support for 'lstat'. If
234 possible, get file's attributes and security information by
235 handle, not by name. Produce S_IFLNK bit for symlinks, when
236 called from 'lstat'.
237 (stat, lstat): New functions, call 'stat_worker'.
238 (symlink, readlink, careadlinkat): Rewritten to create and resolve
239 symlinks when the underlying filesystem supports them.
240
f162bcc3
PE
2412012-08-02 Paul Eggert <eggert@cs.ucla.edu>
242
79ea6c20
PE
243 Fix macroexp crash on Windows with debugging (Bug#12118).
244 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
245 checking subscripts; problem introduced with the recent
246 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
247 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
248 since it's used in non-static inline functions now.
249
c0ce93fd
PE
250 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
251 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 252
f162bcc3
PE
253 Use C99-style 'extern inline' if available.
254 * buffer.h (BUFFER_INLINE):
255 * category.h (CATEGORY_INLINE):
256 * character.h (CHARACTER_INLINE):
257 * charset.h (CHARSET_INLINE):
258 * composite.h (COMPOSITE_INLINE):
259 * dispextern.h (DISPEXTERN_INLINE):
260 * lisp.h (LISP_INLINE):
261 * systime.h (SYSTIME_INLINE):
262 New macro, replacing 'static inline' in this header.
263 * buffer.h, category.h, character.h, charset.h, composite.h:
264 * dispextern.h, lisp.h, systime.h:
265 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
266 * alloc.c (LISP_INLINE):
267 * buffer.c (BUFFER_INLINE):
268 * category.c (CATEGORY_INLINE):
269 * character.c (CHARACTER_INLINE):
270 * charset.c (CHARSET_INLINE):
271 * composite.c (COMPOSITE_INLINE):
272 * dispnew.c (DISPEXTERN_INLINE):
273 * sysdep.c (SYSTIME_INLINE):
274 Define to EXTERN_INLINE, so that the corresponding functions
275 are compiled into code.
276 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
277 (INLINE_HEADER_END): New macros.
278 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
279 since it's used in non-static inline functions now.
a8333d03 280 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 281
837b365b
GM
2822012-08-02 Glenn Morris <rgm@gnu.org>
283
d66b744d
GM
284 * s/: Remove empty directory.
285
837b365b
GM
286 * s/ms-w32.h: Move to ../nt/inc.
287 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
288 Update for new ms-w32.h location.
289
13294f95
PE
2902012-08-02 Paul Eggert <eggert@cs.ucla.edu>
291
292 Port to Solaris 8.
293 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
294
90df0db3
GM
2952012-08-02 Glenn Morris <rgm@gnu.org>
296
297 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
298 hard-coding the path separator.
299
4939150c
PE
3002012-08-01 Paul Eggert <eggert@cs.ucla.edu>
301
302 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
303 This how ASET and AREF are supposed to work, and makes
304 it easier to think about future improvements. See
305 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
306 * charset.h (set_charset_attr): New function.
307 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
308 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
309 (aref_addr): New function. All uses of &AREF(...) changed.
310 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
311 (set_hash_index): New functions. All lvalue-style uses of
312 HASH_KEY etc. changed.
313 * keyboard.c (set_prop): New function. All lvalue-style uses
314 of PROP changed.
315
947b2afd
AA
3162012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
317
318 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
319 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
320 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
321 * nsfns.m (ns_set_name_as_filename): Likewise.
322 * nsmenu.m (ns_update_menubar): Likewise.
323 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
324
4f5d0325
EZ
3252012-08-01 Eli Zaretskii <eliz@gnu.org>
326
2008beae
EZ
327 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
328 Adapt to latest changes in field names of the corresponding Lisp
288479f6 329 objects.
2008beae 330
4f5d0325
EZ
331 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
332
fe3cc771
GM
3332012-08-01 Glenn Morris <rgm@gnu.org>
334
335 * s/msdos.h: Remove file.
336 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
337 * Makefile.in (S_FILE): Remove.
338 (config_h): Remove S_FILE.
339
c90acc54
JB
3402012-08-01 Juanma Barranquero <lekktu@gmail.com>
341
342 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
343 Remove; moved to nt/config.nt.
344
d8a05828
DA
3452012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
346
347 Use INTERNAL_FIELD for conses and overlays.
348 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
349 Remove obsolete comment.
350 (MVAR): New macro.
351 (struct Lisp_Overlay): Use INTERNAL_FIELD.
352 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
353
8271d590
DA
3542012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Use INTERNAL_FIELD for symbols.
357 * lisp.h (SVAR): New macro. Adjust users.
358 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
359 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
360
3193acd2
DA
3612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
362
363 Use INTERNAL_FIELD for processes.
364 * process.h (PVAR): New macro. Adjust style.
365 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
366 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
367
3a45383a
DA
3682012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
369
370 Use INTERNAL_FIELD for windows.
371 * window.h (WVAR): New macro.
372 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
373 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
374 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
375 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
376 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
377 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
378
c1dbc63c
PE
3792012-08-01 Paul Eggert <eggert@cs.ucla.edu>
380
381 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
382
5c0c0e8a
GM
3832012-08-01 Glenn Morris <rgm@gnu.org>
384
385 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
386 Move to configure.ac.
387
552a99b4
JB
3882012-08-01 Juanma Barranquero <lekktu@gmail.com>
389
390 * makefile.w32-in (CONFIG_H): Update dependencies.
391 (CONF_POST_H): New macro.
392
393 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
394
8d8e2dfe
GM
3952012-07-31 Glenn Morris <rgm@gnu.org>
396
bc96620a
GM
397 * Makefile.in (S_FILE): No longer set by configure.
398
476b1b2d
GM
399 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
400 is available.
401 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
402
b2c7a106
GM
403 * process.h (NULL_DEVICE):
404 * emacs.c (SEPCHAR):
405 * editfns.c (USER_FULL_NAME): Let configure set them.
406
d53d062a
GM
407 * s/README, s/template.h: Remove files.
408
4515017f
GM
409 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
410
8d8e2dfe
GM
411 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
412 Move to configure.ac.
413
5b20b3cc
EZ
4142012-07-31 Eli Zaretskii <eliz@gnu.org>
415
1e0afd9a
EZ
416 * .gdbinit (xframe): Adapt to introduction of FVAR and the
417 resulting renaming of 'struct frame' members.
418
5b20b3cc
EZ
419 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
420
421 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
422 after introduction of FVAR.
423
f1310128
JD
4242012-07-31 Jan Djärv <jan.h.d@swipnet.se>
425
79e721e0
JD
426 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
427
428 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
429 instead of compositeToPoint.
430 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
431
8d7c7eed 432 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 433
e34f7f79
DA
4342012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
435
436 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
437 * lisp.h (INTERNAL_FIELD): New macro.
438 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
439 (BVAR): Change to use INTERNAL_FIELD.
440 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
441 (KVAR): Change to use INTERNAL_FIELD.
442 * frame.h (FVAR): New macro.
443 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
444 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
445 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
446 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
447 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
448
c09bfb2f
DA
4492012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Miscellaneous fixes for non-default X toolkits.
452 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
453 * xterm.c (x_frame_of_widget): Remove redundant prototype.
454 Move under #ifdef USE_LUCID.
455 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
456 definition and usage to avoid warnings.
457
14c114ae
JD
4582012-07-31 Jan Djärv <jan.h.d@swipnet.se>
459
460 * nsterm.m (openFiles): Fix previous checkin.
461
3bd21e82
PE
4622012-07-31 Paul Eggert <eggert@cs.ucla.edu>
463
464 * indent.c (compute_motion): Remove unused local.
465
c1529ded
GM
4662012-07-31 Glenn Morris <rgm@gnu.org>
467
400d5621
GM
468 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
469
268e2432
GM
470 * conf_post.h [USG5_4]:
471 Move remaining contents of s/usg5-4-common.h here.
472 * s/usg5-4-common.h: Remove file.
473
7552f3ee
GM
474 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
475 * s/irix6-5.h: Remove file.
476
6a381852
GM
477 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
478 * s/darwin.h: Remove file.
479
c1529ded
GM
480 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
481 * s/hpux10-20.h: Remove file, which is now empty.
482
b429a4ee
GM
4832012-07-30 Glenn Morris <rgm@gnu.org>
484
485 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
486 * Makefile.in (config_h): Add conf_post.h.
487 * makefile.w32-in (CONFIG_H): Add conf_post.h.
488
adff3182
JD
4892012-07-30 Jan Djärv <jan.h.d@swipnet.se>
490
491 * nsterm.m (ns_do_open_file): New variable.
b9031d69 492 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
493 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
494 files only if ns_do_open_file.
495
c32af1e4
PE
4962012-07-30 Paul Eggert <eggert@cs.ucla.edu>
497
7393bcbb
PE
498 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
499 This no-op macro hasn't been needed for many years.
500 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
501
c32af1e4
PE
502 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
503 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
504 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
505 gdb_make_enums_visible.
506 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
507 (DIRECTORY_SEP): Now a constant, not a macro.
508
302fc036
EZ
5092012-07-30 Eli Zaretskii <eliz@gnu.org>
510
511 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
512 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
513
514 * w32term.c <w32_keyboard_codepage>: Renamed from
515 keyboard_codepage and now external. All users changed.
516
517 * w32term.h: Add declaration of w32_keyboard_codepage.
518
519 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
520 the codepage to translate keys to Unicode. If this argument is
521 -1, use the value returned by GetConsoleCP. All callers changed.
522
88fb40b4
PE
5232012-07-30 Paul Eggert <eggert@cs.ucla.edu>
524
0aee6912
PE
525 Update .PHONY listings in makefiles.
526 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
527 bootstrap-clean, distclean, maintainer-clean, versioclean,
528 extraclean, frc.
529
88fb40b4
PE
530 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
531 This is a bit clearer. Fix some commentary typos.
532
0a763bd1
GM
5332012-07-30 Glenn Morris <rgm@gnu.org>
534
32bac6d6
GM
535 * s/netbsd.h: Let configure include signal.h if needed.
536 Remove file, which is now empty.
537
b65e7c46
GM
538 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
539 Let configure set them.
540 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
541 No more need to undefine.
0a763bd1 542
169304bd
AS
5432012-07-30 Andreas Schwab <schwab@linux-m68k.org>
544
545 * keymap.c (Fkey_description): Don't remove 0x80 bit from
546 non-single-byte char when adding meta modifier. (Bug#12090)
547
6cd7a139
DA
5482012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Convert safe_call to use variable number of arguments.
551 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
552 (safe_call2): Fix comment.
553 * lisp.h (safe_call): Adjust prototype.
554 * coding.c (encode_coding_object): Change to use safe_call2.
555 * xfaces.c (merge_face_heights): Change to use safe_call1.
556
d34d6ffc
GM
5572012-07-30 Glenn Morris <rgm@gnu.org>
558
7b8a48e4 559 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 560 does that unconditionally. Remove file, which is now empty.
7b8a48e4 561
d34d6ffc
GM
562 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
563 Remove empty files.
564
03a660a6
PE
5652012-07-30 Paul Eggert <eggert@cs.ucla.edu>
566
567 Export to GDB most of lisp.h's remaining object-like macros.
568 * lisp.h (min, max): Move earlier, because they're used earlier now.
569 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
570 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
571 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
572 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
573 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
574 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
575 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
576 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
577 Now constants, for GDB. They need not be macros.
578 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
579 Now constants, for GDB, as well as macros, for static initializers.
580 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
581 Move to after the definition of struct Lisp_Char_Table,
582 since the former now needs that type defined.
583 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
584 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
585 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
586 New enums, for gdb_make_enums_visible.
587 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 588 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
589 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
590 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
591 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
592 enum maxargs, enum MAX_ALLOCA.
593 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
594 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
595 no longer needed, now that they are done in lisp.h.
596
e499d0ee
DA
5972012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Cleanup string bytes checking.
600 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
601 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
602 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
603 (check_sblock, compact_small_strings): Simplify.
604
d5040d2d
PE
6052012-07-29 Paul Eggert <eggert@cs.ucla.edu>
606
607 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
608 These macros are confusing and no longer need to be defined, as
609 the enum values now suffice. All uses replaced with definiens.
610 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
611
7f259ae6
JB
6122012-07-29 Juanma Barranquero <lekktu@gmail.com>
613
614 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
615 ($(BLD)/w32console.$(O)): Update dependencies.
616
7e63e0c3
DA
6172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
620 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
621 time. Adjust users.
622 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
623
ffd817eb
JD
6242012-07-29 Jan Djärv <jan.h.d@swipnet.se>
625
626 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
627 setting sitelisp (Bug#12010).
628
417a7a0e
EZ
6292012-07-29 Eli Zaretskii <eliz@gnu.org>
630
631 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
632
633 * w32heap.c (cache_system_info):
634 * w32.c (sys_rename):
635 * w32proc.c (find_child_console, sys_kill): All users changed.
636
387d4d92
PE
6372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
638
639 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
640
55a6cca6
EZ
6412012-07-29 Eli Zaretskii <eliz@gnu.org>
642
643 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
644
dbcf001c
DA
6452012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Cleanup statistics calculation in Fgarbage_collect.
648 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
649 zombies percentage calculation. Simplify elapsed time calculation.
650
e2688e4a
DA
6512012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
652
653 Generalize marker debugging code under MARKER_DEBUG and use eassert.
654 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
655 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
656 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
657 (replace_range, replace_range_2, del_range_2): Change to eassert.
658 * marker.c (byte_char_debug_check): Adjust style.
659
b46a6a83
PE
6602012-07-29 Paul Eggert <eggert@cs.ucla.edu>
661
662 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
663 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
664 long-ago-commented-out code that talks about "WIN32".
665 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
666 All uses changed.
667
e32a5799
PE
6682012-07-28 Paul Eggert <eggert@cs.ucla.edu>
669
670 Use Gnulib stdalign module (Bug#9772, Bug#9960).
671 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
672 Simplify by using alignof.
673 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
674 * lisp.h: Include <stdalign.h>.
675 (GCALIGNMENT): New macro and constant.
676 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
677 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
678 (stdalign): New macro, if not already defined.
679
df81cd29
EZ
6802012-07-28 Eli Zaretskii <eliz@gnu.org>
681
01bd1b0d
EZ
682 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
683 * w32inevt.c: Include w32inevt.h.
684 (w32_read_console_input): New inline function, calls either
685 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
686 w32_console_unicode_input.
687 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
688 (w32_kbd_patch_key, key_event): Use the codepage returned by
689 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
690 (key_event): use uChar.UnicodeChar only if
691 w32_console_unicode_input is non-zero.
692
693 * w32console.c: Include w32heap.h.
694 <w32_console_unicode_input>: New global variable.
695 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
696 family of Windows, zero otherwise.
697
698 * w32inevt.h: Declare w32_console_unicode_input.
699
df81cd29
EZ
700 * xdisp.c (init_iterator): Don't reference tip_frame in a build
701 --without-x. (Bug#11742)
702
c20fdd9e
PE
7032012-07-27 Paul Eggert <eggert@cs.ucla.edu>
704
705 Adjust GDB to reflect pvec_type changes (Bug#12036).
706 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
707 2012-07-04 changes to pseudovector representation. Problem
708 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
709
32770973 7102012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
711
712 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
713 bus address.
714 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
715
3438fe21
EZ
7162012-07-27 Eli Zaretskii <eliz@gnu.org>
717
bcfbc9de
EZ
718 * alloc.c (listn): Fix the order the arguments are consed onto the
719 list.
720
3438fe21
EZ
721 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
722 enumeration constants, as PURE and HEAP are too general, and clash
723 with other headers and sources, such as gmalloc.c and the
724 MS-Windows system headers. All users changed.
725
eeaea515
DA
7262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Revert last save_excursion_save and save_excursion_restore changes.
729 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
730 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
731
073c88c2
DA
7322012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Fix recently-introduced typos in Windows port.
735 Reported by Martin Rudalics <rudalics@gmx.at>.
736 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 737 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 738
4706125e
PE
7392012-07-27 Paul Eggert <eggert@cs.ucla.edu>
740
741 Improve GDB symbol export (Bug#12036).
742 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
743 arms of an 'if', not using conditional expressions; otherwise GDB
744 complains about the types in the unevaluated arm when the argument
745 is an integer literal.
746 (xgetint): Simplify expression.
747 * alloc.c (gdb_make_enums_visible): New constant. This ports to
748 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
749 Zaretskii in <http://bugs.gnu.org/12036#13>.
750 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
751 needed now that we have gdb_make_enums_visible.
752 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
753 (enum enum_USE_LSB_TAG):
754 New enum types, packaging up enums that need to be exported to GDB.
755
694b6c97
DA
7562012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
757
758 Utility function to make a list from specified amount of objects.
759 * lisp.h (enum constype): New datatype.
760 (listn): New prototype.
761 * alloc.c (listn): New function.
762 (Fmemory_use_count, syms_of_alloc): Use it.
763 * buffer.c (syms_of_buffer): Likewise.
764 * callint.c (syms_of_callint): Likewise.
765 * charset.c (define_charset_internal): Likewise.
766 * coding.c (syms_of_coding): Likewise.
767 * keymap.c (syms_of_keymap): Likewise.
768 * search.c (syms_of_search): Likewise.
769 * syntax.c (syms_of_syntax): Likewise.
770 * w32.c (init_environment): Likewise.
771 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
772 * xdisp.c (syms_of_xdisp): Likewise.
773 * xfns.c (syms_of_xfns): Likewise.
774
6195f384
DA
7752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Fast save_excursion_save and save_excursion_restore.
778 * lisp.h (struct Lisp_Excursion): New data type.
779 (PVEC_EXCURSION): New pseudovector type.
780 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
781 to deal with it. Adjust comments.
782 (init_marker, attach_marker): New prototype.
783 (unchain_marker): Adjust prototype.
784 * marker.c (attach_marker): Change to global.
785 (init_marker): New function.
786 * alloc.c (Fmake_marker, build_marker): Use it.
787 (build_marker): More easserts.
788 (mark_object): Handle struct Lisp_Excursion.
789 * editfns.c (save_excursion_save, save_excursion_restore):
790 Reimplement to use struct Lisp_Excursion. Add comments.
791
5eceb8fb
PE
7922012-07-26 Paul Eggert <eggert@cs.ucla.edu>
793
794 Fix export of symbols to GDB (Bug#12036).
795 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
796 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
797 emacs.c, as this is a more-suitable home. Had this been done earlier
798 the fix for 12036 would have avoided some of the problems noted in
799 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
800 would have been more obvious.
562157c8
PE
801 * emacs.c: Do not include <verify.h>; no longer needed.
802 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
803 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
804 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
805 Remove; now done in lisp.h.
806 * lisp.h (PUBLISH_TO_GDB): New macro.
807 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
808 (DATA_SEG_BITS): Use it.
809 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
810 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
811 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
812 not be usable in #if. This simplifies things.
813
d6749401
JB
8142012-07-26 Juanma Barranquero <lekktu@gmail.com>
815
816 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
817
1781b9e9
PE
8182012-07-26 Paul Eggert <eggert@cs.ucla.edu>
819
d89518db 820 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
821 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
822 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
823 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
824 Adjust to changes in lisp.h and emacs.c, by using
825 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
826 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
827 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
828 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
829 instead of gdb_valbits.
830 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
831 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
832 instead of gdb_array_mark_flag.
833 (xboolvector): Get size from $->size, not $->header.size.
834 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
835 (xreload, hook-run, hookpost-run): Remove.
836 * emacs.c: Include <verify.h>.
837 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
838 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
839 Remove.
840 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
841 (gdb_USE_LSB_TAG): New enum constants.
842 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
843 Also define these as enum constants, so they're visible to GDB.
844 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
845 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
846 as constants, so they're visible to GDB.
847 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
848 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
849 Now enum constants, not macros, so they're visible to GDB.
850 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
851 more convenient now. All uses changed.
852 (VALMASK) [USE_LSB_TAG]: Also define in this case.
853 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
854
3628596a
DA
8552012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
856
857 Explicitly free restriction data that are not needed anymore.
858 * editfns.c (save_restriction_restore): Free restriction data.
859
7abaf5cc
SM
8602012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
861
862 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
863 add argument, tune behavior, and adjust all callers.
864
71f88e00
PE
8652012-07-25 Paul Eggert <eggert@cs.ucla.edu>
866
867 Use typedef for EMACS_INT, EMACS_UINT.
868 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
869 than macros. This simplifies debugging in the usual case, since
870 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
871 and it allows expressions involving EMACS_INT casts.
872 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
873
57ec3034
JD
8742012-07-25 Jan Djärv <jan.h.d@swipnet.se>
875
876 * nsterm.m (ns_read_socket): Return early if there is a modal
877 window (Bug#12043).
878
8137e7b3
MR
8792012-07-25 Martin Rudalics <rudalics@gmx.at>
880
881 * frame.c (Fredirect_frame_focus): In doc-string don't mention
882 that FOCUS-FRAME can be omitted.
883
04e9897c
DA
8842012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Adjust buffer text indirection counters at the end of Fkill_buffer.
887 * buffer.c (Fkill_buffer): Adjust indirection counters when the
888 buffer is definitely dead. This should really fix an issue reported
889 by Christoph Scholtes again. (Bug#12007).
890 (init_buffer_once): Initialize indirection counters of
891 buffer_defaults and buffer_local_symbols (for sanity and safety).
892
8a0484e1
EZ
8932012-07-24 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (init_iterator): Don't compute dimensions of truncation
896 and continuation glyphs on tooltip frames, leave them at zero.
897 Avoids continued lines in tooltips. (Bug#11832)
898
fa691a83
DA
8992012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Simplify copy_overlay.
04e9897c 902 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
903 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
904
436bc8e0
EZ
9052012-07-23 Eli Zaretskii <eliz@gnu.org>
906
907 * print.c (print_object): Don't crash when a frame's name is nil
908 or invalid. (Bug#12025)
909
910 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
911 it signals an error when a tooltip frame is being created.
912
d7a7fda3
DA
9132012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Cleanup miscellaneous objects allocation and initialization.
916 * alloc.c (allocate_misc): Change to static. Add argument to
917 specify the subtype. Adjust comment and users.
918 (build_overlay): New function.
919 * buffer.c (copy_overlays, Fmake_overlay): Use it.
920 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
921 (allocate_misc): Remove prototype.
922 (build_overlay): Add prototype.
923
9242012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
925
926 Swap buffer text indirection counters in Fbuffer_swap_text.
927 * buffer.c (Fbuffer_swap_text): Swap indirections too.
928 This avoids crash reported by Christoph Scholtes at
929 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
930
9d7fa573
JD
9312012-07-22 Jan Djärv <jan.h.d@swipnet.se>
932
933 * nsmenu.m (Popdown_data): New struct.
934 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
935 free Popdown_data.
936 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
937 (initWithContentRect): Make imgView and contentView non-static
938 and autorelease them. Also autorelease img and matrix (Bug#12005).
939 (dealloc): Remove (Bug#12005).
940
0dd6d66d
DA
9412012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Adjust consing_since_gc when objects are explicitly freed.
944 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
945 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
946 (free_cons, free_misc): Subtract object size from consing_since_gc.
947
d36d71df
DA
9482012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
949
950 Simplify and cleanup markers positioning code.
951 * marker.c (attach_marker): More useful eassert.
952 (live_buffer, set_marker_internal): New function.
953 (Fset_marker, set_marker_restricted): Use set_marker_internal.
954 (set_marker_both, set_marker_restricted_both): Use live_buffer.
955
fb9ea40f
PE
9562012-07-22 Paul Eggert <eggert@cs.ucla.edu>
957
958 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
959 as it's limited by the amount of memory, not by INT_MAX.
960
2d5c5f7d
EZ
9612012-07-21 Eli Zaretskii <eliz@gnu.org>
962
07fb592e
EZ
963 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
964 in special-event-map. See the discussion at
965 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
966 for the reasons.
967
37a9eac8 968 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
969 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
970 Fabrice Popineau <fabrice.popineau@supelec.fr>.
971
c4328746
JD
9722012-07-21 Jan Djärv <jan.h.d@swipnet.se>
973
974 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 975 (conversationIdentifier): Return value is NSInteger.
784051c4 976 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 977
6e5d1c12
CY
9782012-07-21 Chong Yidong <cyd@gnu.org>
979
980 * window.c (decode_any_window): Signal an error if the window is
981 on a dead frame (Bug#11984).
982
9928463d
DA
9832012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
984
985 Add indirection counting to speed up Fkill_buffer.
986 * buffer.h (struct buffer): New member.
987 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
988 (Fmake_indirect_buffer): Set indirection counter to -1, increment
989 base buffer indirection counter.
990 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
991 (Fkill_buffer): Adjust indirection counters as needed, don't walk
992 through buffer list if indirection counter is 0.
993
f8643a6b
DA
9942012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Extend the value returned by Fgarbage_collect with heap statistics.
997 * alloc.c (Qheap): New symbol.
998 (syms_of_alloc): DEFSYM it.
999 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1000 (Fmemory_free): Remove.
1001 (syms_of_alloc): Don't defsubr it.
1002 * buffer.c (Fcompact_buffer): Remove.
1003 (syms_of_buffer): Don't defsubr it.
1004
dac616ff
DA
10052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 Make maybe_gc inline.
1008 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1009 * lisp.h (consing_since_gc, gc_relative_threshold)
1010 (memory_full_cons_threshold): Revert declaration.
1011 (maybe_gc): Remove prototype, define as inline.
1012 * alloc.c: Remove old commented-out code.
1013 (consing_since_gc, gc_relative_threshold)
1014 (memory_full_cons_threshold): Revert to global.
1015 (maybe_gc): Remove.
1016
d7ea76b4
DA
10172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1020 * lisp.h (build_unibyte_string): New function.
1021 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1022 * sysdep.c, w32fns.c, xfns.c: Use it.
1023 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1024 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1025 Adjust users accordingly.
1026 * font.h (font_open_by_name): Adjust prototype.
1027
765e61e3
DA
10282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Cleanup calls to Fgarbage_collect.
1031 * lisp.h (maybe_gc): New prototype.
1032 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1033 Remove declarations.
1034 * alloc.c (maybe_gc): New function.
1035 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1036 Make them static.
1037 * bytecode.c (MAYBE_GC): Use maybe_gc.
1038 * eval.c (eval_sub, Ffuncall): Likewise.
1039 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1040 to avoid dependency from auto-save feature.
1041
52b852c7
PE
10422012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1045 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1046 'for_each_per_buffer_object_at'.
1047 All uses changed. It's better to use upper-case for macros that
1048 cannot be implemented as functions, to give the reader a clue
1049 that they're special.
1050
5db81e33
SM
10512012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1052
1053 * alloc.c (Fgarbage_collect): Tweak docstring.
1054
5b835e1d
DA
10552012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 Tweak the value returned from Fgarbage_collect again.
1058 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1059 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1060 Adjust documentation.
1061 (total_vector_bytes): Rename to total_vector_slots, adjust
1062 accounting.
1063 (total_free_vector_bytes): Rename to total_free_vector_slots,
1064 adjust accounting.
1065 (Qstring_bytes, Qvector_slots): New symbols.
1066 (syms_of_alloc): DEFSYM them.
1067
9cd47b72
DA
10682012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1069
1070 Buffer compaction primitive which may be used from Lisp.
1071 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1072 (syms_of_buffer): Register Fcompact_buffer.
1073 * alloc.c (Fgarbage_collect): Use compact_buffer.
1074 * buffer.h (compact_buffer): New prototype.
1075 (struct buffer_text): New member.
1076
d17337e5
DA
10772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 New macro to iterate over all buffers, miscellaneous cleanups.
1080 * lisp.h (all_buffers): Remove declaration.
1081 * buffer.h (all_buffers): Add declaration, with comment.
1082 (for_each_buffer): New macro.
1083 * alloc.c (Fgarbage_collect, mark_object): Use it.
1084 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1085 (init_buffer): Likewise.
1086 * data.c (Fset_default): Likewise.
1087 * coding.c (code_conversion_restore): Remove redundant check
1088 for dead buffer.
1089 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1090
60cfd278
AS
10912012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1092
1093 Fix bug that created negative-length intervals.
1094 * intervals.c (merge_interval_right, merge_interval_left):
1095 Do not zero out this interval if it is absorbed by its children,
1096 as this interval's total length doesn't change in that case. See
1097 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1098
d06714cb
PE
10992012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1100
83713154
PE
1101 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1102 when invoking (make-bool-vector N t) and N is a positive
1103 multiple of 8 -- the last 8 bits were mistakenly cleared.
1104
d06714cb
PE
1105 Remove some struct layout assumptions in bool vectors.
1106 * alloc.c (bool_header_size): New constant.
1107 (header_size, word_size): Move earlier, as they're now used earlier.
1108 Use 'word_size' in a few more places, where it's appropriate.
1109 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1110 padding before the data member of a bool vector.
1111 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1112 than doing the check by hand with an abort ().
1113
464d5a5e
SM
11142012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1115
5fbc0409
SM
1116 * eval.c (Fdefvar): Don't check constants since we only set the var if
1117 it's not yet defined anyway (bug#11904).
1118
464d5a5e
SM
1119 * lisp.h (last_undo_boundary): Declare new var.
1120 * keyboard.c (command_loop_1): Set it.
1121 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1122 were auto-added by the command loop (bug#11774).
1123
8dc2e44a
AS
11242012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1125
1126 * w32font.c (Qsymbol): Remove local definition.
1127 (syms_of_w32font): Don't DEFSYM it.
1128
169925ec
DA
11292012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 Fix sweep_vectors to handle large bool vectors correctly.
1132 * alloc.c (sweep_vectors): Account total_vector_bytes for
1133 bool vectors larger than VBLOCK_BYTES_MAX.
1134
5fbfb018
CY
11352012-07-18 Chong Yidong <cyd@gnu.org>
1136
1137 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1138 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1139
3ab6e069
DA
11402012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1141
1142 Return more descriptive data from Fgarbage_collect.
1143 Suggested by Stefan Monnier in
1144 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1145 * alloc.c (bounded_number): New function.
1146 (total_buffers, total_vectors): New variable.
1147 (total_string_size): Rename to total_string_bytes, adjust users.
1148 (total_vector_size): Rename to total_vector_bytes, adjust users.
1149 (sweep_vectors): Account total_vectors and total_vector_bytes.
1150 (Fgarbage_collect): New return value. Adjust documentation.
1151 (gc_sweep): Account total_buffers.
1152 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1153 (VECTOR_SIZE): Remove.
1154 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1155 (Qinterval, Qmisc): New symbols.
1156 (syms_of_data): Initialize them.
1157 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1158 (Qcons, Qbuffer): New declarations.
1159
6d02fe5b
PE
11602012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1163 Round up, not down. Improve doc.
1164
b7ffe040
DA
11652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 Restore old code in allocate_string_data to avoid Faset breakage.
1168 Reported by Julien Danjou <julien@danjou.info> in
1169 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1170 * alloc.c (allocate_string_data): Restore old code with minor
1171 adjustments, fix comment to explain this subtle issue.
1172
4dc7c8d5
SM
11732012-07-17 Eli Zaretskii <eliz@gnu.org>
1174
1175 Remove FILE_SYSTEM_CASE.
1176 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1177
1178 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1179 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1180 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1181 call-process-region passes it through expand-file-name.
1182
1183 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1184
11852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1186
1187 Fix crash when creating indirect buffer (Bug#11917)
1188 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1189 Don't handle unbound variables specially if non-zero.
1190 (Fbuffer_local_variables): Pass zero.
1191 (clone_per_buffer_values): Pass non-zero.
1192
11932012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1194
1195 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1196 to make the loop interruptible.
1197
11982012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1199
1200 * gnutls.c (emacs_gnutls_handshake): Only retry if
1201 GNUTLS_E_INTERRUPTED.
1202
cce7fefc
DA
12032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 Cleanup and convert miscellaneous checks to eassert.
1206 * alloc.c (mark_interval): Fix comment, partially rephrase
1207 old comment from intervals.h (see below).
1208 * intervals.c (find_interval, adjust_intervals_for_insertion)
1209 (delete_interval, adjust_intervals_for_deletion)
1210 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1211 Convert to eassert.
1212 (adjust_intervals_for_insertion, make_new_interval):
1213 Remove obsolete and unused code.
1214 * intervals.h (struct interval): Remove obsolete comment.
1215 * textprotp.c (erase_properties): Remove unused code.
1216 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1217 (Fremove_list_of_text_properties): Convert to eassert.
1218
9ea10cc3
CY
12192012-07-17 Chong Yidong <cyd@gnu.org>
1220
1221 * editfns.c (Finsert_char): Doc fix.
1222
3900d5de
DA
12232012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1224
1225 Fix previous change to make Fmemory_free always accurate.
1226 * alloc.c (make_interval): Update total_free_intervals.
1227 (make_float): Likewise for total_free_floats.
1228 (free_cons, Fcons): Likewise for total_free_conses.
1229 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1230 Likewise for total_free_vector_bytes.
1231 (Fmake_symbol): Likewise for total_free_symbols.
1232 (bytes_free): Remove.
1233
7098646f
DA
12342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 Simple free memory accounting feature.
1237 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1238 (sweep_vectors): Accumulate size of free vectors.
1239 (Fgarbage_collect): Setup bytes_free.
1240 (Fmemory_free): New function.
1241 (syms_of_alloc): Register it.
1242
22657b40
DA
12432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1244
1245 Cleanup overlays checking.
1246 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1247 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1248 eassert and OVERLAYP.
1249 (sort_overlays): Change to use OVERLAYP.
1250
ddfc8813
RK
12512012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1252
1253 * editfns.c (Finsert_char): Make it interactive, and make the
1254 second arg optional. Copy interactive spec and docstring from
1255 ucs-insert.
1256
7c26cf3c
PE
12572012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1260 Unlike the other wrapped functions, fabs has an unspecified
1261 effect on errno.
1262
5d127af9
JD
12632012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1264
1265 * nsterm.m (keyDown): Interpret flags without left/right bits
1266 as the left key (Bug#11670).
1267
6a0dd1d7
DA
12682012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Remove empty and useless init functions.
1271 * lisp.h (init_character_once, init_fns, init_image)
1272 (init_filelock, init_sound): Remove prototype.
1273 * character.c (init_character_once): Remove.
1274 * filelock.c (init_filelock): Likewise.
1275 * fns.c (init_fns): Likewise.
1276 * image.c (init_image): Likewise.
1277 * sound.c (init_sound): Likewise.
1278 * emacs.c (main): Adjust accordingly.
1279
7a6136fd
DA
12802012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1281
1282 * gtkutil.h: Tiny cleanups.
1283 (use_old_gtk_file_dialog): Remove useless declaration.
1284 (xg_uses_old_file_dialog): Add suggested const attribute.
1285
ce811ad9
EZ
12862012-07-15 Eli Zaretskii <eliz@gnu.org>
1287
1288 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1289 (bidi_paragraph_init): Use it to limit search forward for a strong
1290 directional character in abnormally large paragraphs full of
1291 neutral or weak characters. (Bug#11943)
1292
c9adfeaa
SF
12932012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1294
1295 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1296 the toolbar (Bug#9451).
1297 (xg_make_tool_item): Give the widget event box a transparent
1298 background.
1299
fff62aa9
DA
13002012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1301
1302 Cleanup basic allocation variables and functions.
1303 * alloc.c (ignore_warnings, init_intervals, init_float)
1304 (init_cons, init_symbol, init_marker): Remove.
1305 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1306 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1307 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1308 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1309 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1310 (staticidx, init_alloc_once, init_strings, free_ablock):
1311 Remove redundant initialization.
1312 * fns.c (init_weak_hash_tables): Remove.
1313 * lisp.h (init_weak_hash_tables): Remove prototype.
1314
9730daca
DA
13152012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1316
1317 Use zero_vector where appropriate.
1318 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1319 accordingly.
1320 * lisp.h (zero_vector): New declaration.
1321 * font.c (null_vector): Remove.
1322 (syms_of_font): Remove initialization and staticpro.
1323 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1324 * keymap.c (Faccessible_keymaps): Likewise.
1325
2e2d2a13
LL
13262012-07-15 Leo Liu <sdl.web@gmail.com>
1327
1328 * fringe.c: Fix typo in comments.
1329
cd276f6e
LL
13302012-07-14 Leo Liu <sdl.web@gmail.com>
1331
1332 * fringe.c: Add a new bitmap exclamation-mark.
1333
5a1131d9
EZ
13342012-07-14 Eli Zaretskii <eliz@gnu.org>
1335
1336 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1337
1338 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1339 (HAVE_MENUS): Don't define, defined by editing config.in with
1340 msdos/sed2v2.inp.
1341 (GMALLOC_INHIBIT_VALLOC): Don't define.
1342 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1343
22e983b7
JB
13442012-07-14 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1347
5b3f250f
GM
13482012-07-14 Glenn Morris <rgm@gnu.org>
1349
1350 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1351 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1352 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1353
33d63ff4
GM
13542012-07-13 Glenn Morris <rgm@gnu.org>
1355
5b633342
GM
1356 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1357
33d63ff4
GM
1358 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1359 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1360
b55b9f85
JD
13612012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1362
0dc8cf50
JD
1363 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1364 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1365 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1366 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1367 where appropriate.
1368 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1369 as boolean expression.
1370 (x_set_window_size): Remove unused variable toolbar.
1371 (ns_get_color_default, ns_mod_to_lisp): Remove.
1372 (ns_mouse_position): Remove unused variables xchar and ychar.
1373 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1374 (ns_set_vertical_scroll_bar): Remove unused variable count.
1375 (ns_delete_terminal): Remove unused variable i.
1376 (ns_term_init): Remove unused variables r, g and b.
1377 (mouseDown): Remove unused variable window.
1378 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1379 (initFrameFromEmacs): Remove unused variable vbextra.
1380 (mouseEntered): Remove unused variables p and dpyinfo.
1381 (mouseExited): Remove unused variables p and r.
1382 (ns_define_frame_cursor, ns_clear_frame_area)
1383 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1384 (menuDown): Assign [sender tag] to variable and cast the variable.
1385
1386 * nsterm.h (menuDown): Add id as type to argument sender.
1387 (ns_display_info_for_name): Add Lisp_Object argument.
1388 (ns_term_init): Add Lisp_Object argument.
1389 (ns_map_event_to_object): Add void argument.
1390 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1391 prototype with arguments and only declare if __OBJC__.
1392 (nxatoms_of_nsselect): Add void argument.
1393 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1394 (ns_alloc_autorelease_pool): Add void argument.
1395 (ns_release_autorelease_pool): Add void* argument.
1396 (ns_get_defaults_value): Add const char* argument.
1397
1398 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1399 (initFromContents): Use SSDATA where appropriate.
1400 (ns_update_menubar): Add braces to ambigous if-else.
1401 (initWithTitle): Put () around assignment in if statement.
1402 (ns_menu_show): Remove unused variables window and keymap.
1403 (update_frame_tool_bar): Remove unused variable selected_p.
1404 (initWithContentRect): Remove unused variable this_cmd_name.
1405
1406 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1407 appropriate.
1408 (setXBMColor): Remove unused variable len.
1409 (setPixmapData): Put () around assignment in loop statement.
1410
1411 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1412 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1413 where appropriate.
1414 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1415 around assignment in loop statement.
1416 (nsfont_open): Remove unused variable i.
1417 (nsfont_open): Remove unused variable len.
1418 (nsfont_draw): Remove unused variable cs.
1419
1420 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1421 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1422 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1423 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1424 (Fns_font_name, Fns_perform_service)
1425 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1426 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1427 (ns_set_name): Remove unused variable view.
1428 (x_set_menu_bar_lines): Remove unused variable olines.
1429 (x_set_tool_bar_lines): Remove unused variable root_window.
1430 (Fns_list_colors): Put () around assignment in while statement.
1431 (Fns_perform_service): Remove unused variable len.
1432 (Fns_display_usable_bounds): Remove unused variable top.
1433 (syms_of_nsfns): Remove unused variable i.
1434
b55b9f85
JD
1435 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1436 memcpy (Bug#11907).
1437
ed9265fc 14382012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1439
1440 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1441 and free it with DestroyExceptionInfo (Bug#11558).
1442
ef099b57
JB
14432012-07-13 Juanma Barranquero <lekktu@gmail.com>
1444
1445 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1446 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1447 Set here, not in nt/config.nt.
1448
ea814a5d
EZ
14492012-07-13 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1452 cursor overflow into the last glyph on display line when the right
1453 fringe is off. (Bug#11832)
1454
1a952767
PE
14552012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 * xdisp.c (produce_special_glyphs): Now static.
1458 * dispextern.h (produce_special_glyphs): Remove decl.
1459
983188fd
GM
14602012-07-13 Glenn Morris <rgm@gnu.org>
1461
8d7c7eed 1462 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1463 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1464
983188fd
GM
1465 * s/usg5-4-common.h (USG, USG5):
1466 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1467 * s/sol2-6.h (SOLARIS2):
1468 * s/irix6-5.h (IRIX6_5):
1469 * s/hpux10-20.h (USG, USG5, HPUX):
1470 * s/gnu-linux.h (USG, GNU_LINUX):
1471 * s/freebsd.h (BSD_SYSTEM):
1472 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1473 * s/cygwin.h (CYGWIN):
1474 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1475 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1476
d1e68667 14772012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1478
1479 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1480
6de0e799
GM
14812012-07-13 Glenn Morris <rgm@gnu.org>
1482
739ae010
GM
1483 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1484
dbee5793
GM
1485 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1486
6de0e799
GM
1487 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1488 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1489
b82da769
GM
14902012-07-12 Glenn Morris <rgm@gnu.org>
1491
4fae5a7a 1492 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1493
1494 * process.c (init_process_emacs): Rename from init_process.
1495 The old name is also the name of a Mach system call.
1496 * lisp.h, emacs.c: Update for this name change.
1497 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1498 longer needed.
1499
5a979817
EZ
15002012-07-12 Eli Zaretskii <eliz@gnu.org>
1501
1502 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1503 memmove call that removes glyphs covered by the left truncation
1504 glyph. Improve commentary.
1505 (display_line): Fix display of continuation glyphs on GUI frames
1506 when the right fringe is turned off and variable-size fonts are
1507 used in the window. Move the code that appends a stretch glyph to
1508 produce_special_glyphs, so that it could be used for truncation
1509 and continuation glyphs alike.
1510 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1511 glyph of a suitably computed width, to align the special glyphs at
1512 the window margin. Code moved from display_line. (Bug#11832)
1513
3e91a053
GM
15142012-07-12 Glenn Morris <rgm@gnu.org>
1515
ba9e4b84
GM
1516 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1517
1518 * s/gnu-linux.h, s/hpux10-20.h:
1519 Do not unconditionally define HAVE_XRMSETDATABASE.
1520
3e91a053
GM
1521 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1522
b300b1f4
PE
15232012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Fix typos that broke OS X build.
1526 Reported by Randal L. Schwartz in
1527 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1528 * nsterm.m (ns_timeout): Add missing local decl.
1529 (ns_get_color): snprintf -> sprintf, to fix typo.
1530
6e777848
GM
15312012-07-12 Glenn Morris <rgm@gnu.org>
1532
3f922c37
GM
1533 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1534 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1535 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1536 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1537
0ab7b23a
GM
1538 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1539 Move PTY_OPEN to configure.
1540
6e777848
GM
1541 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1542 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1543 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1544
4a7edc24
DA
15452012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1546
1547 Use empty_unibyte_string where applicable.
1548 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1549 * lread.c (read1): Likewise.
1550 * xsettings.c (syms_of_xsettings): Likewise.
1551
308aab79
GM
15522012-07-12 Glenn Morris <rgm@gnu.org>
1553
42bd1719
GM
1554 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1555 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1556 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1557 * s/hpux10-20.h (RUN_TIME_REMAP):
1558 * s/bsd-common.h (TABDLY): Move to configure.
1559
1560 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1561
1562 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1563
ea0bbd17 1564 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1565 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1566
1567 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1568
308aab79
GM
1569 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1570 * s/template.h: Move NARROWPROTO to configure.
1571
ee1cf5cf
GM
15722012-07-11 Glenn Morris <rgm@gnu.org>
1573
30fe9bf4
GM
1574 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1575 unused since 2011-01-17 change to systty.h.
1576
ee1cf5cf
GM
1577 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1578 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1579 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1580
63e47e07
PE
15812012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1584
c43fb4c3
GM
15852012-07-11 Glenn Morris <rgm@gnu.org>
1586
1587 * s/darwin.h, s/gnu-linux.h, s/template.h:
1588 Move INTERRUPT_INPUT to configure.
1589
e8df9267
DA
15902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Minor adjustments to interning code.
1593 * lisp.h (intern, intern_c_string): Redefine as static inline
1594 wrappers for intern_1 and intern_c_string_1, respectively.
1595 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1596 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1597 Vobarray checking.
e8df9267
DA
1598 * font.c (font_intern_prop): Likewise. Adjust comment.
1599 * w32font.c (intern_font_name): Likewise.
1600
34348bd4
AS
16012012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1602
d96a1e0c
AS
1603 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1604
34348bd4
AS
1605 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1606 of Fcar/Fcdr if possible.
1607 * font.c (check_otf_features): Likewise.
1608 * fontset.c (Fnew_fontset): Likewise.
1609 * gnutls.c (Fgnutls_boot): Likewise.
1610 * minibuf.c (read_minibuf): Likewise.
1611 * msdos.c (IT_set_frame_parameters): Likewise.
1612 * xmenu.c (Fx_popup_dialog): Likewise.
1613 * w32menu.c (Fx_popup_dialog): Likewise.
1614
c8add24e
GM
16152012-07-11 Glenn Morris <rgm@gnu.org>
1616
4b575b3c
GM
1617 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1618 since nothing has defined it on these platforms.
1619
09f4e3b0
GM
1620 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1621 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1622
172bedef
GM
1623 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1624 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1625 Move CLASH_DETECTION to configure.
1626
249685df
GM
1627 * s/gnu.h: Remove file, which is now empty.
1628
c8add24e
GM
1629 * s/gnu.h, s/gnu-linux.h:
1630 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1631
b41253a3
JW
16322012-07-11 John Wiegley <johnw@newartisans.com>
1633
1634 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1635 function attribute, so we only use it if it exists in the
1636 compiler.
1637
d923b542
DA
16382012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1639
1640 Avoid call to strlen in fast_c_string_match_ignore_case.
1641 * search.c (fast_c_string_match_ignore_case): Change to use
1642 length argument. Adjust users accordingly.
1643 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1644
5ebbef1d
PE
16452012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1646
bb352260
PE
1647 Assume mkdir, rmdir.
1648 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1649 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1650
57054ddd
PE
1651 Assume rename.
1652 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1653
b747d3f7
PE
1654 Assume perror.
1655 * s/hpux10-20.h (HAVE_PERROR): Remove.
1656 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1657 Remove dummy definition, as this problem was obsolete long ago.
1658
5ebbef1d
PE
1659 Assume strerror.
1660 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1661
984e7f30
DA
16622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1663
1664 Avoid calls to strlen in font processing functions.
1665 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1666 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1667 users accordingly.
d923b542
DA
1668 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1669 Adjust prototypes.
1670 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1671 Change to return ptrdiff_t.
984e7f30
DA
1672 (xfont_list_pattern, xfont_match): Use length returned by
1673 xfont_decode_coding_xlfd.
1674 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1675
20e94fdd
GM
16762012-07-11 Glenn Morris <rgm@gnu.org>
1677
9d596af3
GM
1678 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1679 Move DONT_REOPEN_PTY to configure.
1680
20e94fdd
GM
1681 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1682 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1683
e99a530f
PE
16842012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1685
22ffb973
PE
1686 Remove "#define unix" that is no longer needed (Bug#11905).
1687 * s/aix4-2.h (unix): Remove; no longer needed.
1688
e9a9ae03
PE
1689 EMACS_TIME simplification (Bug#11875).
1690 This replaces macros (which typically do not work in GDB)
1691 with functions, typedefs and enums, making the code easier to debug.
1692 The functional style also makes code easier to read and maintain.
1693 * systime.h: Include <sys/time.h> on all hosts, not just if
1694 WINDOWSNT, since 'struct timeval' is needed in general.
1695 (EMACS_TIME): Now a typedef, not a macro.
1696 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1697 not macros.
1698 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1699 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1700 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1701 (EMACS_TIME_LE): Now functions, not macros.
1702 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1703 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1704 which are not functions. All uses rewritten to use:
1705 (make_emacs_time): New function.
1706 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1707 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1708 not functions. All uses rewritten to use the following, respectively:
1709 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1710 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1711 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1712 * fileio.c (Fcopy_file):
1713 * xterm.c (XTflash): Get the current time closer to when it's used.
1714 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1715
ffacb126
PE
1716 * bytecode.c (targets): Suppress -Woverride-init warnings.
1717
e99a530f
PE
1718 Simplify by avoiding confusing use of strncpy etc.
1719 * doc.c (Fsnarf_documentation):
1720 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1721 * frame.c (Fmake_terminal_frame):
1722 * gtkutil.c (get_utf8_string):
1723 * lread.c (openp):
1724 * nsmenu.m (ns_update_menubar):
1725 * regex.c (regerror):
1726 Prefer memcpy to strncpy and strncat when either will do.
1727 * fileio.c (Fsubstitute_in_file_name):
1728 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1729 (menu_separator_name_p):
1730 * nsmenu.m (ns_update_menubar):
1731 Prefer memcmp to strncmp when either will do.
1732 * nsterm.m: Include <ftoastr.h>.
1733 (ns_get_color):
1734 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1735 Prefer snprintf to strncpy.
1736 * nsterm.m (ns_term_init):
1737 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1738 * nsterm.m (ns_term_init):
1739 Avoid the need for strncpy, by using build_string or
1740 make_unibyte_string directly. Use dtoastr, not snprintf.
1741 * process.c (Fmake_network_process): Diagnose service names that
1742 are too long, rather than silently truncating them or creating
1743 non-null-terminated names.
1744 (Fnetwork_interface_info): Likewise, for interface names.
1745 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1746 Prefer sprintf to strncat.
1747 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1748 Prefer vsnprintf to vsprintf + strncpy.
1749
c59592b3
GM
17502012-07-10 Glenn Morris <rgm@gnu.org>
1751
1752 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1753 Clarify fallback case.
1754
7d7bbefd
DA
17552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1758 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1759 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1760 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1761 where argument type is known to be a Lisp_Cons.
1762
3a4c8000
TT
17632012-07-10 Tom Tromey <tromey@redhat.com>
1764
1765 * bytecode.c (BYTE_CODE_THREADED): New macro.
1766 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1767 (enum byte_code_op): New type.
1768 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1769 (exec_byte_code): Use them. Use token threading when applicable.
1770
2a0213a6
DA
17712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1772
1773 Optimize pure C strings initialization.
1774 * lisp.h (make_pure_string): Fix prototype.
1775 (build_pure_c_string): New function, defined as static inline. This
1776 provides a better opportunity to optimize away calls to strlen when
1777 the function is called with compile-time constant argument.
1778 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1779 argument, adjust users accordingly. Use build_pure_c_string where
1780 appropriate.
1781 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1782 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1783 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1784
cb1caeaf
DA
17852012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 Avoid calls to strlen in miscellaneous functions.
1788 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1789 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1790 * lread.c (openp): Likewise.
1791
c293e30c
DA
17922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 Avoid calls to strlen in path processing functions.
1795 * fileio.c (file_name_as_directory): Add comment. Change to add
1796 srclen argument and return the length of result. Adjust users
1797 accordingly.
1798 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1799 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1800 users accordingly.
1801 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1802
9e059e3f
GM
18032012-07-10 Glenn Morris <rgm@gnu.org>
1804
d02eb359
GM
1805 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1806 Move PENDING_OUTPUT_COUNT definition to configure.
1807
882cf227
GM
1808 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1809 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1810 * s/gnu.h (DATA_START): Move definitions to configure.
1811
af6e839f
GM
1812 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1813 We include usg5-4-common.h, which defines them both.
1814
40289a12
GM
1815 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1816 O_RDONLY already includes it).
1817
9e059e3f
GM
1818 Stop ns builds setting the EMACSLOADPATH environment variable.
1819 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1820 Now it does not set EMACSLOADPATH, just returns the load-path string.
1821 * nsterm.h: Update accordingly.
1822 * lread.c [HAVE_NS]: Include nsterm.h.
1823 (init_lread) [HAVE_NS]: Use ns_load_path.
1824 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1825
7c4e8ec0
GM
18262012-07-09 Glenn Morris <rgm@gnu.org>
1827
d4f600ff
GM
1828 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1829 since the included bsd-common.h does so.
1830
cbb31951
GM
1831 Stop ns builds setting the EMACSPATH environment variable.
1832 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1833 (ns_init_paths): Do not set EMACSPATH.
1834 * nsterm.h (ns_exec_path): Add it.
1835 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1836 Use ns_exec_path.
1837
7c4e8ec0
GM
1838 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1839
26bccfae
PE
18402012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1841
a0bee46f
PE
1842 * process.c (wait_reading_process_output): 'waitchannels' was unset
1843 when read_kbd || !NILP (wait_for_cell); fix this.
1844
5994c183
PE
1845 Add GCC-style 'const' attribute to functions that can use it.
1846 * character.h (char_resolve_modifier_mask):
1847 * keyboard.h (make_ctrl_char):
1848 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1849 (init_character_once, next_almost_prime, init_fns, init_image)
1850 (flush_pending_output, init_sound):
1851 * mem-limits.h (start_of_data):
1852 * menu.h (finish_menu_items):
1853 Add ATTRIBUTE_CONST.
1854 * emacs.c (DEFINE_DUMMY_FUNCTION):
1855 Declare the dummy function with ATTRIBUTE_CONST.
1856 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1857 Add decls with ATTRIBUTE_CONST.
1858
26bccfae
PE
1859 Minor improvements to make_formatted_string.
1860 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1861 where int is good enough, as vsprintf returns an int.
1862 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1863
a8290ec3
DA
18642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1865
1866 Use make_formatted_string to avoid double length calculation.
1867 * lisp.h (make_formatted_string): New prototype.
1868 * alloc.c (make_formatted_string): New function.
1869 * buffer.c (Fgenerate_new_buffer_name): Use it.
1870 * dbus.c (syms_of_dbusbind): Likewise.
1871 * editfns.c (Fcurrent_time_zone): Likewise.
1872 * filelock.c (get_boot_time): Likewise.
1873 * frame.c (make_terminal_frame, set_term_frame_name)
1874 (x_report_frame_params): Likewise.
1875 * image.c (gs_load): Likewise.
1876 * minibuf.c (get_minibuffer): Likewise.
1877 * msdos.c (dos_set_window_size): Likewise.
1878 * process.c (make_process): Likewise.
1879 * xdisp.c (ensure_echo_area_buffers): Likewise.
1880 * xsettings.c (apply_xft_settings): Likewise.
1881
d01ba2f1
GM
18822012-07-09 Glenn Morris <rgm@gnu.org>
1883
1884 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1885 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1886 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1887 * nsterm.h (ns_etc_directory): Add it.
1888 * callproc.c [HAVE_NS]: Include nsterm.h.
1889 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1890
f1f924b6
DA
18912012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1892
1893 Move marker debugging code under MARKER_DEBUG.
1894 * marker.c (MARKER_DEBUG): Move marker debugging code under
1895 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1896 for bootstrap with --enable-checking (~3x slowdown reported
1897 by Juanma Barranquero <lekktu@gmail.com>).
1898 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1899
ab531b66
PE
19002012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1903 See <http://bugs.gnu.org/11825#29>.
1904
c4b3bc8a
EZ
19052012-07-08 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1908 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1909 (display_line): Add commentary about displaying truncation glyphs
1910 on GUI frames.
1911 (produce_special_glyphs): Move here from term.c.
1912
1913 * term.c (produce_special_glyphs): Move to xdisp.c.
1914
1915 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1916 section.
c4b3bc8a 1917
b676b881
AS
19182012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1919
f17c5273
AS
1920 * xdisp.c (display_line): Avoid warning about implicit declaration
1921 of FRAME_FONT.
1922
298819b9
AS
1923 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1924
b676b881
AS
1925 * lisp.h: Remove empty conditional.
1926
6045c4fd
PE
19272012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1928
b3350bf9
PE
1929 * lread.c (load_path_check): Now static.
1930
6045c4fd
PE
1931 Fix some minor --with-ns problems found by static checking.
1932 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1933 (x_set_font) [!HAVE_X_WINDOWS]:
1934 * image.c (xpm_load_image) [HAVE_NS]:
1935 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1936 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1937 Remove unused local.
1938 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1939 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1940 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1941 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1942 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1943 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1944 Fix pointer signedness problem.
1945 * xfaces.c (FRAME_X_FONT_TABLE):
1946 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1947
929e7845
GM
19482012-07-07 Glenn Morris <rgm@gnu.org>
1949
1950 * lread.c (load_path_check): New function, split from init_lread.
1951 (init_lread): Reorganize. Motivation:
1952 If EMACSLOADPATH is set, check/warn about that rather than the
1953 defaults, which we are not going to use. Hence we can remove
1954 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1955 Don't warn if site-lisp directories are missing.
1956 If not installed, start from a blank load-path, since
1957 PATH_LOADSEARCH refers to the eventual installation directories.
1958
58dd0aa4
EZ
19592012-07-07 Eli Zaretskii <eliz@gnu.org>
1960
1961 Support truncation and continuation glyphs on GUI frames, when
1962 fringes are disabled. (Bug#11832)
1963 * xdisp.c (init_iterator): Get dimensions of truncation and
1964 continuation glyphs even if on GUI frames. Adjust
1965 it->last_visible_x on GUI frames when the left or right fringes,
1966 or both, are absent.
1967 (start_display, move_it_in_display_line_to): Handle the case of a
1968 GUI frame without a fringe to display continuation or truncation
1969 glyphs.
1970 (insert_left_trunc_glyphs): Support GUI frames: make sure
1971 truncation glyphs overwrite enough glyphs from the current line to
1972 have sufficient space in pixels.
1973 (display_line): Support truncation and continuation glyphs on GUI
1974 frames. If some spare pixels are left on the line after inserting
1975 the truncation glyphs, fill that space with a stretch glyph of a
1976 suitably computed width.
1977
1978 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1979 produce_glyphs, to support GUI sessions.
1980
31571fd7
PE
19812012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1982
5a16b9bc
PE
1983 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1984
f3047c75
PE
1985 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1986
31571fd7
PE
1987 Do not require float-time's arg to fit in time_t (Bug#11825).
1988 This works better on hosts where time_t is unsigned, and where
1989 float-time is applied to the (negative) difference between two times.
1990 * editfns.c (decode_time_components): Last arg is now double *,
1991 not int *, and means to store all the result as a double, without
1992 worrying about whether the seconds part fits in time_t.
1993 All callers changed.
1994 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1995 All callers changed.
1996 (Ffloat_time): Do not fail merely because the specified time falls
1997 outside of time_t range.
1998
4516fbef
GM
19992012-07-07 Glenn Morris <rgm@gnu.org>
2000
2001 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2002 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2003 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2004
07adc2c6
JB
20052012-07-07 Juanma Barranquero <lekktu@gmail.com>
2006
2007 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2008 Update dependencies.
2009
2010 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2011
fd573f31
PE
20122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2013
fee5959d
PE
2014 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2015 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2016 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2017 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2018 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2019 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2020
fd573f31
PE
2021 * xfont.c (compare_font_names): Redo to omit the need for casts.
2022
ddadbc0e
AS
20232012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2024
fca8d6b6
AS
2025 * xfns.c (Fx_change_window_property): Doc fix.
2026 * w32fns.c (Fx_change_window_property): Doc fix.
2027
ddadbc0e
AS
2028 * w32fns.c (Fx_window_property): Accept the same arguments as the
2029 X Windows version. Doc fix.
2030 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2031
ed9265fc 20322012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2033 Eli Zaretskii <eliz@gnu.org>
2034
2035 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2036 Windows-specific code from nt/config.nt moved here.
2037 Obsolete settings removed.
2038
216ee680
PE
20392012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * process.c: Avoid unnecessary calls to gettime.
2042 (wait_reading_process_output): Don't get the time of day
2043 when gobbling data immediately and not waiting, as there's no need
2044 for it in that case. This removes a FIXME.
2045
bdd091e4
JD
20462012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2047
2048 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2049 is defined (Bug#11768).
2050
9d44f8ce
DA
20512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2052
2053 Fix marker debugging code.
2054 * marker.c (byte_char_debug_check): Do not perform the check
2055 if buffer is not multibyte.
090bd7cb
JB
2056 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2057 Call byte_char_debug_check with correct arguments.
9d44f8ce 2058
90fc4786
DA
20592012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2062 * marker.c (byte_char_debug_check, count_markers):
2063 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2064 (byte_debug_flag): Remove.
2065 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2066 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2067
7b7ae965
DA
20682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2069
4e57b342
DA
2070 Avoid code repetition in marker-related functions.
2071 * marker.c (attach_marker): New function.
2072 (Fset_marker, set_marker_restricted, set_marker_both)
2073 (set_marker_restricted_both): Use it.
2074 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2075 Consistently rename charno to charpos.
2076 (marker_position): Add eassert.
2077 (marker_byte_position): Convert to eassert.
2078
20792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2080
2081 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2082 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2083 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2084
657924ff
DA
20852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 Introduce fast path for the widely used marker operation.
2088 * alloc.c (build_marker): New function.
2089 * lisp.h (build_marker): New prototype.
2090 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2091 * composite.c (autocmp_chars): Likewise.
2092 * editfns.c (buildmark): Remove.
2093 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2094 (save_restriction_save): Use build_marker.
2095 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2096 * window.c (save_window_save): Likewise.
2097
041a49a6
DA
20982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2099
2100 Do not use Fdelete_overlay in delete_all_overlays
2101 to avoid redundant calls to unchain_overlay.
2102 * buffer.c (drop_overlay): New function.
2103 (delete_all_overlays, Fdelete_overlay): Use it.
2104 * minibuf.c (get_minibuffer): Fix comment.
2105
7dca65a4
PE
21062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 Port to OpenBSD 5.1 amd64.
2109 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2110 This is needed for OpenBSD, and should be harmless on all BSD systems.
2111 Also, include <sys/sysctl.h>, as it should be available on all
2112 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2113 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2114 use p_pid member, not kp_proc.pid.
2115
8eb876e2
GM
21162012-07-06 Glenn Morris <rgm@gnu.org>
2117
2118 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2119
38182d90
PE
21202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 More xmalloc and related cleanup.
2123 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2124 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2125 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2126 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2127 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2128 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2129 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2130 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2131 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2132 * xterm.c:
2133 Omit needless casts involving void * pointers and allocation.
2134 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2135 as the former is more robust if P's type is changed.
2136 Prefer xzalloc to xmalloc + memset 0.
2137 Simplify malloc-or-realloc to realloc.
2138 Don't worry about xmalloc returning a null pointer.
2139 Prefer xstrdup to xmalloc + strcpy.
2140 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2141 growing it.
2142 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2143 alloca of a constant.
2144
6dd5a677
EZ
21452012-07-05 Eli Zaretskii <eliz@gnu.org>
2146
2147 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2148 hscroll is larger than the line width. Fixes long and futile
2149 looping inside extend_face_to_end_of_line (on a TTY) producing
2150 glyphs that are not needed and thrown away.
2151
6b312f0f
DA
21522012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 * marker.c (set_marker_restricted_both): Simplify by using
2155 clip_to_bounds.
2156
f520ef9b
PE
21572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2160
383b7c95
JD
21612012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2162
2163 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2164 not defined (Bug#11768).
2165 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2166 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2167 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2168 followed by gtk_box_set_homogeneous (Bug#11768).
2169 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2170 (update_theme_scrollbar_width, xg_create_scroll_bar):
2171 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2172 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2173 (is_box_type): New function (Bug#11768).
2174 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2175 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2176 with default display (Bug#11768).
2177
d6e7bf45
EZ
21782012-07-05 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (window_hscroll_limited): New function.
2181 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2182 coordinates when window's hscroll is set to insanely large
2183 values. (Bug#11857)
2184
431391ec
JB
21852012-07-05 Juanma Barranquero <lekktu@gmail.com>
2186
2187 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2188 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2189
23f86fce
DA
21902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2191
2192 Cleanup xmalloc.
2193 * lisp.h (xzalloc): New prototype. Omit needless casts.
2194 * alloc.c (xzalloc): New function. Omit needless casts.
2195 * charset.c: Omit needless casts. Convert all calls to
2196 xmalloc with following memset to xzalloc.
2197 * dispnew.c: Likewise.
2198 * fringe.c: Likewise.
2199 * image.c: Likewise.
2200 * sound.c: Likewise.
2201 * term.c: Likewise.
2202 * w32fns.c: Likewise.
2203 * w32font.c: Likewise.
2204 * w32term.c: Likewise.
2205 * xfaces.c: Likewise.
2206 * xfns.c: Likewise.
2207 * xterm.c: Likewise.
2208 * atimer.c: Omit needless casts.
2209 * buffer.c: Likewise.
2210 * callproc.c: Likewise.
2211 * ccl.c: Likewise.
2212 * coding.c: Likewise.
2213 * composite.c: Likewise.
2214 * doc.c: Likewise.
2215 * doprnt.c: Likewise.
2216 * editfns.c: Likewise.
2217 * emacs.c: Likewise.
2218 * eval.c: Likewise.
2219 * filelock.c: Likewise.
2220 * fns.c: Likewise.
2221 * gtkutil.c: Likewise.
2222 * keyboard.c: Likewise.
2223 * lisp.h: Likewise.
2224 * lread.c: Likewise.
2225 * minibuf.c: Likewise.
2226 * msdos.c: Likewise.
2227 * print.c: Likewise.
2228 * process.c: Likewise.
2229 * region-cache.c: Likewise.
2230 * search.c: Likewise.
2231 * sysdep.c: Likewise.
2232 * termcap.c: Likewise.
2233 * terminal.c: Likewise.
2234 * tparam.c: Likewise.
2235 * w16select.c: Likewise.
2236 * w32.c: Likewise.
2237 * w32reg.c: Likewise.
2238 * w32select.c: Likewise.
2239 * w32uniscribe.c: Likewise.
2240 * widget.c: Likewise.
2241 * xdisp.c: Likewise.
2242 * xmenu.c: Likewise.
2243 * xrdb.c: Likewise.
2244 * xselect.c: Likewise.
2245
0497dc44
PE
22462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * fileio.c (time_error_value): Check the right error number.
2249 Problem reported by Troels Nielsen in
2250 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2251
356e7178
PE
22522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2253
4e71fd89
PE
2254 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2255 This should be fixed in a better way; see Eli Zaretskii in
2256 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2257 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2258
f0941253
PE
2259 * fileio.c (time_error_value): Rename from special_mtime.
2260 The old name's problems were noted by Eli Zaretskii in
2261 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2262
065c9eb4
PE
2263 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2264 This variable's comment says Emacs needs at least one GDB-visible
2265 symbol of type enum pvec_type, to work around GDB problems.
2266 The symbol's value doesn't matter.
2267
356e7178
PE
2268 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2269 that causes compilation to fail on pre-C99 compilers.
2270
ed9265fc 22712012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2272
2273 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2274 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2275
3884d954
DA
22762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2277
d209e2fb 2278 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2279 headers for buffer_defaults and buffer_local_symbols.
2280 Reported by Juanma Barranquero <lekktu@gmail.com>.
2281
ee28be33
SM
22822012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2283
2284 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2285 * lisp.h (enum pvec_type): Use fewer bits.
2286 (PSEUDOVECTOR_SIZE_BITS): New constant.
2287 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2288 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2289 change in pvec_type.
2290 (PSEUDOVECTOR_TYPEP): New macro.
2291 (TYPED_PSEUDOVECTORP): Use it.
2292 * fns.c (internal_equal): Adapt code to extract pvectype.
2293 * emacs.c (gdb_pvec_type): Update type.
2294 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2295 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2296 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2297 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2298 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2299 abusing vector->header.next.nbytes.
2300 (live_vector_p): Use PVEC_TYPE.
2301 (mark_object): Adapt code to extract pvectype. Use switch.
2302
c7f2cd7f
PE
23032012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2306 Tighten new eassert a bit.
2307
8ce70ed2
DA
23082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2309
2310 Fix compilation with --enable-gcc-warnings and -O1
2311 optimization level.
2312 * doprnt.c (doprnt): Change type of tem to int, initialize
2313 to avoid compiler warning. Add eassert.
2314 * search.c (simple_search): Initialize match_byte to avoid
2315 compiler warning. Add eassert.
2316
dea7f1e5
PE
23172012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2318
24a212eb
PE
2319 Avoid weird behavior with large horizontal scrolls.
2320 Without this change, for example, large hscroll values would
2321 mess up Emacs's display on Fedora 15 x86, presumably due to
2322 overflows in int calculations in the display code.
2323 Also, if buffers had long lines, Emacs would freeze.
2324 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2325 (set_window_hscroll): New function, containing the old guts of
2326 Fset_window_hscroll. Return the clipped value.
2327 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2328 This avoids the need to check against PTRDIFF_MAX.
2329
dea7f1e5
PE
2330 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2331
76046526
DA
23322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2333
2334 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2335
39adff0d
PE
23362012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2337
63807d47
PE
2338 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2339 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2340 since GCC 4.4.6 issues a bogus warning for them.
2341
39adff0d
PE
2342 Fix bugs in file timestamp newness comparisons.
2343 * fileio.c (Ffile_newer_than_file_p):
2344 * lread.c (Fload): Use full timestamp resolution of files,
2345 not just the 1-second resolution, so that files that are only
2346 slightly newer still count as newer.
2347 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2348 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2349
dbeed9a6
PE
23502012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * fileio.c: Improve handling of file time marker. (Bug#11852)
2353 (special_mtime): New function.
2354 (Finsert_file_contents, Fverify_visited_file_modtime):
2355 Use it to set special mtime values consistently.
2356
636334d6
AS
23572012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2358
2359 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2360 marker for non-existing file. (Bug#11852)
2361
e2017fe2
GM
23622012-07-03 Glenn Morris <rgm@gnu.org>
2363
2364 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2365 and did not make it into globals.h).
2366
404dbd37
TT
23672012-07-03 Tom Tromey <tromey@redhat.com>
2368
2369 * window.c (Fset_window_margins, Fset_window_fringes)
2370 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2371 * textprop.c (Fprevious_property_change): No longer static.
2372 * syntax.c (Fsyntax_table_p): No longer static.
2373 * process.c (Fget_process, Fprocess_datagram_address): No longer
2374 static.
2375 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2376 * keyboard.c (Fcommand_execute): No longer static.
2377 Remove EXFUN.
2378 * insdel.c (Fcombine_after_change_execute): No longer static.
2379 * image.c (Finit_image_library): No longer static.
2380 * fileio.c (Fmake_symbolic_link): No longer static.
2381 * eval.c (Ffetch_bytecode): No longer static.
2382 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2383 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2384 No longer static.
404dbd37
TT
2385 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2386 static.
2387 * dired.c (Ffile_attributes): No longer static.
2388 * composite.c (Fcomposition_get_gstring): No longer static.
2389 * callproc.c (Fgetenv_internal): No longer static.
2390
2391 * ccl.h: Remove EXFUNs.
2392 * buffer.h: Remove EXFUNs.
2393 * dispextern.h: Remove EXFUNs.
2394 * intervals.h: Remove EXFUNs.
2395 * fontset.h: Remove EXFUN.
2396 * font.h: Remove EXFUNs.
2397 * dosfns.c (system_process_attributes): Remove EXFUN.
2398 * keymap.h: Remove EXFUNs.
2399 * lisp.h: Remove EXFUNs.
2400 * w32term.h: Remove EXFUNs.
2401 * window.h: Remove EXFUNs.
2402 * xsettings.h: Remove EXFUN.
2403 * xterm.h: Remove EXFUN.
2404
8e4fd1e1
GM
24052012-07-03 Glenn Morris <rgm@gnu.org>
2406
2407 * lisp.h (Frandom): Make it visible to C.
2408 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2409 buffer for invisible buffers. (Bug#1229)
2410
ca95b3eb
DA
24112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2412
2413 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2414 values which aren't power of 2.
2415 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2416 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2417 accordingly.
2418
7555c33f
SM
24192012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2420
2421 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2422
2423 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2424
d12e8f5a
DA
24252012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2426
2427 * alloc.c (allocate_vector_block): Remove redundant
2428 calls to mallopt if DOUG_LEA_MALLOC is defined.
2429 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2430 avoid calls to mallopt if zero_vector is returned.
2431
296094c3
DA
24322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2433
2434 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2435 is enabled, avoid dereferencing NULL current_sblock if
2436 running undumped.
2437
36429c89
DA
24382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2439
2440 Cleanup basic buffer management.
2441 * buffer.h (struct buffer): Change layout to use generic vector
2442 marking code. Fix some comments. Change type of 'clip_changed'
2443 to bitfield. Remove unused #ifndef old.
2444 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2445 (GET_OVERLAYS_AT): Fix indentation.
2446 (for_each_per_buffer_object_at): New macro.
2447 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2448 (Fbuffer_local_variables): Use it.
2449 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2450 * alloc.c (allocate_buffer): Adjust to match new layout of
2451 struct buffer. Fix comment.
2452 (mark_overlay): New function.
2453 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2454 Lisp area of struct buffer.
2455 (mark_object): Use it. Adjust marking of misc objects
2456 and related comments.
2457
3b3e4cac
PE
24582012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2461 wrapper that is not needed because the wrapped code is a no-op (zero
2462 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2463 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2464
cf5c0175
DA
24652012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2466
2467 * alloc.c (mark_buffer): Simplify. Remove prototype.
2468 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2469 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2470 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2471 redundant calls to mark_vectorlike for bool vectors.
2472
ca26824c
GM
24732012-06-30 Glenn Morris <rgm@gnu.org>
2474
2e4c5312
GM
2475 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2476
ca26824c
GM
2477 * epaths.in (PATH_SITELOADSEARCH): New.
2478 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2479 This is rather than relying on --enable-locallisppath elements
2480 having "site-lisp" in their names. (Bug#10208#25, 11658)
2481
0d23c240
EZ
24822012-06-30 Eli Zaretskii <eliz@gnu.org>
2483
c9240d7a
EZ
2484 * w32proc.c (sys_select): Accept and ignore one more argument.
2485
2486 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2487
0d23c240 2488 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2489 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2490
2491 * sysdep.c: Don't include dos.h and dosfns.h.
2492
2493 * process.c (sys_select):
2494 * msdos.c (sys_select): Accept one more argument and ignore it.
2495
2496 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2497 adapt data types and code to that.
2498
2499 * dosfns.c:
2500 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2501 which clashes with the gnulib function of the same name.
2502
af5a5a98
AS
25032012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2504
c5e4379c
AS
2505 * font.c (font_style_to_value, font_style_symbolic)
2506 (font_prop_validate_style): Add type checks for values in
2507 font_style_table.
2508
af5a5a98
AS
2509 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2510 argument.
2511 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2512 uses.
2513
8d38f461
EZ
25142012-06-29 Eli Zaretskii <eliz@gnu.org>
2515
2e5a6631
EZ
2516 * xdisp.c (try_window_id): Undo last change.
2517
8d38f461
EZ
2518 * w32.c (getwd): Adjust commentary about startup_dir.
2519 (init_environment): Always call sys_access, even in non-MSVC
2520 builds. Don't chdir to the directory of the Emacs executable.
2521 This undoes code from 1997 which was justified by the need to
2522 "avoid conflicts when removing and renaming directories". But its
2523 downside was that every relative file name was being interpreted
2524 relative to the directory of the Emacs executable, which can never
2525 be TRT. In particular, it broke sys_access when called with
2526 relative file names.
2527 (sys_access): Map GetLastError to errno.
2528
2af3565e
DA
25292012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2530
2531 * window.h (struct window): Change type of 'fringes_outside_margins'
2532 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2533 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2534 Adjust comment.
2535 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2536 to ptrdiff_t.
2537
c8d3a25c 25382012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2539
c8d3a25c
GM
2540 * gnutls.c (emacs_gnutls_handshake):
2541 Add QUIT to make the loop interruptible.
57570cd3 2542
c8d3a25c 25432012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2544
c8d3a25c
GM
2545 * charset.c (init_charset): Make lack of etc/charsets fatal.
2546
3e984ee8
DA
25472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2548
2549 * editfns.c (region_limit): Fix type mismatch.
2550
ef884f23
DA
25512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2552
2553 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2554 undefined. Convert from xassert to eassert.
2555 * nsmenu.m: Convert from xassert to eassert.
2556 * nsterm.m: Likewise.
2557
7d7e0027
SM
25582012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2559
2560 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2561
aa754e6a
PE
25622012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 Avoid integer overflow on scroll-left and scroll-right.
2565 * window.c (HSCROLL_MAX): New macro.
2566 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2567 overflow when requested scroll falls outside ptrdiff_t range.
2568
80b00b08
DA
25692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2570
2571 * window.h (struct window): Change type of 'hscroll',
2572 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2573 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2574 Adjust users accordingly.
2575 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2576 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2577 from EMACS_INT to ptrdiff_t.
2578 (make_window): Omit redundant initialization.
2579
62b2bcf6
JB
25802012-06-28 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2583
45942c7d
DA
25842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2585
2586 * window.h (struct window): Change type of 'use_time' and
2587 'sequence_number' from Lisp_Object to int.
2588 * frame.c (make_frame): Adjust users accordingly.
2589 * print.c (print_object): Likewise.
2590 * window.c (select_window, Fwindow_use_time, make_parent_window)
2591 (make_window): Likewise.
2592
e509cfa6
DA
25932012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2594
2595 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2596 enabled with --enable-checking=[all,glyphs] configure option.
2597 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2598 adjust comments accordingly.
2599 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2600 undefined, adjust comments accordingly.
2601 * image.c: Likewise.
2602 * scroll.c: Likewise.
2603 * w32fns.c: Likewise.
2604 * w32term.c: Likewise.
2605 * xdisp.c: Likewise.
2606 * xfaces.c: Likewise.
2607 * xfns.c: Likewise.
2608 * xterm.c: Likewise.
2609
a54e2c05
DA
26102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2611
2612 Generalize run-time debugging checks.
2613 * dispextern.h (XASSERTS): Remove.
2614 * fontset.c (xassert): Remove.
2615 Convert from xassert to eassert.
2616 * alloc.c: Convert from xassert to eassert.
2617 * bidi.c: Likewise.
2618 * dispnew.c: Likewise.
2619 * fns.c: Likewise.
2620 * fringe.c: Likewise.
2621 * ftfont.c: Likewise.
2622 * gtkutil.c: Likewise.
2623 * image.c: Likewise.
2624 * keyboard.c: Likewise.
2625 * menu.c: Likewise.
2626 * process.c: Likewise.
2627 * scroll.c: Likewise.
2628 * sound.c: Likewise.
2629 * term.c: Likewise.
2630 * w32console.c: Likewise.
2631 * w32fns.c: Likewise.
2632 * w32term.c: Likewise.
2633 * window.c: Likewise.
2634 * xdisp.c: Likewise.
2635 * xfaces.c: Likewise.
2636 * xfns.c: Likewise.
2637 * xselect.c: Likewise.
2638 * xterm.c: Likewise.
2639
1ec4b7b2
SM
26402012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2641
2642 * fns.c (maybe_resize_hash_table): Output message when growing the
2643 purify-hashtable.
2644
2014308a
DA
26452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2646
2647 * alloc.c (allocate_string_data): Remove dead code.
2648 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2649 avoid GCC warning about unused macro.
2650
246155eb
DA
26512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2652
2653 * alloc.c (allocate_string): Omit intervals initialization.
2654 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2655 as in make_pure_string and make_pure_c_string.
2656
43184b7b
DA
26572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2658
d209e2fb 2659 * alloc.c (allocate_string): Fix last change.
43184b7b 2660
3fe6dd74
DA
26612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2662
d209e2fb 2663 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2664 to memset, add explicit initialization where appropriate.
2665
1ba6038a
GM
26662012-06-27 Glenn Morris <rgm@gnu.org>
2667
2668 * lisp.mk (lisp): Remove paths.elc.
2669
c89926a5
CY
26702012-06-27 Chong Yidong <cyd@gnu.org>
2671
2672 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2673
ed6b3510
JW
26742012-06-26 John Wiegley <johnw@newartisans.com>
2675
1ec4b7b2 2676 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2677 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2678
ed6b3510
JW
2679 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2680 when building with Clang.
2681
8edd4a2b
SM
26822012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2683
2684 * eval.c (Fapply): Allow calling it with a single argument.
2685
f6f62d1b
EZ
26862012-06-26 Eli Zaretskii <eliz@gnu.org>
2687
2688 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2689 _stricmp and _strnicmp.
2690 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2691
62efea5e
DA
26922012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2693
2694 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2695 allocated window.
2696 (allocate_process): Likewise for new process.
8edd4a2b 2697 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2698 (allocate_frame): Likewise.
2699 * frame.c (make_frame): Omit redundant initialization.
2700 * window.c (make_parent_window): Use memset.
2701 (make_window): Omit redundant initialization.
2702 * process.c (make_process): Omit redundant initialization.
2703 * terminal.c (create_terminal): Likewise.
2704
42997f4d
DA
27052012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2706
2707 * term.c (delete_tty): Remove redundant call to memset.
2708
1130ecfc
DA
27092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2710
2711 * alloc.c: Remove build_string.
2712 * lisp.h: Define build_string as static inline. This provides
2713 a better opportunity to optimize away calls to strlen when the
2714 function is called with compile-time constant argument.
2715 * image.c (imagemagick_error): Convert to build_string.
2716 * w32proc.c (sys_spawnve): Likewise.
2717 * xterm.c (x_term_init): Likewise.
2718
cf38a720
PE
27192012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2720
99027bdd
PE
2721 Use sprintf return value instead of invoking strlen on result.
2722 In the old days this wasn't portable, since some sprintf
2723 implementations returned char *. But they died out years ago and
2724 Emacs already assumes sprintf returns int.
2725 Similarly for float_to_string.
2726 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2727 * ccl.c (ccl_driver):
2728 * character.c (string_escape_byte8):
2729 * data.c (Fnumber_to_string):
2730 * doprnt.c (doprnt):
2731 * print.c (print_object):
2732 * xdisp.c (message_dolog):
2733 * xfns.c (syms_of_xfns):
2734 Use sprintf or float_to_string result to avoid need to call strlen.
2735 * data.c (Fnumber_to_string):
2736 Use make_unibyte_string, since the string must be ASCII.
2737 * lisp.h, print.c (float_to_string): Now returns int length.
2738 * term.c (produce_glyphless_glyph):
2739 Use sprintf result rather than recomputing it.
2740
cf38a720
PE
2741 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2742 * Makefile.in (ALL_CFLAGS):
2743 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2744 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2745
3511c784
DA
27462012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2747
0a08eb21 2748 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2749 strcasecmp if available.
2750 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2751
fb7da12e
AS
27522012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2753
2754 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2755 Avoid comma operator.
2756 * menu.c (push_submenu_start, push_submenu_end)
2757 (push_left_right_boundary, push_menu_pane): Likewise.
2758 * msdos.c (dos_rawgetc): Likewise.
2759
afa2ffd8
DA
27602012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2761
2762 * xfns.c (xic_create_fontsetname): Remove redundant calls
2763 to memset.
2764
b3b4476b
PE
27652012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2766
4495ff38
PE
2767 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2768 sprintf already null-terminates its output.
2769
b3b4476b
PE
2770 * xfns.c (x_window): Remove redundant cast.
2771
b00876c9
DA
27722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2773
2774 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2775 `const char *' to `char *' to avoid compiler warning.
2776
d188e26b
PE
27772012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2778
885d1d74
PE
2779 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2780 instead of truncating it to 63 (admittedly a generous limit).
2781
d188e26b
PE
2782 * process.c: Fix spelling and caps in comments.
2783
e2f560b1
DN
27842012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2785
e86db54b 2786 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2787 * sysdep.c (setpgrp): Remove definition, not used in this file.
2788
7583a3a1
JB
27892012-06-24 Juanma Barranquero <lekktu@gmail.com>
2790
2791 * makefile.w32-in: Update dependencies.
2792
696056c2
EZ
27932012-06-24 Eli Zaretskii <eliz@gnu.org>
2794
2795 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2796 (SYSTIME_H): Add nt/inc/sys/time.h.
2797
2798 * systime.h [WINDOWSNT]: Include sys/time.h.
2799
2800 * s/ms-w32.h (struct timespec): Definition moved from
2801 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2802
845ca893
PE
28032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2806 * buffer.h (buffer_slot_type_mismatch):
2807 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2808 * eval.c (unwind_to_catch):
2809 * image.c (my_png_error, my_error_exit):
2810 * keyboard.c (quit_throw_to_read_char, user_error)
2811 (Fexit_recursive_edit, Fabort_recursive_edit):
2812 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2813 (wrong_type_argument, buffer_overflow, __executable_start)
2814 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2815 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2816 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2817 (fatal):
2818 (child_setup) [!DOS_NT]:
2819 * lread.c (end_of_file_error, invalid_syntax):
2820 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2821 * puresize.h (pure_write_error):
2822 * search.c (matcher_overflow):
2823 * sound.c (sound_perror, alsa_sound_perror):
2824 * sysdep.c, syssignal.h (croak):
2825 * term.c (maybe_fatal, vfatal):
2826 * textprop.c (text_read_only):
2827 * undo.c (user_error):
2828 * unexmacosx.c (unexec_error):
2829 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2830 Use _Noreturn rather than NO_RETURN.
2831 No need for separate decl merely because of _Noreturn.
2832 * sound.c (sound_warning, parse_sound):
2833 Remove unnecessary forward decls.
2834
f1dd8073
PE
28352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2838 * lisp.h (WAIT_READING_MAX): New macro.
2839 * dispnew.c (Fsleep_for, sit_for):
2840 * keyboard.c (kbd_buffer_get_event):
2841 * process.c (Faccept_process_output):
2842 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2843 This improves on the previous patch, which introduced a bug
2844 when time_t is unsigned and as wide as intmax_t.
2845 See <http://bugs.gnu.org/9000#51>.
2846
b82c1755
EZ
28472012-06-23 Eli Zaretskii <eliz@gnu.org>
2848
2849 * dispnew.c (sit_for, Fsleep_for):
2850 * keyboard.c (kbd_buffer_get_event):
2851 * process.c (Faccept_process_output): Avoid compiler warnings when
2852 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2853
ca300656
JB
28542012-06-23 Juanma Barranquero <lekktu@gmail.com>
2855
049ec95b
JB
2856 * makefile.w32-in: Update dependencies.
2857
ca300656
JB
2858 * w32.c (ltime): Add return type and declare static.
2859 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2860
db7b8d06
PE
28612012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2864 Privately reported by Herbert J. Skuhra.
2865 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2866 All uses changed.
2867 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2868 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2869
0bd8297f
EZ
28702012-06-23 Eli Zaretskii <eliz@gnu.org>
2871
96512555
EZ
2872 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2873 last argument of make_unibyte_string.
2874
0bd8297f
EZ
2875 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2876 language ID in the event parameters.
2877
2878 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2879 event.code, not the obscure "character set ID".
2880
63def6b6
CY
28812012-06-23 Chong Yidong <cyd@gnu.org>
2882
2883 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2884
e8a02204
EZ
28852012-06-23 Eli Zaretskii <eliz@gnu.org>
2886
388cdec0
EZ
2887 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2888 * w32.c (fdutimens): New function.
2889
2890 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2891
2892 * s/ms-w32.h (pselect): Redirect to sys_select.
2893
2894 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2895
e8a02204
EZ
2896 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2897 in the logic of incrementing and decrementing the value of
2898 use_relocatable_buffers.
2899
d054f3fb
PE
29002012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2903 Privately reported by Herbert J. Skuhra.
2904 [__FreeBSD__]: Remove "*/" typo after "#include".
2905 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2906 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2907 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2908 Don't assume EMACS_TIME and struct timeval are the same type.
2909
d35af63c
PE
29102012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Support higher-resolution time stamps (Bug#9000).
2913 The time stamps are only nanosecond-resolution at the C level,
2914 since that's the best that any real-world system supports now.
2915 But they are picosecond-resolution at the Lisp level, as that's
2916 easy, and leaves room for future OS improvements.
2917
2918 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2919 (LIBES): Use it.
2920
2921 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2922 Don't get current time unless it's needed.
2923
2924 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2925 now provides it if it's absent.
2926 (start_atimer): Port to higher-res time stamps.
2927 Check for time stamp overflow. Don't get current time more
2928 often than is needed.
2929
2930 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2931 Include systime.h, not time.h.
2932 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2933
2934 * dired.c: Include stat-time.h.
2935 (Ffile-attributes): File times now have higher resolution.
2936
2937 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2938 (struct image): Timestamp now has higher resolution.
2939
2940 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2941 has at least microseconds now. All uses removed.
2942 (update_frame, update_single_window, update_window, update_frame_1)
2943 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2944
2945 * editfns.c (time_overflow): Now extern.
2946 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2947 (float-time, Fformat_time_string, Fcurrent_time_string)
2948 (Fcurrent_time_zone): Accept and generate higher-resolution
2949 time stamps.
2950 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2951 (decode_time_components, lisp_seconds_argument): New functions.
2952 (make_time): Now static.
2953 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2954 Report an error if the time is invalid, rather than having the caller
2955 do that.
2956
2957 * fileio.c: Include <stat-time.h>
2958 (Fcopy_file): Copy higher-resolution time stamps.
2959 Prefer to set the time stamp via a file descriptor if that works.
2960 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2961 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2962 (Fvisited_file_modtime, Fset_visited_file_modtime):
2963 Support higher-resolution time stamps.
2964
2965 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2966
2967 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2968
2969 * image.c (prepare_image_for_display, clear_image_cache)
2970 (lookup_image): Port to higer-resolution time stamps.
2971
2972 * keyboard.c (start_polling, bind_polling_period):
2973 Check for time stamp overflow.
2974 (read_char, kbd_buffer_get_event, timer_start_idle)
2975 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2976 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2977 Port to higher-resolution time stamps. Do not assume time_t is signed.
2978 (decode_timer): New function. Timers are now vectors of length 9,
2979 not 8, to accommodate the picosecond component.
2980 (timer_check_2): Use it.
2981
2982 * nsterm.m (select_timeout, timeval_subtract): Remove.
2983 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2984 as they're a bit more accurate and handle overflow better.
2985 (ns_select): Change prototype to be compatible with pselect.
2986 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2987 * nsterm.h (ns_select): Adjust prototype.
2988
2989 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2990 us-resolution time stamps.
2991 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2992
2993 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2994
2995 * lisp.h (time_overflow): New decl.
2996 (wait_reading_process_output): First arg is now intmax_t, not int,
2997 to accommodate larger waits.
2998
2999 * process.h (struct Lisp_Process.read_output_delay):
3000 Now counts nanoseconds, not microseconds.
3001 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3002 EMACS_HAS_USECS.
3003 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3004 (wait_reading_process_output):
3005 Port to ns-resolution time stamps.
3006 (Faccept_process_output, wait_reading_process_output):
3007 Check for time stamp overflow. Do not assume time_t is signed.
3008 (select_wrapper): Remove; we now use pselect.
3009 (Fprocess_attributes): Now generates ns-resolution time stamps.
3010
3011 * sysdep.c: Include utimens.h. Don't include utime.h
3012 or worry about struct utimbuf; gnulib does that for us now.
3013 (gettimeofday): Remove; gnulib provides a substitute.
3014 (make_timeval): New function.
3015 (set_file_times): Now sets ns-resolution time stamps.
3016 New arg FD; all uses changed.
3017 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3018 (system_process_attributes):
3019 Now returns ns-resolution time stamp. All uses changed.
3020 Check for time stamp overflow.
3021
3022 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3023 provides a substitute now.
3024
3025 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3026 since it guarantees struct timespec.
3027 (EMACS_TIME): Now struct timespec, so that we can support
3028 ns-resolution time stamps.
3029 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3030 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3031 (EMACS_USECS): Remove.
3032 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3033 so multiply the arg by 1000 before storing it.
3034 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3035 New macros.
3036 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3037 Port to ns-resolution time stamps.
3038 (EMACS_TIME_NEG_P): Remove; replaced by....
3039 (EMACS_TIME_SIGN): New macro.
3040 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3041 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3042 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3043 (make_timeval, make_lisp_time, decode_time_components): New decls.
3044 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3045 that it mishandled time_t overflow. You can't compare by subtracting!
3046 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3047 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3048
3049 * term.c: Include <sys/time.h>.
3050 (timeval_to_Time): New function, for proper overflow wraparound.
3051 (term_mouse_position, term_mouse_click): Use it.
3052
3053 * undo.c (record_first_change): Support higher-resolution time stamps
3054 in the undo buffer.
3055 (Fprimitive_undo): Use them when restoring time stamps.
3056
3057 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3058 (w32_get_internal_run_time):
3059 Port to higher-resolution Emacs time stamps.
3060 (ltime): Now accepts single 64-bit integer, as that's more convenient
3061 for callers.
3062
3063 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3064
3065 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3066 for compatibility with pselect. Support ns-resolution time stamps.
3067
3068 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3069
3070 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3071 Check for time stamp overflow, and support ns-resolution time stamps.
3072
3073 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3074 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3075 (timeval_subtract): Remove; no longer needed.
3076 (XTflash, XTring_bell, x_wait_for_event):
3077 Port to ns-resolution time stamps. Don't assume time_t is signed.
3078
b6a92dfe
CY
30792012-06-22 Chong Yidong <cyd@gnu.org>
3080
3081 * xdisp.c (x_consider_frame_title): Revert last change.
3082
d251c37c
EZ
30832012-06-22 Eli Zaretskii <eliz@gnu.org>
3084
3085 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3086 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3087 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3088 staticidx goes up to 1597 out of 1600 = 0x640.)
3089
f10deafb
PE
30902012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3093 Otherwise, the umask might be mistakenly 0 while handling input signals.
3094
ec6de1e2
SM
30952012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3096
3097 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3098
28be1ada
DA
30992012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3100
3101 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3102 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3103 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3104 access to `contents' member of Lisp_Vector objects with AREF and ASET
3105 where appropriate.
3106
c6bf3022
CY
31072012-06-19 Chong Yidong <cyd@gnu.org>
3108
3109 * frame.c (delete_frame): When selecting a frame on a different
3110 text terminal, do not alter the terminal's top-frame.
3111
3112 * xdisp.c (format_mode_line_unwind_data): Record the target
3113 frame's selected window and its terminal's top-frame.
3114 (unwind_format_mode_line): Restore them.
3115 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3116 Callers changed.
3117 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3118 since tty frames can be explicitly named.
3119 (prepare_menu_bars): Likewise.
3120
3121 * term.c (Ftty_top_frame): New function.
3122
defd4196
PE
31232012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 Port byte-code-meter to modern targets.
3126 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3127 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3128 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3129 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3130 (METER_1, METER_2): Simplify.
3131
1053a871
SM
31322012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3133
3134 * data.c (Fdefalias): Return `symbol' (bug#11686).
3135
b7e8d081
MR
31362012-06-18 Martin Rudalics <rudalics@gmx.at>
3137
3138 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3139 gets killed during executing of this function (Bug#11665).
3140 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3141 (Vkill_buffer_query_functions): In doc-string say that functions
3142 run by this hook should not change the current buffer.
3143
7ea2b339
PE
31442012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 Fix recently-introduced process.c problems found by static checking.
3147 * process.c (write_queue_push, write_queue_pop, send_process):
3148 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3149 (write_queue_pop): Fix pointer signedness problem.
3150 (send_process): Remove unused local.
3151
96a313a1
CY
31522012-06-17 Chong Yidong <cyd@gnu.org>
3153
3154 * xdisp.c (redisplay_internal): No need to redisplay terminal
3155 frames that are not on top.
3156
20ca2e94
TN
31572012-06-17 Troels Nielsen <bn.troels@gmail.com>
3158
3159 * process.c (make_process): Initialize write_queue.
3160 (write_queue_push, write_queue_pop): New functions.
3161 (send_process): Use them to maintain correct ordering of process
3162 writes (Bug#10815).
3163
9a900ca9
PE
31642012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3165
310fbfa8
PE
3166 * lisp.h (eassert): Assume C89 or later.
3167 This removes the need for CHECK.
3168 (CHECK): Remove. Its comments about always evaluating its
3169 argument were confusing, as 'eassert' typically does not evaluate
3170 its argument.
3171
27bb1ca4
PE
3172 * coding.c (produce_chars): Use ptrdiff_t, not int.
3173
9a900ca9
PE
3174 * xterm.c (x_draw_underwave): Check for integer overflow.
3175 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3176
41b7f8bc 31772012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3178
3179 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3180 referenced (Bug#11583).
3181
9b0e3eba
AA
31822012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3183
3184 Implement wave-style variant of underlining.
3185 * dispextern.h (face_underline_type): New enum.
3186 (face): Add field for underline type.
3187 * nsterm.m (ns_draw_underwave): New function.
3188 (ns_draw_text_decoration): Use it.
3189 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3190 New functions.
3191 (x_draw_glyph_string): Use them.
3192 * xfaces.c (Qline, Qwave): New Lisp objects.
3193 (check_lface_attrs, merge_face_ref)
1053a871
SM
3194 (Finternal_set_lisp_face_attribute, realize_x_face):
3195 Handle wave-style underline face attributes.
9b0e3eba
AA
3196 * xterm.c (x_draw_underwave): New function.
3197 (x_draw_glyph_string): Use it.
3198
0fb52f11
JB
31992012-06-16 Juanma Barranquero <lekktu@gmail.com>
3200
3201 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3202 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3203 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3204 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3205 ($(BLD)/w32select.$(O)): Update dependencies.
3206
e5560ff7
AS
32072012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3208
3209 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3210 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3211 * character.c (_fetch_multibyte_char_p): Remove.
3212 * alloc.c: Include "character.h" before "buffer.h".
3213 * bidi.c: Likewise.
3214 * buffer.c: Likewise.
3215 * bytecode.c: Likewise.
3216 * callint.c: Likewise.
3217 * callproc.c: Likewise.
3218 * casefiddle.c: Likewise.
3219 * casetab.c: Likewise.
3220 * category.c: Likewise.
3221 * cmds.c: Likewise.
3222 * coding.c: Likewise.
3223 * composite.c: Likewise.
3224 * dired.c: Likewise.
3225 * dispnew.c: Likewise.
3226 * doc.c: Likewise.
3227 * dosfns.c: Likewise.
3228 * editfns.c: Likewise.
3229 * emacs.c: Likewise.
3230 * fileio.c: Likewise.
3231 * filelock.c: Likewise.
3232 * font.c: Likewise.
3233 * fontset.c: Likewise.
3234 * fringe.c: Likewise.
3235 * indent.c: Likewise.
3236 * insdel.c: Likewise.
3237 * intervals.c: Likewise.
3238 * keyboard.c: Likewise.
3239 * keymap.c: Likewise.
3240 * lread.c: Likewise.
3241 * macros.c: Likewise.
3242 * marker.c: Likewise.
3243 * minibuf.c: Likewise.
3244 * nsfns.m: Likewise.
3245 * nsmenu.m: Likewise.
3246 * print.c: Likewise.
3247 * process.c: Likewise.
3248 * regex.c: Likewise.
3249 * region-cache.c: Likewise.
3250 * search.c: Likewise.
3251 * syntax.c: Likewise.
3252 * term.c: Likewise.
3253 * textprop.c: Likewise.
3254 * undo.c: Likewise.
3255 * unexsol.c: Likewise.
3256 * w16select.c: Likewise.
3257 * w32fns.c: Likewise.
3258 * w32menu.c: Likewise.
3259 * window.c: Likewise.
3260 * xdisp.c: Likewise.
3261 * xfns.c: Likewise.
3262 * xmenu.c: Likewise.
3263 * xml.c: Likewise.
3264 * xselect.c: Likewise.
3265
2f07e6af
EZ
32662012-06-16 Eli Zaretskii <eliz@gnu.org>
3267
1053a871
SM
3268 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3269 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3270 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3271 row.
3272 (handle_face_prop): Use chunk-relative overlay string index when
3273 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3274 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3275 the rightmost. (Bug#11720)
2f07e6af 3276
29b83cec
AS
32772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3280 (CATEGORY_MEMBER): Enforce 1/0 value.
3281 * category.c (_temp_category_set): Remove.
3282
4c5501e9
EZ
32832012-06-16 Eli Zaretskii <eliz@gnu.org>
3284
3285 * window.c (Fdelete_other_windows_internal)
3286 (Fdelete_window_internal): Don't access frame's mouse highlight
3287 info of the initial frame. (Bug#11677)
3288
2b570124
PE
32892012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3290
e93864f9
PE
3291 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3292 Assume USE_2_TAGS_FOR_INTS.
3293 (xreload): Adjust $tagmask width to match recent lisp.h change.
3294
2b570124
PE
3295 Simplify lisp.h in minor ways that should not affect code.
3296 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3297 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3298 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3299 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3300 (INTTYPEBITS): New macro, for clarity.
3301 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3302 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3303 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3304 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3305 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3306
81755f69
JB
33072012-06-13 Juanma Barranquero <lekktu@gmail.com>
3308
3309 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3310
16192a57
GM
33112012-06-13 Glenn Morris <rgm@gnu.org>
3312
3313 * s/bsd-common.h (BSD4_3):
3314 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3315
646b5f55
AS
33162012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3317
3318 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3319 instead of union.
3320 (XLI, XIL): Define.
1053a871
SM
3321 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3322 Use them.
3323 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3324 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3325 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3326 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3327 * frame.c (delete_frame): Remove outdated comment.
3328 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3329 USE_LISP_UNION_TYPE.
3330 (Fw32_unregister_hot_key): Likewise.
3331 (Fw32_toggle_lock_key): Likewise.
3332 * w32menu.c (add_menu_item): Likewise.
3333 (w32_menu_display_help): Use XIL instead of checking
3334 USE_LISP_UNION_TYPE.
3335 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3336 (init_heap): Likewise.
3337 * w32term.c (w32_read_socket): Update comment.
3338
1d3823c9
GM
33392012-06-13 Glenn Morris <rgm@gnu.org>
3340
c62ff706
GM
3341 * s/usg5-4-common.h, src/s/unixware.h:
3342 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3343
1d3823c9
GM
3344 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3345
bfe3e0a2
PE
33462012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3349 * alloc.c (make_number) [!defined make_number]:
3350 Remove, as lisp.h always defines this now.
3351 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3352 (roundup_size): Verify that it is a power of 2.
3353 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3354 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3355 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3356 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3357 USE_LSB_TAG now is always defined to be either 0 or 1.
3358 All uses changed.
3359 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3360 code works fine either way, and efficiency is not a concern here,
3361 as the union type is for debugging, not for production.
3362 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3363 Use an inline function on all platforms when using the union type,
3364 since this is simpler and 'static inline' can be used portably
3365 within Emacs now.
3366 (LISP_INITIALLY_ZERO): New macro.
3367 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3368 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3369
45fa9c0f
GM
33702012-06-12 Glenn Morris <rgm@gnu.org>
3371
b4492cba
GM
3372 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3373
3374 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3375
45fa9c0f
GM
3376 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3377 Move BROKEN_SIGIO to configure.
3378
3379 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3380 Move NO_TERMIO to configure.
3381
0e25d334
CY
33822012-06-12 Chong Yidong <cyd@gnu.org>
3383
3384 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3385 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3386 MagickExportImagePixels is undefined.
3387
43682bb6
PE
33882012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3389
3390 * image.c (imagemagick_load_image): Remove unused label.
3391
a9be7d2b
GM
33922012-06-11 Glenn Morris <rgm@gnu.org>
3393
3394 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3395 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3396 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3397 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3398
3017f87f
SM
33992012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * alloc.c (make_byte_code): New function.
3402 (Fmake_byte_code): Use it. Don't purify here.
3403 * lread.c (read1): Use it as well to avoid extra allocation.
3404
1b9b4cf4
CY
34052012-06-11 Chong Yidong <cyd@gnu.org>
3406
3407 * image.c (imagemagick_load_image): Implement transparency.
3408
95988fcf
AS
34092012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3410
3411 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3412 account for preceding backslashes. (Bug#11663)
3413
cd4eb164
CY
34142012-06-09 Chong Yidong <cyd@gnu.org>
3415
3416 * term.c: Support italics in capable terminals (Bug#9652).
3417 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3418 (turn_on_face): Output using TS_enter_italic_mode if available.
3419 Don't handle unused blinking and alt-charset cases.
3420 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3421 and tty_alt_charset_p cases.
3422 (tty_capable_p, init_tty): Support italics.
3423
3424 * termchar.h (struct tty_display_info): Add field for italics.
3425 Remove unused blink field.
3426
3427 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3428 Handle slant.
3429
3430 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3431 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3432 tty_alt_charset_p. Add tty_italic_p.
3433
ff88beb8
MA
34342012-06-09 Michael Albinus <michael.albinus@gmx.de>
3435
3436 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3437 dbus_type_is_basic if available.
3438 (xd_extract_signed, xd_extract_unsigned): Rename from
3439 extract_signed and extract_unsigned, respectively. Adapt callers.
3440
44286096
CY
34412012-06-09 Chong Yidong <cyd@gnu.org>
3442
1682701f
CY
3443 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3444
44286096
CY
3445 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3446 case (Bug#9752).
3447
d86feb17
PE
34482012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3449
3450 * xdisp.c (vmessage): Treat frame message as multibyte.
3451 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3452 would generate the diagnostic "Making \302\247 buffer-local while
3453 let-bound!".
3454
d5c20fe8
EZ
34552012-06-08 Eli Zaretskii <eliz@gnu.org>
3456
3457 * dispnew.c (showing_window_margins_p): Undo last change, which
3458 was done due to an inadvertent commit.
3459 (adjust_frame_glyphs_for_frame_redisplay): Do call
3460 showing_window_margins_p.
3461
513749ee
SM
34622012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3463
3464 * eval.c (Fmake_var_non_special): New primitive.
3465 (syms_of_eval): Defsubr it.
3466 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3467
d4a8f5c1
JB
34682012-06-08 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3471 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3472
8bbbc977
EZ
34732012-06-08 Eli Zaretskii <eliz@gnu.org>
3474
3475 * alloc.c (allocate_vectorlike): Fix last change.
3476
f3372c87
DA
34772012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3478
3479 Block-based vector allocation of small vectors.
3480 * lisp.h (struct vectorlike_header): New field `nbytes',
3481 adjust comment accordingly.
3482 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3483 to denote vector blocks. Adjust users (live_vector_p,
3484 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3485 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3486 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3487 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3488 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3489 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3490 (roundup_size): New constant.
3491 (struct vector_block): New data type.
3492 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3493 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3494 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3495 (sweep_vectors): New functions.
3496 (allocate_vectorlike): Return `zero_vector' as the only vector of
3497 0 items. Allocate new vector from block if vector size is less than
3498 or equal to VBLOCK_BYTES_MAX.
3499 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3500 (init_alloc_once): Add call to init_vectors.
3501
4f18a4ed
SM
35022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3503
3504 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3505
86f158bc
PE
35062012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 * doprnt.c (doprnt): Truncate multibyte char correctly.
3509 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3510 would mishandle a string argument "Xc" if X was a multibyte
3511 character of length 2: it would truncate after X's first byte
3512 rather than including all of X.
3513
c5cfcbe0
CY
35142012-06-06 Chong Yidong <cyd@gnu.org>
3515
3516 * buffer.c (word_wrap): Doc fix.
3517
c05cf390
PE
35182012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3521
0c3461de
GM
35222012-06-03 Glenn Morris <rgm@gnu.org>
3523
3524 * xdisp.c (tool-bar-style): Doc fix.
3525
c71232db
UM
35262012-06-03 Ulrich Müller <ulm@gentoo.org>
3527
3528 * Makefile.in (PAXCTL): Define.
3529 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3530 binary via PaX flags if the paxctl utility is available.
3531 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3532 Restore PaX flags to their default. (Bug#11398)
3533
383f7350
CY
35342012-06-03 Chong Yidong <cyd@gnu.org>
3535
3536 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3537 buffer (Bug#11226).
3538
5f2c76c6
CY
35392012-06-03 Chong Yidong <cyd@gnu.org>
3540
3541 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3542 (note_mode_line_or_margin_highlight): If there is no help echo,
3543 use mode-line-default-help-echo. Handle the case where the mouse
3544 position is past the end of the mode line string.
3545
3546 * buffer.c (buffer_local_value_1): New function, split from
3547 Fbuffer_local_value; can return Qunbound.
3548 (Fbuffer_local_value): Use it.
3549 (Vmode_line_format): Docstring tweaks.
3550
773d47f6
PE
35512012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 * sysdep.c (system_process_attributes): Improve comment.
3554
f2d6a3df
SM
35552012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3556
3557 * keyboard.c: Export real-this-command to Elisp.
3558 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3559 and DEFVAR it. Update all users.
3560
63810350
PE
35612012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3562
7bd5c1f4
PE
3563 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3564
63810350
PE
3565 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3566 Convert pctcpu and pctmem to Lisp float properly.
3567 Let the compiler fold better, as 100.0/0x8000 is exact.
3568
a2821611
AS
35692012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3570
3571 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3572 cons_block.
3573
5fceba1d
PE
35742012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3577
c98ff5dd
DA
35782012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3579
3580 For a 'struct window', replace some Lisp_Object fields to
3581 bitfields where appropriate, remove unused fields.
3582 * window.h (struct window): Remove unused 'last_mark_x' and
3583 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3584 change it's type from Lisp_Object to bitfield.
3585 Change type of 'force_start', 'optional_new_start',
3586 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3587 fields from Lisp_Object to bitfield. Adjust users accordingly.
3588
ca34e0be
PE
35892012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Pacify gcc -Wdouble-precision when using Xaw.
3592 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3593 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3594 Use 'float' consistently, rather than 'float' in most places
3595 and 'double' in a couple of places.
3596
efc00ab1 35972012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3598
3599 * xdisp.c (handle_stop): Detect whether we have overlay strings
3600 loaded by testing it->current.overlay_string_index to be
3601 non-negative, instead of checking whether n_overlay_strings is
3602 positive. (Bug#11587)
3603
efc00ab1 36042012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3605
3606 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3607
3608 * doc.c (Fsubstitute_command_keys): Doc fix.
3609
efc00ab1 36102012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3611
3612 * search.c (search_buffer): Remove calls to
3613 r_alloc_inhibit_buffer_relocation, as it is now called by
3614 maybe_unify_char, which was the cause of relocation of buffer text
3615 in bug#11519.
3616
efc00ab1 36172012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3618
3619 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3620 for the duration of call to load_charset, to avoid problems with
3621 callers of maybe_unify_char that access buffer text through C
3622 pointers.
3623
3624 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3625 decrement the inhibition flag, instead of just setting or
3626 resetting it.
3627
ba93a187
PE
36282012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Remove obsolete '#define static' cruft.
3631 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3632 This #undef was "temporary" in 2000; it is no longer needed
3633 now that '#define static' has gone away.
3634 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3635 (gray_bitmap_bits): Remove; no longer needed.
3636 All uses replaced with definiens.
3637 * xterm.c: Include "bitmaps/gray.xbm".
3638
9e4bf381
PE
36392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 Clean up __executable_start, monstartup when --enable-profiling.
3642 The following changes affect the code only when profiling.
3643 * dispnew.c (__executable_start): Rename from safe_bcopy.
3644 Define only on platforms that need it.
3645 * emacs.c: Include <sys/gmon.h> when profiling.
3646 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3647 (__executable_start): Remove decl, since lisp.h does it now.
3648 (safe_bcopy): Remove decl; no longer has that name.
3649 (main): Coalesce #if into single bit of code, for simplicity.
3650 Cast pointers to uintptr_t, since standard libraries want integers
3651 and not pointers.
3652 * lisp.h (__executable_start): New decl.
3653
32d72c2f
GM
36542012-05-31 Glenn Morris <rgm@gnu.org>
3655
3656 * image.c (Fimagemagick_types): Doc fix.
3657
baac5bc7
JM
36582012-05-30 Jim Meyering <meyering@redhat.com>
3659
3660 * callproc.c (Fcall_process_region): Include directory component
3661 in mkstemp error message (Bug#11586).
3662
72cb32cf
PE
36632012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 * alloc.c, lisp.h (make_pure_vector): Now static.
3666
61b108cc
SM
36672012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3668
3669 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3670 Move to byte-run.el.
3671 (Fautoload): Do the hash-doc more carefully.
3672 * data.c (Fdefalias): Purify definition, except for keymaps.
3673 (Qdefun): Move from eval.c.
3674 * lisp.h (Qdefun): Remove.
3675 * lread.c (read1): Tiny simplification.
3676
471fe23d
TN
36772012-05-29 Troels Nielsen <bn.troels@gmail.com>
3678
934f3f58 3679 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3680 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3681 Bug#9642, but explicitly check that the buffer the overlay would
3682 be moved to is live and rearrange lines to make sure that errors
3683 will not put the overlay in an inconsistent state.
3684 (Fdelete_overlay): Cosmetics.
3685
85d0efd1
EZ
36862012-05-28 Eli Zaretskii <eliz@gnu.org>
3687
3688 * w32term.c (my_bring_window_to_top): New function.
3689 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3690 could be different from the original one.
3691 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3692 (Bug#11513)
3693
3694 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3695 by calling BringWindowToTop.
3696
3697 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3698 (WM_EMACS_END): Increase by one.
3699
da92a98c
PE
37002012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3703 This avoids undefined behavior that might cause the eassert
3704 to not catch an out-of-range value.
3705
74d1f848
JB
37062012-05-28 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3709 Update dependencies.
3710
9e1a06fc
EZ
37112012-05-27 Eli Zaretskii <eliz@gnu.org>
3712
3713 * bidi.c (bidi_mirror_char): Fix last change.
3714
f3dd7312
AS
37152012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3718 when referring to sectname field in printf format.
3719
81899c91
PE
37202012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3721
57b81a9f
PE
3722 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3723 Only r_alloc_inhibit_buffer_relocation needed to be added;
3724 the others were already declared.
3725
81899c91
PE
3726 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3727 before checking whether it's out of range. Put the check inside
3728 eassert. See
3729 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3730
33017faf 37312012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3732
3733 * callproc.c (Fcall_process): Restore a line that was accidentally
3734 commented out in the 2011-02-13 change (bug#11547).
3735
33017faf 37362012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3737
3738 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3739 defined on ralloc.c.
3740
3741 * buffer.c [REL_ALLOC]: Remove prototypes of
3742 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3743 they are now on lisp.h.
3744
3745 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3746
3747 * search.c (search_buffer): Use it to inhibit relocation of buffer
3748 text while re_search_2 is doing its job, because re_search_2 is
3749 passed C pointers to buffer text. (Bug#11519)
3750
23415acf
EZ
3751 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3752 Update value to 24.
3753
44e27368
EZ
3754 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3755 state after an additional call to move_it_in_display_line_to, keep
3756 the values of it->max_ascent and it->max_descent found for the
3757 entire line.
3758 (pos_visible_p): Revert the comparison against bottom_y to what it
3759 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3760 (Bug#11464)
3761
c1892f11
PE
37622012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 Fix coding-related core dumps with gcc -ftrapv.
3765 The code was computing A - B, where A and B are pointers, and B is
3766 random garbage. This can lead to core dumps on platforms that
3767 have special pointer registers, and it also leads to core dumps on
3768 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3769 A - B only when B is initialized properly.
3770 * coding.c (coding_set_source, coding_set_destination): Return void.
3771 (coding_change_source, coding_change_destinations): New functions,
3772 with the old behaviors of coding_set_source and coding_set_destination.
3773 All callers that need an offset changed to use these new functions.
3774
eb7afdad
GM
37752012-05-26 Glenn Morris <rgm@gnu.org>
3776
3777 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3778
f12fdf02
EZ
37792012-05-26 Eli Zaretskii <eliz@gnu.org>
3780
53a63be6 3781 Extend mouse support on W32 text-mode console.
61b108cc
SM
3782 * xdisp.c (draw_row_with_mouse_face):
3783 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3784
eb3f6f01 3785 * w32console.c: Include window.h.
61b108cc
SM
3786 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3787 New functions.
eb3f6f01
EZ
3788 (initialize_w32_display): Initialize mouse-highlight data.
3789
53a63be6
EZ
3790 * w32inevt.c: Include termchar.h and window.h.
3791 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3792 moves, call note_mouse_highlight. If help_echo changed, call
3793 gen_help_event to produce help-echo message in the echo area.
3794 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3795 highlight info.
3796
4cfd81f6
PE
37972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 * lread.c (read1): Simplify slightly to avoid an overflow warning
3800 with GCC 4.7.0 on x86-64.
3801
4446092a
EZ
38022012-05-26 Eli Zaretskii <eliz@gnu.org>
3803
3804 * bidi.c (bidi_mirror_char): Revert last change: an int is
3805 definitely wide enough here.
3806
42b2a986 38072012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3808
42b2a986 3809 Fix integer width and related bugs (Bug#9874).
eb106a49 3810 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3811 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3812 (string_bytes, check_sblock, allocate_string_data):
3813 (compact_small_strings, Fmake_bool_vector, make_string)
3814 (make_unibyte_string, make_multibyte_string)
3815 (make_string_from_bytes, make_specified_string)
3816 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3817 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3818 (mark_vectorlike):
3819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3820 (allocate_pseudovector):
3821 Use int, not EMACS_INT, where int is wide enough.
3822 (inhibit_garbage_collection, Fgarbage_collect):
3823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3824 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3825 int might not be wide enough.
3826 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3827 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3828 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3829 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3830 (bidi_level_of_next_char, bidi_move_to_visually_next):
3831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3832 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3833 (Fkill_buffer, Fset_buffer_major_mode)
3834 (advance_to_char_boundary, Fbuffer_swap_text)
3835 (Fset_buffer_multibyte, overlays_at, overlays_in)
3836 (overlay_touches_p, struct sortvec, record_overlay_string)
3837 (overlay_strings, recenter_overlay_lists)
3838 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3839 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3840 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3841 (Foverlay_recenter, last_overlay_modification_hooks_used)
3842 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3844 (validate_region): Omit unnecessary test for b <= e,
3845 since that's guaranteed by the previous test.
d311d28c
PE
3846 (adjust_overlays_for_delete): Avoid pos + length overflow.
3847 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3848 (report_overlay_modification):
3849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3850 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3851 Omit pointer cast, which isn't needed anyway, and doesn't work
3852 after the EMACS_INT -> ptrdiff_t change.
02481186 3853 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3854 * buffer.h: Adjust decls to match defn changes elsewhere.
3855 (struct buffer_text, struct buffer):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3858 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3859 not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (exec_byte_code): Use tighter memory-full test, one that checks
3861 for alloca overflow. Don't compute the address of the object just
3862 before an array, as that's not portable. Use EMACS_INT, not
3863 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3864 * callint.c (Fcall_interactively):
3865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3866 * callproc.c (call_process_kill, Fcall_process):
3867 Don't assume pid_t fits into an Emacs fixnum.
3868 (call_process_cleanup, Fcall_process, child_setup):
3869 Don't assume pid_t fits into int.
3870 (call_process_cleanup, Fcall_process, delete_temp_file)
3871 (Fcall_process_region):
3872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3873 (Fcall_process): Simplify handling of volatile integers.
3874 Use int, not EMACS_INT, where int will do.
3875 * casefiddle.c (casify_object, casify_region, operate_on_word)
3876 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 (casify_object): Avoid integer overflow when overallocating buffer.
3879 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3880 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3881 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3882 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3883 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3884 integers are now checked earlier. All uses replaced with XINT.
3885 (ccl_driver):
3886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3887 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3888 (ccl_driver, Fregister_code_conversion_map):
3889 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3890 (resolve_symbol_ccl_program): Check that vector header is in range.
3891 Always copy the vector, so that we can check its contents reliably
3892 now rather than having to recheck each instruction as it's being
3893 executed. Check that vector words fit in 'int'.
3894 (ccl_get_compiled_code, Fregister_ccl_program)
3895 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3896 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3897 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3898 contents are in range.
3899 (Fccl_execute_on_string): Check that status is in range.
3900 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3901 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3902 Accept and return EMACS_INT, not int, because callers can pass values
3903 out of 'int' range.
3904 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3905 (multibyte_chars_in_text, parse_str_as_multibyte)
3906 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3907 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3908 (string_escape_byte8, Fget_byte):
3909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3910 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3911 avoid mishandling large integers.
3912 * character.h: Adjust decls to match defn changes elsewhere.
3913 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3914 (Ffind_charset_region):
3915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3916 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3917 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3918 Don't assume fixnum fits in int.
d311d28c
PE
3919 (load_charset_map_from_vector, Fmap_charset_chars):
3920 Remove now-unnecessary CHECK_NATNUMs.
3921 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3922 Don't rely on undefined behavior with signed left shift overflow.
3923 Don't assume unsigned int fits into fixnum, or that fixnum fits
3924 into unsigned int. Don't require max_code to be a valid fixnum;
3925 that's not true for gb10830 4-byte on a 32-bit host. Allow
3926 invalid_code to be a cons, for the same reason. Require code_offset
3927 to be a character. Avoid int overflow if max_char is close
3928 to INT_MAX.
3929 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3930 this is intended anyway and avoids some undefined behavior.
3931 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3932 INDEX_TO_CODE_POINT, as that's what it expects.
3933 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3934 * charset.h (DECODE_CHAR): Return int, not unsigned;
3935 this is what was intended anyway, and it avoids undefined behavior.
3936 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3937 integer-overflow issues.
3938 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3939 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3940 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3941 * chartab.c (Fmake_char_table, Fset_char_table_range)
3942 (uniprop_get_decoder, uniprop_get_encoder):
3943 Don't assume fixnum fits in int.
3944 * cmds.c (move_point): New function, that does the gist of
3945 Fforward_char and Fbackward_char, but does so while checking
3946 for integer overflow more accurately.
c96e5d6a 3947 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3948 (Fforward_line, Fend_of_line, internal_self_insert)
3949 (internal_self_insert):
3950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3951 Fix a FIXME, by checking for integer overflow when calculating
3952 target_clm and actual_clm.
3953 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3954 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3955 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3956 (coding_alloc_by_making_gap, alloc_destination)
3957 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3958 (encode_coding_utf_16, detect_coding_emacs_mule)
3959 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3960 (detect_coding_iso_2022, decode_coding_iso_2022)
3961 (encode_invocation_designation, encode_designation_at_bol)
3962 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3963 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3964 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3965 (encode_coding_ccl, encode_coding_raw_text)
3966 (detect_coding_charset, decode_coding_charset)
3967 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3968 (produce_composition, produce_charset, produce_annotation)
3969 (decode_coding, handle_composition_annotation)
3970 (handle_charset_annotation, consume_chars, decode_coding_gap)
3971 (decode_coding_object, encode_coding_object, detect_coding_system)
3972 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3973 (code_convert_region, code_convert_string)
8f50130c
PE
3974 (Fdefine_coding_system_internal)
3975 (coding_set_source, coding_set_destination):
d311d28c
PE
3976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3977 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3978 (Fdefine_coding_system_internal):
3979 Don't assume fixnums fit in int.
3980 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3981 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3982 (Funencodable_char_position, Fcheck_coding_systems_region)
3983 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3985 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3986 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3987 Don't access memory outside of the args array.
d311d28c 3988 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3989 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3990 result of ENCODE_CHAR.
d311d28c
PE
3991 * coding.h: Adjust decls to match defn changes elsewhere.
3992 (struct coding_system):
3993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3994 * composite.c (get_composition_id, find_composition)
3995 (run_composition_function, update_compositions)
3996 (compose_text, composition_gstring_put_cache)
3997 (composition_gstring_p, composition_gstring_width)
3998 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3999 (composition_compute_stop_pos, composition_reseat_it)
4000 (composition_update_it, struct position_record)
4001 (find_automatic_composition, composition_adjust_point)
4002 (Fcomposition_get_gstring, Ffind_composition_internal):
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4004 (update_compositions):
4005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4006 * composite.h: Adjust decls to match defn changes elsewhere.
4007 (struct composition):
4008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4009 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4010 Do not attempt to compute the address of the object just before a
4011 buffer; this is not portable.
4012 (Faref, Faset):
4013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4014 (Faset): Use int, not EMACS_INT, where int is wide enough.
4015 (Fstring_to_number): Don't assume fixnums fit in int.
4016 (Frem): Don't assume arg is nonnegative.
4017 * dbusbind.c (xd_append_arg): Check for integers out of range.
4018 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4019 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4020 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4021 (xd_get_connection_references): Return ptrdiff_t, not int.
4022 All uses changed.
4023 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4024 (xd_read_message_1):
4025 Use int, not unsigned, where the dbus API uses int.
4026 (Fdbus_message_internal): Don't overflow mtype.
4027 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4028 * dired.c (directory_files_internal, file_name_completion, scmp)
4029 (file_name_completion_stat):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 (file_name_completion): Don't overflow matchcount.
4032 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4033 * dispextern.h: Adjust decls to match defn changes elsewhere.
4034 (struct text_pos, struct glyph, struct bidi_saved_info)
4035 (struct bidi_string_data, struct bidi_it, struct composition_it)
4036 (struct it):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 (struct display_pos, struct composition_it, struct it):
4039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4040 * dispnew.c (increment_matrix_positions)
4041 (increment_row_positions, mode_line_string)
4042 (marginal_area_string):
4043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4044 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4046 (duration_to_sec_usec): New function, to check for overflow better.
4047 (Fsleep_for, sit_for): Use it.
4048 * doc.c (get_doc_string, store_function_docstring):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (get_doc_string, Fsnarf_documentation):
4051 Use int, not EMACS_INT, where int is wide enough.
4052 (get_doc_string):
4053 Use SAFE_ALLOCA, not alloca.
4054 Check for overflow when converting EMACS_INT to off_t.
4055 * doprnt.c (doprnt):
4056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4057 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4058 Don't assume uid_t fits into fixnum.
4059 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4060 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4061 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4062 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4063 (general_insert_function)
4064 (Finsert_char, make_buffer_string, make_buffer_string_both)
4065 (update_buffer_properties, Fbuffer_substring)
4066 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4067 (Fsubst_char_in_region, check_translation)
4068 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4069 (transpose_markers, Ftranspose_regions):
4070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4071 (clip_to_bounds): Move to lisp.h as an inline function).
4072 (Fconstrain_to_field): Don't assume integers are nonnegative.
4073 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4074 (Fsubst_char_in_region, Fsave_restriction):
4075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4076 (Femacs_pid): Don't assume pid_t fits into fixnum.
4077 (lo_time): Use int, not EMACS_INT, when int suffices.
4078 (lisp_time_argument): Check for usec out of range.
4079 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4080 (Fuser_login_name, Fuser_full_name): Signal an error
4081 if a uid argument is out of range, rather than relying on
4082 undefined behavior.
c8d5c857
PE
4083 (Fformat_time_string): Remove now-unnecessary check.
4084 lisp_time_argument checks for out-of-range usec now.
243e0530 4085 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4086 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4087 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4088 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4089 (init_cmdargs, Fdump_emacs):
4090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4091 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4092 the bottom (typically) 32 bits of the fixnum.
4093 * eval.c (specpdl_size, call_debugger):
4094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4095 (when_entered_debugger, Fbacktrace_debug):
4096 Don't assume fixnum can fit in int.
4097 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4098 the object just before a buffer; this is not portable.
4099 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4100 (grow_specpdl, unbind_to):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4103 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4104 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4105 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4106 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4108 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4109 (a_write, e_write):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 (Fcopy_file, non_regular_nbytes, read_non_regular)
4112 (Finsert_file_contents):
4113 Use int, not EMACS_INT, where int is wide enough.
4114 (READ_BUF_SIZE): Verify that it fits in int.
4115 (Finsert_file_contents): Check that counts are in proper range,
4116 rather than assuming fixnums fit into ptrdiff_t etc.
4117 Don't assume fixnums fit into int.
125b3835 4118 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4119 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4120 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4121 (string_char_to_byte, string_byte_to_char)
4122 (string_make_multibyte, string_to_multibyte)
4123 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4124 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4125 (substring_both, Fdelete, internal_equal, Ffillarray)
4126 (Fclear_string, mapcar1)
4127 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4128 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4129 (larger_vector, make_hash_table, maybe_resize_hash_table)
4130 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4131 (Fmaphash, secure_hash):
4132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4133 (concat): Check for string index and length overflow.
4134 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4135 (Frequire):
4136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4137 (larger_vector): New API (vec, incr_min, size_max) replaces old
4138 one (vec, new_size, init). This catches size overflow.
4139 INIT was removed because it was always Qnil.
4140 All callers changed.
4141 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4142 the upper bound on a hash table index size.
4143 (make_hash_table, maybe_resize_hash_table): Use it.
4144 (secure_hash): Computer start_byte and end_byte only after
4145 they're known to be in ptrdiff_t range.
4146 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4147 (Ffont_get_glyphs, Ffont_at):
4148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4149 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4150 (Flist_fonts, Fopen_font):
4151 Don't assume fixnum can fit in int.
4152 (check_gstring): Don't assume index can fit in int.
4153 (font_match_p): Check that fixnum is a character, not a nonnegative
4154 fixnum, since the later code needs to stuff it into an int.
4155 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4156 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4157 conversion overflow issues.
4158 (Fopen_font): Check for integer out of range.
4159 (Ffont_get_glyphs): Don't assume index can fit in int.
4160 * font.h: Adjust decls to match defn changes elsewhere.
4161 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4162 integer overflow.
4163 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4164 printmax_t, where ptrdiff_t is wide enough.
4165 (Finternal_char_font):
4166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4167 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4168 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4169 (Fset_frame_position, x_set_frame_parameters)
4170 (x_set_line_spacing, x_set_border_width)
4171 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4172 Check that fixnums are in proper range for system types.
4173 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4175 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4176 Use SAFE_ALLOCA_LISP, not alloca.
4177 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4178 intptr_t is wide enough.
4179 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4180 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4181 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4182 Check for fixnum out of range.
4183 * ftfont.c (ftfont_list): Don't assume index fits in int.
4184 Check that fixnums are in proper range for system types.
4185 (ftfont_shape_by_flt):
4186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4187 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4189 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4190 Check that fixnums are in proper range for system types.
4191 * gnutls.h: Adjust decls to match defn changes elsewhere.
4192 * gtkutil.c (xg_dialog_run):
4193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4194 (update_frame_tool_bar):
4195 Check that fixnums are in proper range for system types.
4196 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4197 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4198 * indent.c (last_known_column, last_known_column_point):
4199 (current_column_bol_cache):
4200 (skip_invisible, current_column, check_display_width):
4201 (check_display_width, scan_for_column, current_column_1)
4202 (Findent_to, Fcurrent_indentation, position_indentation)
4203 (indented_beyond_p, Fmove_to_column, compute_motion):
4204 (Fcompute_motion, Fvertical_motion):
4205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4206 (last_known_column_modified): Use EMACS_INT, not int.
4207 (check_display_width):
4208 (Fcompute_motion):
4209 Check that fixnums and floats are in proper range for system types.
4210 (compute_motion): Don't assume index or fixnum fits in int.
4211 (compute_motion, Fcompute_motion):
4212 Use int, not EMACS_INT, when it is wide enough.
4213 (vmotion): Omit local var start_hpos that is always 0; that way
4214 we don't need to worry about overflow in expressions involving it.
4215 * indent.h: Adjust decls to match defn changes elsewhere.
4216 (struct position):
4217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4218 Use int, not EMACS_INT, where int is wide enough.
4219 Remove unused members ovstring_chars_done and tab_offset;
4220 all uses removed.
4221 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4222 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4223 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4224 (make_gap, copy_text, insert, insert_and_inherit)
4225 (insert_before_markers, insert_before_markers_and_inherit)
4226 (insert_1, count_combining_before, count_combining_after)
4227 (insert_1_both, insert_from_string)
4228 (insert_from_string_before_markers, insert_from_string_1)
4229 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4230 (adjust_after_replace, adjust_after_insert, replace_range)
4231 (replace_range_2, del_range, del_range_1, del_range_byte)
4232 (del_range_both, del_range_2, modify_region)
4233 (prepare_to_modify_buffer, signal_before_change)
4234 (signal_after_change, Fcombine_after_change_execute):
4235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4236 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4237 (balance_an_interval, split_interval_right, split_interval_left)
4238 (find_interval, next_interval, update_interval)
4239 (adjust_intervals_for_insertion, delete_node, delete_interval)
4240 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4241 (static_offset_intervals, offset_intervals)
4242 (merge_interval_right, merge_interval_left, make_new_interval)
4243 (graft_intervals_into_buffer, temp_set_point_both)
4244 (temp_set_point, set_point, adjust_for_invis_intang)
4245 (set_point_both, move_if_not_intangible, get_property_and_range)
4246 (get_local_map, copy_intervals, copy_intervals_to_string)
4247 (compare_string_intervals, set_intervals_multibyte_1):
4248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4249 * intervals.h: Adjust decls to match defn changes elsewhere.
4250 (struct interval):
4251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4252 * keyboard.c (this_command_key_count, this_single_command_key_start)
4253 (before_command_key_count, before_command_echo_length, echo_now)
4254 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4255 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4256 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4257 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4259 (last_non_minibuf_size, last_point_position, echo_truncate)
4260 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4261 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4262 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4263 (stuff_buffered_input):
4264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4265 (last_auto_save, command_loop_1, read_char):
4266 Use EMACS_INT, not int, to avoid integer overflow.
4267 (record_char): Avoid overflow in total_keys computation.
4268 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4269 * keyboard.h: Adjust decls to match defn changes elsewhere.
4270 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4271 (Fkey_description, Fdescribe_vector, Flookup_key):
4272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4273 (click_position): New function, to check that positions are in range.
4274 (Fcurrent_active_maps):
4275 (describe_command):
4276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4277 (Faccessible_keymaps, Fkey_description):
4278 (preferred_sequence_p):
4279 Don't assume fixnum can fit into int.
4280 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4281 Check for integer overflow in size calculations.
4282 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4283 avoid mishandling large integers.
4284 * lisp.h: Adjust decls to match defn changes elsewhere.
4285 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4286 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4287 (struct Lisp_Marker):
4288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4289 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4290 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4291 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4292 All callers changed.
4293 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4294 Assume the arg has valid form, since it always does.
4295 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4296 unsigned integer system type.
4297 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4298 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4300 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4301 (duration_to_sec_usec): New decl.
4302 * lread.c (read_from_string_index, read_from_string_index_byte)
4303 (read_from_string_limit, readchar, unreadchar, openp)
4304 (read_internal_start, read1, oblookup):
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 (Fload, readevalloop, Feval_buffer, Feval_region):
4307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4308 (openp): Check for out-of-range argument to 'access'.
4309 (read1): Use int, not EMACS_INT, where int is wide enough.
4310 Don't assume fixnum fits into int.
6efdadfd 4311 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4312 (read_filtered_event): Use duration_to_sec_usec
4313 to do proper overflow checking on durations.
d311d28c
PE
4314 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4315 in size calculation.
4316 (Fexecute_kbd_macro):
4317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4318 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4319 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4320 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4321 (set_marker_both, set_marker_restricted_both, marker_position)
4322 (marker_byte_position, Fbuffer_has_markers_at):
4323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4324 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4325 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4326 It now merely ensures that the menu is large enough, without
4327 necessarily growing it, as this avoids some integer overflow issues.
4328 All callers changed.
4329 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4331 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4332 Use SAFE_ALLOCA_LISP, not alloca.
4333 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4334 to EMACS_INT. Check that fixnums are in proper range for system types.
4335 * minibuf.c (minibuf_prompt_width, string_to_object)
4336 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4337 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4339 (get_minibuffer, read_minibuf_unwind):
4340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4341 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4342 this simplifies overflow checking. All callers changed.
4343 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4344 (Ftest_completion):
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4347 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4348 Check that fixnums are in proper range for system types.
4349 (Fx_create_frame, Fx_show_tip):
4350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4351 * nsfont.m (ns_findfonts, nsfont_list_family):
4352 Don't assume fixnum fits in long.
4353 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4355 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4356 wide enough.
17fdb222 4357 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4359 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4360 (PRINTDECLARE, PRINTPREPARE):
4361 (strout, print_string):
4362 (print, print_preprocess, print_check_string_charset_prop)
4363 (print_object):
4364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4365 (PRINTDECLARE):
4366 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4368 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4369 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4370 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4371 (print_error_message): Use SAFE_ALLOCA, not alloca.
4372 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4373 (print_depth, new_backquote_output, print_number_index):
4374 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4375 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4376 (Fset_process_window_size, Fformat_network_address)
4377 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4378 (sigchld_handler):
d311d28c 4379 Check that fixnums are in proper range for system types.
d44287d4 4380 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4381 Check for process-ids out of pid_t range rather than relying on
4382 undefined behavior.
e4d81efc 4383 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4384 (Fformat_network_address, read_process_output, send_process)
4385 (Fprocess_send_region, status_notify):
4386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4387 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4388 (wait_reading_process_output, read_process_output, exec_sentinel):
4389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4390 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4391 (Faccept_process_output): Use duration_to_sec_usec to do proper
4392 overflow checking on durations.
dde14581
PE
4393 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4394 Don't assume pid_t fits in int.
02481186
PE
4395 * process.h (struct Lisp_Process): Members tick and update_tick
4396 are now of type EMACS_INT, not int.
b62b53e8
PE
4397 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4398 configured --with-wide-int.
d311d28c
PE
4399 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4400 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4401 * search.c (looking_at_1, string_match_1):
4402 (fast_string_match, fast_c_string_match_ignore_case)
4403 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4404 (scan_newline, find_before_next_newline, search_command)
4405 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4406 (set_search_regs, wordify):
4407 (Freplace_match):
4408 (Fmatch_data):
4409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4410 (string_match_1, search_buffer, set_search_regs):
4411 (Fmatch_data):
4412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4413 (wordify): Check for overflow in size calculation.
4414 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4415 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4416 Check that fixnums are in proper range for system types.
4417 * sound.c (struct sound_device)
4418 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4420 (Fplay_sound_internal):
4421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4422 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4423 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4424 (Fparse_partial_sexp):
4425 Don't assume fixnums can fit in int.
4426 (struct lisp_parse_state, find_start_pos, find_start_value)
4427 (find_start_value_byte, find_start_begv)
4428 (update_syntax_table, char_quoted, dec_bytepos)
4429 (find_defun_start, prev_char_comend_first, back_comment):
4430 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4431 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4433 (Finternal_describe_syntax_value): Check that match_lisp is a
4434 character, not an integer, since the code stuffs it into int.
4435 (scan_words, scan_sexps_forward):
4436 Check that fixnums are in proper range for system types.
4437 (Fforward_word):
4438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4439 (scan_sexps_forward):
4440 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4441 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4442 * syntax.h: Adjust decls to match defn changes elsewhere.
4443 (struct gl_state_s):
4444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4445 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4446 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4447 * sysdep.c (wait_for_termination_1, wait_for_termination)
4448 (interruptible_wait_for_termination, mkdir):
4449 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4450 (emacs_read, emacs_write):
4451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4452 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4453 and double all fit in int.
d311d28c
PE
4454 * term.c (set_tty_color_mode):
4455 Check that fixnums are in proper range for system types.
4456 * termhooks.h (struct input_event):
4457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4458 * textprop.c (validate_interval_range, interval_of)
4459 (Fadd_text_properties, set_text_properties_1)
4460 (Fremove_text_properties, Fremove_list_of_text_properties)
4461 (Ftext_property_any, Ftext_property_not_all)
4462 (copy_text_properties, text_property_list, extend_property_ranges)
4463 (verify_interval_modification):
4464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4465 (Fnext_single_char_property_change)
4466 (Fprevious_single_char_property_change):
4467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4468 (copy_text_properties):
4469 Check for integer overflow in index calculation.
d311d28c
PE
4470 * undo.c (last_boundary_position, record_point, record_insert)
4471 (record_delete, record_marker_adjustment, record_change)
4472 (record_property_change):
4473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4474 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4476 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4477 (Fx_hide_tip, Fx_file_dialog):
4478 * w32menu.c (set_frame_menubar):
4479 Use ptrdiff_t, not int, for consistency with rest of code.
4480 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4481 (select_window, Fdelete_other_windows_internal)
4482 (window_scroll_pixel_based, window_scroll_line_based)
4483 (Frecenter, Fset_window_configuration):
4484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4485 (Fset_window_hscroll, run_window_configuration_change_hook)
4486 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4487 (Fscroll_other_window, Frecenter):
d311d28c
PE
4488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4489 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4490 Don't assume fixnum fits in int.
4491 (Fset_window_scroll_bars):
4492 Check that fixnums are in proper range for system types.
4493 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4494 (string_pos, c_string_pos, number_of_chars, init_iterator)
4495 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4496 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4497 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4498 (face_before_or_after_it_pos, handle_invisible_prop)
4499 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4500 (display_prop_intangible_p, string_buffer_position_lim)
4501 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4502 (get_overlay_strings_1, get_overlay_strings)
4503 (iterate_out_of_display_property, forward_to_next_line_start)
4504 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4505 (get_next_display_element, set_iterator_to_next)
4506 (get_visually_first_element, compute_stop_pos_backwards)
4507 (handle_stop_backwards, next_element_from_buffer)
4508 (move_it_in_display_line_to, move_it_in_display_line)
4509 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4510 (add_to_log, message_dolog, message_log_check_duplicate)
4511 (message2, message2_nolog, message3, message3_nolog
4512 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4513 (current_message_1, truncate_echo_area, truncate_message_1)
4514 (set_message, set_message_1, store_mode_line_noprop)
4515 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4516 (text_outside_line_unchanged_p, check_point_in_composition)
4517 (reconsider_clip_changes)
4518 (redisplay_internal, set_cursor_from_row, try_scrolling)
4519 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4520 (redisplay_window, find_last_unchanged_at_beg_row)
4521 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4522 (trailing_whitespace_p, find_row_edges, display_line)
4523 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4524 (display_mode_element, store_mode_line_string)
4525 (pint2str, pint2hrstr, decode_mode_spec)
4526 (display_count_lines, display_string, draw_glyphs)
4527 (x_produce_glyphs, x_insert_glyphs)
4528 (rows_from_pos_range, mouse_face_from_buffer_pos)
4529 (fast_find_string_pos, mouse_face_from_string_pos)
4530 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4532 (safe_call, init_from_display_pos, handle_fontified_prop)
4533 (handle_single_display_spec, load_overlay_strings)
4534 (with_echo_area_buffer, setup_echo_area_for_printing)
4535 (display_echo_area, echo_area_display)
4536 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4537 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4538 (redisplay_window, dump_glyph_row, display_mode_line)
4539 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4540 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4542 (handle_single_display_spec, build_desired_tool_bar_string)
4543 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4544 (get_specified_cursor_type):
4545 Check that fixnums are in proper range for system types.
4546 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4547 (Flookup_image_map):
4548 Don't assume fixnums fit in int.
4549 (compare_overlay_entries):
4550 Avoid mishandling comparisons due to subtraction overflow.
4551 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4552 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4553 (handle_tool_bar_click):
4554 Use int, not unsigned, since we prefer signed and the signedness
4555 doesn't matter here.
4556 (get_next_display_element, next_element_from_display_vector):
4557 Use int, not EMACS_INT, when int is wide enough.
4558 (start_hourglass): Use duration_to_sec_usec to do proper
4559 overflow checking on durations.
4560 * xfaces.c (Fbitmap_spec_p):
4561 Check that fixnums are in proper range for system types.
4562 (compare_fonts_by_sort_order):
4563 Avoid mishandling comparisons due to subtraction overflow.
4564 (Fx_family_fonts, realize_basic_faces):
4565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4566 (Fx_family_fonts):
4567 Don't assume fixnum fits in int.
4568 Use SAFE_ALLOCA_LISP, not alloca.
4569 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4570 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4571 (face_at_buffer_position, face_for_overlay_string)
4572 (face_at_string_position):
4573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4574 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4575 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4576 (Fx_show_tip):
4577 Check that fixnums are in proper range for system types.
4578 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4579 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4581 (Fx_change_window_property): Don't assume fixnums fit in int.
4582 * xfont.c (xfont_chars_supported):
4583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4584 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4585 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4587 * xml.c (parse_region):
4588 * xrdb.c (magic_file_p):
4589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4590 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4591 (x_get_local_selection, x_reply_selection_request)
4592 (x_handle_selection_request, wait_for_property_change):
4593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4594 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4595 short is wide enough.
4596 (x_send_client_event): Don't assume fixnum fits in int.
4597 * xterm.c (x_x_to_emacs_modifiers):
4598 Don't assume EMACS_INT overflows nicely into int.
4599 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4600 may come from Lisp.
4601 (handle_one_xevent): NATNUMP can eval its arg twice.
4602 (x_connection_closed):
4603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4604 * xterm.h: Adjust decls to match defn changes elsewhere.
4605 (struct scroll_bar): Use struct vectorlike_header
4606 rather than rolling our own approximation.
4607 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4608
c6574eb5
GM
46092012-05-25 Glenn Morris <rgm@gnu.org>
4610
4611 * lisp.mk (lisp): Update for more files being compiled now.
4612
e8d32c7e
SM
46132012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4614
48def666
SM
4615 * lread.c: Remove `read_pure' which makes no difference.
4616 (read_pure): Remove var.
4617 (unreadpure): Remove function.
4618 (readevalloop): Don't call read_list with -1 flag.
4619 (read1, read_vector): Don't test read_pure any more.
4620 (read_list): Simplify.
4621
e8d32c7e
SM
4622 * fileio.c, character.h: Minor style tweaks.
4623
4b2addb7
DA
46242012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4625
4626 * window.h (clip_changed): Remove useless declaration.
4627
584461b2
JB
46282012-05-22 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4631 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4632
34374650
PE
46332012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 Remove src/m/*.
4636 This directory predates autoconf and is no longer needed nowadays.
4637 Move its few remaining bits of functionality to where they're needed.
4638 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4639 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4640 * m/template.h: Remove.
4641 * Makefile.in (M_FILE): Remove. All uses removed.
4642 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4643 * lisp.h (USE_LSB_TAG):
4644 * mem-limits.h (EXCEEDS_LISP_PTR):
4645 Use VAL_MAX, not VALBITS, in #if.
4646 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4647 (EMACS_UINT): Define unconditionally now.
4648 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4649 (BITS_PER_EMACS_INT): New constants, replacing
4650 what used to be in config.h, but not useful in #if.
4651 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4652 define them any more.
4653 (VAL_MAX): New macro.
4654 (VALMASK): Use it.
4655 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4656 BITS_PER_EMACS_INT, in #if.
4657 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4658 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4659 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4660 * s/ms-w32.h (DATA_START):
4661 Move here from removed file m/intel386.h.
4662 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4663 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4664
261cb4bb
PE
46652012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4666
4667 Assume C89 or later.
4668 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4669 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4670 (xrealloc):
4671 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4672 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4673 * textprop.c, tparam.c (NULL): Remove.
4674 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4675 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4676 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4677 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4678 * xterm.c (input_signal_count): Assume volatile works.
4679
ff23cd9f
KB
46802012-05-21 Ken Brown <kbrown@cornell.edu>
4681
4682 * xgselect.c (xg_select): Fix first argument in call to 'select'
4683 (bug#11508).
4684
1b170bc6
KB
46852012-05-20 Ken Brown <kbrown@cornell.edu>
4686
4687 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4688 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4689
b2f4d39f
KB
46902012-05-19 Ken Brown <kbrown@cornell.edu>
4691
4692 * xfns.c (x_in_use): Remove `static' qualifier.
4693 * xterm.h (x_in_use): Declare.
4694 * xgselect.c: Include xterm.h.
4695 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4696 and `display_arg' (bug#9754).
4697
003fdae2
PE
46982012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4699
9232a6d9
PE
4700 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4701
003fdae2
PE
4702 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4703 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4704
784b56e2
EZ
47052012-05-18 Eli Zaretskii <eliz@gnu.org>
4706
4707 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4708
4709 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4710 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4711
4712 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4713 reference to image_cache->refcount.
4714 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4715
a0a79cde
JL
47162012-05-17 Juri Linkov <juri@jurta.org>
4717
4718 * search.c (Fword_search_regexp, Fword_search_backward)
4719 (Fword_search_forward, Fword_search_backward_lax)
4720 (Fword_search_forward_lax): Move functions to isearch.el
4721 (bug#10145, bug#11381).
4722
b0572523
PE
47232012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4726
9660f5fc
SM
47272012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4728
4729 * lread.c (init_obarray): Declare Qt and Qnil as special.
4730
4374de83
GM
47312012-05-14 Glenn Morris <rgm@gnu.org>
4732
4733 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4734 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4735
dc44c39a
PE
47362012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4737
078c97cb
PE
4738 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4739
dc44c39a
PE
4740 * unexaix.c: Port to more-recent AIX compilers.
4741 (report_error, report_error_1, make_hdr, copy_sym)
4742 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4743 Make arguments const char *, not char *, to avoid violations of C
4744 standard and to fix some AIX warnings reported by Gilles Pion.
4745
e18afed7 47462012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4747
4748 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4749 already have overlays loaded.
4750 (handle_single_display_spec): Before returning without displaying
4751 fringe bitmap, synchronize the bidi iterator with the main display
4752 iterator, by calling iterate_out_of_display_property.
4753 (iterate_out_of_display_property): Detect buffer iteration by
4754 testing that it->string is a Lisp string.
4755 (get_next_display_element): When the current object is exhausted,
4756 and there's something on it->stack, call set_iterator_to_next to
4757 proceed with what's on the stack, instead of returning zero.
4758 (set_iterator_to_next): If called at the end of a Lisp string,
4759 proceed to consider_string_end without incrementing string
4760 position. Don't increment display vector index past the end of
4761 the display vector. (Bug#11417)
c8fb9dc6
EZ
4762 (pos_visible_p): Don't report a position visible when move_it_to
4763 stopped at the last line of window, which happens to be scanned
4764 backwards by the bidi iteration. (Bug#11464)
ac268e67 4765
e18afed7 47662012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4767
4768 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4769 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4770 are on a TTY, and thus unable to display on the fringes.
4771 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4772 so we need to signal to the caller that this is a "replacing"
4773 display spec. This fixes display when the spec is invalid or we
4774 are on a TTY.
4775
e18afed7 47762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4777
4778 * unexaix.c (make_hdr): Fix typo in prototype.
4779 This bug broke the build on AIX. Problem reported by Gilles Pion.
4780
9d0a235a
MA
47812012-05-14 Michael Albinus <michael.albinus@gmx.de>
4782
4783 * keyboard.c (kbd_buffer_get_event): Read special events also in
4784 batch mode. (Bug#11415)
4785
9e6b06ed
GM
47862012-05-12 Glenn Morris <rgm@gnu.org>
4787
4788 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4789
c1a1d7a3
EZ
47902012-05-12 Eli Zaretskii <eliz@gnu.org>
4791
4792 * lisp.mk (lisp): Add newcomment.elc.
4793
3fe7cdc8
GM
47942012-05-12 Glenn Morris <rgm@gnu.org>
4795
4796 * Makefile.in (MKDIR_P): New, set by configure.
4797 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4798
53f7d2c0
PE
47992012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 Remove unused function hourglass_started.
4802 * dispextern.h (hourglass_started):
4803 * w32fns.c (hourglass_started):
4804 * xdisp.c (hourglass_started): Remove.
4805
75aafb17
JB
48062012-05-10 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4809 Update dependencies.
4810
12959e8e
PE
48112012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4812
97107e2e
PE
4813 * xgselect.c (xg_select): Put maxfds+1 into a var.
4814 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4815
12959e8e
PE
4816 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4817
836d29b3
DA
48182012-05-10 Dave Abrahams <dave@boostpro.com>
4819
4820 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4821 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4822
5cb67954
MA
48232012-05-09 Michael Albinus <michael.albinus@gmx.de>
4824
4825 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4826 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4827 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4828 Initialize xd_registered_buses.
4829
3478ec45
PE
48302012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4831
b263a6b0
PE
4832 Untag more efficiently if USE_LSB_TAG.
4833 This is based on a proposal by YAMAMOTO Mitsuharu in
4834 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4835 For an admittedly artificial (nth 8000 longlist) benchmark on
4836 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4837 Emacs's overall text size by 1%.
4838 * lisp.h (XUNTAG): New macro.
4839 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4840 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4841 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4842 * eval.c (Fautoload):
4843 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4844 * frame.h (XFRAME): Use XUNTAG.
4845
3478ec45
PE
4846 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4847 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4848 Remove unportable assumptions about print widths of types like
4849 dbus_uint32_t.
4850 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4851 intptr_t when converting between pointer and integer, to avoid GCC
4852 warnings about wrong width.
4853
666b903b 48542012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4855
4856 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4857 stack for each reader_thread, instead of defaulting to 8MB
4858 determined by the linker. This avoids failures in creating
4859 subprocesses on Windows 7, see the discussion in this thread:
4860 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4861
b120cc17
JC
48622012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4863
4864 Fix up display of the *Minibuf-0* buffer in the mini window.
4865 * keyboard.c (read_char): Don't clear the echo area if there's no
4866 message to clear.
4867 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4868 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4869
9a4b36f8
MA
48702012-05-07 Michael Albinus <michael.albinus@gmx.de>
4871
4872 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4873 batch mode.
4874
e5f9458f
CY
48752012-05-06 Chong Yidong <cyd@gnu.org>
4876
4877 * lisp.mk (lisp): Update.
4878
eceeb5fc 48792012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4880
4881 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4882
71873e2b
SM
48832012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4884
4885 * data.c (PUT_ERROR): New macro.
4886 (syms_of_data): Use it. Add new error type `user-error'.
4887 * undo.c (user_error): New function.
4888 (Fprimitive_undo): Use it.
4889 * print.c (print_error_message): Adjust print style for `user-error'.
4890 * keyboard.c (user_error): New function.
4891 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4892
ab0fa4e4
PE
48932012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4894
4895 Do not limit current-time-string to years 1000..9999.
4896 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4897 (Fcurrent_time_string): Support any year that is supported by the
4898 underlying localtime representation. Don't use asctime, as it
4899 has undefined behavior for years outside the range -999..9999.
4900
7ed806a7
PE
49012012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4902
4903 Fix race conditions involving setenv, gmtime, localtime, asctime.
4904 Without this fix, interrupts could mess up code that uses these
4905 nonreentrant functions, since setting TZ invalidates existing
4906 tm_zone or tzname values, and since most of these functions return
4907 pointers to static storage.
4908 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4909 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4910 Grow the critical sections to include not just invoking
4911 localtime/gmtime, but also accessing these functions' results
4912 including their tm_zone values if any, and any related TZ setting.
4913 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4914 so that the struct tm is saved in the critical section.
4915 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4916 motivated by the fact that memory allocation needs to be outside
4917 the critical section.
4918
0c16dfed
DA
49192012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4920
4921 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4922 with RESET_INTERVAL.
4923
4924 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4925 Remove duplicated buffer name initialization.
4926
3f83ace8
JM
49272012-05-02 Jim Meyering <jim@meyering.net>
4928
4929 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4930
c7b8541e
JM
4931 * xfns.c (x_window): Use xstrdup (Bug#11375).
4932
90207a15 49332012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4934
4935 * xdisp.c (pos_visible_p): If already at a newline from the
4936 display string before the 'while' loop, don't walk back the glyphs
4937 from it3.glyph_row. Solves assertion violation when the display
4938 string begins with a newline (egg.el). (Bug#11367)
4939
b593d6a9
AH
49402012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4943 Move to simple.el.
4944
4737362e
GM
49452012-05-01 Glenn Morris <rgm@gnu.org>
4946
99cf43f9
GM
4947 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4948 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4949 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4950 All were removed before 23.1.
4951
9311dcff
GM
4952 * dispnew.c: Remove HAVE_LIBNCURSES test;
4953 it is always true on relevant platforms.
4954
4d5c6349
GM
4955 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4956 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4957
4737362e
GM
4958 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4959
74dd3a6b
AS
49602012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4961
4962 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4963 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4964 Remove.
4965
13c379ee
PE
49662012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Do not avoid creating empty evaporating overlays (Bug#9642).
4969 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4970 That is, do not delete an evaporating overlay if it becomes
4971 empty after its bounds are adjusted to fit within its buffer.
4972 This fix caused other problems, and I'm reverting it until we get
4973 to the bottom of them.
4974
a8e7d6d7 49752012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4976
4977 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4978
a8e7d6d7 49792012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4980
4981 * xdisp.c (pos_visible_p): If the window start position is beyond
4982 ZV, start the display from buffer beginning. Prevents assertion
4983 violation in init_iterator when the minibuffer window is scrolled
4984 via the scroll bar.
4985
4986 * window.c (window_scroll_pixel_based): Likewise.
4987
a8e7d6d7 49882012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4989
4990 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4991
a8e7d6d7 49922012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4993
4994 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4995 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4996
a8e7d6d7 49972012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4998
b593d6a9
AH
4999 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5000 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5001
1c6900d9
EZ
50022012-04-26 Eli Zaretskii <eliz@gnu.org>
5003
4c3fa1d9
EZ
5004 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5005 display element, check also the underlying string or buffer
5006 character. (Bug#11341)
5007
1c6900d9
EZ
5008 * w32menu.c: Include w32heap.h.
5009 (add_menu_item): If the call to AppendMenuW (via
5010 unicode_append_menu) fails, disable Unicode menus only if we are
5011 running on Windows 9X/Me.
5012
42bf8205
AS
50132012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5014
5015 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5016 (xgetint): Add missing shift for LSB tags.
5017
b1bac16e
MR
50182012-04-24 Martin Rudalics <rudalics@gmx.at>
5019
5020 * keyboard.c (read_char): Don't wipe echo area for select window
5021 events: These might get delayed via `mouse-autoselect-window'
5022 (Bug#11304).
5023
d69621cc
JB
50242012-04-24 Juanma Barranquero <lekktu@gmail.com>
5025
5026 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5027 manipulation of :loaded-from data.
5028
02fd101b
JB
50292012-04-23 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5032 now a cons (bug#11311).
5033
888bec30
PE
50342012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5035
89a438bd
PE
5036 Do not create empty overlays with the evaporate property (Bug#9642).
5037 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5038 if it becomes empty after its bounds are adjusted to fit within
5039 its buffer. Without this fix, in a nonempty buffer (let ((o
5040 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5041 yields an empty overlay that has the evaporate property, which is
5042 not supposed to happen.
5043
1068fe4d
PE
5044 Fix minor GTK3 problems found by static checking.
5045 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5046 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5047 (struct _EmacsFixedClass, emacs_fixed_get_type):
5048 Move decls here from emacsgtkfixed.h, since they needn't be public.
5049 (emacs_fixed_get_type): Now static.
5050 (emacs_fixed_class_init): Omit unused local.
5051 (emacs_fixed_child_type): Remove; unused.
5052 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5053 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5054 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5055 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5056 (EMACS_FIXED_GET_CLASS): Remove; unused.
5057 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5058
888bec30
PE
5059 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5060 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5061
de85e130
PE
50622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5063
d0baac98 5064 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5065 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5066 (__malloc_size_t, __malloc_ptrdiff_t):
5067 Remove. All uses removed, replaced by the definiens if needed,
5068 since we can assume C89 or better now.
5069 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5070 (protect_malloc_state, align, get_contiguous_space)
5071 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5072 (malloc_atfork_handler_child, malloc_enable_thread)
5073 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5074 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5075 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5076 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5077 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5078 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5079 Define using prototypes, not old style.
5080 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5081 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5082 (align): Don't assume that signed integer overflow wraps around.
5083 Omit unused local var.
5084 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5085 (_free_internal_nolock, memalign, mallochook, reallochook):
5086 Omit no-longer-needed casts.
5087 (valloc): Use getpagesize, not __getpagesize.
5088 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5089 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5090
de85e130
PE
5091 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5092
dcbf5805
MA
50932012-04-22 Michael Albinus <michael.albinus@gmx.de>
5094
5095 Move functions from C to Lisp. Make non-blocking method calls
5096 the default. Implement further D-Bus standard interfaces.
5097
5098 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5099 (QCdbus_request_name_allow_replacement)
5100 (QCdbus_request_name_replace_existing)
5101 (QCdbus_request_name_do_not_queue)
5102 (QCdbus_request_name_reply_primary_owner)
5103 (QCdbus_request_name_reply_in_queue)
5104 (QCdbus_request_name_reply_exists)
5105 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5106 (QCdbus_registered_serial, QCdbus_registered_method)
5107 (QCdbus_registered_signal): New Lisp objects.
5108 (XD_DEBUG_MESSAGE): Use sizeof.
5109 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5110 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5111 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5112 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5113 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5114 (xd_signature, xd_append_arg): Allow float for integer types.
5115 (xd_get_connection_references): New function.
b593d6a9
AH
5116 (xd_get_connection_address): Rename from xd_initialize.
5117 Return cached address.
dcbf5805
MA
5118 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5119 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5120 level.
5121 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5122 Return number of refcounts.
dcbf5805
MA
5123 (Fdbus_get_unique_name): Make stronger parameter check.
5124 (Fdbus_message_internal): New defun.
5125 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5126 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5127 (Fdbus_send_signal, Fdbus_register_service)
5128 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5129 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5130 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5131 (Vdbus_compiled_version, Vdbus_runtime_version)
5132 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5133 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5134 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5135 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5136 Adapt docstring.
dcbf5805 5137
52828e02
PE
51382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5139
da05bc4c
PE
5140 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5141 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5142 Do not assume ptrdiff_t is the same width as 'int'.
5143
52828e02
PE
5144 * alloc.c: Handle unusual debugging option combinations.
5145 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5146 since the two debugging options are incompatible.
5147 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5148 is defined.
5149 (mem_init, mem_insert, mem_insert_fixup):
5150 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5151 (NEED_MEM_INSERT): Remove; no longer needed.
5152
f01769f9
LL
51532012-04-22 Leo Liu <sdl.web@gmail.com>
5154
5155 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5156
5790543d
PE
51572012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5158
5159 * sysdep.c [__FreeBSD__]: Minor cleanups.
5160 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5161 Use Emacs indenting style more consistently. Avoid some casts.
5162 Use 'double' consistently rather than mixing 'float' and 'double'.
5163
b91b7e4d
EW
51642012-04-21 Eduard Wiebe <usenet@pusto.de>
5165
b593d6a9
AH
5166 * sysdep.c (list_system_processes, system_process_attributes):
5167 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5168
6114eb15
AS
51692012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5170
5171 * lisp.mk (lisp): Update.
5172
2f38dff7
PE
51732012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5174
5175 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5176 It is never used otherwise.
5177
4ae29f89
SM
51782012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5179
5180 * print.c (print_preprocess): Only check print_depth if print-circle
5181 is nil.
5182 (print_object): Check for cycles even when print-circle is nil and
5183 print-gensym is t, but only check print_depth if print-circle is nil.
5184
f30d612a
CY
51852012-04-20 Chong Yidong <cyd@gnu.org>
5186
5187 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5188 set the status to "failed" and ensure that sentinel is run.
5189
c07a4c0b 51902012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5191
5192 * process.c (Fset_process_inherit_coding_system_flag)
5193 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5194 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5195
c07a4c0b 51962012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5197
5198 * xdisp.c (string_buffer_position_lim): Limit starting position to
5199 BEGV.
5200 (set_cursor_from_row): If called for a mode-line or header-line
5201 row, return zero immediately.
5202 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5203 farther than the first row after the header line, if any.
5204 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5205 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5206
c07a4c0b 52072012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5208
4ae29f89
SM
5209 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5210 (bug#11238).
ad3a2b41 5211
c07a4c0b 52122012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52132012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5214
5215 configure: new option --enable-gcc-warnings (Bug#11207)
5216 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5217 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5218 (ALL_CFLAGS): Use new macros rather than old.
5219 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5220 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5221 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5222 -Wunused-result, -Wunused-variable. This should go away once
5223 the Emacs and Gnulib regex code is merged.
5224 (xmalloc, xrealloc): Now static.
5225
aba027e8
PE
52262012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 * dired.c (Fsystem_groups): Remove unused local.
5229
e5a36063
GM
52302012-04-17 Glenn Morris <rgm@gnu.org>
5231
5232 * dired.c (Fsystem_users): Doc fix.
5233
316411f0
DA
52342012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5235
5236 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5237 (syms_of_dired): Add them.
5238
9426aba4
PE
52392012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5240
b62a57be
PE
5241 Fix minor alloc.c problems found by static checking.
5242 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5243 New extern decls, to avoid calling undeclared functions.
5244 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5245 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5246 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5247 (NEED_MEM_INSERT): New macro.
5248 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5249 Remove one incorrect comment and fix another.
b62a57be 5250
3539f31f
PE
5251 Fix minor ralloc.c problems found by static checking.
5252 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5253 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5254 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5255 (r_alloc_sbrk): Now static.
5256
a041960a
PE
5257 Improve ralloc.c interface checking.
5258 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5259 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5260 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5261 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5262 [REL_ALLOC]: ... to here, to check interface.
5263 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5264 Remove decls. This fixes an "It stinks!".
5265
9426aba4
PE
5266 * alloc.c (which_symbols): Fix alignment issue / type clash.
5267
d55c12ed
AS
52682012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5269
5270 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5271 (struct Lisp_Misc_Any): Likewise.
5272 (struct Lisp_Free): Likewise.
5273 * alloc.c (union aligned_Lisp_Symbol): Define.
5274 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5275 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5276 (union aligned_Lisp_Misc): Define.
5277 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5278 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5279 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5280
b948ce8b
PE
52812012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5284 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5285 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5286 * s/netbsd.h, s/sol2-6.h:
5287 Remove definition of GC_MARK_STACK, since the default now works.
5288 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5289 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5290 no longer the default.
5291 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5292
35dc09a1 52932012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5294
35dc09a1
GM
5295 * lread.c (lisp_file_lexically_bound_p):
5296 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5297
35dc09a1
GM
52982012-04-14 Eli Zaretskii <eliz@gnu.org>
5299
5300 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5301 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5302
53032012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5304
5305 * nsterm.m (constrainFrameRect): Always constrain when there is only
5306 one screen (Bug#10962).
5307
bcd86815
KB
53082012-04-13 Ken Brown <kbrown@cornell.edu>
5309
5310 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5311
c25df26e
RT
53122012-04-13 Reuben Thomas <rrt@sc3d.org>
5313
5314 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5315
0fc59f1e
DC
53162012-04-11 Daniel Colascione <dancol@dancol.org>
5317
5318 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5319 against is gone. It's better to use vfork now so that when Cygwin
5320 gains a new, working vfork, we use it automatically (bug#10398).
5321
de8c03dc
SM
53222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * window.c (save_window_save): Obey window-point-insertion-type.
5325
2f097256
GM
53262012-04-11 Glenn Morris <rgm@gnu.org>
5327
5328 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5329
453b951e
SM
53302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5331
5332 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5333
75f1671a 53342012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5335
5336 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5337 (force_quit_count): New var.
5338 (handle_interrupt): Use it.
5339
2a8ce227
JB
53402012-04-10 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * w32.c (w32_delayed_load): Record the full path of the library
5343 being loaded (bug#10424).
5344
935396c0
GM
53452012-04-09 Glenn Morris <rgm@gnu.org>
5346
05920a43
GM
5347 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5348 not just in the obarray, before snarfing them. (Bug#11036)
5349
935396c0
GM
5350 * Makefile.in ($(leimdir)/leim-list.el):
5351 Pass EMACS rather than BUILT_EMACS.
5352
a18ecafa
TZ
53532012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5354
5355 * process.c (make_process):
5356 * process.h: Add integer `gnutls_handshakes_tried' member to
5357 process struct.
5358
6bbef4e5
JC
5359 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5360 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5361
5362 * gnutls.c (gnutls_log_function2i): Convenience log function.
5363 (emacs_gnutls_read): Use new log functions,
5364 `gnutls_handshakes_tried' process member, and
5365 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5366 attempts per process (connection).
5367
b4d3bc10
CY
53682012-04-09 Chong Yidong <cyd@gnu.org>
5369
5370 * eval.c (Fuser_variable_p, user_variable_p_eh)
5371 (lisp_indirect_variable): Functions deleted.
5372 (Fdefvar): Caller changed.
5373
5374 * callint.c (Finteractive, Fcall_interactively):
5375 * minibuf.c (Fread_variable): Callers changed.
5376
70f4d973
EZ
53772012-04-09 Eli Zaretskii <eliz@gnu.org>
5378
5379 * xdisp.c (set_cursor_from_row): If the display string appears in
5380 the buffer at position that is closer to point than the position
5381 after the display string, display the cursor on the first glyph of
5382 the display string. Fixes cursor display when a 'display' text
5383 property immediately follows invisible text. (Bug#11094)
5384
cb3c2e3e
PE
53852012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5386
5387 composite.c: use 'double' consistently
5388 * composite.c (get_composition_id): Use 'double' consistently
5389 instead of converting 'float' to 'double' and vice versa; this is
5390 easier to understand and avoids a GCC warning.
5391
fd06db5d
GM
53922012-04-09 Glenn Morris <rgm@gnu.org>
5393
50fe702a
GM
5394 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5395 preparation for dumping it with emacs. (Bug#4789)
5396 (leimdir): New variable.
5397 ($(leimdir)/leim-list.el): New rule.
5398 (emacs$(EXEEXT)): Depend on leim-list.el.
5399
fd06db5d
GM
5400 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5401 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5402 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5403
55c131ee
AS
54042012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5405
5406 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5407 proper alignment.
5408
9209588f
JB
54092012-04-07 Juanma Barranquero <lekktu@gmail.com>
5410
5411 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5412 Remove unused local variable.
5413
e3fb2efb
PE
54142012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5415
5416 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5417 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5418 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5419 objects, as mark_maybe_pointer will catch them otherwise.
5420 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5421 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5422
b5385551
PE
54232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 Fix typo that broke non-Windows builds.
5426 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5427
9078ead6
EZ
54282012-04-07 Eli Zaretskii <eliz@gnu.org>
5429
5430 Support building on MS-Windows with libxml2.
5431
5432 * makefile.w32-in (OBJ2): Add xml.$(O).
5433 (GLOBAL_SOURCES): Add xml.c.
5434 ($(BLD)/xml.$(O)): New dependency list.
5435
5436 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5437 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5438 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5439 [!WINDOWSNT]: New macros.
5440 (init_libxml2_functions, libxml2_loaded_p): New functions.
5441 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5442 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5443 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5444 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5445 linked in).
6bbef4e5
JC
5446 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5447 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5448 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5449
5450 * emacs.c: Don't include libxml/parser.h.
5451 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5452 xmlCleanupParser directly.
5453
5454 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5455
3811fdf3
EZ
54562012-04-07 Eli Zaretskii <eliz@gnu.org>
5457
5458 * indent.c (Fvertical_motion): If there is a display string at
5459 point, use it.vpos to compute how many lines to backtrack after
5460 move_it_to point. (Bug#11133)
5461
2f8e16b2
EZ
54622012-04-06 Eli Zaretskii <eliz@gnu.org>
5463
5464 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5465 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5466 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5467 macros related to unification of CJK characters. For the details,
5468 see the discussion following the message here:
5469 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5470
3d439cd1
CY
54712012-04-04 Chong Yidong <cyd@gnu.org>
5472
5473 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5474
8bc53d00
EZ
54752012-04-01 Eli Zaretskii <eliz@gnu.org>
5476
5477 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5478 instead of alloca. (Bug#11138)
5479
3b0512a3
AS
54802012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5481
5482 * w32menu.c (is_simple_dialog): Properly check lisp types.
5483 (Bug#11141)
5484
8427ddd2
EZ
54852012-03-31 Eli Zaretskii <eliz@gnu.org>
5486
979022ef
EZ
5487 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5488 position we get to after a call to move_it_to fails the
5489 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5490 only if we wind up in a string from display property. (Bug#11063)
5491
a6b1c7cc
EZ
5492 * window.c (Fdelete_other_windows_internal): Invalidate the row
5493 and column information about mouse highlight, so that redisplay
5494 restores it after reallocating the glyph matrices. (Bug#7464)
5495
8427ddd2
EZ
5496 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5497 string comes from a `display' text property, use the buffer
5498 position of that property as if we actually saw that position in
5499 the row's glyphs.
697ba24b
EZ
5500 (move_it_by_lines): Remove the assertion that
5501 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5502 violated when there's a before-string at the beginning of a line.
5503 (Bug#11063)
8427ddd2 5504
65a0a738
EZ
55052012-03-30 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (append_space_for_newline): If the default face was
5508 remapped, use the remapped face for the appended newline.
5509 (extend_face_to_end_of_line): Use the remapped default face for
5510 extending the face to the end of the line.
5511 (display_line): Call extend_face_to_end_of_line when the default
5512 face was remapped. (Bug#11068)
5513
581355cc
EZ
55142012-03-29 Eli Zaretskii <eliz@gnu.org>
5515
5516 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5517
e8fc049f
SM
55182012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5519
5520 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5521
4fb9a543
GM
55222012-03-27 Glenn Morris <rgm@gnu.org>
5523
5524 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5525 Doc fixes.
5526
679910f1
KH
55272012-03-26 Kenichi Handa <handa@m17n.org>
5528
5529 * dispextern.h (struct glyph): Fix previous change. Change the
5530 bit length of glyphless.ch to 25 (Bug#11082).
5531
90d49b7f
CY
55322012-03-26 Chong Yidong <cyd@gnu.org>
5533
5534 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5535 (command_loop_1): Use it; inhibit selection update for
5536 handle-select-window too (Bug#8996).
5537
f514f6f0
FP
55382012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5539
e8fc049f 5540 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5541
bf43fa51
KH
55422012-03-25 Kenichi Handa <handa@m17n.org>
5543
5544 * dispextern.h (struct glyph): Change the bit length of
5545 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5546
8a0c01dd
EZ
55472012-03-24 Eli Zaretskii <eliz@gnu.org>
5548
5549 * s/ms-w32.h (tzname): Include time.h before redirecting to
5550 _tzname. Fixes the MSVC build. (Bug#9960)
5551
7d1c3a76
AS
55522012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5553
8ed79523
AS
5554 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5555 characters.
5556
7d1c3a76
AS
5557 * xterm.c (XTread_socket): Only modify handling_signal if
5558 !SYNC_INPUT. (Bug#11080)
5559
e99a9b8b
EZ
55602012-03-23 Eli Zaretskii <eliz@gnu.org>
5561
5562 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5563 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5564 when fetching a multibyte character consumes more bytes than
5565 CHAR_BYTES returns, due to unification of CJK characters in
5566 string_char. (Bug#11073)
5567
5063c0e1
TN
55682012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5569
5570 * process.c (wait_reading_process_output): Handle pty disconnect
5571 by refraining from sending oneself a SIGCHLD (bug#10933).
5572
9f851fbd
CY
55732012-03-22 Chong Yidong <cyd@gnu.org>
5574
5575 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5576
5063c0e1 5577 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5578 Mark string as coming from a prefix property.
5579 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5580 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5581
fb5b8aca
CY
55822012-03-21 Chong Yidong <cyd@gnu.org>
5583
5584 * xfaces.c (Vface_remapping_alist): Doc fix.
5585
62356a1b
EZ
55862012-03-20 Eli Zaretskii <eliz@gnu.org>
5587
5588 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5589 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5590 Doc fixes.
62356a1b 5591
025de85b
CY
55922012-03-20 Chong Yidong <cyd@gnu.org>
5593
5594 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5595 to reflect default non-nil value of redisplay-dont-pause.
5596
4827f94e
KH
55972012-03-19 Kenichi Handa <handa@m17n.org>
5598
5599 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5600 it fit in a valid range (Bug#11003).
5601
e50a24a2
EZ
56022012-03-18 Eli Zaretskii <eliz@gnu.org>
5603
5604 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5605 that is not from display property, accept the row as a "cursor
5606 row" if one of the string's character has a non-nil `cursor'
5607 property. Fixes cursor positioning when there are newlines in
5608 overlay strings, e.g. in icomplete.el. (Bug#11035)
5609
9af5ed87
PE
56102012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5611
5612 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5613
d1f55f16
CY
56142012-03-12 Chong Yidong <cyd@gnu.org>
5615
5616 * eval.c (inhibit_lisp_code): Rename from
5617 inhibit_window_configuration_change_hook; move from window.c.
5618
5619 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5620 * window.c (run_window_configuration_change_hook)
5621 (syms_of_window): Callers changed.
5622
66c5eebd
CY
56232012-03-11 Chong Yidong <cyd@gnu.org>
5624
413df973
CY
5625 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5626
66c5eebd
CY
5627 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5628
1de11f56
CY
56292012-03-10 Chong Yidong <cyd@gnu.org>
5630
5631 * frame.c (other_visible_frames): Don't assume the selected frame
5632 is visible (Bug#10955).
5633
cae07000
SM
56342012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5635
5636 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5637
89c94350
JD
56382012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5639
5640 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5641 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5642 zero (Bug#10954).
5643
999dd333
GM
56442012-03-03 Glenn Morris <rgm@gnu.org>
5645
01a6dcc8 5646 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5647
de0100f2
EZ
56482012-03-02 Eli Zaretskii <eliz@gnu.org>
5649
5650 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5651 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5652 (redisplay_window, next_element_from_string): Fix typos in
5653 comments.
3e441275
EZ
5654 (redisplay_window): Pass to move_it_vertically the margin in
5655 pixels, not in screen lines.
de0100f2 5656
96a72ee9
GM
56572012-03-02 Glenn Morris <rgm@gnu.org>
5658
5659 * buffer.c (buffer-list-update-hook): Doc fix.
5660
312508d7
EZ
56612012-02-29 Eli Zaretskii <eliz@gnu.org>
5662
5663 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5664 push_it before setting up the iterator for the first overlay
5665 string, even if we have an empty string loaded.
5666 (next_overlay_string): If there's an empty string on the iterator
5667 stack, pop the stack. (Bug#10903)
5668
27f3c637
PE
56692012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5670
5671 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5672 Suggested by Stefan Monnier in
5673 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5674 * alloc.c (widen_to_Lisp_Object): New static function.
5675 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5676 and widening them to Lisp_Objects. This would work even if
5677 USE_LSB_TAG is defined and wide integers are used, which might
5678 happen in a future version of Emacs.
5679
3c9dfce6
CY
56802012-02-25 Chong Yidong <cyd@gnu.org>
5681
fa74b241
CY
5682 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5683 Doc fix.
5684
3c9dfce6
CY
5685 * xselect.c (Fx_selection_exists_p): Doc fix.
5686 (x_clipboard_manager_save_all): Print an informative message
5687 before saving to clipboard manager.
5688
9486df08
CY
56892012-02-24 Chong Yidong <cyd@gnu.org>
5690
5691 * keyboard.c (process_special_events): Handle all X selection
5692 requests in kbd_buffer, not just the next one (Bug#8869).
5693
f01d3321
CY
56942012-02-23 Chong Yidong <cyd@gnu.org>
5695
5696 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5697 call when setting menu-bar-lines and tool-bar-lines parameters.
5698 (unwind_create_frame_1): New helper function.
5699
5700 * window.c (inhibit_window_configuration_change_hook): New var.
5701 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5702 (syms_of_window): Initialize it.
f01d3321 5703
86b847b6
CY
57042012-02-22 Chong Yidong <cyd@gnu.org>
5705
5706 * xterm.c (x_draw_image_relief): Add missing type check for
5707 Vtool_bar_button_margin (Bug#10743).
5708
a59225b1
CY
57092012-02-21 Chong Yidong <cyd@gnu.org>
5710
5711 * fileio.c (Vfile_name_handler_alist): Doc fix.
5712
5713 * buffer.c (Fget_file_buffer): Protect against invalid file
5714 handler return value.
5715
310f5bd4
PE
57162012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5717
cb3a28cc
PE
5718 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5719 when computing $valmask.
5720
310f5bd4
PE
5721 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5722 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5723 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5724 It's useless in that case, and it can cause problems on hosts
5725 that allocate halves of EMACS_INT values separately.
5726 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5727 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5728 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5729 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5730 it avoids undefined behavior on hosts where shifting right by more
5731 than the word width has undefined behavior.
5732
2375c96a
CY
57332012-02-19 Chong Yidong <cyd@gnu.org>
5734
5735 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5736 (Funhandled_file_name_directory, Ffile_name_as_directory)
5737 (Fdirectory_file_name, Fexpand_file_name)
5738 (Fsubstitute_in_file_name): Protect against invalid file handler
5739 return values (Bug#10845).
5740
3eb49e71
EZ
57412012-02-18 Eli Zaretskii <eliz@gnu.org>
5742
5743 * .gdbinit (pitx): Fix incorrect references to fields of the
5744 iterator stack.
5745
7b926f3f
CY
57462012-02-17 Chong Yidong <cyd@gnu.org>
5747
5748 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5749
11273115
PE
57502012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5753 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5754
c3a70e2b
CY
57552012-02-15 Chong Yidong <cyd@gnu.org>
5756
5757 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5758 marked as special. Also, starting docstrings with * is obsolete.
5759
0ca43699
AS
57602012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5761
5762 * gnutls.c (emacs_gnutls_write): Fix last change.
5763
2e8f3c56
LI
57642012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5765
5766 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5767 send_process.
5768
af70074f
SM
57692012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5770
5771 * keymap.c (Fsingle_key_description): Handle char ranges.
5772
95986d52
CY
57732012-02-12 Chong Yidong <cyd@gnu.org>
5774
afd83bd1
CY
5775 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5776 as that creates a dangerous corner case.
5777
95986d52
CY
5778 * window.c (Fdelete_window_internal): Invalidate the mouse
5779 highlight (Bug#9904).
5780
bd7da63e
GM
57812012-02-12 Glenn Morris <rgm@gnu.org>
5782
5783 * xselect.c (Fx_own_selection_internal)
5784 (Fx_get_selection_internal, Fx_disown_selection_internal)
5785 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5786 * nsselect.m (Fx_own_selection_internal)
5787 (Fx_disown_selection_internal, Fx_selection_exists_p)
5788 (Fx_selection_owner_p, Fx_get_selection_internal):
5789 Sync docs and argument specs with the xselect.c versions.
5790
77abcbc2
LI
57912012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5792
5793 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5794
90b671e2
EZ
57952012-02-11 Eli Zaretskii <eliz@gnu.org>
5796
1c0ca0b7
EZ
5797 * w32select.c (Fx_selection_exists_p): Sync doc string and
5798 argument list with xselect.c. (Bug#10783)
5799
5800 * w16select.c (Fx_selection_exists_p): Sync doc string and
5801 argument list with xselect.c. (Bug#10783)
90b671e2 5802
49241268
GM
58032012-02-10 Glenn Morris <rgm@gnu.org>
5804
5805 * fns.c (Fsecure_hash): Doc fix.
5806
f998bbe7 58072012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5808
5809 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5810
0992bd9c
CY
58112012-02-07 Chong Yidong <cyd@gnu.org>
5812
5813 * buffer.c (Fbuffer_local_variables)
5814 (buffer_lisp_local_variables): Handle unbound vars correctly;
5815 don't let Qunbound leak into Lisp.
5816
af008560
GM
58172012-02-07 Glenn Morris <rgm@gnu.org>
5818
dd605cc4
GM
5819 * image.c (Fimagemagick_types): Doc fix.
5820
af008560
GM
5821 * image.c (imagemagick-render-type): Change it from a lisp object
5822 to an integer. Move the doc here from the lisp manual.
5823 Treat all values not equal to 0 the same.
5824
1449fa1d
CY
58252012-02-06 Chong Yidong <cyd@gnu.org>
5826
5827 * doc.c (store_function_docstring): Avoid applying docstring of
5828 alias to base function (Bug#2603).
5829
3723ec07
AS
58302012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5831
5832 * .gdbinit (pp1, pv1): Remove redundant defines.
5833 (pr): Use pp.
5834
79c1cc1e
CY
58352012-02-04 Chong Yidong <cyd@gnu.org>
5836
5837 * nsterm.m: Declare a global (Bug#10694).
5838
d7f29f8e
EZ
58392012-02-04 Eli Zaretskii <eliz@gnu.org>
5840
cae07000
SM
5841 * w32.c (get_emacs_configuration_options):
5842 Include --enable-checking, if specified, in the return value.
d7f29f8e 5843
3b95a6f9
MR
58442012-02-04 Martin Rudalics <rudalics@gmx.at>
5845
5846 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5847 after rounding frame sizes. (Bug#9723)
5848
d6fa96a6
EZ
58492012-02-04 Eli Zaretskii <eliz@gnu.org>
5850
5851 * keyboard.c (adjust_point_for_property): Don't position point
5852 before BEGV. (Bug#10696)
5853
df0b2940
PE
58542012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 Handle overflow when computing char display width (Bug#9496).
5857 * character.c (char_width): Return EMACS_INT, not int.
5858 (char_width, c_string_width): Check for overflow when
5859 computing the width; this is possible now that individual
5860 characters can have unbounded width. Problem introduced
5861 by merge from Emacs 23 on 2012-01-19.
5862
6bee44d6
MA
58632012-02-02 Michael Albinus <michael.albinus@gmx.de>
5864
5865 * dbusbind.c (Fdbus_register_method): Mention the return value
5866 :ignore in the docstring.
5867
44f92739
GM
58682012-02-02 Glenn Morris <rgm@gnu.org>
5869
1b9f60cc
GM
5870 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5871
44f92739
GM
5872 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5873 Unconditionally set to t. (Bug#10673)
5874 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5875 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5876 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5877
c5d3843c
KH
58782012-02-02 Kenichi Handa <handa@m17n.org>
5879
5880 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5881 0, do not call append_composite_glyph.
5882
159462d4 58832012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5884
5885 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5886 NULL (Bug#6988).
5887 (x_produce_glyphs): If the component of a composition is a null
5888 string, set it->pixel_width to 1 to avoid zero-width glyph.
5889
78cef877
EZ
58902012-02-01 Eli Zaretskii <eliz@gnu.org>
5891
5892 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5893 first 2 arguments are identical. This makes inserting large
5894 output from a subprocess an order of magnitude faster on
5895 MS-Windows, where all sbrk'ed memory is always contiguous.
5896
97897668
GM
58972012-01-31 Glenn Morris <rgm@gnu.org>
5898
5899 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5900 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5901 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5902
31fd3586
GM
59032012-01-29 Glenn Morris <rgm@gnu.org>
5904
5905 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5906
0e24a8b2
CY
59072012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5908
5909 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5910
cc0adcb0
CY
59112012-01-28 Chong Yidong <cyd@gnu.org>
5912
5913 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5914
acc28cb9
CY
59152012-01-26 Chong Yidong <cyd@gnu.org>
5916
9c69cfb7
CY
5917 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5918
acc28cb9
CY
5919 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5920 repeat counts (Bug#10507).
5921
48da7392
GM
59222012-01-26 Glenn Morris <rgm@gnu.org>
5923
5924 * lread.c (syms_of_lread): Doc fix.
5925
14af5f7f
CY
59262012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5927
5928 * coding.c (encode_designation_at_bol): Change return value to
5929 EMACS_INT.
5930
0b21c100
CY
59312012-01-25 Chong Yidong <cyd@gnu.org>
5932
5933 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5934
3c2907f7
CY
59352012-01-21 Chong Yidong <cyd@gnu.org>
5936
5937 * floatfns.c (Fcopysign): Make the second argument non-optional,
5938 since nil is not allowed anyway.
5939
959ad23f
AS
59402012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5941
5942 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5943 (send_process): Likewise.
5944
34a02f46
MR
59452012-01-19 Martin Rudalics <rudalics@gmx.at>
5946
5947 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5948 (Vwindow_persistent_parameters): Do not use Qstate.
5949 Rewrite doc-strings.
34a02f46 5950
1259009a 59512012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5952
5953 * character.c (char_width): New function.
70d4fdf6
GM
5954 (Fchar_width, c_string_width, lisp_string_width):
5955 Use char_width (Bug#9496).
25ed9e61 5956
6a6ee00d
MR
59572012-01-16 Martin Rudalics <rudalics@gmx.at>
5958
5959 * window.c (Vwindow_persistent_parameters): New variable.
5960 (Fset_window_configuration, save_window_save): Handle persistent
5961 window parameters.
5962
c85efaf7
EZ
59632012-01-14 Eli Zaretskii <eliz@gnu.org>
5964
5965 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5966 thrashing the stack of the thread. (Bug#9087)
5967
5944709e
PE
59682012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5971
e71f5d99
EZ
59722012-01-11 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (rows_from_pos_range): Handle the case where the
5975 highlight ends on a newline. (Bug#10464)
5976 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5977 he end column for display of highlight that ends on a newline
5978 before a R2L line.
5979
ce316182
GM
59802012-01-11 Glenn Morris <rgm@gnu.org>
5981
5982 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5983 from load-path also when installation-directory is nil. (Bug#10208)
5984
5b43da69
GM
59852012-01-10 Glenn Morris <rgm@gnu.org>
5986
74cc8ff9
GM
5987 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5988
7d8d6e4e
GM
5989 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5990 Update template values to be closer to their typical values these days.
5b43da69 5991
a0db8d43
EZ
59922012-01-09 Eli Zaretskii <eliz@gnu.org>
5993
5994 * xdisp.c (rows_from_pos_range): Accept additional argument
5995 DISP_STRING, and accept any glyph in a row whose object is that
5996 string as eligible for mouse highlight. Fixes mouse highlight of
5997 display strings from overlays. (Bug#10464)
5998
9a0115ab 59992012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6000
b9110d6a 6001 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6002 * fileio.c (auto_saving_dir_umask): New static var.
6003 (Fmake_directory_internal): Use it.
6004 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6005 creating the directory. The old code temporarily assigns
6006 too-generous permissions to the directory.
6007 (do_auto_save_eh): Clear it.
b9110d6a 6008 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6009 that the var is always cleared.
6010
6c1bd3f3
EZ
60112012-01-07 Eli Zaretskii <eliz@gnu.org>
6012
6013 * search.c (scan_buffer): Pass character positions to
6014 know_region_cache, not byte positions. (Bug#6540)
6015
069d2b50
L
60162012-01-07 LynX <_LynX@bk.ru> (tiny change)
6017
6018 * w32.c (sys_rename): Report EXDEV when rename of a directory
6019 fails because the target is on another logical disk. (Bug#10284)
6020
75bf0d33
DB
60212012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6022
6023 * xterm.c (x_embed_request_focus): New function.
6024
6025 * xterm.h: Add prototype.
6026
6027 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6028
1c6e5a32
GM
60292012-01-05 Glenn Morris <rgm@gnu.org>
6030
6031 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6032
651e947e
EZ
60332012-01-01 Eli Zaretskii <eliz@gnu.org>
6034
6035 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6036 Load gnutls_transport_set_lowat only if GnuTLS version is below
6037 2.11.1.
6038 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6039 GnuTLS versions below 2.11.1.
6040
3778cdd8
AL
60412011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6042
6043 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6044 to the doc string advising against its use for altering the way
6045 windows are scrolled.
6046
0e5317f7
KH
60472011-12-28 Kenichi Handa <handa@m17n.org>
6048
6049 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6050 coding-system ASCII compatible only when it does not produce BOM
6051 on encoding (Bug#10383).
6052
93d5ca1f
JD
60532011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6054
6055 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6056 can scroll.
6057 (create_and_show_popup_menu): Always use menu_position_func for
6058 Gtk3 (Bug#10361).
6059
ca22b785
AS
60602011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6061
6062 * callint.c (Fcall_interactively): Don't truncate prompt string.
6063
d048e1e6
EZ
60642011-12-23 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6067 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6068 resumed from there (after widening). (Bug#10360)
d048e1e6 6069
5ccaba1f
JD
60702011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6071
6072 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6073
204ee57f
JD
60742011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6075
b81d40f0
JB
6076 * nsterm.m (x_free_frame_resources):
6077 Release f->output_data.ns->miniimage.
204ee57f
JD
6078 (ns_index_color): Fix indentation. Do not retain
6079 color_table->colors[i].
6080
6081 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6082 before returning.
6083
6084 * nsfns.m (x_set_background_color): Assign return value from
6085 ns_index_color to face-background instead of NSColor*.
6086 (ns_implicitly_set_icon_type): Fix indentation.
6087 Change assignment in for loop to comparison.
6088
6089 * emacs.c (ns_pool): New variable.
6090 (main): Assign ns_pool.
6091 (Fkill_emacs): Call ns_release_autorelease_pool.
6092
6093 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6094 autorelease fdesc, release fdAttrs and tdict.
6095 (ns_get_covering_families): Release charset.
6096 (ns_findfonts): Release NSFontDescriptor created with new.
6097 (ns_uni_to_glyphs): Fix indentation.
6098 (setString): Release attrStr before assigning new value.
6099
c803b2b7
JD
61002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6101
678f4426
JD
6102 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6103 and NS_IMPL_COCOA.
6104 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6105 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6106
cd394be1 61072011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6108
5fecd5fc
JD
6109 * nsterm.m (ns_term_init): Subscribe for notifications
6110 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6111 to method trackingNotification in EmacsMenu.
6112
6113 * nsmenu.m (trackingMenu): New variable.
3771cb17 6114 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6115 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6116 from Aquamacs (Bug#7030).
678f4426
JD
6117
61182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6119
c803b2b7
JD
6120 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6121 (symbol_to_nsstring): Fix indentation.
6122 (ns_symbol_to_pb): New function.
cae07000
SM
6123 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6124 (Fns_rotate_cut_buffers_internal): Remove.
6125 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6126 Fns_store_cut_buffer_internal.
6127 (ns_get_foreign_selection, Fx_own_selection_internal)
6128 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6129 (Fns_get_selection_internal, Fns_store_selection_internal):
6130 Use ns_symbol_to_pb and check if return value is nil.
6131 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6132 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6133 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6134 renamed to Sns_store_selection_internal.
6135 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6136 and remove this function.
6137 (ns_handle_selection_clear): Remove, never used.
6138 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6139 here.
6140
e1b01a3a
KB
61412011-12-17 Ken Brown <kbrown@cornell.edu>
6142
6143 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6144 GID is unknown (Bug#10257).
6145
2adb6e85
PE
61462011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6149 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6150 which caused a build failure on GNU/Linux IA-64. This problem was
6151 introduced by my 2011-10-07 patch.
6152
d1d7b339
JL
61532011-12-15 Juri Linkov <juri@jurta.org>
6154
6155 * image.c (imagemagick_error): New function. (Bug#10112)
6156 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6157 Use `imagemagick_error' where ImageMagick functions return
6158 `MagickFalse'.
6159 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6160 proper order.
6161
100d5755
KH
61622011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6163
6164 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6165 fill background (Bug#8992).
6166
454592a6
MR
61672011-12-13 Martin Rudalics <rudalics@gmx.at>
6168
6169 * window.c (Vwindow_combination_resize)
6170 (Vwindow_combination_limit): Use t instead of non-nil in
6171 doc-strings.
61d4b438
MR
6172 (Vrecenter_redisplay): Add first sentence of doc-string on
6173 separate line.
53524d93 6174 (Frecenter): Fix doc-string typo.
454592a6 6175
3633e3aa
KH
61762011-12-11 Kenichi Handa <handa@m17n.org>
6177
6178 * coding.c (Funencodable_char_position): Pay attention to the
6179 buffer text relocation (Bug#9389).
6180
7b9d523a 61812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6182
7b9d523a
JD
6183 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6184 gtk_init (Bug#10100).
6185
b73189c6
EZ
61862011-12-10 Eli Zaretskii <eliz@gnu.org>
6187
6188 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6189 IT->string is nil. (Bug#10263)
6190
f7dfe5d6
JD
61912011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6192
83faebb4
JD
6193 * nsterm.h (x_free_frame_resources): Declare.
6194
f7dfe5d6
JD
6195 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6196 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6197
6198 * nsterm.h (ns_get_defaults_value): Declare.
6199
6200 * nsterm.m (ns_default): Call ns_get_defaults_value.
6201
7cd4e72c
EZ
62022011-12-09 Eli Zaretskii <eliz@gnu.org>
6203
6204 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6205 (Bug#10170)
6206
b34d7317
YM
62072011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6208
6209 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6210 that where the value of an _OBJC_* symbol points to is in the .bss
6211 section (Bug#10240).
6212
76470ad1
KH
62132011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6214
6215 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6216 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6217
745fff94
KH
62182011-12-08 Kenichi Handa <handa@m17n.org>
6219
6220 * ftfont.c (get_adstyle_property): Fix previous change
6221 (Bug#10233).
6222
6e44397c
JB
62232011-12-07 Juanma Barranquero <lekktu@gmail.com>
6224
6225 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6226 dirs from the default value of EMACSLOADPATH (bug#10208).
6227
7efa6272
GM
62282011-12-07 Glenn Morris <rgm@gnu.org>
6229
6230 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6231 installation and source directories as well. (Bug#10208)
6232
f6fc4d87
CY
62332011-12-06 Chong Yidong <cyd@gnu.org>
6234
6235 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6236
2bf26180
GM
62372011-12-06 Glenn Morris <rgm@gnu.org>
6238
6239 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6240 as an error, not just -1. (Bug#10217)
6241
3a6ad4f0
CY
62422011-12-05 Chong Yidong <cyd@gnu.org>
6243
6244 * keyboard.c (process_special_events): New function.
6245 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6246
75a3b399
PE
62472011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6248
6249 * coding.c (encode_designation_at_bol): Don't use uninitialized
6250 local variable (Bug#9318).
6251
c3c9e25e
KH
62522011-12-05 Kenichi Handa <handa@m17n.org>
6253
6254 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6255 return Qnil (Bug#8046, Bug#10193).
6256
5eb05ea3
KH
62572011-12-05 Kenichi Handa <handa@m17n.org>
6258
6259 * coding.c (encode_designation_at_bol): New args charbuf_end and
6260 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6261 (coding_set_source): Return how many bytes coding->source was
6262 relocated.
6263 (coding_set_destination): Return how many bytes
6264 coding->destination was relocated.
6265 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6266 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6267
62682011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6269
6270 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6271 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6272 macro (Bug#9318).
6273
62742011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6275
6276 The following changes are to fix Bug#9318.
6277
a79703f5 6278 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6279 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6280 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6281 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6282
7dbda6df
JB
62832011-12-05 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * lisp.h (process_quit_flag): Fix external declaration.
6286
6d5eb5b0
SM
62872011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6288
6289 Don't macro-inline non-performance-critical code.
6290 * eval.c (process_quit_flag): New function.
6291 * lisp.h (QUIT): Use it.
6292
a0c3fad0
JD
62932011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6294
6295 * nsfns.m (get_geometry_from_preferences): New function.
6296 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6297
6c07aac2
AS
62982011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6299
6300 * emacs.c (Qkill_emacs): Define.
6301 (syms_of_emacs): Initialize it.
6302 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6303 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6304 (quit_throw_to_read_char): Add parameter `from_signal'.
6305 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6306 * lisp.h (QUIT): Call Fkill_emacs if requested.
6307
c052ead4
JD
63082011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6309
6310 * widget.c (update_wm_hints): Return if wmshell is null.
6311 (widget_update_wm_size_hints): New function.
6312
6313 * widget.h (widget_update_wm_size_hints): Declare.
6314
6315 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6316 widget_update_wm_size_hints (Bug#10104).
6317
9e49252b
EZ
63182011-12-03 Eli Zaretskii <eliz@gnu.org>
6319
6320 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6321 before a newline, prepare the bidi iterator for consuming the
6322 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6323 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6324
02b16839
JL
63252011-12-02 Juri Linkov <juri@jurta.org>
6326
6327 * search.c (Fword_search_regexp): New Lisp function created from
6328 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6329 (Fword_search_backward, Fword_search_forward)
6330 (Fword_search_backward_lax, Fword_search_forward_lax):
6331 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6332 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6333
0068070e
SM
63342011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6335
6336 * fileio.c (Finsert_file_contents): Move after-change-function call
6337 to before the "handled:" label, since all "goto handled" appear in
6338 cases where the *-change-functions have already been properly called
6339 (bug#10117).
6340
3360a3fc
AS
63412011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6342
6343 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6344 waiting for input. (Bug#10169)
6345
73d6c093
EZ
63462011-11-30 Eli Zaretskii <eliz@gnu.org>
6347
6348 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6349 verifies glyph row's hash code--we have just reallocated the
6350 glyphs, so their contents can be complete garbage. (Bug#10164)
6351
febe6bea
JB
63522011-11-30 Juanma Barranquero <lekktu@gmail.com>
6353
6354 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6355
801a4313
EZ
63562011-11-30 Eli Zaretskii <eliz@gnu.org>
6357
6358 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6359 attributes are tested _before_ calling verify_row_hash, to protect
6360 against GCC re-ordering of the tests. (Bug#10164)
6361
2b56b87e
JD
63622011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6363
6364 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6365
6366 * xterm.c (handle_one_xevent): Only set async_visible and friends
6367 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6368 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6369 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6370
dbf31225
PE
63712011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6372
6373 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6374 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6375 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6376 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6377 All uses changed to use GCPRO1 etc.
6378 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6379 Revert to old implementation (i.e., before 2011-03-11).
6380
1305621b
YM
63812011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6382
6383 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6384 of scroll runs so as to avoid assigning disabled bogus rows and
6385 unnecessary graphics copy operations.
6386
8c9afb46
EZ
63872011-11-27 Eli Zaretskii <eliz@gnu.org>
6388
6389 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6390 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6391 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6392 (malloc, free, realloc, calloc): Redirect to e_* only when
6393 compiling Emacs.
6394
6395 * lisp.h (GCTYPEBITS): Move before first use.
6396 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6397 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6398 this macro definition.
6399
6400 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6401 _MSC_VER.
6402
54e9e3bf
JD
64032011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6404
6d5eb5b0
SM
6405 * gtkutil.c (xg_create_frame_widgets):
6406 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6407 present with Gtk+ 2.0.
6408
83aca1cb
PE
64092011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6410
6411 * fileio.c (Finsert_file_contents): Undo previous change; see
6412 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6413
5b76caa4
PE
64142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 Rename locals to avoid shadowing.
6417 * fileio.c (Finsert_file_contents):
6418 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6419 * process.c (wait_reading_process_output):
6420 Rename inner 'proc' to 'p' to avoid shadowing.
6421 Indent for consistency with usual Emacs style.
6422
8c535114
EZ
64232011-11-25 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (redisplay_window): If cursor row is not fully visible
6426 after recentering, and scroll-conservatively is set to a large
6427 number, scroll window by a few more lines to make the cursor fully
6428 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6429 (start_display): Don't move to the next line if the display should
6430 start at a newline that is part of a display vector or an overlay
6431 string. (Bug#10119)
8c535114 6432
fa4fdb5c
JL
64332011-11-24 Juri Linkov <juri@jurta.org>
6434
6435 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6436 after the `MagickPingImage' call. (Bug#10112)
6437
90ec88df
CY
64382011-11-23 Chong Yidong <cyd@gnu.org>
6439
6440 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6441
56e2e794
MR
64422011-11-23 Martin Rudalics <rudalics@gmx.at>
6443
6444 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6445 making another buffer current. (Bug#10114)
6446
b6e64c41
GM
64472011-11-23 Glenn Morris <rgm@gnu.org>
6448
6449 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6450
6b21de18
CY
64512011-11-23 Chong Yidong <cyd@gnu.org>
6452
6453 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6454 using it (Bug#5984).
6455
b12cd789
EZ
64562011-11-22 Eli Zaretskii <eliz@gnu.org>
6457
6458 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6459 and header-lines, as they don't have one computed for them.
6460 (Bug#10098)
6461
6462 * .gdbinit (prow): Make displayed values more self-explaining.
6463 Add row's hash code.
6464
261b6fd4
LMI
64652011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
6467 * process.c (wait_reading_process_output): Fix asynchrounous
6468 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6469 (wait_reading_process_output): Add comment and URL.
261b6fd4 6470
e7cfd277
JD
64712011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6472
6473 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6474
a9b9b7f5
CY
64752011-11-21 Chong Yidong <cyd@gnu.org>
6476
6477 * window.c (Fnext_window, Fprevious_window): Doc fix.
6478
b0d15b4f
SM
64792011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6480
6481 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6482
fe7a3057
JB
64832011-11-20 Juanma Barranquero <lekktu@gmail.com>
6484
6485 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6486
d2999b1a
MR
64872011-11-20 Martin Rudalics <rudalics@gmx.at>
6488
6489 * window.c (Fset_window_combination_limit): Rename argument
6490 STATUS to LIMIT.
6491 (Vwindow_combination_limit): Remove "status" from doc-string.
6492
d5ff9cd0
AS
64932011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6494
6495 * m/ibms390.h: Remove.
6496 * m/ibms390x.h: Don't include "ibms390.h".
6497
a5bb9bd3
SM
64982011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6499
6500 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6501 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6502
cd1181db
JB
65032011-11-20 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * casetab.c (Fset_case_table):
6506 * charset.c (Fcharset_after): Fix typos.
6507
615a3b8d 65082011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6509
17e845af
PE
6510 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6511 Otherwise, valgrind does not work on some platforms.
6512 Problem reported by Andreas Schwab in
6a0bf43d
PE
6513 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6514 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6515 is set, removing the need for VIRT_ADDRESS_VARIES.
6516 (PURE_P): Use a more-efficient implementation that needs just one
6517 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6518 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6519 to 4 (xorl, subq, cmpq, setbe).
6520 * alloc.c (pure): Always extern now, since that's the
6521 VIRT_ADDR_VARIES behavior.
6522 (PURE_POINTER_P): Use a single comparison, not two, for
6523 consistency with the new puresize.h.
6524 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6525 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6526 Remove VIRT_ADDR_VARIES no longer needed.
6527
f8fe6f96
EZ
65282011-11-19 Eli Zaretskii <eliz@gnu.org>
6529
6530 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6531 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6532 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6533 behave as if the cursor position were at the window margin.
6534
6535 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6536 and the cursor position is out of bounds, behave as if the cursor
6537 position were at the window margin. (Bug#10075)
6538
df05a53c
CY
65392011-11-18 Chong Yidong <cyd@gnu.org>
6540
6541 * window.c (Fwindow_combination_limit): Make first argument
6542 non-optional, since it is meaningless for live windows like the
6543 selected window.
61ccba97 6544
2071918e
DA
65452011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6546
6547 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6548
b50a28de
SM
65492011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6550
6551 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6552 (graft_intervals_into_buffer): Simplify.
6553
015137db
EZ
65542011-11-18 Eli Zaretskii <eliz@gnu.org>
6555
6556 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6557 hash values of the two rows.
6558 (copy_row_except_pointers): Preserve the used[] arrays and the
6559 hash values of the two rows. (Bug#10035)
68c95424 6560 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6561
6562 * xdisp.c (row_hash): New function, body extracted from
6563 compute_line_metrics.
6564 (compute_line_metrics): Call row_hash, instead of computing the
6565 hash code inline.
6566
6567 * dispnew.c (verify_row_hash): Call row_hash for computing the
6568 hash code of a row, instead of duplicating code from xdisp.c.
6569
6570 * dispextern.h (row_hash): Add prototype.
6571
a2addb04
TH
65722011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6573
6574 * frame.c (delete_frame): Don't delete the terminal when the last
6575 X frame is closed if emacs is built with GTK toolkit.
6576
df85d315
JB
65772011-11-17 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6580
a0c2d0ae
MR
65812011-11-17 Martin Rudalics <rudalics@gmx.at>
6582
6583 * window.c (Vwindow_splits): Rename to
6584 Vwindow_combination_resize. Suggested by Juri Linkov.
6585 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6586 of Vwindow_splits.
6587
58179cce
JB
65882011-11-16 Juanma Barranquero <lekktu@gmail.com>
6589
7877f373
JB
6590 * nsfns.m (Fns_font_name):
6591 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6592
b6f67890
MR
65932011-11-16 Martin Rudalics <rudalics@gmx.at>
6594
6595 * window.h (window): Rename slot "nest" to "combination_limit".
6596 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6597 (Fset_window_nest): Rename to Fset_window_combination_limit.
6598 (Vwindow_nest): Rename to Vwindow_combination_limit.
6599 (recombine_windows, make_parent_window, make_window)
6600 (Fsplit_window_internal, saved_window)
6601 (Fset_window_configuration, save_window_save): Rename all
6602 occurrences of window_nest to window_combination_limit.
6603
c7015153
JB
66042011-11-15 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * image.c (imagemagick_load_image): Fix typo.
6607
322ad6ec
EZ
66082011-11-14 Eli Zaretskii <eliz@gnu.org>
6609
6610 * xdisp.c (display_line): Move the call to
6611 highlight_trailing_whitespace before the call to
6612 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6613 faces of all the glyphs to compute ROW's hash value.
6614 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6615
f067b8ec
JB
66162011-11-14 Juanma Barranquero <lekktu@gmail.com>
6617
6618 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6619 just return (bug#10044).
6620
1e5b2111
EZ
66212011-11-12 Eli Zaretskii <eliz@gnu.org>
6622
7ef3cbd5
EZ
6623 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6624 with user-defined heap size. Bump the default size of the temacs
6625 heap to 27MB, to avoid memory warning when running temacs.
6626 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6627
1e5b2111
EZ
6628 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6629 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6630 (verify_row_hash) [XASSERTS]: New function.
6631 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6632 that the hash value of glyph rows is correct.
1e5b2111 6633
89d61221
MR
66342011-11-12 Martin Rudalics <rudalics@gmx.at>
6635
6636 * window.h (window): Remove splits slot.
6637 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6638 (Fdelete_other_windows_internal, make_parent_window)
6639 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6640 (Fset_window_configuration, save_window_save): Don't deal with
6641 split status of windows.
6642 (saved_window): Remove splits slot.
6643 (Vwindow_splits): Rewrite doc-string.
6644
97f18cc8
JD
66452011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6646
6647 * xfns.c (unwind_create_frame):
6648 * nsfns.m (unwind_create_frame):
6649 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6650 Vframe_list (Bug#9999).
6651
22a648b4
DA
66522011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6653
0b381c7e 6654 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6655
659afede
KH
66562011-11-11 Kenichi Handa <handa@m17n.org>
6657
6658 * callproc.c (Fcall_process): Set the member dst_multibyte of
6659 process_coding.
6660
9ac0394b
KH
66612011-11-11 Johan Bockgård <bojohan@gnu.org>
6662
6663 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6664 avoid a crash (bug#9496).
6665
2fbdc249
CY
66662011-11-09 Chong Yidong <cyd@gnu.org>
6667
6668 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6669 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6670
ac6b1f81
PE
66712011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6672
6673 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6674
09db192c
PE
66752011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 Avoid some portability problems by eschewing 'extern inline' functions.
6678 The trivial performance wins aren't worth the portability hassles; see
6679 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6680 et seq.
6681 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6682 (window_box_width, window_box_left, window_box_left_offset)
6683 (window_box_right, window_box_right_offset): Undo previous change,
6684 by removing the "extern"s.
6685 * intervals.c (adjust_intervals_for_insertion)
6686 (adjust_intervals_for_deletion): Undo previous change,
6687 making these static again.
6688 (offset_intervals, temp_set_point_both, temp_set_point)
6689 (copy_intervals_to_string): No longer inline.
6690 * xdisp.c (window_text_bottom_y, window_box_width)
6691 (window_box_height, window_box_left_offset)
6692 (window_box_right_offset, window_box_left, window_box_right)
6693 (window_box): No longer inline.
6694
105216ed
CY
66952011-11-08 Chong Yidong <cyd@gnu.org>
6696
6697 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6698 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6699 Signal an error if not a live window.
105216ed
CY
6700 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6701 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6702
ae9e237f
JB
67032011-11-07 Juanma Barranquero <lekktu@gmail.com>
6704
6705 * lisp.h (syms_of_abbrev): Remove declaration.
6706 Reported by CHENG Gao <chenggao@royau.me>.
6707
c7aa8333
EZ
67082011-11-07 Eli Zaretskii <eliz@gnu.org>
6709
6710 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6711 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6712 of temacs in GUI mode.
6713
be7f5545
MR
67142011-11-07 Martin Rudalics <rudalics@gmx.at>
6715
6716 * window.h: Declare delete_all_child_windows instead of
6717 delete_all_subwindows.
6718 * window.c (Fwindow_nest, Fset_window_nest)
6719 (Fset_window_new_total, Fset_window_new_normal)
6720 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6721 (delete_all_subwindows): Rename to delete_all_child_windows.
6722 (Fdelete_other_windows_internal, Fset_window_configuration):
6723 Call delete_all_child_windows instead of delete_all_subwindows.
6724 * frame.c (delete_frame): Call delete_all_child_windows instead
6725 of delete_all_subwindows.
6726
ca78dc43
PE
67272011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6728
6729 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6730 This is also needed for porting to any host where GC_MARK_STACK is
6731 not GC_MAKE_GCPROS_NOOPS.
6732 (which_symbols): Use it.
6733
a0241d01
KH
67342011-11-07 Kenichi Handa <handa@m17n.org>
6735
6736 * coding.c (coding_set_destination): Check coding->src_pos only
6737 when coding->src_object is a buffer (bug#9910).
6738
6739 * process.c (send_process): Set the member src_multibyte of coding
6740 to 0 (bug#9911) when sending a unibyte text.
6741
6742 * callproc.c (Fcall_process): Set the member src_multibyte of
6743 process_coding to 0 (bug#9912).
6744
a64bfdfa 67452011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6746
6747 * xmenu.c (cleanup_widget_value_tree): New function.
6748 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6749 calling free_menubar_widget_value_tree directly (Bug#9830).
6750
cb41b32a
PE
67512011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6752
6753 Fix some portability problems with 'inline'.
6754 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6755 (window_box_width, window_box_left, window_box_left_offset)
6756 (window_box_right, window_box_right_offset): Declare extern.
6757 Otherwise, these inline functions do not conform to C99 and
6758 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6759 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6760 * intervals.c (adjust_intervals_for_insertion)
6761 (adjust_intervals_for_deletion): Now extern, because otherwise the
6762 extern inline functions 'offset_intervals' couldn't refer to it.
6763 (static_offset_intervals): Remove.
6764 (offset_intervals): Rewrite using the old contents of
6765 static_offset_intervals. The old version didn't conform to C99
6766 because an extern inline function contained a reference to an
6767 identifier with static linkage.
6768
b7041366
AS
67692011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6770
6771 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6772 GC.
6773
88a37c4d
EZ
67742011-11-06 Eli Zaretskii <eliz@gnu.org>
6775
6776 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6777 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6778 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6779 return Qleft_to_right.
6780
49745b39
CY
67812011-11-06 Chong Yidong <cyd@gnu.org>
6782
6783 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6784 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6785 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6786 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6787 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6788 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6789 (Fwindow_vscroll): Doc fix.
6790 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6791 argument, since it makes no sense to pass a live window and for
6792 consistency with window-child.
6793
1f05cd82
CS
67942011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6795
6796 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6797 support MSVC.
6798
22610910
JR
67992011-11-05 Jason Rumney <jasonr@gnu.org>
6800
6801 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6802 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6803 fonts (Bug#6029).
6804 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6805 bitwise arithmetic preventing use of unicode-sip and non-truetype
6806 opentype fonts.
6807
a06776b2
EZ
68082011-11-05 Eli Zaretskii <eliz@gnu.org>
6809
3ad924ba
EZ
6810 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6811 "emacs"-only part.
6812
a06776b2
EZ
6813 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6814 initialization code to keep similarity to xfns.c after changes
6815 from 2011-11-05.
6816
c9e7db78
JD
68172011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6818
a97f8f3f
JD
6819 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6820 (unwind_create_frame): New function (Bug#9943).
6821 (Fx_create_frame): Restructure code to be more similar to the one in
6822 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6823 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6824 Move terminal->reference_count++ just before making the frame official
6825 (Bug#9943).
6826
6827 * nsterm.m (x_free_frame_resources): New function.
6828 (x_destroy_window): Move code to x_free_frame_resources.
6829
c9e7db78 6830 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6831 (Fx_create_frame, x_create_tip_frame):
6832 Move terminal->reference_count++ just before making the frame
75f1671a 6833 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6834 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6835
a6fc3b5c
EZ
68362011-11-05 Eli Zaretskii <eliz@gnu.org>
6837
6838 Support MSVC build with newer versions of Visual Studio.
6839 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6840 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6841 nt/gmake.defs.
6842
6843 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6844 which are not supported by MSVC.
6845 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6846 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6847 bitfields.
6848 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6849 types in bitfields.
6850 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6851
6852 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6853
58179cce 68542011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6855
6856 Support MSVC build with newer versions of Visual Studio.
6857 * w32.c: Don't include w32api.h for MSVC.
6858 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6859
6860 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6861 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6862 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6863 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6864 e_* cousins.
6865 (alloca) [_MSC_VER]: Define to _alloca.
6866
6867 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6868
6869 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6870
a58c13ed
EZ
68712011-11-04 Eli Zaretskii <eliz@gnu.org>
6872
6873 * xdisp.c (note_mouse_highlight): If either of
6874 previous/next-single-property-change returns nil, treat that as
6875 the beginning or the end of the buffer. (Bug#9955)
6876
fe0b6370
JD
68772011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6878
a58c13ed 6879 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6880 label is not null (Bug#9951).
6881 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6882 may be NULL.
6883
89bd5ee1
EZ
68842011-11-04 Eli Zaretskii <eliz@gnu.org>
6885
6886 * window.c (Fwindow_body_size): Mention in the doc string that the
6887 return value is in frame's canonical units. (Bug#9949)
6888
84c3edb9
EZ
68892011-11-03 Eli Zaretskii <eliz@gnu.org>
6890
4e2fb5c7
EZ
6891 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6892
84c3edb9 6893 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6894 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6895 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6896
bc17a887
EZ
68972011-11-01 Eli Zaretskii <eliz@gnu.org>
6898
6899 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6900 Don't stop backward scan on the continuation glyph, even though
6901 its CHARPOS is positive.
6d5eb5b0
SM
6902 (mouse_face_from_buffer_pos, note_mouse_highlight):
6903 Rename cover_string to disp_string.
bc17a887 6904
4ee88440
MR
69052011-11-01 Martin Rudalics <rudalics@gmx.at>
6906
6907 * window.c (temp_output_buffer_show): Don't use
6908 Vtemp_buffer_show_specifiers.
6909 (Vtemp_buffer_show_specifiers): Remove unused variable.
6910
c2ff3c02
EZ
69112011-10-30 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6914 past the beginning of the current glyph matrix.
6915
58179cce 69162011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6917
6918 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6919 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6920 HAVE_GTK3 (Bug#9869).
b77a6a7f 6921
3b574623
JD
6922 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6923 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6924
b77a6a7f
JD
6925 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6926
6927 * xterm.c: Declare x_handle_net_wm_state to return int.
6928 (handle_one_xevent): Check if we are iconified but don't have
6929 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6930 (get_current_wm_state): Return non-zero if not hidden,
6931 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6932 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6933 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6934 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6935
196e41e4
PE
69362011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6939 so that this new function doesn't get optimized away by a
6940 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6941
021f2e1a
AS
69422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6943
6944 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6945
8b058d44
EZ
69462011-10-29 Eli Zaretskii <eliz@gnu.org>
6947
6948 Fix the `xbytecode' command.
6949 * .gdbinit (xprintbytestr): New command.
b50a28de 6950 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6951 (xbytecode): Print the byte-code string as well.
6952
4452fb80
EZ
69532011-10-29 Kim Storm <storm@cua.dk>
6954
8b058d44
EZ
6955 * alloc.c (which_symbols): New function.
6956
21b72067
AS
69572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6958
6959 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6960 line. (Bug#9903)
6961
83ed7b5c
GM
69622011-10-29 Glenn Morris <rgm@gnu.org>
6963
6964 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6965 Not clear what it was for, and it causes various bugs. (Bug#9839)
6966
5a7a728b
EZ
69672011-10-28 Eli Zaretskii <eliz@gnu.org>
6968
6969 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6970 possible random value that matches one of those tested as
6971 condition to clear the mouse face.
6972
d3d0842f
CY
69732011-10-28 Chong Yidong <cyd@gnu.org>
6974
6975 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6976
31b39d13
DN
69772011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6978
6979 * window.c (make_window): Initialize phys_cursor_on_p.
6980
9aba6043
SM
69812011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6982
6983 * lisp.h (struct Lisp_Symbol): Update comments.
6984
c20992f4
JB
69852011-10-28 Juanma Barranquero <lekktu@gmail.com>
6986
6987 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6988
db4f02f2
EZ
69892011-10-28 Eli Zaretskii <eliz@gnu.org>
6990
6991 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6992 <oslsachem@gmail.com> for helping to debug this.
6993
6994 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6995 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6996 (g_b_init_get_glyph_outline_w): New static variables.
6997 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6998 (GetGlyphOutlineW_Proc): New typedefs.
6999 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7000 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7001 New functions.
7002 (w32font_open_internal, compute_metrics):
7003 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7004 instead of calling the "wide" APIs directly.
7005
7006 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7007
7008 * w32.h (syms_of_w32font): Add prototype.
7009
87e68db4
JB
70102011-10-27 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7013 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7014 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7015 (Fmove_to_window_line): Doc fix.
7016
435c1d67
CY
70172011-10-27 Chong Yidong <cyd@gnu.org>
7018
7019 * process.c (make_process): Set gnutls_state to NULL.
7020
7021 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7022 non-NULL, regardless of GNUTLS_INITSTAGE.
7023 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7024 an error. Set process slots as soon as we allocate them.
7025
7026 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7027
9c6c6f49
CY
70282011-10-27 Chong Yidong <cyd@gnu.org>
7029
9aba6043
SM
7030 * gnutls.c (emacs_gnutls_deinit): New function.
7031 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7032 (Fgnutls_deinit, Fgnutls_boot): Use it.
7033
7034 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7035 (deactivate_process): Call emacs_gnutls_deinit.
7036
657d08d3
JB
70372011-10-27 Juanma Barranquero <lekktu@gmail.com>
7038
7039 * image.c (x_create_x_image_and_pixmap):
7040 * w32.c (sys_rename, w32_delayed_load):
7041 * w32font.c (fill_in_logfont):
7042 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7043
5430d399
JB
70442011-10-26 Juanma Barranquero <lekktu@gmail.com>
7045
7046 * w32fns.c (w32_default_color_map): New function,
7047 extracted from Fw32_default_color_map.
a7ef684b 7048 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7049
fe0055fa
PE
70502011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7051
7052 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7053
e6346438
SM
70542011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7055
7056 * keyboard.c (test_undefined): New function (bug#9751).
7057 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7058
e112cc37
ET
70592011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7060
7061 * sysdep.c (init_sys_modes): Fix the check for the controlling
7062 terminal (Bug#6649).
7063
7b5d6677
EZ
70642011-10-20 Eli Zaretskii <eliz@gnu.org>
7065
7066 * dispextern.h (struct bidi_it): New member next_en_type.
7067
7068 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7069 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7070 current character, check also for next_en_type being WEAK_EN.
7071 (bidi_resolve_weak): Don't enter the expensive loop if the current
7072 position is before next_en_pos. Record the bidi type of the first
7073 non-ET, non-BN character we find, in addition to its position.
7074 (bidi_level_of_next_char): Invalidate next_en_type when
7075 next_en_pos is over-stepped.
7076
7da0b018
PE
70772011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7078
7079 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7080 * editfns.c: Rewrite current-time-zone so that it invokes
7081 the equivalent of (format-time-string "%Z") to get the time zone name.
7082 This fixes a bug when the time zone name contains characters that
7083 need converting from the system time locale to Emacs internal format.
7084 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7085 that patch fixed format-time-string to do the conversion, but
7086 I forgot to fix current-time-zone.
7087 (format_time_string): New function, containing most of
7088 what Fformat_time_string used to contain.
7089 (Fformat_time_string): Rewrite in terms of format_time_string.
7090 This doesn't change this function's behavior.
7091 (current-time-zone): Rewrite to use format_time_string.
7092 This fixes the bug reported by Michael Schierl in
7093 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7094 Jason Rumney's 2007-06-07 change worked around this bug, but
7095 didn't fix it.
7096 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7097
8547b010
EZ
70982011-10-19 Eli Zaretskii <eliz@gnu.org>
7099
7100 * xdisp.c (start_display): If the character at POS is displayed
7101 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7102 (try_window_reusing_current_matrix): If a line ends in a display
7103 vector or the next line starts in a display vector, continue
7104 redrawing the window even though the character position of
7105 start_row was reached.
8547b010
EZ
7106 (Bug#9771, part 2)
7107
4e948d15
CY
71082011-10-18 Chong Yidong <cyd@gnu.org>
7109
7110 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7111 with nobreak-char-display too.
7112
4787455f
EZ
71132011-10-18 Eli Zaretskii <eliz@gnu.org>
7114
7115 Fix part 3 of bug#9771.
7116 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7117 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7118 non-neutral characters if the current character is a paragraph
7119 separator (a.k.a. Newline). This avoids running the same
7120 expensive loop twice, once when we consume the preceding newline
7121 and the other time when the line actually needs to be displayed.
7122 Avoid the loop when we see neutrals on the base embedding level
7123 following a character whose directionality is the same as the
7124 paragraph's. This avoids running the expensive loop when a line
7125 ends in a long sequence of neutrals, like control characters.
7126 Add assertion against STRONG_AL type. Slightly rearrange code
7127 that determines the type of a neutral given the first non-neutral
7128 that follows it.
7129 (bidi_level_of_next_char): Set next_en_pos to zero when
7130 invalidating its info.
7131
2c91f553
EZ
71322011-10-17 Eli Zaretskii <eliz@gnu.org>
7133
7134 * xdisp.c (push_display_prop): Determine whether to record string
7135 or buffer position by IT->string, not by IT->method. Allow
7136 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7137 (move_it_vertically_backward): Don't look for character position
7138 immediately after the newline when in a continuation line.
7139 (Bug#9771, part 1)
2c91f553 7140
c7b08b0d
MR
71412011-10-15 Martin Rudalics <rudalics@gmx.at>
7142
7143 * window.c (coordinates_in_window): Rewrite and delabelize
7144 vertical border check. (Bug#5357) (Bug#9618)
7145
6b02f655
SM
71462011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7147
7148 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7149 errors in XSetWindowBorder (bug#9310).
7150
81d40c92
DA
71512011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7152
7153 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7154 avoid crash when xmalloc overrun checking is enabled.
7155
d4172c3b
EZ
71562011-10-13 Eli Zaretskii <eliz@gnu.org>
7157
7158 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7159 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7160 cursor motion with <left> and <right> arrow keys.
7161
7162 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7163 some callers set that themselves.
7164
b00eea75
EZ
71652011-10-12 Eli Zaretskii <eliz@gnu.org>
7166
7167 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7168 display string and the previous row comes from the same string and
7169 is empty. (Bug#9739) (Bug#9738)
7170
8fe012c4
SM
71712011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7172
7173 * doc.c (get_doc_string): Encode file name (bug#9735).
7174
0074aef2
EZ
71752011-10-12 Eli Zaretskii <eliz@gnu.org>
7176
79beb178
EZ
7177 * bidi.c (bidi_level_of_next_char):
7178 * xdisp.c (get_visually_first_element): Remove old incorrect
7179 comments regarding the Unicode Line Separator character.
7180
0074aef2
EZ
7181 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7182
6e4b3fbe
DA
71832011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7184
7185 * alloc.c (Fgc_status): Do not access beyond zombies array
7186 boundary if nzombies > MAX_ZOMBIES.
7187 * alloc.c (dump_zombies): Add missing format specifier.
7188
0324f3af
PE
71892011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7190
b5525cac
PE
7191 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7192 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7193
0324f3af
PE
7194 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7195 Some packages use them to denote characters with modifiers.
7196
e9b5f888
AS
71972011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7198
7199 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7200 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7201 matching a pp-number. Rename parameter var to var1.
7202
127827c0
SM
72032011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7204
7205 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7206
c8fd3bd0
GM
72072011-10-08 Glenn Morris <rgm@gnu.org>
7208
7209 * callint.c (Fcall_interactively): Give a more explicit error for the
7210 'c' case with a non-character input. (Bug#8479)
7211
352ec8ff
EZ
72122011-10-08 Eli Zaretskii <eliz@gnu.org>
7213
03669ccb
EZ
7214 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7215 lines.
7061c986
EZ
7216 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7217 lines that are hscrolled on the left.
03669ccb 7218
352ec8ff
EZ
7219 * dispnew.c (buffer_posn_from_coords): Account for a possible
7220 presence of header-line. (Bug#4426)
7221
a66cfb1c
SM
72222011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7223
6b02f655
SM
7224 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7225 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7226
7c5ee88e
PE
72272011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7230 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7231 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7232 this makes Emacs dump core during garbage collection on rare
7233 occasions. sizeof is obviously inferior to offsetof here, so
7234 stick with offsetof.
7235 (GC_POINTER_ALIGNMENT): New macro.
7236 (mark_memory): Omit 3rd (offset) arg; caller changed.
7237 Don't assume EMACS_INT alignment is the same as pointer alignment.
7238
df1bbe5b
SM
72392011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * keyboard.c (read_key_sequence_remapped): New var.
7242 (read_key_sequence): Compute remapping in the right buffer.
7243 (command_loop_1): Use read_key_sequence's remapping directly.
7244
51553db6
SM
72452011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7246
32c1fffd
SM
7247 * dired.c (file_name_completion): Don't expand file name.
7248 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7249 before checking file name handler.
7250
51553db6
SM
7251 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7252 they've been requested explicitly (bug#9591).
7253
b6bd1599 72542011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7255
7256 * keymap.c (Fsingle_key_description): Use make_specified_string
7257 instead of build_string to build string from push_key_description.
7258 (Bug#5193)
7259
f701dc2a
PE
72602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7261
4222c55d
PE
7262 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7263 This fixes a Y2038 bug on 64-bit hosts.
7264 * buffer.c (reset_buffer):
7265 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7266 (Fclear_buffer_auto_save_failure):
7267 Use 0, not -1, to represent an unset failure time, since time_t
7268 might not be signed.
7269
f701dc2a
PE
7270 Remove dependency on glibc malloc internals.
7271 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7272 Move back here from lisp.h, but with their new implementations.
7273 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7274 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7275 * charset.c (charset_table_init): New static var.
7276 (syms_of_charset): Use it instead of xmalloc. This removes a
7277 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7278 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7279 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7280 Move back to alloc.c.
7281 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7282 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7283
9ceebf39
JD
72842011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7285
7286 * nsterm.m (windowDidResize): Call x_set_window_size only when
7287 ns_in_resize is true. Otherwise set pixelwidth/height and
7288 call change_frame_size (Bug#9628).
7289
cb993c58
PE
72902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7291
3930c88b
PE
7292 Port --enable-checking=all to Fedora 14 x86-64.
7293 * charset.c (syms_of_charset): Also account for glibc malloc's
7294 internal overhead when calculating the initial malloc maximum.
7295
cb993c58
PE
7296 Port --enable-checking=all to Fedora 14 x86.
7297 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7298 Move to lisp.h.
7299 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7300 (overrun_check_realloc, overrun_check_free):
7301 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7302 That way, xmalloc returns a properly-aligned pointer even if
7303 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7304 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7305 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7306 into account when calculating the initial malloc maximum.
7307 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7308 Move here from alloc.c, so that charset.c can use it too.
7309 Properly align; the old code wasn't right for common 32-bit hosts
7310 when configured with --enable-checking=all.
7311 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7312 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7313
31bed486
EZ
73142011-09-29 Eli Zaretskii <eliz@gnu.org>
7315
04c70788 7316 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7317 use EDOM.
7318
fbcaa2f3
EZ
73192011-09-28 Eli Zaretskii <eliz@gnu.org>
7320
7321 * xdisp.c (compute_display_string_end): If there's no display
7322 string at CHARPOS, return -1.
7323
7324 * bidi.c (bidi_fetch_char): When compute_display_string_end
7325 returns a negative value, treat the character as a normal
7326 character not covered by a display string. (Bug#9624)
7327
a239d4e9
JB
73282011-09-28 Juanma Barranquero <lekktu@gmail.com>
7329
7330 * lread.c (Fread_from_string): Fix typo in docstring.
7331
88652fd5
EZ
73322011-09-27 Eli Zaretskii <eliz@gnu.org>
7333
7334 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7335 newline, reseat the iterator instead of bidi-iterating there one
7336 character at a time. (Bug#9610)
32c1fffd
SM
7337 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7338 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7339
ed497dd4
AS
73402011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7341
7342 * lread.c (readevalloop): Use correct code for NBSP.
7343 (read1): Likewise. (Bug#9608)
7344
b2bf61aa
MA
73452011-09-25 Michael Albinus <michael.albinus@gmx.de>
7346
7347 * dbusbind.c (Fdbus_register_signal): When service is not
7348 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7349
32bbb17c
GM
73502011-09-25 Glenn Morris <rgm@gnu.org>
7351
7352 * buffer.c (truncate-lines): Doc fix.
7353
94e0933e
CY
73542011-09-24 Chong Yidong <cyd@stupidchicken.com>
7355
7356 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7357 (Fset_window_next_buffers): Doc fix.
7358
cddde921
GM
73592011-09-24 Glenn Morris <rgm@gnu.org>
7360
7361 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7362
1260aef1
PE
73632011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7364
25b4bfa0
PE
7365 Fix minor problems found by static checking.
7366 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7367 * indent.c (Fvertical_motion): Fix == vs = typo.
7368
e3cbd34b
EZ
73692011-09-24 Eli Zaretskii <eliz@gnu.org>
7370
a66cfb1c
SM
7371 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7372 Default value is now t. Doc fix.
6bf7006f 7373
e3cbd34b 7374 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7375 logic when moving up, not only when moving down. Fix the
e3cbd34b 7376 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7377 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7378
7379 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7380 CHARPOS is covered by a display string which includes newlines.
7381 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7382 is covered by a display string with embedded newlines.
7383
a3de0cbd
MA
73842011-09-24 Michael Albinus <michael.albinus@gmx.de>
7385
7386 * dbusbind.c (Fdbus_register_signal): Add match rule to
7387 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7388 (Fdbus_register_method, Vdbus_registered_objects_table):
7389 Fix docstring.
a3de0cbd 7390
b260039d
JM
73912011-09-24 Jim Meyering <meyering@redhat.com>
7392
32c1fffd 7393 do not ignore write error for any output size
b260039d
JM
7394 The previous change was incomplete.
7395 While it makes emacs --batch detect the vast majority of stdout
7396 write failures, errors were still ignored whenever the output size is
7397 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7398 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7399 && echo FAIL: ignored write error
7400 FAIL: ignored write error
7401 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7402 && echo FAIL: ignored write error
7403 FAIL: ignored write error
7404 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7405
8eca8a7c
AS
74062011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7407
7408 * emacs.c (Fkill_emacs): In noninteractive mode exit
7409 non-successfully if a write error occurred on stdout. (Bug#9574)
7410
3341db62
EZ
74112011-09-21 Eli Zaretskii <eliz@gnu.org>
7412
7413 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7414 the xassert test.
7415
7416 * dispextern.h (struct it): Update the comment documenting what
7417 can it->OBJECT be.
7418
8c203dbf
EZ
74192011-09-20 Eli Zaretskii <eliz@gnu.org>
7420
7421 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7422 a display string, extend search for cursor position to end of row.
7423 (find_row_edges): If the row ends in a newline from a display
7424 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7425 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7426 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7427 non-empty line. Fixes confusing cursor motion with arrow keys at
7428 the beginning of a line that starts with whitespace.
8c203dbf 7429
a4824228
LMI
74302011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7431
7432 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7433 (bug#9493).
7434
33ed493b
CY
74352011-09-18 Chong Yidong <cyd@stupidchicken.com>
7436
7437 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7438 boolean (Bug#9154).
7439
56cd55c8
EZ
74402011-09-18 Eli Zaretskii <eliz@gnu.org>
7441
7442 * xdisp.c (display_line): Record maximum and minimum buffer
7443 positions even if no glyphs were produced (e.g., by a zero-width
7444 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7445 buffer positions that will be removed from the glyph row because
7446 they don't fit.
c02dcedf
EZ
7447 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7448 column is beyond frame width: don't subtract 1 "pixel" when
7449 computing width of the stretch.
3e62b7e0
EZ
7450 (reseat_at_next_visible_line_start): Undo the change made on
7451 2011-09-17 that saved paragraph information and restored it after
7452 the call to `reseat'. (Bug#9545)
56cd55c8 7453
5ed99d36 74542011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7455
7456 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7457 and turn window cursor on if cleared (Bug#9415).
7458
5ed99d36 74592011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7460
7461 * search.c (boyer_moore): Take unibyte characters from pattern
7462 literally. (Bug#9458)
7463
9bade7b2
EZ
74642011-09-18 Eli Zaretskii <eliz@gnu.org>
7465
7466 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7467
e5e9d610
PE
74682011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7469
87e4427a
PE
7470 Fix minor problem found by static checking.
7471 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7472 initialized, to pacify gcc -Wuninitialized.
7473
e5e9d610
PE
7474 * fileio.c: Report proper errno when syscall falls.
7475 (Finsert_file_contents): Save and restore errno,
7476 so that report_file_error outputs the correct diagnostic.
7477 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7478
a1674f0b
EZ
74792011-09-18 Eli Zaretskii <eliz@gnu.org>
7480
7481 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7482
fbfb6dd4
EZ
74832011-09-17 Eli Zaretskii <eliz@gnu.org>
7484
7485 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7486 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7487
bb187662
EZ
74882011-09-17 Eli Zaretskii <eliz@gnu.org>
7489
1137e8b8 7490 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7491 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7492
7493 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7494 (bidi_find_paragraph_start): Search back for paragraph beginning
7495 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7496 (bidi_move_to_visually_next): Only trigger paragraph-related
7497 computations when the last character is a newline or at EOB, not
7498 just any NEUTRAL_B. (Bug#9470)
7499
bb187662
EZ
7500 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7501 truncated lines if point is covered by a display string. (Bug#9524)
7502
2e621251
PE
75032011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7504
7505 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7506 (cons_to_x_long): New function.
7507 (lisp_data_to_selection_data): Use it. Correct the test for
7508 short-versus-long data; it was negated. Break out of vector
7509 loop, for efficiency, when a long datum is discovered.
7510
91a15bc6
SM
75112011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7512
7513 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7514
b41c3a35
EZ
75152011-09-16 Eli Zaretskii <eliz@gnu.org>
7516
7517 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7518 GCC PR/17406) by declaring this function with external scope.
7519
7812ba2d
PE
75202011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7523 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7524
cf7edc2a
AS
75252011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7526
7527 * editfns.c (Fformat): Correctly handle text properties on "%%".
7528
bd01620e
EZ
75292011-09-15 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xterm.c (x_draw_composite_glyph_string_foreground):
7532 * w32term.c (x_draw_composite_glyph_string_foreground):
7533 * term.c (encode_terminal_code):
7534 * composite.c (composition_update_it, get_composition_id):
7535 * xdisp.c (get_next_display_element)
7536 (fill_composite_glyph_string): Add comments about special meaning
7537 of TAB characters in a composition.
7538
a02719a3
PE
75392011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7542 This occurs when processing a multibyte format.
7543 Problem reported by Wolfgang Jenker.
a02719a3 7544
72589a3c
JB
75452011-09-15 Johan Bockgård <bojohan@gnu.org>
7546
7547 * xdisp.c (try_cursor_movement): Only check for exact match if
7548 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7549
1c14176c
PE
75502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7551
7552 Remove unused external symbols.
7553 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7554 * xdisp.c (calc_pixel_width_or_height): Now static.
7555 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7556 * indent.c (check_display_width):
7557 * w32term.c: Fix comment to match code.
7558 * xterm.c, xterm.h (x_catching_errors): Remove.
7559
d2eea5b5
PE
75602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 * xselect.c: Use signed conversions more consistently (Bug#9498).
7563 (selection_data_to_lisp_data): Assume incoming selection data are
7564 signed integers, not unsigned. This is to be consistent with
7565 outgoing selection data, which was modified to use signed integers
7566 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7567 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7568 expects long, not unsigned long.
7569
46888499
EZ
75702011-09-14 Eli Zaretskii <eliz@gnu.org>
7571
7572 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7573 computation of loop end. Reported by Johan Bockgård
7574 <bojohan@gnu.org>.
7575
ef8ef9fb
CY
75762011-09-13 Chong Yidong <cyd@stupidchicken.com>
7577
7578 * frame.c (Fother_visible_frames_p): Function deleted.
7579
fa819fed
EZ
75802011-09-12 Eli Zaretskii <eliz@gnu.org>
7581
7582 * indent.c (compute_motion): Process display vector front to back
7583 rather than the other way around. (Bug#2496)
7584
2ba8e008
SM
75852011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7586
7587 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7588
20f53c69
CY
75892011-09-11 Chong Yidong <cyd@stupidchicken.com>
7590
7591 * minibuf.c (Fread_from_minibuffer): Doc fix.
7592
d562d7a4
EZ
75932011-09-11 Eli Zaretskii <eliz@gnu.org>
7594
7595 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7596 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7597
1c4d7f3d
LMI
75982011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7599
7600 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7601 value for non-existent files.
7602
b885bf36
EZ
76032011-09-11 Eli Zaretskii <eliz@gnu.org>
7604
7605 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7606 set its "size" to -1. This will set the modtime_size field of
7607 the corresponding buffer to -1, which is what
7608 verify-visited-file-modtime expects for files that do not exist.
7609 (Bug#9139)
7610
6612f0bf
PE
76112011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7612
7613 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7614 here ...
7615 * lisp.h: ... from here. push_key_description is no longer
7616 defined in keyboard.c, so its declaration should not be in
7617 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7618 logically belongs with push_key_description.
7619
dfb3f755
PE
76202011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7621
7622 * buffer.h: Include <sys/types.h> instead of <time.h>.
7623 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7624 Problem reported by Herbert J. Skuhra.
7625
3134906c
LMI
76262011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7627
7628 * xml.c (parse_region): Make the parsing work for
7629 non-comment-starting XML files again (bug#9144).
7630
8d903f4e
AS
76312011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7632
7633 * image.c (gif_load): Fix calculation of bottom and right corner.
7634 (Bug#9468)
7635
80ad64f4
EZ
76362011-09-10 Eli Zaretskii <eliz@gnu.org>
7637
7638 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7639 redisplay in small windows.
7640
208a048d
EZ
76412011-09-09 Eli Zaretskii <eliz@gnu.org>
7642
7643 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7644
9b1c252e
MR
76452011-09-08 Martin Rudalics <rudalics@gmx.at>
7646
7647 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7648 Operate on live windows only.
7649
2949f33b
JB
76502011-09-08 Juanma Barranquero <lekktu@gmail.com>
7651
7652 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7653
e08dcafd
EZ
76542011-09-07 Eli Zaretskii <eliz@gnu.org>
7655
7656 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7657 only under bidi iteration.
7658
115b96bd
JD
76592011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7660
7661 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7662
c8199d0f
PE
76632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7664
7665 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7666 Without this fix, the command to link temacs failed due to an
7667 undefined symbol __builtin_isnan. This is because
7668 /usr/include/iso/math_c99.h #defines isnan(x) to
7669 __builtin_isnan(x), but the bundled gcc, which identifies itself
7670 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7671 a __builtin_isnan.
7672 * floatfns.c (isnan): #undef, and then #define to a clone of
7673 what's in data.c.
7674 (Fisnan): Always define, since it's always available now.
7675 (syms_of_floatfns): Always define isnan at the Lisp level.
7676
e39b275c 76772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7678
7679 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7680
b2db44d9 76812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7682
f4af5137 7683 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7684 The previous code assumed that file offsets (off_t values) fit in
7685 EMACS_INT variables, which is not true on typical 32-bit hosts.
7686 The code messed up by falsely reporting buffer overflow in cases
7687 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7688 when "big" contains more than 2**29 bytes, even though this
7689 inserts just one byte and does not overflow the buffer.
7690 (Finsert_file_contents): Store file offsets as off_t
7691 values, not as EMACS_INT values. Check for overflow when
7692 converting between EMACS_INT and off_t. When checking for
7693 buffer overflow or for overlap, take the offsets into account.
7694 Don't use EMACS_INT for small values where int suffices.
7695 When checking for overlap, fix a typo: ZV was used where
7696 ZV_BYTE was intended.
7697 (Fwrite_region): Don't assume off_t fits into 'long'.
7698 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7699
ecfc0a49
MA
77002011-09-05 Michael Albinus <michael.albinus@gmx.de>
7701
7702 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7703
6511acf2 77042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7705
0999621a 7706 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7707
7708 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7709 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7710 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7711 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7712 (modify_event_symbol): Do not assume that the length of
7713 name_alist_or_stem is safe to alloca and fits in int.
7714 (Fexecute_extended_command): Likewise for function name and binding.
7715 (Frecursion_depth): Wrap around reliably on integer overflow.
7716 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7717 since some callers pass EMACS_INT values.
7718 (Fsingle_key_description): Don't crash if symbol name contains more
7719 than MAX_ALLOCA bytes.
7720 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7721 (get_minibuffer): Arg is now EMACS_INT, not int.
7722 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7723 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7724 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7725
2be7d702
PE
7726 * dbusbind.c (signature_cat): New function.
7727 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7728 Do not overrun buffer; instead, report string overflow.
7729
9d1df220
PE
7730 * dispnew.c (add_window_display_history): Don't overrun buffer.
7731 Truncate instead; this is OK since it's just a log.
7732
33ef5c64
PE
7733 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7734 even if the time zone offset is outlandishly large.
7735 Don't mishandle offset == INT_MIN.
7736
66c6fdd5
PE
7737 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7738 when creating daemon; the previous buffer-overflow check was incorrect.
7739
d749b01b
PE
7740 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7741 which has the guts of the old verror function.
7742
b5cd1905
PE
7743 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7744 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7745
6e1a67fb
PE
7746 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7747 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7748 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7749 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7750 length of string rather than counting it via multiple sprintfs;
7751 that's simpler and more reliable.
c21721cc
PE
7752 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7753 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7754 sprintf, in case result does not fit in int.
7755
c57b67fc
PE
7756 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7757 (fontset_from_font): Print it.
7758
8a401434
PE
7759 * frame.c (tty_frame_count): Now printmax_t, not int.
7760 (make_terminal_frame, set_term_frame_name): Print it.
7761 (x_report_frame_params): In X, window IDs are unsigned long,
7762 not signed long, so print them as unsigned.
7763 (validate_x_resource_name): Check for implausibly long names,
7764 and don't assume name length fits in 'int'.
7765 (x_get_resource_string): Don't blindly alloca invocation name;
7766 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7767 not fit in int.
7768
6e1a67fb
PE
7769 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7770 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7771 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7772
0df02bf3
PE
7773 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7774 Use esprintf, not sprintf, in case result does not fit in int.
7775
48e30793
PE
7776 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7777 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7778 it as a large positive number.
7779 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7780 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7781
a66ff6d8
PE
7782 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7783 in case result does not fit in int.
7784
aca216ff
PE
7785 * print.c (float_to_string): Detect width overflow more reliably.
7786 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7787 buffer overrun. Don't assume list length fits in 'int'. Treat
7788 print length of 0 as 0, not as infinity; to be consistent with other
7789 uses of print length in this function. Don't overflow print length
7790 index. Don't assume hash table size fits in 'long', or that
7791 vectorlike size fits in 'unsigned long'.
7792
31c286f7
PE
7793 * process.c (make_process): Use printmax_t, not int, to format
7794 process-name gensyms.
7795
55e5faa1
PE
7796 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7797
80f2e268
PE
7798 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7799 to avoid potential buffer overrun.
7800
670741ab
PE
7801 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7802 if X resource line is longer than 512 bytes.
7803
b7163a50
PE
7804 * xfns.c (x_window): Make sprintf buffer a bit bigger
7805 to avoid potential buffer overrun.
7806
ae58ff1f
PE
7807 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7808
c43c8a6a
PE
7809 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7810
3f8236f4
PE
78112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7812
53e9fe90 7813 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7814 Without these, Emacs silently mishandles large integers sometimes.
7815 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7816 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7817
6511acf2
PE
7818 * xdisp.c (try_window_id): Check Emacs fixnum range before
7819 converting to 'int'.
806add1d 7820
6511acf2 7821 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7822 Check that an Emacs fixnum is in range before assigning it to 'int'.
7823 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7824 values converted from Emacs fixnums.
7825 (Frecenter): Don't wrap around a line count if it is out of 'int'
7826 range; instead, treat it as an extreme value.
7827 (Fset_window_configuration, compare_window_configurations):
7828 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7829
6511acf2
PE
7830 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7831 that can exceed INT_MAX. Check that EMACS_INT value is in range
7832 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7833 (match_limit): Don't assume that a fixnum can fit in 'int'.
7834
6511acf2 7835 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7836 exceed INT_MAX.
7837
6511acf2 7838 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7839 (Fvertical_motion): Don't wrap around LINES values that don't fit
7840 in 'int'. Instead, treat them as extreme values. This is good
7841 enough for windows, which can't have more than INT_MAX lines anyway.
7842
fcb901a7
LMI
78432011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844
0f2f6b6d
LMI
7845 * Require libxml/parser.h to avoid compilation warning.
7846
fcb901a7
LMI
7847 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7848
7849 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7850 since this reportedly can destroy thread storage.
7851
6e20a0d4
CY
78522011-08-30 Chong Yidong <cyd@stupidchicken.com>
7853
7854 * syntax.c (find_defun_start): Update all cache variables if
7855 exiting early (Bug#9401).
7856
148ae00e
EZ
78572011-08-30 Eli Zaretskii <eliz@gnu.org>
7858
f6cfbd8f
EZ
7859 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7860
148ae00e
EZ
7861 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7862 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7863 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7864
7865 * term.c (tty_append_glyph): New function.
7866 (produce_stretch_glyph): Static function and its prototype deleted.
7867
a66cfb1c
SM
7868 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7869 Add prototypes.
148ae00e 7870
c4a07a4c
PE
78712011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7872
7873 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7874 when checking :margin (Bug#9390).
7875 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7876 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7877 so that the name doesn't mislead. All uses changed.
7878
6bc8cd65
JB
78792011-08-28 Johan Bockgård <bojohan@gnu.org>
7880
7881 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7882 set_tty_hooks.
7883
dca4927e
EZ
78842011-08-27 Eli Zaretskii <eliz@gnu.org>
7885
7886 * xdisp.c (move_it_to): Don't bail out early when reaching
7887 position beyond to_charpos, if we are scanning backwards.
7888 (move_it_vertically_backward): When DY == 0, make sure we get to
7889 the first character in the line after the newline.
7890
f2cad773
PE
78912011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7892
7893 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7894 (ccl_driver): Do not generate an out-of-range pointer.
7895 (Fccl_execute_on_string): Remove unnecessary check for
7896 integer overflow, noted by Stefan Monnier in
7897 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7898 Remove a FIXME that didn't need fixing.
7899 Simplify the newly-introduced buffer reallocation code.
7900
0cae2cdb
JB
79012011-08-27 Juanma Barranquero <lekktu@gmail.com>
7902
7903 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7904
5fc295a4 79052011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7906
70c60eb2 7907 Integer and memory overflow issues (Bug#9196).
726e0ab1 7908
d31850da
PE
7909 * doc.c (get_doc_string): Rework so that
7910 get_doc_string_buffer_size is the actual buffer size, rather than
7911 being 1 less than the actual buffer size; this makes xpalloc more
7912 convenient.
7913
a69fbedb
PE
7914 * image.c (x_allocate_bitmap_record, cache_image):
7915 * xselect.c (Fx_register_dnd_atom):
7916 Simplify previous changes by using xpalloc.
7917
fe5c5d37
PE
7918 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7919 since either will do and ptrdiff_t is convenient with xpalloc.
7920
0065d054
PE
7921 * charset.c (charset_table_size)
7922 (struct charset_sort_data.priority): Now ptrdiff_t.
7923 (charset_compare): Don't overflow if priorities differ greatly.
7924 (Fsort_charsets): Don't assume list length fits in int.
7925 Check for size-calculation overflow when allocating sort data.
7926 (syms_of_charset): Allocate an initial charset table that is
7927 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7928
7929 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7930
7931 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7932 The actual value is always <= INT_MAX, and leaving it unsigned made
7933 overflow checking harder.
7934
7935 * dispextern.h (struct glyph_matrix.rows_allocated)
7936 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7937 with xpalloc. The values are still always <= INT_MAX.
7938
7939 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7940
7941 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7942 (SAFE_NALLOCA): New macro.
7943
7944 * region-cache.c (struct boundary.pos, find_cache_boundary)
7945 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7946 (set_cache_region, invalidate_region_cache)
7947 (revalidate_region_cache, know_region_cache, region_cache_forward)
7948 (region_cache_backward, pp_cache):
7949 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7950 so that ptrdiff_t * can be passed to xpalloc.
7951 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7952 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7953 (pp_cache): Don't assume cache_len fits in int.
7954 * region-cache.h: Adjust extern decls to match.
7955
7956 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7957 EMACS_INT, since either will do, for xpalloc.
7958
7959 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7960 (xnmalloc, xnrealloc, xpalloc): New functions.
7961
726e0ab1
PE
7962 * bidi.c (bidi_shelve_header_size): New constant.
7963 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7964 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7965
51f30bc5 7966 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7967 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7968 (overlay_strings):
7969 Don't update size of array until after memory allocation succeeds,
7970 because xmalloc/xrealloc may not return.
0065d054
PE
7971 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7972 now that we have proper integer overflow checking.
7973 (record_overlay_string, overlay_strings): Catch overflows when
7974 calculating size of overlay_str_buf.
726e0ab1 7975
0065d054
PE
7976 * callproc.c (Fcall_process): Check for size overflow when
7977 calculating size of args2.
7978 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7979 Normally we prefer signed values, but sticking with ptrdiff_t would
7980 require adding more-complicated checks.
726e0ab1
PE
7981
7982 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7983 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7984 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7985 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7986
7987 * character.c (Fstring): Check for size-calculation overflow.
7988
7989 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7990 unnecessary integer overflow. Check for size overflow.
7991 (encode_coding_object): Don't update size until xmalloc succeeds.
7992
7993 * composite.c (get_composition_id): Check for overflow in glyph
7994 length calculations.
7995
7996 Integer and memory overflow fixes for display code.
7997 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7998 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7999 (scrolling_window): Check for overflow in size calculations.
8000 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8001 Don't assume glyph table len fits in int.
8002 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8003 (row_table_size): Now ptrdiff_t, not int.
8004 (scrolling_window): Avoid overflow in size calculations.
8005 Don't update size until allocation succeeds.
8006 * fns.c (concat): Check for overflow in size calculations.
8007 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8008 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8009 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8010
8011 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8012 (get_doc_string): Check for size calculation overflow.
8013 Don't update size until allocation succeeds.
8014 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8015 EMACS_INT, where ptrdiff_t will do.
8016 (Fsubstitute_command_keys): Check for string overflow.
8017
8018 * editfns.c (set_time_zone_rule): Don't assume environment length
8019 fits in int.
8020 (message_length): Now ptrdiff_t, not int.
8021 (Fmessage_box): Don't update size until allocation succeeds.
8022 Don't assume message length fits in int.
8023 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8024
0065d054
PE
8025 * emacs.c (main): Do not reallocate argv, since there is a null at
8026 the end that can be overwritten, and this way there's no need to
8027 worry about size-calculation overflow.
8028 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8029
8030 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8031 alloc succeeds.
8032 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8033
8034 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8035 (x_set_scroll_bar_width, x_figure_window_size):
8036 Check for integer overflow.
8037 (x_set_alpha): Do not assume XINT fits in int.
8038
8039 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8040 This is for the members text_lines, text_cols, total_lines, total_cols,
8041 where the system imposes an 'int' limit.
8042
8043 * fringe.c (Fdefine_fringe_bitmap):
8044 Don't update size until alloc works.
8045
8046 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8047 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8048
8049 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8050 Check for size-calculation overflow.
8051 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8052 do, as we prefer signed integers.
8053 (id_to_widget.max_size, id_to_widget.used)
8054 (xg_store_widget_in_map, xg_remove_widget_from_map)
8055 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8056 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8057 Use and return ptrdiff_t, not int.
8058 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8059 * gtkutil.h: Change prototypes to match the above.
8060
8061 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8062 are duplicate now that they've been promoted to lisp.h.
8063 (x_allocate_bitmap_record, x_alloc_image_color)
8064 (make_image_cache, cache_image, xpm_load):
8065 Don't update size until alloc is done.
8066 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8067 (x_detect_edges):
3256efce 8068 Check for size calculation overflow.
726e0ab1
PE
8069 (ct_colors_allocated_max): New constant.
8070 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8071 overflow.
3256efce 8072
726e0ab1
PE
8073 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8074 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8075 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8076 Use ptrdiff_t, not int, to count maps.
8077 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8078 calculations. Don't update size until allocation succeeds.
8079 Redo calculations to avoid overflow.
726e0ab1
PE
8080 * keyboard.h: Change prototypes to match the above.
8081
8082 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8083 to count maps.
8084 (current_minor_maps): Check for size calculation overflow.
8085 * keymap.h: Change prototypes to match the above.
8086
8087 * lread.c (read1, init_obarray): Don't update size until alloc done.
8088
8089 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8090 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8091
726e0ab1
PE
8092 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8093 Now ptrdiff_t, not int.
8094 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8095 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8096
8097 * process.c (Fnetwork_interface_list): Check for overflow
8098 in size calculation.
8099
8100 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8101
8102 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8103 overflow. Don't bother calling xmalloc when xrealloc will do.
8104
8105 * search.c (Freplace_match): Check for size calculation overflow.
8106 (Fset_match_data): Don't assume list lengths fit in 'int'.
8107
8108 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8109 for command line length. Do not attempt to address one before the
8110 beginning of an array, as that's not portable.
8111
8112 * term.c (max_frame_lines): Remove; unused.
8113 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8114 not int.
8115 (encode_terminal_code, calculate_costs): Check for size
8116 calculation overflow.
8117 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8118 table lengths and related sizes. Don't update size until alloc
8119 done. Redo calculations to avoid overflow.
8120 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8121
8122 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8123 subtracting pointers.
8124 (gobble_line): Check for overflow more carefully. Don't update size
8125 until alloc done.
8126
8127 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8128 Don't update size until alloc done.
8129 Redo size calculations to avoid overflow.
8130 Check for size calculation overflow.
0065d054 8131 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8132
8133 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8134 Use ptrdiff_t, not int, for sizes.
8135 (store_mode_line_noprop_char): Don't update size until alloc done.
8136
0065d054
PE
8137 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8138 Use ptrdiff_t, not int, for sizes.
8139 (Finternal_make_lisp_face, cache_face):
8140 Check for size calculation overflow.
8141 (cache_face): Treat size calculation overflows as if they were
8142 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8143
8144 * xfns.c (x_encode_text, x_set_name_internal)
8145 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8146 sizes, since they can exceed INT_MAX in size. Check for size
8147 calculation overflow.
8148
0065d054
PE
8149 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8150 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8151 Don't update size until alloc done.
8152
0065d054 8153 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8154 as sprintf is limited to int lengths.
1d526e2f 8155
252c5ee1
PE
8156 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8157 (X_LONG_MIN): New macros.
864d7ce7
PE
8158 Use them to make the following changes clearer.
8159 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8160 This change doesn't affect the value now, but it may help remind
8161 future maintainers not to raise the value too much later.
8162 (SELECTION_QUANTUM): Remove, replacing with ...
8163 (selection_quantum): ... new function, which avoids overflow.
8164 All uses changed.
8165 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8166 assumption that selection length fits in 'int'.
8167 (x_reply_selection_request, x_handle_selection_request)
8168 (x_get_window_property, receive_incremental_selection)
8169 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8170 (lisp_data_to_selection_data, clean_local_selection_data):
8171 Use ptrdiff_t, not int, to record length of selection.
8172 (x_reply_selection_request, x_get_window_property)
8173 (receive_incremental_selection, x_property_data_to_lisp):
8174 Redo calculations to avoid overflow.
8175 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8176 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8177 something.
8178 (x_get_window_property, receive_incremental_selection)
8179 (lisp_data_to_selection_data, x_property_data_to_lisp):
8180 Check for size-calculation overflow.
8181 (x_get_window_property, receive_incremental_selection)
8182 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8183 Don't store size until memory allocation succeeds.
8184 (x_get_window_property): Plug memory leak on memory exhaustion.
8185 Don't double-block input; malloc is safe here. Don't assume 2**34
8186 - 4 fits in unsigned long. Add an xassert to check
8187 XGetWindowProperty overflow. Be more careful about overflow
8188 calculations, and distinguish size from memory overflow better.
8189 (receive_incremental_selection): When tracing, don't assume
8190 unsigned int is less than INT_MAX.
8191 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8192 harmful) conversions of unsigned short to int.
8193 (lisp_data_to_selection_data): Don't assume that integers
8194 in the range -65535 through -1 fit in an X unsigned short.
8195 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8196 result parameters unless successful. Rely on cons_to_unsigned
8197 to report problems with elements; the old code wasn't right anyway.
8198 (x_check_property_data): Check for int overflow; we cannot use
8199 a wider type due to X limits.
8200 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8201
726e0ab1 8202 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8203
0065d054
PE
8204 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8205 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8206 (x_color_cells): Don't store size until memory allocation succeeds.
8207 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8208 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8209 (x_term_init): Don't assume length fits in int (sprintf is limited
8210 to int size).
bc18e09d 8211
ebfa62c0
PE
8212 Use ptrdiff_t for composition IDs.
8213 * character.c (lisp_string_width):
8214 * composite.c (composition_table_size, n_compositions)
8215 (get_composition_id, composition_gstring_from_id):
8216 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8217 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8218 * window.c (Frecenter):
8219 Use ptrdiff_t, not int, for composition IDs.
8220 * composite.c (get_composition_id): Check for integer overflow.
8221 * composite.h: Adjust prototypes to match the above changes.
8222
d3411f89
PE
8223 Use ptrdiff_t for hash table indexes.
8224 * category.c (hash_get_category_set):
8225 * ccl.c (ccl_driver):
8226 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8227 * coding.c (coding_system_charset_list, detect_coding_system):
8228 * coding.h (struct coding_system.id):
8229 * composite.c (get_composition_id, gstring_lookup_cache):
8230 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8231 * image.c (xpm_get_color_table_h):
8232 * lisp.h (hash_lookup, hash_put):
8233 * minibuf.c (Ftest_completion):
8234 Use ptrdiff_t for hash table indexes, not int (which is too
8235 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8236 32-bit --with-wide-int hosts).
8237
e097a6fa
PE
8238 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8239 Add a FIXME comment about memory leaks.
8240 (syms_of_charset): Don't assume xmalloc returns.
8241
5637687f
PE
8242 Don't assume that stated character widths fit in int.
8243 * character.c (Fchar_width, c_string_width, lisp_string_width):
8244 * character.h (CHAR_WIDTH):
8245 * indent.c (MULTIBYTE_BYTES_WIDTH):
8246 Use sanitize_char_width to avoid undefined and/or bad behavior
8247 with outlandish widths.
a66cfb1c 8248 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8249 now that we have two such functions. All uses changed.
8250 (sanitize_char_width): New inline function.
8251
a2271ba2
PE
8252 Don't assume that tab-width fits in int.
8253 * character.h (sanitize_width): New inline function.
8254 (SANE_TAB_WIDTH): New macro.
8255 (ASCII_CHAR_WIDTH): Use it.
8256 * indent.c (sane_tab_width): Remove. All uses replaced by
8257 SANE_TAB_WIDTH (current_buffer).
8258 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8259
18c52557
PE
8260 * fileio.c: Integer overflow issues with file modes.
8261 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8262
caeeedc1
PE
8263 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8264 Remove unreachable code.
8265 (read_hex, load_charset_map_from_file): Check for integer overflow.
8266
6df6ae42 8267 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8268 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8269 (x_send_scroll_bar_event): Likewise. Check that the size does not
8270 exceed limits imposed by XClientMessageEvent, as well as the usual
8271 ptrdiff_t and size_t limits.
8272
b13995db
PE
8273 * keyboard.c: Overflow, signedness and related fixes.
8274 (make_lispy_movement): Use same integer type in forward decl
8275 that is used in the definition.
8276 (read_key_sequence, keyremap_step):
8277 Change bufsize argument back to int, undoing my 2011-03-30 change.
8278 We prefer signed types, and int is wide enough here.
8279 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8280 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8281 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8282 length, not size_t. Use ptrdiff_t for index, not int.
8283 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8284 possibility of integer overflow.
8285
13464394
PE
8286 Overflow, signedness and related fixes for images.
8287
8288 * dispextern.h (struct it.stack[0].u.image.image_id)
8289 (struct_it.image_id, struct image.id, struct image_cache.size)
8290 (struct image_cache.used, struct image_cache.ref_count):
8291 * gtkutil.c (update_frame_tool_bar):
8292 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8293 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8294 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8295 * nsmenu.m (update_frame_tool_bar):
8296 * xdisp.c (calc_pixel_width_or_height):
8297 * xfns.c (image_cache_refcount):
8298 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8299 on typical 64-bit hosts.
8300
8301 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8302 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8303 Omit unnecessary casts to int.
8304 (parse_image_spec): Check that integers fall into 'int' range
8305 when the callers expect that.
8306 (image_ascent): Redo ascent calculation to avoid int overflow.
8307 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8308 (lookup_image): Remove unnecessary tests.
8309 (xbm_image_p): Locals are now of int, not EMACS_INT,
8310 since parse_image_check makes sure they fit into int.
8311 (png_load, gif_load, svg_load_image):
8312 Prefer int to unsigned where either will do.
8313 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8314 old tiff_error_handler and tiff_warning_handler.
8315 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8316 stack buffer overflows. It uses only the features of vsnprintf
8317 that are common to both POSIX and native Microsoft.
8318 (tiff_error_handler, tiff_warning_handler): Use it.
8319 (tiff_load, gif_load, imagemagick_load_image):
8320 Don't assume :index value fits in 'int'.
8321 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8322 (imagemagick_load_image): Check that crop parameters fit into
8323 the integer types that MagickCropImage accepts. Don't assume
8324 Vimagemagick_render_type has a nonnegative value. Don't assume
8325 size_t fits in 'long'.
8326 (gs_load): Use printmax_t to print the widest integers possible.
8327 Check for integer overflow when computing image height and width.
8328
c11821d4
EZ
83292011-08-26 Eli Zaretskii <eliz@gnu.org>
8330
8331 * xdisp.c (redisplay_window): Don't force window start if point
8332 will be invisible in the resulting window. (Bug#9324)
8333
0c95fcf7
EZ
83342011-08-25 Eli Zaretskii <eliz@gnu.org>
8335
8336 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8337 the display spec is of the form `(space ...)'.
8338 (handle_display_spec): Return the value returned by
8339 handle_single_display_spec, not just 1 or zero.
8340 (handle_single_display_spec): If the display spec is of the form
8341 `(space ...)', and specifies display in the text area, return 2
8342 rather than 1.
fee65a97 8343 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8344 accurately, and prefer exact match for point under bidi.
8345 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8346
8347 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8348 into disp_prop; all users changed.
8349
8350 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8351 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8352 for the text covered by the display property.
8353
e4ed06f1
CY
83542011-08-25 Chong Yidong <cyd@stupidchicken.com>
8355
8356 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8357 Change return value to nil.
8358 (Frecord_buffer): Delete unused function.
8359
f67cdd7f
EZ
83602011-08-24 Eli Zaretskii <eliz@gnu.org>
8361
5980d4c6
EZ
8362 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8363 buffers, return left-to-right.
8610fe8b
EZ
8364 (set_cursor_from_row): Consider candidate row a win if its glyph
8365 represents a newline and point is on that newline. Fixes cursor
8366 positioning on the newline at EOL of R2L text within L2R
8367 paragraph, and vice versa.
8368 (try_cursor_movement): Check continued rows, in addition to
8369 continuation rows. Fixes unwarranted scroll when point enters a
8370 continued line of R2L text within an L2R paragraph, or vice versa.
8371 (cursor_row_p): Consider the case of point being equal to
8372 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8373 from the end of a short line to the beginning of a continued line
8374 of R2L text within L2R paragraph.
8375 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8376 composed characters.
5980d4c6 8377
f67cdd7f
EZ
8378 * bidi.c (bidi_check_type): Use xassert.
8379 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8380 members.
8381
bca633fb
EZ
83822011-08-23 Eli Zaretskii <eliz@gnu.org>
8383
8384 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8385 a character.
8386
4a5885a7
CY
83872011-08-23 Chong Yidong <cyd@stupidchicken.com>
8388
8389 * nsfont.m (ns_otf_to_script): Fix typo.
8390
0902a04e
KH
83912011-08-22 Kenichi Handa <handa@m17n.org>
8392
8393 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8394 extra slot even if the purpose is char-code-property-table.
8395
1a2e6670
EZ
83962011-08-23 Eli Zaretskii <eliz@gnu.org>
8397
8ddde651
EZ
8398 * xdisp.c (redisplay_window): When computing centering_position,
8399 account for the height of the header line. (Bug#8874)
8400
425cc014
EZ
8401 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8402 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8403 candidate is selected by the mouse, and that candidate has a
8404 composed character under the mouse.
8405
1a2e6670
EZ
8406 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8407 coordinates reported by pos-visible-in-window-p for a composed
8408 character in column zero.
8409
8b76d6f8
SM
84102011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8411
8412 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8413
dac347dd
EZ
84142011-08-22 Eli Zaretskii <eliz@gnu.org>
8415
8416 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8417 consider it a hit if to_charpos is anywhere in the range of the
8418 composed buffer positions.
8419
e013fb34
CY
84202011-08-22 Chong Yidong <cyd@stupidchicken.com>
8421
8422 * image.c (gif_load): Don't assume that each subimage has the same
8423 dimensions as the base image. Handle disposal method that is
8424 "undefined" by the gif spec (Bug#9335).
8425
bd1ba3e8
CY
84262011-08-20 Chong Yidong <cyd@stupidchicken.com>
8427
8428 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8429 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8430
54a1215b
EZ
84312011-08-19 Eli Zaretskii <eliz@gnu.org>
8432
823564e5
EZ
8433 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8434 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8435 from an Org mode buffer to a Speedbar frame.
8436
54a1215b
EZ
8437 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8438 a composition, take its buffer position from IT->cmp_it.charpos.
8439 Fixes cursor positioning at the beginning of a line that begins
8440 with a composed character.
8441
9778ebcc
EZ
84422011-08-18 Eli Zaretskii <eliz@gnu.org>
8443
0be6ee06
EZ
8444 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8445 character bidirectional type, use STRONG_L instead. Fixes crashes
8446 in a buffer produced by `describe-categories'.
8447
9778ebcc
EZ
8448 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8449 members before the level stack, so they would be saved and
8450 restored when copying iterator state. Fixes incorrect reordering
8451 around TABs covered by display properties.
8452
156bffbe
AS
84532011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8454
6b02f655 8455 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8456
72ad093b
CY
84572011-08-17 Chong Yidong <cyd@stupidchicken.com>
8458
8459 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8460 (internal_condition_case_2, internal_condition_case_n):
8461 Remove unnecessary aborts (Bug#9081).
72ad093b 8462
35774242
EZ
84632011-08-17 Eli Zaretskii <eliz@gnu.org>
8464
8465 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8466 has no `load' handler, try opening the file locally. (Bug#9311)
8467
db76dd85
KB
84682011-08-16 Ken Brown <kbrown@cornell.edu>
8469
8470 * gmalloc.c: Expand comment.
8471
b215eee5
EZ
84722011-08-16 Eli Zaretskii <eliz@gnu.org>
8473
8474 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8475 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8476
a4579d33
KB
84772011-08-16 Ken Brown <kbrown@cornell.edu>
8478
8479 Fix memory allocation problems in Cygwin build (Bug#9273).
8480
8481 * unexcw.c ( __malloc_initialized): Declare external variable.
8482 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8483
8b76d6f8
SM
8484 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8485 New variables.
a4579d33
KB
8486 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8487 dumped emacs.
8488 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8489 in the static heap.
8490 [CYGWIN] (special_realloc): New function.
8491 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8492 requests to realloc storage in the static heap.
8493
3ebec551
PE
84942011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8495
8496 * bidi.c (bidi_initialize): Remove unused local.
8497
9fd8be00
EZ
84982011-08-15 Eli Zaretskii <eliz@gnu.org>
8499
6b02f655
SM
8500 * bidimirror.h:
8501 * biditype.h: Remove file.
8502 * makefile.w32-in ($(BLD)/bidi.$(O)):
8503 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8504
8505 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8506
8507 * chartab.c: Improve commentary for the uniprop_table API.
8508
32413314
EZ
8509 * bidi.c (bidi_paragraph_init): Support zero value of
8510 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8511 (bidi_initialize): Use uniprop_table instead of including
8512 biditype.h and bidimirror.h.
32413314 8513
9fd8be00
EZ
8514 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8515 coordinates of the iterator when restoring from ppos_it.
8516 (Bug#9296)
8517
5cf2b69b
KH
85182011-08-14 Kenichi Handa <handa@m17n.org>
8519
8520 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8521 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8522
daf17d00
EZ
85232011-08-14 Eli Zaretskii <eliz@gnu.org>
8524
8525 * xdisp.c (move_it_in_display_line_to): Don't invoke
8526 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8527 ppos_it. Fixes vertical cursor motion when line beginning is
8528 covered by an image. (Bug#9296)
8529
08e3161a
JD
85302011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8531
8532 * nsterm.h (ns_run_ascript): Declare.
8533 (NSAPP_DATA2_RUNASSCRIPT): Define.
8534
8535 * nsfns.m (as_script, as_result, as_status): New static variables.
8536 (ns_run_ascript): New function.
5e617bc2 8537 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8538 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8539 the event loop. Get status from as_status (Bug#7276).
8540
8541 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8542 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8543 the event loop (Bug#7276).
8544
a3720aa2
AS
85452011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8546
8547 * gnutls.c (QCgnutls_bootprop_priority)
8548 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8549 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8550 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8551 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8552 (QCgnutls_bootprop_verify_hostname_error)
8553 (QCgnutls_bootprop_callbacks_verify): Rename from
8554 Qgnutls_bootprop_..., all uses changed.
8555
8556 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8557 uses changed.
8558
0a0d27fb
PE
85592011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8560
19d5c50c
PE
8561 * xfaces.c (Qframe_set_background_mode): Now static.
8562 * dispextern.h (Qframe_set_background_mode): Remove decl.
8563
0a0d27fb
PE
8564 * process.c (Fnetwork_interface_info): Declare local only if needed.
8565
377538cb
JD
85662011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8567
8568 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8569 (Fnetwork_interface_list): Allocate in increments of bytes instead
8570 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8571 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8572 sockaddr.
8573 (struct ifflag_def): notrailers is smart on OSX.
8574 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8575 Get hardware address with getifaddrs if available.
8576
08fff70c
EZ
85772011-08-12 Eli Zaretskii <eliz@gnu.org>
8578
8579 * xdisp.c (iterate_out_of_display_property): xassert that
8580 IT->position is set to within IT->object's boundaries. Break from
8581 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8582 when IT->position is set up wrongly due to some bug.
8583 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8584 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8585 entry. Force push_it to save on the stack the current
8586 buffer/string position, to be restored by pop_it. Fix flags in
8587 the iterator structure wrt the object coming from a display
8588 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8589 properties. (Bug#9284)
8590
7be1c708 85912011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8592
7be1c708
CY
8593 * fontset.c (fontset_get_font_group): Add proper type checks.
8594 (Bug#9172)
aac0c6e3 8595
7be1c708 85962011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8597
7be1c708
CY
8598 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8599 and LC_VERSION_MIN_MACOSX.
8600 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8601 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8602
97bb72a6
EZ
86032011-08-08 Eli Zaretskii <eliz@gnu.org>
8604
8605 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8606 no-display-properties-and-no-overlays under bidi display.
8607 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8608 properties and overlays.
97bb72a6 8609
d5617611
CY
86102011-08-08 Chong Yidong <cyd@stupidchicken.com>
8611
37e11a63
CY
8612 * editfns.c (Fset_time_zone_rule): Document relationship with the
8613 setenv function.
8614
d5617611
CY
8615 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8616 the font entity extracted from the cache (Bug#8109).
8617
58872834
CY
86182011-08-07 Chong Yidong <cyd@stupidchicken.com>
8619
8620 * composite.c (autocmp_chars): Don't reset point. That is done by
8621 restore_point_unwind (Bug#5984).
8622
75bfc667
JL
86232011-08-07 Juri Linkov <juri@jurta.org>
8624
8625 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8626 to show the arg `TIME' instead of `TIMEVAL'.
8627
d1410150
EZ
86282011-08-06 Eli Zaretskii <eliz@gnu.org>
8629
8630 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8631 display property strides EOL and includes a newline, as in
8632 longlines-mode. (Bug#9254)
75b771e4
EZ
8633 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8634 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8635
8636 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8637 is non-zero, even if the data buffer is NULL. Fixes a crash in
8638 vertical-motion with longlines-mode. (Bug#9254)
8639
35928349
EZ
86402011-08-05 Eli Zaretskii <eliz@gnu.org>
8641
ec7cc85b
EZ
8642 * bidi.c <bidi_cache_total_alloc>: Now static.
8643 (bidi_initialize): Initialize bidi_cache_total_alloc.
8644
8b76d6f8 8645 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8646 cache. (Bug#9221)
8647
8648 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8649 amount allocated this far in `bidi_cache_total_alloc'.
8650 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8651 non-zero, only free the data buffer without restoring the cache
8652 contents. All callers changed.
8653
8654 * dispextern.h (bidi_unshelve_cache): Update prototype.
8655
8656 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8657 (move_it_in_display_line, move_it_to)
8658 (move_it_vertically_backward, move_it_by_lines): Replace the call
8659 to xfree to an equivalent call to bidi_unshelve_cache.
8660 (move_it_in_display_line_to): Fix logic of returning
412b6358 8661 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8662
e2e2423b
EZ
86632011-08-05 Eli Zaretskii <eliz@gnu.org>
8664
8665 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8666 came from a string character with a `cursor' property. (Bug#9229)
8667
ae9e757a
JD
86682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8669
8670 * Makefile.in (LIB_PTHREAD): New variable.
8671 (LIBES): Add LIB_PTHREAD (Bug#9216).
8672
8673 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8674 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8675
213bd7f2
AS
86762011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8677
6b02f655 8678 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8679
99aaf75f
JD
86802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8681
8682 * xterm.c (x_find_topmost_parent): New function.
8683 (x_set_frame_alpha): Find topmost parent window with
8684 x_find_topmost_parent and set the property there also (bug#9181).
8685 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8686
c74e9d86
PE
86872011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8688
8689 * callproc.c (Fcall_process): Avoid vfork clobbering
8690 the local vars buffer, coding_systems, current_dir.
8691
640c8776
SM
86922011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8693
8694 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8695
f26d0e4c
PE
86962011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8697
8a10d76c
PE
8698 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8699 so that it is not optimized away.
8700
f26d0e4c
PE
8701 * xdisp.c (compute_display_string_pos): Remove unused local.
8702
55439c61
EZ
87032011-08-02 Eli Zaretskii <eliz@gnu.org>
8704
8705 Fix slow cursor motion and scrolling in large buffers with
8706 selective display, like Org Mode buffers. (Bug#9218)
8707
8708 * dispextern.h (struct bidi_it): New member disp_prop_p.
8709
8710 * xdisp.c: Remove one-slot cache of display string positions.
8711 (compute_display_string_pos): Accept an additional argument
5e617bc2 8712 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8713 for a display string or property. If found, set DISP_PROP_P
8714 non-zero.
8715
8716 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8717 DISP_PROP_P, and pass it to compute_display_string_pos.
8718 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8719 non-zero. All callers of bidi_fetch_char changed.
8720
fb33fa43
SM
87212011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8722
8723 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8724
b099e063
DM
87252010-12-03 Don March <don@ohspite.net>
8726
8727 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8728 last character M-[char] is translated to ESC [char] (bug#7541).
8729
5cc7f7af
KH
87302011-08-02 Kenichi Handa <handa@m17n.org>
8731
d0fffa3f 8732 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8733
8734 * chartab.c (uniprop_table): Make it non-static.
8735
525d5e6e
EZ
87362011-08-01 Eli Zaretskii <eliz@gnu.org>
8737
8738 * xdisp.c (forward_to_next_line_start): Accept additional argument
8739 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8740 on the newline.
8741 (reseat_at_next_visible_line_start): Use the bidi iterator state
8742 returned by forward_to_next_line_start to restore the state of
8743 it->bidi_it after backing up to previous newline. (Bug#9212)
8744
31011111
AS
87452011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8746
8747 * regex.c (re_comp): Protoize.
8748 (re_exec): Fix return type.
8749 (regexec): Fix type of `ret'. (Bug#9203)
8750
476371c4
PE
87512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8752
e5d76069
PE
8753 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8754 This is needed if max-image-size is a floating-point number.
8755
9a79b20c
AS
87562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8757
8758 * print.c (print_object): Print empty symbol as ##.
8759
8760 * lread.c (read1): Read ## as empty symbol.
8761
d8c2fa78
AA
87622011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8763
8764 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8765 setting frame foreground color (Bug#9175).
8766 (x_set_background_color): Likewise.
8767
ffe57a7a
AA
8768 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8769 contents (Bug#9176).
8770 (EmacsTooltip -init): Remove bezels and add shadows to
8771 tooltip windows.
8772
bf3492a5
AA
8773 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8774 or scroll bar (Bug#8470).
8775
d55e9c53
AA
8776 * nsfont.m (nsfont_open): Remove assignment to voffset and
8777 unnecessary vars hshink, expand, hd, full_height, min_height.
8778 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8779
8780 * nsterm.h (nsfont_info): Remove voffset field.
8781
d8c2fa78 87822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8783
8784 Implement strike-through and overline on NextStep (Bug#8863).
8785
8786 * nsfont.m (nsfont_open): Use underline position provided by font,
8787 instead of hard-coded value of 2.
8788 (nsfont_draw): Call ns_draw_text_decoration instead.
8789
8790 * nsterm.h: Add declaration for ns_draw_text_decoration.
8791
8792 * nsterm.m (ns_draw_text_decoration): New function for drawing
8793 underline, overline, and strike-through.
8794 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8795 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8796 accommodate underlining, etc.
4843aac3 8797
4cc60b9b
EZ
87982011-07-28 Eli Zaretskii <eliz@gnu.org>
8799
bc7ece87
EZ
8800 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8801 default.
4cc60b9b 8802
476371c4
PE
88032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8804
66606eea
PE
8805 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8806 Without this fix, if a signal arrives just after memory fills up,
8807 'malloc' might be invoked reentrantly.
8808
476371c4
PE
8809 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8810 In other words, assume that every image size is allowed, on non-X
8811 hosts. This assumption is probably wrong, but it lets Emacs compile.
8812
f3fcc40d
AS
88132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8814
8815 * regex.c (re_iswctype): Convert return values to boolean.
8816
350c992f
EZ
88172011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8818
8819 * xdisp.c (compute_display_string_pos): Don't use cached display
8820 string position if the buffer had its restriction changed.
8821 (Bug#9184)
8822
5266b4bb
PE
88232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8824
8825 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8826
2573a837 88272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8828
41f55ccd 8829 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8830
39e378da
PE
8831 * bidi.c: Integer size and overflow fixes.
8832 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8833 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8834 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8835 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8836 (bidi_find_other_level_edge):
8837 Use ptrdiff_t instead of EMACS_INT where either will do.
8838 This works better on 32-bit hosts configured --with-wide-int.
8839 (bidi_cache_ensure_space): Check for size-calculation overflow.
8840 Use % rather than repeated addition, for better worst-case speed.
8841 Don't set bidi_cache_size until after xrealloc returns, because it
8842 might not return.
8843 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8844 (bidi_cache_ensure_space): Also check that the bidi cache size
8845 does not exceed that of the largest Lisp string or buffer. See Eli
8846 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8847
5e927815
PE
8848 * alloc.c (__malloc_size_t): Remove.
8849 All uses replaced by size_t. See Andreas Schwab's note
8850 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8851
ca4aa935
PE
8852 * image.c: Improve checking for integer overflow.
8853 (check_image_size): Assume that f is nonnull, since
8854 it is always nonnull in practice. This is one less thing to
8855 worry about when checking for integer overflow later.
8856 (x_check_image_size): New function, which checks for integer
8857 overflow issues inside X.
8858 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8859 This removes the need for a memory_full check.
8860 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8861 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8862 (xbm_read_bitmap_data): Change locals back to 'int', since
8863 their values must fit in 'int'.
8864 (xpm_load_image, png_load, tiff_load):
8865 Invoke x_create_x_image_and_pixmap earlier,
8866 to avoid much needless work if the image is too large.
8867 (tiff_load): Treat overly large images as if
8868 x_create_x_image_and_pixmap failed, not as malloc failures.
8869 (gs_load): Use x_check_image_size.
8870
5f8f9cc2
PE
8871 * gtkutil.c: Omit integer casts.
8872 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8873 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8874
5adf60bc
PE
8875 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8876
c8907a93
PE
8877 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8878 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8879 would wrongly return t on a 64-bit host.
8880
e3c25c68
PE
8881 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8882 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8883 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8884 and therefore cause GCC to emit a bogus diagnostic in some cases.
8885
3f791afe
PE
8886 * image.c: Integer signedness and overflow and related fixes.
8887 This is not an exhaustive set of fixes, but it's time to
8888 record what I've got.
8889 (lookup_pixel_color, check_image_size): Remove redundant decls.
8890 (check_image_size): Don't assume that arbitrary EMACS_INT values
8891 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8892 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8893 (tiff_load, imagemagick_load_image):
8894 Check for overflow in size calculations.
8895 (x_create_x_image_and_pixmap): Remove unnecessary test for
8896 xmalloc returning NULL; that can't happen.
8897 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8898 (xpm_color_bucket): Use better integer hashing function.
8899 (xpm_cache_color): Don't possibly over-allocate memory.
8900 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8901 (gif_memory_source):
8902 Use ptrdiff_t, not int or size_t, to record sizes.
8903 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8904 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8905 either works, as we prefer signed integers.
8906 (tiff_read_from_memory, tiff_write_from_memory):
8907 Return tsize_t, not size_t, since that's what the TIFF API wants.
8908 (tiff_read_from_memory): Don't fail simply because the read would
8909 go past EOF; instead, return a short read.
8910 (tiff_load): Omit no-longer-needed casts.
8911 (Fimagemagick_types): Don't assume size fits into 'int'.
8912
3cc5a532
PE
8913 Improve hashing quality when configured --with-wide-int.
8914 * fns.c (hash_string): New function, taken from sxhash_string.
8915 Do not discard information about ASCII character case; this
8916 discarding is no longer needed.
8917 (sxhash-string): Use it. Change sig to match it. Caller changed.
8918 * lisp.h: Declare it.
8919 * lread.c (hash_string): Remove, since we now use fns.c's version.
8920 The fns.c version returns a wider integer if --with-wide-int is
8921 specified, so this should help the quality of the hashing a bit.
8922
b312a492
PE
8923 * emacs.c: Integer overflow minor fix.
8924 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8925 Define only if GNU_LINUX.
8926 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8927
dfd153ae
PE
8928 * dispnew.c: Integer signedness and overflow fixes.
8929 Remove unnecessary forward decls, that were a maintenance hassle.
8930 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8931 All uses changed.
8932 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8933 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8934 (prepare_desired_row, line_draw_cost):
8935 Use int, not unsigned, where either works.
8936 (save_current_matrix, restore_current_matrix):
8937 Use ptrdiff_t, not size_t, where either works.
8938 (init_display): Check for overflow more accurately, and without
8939 relying on undefined behavior.
8940
a81d11a3
PE
8941 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8942 Remove, replacing with the new symbols in lisp.h. All uses changed.
8943 * fileio.c (make_temp_name):
8944 * filelock.c (lock_file_1, lock_file):
8945 * xdisp.c (message_dolog):
8946 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8947 Use pMd etc. instead.
8948 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8949 replacing the pWIDE etc. symbols removed from editfns.c.
8950
3300e6fd
PE
8951 * keyboard.h (num_input_events): Now uintmax_t.
8952 This is (very slightly) less likely to mess up due to wraparound.
8953 All uses changed.
8954
fd05c7e9
PE
8955 * buffer.c: Integer signedness fixes.
8956 (alloc_buffer_text, enlarge_buffer_text):
8957 Use ptrdiff_t rather than size_t when either will do, as we prefer
8958 signed integers.
8959
903fe15d
PE
8960 * alloc.c: Integer signedness and overflow fixes.
8961 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8962 (__malloc_size_t): Default to size_t, not to int.
8963 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8964 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8965 Prefer ptrdiff_t to size_t when either would do, as we prefer
8966 signed integers.
8967 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8968 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8969 Now const. Initialize with values that are in range even if char
8970 is signed.
8971 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8972 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8973 These functions do the right thing with sizes > 2**32.
8974 (check_depth): Now ptrdiff_t, not int.
8975 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8976 Adjust to new way of storing sizes. Check for size overflow bugs
8977 in rest of code.
8978 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8979 slightly wrong anyway, as it missed one instance of
8980 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8981 (refill_memory_reserve): Omit needless cast to size_t.
8982 (mark_object_loop_halt): Mark as externally visible.
8983
ac82cc6a
PE
8984 * xselect.c: Integer signedness and overflow fixes.
8985 (Fx_register_dnd_atom, x_handle_dnd_message):
8986 Use ptrdiff_t, not size_t, since we prefer signed.
8987 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8988 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8989 x_dnd_atoms_size and x_dnd_atoms_length.
8990
c2d1e36d
PE
8991 * doprnt.c: Prefer signed to unsigned when either works.
8992 * eval.c (verror):
8993 * doprnt.c (doprnt):
8994 * lisp.h (doprnt):
8995 * xdisp.c (vmessage):
8996 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8997 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8998 prefer signed arithmetic to avoid comparison confusion.
8999 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9000 but is a bit tricky.
9001
0e926e56
PE
9002 Assume freestanding C89 headers, string.h, stdlib.h.
9003 * data.c, doprnt.c, floatfns.c, print.c:
9004 Include float.h unconditionally.
9005 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9006 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9007 * regex.c: Likewise for stddef.h, string.h.
9008 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9009 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9010 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9011 (STDC_HEADERS): Remove obsolete defines.
9012 * sysdep.c: Include limits.h unconditionally.
9013
9cfdb3ec
PE
9014 Assume support for memcmp, memcpy, memmove, memset.
9015 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9016 * regex.c (memcmp, memcpy):
9017 Remove; we assume C89 now.
9018
9019 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9020 (__malloc_safe_bcopy): Remove; no longer needed.
9021
cf950e6b 9022 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9023 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9024 well either way, and we prefer signed to unsigned.
9025
dbf38e02
LMI
90262011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9027
9028 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9029 closes the connection while we're reading (bug#9182).
9030
d6f0886c 90312011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9032
d6f0886c
JD
9033 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9034 are specified (Bug#9168).
24e0f6b1 9035
2eb1f9e6
PE
90362011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9037
9038 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9039 Found by GCC static checking and --with-wide-int on a 32-bit host.
9040
22381272 90412011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9042
9043 * xdisp.c (compute_display_string_pos): Fix logic of caching
9044 previous display string position. Initialize cached_prev_pos to
9045 -1. Fixes slow-down at the beginning of a buffer.
9046
f25e39b4
EZ
90472011-07-24 Eli Zaretskii <eliz@gnu.org>
9048
9049 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9050 for attrs[LFACE_FONTSET_INDEX].
9051
04c4b52e
PE
90522011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9053
9054 * xml.c (parse_region): Remove unused local
9055 that was recently introduced.
9056
c1734fbd
EZ
90572011-07-23 Eli Zaretskii <eliz@gnu.org>
9058
be18c5a5
EZ
9059 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9060 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9061
c1734fbd
EZ
9062 * xdisp.c (move_it_in_display_line_to): Record the best matching
9063 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9064 exit if none of the characters scanned was an exact match.
9065 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9066 when exact match is impossible due to invisible text, and the
9067 lines are truncated.
9068
a258d627
JD
90692011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9070
9071 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9072 for OSX >= 10.7.
9073
b6d5a689
EZ
90742011-07-22 Eli Zaretskii <eliz@gnu.org>
9075
0f74f785
EZ
9076 Fix a significant slow-down of cursor motion with C-n, C-p,
9077 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9078 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9079 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9080 (next_element_from_buffer): Call compute_stop_pos_backwards to
9081 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9082 base_level_stop.
9083 (reseat): Don't look for prev_stop, as that could mean a very long
9084 run.
9085 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9086 <cached_disp_overlay_modiff>: Cache for last found display string
9087 position.
551918c1 9088 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9089 about the same buffer in the same area of character positions, and
9090 the buffer wasn't changed since the time the display string
9091 position was cached.
551918c1 9092
b2d0c91a
EZ
90932011-07-22 Eli Zaretskii <eliz@gnu.org>
9094
9095 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9096 is an integer, which is important for empty lines. (Bug#9149)
9097
043604ee
CY
90982011-07-22 Chong Yidong <cyd@stupidchicken.com>
9099
9100 * frame.c (Fmodify_frame_parameters): In tty case, update the
9101 default face if necessary (Bug#4238).
9102
da4adb04
CY
91032011-07-21 Chong Yidong <cyd@stupidchicken.com>
9104
9105 * editfns.c (Fstring_to_char): No need to explain what a character
9106 is in the docstring (Bug#6576).
9107
9abd0532
LMI
91082011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9109
9110 * xml.c (parse_region): Make sure we always return a tree.
9111
36881d16
HK
91122011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9113
9114 * xml.c (parse_region): If a document contains only comments,
9115 return that, too.
9116
1e98674d
LMI
91172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9118
9119 * xml.c (make_dom): Return comments, too.
9120
590bd467
PE
91212011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9122
9123 Port to OpenBSD.
9124 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9125 and the surrounding thread.
9126 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9127 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9128 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9129 timer goes off.
9130 * s/openbsd.h (BROKEN_SIGIO): Define.
9131 * unexelf.c (unexec) [__OpenBSD__]:
9132 Don't update the .mdebug section of the Alpha COFF symbol table.
9133
f41628b2
LMI
91342011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9135
9136 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9137 (bug#8460).
9138
b59b67c5
PE
91392011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9140
15e3a074
PE
9141 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9142 This fixes some race conditions on the permissions of any newly
9143 created file.
9144
41bed37d
PE
9145 * alloc.c (valid_pointer_p): Use pipe, not open.
9146 This fixes some permissions issues when debugging.
9147
b59b67c5
PE
9148 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9149 If fchown fails to set both uid and gid, try to set just gid,
9150 as that is sometimes allowed. Adjust the file's mode to eliminate
9151 setuid or setgid bits that are inappropriate if fchown fails.
9152
925a6be7
SM
91532011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9154
9155 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9156 to compare Lisp_Objects.
9157 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9158 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9159 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9160
52968808
AS
91612011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9162
0a6a104b
AS
9163 * lread.c (read_integer): Unread even EOF character.
9164 (read1): Likewise. Properly record start position of symbol.
9165
52968808
AS
9166 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9167 symbol character follows.
9168
9e381cdd
PE
91692011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9170
9171 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9172 This works around a problem with the previous change to Fcopy_file.
9173 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9174 and without this change, GCC might complain about discarding
9175 fchown's return value.
9176
b5641435
JB
91772011-07-16 Juanma Barranquero <lekktu@gmail.com>
9178
9179 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9180
a8031457
PE
91812011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9182
9183 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9184
dd889327
LMI
91852011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9186
750c33f7
LMI
9187 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9188 it's used from the C level.
9189
dd889327
LMI
9190 * process.c: Use the same condition for POLL_FOR_INPUT in both
9191 keyboard.c and process.c (bug#1858).
9192
87e86684
LM
91932011-07-09 Lawrence Mitchell <wence@gmx.li>
9194
9195 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9196 (Fgnutls_boot): Use it.
9197
64348f40
AS
91982011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9199
9200 * doc.c (Fsubstitute_command_keys): Revert last change.
9201
1d698799
LMI
92022011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9203
f863868c
LMI
9204 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9205 quotes the next character, and doesn't affect other longer
9206 sequences (bug#8935).
9207
1d698799
LMI
9208 * lread.c (syms_of_lread): Clarify that is isn't only
9209 `eval-buffer' and `eval-defun' that's affected by
9210 `lexical-binding' (bug#8460).
9211
aa4b6df6
EZ
92122011-07-15 Eli Zaretskii <eliz@gnu.org>
9213
9214 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9215 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9216
5d856da6
PE
92172011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9218
ad6042bb
PE
9219 Fix minor problems found by static checking.
9220 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9221 (elsz): Now a signed constant, not a size_t var. We prefer signed
9222 types to unsigned, to avoid integer comparison confusion. Without
9223 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9224 "cannot optimize loop, the loop counter may overflow", a symptom
9225 of the confusion.
f00bbb22 9226 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9227 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9228
6468f31c
LMI
92292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9230
49080b10
LMI
9231 * search.c (Fre_search_backward): Mention `case-fold-search' in
9232 all the re_search_* functions (bug#8138).
9233
6468f31c
LMI
9234 * keyboard.c (Fopen_dribble_file): Document when the file is
9235 closed (bug#8056).
9236
c965adc5
EZ
92372011-07-14 Eli Zaretskii <eliz@gnu.org>
9238
df9733bf
EZ
9239 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9240 bidi_cache_idx.
9241
0bb23927
EZ
9242 Support bidi reordering of display and overlay strings.
9243 * xdisp.c (compute_display_string_pos)
9244 (compute_display_string_end): Accept additional argument STRING.
9245 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9246 (reseat_to_string): Initialize bidi_it->string.s and
9247 bidi_it->string.schars.
9248 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9249 NULL (avoids a crash in bidi_paragraph_init).
9250 Initialize itb.string.lstring.
0bb23927
EZ
9251 (init_iterator): Call bidi_init_it only of a valid
9252 buffer position was specified. Initialize paragraph_embedding to
9253 L2R.
9254 (reseat_to_string): Initialize the bidi iterator.
9255 (display_string): If we need to ignore text properties of
9256 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9257 original value of -1 will not work with bidi.)
9258 (compute_display_string_pos): First arg is now struct
9259 `text_pos *'; all callers changed. Support display properties on
9260 Lisp strings.
9261 (compute_display_string_end): Support display properties on Lisp
9262 strings.
9263 (init_iterator, reseat_1, reseat_to_string): Initialize the
9264 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9265 when iterating on a string not from display properties).
640c8776
SM
9266 (compute_display_string_pos, compute_display_string_end):
9267 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9268 arrow keys.
9269 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9270 base_level_stop; instead, set base_level_stop to BEGV.
9271 Fixes crashes in vertical-motion.
0bb23927
EZ
9272 (next_element_from_buffer): Improve commentary for when
9273 the iterator is before prev_stop.
9274 (init_iterator): Initialize bidi_p from the default value of
9275 bidi-display-reordering, not from buffer-local value. Use the
9276 buffer-local value only if initializing for buffer iteration.
9277 (handle_invisible_prop): Support invisible properties on strings
9278 that are being bidi-reordered.
9279 (set_iterator_to_next): Support bidi reordering of C strings and
9280 Lisp strings.
9281 (next_element_from_string): Support bidi reordering of Lisp
9282 strings.
9283 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9284 (display_string): Support display of R2L glyph rows.
9285 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9286 (init_iterator): Don't initialize it->bidi_p for strings
9287 here.
9288 (reseat_to_string): Initialize it->bidi_p for strings here.
9289 (next_element_from_string, next_element_from_c_string)
9290 (next_element_from_buffer): Add xassert's for correspondence
9291 between IT's object being iterated and it->bidi_it.string
9292 structure.
9293 (face_before_or_after_it_pos): Support bidi iteration.
9294 (next_element_from_c_string): Handle the case of the first string
9295 character that is not the first one in the visual order.
9296 (get_visually_first_element): New function, refactored from common
9297 parts of next_element_from_buffer, next_element_from_string, and
9298 next_element_from_c_string.
9299 (tool_bar_lines_needed, redisplay_tool_bar)
9300 (display_menu_bar): Force left-to-right direction. Add a FIXME
9301 comment for making that be controlled by a user option.
9302 (push_it, pop_it): Save and restore the state of the
9303 bidi iterator. Save and restore the bidi_p flag.
9304 (pop_it): Iterate out of display property for string iteration as
9305 well.
9306 (iterate_out_of_display_property): Support iteration over strings.
9307 (handle_single_display_spec): Set up it->bidi_it for iteration
9308 over a display string, and call bidi_init_it.
9309 (handle_single_display_spec, next_overlay_string)
9310 (get_overlay_strings_1, push_display_prop): Set up the bidi
9311 iterator for displaying display or overlay strings.
9312 (forward_to_next_line_start): Don't use the shortcut if
9313 bidi-iterating.
9314 (back_to_previous_visible_line_start): If handle_display_prop
9315 pushed the iterator stack, restore the internal state of the bidi
9316 iterator by calling bidi_pop_it same number of times.
9317 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9318 and we are bidi-iterating, don't decrement the iterator position;
9319 instead, set the first_elt flag in the bidi iterator, to produce
9320 the same effect.
9321 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9322 (push_display_prop): xassert that we are iterating a buffer.
9323 (push_it, pop_it): Save and restore paragraph_embedding member.
9324 (handle_single_display_spec, next_overlay_string)
9325 (get_overlay_strings_1, reseat_1, reseat_to_string)
9326 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9327 correctly. Don't assume unibyte strings are not bidi-reordered.
9328 (compute_display_string_pos)
9329 (compute_display_string_end): Fix handling the case of C string.
9330 (push_it, pop_it): Save and restore from_disp_prop_p.
9331 (handle_single_display_spec, push_display_prop): Set the
9332 from_disp_prop_p flag.
9333 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9334 (pop_it): Call iterate_out_of_display_property only if we are
9335 popping after iteration over a string that came from a display
9336 property. Fix a typo in popping stretch info. Add an assertion
9337 for verifying that the iterator position is in sync with the bidi
9338 iterator.
9339 (handle_single_display_spec, get_overlay_strings_1)
9340 (push_display_prop): Fix initialization of paragraph direction for
9341 string when that of the parent object is not yet determined.
9342 (reseat_1): Call bidi_init_it to resync the bidi
9343 iterator with IT's position. (Bug#7616)
9344 (find_row_edges): If ROW->start.pos gives position
9345 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9346 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9347 Reset the from_disp_prop_p flag.
9348 (SAVE_IT, RESTORE_IT): New macros.
9349 (pos_visible_p, face_before_or_after_it_pos)
9350 (back_to_previous_visible_line_start)
9351 (move_it_in_display_line_to, move_it_in_display_line)
9352 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9353 (try_scrolling, redisplay_window, display_line): Use them when
9354 saving a temporary copy of the iterator and restoring it back.
9355 (back_to_previous_visible_line_start, reseat_1)
9356 (init_iterator): Empty the bidi cache "stack".
9357 (move_it_in_display_line_to): If iterator ended up at
9358 EOL, but we never saw any buffer positions smaller than
9359 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9360 motion in bidi-reordered lines.
9361 (move_it_in_display_line_to): Record prev_method and prev_pos
9362 immediately before the call to set_iterator_to_next. Fixes cursor
9363 motion in bidi-reordered lines with stretch glyphs and strings
9364 displayed in margins. (Bug#8133) (Bug#8867)
9365 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9366 TO_CHARPOS.
640c8776
SM
9367 (pos_visible_p): Support positions in bidi-reordered lines.
9368 Save and restore bidi cache.
0bb23927
EZ
9369
9370 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9371 (bidi_paragraph_info): Delete unused struct.
9372 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9373 (bidi_cache_start): New variable.
9374 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9375 to zero.
9376 (bidi_cache_fetch_state, bidi_cache_search)
9377 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9378 (bidi_cache_find, bidi_peek_at_next_level)
9379 (bidi_level_of_next_char, bidi_find_other_level_edge)
9380 (bidi_move_to_visually_next): Compare cache index with
9381 bidi_cache_start rather than with zero.
9382 (bidi_fetch_char): Accept new argument STRING; all callers
9383 changed. Support iteration over a string. Support strings with
9384 display properties. Support unibyte strings. Fix the type of
9385 `len' according to what STRING_CHAR_AND_LENGTH expects.
9386 (bidi_paragraph_init, bidi_resolve_explicit_1)
9387 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9388 (bidi_level_of_next_char, bidi_move_to_visually_next):
9389 Support iteration over a string.
0bb23927
EZ
9390 (bidi_set_sor_type, bidi_resolve_explicit_1)
9391 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9392 can now be zero (for strings); special values 0 and -1 were
9393 changed to -1 and -2, respectively.
9394 (bidi_char_at_pos): New function.
9395 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9396 Call it instead of FETCH_MULTIBYTE_CHAR.
9397 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9398 initialized to valid values.
9399 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9400 values.
9401 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9402 the test for valid cached positions. Fix the logic for looking up
9403 the sentinel state in the cache. GCPRO the Lisp string we are
9404 iterating.
9405 (bidi_push_it, bidi_pop_it): New functions.
9406 (bidi_initialize): Initialize the bidi cache start stack pointer.
9407 (bidi_cache_ensure_space): New function, refactored from part of
9408 bidi_cache_iterator_state. Don't assume the required size is just
9409 one BIDI_CACHE_CHUNK away.
9410 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9411 (bidi_count_bytes, bidi_char_at_pos): New functions.
9412 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9413 always valid if bidi_cache_idx is valid.
9414 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9415 is valid if it's going to be used.
9416 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9417 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9418 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9419 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9420 (bidi_find_other_level_edge, bidi_cache_start_stack):
9421 All variables related to cache indices are now EMACS_INT.
c965adc5 9422
0bb23927
EZ
9423 * dispextern.h (struct bidi_string_data): New structure.
9424 (struct bidi_it): New member `string'. Make flag members be 1-bit
9425 fields, and put them last in the struct.
640c8776
SM
9426 (compute_display_string_pos, compute_display_string_end):
9427 Update prototypes.
0bb23927
EZ
9428 (bidi_push_it, bidi_pop_it): Add prototypes.
9429 (struct iterator_stack_entry): New members bidi_p,
9430 paragraph_embedding, and from_disp_prop_p.
9431 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9432 (bidi_shelve_cache, bidi_unshelve_cache):
9433 Declare prototypes.
0bb23927
EZ
9434
9435 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9436 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9437 and vector-like objects.
9438
9439 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9440 cache around display iteration.
9441
9442 * window.c (Fwindow_end, window_scroll_pixel_based)
9443 (displayed_window_lines, Frecenter): Save and restore the bidi
9444 cache around display iteration.
9445
3bbd2265
LMI
94462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9447
9448 * editfns.c (Fdelete_region): Clarify the use of the named
9449 parameters (bug#6788).
9450
adc47434
MR
94512011-07-14 Martin Rudalics <rudalics@gmx.at>
9452
9453 * indent.c (Fvertical_motion): Set and restore w->pointm when
9454 saving and restoring the window's buffer (Bug#9006).
9455
837c31f8
LMI
94562011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9457
9458 * editfns.c (Fstring_to_char): Clarify just what is returned
9459 (bug#6576). Text by Eli Zaretskii.
9460
ac389d0c
JB
94612011-07-13 Juanma Barranquero <lekktu@gmail.com>
9462
9463 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9464
0be0ce47
EZ
94652011-07-13 Eli Zaretskii <eliz@gnu.org>
9466
9467 * buffer.c (mmap_find): Fix a typo.
9468
cd18e7e3
JB
94692011-07-13 Johan Bockgård <bojohan@gnu.org>
9470
9471 Fix execution of x selection hooks.
9472 * xselect.c (Qx_lost_selection_functions)
9473 (Qx_sent_selection_functions): New vars.
9474 (syms_of_xselect): DEFSYM them.
9475 (x_handle_selection_request): Pass Qx_sent_selection_functions
9476 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9477 (x_handle_selection_clear,x_clear_frame_selections):
9478 Pass Qx_lost_selection_functions rather than
9479 Vx_lost_selection_functions to Frun_hook_with_args.
9480
47ea7f44
PE
94812011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9482
ac389d0c 9483 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9484 The old code sometimes used this field without initializing it.
9485
47ea7f44
PE
9486 * alloc.c (gc_sweep): Don't read past end of array.
9487 In theory, the old code could also have corrupted Emacs internals,
9488 though it'd be very unlikely.
9489
bc985c87
AS
94902011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9491
9492 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9493 argument. (Bug#4026)
bc985c87 9494
0cf34688
LMI
94952011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9496
b3dadd76
LMI
9497 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9498 key" (bug#4257).
9499
0cf34688
LMI
9500 * window.c (Fset_window_start): Doc fix (bug#4199).
9501 (Fset_window_hscroll): Ditto.
9502
270768cd
PE
95032011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9504
077e3dda 9505 Fix minor new problems caught by GCC 4.6.1.
270768cd 9506 * term.c (init_tty): Remove unused local.
490011a6 9507 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9508 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9509 not used otherwise.
270768cd 9510
b1f58454
CY
95112011-07-12 Chong Yidong <cyd@stupidchicken.com>
9512
9513 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9514
22b9578d
LMI
95152011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9516
6e70ab07
LMI
9517 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9518 are the mini-buffer and the echo area (bug#3320).
9519
22b9578d
LMI
9520 * term.c (init_tty): Remove support for supdup, c10 and perq
9521 terminals, which are no longer supported (bug#1482).
9522
8974cc9f
JB
95232011-07-10 Johan Bockgård <bojohan@gnu.org>
9524
9525 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9526
a560d974
JD
95272011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9528
9529 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9530 for non-popups (Bug#3642).
9531
1dae0f0a
AS
95322011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9533
268c2c36 9534 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9535 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9536 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9537 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9538 * data.c (fmod): Likewise.
9539 * dispnew.c (swap_glyphs_in_rows): Likewise.
9540 * emacs.c (memory_warning_signal): Likewise.
9541 * floatfns.c (float_error): Likewise.
9542 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9543 (otf_open, font_otf_capability, generate_otf_features)
9544 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9545 Likewise.
9546 * image.c (pbm_read_file): Likewise.
9547 * indent.c (string_display_width): Likewise.
9548 * intervals.c (check_for_interval, search_for_interval)
9549 (inc_interval_count, count_intervals, root_interval)
9550 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9551 * lread.c (defalias): Likewise.
268c2c36 9552 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9553 * regex.c (set_image_of_range_1, set_image_of_range)
9554 (regex_grow_registers): Likewise.
9555 * sysdep.c (strerror): Likewise.
9556 * termcap.c (valid_filename_p, tprint, main): Likewise.
9557 * tparam.c (main): Likewise.
9558 * unexhp9k800.c (run_time_remap, save_data_space)
9559 (update_file_ptrs, read_header, write_header, calculate_checksum)
9560 (copy_file, copy_rest, display_header): Likewise.
9561 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9562 Likewise.
9563 * xdisp.c (check_it): Likewise.
9564 * xfaces.c (register_color, unregister_color, unregister_colors):
9565 Likewise.
9566 * xfns.c (print_fontset_result): Likewise.
9567 * xrdb.c (member, fatal, main): Likewise.
9568
99033785
PE
95692011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9570
9571 Fix minor problems found by static checking (Bug#9031).
9572 * chartab.c (char_table_set_range, map_sub_char_table):
9573 Remove unused locals.
9574 (uniprop_table): Now static.
9575 * composite.c (_work_char): Remove unused static var.
9576
9cb2ac56
JB
95772011-07-09 Juanma Barranquero <lekktu@gmail.com>
9578
9579 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9580
f25661f0
JD
95812011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9582
9583 * gtkutil.c (qttip_cb): Remove code without function.
9584
8278c4fe
EZ
95852011-07-09 Eli Zaretskii <eliz@gnu.org>
9586
9587 * w32.c (pthread_sigmask): New stub.
9588
1692ae2d 95892011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9590
8a6ebd58 9591 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9592 sigprocmask is portable only for single-threaded applications, and
9593 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9594 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9595 (LIBES): Use it.
9596 * callproc.c (Fcall_process):
9597 * process.c (create_process):
9598 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9599 Use pthread_sigmask, not sigprocmask.
123403e4 9600
1b854618
JD
96012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9602
9603 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9604 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9605 wrong (Bug#8591).
9606
3fe4b549
JD
96072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9608
0ce7e563
JD
9609 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9610 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9611 (xg_hide_tooltip): Fix comment.
9612
3fe4b549
JD
9613 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9614 in registerServicesMenuSendTypes.
9615 (validRequestorForSendType): Don't check ns_return_types.
9616
9617 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9618 ns_return_type.
9619
5df75e47
JR
96202011-07-08 Jason Rumney <jasonr@gnu.org>
9621
22610910
JR
9622 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9623 SH_SHOW for hidden windows (Bug#5482).
9624
5df75e47
JR
9625 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9626 frame struct members of non-existent frames (Bug#6284).
9627
699c10bd
JD
96282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9629
4393663b
JD
9630 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9631 variable firstTime not needed on OSX >= 10.6.
9632 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9633 >= 10.5. Use setKnobProportion, setDoubleValue.
9634
9635 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9636 (MAC_OS_X_VERSION_10_5): Define if not defined.
9637 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9638 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9639 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9640
9641 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9642 cString and lossyCString on OSX >= 10.4.
4393663b 9643
58179cce 9644 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9645 sizeToFit on OSX >= 10.2.
9646
9647 * nsimage.m (allocInitFromFile): Don't use deprecated method
9648 bestRepresentationForDevice on OSX >= 10.6.
9649
9650 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9651 to avoid warning.
9652
9653 * emacs.c: Declare unexec_init_emacs_zone.
9654
a63e0781
JD
9655 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9656
699c10bd
JD
9657 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9658
9659 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9660 on svcsMenu (Bug#8842).
9661
9662 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9663 ns_return_types.
9664 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9665
9666 * nsterm.m (QUTF8_STRING): Declare.
9667 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9668 (validRequestorForSendType): Return type is (id).
9669 Change indexOfObjectIdenticalTo to indexOfObject.
9670 Check if we have local selection before returning self (Bug#8842).
9671 (writeSelectionToPasteboard): Put local selection into paste board
9672 if we have a local selection (Bug#8842).
9673 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9674
9675 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9676 (ns_get_local_selection): Declare.
9677
54e10184
LMI
96782011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9679
9888ff71
LMI
9680 * keymap.c (describe_map_tree): Don't insert a double newline at
9681 the end of the buffer (bug#1169) and return whether we inserted
9682 something.
9683
54e10184
LMI
9684 * callint.c (Fcall_interactively): Change "reading args" to
9685 "providing args" to try to clarify what it does (bug#1010).
9686
15fa4783
KH
96872011-07-07 Kenichi Handa <handa@m17n.org>
9688
9689 * composite.c (composition_compute_stop_pos): Ignore a static
9690 composition starting before CHARPOS (Bug#8915).
9691
9692 * xdisp.c (handle_composition_prop): Likewise.
9693
a8815b00
EZ
96942011-07-07 Eli Zaretskii <eliz@gnu.org>
9695
9696 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9697 (Bug#9015)
9698
ef7b981d 96992011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9700
9701 * character.h (unicode_category_t): New enum type.
9702
9703 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9704 (Qchar_code_property_table): New variable.
9705 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9706 (UNIPROP_COMPRESSED_FORM_P): New macros.
9707 (char_table_ascii): Uncompress the compressed values.
9708 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9709 Uncompress the compressed values.
ac389d0c 9710 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9711 (char_table_ref_and_range): Uncompress the compressed values.
9712 (sub_char_table_set): New arg is_uniprop. Callers changed.
9713 Uncompress the compressed values.
9714 (sub_char_table_set_range): Args changed. Callers changed.
9715 (char_table_set_range): Adjuted for the above change.
9716 (map_sub_char_table): Delete args default_val and parent. Add arg
9717 top. Give decoded values to a Lisp function.
640c8776 9718 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9719 values to a Lisp function. Gcpro more variables.
9720 (uniprop_table_uncompress)
9721 (uniprop_decode_value_run_length): New functions.
9722 (uniprop_decoder, uniprop_decoder_count): New variables.
9723 (uniprop_get_decoder, uniprop_encode_value_character)
9724 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9725 New functions.
9726 (uniprop_encoder, uniprop_encoder_count): New variables.
9727 (uniprop_get_encoder, uniprop_table)
9728 (Funicode_property_table_internal, Fget_unicode_property_internal)
9729 (Fput_unicode_property_internal): New functions.
9730 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9731 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9732 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9733 char-code-property-alist.
9734
640c8776 9735 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9736 Vunicode_category_table.
9737
640c8776 9738 * font.c (font_range): Adjust for the change of
c805dec0
KH
9739 Vunicode_category_table.
9740
76b397fb
DN
97412011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9742
9743 * m/iris4d.h: Remove file, move contents ...
9744 * s/irix6-5.h: ... here.
9745
22b4128e
PE
97462011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9747
9748 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9749 * alloc.c (mark_buffer):
9750 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9751 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9752 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9753 This isn't true in general, and it's particularly not true
9754 if Emacs is configured with --with-wide-int.
9755 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9756 New macros, used in the buffer.c change.
9757
869795d6
JD
97582011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9759
9760 * xsettings.c: Use both GConf and GSettings if both are available.
9761 (store_config_changed_event): Add comment.
9762 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9763 (store_tool_bar_style_changed): New functions.
5e617bc2 9764 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9765 (struct xsettings): Move font inside HAVE_XFT.
9766 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9767 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9768 Move inside HAVE_XFT.
640c8776 9769 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9770 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9771 also.
9772 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9773 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9774 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9775 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9776 (parse_settings): Move check for font inside HAVE_XFT.
9777 (read_settings, apply_xft_settings): Add comment.
9778 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9779 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9780 call store_font_name_changed.
9781 (xft_settings_event): Add comment.
9782 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9783 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9784 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9785 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9786 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9787 (xsettings_get_system_font, xsettings_get_system_normal_font):
9788 Add comment.
869795d6 9789
d8ed26bd
PE
97902011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9791
9792 Random fixes. E.g., (random) never returned negative values.
9793 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9794 subseconds part to the entropy, as that's a bit more random.
9795 Prefer signed to unsigned, since the signedness doesn't matter and
9796 in general we prefer signed. When given a limit, use a
9797 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9798 latter isn't right if USE_2_TAGS_FOR_INTS.
9799 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9800 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9801
cabf1cac
SM
98022011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9803
9804 * textprop.c (text_property_stickiness):
9805 Obey Vtext_property_default_nonsticky.
9806 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9807 * w32fns.c (syms_of_w32fns):
9808 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9809
6e9b2be9
PE
98102011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9811
9812 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9813 This is more efficient than Ffile_directory_p and avoids a minor race.
9814
90186c68
LMI
98152011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9816
7c301272
LMI
9817 * buffer.c (Foverlay_put): Say what the return value is
9818 (bug#7835).
9819
c4f2d8d4
LMI
9820 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9821 is a directory before asking whether to use the file name
9822 (bug#7564).
ad637907
LMI
9823 (barf_or_query_if_file_exists): Make the "File is a directory"
9824 error be more correct.
c4f2d8d4 9825
90186c68
LMI
9826 * fns.c (Frequire): Remove the mention of the .gz files, since
9827 that's installation-specific, but keep the mention of
9828 `get-load-suffixes'.
9829
da64016e
PE
98302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9831
9832 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9833 Report string overflow if the output is too long.
9834
7d47b580
JB
98352011-07-04 Juanma Barranquero <lekktu@gmail.com>
9836
a555cb87
JB
9837 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9838 (syms_of_gnutls): Remove duplicate DEFSYM for
9839 Qgnutls_bootprop_verify_hostname_error, an error for
9840 Qgnutls_bootprop_verify_error (which is no longer used).
9841
7d47b580
JB
9842 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9843 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9844 Also (re)move comments that are misplaced or no longer relevant.
9845
1e49bfab
LMI
98462011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9847
9848 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9849
1485f4c0
CY
98502011-07-03 Chong Yidong <cyd@stupidchicken.com>
9851
9852 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9853 and background color parameters if they have been changed.
9854
a9ab721e
LMI
98552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9856
9857 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9858
cf7cff57
PE
98592011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9860
2e13213d
PE
9861 * xsettings.c (SYSTEM_FONT): Define only when used.
9862 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9863
cf7cff57
PE
9864 * keymap.c (access_keymap_1): Now static.
9865
7a8e04f7
CY
98662011-07-02 Chong Yidong <cyd@stupidchicken.com>
9867
9868 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9869 leave any prefix arg for the up event (Bug#1586).
9870
61352f62
LMI
98712011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9872
69bb1ef7
LMI
9873 * lread.c (syms_of_lread): Mention single symbols defined by
9874 `defvar' or `defconst' (bug#7154).
9875
61352f62 9876 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9877 (Frequire): Mention get-load-suffixes.
61352f62 9878
28545e04
MR
98792011-07-02 Martin Rudalics <rudalics@gmx.at>
9880
9881 * window.h (window): Remove clone_number slot.
9882 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9883 Remove.
9884 (make_parent_window, make_window, saved_window)
9885 (Fset_window_configuration, save_window_save): Don't deal with
9886 clone numbers.
9887 * buffer.c (Qclone_number): Remove declaration.
9888 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9889
3349e122
SM
98902011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9891
9892 Add multiple inheritance to keymaps.
9893 * keymap.c (Fmake_composed_keymap): New function.
9894 (Fset_keymap_parent): Simplify.
9895 (fix_submap_inheritance): Remove.
9896 (access_keymap_1): New function extracted from access_keymap to handle
9897 embedded parents and handle lists of maps.
9898 (access_keymap): Use it.
9899 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9900 (Fcopy_keymap): Handle embedded parents.
9901 (Fcommand_remapping, define_as_prefix): Simplify.
9902 (Fkey_binding): Simplify.
9903 (syms_of_keymap): Move minibuffer-local-completion-map,
9904 minibuffer-local-filename-completion-map,
9905 minibuffer-local-must-match-map, and
9906 minibuffer-local-filename-must-match-map to Elisp.
9907 (syms_of_keymap): Defsubr make-composed-keymap.
9908 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9909 (parse_menu_item): Trivial simplification.
9910
3279eb87
GM
99112011-07-01 Glenn Morris <rgm@gnu.org>
9912
9913 * Makefile.in (SETTINGS_LIBS): Fix typo.
9914
4550efdf
KI
99152011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9916
9917 * coding.c (Fencode_coding_string): Record the last coding system
9918 used, as the function doc string says (bug#8738).
9919
0949d2b6
JD
99202011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9921
9922 * xsettings.c (store_monospaced_changed): Take new font as arg and
9923 check for change against current_mono_font.
9924 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9925 (emacs_settings_constructor, emacs_settings_get_property)
9926 (emacs_settings_set_property, emacs_settings_class_init)
9927 (emacs_settings_init, gsettings_obj): Remove.
9928 (something_changedCB): New function for HAVE_GSETTINGS.
9929 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9930 with value as argument.
9931 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9932 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9933 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9934 "changed".
9935
9936 * xgselect.c: Add defined (HAVE_GSETTINGS).
9937 (xgselect_initialize): Ditto.
9938
9939 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9940 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9941 xg_select.
9942
bbc6b304
PE
99432011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9944
9945 * eval.c (struct backtrace): Simplify and port the data structure.
9946 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9947 signed bit field, as this assumption is not portable and it makes
9948 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9949 "char debug_on_exit : 1" as this is not portable either; instead,
9950 use the portable "unsigned int debug_on_exit : 1". Remove unused
9951 member evalargs. Remove obsolete comments about cc bombing out.
9952
9851bfc5
JD
99532011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9954
51bb811f 9955 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9956 Let HAVE_GSETTINGS override HAVE_GCONF.
9957 (store_monospaced_changed): New function.
9958 (EMACS_SETTINGS): A new type derived from GObject to handle
9959 GSettings notifications.
9960 (emacs_settings_constructor, emacs_settings_get_property)
9961 (emacs_settings_set_property, emacs_settings_class_init):
9962 New functions.
9963 (gsettings_client, gsettings_obj): New variables.
9964 (GSETTINGS_SCHEMA): New define.
9965 (something_changedCB): Call store_monospaced_changed.
9966 (init_gsettings): New function.
9967 (xsettings_initialize): Call init_gsettings.
9968 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9969 to NULL.
9970
640c8776 9971 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9972 GCONF_CFLAGS/LIBS.
9973
5386012d
MR
99742011-06-29 Martin Rudalics <rudalics@gmx.at>
9975
9976 * window.c (resize_root_window, grow_mini_window)
9977 (shrink_mini_window): Rename Qresize_root_window to
9978 Qwindow_resize_root_window and Qresize_root_window_vertically to
9979 Qwindow_resize_root_window_vertically.
9980
f13e0b08
PE
99812011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9982
9983 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9984
94515237
JB
99852011-06-27 Juanma Barranquero <lekktu@gmail.com>
9986
9987 * makefile.w32-in: Redesign dependencies so they reflect more
9988 clearly which files are directly included by each source file,
9989 and not through other includes.
9990
e43b6e43
MR
99912011-06-27 Martin Rudalics <rudalics@gmx.at>
9992
9993 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9994 (sort_overlays, overlay_strings): When an overlay's clone number
9995 matches the window's clone number process the overlay even if
9996 the overlay's window property doesn't match the current window.
9997
d68443dc
MR
9998 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9999 (Fwindow_hchild): Rename to Fwindow_left_child.
10000 (Fwindow_next): Rename to Fwindow_next_sibling.
10001 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10002 (resize_window_check): Rename to window_resize_check.
10003 (resize_window_apply): Rename to window_resize_apply.
10004 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10005 (Fdelete_other_windows_internal, resize_frame_windows)
10006 (Fsplit_window_internal, Fdelete_window_internal)
10007 (grow_mini_window, shrink_mini_window)
10008 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10009
c7e73be5
JD
100102011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10011
10012 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10013 (emacs_fixed_set_min_size): Remove.
10014 (emacs_fixed_new): Take frame as argument.
10015
10016 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10017 (_EmacsFixedPrivate): Remove minwidth/height.
10018 Add struct frame *f.
10019 (emacs_fixed_init): Initialize priv->f.
10020 (get_parent_class, emacs_fixed_set_min_size): Remove.
10021 (emacs_fixed_new): Set priv->f to argument.
10022 (emacs_fixed_get_preferred_width)
10023 (emacs_fixed_get_preferred_height): Use min_width/height from
10024 frames size_hint to set minimum and natural (Bug#8919).
10025 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10026 and use min_width/height from frames size_hint to set
10027 min_width/height (Bug#8919).
10028
10029 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10030 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10031 Fix indentation.
c7e73be5 10032
cf99dcf8
EZ
100332011-06-26 Eli Zaretskii <eliz@gnu.org>
10034
10035 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10036 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10037 called at ZV.
10038
029529ac
CY
100392011-06-26 Chong Yidong <cyd@stupidchicken.com>
10040
10041 * process.c (wait_reading_process_output): Bypass select if
10042 waiting for a cell while ignoring keyboard input, and input is
10043 pending. Suggested by Jan Djärv (Bug#8869).
10044
7a7ef429
PE
100452011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10046
10047 Use gnulib's dup2 module instead of rolling our own.
10048 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10049
11fdef7d 100502011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10051
10052 * dispnew.c (scrolling_window): Before scrolling, turn off a
10053 mouse-highlight in the window being scrolled.
10054
cd3520a4
JB
100552011-06-24 Juanma Barranquero <lekktu@gmail.com>
10056
10057 Move DEFSYM to lisp.h and use everywhere.
10058
10059 * character.h (DEFSYM): Move declaration...
10060 * lisp.h (DEFSYM): ...here.
10061
10062 * gnutls.c:
10063 * minibuf.c:
10064 * w32menu.c:
10065 * w32proc.c:
10066 * w32select.c: Don't include character.h.
10067
10068 * alloc.c (syms_of_alloc):
10069 * buffer.c (syms_of_buffer):
10070 * bytecode.c (syms_of_bytecode):
10071 * callint.c (syms_of_callint):
10072 * casefiddle.c (syms_of_casefiddle):
10073 * casetab.c (init_casetab_once):
10074 * category.c (init_category_once, syms_of_category):
10075 * ccl.c (syms_of_ccl):
10076 * cmds.c (syms_of_cmds):
10077 * composite.c (syms_of_composite):
10078 * dbusbind.c (syms_of_dbusbind):
10079 * dired.c (syms_of_dired):
10080 * dispnew.c (syms_of_display):
10081 * doc.c (syms_of_doc):
10082 * editfns.c (syms_of_editfns):
10083 * emacs.c (syms_of_emacs):
10084 * eval.c (syms_of_eval):
10085 * fileio.c (syms_of_fileio):
10086 * fns.c (syms_of_fns):
10087 * frame.c (syms_of_frame):
10088 * fringe.c (syms_of_fringe):
10089 * insdel.c (syms_of_insdel):
10090 * keymap.c (syms_of_keymap):
10091 * lread.c (init_obarray, syms_of_lread):
10092 * macros.c (syms_of_macros):
10093 * msdos.c (syms_of_msdos):
10094 * print.c (syms_of_print):
10095 * process.c (syms_of_process):
10096 * search.c (syms_of_search):
10097 * sound.c (syms_of_sound):
10098 * syntax.c (init_syntax_once, syms_of_syntax):
10099 * terminal.c (syms_of_terminal):
10100 * textprop.c (syms_of_textprop):
10101 * undo.c (syms_of_undo):
10102 * w32.c (globals_of_w32):
10103 * window.c (syms_of_window):
10104 * xdisp.c (syms_of_xdisp):
10105 * xfaces.c (syms_of_xfaces):
10106 * xfns.c (syms_of_xfns):
10107 * xmenu.c (syms_of_xmenu):
10108 * xsettings.c (syms_of_xsettings):
10109 * xterm.c (syms_of_xterm): Use DEFSYM.
10110
4228cf16
TZ
101112011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10112
cd3520a4 10113 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10114
7fcccf1e
PE
101152011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10116
7efb4e0e
PE
10117 Integer and buffer overflow fixes (Bug#8873).
10118
ff5844ad
PE
10119 * print.c (printchar, strout): Check for string overflow.
10120 (PRINTPREPARE, printchar, strout):
10121 Don't set size unless allocation succeeds.
10122
90532f02
PE
10123 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10124 for sizes. Check for string overflow more accurately.
10125 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10126
6d84508d
PE
10127 * macros.c: Integer and buffer overflow fixes.
10128 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10129 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10130 Use ptrdiff_t, not int, for sizes.
10131 Don't increment bufsize until after realloc succeeds.
10132 Check for size-calculation overflow.
10133 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10134
437b2cb4
PE
10135 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10136
8b9ac8b4
PE
10137 * lread.c: Integer overflow fixes.
10138 (read_integer): Radix is now EMACS_INT, not int,
10139 to improve quality of diagnostics for out-of-range radices.
10140 Calculate buffer size correctly for out-of-range radices.
10141 (read1): Check for integer overflow in radices, and in
10142 read-circle numbers.
82cb60d3
PE
10143 (read_escape): Avoid int overflow.
10144 (Fload, openp, read_buffer_size, read1)
10145 (substitute_object_recurse, read_vector, read_list, map_obarray):
10146 Use ptrdiff_t, not int, for sizes.
10147 (read1): Use EMACS_INT, not int, for sizes.
20270765 10148 Check for size overflow.
8b9ac8b4 10149
7fcccf1e
PE
10150 * image.c (cache_image): Check for size arithmetic overflow.
10151
bfbbd7e7
PE
10152 * lread.c: Integer overflow issues.
10153 (saved_doc_string_size, saved_doc_string_length)
10154 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10155 Now ptrdiff_t, not int.
10156 (read1): Don't assume doc string length fits in int. Check for
10157 out-of-range doc string lengths.
10158 (read_list): Don't assume file position fits in int.
39019e54 10159 (read_escape): Check for hex character overflow.
bfbbd7e7 10160
4e323265
LL
101612011-06-22 Leo Liu <sdl.web@gmail.com>
10162
10163 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10164 Move to minibuffer.el.
10165
85fece3e
PE
101662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10167
20b84ce9 10168 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10169 The following patches are for when GLYPH_DEBUG && !XASSERT.
10170 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10171 * dispnew.c (flush_stdout):
10172 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10173 Mark as externally visible.
10174 * dispnew.c (check_window_matrix_pointers): Now static.
10175 * dispnew.c (window_to_frame_vpos):
10176 * xfns.c (unwind_create_frame):
10177 * xterm.c (x_check_font): Remove unused local.
10178 * scroll.c (CHECK_BOUNDS):
10179 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10180 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10181 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10182 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10183 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10184 Now static.
10185 (debug_method_add): Use va_list and vsprintf rather than relying
10186 on undefined behavior with wrong number of arguments.
10187 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10188 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10189 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10190 since we're not interested in debugging glyphs with old libraries.
10191 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10192 GCC 4.6.0's static checking.
10193
0766b489
PE
101942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10195
31fd4b32
PE
10196 Integer overflow and signedness fixes (Bug#8873).
10197 A few related buffer overrun fixes, too.
10198
b79e8648
PE
10199 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10200
0766b489
PE
10201 * dispextern.h (struct face.stipple):
10202 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10203 (x_bitmap_mask, x_allocate_bitmap_record)
10204 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10205 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10206 (x_create_bitmap_from_xpm_data):
10207 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10208 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10209 (.bitmaps_last):
10210 * xfaces.c (load_pixmap):
10211 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10212 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10213 (.bitmaps_last, struct x_output.icon_bitmap):
10214 Use ptrdiff_t, not int, for bitmap indexes.
10215 (x_allocate_bitmap_record): Check for size overflow.
10216 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10217
b081724f
PE
10218 Use ptrdiff_t, not int, for overlay counts.
10219 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10220 * editfns.c (overlays_around, get_pos_property):
10221 * textprop.c (get_char_property_and_overlay):
10222 * xdisp.c (next_overlay_change, note_mouse_highlight):
10223 * xfaces.c (face_at_buffer_position):
21514da7
PE
10224 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10225 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10226 (Fnext_overlay_change, Fprevious_overlay_change)
10227 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10228 Use ptrdiff_t, not int, for sizes.
21514da7 10229 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10230
3de73e5e
PE
10231 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10232
2606c57b
PE
10233 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10234 (x_session_initialize): Do not assume string length fits in int.
10235
aaafe47a
PE
10236 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10237 This is unlikely, but can occur if DPI is outlandish.
10238
2674ddc8 10239 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10240 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10241
28154962
PE
10242 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10243 * xrdb.c (magic_file_p, search_magic_path):
10244 Omit last arg SUFFIX; it was always 0. All callers changed.
10245 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10246
7de51af5
PE
10247 * xfont.c (xfont_match): Avoid need for strlen.
10248
25ed6cc3
PE
10249 * xfns.c: Don't assume strlen fits in int.
10250 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10251
4eab31dd
PE
10252 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10253 not unsigned long, as we prefer signed integers. All callers changed.
10254 Detect integer overflow in repeat count.
10255 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10256 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10257
171e2a58
PE
10258 * termcap.c: Don't assume sizes fit in int and never overflow.
10259 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10260 (gobble_line): Check for size-calculation overflow.
10261
ad39faca 10262 * minibuf.c (Fread_buffer):
6e5bb2dc 10263 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10264 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10265 Don't assume string length fits in int.
10266
52c61c22 10267 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10268 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10269
b5b8c9e5
PE
10270 * font.c: Don't assume string length fits in int.
10271 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10272 Use ptrdiff_t, not int.
ccd6111c
PE
10273 (font_intern_prop): Don't assume string length fits in int.
10274 Don't assume integer property fits in fixnum.
10275 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10276
882f0d81 10277 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10278 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10279 Reformulate so as not to need the command string.
10280 Invoke gzip -cd rather than gunzip, as it's more portable.
10281 (lock_info_type, lock_file_1, lock_file):
10282 Don't assume pid_t and time_t fit in unsigned long.
10283 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10284 (current_lock_owner): Prefer signed type for sizes.
10285 Use memcpy, not strncpy, where memcpy is what is really wanted.
10286 Don't assume (via atoi) that time_t and pid_t fit in int.
10287 Check for time_t and/or pid_t out of range, e.g., via a network share.
10288 Don't alloca where an auto var works fine.
10289
93f4cf88
PE
10290 * fileio.c: Fix some integer overflow issues.
10291 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10292 Don't assume string length fits in int.
10293 (directory_file_name): Don't assume string length fits in long.
10294 (make_temp_name): Don't assume pid fits in int, or that its print
10295 length is less than 20.
10296
f3e92b69
PE
10297 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10298
1bfdaf10
PE
10299 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10300
35016e9a
PE
10301 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10302
3d1e65a1
PE
10303 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10304 We prefer signed integers, even for size calculations.
10305
0b963a93
PE
10306 * emacs.c: Don't assume string length fits in 'int'.
10307 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10308 (main): Don't invoke strlen when not needed.
10309
573f4b54
PE
10310 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10311 (XD_DEBUG_MESSAGE): Don't waste a byte.
10312
989f33ba
PE
10313 * callproc.c (getenv_internal_1, getenv_internal)
10314 (Fgetenv_internal):
965d34eb
PE
10315 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10316
e4d29b33
PE
10317 * lread.c (invalid_syntax): Omit length argument.
10318 All uses changed. This doesn't fix a bug, but it simplifies the
10319 code away from its former Hollerith-constant appearance, and it's
10320 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10321 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10322
eb49b136
PE
10323 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10324 This didn't break anything, but it didn't help either.
10325 It's confusing to put a bogus integer in a place where the actual
10326 value does not matter.
9f62aeb1 10327 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10328 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10329
15375a22
PE
10330 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10331 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10332 implementation.
b61cc01c
PE
10333 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10334 We prefer signed types, and the value cannot exceed the EMACS_INT
10335 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10336 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10337 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10338 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10339
53b2623d
PE
10340 * indent.c (sane_tab_width): New function.
10341 (current_column, scan_for_column, Findent_to, position_indentation)
10342 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10343 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10344
51cab52b 10345 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10346
f2ed8a70
PE
10347 * lisp.h (lint_assume): New macro.
10348 * composite.c (composition_gstring_put_cache):
10349 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10350
abe80cc6
PE
10351 * editfns.c, insdel.c:
10352 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10353
b02c740e
PE
10354 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10355
ebc96716
PE
10356 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10357
b4e50fa0 10358 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10359 Use much-faster test for byte-length change.
311d5d7c 10360 Don't assume string byte-length fits in 'int'.
a4cf38e4 10361 Check that character arg fits in 'int'.
85461888 10362 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10363
c0c1ee9f
PE
10364 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10365
a498d7f4
PE
10366 * fns.c (concat): Catch string overflow earlier.
10367 Do not rely on integer wraparound.
10368
51cab52b
PE
10369 * dispextern.h (struct it.overlay_strings_charpos)
10370 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10371 * xdisp.c (forward_to_next_line_start)
10372 (back_to_previous_visible_line_start)
10373 (reseat_at_next_visible_line_start, next_element_from_buffer):
10374 Don't arbitrarily truncate the value of 'selective' to int.
10375
76031fad
PE
10376 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10377
5eb55db9
PE
10378 * composite.c: Don't truncate sizes to 'int'.
10379 (composition_gstring_p, composition_reseat_it)
10380 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10381 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10382 not EMACS_UINT, for indexes.
5eb55db9 10383
0703a717
PE
10384 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10385
d6202519
PE
10386 * buffer.c: Include <verify.h>.
10387 (struct sortvec.priority, struct sortstr.priority):
8961a454 10388 Now EMACS_INT, not int.
c20998a7 10389 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10390 (struct sortstr.size, record_overlay_string)
10391 (struct sortstrlist.size, struct sortlist.used):
10392 Don't truncate size to int.
10393 (record_overlay_string): Check for size-calculation overflow.
d6202519 10394 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10395
d5a19415
JM
103962011-06-22 Jim Meyering <meyering@redhat.com>
10397
029529ac 10398 Don't leak an XBM-image-sized buffer
d5a19415
JM
10399 * image.c (xbm_load): Free the image buffer after using it.
10400
a9041e6c
PE
104012011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10402
10403 Port to Sun C.
10404 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10405 that Sun C diagnosed.
10406 * fns.c (secure_hash): Fix pointer signedness issue.
10407 * intervals.c (static_offset_intervals): New function.
10408 (offset_intervals): Use it.
10409
7f3f739f
LL
104102011-06-21 Leo Liu <sdl.web@gmail.com>
10411
10412 * deps.mk (fns.o):
10413 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10414 sha512.h.
10415
10416 * fns.c (secure_hash): Rename from crypto_hash_function and change
10417 the first arg to accept symbols.
5b66d427 10418 (Fsecure_hash): New primitive.
7f3f739f
LL
10419 (syms_of_fns): New symbols.
10420
76147d94
DD
104212011-06-20 Deniz Dogan <deniz@dogan.se>
10422
10423 * process.c (Fset_process_buffer): Clarify return value in
10424 docstring.
10425
7d7d0045
CY
104262011-06-18 Chong Yidong <cyd@stupidchicken.com>
10427
10428 * dispnew.c (add_window_display_history): Use BVAR.
10429
10430 * xdisp.c (debug_method_add): Use BVAR.
10431 (check_window_end, dump_glyph_matrix, dump_glyph)
10432 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10433
10434 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10435 Likewise.
10436
10437 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10438 check till after the cache is created in init_frame_faces.
10439
ff2bc410
SM
104402011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10441
10442 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10443
28177add
PE
104442011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10445
dd3482fe
PE
10446 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10447 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10448 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10449
393d71f3 10450 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10451 * fileio.c (Finsert_file_contents):
10452 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10453 Remove the old (too-loose) buffer overflow checks.
10454 They weren't needed, since make_gap checks for buffer overflow.
10455 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10456 The old code merely checked for Emacs fixnum overflow, and relied
10457 on undefined (wraparound) behavior. The new code avoids undefined
10458 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10459
2e6813b0 10460 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10461 Tune. Don't use wider integers than needed. Don't use alloca.
10462 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10463
599a9e4f
PE
10464 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10465
99561444
PE
10466 * insdel.c, lisp.h (buffer_overflow): New function.
10467 (insert_from_buffer_1, replace_range, replace_range_2):
10468 * insdel.c (make_gap_larger):
10469 * editfns.c (Finsert_char):
10470 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10471
28177add
PE
10472 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10473
e69dafad
PE
104742011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10475
4baa020d 10476 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10477
b1c46f02
PE
10478 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10479 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10480
e69dafad
PE
10481 * fileio.c: Don't assume EMACS_INT fits in off_t.
10482 (emacs_lseek): New static function.
10483 (Finsert_file_contents, Fwrite_region): Use it.
10484 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10485
566684ea
PE
10486 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10487
e6966cd6
PE
10488 * fns.c: Don't overflow int when computing a list length.
10489 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10490 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10491 truncation on 64-bit hosts. Check for QUIT every
10492 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10493 faster and is responsive enough.
10494 (Flength): Report an error instead of overflowing an integer.
10495 (Fsafe_length): Return a float if the value is not representable
10496 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10497 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10498 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10499
dd0b0efb
PE
10500 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10501 (header_size, word_size): New constants.
10502 (allocate_vectorlike): Don't check size overflow here.
10503 (allocate_vector): Check it here instead, since this is the only
10504 caller of allocate_vectorlike that could cause overflow.
10505 Check that the new vector's length is representable as a fixnum.
10506
86fe5cfe
PE
10507 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10508 The previous code was bogus. For example, next_almost_prime (32)
10509 returned 39, which is undesirable as it is a multiple of 3; and
10510 next_almost_prime (24) returned 25, which is a multiple of 5 so
10511 why was the code bothering to check for multiples of 7?
10512
80e88859
PE
10513 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10514
4a2f0ad6
PE
10515 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10516
f66c7cf8
PE
10517 Variadic C functions now count arguments with ptrdiff_t.
10518 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10519 Back then I didn't know that the Emacs coding style prefers signed int.
10520 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10521 were being counted with int, which may truncate counts on 64-bit
10522 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10523 * lisp.h (struct Lisp_Subr.function.aMANY)
10524 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10525 Arg counts are now ptrdiff_t, not size_t.
10526 All variadic functions and their callers changed accordingly.
10527 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10528 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10529 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10530 * callint.c (Fcall_interactively): Check arg count for overflow,
10531 to avoid potential buffer overrun. Use signed char, not 'int',
10532 for 'varies' array, so that we needn't bother to check its size
10533 calculation for overflow.
10534 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10535 * eval.c (apply_lambda):
10536 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10537 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10538 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10539
a1759b76
PE
10540 * callint.c (Fcall_interactively): Don't use index var as event count.
10541
d96be9fc
PE
10542 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10543 * mem-limits.h (SIZE): Remove; no longer used.
10544
a690a978 10545 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10546
578c21e6
PE
10547 Remove unnecessary casts.
10548 * xterm.c (x_term_init):
10549 * xfns.c (x_set_border_pixel):
10550 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10551 These aren't needed now that we assume ANSI C.
10552
96f53c6c
PE
10553 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10554 It's more likely to cause problems (due to unsigned overflow)
10555 than to cure them.
10556
83c77d31
PE
10557 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10558
ee2079f1
PE
10559 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10560
6da65536
PE
10561 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10562
7147c4a4
PE
10563 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10564
193e32d9
PE
10565 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10566
e5533da6
PE
10567 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10568
9910e595
PE
10569 GLYPH_CODE_FACE returns EMACS_INT, not int.
10570 * dispextern.h (merge_faces):
10571 * xfaces.c (merge_faces):
01103c44
PE
10572 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10573 Don't assume EMACS_INT fits in int.
9910e595 10574
2638320e
PE
10575 * character.h (CHAR_VALID_P): Remove unused parameter.
10576 * fontset.c, lisp.h, xdisp.c: All uses changed.
10577
045eb8d9
PE
10578 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10579
c1f134b5
PE
10580 * fns.c (concat): Minor tuning based on overflow analysis.
10581 This doesn't fix any bugs. Use int to hold character, instead
10582 of constantly refetching from Emacs object. Use XFASTINT, not
10583 XINT, for value known to be a character. Don't bother comparing
10584 a single byte to 0400, as it's always less.
10585
395fcb93 10586 * floatfns.c (Fexpt):
327eeec8
PE
10587 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10588
abbd3d23
PE
10589 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10590 for characters.
10591
684a03ef
PE
10592 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10593
0fed43f3
PE
10594 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10595 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10596 incorrectly succeed when S was a string, because 4294967386 was
10597 truncated before it was used.
10598
8fd02eb7
PE
10599 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10600 Otherwise, an out-of-range integer could cause undefined behavior
10601 on a 64-bit host.
10602
f8c86b69
PE
10603 * composite.c: Use int, not EMACS_INT, for characters.
10604 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10605 EMACS_INT, for values that are known to be in character range.
10606 This doesn't fix any bugs but is the usual style inside Emacs and
10607 may generate better code on 32-bit machines.
10608
34206dd2
PE
10609 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10610 This is for reasons similar to the recent CHAR_STRING fix.
10611 * charset.c (Fencode_char): Check that character arg is actually
10612 a character. Pass an int to ENCODE_CHAR.
10613 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10614 wider than 'int', as a compile-time check to prevent future regressions
10615 in this area.
10616
c5958d4c 10617 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10618
10619 Make sure a 64-bit char is never passed to CHAR_STRING.
10620 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10621 by silently ignoring the top 32 bits, allowing some values
10622 that were far too large to be valid characters.
10623 * character.h: Include <verify.h>.
10624 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10625 arguments are no wider than unsigned, as a compile-time check
10626 to prevent future regressions in this area.
10627 * data.c (Faset):
01103c44 10628 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10629 (Fsubst_char_in_region):
10630 * fns.c (concat):
10631 * xdisp.c (decode_mode_spec_coding):
10632 Adjust to CHAR_STRING's new requirement.
10633 * editfns.c (Finsert_char, Fsubst_char_in_region):
10634 * fns.c (concat): Check that character args are actually
10635 characters. Without this test, these functions did the wrong
10636 thing with wildly out-of-range values on 64-bit hosts.
10637
d37ca623
PE
10638 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10639 These casts should not be needed on 32-bit hosts, either.
10640 * keyboard.c (read_char):
10641 * lread.c (Fload): Remove casts to unsigned.
10642
ea204efb
PE
10643 * lisp.h (UNSIGNED_CMP): New macro.
10644 This fixes comparison bugs on 64-bit hosts.
10645 (ASCII_CHAR_P): Use it.
10646 * casefiddle.c (casify_object):
01103c44 10647 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10648 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10649 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10650 * dispextern.h (FACE_FROM_ID):
10651 * keyboard.c (read_char): Use UNSIGNED_CMP.
10652
41cb286c
PE
10653 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10654 not to EMACS_INT, to avoid GCC warning.
10655
4a1b9832
PE
10656 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10657
55daad71
PE
10658 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10659 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10660 isn't needed on 32-bit machines.
8f95c75c 10661
01103c44
PE
10662 * buffer.c (Fgenerate_new_buffer_name):
10663 Use EMACS_INT for count, not int.
0ceccced 10664 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10665
10666 * data.c (Qcompiled_function): Now static.
10667
c6f072e7
PE
10668 * window.c (window_body_lines): Now static.
10669
20ce5912
PE
10670 * image.c (gif_load): Rename local to avoid shadowing.
10671
9c4c5f81
PE
10672 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10673 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10674 * alloc.c (make_save_value): Integer argument is now of type
10675 ptrdiff_t, not int.
10676 (mark_object): Use ptrdiff_t, not int.
10677 * lisp.h (pD): New macro.
10678 * print.c (print_object): Use it.
10679
c0c5c8ae
PE
10680 * alloc.c: Use EMACS_INT, not int, to count objects.
10681 (total_conses, total_markers, total_symbols, total_vector_size)
10682 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10683 (total_free_floats, total_floats, total_free_intervals)
10684 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10685 Now EMACS_INT, not int. All uses changed.
10686 (Fgarbage_collect): Compute overall total using a double, so that
10687 integer overflow is less likely to be a problem. Check for overflow
10688 when converting back to an integer.
5a25e253
PE
10689 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10690 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10691 These were 'int' variables that could overflow on 64-bit hosts;
10692 they were never used, so remove them instead of repairing them.
211a0b2a 10693 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10694 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10695 Previously, this ceilinged at INT_MAX, but that doesn't work on
10696 64-bit machines.
e46bb31a 10697 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10698
c78baabf 10699 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10700 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10701 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10702 when a (possibly-narrower) signed value would do just as well.
10703 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10704
c9d624c6
PE
10705 * alloc.c: Catch some string size overflows that we were missing.
10706 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10707 for convenience in STRING_BYTES_MAX.
10708 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10709 The definition here is exact; the one in lisp.h was approximate.
10710 (allocate_string_data): Check for string overflow. This catches
10711 some instances we weren't catching before. Also, it catches
10712 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10713 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10714 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10715
c9d624c6
PE
10716 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10717 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10718 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10719
353032ce
PE
10720 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10721
2bccce07
PE
10722 * alloc.c (Fmake_string): Check for out-of-range init.
10723
0ac30604
SM
107242011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10725
10726 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10727
c195f2de
JD
107282011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10729
10730 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10731 xg_get_default_scrollbar_width.
10732
10733 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10734 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10735 (style_changed_cb): Call update_theme_scrollbar_width and call
10736 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10737 all frames (Bug#8505).
10738 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10739 Call gtk_window_set_resizable if HAVE_GTK3.
10740 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10741 and height if HAVE_GTK3 (Bug#8505).
10742 (scroll_bar_width_for_theme): New variable.
10743 (update_theme_scrollbar_width): New function.
10744 (xg_get_default_scrollbar_width): Move code to
10745 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10746 (xg_initialize): Call update_theme_scrollbar_width.
10747
10748 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10749
10750 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10751
e10ac9f1
MR
107522011-06-12 Martin Rudalics <rudalics@gmx.at>
10753
10754 * frame.c (make_frame): Call other_buffer_safely instead of
10755 other_buffer.
10756
10757 * window.c (temp_output_buffer_show): Call display_buffer with
10758 second argument Vtemp_buffer_show_specifiers and reset latter
10759 immediately after the call.
10760 (Vtemp_buffer_show_specifiers): New variable.
10761 (auto_window_vscroll_p, next_screen_context_lines)
10762 (Vscroll_preserve_screen_position): Remove leading asterisks from
10763 doc-strings.
10764
2d3c217e 107652011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10766
7b7f97e8 10767 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10768 * buffer.c (Qclone_number): Remove for now, as it's unused.
10769 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10770 (record_buffer): Remove unused local.
10771 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10772 (set_frame_buffer_list): Remove; unused.
10773 * frame.h (other_visible_frames): Remove decl.
10774 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10775 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10776 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10777 if HAVE_GPM.
10778 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10779 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10780 Define only if HAVE_GPM.
10781 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10782 (update_hints_inhibit): Remove; never set. All uses removed.
10783 * widgetprv.h (emacsFrameClassRec): Remove decl.
10784 * window.c (delete_deletable_window): Now returns void, since it
10785 wasn't returning anything.
10786 (compare_window_configurations): Remove unused locals.
10787 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10788 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10789 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10790 the same widths as pointers. This follows up on the 2011-05-06 patch.
10791 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10792 * xterm.h: Likewise.
10793 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10794
1384b89e
JB
107952011-06-12 Juanma Barranquero <lekktu@gmail.com>
10796
10797 * makefile.w32-in: Update dependencies.
10798 (LISP_H): Add lib/intprops.h.
10799
1100a63c
CY
108002011-06-11 Chong Yidong <cyd@stupidchicken.com>
10801
10802 * image.c (gif_load): Add animation frame delay to the metadata.
10803 (syms_of_image): Use DEFSYM. New symbol `delay'.
10804
6198ccd0
MR
108052011-06-11 Martin Rudalics <rudalics@gmx.at>
10806
10807 * window.c (delete_deletable_window): Re-add.
10808 (Fset_window_configuration): Rewrite to handle dead buffers and
10809 consequently deletable windows.
10810 (window_tree, Fwindow_tree): Remove. Supply functionality in
10811 window.el.
10812 (compare_window_configurations): Simplify code.
10813
b6e3633c
AS
108142011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10815
1ab0dee5
AS
10816 * image.c (imagemagick_load_image): Fix type mismatch.
10817 (Fimagemagick_types): Likewise.
10818
b6e3633c
AS
10819 * window.h (replace_buffer_in_windows): Declare.
10820
9397e56f
MR
108212011-06-11 Martin Rudalics <rudalics@gmx.at>
10822
10823 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10824 Qclone_number. Remove external declaration of Qdelete_window.
10825 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10826 code.
640c8776
SM
10827 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10828 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10829 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10830 buffer list implementation.
10831 (other_buffer_safely): New function.
10832 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10833 calls to replace_buffer_in_windows and
10834 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10835 if allowed.
10836 (record_buffer): Inhibit quitting and rewrite using quittable
10837 functions. Run Qbuffer_list_update_hook if allowed.
10838 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10839 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10840 Move switch-to-buffer to window.el.
9397e56f
MR
10841 (bury-buffer): Move to window.el.
10842 (Vbuffer_list_update_hook): New variable.
10843
10844 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10845 section.
10846
10847 * window.h (resize_frame_windows): Move up in code.
10848 (Fwindow_frame): Remove EXFUN.
10849 (replace_buffer_in_all_windows): Remove prototype.
10850 (replace_buffer_in_windows_safely): Add prototype.
10851
10852 * window.c: Declare Qdelete_window static again. Move down
10853 declaration of select_count.
10854 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10855 (Fother_window): Move to window.el.
10856 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10857 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10858 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10859 window.el.
10860 (replace_buffer_in_windows): Implement by calling
10861 Qreplace_buffer_in_windows.
10862 (replace_buffer_in_all_windows): Remove with some functionality
10863 moved into replace_buffer_in_windows_safely.
10864 (replace_buffer_in_windows_safely): New function.
10865 (select_window_norecord, select_frame_norecord): Move in front
10866 of run_window_configuration_change_hook. Remove now obsolete
10867 declarations.
640c8776
SM
10868 (Fset_window_buffer): Rewrite doc-string.
10869 Call Qrecord_window_buffer.
9397e56f
MR
10870 (keys_of_window): Move binding for other-window to window.el.
10871
b50691aa
CY
108722011-06-11 Chong Yidong <cyd@stupidchicken.com>
10873
10874 * dispextern.h (struct image): Replace data member, whose int_val
10875 and ptr_val fields were not used by anything, with a single
10876 lisp_val object.
10877
10878 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10879 (gif_clear_image, gif_load, imagemagick_load_image)
10880 (gs_clear_image, gs_load): Callers changed.
10881
3f754b86
PE
108822011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10883
cca69397
PE
10884 * buffer.h: Include <time.h>, for time_t.
10885 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10886
109e28d0
PE
10887 Fix minor problems found by static checking.
10888
60737f02
PE
10889 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10890
4b66faf3
PE
10891 Make identifiers static if they are not used in other modules.
10892 * data.c (Qcompiled_function, Qframe, Qvector):
10893 * image.c (QimageMagick, Qsvg):
10894 * minibuf.c (Qmetadata):
10895 * window.c (resize_window_check, resize_root_window): Now static.
10896 * window.h (resize_window_check, resize_root_window): Remove decls.
10897
109e28d0
PE
10898 * window.c (window_deletion_count, delete_deletable_window):
10899 Remove; unused.
46a4ce9e
PE
10900 (window_body_lines): Now static.
10901 (Fdelete_other_windows_internal): Mark vars as initialized.
10902 Make sure 'resize_failed' is initialized.
10903 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10904 (resize_window_apply): Remove unused local.
10905 * window.h (delete_deletable_window): Remove decl.
10906
109e28d0 10907 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10908 (imagemagick_load_image): Fix pointer signedness problem by changing
10909 last arg from unsigned char * to char *. All uses changed.
10910 Also, fix a local for similar reasons.
10911 Remove unused locals. Remove locals to avoid shadowing.
10912 (fn_rsvg_handle_free): Remove; unused.
10913 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10914 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10915
3f754b86
PE
10916 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10917
2547adb1
CY
109182011-06-10 Chong Yidong <cyd@stupidchicken.com>
10919
10920 * image.c (gif_load): Fix omitted cast error introduced by
10921 2011-06-06 change.
10922
2c8e37d4
MR
109232011-06-10 Martin Rudalics <rudalics@gmx.at>
10924
10925 * window.h (resize_proportionally, orig_total_lines)
10926 (orig_top_line): Remove from window structure.
10927 (set_window_height, set_window_width, change_window_heights)
10928 (Fdelete_window): Remove prototypes.
10929 (resize_frame_windows): Remove duplicate declaration.
10930
440a42e3
EZ
109312011-06-10 Eli Zaretskii <eliz@gnu.org>
10932
10933 * window.h (resize_frame_windows, resize_window_check)
10934 (delete_deletable_window, resize_root_window)
10935 (resize_frame_windows): Declare prototypes.
10936
10937 * window.c (resize_window_apply): Make definition be "static" to
10938 match the prototype.
10939
562dd5e9
MR
109402011-06-10 Martin Rudalics <rudalics@gmx.at>
10941
10942 * window.c: Remove declarations of Qwindow_size_fixed,
10943 window_min_size_1, window_min_size_2, window_min_size,
10944 size_window, window_fixed_size_p, enlarge_window, delete_window.
10945 Remove static from declaration of Qdelete_window, it's
10946 temporarily needed by Fbury_buffer.
10947 (replace_window): Don't assign orig_top_line and
10948 orig_total_lines.
10949 (Fdelete_window, delete_window): Remove. Window deletion is
10950 handled by window.el.
640c8776
SM
10951 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10952 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10953 (Fdelete_other_windows): Remove. Deleting other windows is
10954 handled by window.el.
10955 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10956 handled in window.el.
10957 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10958 Window minimum sizes are handled in window.el.
10959 (shrink_windows, size_window, set_window_height)
10960 (set_window_width, change_window_heights, window_height)
10961 (window_width, CURBEG, CURSIZE, enlarge_window)
10962 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10963 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10964 handled in window.el.
10965 (make_dummy_parent): Rename to make_parent_window and give it a
10966 second argument horflag.
10967 (make_window): Don't set resize_proportionally any more.
10968 (Fsplit_window): Remove. Windows are split in window.el.
10969 (save_restore_action, save_restore_orig_size)
10970 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10971 Resize mini windows in window.el.
10972 (grow_mini_window, shrink_mini_window): Implement by calling
10973 Qresize_root_window_vertically, resize_window_check and
10974 resize_window_apply.
640c8776
SM
10975 (saved_window, Fset_window_configuration, save_window_save):
10976 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10977 resize_proportionally.
10978 (window_min_height, window_min_width): Move to window.el.
10979 (keys_of_window): Move bindings for delete-other-windows,
10980 split-window, delete-window and enlarge-window to window.el.
10981
10982 * buffer.c: Temporarily extern Qdelete_window.
10983 (Fbury_buffer): Temporarily call Qdelete_window instead of
10984 Fdelete_window (Fbury_buffer will move to window.el soon).
10985
10986 * frame.c (set_menu_bar_lines_1): Remove code handling
10987 orig_top_line and orig_total_lines.
10988
10989 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10990 set_window_height but set heights directly.
10991 (change_frame_size_1): Use resize_frame_windows.
10992
10993 * xdisp.c (init_xdisp): Don't use set_window_height but set
10994 heights directly.
10995
640c8776
SM
10996 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10997 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10998 run_window_configuration_change_hook.
10999
11000 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11001 instead of change_window_heights and run
11002 run_window_configuration_change_hook.
11003
1a13852e
MR
110042011-06-09 Martin Rudalics <rudalics@gmx.at>
11005
11006 * window.c (replace_window): Rename second argument REPLACEMENT to
11007 NEW. New third argument SETFLAG. Rewrite.
11008 (delete_window, make_dummy_parent): Call replace_window with
11009 third argument 1.
11010 (window_list_1): Move down in code.
11011 (run_window_configuration_change_hook): Move set_buffer part
11012 before select_frame_norecord part in order to unwind correctly.
11013 Rename count1 to count.
11014 (recombine_windows, delete_deletable_window, resize_root_window)
11015 (Fdelete_other_windows_internal)
11016 (Frun_window_configuration_change_hook, make_parent_window)
11017 (resize_window_check, resize_window_apply, Fresize_window_apply)
11018 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11019 (Fdelete_window_internal, Fresize_mini_window_internal):
11020 New functions.
1a13852e
MR
11021 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11022
f3d1777e
MR
110232011-06-08 Martin Rudalics <rudalics@gmx.at>
11024
496e208e
MR
11025 * window.h (window): Add some new members to window structure -
11026 normal_lines, normal_cols, new_total, new_normal, clone_number,
11027 splits, nest, prev_buffers, next_buffers.
11028 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11029 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11030
f3d1777e
MR
11031 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11032 Remove.
496e208e
MR
11033 (make_dummy_parent): Set new members of windows structure.
11034 (make_window): Move down in code. Handle new members of window
11035 structure.
11036 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11037 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11038 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11039 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11040 (Fset_window_next_buffers, Fset_window_clone_number):
11041 New functions.
496e208e
MR
11042 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11043 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11044 Doc-string fixes.
11045 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11046 Argument WINDOW can be now internal window too.
11047 (Fwindow_use_time): Move up in code.
11048 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11049 Rewrite doc-string.
11050 (Fset_window_configuration, saved_window)
11051 (Fcurrent_window_configuration, save_window_save): Handle new
11052 members of window structure.
b9e809c2
MR
11053 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11054 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11055 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11056 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11057 Qget_mru_window, Qresize_root_window,
11058 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11059 Qauto_buffer_name; staticpro them.
f3d1777e 11060
abde8f8c
MR
110612011-06-07 Martin Rudalics <rudalics@gmx.at>
11062
11063 * window.c (Fwindow_total_size, Fwindow_left_column)
11064 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11065 (Fwindow_list_1): New functions.
11066 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11067 (Fwindow_width, Fscroll_left, Fscroll_right):
11068 Use window_body_cols instead of window_box_text_cols.
11069 (delete_window, Fset_window_configuration):
11070 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11071 (delete_all_subwindows): Take a window as argument and not a
11072 structure. Rewrite.
190b47e6
MR
11073 (window_loop): Remove handling of GET_LRU_WINDOW and
11074 GET_LARGEST_WINDOW.
11075 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11076
11077 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11078 window_box_text_cols. delete_all_subwindows now takes a
11079 Lisp_Object as argument.
abde8f8c 11080
640c8776
SM
11081 * indent.c (compute_motion, Fcompute_motion):
11082 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11083
fa8a67e6
MR
11084 * frame.c (delete_frame): Call delete_all_subwindows with root
11085 window as argument.
11086
a54e3482
DC
110872011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11088
11089 * fns.c (Fputhash): Document return value.
11090
60002bf5
CY
110912011-06-06 Chong Yidong <cyd@stupidchicken.com>
11092
11093 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11094
0c671da6 110952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11096
b862a52a 11097 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11098
be44ca6c
PE
11099 Check for overflow when converting integer to cons and back.
11100 * charset.c (Fdefine_charset_internal, Fdecode_char):
11101 Use cons_to_unsigned to catch overflow.
11102 (Fencode_char): Use INTEGER_TO_CONS.
11103 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11104 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11105 * data.c (long_to_cons, cons_to_long): Remove.
11106 (cons_to_unsigned, cons_to_signed): New functions.
11107 These signal an error for invalid or out-of-range values.
11108 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11109 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11110 * font.c (Ffont_variation_glyphs):
11111 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11112 * lisp.h: Include <intprops.h>.
11113 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11114 (cons_to_signed, cons_to_unsigned): New decls.
11115 (long_to_cons, cons_to_long): Remove decls.
11116 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11117 (Fprimitive_undo): Use CONS_TO_INTEGER.
11118 * xfns.c (Fx_window_property): Likewise.
11119 * xselect.c: Include <limits.h>.
11120 (x_own_selection, selection_data_to_lisp_data):
11121 Use INTEGER_TO_CONS.
11122 (x_handle_selection_request, x_handle_selection_clear)
11123 (x_get_foreign_selection, Fx_disown_selection_internal)
11124 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11125 (lisp_data_to_selection_data): Use cons_to_unsigned.
11126 (x_fill_property_data): Use cons_to_signed.
11127 Report values out of range.
11128
d1f3d2af
PE
11129 Check for buffer and string overflow more precisely.
11130 * buffer.h (BUF_BYTES_MAX): New macro.
11131 * lisp.h (STRING_BYTES_MAX): New macro.
11132 * alloc.c (Fmake_string):
11133 * character.c (string_escape_byte8):
11134 * coding.c (coding_alloc_by_realloc):
11135 * doprnt.c (doprnt):
11136 * editfns.c (Fformat):
11137 * eval.c (verror):
11138 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11139 since they may not be the same number.
11140 * editfns.c (Finsert_char):
11141 * fileio.c (Finsert_file_contents):
11142 Likewise for BUF_BYTES_MAX.
11143
dd52fcea
PE
11144 * image.c: Use ptrdiff_t, not int, for sizes.
11145 (slurp_file): Switch from int to ptrdiff_t.
11146 All uses changed.
11147 (slurp_file): Check that file size fits in both size_t (for
11148 malloc) and ptrdiff_t (for sanity and safety).
11149
7f9bbdbb
PE
11150 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11151 if b->modtime has its maximal value.
11152
dfe18f82
PE
11153 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11154
84acfcf0
PE
11155 Don't assume time_t can fit into int.
11156 * buffer.h (struct buffer.modtime): Now time_t, not int.
11157 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11158 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11159
ccd9a01a
PE
11160 Minor fixes for signed vs unsigned integers.
11161 * character.h (MAYBE_UNIFY_CHAR):
11162 * charset.c (maybe_unify_char):
11163 * keyboard.c (read_char, reorder_modifiers):
11164 XINT -> XFASTINT, since the integer must be nonnegative.
11165 * ftfont.c (ftfont_spec_pattern):
11166 * keymap.c (access_keymap, silly_event_symbol_error):
11167 XUINT -> XFASTINT, since the integer must be nonnegative.
11168 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11169 since it makes no difference and we prefer signed.
11170 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11171 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11172 nonnegative.
11173
d6d100dd
SM
111742011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11175
11176 * window.h (Fwindow_frame): Declare.
11177
2b6148e4
PE
111782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11179
11180 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11181 (SPARE_MEMORY): Always define.
11182 (LARGE_REQUEST): Remove.
11183 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11184
f230ecc9
MR
111852011-06-06 Martin Rudalics <rudalics@gmx.at>
11186
727e958e
MR
11187 * lisp.h: Move EXFUNS for Fframe_root_window,
11188 Fframe_first_window and Fset_frame_selected_window to window.h.
11189
11190 * window.h: Move EXFUNS for Fframe_root_window,
11191 Fframe_first_window and Fset_frame_selected_window here from
11192 lisp.h.
11193
11194 * frame.c (Fwindow_frame, Fframe_first_window)
11195 (Fframe_root_window, Fframe_selected_window)
11196 (Fset_frame_selected_window): Move to window.c.
11197 (Factive_minibuffer_window): Move to minibuf.c.
11198 (Fother_visible_frames_p): New function.
11199
11200 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11201
f230ecc9
MR
11202 * window.c (decode_window, decode_any_window): Move up in code.
11203 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11204 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11205 (Fwindow_buffer): Move up and rewrite doc-string.
11206 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11207 (Fwindow_prev): New functions.
727e958e
MR
11208 (Fwindow_frame): Move here from frame.c. Accept any window as
11209 argument.
11210 (Fframe_root_window, Fframe_first_window)
11211 (Fframe_selected_window): Move here from frame.c. Accept frame
11212 or arbitrary window as argument. Update doc-strings.
11213 (Fminibuffer_window): Move up in code.
11214 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11215 (Fset_frame_selected_window): Move here from frame.c.
11216 Marginal rewrite.
727e958e
MR
11217 (Fselected_window, select_window, Fselect_window): Move up in
11218 code. Minor doc-string fixes.
f230ecc9 11219
4d09bcf6
PE
112202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11221
11222 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11223 Do not assume that spare memory exists; that assumption is valid
11224 only if SYSTEM_MALLOC.
11225 (LARGE_REQUEST): New macro, so that the issue of large requests
11226 is separated from the issue of spare memory.
11227
810928a2
AS
112282011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11229
172418ad
AS
11230 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11231 format. (Bug#8806)
11232
43f862f7
AS
11233 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11234
810928a2
AS
11235 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11236 before statements.
11237
a059fe24
JD
112382011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11239
11240 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11241
11242 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11243
11244 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11245 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11246
989bf368
JB
112472011-06-05 Juanma Barranquero <lekktu@gmail.com>
11248
11249 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11250
4b80f674
CY
112512011-06-04 Chong Yidong <cyd@stupidchicken.com>
11252
11253 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11254 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11255 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11256 New error handlers.
4b80f674
CY
11257 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11258 Obey Vx_select_enable_clipboard_manager. Catch errors in
11259 x_clipboard_manager_save (Bug#8779).
11260 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11261 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11262
99a33b77 112632011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11264
11265 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11266
99a33b77 112672011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11268
11269 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11270 in the current matrix if keep_current_p is non-zero.
11271
8264569d
EZ
112722011-06-04 Eli Zaretskii <eliz@gnu.org>
11273
11274 * bidi.c (bidi_level_of_next_char): Fix last change.
11275
57f97249
EZ
112762011-06-03 Eli Zaretskii <eliz@gnu.org>
11277
fec2107c 11278 Support bidi reordering of text covered by display properties.
57f97249 11279
fec2107c
EZ
11280 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11281 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11282 (bidi_cache_search, bidi_cache_iterator_state)
11283 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11284 (bidi_level_of_next_char, bidi_move_to_visually_next):
11285 Support character positions inside a run of characters covered by a
fec2107c
EZ
11286 display string.
11287 (bidi_paragraph_init, bidi_resolve_explicit_1)
11288 (bidi_level_of_next_char): Call bidi_fetch_char and
11289 bidi_fetch_char_advance instead of FETCH_CHAR and
11290 FETCH_CHAR_ADVANCE.
11291 (bidi_init_it): Initialize new members.
11292 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11293 definitions.
11294 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11295 instead of using explicit *_CHAR codes.
d6d100dd
SM
11296 (bidi_resolve_explicit, bidi_resolve_weak):
11297 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11298 bidirectional text is supported only in multibyte buffers.
11299 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11300 it to initialize the frame_window_p member of struct bidi_it.
11301 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11302 (bidi_resolve_explicit, bidi_resolve_weak)
11303 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11304 bidi_it->nchars is non-positive.
11305 (bidi_level_of_next_char): Don't try to lookup the cache for the
11306 next/previous character if nothing is cached there yet, or if we
11307 were just reseat()'ed to a new position.
c40e2fb2 11308
0e14fe90
EZ
11309 * xdisp.c (set_cursor_from_row): Set start and stop points
11310 according to the row's direction when priming the loop that looks
11311 for the glyph on which to display cursor.
11312 (single_display_spec_intangible_p): Function deleted.
11313 (display_prop_intangible_p): Reimplement to call
11314 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11315 Accept 3 additional arguments needed by handle_display_spec.
11316 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11317 values: lists, `(when COND...)' forms, etc.
11318 (single_display_spec_string_p): Support property values that are
11319 lists with the argument STRING its top-level element.
11320 (display_prop_string_p): Fix the condition for processing a
11321 property that is a list to be consistent with handle_display_spec.
fec2107c 11322 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11323 last portion of handle_display_prop.
11324 (compute_display_string_pos): Accept additional argument
11325 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11326 value of a `display' property is a "replacing spec".
11327 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11328 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11329 the display property, but just return a value indicating whether
11330 the display property will replace the characters it covers.
11331 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11332 frame_window_p members of struct bidi_it.
d6d100dd
SM
11333 (compute_display_string_pos, compute_display_string_end):
11334 New functions.
fec2107c
EZ
11335 (push_it): Accept second argument POSITION, where pop_it should
11336 jump to continue iteration.
11337 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11338
fec2107c
EZ
11339 * keyboard.c (adjust_point_for_property): Adjust the call to
11340 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11341
11342 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11343 (bidi_init_it): Update prototypes.
11344 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11345 (compute_display_string_pos, compute_display_string_end):
11346 Declare prototypes.
fec2107c
EZ
11347 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11348 EMACS_INT.
fc6f18ce 11349
40087514 113502011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11351
57f53182
PE
11352 Malloc failure behavior now depends on size of allocation.
11353 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11354 * lisp.h: Change signatures accordingly.
11355 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11356 All callers changed. (Bug#8762)
11357
11358 * gnutls.c: Use Emacs's memory allocators.
11359 Without this change, the gnutls library would invoke malloc etc.
11360 directly, which causes problems on non-SYNC_INPUT hosts, and which
11361 runs afoul of improving memory_full behavior. (Bug#8761)
11362 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11363 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11364 xfree instead of the default malloc, realloc, free.
11365 (Fgnutls_boot): No need to check for memory allocation failure,
11366 since xmalloc does that for us.
11367
ac32cd99 11368 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11369 * category.c (hash_get_category_set):
11370 * ccl.c (ccl_driver):
11371 * charset.c (Fdefine_charset_internal):
11372 * charset.h (struct charset.hash_index):
11373 * composite.c (get_composition_id, gstring_lookup_cache)
11374 (composition_gstring_put_cache):
11375 * composite.h (struct composition.hash_index):
11376 * dispextern.h (struct image.hash):
11377 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11378 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11379 (hashfn_equal, hashfn_user_defined, make_hash_table)
11380 (maybe_resize_hash_table, hash_lookup, hash_put)
11381 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11382 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11383 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11384 * image.c (make_image, search_image_cache, lookup_image)
11385 (xpm_put_color_table_h):
11386 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11387 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11388 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11389 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11390 * alloc.c (allocate_vectorlike):
11391 Check for overflow in vector size calculations.
11392 * ccl.c (ccl_driver):
11393 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11394 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11395 need to be updated by these changes.
40087514
PE
11396 * fns.c (make_hash_table, maybe_resize_hash_table):
11397 Check for integer overflow with large hash tables.
0de4bb68
PE
11398 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11399 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11400 (SXHASH_REDUCE): New macro.
11401 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11402 Use it instead of discarding useful hash info with large hash values.
11403 (sxhash_float): New function.
11404 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11405 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11406 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11407 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11408 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11409 Adjust signatures to match updated version of code.
11410 (consing_since_gc): Now EMACS_INT, since a single hash table can
11411 use more than INT_MAX bytes.
11412
698d32e2
DN
114132011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11414
11415 Make it possible to build with GCC-4.6+ -O2 -flto.
11416
11417 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11418
fd6fa53f
SM
114192011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11420
11421 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11422 Call minibuffer-inactive-mode.
11423
864db017
JB
114242011-05-31 Juanma Barranquero <lekktu@gmail.com>
11425
11426 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11427 Update dependencies.
11428
2ad0baf4
DN
114292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11430
11431 * data.c (init_data): Remove code for UTS, this system is not
11432 supported anymore.
11433
4fcc2638
DN
114342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11435
11436 Don't force ./temacs to start in terminal mode.
11437
11438 * frame.c (make_initial_frame): Initialize faces in all cases, not
11439 only when CANNOT_DUMP is defined.
11440 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11441
c56e0fd5
DN
114422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11443
11444 * dispnew.c (add_window_display_history): Use const for the string
11445 pointer. Remove declaration, not needed.
11446
333d54da 114472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11448
55d4c1b2 11449 Use 'inline', not 'INLINE'.
333d54da 11450 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11451 * alloc.c, fontset.c (INLINE): Remove.
11452 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11453 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11454 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11455 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11456 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11457
738db178
DN
114582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11459
11460 Make it possible to run ./temacs.
11461
11462 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11463 syms_of_callproc does the same thing. Remove test for
11464 "initialized", do it in the caller.
11465 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11466
620c53a6
SM
114672011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11468
11469 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11470 (read_minibuf): Use get_minibuffer.
11471 (syms_of_minibuf): Use DEFSYM.
11472 (Qmetadata): New var.
11473 * data.c (Qbuffer): Don't make it static.
11474 (syms_of_data): Use DEFSYM.
11475
e003a292
PE
114762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11477
11478 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11479 (CCL_CODE_MIN): New macro.
11480
ed008a6d
PE
114812011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11482
3687c2ef
PE
11483 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11484
ed008a6d
PE
11485 * eval.c (Qdebug): Now static.
11486 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11487 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11488 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11489
d66c4c7c
CY
114902011-05-29 Chong Yidong <cyd@stupidchicken.com>
11491
11492 * image.c: Various fixes to ImageMagick code comments.
11493 (Fimagemagick_types): Doc fix.
11494
5fbc2025
PE
114952011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11496
0196f88a
PE
11497 Minor fixes prompted by GCC 4.6.0 warnings.
11498
11499 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11500
5fbc2025
PE
11501 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11502 (x_clipboard_manager_save_all): Move extern decl to ...
11503 * xterm.h: ... here, so that it can be checked for consistency.
11504
1dd3c2d9
CY
115052011-05-29 Chong Yidong <cyd@stupidchicken.com>
11506
11507 * xselect.c (x_clipboard_manager_save_frame)
11508 (x_clipboard_manager_save_all): New functions.
11509 (Fx_clipboard_manager_save): Lisp function deleted.
11510
11511 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11512 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11513
11514 * xterm.h: Update prototype.
11515
5ba6571d
WX
115162011-05-28 William Xu <william.xwl@gmail.com>
11517
11518 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11519 exiting (Bug#8239).
11520
3eaff834
JM
115212011-05-28 Jim Meyering <meyering@redhat.com>
11522
e1900994 11523 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11524 * fns.c (to_uchar): Define.
11525 (crypto_hash_function): Use it to convert some newly-signed
11526 variables to unsigned, to avoid sign-extension bugs. For example,
11527 without this change, (md5 "truc") would evaluate to
11528 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11529 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11530 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11531
0f6990a7
PE
115322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11533
11534 Integer overflow fixes.
c8a9ca5a 11535
08686060
PE
11536 * dbusbind.c: Serial number integer overflow fixes.
11537 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11538 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11539 to hold a serial number that is too large for a fixnum.
11540 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11541 Check for serial numbers out of range. Decode any serial number
59568bf0 11542 that was so large that it became a float. (Bug#8722)
08686060 11543
2d1fc3c7
PE
11544 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11545 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11546 Use XFASTINT rather than XUINT when numbers are nonnegative.
11547 (xd_append_arg, Fdbus_method_return_internal):
11548 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11549 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11550 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11551 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11552 (Bug#8722)
2d1fc3c7 11553
c8a9ca5a
PE
11554 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11555
519e1d69
PE
11556 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11557
6df6ae42 11558 ccl: Add integer overflow checks.
30569699
PE
11559 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11560 (IN_INT_RANGE): New macros.
11561 (ccl_driver): Use them to check for integer overflow when
11562 decoding a CCL program. Many of the new checks are whether XINT (x)
11563 fits in int; it doesn't always, on 64-bit hosts. The new version
11564 doesn't catch all possible integer overflows, but it's an
847044ea 11565 improvement. (Bug#8719)
30569699 11566
c11285dc
PE
11567 * alloc.c (make_event_array): Use XINT, not XUINT.
11568 There's no need for unsigned here.
11569
fdccd48e
PE
11570 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11571 This follows up to the 2011-05-06 change that substituted uintptr_t
11572 for EMACS_INT. This case wasn't caught back then.
11573
37910ab2
PE
11574 Rework Fformat to avoid integer overflow issues.
11575 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11576 now (part of C89). Include <verify.h>.
11577 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11578 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11579 (Fformat): Avoid the prepass trying to compute sizes; it was only
11580 approximate and thus did not catch overflow reliably. Instead, walk
11581 through the format just once, formatting and computing sizes as we go,
11582 checking for integer overflow at every step, and allocating a larger
11583 buffer as needed. Keep track separately whether the format is
11584 multibyte. Keep only the most-recently calculated precision, rather
11585 than them all. Record whether each argument has been converted to
11586 string. Use EMACS_INT, not int, for byte and char and arg counts.
11587 Support field widths and precisions larger than INT_MAX. Avoid
11588 sprintf's undefined behavior with conversion specifications such as %#d
11589 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11590 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11591 formatting out-of-range floating point numbers with int
9173deec 11592 formats. (Bug#8668)
37910ab2 11593
2e6578fb
PE
11594 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11595
0ae6bdee
PE
11596 * data.c: Avoid integer truncation in expressions involving floats.
11597 * data.c: Include <intprops.h>.
11598 (arith_driver): When there's an integer overflow in an expression
11599 involving floating point, convert the integers to floating point
11600 so that the resulting value does not suffer from catastrophic
11601 integer truncation. For example, on a 64-bit host (* 4
11602 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11603 Do not rely on undefined behavior after integer overflow.
11604
de883a70
PE
11605 merge count_size_as_multibyte, parse_str_to_multibyte
11606 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11607 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11608 Check for integer overflow.
11609 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11610 since it's now a duplicate of the other. This is more of
11611 a character than a buffer op, so better that it's in character.c.
11612 * fns.c, print.c: Adjust to above changes.
11613
2ff916cb
PE
116142011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11615
11616 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11617
f1b54466
PE
116182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11619
fb1ac845
PE
11620 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11621 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11622 (x_clipboard_manager_save): Now static.
11623 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11624
f1b54466
PE
11625 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11626 (crypto_hash_function): Now static.
11627 Fix pointer signedness problems. Avoid unnecessary initializations.
11628
a9f737ee
CY
116292011-05-27 Chong Yidong <cyd@stupidchicken.com>
11630
11631 * termhooks.h (Vselection_alist): Make it terminal-local.
11632
11633 * terminal.c (create_terminal): Initialize it.
11634
11635 * xselect.c: Support for clipboard managers.
11636 (Vselection_alist): Move to termhooks.h as terminal-local var.
11637 (LOCAL_SELECTION): New macro.
11638 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11639 (symbol_to_x_atom): Remove gratuitous arg.
11640 (x_handle_selection_request, lisp_data_to_selection_data)
11641 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11642 (x_own_selection, x_get_local_selection, x_convert_selection):
11643 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11644 (some_frame_on_display): Delete unused function.
11645 (Fx_own_selection_internal, Fx_get_selection_internal)
11646 (Fx_disown_selection_internal, Fx_selection_owner_p)
11647 (Fx_selection_exists_p): New optional frame arg.
11648 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11649 (x_handle_selection_clear): Don't treat other terminals with the
11650 same keyboard specially. Use the terminal-local Vselection_alist.
11651 (x_clear_frame_selections): Use Frun_hook_with_args.
11652
11653 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11654
11655 * xterm.h: Add support for those atoms.
11656
e067f0c1
CY
116572011-05-26 Chong Yidong <cyd@stupidchicken.com>
11658
11659 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11660 (converted_selections, conversion_fail_tag): New global variables.
11661 (x_selection_request_lisp_error): Free the above.
11662 (x_get_local_selection): Remove unnecessary code.
11663 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11664 of converted selections stored in converted_selections.
11665 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11666 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11667 (x_convert_selection): New function.
11668 (x_handle_selection_event): Simplify.
11669 (x_get_foreign_selection): Don't ignore incoming requests while
11670 waiting for an answer; this will fail when we implement
11671 SAVE_TARGETS, and seems unnecessary anyway.
11672 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11673 (Vx_sent_selection_functions): Doc fix.
11674
0f4aebc0
LL
116752011-05-26 Leo Liu <sdl.web@gmail.com>
11676
11677 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11678
e61124cd
YM
116792011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11680
11681 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11682
11683 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11684 for fringe update if it has periodic bitmap.
ac389d0c 11685 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11686 and fringe_bitmap_periodic_p.
11687
11688 * fringe.c (get_fringe_bitmap_data): New function.
11689 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11690 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11691 row. Mark glyph row for fringe update if periodicity changed.
11692
11693 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11694 for fringe update unless it has periodic bitmap.
11695
f16d9837
KH
116962011-05-25 Kenichi Handa <handa@m17n.org>
11697
11698 * xdisp.c (get_next_display_element): Set correct it->face_id for
11699 a static composition.
11700
e1b90ef6
LL
117012011-05-24 Leo Liu <sdl.web@gmail.com>
11702
11703 * deps.mk (fns.o):
11704 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11705
11706 * fns.c (crypto_hash_function, Fsha1): New function.
11707 (Fmd5): Use crypto_hash_function.
11708 (syms_of_fns): Add Ssha1.
11709
7400048f
PE
117102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11711
11712 * gnutls.c: Remove unused macros.
11713 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11714 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11715 Remove macros that are defined and never used.
11716 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11717
abb71cf4
CY
117182011-05-22 Chong Yidong <cyd@stupidchicken.com>
11719
11720 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11721 (Fx_get_selection_internal): Minor cleanup.
11722 (Fx_own_selection_internal): Rename arguments for consistency with
11723 select.el.
11724
6307db39
PE
117252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11726
11727 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11728
f3d4e0a4
CY
117292011-05-22 Chong Yidong <cyd@stupidchicken.com>
11730
11731 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11732
4d8ade89
YM
117332011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11734
11735 * dispnew.c (scrolling_window): Don't exclude the case that the
11736 last enabled row in the desired matrix touches the bottom boundary.
11737
32078c8d
GM
117382011-05-21 Glenn Morris <rgm@gnu.org>
11739
11740 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11741 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11742 and add some more files.
32078c8d 11743
7285dc67
EZ
117442011-05-20 Eli Zaretskii <eliz@gnu.org>
11745
11746 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11747 report_file_error introduced by the change from 2011-05-07.
11748
89d1bd22
PE
117492011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11750
11751 * systime.h (Time): Define only if emacs is defined.
11752 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11753 where the include path doesn't have X11/X.h by default. See
11754 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11755
cd394be1 117562011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11757
11758 * composite.c (find_automatic_composition): Fix previous change.
11759
b9704ad9
GM
117602011-05-20 Glenn Morris <rgm@gnu.org>
11761
11762 * lisp.mk: New file, split from Makefile.in.
11763 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11764 (shortlisp): Remove.
11765 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11766
4a720484
GM
117672011-05-19 Glenn Morris <rgm@gnu.org>
11768
11769 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11770 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11771 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11772 (lisp): Set the order to that of loadup.el.
11773 (shortlisp): Make it a copy of $lisp.
11774 (SOME_MACHINE_LISP): Remove.
11775 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11776 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11777
a28d4396
KH
117782011-05-18 Kenichi Handa <handa@m17n.org>
11779
11780 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11781 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11782 (find_automatic_composition): Mostly rewrite for efficiency.
11783
a2b1fa8e
JB
117842011-05-18 Juanma Barranquero <lekktu@gmail.com>
11785
11786 * makefile.w32-in: Update dependencies.
11787
8e1f5610
CS
117882011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11789
11790 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11791 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11792
7025ee00 117932011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11794
cdfa6eab
PE
11795 Fix some integer overflow issues, such as string length overflow.
11796
06d6db33
PE
11797 * insdel.c (count_size_as_multibyte): Check for string overflow.
11798
2b4560a8
PE
11799 * character.c (lisp_string_width): Check for string overflow.
11800 Use EMACS_INT, not int, for string indexes and lengths; in
11801 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11802 the resulting string length overflows an EMACS_INT; instead,
11803 report a string overflow if no precision given. When checking for
11804 precision exhaustion, use a check that cannot possibly have
11805 integer overflow. (Bug#8675)
11806 * character.h (lisp_string_width): Adjust to new signature.
11807
cb93f9be
PE
11808 * alloc.c (string_overflow): New function.
11809 (Fmake_string): Use it. This doesn't change behavior, but saves
11810 a few bytes and will simplify future changes.
11811 * character.c (string_escape_byte8): Likewise.
11812 * lisp.h (string_overflow): New decl.
11813
1a1f3366
PE
11814 Fixups, following up to the user-interface timestamp change.
11815 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11816 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11817 * msdos.c (mouse_get_pos): Likewise.
11818 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11819 * w32gui.h (Time): Define by including "systime.h" rather than by
11820 declaring it ourselves. (Bug#8664)
11821
d4e3e4d3
PE
11822 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11823 * image.c (clear_image_cache): Likewise.
11824
f6a24d19
PE
11825 * term.c (term_mouse_position): Don't assume time_t wraparound.
11826
08dc5ae6
PE
11827 Be more systematic about user-interface timestamps.
11828 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11829 and sometimes 'EMACS_UINT', to represent these timestamps.
11830 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11831 This makes the code easier to follow, and makes it easier to catch
11832 integer overflow bugs such as Bug#8664.
11833 * frame.c (Fmouse_position, Fmouse_pixel_position):
11834 Use Time, not unsigned long, for user-interface timestamps.
11835 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11836 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11837 * keyboard.h (last_event_timestamp): Likewise.
11838 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11839 * menu.h (xmenu_show): Likewise.
11840 * term.c (term_mouse_position): Likewise.
11841 * termhooks.h (struct input_event.timestamp): Likewise.
11842 (struct terminal.mouse_position_hook): Likewise.
11843 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11844 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11845 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11846 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11847 what it was before.
11848 * menu.h, termhooks.h: Include "systime.h", for Time.
11849
8e55734a
PE
11850 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11851 Don't assume that the difference between two unsigned long values
11852 can fit into an integer. At this point, we know button_down_time
11853 <= event->timestamp, so the difference must be nonnegative, so
11854 there's no need to cast the result if double-click-time is
11855 nonnegative, as it should be; check that it's nonnegative, just in
11856 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11857 apart (about 25 days). (Bug#8664)
8e55734a 11858
841f1b75 11859 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11860 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11861
3e26f69c
PE
11862 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11863 that always fit in int. Use a sentinel instead of a counter, to
11864 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11865 * frame.h (struct frame): Use int for menu_bar_items_used
11866 instead of EMACS_INT, since it always fits in int.
3e26f69c 11867
5cc152c0
PE
11868 * menu.c (grow_menu_items): Check for int overflow.
11869
d89eb65e
PE
11870 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11871
5235bd3e
PE
11872 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11873 Before, the code was not consistent. These values cannot exceed
11874 2**31 - 1 so there's no need to make them unsigned.
11875 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11876 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11877 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11878 as modifiers.
11879 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11880
bc827e23
PE
11881 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11882 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11883 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11884 presumably because the widths might not match.
11885
78eb494e
PE
11886 * window.c (size_window): Avoid needless test at loop start.
11887
04f2d78b
CB
118882011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11889
11890 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11891
d2fc7e3d 118922011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11893
11894 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11895
d2fc7e3d 118962011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11897
11898 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11899 `width' to `bar_area_x' and `bar_area_width', respectively.
11900 (x_scroll_run): Take account of fringe background extension.
11901
04f2d78b
CB
11902 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11903 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11904 `bar_area_width', respectively.
11905 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11906 background extension.
11907
79b70037
GM
119082011-05-10 Jim Meyering <meyering@redhat.com>
11909
11910 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11911
2f142cc5
JB
119122011-05-10 Juanma Barranquero <lekktu@gmail.com>
11913
11914 * image.c (Finit_image_library): Return t for built-in image types,
11915 like pbm and xbm. (Bug#8640)
11916
57679c86
AS
119172011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11918
11919 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11920
888c9e86
EZ
119212011-05-07 Eli Zaretskii <eliz@gnu.org>
11922
b0512a1d
EZ
11923 * w32console.c (Fset_screen_color): Doc fix.
11924 (Fget_screen_color): New function.
11925 (syms_of_ntterm): Defsubr it.
11926
7285dc67
EZ
11927 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11928 unlink the temporary file if Fcall_process didn't create it in the
11929 first place.
11930 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11931 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11932 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11933 cue to call_process_cleanup not to close that handle.
11934
4d3fcc8e
BK
119352011-05-07 Ben Key <bkey76@gmail.com>
11936
11937 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11938 one of two shell specific rules, either bootstrap-temacs-CMD or
11939 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11940 to the previous implementation of the bootstrap-temacs rule.
11941 The bootstrap-temacs-CMD rule is similar to the previous
11942 implementation of the bootstrap-temacs rule except that it
11943 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11944 variable.
11945
11946 These changes, along with some changes to nt/configure.bat,
11947 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11948 earlier fix to add support for --cflags and --ldflags options
11949 that include quotes so that it works whether make uses cmd or
11950 sh as the shell.
11951
b4289b64
MA
119522011-05-06 Michael Albinus <michael.albinus@gmx.de>
11953
11954 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11955 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11956 is a constant.
11957 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11958 a string. Handle both cases.
11959 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11960 (Fdbus_register_method): Use Qinvalid_function.
11961
af4c0e28
JB
119622011-05-06 Juanma Barranquero <lekktu@gmail.com>
11963
11964 * makefile.w32-in: Update dependencies.
11965 (LISP_H): Add inttypes.h and stdin.h.
11966 (PROCESS_H): Add unistd.h.
11967
c51453d9
EZ
119682011-05-06 Eli Zaretskii <eliz@gnu.org>
11969
11970 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11971 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11972
8ff0ac3c 119732011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11974
4c4b566b
PE
11975 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11976
aab2b9b5
PE
11977 * term.c (vfatal): Remove stray call to va_end.
11978 It's not needed and the C Standard doesn't allow it here anyway.
11979
c378da0b
PE
11980 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11981 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11982
288b08c7
PE
11983 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11984 bytes.
11985
e3601888
PE
11986 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11987
db6c0e74
PE
11988 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11989
dd5963ea
PE
11990 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11991
88c9450f
PE
11992 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11993
2f9442b8
PE
11994 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11995
c032b5f8
PE
11996 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11997 * charset.c (Fdefine_charset_internal): Don't initialize
11998 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11999 32-bit int (Bug#8600).
a108c10b
PE
12000
12001 * lread.c (read_integer): Be more consistent with string-to-number.
12002 Use string_to_number to do the actual conversion; this avoids
12003 rounding errors and fixes some other screwups. Without this fix,
12004 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12005 (digit_to_number): Move earlier, for benefit of read_integer.
12006 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12007 not a digit in any supported base. (Bug#8602)
a108c10b 12008
ad5f9eea
PE
12009 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12010
aec1708a
PE
12011 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12012 to match comment at start of function. This also removes a
12013 GCC warning about overflow in a 32+64-bit port.
12014
47be4ab5
PE
12015 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12016
371cac43
PE
12017 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12018 Reported by Stefan Monnier in
12019 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12020 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12021 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12022
d01a7826
PE
12023 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12024 (EMACS_UINTPTR): Likewise, with uintptr_t.
12025
7fd47d5c
PE
12026 * lisp.h: Prefer 64-bit EMACS_INT if available.
12027 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12028 on 32-bit hosts that have 64-bit int, so that they can access
12029 large files.
122b0c86
PE
12030 However, temporarily disable this change unless the temporary
12031 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12032
8727937b
PE
12033 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12034
8ac068ac
PE
12035 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12036 This removes an assumption that EMACS_INT and long are the same
12037 width as pointers. The assumption is true for Emacs porting targets
12038 now, but we want to make other targets possible.
12039 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12040 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12041 In the rest of the code, change types of integers that hold casted
12042 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12043 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12044 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12045 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12046 No need to cast type when ORing.
12047 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12048 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12049 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12050 assume EMACS_INT is the same width as char *.
12051 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12052 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12053 Remove no-longer-needed casts.
12054 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12055 (xg_tool_bar_help_callback, xg_make_tool_item):
12056 Use EMACS_INTPTR to hold an integer
12057 that will be cast to void *; this can avoid a GCC warning
12058 if EMACS_INT is not the same width as void *.
12059 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12060 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12061 (current_message_1, set_message_1):
12062 Use a local to convert to proper width without a cast.
12063 * xmenu.c (dialog_selection_callback): Likewise.
12064
ede49d71
PE
12065 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12066 Also, don't assume VALBITS / RAND_BITS is less than 5,
12067 and don't rely on undefined behavior when shifting a 1 left into
12068 the sign bit.
12069 * lisp.h (get_random): Change signature to match.
12070
2f30ecd0
PE
12071 * lread.c (hash_string): Use size_t, not int, for hash computation.
12072 Normally we prefer signed values; but hashing is special, because
12073 it's better to use unsigned division on hash table sizes so that
12074 the remainder is nonnegative. Also, size_t is the natural width
12075 for hashing into memory. The previous code used 'int', which doesn't
12076 retain enough info to hash well into very large tables.
12077 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12078
2a866e7b
PE
12079 * dbusbind.c: Don't possibly lose pointer info when converting.
12080 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12081 Use XPNTR rather than XHASH, so that the high-order bits of
12082 the pointer aren't lost when converting through void *.
12083
51639eac
PE
12084 * eval.c (Fautoload): Don't double-shift a pointer.
12085
92394119
PE
12086 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12087
dbdb9a7c
JB
120882011-05-06 Juanma Barranquero <lekktu@gmail.com>
12089
12090 * gnutls.c (DEF_GNUTLS_FN):
12091 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12092
db7a0b4f
AS
120932011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12094
12095 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12096 marker. (Bug#8610)
12097
cd394be1 120982011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12099
12100 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12101 New version that can reserve upto 2GB of heap space.
12102
f7ff1b0f 121032011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12104
12105 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12106
639c109b
TZ
121072011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12108
12109 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12110 `gnutls_certificate_set_x509_key_file'.
12111
d2127135
JB
121122011-05-05 Juanma Barranquero <lekktu@gmail.com>
12113
12114 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12115 Update dependencies.
12116
e968f4f3
JB
121172011-05-04 Juanma Barranquero <lekktu@gmail.com>
12118
12119 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12120 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12121 Remove unused parameter `fildes'.
12122 * process.c (read_process_output, send_process): Don't pass it.
12123
84d358f0
JB
121242011-05-04 Juanma Barranquero <lekktu@gmail.com>
12125
12126 Fix previous change: the library cache is defined in w32.c.
12127 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12128 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12129
0898ca10
JB
121302011-05-04 Juanma Barranquero <lekktu@gmail.com>
12131
12132 Implement dynamic loading of GnuTLS on Windows.
12133
12134 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12135 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12136 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12137 Declare.
12138
12139 * gnutls.c (Qgnutls_dll): Define.
12140 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12141 (gnutls_*): Declare function pointers.
12142 (init_gnutls_functions): New function to initialize function pointers.
12143 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12144 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12145 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12146 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12147 (emacs_gnutls_write, emacs_gnutls_read)
12148 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12149 (Fgnutls_available_p): New function.
12150 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12151 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12152 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12153
12154 * image.c: Include w32.h.
12155 (Vimage_type_cache): Delete.
12156 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12157 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12158 (w32_delayed_load): Move to w32.c.
12159
12160 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12161
12162 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12163 (w32_delayed_load): Move from image.c. When loading a library, record
12164 its filename in the :loaded-from property of the library id.
12165 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12166 Initialize and staticpro them.
12167 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12168
12169 * process.c: Include lisp.h before w32.h, not after.
12170 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12171 instead of gnutls_record_check_pending.
12172
12173 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12174
ff4de4aa
TZ
121752011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12176
12177 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12178 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12179 as passed in.
12180
abe95abb
JD
121812011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12182
12183 * xterm.c (x_set_frame_alpha): Do not set property on anything
12184 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12185
e16e55d4
JB
121862011-05-02 Juanma Barranquero <lekktu@gmail.com>
12187
12188 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12189
bafcf6a5
JB
121902011-05-02 Juanma Barranquero <lekktu@gmail.com>
12191
12192 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12193 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12194 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12195 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12196 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12197 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12198 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12199 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12200 (Qgnutls_bootprop_callbacks_verify): Make static.
12201
e7a6747f
AS
122022011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12203
19ed11ba
AS
12204 * callproc.c: Indentation fixup.
12205
e7a6747f 12206 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12207 (wait_for_termination, interruptible_wait_for_termination):
12208 Move after wait_for_termination_1.
e7a6747f 12209
1ef14cb4
LMI
122102011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12211
12212 * sysdep.c (interruptible_wait_for_termination): New function
12213 which is like wait_for_termination, but allows keyboard
12214 interruptions.
12215
12216 * callproc.c (Fcall_process): Add (:file "file") as an option for
12217 the STDOUT buffer.
12218 (Fcall_process_region): Ditto.
12219
330d880c
EZ
122202011-04-30 Eli Zaretskii <eliz@gnu.org>
12221
8db90b73
EZ
12222 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12223 rather than `XVECTOR (FOO)->size'.
12224
330d880c
EZ
12225 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12226 inttypes.h, as a gnulib replacement is used if it not available in
12227 system headers.
12228
15cbd324
EZ
122292011-04-21 Eli Zaretskii <eliz@gnu.org>
12230
12231 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12232 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12233 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12234
12235 * coding.c (coding_alloc_by_realloc): Error out if destination
12236 will grow beyond MOST_POSITIVE_FIXNUM.
12237 (decode_coding_emacs_mule): Abort if there isn't enough place in
12238 charbuf for the composition carryover bytes. Reserve an extra
12239 space for up to 2 characters produced in a loop.
12240 (decode_coding_iso_2022): Abort if there isn't enough place in
12241 charbuf for the composition carryover bytes.
12242
122432011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12244
ae940cca
EZ
12245 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12246 aborting when %lld or %lll format is passed.
12247 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12248 %llo or %llx format is passed. (Bug#8545)
12249
03ab8921
EZ
12250 * window.c (window_scroll_line_based): Use a marker instead of
12251 simple variables to record original value of point. (Bug#7952)
12252
afda1437
EZ
12253 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12254 produced by %s or %c overflows available buffer space. (Bug#8545)
12255
f76dee0c
PE
122562011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12257
12258 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12259 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12260
fdc5744d
JB
122612011-04-28 Juanma Barranquero <lekktu@gmail.com>
12262
12263 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12264
638f053a
JB
122652011-04-28 Juanma Barranquero <lekktu@gmail.com>
12266
12267 * keyboard.c (Qdelayed_warnings_hook): Define.
12268 (command_loop_1): Run `delayed-warnings-hook'
12269 if Vdelayed_warnings_list is non-nil.
12270 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12271 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12272
d178f871
EZ
122732011-04-28 Eli Zaretskii <eliz@gnu.org>
12274
12275 * doprnt.c (doprnt): Don't return value smaller than the buffer
12276 size if the message was truncated. (Bug#8545).
12277
b124fd93
JB
122782011-04-28 Juanma Barranquero <lekktu@gmail.com>
12279
12280 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12281 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12282
e810457d
PE
122832011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12284
12285 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12286
ea51cceb
JB
122872011-04-27 Juanma Barranquero <lekktu@gmail.com>
12288
12289 * makefile.w32-in: Update dependencies.
12290
94dcfacf
EZ
122912011-04-27 Eli Zaretskii <eliz@gnu.org>
12292
12293 Improve `doprnt' and its usage. (Bug#8545)
12294 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12295 `format_end'. Remove support for %l as a conversion specifier.
12296 Don't use xrealloc. Improve diagnostics when the %l size modifier
12297 is used. Update the commentary.
12298
12299 * eval.c (verror): Simplify calculation of size_t.
12300
12301 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12302 messages.
12303
f61f41d7
PE
123042011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12305
12306 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12307 change.
12308
96fb4434
PE
123092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12310
12311 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12312 This makes this file independent of the recent pseudovector change.
12313
671875da 123142011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12315
69e9b5a3
PE
12316 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12317
b5f869a7 12318 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12319 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12320 Remove unused local.
c8926152 12321 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12322
841a1577 12323 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12324 GCC 4.6.0 optimizes based on type-based alias analysis.
12325 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12326 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12327 != &v->size, and therefore "v->size = 1; b->size = 2; return
12328 v->size;" must therefore return 1. This assumption is incorrect
12329 for Emacs, since it type-puns struct Lisp_Vector * with many other
12330 types. To fix this problem, this patch adds a new type struct
f904488f 12331 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12332 and pseudovectors, and helps optimizing compilers not get fooled
12333 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12334 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12335 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12336 the size member.
eab3844f
PE
12337 (XSETPVECTYPE): Rewrite in terms of new macro.
12338 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12339 This is a bit clearer, and further avoids the possibility of
12340 undesirable aliasing.
12341 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12342 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12343 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12344 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12345 (ASIZE): Now uses header.size rather than size.
12346 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12347 to avoid the hassle of writing XVECTOR (foo)->header.size.
12348 (struct vectorlike_header): New type.
eab3844f
PE
12349 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12350 object, to help avoid aliasing.
12351 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12352 (SUBRP): Likewise, since Lisp_Subr is a special case.
12353 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12354 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12355 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12356 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12357 changed to be "header.size" and "header.next".
12358 * buffer.h (struct buffer): Likewise.
12359 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12360 * frame.h (struct frame): Likewise.
12361 * process.h (struct Lisp_Process): Likewise.
12362 * termhooks.h (struct terminal): Likewise.
12363 * window.c (struct save_window_data, struct saved_window): Likewise.
12364 * window.h (struct window): Likewise.
12365 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12366 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12367 * buffer.c (init_buffer_once): Likewise.
12368 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12369 special case.
12370 * process.c (Fformat_network_address): Use local var for size,
12371 for brevity.
12372
0df1eac5
PE
12373 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12374
847ab9d1 12375 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12376 * data.c (atof): Remove decl; no longer used or needed.
12377 (digit_to_number): Move to lread.c.
12378 (Fstring_to_number): Use new string_to_number function, to be
12379 consistent with how the Lisp reader treats infinities and NaNs.
12380 Do not assume that floating-point numbers represent EMACS_INT
12381 without losing information; this is not true on most 64-bit hosts.
12382 Avoid double-rounding errors, by insisting on integers when
12383 parsing non-base-10 numbers, as the documentation specifies.
12384 * lisp.h (string_to_number): New decl, replacing ...
12385 (isfloat_string): Remove.
bc0a5c13 12386 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12387 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12388 appears to have been a coding error. Similarly, do not accept
12389 strings like +-1e0 as floating point numbers. Do not report
12390 overflow for integer overflows unless the base is not 10 which
12391 means we have no simple and reliable way to continue.
12392 Break out the floating-point parsing into a new
12393 function string_to_number, so that Fstring_to_number parses
12394 floating point numbers consistently with the Lisp reader.
04f2d78b 12395 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12396 (E_CHAR, EXP_INT): Remove, replacing with ...
12397 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12398 (string_to_number): New function, replacing isfloat_string.
12399 This function checks for valid syntax and produces the resulting
12400 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12401 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12402 so that overflow for non-base-10 numbers is reported only when
12403 there's no portable and simple way to convert to floating point.
452f4150 12404
67769ffc
PE
12405 * textprop.c (set_text_properties_1): Rewrite for clarity,
12406 and to avoid GCC warning about integer overflow.
12407
c20db43f
PE
12408 * intervals.h (struct interval): Use EMACS_INT for members
12409 where EMACS_UINT might cause problems. See
12410 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12411 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12412 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12413 All uses changed.
37aa2f85
PE
12414 (offset_intervals): Tell GCC not to worry about length overflow
12415 when negating a negative length.
c20db43f 12416
2538aa2f
PE
12417 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12418 (overrun_check_free): Likewise.
12419
f2d3008d
PE
12420 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12421 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12422 word size.
12423
ec8df744
PE
12424 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12425 (gnutls_make_error): Rename local to avoid shadowing.
12426 (gnutls_emacs_global_deinit): ifdef out; not used.
12427 (Fgnutls_boot): Use const for pointer to readonly storage.
12428 Comment out unused local. Fix pointer signedness problems.
12429
640ee02d
PE
12430 * lread.c (openp): Don't stuff size_t into an 'int'.
12431 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12432 about possible signed overflow.
12433
6048fb2a
PE
12434 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12435 (GDK_KEY_g): Don't define if already defined.
12436 (xg_prepare_tooltip): Avoid pointer signedness problem.
12437 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12438
fa3c87e1
PE
12439 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12440 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12441
2172544b
PE
12442 * xfns.c (Fx_window_property): Simplify a bit,
12443 to make a bit faster and to avoid GCC 4.6.0 warning.
12444 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12445
9b821a21
PE
12446 * fns.c (internal_equal): Don't assume size_t fits in int.
12447
3c616cfa
PE
12448 * alloc.c (compact_small_strings): Tighten assertion a little.
12449
c2982e87
PE
12450 Replace pEd with more-general pI, and fix some printf arg casts.
12451 * lisp.h (pI): New macro, generalizing old pEd macro to other
12452 conversion specifiers. For example, use "...%"pI"d..." rather
12453 than "...%"pEd"...".
12454 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12455 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12456 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12457 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12458 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12459 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12460 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12461 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12462 64-bit hosts.
12463 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12464 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12465 * print.c (safe_debug_print, print_object): Likewise.
12466 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12467 to int.
6f04d126
PE
12468 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12469 avoiding the 0 flag, which is not portable.
c2982e87
PE
12470 * process.c (Fmake_network_process): Use pI to avoid cast.
12471 * region-cache.c (pp_cache): Likewise.
12472 * xdisp.c (decode_mode_spec): Likewise.
12473 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12474 behavior on 64-bit hosts with printf arg.
6f04d126 12475 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12476 (x_stop_queuing_selection_requests): Likewise.
12477 (x_get_window_property): Don't truncate byte count to an 'int'
12478 when tracing.
0b432f21 12479
5e073ec7
PE
12480 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12481 here, since it parses constructs like leading '-' and spaces,
12482 which are not wanted; and it overflows with large numbers.
12483 Instead, simply match F[0-9]+, which is what is wanted anyway.
12484
36372bf9
PE
12485 * alloc.c: Remove unportable assumptions about struct layout.
12486 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12487 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12488 (allocate_vectorlike, make_pure_vector): Use the new macros,
12489 plus offsetof, to remove unportable assumptions about struct layout.
12490 These assumptions hold on all porting targets that I know of, but
12491 they are not guaranteed, they're easy to remove, and removing them
12492 makes further changes easier.
12493
0b432f21
PE
12494 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12495 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12496 (string_overrun_cookie): Now const. Use initializers that
12497 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12498 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12499 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12500 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12501 multiple of sizeof (EMACS_INT); it need not be, if
12502 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12503 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12504
895009e1
JB
125052011-04-26 Juanma Barranquero <lekktu@gmail.com>
12506
12507 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12508
6a7a1b0b
TZ
125092011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12510
12511 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12512 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12513 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12514
841a1577 125152011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12516
12517 * lisp.h (Qdebug): List symbol.
895009e1 12518 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12519 * keyboard.c (debug-on-event): New variable.
12520 (handle_user_signal): Break into debugger when debug-on-event
12521 matches the current signal symbol.
12522
f2d3ba6f
DN
125232011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12524
12525 * alloc.c (check_sblock, check_string_bytes)
12526 (check_string_free_list): Convert to standard C.
12527
42ce4c63
TZ
125282011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12529
12530 * w32.c (emacs_gnutls_push): Fix typo.
12531
825cd63c
EZ
125322011-04-25 Eli Zaretskii <eliz@gnu.org>
12533
fb11d64d
EZ
12534 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12535 "cast to pointer from integer of different size".
12536
825cd63c
EZ
12537 Improve doprnt and its use in verror. (Bug#8545)
12538 * doprnt.c (doprnt): Document the set of format control sequences
12539 supported by the function. Use SAFE_ALLOCA instead of always
12540 using `alloca'.
12541
12542 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12543 is one byte too soon. Don't use xrealloc; instead xfree and
12544 xmalloc anew.
12545
e061a11b
TZ
125462011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12547
12548 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12549 callbacks stage.
12550
12551 * gnutls.c: Renamed global_initialized to
12552 gnutls_global_initialized. Added internals for the
12553 :verify-hostname-error, :verify-error, and :verify-flags
12554 parameters of `gnutls-boot' and documented those parameters in the
12555 docstring. Start callback support.
9173deec
JB
12556 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12557 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12558 on error. Return error code.
e061a11b
TZ
12559 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12560 (emacs_gnutls_read): Likewise.
12561 (Fgnutls_boot): Return handshake error code.
12562 (emacs_gnutls_handle_error): New function.
12563 (wsaerror_to_errno): Likewise.
12564
12565 * w32.h (emacs_gnutls_pull): Add prototype.
12566 (emacs_gnutls_push): Likewise.
12567
12568 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12569 (emacs_gnutls_push): Likewise.
12570
125712011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12572
12573 * process.c (wait_reading_process_output): Check if GnuTLS
12574 buffered some data internally if no FDs are set for TLS
12575 connections.
12576
12577 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12578 (LIBS): Link to USER_LIBS.
12579 ($(BLD)/gnutls.$(0)): New target.
12580
fa6996bc
EZ
125812011-04-24 Eli Zaretskii <eliz@gnu.org>
12582
eb35682e
EZ
12583 * xdisp.c (handle_single_display_spec): Rename the
12584 display_replaced_before_p argument into display_replaced_p, to
12585 make it consistent with the commentary. Fix typos in the
12586 commentary.
12587
e2ad650c
EZ
12588 * textprop.c (syms_of_textprop): Remove dead code.
12589 (copy_text_properties): Delete obsolete commentary about an
12590 interface that was deleted long ago. Fix typos in the description
12591 of arguments.
12592
1b2de274
EZ
12593 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12594 to changes in oldXMenu/XMenu.h from 2011-04-16.
12595 <menu_help_message, prev_menu_help_message>: Constify.
12596 (IT_menu_make_room): menu->help_text is now `const char **';
12597 adjust.
12598
12599 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12600 to changes in oldXMenu/XMenu.h from 2011-04-16.
12601 (struct XMenu): Declare `help_text' `const char **'.
12602
12603 * xfaces.c <Qunspecified>: Make extern again.
12604
12605 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12606 required by POSIX.
1b2de274 12607
762b15be
EZ
12608 * doc.c (get_doc_string): Improve the format passed to `error'.
12609
12610 * doprnt.c (doprnt): Improve commentary.
12611
12612 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12613
12614 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12615 them with etags.
12616
f1052e5d
EZ
12617 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12618 changes in globals.h immediately force recompilation.
762b15be
EZ
12619 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12620 $(CURDIR)/s/ms-w32.h.
12621 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12622
fa6996bc
EZ
12623 * character.c (Fchar_direction): Function deleted.
12624 (syms_of_character): Don't defsubr it.
12625 <char-direction-table>: Deleted.
12626
e6c3da20
EZ
126272011-04-23 Eli Zaretskii <eliz@gnu.org>
12628
12629 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12630 * doprnt.c: Include limits.h.
12631 (SIZE_MAX): New macro.
04f2d78b
CB
12632 (doprnt): Return a size_t value. 2nd arg is now size_t.
12633 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12634 Improve overflow protection. Support `l' modifier for integer
12635 conversions. Support %l conversion. Don't assume an EMACS_INT
12636 argument for integer conversions and for %c.
12637
12638 * lisp.h (doprnt): Restore prototype.
12639
12640 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12641 $(SRC)/character.h.
12642
12643 * Makefile.in (base_obj): Add back doprnt.o.
12644
12645 * deps.mk (doprnt.o): Add back prerequisites.
12646 (callint.o): Depend on character.h.
12647
12648 * eval.c (internal_lisp_condition_case): Include the handler
12649 representation in the error message.
12650 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12651 when breaking from the loop.
12652
12653 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12654
12655 * callint.c (Fcall_interactively): When displaying error message
12656 about invalid control letter, pass the character's codepoint, not
12657 a pointer to its multibyte form. Improve display of the character
12658 in octal and display also its hex code.
12659
12660 * character.c (char_string): Use %x to display the (unsigned)
12661 codepoint of an invalid character, to avoid displaying a bogus
12662 negative value.
12663
12664 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12665 `error', not SYMBOL_NAME itself.
12666
12667 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12668 character arguments to `error'.
12669
12670 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12671 to `error' in error message about FINAL_CHAR argument. Make sure
12672 FINAL_CHAR is a character, and use %c when it is passed as
12673 argument to `error'.
12674
4ffd0d6b 126752011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12676
12677 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12678
12679 * w32.c: Include <time.h>.
12680 (sys_localtime): New function.
12681
4ffd0d6b 126822011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12683
12684 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12685
4ffd0d6b 12686 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12687
4ffd0d6b 126882011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12689
4ffd0d6b
GM
12690 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12691 zombies (Bug#8467).
aac0c6e3 12692
04c56954
EZ
126932011-04-19 Eli Zaretskii <eliz@gnu.org>
12694
12695 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12696 gl_state.e_property when gl_state.object is Qt.
12697
12698 * insdel.c (make_gap_larger): Remove limitation of buffer size
12699 to <= INT_MAX.
12700
16a43933
CY
127012011-04-18 Chong Yidong <cyd@stupidchicken.com>
12702
12703 * xdisp.c (lookup_glyphless_char_display)
12704 (produce_glyphless_glyph): Handle cons cell entry in
12705 glyphless-char-display.
12706 (Vglyphless_char_display): Document it.
12707
12708 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12709 glyphless-char-display.
12710
4581706e
CY
127112011-04-17 Chong Yidong <cyd@stupidchicken.com>
12712
12713 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12714
12715 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12716
12717 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12718 definition for no-X builds.
12719
4887c6e2 127202011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12721
fd35b6f9
PE
12722 Static checks with GCC 4.6.0 and non-default toolkits.
12723
5c1ccb01
PE
12724 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12725
006c5daa
PE
12726 * process.c (keyboard_bit_set): Define only if SIGIO.
12727 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12728 (send_process): Repair possible setjmp clobbering.
12729
efc736d3
PE
12730 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12731
4e2fe2e6
PE
12732 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12733
f97334a2
PE
12734 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12735
4e75f29d
PE
12736 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12737 Define only if needed.
12738
90efadd1
PE
12739 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12740 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12741 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12742
3c647824
PE
12743 * dispextern.h (struct redisplay_interface): Rename param
12744 to avoid shadowing.
e264f262 12745 * termhooks.h (struct terminal): Likewise.
761383f4 12746 * xterm.c (xembed_send_message): Likewise.
3c647824 12747
b58c5c4a
PE
12748 * insdel.c (make_gap_smaller): Define only if
12749 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12750
cad59032
PE
12751 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12752 it.
12753
c339dc2e
PE
12754 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12755 so that we aren't warned about unused symbols.
12756
91a3e27b
PE
12757 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12758
399c71d3 12759 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12760
8ffc96f5
PE
12761 * xfns.c (x_real_positions): Mark locals as initialized.
12762
eef9bc79
PE
12763 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12764
098db9dd
PE
12765 * xterm.c: Fix problems found by static analysis with other toolkits.
12766 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12767 (x_dispatch_event): Declare static if USE_GTK, and
12768 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12769 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12770 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12771 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12772 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12773
eb18f6cc
PE
12774 * xmenu.c (menu_help_callback): Pointer type fixes.
12775 Use const pointers when pointing at readonly data. Avoid pointer
12776 signedness clashes.
12777 (FALSE): Remove unused macro.
12778 (update_frame_menubar): Remove unused decl.
12779
1fe72bf8
PE
12780 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12781
60d9e1db
PE
12782 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12783 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12784 (single_menu_item): Rename local to avoid shadowing.
12785
39261c26
PE
12786 * keyboard.c (make_lispy_event): Remove unused local var.
12787
018c5e19
PE
12788 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12789 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12790
63d2b86e
PE
12791 * bitmaps: Change bitmaps from unsigned char back to the X11
12792 compatible char. Avoid the old compiler warnings about
12793 out-of-range initializers by using, for example, '\xab' rather
12794 than 0xab.
12795
aefd87e1
PE
12796 * xgselect.c (xgselect_initialize): Check vs interface
12797 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12798
bf501fb9
PE
12799 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12800
e9829fdf
PE
12801 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12802 to read-only memory.
12803
1086c095
PE
12804 * fns.c (vector): Remove; this old hack is no longer needed.
12805
2baccd04 12806 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12807 Remove unused var.
dde42981 12808 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12809
72391843 12810 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12811
436c16df 12812 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12813 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12814 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12815
92bb796d 12816 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12817 (x_term_init): Remove local to avoid shadowing.
92bb796d 12818
764430a3 12819 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12820
12821 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12822 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12823
d1dfb56c
EZ
128242011-04-16 Eli Zaretskii <eliz@gnu.org>
12825
c4354cb4
EZ
12826 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12827
d1dfb56c
EZ
12828 Fix regex.c, syntax.c and friends for buffers > 2GB.
12829 * syntax.h (struct gl_state_s): Declare character position members
12830 EMACS_INT.
12831
12832 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12833
04f2d78b
CB
12834 * textprop.c (verify_interval_modification, interval_of):
12835 Declare arguments EMACS_INT.
d1dfb56c
EZ
12836
12837 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12838 EMACS_INT.
12839
12840 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12841
12842 * indent.c (Fvertical_motion): Local variable it_start is now
12843 EMACS_INT.
12844
12845 * regex.c (re_match, re_match_2, re_match_2_internal)
12846 (bcmp_translate, regcomp, regexec, print_double_string)
12847 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12848 (re_compile_pattern, re_exec): Declare arguments and local
12849 variables `size_t' and `ssize_t' and return values `regoff_t', as
12850 appropriate.
12851 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12852 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12853 <compile_stack_type>: `size' and `avail' are now `size_t'.
12854
12855 * regex.h <regoff_t>: Use ssize_t, not int.
12856 (re_search, re_search_2, re_match, re_match_2): Arguments that
12857 specify buffer/string position and length are now ssize_t and
12858 size_t. Return type is regoff_t.
12859
613052cd
BK
128602011-04-16 Ben Key <bkey76@gmail.com>
12861
12862 * nsfont.m: Fixed bugs in ns_get_family and
12863 ns_descriptor_to_entity that were caused by using free to
12864 deallocate memory blocks that were allocated by xmalloc (via
12865 xstrdup). This caused Emacs to crash when compiled with
12866 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12867 --enable-checking=xmallocoverrun). xfree is now used to
12868 deallocate these memory blocks.
12869
4170f62f 128702011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12871
71b41406
PE
12872 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12873
9587a89d
PE
12874 emacs_write: Accept and return EMACS_INT for sizes.
12875 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12876 et seq.
12877 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12878 Accept and return EMACS_INT.
12879 (emacs_gnutls_write): Return the number of bytes written on
12880 partial writes.
12881 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12882 (emacs_read, emacs_write): Remove check for negative size, as the
12883 Emacs source code has been audited now.
9587a89d
PE
12884 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12885 (emacs_read, emacs_write): Use it.
273a5f82
PE
12886 * process.c (send_process): Adjust to the new signatures of
12887 emacs_write and emacs_gnutls_write. Do not attempt to store
12888 a byte offset into an 'int'; it might overflow.
9587a89d 12889 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12890
3e047f51
PE
12891 * sound.c: Don't assume sizes fit in 'int'.
12892 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12893 Return EMACS_INT, not int.
3e047f51 12894 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12895 Accept EMACS_INT, not int.
12896 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12897 record read return values.
12898
cc39a9db
BK
128992011-04-15 Ben Key <bkey76@gmail.com>
12900
c9d0ec6d
JB
12901 * keyboard.c (Qundefined): Don't declare static since it is used
12902 in nsfns.m.
12903 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12904 static since they are used in nsfont.m.
cc39a9db 12905
6c60eb9f
SM
129062011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12907
12908 * process.c (Qprocessp): Don't declare static.
12909 * lisp.h (Qprocessp): Declare again.
12910
7990b61a
JB
129112011-04-15 Juanma Barranquero <lekktu@gmail.com>
12912
12913 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12914
5d4cb038
PE
129152011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12916
8bd7b830 12917 Improve C-level modularity by making more things 'static'.
cd64ea1d 12918
e3b27b31
PE
12919 Don't publish debugger-only interfaces to other modules.
12920 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12921 (verify_bytepos, count_markers): Move decls to the only modules
12922 that need them.
12923 * region-cache.h (pp_cache): Likewise.
12924 * window.h (check_all_windows): Likewise.
12925 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12926
5d4cb038
PE
12927 * sysdep.c (croak): Now static, if
12928 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12929 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12930
12931 * alloc.c (refill_memory_reserve): Now static if
12932 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12933 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12934
e87b6180
PE
12935 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12936 Define only if USE_LUCID.
12937
ac64929e
PE
12938 * xrdb.c (x_customization_string, x_rm_string): Now static.
12939
6f37259d
PE
12940 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12941 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12942
1683e3ab
PE
12943 * xdisp.c (draw_row_with_mouse_face): Now static.
12944 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12945
de9c2632
PE
12946 * window.h (check_all_windows): Mark externally visible.
12947
2b96acb7
PE
12948 * window.c (window_deletion_count): Now static.
12949
12950 * undo.c: Make symbols static if they're not exported.
12951 (last_undo_buffer, last_boundary_position, pending_boundary):
12952 Now static.
12953
50436f33
PE
12954 * textprop.c (interval_insert_behind_hooks): Now static.
12955 (interval_insert_in_front_hooks): Likewise.
12956
64520e5c
PE
12957 * term.c: Make symbols static if they're not exported.
12958 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12959 (max_frame_lines, tty_set_terminal_modes):
12960 (tty_reset_terminal_modes, tty_turn_off_highlight):
12961 (get_tty_terminal): Now static.
12962 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12963 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12964 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12965 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12966 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12967
1fa53021
PE
12968 * sysdep.c: Make symbols static if they're not exported.
12969 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12970 Now static.
12971 (sigprocmask_set, full_mask): Remove; unused.
12972 (wait_debugging): Mark as visible.
12973 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12974 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12975
d4b43b22
PE
12976 * syntax.c (syntax_temp): Define only if !__GNUC__.
12977
b7c513d0
PE
12978 * sound.c (current_sound_device, current_sound): Now static.
12979
989b29ad
PE
12980 * search.c (searchbufs, searchbuf_head): Now static.
12981
13a55a78
PE
12982 * scroll.c (scroll_cost): Remove; unused.
12983 * dispextern.h (scroll_cost): Remove decl.
12984
de68a1fc
PE
12985 * region-cache.h (pp_cache): Mark as externally visible.
12986
40ccffa6
PE
12987 * process.c: Make symbols static if they're not exported.
12988 (process_tick, update_tick, create_process, chan_process):
12989 (Vprocess_alist, proc_buffered_char, datagram_access):
12990 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12991 (deactivate_process): Mark defn as static, as well as decl.
12992 * lisp.h (create_process): Remove decl.
12993 * process.h (chan_process, Vprocess_alist): Remove decls.
12994
ad64fc97
PE
12995 * print.c: Make symbols static if they're not exported.
12996 (print_depth, new_backquote_output, being_printed, print_buffer):
12997 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12998 (print_interval, print_number_index, initial_stderr_stream):
12999 Now static.
13000 * lisp.h (Fprinc): Remove decl.
13001 (debug_output_compilation_hack): Mark as externally visible.
13002
adddb265
PE
13003 * sysdep.c (croak): Move decl from here to syssignal.h.
13004 * syssignal.h (croak): Put it here, so the API can be checked when
13005 'croak' is called from dissociate_if_controlling_tty.
13006
1717ede2
PE
13007 * minibuf.c: Make symbols static if they're not exported.
13008 (minibuf_save_list, choose_minibuf_frame): Now static.
13009 * lisp.h (choose_minibuf_frame): Remove decl.
13010
fa5fb2bc
PE
13011 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13012
1e3890d1
PE
13013 * lread.c: Make symbols static if they're not exported.
13014 (read_objects, initial_obarray, oblookup_last_bucket_number):
13015 Now static.
13016 (make_symbol): Remove; unused.
13017 * lisp.h (initial_obarray, make_symbol): Remove decls.
13018
8a1414fa
PE
13019 * keyboard.c: Make symbols static if they're not exported.
13020 (single_kboard, recent_keys_index, total_keys, recent_keys):
13021 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13022 (this_single_command_key_start, echoing, last_auto_save):
13023 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13024 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13025 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13026 (Vlispy_mouse_stem, double_click_count):
13027 Now static.
13028 (force_auto_save_soon): Define only if SIGDANGER.
13029 (ignore_mouse_drag_p): Now static if
13030 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13031 (print_help): Remove; unused.
13032 (stop_character, last_timer_event): Mark as externally visible.
13033 * keyboard.h (ignore_mouse_drag_p): Declare only if
13034 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13035 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13036 * lisp.h (echoing): Remove decl.
13037 (force_auto_save_soon): Declare only if SIGDANGER.
13038 * xdisp.c (redisplay_window): Simplify code, to make it more
13039 obvious that ignore_mouse_drag_p is not accessed if !defined
13040 USE_GTK && !defined HAVE_NS.
13041
93ea6e8f
PE
13042 * intervals.c: Make symbols static if they're not exported.
13043 (merge_properties_sticky, merge_interval_right, delete_interval):
13044 Now static.
13045 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13046
77382fcc
PE
13047 * insdel.c: Make symbols static if they're not exported.
13048 However, leave prepare_to_modify_buffer alone. It's never
13049 called from outside this function, but that appears to be a bug.
13050 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13051 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13052 (adjust_after_replace_noundo): Remove; unused.
13053 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13054 (signal_before_change): Remove decls.
77382fcc 13055
9306c32e
PE
13056 * indent.c (val_compute_motion, val_vmotion): Now static.
13057
cd44d2eb
PE
13058 * image.c: Make symbols static if they're not exported.
13059 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13060 if USE_GTK.
13061 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13062 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13063
ad9a7a06
PE
13064 * fringe.c (standard_bitmaps): Now static.
13065 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13066
81626931
PE
13067 * frame.c: Make symbols static if they're not exported.
13068 (x_report_frame_params, make_terminal_frame): Now static.
13069 (get_frame_param): Now static, unless HAVE_NS.
13070 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13071 (x_get_resource_string): Remove; not used.
13072 * frame.h (make_terminal_frame, x_report_frame_params):
13073 (x_get_resource_string); Remove decls.
13074 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13075 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13076
239f9db9
PE
13077 * font.c, fontset.c: Make symbols static if they're not exported.
13078 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13079 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13080 * font.c (font_close_object): Now static.
13081 * font.h (font_close_object): Remove.
13082 * fontset.c (FONTSET_OBJLIST): Remove.
13083 (free_realized_fontset) #if-0 the body, which does nothing.
13084 (face_suitable_for_char_p): #if-0, as it's never called.
13085 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13086 * xfaces.c (face_at_string_position):
13087 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13088 since 0 is always ASCII.
13089
dfcf3579
PE
13090 * fns.c (weak_hash_tables): Now static.
13091
5045092b
PE
13092 * fileio.c: Make symbols static if they're not exported.
13093 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13094 (Vwrite_region_annotation_buffers): Now static.
13095
57a96f5c
PE
13096 * eval.c: Make symbols static if they're not exported.
13097 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13098 * lisp.h (backtrace_list): Remove decl.
13099
35f08c38
PE
13100 * emacs.c: Make symbols static if they're not exported.
13101 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13102 (fatal_error_code, fatal_error_signal_hook, standard_args):
13103 Now static.
13104 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13105 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13106 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13107 * lisp.h (fatal_error_signal_hook): Remove decl.
13108 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13109
f44bd759
PE
13110 * editfns.c: Move a (normally-unused) function to its only use.
13111 * editfns.c, lisp.h (get_operating_system_release): Remove.
13112 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13113 worth the hassle of breaking this out.
13114
b532497d
PE
13115 * xterm.c: Make symbols static if they're not exported.
13116 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13117 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13118 (x_destroy_window, x_delete_display):
13119 Now static.
13120 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13121 (x_mouse_leave): Remove; unused.
13122 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13123 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13124 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13125 Remove decls.
13126 (x_mouse_leave): Declare only if WINDOWSNT.
13127 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13128 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13129 USE_X_TOOLKIT.
13130
1675728f
PE
13131 * ftxfont.c: Make symbols static if they're not exported.
13132 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13133 HAVE_FREETYPE.
13134 * font.h (ftxfont_driver): Likewise.
13135
e4cebfca
PE
13136 * xfns.c: Make symbols static if they're not exported.
13137 (x_last_font_name, x_display_info_for_name):
13138 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13139 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13140 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13141 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13142 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13143 (last_show_tip_args): Now static.
13144 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13145 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13146 (x_screen_planes): Remove; unused.
13147 * dispextern.h (x_screen_planes): Remove decl.
13148
5bf46f05
PE
13149 * dispnew.c: Make symbols static if they're not exported.
13150 * dispextern.h (redraw_garbaged_frames, scrolling):
13151 (increment_row_positions): Remove.
13152 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13153 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13154 Now static.
13155 (redraw_garbaged_frames): Remove; unused.
13156
435f4c28
PE
13157 * xfaces.c: Make symbols static if they're not exported.
13158 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13159 Remove decls.
13160 * xterm.h (defined_color): Remove decls.
13161 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13162 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13163 (menu_face_changed_default, defined_color, free_realized_face):
13164 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13165 (ascii_face_of_lisp_face): Remove; unused.
13166
8524aef3
PE
13167 * xdisp.c: Make symbols static if they're not exported.
13168 * dispextern.h (scratch_glyph_row, window_box_edges):
13169 (glyph_to_pixel_coords, set_cursor_from_row):
13170 (get_next_display_element, set_iterator_to_next):
13171 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13172 (show_mouse_face): Remove decls
13173 * frame.h (message_buf_print): Likewise.
13174 * lisp.h (pop_message, set_message, check_point_in_composition):
13175 Likewise.
13176 * xterm.h (set_vertical_scroll_bar): Likewise.
13177 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13178 (message_buf_print, scratch_glyph_row, displayed_buffer):
13179 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13180 (get_next_display_element, show_mouse_face, window_box_edges):
13181 (frame_to_window_pixel_xy, check_point_in_composition):
13182 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13183 (glyph_to_pixel_coords): Remove; unused.
13184
16390cd2
PE
13185 * dired.c (file_name_completion): Now static.
13186
13187 * dbusbind.c (xd_in_read_queued_messages): Now static.
13188
a25f4dfa
PE
13189 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13190 * data.c (circular_list_error): Remove.
13191
14a9c8df
PE
13192 * commands.h (last_point_position, last_point_position_buffer):
13193 (last_point_position_window): Remove decls.
13194 * keyboard.c: Make these variables static.
13195
04f2d78b
CB
13196 * coding.h (coding, code_convert_region, encode_coding_gap):
13197 Remove decls.
74ab6df5
PE
13198 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13199 (iso_code_class, detect_coding, code_convert_region): Now static.
13200 (encode_coding_gap): Remove; unused.
13201
38dfbee1
PE
13202 * chartab.c (chartab_chars, chartab_bits): Now static.
13203
a2cb4e63
PE
13204 * charset.h (charset_iso_8859_1): Remove decl.
13205 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13206 Now static.
13207
127198fd
PE
13208 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13209 * ccl.c (Vccl_program_table): Now static.
13210 (check_ccl_update): Remove; unused.
13211
d85b608f
PE
13212 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13213 * category.h: ... from here.
13214 * category.c (check_category_table, set_category_set): Now static.
13215
31cd66f3
PE
13216 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13217 * lisp.h: Remove these decls.
13218
c358e587
PE
13219 * buffer.c (buffer_count): Remove unused var.
13220
e78aecca
PE
13221 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13222 so that it's not optimized away.
13223 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13224 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13225 exported only to the debugger.
13226
e192d7d3 13227 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13228 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13229
92470028
PE
13230 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13231 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13232 was inaccessible from Lisp.
13233 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13234 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13235
244ed907
PE
13236 alloc.c: Import and export fewer symbols, and remove unused items.
13237 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13238 is defined.
13239 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13240 it's not optimized away by whole-program optimization.
13241 (message_enable_multibyte, free_misc): Remove.
13242 (catchlist, handlerlist, mark_backtrace):
13243 Declare only if BYTE_MARK_STACK.
13244 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13245 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13246 (message_enable_multibyte): Remove decl.
13247 (free_misc, interval_free_list, float_block, float_block_index):
13248 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13249 (cons_free_list, last_marked_index):
13250 Now static.
13251 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13252 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13253 (mark_backtrace): Define only if BYTE_MARK_STACK.
13254 * xdisp.c (message_enable_multibyte): Now static.
13255
61c2b50e 13256 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13257 This makes it easier for human readers (and static analyzers)
13258 to see whether these variables are used from other modules.
13259 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13260 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13261 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13262 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13263 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13264 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13265 * xmenu.c, xselect.c:
13266 Declare Q* vars static if they are not used in other modules.
13267 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13268 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13269 Remove decls of unexported vars.
13270 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13271
95c82688
PE
13272 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13273
16a97296
PE
13274 Make Emacs functions such as Fatom 'static' by default.
13275 This makes it easier for human readers (and static analyzers)
13276 to see whether these functions can be called from other modules.
13277 DEFUN now defines a static function. To make the function external
13278 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13279 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13280 (Finit_image_library):
16a97296
PE
13281 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13282 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13283 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13284 Remove decls, since these functions are now static.
13285 (Funintern, Fget_internal_run_time): New decls, since these functions
13286 were already external.
95c82688 13287
16a97296
PE
13288 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13289 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13290 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13291 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13292 * keyboard.c, keymap.c, lread.c:
13293 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13294 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13295 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13296 Mark functions with DEFUE instead of DEFUN,
13297 if they are used in other modules.
13298 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13299 decls for now-static functions.
13300 * buffer.h (Fdelete_overlay): Remove decl.
13301 * callproc.c (Fgetenv_internal): Mark as internal.
13302 * composite.c (Fremove_list_of_text_properties): Remove decl.
13303 (Fcomposition_get_gstring): New forward static decl.
13304 * composite.h (Fcomposite_get_gstring): Remove decl.
13305 * dired.c (Ffile_attributes): New forward static decl.
13306 * doc.c (Fdocumntation_property): New forward static decl.
13307 * eval.c (Ffetch_bytecode): New forward static decl.
13308 (Funintern): Remove extern decl; now in .h file where it belongs.
13309 * fileio.c (Fmake_symbolic_link): New forward static decl.
13310 * image.c (Finit_image_library): New forward static decl.
13311 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13312 * intervals.h (Fprevious_property_change):
13313 (Fremove_list_of_text_properties): Remove decls.
13314 * keyboard.c (Fthis_command_keys): Remove decl.
13315 (Fcommand_execute): New forward static decl.
13316 * keymap.c (Flookup_key): New forward static decl.
13317 (Fcopy_keymap): Now static.
13318 * keymap.h (Flookup_key): Remove decl.
13319 * process.c (Fget_process): New forward static decl.
13320 (Fprocess_datagram_address): Mark as internal.
13321 * syntax.c (Fsyntax_table_p): New forward static decl.
13322 (skip_chars): Remove duplicate decl.
13323 * textprop.c (Fprevious_property_change): New forward static decl.
13324 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13325 Now internal.
13326 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13327 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13328
785bbd42
PE
13329 * editfns.c (Fformat): Remove unreachable code.
13330
8b913b57
AS
133312011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13332
13333 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13334 change. (Bug#8496)
13335
a6744a35
EZ
133362011-04-13 Eli Zaretskii <eliz@gnu.org>
13337
13338 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13339 when at ZV. (Bug#8487)
13340
e7974947
AS
133412011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13342
baad03f0
AS
13343 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13344 (Bug#8437)
13345 * keyboard.c (parse_tool_bar_item): Likewise.
13346 * sound.c (sound_cleanup, alsa_close): Likewise.
13347 * termcap.c (tgetent): Likewise.
13348 * xfns.c (x_default_font_parameter): Likewise.
13349 * xsettings.c (read_and_apply_settings): Likewise.
13350
e7974947
AS
13351 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13352 (overrun_check_free): Protoize.
13353
28272684
PE
133542011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13355
13356 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13357 since callers should never pass a negative size.
13358 Change the signature to match that of plain 'read' and 'write'; see
13359 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13360 * lisp.h: Update prototypes of emacs_write and emacs_read.
13361
11997c76
EZ
133622011-04-11 Eli Zaretskii <eliz@gnu.org>
13363
13364 * xdisp.c (redisplay_window): Don't try to determine the character
13365 position of the scroll margin if the window start point w->startp
e896f03c 13366 is outside the buffer's accessible region. (Bug#8468)
11997c76 13367
8a2cbd72
EZ
133682011-04-10 Eli Zaretskii <eliz@gnu.org>
13369
13370 Fix write-region and its subroutines for buffers > 2GB.
13371 * fileio.c (a_write, e_write): Modify declaration of arguments and
13372 local variables to support buffers larger than 2GB.
13373 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13374
13375 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13376 argument, local variables, and return value.
13377
13378 * lisp.h: Update prototypes of emacs_write and emacs_read.
13379
13380 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13381
4073e537 133822011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13383
1ebfdcb6
PE
13384 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13385
b2ded58d
PE
13386 Fix more problems found by GCC 4.6.0's static checks.
13387
7d66342c
PE
13388 * xdisp.c (vmessage): Use a better test for character truncation.
13389
bbf47d44
PE
13390 * charset.c (load_charset_map): <, not <=, for optimization,
13391 and to avoid potential problems with integer overflow.
9248994d 13392 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13393 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13394 * editfns.c (Fformat): Likewise.
1e69125e 13395 * syntax.c (skip_chars): Likewise.
3befa583 13396
e3019616
PE
13397 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13398 This also lets GCC 4.6.0 generate slightly better loop code.
13399
becfa255
PE
13400 * callint.c (Fcall_interactively): <, not <=, for optimization.
13401 (Fcall_interactively): Count the number of arguments produced,
13402 not the number of arguments given. This is simpler and lets GCC
13403 4.6.0 generate slightly better code.
13404
dae0cd48
PE
13405 * ftfont.c: Distingish more carefully between FcChar8 and char.
13406 The previous code passed unsigned char * to a functions like
13407 strlen and xstrcasecmp that expect char *, which does not
13408 conform to the C standard.
13409 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13410 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13411 char * when the C standard requires it.
13412
76032d70
PE
13413 * keyboard.c (read_char): Remove unused var.
13414
eb3f1cc8
PE
13415 * eval.c: Port to Windows vsnprintf (Bug#8435).
13416 Include <limits.h>.
13417 (SIZE_MAX): Define if the headers do not.
13418 (verror): Do not give up if vsnprintf returns a negative count.
13419 Instead, grow the buffer. This ports to Windows vsnprintf, which
13420 does not conform to C99. Problem reported by Eli Zaretskii.
13421 Also, simplify the allocation scheme, by avoiding the need for
13422 calling realloc, and removing the ALLOCATED variable.
13423
70476b54
PE
13424 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13425
12020a9e
PE
13426 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13427 But keep the doprint source code for now, as we might revamp it
13428 and use it again (Bug#8435).
ea6c7ae6
PE
13429 * lisp.h (doprnt): Remove.
13430 * Makefile.in (base_obj): Remove doprnt.o.
13431 * deps.mk (doprnt.o): Remove.
13432
5fdb398c
PE
13433 error: Print 32- and 64-bit integers portably (Bug#8435).
13434 Without this change, on typical 64-bit hosts error ("...%d...", N)
13435 was used to print both 32- and 64-bit integers N, which relied on
13436 undefined behavior.
61bdb816 13437 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13438 * lisp.h (error, verror): Mark as printf-like functions.
13439 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13440 Report overflow in size calculations when allocating printf buffer.
13441 Do not truncate output string at its first null byte.
13442 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13443 Truncate the output at a character boundary, since vsnprintf does not
13444 do that.
13445 * charset.c (check_iso_charset_parameter): Convert internal
13446 character to string before calling 'error', since %c now has the
13447 printf meaning.
13448 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13449 overflow when computing char to be passed to 'error'. Do not
13450 pass Lisp_Object to 'error'; pass the integer instead.
13451 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13452 formatted with plain %d.
13453
b189fa66
PE
13454 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13455
bff87ef0
PE
13456 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13457
7e2cac20
PE
13458 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13459
ce4d90b5
PE
13460 * xterm.c (x_catch_errors): Remove duplicate declaration.
13461
266c9547
PE
13462 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13463
79c49ad2
PE
13464 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13465
368f4090
JM
134662011-04-10 Jim Meyering <meyering@redhat.com>
13467
13468 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13469 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13470 return ssize_t not "int", and use size_t as the buffer length.
13471 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13472 * gnutls.h: Update declarations.
13473 * process.c (read_process_output): Use ssize_t, to match.
13474 (send_process): Likewise.
13475
a32d4040
CY
134762011-04-09 Chong Yidong <cyd@stupidchicken.com>
13477
13478 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13479
8546720e 134802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13481
04f2d78b
CB
13482 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13483 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13484
8546720e
GM
13485 * xterm.c (handle_one_xevent):
13486 * xmenu.c (create_and_show_popup_menu):
13487 * xselect.c (x_decline_selection_request)
13488 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13489
0a2f5c1a 134902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13491
13492 Fix some uses of `int' instead of EMACS_INT.
13493 * search.c (string_match_1, fast_string_match)
13494 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13495 (scan_buffer, find_next_newline_no_quit)
13496 (find_before_next_newline, search_command, Freplace_match)
13497 (Fmatch_data): Make some `int' variables be EMACS_INT.
13498
13499 * xdisp.c (display_count_lines): 3rd argument and return value now
13500 EMACS_INT. All callers changed.
13501 (pint2hrstr): Last argument is now EMACS_INT.
13502
13503 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13504 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13505 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13506 (decode_coding_utf_16, decode_coding_emacs_mule)
13507 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13508 (decode_coding_ccl, decode_coding_charset)
13509 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13510 (decode_coding_iso_2022, decode_coding_emacs_mule)
13511 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13512 <char_offset, last_offset>: Declare EMACS_INT.
13513 (encode_coding_utf_8, encode_coding_utf_16)
13514 (encode_coding_emacs_mule, encode_invocation_designation)
13515 (encode_designation_at_bol, encode_coding_iso_2022)
13516 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13517 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13518 Declare EMACS_INT.
13519 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13520 (encode_invocation_designation): Last argument P_NCHARS is now
13521 EMACS_INT.
13522 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13523 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13524
13525 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13526 All users changed.
13527
13528 * ccl.c (Fccl_execute_on_string): Declare some variables
13529 EMACS_INT.
13530
8546720e 135312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13532
13533 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13534
4e19a977
CS
135352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13536
13537 * process.c (Fformat_network_address): Doc fix.
13538
87302331
R
135392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13540
ee7683eb 13541 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13542
cbb59342
CY
135432011-04-08 Chong Yidong <cyd@stupidchicken.com>
13544
13545 * keyboard.c (read_char): Call Lisp function help-form-show,
13546 instead of using internal_with_output_to_temp_buffer.
13547 (Qhelp_form_show): New var.
e0d38eeb 13548 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13549
13550 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13551
13552 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13553
e67a13ab
CY
135542011-04-06 Chong Yidong <cyd@stupidchicken.com>
13555
04f2d78b
CB
13556 * process.c (Flist_processes): Remove to Lisp.
13557 (list_processes_1): Delete.
e67a13ab 13558
973f782d
EZ
135592011-04-06 Eli Zaretskii <eliz@gnu.org>
13560
7c106b1e
EZ
13561 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13562
973f782d
EZ
13563 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13564
41cf7d1a 135652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13566
ca23cc88
PE
13567 Fix more problems found by GCC 4.6.0's static checks.
13568
f390e2d5
PE
13569 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13570
42eea0d0
PE
13571 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13572
b69769da 13573 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13574
f9541e84
PE
13575 * xdisp.c (vmessage): Mark as a printf-like function.
13576
13841b55
PE
13577 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13578
c136c10f
PE
13579 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13580
5e2d4a30
PE
13581 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13582 printf-like functions.
13583 (tiff_load): Add casts to remove these marks before passing them
13584 to system-supplied API.
13585
583f48b9
PE
13586 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13587
b25d760e
PE
13588 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13589 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13590 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13591 directly, rather than having caller test rule sign. This avoids
13592 some unnecessary tests.
13593 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13594 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13595 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13596
bc7b6697 13597 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13598 (xfont_open): Avoid unnecessary tests.
bc7b6697 13599
27ccc379
PE
13600 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13601
dcd5c89a
PE
13602 * composite.h, composite.c (composition_gstring_put_cache):
13603 Use EMACS_INT, not int, for length.
13604
b13a45c6
PE
13605 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13606 breaking out part of COMPOSITION_DECODE_RULE.
13607 (COMPOSITION_DECODE_RULE): Use it.
13608 * composite.c (get_composition_id): Remove unused local vars,
13609 by using the new macro.
13610
1e792e4d
PE
13611 * textprop.c (set_text_properties_1): Change while to do-while,
13612 since the condition is always true at first.
13613
dc6c6455 13614 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13615 (interval_deletion_adjustment): Return unsigned value.
13616 All uses changed.
dc6c6455 13617
aba7731a
PE
13618 * process.c (list_processes_1, create_pty, read_process_output):
13619 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13620 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13621 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13622 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13623 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13624
fdfc4bf3
PE
13625 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13626
fca8fe46 13627 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13628 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13629
06a0259a 13630 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13631 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13632 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13633
e7b9e80f
PE
13634 * print.c (print_error_message): Avoid int overflow.
13635
56201685
PE
13636 * font.c (font_list_entities): Redo for clarity,
13637 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13638
78834453 13639 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13640 (font_score): Avoid potential overflow in diff calculation.
78834453 13641
0bc0b309 13642 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13643 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13644
e610eaca
PE
13645 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13646
b895abce
PE
13647 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13648 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13649 can always succeed if overflow has undefined behavior.
13650
1f1d9321 13651 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13652 (wordify): Omit three unnecessary tests.
1f1d9321 13653
c59478bc
PE
13654 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13655 All callers changed. This avoids the need for an unused var.
13656
79b73827
PE
13657 * casefiddle.c (casify_region): Remove var that is set but not used.
13658
a4db5dfe
PE
13659 * dired.c (file_name_completion): Remove var that is set but not used.
13660
43aae36e
PE
13661 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13662
2a47c44d 13663 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13664 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13665
a37c69bf
PE
13666 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13667 Check for integer overflow on size calculations.
13668
328ab8e7
PE
13669 * buffer.c (Fprevious_overlay_change): Remove var that is set
13670 but not used.
13671
e5a2a5cb
PE
13672 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13673 Remove vars that are set but not used.
8d84a6eb 13674 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13675 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13676
a60e5f68
PE
13677 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13678
f661cb61 13679 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13680 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13681
f0397f5a
PE
13682 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13683 that are set but not used.
13684
8664db06 13685 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13686 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13687
6abdaa4a
PE
13688 * xselect.c (x_get_local_selection, x_handle_property_notify):
13689 Remove vars that are set but not used.
13690
0ce7538d 13691 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13692 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13693
9ae848fc
PE
13694 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13695 Remove var that is set but not used.
0b918413
PE
13696 (scroll_bar_windows_size): Now size_t, not int.
13697 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13698 Check for overflow.
9ae848fc 13699
a5a62657
PE
13700 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13701 (map_tty_color) [!defined MSDOS]: Likewise.
13702
5c5cdd39
PE
13703 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13704
66ebf983
PE
13705 * coding.c: Remove vars that are set but not used.
13706 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13707 All callers changed.
13708 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13709 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13710 (decode_coding_charset): Remove vars that are set but not used.
13711
1be4d761
PE
13712 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13713 that is set but not used.
13714
47553fa8
PE
13715 * print.c (print_object): Remove var that is set but not used.
13716
1f7196bf 13717 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13718 The gnulib version avoids calling malloc in the usual case,
13719 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13720 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13721 * filelock.c (current_lock_owner): Likewise.
13722 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13723 * sysdep.c: Include allocator.h, careadlinkat.h.
13724 (emacs_no_realloc_allocator): New static constant.
13725 (emacs_readlink): New function.
fdb61804
PE
13726 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13727 ../lib/careadlinkat.h.
d1fdcab7 13728
f84c17c7
SM
137292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13730
13731 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13732 first non-nil return value).
13733
ef3862ad
JD
137342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13735
13736 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13737 if not defined (Bug#8403).
13738
376a7006
JB
137392011-04-02 Juanma Barranquero <lekktu@gmail.com>
13740
13741 * xdisp.c (display_count_lines): Remove parameter `start',
13742 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13743 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13744 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13745 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13746 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13747 and thereabouts. All callers changed.
13748 (get_per_char_metric): Remove parameter `f', unused since
13749 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13750
6ca3801d
JM
137512011-04-02 Jim Meyering <meyering@redhat.com>
13752
13753 do not dereference NULL upon failed strdup
13754 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13755 (ns_get_family): Likewise.
13756
d8e2b5ba
JB
137572011-04-02 Juanma Barranquero <lekktu@gmail.com>
13758
13759 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13760
8c74fcbd
JD
137612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13762
13763 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13764 later (Bug#8403).
13765
7200d79c
SM
137662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13767
03408648 13768 Add lexical binding.
7200d79c 13769
03408648
SM
13770 * window.c (Ftemp_output_buffer_show): New fun.
13771 (Fsave_window_excursion):
13772 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13773
13774 * lread.c (lisp_file_lexically_bound_p): New function.
13775 (Fload): Bind Qlexical_binding.
13776 (readevalloop): Remove `evalfun' arg.
13777 Bind Qinternal_interpreter_environment.
13778 (Feval_buffer): Bind Qlexical_binding.
13779 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13780 Mark as dynamic.
13781 (syms_of_lread): Declare `lexical-binding'.
13782
13783 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13784
13785 * keyboard.c (eval_dyn): New fun.
13786 (menu_item_eval_property): Use it.
ca105506
SM
13787
13788 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13789
03408648
SM
13790 * fns.c (concat, mapcar1): Accept byte-code-functions.
13791
13792 * eval.c (Fsetq): Handle lexical vars.
13793 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13794 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13795 (FletX, Flet): Obey lexical binding.
13796 (Fcommandp): Handle closures.
13797 (Feval): New `lexical' arg.
13798 (eval_sub): New function extracted from Feval. Use it almost
13799 everywhere where Feval was used. Look up vars in lexical env.
13800 Handle closures.
13801 (Ffunctionp): Move from subr.el.
13802 (Ffuncall): Handle closures.
13803 (apply_lambda): Remove `eval_flags'.
13804 (funcall_lambda): Handle closures and new byte-code-functions.
13805 (Fspecial_variable_p): New function.
13806 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13807 but without exporting it to Lisp.
23aba0ea 13808
23aba0ea 13809 * doc.c (Fdocumentation, store_function_docstring):
03408648 13810 * data.c (Finteractive_form): Handle closures.
23aba0ea 13811
03408648
SM
13812 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13813 interactive spec.
ba83908c 13814
04f2d78b
CB
13815 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13816 New byte-codes.
03408648
SM
13817 (exec_byte_code): New function extracted from Fbyte_code to handle new
13818 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13819
03408648 13820 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13821
03408648 13822 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13823
e2abce01
JB
138242011-03-31 Juanma Barranquero <lekktu@gmail.com>
13825
13826 * xdisp.c (redisplay_internal): Fix prototype.
13827
63696a73 138282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13829
63696a73 13830 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13831 (try_scrolling): Use it when setting scroll_limit.
13832 Limit scrolling to 100 screen lines.
63696a73
EZ
13833 (redisplay_window): Even when falling back on "recentering",
13834 position point in the window according to scroll-conservatively,
13835 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13836
13837 (try_scrolling): When point is above the window, allow searching
13838 as far as scroll_max, or one screenful, to compute vertical
13839 distance from PT to the scroll margin position. This prevents
13840 try_scrolling from unnecessarily failing when
13841 scroll-conservatively is set to a value slightly larger than the
13842 window height. Clean up the case of PT below the margin at bottom
13843 of window: scroll_max can no longer be INT_MAX. When aggressive
13844 scrolling is in use, don't let point enter the opposite scroll
13845 margin as result of the scroll.
13846 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13847 threshold of 100 lines for never-recentering scrolling.
13848
e4cc2dfc
JB
138492011-03-31 Juanma Barranquero <lekktu@gmail.com>
13850
13851 * dispextern.h (move_it_by_lines):
13852 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13853 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13854 (message_log_check_duplicate): Remove parameters `prev_bol' and
13855 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13856 (redisplay_internal): Remove parameter `preserve_echo_area',
13857 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13858
13859 * indent.c (Fvertical_motion):
13860 * window.c (window_scroll_pixel_based, Frecenter):
13861 Don't pass `need_y_p' to `move_it_by_lines'.
13862
1c470562
SM
138632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13864
44f230aa
SM
13865 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13866 steal a few bits to be more compact.
13867 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13868 Remove unneeded casts.
13869
1c470562
SM
13870 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13871
888adce9
ZK
138722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13873
13874 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13875 binding" message (bug#7967).
13876
f838ed7b
PE
138772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13878
77861b95
PE
13879 Fix more problems found by GCC 4.6.0's static checks.
13880
de6dbc14
PE
13881 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13882 Remove unused local var.
13883
f838ed7b
PE
13884 * editfns.c (Fmessage_box): Remove unused local var.
13885
792c7b2b
PE
13886 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13887 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13888 Omit unused local vars.
c499e557 13889 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13890 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13891 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13892 Omit unused local var.
13893
ba0165e1
PE
13894 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13895 Don't assume string length fits in int.
32ad8845 13896 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13897 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13898
3c59b4c9
PE
13899 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13900 instead of alloca (Bug#8344).
13901
a3eed478 13902 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13903 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13904
eb4d412d
PE
13905 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13906
1658b401
PE
13907 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13908 concerns.
13909
13910 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13911
13912 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13913
9a2c6e05
PE
13914 * keyboard.c (syms_of_keyboard): Use the same style as later
13915 in this function when indexing through an array. This also
13916 works around GCC bug 48267.
13917
03d0a109
PE
13918 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13919
44f730c8
PE
13920 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13921
fe75f926
PE
13922 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13923 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13924
ffa8c828
PE
13925 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13926 This avoids undefined behavior on integer overflow, and is a bit
13927 more convenient anyway since it is compared to a size_t variable.
13928
c5101a77
PE
13929 Variadic C functions now count arguments with size_t, not int.
13930 This avoids an unnecessary limitation on 64-bit machines, which
13931 caused (substring ...) to crash on large vectors (Bug#8344).
13932 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13933 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13934 All variadic functions and their callers changed accordingly.
c5101a77
PE
13935 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13936 * data.c (arith_driver, float_arith_driver): Likewise.
13937 * editfns.c (general_insert_function): Likewise.
13938 * eval.c (struct backtrace.nargs, interactive_p)
13939 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13940 (funcall_lambda, mark_backtrace): Likewise.
13941 * fns.c (concat): Likewise.
13942 * frame.c (x_set_frame_parameters): Likewise.
13943 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13944 0 if not found, not -1. All callers changed.
13945
dd3f25f7
PE
13946 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13947 (stack_copy_size): Now size_t, not int.
13948 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13949
461c2ab9
JB
139502011-03-28 Juanma Barranquero <lekktu@gmail.com>
13951
13952 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13953 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13954 All callers changed.
13955
13956 * lisp.h (multibyte_char_to_unibyte):
13957 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13958 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13959 * character.h (CHAR_TO_BYTE8):
13960 * cmds.c (internal_self_insert):
13961 * editfns.c (general_insert_function):
13962 * keymap.c (push_key_description):
13963 * search.c (Freplace_match):
13964 * xdisp.c (message_dolog, set_message_1): All callers changed.
13965
f6d62986
SM
139662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13967
13968 * keyboard.c (safe_run_hook_funcall): New function.
13969 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13970 don't set the hook to nil, but remove the offending function instead.
13971 (Qcommand_hook_internal): Remove, unused.
13972 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13973 Vcommand_hook_internal.
13974
13975 * eval.c (enum run_hooks_condition): Remove.
13976 (funcall_nil, funcall_not): New functions.
13977 (run_hook_with_args): Call each function through a `funcall' argument.
13978 Remove `cond' argument, now redundant.
13979 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13980 (Frun_hook_with_args_until_failure): Adjust accordingly.
13981 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13982
1db5b1ad
JB
139832011-03-28 Juanma Barranquero <lekktu@gmail.com>
13984
13985 * dispextern.h (string_buffer_position): Remove declaration.
13986
13987 * print.c (strout): Remove parameter `multibyte', unused since
13988 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13989
13990 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13991 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13992 All callers changed.
13993
13994 * w32.c (_wsa_errlist): Use braces for struct initializers.
13995
13996 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13997 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13998 All callers changed.
13999 (string_buffer_position): Likewise. Also, make static (it's never
14000 used outside xdisp.c).
14001 (cursor_row_p): Remove parameter `w', unused since
14002 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14003 (decode_mode_spec): Remove parameter `precision', introduced during
14004 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14005 All callers changed.
14006
5ffb62aa
JD
140072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14008
14009 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14010
461c2ab9 140112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14012
14013 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14014 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14015 (ns_update_auto_hide_menu_bar): New functions.
14016 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14017 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14018 ns_constrain_all_frames.
14019 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14020 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14021
5c380ffb
JD
140222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14023
14024 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14025
9af30bdf
GM
140262011-03-27 Glenn Morris <rgm@gnu.org>
14027
14028 * syssignal.h: Replace RETSIGTYPE with void.
14029 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14030 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14031 Replace SIGTYPE with void everywhere.
14032 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14033 * s/template.h (SIGTYPE): Remove commented out definition.
14034
e2abce01
JB
140352011-03-26 Eli Zaretskii <eliz@gnu.org>
14036
14037 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14038 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14039
f868cd8a
JB
140402011-03-26 Juanma Barranquero <lekktu@gmail.com>
14041
59eb0929
JB
14042 * w32.c (read_unc_volume): Use parameter `henum', instead of
14043 global variable `wget_enum_handle'.
14044
14045 * keymap.c (describe_vector): Remove parameters `indices' and
14046 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14047 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14048
f868cd8a
JB
14049 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14050
14051 * keyboard.c (timer_check): Remove parameter `do_it_now',
14052 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14053 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14054 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14055
14056 * keyboard.c (read_char):
14057 * w32menu.c (w32_menu_display_help):
14058 * xmenu.c (show_help_event, menu_help_callback):
14059 Adjust calls to `show_help_echo'.
14060
14061 * gtkutil.c (xg_maybe_add_timer):
14062 * keyboard.c (readable_events):
14063 * process.c (wait_reading_process_output):
14064 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14065
14066 * insdel.c (adjust_markers_gap_motion):
14067 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14068 (gap_left, gap_right): Don't call it.
14069
2ecf6fdb
CY
140702011-03-25 Chong Yidong <cyd@stupidchicken.com>
14071
14072 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14073 incurred during fontification.
14074
6b1f9ba4
JB
140752011-03-25 Juanma Barranquero <lekktu@gmail.com>
14076
14077 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14078 (DEFVAR_PER_BUFFER): Don't pass it.
14079
14080 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14081 (scrolling_window): Don't pass it.
14082
0f4a96b5
JB
140832011-03-25 Juanma Barranquero <lekktu@gmail.com>
14084
14085 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14086
14087 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14088 and `suffix'.
14089 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14090 of variables specific to SELinux and computation of `encoded_absname'.
14091
14092 * image.c (XPutPixel): Remove unused variable `height'.
14093
14094 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14095
14096 * unexw32.c (get_section_info): Remove unused variable `section'.
14097
14098 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14099 (system_process_attributes): Remove unused variable `sess'.
14100 (sys_read): Remove unused variable `err'.
14101
14102 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14103 (w32_wnd_proc): Remove unused variable `isdead'.
14104 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14105 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14106 (x_create_tip_frame): Remove unused variable `tem'.
14107
14108 * w32inevt.c (w32_console_read_socket):
14109 Remove unused variable `no_events'.
14110
14111 * w32term.c (x_draw_composite_glyph_string_foreground):
14112 Remove unused variable `width'.
14113
1149507c
JB
141142011-03-24 Juanma Barranquero <lekktu@gmail.com>
14115
14116 * w32term.c (x_set_glyph_string_clipping):
14117 Don't pass uninitialized region to CombineRgn.
14118
9c88f339
JB
141192011-03-23 Juanma Barranquero <lekktu@gmail.com>
14120
14121 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14122 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14123 (Fx_close_connection): Remove unused variable `i'.
14124
14125 * w32font.c (w32font_draw): Return number of glyphs.
14126 (w32font_open_internal): Remove unused variable `i'.
14127 (w32font_driver): Add missing initializer.
14128
14129 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14130 (fill_in_menu): Remove unused variable `items_added'.
14131
14132 * w32term.c (last_mouse_press_frame): Remove static global variable.
14133 (w32_clip_to_row): Remove unused variable `f'.
14134 (x_delete_terminal): Remove unused variable `i'.
14135
14136 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14137 (NOTHING): Remove unused static global variable.
14138 (uniscribe_check_otf): Remove unused variable `table'.
14139 (uniscribe_font_driver): Add missing initializers.
14140
dee091a3
JD
141412011-03-23 Julien Danjou <julien@danjou.info>
14142
14143 * term.c (Fsuspend_tty, Fresume_tty):
14144 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14145 * window.c (temp_output_buffer_show):
14146 * insdel.c (signal_before_change):
14147 * frame.c (Fhandle_switch_frame):
14148 * fileio.c (Fdo_auto_save):
14149 * emacs.c (Fkill_emacs):
14150 * editfns.c (save_excursion_restore):
14151 * cmds.c (internal_self_insert):
14152 * callint.c (Fcall_interactively):
14153 * buffer.c (Fkill_all_local_variables):
14154 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14155 Use Frun_hooks.
0f4a96b5 14156 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14157 unconditionally since it does the check itself.
dee091a3 14158
2c520ab5 141592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14160
c9c49752
PE
14161 Fix more problems found by GCC 4.5.2's static checks.
14162
8abc3f12
PE
14163 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14164 the first time through the loop, since we know p0 < p1 then.
14165 This also avoids a gcc -Wstrict-overflow warning.
14166
a2d26660
PE
14167 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14168 leading to a memory leak, possible in functions like
14169 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14170 of objects (Bug#8318).
a2d26660 14171
916c72e9
PE
14172 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14173 that could (at least in theory) be that large.
14174
19ab8a18
PE
14175 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14176 This is less likely to overflow, and avoids undefined behavior if
14177 overflow does occur. All callers changed. Use strtoul to scan
14178 for the unsigned long integer.
b7cbbd6f
PE
14179 (pint2hrstr): Simplify and tune code slightly.
14180 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14181
f0641eff
PE
14182 * scroll.c (do_scrolling): Work around GCC bug 48228.
14183 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14184
7f650bb9
PE
14185 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14186 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14187 (validate_x_resource_name): Simplify count usage.
14188 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14189
37dd57d1
PE
14190 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14191 fail (Bug#8306).
81e56e61 14192
699979fc 14193 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14194
401bf9b4
PE
14195 * process.c (Fmake_network_process): Use socklen_t, not int,
14196 where POSIX says socklen_t is required in portable programs.
14197 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14198 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14199 (Fmake_network_process, server_accept_connection):
14200 (wait_reading_process_output, read_process_output):
14201 Likewise.
14202
b93aacde
PE
14203 * process.c: Rename or move locals to avoid shadowing.
14204 (list_processes_1, Fmake_network_process):
14205 (read_process_output_error_handler, exec_sentinel_error_handler):
14206 Rename or move locals.
4dc343ee 14207 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14208 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14209 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14210 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14211 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14212
af8a867c 14213 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14214 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14215 Include tparam.h instead, since it declares them.
af8a867c
PE
14216 * cm.h (PC): Remove extern decl; tparam.h now does this.
14217 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14218 * terminfo.c: Include tparam.h, to check interfaces.
14219 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14220 (tparam): Adjust signature to match interface in tparam.h;
14221 this removes some undefined behavior. Check that outstring and len
14222 are zero, which they always are with Emacs.
14223 * tparam.h (PC, BC, UP): New extern decls.
14224
0248044d 14225 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14226 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14227
8ff096c1 14228 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14229 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14230 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14231 (ftfont_list): Remove unused local.
49eaafba
PE
14232 (get_adstyle_property, ftfont_pattern_entity):
14233 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14234 Rename locals to avoid shadowing.
8ff096c1 14235
e2be39f6
PE
14236 * xfont.c (xfont_list_family): Mark var as initialized.
14237
c9735e30
PE
14238 * xml.c (make_dom): Now static.
14239
8f5201ae
PE
14240 * composite.c (composition_compute_stop_pos): Rename local to
14241 avoid shadowing.
b246f932
PE
14242 (composition_reseat_it): Remove unused locals.
14243 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14244 (composition_update_it): Mark var as initialized.
11b61122
PE
14245 (find_automatic_composition): Mark vars as initialized,
14246 with a FIXME (Bug#8290).
8f5201ae 14247
760fbc2c
PE
14248 character.h: Rename locals to avoid shadowing.
14249 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14250 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14251 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14252 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14253 to avoid shadowing.
14254
ff08eb85
PE
14255 * textprop.c (property_change_between_p): Remove; unused.
14256
fc7bf025
PE
14257 * intervals.c (interval_start_pos): Now static.
14258
235d7abc
PE
14259 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14260
44f230aa
SM
14261 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14262 Rename locals to avoid shadowing.
3e7d6594 14263
50060332
PE
14264 * sound.c (wav_play, au_play, Fplay_sound_internal):
14265 Fix pointer signedness.
d01f234b 14266 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14267 (wav_play): Initialize a variable to 0, to prevent undefined
14268 behavior (Bug#8278).
50060332 14269
c4fc4e30
PE
14270 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14271
918436ed
PE
14272 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14273
c939f91b
PE
14274 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14275 clobbering (Bug#8298).
b9c7f648
PE
14276 * sysdep.c (sys_subshell): Likewise.
14277 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14278
6bd8c144
PE
14279 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14280 This should get cleaned up, so that child_setup has the
14281 same signature on all platforms.
14282
7710357c 14283 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14284 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14285
c59da222
CY
142862011-03-22 Chong Yidong <cyd@stupidchicken.com>
14287
14288 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14289 not to be necessary, and produces flickering.
14290
66b87493
GM
142912011-03-20 Glenn Morris <rgm@gnu.org>
14292
14293 * config.in: Remove file.
14294
45b6f6d5
JB
142952011-03-20 Juanma Barranquero <lekktu@gmail.com>
14296
14297 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14298 are now in src/globals.h.
14299 (syms_of_minibuf): Remove spurious & from previous change.
14300
cd394be1 143012011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14302
14303 * minibuf.c (completing-read-function): New variable.
14304 (completing-read-default): Rename from completing-read.
14305 (completing-read): Call completing-read-function.
14306
b14e3e21
CY
143072011-03-19 Juanma Barranquero <lekktu@gmail.com>
14308
14309 * xfaces.c (Fx_load_color_file):
14310 Read color file from absolute filename (bug#8250).
14311
f2b726e6
JB
143122011-03-19 Juanma Barranquero <lekktu@gmail.com>
14313
14314 * makefile.w32-in: Update dependencies.
14315
09f6ff02
EZ
143162011-03-17 Eli Zaretskii <eliz@gnu.org>
14317
14318 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14319
29a6015a
PE
143202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14321
a3a6c54e
PE
14322 Fix more problems found by GCC 4.5.2's static checks.
14323
b766f867
PE
14324 * process.c (make_serial_process_unwind, send_process_trap):
14325 (sigchld_handler): Now static.
14326
be02381c
PE
14327 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14328 That way, the code declares only the vars that it needs.
14329 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14330 * s/cygwin.h (PTY_ITERATION): Likewise.
14331 * s/darwin.h (PTY_ITERATION): Likewise.
14332 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14333
57048744
PE
14334 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14335 * process.c (allocate_pty): Don't declare stb unless it's needed.
14336
7914961c 14337 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14338 (CONSTANTLIM): Remove; unused.
14339 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14340 Define only if needed.
7914961c 14341
b3967b18
PE
14342 * unexelf.c (unexec): Name an expression,
14343 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14344 Use a different way to cause a compilation error if anyone uses
14345 n rather than nn, a way that does not involve shadowing.
73366a00 14346 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14347
29a6015a
PE
14348 * deps.mk (unexalpha.o): Remove; unused.
14349
43cfc33e 14350 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14351 * unexec.h: New file.
ce701a33
PE
14352 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14353 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14354 Depend on unexec.h.
14355 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14356 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14357 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14358 Change as necessary to match prototype in unexec.h.
ce701a33 14359
01f44d5a
PE
14360 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14361 shadowing.
4f63c6bb 14362 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14363
a6670b0b
PE
14364 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14365 Rename locals to avoid shadowing.
14366
cef2010d 14367 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14368 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14369
d4d7173a
PE
14370 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14371
f08b802a
PE
14372 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14373 warning when compiling print.c.
14374
3ddb0639
PE
14375 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14376 instead of using an uninitialized var.
5ad03b97 14377 (font_sort_entities): Mark var as initialized.
3ddb0639 14378
170a2692
PE
14379 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14380
e663c700
PE
14381 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14382 pointers to constants.
89bc529a 14383 (font_parse_fcname): Remove unused vars.
7b81e2d0 14384 (font_delete_unmatched): Now static.
ea838e10 14385 (font_get_spec): Remove; unused.
13a547c6
PE
14386 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14387 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14388 Rename or move locals to avoid shadowing.
e663c700 14389
2a80c887 14390 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14391 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14392
1384fa33 14393 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14394 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14395
8b2c52e9
PE
14396 * alloc.c (mark_backtrace): Move decl from here ...
14397 * lisp.h: ... to here, so that it can be checked.
14398
475545b5 14399 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14400 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14401 (lisp_indirect_variable): Name an expression,
14402 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14403 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14404
b1349114 14405 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14406 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14407 Use const pointer when appropriate.
b1349114 14408
a2928364
PE
14409 * lisp.h (get_system_name, get_operating_system_release):
14410 Move decls here, to check interfaces.
14411 * process.c (get_operating_system_release): Move decl to lisp.h.
14412 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14413 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14414 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14415 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14416 (Fformat_time_string, Fencode_time, Finsert_char):
14417 (Ftranslate_region_internal, Fformat):
14418 Rename or remove local vars to avoid shadowing.
9710023e 14419 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14420
a415e694
PE
14421 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14422 avoid shadowing.
14423
8ef4622d
PE
14424 * lisp.h (eassert): Check that the argument compiles, even if
14425 ENABLE_CHECKING is not defined.
14426
946f9a5b
PE
14427 * data.c (Findirect_variable): Name an expression, to avoid
14428 gcc -Wbad-function-cast warning.
112396d6 14429 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14430 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14431 (Fmake_variable_buffer_local, Fmake_local_variable):
14432 Mark variables as initialized.
52746918 14433 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14434
e5aab7e7 14435 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14436 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14437 Rename locals to avoid shadowing.
dff45157
PE
14438 (mark_stack): Move local variables into the #ifdef region where
14439 they're used.
7bc26fdb
PE
14440 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14441 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14442 needed otherwise.
14443 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14444 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14445 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14446
e5aab7e7
PE
14447 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14448 avoids undefined behavior in theory.
14449
4da60324
PE
14450 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14451
88043301
PE
14452 Use functions, not macros, for up- and down-casing (Bug#8254).
14453 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14454 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14455 to use the following functions instead of these macros.
14456 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14457 EMACS_INT, since callers assume the returned value fits in int.
14458 (upcase1): Likewise, for UPCASE_TABLE.
14459 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14460 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14461 the race-condition problem in the old DOWNCASE.
88043301 14462
19ed5445
PE
14463 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14464 Rename locals to avoid shadowing.
14465 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14466 (regex_compile, re_search_2, re_match_2_internal):
14467 Remove unused local vars.
952db0d7
PE
14468 (FREE_VAR): Rewrite so as not to use empty "else",
14469 which gcc can warn about.
da053e48 14470 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14471 (RETALLOC_IF): Define only if needed.
14472 (WORDCHAR_P): Likewise. This one is never needed, but is used
14473 only in a comment talking about a compiler bug, so put inside
14474 the #if 0 of that comment.
14475 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14476 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14477 Remove; unused.
19ed5445 14478
1f3561e4 14479 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14480 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14481 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14482
ded6f8f7
PE
14483 * search.c (simple_search): Remove unused var.
14484
dbd37a95
PE
14485 * dired.c (compile_pattern): Move decl from here ...
14486 * lisp.h: ... to here, so that it can be checked.
14487 (struct re_registers): New forward decl.
14488
7e47afad
PE
14489 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14490
85f24f61
PE
14491 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14492 All uses changed.
14493 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14494 Rename locals to avoid shadowing.
5671df8f 14495 (Fvertical_motion): Mark locals as initialized.
85f24f61 14496
181aa2be 14497 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14498 (casify_region): Mark local as initialized.
181aa2be 14499
930d429c
PE
14500 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14501
7082eac6
PE
14502 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14503 New macros, so that the caller can use some names other than
14504 gcpro1, gcpro2, etc.
14505 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14506 of the new macros.
14507 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14508 argument, for consistency with GCPRO2_VAR, etc: it is now the
14509 prefix of the variable, not the variable itself. All uses
14510 changed.
38b2c076
PE
14511 * dired.c (directory_files_internal, file_name_completion):
14512 Rename locals to avoid shadowing.
14513
15206ed9
PE
14514 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14515 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14516 dired.c's scmp function, had undefined behavior.
14517 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14518 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14519 * buffer.h: ... to here, because these macros use current_buffer,
14520 and the new implementation with inline functions needs to have
14521 current_buffer in scope now, rather than later when the macros
14522 are used.
14523 (downcase, upcase1): New static inline functions.
14524 (DOWNCASE, UPCASE1): Reimplement using these functions.
14525 This avoids undefined behavior in expressions like
14526 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14527 from race conditions in accessing the global variables
14528 case_temp1 and case_temp2.
14529 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14530 * lisp.h (case_temp1, case_temp2): Remove their decls.
14531 * character.h (ASCII_CHAR_P): Move from here ...
14532 * lisp.h: ... to here, so that the inline functions mentioned
14533 above can use them.
14534
4a6bea26
PE
14535 * dired.c (directory_files_internal_unwind): Now static.
14536
f14b7e14
PE
14537 * fileio.c (file_name_as_directory, directory_file_name):
14538 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14539 Now static.
2893f146
PE
14540 (file_name_as_directory): Use const pointers when appropriate.
14541 (Fexpand_file_name): Likewise. In particular, newdir might
14542 point at constant storage, so make it a const pointer.
fd4ead52 14543 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14544 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14545 signedness issues.
f839df0c
PE
14546 (Fset_file_times, Finsert_file_contents, auto_save_error):
14547 Rename locals to avoid shadowing.
f14b7e14 14548
5716756e 14549 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14550 (Ftry_completion, Fall_completions): Rename or remove locals
14551 to avoid shadowing.
5716756e 14552
b4c3046a
PE
14553 * marker.c (bytepos_to_charpos): Remove; unused.
14554
b45db522
PE
14555 * lisp.h (verify_bytepos, count_markers): New decls,
14556 so that gcc does not warn that these functions aren't declared.
14557
85876d07
PE
14558 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14559 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14560 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14561 (copy_text): Remove unused local var.
85876d07 14562
03d78a21 14563 * filelock.c (within_one_second): Now static.
b3dd38ab 14564 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14565
5df8f01b
PE
14566 * buffer.c (fix_overlays_before): Mark locals as initialized.
14567 (fix_start_end_in_overlays): Likewise. This function should be
14568 simplified by using pointers-to-pointers, but that's a different
14569 matter.
b1d876f1 14570 (switch_to_buffer_1): Now static.
8f54f30a
PE
14571 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14572 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14573
a70072c9 14574 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14575 Fix pointer signedness issue.
edced198
PE
14576 (sys_subshell): Mark local as volatile if checking for lint,
14577 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14578 (MAXPATHLEN): Define only if needed.
a70072c9 14579
a0977c44
PE
14580 * process.c (serial_open, serial_configure): Move decls from here ...
14581 * systty.h: ... to here, so that they can be checked.
14582
a884fdcc
PE
14583 * fns.c (get_random, seed_random): Move extern decls from here ...
14584 * lisp.h: ... to here, so that they can be checked.
14585
604efe86 14586 * sysdep.c (reset_io): Now static.
b8950c94 14587 (wait_for_termination_signal): Remove; unused.
604efe86 14588
38fc62d9
PE
14589 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14590 (copy_keymap_item, append_key, push_text_char_description):
14591 Now static.
1004a21a 14592 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14593 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14594 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14595 (describe_map_tree):
14596 Rename locals to avoid shadowing.
38fc62d9 14597
2f2650da
PE
14598 * keyboard.c: Declare functions static if they are not used elsewhere.
14599 (echo_char, echo_dash, cmd_error, top_level_2):
14600 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14601 (read_char, kbd_buffer_get_event, make_lispy_position):
14602 (make_lispy_event, make_lispy_movement, apply_modifiers):
14603 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14604 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14605 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14606 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14607 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14608
a053e86c 14609 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14610 (mark_kboards): Move decl here ...
14611 * alloc.c (mark_kboards): ... from here.
a053e86c 14612
4752793e
PE
14613 * lisp.h (force_auto_save_soon): New decl.
14614
74f10ca7 14615 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14616 (DEFINE_DUMMY_FUNCTION): New macro.
14617 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14618 Use it.
c03cd23f
PE
14619 (main): Add casts to avoid warnings
14620 if GCC considers string literals to be constants.
74f10ca7 14621
022e70d4
PE
14622 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14623
59d6fe83
PE
14624 * dbusbind.c: Pointer signedness fixes.
14625 (xd_signature, xd_append_arg, xd_initialize):
14626 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14627 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14628 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14629 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14630
78320123
PE
14631 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14632 if GCC considers string literals to be constants.
49cebcca 14633 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14634
35ac2a97
SM
146352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14636
fb103ca9
SM
14637 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14638 (print_preprocess, print_object): New macro to fix last change.
14639
35ac2a97
SM
14640 * print.c (print_preprocess): Don't forget font objects.
14641
62973b41
JB
146422011-03-16 Juanma Barranquero <lekktu@gmail.com>
14643
14644 * emacs.c (USAGE3): Doc fixes.
14645
0e48bb22
AS
146462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14647
14648 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14649 structure.
14650
7684e57b
JB
146512011-03-14 Juanma Barranquero <lekktu@gmail.com>
14652
14653 * lisp.h (VWindow_system, Qfile_name_history):
14654 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14655 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14656 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14657
14658 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14659 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14660
14661 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14662 * w32console.c (detect_input_pending, read_input_pending)
14663 (encode_terminal_code):
14664 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14665 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14666 (w32_system_caret_y, Qfile_name_history):
14667 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14668 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14669 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14670 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14671 * w32proc.c (Qlocal, report_file_error):
14672 * w32term.c (Vwindow_system, updating_frame):
14673 * w32uniscribe.c (initialized, uniscribe_font_driver):
14674 Remove unneeded extern declarations.
14675
2aa46d6c
CY
146762011-03-14 Chong Yidong <cyd@stupidchicken.com>
14677
c96bbc66 14678 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14679
cffc6f3b
CY
146802011-03-13 Chong Yidong <cyd@stupidchicken.com>
14681
14682 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14683 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14684 These macros can no longer be used for assignment.
14685
44f230aa
SM
14686 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14687 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14688 (record_buffer_markers, fetch_buffer_markers): New functions for
14689 recording and fetching special buffer markers.
14690 (set_buffer_internal_1, set_buffer_temp): Use them.
14691
14692 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14693
14694 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14695
14696 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14697 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14698
14699 * xdisp.c (hscroll_window_tree):
14700 (reconsider_clip_changes): Use PT instead of BUF_PT.
14701
d251f04b
EZ
147022011-03-13 Eli Zaretskii <eliz@gnu.org>
14703
14704 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14705 $(EMACS_ROOT)/lib/intprops.h.
14706
f0c77cd1
PE
147072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14708
3eca4629
PE
14709 Fix more problems found by GCC 4.5.2's static checks.
14710
7c86ee98
PE
14711 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14712 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14713 (xg_free_frame_widgets): Make it clear that a local variable is
14714 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14715 (gdk_window_get_screen): Make it clear that this macro is needed
14716 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14717 (int_gtk_range_get_value): New function, which avoids a diagnostic
14718 from gcc -Wbad-function-cast.
14719 (xg_set_toolkit_scroll_bar_thumb): Use it.
14720 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14721 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14722 (get_utf8_string, xg_get_file_with_chooser):
14723 Rename locals to avoid shadowing.
14724 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14725
41729b81
PE
14726 * xgselect.c (xg_select): Remove unused var.
14727
f0c77cd1
PE
14728 * image.c (four_corners_best): Mark locals as initialized.
14729 (gif_load): Initialize transparent_p to zero (Bug#8238).
14730 Mark another local as initialized.
ec6cf4c6 14731 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14732
ce0ad53d 14733 * image.c (clear_image_cache): Now static.
d5d5a617 14734 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14735 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14736 (x_edge_detection): Remove unnecessary cast that
14737 gcc -Wbad-function-cast diagnoses.
2037898d 14738 (gif_load): Fix pointer signedness.
6ae141d6
PE
14739 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14740 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14741
33383987 147422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14743
d32df629
PE
14744 Improve quality of tests for time stamp overflow.
14745 For example, without this patch (encode-time 0 0 0 1 1
14746 1152921504606846976) returns the obviously-bogus value (-948597
14747 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14748 reports time overflow. See
14749 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14750 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14751 * editfns.c: Include limits.h and intprops.h.
14752 (TIME_T_MIN, TIME_T_MAX): New macros.
14753 (time_overflow): Move earlier, to before first use.
14754 (hi_time, lo_time): New functions, for an accurate test for
14755 out-of-range times.
14756 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14757 (Fget_internal_run_time): Don't assume time_t fits in int.
14758 (make_time): Use list2 instead of Fcons twice.
14759 (Fdecode_time): More accurate test for out-of-range times.
14760 (check_tm_member): New function.
14761 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14762 (lisp_time_argument): Don't rely on undefined left-shift and
14763 right-shift behavior when checking for time stamp overflow.
8be6f318 14764
fe31d94c
PE
14765 * editfns.c (time_overflow): New function, refactoring common code.
14766 (Fformat_time_string, Fdecode_time, Fencode_time):
14767 (Fcurrent_time_string): Use it.
14768
8be6f318
PE
14769 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14770 * dired.c (make_time): Move to ...
14771 * editfns.c (make_time): ... here.
14772 * systime.h: Note the move.
14773
09d9db2c 147742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14775
126bc0dc
YM
14776 * fringe.c (update_window_fringes): Remove unused variables.
14777
c47cbdfd
YM
14778 * unexmacosx.c (copy_data_segment): Also copy __got section.
14779 (Bug#8223)
14780
7ac80be9
EZ
147812011-03-12 Eli Zaretskii <eliz@gnu.org>
14782
c96bbc66 14783 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14784 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14785 Constify `char *' arguments and their references according to
14786 prototypes in tparam.h.
14787
ecb0f94d 14788 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14789
7ac80be9
EZ
14790 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14791 Adapt all references accordingly.
14792
14793 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14794
ef1fd07e
TT
147952011-03-11 Tom Tromey <tromey@redhat.com>
14796
14797 * buffer.c (syms_of_buffer): Remove obsolete comment.
14798
7ef4b50c
EZ
147992011-03-11 Eli Zaretskii <eliz@gnu.org>
14800
14801 * termhooks.h (encode_terminal_code): Declare prototype.
14802
14803 * msdos.c (encode_terminal_code): Don't declare prototype.
14804
14805 * term.c (encode_terminal_code): Now external again, used by
14806 w32console.c and msdos.c.
14807
44f230aa
SM
14808 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14809 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14810
4b1ec863 148112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14812
1714f52b 14813 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14814
4b1ec863
PE
14815 * fringe.c (update_window_fringes): Mark locals as initialized
14816 (Bug#8227).
14817 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14818
524c7aa6
PE
14819 * alloc.c (mark_fringe_data): Move decl from here ...
14820 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14821 to check its interface.
14822 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14823
a5c0af81 14824 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14825 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14826 (fontset_font): Mark local as initialized.
a9a06e0b 14827 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14828
b4716021
PE
14829 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14830
811e9bac 14831 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14832 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14833 (x_own_selection, Fx_disown_selection_internal): Rename locals
14834 to avoid shadowing.
14835 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14836
7e3ab302
PE
14837 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14838 so that the caller can use some name other than gcpro1.
14839 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14840 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14841 (Fx_backspace_delete_keys_p):
14842 Use them to avoid shadowing, and rename vars to avoid shadowing.
14843 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14844 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14845 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14846 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14847 Remove unused locals.
7e3ab302
PE
14848 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14849 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14850 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14851 macros.
f78faa98 14852
e2b13473
PE
14853 * xterm.h (x_mouse_leave): New decl.
14854
77f23912
PE
14855 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14856 Remove unused functions.
cdf4ba58
PE
14857 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14858 (x_calc_absolute_position): Now static.
7411c686 14859 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14860 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14861 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14862 unless they are used.
38d0b34a
PE
14863 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14864 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14865 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14866 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14867 (x_error_catcher, x_connection_closed, x_error_handler):
14868 (x_error_quitter, xembed_send_message, x_iconify_frame):
14869 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14870 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14871 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14872
44f230aa
SM
14873 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14874 Rename or move locals to avoid shadowing.
6b463e58 14875 (tty_defined_color, merge_face_heights): Now static.
5967d051 14876 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14877 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14878 does not deduce is never used uninitialized.
73719eba
PE
14879 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14880 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14881
426994c3 14882 * terminal.c (store_terminal_param): Now static.
5489860b 14883
032f1620 14884 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14885 (set_frame_menubar): Remove unused local.
d4323972 14886 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14887 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14888 since they might point to immutable storage.
281585b0
PE
14889 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14890 since it's unused otherwise.
032f1620 14891
367c19e5 14892 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14893 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14894 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14895 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14896 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14897 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14898 does not deduce are never used uninitialized.
70739cbe 14899
07b48fa9
PE
14900 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14901
8868a238 14902 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14903 * window.c (window_loop, size_window):
14904 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14905
7e5cf297 14906 * window.c (display_buffer): Now static.
d6550a9f
PE
14907 (size_window): Mark variables that gcc -Wuninitialized
14908 does not deduce are never used uninitialized.
a586633d
PE
14909 * window.h (check_all_windows): New decl, to forestall
14910 gcc -Wmissing-prototypes diagnostic.
5b555da1 14911 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14912
f6095868
PE
14913 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14914 shadowing.
14915 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14916 Include <limits.h>.
14917 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14918 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14919 (load_charset_map): Mark variables that gcc -Wuninitialized
14920 does not deduce are never used uninitialized.
53df7c11 14921 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14922
f38b440c
PE
14923 * coding.c (coding_set_source, coding_set_destination):
14924 Use "else { /* comment */ }" rather than "else /* comment */;"
14925 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14926 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14927 a block, when the outer 'i' will do.
14928 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14929 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14930 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14931 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14932 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14933 Rename locals to avoid shadowing.
14934 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14935 * coding.c (emacs_mule_char, encode_invocation_designation):
14936 Now static, since they're not used elsewhere.
413bb2db 14937 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14938 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14939 (decode_coding_emacs_mule): Mark variables that gcc
14940 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14941 (detect_coding_iso_2022): Initialize a local variable that might
14942 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14943 this initialization is needed. (Bug#8211)
5f58e762
PE
14944 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14945 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14946 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14947 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14948 Remove unused macros.
f38b440c 14949
232b38b9 14950 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14951 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14952 * character.c (string_count_byte8): Likewise.
232b38b9 14953
fb90da1b
PE
14954 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14955 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14956
fb93dbc2
PE
14957 * chartab.c (copy_sub_char_table): Now static, since it's not used
14958 elsewhere.
5c156ace
PE
14959 (sub_char_table_ref_and_range, char_table_ref_and_range):
14960 Rename locals to avoid shadowing.
bbcd0949 14961 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14962
7d3b3862 14963 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14964 (BIDI_BOB): Remove unused macro.
7d3b3862 14965
6be7d3da
PE
14966 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14967 deduce are never used uninitialized.
c2ed9c8b 14968 * term.c (encode_terminal_code): Likewise.
6be7d3da 14969
75f8807f 14970 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14971
50938595
PE
14972 * tparam.h: New file.
14973 * term.c, tparam.h: Include it.
14974 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14975 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14976 Move these decls to tparam.h, and make them agree with what
14977 is actually in tparam.c. The previous trick of using incompatible
14978 decls in different modules does not conform to the C standard.
14979 All callers of tparam changed to use tparam's actual API.
14980 * tparam.c (tparam1, tparam, tgoto):
14981 Use const pointers where appropriate.
14982
fbceeba2
PE
14983 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14984 * cm.h (struct cm): Likewise.
14985 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14986 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14987 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14988 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14989 (turn_on_face, init_tty): Likewise.
14990 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14991
7f3f1250
PE
14992 * term.c (term_mouse_position): Rename local to avoid shadowing.
14993
e6ca6543
PE
14994 * alloc.c (mark_ttys): Move decl from here ...
14995 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14996
c40f8d15
AS
149972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14998
14999 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15000
cfe0661d
JB
150012011-03-09 Juanma Barranquero <lekktu@gmail.com>
15002
15003 * search.c (compile_pattern_1): Remove argument regp, unused since
15004 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15005 (compile_pattern): Don't pass it.
15006
0afb4571
J
150072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15008
15009 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15010 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15011 for ! HAVE_GTK3.
15012 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15013
15014 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15015
15016 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15017 gdk_window_get_screen, gdk_window_get_geometry,
15018 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15019 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15020 (xg_get_pixbuf_from_pixmap): New function.
15021 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15022 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15023 Call xg_get_pixbuf_from_pixmap instead of
15024 gdk_pixbuf_get_from_drawable.
15025 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15026 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15027 (xg_check_special_colors): Use GtkStyleContext and its functions
15028 for HAVE_GTK3.
15029 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15030 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15031 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15032 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15033 Call gtk_widget_get_preferred_size.
0afb4571
J
15034 (xg_frame_resized): gdk_window_get_geometry only takes 5
15035 parameters.
44f230aa
SM
15036 (xg_win_to_widget, xg_event_is_for_menubar):
15037 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15038 (xg_set_widget_bg): New function.
15039 (delete_cb): New function.
895009e1 15040 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15041 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15042 (xg_set_background_color): Call xg_set_widget_bg.
15043 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15044 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15045 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15046 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15047 if ! HAVE_GTK3.
15048 (update_frame_tool_bar): Call gtk_widget_hide.
15049 (xg_initialize): Use GDK_KEY_g.
15050
15051 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15052 if ! HAVE_GTK3
15053 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15054
15055 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15056 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15057 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15058
1c2cc4ef
JB
150592011-03-08 Juanma Barranquero <lekktu@gmail.com>
15060
15061 * w32xfns.c (select_palette): Check success of RealizePalette against
15062 GDI_ERROR, not zero.
15063
33383987 15064See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15065
15066;; Local Variables:
15067;; coding: utf-8
aac0c6e3
MR
15068;; End:
15069
2f097256 15070 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15071
15072 This file is part of GNU Emacs.
15073
15074 GNU Emacs is free software: you can redistribute it and/or modify
15075 it under the terms of the GNU General Public License as published by
15076 the Free Software Foundation, either version 3 of the License, or
15077 (at your option) any later version.
15078
15079 GNU Emacs is distributed in the hope that it will be useful,
15080 but WITHOUT ANY WARRANTY; without even the implied warranty of
15081 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15082 GNU General Public License for more details.
15083
15084 You should have received a copy of the GNU General Public License
15085 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.