Update programs.texi and cc-mode.texi for new CC Mode features:
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c803b2b7
JD
12011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2
5fecd5fc
JD
3 * nsterm.m (ns_term_init): Subscribe for notifications
4 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5 to method trackingNotification in EmacsMenu.
6
7 * nsmenu.m (trackingMenu): New variable.
8 (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5 and
9 NS_IMPL_COCOA.
3771cb17 10 (trackingNotification): New method (from Aquamacs).
5fecd5fc 11 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 12 from Aquamacs (Bug#7030).
5fecd5fc
JD
13 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
14
c803b2b7
JD
15 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
16 (symbol_to_nsstring): Fix indentation.
17 (ns_symbol_to_pb): New function.
18 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
19 (Fns_rotate_cut_buffers_internal): Removed.
20 (Fns_store_selection_internal): Renamed from
21 Fns_store_cut_buffer_internal.
22 (ns_get_foreign_selection, Fx_own_selection_internal)
23 (Fx_disown_selection_internal, Fx_selection_exists_p)
24 (Fns_get_selection_internal, Fns_store_selection_internal): Use
25 ns_symbol_to_pb and check if return value is nil.
26 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
27 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
28 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
29 renamed to Sns_store_selection_internal.
30 (ns_handle_selection_request): Move code to Fx_own_selection_internal
31 and remove this function.
32 (ns_handle_selection_clear): Remove, never used.
33 (Fx_own_selection_internal): Move code from ns_handle_selection_request
34 here.
35
e1b01a3a
KB
362011-12-17 Ken Brown <kbrown@cornell.edu>
37
38 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
39 GID is unknown (Bug#10257).
40
2adb6e85
PE
412011-12-17 Paul Eggert <eggert@cs.ucla.edu>
42
43 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
44 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
45 which caused a build failure on GNU/Linux IA-64. This problem was
46 introduced by my 2011-10-07 patch.
47
d1d7b339
JL
482011-12-15 Juri Linkov <juri@jurta.org>
49
50 * image.c (imagemagick_error): New function. (Bug#10112)
51 (imagemagick_load_image): Comment out `MagickSetResolution' call.
52 Use `imagemagick_error' where ImageMagick functions return
53 `MagickFalse'.
54 (Fimagemagick_types): Add `Fnreverse' to return the list in the
55 proper order.
56
100d5755
KH
572011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
58
59 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
60 fill background (Bug#8992).
61
454592a6
MR
622011-12-13 Martin Rudalics <rudalics@gmx.at>
63
64 * window.c (Vwindow_combination_resize)
65 (Vwindow_combination_limit): Use t instead of non-nil in
66 doc-strings.
61d4b438
MR
67 (Vrecenter_redisplay): Add first sentence of doc-string on
68 separate line.
53524d93 69 (Frecenter): Fix doc-string typo.
454592a6 70
3633e3aa
KH
712011-12-11 Kenichi Handa <handa@m17n.org>
72
73 * coding.c (Funencodable_char_position): Pay attention to the
74 buffer text relocation (Bug#9389).
75
7b9d523a
JD
762011-12-10 Jan Djärv <jan.h.d@swipnet.se>
77
78 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
79 gtk_init (Bug#10100).
80
b73189c6
EZ
812011-12-10 Eli Zaretskii <eliz@gnu.org>
82
83 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
84 IT->string is nil. (Bug#10263)
85
f7dfe5d6
JD
862011-12-10 Jan Djärv <jan.h.d@swipnet.se>
87
83faebb4
JD
88 * nsterm.h (x_free_frame_resources): Declare.
89
f7dfe5d6
JD
90 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
91 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
92
93 * nsterm.h (ns_get_defaults_value): Declare.
94
95 * nsterm.m (ns_default): Call ns_get_defaults_value.
96
7cd4e72c
EZ
972011-12-09 Eli Zaretskii <eliz@gnu.org>
98
99 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
100 (Bug#10170)
101
b34d7317
YM
1022011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
103
104 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
105 that where the value of an _OBJC_* symbol points to is in the .bss
106 section (Bug#10240).
107
76470ad1
KH
1082011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
109
110 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 111 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 112
745fff94
KH
1132011-12-08 Kenichi Handa <handa@m17n.org>
114
115 * ftfont.c (get_adstyle_property): Fix previous change
116 (Bug#10233).
117
6e44397c
JB
1182011-12-07 Juanma Barranquero <lekktu@gmail.com>
119
120 * w32.c (init_environment): If no_site_lisp, remove site-lisp
121 dirs from the default value of EMACSLOADPATH (bug#10208).
122
7efa6272
GM
1232011-12-07 Glenn Morris <rgm@gnu.org>
124
125 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
126 installation and source directories as well. (Bug#10208)
127
f6fc4d87
CY
1282011-12-06 Chong Yidong <cyd@gnu.org>
129
130 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
131
2bf26180
GM
1322011-12-06 Glenn Morris <rgm@gnu.org>
133
134 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
135 as an error, not just -1. (Bug#10217)
136
3a6ad4f0
CY
1372011-12-05 Chong Yidong <cyd@gnu.org>
138
139 * keyboard.c (process_special_events): New function.
140 (swallow_events, Finput_pending_p): Use it (Bug#10195).
141
75a3b399
PE
1422011-12-05 Paul Eggert <eggert@cs.ucla.edu>
143
144 * coding.c (encode_designation_at_bol): Don't use uninitialized
145 local variable (Bug#9318).
146
c3c9e25e
KH
1472011-12-05 Kenichi Handa <handa@m17n.org>
148
149 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
150 return Qnil (Bug#8046, Bug#10193).
151
5eb05ea3
KH
1522011-12-05 Kenichi Handa <handa@m17n.org>
153
154 * coding.c (encode_designation_at_bol): New args charbuf_end and
155 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
156 (coding_set_source): Return how many bytes coding->source was
157 relocated.
158 (coding_set_destination): Return how many bytes
159 coding->destination was relocated.
160 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
161 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
162
1632011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
164
165 * coding.c (CODING_CHAR_CHARSET_P): New macro.
166 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
167 macro (Bug#9318).
168
1692011-12-05 Andreas Schwab <schwab@linux-m68k.org>
170
171 The following changes are to fix Bug#9318.
172
a79703f5 173 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
174 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
175 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 176 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 177
7dbda6df
JB
1782011-12-05 Juanma Barranquero <lekktu@gmail.com>
179
180 * lisp.h (process_quit_flag): Fix external declaration.
181
6d5eb5b0
SM
1822011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
183
184 Don't macro-inline non-performance-critical code.
185 * eval.c (process_quit_flag): New function.
186 * lisp.h (QUIT): Use it.
187
a0c3fad0
JD
1882011-12-04 Jan Djärv <jan.h.d@swipnet.se>
189
190 * nsfns.m (get_geometry_from_preferences): New function.
191 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
192
6c07aac2
AS
1932011-12-04 Andreas Schwab <schwab@linux-m68k.org>
194
195 * emacs.c (Qkill_emacs): Define.
196 (syms_of_emacs): Initialize it.
197 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
198 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
199 (quit_throw_to_read_char): Add parameter `from_signal'.
200 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
201 * lisp.h (QUIT): Call Fkill_emacs if requested.
202
c052ead4
JD
2032011-12-03 Jan Djärv <jan.h.d@swipnet.se>
204
205 * widget.c (update_wm_hints): Return if wmshell is null.
206 (widget_update_wm_size_hints): New function.
207
208 * widget.h (widget_update_wm_size_hints): Declare.
209
210 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
211 widget_update_wm_size_hints (Bug#10104).
212
9e49252b
EZ
2132011-12-03 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (handle_invisible_prop): If the invisible text ends just
216 before a newline, prepare the bidi iterator for consuming the
217 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 218 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 219
02b16839
JL
2202011-12-02 Juri Linkov <juri@jurta.org>
221
222 * search.c (Fword_search_regexp): New Lisp function created from
223 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
224 (Fword_search_backward, Fword_search_forward)
225 (Fword_search_backward_lax, Fword_search_forward_lax):
226 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
227 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
228
0068070e
SM
2292011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
230
231 * fileio.c (Finsert_file_contents): Move after-change-function call
232 to before the "handled:" label, since all "goto handled" appear in
233 cases where the *-change-functions have already been properly called
234 (bug#10117).
235
3360a3fc
AS
2362011-12-01 Andreas Schwab <schwab@linux-m68k.org>
237
238 * keyboard.c (interrupt_signal): Don't call kill-emacs when
239 waiting for input. (Bug#10169)
240
73d6c093
EZ
2412011-11-30 Eli Zaretskii <eliz@gnu.org>
242
243 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
244 verifies glyph row's hash code--we have just reallocated the
245 glyphs, so their contents can be complete garbage. (Bug#10164)
246
febe6bea
JB
2472011-11-30 Juanma Barranquero <lekktu@gmail.com>
248
249 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
250
801a4313
EZ
2512011-11-30 Eli Zaretskii <eliz@gnu.org>
252
253 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
254 attributes are tested _before_ calling verify_row_hash, to protect
255 against GCC re-ordering of the tests. (Bug#10164)
256
2b56b87e
JD
2572011-11-29 Jan Djärv <jan.h.d@swipnet.se>
258
259 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
260
261 * xterm.c (handle_one_xevent): Only set async_visible and friends
262 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 263 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
264 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
265
dbf31225
PE
2662011-11-28 Paul Eggert <eggert@cs.ucla.edu>
267
268 Remove GCPRO-related macros that exist only to avoid shadowing locals.
269 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
270 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
271 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
272 All uses changed to use GCPRO1 etc.
273 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
274 Revert to old implementation (i.e., before 2011-03-11).
275
1305621b
YM
2762011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
277
278 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
279 of scroll runs so as to avoid assigning disabled bogus rows and
280 unnecessary graphics copy operations.
281
8c9afb46
EZ
2822011-11-27 Eli Zaretskii <eliz@gnu.org>
283
284 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
285 (snprintf) [_MSC_VER]: Redirect to _snprintf.
286 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
287 (malloc, free, realloc, calloc): Redirect to e_* only when
288 compiling Emacs.
289
290 * lisp.h (GCTYPEBITS): Move before first use.
291 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
292 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
293 this macro definition.
294
295 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
296 _MSC_VER.
297
54e9e3bf
JD
2982011-11-27 Jan Djärv <jan.h.d@swipnet.se>
299
6d5eb5b0
SM
300 * gtkutil.c (xg_create_frame_widgets):
301 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
302 present with Gtk+ 2.0.
303
83aca1cb
PE
3042011-11-26 Paul Eggert <eggert@cs.ucla.edu>
305
306 * fileio.c (Finsert_file_contents): Undo previous change; see
307 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
308
5b76caa4
PE
3092011-11-26 Paul Eggert <eggert@cs.ucla.edu>
310
311 Rename locals to avoid shadowing.
312 * fileio.c (Finsert_file_contents):
313 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
314 * process.c (wait_reading_process_output):
315 Rename inner 'proc' to 'p' to avoid shadowing.
316 Indent for consistency with usual Emacs style.
317
8c535114
EZ
3182011-11-25 Eli Zaretskii <eliz@gnu.org>
319
320 * xdisp.c (redisplay_window): If cursor row is not fully visible
321 after recentering, and scroll-conservatively is set to a large
322 number, scroll window by a few more lines to make the cursor fully
323 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
324 (start_display): Don't move to the next line if the display should
325 start at a newline that is part of a display vector or an overlay
326 string. (Bug#10119)
8c535114 327
fa4fdb5c
JL
3282011-11-24 Juri Linkov <juri@jurta.org>
329
330 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
331 after the `MagickPingImage' call. (Bug#10112)
332
90ec88df
CY
3332011-11-23 Chong Yidong <cyd@gnu.org>
334
335 * window.c (Fcoordinates_in_window_p): Accept only live windows.
336
56e2e794
MR
3372011-11-23 Martin Rudalics <rudalics@gmx.at>
338
339 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
340 making another buffer current. (Bug#10114)
341
b6e64c41
GM
3422011-11-23 Glenn Morris <rgm@gnu.org>
343
344 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
345
6b21de18
CY
3462011-11-23 Chong Yidong <cyd@gnu.org>
347
348 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
349 using it (Bug#5984).
350
b12cd789
EZ
3512011-11-22 Eli Zaretskii <eliz@gnu.org>
352
353 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
354 and header-lines, as they don't have one computed for them.
355 (Bug#10098)
356
357 * .gdbinit (prow): Make displayed values more self-explaining.
358 Add row's hash code.
359
261b6fd4
LMI
3602011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
361
362 * process.c (wait_reading_process_output): Fix asynchrounous
363 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 364 (wait_reading_process_output): Add comment and URL.
261b6fd4 365
e7cfd277
JD
3662011-11-21 Jan Djärv <jan.h.d@swipnet.se>
367
368 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
369
a9b9b7f5
CY
3702011-11-21 Chong Yidong <cyd@gnu.org>
371
372 * window.c (Fnext_window, Fprevious_window): Doc fix.
373
b0d15b4f
SM
3742011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
375
376 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
377
fe7a3057
JB
3782011-11-20 Juanma Barranquero <lekktu@gmail.com>
379
380 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
381
d2999b1a
MR
3822011-11-20 Martin Rudalics <rudalics@gmx.at>
383
384 * window.c (Fset_window_combination_limit): Rename argument
385 STATUS to LIMIT.
386 (Vwindow_combination_limit): Remove "status" from doc-string.
387
d5ff9cd0
AS
3882011-11-20 Andreas Schwab <schwab@linux-m68k.org>
389
390 * m/ibms390.h: Remove.
391 * m/ibms390x.h: Don't include "ibms390.h".
392
a5bb9bd3
SM
3932011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
394
395 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
396 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
397
cd1181db
JB
3982011-11-20 Juanma Barranquero <lekktu@gmail.com>
399
400 * casetab.c (Fset_case_table):
401 * charset.c (Fcharset_after): Fix typos.
402
615a3b8d 4032011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 404
17e845af
PE
405 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
406 Otherwise, valgrind does not work on some platforms.
407 Problem reported by Andreas Schwab in
6a0bf43d
PE
408 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
409 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
410 is set, removing the need for VIRT_ADDRESS_VARIES.
411 (PURE_P): Use a more-efficient implementation that needs just one
412 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
413 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
414 to 4 (xorl, subq, cmpq, setbe).
415 * alloc.c (pure): Always extern now, since that's the
416 VIRT_ADDR_VARIES behavior.
417 (PURE_POINTER_P): Use a single comparison, not two, for
418 consistency with the new puresize.h.
419 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
420 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
421 Remove VIRT_ADDR_VARIES no longer needed.
422
f8fe6f96
EZ
4232011-11-19 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
426 (erase_phys_cursor, update_window_cursor, show_mouse_face)
427 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
428 behave as if the cursor position were at the window margin.
429
430 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
431 and the cursor position is out of bounds, behave as if the cursor
432 position were at the window margin. (Bug#10075)
433
df05a53c
CY
4342011-11-18 Chong Yidong <cyd@gnu.org>
435
436 * window.c (Fwindow_combination_limit): Make first argument
437 non-optional, since it is meaningless for live windows like the
438 selected window.
439
2071918e
DA
4402011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
441
442 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
443
b50a28de
SM
4442011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
445
446 * intervals.c: Fix grafting over the whole buffer (bug#10071).
447 (graft_intervals_into_buffer): Simplify.
448
015137db
EZ
4492011-11-18 Eli Zaretskii <eliz@gnu.org>
450
451 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
452 hash values of the two rows.
453 (copy_row_except_pointers): Preserve the used[] arrays and the
454 hash values of the two rows. (Bug#10035)
68c95424 455 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
456
457 * xdisp.c (row_hash): New function, body extracted from
458 compute_line_metrics.
459 (compute_line_metrics): Call row_hash, instead of computing the
460 hash code inline.
461
462 * dispnew.c (verify_row_hash): Call row_hash for computing the
463 hash code of a row, instead of duplicating code from xdisp.c.
464
465 * dispextern.h (row_hash): Add prototype.
466
a2addb04
TH
4672011-11-18 Tassilo Horn <tassilo@member.fsf.org>
468
469 * frame.c (delete_frame): Don't delete the terminal when the last
470 X frame is closed if emacs is built with GTK toolkit.
471
df85d315
JB
4722011-11-17 Juanma Barranquero <lekktu@gmail.com>
473
474 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
475
a0c2d0ae
MR
4762011-11-17 Martin Rudalics <rudalics@gmx.at>
477
478 * window.c (Vwindow_splits): Rename to
479 Vwindow_combination_resize. Suggested by Juri Linkov.
480 (Fsplit_window_internal): Use Vwindow_combination_resize instead
481 of Vwindow_splits.
482
58179cce
JB
4832011-11-16 Juanma Barranquero <lekktu@gmail.com>
484
7877f373
JB
485 * nsfns.m (Fns_font_name):
486 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 487
b6f67890
MR
4882011-11-16 Martin Rudalics <rudalics@gmx.at>
489
490 * window.h (window): Rename slot "nest" to "combination_limit".
491 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
492 (Fset_window_nest): Rename to Fset_window_combination_limit.
493 (Vwindow_nest): Rename to Vwindow_combination_limit.
494 (recombine_windows, make_parent_window, make_window)
495 (Fsplit_window_internal, saved_window)
496 (Fset_window_configuration, save_window_save): Rename all
497 occurrences of window_nest to window_combination_limit.
498
c7015153
JB
4992011-11-15 Juanma Barranquero <lekktu@gmail.com>
500
501 * image.c (imagemagick_load_image): Fix typo.
502
322ad6ec
EZ
5032011-11-14 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (display_line): Move the call to
506 highlight_trailing_whitespace before the call to
507 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
508 faces of all the glyphs to compute ROW's hash value.
509 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 510
f067b8ec
JB
5112011-11-14 Juanma Barranquero <lekktu@gmail.com>
512
513 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
514 just return (bug#10044).
515
1e5b2111
EZ
5162011-11-12 Eli Zaretskii <eliz@gnu.org>
517
7ef3cbd5
EZ
518 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
519 with user-defined heap size. Bump the default size of the temacs
520 heap to 27MB, to avoid memory warning when running temacs.
521 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
522
1e5b2111
EZ
523 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
524 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
525 (verify_row_hash) [XASSERTS]: New function.
526 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
527 that the hash value of glyph rows is correct.
1e5b2111 528
89d61221
MR
5292011-11-12 Martin Rudalics <rudalics@gmx.at>
530
531 * window.h (window): Remove splits slot.
532 * window.c (Fwindow_splits, Fset_window_splits): Remove.
533 (Fdelete_other_windows_internal, make_parent_window)
534 (make_window, Fsplit_window_internal, Fdelete_window_internal)
535 (Fset_window_configuration, save_window_save): Don't deal with
536 split status of windows.
537 (saved_window): Remove splits slot.
538 (Vwindow_splits): Rewrite doc-string.
539
97f18cc8
JD
5402011-11-11 Jan Djärv <jan.h.d@swipnet.se>
541
542 * xfns.c (unwind_create_frame):
543 * nsfns.m (unwind_create_frame):
544 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
545 Vframe_list (Bug#9999).
546
22a648b4
DA
5472011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
548
0b381c7e 549 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 550
659afede
KH
5512011-11-11 Kenichi Handa <handa@m17n.org>
552
553 * callproc.c (Fcall_process): Set the member dst_multibyte of
554 process_coding.
555
9ac0394b
KH
5562011-11-11 Johan Bockgård <bojohan@gnu.org>
557
558 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
559 avoid a crash (bug#9496).
560
2fbdc249
CY
5612011-11-09 Chong Yidong <cyd@gnu.org>
562
563 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
564 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
565
ac6b1f81
PE
5662011-11-08 Paul Eggert <eggert@cs.ucla.edu>
567
568 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
569
09db192c
PE
5702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
571
572 Avoid some portability problems by eschewing 'extern inline' functions.
573 The trivial performance wins aren't worth the portability hassles; see
574 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
575 et seq.
576 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
577 (window_box_width, window_box_left, window_box_left_offset)
578 (window_box_right, window_box_right_offset): Undo previous change,
579 by removing the "extern"s.
580 * intervals.c (adjust_intervals_for_insertion)
581 (adjust_intervals_for_deletion): Undo previous change,
582 making these static again.
583 (offset_intervals, temp_set_point_both, temp_set_point)
584 (copy_intervals_to_string): No longer inline.
585 * xdisp.c (window_text_bottom_y, window_box_width)
586 (window_box_height, window_box_left_offset)
587 (window_box_right_offset, window_box_left, window_box_right)
588 (window_box): No longer inline.
589
105216ed
CY
5902011-11-08 Chong Yidong <cyd@gnu.org>
591
592 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
593 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
594 Signal an error if not a live window.
105216ed
CY
595 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
596 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
597
ae9e237f
JB
5982011-11-07 Juanma Barranquero <lekktu@gmail.com>
599
600 * lisp.h (syms_of_abbrev): Remove declaration.
601 Reported by CHENG Gao <chenggao@royau.me>.
602
c7aa8333
EZ
6032011-11-07 Eli Zaretskii <eliz@gnu.org>
604
605 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
606 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
607 of temacs in GUI mode.
608
be7f5545
MR
6092011-11-07 Martin Rudalics <rudalics@gmx.at>
610
611 * window.h: Declare delete_all_child_windows instead of
612 delete_all_subwindows.
613 * window.c (Fwindow_nest, Fset_window_nest)
614 (Fset_window_new_total, Fset_window_new_normal)
615 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
616 (delete_all_subwindows): Rename to delete_all_child_windows.
617 (Fdelete_other_windows_internal, Fset_window_configuration):
618 Call delete_all_child_windows instead of delete_all_subwindows.
619 * frame.c (delete_frame): Call delete_all_child_windows instead
620 of delete_all_subwindows.
621
ca78dc43
PE
6222011-11-07 Paul Eggert <eggert@cs.ucla.edu>
623
624 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
625 This is also needed for porting to any host where GC_MARK_STACK is
626 not GC_MAKE_GCPROS_NOOPS.
627 (which_symbols): Use it.
628
a0241d01
KH
6292011-11-07 Kenichi Handa <handa@m17n.org>
630
631 * coding.c (coding_set_destination): Check coding->src_pos only
632 when coding->src_object is a buffer (bug#9910).
633
634 * process.c (send_process): Set the member src_multibyte of coding
635 to 0 (bug#9911) when sending a unibyte text.
636
637 * callproc.c (Fcall_process): Set the member src_multibyte of
638 process_coding to 0 (bug#9912).
639
a64bfdfa 6402011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
641
642 * xmenu.c (cleanup_widget_value_tree): New function.
643 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
644 calling free_menubar_widget_value_tree directly (Bug#9830).
645
cb41b32a
PE
6462011-11-06 Paul Eggert <eggert@cs.ucla.edu>
647
648 Fix some portability problems with 'inline'.
649 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
650 (window_box_width, window_box_left, window_box_left_offset)
651 (window_box_right, window_box_right_offset): Declare extern.
652 Otherwise, these inline functions do not conform to C99 and
653 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
654 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
655 * intervals.c (adjust_intervals_for_insertion)
656 (adjust_intervals_for_deletion): Now extern, because otherwise the
657 extern inline functions 'offset_intervals' couldn't refer to it.
658 (static_offset_intervals): Remove.
659 (offset_intervals): Rewrite using the old contents of
660 static_offset_intervals. The old version didn't conform to C99
661 because an extern inline function contained a reference to an
662 identifier with static linkage.
663
b7041366
AS
6642011-11-06 Andreas Schwab <schwab@linux-m68k.org>
665
666 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
667 GC.
668
88a37c4d
EZ
6692011-11-06 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (init_iterator, reseat_to_string): Don't set the
672 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
673 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
674 return Qleft_to_right.
675
49745b39
CY
6762011-11-06 Chong Yidong <cyd@gnu.org>
677
678 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
679 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
680 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
681 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
682 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
683 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
684 (Fwindow_vscroll): Doc fix.
685 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
686 argument, since it makes no sense to pass a live window and for
687 consistency with window-child.
688
1f05cd82
CS
6892011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
690
691 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
692 support MSVC.
693
22610910
JR
6942011-11-05 Jason Rumney <jasonr@gnu.org>
695
696 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
697 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
698 fonts (Bug#6029).
699 (add_font_entity_to_list): Fix logic errors in mixed boolean and
700 bitwise arithmetic preventing use of unicode-sip and non-truetype
701 opentype fonts.
702
a06776b2
EZ
7032011-11-05 Eli Zaretskii <eliz@gnu.org>
704
3ad924ba
EZ
705 * s/ms-w32.h (fstat, stat, utime): Move redirections to
706 "emacs"-only part.
707
a06776b2
EZ
708 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
709 initialization code to keep similarity to xfns.c after changes
710 from 2011-11-05.
711
c9e7db78
JD
7122011-11-05 Jan Djärv <jan.h.d@swipnet.se>
713
a97f8f3f
JD
714 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
715 (unwind_create_frame): New function (Bug#9943).
716 (Fx_create_frame): Restructure code to be more similar to the one in
717 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
718 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
719 Move terminal->reference_count++ just before making the frame official
720 (Bug#9943).
721
722 * nsterm.m (x_free_frame_resources): New function.
723 (x_destroy_window): Move code to x_free_frame_resources.
724
c9e7db78 725 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
726 (Fx_create_frame, x_create_tip_frame):
727 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
728 official. Move initialization of image_cache_refcount and
729 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
730
a6fc3b5c
EZ
7312011-11-05 Eli Zaretskii <eliz@gnu.org>
732
733 Support MSVC build with newer versions of Visual Studio.
734 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
735 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
736 nt/gmake.defs.
737
738 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
739 which are not supported by MSVC.
740 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
741 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
742 bitfields.
743 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
744 types in bitfields.
745 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
746
747 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
748
58179cce 7492011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
750
751 Support MSVC build with newer versions of Visual Studio.
752 * w32.c: Don't include w32api.h for MSVC.
753 (init_environment) [_MSC_VER]: Call sys_access, not _access.
754
755 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
756 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
757 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
758 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
759 e_* cousins.
760 (alloca) [_MSC_VER]: Define to _alloca.
761
762 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
763
764 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
765
a58c13ed
EZ
7662011-11-04 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (note_mouse_highlight): If either of
769 previous/next-single-property-change returns nil, treat that as
770 the beginning or the end of the buffer. (Bug#9955)
771
fe0b6370
JD
7722011-11-04 Jan Djärv <jan.h.d@swipnet.se>
773
a58c13ed 774 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
775 label is not null (Bug#9951).
776 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
777 may be NULL.
778
89bd5ee1
EZ
7792011-11-04 Eli Zaretskii <eliz@gnu.org>
780
781 * window.c (Fwindow_body_size): Mention in the doc string that the
782 return value is in frame's canonical units. (Bug#9949)
783
84c3edb9
EZ
7842011-11-03 Eli Zaretskii <eliz@gnu.org>
785
4e2fb5c7
EZ
786 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
787
84c3edb9 788 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 789 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 790 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 791
bc17a887
EZ
7922011-11-01 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
795 Don't stop backward scan on the continuation glyph, even though
796 its CHARPOS is positive.
6d5eb5b0
SM
797 (mouse_face_from_buffer_pos, note_mouse_highlight):
798 Rename cover_string to disp_string.
bc17a887 799
4ee88440
MR
8002011-11-01 Martin Rudalics <rudalics@gmx.at>
801
802 * window.c (temp_output_buffer_show): Don't use
803 Vtemp_buffer_show_specifiers.
804 (Vtemp_buffer_show_specifiers): Remove unused variable.
805
c2ff3c02
EZ
8062011-10-30 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
809 past the beginning of the current glyph matrix.
810
58179cce 8112011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
812
813 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
814 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
815 HAVE_GTK3 (Bug#9869).
b77a6a7f 816
3b574623
JD
817 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
818 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
819
b77a6a7f
JD
820 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
821
822 * xterm.c: Declare x_handle_net_wm_state to return int.
823 (handle_one_xevent): Check if we are iconified but don't have
824 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
825 (get_current_wm_state): Return non-zero if not hidden,
826 check for _NET_WM_STATE_HIDDEN (Bug#9893).
827 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
828 (x_handle_net_wm_state): Return what get_current_wm_state returns.
829 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
830
196e41e4
PE
8312011-10-29 Paul Eggert <eggert@cs.ucla.edu>
832
833 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
834 so that this new function doesn't get optimized away by a
835 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
836
021f2e1a
AS
8372011-10-29 Andreas Schwab <schwab@linux-m68k.org>
838
839 * frame.h (MOUSE_HL_INFO): Remove excess parens.
840
8b058d44
EZ
8412011-10-29 Eli Zaretskii <eliz@gnu.org>
842
843 Fix the `xbytecode' command.
844 * .gdbinit (xprintbytestr): New command.
b50a28de 845 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
846 (xbytecode): Print the byte-code string as well.
847
4452fb80
EZ
8482011-10-29 Kim Storm <storm@cua.dk>
849
8b058d44
EZ
850 * alloc.c (which_symbols): New function.
851
21b72067
AS
8522011-10-29 Andreas Schwab <schwab@linux-m68k.org>
853
854 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
855 line. (Bug#9903)
856
83ed7b5c
GM
8572011-10-29 Glenn Morris <rgm@gnu.org>
858
859 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
860 Not clear what it was for, and it causes various bugs. (Bug#9839)
861
5a7a728b
EZ
8622011-10-28 Eli Zaretskii <eliz@gnu.org>
863
864 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
865 possible random value that matches one of those tested as
866 condition to clear the mouse face.
867
d3d0842f
CY
8682011-10-28 Chong Yidong <cyd@gnu.org>
869
870 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
871
31b39d13
DN
8722011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
873
874 * window.c (make_window): Initialize phys_cursor_on_p.
875
9aba6043
SM
8762011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
877
878 * lisp.h (struct Lisp_Symbol): Update comments.
879
c20992f4
JB
8802011-10-28 Juanma Barranquero <lekktu@gmail.com>
881
882 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
883
db4f02f2
EZ
8842011-10-28 Eli Zaretskii <eliz@gnu.org>
885
886 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
887 <oslsachem@gmail.com> for helping to debug this.
888
889 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
890 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
891 (g_b_init_get_glyph_outline_w): New static variables.
892 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
893 (GetGlyphOutlineW_Proc): New typedefs.
894 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
895 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
896 New functions.
897 (w32font_open_internal, compute_metrics):
898 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
899 instead of calling the "wide" APIs directly.
900
901 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
902
903 * w32.h (syms_of_w32font): Add prototype.
904
87e68db4
JB
9052011-10-27 Juanma Barranquero <lekktu@gmail.com>
906
907 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
908 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
909 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
910 (Fmove_to_window_line): Doc fix.
911
435c1d67
CY
9122011-10-27 Chong Yidong <cyd@gnu.org>
913
914 * process.c (make_process): Set gnutls_state to NULL.
915
916 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
917 non-NULL, regardless of GNUTLS_INITSTAGE.
918 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
919 an error. Set process slots as soon as we allocate them.
920
921 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
922
9c6c6f49
CY
9232011-10-27 Chong Yidong <cyd@gnu.org>
924
9aba6043
SM
925 * gnutls.c (emacs_gnutls_deinit): New function.
926 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
927 (Fgnutls_deinit, Fgnutls_boot): Use it.
928
929 * process.c (make_process): Initialize GnuTLS credentials to NULL.
930 (deactivate_process): Call emacs_gnutls_deinit.
931
657d08d3
JB
9322011-10-27 Juanma Barranquero <lekktu@gmail.com>
933
934 * image.c (x_create_x_image_and_pixmap):
935 * w32.c (sys_rename, w32_delayed_load):
936 * w32font.c (fill_in_logfont):
937 * w32reg.c (x_get_string_resource): Silence compiler warnings.
938
5430d399
JB
9392011-10-26 Juanma Barranquero <lekktu@gmail.com>
940
941 * w32fns.c (w32_default_color_map): New function,
942 extracted from Fw32_default_color_map.
a7ef684b 943 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 944
fe0055fa
PE
9452011-10-25 Paul Eggert <eggert@cs.ucla.edu>
946
947 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
948
e6346438
SM
9492011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
950
951 * keyboard.c (test_undefined): New function (bug#9751).
952 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
953
e112cc37
ET
9542011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
955
956 * sysdep.c (init_sys_modes): Fix the check for the controlling
957 terminal (Bug#6649).
958
7b5d6677
EZ
9592011-10-20 Eli Zaretskii <eliz@gnu.org>
960
961 * dispextern.h (struct bidi_it): New member next_en_type.
962
963 * bidi.c (bidi_line_init): Initialize the next_en_type member.
964 (bidi_resolve_explicit_1): When next_en_pos is valid for the
965 current character, check also for next_en_type being WEAK_EN.
966 (bidi_resolve_weak): Don't enter the expensive loop if the current
967 position is before next_en_pos. Record the bidi type of the first
968 non-ET, non-BN character we find, in addition to its position.
969 (bidi_level_of_next_char): Invalidate next_en_type when
970 next_en_pos is over-stepped.
971
7da0b018
PE
9722011-10-20 Paul Eggert <eggert@cs.ucla.edu>
973
974 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
975 * editfns.c: Rewrite current-time-zone so that it invokes
976 the equivalent of (format-time-string "%Z") to get the time zone name.
977 This fixes a bug when the time zone name contains characters that
978 need converting from the system time locale to Emacs internal format.
979 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
980 that patch fixed format-time-string to do the conversion, but
981 I forgot to fix current-time-zone.
982 (format_time_string): New function, containing most of
983 what Fformat_time_string used to contain.
984 (Fformat_time_string): Rewrite in terms of format_time_string.
985 This doesn't change this function's behavior.
986 (current-time-zone): Rewrite to use format_time_string.
987 This fixes the bug reported by Michael Schierl in
988 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
989 Jason Rumney's 2007-06-07 change worked around this bug, but
990 didn't fix it.
991 * systime.h (tzname, timezone): Remove no-longer-used declarations.
992
8547b010
EZ
9932011-10-19 Eli Zaretskii <eliz@gnu.org>
994
995 * xdisp.c (start_display): If the character at POS is displayed
996 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
997 (try_window_reusing_current_matrix): If a line ends in a display
998 vector or the next line starts in a display vector, continue
999 redrawing the window even though the character position of
1000 start_row was reached.
8547b010
EZ
1001 (Bug#9771, part 2)
1002
4e948d15
CY
10032011-10-18 Chong Yidong <cyd@gnu.org>
1004
1005 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1006 with nobreak-char-display too.
1007
4787455f
EZ
10082011-10-18 Eli Zaretskii <eliz@gnu.org>
1009
1010 Fix part 3 of bug#9771.
1011 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1012 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1013 non-neutral characters if the current character is a paragraph
1014 separator (a.k.a. Newline). This avoids running the same
1015 expensive loop twice, once when we consume the preceding newline
1016 and the other time when the line actually needs to be displayed.
1017 Avoid the loop when we see neutrals on the base embedding level
1018 following a character whose directionality is the same as the
1019 paragraph's. This avoids running the expensive loop when a line
1020 ends in a long sequence of neutrals, like control characters.
1021 Add assertion against STRONG_AL type. Slightly rearrange code
1022 that determines the type of a neutral given the first non-neutral
1023 that follows it.
1024 (bidi_level_of_next_char): Set next_en_pos to zero when
1025 invalidating its info.
1026
2c91f553
EZ
10272011-10-17 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (push_display_prop): Determine whether to record string
1030 or buffer position by IT->string, not by IT->method. Allow
1031 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1032 (move_it_vertically_backward): Don't look for character position
1033 immediately after the newline when in a continuation line.
1034 (Bug#9771, part 1)
2c91f553 1035
c7b08b0d
MR
10362011-10-15 Martin Rudalics <rudalics@gmx.at>
1037
1038 * window.c (coordinates_in_window): Rewrite and delabelize
1039 vertical border check. (Bug#5357) (Bug#9618)
1040
6b02f655
SM
10412011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1042
1043 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1044 errors in XSetWindowBorder (bug#9310).
1045
81d40c92
DA
10462011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1049 avoid crash when xmalloc overrun checking is enabled.
1050
d4172c3b
EZ
10512011-10-13 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1054 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1055 cursor motion with <left> and <right> arrow keys.
1056
1057 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1058 some callers set that themselves.
1059
b00eea75
EZ
10602011-10-12 Eli Zaretskii <eliz@gnu.org>
1061
1062 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1063 display string and the previous row comes from the same string and
1064 is empty. (Bug#9739) (Bug#9738)
1065
8fe012c4
SM
10662011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * doc.c (get_doc_string): Encode file name (bug#9735).
1069
0074aef2
EZ
10702011-10-12 Eli Zaretskii <eliz@gnu.org>
1071
79beb178
EZ
1072 * bidi.c (bidi_level_of_next_char):
1073 * xdisp.c (get_visually_first_element): Remove old incorrect
1074 comments regarding the Unicode Line Separator character.
1075
0074aef2
EZ
1076 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1077
6e4b3fbe
DA
10782011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1079
1080 * alloc.c (Fgc_status): Do not access beyond zombies array
1081 boundary if nzombies > MAX_ZOMBIES.
1082 * alloc.c (dump_zombies): Add missing format specifier.
1083
0324f3af
PE
10842011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1085
b5525cac
PE
1086 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1087 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1088
0324f3af
PE
1089 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1090 Some packages use them to denote characters with modifiers.
1091
e9b5f888
AS
10922011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1093
1094 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1095 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1096 matching a pp-number. Rename parameter var to var1.
1097
127827c0
SM
10982011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1101
c8fd3bd0
GM
11022011-10-08 Glenn Morris <rgm@gnu.org>
1103
1104 * callint.c (Fcall_interactively): Give a more explicit error for the
1105 'c' case with a non-character input. (Bug#8479)
1106
352ec8ff
EZ
11072011-10-08 Eli Zaretskii <eliz@gnu.org>
1108
03669ccb
EZ
1109 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1110 lines.
7061c986
EZ
1111 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1112 lines that are hscrolled on the left.
03669ccb 1113
352ec8ff
EZ
1114 * dispnew.c (buffer_posn_from_coords): Account for a possible
1115 presence of header-line. (Bug#4426)
1116
a66cfb1c
SM
11172011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1118
6b02f655
SM
1119 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1120 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1121
7c5ee88e
PE
11222011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1125 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1126 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1127 this makes Emacs dump core during garbage collection on rare
1128 occasions. sizeof is obviously inferior to offsetof here, so
1129 stick with offsetof.
1130 (GC_POINTER_ALIGNMENT): New macro.
1131 (mark_memory): Omit 3rd (offset) arg; caller changed.
1132 Don't assume EMACS_INT alignment is the same as pointer alignment.
1133
df1bbe5b
SM
11342011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * keyboard.c (read_key_sequence_remapped): New var.
1137 (read_key_sequence): Compute remapping in the right buffer.
1138 (command_loop_1): Use read_key_sequence's remapping directly.
1139
51553db6
SM
11402011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1141
32c1fffd
SM
1142 * dired.c (file_name_completion): Don't expand file name.
1143 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1144 before checking file name handler.
1145
51553db6
SM
1146 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1147 they've been requested explicitly (bug#9591).
1148
b6bd1599 11492011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1150
1151 * keymap.c (Fsingle_key_description): Use make_specified_string
1152 instead of build_string to build string from push_key_description.
1153 (Bug#5193)
1154
f701dc2a
PE
11552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1156
4222c55d
PE
1157 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1158 This fixes a Y2038 bug on 64-bit hosts.
1159 * buffer.c (reset_buffer):
1160 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1161 (Fclear_buffer_auto_save_failure):
1162 Use 0, not -1, to represent an unset failure time, since time_t
1163 might not be signed.
1164
f701dc2a
PE
1165 Remove dependency on glibc malloc internals.
1166 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1167 Move back here from lisp.h, but with their new implementations.
1168 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1169 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1170 * charset.c (charset_table_init): New static var.
1171 (syms_of_charset): Use it instead of xmalloc. This removes a
1172 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1173 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1174 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1175 Move back to alloc.c.
1176 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1177 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1178
9ceebf39
JD
11792011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsterm.m (windowDidResize): Call x_set_window_size only when
1182 ns_in_resize is true. Otherwise set pixelwidth/height and
1183 call change_frame_size (Bug#9628).
1184
cb993c58
PE
11852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1186
3930c88b
PE
1187 Port --enable-checking=all to Fedora 14 x86-64.
1188 * charset.c (syms_of_charset): Also account for glibc malloc's
1189 internal overhead when calculating the initial malloc maximum.
1190
cb993c58
PE
1191 Port --enable-checking=all to Fedora 14 x86.
1192 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1193 Move to lisp.h.
1194 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1195 (overrun_check_realloc, overrun_check_free):
1196 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1197 That way, xmalloc returns a properly-aligned pointer even if
1198 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1199 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1200 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1201 into account when calculating the initial malloc maximum.
1202 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1203 Move here from alloc.c, so that charset.c can use it too.
1204 Properly align; the old code wasn't right for common 32-bit hosts
1205 when configured with --enable-checking=all.
1206 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1207 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1208
31bed486
EZ
12092011-09-29 Eli Zaretskii <eliz@gnu.org>
1210
04c70788 1211 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1212 use EDOM.
1213
fbcaa2f3
EZ
12142011-09-28 Eli Zaretskii <eliz@gnu.org>
1215
1216 * xdisp.c (compute_display_string_end): If there's no display
1217 string at CHARPOS, return -1.
1218
1219 * bidi.c (bidi_fetch_char): When compute_display_string_end
1220 returns a negative value, treat the character as a normal
1221 character not covered by a display string. (Bug#9624)
1222
a239d4e9
JB
12232011-09-28 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * lread.c (Fread_from_string): Fix typo in docstring.
1226
88652fd5
EZ
12272011-09-27 Eli Zaretskii <eliz@gnu.org>
1228
1229 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1230 newline, reseat the iterator instead of bidi-iterating there one
1231 character at a time. (Bug#9610)
32c1fffd
SM
1232 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1233 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1234
ed497dd4
AS
12352011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1236
1237 * lread.c (readevalloop): Use correct code for NBSP.
1238 (read1): Likewise. (Bug#9608)
1239
b2bf61aa
MA
12402011-09-25 Michael Albinus <michael.albinus@gmx.de>
1241
1242 * dbusbind.c (Fdbus_register_signal): When service is not
1243 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1244
32bbb17c
GM
12452011-09-25 Glenn Morris <rgm@gnu.org>
1246
1247 * buffer.c (truncate-lines): Doc fix.
1248
94e0933e
CY
12492011-09-24 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1252 (Fset_window_next_buffers): Doc fix.
1253
cddde921
GM
12542011-09-24 Glenn Morris <rgm@gnu.org>
1255
1256 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1257
1260aef1
PE
12582011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1259
25b4bfa0
PE
1260 Fix minor problems found by static checking.
1261 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1262 * indent.c (Fvertical_motion): Fix == vs = typo.
1263
e3cbd34b
EZ
12642011-09-24 Eli Zaretskii <eliz@gnu.org>
1265
a66cfb1c
SM
1266 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1267 Default value is now t. Doc fix.
6bf7006f 1268
e3cbd34b 1269 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1270 logic when moving up, not only when moving down. Fix the
e3cbd34b 1271 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1272 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1273
1274 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1275 CHARPOS is covered by a display string which includes newlines.
1276 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1277 is covered by a display string with embedded newlines.
1278
a3de0cbd
MA
12792011-09-24 Michael Albinus <michael.albinus@gmx.de>
1280
1281 * dbusbind.c (Fdbus_register_signal): Add match rule to
1282 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1283 (Fdbus_register_method, Vdbus_registered_objects_table):
1284 Fix docstring.
a3de0cbd 1285
b260039d
JM
12862011-09-24 Jim Meyering <meyering@redhat.com>
1287
32c1fffd 1288 do not ignore write error for any output size
b260039d
JM
1289 The previous change was incomplete.
1290 While it makes emacs --batch detect the vast majority of stdout
1291 write failures, errors were still ignored whenever the output size is
1292 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1293 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1294 && echo FAIL: ignored write error
1295 FAIL: ignored write error
1296 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1297 && echo FAIL: ignored write error
1298 FAIL: ignored write error
1299 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1300
8eca8a7c
AS
13012011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1302
1303 * emacs.c (Fkill_emacs): In noninteractive mode exit
1304 non-successfully if a write error occurred on stdout. (Bug#9574)
1305
3341db62
EZ
13062011-09-21 Eli Zaretskii <eliz@gnu.org>
1307
1308 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1309 the xassert test.
1310
1311 * dispextern.h (struct it): Update the comment documenting what
1312 can it->OBJECT be.
1313
8c203dbf
EZ
13142011-09-20 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1317 a display string, extend search for cursor position to end of row.
1318 (find_row_edges): If the row ends in a newline from a display
1319 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1320 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1321 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1322 non-empty line. Fixes confusing cursor motion with arrow keys at
1323 the beginning of a line that starts with whitespace.
8c203dbf 1324
a4824228
LMI
13252011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1326
1327 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1328 (bug#9493).
1329
33ed493b
CY
13302011-09-18 Chong Yidong <cyd@stupidchicken.com>
1331
1332 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1333 boolean (Bug#9154).
1334
56cd55c8
EZ
13352011-09-18 Eli Zaretskii <eliz@gnu.org>
1336
1337 * xdisp.c (display_line): Record maximum and minimum buffer
1338 positions even if no glyphs were produced (e.g., by a zero-width
1339 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1340 buffer positions that will be removed from the glyph row because
1341 they don't fit.
c02dcedf
EZ
1342 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1343 column is beyond frame width: don't subtract 1 "pixel" when
1344 computing width of the stretch.
3e62b7e0
EZ
1345 (reseat_at_next_visible_line_start): Undo the change made on
1346 2011-09-17 that saved paragraph information and restored it after
1347 the call to `reseat'. (Bug#9545)
56cd55c8 1348
5ed99d36 13492011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1350
1351 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1352 and turn window cursor on if cleared (Bug#9415).
1353
5ed99d36 13542011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1355
1356 * search.c (boyer_moore): Take unibyte characters from pattern
1357 literally. (Bug#9458)
1358
9bade7b2
EZ
13592011-09-18 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1362
e5e9d610
PE
13632011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1364
87e4427a
PE
1365 Fix minor problem found by static checking.
1366 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1367 initialized, to pacify gcc -Wuninitialized.
1368
e5e9d610
PE
1369 * fileio.c: Report proper errno when syscall falls.
1370 (Finsert_file_contents): Save and restore errno,
1371 so that report_file_error outputs the correct diagnostic.
1372 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1373
a1674f0b
EZ
13742011-09-18 Eli Zaretskii <eliz@gnu.org>
1375
1376 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1377
fbfb6dd4
EZ
13782011-09-17 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1381 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1382
bb187662
EZ
13832011-09-17 Eli Zaretskii <eliz@gnu.org>
1384
1137e8b8 1385 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1386 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1387
1388 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1389 (bidi_find_paragraph_start): Search back for paragraph beginning
1390 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1391 (bidi_move_to_visually_next): Only trigger paragraph-related
1392 computations when the last character is a newline or at EOB, not
1393 just any NEUTRAL_B. (Bug#9470)
1394
bb187662
EZ
1395 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1396 truncated lines if point is covered by a display string. (Bug#9524)
1397
2e621251
PE
13982011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1401 (cons_to_x_long): New function.
1402 (lisp_data_to_selection_data): Use it. Correct the test for
1403 short-versus-long data; it was negated. Break out of vector
1404 loop, for efficiency, when a long datum is discovered.
1405
91a15bc6
SM
14062011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1409
b41c3a35
EZ
14102011-09-16 Eli Zaretskii <eliz@gnu.org>
1411
1412 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1413 GCC PR/17406) by declaring this function with external scope.
1414
7812ba2d
PE
14152011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1418 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1419
cf7edc2a
AS
14202011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1421
1422 * editfns.c (Fformat): Correctly handle text properties on "%%".
1423
bd01620e
EZ
14242011-09-15 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xterm.c (x_draw_composite_glyph_string_foreground):
1427 * w32term.c (x_draw_composite_glyph_string_foreground):
1428 * term.c (encode_terminal_code):
1429 * composite.c (composition_update_it, get_composition_id):
1430 * xdisp.c (get_next_display_element)
1431 (fill_composite_glyph_string): Add comments about special meaning
1432 of TAB characters in a composition.
1433
a02719a3
PE
14342011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1437 This occurs when processing a multibyte format.
1438 Problem reported by Wolfgang Jenker.
a02719a3 1439
72589a3c
JB
14402011-09-15 Johan Bockgård <bojohan@gnu.org>
1441
1442 * xdisp.c (try_cursor_movement): Only check for exact match if
1443 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1444
1c14176c
PE
14452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 Remove unused external symbols.
1448 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1449 * xdisp.c (calc_pixel_width_or_height): Now static.
1450 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1451 * indent.c (check_display_width):
1452 * w32term.c: Fix comment to match code.
1453 * xterm.c, xterm.h (x_catching_errors): Remove.
1454
d2eea5b5
PE
14552011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 * xselect.c: Use signed conversions more consistently (Bug#9498).
1458 (selection_data_to_lisp_data): Assume incoming selection data are
1459 signed integers, not unsigned. This is to be consistent with
1460 outgoing selection data, which was modified to use signed integers
1461 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1462 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1463 expects long, not unsigned long.
1464
46888499
EZ
14652011-09-14 Eli Zaretskii <eliz@gnu.org>
1466
1467 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1468 computation of loop end. Reported by Johan Bockgård
1469 <bojohan@gnu.org>.
1470
ef8ef9fb
CY
14712011-09-13 Chong Yidong <cyd@stupidchicken.com>
1472
1473 * frame.c (Fother_visible_frames_p): Function deleted.
1474
fa819fed
EZ
14752011-09-12 Eli Zaretskii <eliz@gnu.org>
1476
1477 * indent.c (compute_motion): Process display vector front to back
1478 rather than the other way around. (Bug#2496)
1479
2ba8e008
SM
14802011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1481
1482 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1483
20f53c69
CY
14842011-09-11 Chong Yidong <cyd@stupidchicken.com>
1485
1486 * minibuf.c (Fread_from_minibuffer): Doc fix.
1487
d562d7a4
EZ
14882011-09-11 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1491 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1492
1c4d7f3d
LMI
14932011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1494
1495 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1496 value for non-existent files.
1497
b885bf36
EZ
14982011-09-11 Eli Zaretskii <eliz@gnu.org>
1499
1500 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1501 set its "size" to -1. This will set the modtime_size field of
1502 the corresponding buffer to -1, which is what
1503 verify-visited-file-modtime expects for files that do not exist.
1504 (Bug#9139)
1505
6612f0bf
PE
15062011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1507
1508 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1509 here ...
1510 * lisp.h: ... from here. push_key_description is no longer
1511 defined in keyboard.c, so its declaration should not be in
1512 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1513 logically belongs with push_key_description.
1514
dfb3f755
PE
15152011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * buffer.h: Include <sys/types.h> instead of <time.h>.
1518 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1519 Problem reported by Herbert J. Skuhra.
1520
3134906c
LMI
15212011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1522
1523 * xml.c (parse_region): Make the parsing work for
1524 non-comment-starting XML files again (bug#9144).
1525
8d903f4e
AS
15262011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1527
1528 * image.c (gif_load): Fix calculation of bottom and right corner.
1529 (Bug#9468)
1530
80ad64f4
EZ
15312011-09-10 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1534 redisplay in small windows.
1535
208a048d
EZ
15362011-09-09 Eli Zaretskii <eliz@gnu.org>
1537
1538 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1539
9b1c252e
MR
15402011-09-08 Martin Rudalics <rudalics@gmx.at>
1541
1542 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1543 Operate on live windows only.
1544
2949f33b
JB
15452011-09-08 Juanma Barranquero <lekktu@gmail.com>
1546
1547 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1548
e08dcafd
EZ
15492011-09-07 Eli Zaretskii <eliz@gnu.org>
1550
1551 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1552 only under bidi iteration.
1553
115b96bd
JD
15542011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1555
1556 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1557
c8199d0f
PE
15582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1561 Without this fix, the command to link temacs failed due to an
1562 undefined symbol __builtin_isnan. This is because
1563 /usr/include/iso/math_c99.h #defines isnan(x) to
1564 __builtin_isnan(x), but the bundled gcc, which identifies itself
1565 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1566 a __builtin_isnan.
1567 * floatfns.c (isnan): #undef, and then #define to a clone of
1568 what's in data.c.
1569 (Fisnan): Always define, since it's always available now.
1570 (syms_of_floatfns): Always define isnan at the Lisp level.
1571
e39b275c 15722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1573
1574 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1575
b2db44d9 15762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1577
f4af5137 1578 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1579 The previous code assumed that file offsets (off_t values) fit in
1580 EMACS_INT variables, which is not true on typical 32-bit hosts.
1581 The code messed up by falsely reporting buffer overflow in cases
1582 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1583 when "big" contains more than 2**29 bytes, even though this
1584 inserts just one byte and does not overflow the buffer.
1585 (Finsert_file_contents): Store file offsets as off_t
1586 values, not as EMACS_INT values. Check for overflow when
1587 converting between EMACS_INT and off_t. When checking for
1588 buffer overflow or for overlap, take the offsets into account.
1589 Don't use EMACS_INT for small values where int suffices.
1590 When checking for overlap, fix a typo: ZV was used where
1591 ZV_BYTE was intended.
1592 (Fwrite_region): Don't assume off_t fits into 'long'.
1593 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1594
ecfc0a49
MA
15952011-09-05 Michael Albinus <michael.albinus@gmx.de>
1596
1597 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1598
6511acf2 15992011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1600
0999621a 1601 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1602
1603 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1604 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1605 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1606 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1607 (modify_event_symbol): Do not assume that the length of
1608 name_alist_or_stem is safe to alloca and fits in int.
1609 (Fexecute_extended_command): Likewise for function name and binding.
1610 (Frecursion_depth): Wrap around reliably on integer overflow.
1611 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1612 since some callers pass EMACS_INT values.
1613 (Fsingle_key_description): Don't crash if symbol name contains more
1614 than MAX_ALLOCA bytes.
1615 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1616 (get_minibuffer): Arg is now EMACS_INT, not int.
1617 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1618 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1619 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1620
2be7d702
PE
1621 * dbusbind.c (signature_cat): New function.
1622 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1623 Do not overrun buffer; instead, report string overflow.
1624
9d1df220
PE
1625 * dispnew.c (add_window_display_history): Don't overrun buffer.
1626 Truncate instead; this is OK since it's just a log.
1627
33ef5c64
PE
1628 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1629 even if the time zone offset is outlandishly large.
1630 Don't mishandle offset == INT_MIN.
1631
66c6fdd5
PE
1632 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1633 when creating daemon; the previous buffer-overflow check was incorrect.
1634
d749b01b
PE
1635 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1636 which has the guts of the old verror function.
1637
b5cd1905
PE
1638 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1639 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1640
6e1a67fb
PE
1641 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1642 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1643 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1644 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1645 length of string rather than counting it via multiple sprintfs;
1646 that's simpler and more reliable.
c21721cc
PE
1647 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1648 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1649 sprintf, in case result does not fit in int.
1650
c57b67fc
PE
1651 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1652 (fontset_from_font): Print it.
1653
8a401434
PE
1654 * frame.c (tty_frame_count): Now printmax_t, not int.
1655 (make_terminal_frame, set_term_frame_name): Print it.
1656 (x_report_frame_params): In X, window IDs are unsigned long,
1657 not signed long, so print them as unsigned.
1658 (validate_x_resource_name): Check for implausibly long names,
1659 and don't assume name length fits in 'int'.
1660 (x_get_resource_string): Don't blindly alloca invocation name;
1661 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1662 not fit in int.
1663
6e1a67fb
PE
1664 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1665 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1666 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1667
0df02bf3
PE
1668 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1669 Use esprintf, not sprintf, in case result does not fit in int.
1670
48e30793
PE
1671 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1672 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1673 it as a large positive number.
1674 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1675 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1676
a66ff6d8
PE
1677 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1678 in case result does not fit in int.
1679
aca216ff
PE
1680 * print.c (float_to_string): Detect width overflow more reliably.
1681 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1682 buffer overrun. Don't assume list length fits in 'int'. Treat
1683 print length of 0 as 0, not as infinity; to be consistent with other
1684 uses of print length in this function. Don't overflow print length
1685 index. Don't assume hash table size fits in 'long', or that
1686 vectorlike size fits in 'unsigned long'.
1687
31c286f7
PE
1688 * process.c (make_process): Use printmax_t, not int, to format
1689 process-name gensyms.
1690
55e5faa1
PE
1691 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1692
80f2e268
PE
1693 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1694 to avoid potential buffer overrun.
1695
670741ab
PE
1696 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1697 if X resource line is longer than 512 bytes.
1698
b7163a50
PE
1699 * xfns.c (x_window): Make sprintf buffer a bit bigger
1700 to avoid potential buffer overrun.
1701
ae58ff1f
PE
1702 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1703
c43c8a6a
PE
1704 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1705
3f8236f4
PE
17062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1707
53e9fe90 1708 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1709 Without these, Emacs silently mishandles large integers sometimes.
1710 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1711 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1712
6511acf2
PE
1713 * xdisp.c (try_window_id): Check Emacs fixnum range before
1714 converting to 'int'.
806add1d 1715
6511acf2 1716 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1717 Check that an Emacs fixnum is in range before assigning it to 'int'.
1718 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1719 values converted from Emacs fixnums.
1720 (Frecenter): Don't wrap around a line count if it is out of 'int'
1721 range; instead, treat it as an extreme value.
1722 (Fset_window_configuration, compare_window_configurations):
1723 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1724
6511acf2
PE
1725 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1726 that can exceed INT_MAX. Check that EMACS_INT value is in range
1727 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1728 (match_limit): Don't assume that a fixnum can fit in 'int'.
1729
6511acf2 1730 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1731 exceed INT_MAX.
1732
6511acf2 1733 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1734 (Fvertical_motion): Don't wrap around LINES values that don't fit
1735 in 'int'. Instead, treat them as extreme values. This is good
1736 enough for windows, which can't have more than INT_MAX lines anyway.
1737
fcb901a7
LMI
17382011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1739
0f2f6b6d
LMI
1740 * Require libxml/parser.h to avoid compilation warning.
1741
fcb901a7
LMI
1742 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1743
1744 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1745 since this reportedly can destroy thread storage.
1746
6e20a0d4
CY
17472011-08-30 Chong Yidong <cyd@stupidchicken.com>
1748
1749 * syntax.c (find_defun_start): Update all cache variables if
1750 exiting early (Bug#9401).
1751
148ae00e
EZ
17522011-08-30 Eli Zaretskii <eliz@gnu.org>
1753
f6cfbd8f
EZ
1754 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1755
148ae00e
EZ
1756 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1757 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1758 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1759
1760 * term.c (tty_append_glyph): New function.
1761 (produce_stretch_glyph): Static function and its prototype deleted.
1762
a66cfb1c
SM
1763 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1764 Add prototypes.
148ae00e 1765
c4a07a4c
PE
17662011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1769 when checking :margin (Bug#9390).
1770 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1771 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1772 so that the name doesn't mislead. All uses changed.
1773
6bc8cd65
JB
17742011-08-28 Johan Bockgård <bojohan@gnu.org>
1775
1776 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1777 set_tty_hooks.
1778
dca4927e
EZ
17792011-08-27 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (move_it_to): Don't bail out early when reaching
1782 position beyond to_charpos, if we are scanning backwards.
1783 (move_it_vertically_backward): When DY == 0, make sure we get to
1784 the first character in the line after the newline.
1785
f2cad773
PE
17862011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1789 (ccl_driver): Do not generate an out-of-range pointer.
1790 (Fccl_execute_on_string): Remove unnecessary check for
1791 integer overflow, noted by Stefan Monnier in
1792 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1793 Remove a FIXME that didn't need fixing.
1794 Simplify the newly-introduced buffer reallocation code.
1795
0cae2cdb
JB
17962011-08-27 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1799
5fc295a4 18002011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1801
70c60eb2 1802 Integer and memory overflow issues (Bug#9196).
726e0ab1 1803
d31850da
PE
1804 * doc.c (get_doc_string): Rework so that
1805 get_doc_string_buffer_size is the actual buffer size, rather than
1806 being 1 less than the actual buffer size; this makes xpalloc more
1807 convenient.
1808
a69fbedb
PE
1809 * image.c (x_allocate_bitmap_record, cache_image):
1810 * xselect.c (Fx_register_dnd_atom):
1811 Simplify previous changes by using xpalloc.
1812
fe5c5d37
PE
1813 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1814 since either will do and ptrdiff_t is convenient with xpalloc.
1815
0065d054
PE
1816 * charset.c (charset_table_size)
1817 (struct charset_sort_data.priority): Now ptrdiff_t.
1818 (charset_compare): Don't overflow if priorities differ greatly.
1819 (Fsort_charsets): Don't assume list length fits in int.
1820 Check for size-calculation overflow when allocating sort data.
1821 (syms_of_charset): Allocate an initial charset table that is
1822 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1823
1824 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1825
1826 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1827 The actual value is always <= INT_MAX, and leaving it unsigned made
1828 overflow checking harder.
1829
1830 * dispextern.h (struct glyph_matrix.rows_allocated)
1831 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1832 with xpalloc. The values are still always <= INT_MAX.
1833
1834 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1835
1836 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1837 (SAFE_NALLOCA): New macro.
1838
1839 * region-cache.c (struct boundary.pos, find_cache_boundary)
1840 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1841 (set_cache_region, invalidate_region_cache)
1842 (revalidate_region_cache, know_region_cache, region_cache_forward)
1843 (region_cache_backward, pp_cache):
1844 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1845 so that ptrdiff_t * can be passed to xpalloc.
1846 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1847 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1848 (pp_cache): Don't assume cache_len fits in int.
1849 * region-cache.h: Adjust extern decls to match.
1850
1851 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1852 EMACS_INT, since either will do, for xpalloc.
1853
1854 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1855 (xnmalloc, xnrealloc, xpalloc): New functions.
1856
726e0ab1
PE
1857 * bidi.c (bidi_shelve_header_size): New constant.
1858 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1859 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1860
51f30bc5 1861 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1862 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1863 (overlay_strings):
1864 Don't update size of array until after memory allocation succeeds,
1865 because xmalloc/xrealloc may not return.
0065d054
PE
1866 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1867 now that we have proper integer overflow checking.
1868 (record_overlay_string, overlay_strings): Catch overflows when
1869 calculating size of overlay_str_buf.
726e0ab1 1870
0065d054
PE
1871 * callproc.c (Fcall_process): Check for size overflow when
1872 calculating size of args2.
1873 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1874 Normally we prefer signed values, but sticking with ptrdiff_t would
1875 require adding more-complicated checks.
726e0ab1
PE
1876
1877 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1878 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1879 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1880 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1881
1882 * character.c (Fstring): Check for size-calculation overflow.
1883
1884 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1885 unnecessary integer overflow. Check for size overflow.
1886 (encode_coding_object): Don't update size until xmalloc succeeds.
1887
1888 * composite.c (get_composition_id): Check for overflow in glyph
1889 length calculations.
1890
1891 Integer and memory overflow fixes for display code.
1892 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1893 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1894 (scrolling_window): Check for overflow in size calculations.
1895 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1896 Don't assume glyph table len fits in int.
1897 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1898 (row_table_size): Now ptrdiff_t, not int.
1899 (scrolling_window): Avoid overflow in size calculations.
1900 Don't update size until allocation succeeds.
1901 * fns.c (concat): Check for overflow in size calculations.
1902 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1903 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1904 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1905
1906 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1907 (get_doc_string): Check for size calculation overflow.
1908 Don't update size until allocation succeeds.
1909 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1910 EMACS_INT, where ptrdiff_t will do.
1911 (Fsubstitute_command_keys): Check for string overflow.
1912
1913 * editfns.c (set_time_zone_rule): Don't assume environment length
1914 fits in int.
1915 (message_length): Now ptrdiff_t, not int.
1916 (Fmessage_box): Don't update size until allocation succeeds.
1917 Don't assume message length fits in int.
1918 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1919
0065d054
PE
1920 * emacs.c (main): Do not reallocate argv, since there is a null at
1921 the end that can be overwritten, and this way there's no need to
1922 worry about size-calculation overflow.
1923 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1924
1925 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1926 alloc succeeds.
1927 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1928
1929 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1930 (x_set_scroll_bar_width, x_figure_window_size):
1931 Check for integer overflow.
1932 (x_set_alpha): Do not assume XINT fits in int.
1933
1934 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1935 This is for the members text_lines, text_cols, total_lines, total_cols,
1936 where the system imposes an 'int' limit.
1937
1938 * fringe.c (Fdefine_fringe_bitmap):
1939 Don't update size until alloc works.
1940
1941 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1942 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1943
1944 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1945 Check for size-calculation overflow.
1946 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1947 do, as we prefer signed integers.
1948 (id_to_widget.max_size, id_to_widget.used)
1949 (xg_store_widget_in_map, xg_remove_widget_from_map)
1950 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1951 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1952 Use and return ptrdiff_t, not int.
1953 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1954 * gtkutil.h: Change prototypes to match the above.
1955
1956 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1957 are duplicate now that they've been promoted to lisp.h.
1958 (x_allocate_bitmap_record, x_alloc_image_color)
1959 (make_image_cache, cache_image, xpm_load):
1960 Don't update size until alloc is done.
1961 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1962 (x_detect_edges):
3256efce 1963 Check for size calculation overflow.
726e0ab1
PE
1964 (ct_colors_allocated_max): New constant.
1965 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1966 overflow.
3256efce 1967
726e0ab1
PE
1968 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1969 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1970 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1971 Use ptrdiff_t, not int, to count maps.
1972 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1973 calculations. Don't update size until allocation succeeds.
1974 Redo calculations to avoid overflow.
726e0ab1
PE
1975 * keyboard.h: Change prototypes to match the above.
1976
1977 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1978 to count maps.
1979 (current_minor_maps): Check for size calculation overflow.
1980 * keymap.h: Change prototypes to match the above.
1981
1982 * lread.c (read1, init_obarray): Don't update size until alloc done.
1983
1984 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1985 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1986
726e0ab1
PE
1987 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1988 Now ptrdiff_t, not int.
1989 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1990 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1991
1992 * process.c (Fnetwork_interface_list): Check for overflow
1993 in size calculation.
1994
1995 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1996
1997 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1998 overflow. Don't bother calling xmalloc when xrealloc will do.
1999
2000 * search.c (Freplace_match): Check for size calculation overflow.
2001 (Fset_match_data): Don't assume list lengths fit in 'int'.
2002
2003 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2004 for command line length. Do not attempt to address one before the
2005 beginning of an array, as that's not portable.
2006
2007 * term.c (max_frame_lines): Remove; unused.
2008 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2009 not int.
2010 (encode_terminal_code, calculate_costs): Check for size
2011 calculation overflow.
2012 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2013 table lengths and related sizes. Don't update size until alloc
2014 done. Redo calculations to avoid overflow.
2015 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2016
2017 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2018 subtracting pointers.
2019 (gobble_line): Check for overflow more carefully. Don't update size
2020 until alloc done.
2021
2022 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2023 Don't update size until alloc done.
2024 Redo size calculations to avoid overflow.
2025 Check for size calculation overflow.
0065d054 2026 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2027
2028 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2029 Use ptrdiff_t, not int, for sizes.
2030 (store_mode_line_noprop_char): Don't update size until alloc done.
2031
0065d054
PE
2032 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2033 Use ptrdiff_t, not int, for sizes.
2034 (Finternal_make_lisp_face, cache_face):
2035 Check for size calculation overflow.
2036 (cache_face): Treat size calculation overflows as if they were
2037 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2038
2039 * xfns.c (x_encode_text, x_set_name_internal)
2040 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2041 sizes, since they can exceed INT_MAX in size. Check for size
2042 calculation overflow.
2043
0065d054
PE
2044 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2045 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2046 Don't update size until alloc done.
2047
0065d054 2048 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2049 as sprintf is limited to int lengths.
1d526e2f 2050
252c5ee1
PE
2051 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2052 (X_LONG_MIN): New macros.
864d7ce7
PE
2053 Use them to make the following changes clearer.
2054 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2055 This change doesn't affect the value now, but it may help remind
2056 future maintainers not to raise the value too much later.
2057 (SELECTION_QUANTUM): Remove, replacing with ...
2058 (selection_quantum): ... new function, which avoids overflow.
2059 All uses changed.
2060 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2061 assumption that selection length fits in 'int'.
2062 (x_reply_selection_request, x_handle_selection_request)
2063 (x_get_window_property, receive_incremental_selection)
2064 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2065 (lisp_data_to_selection_data, clean_local_selection_data):
2066 Use ptrdiff_t, not int, to record length of selection.
2067 (x_reply_selection_request, x_get_window_property)
2068 (receive_incremental_selection, x_property_data_to_lisp):
2069 Redo calculations to avoid overflow.
2070 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2071 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2072 something.
2073 (x_get_window_property, receive_incremental_selection)
2074 (lisp_data_to_selection_data, x_property_data_to_lisp):
2075 Check for size-calculation overflow.
2076 (x_get_window_property, receive_incremental_selection)
2077 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2078 Don't store size until memory allocation succeeds.
2079 (x_get_window_property): Plug memory leak on memory exhaustion.
2080 Don't double-block input; malloc is safe here. Don't assume 2**34
2081 - 4 fits in unsigned long. Add an xassert to check
2082 XGetWindowProperty overflow. Be more careful about overflow
2083 calculations, and distinguish size from memory overflow better.
2084 (receive_incremental_selection): When tracing, don't assume
2085 unsigned int is less than INT_MAX.
2086 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2087 harmful) conversions of unsigned short to int.
2088 (lisp_data_to_selection_data): Don't assume that integers
2089 in the range -65535 through -1 fit in an X unsigned short.
2090 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2091 result parameters unless successful. Rely on cons_to_unsigned
2092 to report problems with elements; the old code wasn't right anyway.
2093 (x_check_property_data): Check for int overflow; we cannot use
2094 a wider type due to X limits.
2095 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2096
726e0ab1 2097 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2098
0065d054
PE
2099 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2100 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2101 (x_color_cells): Don't store size until memory allocation succeeds.
2102 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2103 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2104 (x_term_init): Don't assume length fits in int (sprintf is limited
2105 to int size).
bc18e09d 2106
ebfa62c0
PE
2107 Use ptrdiff_t for composition IDs.
2108 * character.c (lisp_string_width):
2109 * composite.c (composition_table_size, n_compositions)
2110 (get_composition_id, composition_gstring_from_id):
2111 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2112 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2113 * window.c (Frecenter):
2114 Use ptrdiff_t, not int, for composition IDs.
2115 * composite.c (get_composition_id): Check for integer overflow.
2116 * composite.h: Adjust prototypes to match the above changes.
2117
d3411f89
PE
2118 Use ptrdiff_t for hash table indexes.
2119 * category.c (hash_get_category_set):
2120 * ccl.c (ccl_driver):
2121 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2122 * coding.c (coding_system_charset_list, detect_coding_system):
2123 * coding.h (struct coding_system.id):
2124 * composite.c (get_composition_id, gstring_lookup_cache):
2125 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2126 * image.c (xpm_get_color_table_h):
2127 * lisp.h (hash_lookup, hash_put):
2128 * minibuf.c (Ftest_completion):
2129 Use ptrdiff_t for hash table indexes, not int (which is too
2130 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2131 32-bit --with-wide-int hosts).
2132
e097a6fa
PE
2133 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2134 Add a FIXME comment about memory leaks.
2135 (syms_of_charset): Don't assume xmalloc returns.
2136
5637687f
PE
2137 Don't assume that stated character widths fit in int.
2138 * character.c (Fchar_width, c_string_width, lisp_string_width):
2139 * character.h (CHAR_WIDTH):
2140 * indent.c (MULTIBYTE_BYTES_WIDTH):
2141 Use sanitize_char_width to avoid undefined and/or bad behavior
2142 with outlandish widths.
a66cfb1c 2143 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2144 now that we have two such functions. All uses changed.
2145 (sanitize_char_width): New inline function.
2146
a2271ba2
PE
2147 Don't assume that tab-width fits in int.
2148 * character.h (sanitize_width): New inline function.
2149 (SANE_TAB_WIDTH): New macro.
2150 (ASCII_CHAR_WIDTH): Use it.
2151 * indent.c (sane_tab_width): Remove. All uses replaced by
2152 SANE_TAB_WIDTH (current_buffer).
2153 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2154
18c52557
PE
2155 * fileio.c: Integer overflow issues with file modes.
2156 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2157
caeeedc1
PE
2158 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2159 Remove unreachable code.
2160 (read_hex, load_charset_map_from_file): Check for integer overflow.
2161
50849c52
PE
2162 * xterm.c: don't go over XClientMessageEvent limit
2163 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2164 (x_send_scroll_bar_event): Likewise. Check that the size does not
2165 exceed limits imposed by XClientMessageEvent, as well as the usual
2166 ptrdiff_t and size_t limits.
2167
b13995db
PE
2168 * keyboard.c: Overflow, signedness and related fixes.
2169 (make_lispy_movement): Use same integer type in forward decl
2170 that is used in the definition.
2171 (read_key_sequence, keyremap_step):
2172 Change bufsize argument back to int, undoing my 2011-03-30 change.
2173 We prefer signed types, and int is wide enough here.
2174 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2175 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2176 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2177 length, not size_t. Use ptrdiff_t for index, not int.
2178 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2179 possibility of integer overflow.
2180
13464394
PE
2181 Overflow, signedness and related fixes for images.
2182
2183 * dispextern.h (struct it.stack[0].u.image.image_id)
2184 (struct_it.image_id, struct image.id, struct image_cache.size)
2185 (struct image_cache.used, struct image_cache.ref_count):
2186 * gtkutil.c (update_frame_tool_bar):
2187 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2188 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2189 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2190 * nsmenu.m (update_frame_tool_bar):
2191 * xdisp.c (calc_pixel_width_or_height):
2192 * xfns.c (image_cache_refcount):
2193 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2194 on typical 64-bit hosts.
2195
2196 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2197 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2198 Omit unnecessary casts to int.
2199 (parse_image_spec): Check that integers fall into 'int' range
2200 when the callers expect that.
2201 (image_ascent): Redo ascent calculation to avoid int overflow.
2202 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2203 (lookup_image): Remove unnecessary tests.
2204 (xbm_image_p): Locals are now of int, not EMACS_INT,
2205 since parse_image_check makes sure they fit into int.
2206 (png_load, gif_load, svg_load_image):
2207 Prefer int to unsigned where either will do.
2208 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2209 old tiff_error_handler and tiff_warning_handler.
2210 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2211 stack buffer overflows. It uses only the features of vsnprintf
2212 that are common to both POSIX and native Microsoft.
2213 (tiff_error_handler, tiff_warning_handler): Use it.
2214 (tiff_load, gif_load, imagemagick_load_image):
2215 Don't assume :index value fits in 'int'.
2216 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2217 (imagemagick_load_image): Check that crop parameters fit into
2218 the integer types that MagickCropImage accepts. Don't assume
2219 Vimagemagick_render_type has a nonnegative value. Don't assume
2220 size_t fits in 'long'.
2221 (gs_load): Use printmax_t to print the widest integers possible.
2222 Check for integer overflow when computing image height and width.
2223
c11821d4
EZ
22242011-08-26 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (redisplay_window): Don't force window start if point
2227 will be invisible in the resulting window. (Bug#9324)
2228
0c95fcf7
EZ
22292011-08-25 Eli Zaretskii <eliz@gnu.org>
2230
2231 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2232 the display spec is of the form `(space ...)'.
2233 (handle_display_spec): Return the value returned by
2234 handle_single_display_spec, not just 1 or zero.
2235 (handle_single_display_spec): If the display spec is of the form
2236 `(space ...)', and specifies display in the text area, return 2
2237 rather than 1.
fee65a97 2238 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2239 accurately, and prefer exact match for point under bidi.
2240 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2241
2242 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2243 into disp_prop; all users changed.
2244
2245 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2246 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2247 for the text covered by the display property.
2248
e4ed06f1
CY
22492011-08-25 Chong Yidong <cyd@stupidchicken.com>
2250
2251 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2252 Change return value to nil.
2253 (Frecord_buffer): Delete unused function.
2254
f67cdd7f
EZ
22552011-08-24 Eli Zaretskii <eliz@gnu.org>
2256
5980d4c6
EZ
2257 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2258 buffers, return left-to-right.
8610fe8b
EZ
2259 (set_cursor_from_row): Consider candidate row a win if its glyph
2260 represents a newline and point is on that newline. Fixes cursor
2261 positioning on the newline at EOL of R2L text within L2R
2262 paragraph, and vice versa.
2263 (try_cursor_movement): Check continued rows, in addition to
2264 continuation rows. Fixes unwarranted scroll when point enters a
2265 continued line of R2L text within an L2R paragraph, or vice versa.
2266 (cursor_row_p): Consider the case of point being equal to
2267 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2268 from the end of a short line to the beginning of a continued line
2269 of R2L text within L2R paragraph.
2270 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2271 composed characters.
5980d4c6 2272
f67cdd7f
EZ
2273 * bidi.c (bidi_check_type): Use xassert.
2274 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2275 members.
2276
bca633fb
EZ
22772011-08-23 Eli Zaretskii <eliz@gnu.org>
2278
2279 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2280 a character.
2281
4a5885a7
CY
22822011-08-23 Chong Yidong <cyd@stupidchicken.com>
2283
2284 * nsfont.m (ns_otf_to_script): Fix typo.
2285
0902a04e
KH
22862011-08-22 Kenichi Handa <handa@m17n.org>
2287
2288 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2289 extra slot even if the purpose is char-code-property-table.
2290
1a2e6670
EZ
22912011-08-23 Eli Zaretskii <eliz@gnu.org>
2292
8ddde651
EZ
2293 * xdisp.c (redisplay_window): When computing centering_position,
2294 account for the height of the header line. (Bug#8874)
2295
425cc014
EZ
2296 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2297 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2298 candidate is selected by the mouse, and that candidate has a
2299 composed character under the mouse.
2300
1a2e6670
EZ
2301 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2302 coordinates reported by pos-visible-in-window-p for a composed
2303 character in column zero.
2304
8b76d6f8
SM
23052011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2306
2307 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2308
dac347dd
EZ
23092011-08-22 Eli Zaretskii <eliz@gnu.org>
2310
2311 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2312 consider it a hit if to_charpos is anywhere in the range of the
2313 composed buffer positions.
2314
e013fb34
CY
23152011-08-22 Chong Yidong <cyd@stupidchicken.com>
2316
2317 * image.c (gif_load): Don't assume that each subimage has the same
2318 dimensions as the base image. Handle disposal method that is
2319 "undefined" by the gif spec (Bug#9335).
2320
bd1ba3e8
CY
23212011-08-20 Chong Yidong <cyd@stupidchicken.com>
2322
2323 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2324 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2325
54a1215b
EZ
23262011-08-19 Eli Zaretskii <eliz@gnu.org>
2327
823564e5
EZ
2328 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2329 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2330 from an Org mode buffer to a Speedbar frame.
2331
54a1215b
EZ
2332 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2333 a composition, take its buffer position from IT->cmp_it.charpos.
2334 Fixes cursor positioning at the beginning of a line that begins
2335 with a composed character.
2336
9778ebcc
EZ
23372011-08-18 Eli Zaretskii <eliz@gnu.org>
2338
0be6ee06
EZ
2339 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2340 character bidirectional type, use STRONG_L instead. Fixes crashes
2341 in a buffer produced by `describe-categories'.
2342
9778ebcc
EZ
2343 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2344 members before the level stack, so they would be saved and
2345 restored when copying iterator state. Fixes incorrect reordering
2346 around TABs covered by display properties.
2347
156bffbe
AS
23482011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2349
6b02f655 2350 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2351
72ad093b
CY
23522011-08-17 Chong Yidong <cyd@stupidchicken.com>
2353
2354 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2355 (internal_condition_case_2, internal_condition_case_n):
2356 Remove unnecessary aborts (Bug#9081).
72ad093b 2357
35774242
EZ
23582011-08-17 Eli Zaretskii <eliz@gnu.org>
2359
2360 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2361 has no `load' handler, try opening the file locally. (Bug#9311)
2362
db76dd85
KB
23632011-08-16 Ken Brown <kbrown@cornell.edu>
2364
2365 * gmalloc.c: Expand comment.
2366
b215eee5
EZ
23672011-08-16 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2370 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2371
a4579d33
KB
23722011-08-16 Ken Brown <kbrown@cornell.edu>
2373
2374 Fix memory allocation problems in Cygwin build (Bug#9273).
2375
2376 * unexcw.c ( __malloc_initialized): Declare external variable.
2377 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2378
8b76d6f8
SM
2379 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2380 New variables.
a4579d33
KB
2381 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2382 dumped emacs.
2383 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2384 in the static heap.
2385 [CYGWIN] (special_realloc): New function.
2386 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2387 requests to realloc storage in the static heap.
2388
3ebec551
PE
23892011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 * bidi.c (bidi_initialize): Remove unused local.
2392
9fd8be00
EZ
23932011-08-15 Eli Zaretskii <eliz@gnu.org>
2394
6b02f655
SM
2395 * bidimirror.h:
2396 * biditype.h: Remove file.
2397 * makefile.w32-in ($(BLD)/bidi.$(O)):
2398 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2399
2400 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2401
2402 * chartab.c: Improve commentary for the uniprop_table API.
2403
32413314
EZ
2404 * bidi.c (bidi_paragraph_init): Support zero value of
2405 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2406 (bidi_initialize): Use uniprop_table instead of including
2407 biditype.h and bidimirror.h.
32413314 2408
9fd8be00
EZ
2409 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2410 coordinates of the iterator when restoring from ppos_it.
2411 (Bug#9296)
2412
5cf2b69b
KH
24132011-08-14 Kenichi Handa <handa@m17n.org>
2414
2415 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2416 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2417
daf17d00
EZ
24182011-08-14 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (move_it_in_display_line_to): Don't invoke
2421 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2422 ppos_it. Fixes vertical cursor motion when line beginning is
2423 covered by an image. (Bug#9296)
2424
08e3161a
JD
24252011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2426
2427 * nsterm.h (ns_run_ascript): Declare.
2428 (NSAPP_DATA2_RUNASSCRIPT): Define.
2429
2430 * nsfns.m (as_script, as_result, as_status): New static variables.
2431 (ns_run_ascript): New function.
5e617bc2 2432 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2433 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2434 the event loop. Get status from as_status (Bug#7276).
2435
2436 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2437 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2438 the event loop (Bug#7276).
2439
a3720aa2
AS
24402011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2441
2442 * gnutls.c (QCgnutls_bootprop_priority)
2443 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2444 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2445 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2446 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2447 (QCgnutls_bootprop_verify_hostname_error)
2448 (QCgnutls_bootprop_callbacks_verify): Rename from
2449 Qgnutls_bootprop_..., all uses changed.
2450
2451 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2452 uses changed.
2453
0a0d27fb
PE
24542011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2455
19d5c50c
PE
2456 * xfaces.c (Qframe_set_background_mode): Now static.
2457 * dispextern.h (Qframe_set_background_mode): Remove decl.
2458
0a0d27fb
PE
2459 * process.c (Fnetwork_interface_info): Declare local only if needed.
2460
377538cb
JD
24612011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2464 (Fnetwork_interface_list): Allocate in increments of bytes instead
2465 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2466 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2467 sockaddr.
2468 (struct ifflag_def): notrailers is smart on OSX.
2469 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2470 Get hardware address with getifaddrs if available.
2471
08fff70c
EZ
24722011-08-12 Eli Zaretskii <eliz@gnu.org>
2473
2474 * xdisp.c (iterate_out_of_display_property): xassert that
2475 IT->position is set to within IT->object's boundaries. Break from
2476 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2477 when IT->position is set up wrongly due to some bug.
2478 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2479 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2480 entry. Force push_it to save on the stack the current
2481 buffer/string position, to be restored by pop_it. Fix flags in
2482 the iterator structure wrt the object coming from a display
2483 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2484 properties. (Bug#9284)
2485
7be1c708 24862011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2487
7be1c708
CY
2488 * fontset.c (fontset_get_font_group): Add proper type checks.
2489 (Bug#9172)
aac0c6e3 2490
7be1c708 24912011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2492
7be1c708
CY
2493 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2494 and LC_VERSION_MIN_MACOSX.
2495 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2496 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2497
97bb72a6
EZ
24982011-08-08 Eli Zaretskii <eliz@gnu.org>
2499
2500 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2501 no-display-properties-and-no-overlays under bidi display.
2502 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2503 properties and overlays.
97bb72a6 2504
d5617611
CY
25052011-08-08 Chong Yidong <cyd@stupidchicken.com>
2506
37e11a63
CY
2507 * editfns.c (Fset_time_zone_rule): Document relationship with the
2508 setenv function.
2509
d5617611
CY
2510 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2511 the font entity extracted from the cache (Bug#8109).
2512
58872834
CY
25132011-08-07 Chong Yidong <cyd@stupidchicken.com>
2514
2515 * composite.c (autocmp_chars): Don't reset point. That is done by
2516 restore_point_unwind (Bug#5984).
2517
75bfc667
JL
25182011-08-07 Juri Linkov <juri@jurta.org>
2519
2520 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2521 to show the arg `TIME' instead of `TIMEVAL'.
2522
d1410150
EZ
25232011-08-06 Eli Zaretskii <eliz@gnu.org>
2524
2525 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2526 display property strides EOL and includes a newline, as in
2527 longlines-mode. (Bug#9254)
75b771e4
EZ
2528 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2529 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2530
2531 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2532 is non-zero, even if the data buffer is NULL. Fixes a crash in
2533 vertical-motion with longlines-mode. (Bug#9254)
2534
35928349
EZ
25352011-08-05 Eli Zaretskii <eliz@gnu.org>
2536
ec7cc85b
EZ
2537 * bidi.c <bidi_cache_total_alloc>: Now static.
2538 (bidi_initialize): Initialize bidi_cache_total_alloc.
2539
8b76d6f8 2540 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2541 cache. (Bug#9221)
2542
2543 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2544 amount allocated this far in `bidi_cache_total_alloc'.
2545 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2546 non-zero, only free the data buffer without restoring the cache
2547 contents. All callers changed.
2548
2549 * dispextern.h (bidi_unshelve_cache): Update prototype.
2550
2551 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2552 (move_it_in_display_line, move_it_to)
2553 (move_it_vertically_backward, move_it_by_lines): Replace the call
2554 to xfree to an equivalent call to bidi_unshelve_cache.
2555 (move_it_in_display_line_to): Fix logic of returning
412b6358 2556 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2557
e2e2423b
EZ
25582011-08-05 Eli Zaretskii <eliz@gnu.org>
2559
2560 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2561 came from a string character with a `cursor' property. (Bug#9229)
2562
ae9e757a
JD
25632011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2564
2565 * Makefile.in (LIB_PTHREAD): New variable.
2566 (LIBES): Add LIB_PTHREAD (Bug#9216).
2567
2568 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2569 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2570
213bd7f2
AS
25712011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2572
6b02f655 2573 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2574
99aaf75f
JD
25752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2576
2577 * xterm.c (x_find_topmost_parent): New function.
2578 (x_set_frame_alpha): Find topmost parent window with
2579 x_find_topmost_parent and set the property there also (bug#9181).
2580 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2581
c74e9d86
PE
25822011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * callproc.c (Fcall_process): Avoid vfork clobbering
2585 the local vars buffer, coding_systems, current_dir.
2586
640c8776
SM
25872011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2590
f26d0e4c
PE
25912011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2592
8a10d76c
PE
2593 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2594 so that it is not optimized away.
2595
f26d0e4c
PE
2596 * xdisp.c (compute_display_string_pos): Remove unused local.
2597
55439c61
EZ
25982011-08-02 Eli Zaretskii <eliz@gnu.org>
2599
2600 Fix slow cursor motion and scrolling in large buffers with
2601 selective display, like Org Mode buffers. (Bug#9218)
2602
2603 * dispextern.h (struct bidi_it): New member disp_prop_p.
2604
2605 * xdisp.c: Remove one-slot cache of display string positions.
2606 (compute_display_string_pos): Accept an additional argument
5e617bc2 2607 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2608 for a display string or property. If found, set DISP_PROP_P
2609 non-zero.
2610
2611 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2612 DISP_PROP_P, and pass it to compute_display_string_pos.
2613 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2614 non-zero. All callers of bidi_fetch_char changed.
2615
fb33fa43
SM
26162011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2617
2618 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2619
b099e063
DM
26202010-12-03 Don March <don@ohspite.net>
2621
2622 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2623 last character M-[char] is translated to ESC [char] (bug#7541).
2624
5cc7f7af
KH
26252011-08-02 Kenichi Handa <handa@m17n.org>
2626
d0fffa3f 2627 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2628
2629 * chartab.c (uniprop_table): Make it non-static.
2630
525d5e6e
EZ
26312011-08-01 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (forward_to_next_line_start): Accept additional argument
2634 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2635 on the newline.
2636 (reseat_at_next_visible_line_start): Use the bidi iterator state
2637 returned by forward_to_next_line_start to restore the state of
2638 it->bidi_it after backing up to previous newline. (Bug#9212)
2639
31011111
AS
26402011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2641
2642 * regex.c (re_comp): Protoize.
2643 (re_exec): Fix return type.
2644 (regexec): Fix type of `ret'. (Bug#9203)
2645
476371c4
PE
26462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2647
e5d76069
PE
2648 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2649 This is needed if max-image-size is a floating-point number.
2650
9a79b20c
AS
26512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2652
2653 * print.c (print_object): Print empty symbol as ##.
2654
2655 * lread.c (read1): Read ## as empty symbol.
2656
d8c2fa78
AA
26572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2658
2659 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2660 setting frame foreground color (Bug#9175).
2661 (x_set_background_color): Likewise.
2662
ffe57a7a
AA
2663 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2664 contents (Bug#9176).
2665 (EmacsTooltip -init): Remove bezels and add shadows to
2666 tooltip windows.
2667
bf3492a5
AA
2668 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2669 or scroll bar (Bug#8470).
2670
d55e9c53
AA
2671 * nsfont.m (nsfont_open): Remove assignment to voffset and
2672 unnecessary vars hshink, expand, hd, full_height, min_height.
2673 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2674
2675 * nsterm.h (nsfont_info): Remove voffset field.
2676
d8c2fa78 26772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2678
2679 Implement strike-through and overline on NextStep (Bug#8863).
2680
2681 * nsfont.m (nsfont_open): Use underline position provided by font,
2682 instead of hard-coded value of 2.
2683 (nsfont_draw): Call ns_draw_text_decoration instead.
2684
2685 * nsterm.h: Add declaration for ns_draw_text_decoration.
2686
2687 * nsterm.m (ns_draw_text_decoration): New function for drawing
2688 underline, overline, and strike-through.
2689 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2690 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2691 accommodate underlining, etc.
4843aac3 2692
4cc60b9b
EZ
26932011-07-28 Eli Zaretskii <eliz@gnu.org>
2694
bc7ece87
EZ
2695 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2696 default.
4cc60b9b 2697
476371c4
PE
26982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2699
66606eea
PE
2700 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2701 Without this fix, if a signal arrives just after memory fills up,
2702 'malloc' might be invoked reentrantly.
2703
476371c4
PE
2704 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2705 In other words, assume that every image size is allowed, on non-X
2706 hosts. This assumption is probably wrong, but it lets Emacs compile.
2707
f3fcc40d
AS
27082011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2709
2710 * regex.c (re_iswctype): Convert return values to boolean.
2711
350c992f
EZ
27122011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2713
2714 * xdisp.c (compute_display_string_pos): Don't use cached display
2715 string position if the buffer had its restriction changed.
2716 (Bug#9184)
2717
5266b4bb
PE
27182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2721
2573a837 27222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2723
41f55ccd 2724 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2725
39e378da
PE
2726 * bidi.c: Integer size and overflow fixes.
2727 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2728 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2729 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2730 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2731 (bidi_find_other_level_edge):
2732 Use ptrdiff_t instead of EMACS_INT where either will do.
2733 This works better on 32-bit hosts configured --with-wide-int.
2734 (bidi_cache_ensure_space): Check for size-calculation overflow.
2735 Use % rather than repeated addition, for better worst-case speed.
2736 Don't set bidi_cache_size until after xrealloc returns, because it
2737 might not return.
2738 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2739 (bidi_cache_ensure_space): Also check that the bidi cache size
2740 does not exceed that of the largest Lisp string or buffer. See Eli
2741 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2742
5e927815
PE
2743 * alloc.c (__malloc_size_t): Remove.
2744 All uses replaced by size_t. See Andreas Schwab's note
2745 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2746
ca4aa935
PE
2747 * image.c: Improve checking for integer overflow.
2748 (check_image_size): Assume that f is nonnull, since
2749 it is always nonnull in practice. This is one less thing to
2750 worry about when checking for integer overflow later.
2751 (x_check_image_size): New function, which checks for integer
2752 overflow issues inside X.
2753 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2754 This removes the need for a memory_full check.
2755 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2756 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2757 (xbm_read_bitmap_data): Change locals back to 'int', since
2758 their values must fit in 'int'.
2759 (xpm_load_image, png_load, tiff_load):
2760 Invoke x_create_x_image_and_pixmap earlier,
2761 to avoid much needless work if the image is too large.
2762 (tiff_load): Treat overly large images as if
2763 x_create_x_image_and_pixmap failed, not as malloc failures.
2764 (gs_load): Use x_check_image_size.
2765
5f8f9cc2
PE
2766 * gtkutil.c: Omit integer casts.
2767 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2768 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2769
5adf60bc
PE
2770 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2771
c8907a93
PE
2772 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2773 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2774 would wrongly return t on a 64-bit host.
2775
e3c25c68
PE
2776 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2777 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2778 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2779 and therefore cause GCC to emit a bogus diagnostic in some cases.
2780
3f791afe
PE
2781 * image.c: Integer signedness and overflow and related fixes.
2782 This is not an exhaustive set of fixes, but it's time to
2783 record what I've got.
2784 (lookup_pixel_color, check_image_size): Remove redundant decls.
2785 (check_image_size): Don't assume that arbitrary EMACS_INT values
2786 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2787 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2788 (tiff_load, imagemagick_load_image):
2789 Check for overflow in size calculations.
2790 (x_create_x_image_and_pixmap): Remove unnecessary test for
2791 xmalloc returning NULL; that can't happen.
2792 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2793 (xpm_color_bucket): Use better integer hashing function.
2794 (xpm_cache_color): Don't possibly over-allocate memory.
2795 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2796 (gif_memory_source):
2797 Use ptrdiff_t, not int or size_t, to record sizes.
2798 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2799 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2800 either works, as we prefer signed integers.
2801 (tiff_read_from_memory, tiff_write_from_memory):
2802 Return tsize_t, not size_t, since that's what the TIFF API wants.
2803 (tiff_read_from_memory): Don't fail simply because the read would
2804 go past EOF; instead, return a short read.
2805 (tiff_load): Omit no-longer-needed casts.
2806 (Fimagemagick_types): Don't assume size fits into 'int'.
2807
3cc5a532
PE
2808 Improve hashing quality when configured --with-wide-int.
2809 * fns.c (hash_string): New function, taken from sxhash_string.
2810 Do not discard information about ASCII character case; this
2811 discarding is no longer needed.
2812 (sxhash-string): Use it. Change sig to match it. Caller changed.
2813 * lisp.h: Declare it.
2814 * lread.c (hash_string): Remove, since we now use fns.c's version.
2815 The fns.c version returns a wider integer if --with-wide-int is
2816 specified, so this should help the quality of the hashing a bit.
2817
b312a492
PE
2818 * emacs.c: Integer overflow minor fix.
2819 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2820 Define only if GNU_LINUX.
2821 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2822
dfd153ae
PE
2823 * dispnew.c: Integer signedness and overflow fixes.
2824 Remove unnecessary forward decls, that were a maintenance hassle.
2825 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2826 All uses changed.
2827 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2828 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2829 (prepare_desired_row, line_draw_cost):
2830 Use int, not unsigned, where either works.
2831 (save_current_matrix, restore_current_matrix):
2832 Use ptrdiff_t, not size_t, where either works.
2833 (init_display): Check for overflow more accurately, and without
2834 relying on undefined behavior.
2835
a81d11a3
PE
2836 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2837 Remove, replacing with the new symbols in lisp.h. All uses changed.
2838 * fileio.c (make_temp_name):
2839 * filelock.c (lock_file_1, lock_file):
2840 * xdisp.c (message_dolog):
2841 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2842 Use pMd etc. instead.
2843 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2844 replacing the pWIDE etc. symbols removed from editfns.c.
2845
3300e6fd
PE
2846 * keyboard.h (num_input_events): Now uintmax_t.
2847 This is (very slightly) less likely to mess up due to wraparound.
2848 All uses changed.
2849
fd05c7e9
PE
2850 * buffer.c: Integer signedness fixes.
2851 (alloc_buffer_text, enlarge_buffer_text):
2852 Use ptrdiff_t rather than size_t when either will do, as we prefer
2853 signed integers.
2854
903fe15d
PE
2855 * alloc.c: Integer signedness and overflow fixes.
2856 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2857 (__malloc_size_t): Default to size_t, not to int.
2858 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2859 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2860 Prefer ptrdiff_t to size_t when either would do, as we prefer
2861 signed integers.
2862 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2863 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2864 Now const. Initialize with values that are in range even if char
2865 is signed.
2866 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2867 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2868 These functions do the right thing with sizes > 2**32.
2869 (check_depth): Now ptrdiff_t, not int.
2870 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2871 Adjust to new way of storing sizes. Check for size overflow bugs
2872 in rest of code.
2873 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2874 slightly wrong anyway, as it missed one instance of
2875 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2876 (refill_memory_reserve): Omit needless cast to size_t.
2877 (mark_object_loop_halt): Mark as externally visible.
2878
ac82cc6a
PE
2879 * xselect.c: Integer signedness and overflow fixes.
2880 (Fx_register_dnd_atom, x_handle_dnd_message):
2881 Use ptrdiff_t, not size_t, since we prefer signed.
2882 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2883 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2884 x_dnd_atoms_size and x_dnd_atoms_length.
2885
c2d1e36d
PE
2886 * doprnt.c: Prefer signed to unsigned when either works.
2887 * eval.c (verror):
2888 * doprnt.c (doprnt):
2889 * lisp.h (doprnt):
2890 * xdisp.c (vmessage):
2891 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2892 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2893 prefer signed arithmetic to avoid comparison confusion.
2894 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2895 but is a bit tricky.
2896
0e926e56
PE
2897 Assume freestanding C89 headers, string.h, stdlib.h.
2898 * data.c, doprnt.c, floatfns.c, print.c:
2899 Include float.h unconditionally.
2900 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2901 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2902 * regex.c: Likewise for stddef.h, string.h.
2903 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2904 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2905 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2906 (STDC_HEADERS): Remove obsolete defines.
2907 * sysdep.c: Include limits.h unconditionally.
2908
9cfdb3ec
PE
2909 Assume support for memcmp, memcpy, memmove, memset.
2910 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2911 * regex.c (memcmp, memcpy):
2912 Remove; we assume C89 now.
2913
2914 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2915 (__malloc_safe_bcopy): Remove; no longer needed.
2916
cf950e6b 2917 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2918 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2919 well either way, and we prefer signed to unsigned.
2920
dbf38e02
LMI
29212011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2922
2923 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2924 closes the connection while we're reading (bug#9182).
2925
d6f0886c 29262011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2927
d6f0886c
JD
2928 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2929 are specified (Bug#9168).
24e0f6b1 2930
2eb1f9e6
PE
29312011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2934 Found by GCC static checking and --with-wide-int on a 32-bit host.
2935
22381272 29362011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2937
2938 * xdisp.c (compute_display_string_pos): Fix logic of caching
2939 previous display string position. Initialize cached_prev_pos to
2940 -1. Fixes slow-down at the beginning of a buffer.
2941
f25e39b4
EZ
29422011-07-24 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2945 for attrs[LFACE_FONTSET_INDEX].
2946
04c4b52e
PE
29472011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 * xml.c (parse_region): Remove unused local
2950 that was recently introduced.
2951
c1734fbd
EZ
29522011-07-23 Eli Zaretskii <eliz@gnu.org>
2953
be18c5a5
EZ
2954 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2955 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2956
c1734fbd
EZ
2957 * xdisp.c (move_it_in_display_line_to): Record the best matching
2958 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2959 exit if none of the characters scanned was an exact match.
2960 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2961 when exact match is impossible due to invisible text, and the
2962 lines are truncated.
2963
a258d627
JD
29642011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2965
2966 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2967 for OSX >= 10.7.
2968
b6d5a689
EZ
29692011-07-22 Eli Zaretskii <eliz@gnu.org>
2970
0f74f785
EZ
2971 Fix a significant slow-down of cursor motion with C-n, C-p,
2972 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2973 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2974 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2975 (next_element_from_buffer): Call compute_stop_pos_backwards to
2976 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2977 base_level_stop.
2978 (reseat): Don't look for prev_stop, as that could mean a very long
2979 run.
2980 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2981 <cached_disp_overlay_modiff>: Cache for last found display string
2982 position.
551918c1 2983 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2984 about the same buffer in the same area of character positions, and
2985 the buffer wasn't changed since the time the display string
2986 position was cached.
551918c1 2987
b2d0c91a
EZ
29882011-07-22 Eli Zaretskii <eliz@gnu.org>
2989
2990 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2991 is an integer, which is important for empty lines. (Bug#9149)
2992
043604ee
CY
29932011-07-22 Chong Yidong <cyd@stupidchicken.com>
2994
2995 * frame.c (Fmodify_frame_parameters): In tty case, update the
2996 default face if necessary (Bug#4238).
2997
da4adb04
CY
29982011-07-21 Chong Yidong <cyd@stupidchicken.com>
2999
3000 * editfns.c (Fstring_to_char): No need to explain what a character
3001 is in the docstring (Bug#6576).
3002
9abd0532
LMI
30032011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3004
3005 * xml.c (parse_region): Make sure we always return a tree.
3006
36881d16
HK
30072011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3008
3009 * xml.c (parse_region): If a document contains only comments,
3010 return that, too.
3011
1e98674d
LMI
30122011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3013
3014 * xml.c (make_dom): Return comments, too.
3015
590bd467
PE
30162011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 Port to OpenBSD.
3019 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3020 and the surrounding thread.
3021 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3022 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3023 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3024 timer goes off.
3025 * s/openbsd.h (BROKEN_SIGIO): Define.
3026 * unexelf.c (unexec) [__OpenBSD__]:
3027 Don't update the .mdebug section of the Alpha COFF symbol table.
3028
f41628b2
LMI
30292011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3030
3031 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3032 (bug#8460).
3033
b59b67c5
PE
30342011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3035
15e3a074
PE
3036 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3037 This fixes some race conditions on the permissions of any newly
3038 created file.
3039
41bed37d
PE
3040 * alloc.c (valid_pointer_p): Use pipe, not open.
3041 This fixes some permissions issues when debugging.
3042
b59b67c5
PE
3043 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3044 If fchown fails to set both uid and gid, try to set just gid,
3045 as that is sometimes allowed. Adjust the file's mode to eliminate
3046 setuid or setgid bits that are inappropriate if fchown fails.
3047
925a6be7
SM
30482011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3049
3050 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3051 to compare Lisp_Objects.
3052 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3053 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3054 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3055
52968808
AS
30562011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3057
0a6a104b
AS
3058 * lread.c (read_integer): Unread even EOF character.
3059 (read1): Likewise. Properly record start position of symbol.
3060
52968808
AS
3061 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3062 symbol character follows.
3063
9e381cdd
PE
30642011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3065
3066 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3067 This works around a problem with the previous change to Fcopy_file.
3068 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3069 and without this change, GCC might complain about discarding
3070 fchown's return value.
3071
b5641435
JB
30722011-07-16 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3075
a8031457
PE
30762011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3079
dd889327
LMI
30802011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3081
750c33f7
LMI
3082 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3083 it's used from the C level.
3084
dd889327
LMI
3085 * process.c: Use the same condition for POLL_FOR_INPUT in both
3086 keyboard.c and process.c (bug#1858).
3087
87e86684
LM
30882011-07-09 Lawrence Mitchell <wence@gmx.li>
3089
3090 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3091 (Fgnutls_boot): Use it.
3092
64348f40
AS
30932011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3094
3095 * doc.c (Fsubstitute_command_keys): Revert last change.
3096
1d698799
LMI
30972011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3098
f863868c
LMI
3099 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3100 quotes the next character, and doesn't affect other longer
3101 sequences (bug#8935).
3102
1d698799
LMI
3103 * lread.c (syms_of_lread): Clarify that is isn't only
3104 `eval-buffer' and `eval-defun' that's affected by
3105 `lexical-binding' (bug#8460).
3106
aa4b6df6
EZ
31072011-07-15 Eli Zaretskii <eliz@gnu.org>
3108
3109 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3110 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3111
5d856da6
PE
31122011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3113
ad6042bb
PE
3114 Fix minor problems found by static checking.
3115 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3116 (elsz): Now a signed constant, not a size_t var. We prefer signed
3117 types to unsigned, to avoid integer comparison confusion. Without
3118 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3119 "cannot optimize loop, the loop counter may overflow", a symptom
3120 of the confusion.
f00bbb22 3121 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3122 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3123
6468f31c
LMI
31242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3125
49080b10
LMI
3126 * search.c (Fre_search_backward): Mention `case-fold-search' in
3127 all the re_search_* functions (bug#8138).
3128
6468f31c
LMI
3129 * keyboard.c (Fopen_dribble_file): Document when the file is
3130 closed (bug#8056).
3131
c965adc5
EZ
31322011-07-14 Eli Zaretskii <eliz@gnu.org>
3133
df9733bf
EZ
3134 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3135 bidi_cache_idx.
3136
0bb23927
EZ
3137 Support bidi reordering of display and overlay strings.
3138 * xdisp.c (compute_display_string_pos)
3139 (compute_display_string_end): Accept additional argument STRING.
3140 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3141 (reseat_to_string): Initialize bidi_it->string.s and
3142 bidi_it->string.schars.
3143 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3144 NULL (avoids a crash in bidi_paragraph_init).
3145 Initialize itb.string.lstring.
0bb23927
EZ
3146 (init_iterator): Call bidi_init_it only of a valid
3147 buffer position was specified. Initialize paragraph_embedding to
3148 L2R.
3149 (reseat_to_string): Initialize the bidi iterator.
3150 (display_string): If we need to ignore text properties of
3151 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3152 original value of -1 will not work with bidi.)
3153 (compute_display_string_pos): First arg is now struct
3154 `text_pos *'; all callers changed. Support display properties on
3155 Lisp strings.
3156 (compute_display_string_end): Support display properties on Lisp
3157 strings.
3158 (init_iterator, reseat_1, reseat_to_string): Initialize the
3159 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3160 when iterating on a string not from display properties).
640c8776
SM
3161 (compute_display_string_pos, compute_display_string_end):
3162 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3163 arrow keys.
3164 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3165 base_level_stop; instead, set base_level_stop to BEGV.
3166 Fixes crashes in vertical-motion.
0bb23927
EZ
3167 (next_element_from_buffer): Improve commentary for when
3168 the iterator is before prev_stop.
3169 (init_iterator): Initialize bidi_p from the default value of
3170 bidi-display-reordering, not from buffer-local value. Use the
3171 buffer-local value only if initializing for buffer iteration.
3172 (handle_invisible_prop): Support invisible properties on strings
3173 that are being bidi-reordered.
3174 (set_iterator_to_next): Support bidi reordering of C strings and
3175 Lisp strings.
3176 (next_element_from_string): Support bidi reordering of Lisp
3177 strings.
3178 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3179 (display_string): Support display of R2L glyph rows.
3180 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3181 (init_iterator): Don't initialize it->bidi_p for strings
3182 here.
3183 (reseat_to_string): Initialize it->bidi_p for strings here.
3184 (next_element_from_string, next_element_from_c_string)
3185 (next_element_from_buffer): Add xassert's for correspondence
3186 between IT's object being iterated and it->bidi_it.string
3187 structure.
3188 (face_before_or_after_it_pos): Support bidi iteration.
3189 (next_element_from_c_string): Handle the case of the first string
3190 character that is not the first one in the visual order.
3191 (get_visually_first_element): New function, refactored from common
3192 parts of next_element_from_buffer, next_element_from_string, and
3193 next_element_from_c_string.
3194 (tool_bar_lines_needed, redisplay_tool_bar)
3195 (display_menu_bar): Force left-to-right direction. Add a FIXME
3196 comment for making that be controlled by a user option.
3197 (push_it, pop_it): Save and restore the state of the
3198 bidi iterator. Save and restore the bidi_p flag.
3199 (pop_it): Iterate out of display property for string iteration as
3200 well.
3201 (iterate_out_of_display_property): Support iteration over strings.
3202 (handle_single_display_spec): Set up it->bidi_it for iteration
3203 over a display string, and call bidi_init_it.
3204 (handle_single_display_spec, next_overlay_string)
3205 (get_overlay_strings_1, push_display_prop): Set up the bidi
3206 iterator for displaying display or overlay strings.
3207 (forward_to_next_line_start): Don't use the shortcut if
3208 bidi-iterating.
3209 (back_to_previous_visible_line_start): If handle_display_prop
3210 pushed the iterator stack, restore the internal state of the bidi
3211 iterator by calling bidi_pop_it same number of times.
3212 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3213 and we are bidi-iterating, don't decrement the iterator position;
3214 instead, set the first_elt flag in the bidi iterator, to produce
3215 the same effect.
3216 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3217 (push_display_prop): xassert that we are iterating a buffer.
3218 (push_it, pop_it): Save and restore paragraph_embedding member.
3219 (handle_single_display_spec, next_overlay_string)
3220 (get_overlay_strings_1, reseat_1, reseat_to_string)
3221 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3222 correctly. Don't assume unibyte strings are not bidi-reordered.
3223 (compute_display_string_pos)
3224 (compute_display_string_end): Fix handling the case of C string.
3225 (push_it, pop_it): Save and restore from_disp_prop_p.
3226 (handle_single_display_spec, push_display_prop): Set the
3227 from_disp_prop_p flag.
3228 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3229 (pop_it): Call iterate_out_of_display_property only if we are
3230 popping after iteration over a string that came from a display
3231 property. Fix a typo in popping stretch info. Add an assertion
3232 for verifying that the iterator position is in sync with the bidi
3233 iterator.
3234 (handle_single_display_spec, get_overlay_strings_1)
3235 (push_display_prop): Fix initialization of paragraph direction for
3236 string when that of the parent object is not yet determined.
3237 (reseat_1): Call bidi_init_it to resync the bidi
3238 iterator with IT's position. (Bug#7616)
3239 (find_row_edges): If ROW->start.pos gives position
3240 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3241 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3242 Reset the from_disp_prop_p flag.
3243 (SAVE_IT, RESTORE_IT): New macros.
3244 (pos_visible_p, face_before_or_after_it_pos)
3245 (back_to_previous_visible_line_start)
3246 (move_it_in_display_line_to, move_it_in_display_line)
3247 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3248 (try_scrolling, redisplay_window, display_line): Use them when
3249 saving a temporary copy of the iterator and restoring it back.
3250 (back_to_previous_visible_line_start, reseat_1)
3251 (init_iterator): Empty the bidi cache "stack".
3252 (move_it_in_display_line_to): If iterator ended up at
3253 EOL, but we never saw any buffer positions smaller than
3254 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3255 motion in bidi-reordered lines.
3256 (move_it_in_display_line_to): Record prev_method and prev_pos
3257 immediately before the call to set_iterator_to_next. Fixes cursor
3258 motion in bidi-reordered lines with stretch glyphs and strings
3259 displayed in margins. (Bug#8133) (Bug#8867)
3260 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3261 TO_CHARPOS.
640c8776
SM
3262 (pos_visible_p): Support positions in bidi-reordered lines.
3263 Save and restore bidi cache.
0bb23927
EZ
3264
3265 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3266 (bidi_paragraph_info): Delete unused struct.
3267 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3268 (bidi_cache_start): New variable.
3269 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3270 to zero.
3271 (bidi_cache_fetch_state, bidi_cache_search)
3272 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3273 (bidi_cache_find, bidi_peek_at_next_level)
3274 (bidi_level_of_next_char, bidi_find_other_level_edge)
3275 (bidi_move_to_visually_next): Compare cache index with
3276 bidi_cache_start rather than with zero.
3277 (bidi_fetch_char): Accept new argument STRING; all callers
3278 changed. Support iteration over a string. Support strings with
3279 display properties. Support unibyte strings. Fix the type of
3280 `len' according to what STRING_CHAR_AND_LENGTH expects.
3281 (bidi_paragraph_init, bidi_resolve_explicit_1)
3282 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3283 (bidi_level_of_next_char, bidi_move_to_visually_next):
3284 Support iteration over a string.
0bb23927
EZ
3285 (bidi_set_sor_type, bidi_resolve_explicit_1)
3286 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3287 can now be zero (for strings); special values 0 and -1 were
3288 changed to -1 and -2, respectively.
3289 (bidi_char_at_pos): New function.
3290 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3291 Call it instead of FETCH_MULTIBYTE_CHAR.
3292 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3293 initialized to valid values.
3294 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3295 values.
3296 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3297 the test for valid cached positions. Fix the logic for looking up
3298 the sentinel state in the cache. GCPRO the Lisp string we are
3299 iterating.
3300 (bidi_push_it, bidi_pop_it): New functions.
3301 (bidi_initialize): Initialize the bidi cache start stack pointer.
3302 (bidi_cache_ensure_space): New function, refactored from part of
3303 bidi_cache_iterator_state. Don't assume the required size is just
3304 one BIDI_CACHE_CHUNK away.
3305 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3306 (bidi_count_bytes, bidi_char_at_pos): New functions.
3307 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3308 always valid if bidi_cache_idx is valid.
3309 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3310 is valid if it's going to be used.
3311 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3312 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3313 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3314 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3315 (bidi_find_other_level_edge, bidi_cache_start_stack):
3316 All variables related to cache indices are now EMACS_INT.
c965adc5 3317
0bb23927
EZ
3318 * dispextern.h (struct bidi_string_data): New structure.
3319 (struct bidi_it): New member `string'. Make flag members be 1-bit
3320 fields, and put them last in the struct.
640c8776
SM
3321 (compute_display_string_pos, compute_display_string_end):
3322 Update prototypes.
0bb23927
EZ
3323 (bidi_push_it, bidi_pop_it): Add prototypes.
3324 (struct iterator_stack_entry): New members bidi_p,
3325 paragraph_embedding, and from_disp_prop_p.
3326 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3327 (bidi_shelve_cache, bidi_unshelve_cache):
3328 Declare prototypes.
0bb23927
EZ
3329
3330 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3331 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3332 and vector-like objects.
3333
3334 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3335 cache around display iteration.
3336
3337 * window.c (Fwindow_end, window_scroll_pixel_based)
3338 (displayed_window_lines, Frecenter): Save and restore the bidi
3339 cache around display iteration.
3340
3bbd2265
LMI
33412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3342
3343 * editfns.c (Fdelete_region): Clarify the use of the named
3344 parameters (bug#6788).
3345
adc47434
MR
33462011-07-14 Martin Rudalics <rudalics@gmx.at>
3347
3348 * indent.c (Fvertical_motion): Set and restore w->pointm when
3349 saving and restoring the window's buffer (Bug#9006).
3350
837c31f8
LMI
33512011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3352
3353 * editfns.c (Fstring_to_char): Clarify just what is returned
3354 (bug#6576). Text by Eli Zaretskii.
3355
ac389d0c
JB
33562011-07-13 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3359
0be0ce47
EZ
33602011-07-13 Eli Zaretskii <eliz@gnu.org>
3361
3362 * buffer.c (mmap_find): Fix a typo.
3363
cd18e7e3
JB
33642011-07-13 Johan Bockgård <bojohan@gnu.org>
3365
3366 Fix execution of x selection hooks.
3367 * xselect.c (Qx_lost_selection_functions)
3368 (Qx_sent_selection_functions): New vars.
3369 (syms_of_xselect): DEFSYM them.
3370 (x_handle_selection_request): Pass Qx_sent_selection_functions
3371 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3372 (x_handle_selection_clear,x_clear_frame_selections):
3373 Pass Qx_lost_selection_functions rather than
3374 Vx_lost_selection_functions to Frun_hook_with_args.
3375
47ea7f44
PE
33762011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3377
ac389d0c 3378 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3379 The old code sometimes used this field without initializing it.
3380
47ea7f44
PE
3381 * alloc.c (gc_sweep): Don't read past end of array.
3382 In theory, the old code could also have corrupted Emacs internals,
3383 though it'd be very unlikely.
3384
bc985c87
AS
33852011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3386
3387 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3388 argument. (Bug#4026)
bc985c87 3389
0cf34688
LMI
33902011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3391
b3dadd76
LMI
3392 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3393 key" (bug#4257).
3394
0cf34688
LMI
3395 * window.c (Fset_window_start): Doc fix (bug#4199).
3396 (Fset_window_hscroll): Ditto.
3397
270768cd
PE
33982011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3399
077e3dda 3400 Fix minor new problems caught by GCC 4.6.1.
270768cd 3401 * term.c (init_tty): Remove unused local.
490011a6 3402 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3403 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3404 not used otherwise.
270768cd 3405
b1f58454
CY
34062011-07-12 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3409
22b9578d
LMI
34102011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3411
6e70ab07
LMI
3412 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3413 are the mini-buffer and the echo area (bug#3320).
3414
22b9578d
LMI
3415 * term.c (init_tty): Remove support for supdup, c10 and perq
3416 terminals, which are no longer supported (bug#1482).
3417
8974cc9f
JB
34182011-07-10 Johan Bockgård <bojohan@gnu.org>
3419
3420 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3421
a560d974
JD
34222011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3423
3424 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3425 for non-popups (Bug#3642).
3426
1dae0f0a
AS
34272011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3428
268c2c36 3429 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3430 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3431 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3432 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3433 * data.c (fmod): Likewise.
3434 * dispnew.c (swap_glyphs_in_rows): Likewise.
3435 * emacs.c (memory_warning_signal): Likewise.
3436 * floatfns.c (float_error): Likewise.
3437 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3438 (otf_open, font_otf_capability, generate_otf_features)
3439 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3440 Likewise.
3441 * image.c (pbm_read_file): Likewise.
3442 * indent.c (string_display_width): Likewise.
3443 * intervals.c (check_for_interval, search_for_interval)
3444 (inc_interval_count, count_intervals, root_interval)
3445 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3446 * lread.c (defalias): Likewise.
268c2c36 3447 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3448 * regex.c (set_image_of_range_1, set_image_of_range)
3449 (regex_grow_registers): Likewise.
3450 * sysdep.c (strerror): Likewise.
3451 * termcap.c (valid_filename_p, tprint, main): Likewise.
3452 * tparam.c (main): Likewise.
3453 * unexhp9k800.c (run_time_remap, save_data_space)
3454 (update_file_ptrs, read_header, write_header, calculate_checksum)
3455 (copy_file, copy_rest, display_header): Likewise.
3456 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3457 Likewise.
3458 * xdisp.c (check_it): Likewise.
3459 * xfaces.c (register_color, unregister_color, unregister_colors):
3460 Likewise.
3461 * xfns.c (print_fontset_result): Likewise.
3462 * xrdb.c (member, fatal, main): Likewise.
3463
99033785
PE
34642011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 Fix minor problems found by static checking (Bug#9031).
3467 * chartab.c (char_table_set_range, map_sub_char_table):
3468 Remove unused locals.
3469 (uniprop_table): Now static.
3470 * composite.c (_work_char): Remove unused static var.
3471
9cb2ac56
JB
34722011-07-09 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3475
f25661f0
JD
34762011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3477
3478 * gtkutil.c (qttip_cb): Remove code without function.
3479
8278c4fe
EZ
34802011-07-09 Eli Zaretskii <eliz@gnu.org>
3481
3482 * w32.c (pthread_sigmask): New stub.
3483
1692ae2d 34842011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3485
8a6ebd58 3486 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3487 sigprocmask is portable only for single-threaded applications, and
3488 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3489 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3490 (LIBES): Use it.
3491 * callproc.c (Fcall_process):
3492 * process.c (create_process):
3493 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3494 Use pthread_sigmask, not sigprocmask.
123403e4 3495
1b854618
JD
34962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3497
3498 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3499 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3500 wrong (Bug#8591).
3501
3fe4b549
JD
35022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3503
0ce7e563
JD
3504 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3505 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3506 (xg_hide_tooltip): Fix comment.
3507
3fe4b549
JD
3508 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3509 in registerServicesMenuSendTypes.
3510 (validRequestorForSendType): Don't check ns_return_types.
3511
3512 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3513 ns_return_type.
3514
5df75e47
JR
35152011-07-08 Jason Rumney <jasonr@gnu.org>
3516
22610910
JR
3517 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3518 SH_SHOW for hidden windows (Bug#5482).
3519
5df75e47
JR
3520 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3521 frame struct members of non-existent frames (Bug#6284).
3522
699c10bd
JD
35232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3524
4393663b
JD
3525 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3526 variable firstTime not needed on OSX >= 10.6.
3527 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3528 >= 10.5. Use setKnobProportion, setDoubleValue.
3529
3530 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3531 (MAC_OS_X_VERSION_10_5): Define if not defined.
3532 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3533 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3534 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3535
3536 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3537 cString and lossyCString on OSX >= 10.4
3538
58179cce 3539 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3540 sizeToFit on OSX >= 10.2.
3541
3542 * nsimage.m (allocInitFromFile): Don't use deprecated method
3543 bestRepresentationForDevice on OSX >= 10.6.
3544
3545 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3546 to avoid warning.
3547
3548 * emacs.c: Declare unexec_init_emacs_zone.
3549
a63e0781
JD
3550 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3551
699c10bd
JD
3552 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3553
3554 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3555 on svcsMenu (Bug#8842).
3556
3557 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3558 ns_return_types.
3559 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3560
3561 * nsterm.m (QUTF8_STRING): Declare.
3562 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3563 (validRequestorForSendType): Return type is (id).
3564 Change indexOfObjectIdenticalTo to indexOfObject.
3565 Check if we have local selection before returning self (Bug#8842).
3566 (writeSelectionToPasteboard): Put local selection into paste board
3567 if we have a local selection (Bug#8842).
3568 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3569
3570 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3571 (ns_get_local_selection): Declare.
3572
54e10184
LMI
35732011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3574
9888ff71
LMI
3575 * keymap.c (describe_map_tree): Don't insert a double newline at
3576 the end of the buffer (bug#1169) and return whether we inserted
3577 something.
3578
54e10184
LMI
3579 * callint.c (Fcall_interactively): Change "reading args" to
3580 "providing args" to try to clarify what it does (bug#1010).
3581
15fa4783
KH
35822011-07-07 Kenichi Handa <handa@m17n.org>
3583
3584 * composite.c (composition_compute_stop_pos): Ignore a static
3585 composition starting before CHARPOS (Bug#8915).
3586
3587 * xdisp.c (handle_composition_prop): Likewise.
3588
a8815b00
EZ
35892011-07-07 Eli Zaretskii <eliz@gnu.org>
3590
3591 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3592 (Bug#9015)
3593
ef7b981d 35942011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3595
3596 * character.h (unicode_category_t): New enum type.
3597
3598 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3599 (Qchar_code_property_table): New variable.
3600 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3601 (UNIPROP_COMPRESSED_FORM_P): New macros.
3602 (char_table_ascii): Uncompress the compressed values.
3603 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3604 Uncompress the compressed values.
ac389d0c 3605 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3606 (char_table_ref_and_range): Uncompress the compressed values.
3607 (sub_char_table_set): New arg is_uniprop. Callers changed.
3608 Uncompress the compressed values.
3609 (sub_char_table_set_range): Args changed. Callers changed.
3610 (char_table_set_range): Adjuted for the above change.
3611 (map_sub_char_table): Delete args default_val and parent. Add arg
3612 top. Give decoded values to a Lisp function.
640c8776 3613 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3614 values to a Lisp function. Gcpro more variables.
3615 (uniprop_table_uncompress)
3616 (uniprop_decode_value_run_length): New functions.
3617 (uniprop_decoder, uniprop_decoder_count): New variables.
3618 (uniprop_get_decoder, uniprop_encode_value_character)
3619 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3620 New functions.
3621 (uniprop_encoder, uniprop_encoder_count): New variables.
3622 (uniprop_get_encoder, uniprop_table)
3623 (Funicode_property_table_internal, Fget_unicode_property_internal)
3624 (Fput_unicode_property_internal): New functions.
3625 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3626 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3627 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3628 char-code-property-alist.
3629
640c8776 3630 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3631 Vunicode_category_table.
3632
640c8776 3633 * font.c (font_range): Adjust for the change of
c805dec0
KH
3634 Vunicode_category_table.
3635
76b397fb
DN
36362011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3637
3638 * m/iris4d.h: Remove file, move contents ...
3639 * s/irix6-5.h: ... here.
3640
22b4128e
PE
36412011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3644 * alloc.c (mark_buffer):
3645 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3646 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3647 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3648 This isn't true in general, and it's particularly not true
3649 if Emacs is configured with --with-wide-int.
3650 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3651 New macros, used in the buffer.c change.
3652
869795d6
JD
36532011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3654
3655 * xsettings.c: Use both GConf and GSettings if both are available.
3656 (store_config_changed_event): Add comment.
3657 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3658 (store_tool_bar_style_changed): New functions.
5e617bc2 3659 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3660 (struct xsettings): Move font inside HAVE_XFT.
3661 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3662 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3663 Move inside HAVE_XFT.
640c8776 3664 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3665 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3666 also.
3667 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3668 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3669 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3670 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3671 (parse_settings): Move check for font inside HAVE_XFT.
3672 (read_settings, apply_xft_settings): Add comment.
3673 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3674 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3675 call store_font_name_changed.
3676 (xft_settings_event): Add comment.
3677 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3678 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3679 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3680 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3681 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3682 (xsettings_get_system_font, xsettings_get_system_normal_font):
3683 Add comment.
869795d6 3684
d8ed26bd
PE
36852011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 Random fixes. E.g., (random) never returned negative values.
3688 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3689 subseconds part to the entropy, as that's a bit more random.
3690 Prefer signed to unsigned, since the signedness doesn't matter and
3691 in general we prefer signed. When given a limit, use a
3692 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3693 latter isn't right if USE_2_TAGS_FOR_INTS.
3694 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3695 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3696
cabf1cac
SM
36972011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3698
3699 * textprop.c (text_property_stickiness):
3700 Obey Vtext_property_default_nonsticky.
3701 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3702 * w32fns.c (syms_of_w32fns):
3703 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3704
6e9b2be9
PE
37052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3708 This is more efficient than Ffile_directory_p and avoids a minor race.
3709
90186c68
LMI
37102011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3711
7c301272
LMI
3712 * buffer.c (Foverlay_put): Say what the return value is
3713 (bug#7835).
3714
c4f2d8d4
LMI
3715 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3716 is a directory before asking whether to use the file name
3717 (bug#7564).
ad637907
LMI
3718 (barf_or_query_if_file_exists): Make the "File is a directory"
3719 error be more correct.
c4f2d8d4 3720
90186c68
LMI
3721 * fns.c (Frequire): Remove the mention of the .gz files, since
3722 that's installation-specific, but keep the mention of
3723 `get-load-suffixes'.
3724
da64016e
PE
37252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3728 Report string overflow if the output is too long.
3729
7d47b580
JB
37302011-07-04 Juanma Barranquero <lekktu@gmail.com>
3731
a555cb87
JB
3732 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3733 (syms_of_gnutls): Remove duplicate DEFSYM for
3734 Qgnutls_bootprop_verify_hostname_error, an error for
3735 Qgnutls_bootprop_verify_error (which is no longer used).
3736
7d47b580
JB
3737 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3738 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3739 Also (re)move comments that are misplaced or no longer relevant.
3740
1e49bfab
LMI
37412011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3742
3743 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3744
1485f4c0
CY
37452011-07-03 Chong Yidong <cyd@stupidchicken.com>
3746
3747 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3748 and background color parameters if they have been changed.
3749
a9ab721e
LMI
37502011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3751
3752 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3753
cf7cff57
PE
37542011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3755
2e13213d
PE
3756 * xsettings.c (SYSTEM_FONT): Define only when used.
3757 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3758
cf7cff57
PE
3759 * keymap.c (access_keymap_1): Now static.
3760
7a8e04f7
CY
37612011-07-02 Chong Yidong <cyd@stupidchicken.com>
3762
3763 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3764 leave any prefix arg for the up event (Bug#1586).
3765
61352f62
LMI
37662011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3767
69bb1ef7
LMI
3768 * lread.c (syms_of_lread): Mention single symbols defined by
3769 `defvar' or `defconst' (bug#7154).
3770
61352f62 3771 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3772 (Frequire): Mention get-load-suffixes.
61352f62 3773
28545e04
MR
37742011-07-02 Martin Rudalics <rudalics@gmx.at>
3775
3776 * window.h (window): Remove clone_number slot.
3777 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3778 Remove.
3779 (make_parent_window, make_window, saved_window)
3780 (Fset_window_configuration, save_window_save): Don't deal with
3781 clone numbers.
3782 * buffer.c (Qclone_number): Remove declaration.
3783 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3784
3349e122
SM
37852011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 Add multiple inheritance to keymaps.
3788 * keymap.c (Fmake_composed_keymap): New function.
3789 (Fset_keymap_parent): Simplify.
3790 (fix_submap_inheritance): Remove.
3791 (access_keymap_1): New function extracted from access_keymap to handle
3792 embedded parents and handle lists of maps.
3793 (access_keymap): Use it.
3794 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3795 (Fcopy_keymap): Handle embedded parents.
3796 (Fcommand_remapping, define_as_prefix): Simplify.
3797 (Fkey_binding): Simplify.
3798 (syms_of_keymap): Move minibuffer-local-completion-map,
3799 minibuffer-local-filename-completion-map,
3800 minibuffer-local-must-match-map, and
3801 minibuffer-local-filename-must-match-map to Elisp.
3802 (syms_of_keymap): Defsubr make-composed-keymap.
3803 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3804 (parse_menu_item): Trivial simplification.
3805
3279eb87
GM
38062011-07-01 Glenn Morris <rgm@gnu.org>
3807
3808 * Makefile.in (SETTINGS_LIBS): Fix typo.
3809
4550efdf
KI
38102011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3811
3812 * coding.c (Fencode_coding_string): Record the last coding system
3813 used, as the function doc string says (bug#8738).
3814
0949d2b6
JD
38152011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3816
3817 * xsettings.c (store_monospaced_changed): Take new font as arg and
3818 check for change against current_mono_font.
3819 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3820 (emacs_settings_constructor, emacs_settings_get_property)
3821 (emacs_settings_set_property, emacs_settings_class_init)
3822 (emacs_settings_init, gsettings_obj): Remove.
3823 (something_changedCB): New function for HAVE_GSETTINGS.
3824 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3825 with value as argument.
3826 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3827 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3828 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3829 "changed".
3830
3831 * xgselect.c: Add defined (HAVE_GSETTINGS).
3832 (xgselect_initialize): Ditto.
3833
3834 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3835 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3836 xg_select.
3837
bbc6b304
PE
38382011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3839
3840 * eval.c (struct backtrace): Simplify and port the data structure.
3841 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3842 signed bit field, as this assumption is not portable and it makes
3843 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3844 "char debug_on_exit : 1" as this is not portable either; instead,
3845 use the portable "unsigned int debug_on_exit : 1". Remove unused
3846 member evalargs. Remove obsolete comments about cc bombing out.
3847
9851bfc5
JD
38482011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3849
51bb811f 3850 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3851 Let HAVE_GSETTINGS override HAVE_GCONF.
3852 (store_monospaced_changed): New function.
3853 (EMACS_SETTINGS): A new type derived from GObject to handle
3854 GSettings notifications.
3855 (emacs_settings_constructor, emacs_settings_get_property)
3856 (emacs_settings_set_property, emacs_settings_class_init):
3857 New functions.
3858 (gsettings_client, gsettings_obj): New variables.
3859 (GSETTINGS_SCHEMA): New define.
3860 (something_changedCB): Call store_monospaced_changed.
3861 (init_gsettings): New function.
3862 (xsettings_initialize): Call init_gsettings.
3863 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3864 to NULL.
3865
640c8776 3866 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3867 GCONF_CFLAGS/LIBS.
3868
5386012d
MR
38692011-06-29 Martin Rudalics <rudalics@gmx.at>
3870
3871 * window.c (resize_root_window, grow_mini_window)
3872 (shrink_mini_window): Rename Qresize_root_window to
3873 Qwindow_resize_root_window and Qresize_root_window_vertically to
3874 Qwindow_resize_root_window_vertically.
3875
f13e0b08
PE
38762011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3879
94515237
JB
38802011-06-27 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * makefile.w32-in: Redesign dependencies so they reflect more
3883 clearly which files are directly included by each source file,
3884 and not through other includes.
3885
e43b6e43
MR
38862011-06-27 Martin Rudalics <rudalics@gmx.at>
3887
3888 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3889 (sort_overlays, overlay_strings): When an overlay's clone number
3890 matches the window's clone number process the overlay even if
3891 the overlay's window property doesn't match the current window.
3892
d68443dc
MR
3893 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3894 (Fwindow_hchild): Rename to Fwindow_left_child.
3895 (Fwindow_next): Rename to Fwindow_next_sibling.
3896 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3897 (resize_window_check): Rename to window_resize_check.
3898 (resize_window_apply): Rename to window_resize_apply.
3899 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3900 (Fdelete_other_windows_internal, resize_frame_windows)
3901 (Fsplit_window_internal, Fdelete_window_internal)
3902 (grow_mini_window, shrink_mini_window)
3903 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3904
c7e73be5
JD
39052011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3906
3907 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3908 (emacs_fixed_set_min_size): Remove.
3909 (emacs_fixed_new): Take frame as argument.
3910
3911 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3912 (_EmacsFixedPrivate): Remove minwidth/height.
3913 Add struct frame *f.
3914 (emacs_fixed_init): Initialize priv->f.
3915 (get_parent_class, emacs_fixed_set_min_size): Remove.
3916 (emacs_fixed_new): Set priv->f to argument.
3917 (emacs_fixed_get_preferred_width)
3918 (emacs_fixed_get_preferred_height): Use min_width/height from
3919 frames size_hint to set minimum and natural (Bug#8919).
3920 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3921 and use min_width/height from frames size_hint to set
3922 min_width/height (Bug#8919).
3923
3924 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3925 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3926 Fix indentation.
c7e73be5 3927
cf99dcf8
EZ
39282011-06-26 Eli Zaretskii <eliz@gnu.org>
3929
3930 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3931 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3932 called at ZV.
3933
029529ac
CY
39342011-06-26 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * process.c (wait_reading_process_output): Bypass select if
3937 waiting for a cell while ignoring keyboard input, and input is
3938 pending. Suggested by Jan Djärv (Bug#8869).
3939
7a7ef429
PE
39402011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Use gnulib's dup2 module instead of rolling our own.
3943 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3944
11fdef7d 39452011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3946
3947 * dispnew.c (scrolling_window): Before scrolling, turn off a
3948 mouse-highlight in the window being scrolled.
3949
cd3520a4
JB
39502011-06-24 Juanma Barranquero <lekktu@gmail.com>
3951
3952 Move DEFSYM to lisp.h and use everywhere.
3953
3954 * character.h (DEFSYM): Move declaration...
3955 * lisp.h (DEFSYM): ...here.
3956
3957 * gnutls.c:
3958 * minibuf.c:
3959 * w32menu.c:
3960 * w32proc.c:
3961 * w32select.c: Don't include character.h.
3962
3963 * alloc.c (syms_of_alloc):
3964 * buffer.c (syms_of_buffer):
3965 * bytecode.c (syms_of_bytecode):
3966 * callint.c (syms_of_callint):
3967 * casefiddle.c (syms_of_casefiddle):
3968 * casetab.c (init_casetab_once):
3969 * category.c (init_category_once, syms_of_category):
3970 * ccl.c (syms_of_ccl):
3971 * cmds.c (syms_of_cmds):
3972 * composite.c (syms_of_composite):
3973 * dbusbind.c (syms_of_dbusbind):
3974 * dired.c (syms_of_dired):
3975 * dispnew.c (syms_of_display):
3976 * doc.c (syms_of_doc):
3977 * editfns.c (syms_of_editfns):
3978 * emacs.c (syms_of_emacs):
3979 * eval.c (syms_of_eval):
3980 * fileio.c (syms_of_fileio):
3981 * fns.c (syms_of_fns):
3982 * frame.c (syms_of_frame):
3983 * fringe.c (syms_of_fringe):
3984 * insdel.c (syms_of_insdel):
3985 * keymap.c (syms_of_keymap):
3986 * lread.c (init_obarray, syms_of_lread):
3987 * macros.c (syms_of_macros):
3988 * msdos.c (syms_of_msdos):
3989 * print.c (syms_of_print):
3990 * process.c (syms_of_process):
3991 * search.c (syms_of_search):
3992 * sound.c (syms_of_sound):
3993 * syntax.c (init_syntax_once, syms_of_syntax):
3994 * terminal.c (syms_of_terminal):
3995 * textprop.c (syms_of_textprop):
3996 * undo.c (syms_of_undo):
3997 * w32.c (globals_of_w32):
3998 * window.c (syms_of_window):
3999 * xdisp.c (syms_of_xdisp):
4000 * xfaces.c (syms_of_xfaces):
4001 * xfns.c (syms_of_xfns):
4002 * xmenu.c (syms_of_xmenu):
4003 * xsettings.c (syms_of_xsettings):
4004 * xterm.c (syms_of_xterm): Use DEFSYM.
4005
4228cf16
TZ
40062011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4007
cd3520a4 4008 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4009
7fcccf1e
PE
40102011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4011
7efb4e0e
PE
4012 Integer and buffer overflow fixes (Bug#8873).
4013
ff5844ad
PE
4014 * print.c (printchar, strout): Check for string overflow.
4015 (PRINTPREPARE, printchar, strout):
4016 Don't set size unless allocation succeeds.
4017
90532f02
PE
4018 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4019 for sizes. Check for string overflow more accurately.
4020 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4021
6d84508d
PE
4022 * macros.c: Integer and buffer overflow fixes.
4023 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4024 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4025 Use ptrdiff_t, not int, for sizes.
4026 Don't increment bufsize until after realloc succeeds.
4027 Check for size-calculation overflow.
4028 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4029
437b2cb4
PE
4030 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4031
8b9ac8b4
PE
4032 * lread.c: Integer overflow fixes.
4033 (read_integer): Radix is now EMACS_INT, not int,
4034 to improve quality of diagnostics for out-of-range radices.
4035 Calculate buffer size correctly for out-of-range radices.
4036 (read1): Check for integer overflow in radices, and in
4037 read-circle numbers.
82cb60d3
PE
4038 (read_escape): Avoid int overflow.
4039 (Fload, openp, read_buffer_size, read1)
4040 (substitute_object_recurse, read_vector, read_list, map_obarray):
4041 Use ptrdiff_t, not int, for sizes.
4042 (read1): Use EMACS_INT, not int, for sizes.
20270765 4043 Check for size overflow.
8b9ac8b4 4044
7fcccf1e
PE
4045 * image.c (cache_image): Check for size arithmetic overflow.
4046
bfbbd7e7
PE
4047 * lread.c: Integer overflow issues.
4048 (saved_doc_string_size, saved_doc_string_length)
4049 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4050 Now ptrdiff_t, not int.
4051 (read1): Don't assume doc string length fits in int. Check for
4052 out-of-range doc string lengths.
4053 (read_list): Don't assume file position fits in int.
39019e54 4054 (read_escape): Check for hex character overflow.
bfbbd7e7 4055
4e323265
LL
40562011-06-22 Leo Liu <sdl.web@gmail.com>
4057
4058 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4059 Move to minibuffer.el.
4060
85fece3e
PE
40612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4062
20b84ce9 4063 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4064 The following patches are for when GLYPH_DEBUG && !XASSERT.
4065 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4066 * dispnew.c (flush_stdout):
4067 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4068 Mark as externally visible.
4069 * dispnew.c (check_window_matrix_pointers): Now static.
4070 * dispnew.c (window_to_frame_vpos):
4071 * xfns.c (unwind_create_frame):
4072 * xterm.c (x_check_font): Remove unused local.
4073 * scroll.c (CHECK_BOUNDS):
4074 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4075 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4076 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4077 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4078 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4079 Now static.
4080 (debug_method_add): Use va_list and vsprintf rather than relying
4081 on undefined behavior with wrong number of arguments.
4082 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4083 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4084 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4085 since we're not interested in debugging glyphs with old libraries.
4086 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4087 GCC 4.6.0's static checking.
4088
0766b489
PE
40892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4090
31fd4b32
PE
4091 Integer overflow and signedness fixes (Bug#8873).
4092 A few related buffer overrun fixes, too.
4093
b79e8648
PE
4094 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4095
0766b489
PE
4096 * dispextern.h (struct face.stipple):
4097 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4098 (x_bitmap_mask, x_allocate_bitmap_record)
4099 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4100 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4101 (x_create_bitmap_from_xpm_data):
4102 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4103 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4104 (.bitmaps_last):
4105 * xfaces.c (load_pixmap):
4106 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4107 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4108 (.bitmaps_last, struct x_output.icon_bitmap):
4109 Use ptrdiff_t, not int, for bitmap indexes.
4110 (x_allocate_bitmap_record): Check for size overflow.
4111 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4112
b081724f
PE
4113 Use ptrdiff_t, not int, for overlay counts.
4114 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4115 * editfns.c (overlays_around, get_pos_property):
4116 * textprop.c (get_char_property_and_overlay):
4117 * xdisp.c (next_overlay_change, note_mouse_highlight):
4118 * xfaces.c (face_at_buffer_position):
21514da7
PE
4119 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4120 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4121 (Fnext_overlay_change, Fprevious_overlay_change)
4122 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4123 Use ptrdiff_t, not int, for sizes.
21514da7 4124 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4125
3de73e5e
PE
4126 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4127
2606c57b
PE
4128 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4129 (x_session_initialize): Do not assume string length fits in int.
4130
aaafe47a
PE
4131 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4132 This is unlikely, but can occur if DPI is outlandish.
4133
2674ddc8 4134 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4135 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4136
28154962
PE
4137 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4138 * xrdb.c (magic_file_p, search_magic_path):
4139 Omit last arg SUFFIX; it was always 0. All callers changed.
4140 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4141
7de51af5
PE
4142 * xfont.c (xfont_match): Avoid need for strlen.
4143
25ed6cc3
PE
4144 * xfns.c: Don't assume strlen fits in int.
4145 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4146
4eab31dd
PE
4147 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4148 not unsigned long, as we prefer signed integers. All callers changed.
4149 Detect integer overflow in repeat count.
4150 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4151 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4152
171e2a58
PE
4153 * termcap.c: Don't assume sizes fit in int and never overflow.
4154 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4155 (gobble_line): Check for size-calculation overflow.
4156
ad39faca 4157 * minibuf.c (Fread_buffer):
6e5bb2dc 4158 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4159 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4160 Don't assume string length fits in int.
4161
52c61c22 4162 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4163 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4164
b5b8c9e5
PE
4165 * font.c: Don't assume string length fits in int.
4166 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4167 Use ptrdiff_t, not int.
ccd6111c
PE
4168 (font_intern_prop): Don't assume string length fits in int.
4169 Don't assume integer property fits in fixnum.
4170 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4171
882f0d81 4172 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4173 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4174 Reformulate so as not to need the command string.
4175 Invoke gzip -cd rather than gunzip, as it's more portable.
4176 (lock_info_type, lock_file_1, lock_file):
4177 Don't assume pid_t and time_t fit in unsigned long.
4178 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4179 (current_lock_owner): Prefer signed type for sizes.
4180 Use memcpy, not strncpy, where memcpy is what is really wanted.
4181 Don't assume (via atoi) that time_t and pid_t fit in int.
4182 Check for time_t and/or pid_t out of range, e.g., via a network share.
4183 Don't alloca where an auto var works fine.
4184
93f4cf88
PE
4185 * fileio.c: Fix some integer overflow issues.
4186 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4187 Don't assume string length fits in int.
4188 (directory_file_name): Don't assume string length fits in long.
4189 (make_temp_name): Don't assume pid fits in int, or that its print
4190 length is less than 20.
4191
f3e92b69
PE
4192 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4193
1bfdaf10
PE
4194 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4195
35016e9a
PE
4196 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4197
3d1e65a1
PE
4198 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4199 We prefer signed integers, even for size calculations.
4200
0b963a93
PE
4201 * emacs.c: Don't assume string length fits in 'int'.
4202 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4203 (main): Don't invoke strlen when not needed.
4204
573f4b54
PE
4205 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4206 (XD_DEBUG_MESSAGE): Don't waste a byte.
4207
989f33ba
PE
4208 * callproc.c (getenv_internal_1, getenv_internal)
4209 (Fgetenv_internal):
965d34eb
PE
4210 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4211
e4d29b33
PE
4212 * lread.c (invalid_syntax): Omit length argument.
4213 All uses changed. This doesn't fix a bug, but it simplifies the
4214 code away from its former Hollerith-constant appearance, and it's
4215 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4216 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4217
eb49b136
PE
4218 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4219 This didn't break anything, but it didn't help either.
4220 It's confusing to put a bogus integer in a place where the actual
4221 value does not matter.
9f62aeb1 4222 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4223 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4224
15375a22
PE
4225 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4226 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4227 implementation.
b61cc01c
PE
4228 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4229 We prefer signed types, and the value cannot exceed the EMACS_INT
4230 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4231 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4232 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4233 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4234
53b2623d
PE
4235 * indent.c (sane_tab_width): New function.
4236 (current_column, scan_for_column, Findent_to, position_indentation)
4237 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4238 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4239
51cab52b 4240 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4241
f2ed8a70
PE
4242 * lisp.h (lint_assume): New macro.
4243 * composite.c (composition_gstring_put_cache):
4244 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4245
abe80cc6
PE
4246 * editfns.c, insdel.c:
4247 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4248
b02c740e
PE
4249 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4250
ebc96716
PE
4251 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4252
b4e50fa0 4253 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4254 Use much-faster test for byte-length change.
311d5d7c 4255 Don't assume string byte-length fits in 'int'.
a4cf38e4 4256 Check that character arg fits in 'int'.
85461888 4257 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4258
c0c1ee9f
PE
4259 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4260
a498d7f4
PE
4261 * fns.c (concat): Catch string overflow earlier.
4262 Do not rely on integer wraparound.
4263
51cab52b
PE
4264 * dispextern.h (struct it.overlay_strings_charpos)
4265 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4266 * xdisp.c (forward_to_next_line_start)
4267 (back_to_previous_visible_line_start)
4268 (reseat_at_next_visible_line_start, next_element_from_buffer):
4269 Don't arbitrarily truncate the value of 'selective' to int.
4270
76031fad
PE
4271 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4272
5eb55db9
PE
4273 * composite.c: Don't truncate sizes to 'int'.
4274 (composition_gstring_p, composition_reseat_it)
4275 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4276 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4277 not EMACS_UINT, for indexes.
5eb55db9 4278
0703a717
PE
4279 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4280
d6202519
PE
4281 * buffer.c: Include <verify.h>.
4282 (struct sortvec.priority, struct sortstr.priority):
8961a454 4283 Now EMACS_INT, not int.
c20998a7 4284 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4285 (struct sortstr.size, record_overlay_string)
4286 (struct sortstrlist.size, struct sortlist.used):
4287 Don't truncate size to int.
4288 (record_overlay_string): Check for size-calculation overflow.
d6202519 4289 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4290
d5a19415
JM
42912011-06-22 Jim Meyering <meyering@redhat.com>
4292
029529ac 4293 Don't leak an XBM-image-sized buffer
d5a19415
JM
4294 * image.c (xbm_load): Free the image buffer after using it.
4295
a9041e6c
PE
42962011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 Port to Sun C.
4299 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4300 that Sun C diagnosed.
4301 * fns.c (secure_hash): Fix pointer signedness issue.
4302 * intervals.c (static_offset_intervals): New function.
4303 (offset_intervals): Use it.
4304
7f3f739f
LL
43052011-06-21 Leo Liu <sdl.web@gmail.com>
4306
4307 * deps.mk (fns.o):
4308 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4309 sha512.h.
4310
4311 * fns.c (secure_hash): Rename from crypto_hash_function and change
4312 the first arg to accept symbols.
5b66d427 4313 (Fsecure_hash): New primitive.
7f3f739f
LL
4314 (syms_of_fns): New symbols.
4315
76147d94
DD
43162011-06-20 Deniz Dogan <deniz@dogan.se>
4317
4318 * process.c (Fset_process_buffer): Clarify return value in
4319 docstring.
4320
7d7d0045
CY
43212011-06-18 Chong Yidong <cyd@stupidchicken.com>
4322
4323 * dispnew.c (add_window_display_history): Use BVAR.
4324
4325 * xdisp.c (debug_method_add): Use BVAR.
4326 (check_window_end, dump_glyph_matrix, dump_glyph)
4327 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4328
4329 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4330 Likewise.
4331
4332 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4333 check till after the cache is created in init_frame_faces.
4334
ff2bc410
SM
43352011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4336
4337 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4338
28177add
PE
43392011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4340
dd3482fe
PE
4341 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4342 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4343 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4344
393d71f3 4345 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4346 * fileio.c (Finsert_file_contents):
4347 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4348 Remove the old (too-loose) buffer overflow checks.
4349 They weren't needed, since make_gap checks for buffer overflow.
4350 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4351 The old code merely checked for Emacs fixnum overflow, and relied
4352 on undefined (wraparound) behavior. The new code avoids undefined
4353 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4354
2e6813b0 4355 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4356 Tune. Don't use wider integers than needed. Don't use alloca.
4357 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4358
599a9e4f
PE
4359 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4360
99561444
PE
4361 * insdel.c, lisp.h (buffer_overflow): New function.
4362 (insert_from_buffer_1, replace_range, replace_range_2):
4363 * insdel.c (make_gap_larger):
4364 * editfns.c (Finsert_char):
4365 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4366
28177add
PE
4367 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4368
e69dafad
PE
43692011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4370
a7af7fde 4371 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4372
b1c46f02
PE
4373 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4374 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4375
e69dafad
PE
4376 * fileio.c: Don't assume EMACS_INT fits in off_t.
4377 (emacs_lseek): New static function.
4378 (Finsert_file_contents, Fwrite_region): Use it.
4379 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4380
566684ea
PE
4381 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4382
e6966cd6
PE
4383 * fns.c: Don't overflow int when computing a list length.
4384 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4385 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4386 truncation on 64-bit hosts. Check for QUIT every
4387 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4388 faster and is responsive enough.
4389 (Flength): Report an error instead of overflowing an integer.
4390 (Fsafe_length): Return a float if the value is not representable
4391 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4392 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4393 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4394
dd0b0efb
PE
4395 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4396 (header_size, word_size): New constants.
4397 (allocate_vectorlike): Don't check size overflow here.
4398 (allocate_vector): Check it here instead, since this is the only
4399 caller of allocate_vectorlike that could cause overflow.
4400 Check that the new vector's length is representable as a fixnum.
4401
86fe5cfe
PE
4402 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4403 The previous code was bogus. For example, next_almost_prime (32)
4404 returned 39, which is undesirable as it is a multiple of 3; and
4405 next_almost_prime (24) returned 25, which is a multiple of 5 so
4406 why was the code bothering to check for multiples of 7?
4407
80e88859
PE
4408 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4409
4a2f0ad6
PE
4410 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4411
f66c7cf8
PE
4412 Variadic C functions now count arguments with ptrdiff_t.
4413 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4414 Back then I didn't know that the Emacs coding style prefers signed int.
4415 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4416 were being counted with int, which may truncate counts on 64-bit
4417 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4418 * lisp.h (struct Lisp_Subr.function.aMANY)
4419 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4420 Arg counts are now ptrdiff_t, not size_t.
4421 All variadic functions and their callers changed accordingly.
4422 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4423 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4424 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4425 * callint.c (Fcall_interactively): Check arg count for overflow,
4426 to avoid potential buffer overrun. Use signed char, not 'int',
4427 for 'varies' array, so that we needn't bother to check its size
4428 calculation for overflow.
4429 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4430 * eval.c (apply_lambda):
4431 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4432 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4433 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4434
a1759b76
PE
4435 * callint.c (Fcall_interactively): Don't use index var as event count.
4436
d96be9fc
PE
4437 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4438 * mem-limits.h (SIZE): Remove; no longer used.
4439
a690a978 4440 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4441
578c21e6
PE
4442 Remove unnecessary casts.
4443 * xterm.c (x_term_init):
4444 * xfns.c (x_set_border_pixel):
4445 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4446 These aren't needed now that we assume ANSI C.
4447
96f53c6c
PE
4448 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4449 It's more likely to cause problems (due to unsigned overflow)
4450 than to cure them.
4451
83c77d31
PE
4452 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4453
ee2079f1
PE
4454 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4455
6da65536
PE
4456 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4457
7147c4a4
PE
4458 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4459
193e32d9
PE
4460 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4461
e5533da6
PE
4462 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4463
9910e595
PE
4464 GLYPH_CODE_FACE returns EMACS_INT, not int.
4465 * dispextern.h (merge_faces):
4466 * xfaces.c (merge_faces):
01103c44
PE
4467 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4468 Don't assume EMACS_INT fits in int.
9910e595 4469
2638320e
PE
4470 * character.h (CHAR_VALID_P): Remove unused parameter.
4471 * fontset.c, lisp.h, xdisp.c: All uses changed.
4472
045eb8d9
PE
4473 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4474
c1f134b5
PE
4475 * fns.c (concat): Minor tuning based on overflow analysis.
4476 This doesn't fix any bugs. Use int to hold character, instead
4477 of constantly refetching from Emacs object. Use XFASTINT, not
4478 XINT, for value known to be a character. Don't bother comparing
4479 a single byte to 0400, as it's always less.
4480
395fcb93 4481 * floatfns.c (Fexpt):
327eeec8
PE
4482 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4483
abbd3d23
PE
4484 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4485 for characters.
4486
684a03ef
PE
4487 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4488
0fed43f3
PE
4489 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4490 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4491 incorrectly succeed when S was a string, because 4294967386 was
4492 truncated before it was used.
4493
8fd02eb7
PE
4494 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4495 Otherwise, an out-of-range integer could cause undefined behavior
4496 on a 64-bit host.
4497
f8c86b69
PE
4498 * composite.c: Use int, not EMACS_INT, for characters.
4499 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4500 EMACS_INT, for values that are known to be in character range.
4501 This doesn't fix any bugs but is the usual style inside Emacs and
4502 may generate better code on 32-bit machines.
4503
34206dd2
PE
4504 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4505 This is for reasons similar to the recent CHAR_STRING fix.
4506 * charset.c (Fencode_char): Check that character arg is actually
4507 a character. Pass an int to ENCODE_CHAR.
4508 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4509 wider than 'int', as a compile-time check to prevent future regressions
4510 in this area.
4511
c5958d4c 4512 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4513
4514 Make sure a 64-bit char is never passed to CHAR_STRING.
4515 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4516 by silently ignoring the top 32 bits, allowing some values
4517 that were far too large to be valid characters.
4518 * character.h: Include <verify.h>.
4519 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4520 arguments are no wider than unsigned, as a compile-time check
4521 to prevent future regressions in this area.
4522 * data.c (Faset):
01103c44 4523 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4524 (Fsubst_char_in_region):
4525 * fns.c (concat):
4526 * xdisp.c (decode_mode_spec_coding):
4527 Adjust to CHAR_STRING's new requirement.
4528 * editfns.c (Finsert_char, Fsubst_char_in_region):
4529 * fns.c (concat): Check that character args are actually
4530 characters. Without this test, these functions did the wrong
4531 thing with wildly out-of-range values on 64-bit hosts.
4532
d37ca623
PE
4533 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4534 These casts should not be needed on 32-bit hosts, either.
4535 * keyboard.c (read_char):
4536 * lread.c (Fload): Remove casts to unsigned.
4537
ea204efb
PE
4538 * lisp.h (UNSIGNED_CMP): New macro.
4539 This fixes comparison bugs on 64-bit hosts.
4540 (ASCII_CHAR_P): Use it.
4541 * casefiddle.c (casify_object):
01103c44 4542 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4543 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4544 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4545 * dispextern.h (FACE_FROM_ID):
4546 * keyboard.c (read_char): Use UNSIGNED_CMP.
4547
41cb286c
PE
4548 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4549 not to EMACS_INT, to avoid GCC warning.
4550
4a1b9832
PE
4551 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4552
55daad71
PE
4553 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4554 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4555 isn't needed on 32-bit machines.
8f95c75c 4556
01103c44
PE
4557 * buffer.c (Fgenerate_new_buffer_name):
4558 Use EMACS_INT for count, not int.
0ceccced 4559 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4560
4561 * data.c (Qcompiled_function): Now static.
4562
c6f072e7
PE
4563 * window.c (window_body_lines): Now static.
4564
20ce5912
PE
4565 * image.c (gif_load): Rename local to avoid shadowing.
4566
9c4c5f81
PE
4567 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4568 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4569 * alloc.c (make_save_value): Integer argument is now of type
4570 ptrdiff_t, not int.
4571 (mark_object): Use ptrdiff_t, not int.
4572 * lisp.h (pD): New macro.
4573 * print.c (print_object): Use it.
4574
c0c5c8ae
PE
4575 * alloc.c: Use EMACS_INT, not int, to count objects.
4576 (total_conses, total_markers, total_symbols, total_vector_size)
4577 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4578 (total_free_floats, total_floats, total_free_intervals)
4579 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4580 Now EMACS_INT, not int. All uses changed.
4581 (Fgarbage_collect): Compute overall total using a double, so that
4582 integer overflow is less likely to be a problem. Check for overflow
4583 when converting back to an integer.
5a25e253
PE
4584 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4585 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4586 These were 'int' variables that could overflow on 64-bit hosts;
4587 they were never used, so remove them instead of repairing them.
211a0b2a 4588 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4589 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4590 Previously, this ceilinged at INT_MAX, but that doesn't work on
4591 64-bit machines.
e46bb31a 4592 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4593
c78baabf 4594 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4595 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4596 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4597 when a (possibly-narrower) signed value would do just as well.
4598 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4599
c9d624c6
PE
4600 * alloc.c: Catch some string size overflows that we were missing.
4601 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4602 for convenience in STRING_BYTES_MAX.
4603 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4604 The definition here is exact; the one in lisp.h was approximate.
4605 (allocate_string_data): Check for string overflow. This catches
4606 some instances we weren't catching before. Also, it catches
4607 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4608 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4609 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4610
c9d624c6
PE
4611 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4612 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4613 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4614
353032ce
PE
4615 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4616
2bccce07
PE
4617 * alloc.c (Fmake_string): Check for out-of-range init.
4618
0ac30604
SM
46192011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4620
4621 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4622
c195f2de
JD
46232011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4624
4625 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4626 xg_get_default_scrollbar_width.
4627
4628 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4629 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4630 (style_changed_cb): Call update_theme_scrollbar_width and call
4631 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4632 all frames (Bug#8505).
4633 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4634 Call gtk_window_set_resizable if HAVE_GTK3.
4635 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4636 and height if HAVE_GTK3 (Bug#8505).
4637 (scroll_bar_width_for_theme): New variable.
4638 (update_theme_scrollbar_width): New function.
4639 (xg_get_default_scrollbar_width): Move code to
4640 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4641 (xg_initialize): Call update_theme_scrollbar_width.
4642
4643 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4644
4645 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4646
e10ac9f1
MR
46472011-06-12 Martin Rudalics <rudalics@gmx.at>
4648
4649 * frame.c (make_frame): Call other_buffer_safely instead of
4650 other_buffer.
4651
4652 * window.c (temp_output_buffer_show): Call display_buffer with
4653 second argument Vtemp_buffer_show_specifiers and reset latter
4654 immediately after the call.
4655 (Vtemp_buffer_show_specifiers): New variable.
4656 (auto_window_vscroll_p, next_screen_context_lines)
4657 (Vscroll_preserve_screen_position): Remove leading asterisks from
4658 doc-strings.
4659
2d3c217e 46602011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4661
7b7f97e8 4662 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4663 * buffer.c (Qclone_number): Remove for now, as it's unused.
4664 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4665 (record_buffer): Remove unused local.
4666 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4667 (set_frame_buffer_list): Remove; unused.
4668 * frame.h (other_visible_frames): Remove decl.
4669 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4670 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4671 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4672 if HAVE_GPM.
4673 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4674 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4675 Define only if HAVE_GPM.
4676 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4677 (update_hints_inhibit): Remove; never set. All uses removed.
4678 * widgetprv.h (emacsFrameClassRec): Remove decl.
4679 * window.c (delete_deletable_window): Now returns void, since it
4680 wasn't returning anything.
4681 (compare_window_configurations): Remove unused locals.
4682 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4683 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4684 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4685 the same widths as pointers. This follows up on the 2011-05-06 patch.
4686 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4687 * xterm.h: Likewise.
4688 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4689
1384b89e
JB
46902011-06-12 Juanma Barranquero <lekktu@gmail.com>
4691
4692 * makefile.w32-in: Update dependencies.
4693 (LISP_H): Add lib/intprops.h.
4694
1100a63c
CY
46952011-06-11 Chong Yidong <cyd@stupidchicken.com>
4696
4697 * image.c (gif_load): Add animation frame delay to the metadata.
4698 (syms_of_image): Use DEFSYM. New symbol `delay'.
4699
6198ccd0
MR
47002011-06-11 Martin Rudalics <rudalics@gmx.at>
4701
4702 * window.c (delete_deletable_window): Re-add.
4703 (Fset_window_configuration): Rewrite to handle dead buffers and
4704 consequently deletable windows.
4705 (window_tree, Fwindow_tree): Remove. Supply functionality in
4706 window.el.
4707 (compare_window_configurations): Simplify code.
4708
b6e3633c
AS
47092011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4710
1ab0dee5
AS
4711 * image.c (imagemagick_load_image): Fix type mismatch.
4712 (Fimagemagick_types): Likewise.
4713
b6e3633c
AS
4714 * window.h (replace_buffer_in_windows): Declare.
4715
9397e56f
MR
47162011-06-11 Martin Rudalics <rudalics@gmx.at>
4717
4718 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4719 Qclone_number. Remove external declaration of Qdelete_window.
4720 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4721 code.
640c8776
SM
4722 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4723 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4724 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4725 buffer list implementation.
4726 (other_buffer_safely): New function.
4727 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4728 calls to replace_buffer_in_windows and
4729 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4730 if allowed.
4731 (record_buffer): Inhibit quitting and rewrite using quittable
4732 functions. Run Qbuffer_list_update_hook if allowed.
4733 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4734 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4735 Move switch-to-buffer to window.el.
9397e56f
MR
4736 (bury-buffer): Move to window.el.
4737 (Vbuffer_list_update_hook): New variable.
4738
4739 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4740 section.
4741
4742 * window.h (resize_frame_windows): Move up in code.
4743 (Fwindow_frame): Remove EXFUN.
4744 (replace_buffer_in_all_windows): Remove prototype.
4745 (replace_buffer_in_windows_safely): Add prototype.
4746
4747 * window.c: Declare Qdelete_window static again. Move down
4748 declaration of select_count.
4749 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4750 (Fother_window): Move to window.el.
4751 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4752 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4753 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4754 window.el.
4755 (replace_buffer_in_windows): Implement by calling
4756 Qreplace_buffer_in_windows.
4757 (replace_buffer_in_all_windows): Remove with some functionality
4758 moved into replace_buffer_in_windows_safely.
4759 (replace_buffer_in_windows_safely): New function.
4760 (select_window_norecord, select_frame_norecord): Move in front
4761 of run_window_configuration_change_hook. Remove now obsolete
4762 declarations.
640c8776
SM
4763 (Fset_window_buffer): Rewrite doc-string.
4764 Call Qrecord_window_buffer.
9397e56f
MR
4765 (keys_of_window): Move binding for other-window to window.el.
4766
b50691aa
CY
47672011-06-11 Chong Yidong <cyd@stupidchicken.com>
4768
4769 * dispextern.h (struct image): Replace data member, whose int_val
4770 and ptr_val fields were not used by anything, with a single
4771 lisp_val object.
4772
4773 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4774 (gif_clear_image, gif_load, imagemagick_load_image)
4775 (gs_clear_image, gs_load): Callers changed.
4776
3f754b86
PE
47772011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4778
cca69397
PE
4779 * buffer.h: Include <time.h>, for time_t.
4780 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4781
109e28d0
PE
4782 Fix minor problems found by static checking.
4783
60737f02
PE
4784 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4785
4b66faf3
PE
4786 Make identifiers static if they are not used in other modules.
4787 * data.c (Qcompiled_function, Qframe, Qvector):
4788 * image.c (QimageMagick, Qsvg):
4789 * minibuf.c (Qmetadata):
4790 * window.c (resize_window_check, resize_root_window): Now static.
4791 * window.h (resize_window_check, resize_root_window): Remove decls.
4792
109e28d0
PE
4793 * window.c (window_deletion_count, delete_deletable_window):
4794 Remove; unused.
46a4ce9e
PE
4795 (window_body_lines): Now static.
4796 (Fdelete_other_windows_internal): Mark vars as initialized.
4797 Make sure 'resize_failed' is initialized.
4798 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4799 (resize_window_apply): Remove unused local.
4800 * window.h (delete_deletable_window): Remove decl.
4801
109e28d0 4802 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4803 (imagemagick_load_image): Fix pointer signedness problem by changing
4804 last arg from unsigned char * to char *. All uses changed.
4805 Also, fix a local for similar reasons.
4806 Remove unused locals. Remove locals to avoid shadowing.
4807 (fn_rsvg_handle_free): Remove; unused.
4808 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4809 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4810
3f754b86
PE
4811 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4812
2547adb1
CY
48132011-06-10 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * image.c (gif_load): Fix omitted cast error introduced by
4816 2011-06-06 change.
4817
2c8e37d4
MR
48182011-06-10 Martin Rudalics <rudalics@gmx.at>
4819
4820 * window.h (resize_proportionally, orig_total_lines)
4821 (orig_top_line): Remove from window structure.
4822 (set_window_height, set_window_width, change_window_heights)
4823 (Fdelete_window): Remove prototypes.
4824 (resize_frame_windows): Remove duplicate declaration.
4825
440a42e3
EZ
48262011-06-10 Eli Zaretskii <eliz@gnu.org>
4827
4828 * window.h (resize_frame_windows, resize_window_check)
4829 (delete_deletable_window, resize_root_window)
4830 (resize_frame_windows): Declare prototypes.
4831
4832 * window.c (resize_window_apply): Make definition be "static" to
4833 match the prototype.
4834
562dd5e9
MR
48352011-06-10 Martin Rudalics <rudalics@gmx.at>
4836
4837 * window.c: Remove declarations of Qwindow_size_fixed,
4838 window_min_size_1, window_min_size_2, window_min_size,
4839 size_window, window_fixed_size_p, enlarge_window, delete_window.
4840 Remove static from declaration of Qdelete_window, it's
4841 temporarily needed by Fbury_buffer.
4842 (replace_window): Don't assign orig_top_line and
4843 orig_total_lines.
4844 (Fdelete_window, delete_window): Remove. Window deletion is
4845 handled by window.el.
640c8776
SM
4846 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4847 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4848 (Fdelete_other_windows): Remove. Deleting other windows is
4849 handled by window.el.
4850 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4851 handled in window.el.
4852 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4853 Window minimum sizes are handled in window.el.
4854 (shrink_windows, size_window, set_window_height)
4855 (set_window_width, change_window_heights, window_height)
4856 (window_width, CURBEG, CURSIZE, enlarge_window)
4857 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4858 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4859 handled in window.el.
4860 (make_dummy_parent): Rename to make_parent_window and give it a
4861 second argument horflag.
4862 (make_window): Don't set resize_proportionally any more.
4863 (Fsplit_window): Remove. Windows are split in window.el.
4864 (save_restore_action, save_restore_orig_size)
4865 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4866 Resize mini windows in window.el.
4867 (grow_mini_window, shrink_mini_window): Implement by calling
4868 Qresize_root_window_vertically, resize_window_check and
4869 resize_window_apply.
640c8776
SM
4870 (saved_window, Fset_window_configuration, save_window_save):
4871 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4872 resize_proportionally.
4873 (window_min_height, window_min_width): Move to window.el.
4874 (keys_of_window): Move bindings for delete-other-windows,
4875 split-window, delete-window and enlarge-window to window.el.
4876
4877 * buffer.c: Temporarily extern Qdelete_window.
4878 (Fbury_buffer): Temporarily call Qdelete_window instead of
4879 Fdelete_window (Fbury_buffer will move to window.el soon).
4880
4881 * frame.c (set_menu_bar_lines_1): Remove code handling
4882 orig_top_line and orig_total_lines.
4883
4884 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4885 set_window_height but set heights directly.
4886 (change_frame_size_1): Use resize_frame_windows.
4887
4888 * xdisp.c (init_xdisp): Don't use set_window_height but set
4889 heights directly.
4890
640c8776
SM
4891 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4892 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4893 run_window_configuration_change_hook.
4894
4895 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4896 instead of change_window_heights and run
4897 run_window_configuration_change_hook.
4898
1a13852e
MR
48992011-06-09 Martin Rudalics <rudalics@gmx.at>
4900
4901 * window.c (replace_window): Rename second argument REPLACEMENT to
4902 NEW. New third argument SETFLAG. Rewrite.
4903 (delete_window, make_dummy_parent): Call replace_window with
4904 third argument 1.
4905 (window_list_1): Move down in code.
4906 (run_window_configuration_change_hook): Move set_buffer part
4907 before select_frame_norecord part in order to unwind correctly.
4908 Rename count1 to count.
4909 (recombine_windows, delete_deletable_window, resize_root_window)
4910 (Fdelete_other_windows_internal)
4911 (Frun_window_configuration_change_hook, make_parent_window)
4912 (resize_window_check, resize_window_apply, Fresize_window_apply)
4913 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4914 (Fdelete_window_internal, Fresize_mini_window_internal):
4915 New functions.
1a13852e
MR
4916 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4917
f3d1777e
MR
49182011-06-08 Martin Rudalics <rudalics@gmx.at>
4919
496e208e
MR
4920 * window.h (window): Add some new members to window structure -
4921 normal_lines, normal_cols, new_total, new_normal, clone_number,
4922 splits, nest, prev_buffers, next_buffers.
4923 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4924 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4925
f3d1777e
MR
4926 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4927 Remove.
496e208e
MR
4928 (make_dummy_parent): Set new members of windows structure.
4929 (make_window): Move down in code. Handle new members of window
4930 structure.
4931 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4932 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4933 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4934 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4935 (Fset_window_next_buffers, Fset_window_clone_number):
4936 New functions.
496e208e
MR
4937 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4938 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4939 Doc-string fixes.
4940 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4941 Argument WINDOW can be now internal window too.
4942 (Fwindow_use_time): Move up in code.
4943 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4944 Rewrite doc-string.
4945 (Fset_window_configuration, saved_window)
4946 (Fcurrent_window_configuration, save_window_save): Handle new
4947 members of window structure.
b9e809c2
MR
4948 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4949 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4950 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4951 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4952 Qget_mru_window, Qresize_root_window,
4953 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4954 Qauto_buffer_name; staticpro them.
f3d1777e 4955
abde8f8c
MR
49562011-06-07 Martin Rudalics <rudalics@gmx.at>
4957
4958 * window.c (Fwindow_total_size, Fwindow_left_column)
4959 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4960 (Fwindow_list_1): New functions.
4961 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4962 (Fwindow_width, Fscroll_left, Fscroll_right):
4963 Use window_body_cols instead of window_box_text_cols.
4964 (delete_window, Fset_window_configuration):
4965 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4966 (delete_all_subwindows): Take a window as argument and not a
4967 structure. Rewrite.
190b47e6
MR
4968 (window_loop): Remove handling of GET_LRU_WINDOW and
4969 GET_LARGEST_WINDOW.
4970 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4971
4972 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4973 window_box_text_cols. delete_all_subwindows now takes a
4974 Lisp_Object as argument.
abde8f8c 4975
640c8776
SM
4976 * indent.c (compute_motion, Fcompute_motion):
4977 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4978
fa8a67e6
MR
4979 * frame.c (delete_frame): Call delete_all_subwindows with root
4980 window as argument.
4981
a54e3482
DC
49822011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4983
4984 * fns.c (Fputhash): Document return value.
4985
60002bf5
CY
49862011-06-06 Chong Yidong <cyd@stupidchicken.com>
4987
4988 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4989
0c671da6 49902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4991
b862a52a 4992 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4993
be44ca6c
PE
4994 Check for overflow when converting integer to cons and back.
4995 * charset.c (Fdefine_charset_internal, Fdecode_char):
4996 Use cons_to_unsigned to catch overflow.
4997 (Fencode_char): Use INTEGER_TO_CONS.
4998 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4999 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5000 * data.c (long_to_cons, cons_to_long): Remove.
5001 (cons_to_unsigned, cons_to_signed): New functions.
5002 These signal an error for invalid or out-of-range values.
5003 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5004 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5005 * font.c (Ffont_variation_glyphs):
5006 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5007 * lisp.h: Include <intprops.h>.
5008 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5009 (cons_to_signed, cons_to_unsigned): New decls.
5010 (long_to_cons, cons_to_long): Remove decls.
5011 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5012 (Fprimitive_undo): Use CONS_TO_INTEGER.
5013 * xfns.c (Fx_window_property): Likewise.
5014 * xselect.c: Include <limits.h>.
5015 (x_own_selection, selection_data_to_lisp_data):
5016 Use INTEGER_TO_CONS.
5017 (x_handle_selection_request, x_handle_selection_clear)
5018 (x_get_foreign_selection, Fx_disown_selection_internal)
5019 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5020 (lisp_data_to_selection_data): Use cons_to_unsigned.
5021 (x_fill_property_data): Use cons_to_signed.
5022 Report values out of range.
5023
d1f3d2af
PE
5024 Check for buffer and string overflow more precisely.
5025 * buffer.h (BUF_BYTES_MAX): New macro.
5026 * lisp.h (STRING_BYTES_MAX): New macro.
5027 * alloc.c (Fmake_string):
5028 * character.c (string_escape_byte8):
5029 * coding.c (coding_alloc_by_realloc):
5030 * doprnt.c (doprnt):
5031 * editfns.c (Fformat):
5032 * eval.c (verror):
5033 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5034 since they may not be the same number.
5035 * editfns.c (Finsert_char):
5036 * fileio.c (Finsert_file_contents):
5037 Likewise for BUF_BYTES_MAX.
5038
dd52fcea
PE
5039 * image.c: Use ptrdiff_t, not int, for sizes.
5040 (slurp_file): Switch from int to ptrdiff_t.
5041 All uses changed.
5042 (slurp_file): Check that file size fits in both size_t (for
5043 malloc) and ptrdiff_t (for sanity and safety).
5044
7f9bbdbb
PE
5045 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5046 if b->modtime has its maximal value.
5047
dfe18f82
PE
5048 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5049
84acfcf0
PE
5050 Don't assume time_t can fit into int.
5051 * buffer.h (struct buffer.modtime): Now time_t, not int.
5052 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5053 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5054
ccd9a01a
PE
5055 Minor fixes for signed vs unsigned integers.
5056 * character.h (MAYBE_UNIFY_CHAR):
5057 * charset.c (maybe_unify_char):
5058 * keyboard.c (read_char, reorder_modifiers):
5059 XINT -> XFASTINT, since the integer must be nonnegative.
5060 * ftfont.c (ftfont_spec_pattern):
5061 * keymap.c (access_keymap, silly_event_symbol_error):
5062 XUINT -> XFASTINT, since the integer must be nonnegative.
5063 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5064 since it makes no difference and we prefer signed.
5065 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5066 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5067 nonnegative.
5068
d6d100dd
SM
50692011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5070
5071 * window.h (Fwindow_frame): Declare.
5072
2b6148e4
PE
50732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5076 (SPARE_MEMORY): Always define.
5077 (LARGE_REQUEST): Remove.
5078 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5079
f230ecc9
MR
50802011-06-06 Martin Rudalics <rudalics@gmx.at>
5081
727e958e
MR
5082 * lisp.h: Move EXFUNS for Fframe_root_window,
5083 Fframe_first_window and Fset_frame_selected_window to window.h.
5084
5085 * window.h: Move EXFUNS for Fframe_root_window,
5086 Fframe_first_window and Fset_frame_selected_window here from
5087 lisp.h.
5088
5089 * frame.c (Fwindow_frame, Fframe_first_window)
5090 (Fframe_root_window, Fframe_selected_window)
5091 (Fset_frame_selected_window): Move to window.c.
5092 (Factive_minibuffer_window): Move to minibuf.c.
5093 (Fother_visible_frames_p): New function.
5094
5095 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5096
f230ecc9
MR
5097 * window.c (decode_window, decode_any_window): Move up in code.
5098 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5099 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5100 (Fwindow_buffer): Move up and rewrite doc-string.
5101 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5102 (Fwindow_prev): New functions.
727e958e
MR
5103 (Fwindow_frame): Move here from frame.c. Accept any window as
5104 argument.
5105 (Fframe_root_window, Fframe_first_window)
5106 (Fframe_selected_window): Move here from frame.c. Accept frame
5107 or arbitrary window as argument. Update doc-strings.
5108 (Fminibuffer_window): Move up in code.
5109 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5110 (Fset_frame_selected_window): Move here from frame.c.
5111 Marginal rewrite.
727e958e
MR
5112 (Fselected_window, select_window, Fselect_window): Move up in
5113 code. Minor doc-string fixes.
f230ecc9 5114
4d09bcf6
PE
51152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5118 Do not assume that spare memory exists; that assumption is valid
5119 only if SYSTEM_MALLOC.
5120 (LARGE_REQUEST): New macro, so that the issue of large requests
5121 is separated from the issue of spare memory.
5122
810928a2
AS
51232011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5124
172418ad
AS
5125 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5126 format. (Bug#8806)
5127
43f862f7
AS
5128 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5129
810928a2
AS
5130 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5131 before statements.
5132
a059fe24
JD
51332011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5134
5135 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5136
5137 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5138
5139 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5140 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5141
989bf368
JB
51422011-06-05 Juanma Barranquero <lekktu@gmail.com>
5143
5144 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5145
4b80f674
CY
51462011-06-04 Chong Yidong <cyd@stupidchicken.com>
5147
5148 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5149 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5150 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5151 New error handlers.
4b80f674
CY
5152 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5153 Obey Vx_select_enable_clipboard_manager. Catch errors in
5154 x_clipboard_manager_save (Bug#8779).
5155 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5156 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5157
99a33b77 51582011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5159
5160 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5161
99a33b77 51622011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5163
5164 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5165 in the current matrix if keep_current_p is non-zero.
5166
8264569d
EZ
51672011-06-04 Eli Zaretskii <eliz@gnu.org>
5168
5169 * bidi.c (bidi_level_of_next_char): Fix last change.
5170
57f97249
EZ
51712011-06-03 Eli Zaretskii <eliz@gnu.org>
5172
fec2107c 5173 Support bidi reordering of text covered by display properties.
57f97249 5174
fec2107c
EZ
5175 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5176 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5177 (bidi_cache_search, bidi_cache_iterator_state)
5178 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5179 (bidi_level_of_next_char, bidi_move_to_visually_next):
5180 Support character positions inside a run of characters covered by a
fec2107c
EZ
5181 display string.
5182 (bidi_paragraph_init, bidi_resolve_explicit_1)
5183 (bidi_level_of_next_char): Call bidi_fetch_char and
5184 bidi_fetch_char_advance instead of FETCH_CHAR and
5185 FETCH_CHAR_ADVANCE.
5186 (bidi_init_it): Initialize new members.
5187 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5188 definitions.
5189 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5190 instead of using explicit *_CHAR codes.
d6d100dd
SM
5191 (bidi_resolve_explicit, bidi_resolve_weak):
5192 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5193 bidirectional text is supported only in multibyte buffers.
5194 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5195 it to initialize the frame_window_p member of struct bidi_it.
5196 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5197 (bidi_resolve_explicit, bidi_resolve_weak)
5198 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5199 bidi_it->nchars is non-positive.
5200 (bidi_level_of_next_char): Don't try to lookup the cache for the
5201 next/previous character if nothing is cached there yet, or if we
5202 were just reseat()'ed to a new position.
c40e2fb2 5203
0e14fe90
EZ
5204 * xdisp.c (set_cursor_from_row): Set start and stop points
5205 according to the row's direction when priming the loop that looks
5206 for the glyph on which to display cursor.
5207 (single_display_spec_intangible_p): Function deleted.
5208 (display_prop_intangible_p): Reimplement to call
5209 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5210 Accept 3 additional arguments needed by handle_display_spec.
5211 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5212 values: lists, `(when COND...)' forms, etc.
5213 (single_display_spec_string_p): Support property values that are
5214 lists with the argument STRING its top-level element.
5215 (display_prop_string_p): Fix the condition for processing a
5216 property that is a list to be consistent with handle_display_spec.
fec2107c 5217 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5218 last portion of handle_display_prop.
5219 (compute_display_string_pos): Accept additional argument
5220 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5221 value of a `display' property is a "replacing spec".
5222 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5223 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5224 the display property, but just return a value indicating whether
5225 the display property will replace the characters it covers.
5226 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5227 frame_window_p members of struct bidi_it.
d6d100dd
SM
5228 (compute_display_string_pos, compute_display_string_end):
5229 New functions.
fec2107c
EZ
5230 (push_it): Accept second argument POSITION, where pop_it should
5231 jump to continue iteration.
5232 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5233
fec2107c
EZ
5234 * keyboard.c (adjust_point_for_property): Adjust the call to
5235 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5236
5237 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5238 (bidi_init_it): Update prototypes.
5239 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5240 (compute_display_string_pos, compute_display_string_end):
5241 Declare prototypes.
fec2107c
EZ
5242 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5243 EMACS_INT.
fc6f18ce 5244
40087514 52452011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5246
57f53182
PE
5247 Malloc failure behavior now depends on size of allocation.
5248 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5249 * lisp.h: Change signatures accordingly.
5250 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5251 All callers changed. (Bug#8762)
5252
5253 * gnutls.c: Use Emacs's memory allocators.
5254 Without this change, the gnutls library would invoke malloc etc.
5255 directly, which causes problems on non-SYNC_INPUT hosts, and which
5256 runs afoul of improving memory_full behavior. (Bug#8761)
5257 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5258 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5259 xfree instead of the default malloc, realloc, free.
5260 (Fgnutls_boot): No need to check for memory allocation failure,
5261 since xmalloc does that for us.
5262
ac32cd99 5263 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5264 * category.c (hash_get_category_set):
5265 * ccl.c (ccl_driver):
5266 * charset.c (Fdefine_charset_internal):
5267 * charset.h (struct charset.hash_index):
5268 * composite.c (get_composition_id, gstring_lookup_cache)
5269 (composition_gstring_put_cache):
5270 * composite.h (struct composition.hash_index):
5271 * dispextern.h (struct image.hash):
5272 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5273 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5274 (hashfn_equal, hashfn_user_defined, make_hash_table)
5275 (maybe_resize_hash_table, hash_lookup, hash_put)
5276 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5277 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5278 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5279 * image.c (make_image, search_image_cache, lookup_image)
5280 (xpm_put_color_table_h):
5281 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5282 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5283 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5284 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5285 * alloc.c (allocate_vectorlike):
5286 Check for overflow in vector size calculations.
5287 * ccl.c (ccl_driver):
5288 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5289 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5290 need to be updated by these changes.
40087514
PE
5291 * fns.c (make_hash_table, maybe_resize_hash_table):
5292 Check for integer overflow with large hash tables.
0de4bb68
PE
5293 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5294 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5295 (SXHASH_REDUCE): New macro.
5296 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5297 Use it instead of discarding useful hash info with large hash values.
5298 (sxhash_float): New function.
5299 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5300 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5301 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5302 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5303 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5304 Adjust signatures to match updated version of code.
5305 (consing_since_gc): Now EMACS_INT, since a single hash table can
5306 use more than INT_MAX bytes.
5307
698d32e2
DN
53082011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5309
5310 Make it possible to build with GCC-4.6+ -O2 -flto.
5311
5312 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5313
fd6fa53f
SM
53142011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5315
5316 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5317 Call minibuffer-inactive-mode.
5318
864db017
JB
53192011-05-31 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5322 Update dependencies.
5323
2ad0baf4
DN
53242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5325
5326 * data.c (init_data): Remove code for UTS, this system is not
5327 supported anymore.
5328
4fcc2638
DN
53292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5330
5331 Don't force ./temacs to start in terminal mode.
5332
5333 * frame.c (make_initial_frame): Initialize faces in all cases, not
5334 only when CANNOT_DUMP is defined.
5335 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5336
c56e0fd5
DN
53372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5338
5339 * dispnew.c (add_window_display_history): Use const for the string
5340 pointer. Remove declaration, not needed.
5341
333d54da 53422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5343
55d4c1b2 5344 Use 'inline', not 'INLINE'.
333d54da 5345 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5346 * alloc.c, fontset.c (INLINE): Remove.
5347 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5348 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5349 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5350 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5351 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5352
738db178
DN
53532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5354
5355 Make it possible to run ./temacs.
5356
5357 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5358 syms_of_callproc does the same thing. Remove test for
5359 "initialized", do it in the caller.
5360 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5361
620c53a6
SM
53622011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5363
5364 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5365 (read_minibuf): Use get_minibuffer.
5366 (syms_of_minibuf): Use DEFSYM.
5367 (Qmetadata): New var.
5368 * data.c (Qbuffer): Don't make it static.
5369 (syms_of_data): Use DEFSYM.
5370
e003a292
PE
53712011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5372
5373 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5374 (CCL_CODE_MIN): New macro.
5375
ed008a6d
PE
53762011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5377
3687c2ef
PE
5378 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5379
ed008a6d
PE
5380 * eval.c (Qdebug): Now static.
5381 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5382 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5383 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5384
d66c4c7c
CY
53852011-05-29 Chong Yidong <cyd@stupidchicken.com>
5386
5387 * image.c: Various fixes to ImageMagick code comments.
5388 (Fimagemagick_types): Doc fix.
5389
5fbc2025
PE
53902011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5391
0196f88a
PE
5392 Minor fixes prompted by GCC 4.6.0 warnings.
5393
5394 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5395
5fbc2025
PE
5396 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5397 (x_clipboard_manager_save_all): Move extern decl to ...
5398 * xterm.h: ... here, so that it can be checked for consistency.
5399
1dd3c2d9
CY
54002011-05-29 Chong Yidong <cyd@stupidchicken.com>
5401
5402 * xselect.c (x_clipboard_manager_save_frame)
5403 (x_clipboard_manager_save_all): New functions.
5404 (Fx_clipboard_manager_save): Lisp function deleted.
5405
5406 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5407 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5408
5409 * xterm.h: Update prototype.
5410
5ba6571d
WX
54112011-05-28 William Xu <william.xwl@gmail.com>
5412
5413 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5414 exiting (Bug#8239).
5415
3eaff834
JM
54162011-05-28 Jim Meyering <meyering@redhat.com>
5417
e1900994 5418 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5419 * fns.c (to_uchar): Define.
5420 (crypto_hash_function): Use it to convert some newly-signed
5421 variables to unsigned, to avoid sign-extension bugs. For example,
5422 without this change, (md5 "truc") would evaluate to
5423 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5424 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5425 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5426
0f6990a7
PE
54272011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5428
5429 Integer overflow fixes.
c8a9ca5a 5430
08686060
PE
5431 * dbusbind.c: Serial number integer overflow fixes.
5432 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5433 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5434 to hold a serial number that is too large for a fixnum.
5435 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5436 Check for serial numbers out of range. Decode any serial number
59568bf0 5437 that was so large that it became a float. (Bug#8722)
08686060 5438
2d1fc3c7
PE
5439 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5440 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5441 Use XFASTINT rather than XUINT when numbers are nonnegative.
5442 (xd_append_arg, Fdbus_method_return_internal):
5443 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5444 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5445 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5446 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5447 (Bug#8722)
2d1fc3c7 5448
c8a9ca5a
PE
5449 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5450
519e1d69
PE
5451 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5452
30569699
PE
5453 ccl: add integer overflow checks
5454 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5455 (IN_INT_RANGE): New macros.
5456 (ccl_driver): Use them to check for integer overflow when
5457 decoding a CCL program. Many of the new checks are whether XINT (x)
5458 fits in int; it doesn't always, on 64-bit hosts. The new version
5459 doesn't catch all possible integer overflows, but it's an
847044ea 5460 improvement. (Bug#8719)
30569699 5461
c11285dc
PE
5462 * alloc.c (make_event_array): Use XINT, not XUINT.
5463 There's no need for unsigned here.
5464
fdccd48e
PE
5465 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5466 This follows up to the 2011-05-06 change that substituted uintptr_t
5467 for EMACS_INT. This case wasn't caught back then.
5468
37910ab2
PE
5469 Rework Fformat to avoid integer overflow issues.
5470 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5471 now (part of C89). Include <verify.h>.
5472 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5473 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5474 (Fformat): Avoid the prepass trying to compute sizes; it was only
5475 approximate and thus did not catch overflow reliably. Instead, walk
5476 through the format just once, formatting and computing sizes as we go,
5477 checking for integer overflow at every step, and allocating a larger
5478 buffer as needed. Keep track separately whether the format is
5479 multibyte. Keep only the most-recently calculated precision, rather
5480 than them all. Record whether each argument has been converted to
5481 string. Use EMACS_INT, not int, for byte and char and arg counts.
5482 Support field widths and precisions larger than INT_MAX. Avoid
5483 sprintf's undefined behavior with conversion specifications such as %#d
5484 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5485 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5486 formatting out-of-range floating point numbers with int
9173deec 5487 formats. (Bug#8668)
37910ab2 5488
2e6578fb
PE
5489 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5490
0ae6bdee
PE
5491 * data.c: Avoid integer truncation in expressions involving floats.
5492 * data.c: Include <intprops.h>.
5493 (arith_driver): When there's an integer overflow in an expression
5494 involving floating point, convert the integers to floating point
5495 so that the resulting value does not suffer from catastrophic
5496 integer truncation. For example, on a 64-bit host (* 4
5497 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5498 Do not rely on undefined behavior after integer overflow.
5499
de883a70
PE
5500 merge count_size_as_multibyte, parse_str_to_multibyte
5501 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5502 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5503 Check for integer overflow.
5504 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5505 since it's now a duplicate of the other. This is more of
5506 a character than a buffer op, so better that it's in character.c.
5507 * fns.c, print.c: Adjust to above changes.
5508
2ff916cb
PE
55092011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5510
5511 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5512
f1b54466
PE
55132011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5514
fb1ac845
PE
5515 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5516 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5517 (x_clipboard_manager_save): Now static.
5518 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5519
f1b54466
PE
5520 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5521 (crypto_hash_function): Now static.
5522 Fix pointer signedness problems. Avoid unnecessary initializations.
5523
a9f737ee
CY
55242011-05-27 Chong Yidong <cyd@stupidchicken.com>
5525
5526 * termhooks.h (Vselection_alist): Make it terminal-local.
5527
5528 * terminal.c (create_terminal): Initialize it.
5529
5530 * xselect.c: Support for clipboard managers.
5531 (Vselection_alist): Move to termhooks.h as terminal-local var.
5532 (LOCAL_SELECTION): New macro.
5533 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5534 (symbol_to_x_atom): Remove gratuitous arg.
5535 (x_handle_selection_request, lisp_data_to_selection_data)
5536 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5537 (x_own_selection, x_get_local_selection, x_convert_selection):
5538 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5539 (some_frame_on_display): Delete unused function.
5540 (Fx_own_selection_internal, Fx_get_selection_internal)
5541 (Fx_disown_selection_internal, Fx_selection_owner_p)
5542 (Fx_selection_exists_p): New optional frame arg.
5543 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5544 (x_handle_selection_clear): Don't treat other terminals with the
5545 same keyboard specially. Use the terminal-local Vselection_alist.
5546 (x_clear_frame_selections): Use Frun_hook_with_args.
5547
5548 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5549
5550 * xterm.h: Add support for those atoms.
5551
e067f0c1
CY
55522011-05-26 Chong Yidong <cyd@stupidchicken.com>
5553
5554 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5555 (converted_selections, conversion_fail_tag): New global variables.
5556 (x_selection_request_lisp_error): Free the above.
5557 (x_get_local_selection): Remove unnecessary code.
5558 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5559 of converted selections stored in converted_selections.
5560 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5561 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5562 (x_convert_selection): New function.
5563 (x_handle_selection_event): Simplify.
5564 (x_get_foreign_selection): Don't ignore incoming requests while
5565 waiting for an answer; this will fail when we implement
5566 SAVE_TARGETS, and seems unnecessary anyway.
5567 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5568 (Vx_sent_selection_functions): Doc fix.
5569
0f4aebc0
LL
55702011-05-26 Leo Liu <sdl.web@gmail.com>
5571
5572 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5573
e61124cd
YM
55742011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5575
5576 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5577
5578 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5579 for fringe update if it has periodic bitmap.
ac389d0c 5580 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5581 and fringe_bitmap_periodic_p.
5582
5583 * fringe.c (get_fringe_bitmap_data): New function.
5584 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5585 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5586 row. Mark glyph row for fringe update if periodicity changed.
5587
5588 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5589 for fringe update unless it has periodic bitmap.
5590
f16d9837
KH
55912011-05-25 Kenichi Handa <handa@m17n.org>
5592
5593 * xdisp.c (get_next_display_element): Set correct it->face_id for
5594 a static composition.
5595
e1b90ef6
LL
55962011-05-24 Leo Liu <sdl.web@gmail.com>
5597
5598 * deps.mk (fns.o):
5599 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5600
5601 * fns.c (crypto_hash_function, Fsha1): New function.
5602 (Fmd5): Use crypto_hash_function.
5603 (syms_of_fns): Add Ssha1.
5604
7400048f
PE
56052011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5606
5607 * gnutls.c: Remove unused macros.
5608 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5609 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5610 Remove macros that are defined and never used.
5611 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5612
abb71cf4
CY
56132011-05-22 Chong Yidong <cyd@stupidchicken.com>
5614
5615 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5616 (Fx_get_selection_internal): Minor cleanup.
5617 (Fx_own_selection_internal): Rename arguments for consistency with
5618 select.el.
5619
6307db39
PE
56202011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5621
5622 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5623
f3d4e0a4
CY
56242011-05-22 Chong Yidong <cyd@stupidchicken.com>
5625
5626 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5627
4d8ade89
YM
56282011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5629
5630 * dispnew.c (scrolling_window): Don't exclude the case that the
5631 last enabled row in the desired matrix touches the bottom boundary.
5632
32078c8d
GM
56332011-05-21 Glenn Morris <rgm@gnu.org>
5634
5635 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5636 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5637 and add some more files.
32078c8d 5638
7285dc67
EZ
56392011-05-20 Eli Zaretskii <eliz@gnu.org>
5640
5641 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5642 report_file_error introduced by the change from 2011-05-07.
5643
89d1bd22
PE
56442011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * systime.h (Time): Define only if emacs is defined.
5647 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5648 where the include path doesn't have X11/X.h by default. See
5649 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5650
e23640bb 56512011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5652
5653 * composite.c (find_automatic_composition): Fix previous change.
5654
b9704ad9
GM
56552011-05-20 Glenn Morris <rgm@gnu.org>
5656
5657 * lisp.mk: New file, split from Makefile.in.
5658 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5659 (shortlisp): Remove.
5660 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5661
4a720484
GM
56622011-05-19 Glenn Morris <rgm@gnu.org>
5663
5664 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5665 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5666 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5667 (lisp): Set the order to that of loadup.el.
5668 (shortlisp): Make it a copy of $lisp.
5669 (SOME_MACHINE_LISP): Remove.
5670 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5671 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5672
a28d4396
KH
56732011-05-18 Kenichi Handa <handa@m17n.org>
5674
5675 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5676 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5677 (find_automatic_composition): Mostly rewrite for efficiency.
5678
a2b1fa8e
JB
56792011-05-18 Juanma Barranquero <lekktu@gmail.com>
5680
5681 * makefile.w32-in: Update dependencies.
5682
8e1f5610
CS
56832011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5684
5685 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5686 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5687
7025ee00 56882011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5689
cdfa6eab
PE
5690 Fix some integer overflow issues, such as string length overflow.
5691
06d6db33
PE
5692 * insdel.c (count_size_as_multibyte): Check for string overflow.
5693
2b4560a8
PE
5694 * character.c (lisp_string_width): Check for string overflow.
5695 Use EMACS_INT, not int, for string indexes and lengths; in
5696 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5697 the resulting string length overflows an EMACS_INT; instead,
5698 report a string overflow if no precision given. When checking for
5699 precision exhaustion, use a check that cannot possibly have
5700 integer overflow. (Bug#8675)
5701 * character.h (lisp_string_width): Adjust to new signature.
5702
cb93f9be
PE
5703 * alloc.c (string_overflow): New function.
5704 (Fmake_string): Use it. This doesn't change behavior, but saves
5705 a few bytes and will simplify future changes.
5706 * character.c (string_escape_byte8): Likewise.
5707 * lisp.h (string_overflow): New decl.
5708
1a1f3366
PE
5709 Fixups, following up to the user-interface timestamp change.
5710 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5711 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5712 * msdos.c (mouse_get_pos): Likewise.
5713 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5714 * w32gui.h (Time): Define by including "systime.h" rather than by
5715 declaring it ourselves. (Bug#8664)
5716
d4e3e4d3
PE
5717 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5718 * image.c (clear_image_cache): Likewise.
5719
f6a24d19
PE
5720 * term.c (term_mouse_position): Don't assume time_t wraparound.
5721
08dc5ae6
PE
5722 Be more systematic about user-interface timestamps.
5723 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5724 and sometimes 'EMACS_UINT', to represent these timestamps.
5725 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5726 This makes the code easier to follow, and makes it easier to catch
5727 integer overflow bugs such as Bug#8664.
5728 * frame.c (Fmouse_position, Fmouse_pixel_position):
5729 Use Time, not unsigned long, for user-interface timestamps.
5730 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5731 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5732 * keyboard.h (last_event_timestamp): Likewise.
5733 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5734 * menu.h (xmenu_show): Likewise.
5735 * term.c (term_mouse_position): Likewise.
5736 * termhooks.h (struct input_event.timestamp): Likewise.
5737 (struct terminal.mouse_position_hook): Likewise.
5738 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5739 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5740 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5741 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5742 what it was before.
5743 * menu.h, termhooks.h: Include "systime.h", for Time.
5744
8e55734a
PE
5745 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5746 Don't assume that the difference between two unsigned long values
5747 can fit into an integer. At this point, we know button_down_time
5748 <= event->timestamp, so the difference must be nonnegative, so
5749 there's no need to cast the result if double-click-time is
5750 nonnegative, as it should be; check that it's nonnegative, just in
5751 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5752 apart (about 25 days). (Bug#8664)
8e55734a 5753
841f1b75 5754 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5755 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5756
3e26f69c
PE
5757 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5758 that always fit in int. Use a sentinel instead of a counter, to
5759 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5760 * frame.h (struct frame): Use int for menu_bar_items_used
5761 instead of EMACS_INT, since it always fits in int.
3e26f69c 5762
5cc152c0
PE
5763 * menu.c (grow_menu_items): Check for int overflow.
5764
d89eb65e
PE
5765 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5766
5235bd3e
PE
5767 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5768 Before, the code was not consistent. These values cannot exceed
5769 2**31 - 1 so there's no need to make them unsigned.
5770 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5771 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5772 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5773 as modifiers.
5774 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5775
bc827e23
PE
5776 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5777 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5778 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5779 presumably because the widths might not match.
5780
78eb494e
PE
5781 * window.c (size_window): Avoid needless test at loop start.
5782
04f2d78b
CB
57832011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5784
5785 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5786
d2fc7e3d 57872011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5788
5789 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5790
d2fc7e3d 57912011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5792
5793 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5794 `width' to `bar_area_x' and `bar_area_width', respectively.
5795 (x_scroll_run): Take account of fringe background extension.
5796
04f2d78b
CB
5797 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5798 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5799 `bar_area_width', respectively.
5800 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5801 background extension.
5802
79b70037
GM
58032011-05-10 Jim Meyering <meyering@redhat.com>
5804
5805 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5806
2f142cc5
JB
58072011-05-10 Juanma Barranquero <lekktu@gmail.com>
5808
5809 * image.c (Finit_image_library): Return t for built-in image types,
5810 like pbm and xbm. (Bug#8640)
5811
57679c86
AS
58122011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5813
5814 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5815
888c9e86
EZ
58162011-05-07 Eli Zaretskii <eliz@gnu.org>
5817
b0512a1d
EZ
5818 * w32console.c (Fset_screen_color): Doc fix.
5819 (Fget_screen_color): New function.
5820 (syms_of_ntterm): Defsubr it.
5821
7285dc67
EZ
5822 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5823 unlink the temporary file if Fcall_process didn't create it in the
5824 first place.
5825 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5826 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5827 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5828 cue to call_process_cleanup not to close that handle.
5829
4d3fcc8e
BK
58302011-05-07 Ben Key <bkey76@gmail.com>
5831
5832 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5833 one of two shell specific rules, either bootstrap-temacs-CMD or
5834 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5835 to the previous implementation of the bootstrap-temacs rule.
5836 The bootstrap-temacs-CMD rule is similar to the previous
5837 implementation of the bootstrap-temacs rule except that it
5838 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5839 variable.
5840
5841 These changes, along with some changes to nt/configure.bat,
5842 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5843 earlier fix to add support for --cflags and --ldflags options
5844 that include quotes so that it works whether make uses cmd or
5845 sh as the shell.
5846
b4289b64
MA
58472011-05-06 Michael Albinus <michael.albinus@gmx.de>
5848
5849 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5850 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5851 is a constant.
5852 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5853 a string. Handle both cases.
5854 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5855 (Fdbus_register_method): Use Qinvalid_function.
5856
af4c0e28
JB
58572011-05-06 Juanma Barranquero <lekktu@gmail.com>
5858
5859 * makefile.w32-in: Update dependencies.
5860 (LISP_H): Add inttypes.h and stdin.h.
5861 (PROCESS_H): Add unistd.h.
5862
c51453d9
EZ
58632011-05-06 Eli Zaretskii <eliz@gnu.org>
5864
5865 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5866 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5867
8ff0ac3c 58682011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5869
4c4b566b
PE
5870 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5871
aab2b9b5
PE
5872 * term.c (vfatal): Remove stray call to va_end.
5873 It's not needed and the C Standard doesn't allow it here anyway.
5874
c378da0b
PE
5875 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5876 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5877
288b08c7
PE
5878 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5879 bytes.
5880
e3601888
PE
5881 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5882
db6c0e74
PE
5883 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5884
dd5963ea
PE
5885 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5886
88c9450f
PE
5887 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5888
2f9442b8
PE
5889 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5890
c032b5f8
PE
5891 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5892 * charset.c (Fdefine_charset_internal): Don't initialize
5893 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5894 32-bit int (Bug#8600).
a108c10b
PE
5895
5896 * lread.c (read_integer): Be more consistent with string-to-number.
5897 Use string_to_number to do the actual conversion; this avoids
5898 rounding errors and fixes some other screwups. Without this fix,
5899 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5900 (digit_to_number): Move earlier, for benefit of read_integer.
5901 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5902 not a digit in any supported base. (Bug#8602)
a108c10b 5903
ad5f9eea
PE
5904 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5905
aec1708a
PE
5906 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5907 to match comment at start of function. This also removes a
5908 GCC warning about overflow in a 32+64-bit port.
5909
47be4ab5
PE
5910 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5911
371cac43
PE
5912 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5913 Reported by Stefan Monnier in
5914 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5915 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5916 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5917
d01a7826
PE
5918 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5919 (EMACS_UINTPTR): Likewise, with uintptr_t.
5920
7fd47d5c
PE
5921 * lisp.h: Prefer 64-bit EMACS_INT if available.
5922 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5923 on 32-bit hosts that have 64-bit int, so that they can access
5924 large files.
122b0c86
PE
5925 However, temporarily disable this change unless the temporary
5926 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5927
8727937b
PE
5928 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5929
8ac068ac
PE
5930 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5931 This removes an assumption that EMACS_INT and long are the same
5932 width as pointers. The assumption is true for Emacs porting targets
5933 now, but we want to make other targets possible.
5934 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5935 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5936 In the rest of the code, change types of integers that hold casted
5937 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5938 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5939 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5940 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5941 No need to cast type when ORing.
5942 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5943 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5944 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5945 assume EMACS_INT is the same width as char *.
5946 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5947 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5948 Remove no-longer-needed casts.
5949 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5950 (xg_tool_bar_help_callback, xg_make_tool_item):
5951 Use EMACS_INTPTR to hold an integer
5952 that will be cast to void *; this can avoid a GCC warning
5953 if EMACS_INT is not the same width as void *.
5954 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5955 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5956 (current_message_1, set_message_1):
5957 Use a local to convert to proper width without a cast.
5958 * xmenu.c (dialog_selection_callback): Likewise.
5959
ede49d71
PE
5960 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5961 Also, don't assume VALBITS / RAND_BITS is less than 5,
5962 and don't rely on undefined behavior when shifting a 1 left into
5963 the sign bit.
5964 * lisp.h (get_random): Change signature to match.
5965
2f30ecd0
PE
5966 * lread.c (hash_string): Use size_t, not int, for hash computation.
5967 Normally we prefer signed values; but hashing is special, because
5968 it's better to use unsigned division on hash table sizes so that
5969 the remainder is nonnegative. Also, size_t is the natural width
5970 for hashing into memory. The previous code used 'int', which doesn't
5971 retain enough info to hash well into very large tables.
5972 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5973
2a866e7b
PE
5974 * dbusbind.c: Don't possibly lose pointer info when converting.
5975 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5976 Use XPNTR rather than XHASH, so that the high-order bits of
5977 the pointer aren't lost when converting through void *.
5978
51639eac
PE
5979 * eval.c (Fautoload): Don't double-shift a pointer.
5980
92394119
PE
5981 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5982
dbdb9a7c
JB
59832011-05-06 Juanma Barranquero <lekktu@gmail.com>
5984
5985 * gnutls.c (DEF_GNUTLS_FN):
5986 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5987
db7a0b4f
AS
59882011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5989
5990 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5991 marker. (Bug#8610)
5992
f7ff1b0f 59932011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5994
5995 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5996 New version that can reserve upto 2GB of heap space.
5997
f7ff1b0f 59982011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5999
6000 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6001
639c109b
TZ
60022011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6003
6004 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6005 `gnutls_certificate_set_x509_key_file'.
6006
d2127135
JB
60072011-05-05 Juanma Barranquero <lekktu@gmail.com>
6008
6009 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6010 Update dependencies.
6011
e968f4f3
JB
60122011-05-04 Juanma Barranquero <lekktu@gmail.com>
6013
6014 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6015 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6016 Remove unused parameter `fildes'.
6017 * process.c (read_process_output, send_process): Don't pass it.
6018
84d358f0
JB
60192011-05-04 Juanma Barranquero <lekktu@gmail.com>
6020
6021 Fix previous change: the library cache is defined in w32.c.
6022 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6023 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6024
0898ca10
JB
60252011-05-04 Juanma Barranquero <lekktu@gmail.com>
6026
6027 Implement dynamic loading of GnuTLS on Windows.
6028
6029 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6030 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6031 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6032 Declare.
6033
6034 * gnutls.c (Qgnutls_dll): Define.
6035 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6036 (gnutls_*): Declare function pointers.
6037 (init_gnutls_functions): New function to initialize function pointers.
6038 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6039 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6040 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6041 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6042 (emacs_gnutls_write, emacs_gnutls_read)
6043 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6044 (Fgnutls_available_p): New function.
6045 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6046 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6047 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6048
6049 * image.c: Include w32.h.
6050 (Vimage_type_cache): Delete.
6051 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6052 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6053 (w32_delayed_load): Move to w32.c.
6054
6055 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6056
6057 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6058 (w32_delayed_load): Move from image.c. When loading a library, record
6059 its filename in the :loaded-from property of the library id.
6060 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6061 Initialize and staticpro them.
6062 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6063
6064 * process.c: Include lisp.h before w32.h, not after.
6065 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6066 instead of gnutls_record_check_pending.
6067
6068 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6069
ff4de4aa
TZ
60702011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6071
6072 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6073 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6074 as passed in.
6075
abe95abb
JD
60762011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6077
6078 * xterm.c (x_set_frame_alpha): Do not set property on anything
6079 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6080
e16e55d4
JB
60812011-05-02 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6084
bafcf6a5
JB
60852011-05-02 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6088 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6089 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6090 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6091 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6092 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6093 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6094 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6095 (Qgnutls_bootprop_callbacks_verify): Make static.
6096
e7a6747f
AS
60972011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6098
19ed11ba
AS
6099 * callproc.c: Indentation fixup.
6100
e7a6747f 6101 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6102 (wait_for_termination, interruptible_wait_for_termination):
6103 Move after wait_for_termination_1.
e7a6747f 6104
1ef14cb4
LMI
61052011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6106
6107 * sysdep.c (interruptible_wait_for_termination): New function
6108 which is like wait_for_termination, but allows keyboard
6109 interruptions.
6110
6111 * callproc.c (Fcall_process): Add (:file "file") as an option for
6112 the STDOUT buffer.
6113 (Fcall_process_region): Ditto.
6114
330d880c
EZ
61152011-04-30 Eli Zaretskii <eliz@gnu.org>
6116
8db90b73
EZ
6117 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6118 rather than `XVECTOR (FOO)->size'.
6119
330d880c
EZ
6120 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6121 inttypes.h, as a gnulib replacement is used if it not available in
6122 system headers.
6123
15cbd324
EZ
61242011-04-21 Eli Zaretskii <eliz@gnu.org>
6125
6126 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6127 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6128 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6129
6130 * coding.c (coding_alloc_by_realloc): Error out if destination
6131 will grow beyond MOST_POSITIVE_FIXNUM.
6132 (decode_coding_emacs_mule): Abort if there isn't enough place in
6133 charbuf for the composition carryover bytes. Reserve an extra
6134 space for up to 2 characters produced in a loop.
6135 (decode_coding_iso_2022): Abort if there isn't enough place in
6136 charbuf for the composition carryover bytes.
6137
61382011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6139
ae940cca
EZ
6140 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6141 aborting when %lld or %lll format is passed.
6142 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6143 %llo or %llx format is passed. (Bug#8545)
6144
03ab8921
EZ
6145 * window.c (window_scroll_line_based): Use a marker instead of
6146 simple variables to record original value of point. (Bug#7952)
6147
afda1437
EZ
6148 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6149 produced by %s or %c overflows available buffer space. (Bug#8545)
6150
f76dee0c
PE
61512011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6152
6153 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6154 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6155
fdc5744d
JB
61562011-04-28 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6159
638f053a
JB
61602011-04-28 Juanma Barranquero <lekktu@gmail.com>
6161
6162 * keyboard.c (Qdelayed_warnings_hook): Define.
6163 (command_loop_1): Run `delayed-warnings-hook'
6164 if Vdelayed_warnings_list is non-nil.
6165 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6166 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6167
d178f871
EZ
61682011-04-28 Eli Zaretskii <eliz@gnu.org>
6169
6170 * doprnt.c (doprnt): Don't return value smaller than the buffer
6171 size if the message was truncated. (Bug#8545).
6172
b124fd93
JB
61732011-04-28 Juanma Barranquero <lekktu@gmail.com>
6174
6175 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6176 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6177
e810457d
PE
61782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6179
6180 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6181
ea51cceb
JB
61822011-04-27 Juanma Barranquero <lekktu@gmail.com>
6183
6184 * makefile.w32-in: Update dependencies.
6185
94dcfacf
EZ
61862011-04-27 Eli Zaretskii <eliz@gnu.org>
6187
6188 Improve `doprnt' and its usage. (Bug#8545)
6189 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6190 `format_end'. Remove support for %l as a conversion specifier.
6191 Don't use xrealloc. Improve diagnostics when the %l size modifier
6192 is used. Update the commentary.
6193
6194 * eval.c (verror): Simplify calculation of size_t.
6195
6196 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6197 messages.
6198
f61f41d7
PE
61992011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6200
6201 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6202 change.
6203
96fb4434
PE
62042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6205
6206 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6207 This makes this file independent of the recent pseudovector change.
6208
671875da 62092011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6210
69e9b5a3
PE
6211 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6212
b5f869a7 6213 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6214 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6215 Remove unused local.
c8926152 6216 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6217
841a1577 6218 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6219 GCC 4.6.0 optimizes based on type-based alias analysis.
6220 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6221 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6222 != &v->size, and therefore "v->size = 1; b->size = 2; return
6223 v->size;" must therefore return 1. This assumption is incorrect
6224 for Emacs, since it type-puns struct Lisp_Vector * with many other
6225 types. To fix this problem, this patch adds a new type struct
f904488f 6226 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6227 and pseudovectors, and helps optimizing compilers not get fooled
6228 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6229 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6230 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6231 the size member.
eab3844f
PE
6232 (XSETPVECTYPE): Rewrite in terms of new macro.
6233 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6234 This is a bit clearer, and further avoids the possibility of
6235 undesirable aliasing.
6236 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6237 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6238 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6239 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6240 (ASIZE): Now uses header.size rather than size.
6241 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6242 to avoid the hassle of writing XVECTOR (foo)->header.size.
6243 (struct vectorlike_header): New type.
eab3844f
PE
6244 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6245 object, to help avoid aliasing.
6246 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6247 (SUBRP): Likewise, since Lisp_Subr is a special case.
6248 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6249 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6250 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6251 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6252 changed to be "header.size" and "header.next".
6253 * buffer.h (struct buffer): Likewise.
6254 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6255 * frame.h (struct frame): Likewise.
6256 * process.h (struct Lisp_Process): Likewise.
6257 * termhooks.h (struct terminal): Likewise.
6258 * window.c (struct save_window_data, struct saved_window): Likewise.
6259 * window.h (struct window): Likewise.
6260 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6261 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6262 * buffer.c (init_buffer_once): Likewise.
6263 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6264 special case.
6265 * process.c (Fformat_network_address): Use local var for size,
6266 for brevity.
6267
0df1eac5
PE
6268 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6269
847ab9d1 6270 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6271 * data.c (atof): Remove decl; no longer used or needed.
6272 (digit_to_number): Move to lread.c.
6273 (Fstring_to_number): Use new string_to_number function, to be
6274 consistent with how the Lisp reader treats infinities and NaNs.
6275 Do not assume that floating-point numbers represent EMACS_INT
6276 without losing information; this is not true on most 64-bit hosts.
6277 Avoid double-rounding errors, by insisting on integers when
6278 parsing non-base-10 numbers, as the documentation specifies.
6279 * lisp.h (string_to_number): New decl, replacing ...
6280 (isfloat_string): Remove.
bc0a5c13 6281 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6282 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6283 appears to have been a coding error. Similarly, do not accept
6284 strings like +-1e0 as floating point numbers. Do not report
6285 overflow for integer overflows unless the base is not 10 which
6286 means we have no simple and reliable way to continue.
6287 Break out the floating-point parsing into a new
6288 function string_to_number, so that Fstring_to_number parses
6289 floating point numbers consistently with the Lisp reader.
04f2d78b 6290 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6291 (E_CHAR, EXP_INT): Remove, replacing with ...
6292 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6293 (string_to_number): New function, replacing isfloat_string.
6294 This function checks for valid syntax and produces the resulting
6295 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6296 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6297 so that overflow for non-base-10 numbers is reported only when
6298 there's no portable and simple way to convert to floating point.
452f4150 6299
67769ffc
PE
6300 * textprop.c (set_text_properties_1): Rewrite for clarity,
6301 and to avoid GCC warning about integer overflow.
6302
c20db43f
PE
6303 * intervals.h (struct interval): Use EMACS_INT for members
6304 where EMACS_UINT might cause problems. See
6305 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6306 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6307 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6308 All uses changed.
37aa2f85
PE
6309 (offset_intervals): Tell GCC not to worry about length overflow
6310 when negating a negative length.
c20db43f 6311
2538aa2f
PE
6312 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6313 (overrun_check_free): Likewise.
6314
f2d3008d
PE
6315 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6316 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6317 word size.
6318
ec8df744
PE
6319 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6320 (gnutls_make_error): Rename local to avoid shadowing.
6321 (gnutls_emacs_global_deinit): ifdef out; not used.
6322 (Fgnutls_boot): Use const for pointer to readonly storage.
6323 Comment out unused local. Fix pointer signedness problems.
6324
640ee02d
PE
6325 * lread.c (openp): Don't stuff size_t into an 'int'.
6326 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6327 about possible signed overflow.
6328
6048fb2a
PE
6329 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6330 (GDK_KEY_g): Don't define if already defined.
6331 (xg_prepare_tooltip): Avoid pointer signedness problem.
6332 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6333
fa3c87e1
PE
6334 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6335 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6336
2172544b
PE
6337 * xfns.c (Fx_window_property): Simplify a bit,
6338 to make a bit faster and to avoid GCC 4.6.0 warning.
6339 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6340
9b821a21
PE
6341 * fns.c (internal_equal): Don't assume size_t fits in int.
6342
3c616cfa
PE
6343 * alloc.c (compact_small_strings): Tighten assertion a little.
6344
c2982e87
PE
6345 Replace pEd with more-general pI, and fix some printf arg casts.
6346 * lisp.h (pI): New macro, generalizing old pEd macro to other
6347 conversion specifiers. For example, use "...%"pI"d..." rather
6348 than "...%"pEd"...".
6349 (pEd): Remove. All uses replaced with similar uses of pI.
6350 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6351 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6352 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6353 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6354 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6355 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6356 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6357 64-bit hosts.
6358 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6359 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6360 * print.c (safe_debug_print, print_object): Likewise.
6361 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6362 to int.
6f04d126
PE
6363 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6364 avoiding the 0 flag, which is not portable.
c2982e87
PE
6365 * process.c (Fmake_network_process): Use pI to avoid cast.
6366 * region-cache.c (pp_cache): Likewise.
6367 * xdisp.c (decode_mode_spec): Likewise.
6368 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6369 behavior on 64-bit hosts with printf arg.
6f04d126 6370 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6371 (x_stop_queuing_selection_requests): Likewise.
6372 (x_get_window_property): Don't truncate byte count to an 'int'
6373 when tracing.
0b432f21 6374
5e073ec7
PE
6375 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6376 here, since it parses constructs like leading '-' and spaces,
6377 which are not wanted; and it overflows with large numbers.
6378 Instead, simply match F[0-9]+, which is what is wanted anyway.
6379
36372bf9
PE
6380 * alloc.c: Remove unportable assumptions about struct layout.
6381 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6382 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6383 (allocate_vectorlike, make_pure_vector): Use the new macros,
6384 plus offsetof, to remove unportable assumptions about struct layout.
6385 These assumptions hold on all porting targets that I know of, but
6386 they are not guaranteed, they're easy to remove, and removing them
6387 makes further changes easier.
6388
0b432f21
PE
6389 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6390 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6391 (string_overrun_cookie): Now const. Use initializers that
6392 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6393 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6394 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6395 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6396 multiple of sizeof (EMACS_INT); it need not be, if
6397 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6398 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6399
895009e1
JB
64002011-04-26 Juanma Barranquero <lekktu@gmail.com>
6401
6402 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6403
6a7a1b0b
TZ
64042011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6405
6406 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6407 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6408 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6409
841a1577 64102011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6411
6412 * lisp.h (Qdebug): List symbol.
895009e1 6413 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6414 * keyboard.c (debug-on-event): New variable.
6415 (handle_user_signal): Break into debugger when debug-on-event
6416 matches the current signal symbol.
6417
f2d3ba6f
DN
64182011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6419
6420 * alloc.c (check_sblock, check_string_bytes)
6421 (check_string_free_list): Convert to standard C.
6422
42ce4c63
TZ
64232011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6424
6425 * w32.c (emacs_gnutls_push): Fix typo.
6426
825cd63c
EZ
64272011-04-25 Eli Zaretskii <eliz@gnu.org>
6428
fb11d64d
EZ
6429 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6430 "cast to pointer from integer of different size".
6431
825cd63c
EZ
6432 Improve doprnt and its use in verror. (Bug#8545)
6433 * doprnt.c (doprnt): Document the set of format control sequences
6434 supported by the function. Use SAFE_ALLOCA instead of always
6435 using `alloca'.
6436
6437 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6438 is one byte too soon. Don't use xrealloc; instead xfree and
6439 xmalloc anew.
6440
e061a11b
TZ
64412011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6442
6443 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6444 callbacks stage.
6445
6446 * gnutls.c: Renamed global_initialized to
6447 gnutls_global_initialized. Added internals for the
6448 :verify-hostname-error, :verify-error, and :verify-flags
6449 parameters of `gnutls-boot' and documented those parameters in the
6450 docstring. Start callback support.
9173deec
JB
6451 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6452 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6453 on error. Return error code.
e061a11b
TZ
6454 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6455 (emacs_gnutls_read): Likewise.
6456 (Fgnutls_boot): Return handshake error code.
6457 (emacs_gnutls_handle_error): New function.
6458 (wsaerror_to_errno): Likewise.
6459
6460 * w32.h (emacs_gnutls_pull): Add prototype.
6461 (emacs_gnutls_push): Likewise.
6462
6463 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6464 (emacs_gnutls_push): Likewise.
6465
64662011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6467
6468 * process.c (wait_reading_process_output): Check if GnuTLS
6469 buffered some data internally if no FDs are set for TLS
6470 connections.
6471
6472 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6473 (LIBS): Link to USER_LIBS.
6474 ($(BLD)/gnutls.$(0)): New target.
6475
fa6996bc
EZ
64762011-04-24 Eli Zaretskii <eliz@gnu.org>
6477
eb35682e
EZ
6478 * xdisp.c (handle_single_display_spec): Rename the
6479 display_replaced_before_p argument into display_replaced_p, to
6480 make it consistent with the commentary. Fix typos in the
6481 commentary.
6482
e2ad650c
EZ
6483 * textprop.c (syms_of_textprop): Remove dead code.
6484 (copy_text_properties): Delete obsolete commentary about an
6485 interface that was deleted long ago. Fix typos in the description
6486 of arguments.
6487
1b2de274
EZ
6488 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6489 to changes in oldXMenu/XMenu.h from 2011-04-16.
6490 <menu_help_message, prev_menu_help_message>: Constify.
6491 (IT_menu_make_room): menu->help_text is now `const char **';
6492 adjust.
6493
6494 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6495 to changes in oldXMenu/XMenu.h from 2011-04-16.
6496 (struct XMenu): Declare `help_text' `const char **'.
6497
6498 * xfaces.c <Qunspecified>: Make extern again.
6499
6500 * syntax.c: Include sys/types.h before including regex.h, as
6501 required by Posix.
6502
762b15be
EZ
6503 * doc.c (get_doc_string): Improve the format passed to `error'.
6504
6505 * doprnt.c (doprnt): Improve commentary.
6506
6507 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6508
6509 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6510 them with etags.
6511
f1052e5d
EZ
6512 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6513 changes in globals.h immediately force recompilation.
762b15be
EZ
6514 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6515 $(CURDIR)/s/ms-w32.h.
6516 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6517
fa6996bc
EZ
6518 * character.c (Fchar_direction): Function deleted.
6519 (syms_of_character): Don't defsubr it.
6520 <char-direction-table>: Deleted.
6521
e6c3da20
EZ
65222011-04-23 Eli Zaretskii <eliz@gnu.org>
6523
6524 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6525 * doprnt.c: Include limits.h.
6526 (SIZE_MAX): New macro.
04f2d78b
CB
6527 (doprnt): Return a size_t value. 2nd arg is now size_t.
6528 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6529 Improve overflow protection. Support `l' modifier for integer
6530 conversions. Support %l conversion. Don't assume an EMACS_INT
6531 argument for integer conversions and for %c.
6532
6533 * lisp.h (doprnt): Restore prototype.
6534
6535 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6536 $(SRC)/character.h.
6537
6538 * Makefile.in (base_obj): Add back doprnt.o.
6539
6540 * deps.mk (doprnt.o): Add back prerequisites.
6541 (callint.o): Depend on character.h.
6542
6543 * eval.c (internal_lisp_condition_case): Include the handler
6544 representation in the error message.
6545 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6546 when breaking from the loop.
6547
6548 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6549
6550 * callint.c (Fcall_interactively): When displaying error message
6551 about invalid control letter, pass the character's codepoint, not
6552 a pointer to its multibyte form. Improve display of the character
6553 in octal and display also its hex code.
6554
6555 * character.c (char_string): Use %x to display the (unsigned)
6556 codepoint of an invalid character, to avoid displaying a bogus
6557 negative value.
6558
6559 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6560 `error', not SYMBOL_NAME itself.
6561
6562 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6563 character arguments to `error'.
6564
6565 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6566 to `error' in error message about FINAL_CHAR argument. Make sure
6567 FINAL_CHAR is a character, and use %c when it is passed as
6568 argument to `error'.
6569
4ffd0d6b 65702011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6571
6572 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6573
6574 * w32.c: Include <time.h>.
6575 (sys_localtime): New function.
6576
4ffd0d6b 65772011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6578
6579 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6580
4ffd0d6b 6581 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6582
4ffd0d6b 65832011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6584
4ffd0d6b
GM
6585 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6586 zombies (Bug#8467).
aac0c6e3 6587
04c56954
EZ
65882011-04-19 Eli Zaretskii <eliz@gnu.org>
6589
6590 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6591 gl_state.e_property when gl_state.object is Qt.
6592
6593 * insdel.c (make_gap_larger): Remove limitation of buffer size
6594 to <= INT_MAX.
6595
16a43933
CY
65962011-04-18 Chong Yidong <cyd@stupidchicken.com>
6597
6598 * xdisp.c (lookup_glyphless_char_display)
6599 (produce_glyphless_glyph): Handle cons cell entry in
6600 glyphless-char-display.
6601 (Vglyphless_char_display): Document it.
6602
6603 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6604 glyphless-char-display.
6605
4581706e
CY
66062011-04-17 Chong Yidong <cyd@stupidchicken.com>
6607
6608 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6609
6610 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6611
6612 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6613 definition for no-X builds.
6614
4887c6e2 66152011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6616
fd35b6f9
PE
6617 Static checks with GCC 4.6.0 and non-default toolkits.
6618
5c1ccb01
PE
6619 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6620
006c5daa
PE
6621 * process.c (keyboard_bit_set): Define only if SIGIO.
6622 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6623 (send_process): Repair possible setjmp clobbering.
6624
efc736d3
PE
6625 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6626
4e2fe2e6
PE
6627 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6628
f97334a2
PE
6629 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6630
4e75f29d
PE
6631 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6632 Define only if needed.
6633
90efadd1
PE
6634 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6635 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6636 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6637
3c647824
PE
6638 * dispextern.h (struct redisplay_interface): Rename param
6639 to avoid shadowing.
e264f262 6640 * termhooks.h (struct terminal): Likewise.
761383f4 6641 * xterm.c (xembed_send_message): Likewise.
3c647824 6642
b58c5c4a
PE
6643 * insdel.c (make_gap_smaller): Define only if
6644 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6645
cad59032
PE
6646 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6647 it.
6648
c339dc2e
PE
6649 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6650 so that we aren't warned about unused symbols.
6651
91a3e27b
PE
6652 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6653
399c71d3 6654 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6655
8ffc96f5
PE
6656 * xfns.c (x_real_positions): Mark locals as initialized.
6657
eef9bc79
PE
6658 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6659
098db9dd
PE
6660 * xterm.c: Fix problems found by static analysis with other toolkits.
6661 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6662 (x_dispatch_event): Declare static if USE_GTK, and
6663 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6664 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6665 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6666 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6667 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6668
eb18f6cc
PE
6669 * xmenu.c (menu_help_callback): Pointer type fixes.
6670 Use const pointers when pointing at readonly data. Avoid pointer
6671 signedness clashes.
6672 (FALSE): Remove unused macro.
6673 (update_frame_menubar): Remove unused decl.
6674
1fe72bf8
PE
6675 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6676
60d9e1db
PE
6677 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6678 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6679 (single_menu_item): Rename local to avoid shadowing.
6680
39261c26
PE
6681 * keyboard.c (make_lispy_event): Remove unused local var.
6682
018c5e19
PE
6683 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6684 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6685
63d2b86e
PE
6686 * bitmaps: Change bitmaps from unsigned char back to the X11
6687 compatible char. Avoid the old compiler warnings about
6688 out-of-range initializers by using, for example, '\xab' rather
6689 than 0xab.
6690
aefd87e1
PE
6691 * xgselect.c (xgselect_initialize): Check vs interface
6692 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6693
bf501fb9
PE
6694 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6695
e9829fdf
PE
6696 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6697 to read-only memory.
6698
1086c095
PE
6699 * fns.c (vector): Remove; this old hack is no longer needed.
6700
2baccd04 6701 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6702 Remove unused var.
dde42981 6703 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6704
72391843 6705 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6706
436c16df 6707 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6708 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6709 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6710
92bb796d 6711 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6712 (x_term_init): Remove local to avoid shadowing.
92bb796d 6713
764430a3 6714 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6715
6716 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6717 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6718
d1dfb56c
EZ
67192011-04-16 Eli Zaretskii <eliz@gnu.org>
6720
c4354cb4
EZ
6721 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6722
d1dfb56c
EZ
6723 Fix regex.c, syntax.c and friends for buffers > 2GB.
6724 * syntax.h (struct gl_state_s): Declare character position members
6725 EMACS_INT.
6726
6727 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6728
04f2d78b
CB
6729 * textprop.c (verify_interval_modification, interval_of):
6730 Declare arguments EMACS_INT.
d1dfb56c
EZ
6731
6732 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6733 EMACS_INT.
6734
6735 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6736
6737 * indent.c (Fvertical_motion): Local variable it_start is now
6738 EMACS_INT.
6739
6740 * regex.c (re_match, re_match_2, re_match_2_internal)
6741 (bcmp_translate, regcomp, regexec, print_double_string)
6742 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6743 (re_compile_pattern, re_exec): Declare arguments and local
6744 variables `size_t' and `ssize_t' and return values `regoff_t', as
6745 appropriate.
6746 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6747 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6748 <compile_stack_type>: `size' and `avail' are now `size_t'.
6749
6750 * regex.h <regoff_t>: Use ssize_t, not int.
6751 (re_search, re_search_2, re_match, re_match_2): Arguments that
6752 specify buffer/string position and length are now ssize_t and
6753 size_t. Return type is regoff_t.
6754
613052cd
BK
67552011-04-16 Ben Key <bkey76@gmail.com>
6756
6757 * nsfont.m: Fixed bugs in ns_get_family and
6758 ns_descriptor_to_entity that were caused by using free to
6759 deallocate memory blocks that were allocated by xmalloc (via
6760 xstrdup). This caused Emacs to crash when compiled with
6761 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6762 --enable-checking=xmallocoverrun). xfree is now used to
6763 deallocate these memory blocks.
6764
4170f62f 67652011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6766
71b41406
PE
6767 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6768
9587a89d
PE
6769 emacs_write: Accept and return EMACS_INT for sizes.
6770 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6771 et seq.
6772 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6773 Accept and return EMACS_INT.
6774 (emacs_gnutls_write): Return the number of bytes written on
6775 partial writes.
6776 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6777 (emacs_read, emacs_write): Remove check for negative size, as the
6778 Emacs source code has been audited now.
9587a89d
PE
6779 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6780 (emacs_read, emacs_write): Use it.
273a5f82
PE
6781 * process.c (send_process): Adjust to the new signatures of
6782 emacs_write and emacs_gnutls_write. Do not attempt to store
6783 a byte offset into an 'int'; it might overflow.
9587a89d 6784 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6785
3e047f51
PE
6786 * sound.c: Don't assume sizes fit in 'int'.
6787 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6788 Return EMACS_INT, not int.
3e047f51 6789 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6790 Accept EMACS_INT, not int.
6791 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6792 record read return values.
6793
cc39a9db
BK
67942011-04-15 Ben Key <bkey76@gmail.com>
6795
c9d0ec6d
JB
6796 * keyboard.c (Qundefined): Don't declare static since it is used
6797 in nsfns.m.
6798 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6799 static since they are used in nsfont.m.
cc39a9db 6800
6c60eb9f
SM
68012011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6802
6803 * process.c (Qprocessp): Don't declare static.
6804 * lisp.h (Qprocessp): Declare again.
6805
7990b61a
JB
68062011-04-15 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6809
5d4cb038
PE
68102011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6811
8bd7b830 6812 Improve C-level modularity by making more things 'static'.
cd64ea1d 6813
e3b27b31
PE
6814 Don't publish debugger-only interfaces to other modules.
6815 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6816 (verify_bytepos, count_markers): Move decls to the only modules
6817 that need them.
6818 * region-cache.h (pp_cache): Likewise.
6819 * window.h (check_all_windows): Likewise.
6820 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6821
5d4cb038
PE
6822 * sysdep.c (croak): Now static, if
6823 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6824 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6825
6826 * alloc.c (refill_memory_reserve): Now static if
6827 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6828 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6829
e87b6180
PE
6830 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6831 Define only if USE_LUCID.
6832
ac64929e
PE
6833 * xrdb.c (x_customization_string, x_rm_string): Now static.
6834
6f37259d
PE
6835 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6836 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6837
1683e3ab
PE
6838 * xdisp.c (draw_row_with_mouse_face): Now static.
6839 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6840
de9c2632
PE
6841 * window.h (check_all_windows): Mark externally visible.
6842
2b96acb7
PE
6843 * window.c (window_deletion_count): Now static.
6844
6845 * undo.c: Make symbols static if they're not exported.
6846 (last_undo_buffer, last_boundary_position, pending_boundary):
6847 Now static.
6848
50436f33
PE
6849 * textprop.c (interval_insert_behind_hooks): Now static.
6850 (interval_insert_in_front_hooks): Likewise.
6851
64520e5c
PE
6852 * term.c: Make symbols static if they're not exported.
6853 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6854 (max_frame_lines, tty_set_terminal_modes):
6855 (tty_reset_terminal_modes, tty_turn_off_highlight):
6856 (get_tty_terminal): Now static.
6857 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6858 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6859 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6860 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6861 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6862
1fa53021
PE
6863 * sysdep.c: Make symbols static if they're not exported.
6864 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6865 Now static.
6866 (sigprocmask_set, full_mask): Remove; unused.
6867 (wait_debugging): Mark as visible.
6868 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6869 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6870
d4b43b22
PE
6871 * syntax.c (syntax_temp): Define only if !__GNUC__.
6872
b7c513d0
PE
6873 * sound.c (current_sound_device, current_sound): Now static.
6874
989b29ad
PE
6875 * search.c (searchbufs, searchbuf_head): Now static.
6876
13a55a78
PE
6877 * scroll.c (scroll_cost): Remove; unused.
6878 * dispextern.h (scroll_cost): Remove decl.
6879
de68a1fc
PE
6880 * region-cache.h (pp_cache): Mark as externally visible.
6881
40ccffa6
PE
6882 * process.c: Make symbols static if they're not exported.
6883 (process_tick, update_tick, create_process, chan_process):
6884 (Vprocess_alist, proc_buffered_char, datagram_access):
6885 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6886 (deactivate_process): Mark defn as static, as well as decl.
6887 * lisp.h (create_process): Remove decl.
6888 * process.h (chan_process, Vprocess_alist): Remove decls.
6889
ad64fc97
PE
6890 * print.c: Make symbols static if they're not exported.
6891 (print_depth, new_backquote_output, being_printed, print_buffer):
6892 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6893 (print_interval, print_number_index, initial_stderr_stream):
6894 Now static.
6895 * lisp.h (Fprinc): Remove decl.
6896 (debug_output_compilation_hack): Mark as externally visible.
6897
adddb265
PE
6898 * sysdep.c (croak): Move decl from here to syssignal.h.
6899 * syssignal.h (croak): Put it here, so the API can be checked when
6900 'croak' is called from dissociate_if_controlling_tty.
6901
1717ede2
PE
6902 * minibuf.c: Make symbols static if they're not exported.
6903 (minibuf_save_list, choose_minibuf_frame): Now static.
6904 * lisp.h (choose_minibuf_frame): Remove decl.
6905
fa5fb2bc
PE
6906 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6907
1e3890d1
PE
6908 * lread.c: Make symbols static if they're not exported.
6909 (read_objects, initial_obarray, oblookup_last_bucket_number):
6910 Now static.
6911 (make_symbol): Remove; unused.
6912 * lisp.h (initial_obarray, make_symbol): Remove decls.
6913
8a1414fa
PE
6914 * keyboard.c: Make symbols static if they're not exported.
6915 (single_kboard, recent_keys_index, total_keys, recent_keys):
6916 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6917 (this_single_command_key_start, echoing, last_auto_save):
6918 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6919 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6920 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6921 (Vlispy_mouse_stem, double_click_count):
6922 Now static.
6923 (force_auto_save_soon): Define only if SIGDANGER.
6924 (ignore_mouse_drag_p): Now static if
6925 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6926 (print_help): Remove; unused.
6927 (stop_character, last_timer_event): Mark as externally visible.
6928 * keyboard.h (ignore_mouse_drag_p): Declare only if
6929 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6930 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6931 * lisp.h (echoing): Remove decl.
6932 (force_auto_save_soon): Declare only if SIGDANGER.
6933 * xdisp.c (redisplay_window): Simplify code, to make it more
6934 obvious that ignore_mouse_drag_p is not accessed if !defined
6935 USE_GTK && !defined HAVE_NS.
6936
93ea6e8f
PE
6937 * intervals.c: Make symbols static if they're not exported.
6938 (merge_properties_sticky, merge_interval_right, delete_interval):
6939 Now static.
6940 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6941
77382fcc
PE
6942 * insdel.c: Make symbols static if they're not exported.
6943 However, leave prepare_to_modify_buffer alone. It's never
6944 called from outside this function, but that appears to be a bug.
6945 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6946 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6947 (adjust_after_replace_noundo): Remove; unused.
6948 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6949 (signal_before_change): Remove decls.
77382fcc 6950
9306c32e
PE
6951 * indent.c (val_compute_motion, val_vmotion): Now static.
6952
cd44d2eb
PE
6953 * image.c: Make symbols static if they're not exported.
6954 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6955 if USE_GTK.
6956 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6957 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6958
ad9a7a06
PE
6959 * fringe.c (standard_bitmaps): Now static.
6960 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6961
81626931
PE
6962 * frame.c: Make symbols static if they're not exported.
6963 (x_report_frame_params, make_terminal_frame): Now static.
6964 (get_frame_param): Now static, unless HAVE_NS.
6965 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6966 (x_get_resource_string): Remove; not used.
6967 * frame.h (make_terminal_frame, x_report_frame_params):
6968 (x_get_resource_string); Remove decls.
6969 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6970 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6971
239f9db9
PE
6972 * font.c, fontset.c: Make symbols static if they're not exported.
6973 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6974 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6975 * font.c (font_close_object): Now static.
6976 * font.h (font_close_object): Remove.
6977 * fontset.c (FONTSET_OBJLIST): Remove.
6978 (free_realized_fontset) #if-0 the body, which does nothing.
6979 (face_suitable_for_char_p): #if-0, as it's never called.
6980 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6981 * xfaces.c (face_at_string_position):
6982 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6983 since 0 is always ASCII.
6984
dfcf3579
PE
6985 * fns.c (weak_hash_tables): Now static.
6986
5045092b
PE
6987 * fileio.c: Make symbols static if they're not exported.
6988 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6989 (Vwrite_region_annotation_buffers): Now static.
6990
57a96f5c
PE
6991 * eval.c: Make symbols static if they're not exported.
6992 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6993 * lisp.h (backtrace_list): Remove decl.
6994
35f08c38
PE
6995 * emacs.c: Make symbols static if they're not exported.
6996 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6997 (fatal_error_code, fatal_error_signal_hook, standard_args):
6998 Now static.
6999 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7000 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7001 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7002 * lisp.h (fatal_error_signal_hook): Remove decl.
7003 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7004
f44bd759
PE
7005 * editfns.c: Move a (normally-unused) function to its only use.
7006 * editfns.c, lisp.h (get_operating_system_release): Remove.
7007 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7008 worth the hassle of breaking this out.
7009
b532497d
PE
7010 * xterm.c: Make symbols static if they're not exported.
7011 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7012 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7013 (x_destroy_window, x_delete_display):
7014 Now static.
7015 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7016 (x_mouse_leave): Remove; unused.
7017 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7018 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7019 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7020 Remove decls.
7021 (x_mouse_leave): Declare only if WINDOWSNT.
7022 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7023 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7024 USE_X_TOOLKIT.
7025
1675728f
PE
7026 * ftxfont.c: Make symbols static if they're not exported.
7027 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7028 HAVE_FREETYPE.
7029 * font.h (ftxfont_driver): Likewise.
7030
e4cebfca
PE
7031 * xfns.c: Make symbols static if they're not exported.
7032 (x_last_font_name, x_display_info_for_name):
7033 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7034 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7035 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7036 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7037 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7038 (last_show_tip_args): Now static.
7039 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7040 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7041 (x_screen_planes): Remove; unused.
7042 * dispextern.h (x_screen_planes): Remove decl.
7043
5bf46f05
PE
7044 * dispnew.c: Make symbols static if they're not exported.
7045 * dispextern.h (redraw_garbaged_frames, scrolling):
7046 (increment_row_positions): Remove.
7047 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7048 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7049 Now static.
7050 (redraw_garbaged_frames): Remove; unused.
7051
435f4c28
PE
7052 * xfaces.c: Make symbols static if they're not exported.
7053 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7054 Remove decls.
7055 * xterm.h (defined_color): Remove decls.
7056 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7057 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7058 (menu_face_changed_default, defined_color, free_realized_face):
7059 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7060 (ascii_face_of_lisp_face): Remove; unused.
7061
8524aef3
PE
7062 * xdisp.c: Make symbols static if they're not exported.
7063 * dispextern.h (scratch_glyph_row, window_box_edges):
7064 (glyph_to_pixel_coords, set_cursor_from_row):
7065 (get_next_display_element, set_iterator_to_next):
7066 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7067 (show_mouse_face): Remove decls
7068 * frame.h (message_buf_print): Likewise.
7069 * lisp.h (pop_message, set_message, check_point_in_composition):
7070 Likewise.
7071 * xterm.h (set_vertical_scroll_bar): Likewise.
7072 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7073 (message_buf_print, scratch_glyph_row, displayed_buffer):
7074 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7075 (get_next_display_element, show_mouse_face, window_box_edges):
7076 (frame_to_window_pixel_xy, check_point_in_composition):
7077 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7078 (glyph_to_pixel_coords): Remove; unused.
7079
16390cd2
PE
7080 * dired.c (file_name_completion): Now static.
7081
7082 * dbusbind.c (xd_in_read_queued_messages): Now static.
7083
a25f4dfa
PE
7084 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7085 * data.c (circular_list_error): Remove.
7086
14a9c8df
PE
7087 * commands.h (last_point_position, last_point_position_buffer):
7088 (last_point_position_window): Remove decls.
7089 * keyboard.c: Make these variables static.
7090
04f2d78b
CB
7091 * coding.h (coding, code_convert_region, encode_coding_gap):
7092 Remove decls.
74ab6df5
PE
7093 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7094 (iso_code_class, detect_coding, code_convert_region): Now static.
7095 (encode_coding_gap): Remove; unused.
7096
38dfbee1
PE
7097 * chartab.c (chartab_chars, chartab_bits): Now static.
7098
a2cb4e63
PE
7099 * charset.h (charset_iso_8859_1): Remove decl.
7100 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7101 Now static.
7102
127198fd
PE
7103 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7104 * ccl.c (Vccl_program_table): Now static.
7105 (check_ccl_update): Remove; unused.
7106
d85b608f
PE
7107 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7108 * category.h: ... from here.
7109 * category.c (check_category_table, set_category_set): Now static.
7110
31cd66f3
PE
7111 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7112 * lisp.h: Remove these decls.
7113
c358e587
PE
7114 * buffer.c (buffer_count): Remove unused var.
7115
e78aecca
PE
7116 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7117 so that it's not optimized away.
7118 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7119 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7120 exported only to the debugger.
7121
e192d7d3 7122 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7123 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7124
92470028
PE
7125 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7126 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7127 was inaccessible from Lisp.
7128 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7129 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7130
244ed907
PE
7131 alloc.c: Import and export fewer symbols, and remove unused items.
7132 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7133 is defined.
7134 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7135 it's not optimized away by whole-program optimization.
7136 (message_enable_multibyte, free_misc): Remove.
7137 (catchlist, handlerlist, mark_backtrace):
7138 Declare only if BYTE_MARK_STACK.
7139 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7140 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7141 (message_enable_multibyte): Remove decl.
7142 (free_misc, interval_free_list, float_block, float_block_index):
7143 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7144 (cons_free_list, last_marked_index):
7145 Now static.
7146 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7147 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7148 (mark_backtrace): Define only if BYTE_MARK_STACK.
7149 * xdisp.c (message_enable_multibyte): Now static.
7150
61c2b50e 7151 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7152 This makes it easier for human readers (and static analyzers)
7153 to see whether these variables are used from other modules.
7154 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7155 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7156 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7157 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7158 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7159 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7160 * xmenu.c, xselect.c:
7161 Declare Q* vars static if they are not used in other modules.
7162 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7163 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7164 Remove decls of unexported vars.
7165 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7166
95c82688
PE
7167 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7168
16a97296
PE
7169 Make Emacs functions such as Fatom 'static' by default.
7170 This makes it easier for human readers (and static analyzers)
7171 to see whether these functions can be called from other modules.
7172 DEFUN now defines a static function. To make the function external
7173 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7174 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7175 (Finit_image_library):
16a97296
PE
7176 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7177 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7178 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7179 Remove decls, since these functions are now static.
7180 (Funintern, Fget_internal_run_time): New decls, since these functions
7181 were already external.
95c82688 7182
16a97296
PE
7183 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7184 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7185 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7186 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7187 * keyboard.c, keymap.c, lread.c:
7188 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7189 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7190 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7191 Mark functions with DEFUE instead of DEFUN,
7192 if they are used in other modules.
7193 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7194 decls for now-static functions.
7195 * buffer.h (Fdelete_overlay): Remove decl.
7196 * callproc.c (Fgetenv_internal): Mark as internal.
7197 * composite.c (Fremove_list_of_text_properties): Remove decl.
7198 (Fcomposition_get_gstring): New forward static decl.
7199 * composite.h (Fcomposite_get_gstring): Remove decl.
7200 * dired.c (Ffile_attributes): New forward static decl.
7201 * doc.c (Fdocumntation_property): New forward static decl.
7202 * eval.c (Ffetch_bytecode): New forward static decl.
7203 (Funintern): Remove extern decl; now in .h file where it belongs.
7204 * fileio.c (Fmake_symbolic_link): New forward static decl.
7205 * image.c (Finit_image_library): New forward static decl.
7206 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7207 * intervals.h (Fprevious_property_change):
7208 (Fremove_list_of_text_properties): Remove decls.
7209 * keyboard.c (Fthis_command_keys): Remove decl.
7210 (Fcommand_execute): New forward static decl.
7211 * keymap.c (Flookup_key): New forward static decl.
7212 (Fcopy_keymap): Now static.
7213 * keymap.h (Flookup_key): Remove decl.
7214 * process.c (Fget_process): New forward static decl.
7215 (Fprocess_datagram_address): Mark as internal.
7216 * syntax.c (Fsyntax_table_p): New forward static decl.
7217 (skip_chars): Remove duplicate decl.
7218 * textprop.c (Fprevious_property_change): New forward static decl.
7219 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7220 Now internal.
7221 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7222 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7223
785bbd42
PE
7224 * editfns.c (Fformat): Remove unreachable code.
7225
8b913b57
AS
72262011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7227
7228 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7229 change. (Bug#8496)
7230
a6744a35
EZ
72312011-04-13 Eli Zaretskii <eliz@gnu.org>
7232
7233 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7234 when at ZV. (Bug#8487)
7235
e7974947
AS
72362011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7237
baad03f0
AS
7238 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7239 (Bug#8437)
7240 * keyboard.c (parse_tool_bar_item): Likewise.
7241 * sound.c (sound_cleanup, alsa_close): Likewise.
7242 * termcap.c (tgetent): Likewise.
7243 * xfns.c (x_default_font_parameter): Likewise.
7244 * xsettings.c (read_and_apply_settings): Likewise.
7245
e7974947
AS
7246 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7247 (overrun_check_free): Protoize.
7248
28272684
PE
72492011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7250
7251 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7252 since callers should never pass a negative size.
7253 Change the signature to match that of plain 'read' and 'write'; see
7254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7255 * lisp.h: Update prototypes of emacs_write and emacs_read.
7256
11997c76
EZ
72572011-04-11 Eli Zaretskii <eliz@gnu.org>
7258
7259 * xdisp.c (redisplay_window): Don't try to determine the character
7260 position of the scroll margin if the window start point w->startp
e896f03c 7261 is outside the buffer's accessible region. (Bug#8468)
11997c76 7262
8a2cbd72
EZ
72632011-04-10 Eli Zaretskii <eliz@gnu.org>
7264
7265 Fix write-region and its subroutines for buffers > 2GB.
7266 * fileio.c (a_write, e_write): Modify declaration of arguments and
7267 local variables to support buffers larger than 2GB.
7268 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7269
7270 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7271 argument, local variables, and return value.
7272
7273 * lisp.h: Update prototypes of emacs_write and emacs_read.
7274
7275 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7276
4073e537 72772011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7278
1ebfdcb6
PE
7279 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7280
b2ded58d
PE
7281 Fix more problems found by GCC 4.6.0's static checks.
7282
7d66342c
PE
7283 * xdisp.c (vmessage): Use a better test for character truncation.
7284
bbf47d44
PE
7285 * charset.c (load_charset_map): <, not <=, for optimization,
7286 and to avoid potential problems with integer overflow.
9248994d 7287 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7288 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7289 * editfns.c (Fformat): Likewise.
1e69125e 7290 * syntax.c (skip_chars): Likewise.
3befa583 7291
e3019616
PE
7292 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7293 This also lets GCC 4.6.0 generate slightly better loop code.
7294
becfa255
PE
7295 * callint.c (Fcall_interactively): <, not <=, for optimization.
7296 (Fcall_interactively): Count the number of arguments produced,
7297 not the number of arguments given. This is simpler and lets GCC
7298 4.6.0 generate slightly better code.
7299
dae0cd48
PE
7300 * ftfont.c: Distingish more carefully between FcChar8 and char.
7301 The previous code passed unsigned char * to a functions like
7302 strlen and xstrcasecmp that expect char *, which does not
7303 conform to the C standard.
7304 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7305 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7306 char * when the C standard requires it.
7307
76032d70
PE
7308 * keyboard.c (read_char): Remove unused var.
7309
eb3f1cc8
PE
7310 * eval.c: Port to Windows vsnprintf (Bug#8435).
7311 Include <limits.h>.
7312 (SIZE_MAX): Define if the headers do not.
7313 (verror): Do not give up if vsnprintf returns a negative count.
7314 Instead, grow the buffer. This ports to Windows vsnprintf, which
7315 does not conform to C99. Problem reported by Eli Zaretskii.
7316 Also, simplify the allocation scheme, by avoiding the need for
7317 calling realloc, and removing the ALLOCATED variable.
7318
70476b54
PE
7319 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7320
12020a9e
PE
7321 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7322 But keep the doprint source code for now, as we might revamp it
7323 and use it again (Bug#8435).
ea6c7ae6
PE
7324 * lisp.h (doprnt): Remove.
7325 * Makefile.in (base_obj): Remove doprnt.o.
7326 * deps.mk (doprnt.o): Remove.
7327
5fdb398c
PE
7328 error: Print 32- and 64-bit integers portably (Bug#8435).
7329 Without this change, on typical 64-bit hosts error ("...%d...", N)
7330 was used to print both 32- and 64-bit integers N, which relied on
7331 undefined behavior.
7332 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7333 New macro.
7334 * lisp.h (error, verror): Mark as printf-like functions.
7335 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7336 Report overflow in size calculations when allocating printf buffer.
7337 Do not truncate output string at its first null byte.
7338 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7339 Truncate the output at a character boundary, since vsnprintf does not
7340 do that.
7341 * charset.c (check_iso_charset_parameter): Convert internal
7342 character to string before calling 'error', since %c now has the
7343 printf meaning.
7344 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7345 overflow when computing char to be passed to 'error'. Do not
7346 pass Lisp_Object to 'error'; pass the integer instead.
7347 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7348 formatted with plain %d.
7349
b189fa66
PE
7350 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7351
bff87ef0
PE
7352 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7353
7e2cac20
PE
7354 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7355
ce4d90b5
PE
7356 * xterm.c (x_catch_errors): Remove duplicate declaration.
7357
266c9547
PE
7358 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7359
79c49ad2
PE
7360 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7361
368f4090
JM
73622011-04-10 Jim Meyering <meyering@redhat.com>
7363
7364 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7365 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7366 return ssize_t not "int", and use size_t as the buffer length.
7367 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7368 * gnutls.h: Update declarations.
7369 * process.c (read_process_output): Use ssize_t, to match.
7370 (send_process): Likewise.
7371
a32d4040
CY
73722011-04-09 Chong Yidong <cyd@stupidchicken.com>
7373
7374 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7375
8546720e 73762011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7377
04f2d78b
CB
7378 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7379 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7380
8546720e
GM
7381 * xterm.c (handle_one_xevent):
7382 * xmenu.c (create_and_show_popup_menu):
7383 * xselect.c (x_decline_selection_request)
7384 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7385
0a2f5c1a 73862011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7387
7388 Fix some uses of `int' instead of EMACS_INT.
7389 * search.c (string_match_1, fast_string_match)
7390 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7391 (scan_buffer, find_next_newline_no_quit)
7392 (find_before_next_newline, search_command, Freplace_match)
7393 (Fmatch_data): Make some `int' variables be EMACS_INT.
7394
7395 * xdisp.c (display_count_lines): 3rd argument and return value now
7396 EMACS_INT. All callers changed.
7397 (pint2hrstr): Last argument is now EMACS_INT.
7398
7399 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7400 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7401 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7402 (decode_coding_utf_16, decode_coding_emacs_mule)
7403 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7404 (decode_coding_ccl, decode_coding_charset)
7405 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7406 (decode_coding_iso_2022, decode_coding_emacs_mule)
7407 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7408 <char_offset, last_offset>: Declare EMACS_INT.
7409 (encode_coding_utf_8, encode_coding_utf_16)
7410 (encode_coding_emacs_mule, encode_invocation_designation)
7411 (encode_designation_at_bol, encode_coding_iso_2022)
7412 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7413 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7414 Declare EMACS_INT.
7415 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7416 (encode_invocation_designation): Last argument P_NCHARS is now
7417 EMACS_INT.
7418 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7419 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7420
7421 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7422 All users changed.
7423
7424 * ccl.c (Fccl_execute_on_string): Declare some variables
7425 EMACS_INT.
7426
8546720e 74272011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7428
7429 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7430
4e19a977
CS
74312011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7432
7433 * process.c (Fformat_network_address): Doc fix.
7434
87302331
R
74352011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7436
ee7683eb 7437 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7438
cbb59342
CY
74392011-04-08 Chong Yidong <cyd@stupidchicken.com>
7440
7441 * keyboard.c (read_char): Call Lisp function help-form-show,
7442 instead of using internal_with_output_to_temp_buffer.
7443 (Qhelp_form_show): New var.
e0d38eeb 7444 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7445
7446 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7447
7448 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7449
e67a13ab
CY
74502011-04-06 Chong Yidong <cyd@stupidchicken.com>
7451
04f2d78b
CB
7452 * process.c (Flist_processes): Remove to Lisp.
7453 (list_processes_1): Delete.
e67a13ab 7454
973f782d
EZ
74552011-04-06 Eli Zaretskii <eliz@gnu.org>
7456
7c106b1e
EZ
7457 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7458
973f782d
EZ
7459 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7460
41cf7d1a 74612011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7462
ca23cc88
PE
7463 Fix more problems found by GCC 4.6.0's static checks.
7464
f390e2d5
PE
7465 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7466
42eea0d0
PE
7467 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7468
b69769da 7469 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7470
f9541e84
PE
7471 * xdisp.c (vmessage): Mark as a printf-like function.
7472
13841b55
PE
7473 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7474
c136c10f
PE
7475 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7476
5e2d4a30
PE
7477 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7478 printf-like functions.
7479 (tiff_load): Add casts to remove these marks before passing them
7480 to system-supplied API.
7481
583f48b9
PE
7482 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7483
b25d760e
PE
7484 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7485 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7486 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7487 directly, rather than having caller test rule sign. This avoids
7488 some unnecessary tests.
7489 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7490 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7491 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7492
bc7b6697 7493 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7494 (xfont_open): Avoid unnecessary tests.
bc7b6697 7495
27ccc379
PE
7496 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7497
dcd5c89a
PE
7498 * composite.h, composite.c (composition_gstring_put_cache):
7499 Use EMACS_INT, not int, for length.
7500
b13a45c6
PE
7501 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7502 breaking out part of COMPOSITION_DECODE_RULE.
7503 (COMPOSITION_DECODE_RULE): Use it.
7504 * composite.c (get_composition_id): Remove unused local vars,
7505 by using the new macro.
7506
1e792e4d
PE
7507 * textprop.c (set_text_properties_1): Change while to do-while,
7508 since the condition is always true at first.
7509
dc6c6455 7510 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7511 (interval_deletion_adjustment): Return unsigned value.
7512 All uses changed.
dc6c6455 7513
aba7731a
PE
7514 * process.c (list_processes_1, create_pty, read_process_output):
7515 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7516 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7517 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7518 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7519 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7520
fdfc4bf3
PE
7521 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7522
fca8fe46 7523 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7524 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7525
06a0259a 7526 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7527 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7528 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7529
e7b9e80f
PE
7530 * print.c (print_error_message): Avoid int overflow.
7531
56201685
PE
7532 * font.c (font_list_entities): Redo for clarity,
7533 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7534
78834453 7535 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7536 (font_score): Avoid potential overflow in diff calculation.
78834453 7537
0bc0b309 7538 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7539 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7540
e610eaca
PE
7541 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7542
b895abce
PE
7543 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7544 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7545 can always succeed if overflow has undefined behavior.
7546
1f1d9321 7547 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7548 (wordify): Omit three unnecessary tests.
1f1d9321 7549
c59478bc
PE
7550 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7551 All callers changed. This avoids the need for an unused var.
7552
79b73827
PE
7553 * casefiddle.c (casify_region): Remove var that is set but not used.
7554
a4db5dfe
PE
7555 * dired.c (file_name_completion): Remove var that is set but not used.
7556
43aae36e
PE
7557 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7558
2a47c44d 7559 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7560 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7561
a37c69bf
PE
7562 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7563 Check for integer overflow on size calculations.
7564
328ab8e7
PE
7565 * buffer.c (Fprevious_overlay_change): Remove var that is set
7566 but not used.
7567
e5a2a5cb
PE
7568 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7569 Remove vars that are set but not used.
8d84a6eb 7570 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7571 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7572
a60e5f68
PE
7573 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7574
f661cb61 7575 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7576 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7577
f0397f5a
PE
7578 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7579 that are set but not used.
7580
8664db06 7581 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7582 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7583
6abdaa4a
PE
7584 * xselect.c (x_get_local_selection, x_handle_property_notify):
7585 Remove vars that are set but not used.
7586
0ce7538d 7587 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7588 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7589
9ae848fc
PE
7590 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7591 Remove var that is set but not used.
0b918413
PE
7592 (scroll_bar_windows_size): Now size_t, not int.
7593 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7594 Check for overflow.
9ae848fc 7595
a5a62657
PE
7596 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7597 (map_tty_color) [!defined MSDOS]: Likewise.
7598
5c5cdd39
PE
7599 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7600
66ebf983
PE
7601 * coding.c: Remove vars that are set but not used.
7602 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7603 All callers changed.
7604 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7605 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7606 (decode_coding_charset): Remove vars that are set but not used.
7607
1be4d761
PE
7608 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7609 that is set but not used.
7610
47553fa8
PE
7611 * print.c (print_object): Remove var that is set but not used.
7612
1f7196bf 7613 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7614 The gnulib version avoids calling malloc in the usual case,
7615 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7616 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7617 * filelock.c (current_lock_owner): Likewise.
7618 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7619 * sysdep.c: Include allocator.h, careadlinkat.h.
7620 (emacs_no_realloc_allocator): New static constant.
7621 (emacs_readlink): New function.
fdb61804
PE
7622 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7623 ../lib/careadlinkat.h.
d1fdcab7 7624
f84c17c7
SM
76252011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7626
7627 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7628 first non-nil return value).
7629
ef3862ad
JD
76302011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7631
7632 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7633 if not defined (Bug#8403).
7634
376a7006
JB
76352011-04-02 Juanma Barranquero <lekktu@gmail.com>
7636
7637 * xdisp.c (display_count_lines): Remove parameter `start',
7638 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7639 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7640 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7641 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7642 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7643 and thereabouts. All callers changed.
7644 (get_per_char_metric): Remove parameter `f', unused since
7645 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7646
6ca3801d
JM
76472011-04-02 Jim Meyering <meyering@redhat.com>
7648
7649 do not dereference NULL upon failed strdup
7650 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7651 (ns_get_family): Likewise.
7652
d8e2b5ba
JB
76532011-04-02 Juanma Barranquero <lekktu@gmail.com>
7654
7655 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7656
8c74fcbd
JD
76572011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7658
7659 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7660 later (Bug#8403).
7661
7200d79c
SM
76622011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7663
03408648 7664 Add lexical binding.
7200d79c 7665
03408648
SM
7666 * window.c (Ftemp_output_buffer_show): New fun.
7667 (Fsave_window_excursion):
7668 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7669
7670 * lread.c (lisp_file_lexically_bound_p): New function.
7671 (Fload): Bind Qlexical_binding.
7672 (readevalloop): Remove `evalfun' arg.
7673 Bind Qinternal_interpreter_environment.
7674 (Feval_buffer): Bind Qlexical_binding.
7675 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7676 Mark as dynamic.
7677 (syms_of_lread): Declare `lexical-binding'.
7678
7679 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7680
7681 * keyboard.c (eval_dyn): New fun.
7682 (menu_item_eval_property): Use it.
ca105506
SM
7683
7684 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7685
03408648
SM
7686 * fns.c (concat, mapcar1): Accept byte-code-functions.
7687
7688 * eval.c (Fsetq): Handle lexical vars.
7689 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7690 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7691 (FletX, Flet): Obey lexical binding.
7692 (Fcommandp): Handle closures.
7693 (Feval): New `lexical' arg.
7694 (eval_sub): New function extracted from Feval. Use it almost
7695 everywhere where Feval was used. Look up vars in lexical env.
7696 Handle closures.
7697 (Ffunctionp): Move from subr.el.
7698 (Ffuncall): Handle closures.
7699 (apply_lambda): Remove `eval_flags'.
7700 (funcall_lambda): Handle closures and new byte-code-functions.
7701 (Fspecial_variable_p): New function.
7702 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7703 but without exporting it to Lisp.
23aba0ea 7704
23aba0ea 7705 * doc.c (Fdocumentation, store_function_docstring):
03408648 7706 * data.c (Finteractive_form): Handle closures.
23aba0ea 7707
03408648
SM
7708 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7709 interactive spec.
ba83908c 7710
04f2d78b
CB
7711 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7712 New byte-codes.
03408648
SM
7713 (exec_byte_code): New function extracted from Fbyte_code to handle new
7714 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7715
03408648 7716 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7717
03408648 7718 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7719
e2abce01
JB
77202011-03-31 Juanma Barranquero <lekktu@gmail.com>
7721
7722 * xdisp.c (redisplay_internal): Fix prototype.
7723
63696a73 77242011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7725
63696a73 7726 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7727 (try_scrolling): Use it when setting scroll_limit.
7728 Limit scrolling to 100 screen lines.
63696a73
EZ
7729 (redisplay_window): Even when falling back on "recentering",
7730 position point in the window according to scroll-conservatively,
7731 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7732
7733 (try_scrolling): When point is above the window, allow searching
7734 as far as scroll_max, or one screenful, to compute vertical
7735 distance from PT to the scroll margin position. This prevents
7736 try_scrolling from unnecessarily failing when
7737 scroll-conservatively is set to a value slightly larger than the
7738 window height. Clean up the case of PT below the margin at bottom
7739 of window: scroll_max can no longer be INT_MAX. When aggressive
7740 scrolling is in use, don't let point enter the opposite scroll
7741 margin as result of the scroll.
7742 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7743 threshold of 100 lines for never-recentering scrolling.
7744
e4cc2dfc
JB
77452011-03-31 Juanma Barranquero <lekktu@gmail.com>
7746
7747 * dispextern.h (move_it_by_lines):
7748 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7749 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7750 (message_log_check_duplicate): Remove parameters `prev_bol' and
7751 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7752 (redisplay_internal): Remove parameter `preserve_echo_area',
7753 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7754
7755 * indent.c (Fvertical_motion):
7756 * window.c (window_scroll_pixel_based, Frecenter):
7757 Don't pass `need_y_p' to `move_it_by_lines'.
7758
1c470562
SM
77592011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7760
44f230aa
SM
7761 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7762 steal a few bits to be more compact.
7763 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7764 Remove unneeded casts.
7765
1c470562
SM
7766 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7767
888adce9
ZK
77682011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7769
7770 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7771 binding" message (bug#7967).
7772
f838ed7b
PE
77732011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7774
77861b95
PE
7775 Fix more problems found by GCC 4.6.0's static checks.
7776
de6dbc14
PE
7777 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7778 Remove unused local var.
7779
f838ed7b
PE
7780 * editfns.c (Fmessage_box): Remove unused local var.
7781
792c7b2b
PE
7782 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7783 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7784 Omit unused local vars.
c499e557 7785 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7786 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7787 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7788 Omit unused local var.
7789
ba0165e1
PE
7790 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7791 Don't assume string length fits in int.
32ad8845 7792 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7793 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7794
3c59b4c9
PE
7795 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7796 instead of alloca (Bug#8344).
7797
a3eed478 7798 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7799 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7800
eb4d412d
PE
7801 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7802
1658b401
PE
7803 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7804 concerns.
7805
7806 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7807
7808 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7809
9a2c6e05
PE
7810 * keyboard.c (syms_of_keyboard): Use the same style as later
7811 in this function when indexing through an array. This also
7812 works around GCC bug 48267.
7813
03d0a109
PE
7814 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7815
44f730c8
PE
7816 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7817
fe75f926
PE
7818 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7819 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7820
ffa8c828
PE
7821 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7822 This avoids undefined behavior on integer overflow, and is a bit
7823 more convenient anyway since it is compared to a size_t variable.
7824
c5101a77
PE
7825 Variadic C functions now count arguments with size_t, not int.
7826 This avoids an unnecessary limitation on 64-bit machines, which
7827 caused (substring ...) to crash on large vectors (Bug#8344).
7828 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7829 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7830 All variadic functions and their callers changed accordingly.
c5101a77
PE
7831 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7832 * data.c (arith_driver, float_arith_driver): Likewise.
7833 * editfns.c (general_insert_function): Likewise.
7834 * eval.c (struct backtrace.nargs, interactive_p)
7835 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7836 (funcall_lambda, mark_backtrace): Likewise.
7837 * fns.c (concat): Likewise.
7838 * frame.c (x_set_frame_parameters): Likewise.
7839 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7840 0 if not found, not -1. All callers changed.
7841
dd3f25f7
PE
7842 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7843 (stack_copy_size): Now size_t, not int.
7844 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7845
461c2ab9
JB
78462011-03-28 Juanma Barranquero <lekktu@gmail.com>
7847
7848 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7849 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7850 All callers changed.
7851
7852 * lisp.h (multibyte_char_to_unibyte):
7853 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7854 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7855 * character.h (CHAR_TO_BYTE8):
7856 * cmds.c (internal_self_insert):
7857 * editfns.c (general_insert_function):
7858 * keymap.c (push_key_description):
7859 * search.c (Freplace_match):
7860 * xdisp.c (message_dolog, set_message_1): All callers changed.
7861
f6d62986
SM
78622011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7863
7864 * keyboard.c (safe_run_hook_funcall): New function.
7865 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7866 don't set the hook to nil, but remove the offending function instead.
7867 (Qcommand_hook_internal): Remove, unused.
7868 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7869 Vcommand_hook_internal.
7870
7871 * eval.c (enum run_hooks_condition): Remove.
7872 (funcall_nil, funcall_not): New functions.
7873 (run_hook_with_args): Call each function through a `funcall' argument.
7874 Remove `cond' argument, now redundant.
7875 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7876 (Frun_hook_with_args_until_failure): Adjust accordingly.
7877 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7878
1db5b1ad
JB
78792011-03-28 Juanma Barranquero <lekktu@gmail.com>
7880
7881 * dispextern.h (string_buffer_position): Remove declaration.
7882
7883 * print.c (strout): Remove parameter `multibyte', unused since
7884 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7885
7886 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7887 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7888 All callers changed.
7889
7890 * w32.c (_wsa_errlist): Use braces for struct initializers.
7891
7892 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7893 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7894 All callers changed.
7895 (string_buffer_position): Likewise. Also, make static (it's never
7896 used outside xdisp.c).
7897 (cursor_row_p): Remove parameter `w', unused since
7898 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7899 (decode_mode_spec): Remove parameter `precision', introduced during
7900 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7901 All callers changed.
7902
5ffb62aa
JD
79032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7904
7905 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7906
461c2ab9 79072011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7908
7909 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7910 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7911 (ns_update_auto_hide_menu_bar): New functions.
7912 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7913 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7914 ns_constrain_all_frames.
7915 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7916 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7917
5c380ffb
JD
79182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7919
7920 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7921
9af30bdf
GM
79222011-03-27 Glenn Morris <rgm@gnu.org>
7923
7924 * syssignal.h: Replace RETSIGTYPE with void.
7925 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7926 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7927 Replace SIGTYPE with void everywhere.
7928 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7929 * s/template.h (SIGTYPE): Remove commented out definition.
7930
e2abce01
JB
79312011-03-26 Eli Zaretskii <eliz@gnu.org>
7932
7933 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7934 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7935
f868cd8a
JB
79362011-03-26 Juanma Barranquero <lekktu@gmail.com>
7937
59eb0929
JB
7938 * w32.c (read_unc_volume): Use parameter `henum', instead of
7939 global variable `wget_enum_handle'.
7940
7941 * keymap.c (describe_vector): Remove parameters `indices' and
7942 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7943 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7944
f868cd8a
JB
7945 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7946
7947 * keyboard.c (timer_check): Remove parameter `do_it_now',
7948 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7949 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7950 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7951
7952 * keyboard.c (read_char):
7953 * w32menu.c (w32_menu_display_help):
7954 * xmenu.c (show_help_event, menu_help_callback):
7955 Adjust calls to `show_help_echo'.
7956
7957 * gtkutil.c (xg_maybe_add_timer):
7958 * keyboard.c (readable_events):
7959 * process.c (wait_reading_process_output):
7960 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7961
7962 * insdel.c (adjust_markers_gap_motion):
7963 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7964 (gap_left, gap_right): Don't call it.
7965
2ecf6fdb
CY
79662011-03-25 Chong Yidong <cyd@stupidchicken.com>
7967
7968 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7969 incurred during fontification.
7970
6b1f9ba4
JB
79712011-03-25 Juanma Barranquero <lekktu@gmail.com>
7972
7973 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7974 (DEFVAR_PER_BUFFER): Don't pass it.
7975
7976 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7977 (scrolling_window): Don't pass it.
7978
0f4a96b5
JB
79792011-03-25 Juanma Barranquero <lekktu@gmail.com>
7980
7981 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7982
7983 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7984 and `suffix'.
7985 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7986 of variables specific to SELinux and computation of `encoded_absname'.
7987
7988 * image.c (XPutPixel): Remove unused variable `height'.
7989
7990 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7991
7992 * unexw32.c (get_section_info): Remove unused variable `section'.
7993
7994 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7995 (system_process_attributes): Remove unused variable `sess'.
7996 (sys_read): Remove unused variable `err'.
7997
7998 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7999 (w32_wnd_proc): Remove unused variable `isdead'.
8000 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8001 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8002 (x_create_tip_frame): Remove unused variable `tem'.
8003
8004 * w32inevt.c (w32_console_read_socket):
8005 Remove unused variable `no_events'.
8006
8007 * w32term.c (x_draw_composite_glyph_string_foreground):
8008 Remove unused variable `width'.
8009
1149507c
JB
80102011-03-24 Juanma Barranquero <lekktu@gmail.com>
8011
8012 * w32term.c (x_set_glyph_string_clipping):
8013 Don't pass uninitialized region to CombineRgn.
8014
9c88f339
JB
80152011-03-23 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8018 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8019 (Fx_close_connection): Remove unused variable `i'.
8020
8021 * w32font.c (w32font_draw): Return number of glyphs.
8022 (w32font_open_internal): Remove unused variable `i'.
8023 (w32font_driver): Add missing initializer.
8024
8025 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8026 (fill_in_menu): Remove unused variable `items_added'.
8027
8028 * w32term.c (last_mouse_press_frame): Remove static global variable.
8029 (w32_clip_to_row): Remove unused variable `f'.
8030 (x_delete_terminal): Remove unused variable `i'.
8031
8032 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8033 (NOTHING): Remove unused static global variable.
8034 (uniscribe_check_otf): Remove unused variable `table'.
8035 (uniscribe_font_driver): Add missing initializers.
8036
dee091a3
JD
80372011-03-23 Julien Danjou <julien@danjou.info>
8038
8039 * term.c (Fsuspend_tty, Fresume_tty):
8040 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8041 * window.c (temp_output_buffer_show):
8042 * insdel.c (signal_before_change):
8043 * frame.c (Fhandle_switch_frame):
8044 * fileio.c (Fdo_auto_save):
8045 * emacs.c (Fkill_emacs):
8046 * editfns.c (save_excursion_restore):
8047 * cmds.c (internal_self_insert):
8048 * callint.c (Fcall_interactively):
8049 * buffer.c (Fkill_all_local_variables):
8050 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8051 Use Frun_hooks.
0f4a96b5 8052 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8053 unconditionally since it does the check itself.
dee091a3 8054
2c520ab5 80552011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8056
c9c49752
PE
8057 Fix more problems found by GCC 4.5.2's static checks.
8058
8abc3f12
PE
8059 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8060 the first time through the loop, since we know p0 < p1 then.
8061 This also avoids a gcc -Wstrict-overflow warning.
8062
a2d26660
PE
8063 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8064 leading to a memory leak, possible in functions like
8065 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8066 of objects (Bug#8318).
a2d26660 8067
916c72e9
PE
8068 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8069 that could (at least in theory) be that large.
8070
19ab8a18
PE
8071 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8072 This is less likely to overflow, and avoids undefined behavior if
8073 overflow does occur. All callers changed. Use strtoul to scan
8074 for the unsigned long integer.
b7cbbd6f
PE
8075 (pint2hrstr): Simplify and tune code slightly.
8076 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8077
f0641eff
PE
8078 * scroll.c (do_scrolling): Work around GCC bug 48228.
8079 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8080
7f650bb9
PE
8081 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8082 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8083 (validate_x_resource_name): Simplify count usage.
8084 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8085
37dd57d1
PE
8086 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8087 fail (Bug#8306).
81e56e61 8088
699979fc 8089 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8090
401bf9b4
PE
8091 * process.c (Fmake_network_process): Use socklen_t, not int,
8092 where POSIX says socklen_t is required in portable programs.
8093 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8094 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8095 (Fmake_network_process, server_accept_connection):
8096 (wait_reading_process_output, read_process_output):
8097 Likewise.
8098
b93aacde
PE
8099 * process.c: Rename or move locals to avoid shadowing.
8100 (list_processes_1, Fmake_network_process):
8101 (read_process_output_error_handler, exec_sentinel_error_handler):
8102 Rename or move locals.
4dc343ee 8103 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8104 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8105 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8106 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8107 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8108
af8a867c 8109 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8110 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8111 Include tparam.h instead, since it declares them.
af8a867c
PE
8112 * cm.h (PC): Remove extern decl; tparam.h now does this.
8113 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8114 * terminfo.c: Include tparam.h, to check interfaces.
8115 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8116 (tparam): Adjust signature to match interface in tparam.h;
8117 this removes some undefined behavior. Check that outstring and len
8118 are zero, which they always are with Emacs.
8119 * tparam.h (PC, BC, UP): New extern decls.
8120
0248044d 8121 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8122 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8123
8ff096c1 8124 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8125 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8126 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8127 (ftfont_list): Remove unused local.
49eaafba
PE
8128 (get_adstyle_property, ftfont_pattern_entity):
8129 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8130 Rename locals to avoid shadowing.
8ff096c1 8131
e2be39f6
PE
8132 * xfont.c (xfont_list_family): Mark var as initialized.
8133
c9735e30
PE
8134 * xml.c (make_dom): Now static.
8135
8f5201ae
PE
8136 * composite.c (composition_compute_stop_pos): Rename local to
8137 avoid shadowing.
b246f932
PE
8138 (composition_reseat_it): Remove unused locals.
8139 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8140 (composition_update_it): Mark var as initialized.
11b61122
PE
8141 (find_automatic_composition): Mark vars as initialized,
8142 with a FIXME (Bug#8290).
8f5201ae 8143
760fbc2c
PE
8144 character.h: Rename locals to avoid shadowing.
8145 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8146 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8147 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8148 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8149 to avoid shadowing.
8150
ff08eb85
PE
8151 * textprop.c (property_change_between_p): Remove; unused.
8152
fc7bf025
PE
8153 * intervals.c (interval_start_pos): Now static.
8154
235d7abc
PE
8155 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8156
44f230aa
SM
8157 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8158 Rename locals to avoid shadowing.
3e7d6594 8159
50060332
PE
8160 * sound.c (wav_play, au_play, Fplay_sound_internal):
8161 Fix pointer signedness.
d01f234b 8162 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8163 (wav_play): Initialize a variable to 0, to prevent undefined
8164 behavior (Bug#8278).
50060332 8165
c4fc4e30
PE
8166 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8167
918436ed
PE
8168 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8169
c939f91b
PE
8170 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8171 clobbering (Bug#8298).
b9c7f648
PE
8172 * sysdep.c (sys_subshell): Likewise.
8173 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8174
6bd8c144
PE
8175 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8176 This should get cleaned up, so that child_setup has the
8177 same signature on all platforms.
8178
7710357c 8179 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8180 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8181
c59da222
CY
81822011-03-22 Chong Yidong <cyd@stupidchicken.com>
8183
8184 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8185 not to be necessary, and produces flickering.
8186
66b87493
GM
81872011-03-20 Glenn Morris <rgm@gnu.org>
8188
8189 * config.in: Remove file.
8190
45b6f6d5
JB
81912011-03-20 Juanma Barranquero <lekktu@gmail.com>
8192
8193 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8194 are now in src/globals.h.
8195 (syms_of_minibuf): Remove spurious & from previous change.
8196
3ec03f7e
LL
81972011-03-20 Leo <sdl.web@gmail.com>
8198
8199 * minibuf.c (completing-read-function): New variable.
8200 (completing-read-default): Rename from completing-read.
8201 (completing-read): Call completing-read-function.
8202
b14e3e21
CY
82032011-03-19 Juanma Barranquero <lekktu@gmail.com>
8204
8205 * xfaces.c (Fx_load_color_file):
8206 Read color file from absolute filename (bug#8250).
8207
f2b726e6
JB
82082011-03-19 Juanma Barranquero <lekktu@gmail.com>
8209
8210 * makefile.w32-in: Update dependencies.
8211
09f6ff02
EZ
82122011-03-17 Eli Zaretskii <eliz@gnu.org>
8213
8214 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8215
29a6015a
PE
82162011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8217
a3a6c54e
PE
8218 Fix more problems found by GCC 4.5.2's static checks.
8219
b766f867
PE
8220 * process.c (make_serial_process_unwind, send_process_trap):
8221 (sigchld_handler): Now static.
8222
be02381c
PE
8223 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8224 That way, the code declares only the vars that it needs.
8225 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8226 * s/cygwin.h (PTY_ITERATION): Likewise.
8227 * s/darwin.h (PTY_ITERATION): Likewise.
8228 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8229
57048744
PE
8230 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8231 * process.c (allocate_pty): Don't declare stb unless it's needed.
8232
7914961c 8233 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8234 (CONSTANTLIM): Remove; unused.
8235 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8236 Define only if needed.
7914961c 8237
b3967b18
PE
8238 * unexelf.c (unexec): Name an expression,
8239 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8240 Use a different way to cause a compilation error if anyone uses
8241 n rather than nn, a way that does not involve shadowing.
73366a00 8242 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8243
29a6015a
PE
8244 * deps.mk (unexalpha.o): Remove; unused.
8245
43cfc33e 8246 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8247 * unexec.h: New file.
ce701a33
PE
8248 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8249 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8250 Depend on unexec.h.
8251 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8252 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8253 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8254 Change as necessary to match prototype in unexec.h.
ce701a33 8255
01f44d5a
PE
8256 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8257 shadowing.
4f63c6bb 8258 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8259
a6670b0b
PE
8260 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8261 Rename locals to avoid shadowing.
8262
cef2010d 8263 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8264 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8265
d4d7173a
PE
8266 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8267
f08b802a
PE
8268 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8269 warning when compiling print.c.
8270
3ddb0639
PE
8271 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8272 instead of using an uninitialized var.
5ad03b97 8273 (font_sort_entities): Mark var as initialized.
3ddb0639 8274
170a2692
PE
8275 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8276
e663c700
PE
8277 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8278 pointers to constants.
89bc529a 8279 (font_parse_fcname): Remove unused vars.
7b81e2d0 8280 (font_delete_unmatched): Now static.
ea838e10 8281 (font_get_spec): Remove; unused.
13a547c6
PE
8282 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8283 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8284 Rename or move locals to avoid shadowing.
e663c700 8285
2a80c887 8286 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8287 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8288
1384fa33 8289 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8290 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8291
8b2c52e9
PE
8292 * alloc.c (mark_backtrace): Move decl from here ...
8293 * lisp.h: ... to here, so that it can be checked.
8294
475545b5 8295 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8296 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8297 (lisp_indirect_variable): Name an expression,
8298 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8299 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8300
b1349114 8301 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8302 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8303 Use const pointer when appropriate.
b1349114 8304
a2928364
PE
8305 * lisp.h (get_system_name, get_operating_system_release):
8306 Move decls here, to check interfaces.
8307 * process.c (get_operating_system_release): Move decl to lisp.h.
8308 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8309 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8310 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8311 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8312 (Fformat_time_string, Fencode_time, Finsert_char):
8313 (Ftranslate_region_internal, Fformat):
8314 Rename or remove local vars to avoid shadowing.
9710023e 8315 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8316
a415e694
PE
8317 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8318 avoid shadowing.
8319
8ef4622d
PE
8320 * lisp.h (eassert): Check that the argument compiles, even if
8321 ENABLE_CHECKING is not defined.
8322
946f9a5b
PE
8323 * data.c (Findirect_variable): Name an expression, to avoid
8324 gcc -Wbad-function-cast warning.
112396d6 8325 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8326 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8327 (Fmake_variable_buffer_local, Fmake_local_variable):
8328 Mark variables as initialized.
52746918 8329 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8330
e5aab7e7 8331 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8332 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8333 Rename locals to avoid shadowing.
dff45157
PE
8334 (mark_stack): Move local variables into the #ifdef region where
8335 they're used.
7bc26fdb
PE
8336 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8337 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8338 needed otherwise.
8339 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8340 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8341 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8342
e5aab7e7
PE
8343 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8344 avoids undefined behavior in theory.
8345
4da60324
PE
8346 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8347
88043301
PE
8348 Use functions, not macros, for up- and down-casing (Bug#8254).
8349 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8350 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8351 to use the following functions instead of these macros.
8352 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8353 EMACS_INT, since callers assume the returned value fits in int.
8354 (upcase1): Likewise, for UPCASE_TABLE.
8355 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8356 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8357 the race-condition problem in the old DOWNCASE.
88043301 8358
19ed5445
PE
8359 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8360 Rename locals to avoid shadowing.
8361 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8362 (regex_compile, re_search_2, re_match_2_internal):
8363 Remove unused local vars.
952db0d7
PE
8364 (FREE_VAR): Rewrite so as not to use empty "else",
8365 which gcc can warn about.
da053e48 8366 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8367 (RETALLOC_IF): Define only if needed.
8368 (WORDCHAR_P): Likewise. This one is never needed, but is used
8369 only in a comment talking about a compiler bug, so put inside
8370 the #if 0 of that comment.
8371 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8372 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8373 Remove; unused.
19ed5445 8374
1f3561e4 8375 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8376 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8377 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8378
ded6f8f7
PE
8379 * search.c (simple_search): Remove unused var.
8380
dbd37a95
PE
8381 * dired.c (compile_pattern): Move decl from here ...
8382 * lisp.h: ... to here, so that it can be checked.
8383 (struct re_registers): New forward decl.
8384
7e47afad
PE
8385 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8386
85f24f61
PE
8387 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8388 All uses changed.
8389 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8390 Rename locals to avoid shadowing.
5671df8f 8391 (Fvertical_motion): Mark locals as initialized.
85f24f61 8392
181aa2be 8393 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8394 (casify_region): Mark local as initialized.
181aa2be 8395
930d429c
PE
8396 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8397
7082eac6
PE
8398 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8399 New macros, so that the caller can use some names other than
8400 gcpro1, gcpro2, etc.
8401 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8402 of the new macros.
8403 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8404 argument, for consistency with GCPRO2_VAR, etc: it is now the
8405 prefix of the variable, not the variable itself. All uses
8406 changed.
38b2c076
PE
8407 * dired.c (directory_files_internal, file_name_completion):
8408 Rename locals to avoid shadowing.
8409
15206ed9
PE
8410 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8411 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8412 dired.c's scmp function, had undefined behavior.
8413 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8414 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8415 * buffer.h: ... to here, because these macros use current_buffer,
8416 and the new implementation with inline functions needs to have
8417 current_buffer in scope now, rather than later when the macros
8418 are used.
8419 (downcase, upcase1): New static inline functions.
8420 (DOWNCASE, UPCASE1): Reimplement using these functions.
8421 This avoids undefined behavior in expressions like
8422 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8423 from race conditions in accessing the global variables
8424 case_temp1 and case_temp2.
8425 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8426 * lisp.h (case_temp1, case_temp2): Remove their decls.
8427 * character.h (ASCII_CHAR_P): Move from here ...
8428 * lisp.h: ... to here, so that the inline functions mentioned
8429 above can use them.
8430
4a6bea26
PE
8431 * dired.c (directory_files_internal_unwind): Now static.
8432
f14b7e14
PE
8433 * fileio.c (file_name_as_directory, directory_file_name):
8434 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8435 Now static.
2893f146
PE
8436 (file_name_as_directory): Use const pointers when appropriate.
8437 (Fexpand_file_name): Likewise. In particular, newdir might
8438 point at constant storage, so make it a const pointer.
fd4ead52 8439 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8440 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8441 signedness issues.
f839df0c
PE
8442 (Fset_file_times, Finsert_file_contents, auto_save_error):
8443 Rename locals to avoid shadowing.
f14b7e14 8444
5716756e 8445 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8446 (Ftry_completion, Fall_completions): Rename or remove locals
8447 to avoid shadowing.
5716756e 8448
b4c3046a
PE
8449 * marker.c (bytepos_to_charpos): Remove; unused.
8450
b45db522
PE
8451 * lisp.h (verify_bytepos, count_markers): New decls,
8452 so that gcc does not warn that these functions aren't declared.
8453
85876d07
PE
8454 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8455 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8456 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8457 (copy_text): Remove unused local var.
85876d07 8458
03d78a21 8459 * filelock.c (within_one_second): Now static.
b3dd38ab 8460 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8461
5df8f01b
PE
8462 * buffer.c (fix_overlays_before): Mark locals as initialized.
8463 (fix_start_end_in_overlays): Likewise. This function should be
8464 simplified by using pointers-to-pointers, but that's a different
8465 matter.
b1d876f1 8466 (switch_to_buffer_1): Now static.
8f54f30a
PE
8467 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8468 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8469
a70072c9 8470 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8471 Fix pointer signedness issue.
edced198
PE
8472 (sys_subshell): Mark local as volatile if checking for lint,
8473 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8474 (MAXPATHLEN): Define only if needed.
a70072c9 8475
a0977c44
PE
8476 * process.c (serial_open, serial_configure): Move decls from here ...
8477 * systty.h: ... to here, so that they can be checked.
8478
a884fdcc
PE
8479 * fns.c (get_random, seed_random): Move extern decls from here ...
8480 * lisp.h: ... to here, so that they can be checked.
8481
604efe86 8482 * sysdep.c (reset_io): Now static.
b8950c94 8483 (wait_for_termination_signal): Remove; unused.
604efe86 8484
38fc62d9
PE
8485 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8486 (copy_keymap_item, append_key, push_text_char_description):
8487 Now static.
1004a21a 8488 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8489 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8490 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8491 (describe_map_tree):
8492 Rename locals to avoid shadowing.
38fc62d9 8493
2f2650da
PE
8494 * keyboard.c: Declare functions static if they are not used elsewhere.
8495 (echo_char, echo_dash, cmd_error, top_level_2):
8496 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8497 (read_char, kbd_buffer_get_event, make_lispy_position):
8498 (make_lispy_event, make_lispy_movement, apply_modifiers):
8499 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8500 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8501 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8502 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8503 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8504
a053e86c 8505 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8506 (mark_kboards): Move decl here ...
8507 * alloc.c (mark_kboards): ... from here.
a053e86c 8508
4752793e
PE
8509 * lisp.h (force_auto_save_soon): New decl.
8510
74f10ca7 8511 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8512 (DEFINE_DUMMY_FUNCTION): New macro.
8513 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8514 Use it.
c03cd23f
PE
8515 (main): Add casts to avoid warnings
8516 if GCC considers string literals to be constants.
74f10ca7 8517
022e70d4
PE
8518 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8519
59d6fe83
PE
8520 * dbusbind.c: Pointer signedness fixes.
8521 (xd_signature, xd_append_arg, xd_initialize):
8522 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8523 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8524 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8525 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8526
78320123
PE
8527 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8528 if GCC considers string literals to be constants.
49cebcca 8529 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8530
35ac2a97
SM
85312011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8532
fb103ca9
SM
8533 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8534 (print_preprocess, print_object): New macro to fix last change.
8535
35ac2a97
SM
8536 * print.c (print_preprocess): Don't forget font objects.
8537
62973b41
JB
85382011-03-16 Juanma Barranquero <lekktu@gmail.com>
8539
8540 * emacs.c (USAGE3): Doc fixes.
8541
0e48bb22
AS
85422011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8543
8544 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8545 structure.
8546
7684e57b
JB
85472011-03-14 Juanma Barranquero <lekktu@gmail.com>
8548
8549 * lisp.h (VWindow_system, Qfile_name_history):
8550 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8551 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8552 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8553
8554 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8555 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8556
8557 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8558 * w32console.c (detect_input_pending, read_input_pending)
8559 (encode_terminal_code):
8560 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8561 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8562 (w32_system_caret_y, Qfile_name_history):
8563 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8564 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8565 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8566 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8567 * w32proc.c (Qlocal, report_file_error):
8568 * w32term.c (Vwindow_system, updating_frame):
8569 * w32uniscribe.c (initialized, uniscribe_font_driver):
8570 Remove unneeded extern declarations.
8571
2aa46d6c
CY
85722011-03-14 Chong Yidong <cyd@stupidchicken.com>
8573
c96bbc66 8574 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8575
cffc6f3b
CY
85762011-03-13 Chong Yidong <cyd@stupidchicken.com>
8577
8578 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8579 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8580 These macros can no longer be used for assignment.
8581
44f230aa
SM
8582 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8583 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8584 (record_buffer_markers, fetch_buffer_markers): New functions for
8585 recording and fetching special buffer markers.
8586 (set_buffer_internal_1, set_buffer_temp): Use them.
8587
8588 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8589
8590 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8591
8592 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8593 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8594
8595 * xdisp.c (hscroll_window_tree):
8596 (reconsider_clip_changes): Use PT instead of BUF_PT.
8597
d251f04b
EZ
85982011-03-13 Eli Zaretskii <eliz@gnu.org>
8599
8600 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8601 $(EMACS_ROOT)/lib/intprops.h.
8602
f0c77cd1
PE
86032011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8604
3eca4629
PE
8605 Fix more problems found by GCC 4.5.2's static checks.
8606
7c86ee98
PE
8607 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8608 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8609 (xg_free_frame_widgets): Make it clear that a local variable is
8610 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8611 (gdk_window_get_screen): Make it clear that this macro is needed
8612 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8613 (int_gtk_range_get_value): New function, which avoids a diagnostic
8614 from gcc -Wbad-function-cast.
8615 (xg_set_toolkit_scroll_bar_thumb): Use it.
8616 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8617 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8618 (get_utf8_string, xg_get_file_with_chooser):
8619 Rename locals to avoid shadowing.
8620 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8621
41729b81
PE
8622 * xgselect.c (xg_select): Remove unused var.
8623
f0c77cd1
PE
8624 * image.c (four_corners_best): Mark locals as initialized.
8625 (gif_load): Initialize transparent_p to zero (Bug#8238).
8626 Mark another local as initialized.
ec6cf4c6 8627 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8628
ce0ad53d 8629 * image.c (clear_image_cache): Now static.
d5d5a617 8630 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8631 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8632 (x_edge_detection): Remove unnecessary cast that
8633 gcc -Wbad-function-cast diagnoses.
2037898d 8634 (gif_load): Fix pointer signedness.
6ae141d6
PE
8635 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8636 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8637
33383987 86382011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8639
d32df629
PE
8640 Improve quality of tests for time stamp overflow.
8641 For example, without this patch (encode-time 0 0 0 1 1
8642 1152921504606846976) returns the obviously-bogus value (-948597
8643 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8644 reports time overflow. See
8645 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8646 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8647 * editfns.c: Include limits.h and intprops.h.
8648 (TIME_T_MIN, TIME_T_MAX): New macros.
8649 (time_overflow): Move earlier, to before first use.
8650 (hi_time, lo_time): New functions, for an accurate test for
8651 out-of-range times.
8652 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8653 (Fget_internal_run_time): Don't assume time_t fits in int.
8654 (make_time): Use list2 instead of Fcons twice.
8655 (Fdecode_time): More accurate test for out-of-range times.
8656 (check_tm_member): New function.
8657 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8658 (lisp_time_argument): Don't rely on undefined left-shift and
8659 right-shift behavior when checking for time stamp overflow.
8be6f318 8660
fe31d94c
PE
8661 * editfns.c (time_overflow): New function, refactoring common code.
8662 (Fformat_time_string, Fdecode_time, Fencode_time):
8663 (Fcurrent_time_string): Use it.
8664
8be6f318
PE
8665 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8666 * dired.c (make_time): Move to ...
8667 * editfns.c (make_time): ... here.
8668 * systime.h: Note the move.
8669
09d9db2c 86702011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8671
126bc0dc
YM
8672 * fringe.c (update_window_fringes): Remove unused variables.
8673
c47cbdfd
YM
8674 * unexmacosx.c (copy_data_segment): Also copy __got section.
8675 (Bug#8223)
8676
7ac80be9
EZ
86772011-03-12 Eli Zaretskii <eliz@gnu.org>
8678
c96bbc66 8679 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8680 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8681 Constify `char *' arguments and their references according to
8682 prototypes in tparam.h.
8683
ecb0f94d 8684 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8685
7ac80be9
EZ
8686 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8687 Adapt all references accordingly.
8688
8689 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8690
ef1fd07e
TT
86912011-03-11 Tom Tromey <tromey@redhat.com>
8692
8693 * buffer.c (syms_of_buffer): Remove obsolete comment.
8694
7ef4b50c
EZ
86952011-03-11 Eli Zaretskii <eliz@gnu.org>
8696
8697 * termhooks.h (encode_terminal_code): Declare prototype.
8698
8699 * msdos.c (encode_terminal_code): Don't declare prototype.
8700
8701 * term.c (encode_terminal_code): Now external again, used by
8702 w32console.c and msdos.c.
8703
44f230aa
SM
8704 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8705 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8706
4b1ec863 87072011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8708
1714f52b 8709 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8710
4b1ec863
PE
8711 * fringe.c (update_window_fringes): Mark locals as initialized
8712 (Bug#8227).
8713 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8714
524c7aa6
PE
8715 * alloc.c (mark_fringe_data): Move decl from here ...
8716 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8717 to check its interface.
8718 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8719
a5c0af81 8720 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8721 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8722 (fontset_font): Mark local as initialized.
a9a06e0b 8723 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8724
b4716021
PE
8725 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8726
811e9bac 8727 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8728 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8729 (x_own_selection, Fx_disown_selection_internal): Rename locals
8730 to avoid shadowing.
8731 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8732
7e3ab302
PE
8733 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8734 so that the caller can use some name other than gcpro1.
8735 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8736 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8737 (Fx_backspace_delete_keys_p):
8738 Use them to avoid shadowing, and rename vars to avoid shadowing.
8739 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8740 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8741 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8742 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8743 Remove unused locals.
7e3ab302
PE
8744 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8745 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8746 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8747 macros.
f78faa98 8748
e2b13473
PE
8749 * xterm.h (x_mouse_leave): New decl.
8750
77f23912
PE
8751 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8752 Remove unused functions.
cdf4ba58
PE
8753 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8754 (x_calc_absolute_position): Now static.
7411c686 8755 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8756 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8757 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8758 unless they are used.
38d0b34a
PE
8759 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8760 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8761 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8762 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8763 (x_error_catcher, x_connection_closed, x_error_handler):
8764 (x_error_quitter, xembed_send_message, x_iconify_frame):
8765 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8766 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8767 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8768
44f230aa
SM
8769 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8770 Rename or move locals to avoid shadowing.
6b463e58 8771 (tty_defined_color, merge_face_heights): Now static.
5967d051 8772 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8773 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8774 does not deduce is never used uninitialized.
73719eba
PE
8775 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8776 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8777
426994c3 8778 * terminal.c (store_terminal_param): Now static.
5489860b 8779
032f1620 8780 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8781 (set_frame_menubar): Remove unused local.
d4323972 8782 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8783 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8784 since they might point to immutable storage.
281585b0
PE
8785 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8786 since it's unused otherwise.
032f1620 8787
367c19e5 8788 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8789 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8790 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8791 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8792 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8793 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8794 does not deduce are never used uninitialized.
70739cbe 8795
07b48fa9
PE
8796 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8797
8868a238 8798 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8799 * window.c (window_loop, size_window):
8800 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8801
7e5cf297 8802 * window.c (display_buffer): Now static.
d6550a9f
PE
8803 (size_window): Mark variables that gcc -Wuninitialized
8804 does not deduce are never used uninitialized.
a586633d
PE
8805 * window.h (check_all_windows): New decl, to forestall
8806 gcc -Wmissing-prototypes diagnostic.
5b555da1 8807 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8808
f6095868
PE
8809 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8810 shadowing.
8811 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8812 Include <limits.h>.
8813 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8814 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8815 (load_charset_map): Mark variables that gcc -Wuninitialized
8816 does not deduce are never used uninitialized.
53df7c11 8817 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8818
f38b440c
PE
8819 * coding.c (coding_set_source, coding_set_destination):
8820 Use "else { /* comment */ }" rather than "else /* comment */;"
8821 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8822 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8823 a block, when the outer 'i' will do.
8824 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8825 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8826 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8827 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8828 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8829 Rename locals to avoid shadowing.
8830 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8831 * coding.c (emacs_mule_char, encode_invocation_designation):
8832 Now static, since they're not used elsewhere.
413bb2db 8833 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8834 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8835 (decode_coding_emacs_mule): Mark variables that gcc
8836 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8837 (detect_coding_iso_2022): Initialize a local variable that might
8838 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8839 this initialization is needed. (Bug#8211)
5f58e762
PE
8840 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8841 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8842 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8843 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8844 Remove unused macros.
f38b440c 8845
232b38b9 8846 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8847 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8848 * character.c (string_count_byte8): Likewise.
232b38b9 8849
fb90da1b
PE
8850 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8851 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8852
fb93dbc2
PE
8853 * chartab.c (copy_sub_char_table): Now static, since it's not used
8854 elsewhere.
5c156ace
PE
8855 (sub_char_table_ref_and_range, char_table_ref_and_range):
8856 Rename locals to avoid shadowing.
bbcd0949 8857 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8858
7d3b3862 8859 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8860 (BIDI_BOB): Remove unused macro.
7d3b3862 8861
6be7d3da
PE
8862 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8863 deduce are never used uninitialized.
c2ed9c8b 8864 * term.c (encode_terminal_code): Likewise.
6be7d3da 8865
75f8807f 8866 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8867
50938595
PE
8868 * tparam.h: New file.
8869 * term.c, tparam.h: Include it.
8870 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8871 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8872 Move these decls to tparam.h, and make them agree with what
8873 is actually in tparam.c. The previous trick of using incompatible
8874 decls in different modules does not conform to the C standard.
8875 All callers of tparam changed to use tparam's actual API.
8876 * tparam.c (tparam1, tparam, tgoto):
8877 Use const pointers where appropriate.
8878
fbceeba2
PE
8879 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8880 * cm.h (struct cm): Likewise.
8881 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8882 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8883 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8884 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8885 (turn_on_face, init_tty): Likewise.
8886 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8887
7f3f1250
PE
8888 * term.c (term_mouse_position): Rename local to avoid shadowing.
8889
e6ca6543
PE
8890 * alloc.c (mark_ttys): Move decl from here ...
8891 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8892
c40f8d15
AS
88932011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8894
8895 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8896
cfe0661d
JB
88972011-03-09 Juanma Barranquero <lekktu@gmail.com>
8898
8899 * search.c (compile_pattern_1): Remove argument regp, unused since
8900 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8901 (compile_pattern): Don't pass it.
8902
0afb4571
J
89032011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8904
8905 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8906 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8907 for ! HAVE_GTK3.
8908 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8909
8910 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8911
8912 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8913 gdk_window_get_screen, gdk_window_get_geometry,
8914 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8915 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8916 (xg_get_pixbuf_from_pixmap): New function.
8917 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8918 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8919 Call xg_get_pixbuf_from_pixmap instead of
8920 gdk_pixbuf_get_from_drawable.
8921 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8922 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8923 (xg_check_special_colors): Use GtkStyleContext and its functions
8924 for HAVE_GTK3.
8925 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8926 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8927 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8928 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8929 Call gtk_widget_get_preferred_size.
0afb4571
J
8930 (xg_frame_resized): gdk_window_get_geometry only takes 5
8931 parameters.
44f230aa
SM
8932 (xg_win_to_widget, xg_event_is_for_menubar):
8933 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8934 (xg_set_widget_bg): New function.
8935 (delete_cb): New function.
895009e1 8936 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8937 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8938 (xg_set_background_color): Call xg_set_widget_bg.
8939 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8940 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8941 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8942 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8943 if ! HAVE_GTK3.
8944 (update_frame_tool_bar): Call gtk_widget_hide.
8945 (xg_initialize): Use GDK_KEY_g.
8946
8947 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8948 if ! HAVE_GTK3
8949 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8950
8951 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8952 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8953 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8954
1c2cc4ef
JB
89552011-03-08 Juanma Barranquero <lekktu@gmail.com>
8956
8957 * w32xfns.c (select_palette): Check success of RealizePalette against
8958 GDI_ERROR, not zero.
8959
33383987 8960See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8961
8962;; Local Variables:
8963;; coding: utf-8
aac0c6e3
MR
8964;; End:
8965
33383987 8966 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8967
8968 This file is part of GNU Emacs.
8969
8970 GNU Emacs is free software: you can redistribute it and/or modify
8971 it under the terms of the GNU General Public License as published by
8972 the Free Software Foundation, either version 3 of the License, or
8973 (at your option) any later version.
8974
8975 GNU Emacs is distributed in the hope that it will be useful,
8976 but WITHOUT ANY WARRANTY; without even the implied warranty of
8977 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8978 GNU General Public License for more details.
8979
8980 You should have received a copy of the GNU General Public License
8981 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.