Final version that supports only one watch at a time.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c5c91b84
EZ
12012-10-07 Eli Zaretskii <eliz@gnu.org>
2
3 * w32term.h (WM_EMACS_FILENOTIFY): New custom message.
4 (WM_EMACS_END): Bump value by 1.
5
6 * w32term.c (lispy_file_action, queue_notifications): New functions.
7 (syms_of_w32term) <Qadded, Qremoved, Qmodified, Qrenamed_from>
8 <Qrenamed_to>: New symbols.
9
10 * w32notify.c: New file, implement file event notifications for
11 MS-Windows.
12
13 * w32fns.c (w32_wnd_proc): Handle the WM_EMACS_FILENOTIFY message
14 by posting it to the w32_read_socket queue.
15
16 * termhooks.h (enum event_kind) [WINDOWSNT]: New event kind
17 FILE_NOTIFY_EVENT.
18
19 * makefile.w32-in (OBJ2): Add $(BLD)/w32notify.$(O).
20 (GLOBAL_SOURCES): Add w32notify.c
21 ($(BLD)/w32notify.$(O)): New set of dependencies.
22
23 * lisp.h (syms_of_w32notify) [WINDOWSNT]: Add prototype.
24
25 * keyboard.c (kbd_buffer_get_event) [WINDOWSNT]: Handle
26 FILE_NOTIFY_EVENT.
27 (syms_of_keyboard) [WINDOWSNT] <Qfile_notify>: New symbol.
28 (keys_of_keyboard) [WINDOWSNT]: Bind file-notify to
29 w32notify-handle-event by default.
30
31 * emacs.c (main) [WINDOWSNT]: Call syms_of_w32notify.
32
33 * alloc.c (NSTATICS): Enlarge to 0x660.
34
3bc0a2f7
JD
352012-10-07 Jan Djärv <jan.h.d@swipnet.se>
36
493b5b1c
JD
37 * nsterm.m (ns_dumpglyphs_image): Only draw slize of image (Bug#12506).
38
335f5ae4
JD
39 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
40 MAC_OS_X_VERSION_10_6.
41 (syms_of_nsterm): Remove comment about Panther and above for ns-antialias-text.
335f5ae4
JD
42 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
43 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
44 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
45
46 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
47 MAC_OS_X_VERSION_10_4.
48
49 * nsmenu.m (fillWithWidgetValue:): Remove code for < MAC_OS_X_VERSION_10_2.
50
51 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
52
53 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
54 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
55
3bc0a2f7
JD
56 * nsterm.m (ns_in_resize): Remove (Bug#12479).
57 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
58 (ns_clear_frame, sendEvent, windowDidResize, drawRect:): Remove ns_in_resize
59 check.
60 (ns_clear_frame_area): Remove resize handle code.
61
62 * nsfns.m (ns_in_resize): Remove.
63 (x_set_icon_name, ns_set_name, ns_set_name_as_filename): Remove ns_in_resize
64 check.
65
c622b48f
PE
662012-10-07 Paul Eggert <eggert@cs.ucla.edu>
67
68 Improve sys_siglist detection.
69 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
70 defined as a macro, as is done in Solaris.
71 (sys_siglist_entries): New macro.
72 (save_strsignal): Use it.
73 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
74 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
75
04fafa46
JD
762012-10-06 Jan Djärv <jan.h.d@swipnet.se>
77
78 * nsfns.m (Fx_create_frame): Call x_default_parameter with
79 fullscreen/Fullscreen.
80
81 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
82 tobar_height is new.
83
84 * nsterm.m (x_make_frame_visible): Check for fullscreen.
85 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
86 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
87 (windowDidResize:): Check for correct window if old style fullscreen.
88 Capitalize word in comment. Remove incorrect comment.
89 (initFrameFromEmacs:): tbar_height renamed tibar_height.
90 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
91 error in drawing background.
92 (toggleFullScreen:): Remove comment. Rearrange calls.
93 Set toolbar values to zero, save old height in tobar_height.
94 Restore tool bar height when leaving fullscreen.
95 (canBecomeMainWindow): New function.
96
c6e21c03
PE
972012-10-06 Paul Eggert <eggert@cs.ucla.edu>
98
99 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
100
0d9f584b
EZ
1012012-10-05 Eli Zaretskii <eliz@gnu.org>
102
a65fbb5f
EZ
103 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
104
0d9f584b
EZ
105 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
106 that time stamps of directories could also be changed. Don't
107 request the too broad GENERIC_WRITE, only the more restrictive
108 FILE_WRITE_ATTRIBUTES access rights.
109
110 * fileio.c (Fset_file_times): Special-case ignoring errors for
111 directories only on MSDOS, not on MS-Windows.
112
e8757f09 1132012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
114
115 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
116
7604f298
EZ
1172012-10-04 Eli Zaretskii <eliz@gnu.org>
118
119 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
120 see whether CreateFile failed.
121
88d69b7d
PE
1222012-10-04 Paul Eggert <eggert@cs.ucla.edu>
123
124 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
125 to avoid similar races.
126 * keyboard.c (pending_signals): Now bool, not int.
127
7509f454
PE
128 Port timers to OpenBSD, plus check for timer failures.
129 OpenBSD problem reported by Han Boetes.
130 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
131 and/or setitimer.
132 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
133 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
134 like OpenBSD, which has timer_settime but does not declare it.
135 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
136 whether to use itimerspec-related primitives. All uses of
137 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
138
a3c5c0c5
PE
1392012-10-02 Paul Eggert <eggert@cs.ucla.edu>
140
141 * profiler.c (handle_profiler_signal): Fix a malloc race
142 that caused Emacs to hang on Fedora 17 when profiling Lisp.
143
914e743b
JD
1442012-10-02 Jan Djärv <jan.h.d@swipnet.se>
145
146 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
147
d8ab37a8
EZ
1482012-10-02 Eli Zaretskii <eliz@gnu.org>
149
150 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
151 consistent with the change in return value of 'safe_strsignal'.
152
b3ecad33
PE
1532012-10-02 Paul Eggert <eggert@cs.ucla.edu>
154
0a99eee1
PE
155 Prefer plain 'static' to 'static inline' (Bug#12541).
156 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
157 (bidi_set_sor_type, bidi_push_embedding_level)
158 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
159 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
160 (bidi_cache_search, bidi_cache_ensure_space)
161 (bidi_cache_iterator_state, bidi_cache_find)
162 (bidi_peek_at_next_level, bidi_set_paragraph_end)
163 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
164 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
165 Now 'static', not 'static inline'.
166
b3ecad33
PE
167 Count overruns when profiling; change units to ns.
168 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
169 Give extra weight to samples after overruns, to attempt to count
170 the time more accurately.
171 (setup_cpu_timer): Change sampling interval units from ms to ns, since
172 the underlying primitives nominally do ns.
173 (Fprofiler_cpu_start): Document the change. Mention that
174 the sampling intervals are only approximate.
175
090cf9db
SM
1762012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
179
180 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
181 case for the special 0 coding-system.
182
183 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
184 (Fmake_overlay): Remove redundant tests.
64edc777 185 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 186
81550bf4
JB
1872012-10-02 Juanma Barranquero <lekktu@gmail.com>
188
189 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
190 Update dependencies.
191
aa1ba90e
PE
1922012-10-01 Paul Eggert <eggert@cs.ucla.edu>
193
194 Fix a malloc race condition involving strsignal.
195 A signal can arrive in the middle of a malloc, and Emacs's signal
196 handler can invoke strsignal, which can invoke malloc, which is
197 not portable. This race condition bug makes Emacs hang on GNU/Linux.
198 Fix it by altering the signal handler so that it does not invoke
199 strsignal.
200 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
201 * process.c (status_message): Use const pointer, in case strsignal
202 is #defined to safe_strsignal.
203 * sysdep.c (sys_siglist, init_signals): Always define and
204 initialize a substitute sys_siglist if the system does not define
205 one, even if HAVE_STRSIGNAL.
206 (safe_strsignal): Rename from strsignal. Always define,
207 using sys_siglist. Return a const pointer.
208 * syssignal.h (safe_strsignal): New decl.
209 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
210
ace917bd
EZ
2112012-10-01 Eli Zaretskii <eliz@gnu.org>
212
213 * w32proc.c (timer_loop): Fix code that waits for timer
214 expiration, to avoid high CPU usage.
215
9eb71b9c
SM
2162012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
217
218 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
219 (sweep_weak_table): Remove redundant prototypes.
220
b3317662
FP
2212012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
222
223 * emacs.c: Move the inclusion of TERM_HEADER after including
224 windows.h on WINDOWSNT. This avoids compilation problems with
225 MSVC.
226
f0e5f225
EZ
2272012-10-01 Eli Zaretskii <eliz@gnu.org>
228
2d7d1608
EZ
229 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
230 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
231 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
232 as the previous version used 'void *'.
233
234 * ralloc.c (ROUNDUP): Fix last change.
235 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
236 'size_t'.
237
f0e5f225
EZ
238 * w32proc.c <disable_itimers>: New static flag.
239 (init_timers): Initialize it to zero, after creating the critical
240 sections used by the timer threads.
241 (term_timers): Set to 1 before deleting the critical sections.
242 (getitimer, setitimer): If disable_itimers is non-zero, return an
243 error indication without doing anything. Reported by Fabrice
244 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
245 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
246 return results.
247 [!HAVE_SETITIMER]: Behave as the previous version that didn't
248 support timers.
f0e5f225
EZ
249
250 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
251 term_ntproc after all the other bookkeeping, to get timers working
252 as long as possible.
253
82ef37c1
PE
2542012-10-01 Paul Eggert <eggert@cs.ucla.edu>
255
b3a4c387
PE
256 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
257 Suggested by Juri Linkov in
258 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
259
b0ab8123
PE
260 Prefer plain 'static' to 'static inline' (Bug#12541).
261 With static functions, modern compilers inline pretty well by
262 themselves; advice from programmers often hurts as much as it helps.
263 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
264 this change shrinks the text size of the Emacs executable by 1.1%
265 without affecting CPU significantly in my benchmark.
266 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
267 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
268 (mark_maybe_object, mark_maybe_pointer, bounded_number):
269 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
270 (bset_auto_fill_function, bset_auto_save_file_format)
271 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
272 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
273 (bset_cache_long_line_scans, bset_case_fold_search)
274 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
275 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
276 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
277 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
278 (bset_header_line_format, bset_indicate_buffer_boundaries)
279 (bset_indicate_empty_lines, bset_invisibility_spec)
280 (bset_left_fringe_width, bset_major_mode, bset_mark)
281 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
282 (bset_name, bset_overwrite_mode, bset_pt_marker)
283 (bset_right_fringe_width, bset_save_length)
284 (bset_scroll_bar_width, bset_scroll_down_aggressively)
285 (bset_scroll_up_aggressively, bset_selective_display)
286 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
287 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
288 (set_buffer_overlays_after):
289 * category.c (bset_category_table):
290 * charset.c (read_hex):
291 * coding.c (produce_composition, produce_charset)
292 (handle_composition_annotation, handle_charset_annotation)
293 (char_encodable_p):
294 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
295 (assign_row, set_frame_matrix_frame, make_current)
296 (add_row_entry):
297 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
298 * fns.c (maybe_resize_hash_table):
299 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
300 * gmalloc.c (register_heapinfo):
301 * image.c (lookup_image_type):
302 * intervals.c (set_interval_object, set_interval_left)
303 (set_interval_right, copy_interval_parent, rotate_right)
304 (rotate_left, balance_possible_root_interval):
305 * keyboard.c (kset_echo_string, kset_kbd_queue)
306 (kset_keyboard_translate_table, kset_last_prefix_arg)
307 (kset_last_repeatable_command, kset_local_function_key_map)
308 (kset_overriding_terminal_local_map, kset_real_last_command)
309 (kset_system_key_syms, clear_event, set_prop):
310 * lread.c (digit_to_number):
311 * marker.c (attach_marker, live_buffer, set_marker_internal):
312 * nsterm.m (ns_compute_glyph_string_overhangs):
313 * process.c (pset_buffer, pset_command)
314 (pset_decode_coding_system, pset_decoding_buf)
315 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
316 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
317 (pset_status, pset_tty_name, pset_type, pset_write_queue):
318 * syntax.c (bset_syntax_table, dec_bytepos):
319 * terminal.c (tset_param_alist):
320 * textprop.c (interval_has_some_properties)
321 (interval_has_some_properties_list):
322 * window.c (wset_combination_limit, wset_dedicated)
323 (wset_display_table, wset_hchild, wset_left_fringe_width)
324 (wset_left_margin_cols, wset_new_normal, wset_new_total)
325 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
326 (wset_right_fringe_width, wset_right_margin_cols)
327 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
328 (wset_vertical_scroll_bar_type, wset_window_parameters):
329 * xdisp.c (wset_base_line_number, wset_base_line_pos)
330 (wset_column_number_displayed, wset_region_showing)
331 (window_box_edges, run_window_scroll_functions)
332 (append_glyph_string_lists, prepend_glyph_string_lists)
333 (append_glyph_string, set_glyph_string_background_width)
334 (append_glyph, append_composite_glyph)
335 (take_vertical_position_into_account):
336 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
337 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
338 (lface_hash, lface_same_font_attributes_p, lookup_face):
339 * xml.c (libxml2_loaded_p):
340 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
341 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
342 Now 'static', not 'static inline'.
343
05584c31
PE
344 * bidi.c: Tune.
345 (bidi_copy_it): Do the whole copy with a single memcpy.
346 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
347
86ec63ba
PE
348 Revert the FOLLOW-SYMLINKS change for file-attributes.
349 Doing it right would require several changes to Tramp, and there's
350 not enough time to get that tested before the freeze today.
351 * dired.c (directory_files_internal, Ffile_attributes):
352 Undo last change.
353
82ef37c1
PE
354 * frame.c (x_report_frame_params): Port better to wider ints.
355 Do not assume that EMACS_UINT is the same width as uprintmax_t,
356 or that pointers can be printed in 15 decimal digits.
357 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
358
62aba0d4
FP
3592012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
360
361 Support x64 build on MS-Windows.
362 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
363 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
364 compatibility with x64.
5e4daaf3 365 (x_get_focus_frame): Add prototype.
62aba0d4
FP
366
367 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
368 defining an XRectangle structure.
369
370 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
371 arithmetics for compatibility with x64.
372
373 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
374 compatibility with x64.
375
376 * w32heap.h: Adjust prototypes and declarations.
377
378 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
379 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
380 DWORD, long, and unsigned long, for compatibility with x64.
381 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
382 (sbrk): Argument is now of type ptrdiff_t.
383
384 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
385 less than 0x0500.
386 (w32_msg_pump): Use WPARAM type for 'result'.
387
388 * w32.c (init_environment, get_emacs_configuration): Support AMD64
389 architecture.
390 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
391 compatibility with x64.
392
393 * vm-limit.c (lim_data): Now size_t.
394 (check_memory_limits): Adjust prototypes of real_morecore and
395 __morecore to receive argument of type ptrdiff_t. Use size_t for
396 five_percent and data_size.
397
398 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
399 variables, for compatibility with x64.
400 (rva_to_section, offset_to_section, relocate_offset)
401 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
402 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
403 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
404 for compatibility with x64.
405
406 * sysdep.c (STDERR_FILENO): Define if not already defined.
407
408 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
409 (__morecore): Argument type is now ptrdiff_t.
410 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
411 (relinquish): Use ptrdiff_t type for 'excess'.
412 (r_alloc_sbrk): Argument type is now ptrdiff_t.
413
414 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
415 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
416 instead of a literal number.
417
418 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
419 (min): Define only if not already defined.
420
421 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
422 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
423 hosts.
424
425 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
426 'bitmaps' is a pointer.
427
428 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
429
430 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
431
e7a2937b
PE
4322012-09-30 Paul Eggert <eggert@cs.ucla.edu>
433
434 file-attributes has a new optional arg FOLLOW-SYMLINKS.
435 * dired.c (directory_files_internal, Ffile_attributes):
436 New arg follow_symlinks. All uses changed.
437
b43d62ae
SM
4382012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
439
440 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
441
c06c382a
EZ
4422012-09-30 Eli Zaretskii <eliz@gnu.org>
443
444 Support atimers and CPU profiler via profile.c on MS-Windows.
445 * w32proc.c (sig_mask, crit_sig): New static variables.
446 (sys_signal): Support SIGALRM and SIGPROF.
447 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 448 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
449 sigfillset, and sigprocmask are no longer no-ops.
450 (sigismember): New function.
451 (struct itimer_data): New definition.
452 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
453 (crit_prof): New static variables.
454 (MAX_SINGLE_SLEEP): New definition.
455 (timer_loop, stop_timer_thread, term_timers, init_timers)
456 (start_timer_thread, getitimer, setitimer): New functions.
457 (alarm): No longer a no-op, calls setitimer.
458
459 * w32.c (term_ntproc): Call term_timers.
460 (init_ntproc): Make sure all signals are unblocked at startup, to
461 erase any traces of dumping. Call init_timers.
462
463 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
464 Windows-specific code to display the hourglass mouse pointer is no
465 longer used.
466 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
467 to hourglass timer expiration.
468 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
469 Remove, no longer used.
b43d62ae
SM
470 (w32_note_current_window, show_hourglass, hide_hourglass):
471 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
472 window systems.
473 (syms_of_w32fns): Don't initialize hourglass_timer.
474
475 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
476 WINDOWSNT as well.
477 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
478
479 * w32.h (init_timers, term_timers): Add prototypes.
480
95402d5f
KH
4812012-09-30 Kenichi Handa <handa@gnu.org>
482
483 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
484 to the buffer relocation which may be caused by ccl_driver.
485
dd946752
JD
4862012-09-30 Jan Djärv <jan.h.d@swipnet.se>
487
d7e642cc
JD
488 * xfns.c (Fx_file_dialog): Update comment.
489
490 * w32fns.c (Fx_file_dialog): Update comment.
491
492 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
493 Initialize panel name field if OSX >= 10.6.
494
495 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
496
dd946752
JD
497 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
498
499 * nsterm.m (NEW_STYLE_FS): New define.
500 (ns_fullscreen_hook, windowWillEnterFullScreen)
501 (windowDidEnterFullScreen, windowWillExitFullScreen)
502 (windowDidExitFullScreen, toggleFullScreen, handleFS)
503 (setFSValue): New functions.
504 (EmacsFSWindow): New implementation.
505 (canBecomeKeyWindow): New function for EmacsFSWindow.
506 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
507 (dealloc): Release nonfs_window if in fullscreen.
508 (updateFrameSize:): Call windowDidMove to update top/left.
509 (windowWillResize:toSize:): Check if frame is still maximized.
510 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
511 next_maximized, maximized_width, maximized_height and nonfs_window.
512 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
513 tbar_height.
514 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
515 fullscreen. Set maximized_width/height. Act on next_maximized.
516
517 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
518 (EmacsView): Add variables for fullscreen.
519 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
520 (EmacsFSWindow): New interface for fullscreen.
521
427730eb
JB
5222012-09-30 Juanma Barranquero <lekktu@gmail.com>
523
524 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
525
48de8b12
CY
5262012-09-30 Chong Yidong <cyd@gnu.org>
527
528 * fns.c (Frandom): Doc fix.
529
5938d519
MR
5302012-09-30 Martin Rudalics <rudalics@gmx.at>
531
532 * window.c (Vwindow_combination_limit): New default value.
533 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
534
cb5b0266
PE
5352012-09-30 Paul Eggert <eggert@cs.ucla.edu>
536
537 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
538 Suggested by Eli Zaretskii in
539 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
540
84f72efd
EZ
5412012-09-30 Eli Zaretskii <eliz@gnu.org>
542
543 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
544 HAVE_TIMER_SETTIME is defined.
545
9d4dcdc9
PE
5462012-09-30 Paul Eggert <eggert@cs.ucla.edu>
547
d89460ed
PE
548 Profiler improvements: more-accurate timers, overflow checks.
549 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
550 signal.h, setjmp.h. Include systime.h instead.
551 (saturated_add): New function.
552 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
553 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
554 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
555 New static vars.
84f72efd 556 (enum profiler_cpu_running): New enum.
d89460ed
PE
557 (profiler_cpu_running): Now of that enum type, not bool.
558 All uses changed to store the new value.
559 (handle_profiler_signal): Rename from sigprof_handler_1,
560 for consistency with other handlers. Do not check whether
561 cpu_log is a hash-table if garbage collecting, since it
562 doesn't matter in that case.
563 (deliver_profiler_signal): Rename from sigprof_handler,
564 for consistency with other handlers.
565 (setup_cpu_timer): New function, with much of what used to be in
566 Fprofiler_cpu_start. Check for out-of-range argument.
567 Prefer timer_settime if available, and prefer
568 thread cputime clocks, then process cputime clocks, then
569 monotonic clocks, to the old realtime clock. Use make_timeval
570 to round more-correctly when falling back to setitimer.
571 (Fprofiler_cpu_start): Use it.
572 (Fprofiler_cpu_stop): Prefer timer_settime if available.
573 Don't assume that passing NULL as the 2nd argument of setitimer
574 is the same as passing a pointer to all-zero storage.
575 Ignore SIGPROF afterwards.
576 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
577 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
578 non-fatal signal handlers. Ignore SIGPROF on startup.
579 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
580 in profiler.c, since sysdep.c now uses it.
581
9d4dcdc9
PE
582 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
583 Suggested by Eli Zaretskii in
584 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
585
8e5691a0
JB
5862012-09-29 Juanma Barranquero <lekktu@gmail.com>
587
588 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
589
e7c1b6ef
SM
5902012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
591
592 * lisp.h (struct backtrace): Remove indirection for `function' field.
593 * xdisp.c (redisplay_internal):
594 * profiler.c (record_backtrace, sigprof_handler_1):
595 * alloc.c (Fgarbage_collect):
596 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
597 (Fbacktrace_frame): Adjust accordingly.
598
e61d39cd 5992012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
600
601 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
602 (Frun_hook_with_args_until_failure): Doc fixes.
603
404043ea
EZ
6042012-09-28 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
607 Qautomatic_redisplay and change the symbol name. All users changed.
608
704d3f45
TM
6092012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
610
611 * profiler.c (sigprof_handler): Fix race condition.
612
757140ff
GM
6132012-09-28 Glenn Morris <rgm@gnu.org>
614
615 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
616
a615a3ae
PE
6172012-09-27 Paul Eggert <eggert@cs.ucla.edu>
618
619 Check more robustly for timer_settime.
89d17fd0
PE
620 * Makefile.in (LIB_TIMER_TIME): New macro.
621 (LIBES): Add it.
a615a3ae
PE
622 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
623 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
624 call timer_settime.
625
3670daf7
TM
6262012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
627
628 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
629
6a586b7f
JB
6302012-09-26 Juanma Barranquero <lekktu@gmail.com>
631
632 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
633
41c8bfcf
PE
6342012-09-26 Paul Eggert <eggert@cs.ucla.edu>
635
636 * character.h (MAYBE_UNIFY_CHAR): Remove.
637 * charset.c, charset.h (maybe_unify_char): Now static.
638 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
639 Since this stuff is now private to charset.c, there's no need for
640 a public macro and no need to inline by hand.
641
3a880af4
SM
6422012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
643 Stefan Monnier <monnier@iro.umontreal.ca>
644 Juanma Barranquero <lekktu@gmail.com>
611b7507 645
3a880af4
SM
646 * profiler.c: New file.
647 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
648 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
649 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
650 * emacs.c (main): Call syms_of_profiler.
651 * alloc.c (Qautomatic_gc): New constant.
652 (MALLOC_PROBE): New macro.
653 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
654 (total_bytes_of_live_objects): New function.
655 (Fgarbage_collect): Use it. Record itself in backtrace_list.
656 Call malloc_probe for the memory profiler.
657 (syms_of_alloc): Define Qautomatic_gc.
658 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
659 race condition.
660 (struct backtrace): Move definition...
661 * lisp.h (struct backtrace): ..here.
662 (Qautomatic_gc, profiler_memory_running): Declare vars.
663 (malloc_probe, syms_of_profiler): Declare functions.
664 * xdisp.c (Qautomatic_redisplay): New constant.
665 (redisplay_internal): Record itself in backtrace_list.
666 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 667
5938d519 6682012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
6692012-09-25 Juanma Barranquero <lekktu@gmail.com>
670
671 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
672
e26fd2e4
PE
6732012-09-25 Paul Eggert <eggert@cs.ucla.edu>
674
675 Prefer POSIX timers if available.
676 They avoid a race if the timer is too close to the current time.
677 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
678 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 679 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 680
eedec3ee
EZ
6812012-09-25 Eli Zaretskii <eliz@gnu.org>
682
683 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
684 CHAR_STRING_ADVANCE.
685 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
686 STRING_CHAR_ADVANCE.
687
aa15c6bb
JB
6882012-09-25 Juanma Barranquero <lekktu@gmail.com>
689
690 Move Vlibrary_cache to emacs.c and reset before dumping.
691
692 * lisp.h (reset_image_types): Declare.
693 [WINDOWSNT] (Vlibrary_cache): Declare.
694
695 * image.c (reset_image_types): New function.
696
697 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
698 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
699 (Fdump_emacs): Reset Vlibrary_cache and image_types.
700
701 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
702 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
703
704 * w32.h (Vlibrary_cache): Do not declare.
705
54d629be
EZ
7062012-09-25 Eli Zaretskii <eliz@gnu.org>
707
16b22fef
EZ
708 * w32proc.c (sys_signal): Handle all signals defined by the
709 MS-Windows runtime, not just SIGCHLD. Actually install the signal
710 handlers for signals supported by Windows. Don't override
711 term_ntproc as the handler for SIGABRT.
712 (sigaction): Rewrite to call sys_signal instead of duplicating its
713 code.
714 (sys_kill): Improve commentary.
715
716 * w32.c (term_ntproc): Accept (and ignore) one argument, for
717 consistency with a signature of a signal handler. All callers
718 changed.
719 (init_ntproc): Accept an argument DUMPING. If dumping, don't
720 install term_ntproc as a signal handler for SIGABRT, as that
721 should be done by the dumped Emacs.
722
723 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
724
725 * w32select.c (term_w32select): Protect against repeated
726 invocation by setting clipboard_owner to NULL after calling
727 DestroyWindow.
728
729 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
730 and term_ntproc to their modified signatures.
731
54d629be
EZ
732 * character.c (char_string, string_char): Remove calls to
733 MAYBE_UNIFY_CHAR. See the discussion starting at
734 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
735 for the details.
736
59f7af81
CY
7372012-09-25 Chong Yidong <cyd@gnu.org>
738
739 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
740
22e8cf4a
SM
7412012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
742
743 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
744 when encountering an unknown bytecode.
745
578098f3
PE
7462012-09-24 Paul Eggert <eggert@cs.ucla.edu>
747
748 image.c, indent.c: Use bool for booleans.
749 * dispextern.h (struct image_type): Members valid_p, load, init
750 now return bool, not int. All uses changed.
751 * image.c: Omit unnecessary static decls.
752 (x_create_bitmap_mask, x_build_heuristic_mask):
753 Return void, not int, since callers don't care about the return value.
754 (x_create_bitmap_mask, define_image_type, valid_image_p)
755 (struct image_keyword, parse_image_spec, image_spec_value)
756 (check_image_size, image_background)
757 (image_background_transparent, x_clear_image_1)
758 (postprocess_image, lookup_image, x_check_image_size)
759 (x_create_x_image_and_pixmap, xbm_image_p)
760 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
761 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
762 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
763 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
764 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
765 (png_image_p, init_png_functions, png_load_body, png_load)
766 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
767 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
768 (init_gif_functions, gif_load, imagemagick_image_p)
769 (imagemagick_load_image, imagemagick_load, svg_image_p)
770 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
771 (gs_load):
772 * nsimage.m (ns_load_image):
773 * nsterm.m (ns_defined_color):
774 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
775 * xfns.c (x_defined_color):
776 * xterm.c (x_alloc_lighter_color_for_widget)
777 (x_alloc_nearest_color_1, x_alloc_nearest_color)
778 (x_alloc_lighter_color):
779 * indent.c (disptab_matches_widthtab, current_column)
780 (scan_for_column, string_display_width, indented_beyond_p)
781 (compute_motion, vmotion, Fvertical_motion):
782 Use bool for booleans.
783
a5f2b6ec
CY
7842012-09-24 Chong Yidong <cyd@gnu.org>
785
786 * chartab.c (Fset_char_table_default): Obsolete function removed.
787
18e27ea8
PE
7882012-09-23 Paul Eggert <eggert@cs.ucla.edu>
789
afea8a8a
PE
790 Move pid_t related decls out of lisp.h.
791 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
792 (interruptible_wait_for_termination):
793 Move these decls from lisp.h to syswait.h, since they use pid_t.
794 Needed on FreeBSD; see Herbert J. Skuhra in
795 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
796 * callproc.c: Include syswait.h.
797
18e27ea8
PE
798 gnutls.c, gtkutil.c: Use bool for boolean.
799 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
800 (emacs_gnutls_handle_error):
801 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
802 (xg_hide_tooltip, xg_create_frame_widgets)
803 (create_dialog, xg_uses_old_file_dialog)
804 (xg_get_file_with_chooser, xg_get_file_with_selection)
805 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
806 (xg_item_label_same_p, xg_update_menubar)
807 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
808 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
809 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
810 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
811 (update_frame_tool_bar, free_frame_tool_bar):
812 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
813 * nsmenu.m (ns_update_menubar):
814 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
815 * xfns.c (Fx_show_tip) [USE_GTK]:
816 Use bool for boolean.
817 * gtkutil.c (xg_update_frame_menubar):
818 * xmenu.c (update_frame_menubar):
819 Return void, not int, since caller ignores return value.
820 * gtkutil.c (xg_change_toolbar_position):
821 Return void, not 1.
822
af0e9f75
JB
8232012-09-23 Juanma Barranquero <lekktu@gmail.com>
824
825 * makefile.w32-in (BLOCKINPUT_H): Remove.
826 (SYSSIGNAL_H): New macro.
827 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
828 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
829 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
830 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
831 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
832 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
833 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
834 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
835 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
836 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
837 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
838 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
839 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
840 ($(BLD)/w32xfns.$(O)): Update dependencies.
841
5101529e
EZ
8422012-09-23 Eli Zaretskii <eliz@gnu.org>
843
844 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
845 fatal_error_backtrace.
846
847 * w32proc.c (sys_kill): Undo last change: don't do anything when
848 invoked to deliver SIGABRT to our own process. This is now
849 handled by emacs_raise.
850
2c3ee0ad
JB
8512012-09-23 Juanma Barranquero <lekktu@gmail.com>
852
853 * w32term.c (w32_read_socket): Remove leftover reference to
854 interrupt_input_pending.
855
62a1d661
PE
8562012-09-23 Paul Eggert <eggert@cs.ucla.edu>
857
858 Do not use SA_NODEFER.
859 Problem reported by Dani Moncayo in
860 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
861 * alloc.c (die):
862 * sysdep.c (emacs_abort): Do not reset signal handler.
863 * emacs.c (terminate_due_to_signal): Reset signal handler here.
864 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
865 wanted even on POSIXish hosts, and it doesn't work on Windows.
866
a0942b9a
JD
8672012-09-23 Jan Djärv <jan.h.d@swipnet.se>
868
869 * xterm.c (x_term_init): Call fixup_locale before and after calling
870 gtk_init (Bug#12392).
871
d07ff9db
CY
8722012-09-23 Chong Yidong <cyd@gnu.org>
873
874 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
875 Vdynamic_library_alist.
876
877 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
878 (Fgnutls_available_p): Caller changed.
879
880 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
881 (Flibxml_parse_xml_region): Likewise.
882
883 * dispextern.h (struct image_type): Remove arg from init function.
884
885 * image.c (Finit_image_library, lookup_image_type)
886 (define_image_type): Remove now-unneeded second arg.
887 (init_xpm_functions, init_png_functions, init_jpeg_functions)
888 (init_tiff_functions, init_gif_functions, init_svg_functions):
889 Arglist and w32_delayed_load calling convention changed.
890 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 891 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 892
4d7e6e51
PE
8932012-09-23 Paul Eggert <eggert@cs.ucla.edu>
894
895 Simplify and avoid signal-handling races (Bug#12471).
896 * alloc.c (die):
897 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
898 Avoid recursive loop if there's a fatal error in the function itself.
899 * atimer.c (pending_atimers):
900 * blockinput.h: Don't include "atimer.h"; no longer needed.
901 (interrupt_input_pending): Remove. All uses removed.
902 pending_signals now counts both atimers and ordinary interrupts.
903 This is less racy than having three separate pending-signal flags.
904 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
905 (input_blocked_p):
906 Rename from their upper-case counterparts BLOCK_INPUT,
907 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
908 INPUT_BLOCKED_P, and turn into functions. All uses changed.
909 This makes it easier to access volatile variables more accurately.
910 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
911 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
912 that's more reliable if the code is buggy and sets
913 interrupt_input_blocked to a negative value. All uses changed.
914 * atimer.c (deliver_alarm_signal):
915 Remove. No need to deliver this to the parent; any thread can
916 handle this signal now. All uses replaced by underlying handler.
917 * atimer.c (turn_on_atimers):
918 * dispnew.c (handle_window_change_signal):
919 * emacs.c (handle_danger_signal):
920 * keyboard.c (kbd_buffer_get_event):
921 Don't reestablish signal handler; not needed with sigaction.
922 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
923 (UNBLOCK_INPUT_TO):
924 Rework to avoid unnecessary accesses to volatile variables.
925 (UNBLOCK_INPUT_TO): Now a function.
926 (totally_unblock_input, unblock_input): New decls.
927 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
928 (init_data): Remove. Necessary stuff now done in init_signal.
929 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
930 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
931 (fatal_error_code): Remove; no longer needed.
932 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
933 it doesn't always backtrace. All uses changed. No need to reset
934 signal to default, since sigaction and/or die does that for us now.
935 Use emacs_raise (FOO), not kill (getpid (), FOO).
936 (main): Check more-accurately whether we're dumping.
937 Move fatal-error setup to sysdep.c
938 * floatfns.c: Do not include "syssignal.h"; no longer needed.
939 * gtkutil.c (xg_get_file_name, xg_get_font):
940 Remove no-longer-needed signal-mask manipulation.
941 * keyboard.c, process.c (POLL_FOR_INPUT):
942 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
943 * keyboard.c (read_avail_input): Remove.
944 All uses replaced by gobble_input.
945 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
946 (kbd_buffer_store_event_hold, gobble_input):
947 (record_asynch_buffer_change) [USABLE_SIGIO]:
948 (store_user_signal_events):
949 No need to mess with signal mask.
950 (gobble_input): If blocking input and there are terminals, simply
951 set pending_signals to 1 and return. All hooks changed to not
952 worry about whether input is blocked.
953 (process_pending_signals): Clear pending_signals before processing
954 them, in case a signal comes in while we're processing.
955 By convention callers now test pending_signals before calling us.
956 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
957 New functions, to support changes to blockinput.h.
958 (handle_input_available_signal): Now extern.
959 (reinvoke_input_signal): Remove. All uses replaced by
960 handle_async_input.
961 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
962 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
963 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
964 Clear sigmask reliably, even if Fsignal returns, which it can.
965 Omit unnecessary accesses to volatile var.
966 (quit_throw_to_read_char): No need to restore sigmask.
967 * keyboard.c (gobble_input, handle_user_signal):
968 * process.c (wait_reading_process_output):
969 Call signal-handling code rather than killing ourselves.
970 * lisp.h: Include <float.h>, for...
971 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
972 (pending_signals): Now volatile.
973 (syms_of_data): Now const if IEEE floating point.
974 (handle_input_available_signal) [USABLE_SIGIO]:
975 (terminate_due_to_signal, record_child_status_change): New decls.
976 * process.c (create_process): Avoid disaster if memory is exhausted
977 while we're processing a vfork, by tightening the critical section
978 around the vfork.
979 (send_process_frame, process_sent_to, handle_pipe_signal)
980 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
981 ignores SIGPIPE.
982 (send_process): No need for setjmp/longjmp any more, since the
983 SIGPIPE stuff is now gone. Instead, report an error if errno
984 is EPIPE.
985 (record_child_status_change): Now extern. PID and W are now args.
986 Return void, not bool. All callers changed.
987 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
988 Remove. All uses removed. This bug should be fixed now in a
989 different way.
990 (wait_for_termination_1): Use waitpid rather than sigsuspend,
991 and record the child status change directly. This avoids the
992 need to futz with the signal mask.
993 (process_fatal_action): Move here from emacs.c.
994 (emacs_sigaction_flags): New function, containing
995 much of what used to be in emacs_sigaction_init.
996 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
997 caught by emacs, to make races less likely.
998 (deliver_process_signal): Rename from handle_on_main_thread.
999 All uses changed.
1000 (BACKTRACE_LIMIT_MAX): Now at top level.
1001 (thread_backtrace_buffer, threadback_backtrace_pointers):
1002 New static vars.
1003 (deliver_thread_signal, deliver_fatal_thread_signal):
1004 New functions, for more-accurate delivery of thread-specific signals.
1005 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
1006 (deliver_arith_signal): Handle in this thread, not
1007 in the main thread, since it's triggered by this thread.
1008 (maybe_fatal_sig): New function.
1009 (init_signals): New arg DUMPING so that we can be more accurate
1010 about whether we're dumping. Caller changed.
1011 Treat thread-specific signals differently from process-general signals.
1012 Block all signals while handling fatal error; that's safer.
1013 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
1014 on IEEE hosts.
1015 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
1016 Ignore SIGPIPE unless batch.
1017 (emacs_backtrace): Output backtrace for the appropriate thread,
1018 which is not necessarily the main thread.
1019 * syssignal.h: Include <stdbool.h>.
1020 (emacs_raise): New macro.
1021 * xterm.c (x_connection_signal): Remove; no longer needed
1022 now that we use sigaction.
1023 (x_connection_closed): No need to mess with sigmask now.
1024 (x_initialize): No need to reset SIGPIPE handler here, since
1025 init_signals does this for us now.
1026
8f4635e9
JD
10272012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1028
1029 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 1030 background rect may be larger (Bug#12245).
8f4635e9 1031
3296976d
CY
10322012-09-23 Chong Yidong <cyd@gnu.org>
1033
1034 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
1035
d41e491e
PE
10362012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * .gdbinit: Just stop at fatal_error_backtrace.
1039 See Stefan Monnier's request in
1040 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
1041 Remove no-longer-used query of system type.
1042
c88b867f
CY
10432012-09-22 Chong Yidong <cyd@gnu.org>
1044
1045 * search.c (Freplace_match): Doc fix (Bug#12325).
1046
1047 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
1048
1049 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
1050 (Fline_end_position): Doc fix.
1051
1052 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
1053
bb4d86b4
CY
10542012-09-22 Chong Yidong <cyd@gnu.org>
1055
1056 * dispextern.h (struct image_type): Add new slot, storing a type
1057 initialization function.
1058
1059 * image.c (define_image_type): Call the image initializer function
1060 if it is defined. Arguments and return value changed.
1061 (valid_image_p, make_image): Callers changed.
1062 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
1063 (gif_type, imagemagick_type, svg_type, gs_type):
1064 Add initialization functions.
bb4d86b4
CY
1065 (Finit_image_library): Call lookup_image_type.
1066 (CHECK_LIB_AVAILABLE): Macro deleted.
1067 (lookup_image_type): Call define_image_type here, rather than via
1068 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
1069 (syms_of_image): Move define_image_type calls for xbm_type and
1070 pbm_type to lookup_image_type.
1071
df9685f3
EZ
10722012-09-22 Eli Zaretskii <eliz@gnu.org>
1073
1074 * keyboard.c (timer_check_2): Move calculation of 'timers' and
1075 'idle_timers' from here ...
1076 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
1077 lists, to avoid infloops when the timer does something stupid,
1078 like reinvoke itself with the same or smaller time-out.
1079 (Bug#12447)
1080
8e17c9ba
MR
10812012-09-22 Martin Rudalics <rudalics@gmx.at>
1082
1083 * window.c (Fsplit_window_internal): Handle only Qt value of
1084 Vwindow_combination_limit separately.
1085 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
1086 (Vwindow_combination_limit): New default value.
1087 Rewrite doc-string.
8e17c9ba 1088
589bd69b
EZ
10892012-09-22 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
1092 the new overlay string. (Bug#10159)
1093
01108e3f
PE
10942012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
1097 or that fprintf is async-signal-safe. POSIX doesn't require
1098 either assumption.
1099
82f8cd94
CY
11002012-09-22 Chong Yidong <cyd@gnu.org>
1101
1102 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
1103 (Bug#8207).
1104
3cccbd87
KH
11052012-09-22 Kenichi Handa <handa@gnu.org>
1106
1107 * composite.c (composition_reseat_it): Handle the case that a
1108 grapheme cluster is not covered by a single font (Bug#12352).
1109
09c01941
CY
11102012-09-21 Chong Yidong <cyd@gnu.org>
1111
1112 * image.c (define_image_type): Avoid adding duplicate types to
1113 image_types (Bug#12463). Suggested by Jörg Walter.
1114
acfa068f 11152012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
1116
1117 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
1118 (print_load_command_name): Add case LC_DATA_IN_CODE.
1119 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
1120
acfa068f 11212012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
1122
1123 * eval.c (Frun_hook_with_args_until_success)
1124 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
1125
acfa068f 11262012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
1127
1128 * fileio.c (Ffile_selinux_context): Only call freecon when
1129 lgetfilecon succeeded.
1130 (Fset_file_selinux_context): Likewise. (Bug#12444)
1131
acfa068f 11322012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
1133
1134 * xdisp.c (try_window_reusing_current_matrix): Under bidi
1135 reordering, locate the cursor by calling set_cursor_from_row; if
1136 that fails, clear the desired glyph matrix before returning a
1137 failure indication to the caller. Fixes leaving garbled display
1138 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
1139 (compute_stop_pos_backwards): Fix a typo that caused crashes while
1140 scrolling through multibyte text.
aa36e4d2 1141
e99f70c8
SM
11422012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
1143
1144 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
1145 calling mark_vectorlike since that's the one that marks the window.
1146 (mark_discard_killed_buffers): Mark the final cdr.
1147 * window.h (struct window): Move prev/next_buffers to the
1148 non-standard fields.
1149 * window.c (make_window): Initialize prev/next_buffers manually.
1150
f75beb47
PE
11512012-09-20 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 Omit unused arg EXPECTED from socket hooks.
1154 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
1155 * nsterm.m (ns_term_init):
1156 * termhooks.h (struct terminal.read_socket_hook):
1157 * w32inevt.c (w32_console_read_socket):
1158 * w32term.c (w32_read_socket):
1159 * xterm.c (XTread_socket):
1160 Omit unused arg EXPECTED. All callers changed.
1161 (store_user_signal_events): Return void, not int, since callers no
1162 longer care about the return value. All uses changed.
1163
b019b76a
JB
11642012-09-20 Juanma Barranquero <lekktu@gmail.com>
1165
1166 * w32gui.h (XParseGeometry): Do not declare.
1167
05642592
PE
11682012-09-19 Paul Eggert <eggert@cs.ucla.edu>
1169
e4bce92a
PE
1170 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1171 Ignore 'expected'. See Eli Zaretskii in
1172 <http://bugs.gnu.org/12471#8> (last line).
1173
05642592
PE
1174 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
1175 (XParseGeometry): Now static. Substitute extremal values for
1176 values that are out of range.
1177
e543ae91
JD
11782012-09-19 Jan Djärv <jan.h.d@swipnet.se>
1179
1180 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
1181
1182 * nsfns.m (XParseGeometry): Remove.
1183 (Fx_create_frame): Call x_set_offset to correctly interpret
1184 top_pos in geometry.
1185
3a880af4 1186 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
1187 (Fx_parse_geometry): If there is a space in string, call
1188 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
1189
45ba16c7
EZ
11902012-09-17 Eli Zaretskii <eliz@gnu.org>
1191
c8b9f1bc
EZ
1192 * search.c (scan_buffer): Use character positions in calls to
1193 region_cache_forward and region_cache_backward, not byte
1194 positions. (Bug#12196)
1195
b4c932a2
EZ
1196 * w32term.c (w32_read_socket): Set pending_signals to 1, like
1197 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
1198
45ba16c7
EZ
1199 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
1200 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
1201 emacs_blocked_malloc, now deleted.
1202
eeceac93
PE
12032012-09-17 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
1206 The workaround was for improving performance on Solaris 2.4, but
1207 is getting in the way now. Emacs will still work if someone is
1208 still running Solaris 2.4 in a museum somewhere; Sun dropped
1209 support for Solaris 2.4 in 2003.
1210 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
1211 * process.c (create_process) [HAVE_WORKING_VFORK]:
1212 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
1213 since Emacs no longer uses vfork on that platform.
1214
78f83752
GM
12152012-09-17 Glenn Morris <rgm@gnu.org>
1216
1217 * emacs.c: Use COPYRIGHT.
1218
634b8cac
PE
12192012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1220
0caaedb1
PE
1221 Remove configure's --without-sync-input option (Bug#12450).
1222 When auditing signal-handling in preparation for cleaning it up,
1223 I found that SYNC_INPUT has race conditions and would be a real
1224 pain to fix. Since it's an undocumented and deprecated
1225 configure-time option, now seems like a good time to remove it.
1226 Also see <http://bugs.gnu.org/11080#16>.
1227 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1228 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1229 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1230 (malloc_hysteresis):
1231 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1232 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1233 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1234 (dont_register_blocks, bytes_used_when_reconsidered)
1235 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1236 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1237 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1238 Remove. All uses removed.
1239 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1240 implementation, one that depends on whether the new macro
1241 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1242 is defined.
1243 * atimer.c (run_timers, handle_alarm_signal):
1244 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1245 (handle_async_input, process_pending_signals)
1246 (handle_input_available_signal, init_keyboard):
1247 * nsterm.m (ns_read_socket):
1248 * process.c (wait_reading_process_output):
1249 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1250 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1251 (emacs_write):
1252 * xterm.c (XTread_socket):
1253 Assume SYNC_INPUT.
1254 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1255 * eval.c (handling_signal): Remove. All uses removed.
1256 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1257 All uses replaced with the SYNC_INPUT version.
1258 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1259 Remove decls.
1260 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1261 Now static.
1262
634b8cac
PE
1263 * font.c (Ffont_shape_gstring): Remove unused local.
1264
83da1b55
GM
12652012-09-16 Glenn Morris <rgm@gnu.org>
1266
518650a5
GM
1267 * Makefile.in (clean): No longer run nextstep's clean.
1268
83da1b55
GM
1269 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1270 (ns_frag): Remove.
1271 (ns-app): Move here from ns.mk, and simplify.
1272 (clean): Simplify nextstep entry.
1273 * ns.mk: Remove file.
1274
85a43e2e
KH
12752012-09-17 Kenichi Handa <handa@gnu.org>
1276
1277 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1278 not covert the last few charactes.
1279
ba13e616 12802012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1281
1282 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1283 here, but just check the validity of glyphs in the glyph-string.
1284
a8c729af
MR
12852012-09-16 Martin Rudalics <rudalics@gmx.at>
1286
3a880af4
SM
1287 * window.c (Fwindow_parameter, Fset_window_parameter):
1288 Accept any window as argument (Bug#12452).
a8c729af 1289
c077c059
JD
12902012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1293 to ns_term_init to avoid memory leak.
1294
1295 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1296 explicit retain/release.
1297 (ns_term_init): Only allow one display. Initialize outerpool and
1298 ns_*_types.
1299
39a57ad0
PE
13002012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1303 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1304 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1305 the Microsoft problem in a different way, by altering ../nt/config.nt.
1306
7105c8cb
EZ
13072012-09-15 Eli Zaretskii <eliz@gnu.org>
1308
1309 * w32xfns.c:
1310 * w32uniscribe.c:
1311 * w32term.c:
1312 * w32select.c:
1313 * w32reg.c:
1314 * w32proc.c:
1315 * w32menu.c:
1316 * w32inevt.c:
1317 * w32heap.c:
1318 * w32font.c:
1319 * w32fns.c:
1320 * w32console.c:
1321 * w32.c:
1322 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1323 by lisp.h. This completes removal of setjmp.h inclusion
1324 erroneously announced in the previous commit. (Bug#12446)
1325
1326 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1327 more accurate.
1328
1329 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1330 not defined as a macro. The latter happens on MS-Windows.
1331 (Bug#12446)
1332
0328b6de
PE
13332012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1336 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1337 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1338 only reason for the instance was because "lisp.h" was included.
1339 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1340 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1341 and _longjmp with the new symbols. Emacs already uses _setjmp if
1342 available, so this change affects only POSIXish hosts that have
1343 sigsetjmp but not _setjmp, such as some versions of Solaris and
1344 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1345 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1346 (png_load_body) [HAVE_PNG]:
1347 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1348 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1349 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1350 since PNG requires jmp_buf. This is the only exception to the
1351 general rule that we now use sys_setjmp and sys_longjmp.
1352 This exception is OK since this code does not change the signal
1353 mask or longjmp out of a signal handler.
1354
2af03429
PE
13552012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1358 Include "syssignal.h", for 'main_thread'.
1359
2f294edf
DA
13602012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1363 * insdel.c (replace_range, replace_range_2):
1364 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1365 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1366 Remove redundant check before calling offset_intervals.
1367
6b533e9c
MR
13682012-09-14 Martin Rudalics <rudalics@gmx.at>
1369
1370 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1371 current buffer (Bug#12387).
1372
2a7931e3
JB
13732012-09-14 Juanma Barranquero <lekktu@gmail.com>
1374
1375 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1376
c18e885b
PE
13772012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 Use a more backwards-compatible timer format (Bug#12430).
1380 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1381 vector element, not from the 4th, since PSECS is now at the end.
1382 (Fcurrent_idle_time): Doc fix.
1383
d59a1afb
DA
13842012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1385
1386 Function to mark objects and remove killed buffers at once.
1387 * alloc.c (discard_killed_buffers): Rename to ...
1388 (mark_discard_killed buffers) ... new name. Add marking
1389 of remaining objects. Fix comment. Adjust users.
1390 (mark_object): Do not touch frame buffer lists here.
1391 * frame.c (delete_frame): Reset frame buffer lists here.
1392
5f0cb45a
PE
13932012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1394
8ea47e3a
PE
1395 Better workaround for GNOME bug when --enable-gcc-warnings.
1396 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1397 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1398 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1399
4a4bbad2
PE
1400 Simplify SIGIO usage (Bug#12408).
1401 The code that dealt with SIGIO was crufty and confusing, e.g., it
1402 played tricks like "#undef SIGIO" but these tricks were not used
1403 consistently. Simplify mostly by not #undeffing standard symbols,
1404 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1405 or not as we please) rather than "defined SIGIO" (standard symbol
1406 that we probably shouldn't #undef).
1407 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1408 Modules that need it can include it.
1409 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1410 * dispextern.h (ignore_sigio): New decl.
1411 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1412 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1413 * emacs.c (shut_down_emacs):
1414 * keyboard.c (kbd_buffer_store_event_hold):
1415 Use ignore_sigio rather than invoking 'signal' directly.
1416 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1417 for FIONREAD.
1418 (FIONREAD, SIGIO): Do not #undef.
1419 (tty_read_avail_input): Use #error rather than a syntax error.
1420 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1421 for I_PIPE, used by SETUP_SLAVE_PTY.
1422 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1423 * sysdep.c (croak): Remove; no longer needed. This bit of
1424 temporary code, with Fred N. Fish's comment that it's temporary,
1425 has been in Emacs since at least 1992!
1426 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1427 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1428 * syssignal.h (croak): Remove decl.
1429 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1430 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1431 now that we're termios-only.
1432 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1433 * term.c (dissociate_if_controlling_tty): Use #error rather than
1434 a run-time error.
1435
5f0cb45a
PE
1436 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1437 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1438 to work around GNOME bug 683906.
1439 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1440 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1441 This works around GCC bug 54561.
1442
40bce90b
PE
14432012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 More fixes for 'volatile' and setjmp/longjmp.
1446 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1447 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1448 (png_load_body) [HAVE_PNG]:
1449 (jpeg_load_body) [HAVE_JPEG]:
1450 New function, with most of the old parent function's body.
1451 (png_load) [HAVE_PNG]:
1452 (jpeg_load) [HAVE_JPEG]:
1453 Invoke the new function, to avoid longjmp munging our locals.
1454 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1455 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1456 longjmp is passed 2, as the C standard doesn't guarantee this.
1457 Instead, store the failure code into mgr->failure_code.
1458
bfeae2cf
SM
14592012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1460
1461 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1462 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1463 (syms_of_keyboard): Remove support for unread-command-char.
1464
8099e36b
EZ
14652012-09-12 Eli Zaretskii <eliz@gnu.org>
1466
1467 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1468 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1469 violation. (Bug#12426)
1470
92547ff9
PE
14712012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1474
45b82ad0
SM
14752012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * eval.c: Add `inhibit-debugger'.
1478 (Qinhibit_debugger): New symbol.
1479 (call_debugger): Bind it instead of Qdebug_on_error.
1480 (maybe_call_debugger): Test Vinhibit_debugger.
1481 (syms_of_eval): Define inhibit-debugger.
1482 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1483 (syms_of_xdisp): Remove inhibit-debug-on-message.
1484
5779a1dc
PE
14852012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1486
50f2e553
PE
1487 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1488 If a nonvolatile local variable is written before a _longjmp to
1489 the frame containing the variable, and is read after the _longjmp,
1490 the value read is indeterminate. Some local variables of type
1491 'struct handler' and 'struct catchtag' are used in this way, so
1492 mark each of their slots as volatile if the slot can be set before
1493 _longjmp and read afterwards.
1494 * lisp.h (struct handler): var and chosen_clause are now volatile.
1495 (struct catchtag): val, next, and pdlcount are now volatile.
1496
ae1d87e2
PE
1497 * bidi.c (bidi_push_it, bidi_pop_it):
1498 * fns.c (copy_hash_table):
1499 * image.c (define_image_type):
1500 * keyboard.c (kbd_buffer_store_event_hold):
1501 * process.c (Fprocess_send_eof):
1502 * xfaces.c (x_create_gc) [HAVE_NS]:
1503 * xgselect.c (xg_select):
1504 Prefer assignment to memcpy when either will do.
1505
5779a1dc
PE
1506 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1507 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1508 time an item is removed. No need to mark this function 'inline';
1509 the compiler knows better than we do.
1510
c4c9756b
JD
15112012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1512
1513 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1514 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1515 to change_frame_size (Bug#12388).
1516 (windowDidResize:): Pass YES to updateFrameSize.
1517
1518 * nsterm.h: Add delay parameter to updateFrameSize.
1519
d73e321c
DA
15202012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1521
1522 Discard killed buffers from deleted window and frame objects.
1523 This reduces an amount of references to killed buffers and
1524 helps GC to reclaim them faster.
1525 * alloc.c (discard_killed_buffers): New function.
1526 (mark_object): Use it for deleted windows and frames.
1527 (mark_object): If symbol's value is set up for a killed buffer
1528 or deleted frame, restore it's global binding.
1529 * data.c (swap_in_global_binding): Add GC notice.
1530 (swap_in_symval_forwarding): Use convenient set_blv_where.
1531 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1532 * window.h: ... to here.
1533
e578f381
DA
15342012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Convenient macro to check whether the buffer is live.
1537 * buffer.h (BUFFER_LIVE_P): New macro.
1538 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1539 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1540
3057e615
YM
15412012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1542
1543 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1544 composition cases (Bug#12364).
1545
1546 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1547 overhang of succeeding glyphs overlapping box cursor.
1548
1549 * w32term.c (x_draw_glyph_string): Likewise.
1550
6fda35f2
PE
15512012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1552
c990426a
PE
1553 Simplify, document, and port floating-point (Bug#12381).
1554 The porting part of this patch fixes bugs on non-IEEE platforms
1555 with frexp, ldexp, logb.
1556 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1557 Now static.
1558 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1559 support, by removing commented-out code and briefly listing the
1560 C89 functions excluded. The commented-out stuff was confusing
1561 maintenance, e.g., we thought we needed cbrt but it was commented out.
1562 (logb): Remove decl; no longer needed.
1563 (isfinite): New macro, if not already supplied.
1564 (isnan): Don't replace any existing macro.
1565 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1566 are present on all C89 platforms.
1567 (Ffrexp): Do not special-case zero, as frexp does the right thing
1568 for that case.
1569 (Flogb): Do not use logb, as it doesn't have the desired meaning
1570 on hosts that use non-base-2 floating point. Instead, stick with
1571 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1572 frexp, to avoid getting an unspecified result.
1573
6fda35f2
PE
1574 * xdisp.c (Qinhibit_debug_on_message): Now static.
1575
16130a58
JD
15762012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1577
1578 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1579 NSBezierPath (Bug#12131).
1580
d105a573
CY
15812012-09-10 Chong Yidong <cyd@gnu.org>
1582
1583 * fns.c (Fdelq, Fdelete): Doc fix.
1584
ff55dfe8
PE
15852012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1588 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1589
e7032e7c
SM
15902012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1593 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1594 Use it.
1595
e9957956
EZ
15962012-09-09 Eli Zaretskii <eliz@gnu.org>
1597
aba05ce9
EZ
1598 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1599 left fringe if the window has a left margin. This avoids leaving
1600 traces of the cursor because its leftmost pixel is not drawn over.
1601
e9957956
EZ
1602 * dispnew.c (update_window_line): When the left margin area of a
1603 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1604 that screen line. (Bug#12277)
1605
f6196b87
PE
16062012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 Assume C89 or later for math functions (Bug#12381).
1609 This simplifies the code, and makes it a bit smaller and faster,
1610 and (most important) makes it easier to clean up signal handling
1611 since we can stop worring about floating-point exceptions in
1612 library code. That was a problem before C89, but the problem
1613 went away many years ago on all practical Emacs targets.
1614 * data.c, image.c, lread.c, print.c:
1615 Don't include <math.h>; no longer needed.
1616 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1617 might be autoconfigured, as that never happens.
1618 * data.c (fmod):
1619 * doprnt.c (DBL_MAX_10_EXP):
1620 * print.c (DBL_DIG):
1621 Remove. C89 or later always defines these.
1622 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1623 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1624 (arith_error, domain_error, domain_error2):
1625 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1626 no longer needed -- we simply return what C returns. All uses removed.
1627 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1628 the wrapped code.
1629 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1630 Remove. All uses expanded, as these macros are no longer used
1631 more than once and are now more trouble than they're worth.
1632 (Ftan): Use tan, not sin / cos.
1633 (Flogb): Assume C89 frexp.
1634 (fmod_float): Assume C89 fmod.
1635 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1636 (init_floatfns): Remove. All uses removed.
1637
9d7f1863
JD
16382012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1639
1640 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1641 compositeToPoint for OSX < 10.6 (Bug#12390).
1642
eabf0404
PE
16432012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1646 This produces more-accurate results.
1647
0b3b1d23
JD
16482012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1649
1650 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1651 changes (Bug#12088).
1652
6dcef6ec
CY
16532012-09-08 Chong Yidong <cyd@gnu.org>
1654
1655 * syntax.c (Fstring_to_syntax): Doc fix.
1656
aa7d57c5
JD
16572012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1658
1659 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1660 in the internal border.
1661 (x_set_window_size): Remove static variables and their usage.
1662 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1663 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1664 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1665 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1666 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1667 (ns_fix_rect_ibw): Remove.
1668 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1669 (ns_dumpglyphs_box_or_relief): Ditto.
1670 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1671 adjustment.
1672 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1673 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1674 border adjustment.
1675 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1676 their usage. Add fringe_extended_p and its use as in other terms.
1677 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1678 scroll bar was removed.
1679 (updateFrameSize): New function.
1680 (windowDidResize): Move code to updateFrameSize and call it.
1681
1682 * nsterm.h (EmacsView): Add updateFrameSize.
1683
1a5432bc
CY
16842012-09-07 Chong Yidong <cyd@gnu.org>
1685
b4f5313e
CY
1686 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1687
1a5432bc
CY
1688 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1689
1a4f1e9b
PE
16902012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1693 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1694 Problem introduced when merging patches. Noted by Eli Zaretskii in
1695 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1696 * floatfns.c: Comment fix.
1697 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1698 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1699 and anyway the declaration is harmless even if SIGDANGER is not defined.
1700 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1701 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1702 source files not surprisingly expected syssignal.h to define, or
1703 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1704 Include <sys/ioctl.h>, for FIONREAD.
1705 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1706 This eliminates a problem whereby other files mysteriously had
1707 to include "syssignal.h" before including "systty.h" if they
1708 wanted to use "#ifdef SIGIO".
1709
bc8000ff
EZ
17102012-09-07 Eli Zaretskii <eliz@gnu.org>
1711
3e6d6928
EZ
1712 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1713
1714 * w32.c (sigemptyset): Empty the set.
1715 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1716
bc8000ff
EZ
1717 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1718
b4fa72f2
DA
17192012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1720
1721 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1722 (mark_object): Likewise for frame objects.
1723
30730c93
PE
17242012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 * syssignal.h (handle_on_main_thread): Always declare,
1727 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1728 This ports to platforms without HAVE_PTHREAD.
1729
2fe28299
PE
17302012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Signal-handler cleanup (Bug#12327).
1733 Emacs's signal handlers were written in the old 4.2BSD style with
1734 sigblock and sigmask and so forth, and this led to some
1735 inefficiencies and confusion. Rewrite these to use
1736 pthread_sigmask etc. without copying signal sets around. Also,
1737 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1738 'signal', and instead use functions that do not attempt to take
1739 over the system name space. This patch causes Emacs's text
1740 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1741 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1742 Do not include <signal.h> or "syssignal.h", as these
1743 modules do not use signals.
1744 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1745 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1746 Do not include <signal.h>, as "syssignal.h" does that for us now.
1747 * atimer.c (sigmask_atimers): New function.
1748 (block_atimers, unblock_atimers): New functions,
1749 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1750 All uses replaced.
1751 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1752 no longer needed here.
1753 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1754 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1755 * sysdep.c (struct save_signal): New member 'action', replacing
1756 old member 'handler'.
1757 (save_signal_handlers, restore_signal_handlers):
1758 Use sigaction instead of 'signal' to save and restore.
1759 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1760 New function. All users of 'signal' modified to use set_sighandler
1761 if they're writeonly, and to use sys_signal if they're read+write.
1762 (emacs_sigaction_init, forwarded_signal): New functions.
1763 (sys_signal): Remove. All uses replaced by calls to sigaction
1764 and emacs_sigaction_init, or by direct calls to 'signal'.
1765 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1766 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1767 all uses replaced by pthread_sigmask etc. calls.
1768 * syssignal.h: Include <signal.h>.
1769 (emacs_sigaction_init, forwarded_signal): New decls.
1770 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1771 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1772 (sigmask, sys_sigmask): Remove; no longer needed.
1773 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1774 (sigblock, sigunblock, sigfree):
1775 (sigsetmask) [!defined sigsetmask]:
1776 Remove. All uses replaced by pthread_sigmask.
1777 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1778 no longer need to be replaced, and its typical old uses
1779 are now done via emacs_sigaction_init and sigaction.
1780 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1781 (sys_sigdel): Remove; unused.
1782 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1783
0216c128
EZ
17842012-09-06 Eli Zaretskii <eliz@gnu.org>
1785
1786 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1787 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1788
c752cfa9
DA
17892012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1790
1791 Explicitly mark buffer_defaults and buffer_local_symbols.
1792 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1793 mark_local_symbols here.
1794 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1795 since special buffers aren't marked here any more.
1796 (allocate_buffer): Chain new buffer with all_buffers here...
1797 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1798 not here.
1799 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1800 (syms_of_buffer): Remove staticpro of the above.
1801 (init_buffer_once): Set names for buffer_defaults and
1802 buffer_local_symbols.
1803
a864ef14
PE
18042012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 Use bool for booleans in font-related modules.
1807 * font.c (font_intern_prop, font_style_to_value)
1808 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1809 (generate_otf_features, font_check_otf_features, font_check_otf)
1810 (font_match_p, font_list_entities, font_at):
1811 * fontset.c (fontset_id_valid_p, reorder_font_vector
1812 (fontset_find_font, Fset_fontset_font)
1813 (face_suitable_for_char_p) [0]:
1814 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1815 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1816 (m17n_flt_initialized, ftfont_shape_by_flt):
1817 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1818 * nsfont.m (nsfont_draw):
1819 * w32font.c (w32font_draw):
1820 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1821 Use bool for booleans.
1822 * font.h: Adjust to above API changes.
1823 (struct font, struct font_driver, struct font_driver_list):
1824 Use bool for booleans.
1825 (struct font): Remove useless member encoding_type.
1826 All users removed.
1827 * fontset.c, xftfont.c: Omit unnecessary static decls.
1828
0699fc18
DA
18292012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1830
1831 * alloc.c (mark_object): Revert window marking code
1832 since it's unsafe for the Fset_window_configuration.
1833
20ef56db
PE
18342012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1835
2fe28299 1836 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1837 Be more systematic about preserving errno whenever a signal
1838 handler returns, even if it's not in the main thread. Do this by
1839 renaming signal handlers to distinguish between signal delivery
1840 and signal handling. All uses changed.
1841 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1842 * data.c (deliver_arith_signal): Rename from arith_error.
1843 * dispnew.c (deliver_window_change_signal): Rename from
1844 window_change_signal.
1845 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1846 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1847 * keyboard.c (deliver_input_available_signal): Rename from
1848 input_available_signal.
1849 (deliver_user_signal): Rename from handle_user_signal.
1850 (deliver_interrupt_signal): Rename from interrupt_signal.
1851 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1852 (deliver_child_signal): Rename from sigchld_handler.
1853 * atimer.c (handle_alarm_signal):
1854 * data.c (handle_arith_signal):
1855 * dispnew.c (handle_window_change_signal):
1856 * emacs.c (handle_fatal_signal, handle_danger_signal):
1857 * keyboard.c (handle_input_available_signal):
1858 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1859 * process.c (handle_pipe_signal, handle_child_signal):
1860 New functions, with the actual signal-handling code taken from the
1861 original respective signal handlers, sans the sporadic attempts to
1862 preserve errno, since that's now done by handle_on_main_thread.
1863 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1864 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1865 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1866 Move to sysdep.c.
1867 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1868 Move initialization of main_thread to sysdep.c's init_signals.
1869 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1870 our usage, and simplifies the mainline code.
1871 (record_child_status_change): New static function, as a helper
1872 for handle_child_signal, and with most of the old child handler's
1873 contents.
1874 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1875 (handle_child_signal): Use the above.
1876 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1877 Moved here from emacs.c.
1878 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1879 code moved here from emacs.c's main function.
1880 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1881 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1882 This lets callers save and restore errno properly.
20ef56db 1883
e3ccf108
DA
18842012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 Remove redundant or unused things here and there.
1887 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1888 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1889 * editfns.c (Fcompare_buffer_substrings): Likewise.
1890 * frame.h (struct terminal, struct font_driver_list):
1891 Remove redundant declarations.
1892 * window.h (Qleft, Qright): Likewise.
1893
697e1e39
DA
18942012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 Do not mark objects from deleted buffers, windows and frames.
1897 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1898 (mark_object): Likewise for windows and frames.
1899
c1ca42ca
DA
19002012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1903 buffer_defaults and buffer_local_symbols as valid objects.
1904 Return special value to denote them.
1905
014d93be
PE
19062012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1907
f75d7a91
PE
1908 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1909 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1910 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1911 (file_name_absolute_p, Fsubstitute_in_file_name):
1912 (check_executable, check_writable, Ffile_accessible_directory_p)
1913 (Fset_file_selinux_context, Fdefault_file_modes)
1914 (Finsert_file_contents, choose_write_coding_system)
1915 (Fwrite_region, build_annotations, a_write, e_write)
1916 (Fdo_auto_save):
1917 * filelock.c (boot_time_initialized, get_boot_time)
1918 (get_boot_time_1, lock_file_1, within_one_second):
1919 * floatfns.c (in_float):
1920 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1921 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1922 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1923 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1924 * window.c (compare_window_configurations):
1925 Use bool for booleans.
1926 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1927 (Fdefault_file_modes): Now mode_t, not int, for modes.
1928 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1929 (internal_delete_file): Now returns void, not a (boolean) int,
1930 since nobody was looking at the return value.
1931 * lisp.h, window.h: Adjust to above API changes.
1932
014d93be
PE
1933 * xdisp.c (set_message): Simplify and reindent last change.
1934
776f29e1
JB
19352012-09-05 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1938
7f7e0167
LI
19392012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1940
1941 * eval.c (call_debugger): Make the function non-static so that we
1942 can call it from set_message.
1943
1944 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1945 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1946
cf29dd84
PE
19472012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Give more-useful info on a fatal error (Bug#12328).
1950 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1951 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1952 of doing the work ourselves.
1953 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1954 do most of the work.
1955 (fatal_error_backtrace): New function, taken from the guts
1956 of the old fatal_error_signal, but with a new option to output
1957 a backtrace.
1958 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1959 info about the signal than just its number.
1960 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1961 * sysdep.c: Include <execinfo.h>
1962 (emacs_backtrace): New function, taken partly from the previous
1963 code of the 'die' function.
1964 (emacs_abort): Call fatal_error_backtrace rather than abort.
1965
972debf2
SM
19662012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1967
1968 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1969 eager (load-time) macro-expansion.
1970 * lisp.mk (lisp): Add macroexp.
1971
1088b922
PE
19722012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Simplify redefinition of 'abort' (Bug#12316).
1975 Do not try to redefine the 'abort' function. Instead, redo
1976 the code so that it calls 'emacs_abort' rather than 'abort'.
1977 This removes the need for the NO_ABORT configure-time macro
1978 and makes it easier to change the abort code to do a backtrace.
1979 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1980 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1981 Remove; sysdep.c's emacs_abort now takes its place.
1982 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1983 'abort' changed to use 'emacs_abort'.
1984 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1985 (abort) [!defined abort]: Rename to ...
1986 (emacs_abort): ... new name.
1987 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1988 the place of the old 'abort' in emacs.c.
1989 * w32.c, w32fns.c (abort): Do not #undef.
1990 * w32.c (emacs_abort): Rename from w32_abort.
1991
30934d33
EZ
19922012-09-04 Eli Zaretskii <eliz@gnu.org>
1993
1994 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1995 offsets[j].dv, since the y axis of the screen coordinates points
1996 down, while the y axis of the font definition coordinates points
1997 up. This fixes display of Arabic diacritics such as KASRA and
1998 KASRATAN. (Bug#11860)
1999
af26b72c
PE
20002012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 Be more systematic about _setjmp vs setjmp.
2003 * alloc.c (test_setjmp, mark_stack):
2004 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
2005 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
2006 (png_load, my_error_exit, jpeg_load):
2007 * process.c (send_process_trap, send_process):
2008 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
2009 The underscored versions are up to 30x faster on some hosts.
2010 Formerly, the code used setjmp+longjmp sometimes and
2011 _setjmp+_longjmp at other times, with no particular reason to
2012 prefer setjmp+longjmp.
2013
26d4541d
PE
20142012-09-03 Paul Eggert <eggert@cs.ucla.edu>
2015
d42f4f0f 2016 Fix minor problem found by static checking.
26d4541d 2017 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 2018
c5e28e39
MR
20192012-09-03 Martin Rudalics <rudalics@gmx.at>
2020
2021 * buffer.c (Fdelete_all_overlays): New function.
2022
3eab3ca9
CY
20232012-09-03 Chong Yidong <cyd@gnu.org>
2024
2025 * gtkutil.c: Add extern decl for Qxft.
2026
c04889f8
PE
20272012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2028
1882aa38
PE
2029 * emacs.c, eval.c: Use bool for boolean.
2030 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
2031 (malloc_using_checking) [DOUG_LEA_MALLOC]:
2032 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
2033 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
2034 (main, decode_env_path, Fdaemon_initialized):
2035 * eval.c (call_debugger, Finteractive_p, interactive_p):
2036 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
2037 (maybe_call_debugger, Fbacktrace):
2038 * process.c (read_process_output, exec_sentinel):
2039 Use bool for booleans.
2040 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
2041 All callers changed.
2042 * eval.c (interactive_p): Omit always-true boolean argument
2043 EXCLUDE_SUBRS_P. All callers changed.
2044 * dispextern.h, lisp.h: Reflect above API changes.
2045 * firstfile.c (dummy): Use the address of 'main', whose signature
2046 won't change, instead of the address of 'initialize', whose
2047 signature just changed from int to bool.
2048 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
2049 * msdos.c (fatal_error_in_progress): ... from here.
2050 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
2051 of incrementing it.
2052 (redisplay_internal, unwind_redisplay): Simply clear
2053 REDISPLAYING_P when unwinding, instead of saving its previous,
2054 always-false value and then restoring it.
2055
a411ac43
PE
2056 Clean up some extern decls.
2057 Mostly, this hoists extern decls out of .c files and into .h files.
2058 That way, we're more likely to catch errors if the interfaces change.
2059 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
2060 declare xg_mark_data.
2061 * dispextern.h (x_frame_parm_handlers):
2062 * font.h (Qxft):
2063 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
2064 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
2065 (Qultra_bold, Qoblique, Qitalic):
2066 Move extern decl here from .c file.
2067 * alloc.c (xg_mark_data) [USE_GTK]:
2068 * doc.c (Qclosure):
2069 * eval.c (Qlexical_binding):
2070 * fns.c (time) [!HAVE_UNISTD_H]:
2071 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
2072 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
2073 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
2074 * lread.c (Qinternal_interpreter_environment):
2075 * minibuf.c (Qbuffer):
2076 * process.c (QCfamily, QCfilter):
2077 * widget.c (free_frame_faces):
2078 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
2079 * xfont.c (x_clear_errors):
2080 * xterm.c (x_frame_parm_handlers):
2081 Remove now-redundant extern decls.
2082 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
2083 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
2084 Now static.
2085 * xfaces.c: Remove unnecessary static decls.
2086 * xterm.c (updating_frame): Remove decl of nonexistent object.
2087
c04889f8
PE
2088 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
2089 when building globals.h, as the objects that are not built on
2090 this host are not needed to compile C files on this host.
2091
8b339673
JD
20922012-09-02 Jan Djärv <jan.h.d@swipnet.se>
2093
2094 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
2095
2096 * frame.h: Add missing prototype for x_wm_set_size_hint.
2097
a08d4ba7
PE
20982012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
2101 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
2102 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
2103 (Fsubstitute_command_keys):
2104 * editfns.c (region_limit, find_field, Fconstrain_to_field)
2105 (save_excursion_save, save_excursion_restore)
2106 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
2107 (format_time_string, general_insert_function)
2108 (make_buffer_string, make_buffer_string_both)
2109 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
2110 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
2111 (copy_text, insert_1, insert_1_both, insert_from_string)
2112 (insert_from_string_before_markers, insert_from_string_1)
2113 (insert_from_buffer, insert_from_buffer_1, replace_range)
2114 (replace_range_2, del_range_1, del_range_byte, del_range_both)
2115 (del_range_2, modify_region):
2116 * intervals.c (intervals_equal, balance_possible_root_interval)
2117 (adjust_intervals_for_insertion, merge_properties_sticky)
2118 (graft_intervals_into_buffer, lookup_char_property)
2119 (adjust_for_invis_intang, set_point_both)
2120 (get_property_and_range, compare_string_intervals)
2121 (set_intervals_multibyte_1, set_intervals_multibyte):
2122 * keyboard.c (decode_timer):
2123 Use bool for boolean.
2124 * intervals.h, lisp.h, systime.h: Reflect above API changes.
2125 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
2126
48c948de
CY
21272012-09-02 Chong Yidong <cyd@gnu.org>
2128
2129 * keymap.c (push_key_description): Print M-TAB as C-M-i
2130 (Bug#11758).
2131
6c49a40b
JB
21322012-09-02 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
2135 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
2136 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
2137 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
2138 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
2139 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
2140 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2141
4dfbd238
EZ
21422012-09-01 Eli Zaretskii <eliz@gnu.org>
2143
7e510e28
EZ
2144 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
2145 more than one grapheme cluster passed to the shaper: compute the
2146 offset adjustment values separately for each cluster. (Bug#11860)
2147
4dfbd238
EZ
2148 * image.c: Restore mistakenly removed inclusion of w32.h. Without
2149 it, GCC doesn't see prototypes of w32_delayed_load, and complains
2150 about implicit conversions from integer to pointer.
2151
86571ae0
DC
21522012-09-01 Daniel Colascione <dancol@dancol.org>
2153
2154 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
2155 system used too early.
2156
0e23ef9d
PE
21572012-09-01 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 Better seed support for (random).
2160 * emacs.c (main): Call init_random.
2161 * fns.c (Frandom): Set the seed from a string argument, if given.
2162 Remove long-obsolete Gentzel cruft.
2163 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
2164 (init_random): New function.
2165
17a2cbbd
DC
21662012-09-01 Daniel Colascione <dancol@dancol.org>
2167
2168 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
2169 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
2170 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
2171 x_wm_set_size_hint, x_query_colors, x_real_positions,
2172 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
2173 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
2174 all of which have been moved to common code.
2175
2176 * xfaces.c: Include TERM_HEADER instead of listing all possible
2177 window-system headers.
2178
2179 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
2180 to match header.
2181
2182 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
2183 directly accessing frame internals.
2184
f18cbb28 2185 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
2186 globals_of_w32font.
2187
2188 * process.c: Include TERM_HEADER instead of listing all possible
2189 window-system headers.
2190
3a880af4
SM
2191 * nsterm.h: Remove declarations now in frame.h.
2192 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
2193
2194 * menu.c: Include TERM_HEADER instead of listing all possible
2195 window-system headers.
2196
2197 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
2198 window system.
2199
2200 * keyboard.c: Include TERM_HEADER instead of listing all possible
2201 window-system headers.
2202
2203 * image.c: Include TERM_HEADER instead of listing all possible
2204 window-system headers. Declare Vlibrary_cache when compiling for
2205 Windows.
2206
2207 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
2208 window system declarations.
2209
2210 * frame.h: Move common functions here: set_frame_menubar,
2211 x_set_window_size, x_sync, x_get_focus_frame,
2212 x_set_mouse_position, x_set_mouse_pixel_position,
2213 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
2214 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2215 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2216 x_activate_menubar, x_real_positions, x_bitmap_icon,
2217 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2218 and x_query_colors.
2219
2220 * frame.c: Include TERM_HEADER instead of listing all possible
2221 window-system headers.
2222
2223 * font.c: Include TERM_HEADER instead of listing all possible
2224 window-system headers.
2225
2226 * emacs.c: Include TERM_HEADER.
2227
f18cbb28
EZ
2228 * dispnew.c: Include TERM_HEADER instead of listing all possible
2229 window-system headers.
17a2cbbd 2230
f18cbb28 2231 * ccl.h: Include character.h.
17a2cbbd
DC
2232
2233 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2234 the current window system; include in list of objects to link into
2235 Emacs.
2236
c650a5de
DA
22372012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2238
2239 Remove mark_ttys function and fix tty_display_info initialization.
2240 * lisp.h (mark_ttys): Remove prototype.
2241 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2242 to mark_ttys because all possible values of 'top_frame' slot are
2243 the frames which are reachable from Vframe_list.
2244 * term.c (mark_ttys): Remove.
2245 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2246
4e0f6479
DA
22472012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2248
2249 Change struct frame bitfields from unsigned char to unsigned.
2250 * frame.h (struct frame): Change type of 'display_preempted',
2251 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2252 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2253 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2254 bitfields from unsigned char to unsigned.
2255
8b96a52c
DA
22562012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2257
2258 Remove unused member of struct x_output and struct w32_output.
2259 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2260 * w32term.h (struct w32_output): Likewise.
2261
b4444c8a
JD
22622012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2263
2264 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2265 does not become zero (Bug#12234).
2266
b98521db
PE
22672012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2270 for GCC 4.7.1 x86-64.
2271
31d02438
GM
22722012-08-30 Glenn Morris <rgm@gnu.org>
2273
2274 * lread.c (init_lread): For out-of-tree builds, only add the
2275 source directory's site-lisp dir to the load-path if it exists,
2276 consistent with in-tree builds. (Bug#12302)
2277
7f8941d8
JD
22782012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2279
2280 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2281 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2282 (windowShouldClose:): Set window_closed.
2283 (dealloc): New member, free button_values.
fc0c31f8
JB
2284 (process_dialog:): Make member function. Remove window argument,
2285 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2286 in button_values.
2287 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2288 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2289 (addString:row:): Remove return self, declare return value as void.
2290 (addSplit): Remove return self, declare return value as void.
2291 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2292 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2293 (initFromContents:isQuestion:): Adjust call to process_dialog.
2294 Code formatting change.
2295 (timeout_handler:): Set timer_fired to YES.
2296 (runDialogAt:): Set timer_fired to NO.
2297 Handle click on close button as quit.
2298
2299 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2300 Add window_closed and button_values. Add void as return value for
2301 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2302 Add process_dialog as new member.
2303
eada0861 23042012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2305
eada0861
GM
2306 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2307 is not one of the heaps we manage. (Bug#12242)
2308
23092012-08-28 Glenn Morris <rgm@gnu.org>
2310
2311 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2312
457294dd
MR
23132012-08-28 Martin Rudalics <rudalics@gmx.at>
2314
2315 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2316 auto-buffer-name window parameter. Install revision of reverted
2317 fix.
457294dd 2318
4f2daf31
DA
23192012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2320
2321 Do not allow to set major mode for a dead buffer.
2322 * buffer.c (Fset_buffer_major_mode): Signal an error
2323 if the buffer is dead.
2324 (Fother_buffer, other_buffer_safely): Remove redundant
2325 nested declaration.
2326
66322887
DA
23272012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 Always use set_buffer_if_live to restore original buffer at unwind.
2330 * buffer.h (record_unwind_current_buffer): New function.
2331 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2332 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2333 * undo.c, window.c: Adjust users.
2334 * buffer.c (set_buffer_if_live): Fix comment.
2335
a3d794a1
DA
23362012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2337
2338 Fix usage of set_buffer_internal.
2339 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2340 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2341 * coding.c (decode_coding): Omit redundant test.
2342 * fileio.c (decide_coding_unwind): Likewise.
2343 * fns.c (secure_hash): Likewise.
2344 * insdel.c (modify_region): Likewise.
2345 * keyboard.c (command_loop_1): Likewise.
2346 * print.c (PRINTFINISH): Likewise.
2347 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2348
59ea14cd
PE
23492012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * dispnew.c: Use bool for boolean.
2352 (frame_garbaged, display_completed, delayed_size_change)
2353 (fonts_changed_p, add_window_display_history)
2354 (add_frame_display_history, verify_row_hash)
2355 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2356 (row_equal_p, realloc_glyph_pool)
2357 (allocate_matrices_for_frame_redisplay)
2358 (showing_window_margins_p)
2359 (adjust_frame_glyphs_for_frame_redisplay)
2360 (build_frame_matrix_from_leaf_window, make_current)
2361 (mirrored_line_dance, mirror_line_dance, update_frame)
2362 (update_window_tree, update_single_window)
2363 (check_current_matrix_flags, update_window, update_text_area)
2364 (update_window_line, set_window_update_flags, scrolling_window)
2365 (update_frame_1, scrolling, buffer_posn_from_coords)
2366 (do_pending_window_change, change_frame_size)
2367 (change_frame_size_1, sit_for):
2368 Use bool for boolean.
2369 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2370 and remove last int (actually boolean) argument, which was always 0.
2371 All callers changed.
2372 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2373 * dispextern.h (struct composition_it): Use bool for boolean.
2374 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2375 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2376 * dired.c (file_name_completion):
2377 Use bool for boolean. (This was missed in an earlier change.)
2378
95072a94
MR
23792012-08-27 Martin Rudalics <rudalics@gmx.at>
2380
2381 * window.c (Fset_window_configuration): Revert first part of
2382 last change.
2383
0f19feff
JD
23842012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2385
2386 * nsterm.h (NSPanel): New class variable dialog_return.
2387
3a880af4
SM
2388 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2389 Initialize dialog_return.
0f19feff
JD
2390 (windowShouldClose:): Use stop instead of stopModalWithCode.
2391 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2392 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2393 event.
2394 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2395 modal loop returns.
2396
f10fe38f
PE
23972012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2398
de1339b0
PE
2399 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2400 * composite.c (find_composition, composition_gstring_p)
2401 (composition_reseat_it, find_automatic_composition):
2402 * data.c (let_shadows_buffer_binding_p)
2403 (let_shadows_global_binding_p, set_internal, make_blv)
2404 (Fmake_variable_buffer_local, Fmake_local_variable)
2405 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2406 (cons_to_signed, arith_driver):
2407 * dbusbind.c (xd_in_read_queued_messages):
2408 * dired.c (directory_files_internal, file_name_completion):
2409 Use bool for booleans.
2410 * dired.c (file_name_completion):
2411 * process.h (fd_callback):
2412 Omit int (actually boolean) argument. It wasn't being used.
2413 All uses changed.
2414 * composite.h, lisp.h: Reflect above API changes.
2415
f10fe38f
PE
2416 * cmds.c, coding.c: Use bool for booleans.
2417 * cmds.c (move_point, Fself_insert_command):
2418 * coding.h (struct composition status, struct coding_system):
2419 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2420 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2421 (emacs_mule_char, decode_coding_emacs_mule)
2422 (encode_coding_emacs_mule, detect_coding_iso_2022)
2423 (decode_coding_iso_2022, encode_invocation_designation)
2424 (encode_designation_at_bol, encode_coding_iso_2022)
2425 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2426 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2427 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2428 (encode_coding_raw_text, detect_coding_charset)
2429 (decode_coding_charset, encode_coding_charset, detect_eol)
2430 (detect_coding, get_translation_table, produce_chars)
2431 (consume_chars, reused_workbuf_in_use)
2432 (make_conversion_work_buffer, code_conversion_save)
2433 (decode_coding_object, encode_coding_object)
2434 (detect_coding_system, char_encodable_p)
2435 (Funencodable_char_position, code_convert_region)
2436 (code_convert_string, code_convert_string_norecord)
2437 (Fset_coding_system_priority):
2438 * fileio.c (Finsert_file_contents):
2439 Use bool for booleans.
2440 * coding.h, lisp.h: Reflect above API changes.
2441 * coding.c: Remove unnecessary static function decls.
2442 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2443 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2444 not a boolean 'int', since callers never look at the return value.
2445 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2446 * coding.h (decoding_buffer_size, encoding_buffer_size)
2447 (emacs_mule_string_char): Remove unused extern decls.
2448 (struct iso_2022_spec, struct coding_system):
2449 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2450 (struct emacs_mule_spec): Remove unused field 'full_support'.
2451 All initializations removed.
2452 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2453
5474c384
DA
24542012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2455
f10fe38f 2456 Fix spare memory change (Bug#12286).
5474c384
DA
2457 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2458 (valid_lisp_object_p): Likewise.
2459
c4b6914d
MR
24602012-08-27 Martin Rudalics <rudalics@gmx.at>
2461
2462 * window.c (Fset_window_configuration): Record any window's old
2463 buffer if it's replaced (see Bug#8789). If the new current
2464 buffer doesn't appear in the selected window, go to its old
2465 point (Bug#12208).
2466
35aaa1ea
DA
24672012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 Special MEM_TYPE_SPARE to denote reserved memory.
2470 * alloc.c (enum mem_type): New memory type.
2471 (refill_memory_reserve): Use new type for spare memory.
2472 This prevents live_cons_p and live_string_p from incorrect
2473 detection of uninitialized objects from spare memory as live.
2474
6af64513
PE
24752012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2476
8b2e00a3
PE
2477 Spelling fixes.
2478 * Makefile.in (.PHONY): versioclean -> versionclean.
2479
b52d6985
PE
2480 Remove unused external symbols.
2481 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2482 * window.c (Qwindow_valid_p, decode_valid_window):
2483 Now static, not extern.
2484 * data.c (Qinterval): Remove; unused.
2485 (syms_of_data): Do not define 'interval'.
2486 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2487 * window.h (decode_valid_window):
2488 Remove decls.
2489
d5172d4f
PE
2490 * character.c, charset.c, chartab.c: Use bool for booleans.
2491 * character.c (lisp_string_width, string_count_byte8)
2492 (string_escape_byte8):
2493 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2494 (load_charset_map_from_file, map_charset_chars)
2495 (Fdefine_charset_internal, define_charset_internal)
2496 (Fdeclare_equiv_charset, find_charsets_in_text)
2497 (Ffind_charset_region, char_charset, Fiso_charset):
2498 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2499 (sub_char_table_set, sub_char_table_set_range)
2500 (char_table_set_range, optimize_sub_char_table)
2501 (map_sub_char_table):
2502 Use bool for boolean.
2503 * character.c (str_to_unibyte): Omit last boolean argument; it was
2504 always 0. All callers changed.
2505 * character.h, charset.h: Adjust to match previous changes.
2506 * character.h (char_printable_p): Remove decl of nonexistent function.
2507 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2508 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2509 are all boolean, so make them single-bit bitfields.
2510
6af64513
PE
2511 * lisp.h (ASET): Remove attempt to detect side effects.
2512 It was meant to be temporary and it often doesn't work,
2513 because when IDX has side effects the behavior of IDX==IDX
2514 is undefined. See Stefan Monnier in
2515 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2516
e1f29348
BR
25172012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2518
2519 * lisp.h (functionp): New function (extracted from Ffunctionp).
2520 (FUNCTIONP): Use it.
2521 * eval.c (Ffunctionp): Use it.
2522
17c05d74
PE
25232012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2524
0f46bc75
PE
2525 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2526 as that's faster and simpler than static storage. Don't bother
2527 with the g_main_context_query overhead if g_main_context_pending
2528 says no events are pending.
2529 (gfds, gfds_size): Remove these static vars.
2530 (xgselect_initialize): Remove; no longer needed.
2531 All uses and decls removed.
2532
ee4c0f69
PE
2533 * emacs.c (fatal_error_signal_hook): Remove.
2534 All uses removed. This leftover from old code was always 0.
2535
17c05d74
PE
2536 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2537 * casefiddle.c (casify_object, casify_region):
2538 * casetab.c (set_case_table):
2539 * category.c, category.h (word_boundary_p):
2540 * category.h (CHAR_HAS_CATEGORY):
2541 Use bool for booleans, instead of int.
2542
391ceac5
EZ
25432012-08-25 Eli Zaretskii <eliz@gnu.org>
2544
2545 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2546
2f221583
PE
25472012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2548
f4a681b0
PE
2549 On assertion failure, print backtrace if available.
2550 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2551 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2552 * Makefile.in (LIB_EXECINFO): New macro.
2553 (LIBES): Use it.
2554
2f221583
PE
2555 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2556 * bytecode.c (exec_byte_code):
2557 * callint.c (check_mark, Fcall_interactively):
2558 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2559 (getenv_internal, sync_process_alive, call_process_exited):
2560 * lisp.h (USE_SAFE_ALLOCA):
2561 Use bool for booleans, instead of int.
2562 * lisp.h, process.h: Adjust prototypes to match above changes.
2563 * callint.c (Fcall_interactively): Don't assume the mark's
2564 offset fits in 'int'.
2565
37ef52bb
PE
25662012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * buffer.c, buffer.h: Use bool for boolean.
2569 * buffer.c (reset_buffer_local_variables)
2570 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2571 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2572 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2573 (overlay_touches_p, overlay_strings, Foverlay_put)
2574 (report_overlay_modification, call_overlay_mod_hooks):
2575 (mmap_enlarge, mmap_set_vars):
2576 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2577 Use bool for booleans, instead of int.
2578 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2579 since the 1-or-0 return value is always ignored anyway.
2580 (mmap_initialized_p):
2581 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2582 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2583
2cc21167
PE
25842012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 * bidi.c: Use bool for boolean.
2587 This is a bit more readable, and makes the text segment of bidi.o
2588 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2589 Presumably it's faster too.
2590 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2591 Now bool.
2592 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2593 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2594 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2595 (bidi_explicit_dir_char, bidi_level_of_next_char)
2596 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2597 Use bool for booleans, instead of int.
2598 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2599 (bidi_unshelve_cache): Adjust decls to match code.
2600
7db4ddf4
MR
26012012-08-23 Martin Rudalics <rudalics@gmx.at>
2602
2603 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2604 argument.
2605
b1bb8011
PE
26062012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2609 * atimer.h: Include <stdbool.h>.
2610
ff687885
DN
26112012-08-22 Dan Nicolaescu <dann@gnu.org>
2612
2613 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2614 compile time tests instead of run time tests on systems that do
2615 not use them.
2616 (FRAME_MAC_P): Remove leftover from deleted code.
2617 * frame.c (syms_of_frame): Remove leftover from deleted code.
2618
4ce7a138
JD
26192012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2620
2621 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2622
d733ec6d
PE
26232012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2626 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2627 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2628 (fontset_add): Return void, for FONTSET_ADD.
2629
d0d2d26f
PE
26302012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2631
fce31d69
PE
2632 * alloc.c: Use bool for booleans.
2633 (gc_in_progress, abort_on_gc)
2634 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2635 (dont_register_blocks) [GC_MALLOC_CHECK]:
2636 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2637 (check_string_bytes, make_specified_string, memory_full)
2638 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2639 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2640 (mark_stack, valid_pointer_p, make_pure_string)
2641 (Fgarbage_collect, survives_gc_p, gc_sweep):
2642 Use bool for booleans, instead of int.
2643 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2644 Remove unused local.
2645 * alloc.c (PURE_POINTER_P):
2646 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2647 * editfns.c (Fformat):
2648 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2649 (Fdo_auto_save):
2650 * fns.c (sweep_weak_table):
2651 * lisp.h (suppress_checking, push_message, survives_gc_p)
2652 (make_pure_string, gc_in_progress, abort_on_gc):
2653 * lread.c (readchar, read1):
2654 * print.c (Fprin1_to_string):
2655 * xdisp.c (push_message):
2656 Use bool for booleans affected directly or indirectly by
2657 alloc.c's changes.
2658
d0d2d26f
PE
2659 Make recently-introduced setters macros.
2660 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2661 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2662 (set_fontset_default, set_fontset_fallback): Rename from their
2663 upper-case counterparts, and make them functions rather than macros.
2664 This is more consistent with the other recently-introduced setters.
2665 These don't need to be inline, since they're local.
2666
d18e2bb6
JD
26672012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2668
2669 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2670 the loop (Bug#12247).
2671
1b9d9d16
PE
26722012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * lisp.h (vcopy): Use memcpy rather than our own loop.
2675 This fixes a performance regression introduced by the recent
2676 addition of vcopy. This means 'vcopy' will need to be modified
2677 for a copying collector, but that's OK. Also, tighten the
2678 checking in the assertion.
2679
b2f09701
EZ
26802012-08-21 Eli Zaretskii <eliz@gnu.org>
2681
2682 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2683 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2684 non-base glyph for the width of the base character, according to
e1f29348
BR
2685 what x_draw_composite_glyph_string_foreground expects.
2686 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2687 expectations, to produce correct width of the composed character.
2688 Reverse the sign of the DU offset produced by ScriptPlace.
2689
9b994fed
PE
26902012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2691
2692 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2693
086ca913
DA
26942012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2695
2696 Avoid direct writes to contents member of struct Lisp_Vector.
2697 * lisp.h (vcopy): New function to copy data into vector.
2698 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2699 * fns.c (Ffillarray): Use ASET.
2700 * keyboard.c (timer_check_2): Use AREF and ASET.
2701 (append_tool_bar_item, Frecent_keys): Use vcopy.
2702 * lread.c (read_vector): Use ASET.
2703 * msdos.c (Frecent_doskeys): Use vcopy.
2704 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2705 (Finternal_merge_in_global_face): Use ASET and vcopy.
2706 * xfont.c (xfont_list_pattern): Likewise.
2707
5481664a
MR
27082012-08-21 Martin Rudalics <rudalics@gmx.at>
2709
2710 * window.c (Fwindow_point): For the selected window always return
2711 the position of its buffer's point.
2712 (Fset_window_point): For the selected window always go in its
2713 buffer to the specified position.
2714
6d470bdd
DA
27152012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2716
2717 Setter macros for fontsets.
2718 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2719 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2720 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2721 Adjust users.
2722
24564fe1
GM
27232012-08-20 Glenn Morris <rgm@gnu.org>
2724
2725 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2726 Don't assume that `ln -f' works.
2727
0a05a035
EZ
27282012-08-20 Eli Zaretskii <eliz@gnu.org>
2729
2730 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2731 and later about non-assignments with no effect. See discussion at
2732 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2733 details.
2734
e46f2325
DA
27352012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2736
2737 Inline setter functions for Lisp_Objects slots of struct specbinding.
2738 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2739 Adjust users.
2740
734fbd86
MR
27412012-08-20 Martin Rudalics <rudalics@gmx.at>
2742
2743 * window.c (select_window): Always make selected window's buffer
2744 current.
2745
f1a95992
DA
27462012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2747
2748 Use AREF and ASET for docstrings of category tables.
2749 * category.h (CATEGORY_DOCSTRING): Use AREF.
2750 (SET_CATEGORY_DOCSTRING): Use ASET.
2751 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2752
e83064be
DA
27532012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2754
2755 Inline setter functions for hash table members.
2756 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2757 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2758 (set_hash_key_and_value, set_hash_index, set_hash_next)
2759 (set_hash_hash): New functions.
2760 * charset.c, fns.c: Adjust users.
2761
4ce60d2e
DA
27622012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2763
2764 Inline getter and setter functions for per-buffer values.
2765 * buffer.h (per_buffer_default, set_per_buffer_default)
2766 (per_buffer_value, set_per_buffer_value): New functions.
2767 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2768 * buffer.c, data.c: Adjust users.
2769
c06c9690
JB
27702012-08-20 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2773
32bd4250
PE
27742012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2775
bad03192 2776 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2777 as gnulib does this if the system doesn't.
2778 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2779 Remove declaration. MS-Windows declares it on stdlib.h which is
2780 included by conf_post.h.
b69a6d22
PE
2781 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2782 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2783 * vm-limit.c: Include <unistd.h>, for 'environ'.
2784
22d7feb2
PE
2785 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2786 (start_of_data): Remove decl; mem-limits.h provides it.
2787
32bd4250
PE
2788 * xdisp.c (handle_invisible_prop): Make it a bit faster
2789 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2790
450809af
CY
27912012-08-19 Chong Yidong <cyd@gnu.org>
2792
2793 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2794 ends (Bug#3874).
2795
9e677988
AS
27962012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2797
6b1319ce
AS
2798 * .gdbinit: Use call instead of set when calling a function in the
2799 inferior.
2800
9e677988
AS
2801 * data.c (set_internal): Don't use set_blv_found.
2802 (Fkill_local_variable): Likewise.
2803
d7191076
AA
28042012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2805
2806 * nsfont.m (ns_ascii_average_width): Ensure the string
2807 ascii_printable is initialized with a null-terminated character
2808 array. Otherwise, it can contain undesired extra characters.
2809
e757f1c6
PE
28102012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 port new setting code to Sun C 5.8 2005/10/13
2813 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2814 Return void, not Lisp_Object. Otherwise, the compiler
2815 complains about (A?B:C) where B is void and C is Lisp_Object
2816 when compiling CHAR_TABLE_SET, due to the recent change to
2817 the API of sub_char_table_set_contents.
2818
a999ce26
CY
28192012-08-18 Chong Yidong <cyd@gnu.org>
2820
2821 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2822 for the string case (Bug#3874).
2823
3f22b86f
PE
28242012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2825
39eb03f1
PE
2826 * buffer.h (BSET): Remove (Bug#12215).
2827 Replace all uses with calls to new setter functions.
2828 (bset_bidi_paragraph_direction, bset_case_canon_table)
2829 (bset_case_eqv_table, bset_directory, bset_display_count)
2830 (bset_display_time, bset_downcase_table)
2831 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2832 (bset_last_selected_window, bset_local_var_alist)
2833 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2834 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2835 (bset_width_table):
2836 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2837 (bset_auto_fill_function, bset_auto_save_file_format)
2838 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2839 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2840 (bset_cache_long_line_scans, bset_case_fold_search)
2841 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2842 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2843 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2844 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2845 (bset_header_line_format, bset_indicate_buffer_boundaries)
2846 (bset_indicate_empty_lines, bset_invisibility_spec)
2847 (bset_left_fringe_width, bset_major_mode, bset_mark)
2848 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2849 (bset_name, bset_overwrite_mode, bset_pt_marker)
2850 (bset_right_fringe_width, bset_save_length)
2851 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2852 (bset_scroll_up_aggressively, bset_selective_display)
2853 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2854 (bset_word_wrap, bset_zv_marker):
2855 * category.c (bset_category_table):
2856 * syntax.c (bset_syntax_table):
2857 New setter functions.
2858
6a09a33b
PE
2859 * process.h (PSET): Remove (Bug#12215).
2860 Replace all uses with calls to new setter functions.
2861 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2862 (PROCESS_INLINE): New macro.
2863 (pset_childp): New setter function.
2864 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2865 * process.c (PROCESS_INLINE):
2866 Define to EXTERN_INLINE, so that the corresponding functions
2867 are compiled into code.
2868 (pset_buffer, pset_command, pset_decode_coding_system)
2869 (pset_decoding_buf, pset_encode_coding_system)
2870 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2871 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2872 (pset_type, pset_write_queue): New setter functions.
2873
e8c17b81
PE
2874 * window.h (WSET): Remove (Bug#12215).
2875 Replace all uses with calls to new setter functions.
2876 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2877 (WINDOW_INLINE): New macro.
2878 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2879 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2880 (wset_total_lines, wset_vertical_scroll_bar)
2881 (wset_window_end_pos, wset_window_end_valid)
2882 (wset_window_end_vpos): New setter functions.
2883 * window.c (WINDOW_INLINE):
2884 Define to EXTERN_INLINE, so that the corresponding functions
2885 are compiled into code.
2886 (wset_combination_limit, wset_dedicated, wset_display_table)
2887 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2888 (wset_new_normal, wset_new_total, wset_next_buffers)
2889 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2890 (wset_prev_buffers, wset_right_fringe_width)
2891 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2892 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2893 (wset_window_parameters):
2894 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2895 (wset_column_number_displayed, wset_region_showing):
2896 New setter functions.
2897
3f22b86f
PE
2898 * termhooks.h (TSET): Remove (Bug#12215).
2899 Replace all uses with calls to new setter functions.
2900 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2901 (TERMHOOKS_INLINE): New macro.
2902 (tset_charset_list, tset_selection_alist): New setter functions.
2903 * terminal.c (TERMHOOKS_INLINE):
2904 Define to EXTERN_INLINE, so that the corresponding functions
2905 are compiled into code.
2906 (tset_param_alist): New setter function.
2907
742af32f
PE
29082012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2909
15dbb4d6
PE
2910 * keyboard.h (KSET): Remove (Bug#12215).
2911 Replace all uses with calls to new setter functions.
2912 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2913 (KEYBOARD_INLINE): New macro.
2914 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2915 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2916 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2917 New setter functions.
2918 * keyboard.c (KEYBOARD_INLINE):
2919 Define to EXTERN_INLINE, so that the corresponding functions
2920 are compiled into code.
2921 (kset_echo_string, kset_kbd_queue)
2922 (kset_keyboard_translate_table, kset_last_prefix_arg)
2923 (kset_last_repeatable_command, kset_local_function_key_map)
2924 (kset_overriding_terminal_local_map, kset_real_last_command)
2925 (kset_system_key_syms): New setter functions.
2926
f00af5b1
PE
2927 * frame.h (FSET): Remove (Bug#12215).
2928 Replace all uses with calls to new setter functions.
2929 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2930 (FRAME_INLINE): New macro.
2931 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2932 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2933 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2934 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2935 (fset_param_alist, fset_root_window, fset_scroll_bars)
2936 (fset_selected_window, fset_title, fset_tool_bar_items)
2937 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2938 * frame.c (FRAME_INLINE):
2939 Define to EXTERN_INLINE, so that the corresponding functions
2940 are compiled into code.
2941 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2942
0c94c8d6
PE
2943 A few more naming-convention fixes for getters and setters.
2944 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2945 and rename from buffer_overlays_set_before.
2946 (set_buffer_overlays_after): Move here from buffer.h, and rename
2947 from buffer_overlays_set_after.
2948 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2949 All uses changed.
2950 (set_buffer_intervals): Rename from buffer_set_intervals.
2951 * intervals.c (set_interval_object): Move here from intervals.h,
2952 and rename from interval_set_object.
2953 (set_interval_left): Move here from intervals.h, and rename from
2954 interval_set_left.
2955 (set_interval_right): Move here from intervals.h, and rename from
2956 interval_set_right.
2957 (copy_interval_parent): Move here from intervals.h, and rename from
2958 interval_copy_parent.
2959 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2960 (set_interval_plist): Rename from interval_set_plist.
2961 Return void, not Lisp_Object, since no caller uses the result.
2962 * lisp.h (string_intervals): Rename from string_get_intervals.
2963 (set_string_intervals): Rename from string_set_intervals.
2964
34dabdb7
PE
2965 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2966 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2967 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2968 All uses changed. See the end of
2969 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2970
742af32f
PE
2971 * lisp.h (CSET): Remove (Bug#12215).
2972 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2973 (set_char_table_purpose): New functions,
2974 replacing CSET. All uses changed. For example, replace
2975 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2976 "set_char_table_parent (char_table, parent);".
742af32f
PE
2977 The old version was confusing because it used the same name
2978 'parent' for two different things.
2979
a04e2c62
DA
29802012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2981
2982 Functions to get and set Lisp_Object fields of buffer-local variables.
2983 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2984 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2985 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2986 * data.c, eval.c, frame.c: Adjust users.
2987
383dcbf9
CY
29882012-08-17 Chong Yidong <cyd@gnu.org>
2989
2990 * xfaces.c (merge_face_vectors): If the target font specfies a
2991 font spec, make the font's attributes take precedence over
2992 directly-specified attributes.
2993 (merge_face_ref): Recognize :font.
2994
44386687
DA
29952012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2996
2997 Do not use memcpy for copying intervals.
2998 * intervals.c (reproduce_interval): New function.
2999 (reproduce_tree, reproduce_tree_obj): Use it.
3000 (reproduce_tree_obj): Remove prototype.
3001
927c7216
PE
30022012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 * lisp.h (duration_to_sec_usec): Remove unused decl.
3005
93044f7b
AA
30062012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
3007
3008 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
3009 to an allocated instance of NSString, not to the class itself.
3010
9851e4a5
JB
30112012-08-17 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * makefile.w32-in (C_CTYPE_H): New macro.
3014 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
3015 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
3016 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
3017
620f13b0
PE
30182012-08-16 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 Use ASCII tests for character types.
3021 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
3022 * xfns.c, xterm.c:
3023 Don't include <ctype.h>; was not needed.
3024 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
3025 * sysdep.c, xfaces.c:
3026 Include <c-ctype.h> instead of <ctype.h>.
3027 * nsterm.m: Include <c-ctype.h>.
3028 * charset.c (read_hex):
3029 * doc.c (Fsnarf_documentation):
3030 * fileio.c (IS_DRIVE) [WINDOWSNT]:
3031 (DRIVE_LETTER) [DOS_NT]:
3032 (Ffile_name_directory, Fexpand_file_name)
3033 (Fsubstitute_in_file_name):
3034 * font.c (font_parse_xlfd, font_parse_fcname):
3035 * frame.c (x_set_font_backend):
3036 * gtkutil.c (xg_get_font):
3037 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
3038 * nsimage.m (hexchar):
3039 * nsterm.m (ns_xlfd_to_fontname):
3040 * sysdep.c (system_process_attributes):
3041 * xfaces.c (hash_string_case_insensitive):
3042 Use C-locale tests instead of locale-specific tests for character
3043 types, since we want the ASCII interpretation here, not the
3044 interpretation suitable for whatever happens to be the current locale.
3045
52162052
MR
30462012-08-16 Martin Rudalics <rudalics@gmx.at>
3047
3048 Consistently check windows for validity/liveness
3049 (Bug#11984, Bug#12025, Bug#12026).
3050 * lisp.h (CHECK_VALID_WINDOW): New macro.
3051 * window.c (decode_window): Rename to decode_live_window.
3052 (decode_valid_window, Fwindow_valid_p): New functions.
3053 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
3054 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
3055 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
3056 (Fwindow_prev_sibling, Fwindow_combination_limit)
3057 (Fset_window_combination_limit, Fwindow_use_time)
3058 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
3059 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
3060 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
3061 (Fwindow_hscroll, Fset_window_hscroll)
3062 (Fwindow_redisplay_end_trigger)
3063 (Fset_window_redisplay_end_trigger, Fwindow_edges)
3064 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
3065 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3066 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
3067 (Fwindow_end, Fset_window_point, Fset_window_start)
3068 (Fpos_visible_in_window_p, Fwindow_line_height)
3069 (Fwindow_dedicated_p, Fset_window_dedicated_p)
3070 (Fwindow_prev_buffers, Fset_window_prev_buffers)
3071 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
3072 (Fset_window_parameter, Fwindow_display_table)
3073 (Fset_window_display_table, Fdelete_other_windows_internal)
3074 (Fset_window_buffer, Fset_window_new_total)
3075 (Fset_window_new_normal, Fdelete_window_internal)
3076 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
3077 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
3078 (Fwindow_scroll_bars): Check whether argument window is a valid or
3079 live window. Update doc-strings.
3080 (syms_of_window): New symbol Qwindow_valid_p.
3081 * keyboard.c (Fposn_at_x_y): Check whether argument
3082 frame_or_window denotes a valid window.
3083
2751c80f
DA
30842012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3085
3086 Fix previous char table change.
3087 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
3088 * chartab.c (optimize_sub_char_table): Likewise.
3089
032a42c8
CY
30902012-08-16 Chong Yidong <cyd@gnu.org>
3091
a2d19368
CY
3092 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
3093
032a42c8
CY
3094 * xfont.c (xfont_open):
3095 * xftfont.c (xftfont_open): Set the font's max_width field.
3096
3097 * nsfont.m (nsfont_open): Similar to the Xft backend, set
3098 min_width to space_width and average_width to the average over
3099 printable ASCII characters.
3100 (ns_char_width): Code cleanup.
3101 (ns_ascii_average_width): New utility function.
3102
3103 * font.h (struct font): Update comments.
3104
a098c930
DA
31052012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3106
032a42c8 3107 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
3108 * lisp.h (CSET): New macro.
3109 (char_table_set_extras, char_table_set_contents)
3110 (sub_char_table_set_contents): New function.
3111 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
3112 * syntax.c: Adjust users.
3113
8be3a09c
SM
31142012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
3115
3116 * eval.c (eval_sub): Bind lexical-binding.
3117 * lread.c (Qlexical_binding): Make non-static.
3118
ac4845a6
JD
31192012-08-15 Jan Djärv <jan.h.d@swipnet.se>
3120
ddee6515
JD
3121 * nsmenu.m (popupSession): Remove.
3122 (pop_down_menu): Remove endModalSession.
3123 (timeout_handler:): New method.
3124 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
3125 Call runModalForWindow. Check timer_fired when it returns.
3126 If not set, cancel timer and break out of loop.
3127 Otherwise loop again, with a new timeout.
3128
3129 * nsterm.m: Include fcntl.h if present.
3130 (fd_entry, t_readfds, inNsSelect): Remove.
3131 (select_writefds, select_valid, select_timeout, selfds)
3132 (select_mutex, apploopnr): Add.
3133 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
3134 Otherwise call kbd_buffer_store_event.
3135 (ns_send_appdefined): Remove release of fd_entry.
3136 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
3137 Increment and decrement apploopnr.
3138 (ns_select): If no file descriptors, just do a NSTimer.
3139 Otherwise copy read/write masks and start select thread (fd_handler).
3140 Start main loop and wait for application defined event.
3141 Inform select thread to stop selecting after main loop is exited.
3142 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 3143 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
3144 (fd_handler:): Loop forever, wait for info from the main thread
3145 to either start or stop selecting. When select returns, send
3146 and appdefined event.
3147 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
3148 If not call kbd_buffer_store_event.
3149
3150 * nsterm.h (EmacsApp): fd_handler takes id argument.
3151 (EmacsDialogPanel): Add timer_fired and timeout_handler.
3152
ac4845a6
JD
3153 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
3154
eb424fe3
EZ
31552012-08-15 Eli Zaretskii <eliz@gnu.org>
3156
3157 * region-cache.c (move_cache_gap): Update gap_len using the actual
3158 growth of the boundaries array. Do not change cache_len.
3159 (Bug#12196)
3160
4e6a86c6
DA
31612012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3162
3163 Generalize and cleanup font subsystem checks.
3164 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
3165 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
3166 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 3167
5bf192ca
DA
31682012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3169
3170 * gtkutil.c (xg_get_font): Use pango_units_to_double.
3171
f2045622
CY
31722012-08-15 Chong Yidong <cyd@gnu.org>
3173
8be3a09c
SM
3174 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
3175 When using the new font chooser, use gtk_font_chooser_get_font_desc to
3176 extract the font descriptor instead of just the font name.
3177 In that case, return a font spec instead of a string.
f2045622
CY
3178 (x_last_font_name): Move to this file from xfns.c.
3179
3180 * xfns.c (Fx_select_font): The return value can also be a font
3181 spec. Move x_last_font_name management to gtkutil.c.
3182
3183 * xfaces.c: Make font weight and style symbols non-static.
3184
7f6feb56
SM
31852012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
3188 (bug#12117).
3189
fecbd8ff
SM
31902012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
3191
3192 * alloc.c (Fgarbage_collect): Use plural form consistently.
3193
9b8d5165
EZ
31942012-08-14 Eli Zaretskii <eliz@gnu.org>
3195
3196 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
3197 iteration through the command loop. Fixes a problem whereby mouse
3198 movements are ignored until the first mouse click.
3199
f5d9e83a
PE
32002012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 Use bool, not int, for Lisp booleans.
3203 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
3204 makes Emacs a bit smaller and presumably a bit faster.
3205 * lisp.h: Include <stdbool.h>.
3206 (struct Lisp_Boolfwd, defvar_bool):
3207 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
3208 * regex.c [!emacs]: Include <stdbool.h>.
3209 (false, true): Remove; <stdbool.h> does this for us now.
3210
55802e4a
CY
32112012-08-14 Chong Yidong <cyd@gnu.org>
3212
4abcdac8
CY
3213 * character.c (Fcharacterp): Doc fix (Bug#12076).
3214
3215 * data.c (Findirect_variable): Doc fix (Bug#11040).
3216
55802e4a
CY
3217 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3218
3219 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3220 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3221
8e99d072
BR
32222012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3223
3224 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3225 (bug#12022).
3226
08908aca
MR
32272012-08-14 Martin Rudalics <rudalics@gmx.at>
3228
3229 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3230 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3231 * minibuf.c (choose_minibuf_frame, read_minibuf):
3232 * w32fns.c (x_create_tip_frame):
3233 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3234 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3235
56120d6f
PE
32362012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 * intervals.c (offset_intervals): Remove obsolete comment.
3239
67b77c0b
AS
32402012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3241
3242 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3243
f48b82fd
GR
32442012-08-14 Gergely Risko <gergely@risko.hu>
3245
3246 * coding.c (decode_coding): Record buffer modification before
3247 disabling undo_list (Bug#11773).
3248
fd318b54
DA
32492012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3250
3251 Revert and cleanup some recent overlay changes.
3252 * buffer.h (enum overlay_type): Remove.
3253 (buffer_get_overlays, buffer_set_overlays): Likewise.
3254 (buffer_set_overlays_before, buffer_set_overlays_after):
3255 New function. Adjust users.
3256 (unchain_both): Add eassert.
3257
41a62dd9
DA
32582012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3259
3260 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3261
5884c324
PE
32622012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 * gtkutil.c (xg_mark_data): Don't assume C99.
3265
ca06f160
JD
32662012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3267
3268 * gtkutil.c (xg_frame_tb_info): New struct.
3269 (TB_INFO_KEY): New define.
3270 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3271 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3272 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3273 if not present.
3274 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3275 is up to date. Otherwise store new data.
ca06f160
JD
3276 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3277
7864a3f7
DA
32782012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3279
3280 Use KSET for write access to Lisp_Object members of struct kboard.
3281 * keyboard.h (KSET): New macro.
3282 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3283 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3284 * xterm.c: Adjust users.
3285
4c31be61
DA
32862012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3287
3288 Use BSET for write access to Lisp_Object members of struct buffer.
3289 * buffer.h (BSET): New macro.
3290 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3291 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3292 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3293 * window.c, xdisp.c, xfns.c: Adjust users.
3294
14ae4239
BT
32952012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3296
3297 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3298
32bcadb4
JD
32992012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3300
3d29b2ce 3301 * nsterm.m (not_in_argv): New function.
fc0c31f8 3302 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3303 (application:openFileWithoutUI:, application:openFiles:): Open file
3304 if not_in_argv returns non-zero (bug#12171).
3305
32bcadb4 3306 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3307 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3308 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3309 (xg_get_font_name): Use those functions/macros here.
3310 Reported by Frans Oilinki <moilinki@gmail.com>.
3311
9ff9402d 33122012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3313
3314 * unexmacosx.c (copy_data_segment): Copy initialized data in
3315 statically linked libraries from input file rather than memory.
3316
db74a5fc
YM
3317 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3318 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3319 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3320
25e65510
GM
33212012-08-10 Glenn Morris <rgm@gnu.org>
3322
3323 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3324 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3325
7961135c
DA
33262012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3327
3328 Fix last change to allow compilation with low optimization levels.
3329 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3330 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3331
42b3a444
DA
33322012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3333
3334 Use common inline syntax in intervals.h.
3335 * intervals.h (INTERVALS_INLINE): New macro.
3336 Change all users from LISP_INLINE.
3337
9fb0c957
DA
33382012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3339
3340 Define Qnone once for all platforms.
3341 * frame.c (Qnone): Define here.
3342 (syms_of_frame): DEFSYM it.
3343 * lisp.h (Qnone): New declaration.
3344 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3345 * xfns.c: Remove duplication. Adjust users.
3346
65e8ee52
DA
33472012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3348
3349 Remove unused macros from intervals.h.
3350 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3351 * intervals.c: Adjust comment.
3352
9b855fd6
EZ
33532012-08-10 Eli Zaretskii <eliz@gnu.org>
3354
3355 * w32fns.c <w32_unicode_gui>: New static variable.
3356 (globals_of_w32fns): Initialize it according to os_subtype.
3357 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3358 testing os_subtype.
3359
39cb9e56 33602012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3361 Eli Zaretskii <eliz@gnu.org>
3362
3363 Fix bug #10299 with Unicode characters sent by customized
3364 keyboards created by MSKLC.
3365 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3366 (w32_init_class): Use it to initialize the Emacs class with either
3367 ANSI or Unicode API calls.
3368 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3369 later.
3370 (w32_wnd_proc): If the character code sent by WM_CHAR or
3371 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3372 original message. Call DefWindowProcW on NT and later.
3373
9374581a
GM
33742012-08-10 Glenn Morris <rgm@gnu.org>
3375
4b94e8cf
GM
3376 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3377
9374581a
GM
3378 * lisp.h (DIRECTORY_SEP): Let configure set it.
3379
a2752828
DA
33802012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3381
3382 Use TSET for write access to Lisp_Object slots of struct terminal.
3383 * termhooks.h (TSET): New macro.
3384 * coding.c, terminal.c, xselect.c: Adjust users.
3385
cc92c454
SM
33862012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3387
3388 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3389 the failing expression, include them in the error message.
3390 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3391 * lisp.h (internal_condition_case_n): Update declaration.
3392
4cb3e6b3
DA
33932012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3394
3395 Inline functions to examine and change buffer overlays.
3396 * buffer.c (unchain_both): New function.
3397 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3398 (buffer_has_overlays): New function.
3399 (enum overlay_type): New enum.
3400 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3401 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3402
8707c1e5
DA
34032012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3404
3405 Inline functions to examine and change buffer intervals.
3406 * alloc.c (mark_interval_tree): Remove.
3407 (MARK_INTERVAL_TREE): Simplify.
3408 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3409 * intervals.c (buffer_balance_intervals): New function.
3410 (graft_intervals_into_buffer): Adjust indentation.
3411 (set_intervals_multibyte): Simplify.
3412 * buffer.h (BUF_INTERVALS): Remove.
3413 (buffer_get_intervals, buffer_set_intervals): New function.
3414 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3415 * intervals.c, textprop.c: Adjust users.
3416
ad8c997f
DA
34172012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3418
3419 Inline functions to examine and change string intervals.
3420 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3421 (string_get_intervals, string_set_intervals): New function.
3422 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3423 * lread.c, print.c, textprop.c: Adjust users.
3424
32ac3a6b
GM
34252012-08-08 Glenn Morris <rgm@gnu.org>
3426
3427 * lisp.mk (lisp): Remove language/persian.elc.
3428
77c7bcb1
DA
34292012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3430
3431 Cleanup intervals.
3432 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3433 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3434 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3435 Adjust comment. Move under #if 0.
77c7bcb1
DA
3436 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3437 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3438
9c08a8d4
DA
34392012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3440
3441 Check total length of intervals with eassert.
3442 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3443 * intervals.c: Change all users to eassert.
3444
26d16b35
EZ
34452012-08-07 Eli Zaretskii <eliz@gnu.org>
3446
14ae4239
BT
3447 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3448 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3449 INTERNAL_FIELD in Lisp_Cons.
3450
c644523b
DA
34512012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3452
3453 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3454 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3455 name since all xname users are fixed long time ago. Do not
3456 use INTERNAL_FIELD.
3457 (set_symbol_name, set_symbol_function, set_symbol_plist):
3458 (set_symbol_next, set_overlay_plist): New function.
3459 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3460 (struct Lisp_Overlay): Likewise.
3461 (CVAR, MVAR, SVAR): Remove.
3462 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3463 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3464 * xterm.c: Adjust users.
3465 * .gdbinit: Change to use name field of struct Lisp_Symbol
3466 where appropriate.
3467
6a3d20cc
DA
34682012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3469
3470 Basic functions to set Lisp_Object and pointer slots of intervals.
3471 * intervals.h (interval_set_parent, interval_set_object):
3472 (interval_set_left, interval_set_right, interval_set_plist):
3473 (interval_copy_parent): New function.
3474 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3475 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3476 Adjust indentation.
6a3d20cc
DA
3477 (INTERVAL_SIZE): Remove. Adjust users.
3478 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3479
4d2b044c
DA
34802012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3481
3482 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3483 * process.h (PGET): Remove.
3484 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3485 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3486
d3d50620
DA
34872012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3488
3489 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3490 * window.h (WGET): Remove.
3491 (struct window): Do not use INTERNAL_FIELD.
3492 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3493 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3494 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3495 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3496 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3497 Adjust users.
3498
d10a51dc
CY
34992012-08-07 Chong Yidong <cyd@gnu.org>
3500
3501 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3502 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3503 (Fdelete_window_internal): Signal an error if the window is not on
3504 a live frame (Bug#12025).
3505
e69b0960
DA
35062012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3507
3508 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3509 * frame.h (FGET): Remove.
3510 (struct frame): Do not use INTERNAL_FIELD.
3511 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3512 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3513 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3514 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3515
25a20a3a
JB
35162012-08-06 Juanma Barranquero <lekktu@gmail.com>
3517
3518 * w32.c: Silence compiler warnings.
3519 (map_w32_filename): Remove unused variable `is_fat'.
3520 (chase_symlinks): Add parentheses around expression.
3521
1c6f11f4
GM
35222012-08-06 Glenn Morris <rgm@gnu.org>
3523
1db4583a
GM
3524 * sysdep.c: Respect BROKEN_GETWD.
3525
1c6f11f4
GM
3526 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3527 Let configure handle it.
3528 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3529
2b90362b
DA
35302012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3531
3532 Use GCALIGNMENT where appropriate.
3533 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3534 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3535 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3536
5f50daf2
EZ
35372012-08-06 Eli Zaretskii <eliz@gnu.org>
3538
14ae4239
BT
3539 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3540 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3541
cbcc7007
SM
35422012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3545 that should be sufficient for everyone.
3546
4d365fa4
JD
35472012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * keyboard.c (timer_check_2): Add break so timer_check returns next
3550 timeout.
3551
dd86bd82
DA
35522012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3553
3554 Fix Windows build errors introduced after converting to WGET and WSET.
3555 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3556 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3557
054e1668
JD
35582012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3559
3560 * nsterm.m (ns_frame_rehighlight): Use FSET.
3561
3562 * nsmenu.m (ns_update_menubar): Use FSET.
3563
21238f11
DA
35642012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3565
3566 Separate read and write access to Lisp_Object slots of Lisp_Process.
3567 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3568 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3569
077288cf
DA
35702012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3571
3572 Separate read and write access to Lisp_Object slots of struct window.
3573 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3574 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3575 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3576 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3577 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3578 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3579 Adjust users.
3580
71688bd7
DA
35812012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3582
3583 Fix Windows build errors introduced after converting to FGET and FSET.
3584 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3585 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3586 (w32_judge_scroll_bars): Change to use FSET.
3587 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3588
f99bac93
DA
35892012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3590
3591 Fix replacement typo.
3592 * window.c (replace_window): Set root_window instead of
3593 selected_window. This fixes a total window subsystem
3594 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3595
8c2a0f2d
GM
35962012-08-06 Glenn Morris <rgm@gnu.org>
3597
3598 * lisp.mk (lisp): Add language/persian.elc.
3599
edd74c35
DA
36002012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3601
3602 Separate read and write access to Lisp_Object slots of struct frame.
3603 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3604 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3605 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3606 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3607 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3608
8671676c
AS
36092012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3610
3611 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3612
663e2b3f
DA
36132012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3614
3615 Generalize common compile-time constants.
3616 * lisp.h (header_size, bool_header_size, word_size): Now here.
3617 (struct Lisp_Vector): Add comment.
3618 (struct Lisp_Bool_Vector): Move up to define handy constants.
3619 (VECSIZE, PSEUDOVECSIZE): Simplify.
3620 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3621 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3622 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3623 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3624 * xfont.c, xmenu.c: Use word_size where appropriate.
3625
d32e47af
LM
36262012-08-05 Lawrence Mitchell <wence@gmx.li>
3627
3628 * search.c (Freplace_match): Treat \? in the replacement text
3629 literally (Bug#8161).
3630
e5d9c0d1
CY
36312012-08-05 Chong Yidong <cyd@gnu.org>
3632
3633 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3634 * frame.c (Vdelete_frame_functions):
3635 * emacs.c (Vkill_emacs_hook): Doc fix.
3636
8da0576b
EZ
36372012-08-04 Eli Zaretskii <eliz@gnu.org>
3638
3639 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3640 --with-x-toolkit=no builds.
3641 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3642
02676e5d
CY
36432012-08-04 Chong Yidong <cyd@gnu.org>
3644
3645 * syntax.c (Fmodify_syntax_entry): Doc fix.
3646
97147da9
EZ
36472012-08-04 Eli Zaretskii <eliz@gnu.org>
3648
76151e2c
EZ
3649 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3650 * w32.c (init_environment): Change the default values of many
3651 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3652 them into environment when they were not already defined.
3653 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3654 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3655 (check_windows_init_file): Now external, not static.
3656 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3657 called when Vload_path is already set up.
3658
3659 * w32.h (check_windows_init_file): Add prototype.
3660
3661 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3662 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3663 compatibility with Posix platforms.
3664 (main): Move the call to check_windows_init_file to here from
3665 w32.c.
3666 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3667 any, in the DEFALT argument into the root of the Emacs build or
3668 installation tree, as appropriate.
3669
3670 * callproc.c (init_callproc_1): Call decode_env_path instead of
3671 doing its equivalent by hand.
3672 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3673 the code that sets Vexec_path run on MS-Windows.
3674
3675 * lread.c (init_lread): Add comments to #ifdef's.
3676
97147da9
EZ
3677 * msdos.c (dos_set_window_size, IT_update_begin)
3678 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3679 instead of direct references.
3680
185ee146
PE
36812012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 Export DEFAULT_REHASH_* to GDB.
3684 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3685 Now constants, not macros.
3686
8834c57a
PE
36872012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3688
98c6f1e3
PE
3689 Remove unnecessary casts involving pointers.
3690 These casts are no longer needed now that we assume C89 or later,
3691 since they involve casting to or from void *.
3692 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3693 (make_pure_float, make_pure_vector):
3694 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3695 * macros.c (Fstart_kbd_macro):
3696 * menu.c (find_and_return_menu_selection):
3697 * minibuf.c (read_minibuf_noninteractive):
3698 * sysdep.c (closedir):
3699 * xdisp.c (x_produce_glyphs):
3700 * xfaces.c (compare_fonts_by_sort_order):
3701 * xfns.c (x_real_positions, select_visual):
3702 * xselect.c (x_stop_queuing_selection_requests)
3703 (x_get_window_property, x_get_window_property_as_lisp_data):
3704 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3705 Remove unnecessary pointer casts.
3706 * alloc.c (record_xmalloc): New function.
3707 * lisp.h (record_xmalloc): New decl.
3708 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3709 more like a function. This is because the pointer cast is not
3710 needed. All uses changed.
3711 * print.c (print_string, print_error_message): Avoid length recalc.
3712
8834c57a
PE
3713 Improve fix for macroexp crash with debugging (Bug#12118).
3714 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3715 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3716 not supposed to be invoked from the garbage collector.
3717 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3718 (gc_aset): New function, which is like ASET but can be
3719 used in the garbage collector.
3720 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3721 (set_hash_index): Use it instead of ASET.
3722
6dad7178
EZ
37232012-08-03 Eli Zaretskii <eliz@gnu.org>
3724
3725 Support symlinks on latest versions of MS-Windows.
3726 * w32.c: Include winioctl.h and aclapi.h.
3727 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3728 (revert_to_self): Forward declarations of static functions.
3729 <static BOOL g_b_init_get_security_info>:
3730 <g_b_init_create_symbolic_link>: New static flags.
3731 (globals_of_w32): Initialize them to zero.
3732 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3733 (map_w32_filename): Improve commentary. Simplify switch.
3734 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3735 headers (most versions of MinGW w32api don't).
3736 (get_security_info, create_symbolic_link)
3737 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3738 New functions.
3739 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3740 in the argument file name.
3741 (sys_access): Call unc_volume_file_attributes only if
3742 GetFileAttributes fails with network-related error codes.
3743 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3744 have the required privileges.
14ae4239 3745 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3746 get_file_security_desc.
3747 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3748 with addition of handling of symlinks and support for 'lstat'.
3749 If possible, get file's attributes and security information by
6dad7178
EZ
3750 handle, not by name. Produce S_IFLNK bit for symlinks, when
3751 called from 'lstat'.
3752 (stat, lstat): New functions, call 'stat_worker'.
3753 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3754 symlinks when the underlying filesystem supports them.
3755
f162bcc3
PE
37562012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3757
79ea6c20
PE
3758 Fix macroexp crash on Windows with debugging (Bug#12118).
3759 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3760 checking subscripts; problem introduced with the recent
3761 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3762 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3763 since it's used in non-static inline functions now.
3764
c0ce93fd
PE
3765 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3766 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3767
f162bcc3
PE
3768 Use C99-style 'extern inline' if available.
3769 * buffer.h (BUFFER_INLINE):
3770 * category.h (CATEGORY_INLINE):
3771 * character.h (CHARACTER_INLINE):
3772 * charset.h (CHARSET_INLINE):
3773 * composite.h (COMPOSITE_INLINE):
3774 * dispextern.h (DISPEXTERN_INLINE):
3775 * lisp.h (LISP_INLINE):
3776 * systime.h (SYSTIME_INLINE):
3777 New macro, replacing 'static inline' in this header.
3778 * buffer.h, category.h, character.h, charset.h, composite.h:
3779 * dispextern.h, lisp.h, systime.h:
3780 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3781 * alloc.c (LISP_INLINE):
3782 * buffer.c (BUFFER_INLINE):
3783 * category.c (CATEGORY_INLINE):
3784 * character.c (CHARACTER_INLINE):
3785 * charset.c (CHARSET_INLINE):
3786 * composite.c (COMPOSITE_INLINE):
3787 * dispnew.c (DISPEXTERN_INLINE):
3788 * sysdep.c (SYSTIME_INLINE):
3789 Define to EXTERN_INLINE, so that the corresponding functions
3790 are compiled into code.
3791 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3792 (INLINE_HEADER_END): New macros.
3793 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3794 since it's used in non-static inline functions now.
a8333d03 3795 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3796
837b365b
GM
37972012-08-02 Glenn Morris <rgm@gnu.org>
3798
d66b744d
GM
3799 * s/: Remove empty directory.
3800
837b365b
GM
3801 * s/ms-w32.h: Move to ../nt/inc.
3802 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3803 Update for new ms-w32.h location.
3804
13294f95
PE
38052012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 Port to Solaris 8.
3808 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3809
90df0db3
GM
38102012-08-02 Glenn Morris <rgm@gnu.org>
3811
3812 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3813 hard-coding the path separator.
3814
4939150c
PE
38152012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3818 This how ASET and AREF are supposed to work, and makes
3819 it easier to think about future improvements. See
3820 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3821 * charset.h (set_charset_attr): New function.
3822 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3823 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3824 (aref_addr): New function. All uses of &AREF(...) changed.
3825 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3826 (set_hash_index): New functions. All lvalue-style uses of
3827 HASH_KEY etc. changed.
3828 * keyboard.c (set_prop): New function. All lvalue-style uses
3829 of PROP changed.
3830
947b2afd
AA
38312012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3832
3833 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3834 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3835 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3836 * nsfns.m (ns_set_name_as_filename): Likewise.
3837 * nsmenu.m (ns_update_menubar): Likewise.
3838 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3839
4f5d0325
EZ
38402012-08-01 Eli Zaretskii <eliz@gnu.org>
3841
2008beae
EZ
3842 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3843 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3844 objects.
2008beae 3845
4f5d0325
EZ
3846 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3847
fe3cc771
GM
38482012-08-01 Glenn Morris <rgm@gnu.org>
3849
3850 * s/msdos.h: Remove file.
3851 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3852 * Makefile.in (S_FILE): Remove.
3853 (config_h): Remove S_FILE.
3854
c90acc54
JB
38552012-08-01 Juanma Barranquero <lekktu@gmail.com>
3856
3857 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3858 Remove; moved to nt/config.nt.
3859
d8a05828
DA
38602012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3861
3862 Use INTERNAL_FIELD for conses and overlays.
3863 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3864 Remove obsolete comment.
3865 (MVAR): New macro.
3866 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3867 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3868
8271d590
DA
38692012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3870
3871 Use INTERNAL_FIELD for symbols.
3872 * lisp.h (SVAR): New macro. Adjust users.
3873 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3874 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3875
3193acd2
DA
38762012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3877
3878 Use INTERNAL_FIELD for processes.
3879 * process.h (PVAR): New macro. Adjust style.
3880 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3881 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3882
3a45383a
DA
38832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3884
3885 Use INTERNAL_FIELD for windows.
3886 * window.h (WVAR): New macro.
3887 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3888 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3889 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3890 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3891 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3892 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3893
c1dbc63c
PE
38942012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3897
5c0c0e8a
GM
38982012-08-01 Glenn Morris <rgm@gnu.org>
3899
3900 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3901 Move to configure.ac.
3902
552a99b4
JB
39032012-08-01 Juanma Barranquero <lekktu@gmail.com>
3904
3905 * makefile.w32-in (CONFIG_H): Update dependencies.
3906 (CONF_POST_H): New macro.
3907
3908 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3909
8d8e2dfe
GM
39102012-07-31 Glenn Morris <rgm@gnu.org>
3911
bc96620a
GM
3912 * Makefile.in (S_FILE): No longer set by configure.
3913
476b1b2d
GM
3914 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3915 is available.
3916 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3917
b2c7a106
GM
3918 * process.h (NULL_DEVICE):
3919 * emacs.c (SEPCHAR):
3920 * editfns.c (USER_FULL_NAME): Let configure set them.
3921
d53d062a
GM
3922 * s/README, s/template.h: Remove files.
3923
4515017f
GM
3924 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3925
8d8e2dfe
GM
3926 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3927 Move to configure.ac.
3928
5b20b3cc
EZ
39292012-07-31 Eli Zaretskii <eliz@gnu.org>
3930
1e0afd9a
EZ
3931 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3932 resulting renaming of 'struct frame' members.
3933
5b20b3cc
EZ
3934 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3935
3936 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3937 after introduction of FVAR.
3938
f1310128
JD
39392012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3940
79e721e0
JD
3941 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3942
3943 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3944 instead of compositeToPoint.
3945 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3946
8d7c7eed 3947 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3948
e34f7f79
DA
39492012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3950
3951 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3952 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3953 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3954 (BVAR): Change to use INTERNAL_FIELD.
3955 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3956 (KVAR): Change to use INTERNAL_FIELD.
3957 * frame.h (FVAR): New macro.
3958 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3959 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3960 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3961 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3962 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3963
c09bfb2f
DA
39642012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3965
3966 Miscellaneous fixes for non-default X toolkits.
3967 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3968 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3969 Move under #ifdef USE_LUCID.
3970 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3971 definition and usage to avoid warnings.
3972
14c114ae
JD
39732012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3974
3975 * nsterm.m (openFiles): Fix previous checkin.
3976
3bd21e82
PE
39772012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 * indent.c (compute_motion): Remove unused local.
3980
c1529ded
GM
39812012-07-31 Glenn Morris <rgm@gnu.org>
3982
400d5621
GM
3983 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3984
268e2432
GM
3985 * conf_post.h [USG5_4]:
3986 Move remaining contents of s/usg5-4-common.h here.
3987 * s/usg5-4-common.h: Remove file.
3988
7552f3ee
GM
3989 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3990 * s/irix6-5.h: Remove file.
3991
6a381852
GM
3992 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3993 * s/darwin.h: Remove file.
3994
c1529ded
GM
3995 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3996 * s/hpux10-20.h: Remove file, which is now empty.
3997
b429a4ee
GM
39982012-07-30 Glenn Morris <rgm@gnu.org>
3999
4000 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
4001 * Makefile.in (config_h): Add conf_post.h.
4002 * makefile.w32-in (CONFIG_H): Add conf_post.h.
4003
adff3182
JD
40042012-07-30 Jan Djärv <jan.h.d@swipnet.se>
4005
4006 * nsterm.m (ns_do_open_file): New variable.
b9031d69 4007 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
4008 (openFile, openTempFile, openFileWithoutUI, openFiles):
4009 Open files only if ns_do_open_file.
adff3182 4010
c32af1e4
PE
40112012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4012
7393bcbb
PE
4013 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
4014 This no-op macro hasn't been needed for many years.
4015 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
4016
c32af1e4
PE
4017 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
4018 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
4019 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
4020 gdb_make_enums_visible.
4021 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
4022 (DIRECTORY_SEP): Now a constant, not a macro.
4023
302fc036
EZ
40242012-07-30 Eli Zaretskii <eliz@gnu.org>
4025
4026 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
4027 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
4028
4029 * w32term.c <w32_keyboard_codepage>: Renamed from
4030 keyboard_codepage and now external. All users changed.
4031
4032 * w32term.h: Add declaration of w32_keyboard_codepage.
4033
4034 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
4035 the codepage to translate keys to Unicode. If this argument is
4036 -1, use the value returned by GetConsoleCP. All callers changed.
4037
88fb40b4
PE
40382012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4039
0aee6912
PE
4040 Update .PHONY listings in makefiles.
4041 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
4042 bootstrap-clean, distclean, maintainer-clean, versioclean,
4043 extraclean, frc.
4044
88fb40b4
PE
4045 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
4046 This is a bit clearer. Fix some commentary typos.
4047
0a763bd1
GM
40482012-07-30 Glenn Morris <rgm@gnu.org>
4049
32bac6d6
GM
4050 * s/netbsd.h: Let configure include signal.h if needed.
4051 Remove file, which is now empty.
4052
b65e7c46
GM
4053 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
4054 Let configure set them.
4055 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
4056 No more need to undefine.
0a763bd1 4057
169304bd
AS
40582012-07-30 Andreas Schwab <schwab@linux-m68k.org>
4059
4060 * keymap.c (Fkey_description): Don't remove 0x80 bit from
4061 non-single-byte char when adding meta modifier. (Bug#12090)
4062
6cd7a139
DA
40632012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4064
4065 Convert safe_call to use variable number of arguments.
4066 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
4067 (safe_call2): Fix comment.
4068 * lisp.h (safe_call): Adjust prototype.
4069 * coding.c (encode_coding_object): Change to use safe_call2.
4070 * xfaces.c (merge_face_heights): Change to use safe_call1.
4071
d34d6ffc
GM
40722012-07-30 Glenn Morris <rgm@gnu.org>
4073
7b8a48e4 4074 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 4075 does that unconditionally. Remove file, which is now empty.
7b8a48e4 4076
d34d6ffc
GM
4077 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
4078 Remove empty files.
4079
03a660a6
PE
40802012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 Export to GDB most of lisp.h's remaining object-like macros.
4083 * lisp.h (min, max): Move earlier, because they're used earlier now.
4084 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
4085 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
4086 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
4087 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
4088 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
4089 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
4090 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
4091 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
4092 Now constants, for GDB. They need not be macros.
4093 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
4094 Now constants, for GDB, as well as macros, for static initializers.
4095 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
4096 Move to after the definition of struct Lisp_Char_Table,
4097 since the former now needs that type defined.
4098 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
4099 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
4100 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
4101 New enums, for gdb_make_enums_visible.
4102 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 4103 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
4104 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
4105 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
4106 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
4107 enum maxargs, enum MAX_ALLOCA.
4108 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
4109 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
4110 no longer needed, now that they are done in lisp.h.
4111
e499d0ee
DA
41122012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4113
4114 Cleanup string bytes checking.
4115 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
4116 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
4117 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
4118 (check_sblock, compact_small_strings): Simplify.
4119
d5040d2d
PE
41202012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4123 These macros are confusing and no longer need to be defined, as
4124 the enum values now suffice. All uses replaced with definiens.
4125 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
4126
7f259ae6
JB
41272012-07-29 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
4130 ($(BLD)/w32console.$(O)): Update dependencies.
4131
7e63e0c3
DA
41322012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4133
4134 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4135 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
4136 time. Adjust users.
4137 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
4138
ffd817eb
JD
41392012-07-29 Jan Djärv <jan.h.d@swipnet.se>
4140
4141 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4142 setting sitelisp (Bug#12010).
4143
417a7a0e
EZ
41442012-07-29 Eli Zaretskii <eliz@gnu.org>
4145
14ae4239 4146 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
4147
4148 * w32heap.c (cache_system_info):
4149 * w32.c (sys_rename):
4150 * w32proc.c (find_child_console, sys_kill): All users changed.
4151
387d4d92
PE
41522012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4153
4154 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
4155
55a6cca6
EZ
41562012-07-29 Eli Zaretskii <eliz@gnu.org>
4157
4158 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4159
dbcf001c
DA
41602012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4161
4162 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
4163 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
4164 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 4165
e2688e4a
DA
41662012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4167
4168 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4169 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
4170 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
4171 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
4172 (replace_range, replace_range_2, del_range_2): Change to eassert.
4173 * marker.c (byte_char_debug_check): Adjust style.
4174
b46a6a83
PE
41752012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4176
4177 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4178 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
4179 long-ago-commented-out code that talks about "WIN32".
4180 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
4181 All uses changed.
4182
e32a5799
PE
41832012-07-28 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 Use Gnulib stdalign module (Bug#9772, Bug#9960).
4186 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
4187 Simplify by using alignof.
4188 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
4189 * lisp.h: Include <stdalign.h>.
4190 (GCALIGNMENT): New macro and constant.
4191 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
4192 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
4193 (stdalign): New macro, if not already defined.
4194
df81cd29
EZ
41952012-07-28 Eli Zaretskii <eliz@gnu.org>
4196
01bd1b0d
EZ
4197 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4198 * w32inevt.c: Include w32inevt.h.
4199 (w32_read_console_input): New inline function, calls either
4200 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
4201 w32_console_unicode_input.
4202 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
4203 (w32_kbd_patch_key, key_event): Use the codepage returned by
4204 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
4205 (key_event): use uChar.UnicodeChar only if
4206 w32_console_unicode_input is non-zero.
4207
4208 * w32console.c: Include w32heap.h.
4209 <w32_console_unicode_input>: New global variable.
4210 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
4211 family of Windows, zero otherwise.
4212
4213 * w32inevt.h: Declare w32_console_unicode_input.
4214
df81cd29
EZ
4215 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4216 --without-x. (Bug#11742)
4217
c20fdd9e
PE
42182012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4219
4220 Adjust GDB to reflect pvec_type changes (Bug#12036).
4221 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4222 2012-07-04 changes to pseudovector representation.
4223 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4224
32770973 42252012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4226
4227 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4228 bus address.
4229 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4230
3438fe21
EZ
42312012-07-27 Eli Zaretskii <eliz@gnu.org>
4232
bcfbc9de
EZ
4233 * alloc.c (listn): Fix the order the arguments are consed onto the
4234 list.
4235
3438fe21
EZ
4236 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4237 enumeration constants, as PURE and HEAP are too general, and clash
4238 with other headers and sources, such as gmalloc.c and the
4239 MS-Windows system headers. All users changed.
4240
eeaea515
DA
42412012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4242
4243 Revert last save_excursion_save and save_excursion_restore changes.
4244 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4245 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4246
073c88c2
DA
42472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4248
4249 Fix recently-introduced typos in Windows port.
4250 Reported by Martin Rudalics <rudalics@gmx.at>.
4251 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4252 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4253
4706125e
PE
42542012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 Improve GDB symbol export (Bug#12036).
4257 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4258 arms of an 'if', not using conditional expressions; otherwise GDB
4259 complains about the types in the unevaluated arm when the argument
4260 is an integer literal.
4261 (xgetint): Simplify expression.
4262 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4263 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4264 Zaretskii in <http://bugs.gnu.org/12036#13>.
4265 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4266 needed now that we have gdb_make_enums_visible.
4267 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4268 (enum enum_USE_LSB_TAG):
4269 New enum types, packaging up enums that need to be exported to GDB.
4270
694b6c97
DA
42712012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4272
4273 Utility function to make a list from specified amount of objects.
4274 * lisp.h (enum constype): New datatype.
4275 (listn): New prototype.
4276 * alloc.c (listn): New function.
4277 (Fmemory_use_count, syms_of_alloc): Use it.
4278 * buffer.c (syms_of_buffer): Likewise.
4279 * callint.c (syms_of_callint): Likewise.
4280 * charset.c (define_charset_internal): Likewise.
4281 * coding.c (syms_of_coding): Likewise.
4282 * keymap.c (syms_of_keymap): Likewise.
4283 * search.c (syms_of_search): Likewise.
4284 * syntax.c (syms_of_syntax): Likewise.
4285 * w32.c (init_environment): Likewise.
4286 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4287 * xdisp.c (syms_of_xdisp): Likewise.
4288 * xfns.c (syms_of_xfns): Likewise.
4289
6195f384
DA
42902012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4291
4292 Fast save_excursion_save and save_excursion_restore.
4293 * lisp.h (struct Lisp_Excursion): New data type.
4294 (PVEC_EXCURSION): New pseudovector type.
4295 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4296 to deal with it. Adjust comments.
4297 (init_marker, attach_marker): New prototype.
4298 (unchain_marker): Adjust prototype.
4299 * marker.c (attach_marker): Change to global.
4300 (init_marker): New function.
4301 * alloc.c (Fmake_marker, build_marker): Use it.
4302 (build_marker): More easserts.
4303 (mark_object): Handle struct Lisp_Excursion.
4304 * editfns.c (save_excursion_save, save_excursion_restore):
4305 Reimplement to use struct Lisp_Excursion. Add comments.
4306
5eceb8fb
PE
43072012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 Fix export of symbols to GDB (Bug#12036).
4310 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4311 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4312 emacs.c, as this is a more-suitable home. Had this been done earlier
4313 the fix for 12036 would have avoided some of the problems noted in
4314 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4315 would have been more obvious.
562157c8
PE
4316 * emacs.c: Do not include <verify.h>; no longer needed.
4317 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4318 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4319 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4320 Remove; now done in lisp.h.
4321 * lisp.h (PUBLISH_TO_GDB): New macro.
4322 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4323 (DATA_SEG_BITS): Use it.
4324 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4325 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4326 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4327 not be usable in #if. This simplifies things.
4328
d6749401
JB
43292012-07-26 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4332
1781b9e9
PE
43332012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4334
d89518db 4335 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4336 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4337 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4338 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4339 Adjust to changes in lisp.h and emacs.c, by using
4340 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4341 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4342 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4343 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4344 instead of gdb_valbits.
4345 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4346 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4347 instead of gdb_array_mark_flag.
4348 (xboolvector): Get size from $->size, not $->header.size.
4349 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4350 (xreload, hook-run, hookpost-run): Remove.
4351 * emacs.c: Include <verify.h>.
4352 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4353 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4354 Remove.
4355 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4356 (gdb_USE_LSB_TAG): New enum constants.
4357 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4358 Also define these as enum constants, so they're visible to GDB.
4359 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4360 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4361 as constants, so they're visible to GDB.
4362 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4363 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4364 Now enum constants, not macros, so they're visible to GDB.
4365 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4366 more convenient now. All uses changed.
4367 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4368 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4369
3628596a
DA
43702012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4371
4372 Explicitly free restriction data that are not needed anymore.
4373 * editfns.c (save_restriction_restore): Free restriction data.
4374
7abaf5cc
SM
43752012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4376
4377 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4378 add argument, tune behavior, and adjust all callers.
4379
71f88e00
PE
43802012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 Use typedef for EMACS_INT, EMACS_UINT.
4383 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4384 than macros. This simplifies debugging in the usual case, since
4385 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4386 and it allows expressions involving EMACS_INT casts.
4387 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4388
57ec3034
JD
43892012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4390
4391 * nsterm.m (ns_read_socket): Return early if there is a modal
4392 window (Bug#12043).
4393
8137e7b3
MR
43942012-07-25 Martin Rudalics <rudalics@gmx.at>
4395
4396 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4397 that FOCUS-FRAME can be omitted.
4398
04e9897c
DA
43992012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4400
4401 Adjust buffer text indirection counters at the end of Fkill_buffer.
4402 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4403 buffer is definitely dead. This should really fix an issue reported
4404 by Christoph Scholtes again. (Bug#12007).
4405 (init_buffer_once): Initialize indirection counters of
4406 buffer_defaults and buffer_local_symbols (for sanity and safety).
4407
8a0484e1
EZ
44082012-07-24 Eli Zaretskii <eliz@gnu.org>
4409
4410 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4411 and continuation glyphs on tooltip frames, leave them at zero.
4412 Avoids continued lines in tooltips. (Bug#11832)
4413
fa691a83
DA
44142012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4415
4416 Simplify copy_overlay.
04e9897c 4417 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4418 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4419
436bc8e0
EZ
44202012-07-23 Eli Zaretskii <eliz@gnu.org>
4421
4422 * print.c (print_object): Don't crash when a frame's name is nil
4423 or invalid. (Bug#12025)
4424
4425 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4426 it signals an error when a tooltip frame is being created.
4427
d7a7fda3
DA
44282012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4429
4430 Cleanup miscellaneous objects allocation and initialization.
4431 * alloc.c (allocate_misc): Change to static. Add argument to
4432 specify the subtype. Adjust comment and users.
4433 (build_overlay): New function.
4434 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4435 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4436 (allocate_misc): Remove prototype.
4437 (build_overlay): Add prototype.
4438
44392012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4440
4441 Swap buffer text indirection counters in Fbuffer_swap_text.
4442 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4443 This avoids crash reported by Christoph Scholtes at
4444 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4445
9d7fa573
JD
44462012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4447
4448 * nsmenu.m (Popdown_data): New struct.
4449 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4450 free Popdown_data.
4451 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4452 (initWithContentRect): Make imgView and contentView non-static
4453 and autorelease them. Also autorelease img and matrix (Bug#12005).
4454 (dealloc): Remove (Bug#12005).
4455
0dd6d66d
DA
44562012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4457
4458 Adjust consing_since_gc when objects are explicitly freed.
4459 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4460 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4461 (free_cons, free_misc): Subtract object size from consing_since_gc.
4462
d36d71df
DA
44632012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4464
4465 Simplify and cleanup markers positioning code.
4466 * marker.c (attach_marker): More useful eassert.
4467 (live_buffer, set_marker_internal): New function.
4468 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4469 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4470
fb9ea40f
PE
44712012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4474 as it's limited by the amount of memory, not by INT_MAX.
4475
2d5c5f7d
EZ
44762012-07-21 Eli Zaretskii <eliz@gnu.org>
4477
07fb592e
EZ
4478 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4479 in special-event-map. See the discussion at
4480 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4481 for the reasons.
4482
37a9eac8 4483 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4484 info.dwItemData. Fixes crashes on 64-bit Windows.
4485 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4486
c4328746
JD
44872012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4488
fc0c31f8 4489 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4490 (conversationIdentifier): Return value is NSInteger.
784051c4 4491 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4492
6e5d1c12
CY
44932012-07-21 Chong Yidong <cyd@gnu.org>
4494
4495 * window.c (decode_any_window): Signal an error if the window is
4496 on a dead frame (Bug#11984).
4497
9928463d
DA
44982012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4499
4500 Add indirection counting to speed up Fkill_buffer.
4501 * buffer.h (struct buffer): New member.
4502 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4503 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4504 base buffer indirection counter.
4505 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4506 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4507 through buffer list if indirection counter is 0.
4508
f8643a6b
DA
45092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4510
4511 Extend the value returned by Fgarbage_collect with heap statistics.
4512 * alloc.c (Qheap): New symbol.
4513 (syms_of_alloc): DEFSYM it.
4514 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4515 (Fmemory_free): Remove.
4516 (syms_of_alloc): Don't defsubr it.
4517 * buffer.c (Fcompact_buffer): Remove.
4518 (syms_of_buffer): Don't defsubr it.
4519
dac616ff
DA
45202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4521
4522 Make maybe_gc inline.
4523 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4524 * lisp.h (consing_since_gc, gc_relative_threshold)
4525 (memory_full_cons_threshold): Revert declaration.
4526 (maybe_gc): Remove prototype, define as inline.
4527 * alloc.c: Remove old commented-out code.
4528 (consing_since_gc, gc_relative_threshold)
4529 (memory_full_cons_threshold): Revert to global.
4530 (maybe_gc): Remove.
4531
d7ea76b4
DA
45322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4533
4534 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4535 * lisp.h (build_unibyte_string): New function.
4536 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4537 * sysdep.c, w32fns.c, xfns.c: Use it.
4538 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4539 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4540 Adjust users accordingly.
4541 * font.h (font_open_by_name): Adjust prototype.
4542
765e61e3
DA
45432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4544
4545 Cleanup calls to Fgarbage_collect.
4546 * lisp.h (maybe_gc): New prototype.
4547 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4548 Remove declarations.
4549 * alloc.c (maybe_gc): New function.
4550 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4551 Make them static.
4552 * bytecode.c (MAYBE_GC): Use maybe_gc.
4553 * eval.c (eval_sub, Ffuncall): Likewise.
4554 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4555 to avoid dependency from auto-save feature.
4556
52b852c7
PE
45572012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4558
4559 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4560 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4561 'for_each_per_buffer_object_at'.
4562 All uses changed. It's better to use upper-case for macros that
4563 cannot be implemented as functions, to give the reader a clue
4564 that they're special.
4565
5db81e33
SM
45662012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4567
4568 * alloc.c (Fgarbage_collect): Tweak docstring.
4569
5b835e1d
DA
45702012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4571
4572 Tweak the value returned from Fgarbage_collect again.
4573 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4574 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4575 Adjust documentation.
4576 (total_vector_bytes): Rename to total_vector_slots, adjust
4577 accounting.
4578 (total_free_vector_bytes): Rename to total_free_vector_slots,
4579 adjust accounting.
4580 (Qstring_bytes, Qvector_slots): New symbols.
4581 (syms_of_alloc): DEFSYM them.
4582
9cd47b72
DA
45832012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4584
4585 Buffer compaction primitive which may be used from Lisp.
4586 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4587 (syms_of_buffer): Register Fcompact_buffer.
4588 * alloc.c (Fgarbage_collect): Use compact_buffer.
4589 * buffer.h (compact_buffer): New prototype.
4590 (struct buffer_text): New member.
4591
d17337e5
DA
45922012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4593
4594 New macro to iterate over all buffers, miscellaneous cleanups.
4595 * lisp.h (all_buffers): Remove declaration.
4596 * buffer.h (all_buffers): Add declaration, with comment.
4597 (for_each_buffer): New macro.
4598 * alloc.c (Fgarbage_collect, mark_object): Use it.
4599 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4600 (init_buffer): Likewise.
4601 * data.c (Fset_default): Likewise.
4602 * coding.c (code_conversion_restore): Remove redundant check
4603 for dead buffer.
4604 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4605
60cfd278
AS
46062012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4607
4608 Fix bug that created negative-length intervals.
4609 * intervals.c (merge_interval_right, merge_interval_left):
4610 Do not zero out this interval if it is absorbed by its children,
4611 as this interval's total length doesn't change in that case. See
4612 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4613
d06714cb
PE
46142012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4615
83713154
PE
4616 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4617 when invoking (make-bool-vector N t) and N is a positive
4618 multiple of 8 -- the last 8 bits were mistakenly cleared.
4619
d06714cb
PE
4620 Remove some struct layout assumptions in bool vectors.
4621 * alloc.c (bool_header_size): New constant.
4622 (header_size, word_size): Move earlier, as they're now used earlier.
4623 Use 'word_size' in a few more places, where it's appropriate.
4624 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4625 padding before the data member of a bool vector.
4626 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4627 than doing the check by hand with an abort ().
4628
464d5a5e
SM
46292012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4630
5fbc0409
SM
4631 * eval.c (Fdefvar): Don't check constants since we only set the var if
4632 it's not yet defined anyway (bug#11904).
4633
464d5a5e
SM
4634 * lisp.h (last_undo_boundary): Declare new var.
4635 * keyboard.c (command_loop_1): Set it.
4636 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4637 were auto-added by the command loop (bug#11774).
4638
8dc2e44a
AS
46392012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4640
4641 * w32font.c (Qsymbol): Remove local definition.
4642 (syms_of_w32font): Don't DEFSYM it.
4643
169925ec
DA
46442012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4645
4646 Fix sweep_vectors to handle large bool vectors correctly.
4647 * alloc.c (sweep_vectors): Account total_vector_bytes for
4648 bool vectors larger than VBLOCK_BYTES_MAX.
4649
5fbfb018
CY
46502012-07-18 Chong Yidong <cyd@gnu.org>
4651
4652 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4653 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4654
3ab6e069
DA
46552012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4656
4657 Return more descriptive data from Fgarbage_collect.
4658 Suggested by Stefan Monnier in
4659 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4660 * alloc.c (bounded_number): New function.
4661 (total_buffers, total_vectors): New variable.
4662 (total_string_size): Rename to total_string_bytes, adjust users.
4663 (total_vector_size): Rename to total_vector_bytes, adjust users.
4664 (sweep_vectors): Account total_vectors and total_vector_bytes.
4665 (Fgarbage_collect): New return value. Adjust documentation.
4666 (gc_sweep): Account total_buffers.
4667 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4668 (VECTOR_SIZE): Remove.
4669 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4670 (Qinterval, Qmisc): New symbols.
4671 (syms_of_data): Initialize them.
4672 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4673 (Qcons, Qbuffer): New declarations.
4674
6d02fe5b
PE
46752012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4676
4677 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4678 Round up, not down. Improve doc.
4679
b7ffe040
DA
46802012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4681
4682 Restore old code in allocate_string_data to avoid Faset breakage.
4683 Reported by Julien Danjou <julien@danjou.info> in
4684 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4685 * alloc.c (allocate_string_data): Restore old code with minor
4686 adjustments, fix comment to explain this subtle issue.
4687
4dc7c8d5
SM
46882012-07-17 Eli Zaretskii <eliz@gnu.org>
4689
4690 Remove FILE_SYSTEM_CASE.
4691 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4692
4693 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4694 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4695 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4696 call-process-region passes it through expand-file-name.
4697
4698 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4699
47002012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4701
4702 Fix crash when creating indirect buffer (Bug#11917)
4703 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4704 Don't handle unbound variables specially if non-zero.
4705 (Fbuffer_local_variables): Pass zero.
4706 (clone_per_buffer_values): Pass non-zero.
4707
47082012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4709
4710 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4711 to make the loop interruptible.
4712
47132012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4714
4715 * gnutls.c (emacs_gnutls_handshake): Only retry if
4716 GNUTLS_E_INTERRUPTED.
4717
cce7fefc
DA
47182012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4719
4720 Cleanup and convert miscellaneous checks to eassert.
4721 * alloc.c (mark_interval): Fix comment, partially rephrase
4722 old comment from intervals.h (see below).
4723 * intervals.c (find_interval, adjust_intervals_for_insertion)
4724 (delete_interval, adjust_intervals_for_deletion)
4725 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4726 Convert to eassert.
4727 (adjust_intervals_for_insertion, make_new_interval):
4728 Remove obsolete and unused code.
4729 * intervals.h (struct interval): Remove obsolete comment.
4730 * textprotp.c (erase_properties): Remove unused code.
4731 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4732 (Fremove_list_of_text_properties): Convert to eassert.
4733
9ea10cc3
CY
47342012-07-17 Chong Yidong <cyd@gnu.org>
4735
4736 * editfns.c (Finsert_char): Doc fix.
4737
3900d5de
DA
47382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4739
4740 Fix previous change to make Fmemory_free always accurate.
4741 * alloc.c (make_interval): Update total_free_intervals.
4742 (make_float): Likewise for total_free_floats.
4743 (free_cons, Fcons): Likewise for total_free_conses.
4744 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4745 Likewise for total_free_vector_bytes.
4746 (Fmake_symbol): Likewise for total_free_symbols.
4747 (bytes_free): Remove.
4748
7098646f
DA
47492012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4750
4751 Simple free memory accounting feature.
4752 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4753 (sweep_vectors): Accumulate size of free vectors.
4754 (Fgarbage_collect): Setup bytes_free.
4755 (Fmemory_free): New function.
4756 (syms_of_alloc): Register it.
4757
22657b40
DA
47582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4759
4760 Cleanup overlays checking.
4761 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4762 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4763 eassert and OVERLAYP.
4764 (sort_overlays): Change to use OVERLAYP.
4765
ddfc8813
RK
47662012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4767
4768 * editfns.c (Finsert_char): Make it interactive, and make the
4769 second arg optional. Copy interactive spec and docstring from
4770 ucs-insert.
4771
7c26cf3c
PE
47722012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4773
4774 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4775 Unlike the other wrapped functions, fabs has an unspecified
4776 effect on errno.
4777
5d127af9
JD
47782012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4779
4780 * nsterm.m (keyDown): Interpret flags without left/right bits
4781 as the left key (Bug#11670).
4782
6a0dd1d7
DA
47832012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4784
4785 Remove empty and useless init functions.
4786 * lisp.h (init_character_once, init_fns, init_image)
4787 (init_filelock, init_sound): Remove prototype.
4788 * character.c (init_character_once): Remove.
4789 * filelock.c (init_filelock): Likewise.
4790 * fns.c (init_fns): Likewise.
4791 * image.c (init_image): Likewise.
4792 * sound.c (init_sound): Likewise.
4793 * emacs.c (main): Adjust accordingly.
4794
7a6136fd
DA
47952012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4796
4797 * gtkutil.h: Tiny cleanups.
4798 (use_old_gtk_file_dialog): Remove useless declaration.
4799 (xg_uses_old_file_dialog): Add suggested const attribute.
4800
ce811ad9
EZ
48012012-07-15 Eli Zaretskii <eliz@gnu.org>
4802
4803 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4804 (bidi_paragraph_init): Use it to limit search forward for a strong
4805 directional character in abnormally large paragraphs full of
4806 neutral or weak characters. (Bug#11943)
4807
c9adfeaa
SF
48082012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4809
4810 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4811 the toolbar (Bug#9451).
4812 (xg_make_tool_item): Give the widget event box a transparent
4813 background.
4814
fff62aa9
DA
48152012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4816
4817 Cleanup basic allocation variables and functions.
4818 * alloc.c (ignore_warnings, init_intervals, init_float)
4819 (init_cons, init_symbol, init_marker): Remove.
4820 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4821 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4822 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4823 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4824 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4825 (staticidx, init_alloc_once, init_strings, free_ablock):
4826 Remove redundant initialization.
4827 * fns.c (init_weak_hash_tables): Remove.
4828 * lisp.h (init_weak_hash_tables): Remove prototype.
4829
9730daca
DA
48302012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4831
4832 Use zero_vector where appropriate.
4833 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4834 accordingly.
4835 * lisp.h (zero_vector): New declaration.
4836 * font.c (null_vector): Remove.
4837 (syms_of_font): Remove initialization and staticpro.
4838 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4839 * keymap.c (Faccessible_keymaps): Likewise.
4840
2e2d2a13
LL
48412012-07-15 Leo Liu <sdl.web@gmail.com>
4842
4843 * fringe.c: Fix typo in comments.
4844
cd276f6e
LL
48452012-07-14 Leo Liu <sdl.web@gmail.com>
4846
4847 * fringe.c: Add a new bitmap exclamation-mark.
4848
5a1131d9
EZ
48492012-07-14 Eli Zaretskii <eliz@gnu.org>
4850
4851 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4852
4853 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4854 (HAVE_MENUS): Don't define, defined by editing config.in with
4855 msdos/sed2v2.inp.
4856 (GMALLOC_INHIBIT_VALLOC): Don't define.
4857 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4858
22e983b7
JB
48592012-07-14 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4862
5b3f250f
GM
48632012-07-14 Glenn Morris <rgm@gnu.org>
4864
4865 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4866 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4867 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4868
33d63ff4
GM
48692012-07-13 Glenn Morris <rgm@gnu.org>
4870
5b633342
GM
4871 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4872
33d63ff4
GM
4873 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4874 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4875
b55b9f85
JD
48762012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4877
0dc8cf50
JD
4878 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4879 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4880 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4881 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4882 where appropriate.
4883 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4884 as boolean expression.
4885 (x_set_window_size): Remove unused variable toolbar.
4886 (ns_get_color_default, ns_mod_to_lisp): Remove.
4887 (ns_mouse_position): Remove unused variables xchar and ychar.
4888 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4889 (ns_set_vertical_scroll_bar): Remove unused variable count.
4890 (ns_delete_terminal): Remove unused variable i.
4891 (ns_term_init): Remove unused variables r, g and b.
4892 (mouseDown): Remove unused variable window.
4893 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4894 (initFrameFromEmacs): Remove unused variable vbextra.
4895 (mouseEntered): Remove unused variables p and dpyinfo.
4896 (mouseExited): Remove unused variables p and r.
4897 (ns_define_frame_cursor, ns_clear_frame_area)
4898 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4899 (menuDown): Assign [sender tag] to variable and cast the variable.
4900
4901 * nsterm.h (menuDown): Add id as type to argument sender.
4902 (ns_display_info_for_name): Add Lisp_Object argument.
4903 (ns_term_init): Add Lisp_Object argument.
4904 (ns_map_event_to_object): Add void argument.
4905 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4906 prototype with arguments and only declare if __OBJC__.
4907 (nxatoms_of_nsselect): Add void argument.
4908 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4909 (ns_alloc_autorelease_pool): Add void argument.
4910 (ns_release_autorelease_pool): Add void* argument.
4911 (ns_get_defaults_value): Add const char* argument.
4912
4913 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4914 (initFromContents): Use SSDATA where appropriate.
4915 (ns_update_menubar): Add braces to ambigous if-else.
4916 (initWithTitle): Put () around assignment in if statement.
4917 (ns_menu_show): Remove unused variables window and keymap.
4918 (update_frame_tool_bar): Remove unused variable selected_p.
4919 (initWithContentRect): Remove unused variable this_cmd_name.
4920
4921 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4922 appropriate.
4923 (setXBMColor): Remove unused variable len.
4924 (setPixmapData): Put () around assignment in loop statement.
4925
4926 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4927 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4928 where appropriate.
4929 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4930 around assignment in loop statement.
4931 (nsfont_open): Remove unused variable i.
4932 (nsfont_open): Remove unused variable len.
4933 (nsfont_draw): Remove unused variable cs.
4934
4935 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4936 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4937 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4938 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4939 (Fns_font_name, Fns_perform_service)
4940 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4941 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4942 (ns_set_name): Remove unused variable view.
4943 (x_set_menu_bar_lines): Remove unused variable olines.
4944 (x_set_tool_bar_lines): Remove unused variable root_window.
4945 (Fns_list_colors): Put () around assignment in while statement.
4946 (Fns_perform_service): Remove unused variable len.
4947 (Fns_display_usable_bounds): Remove unused variable top.
4948 (syms_of_nsfns): Remove unused variable i.
4949
b55b9f85
JD
4950 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4951 memcpy (Bug#11907).
4952
ed9265fc 49532012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4954
4955 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4956 and free it with DestroyExceptionInfo (Bug#11558).
4957
ef099b57
JB
49582012-07-13 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4961 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4962 Set here, not in nt/config.nt.
4963
ea814a5d
EZ
49642012-07-13 Eli Zaretskii <eliz@gnu.org>
4965
4966 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4967 cursor overflow into the last glyph on display line when the right
4968 fringe is off. (Bug#11832)
4969
1a952767
PE
49702012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 * xdisp.c (produce_special_glyphs): Now static.
4973 * dispextern.h (produce_special_glyphs): Remove decl.
4974
983188fd
GM
49752012-07-13 Glenn Morris <rgm@gnu.org>
4976
8d7c7eed 4977 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4978 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4979
983188fd
GM
4980 * s/usg5-4-common.h (USG, USG5):
4981 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4982 * s/sol2-6.h (SOLARIS2):
4983 * s/irix6-5.h (IRIX6_5):
4984 * s/hpux10-20.h (USG, USG5, HPUX):
4985 * s/gnu-linux.h (USG, GNU_LINUX):
4986 * s/freebsd.h (BSD_SYSTEM):
4987 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4988 * s/cygwin.h (CYGWIN):
4989 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4990 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4991
d1e68667 49922012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4993
4994 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4995
6de0e799
GM
49962012-07-13 Glenn Morris <rgm@gnu.org>
4997
739ae010
GM
4998 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4999
dbee5793
GM
5000 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
5001
6de0e799
GM
5002 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
5003 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
5004
b82da769
GM
50052012-07-12 Glenn Morris <rgm@gnu.org>
5006
4fae5a7a 5007 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
5008
5009 * process.c (init_process_emacs): Rename from init_process.
5010 The old name is also the name of a Mach system call.
5011 * lisp.h, emacs.c: Update for this name change.
5012 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
5013 longer needed.
5014
5a979817
EZ
50152012-07-12 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
5018 memmove call that removes glyphs covered by the left truncation
5019 glyph. Improve commentary.
5020 (display_line): Fix display of continuation glyphs on GUI frames
5021 when the right fringe is turned off and variable-size fonts are
5022 used in the window. Move the code that appends a stretch glyph to
5023 produce_special_glyphs, so that it could be used for truncation
5024 and continuation glyphs alike.
5025 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
5026 glyph of a suitably computed width, to align the special glyphs at
5027 the window margin. Code moved from display_line. (Bug#11832)
5028
3e91a053
GM
50292012-07-12 Glenn Morris <rgm@gnu.org>
5030
ba9e4b84
GM
5031 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
5032
5033 * s/gnu-linux.h, s/hpux10-20.h:
5034 Do not unconditionally define HAVE_XRMSETDATABASE.
5035
3e91a053
GM
5036 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
5037
b300b1f4
PE
50382012-07-12 Paul Eggert <eggert@cs.ucla.edu>
5039
5040 Fix typos that broke OS X build.
5041 Reported by Randal L. Schwartz in
5042 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
5043 * nsterm.m (ns_timeout): Add missing local decl.
5044 (ns_get_color): snprintf -> sprintf, to fix typo.
5045
6e777848
GM
50462012-07-12 Glenn Morris <rgm@gnu.org>
5047
3f922c37
GM
5048 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
5049 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
5050 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
5051 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
5052
0ab7b23a
GM
5053 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
5054 Move PTY_OPEN to configure.
5055
6e777848
GM
5056 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5057 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
5058 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
5059
4a7edc24
DA
50602012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
5061
5062 Use empty_unibyte_string where applicable.
5063 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
5064 * lread.c (read1): Likewise.
5065 * xsettings.c (syms_of_xsettings): Likewise.
5066
308aab79
GM
50672012-07-12 Glenn Morris <rgm@gnu.org>
5068
42bd1719
GM
5069 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
5070 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
5071 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
5072 * s/hpux10-20.h (RUN_TIME_REMAP):
5073 * s/bsd-common.h (TABDLY): Move to configure.
5074
5075 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
5076
5077 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
5078
ea0bbd17 5079 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 5080 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
5081
5082 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 5083
308aab79
GM
5084 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
5085 * s/template.h: Move NARROWPROTO to configure.
5086
ee1cf5cf
GM
50872012-07-11 Glenn Morris <rgm@gnu.org>
5088
30fe9bf4
GM
5089 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
5090 unused since 2011-01-17 change to systty.h.
5091
ee1cf5cf
GM
5092 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
5093 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5094 Move HAVE_PTYS and HAVE_SOCKETS to configure.
5095
63e47e07
PE
50962012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
5099
c43fb4c3
GM
51002012-07-11 Glenn Morris <rgm@gnu.org>
5101
5102 * s/darwin.h, s/gnu-linux.h, s/template.h:
5103 Move INTERRUPT_INPUT to configure.
5104
e8df9267
DA
51052012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5106
5107 Minor adjustments to interning code.
5108 * lisp.h (intern, intern_c_string): Redefine as static inline
5109 wrappers for intern_1 and intern_c_string_1, respectively.
5110 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
5111 * lread.c (intern_1, intern_c_string_1, oblookup):
5112 Simplify Vobarray checking.
e8df9267
DA
5113 * font.c (font_intern_prop): Likewise. Adjust comment.
5114 * w32font.c (intern_font_name): Likewise.
5115
34348bd4
AS
51162012-07-11 Andreas Schwab <schwab@linux-m68k.org>
5117
d96a1e0c
AS
5118 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
5119
34348bd4
AS
5120 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
5121 of Fcar/Fcdr if possible.
5122 * font.c (check_otf_features): Likewise.
5123 * fontset.c (Fnew_fontset): Likewise.
5124 * gnutls.c (Fgnutls_boot): Likewise.
5125 * minibuf.c (read_minibuf): Likewise.
5126 * msdos.c (IT_set_frame_parameters): Likewise.
5127 * xmenu.c (Fx_popup_dialog): Likewise.
5128 * w32menu.c (Fx_popup_dialog): Likewise.
5129
c8add24e
GM
51302012-07-11 Glenn Morris <rgm@gnu.org>
5131
4b575b3c
GM
5132 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
5133 since nothing has defined it on these platforms.
5134
09f4e3b0
GM
5135 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
5136 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
5137
172bedef
GM
5138 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5139 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5140 Move CLASH_DETECTION to configure.
5141
249685df
GM
5142 * s/gnu.h: Remove file, which is now empty.
5143
c8add24e
GM
5144 * s/gnu.h, s/gnu-linux.h:
5145 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5146
b41253a3
JW
51472012-07-11 John Wiegley <johnw@newartisans.com>
5148
5149 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
5150 function attribute, so we only use it if it exists in the
5151 compiler.
5152
d923b542
DA
51532012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5154
5155 Avoid call to strlen in fast_c_string_match_ignore_case.
5156 * search.c (fast_c_string_match_ignore_case): Change to use
5157 length argument. Adjust users accordingly.
5158 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
5159
5ebbef1d
PE
51602012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5161
bb352260
PE
5162 Assume mkdir, rmdir.
5163 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
5164 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
5165
57054ddd
PE
5166 Assume rename.
5167 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
5168
b747d3f7
PE
5169 Assume perror.
5170 * s/hpux10-20.h (HAVE_PERROR): Remove.
5171 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
5172 Remove dummy definition, as this problem was obsolete long ago.
5173
5ebbef1d
PE
5174 Assume strerror.
5175 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5176
984e7f30
DA
51772012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5178
5179 Avoid calls to strlen in font processing functions.
5180 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
5181 (font_open_by_name): Change to use length argument.
5182 Adjust users accordingly.
d923b542
DA
5183 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
5184 Adjust prototypes.
5185 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
5186 Change to return ptrdiff_t.
984e7f30
DA
5187 (xfont_list_pattern, xfont_match): Use length returned by
5188 xfont_decode_coding_xlfd.
5189 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
5190
20e94fdd
GM
51912012-07-11 Glenn Morris <rgm@gnu.org>
5192
9d596af3
GM
5193 * s/darwin.h, s/freebsd.h, s/netbsd.h:
5194 Move DONT_REOPEN_PTY to configure.
5195
20e94fdd
GM
5196 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
5197 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5198
e99a530f
PE
51992012-07-10 Paul Eggert <eggert@cs.ucla.edu>
5200
22ffb973
PE
5201 Remove "#define unix" that is no longer needed (Bug#11905).
5202 * s/aix4-2.h (unix): Remove; no longer needed.
5203
e9a9ae03
PE
5204 EMACS_TIME simplification (Bug#11875).
5205 This replaces macros (which typically do not work in GDB)
5206 with functions, typedefs and enums, making the code easier to debug.
5207 The functional style also makes code easier to read and maintain.
5208 * systime.h: Include <sys/time.h> on all hosts, not just if
5209 WINDOWSNT, since 'struct timeval' is needed in general.
5210 (EMACS_TIME): Now a typedef, not a macro.
5211 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
5212 not macros.
5213 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
5214 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5215 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5216 (EMACS_TIME_LE): Now functions, not macros.
5217 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5218 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5219 which are not functions. All uses rewritten to use:
5220 (make_emacs_time): New function.
5221 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5222 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5223 not functions. All uses rewritten to use the following, respectively:
5224 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5225 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5226 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5227 * fileio.c (Fcopy_file):
5228 * xterm.c (XTflash): Get the current time closer to when it's used.
5229 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5230
ffacb126
PE
5231 * bytecode.c (targets): Suppress -Woverride-init warnings.
5232
e99a530f
PE
5233 Simplify by avoiding confusing use of strncpy etc.
5234 * doc.c (Fsnarf_documentation):
5235 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5236 * frame.c (Fmake_terminal_frame):
5237 * gtkutil.c (get_utf8_string):
5238 * lread.c (openp):
5239 * nsmenu.m (ns_update_menubar):
5240 * regex.c (regerror):
5241 Prefer memcpy to strncpy and strncat when either will do.
5242 * fileio.c (Fsubstitute_in_file_name):
5243 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5244 (menu_separator_name_p):
5245 * nsmenu.m (ns_update_menubar):
5246 Prefer memcmp to strncmp when either will do.
5247 * nsterm.m: Include <ftoastr.h>.
5248 (ns_get_color):
5249 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5250 Prefer snprintf to strncpy.
5251 * nsterm.m (ns_term_init):
5252 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5253 * nsterm.m (ns_term_init):
5254 Avoid the need for strncpy, by using build_string or
5255 make_unibyte_string directly. Use dtoastr, not snprintf.
5256 * process.c (Fmake_network_process): Diagnose service names that
5257 are too long, rather than silently truncating them or creating
5258 non-null-terminated names.
5259 (Fnetwork_interface_info): Likewise, for interface names.
5260 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5261 Prefer sprintf to strncat.
5262 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5263 Prefer vsnprintf to vsprintf + strncpy.
5264
c59592b3
GM
52652012-07-10 Glenn Morris <rgm@gnu.org>
5266
5267 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5268 Clarify fallback case.
5269
7d7bbefd
DA
52702012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5271
5272 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5273 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5274 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5275 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5276 where argument type is known to be a Lisp_Cons.
5277
3a4c8000
TT
52782012-07-10 Tom Tromey <tromey@redhat.com>
5279
5280 * bytecode.c (BYTE_CODE_THREADED): New macro.
5281 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5282 (enum byte_code_op): New type.
5283 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5284 (exec_byte_code): Use them. Use token threading when applicable.
5285
2a0213a6
DA
52862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5287
5288 Optimize pure C strings initialization.
5289 * lisp.h (make_pure_string): Fix prototype.
5290 (build_pure_c_string): New function, defined as static inline. This
5291 provides a better opportunity to optimize away calls to strlen when
5292 the function is called with compile-time constant argument.
5293 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5294 argument, adjust users accordingly. Use build_pure_c_string where
5295 appropriate.
5296 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5297 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5298 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5299
cb1caeaf
DA
53002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5301
5302 Avoid calls to strlen in miscellaneous functions.
5303 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5304 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5305 * lread.c (openp): Likewise.
5306
c293e30c
DA
53072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5308
5309 Avoid calls to strlen in path processing functions.
5310 * fileio.c (file_name_as_directory): Add comment. Change to add
5311 srclen argument and return the length of result. Adjust users
5312 accordingly.
5313 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5314 swap 1st and 2nd arguments to obey the common convention.
5315 Adjust users accordingly.
c293e30c
DA
5316 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5317
9e059e3f
GM
53182012-07-10 Glenn Morris <rgm@gnu.org>
5319
d02eb359
GM
5320 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5321 Move PENDING_OUTPUT_COUNT definition to configure.
5322
882cf227
GM
5323 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5324 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5325 * s/gnu.h (DATA_START): Move definitions to configure.
5326
af6e839f
GM
5327 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5328 We include usg5-4-common.h, which defines them both.
5329
40289a12
GM
5330 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5331 O_RDONLY already includes it).
5332
9e059e3f
GM
5333 Stop ns builds setting the EMACSLOADPATH environment variable.
5334 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5335 Now it does not set EMACSLOADPATH, just returns the load-path string.
5336 * nsterm.h: Update accordingly.
5337 * lread.c [HAVE_NS]: Include nsterm.h.
5338 (init_lread) [HAVE_NS]: Use ns_load_path.
5339 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5340
7c4e8ec0
GM
53412012-07-09 Glenn Morris <rgm@gnu.org>
5342
d4f600ff
GM
5343 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5344 since the included bsd-common.h does so.
5345
cbb31951
GM
5346 Stop ns builds setting the EMACSPATH environment variable.
5347 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5348 (ns_init_paths): Do not set EMACSPATH.
5349 * nsterm.h (ns_exec_path): Add it.
5350 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5351 Use ns_exec_path.
5352
7c4e8ec0
GM
5353 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5354
26bccfae
PE
53552012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5356
a0bee46f
PE
5357 * process.c (wait_reading_process_output): 'waitchannels' was unset
5358 when read_kbd || !NILP (wait_for_cell); fix this.
5359
5994c183
PE
5360 Add GCC-style 'const' attribute to functions that can use it.
5361 * character.h (char_resolve_modifier_mask):
5362 * keyboard.h (make_ctrl_char):
5363 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5364 (init_character_once, next_almost_prime, init_fns, init_image)
5365 (flush_pending_output, init_sound):
5366 * mem-limits.h (start_of_data):
5367 * menu.h (finish_menu_items):
5368 Add ATTRIBUTE_CONST.
5369 * emacs.c (DEFINE_DUMMY_FUNCTION):
5370 Declare the dummy function with ATTRIBUTE_CONST.
5371 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5372 Add decls with ATTRIBUTE_CONST.
5373
26bccfae
PE
5374 Minor improvements to make_formatted_string.
5375 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5376 where int is good enough, as vsprintf returns an int.
5377 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5378
a8290ec3
DA
53792012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5380
5381 Use make_formatted_string to avoid double length calculation.
5382 * lisp.h (make_formatted_string): New prototype.
5383 * alloc.c (make_formatted_string): New function.
5384 * buffer.c (Fgenerate_new_buffer_name): Use it.
5385 * dbus.c (syms_of_dbusbind): Likewise.
5386 * editfns.c (Fcurrent_time_zone): Likewise.
5387 * filelock.c (get_boot_time): Likewise.
5388 * frame.c (make_terminal_frame, set_term_frame_name)
5389 (x_report_frame_params): Likewise.
5390 * image.c (gs_load): Likewise.
5391 * minibuf.c (get_minibuffer): Likewise.
5392 * msdos.c (dos_set_window_size): Likewise.
5393 * process.c (make_process): Likewise.
5394 * xdisp.c (ensure_echo_area_buffers): Likewise.
5395 * xsettings.c (apply_xft_settings): Likewise.
5396
d01ba2f1
GM
53972012-07-09 Glenn Morris <rgm@gnu.org>
5398
5399 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5400 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5401 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5402 * nsterm.h (ns_etc_directory): Add it.
5403 * callproc.c [HAVE_NS]: Include nsterm.h.
5404 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5405
f1f924b6
DA
54062012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5407
5408 Move marker debugging code under MARKER_DEBUG.
5409 * marker.c (MARKER_DEBUG): Move marker debugging code under
5410 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5411 for bootstrap with --enable-checking (~3x slowdown reported
5412 by Juanma Barranquero <lekktu@gmail.com>).
5413 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5414
ab531b66
PE
54152012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5418 See <http://bugs.gnu.org/11825#29>.
5419
c4b3bc8a
EZ
54202012-07-08 Eli Zaretskii <eliz@gnu.org>
5421
5422 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5423 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5424 (display_line): Add commentary about displaying truncation glyphs
5425 on GUI frames.
5426 (produce_special_glyphs): Move here from term.c.
5427
5428 * term.c (produce_special_glyphs): Move to xdisp.c.
5429
5430 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5431 section.
c4b3bc8a 5432
b676b881
AS
54332012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5434
f17c5273
AS
5435 * xdisp.c (display_line): Avoid warning about implicit declaration
5436 of FRAME_FONT.
5437
298819b9
AS
5438 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5439
b676b881
AS
5440 * lisp.h: Remove empty conditional.
5441
6045c4fd
PE
54422012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5443
b3350bf9
PE
5444 * lread.c (load_path_check): Now static.
5445
6045c4fd
PE
5446 Fix some minor --with-ns problems found by static checking.
5447 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5448 (x_set_font) [!HAVE_X_WINDOWS]:
5449 * image.c (xpm_load_image) [HAVE_NS]:
5450 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5451 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5452 Remove unused local.
5453 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5454 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5455 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5456 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5457 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5458 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5459 Fix pointer signedness problem.
5460 * xfaces.c (FRAME_X_FONT_TABLE):
5461 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5462
929e7845
GM
54632012-07-07 Glenn Morris <rgm@gnu.org>
5464
5465 * lread.c (load_path_check): New function, split from init_lread.
5466 (init_lread): Reorganize. Motivation:
5467 If EMACSLOADPATH is set, check/warn about that rather than the
5468 defaults, which we are not going to use. Hence we can remove
5469 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5470 Don't warn if site-lisp directories are missing.
5471 If not installed, start from a blank load-path, since
5472 PATH_LOADSEARCH refers to the eventual installation directories.
5473
58dd0aa4
EZ
54742012-07-07 Eli Zaretskii <eliz@gnu.org>
5475
5476 Support truncation and continuation glyphs on GUI frames, when
5477 fringes are disabled. (Bug#11832)
5478 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5479 continuation glyphs even if on GUI frames.
5480 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5481 or both, are absent.
5482 (start_display, move_it_in_display_line_to): Handle the case of a
5483 GUI frame without a fringe to display continuation or truncation
5484 glyphs.
5485 (insert_left_trunc_glyphs): Support GUI frames: make sure
5486 truncation glyphs overwrite enough glyphs from the current line to
5487 have sufficient space in pixels.
5488 (display_line): Support truncation and continuation glyphs on GUI
5489 frames. If some spare pixels are left on the line after inserting
5490 the truncation glyphs, fill that space with a stretch glyph of a
5491 suitably computed width.
5492
5493 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5494 produce_glyphs, to support GUI sessions.
5495
31571fd7
PE
54962012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5497
5a16b9bc
PE
5498 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5499
f3047c75
PE
5500 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5501
31571fd7
PE
5502 Do not require float-time's arg to fit in time_t (Bug#11825).
5503 This works better on hosts where time_t is unsigned, and where
5504 float-time is applied to the (negative) difference between two times.
5505 * editfns.c (decode_time_components): Last arg is now double *,
5506 not int *, and means to store all the result as a double, without
5507 worrying about whether the seconds part fits in time_t.
5508 All callers changed.
5509 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5510 All callers changed.
5511 (Ffloat_time): Do not fail merely because the specified time falls
5512 outside of time_t range.
5513
4516fbef
GM
55142012-07-07 Glenn Morris <rgm@gnu.org>
5515
5516 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5517 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5518 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5519
07adc2c6
JB
55202012-07-07 Juanma Barranquero <lekktu@gmail.com>
5521
5522 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5523 Update dependencies.
5524
5525 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5526
fd573f31
PE
55272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5528
fee5959d
PE
5529 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5530 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5531 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5532 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5533 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5534 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5535
fd573f31
PE
5536 * xfont.c (compare_font_names): Redo to omit the need for casts.
5537
ddadbc0e
AS
55382012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5539
fca8d6b6
AS
5540 * xfns.c (Fx_change_window_property): Doc fix.
5541 * w32fns.c (Fx_change_window_property): Doc fix.
5542
ddadbc0e
AS
5543 * w32fns.c (Fx_window_property): Accept the same arguments as the
5544 X Windows version. Doc fix.
5545 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5546
ed9265fc 55472012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5548 Eli Zaretskii <eliz@gnu.org>
5549
5550 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5551 Windows-specific code from nt/config.nt moved here.
5552 Obsolete settings removed.
5553
216ee680
PE
55542012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5555
5556 * process.c: Avoid unnecessary calls to gettime.
5557 (wait_reading_process_output): Don't get the time of day
5558 when gobbling data immediately and not waiting, as there's no need
5559 for it in that case. This removes a FIXME.
5560
bdd091e4
JD
55612012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5562
5563 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5564 is defined (Bug#11768).
5565
9d44f8ce
DA
55662012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5567
5568 Fix marker debugging code.
5569 * marker.c (byte_char_debug_check): Do not perform the check
5570 if buffer is not multibyte.
090bd7cb
JB
5571 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5572 Call byte_char_debug_check with correct arguments.
9d44f8ce 5573
90fc4786
DA
55742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5575
5576 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5577 * marker.c (byte_char_debug_check, count_markers):
5578 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5579 (byte_debug_flag): Remove.
5580 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5581 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5582
7b7ae965
DA
55832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5584
4e57b342
DA
5585 Avoid code repetition in marker-related functions.
5586 * marker.c (attach_marker): New function.
5587 (Fset_marker, set_marker_restricted, set_marker_both)
5588 (set_marker_restricted_both): Use it.
5589 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5590 Consistently rename charno to charpos.
5591 (marker_position): Add eassert.
5592 (marker_byte_position): Convert to eassert.
5593
55942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5595
5596 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5597 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5598 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5599
657924ff
DA
56002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5601
5602 Introduce fast path for the widely used marker operation.
5603 * alloc.c (build_marker): New function.
5604 * lisp.h (build_marker): New prototype.
5605 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5606 * composite.c (autocmp_chars): Likewise.
5607 * editfns.c (buildmark): Remove.
5608 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5609 (save_restriction_save): Use build_marker.
5610 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5611 * window.c (save_window_save): Likewise.
5612
041a49a6
DA
56132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5614
5615 Do not use Fdelete_overlay in delete_all_overlays
5616 to avoid redundant calls to unchain_overlay.
5617 * buffer.c (drop_overlay): New function.
5618 (delete_all_overlays, Fdelete_overlay): Use it.
5619 * minibuf.c (get_minibuffer): Fix comment.
5620
7dca65a4
PE
56212012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 Port to OpenBSD 5.1 amd64.
5624 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5625 This is needed for OpenBSD, and should be harmless on all BSD systems.
5626 Also, include <sys/sysctl.h>, as it should be available on all
5627 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5628 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5629 use p_pid member, not kp_proc.pid.
5630
8eb876e2
GM
56312012-07-06 Glenn Morris <rgm@gnu.org>
5632
5633 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5634
38182d90
PE
56352012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 More xmalloc and related cleanup.
5638 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5639 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5640 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5641 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5642 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5643 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5644 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5645 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5646 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5647 * xterm.c:
5648 Omit needless casts involving void * pointers and allocation.
5649 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5650 as the former is more robust if P's type is changed.
5651 Prefer xzalloc to xmalloc + memset 0.
5652 Simplify malloc-or-realloc to realloc.
5653 Don't worry about xmalloc returning a null pointer.
5654 Prefer xstrdup to xmalloc + strcpy.
5655 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5656 growing it.
5657 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5658 alloca of a constant.
5659
6dd5a677
EZ
56602012-07-05 Eli Zaretskii <eliz@gnu.org>
5661
5662 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5663 hscroll is larger than the line width. Fixes long and futile
5664 looping inside extend_face_to_end_of_line (on a TTY) producing
5665 glyphs that are not needed and thrown away.
5666
6b312f0f
DA
56672012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5668
5669 * marker.c (set_marker_restricted_both): Simplify by using
5670 clip_to_bounds.
5671
f520ef9b
PE
56722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5675
383b7c95
JD
56762012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5677
5678 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5679 not defined (Bug#11768).
5680 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5681 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5682 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5683 followed by gtk_box_set_homogeneous (Bug#11768).
5684 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5685 (update_theme_scrollbar_width, xg_create_scroll_bar):
5686 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5687 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5688 (is_box_type): New function (Bug#11768).
5689 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5690 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5691 with default display (Bug#11768).
5692
d6e7bf45
EZ
56932012-07-05 Eli Zaretskii <eliz@gnu.org>
5694
5695 * xdisp.c (window_hscroll_limited): New function.
5696 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5697 coordinates when window's hscroll is set to insanely large
5698 values. (Bug#11857)
5699
431391ec
JB
57002012-07-05 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5703 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5704
23f86fce
DA
57052012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5706
5707 Cleanup xmalloc.
5708 * lisp.h (xzalloc): New prototype. Omit needless casts.
5709 * alloc.c (xzalloc): New function. Omit needless casts.
5710 * charset.c: Omit needless casts. Convert all calls to
5711 xmalloc with following memset to xzalloc.
5712 * dispnew.c: Likewise.
5713 * fringe.c: Likewise.
5714 * image.c: Likewise.
5715 * sound.c: Likewise.
5716 * term.c: Likewise.
5717 * w32fns.c: Likewise.
5718 * w32font.c: Likewise.
5719 * w32term.c: Likewise.
5720 * xfaces.c: Likewise.
5721 * xfns.c: Likewise.
5722 * xterm.c: Likewise.
5723 * atimer.c: Omit needless casts.
5724 * buffer.c: Likewise.
5725 * callproc.c: Likewise.
5726 * ccl.c: Likewise.
5727 * coding.c: Likewise.
5728 * composite.c: Likewise.
5729 * doc.c: Likewise.
5730 * doprnt.c: Likewise.
5731 * editfns.c: Likewise.
5732 * emacs.c: Likewise.
5733 * eval.c: Likewise.
5734 * filelock.c: Likewise.
5735 * fns.c: Likewise.
5736 * gtkutil.c: Likewise.
5737 * keyboard.c: Likewise.
5738 * lisp.h: Likewise.
5739 * lread.c: Likewise.
5740 * minibuf.c: Likewise.
5741 * msdos.c: Likewise.
5742 * print.c: Likewise.
5743 * process.c: Likewise.
5744 * region-cache.c: Likewise.
5745 * search.c: Likewise.
5746 * sysdep.c: Likewise.
5747 * termcap.c: Likewise.
5748 * terminal.c: Likewise.
5749 * tparam.c: Likewise.
5750 * w16select.c: Likewise.
5751 * w32.c: Likewise.
5752 * w32reg.c: Likewise.
5753 * w32select.c: Likewise.
5754 * w32uniscribe.c: Likewise.
5755 * widget.c: Likewise.
5756 * xdisp.c: Likewise.
5757 * xmenu.c: Likewise.
5758 * xrdb.c: Likewise.
5759 * xselect.c: Likewise.
5760
0497dc44
PE
57612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5762
5763 * fileio.c (time_error_value): Check the right error number.
5764 Problem reported by Troels Nielsen in
5765 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5766
356e7178
PE
57672012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5768
4e71fd89
PE
5769 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5770 This should be fixed in a better way; see Eli Zaretskii in
5771 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5772 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5773
f0941253
PE
5774 * fileio.c (time_error_value): Rename from special_mtime.
5775 The old name's problems were noted by Eli Zaretskii in
5776 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5777
065c9eb4
PE
5778 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5779 This variable's comment says Emacs needs at least one GDB-visible
5780 symbol of type enum pvec_type, to work around GDB problems.
5781 The symbol's value doesn't matter.
5782
356e7178
PE
5783 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5784 that causes compilation to fail on pre-C99 compilers.
5785
ed9265fc 57862012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5787
5788 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5789 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5790
3884d954
DA
57912012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5792
d209e2fb 5793 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5794 headers for buffer_defaults and buffer_local_symbols.
5795 Reported by Juanma Barranquero <lekktu@gmail.com>.
5796
ee28be33
SM
57972012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5798
5799 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5800 * lisp.h (enum pvec_type): Use fewer bits.
5801 (PSEUDOVECTOR_SIZE_BITS): New constant.
5802 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5803 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5804 change in pvec_type.
5805 (PSEUDOVECTOR_TYPEP): New macro.
5806 (TYPED_PSEUDOVECTORP): Use it.
5807 * fns.c (internal_equal): Adapt code to extract pvectype.
5808 * emacs.c (gdb_pvec_type): Update type.
5809 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5810 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5811 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5812 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5813 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5814 abusing vector->header.next.nbytes.
5815 (live_vector_p): Use PVEC_TYPE.
5816 (mark_object): Adapt code to extract pvectype. Use switch.
5817
c7f2cd7f
PE
58182012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5819
5820 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5821 Tighten new eassert a bit.
5822
8ce70ed2
DA
58232012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5824
5825 Fix compilation with --enable-gcc-warnings and -O1
5826 optimization level.
5827 * doprnt.c (doprnt): Change type of tem to int, initialize
5828 to avoid compiler warning. Add eassert.
5829 * search.c (simple_search): Initialize match_byte to avoid
5830 compiler warning. Add eassert.
5831
dea7f1e5
PE
58322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5833
24a212eb
PE
5834 Avoid weird behavior with large horizontal scrolls.
5835 Without this change, for example, large hscroll values would
5836 mess up Emacs's display on Fedora 15 x86, presumably due to
5837 overflows in int calculations in the display code.
5838 Also, if buffers had long lines, Emacs would freeze.
5839 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5840 (set_window_hscroll): New function, containing the old guts of
5841 Fset_window_hscroll. Return the clipped value.
5842 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5843 This avoids the need to check against PTRDIFF_MAX.
5844
dea7f1e5
PE
5845 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5846
76046526
DA
58472012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5848
5849 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5850
39adff0d
PE
58512012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5852
63807d47
PE
5853 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5854 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5855 since GCC 4.4.6 issues a bogus warning for them.
5856
39adff0d
PE
5857 Fix bugs in file timestamp newness comparisons.
5858 * fileio.c (Ffile_newer_than_file_p):
5859 * lread.c (Fload): Use full timestamp resolution of files,
5860 not just the 1-second resolution, so that files that are only
5861 slightly newer still count as newer.
5862 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5863 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5864
dbeed9a6
PE
58652012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5866
5867 * fileio.c: Improve handling of file time marker. (Bug#11852)
5868 (special_mtime): New function.
5869 (Finsert_file_contents, Fverify_visited_file_modtime):
5870 Use it to set special mtime values consistently.
5871
636334d6
AS
58722012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5873
5874 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5875 marker for non-existing file. (Bug#11852)
5876
e2017fe2
GM
58772012-07-03 Glenn Morris <rgm@gnu.org>
5878
5879 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5880 and did not make it into globals.h).
5881
404dbd37
TT
58822012-07-03 Tom Tromey <tromey@redhat.com>
5883
5884 * window.c (Fset_window_margins, Fset_window_fringes)
5885 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5886 * textprop.c (Fprevious_property_change): No longer static.
5887 * syntax.c (Fsyntax_table_p): No longer static.
5888 * process.c (Fget_process, Fprocess_datagram_address): No longer
5889 static.
5890 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5891 * keyboard.c (Fcommand_execute): No longer static.
5892 Remove EXFUN.
5893 * insdel.c (Fcombine_after_change_execute): No longer static.
5894 * image.c (Finit_image_library): No longer static.
5895 * fileio.c (Fmake_symbolic_link): No longer static.
5896 * eval.c (Ffetch_bytecode): No longer static.
5897 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5898 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5899 No longer static.
404dbd37
TT
5900 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5901 static.
5902 * dired.c (Ffile_attributes): No longer static.
5903 * composite.c (Fcomposition_get_gstring): No longer static.
5904 * callproc.c (Fgetenv_internal): No longer static.
5905
5906 * ccl.h: Remove EXFUNs.
5907 * buffer.h: Remove EXFUNs.
5908 * dispextern.h: Remove EXFUNs.
5909 * intervals.h: Remove EXFUNs.
5910 * fontset.h: Remove EXFUN.
5911 * font.h: Remove EXFUNs.
5912 * dosfns.c (system_process_attributes): Remove EXFUN.
5913 * keymap.h: Remove EXFUNs.
5914 * lisp.h: Remove EXFUNs.
5915 * w32term.h: Remove EXFUNs.
5916 * window.h: Remove EXFUNs.
5917 * xsettings.h: Remove EXFUN.
5918 * xterm.h: Remove EXFUN.
5919
8e4fd1e1
GM
59202012-07-03 Glenn Morris <rgm@gnu.org>
5921
5922 * lisp.h (Frandom): Make it visible to C.
5923 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5924 buffer for invisible buffers. (Bug#1229)
5925
ca95b3eb
DA
59262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5927
5928 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5929 values which aren't power of 2.
14ae4239
BT
5930 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5931 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5932 accordingly.
5933
7555c33f
SM
59342012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5935
5936 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5937
5938 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5939
d12e8f5a
DA
59402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5941
5942 * alloc.c (allocate_vector_block): Remove redundant
5943 calls to mallopt if DOUG_LEA_MALLOC is defined.
5944 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5945 avoid calls to mallopt if zero_vector is returned.
5946
296094c3
DA
59472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5948
5949 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5950 is enabled, avoid dereferencing NULL current_sblock if
5951 running undumped.
5952
36429c89
DA
59532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5954
5955 Cleanup basic buffer management.
5956 * buffer.h (struct buffer): Change layout to use generic vector
5957 marking code. Fix some comments. Change type of 'clip_changed'
5958 to bitfield. Remove unused #ifndef old.
5959 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5960 (GET_OVERLAYS_AT): Fix indentation.
5961 (for_each_per_buffer_object_at): New macro.
5962 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5963 (Fbuffer_local_variables): Use it.
5964 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5965 * alloc.c (allocate_buffer): Adjust to match new layout of
5966 struct buffer. Fix comment.
5967 (mark_overlay): New function.
5968 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5969 Lisp area of struct buffer.
5970 (mark_object): Use it. Adjust marking of misc objects
5971 and related comments.
5972
3b3e4cac
PE
59732012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5974
5975 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5976 wrapper that is not needed because the wrapped code is a no-op (zero
5977 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5978 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5979
cf5c0175
DA
59802012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5981
5982 * alloc.c (mark_buffer): Simplify. Remove prototype.
5983 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5984 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5985 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5986 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5987
ca26824c
GM
59882012-06-30 Glenn Morris <rgm@gnu.org>
5989
2e4c5312
GM
5990 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5991
ca26824c
GM
5992 * epaths.in (PATH_SITELOADSEARCH): New.
5993 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5994 This is rather than relying on --enable-locallisppath elements
5995 having "site-lisp" in their names. (Bug#10208#25, 11658)
5996
0d23c240
EZ
59972012-06-30 Eli Zaretskii <eliz@gnu.org>
5998
c9240d7a
EZ
5999 * w32proc.c (sys_select): Accept and ignore one more argument.
6000
6001 * w32.c (emacs_gnutls_pull): Call select with one more argument.
6002
0d23c240 6003 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 6004 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
6005
6006 * sysdep.c: Don't include dos.h and dosfns.h.
6007
6008 * process.c (sys_select):
6009 * msdos.c (sys_select): Accept one more argument and ignore it.
6010
6011 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
6012 adapt data types and code to that.
6013
6014 * dosfns.c:
6015 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
6016 which clashes with the gnulib function of the same name.
6017
af5a5a98
AS
60182012-06-30 Andreas Schwab <schwab@linux-m68k.org>
6019
c5e4379c
AS
6020 * font.c (font_style_to_value, font_style_symbolic)
6021 (font_prop_validate_style): Add type checks for values in
6022 font_style_table.
6023
af5a5a98
AS
6024 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
6025 argument.
6026 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
6027 uses.
6028
8d38f461
EZ
60292012-06-29 Eli Zaretskii <eliz@gnu.org>
6030
2e5a6631
EZ
6031 * xdisp.c (try_window_id): Undo last change.
6032
8d38f461
EZ
6033 * w32.c (getwd): Adjust commentary about startup_dir.
6034 (init_environment): Always call sys_access, even in non-MSVC
6035 builds. Don't chdir to the directory of the Emacs executable.
6036 This undoes code from 1997 which was justified by the need to
6037 "avoid conflicts when removing and renaming directories". But its
6038 downside was that every relative file name was being interpreted
6039 relative to the directory of the Emacs executable, which can never
6040 be TRT. In particular, it broke sys_access when called with
6041 relative file names.
6042 (sys_access): Map GetLastError to errno.
6043
2af3565e
DA
60442012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6045
6046 * window.h (struct window): Change type of 'fringes_outside_margins'
6047 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 6048 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
6049 Adjust comment.
6050 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
6051 to ptrdiff_t.
6052
c8d3a25c 60532012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 6054
c8d3a25c
GM
6055 * gnutls.c (emacs_gnutls_handshake):
6056 Add QUIT to make the loop interruptible.
57570cd3 6057
c8d3a25c 60582012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 6059
c8d3a25c
GM
6060 * charset.c (init_charset): Make lack of etc/charsets fatal.
6061
3e984ee8
DA
60622012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6063
6064 * editfns.c (region_limit): Fix type mismatch.
6065
ef884f23
DA
60662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6067
6068 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
6069 undefined. Convert from xassert to eassert.
6070 * nsmenu.m: Convert from xassert to eassert.
6071 * nsterm.m: Likewise.
6072
7d7e0027
SM
60732012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
6074
6075 * editfns.c (region_limit): Clip to narrowing (bug#11770).
6076
aa754e6a
PE
60772012-06-28 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 Avoid integer overflow on scroll-left and scroll-right.
6080 * window.c (HSCROLL_MAX): New macro.
6081 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
6082 overflow when requested scroll falls outside ptrdiff_t range.
6083
80b00b08
DA
60842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6085
6086 * window.h (struct window): Change type of 'hscroll',
6087 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
6088 'last_modified' and 'last_overlay_modified' to EMACS_INT.
6089 Adjust users accordingly.
6090 * xdisp.c (try_cursor_movement): Replace type check with eassert.
6091 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
6092 from EMACS_INT to ptrdiff_t.
6093 (make_window): Omit redundant initialization.
6094
62b2bcf6
JB
60952012-06-28 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
6098
45942c7d
DA
60992012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6100
6101 * window.h (struct window): Change type of 'use_time' and
6102 'sequence_number' from Lisp_Object to int.
6103 * frame.c (make_frame): Adjust users accordingly.
6104 * print.c (print_object): Likewise.
6105 * window.c (select_window, Fwindow_use_time, make_parent_window)
6106 (make_window): Likewise.
6107
e509cfa6
DA
61082012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6109
6110 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
6111 enabled with --enable-checking=[all,glyphs] configure option.
6112 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6113 adjust comments accordingly.
6114 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
6115 undefined, adjust comments accordingly.
6116 * image.c: Likewise.
6117 * scroll.c: Likewise.
6118 * w32fns.c: Likewise.
6119 * w32term.c: Likewise.
6120 * xdisp.c: Likewise.
6121 * xfaces.c: Likewise.
6122 * xfns.c: Likewise.
6123 * xterm.c: Likewise.
6124
a54e2c05
DA
61252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6126
6127 Generalize run-time debugging checks.
6128 * dispextern.h (XASSERTS): Remove.
6129 * fontset.c (xassert): Remove.
6130 Convert from xassert to eassert.
6131 * alloc.c: Convert from xassert to eassert.
6132 * bidi.c: Likewise.
6133 * dispnew.c: Likewise.
6134 * fns.c: Likewise.
6135 * fringe.c: Likewise.
6136 * ftfont.c: Likewise.
6137 * gtkutil.c: Likewise.
6138 * image.c: Likewise.
6139 * keyboard.c: Likewise.
6140 * menu.c: Likewise.
6141 * process.c: Likewise.
6142 * scroll.c: Likewise.
6143 * sound.c: Likewise.
6144 * term.c: Likewise.
6145 * w32console.c: Likewise.
6146 * w32fns.c: Likewise.
6147 * w32term.c: Likewise.
6148 * window.c: Likewise.
6149 * xdisp.c: Likewise.
6150 * xfaces.c: Likewise.
6151 * xfns.c: Likewise.
6152 * xselect.c: Likewise.
6153 * xterm.c: Likewise.
6154
1ec4b7b2
SM
61552012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
6156
6157 * fns.c (maybe_resize_hash_table): Output message when growing the
6158 purify-hashtable.
6159
2014308a
DA
61602012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6161
6162 * alloc.c (allocate_string_data): Remove dead code.
6163 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
6164 avoid GCC warning about unused macro.
6165
246155eb
DA
61662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6167
6168 * alloc.c (allocate_string): Omit intervals initialization.
6169 * alloc.c (make_uninit_multibyte_string): Initialize intervals
6170 as in make_pure_string and make_pure_c_string.
6171
43184b7b
DA
61722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6173
d209e2fb 6174 * alloc.c (allocate_string): Fix last change.
43184b7b 6175
3fe6dd74
DA
61762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6177
d209e2fb 6178 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
6179 to memset, add explicit initialization where appropriate.
6180
1ba6038a
GM
61812012-06-27 Glenn Morris <rgm@gnu.org>
6182
6183 * lisp.mk (lisp): Remove paths.elc.
6184
c89926a5
CY
61852012-06-27 Chong Yidong <cyd@gnu.org>
6186
6187 * doc.c (Fsubstitute_command_keys): Fix punctuation.
6188
ed6b3510
JW
61892012-06-26 John Wiegley <johnw@newartisans.com>
6190
1ec4b7b2 6191 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
6192 on Mac OS X Lion: __mod_init_func and __mod_term_func.
6193
ed6b3510
JW
6194 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
6195 when building with Clang.
6196
8edd4a2b
SM
61972012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
6198
6199 * eval.c (Fapply): Allow calling it with a single argument.
6200
f6f62d1b
EZ
62012012-06-26 Eli Zaretskii <eliz@gnu.org>
6202
6203 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
6204 _stricmp and _strnicmp.
6205 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
6206
62efea5e
DA
62072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6208
6209 * alloc.c (allocate_window): Zero out non-Lisp part of newly
6210 allocated window.
6211 (allocate_process): Likewise for new process.
8edd4a2b 6212 (allocate_terminal): Change to use offsetof.
62efea5e
DA
6213 (allocate_frame): Likewise.
6214 * frame.c (make_frame): Omit redundant initialization.
6215 * window.c (make_parent_window): Use memset.
6216 (make_window): Omit redundant initialization.
6217 * process.c (make_process): Omit redundant initialization.
6218 * terminal.c (create_terminal): Likewise.
6219
42997f4d
DA
62202012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6221
6222 * term.c (delete_tty): Remove redundant call to memset.
6223
1130ecfc
DA
62242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6225
6226 * alloc.c: Remove build_string.
6227 * lisp.h: Define build_string as static inline. This provides
6228 a better opportunity to optimize away calls to strlen when the
6229 function is called with compile-time constant argument.
6230 * image.c (imagemagick_error): Convert to build_string.
6231 * w32proc.c (sys_spawnve): Likewise.
6232 * xterm.c (x_term_init): Likewise.
6233
cf38a720
PE
62342012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6235
99027bdd
PE
6236 Use sprintf return value instead of invoking strlen on result.
6237 In the old days this wasn't portable, since some sprintf
6238 implementations returned char *. But they died out years ago and
6239 Emacs already assumes sprintf returns int.
6240 Similarly for float_to_string.
6241 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6242 * ccl.c (ccl_driver):
6243 * character.c (string_escape_byte8):
6244 * data.c (Fnumber_to_string):
6245 * doprnt.c (doprnt):
6246 * print.c (print_object):
6247 * xdisp.c (message_dolog):
6248 * xfns.c (syms_of_xfns):
6249 Use sprintf or float_to_string result to avoid need to call strlen.
6250 * data.c (Fnumber_to_string):
6251 Use make_unibyte_string, since the string must be ASCII.
6252 * lisp.h, print.c (float_to_string): Now returns int length.
6253 * term.c (produce_glyphless_glyph):
6254 Use sprintf result rather than recomputing it.
6255
cf38a720
PE
6256 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6257 * Makefile.in (ALL_CFLAGS):
6258 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6259 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6260
3511c784
DA
62612012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6262
0a08eb21 6263 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6264 strcasecmp if available.
6265 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6266
fb7da12e
AS
62672012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6268
6269 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6270 Avoid comma operator.
6271 * menu.c (push_submenu_start, push_submenu_end)
6272 (push_left_right_boundary, push_menu_pane): Likewise.
6273 * msdos.c (dos_rawgetc): Likewise.
6274
afa2ffd8
DA
62752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6276
6277 * xfns.c (xic_create_fontsetname): Remove redundant calls
6278 to memset.
6279
b3b4476b
PE
62802012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6281
4495ff38
PE
6282 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6283 sprintf already null-terminates its output.
6284
b3b4476b
PE
6285 * xfns.c (x_window): Remove redundant cast.
6286
b00876c9
DA
62872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6288
6289 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6290 `const char *' to `char *' to avoid compiler warning.
6291
d188e26b
PE
62922012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6293
885d1d74
PE
6294 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6295 instead of truncating it to 63 (admittedly a generous limit).
6296
d188e26b
PE
6297 * process.c: Fix spelling and caps in comments.
6298
e2f560b1
DN
62992012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6300
e86db54b 6301 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6302 * sysdep.c (setpgrp): Remove definition, not used in this file.
6303
7583a3a1
JB
63042012-06-24 Juanma Barranquero <lekktu@gmail.com>
6305
6306 * makefile.w32-in: Update dependencies.
6307
696056c2
EZ
63082012-06-24 Eli Zaretskii <eliz@gnu.org>
6309
6310 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6311 (SYSTIME_H): Add nt/inc/sys/time.h.
6312
6313 * systime.h [WINDOWSNT]: Include sys/time.h.
6314
6315 * s/ms-w32.h (struct timespec): Definition moved from
6316 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6317
845ca893
PE
63182012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6319
6320 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6321 * buffer.h (buffer_slot_type_mismatch):
6322 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6323 * eval.c (unwind_to_catch):
6324 * image.c (my_png_error, my_error_exit):
6325 * keyboard.c (quit_throw_to_read_char, user_error)
6326 (Fexit_recursive_edit, Fabort_recursive_edit):
6327 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6328 (wrong_type_argument, buffer_overflow, __executable_start)
6329 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6330 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6331 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6332 (fatal):
6333 (child_setup) [!DOS_NT]:
6334 * lread.c (end_of_file_error, invalid_syntax):
6335 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6336 * puresize.h (pure_write_error):
6337 * search.c (matcher_overflow):
6338 * sound.c (sound_perror, alsa_sound_perror):
6339 * sysdep.c, syssignal.h (croak):
6340 * term.c (maybe_fatal, vfatal):
6341 * textprop.c (text_read_only):
6342 * undo.c (user_error):
6343 * unexmacosx.c (unexec_error):
6344 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6345 Use _Noreturn rather than NO_RETURN.
6346 No need for separate decl merely because of _Noreturn.
6347 * sound.c (sound_warning, parse_sound):
6348 Remove unnecessary forward decls.
6349
f1dd8073
PE
63502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6353 * lisp.h (WAIT_READING_MAX): New macro.
6354 * dispnew.c (Fsleep_for, sit_for):
6355 * keyboard.c (kbd_buffer_get_event):
6356 * process.c (Faccept_process_output):
6357 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6358 This improves on the previous patch, which introduced a bug
6359 when time_t is unsigned and as wide as intmax_t.
6360 See <http://bugs.gnu.org/9000#51>.
6361
b82c1755
EZ
63622012-06-23 Eli Zaretskii <eliz@gnu.org>
6363
6364 * dispnew.c (sit_for, Fsleep_for):
6365 * keyboard.c (kbd_buffer_get_event):
6366 * process.c (Faccept_process_output): Avoid compiler warnings when
6367 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6368
ca300656
JB
63692012-06-23 Juanma Barranquero <lekktu@gmail.com>
6370
049ec95b
JB
6371 * makefile.w32-in: Update dependencies.
6372
ca300656
JB
6373 * w32.c (ltime): Add return type and declare static.
6374 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6375
db7b8d06
PE
63762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6379 Privately reported by Herbert J. Skuhra.
6380 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6381 All uses changed.
6382 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6383 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6384
0bd8297f
EZ
63852012-06-23 Eli Zaretskii <eliz@gnu.org>
6386
96512555
EZ
6387 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6388 last argument of make_unibyte_string.
6389
0bd8297f
EZ
6390 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6391 language ID in the event parameters.
6392
6393 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6394 event.code, not the obscure "character set ID".
6395
63def6b6
CY
63962012-06-23 Chong Yidong <cyd@gnu.org>
6397
6398 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6399
e8a02204
EZ
64002012-06-23 Eli Zaretskii <eliz@gnu.org>
6401
388cdec0
EZ
6402 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6403 * w32.c (fdutimens): New function.
6404
6405 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6406
6407 * s/ms-w32.h (pselect): Redirect to sys_select.
6408
6409 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6410
e8a02204
EZ
6411 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6412 in the logic of incrementing and decrementing the value of
6413 use_relocatable_buffers.
6414
d054f3fb
PE
64152012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6416
6417 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6418 Privately reported by Herbert J. Skuhra.
6419 [__FreeBSD__]: Remove "*/" typo after "#include".
6420 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6421 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6422 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6423 Don't assume EMACS_TIME and struct timeval are the same type.
6424
d35af63c
PE
64252012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6426
6427 Support higher-resolution time stamps (Bug#9000).
6428 The time stamps are only nanosecond-resolution at the C level,
6429 since that's the best that any real-world system supports now.
6430 But they are picosecond-resolution at the Lisp level, as that's
6431 easy, and leaves room for future OS improvements.
6432
6433 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6434 (LIBES): Use it.
6435
6436 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6437 Don't get current time unless it's needed.
6438
6439 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6440 now provides it if it's absent.
6441 (start_atimer): Port to higher-res time stamps.
6442 Check for time stamp overflow. Don't get current time more
6443 often than is needed.
6444
6445 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6446 Include systime.h, not time.h.
6447 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6448
6449 * dired.c: Include stat-time.h.
6450 (Ffile-attributes): File times now have higher resolution.
6451
6452 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6453 (struct image): Timestamp now has higher resolution.
6454
6455 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6456 has at least microseconds now. All uses removed.
6457 (update_frame, update_single_window, update_window, update_frame_1)
6458 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6459 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6460
6461 * editfns.c (time_overflow): Now extern.
6462 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6463 (float-time, Fformat_time_string, Fcurrent_time_string)
6464 (Fcurrent_time_zone): Accept and generate higher-resolution
6465 time stamps.
6466 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6467 (decode_time_components, lisp_seconds_argument): New functions.
6468 (make_time): Now static.
6469 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6470 Report an error if the time is invalid, rather than having the caller
6471 do that.
6472
6473 * fileio.c: Include <stat-time.h>
6474 (Fcopy_file): Copy higher-resolution time stamps.
6475 Prefer to set the time stamp via a file descriptor if that works.
6476 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6477 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6478 (Fvisited_file_modtime, Fset_visited_file_modtime):
6479 Support higher-resolution time stamps.
6480
6481 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6482
6483 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6484
6485 * image.c (prepare_image_for_display, clear_image_cache)
6486 (lookup_image): Port to higer-resolution time stamps.
6487
6488 * keyboard.c (start_polling, bind_polling_period):
6489 Check for time stamp overflow.
6490 (read_char, kbd_buffer_get_event, timer_start_idle)
6491 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6492 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6493 Port to higher-resolution time stamps. Do not assume time_t is signed.
6494 (decode_timer): New function. Timers are now vectors of length 9,
6495 not 8, to accommodate the picosecond component.
6496 (timer_check_2): Use it.
6497
6498 * nsterm.m (select_timeout, timeval_subtract): Remove.
6499 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6500 as they're a bit more accurate and handle overflow better.
6501 (ns_select): Change prototype to be compatible with pselect.
6502 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6503 * nsterm.h (ns_select): Adjust prototype.
6504
6505 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6506 us-resolution time stamps.
6507 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6508
6509 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6510
6511 * lisp.h (time_overflow): New decl.
6512 (wait_reading_process_output): First arg is now intmax_t, not int,
6513 to accommodate larger waits.
6514
6515 * process.h (struct Lisp_Process.read_output_delay):
6516 Now counts nanoseconds, not microseconds.
6517 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6518 EMACS_HAS_USECS.
6519 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6520 (wait_reading_process_output):
6521 Port to ns-resolution time stamps.
6522 (Faccept_process_output, wait_reading_process_output):
6523 Check for time stamp overflow. Do not assume time_t is signed.
6524 (select_wrapper): Remove; we now use pselect.
6525 (Fprocess_attributes): Now generates ns-resolution time stamps.
6526
6527 * sysdep.c: Include utimens.h. Don't include utime.h
6528 or worry about struct utimbuf; gnulib does that for us now.
6529 (gettimeofday): Remove; gnulib provides a substitute.
6530 (make_timeval): New function.
6531 (set_file_times): Now sets ns-resolution time stamps.
6532 New arg FD; all uses changed.
6533 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6534 (system_process_attributes):
6535 Now returns ns-resolution time stamp. All uses changed.
6536 Check for time stamp overflow.
6537
6538 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6539 provides a substitute now.
6540
6541 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6542 since it guarantees struct timespec.
6543 (EMACS_TIME): Now struct timespec, so that we can support
6544 ns-resolution time stamps.
6545 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6546 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6547 (EMACS_USECS): Remove.
6548 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6549 so multiply the arg by 1000 before storing it.
6550 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6551 New macros.
6552 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6553 Port to ns-resolution time stamps.
6554 (EMACS_TIME_NEG_P): Remove; replaced by....
6555 (EMACS_TIME_SIGN): New macro.
6556 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6557 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6558 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6559 (make_timeval, make_lisp_time, decode_time_components): New decls.
6560 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6561 that it mishandled time_t overflow. You can't compare by subtracting!
6562 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6563 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6564
6565 * term.c: Include <sys/time.h>.
6566 (timeval_to_Time): New function, for proper overflow wraparound.
6567 (term_mouse_position, term_mouse_click): Use it.
6568
6569 * undo.c (record_first_change): Support higher-resolution time stamps
6570 in the undo buffer.
6571 (Fprimitive_undo): Use them when restoring time stamps.
6572
6573 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6574 (w32_get_internal_run_time):
6575 Port to higher-resolution Emacs time stamps.
6576 (ltime): Now accepts single 64-bit integer, as that's more convenient
6577 for callers.
6578
6579 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6580
6581 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6582 for compatibility with pselect. Support ns-resolution time stamps.
6583
6584 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6585
6586 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6587 Check for time stamp overflow, and support ns-resolution time stamps.
6588
6589 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6590 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6591 (timeval_subtract): Remove; no longer needed.
6592 (XTflash, XTring_bell, x_wait_for_event):
6593 Port to ns-resolution time stamps. Don't assume time_t is signed.
6594
b6a92dfe
CY
65952012-06-22 Chong Yidong <cyd@gnu.org>
6596
6597 * xdisp.c (x_consider_frame_title): Revert last change.
6598
d251c37c
EZ
65992012-06-22 Eli Zaretskii <eliz@gnu.org>
6600
6601 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6602 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6603 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6604 staticidx goes up to 1597 out of 1600 = 0x640.)
6605
f10deafb
PE
66062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6607
6608 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6609 Otherwise, the umask might be mistakenly 0 while handling input signals.
6610
ec6de1e2
SM
66112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6612
6613 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6614
28be1ada
DA
66152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6616
6617 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6618 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6619 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6620 access to `contents' member of Lisp_Vector objects with AREF and ASET
6621 where appropriate.
6622
c6bf3022
CY
66232012-06-19 Chong Yidong <cyd@gnu.org>
6624
6625 * frame.c (delete_frame): When selecting a frame on a different
6626 text terminal, do not alter the terminal's top-frame.
6627
6628 * xdisp.c (format_mode_line_unwind_data): Record the target
6629 frame's selected window and its terminal's top-frame.
6630 (unwind_format_mode_line): Restore them.
6631 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6632 Callers changed.
6633 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6634 since tty frames can be explicitly named.
6635 (prepare_menu_bars): Likewise.
6636
6637 * term.c (Ftty_top_frame): New function.
6638
defd4196
PE
66392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6640
6641 Port byte-code-meter to modern targets.
6642 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6643 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6644 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6645 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6646 (METER_1, METER_2): Simplify.
6647
1053a871
SM
66482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6649
6650 * data.c (Fdefalias): Return `symbol' (bug#11686).
6651
b7e8d081
MR
66522012-06-18 Martin Rudalics <rudalics@gmx.at>
6653
6654 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6655 gets killed during executing of this function (Bug#11665).
6656 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6657 (Vkill_buffer_query_functions): In doc-string say that functions
6658 run by this hook should not change the current buffer.
6659
7ea2b339
PE
66602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6661
6662 Fix recently-introduced process.c problems found by static checking.
6663 * process.c (write_queue_push, write_queue_pop, send_process):
6664 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6665 (write_queue_pop): Fix pointer signedness problem.
6666 (send_process): Remove unused local.
6667
96a313a1
CY
66682012-06-17 Chong Yidong <cyd@gnu.org>
6669
6670 * xdisp.c (redisplay_internal): No need to redisplay terminal
6671 frames that are not on top.
6672
20ca2e94
TN
66732012-06-17 Troels Nielsen <bn.troels@gmail.com>
6674
6675 * process.c (make_process): Initialize write_queue.
6676 (write_queue_push, write_queue_pop): New functions.
6677 (send_process): Use them to maintain correct ordering of process
6678 writes (Bug#10815).
6679
9a900ca9
PE
66802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6681
310fbfa8
PE
6682 * lisp.h (eassert): Assume C89 or later.
6683 This removes the need for CHECK.
6684 (CHECK): Remove. Its comments about always evaluating its
6685 argument were confusing, as 'eassert' typically does not evaluate
6686 its argument.
6687
27bb1ca4
PE
6688 * coding.c (produce_chars): Use ptrdiff_t, not int.
6689
9a900ca9
PE
6690 * xterm.c (x_draw_underwave): Check for integer overflow.
6691 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6692
41b7f8bc 66932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6694
6695 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6696 referenced (Bug#11583).
6697
9b0e3eba
AA
66982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6699
6700 Implement wave-style variant of underlining.
6701 * dispextern.h (face_underline_type): New enum.
6702 (face): Add field for underline type.
6703 * nsterm.m (ns_draw_underwave): New function.
6704 (ns_draw_text_decoration): Use it.
6705 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6706 New functions.
6707 (x_draw_glyph_string): Use them.
6708 * xfaces.c (Qline, Qwave): New Lisp objects.
6709 (check_lface_attrs, merge_face_ref)
1053a871
SM
6710 (Finternal_set_lisp_face_attribute, realize_x_face):
6711 Handle wave-style underline face attributes.
9b0e3eba
AA
6712 * xterm.c (x_draw_underwave): New function.
6713 (x_draw_glyph_string): Use it.
6714
0fb52f11
JB
67152012-06-16 Juanma Barranquero <lekktu@gmail.com>
6716
6717 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6718 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6719 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6720 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6721 ($(BLD)/w32select.$(O)): Update dependencies.
6722
e5560ff7
AS
67232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6724
6725 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6726 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6727 * character.c (_fetch_multibyte_char_p): Remove.
6728 * alloc.c: Include "character.h" before "buffer.h".
6729 * bidi.c: Likewise.
6730 * buffer.c: Likewise.
6731 * bytecode.c: Likewise.
6732 * callint.c: Likewise.
6733 * callproc.c: Likewise.
6734 * casefiddle.c: Likewise.
6735 * casetab.c: Likewise.
6736 * category.c: Likewise.
6737 * cmds.c: Likewise.
6738 * coding.c: Likewise.
6739 * composite.c: Likewise.
6740 * dired.c: Likewise.
6741 * dispnew.c: Likewise.
6742 * doc.c: Likewise.
6743 * dosfns.c: Likewise.
6744 * editfns.c: Likewise.
6745 * emacs.c: Likewise.
6746 * fileio.c: Likewise.
6747 * filelock.c: Likewise.
6748 * font.c: Likewise.
6749 * fontset.c: Likewise.
6750 * fringe.c: Likewise.
6751 * indent.c: Likewise.
6752 * insdel.c: Likewise.
6753 * intervals.c: Likewise.
6754 * keyboard.c: Likewise.
6755 * keymap.c: Likewise.
6756 * lread.c: Likewise.
6757 * macros.c: Likewise.
6758 * marker.c: Likewise.
6759 * minibuf.c: Likewise.
6760 * nsfns.m: Likewise.
6761 * nsmenu.m: Likewise.
6762 * print.c: Likewise.
6763 * process.c: Likewise.
6764 * regex.c: Likewise.
6765 * region-cache.c: Likewise.
6766 * search.c: Likewise.
6767 * syntax.c: Likewise.
6768 * term.c: Likewise.
6769 * textprop.c: Likewise.
6770 * undo.c: Likewise.
6771 * unexsol.c: Likewise.
6772 * w16select.c: Likewise.
6773 * w32fns.c: Likewise.
6774 * w32menu.c: Likewise.
6775 * window.c: Likewise.
6776 * xdisp.c: Likewise.
6777 * xfns.c: Likewise.
6778 * xmenu.c: Likewise.
6779 * xml.c: Likewise.
6780 * xselect.c: Likewise.
6781
2f07e6af
EZ
67822012-06-16 Eli Zaretskii <eliz@gnu.org>
6783
1053a871
SM
6784 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6785 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6786 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6787 row.
6788 (handle_face_prop): Use chunk-relative overlay string index when
6789 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6790 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6791 the rightmost. (Bug#11720)
2f07e6af 6792
29b83cec
AS
67932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6794
6795 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6796 (CATEGORY_MEMBER): Enforce 1/0 value.
6797 * category.c (_temp_category_set): Remove.
6798
4c5501e9
EZ
67992012-06-16 Eli Zaretskii <eliz@gnu.org>
6800
6801 * window.c (Fdelete_other_windows_internal)
6802 (Fdelete_window_internal): Don't access frame's mouse highlight
6803 info of the initial frame. (Bug#11677)
6804
2b570124
PE
68052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6806
e93864f9
PE
6807 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6808 Assume USE_2_TAGS_FOR_INTS.
6809 (xreload): Adjust $tagmask width to match recent lisp.h change.
6810
2b570124
PE
6811 Simplify lisp.h in minor ways that should not affect code.
6812 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6813 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6814 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6815 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6816 (INTTYPEBITS): New macro, for clarity.
6817 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6818 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6819 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6820 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6821 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6822
81755f69
JB
68232012-06-13 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6826
16192a57
GM
68272012-06-13 Glenn Morris <rgm@gnu.org>
6828
6829 * s/bsd-common.h (BSD4_3):
6830 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6831
646b5f55
AS
68322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6833
6834 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6835 instead of union.
6836 (XLI, XIL): Define.
1053a871
SM
6837 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6838 Use them.
6839 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6840 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6841 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6842 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6843 * frame.c (delete_frame): Remove outdated comment.
6844 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6845 USE_LISP_UNION_TYPE.
6846 (Fw32_unregister_hot_key): Likewise.
6847 (Fw32_toggle_lock_key): Likewise.
6848 * w32menu.c (add_menu_item): Likewise.
6849 (w32_menu_display_help): Use XIL instead of checking
6850 USE_LISP_UNION_TYPE.
6851 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6852 (init_heap): Likewise.
6853 * w32term.c (w32_read_socket): Update comment.
6854
1d3823c9
GM
68552012-06-13 Glenn Morris <rgm@gnu.org>
6856
c62ff706
GM
6857 * s/usg5-4-common.h, src/s/unixware.h:
6858 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6859
1d3823c9
GM
6860 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6861
bfe3e0a2
PE
68622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6865 * alloc.c (make_number) [!defined make_number]:
6866 Remove, as lisp.h always defines this now.
6867 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6868 (roundup_size): Verify that it is a power of 2.
6869 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6870 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6871 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6872 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6873 USE_LSB_TAG now is always defined to be either 0 or 1.
6874 All uses changed.
6875 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6876 code works fine either way, and efficiency is not a concern here,
6877 as the union type is for debugging, not for production.
6878 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6879 Use an inline function on all platforms when using the union type,
6880 since this is simpler and 'static inline' can be used portably
6881 within Emacs now.
6882 (LISP_INITIALLY_ZERO): New macro.
6883 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6884 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6885
45fa9c0f
GM
68862012-06-12 Glenn Morris <rgm@gnu.org>
6887
b4492cba
GM
6888 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6889
6890 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6891
45fa9c0f
GM
6892 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6893 Move BROKEN_SIGIO to configure.
6894
6895 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6896 Move NO_TERMIO to configure.
6897
0e25d334
CY
68982012-06-12 Chong Yidong <cyd@gnu.org>
6899
6900 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6901 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6902 MagickExportImagePixels is undefined.
6903
43682bb6
PE
69042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 * image.c (imagemagick_load_image): Remove unused label.
6907
a9be7d2b
GM
69082012-06-11 Glenn Morris <rgm@gnu.org>
6909
6910 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6911 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6912 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6913 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6914
3017f87f
SM
69152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * alloc.c (make_byte_code): New function.
6918 (Fmake_byte_code): Use it. Don't purify here.
6919 * lread.c (read1): Use it as well to avoid extra allocation.
6920
1b9b4cf4
CY
69212012-06-11 Chong Yidong <cyd@gnu.org>
6922
6923 * image.c (imagemagick_load_image): Implement transparency.
6924
95988fcf
AS
69252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6926
6927 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6928 account for preceding backslashes. (Bug#11663)
6929
cd4eb164
CY
69302012-06-09 Chong Yidong <cyd@gnu.org>
6931
6932 * term.c: Support italics in capable terminals (Bug#9652).
6933 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6934 (turn_on_face): Output using TS_enter_italic_mode if available.
6935 Don't handle unused blinking and alt-charset cases.
6936 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6937 and tty_alt_charset_p cases.
6938 (tty_capable_p, init_tty): Support italics.
6939
6940 * termchar.h (struct tty_display_info): Add field for italics.
6941 Remove unused blink field.
6942
6943 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6944 Handle slant.
6945
6946 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6947 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6948 tty_alt_charset_p. Add tty_italic_p.
6949
ff88beb8
MA
69502012-06-09 Michael Albinus <michael.albinus@gmx.de>
6951
6952 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6953 dbus_type_is_basic if available.
6954 (xd_extract_signed, xd_extract_unsigned): Rename from
6955 extract_signed and extract_unsigned, respectively. Adapt callers.
6956
44286096
CY
69572012-06-09 Chong Yidong <cyd@gnu.org>
6958
1682701f
CY
6959 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6960
44286096
CY
6961 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6962 case (Bug#9752).
6963
d86feb17
PE
69642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6965
6966 * xdisp.c (vmessage): Treat frame message as multibyte.
6967 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6968 would generate the diagnostic "Making \302\247 buffer-local while
6969 let-bound!".
6970
d5c20fe8
EZ
69712012-06-08 Eli Zaretskii <eliz@gnu.org>
6972
6973 * dispnew.c (showing_window_margins_p): Undo last change, which
6974 was done due to an inadvertent commit.
6975 (adjust_frame_glyphs_for_frame_redisplay): Do call
6976 showing_window_margins_p.
6977
513749ee
SM
69782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6979
6980 * eval.c (Fmake_var_non_special): New primitive.
6981 (syms_of_eval): Defsubr it.
6982 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6983
d4a8f5c1
JB
69842012-06-08 Juanma Barranquero <lekktu@gmail.com>
6985
6986 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6987 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6988
8bbbc977
EZ
69892012-06-08 Eli Zaretskii <eliz@gnu.org>
6990
6991 * alloc.c (allocate_vectorlike): Fix last change.
6992
f3372c87
DA
69932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6994
6995 Block-based vector allocation of small vectors.
6996 * lisp.h (struct vectorlike_header): New field `nbytes',
6997 adjust comment accordingly.
6998 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6999 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
7000 mark_maybe_pointer, valid_lisp_object_p) accordingly.
7001 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
7002 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
7003 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
7004 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
7005 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
7006 (roundup_size): New constant.
7007 (struct vector_block): New data type.
7008 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 7009 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
7010 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
7011 (sweep_vectors): New functions.
7012 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 7013 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
7014 or equal to VBLOCK_BYTES_MAX.
7015 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
7016 (init_alloc_once): Add call to init_vectors.
7017
4f18a4ed
SM
70182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7019
7020 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
7021
86f158bc
PE
70222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
7023
7024 * doprnt.c (doprnt): Truncate multibyte char correctly.
7025 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
7026 would mishandle a string argument "Xc" if X was a multibyte
7027 character of length 2: it would truncate after X's first byte
7028 rather than including all of X.
7029
c5cfcbe0
CY
70302012-06-06 Chong Yidong <cyd@gnu.org>
7031
7032 * buffer.c (word_wrap): Doc fix.
7033
c05cf390
PE
70342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
7035
7036 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
7037
0c3461de
GM
70382012-06-03 Glenn Morris <rgm@gnu.org>
7039
7040 * xdisp.c (tool-bar-style): Doc fix.
7041
c71232db
UM
70422012-06-03 Ulrich Müller <ulm@gentoo.org>
7043
7044 * Makefile.in (PAXCTL): Define.
7045 (temacs$(EXEEXT)): Disable memory randomization for the temacs
7046 binary via PaX flags if the paxctl utility is available.
7047 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7048 Restore PaX flags to their default. (Bug#11398)
7049
383f7350
CY
70502012-06-03 Chong Yidong <cyd@gnu.org>
7051
7052 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
7053 buffer (Bug#11226).
7054
5f2c76c6
CY
70552012-06-03 Chong Yidong <cyd@gnu.org>
7056
7057 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
7058 (note_mode_line_or_margin_highlight): If there is no help echo,
7059 use mode-line-default-help-echo. Handle the case where the mouse
7060 position is past the end of the mode line string.
7061
7062 * buffer.c (buffer_local_value_1): New function, split from
7063 Fbuffer_local_value; can return Qunbound.
7064 (Fbuffer_local_value): Use it.
7065 (Vmode_line_format): Docstring tweaks.
7066
773d47f6
PE
70672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7068
7069 * sysdep.c (system_process_attributes): Improve comment.
7070
f2d6a3df
SM
70712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
7072
7073 * keyboard.c: Export real-this-command to Elisp.
7074 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
7075 and DEFVAR it. Update all users.
7076
63810350
PE
70772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7078
7bd5c1f4
PE
7079 * minibuf.c (Fassoc_string): Remove duplicate declaration.
7080
63810350
PE
7081 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
7082 Convert pctcpu and pctmem to Lisp float properly.
7083 Let the compiler fold better, as 100.0/0x8000 is exact.
7084
a2821611
AS
70852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
7086
7087 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
7088 cons_block.
7089
5fceba1d
PE
70902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
7091
7092 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
7093
c98ff5dd
DA
70942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
7095
7096 For a 'struct window', replace some Lisp_Object fields to
7097 bitfields where appropriate, remove unused fields.
7098 * window.h (struct window): Remove unused 'last_mark_x' and
7099 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
7100 change it's type from Lisp_Object to bitfield.
7101 Change type of 'force_start', 'optional_new_start',
7102 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 7103 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 7104
ca34e0be
PE
71052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7106
7107 Pacify gcc -Wdouble-precision when using Xaw.
7108 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
7109 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
7110 Use 'float' consistently, rather than 'float' in most places
7111 and 'double' in a couple of places.
7112
efc00ab1 71132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
7114
7115 * xdisp.c (handle_stop): Detect whether we have overlay strings
7116 loaded by testing it->current.overlay_string_index to be
7117 non-negative, instead of checking whether n_overlay_strings is
7118 positive. (Bug#11587)
7119
efc00ab1 71202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
7121
7122 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
7123
7124 * doc.c (Fsubstitute_command_keys): Doc fix.
7125
efc00ab1 71262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
7127
7128 * search.c (search_buffer): Remove calls to
7129 r_alloc_inhibit_buffer_relocation, as it is now called by
7130 maybe_unify_char, which was the cause of relocation of buffer text
7131 in bug#11519.
7132
efc00ab1 71332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
7134
7135 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
7136 for the duration of call to load_charset, to avoid problems with
7137 callers of maybe_unify_char that access buffer text through C
7138 pointers.
7139
7140 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
7141 decrement the inhibition flag, instead of just setting or
7142 resetting it.
7143
ba93a187
PE
71442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7145
7146 Remove obsolete '#define static' cruft.
7147 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
7148 This #undef was "temporary" in 2000; it is no longer needed
7149 now that '#define static' has gone away.
7150 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
7151 (gray_bitmap_bits): Remove; no longer needed.
7152 All uses replaced with definiens.
7153 * xterm.c: Include "bitmaps/gray.xbm".
7154
9e4bf381
PE
71552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7156
7157 Clean up __executable_start, monstartup when --enable-profiling.
7158 The following changes affect the code only when profiling.
7159 * dispnew.c (__executable_start): Rename from safe_bcopy.
7160 Define only on platforms that need it.
7161 * emacs.c: Include <sys/gmon.h> when profiling.
7162 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
7163 (__executable_start): Remove decl, since lisp.h does it now.
7164 (safe_bcopy): Remove decl; no longer has that name.
7165 (main): Coalesce #if into single bit of code, for simplicity.
7166 Cast pointers to uintptr_t, since standard libraries want integers
7167 and not pointers.
7168 * lisp.h (__executable_start): New decl.
7169
32d72c2f
GM
71702012-05-31 Glenn Morris <rgm@gnu.org>
7171
7172 * image.c (Fimagemagick_types): Doc fix.
7173
baac5bc7
JM
71742012-05-30 Jim Meyering <meyering@redhat.com>
7175
7176 * callproc.c (Fcall_process_region): Include directory component
7177 in mkstemp error message (Bug#11586).
7178
72cb32cf
PE
71792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 * alloc.c, lisp.h (make_pure_vector): Now static.
7182
61b108cc
SM
71832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
7184
7185 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
7186 Move to byte-run.el.
7187 (Fautoload): Do the hash-doc more carefully.
7188 * data.c (Fdefalias): Purify definition, except for keymaps.
7189 (Qdefun): Move from eval.c.
7190 * lisp.h (Qdefun): Remove.
7191 * lread.c (read1): Tiny simplification.
7192
471fe23d
TN
71932012-05-29 Troels Nielsen <bn.troels@gmail.com>
7194
934f3f58 7195 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
7196 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
7197 Bug#9642, but explicitly check that the buffer the overlay would
7198 be moved to is live and rearrange lines to make sure that errors
7199 will not put the overlay in an inconsistent state.
7200 (Fdelete_overlay): Cosmetics.
7201
85d0efd1
EZ
72022012-05-28 Eli Zaretskii <eliz@gnu.org>
7203
7204 * w32term.c (my_bring_window_to_top): New function.
7205 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
7206 could be different from the original one.
7207 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
7208 (Bug#11513)
7209
7210 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
7211 by calling BringWindowToTop.
7212
7213 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
7214 (WM_EMACS_END): Increase by one.
7215
da92a98c
PE
72162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7217
7218 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7219 This avoids undefined behavior that might cause the eassert
7220 to not catch an out-of-range value.
7221
74d1f848
JB
72222012-05-28 Juanma Barranquero <lekktu@gmail.com>
7223
7224 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7225 Update dependencies.
7226
9e1a06fc
EZ
72272012-05-27 Eli Zaretskii <eliz@gnu.org>
7228
7229 * bidi.c (bidi_mirror_char): Fix last change.
7230
f3dd7312
AS
72312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7232
7233 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7234 when referring to sectname field in printf format.
7235
81899c91
PE
72362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7237
57b81a9f
PE
7238 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7239 Only r_alloc_inhibit_buffer_relocation needed to be added;
7240 the others were already declared.
7241
81899c91
PE
7242 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7243 before checking whether it's out of range. Put the check inside
7244 eassert. See
7245 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7246
33017faf 72472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7248
7249 * callproc.c (Fcall_process): Restore a line that was accidentally
7250 commented out in the 2011-02-13 change (bug#11547).
7251
33017faf 72522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7253
7254 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7255 defined on ralloc.c.
7256
7257 * buffer.c [REL_ALLOC]: Remove prototypes of
7258 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7259 they are now on lisp.h.
7260
7261 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7262
7263 * search.c (search_buffer): Use it to inhibit relocation of buffer
7264 text while re_search_2 is doing its job, because re_search_2 is
7265 passed C pointers to buffer text. (Bug#11519)
7266
23415acf
EZ
7267 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7268 Update value to 24.
7269
44e27368
EZ
7270 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7271 state after an additional call to move_it_in_display_line_to, keep
7272 the values of it->max_ascent and it->max_descent found for the
7273 entire line.
7274 (pos_visible_p): Revert the comparison against bottom_y to what it
7275 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7276 (Bug#11464)
7277
c1892f11
PE
72782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7279
7280 Fix coding-related core dumps with gcc -ftrapv.
7281 The code was computing A - B, where A and B are pointers, and B is
7282 random garbage. This can lead to core dumps on platforms that
7283 have special pointer registers, and it also leads to core dumps on
7284 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7285 A - B only when B is initialized properly.
7286 * coding.c (coding_set_source, coding_set_destination): Return void.
7287 (coding_change_source, coding_change_destinations): New functions,
7288 with the old behaviors of coding_set_source and coding_set_destination.
7289 All callers that need an offset changed to use these new functions.
7290
eb7afdad
GM
72912012-05-26 Glenn Morris <rgm@gnu.org>
7292
7293 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7294
f12fdf02
EZ
72952012-05-26 Eli Zaretskii <eliz@gnu.org>
7296
53a63be6 7297 Extend mouse support on W32 text-mode console.
61b108cc
SM
7298 * xdisp.c (draw_row_with_mouse_face):
7299 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7300
eb3f6f01 7301 * w32console.c: Include window.h.
61b108cc
SM
7302 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7303 New functions.
eb3f6f01
EZ
7304 (initialize_w32_display): Initialize mouse-highlight data.
7305
53a63be6
EZ
7306 * w32inevt.c: Include termchar.h and window.h.
7307 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7308 moves, call note_mouse_highlight. If help_echo changed, call
7309 gen_help_event to produce help-echo message in the echo area.
7310 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7311 highlight info.
7312
4cfd81f6
PE
73132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7314
7315 * lread.c (read1): Simplify slightly to avoid an overflow warning
7316 with GCC 4.7.0 on x86-64.
7317
4446092a
EZ
73182012-05-26 Eli Zaretskii <eliz@gnu.org>
7319
7320 * bidi.c (bidi_mirror_char): Revert last change: an int is
7321 definitely wide enough here.
7322
42b2a986 73232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7324
42b2a986 7325 Fix integer width and related bugs (Bug#9874).
eb106a49 7326 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7327 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7328 (string_bytes, check_sblock, allocate_string_data):
7329 (compact_small_strings, Fmake_bool_vector, make_string)
7330 (make_unibyte_string, make_multibyte_string)
7331 (make_string_from_bytes, make_specified_string)
7332 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7333 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7334 (mark_vectorlike):
7335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7336 (allocate_pseudovector):
7337 Use int, not EMACS_INT, where int is wide enough.
7338 (inhibit_garbage_collection, Fgarbage_collect):
7339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7340 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7341 int might not be wide enough.
7342 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7343 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7344 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7345 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7346 (bidi_level_of_next_char, bidi_move_to_visually_next):
7347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7348 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7349 (Fkill_buffer, Fset_buffer_major_mode)
7350 (advance_to_char_boundary, Fbuffer_swap_text)
7351 (Fset_buffer_multibyte, overlays_at, overlays_in)
7352 (overlay_touches_p, struct sortvec, record_overlay_string)
7353 (overlay_strings, recenter_overlay_lists)
7354 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7355 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7356 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7357 (Foverlay_recenter, last_overlay_modification_hooks_used)
7358 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7360 (validate_region): Omit unnecessary test for b <= e,
7361 since that's guaranteed by the previous test.
d311d28c
PE
7362 (adjust_overlays_for_delete): Avoid pos + length overflow.
7363 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7364 (report_overlay_modification):
7365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7366 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7367 Omit pointer cast, which isn't needed anyway, and doesn't work
7368 after the EMACS_INT -> ptrdiff_t change.
02481186 7369 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7370 * buffer.h: Adjust decls to match defn changes elsewhere.
7371 (struct buffer_text, struct buffer):
7372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7373 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7374 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7375 not int, to avoid needless 32-bit limit on 64-bit hosts.
7376 (exec_byte_code): Use tighter memory-full test, one that checks
7377 for alloca overflow. Don't compute the address of the object just
7378 before an array, as that's not portable. Use EMACS_INT, not
7379 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7380 * callint.c (Fcall_interactively):
7381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7382 * callproc.c (call_process_kill, Fcall_process):
7383 Don't assume pid_t fits into an Emacs fixnum.
7384 (call_process_cleanup, Fcall_process, child_setup):
7385 Don't assume pid_t fits into int.
7386 (call_process_cleanup, Fcall_process, delete_temp_file)
7387 (Fcall_process_region):
7388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7389 (Fcall_process): Simplify handling of volatile integers.
7390 Use int, not EMACS_INT, where int will do.
7391 * casefiddle.c (casify_object, casify_region, operate_on_word)
7392 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7394 (casify_object): Avoid integer overflow when overallocating buffer.
7395 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7396 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7397 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7398 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7399 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7400 integers are now checked earlier. All uses replaced with XINT.
7401 (ccl_driver):
7402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7403 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7404 (ccl_driver, Fregister_code_conversion_map):
7405 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7406 (resolve_symbol_ccl_program): Check that vector header is in range.
7407 Always copy the vector, so that we can check its contents reliably
7408 now rather than having to recheck each instruction as it's being
7409 executed. Check that vector words fit in 'int'.
7410 (ccl_get_compiled_code, Fregister_ccl_program)
7411 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7412 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7413 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7414 contents are in range.
7415 (Fccl_execute_on_string): Check that status is in range.
7416 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7417 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7418 Accept and return EMACS_INT, not int, because callers can pass values
7419 out of 'int' range.
7420 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7421 (multibyte_chars_in_text, parse_str_as_multibyte)
7422 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7423 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7424 (string_escape_byte8, Fget_byte):
7425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7426 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7427 avoid mishandling large integers.
7428 * character.h: Adjust decls to match defn changes elsewhere.
7429 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7430 (Ffind_charset_region):
7431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7432 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7433 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7434 Don't assume fixnum fits in int.
d311d28c
PE
7435 (load_charset_map_from_vector, Fmap_charset_chars):
7436 Remove now-unnecessary CHECK_NATNUMs.
7437 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7438 Don't rely on undefined behavior with signed left shift overflow.
7439 Don't assume unsigned int fits into fixnum, or that fixnum fits
7440 into unsigned int. Don't require max_code to be a valid fixnum;
7441 that's not true for gb10830 4-byte on a 32-bit host. Allow
7442 invalid_code to be a cons, for the same reason. Require code_offset
7443 to be a character. Avoid int overflow if max_char is close
7444 to INT_MAX.
7445 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7446 this is intended anyway and avoids some undefined behavior.
7447 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7448 INDEX_TO_CODE_POINT, as that's what it expects.
7449 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7450 * charset.h (DECODE_CHAR): Return int, not unsigned;
7451 this is what was intended anyway, and it avoids undefined behavior.
7452 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7453 integer-overflow issues.
7454 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7455 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7456 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7457 * chartab.c (Fmake_char_table, Fset_char_table_range)
7458 (uniprop_get_decoder, uniprop_get_encoder):
7459 Don't assume fixnum fits in int.
7460 * cmds.c (move_point): New function, that does the gist of
7461 Fforward_char and Fbackward_char, but does so while checking
7462 for integer overflow more accurately.
c96e5d6a 7463 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7464 (Fforward_line, Fend_of_line, internal_self_insert)
7465 (internal_self_insert):
7466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7467 Fix a FIXME, by checking for integer overflow when calculating
7468 target_clm and actual_clm.
7469 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7470 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7471 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7472 (coding_alloc_by_making_gap, alloc_destination)
7473 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7474 (encode_coding_utf_16, detect_coding_emacs_mule)
7475 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7476 (detect_coding_iso_2022, decode_coding_iso_2022)
7477 (encode_invocation_designation, encode_designation_at_bol)
7478 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7479 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7480 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7481 (encode_coding_ccl, encode_coding_raw_text)
7482 (detect_coding_charset, decode_coding_charset)
7483 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7484 (produce_composition, produce_charset, produce_annotation)
7485 (decode_coding, handle_composition_annotation)
7486 (handle_charset_annotation, consume_chars, decode_coding_gap)
7487 (decode_coding_object, encode_coding_object, detect_coding_system)
7488 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7489 (code_convert_region, code_convert_string)
8f50130c
PE
7490 (Fdefine_coding_system_internal)
7491 (coding_set_source, coding_set_destination):
d311d28c
PE
7492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7493 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7494 (Fdefine_coding_system_internal):
7495 Don't assume fixnums fit in int.
7496 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7497 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7498 (Funencodable_char_position, Fcheck_coding_systems_region)
7499 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7501 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7502 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7503 Don't access memory outside of the args array.
d311d28c 7504 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7505 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7506 result of ENCODE_CHAR.
d311d28c
PE
7507 * coding.h: Adjust decls to match defn changes elsewhere.
7508 (struct coding_system):
7509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7510 * composite.c (get_composition_id, find_composition)
7511 (run_composition_function, update_compositions)
7512 (compose_text, composition_gstring_put_cache)
7513 (composition_gstring_p, composition_gstring_width)
7514 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7515 (composition_compute_stop_pos, composition_reseat_it)
7516 (composition_update_it, struct position_record)
7517 (find_automatic_composition, composition_adjust_point)
7518 (Fcomposition_get_gstring, Ffind_composition_internal):
7519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7520 (update_compositions):
7521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7522 * composite.h: Adjust decls to match defn changes elsewhere.
7523 (struct composition):
7524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7525 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7526 Do not attempt to compute the address of the object just before a
7527 buffer; this is not portable.
7528 (Faref, Faset):
7529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7530 (Faset): Use int, not EMACS_INT, where int is wide enough.
7531 (Fstring_to_number): Don't assume fixnums fit in int.
7532 (Frem): Don't assume arg is nonnegative.
7533 * dbusbind.c (xd_append_arg): Check for integers out of range.
7534 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7535 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7536 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7537 (xd_get_connection_references): Return ptrdiff_t, not int.
7538 All uses changed.
7539 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7540 (xd_read_message_1):
7541 Use int, not unsigned, where the dbus API uses int.
7542 (Fdbus_message_internal): Don't overflow mtype.
7543 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7544 * dired.c (directory_files_internal, file_name_completion, scmp)
7545 (file_name_completion_stat):
7546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7547 (file_name_completion): Don't overflow matchcount.
7548 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7549 * dispextern.h: Adjust decls to match defn changes elsewhere.
7550 (struct text_pos, struct glyph, struct bidi_saved_info)
7551 (struct bidi_string_data, struct bidi_it, struct composition_it)
7552 (struct it):
7553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7554 (struct display_pos, struct composition_it, struct it):
7555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7556 * dispnew.c (increment_matrix_positions)
7557 (increment_row_positions, mode_line_string)
7558 (marginal_area_string):
7559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7560 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7562 (duration_to_sec_usec): New function, to check for overflow better.
7563 (Fsleep_for, sit_for): Use it.
7564 * doc.c (get_doc_string, store_function_docstring):
7565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7566 (get_doc_string, Fsnarf_documentation):
7567 Use int, not EMACS_INT, where int is wide enough.
7568 (get_doc_string):
7569 Use SAFE_ALLOCA, not alloca.
7570 Check for overflow when converting EMACS_INT to off_t.
7571 * doprnt.c (doprnt):
7572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7573 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7574 Don't assume uid_t fits into fixnum.
7575 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7576 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7577 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7578 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7579 (general_insert_function)
7580 (Finsert_char, make_buffer_string, make_buffer_string_both)
7581 (update_buffer_properties, Fbuffer_substring)
7582 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7583 (Fsubst_char_in_region, check_translation)
7584 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7585 (transpose_markers, Ftranspose_regions):
7586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7587 (clip_to_bounds): Move to lisp.h as an inline function).
7588 (Fconstrain_to_field): Don't assume integers are nonnegative.
7589 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7590 (Fsubst_char_in_region, Fsave_restriction):
7591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7592 (Femacs_pid): Don't assume pid_t fits into fixnum.
7593 (lo_time): Use int, not EMACS_INT, when int suffices.
7594 (lisp_time_argument): Check for usec out of range.
7595 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7596 (Fuser_login_name, Fuser_full_name): Signal an error
7597 if a uid argument is out of range, rather than relying on
7598 undefined behavior.
c8d5c857
PE
7599 (Fformat_time_string): Remove now-unnecessary check.
7600 lisp_time_argument checks for out-of-range usec now.
243e0530 7601 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7602 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7603 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7604 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7605 (init_cmdargs, Fdump_emacs):
7606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7607 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7608 the bottom (typically) 32 bits of the fixnum.
7609 * eval.c (specpdl_size, call_debugger):
7610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7611 (when_entered_debugger, Fbacktrace_debug):
7612 Don't assume fixnum can fit in int.
7613 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7614 the object just before a buffer; this is not portable.
7615 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7616 (grow_specpdl, unbind_to):
7617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7618 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7619 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7620 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7621 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7622 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7624 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7625 (a_write, e_write):
7626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7627 (Fcopy_file, non_regular_nbytes, read_non_regular)
7628 (Finsert_file_contents):
7629 Use int, not EMACS_INT, where int is wide enough.
7630 (READ_BUF_SIZE): Verify that it fits in int.
7631 (Finsert_file_contents): Check that counts are in proper range,
7632 rather than assuming fixnums fit into ptrdiff_t etc.
7633 Don't assume fixnums fit into int.
125b3835 7634 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7635 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7636 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7637 (string_char_to_byte, string_byte_to_char)
7638 (string_make_multibyte, string_to_multibyte)
7639 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7640 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7641 (substring_both, Fdelete, internal_equal, Ffillarray)
7642 (Fclear_string, mapcar1)
7643 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7644 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7645 (larger_vector, make_hash_table, maybe_resize_hash_table)
7646 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7647 (Fmaphash, secure_hash):
7648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7649 (concat): Check for string index and length overflow.
7650 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7651 (Frequire):
7652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7653 (larger_vector): New API (vec, incr_min, size_max) replaces old
7654 one (vec, new_size, init). This catches size overflow.
7655 INIT was removed because it was always Qnil.
7656 All callers changed.
7657 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7658 the upper bound on a hash table index size.
7659 (make_hash_table, maybe_resize_hash_table): Use it.
7660 (secure_hash): Computer start_byte and end_byte only after
7661 they're known to be in ptrdiff_t range.
7662 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7663 (Ffont_get_glyphs, Ffont_at):
7664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7665 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7666 (Flist_fonts, Fopen_font):
7667 Don't assume fixnum can fit in int.
7668 (check_gstring): Don't assume index can fit in int.
7669 (font_match_p): Check that fixnum is a character, not a nonnegative
7670 fixnum, since the later code needs to stuff it into an int.
7671 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7672 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7673 conversion overflow issues.
7674 (Fopen_font): Check for integer out of range.
7675 (Ffont_get_glyphs): Don't assume index can fit in int.
7676 * font.h: Adjust decls to match defn changes elsewhere.
7677 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7678 integer overflow.
7679 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7680 printmax_t, where ptrdiff_t is wide enough.
7681 (Finternal_char_font):
7682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7683 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7684 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7685 (Fset_frame_position, x_set_frame_parameters)
7686 (x_set_line_spacing, x_set_border_width)
7687 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7688 Check that fixnums are in proper range for system types.
7689 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7691 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7692 Use SAFE_ALLOCA_LISP, not alloca.
7693 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7694 intptr_t is wide enough.
7695 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7696 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7697 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7698 Check for fixnum out of range.
7699 * ftfont.c (ftfont_list): Don't assume index fits in int.
7700 Check that fixnums are in proper range for system types.
7701 (ftfont_shape_by_flt):
7702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7703 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7705 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7706 Check that fixnums are in proper range for system types.
7707 * gnutls.h: Adjust decls to match defn changes elsewhere.
7708 * gtkutil.c (xg_dialog_run):
7709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7710 (update_frame_tool_bar):
7711 Check that fixnums are in proper range for system types.
7712 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7713 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7714 * indent.c (last_known_column, last_known_column_point):
7715 (current_column_bol_cache):
7716 (skip_invisible, current_column, check_display_width):
7717 (check_display_width, scan_for_column, current_column_1)
7718 (Findent_to, Fcurrent_indentation, position_indentation)
7719 (indented_beyond_p, Fmove_to_column, compute_motion):
7720 (Fcompute_motion, Fvertical_motion):
7721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7722 (last_known_column_modified): Use EMACS_INT, not int.
7723 (check_display_width):
7724 (Fcompute_motion):
7725 Check that fixnums and floats are in proper range for system types.
7726 (compute_motion): Don't assume index or fixnum fits in int.
7727 (compute_motion, Fcompute_motion):
7728 Use int, not EMACS_INT, when it is wide enough.
7729 (vmotion): Omit local var start_hpos that is always 0; that way
7730 we don't need to worry about overflow in expressions involving it.
7731 * indent.h: Adjust decls to match defn changes elsewhere.
7732 (struct position):
7733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7734 Use int, not EMACS_INT, where int is wide enough.
7735 Remove unused members ovstring_chars_done and tab_offset;
7736 all uses removed.
7737 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7738 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7739 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7740 (make_gap, copy_text, insert, insert_and_inherit)
7741 (insert_before_markers, insert_before_markers_and_inherit)
7742 (insert_1, count_combining_before, count_combining_after)
7743 (insert_1_both, insert_from_string)
7744 (insert_from_string_before_markers, insert_from_string_1)
7745 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7746 (adjust_after_replace, adjust_after_insert, replace_range)
7747 (replace_range_2, del_range, del_range_1, del_range_byte)
7748 (del_range_both, del_range_2, modify_region)
7749 (prepare_to_modify_buffer, signal_before_change)
7750 (signal_after_change, Fcombine_after_change_execute):
7751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7752 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7753 (balance_an_interval, split_interval_right, split_interval_left)
7754 (find_interval, next_interval, update_interval)
7755 (adjust_intervals_for_insertion, delete_node, delete_interval)
7756 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7757 (static_offset_intervals, offset_intervals)
7758 (merge_interval_right, merge_interval_left, make_new_interval)
7759 (graft_intervals_into_buffer, temp_set_point_both)
7760 (temp_set_point, set_point, adjust_for_invis_intang)
7761 (set_point_both, move_if_not_intangible, get_property_and_range)
7762 (get_local_map, copy_intervals, copy_intervals_to_string)
7763 (compare_string_intervals, set_intervals_multibyte_1):
7764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7765 * intervals.h: Adjust decls to match defn changes elsewhere.
7766 (struct interval):
7767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7768 * keyboard.c (this_command_key_count, this_single_command_key_start)
7769 (before_command_key_count, before_command_echo_length, echo_now)
7770 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7771 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7772 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7773 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7775 (last_non_minibuf_size, last_point_position, echo_truncate)
7776 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7777 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7778 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7779 (stuff_buffered_input):
7780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7781 (last_auto_save, command_loop_1, read_char):
7782 Use EMACS_INT, not int, to avoid integer overflow.
7783 (record_char): Avoid overflow in total_keys computation.
7784 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7785 * keyboard.h: Adjust decls to match defn changes elsewhere.
7786 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7787 (Fkey_description, Fdescribe_vector, Flookup_key):
7788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7789 (click_position): New function, to check that positions are in range.
7790 (Fcurrent_active_maps):
7791 (describe_command):
7792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7793 (Faccessible_keymaps, Fkey_description):
7794 (preferred_sequence_p):
7795 Don't assume fixnum can fit into int.
7796 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7797 Check for integer overflow in size calculations.
7798 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7799 avoid mishandling large integers.
7800 * lisp.h: Adjust decls to match defn changes elsewhere.
7801 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7802 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7803 (struct Lisp_Marker):
7804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7805 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7806 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7807 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7808 All callers changed.
7809 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7810 Assume the arg has valid form, since it always does.
7811 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7812 unsigned integer system type.
7813 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7814 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7816 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7817 (duration_to_sec_usec): New decl.
7818 * lread.c (read_from_string_index, read_from_string_index_byte)
7819 (read_from_string_limit, readchar, unreadchar, openp)
7820 (read_internal_start, read1, oblookup):
7821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7822 (Fload, readevalloop, Feval_buffer, Feval_region):
7823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7824 (openp): Check for out-of-range argument to 'access'.
7825 (read1): Use int, not EMACS_INT, where int is wide enough.
7826 Don't assume fixnum fits into int.
6efdadfd 7827 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7828 (read_filtered_event): Use duration_to_sec_usec
7829 to do proper overflow checking on durations.
d311d28c
PE
7830 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7831 in size calculation.
7832 (Fexecute_kbd_macro):
7833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7834 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7835 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7836 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7837 (set_marker_both, set_marker_restricted_both, marker_position)
7838 (marker_byte_position, Fbuffer_has_markers_at):
7839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7840 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7841 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7842 It now merely ensures that the menu is large enough, without
7843 necessarily growing it, as this avoids some integer overflow issues.
7844 All callers changed.
7845 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7847 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7848 Use SAFE_ALLOCA_LISP, not alloca.
7849 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7850 to EMACS_INT. Check that fixnums are in proper range for system types.
7851 * minibuf.c (minibuf_prompt_width, string_to_object)
7852 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7853 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7855 (get_minibuffer, read_minibuf_unwind):
7856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7857 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7858 this simplifies overflow checking. All callers changed.
7859 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7860 (Ftest_completion):
7861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7862 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7863 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7864 Check that fixnums are in proper range for system types.
7865 (Fx_create_frame, Fx_show_tip):
7866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7867 * nsfont.m (ns_findfonts, nsfont_list_family):
7868 Don't assume fixnum fits in long.
7869 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7871 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7872 wide enough.
17fdb222 7873 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7875 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7876 (PRINTDECLARE, PRINTPREPARE):
7877 (strout, print_string):
7878 (print, print_preprocess, print_check_string_charset_prop)
7879 (print_object):
7880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7881 (PRINTDECLARE):
7882 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7884 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7885 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7886 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7887 (print_error_message): Use SAFE_ALLOCA, not alloca.
7888 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7889 (print_depth, new_backquote_output, print_number_index):
7890 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7891 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7892 (Fset_process_window_size, Fformat_network_address)
7893 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7894 (sigchld_handler):
d311d28c 7895 Check that fixnums are in proper range for system types.
d44287d4 7896 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7897 Check for process-ids out of pid_t range rather than relying on
7898 undefined behavior.
e4d81efc 7899 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7900 (Fformat_network_address, read_process_output, send_process)
7901 (Fprocess_send_region, status_notify):
7902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7903 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7904 (wait_reading_process_output, read_process_output, exec_sentinel):
7905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7906 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7907 (Faccept_process_output): Use duration_to_sec_usec to do proper
7908 overflow checking on durations.
dde14581
PE
7909 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7910 Don't assume pid_t fits in int.
02481186
PE
7911 * process.h (struct Lisp_Process): Members tick and update_tick
7912 are now of type EMACS_INT, not int.
b62b53e8
PE
7913 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7914 configured --with-wide-int.
d311d28c
PE
7915 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7916 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7917 * search.c (looking_at_1, string_match_1):
7918 (fast_string_match, fast_c_string_match_ignore_case)
7919 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7920 (scan_newline, find_before_next_newline, search_command)
7921 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7922 (set_search_regs, wordify):
7923 (Freplace_match):
7924 (Fmatch_data):
7925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7926 (string_match_1, search_buffer, set_search_regs):
7927 (Fmatch_data):
7928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7929 (wordify): Check for overflow in size calculation.
7930 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7931 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7932 Check that fixnums are in proper range for system types.
7933 * sound.c (struct sound_device)
7934 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7936 (Fplay_sound_internal):
7937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7938 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7939 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7940 (Fparse_partial_sexp):
7941 Don't assume fixnums can fit in int.
7942 (struct lisp_parse_state, find_start_pos, find_start_value)
7943 (find_start_value_byte, find_start_begv)
7944 (update_syntax_table, char_quoted, dec_bytepos)
7945 (find_defun_start, prev_char_comend_first, back_comment):
7946 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7947 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7949 (Finternal_describe_syntax_value): Check that match_lisp is a
7950 character, not an integer, since the code stuffs it into int.
7951 (scan_words, scan_sexps_forward):
7952 Check that fixnums are in proper range for system types.
7953 (Fforward_word):
7954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7955 (scan_sexps_forward):
7956 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7957 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7958 * syntax.h: Adjust decls to match defn changes elsewhere.
7959 (struct gl_state_s):
7960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7961 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7962 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7963 * sysdep.c (wait_for_termination_1, wait_for_termination)
7964 (interruptible_wait_for_termination, mkdir):
7965 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7966 (emacs_read, emacs_write):
7967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7968 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7969 and double all fit in int.
d311d28c
PE
7970 * term.c (set_tty_color_mode):
7971 Check that fixnums are in proper range for system types.
7972 * termhooks.h (struct input_event):
7973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7974 * textprop.c (validate_interval_range, interval_of)
7975 (Fadd_text_properties, set_text_properties_1)
7976 (Fremove_text_properties, Fremove_list_of_text_properties)
7977 (Ftext_property_any, Ftext_property_not_all)
7978 (copy_text_properties, text_property_list, extend_property_ranges)
7979 (verify_interval_modification):
7980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7981 (Fnext_single_char_property_change)
7982 (Fprevious_single_char_property_change):
7983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7984 (copy_text_properties):
7985 Check for integer overflow in index calculation.
d311d28c
PE
7986 * undo.c (last_boundary_position, record_point, record_insert)
7987 (record_delete, record_marker_adjustment, record_change)
7988 (record_property_change):
7989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7990 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7992 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7993 (Fx_hide_tip, Fx_file_dialog):
7994 * w32menu.c (set_frame_menubar):
7995 Use ptrdiff_t, not int, for consistency with rest of code.
7996 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7997 (select_window, Fdelete_other_windows_internal)
7998 (window_scroll_pixel_based, window_scroll_line_based)
7999 (Frecenter, Fset_window_configuration):
8000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8001 (Fset_window_hscroll, run_window_configuration_change_hook)
8002 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 8003 (Fscroll_other_window, Frecenter):
d311d28c
PE
8004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8005 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
8006 Don't assume fixnum fits in int.
8007 (Fset_window_scroll_bars):
8008 Check that fixnums are in proper range for system types.
8009 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
8010 (string_pos, c_string_pos, number_of_chars, init_iterator)
8011 (in_ellipses_for_invisible_text_p, init_from_display_pos)
8012 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
8013 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
8014 (face_before_or_after_it_pos, handle_invisible_prop)
8015 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
8016 (display_prop_intangible_p, string_buffer_position_lim)
8017 (string_buffer_position, handle_composition_prop, load_overlay_strings)
8018 (get_overlay_strings_1, get_overlay_strings)
8019 (iterate_out_of_display_property, forward_to_next_line_start)
8020 (back_to_previous_visible_line_start, reseat, reseat_to_string)
8021 (get_next_display_element, set_iterator_to_next)
8022 (get_visually_first_element, compute_stop_pos_backwards)
8023 (handle_stop_backwards, next_element_from_buffer)
8024 (move_it_in_display_line_to, move_it_in_display_line)
8025 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8026 (add_to_log, message_dolog, message_log_check_duplicate)
8027 (message2, message2_nolog, message3, message3_nolog
8028 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
8029 (current_message_1, truncate_echo_area, truncate_message_1)
8030 (set_message, set_message_1, store_mode_line_noprop)
8031 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
8032 (text_outside_line_unchanged_p, check_point_in_composition)
8033 (reconsider_clip_changes)
8034 (redisplay_internal, set_cursor_from_row, try_scrolling)
8035 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
8036 (redisplay_window, find_last_unchanged_at_beg_row)
8037 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
8038 (trailing_whitespace_p, find_row_edges, display_line)
8039 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
8040 (display_mode_element, store_mode_line_string)
8041 (pint2str, pint2hrstr, decode_mode_spec)
8042 (display_count_lines, display_string, draw_glyphs)
8043 (x_produce_glyphs, x_insert_glyphs)
8044 (rows_from_pos_range, mouse_face_from_buffer_pos)
8045 (fast_find_string_pos, mouse_face_from_string_pos)
8046 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8048 (safe_call, init_from_display_pos, handle_fontified_prop)
8049 (handle_single_display_spec, load_overlay_strings)
8050 (with_echo_area_buffer, setup_echo_area_for_printing)
8051 (display_echo_area, echo_area_display)
8052 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
8053 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
8054 (redisplay_window, dump_glyph_row, display_mode_line)
8055 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 8056 (handle_display_spec, display_prop_string_p):
d311d28c
PE
8057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8058 (handle_single_display_spec, build_desired_tool_bar_string)
8059 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
8060 (get_specified_cursor_type):
8061 Check that fixnums are in proper range for system types.
8062 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
8063 (Flookup_image_map):
8064 Don't assume fixnums fit in int.
8065 (compare_overlay_entries):
8066 Avoid mishandling comparisons due to subtraction overflow.
8067 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
8068 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
8069 (handle_tool_bar_click):
8070 Use int, not unsigned, since we prefer signed and the signedness
8071 doesn't matter here.
8072 (get_next_display_element, next_element_from_display_vector):
8073 Use int, not EMACS_INT, when int is wide enough.
8074 (start_hourglass): Use duration_to_sec_usec to do proper
8075 overflow checking on durations.
8076 * xfaces.c (Fbitmap_spec_p):
8077 Check that fixnums are in proper range for system types.
8078 (compare_fonts_by_sort_order):
8079 Avoid mishandling comparisons due to subtraction overflow.
8080 (Fx_family_fonts, realize_basic_faces):
8081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8082 (Fx_family_fonts):
8083 Don't assume fixnum fits in int.
8084 Use SAFE_ALLOCA_LISP, not alloca.
8085 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
8086 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
8087 (face_at_buffer_position, face_for_overlay_string)
8088 (face_at_string_position):
8089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8090 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
8091 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
8092 (Fx_show_tip):
8093 Check that fixnums are in proper range for system types.
8094 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8095 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
8096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8097 (Fx_change_window_property): Don't assume fixnums fit in int.
8098 * xfont.c (xfont_chars_supported):
8099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8100 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
8101 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
8102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8103 * xml.c (parse_region):
8104 * xrdb.c (magic_file_p):
8105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8106 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
8107 (x_get_local_selection, x_reply_selection_request)
8108 (x_handle_selection_request, wait_for_property_change):
8109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8110 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
8111 short is wide enough.
8112 (x_send_client_event): Don't assume fixnum fits in int.
8113 * xterm.c (x_x_to_emacs_modifiers):
8114 Don't assume EMACS_INT overflows nicely into int.
8115 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
8116 may come from Lisp.
8117 (handle_one_xevent): NATNUMP can eval its arg twice.
8118 (x_connection_closed):
8119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8120 * xterm.h: Adjust decls to match defn changes elsewhere.
8121 (struct scroll_bar): Use struct vectorlike_header
8122 rather than rolling our own approximation.
8123 (SCROLL_BAR_VEC_SIZE): Remove; not used.
8124
c6574eb5
GM
81252012-05-25 Glenn Morris <rgm@gnu.org>
8126
8127 * lisp.mk (lisp): Update for more files being compiled now.
8128
e8d32c7e
SM
81292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
8130
48def666
SM
8131 * lread.c: Remove `read_pure' which makes no difference.
8132 (read_pure): Remove var.
8133 (unreadpure): Remove function.
8134 (readevalloop): Don't call read_list with -1 flag.
8135 (read1, read_vector): Don't test read_pure any more.
8136 (read_list): Simplify.
8137
e8d32c7e
SM
8138 * fileio.c, character.h: Minor style tweaks.
8139
4b2addb7
DA
81402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
8141
8142 * window.h (clip_changed): Remove useless declaration.
8143
584461b2
JB
81442012-05-22 Juanma Barranquero <lekktu@gmail.com>
8145
8146 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8147 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
8148
34374650
PE
81492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
8150
8151 Remove src/m/*.
8152 This directory predates autoconf and is no longer needed nowadays.
8153 Move its few remaining bits of functionality to where they're needed.
8154 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
8155 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
8156 * m/template.h: Remove.
8157 * Makefile.in (M_FILE): Remove. All uses removed.
8158 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
8159 * lisp.h (USE_LSB_TAG):
8160 * mem-limits.h (EXCEEDS_LISP_PTR):
8161 Use VAL_MAX, not VALBITS, in #if.
8162 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
8163 (EMACS_UINT): Define unconditionally now.
8164 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
8165 (BITS_PER_EMACS_INT): New constants, replacing
8166 what used to be in config.h, but not useful in #if.
8167 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
8168 define them any more.
8169 (VAL_MAX): New macro.
8170 (VALMASK): Use it.
8171 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
8172 BITS_PER_EMACS_INT, in #if.
8173 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
8174 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
8175 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
8176 * s/ms-w32.h (DATA_START):
8177 Move here from removed file m/intel386.h.
8178 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
8179 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
8180
261cb4bb
PE
81812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
8182
8183 Assume C89 or later.
8184 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
8185 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
8186 (xrealloc):
8187 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8188 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
8189 * textprop.c, tparam.c (NULL): Remove.
8190 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
8191 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
8192 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
8193 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
8194 * xterm.c (input_signal_count): Assume volatile works.
8195
ff23cd9f
KB
81962012-05-21 Ken Brown <kbrown@cornell.edu>
8197
8198 * xgselect.c (xg_select): Fix first argument in call to 'select'
8199 (bug#11508).
8200
1b170bc6
KB
82012012-05-20 Ken Brown <kbrown@cornell.edu>
8202
8203 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 8204 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 8205
b2f4d39f
KB
82062012-05-19 Ken Brown <kbrown@cornell.edu>
8207
8208 * xfns.c (x_in_use): Remove `static' qualifier.
8209 * xterm.h (x_in_use): Declare.
8210 * xgselect.c: Include xterm.h.
8211 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
8212 and `display_arg' (bug#9754).
8213
003fdae2
PE
82142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8215
9232a6d9
PE
8216 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8217
003fdae2
PE
8218 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8219 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8220
784b56e2
EZ
82212012-05-18 Eli Zaretskii <eliz@gnu.org>
8222
8223 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8224
8225 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8226 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8227
8228 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8229 reference to image_cache->refcount.
8230 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8231
a0a79cde
JL
82322012-05-17 Juri Linkov <juri@jurta.org>
8233
8234 * search.c (Fword_search_regexp, Fword_search_backward)
8235 (Fword_search_forward, Fword_search_backward_lax)
8236 (Fword_search_forward_lax): Move functions to isearch.el
8237 (bug#10145, bug#11381).
8238
b0572523
PE
82392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8240
8241 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8242
9660f5fc
SM
82432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8244
8245 * lread.c (init_obarray): Declare Qt and Qnil as special.
8246
4374de83
GM
82472012-05-14 Glenn Morris <rgm@gnu.org>
8248
8249 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8250 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8251
dc44c39a
PE
82522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8253
078c97cb
PE
8254 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8255
dc44c39a
PE
8256 * unexaix.c: Port to more-recent AIX compilers.
8257 (report_error, report_error_1, make_hdr, copy_sym)
8258 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8259 Make arguments const char *, not char *, to avoid violations of C
8260 standard and to fix some AIX warnings reported by Gilles Pion.
8261
e18afed7 82622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8263
8264 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8265 already have overlays loaded.
8266 (handle_single_display_spec): Before returning without displaying
8267 fringe bitmap, synchronize the bidi iterator with the main display
8268 iterator, by calling iterate_out_of_display_property.
8269 (iterate_out_of_display_property): Detect buffer iteration by
8270 testing that it->string is a Lisp string.
8271 (get_next_display_element): When the current object is exhausted,
8272 and there's something on it->stack, call set_iterator_to_next to
8273 proceed with what's on the stack, instead of returning zero.
8274 (set_iterator_to_next): If called at the end of a Lisp string,
8275 proceed to consider_string_end without incrementing string
8276 position. Don't increment display vector index past the end of
8277 the display vector. (Bug#11417)
c8fb9dc6
EZ
8278 (pos_visible_p): Don't report a position visible when move_it_to
8279 stopped at the last line of window, which happens to be scanned
8280 backwards by the bidi iteration. (Bug#11464)
ac268e67 8281
e18afed7 82822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8283
8284 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8285 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8286 are on a TTY, and thus unable to display on the fringes.
8287 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8288 so we need to signal to the caller that this is a "replacing"
8289 display spec. This fixes display when the spec is invalid or we
8290 are on a TTY.
8291
e18afed7 82922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8293
8294 * unexaix.c (make_hdr): Fix typo in prototype.
8295 This bug broke the build on AIX. Problem reported by Gilles Pion.
8296
9d0a235a
MA
82972012-05-14 Michael Albinus <michael.albinus@gmx.de>
8298
8299 * keyboard.c (kbd_buffer_get_event): Read special events also in
8300 batch mode. (Bug#11415)
8301
9e6b06ed
GM
83022012-05-12 Glenn Morris <rgm@gnu.org>
8303
8304 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8305
c1a1d7a3
EZ
83062012-05-12 Eli Zaretskii <eliz@gnu.org>
8307
8308 * lisp.mk (lisp): Add newcomment.elc.
8309
3fe7cdc8
GM
83102012-05-12 Glenn Morris <rgm@gnu.org>
8311
8312 * Makefile.in (MKDIR_P): New, set by configure.
8313 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8314
53f7d2c0
PE
83152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8316
8317 Remove unused function hourglass_started.
8318 * dispextern.h (hourglass_started):
8319 * w32fns.c (hourglass_started):
8320 * xdisp.c (hourglass_started): Remove.
8321
75aafb17
JB
83222012-05-10 Juanma Barranquero <lekktu@gmail.com>
8323
8324 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8325 Update dependencies.
8326
12959e8e
PE
83272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8328
97107e2e
PE
8329 * xgselect.c (xg_select): Put maxfds+1 into a var.
8330 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8331
12959e8e
PE
8332 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8333
836d29b3
DA
83342012-05-10 Dave Abrahams <dave@boostpro.com>
8335
8336 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8337 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8338
5cb67954
MA
83392012-05-09 Michael Albinus <michael.albinus@gmx.de>
8340
8341 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8342 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8343 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8344 Initialize xd_registered_buses.
8345
3478ec45
PE
83462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8347
b263a6b0
PE
8348 Untag more efficiently if USE_LSB_TAG.
8349 This is based on a proposal by YAMAMOTO Mitsuharu in
8350 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8351 For an admittedly artificial (nth 8000 longlist) benchmark on
8352 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8353 Emacs's overall text size by 1%.
8354 * lisp.h (XUNTAG): New macro.
8355 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8356 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8357 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8358 * eval.c (Fautoload):
8359 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8360 * frame.h (XFRAME): Use XUNTAG.
8361
3478ec45
PE
8362 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8363 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8364 Remove unportable assumptions about print widths of types like
8365 dbus_uint32_t.
8366 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8367 intptr_t when converting between pointer and integer, to avoid GCC
8368 warnings about wrong width.
8369
666b903b 83702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8371
8372 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8373 stack for each reader_thread, instead of defaulting to 8MB
8374 determined by the linker. This avoids failures in creating
8375 subprocesses on Windows 7, see the discussion in this thread:
8376 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8377
b120cc17
JC
83782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8379
8380 Fix up display of the *Minibuf-0* buffer in the mini window.
8381 * keyboard.c (read_char): Don't clear the echo area if there's no
8382 message to clear.
8383 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8384 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8385
9a4b36f8
MA
83862012-05-07 Michael Albinus <michael.albinus@gmx.de>
8387
8388 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8389 batch mode.
8390
e5f9458f
CY
83912012-05-06 Chong Yidong <cyd@gnu.org>
8392
8393 * lisp.mk (lisp): Update.
8394
eceeb5fc 83952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8396
8397 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8398
71873e2b
SM
83992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8400
8401 * data.c (PUT_ERROR): New macro.
8402 (syms_of_data): Use it. Add new error type `user-error'.
8403 * undo.c (user_error): New function.
8404 (Fprimitive_undo): Use it.
8405 * print.c (print_error_message): Adjust print style for `user-error'.
8406 * keyboard.c (user_error): New function.
8407 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8408
ab0fa4e4
PE
84092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8410
8411 Do not limit current-time-string to years 1000..9999.
8412 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8413 (Fcurrent_time_string): Support any year that is supported by the
8414 underlying localtime representation. Don't use asctime, as it
8415 has undefined behavior for years outside the range -999..9999.
8416
7ed806a7
PE
84172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8418
8419 Fix race conditions involving setenv, gmtime, localtime, asctime.
8420 Without this fix, interrupts could mess up code that uses these
8421 nonreentrant functions, since setting TZ invalidates existing
8422 tm_zone or tzname values, and since most of these functions return
8423 pointers to static storage.
8424 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8425 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8426 Grow the critical sections to include not just invoking
8427 localtime/gmtime, but also accessing these functions' results
8428 including their tm_zone values if any, and any related TZ setting.
8429 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8430 so that the struct tm is saved in the critical section.
8431 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8432 motivated by the fact that memory allocation needs to be outside
8433 the critical section.
8434
0c16dfed
DA
84352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8436
8437 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8438 with RESET_INTERVAL.
8439
8440 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8441 Remove duplicated buffer name initialization.
8442
3f83ace8
JM
84432012-05-02 Jim Meyering <jim@meyering.net>
8444
8445 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8446
c7b8541e
JM
8447 * xfns.c (x_window): Use xstrdup (Bug#11375).
8448
90207a15 84492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8450
8451 * xdisp.c (pos_visible_p): If already at a newline from the
8452 display string before the 'while' loop, don't walk back the glyphs
8453 from it3.glyph_row. Solves assertion violation when the display
8454 string begins with a newline (egg.el). (Bug#11367)
8455
b593d6a9
AH
84562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8457
8458 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8459 Move to simple.el.
8460
4737362e
GM
84612012-05-01 Glenn Morris <rgm@gnu.org>
8462
99cf43f9
GM
8463 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8464 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8465 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8466 All were removed before 23.1.
8467
9311dcff
GM
8468 * dispnew.c: Remove HAVE_LIBNCURSES test;
8469 it is always true on relevant platforms.
8470
4d5c6349
GM
8471 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8472 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8473
4737362e
GM
8474 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8475
74dd3a6b
AS
84762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8477
8478 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8479 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8480 Remove.
8481
13c379ee
PE
84822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8483
8484 Do not avoid creating empty evaporating overlays (Bug#9642).
8485 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8486 That is, do not delete an evaporating overlay if it becomes
8487 empty after its bounds are adjusted to fit within its buffer.
8488 This fix caused other problems, and I'm reverting it until we get
8489 to the bottom of them.
8490
a8e7d6d7 84912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8492
8493 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8494
a8e7d6d7 84952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8496
8497 * xdisp.c (pos_visible_p): If the window start position is beyond
8498 ZV, start the display from buffer beginning. Prevents assertion
8499 violation in init_iterator when the minibuffer window is scrolled
8500 via the scroll bar.
8501
8502 * window.c (window_scroll_pixel_based): Likewise.
8503
a8e7d6d7 85042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8505
8506 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8507
a8e7d6d7 85082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8509
8510 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8511 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8512
a8e7d6d7 85132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8514
b593d6a9
AH
8515 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8516 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8517
1c6900d9
EZ
85182012-04-26 Eli Zaretskii <eliz@gnu.org>
8519
4c3fa1d9
EZ
8520 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8521 display element, check also the underlying string or buffer
8522 character. (Bug#11341)
8523
1c6900d9
EZ
8524 * w32menu.c: Include w32heap.h.
8525 (add_menu_item): If the call to AppendMenuW (via
8526 unicode_append_menu) fails, disable Unicode menus only if we are
8527 running on Windows 9X/Me.
8528
42bf8205
AS
85292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8530
8531 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8532 (xgetint): Add missing shift for LSB tags.
8533
b1bac16e
MR
85342012-04-24 Martin Rudalics <rudalics@gmx.at>
8535
8536 * keyboard.c (read_char): Don't wipe echo area for select window
8537 events: These might get delayed via `mouse-autoselect-window'
8538 (Bug#11304).
8539
d69621cc
JB
85402012-04-24 Juanma Barranquero <lekktu@gmail.com>
8541
8542 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8543 manipulation of :loaded-from data.
8544
02fd101b
JB
85452012-04-23 Juanma Barranquero <lekktu@gmail.com>
8546
8547 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8548 now a cons (bug#11311).
8549
888bec30
PE
85502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8551
89a438bd
PE
8552 Do not create empty overlays with the evaporate property (Bug#9642).
8553 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8554 if it becomes empty after its bounds are adjusted to fit within
8555 its buffer. Without this fix, in a nonempty buffer (let ((o
8556 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8557 yields an empty overlay that has the evaporate property, which is
8558 not supposed to happen.
8559
1068fe4d
PE
8560 Fix minor GTK3 problems found by static checking.
8561 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8562 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8563 (struct _EmacsFixedClass, emacs_fixed_get_type):
8564 Move decls here from emacsgtkfixed.h, since they needn't be public.
8565 (emacs_fixed_get_type): Now static.
8566 (emacs_fixed_class_init): Omit unused local.
8567 (emacs_fixed_child_type): Remove; unused.
8568 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8569 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8570 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8571 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8572 (EMACS_FIXED_GET_CLASS): Remove; unused.
8573 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8574
888bec30
PE
8575 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8576 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8577
de85e130
PE
85782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8579
d0baac98 8580 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8581 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8582 (__malloc_size_t, __malloc_ptrdiff_t):
8583 Remove. All uses removed, replaced by the definiens if needed,
8584 since we can assume C89 or better now.
8585 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8586 (protect_malloc_state, align, get_contiguous_space)
8587 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8588 (malloc_atfork_handler_child, malloc_enable_thread)
8589 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8590 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8591 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8592 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8593 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8594 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8595 Define using prototypes, not old style.
8596 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8597 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8598 (align): Don't assume that signed integer overflow wraps around.
8599 Omit unused local var.
8600 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8601 (_free_internal_nolock, memalign, mallochook, reallochook):
8602 Omit no-longer-needed casts.
8603 (valloc): Use getpagesize, not __getpagesize.
8604 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8605 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8606
de85e130
PE
8607 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8608
dcbf5805
MA
86092012-04-22 Michael Albinus <michael.albinus@gmx.de>
8610
8611 Move functions from C to Lisp. Make non-blocking method calls
8612 the default. Implement further D-Bus standard interfaces.
8613
8614 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8615 (QCdbus_request_name_allow_replacement)
8616 (QCdbus_request_name_replace_existing)
8617 (QCdbus_request_name_do_not_queue)
8618 (QCdbus_request_name_reply_primary_owner)
8619 (QCdbus_request_name_reply_in_queue)
8620 (QCdbus_request_name_reply_exists)
8621 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8622 (QCdbus_registered_serial, QCdbus_registered_method)
8623 (QCdbus_registered_signal): New Lisp objects.
8624 (XD_DEBUG_MESSAGE): Use sizeof.
8625 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8626 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8627 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8628 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8629 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8630 (xd_signature, xd_append_arg): Allow float for integer types.
8631 (xd_get_connection_references): New function.
b593d6a9
AH
8632 (xd_get_connection_address): Rename from xd_initialize.
8633 Return cached address.
dcbf5805
MA
8634 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8635 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8636 level.
8637 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8638 Return number of refcounts.
dcbf5805
MA
8639 (Fdbus_get_unique_name): Make stronger parameter check.
8640 (Fdbus_message_internal): New defun.
8641 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8642 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8643 (Fdbus_send_signal, Fdbus_register_service)
8644 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8645 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8646 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8647 (Vdbus_compiled_version, Vdbus_runtime_version)
8648 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8649 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8650 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8651 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8652 Adapt docstring.
dcbf5805 8653
52828e02
PE
86542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8655
da05bc4c
PE
8656 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8657 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8658 Do not assume ptrdiff_t is the same width as 'int'.
8659
52828e02
PE
8660 * alloc.c: Handle unusual debugging option combinations.
8661 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8662 since the two debugging options are incompatible.
8663 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8664 is defined.
8665 (mem_init, mem_insert, mem_insert_fixup):
8666 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8667 (NEED_MEM_INSERT): Remove; no longer needed.
8668
f01769f9
LL
86692012-04-22 Leo Liu <sdl.web@gmail.com>
8670
8671 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8672
5790543d
PE
86732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8674
8675 * sysdep.c [__FreeBSD__]: Minor cleanups.
8676 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8677 Use Emacs indenting style more consistently. Avoid some casts.
8678 Use 'double' consistently rather than mixing 'float' and 'double'.
8679
b91b7e4d
EW
86802012-04-21 Eduard Wiebe <usenet@pusto.de>
8681
b593d6a9
AH
8682 * sysdep.c (list_system_processes, system_process_attributes):
8683 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8684
6114eb15
AS
86852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8686
8687 * lisp.mk (lisp): Update.
8688
2f38dff7
PE
86892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8690
8691 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8692 It is never used otherwise.
8693
4ae29f89
SM
86942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8695
8696 * print.c (print_preprocess): Only check print_depth if print-circle
8697 is nil.
8698 (print_object): Check for cycles even when print-circle is nil and
8699 print-gensym is t, but only check print_depth if print-circle is nil.
8700
f30d612a
CY
87012012-04-20 Chong Yidong <cyd@gnu.org>
8702
8703 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8704 set the status to "failed" and ensure that sentinel is run.
8705
c07a4c0b 87062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8707
8708 * process.c (Fset_process_inherit_coding_system_flag)
8709 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8710 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8711
c07a4c0b 87122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8713
8714 * xdisp.c (string_buffer_position_lim): Limit starting position to
8715 BEGV.
8716 (set_cursor_from_row): If called for a mode-line or header-line
8717 row, return zero immediately.
8718 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8719 farther than the first row after the header line, if any.
8720 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8721 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8722
c07a4c0b 87232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8724
4ae29f89
SM
8725 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8726 (bug#11238).
ad3a2b41 8727
c07a4c0b 87282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 87292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8730
8731 configure: new option --enable-gcc-warnings (Bug#11207)
8732 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8733 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8734 (ALL_CFLAGS): Use new macros rather than old.
8735 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8736 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8737 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8738 -Wunused-result, -Wunused-variable. This should go away once
8739 the Emacs and Gnulib regex code is merged.
8740 (xmalloc, xrealloc): Now static.
8741
aba027e8
PE
87422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8743
8744 * dired.c (Fsystem_groups): Remove unused local.
8745
e5a36063
GM
87462012-04-17 Glenn Morris <rgm@gnu.org>
8747
8748 * dired.c (Fsystem_users): Doc fix.
8749
316411f0
DA
87502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8751
8752 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8753 (syms_of_dired): Add them.
8754
9426aba4
PE
87552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8756
b62a57be
PE
8757 Fix minor alloc.c problems found by static checking.
8758 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8759 New extern decls, to avoid calling undeclared functions.
8760 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8761 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8762 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8763 (NEED_MEM_INSERT): New macro.
8764 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8765 Remove one incorrect comment and fix another.
b62a57be 8766
3539f31f
PE
8767 Fix minor ralloc.c problems found by static checking.
8768 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8769 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8770 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8771 (r_alloc_sbrk): Now static.
8772
a041960a
PE
8773 Improve ralloc.c interface checking.
8774 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8775 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8776 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8777 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8778 [REL_ALLOC]: ... to here, to check interface.
8779 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8780 Remove decls. This fixes an "It stinks!".
8781
9426aba4
PE
8782 * alloc.c (which_symbols): Fix alignment issue / type clash.
8783
d55c12ed
AS
87842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8785
8786 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8787 (struct Lisp_Misc_Any): Likewise.
8788 (struct Lisp_Free): Likewise.
8789 * alloc.c (union aligned_Lisp_Symbol): Define.
8790 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8791 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8792 (union aligned_Lisp_Misc): Define.
8793 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8794 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8795 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8796
b948ce8b
PE
87972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8798
8799 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8800 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8801 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8802 * s/netbsd.h, s/sol2-6.h:
8803 Remove definition of GC_MARK_STACK, since the default now works.
8804 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8805 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8806 no longer the default.
8807 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8808
35dc09a1 88092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8810
35dc09a1
GM
8811 * lread.c (lisp_file_lexically_bound_p):
8812 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8813
35dc09a1
GM
88142012-04-14 Eli Zaretskii <eliz@gnu.org>
8815
8816 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8817 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8818
88192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8820
8821 * nsterm.m (constrainFrameRect): Always constrain when there is only
8822 one screen (Bug#10962).
8823
bcd86815
KB
88242012-04-13 Ken Brown <kbrown@cornell.edu>
8825
8826 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8827
c25df26e
RT
88282012-04-13 Reuben Thomas <rrt@sc3d.org>
8829
8830 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8831
0fc59f1e
DC
88322012-04-11 Daniel Colascione <dancol@dancol.org>
8833
8834 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8835 against is gone. It's better to use vfork now so that when Cygwin
8836 gains a new, working vfork, we use it automatically (bug#10398).
8837
de8c03dc
SM
88382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8839
8840 * window.c (save_window_save): Obey window-point-insertion-type.
8841
2f097256
GM
88422012-04-11 Glenn Morris <rgm@gnu.org>
8843
8844 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8845
453b951e
SM
88462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8847
8848 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8849
75f1671a 88502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8851
8852 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8853 (force_quit_count): New var.
8854 (handle_interrupt): Use it.
8855
2a8ce227
JB
88562012-04-10 Juanma Barranquero <lekktu@gmail.com>
8857
8858 * w32.c (w32_delayed_load): Record the full path of the library
8859 being loaded (bug#10424).
8860
935396c0
GM
88612012-04-09 Glenn Morris <rgm@gnu.org>
8862
05920a43
GM
8863 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8864 not just in the obarray, before snarfing them. (Bug#11036)
8865
935396c0
GM
8866 * Makefile.in ($(leimdir)/leim-list.el):
8867 Pass EMACS rather than BUILT_EMACS.
8868
a18ecafa
TZ
88692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8870
8871 * process.c (make_process):
8872 * process.h: Add integer `gnutls_handshakes_tried' member to
8873 process struct.
8874
6bbef4e5
JC
8875 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8876 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8877
8878 * gnutls.c (gnutls_log_function2i): Convenience log function.
8879 (emacs_gnutls_read): Use new log functions,
8880 `gnutls_handshakes_tried' process member, and
8881 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8882 attempts per process (connection).
8883
b4d3bc10
CY
88842012-04-09 Chong Yidong <cyd@gnu.org>
8885
8886 * eval.c (Fuser_variable_p, user_variable_p_eh)
8887 (lisp_indirect_variable): Functions deleted.
8888 (Fdefvar): Caller changed.
8889
8890 * callint.c (Finteractive, Fcall_interactively):
8891 * minibuf.c (Fread_variable): Callers changed.
8892
70f4d973
EZ
88932012-04-09 Eli Zaretskii <eliz@gnu.org>
8894
8895 * xdisp.c (set_cursor_from_row): If the display string appears in
8896 the buffer at position that is closer to point than the position
8897 after the display string, display the cursor on the first glyph of
8898 the display string. Fixes cursor display when a 'display' text
8899 property immediately follows invisible text. (Bug#11094)
8900
cb3c2e3e
PE
89012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8902
8903 composite.c: use 'double' consistently
8904 * composite.c (get_composition_id): Use 'double' consistently
8905 instead of converting 'float' to 'double' and vice versa; this is
8906 easier to understand and avoids a GCC warning.
8907
fd06db5d
GM
89082012-04-09 Glenn Morris <rgm@gnu.org>
8909
50fe702a
GM
8910 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8911 preparation for dumping it with emacs. (Bug#4789)
8912 (leimdir): New variable.
8913 ($(leimdir)/leim-list.el): New rule.
8914 (emacs$(EXEEXT)): Depend on leim-list.el.
8915
fd06db5d
GM
8916 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8917 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8918 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8919
55c131ee
AS
89202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8921
8922 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8923 proper alignment.
8924
9209588f
JB
89252012-04-07 Juanma Barranquero <lekktu@gmail.com>
8926
8927 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8928 Remove unused local variable.
8929
e3fb2efb
PE
89302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8931
8932 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8933 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8934 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8935 objects, as mark_maybe_pointer will catch them otherwise.
8936 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8937 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8938
b5385551
PE
89392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8940
8941 Fix typo that broke non-Windows builds.
8942 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8943
9078ead6
EZ
89442012-04-07 Eli Zaretskii <eliz@gnu.org>
8945
8946 Support building on MS-Windows with libxml2.
8947
8948 * makefile.w32-in (OBJ2): Add xml.$(O).
8949 (GLOBAL_SOURCES): Add xml.c.
8950 ($(BLD)/xml.$(O)): New dependency list.
8951
8952 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8953 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8954 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8955 [!WINDOWSNT]: New macros.
8956 (init_libxml2_functions, libxml2_loaded_p): New functions.
8957 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8958 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8959 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8960 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8961 linked in).
6bbef4e5
JC
8962 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8963 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8964 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8965
8966 * emacs.c: Don't include libxml/parser.h.
8967 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8968 xmlCleanupParser directly.
8969
8970 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8971
3811fdf3
EZ
89722012-04-07 Eli Zaretskii <eliz@gnu.org>
8973
8974 * indent.c (Fvertical_motion): If there is a display string at
8975 point, use it.vpos to compute how many lines to backtrack after
8976 move_it_to point. (Bug#11133)
8977
2f8e16b2
EZ
89782012-04-06 Eli Zaretskii <eliz@gnu.org>
8979
8980 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8981 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8982 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8983 macros related to unification of CJK characters. For the details,
8984 see the discussion following the message here:
8985 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8986
3d439cd1
CY
89872012-04-04 Chong Yidong <cyd@gnu.org>
8988
8989 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8990
8bc53d00
EZ
89912012-04-01 Eli Zaretskii <eliz@gnu.org>
8992
8993 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8994 instead of alloca. (Bug#11138)
8995
3b0512a3
AS
89962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8997
8998 * w32menu.c (is_simple_dialog): Properly check lisp types.
8999 (Bug#11141)
9000
8427ddd2
EZ
90012012-03-31 Eli Zaretskii <eliz@gnu.org>
9002
979022ef
EZ
9003 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
9004 position we get to after a call to move_it_to fails the
9005 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
9006 only if we wind up in a string from display property. (Bug#11063)
9007
a6b1c7cc
EZ
9008 * window.c (Fdelete_other_windows_internal): Invalidate the row
9009 and column information about mouse highlight, so that redisplay
9010 restores it after reallocating the glyph matrices. (Bug#7464)
9011
8427ddd2
EZ
9012 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
9013 string comes from a `display' text property, use the buffer
9014 position of that property as if we actually saw that position in
9015 the row's glyphs.
697ba24b
EZ
9016 (move_it_by_lines): Remove the assertion that
9017 "it->current_x == 0 && it->hpos == 0" which can be legitimately
9018 violated when there's a before-string at the beginning of a line.
9019 (Bug#11063)
8427ddd2 9020
65a0a738
EZ
90212012-03-30 Eli Zaretskii <eliz@gnu.org>
9022
9023 * xdisp.c (append_space_for_newline): If the default face was
9024 remapped, use the remapped face for the appended newline.
9025 (extend_face_to_end_of_line): Use the remapped default face for
9026 extending the face to the end of the line.
9027 (display_line): Call extend_face_to_end_of_line when the default
9028 face was remapped. (Bug#11068)
9029
581355cc
EZ
90302012-03-29 Eli Zaretskii <eliz@gnu.org>
9031
9032 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
9033
e8fc049f
SM
90342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9035
9036 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
9037
4fb9a543
GM
90382012-03-27 Glenn Morris <rgm@gnu.org>
9039
9040 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
9041 Doc fixes.
9042
679910f1
KH
90432012-03-26 Kenichi Handa <handa@m17n.org>
9044
9045 * dispextern.h (struct glyph): Fix previous change. Change the
9046 bit length of glyphless.ch to 25 (Bug#11082).
9047
90d49b7f
CY
90482012-03-26 Chong Yidong <cyd@gnu.org>
9049
9050 * keyboard.c (Vselection_inhibit_update_commands): New variable.
9051 (command_loop_1): Use it; inhibit selection update for
9052 handle-select-window too (Bug#8996).
9053
f514f6f0
FP
90542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
9055
e8fc049f 9056 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 9057
bf43fa51
KH
90582012-03-25 Kenichi Handa <handa@m17n.org>
9059
9060 * dispextern.h (struct glyph): Change the bit length of
9061 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
9062
8a0c01dd
EZ
90632012-03-24 Eli Zaretskii <eliz@gnu.org>
9064
9065 * s/ms-w32.h (tzname): Include time.h before redirecting to
9066 _tzname. Fixes the MSVC build. (Bug#9960)
9067
7d1c3a76
AS
90682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
9069
8ed79523
AS
9070 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
9071 characters.
9072
7d1c3a76
AS
9073 * xterm.c (XTread_socket): Only modify handling_signal if
9074 !SYNC_INPUT. (Bug#11080)
9075
e99a9b8b
EZ
90762012-03-23 Eli Zaretskii <eliz@gnu.org>
9077
9078 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
9079 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
9080 when fetching a multibyte character consumes more bytes than
9081 CHAR_BYTES returns, due to unification of CJK characters in
9082 string_char. (Bug#11073)
9083
5063c0e1
TN
90842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
9085
9086 * process.c (wait_reading_process_output): Handle pty disconnect
9087 by refraining from sending oneself a SIGCHLD (bug#10933).
9088
9f851fbd
CY
90892012-03-22 Chong Yidong <cyd@gnu.org>
9090
9091 * dispextern.h (struct it): New member string_from_prefix_prop_p.
9092
5063c0e1 9093 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
9094 Mark string as coming from a prefix property.
9095 (handle_face_prop): Use default face for prefix strings (Bug#4281).
9096 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
9097
fb5b8aca
CY
90982012-03-21 Chong Yidong <cyd@gnu.org>
9099
9100 * xfaces.c (Vface_remapping_alist): Doc fix.
9101
62356a1b
EZ
91022012-03-20 Eli Zaretskii <eliz@gnu.org>
9103
9104 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
9105 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
9106 Doc fixes.
62356a1b 9107
025de85b
CY
91082012-03-20 Chong Yidong <cyd@gnu.org>
9109
9110 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
9111 to reflect default non-nil value of redisplay-dont-pause.
9112
4827f94e
KH
91132012-03-19 Kenichi Handa <handa@m17n.org>
9114
9115 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9116 it fit in a valid range (Bug#11003).
9117
e50a24a2
EZ
91182012-03-18 Eli Zaretskii <eliz@gnu.org>
9119
9120 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9121 that is not from display property, accept the row as a "cursor
9122 row" if one of the string's character has a non-nil `cursor'
9123 property. Fixes cursor positioning when there are newlines in
9124 overlay strings, e.g. in icomplete.el. (Bug#11035)
9125
9af5ed87
PE
91262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
9127
9128 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
9129
d1f55f16
CY
91302012-03-12 Chong Yidong <cyd@gnu.org>
9131
9132 * eval.c (inhibit_lisp_code): Rename from
9133 inhibit_window_configuration_change_hook; move from window.c.
9134
9135 * xfns.c (unwind_create_frame_1, Fx_create_frame):
9136 * window.c (run_window_configuration_change_hook)
9137 (syms_of_window): Callers changed.
9138
66c5eebd
CY
91392012-03-11 Chong Yidong <cyd@gnu.org>
9140
413df973
CY
9141 * keymap.c (Fkey_description): Doc fix (Bug#9700).
9142
66c5eebd
CY
9143 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
9144
1de11f56
CY
91452012-03-10 Chong Yidong <cyd@gnu.org>
9146
9147 * frame.c (other_visible_frames): Don't assume the selected frame
9148 is visible (Bug#10955).
9149
cae07000
SM
91502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
9151
9152 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
9153
89c94350
JD
91542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
9155
9156 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
9157 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9158 zero (Bug#10954).
9159
999dd333
GM
91602012-03-03 Glenn Morris <rgm@gnu.org>
9161
01a6dcc8 9162 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 9163
de0100f2
EZ
91642012-03-02 Eli Zaretskii <eliz@gnu.org>
9165
9166 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
9167 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
9168 (redisplay_window, next_element_from_string): Fix typos in
9169 comments.
3e441275
EZ
9170 (redisplay_window): Pass to move_it_vertically the margin in
9171 pixels, not in screen lines.
de0100f2 9172
96a72ee9
GM
91732012-03-02 Glenn Morris <rgm@gnu.org>
9174
9175 * buffer.c (buffer-list-update-hook): Doc fix.
9176
312508d7
EZ
91772012-02-29 Eli Zaretskii <eliz@gnu.org>
9178
9179 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
9180 push_it before setting up the iterator for the first overlay
9181 string, even if we have an empty string loaded.
9182 (next_overlay_string): If there's an empty string on the iterator
9183 stack, pop the stack. (Bug#10903)
9184
27f3c637
PE
91852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
9186
9187 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
9188 Suggested by Stefan Monnier in
9189 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
9190 * alloc.c (widen_to_Lisp_Object): New static function.
9191 (mark_memory): Also mark Lisp_Objects by fetching pointer words
9192 and widening them to Lisp_Objects. This would work even if
9193 USE_LSB_TAG is defined and wide integers are used, which might
9194 happen in a future version of Emacs.
9195
3c9dfce6
CY
91962012-02-25 Chong Yidong <cyd@gnu.org>
9197
fa74b241
CY
9198 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
9199 Doc fix.
9200
3c9dfce6
CY
9201 * xselect.c (Fx_selection_exists_p): Doc fix.
9202 (x_clipboard_manager_save_all): Print an informative message
9203 before saving to clipboard manager.
9204
9486df08
CY
92052012-02-24 Chong Yidong <cyd@gnu.org>
9206
9207 * keyboard.c (process_special_events): Handle all X selection
9208 requests in kbd_buffer, not just the next one (Bug#8869).
9209
f01d3321
CY
92102012-02-23 Chong Yidong <cyd@gnu.org>
9211
9212 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9213 call when setting menu-bar-lines and tool-bar-lines parameters.
9214 (unwind_create_frame_1): New helper function.
9215
9216 * window.c (inhibit_window_configuration_change_hook): New var.
9217 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9218 (syms_of_window): Initialize it.
f01d3321 9219
86b847b6
CY
92202012-02-22 Chong Yidong <cyd@gnu.org>
9221
9222 * xterm.c (x_draw_image_relief): Add missing type check for
9223 Vtool_bar_button_margin (Bug#10743).
9224
a59225b1
CY
92252012-02-21 Chong Yidong <cyd@gnu.org>
9226
9227 * fileio.c (Vfile_name_handler_alist): Doc fix.
9228
9229 * buffer.c (Fget_file_buffer): Protect against invalid file
9230 handler return value.
9231
310f5bd4
PE
92322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9233
cb3a28cc
PE
9234 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9235 when computing $valmask.
9236
310f5bd4
PE
9237 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9238 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9239 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9240 It's useless in that case, and it can cause problems on hosts
9241 that allocate halves of EMACS_INT values separately.
9242 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9243 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9244 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9245 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9246 it avoids undefined behavior on hosts where shifting right by more
9247 than the word width has undefined behavior.
9248
2375c96a
CY
92492012-02-19 Chong Yidong <cyd@gnu.org>
9250
9251 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9252 (Funhandled_file_name_directory, Ffile_name_as_directory)
9253 (Fdirectory_file_name, Fexpand_file_name)
9254 (Fsubstitute_in_file_name): Protect against invalid file handler
9255 return values (Bug#10845).
9256
3eb49e71
EZ
92572012-02-18 Eli Zaretskii <eliz@gnu.org>
9258
9259 * .gdbinit (pitx): Fix incorrect references to fields of the
9260 iterator stack.
9261
7b926f3f
CY
92622012-02-17 Chong Yidong <cyd@gnu.org>
9263
9264 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9265
11273115
PE
92662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9267
9268 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9269 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9270
c3a70e2b
CY
92712012-02-15 Chong Yidong <cyd@gnu.org>
9272
9273 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9274 marked as special. Also, starting docstrings with * is obsolete.
9275
0ca43699
AS
92762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9277
9278 * gnutls.c (emacs_gnutls_write): Fix last change.
9279
2e8f3c56
LI
92802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9281
9282 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9283 send_process.
9284
af70074f
SM
92852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9286
9287 * keymap.c (Fsingle_key_description): Handle char ranges.
9288
95986d52
CY
92892012-02-12 Chong Yidong <cyd@gnu.org>
9290
afd83bd1
CY
9291 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9292 as that creates a dangerous corner case.
9293
95986d52
CY
9294 * window.c (Fdelete_window_internal): Invalidate the mouse
9295 highlight (Bug#9904).
9296
bd7da63e
GM
92972012-02-12 Glenn Morris <rgm@gnu.org>
9298
9299 * xselect.c (Fx_own_selection_internal)
9300 (Fx_get_selection_internal, Fx_disown_selection_internal)
9301 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9302 * nsselect.m (Fx_own_selection_internal)
9303 (Fx_disown_selection_internal, Fx_selection_exists_p)
9304 (Fx_selection_owner_p, Fx_get_selection_internal):
9305 Sync docs and argument specs with the xselect.c versions.
9306
77abcbc2
LI
93072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9308
9309 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9310
90b671e2
EZ
93112012-02-11 Eli Zaretskii <eliz@gnu.org>
9312
1c0ca0b7
EZ
9313 * w32select.c (Fx_selection_exists_p): Sync doc string and
9314 argument list with xselect.c. (Bug#10783)
9315
9316 * w16select.c (Fx_selection_exists_p): Sync doc string and
9317 argument list with xselect.c. (Bug#10783)
90b671e2 9318
49241268
GM
93192012-02-10 Glenn Morris <rgm@gnu.org>
9320
9321 * fns.c (Fsecure_hash): Doc fix.
9322
f998bbe7 93232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9324
9325 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9326
0992bd9c
CY
93272012-02-07 Chong Yidong <cyd@gnu.org>
9328
9329 * buffer.c (Fbuffer_local_variables)
9330 (buffer_lisp_local_variables): Handle unbound vars correctly;
9331 don't let Qunbound leak into Lisp.
9332
af008560
GM
93332012-02-07 Glenn Morris <rgm@gnu.org>
9334
dd605cc4
GM
9335 * image.c (Fimagemagick_types): Doc fix.
9336
af008560
GM
9337 * image.c (imagemagick-render-type): Change it from a lisp object
9338 to an integer. Move the doc here from the lisp manual.
9339 Treat all values not equal to 0 the same.
9340
1449fa1d
CY
93412012-02-06 Chong Yidong <cyd@gnu.org>
9342
9343 * doc.c (store_function_docstring): Avoid applying docstring of
9344 alias to base function (Bug#2603).
9345
3723ec07
AS
93462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9347
9348 * .gdbinit (pp1, pv1): Remove redundant defines.
9349 (pr): Use pp.
9350
79c1cc1e
CY
93512012-02-04 Chong Yidong <cyd@gnu.org>
9352
9353 * nsterm.m: Declare a global (Bug#10694).
9354
d7f29f8e
EZ
93552012-02-04 Eli Zaretskii <eliz@gnu.org>
9356
cae07000
SM
9357 * w32.c (get_emacs_configuration_options):
9358 Include --enable-checking, if specified, in the return value.
d7f29f8e 9359
3b95a6f9
MR
93602012-02-04 Martin Rudalics <rudalics@gmx.at>
9361
9362 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9363 after rounding frame sizes. (Bug#9723)
9364
d6fa96a6
EZ
93652012-02-04 Eli Zaretskii <eliz@gnu.org>
9366
9367 * keyboard.c (adjust_point_for_property): Don't position point
9368 before BEGV. (Bug#10696)
9369
df0b2940
PE
93702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9371
9372 Handle overflow when computing char display width (Bug#9496).
9373 * character.c (char_width): Return EMACS_INT, not int.
9374 (char_width, c_string_width): Check for overflow when
9375 computing the width; this is possible now that individual
9376 characters can have unbounded width. Problem introduced
9377 by merge from Emacs 23 on 2012-01-19.
9378
6bee44d6
MA
93792012-02-02 Michael Albinus <michael.albinus@gmx.de>
9380
9381 * dbusbind.c (Fdbus_register_method): Mention the return value
9382 :ignore in the docstring.
9383
44f92739
GM
93842012-02-02 Glenn Morris <rgm@gnu.org>
9385
1b9f60cc
GM
9386 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9387
44f92739
GM
9388 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9389 Unconditionally set to t. (Bug#10673)
9390 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9391 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9392 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9393
c5d3843c
KH
93942012-02-02 Kenichi Handa <handa@m17n.org>
9395
9396 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9397 0, do not call append_composite_glyph.
9398
159462d4 93992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9400
9401 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9402 NULL (Bug#6988).
9403 (x_produce_glyphs): If the component of a composition is a null
9404 string, set it->pixel_width to 1 to avoid zero-width glyph.
9405
78cef877
EZ
94062012-02-01 Eli Zaretskii <eliz@gnu.org>
9407
9408 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9409 first 2 arguments are identical. This makes inserting large
9410 output from a subprocess an order of magnitude faster on
9411 MS-Windows, where all sbrk'ed memory is always contiguous.
9412
97897668
GM
94132012-01-31 Glenn Morris <rgm@gnu.org>
9414
9415 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9416 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9417 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9418
31fd3586
GM
94192012-01-29 Glenn Morris <rgm@gnu.org>
9420
9421 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9422
0e24a8b2
CY
94232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9424
9425 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9426
cc0adcb0
CY
94272012-01-28 Chong Yidong <cyd@gnu.org>
9428
9429 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9430
acc28cb9
CY
94312012-01-26 Chong Yidong <cyd@gnu.org>
9432
9c69cfb7
CY
9433 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9434
acc28cb9
CY
9435 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9436 repeat counts (Bug#10507).
9437
48da7392
GM
94382012-01-26 Glenn Morris <rgm@gnu.org>
9439
9440 * lread.c (syms_of_lread): Doc fix.
9441
14af5f7f
CY
94422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9443
9444 * coding.c (encode_designation_at_bol): Change return value to
9445 EMACS_INT.
9446
0b21c100
CY
94472012-01-25 Chong Yidong <cyd@gnu.org>
9448
9449 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9450
3c2907f7
CY
94512012-01-21 Chong Yidong <cyd@gnu.org>
9452
9453 * floatfns.c (Fcopysign): Make the second argument non-optional,
9454 since nil is not allowed anyway.
9455
959ad23f
AS
94562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9457
9458 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9459 (send_process): Likewise.
9460
34a02f46
MR
94612012-01-19 Martin Rudalics <rudalics@gmx.at>
9462
9463 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9464 (Vwindow_persistent_parameters): Do not use Qstate.
9465 Rewrite doc-strings.
34a02f46 9466
1259009a 94672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9468
9469 * character.c (char_width): New function.
70d4fdf6
GM
9470 (Fchar_width, c_string_width, lisp_string_width):
9471 Use char_width (Bug#9496).
25ed9e61 9472
6a6ee00d
MR
94732012-01-16 Martin Rudalics <rudalics@gmx.at>
9474
9475 * window.c (Vwindow_persistent_parameters): New variable.
9476 (Fset_window_configuration, save_window_save): Handle persistent
9477 window parameters.
9478
c85efaf7
EZ
94792012-01-14 Eli Zaretskii <eliz@gnu.org>
9480
9481 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9482 thrashing the stack of the thread. (Bug#9087)
9483
5944709e
PE
94842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9485
9486 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9487
e71f5d99
EZ
94882012-01-11 Eli Zaretskii <eliz@gnu.org>
9489
9490 * xdisp.c (rows_from_pos_range): Handle the case where the
9491 highlight ends on a newline. (Bug#10464)
9492 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9493 he end column for display of highlight that ends on a newline
9494 before a R2L line.
9495
ce316182
GM
94962012-01-11 Glenn Morris <rgm@gnu.org>
9497
9498 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9499 from load-path also when installation-directory is nil. (Bug#10208)
9500
5b43da69
GM
95012012-01-10 Glenn Morris <rgm@gnu.org>
9502
74cc8ff9
GM
9503 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9504
7d8d6e4e
GM
9505 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9506 Update template values to be closer to their typical values these days.
5b43da69 9507
a0db8d43
EZ
95082012-01-09 Eli Zaretskii <eliz@gnu.org>
9509
9510 * xdisp.c (rows_from_pos_range): Accept additional argument
9511 DISP_STRING, and accept any glyph in a row whose object is that
9512 string as eligible for mouse highlight. Fixes mouse highlight of
9513 display strings from overlays. (Bug#10464)
9514
9a0115ab 95152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9516
b9110d6a 9517 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9518 * fileio.c (auto_saving_dir_umask): New static var.
9519 (Fmake_directory_internal): Use it.
9520 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9521 creating the directory. The old code temporarily assigns
9522 too-generous permissions to the directory.
9523 (do_auto_save_eh): Clear it.
b9110d6a 9524 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9525 that the var is always cleared.
9526
6c1bd3f3
EZ
95272012-01-07 Eli Zaretskii <eliz@gnu.org>
9528
9529 * search.c (scan_buffer): Pass character positions to
9530 know_region_cache, not byte positions. (Bug#6540)
9531
069d2b50
L
95322012-01-07 LynX <_LynX@bk.ru> (tiny change)
9533
9534 * w32.c (sys_rename): Report EXDEV when rename of a directory
9535 fails because the target is on another logical disk. (Bug#10284)
9536
75bf0d33
DB
95372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9538
9539 * xterm.c (x_embed_request_focus): New function.
9540
9541 * xterm.h: Add prototype.
9542
9543 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9544
1c6e5a32
GM
95452012-01-05 Glenn Morris <rgm@gnu.org>
9546
9547 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9548
651e947e
EZ
95492012-01-01 Eli Zaretskii <eliz@gnu.org>
9550
9551 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9552 Load gnutls_transport_set_lowat only if GnuTLS version is below
9553 2.11.1.
9554 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9555 GnuTLS versions below 2.11.1.
9556
3778cdd8
AL
95572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9558
9559 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9560 to the doc string advising against its use for altering the way
9561 windows are scrolled.
9562
0e5317f7
KH
95632011-12-28 Kenichi Handa <handa@m17n.org>
9564
9565 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9566 coding-system ASCII compatible only when it does not produce BOM
9567 on encoding (Bug#10383).
9568
93d5ca1f
JD
95692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9570
9571 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9572 can scroll.
9573 (create_and_show_popup_menu): Always use menu_position_func for
9574 Gtk3 (Bug#10361).
9575
ca22b785
AS
95762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9577
9578 * callint.c (Fcall_interactively): Don't truncate prompt string.
9579
d048e1e6
EZ
95802011-12-23 Eli Zaretskii <eliz@gnu.org>
9581
9582 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9583 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9584 resumed from there (after widening). (Bug#10360)
d048e1e6 9585
5ccaba1f
JD
95862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9587
9588 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9589
204ee57f
JD
95902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9591
b81d40f0
JB
9592 * nsterm.m (x_free_frame_resources):
9593 Release f->output_data.ns->miniimage.
204ee57f
JD
9594 (ns_index_color): Fix indentation. Do not retain
9595 color_table->colors[i].
9596
9597 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9598 before returning.
9599
9600 * nsfns.m (x_set_background_color): Assign return value from
9601 ns_index_color to face-background instead of NSColor*.
9602 (ns_implicitly_set_icon_type): Fix indentation.
9603 Change assignment in for loop to comparison.
9604
9605 * emacs.c (ns_pool): New variable.
9606 (main): Assign ns_pool.
9607 (Fkill_emacs): Call ns_release_autorelease_pool.
9608
9609 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9610 autorelease fdesc, release fdAttrs and tdict.
9611 (ns_get_covering_families): Release charset.
9612 (ns_findfonts): Release NSFontDescriptor created with new.
9613 (ns_uni_to_glyphs): Fix indentation.
9614 (setString): Release attrStr before assigning new value.
9615
c803b2b7
JD
96162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9617
678f4426
JD
9618 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9619 and NS_IMPL_COCOA.
9620 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9621 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9622
cd394be1 96232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9624
5fecd5fc
JD
9625 * nsterm.m (ns_term_init): Subscribe for notifications
9626 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9627 to method trackingNotification in EmacsMenu.
9628
9629 * nsmenu.m (trackingMenu): New variable.
3771cb17 9630 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9631 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9632 from Aquamacs (Bug#7030).
678f4426
JD
9633
96342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9635
c803b2b7
JD
9636 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9637 (symbol_to_nsstring): Fix indentation.
9638 (ns_symbol_to_pb): New function.
cae07000
SM
9639 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9640 (Fns_rotate_cut_buffers_internal): Remove.
9641 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9642 Fns_store_cut_buffer_internal.
9643 (ns_get_foreign_selection, Fx_own_selection_internal)
9644 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9645 (Fns_get_selection_internal, Fns_store_selection_internal):
9646 Use ns_symbol_to_pb and check if return value is nil.
9647 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9648 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9649 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9650 renamed to Sns_store_selection_internal.
9651 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9652 and remove this function.
9653 (ns_handle_selection_clear): Remove, never used.
9654 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9655 here.
9656
e1b01a3a
KB
96572011-12-17 Ken Brown <kbrown@cornell.edu>
9658
9659 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9660 GID is unknown (Bug#10257).
9661
2adb6e85
PE
96622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9663
9664 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9665 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9666 which caused a build failure on GNU/Linux IA-64. This problem was
9667 introduced by my 2011-10-07 patch.
9668
d1d7b339
JL
96692011-12-15 Juri Linkov <juri@jurta.org>
9670
9671 * image.c (imagemagick_error): New function. (Bug#10112)
9672 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9673 Use `imagemagick_error' where ImageMagick functions return
9674 `MagickFalse'.
9675 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9676 proper order.
9677
100d5755
KH
96782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9679
9680 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9681 fill background (Bug#8992).
9682
454592a6
MR
96832011-12-13 Martin Rudalics <rudalics@gmx.at>
9684
9685 * window.c (Vwindow_combination_resize)
9686 (Vwindow_combination_limit): Use t instead of non-nil in
9687 doc-strings.
61d4b438
MR
9688 (Vrecenter_redisplay): Add first sentence of doc-string on
9689 separate line.
53524d93 9690 (Frecenter): Fix doc-string typo.
454592a6 9691
3633e3aa
KH
96922011-12-11 Kenichi Handa <handa@m17n.org>
9693
9694 * coding.c (Funencodable_char_position): Pay attention to the
9695 buffer text relocation (Bug#9389).
9696
7b9d523a 96972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9698
7b9d523a
JD
9699 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9700 gtk_init (Bug#10100).
9701
b73189c6
EZ
97022011-12-10 Eli Zaretskii <eliz@gnu.org>
9703
9704 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9705 IT->string is nil. (Bug#10263)
9706
f7dfe5d6
JD
97072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9708
83faebb4
JD
9709 * nsterm.h (x_free_frame_resources): Declare.
9710
f7dfe5d6
JD
9711 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9712 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9713
9714 * nsterm.h (ns_get_defaults_value): Declare.
9715
9716 * nsterm.m (ns_default): Call ns_get_defaults_value.
9717
7cd4e72c
EZ
97182011-12-09 Eli Zaretskii <eliz@gnu.org>
9719
9720 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9721 (Bug#10170)
9722
b34d7317
YM
97232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9724
9725 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9726 that where the value of an _OBJC_* symbol points to is in the .bss
9727 section (Bug#10240).
9728
76470ad1
KH
97292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9730
9731 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9732 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9733
745fff94
KH
97342011-12-08 Kenichi Handa <handa@m17n.org>
9735
9736 * ftfont.c (get_adstyle_property): Fix previous change
9737 (Bug#10233).
9738
6e44397c
JB
97392011-12-07 Juanma Barranquero <lekktu@gmail.com>
9740
9741 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9742 dirs from the default value of EMACSLOADPATH (bug#10208).
9743
7efa6272
GM
97442011-12-07 Glenn Morris <rgm@gnu.org>
9745
9746 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9747 installation and source directories as well. (Bug#10208)
9748
f6fc4d87
CY
97492011-12-06 Chong Yidong <cyd@gnu.org>
9750
9751 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9752
2bf26180
GM
97532011-12-06 Glenn Morris <rgm@gnu.org>
9754
9755 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9756 as an error, not just -1. (Bug#10217)
9757
3a6ad4f0
CY
97582011-12-05 Chong Yidong <cyd@gnu.org>
9759
9760 * keyboard.c (process_special_events): New function.
9761 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9762
75a3b399
PE
97632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9764
9765 * coding.c (encode_designation_at_bol): Don't use uninitialized
9766 local variable (Bug#9318).
9767
c3c9e25e
KH
97682011-12-05 Kenichi Handa <handa@m17n.org>
9769
9770 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9771 return Qnil (Bug#8046, Bug#10193).
9772
5eb05ea3
KH
97732011-12-05 Kenichi Handa <handa@m17n.org>
9774
9775 * coding.c (encode_designation_at_bol): New args charbuf_end and
9776 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9777 (coding_set_source): Return how many bytes coding->source was
9778 relocated.
9779 (coding_set_destination): Return how many bytes
9780 coding->destination was relocated.
9781 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9782 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9783
97842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9785
9786 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9787 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9788 macro (Bug#9318).
9789
97902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9791
9792 The following changes are to fix Bug#9318.
9793
a79703f5 9794 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9795 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9796 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9797 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9798
7dbda6df
JB
97992011-12-05 Juanma Barranquero <lekktu@gmail.com>
9800
9801 * lisp.h (process_quit_flag): Fix external declaration.
9802
6d5eb5b0
SM
98032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9804
9805 Don't macro-inline non-performance-critical code.
9806 * eval.c (process_quit_flag): New function.
9807 * lisp.h (QUIT): Use it.
9808
a0c3fad0
JD
98092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9810
9811 * nsfns.m (get_geometry_from_preferences): New function.
9812 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9813
6c07aac2
AS
98142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9815
9816 * emacs.c (Qkill_emacs): Define.
9817 (syms_of_emacs): Initialize it.
9818 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9819 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9820 (quit_throw_to_read_char): Add parameter `from_signal'.
9821 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9822 * lisp.h (QUIT): Call Fkill_emacs if requested.
9823
c052ead4
JD
98242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9825
9826 * widget.c (update_wm_hints): Return if wmshell is null.
9827 (widget_update_wm_size_hints): New function.
9828
9829 * widget.h (widget_update_wm_size_hints): Declare.
9830
9831 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9832 widget_update_wm_size_hints (Bug#10104).
9833
9e49252b
EZ
98342011-12-03 Eli Zaretskii <eliz@gnu.org>
9835
9836 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9837 before a newline, prepare the bidi iterator for consuming the
9838 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9839 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9840
02b16839
JL
98412011-12-02 Juri Linkov <juri@jurta.org>
9842
9843 * search.c (Fword_search_regexp): New Lisp function created from
9844 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9845 (Fword_search_backward, Fword_search_forward)
9846 (Fword_search_backward_lax, Fword_search_forward_lax):
9847 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9848 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9849
0068070e
SM
98502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9851
9852 * fileio.c (Finsert_file_contents): Move after-change-function call
9853 to before the "handled:" label, since all "goto handled" appear in
9854 cases where the *-change-functions have already been properly called
9855 (bug#10117).
9856
3360a3fc
AS
98572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9858
9859 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9860 waiting for input. (Bug#10169)
9861
73d6c093
EZ
98622011-11-30 Eli Zaretskii <eliz@gnu.org>
9863
9864 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9865 verifies glyph row's hash code--we have just reallocated the
9866 glyphs, so their contents can be complete garbage. (Bug#10164)
9867
febe6bea
JB
98682011-11-30 Juanma Barranquero <lekktu@gmail.com>
9869
9870 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9871
801a4313
EZ
98722011-11-30 Eli Zaretskii <eliz@gnu.org>
9873
9874 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9875 attributes are tested _before_ calling verify_row_hash, to protect
9876 against GCC re-ordering of the tests. (Bug#10164)
9877
2b56b87e
JD
98782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9879
9880 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9881
9882 * xterm.c (handle_one_xevent): Only set async_visible and friends
9883 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9884 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9885 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9886
dbf31225
PE
98872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9888
9889 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9890 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9891 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9892 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9893 All uses changed to use GCPRO1 etc.
9894 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9895 Revert to old implementation (i.e., before 2011-03-11).
9896
1305621b
YM
98972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9898
9899 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9900 of scroll runs so as to avoid assigning disabled bogus rows and
9901 unnecessary graphics copy operations.
9902
8c9afb46
EZ
99032011-11-27 Eli Zaretskii <eliz@gnu.org>
9904
9905 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9906 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9907 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9908 (malloc, free, realloc, calloc): Redirect to e_* only when
9909 compiling Emacs.
9910
9911 * lisp.h (GCTYPEBITS): Move before first use.
9912 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9913 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9914 this macro definition.
9915
9916 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9917 _MSC_VER.
9918
54e9e3bf
JD
99192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9920
6d5eb5b0
SM
9921 * gtkutil.c (xg_create_frame_widgets):
9922 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9923 present with Gtk+ 2.0.
9924
83aca1cb
PE
99252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9926
9927 * fileio.c (Finsert_file_contents): Undo previous change; see
9928 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9929
5b76caa4
PE
99302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9931
9932 Rename locals to avoid shadowing.
9933 * fileio.c (Finsert_file_contents):
9934 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9935 * process.c (wait_reading_process_output):
9936 Rename inner 'proc' to 'p' to avoid shadowing.
9937 Indent for consistency with usual Emacs style.
9938
8c535114
EZ
99392011-11-25 Eli Zaretskii <eliz@gnu.org>
9940
9941 * xdisp.c (redisplay_window): If cursor row is not fully visible
9942 after recentering, and scroll-conservatively is set to a large
9943 number, scroll window by a few more lines to make the cursor fully
9944 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9945 (start_display): Don't move to the next line if the display should
9946 start at a newline that is part of a display vector or an overlay
9947 string. (Bug#10119)
8c535114 9948
fa4fdb5c
JL
99492011-11-24 Juri Linkov <juri@jurta.org>
9950
9951 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9952 after the `MagickPingImage' call. (Bug#10112)
9953
90ec88df
CY
99542011-11-23 Chong Yidong <cyd@gnu.org>
9955
9956 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9957
56e2e794
MR
99582011-11-23 Martin Rudalics <rudalics@gmx.at>
9959
9960 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9961 making another buffer current. (Bug#10114)
9962
b6e64c41
GM
99632011-11-23 Glenn Morris <rgm@gnu.org>
9964
9965 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9966
6b21de18
CY
99672011-11-23 Chong Yidong <cyd@gnu.org>
9968
9969 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9970 using it (Bug#5984).
9971
b12cd789
EZ
99722011-11-22 Eli Zaretskii <eliz@gnu.org>
9973
9974 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9975 and header-lines, as they don't have one computed for them.
9976 (Bug#10098)
9977
9978 * .gdbinit (prow): Make displayed values more self-explaining.
9979 Add row's hash code.
9980
261b6fd4
LMI
99812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9982
9983 * process.c (wait_reading_process_output): Fix asynchrounous
9984 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9985 (wait_reading_process_output): Add comment and URL.
261b6fd4 9986
e7cfd277
JD
99872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9988
9989 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9990
a9b9b7f5
CY
99912011-11-21 Chong Yidong <cyd@gnu.org>
9992
9993 * window.c (Fnext_window, Fprevious_window): Doc fix.
9994
b0d15b4f
SM
99952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9996
9997 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9998
fe7a3057
JB
99992011-11-20 Juanma Barranquero <lekktu@gmail.com>
10000
10001 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
10002
d2999b1a
MR
100032011-11-20 Martin Rudalics <rudalics@gmx.at>
10004
10005 * window.c (Fset_window_combination_limit): Rename argument
10006 STATUS to LIMIT.
10007 (Vwindow_combination_limit): Remove "status" from doc-string.
10008
d5ff9cd0
AS
100092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
10010
10011 * m/ibms390.h: Remove.
10012 * m/ibms390x.h: Don't include "ibms390.h".
10013
a5bb9bd3
SM
100142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10015
10016 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
10017 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
10018
cd1181db
JB
100192011-11-20 Juanma Barranquero <lekktu@gmail.com>
10020
10021 * casetab.c (Fset_case_table):
10022 * charset.c (Fcharset_after): Fix typos.
10023
615a3b8d 100242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 10025
17e845af
PE
10026 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
10027 Otherwise, valgrind does not work on some platforms.
10028 Problem reported by Andreas Schwab in
6a0bf43d
PE
10029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
10030 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
10031 is set, removing the need for VIRT_ADDRESS_VARIES.
10032 (PURE_P): Use a more-efficient implementation that needs just one
10033 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
10034 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
10035 to 4 (xorl, subq, cmpq, setbe).
10036 * alloc.c (pure): Always extern now, since that's the
10037 VIRT_ADDR_VARIES behavior.
10038 (PURE_POINTER_P): Use a single comparison, not two, for
10039 consistency with the new puresize.h.
10040 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
10041 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
10042 Remove VIRT_ADDR_VARIES no longer needed.
10043
f8fe6f96
EZ
100442011-11-19 Eli Zaretskii <eliz@gnu.org>
10045
10046 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
10047 (erase_phys_cursor, update_window_cursor, show_mouse_face)
10048 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
10049 behave as if the cursor position were at the window margin.
10050
10051 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
10052 and the cursor position is out of bounds, behave as if the cursor
10053 position were at the window margin. (Bug#10075)
10054
df05a53c
CY
100552011-11-18 Chong Yidong <cyd@gnu.org>
10056
10057 * window.c (Fwindow_combination_limit): Make first argument
10058 non-optional, since it is meaningless for live windows like the
10059 selected window.
61ccba97 10060
2071918e
DA
100612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
10062
10063 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
10064
b50a28de
SM
100652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
10066
10067 * intervals.c: Fix grafting over the whole buffer (bug#10071).
10068 (graft_intervals_into_buffer): Simplify.
10069
015137db
EZ
100702011-11-18 Eli Zaretskii <eliz@gnu.org>
10071
10072 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
10073 hash values of the two rows.
10074 (copy_row_except_pointers): Preserve the used[] arrays and the
10075 hash values of the two rows. (Bug#10035)
68c95424 10076 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
10077
10078 * xdisp.c (row_hash): New function, body extracted from
10079 compute_line_metrics.
10080 (compute_line_metrics): Call row_hash, instead of computing the
10081 hash code inline.
10082
10083 * dispnew.c (verify_row_hash): Call row_hash for computing the
10084 hash code of a row, instead of duplicating code from xdisp.c.
10085
10086 * dispextern.h (row_hash): Add prototype.
10087
a2addb04
TH
100882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
10089
10090 * frame.c (delete_frame): Don't delete the terminal when the last
10091 X frame is closed if emacs is built with GTK toolkit.
10092
df85d315
JB
100932011-11-17 Juanma Barranquero <lekktu@gmail.com>
10094
10095 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
10096
a0c2d0ae
MR
100972011-11-17 Martin Rudalics <rudalics@gmx.at>
10098
10099 * window.c (Vwindow_splits): Rename to
10100 Vwindow_combination_resize. Suggested by Juri Linkov.
10101 (Fsplit_window_internal): Use Vwindow_combination_resize instead
10102 of Vwindow_splits.
10103
58179cce
JB
101042011-11-16 Juanma Barranquero <lekktu@gmail.com>
10105
7877f373
JB
10106 * nsfns.m (Fns_font_name):
10107 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 10108
b6f67890
MR
101092011-11-16 Martin Rudalics <rudalics@gmx.at>
10110
10111 * window.h (window): Rename slot "nest" to "combination_limit".
10112 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10113 (Fset_window_nest): Rename to Fset_window_combination_limit.
10114 (Vwindow_nest): Rename to Vwindow_combination_limit.
10115 (recombine_windows, make_parent_window, make_window)
10116 (Fsplit_window_internal, saved_window)
10117 (Fset_window_configuration, save_window_save): Rename all
10118 occurrences of window_nest to window_combination_limit.
10119
c7015153
JB
101202011-11-15 Juanma Barranquero <lekktu@gmail.com>
10121
10122 * image.c (imagemagick_load_image): Fix typo.
10123
322ad6ec
EZ
101242011-11-14 Eli Zaretskii <eliz@gnu.org>
10125
10126 * xdisp.c (display_line): Move the call to
10127 highlight_trailing_whitespace before the call to
10128 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
10129 faces of all the glyphs to compute ROW's hash value.
10130 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 10131
f067b8ec
JB
101322011-11-14 Juanma Barranquero <lekktu@gmail.com>
10133
10134 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
10135 just return (bug#10044).
10136
1e5b2111
EZ
101372011-11-12 Eli Zaretskii <eliz@gnu.org>
10138
7ef3cbd5
EZ
10139 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
10140 with user-defined heap size. Bump the default size of the temacs
10141 heap to 27MB, to avoid memory warning when running temacs.
10142 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
10143
1e5b2111
EZ
10144 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
10145 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
10146 (verify_row_hash) [XASSERTS]: New function.
10147 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
10148 that the hash value of glyph rows is correct.
1e5b2111 10149
89d61221
MR
101502011-11-12 Martin Rudalics <rudalics@gmx.at>
10151
10152 * window.h (window): Remove splits slot.
10153 * window.c (Fwindow_splits, Fset_window_splits): Remove.
10154 (Fdelete_other_windows_internal, make_parent_window)
10155 (make_window, Fsplit_window_internal, Fdelete_window_internal)
10156 (Fset_window_configuration, save_window_save): Don't deal with
10157 split status of windows.
10158 (saved_window): Remove splits slot.
10159 (Vwindow_splits): Rewrite doc-string.
10160
97f18cc8
JD
101612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
10162
10163 * xfns.c (unwind_create_frame):
10164 * nsfns.m (unwind_create_frame):
10165 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
10166 Vframe_list (Bug#9999).
10167
22a648b4
DA
101682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10169
0b381c7e 10170 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 10171
659afede
KH
101722011-11-11 Kenichi Handa <handa@m17n.org>
10173
10174 * callproc.c (Fcall_process): Set the member dst_multibyte of
10175 process_coding.
10176
9ac0394b
KH
101772011-11-11 Johan Bockgård <bojohan@gnu.org>
10178
10179 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
10180 avoid a crash (bug#9496).
10181
2fbdc249
CY
101822011-11-09 Chong Yidong <cyd@gnu.org>
10183
10184 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
10185 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
10186
ac6b1f81
PE
101872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10188
10189 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
10190
09db192c
PE
101912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10192
10193 Avoid some portability problems by eschewing 'extern inline' functions.
10194 The trivial performance wins aren't worth the portability hassles; see
10195 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
10196 et seq.
10197 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10198 (window_box_width, window_box_left, window_box_left_offset)
10199 (window_box_right, window_box_right_offset): Undo previous change,
10200 by removing the "extern"s.
10201 * intervals.c (adjust_intervals_for_insertion)
10202 (adjust_intervals_for_deletion): Undo previous change,
10203 making these static again.
10204 (offset_intervals, temp_set_point_both, temp_set_point)
10205 (copy_intervals_to_string): No longer inline.
10206 * xdisp.c (window_text_bottom_y, window_box_width)
10207 (window_box_height, window_box_left_offset)
10208 (window_box_right_offset, window_box_left, window_box_right)
10209 (window_box): No longer inline.
10210
105216ed
CY
102112011-11-08 Chong Yidong <cyd@gnu.org>
10212
10213 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
10214 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10215 Signal an error if not a live window.
105216ed
CY
10216 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10217 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10218
ae9e237f
JB
102192011-11-07 Juanma Barranquero <lekktu@gmail.com>
10220
10221 * lisp.h (syms_of_abbrev): Remove declaration.
10222 Reported by CHENG Gao <chenggao@royau.me>.
10223
c7aa8333
EZ
102242011-11-07 Eli Zaretskii <eliz@gnu.org>
10225
10226 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10227 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10228 of temacs in GUI mode.
10229
be7f5545
MR
102302011-11-07 Martin Rudalics <rudalics@gmx.at>
10231
10232 * window.h: Declare delete_all_child_windows instead of
10233 delete_all_subwindows.
10234 * window.c (Fwindow_nest, Fset_window_nest)
10235 (Fset_window_new_total, Fset_window_new_normal)
10236 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10237 (delete_all_subwindows): Rename to delete_all_child_windows.
10238 (Fdelete_other_windows_internal, Fset_window_configuration):
10239 Call delete_all_child_windows instead of delete_all_subwindows.
10240 * frame.c (delete_frame): Call delete_all_child_windows instead
10241 of delete_all_subwindows.
10242
ca78dc43
PE
102432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10244
10245 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10246 This is also needed for porting to any host where GC_MARK_STACK is
10247 not GC_MAKE_GCPROS_NOOPS.
10248 (which_symbols): Use it.
10249
a0241d01
KH
102502011-11-07 Kenichi Handa <handa@m17n.org>
10251
10252 * coding.c (coding_set_destination): Check coding->src_pos only
10253 when coding->src_object is a buffer (bug#9910).
10254
10255 * process.c (send_process): Set the member src_multibyte of coding
10256 to 0 (bug#9911) when sending a unibyte text.
10257
10258 * callproc.c (Fcall_process): Set the member src_multibyte of
10259 process_coding to 0 (bug#9912).
10260
a64bfdfa 102612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10262
10263 * xmenu.c (cleanup_widget_value_tree): New function.
10264 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10265 calling free_menubar_widget_value_tree directly (Bug#9830).
10266
cb41b32a
PE
102672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10268
10269 Fix some portability problems with 'inline'.
10270 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10271 (window_box_width, window_box_left, window_box_left_offset)
10272 (window_box_right, window_box_right_offset): Declare extern.
10273 Otherwise, these inline functions do not conform to C99 and
10274 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10275 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10276 * intervals.c (adjust_intervals_for_insertion)
10277 (adjust_intervals_for_deletion): Now extern, because otherwise the
10278 extern inline functions 'offset_intervals' couldn't refer to it.
10279 (static_offset_intervals): Remove.
10280 (offset_intervals): Rewrite using the old contents of
10281 static_offset_intervals. The old version didn't conform to C99
10282 because an extern inline function contained a reference to an
10283 identifier with static linkage.
10284
b7041366
AS
102852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10286
10287 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10288 GC.
10289
88a37c4d
EZ
102902011-11-06 Eli Zaretskii <eliz@gnu.org>
10291
10292 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10293 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10294 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10295 return Qleft_to_right.
10296
49745b39
CY
102972011-11-06 Chong Yidong <cyd@gnu.org>
10298
10299 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10300 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10301 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10302 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10303 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10304 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10305 (Fwindow_vscroll): Doc fix.
10306 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10307 argument, since it makes no sense to pass a live window and for
10308 consistency with window-child.
10309
1f05cd82
CS
103102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10311
10312 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10313 support MSVC.
10314
22610910
JR
103152011-11-05 Jason Rumney <jasonr@gnu.org>
10316
10317 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10318 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10319 fonts (Bug#6029).
10320 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10321 bitwise arithmetic preventing use of unicode-sip and non-truetype
10322 opentype fonts.
10323
a06776b2
EZ
103242011-11-05 Eli Zaretskii <eliz@gnu.org>
10325
3ad924ba
EZ
10326 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10327 "emacs"-only part.
10328
a06776b2
EZ
10329 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10330 initialization code to keep similarity to xfns.c after changes
10331 from 2011-11-05.
10332
c9e7db78
JD
103332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10334
a97f8f3f
JD
10335 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10336 (unwind_create_frame): New function (Bug#9943).
10337 (Fx_create_frame): Restructure code to be more similar to the one in
10338 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10339 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10340 Move terminal->reference_count++ just before making the frame official
10341 (Bug#9943).
10342
10343 * nsterm.m (x_free_frame_resources): New function.
10344 (x_destroy_window): Move code to x_free_frame_resources.
10345
c9e7db78 10346 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10347 (Fx_create_frame, x_create_tip_frame):
10348 Move terminal->reference_count++ just before making the frame
75f1671a 10349 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10350 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10351
a6fc3b5c
EZ
103522011-11-05 Eli Zaretskii <eliz@gnu.org>
10353
10354 Support MSVC build with newer versions of Visual Studio.
10355 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10356 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10357 nt/gmake.defs.
10358
10359 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10360 which are not supported by MSVC.
10361 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10362 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10363 bitfields.
10364 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10365 types in bitfields.
10366 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10367
10368 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10369
58179cce 103702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10371
10372 Support MSVC build with newer versions of Visual Studio.
10373 * w32.c: Don't include w32api.h for MSVC.
10374 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10375
10376 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10377 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10378 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10379 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10380 e_* cousins.
10381 (alloca) [_MSC_VER]: Define to _alloca.
10382
10383 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10384
10385 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10386
a58c13ed
EZ
103872011-11-04 Eli Zaretskii <eliz@gnu.org>
10388
10389 * xdisp.c (note_mouse_highlight): If either of
10390 previous/next-single-property-change returns nil, treat that as
10391 the beginning or the end of the buffer. (Bug#9955)
10392
fe0b6370
JD
103932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10394
a58c13ed 10395 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10396 label is not null (Bug#9951).
10397 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10398 may be NULL.
10399
89bd5ee1
EZ
104002011-11-04 Eli Zaretskii <eliz@gnu.org>
10401
10402 * window.c (Fwindow_body_size): Mention in the doc string that the
10403 return value is in frame's canonical units. (Bug#9949)
10404
84c3edb9
EZ
104052011-11-03 Eli Zaretskii <eliz@gnu.org>
10406
4e2fb5c7
EZ
10407 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10408
84c3edb9 10409 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10410 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10411 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10412
bc17a887
EZ
104132011-11-01 Eli Zaretskii <eliz@gnu.org>
10414
10415 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10416 Don't stop backward scan on the continuation glyph, even though
10417 its CHARPOS is positive.
6d5eb5b0
SM
10418 (mouse_face_from_buffer_pos, note_mouse_highlight):
10419 Rename cover_string to disp_string.
bc17a887 10420
4ee88440
MR
104212011-11-01 Martin Rudalics <rudalics@gmx.at>
10422
10423 * window.c (temp_output_buffer_show): Don't use
10424 Vtemp_buffer_show_specifiers.
10425 (Vtemp_buffer_show_specifiers): Remove unused variable.
10426
c2ff3c02
EZ
104272011-10-30 Eli Zaretskii <eliz@gnu.org>
10428
10429 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10430 past the beginning of the current glyph matrix.
10431
58179cce 104322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10433
10434 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10435 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10436 HAVE_GTK3 (Bug#9869).
b77a6a7f 10437
3b574623
JD
10438 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10439 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10440
b77a6a7f
JD
10441 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10442
10443 * xterm.c: Declare x_handle_net_wm_state to return int.
10444 (handle_one_xevent): Check if we are iconified but don't have
10445 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10446 (get_current_wm_state): Return non-zero if not hidden,
10447 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10448 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10449 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10450 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10451
196e41e4
PE
104522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10453
10454 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10455 so that this new function doesn't get optimized away by a
10456 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10457
021f2e1a
AS
104582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10459
10460 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10461
8b058d44
EZ
104622011-10-29 Eli Zaretskii <eliz@gnu.org>
10463
10464 Fix the `xbytecode' command.
10465 * .gdbinit (xprintbytestr): New command.
b50a28de 10466 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10467 (xbytecode): Print the byte-code string as well.
10468
4452fb80
EZ
104692011-10-29 Kim Storm <storm@cua.dk>
10470
8b058d44
EZ
10471 * alloc.c (which_symbols): New function.
10472
21b72067
AS
104732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10474
10475 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10476 line. (Bug#9903)
10477
83ed7b5c
GM
104782011-10-29 Glenn Morris <rgm@gnu.org>
10479
10480 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10481 Not clear what it was for, and it causes various bugs. (Bug#9839)
10482
5a7a728b
EZ
104832011-10-28 Eli Zaretskii <eliz@gnu.org>
10484
10485 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10486 possible random value that matches one of those tested as
10487 condition to clear the mouse face.
10488
d3d0842f
CY
104892011-10-28 Chong Yidong <cyd@gnu.org>
10490
10491 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10492
31b39d13
DN
104932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10494
10495 * window.c (make_window): Initialize phys_cursor_on_p.
10496
9aba6043
SM
104972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10498
10499 * lisp.h (struct Lisp_Symbol): Update comments.
10500
c20992f4
JB
105012011-10-28 Juanma Barranquero <lekktu@gmail.com>
10502
10503 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10504
db4f02f2
EZ
105052011-10-28 Eli Zaretskii <eliz@gnu.org>
10506
10507 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10508 <oslsachem@gmail.com> for helping to debug this.
10509
10510 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10511 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10512 (g_b_init_get_glyph_outline_w): New static variables.
10513 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10514 (GetGlyphOutlineW_Proc): New typedefs.
10515 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10516 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10517 New functions.
10518 (w32font_open_internal, compute_metrics):
10519 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10520 instead of calling the "wide" APIs directly.
10521
10522 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10523
10524 * w32.h (syms_of_w32font): Add prototype.
10525
87e68db4
JB
105262011-10-27 Juanma Barranquero <lekktu@gmail.com>
10527
10528 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10529 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10530 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10531 (Fmove_to_window_line): Doc fix.
10532
435c1d67
CY
105332011-10-27 Chong Yidong <cyd@gnu.org>
10534
10535 * process.c (make_process): Set gnutls_state to NULL.
10536
10537 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10538 non-NULL, regardless of GNUTLS_INITSTAGE.
10539 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10540 an error. Set process slots as soon as we allocate them.
10541
10542 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10543
9c6c6f49
CY
105442011-10-27 Chong Yidong <cyd@gnu.org>
10545
9aba6043
SM
10546 * gnutls.c (emacs_gnutls_deinit): New function.
10547 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10548 (Fgnutls_deinit, Fgnutls_boot): Use it.
10549
10550 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10551 (deactivate_process): Call emacs_gnutls_deinit.
10552
657d08d3
JB
105532011-10-27 Juanma Barranquero <lekktu@gmail.com>
10554
10555 * image.c (x_create_x_image_and_pixmap):
10556 * w32.c (sys_rename, w32_delayed_load):
10557 * w32font.c (fill_in_logfont):
10558 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10559
5430d399
JB
105602011-10-26 Juanma Barranquero <lekktu@gmail.com>
10561
10562 * w32fns.c (w32_default_color_map): New function,
10563 extracted from Fw32_default_color_map.
a7ef684b 10564 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10565
fe0055fa
PE
105662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10567
10568 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10569
e6346438
SM
105702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10571
10572 * keyboard.c (test_undefined): New function (bug#9751).
10573 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10574
e112cc37
ET
105752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10576
10577 * sysdep.c (init_sys_modes): Fix the check for the controlling
10578 terminal (Bug#6649).
10579
7b5d6677
EZ
105802011-10-20 Eli Zaretskii <eliz@gnu.org>
10581
10582 * dispextern.h (struct bidi_it): New member next_en_type.
10583
10584 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10585 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10586 current character, check also for next_en_type being WEAK_EN.
10587 (bidi_resolve_weak): Don't enter the expensive loop if the current
10588 position is before next_en_pos. Record the bidi type of the first
10589 non-ET, non-BN character we find, in addition to its position.
10590 (bidi_level_of_next_char): Invalidate next_en_type when
10591 next_en_pos is over-stepped.
10592
7da0b018
PE
105932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10594
10595 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10596 * editfns.c: Rewrite current-time-zone so that it invokes
10597 the equivalent of (format-time-string "%Z") to get the time zone name.
10598 This fixes a bug when the time zone name contains characters that
10599 need converting from the system time locale to Emacs internal format.
10600 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10601 that patch fixed format-time-string to do the conversion, but
10602 I forgot to fix current-time-zone.
10603 (format_time_string): New function, containing most of
10604 what Fformat_time_string used to contain.
10605 (Fformat_time_string): Rewrite in terms of format_time_string.
10606 This doesn't change this function's behavior.
10607 (current-time-zone): Rewrite to use format_time_string.
10608 This fixes the bug reported by Michael Schierl in
10609 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10610 Jason Rumney's 2007-06-07 change worked around this bug, but
10611 didn't fix it.
10612 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10613
8547b010
EZ
106142011-10-19 Eli Zaretskii <eliz@gnu.org>
10615
10616 * xdisp.c (start_display): If the character at POS is displayed
10617 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10618 (try_window_reusing_current_matrix): If a line ends in a display
10619 vector or the next line starts in a display vector, continue
10620 redrawing the window even though the character position of
10621 start_row was reached.
8547b010
EZ
10622 (Bug#9771, part 2)
10623
4e948d15
CY
106242011-10-18 Chong Yidong <cyd@gnu.org>
10625
10626 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10627 with nobreak-char-display too.
10628
4787455f
EZ
106292011-10-18 Eli Zaretskii <eliz@gnu.org>
10630
10631 Fix part 3 of bug#9771.
10632 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10633 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10634 non-neutral characters if the current character is a paragraph
10635 separator (a.k.a. Newline). This avoids running the same
10636 expensive loop twice, once when we consume the preceding newline
10637 and the other time when the line actually needs to be displayed.
10638 Avoid the loop when we see neutrals on the base embedding level
10639 following a character whose directionality is the same as the
10640 paragraph's. This avoids running the expensive loop when a line
10641 ends in a long sequence of neutrals, like control characters.
10642 Add assertion against STRONG_AL type. Slightly rearrange code
10643 that determines the type of a neutral given the first non-neutral
10644 that follows it.
10645 (bidi_level_of_next_char): Set next_en_pos to zero when
10646 invalidating its info.
10647
2c91f553
EZ
106482011-10-17 Eli Zaretskii <eliz@gnu.org>
10649
10650 * xdisp.c (push_display_prop): Determine whether to record string
10651 or buffer position by IT->string, not by IT->method. Allow
10652 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10653 (move_it_vertically_backward): Don't look for character position
10654 immediately after the newline when in a continuation line.
10655 (Bug#9771, part 1)
2c91f553 10656
c7b08b0d
MR
106572011-10-15 Martin Rudalics <rudalics@gmx.at>
10658
10659 * window.c (coordinates_in_window): Rewrite and delabelize
10660 vertical border check. (Bug#5357) (Bug#9618)
10661
6b02f655
SM
106622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10663
10664 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10665 errors in XSetWindowBorder (bug#9310).
10666
81d40c92
DA
106672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10668
10669 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10670 avoid crash when xmalloc overrun checking is enabled.
10671
d4172c3b
EZ
106722011-10-13 Eli Zaretskii <eliz@gnu.org>
10673
10674 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10675 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10676 cursor motion with <left> and <right> arrow keys.
10677
10678 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10679 some callers set that themselves.
10680
b00eea75
EZ
106812011-10-12 Eli Zaretskii <eliz@gnu.org>
10682
10683 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10684 display string and the previous row comes from the same string and
10685 is empty. (Bug#9739) (Bug#9738)
10686
8fe012c4
SM
106872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10688
10689 * doc.c (get_doc_string): Encode file name (bug#9735).
10690
0074aef2
EZ
106912011-10-12 Eli Zaretskii <eliz@gnu.org>
10692
79beb178
EZ
10693 * bidi.c (bidi_level_of_next_char):
10694 * xdisp.c (get_visually_first_element): Remove old incorrect
10695 comments regarding the Unicode Line Separator character.
10696
0074aef2
EZ
10697 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10698
6e4b3fbe
DA
106992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10700
10701 * alloc.c (Fgc_status): Do not access beyond zombies array
10702 boundary if nzombies > MAX_ZOMBIES.
10703 * alloc.c (dump_zombies): Add missing format specifier.
10704
0324f3af
PE
107052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10706
b5525cac
PE
10707 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10708 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10709
0324f3af
PE
10710 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10711 Some packages use them to denote characters with modifiers.
10712
e9b5f888
AS
107132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10714
10715 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10716 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10717 matching a pp-number. Rename parameter var to var1.
10718
127827c0
SM
107192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10720
10721 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10722
c8fd3bd0
GM
107232011-10-08 Glenn Morris <rgm@gnu.org>
10724
10725 * callint.c (Fcall_interactively): Give a more explicit error for the
10726 'c' case with a non-character input. (Bug#8479)
10727
352ec8ff
EZ
107282011-10-08 Eli Zaretskii <eliz@gnu.org>
10729
03669ccb
EZ
10730 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10731 lines.
7061c986
EZ
10732 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10733 lines that are hscrolled on the left.
03669ccb 10734
352ec8ff
EZ
10735 * dispnew.c (buffer_posn_from_coords): Account for a possible
10736 presence of header-line. (Bug#4426)
10737
a66cfb1c
SM
107382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10739
6b02f655
SM
10740 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10741 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10742
7c5ee88e
PE
107432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10744
10745 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10746 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10747 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10748 this makes Emacs dump core during garbage collection on rare
10749 occasions. sizeof is obviously inferior to offsetof here, so
10750 stick with offsetof.
10751 (GC_POINTER_ALIGNMENT): New macro.
10752 (mark_memory): Omit 3rd (offset) arg; caller changed.
10753 Don't assume EMACS_INT alignment is the same as pointer alignment.
10754
df1bbe5b
SM
107552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10756
10757 * keyboard.c (read_key_sequence_remapped): New var.
10758 (read_key_sequence): Compute remapping in the right buffer.
10759 (command_loop_1): Use read_key_sequence's remapping directly.
10760
51553db6
SM
107612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10762
32c1fffd
SM
10763 * dired.c (file_name_completion): Don't expand file name.
10764 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10765 before checking file name handler.
10766
51553db6
SM
10767 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10768 they've been requested explicitly (bug#9591).
10769
b6bd1599 107702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10771
10772 * keymap.c (Fsingle_key_description): Use make_specified_string
10773 instead of build_string to build string from push_key_description.
10774 (Bug#5193)
10775
f701dc2a
PE
107762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10777
4222c55d
PE
10778 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10779 This fixes a Y2038 bug on 64-bit hosts.
10780 * buffer.c (reset_buffer):
10781 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10782 (Fclear_buffer_auto_save_failure):
10783 Use 0, not -1, to represent an unset failure time, since time_t
10784 might not be signed.
10785
f701dc2a
PE
10786 Remove dependency on glibc malloc internals.
10787 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10788 Move back here from lisp.h, but with their new implementations.
10789 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10790 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10791 * charset.c (charset_table_init): New static var.
10792 (syms_of_charset): Use it instead of xmalloc. This removes a
10793 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10794 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10795 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10796 Move back to alloc.c.
10797 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10798 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10799
9ceebf39
JD
108002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10801
10802 * nsterm.m (windowDidResize): Call x_set_window_size only when
10803 ns_in_resize is true. Otherwise set pixelwidth/height and
10804 call change_frame_size (Bug#9628).
10805
cb993c58
PE
108062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10807
3930c88b
PE
10808 Port --enable-checking=all to Fedora 14 x86-64.
10809 * charset.c (syms_of_charset): Also account for glibc malloc's
10810 internal overhead when calculating the initial malloc maximum.
10811
cb993c58
PE
10812 Port --enable-checking=all to Fedora 14 x86.
10813 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10814 Move to lisp.h.
10815 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10816 (overrun_check_realloc, overrun_check_free):
10817 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10818 That way, xmalloc returns a properly-aligned pointer even if
10819 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10820 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10821 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10822 into account when calculating the initial malloc maximum.
10823 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10824 Move here from alloc.c, so that charset.c can use it too.
10825 Properly align; the old code wasn't right for common 32-bit hosts
10826 when configured with --enable-checking=all.
10827 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10828 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10829
31bed486
EZ
108302011-09-29 Eli Zaretskii <eliz@gnu.org>
10831
04c70788 10832 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10833 use EDOM.
10834
fbcaa2f3
EZ
108352011-09-28 Eli Zaretskii <eliz@gnu.org>
10836
10837 * xdisp.c (compute_display_string_end): If there's no display
10838 string at CHARPOS, return -1.
10839
10840 * bidi.c (bidi_fetch_char): When compute_display_string_end
10841 returns a negative value, treat the character as a normal
10842 character not covered by a display string. (Bug#9624)
10843
a239d4e9
JB
108442011-09-28 Juanma Barranquero <lekktu@gmail.com>
10845
10846 * lread.c (Fread_from_string): Fix typo in docstring.
10847
88652fd5
EZ
108482011-09-27 Eli Zaretskii <eliz@gnu.org>
10849
10850 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10851 newline, reseat the iterator instead of bidi-iterating there one
10852 character at a time. (Bug#9610)
32c1fffd
SM
10853 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10854 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10855
ed497dd4
AS
108562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10857
10858 * lread.c (readevalloop): Use correct code for NBSP.
10859 (read1): Likewise. (Bug#9608)
10860
b2bf61aa
MA
108612011-09-25 Michael Albinus <michael.albinus@gmx.de>
10862
10863 * dbusbind.c (Fdbus_register_signal): When service is not
10864 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10865
32bbb17c
GM
108662011-09-25 Glenn Morris <rgm@gnu.org>
10867
10868 * buffer.c (truncate-lines): Doc fix.
10869
94e0933e
CY
108702011-09-24 Chong Yidong <cyd@stupidchicken.com>
10871
10872 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10873 (Fset_window_next_buffers): Doc fix.
10874
cddde921
GM
108752011-09-24 Glenn Morris <rgm@gnu.org>
10876
10877 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10878
1260aef1
PE
108792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10880
25b4bfa0
PE
10881 Fix minor problems found by static checking.
10882 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10883 * indent.c (Fvertical_motion): Fix == vs = typo.
10884
e3cbd34b
EZ
108852011-09-24 Eli Zaretskii <eliz@gnu.org>
10886
a66cfb1c
SM
10887 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10888 Default value is now t. Doc fix.
6bf7006f 10889
e3cbd34b 10890 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10891 logic when moving up, not only when moving down. Fix the
e3cbd34b 10892 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10893 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10894
10895 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10896 CHARPOS is covered by a display string which includes newlines.
10897 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10898 is covered by a display string with embedded newlines.
10899
a3de0cbd
MA
109002011-09-24 Michael Albinus <michael.albinus@gmx.de>
10901
10902 * dbusbind.c (Fdbus_register_signal): Add match rule to
10903 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10904 (Fdbus_register_method, Vdbus_registered_objects_table):
10905 Fix docstring.
a3de0cbd 10906
b260039d
JM
109072011-09-24 Jim Meyering <meyering@redhat.com>
10908
32c1fffd 10909 do not ignore write error for any output size
b260039d
JM
10910 The previous change was incomplete.
10911 While it makes emacs --batch detect the vast majority of stdout
10912 write failures, errors were still ignored whenever the output size is
10913 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10914 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10915 && echo FAIL: ignored write error
10916 FAIL: ignored write error
10917 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10918 && echo FAIL: ignored write error
10919 FAIL: ignored write error
10920 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10921
8eca8a7c
AS
109222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10923
10924 * emacs.c (Fkill_emacs): In noninteractive mode exit
10925 non-successfully if a write error occurred on stdout. (Bug#9574)
10926
3341db62
EZ
109272011-09-21 Eli Zaretskii <eliz@gnu.org>
10928
10929 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10930 the xassert test.
10931
10932 * dispextern.h (struct it): Update the comment documenting what
10933 can it->OBJECT be.
10934
8c203dbf
EZ
109352011-09-20 Eli Zaretskii <eliz@gnu.org>
10936
10937 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10938 a display string, extend search for cursor position to end of row.
10939 (find_row_edges): If the row ends in a newline from a display
10940 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10941 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10942 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10943 non-empty line. Fixes confusing cursor motion with arrow keys at
10944 the beginning of a line that starts with whitespace.
8c203dbf 10945
a4824228
LMI
109462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10947
10948 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10949 (bug#9493).
10950
33ed493b
CY
109512011-09-18 Chong Yidong <cyd@stupidchicken.com>
10952
10953 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10954 boolean (Bug#9154).
10955
56cd55c8
EZ
109562011-09-18 Eli Zaretskii <eliz@gnu.org>
10957
10958 * xdisp.c (display_line): Record maximum and minimum buffer
10959 positions even if no glyphs were produced (e.g., by a zero-width
10960 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10961 buffer positions that will be removed from the glyph row because
10962 they don't fit.
c02dcedf
EZ
10963 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10964 column is beyond frame width: don't subtract 1 "pixel" when
10965 computing width of the stretch.
3e62b7e0
EZ
10966 (reseat_at_next_visible_line_start): Undo the change made on
10967 2011-09-17 that saved paragraph information and restored it after
10968 the call to `reseat'. (Bug#9545)
56cd55c8 10969
5ed99d36 109702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10971
10972 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10973 and turn window cursor on if cleared (Bug#9415).
10974
5ed99d36 109752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10976
10977 * search.c (boyer_moore): Take unibyte characters from pattern
10978 literally. (Bug#9458)
10979
9bade7b2
EZ
109802011-09-18 Eli Zaretskii <eliz@gnu.org>
10981
10982 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10983
e5e9d610
PE
109842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10985
87e4427a
PE
10986 Fix minor problem found by static checking.
10987 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10988 initialized, to pacify gcc -Wuninitialized.
10989
e5e9d610
PE
10990 * fileio.c: Report proper errno when syscall falls.
10991 (Finsert_file_contents): Save and restore errno,
10992 so that report_file_error outputs the correct diagnostic.
10993 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10994
a1674f0b
EZ
109952011-09-18 Eli Zaretskii <eliz@gnu.org>
10996
10997 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10998
fbfb6dd4
EZ
109992011-09-17 Eli Zaretskii <eliz@gnu.org>
11000
11001 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
11002 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
11003
bb187662
EZ
110042011-09-17 Eli Zaretskii <eliz@gnu.org>
11005
1137e8b8 11006 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 11007 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
11008
11009 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
11010 (bidi_find_paragraph_start): Search back for paragraph beginning
11011 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
11012 (bidi_move_to_visually_next): Only trigger paragraph-related
11013 computations when the last character is a newline or at EOB, not
11014 just any NEUTRAL_B. (Bug#9470)
11015
bb187662
EZ
11016 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
11017 truncated lines if point is covered by a display string. (Bug#9524)
11018
2e621251
PE
110192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
11020
11021 * xselect.c: Relax test for outgoing X longs (Bug#9498).
11022 (cons_to_x_long): New function.
11023 (lisp_data_to_selection_data): Use it. Correct the test for
11024 short-versus-long data; it was negated. Break out of vector
11025 loop, for efficiency, when a long datum is discovered.
11026
91a15bc6
SM
110272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
11028
11029 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
11030
b41c3a35
EZ
110312011-09-16 Eli Zaretskii <eliz@gnu.org>
11032
11033 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
11034 GCC PR/17406) by declaring this function with external scope.
11035
7812ba2d
PE
110362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11037
11038 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
11039 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
11040
cf7edc2a
AS
110412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
11042
11043 * editfns.c (Fformat): Correctly handle text properties on "%%".
11044
bd01620e
EZ
110452011-09-15 Eli Zaretskii <eliz@gnu.org>
11046
11047 * xterm.c (x_draw_composite_glyph_string_foreground):
11048 * w32term.c (x_draw_composite_glyph_string_foreground):
11049 * term.c (encode_terminal_code):
11050 * composite.c (composition_update_it, get_composition_id):
11051 * xdisp.c (get_next_display_element)
11052 (fill_composite_glyph_string): Add comments about special meaning
11053 of TAB characters in a composition.
11054
a02719a3
PE
110552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11056
11057 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
11058 This occurs when processing a multibyte format.
11059 Problem reported by Wolfgang Jenker.
a02719a3 11060
72589a3c
JB
110612011-09-15 Johan Bockgård <bojohan@gnu.org>
11062
11063 * xdisp.c (try_cursor_movement): Only check for exact match if
11064 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
11065
1c14176c
PE
110662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11067
11068 Remove unused external symbols.
11069 * dispextern.h (calc_pixel_width_or_height): Remove decl.
11070 * xdisp.c (calc_pixel_width_or_height): Now static.
11071 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
11072 * indent.c (check_display_width):
11073 * w32term.c: Fix comment to match code.
11074 * xterm.c, xterm.h (x_catching_errors): Remove.
11075
d2eea5b5
PE
110762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11077
11078 * xselect.c: Use signed conversions more consistently (Bug#9498).
11079 (selection_data_to_lisp_data): Assume incoming selection data are
11080 signed integers, not unsigned. This is to be consistent with
11081 outgoing selection data, which was modified to use signed integers
11082 in as part of the fix to Bug#9196 in response to Jan D.'s comment
11083 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
11084 expects long, not unsigned long.
11085
46888499
EZ
110862011-09-14 Eli Zaretskii <eliz@gnu.org>
11087
11088 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
11089 computation of loop end. Reported by Johan Bockgård
11090 <bojohan@gnu.org>.
11091
ef8ef9fb
CY
110922011-09-13 Chong Yidong <cyd@stupidchicken.com>
11093
11094 * frame.c (Fother_visible_frames_p): Function deleted.
11095
fa819fed
EZ
110962011-09-12 Eli Zaretskii <eliz@gnu.org>
11097
11098 * indent.c (compute_motion): Process display vector front to back
11099 rather than the other way around. (Bug#2496)
11100
2ba8e008
SM
111012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
11102
11103 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
11104
20f53c69
CY
111052011-09-11 Chong Yidong <cyd@stupidchicken.com>
11106
11107 * minibuf.c (Fread_from_minibuffer): Doc fix.
11108
d562d7a4
EZ
111092011-09-11 Eli Zaretskii <eliz@gnu.org>
11110
11111 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
11112 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
11113
1c4d7f3d
LMI
111142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11115
11116 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
11117 value for non-existent files.
11118
b885bf36
EZ
111192011-09-11 Eli Zaretskii <eliz@gnu.org>
11120
11121 * fileio.c (Finsert_file_contents): If the file cannot be opened,
11122 set its "size" to -1. This will set the modtime_size field of
11123 the corresponding buffer to -1, which is what
11124 verify-visited-file-modtime expects for files that do not exist.
11125 (Bug#9139)
11126
6612f0bf
PE
111272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
11128
11129 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
11130 here ...
11131 * lisp.h: ... from here. push_key_description is no longer
11132 defined in keyboard.c, so its declaration should not be in
11133 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
11134 logically belongs with push_key_description.
11135
dfb3f755
PE
111362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
11137
11138 * buffer.h: Include <sys/types.h> instead of <time.h>.
11139 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
11140 Problem reported by Herbert J. Skuhra.
11141
3134906c
LMI
111422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
11143
11144 * xml.c (parse_region): Make the parsing work for
11145 non-comment-starting XML files again (bug#9144).
11146
8d903f4e
AS
111472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
11148
11149 * image.c (gif_load): Fix calculation of bottom and right corner.
11150 (Bug#9468)
11151
80ad64f4
EZ
111522011-09-10 Eli Zaretskii <eliz@gnu.org>
11153
11154 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
11155 redisplay in small windows.
11156
208a048d
EZ
111572011-09-09 Eli Zaretskii <eliz@gnu.org>
11158
11159 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
11160
9b1c252e
MR
111612011-09-08 Martin Rudalics <rudalics@gmx.at>
11162
11163 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
11164 Operate on live windows only.
11165
2949f33b
JB
111662011-09-08 Juanma Barranquero <lekktu@gmail.com>
11167
11168 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
11169
e08dcafd
EZ
111702011-09-07 Eli Zaretskii <eliz@gnu.org>
11171
11172 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
11173 only under bidi iteration.
11174
115b96bd
JD
111752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
11176
11177 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
11178
c8199d0f
PE
111792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
11180
11181 isnan: Fix porting problem to Solaris 10 with bundled gcc.
11182 Without this fix, the command to link temacs failed due to an
11183 undefined symbol __builtin_isnan. This is because
11184 /usr/include/iso/math_c99.h #defines isnan(x) to
11185 __builtin_isnan(x), but the bundled gcc, which identifies itself
11186 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
11187 a __builtin_isnan.
11188 * floatfns.c (isnan): #undef, and then #define to a clone of
11189 what's in data.c.
11190 (Fisnan): Always define, since it's always available now.
11191 (syms_of_floatfns): Always define isnan at the Lisp level.
11192
e39b275c 111932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
11194
11195 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
11196
b2db44d9 111972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 11198
f4af5137 11199 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
11200 The previous code assumed that file offsets (off_t values) fit in
11201 EMACS_INT variables, which is not true on typical 32-bit hosts.
11202 The code messed up by falsely reporting buffer overflow in cases
11203 such as (insert-file-contents "big" nil 1 2) into an empty buffer
11204 when "big" contains more than 2**29 bytes, even though this
11205 inserts just one byte and does not overflow the buffer.
11206 (Finsert_file_contents): Store file offsets as off_t
11207 values, not as EMACS_INT values. Check for overflow when
11208 converting between EMACS_INT and off_t. When checking for
11209 buffer overflow or for overlap, take the offsets into account.
11210 Don't use EMACS_INT for small values where int suffices.
11211 When checking for overlap, fix a typo: ZV was used where
11212 ZV_BYTE was intended.
11213 (Fwrite_region): Don't assume off_t fits into 'long'.
11214 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11215
ecfc0a49
MA
112162011-09-05 Michael Albinus <michael.albinus@gmx.de>
11217
11218 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11219
6511acf2 112202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11221
0999621a 11222 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11223
11224 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11225 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11226 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11227 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11228 (modify_event_symbol): Do not assume that the length of
11229 name_alist_or_stem is safe to alloca and fits in int.
11230 (Fexecute_extended_command): Likewise for function name and binding.
11231 (Frecursion_depth): Wrap around reliably on integer overflow.
11232 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11233 since some callers pass EMACS_INT values.
11234 (Fsingle_key_description): Don't crash if symbol name contains more
11235 than MAX_ALLOCA bytes.
11236 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11237 (get_minibuffer): Arg is now EMACS_INT, not int.
11238 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11239 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11240 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11241
2be7d702
PE
11242 * dbusbind.c (signature_cat): New function.
11243 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11244 Do not overrun buffer; instead, report string overflow.
11245
9d1df220
PE
11246 * dispnew.c (add_window_display_history): Don't overrun buffer.
11247 Truncate instead; this is OK since it's just a log.
11248
33ef5c64
PE
11249 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11250 even if the time zone offset is outlandishly large.
11251 Don't mishandle offset == INT_MIN.
11252
66c6fdd5
PE
11253 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11254 when creating daemon; the previous buffer-overflow check was incorrect.
11255
d749b01b
PE
11256 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11257 which has the guts of the old verror function.
11258
b5cd1905
PE
11259 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11260 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11261
6e1a67fb
PE
11262 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11263 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11264 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11265 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11266 length of string rather than counting it via multiple sprintfs;
11267 that's simpler and more reliable.
c21721cc
PE
11268 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11269 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11270 sprintf, in case result does not fit in int.
11271
c57b67fc
PE
11272 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11273 (fontset_from_font): Print it.
11274
8a401434
PE
11275 * frame.c (tty_frame_count): Now printmax_t, not int.
11276 (make_terminal_frame, set_term_frame_name): Print it.
11277 (x_report_frame_params): In X, window IDs are unsigned long,
11278 not signed long, so print them as unsigned.
11279 (validate_x_resource_name): Check for implausibly long names,
11280 and don't assume name length fits in 'int'.
11281 (x_get_resource_string): Don't blindly alloca invocation name;
11282 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11283 not fit in int.
11284
6e1a67fb
PE
11285 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11286 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11287 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11288
0df02bf3
PE
11289 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11290 Use esprintf, not sprintf, in case result does not fit in int.
11291
48e30793
PE
11292 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11293 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11294 it as a large positive number.
11295 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11296 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11297
a66ff6d8
PE
11298 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11299 in case result does not fit in int.
11300
aca216ff
PE
11301 * print.c (float_to_string): Detect width overflow more reliably.
11302 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11303 buffer overrun. Don't assume list length fits in 'int'. Treat
11304 print length of 0 as 0, not as infinity; to be consistent with other
11305 uses of print length in this function. Don't overflow print length
11306 index. Don't assume hash table size fits in 'long', or that
11307 vectorlike size fits in 'unsigned long'.
11308
31c286f7
PE
11309 * process.c (make_process): Use printmax_t, not int, to format
11310 process-name gensyms.
11311
55e5faa1
PE
11312 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11313
80f2e268
PE
11314 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11315 to avoid potential buffer overrun.
11316
670741ab
PE
11317 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11318 if X resource line is longer than 512 bytes.
11319
b7163a50
PE
11320 * xfns.c (x_window): Make sprintf buffer a bit bigger
11321 to avoid potential buffer overrun.
11322
ae58ff1f
PE
11323 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11324
c43c8a6a
PE
11325 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11326
3f8236f4
PE
113272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11328
53e9fe90 11329 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11330 Without these, Emacs silently mishandles large integers sometimes.
11331 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11332 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11333
6511acf2
PE
11334 * xdisp.c (try_window_id): Check Emacs fixnum range before
11335 converting to 'int'.
806add1d 11336
6511acf2 11337 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11338 Check that an Emacs fixnum is in range before assigning it to 'int'.
11339 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11340 values converted from Emacs fixnums.
11341 (Frecenter): Don't wrap around a line count if it is out of 'int'
11342 range; instead, treat it as an extreme value.
11343 (Fset_window_configuration, compare_window_configurations):
11344 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11345
6511acf2
PE
11346 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11347 that can exceed INT_MAX. Check that EMACS_INT value is in range
11348 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11349 (match_limit): Don't assume that a fixnum can fit in 'int'.
11350
6511acf2 11351 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11352 exceed INT_MAX.
11353
6511acf2 11354 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11355 (Fvertical_motion): Don't wrap around LINES values that don't fit
11356 in 'int'. Instead, treat them as extreme values. This is good
11357 enough for windows, which can't have more than INT_MAX lines anyway.
11358
fcb901a7
LMI
113592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11360
0f2f6b6d
LMI
11361 * Require libxml/parser.h to avoid compilation warning.
11362
fcb901a7
LMI
11363 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11364
11365 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11366 since this reportedly can destroy thread storage.
11367
6e20a0d4
CY
113682011-08-30 Chong Yidong <cyd@stupidchicken.com>
11369
11370 * syntax.c (find_defun_start): Update all cache variables if
11371 exiting early (Bug#9401).
11372
148ae00e
EZ
113732011-08-30 Eli Zaretskii <eliz@gnu.org>
11374
f6cfbd8f
EZ
11375 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11376
148ae00e
EZ
11377 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11378 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11379 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11380
11381 * term.c (tty_append_glyph): New function.
11382 (produce_stretch_glyph): Static function and its prototype deleted.
11383
a66cfb1c
SM
11384 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11385 Add prototypes.
148ae00e 11386
c4a07a4c
PE
113872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11388
11389 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11390 when checking :margin (Bug#9390).
11391 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11392 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11393 so that the name doesn't mislead. All uses changed.
11394
6bc8cd65
JB
113952011-08-28 Johan Bockgård <bojohan@gnu.org>
11396
11397 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11398 set_tty_hooks.
11399
dca4927e
EZ
114002011-08-27 Eli Zaretskii <eliz@gnu.org>
11401
11402 * xdisp.c (move_it_to): Don't bail out early when reaching
11403 position beyond to_charpos, if we are scanning backwards.
11404 (move_it_vertically_backward): When DY == 0, make sure we get to
11405 the first character in the line after the newline.
11406
f2cad773
PE
114072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11408
11409 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11410 (ccl_driver): Do not generate an out-of-range pointer.
11411 (Fccl_execute_on_string): Remove unnecessary check for
11412 integer overflow, noted by Stefan Monnier in
11413 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11414 Remove a FIXME that didn't need fixing.
11415 Simplify the newly-introduced buffer reallocation code.
11416
0cae2cdb
JB
114172011-08-27 Juanma Barranquero <lekktu@gmail.com>
11418
11419 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11420
5fc295a4 114212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11422
70c60eb2 11423 Integer and memory overflow issues (Bug#9196).
726e0ab1 11424
d31850da
PE
11425 * doc.c (get_doc_string): Rework so that
11426 get_doc_string_buffer_size is the actual buffer size, rather than
11427 being 1 less than the actual buffer size; this makes xpalloc more
11428 convenient.
11429
a69fbedb
PE
11430 * image.c (x_allocate_bitmap_record, cache_image):
11431 * xselect.c (Fx_register_dnd_atom):
11432 Simplify previous changes by using xpalloc.
11433
fe5c5d37
PE
11434 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11435 since either will do and ptrdiff_t is convenient with xpalloc.
11436
0065d054
PE
11437 * charset.c (charset_table_size)
11438 (struct charset_sort_data.priority): Now ptrdiff_t.
11439 (charset_compare): Don't overflow if priorities differ greatly.
11440 (Fsort_charsets): Don't assume list length fits in int.
11441 Check for size-calculation overflow when allocating sort data.
11442 (syms_of_charset): Allocate an initial charset table that is
11443 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11444
11445 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11446
11447 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11448 The actual value is always <= INT_MAX, and leaving it unsigned made
11449 overflow checking harder.
11450
11451 * dispextern.h (struct glyph_matrix.rows_allocated)
11452 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11453 with xpalloc. The values are still always <= INT_MAX.
11454
11455 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11456
11457 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11458 (SAFE_NALLOCA): New macro.
11459
11460 * region-cache.c (struct boundary.pos, find_cache_boundary)
11461 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11462 (set_cache_region, invalidate_region_cache)
11463 (revalidate_region_cache, know_region_cache, region_cache_forward)
11464 (region_cache_backward, pp_cache):
11465 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11466 so that ptrdiff_t * can be passed to xpalloc.
11467 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11468 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11469 (pp_cache): Don't assume cache_len fits in int.
11470 * region-cache.h: Adjust extern decls to match.
11471
11472 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11473 EMACS_INT, since either will do, for xpalloc.
11474
11475 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11476 (xnmalloc, xnrealloc, xpalloc): New functions.
11477
726e0ab1
PE
11478 * bidi.c (bidi_shelve_header_size): New constant.
11479 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11480 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11481
51f30bc5 11482 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11483 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11484 (overlay_strings):
11485 Don't update size of array until after memory allocation succeeds,
11486 because xmalloc/xrealloc may not return.
0065d054
PE
11487 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11488 now that we have proper integer overflow checking.
11489 (record_overlay_string, overlay_strings): Catch overflows when
11490 calculating size of overlay_str_buf.
726e0ab1 11491
0065d054
PE
11492 * callproc.c (Fcall_process): Check for size overflow when
11493 calculating size of args2.
11494 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11495 Normally we prefer signed values, but sticking with ptrdiff_t would
11496 require adding more-complicated checks.
726e0ab1
PE
11497
11498 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11499 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11500 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11501 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11502
11503 * character.c (Fstring): Check for size-calculation overflow.
11504
11505 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11506 unnecessary integer overflow. Check for size overflow.
11507 (encode_coding_object): Don't update size until xmalloc succeeds.
11508
11509 * composite.c (get_composition_id): Check for overflow in glyph
11510 length calculations.
11511
11512 Integer and memory overflow fixes for display code.
11513 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11514 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11515 (scrolling_window): Check for overflow in size calculations.
11516 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11517 Don't assume glyph table len fits in int.
11518 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11519 (row_table_size): Now ptrdiff_t, not int.
11520 (scrolling_window): Avoid overflow in size calculations.
11521 Don't update size until allocation succeeds.
11522 * fns.c (concat): Check for overflow in size calculations.
11523 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11524 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11525 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11526
11527 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11528 (get_doc_string): Check for size calculation overflow.
11529 Don't update size until allocation succeeds.
11530 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11531 EMACS_INT, where ptrdiff_t will do.
11532 (Fsubstitute_command_keys): Check for string overflow.
11533
11534 * editfns.c (set_time_zone_rule): Don't assume environment length
11535 fits in int.
11536 (message_length): Now ptrdiff_t, not int.
11537 (Fmessage_box): Don't update size until allocation succeeds.
11538 Don't assume message length fits in int.
11539 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11540
0065d054
PE
11541 * emacs.c (main): Do not reallocate argv, since there is a null at
11542 the end that can be overwritten, and this way there's no need to
11543 worry about size-calculation overflow.
11544 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11545
11546 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11547 alloc succeeds.
11548 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11549
11550 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11551 (x_set_scroll_bar_width, x_figure_window_size):
11552 Check for integer overflow.
11553 (x_set_alpha): Do not assume XINT fits in int.
11554
11555 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11556 This is for the members text_lines, text_cols, total_lines, total_cols,
11557 where the system imposes an 'int' limit.
11558
11559 * fringe.c (Fdefine_fringe_bitmap):
11560 Don't update size until alloc works.
11561
11562 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11563 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11564
11565 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11566 Check for size-calculation overflow.
11567 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11568 do, as we prefer signed integers.
11569 (id_to_widget.max_size, id_to_widget.used)
11570 (xg_store_widget_in_map, xg_remove_widget_from_map)
11571 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11572 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11573 Use and return ptrdiff_t, not int.
11574 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11575 * gtkutil.h: Change prototypes to match the above.
11576
11577 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11578 are duplicate now that they've been promoted to lisp.h.
11579 (x_allocate_bitmap_record, x_alloc_image_color)
11580 (make_image_cache, cache_image, xpm_load):
11581 Don't update size until alloc is done.
11582 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11583 (x_detect_edges):
3256efce 11584 Check for size calculation overflow.
726e0ab1
PE
11585 (ct_colors_allocated_max): New constant.
11586 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11587 overflow.
3256efce 11588
726e0ab1
PE
11589 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11590 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11591 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11592 Use ptrdiff_t, not int, to count maps.
11593 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11594 calculations. Don't update size until allocation succeeds.
11595 Redo calculations to avoid overflow.
726e0ab1
PE
11596 * keyboard.h: Change prototypes to match the above.
11597
11598 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11599 to count maps.
11600 (current_minor_maps): Check for size calculation overflow.
11601 * keymap.h: Change prototypes to match the above.
11602
11603 * lread.c (read1, init_obarray): Don't update size until alloc done.
11604
11605 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11606 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11607
726e0ab1
PE
11608 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11609 Now ptrdiff_t, not int.
11610 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11611 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11612
11613 * process.c (Fnetwork_interface_list): Check for overflow
11614 in size calculation.
11615
11616 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11617
11618 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11619 overflow. Don't bother calling xmalloc when xrealloc will do.
11620
11621 * search.c (Freplace_match): Check for size calculation overflow.
11622 (Fset_match_data): Don't assume list lengths fit in 'int'.
11623
11624 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11625 for command line length. Do not attempt to address one before the
11626 beginning of an array, as that's not portable.
11627
11628 * term.c (max_frame_lines): Remove; unused.
11629 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11630 not int.
11631 (encode_terminal_code, calculate_costs): Check for size
11632 calculation overflow.
11633 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11634 table lengths and related sizes. Don't update size until alloc
11635 done. Redo calculations to avoid overflow.
11636 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11637
11638 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11639 subtracting pointers.
11640 (gobble_line): Check for overflow more carefully. Don't update size
11641 until alloc done.
11642
11643 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11644 Don't update size until alloc done.
11645 Redo size calculations to avoid overflow.
11646 Check for size calculation overflow.
0065d054 11647 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11648
11649 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11650 Use ptrdiff_t, not int, for sizes.
11651 (store_mode_line_noprop_char): Don't update size until alloc done.
11652
0065d054
PE
11653 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11654 Use ptrdiff_t, not int, for sizes.
11655 (Finternal_make_lisp_face, cache_face):
11656 Check for size calculation overflow.
11657 (cache_face): Treat size calculation overflows as if they were
11658 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11659
11660 * xfns.c (x_encode_text, x_set_name_internal)
11661 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11662 sizes, since they can exceed INT_MAX in size. Check for size
11663 calculation overflow.
11664
0065d054
PE
11665 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11666 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11667 Don't update size until alloc done.
11668
0065d054 11669 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11670 as sprintf is limited to int lengths.
1d526e2f 11671
252c5ee1
PE
11672 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11673 (X_LONG_MIN): New macros.
864d7ce7
PE
11674 Use them to make the following changes clearer.
11675 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11676 This change doesn't affect the value now, but it may help remind
11677 future maintainers not to raise the value too much later.
11678 (SELECTION_QUANTUM): Remove, replacing with ...
11679 (selection_quantum): ... new function, which avoids overflow.
11680 All uses changed.
11681 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11682 assumption that selection length fits in 'int'.
11683 (x_reply_selection_request, x_handle_selection_request)
11684 (x_get_window_property, receive_incremental_selection)
11685 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11686 (lisp_data_to_selection_data, clean_local_selection_data):
11687 Use ptrdiff_t, not int, to record length of selection.
11688 (x_reply_selection_request, x_get_window_property)
11689 (receive_incremental_selection, x_property_data_to_lisp):
11690 Redo calculations to avoid overflow.
11691 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11692 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11693 something.
11694 (x_get_window_property, receive_incremental_selection)
11695 (lisp_data_to_selection_data, x_property_data_to_lisp):
11696 Check for size-calculation overflow.
11697 (x_get_window_property, receive_incremental_selection)
11698 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11699 Don't store size until memory allocation succeeds.
11700 (x_get_window_property): Plug memory leak on memory exhaustion.
11701 Don't double-block input; malloc is safe here. Don't assume 2**34
11702 - 4 fits in unsigned long. Add an xassert to check
11703 XGetWindowProperty overflow. Be more careful about overflow
11704 calculations, and distinguish size from memory overflow better.
11705 (receive_incremental_selection): When tracing, don't assume
11706 unsigned int is less than INT_MAX.
11707 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11708 harmful) conversions of unsigned short to int.
11709 (lisp_data_to_selection_data): Don't assume that integers
11710 in the range -65535 through -1 fit in an X unsigned short.
11711 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11712 result parameters unless successful. Rely on cons_to_unsigned
11713 to report problems with elements; the old code wasn't right anyway.
11714 (x_check_property_data): Check for int overflow; we cannot use
11715 a wider type due to X limits.
11716 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11717
726e0ab1 11718 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11719
0065d054
PE
11720 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11721 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11722 (x_color_cells): Don't store size until memory allocation succeeds.
11723 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11724 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11725 (x_term_init): Don't assume length fits in int (sprintf is limited
11726 to int size).
bc18e09d 11727
ebfa62c0
PE
11728 Use ptrdiff_t for composition IDs.
11729 * character.c (lisp_string_width):
11730 * composite.c (composition_table_size, n_compositions)
11731 (get_composition_id, composition_gstring_from_id):
11732 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11733 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11734 * window.c (Frecenter):
11735 Use ptrdiff_t, not int, for composition IDs.
11736 * composite.c (get_composition_id): Check for integer overflow.
11737 * composite.h: Adjust prototypes to match the above changes.
11738
d3411f89
PE
11739 Use ptrdiff_t for hash table indexes.
11740 * category.c (hash_get_category_set):
11741 * ccl.c (ccl_driver):
11742 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11743 * coding.c (coding_system_charset_list, detect_coding_system):
11744 * coding.h (struct coding_system.id):
11745 * composite.c (get_composition_id, gstring_lookup_cache):
11746 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11747 * image.c (xpm_get_color_table_h):
11748 * lisp.h (hash_lookup, hash_put):
11749 * minibuf.c (Ftest_completion):
11750 Use ptrdiff_t for hash table indexes, not int (which is too
11751 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11752 32-bit --with-wide-int hosts).
11753
e097a6fa
PE
11754 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11755 Add a FIXME comment about memory leaks.
11756 (syms_of_charset): Don't assume xmalloc returns.
11757
5637687f
PE
11758 Don't assume that stated character widths fit in int.
11759 * character.c (Fchar_width, c_string_width, lisp_string_width):
11760 * character.h (CHAR_WIDTH):
11761 * indent.c (MULTIBYTE_BYTES_WIDTH):
11762 Use sanitize_char_width to avoid undefined and/or bad behavior
11763 with outlandish widths.
a66cfb1c 11764 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11765 now that we have two such functions. All uses changed.
11766 (sanitize_char_width): New inline function.
11767
a2271ba2
PE
11768 Don't assume that tab-width fits in int.
11769 * character.h (sanitize_width): New inline function.
11770 (SANE_TAB_WIDTH): New macro.
11771 (ASCII_CHAR_WIDTH): Use it.
11772 * indent.c (sane_tab_width): Remove. All uses replaced by
11773 SANE_TAB_WIDTH (current_buffer).
11774 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11775
18c52557
PE
11776 * fileio.c: Integer overflow issues with file modes.
11777 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11778
caeeedc1
PE
11779 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11780 Remove unreachable code.
11781 (read_hex, load_charset_map_from_file): Check for integer overflow.
11782
6df6ae42 11783 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11784 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11785 (x_send_scroll_bar_event): Likewise. Check that the size does not
11786 exceed limits imposed by XClientMessageEvent, as well as the usual
11787 ptrdiff_t and size_t limits.
11788
b13995db
PE
11789 * keyboard.c: Overflow, signedness and related fixes.
11790 (make_lispy_movement): Use same integer type in forward decl
11791 that is used in the definition.
11792 (read_key_sequence, keyremap_step):
11793 Change bufsize argument back to int, undoing my 2011-03-30 change.
11794 We prefer signed types, and int is wide enough here.
11795 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11796 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11797 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11798 length, not size_t. Use ptrdiff_t for index, not int.
11799 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11800 possibility of integer overflow.
11801
13464394
PE
11802 Overflow, signedness and related fixes for images.
11803
11804 * dispextern.h (struct it.stack[0].u.image.image_id)
11805 (struct_it.image_id, struct image.id, struct image_cache.size)
11806 (struct image_cache.used, struct image_cache.ref_count):
11807 * gtkutil.c (update_frame_tool_bar):
11808 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11809 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11810 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11811 * nsmenu.m (update_frame_tool_bar):
11812 * xdisp.c (calc_pixel_width_or_height):
11813 * xfns.c (image_cache_refcount):
11814 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11815 on typical 64-bit hosts.
11816
11817 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11818 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11819 Omit unnecessary casts to int.
11820 (parse_image_spec): Check that integers fall into 'int' range
11821 when the callers expect that.
11822 (image_ascent): Redo ascent calculation to avoid int overflow.
11823 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11824 (lookup_image): Remove unnecessary tests.
11825 (xbm_image_p): Locals are now of int, not EMACS_INT,
11826 since parse_image_check makes sure they fit into int.
11827 (png_load, gif_load, svg_load_image):
11828 Prefer int to unsigned where either will do.
11829 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11830 old tiff_error_handler and tiff_warning_handler.
11831 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11832 stack buffer overflows. It uses only the features of vsnprintf
11833 that are common to both POSIX and native Microsoft.
11834 (tiff_error_handler, tiff_warning_handler): Use it.
11835 (tiff_load, gif_load, imagemagick_load_image):
11836 Don't assume :index value fits in 'int'.
11837 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11838 (imagemagick_load_image): Check that crop parameters fit into
11839 the integer types that MagickCropImage accepts. Don't assume
11840 Vimagemagick_render_type has a nonnegative value. Don't assume
11841 size_t fits in 'long'.
11842 (gs_load): Use printmax_t to print the widest integers possible.
11843 Check for integer overflow when computing image height and width.
11844
c11821d4
EZ
118452011-08-26 Eli Zaretskii <eliz@gnu.org>
11846
11847 * xdisp.c (redisplay_window): Don't force window start if point
11848 will be invisible in the resulting window. (Bug#9324)
11849
0c95fcf7
EZ
118502011-08-25 Eli Zaretskii <eliz@gnu.org>
11851
11852 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11853 the display spec is of the form `(space ...)'.
11854 (handle_display_spec): Return the value returned by
11855 handle_single_display_spec, not just 1 or zero.
11856 (handle_single_display_spec): If the display spec is of the form
11857 `(space ...)', and specifies display in the text area, return 2
11858 rather than 1.
fee65a97 11859 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11860 accurately, and prefer exact match for point under bidi.
11861 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11862
11863 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11864 into disp_prop; all users changed.
11865
11866 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11867 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11868 for the text covered by the display property.
11869
e4ed06f1
CY
118702011-08-25 Chong Yidong <cyd@stupidchicken.com>
11871
11872 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11873 Change return value to nil.
11874 (Frecord_buffer): Delete unused function.
11875
f67cdd7f
EZ
118762011-08-24 Eli Zaretskii <eliz@gnu.org>
11877
5980d4c6
EZ
11878 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11879 buffers, return left-to-right.
8610fe8b
EZ
11880 (set_cursor_from_row): Consider candidate row a win if its glyph
11881 represents a newline and point is on that newline. Fixes cursor
11882 positioning on the newline at EOL of R2L text within L2R
11883 paragraph, and vice versa.
11884 (try_cursor_movement): Check continued rows, in addition to
11885 continuation rows. Fixes unwarranted scroll when point enters a
11886 continued line of R2L text within an L2R paragraph, or vice versa.
11887 (cursor_row_p): Consider the case of point being equal to
11888 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11889 from the end of a short line to the beginning of a continued line
11890 of R2L text within L2R paragraph.
11891 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11892 composed characters.
5980d4c6 11893
f67cdd7f
EZ
11894 * bidi.c (bidi_check_type): Use xassert.
11895 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11896 members.
11897
bca633fb
EZ
118982011-08-23 Eli Zaretskii <eliz@gnu.org>
11899
11900 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11901 a character.
11902
4a5885a7
CY
119032011-08-23 Chong Yidong <cyd@stupidchicken.com>
11904
11905 * nsfont.m (ns_otf_to_script): Fix typo.
11906
0902a04e
KH
119072011-08-22 Kenichi Handa <handa@m17n.org>
11908
11909 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11910 extra slot even if the purpose is char-code-property-table.
11911
1a2e6670
EZ
119122011-08-23 Eli Zaretskii <eliz@gnu.org>
11913
8ddde651
EZ
11914 * xdisp.c (redisplay_window): When computing centering_position,
11915 account for the height of the header line. (Bug#8874)
11916
425cc014
EZ
11917 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11918 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11919 candidate is selected by the mouse, and that candidate has a
11920 composed character under the mouse.
11921
1a2e6670
EZ
11922 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11923 coordinates reported by pos-visible-in-window-p for a composed
11924 character in column zero.
11925
8b76d6f8
SM
119262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11927
11928 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11929
dac347dd
EZ
119302011-08-22 Eli Zaretskii <eliz@gnu.org>
11931
11932 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11933 consider it a hit if to_charpos is anywhere in the range of the
11934 composed buffer positions.
11935
e013fb34
CY
119362011-08-22 Chong Yidong <cyd@stupidchicken.com>
11937
11938 * image.c (gif_load): Don't assume that each subimage has the same
11939 dimensions as the base image. Handle disposal method that is
11940 "undefined" by the gif spec (Bug#9335).
11941
bd1ba3e8
CY
119422011-08-20 Chong Yidong <cyd@stupidchicken.com>
11943
11944 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11945 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11946
54a1215b
EZ
119472011-08-19 Eli Zaretskii <eliz@gnu.org>
11948
823564e5
EZ
11949 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11950 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11951 from an Org mode buffer to a Speedbar frame.
11952
54a1215b
EZ
11953 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11954 a composition, take its buffer position from IT->cmp_it.charpos.
11955 Fixes cursor positioning at the beginning of a line that begins
11956 with a composed character.
11957
9778ebcc
EZ
119582011-08-18 Eli Zaretskii <eliz@gnu.org>
11959
0be6ee06
EZ
11960 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11961 character bidirectional type, use STRONG_L instead. Fixes crashes
11962 in a buffer produced by `describe-categories'.
11963
9778ebcc
EZ
11964 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11965 members before the level stack, so they would be saved and
11966 restored when copying iterator state. Fixes incorrect reordering
11967 around TABs covered by display properties.
11968
156bffbe
AS
119692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11970
6b02f655 11971 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11972
72ad093b
CY
119732011-08-17 Chong Yidong <cyd@stupidchicken.com>
11974
11975 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11976 (internal_condition_case_2, internal_condition_case_n):
11977 Remove unnecessary aborts (Bug#9081).
72ad093b 11978
35774242
EZ
119792011-08-17 Eli Zaretskii <eliz@gnu.org>
11980
11981 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11982 has no `load' handler, try opening the file locally. (Bug#9311)
11983
db76dd85
KB
119842011-08-16 Ken Brown <kbrown@cornell.edu>
11985
11986 * gmalloc.c: Expand comment.
11987
b215eee5
EZ
119882011-08-16 Eli Zaretskii <eliz@gnu.org>
11989
11990 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11991 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11992
a4579d33
KB
119932011-08-16 Ken Brown <kbrown@cornell.edu>
11994
11995 Fix memory allocation problems in Cygwin build (Bug#9273).
11996
11997 * unexcw.c ( __malloc_initialized): Declare external variable.
11998 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11999
8b76d6f8
SM
12000 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
12001 New variables.
a4579d33
KB
12002 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
12003 dumped emacs.
12004 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
12005 in the static heap.
12006 [CYGWIN] (special_realloc): New function.
12007 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
12008 requests to realloc storage in the static heap.
12009
3ebec551
PE
120102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
12011
12012 * bidi.c (bidi_initialize): Remove unused local.
12013
9fd8be00
EZ
120142011-08-15 Eli Zaretskii <eliz@gnu.org>
12015
6b02f655
SM
12016 * bidimirror.h:
12017 * biditype.h: Remove file.
12018 * makefile.w32-in ($(BLD)/bidi.$(O)):
12019 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
12020
12021 * dispextern.h: Fix a typo in the comment to bidi_type_t.
12022
12023 * chartab.c: Improve commentary for the uniprop_table API.
12024
32413314
EZ
12025 * bidi.c (bidi_paragraph_init): Support zero value of
12026 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
12027 (bidi_initialize): Use uniprop_table instead of including
12028 biditype.h and bidimirror.h.
32413314 12029
9fd8be00
EZ
12030 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
12031 coordinates of the iterator when restoring from ppos_it.
12032 (Bug#9296)
12033
5cf2b69b
KH
120342011-08-14 Kenichi Handa <handa@m17n.org>
12035
12036 * process.c (create_process): Call setup_process_coding_systems
72ad093b 12037 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 12038
daf17d00
EZ
120392011-08-14 Eli Zaretskii <eliz@gnu.org>
12040
12041 * xdisp.c (move_it_in_display_line_to): Don't invoke
12042 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
12043 ppos_it. Fixes vertical cursor motion when line beginning is
12044 covered by an image. (Bug#9296)
12045
08e3161a
JD
120462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
12047
12048 * nsterm.h (ns_run_ascript): Declare.
12049 (NSAPP_DATA2_RUNASSCRIPT): Define.
12050
12051 * nsfns.m (as_script, as_result, as_status): New static variables.
12052 (ns_run_ascript): New function.
5e617bc2 12053 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
12054 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
12055 the event loop. Get status from as_status (Bug#7276).
12056
12057 * nsterm.m (sendEvent): If event is NSApplicationDefined and
12058 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
12059 the event loop (Bug#7276).
12060
a3720aa2
AS
120612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
12062
12063 * gnutls.c (QCgnutls_bootprop_priority)
12064 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
12065 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
12066 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
12067 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
12068 (QCgnutls_bootprop_verify_hostname_error)
12069 (QCgnutls_bootprop_callbacks_verify): Rename from
12070 Qgnutls_bootprop_..., all uses changed.
12071
12072 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
12073 uses changed.
12074
0a0d27fb
PE
120752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
12076
19d5c50c
PE
12077 * xfaces.c (Qframe_set_background_mode): Now static.
12078 * dispextern.h (Qframe_set_background_mode): Remove decl.
12079
0a0d27fb
PE
12080 * process.c (Fnetwork_interface_info): Declare local only if needed.
12081
377538cb
JD
120822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
12083
12084 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
12085 (Fnetwork_interface_list): Allocate in increments of bytes instead
12086 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
12087 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
12088 sockaddr.
12089 (struct ifflag_def): notrailers is smart on OSX.
12090 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
12091 Get hardware address with getifaddrs if available.
12092
08fff70c
EZ
120932011-08-12 Eli Zaretskii <eliz@gnu.org>
12094
12095 * xdisp.c (iterate_out_of_display_property): xassert that
12096 IT->position is set to within IT->object's boundaries. Break from
12097 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
12098 when IT->position is set up wrongly due to some bug.
12099 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
12100 (push_display_prop): Allow GET_FROM_STRING as IT->method on
12101 entry. Force push_it to save on the stack the current
12102 buffer/string position, to be restored by pop_it. Fix flags in
12103 the iterator structure wrt the object coming from a display
12104 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
12105 properties. (Bug#9284)
12106
7be1c708 121072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 12108
7be1c708
CY
12109 * fontset.c (fontset_get_font_group): Add proper type checks.
12110 (Bug#9172)
aac0c6e3 12111
7be1c708 121122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 12113
7be1c708
CY
12114 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
12115 and LC_VERSION_MIN_MACOSX.
12116 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
12117 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 12118
97bb72a6
EZ
121192011-08-08 Eli Zaretskii <eliz@gnu.org>
12120
12121 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
12122 no-display-properties-and-no-overlays under bidi display.
12123 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 12124 properties and overlays.
97bb72a6 12125
d5617611
CY
121262011-08-08 Chong Yidong <cyd@stupidchicken.com>
12127
37e11a63
CY
12128 * editfns.c (Fset_time_zone_rule): Document relationship with the
12129 setenv function.
12130
d5617611
CY
12131 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12132 the font entity extracted from the cache (Bug#8109).
12133
58872834
CY
121342011-08-07 Chong Yidong <cyd@stupidchicken.com>
12135
12136 * composite.c (autocmp_chars): Don't reset point. That is done by
12137 restore_point_unwind (Bug#5984).
12138
75bfc667
JL
121392011-08-07 Juri Linkov <juri@jurta.org>
12140
12141 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
12142 to show the arg `TIME' instead of `TIMEVAL'.
12143
d1410150
EZ
121442011-08-06 Eli Zaretskii <eliz@gnu.org>
12145
12146 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
12147 display property strides EOL and includes a newline, as in
12148 longlines-mode. (Bug#9254)
75b771e4
EZ
12149 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12150 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
12151
12152 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
12153 is non-zero, even if the data buffer is NULL. Fixes a crash in
12154 vertical-motion with longlines-mode. (Bug#9254)
12155
35928349
EZ
121562011-08-05 Eli Zaretskii <eliz@gnu.org>
12157
ec7cc85b
EZ
12158 * bidi.c <bidi_cache_total_alloc>: Now static.
12159 (bidi_initialize): Initialize bidi_cache_total_alloc.
12160
8b76d6f8 12161 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
12162 cache. (Bug#9221)
12163
12164 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
12165 amount allocated this far in `bidi_cache_total_alloc'.
12166 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12167 non-zero, only free the data buffer without restoring the cache
12168 contents. All callers changed.
12169
12170 * dispextern.h (bidi_unshelve_cache): Update prototype.
12171
12172 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
12173 (move_it_in_display_line, move_it_to)
12174 (move_it_vertically_backward, move_it_by_lines): Replace the call
12175 to xfree to an equivalent call to bidi_unshelve_cache.
12176 (move_it_in_display_line_to): Fix logic of returning
412b6358 12177 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 12178
e2e2423b
EZ
121792011-08-05 Eli Zaretskii <eliz@gnu.org>
12180
12181 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
12182 came from a string character with a `cursor' property. (Bug#9229)
12183
ae9e757a
JD
121842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12185
12186 * Makefile.in (LIB_PTHREAD): New variable.
12187 (LIBES): Add LIB_PTHREAD (Bug#9216).
12188
12189 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12190 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
12191
213bd7f2
AS
121922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
12193
6b02f655 12194 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 12195
99aaf75f
JD
121962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12197
12198 * xterm.c (x_find_topmost_parent): New function.
12199 (x_set_frame_alpha): Find topmost parent window with
12200 x_find_topmost_parent and set the property there also (bug#9181).
12201 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
12202
c74e9d86
PE
122032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
12204
12205 * callproc.c (Fcall_process): Avoid vfork clobbering
12206 the local vars buffer, coding_systems, current_dir.
12207
640c8776
SM
122082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
12209
12210 * keymap.c (Fmake_composed_keymap): Move to subr.el.
12211
f26d0e4c
PE
122122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
12213
8a10d76c
PE
12214 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12215 so that it is not optimized away.
12216
f26d0e4c
PE
12217 * xdisp.c (compute_display_string_pos): Remove unused local.
12218
55439c61
EZ
122192011-08-02 Eli Zaretskii <eliz@gnu.org>
12220
12221 Fix slow cursor motion and scrolling in large buffers with
12222 selective display, like Org Mode buffers. (Bug#9218)
12223
12224 * dispextern.h (struct bidi_it): New member disp_prop_p.
12225
12226 * xdisp.c: Remove one-slot cache of display string positions.
12227 (compute_display_string_pos): Accept an additional argument
5e617bc2 12228 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12229 for a display string or property. If found, set DISP_PROP_P
12230 non-zero.
12231
12232 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12233 DISP_PROP_P, and pass it to compute_display_string_pos.
12234 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12235 non-zero. All callers of bidi_fetch_char changed.
12236
fb33fa43
SM
122372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12238
12239 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12240
b099e063
DM
122412010-12-03 Don March <don@ohspite.net>
12242
12243 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12244 last character M-[char] is translated to ESC [char] (bug#7541).
12245
5cc7f7af
KH
122462011-08-02 Kenichi Handa <handa@m17n.org>
12247
d0fffa3f 12248 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12249
12250 * chartab.c (uniprop_table): Make it non-static.
12251
525d5e6e
EZ
122522011-08-01 Eli Zaretskii <eliz@gnu.org>
12253
12254 * xdisp.c (forward_to_next_line_start): Accept additional argument
12255 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12256 on the newline.
12257 (reseat_at_next_visible_line_start): Use the bidi iterator state
12258 returned by forward_to_next_line_start to restore the state of
12259 it->bidi_it after backing up to previous newline. (Bug#9212)
12260
31011111
AS
122612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12262
12263 * regex.c (re_comp): Protoize.
12264 (re_exec): Fix return type.
12265 (regexec): Fix type of `ret'. (Bug#9203)
12266
476371c4
PE
122672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12268
e5d76069
PE
12269 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12270 This is needed if max-image-size is a floating-point number.
12271
9a79b20c
AS
122722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12273
12274 * print.c (print_object): Print empty symbol as ##.
12275
12276 * lread.c (read1): Read ## as empty symbol.
12277
d8c2fa78
AA
122782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12279
12280 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12281 setting frame foreground color (Bug#9175).
12282 (x_set_background_color): Likewise.
12283
ffe57a7a
AA
12284 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12285 contents (Bug#9176).
12286 (EmacsTooltip -init): Remove bezels and add shadows to
12287 tooltip windows.
12288
bf3492a5
AA
12289 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12290 or scroll bar (Bug#8470).
12291
d55e9c53
AA
12292 * nsfont.m (nsfont_open): Remove assignment to voffset and
12293 unnecessary vars hshink, expand, hd, full_height, min_height.
12294 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12295
12296 * nsterm.h (nsfont_info): Remove voffset field.
12297
d8c2fa78 122982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12299
12300 Implement strike-through and overline on NextStep (Bug#8863).
12301
12302 * nsfont.m (nsfont_open): Use underline position provided by font,
12303 instead of hard-coded value of 2.
12304 (nsfont_draw): Call ns_draw_text_decoration instead.
12305
12306 * nsterm.h: Add declaration for ns_draw_text_decoration.
12307
12308 * nsterm.m (ns_draw_text_decoration): New function for drawing
12309 underline, overline, and strike-through.
12310 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12311 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12312 accommodate underlining, etc.
4843aac3 12313
4cc60b9b
EZ
123142011-07-28 Eli Zaretskii <eliz@gnu.org>
12315
bc7ece87
EZ
12316 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12317 default.
4cc60b9b 12318
476371c4
PE
123192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12320
66606eea
PE
12321 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12322 Without this fix, if a signal arrives just after memory fills up,
12323 'malloc' might be invoked reentrantly.
12324
476371c4
PE
12325 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12326 In other words, assume that every image size is allowed, on non-X
12327 hosts. This assumption is probably wrong, but it lets Emacs compile.
12328
f3fcc40d
AS
123292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12330
12331 * regex.c (re_iswctype): Convert return values to boolean.
12332
350c992f
EZ
123332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12334
12335 * xdisp.c (compute_display_string_pos): Don't use cached display
12336 string position if the buffer had its restriction changed.
12337 (Bug#9184)
12338
5266b4bb
PE
123392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12340
12341 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12342
2573a837 123432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12344
41f55ccd 12345 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12346
39e378da
PE
12347 * bidi.c: Integer size and overflow fixes.
12348 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12349 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12350 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12351 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12352 (bidi_find_other_level_edge):
12353 Use ptrdiff_t instead of EMACS_INT where either will do.
12354 This works better on 32-bit hosts configured --with-wide-int.
12355 (bidi_cache_ensure_space): Check for size-calculation overflow.
12356 Use % rather than repeated addition, for better worst-case speed.
12357 Don't set bidi_cache_size until after xrealloc returns, because it
12358 might not return.
12359 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12360 (bidi_cache_ensure_space): Also check that the bidi cache size
12361 does not exceed that of the largest Lisp string or buffer. See Eli
12362 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12363
5e927815
PE
12364 * alloc.c (__malloc_size_t): Remove.
12365 All uses replaced by size_t. See Andreas Schwab's note
12366 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12367
ca4aa935
PE
12368 * image.c: Improve checking for integer overflow.
12369 (check_image_size): Assume that f is nonnull, since
12370 it is always nonnull in practice. This is one less thing to
12371 worry about when checking for integer overflow later.
12372 (x_check_image_size): New function, which checks for integer
12373 overflow issues inside X.
12374 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12375 This removes the need for a memory_full check.
12376 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12377 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12378 (xbm_read_bitmap_data): Change locals back to 'int', since
12379 their values must fit in 'int'.
12380 (xpm_load_image, png_load, tiff_load):
12381 Invoke x_create_x_image_and_pixmap earlier,
12382 to avoid much needless work if the image is too large.
12383 (tiff_load): Treat overly large images as if
12384 x_create_x_image_and_pixmap failed, not as malloc failures.
12385 (gs_load): Use x_check_image_size.
12386
5f8f9cc2
PE
12387 * gtkutil.c: Omit integer casts.
12388 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12389 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12390
5adf60bc
PE
12391 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12392
c8907a93
PE
12393 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12394 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12395 would wrongly return t on a 64-bit host.
12396
e3c25c68
PE
12397 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12398 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12399 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12400 and therefore cause GCC to emit a bogus diagnostic in some cases.
12401
3f791afe
PE
12402 * image.c: Integer signedness and overflow and related fixes.
12403 This is not an exhaustive set of fixes, but it's time to
12404 record what I've got.
12405 (lookup_pixel_color, check_image_size): Remove redundant decls.
12406 (check_image_size): Don't assume that arbitrary EMACS_INT values
12407 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12408 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12409 (tiff_load, imagemagick_load_image):
12410 Check for overflow in size calculations.
12411 (x_create_x_image_and_pixmap): Remove unnecessary test for
12412 xmalloc returning NULL; that can't happen.
12413 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12414 (xpm_color_bucket): Use better integer hashing function.
12415 (xpm_cache_color): Don't possibly over-allocate memory.
12416 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12417 (gif_memory_source):
12418 Use ptrdiff_t, not int or size_t, to record sizes.
12419 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12420 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12421 either works, as we prefer signed integers.
12422 (tiff_read_from_memory, tiff_write_from_memory):
12423 Return tsize_t, not size_t, since that's what the TIFF API wants.
12424 (tiff_read_from_memory): Don't fail simply because the read would
12425 go past EOF; instead, return a short read.
12426 (tiff_load): Omit no-longer-needed casts.
12427 (Fimagemagick_types): Don't assume size fits into 'int'.
12428
3cc5a532
PE
12429 Improve hashing quality when configured --with-wide-int.
12430 * fns.c (hash_string): New function, taken from sxhash_string.
12431 Do not discard information about ASCII character case; this
12432 discarding is no longer needed.
12433 (sxhash-string): Use it. Change sig to match it. Caller changed.
12434 * lisp.h: Declare it.
12435 * lread.c (hash_string): Remove, since we now use fns.c's version.
12436 The fns.c version returns a wider integer if --with-wide-int is
12437 specified, so this should help the quality of the hashing a bit.
12438
b312a492
PE
12439 * emacs.c: Integer overflow minor fix.
12440 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12441 Define only if GNU_LINUX.
12442 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12443
dfd153ae
PE
12444 * dispnew.c: Integer signedness and overflow fixes.
12445 Remove unnecessary forward decls, that were a maintenance hassle.
12446 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12447 All uses changed.
12448 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12449 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12450 (prepare_desired_row, line_draw_cost):
12451 Use int, not unsigned, where either works.
12452 (save_current_matrix, restore_current_matrix):
12453 Use ptrdiff_t, not size_t, where either works.
12454 (init_display): Check for overflow more accurately, and without
12455 relying on undefined behavior.
12456
a81d11a3
PE
12457 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12458 Remove, replacing with the new symbols in lisp.h. All uses changed.
12459 * fileio.c (make_temp_name):
12460 * filelock.c (lock_file_1, lock_file):
12461 * xdisp.c (message_dolog):
12462 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12463 Use pMd etc. instead.
12464 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12465 replacing the pWIDE etc. symbols removed from editfns.c.
12466
3300e6fd
PE
12467 * keyboard.h (num_input_events): Now uintmax_t.
12468 This is (very slightly) less likely to mess up due to wraparound.
12469 All uses changed.
12470
fd05c7e9
PE
12471 * buffer.c: Integer signedness fixes.
12472 (alloc_buffer_text, enlarge_buffer_text):
12473 Use ptrdiff_t rather than size_t when either will do, as we prefer
12474 signed integers.
12475
903fe15d
PE
12476 * alloc.c: Integer signedness and overflow fixes.
12477 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12478 (__malloc_size_t): Default to size_t, not to int.
12479 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12480 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12481 Prefer ptrdiff_t to size_t when either would do, as we prefer
12482 signed integers.
12483 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12484 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12485 Now const. Initialize with values that are in range even if char
12486 is signed.
12487 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12488 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12489 These functions do the right thing with sizes > 2**32.
12490 (check_depth): Now ptrdiff_t, not int.
12491 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12492 Adjust to new way of storing sizes. Check for size overflow bugs
12493 in rest of code.
12494 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12495 slightly wrong anyway, as it missed one instance of
12496 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12497 (refill_memory_reserve): Omit needless cast to size_t.
12498 (mark_object_loop_halt): Mark as externally visible.
12499
ac82cc6a
PE
12500 * xselect.c: Integer signedness and overflow fixes.
12501 (Fx_register_dnd_atom, x_handle_dnd_message):
12502 Use ptrdiff_t, not size_t, since we prefer signed.
12503 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12504 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12505 x_dnd_atoms_size and x_dnd_atoms_length.
12506
c2d1e36d
PE
12507 * doprnt.c: Prefer signed to unsigned when either works.
12508 * eval.c (verror):
12509 * doprnt.c (doprnt):
12510 * lisp.h (doprnt):
12511 * xdisp.c (vmessage):
12512 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12513 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12514 prefer signed arithmetic to avoid comparison confusion.
12515 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12516 but is a bit tricky.
12517
0e926e56
PE
12518 Assume freestanding C89 headers, string.h, stdlib.h.
12519 * data.c, doprnt.c, floatfns.c, print.c:
12520 Include float.h unconditionally.
12521 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12522 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12523 * regex.c: Likewise for stddef.h, string.h.
12524 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12525 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12526 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12527 (STDC_HEADERS): Remove obsolete defines.
12528 * sysdep.c: Include limits.h unconditionally.
12529
9cfdb3ec
PE
12530 Assume support for memcmp, memcpy, memmove, memset.
12531 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12532 * regex.c (memcmp, memcpy):
12533 Remove; we assume C89 now.
12534
12535 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12536 (__malloc_safe_bcopy): Remove; no longer needed.
12537
cf950e6b 12538 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12539 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12540 well either way, and we prefer signed to unsigned.
12541
dbf38e02
LMI
125422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12543
12544 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12545 closes the connection while we're reading (bug#9182).
12546
d6f0886c 125472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12548
d6f0886c
JD
12549 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12550 are specified (Bug#9168).
24e0f6b1 12551
2eb1f9e6
PE
125522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12553
12554 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12555 Found by GCC static checking and --with-wide-int on a 32-bit host.
12556
22381272 125572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12558
12559 * xdisp.c (compute_display_string_pos): Fix logic of caching
12560 previous display string position. Initialize cached_prev_pos to
12561 -1. Fixes slow-down at the beginning of a buffer.
12562
f25e39b4
EZ
125632011-07-24 Eli Zaretskii <eliz@gnu.org>
12564
12565 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12566 for attrs[LFACE_FONTSET_INDEX].
12567
04c4b52e
PE
125682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12569
12570 * xml.c (parse_region): Remove unused local
12571 that was recently introduced.
12572
c1734fbd
EZ
125732011-07-23 Eli Zaretskii <eliz@gnu.org>
12574
be18c5a5
EZ
12575 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12576 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12577
c1734fbd
EZ
12578 * xdisp.c (move_it_in_display_line_to): Record the best matching
12579 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12580 exit if none of the characters scanned was an exact match.
12581 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12582 when exact match is impossible due to invisible text, and the
12583 lines are truncated.
12584
a258d627
JD
125852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12586
12587 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12588 for OSX >= 10.7.
12589
b6d5a689
EZ
125902011-07-22 Eli Zaretskii <eliz@gnu.org>
12591
0f74f785
EZ
12592 Fix a significant slow-down of cursor motion with C-n, C-p,
12593 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12594 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12595 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12596 (next_element_from_buffer): Call compute_stop_pos_backwards to
12597 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12598 base_level_stop.
12599 (reseat): Don't look for prev_stop, as that could mean a very long
12600 run.
12601 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12602 <cached_disp_overlay_modiff>: Cache for last found display string
12603 position.
551918c1 12604 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12605 about the same buffer in the same area of character positions, and
12606 the buffer wasn't changed since the time the display string
12607 position was cached.
551918c1 12608
b2d0c91a
EZ
126092011-07-22 Eli Zaretskii <eliz@gnu.org>
12610
12611 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12612 is an integer, which is important for empty lines. (Bug#9149)
12613
043604ee
CY
126142011-07-22 Chong Yidong <cyd@stupidchicken.com>
12615
12616 * frame.c (Fmodify_frame_parameters): In tty case, update the
12617 default face if necessary (Bug#4238).
12618
da4adb04
CY
126192011-07-21 Chong Yidong <cyd@stupidchicken.com>
12620
12621 * editfns.c (Fstring_to_char): No need to explain what a character
12622 is in the docstring (Bug#6576).
12623
9abd0532
LMI
126242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12625
12626 * xml.c (parse_region): Make sure we always return a tree.
12627
36881d16
HK
126282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12629
12630 * xml.c (parse_region): If a document contains only comments,
12631 return that, too.
12632
1e98674d
LMI
126332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12634
12635 * xml.c (make_dom): Return comments, too.
12636
590bd467
PE
126372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12638
12639 Port to OpenBSD.
12640 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12641 and the surrounding thread.
12642 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12643 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12644 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12645 timer goes off.
12646 * s/openbsd.h (BROKEN_SIGIO): Define.
12647 * unexelf.c (unexec) [__OpenBSD__]:
12648 Don't update the .mdebug section of the Alpha COFF symbol table.
12649
f41628b2
LMI
126502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12651
12652 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12653 (bug#8460).
12654
b59b67c5
PE
126552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12656
15e3a074
PE
12657 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12658 This fixes some race conditions on the permissions of any newly
12659 created file.
12660
41bed37d
PE
12661 * alloc.c (valid_pointer_p): Use pipe, not open.
12662 This fixes some permissions issues when debugging.
12663
b59b67c5
PE
12664 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12665 If fchown fails to set both uid and gid, try to set just gid,
12666 as that is sometimes allowed. Adjust the file's mode to eliminate
12667 setuid or setgid bits that are inappropriate if fchown fails.
12668
925a6be7
SM
126692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12670
12671 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12672 to compare Lisp_Objects.
12673 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12674 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12675 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12676
52968808
AS
126772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12678
0a6a104b
AS
12679 * lread.c (read_integer): Unread even EOF character.
12680 (read1): Likewise. Properly record start position of symbol.
12681
52968808
AS
12682 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12683 symbol character follows.
12684
9e381cdd
PE
126852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12686
12687 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12688 This works around a problem with the previous change to Fcopy_file.
12689 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12690 and without this change, GCC might complain about discarding
12691 fchown's return value.
12692
b5641435
JB
126932011-07-16 Juanma Barranquero <lekktu@gmail.com>
12694
12695 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12696
a8031457
PE
126972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12698
12699 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12700
dd889327
LMI
127012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12702
750c33f7
LMI
12703 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12704 it's used from the C level.
12705
dd889327
LMI
12706 * process.c: Use the same condition for POLL_FOR_INPUT in both
12707 keyboard.c and process.c (bug#1858).
12708
87e86684
LM
127092011-07-09 Lawrence Mitchell <wence@gmx.li>
12710
12711 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12712 (Fgnutls_boot): Use it.
12713
64348f40
AS
127142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12715
12716 * doc.c (Fsubstitute_command_keys): Revert last change.
12717
1d698799
LMI
127182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12719
f863868c
LMI
12720 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12721 quotes the next character, and doesn't affect other longer
12722 sequences (bug#8935).
12723
1d698799
LMI
12724 * lread.c (syms_of_lread): Clarify that is isn't only
12725 `eval-buffer' and `eval-defun' that's affected by
12726 `lexical-binding' (bug#8460).
12727
aa4b6df6
EZ
127282011-07-15 Eli Zaretskii <eliz@gnu.org>
12729
12730 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12731 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12732
5d856da6
PE
127332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12734
ad6042bb
PE
12735 Fix minor problems found by static checking.
12736 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12737 (elsz): Now a signed constant, not a size_t var. We prefer signed
12738 types to unsigned, to avoid integer comparison confusion. Without
12739 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12740 "cannot optimize loop, the loop counter may overflow", a symptom
12741 of the confusion.
f00bbb22 12742 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12743 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12744
6468f31c
LMI
127452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12746
49080b10
LMI
12747 * search.c (Fre_search_backward): Mention `case-fold-search' in
12748 all the re_search_* functions (bug#8138).
12749
6468f31c
LMI
12750 * keyboard.c (Fopen_dribble_file): Document when the file is
12751 closed (bug#8056).
12752
c965adc5
EZ
127532011-07-14 Eli Zaretskii <eliz@gnu.org>
12754
df9733bf
EZ
12755 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12756 bidi_cache_idx.
12757
0bb23927
EZ
12758 Support bidi reordering of display and overlay strings.
12759 * xdisp.c (compute_display_string_pos)
12760 (compute_display_string_end): Accept additional argument STRING.
12761 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12762 (reseat_to_string): Initialize bidi_it->string.s and
12763 bidi_it->string.schars.
12764 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12765 NULL (avoids a crash in bidi_paragraph_init).
12766 Initialize itb.string.lstring.
0bb23927
EZ
12767 (init_iterator): Call bidi_init_it only of a valid
12768 buffer position was specified. Initialize paragraph_embedding to
12769 L2R.
12770 (reseat_to_string): Initialize the bidi iterator.
12771 (display_string): If we need to ignore text properties of
12772 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12773 original value of -1 will not work with bidi.)
12774 (compute_display_string_pos): First arg is now struct
12775 `text_pos *'; all callers changed. Support display properties on
12776 Lisp strings.
12777 (compute_display_string_end): Support display properties on Lisp
12778 strings.
12779 (init_iterator, reseat_1, reseat_to_string): Initialize the
12780 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12781 when iterating on a string not from display properties).
640c8776
SM
12782 (compute_display_string_pos, compute_display_string_end):
12783 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12784 arrow keys.
12785 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12786 base_level_stop; instead, set base_level_stop to BEGV.
12787 Fixes crashes in vertical-motion.
0bb23927
EZ
12788 (next_element_from_buffer): Improve commentary for when
12789 the iterator is before prev_stop.
12790 (init_iterator): Initialize bidi_p from the default value of
12791 bidi-display-reordering, not from buffer-local value. Use the
12792 buffer-local value only if initializing for buffer iteration.
12793 (handle_invisible_prop): Support invisible properties on strings
12794 that are being bidi-reordered.
12795 (set_iterator_to_next): Support bidi reordering of C strings and
12796 Lisp strings.
12797 (next_element_from_string): Support bidi reordering of Lisp
12798 strings.
12799 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12800 (display_string): Support display of R2L glyph rows.
12801 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12802 (init_iterator): Don't initialize it->bidi_p for strings
12803 here.
12804 (reseat_to_string): Initialize it->bidi_p for strings here.
12805 (next_element_from_string, next_element_from_c_string)
12806 (next_element_from_buffer): Add xassert's for correspondence
12807 between IT's object being iterated and it->bidi_it.string
12808 structure.
12809 (face_before_or_after_it_pos): Support bidi iteration.
12810 (next_element_from_c_string): Handle the case of the first string
12811 character that is not the first one in the visual order.
12812 (get_visually_first_element): New function, refactored from common
12813 parts of next_element_from_buffer, next_element_from_string, and
12814 next_element_from_c_string.
12815 (tool_bar_lines_needed, redisplay_tool_bar)
12816 (display_menu_bar): Force left-to-right direction. Add a FIXME
12817 comment for making that be controlled by a user option.
12818 (push_it, pop_it): Save and restore the state of the
12819 bidi iterator. Save and restore the bidi_p flag.
12820 (pop_it): Iterate out of display property for string iteration as
12821 well.
12822 (iterate_out_of_display_property): Support iteration over strings.
12823 (handle_single_display_spec): Set up it->bidi_it for iteration
12824 over a display string, and call bidi_init_it.
12825 (handle_single_display_spec, next_overlay_string)
12826 (get_overlay_strings_1, push_display_prop): Set up the bidi
12827 iterator for displaying display or overlay strings.
12828 (forward_to_next_line_start): Don't use the shortcut if
12829 bidi-iterating.
12830 (back_to_previous_visible_line_start): If handle_display_prop
12831 pushed the iterator stack, restore the internal state of the bidi
12832 iterator by calling bidi_pop_it same number of times.
12833 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12834 and we are bidi-iterating, don't decrement the iterator position;
12835 instead, set the first_elt flag in the bidi iterator, to produce
12836 the same effect.
12837 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12838 (push_display_prop): xassert that we are iterating a buffer.
12839 (push_it, pop_it): Save and restore paragraph_embedding member.
12840 (handle_single_display_spec, next_overlay_string)
12841 (get_overlay_strings_1, reseat_1, reseat_to_string)
12842 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12843 correctly. Don't assume unibyte strings are not bidi-reordered.
12844 (compute_display_string_pos)
12845 (compute_display_string_end): Fix handling the case of C string.
12846 (push_it, pop_it): Save and restore from_disp_prop_p.
12847 (handle_single_display_spec, push_display_prop): Set the
12848 from_disp_prop_p flag.
12849 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12850 (pop_it): Call iterate_out_of_display_property only if we are
12851 popping after iteration over a string that came from a display
12852 property. Fix a typo in popping stretch info. Add an assertion
12853 for verifying that the iterator position is in sync with the bidi
12854 iterator.
12855 (handle_single_display_spec, get_overlay_strings_1)
12856 (push_display_prop): Fix initialization of paragraph direction for
12857 string when that of the parent object is not yet determined.
12858 (reseat_1): Call bidi_init_it to resync the bidi
12859 iterator with IT's position. (Bug#7616)
12860 (find_row_edges): If ROW->start.pos gives position
12861 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12862 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12863 Reset the from_disp_prop_p flag.
12864 (SAVE_IT, RESTORE_IT): New macros.
12865 (pos_visible_p, face_before_or_after_it_pos)
12866 (back_to_previous_visible_line_start)
12867 (move_it_in_display_line_to, move_it_in_display_line)
12868 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12869 (try_scrolling, redisplay_window, display_line): Use them when
12870 saving a temporary copy of the iterator and restoring it back.
12871 (back_to_previous_visible_line_start, reseat_1)
12872 (init_iterator): Empty the bidi cache "stack".
12873 (move_it_in_display_line_to): If iterator ended up at
12874 EOL, but we never saw any buffer positions smaller than
12875 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12876 motion in bidi-reordered lines.
12877 (move_it_in_display_line_to): Record prev_method and prev_pos
12878 immediately before the call to set_iterator_to_next. Fixes cursor
12879 motion in bidi-reordered lines with stretch glyphs and strings
12880 displayed in margins. (Bug#8133) (Bug#8867)
12881 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12882 TO_CHARPOS.
640c8776
SM
12883 (pos_visible_p): Support positions in bidi-reordered lines.
12884 Save and restore bidi cache.
0bb23927
EZ
12885
12886 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12887 (bidi_paragraph_info): Delete unused struct.
12888 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12889 (bidi_cache_start): New variable.
12890 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12891 to zero.
12892 (bidi_cache_fetch_state, bidi_cache_search)
12893 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12894 (bidi_cache_find, bidi_peek_at_next_level)
12895 (bidi_level_of_next_char, bidi_find_other_level_edge)
12896 (bidi_move_to_visually_next): Compare cache index with
12897 bidi_cache_start rather than with zero.
12898 (bidi_fetch_char): Accept new argument STRING; all callers
12899 changed. Support iteration over a string. Support strings with
12900 display properties. Support unibyte strings. Fix the type of
12901 `len' according to what STRING_CHAR_AND_LENGTH expects.
12902 (bidi_paragraph_init, bidi_resolve_explicit_1)
12903 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12904 (bidi_level_of_next_char, bidi_move_to_visually_next):
12905 Support iteration over a string.
0bb23927
EZ
12906 (bidi_set_sor_type, bidi_resolve_explicit_1)
12907 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12908 can now be zero (for strings); special values 0 and -1 were
12909 changed to -1 and -2, respectively.
12910 (bidi_char_at_pos): New function.
12911 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12912 Call it instead of FETCH_MULTIBYTE_CHAR.
12913 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12914 initialized to valid values.
12915 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12916 values.
12917 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12918 the test for valid cached positions. Fix the logic for looking up
12919 the sentinel state in the cache. GCPRO the Lisp string we are
12920 iterating.
12921 (bidi_push_it, bidi_pop_it): New functions.
12922 (bidi_initialize): Initialize the bidi cache start stack pointer.
12923 (bidi_cache_ensure_space): New function, refactored from part of
12924 bidi_cache_iterator_state. Don't assume the required size is just
12925 one BIDI_CACHE_CHUNK away.
12926 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12927 (bidi_count_bytes, bidi_char_at_pos): New functions.
12928 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12929 always valid if bidi_cache_idx is valid.
12930 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12931 is valid if it's going to be used.
12932 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12933 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12934 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12935 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12936 (bidi_find_other_level_edge, bidi_cache_start_stack):
12937 All variables related to cache indices are now EMACS_INT.
c965adc5 12938
0bb23927
EZ
12939 * dispextern.h (struct bidi_string_data): New structure.
12940 (struct bidi_it): New member `string'. Make flag members be 1-bit
12941 fields, and put them last in the struct.
640c8776
SM
12942 (compute_display_string_pos, compute_display_string_end):
12943 Update prototypes.
0bb23927
EZ
12944 (bidi_push_it, bidi_pop_it): Add prototypes.
12945 (struct iterator_stack_entry): New members bidi_p,
12946 paragraph_embedding, and from_disp_prop_p.
12947 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12948 (bidi_shelve_cache, bidi_unshelve_cache):
12949 Declare prototypes.
0bb23927
EZ
12950
12951 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12952 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12953 and vector-like objects.
12954
12955 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12956 cache around display iteration.
12957
12958 * window.c (Fwindow_end, window_scroll_pixel_based)
12959 (displayed_window_lines, Frecenter): Save and restore the bidi
12960 cache around display iteration.
12961
3bbd2265
LMI
129622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12963
12964 * editfns.c (Fdelete_region): Clarify the use of the named
12965 parameters (bug#6788).
12966
adc47434
MR
129672011-07-14 Martin Rudalics <rudalics@gmx.at>
12968
12969 * indent.c (Fvertical_motion): Set and restore w->pointm when
12970 saving and restoring the window's buffer (Bug#9006).
12971
837c31f8
LMI
129722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12973
12974 * editfns.c (Fstring_to_char): Clarify just what is returned
12975 (bug#6576). Text by Eli Zaretskii.
12976
ac389d0c
JB
129772011-07-13 Juanma Barranquero <lekktu@gmail.com>
12978
12979 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12980
0be0ce47
EZ
129812011-07-13 Eli Zaretskii <eliz@gnu.org>
12982
12983 * buffer.c (mmap_find): Fix a typo.
12984
cd18e7e3
JB
129852011-07-13 Johan Bockgård <bojohan@gnu.org>
12986
12987 Fix execution of x selection hooks.
12988 * xselect.c (Qx_lost_selection_functions)
12989 (Qx_sent_selection_functions): New vars.
12990 (syms_of_xselect): DEFSYM them.
12991 (x_handle_selection_request): Pass Qx_sent_selection_functions
12992 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12993 (x_handle_selection_clear,x_clear_frame_selections):
12994 Pass Qx_lost_selection_functions rather than
12995 Vx_lost_selection_functions to Frun_hook_with_args.
12996
47ea7f44
PE
129972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12998
ac389d0c 12999 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
13000 The old code sometimes used this field without initializing it.
13001
47ea7f44
PE
13002 * alloc.c (gc_sweep): Don't read past end of array.
13003 In theory, the old code could also have corrupted Emacs internals,
13004 though it'd be very unlikely.
13005
bc985c87
AS
130062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
13007
13008 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 13009 argument. (Bug#4026)
bc985c87 13010
0cf34688
LMI
130112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
13012
b3dadd76
LMI
13013 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
13014 key" (bug#4257).
13015
0cf34688
LMI
13016 * window.c (Fset_window_start): Doc fix (bug#4199).
13017 (Fset_window_hscroll): Ditto.
13018
270768cd
PE
130192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
13020
077e3dda 13021 Fix minor new problems caught by GCC 4.6.1.
270768cd 13022 * term.c (init_tty): Remove unused local.
490011a6 13023 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 13024 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 13025 not used otherwise.
270768cd 13026
b1f58454
CY
130272011-07-12 Chong Yidong <cyd@stupidchicken.com>
13028
13029 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
13030
22b9578d
LMI
130312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
13032
6e70ab07
LMI
13033 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
13034 are the mini-buffer and the echo area (bug#3320).
13035
22b9578d
LMI
13036 * term.c (init_tty): Remove support for supdup, c10 and perq
13037 terminals, which are no longer supported (bug#1482).
13038
8974cc9f
JB
130392011-07-10 Johan Bockgård <bojohan@gnu.org>
13040
13041 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
13042
a560d974
JD
130432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
13044
13045 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
13046 for non-popups (Bug#3642).
13047
1dae0f0a
AS
130482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
13049
268c2c36 13050 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 13051 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
13052 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
13053 * cm.c (losecursor): Likewise.
1dae0f0a
AS
13054 * data.c (fmod): Likewise.
13055 * dispnew.c (swap_glyphs_in_rows): Likewise.
13056 * emacs.c (memory_warning_signal): Likewise.
13057 * floatfns.c (float_error): Likewise.
13058 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
13059 (otf_open, font_otf_capability, generate_otf_features)
13060 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
13061 Likewise.
13062 * image.c (pbm_read_file): Likewise.
13063 * indent.c (string_display_width): Likewise.
13064 * intervals.c (check_for_interval, search_for_interval)
13065 (inc_interval_count, count_intervals, root_interval)
13066 (adjust_intervals_for_insertion, make_new_interval): Likewise.
13067 * lread.c (defalias): Likewise.
268c2c36 13068 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
13069 * regex.c (set_image_of_range_1, set_image_of_range)
13070 (regex_grow_registers): Likewise.
13071 * sysdep.c (strerror): Likewise.
13072 * termcap.c (valid_filename_p, tprint, main): Likewise.
13073 * tparam.c (main): Likewise.
13074 * unexhp9k800.c (run_time_remap, save_data_space)
13075 (update_file_ptrs, read_header, write_header, calculate_checksum)
13076 (copy_file, copy_rest, display_header): Likewise.
13077 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
13078 Likewise.
13079 * xdisp.c (check_it): Likewise.
13080 * xfaces.c (register_color, unregister_color, unregister_colors):
13081 Likewise.
13082 * xfns.c (print_fontset_result): Likewise.
13083 * xrdb.c (member, fatal, main): Likewise.
13084
99033785
PE
130852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
13086
13087 Fix minor problems found by static checking (Bug#9031).
13088 * chartab.c (char_table_set_range, map_sub_char_table):
13089 Remove unused locals.
13090 (uniprop_table): Now static.
13091 * composite.c (_work_char): Remove unused static var.
13092
9cb2ac56
JB
130932011-07-09 Juanma Barranquero <lekktu@gmail.com>
13094
13095 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13096
f25661f0
JD
130972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
13098
13099 * gtkutil.c (qttip_cb): Remove code without function.
13100
8278c4fe
EZ
131012011-07-09 Eli Zaretskii <eliz@gnu.org>
13102
13103 * w32.c (pthread_sigmask): New stub.
13104
1692ae2d 131052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 13106
8a6ebd58 13107 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
13108 sigprocmask is portable only for single-threaded applications, and
13109 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13110 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
13111 (LIBES): Use it.
13112 * callproc.c (Fcall_process):
13113 * process.c (create_process):
13114 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
13115 Use pthread_sigmask, not sigprocmask.
123403e4 13116
1b854618
JD
131172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13118
13119 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
13120 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
13121 wrong (Bug#8591).
13122
3fe4b549
JD
131232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13124
0ce7e563
JD
13125 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
13126 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
13127 (xg_hide_tooltip): Fix comment.
13128
3fe4b549
JD
13129 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
13130 in registerServicesMenuSendTypes.
13131 (validRequestorForSendType): Don't check ns_return_types.
13132
13133 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
13134 ns_return_type.
13135
5df75e47
JR
131362011-07-08 Jason Rumney <jasonr@gnu.org>
13137
22610910
JR
13138 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
13139 SH_SHOW for hidden windows (Bug#5482).
13140
5df75e47
JR
13141 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13142 frame struct members of non-existent frames (Bug#6284).
13143
699c10bd
JD
131442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13145
4393663b
JD
13146 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
13147 variable firstTime not needed on OSX >= 10.6.
13148 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
13149 >= 10.5. Use setKnobProportion, setDoubleValue.
13150
13151 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
13152 (MAC_OS_X_VERSION_10_5): Define if not defined.
13153 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
13154 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
13155 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
13156
13157 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 13158 cString and lossyCString on OSX >= 10.4.
4393663b 13159
58179cce 13160 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
13161 sizeToFit on OSX >= 10.2.
13162
13163 * nsimage.m (allocInitFromFile): Don't use deprecated method
13164 bestRepresentationForDevice on OSX >= 10.6.
13165
13166 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
13167 to avoid warning.
13168
13169 * emacs.c: Declare unexec_init_emacs_zone.
13170
a63e0781
JD
13171 * nsgui.h: Fix compiler warning about gnulib redefining verify.
13172
699c10bd
JD
13173 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
13174
13175 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
13176 on svcsMenu (Bug#8842).
13177
13178 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
13179 ns_return_types.
13180 (Fns_list_services): Just return Qnil on 10.6, code not working there.
13181
13182 * nsterm.m (QUTF8_STRING): Declare.
13183 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
13184 (validRequestorForSendType): Return type is (id).
13185 Change indexOfObjectIdenticalTo to indexOfObject.
13186 Check if we have local selection before returning self (Bug#8842).
13187 (writeSelectionToPasteboard): Put local selection into paste board
13188 if we have a local selection (Bug#8842).
13189 (syms_of_nsterm): DEFSYM QUTF8_STRING.
13190
13191 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
13192 (ns_get_local_selection): Declare.
13193
54e10184
LMI
131942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
13195
9888ff71
LMI
13196 * keymap.c (describe_map_tree): Don't insert a double newline at
13197 the end of the buffer (bug#1169) and return whether we inserted
13198 something.
13199
54e10184
LMI
13200 * callint.c (Fcall_interactively): Change "reading args" to
13201 "providing args" to try to clarify what it does (bug#1010).
13202
15fa4783
KH
132032011-07-07 Kenichi Handa <handa@m17n.org>
13204
13205 * composite.c (composition_compute_stop_pos): Ignore a static
13206 composition starting before CHARPOS (Bug#8915).
13207
13208 * xdisp.c (handle_composition_prop): Likewise.
13209
a8815b00
EZ
132102011-07-07 Eli Zaretskii <eliz@gnu.org>
13211
13212 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
13213 (Bug#9015)
13214
ef7b981d 132152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13216
13217 * character.h (unicode_category_t): New enum type.
13218
13219 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13220 (Qchar_code_property_table): New variable.
13221 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13222 (UNIPROP_COMPRESSED_FORM_P): New macros.
13223 (char_table_ascii): Uncompress the compressed values.
13224 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13225 Uncompress the compressed values.
ac389d0c 13226 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13227 (char_table_ref_and_range): Uncompress the compressed values.
13228 (sub_char_table_set): New arg is_uniprop. Callers changed.
13229 Uncompress the compressed values.
13230 (sub_char_table_set_range): Args changed. Callers changed.
13231 (char_table_set_range): Adjuted for the above change.
13232 (map_sub_char_table): Delete args default_val and parent. Add arg
13233 top. Give decoded values to a Lisp function.
640c8776 13234 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13235 values to a Lisp function. Gcpro more variables.
13236 (uniprop_table_uncompress)
13237 (uniprop_decode_value_run_length): New functions.
13238 (uniprop_decoder, uniprop_decoder_count): New variables.
13239 (uniprop_get_decoder, uniprop_encode_value_character)
13240 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13241 New functions.
13242 (uniprop_encoder, uniprop_encoder_count): New variables.
13243 (uniprop_get_encoder, uniprop_table)
13244 (Funicode_property_table_internal, Fget_unicode_property_internal)
13245 (Fput_unicode_property_internal): New functions.
13246 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13247 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13248 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13249 char-code-property-alist.
13250
640c8776 13251 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13252 Vunicode_category_table.
13253
640c8776 13254 * font.c (font_range): Adjust for the change of
c805dec0
KH
13255 Vunicode_category_table.
13256
76b397fb
DN
132572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13258
13259 * m/iris4d.h: Remove file, move contents ...
13260 * s/irix6-5.h: ... here.
13261
22b4128e
PE
132622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13263
13264 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13265 * alloc.c (mark_buffer):
13266 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13267 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13268 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13269 This isn't true in general, and it's particularly not true
13270 if Emacs is configured with --with-wide-int.
13271 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13272 New macros, used in the buffer.c change.
13273
869795d6
JD
132742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13275
13276 * xsettings.c: Use both GConf and GSettings if both are available.
13277 (store_config_changed_event): Add comment.
13278 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13279 (store_tool_bar_style_changed): New functions.
5e617bc2 13280 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13281 (struct xsettings): Move font inside HAVE_XFT.
13282 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13283 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13284 Move inside HAVE_XFT.
640c8776 13285 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13286 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13287 also.
13288 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13289 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13290 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13291 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13292 (parse_settings): Move check for font inside HAVE_XFT.
13293 (read_settings, apply_xft_settings): Add comment.
13294 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13295 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13296 call store_font_name_changed.
13297 (xft_settings_event): Add comment.
13298 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13299 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13300 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13301 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13302 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13303 (xsettings_get_system_font, xsettings_get_system_normal_font):
13304 Add comment.
869795d6 13305
d8ed26bd
PE
133062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13307
13308 Random fixes. E.g., (random) never returned negative values.
13309 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13310 subseconds part to the entropy, as that's a bit more random.
13311 Prefer signed to unsigned, since the signedness doesn't matter and
13312 in general we prefer signed. When given a limit, use a
13313 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13314 latter isn't right if USE_2_TAGS_FOR_INTS.
13315 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13316 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13317
cabf1cac
SM
133182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13319
13320 * textprop.c (text_property_stickiness):
13321 Obey Vtext_property_default_nonsticky.
13322 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13323 * w32fns.c (syms_of_w32fns):
13324 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13325
6e9b2be9
PE
133262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13327
13328 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13329 This is more efficient than Ffile_directory_p and avoids a minor race.
13330
90186c68
LMI
133312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13332
7c301272
LMI
13333 * buffer.c (Foverlay_put): Say what the return value is
13334 (bug#7835).
13335
c4f2d8d4
LMI
13336 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13337 is a directory before asking whether to use the file name
13338 (bug#7564).
ad637907
LMI
13339 (barf_or_query_if_file_exists): Make the "File is a directory"
13340 error be more correct.
c4f2d8d4 13341
90186c68
LMI
13342 * fns.c (Frequire): Remove the mention of the .gz files, since
13343 that's installation-specific, but keep the mention of
13344 `get-load-suffixes'.
13345
da64016e
PE
133462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13347
13348 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13349 Report string overflow if the output is too long.
13350
7d47b580
JB
133512011-07-04 Juanma Barranquero <lekktu@gmail.com>
13352
a555cb87
JB
13353 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13354 (syms_of_gnutls): Remove duplicate DEFSYM for
13355 Qgnutls_bootprop_verify_hostname_error, an error for
13356 Qgnutls_bootprop_verify_error (which is no longer used).
13357
7d47b580
JB
13358 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13359 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13360 Also (re)move comments that are misplaced or no longer relevant.
13361
1e49bfab
LMI
133622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13363
13364 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13365
1485f4c0
CY
133662011-07-03 Chong Yidong <cyd@stupidchicken.com>
13367
13368 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13369 and background color parameters if they have been changed.
13370
a9ab721e
LMI
133712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13372
13373 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13374
cf7cff57
PE
133752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13376
2e13213d
PE
13377 * xsettings.c (SYSTEM_FONT): Define only when used.
13378 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13379
cf7cff57
PE
13380 * keymap.c (access_keymap_1): Now static.
13381
7a8e04f7
CY
133822011-07-02 Chong Yidong <cyd@stupidchicken.com>
13383
13384 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13385 leave any prefix arg for the up event (Bug#1586).
13386
61352f62
LMI
133872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13388
69bb1ef7
LMI
13389 * lread.c (syms_of_lread): Mention single symbols defined by
13390 `defvar' or `defconst' (bug#7154).
13391
61352f62 13392 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13393 (Frequire): Mention get-load-suffixes.
61352f62 13394
28545e04
MR
133952011-07-02 Martin Rudalics <rudalics@gmx.at>
13396
13397 * window.h (window): Remove clone_number slot.
13398 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13399 Remove.
13400 (make_parent_window, make_window, saved_window)
13401 (Fset_window_configuration, save_window_save): Don't deal with
13402 clone numbers.
13403 * buffer.c (Qclone_number): Remove declaration.
13404 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13405
3349e122
SM
134062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13407
13408 Add multiple inheritance to keymaps.
13409 * keymap.c (Fmake_composed_keymap): New function.
13410 (Fset_keymap_parent): Simplify.
13411 (fix_submap_inheritance): Remove.
13412 (access_keymap_1): New function extracted from access_keymap to handle
13413 embedded parents and handle lists of maps.
13414 (access_keymap): Use it.
13415 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13416 (Fcopy_keymap): Handle embedded parents.
13417 (Fcommand_remapping, define_as_prefix): Simplify.
13418 (Fkey_binding): Simplify.
13419 (syms_of_keymap): Move minibuffer-local-completion-map,
13420 minibuffer-local-filename-completion-map,
13421 minibuffer-local-must-match-map, and
13422 minibuffer-local-filename-must-match-map to Elisp.
13423 (syms_of_keymap): Defsubr make-composed-keymap.
13424 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13425 (parse_menu_item): Trivial simplification.
13426
3279eb87
GM
134272011-07-01 Glenn Morris <rgm@gnu.org>
13428
13429 * Makefile.in (SETTINGS_LIBS): Fix typo.
13430
39cb9e56 134312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13432
13433 * coding.c (Fencode_coding_string): Record the last coding system
13434 used, as the function doc string says (bug#8738).
13435
0949d2b6
JD
134362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13437
13438 * xsettings.c (store_monospaced_changed): Take new font as arg and
13439 check for change against current_mono_font.
13440 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13441 (emacs_settings_constructor, emacs_settings_get_property)
13442 (emacs_settings_set_property, emacs_settings_class_init)
13443 (emacs_settings_init, gsettings_obj): Remove.
13444 (something_changedCB): New function for HAVE_GSETTINGS.
13445 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13446 with value as argument.
13447 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13448 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13449 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13450 "changed".
13451
13452 * xgselect.c: Add defined (HAVE_GSETTINGS).
13453 (xgselect_initialize): Ditto.
13454
13455 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13456 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13457 xg_select.
13458
bbc6b304
PE
134592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13460
13461 * eval.c (struct backtrace): Simplify and port the data structure.
13462 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13463 signed bit field, as this assumption is not portable and it makes
13464 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13465 "char debug_on_exit : 1" as this is not portable either; instead,
13466 use the portable "unsigned int debug_on_exit : 1". Remove unused
13467 member evalargs. Remove obsolete comments about cc bombing out.
13468
9851bfc5
JD
134692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13470
51bb811f 13471 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13472 Let HAVE_GSETTINGS override HAVE_GCONF.
13473 (store_monospaced_changed): New function.
13474 (EMACS_SETTINGS): A new type derived from GObject to handle
13475 GSettings notifications.
13476 (emacs_settings_constructor, emacs_settings_get_property)
13477 (emacs_settings_set_property, emacs_settings_class_init):
13478 New functions.
13479 (gsettings_client, gsettings_obj): New variables.
13480 (GSETTINGS_SCHEMA): New define.
13481 (something_changedCB): Call store_monospaced_changed.
13482 (init_gsettings): New function.
13483 (xsettings_initialize): Call init_gsettings.
13484 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13485 to NULL.
13486
640c8776 13487 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13488 GCONF_CFLAGS/LIBS.
13489
5386012d
MR
134902011-06-29 Martin Rudalics <rudalics@gmx.at>
13491
13492 * window.c (resize_root_window, grow_mini_window)
13493 (shrink_mini_window): Rename Qresize_root_window to
13494 Qwindow_resize_root_window and Qresize_root_window_vertically to
13495 Qwindow_resize_root_window_vertically.
13496
f13e0b08
PE
134972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13498
13499 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13500
94515237
JB
135012011-06-27 Juanma Barranquero <lekktu@gmail.com>
13502
13503 * makefile.w32-in: Redesign dependencies so they reflect more
13504 clearly which files are directly included by each source file,
13505 and not through other includes.
13506
e43b6e43
MR
135072011-06-27 Martin Rudalics <rudalics@gmx.at>
13508
13509 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13510 (sort_overlays, overlay_strings): When an overlay's clone number
13511 matches the window's clone number process the overlay even if
13512 the overlay's window property doesn't match the current window.
13513
d68443dc
MR
13514 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13515 (Fwindow_hchild): Rename to Fwindow_left_child.
13516 (Fwindow_next): Rename to Fwindow_next_sibling.
13517 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13518 (resize_window_check): Rename to window_resize_check.
13519 (resize_window_apply): Rename to window_resize_apply.
13520 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13521 (Fdelete_other_windows_internal, resize_frame_windows)
13522 (Fsplit_window_internal, Fdelete_window_internal)
13523 (grow_mini_window, shrink_mini_window)
13524 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13525
c7e73be5
JD
135262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13527
13528 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13529 (emacs_fixed_set_min_size): Remove.
13530 (emacs_fixed_new): Take frame as argument.
13531
13532 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13533 (_EmacsFixedPrivate): Remove minwidth/height.
13534 Add struct frame *f.
13535 (emacs_fixed_init): Initialize priv->f.
13536 (get_parent_class, emacs_fixed_set_min_size): Remove.
13537 (emacs_fixed_new): Set priv->f to argument.
13538 (emacs_fixed_get_preferred_width)
13539 (emacs_fixed_get_preferred_height): Use min_width/height from
13540 frames size_hint to set minimum and natural (Bug#8919).
13541 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13542 and use min_width/height from frames size_hint to set
13543 min_width/height (Bug#8919).
13544
13545 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13546 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13547 Fix indentation.
c7e73be5 13548
cf99dcf8
EZ
135492011-06-26 Eli Zaretskii <eliz@gnu.org>
13550
13551 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13552 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13553 called at ZV.
13554
029529ac
CY
135552011-06-26 Chong Yidong <cyd@stupidchicken.com>
13556
13557 * process.c (wait_reading_process_output): Bypass select if
13558 waiting for a cell while ignoring keyboard input, and input is
13559 pending. Suggested by Jan Djärv (Bug#8869).
13560
7a7ef429
PE
135612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13562
13563 Use gnulib's dup2 module instead of rolling our own.
13564 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13565
11fdef7d 135662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13567
13568 * dispnew.c (scrolling_window): Before scrolling, turn off a
13569 mouse-highlight in the window being scrolled.
13570
cd3520a4
JB
135712011-06-24 Juanma Barranquero <lekktu@gmail.com>
13572
13573 Move DEFSYM to lisp.h and use everywhere.
13574
13575 * character.h (DEFSYM): Move declaration...
13576 * lisp.h (DEFSYM): ...here.
13577
13578 * gnutls.c:
13579 * minibuf.c:
13580 * w32menu.c:
13581 * w32proc.c:
13582 * w32select.c: Don't include character.h.
13583
13584 * alloc.c (syms_of_alloc):
13585 * buffer.c (syms_of_buffer):
13586 * bytecode.c (syms_of_bytecode):
13587 * callint.c (syms_of_callint):
13588 * casefiddle.c (syms_of_casefiddle):
13589 * casetab.c (init_casetab_once):
13590 * category.c (init_category_once, syms_of_category):
13591 * ccl.c (syms_of_ccl):
13592 * cmds.c (syms_of_cmds):
13593 * composite.c (syms_of_composite):
13594 * dbusbind.c (syms_of_dbusbind):
13595 * dired.c (syms_of_dired):
13596 * dispnew.c (syms_of_display):
13597 * doc.c (syms_of_doc):
13598 * editfns.c (syms_of_editfns):
13599 * emacs.c (syms_of_emacs):
13600 * eval.c (syms_of_eval):
13601 * fileio.c (syms_of_fileio):
13602 * fns.c (syms_of_fns):
13603 * frame.c (syms_of_frame):
13604 * fringe.c (syms_of_fringe):
13605 * insdel.c (syms_of_insdel):
13606 * keymap.c (syms_of_keymap):
13607 * lread.c (init_obarray, syms_of_lread):
13608 * macros.c (syms_of_macros):
13609 * msdos.c (syms_of_msdos):
13610 * print.c (syms_of_print):
13611 * process.c (syms_of_process):
13612 * search.c (syms_of_search):
13613 * sound.c (syms_of_sound):
13614 * syntax.c (init_syntax_once, syms_of_syntax):
13615 * terminal.c (syms_of_terminal):
13616 * textprop.c (syms_of_textprop):
13617 * undo.c (syms_of_undo):
13618 * w32.c (globals_of_w32):
13619 * window.c (syms_of_window):
13620 * xdisp.c (syms_of_xdisp):
13621 * xfaces.c (syms_of_xfaces):
13622 * xfns.c (syms_of_xfns):
13623 * xmenu.c (syms_of_xmenu):
13624 * xsettings.c (syms_of_xsettings):
13625 * xterm.c (syms_of_xterm): Use DEFSYM.
13626
4228cf16
TZ
136272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13628
cd3520a4 13629 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13630
7fcccf1e
PE
136312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13632
7efb4e0e
PE
13633 Integer and buffer overflow fixes (Bug#8873).
13634
ff5844ad
PE
13635 * print.c (printchar, strout): Check for string overflow.
13636 (PRINTPREPARE, printchar, strout):
13637 Don't set size unless allocation succeeds.
13638
90532f02
PE
13639 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13640 for sizes. Check for string overflow more accurately.
13641 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13642
6d84508d
PE
13643 * macros.c: Integer and buffer overflow fixes.
13644 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13645 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13646 Use ptrdiff_t, not int, for sizes.
13647 Don't increment bufsize until after realloc succeeds.
13648 Check for size-calculation overflow.
13649 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13650
437b2cb4
PE
13651 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13652
8b9ac8b4
PE
13653 * lread.c: Integer overflow fixes.
13654 (read_integer): Radix is now EMACS_INT, not int,
13655 to improve quality of diagnostics for out-of-range radices.
13656 Calculate buffer size correctly for out-of-range radices.
13657 (read1): Check for integer overflow in radices, and in
13658 read-circle numbers.
82cb60d3
PE
13659 (read_escape): Avoid int overflow.
13660 (Fload, openp, read_buffer_size, read1)
13661 (substitute_object_recurse, read_vector, read_list, map_obarray):
13662 Use ptrdiff_t, not int, for sizes.
13663 (read1): Use EMACS_INT, not int, for sizes.
20270765 13664 Check for size overflow.
8b9ac8b4 13665
7fcccf1e
PE
13666 * image.c (cache_image): Check for size arithmetic overflow.
13667
bfbbd7e7
PE
13668 * lread.c: Integer overflow issues.
13669 (saved_doc_string_size, saved_doc_string_length)
13670 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13671 Now ptrdiff_t, not int.
13672 (read1): Don't assume doc string length fits in int. Check for
13673 out-of-range doc string lengths.
13674 (read_list): Don't assume file position fits in int.
39019e54 13675 (read_escape): Check for hex character overflow.
bfbbd7e7 13676
4e323265
LL
136772011-06-22 Leo Liu <sdl.web@gmail.com>
13678
13679 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13680 Move to minibuffer.el.
13681
85fece3e
PE
136822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13683
20b84ce9 13684 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13685 The following patches are for when GLYPH_DEBUG && !XASSERT.
13686 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13687 * dispnew.c (flush_stdout):
13688 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13689 Mark as externally visible.
13690 * dispnew.c (check_window_matrix_pointers): Now static.
13691 * dispnew.c (window_to_frame_vpos):
13692 * xfns.c (unwind_create_frame):
13693 * xterm.c (x_check_font): Remove unused local.
13694 * scroll.c (CHECK_BOUNDS):
13695 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13696 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13697 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13698 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13699 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13700 Now static.
13701 (debug_method_add): Use va_list and vsprintf rather than relying
13702 on undefined behavior with wrong number of arguments.
13703 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13704 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13705 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13706 since we're not interested in debugging glyphs with old libraries.
13707 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13708 GCC 4.6.0's static checking.
13709
0766b489
PE
137102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13711
31fd4b32
PE
13712 Integer overflow and signedness fixes (Bug#8873).
13713 A few related buffer overrun fixes, too.
13714
b79e8648
PE
13715 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13716
0766b489
PE
13717 * dispextern.h (struct face.stipple):
13718 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13719 (x_bitmap_mask, x_allocate_bitmap_record)
13720 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13721 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13722 (x_create_bitmap_from_xpm_data):
13723 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13724 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13725 (.bitmaps_last):
13726 * xfaces.c (load_pixmap):
13727 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13728 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13729 (.bitmaps_last, struct x_output.icon_bitmap):
13730 Use ptrdiff_t, not int, for bitmap indexes.
13731 (x_allocate_bitmap_record): Check for size overflow.
13732 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13733
b081724f
PE
13734 Use ptrdiff_t, not int, for overlay counts.
13735 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13736 * editfns.c (overlays_around, get_pos_property):
13737 * textprop.c (get_char_property_and_overlay):
13738 * xdisp.c (next_overlay_change, note_mouse_highlight):
13739 * xfaces.c (face_at_buffer_position):
21514da7
PE
13740 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13741 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13742 (Fnext_overlay_change, Fprevious_overlay_change)
13743 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13744 Use ptrdiff_t, not int, for sizes.
21514da7 13745 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13746
3de73e5e
PE
13747 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13748
2606c57b
PE
13749 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13750 (x_session_initialize): Do not assume string length fits in int.
13751
aaafe47a
PE
13752 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13753 This is unlikely, but can occur if DPI is outlandish.
13754
2674ddc8 13755 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13756 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13757
28154962
PE
13758 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13759 * xrdb.c (magic_file_p, search_magic_path):
13760 Omit last arg SUFFIX; it was always 0. All callers changed.
13761 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13762
7de51af5
PE
13763 * xfont.c (xfont_match): Avoid need for strlen.
13764
25ed6cc3
PE
13765 * xfns.c: Don't assume strlen fits in int.
13766 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13767
4eab31dd
PE
13768 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13769 not unsigned long, as we prefer signed integers. All callers changed.
13770 Detect integer overflow in repeat count.
13771 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13772 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13773
171e2a58
PE
13774 * termcap.c: Don't assume sizes fit in int and never overflow.
13775 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13776 (gobble_line): Check for size-calculation overflow.
13777
ad39faca 13778 * minibuf.c (Fread_buffer):
6e5bb2dc 13779 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13780 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13781 Don't assume string length fits in int.
13782
52c61c22 13783 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13784 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13785
b5b8c9e5
PE
13786 * font.c: Don't assume string length fits in int.
13787 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13788 Use ptrdiff_t, not int.
ccd6111c
PE
13789 (font_intern_prop): Don't assume string length fits in int.
13790 Don't assume integer property fits in fixnum.
13791 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13792
882f0d81 13793 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13794 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13795 Reformulate so as not to need the command string.
13796 Invoke gzip -cd rather than gunzip, as it's more portable.
13797 (lock_info_type, lock_file_1, lock_file):
13798 Don't assume pid_t and time_t fit in unsigned long.
13799 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13800 (current_lock_owner): Prefer signed type for sizes.
13801 Use memcpy, not strncpy, where memcpy is what is really wanted.
13802 Don't assume (via atoi) that time_t and pid_t fit in int.
13803 Check for time_t and/or pid_t out of range, e.g., via a network share.
13804 Don't alloca where an auto var works fine.
13805
93f4cf88
PE
13806 * fileio.c: Fix some integer overflow issues.
13807 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13808 Don't assume string length fits in int.
13809 (directory_file_name): Don't assume string length fits in long.
13810 (make_temp_name): Don't assume pid fits in int, or that its print
13811 length is less than 20.
13812
f3e92b69
PE
13813 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13814
1bfdaf10
PE
13815 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13816
35016e9a
PE
13817 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13818
3d1e65a1
PE
13819 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13820 We prefer signed integers, even for size calculations.
13821
0b963a93
PE
13822 * emacs.c: Don't assume string length fits in 'int'.
13823 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13824 (main): Don't invoke strlen when not needed.
13825
573f4b54
PE
13826 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13827 (XD_DEBUG_MESSAGE): Don't waste a byte.
13828
989f33ba
PE
13829 * callproc.c (getenv_internal_1, getenv_internal)
13830 (Fgetenv_internal):
965d34eb
PE
13831 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13832
e4d29b33
PE
13833 * lread.c (invalid_syntax): Omit length argument.
13834 All uses changed. This doesn't fix a bug, but it simplifies the
13835 code away from its former Hollerith-constant appearance, and it's
13836 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13837 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13838
eb49b136
PE
13839 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13840 This didn't break anything, but it didn't help either.
13841 It's confusing to put a bogus integer in a place where the actual
13842 value does not matter.
9f62aeb1 13843 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13844 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13845
15375a22
PE
13846 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13847 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13848 implementation.
b61cc01c
PE
13849 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13850 We prefer signed types, and the value cannot exceed the EMACS_INT
13851 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13852 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13853 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13854 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13855
53b2623d
PE
13856 * indent.c (sane_tab_width): New function.
13857 (current_column, scan_for_column, Findent_to, position_indentation)
13858 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13859 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13860
51cab52b 13861 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13862
f2ed8a70
PE
13863 * lisp.h (lint_assume): New macro.
13864 * composite.c (composition_gstring_put_cache):
13865 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13866
abe80cc6
PE
13867 * editfns.c, insdel.c:
13868 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13869
b02c740e
PE
13870 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13871
ebc96716
PE
13872 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13873
b4e50fa0 13874 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13875 Use much-faster test for byte-length change.
311d5d7c 13876 Don't assume string byte-length fits in 'int'.
a4cf38e4 13877 Check that character arg fits in 'int'.
85461888 13878 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13879
c0c1ee9f
PE
13880 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13881
a498d7f4
PE
13882 * fns.c (concat): Catch string overflow earlier.
13883 Do not rely on integer wraparound.
13884
51cab52b
PE
13885 * dispextern.h (struct it.overlay_strings_charpos)
13886 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13887 * xdisp.c (forward_to_next_line_start)
13888 (back_to_previous_visible_line_start)
13889 (reseat_at_next_visible_line_start, next_element_from_buffer):
13890 Don't arbitrarily truncate the value of 'selective' to int.
13891
76031fad
PE
13892 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13893
5eb55db9
PE
13894 * composite.c: Don't truncate sizes to 'int'.
13895 (composition_gstring_p, composition_reseat_it)
13896 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13897 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13898 not EMACS_UINT, for indexes.
5eb55db9 13899
0703a717
PE
13900 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13901
d6202519
PE
13902 * buffer.c: Include <verify.h>.
13903 (struct sortvec.priority, struct sortstr.priority):
8961a454 13904 Now EMACS_INT, not int.
c20998a7 13905 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13906 (struct sortstr.size, record_overlay_string)
13907 (struct sortstrlist.size, struct sortlist.used):
13908 Don't truncate size to int.
13909 (record_overlay_string): Check for size-calculation overflow.
d6202519 13910 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13911
d5a19415
JM
139122011-06-22 Jim Meyering <meyering@redhat.com>
13913
029529ac 13914 Don't leak an XBM-image-sized buffer
d5a19415
JM
13915 * image.c (xbm_load): Free the image buffer after using it.
13916
a9041e6c
PE
139172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13918
13919 Port to Sun C.
13920 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13921 that Sun C diagnosed.
13922 * fns.c (secure_hash): Fix pointer signedness issue.
13923 * intervals.c (static_offset_intervals): New function.
13924 (offset_intervals): Use it.
13925
7f3f739f
LL
139262011-06-21 Leo Liu <sdl.web@gmail.com>
13927
13928 * deps.mk (fns.o):
13929 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13930 sha512.h.
13931
13932 * fns.c (secure_hash): Rename from crypto_hash_function and change
13933 the first arg to accept symbols.
5b66d427 13934 (Fsecure_hash): New primitive.
7f3f739f
LL
13935 (syms_of_fns): New symbols.
13936
76147d94
DD
139372011-06-20 Deniz Dogan <deniz@dogan.se>
13938
13939 * process.c (Fset_process_buffer): Clarify return value in
13940 docstring.
13941
7d7d0045
CY
139422011-06-18 Chong Yidong <cyd@stupidchicken.com>
13943
13944 * dispnew.c (add_window_display_history): Use BVAR.
13945
13946 * xdisp.c (debug_method_add): Use BVAR.
13947 (check_window_end, dump_glyph_matrix, dump_glyph)
13948 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13949
13950 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13951 Likewise.
13952
13953 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13954 check till after the cache is created in init_frame_faces.
13955
ff2bc410
SM
139562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13957
13958 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13959
28177add
PE
139602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13961
dd3482fe
PE
13962 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13963 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13964 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13965
393d71f3 13966 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13967 * fileio.c (Finsert_file_contents):
13968 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13969 Remove the old (too-loose) buffer overflow checks.
13970 They weren't needed, since make_gap checks for buffer overflow.
13971 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13972 The old code merely checked for Emacs fixnum overflow, and relied
13973 on undefined (wraparound) behavior. The new code avoids undefined
13974 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13975
2e6813b0 13976 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13977 Tune. Don't use wider integers than needed. Don't use alloca.
13978 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13979
599a9e4f
PE
13980 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13981
99561444
PE
13982 * insdel.c, lisp.h (buffer_overflow): New function.
13983 (insert_from_buffer_1, replace_range, replace_range_2):
13984 * insdel.c (make_gap_larger):
13985 * editfns.c (Finsert_char):
13986 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13987
28177add
PE
13988 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13989
e69dafad
PE
139902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13991
4baa020d 13992 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13993
b1c46f02
PE
13994 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13995 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13996
e69dafad
PE
13997 * fileio.c: Don't assume EMACS_INT fits in off_t.
13998 (emacs_lseek): New static function.
13999 (Finsert_file_contents, Fwrite_region): Use it.
14000 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
14001
566684ea
PE
14002 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
14003
e6966cd6
PE
14004 * fns.c: Don't overflow int when computing a list length.
14005 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
14006 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
14007 truncation on 64-bit hosts. Check for QUIT every
14008 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
14009 faster and is responsive enough.
14010 (Flength): Report an error instead of overflowing an integer.
14011 (Fsafe_length): Return a float if the value is not representable
14012 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 14013 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 14014 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 14015
dd0b0efb
PE
14016 * alloc.c: Check that resized vectors' lengths fit in fixnums.
14017 (header_size, word_size): New constants.
14018 (allocate_vectorlike): Don't check size overflow here.
14019 (allocate_vector): Check it here instead, since this is the only
14020 caller of allocate_vectorlike that could cause overflow.
14021 Check that the new vector's length is representable as a fixnum.
14022
86fe5cfe
PE
14023 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
14024 The previous code was bogus. For example, next_almost_prime (32)
14025 returned 39, which is undesirable as it is a multiple of 3; and
14026 next_almost_prime (24) returned 25, which is a multiple of 5 so
14027 why was the code bothering to check for multiples of 7?
14028
80e88859
PE
14029 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
14030
4a2f0ad6
PE
14031 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
14032
f66c7cf8
PE
14033 Variadic C functions now count arguments with ptrdiff_t.
14034 This partly undoes my 2011-03-30 change, which replaced int with size_t.
14035 Back then I didn't know that the Emacs coding style prefers signed int.
14036 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
14037 were being counted with int, which may truncate counts on 64-bit
14038 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
14039 * lisp.h (struct Lisp_Subr.function.aMANY)
14040 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
14041 Arg counts are now ptrdiff_t, not size_t.
14042 All variadic functions and their callers changed accordingly.
14043 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
14044 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
14045 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
14046 * callint.c (Fcall_interactively): Check arg count for overflow,
14047 to avoid potential buffer overrun. Use signed char, not 'int',
14048 for 'varies' array, so that we needn't bother to check its size
14049 calculation for overflow.
14050 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
14051 * eval.c (apply_lambda):
14052 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
14053 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
14054 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
14055
a1759b76
PE
14056 * callint.c (Fcall_interactively): Don't use index var as event count.
14057
d96be9fc
PE
14058 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
14059 * mem-limits.h (SIZE): Remove; no longer used.
14060
a690a978 14061 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 14062
578c21e6
PE
14063 Remove unnecessary casts.
14064 * xterm.c (x_term_init):
14065 * xfns.c (x_set_border_pixel):
14066 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
14067 These aren't needed now that we assume ANSI C.
14068
96f53c6c
PE
14069 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14070 It's more likely to cause problems (due to unsigned overflow)
14071 than to cure them.
14072
83c77d31
PE
14073 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
14074
ee2079f1
PE
14075 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
14076
6da65536
PE
14077 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
14078
7147c4a4
PE
14079 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
14080
193e32d9
PE
14081 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
14082
e5533da6
PE
14083 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
14084
9910e595
PE
14085 GLYPH_CODE_FACE returns EMACS_INT, not int.
14086 * dispextern.h (merge_faces):
14087 * xfaces.c (merge_faces):
01103c44
PE
14088 * xdisp.c (get_next_display_element, next_element_from_display_vector):
14089 Don't assume EMACS_INT fits in int.
9910e595 14090
2638320e
PE
14091 * character.h (CHAR_VALID_P): Remove unused parameter.
14092 * fontset.c, lisp.h, xdisp.c: All uses changed.
14093
045eb8d9
PE
14094 * editfns.c (Ftranslate_region_internal): Omit redundant test.
14095
c1f134b5
PE
14096 * fns.c (concat): Minor tuning based on overflow analysis.
14097 This doesn't fix any bugs. Use int to hold character, instead
14098 of constantly refetching from Emacs object. Use XFASTINT, not
14099 XINT, for value known to be a character. Don't bother comparing
14100 a single byte to 0400, as it's always less.
14101
395fcb93 14102 * floatfns.c (Fexpt):
327eeec8
PE
14103 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
14104
abbd3d23
PE
14105 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
14106 for characters.
14107
684a03ef
PE
14108 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
14109
0fed43f3
PE
14110 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
14111 Without this fix, on a 64-bit host (aset S 0 4294967386) would
14112 incorrectly succeed when S was a string, because 4294967386 was
14113 truncated before it was used.
14114
8fd02eb7
PE
14115 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
14116 Otherwise, an out-of-range integer could cause undefined behavior
14117 on a 64-bit host.
14118
f8c86b69
PE
14119 * composite.c: Use int, not EMACS_INT, for characters.
14120 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14121 EMACS_INT, for values that are known to be in character range.
14122 This doesn't fix any bugs but is the usual style inside Emacs and
14123 may generate better code on 32-bit machines.
14124
34206dd2
PE
14125 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14126 This is for reasons similar to the recent CHAR_STRING fix.
14127 * charset.c (Fencode_char): Check that character arg is actually
14128 a character. Pass an int to ENCODE_CHAR.
14129 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14130 wider than 'int', as a compile-time check to prevent future regressions
14131 in this area.
14132
c5958d4c 14133 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
14134
14135 Make sure a 64-bit char is never passed to CHAR_STRING.
14136 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
14137 by silently ignoring the top 32 bits, allowing some values
14138 that were far too large to be valid characters.
14139 * character.h: Include <verify.h>.
14140 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
14141 arguments are no wider than unsigned, as a compile-time check
14142 to prevent future regressions in this area.
14143 * data.c (Faset):
01103c44 14144 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
14145 (Fsubst_char_in_region):
14146 * fns.c (concat):
14147 * xdisp.c (decode_mode_spec_coding):
14148 Adjust to CHAR_STRING's new requirement.
14149 * editfns.c (Finsert_char, Fsubst_char_in_region):
14150 * fns.c (concat): Check that character args are actually
14151 characters. Without this test, these functions did the wrong
14152 thing with wildly out-of-range values on 64-bit hosts.
14153
d37ca623
PE
14154 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
14155 These casts should not be needed on 32-bit hosts, either.
14156 * keyboard.c (read_char):
14157 * lread.c (Fload): Remove casts to unsigned.
14158
ea204efb
PE
14159 * lisp.h (UNSIGNED_CMP): New macro.
14160 This fixes comparison bugs on 64-bit hosts.
14161 (ASCII_CHAR_P): Use it.
14162 * casefiddle.c (casify_object):
01103c44 14163 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
14164 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14165 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
14166 * dispextern.h (FACE_FROM_ID):
14167 * keyboard.c (read_char): Use UNSIGNED_CMP.
14168
41cb286c
PE
14169 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
14170 not to EMACS_INT, to avoid GCC warning.
14171
4a1b9832
PE
14172 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
14173
55daad71
PE
14174 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
14175 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
14176 isn't needed on 32-bit machines.
8f95c75c 14177
01103c44
PE
14178 * buffer.c (Fgenerate_new_buffer_name):
14179 Use EMACS_INT for count, not int.
0ceccced 14180 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
14181
14182 * data.c (Qcompiled_function): Now static.
14183
c6f072e7
PE
14184 * window.c (window_body_lines): Now static.
14185
20ce5912
PE
14186 * image.c (gif_load): Rename local to avoid shadowing.
14187
9c4c5f81
PE
14188 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
14189 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
14190 * alloc.c (make_save_value): Integer argument is now of type
14191 ptrdiff_t, not int.
14192 (mark_object): Use ptrdiff_t, not int.
14193 * lisp.h (pD): New macro.
14194 * print.c (print_object): Use it.
14195
c0c5c8ae
PE
14196 * alloc.c: Use EMACS_INT, not int, to count objects.
14197 (total_conses, total_markers, total_symbols, total_vector_size)
14198 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
14199 (total_free_floats, total_floats, total_free_intervals)
14200 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
14201 Now EMACS_INT, not int. All uses changed.
14202 (Fgarbage_collect): Compute overall total using a double, so that
14203 integer overflow is less likely to be a problem. Check for overflow
14204 when converting back to an integer.
5a25e253
PE
14205 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
14206 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14207 These were 'int' variables that could overflow on 64-bit hosts;
14208 they were never used, so remove them instead of repairing them.
211a0b2a 14209 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
14210 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
14211 Previously, this ceilinged at INT_MAX, but that doesn't work on
14212 64-bit machines.
e46bb31a 14213 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 14214
c78baabf 14215 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14216 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14217 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14218 when a (possibly-narrower) signed value would do just as well.
14219 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14220
c9d624c6
PE
14221 * alloc.c: Catch some string size overflows that we were missing.
14222 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14223 for convenience in STRING_BYTES_MAX.
14224 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14225 The definition here is exact; the one in lisp.h was approximate.
14226 (allocate_string_data): Check for string overflow. This catches
14227 some instances we weren't catching before. Also, it catches
14228 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14229 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14230 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14231
c9d624c6
PE
14232 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14233 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14234 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14235
353032ce
PE
14236 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14237
2bccce07
PE
14238 * alloc.c (Fmake_string): Check for out-of-range init.
14239
0ac30604
SM
142402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14241
14242 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14243
c195f2de
JD
142442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14245
14246 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14247 xg_get_default_scrollbar_width.
14248
14249 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14250 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14251 (style_changed_cb): Call update_theme_scrollbar_width and call
14252 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14253 all frames (Bug#8505).
14254 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14255 Call gtk_window_set_resizable if HAVE_GTK3.
14256 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14257 and height if HAVE_GTK3 (Bug#8505).
14258 (scroll_bar_width_for_theme): New variable.
14259 (update_theme_scrollbar_width): New function.
14260 (xg_get_default_scrollbar_width): Move code to
14261 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14262 (xg_initialize): Call update_theme_scrollbar_width.
14263
14264 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14265
14266 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14267
e10ac9f1
MR
142682011-06-12 Martin Rudalics <rudalics@gmx.at>
14269
14270 * frame.c (make_frame): Call other_buffer_safely instead of
14271 other_buffer.
14272
14273 * window.c (temp_output_buffer_show): Call display_buffer with
14274 second argument Vtemp_buffer_show_specifiers and reset latter
14275 immediately after the call.
14276 (Vtemp_buffer_show_specifiers): New variable.
14277 (auto_window_vscroll_p, next_screen_context_lines)
14278 (Vscroll_preserve_screen_position): Remove leading asterisks from
14279 doc-strings.
14280
2d3c217e 142812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14282
7b7f97e8 14283 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14284 * buffer.c (Qclone_number): Remove for now, as it's unused.
14285 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14286 (record_buffer): Remove unused local.
14287 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14288 (set_frame_buffer_list): Remove; unused.
14289 * frame.h (other_visible_frames): Remove decl.
14290 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14291 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14292 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14293 if HAVE_GPM.
14294 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14295 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14296 Define only if HAVE_GPM.
14297 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14298 (update_hints_inhibit): Remove; never set. All uses removed.
14299 * widgetprv.h (emacsFrameClassRec): Remove decl.
14300 * window.c (delete_deletable_window): Now returns void, since it
14301 wasn't returning anything.
14302 (compare_window_configurations): Remove unused locals.
14303 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14304 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14305 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14306 the same widths as pointers. This follows up on the 2011-05-06 patch.
14307 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14308 * xterm.h: Likewise.
14309 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14310
1384b89e
JB
143112011-06-12 Juanma Barranquero <lekktu@gmail.com>
14312
14313 * makefile.w32-in: Update dependencies.
14314 (LISP_H): Add lib/intprops.h.
14315
1100a63c
CY
143162011-06-11 Chong Yidong <cyd@stupidchicken.com>
14317
14318 * image.c (gif_load): Add animation frame delay to the metadata.
14319 (syms_of_image): Use DEFSYM. New symbol `delay'.
14320
6198ccd0
MR
143212011-06-11 Martin Rudalics <rudalics@gmx.at>
14322
14323 * window.c (delete_deletable_window): Re-add.
14324 (Fset_window_configuration): Rewrite to handle dead buffers and
14325 consequently deletable windows.
14326 (window_tree, Fwindow_tree): Remove. Supply functionality in
14327 window.el.
14328 (compare_window_configurations): Simplify code.
14329
b6e3633c
AS
143302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14331
1ab0dee5
AS
14332 * image.c (imagemagick_load_image): Fix type mismatch.
14333 (Fimagemagick_types): Likewise.
14334
b6e3633c
AS
14335 * window.h (replace_buffer_in_windows): Declare.
14336
9397e56f
MR
143372011-06-11 Martin Rudalics <rudalics@gmx.at>
14338
14339 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14340 Qclone_number. Remove external declaration of Qdelete_window.
14341 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14342 code.
640c8776
SM
14343 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14344 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14345 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14346 buffer list implementation.
14347 (other_buffer_safely): New function.
14348 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14349 calls to replace_buffer_in_windows and
14350 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14351 if allowed.
14352 (record_buffer): Inhibit quitting and rewrite using quittable
14353 functions. Run Qbuffer_list_update_hook if allowed.
14354 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14355 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14356 Move switch-to-buffer to window.el.
9397e56f
MR
14357 (bury-buffer): Move to window.el.
14358 (Vbuffer_list_update_hook): New variable.
14359
14360 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14361 section.
14362
14363 * window.h (resize_frame_windows): Move up in code.
14364 (Fwindow_frame): Remove EXFUN.
14365 (replace_buffer_in_all_windows): Remove prototype.
14366 (replace_buffer_in_windows_safely): Add prototype.
14367
14368 * window.c: Declare Qdelete_window static again. Move down
14369 declaration of select_count.
14370 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14371 (Fother_window): Move to window.el.
14372 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14373 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14374 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14375 window.el.
14376 (replace_buffer_in_windows): Implement by calling
14377 Qreplace_buffer_in_windows.
14378 (replace_buffer_in_all_windows): Remove with some functionality
14379 moved into replace_buffer_in_windows_safely.
14380 (replace_buffer_in_windows_safely): New function.
14381 (select_window_norecord, select_frame_norecord): Move in front
14382 of run_window_configuration_change_hook. Remove now obsolete
14383 declarations.
640c8776
SM
14384 (Fset_window_buffer): Rewrite doc-string.
14385 Call Qrecord_window_buffer.
9397e56f
MR
14386 (keys_of_window): Move binding for other-window to window.el.
14387
b50691aa
CY
143882011-06-11 Chong Yidong <cyd@stupidchicken.com>
14389
14390 * dispextern.h (struct image): Replace data member, whose int_val
14391 and ptr_val fields were not used by anything, with a single
14392 lisp_val object.
14393
14394 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14395 (gif_clear_image, gif_load, imagemagick_load_image)
14396 (gs_clear_image, gs_load): Callers changed.
14397
3f754b86
PE
143982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14399
cca69397
PE
14400 * buffer.h: Include <time.h>, for time_t.
14401 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14402
109e28d0
PE
14403 Fix minor problems found by static checking.
14404
60737f02
PE
14405 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14406
4b66faf3
PE
14407 Make identifiers static if they are not used in other modules.
14408 * data.c (Qcompiled_function, Qframe, Qvector):
14409 * image.c (QimageMagick, Qsvg):
14410 * minibuf.c (Qmetadata):
14411 * window.c (resize_window_check, resize_root_window): Now static.
14412 * window.h (resize_window_check, resize_root_window): Remove decls.
14413
109e28d0
PE
14414 * window.c (window_deletion_count, delete_deletable_window):
14415 Remove; unused.
46a4ce9e
PE
14416 (window_body_lines): Now static.
14417 (Fdelete_other_windows_internal): Mark vars as initialized.
14418 Make sure 'resize_failed' is initialized.
14419 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14420 (resize_window_apply): Remove unused local.
14421 * window.h (delete_deletable_window): Remove decl.
14422
109e28d0 14423 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14424 (imagemagick_load_image): Fix pointer signedness problem by changing
14425 last arg from unsigned char * to char *. All uses changed.
14426 Also, fix a local for similar reasons.
14427 Remove unused locals. Remove locals to avoid shadowing.
14428 (fn_rsvg_handle_free): Remove; unused.
14429 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14430 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14431
3f754b86
PE
14432 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14433
2547adb1
CY
144342011-06-10 Chong Yidong <cyd@stupidchicken.com>
14435
14436 * image.c (gif_load): Fix omitted cast error introduced by
14437 2011-06-06 change.
14438
2c8e37d4
MR
144392011-06-10 Martin Rudalics <rudalics@gmx.at>
14440
14441 * window.h (resize_proportionally, orig_total_lines)
14442 (orig_top_line): Remove from window structure.
14443 (set_window_height, set_window_width, change_window_heights)
14444 (Fdelete_window): Remove prototypes.
14445 (resize_frame_windows): Remove duplicate declaration.
14446
440a42e3
EZ
144472011-06-10 Eli Zaretskii <eliz@gnu.org>
14448
14449 * window.h (resize_frame_windows, resize_window_check)
14450 (delete_deletable_window, resize_root_window)
14451 (resize_frame_windows): Declare prototypes.
14452
14453 * window.c (resize_window_apply): Make definition be "static" to
14454 match the prototype.
14455
562dd5e9
MR
144562011-06-10 Martin Rudalics <rudalics@gmx.at>
14457
14458 * window.c: Remove declarations of Qwindow_size_fixed,
14459 window_min_size_1, window_min_size_2, window_min_size,
14460 size_window, window_fixed_size_p, enlarge_window, delete_window.
14461 Remove static from declaration of Qdelete_window, it's
14462 temporarily needed by Fbury_buffer.
14463 (replace_window): Don't assign orig_top_line and
14464 orig_total_lines.
14465 (Fdelete_window, delete_window): Remove. Window deletion is
14466 handled by window.el.
640c8776
SM
14467 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14468 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14469 (Fdelete_other_windows): Remove. Deleting other windows is
14470 handled by window.el.
14471 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14472 handled in window.el.
14473 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14474 Window minimum sizes are handled in window.el.
14475 (shrink_windows, size_window, set_window_height)
14476 (set_window_width, change_window_heights, window_height)
14477 (window_width, CURBEG, CURSIZE, enlarge_window)
14478 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14479 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14480 handled in window.el.
14481 (make_dummy_parent): Rename to make_parent_window and give it a
14482 second argument horflag.
14483 (make_window): Don't set resize_proportionally any more.
14484 (Fsplit_window): Remove. Windows are split in window.el.
14485 (save_restore_action, save_restore_orig_size)
14486 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14487 Resize mini windows in window.el.
14488 (grow_mini_window, shrink_mini_window): Implement by calling
14489 Qresize_root_window_vertically, resize_window_check and
14490 resize_window_apply.
640c8776
SM
14491 (saved_window, Fset_window_configuration, save_window_save):
14492 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14493 resize_proportionally.
14494 (window_min_height, window_min_width): Move to window.el.
14495 (keys_of_window): Move bindings for delete-other-windows,
14496 split-window, delete-window and enlarge-window to window.el.
14497
14498 * buffer.c: Temporarily extern Qdelete_window.
14499 (Fbury_buffer): Temporarily call Qdelete_window instead of
14500 Fdelete_window (Fbury_buffer will move to window.el soon).
14501
14502 * frame.c (set_menu_bar_lines_1): Remove code handling
14503 orig_top_line and orig_total_lines.
14504
14505 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14506 set_window_height but set heights directly.
14507 (change_frame_size_1): Use resize_frame_windows.
14508
14509 * xdisp.c (init_xdisp): Don't use set_window_height but set
14510 heights directly.
14511
640c8776
SM
14512 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14513 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14514 run_window_configuration_change_hook.
14515
14516 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14517 instead of change_window_heights and run
14518 run_window_configuration_change_hook.
14519
1a13852e
MR
145202011-06-09 Martin Rudalics <rudalics@gmx.at>
14521
14522 * window.c (replace_window): Rename second argument REPLACEMENT to
14523 NEW. New third argument SETFLAG. Rewrite.
14524 (delete_window, make_dummy_parent): Call replace_window with
14525 third argument 1.
14526 (window_list_1): Move down in code.
14527 (run_window_configuration_change_hook): Move set_buffer part
14528 before select_frame_norecord part in order to unwind correctly.
14529 Rename count1 to count.
14530 (recombine_windows, delete_deletable_window, resize_root_window)
14531 (Fdelete_other_windows_internal)
14532 (Frun_window_configuration_change_hook, make_parent_window)
14533 (resize_window_check, resize_window_apply, Fresize_window_apply)
14534 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14535 (Fdelete_window_internal, Fresize_mini_window_internal):
14536 New functions.
1a13852e
MR
14537 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14538
f3d1777e
MR
145392011-06-08 Martin Rudalics <rudalics@gmx.at>
14540
496e208e
MR
14541 * window.h (window): Add some new members to window structure -
14542 normal_lines, normal_cols, new_total, new_normal, clone_number,
14543 splits, nest, prev_buffers, next_buffers.
14544 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14545 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14546
f3d1777e
MR
14547 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14548 Remove.
496e208e
MR
14549 (make_dummy_parent): Set new members of windows structure.
14550 (make_window): Move down in code. Handle new members of window
14551 structure.
14552 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14553 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14554 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14555 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14556 (Fset_window_next_buffers, Fset_window_clone_number):
14557 New functions.
496e208e
MR
14558 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14559 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14560 Doc-string fixes.
14561 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14562 Argument WINDOW can be now internal window too.
14563 (Fwindow_use_time): Move up in code.
14564 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14565 Rewrite doc-string.
14566 (Fset_window_configuration, saved_window)
14567 (Fcurrent_window_configuration, save_window_save): Handle new
14568 members of window structure.
b9e809c2
MR
14569 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14570 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14571 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14572 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14573 Qget_mru_window, Qresize_root_window,
14574 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14575 Qauto_buffer_name; staticpro them.
f3d1777e 14576
abde8f8c
MR
145772011-06-07 Martin Rudalics <rudalics@gmx.at>
14578
14579 * window.c (Fwindow_total_size, Fwindow_left_column)
14580 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14581 (Fwindow_list_1): New functions.
14582 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14583 (Fwindow_width, Fscroll_left, Fscroll_right):
14584 Use window_body_cols instead of window_box_text_cols.
14585 (delete_window, Fset_window_configuration):
14586 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14587 (delete_all_subwindows): Take a window as argument and not a
14588 structure. Rewrite.
190b47e6
MR
14589 (window_loop): Remove handling of GET_LRU_WINDOW and
14590 GET_LARGEST_WINDOW.
14591 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14592
14593 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14594 window_box_text_cols. delete_all_subwindows now takes a
14595 Lisp_Object as argument.
abde8f8c 14596
640c8776
SM
14597 * indent.c (compute_motion, Fcompute_motion):
14598 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14599
fa8a67e6
MR
14600 * frame.c (delete_frame): Call delete_all_subwindows with root
14601 window as argument.
14602
a54e3482
DC
146032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14604
14605 * fns.c (Fputhash): Document return value.
14606
60002bf5
CY
146072011-06-06 Chong Yidong <cyd@stupidchicken.com>
14608
14609 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14610
0c671da6 146112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14612
b862a52a 14613 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14614
be44ca6c
PE
14615 Check for overflow when converting integer to cons and back.
14616 * charset.c (Fdefine_charset_internal, Fdecode_char):
14617 Use cons_to_unsigned to catch overflow.
14618 (Fencode_char): Use INTEGER_TO_CONS.
14619 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14620 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14621 * data.c (long_to_cons, cons_to_long): Remove.
14622 (cons_to_unsigned, cons_to_signed): New functions.
14623 These signal an error for invalid or out-of-range values.
14624 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14625 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14626 * font.c (Ffont_variation_glyphs):
14627 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14628 * lisp.h: Include <intprops.h>.
14629 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14630 (cons_to_signed, cons_to_unsigned): New decls.
14631 (long_to_cons, cons_to_long): Remove decls.
14632 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14633 (Fprimitive_undo): Use CONS_TO_INTEGER.
14634 * xfns.c (Fx_window_property): Likewise.
14635 * xselect.c: Include <limits.h>.
14636 (x_own_selection, selection_data_to_lisp_data):
14637 Use INTEGER_TO_CONS.
14638 (x_handle_selection_request, x_handle_selection_clear)
14639 (x_get_foreign_selection, Fx_disown_selection_internal)
14640 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14641 (lisp_data_to_selection_data): Use cons_to_unsigned.
14642 (x_fill_property_data): Use cons_to_signed.
14643 Report values out of range.
14644
d1f3d2af
PE
14645 Check for buffer and string overflow more precisely.
14646 * buffer.h (BUF_BYTES_MAX): New macro.
14647 * lisp.h (STRING_BYTES_MAX): New macro.
14648 * alloc.c (Fmake_string):
14649 * character.c (string_escape_byte8):
14650 * coding.c (coding_alloc_by_realloc):
14651 * doprnt.c (doprnt):
14652 * editfns.c (Fformat):
14653 * eval.c (verror):
14654 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14655 since they may not be the same number.
14656 * editfns.c (Finsert_char):
14657 * fileio.c (Finsert_file_contents):
14658 Likewise for BUF_BYTES_MAX.
14659
dd52fcea
PE
14660 * image.c: Use ptrdiff_t, not int, for sizes.
14661 (slurp_file): Switch from int to ptrdiff_t.
14662 All uses changed.
14663 (slurp_file): Check that file size fits in both size_t (for
14664 malloc) and ptrdiff_t (for sanity and safety).
14665
7f9bbdbb
PE
14666 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14667 if b->modtime has its maximal value.
14668
dfe18f82
PE
14669 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14670
84acfcf0
PE
14671 Don't assume time_t can fit into int.
14672 * buffer.h (struct buffer.modtime): Now time_t, not int.
14673 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14674 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14675
ccd9a01a
PE
14676 Minor fixes for signed vs unsigned integers.
14677 * character.h (MAYBE_UNIFY_CHAR):
14678 * charset.c (maybe_unify_char):
14679 * keyboard.c (read_char, reorder_modifiers):
14680 XINT -> XFASTINT, since the integer must be nonnegative.
14681 * ftfont.c (ftfont_spec_pattern):
14682 * keymap.c (access_keymap, silly_event_symbol_error):
14683 XUINT -> XFASTINT, since the integer must be nonnegative.
14684 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14685 since it makes no difference and we prefer signed.
14686 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14687 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14688 nonnegative.
14689
d6d100dd
SM
146902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14691
14692 * window.h (Fwindow_frame): Declare.
14693
2b6148e4
PE
146942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14695
14696 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14697 (SPARE_MEMORY): Always define.
14698 (LARGE_REQUEST): Remove.
14699 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14700
f230ecc9
MR
147012011-06-06 Martin Rudalics <rudalics@gmx.at>
14702
727e958e
MR
14703 * lisp.h: Move EXFUNS for Fframe_root_window,
14704 Fframe_first_window and Fset_frame_selected_window to window.h.
14705
14706 * window.h: Move EXFUNS for Fframe_root_window,
14707 Fframe_first_window and Fset_frame_selected_window here from
14708 lisp.h.
14709
14710 * frame.c (Fwindow_frame, Fframe_first_window)
14711 (Fframe_root_window, Fframe_selected_window)
14712 (Fset_frame_selected_window): Move to window.c.
14713 (Factive_minibuffer_window): Move to minibuf.c.
14714 (Fother_visible_frames_p): New function.
14715
14716 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14717
f230ecc9
MR
14718 * window.c (decode_window, decode_any_window): Move up in code.
14719 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14720 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14721 (Fwindow_buffer): Move up and rewrite doc-string.
14722 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14723 (Fwindow_prev): New functions.
727e958e
MR
14724 (Fwindow_frame): Move here from frame.c. Accept any window as
14725 argument.
14726 (Fframe_root_window, Fframe_first_window)
14727 (Fframe_selected_window): Move here from frame.c. Accept frame
14728 or arbitrary window as argument. Update doc-strings.
14729 (Fminibuffer_window): Move up in code.
14730 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14731 (Fset_frame_selected_window): Move here from frame.c.
14732 Marginal rewrite.
727e958e
MR
14733 (Fselected_window, select_window, Fselect_window): Move up in
14734 code. Minor doc-string fixes.
f230ecc9 14735
4d09bcf6
PE
147362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14737
14738 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14739 Do not assume that spare memory exists; that assumption is valid
14740 only if SYSTEM_MALLOC.
14741 (LARGE_REQUEST): New macro, so that the issue of large requests
14742 is separated from the issue of spare memory.
14743
810928a2
AS
147442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14745
172418ad
AS
14746 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14747 format. (Bug#8806)
14748
43f862f7
AS
14749 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14750
810928a2
AS
14751 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14752 before statements.
14753
a059fe24
JD
147542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14755
14756 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14757
14758 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14759
14760 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14761 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14762
989bf368
JB
147632011-06-05 Juanma Barranquero <lekktu@gmail.com>
14764
14765 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14766
4b80f674
CY
147672011-06-04 Chong Yidong <cyd@stupidchicken.com>
14768
14769 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14770 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14771 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14772 New error handlers.
4b80f674
CY
14773 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14774 Obey Vx_select_enable_clipboard_manager. Catch errors in
14775 x_clipboard_manager_save (Bug#8779).
14776 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14777 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14778
99a33b77 147792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14780
14781 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14782
99a33b77 147832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14784
14785 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14786 in the current matrix if keep_current_p is non-zero.
14787
8264569d
EZ
147882011-06-04 Eli Zaretskii <eliz@gnu.org>
14789
14790 * bidi.c (bidi_level_of_next_char): Fix last change.
14791
57f97249
EZ
147922011-06-03 Eli Zaretskii <eliz@gnu.org>
14793
fec2107c 14794 Support bidi reordering of text covered by display properties.
57f97249 14795
fec2107c
EZ
14796 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14797 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14798 (bidi_cache_search, bidi_cache_iterator_state)
14799 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14800 (bidi_level_of_next_char, bidi_move_to_visually_next):
14801 Support character positions inside a run of characters covered by a
fec2107c
EZ
14802 display string.
14803 (bidi_paragraph_init, bidi_resolve_explicit_1)
14804 (bidi_level_of_next_char): Call bidi_fetch_char and
14805 bidi_fetch_char_advance instead of FETCH_CHAR and
14806 FETCH_CHAR_ADVANCE.
14807 (bidi_init_it): Initialize new members.
14808 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14809 definitions.
14810 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14811 instead of using explicit *_CHAR codes.
d6d100dd
SM
14812 (bidi_resolve_explicit, bidi_resolve_weak):
14813 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14814 bidirectional text is supported only in multibyte buffers.
14815 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14816 it to initialize the frame_window_p member of struct bidi_it.
14817 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14818 (bidi_resolve_explicit, bidi_resolve_weak)
14819 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14820 bidi_it->nchars is non-positive.
14821 (bidi_level_of_next_char): Don't try to lookup the cache for the
14822 next/previous character if nothing is cached there yet, or if we
14823 were just reseat()'ed to a new position.
c40e2fb2 14824
0e14fe90
EZ
14825 * xdisp.c (set_cursor_from_row): Set start and stop points
14826 according to the row's direction when priming the loop that looks
14827 for the glyph on which to display cursor.
14828 (single_display_spec_intangible_p): Function deleted.
14829 (display_prop_intangible_p): Reimplement to call
14830 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14831 Accept 3 additional arguments needed by handle_display_spec.
14832 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14833 values: lists, `(when COND...)' forms, etc.
14834 (single_display_spec_string_p): Support property values that are
14835 lists with the argument STRING its top-level element.
14836 (display_prop_string_p): Fix the condition for processing a
14837 property that is a list to be consistent with handle_display_spec.
fec2107c 14838 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14839 last portion of handle_display_prop.
14840 (compute_display_string_pos): Accept additional argument
14841 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14842 value of a `display' property is a "replacing spec".
14843 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14844 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14845 the display property, but just return a value indicating whether
14846 the display property will replace the characters it covers.
14847 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14848 frame_window_p members of struct bidi_it.
d6d100dd
SM
14849 (compute_display_string_pos, compute_display_string_end):
14850 New functions.
fec2107c
EZ
14851 (push_it): Accept second argument POSITION, where pop_it should
14852 jump to continue iteration.
14853 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14854
fec2107c
EZ
14855 * keyboard.c (adjust_point_for_property): Adjust the call to
14856 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14857
14858 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14859 (bidi_init_it): Update prototypes.
14860 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14861 (compute_display_string_pos, compute_display_string_end):
14862 Declare prototypes.
fec2107c
EZ
14863 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14864 EMACS_INT.
fc6f18ce 14865
40087514 148662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14867
57f53182
PE
14868 Malloc failure behavior now depends on size of allocation.
14869 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14870 * lisp.h: Change signatures accordingly.
14871 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14872 All callers changed. (Bug#8762)
14873
14874 * gnutls.c: Use Emacs's memory allocators.
14875 Without this change, the gnutls library would invoke malloc etc.
14876 directly, which causes problems on non-SYNC_INPUT hosts, and which
14877 runs afoul of improving memory_full behavior. (Bug#8761)
14878 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14879 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14880 xfree instead of the default malloc, realloc, free.
14881 (Fgnutls_boot): No need to check for memory allocation failure,
14882 since xmalloc does that for us.
14883
ac32cd99 14884 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14885 * category.c (hash_get_category_set):
14886 * ccl.c (ccl_driver):
14887 * charset.c (Fdefine_charset_internal):
14888 * charset.h (struct charset.hash_index):
14889 * composite.c (get_composition_id, gstring_lookup_cache)
14890 (composition_gstring_put_cache):
14891 * composite.h (struct composition.hash_index):
14892 * dispextern.h (struct image.hash):
14893 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14894 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14895 (hashfn_equal, hashfn_user_defined, make_hash_table)
14896 (maybe_resize_hash_table, hash_lookup, hash_put)
14897 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14898 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14899 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14900 * image.c (make_image, search_image_cache, lookup_image)
14901 (xpm_put_color_table_h):
14902 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14903 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14904 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14905 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14906 * alloc.c (allocate_vectorlike):
14907 Check for overflow in vector size calculations.
14908 * ccl.c (ccl_driver):
14909 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14910 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14911 need to be updated by these changes.
40087514
PE
14912 * fns.c (make_hash_table, maybe_resize_hash_table):
14913 Check for integer overflow with large hash tables.
0de4bb68
PE
14914 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14915 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14916 (SXHASH_REDUCE): New macro.
14917 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14918 Use it instead of discarding useful hash info with large hash values.
14919 (sxhash_float): New function.
14920 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14921 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14922 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14923 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14924 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14925 Adjust signatures to match updated version of code.
14926 (consing_since_gc): Now EMACS_INT, since a single hash table can
14927 use more than INT_MAX bytes.
14928
698d32e2
DN
149292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14930
14931 Make it possible to build with GCC-4.6+ -O2 -flto.
14932
14933 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14934
fd6fa53f
SM
149352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14936
14937 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14938 Call minibuffer-inactive-mode.
14939
864db017
JB
149402011-05-31 Juanma Barranquero <lekktu@gmail.com>
14941
14942 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14943 Update dependencies.
14944
2ad0baf4
DN
149452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14946
14947 * data.c (init_data): Remove code for UTS, this system is not
14948 supported anymore.
14949
4fcc2638
DN
149502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14951
14952 Don't force ./temacs to start in terminal mode.
14953
14954 * frame.c (make_initial_frame): Initialize faces in all cases, not
14955 only when CANNOT_DUMP is defined.
14956 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14957
c56e0fd5
DN
149582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14959
14960 * dispnew.c (add_window_display_history): Use const for the string
14961 pointer. Remove declaration, not needed.
14962
333d54da 149632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14964
55d4c1b2 14965 Use 'inline', not 'INLINE'.
333d54da 14966 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14967 * alloc.c, fontset.c (INLINE): Remove.
14968 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14969 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14970 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14971 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14972 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14973
738db178
DN
149742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14975
14976 Make it possible to run ./temacs.
14977
14978 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14979 syms_of_callproc does the same thing. Remove test for
14980 "initialized", do it in the caller.
14981 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14982
620c53a6
SM
149832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14984
14985 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14986 (read_minibuf): Use get_minibuffer.
14987 (syms_of_minibuf): Use DEFSYM.
14988 (Qmetadata): New var.
14989 * data.c (Qbuffer): Don't make it static.
14990 (syms_of_data): Use DEFSYM.
14991
e003a292
PE
149922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14993
14994 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14995 (CCL_CODE_MIN): New macro.
14996
ed008a6d
PE
149972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14998
3687c2ef
PE
14999 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
15000
ed008a6d
PE
15001 * eval.c (Qdebug): Now static.
15002 * lisp.h (Qdebug): Remove decl. This reverts a part of the
15003 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
15004 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
15005
d66c4c7c
CY
150062011-05-29 Chong Yidong <cyd@stupidchicken.com>
15007
15008 * image.c: Various fixes to ImageMagick code comments.
15009 (Fimagemagick_types): Doc fix.
15010
5fbc2025
PE
150112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
15012
0196f88a
PE
15013 Minor fixes prompted by GCC 4.6.0 warnings.
15014
15015 * xselect.c (converted_selections, conversion_fail_tag): Now static.
15016
5fbc2025
PE
15017 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
15018 (x_clipboard_manager_save_all): Move extern decl to ...
15019 * xterm.h: ... here, so that it can be checked for consistency.
15020
1dd3c2d9
CY
150212011-05-29 Chong Yidong <cyd@stupidchicken.com>
15022
15023 * xselect.c (x_clipboard_manager_save_frame)
15024 (x_clipboard_manager_save_all): New functions.
15025 (Fx_clipboard_manager_save): Lisp function deleted.
15026
15027 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
15028 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
15029
15030 * xterm.h: Update prototype.
15031
5ba6571d
WX
150322011-05-28 William Xu <william.xwl@gmail.com>
15033
15034 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
15035 exiting (Bug#8239).
15036
3eaff834
JM
150372011-05-28 Jim Meyering <meyering@redhat.com>
15038
e1900994 15039 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
15040 * fns.c (to_uchar): Define.
15041 (crypto_hash_function): Use it to convert some newly-signed
15042 variables to unsigned, to avoid sign-extension bugs. For example,
15043 without this change, (md5 "truc") would evaluate to
15044 45723a2aff78ff4fff7fff1114760e62 rather than the expected
15045 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 15046 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 15047
0f6990a7
PE
150482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15049
15050 Integer overflow fixes.
c8a9ca5a 15051
08686060
PE
15052 * dbusbind.c: Serial number integer overflow fixes.
15053 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
15054 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
15055 to hold a serial number that is too large for a fixnum.
15056 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15057 Check for serial numbers out of range. Decode any serial number
59568bf0 15058 that was so large that it became a float. (Bug#8722)
08686060 15059
2d1fc3c7
PE
15060 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
15061 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15062 Use XFASTINT rather than XUINT when numbers are nonnegative.
15063 (xd_append_arg, Fdbus_method_return_internal):
15064 (Fdbus_method_error_internal): Likewise. Also, for unsigned
15065 arguments, check that Lisp number is nonnegative, rather than
59568bf0 15066 silently wrapping negative numbers around. (Bug#8722)
30217ff0 15067 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 15068 (Bug#8722)
2d1fc3c7 15069
c8a9ca5a
PE
15070 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
15071
519e1d69
PE
15072 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
15073
6df6ae42 15074 ccl: Add integer overflow checks.
30569699
PE
15075 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
15076 (IN_INT_RANGE): New macros.
15077 (ccl_driver): Use them to check for integer overflow when
15078 decoding a CCL program. Many of the new checks are whether XINT (x)
15079 fits in int; it doesn't always, on 64-bit hosts. The new version
15080 doesn't catch all possible integer overflows, but it's an
847044ea 15081 improvement. (Bug#8719)
30569699 15082
c11285dc
PE
15083 * alloc.c (make_event_array): Use XINT, not XUINT.
15084 There's no need for unsigned here.
15085
fdccd48e
PE
15086 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
15087 This follows up to the 2011-05-06 change that substituted uintptr_t
15088 for EMACS_INT. This case wasn't caught back then.
15089
37910ab2
PE
15090 Rework Fformat to avoid integer overflow issues.
15091 * editfns.c: Include <float.h> unconditionally, as it's everywhere
15092 now (part of C89). Include <verify.h>.
15093 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
15094 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
15095 (Fformat): Avoid the prepass trying to compute sizes; it was only
15096 approximate and thus did not catch overflow reliably. Instead, walk
15097 through the format just once, formatting and computing sizes as we go,
15098 checking for integer overflow at every step, and allocating a larger
15099 buffer as needed. Keep track separately whether the format is
15100 multibyte. Keep only the most-recently calculated precision, rather
15101 than them all. Record whether each argument has been converted to
15102 string. Use EMACS_INT, not int, for byte and char and arg counts.
15103 Support field widths and precisions larger than INT_MAX. Avoid
15104 sprintf's undefined behavior with conversion specifications such as %#d
15105 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
15106 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
15107 formatting out-of-range floating point numbers with int
9173deec 15108 formats. (Bug#8668)
37910ab2 15109
2e6578fb
PE
15110 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
15111
0ae6bdee
PE
15112 * data.c: Avoid integer truncation in expressions involving floats.
15113 * data.c: Include <intprops.h>.
15114 (arith_driver): When there's an integer overflow in an expression
15115 involving floating point, convert the integers to floating point
15116 so that the resulting value does not suffer from catastrophic
15117 integer truncation. For example, on a 64-bit host (* 4
15118 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
15119 Do not rely on undefined behavior after integer overflow.
15120
de883a70
PE
15121 merge count_size_as_multibyte, parse_str_to_multibyte
15122 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 15123 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
15124 Check for integer overflow.
15125 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
15126 since it's now a duplicate of the other. This is more of
15127 a character than a buffer op, so better that it's in character.c.
15128 * fns.c, print.c: Adjust to above changes.
15129
2ff916cb
PE
151302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
15131
15132 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
15133
f1b54466
PE
151342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15135
fb1ac845
PE
15136 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15137 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
15138 (x_clipboard_manager_save): Now static.
15139 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
15140
f1b54466
PE
15141 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15142 (crypto_hash_function): Now static.
15143 Fix pointer signedness problems. Avoid unnecessary initializations.
15144
a9f737ee
CY
151452011-05-27 Chong Yidong <cyd@stupidchicken.com>
15146
15147 * termhooks.h (Vselection_alist): Make it terminal-local.
15148
15149 * terminal.c (create_terminal): Initialize it.
15150
15151 * xselect.c: Support for clipboard managers.
15152 (Vselection_alist): Move to termhooks.h as terminal-local var.
15153 (LOCAL_SELECTION): New macro.
15154 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
15155 (symbol_to_x_atom): Remove gratuitous arg.
15156 (x_handle_selection_request, lisp_data_to_selection_data)
15157 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
15158 (x_own_selection, x_get_local_selection, x_convert_selection):
15159 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
15160 (some_frame_on_display): Delete unused function.
15161 (Fx_own_selection_internal, Fx_get_selection_internal)
15162 (Fx_disown_selection_internal, Fx_selection_owner_p)
15163 (Fx_selection_exists_p): New optional frame arg.
15164 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
15165 (x_handle_selection_clear): Don't treat other terminals with the
15166 same keyboard specially. Use the terminal-local Vselection_alist.
15167 (x_clear_frame_selections): Use Frun_hook_with_args.
15168
15169 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
15170
15171 * xterm.h: Add support for those atoms.
15172
e067f0c1
CY
151732011-05-26 Chong Yidong <cyd@stupidchicken.com>
15174
15175 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
15176 (converted_selections, conversion_fail_tag): New global variables.
15177 (x_selection_request_lisp_error): Free the above.
15178 (x_get_local_selection): Remove unnecessary code.
15179 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
15180 of converted selections stored in converted_selections.
15181 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
15182 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
15183 (x_convert_selection): New function.
15184 (x_handle_selection_event): Simplify.
15185 (x_get_foreign_selection): Don't ignore incoming requests while
15186 waiting for an answer; this will fail when we implement
15187 SAVE_TARGETS, and seems unnecessary anyway.
15188 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
15189 (Vx_sent_selection_functions): Doc fix.
15190
0f4aebc0
LL
151912011-05-26 Leo Liu <sdl.web@gmail.com>
15192
15193 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
15194
e61124cd
YM
151952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15196
15197 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
15198
15199 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
15200 for fringe update if it has periodic bitmap.
ac389d0c 15201 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
15202 and fringe_bitmap_periodic_p.
15203
15204 * fringe.c (get_fringe_bitmap_data): New function.
15205 (draw_fringe_bitmap_1, update_window_fringes): Use it.
15206 (update_window_fringes): Record periodicity of fringe bitmap in glyph
15207 row. Mark glyph row for fringe update if periodicity changed.
15208
15209 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
15210 for fringe update unless it has periodic bitmap.
15211
f16d9837
KH
152122011-05-25 Kenichi Handa <handa@m17n.org>
15213
15214 * xdisp.c (get_next_display_element): Set correct it->face_id for
15215 a static composition.
15216
e1b90ef6
LL
152172011-05-24 Leo Liu <sdl.web@gmail.com>
15218
15219 * deps.mk (fns.o):
15220 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15221
15222 * fns.c (crypto_hash_function, Fsha1): New function.
15223 (Fmd5): Use crypto_hash_function.
15224 (syms_of_fns): Add Ssha1.
15225
7400048f
PE
152262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15227
15228 * gnutls.c: Remove unused macros.
15229 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15230 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15231 Remove macros that are defined and never used.
15232 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15233
abb71cf4
CY
152342011-05-22 Chong Yidong <cyd@stupidchicken.com>
15235
15236 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15237 (Fx_get_selection_internal): Minor cleanup.
15238 (Fx_own_selection_internal): Rename arguments for consistency with
15239 select.el.
15240
6307db39
PE
152412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15242
15243 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15244
f3d4e0a4
CY
152452011-05-22 Chong Yidong <cyd@stupidchicken.com>
15246
15247 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15248
4d8ade89
YM
152492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15250
15251 * dispnew.c (scrolling_window): Don't exclude the case that the
15252 last enabled row in the desired matrix touches the bottom boundary.
15253
32078c8d
GM
152542011-05-21 Glenn Morris <rgm@gnu.org>
15255
15256 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15257 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15258 and add some more files.
32078c8d 15259
7285dc67
EZ
152602011-05-20 Eli Zaretskii <eliz@gnu.org>
15261
15262 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15263 report_file_error introduced by the change from 2011-05-07.
15264
89d1bd22
PE
152652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15266
15267 * systime.h (Time): Define only if emacs is defined.
15268 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15269 where the include path doesn't have X11/X.h by default. See
15270 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15271
cd394be1 152722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15273
15274 * composite.c (find_automatic_composition): Fix previous change.
15275
b9704ad9
GM
152762011-05-20 Glenn Morris <rgm@gnu.org>
15277
15278 * lisp.mk: New file, split from Makefile.in.
15279 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15280 (shortlisp): Remove.
15281 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15282
4a720484
GM
152832011-05-19 Glenn Morris <rgm@gnu.org>
15284
15285 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15286 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15287 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15288 (lisp): Set the order to that of loadup.el.
15289 (shortlisp): Make it a copy of $lisp.
15290 (SOME_MACHINE_LISP): Remove.
15291 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15292 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15293
a28d4396
KH
152942011-05-18 Kenichi Handa <handa@m17n.org>
15295
15296 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15297 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15298 (find_automatic_composition): Mostly rewrite for efficiency.
15299
a2b1fa8e
JB
153002011-05-18 Juanma Barranquero <lekktu@gmail.com>
15301
15302 * makefile.w32-in: Update dependencies.
15303
8e1f5610
CS
153042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15305
15306 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15307 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15308
7025ee00 153092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15310
cdfa6eab
PE
15311 Fix some integer overflow issues, such as string length overflow.
15312
06d6db33
PE
15313 * insdel.c (count_size_as_multibyte): Check for string overflow.
15314
2b4560a8
PE
15315 * character.c (lisp_string_width): Check for string overflow.
15316 Use EMACS_INT, not int, for string indexes and lengths; in
15317 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15318 the resulting string length overflows an EMACS_INT; instead,
15319 report a string overflow if no precision given. When checking for
15320 precision exhaustion, use a check that cannot possibly have
15321 integer overflow. (Bug#8675)
15322 * character.h (lisp_string_width): Adjust to new signature.
15323
cb93f9be
PE
15324 * alloc.c (string_overflow): New function.
15325 (Fmake_string): Use it. This doesn't change behavior, but saves
15326 a few bytes and will simplify future changes.
15327 * character.c (string_escape_byte8): Likewise.
15328 * lisp.h (string_overflow): New decl.
15329
1a1f3366
PE
15330 Fixups, following up to the user-interface timestamp change.
15331 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15332 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15333 * msdos.c (mouse_get_pos): Likewise.
15334 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15335 * w32gui.h (Time): Define by including "systime.h" rather than by
15336 declaring it ourselves. (Bug#8664)
15337
d4e3e4d3
PE
15338 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15339 * image.c (clear_image_cache): Likewise.
15340
f6a24d19
PE
15341 * term.c (term_mouse_position): Don't assume time_t wraparound.
15342
08dc5ae6
PE
15343 Be more systematic about user-interface timestamps.
15344 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15345 and sometimes 'EMACS_UINT', to represent these timestamps.
15346 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15347 This makes the code easier to follow, and makes it easier to catch
15348 integer overflow bugs such as Bug#8664.
15349 * frame.c (Fmouse_position, Fmouse_pixel_position):
15350 Use Time, not unsigned long, for user-interface timestamps.
15351 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15352 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15353 * keyboard.h (last_event_timestamp): Likewise.
15354 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15355 * menu.h (xmenu_show): Likewise.
15356 * term.c (term_mouse_position): Likewise.
15357 * termhooks.h (struct input_event.timestamp): Likewise.
15358 (struct terminal.mouse_position_hook): Likewise.
15359 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15360 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15361 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15362 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15363 what it was before.
15364 * menu.h, termhooks.h: Include "systime.h", for Time.
15365
8e55734a
PE
15366 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15367 Don't assume that the difference between two unsigned long values
15368 can fit into an integer. At this point, we know button_down_time
15369 <= event->timestamp, so the difference must be nonnegative, so
15370 there's no need to cast the result if double-click-time is
15371 nonnegative, as it should be; check that it's nonnegative, just in
15372 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15373 apart (about 25 days). (Bug#8664)
8e55734a 15374
841f1b75 15375 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15376 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15377
3e26f69c
PE
15378 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15379 that always fit in int. Use a sentinel instead of a counter, to
15380 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15381 * frame.h (struct frame): Use int for menu_bar_items_used
15382 instead of EMACS_INT, since it always fits in int.
3e26f69c 15383
5cc152c0
PE
15384 * menu.c (grow_menu_items): Check for int overflow.
15385
d89eb65e
PE
15386 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15387
5235bd3e
PE
15388 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15389 Before, the code was not consistent. These values cannot exceed
15390 2**31 - 1 so there's no need to make them unsigned.
15391 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15392 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15393 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15394 as modifiers.
15395 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15396
bc827e23
PE
15397 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15398 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15399 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15400 presumably because the widths might not match.
15401
78eb494e
PE
15402 * window.c (size_window): Avoid needless test at loop start.
15403
04f2d78b
CB
154042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15405
15406 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15407
d2fc7e3d 154082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15409
15410 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15411
d2fc7e3d 154122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15413
15414 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15415 `width' to `bar_area_x' and `bar_area_width', respectively.
15416 (x_scroll_run): Take account of fringe background extension.
15417
04f2d78b
CB
15418 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15419 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15420 `bar_area_width', respectively.
15421 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15422 background extension.
15423
79b70037
GM
154242011-05-10 Jim Meyering <meyering@redhat.com>
15425
15426 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15427
2f142cc5
JB
154282011-05-10 Juanma Barranquero <lekktu@gmail.com>
15429
15430 * image.c (Finit_image_library): Return t for built-in image types,
15431 like pbm and xbm. (Bug#8640)
15432
57679c86
AS
154332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15434
15435 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15436
888c9e86
EZ
154372011-05-07 Eli Zaretskii <eliz@gnu.org>
15438
b0512a1d
EZ
15439 * w32console.c (Fset_screen_color): Doc fix.
15440 (Fget_screen_color): New function.
15441 (syms_of_ntterm): Defsubr it.
15442
7285dc67
EZ
15443 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15444 unlink the temporary file if Fcall_process didn't create it in the
15445 first place.
15446 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15447 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15448 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15449 cue to call_process_cleanup not to close that handle.
15450
4d3fcc8e
BK
154512011-05-07 Ben Key <bkey76@gmail.com>
15452
15453 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15454 one of two shell specific rules, either bootstrap-temacs-CMD or
15455 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15456 to the previous implementation of the bootstrap-temacs rule.
15457 The bootstrap-temacs-CMD rule is similar to the previous
15458 implementation of the bootstrap-temacs rule except that it
15459 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15460 variable.
15461
15462 These changes, along with some changes to nt/configure.bat,
15463 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15464 earlier fix to add support for --cflags and --ldflags options
15465 that include quotes so that it works whether make uses cmd or
15466 sh as the shell.
15467
b4289b64
MA
154682011-05-06 Michael Albinus <michael.albinus@gmx.de>
15469
15470 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15471 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15472 is a constant.
15473 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15474 a string. Handle both cases.
15475 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15476 (Fdbus_register_method): Use Qinvalid_function.
15477
af4c0e28
JB
154782011-05-06 Juanma Barranquero <lekktu@gmail.com>
15479
15480 * makefile.w32-in: Update dependencies.
15481 (LISP_H): Add inttypes.h and stdin.h.
15482 (PROCESS_H): Add unistd.h.
15483
c51453d9
EZ
154842011-05-06 Eli Zaretskii <eliz@gnu.org>
15485
15486 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15487 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15488
8ff0ac3c 154892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15490
4c4b566b
PE
15491 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15492
aab2b9b5
PE
15493 * term.c (vfatal): Remove stray call to va_end.
15494 It's not needed and the C Standard doesn't allow it here anyway.
15495
c378da0b
PE
15496 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15497 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15498
288b08c7
PE
15499 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15500 bytes.
15501
e3601888
PE
15502 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15503
db6c0e74
PE
15504 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15505
dd5963ea
PE
15506 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15507
88c9450f
PE
15508 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15509
2f9442b8
PE
15510 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15511
c032b5f8
PE
15512 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15513 * charset.c (Fdefine_charset_internal): Don't initialize
15514 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15515 32-bit int (Bug#8600).
a108c10b
PE
15516
15517 * lread.c (read_integer): Be more consistent with string-to-number.
15518 Use string_to_number to do the actual conversion; this avoids
15519 rounding errors and fixes some other screwups. Without this fix,
15520 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15521 (digit_to_number): Move earlier, for benefit of read_integer.
15522 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15523 not a digit in any supported base. (Bug#8602)
a108c10b 15524
ad5f9eea
PE
15525 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15526
aec1708a
PE
15527 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15528 to match comment at start of function. This also removes a
15529 GCC warning about overflow in a 32+64-bit port.
15530
47be4ab5
PE
15531 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15532
371cac43
PE
15533 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15534 Reported by Stefan Monnier in
15535 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15536 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15537 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15538
d01a7826
PE
15539 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15540 (EMACS_UINTPTR): Likewise, with uintptr_t.
15541
7fd47d5c
PE
15542 * lisp.h: Prefer 64-bit EMACS_INT if available.
15543 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15544 on 32-bit hosts that have 64-bit int, so that they can access
15545 large files.
122b0c86
PE
15546 However, temporarily disable this change unless the temporary
15547 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15548
8727937b
PE
15549 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15550
8ac068ac
PE
15551 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15552 This removes an assumption that EMACS_INT and long are the same
15553 width as pointers. The assumption is true for Emacs porting targets
15554 now, but we want to make other targets possible.
15555 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15556 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15557 In the rest of the code, change types of integers that hold casted
15558 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15559 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15560 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15561 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15562 No need to cast type when ORing.
15563 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15564 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15565 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15566 assume EMACS_INT is the same width as char *.
15567 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15568 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15569 Remove no-longer-needed casts.
15570 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15571 (xg_tool_bar_help_callback, xg_make_tool_item):
15572 Use EMACS_INTPTR to hold an integer
15573 that will be cast to void *; this can avoid a GCC warning
15574 if EMACS_INT is not the same width as void *.
15575 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15576 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15577 (current_message_1, set_message_1):
15578 Use a local to convert to proper width without a cast.
15579 * xmenu.c (dialog_selection_callback): Likewise.
15580
ede49d71
PE
15581 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15582 Also, don't assume VALBITS / RAND_BITS is less than 5,
15583 and don't rely on undefined behavior when shifting a 1 left into
15584 the sign bit.
15585 * lisp.h (get_random): Change signature to match.
15586
2f30ecd0
PE
15587 * lread.c (hash_string): Use size_t, not int, for hash computation.
15588 Normally we prefer signed values; but hashing is special, because
15589 it's better to use unsigned division on hash table sizes so that
15590 the remainder is nonnegative. Also, size_t is the natural width
15591 for hashing into memory. The previous code used 'int', which doesn't
15592 retain enough info to hash well into very large tables.
15593 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15594
2a866e7b
PE
15595 * dbusbind.c: Don't possibly lose pointer info when converting.
15596 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15597 Use XPNTR rather than XHASH, so that the high-order bits of
15598 the pointer aren't lost when converting through void *.
15599
51639eac
PE
15600 * eval.c (Fautoload): Don't double-shift a pointer.
15601
92394119
PE
15602 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15603
dbdb9a7c
JB
156042011-05-06 Juanma Barranquero <lekktu@gmail.com>
15605
15606 * gnutls.c (DEF_GNUTLS_FN):
15607 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15608
db7a0b4f
AS
156092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15610
15611 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15612 marker. (Bug#8610)
15613
cd394be1 156142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15615
15616 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15617 New version that can reserve upto 2GB of heap space.
15618
f7ff1b0f 156192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15620
15621 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15622
639c109b
TZ
156232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15624
15625 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15626 `gnutls_certificate_set_x509_key_file'.
15627
d2127135
JB
156282011-05-05 Juanma Barranquero <lekktu@gmail.com>
15629
15630 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15631 Update dependencies.
15632
e968f4f3
JB
156332011-05-04 Juanma Barranquero <lekktu@gmail.com>
15634
15635 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15636 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15637 Remove unused parameter `fildes'.
15638 * process.c (read_process_output, send_process): Don't pass it.
15639
84d358f0
JB
156402011-05-04 Juanma Barranquero <lekktu@gmail.com>
15641
15642 Fix previous change: the library cache is defined in w32.c.
15643 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15644 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15645
0898ca10
JB
156462011-05-04 Juanma Barranquero <lekktu@gmail.com>
15647
15648 Implement dynamic loading of GnuTLS on Windows.
15649
15650 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15651 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15652 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15653 Declare.
15654
15655 * gnutls.c (Qgnutls_dll): Define.
15656 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15657 (gnutls_*): Declare function pointers.
15658 (init_gnutls_functions): New function to initialize function pointers.
15659 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15660 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15661 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15662 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15663 (emacs_gnutls_write, emacs_gnutls_read)
15664 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15665 (Fgnutls_available_p): New function.
15666 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15667 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15668 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15669
15670 * image.c: Include w32.h.
15671 (Vimage_type_cache): Delete.
15672 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15673 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15674 (w32_delayed_load): Move to w32.c.
15675
15676 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15677
15678 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15679 (w32_delayed_load): Move from image.c. When loading a library, record
15680 its filename in the :loaded-from property of the library id.
15681 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15682 Initialize and staticpro them.
15683 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15684
15685 * process.c: Include lisp.h before w32.h, not after.
15686 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15687 instead of gnutls_record_check_pending.
15688
15689 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15690
ff4de4aa
TZ
156912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15692
15693 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15694 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15695 as passed in.
15696
abe95abb
JD
156972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15698
15699 * xterm.c (x_set_frame_alpha): Do not set property on anything
15700 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15701
e16e55d4
JB
157022011-05-02 Juanma Barranquero <lekktu@gmail.com>
15703
15704 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15705
bafcf6a5
JB
157062011-05-02 Juanma Barranquero <lekktu@gmail.com>
15707
15708 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15709 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15710 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15711 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15712 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15713 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15714 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15715 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15716 (Qgnutls_bootprop_callbacks_verify): Make static.
15717
e7a6747f
AS
157182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15719
19ed11ba
AS
15720 * callproc.c: Indentation fixup.
15721
e7a6747f 15722 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15723 (wait_for_termination, interruptible_wait_for_termination):
15724 Move after wait_for_termination_1.
e7a6747f 15725
1ef14cb4
LMI
157262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15727
15728 * sysdep.c (interruptible_wait_for_termination): New function
15729 which is like wait_for_termination, but allows keyboard
15730 interruptions.
15731
15732 * callproc.c (Fcall_process): Add (:file "file") as an option for
15733 the STDOUT buffer.
15734 (Fcall_process_region): Ditto.
15735
330d880c
EZ
157362011-04-30 Eli Zaretskii <eliz@gnu.org>
15737
8db90b73
EZ
15738 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15739 rather than `XVECTOR (FOO)->size'.
15740
330d880c
EZ
15741 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15742 inttypes.h, as a gnulib replacement is used if it not available in
15743 system headers.
15744
15cbd324
EZ
157452011-04-21 Eli Zaretskii <eliz@gnu.org>
15746
15747 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15748 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15749 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15750
15751 * coding.c (coding_alloc_by_realloc): Error out if destination
15752 will grow beyond MOST_POSITIVE_FIXNUM.
15753 (decode_coding_emacs_mule): Abort if there isn't enough place in
15754 charbuf for the composition carryover bytes. Reserve an extra
15755 space for up to 2 characters produced in a loop.
15756 (decode_coding_iso_2022): Abort if there isn't enough place in
15757 charbuf for the composition carryover bytes.
15758
157592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15760
ae940cca
EZ
15761 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15762 aborting when %lld or %lll format is passed.
15763 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15764 %llo or %llx format is passed. (Bug#8545)
15765
03ab8921
EZ
15766 * window.c (window_scroll_line_based): Use a marker instead of
15767 simple variables to record original value of point. (Bug#7952)
15768
afda1437
EZ
15769 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15770 produced by %s or %c overflows available buffer space. (Bug#8545)
15771
f76dee0c
PE
157722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15773
15774 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15775 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15776
fdc5744d
JB
157772011-04-28 Juanma Barranquero <lekktu@gmail.com>
15778
15779 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15780
638f053a
JB
157812011-04-28 Juanma Barranquero <lekktu@gmail.com>
15782
15783 * keyboard.c (Qdelayed_warnings_hook): Define.
15784 (command_loop_1): Run `delayed-warnings-hook'
15785 if Vdelayed_warnings_list is non-nil.
15786 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15787 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15788
d178f871
EZ
157892011-04-28 Eli Zaretskii <eliz@gnu.org>
15790
15791 * doprnt.c (doprnt): Don't return value smaller than the buffer
15792 size if the message was truncated. (Bug#8545).
15793
b124fd93
JB
157942011-04-28 Juanma Barranquero <lekktu@gmail.com>
15795
15796 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15797 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15798
e810457d
PE
157992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15800
15801 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15802
ea51cceb
JB
158032011-04-27 Juanma Barranquero <lekktu@gmail.com>
15804
15805 * makefile.w32-in: Update dependencies.
15806
94dcfacf
EZ
158072011-04-27 Eli Zaretskii <eliz@gnu.org>
15808
15809 Improve `doprnt' and its usage. (Bug#8545)
15810 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15811 `format_end'. Remove support for %l as a conversion specifier.
15812 Don't use xrealloc. Improve diagnostics when the %l size modifier
15813 is used. Update the commentary.
15814
15815 * eval.c (verror): Simplify calculation of size_t.
15816
15817 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15818 messages.
15819
f61f41d7
PE
158202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15821
15822 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15823 change.
15824
96fb4434
PE
158252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15826
15827 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15828 This makes this file independent of the recent pseudovector change.
15829
671875da 158302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15831
69e9b5a3
PE
15832 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15833
b5f869a7 15834 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15835 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15836 Remove unused local.
c8926152 15837 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15838
841a1577 15839 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15840 GCC 4.6.0 optimizes based on type-based alias analysis.
15841 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15842 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15843 != &v->size, and therefore "v->size = 1; b->size = 2; return
15844 v->size;" must therefore return 1. This assumption is incorrect
15845 for Emacs, since it type-puns struct Lisp_Vector * with many other
15846 types. To fix this problem, this patch adds a new type struct
f904488f 15847 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15848 and pseudovectors, and helps optimizing compilers not get fooled
15849 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15850 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15851 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15852 the size member.
eab3844f
PE
15853 (XSETPVECTYPE): Rewrite in terms of new macro.
15854 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15855 This is a bit clearer, and further avoids the possibility of
15856 undesirable aliasing.
15857 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15858 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15859 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15860 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15861 (ASIZE): Now uses header.size rather than size.
15862 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15863 to avoid the hassle of writing XVECTOR (foo)->header.size.
15864 (struct vectorlike_header): New type.
eab3844f
PE
15865 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15866 object, to help avoid aliasing.
15867 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15868 (SUBRP): Likewise, since Lisp_Subr is a special case.
15869 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15870 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15871 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15872 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15873 changed to be "header.size" and "header.next".
15874 * buffer.h (struct buffer): Likewise.
15875 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15876 * frame.h (struct frame): Likewise.
15877 * process.h (struct Lisp_Process): Likewise.
15878 * termhooks.h (struct terminal): Likewise.
15879 * window.c (struct save_window_data, struct saved_window): Likewise.
15880 * window.h (struct window): Likewise.
15881 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15882 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15883 * buffer.c (init_buffer_once): Likewise.
15884 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15885 special case.
15886 * process.c (Fformat_network_address): Use local var for size,
15887 for brevity.
15888
0df1eac5
PE
15889 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15890
847ab9d1 15891 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15892 * data.c (atof): Remove decl; no longer used or needed.
15893 (digit_to_number): Move to lread.c.
15894 (Fstring_to_number): Use new string_to_number function, to be
15895 consistent with how the Lisp reader treats infinities and NaNs.
15896 Do not assume that floating-point numbers represent EMACS_INT
15897 without losing information; this is not true on most 64-bit hosts.
15898 Avoid double-rounding errors, by insisting on integers when
15899 parsing non-base-10 numbers, as the documentation specifies.
15900 * lisp.h (string_to_number): New decl, replacing ...
15901 (isfloat_string): Remove.
bc0a5c13 15902 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15903 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15904 appears to have been a coding error. Similarly, do not accept
15905 strings like +-1e0 as floating point numbers. Do not report
15906 overflow for integer overflows unless the base is not 10 which
15907 means we have no simple and reliable way to continue.
15908 Break out the floating-point parsing into a new
15909 function string_to_number, so that Fstring_to_number parses
15910 floating point numbers consistently with the Lisp reader.
04f2d78b 15911 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15912 (E_CHAR, EXP_INT): Remove, replacing with ...
15913 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15914 (string_to_number): New function, replacing isfloat_string.
15915 This function checks for valid syntax and produces the resulting
15916 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15917 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15918 so that overflow for non-base-10 numbers is reported only when
15919 there's no portable and simple way to convert to floating point.
452f4150 15920
67769ffc
PE
15921 * textprop.c (set_text_properties_1): Rewrite for clarity,
15922 and to avoid GCC warning about integer overflow.
15923
c20db43f
PE
15924 * intervals.h (struct interval): Use EMACS_INT for members
15925 where EMACS_UINT might cause problems. See
15926 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15927 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15928 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15929 All uses changed.
37aa2f85
PE
15930 (offset_intervals): Tell GCC not to worry about length overflow
15931 when negating a negative length.
c20db43f 15932
2538aa2f
PE
15933 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15934 (overrun_check_free): Likewise.
15935
f2d3008d
PE
15936 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15937 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15938 word size.
15939
ec8df744
PE
15940 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15941 (gnutls_make_error): Rename local to avoid shadowing.
15942 (gnutls_emacs_global_deinit): ifdef out; not used.
15943 (Fgnutls_boot): Use const for pointer to readonly storage.
15944 Comment out unused local. Fix pointer signedness problems.
15945
640ee02d
PE
15946 * lread.c (openp): Don't stuff size_t into an 'int'.
15947 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15948 about possible signed overflow.
15949
6048fb2a
PE
15950 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15951 (GDK_KEY_g): Don't define if already defined.
15952 (xg_prepare_tooltip): Avoid pointer signedness problem.
15953 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15954
fa3c87e1
PE
15955 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15956 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15957
2172544b
PE
15958 * xfns.c (Fx_window_property): Simplify a bit,
15959 to make a bit faster and to avoid GCC 4.6.0 warning.
15960 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15961
9b821a21
PE
15962 * fns.c (internal_equal): Don't assume size_t fits in int.
15963
3c616cfa
PE
15964 * alloc.c (compact_small_strings): Tighten assertion a little.
15965
c2982e87
PE
15966 Replace pEd with more-general pI, and fix some printf arg casts.
15967 * lisp.h (pI): New macro, generalizing old pEd macro to other
15968 conversion specifiers. For example, use "...%"pI"d..." rather
15969 than "...%"pEd"...".
15970 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15971 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15972 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15973 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15974 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15975 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15976 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15977 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15978 64-bit hosts.
15979 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15980 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15981 * print.c (safe_debug_print, print_object): Likewise.
15982 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15983 to int.
6f04d126
PE
15984 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15985 avoiding the 0 flag, which is not portable.
c2982e87
PE
15986 * process.c (Fmake_network_process): Use pI to avoid cast.
15987 * region-cache.c (pp_cache): Likewise.
15988 * xdisp.c (decode_mode_spec): Likewise.
15989 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15990 behavior on 64-bit hosts with printf arg.
6f04d126 15991 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15992 (x_stop_queuing_selection_requests): Likewise.
15993 (x_get_window_property): Don't truncate byte count to an 'int'
15994 when tracing.
0b432f21 15995
5e073ec7
PE
15996 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15997 here, since it parses constructs like leading '-' and spaces,
15998 which are not wanted; and it overflows with large numbers.
15999 Instead, simply match F[0-9]+, which is what is wanted anyway.
16000
36372bf9
PE
16001 * alloc.c: Remove unportable assumptions about struct layout.
16002 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
16003 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
16004 (allocate_vectorlike, make_pure_vector): Use the new macros,
16005 plus offsetof, to remove unportable assumptions about struct layout.
16006 These assumptions hold on all porting targets that I know of, but
16007 they are not guaranteed, they're easy to remove, and removing them
16008 makes further changes easier.
16009
0b432f21
PE
16010 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
16011 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
16012 (string_overrun_cookie): Now const. Use initializers that
16013 don't formally overflow signed char, to avoid warnings.
000098c1
PE
16014 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
16015 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
16016 (allocate_buffer): Don't assume sizeof (struct buffer) is a
16017 multiple of sizeof (EMACS_INT); it need not be, if
16018 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 16019 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 16020
895009e1
JB
160212011-04-26 Juanma Barranquero <lekktu@gmail.com>
16022
16023 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
16024
6a7a1b0b
TZ
160252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
16026
16027 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 16028 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
16029 Reported by Paul Eggert <eggert@cs.ucla.edu>.
16030
841a1577 160312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
16032
16033 * lisp.h (Qdebug): List symbol.
895009e1 16034 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
16035 * keyboard.c (debug-on-event): New variable.
16036 (handle_user_signal): Break into debugger when debug-on-event
16037 matches the current signal symbol.
16038
f2d3ba6f
DN
160392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
16040
16041 * alloc.c (check_sblock, check_string_bytes)
16042 (check_string_free_list): Convert to standard C.
16043
42ce4c63
TZ
160442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
16045
16046 * w32.c (emacs_gnutls_push): Fix typo.
16047
825cd63c
EZ
160482011-04-25 Eli Zaretskii <eliz@gnu.org>
16049
fb11d64d
EZ
16050 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
16051 "cast to pointer from integer of different size".
16052
825cd63c
EZ
16053 Improve doprnt and its use in verror. (Bug#8545)
16054 * doprnt.c (doprnt): Document the set of format control sequences
16055 supported by the function. Use SAFE_ALLOCA instead of always
16056 using `alloca'.
16057
16058 * eval.c (verror): Don't limit the buffer size at size_max-1, that
16059 is one byte too soon. Don't use xrealloc; instead xfree and
16060 xmalloc anew.
16061
e061a11b
TZ
160622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
16063
16064 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
16065 callbacks stage.
16066
16067 * gnutls.c: Renamed global_initialized to
16068 gnutls_global_initialized. Added internals for the
16069 :verify-hostname-error, :verify-error, and :verify-flags
16070 parameters of `gnutls-boot' and documented those parameters in the
16071 docstring. Start callback support.
9173deec
JB
16072 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
16073 unless a fatal error occurred. Call gnutls_alert_send_appropriate
16074 on error. Return error code.
e061a11b
TZ
16075 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
16076 (emacs_gnutls_read): Likewise.
16077 (Fgnutls_boot): Return handshake error code.
16078 (emacs_gnutls_handle_error): New function.
16079 (wsaerror_to_errno): Likewise.
16080
16081 * w32.h (emacs_gnutls_pull): Add prototype.
16082 (emacs_gnutls_push): Likewise.
16083
16084 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
16085 (emacs_gnutls_push): Likewise.
16086
160872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
16088
16089 * process.c (wait_reading_process_output): Check if GnuTLS
16090 buffered some data internally if no FDs are set for TLS
16091 connections.
16092
16093 * makefile.w32-in (OBJ2): Add gnutls.$(O).
16094 (LIBS): Link to USER_LIBS.
16095 ($(BLD)/gnutls.$(0)): New target.
16096
fa6996bc
EZ
160972011-04-24 Eli Zaretskii <eliz@gnu.org>
16098
eb35682e
EZ
16099 * xdisp.c (handle_single_display_spec): Rename the
16100 display_replaced_before_p argument into display_replaced_p, to
16101 make it consistent with the commentary. Fix typos in the
16102 commentary.
16103
e2ad650c
EZ
16104 * textprop.c (syms_of_textprop): Remove dead code.
16105 (copy_text_properties): Delete obsolete commentary about an
16106 interface that was deleted long ago. Fix typos in the description
16107 of arguments.
16108
1b2de274
EZ
16109 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
16110 to changes in oldXMenu/XMenu.h from 2011-04-16.
16111 <menu_help_message, prev_menu_help_message>: Constify.
16112 (IT_menu_make_room): menu->help_text is now `const char **';
16113 adjust.
16114
16115 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
16116 to changes in oldXMenu/XMenu.h from 2011-04-16.
16117 (struct XMenu): Declare `help_text' `const char **'.
16118
16119 * xfaces.c <Qunspecified>: Make extern again.
16120
16121 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 16122 required by POSIX.
1b2de274 16123
762b15be
EZ
16124 * doc.c (get_doc_string): Improve the format passed to `error'.
16125
16126 * doprnt.c (doprnt): Improve commentary.
16127
16128 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
16129
16130 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
16131 them with etags.
16132
f1052e5d
EZ
16133 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
16134 changes in globals.h immediately force recompilation.
762b15be
EZ
16135 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16136 $(CURDIR)/s/ms-w32.h.
16137 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 16138
fa6996bc
EZ
16139 * character.c (Fchar_direction): Function deleted.
16140 (syms_of_character): Don't defsubr it.
16141 <char-direction-table>: Deleted.
16142
e6c3da20
EZ
161432011-04-23 Eli Zaretskii <eliz@gnu.org>
16144
16145 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
16146 * doprnt.c: Include limits.h.
16147 (SIZE_MAX): New macro.
04f2d78b
CB
16148 (doprnt): Return a size_t value. 2nd arg is now size_t.
16149 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
16150 Improve overflow protection. Support `l' modifier for integer
16151 conversions. Support %l conversion. Don't assume an EMACS_INT
16152 argument for integer conversions and for %c.
16153
16154 * lisp.h (doprnt): Restore prototype.
16155
16156 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
16157 $(SRC)/character.h.
16158
16159 * Makefile.in (base_obj): Add back doprnt.o.
16160
16161 * deps.mk (doprnt.o): Add back prerequisites.
16162 (callint.o): Depend on character.h.
16163
16164 * eval.c (internal_lisp_condition_case): Include the handler
16165 representation in the error message.
16166 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
16167 when breaking from the loop.
16168
16169 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
16170
16171 * callint.c (Fcall_interactively): When displaying error message
16172 about invalid control letter, pass the character's codepoint, not
16173 a pointer to its multibyte form. Improve display of the character
16174 in octal and display also its hex code.
16175
16176 * character.c (char_string): Use %x to display the (unsigned)
16177 codepoint of an invalid character, to avoid displaying a bogus
16178 negative value.
16179
16180 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
16181 `error', not SYMBOL_NAME itself.
16182
16183 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
16184 character arguments to `error'.
16185
16186 * charset.c (check_iso_charset_parameter): Fix incorrect argument
16187 to `error' in error message about FINAL_CHAR argument. Make sure
16188 FINAL_CHAR is a character, and use %c when it is passed as
16189 argument to `error'.
16190
4ffd0d6b 161912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
16192
16193 * s/ms-w32.h (localtime): Redirect to sys_localtime.
16194
16195 * w32.c: Include <time.h>.
16196 (sys_localtime): New function.
16197
4ffd0d6b 161982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
16199
16200 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
16201
4ffd0d6b 16202 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 16203
4ffd0d6b 162042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 16205
4ffd0d6b
GM
16206 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
16207 zombies (Bug#8467).
aac0c6e3 16208
04c56954
EZ
162092011-04-19 Eli Zaretskii <eliz@gnu.org>
16210
16211 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
16212 gl_state.e_property when gl_state.object is Qt.
16213
16214 * insdel.c (make_gap_larger): Remove limitation of buffer size
16215 to <= INT_MAX.
16216
16a43933
CY
162172011-04-18 Chong Yidong <cyd@stupidchicken.com>
16218
16219 * xdisp.c (lookup_glyphless_char_display)
16220 (produce_glyphless_glyph): Handle cons cell entry in
16221 glyphless-char-display.
16222 (Vglyphless_char_display): Document it.
16223
16224 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16225 glyphless-char-display.
16226
4581706e
CY
162272011-04-17 Chong Yidong <cyd@stupidchicken.com>
16228
16229 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16230
16231 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16232
16233 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16234 definition for no-X builds.
16235
4887c6e2 162362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16237
fd35b6f9
PE
16238 Static checks with GCC 4.6.0 and non-default toolkits.
16239
5c1ccb01
PE
16240 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16241
006c5daa
PE
16242 * process.c (keyboard_bit_set): Define only if SIGIO.
16243 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16244 (send_process): Repair possible setjmp clobbering.
16245
efc736d3
PE
16246 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16247
4e2fe2e6
PE
16248 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16249
f97334a2
PE
16250 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16251
4e75f29d
PE
16252 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16253 Define only if needed.
16254
90efadd1
PE
16255 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16256 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16257 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16258
3c647824
PE
16259 * dispextern.h (struct redisplay_interface): Rename param
16260 to avoid shadowing.
e264f262 16261 * termhooks.h (struct terminal): Likewise.
761383f4 16262 * xterm.c (xembed_send_message): Likewise.
3c647824 16263
b58c5c4a
PE
16264 * insdel.c (make_gap_smaller): Define only if
16265 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16266
cad59032
PE
16267 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16268 it.
16269
c339dc2e
PE
16270 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16271 so that we aren't warned about unused symbols.
16272
91a3e27b
PE
16273 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16274
399c71d3 16275 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16276
8ffc96f5
PE
16277 * xfns.c (x_real_positions): Mark locals as initialized.
16278
eef9bc79
PE
16279 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16280
098db9dd
PE
16281 * xterm.c: Fix problems found by static analysis with other toolkits.
16282 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16283 (x_dispatch_event): Declare static if USE_GTK, and
16284 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16285 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16286 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16287 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16288 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16289
eb18f6cc
PE
16290 * xmenu.c (menu_help_callback): Pointer type fixes.
16291 Use const pointers when pointing at readonly data. Avoid pointer
16292 signedness clashes.
16293 (FALSE): Remove unused macro.
16294 (update_frame_menubar): Remove unused decl.
16295
1fe72bf8
PE
16296 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16297
60d9e1db
PE
16298 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16299 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16300 (single_menu_item): Rename local to avoid shadowing.
16301
39261c26
PE
16302 * keyboard.c (make_lispy_event): Remove unused local var.
16303
018c5e19
PE
16304 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16305 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16306
63d2b86e
PE
16307 * bitmaps: Change bitmaps from unsigned char back to the X11
16308 compatible char. Avoid the old compiler warnings about
16309 out-of-range initializers by using, for example, '\xab' rather
16310 than 0xab.
16311
aefd87e1
PE
16312 * xgselect.c (xgselect_initialize): Check vs interface
16313 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16314
bf501fb9
PE
16315 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16316
e9829fdf
PE
16317 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16318 to read-only memory.
16319
1086c095
PE
16320 * fns.c (vector): Remove; this old hack is no longer needed.
16321
2baccd04 16322 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16323 Remove unused var.
dde42981 16324 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16325
72391843 16326 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16327
436c16df 16328 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16329 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16330 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16331
92bb796d 16332 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16333 (x_term_init): Remove local to avoid shadowing.
92bb796d 16334
764430a3 16335 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16336
16337 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16338 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16339
d1dfb56c
EZ
163402011-04-16 Eli Zaretskii <eliz@gnu.org>
16341
c4354cb4
EZ
16342 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16343
d1dfb56c
EZ
16344 Fix regex.c, syntax.c and friends for buffers > 2GB.
16345 * syntax.h (struct gl_state_s): Declare character position members
16346 EMACS_INT.
16347
16348 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16349
04f2d78b
CB
16350 * textprop.c (verify_interval_modification, interval_of):
16351 Declare arguments EMACS_INT.
d1dfb56c
EZ
16352
16353 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16354 EMACS_INT.
16355
16356 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16357
16358 * indent.c (Fvertical_motion): Local variable it_start is now
16359 EMACS_INT.
16360
16361 * regex.c (re_match, re_match_2, re_match_2_internal)
16362 (bcmp_translate, regcomp, regexec, print_double_string)
16363 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16364 (re_compile_pattern, re_exec): Declare arguments and local
16365 variables `size_t' and `ssize_t' and return values `regoff_t', as
16366 appropriate.
16367 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16368 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16369 <compile_stack_type>: `size' and `avail' are now `size_t'.
16370
16371 * regex.h <regoff_t>: Use ssize_t, not int.
16372 (re_search, re_search_2, re_match, re_match_2): Arguments that
16373 specify buffer/string position and length are now ssize_t and
16374 size_t. Return type is regoff_t.
16375
613052cd
BK
163762011-04-16 Ben Key <bkey76@gmail.com>
16377
16378 * nsfont.m: Fixed bugs in ns_get_family and
16379 ns_descriptor_to_entity that were caused by using free to
16380 deallocate memory blocks that were allocated by xmalloc (via
16381 xstrdup). This caused Emacs to crash when compiled with
16382 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16383 --enable-checking=xmallocoverrun). xfree is now used to
16384 deallocate these memory blocks.
16385
4170f62f 163862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16387
71b41406
PE
16388 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16389
9587a89d
PE
16390 emacs_write: Accept and return EMACS_INT for sizes.
16391 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16392 et seq.
16393 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16394 Accept and return EMACS_INT.
16395 (emacs_gnutls_write): Return the number of bytes written on
16396 partial writes.
16397 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16398 (emacs_read, emacs_write): Remove check for negative size, as the
16399 Emacs source code has been audited now.
9587a89d
PE
16400 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16401 (emacs_read, emacs_write): Use it.
273a5f82
PE
16402 * process.c (send_process): Adjust to the new signatures of
16403 emacs_write and emacs_gnutls_write. Do not attempt to store
16404 a byte offset into an 'int'; it might overflow.
9587a89d 16405 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16406
3e047f51
PE
16407 * sound.c: Don't assume sizes fit in 'int'.
16408 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16409 Return EMACS_INT, not int.
3e047f51 16410 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16411 Accept EMACS_INT, not int.
16412 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16413 record read return values.
16414
cc39a9db
BK
164152011-04-15 Ben Key <bkey76@gmail.com>
16416
c9d0ec6d
JB
16417 * keyboard.c (Qundefined): Don't declare static since it is used
16418 in nsfns.m.
16419 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16420 static since they are used in nsfont.m.
cc39a9db 16421
6c60eb9f
SM
164222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16423
16424 * process.c (Qprocessp): Don't declare static.
16425 * lisp.h (Qprocessp): Declare again.
16426
7990b61a
JB
164272011-04-15 Juanma Barranquero <lekktu@gmail.com>
16428
16429 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16430
5d4cb038
PE
164312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16432
8bd7b830 16433 Improve C-level modularity by making more things 'static'.
cd64ea1d 16434
e3b27b31
PE
16435 Don't publish debugger-only interfaces to other modules.
16436 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16437 (verify_bytepos, count_markers): Move decls to the only modules
16438 that need them.
16439 * region-cache.h (pp_cache): Likewise.
16440 * window.h (check_all_windows): Likewise.
16441 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16442
5d4cb038
PE
16443 * sysdep.c (croak): Now static, if
16444 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16445 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16446
16447 * alloc.c (refill_memory_reserve): Now static if
16448 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16449 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16450
e87b6180
PE
16451 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16452 Define only if USE_LUCID.
16453
ac64929e
PE
16454 * xrdb.c (x_customization_string, x_rm_string): Now static.
16455
6f37259d
PE
16456 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16457 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16458
1683e3ab
PE
16459 * xdisp.c (draw_row_with_mouse_face): Now static.
16460 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16461
de9c2632
PE
16462 * window.h (check_all_windows): Mark externally visible.
16463
2b96acb7
PE
16464 * window.c (window_deletion_count): Now static.
16465
16466 * undo.c: Make symbols static if they're not exported.
16467 (last_undo_buffer, last_boundary_position, pending_boundary):
16468 Now static.
16469
50436f33
PE
16470 * textprop.c (interval_insert_behind_hooks): Now static.
16471 (interval_insert_in_front_hooks): Likewise.
16472
64520e5c
PE
16473 * term.c: Make symbols static if they're not exported.
16474 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16475 (max_frame_lines, tty_set_terminal_modes):
16476 (tty_reset_terminal_modes, tty_turn_off_highlight):
16477 (get_tty_terminal): Now static.
16478 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16479 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16480 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16481 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16482 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16483
1fa53021
PE
16484 * sysdep.c: Make symbols static if they're not exported.
16485 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16486 Now static.
16487 (sigprocmask_set, full_mask): Remove; unused.
16488 (wait_debugging): Mark as visible.
16489 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16490 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16491
d4b43b22
PE
16492 * syntax.c (syntax_temp): Define only if !__GNUC__.
16493
b7c513d0
PE
16494 * sound.c (current_sound_device, current_sound): Now static.
16495
989b29ad
PE
16496 * search.c (searchbufs, searchbuf_head): Now static.
16497
13a55a78
PE
16498 * scroll.c (scroll_cost): Remove; unused.
16499 * dispextern.h (scroll_cost): Remove decl.
16500
de68a1fc
PE
16501 * region-cache.h (pp_cache): Mark as externally visible.
16502
40ccffa6
PE
16503 * process.c: Make symbols static if they're not exported.
16504 (process_tick, update_tick, create_process, chan_process):
16505 (Vprocess_alist, proc_buffered_char, datagram_access):
16506 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16507 (deactivate_process): Mark defn as static, as well as decl.
16508 * lisp.h (create_process): Remove decl.
16509 * process.h (chan_process, Vprocess_alist): Remove decls.
16510
ad64fc97
PE
16511 * print.c: Make symbols static if they're not exported.
16512 (print_depth, new_backquote_output, being_printed, print_buffer):
16513 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16514 (print_interval, print_number_index, initial_stderr_stream):
16515 Now static.
16516 * lisp.h (Fprinc): Remove decl.
16517 (debug_output_compilation_hack): Mark as externally visible.
16518
adddb265
PE
16519 * sysdep.c (croak): Move decl from here to syssignal.h.
16520 * syssignal.h (croak): Put it here, so the API can be checked when
16521 'croak' is called from dissociate_if_controlling_tty.
16522
1717ede2
PE
16523 * minibuf.c: Make symbols static if they're not exported.
16524 (minibuf_save_list, choose_minibuf_frame): Now static.
16525 * lisp.h (choose_minibuf_frame): Remove decl.
16526
fa5fb2bc
PE
16527 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16528
1e3890d1
PE
16529 * lread.c: Make symbols static if they're not exported.
16530 (read_objects, initial_obarray, oblookup_last_bucket_number):
16531 Now static.
16532 (make_symbol): Remove; unused.
16533 * lisp.h (initial_obarray, make_symbol): Remove decls.
16534
8a1414fa
PE
16535 * keyboard.c: Make symbols static if they're not exported.
16536 (single_kboard, recent_keys_index, total_keys, recent_keys):
16537 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16538 (this_single_command_key_start, echoing, last_auto_save):
16539 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16540 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16541 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16542 (Vlispy_mouse_stem, double_click_count):
16543 Now static.
16544 (force_auto_save_soon): Define only if SIGDANGER.
16545 (ignore_mouse_drag_p): Now static if
16546 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16547 (print_help): Remove; unused.
16548 (stop_character, last_timer_event): Mark as externally visible.
16549 * keyboard.h (ignore_mouse_drag_p): Declare only if
16550 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16551 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16552 * lisp.h (echoing): Remove decl.
16553 (force_auto_save_soon): Declare only if SIGDANGER.
16554 * xdisp.c (redisplay_window): Simplify code, to make it more
16555 obvious that ignore_mouse_drag_p is not accessed if !defined
16556 USE_GTK && !defined HAVE_NS.
16557
93ea6e8f
PE
16558 * intervals.c: Make symbols static if they're not exported.
16559 (merge_properties_sticky, merge_interval_right, delete_interval):
16560 Now static.
16561 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16562
77382fcc
PE
16563 * insdel.c: Make symbols static if they're not exported.
16564 However, leave prepare_to_modify_buffer alone. It's never
16565 called from outside this function, but that appears to be a bug.
16566 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16567 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16568 (adjust_after_replace_noundo): Remove; unused.
16569 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16570 (signal_before_change): Remove decls.
77382fcc 16571
9306c32e
PE
16572 * indent.c (val_compute_motion, val_vmotion): Now static.
16573
cd44d2eb
PE
16574 * image.c: Make symbols static if they're not exported.
16575 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16576 if USE_GTK.
16577 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16578 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16579
ad9a7a06
PE
16580 * fringe.c (standard_bitmaps): Now static.
16581 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16582
81626931
PE
16583 * frame.c: Make symbols static if they're not exported.
16584 (x_report_frame_params, make_terminal_frame): Now static.
16585 (get_frame_param): Now static, unless HAVE_NS.
16586 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16587 (x_get_resource_string): Remove; not used.
16588 * frame.h (make_terminal_frame, x_report_frame_params):
16589 (x_get_resource_string); Remove decls.
16590 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16591 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16592
239f9db9
PE
16593 * font.c, fontset.c: Make symbols static if they're not exported.
16594 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16595 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16596 * font.c (font_close_object): Now static.
16597 * font.h (font_close_object): Remove.
16598 * fontset.c (FONTSET_OBJLIST): Remove.
16599 (free_realized_fontset) #if-0 the body, which does nothing.
16600 (face_suitable_for_char_p): #if-0, as it's never called.
16601 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16602 * xfaces.c (face_at_string_position):
16603 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16604 since 0 is always ASCII.
16605
dfcf3579
PE
16606 * fns.c (weak_hash_tables): Now static.
16607
5045092b
PE
16608 * fileio.c: Make symbols static if they're not exported.
16609 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16610 (Vwrite_region_annotation_buffers): Now static.
16611
57a96f5c
PE
16612 * eval.c: Make symbols static if they're not exported.
16613 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16614 * lisp.h (backtrace_list): Remove decl.
16615
35f08c38
PE
16616 * emacs.c: Make symbols static if they're not exported.
16617 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16618 (fatal_error_code, fatal_error_signal_hook, standard_args):
16619 Now static.
16620 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16621 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16622 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16623 * lisp.h (fatal_error_signal_hook): Remove decl.
16624 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16625
f44bd759
PE
16626 * editfns.c: Move a (normally-unused) function to its only use.
16627 * editfns.c, lisp.h (get_operating_system_release): Remove.
16628 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16629 worth the hassle of breaking this out.
16630
b532497d
PE
16631 * xterm.c: Make symbols static if they're not exported.
16632 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16633 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16634 (x_destroy_window, x_delete_display):
16635 Now static.
16636 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16637 (x_mouse_leave): Remove; unused.
16638 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16639 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16640 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16641 Remove decls.
16642 (x_mouse_leave): Declare only if WINDOWSNT.
16643 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16644 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16645 USE_X_TOOLKIT.
16646
1675728f
PE
16647 * ftxfont.c: Make symbols static if they're not exported.
16648 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16649 HAVE_FREETYPE.
16650 * font.h (ftxfont_driver): Likewise.
16651
e4cebfca
PE
16652 * xfns.c: Make symbols static if they're not exported.
16653 (x_last_font_name, x_display_info_for_name):
16654 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16655 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16656 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16657 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16658 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16659 (last_show_tip_args): Now static.
16660 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16661 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16662 (x_screen_planes): Remove; unused.
16663 * dispextern.h (x_screen_planes): Remove decl.
16664
5bf46f05
PE
16665 * dispnew.c: Make symbols static if they're not exported.
16666 * dispextern.h (redraw_garbaged_frames, scrolling):
16667 (increment_row_positions): Remove.
16668 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16669 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16670 Now static.
16671 (redraw_garbaged_frames): Remove; unused.
16672
435f4c28
PE
16673 * xfaces.c: Make symbols static if they're not exported.
16674 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16675 Remove decls.
16676 * xterm.h (defined_color): Remove decls.
16677 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16678 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16679 (menu_face_changed_default, defined_color, free_realized_face):
16680 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16681 (ascii_face_of_lisp_face): Remove; unused.
16682
8524aef3
PE
16683 * xdisp.c: Make symbols static if they're not exported.
16684 * dispextern.h (scratch_glyph_row, window_box_edges):
16685 (glyph_to_pixel_coords, set_cursor_from_row):
16686 (get_next_display_element, set_iterator_to_next):
16687 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16688 (show_mouse_face): Remove decls
16689 * frame.h (message_buf_print): Likewise.
16690 * lisp.h (pop_message, set_message, check_point_in_composition):
16691 Likewise.
16692 * xterm.h (set_vertical_scroll_bar): Likewise.
16693 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16694 (message_buf_print, scratch_glyph_row, displayed_buffer):
16695 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16696 (get_next_display_element, show_mouse_face, window_box_edges):
16697 (frame_to_window_pixel_xy, check_point_in_composition):
16698 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16699 (glyph_to_pixel_coords): Remove; unused.
16700
16390cd2
PE
16701 * dired.c (file_name_completion): Now static.
16702
16703 * dbusbind.c (xd_in_read_queued_messages): Now static.
16704
a25f4dfa
PE
16705 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16706 * data.c (circular_list_error): Remove.
16707
14a9c8df
PE
16708 * commands.h (last_point_position, last_point_position_buffer):
16709 (last_point_position_window): Remove decls.
16710 * keyboard.c: Make these variables static.
16711
04f2d78b
CB
16712 * coding.h (coding, code_convert_region, encode_coding_gap):
16713 Remove decls.
74ab6df5
PE
16714 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16715 (iso_code_class, detect_coding, code_convert_region): Now static.
16716 (encode_coding_gap): Remove; unused.
16717
38dfbee1
PE
16718 * chartab.c (chartab_chars, chartab_bits): Now static.
16719
a2cb4e63
PE
16720 * charset.h (charset_iso_8859_1): Remove decl.
16721 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16722 Now static.
16723
127198fd
PE
16724 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16725 * ccl.c (Vccl_program_table): Now static.
16726 (check_ccl_update): Remove; unused.
16727
d85b608f
PE
16728 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16729 * category.h: ... from here.
16730 * category.c (check_category_table, set_category_set): Now static.
16731
31cd66f3
PE
16732 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16733 * lisp.h: Remove these decls.
16734
c358e587
PE
16735 * buffer.c (buffer_count): Remove unused var.
16736
e78aecca
PE
16737 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16738 so that it's not optimized away.
16739 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16740 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16741 exported only to the debugger.
16742
e192d7d3 16743 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16744 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16745
92470028
PE
16746 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16747 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16748 was inaccessible from Lisp.
16749 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16750 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16751
244ed907
PE
16752 alloc.c: Import and export fewer symbols, and remove unused items.
16753 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16754 is defined.
16755 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16756 it's not optimized away by whole-program optimization.
16757 (message_enable_multibyte, free_misc): Remove.
16758 (catchlist, handlerlist, mark_backtrace):
16759 Declare only if BYTE_MARK_STACK.
16760 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16761 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16762 (message_enable_multibyte): Remove decl.
16763 (free_misc, interval_free_list, float_block, float_block_index):
16764 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16765 (cons_free_list, last_marked_index):
16766 Now static.
16767 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16768 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16769 (mark_backtrace): Define only if BYTE_MARK_STACK.
16770 * xdisp.c (message_enable_multibyte): Now static.
16771
61c2b50e 16772 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16773 This makes it easier for human readers (and static analyzers)
16774 to see whether these variables are used from other modules.
16775 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16776 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16777 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16778 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16779 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16780 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16781 * xmenu.c, xselect.c:
16782 Declare Q* vars static if they are not used in other modules.
16783 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16784 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16785 Remove decls of unexported vars.
16786 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16787
95c82688
PE
16788 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16789
16a97296
PE
16790 Make Emacs functions such as Fatom 'static' by default.
16791 This makes it easier for human readers (and static analyzers)
16792 to see whether these functions can be called from other modules.
16793 DEFUN now defines a static function. To make the function external
16794 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16795 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16796 (Finit_image_library):
16a97296
PE
16797 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16798 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16799 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16800 Remove decls, since these functions are now static.
16801 (Funintern, Fget_internal_run_time): New decls, since these functions
16802 were already external.
95c82688 16803
16a97296
PE
16804 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16805 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16806 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16807 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16808 * keyboard.c, keymap.c, lread.c:
16809 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16810 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16811 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16812 Mark functions with DEFUE instead of DEFUN,
16813 if they are used in other modules.
16814 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16815 decls for now-static functions.
16816 * buffer.h (Fdelete_overlay): Remove decl.
16817 * callproc.c (Fgetenv_internal): Mark as internal.
16818 * composite.c (Fremove_list_of_text_properties): Remove decl.
16819 (Fcomposition_get_gstring): New forward static decl.
16820 * composite.h (Fcomposite_get_gstring): Remove decl.
16821 * dired.c (Ffile_attributes): New forward static decl.
16822 * doc.c (Fdocumntation_property): New forward static decl.
16823 * eval.c (Ffetch_bytecode): New forward static decl.
16824 (Funintern): Remove extern decl; now in .h file where it belongs.
16825 * fileio.c (Fmake_symbolic_link): New forward static decl.
16826 * image.c (Finit_image_library): New forward static decl.
16827 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16828 * intervals.h (Fprevious_property_change):
16829 (Fremove_list_of_text_properties): Remove decls.
16830 * keyboard.c (Fthis_command_keys): Remove decl.
16831 (Fcommand_execute): New forward static decl.
16832 * keymap.c (Flookup_key): New forward static decl.
16833 (Fcopy_keymap): Now static.
16834 * keymap.h (Flookup_key): Remove decl.
16835 * process.c (Fget_process): New forward static decl.
16836 (Fprocess_datagram_address): Mark as internal.
16837 * syntax.c (Fsyntax_table_p): New forward static decl.
16838 (skip_chars): Remove duplicate decl.
16839 * textprop.c (Fprevious_property_change): New forward static decl.
16840 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16841 Now internal.
16842 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16843 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16844
785bbd42
PE
16845 * editfns.c (Fformat): Remove unreachable code.
16846
8b913b57
AS
168472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16848
16849 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16850 change. (Bug#8496)
16851
a6744a35
EZ
168522011-04-13 Eli Zaretskii <eliz@gnu.org>
16853
16854 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16855 when at ZV. (Bug#8487)
16856
e7974947
AS
168572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16858
baad03f0
AS
16859 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16860 (Bug#8437)
16861 * keyboard.c (parse_tool_bar_item): Likewise.
16862 * sound.c (sound_cleanup, alsa_close): Likewise.
16863 * termcap.c (tgetent): Likewise.
16864 * xfns.c (x_default_font_parameter): Likewise.
16865 * xsettings.c (read_and_apply_settings): Likewise.
16866
e7974947
AS
16867 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16868 (overrun_check_free): Protoize.
16869
28272684
PE
168702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16871
16872 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16873 since callers should never pass a negative size.
16874 Change the signature to match that of plain 'read' and 'write'; see
16875 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16876 * lisp.h: Update prototypes of emacs_write and emacs_read.
16877
11997c76
EZ
168782011-04-11 Eli Zaretskii <eliz@gnu.org>
16879
16880 * xdisp.c (redisplay_window): Don't try to determine the character
16881 position of the scroll margin if the window start point w->startp
e896f03c 16882 is outside the buffer's accessible region. (Bug#8468)
11997c76 16883
8a2cbd72
EZ
168842011-04-10 Eli Zaretskii <eliz@gnu.org>
16885
16886 Fix write-region and its subroutines for buffers > 2GB.
16887 * fileio.c (a_write, e_write): Modify declaration of arguments and
16888 local variables to support buffers larger than 2GB.
16889 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16890
16891 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16892 argument, local variables, and return value.
16893
16894 * lisp.h: Update prototypes of emacs_write and emacs_read.
16895
16896 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16897
4073e537 168982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16899
1ebfdcb6
PE
16900 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16901
b2ded58d
PE
16902 Fix more problems found by GCC 4.6.0's static checks.
16903
7d66342c
PE
16904 * xdisp.c (vmessage): Use a better test for character truncation.
16905
bbf47d44
PE
16906 * charset.c (load_charset_map): <, not <=, for optimization,
16907 and to avoid potential problems with integer overflow.
9248994d 16908 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16909 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16910 * editfns.c (Fformat): Likewise.
1e69125e 16911 * syntax.c (skip_chars): Likewise.
3befa583 16912
e3019616
PE
16913 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16914 This also lets GCC 4.6.0 generate slightly better loop code.
16915
becfa255
PE
16916 * callint.c (Fcall_interactively): <, not <=, for optimization.
16917 (Fcall_interactively): Count the number of arguments produced,
16918 not the number of arguments given. This is simpler and lets GCC
16919 4.6.0 generate slightly better code.
16920
dae0cd48
PE
16921 * ftfont.c: Distingish more carefully between FcChar8 and char.
16922 The previous code passed unsigned char * to a functions like
16923 strlen and xstrcasecmp that expect char *, which does not
16924 conform to the C standard.
16925 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16926 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16927 char * when the C standard requires it.
16928
76032d70
PE
16929 * keyboard.c (read_char): Remove unused var.
16930
eb3f1cc8
PE
16931 * eval.c: Port to Windows vsnprintf (Bug#8435).
16932 Include <limits.h>.
16933 (SIZE_MAX): Define if the headers do not.
16934 (verror): Do not give up if vsnprintf returns a negative count.
16935 Instead, grow the buffer. This ports to Windows vsnprintf, which
16936 does not conform to C99. Problem reported by Eli Zaretskii.
16937 Also, simplify the allocation scheme, by avoiding the need for
16938 calling realloc, and removing the ALLOCATED variable.
16939
70476b54
PE
16940 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16941
12020a9e
PE
16942 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16943 But keep the doprint source code for now, as we might revamp it
16944 and use it again (Bug#8435).
ea6c7ae6
PE
16945 * lisp.h (doprnt): Remove.
16946 * Makefile.in (base_obj): Remove doprnt.o.
16947 * deps.mk (doprnt.o): Remove.
16948
5fdb398c
PE
16949 error: Print 32- and 64-bit integers portably (Bug#8435).
16950 Without this change, on typical 64-bit hosts error ("...%d...", N)
16951 was used to print both 32- and 64-bit integers N, which relied on
16952 undefined behavior.
61bdb816 16953 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16954 * lisp.h (error, verror): Mark as printf-like functions.
16955 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16956 Report overflow in size calculations when allocating printf buffer.
16957 Do not truncate output string at its first null byte.
16958 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16959 Truncate the output at a character boundary, since vsnprintf does not
16960 do that.
16961 * charset.c (check_iso_charset_parameter): Convert internal
16962 character to string before calling 'error', since %c now has the
16963 printf meaning.
16964 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16965 overflow when computing char to be passed to 'error'. Do not
16966 pass Lisp_Object to 'error'; pass the integer instead.
16967 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16968 formatted with plain %d.
16969
b189fa66
PE
16970 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16971
bff87ef0
PE
16972 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16973
7e2cac20
PE
16974 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16975
ce4d90b5
PE
16976 * xterm.c (x_catch_errors): Remove duplicate declaration.
16977
266c9547
PE
16978 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16979
79c49ad2
PE
16980 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16981
368f4090
JM
169822011-04-10 Jim Meyering <meyering@redhat.com>
16983
16984 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16985 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16986 return ssize_t not "int", and use size_t as the buffer length.
16987 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16988 * gnutls.h: Update declarations.
16989 * process.c (read_process_output): Use ssize_t, to match.
16990 (send_process): Likewise.
16991
a32d4040
CY
169922011-04-09 Chong Yidong <cyd@stupidchicken.com>
16993
16994 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16995
8546720e 169962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16997
04f2d78b
CB
16998 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16999 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 17000
8546720e
GM
17001 * xterm.c (handle_one_xevent):
17002 * xmenu.c (create_and_show_popup_menu):
17003 * xselect.c (x_decline_selection_request)
17004 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 17005
0a2f5c1a 170062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
17007
17008 Fix some uses of `int' instead of EMACS_INT.
17009 * search.c (string_match_1, fast_string_match)
17010 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
17011 (scan_buffer, find_next_newline_no_quit)
17012 (find_before_next_newline, search_command, Freplace_match)
17013 (Fmatch_data): Make some `int' variables be EMACS_INT.
17014
17015 * xdisp.c (display_count_lines): 3rd argument and return value now
17016 EMACS_INT. All callers changed.
17017 (pint2hrstr): Last argument is now EMACS_INT.
17018
17019 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
17020 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
17021 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
17022 (decode_coding_utf_16, decode_coding_emacs_mule)
17023 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
17024 (decode_coding_ccl, decode_coding_charset)
17025 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
17026 (decode_coding_iso_2022, decode_coding_emacs_mule)
17027 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
17028 <char_offset, last_offset>: Declare EMACS_INT.
17029 (encode_coding_utf_8, encode_coding_utf_16)
17030 (encode_coding_emacs_mule, encode_invocation_designation)
17031 (encode_designation_at_bol, encode_coding_iso_2022)
17032 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
17033 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
17034 Declare EMACS_INT.
17035 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
17036 (encode_invocation_designation): Last argument P_NCHARS is now
17037 EMACS_INT.
17038 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
17039 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
17040
17041 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
17042 All users changed.
17043
17044 * ccl.c (Fccl_execute_on_string): Declare some variables
17045 EMACS_INT.
17046
8546720e 170472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
17048
17049 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
17050
4e19a977
CS
170512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
17052
17053 * process.c (Fformat_network_address): Doc fix.
17054
87302331
R
170552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
17056
ee7683eb 17057 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 17058
cbb59342
CY
170592011-04-08 Chong Yidong <cyd@stupidchicken.com>
17060
17061 * keyboard.c (read_char): Call Lisp function help-form-show,
17062 instead of using internal_with_output_to_temp_buffer.
17063 (Qhelp_form_show): New var.
e0d38eeb 17064 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
17065
17066 * print.c (internal_with_output_to_temp_buffer): Function deleted.
17067
17068 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
17069
e67a13ab
CY
170702011-04-06 Chong Yidong <cyd@stupidchicken.com>
17071
04f2d78b
CB
17072 * process.c (Flist_processes): Remove to Lisp.
17073 (list_processes_1): Delete.
e67a13ab 17074
973f782d
EZ
170752011-04-06 Eli Zaretskii <eliz@gnu.org>
17076
7c106b1e
EZ
17077 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
17078
973f782d
EZ
17079 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
17080
41cf7d1a 170812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 17082
ca23cc88
PE
17083 Fix more problems found by GCC 4.6.0's static checks.
17084
f390e2d5
PE
17085 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
17086
42eea0d0
PE
17087 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
17088
b69769da 17089 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 17090
f9541e84
PE
17091 * xdisp.c (vmessage): Mark as a printf-like function.
17092
13841b55
PE
17093 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
17094
c136c10f
PE
17095 * sound.c (sound_warning): Don't crash if arg contains a printf format.
17096
5e2d4a30
PE
17097 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
17098 printf-like functions.
17099 (tiff_load): Add casts to remove these marks before passing them
17100 to system-supplied API.
17101
583f48b9
PE
17102 * eval.c (Fsignal): Remove excess argument to 'fatal'.
17103
b25d760e
PE
17104 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
17105 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
17106 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
17107 directly, rather than having caller test rule sign. This avoids
17108 some unnecessary tests.
17109 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
17110 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
17111 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 17112
bc7b6697 17113 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 17114 (xfont_open): Avoid unnecessary tests.
bc7b6697 17115
27ccc379
PE
17116 * composite.c (composition_gstring_put_cache): Use unsigned integer.
17117
dcd5c89a
PE
17118 * composite.h, composite.c (composition_gstring_put_cache):
17119 Use EMACS_INT, not int, for length.
17120
b13a45c6
PE
17121 * composite.h (COMPOSITION_DECODE_REFS): New macro,
17122 breaking out part of COMPOSITION_DECODE_RULE.
17123 (COMPOSITION_DECODE_RULE): Use it.
17124 * composite.c (get_composition_id): Remove unused local vars,
17125 by using the new macro.
17126
1e792e4d
PE
17127 * textprop.c (set_text_properties_1): Change while to do-while,
17128 since the condition is always true at first.
17129
dc6c6455 17130 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
17131 (interval_deletion_adjustment): Return unsigned value.
17132 All uses changed.
dc6c6455 17133
aba7731a
PE
17134 * process.c (list_processes_1, create_pty, read_process_output):
17135 (exec_sentinel): Remove vars that were set but not used.
afd4052b 17136 (create_pty): Remove unnecessary "volatile"s.
bc57d757 17137 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 17138 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 17139 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 17140
fdfc4bf3
PE
17141 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
17142
fca8fe46 17143 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 17144 (update_syntax_table): Use unsigned instead of int.
fca8fe46 17145
06a0259a 17146 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 17147 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 17148 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 17149
e7b9e80f
PE
17150 * print.c (print_error_message): Avoid int overflow.
17151
56201685
PE
17152 * font.c (font_list_entities): Redo for clarity,
17153 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
17154
78834453 17155 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 17156 (font_score): Avoid potential overflow in diff calculation.
78834453 17157
0bc0b309 17158 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 17159 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 17160
e610eaca
PE
17161 * eval.c (funcall_lambda): Rename local to avoid shadowing.
17162
b895abce
PE
17163 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
17164 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
17165 can always succeed if overflow has undefined behavior.
17166
1f1d9321 17167 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 17168 (wordify): Omit three unnecessary tests.
1f1d9321 17169
c59478bc
PE
17170 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
17171 All callers changed. This avoids the need for an unused var.
17172
79b73827
PE
17173 * casefiddle.c (casify_region): Remove var that is set but not used.
17174
a4db5dfe
PE
17175 * dired.c (file_name_completion): Remove var that is set but not used.
17176
43aae36e
PE
17177 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
17178
2a47c44d 17179 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 17180 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 17181
a37c69bf
PE
17182 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
17183 Check for integer overflow on size calculations.
17184
328ab8e7
PE
17185 * buffer.c (Fprevious_overlay_change): Remove var that is set
17186 but not used.
17187
e5a2a5cb
PE
17188 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
17189 Remove vars that are set but not used.
8d84a6eb 17190 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 17191 (timer_check_2): Mark vars as initialized.
e5a2a5cb 17192
a60e5f68
PE
17193 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
17194
f661cb61 17195 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 17196 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 17197
f0397f5a
PE
17198 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
17199 that are set but not used.
17200
8664db06 17201 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 17202 if XCreateBitmapFromData fails (Bug#8410).
8664db06 17203
6abdaa4a
PE
17204 * xselect.c (x_get_local_selection, x_handle_property_notify):
17205 Remove vars that are set but not used.
17206
0ce7538d 17207 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 17208 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 17209
9ae848fc
PE
17210 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
17211 Remove var that is set but not used.
0b918413
PE
17212 (scroll_bar_windows_size): Now size_t, not int.
17213 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
17214 Check for overflow.
9ae848fc 17215
a5a62657
PE
17216 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17217 (map_tty_color) [!defined MSDOS]: Likewise.
17218
5c5cdd39
PE
17219 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17220
66ebf983
PE
17221 * coding.c: Remove vars that are set but not used.
17222 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17223 All callers changed.
17224 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17225 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17226 (decode_coding_charset): Remove vars that are set but not used.
17227
1be4d761
PE
17228 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17229 that is set but not used.
17230
47553fa8
PE
17231 * print.c (print_object): Remove var that is set but not used.
17232
1f7196bf 17233 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17234 The gnulib version avoids calling malloc in the usual case,
17235 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17236 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17237 * filelock.c (current_lock_owner): Likewise.
17238 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17239 * sysdep.c: Include allocator.h, careadlinkat.h.
17240 (emacs_no_realloc_allocator): New static constant.
17241 (emacs_readlink): New function.
fdb61804
PE
17242 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17243 ../lib/careadlinkat.h.
d1fdcab7 17244
f84c17c7
SM
172452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17246
17247 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17248 first non-nil return value).
17249
ef3862ad
JD
172502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17251
17252 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17253 if not defined (Bug#8403).
17254
376a7006
JB
172552011-04-02 Juanma Barranquero <lekktu@gmail.com>
17256
17257 * xdisp.c (display_count_lines): Remove parameter `start',
17258 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17259 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17260 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17261 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17262 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17263 and thereabouts. All callers changed.
17264 (get_per_char_metric): Remove parameter `f', unused since
17265 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17266
6ca3801d
JM
172672011-04-02 Jim Meyering <meyering@redhat.com>
17268
17269 do not dereference NULL upon failed strdup
17270 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17271 (ns_get_family): Likewise.
17272
d8e2b5ba
JB
172732011-04-02 Juanma Barranquero <lekktu@gmail.com>
17274
17275 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17276
8c74fcbd
JD
172772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17278
17279 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17280 later (Bug#8403).
17281
7200d79c
SM
172822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17283
03408648 17284 Add lexical binding.
7200d79c 17285
03408648
SM
17286 * window.c (Ftemp_output_buffer_show): New fun.
17287 (Fsave_window_excursion):
17288 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17289
17290 * lread.c (lisp_file_lexically_bound_p): New function.
17291 (Fload): Bind Qlexical_binding.
17292 (readevalloop): Remove `evalfun' arg.
17293 Bind Qinternal_interpreter_environment.
17294 (Feval_buffer): Bind Qlexical_binding.
17295 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17296 Mark as dynamic.
17297 (syms_of_lread): Declare `lexical-binding'.
17298
17299 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17300
17301 * keyboard.c (eval_dyn): New fun.
17302 (menu_item_eval_property): Use it.
ca105506
SM
17303
17304 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17305
03408648
SM
17306 * fns.c (concat, mapcar1): Accept byte-code-functions.
17307
17308 * eval.c (Fsetq): Handle lexical vars.
17309 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17310 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17311 (FletX, Flet): Obey lexical binding.
17312 (Fcommandp): Handle closures.
17313 (Feval): New `lexical' arg.
17314 (eval_sub): New function extracted from Feval. Use it almost
17315 everywhere where Feval was used. Look up vars in lexical env.
17316 Handle closures.
17317 (Ffunctionp): Move from subr.el.
17318 (Ffuncall): Handle closures.
17319 (apply_lambda): Remove `eval_flags'.
17320 (funcall_lambda): Handle closures and new byte-code-functions.
17321 (Fspecial_variable_p): New function.
17322 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17323 but without exporting it to Lisp.
23aba0ea 17324
23aba0ea 17325 * doc.c (Fdocumentation, store_function_docstring):
03408648 17326 * data.c (Finteractive_form): Handle closures.
23aba0ea 17327
03408648
SM
17328 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17329 interactive spec.
ba83908c 17330
04f2d78b
CB
17331 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17332 New byte-codes.
03408648
SM
17333 (exec_byte_code): New function extracted from Fbyte_code to handle new
17334 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17335
03408648 17336 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17337
03408648 17338 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17339
e2abce01
JB
173402011-03-31 Juanma Barranquero <lekktu@gmail.com>
17341
17342 * xdisp.c (redisplay_internal): Fix prototype.
17343
63696a73 173442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17345
63696a73 17346 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17347 (try_scrolling): Use it when setting scroll_limit.
17348 Limit scrolling to 100 screen lines.
63696a73
EZ
17349 (redisplay_window): Even when falling back on "recentering",
17350 position point in the window according to scroll-conservatively,
17351 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17352
17353 (try_scrolling): When point is above the window, allow searching
17354 as far as scroll_max, or one screenful, to compute vertical
17355 distance from PT to the scroll margin position. This prevents
17356 try_scrolling from unnecessarily failing when
17357 scroll-conservatively is set to a value slightly larger than the
17358 window height. Clean up the case of PT below the margin at bottom
17359 of window: scroll_max can no longer be INT_MAX. When aggressive
17360 scrolling is in use, don't let point enter the opposite scroll
17361 margin as result of the scroll.
17362 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17363 threshold of 100 lines for never-recentering scrolling.
17364
e4cc2dfc
JB
173652011-03-31 Juanma Barranquero <lekktu@gmail.com>
17366
17367 * dispextern.h (move_it_by_lines):
17368 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17369 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17370 (message_log_check_duplicate): Remove parameters `prev_bol' and
17371 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17372 (redisplay_internal): Remove parameter `preserve_echo_area',
17373 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17374
17375 * indent.c (Fvertical_motion):
17376 * window.c (window_scroll_pixel_based, Frecenter):
17377 Don't pass `need_y_p' to `move_it_by_lines'.
17378
1c470562
SM
173792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17380
44f230aa
SM
17381 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17382 steal a few bits to be more compact.
17383 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17384 Remove unneeded casts.
17385
1c470562
SM
17386 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17387
888adce9
ZK
173882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17389
17390 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17391 binding" message (bug#7967).
17392
f838ed7b
PE
173932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17394
77861b95
PE
17395 Fix more problems found by GCC 4.6.0's static checks.
17396
de6dbc14
PE
17397 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17398 Remove unused local var.
17399
f838ed7b
PE
17400 * editfns.c (Fmessage_box): Remove unused local var.
17401
792c7b2b
PE
17402 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17403 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17404 Omit unused local vars.
c499e557 17405 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17406 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17407 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17408 Omit unused local var.
17409
ba0165e1
PE
17410 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17411 Don't assume string length fits in int.
32ad8845 17412 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17413 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17414
3c59b4c9
PE
17415 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17416 instead of alloca (Bug#8344).
17417
a3eed478 17418 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17419 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17420
eb4d412d
PE
17421 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17422
1658b401
PE
17423 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17424 concerns.
17425
17426 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17427
17428 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17429
9a2c6e05
PE
17430 * keyboard.c (syms_of_keyboard): Use the same style as later
17431 in this function when indexing through an array. This also
17432 works around GCC bug 48267.
17433
03d0a109
PE
17434 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17435
44f730c8
PE
17436 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17437
fe75f926
PE
17438 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17439 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17440
ffa8c828
PE
17441 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17442 This avoids undefined behavior on integer overflow, and is a bit
17443 more convenient anyway since it is compared to a size_t variable.
17444
c5101a77
PE
17445 Variadic C functions now count arguments with size_t, not int.
17446 This avoids an unnecessary limitation on 64-bit machines, which
17447 caused (substring ...) to crash on large vectors (Bug#8344).
17448 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17449 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17450 All variadic functions and their callers changed accordingly.
c5101a77
PE
17451 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17452 * data.c (arith_driver, float_arith_driver): Likewise.
17453 * editfns.c (general_insert_function): Likewise.
17454 * eval.c (struct backtrace.nargs, interactive_p)
17455 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17456 (funcall_lambda, mark_backtrace): Likewise.
17457 * fns.c (concat): Likewise.
17458 * frame.c (x_set_frame_parameters): Likewise.
17459 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17460 0 if not found, not -1. All callers changed.
17461
dd3f25f7
PE
17462 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17463 (stack_copy_size): Now size_t, not int.
17464 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17465
461c2ab9
JB
174662011-03-28 Juanma Barranquero <lekktu@gmail.com>
17467
17468 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17469 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17470 All callers changed.
17471
17472 * lisp.h (multibyte_char_to_unibyte):
17473 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17474 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17475 * character.h (CHAR_TO_BYTE8):
17476 * cmds.c (internal_self_insert):
17477 * editfns.c (general_insert_function):
17478 * keymap.c (push_key_description):
17479 * search.c (Freplace_match):
17480 * xdisp.c (message_dolog, set_message_1): All callers changed.
17481
f6d62986
SM
174822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17483
17484 * keyboard.c (safe_run_hook_funcall): New function.
17485 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17486 don't set the hook to nil, but remove the offending function instead.
17487 (Qcommand_hook_internal): Remove, unused.
17488 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17489 Vcommand_hook_internal.
17490
17491 * eval.c (enum run_hooks_condition): Remove.
17492 (funcall_nil, funcall_not): New functions.
17493 (run_hook_with_args): Call each function through a `funcall' argument.
17494 Remove `cond' argument, now redundant.
17495 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17496 (Frun_hook_with_args_until_failure): Adjust accordingly.
17497 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17498
1db5b1ad
JB
174992011-03-28 Juanma Barranquero <lekktu@gmail.com>
17500
17501 * dispextern.h (string_buffer_position): Remove declaration.
17502
17503 * print.c (strout): Remove parameter `multibyte', unused since
17504 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17505
17506 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17507 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17508 All callers changed.
17509
17510 * w32.c (_wsa_errlist): Use braces for struct initializers.
17511
17512 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17513 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17514 All callers changed.
17515 (string_buffer_position): Likewise. Also, make static (it's never
17516 used outside xdisp.c).
17517 (cursor_row_p): Remove parameter `w', unused since
17518 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17519 (decode_mode_spec): Remove parameter `precision', introduced during
17520 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17521 All callers changed.
17522
5ffb62aa
JD
175232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17524
17525 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17526
461c2ab9 175272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17528
17529 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17530 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17531 (ns_update_auto_hide_menu_bar): New functions.
17532 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17533 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17534 ns_constrain_all_frames.
17535 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17536 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17537
5c380ffb
JD
175382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17539
17540 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17541
9af30bdf
GM
175422011-03-27 Glenn Morris <rgm@gnu.org>
17543
17544 * syssignal.h: Replace RETSIGTYPE with void.
17545 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17546 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17547 Replace SIGTYPE with void everywhere.
17548 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17549 * s/template.h (SIGTYPE): Remove commented out definition.
17550
e2abce01
JB
175512011-03-26 Eli Zaretskii <eliz@gnu.org>
17552
17553 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17554 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17555
f868cd8a
JB
175562011-03-26 Juanma Barranquero <lekktu@gmail.com>
17557
59eb0929
JB
17558 * w32.c (read_unc_volume): Use parameter `henum', instead of
17559 global variable `wget_enum_handle'.
17560
17561 * keymap.c (describe_vector): Remove parameters `indices' and
17562 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17563 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17564
f868cd8a
JB
17565 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17566
17567 * keyboard.c (timer_check): Remove parameter `do_it_now',
17568 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17569 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17570 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17571
17572 * keyboard.c (read_char):
17573 * w32menu.c (w32_menu_display_help):
17574 * xmenu.c (show_help_event, menu_help_callback):
17575 Adjust calls to `show_help_echo'.
17576
17577 * gtkutil.c (xg_maybe_add_timer):
17578 * keyboard.c (readable_events):
17579 * process.c (wait_reading_process_output):
17580 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17581
17582 * insdel.c (adjust_markers_gap_motion):
17583 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17584 (gap_left, gap_right): Don't call it.
17585
2ecf6fdb
CY
175862011-03-25 Chong Yidong <cyd@stupidchicken.com>
17587
17588 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17589 incurred during fontification.
17590
6b1f9ba4
JB
175912011-03-25 Juanma Barranquero <lekktu@gmail.com>
17592
17593 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17594 (DEFVAR_PER_BUFFER): Don't pass it.
17595
17596 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17597 (scrolling_window): Don't pass it.
17598
0f4a96b5
JB
175992011-03-25 Juanma Barranquero <lekktu@gmail.com>
17600
17601 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17602
17603 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17604 and `suffix'.
17605 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17606 of variables specific to SELinux and computation of `encoded_absname'.
17607
17608 * image.c (XPutPixel): Remove unused variable `height'.
17609
17610 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17611
17612 * unexw32.c (get_section_info): Remove unused variable `section'.
17613
17614 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17615 (system_process_attributes): Remove unused variable `sess'.
17616 (sys_read): Remove unused variable `err'.
17617
17618 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17619 (w32_wnd_proc): Remove unused variable `isdead'.
17620 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17621 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17622 (x_create_tip_frame): Remove unused variable `tem'.
17623
17624 * w32inevt.c (w32_console_read_socket):
17625 Remove unused variable `no_events'.
17626
17627 * w32term.c (x_draw_composite_glyph_string_foreground):
17628 Remove unused variable `width'.
17629
1149507c
JB
176302011-03-24 Juanma Barranquero <lekktu@gmail.com>
17631
17632 * w32term.c (x_set_glyph_string_clipping):
17633 Don't pass uninitialized region to CombineRgn.
17634
9c88f339
JB
176352011-03-23 Juanma Barranquero <lekktu@gmail.com>
17636
17637 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17638 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17639 (Fx_close_connection): Remove unused variable `i'.
17640
17641 * w32font.c (w32font_draw): Return number of glyphs.
17642 (w32font_open_internal): Remove unused variable `i'.
17643 (w32font_driver): Add missing initializer.
17644
17645 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17646 (fill_in_menu): Remove unused variable `items_added'.
17647
17648 * w32term.c (last_mouse_press_frame): Remove static global variable.
17649 (w32_clip_to_row): Remove unused variable `f'.
17650 (x_delete_terminal): Remove unused variable `i'.
17651
17652 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17653 (NOTHING): Remove unused static global variable.
17654 (uniscribe_check_otf): Remove unused variable `table'.
17655 (uniscribe_font_driver): Add missing initializers.
17656
dee091a3
JD
176572011-03-23 Julien Danjou <julien@danjou.info>
17658
17659 * term.c (Fsuspend_tty, Fresume_tty):
17660 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17661 * window.c (temp_output_buffer_show):
17662 * insdel.c (signal_before_change):
17663 * frame.c (Fhandle_switch_frame):
17664 * fileio.c (Fdo_auto_save):
17665 * emacs.c (Fkill_emacs):
17666 * editfns.c (save_excursion_restore):
17667 * cmds.c (internal_self_insert):
17668 * callint.c (Fcall_interactively):
17669 * buffer.c (Fkill_all_local_variables):
17670 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17671 Use Frun_hooks.
0f4a96b5 17672 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17673 unconditionally since it does the check itself.
dee091a3 17674
2c520ab5 176752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17676
c9c49752
PE
17677 Fix more problems found by GCC 4.5.2's static checks.
17678
8abc3f12
PE
17679 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17680 the first time through the loop, since we know p0 < p1 then.
17681 This also avoids a gcc -Wstrict-overflow warning.
17682
a2d26660
PE
17683 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17684 leading to a memory leak, possible in functions like
17685 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17686 of objects (Bug#8318).
a2d26660 17687
916c72e9
PE
17688 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17689 that could (at least in theory) be that large.
17690
19ab8a18
PE
17691 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17692 This is less likely to overflow, and avoids undefined behavior if
17693 overflow does occur. All callers changed. Use strtoul to scan
17694 for the unsigned long integer.
b7cbbd6f
PE
17695 (pint2hrstr): Simplify and tune code slightly.
17696 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17697
f0641eff
PE
17698 * scroll.c (do_scrolling): Work around GCC bug 48228.
17699 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17700
7f650bb9
PE
17701 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17702 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17703 (validate_x_resource_name): Simplify count usage.
17704 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17705
37dd57d1
PE
17706 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17707 fail (Bug#8306).
81e56e61 17708
699979fc 17709 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17710
401bf9b4
PE
17711 * process.c (Fmake_network_process): Use socklen_t, not int,
17712 where POSIX says socklen_t is required in portable programs.
17713 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17714 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17715 (Fmake_network_process, server_accept_connection):
17716 (wait_reading_process_output, read_process_output):
17717 Likewise.
17718
b93aacde
PE
17719 * process.c: Rename or move locals to avoid shadowing.
17720 (list_processes_1, Fmake_network_process):
17721 (read_process_output_error_handler, exec_sentinel_error_handler):
17722 Rename or move locals.
4dc343ee 17723 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17724 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17725 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17726 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17727 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17728
af8a867c 17729 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17730 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17731 Include tparam.h instead, since it declares them.
af8a867c
PE
17732 * cm.h (PC): Remove extern decl; tparam.h now does this.
17733 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17734 * terminfo.c: Include tparam.h, to check interfaces.
17735 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17736 (tparam): Adjust signature to match interface in tparam.h;
17737 this removes some undefined behavior. Check that outstring and len
17738 are zero, which they always are with Emacs.
17739 * tparam.h (PC, BC, UP): New extern decls.
17740
0248044d 17741 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17742 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17743
8ff096c1 17744 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17745 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17746 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17747 (ftfont_list): Remove unused local.
49eaafba
PE
17748 (get_adstyle_property, ftfont_pattern_entity):
17749 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17750 Rename locals to avoid shadowing.
8ff096c1 17751
e2be39f6
PE
17752 * xfont.c (xfont_list_family): Mark var as initialized.
17753
c9735e30
PE
17754 * xml.c (make_dom): Now static.
17755
8f5201ae
PE
17756 * composite.c (composition_compute_stop_pos): Rename local to
17757 avoid shadowing.
b246f932
PE
17758 (composition_reseat_it): Remove unused locals.
17759 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17760 (composition_update_it): Mark var as initialized.
11b61122
PE
17761 (find_automatic_composition): Mark vars as initialized,
17762 with a FIXME (Bug#8290).
8f5201ae 17763
760fbc2c
PE
17764 character.h: Rename locals to avoid shadowing.
17765 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17766 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17767 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17768 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17769 to avoid shadowing.
17770
ff08eb85
PE
17771 * textprop.c (property_change_between_p): Remove; unused.
17772
fc7bf025
PE
17773 * intervals.c (interval_start_pos): Now static.
17774
235d7abc
PE
17775 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17776
44f230aa
SM
17777 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17778 Rename locals to avoid shadowing.
3e7d6594 17779
50060332
PE
17780 * sound.c (wav_play, au_play, Fplay_sound_internal):
17781 Fix pointer signedness.
d01f234b 17782 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17783 (wav_play): Initialize a variable to 0, to prevent undefined
17784 behavior (Bug#8278).
50060332 17785
c4fc4e30
PE
17786 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17787
918436ed
PE
17788 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17789
c939f91b
PE
17790 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17791 clobbering (Bug#8298).
b9c7f648
PE
17792 * sysdep.c (sys_subshell): Likewise.
17793 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17794
6bd8c144
PE
17795 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17796 This should get cleaned up, so that child_setup has the
17797 same signature on all platforms.
17798
7710357c 17799 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17800 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17801
c59da222
CY
178022011-03-22 Chong Yidong <cyd@stupidchicken.com>
17803
17804 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17805 not to be necessary, and produces flickering.
17806
66b87493
GM
178072011-03-20 Glenn Morris <rgm@gnu.org>
17808
17809 * config.in: Remove file.
17810
45b6f6d5
JB
178112011-03-20 Juanma Barranquero <lekktu@gmail.com>
17812
17813 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17814 are now in src/globals.h.
17815 (syms_of_minibuf): Remove spurious & from previous change.
17816
cd394be1 178172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17818
17819 * minibuf.c (completing-read-function): New variable.
17820 (completing-read-default): Rename from completing-read.
17821 (completing-read): Call completing-read-function.
17822
b14e3e21
CY
178232011-03-19 Juanma Barranquero <lekktu@gmail.com>
17824
17825 * xfaces.c (Fx_load_color_file):
17826 Read color file from absolute filename (bug#8250).
17827
f2b726e6
JB
178282011-03-19 Juanma Barranquero <lekktu@gmail.com>
17829
17830 * makefile.w32-in: Update dependencies.
17831
09f6ff02
EZ
178322011-03-17 Eli Zaretskii <eliz@gnu.org>
17833
17834 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17835
29a6015a
PE
178362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17837
a3a6c54e
PE
17838 Fix more problems found by GCC 4.5.2's static checks.
17839
b766f867
PE
17840 * process.c (make_serial_process_unwind, send_process_trap):
17841 (sigchld_handler): Now static.
17842
be02381c
PE
17843 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17844 That way, the code declares only the vars that it needs.
17845 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17846 * s/cygwin.h (PTY_ITERATION): Likewise.
17847 * s/darwin.h (PTY_ITERATION): Likewise.
17848 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17849
57048744
PE
17850 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17851 * process.c (allocate_pty): Don't declare stb unless it's needed.
17852
7914961c 17853 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17854 (CONSTANTLIM): Remove; unused.
17855 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17856 Define only if needed.
7914961c 17857
b3967b18
PE
17858 * unexelf.c (unexec): Name an expression,
17859 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17860 Use a different way to cause a compilation error if anyone uses
17861 n rather than nn, a way that does not involve shadowing.
73366a00 17862 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17863
29a6015a
PE
17864 * deps.mk (unexalpha.o): Remove; unused.
17865
43cfc33e 17866 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17867 * unexec.h: New file.
ce701a33
PE
17868 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17869 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17870 Depend on unexec.h.
17871 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17872 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17873 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17874 Change as necessary to match prototype in unexec.h.
ce701a33 17875
01f44d5a
PE
17876 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17877 shadowing.
4f63c6bb 17878 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17879
a6670b0b
PE
17880 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17881 Rename locals to avoid shadowing.
17882
cef2010d 17883 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17884 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17885
d4d7173a
PE
17886 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17887
f08b802a
PE
17888 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17889 warning when compiling print.c.
17890
3ddb0639
PE
17891 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17892 instead of using an uninitialized var.
5ad03b97 17893 (font_sort_entities): Mark var as initialized.
3ddb0639 17894
170a2692
PE
17895 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17896
e663c700
PE
17897 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17898 pointers to constants.
89bc529a 17899 (font_parse_fcname): Remove unused vars.
7b81e2d0 17900 (font_delete_unmatched): Now static.
ea838e10 17901 (font_get_spec): Remove; unused.
13a547c6
PE
17902 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17903 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17904 Rename or move locals to avoid shadowing.
e663c700 17905
2a80c887 17906 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17907 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17908
1384fa33 17909 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17910 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17911
8b2c52e9
PE
17912 * alloc.c (mark_backtrace): Move decl from here ...
17913 * lisp.h: ... to here, so that it can be checked.
17914
475545b5 17915 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17916 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17917 (lisp_indirect_variable): Name an expression,
17918 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17919 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17920
b1349114 17921 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17922 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17923 Use const pointer when appropriate.
b1349114 17924
a2928364
PE
17925 * lisp.h (get_system_name, get_operating_system_release):
17926 Move decls here, to check interfaces.
17927 * process.c (get_operating_system_release): Move decl to lisp.h.
17928 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17929 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17930 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17931 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17932 (Fformat_time_string, Fencode_time, Finsert_char):
17933 (Ftranslate_region_internal, Fformat):
17934 Rename or remove local vars to avoid shadowing.
9710023e 17935 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17936
a415e694
PE
17937 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17938 avoid shadowing.
17939
8ef4622d
PE
17940 * lisp.h (eassert): Check that the argument compiles, even if
17941 ENABLE_CHECKING is not defined.
17942
946f9a5b
PE
17943 * data.c (Findirect_variable): Name an expression, to avoid
17944 gcc -Wbad-function-cast warning.
112396d6 17945 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17946 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17947 (Fmake_variable_buffer_local, Fmake_local_variable):
17948 Mark variables as initialized.
52746918 17949 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17950
e5aab7e7 17951 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17952 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17953 Rename locals to avoid shadowing.
dff45157
PE
17954 (mark_stack): Move local variables into the #ifdef region where
17955 they're used.
7bc26fdb
PE
17956 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17957 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17958 needed otherwise.
17959 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17960 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17961 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17962
e5aab7e7
PE
17963 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17964 avoids undefined behavior in theory.
17965
4da60324
PE
17966 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17967
88043301
PE
17968 Use functions, not macros, for up- and down-casing (Bug#8254).
17969 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17970 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17971 to use the following functions instead of these macros.
17972 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17973 EMACS_INT, since callers assume the returned value fits in int.
17974 (upcase1): Likewise, for UPCASE_TABLE.
17975 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17976 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17977 the race-condition problem in the old DOWNCASE.
88043301 17978
19ed5445
PE
17979 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17980 Rename locals to avoid shadowing.
17981 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17982 (regex_compile, re_search_2, re_match_2_internal):
17983 Remove unused local vars.
952db0d7
PE
17984 (FREE_VAR): Rewrite so as not to use empty "else",
17985 which gcc can warn about.
da053e48 17986 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17987 (RETALLOC_IF): Define only if needed.
17988 (WORDCHAR_P): Likewise. This one is never needed, but is used
17989 only in a comment talking about a compiler bug, so put inside
17990 the #if 0 of that comment.
17991 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17992 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17993 Remove; unused.
19ed5445 17994
1f3561e4 17995 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17996 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17997 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17998
ded6f8f7
PE
17999 * search.c (simple_search): Remove unused var.
18000
dbd37a95
PE
18001 * dired.c (compile_pattern): Move decl from here ...
18002 * lisp.h: ... to here, so that it can be checked.
18003 (struct re_registers): New forward decl.
18004
7e47afad
PE
18005 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
18006
85f24f61
PE
18007 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
18008 All uses changed.
18009 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
18010 Rename locals to avoid shadowing.
5671df8f 18011 (Fvertical_motion): Mark locals as initialized.
85f24f61 18012
181aa2be 18013 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 18014 (casify_region): Mark local as initialized.
181aa2be 18015
930d429c
PE
18016 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
18017
7082eac6
PE
18018 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
18019 New macros, so that the caller can use some names other than
18020 gcpro1, gcpro2, etc.
18021 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
18022 of the new macros.
18023 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
18024 argument, for consistency with GCPRO2_VAR, etc: it is now the
18025 prefix of the variable, not the variable itself. All uses
18026 changed.
38b2c076
PE
18027 * dired.c (directory_files_internal, file_name_completion):
18028 Rename locals to avoid shadowing.
18029
15206ed9
PE
18030 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
18031 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
18032 dired.c's scmp function, had undefined behavior.
18033 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18034 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
18035 * buffer.h: ... to here, because these macros use current_buffer,
18036 and the new implementation with inline functions needs to have
18037 current_buffer in scope now, rather than later when the macros
18038 are used.
18039 (downcase, upcase1): New static inline functions.
18040 (DOWNCASE, UPCASE1): Reimplement using these functions.
18041 This avoids undefined behavior in expressions like
18042 DOWNCASE (x) == DOWNCASE (y), which previously suffered
18043 from race conditions in accessing the global variables
18044 case_temp1 and case_temp2.
18045 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
18046 * lisp.h (case_temp1, case_temp2): Remove their decls.
18047 * character.h (ASCII_CHAR_P): Move from here ...
18048 * lisp.h: ... to here, so that the inline functions mentioned
18049 above can use them.
18050
4a6bea26
PE
18051 * dired.c (directory_files_internal_unwind): Now static.
18052
f14b7e14
PE
18053 * fileio.c (file_name_as_directory, directory_file_name):
18054 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
18055 Now static.
2893f146
PE
18056 (file_name_as_directory): Use const pointers when appropriate.
18057 (Fexpand_file_name): Likewise. In particular, newdir might
18058 point at constant storage, so make it a const pointer.
fd4ead52 18059 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
18060 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
18061 signedness issues.
f839df0c
PE
18062 (Fset_file_times, Finsert_file_contents, auto_save_error):
18063 Rename locals to avoid shadowing.
f14b7e14 18064
5716756e 18065 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
18066 (Ftry_completion, Fall_completions): Rename or remove locals
18067 to avoid shadowing.
5716756e 18068
b4c3046a
PE
18069 * marker.c (bytepos_to_charpos): Remove; unused.
18070
b45db522
PE
18071 * lisp.h (verify_bytepos, count_markers): New decls,
18072 so that gcc does not warn that these functions aren't declared.
18073
85876d07
PE
18074 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
18075 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 18076 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 18077 (copy_text): Remove unused local var.
85876d07 18078
03d78a21 18079 * filelock.c (within_one_second): Now static.
b3dd38ab 18080 (lock_file_1): Rename local to avoid shadowing.
03d78a21 18081
5df8f01b
PE
18082 * buffer.c (fix_overlays_before): Mark locals as initialized.
18083 (fix_start_end_in_overlays): Likewise. This function should be
18084 simplified by using pointers-to-pointers, but that's a different
18085 matter.
b1d876f1 18086 (switch_to_buffer_1): Now static.
8f54f30a
PE
18087 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
18088 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 18089
a70072c9 18090 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 18091 Fix pointer signedness issue.
edced198
PE
18092 (sys_subshell): Mark local as volatile if checking for lint,
18093 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 18094 (MAXPATHLEN): Define only if needed.
a70072c9 18095
a0977c44
PE
18096 * process.c (serial_open, serial_configure): Move decls from here ...
18097 * systty.h: ... to here, so that they can be checked.
18098
a884fdcc
PE
18099 * fns.c (get_random, seed_random): Move extern decls from here ...
18100 * lisp.h: ... to here, so that they can be checked.
18101
604efe86 18102 * sysdep.c (reset_io): Now static.
b8950c94 18103 (wait_for_termination_signal): Remove; unused.
604efe86 18104
38fc62d9
PE
18105 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
18106 (copy_keymap_item, append_key, push_text_char_description):
18107 Now static.
1004a21a 18108 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 18109 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
18110 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
18111 (describe_map_tree):
18112 Rename locals to avoid shadowing.
38fc62d9 18113
2f2650da
PE
18114 * keyboard.c: Declare functions static if they are not used elsewhere.
18115 (echo_char, echo_dash, cmd_error, top_level_2):
18116 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
18117 (read_char, kbd_buffer_get_event, make_lispy_position):
18118 (make_lispy_event, make_lispy_movement, apply_modifiers):
18119 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
18120 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
18121 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 18122 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 18123 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 18124
a053e86c 18125 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
18126 (mark_kboards): Move decl here ...
18127 * alloc.c (mark_kboards): ... from here.
a053e86c 18128
4752793e
PE
18129 * lisp.h (force_auto_save_soon): New decl.
18130
74f10ca7 18131 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
18132 (DEFINE_DUMMY_FUNCTION): New macro.
18133 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
18134 Use it.
c03cd23f
PE
18135 (main): Add casts to avoid warnings
18136 if GCC considers string literals to be constants.
74f10ca7 18137
022e70d4
PE
18138 * lisp.h (fatal_error_signal): Add decl, since it's exported.
18139
59d6fe83
PE
18140 * dbusbind.c: Pointer signedness fixes.
18141 (xd_signature, xd_append_arg, xd_initialize):
18142 (Fdbus_call_method, Fdbus_call_method_asynchronously):
18143 (Fdbus_method_return_internal, Fdbus_method_error_internal):
18144 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
18145 (Fdbus_register_signal): Use SSDATA when the context wants char *.
18146
78320123
PE
18147 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
18148 if GCC considers string literals to be constants.
49cebcca 18149 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 18150
35ac2a97
SM
181512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
18152
fb103ca9
SM
18153 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
18154 (print_preprocess, print_object): New macro to fix last change.
18155
35ac2a97
SM
18156 * print.c (print_preprocess): Don't forget font objects.
18157
62973b41
JB
181582011-03-16 Juanma Barranquero <lekktu@gmail.com>
18159
18160 * emacs.c (USAGE3): Doc fixes.
18161
0e48bb22
AS
181622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
18163
18164 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
18165 structure.
18166
7684e57b
JB
181672011-03-14 Juanma Barranquero <lekktu@gmail.com>
18168
18169 * lisp.h (VWindow_system, Qfile_name_history):
18170 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
18171 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
18172 (w32_system_caret_x, w32_system_caret_y): Declare extern.
18173
18174 * w32select.c: Don't #include "keyboard.h".
c96bbc66 18175 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
18176
18177 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
18178 * w32console.c (detect_input_pending, read_input_pending)
18179 (encode_terminal_code):
18180 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
18181 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
18182 (w32_system_caret_y, Qfile_name_history):
18183 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
18184 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
18185 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
18186 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
18187 * w32proc.c (Qlocal, report_file_error):
18188 * w32term.c (Vwindow_system, updating_frame):
18189 * w32uniscribe.c (initialized, uniscribe_font_driver):
18190 Remove unneeded extern declarations.
18191
2aa46d6c
CY
181922011-03-14 Chong Yidong <cyd@stupidchicken.com>
18193
c96bbc66 18194 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 18195
cffc6f3b
CY
181962011-03-13 Chong Yidong <cyd@stupidchicken.com>
18197
18198 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
18199 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
18200 These macros can no longer be used for assignment.
18201
44f230aa
SM
18202 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
18203 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
18204 (record_buffer_markers, fetch_buffer_markers): New functions for
18205 recording and fetching special buffer markers.
18206 (set_buffer_internal_1, set_buffer_temp): Use them.
18207
18208 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
18209
18210 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
18211
18212 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
18213 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
18214
18215 * xdisp.c (hscroll_window_tree):
18216 (reconsider_clip_changes): Use PT instead of BUF_PT.
18217
d251f04b
EZ
182182011-03-13 Eli Zaretskii <eliz@gnu.org>
18219
18220 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18221 $(EMACS_ROOT)/lib/intprops.h.
18222
f0c77cd1
PE
182232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18224
3eca4629
PE
18225 Fix more problems found by GCC 4.5.2's static checks.
18226
7c86ee98
PE
18227 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18228 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18229 (xg_free_frame_widgets): Make it clear that a local variable is
18230 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18231 (gdk_window_get_screen): Make it clear that this macro is needed
18232 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18233 (int_gtk_range_get_value): New function, which avoids a diagnostic
18234 from gcc -Wbad-function-cast.
18235 (xg_set_toolkit_scroll_bar_thumb): Use it.
18236 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18237 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18238 (get_utf8_string, xg_get_file_with_chooser):
18239 Rename locals to avoid shadowing.
18240 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18241
41729b81
PE
18242 * xgselect.c (xg_select): Remove unused var.
18243
f0c77cd1
PE
18244 * image.c (four_corners_best): Mark locals as initialized.
18245 (gif_load): Initialize transparent_p to zero (Bug#8238).
18246 Mark another local as initialized.
ec6cf4c6 18247 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18248
ce0ad53d 18249 * image.c (clear_image_cache): Now static.
d5d5a617 18250 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18251 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18252 (x_edge_detection): Remove unnecessary cast that
18253 gcc -Wbad-function-cast diagnoses.
2037898d 18254 (gif_load): Fix pointer signedness.
6ae141d6
PE
18255 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18256 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18257
33383987 182582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18259
d32df629
PE
18260 Improve quality of tests for time stamp overflow.
18261 For example, without this patch (encode-time 0 0 0 1 1
18262 1152921504606846976) returns the obviously-bogus value (-948597
18263 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18264 reports time overflow. See
18265 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18266 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18267 * editfns.c: Include limits.h and intprops.h.
18268 (TIME_T_MIN, TIME_T_MAX): New macros.
18269 (time_overflow): Move earlier, to before first use.
18270 (hi_time, lo_time): New functions, for an accurate test for
18271 out-of-range times.
18272 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18273 (Fget_internal_run_time): Don't assume time_t fits in int.
18274 (make_time): Use list2 instead of Fcons twice.
18275 (Fdecode_time): More accurate test for out-of-range times.
18276 (check_tm_member): New function.
18277 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18278 (lisp_time_argument): Don't rely on undefined left-shift and
18279 right-shift behavior when checking for time stamp overflow.
8be6f318 18280
fe31d94c
PE
18281 * editfns.c (time_overflow): New function, refactoring common code.
18282 (Fformat_time_string, Fdecode_time, Fencode_time):
18283 (Fcurrent_time_string): Use it.
18284
8be6f318
PE
18285 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18286 * dired.c (make_time): Move to ...
18287 * editfns.c (make_time): ... here.
18288 * systime.h: Note the move.
18289
09d9db2c 182902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18291
126bc0dc
YM
18292 * fringe.c (update_window_fringes): Remove unused variables.
18293
c47cbdfd
YM
18294 * unexmacosx.c (copy_data_segment): Also copy __got section.
18295 (Bug#8223)
18296
7ac80be9
EZ
182972011-03-12 Eli Zaretskii <eliz@gnu.org>
18298
c96bbc66 18299 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18300 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18301 Constify `char *' arguments and their references according to
18302 prototypes in tparam.h.
18303
ecb0f94d 18304 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18305
7ac80be9
EZ
18306 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18307 Adapt all references accordingly.
18308
18309 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18310
ef1fd07e
TT
183112011-03-11 Tom Tromey <tromey@redhat.com>
18312
18313 * buffer.c (syms_of_buffer): Remove obsolete comment.
18314
7ef4b50c
EZ
183152011-03-11 Eli Zaretskii <eliz@gnu.org>
18316
18317 * termhooks.h (encode_terminal_code): Declare prototype.
18318
18319 * msdos.c (encode_terminal_code): Don't declare prototype.
18320
18321 * term.c (encode_terminal_code): Now external again, used by
18322 w32console.c and msdos.c.
18323
44f230aa
SM
18324 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18325 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18326
4b1ec863 183272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18328
1714f52b 18329 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18330
4b1ec863
PE
18331 * fringe.c (update_window_fringes): Mark locals as initialized
18332 (Bug#8227).
18333 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18334
524c7aa6
PE
18335 * alloc.c (mark_fringe_data): Move decl from here ...
18336 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18337 to check its interface.
18338 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18339
a5c0af81 18340 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18341 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18342 (fontset_font): Mark local as initialized.
a9a06e0b 18343 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18344
b4716021
PE
18345 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18346
811e9bac 18347 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18348 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18349 (x_own_selection, Fx_disown_selection_internal): Rename locals
18350 to avoid shadowing.
18351 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18352
7e3ab302
PE
18353 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18354 so that the caller can use some name other than gcpro1.
18355 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18356 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18357 (Fx_backspace_delete_keys_p):
18358 Use them to avoid shadowing, and rename vars to avoid shadowing.
18359 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18360 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18361 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18362 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18363 Remove unused locals.
7e3ab302
PE
18364 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18365 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18366 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18367 macros.
f78faa98 18368
e2b13473
PE
18369 * xterm.h (x_mouse_leave): New decl.
18370
77f23912
PE
18371 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18372 Remove unused functions.
cdf4ba58
PE
18373 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18374 (x_calc_absolute_position): Now static.
7411c686 18375 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18376 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18377 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18378 unless they are used.
38d0b34a
PE
18379 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18380 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18381 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18382 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18383 (x_error_catcher, x_connection_closed, x_error_handler):
18384 (x_error_quitter, xembed_send_message, x_iconify_frame):
18385 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18386 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18387 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18388
44f230aa
SM
18389 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18390 Rename or move locals to avoid shadowing.
6b463e58 18391 (tty_defined_color, merge_face_heights): Now static.
5967d051 18392 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18393 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18394 does not deduce is never used uninitialized.
73719eba
PE
18395 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18396 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18397
426994c3 18398 * terminal.c (store_terminal_param): Now static.
5489860b 18399
032f1620 18400 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18401 (set_frame_menubar): Remove unused local.
d4323972 18402 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18403 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18404 since they might point to immutable storage.
281585b0
PE
18405 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18406 since it's unused otherwise.
032f1620 18407
367c19e5 18408 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18409 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18410 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18411 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18412 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18413 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18414 does not deduce are never used uninitialized.
70739cbe 18415
07b48fa9
PE
18416 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18417
8868a238 18418 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18419 * window.c (window_loop, size_window):
18420 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18421
7e5cf297 18422 * window.c (display_buffer): Now static.
d6550a9f
PE
18423 (size_window): Mark variables that gcc -Wuninitialized
18424 does not deduce are never used uninitialized.
a586633d
PE
18425 * window.h (check_all_windows): New decl, to forestall
18426 gcc -Wmissing-prototypes diagnostic.
5b555da1 18427 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18428
f6095868
PE
18429 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18430 shadowing.
18431 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18432 Include <limits.h>.
18433 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18434 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18435 (load_charset_map): Mark variables that gcc -Wuninitialized
18436 does not deduce are never used uninitialized.
53df7c11 18437 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18438
f38b440c
PE
18439 * coding.c (coding_set_source, coding_set_destination):
18440 Use "else { /* comment */ }" rather than "else /* comment */;"
18441 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18442 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18443 a block, when the outer 'i' will do.
18444 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18445 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18446 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18447 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18448 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18449 Rename locals to avoid shadowing.
18450 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18451 * coding.c (emacs_mule_char, encode_invocation_designation):
18452 Now static, since they're not used elsewhere.
413bb2db 18453 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18454 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18455 (decode_coding_emacs_mule): Mark variables that gcc
18456 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18457 (detect_coding_iso_2022): Initialize a local variable that might
18458 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18459 this initialization is needed. (Bug#8211)
5f58e762
PE
18460 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18461 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18462 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18463 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18464 Remove unused macros.
f38b440c 18465
232b38b9 18466 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18467 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18468 * character.c (string_count_byte8): Likewise.
232b38b9 18469
fb90da1b
PE
18470 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18471 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18472
fb93dbc2
PE
18473 * chartab.c (copy_sub_char_table): Now static, since it's not used
18474 elsewhere.
5c156ace
PE
18475 (sub_char_table_ref_and_range, char_table_ref_and_range):
18476 Rename locals to avoid shadowing.
bbcd0949 18477 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18478
7d3b3862 18479 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18480 (BIDI_BOB): Remove unused macro.
7d3b3862 18481
6be7d3da
PE
18482 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18483 deduce are never used uninitialized.
c2ed9c8b 18484 * term.c (encode_terminal_code): Likewise.
6be7d3da 18485
75f8807f 18486 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18487
50938595
PE
18488 * tparam.h: New file.
18489 * term.c, tparam.h: Include it.
18490 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18491 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18492 Move these decls to tparam.h, and make them agree with what
18493 is actually in tparam.c. The previous trick of using incompatible
18494 decls in different modules does not conform to the C standard.
18495 All callers of tparam changed to use tparam's actual API.
18496 * tparam.c (tparam1, tparam, tgoto):
18497 Use const pointers where appropriate.
18498
fbceeba2
PE
18499 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18500 * cm.h (struct cm): Likewise.
18501 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18502 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18503 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18504 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18505 (turn_on_face, init_tty): Likewise.
18506 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18507
7f3f1250
PE
18508 * term.c (term_mouse_position): Rename local to avoid shadowing.
18509
e6ca6543
PE
18510 * alloc.c (mark_ttys): Move decl from here ...
18511 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18512
c40f8d15
AS
185132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18514
18515 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18516
cfe0661d
JB
185172011-03-09 Juanma Barranquero <lekktu@gmail.com>
18518
18519 * search.c (compile_pattern_1): Remove argument regp, unused since
18520 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18521 (compile_pattern): Don't pass it.
18522
0afb4571
J
185232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18524
18525 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18526 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18527 for ! HAVE_GTK3.
18528 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18529
18530 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18531
18532 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18533 gdk_window_get_screen, gdk_window_get_geometry,
18534 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18535 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18536 (xg_get_pixbuf_from_pixmap): New function.
18537 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18538 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18539 Call xg_get_pixbuf_from_pixmap instead of
18540 gdk_pixbuf_get_from_drawable.
18541 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18542 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18543 (xg_check_special_colors): Use GtkStyleContext and its functions
18544 for HAVE_GTK3.
18545 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18546 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18547 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18548 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18549 Call gtk_widget_get_preferred_size.
0afb4571
J
18550 (xg_frame_resized): gdk_window_get_geometry only takes 5
18551 parameters.
44f230aa
SM
18552 (xg_win_to_widget, xg_event_is_for_menubar):
18553 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18554 (xg_set_widget_bg): New function.
18555 (delete_cb): New function.
895009e1 18556 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18557 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18558 (xg_set_background_color): Call xg_set_widget_bg.
18559 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18560 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18561 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18562 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18563 if ! HAVE_GTK3.
18564 (update_frame_tool_bar): Call gtk_widget_hide.
18565 (xg_initialize): Use GDK_KEY_g.
18566
18567 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18568 if ! HAVE_GTK3
18569 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18570
18571 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18572 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18573 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18574
1c2cc4ef
JB
185752011-03-08 Juanma Barranquero <lekktu@gmail.com>
18576
18577 * w32xfns.c (select_palette): Check success of RealizePalette against
18578 GDI_ERROR, not zero.
18579
33383987 18580See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18581
18582;; Local Variables:
18583;; coding: utf-8
aac0c6e3
MR
18584;; End:
18585
2f097256 18586 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18587
18588 This file is part of GNU Emacs.
18589
18590 GNU Emacs is free software: you can redistribute it and/or modify
18591 it under the terms of the GNU General Public License as published by
18592 the Free Software Foundation, either version 3 of the License, or
18593 (at your option) any later version.
18594
18595 GNU Emacs is distributed in the hope that it will be useful,
18596 but WITHOUT ANY WARRANTY; without even the implied warranty of
18597 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18598 GNU General Public License for more details.
18599
18600 You should have received a copy of the GNU General Public License
18601 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.