Removed some unnecessary undef INTERRUPT_INPUTs from src/s
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8df9267
DA
12012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Minor adjustments to interning code.
4 * lisp.h (intern, intern_c_string): Redefine as static inline
5 wrappers for intern_1 and intern_c_string_1, respectively.
6 (intern_1, intern_c_string_1): Rename prototypes.
7 * lread.c (intern_1, intern_c_string_1): Simplify Vobarray checking.
8 * font.c (font_intern_prop): Likewise. Adjust comment.
9 * w32font.c (intern_font_name): Likewise.
10
34348bd4
AS
112012-07-11 Andreas Schwab <schwab@linux-m68k.org>
12
d96a1e0c
AS
13 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
14
34348bd4
AS
15 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
16 of Fcar/Fcdr if possible.
17 * font.c (check_otf_features): Likewise.
18 * fontset.c (Fnew_fontset): Likewise.
19 * gnutls.c (Fgnutls_boot): Likewise.
20 * minibuf.c (read_minibuf): Likewise.
21 * msdos.c (IT_set_frame_parameters): Likewise.
22 * xmenu.c (Fx_popup_dialog): Likewise.
23 * w32menu.c (Fx_popup_dialog): Likewise.
24
c8add24e
GM
252012-07-11 Glenn Morris <rgm@gnu.org>
26
4b575b3c
GM
27 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
28 since nothing has defined it on these platforms.
29
09f4e3b0
GM
30 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
31 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
32
172bedef
GM
33 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
34 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
35 Move CLASH_DETECTION to configure.
36
249685df
GM
37 * s/gnu.h: Remove file, which is now empty.
38
c8add24e
GM
39 * s/gnu.h, s/gnu-linux.h:
40 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
41
b41253a3
JW
422012-07-11 John Wiegley <johnw@newartisans.com>
43
44 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
45 function attribute, so we only use it if it exists in the
46 compiler.
47
d923b542
DA
482012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
49
50 Avoid call to strlen in fast_c_string_match_ignore_case.
51 * search.c (fast_c_string_match_ignore_case): Change to use
52 length argument. Adjust users accordingly.
53 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
54
5ebbef1d
PE
552012-07-11 Paul Eggert <eggert@cs.ucla.edu>
56
bb352260
PE
57 Assume mkdir, rmdir.
58 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
59 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
60
57054ddd
PE
61 Assume rename.
62 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
63
b747d3f7
PE
64 Assume perror.
65 * s/hpux10-20.h (HAVE_PERROR): Remove.
66 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
67 Remove dummy definition, as this problem was obsolete long ago.
68
5ebbef1d
PE
69 Assume strerror.
70 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
71
984e7f30
DA
722012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Avoid calls to strlen in font processing functions.
75 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 76 (font_open_by_name): Change to use length argument. Adjust
984e7f30 77 users accordingly.
d923b542
DA
78 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
79 Adjust prototypes.
80 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
81 Change to return ptrdiff_t.
984e7f30
DA
82 (xfont_list_pattern, xfont_match): Use length returned by
83 xfont_decode_coding_xlfd.
84 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
85
20e94fdd
GM
862012-07-11 Glenn Morris <rgm@gnu.org>
87
9d596af3
GM
88 * s/darwin.h, s/freebsd.h, s/netbsd.h:
89 Move DONT_REOPEN_PTY to configure.
90
20e94fdd
GM
91 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
92 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
93
e99a530f
PE
942012-07-10 Paul Eggert <eggert@cs.ucla.edu>
95
22ffb973
PE
96 Remove "#define unix" that is no longer needed (Bug#11905).
97 * s/aix4-2.h (unix): Remove; no longer needed.
98
e9a9ae03
PE
99 EMACS_TIME simplification (Bug#11875).
100 This replaces macros (which typically do not work in GDB)
101 with functions, typedefs and enums, making the code easier to debug.
102 The functional style also makes code easier to read and maintain.
103 * systime.h: Include <sys/time.h> on all hosts, not just if
104 WINDOWSNT, since 'struct timeval' is needed in general.
105 (EMACS_TIME): Now a typedef, not a macro.
106 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
107 not macros.
108 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
109 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
110 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
111 (EMACS_TIME_LE): Now functions, not macros.
112 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
113 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
114 which are not functions. All uses rewritten to use:
115 (make_emacs_time): New function.
116 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
117 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
118 not functions. All uses rewritten to use the following, respectively:
119 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
120 (add_emacs_time, sub_emacs_time): New functions.
121 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
122 * fileio.c (Fcopy_file):
123 * xterm.c (XTflash): Get the current time closer to when it's used.
124 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
125
ffacb126
PE
126 * bytecode.c (targets): Suppress -Woverride-init warnings.
127
e99a530f
PE
128 Simplify by avoiding confusing use of strncpy etc.
129 * doc.c (Fsnarf_documentation):
130 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
131 * frame.c (Fmake_terminal_frame):
132 * gtkutil.c (get_utf8_string):
133 * lread.c (openp):
134 * nsmenu.m (ns_update_menubar):
135 * regex.c (regerror):
136 Prefer memcpy to strncpy and strncat when either will do.
137 * fileio.c (Fsubstitute_in_file_name):
138 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
139 (menu_separator_name_p):
140 * nsmenu.m (ns_update_menubar):
141 Prefer memcmp to strncmp when either will do.
142 * nsterm.m: Include <ftoastr.h>.
143 (ns_get_color):
144 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
145 Prefer snprintf to strncpy.
146 * nsterm.m (ns_term_init):
147 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
148 * nsterm.m (ns_term_init):
149 Avoid the need for strncpy, by using build_string or
150 make_unibyte_string directly. Use dtoastr, not snprintf.
151 * process.c (Fmake_network_process): Diagnose service names that
152 are too long, rather than silently truncating them or creating
153 non-null-terminated names.
154 (Fnetwork_interface_info): Likewise, for interface names.
155 * sysdep.c (system_process_attributes) [GNU_LINUX]:
156 Prefer sprintf to strncat.
157 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
158 Prefer vsnprintf to vsprintf + strncpy.
159
c59592b3
GM
1602012-07-10 Glenn Morris <rgm@gnu.org>
161
162 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
163 Clarify fallback case.
164
7d7bbefd
DA
1652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
166
167 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
168 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
169 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 170 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
171 where argument type is known to be a Lisp_Cons.
172
3a4c8000
TT
1732012-07-10 Tom Tromey <tromey@redhat.com>
174
175 * bytecode.c (BYTE_CODE_THREADED): New macro.
176 (BYTE_CODES): New macro. Replaces all old byte-code defines.
177 (enum byte_code_op): New type.
178 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
179 (exec_byte_code): Use them. Use token threading when applicable.
180
2a0213a6
DA
1812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
182
183 Optimize pure C strings initialization.
184 * lisp.h (make_pure_string): Fix prototype.
185 (build_pure_c_string): New function, defined as static inline. This
186 provides a better opportunity to optimize away calls to strlen when
187 the function is called with compile-time constant argument.
188 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
189 argument, adjust users accordingly. Use build_pure_c_string where
190 appropriate.
191 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
192 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
193 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
194
cb1caeaf
DA
1952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
196
197 Avoid calls to strlen in miscellaneous functions.
198 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
199 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
200 * lread.c (openp): Likewise.
201
c293e30c
DA
2022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Avoid calls to strlen in path processing functions.
205 * fileio.c (file_name_as_directory): Add comment. Change to add
206 srclen argument and return the length of result. Adjust users
207 accordingly.
208 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 209 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
210 users accordingly.
211 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
212
9e059e3f
GM
2132012-07-10 Glenn Morris <rgm@gnu.org>
214
d02eb359
GM
215 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
216 Move PENDING_OUTPUT_COUNT definition to configure.
217
882cf227
GM
218 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
219 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
220 * s/gnu.h (DATA_START): Move definitions to configure.
221
af6e839f
GM
222 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
223 We include usg5-4-common.h, which defines them both.
224
40289a12
GM
225 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
226 O_RDONLY already includes it).
227
9e059e3f
GM
228 Stop ns builds setting the EMACSLOADPATH environment variable.
229 * nsterm.m (ns_load_path): Rename from ns_init_paths.
230 Now it does not set EMACSLOADPATH, just returns the load-path string.
231 * nsterm.h: Update accordingly.
232 * lread.c [HAVE_NS]: Include nsterm.h.
233 (init_lread) [HAVE_NS]: Use ns_load_path.
234 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
235
7c4e8ec0
GM
2362012-07-09 Glenn Morris <rgm@gnu.org>
237
d4f600ff
GM
238 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
239 since the included bsd-common.h does so.
240
cbb31951
GM
241 Stop ns builds setting the EMACSPATH environment variable.
242 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
243 (ns_init_paths): Do not set EMACSPATH.
244 * nsterm.h (ns_exec_path): Add it.
245 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
246 Use ns_exec_path.
247
7c4e8ec0
GM
248 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
249
26bccfae
PE
2502012-07-09 Paul Eggert <eggert@cs.ucla.edu>
251
a0bee46f
PE
252 * process.c (wait_reading_process_output): 'waitchannels' was unset
253 when read_kbd || !NILP (wait_for_cell); fix this.
254
5994c183
PE
255 Add GCC-style 'const' attribute to functions that can use it.
256 * character.h (char_resolve_modifier_mask):
257 * keyboard.h (make_ctrl_char):
258 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
259 (init_character_once, next_almost_prime, init_fns, init_image)
260 (flush_pending_output, init_sound):
261 * mem-limits.h (start_of_data):
262 * menu.h (finish_menu_items):
263 Add ATTRIBUTE_CONST.
264 * emacs.c (DEFINE_DUMMY_FUNCTION):
265 Declare the dummy function with ATTRIBUTE_CONST.
266 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
267 Add decls with ATTRIBUTE_CONST.
268
26bccfae
PE
269 Minor improvements to make_formatted_string.
270 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
271 where int is good enough, as vsprintf returns an int.
272 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
273
a8290ec3
DA
2742012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
275
276 Use make_formatted_string to avoid double length calculation.
277 * lisp.h (make_formatted_string): New prototype.
278 * alloc.c (make_formatted_string): New function.
279 * buffer.c (Fgenerate_new_buffer_name): Use it.
280 * dbus.c (syms_of_dbusbind): Likewise.
281 * editfns.c (Fcurrent_time_zone): Likewise.
282 * filelock.c (get_boot_time): Likewise.
283 * frame.c (make_terminal_frame, set_term_frame_name)
284 (x_report_frame_params): Likewise.
285 * image.c (gs_load): Likewise.
286 * minibuf.c (get_minibuffer): Likewise.
287 * msdos.c (dos_set_window_size): Likewise.
288 * process.c (make_process): Likewise.
289 * xdisp.c (ensure_echo_area_buffers): Likewise.
290 * xsettings.c (apply_xft_settings): Likewise.
291
d01ba2f1
GM
2922012-07-09 Glenn Morris <rgm@gnu.org>
293
294 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
295 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
296 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
297 * nsterm.h (ns_etc_directory): Add it.
298 * callproc.c [HAVE_NS]: Include nsterm.h.
299 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
300
f1f924b6
DA
3012012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
302
303 Move marker debugging code under MARKER_DEBUG.
304 * marker.c (MARKER_DEBUG): Move marker debugging code under
305 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
306 for bootstrap with --enable-checking (~3x slowdown reported
307 by Juanma Barranquero <lekktu@gmail.com>).
308 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
309
ab531b66
PE
3102012-07-08 Paul Eggert <eggert@cs.ucla.edu>
311
312 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
313 See <http://bugs.gnu.org/11825#29>.
314
c4b3bc8a
EZ
3152012-07-08 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
318 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
319 (display_line): Add commentary about displaying truncation glyphs
320 on GUI frames.
321 (produce_special_glyphs): Move here from term.c.
322
323 * term.c (produce_special_glyphs): Move to xdisp.c.
324
325 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
326 section.
c4b3bc8a 327
b676b881
AS
3282012-07-07 Andreas Schwab <schwab@linux-m68k.org>
329
f17c5273
AS
330 * xdisp.c (display_line): Avoid warning about implicit declaration
331 of FRAME_FONT.
332
298819b9
AS
333 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
334
b676b881
AS
335 * lisp.h: Remove empty conditional.
336
6045c4fd
PE
3372012-07-07 Paul Eggert <eggert@cs.ucla.edu>
338
b3350bf9
PE
339 * lread.c (load_path_check): Now static.
340
6045c4fd
PE
341 Fix some minor --with-ns problems found by static checking.
342 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
343 (x_set_font) [!HAVE_X_WINDOWS]:
344 * image.c (xpm_load_image) [HAVE_NS]:
345 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
346 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
347 Remove unused local.
348 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
349 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
350 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
351 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
352 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
353 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
354 Fix pointer signedness problem.
355 * xfaces.c (FRAME_X_FONT_TABLE):
356 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
357
929e7845
GM
3582012-07-07 Glenn Morris <rgm@gnu.org>
359
360 * lread.c (load_path_check): New function, split from init_lread.
361 (init_lread): Reorganize. Motivation:
362 If EMACSLOADPATH is set, check/warn about that rather than the
363 defaults, which we are not going to use. Hence we can remove
364 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
365 Don't warn if site-lisp directories are missing.
366 If not installed, start from a blank load-path, since
367 PATH_LOADSEARCH refers to the eventual installation directories.
368
58dd0aa4
EZ
3692012-07-07 Eli Zaretskii <eliz@gnu.org>
370
371 Support truncation and continuation glyphs on GUI frames, when
372 fringes are disabled. (Bug#11832)
373 * xdisp.c (init_iterator): Get dimensions of truncation and
374 continuation glyphs even if on GUI frames. Adjust
375 it->last_visible_x on GUI frames when the left or right fringes,
376 or both, are absent.
377 (start_display, move_it_in_display_line_to): Handle the case of a
378 GUI frame without a fringe to display continuation or truncation
379 glyphs.
380 (insert_left_trunc_glyphs): Support GUI frames: make sure
381 truncation glyphs overwrite enough glyphs from the current line to
382 have sufficient space in pixels.
383 (display_line): Support truncation and continuation glyphs on GUI
384 frames. If some spare pixels are left on the line after inserting
385 the truncation glyphs, fill that space with a stretch glyph of a
386 suitably computed width.
387
388 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
389 produce_glyphs, to support GUI sessions.
390
31571fd7
PE
3912012-07-07 Paul Eggert <eggert@cs.ucla.edu>
392
5a16b9bc
PE
393 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
394
f3047c75
PE
395 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
396
31571fd7
PE
397 Do not require float-time's arg to fit in time_t (Bug#11825).
398 This works better on hosts where time_t is unsigned, and where
399 float-time is applied to the (negative) difference between two times.
400 * editfns.c (decode_time_components): Last arg is now double *,
401 not int *, and means to store all the result as a double, without
402 worrying about whether the seconds part fits in time_t.
403 All callers changed.
404 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
405 All callers changed.
406 (Ffloat_time): Do not fail merely because the specified time falls
407 outside of time_t range.
408
4516fbef
GM
4092012-07-07 Glenn Morris <rgm@gnu.org>
410
411 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
412 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
413 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
414
07adc2c6
JB
4152012-07-07 Juanma Barranquero <lekktu@gmail.com>
416
417 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
418 Update dependencies.
419
420 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
421
fd573f31
PE
4222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
423
fee5959d
PE
424 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
425 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
426 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
427 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
428 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
429 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
430
fd573f31
PE
431 * xfont.c (compare_font_names): Redo to omit the need for casts.
432
ddadbc0e
AS
4332012-07-06 Andreas Schwab <schwab@linux-m68k.org>
434
fca8d6b6
AS
435 * xfns.c (Fx_change_window_property): Doc fix.
436 * w32fns.c (Fx_change_window_property): Doc fix.
437
ddadbc0e
AS
438 * w32fns.c (Fx_window_property): Accept the same arguments as the
439 X Windows version. Doc fix.
440 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
441
f247498e
JB
4422012-07-06 Juanma Barranquero <lekktu@gmail.com>
443 Eli Zaretskii <eliz@gnu.org>
444
445 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
446 Windows-specific code from nt/config.nt moved here.
447 Obsolete settings removed.
448
216ee680
PE
4492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
450
451 * process.c: Avoid unnecessary calls to gettime.
452 (wait_reading_process_output): Don't get the time of day
453 when gobbling data immediately and not waiting, as there's no need
454 for it in that case. This removes a FIXME.
455
bdd091e4
JD
4562012-07-06 Jan Djärv <jan.h.d@swipnet.se>
457
458 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
459 is defined (Bug#11768).
460
9d44f8ce
DA
4612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Fix marker debugging code.
464 * marker.c (byte_char_debug_check): Do not perform the check
465 if buffer is not multibyte.
090bd7cb
JB
466 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
467 Call byte_char_debug_check with correct arguments.
9d44f8ce 468
90fc4786
DA
4692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
472 * marker.c (byte_char_debug_check, count_markers):
473 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
474 (byte_debug_flag): Remove.
475 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
476 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
477
7b7ae965
DA
4782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
479
4e57b342
DA
480 Avoid code repetition in marker-related functions.
481 * marker.c (attach_marker): New function.
482 (Fset_marker, set_marker_restricted, set_marker_both)
483 (set_marker_restricted_both): Use it.
484 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
485 Consistently rename charno to charpos.
486 (marker_position): Add eassert.
487 (marker_byte_position): Convert to eassert.
488
4892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
490
491 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 492 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 493 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 494
657924ff
DA
4952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Introduce fast path for the widely used marker operation.
498 * alloc.c (build_marker): New function.
499 * lisp.h (build_marker): New prototype.
500 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
501 * composite.c (autocmp_chars): Likewise.
502 * editfns.c (buildmark): Remove.
503 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
504 (save_restriction_save): Use build_marker.
505 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
506 * window.c (save_window_save): Likewise.
507
041a49a6
DA
5082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
509
510 Do not use Fdelete_overlay in delete_all_overlays
511 to avoid redundant calls to unchain_overlay.
512 * buffer.c (drop_overlay): New function.
513 (delete_all_overlays, Fdelete_overlay): Use it.
514 * minibuf.c (get_minibuffer): Fix comment.
515
7dca65a4
PE
5162012-07-06 Paul Eggert <eggert@cs.ucla.edu>
517
518 Port to OpenBSD 5.1 amd64.
519 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
520 This is needed for OpenBSD, and should be harmless on all BSD systems.
521 Also, include <sys/sysctl.h>, as it should be available on all
522 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
523 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
524 use p_pid member, not kp_proc.pid.
525
8eb876e2
GM
5262012-07-06 Glenn Morris <rgm@gnu.org>
527
528 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
529
38182d90
PE
5302012-07-05 Paul Eggert <eggert@cs.ucla.edu>
531
532 More xmalloc and related cleanup.
533 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
534 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
535 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
536 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
537 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
538 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
539 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
540 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
541 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
542 * xterm.c:
543 Omit needless casts involving void * pointers and allocation.
544 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
545 as the former is more robust if P's type is changed.
546 Prefer xzalloc to xmalloc + memset 0.
547 Simplify malloc-or-realloc to realloc.
548 Don't worry about xmalloc returning a null pointer.
549 Prefer xstrdup to xmalloc + strcpy.
550 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
551 growing it.
552 * keyboard.c (apply_modifiers_uncached): Prefer local array to
553 alloca of a constant.
554
6dd5a677
EZ
5552012-07-05 Eli Zaretskii <eliz@gnu.org>
556
557 * xdisp.c (display_line): Fix horizontal pixel coordinates when
558 hscroll is larger than the line width. Fixes long and futile
559 looping inside extend_face_to_end_of_line (on a TTY) producing
560 glyphs that are not needed and thrown away.
561
6b312f0f
DA
5622012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
563
564 * marker.c (set_marker_restricted_both): Simplify by using
565 clip_to_bounds.
566
f520ef9b
PE
5672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
568
569 * editfns.c (region_limit): Simplify by using clip_to_bounds.
570
383b7c95
JD
5712012-07-05 Jan Djärv <jan.h.d@swipnet.se>
572
573 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
574 not defined (Bug#11768).
575 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
576 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
577 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
578 followed by gtk_box_set_homogeneous (Bug#11768).
579 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
580 (update_theme_scrollbar_width, xg_create_scroll_bar):
581 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
582 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
583 (is_box_type): New function (Bug#11768).
584 (xg_tool_item_stale_p): Call is_box_type.
5293d758 585 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
586 with default display (Bug#11768).
587
d6e7bf45
EZ
5882012-07-05 Eli Zaretskii <eliz@gnu.org>
589
590 * xdisp.c (window_hscroll_limited): New function.
591 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
592 coordinates when window's hscroll is set to insanely large
593 values. (Bug#11857)
594
431391ec
JB
5952012-07-05 Juanma Barranquero <lekktu@gmail.com>
596
597 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
598 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
599
23f86fce
DA
6002012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
601
602 Cleanup xmalloc.
603 * lisp.h (xzalloc): New prototype. Omit needless casts.
604 * alloc.c (xzalloc): New function. Omit needless casts.
605 * charset.c: Omit needless casts. Convert all calls to
606 xmalloc with following memset to xzalloc.
607 * dispnew.c: Likewise.
608 * fringe.c: Likewise.
609 * image.c: Likewise.
610 * sound.c: Likewise.
611 * term.c: Likewise.
612 * w32fns.c: Likewise.
613 * w32font.c: Likewise.
614 * w32term.c: Likewise.
615 * xfaces.c: Likewise.
616 * xfns.c: Likewise.
617 * xterm.c: Likewise.
618 * atimer.c: Omit needless casts.
619 * buffer.c: Likewise.
620 * callproc.c: Likewise.
621 * ccl.c: Likewise.
622 * coding.c: Likewise.
623 * composite.c: Likewise.
624 * doc.c: Likewise.
625 * doprnt.c: Likewise.
626 * editfns.c: Likewise.
627 * emacs.c: Likewise.
628 * eval.c: Likewise.
629 * filelock.c: Likewise.
630 * fns.c: Likewise.
631 * gtkutil.c: Likewise.
632 * keyboard.c: Likewise.
633 * lisp.h: Likewise.
634 * lread.c: Likewise.
635 * minibuf.c: Likewise.
636 * msdos.c: Likewise.
637 * print.c: Likewise.
638 * process.c: Likewise.
639 * region-cache.c: Likewise.
640 * search.c: Likewise.
641 * sysdep.c: Likewise.
642 * termcap.c: Likewise.
643 * terminal.c: Likewise.
644 * tparam.c: Likewise.
645 * w16select.c: Likewise.
646 * w32.c: Likewise.
647 * w32reg.c: Likewise.
648 * w32select.c: Likewise.
649 * w32uniscribe.c: Likewise.
650 * widget.c: Likewise.
651 * xdisp.c: Likewise.
652 * xmenu.c: Likewise.
653 * xrdb.c: Likewise.
654 * xselect.c: Likewise.
655
0497dc44
PE
6562012-07-05 Paul Eggert <eggert@cs.ucla.edu>
657
658 * fileio.c (time_error_value): Check the right error number.
659 Problem reported by Troels Nielsen in
660 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
661
356e7178
PE
6622012-07-04 Paul Eggert <eggert@cs.ucla.edu>
663
4e71fd89
PE
664 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
665 This should be fixed in a better way; see Eli Zaretskii in
666 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
667 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
668
f0941253
PE
669 * fileio.c (time_error_value): Rename from special_mtime.
670 The old name's problems were noted by Eli Zaretskii in
671 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
672
065c9eb4
PE
673 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
674 This variable's comment says Emacs needs at least one GDB-visible
675 symbol of type enum pvec_type, to work around GDB problems.
676 The symbol's value doesn't matter.
677
356e7178
PE
678 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
679 that causes compilation to fail on pre-C99 compilers.
680
95f61aa2
JB
6812012-07-04 Juanma Barranquero <lekktu@gmail.com>
682
683 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
684 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
685
3884d954
DA
6862012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
687
d209e2fb 688 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
689 headers for buffer_defaults and buffer_local_symbols.
690 Reported by Juanma Barranquero <lekktu@gmail.com>.
691
ee28be33
SM
6922012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
695 * lisp.h (enum pvec_type): Use fewer bits.
696 (PSEUDOVECTOR_SIZE_BITS): New constant.
697 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
698 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
699 change in pvec_type.
700 (PSEUDOVECTOR_TYPEP): New macro.
701 (TYPED_PSEUDOVECTORP): Use it.
702 * fns.c (internal_equal): Adapt code to extract pvectype.
703 * emacs.c (gdb_pvec_type): Update type.
704 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
705 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
706 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
707 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
708 (sweep_vectors): Use it. Use local var `total_bytes' instead of
709 abusing vector->header.next.nbytes.
710 (live_vector_p): Use PVEC_TYPE.
711 (mark_object): Adapt code to extract pvectype. Use switch.
712
c7f2cd7f
PE
7132012-07-04 Paul Eggert <eggert@cs.ucla.edu>
714
715 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
716 Tighten new eassert a bit.
717
8ce70ed2
DA
7182012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
719
720 Fix compilation with --enable-gcc-warnings and -O1
721 optimization level.
722 * doprnt.c (doprnt): Change type of tem to int, initialize
723 to avoid compiler warning. Add eassert.
724 * search.c (simple_search): Initialize match_byte to avoid
725 compiler warning. Add eassert.
726
dea7f1e5
PE
7272012-07-04 Paul Eggert <eggert@cs.ucla.edu>
728
24a212eb
PE
729 Avoid weird behavior with large horizontal scrolls.
730 Without this change, for example, large hscroll values would
731 mess up Emacs's display on Fedora 15 x86, presumably due to
732 overflows in int calculations in the display code.
733 Also, if buffers had long lines, Emacs would freeze.
734 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
735 (set_window_hscroll): New function, containing the old guts of
736 Fset_window_hscroll. Return the clipped value.
737 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
738 This avoids the need to check against PTRDIFF_MAX.
739
dea7f1e5
PE
740 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
741
76046526
DA
7422012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
743
744 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
745
39adff0d
PE
7462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
747
63807d47
PE
748 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
749 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
750 since GCC 4.4.6 issues a bogus warning for them.
751
39adff0d
PE
752 Fix bugs in file timestamp newness comparisons.
753 * fileio.c (Ffile_newer_than_file_p):
754 * lread.c (Fload): Use full timestamp resolution of files,
755 not just the 1-second resolution, so that files that are only
756 slightly newer still count as newer.
757 * fileio.c (Ffile_newer_than_file_p): Don't assume file
758 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
759
dbeed9a6
PE
7602012-07-03 Paul Eggert <eggert@cs.ucla.edu>
761
762 * fileio.c: Improve handling of file time marker. (Bug#11852)
763 (special_mtime): New function.
764 (Finsert_file_contents, Fverify_visited_file_modtime):
765 Use it to set special mtime values consistently.
766
636334d6
AS
7672012-07-03 Andreas Schwab <schwab@linux-m68k.org>
768
769 * fileio.c (Finsert_file_contents): Properly handle st_mtime
770 marker for non-existing file. (Bug#11852)
771
e2017fe2
GM
7722012-07-03 Glenn Morris <rgm@gnu.org>
773
774 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
775 and did not make it into globals.h).
776
404dbd37
TT
7772012-07-03 Tom Tromey <tromey@redhat.com>
778
779 * window.c (Fset_window_margins, Fset_window_fringes)
780 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
781 * textprop.c (Fprevious_property_change): No longer static.
782 * syntax.c (Fsyntax_table_p): No longer static.
783 * process.c (Fget_process, Fprocess_datagram_address): No longer
784 static.
785 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
786 * keyboard.c (Fcommand_execute): No longer static.
787 Remove EXFUN.
788 * insdel.c (Fcombine_after_change_execute): No longer static.
789 * image.c (Finit_image_library): No longer static.
790 * fileio.c (Fmake_symbolic_link): No longer static.
791 * eval.c (Ffetch_bytecode): No longer static.
792 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
793 * doc.c (Fdocumentation_property, Fsnarf_documentation):
794 No longer static.
404dbd37
TT
795 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
796 static.
797 * dired.c (Ffile_attributes): No longer static.
798 * composite.c (Fcomposition_get_gstring): No longer static.
799 * callproc.c (Fgetenv_internal): No longer static.
800
801 * ccl.h: Remove EXFUNs.
802 * buffer.h: Remove EXFUNs.
803 * dispextern.h: Remove EXFUNs.
804 * intervals.h: Remove EXFUNs.
805 * fontset.h: Remove EXFUN.
806 * font.h: Remove EXFUNs.
807 * dosfns.c (system_process_attributes): Remove EXFUN.
808 * keymap.h: Remove EXFUNs.
809 * lisp.h: Remove EXFUNs.
810 * w32term.h: Remove EXFUNs.
811 * window.h: Remove EXFUNs.
812 * xsettings.h: Remove EXFUN.
813 * xterm.h: Remove EXFUN.
814
8e4fd1e1
GM
8152012-07-03 Glenn Morris <rgm@gnu.org>
816
817 * lisp.h (Frandom): Make it visible to C.
818 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
819 buffer for invisible buffers. (Bug#1229)
820
ca95b3eb
DA
8212012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
822
823 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
824 values which aren't power of 2.
825 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
826 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
827 accordingly.
828
7555c33f
SM
8292012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
830
831 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
832
833 * alloc.c (mark_object): Revert part of last patch to use `switch'.
834
d12e8f5a
DA
8352012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
836
837 * alloc.c (allocate_vector_block): Remove redundant
838 calls to mallopt if DOUG_LEA_MALLOC is defined.
839 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
840 avoid calls to mallopt if zero_vector is returned.
841
296094c3
DA
8422012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
843
844 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
845 is enabled, avoid dereferencing NULL current_sblock if
846 running undumped.
847
36429c89
DA
8482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
849
850 Cleanup basic buffer management.
851 * buffer.h (struct buffer): Change layout to use generic vector
852 marking code. Fix some comments. Change type of 'clip_changed'
853 to bitfield. Remove unused #ifndef old.
854 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
855 (GET_OVERLAYS_AT): Fix indentation.
856 (for_each_per_buffer_object_at): New macro.
857 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
858 (Fbuffer_local_variables): Use it.
859 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
860 * alloc.c (allocate_buffer): Adjust to match new layout of
861 struct buffer. Fix comment.
862 (mark_overlay): New function.
863 (mark_buffer): Use it. Use mark_vectorlike to mark normal
864 Lisp area of struct buffer.
865 (mark_object): Use it. Adjust marking of misc objects
866 and related comments.
867
3b3e4cac
PE
8682012-07-02 Paul Eggert <eggert@cs.ucla.edu>
869
870 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
871 wrapper that is not needed because the wrapped code is a no-op (zero
872 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
873 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
874
cf5c0175
DA
8752012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
876
877 * alloc.c (mark_buffer): Simplify. Remove prototype.
878 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 879 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
880 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
881 redundant calls to mark_vectorlike for bool vectors.
882
ca26824c
GM
8832012-06-30 Glenn Morris <rgm@gnu.org>
884
2e4c5312
GM
885 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
886
ca26824c
GM
887 * epaths.in (PATH_SITELOADSEARCH): New.
888 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
889 This is rather than relying on --enable-locallisppath elements
890 having "site-lisp" in their names. (Bug#10208#25, 11658)
891
0d23c240
EZ
8922012-06-30 Eli Zaretskii <eliz@gnu.org>
893
c9240d7a
EZ
894 * w32proc.c (sys_select): Accept and ignore one more argument.
895
896 * w32.c (emacs_gnutls_pull): Call select with one more argument.
897
0d23c240 898 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 899 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
900
901 * sysdep.c: Don't include dos.h and dosfns.h.
902
903 * process.c (sys_select):
904 * msdos.c (sys_select): Accept one more argument and ignore it.
905
906 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
907 adapt data types and code to that.
908
909 * dosfns.c:
910 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
911 which clashes with the gnulib function of the same name.
912
af5a5a98
AS
9132012-06-30 Andreas Schwab <schwab@linux-m68k.org>
914
c5e4379c
AS
915 * font.c (font_style_to_value, font_style_symbolic)
916 (font_prop_validate_style): Add type checks for values in
917 font_style_table.
918
af5a5a98
AS
919 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
920 argument.
921 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
922 uses.
923
8d38f461
EZ
9242012-06-29 Eli Zaretskii <eliz@gnu.org>
925
2e5a6631
EZ
926 * xdisp.c (try_window_id): Undo last change.
927
8d38f461
EZ
928 * w32.c (getwd): Adjust commentary about startup_dir.
929 (init_environment): Always call sys_access, even in non-MSVC
930 builds. Don't chdir to the directory of the Emacs executable.
931 This undoes code from 1997 which was justified by the need to
932 "avoid conflicts when removing and renaming directories". But its
933 downside was that every relative file name was being interpreted
934 relative to the directory of the Emacs executable, which can never
935 be TRT. In particular, it broke sys_access when called with
936 relative file names.
937 (sys_access): Map GetLastError to errno.
938
2af3565e
DA
9392012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * window.h (struct window): Change type of 'fringes_outside_margins'
942 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 943 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
944 Adjust comment.
945 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
946 to ptrdiff_t.
947
c8d3a25c 9482012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 949
c8d3a25c
GM
950 * gnutls.c (emacs_gnutls_handshake):
951 Add QUIT to make the loop interruptible.
57570cd3 952
c8d3a25c 9532012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 954
c8d3a25c
GM
955 * charset.c (init_charset): Make lack of etc/charsets fatal.
956
3e984ee8
DA
9572012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
958
959 * editfns.c (region_limit): Fix type mismatch.
960
ef884f23
DA
9612012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
962
963 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
964 undefined. Convert from xassert to eassert.
965 * nsmenu.m: Convert from xassert to eassert.
966 * nsterm.m: Likewise.
967
7d7e0027
SM
9682012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
969
970 * editfns.c (region_limit): Clip to narrowing (bug#11770).
971
aa754e6a
PE
9722012-06-28 Paul Eggert <eggert@cs.ucla.edu>
973
974 Avoid integer overflow on scroll-left and scroll-right.
975 * window.c (HSCROLL_MAX): New macro.
976 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
977 overflow when requested scroll falls outside ptrdiff_t range.
978
80b00b08
DA
9792012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
980
981 * window.h (struct window): Change type of 'hscroll',
982 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
983 'last_modified' and 'last_overlay_modified' to EMACS_INT.
984 Adjust users accordingly.
985 * xdisp.c (try_cursor_movement): Replace type check with eassert.
986 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
987 from EMACS_INT to ptrdiff_t.
988 (make_window): Omit redundant initialization.
989
62b2bcf6
JB
9902012-06-28 Juanma Barranquero <lekktu@gmail.com>
991
992 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
993
45942c7d
DA
9942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * window.h (struct window): Change type of 'use_time' and
997 'sequence_number' from Lisp_Object to int.
998 * frame.c (make_frame): Adjust users accordingly.
999 * print.c (print_object): Likewise.
1000 * window.c (select_window, Fwindow_use_time, make_parent_window)
1001 (make_window): Likewise.
1002
e509cfa6
DA
10032012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1006 enabled with --enable-checking=[all,glyphs] configure option.
1007 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1008 adjust comments accordingly.
1009 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1010 undefined, adjust comments accordingly.
1011 * image.c: Likewise.
1012 * scroll.c: Likewise.
1013 * w32fns.c: Likewise.
1014 * w32term.c: Likewise.
1015 * xdisp.c: Likewise.
1016 * xfaces.c: Likewise.
1017 * xfns.c: Likewise.
1018 * xterm.c: Likewise.
1019
a54e2c05
DA
10202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 Generalize run-time debugging checks.
1023 * dispextern.h (XASSERTS): Remove.
1024 * fontset.c (xassert): Remove.
1025 Convert from xassert to eassert.
1026 * alloc.c: Convert from xassert to eassert.
1027 * bidi.c: Likewise.
1028 * dispnew.c: Likewise.
1029 * fns.c: Likewise.
1030 * fringe.c: Likewise.
1031 * ftfont.c: Likewise.
1032 * gtkutil.c: Likewise.
1033 * image.c: Likewise.
1034 * keyboard.c: Likewise.
1035 * menu.c: Likewise.
1036 * process.c: Likewise.
1037 * scroll.c: Likewise.
1038 * sound.c: Likewise.
1039 * term.c: Likewise.
1040 * w32console.c: Likewise.
1041 * w32fns.c: Likewise.
1042 * w32term.c: Likewise.
1043 * window.c: Likewise.
1044 * xdisp.c: Likewise.
1045 * xfaces.c: Likewise.
1046 * xfns.c: Likewise.
1047 * xselect.c: Likewise.
1048 * xterm.c: Likewise.
1049
1ec4b7b2
SM
10502012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1051
1052 * fns.c (maybe_resize_hash_table): Output message when growing the
1053 purify-hashtable.
1054
2014308a
DA
10552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 * alloc.c (allocate_string_data): Remove dead code.
1058 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1059 avoid GCC warning about unused macro.
1060
246155eb
DA
10612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 * alloc.c (allocate_string): Omit intervals initialization.
1064 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1065 as in make_pure_string and make_pure_c_string.
1066
43184b7b
DA
10672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1068
d209e2fb 1069 * alloc.c (allocate_string): Fix last change.
43184b7b 1070
3fe6dd74
DA
10712012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1072
d209e2fb 1073 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1074 to memset, add explicit initialization where appropriate.
1075
1ba6038a
GM
10762012-06-27 Glenn Morris <rgm@gnu.org>
1077
1078 * lisp.mk (lisp): Remove paths.elc.
1079
c89926a5
CY
10802012-06-27 Chong Yidong <cyd@gnu.org>
1081
1082 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1083
ed6b3510
JW
10842012-06-26 John Wiegley <johnw@newartisans.com>
1085
1ec4b7b2 1086 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1087 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1088
ed6b3510
JW
1089 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1090 when building with Clang.
1091
8edd4a2b
SM
10922012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1093
1094 * eval.c (Fapply): Allow calling it with a single argument.
1095
f6f62d1b
EZ
10962012-06-26 Eli Zaretskii <eliz@gnu.org>
1097
1098 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1099 _stricmp and _strnicmp.
1100 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1101
62efea5e
DA
11022012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1105 allocated window.
1106 (allocate_process): Likewise for new process.
8edd4a2b 1107 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1108 (allocate_frame): Likewise.
1109 * frame.c (make_frame): Omit redundant initialization.
1110 * window.c (make_parent_window): Use memset.
1111 (make_window): Omit redundant initialization.
1112 * process.c (make_process): Omit redundant initialization.
1113 * terminal.c (create_terminal): Likewise.
1114
42997f4d
DA
11152012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1116
1117 * term.c (delete_tty): Remove redundant call to memset.
1118
1130ecfc
DA
11192012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 * alloc.c: Remove build_string.
1122 * lisp.h: Define build_string as static inline. This provides
1123 a better opportunity to optimize away calls to strlen when the
1124 function is called with compile-time constant argument.
1125 * image.c (imagemagick_error): Convert to build_string.
1126 * w32proc.c (sys_spawnve): Likewise.
1127 * xterm.c (x_term_init): Likewise.
1128
cf38a720
PE
11292012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1130
99027bdd
PE
1131 Use sprintf return value instead of invoking strlen on result.
1132 In the old days this wasn't portable, since some sprintf
1133 implementations returned char *. But they died out years ago and
1134 Emacs already assumes sprintf returns int.
1135 Similarly for float_to_string.
1136 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1137 * ccl.c (ccl_driver):
1138 * character.c (string_escape_byte8):
1139 * data.c (Fnumber_to_string):
1140 * doprnt.c (doprnt):
1141 * print.c (print_object):
1142 * xdisp.c (message_dolog):
1143 * xfns.c (syms_of_xfns):
1144 Use sprintf or float_to_string result to avoid need to call strlen.
1145 * data.c (Fnumber_to_string):
1146 Use make_unibyte_string, since the string must be ASCII.
1147 * lisp.h, print.c (float_to_string): Now returns int length.
1148 * term.c (produce_glyphless_glyph):
1149 Use sprintf result rather than recomputing it.
1150
cf38a720
PE
1151 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1152 * Makefile.in (ALL_CFLAGS):
1153 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1154 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1155
3511c784
DA
11562012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1157
0a08eb21 1158 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1159 strcasecmp if available.
1160 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1161
fb7da12e
AS
11622012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1165 Avoid comma operator.
1166 * menu.c (push_submenu_start, push_submenu_end)
1167 (push_left_right_boundary, push_menu_pane): Likewise.
1168 * msdos.c (dos_rawgetc): Likewise.
1169
afa2ffd8
DA
11702012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 * xfns.c (xic_create_fontsetname): Remove redundant calls
1173 to memset.
1174
b3b4476b
PE
11752012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1176
4495ff38
PE
1177 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1178 sprintf already null-terminates its output.
1179
b3b4476b
PE
1180 * xfns.c (x_window): Remove redundant cast.
1181
b00876c9
DA
11822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1185 `const char *' to `char *' to avoid compiler warning.
1186
d188e26b
PE
11872012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1188
885d1d74
PE
1189 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1190 instead of truncating it to 63 (admittedly a generous limit).
1191
d188e26b
PE
1192 * process.c: Fix spelling and caps in comments.
1193
e2f560b1
DN
11942012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1195
e86db54b 1196 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1197 * sysdep.c (setpgrp): Remove definition, not used in this file.
1198
7583a3a1
JB
11992012-06-24 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * makefile.w32-in: Update dependencies.
1202
696056c2
EZ
12032012-06-24 Eli Zaretskii <eliz@gnu.org>
1204
1205 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1206 (SYSTIME_H): Add nt/inc/sys/time.h.
1207
1208 * systime.h [WINDOWSNT]: Include sys/time.h.
1209
1210 * s/ms-w32.h (struct timespec): Definition moved from
1211 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1212
845ca893
PE
12132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1216 * buffer.h (buffer_slot_type_mismatch):
1217 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1218 * eval.c (unwind_to_catch):
1219 * image.c (my_png_error, my_error_exit):
1220 * keyboard.c (quit_throw_to_read_char, user_error)
1221 (Fexit_recursive_edit, Fabort_recursive_edit):
1222 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1223 (wrong_type_argument, buffer_overflow, __executable_start)
1224 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1225 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1226 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1227 (fatal):
1228 (child_setup) [!DOS_NT]:
1229 * lread.c (end_of_file_error, invalid_syntax):
1230 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1231 * puresize.h (pure_write_error):
1232 * search.c (matcher_overflow):
1233 * sound.c (sound_perror, alsa_sound_perror):
1234 * sysdep.c, syssignal.h (croak):
1235 * term.c (maybe_fatal, vfatal):
1236 * textprop.c (text_read_only):
1237 * undo.c (user_error):
1238 * unexmacosx.c (unexec_error):
1239 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1240 Use _Noreturn rather than NO_RETURN.
1241 No need for separate decl merely because of _Noreturn.
1242 * sound.c (sound_warning, parse_sound):
1243 Remove unnecessary forward decls.
1244
f1dd8073
PE
12452012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1248 * lisp.h (WAIT_READING_MAX): New macro.
1249 * dispnew.c (Fsleep_for, sit_for):
1250 * keyboard.c (kbd_buffer_get_event):
1251 * process.c (Faccept_process_output):
1252 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1253 This improves on the previous patch, which introduced a bug
1254 when time_t is unsigned and as wide as intmax_t.
1255 See <http://bugs.gnu.org/9000#51>.
1256
b82c1755
EZ
12572012-06-23 Eli Zaretskii <eliz@gnu.org>
1258
1259 * dispnew.c (sit_for, Fsleep_for):
1260 * keyboard.c (kbd_buffer_get_event):
1261 * process.c (Faccept_process_output): Avoid compiler warnings when
1262 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1263
ca300656
JB
12642012-06-23 Juanma Barranquero <lekktu@gmail.com>
1265
049ec95b
JB
1266 * makefile.w32-in: Update dependencies.
1267
ca300656
JB
1268 * w32.c (ltime): Add return type and declare static.
1269 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1270
db7b8d06
PE
12712012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1274 Privately reported by Herbert J. Skuhra.
1275 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1276 All uses changed.
1277 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1278 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1279
0bd8297f
EZ
12802012-06-23 Eli Zaretskii <eliz@gnu.org>
1281
96512555
EZ
1282 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1283 last argument of make_unibyte_string.
1284
0bd8297f
EZ
1285 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1286 language ID in the event parameters.
1287
1288 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1289 event.code, not the obscure "character set ID".
1290
63def6b6
CY
12912012-06-23 Chong Yidong <cyd@gnu.org>
1292
1293 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1294
e8a02204
EZ
12952012-06-23 Eli Zaretskii <eliz@gnu.org>
1296
388cdec0
EZ
1297 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1298 * w32.c (fdutimens): New function.
1299
1300 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1301
1302 * s/ms-w32.h (pselect): Redirect to sys_select.
1303
1304 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1305
e8a02204
EZ
1306 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1307 in the logic of incrementing and decrementing the value of
1308 use_relocatable_buffers.
1309
d054f3fb
PE
13102012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1313 Privately reported by Herbert J. Skuhra.
1314 [__FreeBSD__]: Remove "*/" typo after "#include".
1315 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1316 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1317 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1318 Don't assume EMACS_TIME and struct timeval are the same type.
1319
d35af63c
PE
13202012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 Support higher-resolution time stamps (Bug#9000).
1323 The time stamps are only nanosecond-resolution at the C level,
1324 since that's the best that any real-world system supports now.
1325 But they are picosecond-resolution at the Lisp level, as that's
1326 easy, and leaves room for future OS improvements.
1327
1328 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1329 (LIBES): Use it.
1330
1331 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1332 Don't get current time unless it's needed.
1333
1334 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1335 now provides it if it's absent.
1336 (start_atimer): Port to higher-res time stamps.
1337 Check for time stamp overflow. Don't get current time more
1338 often than is needed.
1339
1340 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1341 Include systime.h, not time.h.
1342 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1343
1344 * dired.c: Include stat-time.h.
1345 (Ffile-attributes): File times now have higher resolution.
1346
1347 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1348 (struct image): Timestamp now has higher resolution.
1349
1350 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1351 has at least microseconds now. All uses removed.
1352 (update_frame, update_single_window, update_window, update_frame_1)
1353 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1354
1355 * editfns.c (time_overflow): Now extern.
1356 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1357 (float-time, Fformat_time_string, Fcurrent_time_string)
1358 (Fcurrent_time_zone): Accept and generate higher-resolution
1359 time stamps.
1360 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1361 (decode_time_components, lisp_seconds_argument): New functions.
1362 (make_time): Now static.
1363 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1364 Report an error if the time is invalid, rather than having the caller
1365 do that.
1366
1367 * fileio.c: Include <stat-time.h>
1368 (Fcopy_file): Copy higher-resolution time stamps.
1369 Prefer to set the time stamp via a file descriptor if that works.
1370 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1371 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1372 (Fvisited_file_modtime, Fset_visited_file_modtime):
1373 Support higher-resolution time stamps.
1374
1375 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1376
1377 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1378
1379 * image.c (prepare_image_for_display, clear_image_cache)
1380 (lookup_image): Port to higer-resolution time stamps.
1381
1382 * keyboard.c (start_polling, bind_polling_period):
1383 Check for time stamp overflow.
1384 (read_char, kbd_buffer_get_event, timer_start_idle)
1385 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1386 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1387 Port to higher-resolution time stamps. Do not assume time_t is signed.
1388 (decode_timer): New function. Timers are now vectors of length 9,
1389 not 8, to accommodate the picosecond component.
1390 (timer_check_2): Use it.
1391
1392 * nsterm.m (select_timeout, timeval_subtract): Remove.
1393 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1394 as they're a bit more accurate and handle overflow better.
1395 (ns_select): Change prototype to be compatible with pselect.
1396 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1397 * nsterm.h (ns_select): Adjust prototype.
1398
1399 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1400 us-resolution time stamps.
1401 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1402
1403 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1404
1405 * lisp.h (time_overflow): New decl.
1406 (wait_reading_process_output): First arg is now intmax_t, not int,
1407 to accommodate larger waits.
1408
1409 * process.h (struct Lisp_Process.read_output_delay):
1410 Now counts nanoseconds, not microseconds.
1411 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1412 EMACS_HAS_USECS.
1413 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1414 (wait_reading_process_output):
1415 Port to ns-resolution time stamps.
1416 (Faccept_process_output, wait_reading_process_output):
1417 Check for time stamp overflow. Do not assume time_t is signed.
1418 (select_wrapper): Remove; we now use pselect.
1419 (Fprocess_attributes): Now generates ns-resolution time stamps.
1420
1421 * sysdep.c: Include utimens.h. Don't include utime.h
1422 or worry about struct utimbuf; gnulib does that for us now.
1423 (gettimeofday): Remove; gnulib provides a substitute.
1424 (make_timeval): New function.
1425 (set_file_times): Now sets ns-resolution time stamps.
1426 New arg FD; all uses changed.
1427 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1428 (system_process_attributes):
1429 Now returns ns-resolution time stamp. All uses changed.
1430 Check for time stamp overflow.
1431
1432 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1433 provides a substitute now.
1434
1435 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1436 since it guarantees struct timespec.
1437 (EMACS_TIME): Now struct timespec, so that we can support
1438 ns-resolution time stamps.
1439 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1440 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1441 (EMACS_USECS): Remove.
1442 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1443 so multiply the arg by 1000 before storing it.
1444 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1445 New macros.
1446 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1447 Port to ns-resolution time stamps.
1448 (EMACS_TIME_NEG_P): Remove; replaced by....
1449 (EMACS_TIME_SIGN): New macro.
1450 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1451 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1452 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1453 (make_timeval, make_lisp_time, decode_time_components): New decls.
1454 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1455 that it mishandled time_t overflow. You can't compare by subtracting!
1456 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1457 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1458
1459 * term.c: Include <sys/time.h>.
1460 (timeval_to_Time): New function, for proper overflow wraparound.
1461 (term_mouse_position, term_mouse_click): Use it.
1462
1463 * undo.c (record_first_change): Support higher-resolution time stamps
1464 in the undo buffer.
1465 (Fprimitive_undo): Use them when restoring time stamps.
1466
1467 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1468 (w32_get_internal_run_time):
1469 Port to higher-resolution Emacs time stamps.
1470 (ltime): Now accepts single 64-bit integer, as that's more convenient
1471 for callers.
1472
1473 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1474
1475 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1476 for compatibility with pselect. Support ns-resolution time stamps.
1477
1478 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1479
1480 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1481 Check for time stamp overflow, and support ns-resolution time stamps.
1482
1483 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1484 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1485 (timeval_subtract): Remove; no longer needed.
1486 (XTflash, XTring_bell, x_wait_for_event):
1487 Port to ns-resolution time stamps. Don't assume time_t is signed.
1488
b6a92dfe
CY
14892012-06-22 Chong Yidong <cyd@gnu.org>
1490
1491 * xdisp.c (x_consider_frame_title): Revert last change.
1492
d251c37c
EZ
14932012-06-22 Eli Zaretskii <eliz@gnu.org>
1494
1495 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1496 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1497 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1498 staticidx goes up to 1597 out of 1600 = 0x640.)
1499
f10deafb
PE
15002012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1503 Otherwise, the umask might be mistakenly 0 while handling input signals.
1504
ec6de1e2
SM
15052012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1506
1507 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1508
28be1ada
DA
15092012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1510
1511 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1512 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1513 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1514 access to `contents' member of Lisp_Vector objects with AREF and ASET
1515 where appropriate.
1516
c6bf3022
CY
15172012-06-19 Chong Yidong <cyd@gnu.org>
1518
1519 * frame.c (delete_frame): When selecting a frame on a different
1520 text terminal, do not alter the terminal's top-frame.
1521
1522 * xdisp.c (format_mode_line_unwind_data): Record the target
1523 frame's selected window and its terminal's top-frame.
1524 (unwind_format_mode_line): Restore them.
1525 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1526 Callers changed.
1527 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1528 since tty frames can be explicitly named.
1529 (prepare_menu_bars): Likewise.
1530
1531 * term.c (Ftty_top_frame): New function.
1532
defd4196
PE
15332012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 Port byte-code-meter to modern targets.
1536 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1537 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1538 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1539 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1540 (METER_1, METER_2): Simplify.
1541
1053a871
SM
15422012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1543
1544 * data.c (Fdefalias): Return `symbol' (bug#11686).
1545
b7e8d081
MR
15462012-06-18 Martin Rudalics <rudalics@gmx.at>
1547
1548 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1549 gets killed during executing of this function (Bug#11665).
1550 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1551 (Vkill_buffer_query_functions): In doc-string say that functions
1552 run by this hook should not change the current buffer.
1553
7ea2b339
PE
15542012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1555
1556 Fix recently-introduced process.c problems found by static checking.
1557 * process.c (write_queue_push, write_queue_pop, send_process):
1558 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1559 (write_queue_pop): Fix pointer signedness problem.
1560 (send_process): Remove unused local.
1561
96a313a1
CY
15622012-06-17 Chong Yidong <cyd@gnu.org>
1563
1564 * xdisp.c (redisplay_internal): No need to redisplay terminal
1565 frames that are not on top.
1566
20ca2e94
TN
15672012-06-17 Troels Nielsen <bn.troels@gmail.com>
1568
1569 * process.c (make_process): Initialize write_queue.
1570 (write_queue_push, write_queue_pop): New functions.
1571 (send_process): Use them to maintain correct ordering of process
1572 writes (Bug#10815).
1573
9a900ca9
PE
15742012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1575
310fbfa8
PE
1576 * lisp.h (eassert): Assume C89 or later.
1577 This removes the need for CHECK.
1578 (CHECK): Remove. Its comments about always evaluating its
1579 argument were confusing, as 'eassert' typically does not evaluate
1580 its argument.
1581
27bb1ca4
PE
1582 * coding.c (produce_chars): Use ptrdiff_t, not int.
1583
9a900ca9
PE
1584 * xterm.c (x_draw_underwave): Check for integer overflow.
1585 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1586
41b7f8bc 15872012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1588
1589 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1590 referenced (Bug#11583).
1591
9b0e3eba
AA
15922012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1593
1594 Implement wave-style variant of underlining.
1595 * dispextern.h (face_underline_type): New enum.
1596 (face): Add field for underline type.
1597 * nsterm.m (ns_draw_underwave): New function.
1598 (ns_draw_text_decoration): Use it.
1599 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1600 New functions.
1601 (x_draw_glyph_string): Use them.
1602 * xfaces.c (Qline, Qwave): New Lisp objects.
1603 (check_lface_attrs, merge_face_ref)
1053a871
SM
1604 (Finternal_set_lisp_face_attribute, realize_x_face):
1605 Handle wave-style underline face attributes.
9b0e3eba
AA
1606 * xterm.c (x_draw_underwave): New function.
1607 (x_draw_glyph_string): Use it.
1608
0fb52f11
JB
16092012-06-16 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1612 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1613 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1614 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1615 ($(BLD)/w32select.$(O)): Update dependencies.
1616
e5560ff7
AS
16172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1618
1619 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1620 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1621 * character.c (_fetch_multibyte_char_p): Remove.
1622 * alloc.c: Include "character.h" before "buffer.h".
1623 * bidi.c: Likewise.
1624 * buffer.c: Likewise.
1625 * bytecode.c: Likewise.
1626 * callint.c: Likewise.
1627 * callproc.c: Likewise.
1628 * casefiddle.c: Likewise.
1629 * casetab.c: Likewise.
1630 * category.c: Likewise.
1631 * cmds.c: Likewise.
1632 * coding.c: Likewise.
1633 * composite.c: Likewise.
1634 * dired.c: Likewise.
1635 * dispnew.c: Likewise.
1636 * doc.c: Likewise.
1637 * dosfns.c: Likewise.
1638 * editfns.c: Likewise.
1639 * emacs.c: Likewise.
1640 * fileio.c: Likewise.
1641 * filelock.c: Likewise.
1642 * font.c: Likewise.
1643 * fontset.c: Likewise.
1644 * fringe.c: Likewise.
1645 * indent.c: Likewise.
1646 * insdel.c: Likewise.
1647 * intervals.c: Likewise.
1648 * keyboard.c: Likewise.
1649 * keymap.c: Likewise.
1650 * lread.c: Likewise.
1651 * macros.c: Likewise.
1652 * marker.c: Likewise.
1653 * minibuf.c: Likewise.
1654 * nsfns.m: Likewise.
1655 * nsmenu.m: Likewise.
1656 * print.c: Likewise.
1657 * process.c: Likewise.
1658 * regex.c: Likewise.
1659 * region-cache.c: Likewise.
1660 * search.c: Likewise.
1661 * syntax.c: Likewise.
1662 * term.c: Likewise.
1663 * textprop.c: Likewise.
1664 * undo.c: Likewise.
1665 * unexsol.c: Likewise.
1666 * w16select.c: Likewise.
1667 * w32fns.c: Likewise.
1668 * w32menu.c: Likewise.
1669 * window.c: Likewise.
1670 * xdisp.c: Likewise.
1671 * xfns.c: Likewise.
1672 * xmenu.c: Likewise.
1673 * xml.c: Likewise.
1674 * xselect.c: Likewise.
1675
2f07e6af
EZ
16762012-06-16 Eli Zaretskii <eliz@gnu.org>
1677
1053a871
SM
1678 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1679 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1680 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1681 row.
1682 (handle_face_prop): Use chunk-relative overlay string index when
1683 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1684 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1685 the rightmost. (Bug#11720)
2f07e6af 1686
29b83cec
AS
16872012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1688
1689 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1690 (CATEGORY_MEMBER): Enforce 1/0 value.
1691 * category.c (_temp_category_set): Remove.
1692
4c5501e9
EZ
16932012-06-16 Eli Zaretskii <eliz@gnu.org>
1694
1695 * window.c (Fdelete_other_windows_internal)
1696 (Fdelete_window_internal): Don't access frame's mouse highlight
1697 info of the initial frame. (Bug#11677)
1698
2b570124
PE
16992012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1700
e93864f9
PE
1701 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1702 Assume USE_2_TAGS_FOR_INTS.
1703 (xreload): Adjust $tagmask width to match recent lisp.h change.
1704
2b570124
PE
1705 Simplify lisp.h in minor ways that should not affect code.
1706 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1707 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1708 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1709 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1710 (INTTYPEBITS): New macro, for clarity.
1711 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1712 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1713 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1714 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1715 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1716
81755f69
JB
17172012-06-13 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1720
16192a57
GM
17212012-06-13 Glenn Morris <rgm@gnu.org>
1722
1723 * s/bsd-common.h (BSD4_3):
1724 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1725
646b5f55
AS
17262012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1727
1728 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1729 instead of union.
1730 (XLI, XIL): Define.
1053a871
SM
1731 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1732 Use them.
1733 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1734 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1735 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1736 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1737 * frame.c (delete_frame): Remove outdated comment.
1738 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1739 USE_LISP_UNION_TYPE.
1740 (Fw32_unregister_hot_key): Likewise.
1741 (Fw32_toggle_lock_key): Likewise.
1742 * w32menu.c (add_menu_item): Likewise.
1743 (w32_menu_display_help): Use XIL instead of checking
1744 USE_LISP_UNION_TYPE.
1745 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1746 (init_heap): Likewise.
1747 * w32term.c (w32_read_socket): Update comment.
1748
1d3823c9
GM
17492012-06-13 Glenn Morris <rgm@gnu.org>
1750
c62ff706
GM
1751 * s/usg5-4-common.h, src/s/unixware.h:
1752 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1753
1d3823c9
GM
1754 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1755
bfe3e0a2
PE
17562012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1759 * alloc.c (make_number) [!defined make_number]:
1760 Remove, as lisp.h always defines this now.
1761 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1762 (roundup_size): Verify that it is a power of 2.
1763 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1764 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1765 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1766 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1767 USE_LSB_TAG now is always defined to be either 0 or 1.
1768 All uses changed.
1769 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1770 code works fine either way, and efficiency is not a concern here,
1771 as the union type is for debugging, not for production.
1772 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1773 Use an inline function on all platforms when using the union type,
1774 since this is simpler and 'static inline' can be used portably
1775 within Emacs now.
1776 (LISP_INITIALLY_ZERO): New macro.
1777 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1778 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1779
45fa9c0f
GM
17802012-06-12 Glenn Morris <rgm@gnu.org>
1781
b4492cba
GM
1782 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1783
1784 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1785
45fa9c0f
GM
1786 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1787 Move BROKEN_SIGIO to configure.
1788
1789 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1790 Move NO_TERMIO to configure.
1791
0e25d334
CY
17922012-06-12 Chong Yidong <cyd@gnu.org>
1793
1794 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1795 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1796 MagickExportImagePixels is undefined.
1797
43682bb6
PE
17982012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 * image.c (imagemagick_load_image): Remove unused label.
1801
a9be7d2b
GM
18022012-06-11 Glenn Morris <rgm@gnu.org>
1803
1804 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1805 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1806 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1807 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1808
3017f87f
SM
18092012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * alloc.c (make_byte_code): New function.
1812 (Fmake_byte_code): Use it. Don't purify here.
1813 * lread.c (read1): Use it as well to avoid extra allocation.
1814
1b9b4cf4
CY
18152012-06-11 Chong Yidong <cyd@gnu.org>
1816
1817 * image.c (imagemagick_load_image): Implement transparency.
1818
95988fcf
AS
18192012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1820
1821 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1822 account for preceding backslashes. (Bug#11663)
1823
cd4eb164
CY
18242012-06-09 Chong Yidong <cyd@gnu.org>
1825
1826 * term.c: Support italics in capable terminals (Bug#9652).
1827 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1828 (turn_on_face): Output using TS_enter_italic_mode if available.
1829 Don't handle unused blinking and alt-charset cases.
1830 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1831 and tty_alt_charset_p cases.
1832 (tty_capable_p, init_tty): Support italics.
1833
1834 * termchar.h (struct tty_display_info): Add field for italics.
1835 Remove unused blink field.
1836
1837 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1838 Handle slant.
1839
1840 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1841 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1842 tty_alt_charset_p. Add tty_italic_p.
1843
ff88beb8
MA
18442012-06-09 Michael Albinus <michael.albinus@gmx.de>
1845
1846 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1847 dbus_type_is_basic if available.
1848 (xd_extract_signed, xd_extract_unsigned): Rename from
1849 extract_signed and extract_unsigned, respectively. Adapt callers.
1850
44286096
CY
18512012-06-09 Chong Yidong <cyd@gnu.org>
1852
1682701f
CY
1853 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1854
44286096
CY
1855 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1856 case (Bug#9752).
1857
d86feb17
PE
18582012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 * xdisp.c (vmessage): Treat frame message as multibyte.
1861 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1862 would generate the diagnostic "Making \302\247 buffer-local while
1863 let-bound!".
1864
d5c20fe8
EZ
18652012-06-08 Eli Zaretskii <eliz@gnu.org>
1866
1867 * dispnew.c (showing_window_margins_p): Undo last change, which
1868 was done due to an inadvertent commit.
1869 (adjust_frame_glyphs_for_frame_redisplay): Do call
1870 showing_window_margins_p.
1871
513749ee
SM
18722012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1873
1874 * eval.c (Fmake_var_non_special): New primitive.
1875 (syms_of_eval): Defsubr it.
1876 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1877
d4a8f5c1
JB
18782012-06-08 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1881 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1882
8bbbc977
EZ
18832012-06-08 Eli Zaretskii <eliz@gnu.org>
1884
1885 * alloc.c (allocate_vectorlike): Fix last change.
1886
f3372c87
DA
18872012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1888
1889 Block-based vector allocation of small vectors.
1890 * lisp.h (struct vectorlike_header): New field `nbytes',
1891 adjust comment accordingly.
1892 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1893 to denote vector blocks. Adjust users (live_vector_p,
1894 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1895 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1896 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1897 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1898 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1899 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1900 (roundup_size): New constant.
1901 (struct vector_block): New data type.
1902 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1903 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1904 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1905 (sweep_vectors): New functions.
1906 (allocate_vectorlike): Return `zero_vector' as the only vector of
1907 0 items. Allocate new vector from block if vector size is less than
1908 or equal to VBLOCK_BYTES_MAX.
1909 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1910 (init_alloc_once): Add call to init_vectors.
1911
4f18a4ed
SM
19122012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1913
1914 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1915
86f158bc
PE
19162012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 * doprnt.c (doprnt): Truncate multibyte char correctly.
1919 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1920 would mishandle a string argument "Xc" if X was a multibyte
1921 character of length 2: it would truncate after X's first byte
1922 rather than including all of X.
1923
c5cfcbe0
CY
19242012-06-06 Chong Yidong <cyd@gnu.org>
1925
1926 * buffer.c (word_wrap): Doc fix.
1927
c05cf390
PE
19282012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1929
1930 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1931
0c3461de
GM
19322012-06-03 Glenn Morris <rgm@gnu.org>
1933
1934 * xdisp.c (tool-bar-style): Doc fix.
1935
c71232db
UM
19362012-06-03 Ulrich Müller <ulm@gentoo.org>
1937
1938 * Makefile.in (PAXCTL): Define.
1939 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1940 binary via PaX flags if the paxctl utility is available.
1941 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1942 Restore PaX flags to their default. (Bug#11398)
1943
383f7350
CY
19442012-06-03 Chong Yidong <cyd@gnu.org>
1945
1946 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1947 buffer (Bug#11226).
1948
5f2c76c6
CY
19492012-06-03 Chong Yidong <cyd@gnu.org>
1950
1951 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1952 (note_mode_line_or_margin_highlight): If there is no help echo,
1953 use mode-line-default-help-echo. Handle the case where the mouse
1954 position is past the end of the mode line string.
1955
1956 * buffer.c (buffer_local_value_1): New function, split from
1957 Fbuffer_local_value; can return Qunbound.
1958 (Fbuffer_local_value): Use it.
1959 (Vmode_line_format): Docstring tweaks.
1960
773d47f6
PE
19612012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 * sysdep.c (system_process_attributes): Improve comment.
1964
f2d6a3df
SM
19652012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1966
1967 * keyboard.c: Export real-this-command to Elisp.
1968 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1969 and DEFVAR it. Update all users.
1970
63810350
PE
19712012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1972
7bd5c1f4
PE
1973 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1974
63810350
PE
1975 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1976 Convert pctcpu and pctmem to Lisp float properly.
1977 Let the compiler fold better, as 100.0/0x8000 is exact.
1978
a2821611
AS
19792012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1980
1981 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1982 cons_block.
1983
5fceba1d
PE
19842012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1987
c98ff5dd
DA
19882012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1989
1990 For a 'struct window', replace some Lisp_Object fields to
1991 bitfields where appropriate, remove unused fields.
1992 * window.h (struct window): Remove unused 'last_mark_x' and
1993 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1994 change it's type from Lisp_Object to bitfield.
1995 Change type of 'force_start', 'optional_new_start',
1996 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1997 fields from Lisp_Object to bitfield. Adjust users accordingly.
1998
ca34e0be
PE
19992012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 Pacify gcc -Wdouble-precision when using Xaw.
2002 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2003 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2004 Use 'float' consistently, rather than 'float' in most places
2005 and 'double' in a couple of places.
2006
efc00ab1 20072012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2008
2009 * xdisp.c (handle_stop): Detect whether we have overlay strings
2010 loaded by testing it->current.overlay_string_index to be
2011 non-negative, instead of checking whether n_overlay_strings is
2012 positive. (Bug#11587)
2013
efc00ab1 20142012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2015
2016 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2017
2018 * doc.c (Fsubstitute_command_keys): Doc fix.
2019
efc00ab1 20202012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2021
2022 * search.c (search_buffer): Remove calls to
2023 r_alloc_inhibit_buffer_relocation, as it is now called by
2024 maybe_unify_char, which was the cause of relocation of buffer text
2025 in bug#11519.
2026
efc00ab1 20272012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2028
2029 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2030 for the duration of call to load_charset, to avoid problems with
2031 callers of maybe_unify_char that access buffer text through C
2032 pointers.
2033
2034 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2035 decrement the inhibition flag, instead of just setting or
2036 resetting it.
2037
ba93a187
PE
20382012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 Remove obsolete '#define static' cruft.
2041 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2042 This #undef was "temporary" in 2000; it is no longer needed
2043 now that '#define static' has gone away.
2044 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2045 (gray_bitmap_bits): Remove; no longer needed.
2046 All uses replaced with definiens.
2047 * xterm.c: Include "bitmaps/gray.xbm".
2048
9e4bf381
PE
20492012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2050
2051 Clean up __executable_start, monstartup when --enable-profiling.
2052 The following changes affect the code only when profiling.
2053 * dispnew.c (__executable_start): Rename from safe_bcopy.
2054 Define only on platforms that need it.
2055 * emacs.c: Include <sys/gmon.h> when profiling.
2056 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2057 (__executable_start): Remove decl, since lisp.h does it now.
2058 (safe_bcopy): Remove decl; no longer has that name.
2059 (main): Coalesce #if into single bit of code, for simplicity.
2060 Cast pointers to uintptr_t, since standard libraries want integers
2061 and not pointers.
2062 * lisp.h (__executable_start): New decl.
2063
32d72c2f
GM
20642012-05-31 Glenn Morris <rgm@gnu.org>
2065
2066 * image.c (Fimagemagick_types): Doc fix.
2067
baac5bc7
JM
20682012-05-30 Jim Meyering <meyering@redhat.com>
2069
2070 * callproc.c (Fcall_process_region): Include directory component
2071 in mkstemp error message (Bug#11586).
2072
72cb32cf
PE
20732012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 * alloc.c, lisp.h (make_pure_vector): Now static.
2076
61b108cc
SM
20772012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2080 Move to byte-run.el.
2081 (Fautoload): Do the hash-doc more carefully.
2082 * data.c (Fdefalias): Purify definition, except for keymaps.
2083 (Qdefun): Move from eval.c.
2084 * lisp.h (Qdefun): Remove.
2085 * lread.c (read1): Tiny simplification.
2086
471fe23d
TN
20872012-05-29 Troels Nielsen <bn.troels@gmail.com>
2088
934f3f58 2089 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2090 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2091 Bug#9642, but explicitly check that the buffer the overlay would
2092 be moved to is live and rearrange lines to make sure that errors
2093 will not put the overlay in an inconsistent state.
2094 (Fdelete_overlay): Cosmetics.
2095
85d0efd1
EZ
20962012-05-28 Eli Zaretskii <eliz@gnu.org>
2097
2098 * w32term.c (my_bring_window_to_top): New function.
2099 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2100 could be different from the original one.
2101 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2102 (Bug#11513)
2103
2104 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2105 by calling BringWindowToTop.
2106
2107 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2108 (WM_EMACS_END): Increase by one.
2109
da92a98c
PE
21102012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2113 This avoids undefined behavior that might cause the eassert
2114 to not catch an out-of-range value.
2115
74d1f848
JB
21162012-05-28 Juanma Barranquero <lekktu@gmail.com>
2117
2118 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2119 Update dependencies.
2120
9e1a06fc
EZ
21212012-05-27 Eli Zaretskii <eliz@gnu.org>
2122
2123 * bidi.c (bidi_mirror_char): Fix last change.
2124
f3dd7312
AS
21252012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2126
2127 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2128 when referring to sectname field in printf format.
2129
81899c91
PE
21302012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2131
57b81a9f
PE
2132 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2133 Only r_alloc_inhibit_buffer_relocation needed to be added;
2134 the others were already declared.
2135
81899c91
PE
2136 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2137 before checking whether it's out of range. Put the check inside
2138 eassert. See
2139 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2140
33017faf 21412012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2142
2143 * callproc.c (Fcall_process): Restore a line that was accidentally
2144 commented out in the 2011-02-13 change (bug#11547).
2145
33017faf 21462012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2147
2148 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2149 defined on ralloc.c.
2150
2151 * buffer.c [REL_ALLOC]: Remove prototypes of
2152 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2153 they are now on lisp.h.
2154
2155 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2156
2157 * search.c (search_buffer): Use it to inhibit relocation of buffer
2158 text while re_search_2 is doing its job, because re_search_2 is
2159 passed C pointers to buffer text. (Bug#11519)
2160
23415acf
EZ
2161 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2162 Update value to 24.
2163
44e27368
EZ
2164 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2165 state after an additional call to move_it_in_display_line_to, keep
2166 the values of it->max_ascent and it->max_descent found for the
2167 entire line.
2168 (pos_visible_p): Revert the comparison against bottom_y to what it
2169 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2170 (Bug#11464)
2171
c1892f11
PE
21722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 Fix coding-related core dumps with gcc -ftrapv.
2175 The code was computing A - B, where A and B are pointers, and B is
2176 random garbage. This can lead to core dumps on platforms that
2177 have special pointer registers, and it also leads to core dumps on
2178 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2179 A - B only when B is initialized properly.
2180 * coding.c (coding_set_source, coding_set_destination): Return void.
2181 (coding_change_source, coding_change_destinations): New functions,
2182 with the old behaviors of coding_set_source and coding_set_destination.
2183 All callers that need an offset changed to use these new functions.
2184
eb7afdad
GM
21852012-05-26 Glenn Morris <rgm@gnu.org>
2186
2187 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2188
f12fdf02
EZ
21892012-05-26 Eli Zaretskii <eliz@gnu.org>
2190
53a63be6 2191 Extend mouse support on W32 text-mode console.
61b108cc
SM
2192 * xdisp.c (draw_row_with_mouse_face):
2193 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2194
eb3f6f01 2195 * w32console.c: Include window.h.
61b108cc
SM
2196 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2197 New functions.
eb3f6f01
EZ
2198 (initialize_w32_display): Initialize mouse-highlight data.
2199
53a63be6
EZ
2200 * w32inevt.c: Include termchar.h and window.h.
2201 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2202 moves, call note_mouse_highlight. If help_echo changed, call
2203 gen_help_event to produce help-echo message in the echo area.
2204 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2205 highlight info.
2206
4cfd81f6
PE
22072012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * lread.c (read1): Simplify slightly to avoid an overflow warning
2210 with GCC 4.7.0 on x86-64.
2211
4446092a
EZ
22122012-05-26 Eli Zaretskii <eliz@gnu.org>
2213
2214 * bidi.c (bidi_mirror_char): Revert last change: an int is
2215 definitely wide enough here.
2216
42b2a986 22172012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2218
42b2a986 2219 Fix integer width and related bugs (Bug#9874).
eb106a49 2220 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2221 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2222 (string_bytes, check_sblock, allocate_string_data):
2223 (compact_small_strings, Fmake_bool_vector, make_string)
2224 (make_unibyte_string, make_multibyte_string)
2225 (make_string_from_bytes, make_specified_string)
2226 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2227 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2228 (mark_vectorlike):
2229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2230 (allocate_pseudovector):
2231 Use int, not EMACS_INT, where int is wide enough.
2232 (inhibit_garbage_collection, Fgarbage_collect):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2235 int might not be wide enough.
2236 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2237 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2238 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2240 (bidi_level_of_next_char, bidi_move_to_visually_next):
2241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2242 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2243 (Fkill_buffer, Fset_buffer_major_mode)
2244 (advance_to_char_boundary, Fbuffer_swap_text)
2245 (Fset_buffer_multibyte, overlays_at, overlays_in)
2246 (overlay_touches_p, struct sortvec, record_overlay_string)
2247 (overlay_strings, recenter_overlay_lists)
2248 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2249 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2250 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2251 (Foverlay_recenter, last_overlay_modification_hooks_used)
2252 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2254 (validate_region): Omit unnecessary test for b <= e,
2255 since that's guaranteed by the previous test.
d311d28c
PE
2256 (adjust_overlays_for_delete): Avoid pos + length overflow.
2257 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2258 (report_overlay_modification):
2259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2260 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2261 Omit pointer cast, which isn't needed anyway, and doesn't work
2262 after the EMACS_INT -> ptrdiff_t change.
02481186 2263 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2264 * buffer.h: Adjust decls to match defn changes elsewhere.
2265 (struct buffer_text, struct buffer):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2268 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2269 not int, to avoid needless 32-bit limit on 64-bit hosts.
2270 (exec_byte_code): Use tighter memory-full test, one that checks
2271 for alloca overflow. Don't compute the address of the object just
2272 before an array, as that's not portable. Use EMACS_INT, not
2273 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2274 * callint.c (Fcall_interactively):
2275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2276 * callproc.c (call_process_kill, Fcall_process):
2277 Don't assume pid_t fits into an Emacs fixnum.
2278 (call_process_cleanup, Fcall_process, child_setup):
2279 Don't assume pid_t fits into int.
2280 (call_process_cleanup, Fcall_process, delete_temp_file)
2281 (Fcall_process_region):
2282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2283 (Fcall_process): Simplify handling of volatile integers.
2284 Use int, not EMACS_INT, where int will do.
2285 * casefiddle.c (casify_object, casify_region, operate_on_word)
2286 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2288 (casify_object): Avoid integer overflow when overallocating buffer.
2289 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2290 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2291 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2292 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2293 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2294 integers are now checked earlier. All uses replaced with XINT.
2295 (ccl_driver):
2296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2297 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2298 (ccl_driver, Fregister_code_conversion_map):
2299 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2300 (resolve_symbol_ccl_program): Check that vector header is in range.
2301 Always copy the vector, so that we can check its contents reliably
2302 now rather than having to recheck each instruction as it's being
2303 executed. Check that vector words fit in 'int'.
2304 (ccl_get_compiled_code, Fregister_ccl_program)
2305 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2306 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2307 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2308 contents are in range.
2309 (Fccl_execute_on_string): Check that status is in range.
2310 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2311 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2312 Accept and return EMACS_INT, not int, because callers can pass values
2313 out of 'int' range.
2314 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2315 (multibyte_chars_in_text, parse_str_as_multibyte)
2316 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2317 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2318 (string_escape_byte8, Fget_byte):
2319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2320 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2321 avoid mishandling large integers.
2322 * character.h: Adjust decls to match defn changes elsewhere.
2323 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2324 (Ffind_charset_region):
2325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2326 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2327 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2328 Don't assume fixnum fits in int.
d311d28c
PE
2329 (load_charset_map_from_vector, Fmap_charset_chars):
2330 Remove now-unnecessary CHECK_NATNUMs.
2331 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2332 Don't rely on undefined behavior with signed left shift overflow.
2333 Don't assume unsigned int fits into fixnum, or that fixnum fits
2334 into unsigned int. Don't require max_code to be a valid fixnum;
2335 that's not true for gb10830 4-byte on a 32-bit host. Allow
2336 invalid_code to be a cons, for the same reason. Require code_offset
2337 to be a character. Avoid int overflow if max_char is close
2338 to INT_MAX.
2339 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2340 this is intended anyway and avoids some undefined behavior.
2341 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2342 INDEX_TO_CODE_POINT, as that's what it expects.
2343 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2344 * charset.h (DECODE_CHAR): Return int, not unsigned;
2345 this is what was intended anyway, and it avoids undefined behavior.
2346 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2347 integer-overflow issues.
2348 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2349 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2350 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2351 * chartab.c (Fmake_char_table, Fset_char_table_range)
2352 (uniprop_get_decoder, uniprop_get_encoder):
2353 Don't assume fixnum fits in int.
2354 * cmds.c (move_point): New function, that does the gist of
2355 Fforward_char and Fbackward_char, but does so while checking
2356 for integer overflow more accurately.
c96e5d6a 2357 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2358 (Fforward_line, Fend_of_line, internal_self_insert)
2359 (internal_self_insert):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2361 Fix a FIXME, by checking for integer overflow when calculating
2362 target_clm and actual_clm.
2363 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2364 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2365 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2366 (coding_alloc_by_making_gap, alloc_destination)
2367 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2368 (encode_coding_utf_16, detect_coding_emacs_mule)
2369 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2370 (detect_coding_iso_2022, decode_coding_iso_2022)
2371 (encode_invocation_designation, encode_designation_at_bol)
2372 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2373 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2374 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2375 (encode_coding_ccl, encode_coding_raw_text)
2376 (detect_coding_charset, decode_coding_charset)
2377 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2378 (produce_composition, produce_charset, produce_annotation)
2379 (decode_coding, handle_composition_annotation)
2380 (handle_charset_annotation, consume_chars, decode_coding_gap)
2381 (decode_coding_object, encode_coding_object, detect_coding_system)
2382 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2383 (code_convert_region, code_convert_string)
8f50130c
PE
2384 (Fdefine_coding_system_internal)
2385 (coding_set_source, coding_set_destination):
d311d28c
PE
2386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2387 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2388 (Fdefine_coding_system_internal):
2389 Don't assume fixnums fit in int.
2390 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2391 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2392 (Funencodable_char_position, Fcheck_coding_systems_region)
2393 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2395 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2396 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2397 Don't access memory outside of the args array.
d311d28c 2398 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2399 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2400 result of ENCODE_CHAR.
d311d28c
PE
2401 * coding.h: Adjust decls to match defn changes elsewhere.
2402 (struct coding_system):
2403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2404 * composite.c (get_composition_id, find_composition)
2405 (run_composition_function, update_compositions)
2406 (compose_text, composition_gstring_put_cache)
2407 (composition_gstring_p, composition_gstring_width)
2408 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2409 (composition_compute_stop_pos, composition_reseat_it)
2410 (composition_update_it, struct position_record)
2411 (find_automatic_composition, composition_adjust_point)
2412 (Fcomposition_get_gstring, Ffind_composition_internal):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 (update_compositions):
2415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2416 * composite.h: Adjust decls to match defn changes elsewhere.
2417 (struct composition):
2418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2419 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2420 Do not attempt to compute the address of the object just before a
2421 buffer; this is not portable.
2422 (Faref, Faset):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 (Faset): Use int, not EMACS_INT, where int is wide enough.
2425 (Fstring_to_number): Don't assume fixnums fit in int.
2426 (Frem): Don't assume arg is nonnegative.
2427 * dbusbind.c (xd_append_arg): Check for integers out of range.
2428 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2429 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2430 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2431 (xd_get_connection_references): Return ptrdiff_t, not int.
2432 All uses changed.
2433 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2434 (xd_read_message_1):
2435 Use int, not unsigned, where the dbus API uses int.
2436 (Fdbus_message_internal): Don't overflow mtype.
2437 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2438 * dired.c (directory_files_internal, file_name_completion, scmp)
2439 (file_name_completion_stat):
2440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2441 (file_name_completion): Don't overflow matchcount.
2442 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2443 * dispextern.h: Adjust decls to match defn changes elsewhere.
2444 (struct text_pos, struct glyph, struct bidi_saved_info)
2445 (struct bidi_string_data, struct bidi_it, struct composition_it)
2446 (struct it):
2447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2448 (struct display_pos, struct composition_it, struct it):
2449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2450 * dispnew.c (increment_matrix_positions)
2451 (increment_row_positions, mode_line_string)
2452 (marginal_area_string):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2454 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2456 (duration_to_sec_usec): New function, to check for overflow better.
2457 (Fsleep_for, sit_for): Use it.
2458 * doc.c (get_doc_string, store_function_docstring):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (get_doc_string, Fsnarf_documentation):
2461 Use int, not EMACS_INT, where int is wide enough.
2462 (get_doc_string):
2463 Use SAFE_ALLOCA, not alloca.
2464 Check for overflow when converting EMACS_INT to off_t.
2465 * doprnt.c (doprnt):
2466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2467 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2468 Don't assume uid_t fits into fixnum.
2469 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2470 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2471 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2472 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2473 (general_insert_function)
2474 (Finsert_char, make_buffer_string, make_buffer_string_both)
2475 (update_buffer_properties, Fbuffer_substring)
2476 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2477 (Fsubst_char_in_region, check_translation)
2478 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2479 (transpose_markers, Ftranspose_regions):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 (clip_to_bounds): Move to lisp.h as an inline function).
2482 (Fconstrain_to_field): Don't assume integers are nonnegative.
2483 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2484 (Fsubst_char_in_region, Fsave_restriction):
2485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2486 (Femacs_pid): Don't assume pid_t fits into fixnum.
2487 (lo_time): Use int, not EMACS_INT, when int suffices.
2488 (lisp_time_argument): Check for usec out of range.
2489 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2490 (Fuser_login_name, Fuser_full_name): Signal an error
2491 if a uid argument is out of range, rather than relying on
2492 undefined behavior.
c8d5c857
PE
2493 (Fformat_time_string): Remove now-unnecessary check.
2494 lisp_time_argument checks for out-of-range usec now.
243e0530 2495 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2496 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2497 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2498 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2499 (init_cmdargs, Fdump_emacs):
2500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2501 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2502 the bottom (typically) 32 bits of the fixnum.
2503 * eval.c (specpdl_size, call_debugger):
2504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2505 (when_entered_debugger, Fbacktrace_debug):
2506 Don't assume fixnum can fit in int.
2507 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2508 the object just before a buffer; this is not portable.
2509 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2510 (grow_specpdl, unbind_to):
2511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2512 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2513 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2514 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2515 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2516 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2518 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2519 (a_write, e_write):
2520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2521 (Fcopy_file, non_regular_nbytes, read_non_regular)
2522 (Finsert_file_contents):
2523 Use int, not EMACS_INT, where int is wide enough.
2524 (READ_BUF_SIZE): Verify that it fits in int.
2525 (Finsert_file_contents): Check that counts are in proper range,
2526 rather than assuming fixnums fit into ptrdiff_t etc.
2527 Don't assume fixnums fit into int.
125b3835 2528 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2529 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2530 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2531 (string_char_to_byte, string_byte_to_char)
2532 (string_make_multibyte, string_to_multibyte)
2533 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2534 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2535 (substring_both, Fdelete, internal_equal, Ffillarray)
2536 (Fclear_string, mapcar1)
2537 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2538 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2539 (larger_vector, make_hash_table, maybe_resize_hash_table)
2540 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2541 (Fmaphash, secure_hash):
2542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2543 (concat): Check for string index and length overflow.
2544 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2545 (Frequire):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (larger_vector): New API (vec, incr_min, size_max) replaces old
2548 one (vec, new_size, init). This catches size overflow.
2549 INIT was removed because it was always Qnil.
2550 All callers changed.
2551 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2552 the upper bound on a hash table index size.
2553 (make_hash_table, maybe_resize_hash_table): Use it.
2554 (secure_hash): Computer start_byte and end_byte only after
2555 they're known to be in ptrdiff_t range.
2556 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2557 (Ffont_get_glyphs, Ffont_at):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2559 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2560 (Flist_fonts, Fopen_font):
2561 Don't assume fixnum can fit in int.
2562 (check_gstring): Don't assume index can fit in int.
2563 (font_match_p): Check that fixnum is a character, not a nonnegative
2564 fixnum, since the later code needs to stuff it into an int.
2565 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2566 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2567 conversion overflow issues.
2568 (Fopen_font): Check for integer out of range.
2569 (Ffont_get_glyphs): Don't assume index can fit in int.
2570 * font.h: Adjust decls to match defn changes elsewhere.
2571 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2572 integer overflow.
2573 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2574 printmax_t, where ptrdiff_t is wide enough.
2575 (Finternal_char_font):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2578 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2579 (Fset_frame_position, x_set_frame_parameters)
2580 (x_set_line_spacing, x_set_border_width)
2581 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2582 Check that fixnums are in proper range for system types.
2583 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2585 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2586 Use SAFE_ALLOCA_LISP, not alloca.
2587 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2588 intptr_t is wide enough.
2589 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2590 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2591 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2592 Check for fixnum out of range.
2593 * ftfont.c (ftfont_list): Don't assume index fits in int.
2594 Check that fixnums are in proper range for system types.
2595 (ftfont_shape_by_flt):
2596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2597 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2599 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2600 Check that fixnums are in proper range for system types.
2601 * gnutls.h: Adjust decls to match defn changes elsewhere.
2602 * gtkutil.c (xg_dialog_run):
2603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2604 (update_frame_tool_bar):
2605 Check that fixnums are in proper range for system types.
2606 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2607 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2608 * indent.c (last_known_column, last_known_column_point):
2609 (current_column_bol_cache):
2610 (skip_invisible, current_column, check_display_width):
2611 (check_display_width, scan_for_column, current_column_1)
2612 (Findent_to, Fcurrent_indentation, position_indentation)
2613 (indented_beyond_p, Fmove_to_column, compute_motion):
2614 (Fcompute_motion, Fvertical_motion):
2615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2616 (last_known_column_modified): Use EMACS_INT, not int.
2617 (check_display_width):
2618 (Fcompute_motion):
2619 Check that fixnums and floats are in proper range for system types.
2620 (compute_motion): Don't assume index or fixnum fits in int.
2621 (compute_motion, Fcompute_motion):
2622 Use int, not EMACS_INT, when it is wide enough.
2623 (vmotion): Omit local var start_hpos that is always 0; that way
2624 we don't need to worry about overflow in expressions involving it.
2625 * indent.h: Adjust decls to match defn changes elsewhere.
2626 (struct position):
2627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2628 Use int, not EMACS_INT, where int is wide enough.
2629 Remove unused members ovstring_chars_done and tab_offset;
2630 all uses removed.
2631 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2632 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2633 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2634 (make_gap, copy_text, insert, insert_and_inherit)
2635 (insert_before_markers, insert_before_markers_and_inherit)
2636 (insert_1, count_combining_before, count_combining_after)
2637 (insert_1_both, insert_from_string)
2638 (insert_from_string_before_markers, insert_from_string_1)
2639 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2640 (adjust_after_replace, adjust_after_insert, replace_range)
2641 (replace_range_2, del_range, del_range_1, del_range_byte)
2642 (del_range_both, del_range_2, modify_region)
2643 (prepare_to_modify_buffer, signal_before_change)
2644 (signal_after_change, Fcombine_after_change_execute):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2647 (balance_an_interval, split_interval_right, split_interval_left)
2648 (find_interval, next_interval, update_interval)
2649 (adjust_intervals_for_insertion, delete_node, delete_interval)
2650 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2651 (static_offset_intervals, offset_intervals)
2652 (merge_interval_right, merge_interval_left, make_new_interval)
2653 (graft_intervals_into_buffer, temp_set_point_both)
2654 (temp_set_point, set_point, adjust_for_invis_intang)
2655 (set_point_both, move_if_not_intangible, get_property_and_range)
2656 (get_local_map, copy_intervals, copy_intervals_to_string)
2657 (compare_string_intervals, set_intervals_multibyte_1):
2658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2659 * intervals.h: Adjust decls to match defn changes elsewhere.
2660 (struct interval):
2661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2662 * keyboard.c (this_command_key_count, this_single_command_key_start)
2663 (before_command_key_count, before_command_echo_length, echo_now)
2664 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2665 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2666 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2667 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2669 (last_non_minibuf_size, last_point_position, echo_truncate)
2670 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2671 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2672 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2673 (stuff_buffered_input):
2674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2675 (last_auto_save, command_loop_1, read_char):
2676 Use EMACS_INT, not int, to avoid integer overflow.
2677 (record_char): Avoid overflow in total_keys computation.
2678 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2679 * keyboard.h: Adjust decls to match defn changes elsewhere.
2680 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2681 (Fkey_description, Fdescribe_vector, Flookup_key):
2682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2683 (click_position): New function, to check that positions are in range.
2684 (Fcurrent_active_maps):
2685 (describe_command):
2686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2687 (Faccessible_keymaps, Fkey_description):
2688 (preferred_sequence_p):
2689 Don't assume fixnum can fit into int.
2690 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2691 Check for integer overflow in size calculations.
2692 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2693 avoid mishandling large integers.
2694 * lisp.h: Adjust decls to match defn changes elsewhere.
2695 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2696 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2697 (struct Lisp_Marker):
2698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2699 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2700 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2701 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2702 All callers changed.
2703 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2704 Assume the arg has valid form, since it always does.
2705 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2706 unsigned integer system type.
2707 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2708 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2710 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2711 (duration_to_sec_usec): New decl.
2712 * lread.c (read_from_string_index, read_from_string_index_byte)
2713 (read_from_string_limit, readchar, unreadchar, openp)
2714 (read_internal_start, read1, oblookup):
2715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2716 (Fload, readevalloop, Feval_buffer, Feval_region):
2717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2718 (openp): Check for out-of-range argument to 'access'.
2719 (read1): Use int, not EMACS_INT, where int is wide enough.
2720 Don't assume fixnum fits into int.
6efdadfd 2721 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2722 (read_filtered_event): Use duration_to_sec_usec
2723 to do proper overflow checking on durations.
d311d28c
PE
2724 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2725 in size calculation.
2726 (Fexecute_kbd_macro):
2727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2728 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2729 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2730 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2731 (set_marker_both, set_marker_restricted_both, marker_position)
2732 (marker_byte_position, Fbuffer_has_markers_at):
2733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2734 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2735 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2736 It now merely ensures that the menu is large enough, without
2737 necessarily growing it, as this avoids some integer overflow issues.
2738 All callers changed.
2739 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2741 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2742 Use SAFE_ALLOCA_LISP, not alloca.
2743 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2744 to EMACS_INT. Check that fixnums are in proper range for system types.
2745 * minibuf.c (minibuf_prompt_width, string_to_object)
2746 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2747 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2749 (get_minibuffer, read_minibuf_unwind):
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2751 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2752 this simplifies overflow checking. All callers changed.
2753 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2754 (Ftest_completion):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2757 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2758 Check that fixnums are in proper range for system types.
2759 (Fx_create_frame, Fx_show_tip):
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 * nsfont.m (ns_findfonts, nsfont_list_family):
2762 Don't assume fixnum fits in long.
2763 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2766 wide enough.
17fdb222 2767 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2770 (PRINTDECLARE, PRINTPREPARE):
2771 (strout, print_string):
2772 (print, print_preprocess, print_check_string_charset_prop)
2773 (print_object):
2774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2775 (PRINTDECLARE):
2776 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2779 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2780 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2781 (print_error_message): Use SAFE_ALLOCA, not alloca.
2782 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2783 (print_depth, new_backquote_output, print_number_index):
2784 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2785 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2786 (Fset_process_window_size, Fformat_network_address)
2787 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2788 (sigchld_handler):
d311d28c 2789 Check that fixnums are in proper range for system types.
d44287d4 2790 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2791 Check for process-ids out of pid_t range rather than relying on
2792 undefined behavior.
e4d81efc 2793 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2794 (Fformat_network_address, read_process_output, send_process)
2795 (Fprocess_send_region, status_notify):
2796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2797 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2798 (wait_reading_process_output, read_process_output, exec_sentinel):
2799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2800 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2801 (Faccept_process_output): Use duration_to_sec_usec to do proper
2802 overflow checking on durations.
dde14581
PE
2803 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2804 Don't assume pid_t fits in int.
02481186
PE
2805 * process.h (struct Lisp_Process): Members tick and update_tick
2806 are now of type EMACS_INT, not int.
b62b53e8
PE
2807 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2808 configured --with-wide-int.
d311d28c
PE
2809 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2810 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2811 * search.c (looking_at_1, string_match_1):
2812 (fast_string_match, fast_c_string_match_ignore_case)
2813 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2814 (scan_newline, find_before_next_newline, search_command)
2815 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2816 (set_search_regs, wordify):
2817 (Freplace_match):
2818 (Fmatch_data):
2819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2820 (string_match_1, search_buffer, set_search_regs):
2821 (Fmatch_data):
2822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2823 (wordify): Check for overflow in size calculation.
2824 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2825 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2826 Check that fixnums are in proper range for system types.
2827 * sound.c (struct sound_device)
2828 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2830 (Fplay_sound_internal):
2831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2832 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2833 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2834 (Fparse_partial_sexp):
2835 Don't assume fixnums can fit in int.
2836 (struct lisp_parse_state, find_start_pos, find_start_value)
2837 (find_start_value_byte, find_start_begv)
2838 (update_syntax_table, char_quoted, dec_bytepos)
2839 (find_defun_start, prev_char_comend_first, back_comment):
2840 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2841 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2843 (Finternal_describe_syntax_value): Check that match_lisp is a
2844 character, not an integer, since the code stuffs it into int.
2845 (scan_words, scan_sexps_forward):
2846 Check that fixnums are in proper range for system types.
2847 (Fforward_word):
2848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2849 (scan_sexps_forward):
2850 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2851 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2852 * syntax.h: Adjust decls to match defn changes elsewhere.
2853 (struct gl_state_s):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2855 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2856 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2857 * sysdep.c (wait_for_termination_1, wait_for_termination)
2858 (interruptible_wait_for_termination, mkdir):
2859 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2860 (emacs_read, emacs_write):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2862 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2863 and double all fit in int.
d311d28c
PE
2864 * term.c (set_tty_color_mode):
2865 Check that fixnums are in proper range for system types.
2866 * termhooks.h (struct input_event):
2867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2868 * textprop.c (validate_interval_range, interval_of)
2869 (Fadd_text_properties, set_text_properties_1)
2870 (Fremove_text_properties, Fremove_list_of_text_properties)
2871 (Ftext_property_any, Ftext_property_not_all)
2872 (copy_text_properties, text_property_list, extend_property_ranges)
2873 (verify_interval_modification):
2874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2875 (Fnext_single_char_property_change)
2876 (Fprevious_single_char_property_change):
2877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2878 (copy_text_properties):
2879 Check for integer overflow in index calculation.
d311d28c
PE
2880 * undo.c (last_boundary_position, record_point, record_insert)
2881 (record_delete, record_marker_adjustment, record_change)
2882 (record_property_change):
2883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2884 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2886 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2887 (Fx_hide_tip, Fx_file_dialog):
2888 * w32menu.c (set_frame_menubar):
2889 Use ptrdiff_t, not int, for consistency with rest of code.
2890 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2891 (select_window, Fdelete_other_windows_internal)
2892 (window_scroll_pixel_based, window_scroll_line_based)
2893 (Frecenter, Fset_window_configuration):
2894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2895 (Fset_window_hscroll, run_window_configuration_change_hook)
2896 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2897 (Fscroll_other_window, Frecenter):
d311d28c
PE
2898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2899 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2900 Don't assume fixnum fits in int.
2901 (Fset_window_scroll_bars):
2902 Check that fixnums are in proper range for system types.
2903 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2904 (string_pos, c_string_pos, number_of_chars, init_iterator)
2905 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2906 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2907 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2908 (face_before_or_after_it_pos, handle_invisible_prop)
2909 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2910 (display_prop_intangible_p, string_buffer_position_lim)
2911 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2912 (get_overlay_strings_1, get_overlay_strings)
2913 (iterate_out_of_display_property, forward_to_next_line_start)
2914 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2915 (get_next_display_element, set_iterator_to_next)
2916 (get_visually_first_element, compute_stop_pos_backwards)
2917 (handle_stop_backwards, next_element_from_buffer)
2918 (move_it_in_display_line_to, move_it_in_display_line)
2919 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2920 (add_to_log, message_dolog, message_log_check_duplicate)
2921 (message2, message2_nolog, message3, message3_nolog
2922 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2923 (current_message_1, truncate_echo_area, truncate_message_1)
2924 (set_message, set_message_1, store_mode_line_noprop)
2925 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2926 (text_outside_line_unchanged_p, check_point_in_composition)
2927 (reconsider_clip_changes)
2928 (redisplay_internal, set_cursor_from_row, try_scrolling)
2929 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2930 (redisplay_window, find_last_unchanged_at_beg_row)
2931 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2932 (trailing_whitespace_p, find_row_edges, display_line)
2933 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2934 (display_mode_element, store_mode_line_string)
2935 (pint2str, pint2hrstr, decode_mode_spec)
2936 (display_count_lines, display_string, draw_glyphs)
2937 (x_produce_glyphs, x_insert_glyphs)
2938 (rows_from_pos_range, mouse_face_from_buffer_pos)
2939 (fast_find_string_pos, mouse_face_from_string_pos)
2940 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2942 (safe_call, init_from_display_pos, handle_fontified_prop)
2943 (handle_single_display_spec, load_overlay_strings)
2944 (with_echo_area_buffer, setup_echo_area_for_printing)
2945 (display_echo_area, echo_area_display)
2946 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2947 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2948 (redisplay_window, dump_glyph_row, display_mode_line)
2949 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2950 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2952 (handle_single_display_spec, build_desired_tool_bar_string)
2953 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2954 (get_specified_cursor_type):
2955 Check that fixnums are in proper range for system types.
2956 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2957 (Flookup_image_map):
2958 Don't assume fixnums fit in int.
2959 (compare_overlay_entries):
2960 Avoid mishandling comparisons due to subtraction overflow.
2961 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2962 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2963 (handle_tool_bar_click):
2964 Use int, not unsigned, since we prefer signed and the signedness
2965 doesn't matter here.
2966 (get_next_display_element, next_element_from_display_vector):
2967 Use int, not EMACS_INT, when int is wide enough.
2968 (start_hourglass): Use duration_to_sec_usec to do proper
2969 overflow checking on durations.
2970 * xfaces.c (Fbitmap_spec_p):
2971 Check that fixnums are in proper range for system types.
2972 (compare_fonts_by_sort_order):
2973 Avoid mishandling comparisons due to subtraction overflow.
2974 (Fx_family_fonts, realize_basic_faces):
2975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2976 (Fx_family_fonts):
2977 Don't assume fixnum fits in int.
2978 Use SAFE_ALLOCA_LISP, not alloca.
2979 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2980 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2981 (face_at_buffer_position, face_for_overlay_string)
2982 (face_at_string_position):
2983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2984 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2985 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2986 (Fx_show_tip):
2987 Check that fixnums are in proper range for system types.
2988 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2989 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 (Fx_change_window_property): Don't assume fixnums fit in int.
2992 * xfont.c (xfont_chars_supported):
2993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2994 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2995 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2997 * xml.c (parse_region):
2998 * xrdb.c (magic_file_p):
2999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3000 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3001 (x_get_local_selection, x_reply_selection_request)
3002 (x_handle_selection_request, wait_for_property_change):
3003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3004 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3005 short is wide enough.
3006 (x_send_client_event): Don't assume fixnum fits in int.
3007 * xterm.c (x_x_to_emacs_modifiers):
3008 Don't assume EMACS_INT overflows nicely into int.
3009 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3010 may come from Lisp.
3011 (handle_one_xevent): NATNUMP can eval its arg twice.
3012 (x_connection_closed):
3013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3014 * xterm.h: Adjust decls to match defn changes elsewhere.
3015 (struct scroll_bar): Use struct vectorlike_header
3016 rather than rolling our own approximation.
3017 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3018
c6574eb5
GM
30192012-05-25 Glenn Morris <rgm@gnu.org>
3020
3021 * lisp.mk (lisp): Update for more files being compiled now.
3022
e8d32c7e
SM
30232012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3024
48def666
SM
3025 * lread.c: Remove `read_pure' which makes no difference.
3026 (read_pure): Remove var.
3027 (unreadpure): Remove function.
3028 (readevalloop): Don't call read_list with -1 flag.
3029 (read1, read_vector): Don't test read_pure any more.
3030 (read_list): Simplify.
3031
e8d32c7e
SM
3032 * fileio.c, character.h: Minor style tweaks.
3033
4b2addb7
DA
30342012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3035
3036 * window.h (clip_changed): Remove useless declaration.
3037
584461b2
JB
30382012-05-22 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3041 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3042
34374650
PE
30432012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Remove src/m/*.
3046 This directory predates autoconf and is no longer needed nowadays.
3047 Move its few remaining bits of functionality to where they're needed.
3048 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3049 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3050 * m/template.h: Remove.
3051 * Makefile.in (M_FILE): Remove. All uses removed.
3052 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3053 * lisp.h (USE_LSB_TAG):
3054 * mem-limits.h (EXCEEDS_LISP_PTR):
3055 Use VAL_MAX, not VALBITS, in #if.
3056 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3057 (EMACS_UINT): Define unconditionally now.
3058 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3059 (BITS_PER_EMACS_INT): New constants, replacing
3060 what used to be in config.h, but not useful in #if.
3061 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3062 define them any more.
3063 (VAL_MAX): New macro.
3064 (VALMASK): Use it.
3065 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3066 BITS_PER_EMACS_INT, in #if.
3067 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3068 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3069 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3070 * s/ms-w32.h (DATA_START):
3071 Move here from removed file m/intel386.h.
3072 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3073 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3074
261cb4bb
PE
30752012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 Assume C89 or later.
3078 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3079 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3080 (xrealloc):
3081 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3082 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3083 * textprop.c, tparam.c (NULL): Remove.
3084 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3085 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3086 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3087 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3088 * xterm.c (input_signal_count): Assume volatile works.
3089
ff23cd9f
KB
30902012-05-21 Ken Brown <kbrown@cornell.edu>
3091
3092 * xgselect.c (xg_select): Fix first argument in call to 'select'
3093 (bug#11508).
3094
1b170bc6
KB
30952012-05-20 Ken Brown <kbrown@cornell.edu>
3096
3097 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3098 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3099
b2f4d39f
KB
31002012-05-19 Ken Brown <kbrown@cornell.edu>
3101
3102 * xfns.c (x_in_use): Remove `static' qualifier.
3103 * xterm.h (x_in_use): Declare.
3104 * xgselect.c: Include xterm.h.
3105 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3106 and `display_arg' (bug#9754).
3107
003fdae2
PE
31082012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3109
9232a6d9
PE
3110 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3111
003fdae2
PE
3112 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3113 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3114
784b56e2
EZ
31152012-05-18 Eli Zaretskii <eliz@gnu.org>
3116
3117 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3118
3119 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3120 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3121
3122 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3123 reference to image_cache->refcount.
3124 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3125
a0a79cde
JL
31262012-05-17 Juri Linkov <juri@jurta.org>
3127
3128 * search.c (Fword_search_regexp, Fword_search_backward)
3129 (Fword_search_forward, Fword_search_backward_lax)
3130 (Fword_search_forward_lax): Move functions to isearch.el
3131 (bug#10145, bug#11381).
3132
b0572523
PE
31332012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3134
3135 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3136
9660f5fc
SM
31372012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3138
3139 * lread.c (init_obarray): Declare Qt and Qnil as special.
3140
4374de83
GM
31412012-05-14 Glenn Morris <rgm@gnu.org>
3142
3143 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3144 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3145
dc44c39a
PE
31462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3147
078c97cb
PE
3148 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3149
dc44c39a
PE
3150 * unexaix.c: Port to more-recent AIX compilers.
3151 (report_error, report_error_1, make_hdr, copy_sym)
3152 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3153 Make arguments const char *, not char *, to avoid violations of C
3154 standard and to fix some AIX warnings reported by Gilles Pion.
3155
e18afed7 31562012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3157
3158 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3159 already have overlays loaded.
3160 (handle_single_display_spec): Before returning without displaying
3161 fringe bitmap, synchronize the bidi iterator with the main display
3162 iterator, by calling iterate_out_of_display_property.
3163 (iterate_out_of_display_property): Detect buffer iteration by
3164 testing that it->string is a Lisp string.
3165 (get_next_display_element): When the current object is exhausted,
3166 and there's something on it->stack, call set_iterator_to_next to
3167 proceed with what's on the stack, instead of returning zero.
3168 (set_iterator_to_next): If called at the end of a Lisp string,
3169 proceed to consider_string_end without incrementing string
3170 position. Don't increment display vector index past the end of
3171 the display vector. (Bug#11417)
c8fb9dc6
EZ
3172 (pos_visible_p): Don't report a position visible when move_it_to
3173 stopped at the last line of window, which happens to be scanned
3174 backwards by the bidi iteration. (Bug#11464)
ac268e67 3175
e18afed7 31762012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3177
3178 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3179 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3180 are on a TTY, and thus unable to display on the fringes.
3181 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3182 so we need to signal to the caller that this is a "replacing"
3183 display spec. This fixes display when the spec is invalid or we
3184 are on a TTY.
3185
e18afed7 31862012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3187
3188 * unexaix.c (make_hdr): Fix typo in prototype.
3189 This bug broke the build on AIX. Problem reported by Gilles Pion.
3190
9d0a235a
MA
31912012-05-14 Michael Albinus <michael.albinus@gmx.de>
3192
3193 * keyboard.c (kbd_buffer_get_event): Read special events also in
3194 batch mode. (Bug#11415)
3195
9e6b06ed
GM
31962012-05-12 Glenn Morris <rgm@gnu.org>
3197
3198 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3199
c1a1d7a3
EZ
32002012-05-12 Eli Zaretskii <eliz@gnu.org>
3201
3202 * lisp.mk (lisp): Add newcomment.elc.
3203
3fe7cdc8
GM
32042012-05-12 Glenn Morris <rgm@gnu.org>
3205
3206 * Makefile.in (MKDIR_P): New, set by configure.
3207 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3208
53f7d2c0
PE
32092012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3210
3211 Remove unused function hourglass_started.
3212 * dispextern.h (hourglass_started):
3213 * w32fns.c (hourglass_started):
3214 * xdisp.c (hourglass_started): Remove.
3215
75aafb17
JB
32162012-05-10 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3219 Update dependencies.
3220
12959e8e
PE
32212012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3222
97107e2e
PE
3223 * xgselect.c (xg_select): Put maxfds+1 into a var.
3224 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3225
12959e8e
PE
3226 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3227
836d29b3
DA
32282012-05-10 Dave Abrahams <dave@boostpro.com>
3229
3230 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3231 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3232
5cb67954
MA
32332012-05-09 Michael Albinus <michael.albinus@gmx.de>
3234
3235 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3236 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3237 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3238 Initialize xd_registered_buses.
3239
3478ec45
PE
32402012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3241
b263a6b0
PE
3242 Untag more efficiently if USE_LSB_TAG.
3243 This is based on a proposal by YAMAMOTO Mitsuharu in
3244 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3245 For an admittedly artificial (nth 8000 longlist) benchmark on
3246 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3247 Emacs's overall text size by 1%.
3248 * lisp.h (XUNTAG): New macro.
3249 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3250 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3251 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3252 * eval.c (Fautoload):
3253 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3254 * frame.h (XFRAME): Use XUNTAG.
3255
3478ec45
PE
3256 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3257 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3258 Remove unportable assumptions about print widths of types like
3259 dbus_uint32_t.
3260 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3261 intptr_t when converting between pointer and integer, to avoid GCC
3262 warnings about wrong width.
3263
666b903b 32642012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3265
3266 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3267 stack for each reader_thread, instead of defaulting to 8MB
3268 determined by the linker. This avoids failures in creating
3269 subprocesses on Windows 7, see the discussion in this thread:
3270 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3271
b120cc17
JC
32722012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3273
3274 Fix up display of the *Minibuf-0* buffer in the mini window.
3275 * keyboard.c (read_char): Don't clear the echo area if there's no
3276 message to clear.
3277 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3278 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3279
9a4b36f8
MA
32802012-05-07 Michael Albinus <michael.albinus@gmx.de>
3281
3282 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3283 batch mode.
3284
e5f9458f
CY
32852012-05-06 Chong Yidong <cyd@gnu.org>
3286
3287 * lisp.mk (lisp): Update.
3288
eceeb5fc 32892012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3290
3291 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3292
71873e2b
SM
32932012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3294
3295 * data.c (PUT_ERROR): New macro.
3296 (syms_of_data): Use it. Add new error type `user-error'.
3297 * undo.c (user_error): New function.
3298 (Fprimitive_undo): Use it.
3299 * print.c (print_error_message): Adjust print style for `user-error'.
3300 * keyboard.c (user_error): New function.
3301 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3302
ab0fa4e4
PE
33032012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 Do not limit current-time-string to years 1000..9999.
3306 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3307 (Fcurrent_time_string): Support any year that is supported by the
3308 underlying localtime representation. Don't use asctime, as it
3309 has undefined behavior for years outside the range -999..9999.
3310
7ed806a7
PE
33112012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 Fix race conditions involving setenv, gmtime, localtime, asctime.
3314 Without this fix, interrupts could mess up code that uses these
3315 nonreentrant functions, since setting TZ invalidates existing
3316 tm_zone or tzname values, and since most of these functions return
3317 pointers to static storage.
3318 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3319 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3320 Grow the critical sections to include not just invoking
3321 localtime/gmtime, but also accessing these functions' results
3322 including their tm_zone values if any, and any related TZ setting.
3323 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3324 so that the struct tm is saved in the critical section.
3325 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3326 motivated by the fact that memory allocation needs to be outside
3327 the critical section.
3328
0c16dfed
DA
33292012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3330
3331 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3332 with RESET_INTERVAL.
3333
3334 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3335 Remove duplicated buffer name initialization.
3336
3f83ace8
JM
33372012-05-02 Jim Meyering <jim@meyering.net>
3338
3339 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3340
c7b8541e
JM
3341 * xfns.c (x_window): Use xstrdup (Bug#11375).
3342
90207a15 33432012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3344
3345 * xdisp.c (pos_visible_p): If already at a newline from the
3346 display string before the 'while' loop, don't walk back the glyphs
3347 from it3.glyph_row. Solves assertion violation when the display
3348 string begins with a newline (egg.el). (Bug#11367)
3349
b593d6a9
AH
33502012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3351
3352 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3353 Move to simple.el.
3354
4737362e
GM
33552012-05-01 Glenn Morris <rgm@gnu.org>
3356
99cf43f9
GM
3357 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3358 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3359 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3360 All were removed before 23.1.
3361
9311dcff
GM
3362 * dispnew.c: Remove HAVE_LIBNCURSES test;
3363 it is always true on relevant platforms.
3364
4d5c6349
GM
3365 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3366 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3367
4737362e
GM
3368 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3369
74dd3a6b
AS
33702012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3371
3372 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3373 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3374 Remove.
3375
13c379ee
PE
33762012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 Do not avoid creating empty evaporating overlays (Bug#9642).
3379 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3380 That is, do not delete an evaporating overlay if it becomes
3381 empty after its bounds are adjusted to fit within its buffer.
3382 This fix caused other problems, and I'm reverting it until we get
3383 to the bottom of them.
3384
a8e7d6d7 33852012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3386
3387 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3388
a8e7d6d7 33892012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3390
3391 * xdisp.c (pos_visible_p): If the window start position is beyond
3392 ZV, start the display from buffer beginning. Prevents assertion
3393 violation in init_iterator when the minibuffer window is scrolled
3394 via the scroll bar.
3395
3396 * window.c (window_scroll_pixel_based): Likewise.
3397
a8e7d6d7 33982012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3399
3400 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3401
a8e7d6d7 34022012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3403
3404 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3405 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3406
a8e7d6d7 34072012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3408
b593d6a9
AH
3409 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3410 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3411
1c6900d9
EZ
34122012-04-26 Eli Zaretskii <eliz@gnu.org>
3413
4c3fa1d9
EZ
3414 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3415 display element, check also the underlying string or buffer
3416 character. (Bug#11341)
3417
1c6900d9
EZ
3418 * w32menu.c: Include w32heap.h.
3419 (add_menu_item): If the call to AppendMenuW (via
3420 unicode_append_menu) fails, disable Unicode menus only if we are
3421 running on Windows 9X/Me.
3422
42bf8205
AS
34232012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3424
3425 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3426 (xgetint): Add missing shift for LSB tags.
3427
b1bac16e
MR
34282012-04-24 Martin Rudalics <rudalics@gmx.at>
3429
3430 * keyboard.c (read_char): Don't wipe echo area for select window
3431 events: These might get delayed via `mouse-autoselect-window'
3432 (Bug#11304).
3433
d69621cc
JB
34342012-04-24 Juanma Barranquero <lekktu@gmail.com>
3435
3436 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3437 manipulation of :loaded-from data.
3438
02fd101b
JB
34392012-04-23 Juanma Barranquero <lekktu@gmail.com>
3440
3441 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3442 now a cons (bug#11311).
3443
888bec30
PE
34442012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3445
89a438bd
PE
3446 Do not create empty overlays with the evaporate property (Bug#9642).
3447 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3448 if it becomes empty after its bounds are adjusted to fit within
3449 its buffer. Without this fix, in a nonempty buffer (let ((o
3450 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3451 yields an empty overlay that has the evaporate property, which is
3452 not supposed to happen.
3453
1068fe4d
PE
3454 Fix minor GTK3 problems found by static checking.
3455 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3456 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3457 (struct _EmacsFixedClass, emacs_fixed_get_type):
3458 Move decls here from emacsgtkfixed.h, since they needn't be public.
3459 (emacs_fixed_get_type): Now static.
3460 (emacs_fixed_class_init): Omit unused local.
3461 (emacs_fixed_child_type): Remove; unused.
3462 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3463 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3464 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3465 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3466 (EMACS_FIXED_GET_CLASS): Remove; unused.
3467 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3468
888bec30
PE
3469 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3470 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3471
de85e130
PE
34722012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3473
d0baac98 3474 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3475 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3476 (__malloc_size_t, __malloc_ptrdiff_t):
3477 Remove. All uses removed, replaced by the definiens if needed,
3478 since we can assume C89 or better now.
3479 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3480 (protect_malloc_state, align, get_contiguous_space)
3481 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3482 (malloc_atfork_handler_child, malloc_enable_thread)
3483 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3484 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3485 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3486 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3487 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3488 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3489 Define using prototypes, not old style.
3490 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3491 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3492 (align): Don't assume that signed integer overflow wraps around.
3493 Omit unused local var.
3494 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3495 (_free_internal_nolock, memalign, mallochook, reallochook):
3496 Omit no-longer-needed casts.
3497 (valloc): Use getpagesize, not __getpagesize.
3498 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3499 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3500
de85e130
PE
3501 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3502
dcbf5805
MA
35032012-04-22 Michael Albinus <michael.albinus@gmx.de>
3504
3505 Move functions from C to Lisp. Make non-blocking method calls
3506 the default. Implement further D-Bus standard interfaces.
3507
3508 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3509 (QCdbus_request_name_allow_replacement)
3510 (QCdbus_request_name_replace_existing)
3511 (QCdbus_request_name_do_not_queue)
3512 (QCdbus_request_name_reply_primary_owner)
3513 (QCdbus_request_name_reply_in_queue)
3514 (QCdbus_request_name_reply_exists)
3515 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3516 (QCdbus_registered_serial, QCdbus_registered_method)
3517 (QCdbus_registered_signal): New Lisp objects.
3518 (XD_DEBUG_MESSAGE): Use sizeof.
3519 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3520 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3521 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3522 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3523 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3524 (xd_signature, xd_append_arg): Allow float for integer types.
3525 (xd_get_connection_references): New function.
b593d6a9
AH
3526 (xd_get_connection_address): Rename from xd_initialize.
3527 Return cached address.
dcbf5805
MA
3528 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3529 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3530 level.
3531 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3532 Return number of refcounts.
dcbf5805
MA
3533 (Fdbus_get_unique_name): Make stronger parameter check.
3534 (Fdbus_message_internal): New defun.
3535 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3536 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3537 (Fdbus_send_signal, Fdbus_register_service)
3538 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3539 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3540 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3541 (Vdbus_compiled_version, Vdbus_runtime_version)
3542 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3543 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3544 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3545 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3546 Adapt docstring.
dcbf5805 3547
52828e02
PE
35482012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3549
da05bc4c
PE
3550 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3551 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3552 Do not assume ptrdiff_t is the same width as 'int'.
3553
52828e02
PE
3554 * alloc.c: Handle unusual debugging option combinations.
3555 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3556 since the two debugging options are incompatible.
3557 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3558 is defined.
3559 (mem_init, mem_insert, mem_insert_fixup):
3560 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3561 (NEED_MEM_INSERT): Remove; no longer needed.
3562
f01769f9
LL
35632012-04-22 Leo Liu <sdl.web@gmail.com>
3564
3565 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3566
5790543d
PE
35672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3568
3569 * sysdep.c [__FreeBSD__]: Minor cleanups.
3570 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3571 Use Emacs indenting style more consistently. Avoid some casts.
3572 Use 'double' consistently rather than mixing 'float' and 'double'.
3573
b91b7e4d
EW
35742012-04-21 Eduard Wiebe <usenet@pusto.de>
3575
b593d6a9
AH
3576 * sysdep.c (list_system_processes, system_process_attributes):
3577 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3578
6114eb15
AS
35792012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3580
3581 * lisp.mk (lisp): Update.
3582
2f38dff7
PE
35832012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3586 It is never used otherwise.
3587
4ae29f89
SM
35882012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3589
3590 * print.c (print_preprocess): Only check print_depth if print-circle
3591 is nil.
3592 (print_object): Check for cycles even when print-circle is nil and
3593 print-gensym is t, but only check print_depth if print-circle is nil.
3594
f30d612a
CY
35952012-04-20 Chong Yidong <cyd@gnu.org>
3596
3597 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3598 set the status to "failed" and ensure that sentinel is run.
3599
c07a4c0b 36002012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3601
3602 * process.c (Fset_process_inherit_coding_system_flag)
3603 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3604 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3605
c07a4c0b 36062012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3607
3608 * xdisp.c (string_buffer_position_lim): Limit starting position to
3609 BEGV.
3610 (set_cursor_from_row): If called for a mode-line or header-line
3611 row, return zero immediately.
3612 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3613 farther than the first row after the header line, if any.
3614 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3615 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3616
c07a4c0b 36172012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3618
4ae29f89
SM
3619 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3620 (bug#11238).
ad3a2b41 3621
c07a4c0b 36222012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36232012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3624
3625 configure: new option --enable-gcc-warnings (Bug#11207)
3626 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3627 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3628 (ALL_CFLAGS): Use new macros rather than old.
3629 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3630 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3631 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3632 -Wunused-result, -Wunused-variable. This should go away once
3633 the Emacs and Gnulib regex code is merged.
3634 (xmalloc, xrealloc): Now static.
3635
aba027e8
PE
36362012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3637
3638 * dired.c (Fsystem_groups): Remove unused local.
3639
e5a36063
GM
36402012-04-17 Glenn Morris <rgm@gnu.org>
3641
3642 * dired.c (Fsystem_users): Doc fix.
3643
316411f0
DA
36442012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3645
3646 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3647 (syms_of_dired): Add them.
3648
9426aba4
PE
36492012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3650
b62a57be
PE
3651 Fix minor alloc.c problems found by static checking.
3652 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3653 New extern decls, to avoid calling undeclared functions.
3654 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3655 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3656 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3657 (NEED_MEM_INSERT): New macro.
3658 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3659 Remove one incorrect comment and fix another.
b62a57be 3660
3539f31f
PE
3661 Fix minor ralloc.c problems found by static checking.
3662 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3663 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3664 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3665 (r_alloc_sbrk): Now static.
3666
a041960a
PE
3667 Improve ralloc.c interface checking.
3668 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3669 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3670 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3671 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3672 [REL_ALLOC]: ... to here, to check interface.
3673 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3674 Remove decls. This fixes an "It stinks!".
3675
9426aba4
PE
3676 * alloc.c (which_symbols): Fix alignment issue / type clash.
3677
d55c12ed
AS
36782012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3679
3680 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3681 (struct Lisp_Misc_Any): Likewise.
3682 (struct Lisp_Free): Likewise.
3683 * alloc.c (union aligned_Lisp_Symbol): Define.
3684 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3685 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3686 (union aligned_Lisp_Misc): Define.
3687 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3688 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3689 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3690
b948ce8b
PE
36912012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3692
3693 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3694 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3695 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3696 * s/netbsd.h, s/sol2-6.h:
3697 Remove definition of GC_MARK_STACK, since the default now works.
3698 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3699 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3700 no longer the default.
3701 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3702
35dc09a1 37032012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3704
35dc09a1
GM
3705 * lread.c (lisp_file_lexically_bound_p):
3706 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3707
35dc09a1
GM
37082012-04-14 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3711 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3712
37132012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * nsterm.m (constrainFrameRect): Always constrain when there is only
3716 one screen (Bug#10962).
3717
bcd86815
KB
37182012-04-13 Ken Brown <kbrown@cornell.edu>
3719
3720 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3721
c25df26e
RT
37222012-04-13 Reuben Thomas <rrt@sc3d.org>
3723
3724 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3725
0fc59f1e
DC
37262012-04-11 Daniel Colascione <dancol@dancol.org>
3727
3728 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3729 against is gone. It's better to use vfork now so that when Cygwin
3730 gains a new, working vfork, we use it automatically (bug#10398).
3731
de8c03dc
SM
37322012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3733
3734 * window.c (save_window_save): Obey window-point-insertion-type.
3735
2f097256
GM
37362012-04-11 Glenn Morris <rgm@gnu.org>
3737
3738 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3739
453b951e
SM
37402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3741
3742 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3743
75f1671a 37442012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3745
3746 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3747 (force_quit_count): New var.
3748 (handle_interrupt): Use it.
3749
2a8ce227
JB
37502012-04-10 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * w32.c (w32_delayed_load): Record the full path of the library
3753 being loaded (bug#10424).
3754
935396c0
GM
37552012-04-09 Glenn Morris <rgm@gnu.org>
3756
05920a43
GM
3757 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3758 not just in the obarray, before snarfing them. (Bug#11036)
3759
935396c0
GM
3760 * Makefile.in ($(leimdir)/leim-list.el):
3761 Pass EMACS rather than BUILT_EMACS.
3762
a18ecafa
TZ
37632012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3764
3765 * process.c (make_process):
3766 * process.h: Add integer `gnutls_handshakes_tried' member to
3767 process struct.
3768
6bbef4e5
JC
3769 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3770 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3771
3772 * gnutls.c (gnutls_log_function2i): Convenience log function.
3773 (emacs_gnutls_read): Use new log functions,
3774 `gnutls_handshakes_tried' process member, and
3775 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3776 attempts per process (connection).
3777
b4d3bc10
CY
37782012-04-09 Chong Yidong <cyd@gnu.org>
3779
3780 * eval.c (Fuser_variable_p, user_variable_p_eh)
3781 (lisp_indirect_variable): Functions deleted.
3782 (Fdefvar): Caller changed.
3783
3784 * callint.c (Finteractive, Fcall_interactively):
3785 * minibuf.c (Fread_variable): Callers changed.
3786
70f4d973
EZ
37872012-04-09 Eli Zaretskii <eliz@gnu.org>
3788
3789 * xdisp.c (set_cursor_from_row): If the display string appears in
3790 the buffer at position that is closer to point than the position
3791 after the display string, display the cursor on the first glyph of
3792 the display string. Fixes cursor display when a 'display' text
3793 property immediately follows invisible text. (Bug#11094)
3794
cb3c2e3e
PE
37952012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 composite.c: use 'double' consistently
3798 * composite.c (get_composition_id): Use 'double' consistently
3799 instead of converting 'float' to 'double' and vice versa; this is
3800 easier to understand and avoids a GCC warning.
3801
fd06db5d
GM
38022012-04-09 Glenn Morris <rgm@gnu.org>
3803
50fe702a
GM
3804 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3805 preparation for dumping it with emacs. (Bug#4789)
3806 (leimdir): New variable.
3807 ($(leimdir)/leim-list.el): New rule.
3808 (emacs$(EXEEXT)): Depend on leim-list.el.
3809
fd06db5d
GM
3810 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3811 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3812 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3813
55c131ee
AS
38142012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3815
3816 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3817 proper alignment.
3818
9209588f
JB
38192012-04-07 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3822 Remove unused local variable.
3823
e3fb2efb
PE
38242012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3825
3826 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3827 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3828 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3829 objects, as mark_maybe_pointer will catch them otherwise.
3830 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3831 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3832
b5385551
PE
38332012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Fix typo that broke non-Windows builds.
3836 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3837
9078ead6
EZ
38382012-04-07 Eli Zaretskii <eliz@gnu.org>
3839
3840 Support building on MS-Windows with libxml2.
3841
3842 * makefile.w32-in (OBJ2): Add xml.$(O).
3843 (GLOBAL_SOURCES): Add xml.c.
3844 ($(BLD)/xml.$(O)): New dependency list.
3845
3846 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3847 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3848 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3849 [!WINDOWSNT]: New macros.
3850 (init_libxml2_functions, libxml2_loaded_p): New functions.
3851 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3852 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3853 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3854 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3855 linked in).
6bbef4e5
JC
3856 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3857 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3858 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3859
3860 * emacs.c: Don't include libxml/parser.h.
3861 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3862 xmlCleanupParser directly.
3863
3864 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3865
3811fdf3
EZ
38662012-04-07 Eli Zaretskii <eliz@gnu.org>
3867
3868 * indent.c (Fvertical_motion): If there is a display string at
3869 point, use it.vpos to compute how many lines to backtrack after
3870 move_it_to point. (Bug#11133)
3871
2f8e16b2
EZ
38722012-04-06 Eli Zaretskii <eliz@gnu.org>
3873
3874 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3875 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3876 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3877 macros related to unification of CJK characters. For the details,
3878 see the discussion following the message here:
3879 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3880
3d439cd1
CY
38812012-04-04 Chong Yidong <cyd@gnu.org>
3882
3883 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3884
8bc53d00
EZ
38852012-04-01 Eli Zaretskii <eliz@gnu.org>
3886
3887 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3888 instead of alloca. (Bug#11138)
3889
3b0512a3
AS
38902012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3891
3892 * w32menu.c (is_simple_dialog): Properly check lisp types.
3893 (Bug#11141)
3894
8427ddd2
EZ
38952012-03-31 Eli Zaretskii <eliz@gnu.org>
3896
979022ef
EZ
3897 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3898 position we get to after a call to move_it_to fails the
3899 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3900 only if we wind up in a string from display property. (Bug#11063)
3901
a6b1c7cc
EZ
3902 * window.c (Fdelete_other_windows_internal): Invalidate the row
3903 and column information about mouse highlight, so that redisplay
3904 restores it after reallocating the glyph matrices. (Bug#7464)
3905
8427ddd2
EZ
3906 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3907 string comes from a `display' text property, use the buffer
3908 position of that property as if we actually saw that position in
3909 the row's glyphs.
697ba24b
EZ
3910 (move_it_by_lines): Remove the assertion that
3911 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3912 violated when there's a before-string at the beginning of a line.
3913 (Bug#11063)
8427ddd2 3914
65a0a738
EZ
39152012-03-30 Eli Zaretskii <eliz@gnu.org>
3916
3917 * xdisp.c (append_space_for_newline): If the default face was
3918 remapped, use the remapped face for the appended newline.
3919 (extend_face_to_end_of_line): Use the remapped default face for
3920 extending the face to the end of the line.
3921 (display_line): Call extend_face_to_end_of_line when the default
3922 face was remapped. (Bug#11068)
3923
581355cc
EZ
39242012-03-29 Eli Zaretskii <eliz@gnu.org>
3925
3926 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3927
e8fc049f
SM
39282012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3931
4fb9a543
GM
39322012-03-27 Glenn Morris <rgm@gnu.org>
3933
3934 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3935 Doc fixes.
3936
679910f1
KH
39372012-03-26 Kenichi Handa <handa@m17n.org>
3938
3939 * dispextern.h (struct glyph): Fix previous change. Change the
3940 bit length of glyphless.ch to 25 (Bug#11082).
3941
90d49b7f
CY
39422012-03-26 Chong Yidong <cyd@gnu.org>
3943
3944 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3945 (command_loop_1): Use it; inhibit selection update for
3946 handle-select-window too (Bug#8996).
3947
f514f6f0
FP
39482012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3949
e8fc049f 3950 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3951
bf43fa51
KH
39522012-03-25 Kenichi Handa <handa@m17n.org>
3953
3954 * dispextern.h (struct glyph): Change the bit length of
3955 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3956
8a0c01dd
EZ
39572012-03-24 Eli Zaretskii <eliz@gnu.org>
3958
3959 * s/ms-w32.h (tzname): Include time.h before redirecting to
3960 _tzname. Fixes the MSVC build. (Bug#9960)
3961
7d1c3a76
AS
39622012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3963
8ed79523
AS
3964 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3965 characters.
3966
7d1c3a76
AS
3967 * xterm.c (XTread_socket): Only modify handling_signal if
3968 !SYNC_INPUT. (Bug#11080)
3969
e99a9b8b
EZ
39702012-03-23 Eli Zaretskii <eliz@gnu.org>
3971
3972 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3973 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3974 when fetching a multibyte character consumes more bytes than
3975 CHAR_BYTES returns, due to unification of CJK characters in
3976 string_char. (Bug#11073)
3977
5063c0e1
TN
39782012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3979
3980 * process.c (wait_reading_process_output): Handle pty disconnect
3981 by refraining from sending oneself a SIGCHLD (bug#10933).
3982
9f851fbd
CY
39832012-03-22 Chong Yidong <cyd@gnu.org>
3984
3985 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3986
5063c0e1 3987 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3988 Mark string as coming from a prefix property.
3989 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3990 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3991
fb5b8aca
CY
39922012-03-21 Chong Yidong <cyd@gnu.org>
3993
3994 * xfaces.c (Vface_remapping_alist): Doc fix.
3995
62356a1b
EZ
39962012-03-20 Eli Zaretskii <eliz@gnu.org>
3997
3998 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3999 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4000 Doc fixes.
62356a1b 4001
025de85b
CY
40022012-03-20 Chong Yidong <cyd@gnu.org>
4003
4004 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4005 to reflect default non-nil value of redisplay-dont-pause.
4006
4827f94e
KH
40072012-03-19 Kenichi Handa <handa@m17n.org>
4008
4009 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4010 it fit in a valid range (Bug#11003).
4011
e50a24a2
EZ
40122012-03-18 Eli Zaretskii <eliz@gnu.org>
4013
4014 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4015 that is not from display property, accept the row as a "cursor
4016 row" if one of the string's character has a non-nil `cursor'
4017 property. Fixes cursor positioning when there are newlines in
4018 overlay strings, e.g. in icomplete.el. (Bug#11035)
4019
9af5ed87
PE
40202012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4023
d1f55f16
CY
40242012-03-12 Chong Yidong <cyd@gnu.org>
4025
4026 * eval.c (inhibit_lisp_code): Rename from
4027 inhibit_window_configuration_change_hook; move from window.c.
4028
4029 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4030 * window.c (run_window_configuration_change_hook)
4031 (syms_of_window): Callers changed.
4032
66c5eebd
CY
40332012-03-11 Chong Yidong <cyd@gnu.org>
4034
413df973
CY
4035 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4036
66c5eebd
CY
4037 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4038
1de11f56
CY
40392012-03-10 Chong Yidong <cyd@gnu.org>
4040
4041 * frame.c (other_visible_frames): Don't assume the selected frame
4042 is visible (Bug#10955).
4043
cae07000
SM
40442012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4045
4046 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4047
89c94350
JD
40482012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4051 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4052 zero (Bug#10954).
4053
999dd333
GM
40542012-03-03 Glenn Morris <rgm@gnu.org>
4055
01a6dcc8 4056 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4057
de0100f2
EZ
40582012-03-02 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4061 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4062 (redisplay_window, next_element_from_string): Fix typos in
4063 comments.
3e441275
EZ
4064 (redisplay_window): Pass to move_it_vertically the margin in
4065 pixels, not in screen lines.
de0100f2 4066
96a72ee9
GM
40672012-03-02 Glenn Morris <rgm@gnu.org>
4068
4069 * buffer.c (buffer-list-update-hook): Doc fix.
4070
312508d7
EZ
40712012-02-29 Eli Zaretskii <eliz@gnu.org>
4072
4073 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4074 push_it before setting up the iterator for the first overlay
4075 string, even if we have an empty string loaded.
4076 (next_overlay_string): If there's an empty string on the iterator
4077 stack, pop the stack. (Bug#10903)
4078
27f3c637
PE
40792012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4082 Suggested by Stefan Monnier in
4083 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4084 * alloc.c (widen_to_Lisp_Object): New static function.
4085 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4086 and widening them to Lisp_Objects. This would work even if
4087 USE_LSB_TAG is defined and wide integers are used, which might
4088 happen in a future version of Emacs.
4089
3c9dfce6
CY
40902012-02-25 Chong Yidong <cyd@gnu.org>
4091
fa74b241
CY
4092 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4093 Doc fix.
4094
3c9dfce6
CY
4095 * xselect.c (Fx_selection_exists_p): Doc fix.
4096 (x_clipboard_manager_save_all): Print an informative message
4097 before saving to clipboard manager.
4098
9486df08
CY
40992012-02-24 Chong Yidong <cyd@gnu.org>
4100
4101 * keyboard.c (process_special_events): Handle all X selection
4102 requests in kbd_buffer, not just the next one (Bug#8869).
4103
f01d3321
CY
41042012-02-23 Chong Yidong <cyd@gnu.org>
4105
4106 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4107 call when setting menu-bar-lines and tool-bar-lines parameters.
4108 (unwind_create_frame_1): New helper function.
4109
4110 * window.c (inhibit_window_configuration_change_hook): New var.
4111 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4112 (syms_of_window): Initialize it.
f01d3321 4113
86b847b6
CY
41142012-02-22 Chong Yidong <cyd@gnu.org>
4115
4116 * xterm.c (x_draw_image_relief): Add missing type check for
4117 Vtool_bar_button_margin (Bug#10743).
4118
a59225b1
CY
41192012-02-21 Chong Yidong <cyd@gnu.org>
4120
4121 * fileio.c (Vfile_name_handler_alist): Doc fix.
4122
4123 * buffer.c (Fget_file_buffer): Protect against invalid file
4124 handler return value.
4125
310f5bd4
PE
41262012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4127
cb3a28cc
PE
4128 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4129 when computing $valmask.
4130
310f5bd4
PE
4131 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4132 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4133 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4134 It's useless in that case, and it can cause problems on hosts
4135 that allocate halves of EMACS_INT values separately.
4136 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4137 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4138 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4139 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4140 it avoids undefined behavior on hosts where shifting right by more
4141 than the word width has undefined behavior.
4142
2375c96a
CY
41432012-02-19 Chong Yidong <cyd@gnu.org>
4144
4145 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4146 (Funhandled_file_name_directory, Ffile_name_as_directory)
4147 (Fdirectory_file_name, Fexpand_file_name)
4148 (Fsubstitute_in_file_name): Protect against invalid file handler
4149 return values (Bug#10845).
4150
3eb49e71
EZ
41512012-02-18 Eli Zaretskii <eliz@gnu.org>
4152
4153 * .gdbinit (pitx): Fix incorrect references to fields of the
4154 iterator stack.
4155
7b926f3f
CY
41562012-02-17 Chong Yidong <cyd@gnu.org>
4157
4158 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4159
11273115
PE
41602012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4163 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4164
c3a70e2b
CY
41652012-02-15 Chong Yidong <cyd@gnu.org>
4166
4167 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4168 marked as special. Also, starting docstrings with * is obsolete.
4169
0ca43699
AS
41702012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4171
4172 * gnutls.c (emacs_gnutls_write): Fix last change.
4173
2e8f3c56
LI
41742012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4175
4176 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4177 send_process.
4178
af70074f
SM
41792012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4180
4181 * keymap.c (Fsingle_key_description): Handle char ranges.
4182
95986d52
CY
41832012-02-12 Chong Yidong <cyd@gnu.org>
4184
afd83bd1
CY
4185 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4186 as that creates a dangerous corner case.
4187
95986d52
CY
4188 * window.c (Fdelete_window_internal): Invalidate the mouse
4189 highlight (Bug#9904).
4190
bd7da63e
GM
41912012-02-12 Glenn Morris <rgm@gnu.org>
4192
4193 * xselect.c (Fx_own_selection_internal)
4194 (Fx_get_selection_internal, Fx_disown_selection_internal)
4195 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4196 * nsselect.m (Fx_own_selection_internal)
4197 (Fx_disown_selection_internal, Fx_selection_exists_p)
4198 (Fx_selection_owner_p, Fx_get_selection_internal):
4199 Sync docs and argument specs with the xselect.c versions.
4200
77abcbc2
LI
42012012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4202
4203 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4204
90b671e2
EZ
42052012-02-11 Eli Zaretskii <eliz@gnu.org>
4206
1c0ca0b7
EZ
4207 * w32select.c (Fx_selection_exists_p): Sync doc string and
4208 argument list with xselect.c. (Bug#10783)
4209
4210 * w16select.c (Fx_selection_exists_p): Sync doc string and
4211 argument list with xselect.c. (Bug#10783)
90b671e2 4212
49241268
GM
42132012-02-10 Glenn Morris <rgm@gnu.org>
4214
4215 * fns.c (Fsecure_hash): Doc fix.
4216
f998bbe7 42172012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4218
4219 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4220
0992bd9c
CY
42212012-02-07 Chong Yidong <cyd@gnu.org>
4222
4223 * buffer.c (Fbuffer_local_variables)
4224 (buffer_lisp_local_variables): Handle unbound vars correctly;
4225 don't let Qunbound leak into Lisp.
4226
af008560
GM
42272012-02-07 Glenn Morris <rgm@gnu.org>
4228
dd605cc4
GM
4229 * image.c (Fimagemagick_types): Doc fix.
4230
af008560
GM
4231 * image.c (imagemagick-render-type): Change it from a lisp object
4232 to an integer. Move the doc here from the lisp manual.
4233 Treat all values not equal to 0 the same.
4234
1449fa1d
CY
42352012-02-06 Chong Yidong <cyd@gnu.org>
4236
4237 * doc.c (store_function_docstring): Avoid applying docstring of
4238 alias to base function (Bug#2603).
4239
3723ec07
AS
42402012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4241
4242 * .gdbinit (pp1, pv1): Remove redundant defines.
4243 (pr): Use pp.
4244
79c1cc1e
CY
42452012-02-04 Chong Yidong <cyd@gnu.org>
4246
4247 * nsterm.m: Declare a global (Bug#10694).
4248
d7f29f8e
EZ
42492012-02-04 Eli Zaretskii <eliz@gnu.org>
4250
cae07000
SM
4251 * w32.c (get_emacs_configuration_options):
4252 Include --enable-checking, if specified, in the return value.
d7f29f8e 4253
3b95a6f9
MR
42542012-02-04 Martin Rudalics <rudalics@gmx.at>
4255
4256 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4257 after rounding frame sizes. (Bug#9723)
4258
d6fa96a6
EZ
42592012-02-04 Eli Zaretskii <eliz@gnu.org>
4260
4261 * keyboard.c (adjust_point_for_property): Don't position point
4262 before BEGV. (Bug#10696)
4263
df0b2940
PE
42642012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 Handle overflow when computing char display width (Bug#9496).
4267 * character.c (char_width): Return EMACS_INT, not int.
4268 (char_width, c_string_width): Check for overflow when
4269 computing the width; this is possible now that individual
4270 characters can have unbounded width. Problem introduced
4271 by merge from Emacs 23 on 2012-01-19.
4272
6bee44d6
MA
42732012-02-02 Michael Albinus <michael.albinus@gmx.de>
4274
4275 * dbusbind.c (Fdbus_register_method): Mention the return value
4276 :ignore in the docstring.
4277
44f92739
GM
42782012-02-02 Glenn Morris <rgm@gnu.org>
4279
1b9f60cc
GM
4280 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4281
44f92739
GM
4282 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4283 Unconditionally set to t. (Bug#10673)
4284 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4285 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4286 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4287
c5d3843c
KH
42882012-02-02 Kenichi Handa <handa@m17n.org>
4289
4290 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4291 0, do not call append_composite_glyph.
4292
159462d4 42932012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4294
4295 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4296 NULL (Bug#6988).
4297 (x_produce_glyphs): If the component of a composition is a null
4298 string, set it->pixel_width to 1 to avoid zero-width glyph.
4299
78cef877
EZ
43002012-02-01 Eli Zaretskii <eliz@gnu.org>
4301
4302 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4303 first 2 arguments are identical. This makes inserting large
4304 output from a subprocess an order of magnitude faster on
4305 MS-Windows, where all sbrk'ed memory is always contiguous.
4306
97897668
GM
43072012-01-31 Glenn Morris <rgm@gnu.org>
4308
4309 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4310 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4311 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4312
31fd3586
GM
43132012-01-29 Glenn Morris <rgm@gnu.org>
4314
4315 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4316
0e24a8b2
CY
43172012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4318
4319 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4320
cc0adcb0
CY
43212012-01-28 Chong Yidong <cyd@gnu.org>
4322
4323 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4324
acc28cb9
CY
43252012-01-26 Chong Yidong <cyd@gnu.org>
4326
9c69cfb7
CY
4327 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4328
acc28cb9
CY
4329 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4330 repeat counts (Bug#10507).
4331
48da7392
GM
43322012-01-26 Glenn Morris <rgm@gnu.org>
4333
4334 * lread.c (syms_of_lread): Doc fix.
4335
14af5f7f
CY
43362012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4337
4338 * coding.c (encode_designation_at_bol): Change return value to
4339 EMACS_INT.
4340
0b21c100
CY
43412012-01-25 Chong Yidong <cyd@gnu.org>
4342
4343 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4344
3c2907f7
CY
43452012-01-21 Chong Yidong <cyd@gnu.org>
4346
4347 * floatfns.c (Fcopysign): Make the second argument non-optional,
4348 since nil is not allowed anyway.
4349
959ad23f
AS
43502012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4351
4352 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4353 (send_process): Likewise.
4354
34a02f46
MR
43552012-01-19 Martin Rudalics <rudalics@gmx.at>
4356
4357 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4358 (Vwindow_persistent_parameters): Do not use Qstate.
4359 Rewrite doc-strings.
34a02f46 4360
1259009a 43612012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4362
4363 * character.c (char_width): New function.
70d4fdf6
GM
4364 (Fchar_width, c_string_width, lisp_string_width):
4365 Use char_width (Bug#9496).
25ed9e61 4366
6a6ee00d
MR
43672012-01-16 Martin Rudalics <rudalics@gmx.at>
4368
4369 * window.c (Vwindow_persistent_parameters): New variable.
4370 (Fset_window_configuration, save_window_save): Handle persistent
4371 window parameters.
4372
c85efaf7
EZ
43732012-01-14 Eli Zaretskii <eliz@gnu.org>
4374
4375 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4376 thrashing the stack of the thread. (Bug#9087)
4377
5944709e
PE
43782012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4381
e71f5d99
EZ
43822012-01-11 Eli Zaretskii <eliz@gnu.org>
4383
4384 * xdisp.c (rows_from_pos_range): Handle the case where the
4385 highlight ends on a newline. (Bug#10464)
4386 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4387 he end column for display of highlight that ends on a newline
4388 before a R2L line.
4389
ce316182
GM
43902012-01-11 Glenn Morris <rgm@gnu.org>
4391
4392 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4393 from load-path also when installation-directory is nil. (Bug#10208)
4394
5b43da69
GM
43952012-01-10 Glenn Morris <rgm@gnu.org>
4396
74cc8ff9
GM
4397 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4398
7d8d6e4e
GM
4399 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4400 Update template values to be closer to their typical values these days.
5b43da69 4401
a0db8d43
EZ
44022012-01-09 Eli Zaretskii <eliz@gnu.org>
4403
4404 * xdisp.c (rows_from_pos_range): Accept additional argument
4405 DISP_STRING, and accept any glyph in a row whose object is that
4406 string as eligible for mouse highlight. Fixes mouse highlight of
4407 display strings from overlays. (Bug#10464)
4408
9a0115ab 44092012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4410
b9110d6a 4411 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4412 * fileio.c (auto_saving_dir_umask): New static var.
4413 (Fmake_directory_internal): Use it.
4414 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4415 creating the directory. The old code temporarily assigns
4416 too-generous permissions to the directory.
4417 (do_auto_save_eh): Clear it.
b9110d6a 4418 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4419 that the var is always cleared.
4420
6c1bd3f3
EZ
44212012-01-07 Eli Zaretskii <eliz@gnu.org>
4422
4423 * search.c (scan_buffer): Pass character positions to
4424 know_region_cache, not byte positions. (Bug#6540)
4425
069d2b50
L
44262012-01-07 LynX <_LynX@bk.ru> (tiny change)
4427
4428 * w32.c (sys_rename): Report EXDEV when rename of a directory
4429 fails because the target is on another logical disk. (Bug#10284)
4430
75bf0d33
DB
44312012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4432
4433 * xterm.c (x_embed_request_focus): New function.
4434
4435 * xterm.h: Add prototype.
4436
4437 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4438
1c6e5a32
GM
44392012-01-05 Glenn Morris <rgm@gnu.org>
4440
4441 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4442
651e947e
EZ
44432012-01-01 Eli Zaretskii <eliz@gnu.org>
4444
4445 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4446 Load gnutls_transport_set_lowat only if GnuTLS version is below
4447 2.11.1.
4448 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4449 GnuTLS versions below 2.11.1.
4450
3778cdd8
AL
44512011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4452
4453 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4454 to the doc string advising against its use for altering the way
4455 windows are scrolled.
4456
0e5317f7
KH
44572011-12-28 Kenichi Handa <handa@m17n.org>
4458
4459 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4460 coding-system ASCII compatible only when it does not produce BOM
4461 on encoding (Bug#10383).
4462
93d5ca1f
JD
44632011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4464
4465 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4466 can scroll.
4467 (create_and_show_popup_menu): Always use menu_position_func for
4468 Gtk3 (Bug#10361).
4469
ca22b785
AS
44702011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4471
4472 * callint.c (Fcall_interactively): Don't truncate prompt string.
4473
d048e1e6
EZ
44742011-12-23 Eli Zaretskii <eliz@gnu.org>
4475
4476 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4477 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4478 resumed from there (after widening). (Bug#10360)
d048e1e6 4479
5ccaba1f
JD
44802011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4481
4482 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4483
204ee57f
JD
44842011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4485
b81d40f0
JB
4486 * nsterm.m (x_free_frame_resources):
4487 Release f->output_data.ns->miniimage.
204ee57f
JD
4488 (ns_index_color): Fix indentation. Do not retain
4489 color_table->colors[i].
4490
4491 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4492 before returning.
4493
4494 * nsfns.m (x_set_background_color): Assign return value from
4495 ns_index_color to face-background instead of NSColor*.
4496 (ns_implicitly_set_icon_type): Fix indentation.
4497 Change assignment in for loop to comparison.
4498
4499 * emacs.c (ns_pool): New variable.
4500 (main): Assign ns_pool.
4501 (Fkill_emacs): Call ns_release_autorelease_pool.
4502
4503 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4504 autorelease fdesc, release fdAttrs and tdict.
4505 (ns_get_covering_families): Release charset.
4506 (ns_findfonts): Release NSFontDescriptor created with new.
4507 (ns_uni_to_glyphs): Fix indentation.
4508 (setString): Release attrStr before assigning new value.
4509
c803b2b7
JD
45102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4511
678f4426
JD
4512 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4513 and NS_IMPL_COCOA.
4514 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4515 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4516
cd394be1 45172011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4518
5fecd5fc
JD
4519 * nsterm.m (ns_term_init): Subscribe for notifications
4520 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4521 to method trackingNotification in EmacsMenu.
4522
4523 * nsmenu.m (trackingMenu): New variable.
3771cb17 4524 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4525 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4526 from Aquamacs (Bug#7030).
678f4426
JD
4527
45282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4529
c803b2b7
JD
4530 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4531 (symbol_to_nsstring): Fix indentation.
4532 (ns_symbol_to_pb): New function.
cae07000
SM
4533 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4534 (Fns_rotate_cut_buffers_internal): Remove.
4535 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4536 Fns_store_cut_buffer_internal.
4537 (ns_get_foreign_selection, Fx_own_selection_internal)
4538 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4539 (Fns_get_selection_internal, Fns_store_selection_internal):
4540 Use ns_symbol_to_pb and check if return value is nil.
4541 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4542 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4543 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4544 renamed to Sns_store_selection_internal.
4545 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4546 and remove this function.
4547 (ns_handle_selection_clear): Remove, never used.
4548 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4549 here.
4550
e1b01a3a
KB
45512011-12-17 Ken Brown <kbrown@cornell.edu>
4552
4553 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4554 GID is unknown (Bug#10257).
4555
2adb6e85
PE
45562011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4557
4558 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4559 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4560 which caused a build failure on GNU/Linux IA-64. This problem was
4561 introduced by my 2011-10-07 patch.
4562
d1d7b339
JL
45632011-12-15 Juri Linkov <juri@jurta.org>
4564
4565 * image.c (imagemagick_error): New function. (Bug#10112)
4566 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4567 Use `imagemagick_error' where ImageMagick functions return
4568 `MagickFalse'.
4569 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4570 proper order.
4571
100d5755
KH
45722011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4573
4574 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4575 fill background (Bug#8992).
4576
454592a6
MR
45772011-12-13 Martin Rudalics <rudalics@gmx.at>
4578
4579 * window.c (Vwindow_combination_resize)
4580 (Vwindow_combination_limit): Use t instead of non-nil in
4581 doc-strings.
61d4b438
MR
4582 (Vrecenter_redisplay): Add first sentence of doc-string on
4583 separate line.
53524d93 4584 (Frecenter): Fix doc-string typo.
454592a6 4585
3633e3aa
KH
45862011-12-11 Kenichi Handa <handa@m17n.org>
4587
4588 * coding.c (Funencodable_char_position): Pay attention to the
4589 buffer text relocation (Bug#9389).
4590
7b9d523a 45912011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4592
7b9d523a
JD
4593 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4594 gtk_init (Bug#10100).
4595
b73189c6
EZ
45962011-12-10 Eli Zaretskii <eliz@gnu.org>
4597
4598 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4599 IT->string is nil. (Bug#10263)
4600
f7dfe5d6
JD
46012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4602
83faebb4
JD
4603 * nsterm.h (x_free_frame_resources): Declare.
4604
f7dfe5d6
JD
4605 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4606 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4607
4608 * nsterm.h (ns_get_defaults_value): Declare.
4609
4610 * nsterm.m (ns_default): Call ns_get_defaults_value.
4611
7cd4e72c
EZ
46122011-12-09 Eli Zaretskii <eliz@gnu.org>
4613
4614 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4615 (Bug#10170)
4616
b34d7317
YM
46172011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4618
4619 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4620 that where the value of an _OBJC_* symbol points to is in the .bss
4621 section (Bug#10240).
4622
76470ad1
KH
46232011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4624
4625 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4626 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4627
745fff94
KH
46282011-12-08 Kenichi Handa <handa@m17n.org>
4629
4630 * ftfont.c (get_adstyle_property): Fix previous change
4631 (Bug#10233).
4632
6e44397c
JB
46332011-12-07 Juanma Barranquero <lekktu@gmail.com>
4634
4635 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4636 dirs from the default value of EMACSLOADPATH (bug#10208).
4637
7efa6272
GM
46382011-12-07 Glenn Morris <rgm@gnu.org>
4639
4640 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4641 installation and source directories as well. (Bug#10208)
4642
f6fc4d87
CY
46432011-12-06 Chong Yidong <cyd@gnu.org>
4644
4645 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4646
2bf26180
GM
46472011-12-06 Glenn Morris <rgm@gnu.org>
4648
4649 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4650 as an error, not just -1. (Bug#10217)
4651
3a6ad4f0
CY
46522011-12-05 Chong Yidong <cyd@gnu.org>
4653
4654 * keyboard.c (process_special_events): New function.
4655 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4656
75a3b399
PE
46572011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4658
4659 * coding.c (encode_designation_at_bol): Don't use uninitialized
4660 local variable (Bug#9318).
4661
c3c9e25e
KH
46622011-12-05 Kenichi Handa <handa@m17n.org>
4663
4664 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4665 return Qnil (Bug#8046, Bug#10193).
4666
5eb05ea3
KH
46672011-12-05 Kenichi Handa <handa@m17n.org>
4668
4669 * coding.c (encode_designation_at_bol): New args charbuf_end and
4670 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4671 (coding_set_source): Return how many bytes coding->source was
4672 relocated.
4673 (coding_set_destination): Return how many bytes
4674 coding->destination was relocated.
4675 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4676 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4677
46782011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4679
4680 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4681 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4682 macro (Bug#9318).
4683
46842011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4685
4686 The following changes are to fix Bug#9318.
4687
a79703f5 4688 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4689 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4690 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4691 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4692
7dbda6df
JB
46932011-12-05 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * lisp.h (process_quit_flag): Fix external declaration.
4696
6d5eb5b0
SM
46972011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4698
4699 Don't macro-inline non-performance-critical code.
4700 * eval.c (process_quit_flag): New function.
4701 * lisp.h (QUIT): Use it.
4702
a0c3fad0
JD
47032011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4704
4705 * nsfns.m (get_geometry_from_preferences): New function.
4706 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4707
6c07aac2
AS
47082011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4709
4710 * emacs.c (Qkill_emacs): Define.
4711 (syms_of_emacs): Initialize it.
4712 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4713 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4714 (quit_throw_to_read_char): Add parameter `from_signal'.
4715 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4716 * lisp.h (QUIT): Call Fkill_emacs if requested.
4717
c052ead4
JD
47182011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4719
4720 * widget.c (update_wm_hints): Return if wmshell is null.
4721 (widget_update_wm_size_hints): New function.
4722
4723 * widget.h (widget_update_wm_size_hints): Declare.
4724
4725 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4726 widget_update_wm_size_hints (Bug#10104).
4727
9e49252b
EZ
47282011-12-03 Eli Zaretskii <eliz@gnu.org>
4729
4730 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4731 before a newline, prepare the bidi iterator for consuming the
4732 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4733 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4734
02b16839
JL
47352011-12-02 Juri Linkov <juri@jurta.org>
4736
4737 * search.c (Fword_search_regexp): New Lisp function created from
4738 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4739 (Fword_search_backward, Fword_search_forward)
4740 (Fword_search_backward_lax, Fword_search_forward_lax):
4741 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4742 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4743
0068070e
SM
47442011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4745
4746 * fileio.c (Finsert_file_contents): Move after-change-function call
4747 to before the "handled:" label, since all "goto handled" appear in
4748 cases where the *-change-functions have already been properly called
4749 (bug#10117).
4750
3360a3fc
AS
47512011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4752
4753 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4754 waiting for input. (Bug#10169)
4755
73d6c093
EZ
47562011-11-30 Eli Zaretskii <eliz@gnu.org>
4757
4758 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4759 verifies glyph row's hash code--we have just reallocated the
4760 glyphs, so their contents can be complete garbage. (Bug#10164)
4761
febe6bea
JB
47622011-11-30 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4765
801a4313
EZ
47662011-11-30 Eli Zaretskii <eliz@gnu.org>
4767
4768 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4769 attributes are tested _before_ calling verify_row_hash, to protect
4770 against GCC re-ordering of the tests. (Bug#10164)
4771
2b56b87e
JD
47722011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4773
4774 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4775
4776 * xterm.c (handle_one_xevent): Only set async_visible and friends
4777 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4778 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4779 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4780
dbf31225
PE
47812011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4784 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4785 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4786 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4787 All uses changed to use GCPRO1 etc.
4788 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4789 Revert to old implementation (i.e., before 2011-03-11).
4790
1305621b
YM
47912011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4792
4793 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4794 of scroll runs so as to avoid assigning disabled bogus rows and
4795 unnecessary graphics copy operations.
4796
8c9afb46
EZ
47972011-11-27 Eli Zaretskii <eliz@gnu.org>
4798
4799 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4800 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4801 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4802 (malloc, free, realloc, calloc): Redirect to e_* only when
4803 compiling Emacs.
4804
4805 * lisp.h (GCTYPEBITS): Move before first use.
4806 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4807 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4808 this macro definition.
4809
4810 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4811 _MSC_VER.
4812
54e9e3bf
JD
48132011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4814
6d5eb5b0
SM
4815 * gtkutil.c (xg_create_frame_widgets):
4816 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4817 present with Gtk+ 2.0.
4818
83aca1cb
PE
48192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * fileio.c (Finsert_file_contents): Undo previous change; see
4822 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4823
5b76caa4
PE
48242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 Rename locals to avoid shadowing.
4827 * fileio.c (Finsert_file_contents):
4828 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4829 * process.c (wait_reading_process_output):
4830 Rename inner 'proc' to 'p' to avoid shadowing.
4831 Indent for consistency with usual Emacs style.
4832
8c535114
EZ
48332011-11-25 Eli Zaretskii <eliz@gnu.org>
4834
4835 * xdisp.c (redisplay_window): If cursor row is not fully visible
4836 after recentering, and scroll-conservatively is set to a large
4837 number, scroll window by a few more lines to make the cursor fully
4838 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4839 (start_display): Don't move to the next line if the display should
4840 start at a newline that is part of a display vector or an overlay
4841 string. (Bug#10119)
8c535114 4842
fa4fdb5c
JL
48432011-11-24 Juri Linkov <juri@jurta.org>
4844
4845 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4846 after the `MagickPingImage' call. (Bug#10112)
4847
90ec88df
CY
48482011-11-23 Chong Yidong <cyd@gnu.org>
4849
4850 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4851
56e2e794
MR
48522011-11-23 Martin Rudalics <rudalics@gmx.at>
4853
4854 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4855 making another buffer current. (Bug#10114)
4856
b6e64c41
GM
48572011-11-23 Glenn Morris <rgm@gnu.org>
4858
4859 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4860
6b21de18
CY
48612011-11-23 Chong Yidong <cyd@gnu.org>
4862
4863 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4864 using it (Bug#5984).
4865
b12cd789
EZ
48662011-11-22 Eli Zaretskii <eliz@gnu.org>
4867
4868 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4869 and header-lines, as they don't have one computed for them.
4870 (Bug#10098)
4871
4872 * .gdbinit (prow): Make displayed values more self-explaining.
4873 Add row's hash code.
4874
261b6fd4
LMI
48752011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4876
4877 * process.c (wait_reading_process_output): Fix asynchrounous
4878 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4879 (wait_reading_process_output): Add comment and URL.
261b6fd4 4880
e7cfd277
JD
48812011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4882
4883 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4884
a9b9b7f5
CY
48852011-11-21 Chong Yidong <cyd@gnu.org>
4886
4887 * window.c (Fnext_window, Fprevious_window): Doc fix.
4888
b0d15b4f
SM
48892011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4890
4891 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4892
fe7a3057
JB
48932011-11-20 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4896
d2999b1a
MR
48972011-11-20 Martin Rudalics <rudalics@gmx.at>
4898
4899 * window.c (Fset_window_combination_limit): Rename argument
4900 STATUS to LIMIT.
4901 (Vwindow_combination_limit): Remove "status" from doc-string.
4902
d5ff9cd0
AS
49032011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4904
4905 * m/ibms390.h: Remove.
4906 * m/ibms390x.h: Don't include "ibms390.h".
4907
a5bb9bd3
SM
49082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4909
4910 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4911 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4912
cd1181db
JB
49132011-11-20 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * casetab.c (Fset_case_table):
4916 * charset.c (Fcharset_after): Fix typos.
4917
615a3b8d 49182011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4919
17e845af
PE
4920 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4921 Otherwise, valgrind does not work on some platforms.
4922 Problem reported by Andreas Schwab in
6a0bf43d
PE
4923 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4924 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4925 is set, removing the need for VIRT_ADDRESS_VARIES.
4926 (PURE_P): Use a more-efficient implementation that needs just one
4927 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4928 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4929 to 4 (xorl, subq, cmpq, setbe).
4930 * alloc.c (pure): Always extern now, since that's the
4931 VIRT_ADDR_VARIES behavior.
4932 (PURE_POINTER_P): Use a single comparison, not two, for
4933 consistency with the new puresize.h.
4934 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4935 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4936 Remove VIRT_ADDR_VARIES no longer needed.
4937
f8fe6f96
EZ
49382011-11-19 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4941 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4942 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4943 behave as if the cursor position were at the window margin.
4944
4945 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4946 and the cursor position is out of bounds, behave as if the cursor
4947 position were at the window margin. (Bug#10075)
4948
df05a53c
CY
49492011-11-18 Chong Yidong <cyd@gnu.org>
4950
4951 * window.c (Fwindow_combination_limit): Make first argument
4952 non-optional, since it is meaningless for live windows like the
4953 selected window.
61ccba97 4954
2071918e
DA
49552011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4956
4957 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4958
b50a28de
SM
49592011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4960
4961 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4962 (graft_intervals_into_buffer): Simplify.
4963
015137db
EZ
49642011-11-18 Eli Zaretskii <eliz@gnu.org>
4965
4966 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4967 hash values of the two rows.
4968 (copy_row_except_pointers): Preserve the used[] arrays and the
4969 hash values of the two rows. (Bug#10035)
68c95424 4970 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4971
4972 * xdisp.c (row_hash): New function, body extracted from
4973 compute_line_metrics.
4974 (compute_line_metrics): Call row_hash, instead of computing the
4975 hash code inline.
4976
4977 * dispnew.c (verify_row_hash): Call row_hash for computing the
4978 hash code of a row, instead of duplicating code from xdisp.c.
4979
4980 * dispextern.h (row_hash): Add prototype.
4981
a2addb04
TH
49822011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4983
4984 * frame.c (delete_frame): Don't delete the terminal when the last
4985 X frame is closed if emacs is built with GTK toolkit.
4986
df85d315
JB
49872011-11-17 Juanma Barranquero <lekktu@gmail.com>
4988
4989 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4990
a0c2d0ae
MR
49912011-11-17 Martin Rudalics <rudalics@gmx.at>
4992
4993 * window.c (Vwindow_splits): Rename to
4994 Vwindow_combination_resize. Suggested by Juri Linkov.
4995 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4996 of Vwindow_splits.
4997
58179cce
JB
49982011-11-16 Juanma Barranquero <lekktu@gmail.com>
4999
7877f373
JB
5000 * nsfns.m (Fns_font_name):
5001 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5002
b6f67890
MR
50032011-11-16 Martin Rudalics <rudalics@gmx.at>
5004
5005 * window.h (window): Rename slot "nest" to "combination_limit".
5006 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5007 (Fset_window_nest): Rename to Fset_window_combination_limit.
5008 (Vwindow_nest): Rename to Vwindow_combination_limit.
5009 (recombine_windows, make_parent_window, make_window)
5010 (Fsplit_window_internal, saved_window)
5011 (Fset_window_configuration, save_window_save): Rename all
5012 occurrences of window_nest to window_combination_limit.
5013
c7015153
JB
50142011-11-15 Juanma Barranquero <lekktu@gmail.com>
5015
5016 * image.c (imagemagick_load_image): Fix typo.
5017
322ad6ec
EZ
50182011-11-14 Eli Zaretskii <eliz@gnu.org>
5019
5020 * xdisp.c (display_line): Move the call to
5021 highlight_trailing_whitespace before the call to
5022 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5023 faces of all the glyphs to compute ROW's hash value.
5024 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5025
f067b8ec
JB
50262011-11-14 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5029 just return (bug#10044).
5030
1e5b2111
EZ
50312011-11-12 Eli Zaretskii <eliz@gnu.org>
5032
7ef3cbd5
EZ
5033 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5034 with user-defined heap size. Bump the default size of the temacs
5035 heap to 27MB, to avoid memory warning when running temacs.
5036 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5037
1e5b2111
EZ
5038 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5039 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5040 (verify_row_hash) [XASSERTS]: New function.
5041 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5042 that the hash value of glyph rows is correct.
1e5b2111 5043
89d61221
MR
50442011-11-12 Martin Rudalics <rudalics@gmx.at>
5045
5046 * window.h (window): Remove splits slot.
5047 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5048 (Fdelete_other_windows_internal, make_parent_window)
5049 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5050 (Fset_window_configuration, save_window_save): Don't deal with
5051 split status of windows.
5052 (saved_window): Remove splits slot.
5053 (Vwindow_splits): Rewrite doc-string.
5054
97f18cc8
JD
50552011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5056
5057 * xfns.c (unwind_create_frame):
5058 * nsfns.m (unwind_create_frame):
5059 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5060 Vframe_list (Bug#9999).
5061
22a648b4
DA
50622011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5063
0b381c7e 5064 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5065
659afede
KH
50662011-11-11 Kenichi Handa <handa@m17n.org>
5067
5068 * callproc.c (Fcall_process): Set the member dst_multibyte of
5069 process_coding.
5070
9ac0394b
KH
50712011-11-11 Johan Bockgård <bojohan@gnu.org>
5072
5073 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5074 avoid a crash (bug#9496).
5075
2fbdc249
CY
50762011-11-09 Chong Yidong <cyd@gnu.org>
5077
5078 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5079 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5080
ac6b1f81
PE
50812011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5082
5083 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5084
09db192c
PE
50852011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5086
5087 Avoid some portability problems by eschewing 'extern inline' functions.
5088 The trivial performance wins aren't worth the portability hassles; see
5089 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5090 et seq.
5091 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5092 (window_box_width, window_box_left, window_box_left_offset)
5093 (window_box_right, window_box_right_offset): Undo previous change,
5094 by removing the "extern"s.
5095 * intervals.c (adjust_intervals_for_insertion)
5096 (adjust_intervals_for_deletion): Undo previous change,
5097 making these static again.
5098 (offset_intervals, temp_set_point_both, temp_set_point)
5099 (copy_intervals_to_string): No longer inline.
5100 * xdisp.c (window_text_bottom_y, window_box_width)
5101 (window_box_height, window_box_left_offset)
5102 (window_box_right_offset, window_box_left, window_box_right)
5103 (window_box): No longer inline.
5104
105216ed
CY
51052011-11-08 Chong Yidong <cyd@gnu.org>
5106
5107 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5108 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5109 Signal an error if not a live window.
105216ed
CY
5110 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5111 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5112
ae9e237f
JB
51132011-11-07 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * lisp.h (syms_of_abbrev): Remove declaration.
5116 Reported by CHENG Gao <chenggao@royau.me>.
5117
c7aa8333
EZ
51182011-11-07 Eli Zaretskii <eliz@gnu.org>
5119
5120 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5121 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5122 of temacs in GUI mode.
5123
be7f5545
MR
51242011-11-07 Martin Rudalics <rudalics@gmx.at>
5125
5126 * window.h: Declare delete_all_child_windows instead of
5127 delete_all_subwindows.
5128 * window.c (Fwindow_nest, Fset_window_nest)
5129 (Fset_window_new_total, Fset_window_new_normal)
5130 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5131 (delete_all_subwindows): Rename to delete_all_child_windows.
5132 (Fdelete_other_windows_internal, Fset_window_configuration):
5133 Call delete_all_child_windows instead of delete_all_subwindows.
5134 * frame.c (delete_frame): Call delete_all_child_windows instead
5135 of delete_all_subwindows.
5136
ca78dc43
PE
51372011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5138
5139 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5140 This is also needed for porting to any host where GC_MARK_STACK is
5141 not GC_MAKE_GCPROS_NOOPS.
5142 (which_symbols): Use it.
5143
a0241d01
KH
51442011-11-07 Kenichi Handa <handa@m17n.org>
5145
5146 * coding.c (coding_set_destination): Check coding->src_pos only
5147 when coding->src_object is a buffer (bug#9910).
5148
5149 * process.c (send_process): Set the member src_multibyte of coding
5150 to 0 (bug#9911) when sending a unibyte text.
5151
5152 * callproc.c (Fcall_process): Set the member src_multibyte of
5153 process_coding to 0 (bug#9912).
5154
a64bfdfa 51552011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5156
5157 * xmenu.c (cleanup_widget_value_tree): New function.
5158 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5159 calling free_menubar_widget_value_tree directly (Bug#9830).
5160
cb41b32a
PE
51612011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 Fix some portability problems with 'inline'.
5164 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5165 (window_box_width, window_box_left, window_box_left_offset)
5166 (window_box_right, window_box_right_offset): Declare extern.
5167 Otherwise, these inline functions do not conform to C99 and
5168 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5169 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5170 * intervals.c (adjust_intervals_for_insertion)
5171 (adjust_intervals_for_deletion): Now extern, because otherwise the
5172 extern inline functions 'offset_intervals' couldn't refer to it.
5173 (static_offset_intervals): Remove.
5174 (offset_intervals): Rewrite using the old contents of
5175 static_offset_intervals. The old version didn't conform to C99
5176 because an extern inline function contained a reference to an
5177 identifier with static linkage.
5178
b7041366
AS
51792011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5180
5181 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5182 GC.
5183
88a37c4d
EZ
51842011-11-06 Eli Zaretskii <eliz@gnu.org>
5185
5186 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5187 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5188 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5189 return Qleft_to_right.
5190
49745b39
CY
51912011-11-06 Chong Yidong <cyd@gnu.org>
5192
5193 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5194 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5195 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5196 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5197 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5198 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5199 (Fwindow_vscroll): Doc fix.
5200 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5201 argument, since it makes no sense to pass a live window and for
5202 consistency with window-child.
5203
1f05cd82
CS
52042011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5205
5206 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5207 support MSVC.
5208
22610910
JR
52092011-11-05 Jason Rumney <jasonr@gnu.org>
5210
5211 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5212 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5213 fonts (Bug#6029).
5214 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5215 bitwise arithmetic preventing use of unicode-sip and non-truetype
5216 opentype fonts.
5217
a06776b2
EZ
52182011-11-05 Eli Zaretskii <eliz@gnu.org>
5219
3ad924ba
EZ
5220 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5221 "emacs"-only part.
5222
a06776b2
EZ
5223 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5224 initialization code to keep similarity to xfns.c after changes
5225 from 2011-11-05.
5226
c9e7db78
JD
52272011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5228
a97f8f3f
JD
5229 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5230 (unwind_create_frame): New function (Bug#9943).
5231 (Fx_create_frame): Restructure code to be more similar to the one in
5232 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5233 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5234 Move terminal->reference_count++ just before making the frame official
5235 (Bug#9943).
5236
5237 * nsterm.m (x_free_frame_resources): New function.
5238 (x_destroy_window): Move code to x_free_frame_resources.
5239
c9e7db78 5240 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5241 (Fx_create_frame, x_create_tip_frame):
5242 Move terminal->reference_count++ just before making the frame
75f1671a 5243 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5244 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5245
a6fc3b5c
EZ
52462011-11-05 Eli Zaretskii <eliz@gnu.org>
5247
5248 Support MSVC build with newer versions of Visual Studio.
5249 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5250 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5251 nt/gmake.defs.
5252
5253 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5254 which are not supported by MSVC.
5255 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5256 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5257 bitfields.
5258 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5259 types in bitfields.
5260 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5261
5262 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5263
58179cce 52642011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5265
5266 Support MSVC build with newer versions of Visual Studio.
5267 * w32.c: Don't include w32api.h for MSVC.
5268 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5269
5270 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5271 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5272 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5273 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5274 e_* cousins.
5275 (alloca) [_MSC_VER]: Define to _alloca.
5276
5277 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5278
5279 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5280
a58c13ed
EZ
52812011-11-04 Eli Zaretskii <eliz@gnu.org>
5282
5283 * xdisp.c (note_mouse_highlight): If either of
5284 previous/next-single-property-change returns nil, treat that as
5285 the beginning or the end of the buffer. (Bug#9955)
5286
fe0b6370
JD
52872011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5288
a58c13ed 5289 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5290 label is not null (Bug#9951).
5291 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5292 may be NULL.
5293
89bd5ee1
EZ
52942011-11-04 Eli Zaretskii <eliz@gnu.org>
5295
5296 * window.c (Fwindow_body_size): Mention in the doc string that the
5297 return value is in frame's canonical units. (Bug#9949)
5298
84c3edb9
EZ
52992011-11-03 Eli Zaretskii <eliz@gnu.org>
5300
4e2fb5c7
EZ
5301 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5302
84c3edb9 5303 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5304 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5305 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5306
bc17a887
EZ
53072011-11-01 Eli Zaretskii <eliz@gnu.org>
5308
5309 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5310 Don't stop backward scan on the continuation glyph, even though
5311 its CHARPOS is positive.
6d5eb5b0
SM
5312 (mouse_face_from_buffer_pos, note_mouse_highlight):
5313 Rename cover_string to disp_string.
bc17a887 5314
4ee88440
MR
53152011-11-01 Martin Rudalics <rudalics@gmx.at>
5316
5317 * window.c (temp_output_buffer_show): Don't use
5318 Vtemp_buffer_show_specifiers.
5319 (Vtemp_buffer_show_specifiers): Remove unused variable.
5320
c2ff3c02
EZ
53212011-10-30 Eli Zaretskii <eliz@gnu.org>
5322
5323 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5324 past the beginning of the current glyph matrix.
5325
58179cce 53262011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5327
5328 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5329 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5330 HAVE_GTK3 (Bug#9869).
b77a6a7f 5331
3b574623
JD
5332 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5333 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5334
b77a6a7f
JD
5335 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5336
5337 * xterm.c: Declare x_handle_net_wm_state to return int.
5338 (handle_one_xevent): Check if we are iconified but don't have
5339 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5340 (get_current_wm_state): Return non-zero if not hidden,
5341 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5342 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5343 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5344 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5345
196e41e4
PE
53462011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5349 so that this new function doesn't get optimized away by a
5350 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5351
021f2e1a
AS
53522011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5353
5354 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5355
8b058d44
EZ
53562011-10-29 Eli Zaretskii <eliz@gnu.org>
5357
5358 Fix the `xbytecode' command.
5359 * .gdbinit (xprintbytestr): New command.
b50a28de 5360 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5361 (xbytecode): Print the byte-code string as well.
5362
4452fb80
EZ
53632011-10-29 Kim Storm <storm@cua.dk>
5364
8b058d44
EZ
5365 * alloc.c (which_symbols): New function.
5366
21b72067
AS
53672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5368
5369 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5370 line. (Bug#9903)
5371
83ed7b5c
GM
53722011-10-29 Glenn Morris <rgm@gnu.org>
5373
5374 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5375 Not clear what it was for, and it causes various bugs. (Bug#9839)
5376
5a7a728b
EZ
53772011-10-28 Eli Zaretskii <eliz@gnu.org>
5378
5379 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5380 possible random value that matches one of those tested as
5381 condition to clear the mouse face.
5382
d3d0842f
CY
53832011-10-28 Chong Yidong <cyd@gnu.org>
5384
5385 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5386
31b39d13
DN
53872011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5388
5389 * window.c (make_window): Initialize phys_cursor_on_p.
5390
9aba6043
SM
53912011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * lisp.h (struct Lisp_Symbol): Update comments.
5394
c20992f4
JB
53952011-10-28 Juanma Barranquero <lekktu@gmail.com>
5396
5397 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5398
db4f02f2
EZ
53992011-10-28 Eli Zaretskii <eliz@gnu.org>
5400
5401 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5402 <oslsachem@gmail.com> for helping to debug this.
5403
5404 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5405 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5406 (g_b_init_get_glyph_outline_w): New static variables.
5407 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5408 (GetGlyphOutlineW_Proc): New typedefs.
5409 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5410 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5411 New functions.
5412 (w32font_open_internal, compute_metrics):
5413 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5414 instead of calling the "wide" APIs directly.
5415
5416 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5417
5418 * w32.h (syms_of_w32font): Add prototype.
5419
87e68db4
JB
54202011-10-27 Juanma Barranquero <lekktu@gmail.com>
5421
5422 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5423 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5424 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5425 (Fmove_to_window_line): Doc fix.
5426
435c1d67
CY
54272011-10-27 Chong Yidong <cyd@gnu.org>
5428
5429 * process.c (make_process): Set gnutls_state to NULL.
5430
5431 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5432 non-NULL, regardless of GNUTLS_INITSTAGE.
5433 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5434 an error. Set process slots as soon as we allocate them.
5435
5436 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5437
9c6c6f49
CY
54382011-10-27 Chong Yidong <cyd@gnu.org>
5439
9aba6043
SM
5440 * gnutls.c (emacs_gnutls_deinit): New function.
5441 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5442 (Fgnutls_deinit, Fgnutls_boot): Use it.
5443
5444 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5445 (deactivate_process): Call emacs_gnutls_deinit.
5446
657d08d3
JB
54472011-10-27 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * image.c (x_create_x_image_and_pixmap):
5450 * w32.c (sys_rename, w32_delayed_load):
5451 * w32font.c (fill_in_logfont):
5452 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5453
5430d399
JB
54542011-10-26 Juanma Barranquero <lekktu@gmail.com>
5455
5456 * w32fns.c (w32_default_color_map): New function,
5457 extracted from Fw32_default_color_map.
a7ef684b 5458 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5459
fe0055fa
PE
54602011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5463
e6346438
SM
54642011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5465
5466 * keyboard.c (test_undefined): New function (bug#9751).
5467 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5468
e112cc37
ET
54692011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5470
5471 * sysdep.c (init_sys_modes): Fix the check for the controlling
5472 terminal (Bug#6649).
5473
7b5d6677
EZ
54742011-10-20 Eli Zaretskii <eliz@gnu.org>
5475
5476 * dispextern.h (struct bidi_it): New member next_en_type.
5477
5478 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5479 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5480 current character, check also for next_en_type being WEAK_EN.
5481 (bidi_resolve_weak): Don't enter the expensive loop if the current
5482 position is before next_en_pos. Record the bidi type of the first
5483 non-ET, non-BN character we find, in addition to its position.
5484 (bidi_level_of_next_char): Invalidate next_en_type when
5485 next_en_pos is over-stepped.
5486
7da0b018
PE
54872011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5488
5489 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5490 * editfns.c: Rewrite current-time-zone so that it invokes
5491 the equivalent of (format-time-string "%Z") to get the time zone name.
5492 This fixes a bug when the time zone name contains characters that
5493 need converting from the system time locale to Emacs internal format.
5494 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5495 that patch fixed format-time-string to do the conversion, but
5496 I forgot to fix current-time-zone.
5497 (format_time_string): New function, containing most of
5498 what Fformat_time_string used to contain.
5499 (Fformat_time_string): Rewrite in terms of format_time_string.
5500 This doesn't change this function's behavior.
5501 (current-time-zone): Rewrite to use format_time_string.
5502 This fixes the bug reported by Michael Schierl in
5503 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5504 Jason Rumney's 2007-06-07 change worked around this bug, but
5505 didn't fix it.
5506 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5507
8547b010
EZ
55082011-10-19 Eli Zaretskii <eliz@gnu.org>
5509
5510 * xdisp.c (start_display): If the character at POS is displayed
5511 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5512 (try_window_reusing_current_matrix): If a line ends in a display
5513 vector or the next line starts in a display vector, continue
5514 redrawing the window even though the character position of
5515 start_row was reached.
8547b010
EZ
5516 (Bug#9771, part 2)
5517
4e948d15
CY
55182011-10-18 Chong Yidong <cyd@gnu.org>
5519
5520 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5521 with nobreak-char-display too.
5522
4787455f
EZ
55232011-10-18 Eli Zaretskii <eliz@gnu.org>
5524
5525 Fix part 3 of bug#9771.
5526 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5527 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5528 non-neutral characters if the current character is a paragraph
5529 separator (a.k.a. Newline). This avoids running the same
5530 expensive loop twice, once when we consume the preceding newline
5531 and the other time when the line actually needs to be displayed.
5532 Avoid the loop when we see neutrals on the base embedding level
5533 following a character whose directionality is the same as the
5534 paragraph's. This avoids running the expensive loop when a line
5535 ends in a long sequence of neutrals, like control characters.
5536 Add assertion against STRONG_AL type. Slightly rearrange code
5537 that determines the type of a neutral given the first non-neutral
5538 that follows it.
5539 (bidi_level_of_next_char): Set next_en_pos to zero when
5540 invalidating its info.
5541
2c91f553
EZ
55422011-10-17 Eli Zaretskii <eliz@gnu.org>
5543
5544 * xdisp.c (push_display_prop): Determine whether to record string
5545 or buffer position by IT->string, not by IT->method. Allow
5546 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5547 (move_it_vertically_backward): Don't look for character position
5548 immediately after the newline when in a continuation line.
5549 (Bug#9771, part 1)
2c91f553 5550
c7b08b0d
MR
55512011-10-15 Martin Rudalics <rudalics@gmx.at>
5552
5553 * window.c (coordinates_in_window): Rewrite and delabelize
5554 vertical border check. (Bug#5357) (Bug#9618)
5555
6b02f655
SM
55562011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5557
5558 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5559 errors in XSetWindowBorder (bug#9310).
5560
81d40c92
DA
55612011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5562
5563 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5564 avoid crash when xmalloc overrun checking is enabled.
5565
d4172c3b
EZ
55662011-10-13 Eli Zaretskii <eliz@gnu.org>
5567
5568 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5569 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5570 cursor motion with <left> and <right> arrow keys.
5571
5572 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5573 some callers set that themselves.
5574
b00eea75
EZ
55752011-10-12 Eli Zaretskii <eliz@gnu.org>
5576
5577 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5578 display string and the previous row comes from the same string and
5579 is empty. (Bug#9739) (Bug#9738)
5580
8fe012c4
SM
55812011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5582
5583 * doc.c (get_doc_string): Encode file name (bug#9735).
5584
0074aef2
EZ
55852011-10-12 Eli Zaretskii <eliz@gnu.org>
5586
79beb178
EZ
5587 * bidi.c (bidi_level_of_next_char):
5588 * xdisp.c (get_visually_first_element): Remove old incorrect
5589 comments regarding the Unicode Line Separator character.
5590
0074aef2
EZ
5591 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5592
6e4b3fbe
DA
55932011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5594
5595 * alloc.c (Fgc_status): Do not access beyond zombies array
5596 boundary if nzombies > MAX_ZOMBIES.
5597 * alloc.c (dump_zombies): Add missing format specifier.
5598
0324f3af
PE
55992011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5600
b5525cac
PE
5601 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5602 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5603
0324f3af
PE
5604 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5605 Some packages use them to denote characters with modifiers.
5606
e9b5f888
AS
56072011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5608
5609 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5610 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5611 matching a pp-number. Rename parameter var to var1.
5612
127827c0
SM
56132011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5614
5615 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5616
c8fd3bd0
GM
56172011-10-08 Glenn Morris <rgm@gnu.org>
5618
5619 * callint.c (Fcall_interactively): Give a more explicit error for the
5620 'c' case with a non-character input. (Bug#8479)
5621
352ec8ff
EZ
56222011-10-08 Eli Zaretskii <eliz@gnu.org>
5623
03669ccb
EZ
5624 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5625 lines.
7061c986
EZ
5626 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5627 lines that are hscrolled on the left.
03669ccb 5628
352ec8ff
EZ
5629 * dispnew.c (buffer_posn_from_coords): Account for a possible
5630 presence of header-line. (Bug#4426)
5631
a66cfb1c
SM
56322011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5633
6b02f655
SM
5634 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5635 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5636
7c5ee88e
PE
56372011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5638
5639 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5640 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5641 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5642 this makes Emacs dump core during garbage collection on rare
5643 occasions. sizeof is obviously inferior to offsetof here, so
5644 stick with offsetof.
5645 (GC_POINTER_ALIGNMENT): New macro.
5646 (mark_memory): Omit 3rd (offset) arg; caller changed.
5647 Don't assume EMACS_INT alignment is the same as pointer alignment.
5648
df1bbe5b
SM
56492011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5650
5651 * keyboard.c (read_key_sequence_remapped): New var.
5652 (read_key_sequence): Compute remapping in the right buffer.
5653 (command_loop_1): Use read_key_sequence's remapping directly.
5654
51553db6
SM
56552011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5656
32c1fffd
SM
5657 * dired.c (file_name_completion): Don't expand file name.
5658 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5659 before checking file name handler.
5660
51553db6
SM
5661 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5662 they've been requested explicitly (bug#9591).
5663
b6bd1599 56642011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5665
5666 * keymap.c (Fsingle_key_description): Use make_specified_string
5667 instead of build_string to build string from push_key_description.
5668 (Bug#5193)
5669
f701dc2a
PE
56702011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5671
4222c55d
PE
5672 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5673 This fixes a Y2038 bug on 64-bit hosts.
5674 * buffer.c (reset_buffer):
5675 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5676 (Fclear_buffer_auto_save_failure):
5677 Use 0, not -1, to represent an unset failure time, since time_t
5678 might not be signed.
5679
f701dc2a
PE
5680 Remove dependency on glibc malloc internals.
5681 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5682 Move back here from lisp.h, but with their new implementations.
5683 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5684 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5685 * charset.c (charset_table_init): New static var.
5686 (syms_of_charset): Use it instead of xmalloc. This removes a
5687 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5688 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5689 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5690 Move back to alloc.c.
5691 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5692 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5693
9ceebf39
JD
56942011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5695
5696 * nsterm.m (windowDidResize): Call x_set_window_size only when
5697 ns_in_resize is true. Otherwise set pixelwidth/height and
5698 call change_frame_size (Bug#9628).
5699
cb993c58
PE
57002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5701
3930c88b
PE
5702 Port --enable-checking=all to Fedora 14 x86-64.
5703 * charset.c (syms_of_charset): Also account for glibc malloc's
5704 internal overhead when calculating the initial malloc maximum.
5705
cb993c58
PE
5706 Port --enable-checking=all to Fedora 14 x86.
5707 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5708 Move to lisp.h.
5709 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5710 (overrun_check_realloc, overrun_check_free):
5711 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5712 That way, xmalloc returns a properly-aligned pointer even if
5713 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5714 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5715 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5716 into account when calculating the initial malloc maximum.
5717 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5718 Move here from alloc.c, so that charset.c can use it too.
5719 Properly align; the old code wasn't right for common 32-bit hosts
5720 when configured with --enable-checking=all.
5721 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5722 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5723
31bed486
EZ
57242011-09-29 Eli Zaretskii <eliz@gnu.org>
5725
04c70788 5726 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5727 use EDOM.
5728
fbcaa2f3
EZ
57292011-09-28 Eli Zaretskii <eliz@gnu.org>
5730
5731 * xdisp.c (compute_display_string_end): If there's no display
5732 string at CHARPOS, return -1.
5733
5734 * bidi.c (bidi_fetch_char): When compute_display_string_end
5735 returns a negative value, treat the character as a normal
5736 character not covered by a display string. (Bug#9624)
5737
a239d4e9
JB
57382011-09-28 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * lread.c (Fread_from_string): Fix typo in docstring.
5741
88652fd5
EZ
57422011-09-27 Eli Zaretskii <eliz@gnu.org>
5743
5744 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5745 newline, reseat the iterator instead of bidi-iterating there one
5746 character at a time. (Bug#9610)
32c1fffd
SM
5747 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5748 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5749
ed497dd4
AS
57502011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5751
5752 * lread.c (readevalloop): Use correct code for NBSP.
5753 (read1): Likewise. (Bug#9608)
5754
b2bf61aa
MA
57552011-09-25 Michael Albinus <michael.albinus@gmx.de>
5756
5757 * dbusbind.c (Fdbus_register_signal): When service is not
5758 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5759
32bbb17c
GM
57602011-09-25 Glenn Morris <rgm@gnu.org>
5761
5762 * buffer.c (truncate-lines): Doc fix.
5763
94e0933e
CY
57642011-09-24 Chong Yidong <cyd@stupidchicken.com>
5765
5766 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5767 (Fset_window_next_buffers): Doc fix.
5768
cddde921
GM
57692011-09-24 Glenn Morris <rgm@gnu.org>
5770
5771 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5772
1260aef1
PE
57732011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5774
25b4bfa0
PE
5775 Fix minor problems found by static checking.
5776 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5777 * indent.c (Fvertical_motion): Fix == vs = typo.
5778
e3cbd34b
EZ
57792011-09-24 Eli Zaretskii <eliz@gnu.org>
5780
a66cfb1c
SM
5781 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5782 Default value is now t. Doc fix.
6bf7006f 5783
e3cbd34b 5784 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5785 logic when moving up, not only when moving down. Fix the
e3cbd34b 5786 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5787 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5788
5789 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5790 CHARPOS is covered by a display string which includes newlines.
5791 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5792 is covered by a display string with embedded newlines.
5793
a3de0cbd
MA
57942011-09-24 Michael Albinus <michael.albinus@gmx.de>
5795
5796 * dbusbind.c (Fdbus_register_signal): Add match rule to
5797 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5798 (Fdbus_register_method, Vdbus_registered_objects_table):
5799 Fix docstring.
a3de0cbd 5800
b260039d
JM
58012011-09-24 Jim Meyering <meyering@redhat.com>
5802
32c1fffd 5803 do not ignore write error for any output size
b260039d
JM
5804 The previous change was incomplete.
5805 While it makes emacs --batch detect the vast majority of stdout
5806 write failures, errors were still ignored whenever the output size is
5807 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5808 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5809 && echo FAIL: ignored write error
5810 FAIL: ignored write error
5811 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5812 && echo FAIL: ignored write error
5813 FAIL: ignored write error
5814 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5815
8eca8a7c
AS
58162011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5817
5818 * emacs.c (Fkill_emacs): In noninteractive mode exit
5819 non-successfully if a write error occurred on stdout. (Bug#9574)
5820
3341db62
EZ
58212011-09-21 Eli Zaretskii <eliz@gnu.org>
5822
5823 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5824 the xassert test.
5825
5826 * dispextern.h (struct it): Update the comment documenting what
5827 can it->OBJECT be.
5828
8c203dbf
EZ
58292011-09-20 Eli Zaretskii <eliz@gnu.org>
5830
5831 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5832 a display string, extend search for cursor position to end of row.
5833 (find_row_edges): If the row ends in a newline from a display
5834 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5835 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5836 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5837 non-empty line. Fixes confusing cursor motion with arrow keys at
5838 the beginning of a line that starts with whitespace.
8c203dbf 5839
a4824228
LMI
58402011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5841
5842 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5843 (bug#9493).
5844
33ed493b
CY
58452011-09-18 Chong Yidong <cyd@stupidchicken.com>
5846
5847 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5848 boolean (Bug#9154).
5849
56cd55c8
EZ
58502011-09-18 Eli Zaretskii <eliz@gnu.org>
5851
5852 * xdisp.c (display_line): Record maximum and minimum buffer
5853 positions even if no glyphs were produced (e.g., by a zero-width
5854 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5855 buffer positions that will be removed from the glyph row because
5856 they don't fit.
c02dcedf
EZ
5857 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5858 column is beyond frame width: don't subtract 1 "pixel" when
5859 computing width of the stretch.
3e62b7e0
EZ
5860 (reseat_at_next_visible_line_start): Undo the change made on
5861 2011-09-17 that saved paragraph information and restored it after
5862 the call to `reseat'. (Bug#9545)
56cd55c8 5863
5ed99d36 58642011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5865
5866 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5867 and turn window cursor on if cleared (Bug#9415).
5868
5ed99d36 58692011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5870
5871 * search.c (boyer_moore): Take unibyte characters from pattern
5872 literally. (Bug#9458)
5873
9bade7b2
EZ
58742011-09-18 Eli Zaretskii <eliz@gnu.org>
5875
5876 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5877
e5e9d610
PE
58782011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5879
87e4427a
PE
5880 Fix minor problem found by static checking.
5881 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5882 initialized, to pacify gcc -Wuninitialized.
5883
e5e9d610
PE
5884 * fileio.c: Report proper errno when syscall falls.
5885 (Finsert_file_contents): Save and restore errno,
5886 so that report_file_error outputs the correct diagnostic.
5887 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5888
a1674f0b
EZ
58892011-09-18 Eli Zaretskii <eliz@gnu.org>
5890
5891 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5892
fbfb6dd4
EZ
58932011-09-17 Eli Zaretskii <eliz@gnu.org>
5894
5895 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5896 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5897
bb187662
EZ
58982011-09-17 Eli Zaretskii <eliz@gnu.org>
5899
1137e8b8 5900 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5901 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5902
5903 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5904 (bidi_find_paragraph_start): Search back for paragraph beginning
5905 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5906 (bidi_move_to_visually_next): Only trigger paragraph-related
5907 computations when the last character is a newline or at EOB, not
5908 just any NEUTRAL_B. (Bug#9470)
5909
bb187662
EZ
5910 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5911 truncated lines if point is covered by a display string. (Bug#9524)
5912
2e621251
PE
59132011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5914
5915 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5916 (cons_to_x_long): New function.
5917 (lisp_data_to_selection_data): Use it. Correct the test for
5918 short-versus-long data; it was negated. Break out of vector
5919 loop, for efficiency, when a long datum is discovered.
5920
91a15bc6
SM
59212011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5924
b41c3a35
EZ
59252011-09-16 Eli Zaretskii <eliz@gnu.org>
5926
5927 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5928 GCC PR/17406) by declaring this function with external scope.
5929
7812ba2d
PE
59302011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5933 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5934
cf7edc2a
AS
59352011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5936
5937 * editfns.c (Fformat): Correctly handle text properties on "%%".
5938
bd01620e
EZ
59392011-09-15 Eli Zaretskii <eliz@gnu.org>
5940
5941 * xterm.c (x_draw_composite_glyph_string_foreground):
5942 * w32term.c (x_draw_composite_glyph_string_foreground):
5943 * term.c (encode_terminal_code):
5944 * composite.c (composition_update_it, get_composition_id):
5945 * xdisp.c (get_next_display_element)
5946 (fill_composite_glyph_string): Add comments about special meaning
5947 of TAB characters in a composition.
5948
a02719a3
PE
59492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5952 This occurs when processing a multibyte format.
5953 Problem reported by Wolfgang Jenker.
a02719a3 5954
72589a3c
JB
59552011-09-15 Johan Bockgård <bojohan@gnu.org>
5956
5957 * xdisp.c (try_cursor_movement): Only check for exact match if
5958 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5959
1c14176c
PE
59602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5961
5962 Remove unused external symbols.
5963 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5964 * xdisp.c (calc_pixel_width_or_height): Now static.
5965 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5966 * indent.c (check_display_width):
5967 * w32term.c: Fix comment to match code.
5968 * xterm.c, xterm.h (x_catching_errors): Remove.
5969
d2eea5b5
PE
59702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5971
5972 * xselect.c: Use signed conversions more consistently (Bug#9498).
5973 (selection_data_to_lisp_data): Assume incoming selection data are
5974 signed integers, not unsigned. This is to be consistent with
5975 outgoing selection data, which was modified to use signed integers
5976 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5977 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5978 expects long, not unsigned long.
5979
46888499
EZ
59802011-09-14 Eli Zaretskii <eliz@gnu.org>
5981
5982 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5983 computation of loop end. Reported by Johan Bockgård
5984 <bojohan@gnu.org>.
5985
ef8ef9fb
CY
59862011-09-13 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * frame.c (Fother_visible_frames_p): Function deleted.
5989
fa819fed
EZ
59902011-09-12 Eli Zaretskii <eliz@gnu.org>
5991
5992 * indent.c (compute_motion): Process display vector front to back
5993 rather than the other way around. (Bug#2496)
5994
2ba8e008
SM
59952011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5996
5997 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5998
20f53c69
CY
59992011-09-11 Chong Yidong <cyd@stupidchicken.com>
6000
6001 * minibuf.c (Fread_from_minibuffer): Doc fix.
6002
d562d7a4
EZ
60032011-09-11 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6006 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6007
1c4d7f3d
LMI
60082011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6009
6010 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6011 value for non-existent files.
6012
b885bf36
EZ
60132011-09-11 Eli Zaretskii <eliz@gnu.org>
6014
6015 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6016 set its "size" to -1. This will set the modtime_size field of
6017 the corresponding buffer to -1, which is what
6018 verify-visited-file-modtime expects for files that do not exist.
6019 (Bug#9139)
6020
6612f0bf
PE
60212011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6024 here ...
6025 * lisp.h: ... from here. push_key_description is no longer
6026 defined in keyboard.c, so its declaration should not be in
6027 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6028 logically belongs with push_key_description.
6029
dfb3f755
PE
60302011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6031
6032 * buffer.h: Include <sys/types.h> instead of <time.h>.
6033 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6034 Problem reported by Herbert J. Skuhra.
6035
3134906c
LMI
60362011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6037
6038 * xml.c (parse_region): Make the parsing work for
6039 non-comment-starting XML files again (bug#9144).
6040
8d903f4e
AS
60412011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6042
6043 * image.c (gif_load): Fix calculation of bottom and right corner.
6044 (Bug#9468)
6045
80ad64f4
EZ
60462011-09-10 Eli Zaretskii <eliz@gnu.org>
6047
6048 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6049 redisplay in small windows.
6050
208a048d
EZ
60512011-09-09 Eli Zaretskii <eliz@gnu.org>
6052
6053 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6054
9b1c252e
MR
60552011-09-08 Martin Rudalics <rudalics@gmx.at>
6056
6057 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6058 Operate on live windows only.
6059
2949f33b
JB
60602011-09-08 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6063
e08dcafd
EZ
60642011-09-07 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6067 only under bidi iteration.
6068
115b96bd
JD
60692011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6070
6071 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6072
c8199d0f
PE
60732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6076 Without this fix, the command to link temacs failed due to an
6077 undefined symbol __builtin_isnan. This is because
6078 /usr/include/iso/math_c99.h #defines isnan(x) to
6079 __builtin_isnan(x), but the bundled gcc, which identifies itself
6080 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6081 a __builtin_isnan.
6082 * floatfns.c (isnan): #undef, and then #define to a clone of
6083 what's in data.c.
6084 (Fisnan): Always define, since it's always available now.
6085 (syms_of_floatfns): Always define isnan at the Lisp level.
6086
e39b275c 60872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6088
6089 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6090
b2db44d9 60912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6092
f4af5137 6093 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6094 The previous code assumed that file offsets (off_t values) fit in
6095 EMACS_INT variables, which is not true on typical 32-bit hosts.
6096 The code messed up by falsely reporting buffer overflow in cases
6097 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6098 when "big" contains more than 2**29 bytes, even though this
6099 inserts just one byte and does not overflow the buffer.
6100 (Finsert_file_contents): Store file offsets as off_t
6101 values, not as EMACS_INT values. Check for overflow when
6102 converting between EMACS_INT and off_t. When checking for
6103 buffer overflow or for overlap, take the offsets into account.
6104 Don't use EMACS_INT for small values where int suffices.
6105 When checking for overlap, fix a typo: ZV was used where
6106 ZV_BYTE was intended.
6107 (Fwrite_region): Don't assume off_t fits into 'long'.
6108 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6109
ecfc0a49
MA
61102011-09-05 Michael Albinus <michael.albinus@gmx.de>
6111
6112 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6113
6511acf2 61142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6115
0999621a 6116 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6117
6118 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6119 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6120 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6121 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6122 (modify_event_symbol): Do not assume that the length of
6123 name_alist_or_stem is safe to alloca and fits in int.
6124 (Fexecute_extended_command): Likewise for function name and binding.
6125 (Frecursion_depth): Wrap around reliably on integer overflow.
6126 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6127 since some callers pass EMACS_INT values.
6128 (Fsingle_key_description): Don't crash if symbol name contains more
6129 than MAX_ALLOCA bytes.
6130 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6131 (get_minibuffer): Arg is now EMACS_INT, not int.
6132 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6133 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6134 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6135
2be7d702
PE
6136 * dbusbind.c (signature_cat): New function.
6137 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6138 Do not overrun buffer; instead, report string overflow.
6139
9d1df220
PE
6140 * dispnew.c (add_window_display_history): Don't overrun buffer.
6141 Truncate instead; this is OK since it's just a log.
6142
33ef5c64
PE
6143 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6144 even if the time zone offset is outlandishly large.
6145 Don't mishandle offset == INT_MIN.
6146
66c6fdd5
PE
6147 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6148 when creating daemon; the previous buffer-overflow check was incorrect.
6149
d749b01b
PE
6150 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6151 which has the guts of the old verror function.
6152
b5cd1905
PE
6153 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6154 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6155
6e1a67fb
PE
6156 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6157 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6158 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6159 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6160 length of string rather than counting it via multiple sprintfs;
6161 that's simpler and more reliable.
c21721cc
PE
6162 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6163 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6164 sprintf, in case result does not fit in int.
6165
c57b67fc
PE
6166 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6167 (fontset_from_font): Print it.
6168
8a401434
PE
6169 * frame.c (tty_frame_count): Now printmax_t, not int.
6170 (make_terminal_frame, set_term_frame_name): Print it.
6171 (x_report_frame_params): In X, window IDs are unsigned long,
6172 not signed long, so print them as unsigned.
6173 (validate_x_resource_name): Check for implausibly long names,
6174 and don't assume name length fits in 'int'.
6175 (x_get_resource_string): Don't blindly alloca invocation name;
6176 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6177 not fit in int.
6178
6e1a67fb
PE
6179 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6180 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6181 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6182
0df02bf3
PE
6183 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6184 Use esprintf, not sprintf, in case result does not fit in int.
6185
48e30793
PE
6186 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6187 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6188 it as a large positive number.
6189 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6190 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6191
a66ff6d8
PE
6192 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6193 in case result does not fit in int.
6194
aca216ff
PE
6195 * print.c (float_to_string): Detect width overflow more reliably.
6196 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6197 buffer overrun. Don't assume list length fits in 'int'. Treat
6198 print length of 0 as 0, not as infinity; to be consistent with other
6199 uses of print length in this function. Don't overflow print length
6200 index. Don't assume hash table size fits in 'long', or that
6201 vectorlike size fits in 'unsigned long'.
6202
31c286f7
PE
6203 * process.c (make_process): Use printmax_t, not int, to format
6204 process-name gensyms.
6205
55e5faa1
PE
6206 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6207
80f2e268
PE
6208 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6209 to avoid potential buffer overrun.
6210
670741ab
PE
6211 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6212 if X resource line is longer than 512 bytes.
6213
b7163a50
PE
6214 * xfns.c (x_window): Make sprintf buffer a bit bigger
6215 to avoid potential buffer overrun.
6216
ae58ff1f
PE
6217 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6218
c43c8a6a
PE
6219 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6220
3f8236f4
PE
62212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6222
53e9fe90 6223 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6224 Without these, Emacs silently mishandles large integers sometimes.
6225 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6226 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6227
6511acf2
PE
6228 * xdisp.c (try_window_id): Check Emacs fixnum range before
6229 converting to 'int'.
806add1d 6230
6511acf2 6231 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6232 Check that an Emacs fixnum is in range before assigning it to 'int'.
6233 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6234 values converted from Emacs fixnums.
6235 (Frecenter): Don't wrap around a line count if it is out of 'int'
6236 range; instead, treat it as an extreme value.
6237 (Fset_window_configuration, compare_window_configurations):
6238 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6239
6511acf2
PE
6240 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6241 that can exceed INT_MAX. Check that EMACS_INT value is in range
6242 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6243 (match_limit): Don't assume that a fixnum can fit in 'int'.
6244
6511acf2 6245 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6246 exceed INT_MAX.
6247
6511acf2 6248 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6249 (Fvertical_motion): Don't wrap around LINES values that don't fit
6250 in 'int'. Instead, treat them as extreme values. This is good
6251 enough for windows, which can't have more than INT_MAX lines anyway.
6252
fcb901a7
LMI
62532011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6254
0f2f6b6d
LMI
6255 * Require libxml/parser.h to avoid compilation warning.
6256
fcb901a7
LMI
6257 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6258
6259 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6260 since this reportedly can destroy thread storage.
6261
6e20a0d4
CY
62622011-08-30 Chong Yidong <cyd@stupidchicken.com>
6263
6264 * syntax.c (find_defun_start): Update all cache variables if
6265 exiting early (Bug#9401).
6266
148ae00e
EZ
62672011-08-30 Eli Zaretskii <eliz@gnu.org>
6268
f6cfbd8f
EZ
6269 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6270
148ae00e
EZ
6271 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6272 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6273 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6274
6275 * term.c (tty_append_glyph): New function.
6276 (produce_stretch_glyph): Static function and its prototype deleted.
6277
a66cfb1c
SM
6278 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6279 Add prototypes.
148ae00e 6280
c4a07a4c
PE
62812011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6284 when checking :margin (Bug#9390).
6285 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6286 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6287 so that the name doesn't mislead. All uses changed.
6288
6bc8cd65
JB
62892011-08-28 Johan Bockgård <bojohan@gnu.org>
6290
6291 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6292 set_tty_hooks.
6293
dca4927e
EZ
62942011-08-27 Eli Zaretskii <eliz@gnu.org>
6295
6296 * xdisp.c (move_it_to): Don't bail out early when reaching
6297 position beyond to_charpos, if we are scanning backwards.
6298 (move_it_vertically_backward): When DY == 0, make sure we get to
6299 the first character in the line after the newline.
6300
f2cad773
PE
63012011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6302
6303 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6304 (ccl_driver): Do not generate an out-of-range pointer.
6305 (Fccl_execute_on_string): Remove unnecessary check for
6306 integer overflow, noted by Stefan Monnier in
6307 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6308 Remove a FIXME that didn't need fixing.
6309 Simplify the newly-introduced buffer reallocation code.
6310
0cae2cdb
JB
63112011-08-27 Juanma Barranquero <lekktu@gmail.com>
6312
6313 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6314
5fc295a4 63152011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6316
70c60eb2 6317 Integer and memory overflow issues (Bug#9196).
726e0ab1 6318
d31850da
PE
6319 * doc.c (get_doc_string): Rework so that
6320 get_doc_string_buffer_size is the actual buffer size, rather than
6321 being 1 less than the actual buffer size; this makes xpalloc more
6322 convenient.
6323
a69fbedb
PE
6324 * image.c (x_allocate_bitmap_record, cache_image):
6325 * xselect.c (Fx_register_dnd_atom):
6326 Simplify previous changes by using xpalloc.
6327
fe5c5d37
PE
6328 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6329 since either will do and ptrdiff_t is convenient with xpalloc.
6330
0065d054
PE
6331 * charset.c (charset_table_size)
6332 (struct charset_sort_data.priority): Now ptrdiff_t.
6333 (charset_compare): Don't overflow if priorities differ greatly.
6334 (Fsort_charsets): Don't assume list length fits in int.
6335 Check for size-calculation overflow when allocating sort data.
6336 (syms_of_charset): Allocate an initial charset table that is
6337 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6338
6339 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6340
6341 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6342 The actual value is always <= INT_MAX, and leaving it unsigned made
6343 overflow checking harder.
6344
6345 * dispextern.h (struct glyph_matrix.rows_allocated)
6346 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6347 with xpalloc. The values are still always <= INT_MAX.
6348
6349 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6350
6351 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6352 (SAFE_NALLOCA): New macro.
6353
6354 * region-cache.c (struct boundary.pos, find_cache_boundary)
6355 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6356 (set_cache_region, invalidate_region_cache)
6357 (revalidate_region_cache, know_region_cache, region_cache_forward)
6358 (region_cache_backward, pp_cache):
6359 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6360 so that ptrdiff_t * can be passed to xpalloc.
6361 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6362 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6363 (pp_cache): Don't assume cache_len fits in int.
6364 * region-cache.h: Adjust extern decls to match.
6365
6366 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6367 EMACS_INT, since either will do, for xpalloc.
6368
6369 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6370 (xnmalloc, xnrealloc, xpalloc): New functions.
6371
726e0ab1
PE
6372 * bidi.c (bidi_shelve_header_size): New constant.
6373 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6374 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6375
51f30bc5 6376 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6377 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6378 (overlay_strings):
6379 Don't update size of array until after memory allocation succeeds,
6380 because xmalloc/xrealloc may not return.
0065d054
PE
6381 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6382 now that we have proper integer overflow checking.
6383 (record_overlay_string, overlay_strings): Catch overflows when
6384 calculating size of overlay_str_buf.
726e0ab1 6385
0065d054
PE
6386 * callproc.c (Fcall_process): Check for size overflow when
6387 calculating size of args2.
6388 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6389 Normally we prefer signed values, but sticking with ptrdiff_t would
6390 require adding more-complicated checks.
726e0ab1
PE
6391
6392 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6393 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6394 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6395 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6396
6397 * character.c (Fstring): Check for size-calculation overflow.
6398
6399 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6400 unnecessary integer overflow. Check for size overflow.
6401 (encode_coding_object): Don't update size until xmalloc succeeds.
6402
6403 * composite.c (get_composition_id): Check for overflow in glyph
6404 length calculations.
6405
6406 Integer and memory overflow fixes for display code.
6407 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6408 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6409 (scrolling_window): Check for overflow in size calculations.
6410 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6411 Don't assume glyph table len fits in int.
6412 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6413 (row_table_size): Now ptrdiff_t, not int.
6414 (scrolling_window): Avoid overflow in size calculations.
6415 Don't update size until allocation succeeds.
6416 * fns.c (concat): Check for overflow in size calculations.
6417 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6418 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6419 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6420
6421 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6422 (get_doc_string): Check for size calculation overflow.
6423 Don't update size until allocation succeeds.
6424 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6425 EMACS_INT, where ptrdiff_t will do.
6426 (Fsubstitute_command_keys): Check for string overflow.
6427
6428 * editfns.c (set_time_zone_rule): Don't assume environment length
6429 fits in int.
6430 (message_length): Now ptrdiff_t, not int.
6431 (Fmessage_box): Don't update size until allocation succeeds.
6432 Don't assume message length fits in int.
6433 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6434
0065d054
PE
6435 * emacs.c (main): Do not reallocate argv, since there is a null at
6436 the end that can be overwritten, and this way there's no need to
6437 worry about size-calculation overflow.
6438 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6439
6440 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6441 alloc succeeds.
6442 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6443
6444 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6445 (x_set_scroll_bar_width, x_figure_window_size):
6446 Check for integer overflow.
6447 (x_set_alpha): Do not assume XINT fits in int.
6448
6449 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6450 This is for the members text_lines, text_cols, total_lines, total_cols,
6451 where the system imposes an 'int' limit.
6452
6453 * fringe.c (Fdefine_fringe_bitmap):
6454 Don't update size until alloc works.
6455
6456 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6457 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6458
6459 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6460 Check for size-calculation overflow.
6461 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6462 do, as we prefer signed integers.
6463 (id_to_widget.max_size, id_to_widget.used)
6464 (xg_store_widget_in_map, xg_remove_widget_from_map)
6465 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6466 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6467 Use and return ptrdiff_t, not int.
6468 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6469 * gtkutil.h: Change prototypes to match the above.
6470
6471 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6472 are duplicate now that they've been promoted to lisp.h.
6473 (x_allocate_bitmap_record, x_alloc_image_color)
6474 (make_image_cache, cache_image, xpm_load):
6475 Don't update size until alloc is done.
6476 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6477 (x_detect_edges):
3256efce 6478 Check for size calculation overflow.
726e0ab1
PE
6479 (ct_colors_allocated_max): New constant.
6480 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6481 overflow.
3256efce 6482
726e0ab1
PE
6483 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6484 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6485 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6486 Use ptrdiff_t, not int, to count maps.
6487 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6488 calculations. Don't update size until allocation succeeds.
6489 Redo calculations to avoid overflow.
726e0ab1
PE
6490 * keyboard.h: Change prototypes to match the above.
6491
6492 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6493 to count maps.
6494 (current_minor_maps): Check for size calculation overflow.
6495 * keymap.h: Change prototypes to match the above.
6496
6497 * lread.c (read1, init_obarray): Don't update size until alloc done.
6498
6499 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6500 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6501
726e0ab1
PE
6502 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6503 Now ptrdiff_t, not int.
6504 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6505 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6506
6507 * process.c (Fnetwork_interface_list): Check for overflow
6508 in size calculation.
6509
6510 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6511
6512 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6513 overflow. Don't bother calling xmalloc when xrealloc will do.
6514
6515 * search.c (Freplace_match): Check for size calculation overflow.
6516 (Fset_match_data): Don't assume list lengths fit in 'int'.
6517
6518 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6519 for command line length. Do not attempt to address one before the
6520 beginning of an array, as that's not portable.
6521
6522 * term.c (max_frame_lines): Remove; unused.
6523 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6524 not int.
6525 (encode_terminal_code, calculate_costs): Check for size
6526 calculation overflow.
6527 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6528 table lengths and related sizes. Don't update size until alloc
6529 done. Redo calculations to avoid overflow.
6530 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6531
6532 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6533 subtracting pointers.
6534 (gobble_line): Check for overflow more carefully. Don't update size
6535 until alloc done.
6536
6537 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6538 Don't update size until alloc done.
6539 Redo size calculations to avoid overflow.
6540 Check for size calculation overflow.
0065d054 6541 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6542
6543 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6544 Use ptrdiff_t, not int, for sizes.
6545 (store_mode_line_noprop_char): Don't update size until alloc done.
6546
0065d054
PE
6547 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6548 Use ptrdiff_t, not int, for sizes.
6549 (Finternal_make_lisp_face, cache_face):
6550 Check for size calculation overflow.
6551 (cache_face): Treat size calculation overflows as if they were
6552 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6553
6554 * xfns.c (x_encode_text, x_set_name_internal)
6555 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6556 sizes, since they can exceed INT_MAX in size. Check for size
6557 calculation overflow.
6558
0065d054
PE
6559 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6560 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6561 Don't update size until alloc done.
6562
0065d054 6563 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6564 as sprintf is limited to int lengths.
1d526e2f 6565
252c5ee1
PE
6566 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6567 (X_LONG_MIN): New macros.
864d7ce7
PE
6568 Use them to make the following changes clearer.
6569 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6570 This change doesn't affect the value now, but it may help remind
6571 future maintainers not to raise the value too much later.
6572 (SELECTION_QUANTUM): Remove, replacing with ...
6573 (selection_quantum): ... new function, which avoids overflow.
6574 All uses changed.
6575 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6576 assumption that selection length fits in 'int'.
6577 (x_reply_selection_request, x_handle_selection_request)
6578 (x_get_window_property, receive_incremental_selection)
6579 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6580 (lisp_data_to_selection_data, clean_local_selection_data):
6581 Use ptrdiff_t, not int, to record length of selection.
6582 (x_reply_selection_request, x_get_window_property)
6583 (receive_incremental_selection, x_property_data_to_lisp):
6584 Redo calculations to avoid overflow.
6585 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6586 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6587 something.
6588 (x_get_window_property, receive_incremental_selection)
6589 (lisp_data_to_selection_data, x_property_data_to_lisp):
6590 Check for size-calculation overflow.
6591 (x_get_window_property, receive_incremental_selection)
6592 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6593 Don't store size until memory allocation succeeds.
6594 (x_get_window_property): Plug memory leak on memory exhaustion.
6595 Don't double-block input; malloc is safe here. Don't assume 2**34
6596 - 4 fits in unsigned long. Add an xassert to check
6597 XGetWindowProperty overflow. Be more careful about overflow
6598 calculations, and distinguish size from memory overflow better.
6599 (receive_incremental_selection): When tracing, don't assume
6600 unsigned int is less than INT_MAX.
6601 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6602 harmful) conversions of unsigned short to int.
6603 (lisp_data_to_selection_data): Don't assume that integers
6604 in the range -65535 through -1 fit in an X unsigned short.
6605 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6606 result parameters unless successful. Rely on cons_to_unsigned
6607 to report problems with elements; the old code wasn't right anyway.
6608 (x_check_property_data): Check for int overflow; we cannot use
6609 a wider type due to X limits.
6610 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6611
726e0ab1 6612 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6613
0065d054
PE
6614 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6615 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6616 (x_color_cells): Don't store size until memory allocation succeeds.
6617 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6618 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6619 (x_term_init): Don't assume length fits in int (sprintf is limited
6620 to int size).
bc18e09d 6621
ebfa62c0
PE
6622 Use ptrdiff_t for composition IDs.
6623 * character.c (lisp_string_width):
6624 * composite.c (composition_table_size, n_compositions)
6625 (get_composition_id, composition_gstring_from_id):
6626 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6627 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6628 * window.c (Frecenter):
6629 Use ptrdiff_t, not int, for composition IDs.
6630 * composite.c (get_composition_id): Check for integer overflow.
6631 * composite.h: Adjust prototypes to match the above changes.
6632
d3411f89
PE
6633 Use ptrdiff_t for hash table indexes.
6634 * category.c (hash_get_category_set):
6635 * ccl.c (ccl_driver):
6636 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6637 * coding.c (coding_system_charset_list, detect_coding_system):
6638 * coding.h (struct coding_system.id):
6639 * composite.c (get_composition_id, gstring_lookup_cache):
6640 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6641 * image.c (xpm_get_color_table_h):
6642 * lisp.h (hash_lookup, hash_put):
6643 * minibuf.c (Ftest_completion):
6644 Use ptrdiff_t for hash table indexes, not int (which is too
6645 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6646 32-bit --with-wide-int hosts).
6647
e097a6fa
PE
6648 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6649 Add a FIXME comment about memory leaks.
6650 (syms_of_charset): Don't assume xmalloc returns.
6651
5637687f
PE
6652 Don't assume that stated character widths fit in int.
6653 * character.c (Fchar_width, c_string_width, lisp_string_width):
6654 * character.h (CHAR_WIDTH):
6655 * indent.c (MULTIBYTE_BYTES_WIDTH):
6656 Use sanitize_char_width to avoid undefined and/or bad behavior
6657 with outlandish widths.
a66cfb1c 6658 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6659 now that we have two such functions. All uses changed.
6660 (sanitize_char_width): New inline function.
6661
a2271ba2
PE
6662 Don't assume that tab-width fits in int.
6663 * character.h (sanitize_width): New inline function.
6664 (SANE_TAB_WIDTH): New macro.
6665 (ASCII_CHAR_WIDTH): Use it.
6666 * indent.c (sane_tab_width): Remove. All uses replaced by
6667 SANE_TAB_WIDTH (current_buffer).
6668 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6669
18c52557
PE
6670 * fileio.c: Integer overflow issues with file modes.
6671 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6672
caeeedc1
PE
6673 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6674 Remove unreachable code.
6675 (read_hex, load_charset_map_from_file): Check for integer overflow.
6676
6df6ae42 6677 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6678 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6679 (x_send_scroll_bar_event): Likewise. Check that the size does not
6680 exceed limits imposed by XClientMessageEvent, as well as the usual
6681 ptrdiff_t and size_t limits.
6682
b13995db
PE
6683 * keyboard.c: Overflow, signedness and related fixes.
6684 (make_lispy_movement): Use same integer type in forward decl
6685 that is used in the definition.
6686 (read_key_sequence, keyremap_step):
6687 Change bufsize argument back to int, undoing my 2011-03-30 change.
6688 We prefer signed types, and int is wide enough here.
6689 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6690 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6691 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6692 length, not size_t. Use ptrdiff_t for index, not int.
6693 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6694 possibility of integer overflow.
6695
13464394
PE
6696 Overflow, signedness and related fixes for images.
6697
6698 * dispextern.h (struct it.stack[0].u.image.image_id)
6699 (struct_it.image_id, struct image.id, struct image_cache.size)
6700 (struct image_cache.used, struct image_cache.ref_count):
6701 * gtkutil.c (update_frame_tool_bar):
6702 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6703 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6704 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6705 * nsmenu.m (update_frame_tool_bar):
6706 * xdisp.c (calc_pixel_width_or_height):
6707 * xfns.c (image_cache_refcount):
6708 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6709 on typical 64-bit hosts.
6710
6711 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6712 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6713 Omit unnecessary casts to int.
6714 (parse_image_spec): Check that integers fall into 'int' range
6715 when the callers expect that.
6716 (image_ascent): Redo ascent calculation to avoid int overflow.
6717 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6718 (lookup_image): Remove unnecessary tests.
6719 (xbm_image_p): Locals are now of int, not EMACS_INT,
6720 since parse_image_check makes sure they fit into int.
6721 (png_load, gif_load, svg_load_image):
6722 Prefer int to unsigned where either will do.
6723 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6724 old tiff_error_handler and tiff_warning_handler.
6725 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6726 stack buffer overflows. It uses only the features of vsnprintf
6727 that are common to both POSIX and native Microsoft.
6728 (tiff_error_handler, tiff_warning_handler): Use it.
6729 (tiff_load, gif_load, imagemagick_load_image):
6730 Don't assume :index value fits in 'int'.
6731 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6732 (imagemagick_load_image): Check that crop parameters fit into
6733 the integer types that MagickCropImage accepts. Don't assume
6734 Vimagemagick_render_type has a nonnegative value. Don't assume
6735 size_t fits in 'long'.
6736 (gs_load): Use printmax_t to print the widest integers possible.
6737 Check for integer overflow when computing image height and width.
6738
c11821d4
EZ
67392011-08-26 Eli Zaretskii <eliz@gnu.org>
6740
6741 * xdisp.c (redisplay_window): Don't force window start if point
6742 will be invisible in the resulting window. (Bug#9324)
6743
0c95fcf7
EZ
67442011-08-25 Eli Zaretskii <eliz@gnu.org>
6745
6746 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6747 the display spec is of the form `(space ...)'.
6748 (handle_display_spec): Return the value returned by
6749 handle_single_display_spec, not just 1 or zero.
6750 (handle_single_display_spec): If the display spec is of the form
6751 `(space ...)', and specifies display in the text area, return 2
6752 rather than 1.
fee65a97 6753 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6754 accurately, and prefer exact match for point under bidi.
6755 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6756
6757 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6758 into disp_prop; all users changed.
6759
6760 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6761 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6762 for the text covered by the display property.
6763
e4ed06f1
CY
67642011-08-25 Chong Yidong <cyd@stupidchicken.com>
6765
6766 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6767 Change return value to nil.
6768 (Frecord_buffer): Delete unused function.
6769
f67cdd7f
EZ
67702011-08-24 Eli Zaretskii <eliz@gnu.org>
6771
5980d4c6
EZ
6772 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6773 buffers, return left-to-right.
8610fe8b
EZ
6774 (set_cursor_from_row): Consider candidate row a win if its glyph
6775 represents a newline and point is on that newline. Fixes cursor
6776 positioning on the newline at EOL of R2L text within L2R
6777 paragraph, and vice versa.
6778 (try_cursor_movement): Check continued rows, in addition to
6779 continuation rows. Fixes unwarranted scroll when point enters a
6780 continued line of R2L text within an L2R paragraph, or vice versa.
6781 (cursor_row_p): Consider the case of point being equal to
6782 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6783 from the end of a short line to the beginning of a continued line
6784 of R2L text within L2R paragraph.
6785 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6786 composed characters.
5980d4c6 6787
f67cdd7f
EZ
6788 * bidi.c (bidi_check_type): Use xassert.
6789 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6790 members.
6791
bca633fb
EZ
67922011-08-23 Eli Zaretskii <eliz@gnu.org>
6793
6794 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6795 a character.
6796
4a5885a7
CY
67972011-08-23 Chong Yidong <cyd@stupidchicken.com>
6798
6799 * nsfont.m (ns_otf_to_script): Fix typo.
6800
0902a04e
KH
68012011-08-22 Kenichi Handa <handa@m17n.org>
6802
6803 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6804 extra slot even if the purpose is char-code-property-table.
6805
1a2e6670
EZ
68062011-08-23 Eli Zaretskii <eliz@gnu.org>
6807
8ddde651
EZ
6808 * xdisp.c (redisplay_window): When computing centering_position,
6809 account for the height of the header line. (Bug#8874)
6810
425cc014
EZ
6811 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6812 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6813 candidate is selected by the mouse, and that candidate has a
6814 composed character under the mouse.
6815
1a2e6670
EZ
6816 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6817 coordinates reported by pos-visible-in-window-p for a composed
6818 character in column zero.
6819
8b76d6f8
SM
68202011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6821
6822 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6823
dac347dd
EZ
68242011-08-22 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6827 consider it a hit if to_charpos is anywhere in the range of the
6828 composed buffer positions.
6829
e013fb34
CY
68302011-08-22 Chong Yidong <cyd@stupidchicken.com>
6831
6832 * image.c (gif_load): Don't assume that each subimage has the same
6833 dimensions as the base image. Handle disposal method that is
6834 "undefined" by the gif spec (Bug#9335).
6835
bd1ba3e8
CY
68362011-08-20 Chong Yidong <cyd@stupidchicken.com>
6837
6838 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6839 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6840
54a1215b
EZ
68412011-08-19 Eli Zaretskii <eliz@gnu.org>
6842
823564e5
EZ
6843 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6844 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6845 from an Org mode buffer to a Speedbar frame.
6846
54a1215b
EZ
6847 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6848 a composition, take its buffer position from IT->cmp_it.charpos.
6849 Fixes cursor positioning at the beginning of a line that begins
6850 with a composed character.
6851
9778ebcc
EZ
68522011-08-18 Eli Zaretskii <eliz@gnu.org>
6853
0be6ee06
EZ
6854 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6855 character bidirectional type, use STRONG_L instead. Fixes crashes
6856 in a buffer produced by `describe-categories'.
6857
9778ebcc
EZ
6858 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6859 members before the level stack, so they would be saved and
6860 restored when copying iterator state. Fixes incorrect reordering
6861 around TABs covered by display properties.
6862
156bffbe
AS
68632011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6864
6b02f655 6865 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6866
72ad093b
CY
68672011-08-17 Chong Yidong <cyd@stupidchicken.com>
6868
6869 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6870 (internal_condition_case_2, internal_condition_case_n):
6871 Remove unnecessary aborts (Bug#9081).
72ad093b 6872
35774242
EZ
68732011-08-17 Eli Zaretskii <eliz@gnu.org>
6874
6875 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6876 has no `load' handler, try opening the file locally. (Bug#9311)
6877
db76dd85
KB
68782011-08-16 Ken Brown <kbrown@cornell.edu>
6879
6880 * gmalloc.c: Expand comment.
6881
b215eee5
EZ
68822011-08-16 Eli Zaretskii <eliz@gnu.org>
6883
6884 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6885 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6886
a4579d33
KB
68872011-08-16 Ken Brown <kbrown@cornell.edu>
6888
6889 Fix memory allocation problems in Cygwin build (Bug#9273).
6890
6891 * unexcw.c ( __malloc_initialized): Declare external variable.
6892 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6893
8b76d6f8
SM
6894 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6895 New variables.
a4579d33
KB
6896 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6897 dumped emacs.
6898 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6899 in the static heap.
6900 [CYGWIN] (special_realloc): New function.
6901 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6902 requests to realloc storage in the static heap.
6903
3ebec551
PE
69042011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 * bidi.c (bidi_initialize): Remove unused local.
6907
9fd8be00
EZ
69082011-08-15 Eli Zaretskii <eliz@gnu.org>
6909
6b02f655
SM
6910 * bidimirror.h:
6911 * biditype.h: Remove file.
6912 * makefile.w32-in ($(BLD)/bidi.$(O)):
6913 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6914
6915 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6916
6917 * chartab.c: Improve commentary for the uniprop_table API.
6918
32413314
EZ
6919 * bidi.c (bidi_paragraph_init): Support zero value of
6920 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6921 (bidi_initialize): Use uniprop_table instead of including
6922 biditype.h and bidimirror.h.
32413314 6923
9fd8be00
EZ
6924 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6925 coordinates of the iterator when restoring from ppos_it.
6926 (Bug#9296)
6927
5cf2b69b
KH
69282011-08-14 Kenichi Handa <handa@m17n.org>
6929
6930 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6931 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6932
daf17d00
EZ
69332011-08-14 Eli Zaretskii <eliz@gnu.org>
6934
6935 * xdisp.c (move_it_in_display_line_to): Don't invoke
6936 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6937 ppos_it. Fixes vertical cursor motion when line beginning is
6938 covered by an image. (Bug#9296)
6939
08e3161a
JD
69402011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6941
6942 * nsterm.h (ns_run_ascript): Declare.
6943 (NSAPP_DATA2_RUNASSCRIPT): Define.
6944
6945 * nsfns.m (as_script, as_result, as_status): New static variables.
6946 (ns_run_ascript): New function.
5e617bc2 6947 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6948 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6949 the event loop. Get status from as_status (Bug#7276).
6950
6951 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6952 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6953 the event loop (Bug#7276).
6954
a3720aa2
AS
69552011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6956
6957 * gnutls.c (QCgnutls_bootprop_priority)
6958 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6959 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6960 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6961 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6962 (QCgnutls_bootprop_verify_hostname_error)
6963 (QCgnutls_bootprop_callbacks_verify): Rename from
6964 Qgnutls_bootprop_..., all uses changed.
6965
6966 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6967 uses changed.
6968
0a0d27fb
PE
69692011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6970
19d5c50c
PE
6971 * xfaces.c (Qframe_set_background_mode): Now static.
6972 * dispextern.h (Qframe_set_background_mode): Remove decl.
6973
0a0d27fb
PE
6974 * process.c (Fnetwork_interface_info): Declare local only if needed.
6975
377538cb
JD
69762011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6977
6978 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6979 (Fnetwork_interface_list): Allocate in increments of bytes instead
6980 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6981 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6982 sockaddr.
6983 (struct ifflag_def): notrailers is smart on OSX.
6984 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6985 Get hardware address with getifaddrs if available.
6986
08fff70c
EZ
69872011-08-12 Eli Zaretskii <eliz@gnu.org>
6988
6989 * xdisp.c (iterate_out_of_display_property): xassert that
6990 IT->position is set to within IT->object's boundaries. Break from
6991 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6992 when IT->position is set up wrongly due to some bug.
6993 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6994 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6995 entry. Force push_it to save on the stack the current
6996 buffer/string position, to be restored by pop_it. Fix flags in
6997 the iterator structure wrt the object coming from a display
6998 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6999 properties. (Bug#9284)
7000
7be1c708 70012011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7002
7be1c708
CY
7003 * fontset.c (fontset_get_font_group): Add proper type checks.
7004 (Bug#9172)
aac0c6e3 7005
7be1c708 70062011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7007
7be1c708
CY
7008 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7009 and LC_VERSION_MIN_MACOSX.
7010 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7011 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7012
97bb72a6
EZ
70132011-08-08 Eli Zaretskii <eliz@gnu.org>
7014
7015 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7016 no-display-properties-and-no-overlays under bidi display.
7017 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7018 properties and overlays.
97bb72a6 7019
d5617611
CY
70202011-08-08 Chong Yidong <cyd@stupidchicken.com>
7021
37e11a63
CY
7022 * editfns.c (Fset_time_zone_rule): Document relationship with the
7023 setenv function.
7024
d5617611
CY
7025 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7026 the font entity extracted from the cache (Bug#8109).
7027
58872834
CY
70282011-08-07 Chong Yidong <cyd@stupidchicken.com>
7029
7030 * composite.c (autocmp_chars): Don't reset point. That is done by
7031 restore_point_unwind (Bug#5984).
7032
75bfc667
JL
70332011-08-07 Juri Linkov <juri@jurta.org>
7034
7035 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7036 to show the arg `TIME' instead of `TIMEVAL'.
7037
d1410150
EZ
70382011-08-06 Eli Zaretskii <eliz@gnu.org>
7039
7040 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7041 display property strides EOL and includes a newline, as in
7042 longlines-mode. (Bug#9254)
75b771e4
EZ
7043 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7044 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7045
7046 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7047 is non-zero, even if the data buffer is NULL. Fixes a crash in
7048 vertical-motion with longlines-mode. (Bug#9254)
7049
35928349
EZ
70502011-08-05 Eli Zaretskii <eliz@gnu.org>
7051
ec7cc85b
EZ
7052 * bidi.c <bidi_cache_total_alloc>: Now static.
7053 (bidi_initialize): Initialize bidi_cache_total_alloc.
7054
8b76d6f8 7055 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7056 cache. (Bug#9221)
7057
7058 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7059 amount allocated this far in `bidi_cache_total_alloc'.
7060 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7061 non-zero, only free the data buffer without restoring the cache
7062 contents. All callers changed.
7063
7064 * dispextern.h (bidi_unshelve_cache): Update prototype.
7065
7066 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7067 (move_it_in_display_line, move_it_to)
7068 (move_it_vertically_backward, move_it_by_lines): Replace the call
7069 to xfree to an equivalent call to bidi_unshelve_cache.
7070 (move_it_in_display_line_to): Fix logic of returning
412b6358 7071 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7072
e2e2423b
EZ
70732011-08-05 Eli Zaretskii <eliz@gnu.org>
7074
7075 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7076 came from a string character with a `cursor' property. (Bug#9229)
7077
ae9e757a
JD
70782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7079
7080 * Makefile.in (LIB_PTHREAD): New variable.
7081 (LIBES): Add LIB_PTHREAD (Bug#9216).
7082
7083 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7084 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7085
213bd7f2
AS
70862011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7087
6b02f655 7088 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7089
99aaf75f
JD
70902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7091
7092 * xterm.c (x_find_topmost_parent): New function.
7093 (x_set_frame_alpha): Find topmost parent window with
7094 x_find_topmost_parent and set the property there also (bug#9181).
7095 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7096
c74e9d86
PE
70972011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 * callproc.c (Fcall_process): Avoid vfork clobbering
7100 the local vars buffer, coding_systems, current_dir.
7101
640c8776
SM
71022011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7103
7104 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7105
f26d0e4c
PE
71062011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7107
8a10d76c
PE
7108 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7109 so that it is not optimized away.
7110
f26d0e4c
PE
7111 * xdisp.c (compute_display_string_pos): Remove unused local.
7112
55439c61
EZ
71132011-08-02 Eli Zaretskii <eliz@gnu.org>
7114
7115 Fix slow cursor motion and scrolling in large buffers with
7116 selective display, like Org Mode buffers. (Bug#9218)
7117
7118 * dispextern.h (struct bidi_it): New member disp_prop_p.
7119
7120 * xdisp.c: Remove one-slot cache of display string positions.
7121 (compute_display_string_pos): Accept an additional argument
5e617bc2 7122 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7123 for a display string or property. If found, set DISP_PROP_P
7124 non-zero.
7125
7126 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7127 DISP_PROP_P, and pass it to compute_display_string_pos.
7128 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7129 non-zero. All callers of bidi_fetch_char changed.
7130
fb33fa43
SM
71312011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7132
7133 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7134
b099e063
DM
71352010-12-03 Don March <don@ohspite.net>
7136
7137 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7138 last character M-[char] is translated to ESC [char] (bug#7541).
7139
5cc7f7af
KH
71402011-08-02 Kenichi Handa <handa@m17n.org>
7141
d0fffa3f 7142 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7143
7144 * chartab.c (uniprop_table): Make it non-static.
7145
525d5e6e
EZ
71462011-08-01 Eli Zaretskii <eliz@gnu.org>
7147
7148 * xdisp.c (forward_to_next_line_start): Accept additional argument
7149 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7150 on the newline.
7151 (reseat_at_next_visible_line_start): Use the bidi iterator state
7152 returned by forward_to_next_line_start to restore the state of
7153 it->bidi_it after backing up to previous newline. (Bug#9212)
7154
31011111
AS
71552011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7156
7157 * regex.c (re_comp): Protoize.
7158 (re_exec): Fix return type.
7159 (regexec): Fix type of `ret'. (Bug#9203)
7160
476371c4
PE
71612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7162
e5d76069
PE
7163 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7164 This is needed if max-image-size is a floating-point number.
7165
9a79b20c
AS
71662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7167
7168 * print.c (print_object): Print empty symbol as ##.
7169
7170 * lread.c (read1): Read ## as empty symbol.
7171
d8c2fa78
AA
71722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7173
7174 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7175 setting frame foreground color (Bug#9175).
7176 (x_set_background_color): Likewise.
7177
ffe57a7a
AA
7178 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7179 contents (Bug#9176).
7180 (EmacsTooltip -init): Remove bezels and add shadows to
7181 tooltip windows.
7182
bf3492a5
AA
7183 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7184 or scroll bar (Bug#8470).
7185
d55e9c53
AA
7186 * nsfont.m (nsfont_open): Remove assignment to voffset and
7187 unnecessary vars hshink, expand, hd, full_height, min_height.
7188 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7189
7190 * nsterm.h (nsfont_info): Remove voffset field.
7191
d8c2fa78 71922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7193
7194 Implement strike-through and overline on NextStep (Bug#8863).
7195
7196 * nsfont.m (nsfont_open): Use underline position provided by font,
7197 instead of hard-coded value of 2.
7198 (nsfont_draw): Call ns_draw_text_decoration instead.
7199
7200 * nsterm.h: Add declaration for ns_draw_text_decoration.
7201
7202 * nsterm.m (ns_draw_text_decoration): New function for drawing
7203 underline, overline, and strike-through.
7204 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7205 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7206 accommodate underlining, etc.
4843aac3 7207
4cc60b9b
EZ
72082011-07-28 Eli Zaretskii <eliz@gnu.org>
7209
bc7ece87
EZ
7210 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7211 default.
4cc60b9b 7212
476371c4
PE
72132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7214
66606eea
PE
7215 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7216 Without this fix, if a signal arrives just after memory fills up,
7217 'malloc' might be invoked reentrantly.
7218
476371c4
PE
7219 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7220 In other words, assume that every image size is allowed, on non-X
7221 hosts. This assumption is probably wrong, but it lets Emacs compile.
7222
f3fcc40d
AS
72232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7224
7225 * regex.c (re_iswctype): Convert return values to boolean.
7226
350c992f
EZ
72272011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7228
7229 * xdisp.c (compute_display_string_pos): Don't use cached display
7230 string position if the buffer had its restriction changed.
7231 (Bug#9184)
7232
5266b4bb
PE
72332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7234
7235 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7236
2573a837 72372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7238
41f55ccd 7239 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7240
39e378da
PE
7241 * bidi.c: Integer size and overflow fixes.
7242 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7243 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7244 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7245 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7246 (bidi_find_other_level_edge):
7247 Use ptrdiff_t instead of EMACS_INT where either will do.
7248 This works better on 32-bit hosts configured --with-wide-int.
7249 (bidi_cache_ensure_space): Check for size-calculation overflow.
7250 Use % rather than repeated addition, for better worst-case speed.
7251 Don't set bidi_cache_size until after xrealloc returns, because it
7252 might not return.
7253 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7254 (bidi_cache_ensure_space): Also check that the bidi cache size
7255 does not exceed that of the largest Lisp string or buffer. See Eli
7256 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7257
5e927815
PE
7258 * alloc.c (__malloc_size_t): Remove.
7259 All uses replaced by size_t. See Andreas Schwab's note
7260 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7261
ca4aa935
PE
7262 * image.c: Improve checking for integer overflow.
7263 (check_image_size): Assume that f is nonnull, since
7264 it is always nonnull in practice. This is one less thing to
7265 worry about when checking for integer overflow later.
7266 (x_check_image_size): New function, which checks for integer
7267 overflow issues inside X.
7268 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7269 This removes the need for a memory_full check.
7270 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7271 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7272 (xbm_read_bitmap_data): Change locals back to 'int', since
7273 their values must fit in 'int'.
7274 (xpm_load_image, png_load, tiff_load):
7275 Invoke x_create_x_image_and_pixmap earlier,
7276 to avoid much needless work if the image is too large.
7277 (tiff_load): Treat overly large images as if
7278 x_create_x_image_and_pixmap failed, not as malloc failures.
7279 (gs_load): Use x_check_image_size.
7280
5f8f9cc2
PE
7281 * gtkutil.c: Omit integer casts.
7282 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7283 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7284
5adf60bc
PE
7285 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7286
c8907a93
PE
7287 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7288 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7289 would wrongly return t on a 64-bit host.
7290
e3c25c68
PE
7291 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7292 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7293 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7294 and therefore cause GCC to emit a bogus diagnostic in some cases.
7295
3f791afe
PE
7296 * image.c: Integer signedness and overflow and related fixes.
7297 This is not an exhaustive set of fixes, but it's time to
7298 record what I've got.
7299 (lookup_pixel_color, check_image_size): Remove redundant decls.
7300 (check_image_size): Don't assume that arbitrary EMACS_INT values
7301 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7302 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7303 (tiff_load, imagemagick_load_image):
7304 Check for overflow in size calculations.
7305 (x_create_x_image_and_pixmap): Remove unnecessary test for
7306 xmalloc returning NULL; that can't happen.
7307 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7308 (xpm_color_bucket): Use better integer hashing function.
7309 (xpm_cache_color): Don't possibly over-allocate memory.
7310 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7311 (gif_memory_source):
7312 Use ptrdiff_t, not int or size_t, to record sizes.
7313 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7314 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7315 either works, as we prefer signed integers.
7316 (tiff_read_from_memory, tiff_write_from_memory):
7317 Return tsize_t, not size_t, since that's what the TIFF API wants.
7318 (tiff_read_from_memory): Don't fail simply because the read would
7319 go past EOF; instead, return a short read.
7320 (tiff_load): Omit no-longer-needed casts.
7321 (Fimagemagick_types): Don't assume size fits into 'int'.
7322
3cc5a532
PE
7323 Improve hashing quality when configured --with-wide-int.
7324 * fns.c (hash_string): New function, taken from sxhash_string.
7325 Do not discard information about ASCII character case; this
7326 discarding is no longer needed.
7327 (sxhash-string): Use it. Change sig to match it. Caller changed.
7328 * lisp.h: Declare it.
7329 * lread.c (hash_string): Remove, since we now use fns.c's version.
7330 The fns.c version returns a wider integer if --with-wide-int is
7331 specified, so this should help the quality of the hashing a bit.
7332
b312a492
PE
7333 * emacs.c: Integer overflow minor fix.
7334 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7335 Define only if GNU_LINUX.
7336 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7337
dfd153ae
PE
7338 * dispnew.c: Integer signedness and overflow fixes.
7339 Remove unnecessary forward decls, that were a maintenance hassle.
7340 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7341 All uses changed.
7342 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7343 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7344 (prepare_desired_row, line_draw_cost):
7345 Use int, not unsigned, where either works.
7346 (save_current_matrix, restore_current_matrix):
7347 Use ptrdiff_t, not size_t, where either works.
7348 (init_display): Check for overflow more accurately, and without
7349 relying on undefined behavior.
7350
a81d11a3
PE
7351 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7352 Remove, replacing with the new symbols in lisp.h. All uses changed.
7353 * fileio.c (make_temp_name):
7354 * filelock.c (lock_file_1, lock_file):
7355 * xdisp.c (message_dolog):
7356 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7357 Use pMd etc. instead.
7358 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7359 replacing the pWIDE etc. symbols removed from editfns.c.
7360
3300e6fd
PE
7361 * keyboard.h (num_input_events): Now uintmax_t.
7362 This is (very slightly) less likely to mess up due to wraparound.
7363 All uses changed.
7364
fd05c7e9
PE
7365 * buffer.c: Integer signedness fixes.
7366 (alloc_buffer_text, enlarge_buffer_text):
7367 Use ptrdiff_t rather than size_t when either will do, as we prefer
7368 signed integers.
7369
903fe15d
PE
7370 * alloc.c: Integer signedness and overflow fixes.
7371 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7372 (__malloc_size_t): Default to size_t, not to int.
7373 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7374 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7375 Prefer ptrdiff_t to size_t when either would do, as we prefer
7376 signed integers.
7377 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7378 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7379 Now const. Initialize with values that are in range even if char
7380 is signed.
7381 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7382 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7383 These functions do the right thing with sizes > 2**32.
7384 (check_depth): Now ptrdiff_t, not int.
7385 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7386 Adjust to new way of storing sizes. Check for size overflow bugs
7387 in rest of code.
7388 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7389 slightly wrong anyway, as it missed one instance of
7390 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7391 (refill_memory_reserve): Omit needless cast to size_t.
7392 (mark_object_loop_halt): Mark as externally visible.
7393
ac82cc6a
PE
7394 * xselect.c: Integer signedness and overflow fixes.
7395 (Fx_register_dnd_atom, x_handle_dnd_message):
7396 Use ptrdiff_t, not size_t, since we prefer signed.
7397 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7398 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7399 x_dnd_atoms_size and x_dnd_atoms_length.
7400
c2d1e36d
PE
7401 * doprnt.c: Prefer signed to unsigned when either works.
7402 * eval.c (verror):
7403 * doprnt.c (doprnt):
7404 * lisp.h (doprnt):
7405 * xdisp.c (vmessage):
7406 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7407 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7408 prefer signed arithmetic to avoid comparison confusion.
7409 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7410 but is a bit tricky.
7411
0e926e56
PE
7412 Assume freestanding C89 headers, string.h, stdlib.h.
7413 * data.c, doprnt.c, floatfns.c, print.c:
7414 Include float.h unconditionally.
7415 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7416 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7417 * regex.c: Likewise for stddef.h, string.h.
7418 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7419 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7420 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7421 (STDC_HEADERS): Remove obsolete defines.
7422 * sysdep.c: Include limits.h unconditionally.
7423
9cfdb3ec
PE
7424 Assume support for memcmp, memcpy, memmove, memset.
7425 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7426 * regex.c (memcmp, memcpy):
7427 Remove; we assume C89 now.
7428
7429 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7430 (__malloc_safe_bcopy): Remove; no longer needed.
7431
cf950e6b 7432 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7433 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7434 well either way, and we prefer signed to unsigned.
7435
dbf38e02
LMI
74362011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7437
7438 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7439 closes the connection while we're reading (bug#9182).
7440
d6f0886c 74412011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7442
d6f0886c
JD
7443 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7444 are specified (Bug#9168).
24e0f6b1 7445
2eb1f9e6
PE
74462011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7447
7448 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7449 Found by GCC static checking and --with-wide-int on a 32-bit host.
7450
22381272 74512011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7452
7453 * xdisp.c (compute_display_string_pos): Fix logic of caching
7454 previous display string position. Initialize cached_prev_pos to
7455 -1. Fixes slow-down at the beginning of a buffer.
7456
f25e39b4
EZ
74572011-07-24 Eli Zaretskii <eliz@gnu.org>
7458
7459 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7460 for attrs[LFACE_FONTSET_INDEX].
7461
04c4b52e
PE
74622011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7463
7464 * xml.c (parse_region): Remove unused local
7465 that was recently introduced.
7466
c1734fbd
EZ
74672011-07-23 Eli Zaretskii <eliz@gnu.org>
7468
be18c5a5
EZ
7469 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7470 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7471
c1734fbd
EZ
7472 * xdisp.c (move_it_in_display_line_to): Record the best matching
7473 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7474 exit if none of the characters scanned was an exact match.
7475 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7476 when exact match is impossible due to invisible text, and the
7477 lines are truncated.
7478
a258d627
JD
74792011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7480
7481 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7482 for OSX >= 10.7.
7483
b6d5a689
EZ
74842011-07-22 Eli Zaretskii <eliz@gnu.org>
7485
0f74f785
EZ
7486 Fix a significant slow-down of cursor motion with C-n, C-p,
7487 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7488 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7489 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7490 (next_element_from_buffer): Call compute_stop_pos_backwards to
7491 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7492 base_level_stop.
7493 (reseat): Don't look for prev_stop, as that could mean a very long
7494 run.
7495 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7496 <cached_disp_overlay_modiff>: Cache for last found display string
7497 position.
551918c1 7498 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7499 about the same buffer in the same area of character positions, and
7500 the buffer wasn't changed since the time the display string
7501 position was cached.
551918c1 7502
b2d0c91a
EZ
75032011-07-22 Eli Zaretskii <eliz@gnu.org>
7504
7505 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7506 is an integer, which is important for empty lines. (Bug#9149)
7507
043604ee
CY
75082011-07-22 Chong Yidong <cyd@stupidchicken.com>
7509
7510 * frame.c (Fmodify_frame_parameters): In tty case, update the
7511 default face if necessary (Bug#4238).
7512
da4adb04
CY
75132011-07-21 Chong Yidong <cyd@stupidchicken.com>
7514
7515 * editfns.c (Fstring_to_char): No need to explain what a character
7516 is in the docstring (Bug#6576).
7517
9abd0532
LMI
75182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7519
7520 * xml.c (parse_region): Make sure we always return a tree.
7521
36881d16
HK
75222011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7523
7524 * xml.c (parse_region): If a document contains only comments,
7525 return that, too.
7526
1e98674d
LMI
75272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7528
7529 * xml.c (make_dom): Return comments, too.
7530
590bd467
PE
75312011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7532
7533 Port to OpenBSD.
7534 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7535 and the surrounding thread.
7536 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7537 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7538 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7539 timer goes off.
7540 * s/openbsd.h (BROKEN_SIGIO): Define.
7541 * unexelf.c (unexec) [__OpenBSD__]:
7542 Don't update the .mdebug section of the Alpha COFF symbol table.
7543
f41628b2
LMI
75442011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
7546 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7547 (bug#8460).
7548
b59b67c5
PE
75492011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7550
15e3a074
PE
7551 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7552 This fixes some race conditions on the permissions of any newly
7553 created file.
7554
41bed37d
PE
7555 * alloc.c (valid_pointer_p): Use pipe, not open.
7556 This fixes some permissions issues when debugging.
7557
b59b67c5
PE
7558 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7559 If fchown fails to set both uid and gid, try to set just gid,
7560 as that is sometimes allowed. Adjust the file's mode to eliminate
7561 setuid or setgid bits that are inappropriate if fchown fails.
7562
925a6be7
SM
75632011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7564
7565 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7566 to compare Lisp_Objects.
7567 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7568 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7569 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7570
52968808
AS
75712011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7572
0a6a104b
AS
7573 * lread.c (read_integer): Unread even EOF character.
7574 (read1): Likewise. Properly record start position of symbol.
7575
52968808
AS
7576 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7577 symbol character follows.
7578
9e381cdd
PE
75792011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7580
7581 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7582 This works around a problem with the previous change to Fcopy_file.
7583 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7584 and without this change, GCC might complain about discarding
7585 fchown's return value.
7586
b5641435
JB
75872011-07-16 Juanma Barranquero <lekktu@gmail.com>
7588
7589 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7590
a8031457
PE
75912011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7592
7593 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7594
dd889327
LMI
75952011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7596
750c33f7
LMI
7597 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7598 it's used from the C level.
7599
dd889327
LMI
7600 * process.c: Use the same condition for POLL_FOR_INPUT in both
7601 keyboard.c and process.c (bug#1858).
7602
87e86684
LM
76032011-07-09 Lawrence Mitchell <wence@gmx.li>
7604
7605 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7606 (Fgnutls_boot): Use it.
7607
64348f40
AS
76082011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7609
7610 * doc.c (Fsubstitute_command_keys): Revert last change.
7611
1d698799
LMI
76122011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7613
f863868c
LMI
7614 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7615 quotes the next character, and doesn't affect other longer
7616 sequences (bug#8935).
7617
1d698799
LMI
7618 * lread.c (syms_of_lread): Clarify that is isn't only
7619 `eval-buffer' and `eval-defun' that's affected by
7620 `lexical-binding' (bug#8460).
7621
aa4b6df6
EZ
76222011-07-15 Eli Zaretskii <eliz@gnu.org>
7623
7624 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7625 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7626
5d856da6
PE
76272011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7628
ad6042bb
PE
7629 Fix minor problems found by static checking.
7630 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7631 (elsz): Now a signed constant, not a size_t var. We prefer signed
7632 types to unsigned, to avoid integer comparison confusion. Without
7633 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7634 "cannot optimize loop, the loop counter may overflow", a symptom
7635 of the confusion.
f00bbb22 7636 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7637 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7638
6468f31c
LMI
76392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7640
49080b10
LMI
7641 * search.c (Fre_search_backward): Mention `case-fold-search' in
7642 all the re_search_* functions (bug#8138).
7643
6468f31c
LMI
7644 * keyboard.c (Fopen_dribble_file): Document when the file is
7645 closed (bug#8056).
7646
c965adc5
EZ
76472011-07-14 Eli Zaretskii <eliz@gnu.org>
7648
df9733bf
EZ
7649 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7650 bidi_cache_idx.
7651
0bb23927
EZ
7652 Support bidi reordering of display and overlay strings.
7653 * xdisp.c (compute_display_string_pos)
7654 (compute_display_string_end): Accept additional argument STRING.
7655 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7656 (reseat_to_string): Initialize bidi_it->string.s and
7657 bidi_it->string.schars.
7658 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7659 NULL (avoids a crash in bidi_paragraph_init).
7660 Initialize itb.string.lstring.
0bb23927
EZ
7661 (init_iterator): Call bidi_init_it only of a valid
7662 buffer position was specified. Initialize paragraph_embedding to
7663 L2R.
7664 (reseat_to_string): Initialize the bidi iterator.
7665 (display_string): If we need to ignore text properties of
7666 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7667 original value of -1 will not work with bidi.)
7668 (compute_display_string_pos): First arg is now struct
7669 `text_pos *'; all callers changed. Support display properties on
7670 Lisp strings.
7671 (compute_display_string_end): Support display properties on Lisp
7672 strings.
7673 (init_iterator, reseat_1, reseat_to_string): Initialize the
7674 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7675 when iterating on a string not from display properties).
640c8776
SM
7676 (compute_display_string_pos, compute_display_string_end):
7677 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7678 arrow keys.
7679 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7680 base_level_stop; instead, set base_level_stop to BEGV.
7681 Fixes crashes in vertical-motion.
0bb23927
EZ
7682 (next_element_from_buffer): Improve commentary for when
7683 the iterator is before prev_stop.
7684 (init_iterator): Initialize bidi_p from the default value of
7685 bidi-display-reordering, not from buffer-local value. Use the
7686 buffer-local value only if initializing for buffer iteration.
7687 (handle_invisible_prop): Support invisible properties on strings
7688 that are being bidi-reordered.
7689 (set_iterator_to_next): Support bidi reordering of C strings and
7690 Lisp strings.
7691 (next_element_from_string): Support bidi reordering of Lisp
7692 strings.
7693 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7694 (display_string): Support display of R2L glyph rows.
7695 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7696 (init_iterator): Don't initialize it->bidi_p for strings
7697 here.
7698 (reseat_to_string): Initialize it->bidi_p for strings here.
7699 (next_element_from_string, next_element_from_c_string)
7700 (next_element_from_buffer): Add xassert's for correspondence
7701 between IT's object being iterated and it->bidi_it.string
7702 structure.
7703 (face_before_or_after_it_pos): Support bidi iteration.
7704 (next_element_from_c_string): Handle the case of the first string
7705 character that is not the first one in the visual order.
7706 (get_visually_first_element): New function, refactored from common
7707 parts of next_element_from_buffer, next_element_from_string, and
7708 next_element_from_c_string.
7709 (tool_bar_lines_needed, redisplay_tool_bar)
7710 (display_menu_bar): Force left-to-right direction. Add a FIXME
7711 comment for making that be controlled by a user option.
7712 (push_it, pop_it): Save and restore the state of the
7713 bidi iterator. Save and restore the bidi_p flag.
7714 (pop_it): Iterate out of display property for string iteration as
7715 well.
7716 (iterate_out_of_display_property): Support iteration over strings.
7717 (handle_single_display_spec): Set up it->bidi_it for iteration
7718 over a display string, and call bidi_init_it.
7719 (handle_single_display_spec, next_overlay_string)
7720 (get_overlay_strings_1, push_display_prop): Set up the bidi
7721 iterator for displaying display or overlay strings.
7722 (forward_to_next_line_start): Don't use the shortcut if
7723 bidi-iterating.
7724 (back_to_previous_visible_line_start): If handle_display_prop
7725 pushed the iterator stack, restore the internal state of the bidi
7726 iterator by calling bidi_pop_it same number of times.
7727 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7728 and we are bidi-iterating, don't decrement the iterator position;
7729 instead, set the first_elt flag in the bidi iterator, to produce
7730 the same effect.
7731 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7732 (push_display_prop): xassert that we are iterating a buffer.
7733 (push_it, pop_it): Save and restore paragraph_embedding member.
7734 (handle_single_display_spec, next_overlay_string)
7735 (get_overlay_strings_1, reseat_1, reseat_to_string)
7736 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7737 correctly. Don't assume unibyte strings are not bidi-reordered.
7738 (compute_display_string_pos)
7739 (compute_display_string_end): Fix handling the case of C string.
7740 (push_it, pop_it): Save and restore from_disp_prop_p.
7741 (handle_single_display_spec, push_display_prop): Set the
7742 from_disp_prop_p flag.
7743 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7744 (pop_it): Call iterate_out_of_display_property only if we are
7745 popping after iteration over a string that came from a display
7746 property. Fix a typo in popping stretch info. Add an assertion
7747 for verifying that the iterator position is in sync with the bidi
7748 iterator.
7749 (handle_single_display_spec, get_overlay_strings_1)
7750 (push_display_prop): Fix initialization of paragraph direction for
7751 string when that of the parent object is not yet determined.
7752 (reseat_1): Call bidi_init_it to resync the bidi
7753 iterator with IT's position. (Bug#7616)
7754 (find_row_edges): If ROW->start.pos gives position
7755 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7756 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7757 Reset the from_disp_prop_p flag.
7758 (SAVE_IT, RESTORE_IT): New macros.
7759 (pos_visible_p, face_before_or_after_it_pos)
7760 (back_to_previous_visible_line_start)
7761 (move_it_in_display_line_to, move_it_in_display_line)
7762 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7763 (try_scrolling, redisplay_window, display_line): Use them when
7764 saving a temporary copy of the iterator and restoring it back.
7765 (back_to_previous_visible_line_start, reseat_1)
7766 (init_iterator): Empty the bidi cache "stack".
7767 (move_it_in_display_line_to): If iterator ended up at
7768 EOL, but we never saw any buffer positions smaller than
7769 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7770 motion in bidi-reordered lines.
7771 (move_it_in_display_line_to): Record prev_method and prev_pos
7772 immediately before the call to set_iterator_to_next. Fixes cursor
7773 motion in bidi-reordered lines with stretch glyphs and strings
7774 displayed in margins. (Bug#8133) (Bug#8867)
7775 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7776 TO_CHARPOS.
640c8776
SM
7777 (pos_visible_p): Support positions in bidi-reordered lines.
7778 Save and restore bidi cache.
0bb23927
EZ
7779
7780 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7781 (bidi_paragraph_info): Delete unused struct.
7782 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7783 (bidi_cache_start): New variable.
7784 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7785 to zero.
7786 (bidi_cache_fetch_state, bidi_cache_search)
7787 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7788 (bidi_cache_find, bidi_peek_at_next_level)
7789 (bidi_level_of_next_char, bidi_find_other_level_edge)
7790 (bidi_move_to_visually_next): Compare cache index with
7791 bidi_cache_start rather than with zero.
7792 (bidi_fetch_char): Accept new argument STRING; all callers
7793 changed. Support iteration over a string. Support strings with
7794 display properties. Support unibyte strings. Fix the type of
7795 `len' according to what STRING_CHAR_AND_LENGTH expects.
7796 (bidi_paragraph_init, bidi_resolve_explicit_1)
7797 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7798 (bidi_level_of_next_char, bidi_move_to_visually_next):
7799 Support iteration over a string.
0bb23927
EZ
7800 (bidi_set_sor_type, bidi_resolve_explicit_1)
7801 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7802 can now be zero (for strings); special values 0 and -1 were
7803 changed to -1 and -2, respectively.
7804 (bidi_char_at_pos): New function.
7805 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7806 Call it instead of FETCH_MULTIBYTE_CHAR.
7807 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7808 initialized to valid values.
7809 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7810 values.
7811 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7812 the test for valid cached positions. Fix the logic for looking up
7813 the sentinel state in the cache. GCPRO the Lisp string we are
7814 iterating.
7815 (bidi_push_it, bidi_pop_it): New functions.
7816 (bidi_initialize): Initialize the bidi cache start stack pointer.
7817 (bidi_cache_ensure_space): New function, refactored from part of
7818 bidi_cache_iterator_state. Don't assume the required size is just
7819 one BIDI_CACHE_CHUNK away.
7820 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7821 (bidi_count_bytes, bidi_char_at_pos): New functions.
7822 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7823 always valid if bidi_cache_idx is valid.
7824 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7825 is valid if it's going to be used.
7826 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7827 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7828 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7829 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7830 (bidi_find_other_level_edge, bidi_cache_start_stack):
7831 All variables related to cache indices are now EMACS_INT.
c965adc5 7832
0bb23927
EZ
7833 * dispextern.h (struct bidi_string_data): New structure.
7834 (struct bidi_it): New member `string'. Make flag members be 1-bit
7835 fields, and put them last in the struct.
640c8776
SM
7836 (compute_display_string_pos, compute_display_string_end):
7837 Update prototypes.
0bb23927
EZ
7838 (bidi_push_it, bidi_pop_it): Add prototypes.
7839 (struct iterator_stack_entry): New members bidi_p,
7840 paragraph_embedding, and from_disp_prop_p.
7841 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7842 (bidi_shelve_cache, bidi_unshelve_cache):
7843 Declare prototypes.
0bb23927
EZ
7844
7845 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7846 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7847 and vector-like objects.
7848
7849 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7850 cache around display iteration.
7851
7852 * window.c (Fwindow_end, window_scroll_pixel_based)
7853 (displayed_window_lines, Frecenter): Save and restore the bidi
7854 cache around display iteration.
7855
3bbd2265
LMI
78562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7857
7858 * editfns.c (Fdelete_region): Clarify the use of the named
7859 parameters (bug#6788).
7860
adc47434
MR
78612011-07-14 Martin Rudalics <rudalics@gmx.at>
7862
7863 * indent.c (Fvertical_motion): Set and restore w->pointm when
7864 saving and restoring the window's buffer (Bug#9006).
7865
837c31f8
LMI
78662011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7867
7868 * editfns.c (Fstring_to_char): Clarify just what is returned
7869 (bug#6576). Text by Eli Zaretskii.
7870
ac389d0c
JB
78712011-07-13 Juanma Barranquero <lekktu@gmail.com>
7872
7873 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7874
0be0ce47
EZ
78752011-07-13 Eli Zaretskii <eliz@gnu.org>
7876
7877 * buffer.c (mmap_find): Fix a typo.
7878
cd18e7e3
JB
78792011-07-13 Johan Bockgård <bojohan@gnu.org>
7880
7881 Fix execution of x selection hooks.
7882 * xselect.c (Qx_lost_selection_functions)
7883 (Qx_sent_selection_functions): New vars.
7884 (syms_of_xselect): DEFSYM them.
7885 (x_handle_selection_request): Pass Qx_sent_selection_functions
7886 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7887 (x_handle_selection_clear,x_clear_frame_selections):
7888 Pass Qx_lost_selection_functions rather than
7889 Vx_lost_selection_functions to Frun_hook_with_args.
7890
47ea7f44
PE
78912011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7892
ac389d0c 7893 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7894 The old code sometimes used this field without initializing it.
7895
47ea7f44
PE
7896 * alloc.c (gc_sweep): Don't read past end of array.
7897 In theory, the old code could also have corrupted Emacs internals,
7898 though it'd be very unlikely.
7899
bc985c87
AS
79002011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7901
7902 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7903 argument. (Bug#4026)
bc985c87 7904
0cf34688
LMI
79052011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7906
b3dadd76
LMI
7907 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7908 key" (bug#4257).
7909
0cf34688
LMI
7910 * window.c (Fset_window_start): Doc fix (bug#4199).
7911 (Fset_window_hscroll): Ditto.
7912
270768cd
PE
79132011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7914
077e3dda 7915 Fix minor new problems caught by GCC 4.6.1.
270768cd 7916 * term.c (init_tty): Remove unused local.
490011a6 7917 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7918 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7919 not used otherwise.
270768cd 7920
b1f58454
CY
79212011-07-12 Chong Yidong <cyd@stupidchicken.com>
7922
7923 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7924
22b9578d
LMI
79252011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7926
6e70ab07
LMI
7927 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7928 are the mini-buffer and the echo area (bug#3320).
7929
22b9578d
LMI
7930 * term.c (init_tty): Remove support for supdup, c10 and perq
7931 terminals, which are no longer supported (bug#1482).
7932
8974cc9f
JB
79332011-07-10 Johan Bockgård <bojohan@gnu.org>
7934
7935 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7936
a560d974
JD
79372011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7938
7939 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7940 for non-popups (Bug#3642).
7941
1dae0f0a
AS
79422011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7943
268c2c36 7944 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7945 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7946 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7947 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7948 * data.c (fmod): Likewise.
7949 * dispnew.c (swap_glyphs_in_rows): Likewise.
7950 * emacs.c (memory_warning_signal): Likewise.
7951 * floatfns.c (float_error): Likewise.
7952 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7953 (otf_open, font_otf_capability, generate_otf_features)
7954 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7955 Likewise.
7956 * image.c (pbm_read_file): Likewise.
7957 * indent.c (string_display_width): Likewise.
7958 * intervals.c (check_for_interval, search_for_interval)
7959 (inc_interval_count, count_intervals, root_interval)
7960 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7961 * lread.c (defalias): Likewise.
268c2c36 7962 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7963 * regex.c (set_image_of_range_1, set_image_of_range)
7964 (regex_grow_registers): Likewise.
7965 * sysdep.c (strerror): Likewise.
7966 * termcap.c (valid_filename_p, tprint, main): Likewise.
7967 * tparam.c (main): Likewise.
7968 * unexhp9k800.c (run_time_remap, save_data_space)
7969 (update_file_ptrs, read_header, write_header, calculate_checksum)
7970 (copy_file, copy_rest, display_header): Likewise.
7971 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7972 Likewise.
7973 * xdisp.c (check_it): Likewise.
7974 * xfaces.c (register_color, unregister_color, unregister_colors):
7975 Likewise.
7976 * xfns.c (print_fontset_result): Likewise.
7977 * xrdb.c (member, fatal, main): Likewise.
7978
99033785
PE
79792011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7980
7981 Fix minor problems found by static checking (Bug#9031).
7982 * chartab.c (char_table_set_range, map_sub_char_table):
7983 Remove unused locals.
7984 (uniprop_table): Now static.
7985 * composite.c (_work_char): Remove unused static var.
7986
9cb2ac56
JB
79872011-07-09 Juanma Barranquero <lekktu@gmail.com>
7988
7989 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7990
f25661f0
JD
79912011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7992
7993 * gtkutil.c (qttip_cb): Remove code without function.
7994
8278c4fe
EZ
79952011-07-09 Eli Zaretskii <eliz@gnu.org>
7996
7997 * w32.c (pthread_sigmask): New stub.
7998
1692ae2d 79992011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8000
8a6ebd58 8001 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8002 sigprocmask is portable only for single-threaded applications, and
8003 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8004 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8005 (LIBES): Use it.
8006 * callproc.c (Fcall_process):
8007 * process.c (create_process):
8008 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8009 Use pthread_sigmask, not sigprocmask.
123403e4 8010
1b854618
JD
80112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8012
8013 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8014 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8015 wrong (Bug#8591).
8016
3fe4b549
JD
80172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8018
0ce7e563
JD
8019 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8020 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8021 (xg_hide_tooltip): Fix comment.
8022
3fe4b549
JD
8023 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8024 in registerServicesMenuSendTypes.
8025 (validRequestorForSendType): Don't check ns_return_types.
8026
8027 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8028 ns_return_type.
8029
5df75e47
JR
80302011-07-08 Jason Rumney <jasonr@gnu.org>
8031
22610910
JR
8032 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8033 SH_SHOW for hidden windows (Bug#5482).
8034
5df75e47
JR
8035 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8036 frame struct members of non-existent frames (Bug#6284).
8037
699c10bd
JD
80382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8039
4393663b
JD
8040 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8041 variable firstTime not needed on OSX >= 10.6.
8042 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8043 >= 10.5. Use setKnobProportion, setDoubleValue.
8044
8045 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8046 (MAC_OS_X_VERSION_10_5): Define if not defined.
8047 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8048 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8049 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8050
8051 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8052 cString and lossyCString on OSX >= 10.4.
4393663b 8053
58179cce 8054 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8055 sizeToFit on OSX >= 10.2.
8056
8057 * nsimage.m (allocInitFromFile): Don't use deprecated method
8058 bestRepresentationForDevice on OSX >= 10.6.
8059
8060 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8061 to avoid warning.
8062
8063 * emacs.c: Declare unexec_init_emacs_zone.
8064
a63e0781
JD
8065 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8066
699c10bd
JD
8067 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8068
8069 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8070 on svcsMenu (Bug#8842).
8071
8072 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8073 ns_return_types.
8074 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8075
8076 * nsterm.m (QUTF8_STRING): Declare.
8077 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8078 (validRequestorForSendType): Return type is (id).
8079 Change indexOfObjectIdenticalTo to indexOfObject.
8080 Check if we have local selection before returning self (Bug#8842).
8081 (writeSelectionToPasteboard): Put local selection into paste board
8082 if we have a local selection (Bug#8842).
8083 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8084
8085 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8086 (ns_get_local_selection): Declare.
8087
54e10184
LMI
80882011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8089
9888ff71
LMI
8090 * keymap.c (describe_map_tree): Don't insert a double newline at
8091 the end of the buffer (bug#1169) and return whether we inserted
8092 something.
8093
54e10184
LMI
8094 * callint.c (Fcall_interactively): Change "reading args" to
8095 "providing args" to try to clarify what it does (bug#1010).
8096
15fa4783
KH
80972011-07-07 Kenichi Handa <handa@m17n.org>
8098
8099 * composite.c (composition_compute_stop_pos): Ignore a static
8100 composition starting before CHARPOS (Bug#8915).
8101
8102 * xdisp.c (handle_composition_prop): Likewise.
8103
a8815b00
EZ
81042011-07-07 Eli Zaretskii <eliz@gnu.org>
8105
8106 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8107 (Bug#9015)
8108
ef7b981d 81092011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8110
8111 * character.h (unicode_category_t): New enum type.
8112
8113 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8114 (Qchar_code_property_table): New variable.
8115 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8116 (UNIPROP_COMPRESSED_FORM_P): New macros.
8117 (char_table_ascii): Uncompress the compressed values.
8118 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8119 Uncompress the compressed values.
ac389d0c 8120 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8121 (char_table_ref_and_range): Uncompress the compressed values.
8122 (sub_char_table_set): New arg is_uniprop. Callers changed.
8123 Uncompress the compressed values.
8124 (sub_char_table_set_range): Args changed. Callers changed.
8125 (char_table_set_range): Adjuted for the above change.
8126 (map_sub_char_table): Delete args default_val and parent. Add arg
8127 top. Give decoded values to a Lisp function.
640c8776 8128 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8129 values to a Lisp function. Gcpro more variables.
8130 (uniprop_table_uncompress)
8131 (uniprop_decode_value_run_length): New functions.
8132 (uniprop_decoder, uniprop_decoder_count): New variables.
8133 (uniprop_get_decoder, uniprop_encode_value_character)
8134 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8135 New functions.
8136 (uniprop_encoder, uniprop_encoder_count): New variables.
8137 (uniprop_get_encoder, uniprop_table)
8138 (Funicode_property_table_internal, Fget_unicode_property_internal)
8139 (Fput_unicode_property_internal): New functions.
8140 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8141 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8142 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8143 char-code-property-alist.
8144
640c8776 8145 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8146 Vunicode_category_table.
8147
640c8776 8148 * font.c (font_range): Adjust for the change of
c805dec0
KH
8149 Vunicode_category_table.
8150
76b397fb
DN
81512011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8152
8153 * m/iris4d.h: Remove file, move contents ...
8154 * s/irix6-5.h: ... here.
8155
22b4128e
PE
81562011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8157
8158 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8159 * alloc.c (mark_buffer):
8160 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8161 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8162 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8163 This isn't true in general, and it's particularly not true
8164 if Emacs is configured with --with-wide-int.
8165 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8166 New macros, used in the buffer.c change.
8167
869795d6
JD
81682011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8169
8170 * xsettings.c: Use both GConf and GSettings if both are available.
8171 (store_config_changed_event): Add comment.
8172 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8173 (store_tool_bar_style_changed): New functions.
5e617bc2 8174 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8175 (struct xsettings): Move font inside HAVE_XFT.
8176 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8177 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8178 Move inside HAVE_XFT.
640c8776 8179 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8180 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8181 also.
8182 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8183 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8184 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8185 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8186 (parse_settings): Move check for font inside HAVE_XFT.
8187 (read_settings, apply_xft_settings): Add comment.
8188 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8189 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8190 call store_font_name_changed.
8191 (xft_settings_event): Add comment.
8192 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8193 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8194 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8195 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8196 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8197 (xsettings_get_system_font, xsettings_get_system_normal_font):
8198 Add comment.
869795d6 8199
d8ed26bd
PE
82002011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8201
8202 Random fixes. E.g., (random) never returned negative values.
8203 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8204 subseconds part to the entropy, as that's a bit more random.
8205 Prefer signed to unsigned, since the signedness doesn't matter and
8206 in general we prefer signed. When given a limit, use a
8207 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8208 latter isn't right if USE_2_TAGS_FOR_INTS.
8209 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8210 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8211
cabf1cac
SM
82122011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8213
8214 * textprop.c (text_property_stickiness):
8215 Obey Vtext_property_default_nonsticky.
8216 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8217 * w32fns.c (syms_of_w32fns):
8218 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8219
6e9b2be9
PE
82202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8221
8222 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8223 This is more efficient than Ffile_directory_p and avoids a minor race.
8224
90186c68
LMI
82252011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8226
7c301272
LMI
8227 * buffer.c (Foverlay_put): Say what the return value is
8228 (bug#7835).
8229
c4f2d8d4
LMI
8230 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8231 is a directory before asking whether to use the file name
8232 (bug#7564).
ad637907
LMI
8233 (barf_or_query_if_file_exists): Make the "File is a directory"
8234 error be more correct.
c4f2d8d4 8235
90186c68
LMI
8236 * fns.c (Frequire): Remove the mention of the .gz files, since
8237 that's installation-specific, but keep the mention of
8238 `get-load-suffixes'.
8239
da64016e
PE
82402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8241
8242 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8243 Report string overflow if the output is too long.
8244
7d47b580
JB
82452011-07-04 Juanma Barranquero <lekktu@gmail.com>
8246
a555cb87
JB
8247 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8248 (syms_of_gnutls): Remove duplicate DEFSYM for
8249 Qgnutls_bootprop_verify_hostname_error, an error for
8250 Qgnutls_bootprop_verify_error (which is no longer used).
8251
7d47b580
JB
8252 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8253 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8254 Also (re)move comments that are misplaced or no longer relevant.
8255
1e49bfab
LMI
82562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8257
8258 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8259
1485f4c0
CY
82602011-07-03 Chong Yidong <cyd@stupidchicken.com>
8261
8262 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8263 and background color parameters if they have been changed.
8264
a9ab721e
LMI
82652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8266
8267 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8268
cf7cff57
PE
82692011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8270
2e13213d
PE
8271 * xsettings.c (SYSTEM_FONT): Define only when used.
8272 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8273
cf7cff57
PE
8274 * keymap.c (access_keymap_1): Now static.
8275
7a8e04f7
CY
82762011-07-02 Chong Yidong <cyd@stupidchicken.com>
8277
8278 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8279 leave any prefix arg for the up event (Bug#1586).
8280
61352f62
LMI
82812011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8282
69bb1ef7
LMI
8283 * lread.c (syms_of_lread): Mention single symbols defined by
8284 `defvar' or `defconst' (bug#7154).
8285
61352f62 8286 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8287 (Frequire): Mention get-load-suffixes.
61352f62 8288
28545e04
MR
82892011-07-02 Martin Rudalics <rudalics@gmx.at>
8290
8291 * window.h (window): Remove clone_number slot.
8292 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8293 Remove.
8294 (make_parent_window, make_window, saved_window)
8295 (Fset_window_configuration, save_window_save): Don't deal with
8296 clone numbers.
8297 * buffer.c (Qclone_number): Remove declaration.
8298 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8299
3349e122
SM
83002011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8301
8302 Add multiple inheritance to keymaps.
8303 * keymap.c (Fmake_composed_keymap): New function.
8304 (Fset_keymap_parent): Simplify.
8305 (fix_submap_inheritance): Remove.
8306 (access_keymap_1): New function extracted from access_keymap to handle
8307 embedded parents and handle lists of maps.
8308 (access_keymap): Use it.
8309 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8310 (Fcopy_keymap): Handle embedded parents.
8311 (Fcommand_remapping, define_as_prefix): Simplify.
8312 (Fkey_binding): Simplify.
8313 (syms_of_keymap): Move minibuffer-local-completion-map,
8314 minibuffer-local-filename-completion-map,
8315 minibuffer-local-must-match-map, and
8316 minibuffer-local-filename-must-match-map to Elisp.
8317 (syms_of_keymap): Defsubr make-composed-keymap.
8318 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8319 (parse_menu_item): Trivial simplification.
8320
3279eb87
GM
83212011-07-01 Glenn Morris <rgm@gnu.org>
8322
8323 * Makefile.in (SETTINGS_LIBS): Fix typo.
8324
4550efdf
KI
83252011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8326
8327 * coding.c (Fencode_coding_string): Record the last coding system
8328 used, as the function doc string says (bug#8738).
8329
0949d2b6
JD
83302011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8331
8332 * xsettings.c (store_monospaced_changed): Take new font as arg and
8333 check for change against current_mono_font.
8334 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8335 (emacs_settings_constructor, emacs_settings_get_property)
8336 (emacs_settings_set_property, emacs_settings_class_init)
8337 (emacs_settings_init, gsettings_obj): Remove.
8338 (something_changedCB): New function for HAVE_GSETTINGS.
8339 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8340 with value as argument.
8341 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8342 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8343 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8344 "changed".
8345
8346 * xgselect.c: Add defined (HAVE_GSETTINGS).
8347 (xgselect_initialize): Ditto.
8348
8349 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8350 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8351 xg_select.
8352
bbc6b304
PE
83532011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8354
8355 * eval.c (struct backtrace): Simplify and port the data structure.
8356 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8357 signed bit field, as this assumption is not portable and it makes
8358 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8359 "char debug_on_exit : 1" as this is not portable either; instead,
8360 use the portable "unsigned int debug_on_exit : 1". Remove unused
8361 member evalargs. Remove obsolete comments about cc bombing out.
8362
9851bfc5
JD
83632011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8364
51bb811f 8365 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8366 Let HAVE_GSETTINGS override HAVE_GCONF.
8367 (store_monospaced_changed): New function.
8368 (EMACS_SETTINGS): A new type derived from GObject to handle
8369 GSettings notifications.
8370 (emacs_settings_constructor, emacs_settings_get_property)
8371 (emacs_settings_set_property, emacs_settings_class_init):
8372 New functions.
8373 (gsettings_client, gsettings_obj): New variables.
8374 (GSETTINGS_SCHEMA): New define.
8375 (something_changedCB): Call store_monospaced_changed.
8376 (init_gsettings): New function.
8377 (xsettings_initialize): Call init_gsettings.
8378 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8379 to NULL.
8380
640c8776 8381 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8382 GCONF_CFLAGS/LIBS.
8383
5386012d
MR
83842011-06-29 Martin Rudalics <rudalics@gmx.at>
8385
8386 * window.c (resize_root_window, grow_mini_window)
8387 (shrink_mini_window): Rename Qresize_root_window to
8388 Qwindow_resize_root_window and Qresize_root_window_vertically to
8389 Qwindow_resize_root_window_vertically.
8390
f13e0b08
PE
83912011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8392
8393 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8394
94515237
JB
83952011-06-27 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * makefile.w32-in: Redesign dependencies so they reflect more
8398 clearly which files are directly included by each source file,
8399 and not through other includes.
8400
e43b6e43
MR
84012011-06-27 Martin Rudalics <rudalics@gmx.at>
8402
8403 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8404 (sort_overlays, overlay_strings): When an overlay's clone number
8405 matches the window's clone number process the overlay even if
8406 the overlay's window property doesn't match the current window.
8407
d68443dc
MR
8408 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8409 (Fwindow_hchild): Rename to Fwindow_left_child.
8410 (Fwindow_next): Rename to Fwindow_next_sibling.
8411 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8412 (resize_window_check): Rename to window_resize_check.
8413 (resize_window_apply): Rename to window_resize_apply.
8414 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8415 (Fdelete_other_windows_internal, resize_frame_windows)
8416 (Fsplit_window_internal, Fdelete_window_internal)
8417 (grow_mini_window, shrink_mini_window)
8418 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8419
c7e73be5
JD
84202011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8421
8422 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8423 (emacs_fixed_set_min_size): Remove.
8424 (emacs_fixed_new): Take frame as argument.
8425
8426 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8427 (_EmacsFixedPrivate): Remove minwidth/height.
8428 Add struct frame *f.
8429 (emacs_fixed_init): Initialize priv->f.
8430 (get_parent_class, emacs_fixed_set_min_size): Remove.
8431 (emacs_fixed_new): Set priv->f to argument.
8432 (emacs_fixed_get_preferred_width)
8433 (emacs_fixed_get_preferred_height): Use min_width/height from
8434 frames size_hint to set minimum and natural (Bug#8919).
8435 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8436 and use min_width/height from frames size_hint to set
8437 min_width/height (Bug#8919).
8438
8439 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8440 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8441 Fix indentation.
c7e73be5 8442
cf99dcf8
EZ
84432011-06-26 Eli Zaretskii <eliz@gnu.org>
8444
8445 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8446 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8447 called at ZV.
8448
029529ac
CY
84492011-06-26 Chong Yidong <cyd@stupidchicken.com>
8450
8451 * process.c (wait_reading_process_output): Bypass select if
8452 waiting for a cell while ignoring keyboard input, and input is
8453 pending. Suggested by Jan Djärv (Bug#8869).
8454
7a7ef429
PE
84552011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8456
8457 Use gnulib's dup2 module instead of rolling our own.
8458 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8459
11fdef7d 84602011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8461
8462 * dispnew.c (scrolling_window): Before scrolling, turn off a
8463 mouse-highlight in the window being scrolled.
8464
cd3520a4
JB
84652011-06-24 Juanma Barranquero <lekktu@gmail.com>
8466
8467 Move DEFSYM to lisp.h and use everywhere.
8468
8469 * character.h (DEFSYM): Move declaration...
8470 * lisp.h (DEFSYM): ...here.
8471
8472 * gnutls.c:
8473 * minibuf.c:
8474 * w32menu.c:
8475 * w32proc.c:
8476 * w32select.c: Don't include character.h.
8477
8478 * alloc.c (syms_of_alloc):
8479 * buffer.c (syms_of_buffer):
8480 * bytecode.c (syms_of_bytecode):
8481 * callint.c (syms_of_callint):
8482 * casefiddle.c (syms_of_casefiddle):
8483 * casetab.c (init_casetab_once):
8484 * category.c (init_category_once, syms_of_category):
8485 * ccl.c (syms_of_ccl):
8486 * cmds.c (syms_of_cmds):
8487 * composite.c (syms_of_composite):
8488 * dbusbind.c (syms_of_dbusbind):
8489 * dired.c (syms_of_dired):
8490 * dispnew.c (syms_of_display):
8491 * doc.c (syms_of_doc):
8492 * editfns.c (syms_of_editfns):
8493 * emacs.c (syms_of_emacs):
8494 * eval.c (syms_of_eval):
8495 * fileio.c (syms_of_fileio):
8496 * fns.c (syms_of_fns):
8497 * frame.c (syms_of_frame):
8498 * fringe.c (syms_of_fringe):
8499 * insdel.c (syms_of_insdel):
8500 * keymap.c (syms_of_keymap):
8501 * lread.c (init_obarray, syms_of_lread):
8502 * macros.c (syms_of_macros):
8503 * msdos.c (syms_of_msdos):
8504 * print.c (syms_of_print):
8505 * process.c (syms_of_process):
8506 * search.c (syms_of_search):
8507 * sound.c (syms_of_sound):
8508 * syntax.c (init_syntax_once, syms_of_syntax):
8509 * terminal.c (syms_of_terminal):
8510 * textprop.c (syms_of_textprop):
8511 * undo.c (syms_of_undo):
8512 * w32.c (globals_of_w32):
8513 * window.c (syms_of_window):
8514 * xdisp.c (syms_of_xdisp):
8515 * xfaces.c (syms_of_xfaces):
8516 * xfns.c (syms_of_xfns):
8517 * xmenu.c (syms_of_xmenu):
8518 * xsettings.c (syms_of_xsettings):
8519 * xterm.c (syms_of_xterm): Use DEFSYM.
8520
4228cf16
TZ
85212011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8522
cd3520a4 8523 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8524
7fcccf1e
PE
85252011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8526
7efb4e0e
PE
8527 Integer and buffer overflow fixes (Bug#8873).
8528
ff5844ad
PE
8529 * print.c (printchar, strout): Check for string overflow.
8530 (PRINTPREPARE, printchar, strout):
8531 Don't set size unless allocation succeeds.
8532
90532f02
PE
8533 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8534 for sizes. Check for string overflow more accurately.
8535 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8536
6d84508d
PE
8537 * macros.c: Integer and buffer overflow fixes.
8538 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8539 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8540 Use ptrdiff_t, not int, for sizes.
8541 Don't increment bufsize until after realloc succeeds.
8542 Check for size-calculation overflow.
8543 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8544
437b2cb4
PE
8545 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8546
8b9ac8b4
PE
8547 * lread.c: Integer overflow fixes.
8548 (read_integer): Radix is now EMACS_INT, not int,
8549 to improve quality of diagnostics for out-of-range radices.
8550 Calculate buffer size correctly for out-of-range radices.
8551 (read1): Check for integer overflow in radices, and in
8552 read-circle numbers.
82cb60d3
PE
8553 (read_escape): Avoid int overflow.
8554 (Fload, openp, read_buffer_size, read1)
8555 (substitute_object_recurse, read_vector, read_list, map_obarray):
8556 Use ptrdiff_t, not int, for sizes.
8557 (read1): Use EMACS_INT, not int, for sizes.
20270765 8558 Check for size overflow.
8b9ac8b4 8559
7fcccf1e
PE
8560 * image.c (cache_image): Check for size arithmetic overflow.
8561
bfbbd7e7
PE
8562 * lread.c: Integer overflow issues.
8563 (saved_doc_string_size, saved_doc_string_length)
8564 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8565 Now ptrdiff_t, not int.
8566 (read1): Don't assume doc string length fits in int. Check for
8567 out-of-range doc string lengths.
8568 (read_list): Don't assume file position fits in int.
39019e54 8569 (read_escape): Check for hex character overflow.
bfbbd7e7 8570
4e323265
LL
85712011-06-22 Leo Liu <sdl.web@gmail.com>
8572
8573 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8574 Move to minibuffer.el.
8575
85fece3e
PE
85762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8577
20b84ce9 8578 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8579 The following patches are for when GLYPH_DEBUG && !XASSERT.
8580 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8581 * dispnew.c (flush_stdout):
8582 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8583 Mark as externally visible.
8584 * dispnew.c (check_window_matrix_pointers): Now static.
8585 * dispnew.c (window_to_frame_vpos):
8586 * xfns.c (unwind_create_frame):
8587 * xterm.c (x_check_font): Remove unused local.
8588 * scroll.c (CHECK_BOUNDS):
8589 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8590 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8591 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8592 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8593 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8594 Now static.
8595 (debug_method_add): Use va_list and vsprintf rather than relying
8596 on undefined behavior with wrong number of arguments.
8597 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8598 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8599 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8600 since we're not interested in debugging glyphs with old libraries.
8601 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8602 GCC 4.6.0's static checking.
8603
0766b489
PE
86042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8605
31fd4b32
PE
8606 Integer overflow and signedness fixes (Bug#8873).
8607 A few related buffer overrun fixes, too.
8608
b79e8648
PE
8609 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8610
0766b489
PE
8611 * dispextern.h (struct face.stipple):
8612 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8613 (x_bitmap_mask, x_allocate_bitmap_record)
8614 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8615 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8616 (x_create_bitmap_from_xpm_data):
8617 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8618 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8619 (.bitmaps_last):
8620 * xfaces.c (load_pixmap):
8621 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8622 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8623 (.bitmaps_last, struct x_output.icon_bitmap):
8624 Use ptrdiff_t, not int, for bitmap indexes.
8625 (x_allocate_bitmap_record): Check for size overflow.
8626 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8627
b081724f
PE
8628 Use ptrdiff_t, not int, for overlay counts.
8629 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8630 * editfns.c (overlays_around, get_pos_property):
8631 * textprop.c (get_char_property_and_overlay):
8632 * xdisp.c (next_overlay_change, note_mouse_highlight):
8633 * xfaces.c (face_at_buffer_position):
21514da7
PE
8634 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8635 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8636 (Fnext_overlay_change, Fprevious_overlay_change)
8637 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8638 Use ptrdiff_t, not int, for sizes.
21514da7 8639 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8640
3de73e5e
PE
8641 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8642
2606c57b
PE
8643 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8644 (x_session_initialize): Do not assume string length fits in int.
8645
aaafe47a
PE
8646 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8647 This is unlikely, but can occur if DPI is outlandish.
8648
2674ddc8 8649 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8650 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8651
28154962
PE
8652 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8653 * xrdb.c (magic_file_p, search_magic_path):
8654 Omit last arg SUFFIX; it was always 0. All callers changed.
8655 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8656
7de51af5
PE
8657 * xfont.c (xfont_match): Avoid need for strlen.
8658
25ed6cc3
PE
8659 * xfns.c: Don't assume strlen fits in int.
8660 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8661
4eab31dd
PE
8662 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8663 not unsigned long, as we prefer signed integers. All callers changed.
8664 Detect integer overflow in repeat count.
8665 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8666 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8667
171e2a58
PE
8668 * termcap.c: Don't assume sizes fit in int and never overflow.
8669 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8670 (gobble_line): Check for size-calculation overflow.
8671
ad39faca 8672 * minibuf.c (Fread_buffer):
6e5bb2dc 8673 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8674 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8675 Don't assume string length fits in int.
8676
52c61c22 8677 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8678 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8679
b5b8c9e5
PE
8680 * font.c: Don't assume string length fits in int.
8681 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8682 Use ptrdiff_t, not int.
ccd6111c
PE
8683 (font_intern_prop): Don't assume string length fits in int.
8684 Don't assume integer property fits in fixnum.
8685 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8686
882f0d81 8687 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8688 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8689 Reformulate so as not to need the command string.
8690 Invoke gzip -cd rather than gunzip, as it's more portable.
8691 (lock_info_type, lock_file_1, lock_file):
8692 Don't assume pid_t and time_t fit in unsigned long.
8693 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8694 (current_lock_owner): Prefer signed type for sizes.
8695 Use memcpy, not strncpy, where memcpy is what is really wanted.
8696 Don't assume (via atoi) that time_t and pid_t fit in int.
8697 Check for time_t and/or pid_t out of range, e.g., via a network share.
8698 Don't alloca where an auto var works fine.
8699
93f4cf88
PE
8700 * fileio.c: Fix some integer overflow issues.
8701 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8702 Don't assume string length fits in int.
8703 (directory_file_name): Don't assume string length fits in long.
8704 (make_temp_name): Don't assume pid fits in int, or that its print
8705 length is less than 20.
8706
f3e92b69
PE
8707 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8708
1bfdaf10
PE
8709 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8710
35016e9a
PE
8711 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8712
3d1e65a1
PE
8713 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8714 We prefer signed integers, even for size calculations.
8715
0b963a93
PE
8716 * emacs.c: Don't assume string length fits in 'int'.
8717 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8718 (main): Don't invoke strlen when not needed.
8719
573f4b54
PE
8720 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8721 (XD_DEBUG_MESSAGE): Don't waste a byte.
8722
989f33ba
PE
8723 * callproc.c (getenv_internal_1, getenv_internal)
8724 (Fgetenv_internal):
965d34eb
PE
8725 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8726
e4d29b33
PE
8727 * lread.c (invalid_syntax): Omit length argument.
8728 All uses changed. This doesn't fix a bug, but it simplifies the
8729 code away from its former Hollerith-constant appearance, and it's
8730 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8731 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8732
eb49b136
PE
8733 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8734 This didn't break anything, but it didn't help either.
8735 It's confusing to put a bogus integer in a place where the actual
8736 value does not matter.
9f62aeb1 8737 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8738 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8739
15375a22
PE
8740 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8741 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8742 implementation.
b61cc01c
PE
8743 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8744 We prefer signed types, and the value cannot exceed the EMACS_INT
8745 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8746 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8747 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8748 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8749
53b2623d
PE
8750 * indent.c (sane_tab_width): New function.
8751 (current_column, scan_for_column, Findent_to, position_indentation)
8752 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8753 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8754
51cab52b 8755 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8756
f2ed8a70
PE
8757 * lisp.h (lint_assume): New macro.
8758 * composite.c (composition_gstring_put_cache):
8759 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8760
abe80cc6
PE
8761 * editfns.c, insdel.c:
8762 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8763
b02c740e
PE
8764 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8765
ebc96716
PE
8766 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8767
b4e50fa0 8768 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8769 Use much-faster test for byte-length change.
311d5d7c 8770 Don't assume string byte-length fits in 'int'.
a4cf38e4 8771 Check that character arg fits in 'int'.
85461888 8772 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8773
c0c1ee9f
PE
8774 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8775
a498d7f4
PE
8776 * fns.c (concat): Catch string overflow earlier.
8777 Do not rely on integer wraparound.
8778
51cab52b
PE
8779 * dispextern.h (struct it.overlay_strings_charpos)
8780 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8781 * xdisp.c (forward_to_next_line_start)
8782 (back_to_previous_visible_line_start)
8783 (reseat_at_next_visible_line_start, next_element_from_buffer):
8784 Don't arbitrarily truncate the value of 'selective' to int.
8785
76031fad
PE
8786 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8787
5eb55db9
PE
8788 * composite.c: Don't truncate sizes to 'int'.
8789 (composition_gstring_p, composition_reseat_it)
8790 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8791 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8792 not EMACS_UINT, for indexes.
5eb55db9 8793
0703a717
PE
8794 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8795
d6202519
PE
8796 * buffer.c: Include <verify.h>.
8797 (struct sortvec.priority, struct sortstr.priority):
8961a454 8798 Now EMACS_INT, not int.
c20998a7 8799 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8800 (struct sortstr.size, record_overlay_string)
8801 (struct sortstrlist.size, struct sortlist.used):
8802 Don't truncate size to int.
8803 (record_overlay_string): Check for size-calculation overflow.
d6202519 8804 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8805
d5a19415
JM
88062011-06-22 Jim Meyering <meyering@redhat.com>
8807
029529ac 8808 Don't leak an XBM-image-sized buffer
d5a19415
JM
8809 * image.c (xbm_load): Free the image buffer after using it.
8810
a9041e6c
PE
88112011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8812
8813 Port to Sun C.
8814 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8815 that Sun C diagnosed.
8816 * fns.c (secure_hash): Fix pointer signedness issue.
8817 * intervals.c (static_offset_intervals): New function.
8818 (offset_intervals): Use it.
8819
7f3f739f
LL
88202011-06-21 Leo Liu <sdl.web@gmail.com>
8821
8822 * deps.mk (fns.o):
8823 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8824 sha512.h.
8825
8826 * fns.c (secure_hash): Rename from crypto_hash_function and change
8827 the first arg to accept symbols.
5b66d427 8828 (Fsecure_hash): New primitive.
7f3f739f
LL
8829 (syms_of_fns): New symbols.
8830
76147d94
DD
88312011-06-20 Deniz Dogan <deniz@dogan.se>
8832
8833 * process.c (Fset_process_buffer): Clarify return value in
8834 docstring.
8835
7d7d0045
CY
88362011-06-18 Chong Yidong <cyd@stupidchicken.com>
8837
8838 * dispnew.c (add_window_display_history): Use BVAR.
8839
8840 * xdisp.c (debug_method_add): Use BVAR.
8841 (check_window_end, dump_glyph_matrix, dump_glyph)
8842 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8843
8844 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8845 Likewise.
8846
8847 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8848 check till after the cache is created in init_frame_faces.
8849
ff2bc410
SM
88502011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8851
8852 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8853
28177add
PE
88542011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8855
dd3482fe
PE
8856 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8857 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8858 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8859
393d71f3 8860 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8861 * fileio.c (Finsert_file_contents):
8862 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8863 Remove the old (too-loose) buffer overflow checks.
8864 They weren't needed, since make_gap checks for buffer overflow.
8865 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8866 The old code merely checked for Emacs fixnum overflow, and relied
8867 on undefined (wraparound) behavior. The new code avoids undefined
8868 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8869
2e6813b0 8870 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8871 Tune. Don't use wider integers than needed. Don't use alloca.
8872 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8873
599a9e4f
PE
8874 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8875
99561444
PE
8876 * insdel.c, lisp.h (buffer_overflow): New function.
8877 (insert_from_buffer_1, replace_range, replace_range_2):
8878 * insdel.c (make_gap_larger):
8879 * editfns.c (Finsert_char):
8880 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8881
28177add
PE
8882 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8883
e69dafad
PE
88842011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8885
4baa020d 8886 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8887
b1c46f02
PE
8888 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8889 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8890
e69dafad
PE
8891 * fileio.c: Don't assume EMACS_INT fits in off_t.
8892 (emacs_lseek): New static function.
8893 (Finsert_file_contents, Fwrite_region): Use it.
8894 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8895
566684ea
PE
8896 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8897
e6966cd6
PE
8898 * fns.c: Don't overflow int when computing a list length.
8899 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8900 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8901 truncation on 64-bit hosts. Check for QUIT every
8902 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8903 faster and is responsive enough.
8904 (Flength): Report an error instead of overflowing an integer.
8905 (Fsafe_length): Return a float if the value is not representable
8906 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8907 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8908 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8909
dd0b0efb
PE
8910 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8911 (header_size, word_size): New constants.
8912 (allocate_vectorlike): Don't check size overflow here.
8913 (allocate_vector): Check it here instead, since this is the only
8914 caller of allocate_vectorlike that could cause overflow.
8915 Check that the new vector's length is representable as a fixnum.
8916
86fe5cfe
PE
8917 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8918 The previous code was bogus. For example, next_almost_prime (32)
8919 returned 39, which is undesirable as it is a multiple of 3; and
8920 next_almost_prime (24) returned 25, which is a multiple of 5 so
8921 why was the code bothering to check for multiples of 7?
8922
80e88859
PE
8923 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8924
4a2f0ad6
PE
8925 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8926
f66c7cf8
PE
8927 Variadic C functions now count arguments with ptrdiff_t.
8928 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8929 Back then I didn't know that the Emacs coding style prefers signed int.
8930 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8931 were being counted with int, which may truncate counts on 64-bit
8932 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8933 * lisp.h (struct Lisp_Subr.function.aMANY)
8934 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8935 Arg counts are now ptrdiff_t, not size_t.
8936 All variadic functions and their callers changed accordingly.
8937 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8938 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8939 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8940 * callint.c (Fcall_interactively): Check arg count for overflow,
8941 to avoid potential buffer overrun. Use signed char, not 'int',
8942 for 'varies' array, so that we needn't bother to check its size
8943 calculation for overflow.
8944 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8945 * eval.c (apply_lambda):
8946 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8947 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8948 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8949
a1759b76
PE
8950 * callint.c (Fcall_interactively): Don't use index var as event count.
8951
d96be9fc
PE
8952 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8953 * mem-limits.h (SIZE): Remove; no longer used.
8954
a690a978 8955 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8956
578c21e6
PE
8957 Remove unnecessary casts.
8958 * xterm.c (x_term_init):
8959 * xfns.c (x_set_border_pixel):
8960 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8961 These aren't needed now that we assume ANSI C.
8962
96f53c6c
PE
8963 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8964 It's more likely to cause problems (due to unsigned overflow)
8965 than to cure them.
8966
83c77d31
PE
8967 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8968
ee2079f1
PE
8969 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8970
6da65536
PE
8971 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8972
7147c4a4
PE
8973 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8974
193e32d9
PE
8975 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8976
e5533da6
PE
8977 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8978
9910e595
PE
8979 GLYPH_CODE_FACE returns EMACS_INT, not int.
8980 * dispextern.h (merge_faces):
8981 * xfaces.c (merge_faces):
01103c44
PE
8982 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8983 Don't assume EMACS_INT fits in int.
9910e595 8984
2638320e
PE
8985 * character.h (CHAR_VALID_P): Remove unused parameter.
8986 * fontset.c, lisp.h, xdisp.c: All uses changed.
8987
045eb8d9
PE
8988 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8989
c1f134b5
PE
8990 * fns.c (concat): Minor tuning based on overflow analysis.
8991 This doesn't fix any bugs. Use int to hold character, instead
8992 of constantly refetching from Emacs object. Use XFASTINT, not
8993 XINT, for value known to be a character. Don't bother comparing
8994 a single byte to 0400, as it's always less.
8995
395fcb93 8996 * floatfns.c (Fexpt):
327eeec8
PE
8997 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8998
abbd3d23
PE
8999 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9000 for characters.
9001
684a03ef
PE
9002 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9003
0fed43f3
PE
9004 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9005 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9006 incorrectly succeed when S was a string, because 4294967386 was
9007 truncated before it was used.
9008
8fd02eb7
PE
9009 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9010 Otherwise, an out-of-range integer could cause undefined behavior
9011 on a 64-bit host.
9012
f8c86b69
PE
9013 * composite.c: Use int, not EMACS_INT, for characters.
9014 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9015 EMACS_INT, for values that are known to be in character range.
9016 This doesn't fix any bugs but is the usual style inside Emacs and
9017 may generate better code on 32-bit machines.
9018
34206dd2
PE
9019 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9020 This is for reasons similar to the recent CHAR_STRING fix.
9021 * charset.c (Fencode_char): Check that character arg is actually
9022 a character. Pass an int to ENCODE_CHAR.
9023 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9024 wider than 'int', as a compile-time check to prevent future regressions
9025 in this area.
9026
c5958d4c 9027 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9028
9029 Make sure a 64-bit char is never passed to CHAR_STRING.
9030 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9031 by silently ignoring the top 32 bits, allowing some values
9032 that were far too large to be valid characters.
9033 * character.h: Include <verify.h>.
9034 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9035 arguments are no wider than unsigned, as a compile-time check
9036 to prevent future regressions in this area.
9037 * data.c (Faset):
01103c44 9038 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9039 (Fsubst_char_in_region):
9040 * fns.c (concat):
9041 * xdisp.c (decode_mode_spec_coding):
9042 Adjust to CHAR_STRING's new requirement.
9043 * editfns.c (Finsert_char, Fsubst_char_in_region):
9044 * fns.c (concat): Check that character args are actually
9045 characters. Without this test, these functions did the wrong
9046 thing with wildly out-of-range values on 64-bit hosts.
9047
d37ca623
PE
9048 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9049 These casts should not be needed on 32-bit hosts, either.
9050 * keyboard.c (read_char):
9051 * lread.c (Fload): Remove casts to unsigned.
9052
ea204efb
PE
9053 * lisp.h (UNSIGNED_CMP): New macro.
9054 This fixes comparison bugs on 64-bit hosts.
9055 (ASCII_CHAR_P): Use it.
9056 * casefiddle.c (casify_object):
01103c44 9057 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9058 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9059 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9060 * dispextern.h (FACE_FROM_ID):
9061 * keyboard.c (read_char): Use UNSIGNED_CMP.
9062
41cb286c
PE
9063 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9064 not to EMACS_INT, to avoid GCC warning.
9065
4a1b9832
PE
9066 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9067
55daad71
PE
9068 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9069 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9070 isn't needed on 32-bit machines.
8f95c75c 9071
01103c44
PE
9072 * buffer.c (Fgenerate_new_buffer_name):
9073 Use EMACS_INT for count, not int.
0ceccced 9074 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9075
9076 * data.c (Qcompiled_function): Now static.
9077
c6f072e7
PE
9078 * window.c (window_body_lines): Now static.
9079
20ce5912
PE
9080 * image.c (gif_load): Rename local to avoid shadowing.
9081
9c4c5f81
PE
9082 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9083 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9084 * alloc.c (make_save_value): Integer argument is now of type
9085 ptrdiff_t, not int.
9086 (mark_object): Use ptrdiff_t, not int.
9087 * lisp.h (pD): New macro.
9088 * print.c (print_object): Use it.
9089
c0c5c8ae
PE
9090 * alloc.c: Use EMACS_INT, not int, to count objects.
9091 (total_conses, total_markers, total_symbols, total_vector_size)
9092 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9093 (total_free_floats, total_floats, total_free_intervals)
9094 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9095 Now EMACS_INT, not int. All uses changed.
9096 (Fgarbage_collect): Compute overall total using a double, so that
9097 integer overflow is less likely to be a problem. Check for overflow
9098 when converting back to an integer.
5a25e253
PE
9099 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9100 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9101 These were 'int' variables that could overflow on 64-bit hosts;
9102 they were never used, so remove them instead of repairing them.
211a0b2a 9103 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9104 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9105 Previously, this ceilinged at INT_MAX, but that doesn't work on
9106 64-bit machines.
e46bb31a 9107 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9108
c78baabf 9109 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9110 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9111 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9112 when a (possibly-narrower) signed value would do just as well.
9113 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9114
c9d624c6
PE
9115 * alloc.c: Catch some string size overflows that we were missing.
9116 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9117 for convenience in STRING_BYTES_MAX.
9118 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9119 The definition here is exact; the one in lisp.h was approximate.
9120 (allocate_string_data): Check for string overflow. This catches
9121 some instances we weren't catching before. Also, it catches
9122 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9123 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9124 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9125
c9d624c6
PE
9126 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9127 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9128 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9129
353032ce
PE
9130 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9131
2bccce07
PE
9132 * alloc.c (Fmake_string): Check for out-of-range init.
9133
0ac30604
SM
91342011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9135
9136 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9137
c195f2de
JD
91382011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9139
9140 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9141 xg_get_default_scrollbar_width.
9142
9143 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9144 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9145 (style_changed_cb): Call update_theme_scrollbar_width and call
9146 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9147 all frames (Bug#8505).
9148 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9149 Call gtk_window_set_resizable if HAVE_GTK3.
9150 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9151 and height if HAVE_GTK3 (Bug#8505).
9152 (scroll_bar_width_for_theme): New variable.
9153 (update_theme_scrollbar_width): New function.
9154 (xg_get_default_scrollbar_width): Move code to
9155 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9156 (xg_initialize): Call update_theme_scrollbar_width.
9157
9158 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9159
9160 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9161
e10ac9f1
MR
91622011-06-12 Martin Rudalics <rudalics@gmx.at>
9163
9164 * frame.c (make_frame): Call other_buffer_safely instead of
9165 other_buffer.
9166
9167 * window.c (temp_output_buffer_show): Call display_buffer with
9168 second argument Vtemp_buffer_show_specifiers and reset latter
9169 immediately after the call.
9170 (Vtemp_buffer_show_specifiers): New variable.
9171 (auto_window_vscroll_p, next_screen_context_lines)
9172 (Vscroll_preserve_screen_position): Remove leading asterisks from
9173 doc-strings.
9174
2d3c217e 91752011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9176
7b7f97e8 9177 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9178 * buffer.c (Qclone_number): Remove for now, as it's unused.
9179 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9180 (record_buffer): Remove unused local.
9181 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9182 (set_frame_buffer_list): Remove; unused.
9183 * frame.h (other_visible_frames): Remove decl.
9184 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9185 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9186 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9187 if HAVE_GPM.
9188 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9189 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9190 Define only if HAVE_GPM.
9191 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9192 (update_hints_inhibit): Remove; never set. All uses removed.
9193 * widgetprv.h (emacsFrameClassRec): Remove decl.
9194 * window.c (delete_deletable_window): Now returns void, since it
9195 wasn't returning anything.
9196 (compare_window_configurations): Remove unused locals.
9197 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9198 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9199 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9200 the same widths as pointers. This follows up on the 2011-05-06 patch.
9201 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9202 * xterm.h: Likewise.
9203 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9204
1384b89e
JB
92052011-06-12 Juanma Barranquero <lekktu@gmail.com>
9206
9207 * makefile.w32-in: Update dependencies.
9208 (LISP_H): Add lib/intprops.h.
9209
1100a63c
CY
92102011-06-11 Chong Yidong <cyd@stupidchicken.com>
9211
9212 * image.c (gif_load): Add animation frame delay to the metadata.
9213 (syms_of_image): Use DEFSYM. New symbol `delay'.
9214
6198ccd0
MR
92152011-06-11 Martin Rudalics <rudalics@gmx.at>
9216
9217 * window.c (delete_deletable_window): Re-add.
9218 (Fset_window_configuration): Rewrite to handle dead buffers and
9219 consequently deletable windows.
9220 (window_tree, Fwindow_tree): Remove. Supply functionality in
9221 window.el.
9222 (compare_window_configurations): Simplify code.
9223
b6e3633c
AS
92242011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9225
1ab0dee5
AS
9226 * image.c (imagemagick_load_image): Fix type mismatch.
9227 (Fimagemagick_types): Likewise.
9228
b6e3633c
AS
9229 * window.h (replace_buffer_in_windows): Declare.
9230
9397e56f
MR
92312011-06-11 Martin Rudalics <rudalics@gmx.at>
9232
9233 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9234 Qclone_number. Remove external declaration of Qdelete_window.
9235 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9236 code.
640c8776
SM
9237 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9238 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9239 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9240 buffer list implementation.
9241 (other_buffer_safely): New function.
9242 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9243 calls to replace_buffer_in_windows and
9244 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9245 if allowed.
9246 (record_buffer): Inhibit quitting and rewrite using quittable
9247 functions. Run Qbuffer_list_update_hook if allowed.
9248 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9249 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9250 Move switch-to-buffer to window.el.
9397e56f
MR
9251 (bury-buffer): Move to window.el.
9252 (Vbuffer_list_update_hook): New variable.
9253
9254 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9255 section.
9256
9257 * window.h (resize_frame_windows): Move up in code.
9258 (Fwindow_frame): Remove EXFUN.
9259 (replace_buffer_in_all_windows): Remove prototype.
9260 (replace_buffer_in_windows_safely): Add prototype.
9261
9262 * window.c: Declare Qdelete_window static again. Move down
9263 declaration of select_count.
9264 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9265 (Fother_window): Move to window.el.
9266 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9267 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9268 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9269 window.el.
9270 (replace_buffer_in_windows): Implement by calling
9271 Qreplace_buffer_in_windows.
9272 (replace_buffer_in_all_windows): Remove with some functionality
9273 moved into replace_buffer_in_windows_safely.
9274 (replace_buffer_in_windows_safely): New function.
9275 (select_window_norecord, select_frame_norecord): Move in front
9276 of run_window_configuration_change_hook. Remove now obsolete
9277 declarations.
640c8776
SM
9278 (Fset_window_buffer): Rewrite doc-string.
9279 Call Qrecord_window_buffer.
9397e56f
MR
9280 (keys_of_window): Move binding for other-window to window.el.
9281
b50691aa
CY
92822011-06-11 Chong Yidong <cyd@stupidchicken.com>
9283
9284 * dispextern.h (struct image): Replace data member, whose int_val
9285 and ptr_val fields were not used by anything, with a single
9286 lisp_val object.
9287
9288 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9289 (gif_clear_image, gif_load, imagemagick_load_image)
9290 (gs_clear_image, gs_load): Callers changed.
9291
3f754b86
PE
92922011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9293
cca69397
PE
9294 * buffer.h: Include <time.h>, for time_t.
9295 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9296
109e28d0
PE
9297 Fix minor problems found by static checking.
9298
60737f02
PE
9299 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9300
4b66faf3
PE
9301 Make identifiers static if they are not used in other modules.
9302 * data.c (Qcompiled_function, Qframe, Qvector):
9303 * image.c (QimageMagick, Qsvg):
9304 * minibuf.c (Qmetadata):
9305 * window.c (resize_window_check, resize_root_window): Now static.
9306 * window.h (resize_window_check, resize_root_window): Remove decls.
9307
109e28d0
PE
9308 * window.c (window_deletion_count, delete_deletable_window):
9309 Remove; unused.
46a4ce9e
PE
9310 (window_body_lines): Now static.
9311 (Fdelete_other_windows_internal): Mark vars as initialized.
9312 Make sure 'resize_failed' is initialized.
9313 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9314 (resize_window_apply): Remove unused local.
9315 * window.h (delete_deletable_window): Remove decl.
9316
109e28d0 9317 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9318 (imagemagick_load_image): Fix pointer signedness problem by changing
9319 last arg from unsigned char * to char *. All uses changed.
9320 Also, fix a local for similar reasons.
9321 Remove unused locals. Remove locals to avoid shadowing.
9322 (fn_rsvg_handle_free): Remove; unused.
9323 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9324 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9325
3f754b86
PE
9326 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9327
2547adb1
CY
93282011-06-10 Chong Yidong <cyd@stupidchicken.com>
9329
9330 * image.c (gif_load): Fix omitted cast error introduced by
9331 2011-06-06 change.
9332
2c8e37d4
MR
93332011-06-10 Martin Rudalics <rudalics@gmx.at>
9334
9335 * window.h (resize_proportionally, orig_total_lines)
9336 (orig_top_line): Remove from window structure.
9337 (set_window_height, set_window_width, change_window_heights)
9338 (Fdelete_window): Remove prototypes.
9339 (resize_frame_windows): Remove duplicate declaration.
9340
440a42e3
EZ
93412011-06-10 Eli Zaretskii <eliz@gnu.org>
9342
9343 * window.h (resize_frame_windows, resize_window_check)
9344 (delete_deletable_window, resize_root_window)
9345 (resize_frame_windows): Declare prototypes.
9346
9347 * window.c (resize_window_apply): Make definition be "static" to
9348 match the prototype.
9349
562dd5e9
MR
93502011-06-10 Martin Rudalics <rudalics@gmx.at>
9351
9352 * window.c: Remove declarations of Qwindow_size_fixed,
9353 window_min_size_1, window_min_size_2, window_min_size,
9354 size_window, window_fixed_size_p, enlarge_window, delete_window.
9355 Remove static from declaration of Qdelete_window, it's
9356 temporarily needed by Fbury_buffer.
9357 (replace_window): Don't assign orig_top_line and
9358 orig_total_lines.
9359 (Fdelete_window, delete_window): Remove. Window deletion is
9360 handled by window.el.
640c8776
SM
9361 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9362 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9363 (Fdelete_other_windows): Remove. Deleting other windows is
9364 handled by window.el.
9365 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9366 handled in window.el.
9367 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9368 Window minimum sizes are handled in window.el.
9369 (shrink_windows, size_window, set_window_height)
9370 (set_window_width, change_window_heights, window_height)
9371 (window_width, CURBEG, CURSIZE, enlarge_window)
9372 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9373 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9374 handled in window.el.
9375 (make_dummy_parent): Rename to make_parent_window and give it a
9376 second argument horflag.
9377 (make_window): Don't set resize_proportionally any more.
9378 (Fsplit_window): Remove. Windows are split in window.el.
9379 (save_restore_action, save_restore_orig_size)
9380 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9381 Resize mini windows in window.el.
9382 (grow_mini_window, shrink_mini_window): Implement by calling
9383 Qresize_root_window_vertically, resize_window_check and
9384 resize_window_apply.
640c8776
SM
9385 (saved_window, Fset_window_configuration, save_window_save):
9386 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9387 resize_proportionally.
9388 (window_min_height, window_min_width): Move to window.el.
9389 (keys_of_window): Move bindings for delete-other-windows,
9390 split-window, delete-window and enlarge-window to window.el.
9391
9392 * buffer.c: Temporarily extern Qdelete_window.
9393 (Fbury_buffer): Temporarily call Qdelete_window instead of
9394 Fdelete_window (Fbury_buffer will move to window.el soon).
9395
9396 * frame.c (set_menu_bar_lines_1): Remove code handling
9397 orig_top_line and orig_total_lines.
9398
9399 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9400 set_window_height but set heights directly.
9401 (change_frame_size_1): Use resize_frame_windows.
9402
9403 * xdisp.c (init_xdisp): Don't use set_window_height but set
9404 heights directly.
9405
640c8776
SM
9406 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9407 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9408 run_window_configuration_change_hook.
9409
9410 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9411 instead of change_window_heights and run
9412 run_window_configuration_change_hook.
9413
1a13852e
MR
94142011-06-09 Martin Rudalics <rudalics@gmx.at>
9415
9416 * window.c (replace_window): Rename second argument REPLACEMENT to
9417 NEW. New third argument SETFLAG. Rewrite.
9418 (delete_window, make_dummy_parent): Call replace_window with
9419 third argument 1.
9420 (window_list_1): Move down in code.
9421 (run_window_configuration_change_hook): Move set_buffer part
9422 before select_frame_norecord part in order to unwind correctly.
9423 Rename count1 to count.
9424 (recombine_windows, delete_deletable_window, resize_root_window)
9425 (Fdelete_other_windows_internal)
9426 (Frun_window_configuration_change_hook, make_parent_window)
9427 (resize_window_check, resize_window_apply, Fresize_window_apply)
9428 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9429 (Fdelete_window_internal, Fresize_mini_window_internal):
9430 New functions.
1a13852e
MR
9431 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9432
f3d1777e
MR
94332011-06-08 Martin Rudalics <rudalics@gmx.at>
9434
496e208e
MR
9435 * window.h (window): Add some new members to window structure -
9436 normal_lines, normal_cols, new_total, new_normal, clone_number,
9437 splits, nest, prev_buffers, next_buffers.
9438 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9439 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9440
f3d1777e
MR
9441 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9442 Remove.
496e208e
MR
9443 (make_dummy_parent): Set new members of windows structure.
9444 (make_window): Move down in code. Handle new members of window
9445 structure.
9446 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9447 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9448 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9449 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9450 (Fset_window_next_buffers, Fset_window_clone_number):
9451 New functions.
496e208e
MR
9452 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9453 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9454 Doc-string fixes.
9455 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9456 Argument WINDOW can be now internal window too.
9457 (Fwindow_use_time): Move up in code.
9458 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9459 Rewrite doc-string.
9460 (Fset_window_configuration, saved_window)
9461 (Fcurrent_window_configuration, save_window_save): Handle new
9462 members of window structure.
b9e809c2
MR
9463 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9464 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9465 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9466 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9467 Qget_mru_window, Qresize_root_window,
9468 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9469 Qauto_buffer_name; staticpro them.
f3d1777e 9470
abde8f8c
MR
94712011-06-07 Martin Rudalics <rudalics@gmx.at>
9472
9473 * window.c (Fwindow_total_size, Fwindow_left_column)
9474 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9475 (Fwindow_list_1): New functions.
9476 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9477 (Fwindow_width, Fscroll_left, Fscroll_right):
9478 Use window_body_cols instead of window_box_text_cols.
9479 (delete_window, Fset_window_configuration):
9480 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9481 (delete_all_subwindows): Take a window as argument and not a
9482 structure. Rewrite.
190b47e6
MR
9483 (window_loop): Remove handling of GET_LRU_WINDOW and
9484 GET_LARGEST_WINDOW.
9485 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9486
9487 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9488 window_box_text_cols. delete_all_subwindows now takes a
9489 Lisp_Object as argument.
abde8f8c 9490
640c8776
SM
9491 * indent.c (compute_motion, Fcompute_motion):
9492 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9493
fa8a67e6
MR
9494 * frame.c (delete_frame): Call delete_all_subwindows with root
9495 window as argument.
9496
a54e3482
DC
94972011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9498
9499 * fns.c (Fputhash): Document return value.
9500
60002bf5
CY
95012011-06-06 Chong Yidong <cyd@stupidchicken.com>
9502
9503 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9504
0c671da6 95052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9506
b862a52a 9507 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9508
be44ca6c
PE
9509 Check for overflow when converting integer to cons and back.
9510 * charset.c (Fdefine_charset_internal, Fdecode_char):
9511 Use cons_to_unsigned to catch overflow.
9512 (Fencode_char): Use INTEGER_TO_CONS.
9513 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9514 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9515 * data.c (long_to_cons, cons_to_long): Remove.
9516 (cons_to_unsigned, cons_to_signed): New functions.
9517 These signal an error for invalid or out-of-range values.
9518 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9519 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9520 * font.c (Ffont_variation_glyphs):
9521 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9522 * lisp.h: Include <intprops.h>.
9523 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9524 (cons_to_signed, cons_to_unsigned): New decls.
9525 (long_to_cons, cons_to_long): Remove decls.
9526 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9527 (Fprimitive_undo): Use CONS_TO_INTEGER.
9528 * xfns.c (Fx_window_property): Likewise.
9529 * xselect.c: Include <limits.h>.
9530 (x_own_selection, selection_data_to_lisp_data):
9531 Use INTEGER_TO_CONS.
9532 (x_handle_selection_request, x_handle_selection_clear)
9533 (x_get_foreign_selection, Fx_disown_selection_internal)
9534 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9535 (lisp_data_to_selection_data): Use cons_to_unsigned.
9536 (x_fill_property_data): Use cons_to_signed.
9537 Report values out of range.
9538
d1f3d2af
PE
9539 Check for buffer and string overflow more precisely.
9540 * buffer.h (BUF_BYTES_MAX): New macro.
9541 * lisp.h (STRING_BYTES_MAX): New macro.
9542 * alloc.c (Fmake_string):
9543 * character.c (string_escape_byte8):
9544 * coding.c (coding_alloc_by_realloc):
9545 * doprnt.c (doprnt):
9546 * editfns.c (Fformat):
9547 * eval.c (verror):
9548 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9549 since they may not be the same number.
9550 * editfns.c (Finsert_char):
9551 * fileio.c (Finsert_file_contents):
9552 Likewise for BUF_BYTES_MAX.
9553
dd52fcea
PE
9554 * image.c: Use ptrdiff_t, not int, for sizes.
9555 (slurp_file): Switch from int to ptrdiff_t.
9556 All uses changed.
9557 (slurp_file): Check that file size fits in both size_t (for
9558 malloc) and ptrdiff_t (for sanity and safety).
9559
7f9bbdbb
PE
9560 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9561 if b->modtime has its maximal value.
9562
dfe18f82
PE
9563 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9564
84acfcf0
PE
9565 Don't assume time_t can fit into int.
9566 * buffer.h (struct buffer.modtime): Now time_t, not int.
9567 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9568 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9569
ccd9a01a
PE
9570 Minor fixes for signed vs unsigned integers.
9571 * character.h (MAYBE_UNIFY_CHAR):
9572 * charset.c (maybe_unify_char):
9573 * keyboard.c (read_char, reorder_modifiers):
9574 XINT -> XFASTINT, since the integer must be nonnegative.
9575 * ftfont.c (ftfont_spec_pattern):
9576 * keymap.c (access_keymap, silly_event_symbol_error):
9577 XUINT -> XFASTINT, since the integer must be nonnegative.
9578 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9579 since it makes no difference and we prefer signed.
9580 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9581 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9582 nonnegative.
9583
d6d100dd
SM
95842011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9585
9586 * window.h (Fwindow_frame): Declare.
9587
2b6148e4
PE
95882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9589
9590 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9591 (SPARE_MEMORY): Always define.
9592 (LARGE_REQUEST): Remove.
9593 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9594
f230ecc9
MR
95952011-06-06 Martin Rudalics <rudalics@gmx.at>
9596
727e958e
MR
9597 * lisp.h: Move EXFUNS for Fframe_root_window,
9598 Fframe_first_window and Fset_frame_selected_window to window.h.
9599
9600 * window.h: Move EXFUNS for Fframe_root_window,
9601 Fframe_first_window and Fset_frame_selected_window here from
9602 lisp.h.
9603
9604 * frame.c (Fwindow_frame, Fframe_first_window)
9605 (Fframe_root_window, Fframe_selected_window)
9606 (Fset_frame_selected_window): Move to window.c.
9607 (Factive_minibuffer_window): Move to minibuf.c.
9608 (Fother_visible_frames_p): New function.
9609
9610 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9611
f230ecc9
MR
9612 * window.c (decode_window, decode_any_window): Move up in code.
9613 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9614 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9615 (Fwindow_buffer): Move up and rewrite doc-string.
9616 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9617 (Fwindow_prev): New functions.
727e958e
MR
9618 (Fwindow_frame): Move here from frame.c. Accept any window as
9619 argument.
9620 (Fframe_root_window, Fframe_first_window)
9621 (Fframe_selected_window): Move here from frame.c. Accept frame
9622 or arbitrary window as argument. Update doc-strings.
9623 (Fminibuffer_window): Move up in code.
9624 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9625 (Fset_frame_selected_window): Move here from frame.c.
9626 Marginal rewrite.
727e958e
MR
9627 (Fselected_window, select_window, Fselect_window): Move up in
9628 code. Minor doc-string fixes.
f230ecc9 9629
4d09bcf6
PE
96302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9631
9632 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9633 Do not assume that spare memory exists; that assumption is valid
9634 only if SYSTEM_MALLOC.
9635 (LARGE_REQUEST): New macro, so that the issue of large requests
9636 is separated from the issue of spare memory.
9637
810928a2
AS
96382011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9639
172418ad
AS
9640 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9641 format. (Bug#8806)
9642
43f862f7
AS
9643 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9644
810928a2
AS
9645 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9646 before statements.
9647
a059fe24
JD
96482011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9649
9650 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9651
9652 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9653
9654 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9655 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9656
989bf368
JB
96572011-06-05 Juanma Barranquero <lekktu@gmail.com>
9658
9659 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9660
4b80f674
CY
96612011-06-04 Chong Yidong <cyd@stupidchicken.com>
9662
9663 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9664 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9665 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9666 New error handlers.
4b80f674
CY
9667 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9668 Obey Vx_select_enable_clipboard_manager. Catch errors in
9669 x_clipboard_manager_save (Bug#8779).
9670 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9671 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9672
99a33b77 96732011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9674
9675 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9676
99a33b77 96772011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9678
9679 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9680 in the current matrix if keep_current_p is non-zero.
9681
8264569d
EZ
96822011-06-04 Eli Zaretskii <eliz@gnu.org>
9683
9684 * bidi.c (bidi_level_of_next_char): Fix last change.
9685
57f97249
EZ
96862011-06-03 Eli Zaretskii <eliz@gnu.org>
9687
fec2107c 9688 Support bidi reordering of text covered by display properties.
57f97249 9689
fec2107c
EZ
9690 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9691 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9692 (bidi_cache_search, bidi_cache_iterator_state)
9693 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9694 (bidi_level_of_next_char, bidi_move_to_visually_next):
9695 Support character positions inside a run of characters covered by a
fec2107c
EZ
9696 display string.
9697 (bidi_paragraph_init, bidi_resolve_explicit_1)
9698 (bidi_level_of_next_char): Call bidi_fetch_char and
9699 bidi_fetch_char_advance instead of FETCH_CHAR and
9700 FETCH_CHAR_ADVANCE.
9701 (bidi_init_it): Initialize new members.
9702 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9703 definitions.
9704 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9705 instead of using explicit *_CHAR codes.
d6d100dd
SM
9706 (bidi_resolve_explicit, bidi_resolve_weak):
9707 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9708 bidirectional text is supported only in multibyte buffers.
9709 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9710 it to initialize the frame_window_p member of struct bidi_it.
9711 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9712 (bidi_resolve_explicit, bidi_resolve_weak)
9713 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9714 bidi_it->nchars is non-positive.
9715 (bidi_level_of_next_char): Don't try to lookup the cache for the
9716 next/previous character if nothing is cached there yet, or if we
9717 were just reseat()'ed to a new position.
c40e2fb2 9718
0e14fe90
EZ
9719 * xdisp.c (set_cursor_from_row): Set start and stop points
9720 according to the row's direction when priming the loop that looks
9721 for the glyph on which to display cursor.
9722 (single_display_spec_intangible_p): Function deleted.
9723 (display_prop_intangible_p): Reimplement to call
9724 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9725 Accept 3 additional arguments needed by handle_display_spec.
9726 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9727 values: lists, `(when COND...)' forms, etc.
9728 (single_display_spec_string_p): Support property values that are
9729 lists with the argument STRING its top-level element.
9730 (display_prop_string_p): Fix the condition for processing a
9731 property that is a list to be consistent with handle_display_spec.
fec2107c 9732 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9733 last portion of handle_display_prop.
9734 (compute_display_string_pos): Accept additional argument
9735 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9736 value of a `display' property is a "replacing spec".
9737 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9738 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9739 the display property, but just return a value indicating whether
9740 the display property will replace the characters it covers.
9741 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9742 frame_window_p members of struct bidi_it.
d6d100dd
SM
9743 (compute_display_string_pos, compute_display_string_end):
9744 New functions.
fec2107c
EZ
9745 (push_it): Accept second argument POSITION, where pop_it should
9746 jump to continue iteration.
9747 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9748
fec2107c
EZ
9749 * keyboard.c (adjust_point_for_property): Adjust the call to
9750 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9751
9752 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9753 (bidi_init_it): Update prototypes.
9754 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9755 (compute_display_string_pos, compute_display_string_end):
9756 Declare prototypes.
fec2107c
EZ
9757 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9758 EMACS_INT.
fc6f18ce 9759
40087514 97602011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9761
57f53182
PE
9762 Malloc failure behavior now depends on size of allocation.
9763 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9764 * lisp.h: Change signatures accordingly.
9765 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9766 All callers changed. (Bug#8762)
9767
9768 * gnutls.c: Use Emacs's memory allocators.
9769 Without this change, the gnutls library would invoke malloc etc.
9770 directly, which causes problems on non-SYNC_INPUT hosts, and which
9771 runs afoul of improving memory_full behavior. (Bug#8761)
9772 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9773 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9774 xfree instead of the default malloc, realloc, free.
9775 (Fgnutls_boot): No need to check for memory allocation failure,
9776 since xmalloc does that for us.
9777
ac32cd99 9778 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9779 * category.c (hash_get_category_set):
9780 * ccl.c (ccl_driver):
9781 * charset.c (Fdefine_charset_internal):
9782 * charset.h (struct charset.hash_index):
9783 * composite.c (get_composition_id, gstring_lookup_cache)
9784 (composition_gstring_put_cache):
9785 * composite.h (struct composition.hash_index):
9786 * dispextern.h (struct image.hash):
9787 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9788 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9789 (hashfn_equal, hashfn_user_defined, make_hash_table)
9790 (maybe_resize_hash_table, hash_lookup, hash_put)
9791 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9792 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9793 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9794 * image.c (make_image, search_image_cache, lookup_image)
9795 (xpm_put_color_table_h):
9796 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9797 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9798 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9799 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9800 * alloc.c (allocate_vectorlike):
9801 Check for overflow in vector size calculations.
9802 * ccl.c (ccl_driver):
9803 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9804 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9805 need to be updated by these changes.
40087514
PE
9806 * fns.c (make_hash_table, maybe_resize_hash_table):
9807 Check for integer overflow with large hash tables.
0de4bb68
PE
9808 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9809 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9810 (SXHASH_REDUCE): New macro.
9811 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9812 Use it instead of discarding useful hash info with large hash values.
9813 (sxhash_float): New function.
9814 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9815 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9816 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9817 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9818 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9819 Adjust signatures to match updated version of code.
9820 (consing_since_gc): Now EMACS_INT, since a single hash table can
9821 use more than INT_MAX bytes.
9822
698d32e2
DN
98232011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9824
9825 Make it possible to build with GCC-4.6+ -O2 -flto.
9826
9827 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9828
fd6fa53f
SM
98292011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9830
9831 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9832 Call minibuffer-inactive-mode.
9833
864db017
JB
98342011-05-31 Juanma Barranquero <lekktu@gmail.com>
9835
9836 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9837 Update dependencies.
9838
2ad0baf4
DN
98392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9840
9841 * data.c (init_data): Remove code for UTS, this system is not
9842 supported anymore.
9843
4fcc2638
DN
98442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9845
9846 Don't force ./temacs to start in terminal mode.
9847
9848 * frame.c (make_initial_frame): Initialize faces in all cases, not
9849 only when CANNOT_DUMP is defined.
9850 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9851
c56e0fd5
DN
98522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9853
9854 * dispnew.c (add_window_display_history): Use const for the string
9855 pointer. Remove declaration, not needed.
9856
333d54da 98572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9858
55d4c1b2 9859 Use 'inline', not 'INLINE'.
333d54da 9860 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9861 * alloc.c, fontset.c (INLINE): Remove.
9862 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9863 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9864 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9865 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9866 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9867
738db178
DN
98682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9869
9870 Make it possible to run ./temacs.
9871
9872 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9873 syms_of_callproc does the same thing. Remove test for
9874 "initialized", do it in the caller.
9875 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9876
620c53a6
SM
98772011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9878
9879 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9880 (read_minibuf): Use get_minibuffer.
9881 (syms_of_minibuf): Use DEFSYM.
9882 (Qmetadata): New var.
9883 * data.c (Qbuffer): Don't make it static.
9884 (syms_of_data): Use DEFSYM.
9885
e003a292
PE
98862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9887
9888 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9889 (CCL_CODE_MIN): New macro.
9890
ed008a6d
PE
98912011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9892
3687c2ef
PE
9893 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9894
ed008a6d
PE
9895 * eval.c (Qdebug): Now static.
9896 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9897 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9898 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9899
d66c4c7c
CY
99002011-05-29 Chong Yidong <cyd@stupidchicken.com>
9901
9902 * image.c: Various fixes to ImageMagick code comments.
9903 (Fimagemagick_types): Doc fix.
9904
5fbc2025
PE
99052011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9906
0196f88a
PE
9907 Minor fixes prompted by GCC 4.6.0 warnings.
9908
9909 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9910
5fbc2025
PE
9911 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9912 (x_clipboard_manager_save_all): Move extern decl to ...
9913 * xterm.h: ... here, so that it can be checked for consistency.
9914
1dd3c2d9
CY
99152011-05-29 Chong Yidong <cyd@stupidchicken.com>
9916
9917 * xselect.c (x_clipboard_manager_save_frame)
9918 (x_clipboard_manager_save_all): New functions.
9919 (Fx_clipboard_manager_save): Lisp function deleted.
9920
9921 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9922 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9923
9924 * xterm.h: Update prototype.
9925
5ba6571d
WX
99262011-05-28 William Xu <william.xwl@gmail.com>
9927
9928 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9929 exiting (Bug#8239).
9930
3eaff834
JM
99312011-05-28 Jim Meyering <meyering@redhat.com>
9932
e1900994 9933 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9934 * fns.c (to_uchar): Define.
9935 (crypto_hash_function): Use it to convert some newly-signed
9936 variables to unsigned, to avoid sign-extension bugs. For example,
9937 without this change, (md5 "truc") would evaluate to
9938 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9939 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9940 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9941
0f6990a7
PE
99422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9943
9944 Integer overflow fixes.
c8a9ca5a 9945
08686060
PE
9946 * dbusbind.c: Serial number integer overflow fixes.
9947 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9948 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9949 to hold a serial number that is too large for a fixnum.
9950 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9951 Check for serial numbers out of range. Decode any serial number
59568bf0 9952 that was so large that it became a float. (Bug#8722)
08686060 9953
2d1fc3c7
PE
9954 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9955 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9956 Use XFASTINT rather than XUINT when numbers are nonnegative.
9957 (xd_append_arg, Fdbus_method_return_internal):
9958 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9959 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9960 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9961 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9962 (Bug#8722)
2d1fc3c7 9963
c8a9ca5a
PE
9964 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9965
519e1d69
PE
9966 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9967
6df6ae42 9968 ccl: Add integer overflow checks.
30569699
PE
9969 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9970 (IN_INT_RANGE): New macros.
9971 (ccl_driver): Use them to check for integer overflow when
9972 decoding a CCL program. Many of the new checks are whether XINT (x)
9973 fits in int; it doesn't always, on 64-bit hosts. The new version
9974 doesn't catch all possible integer overflows, but it's an
847044ea 9975 improvement. (Bug#8719)
30569699 9976
c11285dc
PE
9977 * alloc.c (make_event_array): Use XINT, not XUINT.
9978 There's no need for unsigned here.
9979
fdccd48e
PE
9980 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9981 This follows up to the 2011-05-06 change that substituted uintptr_t
9982 for EMACS_INT. This case wasn't caught back then.
9983
37910ab2
PE
9984 Rework Fformat to avoid integer overflow issues.
9985 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9986 now (part of C89). Include <verify.h>.
9987 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9988 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9989 (Fformat): Avoid the prepass trying to compute sizes; it was only
9990 approximate and thus did not catch overflow reliably. Instead, walk
9991 through the format just once, formatting and computing sizes as we go,
9992 checking for integer overflow at every step, and allocating a larger
9993 buffer as needed. Keep track separately whether the format is
9994 multibyte. Keep only the most-recently calculated precision, rather
9995 than them all. Record whether each argument has been converted to
9996 string. Use EMACS_INT, not int, for byte and char and arg counts.
9997 Support field widths and precisions larger than INT_MAX. Avoid
9998 sprintf's undefined behavior with conversion specifications such as %#d
9999 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10000 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10001 formatting out-of-range floating point numbers with int
9173deec 10002 formats. (Bug#8668)
37910ab2 10003
2e6578fb
PE
10004 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10005
0ae6bdee
PE
10006 * data.c: Avoid integer truncation in expressions involving floats.
10007 * data.c: Include <intprops.h>.
10008 (arith_driver): When there's an integer overflow in an expression
10009 involving floating point, convert the integers to floating point
10010 so that the resulting value does not suffer from catastrophic
10011 integer truncation. For example, on a 64-bit host (* 4
10012 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10013 Do not rely on undefined behavior after integer overflow.
10014
de883a70
PE
10015 merge count_size_as_multibyte, parse_str_to_multibyte
10016 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10017 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10018 Check for integer overflow.
10019 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10020 since it's now a duplicate of the other. This is more of
10021 a character than a buffer op, so better that it's in character.c.
10022 * fns.c, print.c: Adjust to above changes.
10023
2ff916cb
PE
100242011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10025
10026 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10027
f1b54466
PE
100282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10029
fb1ac845
PE
10030 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10031 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10032 (x_clipboard_manager_save): Now static.
10033 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10034
f1b54466
PE
10035 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10036 (crypto_hash_function): Now static.
10037 Fix pointer signedness problems. Avoid unnecessary initializations.
10038
a9f737ee
CY
100392011-05-27 Chong Yidong <cyd@stupidchicken.com>
10040
10041 * termhooks.h (Vselection_alist): Make it terminal-local.
10042
10043 * terminal.c (create_terminal): Initialize it.
10044
10045 * xselect.c: Support for clipboard managers.
10046 (Vselection_alist): Move to termhooks.h as terminal-local var.
10047 (LOCAL_SELECTION): New macro.
10048 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10049 (symbol_to_x_atom): Remove gratuitous arg.
10050 (x_handle_selection_request, lisp_data_to_selection_data)
10051 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10052 (x_own_selection, x_get_local_selection, x_convert_selection):
10053 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10054 (some_frame_on_display): Delete unused function.
10055 (Fx_own_selection_internal, Fx_get_selection_internal)
10056 (Fx_disown_selection_internal, Fx_selection_owner_p)
10057 (Fx_selection_exists_p): New optional frame arg.
10058 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10059 (x_handle_selection_clear): Don't treat other terminals with the
10060 same keyboard specially. Use the terminal-local Vselection_alist.
10061 (x_clear_frame_selections): Use Frun_hook_with_args.
10062
10063 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10064
10065 * xterm.h: Add support for those atoms.
10066
e067f0c1
CY
100672011-05-26 Chong Yidong <cyd@stupidchicken.com>
10068
10069 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10070 (converted_selections, conversion_fail_tag): New global variables.
10071 (x_selection_request_lisp_error): Free the above.
10072 (x_get_local_selection): Remove unnecessary code.
10073 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10074 of converted selections stored in converted_selections.
10075 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10076 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10077 (x_convert_selection): New function.
10078 (x_handle_selection_event): Simplify.
10079 (x_get_foreign_selection): Don't ignore incoming requests while
10080 waiting for an answer; this will fail when we implement
10081 SAVE_TARGETS, and seems unnecessary anyway.
10082 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10083 (Vx_sent_selection_functions): Doc fix.
10084
0f4aebc0
LL
100852011-05-26 Leo Liu <sdl.web@gmail.com>
10086
10087 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10088
e61124cd
YM
100892011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10090
10091 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10092
10093 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10094 for fringe update if it has periodic bitmap.
ac389d0c 10095 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10096 and fringe_bitmap_periodic_p.
10097
10098 * fringe.c (get_fringe_bitmap_data): New function.
10099 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10100 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10101 row. Mark glyph row for fringe update if periodicity changed.
10102
10103 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10104 for fringe update unless it has periodic bitmap.
10105
f16d9837
KH
101062011-05-25 Kenichi Handa <handa@m17n.org>
10107
10108 * xdisp.c (get_next_display_element): Set correct it->face_id for
10109 a static composition.
10110
e1b90ef6
LL
101112011-05-24 Leo Liu <sdl.web@gmail.com>
10112
10113 * deps.mk (fns.o):
10114 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10115
10116 * fns.c (crypto_hash_function, Fsha1): New function.
10117 (Fmd5): Use crypto_hash_function.
10118 (syms_of_fns): Add Ssha1.
10119
7400048f
PE
101202011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10121
10122 * gnutls.c: Remove unused macros.
10123 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10124 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10125 Remove macros that are defined and never used.
10126 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10127
abb71cf4
CY
101282011-05-22 Chong Yidong <cyd@stupidchicken.com>
10129
10130 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10131 (Fx_get_selection_internal): Minor cleanup.
10132 (Fx_own_selection_internal): Rename arguments for consistency with
10133 select.el.
10134
6307db39
PE
101352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10136
10137 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10138
f3d4e0a4
CY
101392011-05-22 Chong Yidong <cyd@stupidchicken.com>
10140
10141 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10142
4d8ade89
YM
101432011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10144
10145 * dispnew.c (scrolling_window): Don't exclude the case that the
10146 last enabled row in the desired matrix touches the bottom boundary.
10147
32078c8d
GM
101482011-05-21 Glenn Morris <rgm@gnu.org>
10149
10150 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10151 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10152 and add some more files.
32078c8d 10153
7285dc67
EZ
101542011-05-20 Eli Zaretskii <eliz@gnu.org>
10155
10156 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10157 report_file_error introduced by the change from 2011-05-07.
10158
89d1bd22
PE
101592011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10160
10161 * systime.h (Time): Define only if emacs is defined.
10162 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10163 where the include path doesn't have X11/X.h by default. See
10164 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10165
cd394be1 101662011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10167
10168 * composite.c (find_automatic_composition): Fix previous change.
10169
b9704ad9
GM
101702011-05-20 Glenn Morris <rgm@gnu.org>
10171
10172 * lisp.mk: New file, split from Makefile.in.
10173 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10174 (shortlisp): Remove.
10175 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10176
4a720484
GM
101772011-05-19 Glenn Morris <rgm@gnu.org>
10178
10179 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10180 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10181 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10182 (lisp): Set the order to that of loadup.el.
10183 (shortlisp): Make it a copy of $lisp.
10184 (SOME_MACHINE_LISP): Remove.
10185 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10186 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10187
a28d4396
KH
101882011-05-18 Kenichi Handa <handa@m17n.org>
10189
10190 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10191 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10192 (find_automatic_composition): Mostly rewrite for efficiency.
10193
a2b1fa8e
JB
101942011-05-18 Juanma Barranquero <lekktu@gmail.com>
10195
10196 * makefile.w32-in: Update dependencies.
10197
8e1f5610
CS
101982011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10199
10200 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10201 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10202
7025ee00 102032011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10204
cdfa6eab
PE
10205 Fix some integer overflow issues, such as string length overflow.
10206
06d6db33
PE
10207 * insdel.c (count_size_as_multibyte): Check for string overflow.
10208
2b4560a8
PE
10209 * character.c (lisp_string_width): Check for string overflow.
10210 Use EMACS_INT, not int, for string indexes and lengths; in
10211 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10212 the resulting string length overflows an EMACS_INT; instead,
10213 report a string overflow if no precision given. When checking for
10214 precision exhaustion, use a check that cannot possibly have
10215 integer overflow. (Bug#8675)
10216 * character.h (lisp_string_width): Adjust to new signature.
10217
cb93f9be
PE
10218 * alloc.c (string_overflow): New function.
10219 (Fmake_string): Use it. This doesn't change behavior, but saves
10220 a few bytes and will simplify future changes.
10221 * character.c (string_escape_byte8): Likewise.
10222 * lisp.h (string_overflow): New decl.
10223
1a1f3366
PE
10224 Fixups, following up to the user-interface timestamp change.
10225 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10226 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10227 * msdos.c (mouse_get_pos): Likewise.
10228 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10229 * w32gui.h (Time): Define by including "systime.h" rather than by
10230 declaring it ourselves. (Bug#8664)
10231
d4e3e4d3
PE
10232 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10233 * image.c (clear_image_cache): Likewise.
10234
f6a24d19
PE
10235 * term.c (term_mouse_position): Don't assume time_t wraparound.
10236
08dc5ae6
PE
10237 Be more systematic about user-interface timestamps.
10238 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10239 and sometimes 'EMACS_UINT', to represent these timestamps.
10240 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10241 This makes the code easier to follow, and makes it easier to catch
10242 integer overflow bugs such as Bug#8664.
10243 * frame.c (Fmouse_position, Fmouse_pixel_position):
10244 Use Time, not unsigned long, for user-interface timestamps.
10245 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10246 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10247 * keyboard.h (last_event_timestamp): Likewise.
10248 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10249 * menu.h (xmenu_show): Likewise.
10250 * term.c (term_mouse_position): Likewise.
10251 * termhooks.h (struct input_event.timestamp): Likewise.
10252 (struct terminal.mouse_position_hook): Likewise.
10253 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10254 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10255 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10256 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10257 what it was before.
10258 * menu.h, termhooks.h: Include "systime.h", for Time.
10259
8e55734a
PE
10260 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10261 Don't assume that the difference between two unsigned long values
10262 can fit into an integer. At this point, we know button_down_time
10263 <= event->timestamp, so the difference must be nonnegative, so
10264 there's no need to cast the result if double-click-time is
10265 nonnegative, as it should be; check that it's nonnegative, just in
10266 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10267 apart (about 25 days). (Bug#8664)
8e55734a 10268
841f1b75 10269 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10270 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10271
3e26f69c
PE
10272 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10273 that always fit in int. Use a sentinel instead of a counter, to
10274 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10275 * frame.h (struct frame): Use int for menu_bar_items_used
10276 instead of EMACS_INT, since it always fits in int.
3e26f69c 10277
5cc152c0
PE
10278 * menu.c (grow_menu_items): Check for int overflow.
10279
d89eb65e
PE
10280 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10281
5235bd3e
PE
10282 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10283 Before, the code was not consistent. These values cannot exceed
10284 2**31 - 1 so there's no need to make them unsigned.
10285 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10286 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10287 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10288 as modifiers.
10289 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10290
bc827e23
PE
10291 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10292 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10293 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10294 presumably because the widths might not match.
10295
78eb494e
PE
10296 * window.c (size_window): Avoid needless test at loop start.
10297
04f2d78b
CB
102982011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10299
10300 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10301
d2fc7e3d 103022011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10303
10304 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10305
d2fc7e3d 103062011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10307
10308 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10309 `width' to `bar_area_x' and `bar_area_width', respectively.
10310 (x_scroll_run): Take account of fringe background extension.
10311
04f2d78b
CB
10312 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10313 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10314 `bar_area_width', respectively.
10315 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10316 background extension.
10317
79b70037
GM
103182011-05-10 Jim Meyering <meyering@redhat.com>
10319
10320 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10321
2f142cc5
JB
103222011-05-10 Juanma Barranquero <lekktu@gmail.com>
10323
10324 * image.c (Finit_image_library): Return t for built-in image types,
10325 like pbm and xbm. (Bug#8640)
10326
57679c86
AS
103272011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10328
10329 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10330
888c9e86
EZ
103312011-05-07 Eli Zaretskii <eliz@gnu.org>
10332
b0512a1d
EZ
10333 * w32console.c (Fset_screen_color): Doc fix.
10334 (Fget_screen_color): New function.
10335 (syms_of_ntterm): Defsubr it.
10336
7285dc67
EZ
10337 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10338 unlink the temporary file if Fcall_process didn't create it in the
10339 first place.
10340 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10341 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10342 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10343 cue to call_process_cleanup not to close that handle.
10344
4d3fcc8e
BK
103452011-05-07 Ben Key <bkey76@gmail.com>
10346
10347 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10348 one of two shell specific rules, either bootstrap-temacs-CMD or
10349 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10350 to the previous implementation of the bootstrap-temacs rule.
10351 The bootstrap-temacs-CMD rule is similar to the previous
10352 implementation of the bootstrap-temacs rule except that it
10353 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10354 variable.
10355
10356 These changes, along with some changes to nt/configure.bat,
10357 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10358 earlier fix to add support for --cflags and --ldflags options
10359 that include quotes so that it works whether make uses cmd or
10360 sh as the shell.
10361
b4289b64
MA
103622011-05-06 Michael Albinus <michael.albinus@gmx.de>
10363
10364 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10365 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10366 is a constant.
10367 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10368 a string. Handle both cases.
10369 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10370 (Fdbus_register_method): Use Qinvalid_function.
10371
af4c0e28
JB
103722011-05-06 Juanma Barranquero <lekktu@gmail.com>
10373
10374 * makefile.w32-in: Update dependencies.
10375 (LISP_H): Add inttypes.h and stdin.h.
10376 (PROCESS_H): Add unistd.h.
10377
c51453d9
EZ
103782011-05-06 Eli Zaretskii <eliz@gnu.org>
10379
10380 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10381 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10382
8ff0ac3c 103832011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10384
4c4b566b
PE
10385 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10386
aab2b9b5
PE
10387 * term.c (vfatal): Remove stray call to va_end.
10388 It's not needed and the C Standard doesn't allow it here anyway.
10389
c378da0b
PE
10390 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10391 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10392
288b08c7
PE
10393 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10394 bytes.
10395
e3601888
PE
10396 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10397
db6c0e74
PE
10398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10399
dd5963ea
PE
10400 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10401
88c9450f
PE
10402 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10403
2f9442b8
PE
10404 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10405
c032b5f8
PE
10406 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10407 * charset.c (Fdefine_charset_internal): Don't initialize
10408 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10409 32-bit int (Bug#8600).
a108c10b
PE
10410
10411 * lread.c (read_integer): Be more consistent with string-to-number.
10412 Use string_to_number to do the actual conversion; this avoids
10413 rounding errors and fixes some other screwups. Without this fix,
10414 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10415 (digit_to_number): Move earlier, for benefit of read_integer.
10416 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10417 not a digit in any supported base. (Bug#8602)
a108c10b 10418
ad5f9eea
PE
10419 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10420
aec1708a
PE
10421 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10422 to match comment at start of function. This also removes a
10423 GCC warning about overflow in a 32+64-bit port.
10424
47be4ab5
PE
10425 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10426
371cac43
PE
10427 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10428 Reported by Stefan Monnier in
10429 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10430 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10431 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10432
d01a7826
PE
10433 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10434 (EMACS_UINTPTR): Likewise, with uintptr_t.
10435
7fd47d5c
PE
10436 * lisp.h: Prefer 64-bit EMACS_INT if available.
10437 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10438 on 32-bit hosts that have 64-bit int, so that they can access
10439 large files.
122b0c86
PE
10440 However, temporarily disable this change unless the temporary
10441 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10442
8727937b
PE
10443 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10444
8ac068ac
PE
10445 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10446 This removes an assumption that EMACS_INT and long are the same
10447 width as pointers. The assumption is true for Emacs porting targets
10448 now, but we want to make other targets possible.
10449 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10450 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10451 In the rest of the code, change types of integers that hold casted
10452 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10453 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10454 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10455 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10456 No need to cast type when ORing.
10457 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10458 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10459 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10460 assume EMACS_INT is the same width as char *.
10461 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10462 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10463 Remove no-longer-needed casts.
10464 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10465 (xg_tool_bar_help_callback, xg_make_tool_item):
10466 Use EMACS_INTPTR to hold an integer
10467 that will be cast to void *; this can avoid a GCC warning
10468 if EMACS_INT is not the same width as void *.
10469 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10470 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10471 (current_message_1, set_message_1):
10472 Use a local to convert to proper width without a cast.
10473 * xmenu.c (dialog_selection_callback): Likewise.
10474
ede49d71
PE
10475 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10476 Also, don't assume VALBITS / RAND_BITS is less than 5,
10477 and don't rely on undefined behavior when shifting a 1 left into
10478 the sign bit.
10479 * lisp.h (get_random): Change signature to match.
10480
2f30ecd0
PE
10481 * lread.c (hash_string): Use size_t, not int, for hash computation.
10482 Normally we prefer signed values; but hashing is special, because
10483 it's better to use unsigned division on hash table sizes so that
10484 the remainder is nonnegative. Also, size_t is the natural width
10485 for hashing into memory. The previous code used 'int', which doesn't
10486 retain enough info to hash well into very large tables.
10487 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10488
2a866e7b
PE
10489 * dbusbind.c: Don't possibly lose pointer info when converting.
10490 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10491 Use XPNTR rather than XHASH, so that the high-order bits of
10492 the pointer aren't lost when converting through void *.
10493
51639eac
PE
10494 * eval.c (Fautoload): Don't double-shift a pointer.
10495
92394119
PE
10496 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10497
dbdb9a7c
JB
104982011-05-06 Juanma Barranquero <lekktu@gmail.com>
10499
10500 * gnutls.c (DEF_GNUTLS_FN):
10501 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10502
db7a0b4f
AS
105032011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10504
10505 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10506 marker. (Bug#8610)
10507
cd394be1 105082011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10509
10510 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10511 New version that can reserve upto 2GB of heap space.
10512
f7ff1b0f 105132011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10514
10515 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10516
639c109b
TZ
105172011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10518
10519 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10520 `gnutls_certificate_set_x509_key_file'.
10521
d2127135
JB
105222011-05-05 Juanma Barranquero <lekktu@gmail.com>
10523
10524 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10525 Update dependencies.
10526
e968f4f3
JB
105272011-05-04 Juanma Barranquero <lekktu@gmail.com>
10528
10529 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10530 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10531 Remove unused parameter `fildes'.
10532 * process.c (read_process_output, send_process): Don't pass it.
10533
84d358f0
JB
105342011-05-04 Juanma Barranquero <lekktu@gmail.com>
10535
10536 Fix previous change: the library cache is defined in w32.c.
10537 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10538 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10539
0898ca10
JB
105402011-05-04 Juanma Barranquero <lekktu@gmail.com>
10541
10542 Implement dynamic loading of GnuTLS on Windows.
10543
10544 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10545 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10546 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10547 Declare.
10548
10549 * gnutls.c (Qgnutls_dll): Define.
10550 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10551 (gnutls_*): Declare function pointers.
10552 (init_gnutls_functions): New function to initialize function pointers.
10553 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10554 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10555 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10556 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10557 (emacs_gnutls_write, emacs_gnutls_read)
10558 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10559 (Fgnutls_available_p): New function.
10560 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10561 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10562 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10563
10564 * image.c: Include w32.h.
10565 (Vimage_type_cache): Delete.
10566 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10567 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10568 (w32_delayed_load): Move to w32.c.
10569
10570 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10571
10572 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10573 (w32_delayed_load): Move from image.c. When loading a library, record
10574 its filename in the :loaded-from property of the library id.
10575 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10576 Initialize and staticpro them.
10577 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10578
10579 * process.c: Include lisp.h before w32.h, not after.
10580 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10581 instead of gnutls_record_check_pending.
10582
10583 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10584
ff4de4aa
TZ
105852011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10586
10587 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10588 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10589 as passed in.
10590
abe95abb
JD
105912011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10592
10593 * xterm.c (x_set_frame_alpha): Do not set property on anything
10594 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10595
e16e55d4
JB
105962011-05-02 Juanma Barranquero <lekktu@gmail.com>
10597
10598 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10599
bafcf6a5
JB
106002011-05-02 Juanma Barranquero <lekktu@gmail.com>
10601
10602 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10603 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10604 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10605 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10606 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10607 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10608 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10609 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10610 (Qgnutls_bootprop_callbacks_verify): Make static.
10611
e7a6747f
AS
106122011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10613
19ed11ba
AS
10614 * callproc.c: Indentation fixup.
10615
e7a6747f 10616 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10617 (wait_for_termination, interruptible_wait_for_termination):
10618 Move after wait_for_termination_1.
e7a6747f 10619
1ef14cb4
LMI
106202011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10621
10622 * sysdep.c (interruptible_wait_for_termination): New function
10623 which is like wait_for_termination, but allows keyboard
10624 interruptions.
10625
10626 * callproc.c (Fcall_process): Add (:file "file") as an option for
10627 the STDOUT buffer.
10628 (Fcall_process_region): Ditto.
10629
330d880c
EZ
106302011-04-30 Eli Zaretskii <eliz@gnu.org>
10631
8db90b73
EZ
10632 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10633 rather than `XVECTOR (FOO)->size'.
10634
330d880c
EZ
10635 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10636 inttypes.h, as a gnulib replacement is used if it not available in
10637 system headers.
10638
15cbd324
EZ
106392011-04-21 Eli Zaretskii <eliz@gnu.org>
10640
10641 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10642 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10643 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10644
10645 * coding.c (coding_alloc_by_realloc): Error out if destination
10646 will grow beyond MOST_POSITIVE_FIXNUM.
10647 (decode_coding_emacs_mule): Abort if there isn't enough place in
10648 charbuf for the composition carryover bytes. Reserve an extra
10649 space for up to 2 characters produced in a loop.
10650 (decode_coding_iso_2022): Abort if there isn't enough place in
10651 charbuf for the composition carryover bytes.
10652
106532011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10654
ae940cca
EZ
10655 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10656 aborting when %lld or %lll format is passed.
10657 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10658 %llo or %llx format is passed. (Bug#8545)
10659
03ab8921
EZ
10660 * window.c (window_scroll_line_based): Use a marker instead of
10661 simple variables to record original value of point. (Bug#7952)
10662
afda1437
EZ
10663 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10664 produced by %s or %c overflows available buffer space. (Bug#8545)
10665
f76dee0c
PE
106662011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10667
10668 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10669 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10670
fdc5744d
JB
106712011-04-28 Juanma Barranquero <lekktu@gmail.com>
10672
10673 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10674
638f053a
JB
106752011-04-28 Juanma Barranquero <lekktu@gmail.com>
10676
10677 * keyboard.c (Qdelayed_warnings_hook): Define.
10678 (command_loop_1): Run `delayed-warnings-hook'
10679 if Vdelayed_warnings_list is non-nil.
10680 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10681 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10682
d178f871
EZ
106832011-04-28 Eli Zaretskii <eliz@gnu.org>
10684
10685 * doprnt.c (doprnt): Don't return value smaller than the buffer
10686 size if the message was truncated. (Bug#8545).
10687
b124fd93
JB
106882011-04-28 Juanma Barranquero <lekktu@gmail.com>
10689
10690 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10691 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10692
e810457d
PE
106932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10694
10695 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10696
ea51cceb
JB
106972011-04-27 Juanma Barranquero <lekktu@gmail.com>
10698
10699 * makefile.w32-in: Update dependencies.
10700
94dcfacf
EZ
107012011-04-27 Eli Zaretskii <eliz@gnu.org>
10702
10703 Improve `doprnt' and its usage. (Bug#8545)
10704 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10705 `format_end'. Remove support for %l as a conversion specifier.
10706 Don't use xrealloc. Improve diagnostics when the %l size modifier
10707 is used. Update the commentary.
10708
10709 * eval.c (verror): Simplify calculation of size_t.
10710
10711 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10712 messages.
10713
f61f41d7
PE
107142011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10715
10716 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10717 change.
10718
96fb4434
PE
107192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10720
10721 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10722 This makes this file independent of the recent pseudovector change.
10723
671875da 107242011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10725
69e9b5a3
PE
10726 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10727
b5f869a7 10728 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10729 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10730 Remove unused local.
c8926152 10731 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10732
841a1577 10733 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10734 GCC 4.6.0 optimizes based on type-based alias analysis.
10735 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10736 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10737 != &v->size, and therefore "v->size = 1; b->size = 2; return
10738 v->size;" must therefore return 1. This assumption is incorrect
10739 for Emacs, since it type-puns struct Lisp_Vector * with many other
10740 types. To fix this problem, this patch adds a new type struct
f904488f 10741 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10742 and pseudovectors, and helps optimizing compilers not get fooled
10743 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10744 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10745 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10746 the size member.
eab3844f
PE
10747 (XSETPVECTYPE): Rewrite in terms of new macro.
10748 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10749 This is a bit clearer, and further avoids the possibility of
10750 undesirable aliasing.
10751 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10752 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10753 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10754 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10755 (ASIZE): Now uses header.size rather than size.
10756 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10757 to avoid the hassle of writing XVECTOR (foo)->header.size.
10758 (struct vectorlike_header): New type.
eab3844f
PE
10759 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10760 object, to help avoid aliasing.
10761 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10762 (SUBRP): Likewise, since Lisp_Subr is a special case.
10763 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10764 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10765 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10766 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10767 changed to be "header.size" and "header.next".
10768 * buffer.h (struct buffer): Likewise.
10769 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10770 * frame.h (struct frame): Likewise.
10771 * process.h (struct Lisp_Process): Likewise.
10772 * termhooks.h (struct terminal): Likewise.
10773 * window.c (struct save_window_data, struct saved_window): Likewise.
10774 * window.h (struct window): Likewise.
10775 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10776 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10777 * buffer.c (init_buffer_once): Likewise.
10778 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10779 special case.
10780 * process.c (Fformat_network_address): Use local var for size,
10781 for brevity.
10782
0df1eac5
PE
10783 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10784
847ab9d1 10785 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10786 * data.c (atof): Remove decl; no longer used or needed.
10787 (digit_to_number): Move to lread.c.
10788 (Fstring_to_number): Use new string_to_number function, to be
10789 consistent with how the Lisp reader treats infinities and NaNs.
10790 Do not assume that floating-point numbers represent EMACS_INT
10791 without losing information; this is not true on most 64-bit hosts.
10792 Avoid double-rounding errors, by insisting on integers when
10793 parsing non-base-10 numbers, as the documentation specifies.
10794 * lisp.h (string_to_number): New decl, replacing ...
10795 (isfloat_string): Remove.
bc0a5c13 10796 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10797 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10798 appears to have been a coding error. Similarly, do not accept
10799 strings like +-1e0 as floating point numbers. Do not report
10800 overflow for integer overflows unless the base is not 10 which
10801 means we have no simple and reliable way to continue.
10802 Break out the floating-point parsing into a new
10803 function string_to_number, so that Fstring_to_number parses
10804 floating point numbers consistently with the Lisp reader.
04f2d78b 10805 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10806 (E_CHAR, EXP_INT): Remove, replacing with ...
10807 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10808 (string_to_number): New function, replacing isfloat_string.
10809 This function checks for valid syntax and produces the resulting
10810 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10811 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10812 so that overflow for non-base-10 numbers is reported only when
10813 there's no portable and simple way to convert to floating point.
452f4150 10814
67769ffc
PE
10815 * textprop.c (set_text_properties_1): Rewrite for clarity,
10816 and to avoid GCC warning about integer overflow.
10817
c20db43f
PE
10818 * intervals.h (struct interval): Use EMACS_INT for members
10819 where EMACS_UINT might cause problems. See
10820 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10821 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10822 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10823 All uses changed.
37aa2f85
PE
10824 (offset_intervals): Tell GCC not to worry about length overflow
10825 when negating a negative length.
c20db43f 10826
2538aa2f
PE
10827 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10828 (overrun_check_free): Likewise.
10829
f2d3008d
PE
10830 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10831 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10832 word size.
10833
ec8df744
PE
10834 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10835 (gnutls_make_error): Rename local to avoid shadowing.
10836 (gnutls_emacs_global_deinit): ifdef out; not used.
10837 (Fgnutls_boot): Use const for pointer to readonly storage.
10838 Comment out unused local. Fix pointer signedness problems.
10839
640ee02d
PE
10840 * lread.c (openp): Don't stuff size_t into an 'int'.
10841 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10842 about possible signed overflow.
10843
6048fb2a
PE
10844 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10845 (GDK_KEY_g): Don't define if already defined.
10846 (xg_prepare_tooltip): Avoid pointer signedness problem.
10847 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10848
fa3c87e1
PE
10849 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10850 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10851
2172544b
PE
10852 * xfns.c (Fx_window_property): Simplify a bit,
10853 to make a bit faster and to avoid GCC 4.6.0 warning.
10854 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10855
9b821a21
PE
10856 * fns.c (internal_equal): Don't assume size_t fits in int.
10857
3c616cfa
PE
10858 * alloc.c (compact_small_strings): Tighten assertion a little.
10859
c2982e87
PE
10860 Replace pEd with more-general pI, and fix some printf arg casts.
10861 * lisp.h (pI): New macro, generalizing old pEd macro to other
10862 conversion specifiers. For example, use "...%"pI"d..." rather
10863 than "...%"pEd"...".
10864 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10865 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10866 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10867 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10868 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10869 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10870 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10871 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10872 64-bit hosts.
10873 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10874 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10875 * print.c (safe_debug_print, print_object): Likewise.
10876 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10877 to int.
6f04d126
PE
10878 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10879 avoiding the 0 flag, which is not portable.
c2982e87
PE
10880 * process.c (Fmake_network_process): Use pI to avoid cast.
10881 * region-cache.c (pp_cache): Likewise.
10882 * xdisp.c (decode_mode_spec): Likewise.
10883 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10884 behavior on 64-bit hosts with printf arg.
6f04d126 10885 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10886 (x_stop_queuing_selection_requests): Likewise.
10887 (x_get_window_property): Don't truncate byte count to an 'int'
10888 when tracing.
0b432f21 10889
5e073ec7
PE
10890 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10891 here, since it parses constructs like leading '-' and spaces,
10892 which are not wanted; and it overflows with large numbers.
10893 Instead, simply match F[0-9]+, which is what is wanted anyway.
10894
36372bf9
PE
10895 * alloc.c: Remove unportable assumptions about struct layout.
10896 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10897 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10898 (allocate_vectorlike, make_pure_vector): Use the new macros,
10899 plus offsetof, to remove unportable assumptions about struct layout.
10900 These assumptions hold on all porting targets that I know of, but
10901 they are not guaranteed, they're easy to remove, and removing them
10902 makes further changes easier.
10903
0b432f21
PE
10904 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10905 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10906 (string_overrun_cookie): Now const. Use initializers that
10907 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10908 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10909 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10910 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10911 multiple of sizeof (EMACS_INT); it need not be, if
10912 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10913 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10914
895009e1
JB
109152011-04-26 Juanma Barranquero <lekktu@gmail.com>
10916
10917 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10918
6a7a1b0b
TZ
109192011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10920
10921 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10922 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10923 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10924
841a1577 109252011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10926
10927 * lisp.h (Qdebug): List symbol.
895009e1 10928 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10929 * keyboard.c (debug-on-event): New variable.
10930 (handle_user_signal): Break into debugger when debug-on-event
10931 matches the current signal symbol.
10932
f2d3ba6f
DN
109332011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10934
10935 * alloc.c (check_sblock, check_string_bytes)
10936 (check_string_free_list): Convert to standard C.
10937
42ce4c63
TZ
109382011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10939
10940 * w32.c (emacs_gnutls_push): Fix typo.
10941
825cd63c
EZ
109422011-04-25 Eli Zaretskii <eliz@gnu.org>
10943
fb11d64d
EZ
10944 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10945 "cast to pointer from integer of different size".
10946
825cd63c
EZ
10947 Improve doprnt and its use in verror. (Bug#8545)
10948 * doprnt.c (doprnt): Document the set of format control sequences
10949 supported by the function. Use SAFE_ALLOCA instead of always
10950 using `alloca'.
10951
10952 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10953 is one byte too soon. Don't use xrealloc; instead xfree and
10954 xmalloc anew.
10955
e061a11b
TZ
109562011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10957
10958 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10959 callbacks stage.
10960
10961 * gnutls.c: Renamed global_initialized to
10962 gnutls_global_initialized. Added internals for the
10963 :verify-hostname-error, :verify-error, and :verify-flags
10964 parameters of `gnutls-boot' and documented those parameters in the
10965 docstring. Start callback support.
9173deec
JB
10966 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10967 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10968 on error. Return error code.
e061a11b
TZ
10969 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10970 (emacs_gnutls_read): Likewise.
10971 (Fgnutls_boot): Return handshake error code.
10972 (emacs_gnutls_handle_error): New function.
10973 (wsaerror_to_errno): Likewise.
10974
10975 * w32.h (emacs_gnutls_pull): Add prototype.
10976 (emacs_gnutls_push): Likewise.
10977
10978 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10979 (emacs_gnutls_push): Likewise.
10980
109812011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10982
10983 * process.c (wait_reading_process_output): Check if GnuTLS
10984 buffered some data internally if no FDs are set for TLS
10985 connections.
10986
10987 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10988 (LIBS): Link to USER_LIBS.
10989 ($(BLD)/gnutls.$(0)): New target.
10990
fa6996bc
EZ
109912011-04-24 Eli Zaretskii <eliz@gnu.org>
10992
eb35682e
EZ
10993 * xdisp.c (handle_single_display_spec): Rename the
10994 display_replaced_before_p argument into display_replaced_p, to
10995 make it consistent with the commentary. Fix typos in the
10996 commentary.
10997
e2ad650c
EZ
10998 * textprop.c (syms_of_textprop): Remove dead code.
10999 (copy_text_properties): Delete obsolete commentary about an
11000 interface that was deleted long ago. Fix typos in the description
11001 of arguments.
11002
1b2de274
EZ
11003 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11004 to changes in oldXMenu/XMenu.h from 2011-04-16.
11005 <menu_help_message, prev_menu_help_message>: Constify.
11006 (IT_menu_make_room): menu->help_text is now `const char **';
11007 adjust.
11008
11009 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11010 to changes in oldXMenu/XMenu.h from 2011-04-16.
11011 (struct XMenu): Declare `help_text' `const char **'.
11012
11013 * xfaces.c <Qunspecified>: Make extern again.
11014
11015 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11016 required by POSIX.
1b2de274 11017
762b15be
EZ
11018 * doc.c (get_doc_string): Improve the format passed to `error'.
11019
11020 * doprnt.c (doprnt): Improve commentary.
11021
11022 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11023
11024 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11025 them with etags.
11026
f1052e5d
EZ
11027 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11028 changes in globals.h immediately force recompilation.
762b15be
EZ
11029 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11030 $(CURDIR)/s/ms-w32.h.
11031 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11032
fa6996bc
EZ
11033 * character.c (Fchar_direction): Function deleted.
11034 (syms_of_character): Don't defsubr it.
11035 <char-direction-table>: Deleted.
11036
e6c3da20
EZ
110372011-04-23 Eli Zaretskii <eliz@gnu.org>
11038
11039 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11040 * doprnt.c: Include limits.h.
11041 (SIZE_MAX): New macro.
04f2d78b
CB
11042 (doprnt): Return a size_t value. 2nd arg is now size_t.
11043 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11044 Improve overflow protection. Support `l' modifier for integer
11045 conversions. Support %l conversion. Don't assume an EMACS_INT
11046 argument for integer conversions and for %c.
11047
11048 * lisp.h (doprnt): Restore prototype.
11049
11050 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11051 $(SRC)/character.h.
11052
11053 * Makefile.in (base_obj): Add back doprnt.o.
11054
11055 * deps.mk (doprnt.o): Add back prerequisites.
11056 (callint.o): Depend on character.h.
11057
11058 * eval.c (internal_lisp_condition_case): Include the handler
11059 representation in the error message.
11060 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11061 when breaking from the loop.
11062
11063 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11064
11065 * callint.c (Fcall_interactively): When displaying error message
11066 about invalid control letter, pass the character's codepoint, not
11067 a pointer to its multibyte form. Improve display of the character
11068 in octal and display also its hex code.
11069
11070 * character.c (char_string): Use %x to display the (unsigned)
11071 codepoint of an invalid character, to avoid displaying a bogus
11072 negative value.
11073
11074 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11075 `error', not SYMBOL_NAME itself.
11076
11077 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11078 character arguments to `error'.
11079
11080 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11081 to `error' in error message about FINAL_CHAR argument. Make sure
11082 FINAL_CHAR is a character, and use %c when it is passed as
11083 argument to `error'.
11084
4ffd0d6b 110852011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11086
11087 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11088
11089 * w32.c: Include <time.h>.
11090 (sys_localtime): New function.
11091
4ffd0d6b 110922011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11093
11094 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11095
4ffd0d6b 11096 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11097
4ffd0d6b 110982011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11099
4ffd0d6b
GM
11100 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11101 zombies (Bug#8467).
aac0c6e3 11102
04c56954
EZ
111032011-04-19 Eli Zaretskii <eliz@gnu.org>
11104
11105 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11106 gl_state.e_property when gl_state.object is Qt.
11107
11108 * insdel.c (make_gap_larger): Remove limitation of buffer size
11109 to <= INT_MAX.
11110
16a43933
CY
111112011-04-18 Chong Yidong <cyd@stupidchicken.com>
11112
11113 * xdisp.c (lookup_glyphless_char_display)
11114 (produce_glyphless_glyph): Handle cons cell entry in
11115 glyphless-char-display.
11116 (Vglyphless_char_display): Document it.
11117
11118 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11119 glyphless-char-display.
11120
4581706e
CY
111212011-04-17 Chong Yidong <cyd@stupidchicken.com>
11122
11123 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11124
11125 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11126
11127 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11128 definition for no-X builds.
11129
4887c6e2 111302011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11131
fd35b6f9
PE
11132 Static checks with GCC 4.6.0 and non-default toolkits.
11133
5c1ccb01
PE
11134 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11135
006c5daa
PE
11136 * process.c (keyboard_bit_set): Define only if SIGIO.
11137 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11138 (send_process): Repair possible setjmp clobbering.
11139
efc736d3
PE
11140 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11141
4e2fe2e6
PE
11142 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11143
f97334a2
PE
11144 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11145
4e75f29d
PE
11146 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11147 Define only if needed.
11148
90efadd1
PE
11149 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11150 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11151 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11152
3c647824
PE
11153 * dispextern.h (struct redisplay_interface): Rename param
11154 to avoid shadowing.
e264f262 11155 * termhooks.h (struct terminal): Likewise.
761383f4 11156 * xterm.c (xembed_send_message): Likewise.
3c647824 11157
b58c5c4a
PE
11158 * insdel.c (make_gap_smaller): Define only if
11159 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11160
cad59032
PE
11161 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11162 it.
11163
c339dc2e
PE
11164 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11165 so that we aren't warned about unused symbols.
11166
91a3e27b
PE
11167 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11168
399c71d3 11169 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11170
8ffc96f5
PE
11171 * xfns.c (x_real_positions): Mark locals as initialized.
11172
eef9bc79
PE
11173 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11174
098db9dd
PE
11175 * xterm.c: Fix problems found by static analysis with other toolkits.
11176 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11177 (x_dispatch_event): Declare static if USE_GTK, and
11178 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11179 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11180 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11181 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11182 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11183
eb18f6cc
PE
11184 * xmenu.c (menu_help_callback): Pointer type fixes.
11185 Use const pointers when pointing at readonly data. Avoid pointer
11186 signedness clashes.
11187 (FALSE): Remove unused macro.
11188 (update_frame_menubar): Remove unused decl.
11189
1fe72bf8
PE
11190 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11191
60d9e1db
PE
11192 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11193 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11194 (single_menu_item): Rename local to avoid shadowing.
11195
39261c26
PE
11196 * keyboard.c (make_lispy_event): Remove unused local var.
11197
018c5e19
PE
11198 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11199 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11200
63d2b86e
PE
11201 * bitmaps: Change bitmaps from unsigned char back to the X11
11202 compatible char. Avoid the old compiler warnings about
11203 out-of-range initializers by using, for example, '\xab' rather
11204 than 0xab.
11205
aefd87e1
PE
11206 * xgselect.c (xgselect_initialize): Check vs interface
11207 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11208
bf501fb9
PE
11209 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11210
e9829fdf
PE
11211 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11212 to read-only memory.
11213
1086c095
PE
11214 * fns.c (vector): Remove; this old hack is no longer needed.
11215
2baccd04 11216 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11217 Remove unused var.
dde42981 11218 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11219
72391843 11220 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11221
436c16df 11222 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11223 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11224 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11225
92bb796d 11226 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11227 (x_term_init): Remove local to avoid shadowing.
92bb796d 11228
764430a3 11229 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11230
11231 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11232 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11233
d1dfb56c
EZ
112342011-04-16 Eli Zaretskii <eliz@gnu.org>
11235
c4354cb4
EZ
11236 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11237
d1dfb56c
EZ
11238 Fix regex.c, syntax.c and friends for buffers > 2GB.
11239 * syntax.h (struct gl_state_s): Declare character position members
11240 EMACS_INT.
11241
11242 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11243
04f2d78b
CB
11244 * textprop.c (verify_interval_modification, interval_of):
11245 Declare arguments EMACS_INT.
d1dfb56c
EZ
11246
11247 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11248 EMACS_INT.
11249
11250 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11251
11252 * indent.c (Fvertical_motion): Local variable it_start is now
11253 EMACS_INT.
11254
11255 * regex.c (re_match, re_match_2, re_match_2_internal)
11256 (bcmp_translate, regcomp, regexec, print_double_string)
11257 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11258 (re_compile_pattern, re_exec): Declare arguments and local
11259 variables `size_t' and `ssize_t' and return values `regoff_t', as
11260 appropriate.
11261 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11262 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11263 <compile_stack_type>: `size' and `avail' are now `size_t'.
11264
11265 * regex.h <regoff_t>: Use ssize_t, not int.
11266 (re_search, re_search_2, re_match, re_match_2): Arguments that
11267 specify buffer/string position and length are now ssize_t and
11268 size_t. Return type is regoff_t.
11269
613052cd
BK
112702011-04-16 Ben Key <bkey76@gmail.com>
11271
11272 * nsfont.m: Fixed bugs in ns_get_family and
11273 ns_descriptor_to_entity that were caused by using free to
11274 deallocate memory blocks that were allocated by xmalloc (via
11275 xstrdup). This caused Emacs to crash when compiled with
11276 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11277 --enable-checking=xmallocoverrun). xfree is now used to
11278 deallocate these memory blocks.
11279
4170f62f 112802011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11281
71b41406
PE
11282 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11283
9587a89d
PE
11284 emacs_write: Accept and return EMACS_INT for sizes.
11285 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11286 et seq.
11287 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11288 Accept and return EMACS_INT.
11289 (emacs_gnutls_write): Return the number of bytes written on
11290 partial writes.
11291 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11292 (emacs_read, emacs_write): Remove check for negative size, as the
11293 Emacs source code has been audited now.
9587a89d
PE
11294 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11295 (emacs_read, emacs_write): Use it.
273a5f82
PE
11296 * process.c (send_process): Adjust to the new signatures of
11297 emacs_write and emacs_gnutls_write. Do not attempt to store
11298 a byte offset into an 'int'; it might overflow.
9587a89d 11299 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11300
3e047f51
PE
11301 * sound.c: Don't assume sizes fit in 'int'.
11302 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11303 Return EMACS_INT, not int.
3e047f51 11304 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11305 Accept EMACS_INT, not int.
11306 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11307 record read return values.
11308
cc39a9db
BK
113092011-04-15 Ben Key <bkey76@gmail.com>
11310
c9d0ec6d
JB
11311 * keyboard.c (Qundefined): Don't declare static since it is used
11312 in nsfns.m.
11313 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11314 static since they are used in nsfont.m.
cc39a9db 11315
6c60eb9f
SM
113162011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11317
11318 * process.c (Qprocessp): Don't declare static.
11319 * lisp.h (Qprocessp): Declare again.
11320
7990b61a
JB
113212011-04-15 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11324
5d4cb038
PE
113252011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11326
8bd7b830 11327 Improve C-level modularity by making more things 'static'.
cd64ea1d 11328
e3b27b31
PE
11329 Don't publish debugger-only interfaces to other modules.
11330 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11331 (verify_bytepos, count_markers): Move decls to the only modules
11332 that need them.
11333 * region-cache.h (pp_cache): Likewise.
11334 * window.h (check_all_windows): Likewise.
11335 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11336
5d4cb038
PE
11337 * sysdep.c (croak): Now static, if
11338 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11339 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11340
11341 * alloc.c (refill_memory_reserve): Now static if
11342 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11343 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11344
e87b6180
PE
11345 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11346 Define only if USE_LUCID.
11347
ac64929e
PE
11348 * xrdb.c (x_customization_string, x_rm_string): Now static.
11349
6f37259d
PE
11350 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11351 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11352
1683e3ab
PE
11353 * xdisp.c (draw_row_with_mouse_face): Now static.
11354 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11355
de9c2632
PE
11356 * window.h (check_all_windows): Mark externally visible.
11357
2b96acb7
PE
11358 * window.c (window_deletion_count): Now static.
11359
11360 * undo.c: Make symbols static if they're not exported.
11361 (last_undo_buffer, last_boundary_position, pending_boundary):
11362 Now static.
11363
50436f33
PE
11364 * textprop.c (interval_insert_behind_hooks): Now static.
11365 (interval_insert_in_front_hooks): Likewise.
11366
64520e5c
PE
11367 * term.c: Make symbols static if they're not exported.
11368 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11369 (max_frame_lines, tty_set_terminal_modes):
11370 (tty_reset_terminal_modes, tty_turn_off_highlight):
11371 (get_tty_terminal): Now static.
11372 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11373 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11374 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11375 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11376 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11377
1fa53021
PE
11378 * sysdep.c: Make symbols static if they're not exported.
11379 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11380 Now static.
11381 (sigprocmask_set, full_mask): Remove; unused.
11382 (wait_debugging): Mark as visible.
11383 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11384 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11385
d4b43b22
PE
11386 * syntax.c (syntax_temp): Define only if !__GNUC__.
11387
b7c513d0
PE
11388 * sound.c (current_sound_device, current_sound): Now static.
11389
989b29ad
PE
11390 * search.c (searchbufs, searchbuf_head): Now static.
11391
13a55a78
PE
11392 * scroll.c (scroll_cost): Remove; unused.
11393 * dispextern.h (scroll_cost): Remove decl.
11394
de68a1fc
PE
11395 * region-cache.h (pp_cache): Mark as externally visible.
11396
40ccffa6
PE
11397 * process.c: Make symbols static if they're not exported.
11398 (process_tick, update_tick, create_process, chan_process):
11399 (Vprocess_alist, proc_buffered_char, datagram_access):
11400 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11401 (deactivate_process): Mark defn as static, as well as decl.
11402 * lisp.h (create_process): Remove decl.
11403 * process.h (chan_process, Vprocess_alist): Remove decls.
11404
ad64fc97
PE
11405 * print.c: Make symbols static if they're not exported.
11406 (print_depth, new_backquote_output, being_printed, print_buffer):
11407 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11408 (print_interval, print_number_index, initial_stderr_stream):
11409 Now static.
11410 * lisp.h (Fprinc): Remove decl.
11411 (debug_output_compilation_hack): Mark as externally visible.
11412
adddb265
PE
11413 * sysdep.c (croak): Move decl from here to syssignal.h.
11414 * syssignal.h (croak): Put it here, so the API can be checked when
11415 'croak' is called from dissociate_if_controlling_tty.
11416
1717ede2
PE
11417 * minibuf.c: Make symbols static if they're not exported.
11418 (minibuf_save_list, choose_minibuf_frame): Now static.
11419 * lisp.h (choose_minibuf_frame): Remove decl.
11420
fa5fb2bc
PE
11421 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11422
1e3890d1
PE
11423 * lread.c: Make symbols static if they're not exported.
11424 (read_objects, initial_obarray, oblookup_last_bucket_number):
11425 Now static.
11426 (make_symbol): Remove; unused.
11427 * lisp.h (initial_obarray, make_symbol): Remove decls.
11428
8a1414fa
PE
11429 * keyboard.c: Make symbols static if they're not exported.
11430 (single_kboard, recent_keys_index, total_keys, recent_keys):
11431 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11432 (this_single_command_key_start, echoing, last_auto_save):
11433 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11434 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11435 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11436 (Vlispy_mouse_stem, double_click_count):
11437 Now static.
11438 (force_auto_save_soon): Define only if SIGDANGER.
11439 (ignore_mouse_drag_p): Now static if
11440 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11441 (print_help): Remove; unused.
11442 (stop_character, last_timer_event): Mark as externally visible.
11443 * keyboard.h (ignore_mouse_drag_p): Declare only if
11444 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11445 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11446 * lisp.h (echoing): Remove decl.
11447 (force_auto_save_soon): Declare only if SIGDANGER.
11448 * xdisp.c (redisplay_window): Simplify code, to make it more
11449 obvious that ignore_mouse_drag_p is not accessed if !defined
11450 USE_GTK && !defined HAVE_NS.
11451
93ea6e8f
PE
11452 * intervals.c: Make symbols static if they're not exported.
11453 (merge_properties_sticky, merge_interval_right, delete_interval):
11454 Now static.
11455 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11456
77382fcc
PE
11457 * insdel.c: Make symbols static if they're not exported.
11458 However, leave prepare_to_modify_buffer alone. It's never
11459 called from outside this function, but that appears to be a bug.
11460 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11461 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11462 (adjust_after_replace_noundo): Remove; unused.
11463 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11464 (signal_before_change): Remove decls.
77382fcc 11465
9306c32e
PE
11466 * indent.c (val_compute_motion, val_vmotion): Now static.
11467
cd44d2eb
PE
11468 * image.c: Make symbols static if they're not exported.
11469 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11470 if USE_GTK.
11471 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11472 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11473
ad9a7a06
PE
11474 * fringe.c (standard_bitmaps): Now static.
11475 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11476
81626931
PE
11477 * frame.c: Make symbols static if they're not exported.
11478 (x_report_frame_params, make_terminal_frame): Now static.
11479 (get_frame_param): Now static, unless HAVE_NS.
11480 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11481 (x_get_resource_string): Remove; not used.
11482 * frame.h (make_terminal_frame, x_report_frame_params):
11483 (x_get_resource_string); Remove decls.
11484 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11485 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11486
239f9db9
PE
11487 * font.c, fontset.c: Make symbols static if they're not exported.
11488 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11489 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11490 * font.c (font_close_object): Now static.
11491 * font.h (font_close_object): Remove.
11492 * fontset.c (FONTSET_OBJLIST): Remove.
11493 (free_realized_fontset) #if-0 the body, which does nothing.
11494 (face_suitable_for_char_p): #if-0, as it's never called.
11495 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11496 * xfaces.c (face_at_string_position):
11497 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11498 since 0 is always ASCII.
11499
dfcf3579
PE
11500 * fns.c (weak_hash_tables): Now static.
11501
5045092b
PE
11502 * fileio.c: Make symbols static if they're not exported.
11503 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11504 (Vwrite_region_annotation_buffers): Now static.
11505
57a96f5c
PE
11506 * eval.c: Make symbols static if they're not exported.
11507 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11508 * lisp.h (backtrace_list): Remove decl.
11509
35f08c38
PE
11510 * emacs.c: Make symbols static if they're not exported.
11511 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11512 (fatal_error_code, fatal_error_signal_hook, standard_args):
11513 Now static.
11514 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11515 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11516 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11517 * lisp.h (fatal_error_signal_hook): Remove decl.
11518 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11519
f44bd759
PE
11520 * editfns.c: Move a (normally-unused) function to its only use.
11521 * editfns.c, lisp.h (get_operating_system_release): Remove.
11522 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11523 worth the hassle of breaking this out.
11524
b532497d
PE
11525 * xterm.c: Make symbols static if they're not exported.
11526 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11527 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11528 (x_destroy_window, x_delete_display):
11529 Now static.
11530 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11531 (x_mouse_leave): Remove; unused.
11532 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11533 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11534 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11535 Remove decls.
11536 (x_mouse_leave): Declare only if WINDOWSNT.
11537 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11538 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11539 USE_X_TOOLKIT.
11540
1675728f
PE
11541 * ftxfont.c: Make symbols static if they're not exported.
11542 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11543 HAVE_FREETYPE.
11544 * font.h (ftxfont_driver): Likewise.
11545
e4cebfca
PE
11546 * xfns.c: Make symbols static if they're not exported.
11547 (x_last_font_name, x_display_info_for_name):
11548 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11549 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11550 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11551 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11552 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11553 (last_show_tip_args): Now static.
11554 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11555 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11556 (x_screen_planes): Remove; unused.
11557 * dispextern.h (x_screen_planes): Remove decl.
11558
5bf46f05
PE
11559 * dispnew.c: Make symbols static if they're not exported.
11560 * dispextern.h (redraw_garbaged_frames, scrolling):
11561 (increment_row_positions): Remove.
11562 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11563 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11564 Now static.
11565 (redraw_garbaged_frames): Remove; unused.
11566
435f4c28
PE
11567 * xfaces.c: Make symbols static if they're not exported.
11568 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11569 Remove decls.
11570 * xterm.h (defined_color): Remove decls.
11571 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11572 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11573 (menu_face_changed_default, defined_color, free_realized_face):
11574 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11575 (ascii_face_of_lisp_face): Remove; unused.
11576
8524aef3
PE
11577 * xdisp.c: Make symbols static if they're not exported.
11578 * dispextern.h (scratch_glyph_row, window_box_edges):
11579 (glyph_to_pixel_coords, set_cursor_from_row):
11580 (get_next_display_element, set_iterator_to_next):
11581 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11582 (show_mouse_face): Remove decls
11583 * frame.h (message_buf_print): Likewise.
11584 * lisp.h (pop_message, set_message, check_point_in_composition):
11585 Likewise.
11586 * xterm.h (set_vertical_scroll_bar): Likewise.
11587 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11588 (message_buf_print, scratch_glyph_row, displayed_buffer):
11589 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11590 (get_next_display_element, show_mouse_face, window_box_edges):
11591 (frame_to_window_pixel_xy, check_point_in_composition):
11592 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11593 (glyph_to_pixel_coords): Remove; unused.
11594
16390cd2
PE
11595 * dired.c (file_name_completion): Now static.
11596
11597 * dbusbind.c (xd_in_read_queued_messages): Now static.
11598
a25f4dfa
PE
11599 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11600 * data.c (circular_list_error): Remove.
11601
14a9c8df
PE
11602 * commands.h (last_point_position, last_point_position_buffer):
11603 (last_point_position_window): Remove decls.
11604 * keyboard.c: Make these variables static.
11605
04f2d78b
CB
11606 * coding.h (coding, code_convert_region, encode_coding_gap):
11607 Remove decls.
74ab6df5
PE
11608 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11609 (iso_code_class, detect_coding, code_convert_region): Now static.
11610 (encode_coding_gap): Remove; unused.
11611
38dfbee1
PE
11612 * chartab.c (chartab_chars, chartab_bits): Now static.
11613
a2cb4e63
PE
11614 * charset.h (charset_iso_8859_1): Remove decl.
11615 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11616 Now static.
11617
127198fd
PE
11618 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11619 * ccl.c (Vccl_program_table): Now static.
11620 (check_ccl_update): Remove; unused.
11621
d85b608f
PE
11622 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11623 * category.h: ... from here.
11624 * category.c (check_category_table, set_category_set): Now static.
11625
31cd66f3
PE
11626 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11627 * lisp.h: Remove these decls.
11628
c358e587
PE
11629 * buffer.c (buffer_count): Remove unused var.
11630
e78aecca
PE
11631 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11632 so that it's not optimized away.
11633 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11634 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11635 exported only to the debugger.
11636
e192d7d3 11637 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11638 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11639
92470028
PE
11640 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11641 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11642 was inaccessible from Lisp.
11643 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11644 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11645
244ed907
PE
11646 alloc.c: Import and export fewer symbols, and remove unused items.
11647 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11648 is defined.
11649 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11650 it's not optimized away by whole-program optimization.
11651 (message_enable_multibyte, free_misc): Remove.
11652 (catchlist, handlerlist, mark_backtrace):
11653 Declare only if BYTE_MARK_STACK.
11654 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11655 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11656 (message_enable_multibyte): Remove decl.
11657 (free_misc, interval_free_list, float_block, float_block_index):
11658 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11659 (cons_free_list, last_marked_index):
11660 Now static.
11661 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11662 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11663 (mark_backtrace): Define only if BYTE_MARK_STACK.
11664 * xdisp.c (message_enable_multibyte): Now static.
11665
61c2b50e 11666 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11667 This makes it easier for human readers (and static analyzers)
11668 to see whether these variables are used from other modules.
11669 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11670 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11671 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11672 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11673 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11674 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11675 * xmenu.c, xselect.c:
11676 Declare Q* vars static if they are not used in other modules.
11677 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11678 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11679 Remove decls of unexported vars.
11680 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11681
95c82688
PE
11682 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11683
16a97296
PE
11684 Make Emacs functions such as Fatom 'static' by default.
11685 This makes it easier for human readers (and static analyzers)
11686 to see whether these functions can be called from other modules.
11687 DEFUN now defines a static function. To make the function external
11688 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11689 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11690 (Finit_image_library):
16a97296
PE
11691 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11692 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11693 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11694 Remove decls, since these functions are now static.
11695 (Funintern, Fget_internal_run_time): New decls, since these functions
11696 were already external.
95c82688 11697
16a97296
PE
11698 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11699 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11700 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11701 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11702 * keyboard.c, keymap.c, lread.c:
11703 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11704 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11705 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11706 Mark functions with DEFUE instead of DEFUN,
11707 if they are used in other modules.
11708 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11709 decls for now-static functions.
11710 * buffer.h (Fdelete_overlay): Remove decl.
11711 * callproc.c (Fgetenv_internal): Mark as internal.
11712 * composite.c (Fremove_list_of_text_properties): Remove decl.
11713 (Fcomposition_get_gstring): New forward static decl.
11714 * composite.h (Fcomposite_get_gstring): Remove decl.
11715 * dired.c (Ffile_attributes): New forward static decl.
11716 * doc.c (Fdocumntation_property): New forward static decl.
11717 * eval.c (Ffetch_bytecode): New forward static decl.
11718 (Funintern): Remove extern decl; now in .h file where it belongs.
11719 * fileio.c (Fmake_symbolic_link): New forward static decl.
11720 * image.c (Finit_image_library): New forward static decl.
11721 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11722 * intervals.h (Fprevious_property_change):
11723 (Fremove_list_of_text_properties): Remove decls.
11724 * keyboard.c (Fthis_command_keys): Remove decl.
11725 (Fcommand_execute): New forward static decl.
11726 * keymap.c (Flookup_key): New forward static decl.
11727 (Fcopy_keymap): Now static.
11728 * keymap.h (Flookup_key): Remove decl.
11729 * process.c (Fget_process): New forward static decl.
11730 (Fprocess_datagram_address): Mark as internal.
11731 * syntax.c (Fsyntax_table_p): New forward static decl.
11732 (skip_chars): Remove duplicate decl.
11733 * textprop.c (Fprevious_property_change): New forward static decl.
11734 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11735 Now internal.
11736 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11737 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11738
785bbd42
PE
11739 * editfns.c (Fformat): Remove unreachable code.
11740
8b913b57
AS
117412011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11742
11743 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11744 change. (Bug#8496)
11745
a6744a35
EZ
117462011-04-13 Eli Zaretskii <eliz@gnu.org>
11747
11748 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11749 when at ZV. (Bug#8487)
11750
e7974947
AS
117512011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11752
baad03f0
AS
11753 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11754 (Bug#8437)
11755 * keyboard.c (parse_tool_bar_item): Likewise.
11756 * sound.c (sound_cleanup, alsa_close): Likewise.
11757 * termcap.c (tgetent): Likewise.
11758 * xfns.c (x_default_font_parameter): Likewise.
11759 * xsettings.c (read_and_apply_settings): Likewise.
11760
e7974947
AS
11761 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11762 (overrun_check_free): Protoize.
11763
28272684
PE
117642011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11765
11766 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11767 since callers should never pass a negative size.
11768 Change the signature to match that of plain 'read' and 'write'; see
11769 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11770 * lisp.h: Update prototypes of emacs_write and emacs_read.
11771
11997c76
EZ
117722011-04-11 Eli Zaretskii <eliz@gnu.org>
11773
11774 * xdisp.c (redisplay_window): Don't try to determine the character
11775 position of the scroll margin if the window start point w->startp
e896f03c 11776 is outside the buffer's accessible region. (Bug#8468)
11997c76 11777
8a2cbd72
EZ
117782011-04-10 Eli Zaretskii <eliz@gnu.org>
11779
11780 Fix write-region and its subroutines for buffers > 2GB.
11781 * fileio.c (a_write, e_write): Modify declaration of arguments and
11782 local variables to support buffers larger than 2GB.
11783 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11784
11785 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11786 argument, local variables, and return value.
11787
11788 * lisp.h: Update prototypes of emacs_write and emacs_read.
11789
11790 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11791
4073e537 117922011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11793
1ebfdcb6
PE
11794 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11795
b2ded58d
PE
11796 Fix more problems found by GCC 4.6.0's static checks.
11797
7d66342c
PE
11798 * xdisp.c (vmessage): Use a better test for character truncation.
11799
bbf47d44
PE
11800 * charset.c (load_charset_map): <, not <=, for optimization,
11801 and to avoid potential problems with integer overflow.
9248994d 11802 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11803 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11804 * editfns.c (Fformat): Likewise.
1e69125e 11805 * syntax.c (skip_chars): Likewise.
3befa583 11806
e3019616
PE
11807 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11808 This also lets GCC 4.6.0 generate slightly better loop code.
11809
becfa255
PE
11810 * callint.c (Fcall_interactively): <, not <=, for optimization.
11811 (Fcall_interactively): Count the number of arguments produced,
11812 not the number of arguments given. This is simpler and lets GCC
11813 4.6.0 generate slightly better code.
11814
dae0cd48
PE
11815 * ftfont.c: Distingish more carefully between FcChar8 and char.
11816 The previous code passed unsigned char * to a functions like
11817 strlen and xstrcasecmp that expect char *, which does not
11818 conform to the C standard.
11819 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11820 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11821 char * when the C standard requires it.
11822
76032d70
PE
11823 * keyboard.c (read_char): Remove unused var.
11824
eb3f1cc8
PE
11825 * eval.c: Port to Windows vsnprintf (Bug#8435).
11826 Include <limits.h>.
11827 (SIZE_MAX): Define if the headers do not.
11828 (verror): Do not give up if vsnprintf returns a negative count.
11829 Instead, grow the buffer. This ports to Windows vsnprintf, which
11830 does not conform to C99. Problem reported by Eli Zaretskii.
11831 Also, simplify the allocation scheme, by avoiding the need for
11832 calling realloc, and removing the ALLOCATED variable.
11833
70476b54
PE
11834 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11835
12020a9e
PE
11836 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11837 But keep the doprint source code for now, as we might revamp it
11838 and use it again (Bug#8435).
ea6c7ae6
PE
11839 * lisp.h (doprnt): Remove.
11840 * Makefile.in (base_obj): Remove doprnt.o.
11841 * deps.mk (doprnt.o): Remove.
11842
5fdb398c
PE
11843 error: Print 32- and 64-bit integers portably (Bug#8435).
11844 Without this change, on typical 64-bit hosts error ("...%d...", N)
11845 was used to print both 32- and 64-bit integers N, which relied on
11846 undefined behavior.
61bdb816 11847 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11848 * lisp.h (error, verror): Mark as printf-like functions.
11849 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11850 Report overflow in size calculations when allocating printf buffer.
11851 Do not truncate output string at its first null byte.
11852 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11853 Truncate the output at a character boundary, since vsnprintf does not
11854 do that.
11855 * charset.c (check_iso_charset_parameter): Convert internal
11856 character to string before calling 'error', since %c now has the
11857 printf meaning.
11858 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11859 overflow when computing char to be passed to 'error'. Do not
11860 pass Lisp_Object to 'error'; pass the integer instead.
11861 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11862 formatted with plain %d.
11863
b189fa66
PE
11864 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11865
bff87ef0
PE
11866 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11867
7e2cac20
PE
11868 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11869
ce4d90b5
PE
11870 * xterm.c (x_catch_errors): Remove duplicate declaration.
11871
266c9547
PE
11872 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11873
79c49ad2
PE
11874 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11875
368f4090
JM
118762011-04-10 Jim Meyering <meyering@redhat.com>
11877
11878 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11879 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11880 return ssize_t not "int", and use size_t as the buffer length.
11881 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11882 * gnutls.h: Update declarations.
11883 * process.c (read_process_output): Use ssize_t, to match.
11884 (send_process): Likewise.
11885
a32d4040
CY
118862011-04-09 Chong Yidong <cyd@stupidchicken.com>
11887
11888 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11889
8546720e 118902011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11891
04f2d78b
CB
11892 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11893 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11894
8546720e
GM
11895 * xterm.c (handle_one_xevent):
11896 * xmenu.c (create_and_show_popup_menu):
11897 * xselect.c (x_decline_selection_request)
11898 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11899
0a2f5c1a 119002011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11901
11902 Fix some uses of `int' instead of EMACS_INT.
11903 * search.c (string_match_1, fast_string_match)
11904 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11905 (scan_buffer, find_next_newline_no_quit)
11906 (find_before_next_newline, search_command, Freplace_match)
11907 (Fmatch_data): Make some `int' variables be EMACS_INT.
11908
11909 * xdisp.c (display_count_lines): 3rd argument and return value now
11910 EMACS_INT. All callers changed.
11911 (pint2hrstr): Last argument is now EMACS_INT.
11912
11913 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11914 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11915 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11916 (decode_coding_utf_16, decode_coding_emacs_mule)
11917 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11918 (decode_coding_ccl, decode_coding_charset)
11919 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11920 (decode_coding_iso_2022, decode_coding_emacs_mule)
11921 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11922 <char_offset, last_offset>: Declare EMACS_INT.
11923 (encode_coding_utf_8, encode_coding_utf_16)
11924 (encode_coding_emacs_mule, encode_invocation_designation)
11925 (encode_designation_at_bol, encode_coding_iso_2022)
11926 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11927 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11928 Declare EMACS_INT.
11929 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11930 (encode_invocation_designation): Last argument P_NCHARS is now
11931 EMACS_INT.
11932 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11933 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11934
11935 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11936 All users changed.
11937
11938 * ccl.c (Fccl_execute_on_string): Declare some variables
11939 EMACS_INT.
11940
8546720e 119412011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11942
11943 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11944
4e19a977
CS
119452011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11946
11947 * process.c (Fformat_network_address): Doc fix.
11948
87302331
R
119492011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11950
ee7683eb 11951 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11952
cbb59342
CY
119532011-04-08 Chong Yidong <cyd@stupidchicken.com>
11954
11955 * keyboard.c (read_char): Call Lisp function help-form-show,
11956 instead of using internal_with_output_to_temp_buffer.
11957 (Qhelp_form_show): New var.
e0d38eeb 11958 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11959
11960 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11961
11962 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11963
e67a13ab
CY
119642011-04-06 Chong Yidong <cyd@stupidchicken.com>
11965
04f2d78b
CB
11966 * process.c (Flist_processes): Remove to Lisp.
11967 (list_processes_1): Delete.
e67a13ab 11968
973f782d
EZ
119692011-04-06 Eli Zaretskii <eliz@gnu.org>
11970
7c106b1e
EZ
11971 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11972
973f782d
EZ
11973 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11974
41cf7d1a 119752011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11976
ca23cc88
PE
11977 Fix more problems found by GCC 4.6.0's static checks.
11978
f390e2d5
PE
11979 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11980
42eea0d0
PE
11981 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11982
b69769da 11983 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11984
f9541e84
PE
11985 * xdisp.c (vmessage): Mark as a printf-like function.
11986
13841b55
PE
11987 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11988
c136c10f
PE
11989 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11990
5e2d4a30
PE
11991 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11992 printf-like functions.
11993 (tiff_load): Add casts to remove these marks before passing them
11994 to system-supplied API.
11995
583f48b9
PE
11996 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11997
b25d760e
PE
11998 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11999 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12000 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12001 directly, rather than having caller test rule sign. This avoids
12002 some unnecessary tests.
12003 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12004 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12005 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12006
bc7b6697 12007 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12008 (xfont_open): Avoid unnecessary tests.
bc7b6697 12009
27ccc379
PE
12010 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12011
dcd5c89a
PE
12012 * composite.h, composite.c (composition_gstring_put_cache):
12013 Use EMACS_INT, not int, for length.
12014
b13a45c6
PE
12015 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12016 breaking out part of COMPOSITION_DECODE_RULE.
12017 (COMPOSITION_DECODE_RULE): Use it.
12018 * composite.c (get_composition_id): Remove unused local vars,
12019 by using the new macro.
12020
1e792e4d
PE
12021 * textprop.c (set_text_properties_1): Change while to do-while,
12022 since the condition is always true at first.
12023
dc6c6455 12024 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12025 (interval_deletion_adjustment): Return unsigned value.
12026 All uses changed.
dc6c6455 12027
aba7731a
PE
12028 * process.c (list_processes_1, create_pty, read_process_output):
12029 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12030 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12031 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12032 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12033 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12034
fdfc4bf3
PE
12035 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12036
fca8fe46 12037 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12038 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12039
06a0259a 12040 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12041 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12042 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12043
e7b9e80f
PE
12044 * print.c (print_error_message): Avoid int overflow.
12045
56201685
PE
12046 * font.c (font_list_entities): Redo for clarity,
12047 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12048
78834453 12049 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12050 (font_score): Avoid potential overflow in diff calculation.
78834453 12051
0bc0b309 12052 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12053 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12054
e610eaca
PE
12055 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12056
b895abce
PE
12057 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12058 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12059 can always succeed if overflow has undefined behavior.
12060
1f1d9321 12061 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12062 (wordify): Omit three unnecessary tests.
1f1d9321 12063
c59478bc
PE
12064 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12065 All callers changed. This avoids the need for an unused var.
12066
79b73827
PE
12067 * casefiddle.c (casify_region): Remove var that is set but not used.
12068
a4db5dfe
PE
12069 * dired.c (file_name_completion): Remove var that is set but not used.
12070
43aae36e
PE
12071 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12072
2a47c44d 12073 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12074 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12075
a37c69bf
PE
12076 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12077 Check for integer overflow on size calculations.
12078
328ab8e7
PE
12079 * buffer.c (Fprevious_overlay_change): Remove var that is set
12080 but not used.
12081
e5a2a5cb
PE
12082 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12083 Remove vars that are set but not used.
8d84a6eb 12084 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12085 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12086
a60e5f68
PE
12087 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12088
f661cb61 12089 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12090 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12091
f0397f5a
PE
12092 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12093 that are set but not used.
12094
8664db06 12095 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12096 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12097
6abdaa4a
PE
12098 * xselect.c (x_get_local_selection, x_handle_property_notify):
12099 Remove vars that are set but not used.
12100
0ce7538d 12101 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12102 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12103
9ae848fc
PE
12104 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12105 Remove var that is set but not used.
0b918413
PE
12106 (scroll_bar_windows_size): Now size_t, not int.
12107 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12108 Check for overflow.
9ae848fc 12109
a5a62657
PE
12110 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12111 (map_tty_color) [!defined MSDOS]: Likewise.
12112
5c5cdd39
PE
12113 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12114
66ebf983
PE
12115 * coding.c: Remove vars that are set but not used.
12116 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12117 All callers changed.
12118 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12119 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12120 (decode_coding_charset): Remove vars that are set but not used.
12121
1be4d761
PE
12122 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12123 that is set but not used.
12124
47553fa8
PE
12125 * print.c (print_object): Remove var that is set but not used.
12126
1f7196bf 12127 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12128 The gnulib version avoids calling malloc in the usual case,
12129 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12130 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12131 * filelock.c (current_lock_owner): Likewise.
12132 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12133 * sysdep.c: Include allocator.h, careadlinkat.h.
12134 (emacs_no_realloc_allocator): New static constant.
12135 (emacs_readlink): New function.
fdb61804
PE
12136 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12137 ../lib/careadlinkat.h.
d1fdcab7 12138
f84c17c7
SM
121392011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12140
12141 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12142 first non-nil return value).
12143
ef3862ad
JD
121442011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12145
12146 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12147 if not defined (Bug#8403).
12148
376a7006
JB
121492011-04-02 Juanma Barranquero <lekktu@gmail.com>
12150
12151 * xdisp.c (display_count_lines): Remove parameter `start',
12152 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12153 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12154 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12155 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12156 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12157 and thereabouts. All callers changed.
12158 (get_per_char_metric): Remove parameter `f', unused since
12159 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12160
6ca3801d
JM
121612011-04-02 Jim Meyering <meyering@redhat.com>
12162
12163 do not dereference NULL upon failed strdup
12164 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12165 (ns_get_family): Likewise.
12166
d8e2b5ba
JB
121672011-04-02 Juanma Barranquero <lekktu@gmail.com>
12168
12169 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12170
8c74fcbd
JD
121712011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12172
12173 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12174 later (Bug#8403).
12175
7200d79c
SM
121762011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12177
03408648 12178 Add lexical binding.
7200d79c 12179
03408648
SM
12180 * window.c (Ftemp_output_buffer_show): New fun.
12181 (Fsave_window_excursion):
12182 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12183
12184 * lread.c (lisp_file_lexically_bound_p): New function.
12185 (Fload): Bind Qlexical_binding.
12186 (readevalloop): Remove `evalfun' arg.
12187 Bind Qinternal_interpreter_environment.
12188 (Feval_buffer): Bind Qlexical_binding.
12189 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12190 Mark as dynamic.
12191 (syms_of_lread): Declare `lexical-binding'.
12192
12193 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12194
12195 * keyboard.c (eval_dyn): New fun.
12196 (menu_item_eval_property): Use it.
ca105506
SM
12197
12198 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12199
03408648
SM
12200 * fns.c (concat, mapcar1): Accept byte-code-functions.
12201
12202 * eval.c (Fsetq): Handle lexical vars.
12203 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12204 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12205 (FletX, Flet): Obey lexical binding.
12206 (Fcommandp): Handle closures.
12207 (Feval): New `lexical' arg.
12208 (eval_sub): New function extracted from Feval. Use it almost
12209 everywhere where Feval was used. Look up vars in lexical env.
12210 Handle closures.
12211 (Ffunctionp): Move from subr.el.
12212 (Ffuncall): Handle closures.
12213 (apply_lambda): Remove `eval_flags'.
12214 (funcall_lambda): Handle closures and new byte-code-functions.
12215 (Fspecial_variable_p): New function.
12216 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12217 but without exporting it to Lisp.
23aba0ea 12218
23aba0ea 12219 * doc.c (Fdocumentation, store_function_docstring):
03408648 12220 * data.c (Finteractive_form): Handle closures.
23aba0ea 12221
03408648
SM
12222 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12223 interactive spec.
ba83908c 12224
04f2d78b
CB
12225 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12226 New byte-codes.
03408648
SM
12227 (exec_byte_code): New function extracted from Fbyte_code to handle new
12228 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12229
03408648 12230 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12231
03408648 12232 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12233
e2abce01
JB
122342011-03-31 Juanma Barranquero <lekktu@gmail.com>
12235
12236 * xdisp.c (redisplay_internal): Fix prototype.
12237
63696a73 122382011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12239
63696a73 12240 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12241 (try_scrolling): Use it when setting scroll_limit.
12242 Limit scrolling to 100 screen lines.
63696a73
EZ
12243 (redisplay_window): Even when falling back on "recentering",
12244 position point in the window according to scroll-conservatively,
12245 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12246
12247 (try_scrolling): When point is above the window, allow searching
12248 as far as scroll_max, or one screenful, to compute vertical
12249 distance from PT to the scroll margin position. This prevents
12250 try_scrolling from unnecessarily failing when
12251 scroll-conservatively is set to a value slightly larger than the
12252 window height. Clean up the case of PT below the margin at bottom
12253 of window: scroll_max can no longer be INT_MAX. When aggressive
12254 scrolling is in use, don't let point enter the opposite scroll
12255 margin as result of the scroll.
12256 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12257 threshold of 100 lines for never-recentering scrolling.
12258
e4cc2dfc
JB
122592011-03-31 Juanma Barranquero <lekktu@gmail.com>
12260
12261 * dispextern.h (move_it_by_lines):
12262 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12263 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12264 (message_log_check_duplicate): Remove parameters `prev_bol' and
12265 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12266 (redisplay_internal): Remove parameter `preserve_echo_area',
12267 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12268
12269 * indent.c (Fvertical_motion):
12270 * window.c (window_scroll_pixel_based, Frecenter):
12271 Don't pass `need_y_p' to `move_it_by_lines'.
12272
1c470562
SM
122732011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12274
44f230aa
SM
12275 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12276 steal a few bits to be more compact.
12277 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12278 Remove unneeded casts.
12279
1c470562
SM
12280 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12281
888adce9
ZK
122822011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12283
12284 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12285 binding" message (bug#7967).
12286
f838ed7b
PE
122872011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12288
77861b95
PE
12289 Fix more problems found by GCC 4.6.0's static checks.
12290
de6dbc14
PE
12291 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12292 Remove unused local var.
12293
f838ed7b
PE
12294 * editfns.c (Fmessage_box): Remove unused local var.
12295
792c7b2b
PE
12296 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12297 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12298 Omit unused local vars.
c499e557 12299 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12300 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12301 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12302 Omit unused local var.
12303
ba0165e1
PE
12304 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12305 Don't assume string length fits in int.
32ad8845 12306 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12307 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12308
3c59b4c9
PE
12309 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12310 instead of alloca (Bug#8344).
12311
a3eed478 12312 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12313 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12314
eb4d412d
PE
12315 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12316
1658b401
PE
12317 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12318 concerns.
12319
12320 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12321
12322 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12323
9a2c6e05
PE
12324 * keyboard.c (syms_of_keyboard): Use the same style as later
12325 in this function when indexing through an array. This also
12326 works around GCC bug 48267.
12327
03d0a109
PE
12328 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12329
44f730c8
PE
12330 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12331
fe75f926
PE
12332 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12333 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12334
ffa8c828
PE
12335 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12336 This avoids undefined behavior on integer overflow, and is a bit
12337 more convenient anyway since it is compared to a size_t variable.
12338
c5101a77
PE
12339 Variadic C functions now count arguments with size_t, not int.
12340 This avoids an unnecessary limitation on 64-bit machines, which
12341 caused (substring ...) to crash on large vectors (Bug#8344).
12342 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12343 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12344 All variadic functions and their callers changed accordingly.
c5101a77
PE
12345 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12346 * data.c (arith_driver, float_arith_driver): Likewise.
12347 * editfns.c (general_insert_function): Likewise.
12348 * eval.c (struct backtrace.nargs, interactive_p)
12349 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12350 (funcall_lambda, mark_backtrace): Likewise.
12351 * fns.c (concat): Likewise.
12352 * frame.c (x_set_frame_parameters): Likewise.
12353 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12354 0 if not found, not -1. All callers changed.
12355
dd3f25f7
PE
12356 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12357 (stack_copy_size): Now size_t, not int.
12358 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12359
461c2ab9
JB
123602011-03-28 Juanma Barranquero <lekktu@gmail.com>
12361
12362 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12363 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12364 All callers changed.
12365
12366 * lisp.h (multibyte_char_to_unibyte):
12367 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12368 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12369 * character.h (CHAR_TO_BYTE8):
12370 * cmds.c (internal_self_insert):
12371 * editfns.c (general_insert_function):
12372 * keymap.c (push_key_description):
12373 * search.c (Freplace_match):
12374 * xdisp.c (message_dolog, set_message_1): All callers changed.
12375
f6d62986
SM
123762011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12377
12378 * keyboard.c (safe_run_hook_funcall): New function.
12379 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12380 don't set the hook to nil, but remove the offending function instead.
12381 (Qcommand_hook_internal): Remove, unused.
12382 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12383 Vcommand_hook_internal.
12384
12385 * eval.c (enum run_hooks_condition): Remove.
12386 (funcall_nil, funcall_not): New functions.
12387 (run_hook_with_args): Call each function through a `funcall' argument.
12388 Remove `cond' argument, now redundant.
12389 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12390 (Frun_hook_with_args_until_failure): Adjust accordingly.
12391 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12392
1db5b1ad
JB
123932011-03-28 Juanma Barranquero <lekktu@gmail.com>
12394
12395 * dispextern.h (string_buffer_position): Remove declaration.
12396
12397 * print.c (strout): Remove parameter `multibyte', unused since
12398 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12399
12400 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12401 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12402 All callers changed.
12403
12404 * w32.c (_wsa_errlist): Use braces for struct initializers.
12405
12406 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12407 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12408 All callers changed.
12409 (string_buffer_position): Likewise. Also, make static (it's never
12410 used outside xdisp.c).
12411 (cursor_row_p): Remove parameter `w', unused since
12412 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12413 (decode_mode_spec): Remove parameter `precision', introduced during
12414 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12415 All callers changed.
12416
5ffb62aa
JD
124172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12418
12419 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12420
461c2ab9 124212011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12422
12423 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12424 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12425 (ns_update_auto_hide_menu_bar): New functions.
12426 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12427 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12428 ns_constrain_all_frames.
12429 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12430 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12431
5c380ffb
JD
124322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12433
12434 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12435
9af30bdf
GM
124362011-03-27 Glenn Morris <rgm@gnu.org>
12437
12438 * syssignal.h: Replace RETSIGTYPE with void.
12439 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12440 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12441 Replace SIGTYPE with void everywhere.
12442 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12443 * s/template.h (SIGTYPE): Remove commented out definition.
12444
e2abce01
JB
124452011-03-26 Eli Zaretskii <eliz@gnu.org>
12446
12447 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12448 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12449
f868cd8a
JB
124502011-03-26 Juanma Barranquero <lekktu@gmail.com>
12451
59eb0929
JB
12452 * w32.c (read_unc_volume): Use parameter `henum', instead of
12453 global variable `wget_enum_handle'.
12454
12455 * keymap.c (describe_vector): Remove parameters `indices' and
12456 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12457 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12458
f868cd8a
JB
12459 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12460
12461 * keyboard.c (timer_check): Remove parameter `do_it_now',
12462 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12463 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12464 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12465
12466 * keyboard.c (read_char):
12467 * w32menu.c (w32_menu_display_help):
12468 * xmenu.c (show_help_event, menu_help_callback):
12469 Adjust calls to `show_help_echo'.
12470
12471 * gtkutil.c (xg_maybe_add_timer):
12472 * keyboard.c (readable_events):
12473 * process.c (wait_reading_process_output):
12474 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12475
12476 * insdel.c (adjust_markers_gap_motion):
12477 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12478 (gap_left, gap_right): Don't call it.
12479
2ecf6fdb
CY
124802011-03-25 Chong Yidong <cyd@stupidchicken.com>
12481
12482 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12483 incurred during fontification.
12484
6b1f9ba4
JB
124852011-03-25 Juanma Barranquero <lekktu@gmail.com>
12486
12487 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12488 (DEFVAR_PER_BUFFER): Don't pass it.
12489
12490 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12491 (scrolling_window): Don't pass it.
12492
0f4a96b5
JB
124932011-03-25 Juanma Barranquero <lekktu@gmail.com>
12494
12495 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12496
12497 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12498 and `suffix'.
12499 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12500 of variables specific to SELinux and computation of `encoded_absname'.
12501
12502 * image.c (XPutPixel): Remove unused variable `height'.
12503
12504 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12505
12506 * unexw32.c (get_section_info): Remove unused variable `section'.
12507
12508 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12509 (system_process_attributes): Remove unused variable `sess'.
12510 (sys_read): Remove unused variable `err'.
12511
12512 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12513 (w32_wnd_proc): Remove unused variable `isdead'.
12514 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12515 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12516 (x_create_tip_frame): Remove unused variable `tem'.
12517
12518 * w32inevt.c (w32_console_read_socket):
12519 Remove unused variable `no_events'.
12520
12521 * w32term.c (x_draw_composite_glyph_string_foreground):
12522 Remove unused variable `width'.
12523
1149507c
JB
125242011-03-24 Juanma Barranquero <lekktu@gmail.com>
12525
12526 * w32term.c (x_set_glyph_string_clipping):
12527 Don't pass uninitialized region to CombineRgn.
12528
9c88f339
JB
125292011-03-23 Juanma Barranquero <lekktu@gmail.com>
12530
12531 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12532 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12533 (Fx_close_connection): Remove unused variable `i'.
12534
12535 * w32font.c (w32font_draw): Return number of glyphs.
12536 (w32font_open_internal): Remove unused variable `i'.
12537 (w32font_driver): Add missing initializer.
12538
12539 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12540 (fill_in_menu): Remove unused variable `items_added'.
12541
12542 * w32term.c (last_mouse_press_frame): Remove static global variable.
12543 (w32_clip_to_row): Remove unused variable `f'.
12544 (x_delete_terminal): Remove unused variable `i'.
12545
12546 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12547 (NOTHING): Remove unused static global variable.
12548 (uniscribe_check_otf): Remove unused variable `table'.
12549 (uniscribe_font_driver): Add missing initializers.
12550
dee091a3
JD
125512011-03-23 Julien Danjou <julien@danjou.info>
12552
12553 * term.c (Fsuspend_tty, Fresume_tty):
12554 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12555 * window.c (temp_output_buffer_show):
12556 * insdel.c (signal_before_change):
12557 * frame.c (Fhandle_switch_frame):
12558 * fileio.c (Fdo_auto_save):
12559 * emacs.c (Fkill_emacs):
12560 * editfns.c (save_excursion_restore):
12561 * cmds.c (internal_self_insert):
12562 * callint.c (Fcall_interactively):
12563 * buffer.c (Fkill_all_local_variables):
12564 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12565 Use Frun_hooks.
0f4a96b5 12566 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12567 unconditionally since it does the check itself.
dee091a3 12568
2c520ab5 125692011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12570
c9c49752
PE
12571 Fix more problems found by GCC 4.5.2's static checks.
12572
8abc3f12
PE
12573 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12574 the first time through the loop, since we know p0 < p1 then.
12575 This also avoids a gcc -Wstrict-overflow warning.
12576
a2d26660
PE
12577 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12578 leading to a memory leak, possible in functions like
12579 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12580 of objects (Bug#8318).
a2d26660 12581
916c72e9
PE
12582 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12583 that could (at least in theory) be that large.
12584
19ab8a18
PE
12585 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12586 This is less likely to overflow, and avoids undefined behavior if
12587 overflow does occur. All callers changed. Use strtoul to scan
12588 for the unsigned long integer.
b7cbbd6f
PE
12589 (pint2hrstr): Simplify and tune code slightly.
12590 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12591
f0641eff
PE
12592 * scroll.c (do_scrolling): Work around GCC bug 48228.
12593 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12594
7f650bb9
PE
12595 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12596 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12597 (validate_x_resource_name): Simplify count usage.
12598 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12599
37dd57d1
PE
12600 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12601 fail (Bug#8306).
81e56e61 12602
699979fc 12603 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12604
401bf9b4
PE
12605 * process.c (Fmake_network_process): Use socklen_t, not int,
12606 where POSIX says socklen_t is required in portable programs.
12607 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12608 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12609 (Fmake_network_process, server_accept_connection):
12610 (wait_reading_process_output, read_process_output):
12611 Likewise.
12612
b93aacde
PE
12613 * process.c: Rename or move locals to avoid shadowing.
12614 (list_processes_1, Fmake_network_process):
12615 (read_process_output_error_handler, exec_sentinel_error_handler):
12616 Rename or move locals.
4dc343ee 12617 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12618 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12619 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12620 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12621 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12622
af8a867c 12623 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12624 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12625 Include tparam.h instead, since it declares them.
af8a867c
PE
12626 * cm.h (PC): Remove extern decl; tparam.h now does this.
12627 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12628 * terminfo.c: Include tparam.h, to check interfaces.
12629 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12630 (tparam): Adjust signature to match interface in tparam.h;
12631 this removes some undefined behavior. Check that outstring and len
12632 are zero, which they always are with Emacs.
12633 * tparam.h (PC, BC, UP): New extern decls.
12634
0248044d 12635 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12636 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12637
8ff096c1 12638 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12639 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12640 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12641 (ftfont_list): Remove unused local.
49eaafba
PE
12642 (get_adstyle_property, ftfont_pattern_entity):
12643 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12644 Rename locals to avoid shadowing.
8ff096c1 12645
e2be39f6
PE
12646 * xfont.c (xfont_list_family): Mark var as initialized.
12647
c9735e30
PE
12648 * xml.c (make_dom): Now static.
12649
8f5201ae
PE
12650 * composite.c (composition_compute_stop_pos): Rename local to
12651 avoid shadowing.
b246f932
PE
12652 (composition_reseat_it): Remove unused locals.
12653 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12654 (composition_update_it): Mark var as initialized.
11b61122
PE
12655 (find_automatic_composition): Mark vars as initialized,
12656 with a FIXME (Bug#8290).
8f5201ae 12657
760fbc2c
PE
12658 character.h: Rename locals to avoid shadowing.
12659 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12660 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12661 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12662 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12663 to avoid shadowing.
12664
ff08eb85
PE
12665 * textprop.c (property_change_between_p): Remove; unused.
12666
fc7bf025
PE
12667 * intervals.c (interval_start_pos): Now static.
12668
235d7abc
PE
12669 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12670
44f230aa
SM
12671 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12672 Rename locals to avoid shadowing.
3e7d6594 12673
50060332
PE
12674 * sound.c (wav_play, au_play, Fplay_sound_internal):
12675 Fix pointer signedness.
d01f234b 12676 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12677 (wav_play): Initialize a variable to 0, to prevent undefined
12678 behavior (Bug#8278).
50060332 12679
c4fc4e30
PE
12680 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12681
918436ed
PE
12682 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12683
c939f91b
PE
12684 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12685 clobbering (Bug#8298).
b9c7f648
PE
12686 * sysdep.c (sys_subshell): Likewise.
12687 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12688
6bd8c144
PE
12689 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12690 This should get cleaned up, so that child_setup has the
12691 same signature on all platforms.
12692
7710357c 12693 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12694 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12695
c59da222
CY
126962011-03-22 Chong Yidong <cyd@stupidchicken.com>
12697
12698 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12699 not to be necessary, and produces flickering.
12700
66b87493
GM
127012011-03-20 Glenn Morris <rgm@gnu.org>
12702
12703 * config.in: Remove file.
12704
45b6f6d5
JB
127052011-03-20 Juanma Barranquero <lekktu@gmail.com>
12706
12707 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12708 are now in src/globals.h.
12709 (syms_of_minibuf): Remove spurious & from previous change.
12710
cd394be1 127112011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12712
12713 * minibuf.c (completing-read-function): New variable.
12714 (completing-read-default): Rename from completing-read.
12715 (completing-read): Call completing-read-function.
12716
b14e3e21
CY
127172011-03-19 Juanma Barranquero <lekktu@gmail.com>
12718
12719 * xfaces.c (Fx_load_color_file):
12720 Read color file from absolute filename (bug#8250).
12721
f2b726e6
JB
127222011-03-19 Juanma Barranquero <lekktu@gmail.com>
12723
12724 * makefile.w32-in: Update dependencies.
12725
09f6ff02
EZ
127262011-03-17 Eli Zaretskii <eliz@gnu.org>
12727
12728 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12729
29a6015a
PE
127302011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12731
a3a6c54e
PE
12732 Fix more problems found by GCC 4.5.2's static checks.
12733
b766f867
PE
12734 * process.c (make_serial_process_unwind, send_process_trap):
12735 (sigchld_handler): Now static.
12736
be02381c
PE
12737 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12738 That way, the code declares only the vars that it needs.
12739 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12740 * s/cygwin.h (PTY_ITERATION): Likewise.
12741 * s/darwin.h (PTY_ITERATION): Likewise.
12742 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12743
57048744
PE
12744 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12745 * process.c (allocate_pty): Don't declare stb unless it's needed.
12746
7914961c 12747 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12748 (CONSTANTLIM): Remove; unused.
12749 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12750 Define only if needed.
7914961c 12751
b3967b18
PE
12752 * unexelf.c (unexec): Name an expression,
12753 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12754 Use a different way to cause a compilation error if anyone uses
12755 n rather than nn, a way that does not involve shadowing.
73366a00 12756 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12757
29a6015a
PE
12758 * deps.mk (unexalpha.o): Remove; unused.
12759
43cfc33e 12760 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12761 * unexec.h: New file.
ce701a33
PE
12762 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12763 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12764 Depend on unexec.h.
12765 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12766 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12767 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12768 Change as necessary to match prototype in unexec.h.
ce701a33 12769
01f44d5a
PE
12770 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12771 shadowing.
4f63c6bb 12772 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12773
a6670b0b
PE
12774 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12775 Rename locals to avoid shadowing.
12776
cef2010d 12777 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12778 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12779
d4d7173a
PE
12780 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12781
f08b802a
PE
12782 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12783 warning when compiling print.c.
12784
3ddb0639
PE
12785 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12786 instead of using an uninitialized var.
5ad03b97 12787 (font_sort_entities): Mark var as initialized.
3ddb0639 12788
170a2692
PE
12789 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12790
e663c700
PE
12791 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12792 pointers to constants.
89bc529a 12793 (font_parse_fcname): Remove unused vars.
7b81e2d0 12794 (font_delete_unmatched): Now static.
ea838e10 12795 (font_get_spec): Remove; unused.
13a547c6
PE
12796 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12797 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12798 Rename or move locals to avoid shadowing.
e663c700 12799
2a80c887 12800 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12801 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12802
1384fa33 12803 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12804 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12805
8b2c52e9
PE
12806 * alloc.c (mark_backtrace): Move decl from here ...
12807 * lisp.h: ... to here, so that it can be checked.
12808
475545b5 12809 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12810 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12811 (lisp_indirect_variable): Name an expression,
12812 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12813 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12814
b1349114 12815 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12816 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12817 Use const pointer when appropriate.
b1349114 12818
a2928364
PE
12819 * lisp.h (get_system_name, get_operating_system_release):
12820 Move decls here, to check interfaces.
12821 * process.c (get_operating_system_release): Move decl to lisp.h.
12822 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12823 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12824 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12825 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12826 (Fformat_time_string, Fencode_time, Finsert_char):
12827 (Ftranslate_region_internal, Fformat):
12828 Rename or remove local vars to avoid shadowing.
9710023e 12829 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12830
a415e694
PE
12831 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12832 avoid shadowing.
12833
8ef4622d
PE
12834 * lisp.h (eassert): Check that the argument compiles, even if
12835 ENABLE_CHECKING is not defined.
12836
946f9a5b
PE
12837 * data.c (Findirect_variable): Name an expression, to avoid
12838 gcc -Wbad-function-cast warning.
112396d6 12839 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12840 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12841 (Fmake_variable_buffer_local, Fmake_local_variable):
12842 Mark variables as initialized.
52746918 12843 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12844
e5aab7e7 12845 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12846 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12847 Rename locals to avoid shadowing.
dff45157
PE
12848 (mark_stack): Move local variables into the #ifdef region where
12849 they're used.
7bc26fdb
PE
12850 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12851 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12852 needed otherwise.
12853 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12854 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12855 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12856
e5aab7e7
PE
12857 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12858 avoids undefined behavior in theory.
12859
4da60324
PE
12860 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12861
88043301
PE
12862 Use functions, not macros, for up- and down-casing (Bug#8254).
12863 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12864 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12865 to use the following functions instead of these macros.
12866 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12867 EMACS_INT, since callers assume the returned value fits in int.
12868 (upcase1): Likewise, for UPCASE_TABLE.
12869 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12870 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12871 the race-condition problem in the old DOWNCASE.
88043301 12872
19ed5445
PE
12873 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12874 Rename locals to avoid shadowing.
12875 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12876 (regex_compile, re_search_2, re_match_2_internal):
12877 Remove unused local vars.
952db0d7
PE
12878 (FREE_VAR): Rewrite so as not to use empty "else",
12879 which gcc can warn about.
da053e48 12880 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12881 (RETALLOC_IF): Define only if needed.
12882 (WORDCHAR_P): Likewise. This one is never needed, but is used
12883 only in a comment talking about a compiler bug, so put inside
12884 the #if 0 of that comment.
12885 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12886 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12887 Remove; unused.
19ed5445 12888
1f3561e4 12889 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12890 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12891 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12892
ded6f8f7
PE
12893 * search.c (simple_search): Remove unused var.
12894
dbd37a95
PE
12895 * dired.c (compile_pattern): Move decl from here ...
12896 * lisp.h: ... to here, so that it can be checked.
12897 (struct re_registers): New forward decl.
12898
7e47afad
PE
12899 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12900
85f24f61
PE
12901 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12902 All uses changed.
12903 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12904 Rename locals to avoid shadowing.
5671df8f 12905 (Fvertical_motion): Mark locals as initialized.
85f24f61 12906
181aa2be 12907 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12908 (casify_region): Mark local as initialized.
181aa2be 12909
930d429c
PE
12910 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12911
7082eac6
PE
12912 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12913 New macros, so that the caller can use some names other than
12914 gcpro1, gcpro2, etc.
12915 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12916 of the new macros.
12917 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12918 argument, for consistency with GCPRO2_VAR, etc: it is now the
12919 prefix of the variable, not the variable itself. All uses
12920 changed.
38b2c076
PE
12921 * dired.c (directory_files_internal, file_name_completion):
12922 Rename locals to avoid shadowing.
12923
15206ed9
PE
12924 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12925 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12926 dired.c's scmp function, had undefined behavior.
12927 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12928 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12929 * buffer.h: ... to here, because these macros use current_buffer,
12930 and the new implementation with inline functions needs to have
12931 current_buffer in scope now, rather than later when the macros
12932 are used.
12933 (downcase, upcase1): New static inline functions.
12934 (DOWNCASE, UPCASE1): Reimplement using these functions.
12935 This avoids undefined behavior in expressions like
12936 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12937 from race conditions in accessing the global variables
12938 case_temp1 and case_temp2.
12939 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12940 * lisp.h (case_temp1, case_temp2): Remove their decls.
12941 * character.h (ASCII_CHAR_P): Move from here ...
12942 * lisp.h: ... to here, so that the inline functions mentioned
12943 above can use them.
12944
4a6bea26
PE
12945 * dired.c (directory_files_internal_unwind): Now static.
12946
f14b7e14
PE
12947 * fileio.c (file_name_as_directory, directory_file_name):
12948 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12949 Now static.
2893f146
PE
12950 (file_name_as_directory): Use const pointers when appropriate.
12951 (Fexpand_file_name): Likewise. In particular, newdir might
12952 point at constant storage, so make it a const pointer.
fd4ead52 12953 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12954 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12955 signedness issues.
f839df0c
PE
12956 (Fset_file_times, Finsert_file_contents, auto_save_error):
12957 Rename locals to avoid shadowing.
f14b7e14 12958
5716756e 12959 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12960 (Ftry_completion, Fall_completions): Rename or remove locals
12961 to avoid shadowing.
5716756e 12962
b4c3046a
PE
12963 * marker.c (bytepos_to_charpos): Remove; unused.
12964
b45db522
PE
12965 * lisp.h (verify_bytepos, count_markers): New decls,
12966 so that gcc does not warn that these functions aren't declared.
12967
85876d07
PE
12968 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12969 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12970 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12971 (copy_text): Remove unused local var.
85876d07 12972
03d78a21 12973 * filelock.c (within_one_second): Now static.
b3dd38ab 12974 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12975
5df8f01b
PE
12976 * buffer.c (fix_overlays_before): Mark locals as initialized.
12977 (fix_start_end_in_overlays): Likewise. This function should be
12978 simplified by using pointers-to-pointers, but that's a different
12979 matter.
b1d876f1 12980 (switch_to_buffer_1): Now static.
8f54f30a
PE
12981 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12982 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12983
a70072c9 12984 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12985 Fix pointer signedness issue.
edced198
PE
12986 (sys_subshell): Mark local as volatile if checking for lint,
12987 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12988 (MAXPATHLEN): Define only if needed.
a70072c9 12989
a0977c44
PE
12990 * process.c (serial_open, serial_configure): Move decls from here ...
12991 * systty.h: ... to here, so that they can be checked.
12992
a884fdcc
PE
12993 * fns.c (get_random, seed_random): Move extern decls from here ...
12994 * lisp.h: ... to here, so that they can be checked.
12995
604efe86 12996 * sysdep.c (reset_io): Now static.
b8950c94 12997 (wait_for_termination_signal): Remove; unused.
604efe86 12998
38fc62d9
PE
12999 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13000 (copy_keymap_item, append_key, push_text_char_description):
13001 Now static.
1004a21a 13002 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13003 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13004 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13005 (describe_map_tree):
13006 Rename locals to avoid shadowing.
38fc62d9 13007
2f2650da
PE
13008 * keyboard.c: Declare functions static if they are not used elsewhere.
13009 (echo_char, echo_dash, cmd_error, top_level_2):
13010 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13011 (read_char, kbd_buffer_get_event, make_lispy_position):
13012 (make_lispy_event, make_lispy_movement, apply_modifiers):
13013 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13014 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13015 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13016 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13017 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13018
a053e86c 13019 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13020 (mark_kboards): Move decl here ...
13021 * alloc.c (mark_kboards): ... from here.
a053e86c 13022
4752793e
PE
13023 * lisp.h (force_auto_save_soon): New decl.
13024
74f10ca7 13025 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13026 (DEFINE_DUMMY_FUNCTION): New macro.
13027 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13028 Use it.
c03cd23f
PE
13029 (main): Add casts to avoid warnings
13030 if GCC considers string literals to be constants.
74f10ca7 13031
022e70d4
PE
13032 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13033
59d6fe83
PE
13034 * dbusbind.c: Pointer signedness fixes.
13035 (xd_signature, xd_append_arg, xd_initialize):
13036 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13037 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13038 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13039 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13040
78320123
PE
13041 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13042 if GCC considers string literals to be constants.
49cebcca 13043 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13044
35ac2a97
SM
130452011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13046
fb103ca9
SM
13047 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13048 (print_preprocess, print_object): New macro to fix last change.
13049
35ac2a97
SM
13050 * print.c (print_preprocess): Don't forget font objects.
13051
62973b41
JB
130522011-03-16 Juanma Barranquero <lekktu@gmail.com>
13053
13054 * emacs.c (USAGE3): Doc fixes.
13055
0e48bb22
AS
130562011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13057
13058 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13059 structure.
13060
7684e57b
JB
130612011-03-14 Juanma Barranquero <lekktu@gmail.com>
13062
13063 * lisp.h (VWindow_system, Qfile_name_history):
13064 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13065 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13066 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13067
13068 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13069 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13070
13071 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13072 * w32console.c (detect_input_pending, read_input_pending)
13073 (encode_terminal_code):
13074 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13075 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13076 (w32_system_caret_y, Qfile_name_history):
13077 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13078 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13079 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13080 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13081 * w32proc.c (Qlocal, report_file_error):
13082 * w32term.c (Vwindow_system, updating_frame):
13083 * w32uniscribe.c (initialized, uniscribe_font_driver):
13084 Remove unneeded extern declarations.
13085
2aa46d6c
CY
130862011-03-14 Chong Yidong <cyd@stupidchicken.com>
13087
c96bbc66 13088 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13089
cffc6f3b
CY
130902011-03-13 Chong Yidong <cyd@stupidchicken.com>
13091
13092 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13093 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13094 These macros can no longer be used for assignment.
13095
44f230aa
SM
13096 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13097 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13098 (record_buffer_markers, fetch_buffer_markers): New functions for
13099 recording and fetching special buffer markers.
13100 (set_buffer_internal_1, set_buffer_temp): Use them.
13101
13102 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13103
13104 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13105
13106 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13107 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13108
13109 * xdisp.c (hscroll_window_tree):
13110 (reconsider_clip_changes): Use PT instead of BUF_PT.
13111
d251f04b
EZ
131122011-03-13 Eli Zaretskii <eliz@gnu.org>
13113
13114 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13115 $(EMACS_ROOT)/lib/intprops.h.
13116
f0c77cd1
PE
131172011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13118
3eca4629
PE
13119 Fix more problems found by GCC 4.5.2's static checks.
13120
7c86ee98
PE
13121 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13122 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13123 (xg_free_frame_widgets): Make it clear that a local variable is
13124 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13125 (gdk_window_get_screen): Make it clear that this macro is needed
13126 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13127 (int_gtk_range_get_value): New function, which avoids a diagnostic
13128 from gcc -Wbad-function-cast.
13129 (xg_set_toolkit_scroll_bar_thumb): Use it.
13130 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13131 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13132 (get_utf8_string, xg_get_file_with_chooser):
13133 Rename locals to avoid shadowing.
13134 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13135
41729b81
PE
13136 * xgselect.c (xg_select): Remove unused var.
13137
f0c77cd1
PE
13138 * image.c (four_corners_best): Mark locals as initialized.
13139 (gif_load): Initialize transparent_p to zero (Bug#8238).
13140 Mark another local as initialized.
ec6cf4c6 13141 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13142
ce0ad53d 13143 * image.c (clear_image_cache): Now static.
d5d5a617 13144 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13145 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13146 (x_edge_detection): Remove unnecessary cast that
13147 gcc -Wbad-function-cast diagnoses.
2037898d 13148 (gif_load): Fix pointer signedness.
6ae141d6
PE
13149 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13150 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13151
33383987 131522011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13153
d32df629
PE
13154 Improve quality of tests for time stamp overflow.
13155 For example, without this patch (encode-time 0 0 0 1 1
13156 1152921504606846976) returns the obviously-bogus value (-948597
13157 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13158 reports time overflow. See
13159 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13160 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13161 * editfns.c: Include limits.h and intprops.h.
13162 (TIME_T_MIN, TIME_T_MAX): New macros.
13163 (time_overflow): Move earlier, to before first use.
13164 (hi_time, lo_time): New functions, for an accurate test for
13165 out-of-range times.
13166 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13167 (Fget_internal_run_time): Don't assume time_t fits in int.
13168 (make_time): Use list2 instead of Fcons twice.
13169 (Fdecode_time): More accurate test for out-of-range times.
13170 (check_tm_member): New function.
13171 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13172 (lisp_time_argument): Don't rely on undefined left-shift and
13173 right-shift behavior when checking for time stamp overflow.
8be6f318 13174
fe31d94c
PE
13175 * editfns.c (time_overflow): New function, refactoring common code.
13176 (Fformat_time_string, Fdecode_time, Fencode_time):
13177 (Fcurrent_time_string): Use it.
13178
8be6f318
PE
13179 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13180 * dired.c (make_time): Move to ...
13181 * editfns.c (make_time): ... here.
13182 * systime.h: Note the move.
13183
09d9db2c 131842011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13185
126bc0dc
YM
13186 * fringe.c (update_window_fringes): Remove unused variables.
13187
c47cbdfd
YM
13188 * unexmacosx.c (copy_data_segment): Also copy __got section.
13189 (Bug#8223)
13190
7ac80be9
EZ
131912011-03-12 Eli Zaretskii <eliz@gnu.org>
13192
c96bbc66 13193 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13194 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13195 Constify `char *' arguments and their references according to
13196 prototypes in tparam.h.
13197
ecb0f94d 13198 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13199
7ac80be9
EZ
13200 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13201 Adapt all references accordingly.
13202
13203 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13204
ef1fd07e
TT
132052011-03-11 Tom Tromey <tromey@redhat.com>
13206
13207 * buffer.c (syms_of_buffer): Remove obsolete comment.
13208
7ef4b50c
EZ
132092011-03-11 Eli Zaretskii <eliz@gnu.org>
13210
13211 * termhooks.h (encode_terminal_code): Declare prototype.
13212
13213 * msdos.c (encode_terminal_code): Don't declare prototype.
13214
13215 * term.c (encode_terminal_code): Now external again, used by
13216 w32console.c and msdos.c.
13217
44f230aa
SM
13218 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13219 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13220
4b1ec863 132212011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13222
1714f52b 13223 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13224
4b1ec863
PE
13225 * fringe.c (update_window_fringes): Mark locals as initialized
13226 (Bug#8227).
13227 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13228
524c7aa6
PE
13229 * alloc.c (mark_fringe_data): Move decl from here ...
13230 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13231 to check its interface.
13232 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13233
a5c0af81 13234 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13235 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13236 (fontset_font): Mark local as initialized.
a9a06e0b 13237 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13238
b4716021
PE
13239 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13240
811e9bac 13241 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13242 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13243 (x_own_selection, Fx_disown_selection_internal): Rename locals
13244 to avoid shadowing.
13245 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13246
7e3ab302
PE
13247 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13248 so that the caller can use some name other than gcpro1.
13249 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13250 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13251 (Fx_backspace_delete_keys_p):
13252 Use them to avoid shadowing, and rename vars to avoid shadowing.
13253 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13254 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13255 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13256 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13257 Remove unused locals.
7e3ab302
PE
13258 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13259 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13260 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13261 macros.
f78faa98 13262
e2b13473
PE
13263 * xterm.h (x_mouse_leave): New decl.
13264
77f23912
PE
13265 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13266 Remove unused functions.
cdf4ba58
PE
13267 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13268 (x_calc_absolute_position): Now static.
7411c686 13269 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13270 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13271 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13272 unless they are used.
38d0b34a
PE
13273 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13274 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13275 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13276 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13277 (x_error_catcher, x_connection_closed, x_error_handler):
13278 (x_error_quitter, xembed_send_message, x_iconify_frame):
13279 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13280 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13281 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13282
44f230aa
SM
13283 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13284 Rename or move locals to avoid shadowing.
6b463e58 13285 (tty_defined_color, merge_face_heights): Now static.
5967d051 13286 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13287 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13288 does not deduce is never used uninitialized.
73719eba
PE
13289 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13290 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13291
426994c3 13292 * terminal.c (store_terminal_param): Now static.
5489860b 13293
032f1620 13294 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13295 (set_frame_menubar): Remove unused local.
d4323972 13296 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13297 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13298 since they might point to immutable storage.
281585b0
PE
13299 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13300 since it's unused otherwise.
032f1620 13301
367c19e5 13302 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13303 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13304 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13305 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13306 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13307 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13308 does not deduce are never used uninitialized.
70739cbe 13309
07b48fa9
PE
13310 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13311
8868a238 13312 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13313 * window.c (window_loop, size_window):
13314 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13315
7e5cf297 13316 * window.c (display_buffer): Now static.
d6550a9f
PE
13317 (size_window): Mark variables that gcc -Wuninitialized
13318 does not deduce are never used uninitialized.
a586633d
PE
13319 * window.h (check_all_windows): New decl, to forestall
13320 gcc -Wmissing-prototypes diagnostic.
5b555da1 13321 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13322
f6095868
PE
13323 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13324 shadowing.
13325 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13326 Include <limits.h>.
13327 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13328 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13329 (load_charset_map): Mark variables that gcc -Wuninitialized
13330 does not deduce are never used uninitialized.
53df7c11 13331 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13332
f38b440c
PE
13333 * coding.c (coding_set_source, coding_set_destination):
13334 Use "else { /* comment */ }" rather than "else /* comment */;"
13335 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13336 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13337 a block, when the outer 'i' will do.
13338 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13339 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13340 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13341 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13342 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13343 Rename locals to avoid shadowing.
13344 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13345 * coding.c (emacs_mule_char, encode_invocation_designation):
13346 Now static, since they're not used elsewhere.
413bb2db 13347 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13348 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13349 (decode_coding_emacs_mule): Mark variables that gcc
13350 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13351 (detect_coding_iso_2022): Initialize a local variable that might
13352 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13353 this initialization is needed. (Bug#8211)
5f58e762
PE
13354 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13355 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13356 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13357 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13358 Remove unused macros.
f38b440c 13359
232b38b9 13360 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13361 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13362 * character.c (string_count_byte8): Likewise.
232b38b9 13363
fb90da1b
PE
13364 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13365 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13366
fb93dbc2
PE
13367 * chartab.c (copy_sub_char_table): Now static, since it's not used
13368 elsewhere.
5c156ace
PE
13369 (sub_char_table_ref_and_range, char_table_ref_and_range):
13370 Rename locals to avoid shadowing.
bbcd0949 13371 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13372
7d3b3862 13373 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13374 (BIDI_BOB): Remove unused macro.
7d3b3862 13375
6be7d3da
PE
13376 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13377 deduce are never used uninitialized.
c2ed9c8b 13378 * term.c (encode_terminal_code): Likewise.
6be7d3da 13379
75f8807f 13380 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13381
50938595
PE
13382 * tparam.h: New file.
13383 * term.c, tparam.h: Include it.
13384 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13385 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13386 Move these decls to tparam.h, and make them agree with what
13387 is actually in tparam.c. The previous trick of using incompatible
13388 decls in different modules does not conform to the C standard.
13389 All callers of tparam changed to use tparam's actual API.
13390 * tparam.c (tparam1, tparam, tgoto):
13391 Use const pointers where appropriate.
13392
fbceeba2
PE
13393 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13394 * cm.h (struct cm): Likewise.
13395 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13396 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13397 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13398 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13399 (turn_on_face, init_tty): Likewise.
13400 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13401
7f3f1250
PE
13402 * term.c (term_mouse_position): Rename local to avoid shadowing.
13403
e6ca6543
PE
13404 * alloc.c (mark_ttys): Move decl from here ...
13405 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13406
c40f8d15
AS
134072011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13408
13409 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13410
cfe0661d
JB
134112011-03-09 Juanma Barranquero <lekktu@gmail.com>
13412
13413 * search.c (compile_pattern_1): Remove argument regp, unused since
13414 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13415 (compile_pattern): Don't pass it.
13416
0afb4571
J
134172011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13418
13419 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13420 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13421 for ! HAVE_GTK3.
13422 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13423
13424 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13425
13426 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13427 gdk_window_get_screen, gdk_window_get_geometry,
13428 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13429 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13430 (xg_get_pixbuf_from_pixmap): New function.
13431 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13432 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13433 Call xg_get_pixbuf_from_pixmap instead of
13434 gdk_pixbuf_get_from_drawable.
13435 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13436 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13437 (xg_check_special_colors): Use GtkStyleContext and its functions
13438 for HAVE_GTK3.
13439 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13440 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13441 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13442 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13443 Call gtk_widget_get_preferred_size.
0afb4571
J
13444 (xg_frame_resized): gdk_window_get_geometry only takes 5
13445 parameters.
44f230aa
SM
13446 (xg_win_to_widget, xg_event_is_for_menubar):
13447 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13448 (xg_set_widget_bg): New function.
13449 (delete_cb): New function.
895009e1 13450 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13451 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13452 (xg_set_background_color): Call xg_set_widget_bg.
13453 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13454 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13455 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13456 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13457 if ! HAVE_GTK3.
13458 (update_frame_tool_bar): Call gtk_widget_hide.
13459 (xg_initialize): Use GDK_KEY_g.
13460
13461 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13462 if ! HAVE_GTK3
13463 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13464
13465 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13466 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13467 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13468
1c2cc4ef
JB
134692011-03-08 Juanma Barranquero <lekktu@gmail.com>
13470
13471 * w32xfns.c (select_palette): Check success of RealizePalette against
13472 GDI_ERROR, not zero.
13473
33383987 13474See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13475
13476;; Local Variables:
13477;; coding: utf-8
aac0c6e3
MR
13478;; End:
13479
2f097256 13480 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13481
13482 This file is part of GNU Emacs.
13483
13484 GNU Emacs is free software: you can redistribute it and/or modify
13485 it under the terms of the GNU General Public License as published by
13486 the Free Software Foundation, either version 3 of the License, or
13487 (at your option) any later version.
13488
13489 GNU Emacs is distributed in the hope that it will be useful,
13490 but WITHOUT ANY WARRANTY; without even the implied warranty of
13491 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13492 GNU General Public License for more details.
13493
13494 You should have received a copy of the GNU General Public License
13495 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.