Fix .gdbinit to match changes with INTERNAL_FIELD.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
26d16b35
EZ
12012-08-07 Eli Zaretskii <eliz@gnu.org>
2
3 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist): Rename
4 fields to match removal of FGET and WGET and disuse of
5 INTERNAL_FIELD in Lisp_Cons.
6
c644523b
DA
72012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
8
9 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
10 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
11 name since all xname users are fixed long time ago. Do not
12 use INTERNAL_FIELD.
13 (set_symbol_name, set_symbol_function, set_symbol_plist):
14 (set_symbol_next, set_overlay_plist): New function.
15 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
16 (struct Lisp_Overlay): Likewise.
17 (CVAR, MVAR, SVAR): Remove.
18 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
19 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
20 * xterm.c: Adjust users.
21 * .gdbinit: Change to use name field of struct Lisp_Symbol
22 where appropriate.
23
6a3d20cc
DA
242012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
25
26 Basic functions to set Lisp_Object and pointer slots of intervals.
27 * intervals.h (interval_set_parent, interval_set_object):
28 (interval_set_left, interval_set_right, interval_set_plist):
29 (interval_copy_parent): New function.
30 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
31 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE): Adjust
32 indentation.
33 (INTERVAL_SIZE): Remove. Adjust users.
34 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
35
4d2b044c
DA
362012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
37
38 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
39 * process.h (PGET): Remove.
40 (struct Lisp_Process): Do not use INTERNAL_FIELD.
41 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
42
d3d50620
DA
432012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Drop WGET and revert read access to Lisp_Objects slots of struct window.
46 * window.h (WGET): Remove.
47 (struct window): Do not use INTERNAL_FIELD.
48 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
49 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
50 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
51 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
52 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
53 Adjust users.
54
d10a51dc
CY
552012-08-07 Chong Yidong <cyd@gnu.org>
56
57 * window.c (Fwindow_edges, Fwindow_pixel_edges)
58 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
59 (Fdelete_window_internal): Signal an error if the window is not on
60 a live frame (Bug#12025).
61
e69b0960
DA
622012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
63
64 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
65 * frame.h (FGET): Remove.
66 (struct frame): Do not use INTERNAL_FIELD.
67 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
68 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
69 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
70 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
71
25a20a3a
JB
722012-08-06 Juanma Barranquero <lekktu@gmail.com>
73
74 * w32.c: Silence compiler warnings.
75 (map_w32_filename): Remove unused variable `is_fat'.
76 (chase_symlinks): Add parentheses around expression.
77
1c6f11f4
GM
782012-08-06 Glenn Morris <rgm@gnu.org>
79
1db4583a
GM
80 * sysdep.c: Respect BROKEN_GETWD.
81
1c6f11f4
GM
82 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
83 Let configure handle it.
84 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
85
2b90362b
DA
862012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Use GCALIGNMENT where appropriate.
89 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
90 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
91 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
92
5f50daf2
EZ
932012-08-06 Eli Zaretskii <eliz@gnu.org>
94
95 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
96 use FRAME_MENU_BAR_ITEMS as an lvalue.
97
cbcc7007
SM
982012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
99
100 * buffer.h (struct buffer): Revert `indirections' to a simple int;
101 that should be sufficient for everyone.
102
4d365fa4
JD
1032012-08-06 Jan Djärv <jan.h.d@swipnet.se>
104
105 * keyboard.c (timer_check_2): Add break so timer_check returns next
106 timeout.
107
dd86bd82
DA
1082012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Fix Windows build errors introduced after converting to WGET and WSET.
111 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
112 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
113
054e1668
JD
1142012-08-06 Jan Djärv <jan.h.d@swipnet.se>
115
116 * nsterm.m (ns_frame_rehighlight): Use FSET.
117
118 * nsmenu.m (ns_update_menubar): Use FSET.
119
21238f11
DA
1202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
121
122 Separate read and write access to Lisp_Object slots of Lisp_Process.
123 * process.h (PGET, PSET): New macros similar to AREF and ASET.
124 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
125
077288cf
DA
1262012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
127
128 Separate read and write access to Lisp_Object slots of struct window.
129 * window.h (WGET, WSET): New macros similar to AREF and ASET.
130 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
131 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
132 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
133 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
134 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
135 Adjust users.
136
71688bd7
DA
1372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Fix Windows build errors introduced after converting to FGET and FSET.
140 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
141 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
142 (w32_judge_scroll_bars): Change to use FSET.
143 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
144
f99bac93
DA
1452012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Fix replacement typo.
148 * window.c (replace_window): Set root_window instead of
149 selected_window. This fixes a total window subsystem
150 malfunction reported by Bastien Guerry <bzg@gnu.org>.
151
8c2a0f2d
GM
1522012-08-06 Glenn Morris <rgm@gnu.org>
153
154 * lisp.mk (lisp): Add language/persian.elc.
155
edd74c35
DA
1562012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
157
158 Separate read and write access to Lisp_Object slots of struct frame.
159 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
160 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
161 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
162 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
163 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
164
8671676c
AS
1652012-08-05 Andreas Schwab <schwab@linux-m68k.org>
166
167 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
168
663e2b3f
DA
1692012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
170
171 Generalize common compile-time constants.
172 * lisp.h (header_size, bool_header_size, word_size): Now here.
173 (struct Lisp_Vector): Add comment.
174 (struct Lisp_Bool_Vector): Move up to define handy constants.
175 (VECSIZE, PSEUDOVECSIZE): Simplify.
176 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
177 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
178 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
179 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
180 * xfont.c, xmenu.c: Use word_size where appropriate.
181
d32e47af
LM
1822012-08-05 Lawrence Mitchell <wence@gmx.li>
183
184 * search.c (Freplace_match): Treat \? in the replacement text
185 literally (Bug#8161).
186
e5d9c0d1
CY
1872012-08-05 Chong Yidong <cyd@gnu.org>
188
189 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
190 * frame.c (Vdelete_frame_functions):
191 * emacs.c (Vkill_emacs_hook): Doc fix.
192
8da0576b
EZ
1932012-08-04 Eli Zaretskii <eliz@gnu.org>
194
195 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
196 --with-x-toolkit=no builds.
197 Reported by Carsten Mattner <carstenmattner@gmail.com>.
198
02676e5d
CY
1992012-08-04 Chong Yidong <cyd@gnu.org>
200
201 * syntax.c (Fmodify_syntax_entry): Doc fix.
202
97147da9
EZ
2032012-08-04 Eli Zaretskii <eliz@gnu.org>
204
76151e2c
EZ
205 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
206 * w32.c (init_environment): Change the default values of many
207 environment variables in dflt_envvars[] to NULL, to avoid pushing
208 them into environment when they were not already defined. Remove
209 the code that deletes site-lisp subdirectories from the default
210 value of EMACSLOADPATH, as it is no longer needed.
211 (check_windows_init_file): Now external, not static. Use
212 Vload_path as is, without adding anything, as this function is now
213 called when Vload_path is already set up.
214
215 * w32.h (check_windows_init_file): Add prototype.
216
217 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
218 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
219 compatibility with Posix platforms.
220 (main): Move the call to check_windows_init_file to here from
221 w32.c.
222 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
223 any, in the DEFALT argument into the root of the Emacs build or
224 installation tree, as appropriate.
225
226 * callproc.c (init_callproc_1): Call decode_env_path instead of
227 doing its equivalent by hand.
228 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
229 the code that sets Vexec_path run on MS-Windows.
230
231 * lread.c (init_lread): Add comments to #ifdef's.
232
97147da9
EZ
233 * msdos.c (dos_set_window_size, IT_update_begin)
234 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
235 instead of direct references.
236
185ee146
PE
2372012-08-04 Paul Eggert <eggert@cs.ucla.edu>
238
239 Export DEFAULT_REHASH_* to GDB.
240 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
241 Now constants, not macros.
242
8834c57a
PE
2432012-08-03 Paul Eggert <eggert@cs.ucla.edu>
244
98c6f1e3
PE
245 Remove unnecessary casts involving pointers.
246 These casts are no longer needed now that we assume C89 or later,
247 since they involve casting to or from void *.
248 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
249 (make_pure_float, make_pure_vector):
250 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
251 * macros.c (Fstart_kbd_macro):
252 * menu.c (find_and_return_menu_selection):
253 * minibuf.c (read_minibuf_noninteractive):
254 * sysdep.c (closedir):
255 * xdisp.c (x_produce_glyphs):
256 * xfaces.c (compare_fonts_by_sort_order):
257 * xfns.c (x_real_positions, select_visual):
258 * xselect.c (x_stop_queuing_selection_requests)
259 (x_get_window_property, x_get_window_property_as_lisp_data):
260 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
261 Remove unnecessary pointer casts.
262 * alloc.c (record_xmalloc): New function.
263 * lisp.h (record_xmalloc): New decl.
264 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
265 more like a function. This is because the pointer cast is not
266 needed. All uses changed.
267 * print.c (print_string, print_error_message): Avoid length recalc.
268
8834c57a
PE
269 Improve fix for macroexp crash with debugging (Bug#12118).
270 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
271 ARRAY_MARK_FLAG when checking subscripts, because ASET is
272 not supposed to be invoked from the garbage collector.
273 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
274 (gc_aset): New function, which is like ASET but can be
275 used in the garbage collector.
276 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
277 (set_hash_index): Use it instead of ASET.
278
6dad7178
EZ
2792012-08-03 Eli Zaretskii <eliz@gnu.org>
280
281 Support symlinks on latest versions of MS-Windows.
282 * w32.c: Include winioctl.h and aclapi.h.
283 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
284 (revert_to_self): Forward declarations of static functions.
285 <static BOOL g_b_init_get_security_info>:
286 <g_b_init_create_symbolic_link>: New static flags.
287 (globals_of_w32): Initialize them to zero.
288 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
289 (map_w32_filename): Improve commentary. Simplify switch.
290 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
291 headers (most versions of MinGW w32api don't).
292 (get_security_info, create_symbolic_link)
293 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
294 New functions.
295 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
296 in the argument file name.
297 (sys_access): Call unc_volume_file_attributes only if
298 GetFileAttributes fails with network-related error codes.
299 (sys_rename): Diagnose renaming of a symlink when the user doesn't
300 have the required privileges.
301 (get_file_security_desc_by_name): Renamed from
302 get_file_security_desc.
303 (stat_worker): New function, with most of the guts of 'stat', and
304 with addition of handling of symlinks and support for 'lstat'. If
305 possible, get file's attributes and security information by
306 handle, not by name. Produce S_IFLNK bit for symlinks, when
307 called from 'lstat'.
308 (stat, lstat): New functions, call 'stat_worker'.
309 (symlink, readlink, careadlinkat): Rewritten to create and resolve
310 symlinks when the underlying filesystem supports them.
311
f162bcc3
PE
3122012-08-02 Paul Eggert <eggert@cs.ucla.edu>
313
79ea6c20
PE
314 Fix macroexp crash on Windows with debugging (Bug#12118).
315 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
316 checking subscripts; problem introduced with the recent
317 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
318 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
319 since it's used in non-static inline functions now.
320
c0ce93fd
PE
321 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
322 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 323
f162bcc3
PE
324 Use C99-style 'extern inline' if available.
325 * buffer.h (BUFFER_INLINE):
326 * category.h (CATEGORY_INLINE):
327 * character.h (CHARACTER_INLINE):
328 * charset.h (CHARSET_INLINE):
329 * composite.h (COMPOSITE_INLINE):
330 * dispextern.h (DISPEXTERN_INLINE):
331 * lisp.h (LISP_INLINE):
332 * systime.h (SYSTIME_INLINE):
333 New macro, replacing 'static inline' in this header.
334 * buffer.h, category.h, character.h, charset.h, composite.h:
335 * dispextern.h, lisp.h, systime.h:
336 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
337 * alloc.c (LISP_INLINE):
338 * buffer.c (BUFFER_INLINE):
339 * category.c (CATEGORY_INLINE):
340 * character.c (CHARACTER_INLINE):
341 * charset.c (CHARSET_INLINE):
342 * composite.c (COMPOSITE_INLINE):
343 * dispnew.c (DISPEXTERN_INLINE):
344 * sysdep.c (SYSTIME_INLINE):
345 Define to EXTERN_INLINE, so that the corresponding functions
346 are compiled into code.
347 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
348 (INLINE_HEADER_END): New macros.
349 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
350 since it's used in non-static inline functions now.
a8333d03 351 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 352
837b365b
GM
3532012-08-02 Glenn Morris <rgm@gnu.org>
354
d66b744d
GM
355 * s/: Remove empty directory.
356
837b365b
GM
357 * s/ms-w32.h: Move to ../nt/inc.
358 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
359 Update for new ms-w32.h location.
360
13294f95
PE
3612012-08-02 Paul Eggert <eggert@cs.ucla.edu>
362
363 Port to Solaris 8.
364 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
365
90df0db3
GM
3662012-08-02 Glenn Morris <rgm@gnu.org>
367
368 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
369 hard-coding the path separator.
370
4939150c
PE
3712012-08-01 Paul Eggert <eggert@cs.ucla.edu>
372
373 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
374 This how ASET and AREF are supposed to work, and makes
375 it easier to think about future improvements. See
376 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
377 * charset.h (set_charset_attr): New function.
378 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
379 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
380 (aref_addr): New function. All uses of &AREF(...) changed.
381 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
382 (set_hash_index): New functions. All lvalue-style uses of
383 HASH_KEY etc. changed.
384 * keyboard.c (set_prop): New function. All lvalue-style uses
385 of PROP changed.
386
947b2afd
AA
3872012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
388
389 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
390 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
391 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
392 * nsfns.m (ns_set_name_as_filename): Likewise.
393 * nsmenu.m (ns_update_menubar): Likewise.
394 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
395
4f5d0325
EZ
3962012-08-01 Eli Zaretskii <eliz@gnu.org>
397
2008beae
EZ
398 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
399 Adapt to latest changes in field names of the corresponding Lisp
288479f6 400 objects.
2008beae 401
4f5d0325
EZ
402 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
403
fe3cc771
GM
4042012-08-01 Glenn Morris <rgm@gnu.org>
405
406 * s/msdos.h: Remove file.
407 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
408 * Makefile.in (S_FILE): Remove.
409 (config_h): Remove S_FILE.
410
c90acc54
JB
4112012-08-01 Juanma Barranquero <lekktu@gmail.com>
412
413 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
414 Remove; moved to nt/config.nt.
415
d8a05828
DA
4162012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Use INTERNAL_FIELD for conses and overlays.
419 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
420 Remove obsolete comment.
421 (MVAR): New macro.
422 (struct Lisp_Overlay): Use INTERNAL_FIELD.
423 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
424
8271d590
DA
4252012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
426
427 Use INTERNAL_FIELD for symbols.
428 * lisp.h (SVAR): New macro. Adjust users.
429 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
430 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
431
3193acd2
DA
4322012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Use INTERNAL_FIELD for processes.
435 * process.h (PVAR): New macro. Adjust style.
436 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
437 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
438
3a45383a
DA
4392012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
440
441 Use INTERNAL_FIELD for windows.
442 * window.h (WVAR): New macro.
443 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
444 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
445 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
446 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
447 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
448 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
449
c1dbc63c
PE
4502012-08-01 Paul Eggert <eggert@cs.ucla.edu>
451
452 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
453
5c0c0e8a
GM
4542012-08-01 Glenn Morris <rgm@gnu.org>
455
456 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
457 Move to configure.ac.
458
552a99b4
JB
4592012-08-01 Juanma Barranquero <lekktu@gmail.com>
460
461 * makefile.w32-in (CONFIG_H): Update dependencies.
462 (CONF_POST_H): New macro.
463
464 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
465
8d8e2dfe
GM
4662012-07-31 Glenn Morris <rgm@gnu.org>
467
bc96620a
GM
468 * Makefile.in (S_FILE): No longer set by configure.
469
476b1b2d
GM
470 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
471 is available.
472 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
473
b2c7a106
GM
474 * process.h (NULL_DEVICE):
475 * emacs.c (SEPCHAR):
476 * editfns.c (USER_FULL_NAME): Let configure set them.
477
d53d062a
GM
478 * s/README, s/template.h: Remove files.
479
4515017f
GM
480 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
481
8d8e2dfe
GM
482 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
483 Move to configure.ac.
484
5b20b3cc
EZ
4852012-07-31 Eli Zaretskii <eliz@gnu.org>
486
1e0afd9a
EZ
487 * .gdbinit (xframe): Adapt to introduction of FVAR and the
488 resulting renaming of 'struct frame' members.
489
5b20b3cc
EZ
490 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
491
492 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
493 after introduction of FVAR.
494
f1310128
JD
4952012-07-31 Jan Djärv <jan.h.d@swipnet.se>
496
79e721e0
JD
497 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
498
499 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
500 instead of compositeToPoint.
501 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
502
8d7c7eed 503 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 504
e34f7f79
DA
5052012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
508 * lisp.h (INTERNAL_FIELD): New macro.
509 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
510 (BVAR): Change to use INTERNAL_FIELD.
511 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
512 (KVAR): Change to use INTERNAL_FIELD.
513 * frame.h (FVAR): New macro.
514 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
515 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
516 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
517 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
518 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
519
c09bfb2f
DA
5202012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Miscellaneous fixes for non-default X toolkits.
523 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
524 * xterm.c (x_frame_of_widget): Remove redundant prototype.
525 Move under #ifdef USE_LUCID.
526 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
527 definition and usage to avoid warnings.
528
14c114ae
JD
5292012-07-31 Jan Djärv <jan.h.d@swipnet.se>
530
531 * nsterm.m (openFiles): Fix previous checkin.
532
3bd21e82
PE
5332012-07-31 Paul Eggert <eggert@cs.ucla.edu>
534
535 * indent.c (compute_motion): Remove unused local.
536
c1529ded
GM
5372012-07-31 Glenn Morris <rgm@gnu.org>
538
400d5621
GM
539 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
540
268e2432
GM
541 * conf_post.h [USG5_4]:
542 Move remaining contents of s/usg5-4-common.h here.
543 * s/usg5-4-common.h: Remove file.
544
7552f3ee
GM
545 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
546 * s/irix6-5.h: Remove file.
547
6a381852
GM
548 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
549 * s/darwin.h: Remove file.
550
c1529ded
GM
551 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
552 * s/hpux10-20.h: Remove file, which is now empty.
553
b429a4ee
GM
5542012-07-30 Glenn Morris <rgm@gnu.org>
555
556 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
557 * Makefile.in (config_h): Add conf_post.h.
558 * makefile.w32-in (CONFIG_H): Add conf_post.h.
559
adff3182
JD
5602012-07-30 Jan Djärv <jan.h.d@swipnet.se>
561
562 * nsterm.m (ns_do_open_file): New variable.
b9031d69 563 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
564 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
565 files only if ns_do_open_file.
566
c32af1e4
PE
5672012-07-30 Paul Eggert <eggert@cs.ucla.edu>
568
7393bcbb
PE
569 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
570 This no-op macro hasn't been needed for many years.
571 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
572
c32af1e4
PE
573 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
574 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
575 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
576 gdb_make_enums_visible.
577 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
578 (DIRECTORY_SEP): Now a constant, not a macro.
579
302fc036
EZ
5802012-07-30 Eli Zaretskii <eliz@gnu.org>
581
582 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
583 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
584
585 * w32term.c <w32_keyboard_codepage>: Renamed from
586 keyboard_codepage and now external. All users changed.
587
588 * w32term.h: Add declaration of w32_keyboard_codepage.
589
590 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
591 the codepage to translate keys to Unicode. If this argument is
592 -1, use the value returned by GetConsoleCP. All callers changed.
593
88fb40b4
PE
5942012-07-30 Paul Eggert <eggert@cs.ucla.edu>
595
0aee6912
PE
596 Update .PHONY listings in makefiles.
597 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
598 bootstrap-clean, distclean, maintainer-clean, versioclean,
599 extraclean, frc.
600
88fb40b4
PE
601 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
602 This is a bit clearer. Fix some commentary typos.
603
0a763bd1
GM
6042012-07-30 Glenn Morris <rgm@gnu.org>
605
32bac6d6
GM
606 * s/netbsd.h: Let configure include signal.h if needed.
607 Remove file, which is now empty.
608
b65e7c46
GM
609 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
610 Let configure set them.
611 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
612 No more need to undefine.
0a763bd1 613
169304bd
AS
6142012-07-30 Andreas Schwab <schwab@linux-m68k.org>
615
616 * keymap.c (Fkey_description): Don't remove 0x80 bit from
617 non-single-byte char when adding meta modifier. (Bug#12090)
618
6cd7a139
DA
6192012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
620
621 Convert safe_call to use variable number of arguments.
622 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
623 (safe_call2): Fix comment.
624 * lisp.h (safe_call): Adjust prototype.
625 * coding.c (encode_coding_object): Change to use safe_call2.
626 * xfaces.c (merge_face_heights): Change to use safe_call1.
627
d34d6ffc
GM
6282012-07-30 Glenn Morris <rgm@gnu.org>
629
7b8a48e4 630 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 631 does that unconditionally. Remove file, which is now empty.
7b8a48e4 632
d34d6ffc
GM
633 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
634 Remove empty files.
635
03a660a6
PE
6362012-07-30 Paul Eggert <eggert@cs.ucla.edu>
637
638 Export to GDB most of lisp.h's remaining object-like macros.
639 * lisp.h (min, max): Move earlier, because they're used earlier now.
640 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
641 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
642 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
643 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
644 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
645 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
646 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
647 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
648 Now constants, for GDB. They need not be macros.
649 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
650 Now constants, for GDB, as well as macros, for static initializers.
651 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
652 Move to after the definition of struct Lisp_Char_Table,
653 since the former now needs that type defined.
654 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
655 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
656 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
657 New enums, for gdb_make_enums_visible.
658 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 659 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
660 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
661 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
662 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
663 enum maxargs, enum MAX_ALLOCA.
664 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
665 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
666 no longer needed, now that they are done in lisp.h.
667
e499d0ee
DA
6682012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Cleanup string bytes checking.
671 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
672 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
673 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
674 (check_sblock, compact_small_strings): Simplify.
675
d5040d2d
PE
6762012-07-29 Paul Eggert <eggert@cs.ucla.edu>
677
678 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
679 These macros are confusing and no longer need to be defined, as
680 the enum values now suffice. All uses replaced with definiens.
681 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
682
7f259ae6
JB
6832012-07-29 Juanma Barranquero <lekktu@gmail.com>
684
685 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
686 ($(BLD)/w32console.$(O)): Update dependencies.
687
7e63e0c3
DA
6882012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
691 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
692 time. Adjust users.
693 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
694
ffd817eb
JD
6952012-07-29 Jan Djärv <jan.h.d@swipnet.se>
696
697 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
698 setting sitelisp (Bug#12010).
699
417a7a0e
EZ
7002012-07-29 Eli Zaretskii <eliz@gnu.org>
701
702 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
703
704 * w32heap.c (cache_system_info):
705 * w32.c (sys_rename):
706 * w32proc.c (find_child_console, sys_kill): All users changed.
707
387d4d92
PE
7082012-07-29 Paul Eggert <eggert@cs.ucla.edu>
709
710 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
711
55a6cca6
EZ
7122012-07-29 Eli Zaretskii <eliz@gnu.org>
713
714 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
715
dbcf001c
DA
7162012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
717
718 Cleanup statistics calculation in Fgarbage_collect.
719 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
720 zombies percentage calculation. Simplify elapsed time calculation.
721
e2688e4a
DA
7222012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
723
724 Generalize marker debugging code under MARKER_DEBUG and use eassert.
725 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
726 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
727 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
728 (replace_range, replace_range_2, del_range_2): Change to eassert.
729 * marker.c (byte_char_debug_check): Adjust style.
730
b46a6a83
PE
7312012-07-29 Paul Eggert <eggert@cs.ucla.edu>
732
733 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
734 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
735 long-ago-commented-out code that talks about "WIN32".
736 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
737 All uses changed.
738
e32a5799
PE
7392012-07-28 Paul Eggert <eggert@cs.ucla.edu>
740
741 Use Gnulib stdalign module (Bug#9772, Bug#9960).
742 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
743 Simplify by using alignof.
744 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
745 * lisp.h: Include <stdalign.h>.
746 (GCALIGNMENT): New macro and constant.
747 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
748 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
749 (stdalign): New macro, if not already defined.
750
df81cd29
EZ
7512012-07-28 Eli Zaretskii <eliz@gnu.org>
752
01bd1b0d
EZ
753 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
754 * w32inevt.c: Include w32inevt.h.
755 (w32_read_console_input): New inline function, calls either
756 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
757 w32_console_unicode_input.
758 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
759 (w32_kbd_patch_key, key_event): Use the codepage returned by
760 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
761 (key_event): use uChar.UnicodeChar only if
762 w32_console_unicode_input is non-zero.
763
764 * w32console.c: Include w32heap.h.
765 <w32_console_unicode_input>: New global variable.
766 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
767 family of Windows, zero otherwise.
768
769 * w32inevt.h: Declare w32_console_unicode_input.
770
df81cd29
EZ
771 * xdisp.c (init_iterator): Don't reference tip_frame in a build
772 --without-x. (Bug#11742)
773
c20fdd9e
PE
7742012-07-27 Paul Eggert <eggert@cs.ucla.edu>
775
776 Adjust GDB to reflect pvec_type changes (Bug#12036).
777 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
778 2012-07-04 changes to pseudovector representation. Problem
779 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
780
32770973 7812012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
782
783 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
784 bus address.
785 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
786
3438fe21
EZ
7872012-07-27 Eli Zaretskii <eliz@gnu.org>
788
bcfbc9de
EZ
789 * alloc.c (listn): Fix the order the arguments are consed onto the
790 list.
791
3438fe21
EZ
792 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
793 enumeration constants, as PURE and HEAP are too general, and clash
794 with other headers and sources, such as gmalloc.c and the
795 MS-Windows system headers. All users changed.
796
eeaea515
DA
7972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
798
799 Revert last save_excursion_save and save_excursion_restore changes.
800 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
801 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
802
073c88c2
DA
8032012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
804
805 Fix recently-introduced typos in Windows port.
806 Reported by Martin Rudalics <rudalics@gmx.at>.
807 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 808 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 809
4706125e
PE
8102012-07-27 Paul Eggert <eggert@cs.ucla.edu>
811
812 Improve GDB symbol export (Bug#12036).
813 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
814 arms of an 'if', not using conditional expressions; otherwise GDB
815 complains about the types in the unevaluated arm when the argument
816 is an integer literal.
817 (xgetint): Simplify expression.
818 * alloc.c (gdb_make_enums_visible): New constant. This ports to
819 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
820 Zaretskii in <http://bugs.gnu.org/12036#13>.
821 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
822 needed now that we have gdb_make_enums_visible.
823 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
824 (enum enum_USE_LSB_TAG):
825 New enum types, packaging up enums that need to be exported to GDB.
826
694b6c97
DA
8272012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Utility function to make a list from specified amount of objects.
830 * lisp.h (enum constype): New datatype.
831 (listn): New prototype.
832 * alloc.c (listn): New function.
833 (Fmemory_use_count, syms_of_alloc): Use it.
834 * buffer.c (syms_of_buffer): Likewise.
835 * callint.c (syms_of_callint): Likewise.
836 * charset.c (define_charset_internal): Likewise.
837 * coding.c (syms_of_coding): Likewise.
838 * keymap.c (syms_of_keymap): Likewise.
839 * search.c (syms_of_search): Likewise.
840 * syntax.c (syms_of_syntax): Likewise.
841 * w32.c (init_environment): Likewise.
842 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
843 * xdisp.c (syms_of_xdisp): Likewise.
844 * xfns.c (syms_of_xfns): Likewise.
845
6195f384
DA
8462012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Fast save_excursion_save and save_excursion_restore.
849 * lisp.h (struct Lisp_Excursion): New data type.
850 (PVEC_EXCURSION): New pseudovector type.
851 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
852 to deal with it. Adjust comments.
853 (init_marker, attach_marker): New prototype.
854 (unchain_marker): Adjust prototype.
855 * marker.c (attach_marker): Change to global.
856 (init_marker): New function.
857 * alloc.c (Fmake_marker, build_marker): Use it.
858 (build_marker): More easserts.
859 (mark_object): Handle struct Lisp_Excursion.
860 * editfns.c (save_excursion_save, save_excursion_restore):
861 Reimplement to use struct Lisp_Excursion. Add comments.
862
5eceb8fb
PE
8632012-07-26 Paul Eggert <eggert@cs.ucla.edu>
864
865 Fix export of symbols to GDB (Bug#12036).
866 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
867 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
868 emacs.c, as this is a more-suitable home. Had this been done earlier
869 the fix for 12036 would have avoided some of the problems noted in
870 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
871 would have been more obvious.
562157c8
PE
872 * emacs.c: Do not include <verify.h>; no longer needed.
873 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
874 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
875 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
876 Remove; now done in lisp.h.
877 * lisp.h (PUBLISH_TO_GDB): New macro.
878 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
879 (DATA_SEG_BITS): Use it.
880 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
881 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
882 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
883 not be usable in #if. This simplifies things.
884
d6749401
JB
8852012-07-26 Juanma Barranquero <lekktu@gmail.com>
886
887 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
888
1781b9e9
PE
8892012-07-26 Paul Eggert <eggert@cs.ucla.edu>
890
d89518db 891 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
892 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
893 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
894 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
895 Adjust to changes in lisp.h and emacs.c, by using
896 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
897 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
898 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
899 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
900 instead of gdb_valbits.
901 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
902 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
903 instead of gdb_array_mark_flag.
904 (xboolvector): Get size from $->size, not $->header.size.
905 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
906 (xreload, hook-run, hookpost-run): Remove.
907 * emacs.c: Include <verify.h>.
908 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
909 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
910 Remove.
911 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
912 (gdb_USE_LSB_TAG): New enum constants.
913 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
914 Also define these as enum constants, so they're visible to GDB.
915 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
916 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
917 as constants, so they're visible to GDB.
918 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
919 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
920 Now enum constants, not macros, so they're visible to GDB.
921 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
922 more convenient now. All uses changed.
923 (VALMASK) [USE_LSB_TAG]: Also define in this case.
924 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
925
3628596a
DA
9262012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
927
928 Explicitly free restriction data that are not needed anymore.
929 * editfns.c (save_restriction_restore): Free restriction data.
930
7abaf5cc
SM
9312012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
932
933 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
934 add argument, tune behavior, and adjust all callers.
935
71f88e00
PE
9362012-07-25 Paul Eggert <eggert@cs.ucla.edu>
937
938 Use typedef for EMACS_INT, EMACS_UINT.
939 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
940 than macros. This simplifies debugging in the usual case, since
941 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
942 and it allows expressions involving EMACS_INT casts.
943 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
944
57ec3034
JD
9452012-07-25 Jan Djärv <jan.h.d@swipnet.se>
946
947 * nsterm.m (ns_read_socket): Return early if there is a modal
948 window (Bug#12043).
949
8137e7b3
MR
9502012-07-25 Martin Rudalics <rudalics@gmx.at>
951
952 * frame.c (Fredirect_frame_focus): In doc-string don't mention
953 that FOCUS-FRAME can be omitted.
954
04e9897c
DA
9552012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Adjust buffer text indirection counters at the end of Fkill_buffer.
958 * buffer.c (Fkill_buffer): Adjust indirection counters when the
959 buffer is definitely dead. This should really fix an issue reported
960 by Christoph Scholtes again. (Bug#12007).
961 (init_buffer_once): Initialize indirection counters of
962 buffer_defaults and buffer_local_symbols (for sanity and safety).
963
8a0484e1
EZ
9642012-07-24 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (init_iterator): Don't compute dimensions of truncation
967 and continuation glyphs on tooltip frames, leave them at zero.
968 Avoids continued lines in tooltips. (Bug#11832)
969
fa691a83
DA
9702012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Simplify copy_overlay.
04e9897c 973 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
974 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
975
436bc8e0
EZ
9762012-07-23 Eli Zaretskii <eliz@gnu.org>
977
978 * print.c (print_object): Don't crash when a frame's name is nil
979 or invalid. (Bug#12025)
980
981 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
982 it signals an error when a tooltip frame is being created.
983
d7a7fda3
DA
9842012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Cleanup miscellaneous objects allocation and initialization.
987 * alloc.c (allocate_misc): Change to static. Add argument to
988 specify the subtype. Adjust comment and users.
989 (build_overlay): New function.
990 * buffer.c (copy_overlays, Fmake_overlay): Use it.
991 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
992 (allocate_misc): Remove prototype.
993 (build_overlay): Add prototype.
994
9952012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
996
997 Swap buffer text indirection counters in Fbuffer_swap_text.
998 * buffer.c (Fbuffer_swap_text): Swap indirections too.
999 This avoids crash reported by Christoph Scholtes at
1000 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1001
9d7fa573
JD
10022012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1003
1004 * nsmenu.m (Popdown_data): New struct.
1005 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1006 free Popdown_data.
1007 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1008 (initWithContentRect): Make imgView and contentView non-static
1009 and autorelease them. Also autorelease img and matrix (Bug#12005).
1010 (dealloc): Remove (Bug#12005).
1011
0dd6d66d
DA
10122012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1013
1014 Adjust consing_since_gc when objects are explicitly freed.
1015 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1016 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1017 (free_cons, free_misc): Subtract object size from consing_since_gc.
1018
d36d71df
DA
10192012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 Simplify and cleanup markers positioning code.
1022 * marker.c (attach_marker): More useful eassert.
1023 (live_buffer, set_marker_internal): New function.
1024 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1025 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1026
fb9ea40f
PE
10272012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1030 as it's limited by the amount of memory, not by INT_MAX.
1031
2d5c5f7d
EZ
10322012-07-21 Eli Zaretskii <eliz@gnu.org>
1033
07fb592e
EZ
1034 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1035 in special-event-map. See the discussion at
1036 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1037 for the reasons.
1038
37a9eac8 1039 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
1040 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1041 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1042
c4328746
JD
10432012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1044
1045 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1046 (conversationIdentifier): Return value is NSInteger.
784051c4 1047 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1048
6e5d1c12
CY
10492012-07-21 Chong Yidong <cyd@gnu.org>
1050
1051 * window.c (decode_any_window): Signal an error if the window is
1052 on a dead frame (Bug#11984).
1053
9928463d
DA
10542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1055
1056 Add indirection counting to speed up Fkill_buffer.
1057 * buffer.h (struct buffer): New member.
1058 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1059 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1060 base buffer indirection counter.
1061 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1062 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1063 through buffer list if indirection counter is 0.
1064
f8643a6b
DA
10652012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 Extend the value returned by Fgarbage_collect with heap statistics.
1068 * alloc.c (Qheap): New symbol.
1069 (syms_of_alloc): DEFSYM it.
1070 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1071 (Fmemory_free): Remove.
1072 (syms_of_alloc): Don't defsubr it.
1073 * buffer.c (Fcompact_buffer): Remove.
1074 (syms_of_buffer): Don't defsubr it.
1075
dac616ff
DA
10762012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Make maybe_gc inline.
1079 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1080 * lisp.h (consing_since_gc, gc_relative_threshold)
1081 (memory_full_cons_threshold): Revert declaration.
1082 (maybe_gc): Remove prototype, define as inline.
1083 * alloc.c: Remove old commented-out code.
1084 (consing_since_gc, gc_relative_threshold)
1085 (memory_full_cons_threshold): Revert to global.
1086 (maybe_gc): Remove.
1087
d7ea76b4
DA
10882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1089
1090 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1091 * lisp.h (build_unibyte_string): New function.
1092 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1093 * sysdep.c, w32fns.c, xfns.c: Use it.
1094 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1095 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1096 Adjust users accordingly.
1097 * font.h (font_open_by_name): Adjust prototype.
1098
765e61e3
DA
10992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 Cleanup calls to Fgarbage_collect.
1102 * lisp.h (maybe_gc): New prototype.
1103 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1104 Remove declarations.
1105 * alloc.c (maybe_gc): New function.
1106 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1107 Make them static.
1108 * bytecode.c (MAYBE_GC): Use maybe_gc.
1109 * eval.c (eval_sub, Ffuncall): Likewise.
1110 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1111 to avoid dependency from auto-save feature.
1112
52b852c7
PE
11132012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1116 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1117 'for_each_per_buffer_object_at'.
1118 All uses changed. It's better to use upper-case for macros that
1119 cannot be implemented as functions, to give the reader a clue
1120 that they're special.
1121
5db81e33
SM
11222012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1123
1124 * alloc.c (Fgarbage_collect): Tweak docstring.
1125
5b835e1d
DA
11262012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1127
1128 Tweak the value returned from Fgarbage_collect again.
1129 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1130 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1131 Adjust documentation.
1132 (total_vector_bytes): Rename to total_vector_slots, adjust
1133 accounting.
1134 (total_free_vector_bytes): Rename to total_free_vector_slots,
1135 adjust accounting.
1136 (Qstring_bytes, Qvector_slots): New symbols.
1137 (syms_of_alloc): DEFSYM them.
1138
9cd47b72
DA
11392012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Buffer compaction primitive which may be used from Lisp.
1142 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1143 (syms_of_buffer): Register Fcompact_buffer.
1144 * alloc.c (Fgarbage_collect): Use compact_buffer.
1145 * buffer.h (compact_buffer): New prototype.
1146 (struct buffer_text): New member.
1147
d17337e5
DA
11482012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 New macro to iterate over all buffers, miscellaneous cleanups.
1151 * lisp.h (all_buffers): Remove declaration.
1152 * buffer.h (all_buffers): Add declaration, with comment.
1153 (for_each_buffer): New macro.
1154 * alloc.c (Fgarbage_collect, mark_object): Use it.
1155 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1156 (init_buffer): Likewise.
1157 * data.c (Fset_default): Likewise.
1158 * coding.c (code_conversion_restore): Remove redundant check
1159 for dead buffer.
1160 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1161
60cfd278
AS
11622012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 Fix bug that created negative-length intervals.
1165 * intervals.c (merge_interval_right, merge_interval_left):
1166 Do not zero out this interval if it is absorbed by its children,
1167 as this interval's total length doesn't change in that case. See
1168 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1169
d06714cb
PE
11702012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1171
83713154
PE
1172 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1173 when invoking (make-bool-vector N t) and N is a positive
1174 multiple of 8 -- the last 8 bits were mistakenly cleared.
1175
d06714cb
PE
1176 Remove some struct layout assumptions in bool vectors.
1177 * alloc.c (bool_header_size): New constant.
1178 (header_size, word_size): Move earlier, as they're now used earlier.
1179 Use 'word_size' in a few more places, where it's appropriate.
1180 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1181 padding before the data member of a bool vector.
1182 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1183 than doing the check by hand with an abort ().
1184
464d5a5e
SM
11852012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1186
5fbc0409
SM
1187 * eval.c (Fdefvar): Don't check constants since we only set the var if
1188 it's not yet defined anyway (bug#11904).
1189
464d5a5e
SM
1190 * lisp.h (last_undo_boundary): Declare new var.
1191 * keyboard.c (command_loop_1): Set it.
1192 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1193 were auto-added by the command loop (bug#11774).
1194
8dc2e44a
AS
11952012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1196
1197 * w32font.c (Qsymbol): Remove local definition.
1198 (syms_of_w32font): Don't DEFSYM it.
1199
169925ec
DA
12002012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 Fix sweep_vectors to handle large bool vectors correctly.
1203 * alloc.c (sweep_vectors): Account total_vector_bytes for
1204 bool vectors larger than VBLOCK_BYTES_MAX.
1205
5fbfb018
CY
12062012-07-18 Chong Yidong <cyd@gnu.org>
1207
1208 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1209 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1210
3ab6e069
DA
12112012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1212
1213 Return more descriptive data from Fgarbage_collect.
1214 Suggested by Stefan Monnier in
1215 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1216 * alloc.c (bounded_number): New function.
1217 (total_buffers, total_vectors): New variable.
1218 (total_string_size): Rename to total_string_bytes, adjust users.
1219 (total_vector_size): Rename to total_vector_bytes, adjust users.
1220 (sweep_vectors): Account total_vectors and total_vector_bytes.
1221 (Fgarbage_collect): New return value. Adjust documentation.
1222 (gc_sweep): Account total_buffers.
1223 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1224 (VECTOR_SIZE): Remove.
1225 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1226 (Qinterval, Qmisc): New symbols.
1227 (syms_of_data): Initialize them.
1228 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1229 (Qcons, Qbuffer): New declarations.
1230
6d02fe5b
PE
12312012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1234 Round up, not down. Improve doc.
1235
b7ffe040
DA
12362012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1237
1238 Restore old code in allocate_string_data to avoid Faset breakage.
1239 Reported by Julien Danjou <julien@danjou.info> in
1240 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1241 * alloc.c (allocate_string_data): Restore old code with minor
1242 adjustments, fix comment to explain this subtle issue.
1243
4dc7c8d5
SM
12442012-07-17 Eli Zaretskii <eliz@gnu.org>
1245
1246 Remove FILE_SYSTEM_CASE.
1247 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1248
1249 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1250 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1251 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1252 call-process-region passes it through expand-file-name.
1253
1254 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1255
12562012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1257
1258 Fix crash when creating indirect buffer (Bug#11917)
1259 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1260 Don't handle unbound variables specially if non-zero.
1261 (Fbuffer_local_variables): Pass zero.
1262 (clone_per_buffer_values): Pass non-zero.
1263
12642012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1265
1266 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1267 to make the loop interruptible.
1268
12692012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1270
1271 * gnutls.c (emacs_gnutls_handshake): Only retry if
1272 GNUTLS_E_INTERRUPTED.
1273
cce7fefc
DA
12742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 Cleanup and convert miscellaneous checks to eassert.
1277 * alloc.c (mark_interval): Fix comment, partially rephrase
1278 old comment from intervals.h (see below).
1279 * intervals.c (find_interval, adjust_intervals_for_insertion)
1280 (delete_interval, adjust_intervals_for_deletion)
1281 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1282 Convert to eassert.
1283 (adjust_intervals_for_insertion, make_new_interval):
1284 Remove obsolete and unused code.
1285 * intervals.h (struct interval): Remove obsolete comment.
1286 * textprotp.c (erase_properties): Remove unused code.
1287 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1288 (Fremove_list_of_text_properties): Convert to eassert.
1289
9ea10cc3
CY
12902012-07-17 Chong Yidong <cyd@gnu.org>
1291
1292 * editfns.c (Finsert_char): Doc fix.
1293
3900d5de
DA
12942012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 Fix previous change to make Fmemory_free always accurate.
1297 * alloc.c (make_interval): Update total_free_intervals.
1298 (make_float): Likewise for total_free_floats.
1299 (free_cons, Fcons): Likewise for total_free_conses.
1300 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1301 Likewise for total_free_vector_bytes.
1302 (Fmake_symbol): Likewise for total_free_symbols.
1303 (bytes_free): Remove.
1304
7098646f
DA
13052012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Simple free memory accounting feature.
1308 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1309 (sweep_vectors): Accumulate size of free vectors.
1310 (Fgarbage_collect): Setup bytes_free.
1311 (Fmemory_free): New function.
1312 (syms_of_alloc): Register it.
1313
22657b40
DA
13142012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 Cleanup overlays checking.
1317 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1318 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1319 eassert and OVERLAYP.
1320 (sort_overlays): Change to use OVERLAYP.
1321
ddfc8813
RK
13222012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1323
1324 * editfns.c (Finsert_char): Make it interactive, and make the
1325 second arg optional. Copy interactive spec and docstring from
1326 ucs-insert.
1327
7c26cf3c
PE
13282012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1331 Unlike the other wrapped functions, fabs has an unspecified
1332 effect on errno.
1333
5d127af9
JD
13342012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1335
1336 * nsterm.m (keyDown): Interpret flags without left/right bits
1337 as the left key (Bug#11670).
1338
6a0dd1d7
DA
13392012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1340
1341 Remove empty and useless init functions.
1342 * lisp.h (init_character_once, init_fns, init_image)
1343 (init_filelock, init_sound): Remove prototype.
1344 * character.c (init_character_once): Remove.
1345 * filelock.c (init_filelock): Likewise.
1346 * fns.c (init_fns): Likewise.
1347 * image.c (init_image): Likewise.
1348 * sound.c (init_sound): Likewise.
1349 * emacs.c (main): Adjust accordingly.
1350
7a6136fd
DA
13512012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 * gtkutil.h: Tiny cleanups.
1354 (use_old_gtk_file_dialog): Remove useless declaration.
1355 (xg_uses_old_file_dialog): Add suggested const attribute.
1356
ce811ad9
EZ
13572012-07-15 Eli Zaretskii <eliz@gnu.org>
1358
1359 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1360 (bidi_paragraph_init): Use it to limit search forward for a strong
1361 directional character in abnormally large paragraphs full of
1362 neutral or weak characters. (Bug#11943)
1363
c9adfeaa
SF
13642012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1365
1366 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1367 the toolbar (Bug#9451).
1368 (xg_make_tool_item): Give the widget event box a transparent
1369 background.
1370
fff62aa9
DA
13712012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 Cleanup basic allocation variables and functions.
1374 * alloc.c (ignore_warnings, init_intervals, init_float)
1375 (init_cons, init_symbol, init_marker): Remove.
1376 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1377 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1378 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1379 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1380 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1381 (staticidx, init_alloc_once, init_strings, free_ablock):
1382 Remove redundant initialization.
1383 * fns.c (init_weak_hash_tables): Remove.
1384 * lisp.h (init_weak_hash_tables): Remove prototype.
1385
9730daca
DA
13862012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 Use zero_vector where appropriate.
1389 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1390 accordingly.
1391 * lisp.h (zero_vector): New declaration.
1392 * font.c (null_vector): Remove.
1393 (syms_of_font): Remove initialization and staticpro.
1394 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1395 * keymap.c (Faccessible_keymaps): Likewise.
1396
2e2d2a13
LL
13972012-07-15 Leo Liu <sdl.web@gmail.com>
1398
1399 * fringe.c: Fix typo in comments.
1400
cd276f6e
LL
14012012-07-14 Leo Liu <sdl.web@gmail.com>
1402
1403 * fringe.c: Add a new bitmap exclamation-mark.
1404
5a1131d9
EZ
14052012-07-14 Eli Zaretskii <eliz@gnu.org>
1406
1407 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1408
1409 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1410 (HAVE_MENUS): Don't define, defined by editing config.in with
1411 msdos/sed2v2.inp.
1412 (GMALLOC_INHIBIT_VALLOC): Don't define.
1413 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1414
22e983b7
JB
14152012-07-14 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1418
5b3f250f
GM
14192012-07-14 Glenn Morris <rgm@gnu.org>
1420
1421 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1422 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1423 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1424
33d63ff4
GM
14252012-07-13 Glenn Morris <rgm@gnu.org>
1426
5b633342
GM
1427 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1428
33d63ff4
GM
1429 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1430 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1431
b55b9f85
JD
14322012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1433
0dc8cf50
JD
1434 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1435 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1436 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1437 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1438 where appropriate.
1439 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1440 as boolean expression.
1441 (x_set_window_size): Remove unused variable toolbar.
1442 (ns_get_color_default, ns_mod_to_lisp): Remove.
1443 (ns_mouse_position): Remove unused variables xchar and ychar.
1444 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1445 (ns_set_vertical_scroll_bar): Remove unused variable count.
1446 (ns_delete_terminal): Remove unused variable i.
1447 (ns_term_init): Remove unused variables r, g and b.
1448 (mouseDown): Remove unused variable window.
1449 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1450 (initFrameFromEmacs): Remove unused variable vbextra.
1451 (mouseEntered): Remove unused variables p and dpyinfo.
1452 (mouseExited): Remove unused variables p and r.
1453 (ns_define_frame_cursor, ns_clear_frame_area)
1454 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1455 (menuDown): Assign [sender tag] to variable and cast the variable.
1456
1457 * nsterm.h (menuDown): Add id as type to argument sender.
1458 (ns_display_info_for_name): Add Lisp_Object argument.
1459 (ns_term_init): Add Lisp_Object argument.
1460 (ns_map_event_to_object): Add void argument.
1461 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1462 prototype with arguments and only declare if __OBJC__.
1463 (nxatoms_of_nsselect): Add void argument.
1464 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1465 (ns_alloc_autorelease_pool): Add void argument.
1466 (ns_release_autorelease_pool): Add void* argument.
1467 (ns_get_defaults_value): Add const char* argument.
1468
1469 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1470 (initFromContents): Use SSDATA where appropriate.
1471 (ns_update_menubar): Add braces to ambigous if-else.
1472 (initWithTitle): Put () around assignment in if statement.
1473 (ns_menu_show): Remove unused variables window and keymap.
1474 (update_frame_tool_bar): Remove unused variable selected_p.
1475 (initWithContentRect): Remove unused variable this_cmd_name.
1476
1477 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1478 appropriate.
1479 (setXBMColor): Remove unused variable len.
1480 (setPixmapData): Put () around assignment in loop statement.
1481
1482 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1483 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1484 where appropriate.
1485 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1486 around assignment in loop statement.
1487 (nsfont_open): Remove unused variable i.
1488 (nsfont_open): Remove unused variable len.
1489 (nsfont_draw): Remove unused variable cs.
1490
1491 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1492 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1493 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1494 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1495 (Fns_font_name, Fns_perform_service)
1496 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1497 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1498 (ns_set_name): Remove unused variable view.
1499 (x_set_menu_bar_lines): Remove unused variable olines.
1500 (x_set_tool_bar_lines): Remove unused variable root_window.
1501 (Fns_list_colors): Put () around assignment in while statement.
1502 (Fns_perform_service): Remove unused variable len.
1503 (Fns_display_usable_bounds): Remove unused variable top.
1504 (syms_of_nsfns): Remove unused variable i.
1505
b55b9f85
JD
1506 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1507 memcpy (Bug#11907).
1508
ed9265fc 15092012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1510
1511 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1512 and free it with DestroyExceptionInfo (Bug#11558).
1513
ef099b57
JB
15142012-07-13 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1517 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1518 Set here, not in nt/config.nt.
1519
ea814a5d
EZ
15202012-07-13 Eli Zaretskii <eliz@gnu.org>
1521
1522 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1523 cursor overflow into the last glyph on display line when the right
1524 fringe is off. (Bug#11832)
1525
1a952767
PE
15262012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * xdisp.c (produce_special_glyphs): Now static.
1529 * dispextern.h (produce_special_glyphs): Remove decl.
1530
983188fd
GM
15312012-07-13 Glenn Morris <rgm@gnu.org>
1532
8d7c7eed 1533 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1534 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1535
983188fd
GM
1536 * s/usg5-4-common.h (USG, USG5):
1537 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1538 * s/sol2-6.h (SOLARIS2):
1539 * s/irix6-5.h (IRIX6_5):
1540 * s/hpux10-20.h (USG, USG5, HPUX):
1541 * s/gnu-linux.h (USG, GNU_LINUX):
1542 * s/freebsd.h (BSD_SYSTEM):
1543 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1544 * s/cygwin.h (CYGWIN):
1545 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1546 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1547
d1e68667 15482012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1549
1550 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1551
6de0e799
GM
15522012-07-13 Glenn Morris <rgm@gnu.org>
1553
739ae010
GM
1554 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1555
dbee5793
GM
1556 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1557
6de0e799
GM
1558 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1559 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1560
b82da769
GM
15612012-07-12 Glenn Morris <rgm@gnu.org>
1562
4fae5a7a 1563 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1564
1565 * process.c (init_process_emacs): Rename from init_process.
1566 The old name is also the name of a Mach system call.
1567 * lisp.h, emacs.c: Update for this name change.
1568 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1569 longer needed.
1570
5a979817
EZ
15712012-07-12 Eli Zaretskii <eliz@gnu.org>
1572
1573 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1574 memmove call that removes glyphs covered by the left truncation
1575 glyph. Improve commentary.
1576 (display_line): Fix display of continuation glyphs on GUI frames
1577 when the right fringe is turned off and variable-size fonts are
1578 used in the window. Move the code that appends a stretch glyph to
1579 produce_special_glyphs, so that it could be used for truncation
1580 and continuation glyphs alike.
1581 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1582 glyph of a suitably computed width, to align the special glyphs at
1583 the window margin. Code moved from display_line. (Bug#11832)
1584
3e91a053
GM
15852012-07-12 Glenn Morris <rgm@gnu.org>
1586
ba9e4b84
GM
1587 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1588
1589 * s/gnu-linux.h, s/hpux10-20.h:
1590 Do not unconditionally define HAVE_XRMSETDATABASE.
1591
3e91a053
GM
1592 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1593
b300b1f4
PE
15942012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 Fix typos that broke OS X build.
1597 Reported by Randal L. Schwartz in
1598 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1599 * nsterm.m (ns_timeout): Add missing local decl.
1600 (ns_get_color): snprintf -> sprintf, to fix typo.
1601
6e777848
GM
16022012-07-12 Glenn Morris <rgm@gnu.org>
1603
3f922c37
GM
1604 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1605 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1606 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1607 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1608
0ab7b23a
GM
1609 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1610 Move PTY_OPEN to configure.
1611
6e777848
GM
1612 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1613 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1614 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1615
4a7edc24
DA
16162012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 Use empty_unibyte_string where applicable.
1619 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1620 * lread.c (read1): Likewise.
1621 * xsettings.c (syms_of_xsettings): Likewise.
1622
308aab79
GM
16232012-07-12 Glenn Morris <rgm@gnu.org>
1624
42bd1719
GM
1625 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1626 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1627 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1628 * s/hpux10-20.h (RUN_TIME_REMAP):
1629 * s/bsd-common.h (TABDLY): Move to configure.
1630
1631 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1632
1633 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1634
ea0bbd17 1635 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1636 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1637
1638 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1639
308aab79
GM
1640 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1641 * s/template.h: Move NARROWPROTO to configure.
1642
ee1cf5cf
GM
16432012-07-11 Glenn Morris <rgm@gnu.org>
1644
30fe9bf4
GM
1645 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1646 unused since 2011-01-17 change to systty.h.
1647
ee1cf5cf
GM
1648 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1649 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1650 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1651
63e47e07
PE
16522012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1655
c43fb4c3
GM
16562012-07-11 Glenn Morris <rgm@gnu.org>
1657
1658 * s/darwin.h, s/gnu-linux.h, s/template.h:
1659 Move INTERRUPT_INPUT to configure.
1660
e8df9267
DA
16612012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1662
1663 Minor adjustments to interning code.
1664 * lisp.h (intern, intern_c_string): Redefine as static inline
1665 wrappers for intern_1 and intern_c_string_1, respectively.
1666 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1667 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1668 Vobarray checking.
e8df9267
DA
1669 * font.c (font_intern_prop): Likewise. Adjust comment.
1670 * w32font.c (intern_font_name): Likewise.
1671
34348bd4
AS
16722012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1673
d96a1e0c
AS
1674 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1675
34348bd4
AS
1676 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1677 of Fcar/Fcdr if possible.
1678 * font.c (check_otf_features): Likewise.
1679 * fontset.c (Fnew_fontset): Likewise.
1680 * gnutls.c (Fgnutls_boot): Likewise.
1681 * minibuf.c (read_minibuf): Likewise.
1682 * msdos.c (IT_set_frame_parameters): Likewise.
1683 * xmenu.c (Fx_popup_dialog): Likewise.
1684 * w32menu.c (Fx_popup_dialog): Likewise.
1685
c8add24e
GM
16862012-07-11 Glenn Morris <rgm@gnu.org>
1687
4b575b3c
GM
1688 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1689 since nothing has defined it on these platforms.
1690
09f4e3b0
GM
1691 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1692 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1693
172bedef
GM
1694 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1695 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1696 Move CLASH_DETECTION to configure.
1697
249685df
GM
1698 * s/gnu.h: Remove file, which is now empty.
1699
c8add24e
GM
1700 * s/gnu.h, s/gnu-linux.h:
1701 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1702
b41253a3
JW
17032012-07-11 John Wiegley <johnw@newartisans.com>
1704
1705 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1706 function attribute, so we only use it if it exists in the
1707 compiler.
1708
d923b542
DA
17092012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 Avoid call to strlen in fast_c_string_match_ignore_case.
1712 * search.c (fast_c_string_match_ignore_case): Change to use
1713 length argument. Adjust users accordingly.
1714 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1715
5ebbef1d
PE
17162012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1717
bb352260
PE
1718 Assume mkdir, rmdir.
1719 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1720 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1721
57054ddd
PE
1722 Assume rename.
1723 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1724
b747d3f7
PE
1725 Assume perror.
1726 * s/hpux10-20.h (HAVE_PERROR): Remove.
1727 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1728 Remove dummy definition, as this problem was obsolete long ago.
1729
5ebbef1d
PE
1730 Assume strerror.
1731 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1732
984e7f30
DA
17332012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 Avoid calls to strlen in font processing functions.
1736 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1737 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1738 users accordingly.
d923b542
DA
1739 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1740 Adjust prototypes.
1741 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1742 Change to return ptrdiff_t.
984e7f30
DA
1743 (xfont_list_pattern, xfont_match): Use length returned by
1744 xfont_decode_coding_xlfd.
1745 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1746
20e94fdd
GM
17472012-07-11 Glenn Morris <rgm@gnu.org>
1748
9d596af3
GM
1749 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1750 Move DONT_REOPEN_PTY to configure.
1751
20e94fdd
GM
1752 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1753 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1754
e99a530f
PE
17552012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1756
22ffb973
PE
1757 Remove "#define unix" that is no longer needed (Bug#11905).
1758 * s/aix4-2.h (unix): Remove; no longer needed.
1759
e9a9ae03
PE
1760 EMACS_TIME simplification (Bug#11875).
1761 This replaces macros (which typically do not work in GDB)
1762 with functions, typedefs and enums, making the code easier to debug.
1763 The functional style also makes code easier to read and maintain.
1764 * systime.h: Include <sys/time.h> on all hosts, not just if
1765 WINDOWSNT, since 'struct timeval' is needed in general.
1766 (EMACS_TIME): Now a typedef, not a macro.
1767 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1768 not macros.
1769 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1770 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1771 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1772 (EMACS_TIME_LE): Now functions, not macros.
1773 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1774 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1775 which are not functions. All uses rewritten to use:
1776 (make_emacs_time): New function.
1777 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1778 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1779 not functions. All uses rewritten to use the following, respectively:
1780 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1781 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1782 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1783 * fileio.c (Fcopy_file):
1784 * xterm.c (XTflash): Get the current time closer to when it's used.
1785 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1786
ffacb126
PE
1787 * bytecode.c (targets): Suppress -Woverride-init warnings.
1788
e99a530f
PE
1789 Simplify by avoiding confusing use of strncpy etc.
1790 * doc.c (Fsnarf_documentation):
1791 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1792 * frame.c (Fmake_terminal_frame):
1793 * gtkutil.c (get_utf8_string):
1794 * lread.c (openp):
1795 * nsmenu.m (ns_update_menubar):
1796 * regex.c (regerror):
1797 Prefer memcpy to strncpy and strncat when either will do.
1798 * fileio.c (Fsubstitute_in_file_name):
1799 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1800 (menu_separator_name_p):
1801 * nsmenu.m (ns_update_menubar):
1802 Prefer memcmp to strncmp when either will do.
1803 * nsterm.m: Include <ftoastr.h>.
1804 (ns_get_color):
1805 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1806 Prefer snprintf to strncpy.
1807 * nsterm.m (ns_term_init):
1808 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1809 * nsterm.m (ns_term_init):
1810 Avoid the need for strncpy, by using build_string or
1811 make_unibyte_string directly. Use dtoastr, not snprintf.
1812 * process.c (Fmake_network_process): Diagnose service names that
1813 are too long, rather than silently truncating them or creating
1814 non-null-terminated names.
1815 (Fnetwork_interface_info): Likewise, for interface names.
1816 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1817 Prefer sprintf to strncat.
1818 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1819 Prefer vsnprintf to vsprintf + strncpy.
1820
c59592b3
GM
18212012-07-10 Glenn Morris <rgm@gnu.org>
1822
1823 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1824 Clarify fallback case.
1825
7d7bbefd
DA
18262012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1829 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1830 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1831 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1832 where argument type is known to be a Lisp_Cons.
1833
3a4c8000
TT
18342012-07-10 Tom Tromey <tromey@redhat.com>
1835
1836 * bytecode.c (BYTE_CODE_THREADED): New macro.
1837 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1838 (enum byte_code_op): New type.
1839 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1840 (exec_byte_code): Use them. Use token threading when applicable.
1841
2a0213a6
DA
18422012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 Optimize pure C strings initialization.
1845 * lisp.h (make_pure_string): Fix prototype.
1846 (build_pure_c_string): New function, defined as static inline. This
1847 provides a better opportunity to optimize away calls to strlen when
1848 the function is called with compile-time constant argument.
1849 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1850 argument, adjust users accordingly. Use build_pure_c_string where
1851 appropriate.
1852 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1853 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1854 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1855
cb1caeaf
DA
18562012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1857
1858 Avoid calls to strlen in miscellaneous functions.
1859 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1860 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1861 * lread.c (openp): Likewise.
1862
c293e30c
DA
18632012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 Avoid calls to strlen in path processing functions.
1866 * fileio.c (file_name_as_directory): Add comment. Change to add
1867 srclen argument and return the length of result. Adjust users
1868 accordingly.
1869 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1870 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1871 users accordingly.
1872 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1873
9e059e3f
GM
18742012-07-10 Glenn Morris <rgm@gnu.org>
1875
d02eb359
GM
1876 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1877 Move PENDING_OUTPUT_COUNT definition to configure.
1878
882cf227
GM
1879 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1880 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1881 * s/gnu.h (DATA_START): Move definitions to configure.
1882
af6e839f
GM
1883 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1884 We include usg5-4-common.h, which defines them both.
1885
40289a12
GM
1886 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1887 O_RDONLY already includes it).
1888
9e059e3f
GM
1889 Stop ns builds setting the EMACSLOADPATH environment variable.
1890 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1891 Now it does not set EMACSLOADPATH, just returns the load-path string.
1892 * nsterm.h: Update accordingly.
1893 * lread.c [HAVE_NS]: Include nsterm.h.
1894 (init_lread) [HAVE_NS]: Use ns_load_path.
1895 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1896
7c4e8ec0
GM
18972012-07-09 Glenn Morris <rgm@gnu.org>
1898
d4f600ff
GM
1899 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1900 since the included bsd-common.h does so.
1901
cbb31951
GM
1902 Stop ns builds setting the EMACSPATH environment variable.
1903 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1904 (ns_init_paths): Do not set EMACSPATH.
1905 * nsterm.h (ns_exec_path): Add it.
1906 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1907 Use ns_exec_path.
1908
7c4e8ec0
GM
1909 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1910
26bccfae
PE
19112012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1912
a0bee46f
PE
1913 * process.c (wait_reading_process_output): 'waitchannels' was unset
1914 when read_kbd || !NILP (wait_for_cell); fix this.
1915
5994c183
PE
1916 Add GCC-style 'const' attribute to functions that can use it.
1917 * character.h (char_resolve_modifier_mask):
1918 * keyboard.h (make_ctrl_char):
1919 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1920 (init_character_once, next_almost_prime, init_fns, init_image)
1921 (flush_pending_output, init_sound):
1922 * mem-limits.h (start_of_data):
1923 * menu.h (finish_menu_items):
1924 Add ATTRIBUTE_CONST.
1925 * emacs.c (DEFINE_DUMMY_FUNCTION):
1926 Declare the dummy function with ATTRIBUTE_CONST.
1927 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1928 Add decls with ATTRIBUTE_CONST.
1929
26bccfae
PE
1930 Minor improvements to make_formatted_string.
1931 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1932 where int is good enough, as vsprintf returns an int.
1933 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1934
a8290ec3
DA
19352012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1936
1937 Use make_formatted_string to avoid double length calculation.
1938 * lisp.h (make_formatted_string): New prototype.
1939 * alloc.c (make_formatted_string): New function.
1940 * buffer.c (Fgenerate_new_buffer_name): Use it.
1941 * dbus.c (syms_of_dbusbind): Likewise.
1942 * editfns.c (Fcurrent_time_zone): Likewise.
1943 * filelock.c (get_boot_time): Likewise.
1944 * frame.c (make_terminal_frame, set_term_frame_name)
1945 (x_report_frame_params): Likewise.
1946 * image.c (gs_load): Likewise.
1947 * minibuf.c (get_minibuffer): Likewise.
1948 * msdos.c (dos_set_window_size): Likewise.
1949 * process.c (make_process): Likewise.
1950 * xdisp.c (ensure_echo_area_buffers): Likewise.
1951 * xsettings.c (apply_xft_settings): Likewise.
1952
d01ba2f1
GM
19532012-07-09 Glenn Morris <rgm@gnu.org>
1954
1955 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1956 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1957 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1958 * nsterm.h (ns_etc_directory): Add it.
1959 * callproc.c [HAVE_NS]: Include nsterm.h.
1960 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1961
f1f924b6
DA
19622012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1963
1964 Move marker debugging code under MARKER_DEBUG.
1965 * marker.c (MARKER_DEBUG): Move marker debugging code under
1966 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1967 for bootstrap with --enable-checking (~3x slowdown reported
1968 by Juanma Barranquero <lekktu@gmail.com>).
1969 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1970
ab531b66
PE
19712012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1974 See <http://bugs.gnu.org/11825#29>.
1975
c4b3bc8a
EZ
19762012-07-08 Eli Zaretskii <eliz@gnu.org>
1977
1978 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1979 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1980 (display_line): Add commentary about displaying truncation glyphs
1981 on GUI frames.
1982 (produce_special_glyphs): Move here from term.c.
1983
1984 * term.c (produce_special_glyphs): Move to xdisp.c.
1985
1986 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1987 section.
c4b3bc8a 1988
b676b881
AS
19892012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1990
f17c5273
AS
1991 * xdisp.c (display_line): Avoid warning about implicit declaration
1992 of FRAME_FONT.
1993
298819b9
AS
1994 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1995
b676b881
AS
1996 * lisp.h: Remove empty conditional.
1997
6045c4fd
PE
19982012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1999
b3350bf9
PE
2000 * lread.c (load_path_check): Now static.
2001
6045c4fd
PE
2002 Fix some minor --with-ns problems found by static checking.
2003 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2004 (x_set_font) [!HAVE_X_WINDOWS]:
2005 * image.c (xpm_load_image) [HAVE_NS]:
2006 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2007 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2008 Remove unused local.
2009 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2010 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2011 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2012 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2013 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2014 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2015 Fix pointer signedness problem.
2016 * xfaces.c (FRAME_X_FONT_TABLE):
2017 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2018
929e7845
GM
20192012-07-07 Glenn Morris <rgm@gnu.org>
2020
2021 * lread.c (load_path_check): New function, split from init_lread.
2022 (init_lread): Reorganize. Motivation:
2023 If EMACSLOADPATH is set, check/warn about that rather than the
2024 defaults, which we are not going to use. Hence we can remove
2025 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2026 Don't warn if site-lisp directories are missing.
2027 If not installed, start from a blank load-path, since
2028 PATH_LOADSEARCH refers to the eventual installation directories.
2029
58dd0aa4
EZ
20302012-07-07 Eli Zaretskii <eliz@gnu.org>
2031
2032 Support truncation and continuation glyphs on GUI frames, when
2033 fringes are disabled. (Bug#11832)
2034 * xdisp.c (init_iterator): Get dimensions of truncation and
2035 continuation glyphs even if on GUI frames. Adjust
2036 it->last_visible_x on GUI frames when the left or right fringes,
2037 or both, are absent.
2038 (start_display, move_it_in_display_line_to): Handle the case of a
2039 GUI frame without a fringe to display continuation or truncation
2040 glyphs.
2041 (insert_left_trunc_glyphs): Support GUI frames: make sure
2042 truncation glyphs overwrite enough glyphs from the current line to
2043 have sufficient space in pixels.
2044 (display_line): Support truncation and continuation glyphs on GUI
2045 frames. If some spare pixels are left on the line after inserting
2046 the truncation glyphs, fill that space with a stretch glyph of a
2047 suitably computed width.
2048
2049 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2050 produce_glyphs, to support GUI sessions.
2051
31571fd7
PE
20522012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2053
5a16b9bc
PE
2054 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2055
f3047c75
PE
2056 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2057
31571fd7
PE
2058 Do not require float-time's arg to fit in time_t (Bug#11825).
2059 This works better on hosts where time_t is unsigned, and where
2060 float-time is applied to the (negative) difference between two times.
2061 * editfns.c (decode_time_components): Last arg is now double *,
2062 not int *, and means to store all the result as a double, without
2063 worrying about whether the seconds part fits in time_t.
2064 All callers changed.
2065 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2066 All callers changed.
2067 (Ffloat_time): Do not fail merely because the specified time falls
2068 outside of time_t range.
2069
4516fbef
GM
20702012-07-07 Glenn Morris <rgm@gnu.org>
2071
2072 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2073 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2074 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2075
07adc2c6
JB
20762012-07-07 Juanma Barranquero <lekktu@gmail.com>
2077
2078 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2079 Update dependencies.
2080
2081 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2082
fd573f31
PE
20832012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2084
fee5959d
PE
2085 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2086 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2087 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2088 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2089 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2090 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2091
fd573f31
PE
2092 * xfont.c (compare_font_names): Redo to omit the need for casts.
2093
ddadbc0e
AS
20942012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2095
fca8d6b6
AS
2096 * xfns.c (Fx_change_window_property): Doc fix.
2097 * w32fns.c (Fx_change_window_property): Doc fix.
2098
ddadbc0e
AS
2099 * w32fns.c (Fx_window_property): Accept the same arguments as the
2100 X Windows version. Doc fix.
2101 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2102
ed9265fc 21032012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2104 Eli Zaretskii <eliz@gnu.org>
2105
2106 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2107 Windows-specific code from nt/config.nt moved here.
2108 Obsolete settings removed.
2109
216ee680
PE
21102012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * process.c: Avoid unnecessary calls to gettime.
2113 (wait_reading_process_output): Don't get the time of day
2114 when gobbling data immediately and not waiting, as there's no need
2115 for it in that case. This removes a FIXME.
2116
bdd091e4
JD
21172012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2118
2119 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2120 is defined (Bug#11768).
2121
9d44f8ce
DA
21222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 Fix marker debugging code.
2125 * marker.c (byte_char_debug_check): Do not perform the check
2126 if buffer is not multibyte.
090bd7cb
JB
2127 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2128 Call byte_char_debug_check with correct arguments.
9d44f8ce 2129
90fc4786
DA
21302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2133 * marker.c (byte_char_debug_check, count_markers):
2134 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2135 (byte_debug_flag): Remove.
2136 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2137 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2138
7b7ae965
DA
21392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2140
4e57b342
DA
2141 Avoid code repetition in marker-related functions.
2142 * marker.c (attach_marker): New function.
2143 (Fset_marker, set_marker_restricted, set_marker_both)
2144 (set_marker_restricted_both): Use it.
2145 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2146 Consistently rename charno to charpos.
2147 (marker_position): Add eassert.
2148 (marker_byte_position): Convert to eassert.
2149
21502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2153 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2154 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2155
657924ff
DA
21562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2157
2158 Introduce fast path for the widely used marker operation.
2159 * alloc.c (build_marker): New function.
2160 * lisp.h (build_marker): New prototype.
2161 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2162 * composite.c (autocmp_chars): Likewise.
2163 * editfns.c (buildmark): Remove.
2164 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2165 (save_restriction_save): Use build_marker.
2166 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2167 * window.c (save_window_save): Likewise.
2168
041a49a6
DA
21692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Do not use Fdelete_overlay in delete_all_overlays
2172 to avoid redundant calls to unchain_overlay.
2173 * buffer.c (drop_overlay): New function.
2174 (delete_all_overlays, Fdelete_overlay): Use it.
2175 * minibuf.c (get_minibuffer): Fix comment.
2176
7dca65a4
PE
21772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 Port to OpenBSD 5.1 amd64.
2180 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2181 This is needed for OpenBSD, and should be harmless on all BSD systems.
2182 Also, include <sys/sysctl.h>, as it should be available on all
2183 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2184 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2185 use p_pid member, not kp_proc.pid.
2186
8eb876e2
GM
21872012-07-06 Glenn Morris <rgm@gnu.org>
2188
2189 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2190
38182d90
PE
21912012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 More xmalloc and related cleanup.
2194 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2195 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2196 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2197 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2198 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2199 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2200 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2201 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2202 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2203 * xterm.c:
2204 Omit needless casts involving void * pointers and allocation.
2205 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2206 as the former is more robust if P's type is changed.
2207 Prefer xzalloc to xmalloc + memset 0.
2208 Simplify malloc-or-realloc to realloc.
2209 Don't worry about xmalloc returning a null pointer.
2210 Prefer xstrdup to xmalloc + strcpy.
2211 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2212 growing it.
2213 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2214 alloca of a constant.
2215
6dd5a677
EZ
22162012-07-05 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2219 hscroll is larger than the line width. Fixes long and futile
2220 looping inside extend_face_to_end_of_line (on a TTY) producing
2221 glyphs that are not needed and thrown away.
2222
6b312f0f
DA
22232012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * marker.c (set_marker_restricted_both): Simplify by using
2226 clip_to_bounds.
2227
f520ef9b
PE
22282012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2231
383b7c95
JD
22322012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2233
2234 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2235 not defined (Bug#11768).
2236 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2237 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2238 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2239 followed by gtk_box_set_homogeneous (Bug#11768).
2240 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2241 (update_theme_scrollbar_width, xg_create_scroll_bar):
2242 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2243 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2244 (is_box_type): New function (Bug#11768).
2245 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2246 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2247 with default display (Bug#11768).
2248
d6e7bf45
EZ
22492012-07-05 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xdisp.c (window_hscroll_limited): New function.
2252 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2253 coordinates when window's hscroll is set to insanely large
2254 values. (Bug#11857)
2255
431391ec
JB
22562012-07-05 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2259 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2260
23f86fce
DA
22612012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 Cleanup xmalloc.
2264 * lisp.h (xzalloc): New prototype. Omit needless casts.
2265 * alloc.c (xzalloc): New function. Omit needless casts.
2266 * charset.c: Omit needless casts. Convert all calls to
2267 xmalloc with following memset to xzalloc.
2268 * dispnew.c: Likewise.
2269 * fringe.c: Likewise.
2270 * image.c: Likewise.
2271 * sound.c: Likewise.
2272 * term.c: Likewise.
2273 * w32fns.c: Likewise.
2274 * w32font.c: Likewise.
2275 * w32term.c: Likewise.
2276 * xfaces.c: Likewise.
2277 * xfns.c: Likewise.
2278 * xterm.c: Likewise.
2279 * atimer.c: Omit needless casts.
2280 * buffer.c: Likewise.
2281 * callproc.c: Likewise.
2282 * ccl.c: Likewise.
2283 * coding.c: Likewise.
2284 * composite.c: Likewise.
2285 * doc.c: Likewise.
2286 * doprnt.c: Likewise.
2287 * editfns.c: Likewise.
2288 * emacs.c: Likewise.
2289 * eval.c: Likewise.
2290 * filelock.c: Likewise.
2291 * fns.c: Likewise.
2292 * gtkutil.c: Likewise.
2293 * keyboard.c: Likewise.
2294 * lisp.h: Likewise.
2295 * lread.c: Likewise.
2296 * minibuf.c: Likewise.
2297 * msdos.c: Likewise.
2298 * print.c: Likewise.
2299 * process.c: Likewise.
2300 * region-cache.c: Likewise.
2301 * search.c: Likewise.
2302 * sysdep.c: Likewise.
2303 * termcap.c: Likewise.
2304 * terminal.c: Likewise.
2305 * tparam.c: Likewise.
2306 * w16select.c: Likewise.
2307 * w32.c: Likewise.
2308 * w32reg.c: Likewise.
2309 * w32select.c: Likewise.
2310 * w32uniscribe.c: Likewise.
2311 * widget.c: Likewise.
2312 * xdisp.c: Likewise.
2313 * xmenu.c: Likewise.
2314 * xrdb.c: Likewise.
2315 * xselect.c: Likewise.
2316
0497dc44
PE
23172012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 * fileio.c (time_error_value): Check the right error number.
2320 Problem reported by Troels Nielsen in
2321 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2322
356e7178
PE
23232012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2324
4e71fd89
PE
2325 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2326 This should be fixed in a better way; see Eli Zaretskii in
2327 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2328 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2329
f0941253
PE
2330 * fileio.c (time_error_value): Rename from special_mtime.
2331 The old name's problems were noted by Eli Zaretskii in
2332 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2333
065c9eb4
PE
2334 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2335 This variable's comment says Emacs needs at least one GDB-visible
2336 symbol of type enum pvec_type, to work around GDB problems.
2337 The symbol's value doesn't matter.
2338
356e7178
PE
2339 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2340 that causes compilation to fail on pre-C99 compilers.
2341
ed9265fc 23422012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2343
2344 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2345 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2346
3884d954
DA
23472012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2348
d209e2fb 2349 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2350 headers for buffer_defaults and buffer_local_symbols.
2351 Reported by Juanma Barranquero <lekktu@gmail.com>.
2352
ee28be33
SM
23532012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2354
2355 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2356 * lisp.h (enum pvec_type): Use fewer bits.
2357 (PSEUDOVECTOR_SIZE_BITS): New constant.
2358 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2359 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2360 change in pvec_type.
2361 (PSEUDOVECTOR_TYPEP): New macro.
2362 (TYPED_PSEUDOVECTORP): Use it.
2363 * fns.c (internal_equal): Adapt code to extract pvectype.
2364 * emacs.c (gdb_pvec_type): Update type.
2365 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2366 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2367 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2368 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2369 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2370 abusing vector->header.next.nbytes.
2371 (live_vector_p): Use PVEC_TYPE.
2372 (mark_object): Adapt code to extract pvectype. Use switch.
2373
c7f2cd7f
PE
23742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2377 Tighten new eassert a bit.
2378
8ce70ed2
DA
23792012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2380
2381 Fix compilation with --enable-gcc-warnings and -O1
2382 optimization level.
2383 * doprnt.c (doprnt): Change type of tem to int, initialize
2384 to avoid compiler warning. Add eassert.
2385 * search.c (simple_search): Initialize match_byte to avoid
2386 compiler warning. Add eassert.
2387
dea7f1e5
PE
23882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2389
24a212eb
PE
2390 Avoid weird behavior with large horizontal scrolls.
2391 Without this change, for example, large hscroll values would
2392 mess up Emacs's display on Fedora 15 x86, presumably due to
2393 overflows in int calculations in the display code.
2394 Also, if buffers had long lines, Emacs would freeze.
2395 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2396 (set_window_hscroll): New function, containing the old guts of
2397 Fset_window_hscroll. Return the clipped value.
2398 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2399 This avoids the need to check against PTRDIFF_MAX.
2400
dea7f1e5
PE
2401 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2402
76046526
DA
24032012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2404
2405 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2406
39adff0d
PE
24072012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2408
63807d47
PE
2409 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2410 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2411 since GCC 4.4.6 issues a bogus warning for them.
2412
39adff0d
PE
2413 Fix bugs in file timestamp newness comparisons.
2414 * fileio.c (Ffile_newer_than_file_p):
2415 * lread.c (Fload): Use full timestamp resolution of files,
2416 not just the 1-second resolution, so that files that are only
2417 slightly newer still count as newer.
2418 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2419 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2420
dbeed9a6
PE
24212012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * fileio.c: Improve handling of file time marker. (Bug#11852)
2424 (special_mtime): New function.
2425 (Finsert_file_contents, Fverify_visited_file_modtime):
2426 Use it to set special mtime values consistently.
2427
636334d6
AS
24282012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2429
2430 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2431 marker for non-existing file. (Bug#11852)
2432
e2017fe2
GM
24332012-07-03 Glenn Morris <rgm@gnu.org>
2434
2435 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2436 and did not make it into globals.h).
2437
404dbd37
TT
24382012-07-03 Tom Tromey <tromey@redhat.com>
2439
2440 * window.c (Fset_window_margins, Fset_window_fringes)
2441 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2442 * textprop.c (Fprevious_property_change): No longer static.
2443 * syntax.c (Fsyntax_table_p): No longer static.
2444 * process.c (Fget_process, Fprocess_datagram_address): No longer
2445 static.
2446 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2447 * keyboard.c (Fcommand_execute): No longer static.
2448 Remove EXFUN.
2449 * insdel.c (Fcombine_after_change_execute): No longer static.
2450 * image.c (Finit_image_library): No longer static.
2451 * fileio.c (Fmake_symbolic_link): No longer static.
2452 * eval.c (Ffetch_bytecode): No longer static.
2453 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2454 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2455 No longer static.
404dbd37
TT
2456 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2457 static.
2458 * dired.c (Ffile_attributes): No longer static.
2459 * composite.c (Fcomposition_get_gstring): No longer static.
2460 * callproc.c (Fgetenv_internal): No longer static.
2461
2462 * ccl.h: Remove EXFUNs.
2463 * buffer.h: Remove EXFUNs.
2464 * dispextern.h: Remove EXFUNs.
2465 * intervals.h: Remove EXFUNs.
2466 * fontset.h: Remove EXFUN.
2467 * font.h: Remove EXFUNs.
2468 * dosfns.c (system_process_attributes): Remove EXFUN.
2469 * keymap.h: Remove EXFUNs.
2470 * lisp.h: Remove EXFUNs.
2471 * w32term.h: Remove EXFUNs.
2472 * window.h: Remove EXFUNs.
2473 * xsettings.h: Remove EXFUN.
2474 * xterm.h: Remove EXFUN.
2475
8e4fd1e1
GM
24762012-07-03 Glenn Morris <rgm@gnu.org>
2477
2478 * lisp.h (Frandom): Make it visible to C.
2479 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2480 buffer for invisible buffers. (Bug#1229)
2481
ca95b3eb
DA
24822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2485 values which aren't power of 2.
2486 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2487 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2488 accordingly.
2489
7555c33f
SM
24902012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2491
2492 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2493
2494 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2495
d12e8f5a
DA
24962012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2497
2498 * alloc.c (allocate_vector_block): Remove redundant
2499 calls to mallopt if DOUG_LEA_MALLOC is defined.
2500 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2501 avoid calls to mallopt if zero_vector is returned.
2502
296094c3
DA
25032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2504
2505 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2506 is enabled, avoid dereferencing NULL current_sblock if
2507 running undumped.
2508
36429c89
DA
25092012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2510
2511 Cleanup basic buffer management.
2512 * buffer.h (struct buffer): Change layout to use generic vector
2513 marking code. Fix some comments. Change type of 'clip_changed'
2514 to bitfield. Remove unused #ifndef old.
2515 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2516 (GET_OVERLAYS_AT): Fix indentation.
2517 (for_each_per_buffer_object_at): New macro.
2518 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2519 (Fbuffer_local_variables): Use it.
2520 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2521 * alloc.c (allocate_buffer): Adjust to match new layout of
2522 struct buffer. Fix comment.
2523 (mark_overlay): New function.
2524 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2525 Lisp area of struct buffer.
2526 (mark_object): Use it. Adjust marking of misc objects
2527 and related comments.
2528
3b3e4cac
PE
25292012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2532 wrapper that is not needed because the wrapped code is a no-op (zero
2533 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2534 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2535
cf5c0175
DA
25362012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2537
2538 * alloc.c (mark_buffer): Simplify. Remove prototype.
2539 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2540 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2541 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2542 redundant calls to mark_vectorlike for bool vectors.
2543
ca26824c
GM
25442012-06-30 Glenn Morris <rgm@gnu.org>
2545
2e4c5312
GM
2546 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2547
ca26824c
GM
2548 * epaths.in (PATH_SITELOADSEARCH): New.
2549 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2550 This is rather than relying on --enable-locallisppath elements
2551 having "site-lisp" in their names. (Bug#10208#25, 11658)
2552
0d23c240
EZ
25532012-06-30 Eli Zaretskii <eliz@gnu.org>
2554
c9240d7a
EZ
2555 * w32proc.c (sys_select): Accept and ignore one more argument.
2556
2557 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2558
0d23c240 2559 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2560 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2561
2562 * sysdep.c: Don't include dos.h and dosfns.h.
2563
2564 * process.c (sys_select):
2565 * msdos.c (sys_select): Accept one more argument and ignore it.
2566
2567 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2568 adapt data types and code to that.
2569
2570 * dosfns.c:
2571 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2572 which clashes with the gnulib function of the same name.
2573
af5a5a98
AS
25742012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2575
c5e4379c
AS
2576 * font.c (font_style_to_value, font_style_symbolic)
2577 (font_prop_validate_style): Add type checks for values in
2578 font_style_table.
2579
af5a5a98
AS
2580 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2581 argument.
2582 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2583 uses.
2584
8d38f461
EZ
25852012-06-29 Eli Zaretskii <eliz@gnu.org>
2586
2e5a6631
EZ
2587 * xdisp.c (try_window_id): Undo last change.
2588
8d38f461
EZ
2589 * w32.c (getwd): Adjust commentary about startup_dir.
2590 (init_environment): Always call sys_access, even in non-MSVC
2591 builds. Don't chdir to the directory of the Emacs executable.
2592 This undoes code from 1997 which was justified by the need to
2593 "avoid conflicts when removing and renaming directories". But its
2594 downside was that every relative file name was being interpreted
2595 relative to the directory of the Emacs executable, which can never
2596 be TRT. In particular, it broke sys_access when called with
2597 relative file names.
2598 (sys_access): Map GetLastError to errno.
2599
2af3565e
DA
26002012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2601
2602 * window.h (struct window): Change type of 'fringes_outside_margins'
2603 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2604 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2605 Adjust comment.
2606 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2607 to ptrdiff_t.
2608
c8d3a25c 26092012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2610
c8d3a25c
GM
2611 * gnutls.c (emacs_gnutls_handshake):
2612 Add QUIT to make the loop interruptible.
57570cd3 2613
c8d3a25c 26142012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2615
c8d3a25c
GM
2616 * charset.c (init_charset): Make lack of etc/charsets fatal.
2617
3e984ee8
DA
26182012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2619
2620 * editfns.c (region_limit): Fix type mismatch.
2621
ef884f23
DA
26222012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2623
2624 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2625 undefined. Convert from xassert to eassert.
2626 * nsmenu.m: Convert from xassert to eassert.
2627 * nsterm.m: Likewise.
2628
7d7e0027
SM
26292012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2630
2631 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2632
aa754e6a
PE
26332012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 Avoid integer overflow on scroll-left and scroll-right.
2636 * window.c (HSCROLL_MAX): New macro.
2637 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2638 overflow when requested scroll falls outside ptrdiff_t range.
2639
80b00b08
DA
26402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2641
2642 * window.h (struct window): Change type of 'hscroll',
2643 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2644 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2645 Adjust users accordingly.
2646 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2647 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2648 from EMACS_INT to ptrdiff_t.
2649 (make_window): Omit redundant initialization.
2650
62b2bcf6
JB
26512012-06-28 Juanma Barranquero <lekktu@gmail.com>
2652
2653 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2654
45942c7d
DA
26552012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2656
2657 * window.h (struct window): Change type of 'use_time' and
2658 'sequence_number' from Lisp_Object to int.
2659 * frame.c (make_frame): Adjust users accordingly.
2660 * print.c (print_object): Likewise.
2661 * window.c (select_window, Fwindow_use_time, make_parent_window)
2662 (make_window): Likewise.
2663
e509cfa6
DA
26642012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2665
2666 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2667 enabled with --enable-checking=[all,glyphs] configure option.
2668 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2669 adjust comments accordingly.
2670 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2671 undefined, adjust comments accordingly.
2672 * image.c: Likewise.
2673 * scroll.c: Likewise.
2674 * w32fns.c: Likewise.
2675 * w32term.c: Likewise.
2676 * xdisp.c: Likewise.
2677 * xfaces.c: Likewise.
2678 * xfns.c: Likewise.
2679 * xterm.c: Likewise.
2680
a54e2c05
DA
26812012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2682
2683 Generalize run-time debugging checks.
2684 * dispextern.h (XASSERTS): Remove.
2685 * fontset.c (xassert): Remove.
2686 Convert from xassert to eassert.
2687 * alloc.c: Convert from xassert to eassert.
2688 * bidi.c: Likewise.
2689 * dispnew.c: Likewise.
2690 * fns.c: Likewise.
2691 * fringe.c: Likewise.
2692 * ftfont.c: Likewise.
2693 * gtkutil.c: Likewise.
2694 * image.c: Likewise.
2695 * keyboard.c: Likewise.
2696 * menu.c: Likewise.
2697 * process.c: Likewise.
2698 * scroll.c: Likewise.
2699 * sound.c: Likewise.
2700 * term.c: Likewise.
2701 * w32console.c: Likewise.
2702 * w32fns.c: Likewise.
2703 * w32term.c: Likewise.
2704 * window.c: Likewise.
2705 * xdisp.c: Likewise.
2706 * xfaces.c: Likewise.
2707 * xfns.c: Likewise.
2708 * xselect.c: Likewise.
2709 * xterm.c: Likewise.
2710
1ec4b7b2
SM
27112012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2712
2713 * fns.c (maybe_resize_hash_table): Output message when growing the
2714 purify-hashtable.
2715
2014308a
DA
27162012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2717
2718 * alloc.c (allocate_string_data): Remove dead code.
2719 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2720 avoid GCC warning about unused macro.
2721
246155eb
DA
27222012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2723
2724 * alloc.c (allocate_string): Omit intervals initialization.
2725 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2726 as in make_pure_string and make_pure_c_string.
2727
43184b7b
DA
27282012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2729
d209e2fb 2730 * alloc.c (allocate_string): Fix last change.
43184b7b 2731
3fe6dd74
DA
27322012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2733
d209e2fb 2734 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2735 to memset, add explicit initialization where appropriate.
2736
1ba6038a
GM
27372012-06-27 Glenn Morris <rgm@gnu.org>
2738
2739 * lisp.mk (lisp): Remove paths.elc.
2740
c89926a5
CY
27412012-06-27 Chong Yidong <cyd@gnu.org>
2742
2743 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2744
ed6b3510
JW
27452012-06-26 John Wiegley <johnw@newartisans.com>
2746
1ec4b7b2 2747 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2748 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2749
ed6b3510
JW
2750 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2751 when building with Clang.
2752
8edd4a2b
SM
27532012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2754
2755 * eval.c (Fapply): Allow calling it with a single argument.
2756
f6f62d1b
EZ
27572012-06-26 Eli Zaretskii <eliz@gnu.org>
2758
2759 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2760 _stricmp and _strnicmp.
2761 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2762
62efea5e
DA
27632012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2764
2765 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2766 allocated window.
2767 (allocate_process): Likewise for new process.
8edd4a2b 2768 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2769 (allocate_frame): Likewise.
2770 * frame.c (make_frame): Omit redundant initialization.
2771 * window.c (make_parent_window): Use memset.
2772 (make_window): Omit redundant initialization.
2773 * process.c (make_process): Omit redundant initialization.
2774 * terminal.c (create_terminal): Likewise.
2775
42997f4d
DA
27762012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2777
2778 * term.c (delete_tty): Remove redundant call to memset.
2779
1130ecfc
DA
27802012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2781
2782 * alloc.c: Remove build_string.
2783 * lisp.h: Define build_string as static inline. This provides
2784 a better opportunity to optimize away calls to strlen when the
2785 function is called with compile-time constant argument.
2786 * image.c (imagemagick_error): Convert to build_string.
2787 * w32proc.c (sys_spawnve): Likewise.
2788 * xterm.c (x_term_init): Likewise.
2789
cf38a720
PE
27902012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2791
99027bdd
PE
2792 Use sprintf return value instead of invoking strlen on result.
2793 In the old days this wasn't portable, since some sprintf
2794 implementations returned char *. But they died out years ago and
2795 Emacs already assumes sprintf returns int.
2796 Similarly for float_to_string.
2797 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2798 * ccl.c (ccl_driver):
2799 * character.c (string_escape_byte8):
2800 * data.c (Fnumber_to_string):
2801 * doprnt.c (doprnt):
2802 * print.c (print_object):
2803 * xdisp.c (message_dolog):
2804 * xfns.c (syms_of_xfns):
2805 Use sprintf or float_to_string result to avoid need to call strlen.
2806 * data.c (Fnumber_to_string):
2807 Use make_unibyte_string, since the string must be ASCII.
2808 * lisp.h, print.c (float_to_string): Now returns int length.
2809 * term.c (produce_glyphless_glyph):
2810 Use sprintf result rather than recomputing it.
2811
cf38a720
PE
2812 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2813 * Makefile.in (ALL_CFLAGS):
2814 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2815 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2816
3511c784
DA
28172012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2818
0a08eb21 2819 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2820 strcasecmp if available.
2821 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2822
fb7da12e
AS
28232012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2824
2825 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2826 Avoid comma operator.
2827 * menu.c (push_submenu_start, push_submenu_end)
2828 (push_left_right_boundary, push_menu_pane): Likewise.
2829 * msdos.c (dos_rawgetc): Likewise.
2830
afa2ffd8
DA
28312012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2832
2833 * xfns.c (xic_create_fontsetname): Remove redundant calls
2834 to memset.
2835
b3b4476b
PE
28362012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2837
4495ff38
PE
2838 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2839 sprintf already null-terminates its output.
2840
b3b4476b
PE
2841 * xfns.c (x_window): Remove redundant cast.
2842
b00876c9
DA
28432012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2844
2845 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2846 `const char *' to `char *' to avoid compiler warning.
2847
d188e26b
PE
28482012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2849
885d1d74
PE
2850 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2851 instead of truncating it to 63 (admittedly a generous limit).
2852
d188e26b
PE
2853 * process.c: Fix spelling and caps in comments.
2854
e2f560b1
DN
28552012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2856
e86db54b 2857 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2858 * sysdep.c (setpgrp): Remove definition, not used in this file.
2859
7583a3a1
JB
28602012-06-24 Juanma Barranquero <lekktu@gmail.com>
2861
2862 * makefile.w32-in: Update dependencies.
2863
696056c2
EZ
28642012-06-24 Eli Zaretskii <eliz@gnu.org>
2865
2866 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2867 (SYSTIME_H): Add nt/inc/sys/time.h.
2868
2869 * systime.h [WINDOWSNT]: Include sys/time.h.
2870
2871 * s/ms-w32.h (struct timespec): Definition moved from
2872 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2873
845ca893
PE
28742012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2877 * buffer.h (buffer_slot_type_mismatch):
2878 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2879 * eval.c (unwind_to_catch):
2880 * image.c (my_png_error, my_error_exit):
2881 * keyboard.c (quit_throw_to_read_char, user_error)
2882 (Fexit_recursive_edit, Fabort_recursive_edit):
2883 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2884 (wrong_type_argument, buffer_overflow, __executable_start)
2885 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2886 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2887 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2888 (fatal):
2889 (child_setup) [!DOS_NT]:
2890 * lread.c (end_of_file_error, invalid_syntax):
2891 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2892 * puresize.h (pure_write_error):
2893 * search.c (matcher_overflow):
2894 * sound.c (sound_perror, alsa_sound_perror):
2895 * sysdep.c, syssignal.h (croak):
2896 * term.c (maybe_fatal, vfatal):
2897 * textprop.c (text_read_only):
2898 * undo.c (user_error):
2899 * unexmacosx.c (unexec_error):
2900 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2901 Use _Noreturn rather than NO_RETURN.
2902 No need for separate decl merely because of _Noreturn.
2903 * sound.c (sound_warning, parse_sound):
2904 Remove unnecessary forward decls.
2905
f1dd8073
PE
29062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2909 * lisp.h (WAIT_READING_MAX): New macro.
2910 * dispnew.c (Fsleep_for, sit_for):
2911 * keyboard.c (kbd_buffer_get_event):
2912 * process.c (Faccept_process_output):
2913 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2914 This improves on the previous patch, which introduced a bug
2915 when time_t is unsigned and as wide as intmax_t.
2916 See <http://bugs.gnu.org/9000#51>.
2917
b82c1755
EZ
29182012-06-23 Eli Zaretskii <eliz@gnu.org>
2919
2920 * dispnew.c (sit_for, Fsleep_for):
2921 * keyboard.c (kbd_buffer_get_event):
2922 * process.c (Faccept_process_output): Avoid compiler warnings when
2923 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2924
ca300656
JB
29252012-06-23 Juanma Barranquero <lekktu@gmail.com>
2926
049ec95b
JB
2927 * makefile.w32-in: Update dependencies.
2928
ca300656
JB
2929 * w32.c (ltime): Add return type and declare static.
2930 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2931
db7b8d06
PE
29322012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2935 Privately reported by Herbert J. Skuhra.
2936 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2937 All uses changed.
2938 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2939 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2940
0bd8297f
EZ
29412012-06-23 Eli Zaretskii <eliz@gnu.org>
2942
96512555
EZ
2943 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2944 last argument of make_unibyte_string.
2945
0bd8297f
EZ
2946 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2947 language ID in the event parameters.
2948
2949 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2950 event.code, not the obscure "character set ID".
2951
63def6b6
CY
29522012-06-23 Chong Yidong <cyd@gnu.org>
2953
2954 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2955
e8a02204
EZ
29562012-06-23 Eli Zaretskii <eliz@gnu.org>
2957
388cdec0
EZ
2958 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2959 * w32.c (fdutimens): New function.
2960
2961 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2962
2963 * s/ms-w32.h (pselect): Redirect to sys_select.
2964
2965 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2966
e8a02204
EZ
2967 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2968 in the logic of incrementing and decrementing the value of
2969 use_relocatable_buffers.
2970
d054f3fb
PE
29712012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2972
2973 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2974 Privately reported by Herbert J. Skuhra.
2975 [__FreeBSD__]: Remove "*/" typo after "#include".
2976 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2977 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2978 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2979 Don't assume EMACS_TIME and struct timeval are the same type.
2980
d35af63c
PE
29812012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 Support higher-resolution time stamps (Bug#9000).
2984 The time stamps are only nanosecond-resolution at the C level,
2985 since that's the best that any real-world system supports now.
2986 But they are picosecond-resolution at the Lisp level, as that's
2987 easy, and leaves room for future OS improvements.
2988
2989 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2990 (LIBES): Use it.
2991
2992 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2993 Don't get current time unless it's needed.
2994
2995 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2996 now provides it if it's absent.
2997 (start_atimer): Port to higher-res time stamps.
2998 Check for time stamp overflow. Don't get current time more
2999 often than is needed.
3000
3001 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3002 Include systime.h, not time.h.
3003 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3004
3005 * dired.c: Include stat-time.h.
3006 (Ffile-attributes): File times now have higher resolution.
3007
3008 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3009 (struct image): Timestamp now has higher resolution.
3010
3011 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3012 has at least microseconds now. All uses removed.
3013 (update_frame, update_single_window, update_window, update_frame_1)
3014 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3015
3016 * editfns.c (time_overflow): Now extern.
3017 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3018 (float-time, Fformat_time_string, Fcurrent_time_string)
3019 (Fcurrent_time_zone): Accept and generate higher-resolution
3020 time stamps.
3021 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3022 (decode_time_components, lisp_seconds_argument): New functions.
3023 (make_time): Now static.
3024 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3025 Report an error if the time is invalid, rather than having the caller
3026 do that.
3027
3028 * fileio.c: Include <stat-time.h>
3029 (Fcopy_file): Copy higher-resolution time stamps.
3030 Prefer to set the time stamp via a file descriptor if that works.
3031 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3032 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3033 (Fvisited_file_modtime, Fset_visited_file_modtime):
3034 Support higher-resolution time stamps.
3035
3036 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3037
3038 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3039
3040 * image.c (prepare_image_for_display, clear_image_cache)
3041 (lookup_image): Port to higer-resolution time stamps.
3042
3043 * keyboard.c (start_polling, bind_polling_period):
3044 Check for time stamp overflow.
3045 (read_char, kbd_buffer_get_event, timer_start_idle)
3046 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3047 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3048 Port to higher-resolution time stamps. Do not assume time_t is signed.
3049 (decode_timer): New function. Timers are now vectors of length 9,
3050 not 8, to accommodate the picosecond component.
3051 (timer_check_2): Use it.
3052
3053 * nsterm.m (select_timeout, timeval_subtract): Remove.
3054 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3055 as they're a bit more accurate and handle overflow better.
3056 (ns_select): Change prototype to be compatible with pselect.
3057 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3058 * nsterm.h (ns_select): Adjust prototype.
3059
3060 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3061 us-resolution time stamps.
3062 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3063
3064 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3065
3066 * lisp.h (time_overflow): New decl.
3067 (wait_reading_process_output): First arg is now intmax_t, not int,
3068 to accommodate larger waits.
3069
3070 * process.h (struct Lisp_Process.read_output_delay):
3071 Now counts nanoseconds, not microseconds.
3072 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3073 EMACS_HAS_USECS.
3074 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3075 (wait_reading_process_output):
3076 Port to ns-resolution time stamps.
3077 (Faccept_process_output, wait_reading_process_output):
3078 Check for time stamp overflow. Do not assume time_t is signed.
3079 (select_wrapper): Remove; we now use pselect.
3080 (Fprocess_attributes): Now generates ns-resolution time stamps.
3081
3082 * sysdep.c: Include utimens.h. Don't include utime.h
3083 or worry about struct utimbuf; gnulib does that for us now.
3084 (gettimeofday): Remove; gnulib provides a substitute.
3085 (make_timeval): New function.
3086 (set_file_times): Now sets ns-resolution time stamps.
3087 New arg FD; all uses changed.
3088 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3089 (system_process_attributes):
3090 Now returns ns-resolution time stamp. All uses changed.
3091 Check for time stamp overflow.
3092
3093 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3094 provides a substitute now.
3095
3096 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3097 since it guarantees struct timespec.
3098 (EMACS_TIME): Now struct timespec, so that we can support
3099 ns-resolution time stamps.
3100 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3101 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3102 (EMACS_USECS): Remove.
3103 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3104 so multiply the arg by 1000 before storing it.
3105 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3106 New macros.
3107 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3108 Port to ns-resolution time stamps.
3109 (EMACS_TIME_NEG_P): Remove; replaced by....
3110 (EMACS_TIME_SIGN): New macro.
3111 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3112 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3113 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3114 (make_timeval, make_lisp_time, decode_time_components): New decls.
3115 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3116 that it mishandled time_t overflow. You can't compare by subtracting!
3117 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3118 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3119
3120 * term.c: Include <sys/time.h>.
3121 (timeval_to_Time): New function, for proper overflow wraparound.
3122 (term_mouse_position, term_mouse_click): Use it.
3123
3124 * undo.c (record_first_change): Support higher-resolution time stamps
3125 in the undo buffer.
3126 (Fprimitive_undo): Use them when restoring time stamps.
3127
3128 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3129 (w32_get_internal_run_time):
3130 Port to higher-resolution Emacs time stamps.
3131 (ltime): Now accepts single 64-bit integer, as that's more convenient
3132 for callers.
3133
3134 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3135
3136 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3137 for compatibility with pselect. Support ns-resolution time stamps.
3138
3139 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3140
3141 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3142 Check for time stamp overflow, and support ns-resolution time stamps.
3143
3144 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3145 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3146 (timeval_subtract): Remove; no longer needed.
3147 (XTflash, XTring_bell, x_wait_for_event):
3148 Port to ns-resolution time stamps. Don't assume time_t is signed.
3149
b6a92dfe
CY
31502012-06-22 Chong Yidong <cyd@gnu.org>
3151
3152 * xdisp.c (x_consider_frame_title): Revert last change.
3153
d251c37c
EZ
31542012-06-22 Eli Zaretskii <eliz@gnu.org>
3155
3156 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3157 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3158 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3159 staticidx goes up to 1597 out of 1600 = 0x640.)
3160
f10deafb
PE
31612012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3162
3163 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3164 Otherwise, the umask might be mistakenly 0 while handling input signals.
3165
ec6de1e2
SM
31662012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3167
3168 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3169
28be1ada
DA
31702012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3171
3172 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3173 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3174 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3175 access to `contents' member of Lisp_Vector objects with AREF and ASET
3176 where appropriate.
3177
c6bf3022
CY
31782012-06-19 Chong Yidong <cyd@gnu.org>
3179
3180 * frame.c (delete_frame): When selecting a frame on a different
3181 text terminal, do not alter the terminal's top-frame.
3182
3183 * xdisp.c (format_mode_line_unwind_data): Record the target
3184 frame's selected window and its terminal's top-frame.
3185 (unwind_format_mode_line): Restore them.
3186 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3187 Callers changed.
3188 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3189 since tty frames can be explicitly named.
3190 (prepare_menu_bars): Likewise.
3191
3192 * term.c (Ftty_top_frame): New function.
3193
defd4196
PE
31942012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 Port byte-code-meter to modern targets.
3197 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3198 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3199 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3200 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3201 (METER_1, METER_2): Simplify.
3202
1053a871
SM
32032012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * data.c (Fdefalias): Return `symbol' (bug#11686).
3206
b7e8d081
MR
32072012-06-18 Martin Rudalics <rudalics@gmx.at>
3208
3209 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3210 gets killed during executing of this function (Bug#11665).
3211 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3212 (Vkill_buffer_query_functions): In doc-string say that functions
3213 run by this hook should not change the current buffer.
3214
7ea2b339
PE
32152012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Fix recently-introduced process.c problems found by static checking.
3218 * process.c (write_queue_push, write_queue_pop, send_process):
3219 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3220 (write_queue_pop): Fix pointer signedness problem.
3221 (send_process): Remove unused local.
3222
96a313a1
CY
32232012-06-17 Chong Yidong <cyd@gnu.org>
3224
3225 * xdisp.c (redisplay_internal): No need to redisplay terminal
3226 frames that are not on top.
3227
20ca2e94
TN
32282012-06-17 Troels Nielsen <bn.troels@gmail.com>
3229
3230 * process.c (make_process): Initialize write_queue.
3231 (write_queue_push, write_queue_pop): New functions.
3232 (send_process): Use them to maintain correct ordering of process
3233 writes (Bug#10815).
3234
9a900ca9
PE
32352012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3236
310fbfa8
PE
3237 * lisp.h (eassert): Assume C89 or later.
3238 This removes the need for CHECK.
3239 (CHECK): Remove. Its comments about always evaluating its
3240 argument were confusing, as 'eassert' typically does not evaluate
3241 its argument.
3242
27bb1ca4
PE
3243 * coding.c (produce_chars): Use ptrdiff_t, not int.
3244
9a900ca9
PE
3245 * xterm.c (x_draw_underwave): Check for integer overflow.
3246 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3247
41b7f8bc 32482012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3249
3250 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3251 referenced (Bug#11583).
3252
9b0e3eba
AA
32532012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3254
3255 Implement wave-style variant of underlining.
3256 * dispextern.h (face_underline_type): New enum.
3257 (face): Add field for underline type.
3258 * nsterm.m (ns_draw_underwave): New function.
3259 (ns_draw_text_decoration): Use it.
3260 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3261 New functions.
3262 (x_draw_glyph_string): Use them.
3263 * xfaces.c (Qline, Qwave): New Lisp objects.
3264 (check_lface_attrs, merge_face_ref)
1053a871
SM
3265 (Finternal_set_lisp_face_attribute, realize_x_face):
3266 Handle wave-style underline face attributes.
9b0e3eba
AA
3267 * xterm.c (x_draw_underwave): New function.
3268 (x_draw_glyph_string): Use it.
3269
0fb52f11
JB
32702012-06-16 Juanma Barranquero <lekktu@gmail.com>
3271
3272 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3273 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3274 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3275 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3276 ($(BLD)/w32select.$(O)): Update dependencies.
3277
e5560ff7
AS
32782012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3279
3280 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3281 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3282 * character.c (_fetch_multibyte_char_p): Remove.
3283 * alloc.c: Include "character.h" before "buffer.h".
3284 * bidi.c: Likewise.
3285 * buffer.c: Likewise.
3286 * bytecode.c: Likewise.
3287 * callint.c: Likewise.
3288 * callproc.c: Likewise.
3289 * casefiddle.c: Likewise.
3290 * casetab.c: Likewise.
3291 * category.c: Likewise.
3292 * cmds.c: Likewise.
3293 * coding.c: Likewise.
3294 * composite.c: Likewise.
3295 * dired.c: Likewise.
3296 * dispnew.c: Likewise.
3297 * doc.c: Likewise.
3298 * dosfns.c: Likewise.
3299 * editfns.c: Likewise.
3300 * emacs.c: Likewise.
3301 * fileio.c: Likewise.
3302 * filelock.c: Likewise.
3303 * font.c: Likewise.
3304 * fontset.c: Likewise.
3305 * fringe.c: Likewise.
3306 * indent.c: Likewise.
3307 * insdel.c: Likewise.
3308 * intervals.c: Likewise.
3309 * keyboard.c: Likewise.
3310 * keymap.c: Likewise.
3311 * lread.c: Likewise.
3312 * macros.c: Likewise.
3313 * marker.c: Likewise.
3314 * minibuf.c: Likewise.
3315 * nsfns.m: Likewise.
3316 * nsmenu.m: Likewise.
3317 * print.c: Likewise.
3318 * process.c: Likewise.
3319 * regex.c: Likewise.
3320 * region-cache.c: Likewise.
3321 * search.c: Likewise.
3322 * syntax.c: Likewise.
3323 * term.c: Likewise.
3324 * textprop.c: Likewise.
3325 * undo.c: Likewise.
3326 * unexsol.c: Likewise.
3327 * w16select.c: Likewise.
3328 * w32fns.c: Likewise.
3329 * w32menu.c: Likewise.
3330 * window.c: Likewise.
3331 * xdisp.c: Likewise.
3332 * xfns.c: Likewise.
3333 * xmenu.c: Likewise.
3334 * xml.c: Likewise.
3335 * xselect.c: Likewise.
3336
2f07e6af
EZ
33372012-06-16 Eli Zaretskii <eliz@gnu.org>
3338
1053a871
SM
3339 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3340 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3341 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3342 row.
3343 (handle_face_prop): Use chunk-relative overlay string index when
3344 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3345 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3346 the rightmost. (Bug#11720)
2f07e6af 3347
29b83cec
AS
33482012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3349
3350 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3351 (CATEGORY_MEMBER): Enforce 1/0 value.
3352 * category.c (_temp_category_set): Remove.
3353
4c5501e9
EZ
33542012-06-16 Eli Zaretskii <eliz@gnu.org>
3355
3356 * window.c (Fdelete_other_windows_internal)
3357 (Fdelete_window_internal): Don't access frame's mouse highlight
3358 info of the initial frame. (Bug#11677)
3359
2b570124
PE
33602012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3361
e93864f9
PE
3362 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3363 Assume USE_2_TAGS_FOR_INTS.
3364 (xreload): Adjust $tagmask width to match recent lisp.h change.
3365
2b570124
PE
3366 Simplify lisp.h in minor ways that should not affect code.
3367 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3368 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3369 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3370 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3371 (INTTYPEBITS): New macro, for clarity.
3372 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3373 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3374 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3375 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3376 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3377
81755f69
JB
33782012-06-13 Juanma Barranquero <lekktu@gmail.com>
3379
3380 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3381
16192a57
GM
33822012-06-13 Glenn Morris <rgm@gnu.org>
3383
3384 * s/bsd-common.h (BSD4_3):
3385 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3386
646b5f55
AS
33872012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3388
3389 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3390 instead of union.
3391 (XLI, XIL): Define.
1053a871
SM
3392 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3393 Use them.
3394 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3395 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3396 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3397 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3398 * frame.c (delete_frame): Remove outdated comment.
3399 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3400 USE_LISP_UNION_TYPE.
3401 (Fw32_unregister_hot_key): Likewise.
3402 (Fw32_toggle_lock_key): Likewise.
3403 * w32menu.c (add_menu_item): Likewise.
3404 (w32_menu_display_help): Use XIL instead of checking
3405 USE_LISP_UNION_TYPE.
3406 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3407 (init_heap): Likewise.
3408 * w32term.c (w32_read_socket): Update comment.
3409
1d3823c9
GM
34102012-06-13 Glenn Morris <rgm@gnu.org>
3411
c62ff706
GM
3412 * s/usg5-4-common.h, src/s/unixware.h:
3413 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3414
1d3823c9
GM
3415 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3416
bfe3e0a2
PE
34172012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3420 * alloc.c (make_number) [!defined make_number]:
3421 Remove, as lisp.h always defines this now.
3422 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3423 (roundup_size): Verify that it is a power of 2.
3424 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3425 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3426 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3427 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3428 USE_LSB_TAG now is always defined to be either 0 or 1.
3429 All uses changed.
3430 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3431 code works fine either way, and efficiency is not a concern here,
3432 as the union type is for debugging, not for production.
3433 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3434 Use an inline function on all platforms when using the union type,
3435 since this is simpler and 'static inline' can be used portably
3436 within Emacs now.
3437 (LISP_INITIALLY_ZERO): New macro.
3438 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3439 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3440
45fa9c0f
GM
34412012-06-12 Glenn Morris <rgm@gnu.org>
3442
b4492cba
GM
3443 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3444
3445 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3446
45fa9c0f
GM
3447 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3448 Move BROKEN_SIGIO to configure.
3449
3450 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3451 Move NO_TERMIO to configure.
3452
0e25d334
CY
34532012-06-12 Chong Yidong <cyd@gnu.org>
3454
3455 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3456 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3457 MagickExportImagePixels is undefined.
3458
43682bb6
PE
34592012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * image.c (imagemagick_load_image): Remove unused label.
3462
a9be7d2b
GM
34632012-06-11 Glenn Morris <rgm@gnu.org>
3464
3465 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3466 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3467 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3468 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3469
3017f87f
SM
34702012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3471
3472 * alloc.c (make_byte_code): New function.
3473 (Fmake_byte_code): Use it. Don't purify here.
3474 * lread.c (read1): Use it as well to avoid extra allocation.
3475
1b9b4cf4
CY
34762012-06-11 Chong Yidong <cyd@gnu.org>
3477
3478 * image.c (imagemagick_load_image): Implement transparency.
3479
95988fcf
AS
34802012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3481
3482 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3483 account for preceding backslashes. (Bug#11663)
3484
cd4eb164
CY
34852012-06-09 Chong Yidong <cyd@gnu.org>
3486
3487 * term.c: Support italics in capable terminals (Bug#9652).
3488 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3489 (turn_on_face): Output using TS_enter_italic_mode if available.
3490 Don't handle unused blinking and alt-charset cases.
3491 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3492 and tty_alt_charset_p cases.
3493 (tty_capable_p, init_tty): Support italics.
3494
3495 * termchar.h (struct tty_display_info): Add field for italics.
3496 Remove unused blink field.
3497
3498 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3499 Handle slant.
3500
3501 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3502 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3503 tty_alt_charset_p. Add tty_italic_p.
3504
ff88beb8
MA
35052012-06-09 Michael Albinus <michael.albinus@gmx.de>
3506
3507 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3508 dbus_type_is_basic if available.
3509 (xd_extract_signed, xd_extract_unsigned): Rename from
3510 extract_signed and extract_unsigned, respectively. Adapt callers.
3511
44286096
CY
35122012-06-09 Chong Yidong <cyd@gnu.org>
3513
1682701f
CY
3514 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3515
44286096
CY
3516 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3517 case (Bug#9752).
3518
d86feb17
PE
35192012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * xdisp.c (vmessage): Treat frame message as multibyte.
3522 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3523 would generate the diagnostic "Making \302\247 buffer-local while
3524 let-bound!".
3525
d5c20fe8
EZ
35262012-06-08 Eli Zaretskii <eliz@gnu.org>
3527
3528 * dispnew.c (showing_window_margins_p): Undo last change, which
3529 was done due to an inadvertent commit.
3530 (adjust_frame_glyphs_for_frame_redisplay): Do call
3531 showing_window_margins_p.
3532
513749ee
SM
35332012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3534
3535 * eval.c (Fmake_var_non_special): New primitive.
3536 (syms_of_eval): Defsubr it.
3537 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3538
d4a8f5c1
JB
35392012-06-08 Juanma Barranquero <lekktu@gmail.com>
3540
3541 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3542 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3543
8bbbc977
EZ
35442012-06-08 Eli Zaretskii <eliz@gnu.org>
3545
3546 * alloc.c (allocate_vectorlike): Fix last change.
3547
f3372c87
DA
35482012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3549
3550 Block-based vector allocation of small vectors.
3551 * lisp.h (struct vectorlike_header): New field `nbytes',
3552 adjust comment accordingly.
3553 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3554 to denote vector blocks. Adjust users (live_vector_p,
3555 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3556 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3557 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3558 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3559 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3560 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3561 (roundup_size): New constant.
3562 (struct vector_block): New data type.
3563 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3564 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3565 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3566 (sweep_vectors): New functions.
3567 (allocate_vectorlike): Return `zero_vector' as the only vector of
3568 0 items. Allocate new vector from block if vector size is less than
3569 or equal to VBLOCK_BYTES_MAX.
3570 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3571 (init_alloc_once): Add call to init_vectors.
3572
4f18a4ed
SM
35732012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3576
86f158bc
PE
35772012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * doprnt.c (doprnt): Truncate multibyte char correctly.
3580 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3581 would mishandle a string argument "Xc" if X was a multibyte
3582 character of length 2: it would truncate after X's first byte
3583 rather than including all of X.
3584
c5cfcbe0
CY
35852012-06-06 Chong Yidong <cyd@gnu.org>
3586
3587 * buffer.c (word_wrap): Doc fix.
3588
c05cf390
PE
35892012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3592
0c3461de
GM
35932012-06-03 Glenn Morris <rgm@gnu.org>
3594
3595 * xdisp.c (tool-bar-style): Doc fix.
3596
c71232db
UM
35972012-06-03 Ulrich Müller <ulm@gentoo.org>
3598
3599 * Makefile.in (PAXCTL): Define.
3600 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3601 binary via PaX flags if the paxctl utility is available.
3602 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3603 Restore PaX flags to their default. (Bug#11398)
3604
383f7350
CY
36052012-06-03 Chong Yidong <cyd@gnu.org>
3606
3607 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3608 buffer (Bug#11226).
3609
5f2c76c6
CY
36102012-06-03 Chong Yidong <cyd@gnu.org>
3611
3612 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3613 (note_mode_line_or_margin_highlight): If there is no help echo,
3614 use mode-line-default-help-echo. Handle the case where the mouse
3615 position is past the end of the mode line string.
3616
3617 * buffer.c (buffer_local_value_1): New function, split from
3618 Fbuffer_local_value; can return Qunbound.
3619 (Fbuffer_local_value): Use it.
3620 (Vmode_line_format): Docstring tweaks.
3621
773d47f6
PE
36222012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * sysdep.c (system_process_attributes): Improve comment.
3625
f2d6a3df
SM
36262012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * keyboard.c: Export real-this-command to Elisp.
3629 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3630 and DEFVAR it. Update all users.
3631
63810350
PE
36322012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3633
7bd5c1f4
PE
3634 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3635
63810350
PE
3636 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3637 Convert pctcpu and pctmem to Lisp float properly.
3638 Let the compiler fold better, as 100.0/0x8000 is exact.
3639
a2821611
AS
36402012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3641
3642 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3643 cons_block.
3644
5fceba1d
PE
36452012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3648
c98ff5dd
DA
36492012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3650
3651 For a 'struct window', replace some Lisp_Object fields to
3652 bitfields where appropriate, remove unused fields.
3653 * window.h (struct window): Remove unused 'last_mark_x' and
3654 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3655 change it's type from Lisp_Object to bitfield.
3656 Change type of 'force_start', 'optional_new_start',
3657 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3658 fields from Lisp_Object to bitfield. Adjust users accordingly.
3659
ca34e0be
PE
36602012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3661
3662 Pacify gcc -Wdouble-precision when using Xaw.
3663 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3664 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3665 Use 'float' consistently, rather than 'float' in most places
3666 and 'double' in a couple of places.
3667
efc00ab1 36682012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3669
3670 * xdisp.c (handle_stop): Detect whether we have overlay strings
3671 loaded by testing it->current.overlay_string_index to be
3672 non-negative, instead of checking whether n_overlay_strings is
3673 positive. (Bug#11587)
3674
efc00ab1 36752012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3676
3677 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3678
3679 * doc.c (Fsubstitute_command_keys): Doc fix.
3680
efc00ab1 36812012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3682
3683 * search.c (search_buffer): Remove calls to
3684 r_alloc_inhibit_buffer_relocation, as it is now called by
3685 maybe_unify_char, which was the cause of relocation of buffer text
3686 in bug#11519.
3687
efc00ab1 36882012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3689
3690 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3691 for the duration of call to load_charset, to avoid problems with
3692 callers of maybe_unify_char that access buffer text through C
3693 pointers.
3694
3695 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3696 decrement the inhibition flag, instead of just setting or
3697 resetting it.
3698
ba93a187
PE
36992012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 Remove obsolete '#define static' cruft.
3702 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3703 This #undef was "temporary" in 2000; it is no longer needed
3704 now that '#define static' has gone away.
3705 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3706 (gray_bitmap_bits): Remove; no longer needed.
3707 All uses replaced with definiens.
3708 * xterm.c: Include "bitmaps/gray.xbm".
3709
9e4bf381
PE
37102012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 Clean up __executable_start, monstartup when --enable-profiling.
3713 The following changes affect the code only when profiling.
3714 * dispnew.c (__executable_start): Rename from safe_bcopy.
3715 Define only on platforms that need it.
3716 * emacs.c: Include <sys/gmon.h> when profiling.
3717 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3718 (__executable_start): Remove decl, since lisp.h does it now.
3719 (safe_bcopy): Remove decl; no longer has that name.
3720 (main): Coalesce #if into single bit of code, for simplicity.
3721 Cast pointers to uintptr_t, since standard libraries want integers
3722 and not pointers.
3723 * lisp.h (__executable_start): New decl.
3724
32d72c2f
GM
37252012-05-31 Glenn Morris <rgm@gnu.org>
3726
3727 * image.c (Fimagemagick_types): Doc fix.
3728
baac5bc7
JM
37292012-05-30 Jim Meyering <meyering@redhat.com>
3730
3731 * callproc.c (Fcall_process_region): Include directory component
3732 in mkstemp error message (Bug#11586).
3733
72cb32cf
PE
37342012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3735
3736 * alloc.c, lisp.h (make_pure_vector): Now static.
3737
61b108cc
SM
37382012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3739
3740 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3741 Move to byte-run.el.
3742 (Fautoload): Do the hash-doc more carefully.
3743 * data.c (Fdefalias): Purify definition, except for keymaps.
3744 (Qdefun): Move from eval.c.
3745 * lisp.h (Qdefun): Remove.
3746 * lread.c (read1): Tiny simplification.
3747
471fe23d
TN
37482012-05-29 Troels Nielsen <bn.troels@gmail.com>
3749
934f3f58 3750 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3751 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3752 Bug#9642, but explicitly check that the buffer the overlay would
3753 be moved to is live and rearrange lines to make sure that errors
3754 will not put the overlay in an inconsistent state.
3755 (Fdelete_overlay): Cosmetics.
3756
85d0efd1
EZ
37572012-05-28 Eli Zaretskii <eliz@gnu.org>
3758
3759 * w32term.c (my_bring_window_to_top): New function.
3760 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3761 could be different from the original one.
3762 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3763 (Bug#11513)
3764
3765 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3766 by calling BringWindowToTop.
3767
3768 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3769 (WM_EMACS_END): Increase by one.
3770
da92a98c
PE
37712012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3772
3773 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3774 This avoids undefined behavior that might cause the eassert
3775 to not catch an out-of-range value.
3776
74d1f848
JB
37772012-05-28 Juanma Barranquero <lekktu@gmail.com>
3778
3779 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3780 Update dependencies.
3781
9e1a06fc
EZ
37822012-05-27 Eli Zaretskii <eliz@gnu.org>
3783
3784 * bidi.c (bidi_mirror_char): Fix last change.
3785
f3dd7312
AS
37862012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3789 when referring to sectname field in printf format.
3790
81899c91
PE
37912012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3792
57b81a9f
PE
3793 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3794 Only r_alloc_inhibit_buffer_relocation needed to be added;
3795 the others were already declared.
3796
81899c91
PE
3797 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3798 before checking whether it's out of range. Put the check inside
3799 eassert. See
3800 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3801
33017faf 38022012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3803
3804 * callproc.c (Fcall_process): Restore a line that was accidentally
3805 commented out in the 2011-02-13 change (bug#11547).
3806
33017faf 38072012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3808
3809 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3810 defined on ralloc.c.
3811
3812 * buffer.c [REL_ALLOC]: Remove prototypes of
3813 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3814 they are now on lisp.h.
3815
3816 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3817
3818 * search.c (search_buffer): Use it to inhibit relocation of buffer
3819 text while re_search_2 is doing its job, because re_search_2 is
3820 passed C pointers to buffer text. (Bug#11519)
3821
23415acf
EZ
3822 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3823 Update value to 24.
3824
44e27368
EZ
3825 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3826 state after an additional call to move_it_in_display_line_to, keep
3827 the values of it->max_ascent and it->max_descent found for the
3828 entire line.
3829 (pos_visible_p): Revert the comparison against bottom_y to what it
3830 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3831 (Bug#11464)
3832
c1892f11
PE
38332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Fix coding-related core dumps with gcc -ftrapv.
3836 The code was computing A - B, where A and B are pointers, and B is
3837 random garbage. This can lead to core dumps on platforms that
3838 have special pointer registers, and it also leads to core dumps on
3839 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3840 A - B only when B is initialized properly.
3841 * coding.c (coding_set_source, coding_set_destination): Return void.
3842 (coding_change_source, coding_change_destinations): New functions,
3843 with the old behaviors of coding_set_source and coding_set_destination.
3844 All callers that need an offset changed to use these new functions.
3845
eb7afdad
GM
38462012-05-26 Glenn Morris <rgm@gnu.org>
3847
3848 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3849
f12fdf02
EZ
38502012-05-26 Eli Zaretskii <eliz@gnu.org>
3851
53a63be6 3852 Extend mouse support on W32 text-mode console.
61b108cc
SM
3853 * xdisp.c (draw_row_with_mouse_face):
3854 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3855
eb3f6f01 3856 * w32console.c: Include window.h.
61b108cc
SM
3857 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3858 New functions.
eb3f6f01
EZ
3859 (initialize_w32_display): Initialize mouse-highlight data.
3860
53a63be6
EZ
3861 * w32inevt.c: Include termchar.h and window.h.
3862 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3863 moves, call note_mouse_highlight. If help_echo changed, call
3864 gen_help_event to produce help-echo message in the echo area.
3865 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3866 highlight info.
3867
4cfd81f6
PE
38682012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * lread.c (read1): Simplify slightly to avoid an overflow warning
3871 with GCC 4.7.0 on x86-64.
3872
4446092a
EZ
38732012-05-26 Eli Zaretskii <eliz@gnu.org>
3874
3875 * bidi.c (bidi_mirror_char): Revert last change: an int is
3876 definitely wide enough here.
3877
42b2a986 38782012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3879
42b2a986 3880 Fix integer width and related bugs (Bug#9874).
eb106a49 3881 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3882 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3883 (string_bytes, check_sblock, allocate_string_data):
3884 (compact_small_strings, Fmake_bool_vector, make_string)
3885 (make_unibyte_string, make_multibyte_string)
3886 (make_string_from_bytes, make_specified_string)
3887 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3888 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3889 (mark_vectorlike):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (allocate_pseudovector):
3892 Use int, not EMACS_INT, where int is wide enough.
3893 (inhibit_garbage_collection, Fgarbage_collect):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3896 int might not be wide enough.
3897 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3898 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3899 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3900 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3901 (bidi_level_of_next_char, bidi_move_to_visually_next):
3902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3903 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3904 (Fkill_buffer, Fset_buffer_major_mode)
3905 (advance_to_char_boundary, Fbuffer_swap_text)
3906 (Fset_buffer_multibyte, overlays_at, overlays_in)
3907 (overlay_touches_p, struct sortvec, record_overlay_string)
3908 (overlay_strings, recenter_overlay_lists)
3909 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3910 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3911 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3912 (Foverlay_recenter, last_overlay_modification_hooks_used)
3913 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3915 (validate_region): Omit unnecessary test for b <= e,
3916 since that's guaranteed by the previous test.
d311d28c
PE
3917 (adjust_overlays_for_delete): Avoid pos + length overflow.
3918 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3919 (report_overlay_modification):
3920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3921 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3922 Omit pointer cast, which isn't needed anyway, and doesn't work
3923 after the EMACS_INT -> ptrdiff_t change.
02481186 3924 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3925 * buffer.h: Adjust decls to match defn changes elsewhere.
3926 (struct buffer_text, struct buffer):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3929 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3930 not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (exec_byte_code): Use tighter memory-full test, one that checks
3932 for alloca overflow. Don't compute the address of the object just
3933 before an array, as that's not portable. Use EMACS_INT, not
3934 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3935 * callint.c (Fcall_interactively):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 * callproc.c (call_process_kill, Fcall_process):
3938 Don't assume pid_t fits into an Emacs fixnum.
3939 (call_process_cleanup, Fcall_process, child_setup):
3940 Don't assume pid_t fits into int.
3941 (call_process_cleanup, Fcall_process, delete_temp_file)
3942 (Fcall_process_region):
3943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3944 (Fcall_process): Simplify handling of volatile integers.
3945 Use int, not EMACS_INT, where int will do.
3946 * casefiddle.c (casify_object, casify_region, operate_on_word)
3947 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3949 (casify_object): Avoid integer overflow when overallocating buffer.
3950 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3951 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3952 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3953 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3954 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3955 integers are now checked earlier. All uses replaced with XINT.
3956 (ccl_driver):
3957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3958 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3959 (ccl_driver, Fregister_code_conversion_map):
3960 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3961 (resolve_symbol_ccl_program): Check that vector header is in range.
3962 Always copy the vector, so that we can check its contents reliably
3963 now rather than having to recheck each instruction as it's being
3964 executed. Check that vector words fit in 'int'.
3965 (ccl_get_compiled_code, Fregister_ccl_program)
3966 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3967 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3968 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3969 contents are in range.
3970 (Fccl_execute_on_string): Check that status is in range.
3971 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3972 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3973 Accept and return EMACS_INT, not int, because callers can pass values
3974 out of 'int' range.
3975 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3976 (multibyte_chars_in_text, parse_str_as_multibyte)
3977 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3978 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3979 (string_escape_byte8, Fget_byte):
3980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3981 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3982 avoid mishandling large integers.
3983 * character.h: Adjust decls to match defn changes elsewhere.
3984 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3985 (Ffind_charset_region):
3986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3987 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3988 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3989 Don't assume fixnum fits in int.
d311d28c
PE
3990 (load_charset_map_from_vector, Fmap_charset_chars):
3991 Remove now-unnecessary CHECK_NATNUMs.
3992 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3993 Don't rely on undefined behavior with signed left shift overflow.
3994 Don't assume unsigned int fits into fixnum, or that fixnum fits
3995 into unsigned int. Don't require max_code to be a valid fixnum;
3996 that's not true for gb10830 4-byte on a 32-bit host. Allow
3997 invalid_code to be a cons, for the same reason. Require code_offset
3998 to be a character. Avoid int overflow if max_char is close
3999 to INT_MAX.
4000 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4001 this is intended anyway and avoids some undefined behavior.
4002 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4003 INDEX_TO_CODE_POINT, as that's what it expects.
4004 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4005 * charset.h (DECODE_CHAR): Return int, not unsigned;
4006 this is what was intended anyway, and it avoids undefined behavior.
4007 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4008 integer-overflow issues.
4009 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4010 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4011 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4012 * chartab.c (Fmake_char_table, Fset_char_table_range)
4013 (uniprop_get_decoder, uniprop_get_encoder):
4014 Don't assume fixnum fits in int.
4015 * cmds.c (move_point): New function, that does the gist of
4016 Fforward_char and Fbackward_char, but does so while checking
4017 for integer overflow more accurately.
c96e5d6a 4018 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4019 (Fforward_line, Fend_of_line, internal_self_insert)
4020 (internal_self_insert):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4022 Fix a FIXME, by checking for integer overflow when calculating
4023 target_clm and actual_clm.
4024 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4025 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4026 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4027 (coding_alloc_by_making_gap, alloc_destination)
4028 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4029 (encode_coding_utf_16, detect_coding_emacs_mule)
4030 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4031 (detect_coding_iso_2022, decode_coding_iso_2022)
4032 (encode_invocation_designation, encode_designation_at_bol)
4033 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4034 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4035 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4036 (encode_coding_ccl, encode_coding_raw_text)
4037 (detect_coding_charset, decode_coding_charset)
4038 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4039 (produce_composition, produce_charset, produce_annotation)
4040 (decode_coding, handle_composition_annotation)
4041 (handle_charset_annotation, consume_chars, decode_coding_gap)
4042 (decode_coding_object, encode_coding_object, detect_coding_system)
4043 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4044 (code_convert_region, code_convert_string)
8f50130c
PE
4045 (Fdefine_coding_system_internal)
4046 (coding_set_source, coding_set_destination):
d311d28c
PE
4047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4048 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4049 (Fdefine_coding_system_internal):
4050 Don't assume fixnums fit in int.
4051 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4052 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4053 (Funencodable_char_position, Fcheck_coding_systems_region)
4054 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4056 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4057 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4058 Don't access memory outside of the args array.
d311d28c 4059 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4060 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4061 result of ENCODE_CHAR.
d311d28c
PE
4062 * coding.h: Adjust decls to match defn changes elsewhere.
4063 (struct coding_system):
4064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4065 * composite.c (get_composition_id, find_composition)
4066 (run_composition_function, update_compositions)
4067 (compose_text, composition_gstring_put_cache)
4068 (composition_gstring_p, composition_gstring_width)
4069 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4070 (composition_compute_stop_pos, composition_reseat_it)
4071 (composition_update_it, struct position_record)
4072 (find_automatic_composition, composition_adjust_point)
4073 (Fcomposition_get_gstring, Ffind_composition_internal):
4074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4075 (update_compositions):
4076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4077 * composite.h: Adjust decls to match defn changes elsewhere.
4078 (struct composition):
4079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4080 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4081 Do not attempt to compute the address of the object just before a
4082 buffer; this is not portable.
4083 (Faref, Faset):
4084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4085 (Faset): Use int, not EMACS_INT, where int is wide enough.
4086 (Fstring_to_number): Don't assume fixnums fit in int.
4087 (Frem): Don't assume arg is nonnegative.
4088 * dbusbind.c (xd_append_arg): Check for integers out of range.
4089 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4090 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4091 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4092 (xd_get_connection_references): Return ptrdiff_t, not int.
4093 All uses changed.
4094 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4095 (xd_read_message_1):
4096 Use int, not unsigned, where the dbus API uses int.
4097 (Fdbus_message_internal): Don't overflow mtype.
4098 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4099 * dired.c (directory_files_internal, file_name_completion, scmp)
4100 (file_name_completion_stat):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 (file_name_completion): Don't overflow matchcount.
4103 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4104 * dispextern.h: Adjust decls to match defn changes elsewhere.
4105 (struct text_pos, struct glyph, struct bidi_saved_info)
4106 (struct bidi_string_data, struct bidi_it, struct composition_it)
4107 (struct it):
4108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4109 (struct display_pos, struct composition_it, struct it):
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 * dispnew.c (increment_matrix_positions)
4112 (increment_row_positions, mode_line_string)
4113 (marginal_area_string):
4114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4115 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4117 (duration_to_sec_usec): New function, to check for overflow better.
4118 (Fsleep_for, sit_for): Use it.
4119 * doc.c (get_doc_string, store_function_docstring):
4120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4121 (get_doc_string, Fsnarf_documentation):
4122 Use int, not EMACS_INT, where int is wide enough.
4123 (get_doc_string):
4124 Use SAFE_ALLOCA, not alloca.
4125 Check for overflow when converting EMACS_INT to off_t.
4126 * doprnt.c (doprnt):
4127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4128 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4129 Don't assume uid_t fits into fixnum.
4130 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4131 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4132 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4133 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4134 (general_insert_function)
4135 (Finsert_char, make_buffer_string, make_buffer_string_both)
4136 (update_buffer_properties, Fbuffer_substring)
4137 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4138 (Fsubst_char_in_region, check_translation)
4139 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4140 (transpose_markers, Ftranspose_regions):
4141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4142 (clip_to_bounds): Move to lisp.h as an inline function).
4143 (Fconstrain_to_field): Don't assume integers are nonnegative.
4144 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4145 (Fsubst_char_in_region, Fsave_restriction):
4146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4147 (Femacs_pid): Don't assume pid_t fits into fixnum.
4148 (lo_time): Use int, not EMACS_INT, when int suffices.
4149 (lisp_time_argument): Check for usec out of range.
4150 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4151 (Fuser_login_name, Fuser_full_name): Signal an error
4152 if a uid argument is out of range, rather than relying on
4153 undefined behavior.
c8d5c857
PE
4154 (Fformat_time_string): Remove now-unnecessary check.
4155 lisp_time_argument checks for out-of-range usec now.
243e0530 4156 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4157 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4158 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4159 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4160 (init_cmdargs, Fdump_emacs):
4161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4162 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4163 the bottom (typically) 32 bits of the fixnum.
4164 * eval.c (specpdl_size, call_debugger):
4165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4166 (when_entered_debugger, Fbacktrace_debug):
4167 Don't assume fixnum can fit in int.
4168 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4169 the object just before a buffer; this is not portable.
4170 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4171 (grow_specpdl, unbind_to):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4174 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4175 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4176 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4177 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4179 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4180 (a_write, e_write):
4181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4182 (Fcopy_file, non_regular_nbytes, read_non_regular)
4183 (Finsert_file_contents):
4184 Use int, not EMACS_INT, where int is wide enough.
4185 (READ_BUF_SIZE): Verify that it fits in int.
4186 (Finsert_file_contents): Check that counts are in proper range,
4187 rather than assuming fixnums fit into ptrdiff_t etc.
4188 Don't assume fixnums fit into int.
125b3835 4189 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4190 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4191 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4192 (string_char_to_byte, string_byte_to_char)
4193 (string_make_multibyte, string_to_multibyte)
4194 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4195 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4196 (substring_both, Fdelete, internal_equal, Ffillarray)
4197 (Fclear_string, mapcar1)
4198 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4199 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4200 (larger_vector, make_hash_table, maybe_resize_hash_table)
4201 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4202 (Fmaphash, secure_hash):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 (concat): Check for string index and length overflow.
4205 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4206 (Frequire):
4207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4208 (larger_vector): New API (vec, incr_min, size_max) replaces old
4209 one (vec, new_size, init). This catches size overflow.
4210 INIT was removed because it was always Qnil.
4211 All callers changed.
4212 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4213 the upper bound on a hash table index size.
4214 (make_hash_table, maybe_resize_hash_table): Use it.
4215 (secure_hash): Computer start_byte and end_byte only after
4216 they're known to be in ptrdiff_t range.
4217 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4218 (Ffont_get_glyphs, Ffont_at):
4219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4220 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4221 (Flist_fonts, Fopen_font):
4222 Don't assume fixnum can fit in int.
4223 (check_gstring): Don't assume index can fit in int.
4224 (font_match_p): Check that fixnum is a character, not a nonnegative
4225 fixnum, since the later code needs to stuff it into an int.
4226 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4227 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4228 conversion overflow issues.
4229 (Fopen_font): Check for integer out of range.
4230 (Ffont_get_glyphs): Don't assume index can fit in int.
4231 * font.h: Adjust decls to match defn changes elsewhere.
4232 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4233 integer overflow.
4234 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4235 printmax_t, where ptrdiff_t is wide enough.
4236 (Finternal_char_font):
4237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4238 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4239 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4240 (Fset_frame_position, x_set_frame_parameters)
4241 (x_set_line_spacing, x_set_border_width)
4242 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4243 Check that fixnums are in proper range for system types.
4244 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4246 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4247 Use SAFE_ALLOCA_LISP, not alloca.
4248 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4249 intptr_t is wide enough.
4250 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4251 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4252 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4253 Check for fixnum out of range.
4254 * ftfont.c (ftfont_list): Don't assume index fits in int.
4255 Check that fixnums are in proper range for system types.
4256 (ftfont_shape_by_flt):
4257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4258 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4260 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4261 Check that fixnums are in proper range for system types.
4262 * gnutls.h: Adjust decls to match defn changes elsewhere.
4263 * gtkutil.c (xg_dialog_run):
4264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4265 (update_frame_tool_bar):
4266 Check that fixnums are in proper range for system types.
4267 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4268 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4269 * indent.c (last_known_column, last_known_column_point):
4270 (current_column_bol_cache):
4271 (skip_invisible, current_column, check_display_width):
4272 (check_display_width, scan_for_column, current_column_1)
4273 (Findent_to, Fcurrent_indentation, position_indentation)
4274 (indented_beyond_p, Fmove_to_column, compute_motion):
4275 (Fcompute_motion, Fvertical_motion):
4276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4277 (last_known_column_modified): Use EMACS_INT, not int.
4278 (check_display_width):
4279 (Fcompute_motion):
4280 Check that fixnums and floats are in proper range for system types.
4281 (compute_motion): Don't assume index or fixnum fits in int.
4282 (compute_motion, Fcompute_motion):
4283 Use int, not EMACS_INT, when it is wide enough.
4284 (vmotion): Omit local var start_hpos that is always 0; that way
4285 we don't need to worry about overflow in expressions involving it.
4286 * indent.h: Adjust decls to match defn changes elsewhere.
4287 (struct position):
4288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4289 Use int, not EMACS_INT, where int is wide enough.
4290 Remove unused members ovstring_chars_done and tab_offset;
4291 all uses removed.
4292 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4293 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4294 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4295 (make_gap, copy_text, insert, insert_and_inherit)
4296 (insert_before_markers, insert_before_markers_and_inherit)
4297 (insert_1, count_combining_before, count_combining_after)
4298 (insert_1_both, insert_from_string)
4299 (insert_from_string_before_markers, insert_from_string_1)
4300 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4301 (adjust_after_replace, adjust_after_insert, replace_range)
4302 (replace_range_2, del_range, del_range_1, del_range_byte)
4303 (del_range_both, del_range_2, modify_region)
4304 (prepare_to_modify_buffer, signal_before_change)
4305 (signal_after_change, Fcombine_after_change_execute):
4306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4307 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4308 (balance_an_interval, split_interval_right, split_interval_left)
4309 (find_interval, next_interval, update_interval)
4310 (adjust_intervals_for_insertion, delete_node, delete_interval)
4311 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4312 (static_offset_intervals, offset_intervals)
4313 (merge_interval_right, merge_interval_left, make_new_interval)
4314 (graft_intervals_into_buffer, temp_set_point_both)
4315 (temp_set_point, set_point, adjust_for_invis_intang)
4316 (set_point_both, move_if_not_intangible, get_property_and_range)
4317 (get_local_map, copy_intervals, copy_intervals_to_string)
4318 (compare_string_intervals, set_intervals_multibyte_1):
4319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4320 * intervals.h: Adjust decls to match defn changes elsewhere.
4321 (struct interval):
4322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4323 * keyboard.c (this_command_key_count, this_single_command_key_start)
4324 (before_command_key_count, before_command_echo_length, echo_now)
4325 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4326 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4327 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4328 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4330 (last_non_minibuf_size, last_point_position, echo_truncate)
4331 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4332 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4333 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4334 (stuff_buffered_input):
4335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4336 (last_auto_save, command_loop_1, read_char):
4337 Use EMACS_INT, not int, to avoid integer overflow.
4338 (record_char): Avoid overflow in total_keys computation.
4339 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4340 * keyboard.h: Adjust decls to match defn changes elsewhere.
4341 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4342 (Fkey_description, Fdescribe_vector, Flookup_key):
4343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4344 (click_position): New function, to check that positions are in range.
4345 (Fcurrent_active_maps):
4346 (describe_command):
4347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4348 (Faccessible_keymaps, Fkey_description):
4349 (preferred_sequence_p):
4350 Don't assume fixnum can fit into int.
4351 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4352 Check for integer overflow in size calculations.
4353 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4354 avoid mishandling large integers.
4355 * lisp.h: Adjust decls to match defn changes elsewhere.
4356 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4357 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4358 (struct Lisp_Marker):
4359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4360 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4361 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4362 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4363 All callers changed.
4364 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4365 Assume the arg has valid form, since it always does.
4366 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4367 unsigned integer system type.
4368 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4369 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4371 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4372 (duration_to_sec_usec): New decl.
4373 * lread.c (read_from_string_index, read_from_string_index_byte)
4374 (read_from_string_limit, readchar, unreadchar, openp)
4375 (read_internal_start, read1, oblookup):
4376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4377 (Fload, readevalloop, Feval_buffer, Feval_region):
4378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4379 (openp): Check for out-of-range argument to 'access'.
4380 (read1): Use int, not EMACS_INT, where int is wide enough.
4381 Don't assume fixnum fits into int.
6efdadfd 4382 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4383 (read_filtered_event): Use duration_to_sec_usec
4384 to do proper overflow checking on durations.
d311d28c
PE
4385 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4386 in size calculation.
4387 (Fexecute_kbd_macro):
4388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4389 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4390 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4391 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4392 (set_marker_both, set_marker_restricted_both, marker_position)
4393 (marker_byte_position, Fbuffer_has_markers_at):
4394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4395 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4396 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4397 It now merely ensures that the menu is large enough, without
4398 necessarily growing it, as this avoids some integer overflow issues.
4399 All callers changed.
4400 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4402 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4403 Use SAFE_ALLOCA_LISP, not alloca.
4404 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4405 to EMACS_INT. Check that fixnums are in proper range for system types.
4406 * minibuf.c (minibuf_prompt_width, string_to_object)
4407 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4408 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4410 (get_minibuffer, read_minibuf_unwind):
4411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4412 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4413 this simplifies overflow checking. All callers changed.
4414 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4415 (Ftest_completion):
4416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4417 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4418 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4419 Check that fixnums are in proper range for system types.
4420 (Fx_create_frame, Fx_show_tip):
4421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4422 * nsfont.m (ns_findfonts, nsfont_list_family):
4423 Don't assume fixnum fits in long.
4424 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4426 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4427 wide enough.
17fdb222 4428 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4430 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4431 (PRINTDECLARE, PRINTPREPARE):
4432 (strout, print_string):
4433 (print, print_preprocess, print_check_string_charset_prop)
4434 (print_object):
4435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4436 (PRINTDECLARE):
4437 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4439 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4440 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4441 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4442 (print_error_message): Use SAFE_ALLOCA, not alloca.
4443 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4444 (print_depth, new_backquote_output, print_number_index):
4445 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4446 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4447 (Fset_process_window_size, Fformat_network_address)
4448 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4449 (sigchld_handler):
d311d28c 4450 Check that fixnums are in proper range for system types.
d44287d4 4451 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4452 Check for process-ids out of pid_t range rather than relying on
4453 undefined behavior.
e4d81efc 4454 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4455 (Fformat_network_address, read_process_output, send_process)
4456 (Fprocess_send_region, status_notify):
4457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4458 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4459 (wait_reading_process_output, read_process_output, exec_sentinel):
4460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4461 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4462 (Faccept_process_output): Use duration_to_sec_usec to do proper
4463 overflow checking on durations.
dde14581
PE
4464 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4465 Don't assume pid_t fits in int.
02481186
PE
4466 * process.h (struct Lisp_Process): Members tick and update_tick
4467 are now of type EMACS_INT, not int.
b62b53e8
PE
4468 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4469 configured --with-wide-int.
d311d28c
PE
4470 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4471 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4472 * search.c (looking_at_1, string_match_1):
4473 (fast_string_match, fast_c_string_match_ignore_case)
4474 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4475 (scan_newline, find_before_next_newline, search_command)
4476 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4477 (set_search_regs, wordify):
4478 (Freplace_match):
4479 (Fmatch_data):
4480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4481 (string_match_1, search_buffer, set_search_regs):
4482 (Fmatch_data):
4483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4484 (wordify): Check for overflow in size calculation.
4485 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4486 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4487 Check that fixnums are in proper range for system types.
4488 * sound.c (struct sound_device)
4489 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4491 (Fplay_sound_internal):
4492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4493 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4494 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4495 (Fparse_partial_sexp):
4496 Don't assume fixnums can fit in int.
4497 (struct lisp_parse_state, find_start_pos, find_start_value)
4498 (find_start_value_byte, find_start_begv)
4499 (update_syntax_table, char_quoted, dec_bytepos)
4500 (find_defun_start, prev_char_comend_first, back_comment):
4501 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4502 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4504 (Finternal_describe_syntax_value): Check that match_lisp is a
4505 character, not an integer, since the code stuffs it into int.
4506 (scan_words, scan_sexps_forward):
4507 Check that fixnums are in proper range for system types.
4508 (Fforward_word):
4509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4510 (scan_sexps_forward):
4511 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4512 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4513 * syntax.h: Adjust decls to match defn changes elsewhere.
4514 (struct gl_state_s):
4515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4516 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4517 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4518 * sysdep.c (wait_for_termination_1, wait_for_termination)
4519 (interruptible_wait_for_termination, mkdir):
4520 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4521 (emacs_read, emacs_write):
4522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4523 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4524 and double all fit in int.
d311d28c
PE
4525 * term.c (set_tty_color_mode):
4526 Check that fixnums are in proper range for system types.
4527 * termhooks.h (struct input_event):
4528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4529 * textprop.c (validate_interval_range, interval_of)
4530 (Fadd_text_properties, set_text_properties_1)
4531 (Fremove_text_properties, Fremove_list_of_text_properties)
4532 (Ftext_property_any, Ftext_property_not_all)
4533 (copy_text_properties, text_property_list, extend_property_ranges)
4534 (verify_interval_modification):
4535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4536 (Fnext_single_char_property_change)
4537 (Fprevious_single_char_property_change):
4538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4539 (copy_text_properties):
4540 Check for integer overflow in index calculation.
d311d28c
PE
4541 * undo.c (last_boundary_position, record_point, record_insert)
4542 (record_delete, record_marker_adjustment, record_change)
4543 (record_property_change):
4544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4545 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4547 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4548 (Fx_hide_tip, Fx_file_dialog):
4549 * w32menu.c (set_frame_menubar):
4550 Use ptrdiff_t, not int, for consistency with rest of code.
4551 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4552 (select_window, Fdelete_other_windows_internal)
4553 (window_scroll_pixel_based, window_scroll_line_based)
4554 (Frecenter, Fset_window_configuration):
4555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4556 (Fset_window_hscroll, run_window_configuration_change_hook)
4557 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4558 (Fscroll_other_window, Frecenter):
d311d28c
PE
4559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4560 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4561 Don't assume fixnum fits in int.
4562 (Fset_window_scroll_bars):
4563 Check that fixnums are in proper range for system types.
4564 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4565 (string_pos, c_string_pos, number_of_chars, init_iterator)
4566 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4567 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4568 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4569 (face_before_or_after_it_pos, handle_invisible_prop)
4570 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4571 (display_prop_intangible_p, string_buffer_position_lim)
4572 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4573 (get_overlay_strings_1, get_overlay_strings)
4574 (iterate_out_of_display_property, forward_to_next_line_start)
4575 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4576 (get_next_display_element, set_iterator_to_next)
4577 (get_visually_first_element, compute_stop_pos_backwards)
4578 (handle_stop_backwards, next_element_from_buffer)
4579 (move_it_in_display_line_to, move_it_in_display_line)
4580 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4581 (add_to_log, message_dolog, message_log_check_duplicate)
4582 (message2, message2_nolog, message3, message3_nolog
4583 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4584 (current_message_1, truncate_echo_area, truncate_message_1)
4585 (set_message, set_message_1, store_mode_line_noprop)
4586 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4587 (text_outside_line_unchanged_p, check_point_in_composition)
4588 (reconsider_clip_changes)
4589 (redisplay_internal, set_cursor_from_row, try_scrolling)
4590 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4591 (redisplay_window, find_last_unchanged_at_beg_row)
4592 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4593 (trailing_whitespace_p, find_row_edges, display_line)
4594 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4595 (display_mode_element, store_mode_line_string)
4596 (pint2str, pint2hrstr, decode_mode_spec)
4597 (display_count_lines, display_string, draw_glyphs)
4598 (x_produce_glyphs, x_insert_glyphs)
4599 (rows_from_pos_range, mouse_face_from_buffer_pos)
4600 (fast_find_string_pos, mouse_face_from_string_pos)
4601 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4603 (safe_call, init_from_display_pos, handle_fontified_prop)
4604 (handle_single_display_spec, load_overlay_strings)
4605 (with_echo_area_buffer, setup_echo_area_for_printing)
4606 (display_echo_area, echo_area_display)
4607 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4608 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4609 (redisplay_window, dump_glyph_row, display_mode_line)
4610 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4611 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (handle_single_display_spec, build_desired_tool_bar_string)
4614 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4615 (get_specified_cursor_type):
4616 Check that fixnums are in proper range for system types.
4617 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4618 (Flookup_image_map):
4619 Don't assume fixnums fit in int.
4620 (compare_overlay_entries):
4621 Avoid mishandling comparisons due to subtraction overflow.
4622 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4623 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4624 (handle_tool_bar_click):
4625 Use int, not unsigned, since we prefer signed and the signedness
4626 doesn't matter here.
4627 (get_next_display_element, next_element_from_display_vector):
4628 Use int, not EMACS_INT, when int is wide enough.
4629 (start_hourglass): Use duration_to_sec_usec to do proper
4630 overflow checking on durations.
4631 * xfaces.c (Fbitmap_spec_p):
4632 Check that fixnums are in proper range for system types.
4633 (compare_fonts_by_sort_order):
4634 Avoid mishandling comparisons due to subtraction overflow.
4635 (Fx_family_fonts, realize_basic_faces):
4636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4637 (Fx_family_fonts):
4638 Don't assume fixnum fits in int.
4639 Use SAFE_ALLOCA_LISP, not alloca.
4640 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4641 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4642 (face_at_buffer_position, face_for_overlay_string)
4643 (face_at_string_position):
4644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4645 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4646 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4647 (Fx_show_tip):
4648 Check that fixnums are in proper range for system types.
4649 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4650 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4652 (Fx_change_window_property): Don't assume fixnums fit in int.
4653 * xfont.c (xfont_chars_supported):
4654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4655 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4656 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4658 * xml.c (parse_region):
4659 * xrdb.c (magic_file_p):
4660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4661 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4662 (x_get_local_selection, x_reply_selection_request)
4663 (x_handle_selection_request, wait_for_property_change):
4664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4665 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4666 short is wide enough.
4667 (x_send_client_event): Don't assume fixnum fits in int.
4668 * xterm.c (x_x_to_emacs_modifiers):
4669 Don't assume EMACS_INT overflows nicely into int.
4670 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4671 may come from Lisp.
4672 (handle_one_xevent): NATNUMP can eval its arg twice.
4673 (x_connection_closed):
4674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4675 * xterm.h: Adjust decls to match defn changes elsewhere.
4676 (struct scroll_bar): Use struct vectorlike_header
4677 rather than rolling our own approximation.
4678 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4679
c6574eb5
GM
46802012-05-25 Glenn Morris <rgm@gnu.org>
4681
4682 * lisp.mk (lisp): Update for more files being compiled now.
4683
e8d32c7e
SM
46842012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4685
48def666
SM
4686 * lread.c: Remove `read_pure' which makes no difference.
4687 (read_pure): Remove var.
4688 (unreadpure): Remove function.
4689 (readevalloop): Don't call read_list with -1 flag.
4690 (read1, read_vector): Don't test read_pure any more.
4691 (read_list): Simplify.
4692
e8d32c7e
SM
4693 * fileio.c, character.h: Minor style tweaks.
4694
4b2addb7
DA
46952012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4696
4697 * window.h (clip_changed): Remove useless declaration.
4698
584461b2
JB
46992012-05-22 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4702 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4703
34374650
PE
47042012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4705
4706 Remove src/m/*.
4707 This directory predates autoconf and is no longer needed nowadays.
4708 Move its few remaining bits of functionality to where they're needed.
4709 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4710 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4711 * m/template.h: Remove.
4712 * Makefile.in (M_FILE): Remove. All uses removed.
4713 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4714 * lisp.h (USE_LSB_TAG):
4715 * mem-limits.h (EXCEEDS_LISP_PTR):
4716 Use VAL_MAX, not VALBITS, in #if.
4717 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4718 (EMACS_UINT): Define unconditionally now.
4719 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4720 (BITS_PER_EMACS_INT): New constants, replacing
4721 what used to be in config.h, but not useful in #if.
4722 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4723 define them any more.
4724 (VAL_MAX): New macro.
4725 (VALMASK): Use it.
4726 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4727 BITS_PER_EMACS_INT, in #if.
4728 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4729 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4730 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4731 * s/ms-w32.h (DATA_START):
4732 Move here from removed file m/intel386.h.
4733 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4734 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4735
261cb4bb
PE
47362012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 Assume C89 or later.
4739 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4740 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4741 (xrealloc):
4742 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4743 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4744 * textprop.c, tparam.c (NULL): Remove.
4745 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4746 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4747 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4748 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4749 * xterm.c (input_signal_count): Assume volatile works.
4750
ff23cd9f
KB
47512012-05-21 Ken Brown <kbrown@cornell.edu>
4752
4753 * xgselect.c (xg_select): Fix first argument in call to 'select'
4754 (bug#11508).
4755
1b170bc6
KB
47562012-05-20 Ken Brown <kbrown@cornell.edu>
4757
4758 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4759 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4760
b2f4d39f
KB
47612012-05-19 Ken Brown <kbrown@cornell.edu>
4762
4763 * xfns.c (x_in_use): Remove `static' qualifier.
4764 * xterm.h (x_in_use): Declare.
4765 * xgselect.c: Include xterm.h.
4766 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4767 and `display_arg' (bug#9754).
4768
003fdae2
PE
47692012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4770
9232a6d9
PE
4771 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4772
003fdae2
PE
4773 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4774 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4775
784b56e2
EZ
47762012-05-18 Eli Zaretskii <eliz@gnu.org>
4777
4778 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4779
4780 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4781 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4782
4783 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4784 reference to image_cache->refcount.
4785 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4786
a0a79cde
JL
47872012-05-17 Juri Linkov <juri@jurta.org>
4788
4789 * search.c (Fword_search_regexp, Fword_search_backward)
4790 (Fword_search_forward, Fword_search_backward_lax)
4791 (Fword_search_forward_lax): Move functions to isearch.el
4792 (bug#10145, bug#11381).
4793
b0572523
PE
47942012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4797
9660f5fc
SM
47982012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4799
4800 * lread.c (init_obarray): Declare Qt and Qnil as special.
4801
4374de83
GM
48022012-05-14 Glenn Morris <rgm@gnu.org>
4803
4804 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4805 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4806
dc44c39a
PE
48072012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4808
078c97cb
PE
4809 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4810
dc44c39a
PE
4811 * unexaix.c: Port to more-recent AIX compilers.
4812 (report_error, report_error_1, make_hdr, copy_sym)
4813 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4814 Make arguments const char *, not char *, to avoid violations of C
4815 standard and to fix some AIX warnings reported by Gilles Pion.
4816
e18afed7 48172012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4818
4819 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4820 already have overlays loaded.
4821 (handle_single_display_spec): Before returning without displaying
4822 fringe bitmap, synchronize the bidi iterator with the main display
4823 iterator, by calling iterate_out_of_display_property.
4824 (iterate_out_of_display_property): Detect buffer iteration by
4825 testing that it->string is a Lisp string.
4826 (get_next_display_element): When the current object is exhausted,
4827 and there's something on it->stack, call set_iterator_to_next to
4828 proceed with what's on the stack, instead of returning zero.
4829 (set_iterator_to_next): If called at the end of a Lisp string,
4830 proceed to consider_string_end without incrementing string
4831 position. Don't increment display vector index past the end of
4832 the display vector. (Bug#11417)
c8fb9dc6
EZ
4833 (pos_visible_p): Don't report a position visible when move_it_to
4834 stopped at the last line of window, which happens to be scanned
4835 backwards by the bidi iteration. (Bug#11464)
ac268e67 4836
e18afed7 48372012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4838
4839 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4840 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4841 are on a TTY, and thus unable to display on the fringes.
4842 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4843 so we need to signal to the caller that this is a "replacing"
4844 display spec. This fixes display when the spec is invalid or we
4845 are on a TTY.
4846
e18afed7 48472012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4848
4849 * unexaix.c (make_hdr): Fix typo in prototype.
4850 This bug broke the build on AIX. Problem reported by Gilles Pion.
4851
9d0a235a
MA
48522012-05-14 Michael Albinus <michael.albinus@gmx.de>
4853
4854 * keyboard.c (kbd_buffer_get_event): Read special events also in
4855 batch mode. (Bug#11415)
4856
9e6b06ed
GM
48572012-05-12 Glenn Morris <rgm@gnu.org>
4858
4859 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4860
c1a1d7a3
EZ
48612012-05-12 Eli Zaretskii <eliz@gnu.org>
4862
4863 * lisp.mk (lisp): Add newcomment.elc.
4864
3fe7cdc8
GM
48652012-05-12 Glenn Morris <rgm@gnu.org>
4866
4867 * Makefile.in (MKDIR_P): New, set by configure.
4868 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4869
53f7d2c0
PE
48702012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Remove unused function hourglass_started.
4873 * dispextern.h (hourglass_started):
4874 * w32fns.c (hourglass_started):
4875 * xdisp.c (hourglass_started): Remove.
4876
75aafb17
JB
48772012-05-10 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4880 Update dependencies.
4881
12959e8e
PE
48822012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4883
97107e2e
PE
4884 * xgselect.c (xg_select): Put maxfds+1 into a var.
4885 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4886
12959e8e
PE
4887 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4888
836d29b3
DA
48892012-05-10 Dave Abrahams <dave@boostpro.com>
4890
4891 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4892 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4893
5cb67954
MA
48942012-05-09 Michael Albinus <michael.albinus@gmx.de>
4895
4896 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4897 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4898 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4899 Initialize xd_registered_buses.
4900
3478ec45
PE
49012012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4902
b263a6b0
PE
4903 Untag more efficiently if USE_LSB_TAG.
4904 This is based on a proposal by YAMAMOTO Mitsuharu in
4905 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4906 For an admittedly artificial (nth 8000 longlist) benchmark on
4907 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4908 Emacs's overall text size by 1%.
4909 * lisp.h (XUNTAG): New macro.
4910 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4911 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4912 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4913 * eval.c (Fautoload):
4914 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4915 * frame.h (XFRAME): Use XUNTAG.
4916
3478ec45
PE
4917 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4918 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4919 Remove unportable assumptions about print widths of types like
4920 dbus_uint32_t.
4921 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4922 intptr_t when converting between pointer and integer, to avoid GCC
4923 warnings about wrong width.
4924
666b903b 49252012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4926
4927 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4928 stack for each reader_thread, instead of defaulting to 8MB
4929 determined by the linker. This avoids failures in creating
4930 subprocesses on Windows 7, see the discussion in this thread:
4931 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4932
b120cc17
JC
49332012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4934
4935 Fix up display of the *Minibuf-0* buffer in the mini window.
4936 * keyboard.c (read_char): Don't clear the echo area if there's no
4937 message to clear.
4938 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4939 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4940
9a4b36f8
MA
49412012-05-07 Michael Albinus <michael.albinus@gmx.de>
4942
4943 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4944 batch mode.
4945
e5f9458f
CY
49462012-05-06 Chong Yidong <cyd@gnu.org>
4947
4948 * lisp.mk (lisp): Update.
4949
eceeb5fc 49502012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4951
4952 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4953
71873e2b
SM
49542012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4955
4956 * data.c (PUT_ERROR): New macro.
4957 (syms_of_data): Use it. Add new error type `user-error'.
4958 * undo.c (user_error): New function.
4959 (Fprimitive_undo): Use it.
4960 * print.c (print_error_message): Adjust print style for `user-error'.
4961 * keyboard.c (user_error): New function.
4962 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4963
ab0fa4e4
PE
49642012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4965
4966 Do not limit current-time-string to years 1000..9999.
4967 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4968 (Fcurrent_time_string): Support any year that is supported by the
4969 underlying localtime representation. Don't use asctime, as it
4970 has undefined behavior for years outside the range -999..9999.
4971
7ed806a7
PE
49722012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4973
4974 Fix race conditions involving setenv, gmtime, localtime, asctime.
4975 Without this fix, interrupts could mess up code that uses these
4976 nonreentrant functions, since setting TZ invalidates existing
4977 tm_zone or tzname values, and since most of these functions return
4978 pointers to static storage.
4979 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4980 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4981 Grow the critical sections to include not just invoking
4982 localtime/gmtime, but also accessing these functions' results
4983 including their tm_zone values if any, and any related TZ setting.
4984 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4985 so that the struct tm is saved in the critical section.
4986 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4987 motivated by the fact that memory allocation needs to be outside
4988 the critical section.
4989
0c16dfed
DA
49902012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4991
4992 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4993 with RESET_INTERVAL.
4994
4995 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4996 Remove duplicated buffer name initialization.
4997
3f83ace8
JM
49982012-05-02 Jim Meyering <jim@meyering.net>
4999
5000 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5001
c7b8541e
JM
5002 * xfns.c (x_window): Use xstrdup (Bug#11375).
5003
90207a15 50042012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5005
5006 * xdisp.c (pos_visible_p): If already at a newline from the
5007 display string before the 'while' loop, don't walk back the glyphs
5008 from it3.glyph_row. Solves assertion violation when the display
5009 string begins with a newline (egg.el). (Bug#11367)
5010
b593d6a9
AH
50112012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5012
5013 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5014 Move to simple.el.
5015
4737362e
GM
50162012-05-01 Glenn Morris <rgm@gnu.org>
5017
99cf43f9
GM
5018 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5019 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5020 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5021 All were removed before 23.1.
5022
9311dcff
GM
5023 * dispnew.c: Remove HAVE_LIBNCURSES test;
5024 it is always true on relevant platforms.
5025
4d5c6349
GM
5026 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5027 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5028
4737362e
GM
5029 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5030
74dd3a6b
AS
50312012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5032
5033 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5034 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5035 Remove.
5036
13c379ee
PE
50372012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 Do not avoid creating empty evaporating overlays (Bug#9642).
5040 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5041 That is, do not delete an evaporating overlay if it becomes
5042 empty after its bounds are adjusted to fit within its buffer.
5043 This fix caused other problems, and I'm reverting it until we get
5044 to the bottom of them.
5045
a8e7d6d7 50462012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5047
5048 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5049
a8e7d6d7 50502012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5051
5052 * xdisp.c (pos_visible_p): If the window start position is beyond
5053 ZV, start the display from buffer beginning. Prevents assertion
5054 violation in init_iterator when the minibuffer window is scrolled
5055 via the scroll bar.
5056
5057 * window.c (window_scroll_pixel_based): Likewise.
5058
a8e7d6d7 50592012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5060
5061 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5062
a8e7d6d7 50632012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5064
5065 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5066 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5067
a8e7d6d7 50682012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5069
b593d6a9
AH
5070 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5071 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5072
1c6900d9
EZ
50732012-04-26 Eli Zaretskii <eliz@gnu.org>
5074
4c3fa1d9
EZ
5075 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5076 display element, check also the underlying string or buffer
5077 character. (Bug#11341)
5078
1c6900d9
EZ
5079 * w32menu.c: Include w32heap.h.
5080 (add_menu_item): If the call to AppendMenuW (via
5081 unicode_append_menu) fails, disable Unicode menus only if we are
5082 running on Windows 9X/Me.
5083
42bf8205
AS
50842012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5085
5086 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5087 (xgetint): Add missing shift for LSB tags.
5088
b1bac16e
MR
50892012-04-24 Martin Rudalics <rudalics@gmx.at>
5090
5091 * keyboard.c (read_char): Don't wipe echo area for select window
5092 events: These might get delayed via `mouse-autoselect-window'
5093 (Bug#11304).
5094
d69621cc
JB
50952012-04-24 Juanma Barranquero <lekktu@gmail.com>
5096
5097 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5098 manipulation of :loaded-from data.
5099
02fd101b
JB
51002012-04-23 Juanma Barranquero <lekktu@gmail.com>
5101
5102 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5103 now a cons (bug#11311).
5104
888bec30
PE
51052012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5106
89a438bd
PE
5107 Do not create empty overlays with the evaporate property (Bug#9642).
5108 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5109 if it becomes empty after its bounds are adjusted to fit within
5110 its buffer. Without this fix, in a nonempty buffer (let ((o
5111 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5112 yields an empty overlay that has the evaporate property, which is
5113 not supposed to happen.
5114
1068fe4d
PE
5115 Fix minor GTK3 problems found by static checking.
5116 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5117 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5118 (struct _EmacsFixedClass, emacs_fixed_get_type):
5119 Move decls here from emacsgtkfixed.h, since they needn't be public.
5120 (emacs_fixed_get_type): Now static.
5121 (emacs_fixed_class_init): Omit unused local.
5122 (emacs_fixed_child_type): Remove; unused.
5123 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5124 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5125 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5126 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5127 (EMACS_FIXED_GET_CLASS): Remove; unused.
5128 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5129
888bec30
PE
5130 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5131 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5132
de85e130
PE
51332012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5134
d0baac98 5135 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5136 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5137 (__malloc_size_t, __malloc_ptrdiff_t):
5138 Remove. All uses removed, replaced by the definiens if needed,
5139 since we can assume C89 or better now.
5140 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5141 (protect_malloc_state, align, get_contiguous_space)
5142 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5143 (malloc_atfork_handler_child, malloc_enable_thread)
5144 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5145 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5146 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5147 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5148 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5149 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5150 Define using prototypes, not old style.
5151 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5152 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5153 (align): Don't assume that signed integer overflow wraps around.
5154 Omit unused local var.
5155 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5156 (_free_internal_nolock, memalign, mallochook, reallochook):
5157 Omit no-longer-needed casts.
5158 (valloc): Use getpagesize, not __getpagesize.
5159 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5160 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5161
de85e130
PE
5162 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5163
dcbf5805
MA
51642012-04-22 Michael Albinus <michael.albinus@gmx.de>
5165
5166 Move functions from C to Lisp. Make non-blocking method calls
5167 the default. Implement further D-Bus standard interfaces.
5168
5169 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5170 (QCdbus_request_name_allow_replacement)
5171 (QCdbus_request_name_replace_existing)
5172 (QCdbus_request_name_do_not_queue)
5173 (QCdbus_request_name_reply_primary_owner)
5174 (QCdbus_request_name_reply_in_queue)
5175 (QCdbus_request_name_reply_exists)
5176 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5177 (QCdbus_registered_serial, QCdbus_registered_method)
5178 (QCdbus_registered_signal): New Lisp objects.
5179 (XD_DEBUG_MESSAGE): Use sizeof.
5180 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5181 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5182 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5183 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5184 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5185 (xd_signature, xd_append_arg): Allow float for integer types.
5186 (xd_get_connection_references): New function.
b593d6a9
AH
5187 (xd_get_connection_address): Rename from xd_initialize.
5188 Return cached address.
dcbf5805
MA
5189 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5190 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5191 level.
5192 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5193 Return number of refcounts.
dcbf5805
MA
5194 (Fdbus_get_unique_name): Make stronger parameter check.
5195 (Fdbus_message_internal): New defun.
5196 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5197 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5198 (Fdbus_send_signal, Fdbus_register_service)
5199 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5200 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5201 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5202 (Vdbus_compiled_version, Vdbus_runtime_version)
5203 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5204 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5205 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5206 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5207 Adapt docstring.
dcbf5805 5208
52828e02
PE
52092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5210
da05bc4c
PE
5211 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5212 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5213 Do not assume ptrdiff_t is the same width as 'int'.
5214
52828e02
PE
5215 * alloc.c: Handle unusual debugging option combinations.
5216 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5217 since the two debugging options are incompatible.
5218 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5219 is defined.
5220 (mem_init, mem_insert, mem_insert_fixup):
5221 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5222 (NEED_MEM_INSERT): Remove; no longer needed.
5223
f01769f9
LL
52242012-04-22 Leo Liu <sdl.web@gmail.com>
5225
5226 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5227
5790543d
PE
52282012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 * sysdep.c [__FreeBSD__]: Minor cleanups.
5231 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5232 Use Emacs indenting style more consistently. Avoid some casts.
5233 Use 'double' consistently rather than mixing 'float' and 'double'.
5234
b91b7e4d
EW
52352012-04-21 Eduard Wiebe <usenet@pusto.de>
5236
b593d6a9
AH
5237 * sysdep.c (list_system_processes, system_process_attributes):
5238 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5239
6114eb15
AS
52402012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5241
5242 * lisp.mk (lisp): Update.
5243
2f38dff7
PE
52442012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5247 It is never used otherwise.
5248
4ae29f89
SM
52492012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5250
5251 * print.c (print_preprocess): Only check print_depth if print-circle
5252 is nil.
5253 (print_object): Check for cycles even when print-circle is nil and
5254 print-gensym is t, but only check print_depth if print-circle is nil.
5255
f30d612a
CY
52562012-04-20 Chong Yidong <cyd@gnu.org>
5257
5258 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5259 set the status to "failed" and ensure that sentinel is run.
5260
c07a4c0b 52612012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5262
5263 * process.c (Fset_process_inherit_coding_system_flag)
5264 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5265 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5266
c07a4c0b 52672012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5268
5269 * xdisp.c (string_buffer_position_lim): Limit starting position to
5270 BEGV.
5271 (set_cursor_from_row): If called for a mode-line or header-line
5272 row, return zero immediately.
5273 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5274 farther than the first row after the header line, if any.
5275 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5276 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5277
c07a4c0b 52782012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5279
4ae29f89
SM
5280 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5281 (bug#11238).
ad3a2b41 5282
c07a4c0b 52832012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52842012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5285
5286 configure: new option --enable-gcc-warnings (Bug#11207)
5287 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5288 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5289 (ALL_CFLAGS): Use new macros rather than old.
5290 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5291 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5292 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5293 -Wunused-result, -Wunused-variable. This should go away once
5294 the Emacs and Gnulib regex code is merged.
5295 (xmalloc, xrealloc): Now static.
5296
aba027e8
PE
52972012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 * dired.c (Fsystem_groups): Remove unused local.
5300
e5a36063
GM
53012012-04-17 Glenn Morris <rgm@gnu.org>
5302
5303 * dired.c (Fsystem_users): Doc fix.
5304
316411f0
DA
53052012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5306
5307 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5308 (syms_of_dired): Add them.
5309
9426aba4
PE
53102012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5311
b62a57be
PE
5312 Fix minor alloc.c problems found by static checking.
5313 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5314 New extern decls, to avoid calling undeclared functions.
5315 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5316 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5317 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5318 (NEED_MEM_INSERT): New macro.
5319 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5320 Remove one incorrect comment and fix another.
b62a57be 5321
3539f31f
PE
5322 Fix minor ralloc.c problems found by static checking.
5323 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5324 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5325 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5326 (r_alloc_sbrk): Now static.
5327
a041960a
PE
5328 Improve ralloc.c interface checking.
5329 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5330 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5331 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5332 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5333 [REL_ALLOC]: ... to here, to check interface.
5334 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5335 Remove decls. This fixes an "It stinks!".
5336
9426aba4
PE
5337 * alloc.c (which_symbols): Fix alignment issue / type clash.
5338
d55c12ed
AS
53392012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5340
5341 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5342 (struct Lisp_Misc_Any): Likewise.
5343 (struct Lisp_Free): Likewise.
5344 * alloc.c (union aligned_Lisp_Symbol): Define.
5345 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5346 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5347 (union aligned_Lisp_Misc): Define.
5348 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5349 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5350 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5351
b948ce8b
PE
53522012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5353
5354 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5355 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5356 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5357 * s/netbsd.h, s/sol2-6.h:
5358 Remove definition of GC_MARK_STACK, since the default now works.
5359 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5360 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5361 no longer the default.
5362 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5363
35dc09a1 53642012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5365
35dc09a1
GM
5366 * lread.c (lisp_file_lexically_bound_p):
5367 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5368
35dc09a1
GM
53692012-04-14 Eli Zaretskii <eliz@gnu.org>
5370
5371 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5372 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5373
53742012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5375
5376 * nsterm.m (constrainFrameRect): Always constrain when there is only
5377 one screen (Bug#10962).
5378
bcd86815
KB
53792012-04-13 Ken Brown <kbrown@cornell.edu>
5380
5381 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5382
c25df26e
RT
53832012-04-13 Reuben Thomas <rrt@sc3d.org>
5384
5385 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5386
0fc59f1e
DC
53872012-04-11 Daniel Colascione <dancol@dancol.org>
5388
5389 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5390 against is gone. It's better to use vfork now so that when Cygwin
5391 gains a new, working vfork, we use it automatically (bug#10398).
5392
de8c03dc
SM
53932012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5394
5395 * window.c (save_window_save): Obey window-point-insertion-type.
5396
2f097256
GM
53972012-04-11 Glenn Morris <rgm@gnu.org>
5398
5399 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5400
453b951e
SM
54012012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5404
75f1671a 54052012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5406
5407 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5408 (force_quit_count): New var.
5409 (handle_interrupt): Use it.
5410
2a8ce227
JB
54112012-04-10 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * w32.c (w32_delayed_load): Record the full path of the library
5414 being loaded (bug#10424).
5415
935396c0
GM
54162012-04-09 Glenn Morris <rgm@gnu.org>
5417
05920a43
GM
5418 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5419 not just in the obarray, before snarfing them. (Bug#11036)
5420
935396c0
GM
5421 * Makefile.in ($(leimdir)/leim-list.el):
5422 Pass EMACS rather than BUILT_EMACS.
5423
a18ecafa
TZ
54242012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5425
5426 * process.c (make_process):
5427 * process.h: Add integer `gnutls_handshakes_tried' member to
5428 process struct.
5429
6bbef4e5
JC
5430 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5431 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5432
5433 * gnutls.c (gnutls_log_function2i): Convenience log function.
5434 (emacs_gnutls_read): Use new log functions,
5435 `gnutls_handshakes_tried' process member, and
5436 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5437 attempts per process (connection).
5438
b4d3bc10
CY
54392012-04-09 Chong Yidong <cyd@gnu.org>
5440
5441 * eval.c (Fuser_variable_p, user_variable_p_eh)
5442 (lisp_indirect_variable): Functions deleted.
5443 (Fdefvar): Caller changed.
5444
5445 * callint.c (Finteractive, Fcall_interactively):
5446 * minibuf.c (Fread_variable): Callers changed.
5447
70f4d973
EZ
54482012-04-09 Eli Zaretskii <eliz@gnu.org>
5449
5450 * xdisp.c (set_cursor_from_row): If the display string appears in
5451 the buffer at position that is closer to point than the position
5452 after the display string, display the cursor on the first glyph of
5453 the display string. Fixes cursor display when a 'display' text
5454 property immediately follows invisible text. (Bug#11094)
5455
cb3c2e3e
PE
54562012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5457
5458 composite.c: use 'double' consistently
5459 * composite.c (get_composition_id): Use 'double' consistently
5460 instead of converting 'float' to 'double' and vice versa; this is
5461 easier to understand and avoids a GCC warning.
5462
fd06db5d
GM
54632012-04-09 Glenn Morris <rgm@gnu.org>
5464
50fe702a
GM
5465 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5466 preparation for dumping it with emacs. (Bug#4789)
5467 (leimdir): New variable.
5468 ($(leimdir)/leim-list.el): New rule.
5469 (emacs$(EXEEXT)): Depend on leim-list.el.
5470
fd06db5d
GM
5471 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5472 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5473 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5474
55c131ee
AS
54752012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5476
5477 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5478 proper alignment.
5479
9209588f
JB
54802012-04-07 Juanma Barranquero <lekktu@gmail.com>
5481
5482 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5483 Remove unused local variable.
5484
e3fb2efb
PE
54852012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5488 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5489 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5490 objects, as mark_maybe_pointer will catch them otherwise.
5491 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5492 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5493
b5385551
PE
54942012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5495
5496 Fix typo that broke non-Windows builds.
5497 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5498
9078ead6
EZ
54992012-04-07 Eli Zaretskii <eliz@gnu.org>
5500
5501 Support building on MS-Windows with libxml2.
5502
5503 * makefile.w32-in (OBJ2): Add xml.$(O).
5504 (GLOBAL_SOURCES): Add xml.c.
5505 ($(BLD)/xml.$(O)): New dependency list.
5506
5507 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5508 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5509 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5510 [!WINDOWSNT]: New macros.
5511 (init_libxml2_functions, libxml2_loaded_p): New functions.
5512 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5513 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5514 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5515 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5516 linked in).
6bbef4e5
JC
5517 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5518 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5519 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5520
5521 * emacs.c: Don't include libxml/parser.h.
5522 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5523 xmlCleanupParser directly.
5524
5525 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5526
3811fdf3
EZ
55272012-04-07 Eli Zaretskii <eliz@gnu.org>
5528
5529 * indent.c (Fvertical_motion): If there is a display string at
5530 point, use it.vpos to compute how many lines to backtrack after
5531 move_it_to point. (Bug#11133)
5532
2f8e16b2
EZ
55332012-04-06 Eli Zaretskii <eliz@gnu.org>
5534
5535 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5536 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5537 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5538 macros related to unification of CJK characters. For the details,
5539 see the discussion following the message here:
5540 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5541
3d439cd1
CY
55422012-04-04 Chong Yidong <cyd@gnu.org>
5543
5544 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5545
8bc53d00
EZ
55462012-04-01 Eli Zaretskii <eliz@gnu.org>
5547
5548 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5549 instead of alloca. (Bug#11138)
5550
3b0512a3
AS
55512012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5552
5553 * w32menu.c (is_simple_dialog): Properly check lisp types.
5554 (Bug#11141)
5555
8427ddd2
EZ
55562012-03-31 Eli Zaretskii <eliz@gnu.org>
5557
979022ef
EZ
5558 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5559 position we get to after a call to move_it_to fails the
5560 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5561 only if we wind up in a string from display property. (Bug#11063)
5562
a6b1c7cc
EZ
5563 * window.c (Fdelete_other_windows_internal): Invalidate the row
5564 and column information about mouse highlight, so that redisplay
5565 restores it after reallocating the glyph matrices. (Bug#7464)
5566
8427ddd2
EZ
5567 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5568 string comes from a `display' text property, use the buffer
5569 position of that property as if we actually saw that position in
5570 the row's glyphs.
697ba24b
EZ
5571 (move_it_by_lines): Remove the assertion that
5572 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5573 violated when there's a before-string at the beginning of a line.
5574 (Bug#11063)
8427ddd2 5575
65a0a738
EZ
55762012-03-30 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (append_space_for_newline): If the default face was
5579 remapped, use the remapped face for the appended newline.
5580 (extend_face_to_end_of_line): Use the remapped default face for
5581 extending the face to the end of the line.
5582 (display_line): Call extend_face_to_end_of_line when the default
5583 face was remapped. (Bug#11068)
5584
581355cc
EZ
55852012-03-29 Eli Zaretskii <eliz@gnu.org>
5586
5587 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5588
e8fc049f
SM
55892012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5590
5591 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5592
4fb9a543
GM
55932012-03-27 Glenn Morris <rgm@gnu.org>
5594
5595 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5596 Doc fixes.
5597
679910f1
KH
55982012-03-26 Kenichi Handa <handa@m17n.org>
5599
5600 * dispextern.h (struct glyph): Fix previous change. Change the
5601 bit length of glyphless.ch to 25 (Bug#11082).
5602
90d49b7f
CY
56032012-03-26 Chong Yidong <cyd@gnu.org>
5604
5605 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5606 (command_loop_1): Use it; inhibit selection update for
5607 handle-select-window too (Bug#8996).
5608
f514f6f0
FP
56092012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5610
e8fc049f 5611 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5612
bf43fa51
KH
56132012-03-25 Kenichi Handa <handa@m17n.org>
5614
5615 * dispextern.h (struct glyph): Change the bit length of
5616 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5617
8a0c01dd
EZ
56182012-03-24 Eli Zaretskii <eliz@gnu.org>
5619
5620 * s/ms-w32.h (tzname): Include time.h before redirecting to
5621 _tzname. Fixes the MSVC build. (Bug#9960)
5622
7d1c3a76
AS
56232012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5624
8ed79523
AS
5625 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5626 characters.
5627
7d1c3a76
AS
5628 * xterm.c (XTread_socket): Only modify handling_signal if
5629 !SYNC_INPUT. (Bug#11080)
5630
e99a9b8b
EZ
56312012-03-23 Eli Zaretskii <eliz@gnu.org>
5632
5633 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5634 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5635 when fetching a multibyte character consumes more bytes than
5636 CHAR_BYTES returns, due to unification of CJK characters in
5637 string_char. (Bug#11073)
5638
5063c0e1
TN
56392012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5640
5641 * process.c (wait_reading_process_output): Handle pty disconnect
5642 by refraining from sending oneself a SIGCHLD (bug#10933).
5643
9f851fbd
CY
56442012-03-22 Chong Yidong <cyd@gnu.org>
5645
5646 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5647
5063c0e1 5648 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5649 Mark string as coming from a prefix property.
5650 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5651 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5652
fb5b8aca
CY
56532012-03-21 Chong Yidong <cyd@gnu.org>
5654
5655 * xfaces.c (Vface_remapping_alist): Doc fix.
5656
62356a1b
EZ
56572012-03-20 Eli Zaretskii <eliz@gnu.org>
5658
5659 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5660 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5661 Doc fixes.
62356a1b 5662
025de85b
CY
56632012-03-20 Chong Yidong <cyd@gnu.org>
5664
5665 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5666 to reflect default non-nil value of redisplay-dont-pause.
5667
4827f94e
KH
56682012-03-19 Kenichi Handa <handa@m17n.org>
5669
5670 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5671 it fit in a valid range (Bug#11003).
5672
e50a24a2
EZ
56732012-03-18 Eli Zaretskii <eliz@gnu.org>
5674
5675 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5676 that is not from display property, accept the row as a "cursor
5677 row" if one of the string's character has a non-nil `cursor'
5678 property. Fixes cursor positioning when there are newlines in
5679 overlay strings, e.g. in icomplete.el. (Bug#11035)
5680
9af5ed87
PE
56812012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5684
d1f55f16
CY
56852012-03-12 Chong Yidong <cyd@gnu.org>
5686
5687 * eval.c (inhibit_lisp_code): Rename from
5688 inhibit_window_configuration_change_hook; move from window.c.
5689
5690 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5691 * window.c (run_window_configuration_change_hook)
5692 (syms_of_window): Callers changed.
5693
66c5eebd
CY
56942012-03-11 Chong Yidong <cyd@gnu.org>
5695
413df973
CY
5696 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5697
66c5eebd
CY
5698 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5699
1de11f56
CY
57002012-03-10 Chong Yidong <cyd@gnu.org>
5701
5702 * frame.c (other_visible_frames): Don't assume the selected frame
5703 is visible (Bug#10955).
5704
cae07000
SM
57052012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5706
5707 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5708
89c94350
JD
57092012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5710
5711 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5712 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5713 zero (Bug#10954).
5714
999dd333
GM
57152012-03-03 Glenn Morris <rgm@gnu.org>
5716
01a6dcc8 5717 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5718
de0100f2
EZ
57192012-03-02 Eli Zaretskii <eliz@gnu.org>
5720
5721 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5722 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5723 (redisplay_window, next_element_from_string): Fix typos in
5724 comments.
3e441275
EZ
5725 (redisplay_window): Pass to move_it_vertically the margin in
5726 pixels, not in screen lines.
de0100f2 5727
96a72ee9
GM
57282012-03-02 Glenn Morris <rgm@gnu.org>
5729
5730 * buffer.c (buffer-list-update-hook): Doc fix.
5731
312508d7
EZ
57322012-02-29 Eli Zaretskii <eliz@gnu.org>
5733
5734 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5735 push_it before setting up the iterator for the first overlay
5736 string, even if we have an empty string loaded.
5737 (next_overlay_string): If there's an empty string on the iterator
5738 stack, pop the stack. (Bug#10903)
5739
27f3c637
PE
57402012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5741
5742 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5743 Suggested by Stefan Monnier in
5744 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5745 * alloc.c (widen_to_Lisp_Object): New static function.
5746 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5747 and widening them to Lisp_Objects. This would work even if
5748 USE_LSB_TAG is defined and wide integers are used, which might
5749 happen in a future version of Emacs.
5750
3c9dfce6
CY
57512012-02-25 Chong Yidong <cyd@gnu.org>
5752
fa74b241
CY
5753 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5754 Doc fix.
5755
3c9dfce6
CY
5756 * xselect.c (Fx_selection_exists_p): Doc fix.
5757 (x_clipboard_manager_save_all): Print an informative message
5758 before saving to clipboard manager.
5759
9486df08
CY
57602012-02-24 Chong Yidong <cyd@gnu.org>
5761
5762 * keyboard.c (process_special_events): Handle all X selection
5763 requests in kbd_buffer, not just the next one (Bug#8869).
5764
f01d3321
CY
57652012-02-23 Chong Yidong <cyd@gnu.org>
5766
5767 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5768 call when setting menu-bar-lines and tool-bar-lines parameters.
5769 (unwind_create_frame_1): New helper function.
5770
5771 * window.c (inhibit_window_configuration_change_hook): New var.
5772 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5773 (syms_of_window): Initialize it.
f01d3321 5774
86b847b6
CY
57752012-02-22 Chong Yidong <cyd@gnu.org>
5776
5777 * xterm.c (x_draw_image_relief): Add missing type check for
5778 Vtool_bar_button_margin (Bug#10743).
5779
a59225b1
CY
57802012-02-21 Chong Yidong <cyd@gnu.org>
5781
5782 * fileio.c (Vfile_name_handler_alist): Doc fix.
5783
5784 * buffer.c (Fget_file_buffer): Protect against invalid file
5785 handler return value.
5786
310f5bd4
PE
57872012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5788
cb3a28cc
PE
5789 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5790 when computing $valmask.
5791
310f5bd4
PE
5792 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5793 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5794 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5795 It's useless in that case, and it can cause problems on hosts
5796 that allocate halves of EMACS_INT values separately.
5797 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5798 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5799 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5800 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5801 it avoids undefined behavior on hosts where shifting right by more
5802 than the word width has undefined behavior.
5803
2375c96a
CY
58042012-02-19 Chong Yidong <cyd@gnu.org>
5805
5806 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5807 (Funhandled_file_name_directory, Ffile_name_as_directory)
5808 (Fdirectory_file_name, Fexpand_file_name)
5809 (Fsubstitute_in_file_name): Protect against invalid file handler
5810 return values (Bug#10845).
5811
3eb49e71
EZ
58122012-02-18 Eli Zaretskii <eliz@gnu.org>
5813
5814 * .gdbinit (pitx): Fix incorrect references to fields of the
5815 iterator stack.
5816
7b926f3f
CY
58172012-02-17 Chong Yidong <cyd@gnu.org>
5818
5819 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5820
11273115
PE
58212012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5822
5823 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5824 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5825
c3a70e2b
CY
58262012-02-15 Chong Yidong <cyd@gnu.org>
5827
5828 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5829 marked as special. Also, starting docstrings with * is obsolete.
5830
0ca43699
AS
58312012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5832
5833 * gnutls.c (emacs_gnutls_write): Fix last change.
5834
2e8f3c56
LI
58352012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5836
5837 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5838 send_process.
5839
af70074f
SM
58402012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5841
5842 * keymap.c (Fsingle_key_description): Handle char ranges.
5843
95986d52
CY
58442012-02-12 Chong Yidong <cyd@gnu.org>
5845
afd83bd1
CY
5846 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5847 as that creates a dangerous corner case.
5848
95986d52
CY
5849 * window.c (Fdelete_window_internal): Invalidate the mouse
5850 highlight (Bug#9904).
5851
bd7da63e
GM
58522012-02-12 Glenn Morris <rgm@gnu.org>
5853
5854 * xselect.c (Fx_own_selection_internal)
5855 (Fx_get_selection_internal, Fx_disown_selection_internal)
5856 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5857 * nsselect.m (Fx_own_selection_internal)
5858 (Fx_disown_selection_internal, Fx_selection_exists_p)
5859 (Fx_selection_owner_p, Fx_get_selection_internal):
5860 Sync docs and argument specs with the xselect.c versions.
5861
77abcbc2
LI
58622012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5863
5864 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5865
90b671e2
EZ
58662012-02-11 Eli Zaretskii <eliz@gnu.org>
5867
1c0ca0b7
EZ
5868 * w32select.c (Fx_selection_exists_p): Sync doc string and
5869 argument list with xselect.c. (Bug#10783)
5870
5871 * w16select.c (Fx_selection_exists_p): Sync doc string and
5872 argument list with xselect.c. (Bug#10783)
90b671e2 5873
49241268
GM
58742012-02-10 Glenn Morris <rgm@gnu.org>
5875
5876 * fns.c (Fsecure_hash): Doc fix.
5877
f998bbe7 58782012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5879
5880 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5881
0992bd9c
CY
58822012-02-07 Chong Yidong <cyd@gnu.org>
5883
5884 * buffer.c (Fbuffer_local_variables)
5885 (buffer_lisp_local_variables): Handle unbound vars correctly;
5886 don't let Qunbound leak into Lisp.
5887
af008560
GM
58882012-02-07 Glenn Morris <rgm@gnu.org>
5889
dd605cc4
GM
5890 * image.c (Fimagemagick_types): Doc fix.
5891
af008560
GM
5892 * image.c (imagemagick-render-type): Change it from a lisp object
5893 to an integer. Move the doc here from the lisp manual.
5894 Treat all values not equal to 0 the same.
5895
1449fa1d
CY
58962012-02-06 Chong Yidong <cyd@gnu.org>
5897
5898 * doc.c (store_function_docstring): Avoid applying docstring of
5899 alias to base function (Bug#2603).
5900
3723ec07
AS
59012012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5902
5903 * .gdbinit (pp1, pv1): Remove redundant defines.
5904 (pr): Use pp.
5905
79c1cc1e
CY
59062012-02-04 Chong Yidong <cyd@gnu.org>
5907
5908 * nsterm.m: Declare a global (Bug#10694).
5909
d7f29f8e
EZ
59102012-02-04 Eli Zaretskii <eliz@gnu.org>
5911
cae07000
SM
5912 * w32.c (get_emacs_configuration_options):
5913 Include --enable-checking, if specified, in the return value.
d7f29f8e 5914
3b95a6f9
MR
59152012-02-04 Martin Rudalics <rudalics@gmx.at>
5916
5917 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5918 after rounding frame sizes. (Bug#9723)
5919
d6fa96a6
EZ
59202012-02-04 Eli Zaretskii <eliz@gnu.org>
5921
5922 * keyboard.c (adjust_point_for_property): Don't position point
5923 before BEGV. (Bug#10696)
5924
df0b2940
PE
59252012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5926
5927 Handle overflow when computing char display width (Bug#9496).
5928 * character.c (char_width): Return EMACS_INT, not int.
5929 (char_width, c_string_width): Check for overflow when
5930 computing the width; this is possible now that individual
5931 characters can have unbounded width. Problem introduced
5932 by merge from Emacs 23 on 2012-01-19.
5933
6bee44d6
MA
59342012-02-02 Michael Albinus <michael.albinus@gmx.de>
5935
5936 * dbusbind.c (Fdbus_register_method): Mention the return value
5937 :ignore in the docstring.
5938
44f92739
GM
59392012-02-02 Glenn Morris <rgm@gnu.org>
5940
1b9f60cc
GM
5941 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5942
44f92739
GM
5943 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5944 Unconditionally set to t. (Bug#10673)
5945 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5946 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5947 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5948
c5d3843c
KH
59492012-02-02 Kenichi Handa <handa@m17n.org>
5950
5951 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5952 0, do not call append_composite_glyph.
5953
159462d4 59542012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5955
5956 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5957 NULL (Bug#6988).
5958 (x_produce_glyphs): If the component of a composition is a null
5959 string, set it->pixel_width to 1 to avoid zero-width glyph.
5960
78cef877
EZ
59612012-02-01 Eli Zaretskii <eliz@gnu.org>
5962
5963 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5964 first 2 arguments are identical. This makes inserting large
5965 output from a subprocess an order of magnitude faster on
5966 MS-Windows, where all sbrk'ed memory is always contiguous.
5967
97897668
GM
59682012-01-31 Glenn Morris <rgm@gnu.org>
5969
5970 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5971 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5972 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5973
31fd3586
GM
59742012-01-29 Glenn Morris <rgm@gnu.org>
5975
5976 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5977
0e24a8b2
CY
59782012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5979
5980 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5981
cc0adcb0
CY
59822012-01-28 Chong Yidong <cyd@gnu.org>
5983
5984 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5985
acc28cb9
CY
59862012-01-26 Chong Yidong <cyd@gnu.org>
5987
9c69cfb7
CY
5988 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5989
acc28cb9
CY
5990 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5991 repeat counts (Bug#10507).
5992
48da7392
GM
59932012-01-26 Glenn Morris <rgm@gnu.org>
5994
5995 * lread.c (syms_of_lread): Doc fix.
5996
14af5f7f
CY
59972012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5998
5999 * coding.c (encode_designation_at_bol): Change return value to
6000 EMACS_INT.
6001
0b21c100
CY
60022012-01-25 Chong Yidong <cyd@gnu.org>
6003
6004 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6005
3c2907f7
CY
60062012-01-21 Chong Yidong <cyd@gnu.org>
6007
6008 * floatfns.c (Fcopysign): Make the second argument non-optional,
6009 since nil is not allowed anyway.
6010
959ad23f
AS
60112012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6012
6013 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6014 (send_process): Likewise.
6015
34a02f46
MR
60162012-01-19 Martin Rudalics <rudalics@gmx.at>
6017
6018 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6019 (Vwindow_persistent_parameters): Do not use Qstate.
6020 Rewrite doc-strings.
34a02f46 6021
1259009a 60222012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6023
6024 * character.c (char_width): New function.
70d4fdf6
GM
6025 (Fchar_width, c_string_width, lisp_string_width):
6026 Use char_width (Bug#9496).
25ed9e61 6027
6a6ee00d
MR
60282012-01-16 Martin Rudalics <rudalics@gmx.at>
6029
6030 * window.c (Vwindow_persistent_parameters): New variable.
6031 (Fset_window_configuration, save_window_save): Handle persistent
6032 window parameters.
6033
c85efaf7
EZ
60342012-01-14 Eli Zaretskii <eliz@gnu.org>
6035
6036 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6037 thrashing the stack of the thread. (Bug#9087)
6038
5944709e
PE
60392012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6042
e71f5d99
EZ
60432012-01-11 Eli Zaretskii <eliz@gnu.org>
6044
6045 * xdisp.c (rows_from_pos_range): Handle the case where the
6046 highlight ends on a newline. (Bug#10464)
6047 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6048 he end column for display of highlight that ends on a newline
6049 before a R2L line.
6050
ce316182
GM
60512012-01-11 Glenn Morris <rgm@gnu.org>
6052
6053 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6054 from load-path also when installation-directory is nil. (Bug#10208)
6055
5b43da69
GM
60562012-01-10 Glenn Morris <rgm@gnu.org>
6057
74cc8ff9
GM
6058 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6059
7d8d6e4e
GM
6060 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6061 Update template values to be closer to their typical values these days.
5b43da69 6062
a0db8d43
EZ
60632012-01-09 Eli Zaretskii <eliz@gnu.org>
6064
6065 * xdisp.c (rows_from_pos_range): Accept additional argument
6066 DISP_STRING, and accept any glyph in a row whose object is that
6067 string as eligible for mouse highlight. Fixes mouse highlight of
6068 display strings from overlays. (Bug#10464)
6069
9a0115ab 60702012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6071
b9110d6a 6072 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6073 * fileio.c (auto_saving_dir_umask): New static var.
6074 (Fmake_directory_internal): Use it.
6075 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6076 creating the directory. The old code temporarily assigns
6077 too-generous permissions to the directory.
6078 (do_auto_save_eh): Clear it.
b9110d6a 6079 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6080 that the var is always cleared.
6081
6c1bd3f3
EZ
60822012-01-07 Eli Zaretskii <eliz@gnu.org>
6083
6084 * search.c (scan_buffer): Pass character positions to
6085 know_region_cache, not byte positions. (Bug#6540)
6086
069d2b50
L
60872012-01-07 LynX <_LynX@bk.ru> (tiny change)
6088
6089 * w32.c (sys_rename): Report EXDEV when rename of a directory
6090 fails because the target is on another logical disk. (Bug#10284)
6091
75bf0d33
DB
60922012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6093
6094 * xterm.c (x_embed_request_focus): New function.
6095
6096 * xterm.h: Add prototype.
6097
6098 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6099
1c6e5a32
GM
61002012-01-05 Glenn Morris <rgm@gnu.org>
6101
6102 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6103
651e947e
EZ
61042012-01-01 Eli Zaretskii <eliz@gnu.org>
6105
6106 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6107 Load gnutls_transport_set_lowat only if GnuTLS version is below
6108 2.11.1.
6109 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6110 GnuTLS versions below 2.11.1.
6111
3778cdd8
AL
61122011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6113
6114 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6115 to the doc string advising against its use for altering the way
6116 windows are scrolled.
6117
0e5317f7
KH
61182011-12-28 Kenichi Handa <handa@m17n.org>
6119
6120 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6121 coding-system ASCII compatible only when it does not produce BOM
6122 on encoding (Bug#10383).
6123
93d5ca1f
JD
61242011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6125
6126 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6127 can scroll.
6128 (create_and_show_popup_menu): Always use menu_position_func for
6129 Gtk3 (Bug#10361).
6130
ca22b785
AS
61312011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6132
6133 * callint.c (Fcall_interactively): Don't truncate prompt string.
6134
d048e1e6
EZ
61352011-12-23 Eli Zaretskii <eliz@gnu.org>
6136
6137 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6138 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6139 resumed from there (after widening). (Bug#10360)
d048e1e6 6140
5ccaba1f
JD
61412011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6142
6143 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6144
204ee57f
JD
61452011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6146
b81d40f0
JB
6147 * nsterm.m (x_free_frame_resources):
6148 Release f->output_data.ns->miniimage.
204ee57f
JD
6149 (ns_index_color): Fix indentation. Do not retain
6150 color_table->colors[i].
6151
6152 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6153 before returning.
6154
6155 * nsfns.m (x_set_background_color): Assign return value from
6156 ns_index_color to face-background instead of NSColor*.
6157 (ns_implicitly_set_icon_type): Fix indentation.
6158 Change assignment in for loop to comparison.
6159
6160 * emacs.c (ns_pool): New variable.
6161 (main): Assign ns_pool.
6162 (Fkill_emacs): Call ns_release_autorelease_pool.
6163
6164 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6165 autorelease fdesc, release fdAttrs and tdict.
6166 (ns_get_covering_families): Release charset.
6167 (ns_findfonts): Release NSFontDescriptor created with new.
6168 (ns_uni_to_glyphs): Fix indentation.
6169 (setString): Release attrStr before assigning new value.
6170
c803b2b7
JD
61712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6172
678f4426
JD
6173 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6174 and NS_IMPL_COCOA.
6175 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6176 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6177
cd394be1 61782011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6179
5fecd5fc
JD
6180 * nsterm.m (ns_term_init): Subscribe for notifications
6181 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6182 to method trackingNotification in EmacsMenu.
6183
6184 * nsmenu.m (trackingMenu): New variable.
3771cb17 6185 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6186 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6187 from Aquamacs (Bug#7030).
678f4426
JD
6188
61892011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6190
c803b2b7
JD
6191 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6192 (symbol_to_nsstring): Fix indentation.
6193 (ns_symbol_to_pb): New function.
cae07000
SM
6194 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6195 (Fns_rotate_cut_buffers_internal): Remove.
6196 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6197 Fns_store_cut_buffer_internal.
6198 (ns_get_foreign_selection, Fx_own_selection_internal)
6199 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6200 (Fns_get_selection_internal, Fns_store_selection_internal):
6201 Use ns_symbol_to_pb and check if return value is nil.
6202 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6203 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6204 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6205 renamed to Sns_store_selection_internal.
6206 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6207 and remove this function.
6208 (ns_handle_selection_clear): Remove, never used.
6209 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6210 here.
6211
e1b01a3a
KB
62122011-12-17 Ken Brown <kbrown@cornell.edu>
6213
6214 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6215 GID is unknown (Bug#10257).
6216
2adb6e85
PE
62172011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6218
6219 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6220 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6221 which caused a build failure on GNU/Linux IA-64. This problem was
6222 introduced by my 2011-10-07 patch.
6223
d1d7b339
JL
62242011-12-15 Juri Linkov <juri@jurta.org>
6225
6226 * image.c (imagemagick_error): New function. (Bug#10112)
6227 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6228 Use `imagemagick_error' where ImageMagick functions return
6229 `MagickFalse'.
6230 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6231 proper order.
6232
100d5755
KH
62332011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6234
6235 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6236 fill background (Bug#8992).
6237
454592a6
MR
62382011-12-13 Martin Rudalics <rudalics@gmx.at>
6239
6240 * window.c (Vwindow_combination_resize)
6241 (Vwindow_combination_limit): Use t instead of non-nil in
6242 doc-strings.
61d4b438
MR
6243 (Vrecenter_redisplay): Add first sentence of doc-string on
6244 separate line.
53524d93 6245 (Frecenter): Fix doc-string typo.
454592a6 6246
3633e3aa
KH
62472011-12-11 Kenichi Handa <handa@m17n.org>
6248
6249 * coding.c (Funencodable_char_position): Pay attention to the
6250 buffer text relocation (Bug#9389).
6251
7b9d523a 62522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6253
7b9d523a
JD
6254 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6255 gtk_init (Bug#10100).
6256
b73189c6
EZ
62572011-12-10 Eli Zaretskii <eliz@gnu.org>
6258
6259 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6260 IT->string is nil. (Bug#10263)
6261
f7dfe5d6
JD
62622011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6263
83faebb4
JD
6264 * nsterm.h (x_free_frame_resources): Declare.
6265
f7dfe5d6
JD
6266 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6267 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6268
6269 * nsterm.h (ns_get_defaults_value): Declare.
6270
6271 * nsterm.m (ns_default): Call ns_get_defaults_value.
6272
7cd4e72c
EZ
62732011-12-09 Eli Zaretskii <eliz@gnu.org>
6274
6275 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6276 (Bug#10170)
6277
b34d7317
YM
62782011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6279
6280 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6281 that where the value of an _OBJC_* symbol points to is in the .bss
6282 section (Bug#10240).
6283
76470ad1
KH
62842011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6285
6286 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6287 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6288
745fff94
KH
62892011-12-08 Kenichi Handa <handa@m17n.org>
6290
6291 * ftfont.c (get_adstyle_property): Fix previous change
6292 (Bug#10233).
6293
6e44397c
JB
62942011-12-07 Juanma Barranquero <lekktu@gmail.com>
6295
6296 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6297 dirs from the default value of EMACSLOADPATH (bug#10208).
6298
7efa6272
GM
62992011-12-07 Glenn Morris <rgm@gnu.org>
6300
6301 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6302 installation and source directories as well. (Bug#10208)
6303
f6fc4d87
CY
63042011-12-06 Chong Yidong <cyd@gnu.org>
6305
6306 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6307
2bf26180
GM
63082011-12-06 Glenn Morris <rgm@gnu.org>
6309
6310 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6311 as an error, not just -1. (Bug#10217)
6312
3a6ad4f0
CY
63132011-12-05 Chong Yidong <cyd@gnu.org>
6314
6315 * keyboard.c (process_special_events): New function.
6316 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6317
75a3b399
PE
63182011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6319
6320 * coding.c (encode_designation_at_bol): Don't use uninitialized
6321 local variable (Bug#9318).
6322
c3c9e25e
KH
63232011-12-05 Kenichi Handa <handa@m17n.org>
6324
6325 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6326 return Qnil (Bug#8046, Bug#10193).
6327
5eb05ea3
KH
63282011-12-05 Kenichi Handa <handa@m17n.org>
6329
6330 * coding.c (encode_designation_at_bol): New args charbuf_end and
6331 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6332 (coding_set_source): Return how many bytes coding->source was
6333 relocated.
6334 (coding_set_destination): Return how many bytes
6335 coding->destination was relocated.
6336 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6337 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6338
63392011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6340
6341 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6342 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6343 macro (Bug#9318).
6344
63452011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6346
6347 The following changes are to fix Bug#9318.
6348
a79703f5 6349 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6350 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6351 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6352 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6353
7dbda6df
JB
63542011-12-05 Juanma Barranquero <lekktu@gmail.com>
6355
6356 * lisp.h (process_quit_flag): Fix external declaration.
6357
6d5eb5b0
SM
63582011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6359
6360 Don't macro-inline non-performance-critical code.
6361 * eval.c (process_quit_flag): New function.
6362 * lisp.h (QUIT): Use it.
6363
a0c3fad0
JD
63642011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6365
6366 * nsfns.m (get_geometry_from_preferences): New function.
6367 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6368
6c07aac2
AS
63692011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6370
6371 * emacs.c (Qkill_emacs): Define.
6372 (syms_of_emacs): Initialize it.
6373 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6374 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6375 (quit_throw_to_read_char): Add parameter `from_signal'.
6376 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6377 * lisp.h (QUIT): Call Fkill_emacs if requested.
6378
c052ead4
JD
63792011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6380
6381 * widget.c (update_wm_hints): Return if wmshell is null.
6382 (widget_update_wm_size_hints): New function.
6383
6384 * widget.h (widget_update_wm_size_hints): Declare.
6385
6386 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6387 widget_update_wm_size_hints (Bug#10104).
6388
9e49252b
EZ
63892011-12-03 Eli Zaretskii <eliz@gnu.org>
6390
6391 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6392 before a newline, prepare the bidi iterator for consuming the
6393 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6394 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6395
02b16839
JL
63962011-12-02 Juri Linkov <juri@jurta.org>
6397
6398 * search.c (Fword_search_regexp): New Lisp function created from
6399 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6400 (Fword_search_backward, Fword_search_forward)
6401 (Fword_search_backward_lax, Fword_search_forward_lax):
6402 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6403 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6404
0068070e
SM
64052011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6406
6407 * fileio.c (Finsert_file_contents): Move after-change-function call
6408 to before the "handled:" label, since all "goto handled" appear in
6409 cases where the *-change-functions have already been properly called
6410 (bug#10117).
6411
3360a3fc
AS
64122011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6413
6414 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6415 waiting for input. (Bug#10169)
6416
73d6c093
EZ
64172011-11-30 Eli Zaretskii <eliz@gnu.org>
6418
6419 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6420 verifies glyph row's hash code--we have just reallocated the
6421 glyphs, so their contents can be complete garbage. (Bug#10164)
6422
febe6bea
JB
64232011-11-30 Juanma Barranquero <lekktu@gmail.com>
6424
6425 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6426
801a4313
EZ
64272011-11-30 Eli Zaretskii <eliz@gnu.org>
6428
6429 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6430 attributes are tested _before_ calling verify_row_hash, to protect
6431 against GCC re-ordering of the tests. (Bug#10164)
6432
2b56b87e
JD
64332011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6434
6435 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6436
6437 * xterm.c (handle_one_xevent): Only set async_visible and friends
6438 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6439 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6440 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6441
dbf31225
PE
64422011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6443
6444 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6445 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6446 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6447 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6448 All uses changed to use GCPRO1 etc.
6449 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6450 Revert to old implementation (i.e., before 2011-03-11).
6451
1305621b
YM
64522011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6453
6454 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6455 of scroll runs so as to avoid assigning disabled bogus rows and
6456 unnecessary graphics copy operations.
6457
8c9afb46
EZ
64582011-11-27 Eli Zaretskii <eliz@gnu.org>
6459
6460 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6461 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6462 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6463 (malloc, free, realloc, calloc): Redirect to e_* only when
6464 compiling Emacs.
6465
6466 * lisp.h (GCTYPEBITS): Move before first use.
6467 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6468 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6469 this macro definition.
6470
6471 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6472 _MSC_VER.
6473
54e9e3bf
JD
64742011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6475
6d5eb5b0
SM
6476 * gtkutil.c (xg_create_frame_widgets):
6477 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6478 present with Gtk+ 2.0.
6479
83aca1cb
PE
64802011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6481
6482 * fileio.c (Finsert_file_contents): Undo previous change; see
6483 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6484
5b76caa4
PE
64852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 Rename locals to avoid shadowing.
6488 * fileio.c (Finsert_file_contents):
6489 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6490 * process.c (wait_reading_process_output):
6491 Rename inner 'proc' to 'p' to avoid shadowing.
6492 Indent for consistency with usual Emacs style.
6493
8c535114
EZ
64942011-11-25 Eli Zaretskii <eliz@gnu.org>
6495
6496 * xdisp.c (redisplay_window): If cursor row is not fully visible
6497 after recentering, and scroll-conservatively is set to a large
6498 number, scroll window by a few more lines to make the cursor fully
6499 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6500 (start_display): Don't move to the next line if the display should
6501 start at a newline that is part of a display vector or an overlay
6502 string. (Bug#10119)
8c535114 6503
fa4fdb5c
JL
65042011-11-24 Juri Linkov <juri@jurta.org>
6505
6506 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6507 after the `MagickPingImage' call. (Bug#10112)
6508
90ec88df
CY
65092011-11-23 Chong Yidong <cyd@gnu.org>
6510
6511 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6512
56e2e794
MR
65132011-11-23 Martin Rudalics <rudalics@gmx.at>
6514
6515 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6516 making another buffer current. (Bug#10114)
6517
b6e64c41
GM
65182011-11-23 Glenn Morris <rgm@gnu.org>
6519
6520 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6521
6b21de18
CY
65222011-11-23 Chong Yidong <cyd@gnu.org>
6523
6524 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6525 using it (Bug#5984).
6526
b12cd789
EZ
65272011-11-22 Eli Zaretskii <eliz@gnu.org>
6528
6529 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6530 and header-lines, as they don't have one computed for them.
6531 (Bug#10098)
6532
6533 * .gdbinit (prow): Make displayed values more self-explaining.
6534 Add row's hash code.
6535
261b6fd4
LMI
65362011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6537
6538 * process.c (wait_reading_process_output): Fix asynchrounous
6539 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6540 (wait_reading_process_output): Add comment and URL.
261b6fd4 6541
e7cfd277
JD
65422011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6543
6544 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6545
a9b9b7f5
CY
65462011-11-21 Chong Yidong <cyd@gnu.org>
6547
6548 * window.c (Fnext_window, Fprevious_window): Doc fix.
6549
b0d15b4f
SM
65502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6551
6552 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6553
fe7a3057
JB
65542011-11-20 Juanma Barranquero <lekktu@gmail.com>
6555
6556 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6557
d2999b1a
MR
65582011-11-20 Martin Rudalics <rudalics@gmx.at>
6559
6560 * window.c (Fset_window_combination_limit): Rename argument
6561 STATUS to LIMIT.
6562 (Vwindow_combination_limit): Remove "status" from doc-string.
6563
d5ff9cd0
AS
65642011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6565
6566 * m/ibms390.h: Remove.
6567 * m/ibms390x.h: Don't include "ibms390.h".
6568
a5bb9bd3
SM
65692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6570
6571 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6572 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6573
cd1181db
JB
65742011-11-20 Juanma Barranquero <lekktu@gmail.com>
6575
6576 * casetab.c (Fset_case_table):
6577 * charset.c (Fcharset_after): Fix typos.
6578
615a3b8d 65792011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6580
17e845af
PE
6581 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6582 Otherwise, valgrind does not work on some platforms.
6583 Problem reported by Andreas Schwab in
6a0bf43d
PE
6584 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6585 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6586 is set, removing the need for VIRT_ADDRESS_VARIES.
6587 (PURE_P): Use a more-efficient implementation that needs just one
6588 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6589 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6590 to 4 (xorl, subq, cmpq, setbe).
6591 * alloc.c (pure): Always extern now, since that's the
6592 VIRT_ADDR_VARIES behavior.
6593 (PURE_POINTER_P): Use a single comparison, not two, for
6594 consistency with the new puresize.h.
6595 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6596 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6597 Remove VIRT_ADDR_VARIES no longer needed.
6598
f8fe6f96
EZ
65992011-11-19 Eli Zaretskii <eliz@gnu.org>
6600
6601 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6602 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6603 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6604 behave as if the cursor position were at the window margin.
6605
6606 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6607 and the cursor position is out of bounds, behave as if the cursor
6608 position were at the window margin. (Bug#10075)
6609
df05a53c
CY
66102011-11-18 Chong Yidong <cyd@gnu.org>
6611
6612 * window.c (Fwindow_combination_limit): Make first argument
6613 non-optional, since it is meaningless for live windows like the
6614 selected window.
61ccba97 6615
2071918e
DA
66162011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6617
6618 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6619
b50a28de
SM
66202011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6621
6622 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6623 (graft_intervals_into_buffer): Simplify.
6624
015137db
EZ
66252011-11-18 Eli Zaretskii <eliz@gnu.org>
6626
6627 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6628 hash values of the two rows.
6629 (copy_row_except_pointers): Preserve the used[] arrays and the
6630 hash values of the two rows. (Bug#10035)
68c95424 6631 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6632
6633 * xdisp.c (row_hash): New function, body extracted from
6634 compute_line_metrics.
6635 (compute_line_metrics): Call row_hash, instead of computing the
6636 hash code inline.
6637
6638 * dispnew.c (verify_row_hash): Call row_hash for computing the
6639 hash code of a row, instead of duplicating code from xdisp.c.
6640
6641 * dispextern.h (row_hash): Add prototype.
6642
a2addb04
TH
66432011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6644
6645 * frame.c (delete_frame): Don't delete the terminal when the last
6646 X frame is closed if emacs is built with GTK toolkit.
6647
df85d315
JB
66482011-11-17 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6651
a0c2d0ae
MR
66522011-11-17 Martin Rudalics <rudalics@gmx.at>
6653
6654 * window.c (Vwindow_splits): Rename to
6655 Vwindow_combination_resize. Suggested by Juri Linkov.
6656 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6657 of Vwindow_splits.
6658
58179cce
JB
66592011-11-16 Juanma Barranquero <lekktu@gmail.com>
6660
7877f373
JB
6661 * nsfns.m (Fns_font_name):
6662 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6663
b6f67890
MR
66642011-11-16 Martin Rudalics <rudalics@gmx.at>
6665
6666 * window.h (window): Rename slot "nest" to "combination_limit".
6667 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6668 (Fset_window_nest): Rename to Fset_window_combination_limit.
6669 (Vwindow_nest): Rename to Vwindow_combination_limit.
6670 (recombine_windows, make_parent_window, make_window)
6671 (Fsplit_window_internal, saved_window)
6672 (Fset_window_configuration, save_window_save): Rename all
6673 occurrences of window_nest to window_combination_limit.
6674
c7015153
JB
66752011-11-15 Juanma Barranquero <lekktu@gmail.com>
6676
6677 * image.c (imagemagick_load_image): Fix typo.
6678
322ad6ec
EZ
66792011-11-14 Eli Zaretskii <eliz@gnu.org>
6680
6681 * xdisp.c (display_line): Move the call to
6682 highlight_trailing_whitespace before the call to
6683 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6684 faces of all the glyphs to compute ROW's hash value.
6685 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6686
f067b8ec
JB
66872011-11-14 Juanma Barranquero <lekktu@gmail.com>
6688
6689 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6690 just return (bug#10044).
6691
1e5b2111
EZ
66922011-11-12 Eli Zaretskii <eliz@gnu.org>
6693
7ef3cbd5
EZ
6694 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6695 with user-defined heap size. Bump the default size of the temacs
6696 heap to 27MB, to avoid memory warning when running temacs.
6697 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6698
1e5b2111
EZ
6699 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6700 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6701 (verify_row_hash) [XASSERTS]: New function.
6702 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6703 that the hash value of glyph rows is correct.
1e5b2111 6704
89d61221
MR
67052011-11-12 Martin Rudalics <rudalics@gmx.at>
6706
6707 * window.h (window): Remove splits slot.
6708 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6709 (Fdelete_other_windows_internal, make_parent_window)
6710 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6711 (Fset_window_configuration, save_window_save): Don't deal with
6712 split status of windows.
6713 (saved_window): Remove splits slot.
6714 (Vwindow_splits): Rewrite doc-string.
6715
97f18cc8
JD
67162011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6717
6718 * xfns.c (unwind_create_frame):
6719 * nsfns.m (unwind_create_frame):
6720 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6721 Vframe_list (Bug#9999).
6722
22a648b4
DA
67232011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6724
0b381c7e 6725 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6726
659afede
KH
67272011-11-11 Kenichi Handa <handa@m17n.org>
6728
6729 * callproc.c (Fcall_process): Set the member dst_multibyte of
6730 process_coding.
6731
9ac0394b
KH
67322011-11-11 Johan Bockgård <bojohan@gnu.org>
6733
6734 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6735 avoid a crash (bug#9496).
6736
2fbdc249
CY
67372011-11-09 Chong Yidong <cyd@gnu.org>
6738
6739 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6740 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6741
ac6b1f81
PE
67422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6743
6744 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6745
09db192c
PE
67462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6747
6748 Avoid some portability problems by eschewing 'extern inline' functions.
6749 The trivial performance wins aren't worth the portability hassles; see
6750 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6751 et seq.
6752 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6753 (window_box_width, window_box_left, window_box_left_offset)
6754 (window_box_right, window_box_right_offset): Undo previous change,
6755 by removing the "extern"s.
6756 * intervals.c (adjust_intervals_for_insertion)
6757 (adjust_intervals_for_deletion): Undo previous change,
6758 making these static again.
6759 (offset_intervals, temp_set_point_both, temp_set_point)
6760 (copy_intervals_to_string): No longer inline.
6761 * xdisp.c (window_text_bottom_y, window_box_width)
6762 (window_box_height, window_box_left_offset)
6763 (window_box_right_offset, window_box_left, window_box_right)
6764 (window_box): No longer inline.
6765
105216ed
CY
67662011-11-08 Chong Yidong <cyd@gnu.org>
6767
6768 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6769 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6770 Signal an error if not a live window.
105216ed
CY
6771 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6772 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6773
ae9e237f
JB
67742011-11-07 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * lisp.h (syms_of_abbrev): Remove declaration.
6777 Reported by CHENG Gao <chenggao@royau.me>.
6778
c7aa8333
EZ
67792011-11-07 Eli Zaretskii <eliz@gnu.org>
6780
6781 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6782 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6783 of temacs in GUI mode.
6784
be7f5545
MR
67852011-11-07 Martin Rudalics <rudalics@gmx.at>
6786
6787 * window.h: Declare delete_all_child_windows instead of
6788 delete_all_subwindows.
6789 * window.c (Fwindow_nest, Fset_window_nest)
6790 (Fset_window_new_total, Fset_window_new_normal)
6791 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6792 (delete_all_subwindows): Rename to delete_all_child_windows.
6793 (Fdelete_other_windows_internal, Fset_window_configuration):
6794 Call delete_all_child_windows instead of delete_all_subwindows.
6795 * frame.c (delete_frame): Call delete_all_child_windows instead
6796 of delete_all_subwindows.
6797
ca78dc43
PE
67982011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6799
6800 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6801 This is also needed for porting to any host where GC_MARK_STACK is
6802 not GC_MAKE_GCPROS_NOOPS.
6803 (which_symbols): Use it.
6804
a0241d01
KH
68052011-11-07 Kenichi Handa <handa@m17n.org>
6806
6807 * coding.c (coding_set_destination): Check coding->src_pos only
6808 when coding->src_object is a buffer (bug#9910).
6809
6810 * process.c (send_process): Set the member src_multibyte of coding
6811 to 0 (bug#9911) when sending a unibyte text.
6812
6813 * callproc.c (Fcall_process): Set the member src_multibyte of
6814 process_coding to 0 (bug#9912).
6815
a64bfdfa 68162011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6817
6818 * xmenu.c (cleanup_widget_value_tree): New function.
6819 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6820 calling free_menubar_widget_value_tree directly (Bug#9830).
6821
cb41b32a
PE
68222011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6823
6824 Fix some portability problems with 'inline'.
6825 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6826 (window_box_width, window_box_left, window_box_left_offset)
6827 (window_box_right, window_box_right_offset): Declare extern.
6828 Otherwise, these inline functions do not conform to C99 and
6829 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6830 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6831 * intervals.c (adjust_intervals_for_insertion)
6832 (adjust_intervals_for_deletion): Now extern, because otherwise the
6833 extern inline functions 'offset_intervals' couldn't refer to it.
6834 (static_offset_intervals): Remove.
6835 (offset_intervals): Rewrite using the old contents of
6836 static_offset_intervals. The old version didn't conform to C99
6837 because an extern inline function contained a reference to an
6838 identifier with static linkage.
6839
b7041366
AS
68402011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6841
6842 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6843 GC.
6844
88a37c4d
EZ
68452011-11-06 Eli Zaretskii <eliz@gnu.org>
6846
6847 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6848 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6849 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6850 return Qleft_to_right.
6851
49745b39
CY
68522011-11-06 Chong Yidong <cyd@gnu.org>
6853
6854 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6855 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6856 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6857 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6858 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6859 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6860 (Fwindow_vscroll): Doc fix.
6861 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6862 argument, since it makes no sense to pass a live window and for
6863 consistency with window-child.
6864
1f05cd82
CS
68652011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6866
6867 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6868 support MSVC.
6869
22610910
JR
68702011-11-05 Jason Rumney <jasonr@gnu.org>
6871
6872 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6873 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6874 fonts (Bug#6029).
6875 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6876 bitwise arithmetic preventing use of unicode-sip and non-truetype
6877 opentype fonts.
6878
a06776b2
EZ
68792011-11-05 Eli Zaretskii <eliz@gnu.org>
6880
3ad924ba
EZ
6881 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6882 "emacs"-only part.
6883
a06776b2
EZ
6884 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6885 initialization code to keep similarity to xfns.c after changes
6886 from 2011-11-05.
6887
c9e7db78
JD
68882011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6889
a97f8f3f
JD
6890 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6891 (unwind_create_frame): New function (Bug#9943).
6892 (Fx_create_frame): Restructure code to be more similar to the one in
6893 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6894 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6895 Move terminal->reference_count++ just before making the frame official
6896 (Bug#9943).
6897
6898 * nsterm.m (x_free_frame_resources): New function.
6899 (x_destroy_window): Move code to x_free_frame_resources.
6900
c9e7db78 6901 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6902 (Fx_create_frame, x_create_tip_frame):
6903 Move terminal->reference_count++ just before making the frame
75f1671a 6904 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6905 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6906
a6fc3b5c
EZ
69072011-11-05 Eli Zaretskii <eliz@gnu.org>
6908
6909 Support MSVC build with newer versions of Visual Studio.
6910 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6911 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6912 nt/gmake.defs.
6913
6914 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6915 which are not supported by MSVC.
6916 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6917 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6918 bitfields.
6919 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6920 types in bitfields.
6921 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6922
6923 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6924
58179cce 69252011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6926
6927 Support MSVC build with newer versions of Visual Studio.
6928 * w32.c: Don't include w32api.h for MSVC.
6929 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6930
6931 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6932 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6933 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6934 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6935 e_* cousins.
6936 (alloca) [_MSC_VER]: Define to _alloca.
6937
6938 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6939
6940 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6941
a58c13ed
EZ
69422011-11-04 Eli Zaretskii <eliz@gnu.org>
6943
6944 * xdisp.c (note_mouse_highlight): If either of
6945 previous/next-single-property-change returns nil, treat that as
6946 the beginning or the end of the buffer. (Bug#9955)
6947
fe0b6370
JD
69482011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6949
a58c13ed 6950 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6951 label is not null (Bug#9951).
6952 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6953 may be NULL.
6954
89bd5ee1
EZ
69552011-11-04 Eli Zaretskii <eliz@gnu.org>
6956
6957 * window.c (Fwindow_body_size): Mention in the doc string that the
6958 return value is in frame's canonical units. (Bug#9949)
6959
84c3edb9
EZ
69602011-11-03 Eli Zaretskii <eliz@gnu.org>
6961
4e2fb5c7
EZ
6962 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6963
84c3edb9 6964 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6965 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6966 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6967
bc17a887
EZ
69682011-11-01 Eli Zaretskii <eliz@gnu.org>
6969
6970 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6971 Don't stop backward scan on the continuation glyph, even though
6972 its CHARPOS is positive.
6d5eb5b0
SM
6973 (mouse_face_from_buffer_pos, note_mouse_highlight):
6974 Rename cover_string to disp_string.
bc17a887 6975
4ee88440
MR
69762011-11-01 Martin Rudalics <rudalics@gmx.at>
6977
6978 * window.c (temp_output_buffer_show): Don't use
6979 Vtemp_buffer_show_specifiers.
6980 (Vtemp_buffer_show_specifiers): Remove unused variable.
6981
c2ff3c02
EZ
69822011-10-30 Eli Zaretskii <eliz@gnu.org>
6983
6984 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6985 past the beginning of the current glyph matrix.
6986
58179cce 69872011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6988
6989 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6990 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6991 HAVE_GTK3 (Bug#9869).
b77a6a7f 6992
3b574623
JD
6993 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6994 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6995
b77a6a7f
JD
6996 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6997
6998 * xterm.c: Declare x_handle_net_wm_state to return int.
6999 (handle_one_xevent): Check if we are iconified but don't have
7000 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7001 (get_current_wm_state): Return non-zero if not hidden,
7002 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7003 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7004 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7005 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7006
196e41e4
PE
70072011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7008
7009 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7010 so that this new function doesn't get optimized away by a
7011 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7012
021f2e1a
AS
70132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7014
7015 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7016
8b058d44
EZ
70172011-10-29 Eli Zaretskii <eliz@gnu.org>
7018
7019 Fix the `xbytecode' command.
7020 * .gdbinit (xprintbytestr): New command.
b50a28de 7021 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7022 (xbytecode): Print the byte-code string as well.
7023
4452fb80
EZ
70242011-10-29 Kim Storm <storm@cua.dk>
7025
8b058d44
EZ
7026 * alloc.c (which_symbols): New function.
7027
21b72067
AS
70282011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7029
7030 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7031 line. (Bug#9903)
7032
83ed7b5c
GM
70332011-10-29 Glenn Morris <rgm@gnu.org>
7034
7035 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7036 Not clear what it was for, and it causes various bugs. (Bug#9839)
7037
5a7a728b
EZ
70382011-10-28 Eli Zaretskii <eliz@gnu.org>
7039
7040 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7041 possible random value that matches one of those tested as
7042 condition to clear the mouse face.
7043
d3d0842f
CY
70442011-10-28 Chong Yidong <cyd@gnu.org>
7045
7046 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7047
31b39d13
DN
70482011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7049
7050 * window.c (make_window): Initialize phys_cursor_on_p.
7051
9aba6043
SM
70522011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7053
7054 * lisp.h (struct Lisp_Symbol): Update comments.
7055
c20992f4
JB
70562011-10-28 Juanma Barranquero <lekktu@gmail.com>
7057
7058 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7059
db4f02f2
EZ
70602011-10-28 Eli Zaretskii <eliz@gnu.org>
7061
7062 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7063 <oslsachem@gmail.com> for helping to debug this.
7064
7065 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7066 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7067 (g_b_init_get_glyph_outline_w): New static variables.
7068 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7069 (GetGlyphOutlineW_Proc): New typedefs.
7070 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7071 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7072 New functions.
7073 (w32font_open_internal, compute_metrics):
7074 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7075 instead of calling the "wide" APIs directly.
7076
7077 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7078
7079 * w32.h (syms_of_w32font): Add prototype.
7080
87e68db4
JB
70812011-10-27 Juanma Barranquero <lekktu@gmail.com>
7082
7083 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7084 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7085 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7086 (Fmove_to_window_line): Doc fix.
7087
435c1d67
CY
70882011-10-27 Chong Yidong <cyd@gnu.org>
7089
7090 * process.c (make_process): Set gnutls_state to NULL.
7091
7092 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7093 non-NULL, regardless of GNUTLS_INITSTAGE.
7094 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7095 an error. Set process slots as soon as we allocate them.
7096
7097 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7098
9c6c6f49
CY
70992011-10-27 Chong Yidong <cyd@gnu.org>
7100
9aba6043
SM
7101 * gnutls.c (emacs_gnutls_deinit): New function.
7102 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7103 (Fgnutls_deinit, Fgnutls_boot): Use it.
7104
7105 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7106 (deactivate_process): Call emacs_gnutls_deinit.
7107
657d08d3
JB
71082011-10-27 Juanma Barranquero <lekktu@gmail.com>
7109
7110 * image.c (x_create_x_image_and_pixmap):
7111 * w32.c (sys_rename, w32_delayed_load):
7112 * w32font.c (fill_in_logfont):
7113 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7114
5430d399
JB
71152011-10-26 Juanma Barranquero <lekktu@gmail.com>
7116
7117 * w32fns.c (w32_default_color_map): New function,
7118 extracted from Fw32_default_color_map.
a7ef684b 7119 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7120
fe0055fa
PE
71212011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7124
e6346438
SM
71252011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7126
7127 * keyboard.c (test_undefined): New function (bug#9751).
7128 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7129
e112cc37
ET
71302011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7131
7132 * sysdep.c (init_sys_modes): Fix the check for the controlling
7133 terminal (Bug#6649).
7134
7b5d6677
EZ
71352011-10-20 Eli Zaretskii <eliz@gnu.org>
7136
7137 * dispextern.h (struct bidi_it): New member next_en_type.
7138
7139 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7140 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7141 current character, check also for next_en_type being WEAK_EN.
7142 (bidi_resolve_weak): Don't enter the expensive loop if the current
7143 position is before next_en_pos. Record the bidi type of the first
7144 non-ET, non-BN character we find, in addition to its position.
7145 (bidi_level_of_next_char): Invalidate next_en_type when
7146 next_en_pos is over-stepped.
7147
7da0b018
PE
71482011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7149
7150 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7151 * editfns.c: Rewrite current-time-zone so that it invokes
7152 the equivalent of (format-time-string "%Z") to get the time zone name.
7153 This fixes a bug when the time zone name contains characters that
7154 need converting from the system time locale to Emacs internal format.
7155 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7156 that patch fixed format-time-string to do the conversion, but
7157 I forgot to fix current-time-zone.
7158 (format_time_string): New function, containing most of
7159 what Fformat_time_string used to contain.
7160 (Fformat_time_string): Rewrite in terms of format_time_string.
7161 This doesn't change this function's behavior.
7162 (current-time-zone): Rewrite to use format_time_string.
7163 This fixes the bug reported by Michael Schierl in
7164 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7165 Jason Rumney's 2007-06-07 change worked around this bug, but
7166 didn't fix it.
7167 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7168
8547b010
EZ
71692011-10-19 Eli Zaretskii <eliz@gnu.org>
7170
7171 * xdisp.c (start_display): If the character at POS is displayed
7172 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7173 (try_window_reusing_current_matrix): If a line ends in a display
7174 vector or the next line starts in a display vector, continue
7175 redrawing the window even though the character position of
7176 start_row was reached.
8547b010
EZ
7177 (Bug#9771, part 2)
7178
4e948d15
CY
71792011-10-18 Chong Yidong <cyd@gnu.org>
7180
7181 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7182 with nobreak-char-display too.
7183
4787455f
EZ
71842011-10-18 Eli Zaretskii <eliz@gnu.org>
7185
7186 Fix part 3 of bug#9771.
7187 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7188 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7189 non-neutral characters if the current character is a paragraph
7190 separator (a.k.a. Newline). This avoids running the same
7191 expensive loop twice, once when we consume the preceding newline
7192 and the other time when the line actually needs to be displayed.
7193 Avoid the loop when we see neutrals on the base embedding level
7194 following a character whose directionality is the same as the
7195 paragraph's. This avoids running the expensive loop when a line
7196 ends in a long sequence of neutrals, like control characters.
7197 Add assertion against STRONG_AL type. Slightly rearrange code
7198 that determines the type of a neutral given the first non-neutral
7199 that follows it.
7200 (bidi_level_of_next_char): Set next_en_pos to zero when
7201 invalidating its info.
7202
2c91f553
EZ
72032011-10-17 Eli Zaretskii <eliz@gnu.org>
7204
7205 * xdisp.c (push_display_prop): Determine whether to record string
7206 or buffer position by IT->string, not by IT->method. Allow
7207 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7208 (move_it_vertically_backward): Don't look for character position
7209 immediately after the newline when in a continuation line.
7210 (Bug#9771, part 1)
2c91f553 7211
c7b08b0d
MR
72122011-10-15 Martin Rudalics <rudalics@gmx.at>
7213
7214 * window.c (coordinates_in_window): Rewrite and delabelize
7215 vertical border check. (Bug#5357) (Bug#9618)
7216
6b02f655
SM
72172011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7218
7219 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7220 errors in XSetWindowBorder (bug#9310).
7221
81d40c92
DA
72222011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7223
7224 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7225 avoid crash when xmalloc overrun checking is enabled.
7226
d4172c3b
EZ
72272011-10-13 Eli Zaretskii <eliz@gnu.org>
7228
7229 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7230 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7231 cursor motion with <left> and <right> arrow keys.
7232
7233 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7234 some callers set that themselves.
7235
b00eea75
EZ
72362011-10-12 Eli Zaretskii <eliz@gnu.org>
7237
7238 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7239 display string and the previous row comes from the same string and
7240 is empty. (Bug#9739) (Bug#9738)
7241
8fe012c4
SM
72422011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7243
7244 * doc.c (get_doc_string): Encode file name (bug#9735).
7245
0074aef2
EZ
72462011-10-12 Eli Zaretskii <eliz@gnu.org>
7247
79beb178
EZ
7248 * bidi.c (bidi_level_of_next_char):
7249 * xdisp.c (get_visually_first_element): Remove old incorrect
7250 comments regarding the Unicode Line Separator character.
7251
0074aef2
EZ
7252 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7253
6e4b3fbe
DA
72542011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7255
7256 * alloc.c (Fgc_status): Do not access beyond zombies array
7257 boundary if nzombies > MAX_ZOMBIES.
7258 * alloc.c (dump_zombies): Add missing format specifier.
7259
0324f3af
PE
72602011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7261
b5525cac
PE
7262 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7263 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7264
0324f3af
PE
7265 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7266 Some packages use them to denote characters with modifiers.
7267
e9b5f888
AS
72682011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7269
7270 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7271 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7272 matching a pp-number. Rename parameter var to var1.
7273
127827c0
SM
72742011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7275
7276 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7277
c8fd3bd0
GM
72782011-10-08 Glenn Morris <rgm@gnu.org>
7279
7280 * callint.c (Fcall_interactively): Give a more explicit error for the
7281 'c' case with a non-character input. (Bug#8479)
7282
352ec8ff
EZ
72832011-10-08 Eli Zaretskii <eliz@gnu.org>
7284
03669ccb
EZ
7285 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7286 lines.
7061c986
EZ
7287 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7288 lines that are hscrolled on the left.
03669ccb 7289
352ec8ff
EZ
7290 * dispnew.c (buffer_posn_from_coords): Account for a possible
7291 presence of header-line. (Bug#4426)
7292
a66cfb1c
SM
72932011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7294
6b02f655
SM
7295 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7296 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7297
7c5ee88e
PE
72982011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7299
7300 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7301 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7302 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7303 this makes Emacs dump core during garbage collection on rare
7304 occasions. sizeof is obviously inferior to offsetof here, so
7305 stick with offsetof.
7306 (GC_POINTER_ALIGNMENT): New macro.
7307 (mark_memory): Omit 3rd (offset) arg; caller changed.
7308 Don't assume EMACS_INT alignment is the same as pointer alignment.
7309
df1bbe5b
SM
73102011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7311
7312 * keyboard.c (read_key_sequence_remapped): New var.
7313 (read_key_sequence): Compute remapping in the right buffer.
7314 (command_loop_1): Use read_key_sequence's remapping directly.
7315
51553db6
SM
73162011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7317
32c1fffd
SM
7318 * dired.c (file_name_completion): Don't expand file name.
7319 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7320 before checking file name handler.
7321
51553db6
SM
7322 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7323 they've been requested explicitly (bug#9591).
7324
b6bd1599 73252011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7326
7327 * keymap.c (Fsingle_key_description): Use make_specified_string
7328 instead of build_string to build string from push_key_description.
7329 (Bug#5193)
7330
f701dc2a
PE
73312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7332
4222c55d
PE
7333 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7334 This fixes a Y2038 bug on 64-bit hosts.
7335 * buffer.c (reset_buffer):
7336 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7337 (Fclear_buffer_auto_save_failure):
7338 Use 0, not -1, to represent an unset failure time, since time_t
7339 might not be signed.
7340
f701dc2a
PE
7341 Remove dependency on glibc malloc internals.
7342 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7343 Move back here from lisp.h, but with their new implementations.
7344 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7345 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7346 * charset.c (charset_table_init): New static var.
7347 (syms_of_charset): Use it instead of xmalloc. This removes a
7348 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7349 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7350 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7351 Move back to alloc.c.
7352 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7353 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7354
9ceebf39
JD
73552011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7356
7357 * nsterm.m (windowDidResize): Call x_set_window_size only when
7358 ns_in_resize is true. Otherwise set pixelwidth/height and
7359 call change_frame_size (Bug#9628).
7360
cb993c58
PE
73612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7362
3930c88b
PE
7363 Port --enable-checking=all to Fedora 14 x86-64.
7364 * charset.c (syms_of_charset): Also account for glibc malloc's
7365 internal overhead when calculating the initial malloc maximum.
7366
cb993c58
PE
7367 Port --enable-checking=all to Fedora 14 x86.
7368 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7369 Move to lisp.h.
7370 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7371 (overrun_check_realloc, overrun_check_free):
7372 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7373 That way, xmalloc returns a properly-aligned pointer even if
7374 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7375 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7376 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7377 into account when calculating the initial malloc maximum.
7378 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7379 Move here from alloc.c, so that charset.c can use it too.
7380 Properly align; the old code wasn't right for common 32-bit hosts
7381 when configured with --enable-checking=all.
7382 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7383 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7384
31bed486
EZ
73852011-09-29 Eli Zaretskii <eliz@gnu.org>
7386
04c70788 7387 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7388 use EDOM.
7389
fbcaa2f3
EZ
73902011-09-28 Eli Zaretskii <eliz@gnu.org>
7391
7392 * xdisp.c (compute_display_string_end): If there's no display
7393 string at CHARPOS, return -1.
7394
7395 * bidi.c (bidi_fetch_char): When compute_display_string_end
7396 returns a negative value, treat the character as a normal
7397 character not covered by a display string. (Bug#9624)
7398
a239d4e9
JB
73992011-09-28 Juanma Barranquero <lekktu@gmail.com>
7400
7401 * lread.c (Fread_from_string): Fix typo in docstring.
7402
88652fd5
EZ
74032011-09-27 Eli Zaretskii <eliz@gnu.org>
7404
7405 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7406 newline, reseat the iterator instead of bidi-iterating there one
7407 character at a time. (Bug#9610)
32c1fffd
SM
7408 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7409 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7410
ed497dd4
AS
74112011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7412
7413 * lread.c (readevalloop): Use correct code for NBSP.
7414 (read1): Likewise. (Bug#9608)
7415
b2bf61aa
MA
74162011-09-25 Michael Albinus <michael.albinus@gmx.de>
7417
7418 * dbusbind.c (Fdbus_register_signal): When service is not
7419 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7420
32bbb17c
GM
74212011-09-25 Glenn Morris <rgm@gnu.org>
7422
7423 * buffer.c (truncate-lines): Doc fix.
7424
94e0933e
CY
74252011-09-24 Chong Yidong <cyd@stupidchicken.com>
7426
7427 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7428 (Fset_window_next_buffers): Doc fix.
7429
cddde921
GM
74302011-09-24 Glenn Morris <rgm@gnu.org>
7431
7432 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7433
1260aef1
PE
74342011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7435
25b4bfa0
PE
7436 Fix minor problems found by static checking.
7437 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7438 * indent.c (Fvertical_motion): Fix == vs = typo.
7439
e3cbd34b
EZ
74402011-09-24 Eli Zaretskii <eliz@gnu.org>
7441
a66cfb1c
SM
7442 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7443 Default value is now t. Doc fix.
6bf7006f 7444
e3cbd34b 7445 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7446 logic when moving up, not only when moving down. Fix the
e3cbd34b 7447 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7448 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7449
7450 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7451 CHARPOS is covered by a display string which includes newlines.
7452 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7453 is covered by a display string with embedded newlines.
7454
a3de0cbd
MA
74552011-09-24 Michael Albinus <michael.albinus@gmx.de>
7456
7457 * dbusbind.c (Fdbus_register_signal): Add match rule to
7458 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7459 (Fdbus_register_method, Vdbus_registered_objects_table):
7460 Fix docstring.
a3de0cbd 7461
b260039d
JM
74622011-09-24 Jim Meyering <meyering@redhat.com>
7463
32c1fffd 7464 do not ignore write error for any output size
b260039d
JM
7465 The previous change was incomplete.
7466 While it makes emacs --batch detect the vast majority of stdout
7467 write failures, errors were still ignored whenever the output size is
7468 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7469 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7470 && echo FAIL: ignored write error
7471 FAIL: ignored write error
7472 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7473 && echo FAIL: ignored write error
7474 FAIL: ignored write error
7475 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7476
8eca8a7c
AS
74772011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7478
7479 * emacs.c (Fkill_emacs): In noninteractive mode exit
7480 non-successfully if a write error occurred on stdout. (Bug#9574)
7481
3341db62
EZ
74822011-09-21 Eli Zaretskii <eliz@gnu.org>
7483
7484 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7485 the xassert test.
7486
7487 * dispextern.h (struct it): Update the comment documenting what
7488 can it->OBJECT be.
7489
8c203dbf
EZ
74902011-09-20 Eli Zaretskii <eliz@gnu.org>
7491
7492 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7493 a display string, extend search for cursor position to end of row.
7494 (find_row_edges): If the row ends in a newline from a display
7495 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7496 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7497 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7498 non-empty line. Fixes confusing cursor motion with arrow keys at
7499 the beginning of a line that starts with whitespace.
8c203dbf 7500
a4824228
LMI
75012011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7502
7503 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7504 (bug#9493).
7505
33ed493b
CY
75062011-09-18 Chong Yidong <cyd@stupidchicken.com>
7507
7508 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7509 boolean (Bug#9154).
7510
56cd55c8
EZ
75112011-09-18 Eli Zaretskii <eliz@gnu.org>
7512
7513 * xdisp.c (display_line): Record maximum and minimum buffer
7514 positions even if no glyphs were produced (e.g., by a zero-width
7515 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7516 buffer positions that will be removed from the glyph row because
7517 they don't fit.
c02dcedf
EZ
7518 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7519 column is beyond frame width: don't subtract 1 "pixel" when
7520 computing width of the stretch.
3e62b7e0
EZ
7521 (reseat_at_next_visible_line_start): Undo the change made on
7522 2011-09-17 that saved paragraph information and restored it after
7523 the call to `reseat'. (Bug#9545)
56cd55c8 7524
5ed99d36 75252011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7526
7527 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7528 and turn window cursor on if cleared (Bug#9415).
7529
5ed99d36 75302011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7531
7532 * search.c (boyer_moore): Take unibyte characters from pattern
7533 literally. (Bug#9458)
7534
9bade7b2
EZ
75352011-09-18 Eli Zaretskii <eliz@gnu.org>
7536
7537 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7538
e5e9d610
PE
75392011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7540
87e4427a
PE
7541 Fix minor problem found by static checking.
7542 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7543 initialized, to pacify gcc -Wuninitialized.
7544
e5e9d610
PE
7545 * fileio.c: Report proper errno when syscall falls.
7546 (Finsert_file_contents): Save and restore errno,
7547 so that report_file_error outputs the correct diagnostic.
7548 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7549
a1674f0b
EZ
75502011-09-18 Eli Zaretskii <eliz@gnu.org>
7551
7552 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7553
fbfb6dd4
EZ
75542011-09-17 Eli Zaretskii <eliz@gnu.org>
7555
7556 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7557 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7558
bb187662
EZ
75592011-09-17 Eli Zaretskii <eliz@gnu.org>
7560
1137e8b8 7561 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7562 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7563
7564 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7565 (bidi_find_paragraph_start): Search back for paragraph beginning
7566 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7567 (bidi_move_to_visually_next): Only trigger paragraph-related
7568 computations when the last character is a newline or at EOB, not
7569 just any NEUTRAL_B. (Bug#9470)
7570
bb187662
EZ
7571 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7572 truncated lines if point is covered by a display string. (Bug#9524)
7573
2e621251
PE
75742011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7575
7576 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7577 (cons_to_x_long): New function.
7578 (lisp_data_to_selection_data): Use it. Correct the test for
7579 short-versus-long data; it was negated. Break out of vector
7580 loop, for efficiency, when a long datum is discovered.
7581
91a15bc6
SM
75822011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7583
7584 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7585
b41c3a35
EZ
75862011-09-16 Eli Zaretskii <eliz@gnu.org>
7587
7588 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7589 GCC PR/17406) by declaring this function with external scope.
7590
7812ba2d
PE
75912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7592
7593 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7594 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7595
cf7edc2a
AS
75962011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7597
7598 * editfns.c (Fformat): Correctly handle text properties on "%%".
7599
bd01620e
EZ
76002011-09-15 Eli Zaretskii <eliz@gnu.org>
7601
7602 * xterm.c (x_draw_composite_glyph_string_foreground):
7603 * w32term.c (x_draw_composite_glyph_string_foreground):
7604 * term.c (encode_terminal_code):
7605 * composite.c (composition_update_it, get_composition_id):
7606 * xdisp.c (get_next_display_element)
7607 (fill_composite_glyph_string): Add comments about special meaning
7608 of TAB characters in a composition.
7609
a02719a3
PE
76102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7611
7612 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7613 This occurs when processing a multibyte format.
7614 Problem reported by Wolfgang Jenker.
a02719a3 7615
72589a3c
JB
76162011-09-15 Johan Bockgård <bojohan@gnu.org>
7617
7618 * xdisp.c (try_cursor_movement): Only check for exact match if
7619 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7620
1c14176c
PE
76212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7622
7623 Remove unused external symbols.
7624 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7625 * xdisp.c (calc_pixel_width_or_height): Now static.
7626 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7627 * indent.c (check_display_width):
7628 * w32term.c: Fix comment to match code.
7629 * xterm.c, xterm.h (x_catching_errors): Remove.
7630
d2eea5b5
PE
76312011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7632
7633 * xselect.c: Use signed conversions more consistently (Bug#9498).
7634 (selection_data_to_lisp_data): Assume incoming selection data are
7635 signed integers, not unsigned. This is to be consistent with
7636 outgoing selection data, which was modified to use signed integers
7637 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7638 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7639 expects long, not unsigned long.
7640
46888499
EZ
76412011-09-14 Eli Zaretskii <eliz@gnu.org>
7642
7643 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7644 computation of loop end. Reported by Johan Bockgård
7645 <bojohan@gnu.org>.
7646
ef8ef9fb
CY
76472011-09-13 Chong Yidong <cyd@stupidchicken.com>
7648
7649 * frame.c (Fother_visible_frames_p): Function deleted.
7650
fa819fed
EZ
76512011-09-12 Eli Zaretskii <eliz@gnu.org>
7652
7653 * indent.c (compute_motion): Process display vector front to back
7654 rather than the other way around. (Bug#2496)
7655
2ba8e008
SM
76562011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7657
7658 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7659
20f53c69
CY
76602011-09-11 Chong Yidong <cyd@stupidchicken.com>
7661
7662 * minibuf.c (Fread_from_minibuffer): Doc fix.
7663
d562d7a4
EZ
76642011-09-11 Eli Zaretskii <eliz@gnu.org>
7665
7666 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7667 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7668
1c4d7f3d
LMI
76692011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7670
7671 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7672 value for non-existent files.
7673
b885bf36
EZ
76742011-09-11 Eli Zaretskii <eliz@gnu.org>
7675
7676 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7677 set its "size" to -1. This will set the modtime_size field of
7678 the corresponding buffer to -1, which is what
7679 verify-visited-file-modtime expects for files that do not exist.
7680 (Bug#9139)
7681
6612f0bf
PE
76822011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7683
7684 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7685 here ...
7686 * lisp.h: ... from here. push_key_description is no longer
7687 defined in keyboard.c, so its declaration should not be in
7688 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7689 logically belongs with push_key_description.
7690
dfb3f755
PE
76912011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7692
7693 * buffer.h: Include <sys/types.h> instead of <time.h>.
7694 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7695 Problem reported by Herbert J. Skuhra.
7696
3134906c
LMI
76972011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7698
7699 * xml.c (parse_region): Make the parsing work for
7700 non-comment-starting XML files again (bug#9144).
7701
8d903f4e
AS
77022011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7703
7704 * image.c (gif_load): Fix calculation of bottom and right corner.
7705 (Bug#9468)
7706
80ad64f4
EZ
77072011-09-10 Eli Zaretskii <eliz@gnu.org>
7708
7709 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7710 redisplay in small windows.
7711
208a048d
EZ
77122011-09-09 Eli Zaretskii <eliz@gnu.org>
7713
7714 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7715
9b1c252e
MR
77162011-09-08 Martin Rudalics <rudalics@gmx.at>
7717
7718 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7719 Operate on live windows only.
7720
2949f33b
JB
77212011-09-08 Juanma Barranquero <lekktu@gmail.com>
7722
7723 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7724
e08dcafd
EZ
77252011-09-07 Eli Zaretskii <eliz@gnu.org>
7726
7727 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7728 only under bidi iteration.
7729
115b96bd
JD
77302011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7731
7732 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7733
c8199d0f
PE
77342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7735
7736 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7737 Without this fix, the command to link temacs failed due to an
7738 undefined symbol __builtin_isnan. This is because
7739 /usr/include/iso/math_c99.h #defines isnan(x) to
7740 __builtin_isnan(x), but the bundled gcc, which identifies itself
7741 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7742 a __builtin_isnan.
7743 * floatfns.c (isnan): #undef, and then #define to a clone of
7744 what's in data.c.
7745 (Fisnan): Always define, since it's always available now.
7746 (syms_of_floatfns): Always define isnan at the Lisp level.
7747
e39b275c 77482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7749
7750 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7751
b2db44d9 77522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7753
f4af5137 7754 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7755 The previous code assumed that file offsets (off_t values) fit in
7756 EMACS_INT variables, which is not true on typical 32-bit hosts.
7757 The code messed up by falsely reporting buffer overflow in cases
7758 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7759 when "big" contains more than 2**29 bytes, even though this
7760 inserts just one byte and does not overflow the buffer.
7761 (Finsert_file_contents): Store file offsets as off_t
7762 values, not as EMACS_INT values. Check for overflow when
7763 converting between EMACS_INT and off_t. When checking for
7764 buffer overflow or for overlap, take the offsets into account.
7765 Don't use EMACS_INT for small values where int suffices.
7766 When checking for overlap, fix a typo: ZV was used where
7767 ZV_BYTE was intended.
7768 (Fwrite_region): Don't assume off_t fits into 'long'.
7769 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7770
ecfc0a49
MA
77712011-09-05 Michael Albinus <michael.albinus@gmx.de>
7772
7773 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7774
6511acf2 77752011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7776
0999621a 7777 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7778
7779 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7780 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7781 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7782 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7783 (modify_event_symbol): Do not assume that the length of
7784 name_alist_or_stem is safe to alloca and fits in int.
7785 (Fexecute_extended_command): Likewise for function name and binding.
7786 (Frecursion_depth): Wrap around reliably on integer overflow.
7787 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7788 since some callers pass EMACS_INT values.
7789 (Fsingle_key_description): Don't crash if symbol name contains more
7790 than MAX_ALLOCA bytes.
7791 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7792 (get_minibuffer): Arg is now EMACS_INT, not int.
7793 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7794 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7795 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7796
2be7d702
PE
7797 * dbusbind.c (signature_cat): New function.
7798 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7799 Do not overrun buffer; instead, report string overflow.
7800
9d1df220
PE
7801 * dispnew.c (add_window_display_history): Don't overrun buffer.
7802 Truncate instead; this is OK since it's just a log.
7803
33ef5c64
PE
7804 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7805 even if the time zone offset is outlandishly large.
7806 Don't mishandle offset == INT_MIN.
7807
66c6fdd5
PE
7808 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7809 when creating daemon; the previous buffer-overflow check was incorrect.
7810
d749b01b
PE
7811 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7812 which has the guts of the old verror function.
7813
b5cd1905
PE
7814 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7815 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7816
6e1a67fb
PE
7817 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7818 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7819 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7820 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7821 length of string rather than counting it via multiple sprintfs;
7822 that's simpler and more reliable.
c21721cc
PE
7823 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7824 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7825 sprintf, in case result does not fit in int.
7826
c57b67fc
PE
7827 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7828 (fontset_from_font): Print it.
7829
8a401434
PE
7830 * frame.c (tty_frame_count): Now printmax_t, not int.
7831 (make_terminal_frame, set_term_frame_name): Print it.
7832 (x_report_frame_params): In X, window IDs are unsigned long,
7833 not signed long, so print them as unsigned.
7834 (validate_x_resource_name): Check for implausibly long names,
7835 and don't assume name length fits in 'int'.
7836 (x_get_resource_string): Don't blindly alloca invocation name;
7837 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7838 not fit in int.
7839
6e1a67fb
PE
7840 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7841 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7842 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7843
0df02bf3
PE
7844 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7845 Use esprintf, not sprintf, in case result does not fit in int.
7846
48e30793
PE
7847 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7848 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7849 it as a large positive number.
7850 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7851 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7852
a66ff6d8
PE
7853 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7854 in case result does not fit in int.
7855
aca216ff
PE
7856 * print.c (float_to_string): Detect width overflow more reliably.
7857 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7858 buffer overrun. Don't assume list length fits in 'int'. Treat
7859 print length of 0 as 0, not as infinity; to be consistent with other
7860 uses of print length in this function. Don't overflow print length
7861 index. Don't assume hash table size fits in 'long', or that
7862 vectorlike size fits in 'unsigned long'.
7863
31c286f7
PE
7864 * process.c (make_process): Use printmax_t, not int, to format
7865 process-name gensyms.
7866
55e5faa1
PE
7867 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7868
80f2e268
PE
7869 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7870 to avoid potential buffer overrun.
7871
670741ab
PE
7872 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7873 if X resource line is longer than 512 bytes.
7874
b7163a50
PE
7875 * xfns.c (x_window): Make sprintf buffer a bit bigger
7876 to avoid potential buffer overrun.
7877
ae58ff1f
PE
7878 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7879
c43c8a6a
PE
7880 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7881
3f8236f4
PE
78822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7883
53e9fe90 7884 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7885 Without these, Emacs silently mishandles large integers sometimes.
7886 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7887 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7888
6511acf2
PE
7889 * xdisp.c (try_window_id): Check Emacs fixnum range before
7890 converting to 'int'.
806add1d 7891
6511acf2 7892 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7893 Check that an Emacs fixnum is in range before assigning it to 'int'.
7894 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7895 values converted from Emacs fixnums.
7896 (Frecenter): Don't wrap around a line count if it is out of 'int'
7897 range; instead, treat it as an extreme value.
7898 (Fset_window_configuration, compare_window_configurations):
7899 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7900
6511acf2
PE
7901 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7902 that can exceed INT_MAX. Check that EMACS_INT value is in range
7903 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7904 (match_limit): Don't assume that a fixnum can fit in 'int'.
7905
6511acf2 7906 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7907 exceed INT_MAX.
7908
6511acf2 7909 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7910 (Fvertical_motion): Don't wrap around LINES values that don't fit
7911 in 'int'. Instead, treat them as extreme values. This is good
7912 enough for windows, which can't have more than INT_MAX lines anyway.
7913
fcb901a7
LMI
79142011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7915
0f2f6b6d
LMI
7916 * Require libxml/parser.h to avoid compilation warning.
7917
fcb901a7
LMI
7918 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7919
7920 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7921 since this reportedly can destroy thread storage.
7922
6e20a0d4
CY
79232011-08-30 Chong Yidong <cyd@stupidchicken.com>
7924
7925 * syntax.c (find_defun_start): Update all cache variables if
7926 exiting early (Bug#9401).
7927
148ae00e
EZ
79282011-08-30 Eli Zaretskii <eliz@gnu.org>
7929
f6cfbd8f
EZ
7930 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7931
148ae00e
EZ
7932 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7933 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7934 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7935
7936 * term.c (tty_append_glyph): New function.
7937 (produce_stretch_glyph): Static function and its prototype deleted.
7938
a66cfb1c
SM
7939 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7940 Add prototypes.
148ae00e 7941
c4a07a4c
PE
79422011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7943
7944 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7945 when checking :margin (Bug#9390).
7946 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7947 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7948 so that the name doesn't mislead. All uses changed.
7949
6bc8cd65
JB
79502011-08-28 Johan Bockgård <bojohan@gnu.org>
7951
7952 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7953 set_tty_hooks.
7954
dca4927e
EZ
79552011-08-27 Eli Zaretskii <eliz@gnu.org>
7956
7957 * xdisp.c (move_it_to): Don't bail out early when reaching
7958 position beyond to_charpos, if we are scanning backwards.
7959 (move_it_vertically_backward): When DY == 0, make sure we get to
7960 the first character in the line after the newline.
7961
f2cad773
PE
79622011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7963
7964 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7965 (ccl_driver): Do not generate an out-of-range pointer.
7966 (Fccl_execute_on_string): Remove unnecessary check for
7967 integer overflow, noted by Stefan Monnier in
7968 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7969 Remove a FIXME that didn't need fixing.
7970 Simplify the newly-introduced buffer reallocation code.
7971
0cae2cdb
JB
79722011-08-27 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7975
5fc295a4 79762011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7977
70c60eb2 7978 Integer and memory overflow issues (Bug#9196).
726e0ab1 7979
d31850da
PE
7980 * doc.c (get_doc_string): Rework so that
7981 get_doc_string_buffer_size is the actual buffer size, rather than
7982 being 1 less than the actual buffer size; this makes xpalloc more
7983 convenient.
7984
a69fbedb
PE
7985 * image.c (x_allocate_bitmap_record, cache_image):
7986 * xselect.c (Fx_register_dnd_atom):
7987 Simplify previous changes by using xpalloc.
7988
fe5c5d37
PE
7989 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7990 since either will do and ptrdiff_t is convenient with xpalloc.
7991
0065d054
PE
7992 * charset.c (charset_table_size)
7993 (struct charset_sort_data.priority): Now ptrdiff_t.
7994 (charset_compare): Don't overflow if priorities differ greatly.
7995 (Fsort_charsets): Don't assume list length fits in int.
7996 Check for size-calculation overflow when allocating sort data.
7997 (syms_of_charset): Allocate an initial charset table that is
7998 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7999
8000 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8001
8002 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8003 The actual value is always <= INT_MAX, and leaving it unsigned made
8004 overflow checking harder.
8005
8006 * dispextern.h (struct glyph_matrix.rows_allocated)
8007 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8008 with xpalloc. The values are still always <= INT_MAX.
8009
8010 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8011
8012 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8013 (SAFE_NALLOCA): New macro.
8014
8015 * region-cache.c (struct boundary.pos, find_cache_boundary)
8016 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8017 (set_cache_region, invalidate_region_cache)
8018 (revalidate_region_cache, know_region_cache, region_cache_forward)
8019 (region_cache_backward, pp_cache):
8020 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8021 so that ptrdiff_t * can be passed to xpalloc.
8022 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8023 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8024 (pp_cache): Don't assume cache_len fits in int.
8025 * region-cache.h: Adjust extern decls to match.
8026
8027 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8028 EMACS_INT, since either will do, for xpalloc.
8029
8030 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8031 (xnmalloc, xnrealloc, xpalloc): New functions.
8032
726e0ab1
PE
8033 * bidi.c (bidi_shelve_header_size): New constant.
8034 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8035 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8036
51f30bc5 8037 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8038 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8039 (overlay_strings):
8040 Don't update size of array until after memory allocation succeeds,
8041 because xmalloc/xrealloc may not return.
0065d054
PE
8042 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8043 now that we have proper integer overflow checking.
8044 (record_overlay_string, overlay_strings): Catch overflows when
8045 calculating size of overlay_str_buf.
726e0ab1 8046
0065d054
PE
8047 * callproc.c (Fcall_process): Check for size overflow when
8048 calculating size of args2.
8049 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8050 Normally we prefer signed values, but sticking with ptrdiff_t would
8051 require adding more-complicated checks.
726e0ab1
PE
8052
8053 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8054 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8055 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8056 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8057
8058 * character.c (Fstring): Check for size-calculation overflow.
8059
8060 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8061 unnecessary integer overflow. Check for size overflow.
8062 (encode_coding_object): Don't update size until xmalloc succeeds.
8063
8064 * composite.c (get_composition_id): Check for overflow in glyph
8065 length calculations.
8066
8067 Integer and memory overflow fixes for display code.
8068 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8069 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8070 (scrolling_window): Check for overflow in size calculations.
8071 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8072 Don't assume glyph table len fits in int.
8073 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8074 (row_table_size): Now ptrdiff_t, not int.
8075 (scrolling_window): Avoid overflow in size calculations.
8076 Don't update size until allocation succeeds.
8077 * fns.c (concat): Check for overflow in size calculations.
8078 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8079 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8080 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8081
8082 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8083 (get_doc_string): Check for size calculation overflow.
8084 Don't update size until allocation succeeds.
8085 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8086 EMACS_INT, where ptrdiff_t will do.
8087 (Fsubstitute_command_keys): Check for string overflow.
8088
8089 * editfns.c (set_time_zone_rule): Don't assume environment length
8090 fits in int.
8091 (message_length): Now ptrdiff_t, not int.
8092 (Fmessage_box): Don't update size until allocation succeeds.
8093 Don't assume message length fits in int.
8094 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8095
0065d054
PE
8096 * emacs.c (main): Do not reallocate argv, since there is a null at
8097 the end that can be overwritten, and this way there's no need to
8098 worry about size-calculation overflow.
8099 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8100
8101 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8102 alloc succeeds.
8103 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8104
8105 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8106 (x_set_scroll_bar_width, x_figure_window_size):
8107 Check for integer overflow.
8108 (x_set_alpha): Do not assume XINT fits in int.
8109
8110 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8111 This is for the members text_lines, text_cols, total_lines, total_cols,
8112 where the system imposes an 'int' limit.
8113
8114 * fringe.c (Fdefine_fringe_bitmap):
8115 Don't update size until alloc works.
8116
8117 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8118 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8119
8120 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8121 Check for size-calculation overflow.
8122 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8123 do, as we prefer signed integers.
8124 (id_to_widget.max_size, id_to_widget.used)
8125 (xg_store_widget_in_map, xg_remove_widget_from_map)
8126 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8127 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8128 Use and return ptrdiff_t, not int.
8129 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8130 * gtkutil.h: Change prototypes to match the above.
8131
8132 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8133 are duplicate now that they've been promoted to lisp.h.
8134 (x_allocate_bitmap_record, x_alloc_image_color)
8135 (make_image_cache, cache_image, xpm_load):
8136 Don't update size until alloc is done.
8137 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8138 (x_detect_edges):
3256efce 8139 Check for size calculation overflow.
726e0ab1
PE
8140 (ct_colors_allocated_max): New constant.
8141 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8142 overflow.
3256efce 8143
726e0ab1
PE
8144 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8145 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8146 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8147 Use ptrdiff_t, not int, to count maps.
8148 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8149 calculations. Don't update size until allocation succeeds.
8150 Redo calculations to avoid overflow.
726e0ab1
PE
8151 * keyboard.h: Change prototypes to match the above.
8152
8153 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8154 to count maps.
8155 (current_minor_maps): Check for size calculation overflow.
8156 * keymap.h: Change prototypes to match the above.
8157
8158 * lread.c (read1, init_obarray): Don't update size until alloc done.
8159
8160 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8161 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8162
726e0ab1
PE
8163 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8164 Now ptrdiff_t, not int.
8165 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8166 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8167
8168 * process.c (Fnetwork_interface_list): Check for overflow
8169 in size calculation.
8170
8171 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8172
8173 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8174 overflow. Don't bother calling xmalloc when xrealloc will do.
8175
8176 * search.c (Freplace_match): Check for size calculation overflow.
8177 (Fset_match_data): Don't assume list lengths fit in 'int'.
8178
8179 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8180 for command line length. Do not attempt to address one before the
8181 beginning of an array, as that's not portable.
8182
8183 * term.c (max_frame_lines): Remove; unused.
8184 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8185 not int.
8186 (encode_terminal_code, calculate_costs): Check for size
8187 calculation overflow.
8188 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8189 table lengths and related sizes. Don't update size until alloc
8190 done. Redo calculations to avoid overflow.
8191 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8192
8193 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8194 subtracting pointers.
8195 (gobble_line): Check for overflow more carefully. Don't update size
8196 until alloc done.
8197
8198 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8199 Don't update size until alloc done.
8200 Redo size calculations to avoid overflow.
8201 Check for size calculation overflow.
0065d054 8202 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8203
8204 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8205 Use ptrdiff_t, not int, for sizes.
8206 (store_mode_line_noprop_char): Don't update size until alloc done.
8207
0065d054
PE
8208 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8209 Use ptrdiff_t, not int, for sizes.
8210 (Finternal_make_lisp_face, cache_face):
8211 Check for size calculation overflow.
8212 (cache_face): Treat size calculation overflows as if they were
8213 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8214
8215 * xfns.c (x_encode_text, x_set_name_internal)
8216 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8217 sizes, since they can exceed INT_MAX in size. Check for size
8218 calculation overflow.
8219
0065d054
PE
8220 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8221 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8222 Don't update size until alloc done.
8223
0065d054 8224 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8225 as sprintf is limited to int lengths.
1d526e2f 8226
252c5ee1
PE
8227 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8228 (X_LONG_MIN): New macros.
864d7ce7
PE
8229 Use them to make the following changes clearer.
8230 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8231 This change doesn't affect the value now, but it may help remind
8232 future maintainers not to raise the value too much later.
8233 (SELECTION_QUANTUM): Remove, replacing with ...
8234 (selection_quantum): ... new function, which avoids overflow.
8235 All uses changed.
8236 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8237 assumption that selection length fits in 'int'.
8238 (x_reply_selection_request, x_handle_selection_request)
8239 (x_get_window_property, receive_incremental_selection)
8240 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8241 (lisp_data_to_selection_data, clean_local_selection_data):
8242 Use ptrdiff_t, not int, to record length of selection.
8243 (x_reply_selection_request, x_get_window_property)
8244 (receive_incremental_selection, x_property_data_to_lisp):
8245 Redo calculations to avoid overflow.
8246 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8247 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8248 something.
8249 (x_get_window_property, receive_incremental_selection)
8250 (lisp_data_to_selection_data, x_property_data_to_lisp):
8251 Check for size-calculation overflow.
8252 (x_get_window_property, receive_incremental_selection)
8253 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8254 Don't store size until memory allocation succeeds.
8255 (x_get_window_property): Plug memory leak on memory exhaustion.
8256 Don't double-block input; malloc is safe here. Don't assume 2**34
8257 - 4 fits in unsigned long. Add an xassert to check
8258 XGetWindowProperty overflow. Be more careful about overflow
8259 calculations, and distinguish size from memory overflow better.
8260 (receive_incremental_selection): When tracing, don't assume
8261 unsigned int is less than INT_MAX.
8262 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8263 harmful) conversions of unsigned short to int.
8264 (lisp_data_to_selection_data): Don't assume that integers
8265 in the range -65535 through -1 fit in an X unsigned short.
8266 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8267 result parameters unless successful. Rely on cons_to_unsigned
8268 to report problems with elements; the old code wasn't right anyway.
8269 (x_check_property_data): Check for int overflow; we cannot use
8270 a wider type due to X limits.
8271 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8272
726e0ab1 8273 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8274
0065d054
PE
8275 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8276 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8277 (x_color_cells): Don't store size until memory allocation succeeds.
8278 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8279 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8280 (x_term_init): Don't assume length fits in int (sprintf is limited
8281 to int size).
bc18e09d 8282
ebfa62c0
PE
8283 Use ptrdiff_t for composition IDs.
8284 * character.c (lisp_string_width):
8285 * composite.c (composition_table_size, n_compositions)
8286 (get_composition_id, composition_gstring_from_id):
8287 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8288 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8289 * window.c (Frecenter):
8290 Use ptrdiff_t, not int, for composition IDs.
8291 * composite.c (get_composition_id): Check for integer overflow.
8292 * composite.h: Adjust prototypes to match the above changes.
8293
d3411f89
PE
8294 Use ptrdiff_t for hash table indexes.
8295 * category.c (hash_get_category_set):
8296 * ccl.c (ccl_driver):
8297 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8298 * coding.c (coding_system_charset_list, detect_coding_system):
8299 * coding.h (struct coding_system.id):
8300 * composite.c (get_composition_id, gstring_lookup_cache):
8301 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8302 * image.c (xpm_get_color_table_h):
8303 * lisp.h (hash_lookup, hash_put):
8304 * minibuf.c (Ftest_completion):
8305 Use ptrdiff_t for hash table indexes, not int (which is too
8306 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8307 32-bit --with-wide-int hosts).
8308
e097a6fa
PE
8309 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8310 Add a FIXME comment about memory leaks.
8311 (syms_of_charset): Don't assume xmalloc returns.
8312
5637687f
PE
8313 Don't assume that stated character widths fit in int.
8314 * character.c (Fchar_width, c_string_width, lisp_string_width):
8315 * character.h (CHAR_WIDTH):
8316 * indent.c (MULTIBYTE_BYTES_WIDTH):
8317 Use sanitize_char_width to avoid undefined and/or bad behavior
8318 with outlandish widths.
a66cfb1c 8319 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8320 now that we have two such functions. All uses changed.
8321 (sanitize_char_width): New inline function.
8322
a2271ba2
PE
8323 Don't assume that tab-width fits in int.
8324 * character.h (sanitize_width): New inline function.
8325 (SANE_TAB_WIDTH): New macro.
8326 (ASCII_CHAR_WIDTH): Use it.
8327 * indent.c (sane_tab_width): Remove. All uses replaced by
8328 SANE_TAB_WIDTH (current_buffer).
8329 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8330
18c52557
PE
8331 * fileio.c: Integer overflow issues with file modes.
8332 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8333
caeeedc1
PE
8334 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8335 Remove unreachable code.
8336 (read_hex, load_charset_map_from_file): Check for integer overflow.
8337
6df6ae42 8338 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8339 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8340 (x_send_scroll_bar_event): Likewise. Check that the size does not
8341 exceed limits imposed by XClientMessageEvent, as well as the usual
8342 ptrdiff_t and size_t limits.
8343
b13995db
PE
8344 * keyboard.c: Overflow, signedness and related fixes.
8345 (make_lispy_movement): Use same integer type in forward decl
8346 that is used in the definition.
8347 (read_key_sequence, keyremap_step):
8348 Change bufsize argument back to int, undoing my 2011-03-30 change.
8349 We prefer signed types, and int is wide enough here.
8350 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8351 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8352 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8353 length, not size_t. Use ptrdiff_t for index, not int.
8354 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8355 possibility of integer overflow.
8356
13464394
PE
8357 Overflow, signedness and related fixes for images.
8358
8359 * dispextern.h (struct it.stack[0].u.image.image_id)
8360 (struct_it.image_id, struct image.id, struct image_cache.size)
8361 (struct image_cache.used, struct image_cache.ref_count):
8362 * gtkutil.c (update_frame_tool_bar):
8363 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8364 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8365 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8366 * nsmenu.m (update_frame_tool_bar):
8367 * xdisp.c (calc_pixel_width_or_height):
8368 * xfns.c (image_cache_refcount):
8369 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8370 on typical 64-bit hosts.
8371
8372 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8373 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8374 Omit unnecessary casts to int.
8375 (parse_image_spec): Check that integers fall into 'int' range
8376 when the callers expect that.
8377 (image_ascent): Redo ascent calculation to avoid int overflow.
8378 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8379 (lookup_image): Remove unnecessary tests.
8380 (xbm_image_p): Locals are now of int, not EMACS_INT,
8381 since parse_image_check makes sure they fit into int.
8382 (png_load, gif_load, svg_load_image):
8383 Prefer int to unsigned where either will do.
8384 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8385 old tiff_error_handler and tiff_warning_handler.
8386 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8387 stack buffer overflows. It uses only the features of vsnprintf
8388 that are common to both POSIX and native Microsoft.
8389 (tiff_error_handler, tiff_warning_handler): Use it.
8390 (tiff_load, gif_load, imagemagick_load_image):
8391 Don't assume :index value fits in 'int'.
8392 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8393 (imagemagick_load_image): Check that crop parameters fit into
8394 the integer types that MagickCropImage accepts. Don't assume
8395 Vimagemagick_render_type has a nonnegative value. Don't assume
8396 size_t fits in 'long'.
8397 (gs_load): Use printmax_t to print the widest integers possible.
8398 Check for integer overflow when computing image height and width.
8399
c11821d4
EZ
84002011-08-26 Eli Zaretskii <eliz@gnu.org>
8401
8402 * xdisp.c (redisplay_window): Don't force window start if point
8403 will be invisible in the resulting window. (Bug#9324)
8404
0c95fcf7
EZ
84052011-08-25 Eli Zaretskii <eliz@gnu.org>
8406
8407 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8408 the display spec is of the form `(space ...)'.
8409 (handle_display_spec): Return the value returned by
8410 handle_single_display_spec, not just 1 or zero.
8411 (handle_single_display_spec): If the display spec is of the form
8412 `(space ...)', and specifies display in the text area, return 2
8413 rather than 1.
fee65a97 8414 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8415 accurately, and prefer exact match for point under bidi.
8416 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8417
8418 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8419 into disp_prop; all users changed.
8420
8421 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8422 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8423 for the text covered by the display property.
8424
e4ed06f1
CY
84252011-08-25 Chong Yidong <cyd@stupidchicken.com>
8426
8427 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8428 Change return value to nil.
8429 (Frecord_buffer): Delete unused function.
8430
f67cdd7f
EZ
84312011-08-24 Eli Zaretskii <eliz@gnu.org>
8432
5980d4c6
EZ
8433 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8434 buffers, return left-to-right.
8610fe8b
EZ
8435 (set_cursor_from_row): Consider candidate row a win if its glyph
8436 represents a newline and point is on that newline. Fixes cursor
8437 positioning on the newline at EOL of R2L text within L2R
8438 paragraph, and vice versa.
8439 (try_cursor_movement): Check continued rows, in addition to
8440 continuation rows. Fixes unwarranted scroll when point enters a
8441 continued line of R2L text within an L2R paragraph, or vice versa.
8442 (cursor_row_p): Consider the case of point being equal to
8443 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8444 from the end of a short line to the beginning of a continued line
8445 of R2L text within L2R paragraph.
8446 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8447 composed characters.
5980d4c6 8448
f67cdd7f
EZ
8449 * bidi.c (bidi_check_type): Use xassert.
8450 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8451 members.
8452
bca633fb
EZ
84532011-08-23 Eli Zaretskii <eliz@gnu.org>
8454
8455 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8456 a character.
8457
4a5885a7
CY
84582011-08-23 Chong Yidong <cyd@stupidchicken.com>
8459
8460 * nsfont.m (ns_otf_to_script): Fix typo.
8461
0902a04e
KH
84622011-08-22 Kenichi Handa <handa@m17n.org>
8463
8464 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8465 extra slot even if the purpose is char-code-property-table.
8466
1a2e6670
EZ
84672011-08-23 Eli Zaretskii <eliz@gnu.org>
8468
8ddde651
EZ
8469 * xdisp.c (redisplay_window): When computing centering_position,
8470 account for the height of the header line. (Bug#8874)
8471
425cc014
EZ
8472 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8473 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8474 candidate is selected by the mouse, and that candidate has a
8475 composed character under the mouse.
8476
1a2e6670
EZ
8477 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8478 coordinates reported by pos-visible-in-window-p for a composed
8479 character in column zero.
8480
8b76d6f8
SM
84812011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8482
8483 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8484
dac347dd
EZ
84852011-08-22 Eli Zaretskii <eliz@gnu.org>
8486
8487 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8488 consider it a hit if to_charpos is anywhere in the range of the
8489 composed buffer positions.
8490
e013fb34
CY
84912011-08-22 Chong Yidong <cyd@stupidchicken.com>
8492
8493 * image.c (gif_load): Don't assume that each subimage has the same
8494 dimensions as the base image. Handle disposal method that is
8495 "undefined" by the gif spec (Bug#9335).
8496
bd1ba3e8
CY
84972011-08-20 Chong Yidong <cyd@stupidchicken.com>
8498
8499 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8500 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8501
54a1215b
EZ
85022011-08-19 Eli Zaretskii <eliz@gnu.org>
8503
823564e5
EZ
8504 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8505 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8506 from an Org mode buffer to a Speedbar frame.
8507
54a1215b
EZ
8508 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8509 a composition, take its buffer position from IT->cmp_it.charpos.
8510 Fixes cursor positioning at the beginning of a line that begins
8511 with a composed character.
8512
9778ebcc
EZ
85132011-08-18 Eli Zaretskii <eliz@gnu.org>
8514
0be6ee06
EZ
8515 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8516 character bidirectional type, use STRONG_L instead. Fixes crashes
8517 in a buffer produced by `describe-categories'.
8518
9778ebcc
EZ
8519 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8520 members before the level stack, so they would be saved and
8521 restored when copying iterator state. Fixes incorrect reordering
8522 around TABs covered by display properties.
8523
156bffbe
AS
85242011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8525
6b02f655 8526 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8527
72ad093b
CY
85282011-08-17 Chong Yidong <cyd@stupidchicken.com>
8529
8530 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8531 (internal_condition_case_2, internal_condition_case_n):
8532 Remove unnecessary aborts (Bug#9081).
72ad093b 8533
35774242
EZ
85342011-08-17 Eli Zaretskii <eliz@gnu.org>
8535
8536 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8537 has no `load' handler, try opening the file locally. (Bug#9311)
8538
db76dd85
KB
85392011-08-16 Ken Brown <kbrown@cornell.edu>
8540
8541 * gmalloc.c: Expand comment.
8542
b215eee5
EZ
85432011-08-16 Eli Zaretskii <eliz@gnu.org>
8544
8545 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8546 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8547
a4579d33
KB
85482011-08-16 Ken Brown <kbrown@cornell.edu>
8549
8550 Fix memory allocation problems in Cygwin build (Bug#9273).
8551
8552 * unexcw.c ( __malloc_initialized): Declare external variable.
8553 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8554
8b76d6f8
SM
8555 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8556 New variables.
a4579d33
KB
8557 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8558 dumped emacs.
8559 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8560 in the static heap.
8561 [CYGWIN] (special_realloc): New function.
8562 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8563 requests to realloc storage in the static heap.
8564
3ebec551
PE
85652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8566
8567 * bidi.c (bidi_initialize): Remove unused local.
8568
9fd8be00
EZ
85692011-08-15 Eli Zaretskii <eliz@gnu.org>
8570
6b02f655
SM
8571 * bidimirror.h:
8572 * biditype.h: Remove file.
8573 * makefile.w32-in ($(BLD)/bidi.$(O)):
8574 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8575
8576 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8577
8578 * chartab.c: Improve commentary for the uniprop_table API.
8579
32413314
EZ
8580 * bidi.c (bidi_paragraph_init): Support zero value of
8581 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8582 (bidi_initialize): Use uniprop_table instead of including
8583 biditype.h and bidimirror.h.
32413314 8584
9fd8be00
EZ
8585 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8586 coordinates of the iterator when restoring from ppos_it.
8587 (Bug#9296)
8588
5cf2b69b
KH
85892011-08-14 Kenichi Handa <handa@m17n.org>
8590
8591 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8592 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8593
daf17d00
EZ
85942011-08-14 Eli Zaretskii <eliz@gnu.org>
8595
8596 * xdisp.c (move_it_in_display_line_to): Don't invoke
8597 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8598 ppos_it. Fixes vertical cursor motion when line beginning is
8599 covered by an image. (Bug#9296)
8600
08e3161a
JD
86012011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8602
8603 * nsterm.h (ns_run_ascript): Declare.
8604 (NSAPP_DATA2_RUNASSCRIPT): Define.
8605
8606 * nsfns.m (as_script, as_result, as_status): New static variables.
8607 (ns_run_ascript): New function.
5e617bc2 8608 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8609 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8610 the event loop. Get status from as_status (Bug#7276).
8611
8612 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8613 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8614 the event loop (Bug#7276).
8615
a3720aa2
AS
86162011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8617
8618 * gnutls.c (QCgnutls_bootprop_priority)
8619 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8620 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8621 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8622 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8623 (QCgnutls_bootprop_verify_hostname_error)
8624 (QCgnutls_bootprop_callbacks_verify): Rename from
8625 Qgnutls_bootprop_..., all uses changed.
8626
8627 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8628 uses changed.
8629
0a0d27fb
PE
86302011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8631
19d5c50c
PE
8632 * xfaces.c (Qframe_set_background_mode): Now static.
8633 * dispextern.h (Qframe_set_background_mode): Remove decl.
8634
0a0d27fb
PE
8635 * process.c (Fnetwork_interface_info): Declare local only if needed.
8636
377538cb
JD
86372011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8638
8639 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8640 (Fnetwork_interface_list): Allocate in increments of bytes instead
8641 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8642 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8643 sockaddr.
8644 (struct ifflag_def): notrailers is smart on OSX.
8645 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8646 Get hardware address with getifaddrs if available.
8647
08fff70c
EZ
86482011-08-12 Eli Zaretskii <eliz@gnu.org>
8649
8650 * xdisp.c (iterate_out_of_display_property): xassert that
8651 IT->position is set to within IT->object's boundaries. Break from
8652 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8653 when IT->position is set up wrongly due to some bug.
8654 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8655 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8656 entry. Force push_it to save on the stack the current
8657 buffer/string position, to be restored by pop_it. Fix flags in
8658 the iterator structure wrt the object coming from a display
8659 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8660 properties. (Bug#9284)
8661
7be1c708 86622011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8663
7be1c708
CY
8664 * fontset.c (fontset_get_font_group): Add proper type checks.
8665 (Bug#9172)
aac0c6e3 8666
7be1c708 86672011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8668
7be1c708
CY
8669 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8670 and LC_VERSION_MIN_MACOSX.
8671 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8672 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8673
97bb72a6
EZ
86742011-08-08 Eli Zaretskii <eliz@gnu.org>
8675
8676 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8677 no-display-properties-and-no-overlays under bidi display.
8678 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8679 properties and overlays.
97bb72a6 8680
d5617611
CY
86812011-08-08 Chong Yidong <cyd@stupidchicken.com>
8682
37e11a63
CY
8683 * editfns.c (Fset_time_zone_rule): Document relationship with the
8684 setenv function.
8685
d5617611
CY
8686 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8687 the font entity extracted from the cache (Bug#8109).
8688
58872834
CY
86892011-08-07 Chong Yidong <cyd@stupidchicken.com>
8690
8691 * composite.c (autocmp_chars): Don't reset point. That is done by
8692 restore_point_unwind (Bug#5984).
8693
75bfc667
JL
86942011-08-07 Juri Linkov <juri@jurta.org>
8695
8696 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8697 to show the arg `TIME' instead of `TIMEVAL'.
8698
d1410150
EZ
86992011-08-06 Eli Zaretskii <eliz@gnu.org>
8700
8701 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8702 display property strides EOL and includes a newline, as in
8703 longlines-mode. (Bug#9254)
75b771e4
EZ
8704 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8705 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8706
8707 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8708 is non-zero, even if the data buffer is NULL. Fixes a crash in
8709 vertical-motion with longlines-mode. (Bug#9254)
8710
35928349
EZ
87112011-08-05 Eli Zaretskii <eliz@gnu.org>
8712
ec7cc85b
EZ
8713 * bidi.c <bidi_cache_total_alloc>: Now static.
8714 (bidi_initialize): Initialize bidi_cache_total_alloc.
8715
8b76d6f8 8716 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8717 cache. (Bug#9221)
8718
8719 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8720 amount allocated this far in `bidi_cache_total_alloc'.
8721 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8722 non-zero, only free the data buffer without restoring the cache
8723 contents. All callers changed.
8724
8725 * dispextern.h (bidi_unshelve_cache): Update prototype.
8726
8727 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8728 (move_it_in_display_line, move_it_to)
8729 (move_it_vertically_backward, move_it_by_lines): Replace the call
8730 to xfree to an equivalent call to bidi_unshelve_cache.
8731 (move_it_in_display_line_to): Fix logic of returning
412b6358 8732 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8733
e2e2423b
EZ
87342011-08-05 Eli Zaretskii <eliz@gnu.org>
8735
8736 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8737 came from a string character with a `cursor' property. (Bug#9229)
8738
ae9e757a
JD
87392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8740
8741 * Makefile.in (LIB_PTHREAD): New variable.
8742 (LIBES): Add LIB_PTHREAD (Bug#9216).
8743
8744 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8745 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8746
213bd7f2
AS
87472011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8748
6b02f655 8749 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8750
99aaf75f
JD
87512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8752
8753 * xterm.c (x_find_topmost_parent): New function.
8754 (x_set_frame_alpha): Find topmost parent window with
8755 x_find_topmost_parent and set the property there also (bug#9181).
8756 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8757
c74e9d86
PE
87582011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8759
8760 * callproc.c (Fcall_process): Avoid vfork clobbering
8761 the local vars buffer, coding_systems, current_dir.
8762
640c8776
SM
87632011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8764
8765 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8766
f26d0e4c
PE
87672011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8768
8a10d76c
PE
8769 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8770 so that it is not optimized away.
8771
f26d0e4c
PE
8772 * xdisp.c (compute_display_string_pos): Remove unused local.
8773
55439c61
EZ
87742011-08-02 Eli Zaretskii <eliz@gnu.org>
8775
8776 Fix slow cursor motion and scrolling in large buffers with
8777 selective display, like Org Mode buffers. (Bug#9218)
8778
8779 * dispextern.h (struct bidi_it): New member disp_prop_p.
8780
8781 * xdisp.c: Remove one-slot cache of display string positions.
8782 (compute_display_string_pos): Accept an additional argument
5e617bc2 8783 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8784 for a display string or property. If found, set DISP_PROP_P
8785 non-zero.
8786
8787 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8788 DISP_PROP_P, and pass it to compute_display_string_pos.
8789 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8790 non-zero. All callers of bidi_fetch_char changed.
8791
fb33fa43
SM
87922011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8793
8794 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8795
b099e063
DM
87962010-12-03 Don March <don@ohspite.net>
8797
8798 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8799 last character M-[char] is translated to ESC [char] (bug#7541).
8800
5cc7f7af
KH
88012011-08-02 Kenichi Handa <handa@m17n.org>
8802
d0fffa3f 8803 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8804
8805 * chartab.c (uniprop_table): Make it non-static.
8806
525d5e6e
EZ
88072011-08-01 Eli Zaretskii <eliz@gnu.org>
8808
8809 * xdisp.c (forward_to_next_line_start): Accept additional argument
8810 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8811 on the newline.
8812 (reseat_at_next_visible_line_start): Use the bidi iterator state
8813 returned by forward_to_next_line_start to restore the state of
8814 it->bidi_it after backing up to previous newline. (Bug#9212)
8815
31011111
AS
88162011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8817
8818 * regex.c (re_comp): Protoize.
8819 (re_exec): Fix return type.
8820 (regexec): Fix type of `ret'. (Bug#9203)
8821
476371c4
PE
88222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8823
e5d76069
PE
8824 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8825 This is needed if max-image-size is a floating-point number.
8826
9a79b20c
AS
88272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8828
8829 * print.c (print_object): Print empty symbol as ##.
8830
8831 * lread.c (read1): Read ## as empty symbol.
8832
d8c2fa78
AA
88332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8834
8835 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8836 setting frame foreground color (Bug#9175).
8837 (x_set_background_color): Likewise.
8838
ffe57a7a
AA
8839 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8840 contents (Bug#9176).
8841 (EmacsTooltip -init): Remove bezels and add shadows to
8842 tooltip windows.
8843
bf3492a5
AA
8844 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8845 or scroll bar (Bug#8470).
8846
d55e9c53
AA
8847 * nsfont.m (nsfont_open): Remove assignment to voffset and
8848 unnecessary vars hshink, expand, hd, full_height, min_height.
8849 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8850
8851 * nsterm.h (nsfont_info): Remove voffset field.
8852
d8c2fa78 88532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8854
8855 Implement strike-through and overline on NextStep (Bug#8863).
8856
8857 * nsfont.m (nsfont_open): Use underline position provided by font,
8858 instead of hard-coded value of 2.
8859 (nsfont_draw): Call ns_draw_text_decoration instead.
8860
8861 * nsterm.h: Add declaration for ns_draw_text_decoration.
8862
8863 * nsterm.m (ns_draw_text_decoration): New function for drawing
8864 underline, overline, and strike-through.
8865 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8866 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8867 accommodate underlining, etc.
4843aac3 8868
4cc60b9b
EZ
88692011-07-28 Eli Zaretskii <eliz@gnu.org>
8870
bc7ece87
EZ
8871 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8872 default.
4cc60b9b 8873
476371c4
PE
88742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8875
66606eea
PE
8876 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8877 Without this fix, if a signal arrives just after memory fills up,
8878 'malloc' might be invoked reentrantly.
8879
476371c4
PE
8880 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8881 In other words, assume that every image size is allowed, on non-X
8882 hosts. This assumption is probably wrong, but it lets Emacs compile.
8883
f3fcc40d
AS
88842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8885
8886 * regex.c (re_iswctype): Convert return values to boolean.
8887
350c992f
EZ
88882011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8889
8890 * xdisp.c (compute_display_string_pos): Don't use cached display
8891 string position if the buffer had its restriction changed.
8892 (Bug#9184)
8893
5266b4bb
PE
88942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8895
8896 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8897
2573a837 88982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8899
41f55ccd 8900 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8901
39e378da
PE
8902 * bidi.c: Integer size and overflow fixes.
8903 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8904 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8905 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8906 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8907 (bidi_find_other_level_edge):
8908 Use ptrdiff_t instead of EMACS_INT where either will do.
8909 This works better on 32-bit hosts configured --with-wide-int.
8910 (bidi_cache_ensure_space): Check for size-calculation overflow.
8911 Use % rather than repeated addition, for better worst-case speed.
8912 Don't set bidi_cache_size until after xrealloc returns, because it
8913 might not return.
8914 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8915 (bidi_cache_ensure_space): Also check that the bidi cache size
8916 does not exceed that of the largest Lisp string or buffer. See Eli
8917 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8918
5e927815
PE
8919 * alloc.c (__malloc_size_t): Remove.
8920 All uses replaced by size_t. See Andreas Schwab's note
8921 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8922
ca4aa935
PE
8923 * image.c: Improve checking for integer overflow.
8924 (check_image_size): Assume that f is nonnull, since
8925 it is always nonnull in practice. This is one less thing to
8926 worry about when checking for integer overflow later.
8927 (x_check_image_size): New function, which checks for integer
8928 overflow issues inside X.
8929 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8930 This removes the need for a memory_full check.
8931 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8932 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8933 (xbm_read_bitmap_data): Change locals back to 'int', since
8934 their values must fit in 'int'.
8935 (xpm_load_image, png_load, tiff_load):
8936 Invoke x_create_x_image_and_pixmap earlier,
8937 to avoid much needless work if the image is too large.
8938 (tiff_load): Treat overly large images as if
8939 x_create_x_image_and_pixmap failed, not as malloc failures.
8940 (gs_load): Use x_check_image_size.
8941
5f8f9cc2
PE
8942 * gtkutil.c: Omit integer casts.
8943 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8944 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8945
5adf60bc
PE
8946 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8947
c8907a93
PE
8948 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8949 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8950 would wrongly return t on a 64-bit host.
8951
e3c25c68
PE
8952 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8953 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8954 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8955 and therefore cause GCC to emit a bogus diagnostic in some cases.
8956
3f791afe
PE
8957 * image.c: Integer signedness and overflow and related fixes.
8958 This is not an exhaustive set of fixes, but it's time to
8959 record what I've got.
8960 (lookup_pixel_color, check_image_size): Remove redundant decls.
8961 (check_image_size): Don't assume that arbitrary EMACS_INT values
8962 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8963 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8964 (tiff_load, imagemagick_load_image):
8965 Check for overflow in size calculations.
8966 (x_create_x_image_and_pixmap): Remove unnecessary test for
8967 xmalloc returning NULL; that can't happen.
8968 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8969 (xpm_color_bucket): Use better integer hashing function.
8970 (xpm_cache_color): Don't possibly over-allocate memory.
8971 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8972 (gif_memory_source):
8973 Use ptrdiff_t, not int or size_t, to record sizes.
8974 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8975 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8976 either works, as we prefer signed integers.
8977 (tiff_read_from_memory, tiff_write_from_memory):
8978 Return tsize_t, not size_t, since that's what the TIFF API wants.
8979 (tiff_read_from_memory): Don't fail simply because the read would
8980 go past EOF; instead, return a short read.
8981 (tiff_load): Omit no-longer-needed casts.
8982 (Fimagemagick_types): Don't assume size fits into 'int'.
8983
3cc5a532
PE
8984 Improve hashing quality when configured --with-wide-int.
8985 * fns.c (hash_string): New function, taken from sxhash_string.
8986 Do not discard information about ASCII character case; this
8987 discarding is no longer needed.
8988 (sxhash-string): Use it. Change sig to match it. Caller changed.
8989 * lisp.h: Declare it.
8990 * lread.c (hash_string): Remove, since we now use fns.c's version.
8991 The fns.c version returns a wider integer if --with-wide-int is
8992 specified, so this should help the quality of the hashing a bit.
8993
b312a492
PE
8994 * emacs.c: Integer overflow minor fix.
8995 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8996 Define only if GNU_LINUX.
8997 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8998
dfd153ae
PE
8999 * dispnew.c: Integer signedness and overflow fixes.
9000 Remove unnecessary forward decls, that were a maintenance hassle.
9001 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9002 All uses changed.
9003 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9004 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9005 (prepare_desired_row, line_draw_cost):
9006 Use int, not unsigned, where either works.
9007 (save_current_matrix, restore_current_matrix):
9008 Use ptrdiff_t, not size_t, where either works.
9009 (init_display): Check for overflow more accurately, and without
9010 relying on undefined behavior.
9011
a81d11a3
PE
9012 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9013 Remove, replacing with the new symbols in lisp.h. All uses changed.
9014 * fileio.c (make_temp_name):
9015 * filelock.c (lock_file_1, lock_file):
9016 * xdisp.c (message_dolog):
9017 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9018 Use pMd etc. instead.
9019 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9020 replacing the pWIDE etc. symbols removed from editfns.c.
9021
3300e6fd
PE
9022 * keyboard.h (num_input_events): Now uintmax_t.
9023 This is (very slightly) less likely to mess up due to wraparound.
9024 All uses changed.
9025
fd05c7e9
PE
9026 * buffer.c: Integer signedness fixes.
9027 (alloc_buffer_text, enlarge_buffer_text):
9028 Use ptrdiff_t rather than size_t when either will do, as we prefer
9029 signed integers.
9030
903fe15d
PE
9031 * alloc.c: Integer signedness and overflow fixes.
9032 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9033 (__malloc_size_t): Default to size_t, not to int.
9034 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9035 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9036 Prefer ptrdiff_t to size_t when either would do, as we prefer
9037 signed integers.
9038 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9039 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9040 Now const. Initialize with values that are in range even if char
9041 is signed.
9042 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9043 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9044 These functions do the right thing with sizes > 2**32.
9045 (check_depth): Now ptrdiff_t, not int.
9046 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9047 Adjust to new way of storing sizes. Check for size overflow bugs
9048 in rest of code.
9049 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9050 slightly wrong anyway, as it missed one instance of
9051 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9052 (refill_memory_reserve): Omit needless cast to size_t.
9053 (mark_object_loop_halt): Mark as externally visible.
9054
ac82cc6a
PE
9055 * xselect.c: Integer signedness and overflow fixes.
9056 (Fx_register_dnd_atom, x_handle_dnd_message):
9057 Use ptrdiff_t, not size_t, since we prefer signed.
9058 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9059 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9060 x_dnd_atoms_size and x_dnd_atoms_length.
9061
c2d1e36d
PE
9062 * doprnt.c: Prefer signed to unsigned when either works.
9063 * eval.c (verror):
9064 * doprnt.c (doprnt):
9065 * lisp.h (doprnt):
9066 * xdisp.c (vmessage):
9067 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9068 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9069 prefer signed arithmetic to avoid comparison confusion.
9070 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9071 but is a bit tricky.
9072
0e926e56
PE
9073 Assume freestanding C89 headers, string.h, stdlib.h.
9074 * data.c, doprnt.c, floatfns.c, print.c:
9075 Include float.h unconditionally.
9076 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9077 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9078 * regex.c: Likewise for stddef.h, string.h.
9079 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9080 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9081 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9082 (STDC_HEADERS): Remove obsolete defines.
9083 * sysdep.c: Include limits.h unconditionally.
9084
9cfdb3ec
PE
9085 Assume support for memcmp, memcpy, memmove, memset.
9086 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9087 * regex.c (memcmp, memcpy):
9088 Remove; we assume C89 now.
9089
9090 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9091 (__malloc_safe_bcopy): Remove; no longer needed.
9092
cf950e6b 9093 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9094 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9095 well either way, and we prefer signed to unsigned.
9096
dbf38e02
LMI
90972011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9098
9099 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9100 closes the connection while we're reading (bug#9182).
9101
d6f0886c 91022011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9103
d6f0886c
JD
9104 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9105 are specified (Bug#9168).
24e0f6b1 9106
2eb1f9e6
PE
91072011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9108
9109 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9110 Found by GCC static checking and --with-wide-int on a 32-bit host.
9111
22381272 91122011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9113
9114 * xdisp.c (compute_display_string_pos): Fix logic of caching
9115 previous display string position. Initialize cached_prev_pos to
9116 -1. Fixes slow-down at the beginning of a buffer.
9117
f25e39b4
EZ
91182011-07-24 Eli Zaretskii <eliz@gnu.org>
9119
9120 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9121 for attrs[LFACE_FONTSET_INDEX].
9122
04c4b52e
PE
91232011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9124
9125 * xml.c (parse_region): Remove unused local
9126 that was recently introduced.
9127
c1734fbd
EZ
91282011-07-23 Eli Zaretskii <eliz@gnu.org>
9129
be18c5a5
EZ
9130 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9131 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9132
c1734fbd
EZ
9133 * xdisp.c (move_it_in_display_line_to): Record the best matching
9134 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9135 exit if none of the characters scanned was an exact match.
9136 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9137 when exact match is impossible due to invisible text, and the
9138 lines are truncated.
9139
a258d627
JD
91402011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9141
9142 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9143 for OSX >= 10.7.
9144
b6d5a689
EZ
91452011-07-22 Eli Zaretskii <eliz@gnu.org>
9146
0f74f785
EZ
9147 Fix a significant slow-down of cursor motion with C-n, C-p,
9148 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9149 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9150 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9151 (next_element_from_buffer): Call compute_stop_pos_backwards to
9152 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9153 base_level_stop.
9154 (reseat): Don't look for prev_stop, as that could mean a very long
9155 run.
9156 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9157 <cached_disp_overlay_modiff>: Cache for last found display string
9158 position.
551918c1 9159 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9160 about the same buffer in the same area of character positions, and
9161 the buffer wasn't changed since the time the display string
9162 position was cached.
551918c1 9163
b2d0c91a
EZ
91642011-07-22 Eli Zaretskii <eliz@gnu.org>
9165
9166 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9167 is an integer, which is important for empty lines. (Bug#9149)
9168
043604ee
CY
91692011-07-22 Chong Yidong <cyd@stupidchicken.com>
9170
9171 * frame.c (Fmodify_frame_parameters): In tty case, update the
9172 default face if necessary (Bug#4238).
9173
da4adb04
CY
91742011-07-21 Chong Yidong <cyd@stupidchicken.com>
9175
9176 * editfns.c (Fstring_to_char): No need to explain what a character
9177 is in the docstring (Bug#6576).
9178
9abd0532
LMI
91792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9180
9181 * xml.c (parse_region): Make sure we always return a tree.
9182
36881d16
HK
91832011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9184
9185 * xml.c (parse_region): If a document contains only comments,
9186 return that, too.
9187
1e98674d
LMI
91882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9189
9190 * xml.c (make_dom): Return comments, too.
9191
590bd467
PE
91922011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9193
9194 Port to OpenBSD.
9195 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9196 and the surrounding thread.
9197 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9198 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9199 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9200 timer goes off.
9201 * s/openbsd.h (BROKEN_SIGIO): Define.
9202 * unexelf.c (unexec) [__OpenBSD__]:
9203 Don't update the .mdebug section of the Alpha COFF symbol table.
9204
f41628b2
LMI
92052011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9206
9207 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9208 (bug#8460).
9209
b59b67c5
PE
92102011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9211
15e3a074
PE
9212 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9213 This fixes some race conditions on the permissions of any newly
9214 created file.
9215
41bed37d
PE
9216 * alloc.c (valid_pointer_p): Use pipe, not open.
9217 This fixes some permissions issues when debugging.
9218
b59b67c5
PE
9219 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9220 If fchown fails to set both uid and gid, try to set just gid,
9221 as that is sometimes allowed. Adjust the file's mode to eliminate
9222 setuid or setgid bits that are inappropriate if fchown fails.
9223
925a6be7
SM
92242011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9225
9226 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9227 to compare Lisp_Objects.
9228 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9229 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9230 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9231
52968808
AS
92322011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9233
0a6a104b
AS
9234 * lread.c (read_integer): Unread even EOF character.
9235 (read1): Likewise. Properly record start position of symbol.
9236
52968808
AS
9237 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9238 symbol character follows.
9239
9e381cdd
PE
92402011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9241
9242 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9243 This works around a problem with the previous change to Fcopy_file.
9244 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9245 and without this change, GCC might complain about discarding
9246 fchown's return value.
9247
b5641435
JB
92482011-07-16 Juanma Barranquero <lekktu@gmail.com>
9249
9250 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9251
a8031457
PE
92522011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9253
9254 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9255
dd889327
LMI
92562011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9257
750c33f7
LMI
9258 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9259 it's used from the C level.
9260
dd889327
LMI
9261 * process.c: Use the same condition for POLL_FOR_INPUT in both
9262 keyboard.c and process.c (bug#1858).
9263
87e86684
LM
92642011-07-09 Lawrence Mitchell <wence@gmx.li>
9265
9266 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9267 (Fgnutls_boot): Use it.
9268
64348f40
AS
92692011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9270
9271 * doc.c (Fsubstitute_command_keys): Revert last change.
9272
1d698799
LMI
92732011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9274
f863868c
LMI
9275 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9276 quotes the next character, and doesn't affect other longer
9277 sequences (bug#8935).
9278
1d698799
LMI
9279 * lread.c (syms_of_lread): Clarify that is isn't only
9280 `eval-buffer' and `eval-defun' that's affected by
9281 `lexical-binding' (bug#8460).
9282
aa4b6df6
EZ
92832011-07-15 Eli Zaretskii <eliz@gnu.org>
9284
9285 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9286 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9287
5d856da6
PE
92882011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9289
ad6042bb
PE
9290 Fix minor problems found by static checking.
9291 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9292 (elsz): Now a signed constant, not a size_t var. We prefer signed
9293 types to unsigned, to avoid integer comparison confusion. Without
9294 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9295 "cannot optimize loop, the loop counter may overflow", a symptom
9296 of the confusion.
f00bbb22 9297 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9298 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9299
6468f31c
LMI
93002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9301
49080b10
LMI
9302 * search.c (Fre_search_backward): Mention `case-fold-search' in
9303 all the re_search_* functions (bug#8138).
9304
6468f31c
LMI
9305 * keyboard.c (Fopen_dribble_file): Document when the file is
9306 closed (bug#8056).
9307
c965adc5
EZ
93082011-07-14 Eli Zaretskii <eliz@gnu.org>
9309
df9733bf
EZ
9310 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9311 bidi_cache_idx.
9312
0bb23927
EZ
9313 Support bidi reordering of display and overlay strings.
9314 * xdisp.c (compute_display_string_pos)
9315 (compute_display_string_end): Accept additional argument STRING.
9316 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9317 (reseat_to_string): Initialize bidi_it->string.s and
9318 bidi_it->string.schars.
9319 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9320 NULL (avoids a crash in bidi_paragraph_init).
9321 Initialize itb.string.lstring.
0bb23927
EZ
9322 (init_iterator): Call bidi_init_it only of a valid
9323 buffer position was specified. Initialize paragraph_embedding to
9324 L2R.
9325 (reseat_to_string): Initialize the bidi iterator.
9326 (display_string): If we need to ignore text properties of
9327 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9328 original value of -1 will not work with bidi.)
9329 (compute_display_string_pos): First arg is now struct
9330 `text_pos *'; all callers changed. Support display properties on
9331 Lisp strings.
9332 (compute_display_string_end): Support display properties on Lisp
9333 strings.
9334 (init_iterator, reseat_1, reseat_to_string): Initialize the
9335 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9336 when iterating on a string not from display properties).
640c8776
SM
9337 (compute_display_string_pos, compute_display_string_end):
9338 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9339 arrow keys.
9340 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9341 base_level_stop; instead, set base_level_stop to BEGV.
9342 Fixes crashes in vertical-motion.
0bb23927
EZ
9343 (next_element_from_buffer): Improve commentary for when
9344 the iterator is before prev_stop.
9345 (init_iterator): Initialize bidi_p from the default value of
9346 bidi-display-reordering, not from buffer-local value. Use the
9347 buffer-local value only if initializing for buffer iteration.
9348 (handle_invisible_prop): Support invisible properties on strings
9349 that are being bidi-reordered.
9350 (set_iterator_to_next): Support bidi reordering of C strings and
9351 Lisp strings.
9352 (next_element_from_string): Support bidi reordering of Lisp
9353 strings.
9354 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9355 (display_string): Support display of R2L glyph rows.
9356 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9357 (init_iterator): Don't initialize it->bidi_p for strings
9358 here.
9359 (reseat_to_string): Initialize it->bidi_p for strings here.
9360 (next_element_from_string, next_element_from_c_string)
9361 (next_element_from_buffer): Add xassert's for correspondence
9362 between IT's object being iterated and it->bidi_it.string
9363 structure.
9364 (face_before_or_after_it_pos): Support bidi iteration.
9365 (next_element_from_c_string): Handle the case of the first string
9366 character that is not the first one in the visual order.
9367 (get_visually_first_element): New function, refactored from common
9368 parts of next_element_from_buffer, next_element_from_string, and
9369 next_element_from_c_string.
9370 (tool_bar_lines_needed, redisplay_tool_bar)
9371 (display_menu_bar): Force left-to-right direction. Add a FIXME
9372 comment for making that be controlled by a user option.
9373 (push_it, pop_it): Save and restore the state of the
9374 bidi iterator. Save and restore the bidi_p flag.
9375 (pop_it): Iterate out of display property for string iteration as
9376 well.
9377 (iterate_out_of_display_property): Support iteration over strings.
9378 (handle_single_display_spec): Set up it->bidi_it for iteration
9379 over a display string, and call bidi_init_it.
9380 (handle_single_display_spec, next_overlay_string)
9381 (get_overlay_strings_1, push_display_prop): Set up the bidi
9382 iterator for displaying display or overlay strings.
9383 (forward_to_next_line_start): Don't use the shortcut if
9384 bidi-iterating.
9385 (back_to_previous_visible_line_start): If handle_display_prop
9386 pushed the iterator stack, restore the internal state of the bidi
9387 iterator by calling bidi_pop_it same number of times.
9388 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9389 and we are bidi-iterating, don't decrement the iterator position;
9390 instead, set the first_elt flag in the bidi iterator, to produce
9391 the same effect.
9392 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9393 (push_display_prop): xassert that we are iterating a buffer.
9394 (push_it, pop_it): Save and restore paragraph_embedding member.
9395 (handle_single_display_spec, next_overlay_string)
9396 (get_overlay_strings_1, reseat_1, reseat_to_string)
9397 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9398 correctly. Don't assume unibyte strings are not bidi-reordered.
9399 (compute_display_string_pos)
9400 (compute_display_string_end): Fix handling the case of C string.
9401 (push_it, pop_it): Save and restore from_disp_prop_p.
9402 (handle_single_display_spec, push_display_prop): Set the
9403 from_disp_prop_p flag.
9404 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9405 (pop_it): Call iterate_out_of_display_property only if we are
9406 popping after iteration over a string that came from a display
9407 property. Fix a typo in popping stretch info. Add an assertion
9408 for verifying that the iterator position is in sync with the bidi
9409 iterator.
9410 (handle_single_display_spec, get_overlay_strings_1)
9411 (push_display_prop): Fix initialization of paragraph direction for
9412 string when that of the parent object is not yet determined.
9413 (reseat_1): Call bidi_init_it to resync the bidi
9414 iterator with IT's position. (Bug#7616)
9415 (find_row_edges): If ROW->start.pos gives position
9416 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9417 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9418 Reset the from_disp_prop_p flag.
9419 (SAVE_IT, RESTORE_IT): New macros.
9420 (pos_visible_p, face_before_or_after_it_pos)
9421 (back_to_previous_visible_line_start)
9422 (move_it_in_display_line_to, move_it_in_display_line)
9423 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9424 (try_scrolling, redisplay_window, display_line): Use them when
9425 saving a temporary copy of the iterator and restoring it back.
9426 (back_to_previous_visible_line_start, reseat_1)
9427 (init_iterator): Empty the bidi cache "stack".
9428 (move_it_in_display_line_to): If iterator ended up at
9429 EOL, but we never saw any buffer positions smaller than
9430 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9431 motion in bidi-reordered lines.
9432 (move_it_in_display_line_to): Record prev_method and prev_pos
9433 immediately before the call to set_iterator_to_next. Fixes cursor
9434 motion in bidi-reordered lines with stretch glyphs and strings
9435 displayed in margins. (Bug#8133) (Bug#8867)
9436 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9437 TO_CHARPOS.
640c8776
SM
9438 (pos_visible_p): Support positions in bidi-reordered lines.
9439 Save and restore bidi cache.
0bb23927
EZ
9440
9441 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9442 (bidi_paragraph_info): Delete unused struct.
9443 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9444 (bidi_cache_start): New variable.
9445 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9446 to zero.
9447 (bidi_cache_fetch_state, bidi_cache_search)
9448 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9449 (bidi_cache_find, bidi_peek_at_next_level)
9450 (bidi_level_of_next_char, bidi_find_other_level_edge)
9451 (bidi_move_to_visually_next): Compare cache index with
9452 bidi_cache_start rather than with zero.
9453 (bidi_fetch_char): Accept new argument STRING; all callers
9454 changed. Support iteration over a string. Support strings with
9455 display properties. Support unibyte strings. Fix the type of
9456 `len' according to what STRING_CHAR_AND_LENGTH expects.
9457 (bidi_paragraph_init, bidi_resolve_explicit_1)
9458 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9459 (bidi_level_of_next_char, bidi_move_to_visually_next):
9460 Support iteration over a string.
0bb23927
EZ
9461 (bidi_set_sor_type, bidi_resolve_explicit_1)
9462 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9463 can now be zero (for strings); special values 0 and -1 were
9464 changed to -1 and -2, respectively.
9465 (bidi_char_at_pos): New function.
9466 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9467 Call it instead of FETCH_MULTIBYTE_CHAR.
9468 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9469 initialized to valid values.
9470 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9471 values.
9472 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9473 the test for valid cached positions. Fix the logic for looking up
9474 the sentinel state in the cache. GCPRO the Lisp string we are
9475 iterating.
9476 (bidi_push_it, bidi_pop_it): New functions.
9477 (bidi_initialize): Initialize the bidi cache start stack pointer.
9478 (bidi_cache_ensure_space): New function, refactored from part of
9479 bidi_cache_iterator_state. Don't assume the required size is just
9480 one BIDI_CACHE_CHUNK away.
9481 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9482 (bidi_count_bytes, bidi_char_at_pos): New functions.
9483 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9484 always valid if bidi_cache_idx is valid.
9485 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9486 is valid if it's going to be used.
9487 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9488 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9489 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9490 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9491 (bidi_find_other_level_edge, bidi_cache_start_stack):
9492 All variables related to cache indices are now EMACS_INT.
c965adc5 9493
0bb23927
EZ
9494 * dispextern.h (struct bidi_string_data): New structure.
9495 (struct bidi_it): New member `string'. Make flag members be 1-bit
9496 fields, and put them last in the struct.
640c8776
SM
9497 (compute_display_string_pos, compute_display_string_end):
9498 Update prototypes.
0bb23927
EZ
9499 (bidi_push_it, bidi_pop_it): Add prototypes.
9500 (struct iterator_stack_entry): New members bidi_p,
9501 paragraph_embedding, and from_disp_prop_p.
9502 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9503 (bidi_shelve_cache, bidi_unshelve_cache):
9504 Declare prototypes.
0bb23927
EZ
9505
9506 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9507 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9508 and vector-like objects.
9509
9510 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9511 cache around display iteration.
9512
9513 * window.c (Fwindow_end, window_scroll_pixel_based)
9514 (displayed_window_lines, Frecenter): Save and restore the bidi
9515 cache around display iteration.
9516
3bbd2265
LMI
95172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9518
9519 * editfns.c (Fdelete_region): Clarify the use of the named
9520 parameters (bug#6788).
9521
adc47434
MR
95222011-07-14 Martin Rudalics <rudalics@gmx.at>
9523
9524 * indent.c (Fvertical_motion): Set and restore w->pointm when
9525 saving and restoring the window's buffer (Bug#9006).
9526
837c31f8
LMI
95272011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9528
9529 * editfns.c (Fstring_to_char): Clarify just what is returned
9530 (bug#6576). Text by Eli Zaretskii.
9531
ac389d0c
JB
95322011-07-13 Juanma Barranquero <lekktu@gmail.com>
9533
9534 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9535
0be0ce47
EZ
95362011-07-13 Eli Zaretskii <eliz@gnu.org>
9537
9538 * buffer.c (mmap_find): Fix a typo.
9539
cd18e7e3
JB
95402011-07-13 Johan Bockgård <bojohan@gnu.org>
9541
9542 Fix execution of x selection hooks.
9543 * xselect.c (Qx_lost_selection_functions)
9544 (Qx_sent_selection_functions): New vars.
9545 (syms_of_xselect): DEFSYM them.
9546 (x_handle_selection_request): Pass Qx_sent_selection_functions
9547 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9548 (x_handle_selection_clear,x_clear_frame_selections):
9549 Pass Qx_lost_selection_functions rather than
9550 Vx_lost_selection_functions to Frun_hook_with_args.
9551
47ea7f44
PE
95522011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9553
ac389d0c 9554 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9555 The old code sometimes used this field without initializing it.
9556
47ea7f44
PE
9557 * alloc.c (gc_sweep): Don't read past end of array.
9558 In theory, the old code could also have corrupted Emacs internals,
9559 though it'd be very unlikely.
9560
bc985c87
AS
95612011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9562
9563 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9564 argument. (Bug#4026)
bc985c87 9565
0cf34688
LMI
95662011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9567
b3dadd76
LMI
9568 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9569 key" (bug#4257).
9570
0cf34688
LMI
9571 * window.c (Fset_window_start): Doc fix (bug#4199).
9572 (Fset_window_hscroll): Ditto.
9573
270768cd
PE
95742011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9575
077e3dda 9576 Fix minor new problems caught by GCC 4.6.1.
270768cd 9577 * term.c (init_tty): Remove unused local.
490011a6 9578 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9579 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9580 not used otherwise.
270768cd 9581
b1f58454
CY
95822011-07-12 Chong Yidong <cyd@stupidchicken.com>
9583
9584 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9585
22b9578d
LMI
95862011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9587
6e70ab07
LMI
9588 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9589 are the mini-buffer and the echo area (bug#3320).
9590
22b9578d
LMI
9591 * term.c (init_tty): Remove support for supdup, c10 and perq
9592 terminals, which are no longer supported (bug#1482).
9593
8974cc9f
JB
95942011-07-10 Johan Bockgård <bojohan@gnu.org>
9595
9596 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9597
a560d974
JD
95982011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9599
9600 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9601 for non-popups (Bug#3642).
9602
1dae0f0a
AS
96032011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9604
268c2c36 9605 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9606 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9607 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9608 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9609 * data.c (fmod): Likewise.
9610 * dispnew.c (swap_glyphs_in_rows): Likewise.
9611 * emacs.c (memory_warning_signal): Likewise.
9612 * floatfns.c (float_error): Likewise.
9613 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9614 (otf_open, font_otf_capability, generate_otf_features)
9615 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9616 Likewise.
9617 * image.c (pbm_read_file): Likewise.
9618 * indent.c (string_display_width): Likewise.
9619 * intervals.c (check_for_interval, search_for_interval)
9620 (inc_interval_count, count_intervals, root_interval)
9621 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9622 * lread.c (defalias): Likewise.
268c2c36 9623 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9624 * regex.c (set_image_of_range_1, set_image_of_range)
9625 (regex_grow_registers): Likewise.
9626 * sysdep.c (strerror): Likewise.
9627 * termcap.c (valid_filename_p, tprint, main): Likewise.
9628 * tparam.c (main): Likewise.
9629 * unexhp9k800.c (run_time_remap, save_data_space)
9630 (update_file_ptrs, read_header, write_header, calculate_checksum)
9631 (copy_file, copy_rest, display_header): Likewise.
9632 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9633 Likewise.
9634 * xdisp.c (check_it): Likewise.
9635 * xfaces.c (register_color, unregister_color, unregister_colors):
9636 Likewise.
9637 * xfns.c (print_fontset_result): Likewise.
9638 * xrdb.c (member, fatal, main): Likewise.
9639
99033785
PE
96402011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9641
9642 Fix minor problems found by static checking (Bug#9031).
9643 * chartab.c (char_table_set_range, map_sub_char_table):
9644 Remove unused locals.
9645 (uniprop_table): Now static.
9646 * composite.c (_work_char): Remove unused static var.
9647
9cb2ac56
JB
96482011-07-09 Juanma Barranquero <lekktu@gmail.com>
9649
9650 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9651
f25661f0
JD
96522011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9653
9654 * gtkutil.c (qttip_cb): Remove code without function.
9655
8278c4fe
EZ
96562011-07-09 Eli Zaretskii <eliz@gnu.org>
9657
9658 * w32.c (pthread_sigmask): New stub.
9659
1692ae2d 96602011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9661
8a6ebd58 9662 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9663 sigprocmask is portable only for single-threaded applications, and
9664 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9665 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9666 (LIBES): Use it.
9667 * callproc.c (Fcall_process):
9668 * process.c (create_process):
9669 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9670 Use pthread_sigmask, not sigprocmask.
123403e4 9671
1b854618
JD
96722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9673
9674 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9675 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9676 wrong (Bug#8591).
9677
3fe4b549
JD
96782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9679
0ce7e563
JD
9680 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9681 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9682 (xg_hide_tooltip): Fix comment.
9683
3fe4b549
JD
9684 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9685 in registerServicesMenuSendTypes.
9686 (validRequestorForSendType): Don't check ns_return_types.
9687
9688 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9689 ns_return_type.
9690
5df75e47
JR
96912011-07-08 Jason Rumney <jasonr@gnu.org>
9692
22610910
JR
9693 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9694 SH_SHOW for hidden windows (Bug#5482).
9695
5df75e47
JR
9696 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9697 frame struct members of non-existent frames (Bug#6284).
9698
699c10bd
JD
96992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9700
4393663b
JD
9701 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9702 variable firstTime not needed on OSX >= 10.6.
9703 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9704 >= 10.5. Use setKnobProportion, setDoubleValue.
9705
9706 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9707 (MAC_OS_X_VERSION_10_5): Define if not defined.
9708 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9709 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9710 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9711
9712 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9713 cString and lossyCString on OSX >= 10.4.
4393663b 9714
58179cce 9715 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9716 sizeToFit on OSX >= 10.2.
9717
9718 * nsimage.m (allocInitFromFile): Don't use deprecated method
9719 bestRepresentationForDevice on OSX >= 10.6.
9720
9721 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9722 to avoid warning.
9723
9724 * emacs.c: Declare unexec_init_emacs_zone.
9725
a63e0781
JD
9726 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9727
699c10bd
JD
9728 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9729
9730 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9731 on svcsMenu (Bug#8842).
9732
9733 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9734 ns_return_types.
9735 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9736
9737 * nsterm.m (QUTF8_STRING): Declare.
9738 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9739 (validRequestorForSendType): Return type is (id).
9740 Change indexOfObjectIdenticalTo to indexOfObject.
9741 Check if we have local selection before returning self (Bug#8842).
9742 (writeSelectionToPasteboard): Put local selection into paste board
9743 if we have a local selection (Bug#8842).
9744 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9745
9746 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9747 (ns_get_local_selection): Declare.
9748
54e10184
LMI
97492011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9750
9888ff71
LMI
9751 * keymap.c (describe_map_tree): Don't insert a double newline at
9752 the end of the buffer (bug#1169) and return whether we inserted
9753 something.
9754
54e10184
LMI
9755 * callint.c (Fcall_interactively): Change "reading args" to
9756 "providing args" to try to clarify what it does (bug#1010).
9757
15fa4783
KH
97582011-07-07 Kenichi Handa <handa@m17n.org>
9759
9760 * composite.c (composition_compute_stop_pos): Ignore a static
9761 composition starting before CHARPOS (Bug#8915).
9762
9763 * xdisp.c (handle_composition_prop): Likewise.
9764
a8815b00
EZ
97652011-07-07 Eli Zaretskii <eliz@gnu.org>
9766
9767 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9768 (Bug#9015)
9769
ef7b981d 97702011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9771
9772 * character.h (unicode_category_t): New enum type.
9773
9774 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9775 (Qchar_code_property_table): New variable.
9776 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9777 (UNIPROP_COMPRESSED_FORM_P): New macros.
9778 (char_table_ascii): Uncompress the compressed values.
9779 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9780 Uncompress the compressed values.
ac389d0c 9781 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9782 (char_table_ref_and_range): Uncompress the compressed values.
9783 (sub_char_table_set): New arg is_uniprop. Callers changed.
9784 Uncompress the compressed values.
9785 (sub_char_table_set_range): Args changed. Callers changed.
9786 (char_table_set_range): Adjuted for the above change.
9787 (map_sub_char_table): Delete args default_val and parent. Add arg
9788 top. Give decoded values to a Lisp function.
640c8776 9789 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9790 values to a Lisp function. Gcpro more variables.
9791 (uniprop_table_uncompress)
9792 (uniprop_decode_value_run_length): New functions.
9793 (uniprop_decoder, uniprop_decoder_count): New variables.
9794 (uniprop_get_decoder, uniprop_encode_value_character)
9795 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9796 New functions.
9797 (uniprop_encoder, uniprop_encoder_count): New variables.
9798 (uniprop_get_encoder, uniprop_table)
9799 (Funicode_property_table_internal, Fget_unicode_property_internal)
9800 (Fput_unicode_property_internal): New functions.
9801 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9802 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9803 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9804 char-code-property-alist.
9805
640c8776 9806 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9807 Vunicode_category_table.
9808
640c8776 9809 * font.c (font_range): Adjust for the change of
c805dec0
KH
9810 Vunicode_category_table.
9811
76b397fb
DN
98122011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9813
9814 * m/iris4d.h: Remove file, move contents ...
9815 * s/irix6-5.h: ... here.
9816
22b4128e
PE
98172011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9818
9819 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9820 * alloc.c (mark_buffer):
9821 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9822 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9823 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9824 This isn't true in general, and it's particularly not true
9825 if Emacs is configured with --with-wide-int.
9826 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9827 New macros, used in the buffer.c change.
9828
869795d6
JD
98292011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9830
9831 * xsettings.c: Use both GConf and GSettings if both are available.
9832 (store_config_changed_event): Add comment.
9833 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9834 (store_tool_bar_style_changed): New functions.
5e617bc2 9835 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9836 (struct xsettings): Move font inside HAVE_XFT.
9837 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9838 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9839 Move inside HAVE_XFT.
640c8776 9840 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9841 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9842 also.
9843 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9844 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9845 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9846 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9847 (parse_settings): Move check for font inside HAVE_XFT.
9848 (read_settings, apply_xft_settings): Add comment.
9849 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9850 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9851 call store_font_name_changed.
9852 (xft_settings_event): Add comment.
9853 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9854 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9855 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9856 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9857 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9858 (xsettings_get_system_font, xsettings_get_system_normal_font):
9859 Add comment.
869795d6 9860
d8ed26bd
PE
98612011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9862
9863 Random fixes. E.g., (random) never returned negative values.
9864 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9865 subseconds part to the entropy, as that's a bit more random.
9866 Prefer signed to unsigned, since the signedness doesn't matter and
9867 in general we prefer signed. When given a limit, use a
9868 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9869 latter isn't right if USE_2_TAGS_FOR_INTS.
9870 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9871 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9872
cabf1cac
SM
98732011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9874
9875 * textprop.c (text_property_stickiness):
9876 Obey Vtext_property_default_nonsticky.
9877 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9878 * w32fns.c (syms_of_w32fns):
9879 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9880
6e9b2be9
PE
98812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9882
9883 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9884 This is more efficient than Ffile_directory_p and avoids a minor race.
9885
90186c68
LMI
98862011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9887
7c301272
LMI
9888 * buffer.c (Foverlay_put): Say what the return value is
9889 (bug#7835).
9890
c4f2d8d4
LMI
9891 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9892 is a directory before asking whether to use the file name
9893 (bug#7564).
ad637907
LMI
9894 (barf_or_query_if_file_exists): Make the "File is a directory"
9895 error be more correct.
c4f2d8d4 9896
90186c68
LMI
9897 * fns.c (Frequire): Remove the mention of the .gz files, since
9898 that's installation-specific, but keep the mention of
9899 `get-load-suffixes'.
9900
da64016e
PE
99012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9902
9903 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9904 Report string overflow if the output is too long.
9905
7d47b580
JB
99062011-07-04 Juanma Barranquero <lekktu@gmail.com>
9907
a555cb87
JB
9908 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9909 (syms_of_gnutls): Remove duplicate DEFSYM for
9910 Qgnutls_bootprop_verify_hostname_error, an error for
9911 Qgnutls_bootprop_verify_error (which is no longer used).
9912
7d47b580
JB
9913 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9914 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9915 Also (re)move comments that are misplaced or no longer relevant.
9916
1e49bfab
LMI
99172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9918
9919 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9920
1485f4c0
CY
99212011-07-03 Chong Yidong <cyd@stupidchicken.com>
9922
9923 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9924 and background color parameters if they have been changed.
9925
a9ab721e
LMI
99262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9927
9928 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9929
cf7cff57
PE
99302011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9931
2e13213d
PE
9932 * xsettings.c (SYSTEM_FONT): Define only when used.
9933 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9934
cf7cff57
PE
9935 * keymap.c (access_keymap_1): Now static.
9936
7a8e04f7
CY
99372011-07-02 Chong Yidong <cyd@stupidchicken.com>
9938
9939 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9940 leave any prefix arg for the up event (Bug#1586).
9941
61352f62
LMI
99422011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9943
69bb1ef7
LMI
9944 * lread.c (syms_of_lread): Mention single symbols defined by
9945 `defvar' or `defconst' (bug#7154).
9946
61352f62 9947 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9948 (Frequire): Mention get-load-suffixes.
61352f62 9949
28545e04
MR
99502011-07-02 Martin Rudalics <rudalics@gmx.at>
9951
9952 * window.h (window): Remove clone_number slot.
9953 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9954 Remove.
9955 (make_parent_window, make_window, saved_window)
9956 (Fset_window_configuration, save_window_save): Don't deal with
9957 clone numbers.
9958 * buffer.c (Qclone_number): Remove declaration.
9959 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9960
3349e122
SM
99612011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9962
9963 Add multiple inheritance to keymaps.
9964 * keymap.c (Fmake_composed_keymap): New function.
9965 (Fset_keymap_parent): Simplify.
9966 (fix_submap_inheritance): Remove.
9967 (access_keymap_1): New function extracted from access_keymap to handle
9968 embedded parents and handle lists of maps.
9969 (access_keymap): Use it.
9970 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9971 (Fcopy_keymap): Handle embedded parents.
9972 (Fcommand_remapping, define_as_prefix): Simplify.
9973 (Fkey_binding): Simplify.
9974 (syms_of_keymap): Move minibuffer-local-completion-map,
9975 minibuffer-local-filename-completion-map,
9976 minibuffer-local-must-match-map, and
9977 minibuffer-local-filename-must-match-map to Elisp.
9978 (syms_of_keymap): Defsubr make-composed-keymap.
9979 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9980 (parse_menu_item): Trivial simplification.
9981
3279eb87
GM
99822011-07-01 Glenn Morris <rgm@gnu.org>
9983
9984 * Makefile.in (SETTINGS_LIBS): Fix typo.
9985
4550efdf
KI
99862011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9987
9988 * coding.c (Fencode_coding_string): Record the last coding system
9989 used, as the function doc string says (bug#8738).
9990
0949d2b6
JD
99912011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9992
9993 * xsettings.c (store_monospaced_changed): Take new font as arg and
9994 check for change against current_mono_font.
9995 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9996 (emacs_settings_constructor, emacs_settings_get_property)
9997 (emacs_settings_set_property, emacs_settings_class_init)
9998 (emacs_settings_init, gsettings_obj): Remove.
9999 (something_changedCB): New function for HAVE_GSETTINGS.
10000 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10001 with value as argument.
10002 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10003 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10004 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10005 "changed".
10006
10007 * xgselect.c: Add defined (HAVE_GSETTINGS).
10008 (xgselect_initialize): Ditto.
10009
10010 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10011 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10012 xg_select.
10013
bbc6b304
PE
100142011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10015
10016 * eval.c (struct backtrace): Simplify and port the data structure.
10017 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10018 signed bit field, as this assumption is not portable and it makes
10019 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10020 "char debug_on_exit : 1" as this is not portable either; instead,
10021 use the portable "unsigned int debug_on_exit : 1". Remove unused
10022 member evalargs. Remove obsolete comments about cc bombing out.
10023
9851bfc5
JD
100242011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10025
51bb811f 10026 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10027 Let HAVE_GSETTINGS override HAVE_GCONF.
10028 (store_monospaced_changed): New function.
10029 (EMACS_SETTINGS): A new type derived from GObject to handle
10030 GSettings notifications.
10031 (emacs_settings_constructor, emacs_settings_get_property)
10032 (emacs_settings_set_property, emacs_settings_class_init):
10033 New functions.
10034 (gsettings_client, gsettings_obj): New variables.
10035 (GSETTINGS_SCHEMA): New define.
10036 (something_changedCB): Call store_monospaced_changed.
10037 (init_gsettings): New function.
10038 (xsettings_initialize): Call init_gsettings.
10039 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10040 to NULL.
10041
640c8776 10042 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10043 GCONF_CFLAGS/LIBS.
10044
5386012d
MR
100452011-06-29 Martin Rudalics <rudalics@gmx.at>
10046
10047 * window.c (resize_root_window, grow_mini_window)
10048 (shrink_mini_window): Rename Qresize_root_window to
10049 Qwindow_resize_root_window and Qresize_root_window_vertically to
10050 Qwindow_resize_root_window_vertically.
10051
f13e0b08
PE
100522011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10053
10054 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10055
94515237
JB
100562011-06-27 Juanma Barranquero <lekktu@gmail.com>
10057
10058 * makefile.w32-in: Redesign dependencies so they reflect more
10059 clearly which files are directly included by each source file,
10060 and not through other includes.
10061
e43b6e43
MR
100622011-06-27 Martin Rudalics <rudalics@gmx.at>
10063
10064 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10065 (sort_overlays, overlay_strings): When an overlay's clone number
10066 matches the window's clone number process the overlay even if
10067 the overlay's window property doesn't match the current window.
10068
d68443dc
MR
10069 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10070 (Fwindow_hchild): Rename to Fwindow_left_child.
10071 (Fwindow_next): Rename to Fwindow_next_sibling.
10072 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10073 (resize_window_check): Rename to window_resize_check.
10074 (resize_window_apply): Rename to window_resize_apply.
10075 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10076 (Fdelete_other_windows_internal, resize_frame_windows)
10077 (Fsplit_window_internal, Fdelete_window_internal)
10078 (grow_mini_window, shrink_mini_window)
10079 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10080
c7e73be5
JD
100812011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10082
10083 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10084 (emacs_fixed_set_min_size): Remove.
10085 (emacs_fixed_new): Take frame as argument.
10086
10087 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10088 (_EmacsFixedPrivate): Remove minwidth/height.
10089 Add struct frame *f.
10090 (emacs_fixed_init): Initialize priv->f.
10091 (get_parent_class, emacs_fixed_set_min_size): Remove.
10092 (emacs_fixed_new): Set priv->f to argument.
10093 (emacs_fixed_get_preferred_width)
10094 (emacs_fixed_get_preferred_height): Use min_width/height from
10095 frames size_hint to set minimum and natural (Bug#8919).
10096 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10097 and use min_width/height from frames size_hint to set
10098 min_width/height (Bug#8919).
10099
10100 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10101 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10102 Fix indentation.
c7e73be5 10103
cf99dcf8
EZ
101042011-06-26 Eli Zaretskii <eliz@gnu.org>
10105
10106 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10107 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10108 called at ZV.
10109
029529ac
CY
101102011-06-26 Chong Yidong <cyd@stupidchicken.com>
10111
10112 * process.c (wait_reading_process_output): Bypass select if
10113 waiting for a cell while ignoring keyboard input, and input is
10114 pending. Suggested by Jan Djärv (Bug#8869).
10115
7a7ef429
PE
101162011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10117
10118 Use gnulib's dup2 module instead of rolling our own.
10119 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10120
11fdef7d 101212011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10122
10123 * dispnew.c (scrolling_window): Before scrolling, turn off a
10124 mouse-highlight in the window being scrolled.
10125
cd3520a4
JB
101262011-06-24 Juanma Barranquero <lekktu@gmail.com>
10127
10128 Move DEFSYM to lisp.h and use everywhere.
10129
10130 * character.h (DEFSYM): Move declaration...
10131 * lisp.h (DEFSYM): ...here.
10132
10133 * gnutls.c:
10134 * minibuf.c:
10135 * w32menu.c:
10136 * w32proc.c:
10137 * w32select.c: Don't include character.h.
10138
10139 * alloc.c (syms_of_alloc):
10140 * buffer.c (syms_of_buffer):
10141 * bytecode.c (syms_of_bytecode):
10142 * callint.c (syms_of_callint):
10143 * casefiddle.c (syms_of_casefiddle):
10144 * casetab.c (init_casetab_once):
10145 * category.c (init_category_once, syms_of_category):
10146 * ccl.c (syms_of_ccl):
10147 * cmds.c (syms_of_cmds):
10148 * composite.c (syms_of_composite):
10149 * dbusbind.c (syms_of_dbusbind):
10150 * dired.c (syms_of_dired):
10151 * dispnew.c (syms_of_display):
10152 * doc.c (syms_of_doc):
10153 * editfns.c (syms_of_editfns):
10154 * emacs.c (syms_of_emacs):
10155 * eval.c (syms_of_eval):
10156 * fileio.c (syms_of_fileio):
10157 * fns.c (syms_of_fns):
10158 * frame.c (syms_of_frame):
10159 * fringe.c (syms_of_fringe):
10160 * insdel.c (syms_of_insdel):
10161 * keymap.c (syms_of_keymap):
10162 * lread.c (init_obarray, syms_of_lread):
10163 * macros.c (syms_of_macros):
10164 * msdos.c (syms_of_msdos):
10165 * print.c (syms_of_print):
10166 * process.c (syms_of_process):
10167 * search.c (syms_of_search):
10168 * sound.c (syms_of_sound):
10169 * syntax.c (init_syntax_once, syms_of_syntax):
10170 * terminal.c (syms_of_terminal):
10171 * textprop.c (syms_of_textprop):
10172 * undo.c (syms_of_undo):
10173 * w32.c (globals_of_w32):
10174 * window.c (syms_of_window):
10175 * xdisp.c (syms_of_xdisp):
10176 * xfaces.c (syms_of_xfaces):
10177 * xfns.c (syms_of_xfns):
10178 * xmenu.c (syms_of_xmenu):
10179 * xsettings.c (syms_of_xsettings):
10180 * xterm.c (syms_of_xterm): Use DEFSYM.
10181
4228cf16
TZ
101822011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10183
cd3520a4 10184 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10185
7fcccf1e
PE
101862011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10187
7efb4e0e
PE
10188 Integer and buffer overflow fixes (Bug#8873).
10189
ff5844ad
PE
10190 * print.c (printchar, strout): Check for string overflow.
10191 (PRINTPREPARE, printchar, strout):
10192 Don't set size unless allocation succeeds.
10193
90532f02
PE
10194 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10195 for sizes. Check for string overflow more accurately.
10196 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10197
6d84508d
PE
10198 * macros.c: Integer and buffer overflow fixes.
10199 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10200 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10201 Use ptrdiff_t, not int, for sizes.
10202 Don't increment bufsize until after realloc succeeds.
10203 Check for size-calculation overflow.
10204 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10205
437b2cb4
PE
10206 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10207
8b9ac8b4
PE
10208 * lread.c: Integer overflow fixes.
10209 (read_integer): Radix is now EMACS_INT, not int,
10210 to improve quality of diagnostics for out-of-range radices.
10211 Calculate buffer size correctly for out-of-range radices.
10212 (read1): Check for integer overflow in radices, and in
10213 read-circle numbers.
82cb60d3
PE
10214 (read_escape): Avoid int overflow.
10215 (Fload, openp, read_buffer_size, read1)
10216 (substitute_object_recurse, read_vector, read_list, map_obarray):
10217 Use ptrdiff_t, not int, for sizes.
10218 (read1): Use EMACS_INT, not int, for sizes.
20270765 10219 Check for size overflow.
8b9ac8b4 10220
7fcccf1e
PE
10221 * image.c (cache_image): Check for size arithmetic overflow.
10222
bfbbd7e7
PE
10223 * lread.c: Integer overflow issues.
10224 (saved_doc_string_size, saved_doc_string_length)
10225 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10226 Now ptrdiff_t, not int.
10227 (read1): Don't assume doc string length fits in int. Check for
10228 out-of-range doc string lengths.
10229 (read_list): Don't assume file position fits in int.
39019e54 10230 (read_escape): Check for hex character overflow.
bfbbd7e7 10231
4e323265
LL
102322011-06-22 Leo Liu <sdl.web@gmail.com>
10233
10234 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10235 Move to minibuffer.el.
10236
85fece3e
PE
102372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10238
20b84ce9 10239 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10240 The following patches are for when GLYPH_DEBUG && !XASSERT.
10241 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10242 * dispnew.c (flush_stdout):
10243 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10244 Mark as externally visible.
10245 * dispnew.c (check_window_matrix_pointers): Now static.
10246 * dispnew.c (window_to_frame_vpos):
10247 * xfns.c (unwind_create_frame):
10248 * xterm.c (x_check_font): Remove unused local.
10249 * scroll.c (CHECK_BOUNDS):
10250 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10251 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10252 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10253 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10254 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10255 Now static.
10256 (debug_method_add): Use va_list and vsprintf rather than relying
10257 on undefined behavior with wrong number of arguments.
10258 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10259 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10260 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10261 since we're not interested in debugging glyphs with old libraries.
10262 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10263 GCC 4.6.0's static checking.
10264
0766b489
PE
102652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10266
31fd4b32
PE
10267 Integer overflow and signedness fixes (Bug#8873).
10268 A few related buffer overrun fixes, too.
10269
b79e8648
PE
10270 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10271
0766b489
PE
10272 * dispextern.h (struct face.stipple):
10273 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10274 (x_bitmap_mask, x_allocate_bitmap_record)
10275 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10276 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10277 (x_create_bitmap_from_xpm_data):
10278 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10279 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10280 (.bitmaps_last):
10281 * xfaces.c (load_pixmap):
10282 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10283 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10284 (.bitmaps_last, struct x_output.icon_bitmap):
10285 Use ptrdiff_t, not int, for bitmap indexes.
10286 (x_allocate_bitmap_record): Check for size overflow.
10287 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10288
b081724f
PE
10289 Use ptrdiff_t, not int, for overlay counts.
10290 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10291 * editfns.c (overlays_around, get_pos_property):
10292 * textprop.c (get_char_property_and_overlay):
10293 * xdisp.c (next_overlay_change, note_mouse_highlight):
10294 * xfaces.c (face_at_buffer_position):
21514da7
PE
10295 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10296 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10297 (Fnext_overlay_change, Fprevious_overlay_change)
10298 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10299 Use ptrdiff_t, not int, for sizes.
21514da7 10300 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10301
3de73e5e
PE
10302 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10303
2606c57b
PE
10304 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10305 (x_session_initialize): Do not assume string length fits in int.
10306
aaafe47a
PE
10307 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10308 This is unlikely, but can occur if DPI is outlandish.
10309
2674ddc8 10310 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10311 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10312
28154962
PE
10313 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10314 * xrdb.c (magic_file_p, search_magic_path):
10315 Omit last arg SUFFIX; it was always 0. All callers changed.
10316 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10317
7de51af5
PE
10318 * xfont.c (xfont_match): Avoid need for strlen.
10319
25ed6cc3
PE
10320 * xfns.c: Don't assume strlen fits in int.
10321 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10322
4eab31dd
PE
10323 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10324 not unsigned long, as we prefer signed integers. All callers changed.
10325 Detect integer overflow in repeat count.
10326 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10327 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10328
171e2a58
PE
10329 * termcap.c: Don't assume sizes fit in int and never overflow.
10330 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10331 (gobble_line): Check for size-calculation overflow.
10332
ad39faca 10333 * minibuf.c (Fread_buffer):
6e5bb2dc 10334 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10335 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10336 Don't assume string length fits in int.
10337
52c61c22 10338 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10339 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10340
b5b8c9e5
PE
10341 * font.c: Don't assume string length fits in int.
10342 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10343 Use ptrdiff_t, not int.
ccd6111c
PE
10344 (font_intern_prop): Don't assume string length fits in int.
10345 Don't assume integer property fits in fixnum.
10346 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10347
882f0d81 10348 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10349 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10350 Reformulate so as not to need the command string.
10351 Invoke gzip -cd rather than gunzip, as it's more portable.
10352 (lock_info_type, lock_file_1, lock_file):
10353 Don't assume pid_t and time_t fit in unsigned long.
10354 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10355 (current_lock_owner): Prefer signed type for sizes.
10356 Use memcpy, not strncpy, where memcpy is what is really wanted.
10357 Don't assume (via atoi) that time_t and pid_t fit in int.
10358 Check for time_t and/or pid_t out of range, e.g., via a network share.
10359 Don't alloca where an auto var works fine.
10360
93f4cf88
PE
10361 * fileio.c: Fix some integer overflow issues.
10362 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10363 Don't assume string length fits in int.
10364 (directory_file_name): Don't assume string length fits in long.
10365 (make_temp_name): Don't assume pid fits in int, or that its print
10366 length is less than 20.
10367
f3e92b69
PE
10368 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10369
1bfdaf10
PE
10370 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10371
35016e9a
PE
10372 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10373
3d1e65a1
PE
10374 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10375 We prefer signed integers, even for size calculations.
10376
0b963a93
PE
10377 * emacs.c: Don't assume string length fits in 'int'.
10378 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10379 (main): Don't invoke strlen when not needed.
10380
573f4b54
PE
10381 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10382 (XD_DEBUG_MESSAGE): Don't waste a byte.
10383
989f33ba
PE
10384 * callproc.c (getenv_internal_1, getenv_internal)
10385 (Fgetenv_internal):
965d34eb
PE
10386 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10387
e4d29b33
PE
10388 * lread.c (invalid_syntax): Omit length argument.
10389 All uses changed. This doesn't fix a bug, but it simplifies the
10390 code away from its former Hollerith-constant appearance, and it's
10391 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10392 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10393
eb49b136
PE
10394 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10395 This didn't break anything, but it didn't help either.
10396 It's confusing to put a bogus integer in a place where the actual
10397 value does not matter.
9f62aeb1 10398 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10399 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10400
15375a22
PE
10401 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10402 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10403 implementation.
b61cc01c
PE
10404 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10405 We prefer signed types, and the value cannot exceed the EMACS_INT
10406 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10407 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10408 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10409 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10410
53b2623d
PE
10411 * indent.c (sane_tab_width): New function.
10412 (current_column, scan_for_column, Findent_to, position_indentation)
10413 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10414 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10415
51cab52b 10416 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10417
f2ed8a70
PE
10418 * lisp.h (lint_assume): New macro.
10419 * composite.c (composition_gstring_put_cache):
10420 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10421
abe80cc6
PE
10422 * editfns.c, insdel.c:
10423 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10424
b02c740e
PE
10425 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10426
ebc96716
PE
10427 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10428
b4e50fa0 10429 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10430 Use much-faster test for byte-length change.
311d5d7c 10431 Don't assume string byte-length fits in 'int'.
a4cf38e4 10432 Check that character arg fits in 'int'.
85461888 10433 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10434
c0c1ee9f
PE
10435 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10436
a498d7f4
PE
10437 * fns.c (concat): Catch string overflow earlier.
10438 Do not rely on integer wraparound.
10439
51cab52b
PE
10440 * dispextern.h (struct it.overlay_strings_charpos)
10441 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10442 * xdisp.c (forward_to_next_line_start)
10443 (back_to_previous_visible_line_start)
10444 (reseat_at_next_visible_line_start, next_element_from_buffer):
10445 Don't arbitrarily truncate the value of 'selective' to int.
10446
76031fad
PE
10447 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10448
5eb55db9
PE
10449 * composite.c: Don't truncate sizes to 'int'.
10450 (composition_gstring_p, composition_reseat_it)
10451 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10452 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10453 not EMACS_UINT, for indexes.
5eb55db9 10454
0703a717
PE
10455 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10456
d6202519
PE
10457 * buffer.c: Include <verify.h>.
10458 (struct sortvec.priority, struct sortstr.priority):
8961a454 10459 Now EMACS_INT, not int.
c20998a7 10460 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10461 (struct sortstr.size, record_overlay_string)
10462 (struct sortstrlist.size, struct sortlist.used):
10463 Don't truncate size to int.
10464 (record_overlay_string): Check for size-calculation overflow.
d6202519 10465 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10466
d5a19415
JM
104672011-06-22 Jim Meyering <meyering@redhat.com>
10468
029529ac 10469 Don't leak an XBM-image-sized buffer
d5a19415
JM
10470 * image.c (xbm_load): Free the image buffer after using it.
10471
a9041e6c
PE
104722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10473
10474 Port to Sun C.
10475 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10476 that Sun C diagnosed.
10477 * fns.c (secure_hash): Fix pointer signedness issue.
10478 * intervals.c (static_offset_intervals): New function.
10479 (offset_intervals): Use it.
10480
7f3f739f
LL
104812011-06-21 Leo Liu <sdl.web@gmail.com>
10482
10483 * deps.mk (fns.o):
10484 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10485 sha512.h.
10486
10487 * fns.c (secure_hash): Rename from crypto_hash_function and change
10488 the first arg to accept symbols.
5b66d427 10489 (Fsecure_hash): New primitive.
7f3f739f
LL
10490 (syms_of_fns): New symbols.
10491
76147d94
DD
104922011-06-20 Deniz Dogan <deniz@dogan.se>
10493
10494 * process.c (Fset_process_buffer): Clarify return value in
10495 docstring.
10496
7d7d0045
CY
104972011-06-18 Chong Yidong <cyd@stupidchicken.com>
10498
10499 * dispnew.c (add_window_display_history): Use BVAR.
10500
10501 * xdisp.c (debug_method_add): Use BVAR.
10502 (check_window_end, dump_glyph_matrix, dump_glyph)
10503 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10504
10505 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10506 Likewise.
10507
10508 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10509 check till after the cache is created in init_frame_faces.
10510
ff2bc410
SM
105112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10512
10513 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10514
28177add
PE
105152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10516
dd3482fe
PE
10517 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10518 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10519 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10520
393d71f3 10521 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10522 * fileio.c (Finsert_file_contents):
10523 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10524 Remove the old (too-loose) buffer overflow checks.
10525 They weren't needed, since make_gap checks for buffer overflow.
10526 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10527 The old code merely checked for Emacs fixnum overflow, and relied
10528 on undefined (wraparound) behavior. The new code avoids undefined
10529 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10530
2e6813b0 10531 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10532 Tune. Don't use wider integers than needed. Don't use alloca.
10533 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10534
599a9e4f
PE
10535 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10536
99561444
PE
10537 * insdel.c, lisp.h (buffer_overflow): New function.
10538 (insert_from_buffer_1, replace_range, replace_range_2):
10539 * insdel.c (make_gap_larger):
10540 * editfns.c (Finsert_char):
10541 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10542
28177add
PE
10543 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10544
e69dafad
PE
105452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10546
4baa020d 10547 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10548
b1c46f02
PE
10549 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10550 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10551
e69dafad
PE
10552 * fileio.c: Don't assume EMACS_INT fits in off_t.
10553 (emacs_lseek): New static function.
10554 (Finsert_file_contents, Fwrite_region): Use it.
10555 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10556
566684ea
PE
10557 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10558
e6966cd6
PE
10559 * fns.c: Don't overflow int when computing a list length.
10560 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10561 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10562 truncation on 64-bit hosts. Check for QUIT every
10563 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10564 faster and is responsive enough.
10565 (Flength): Report an error instead of overflowing an integer.
10566 (Fsafe_length): Return a float if the value is not representable
10567 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10568 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10569 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10570
dd0b0efb
PE
10571 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10572 (header_size, word_size): New constants.
10573 (allocate_vectorlike): Don't check size overflow here.
10574 (allocate_vector): Check it here instead, since this is the only
10575 caller of allocate_vectorlike that could cause overflow.
10576 Check that the new vector's length is representable as a fixnum.
10577
86fe5cfe
PE
10578 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10579 The previous code was bogus. For example, next_almost_prime (32)
10580 returned 39, which is undesirable as it is a multiple of 3; and
10581 next_almost_prime (24) returned 25, which is a multiple of 5 so
10582 why was the code bothering to check for multiples of 7?
10583
80e88859
PE
10584 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10585
4a2f0ad6
PE
10586 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10587
f66c7cf8
PE
10588 Variadic C functions now count arguments with ptrdiff_t.
10589 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10590 Back then I didn't know that the Emacs coding style prefers signed int.
10591 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10592 were being counted with int, which may truncate counts on 64-bit
10593 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10594 * lisp.h (struct Lisp_Subr.function.aMANY)
10595 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10596 Arg counts are now ptrdiff_t, not size_t.
10597 All variadic functions and their callers changed accordingly.
10598 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10599 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10600 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10601 * callint.c (Fcall_interactively): Check arg count for overflow,
10602 to avoid potential buffer overrun. Use signed char, not 'int',
10603 for 'varies' array, so that we needn't bother to check its size
10604 calculation for overflow.
10605 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10606 * eval.c (apply_lambda):
10607 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10608 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10609 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10610
a1759b76
PE
10611 * callint.c (Fcall_interactively): Don't use index var as event count.
10612
d96be9fc
PE
10613 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10614 * mem-limits.h (SIZE): Remove; no longer used.
10615
a690a978 10616 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10617
578c21e6
PE
10618 Remove unnecessary casts.
10619 * xterm.c (x_term_init):
10620 * xfns.c (x_set_border_pixel):
10621 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10622 These aren't needed now that we assume ANSI C.
10623
96f53c6c
PE
10624 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10625 It's more likely to cause problems (due to unsigned overflow)
10626 than to cure them.
10627
83c77d31
PE
10628 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10629
ee2079f1
PE
10630 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10631
6da65536
PE
10632 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10633
7147c4a4
PE
10634 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10635
193e32d9
PE
10636 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10637
e5533da6
PE
10638 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10639
9910e595
PE
10640 GLYPH_CODE_FACE returns EMACS_INT, not int.
10641 * dispextern.h (merge_faces):
10642 * xfaces.c (merge_faces):
01103c44
PE
10643 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10644 Don't assume EMACS_INT fits in int.
9910e595 10645
2638320e
PE
10646 * character.h (CHAR_VALID_P): Remove unused parameter.
10647 * fontset.c, lisp.h, xdisp.c: All uses changed.
10648
045eb8d9
PE
10649 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10650
c1f134b5
PE
10651 * fns.c (concat): Minor tuning based on overflow analysis.
10652 This doesn't fix any bugs. Use int to hold character, instead
10653 of constantly refetching from Emacs object. Use XFASTINT, not
10654 XINT, for value known to be a character. Don't bother comparing
10655 a single byte to 0400, as it's always less.
10656
395fcb93 10657 * floatfns.c (Fexpt):
327eeec8
PE
10658 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10659
abbd3d23
PE
10660 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10661 for characters.
10662
684a03ef
PE
10663 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10664
0fed43f3
PE
10665 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10666 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10667 incorrectly succeed when S was a string, because 4294967386 was
10668 truncated before it was used.
10669
8fd02eb7
PE
10670 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10671 Otherwise, an out-of-range integer could cause undefined behavior
10672 on a 64-bit host.
10673
f8c86b69
PE
10674 * composite.c: Use int, not EMACS_INT, for characters.
10675 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10676 EMACS_INT, for values that are known to be in character range.
10677 This doesn't fix any bugs but is the usual style inside Emacs and
10678 may generate better code on 32-bit machines.
10679
34206dd2
PE
10680 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10681 This is for reasons similar to the recent CHAR_STRING fix.
10682 * charset.c (Fencode_char): Check that character arg is actually
10683 a character. Pass an int to ENCODE_CHAR.
10684 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10685 wider than 'int', as a compile-time check to prevent future regressions
10686 in this area.
10687
c5958d4c 10688 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10689
10690 Make sure a 64-bit char is never passed to CHAR_STRING.
10691 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10692 by silently ignoring the top 32 bits, allowing some values
10693 that were far too large to be valid characters.
10694 * character.h: Include <verify.h>.
10695 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10696 arguments are no wider than unsigned, as a compile-time check
10697 to prevent future regressions in this area.
10698 * data.c (Faset):
01103c44 10699 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10700 (Fsubst_char_in_region):
10701 * fns.c (concat):
10702 * xdisp.c (decode_mode_spec_coding):
10703 Adjust to CHAR_STRING's new requirement.
10704 * editfns.c (Finsert_char, Fsubst_char_in_region):
10705 * fns.c (concat): Check that character args are actually
10706 characters. Without this test, these functions did the wrong
10707 thing with wildly out-of-range values on 64-bit hosts.
10708
d37ca623
PE
10709 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10710 These casts should not be needed on 32-bit hosts, either.
10711 * keyboard.c (read_char):
10712 * lread.c (Fload): Remove casts to unsigned.
10713
ea204efb
PE
10714 * lisp.h (UNSIGNED_CMP): New macro.
10715 This fixes comparison bugs on 64-bit hosts.
10716 (ASCII_CHAR_P): Use it.
10717 * casefiddle.c (casify_object):
01103c44 10718 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10719 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10720 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10721 * dispextern.h (FACE_FROM_ID):
10722 * keyboard.c (read_char): Use UNSIGNED_CMP.
10723
41cb286c
PE
10724 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10725 not to EMACS_INT, to avoid GCC warning.
10726
4a1b9832
PE
10727 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10728
55daad71
PE
10729 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10730 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10731 isn't needed on 32-bit machines.
8f95c75c 10732
01103c44
PE
10733 * buffer.c (Fgenerate_new_buffer_name):
10734 Use EMACS_INT for count, not int.
0ceccced 10735 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10736
10737 * data.c (Qcompiled_function): Now static.
10738
c6f072e7
PE
10739 * window.c (window_body_lines): Now static.
10740
20ce5912
PE
10741 * image.c (gif_load): Rename local to avoid shadowing.
10742
9c4c5f81
PE
10743 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10744 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10745 * alloc.c (make_save_value): Integer argument is now of type
10746 ptrdiff_t, not int.
10747 (mark_object): Use ptrdiff_t, not int.
10748 * lisp.h (pD): New macro.
10749 * print.c (print_object): Use it.
10750
c0c5c8ae
PE
10751 * alloc.c: Use EMACS_INT, not int, to count objects.
10752 (total_conses, total_markers, total_symbols, total_vector_size)
10753 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10754 (total_free_floats, total_floats, total_free_intervals)
10755 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10756 Now EMACS_INT, not int. All uses changed.
10757 (Fgarbage_collect): Compute overall total using a double, so that
10758 integer overflow is less likely to be a problem. Check for overflow
10759 when converting back to an integer.
5a25e253
PE
10760 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10761 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10762 These were 'int' variables that could overflow on 64-bit hosts;
10763 they were never used, so remove them instead of repairing them.
211a0b2a 10764 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10765 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10766 Previously, this ceilinged at INT_MAX, but that doesn't work on
10767 64-bit machines.
e46bb31a 10768 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10769
c78baabf 10770 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10771 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10772 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10773 when a (possibly-narrower) signed value would do just as well.
10774 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10775
c9d624c6
PE
10776 * alloc.c: Catch some string size overflows that we were missing.
10777 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10778 for convenience in STRING_BYTES_MAX.
10779 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10780 The definition here is exact; the one in lisp.h was approximate.
10781 (allocate_string_data): Check for string overflow. This catches
10782 some instances we weren't catching before. Also, it catches
10783 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10784 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10785 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10786
c9d624c6
PE
10787 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10788 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10789 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10790
353032ce
PE
10791 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10792
2bccce07
PE
10793 * alloc.c (Fmake_string): Check for out-of-range init.
10794
0ac30604
SM
107952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10796
10797 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10798
c195f2de
JD
107992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10800
10801 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10802 xg_get_default_scrollbar_width.
10803
10804 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10805 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10806 (style_changed_cb): Call update_theme_scrollbar_width and call
10807 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10808 all frames (Bug#8505).
10809 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10810 Call gtk_window_set_resizable if HAVE_GTK3.
10811 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10812 and height if HAVE_GTK3 (Bug#8505).
10813 (scroll_bar_width_for_theme): New variable.
10814 (update_theme_scrollbar_width): New function.
10815 (xg_get_default_scrollbar_width): Move code to
10816 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10817 (xg_initialize): Call update_theme_scrollbar_width.
10818
10819 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10820
10821 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10822
e10ac9f1
MR
108232011-06-12 Martin Rudalics <rudalics@gmx.at>
10824
10825 * frame.c (make_frame): Call other_buffer_safely instead of
10826 other_buffer.
10827
10828 * window.c (temp_output_buffer_show): Call display_buffer with
10829 second argument Vtemp_buffer_show_specifiers and reset latter
10830 immediately after the call.
10831 (Vtemp_buffer_show_specifiers): New variable.
10832 (auto_window_vscroll_p, next_screen_context_lines)
10833 (Vscroll_preserve_screen_position): Remove leading asterisks from
10834 doc-strings.
10835
2d3c217e 108362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10837
7b7f97e8 10838 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10839 * buffer.c (Qclone_number): Remove for now, as it's unused.
10840 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10841 (record_buffer): Remove unused local.
10842 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10843 (set_frame_buffer_list): Remove; unused.
10844 * frame.h (other_visible_frames): Remove decl.
10845 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10846 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10847 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10848 if HAVE_GPM.
10849 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10850 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10851 Define only if HAVE_GPM.
10852 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10853 (update_hints_inhibit): Remove; never set. All uses removed.
10854 * widgetprv.h (emacsFrameClassRec): Remove decl.
10855 * window.c (delete_deletable_window): Now returns void, since it
10856 wasn't returning anything.
10857 (compare_window_configurations): Remove unused locals.
10858 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10859 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10860 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10861 the same widths as pointers. This follows up on the 2011-05-06 patch.
10862 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10863 * xterm.h: Likewise.
10864 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10865
1384b89e
JB
108662011-06-12 Juanma Barranquero <lekktu@gmail.com>
10867
10868 * makefile.w32-in: Update dependencies.
10869 (LISP_H): Add lib/intprops.h.
10870
1100a63c
CY
108712011-06-11 Chong Yidong <cyd@stupidchicken.com>
10872
10873 * image.c (gif_load): Add animation frame delay to the metadata.
10874 (syms_of_image): Use DEFSYM. New symbol `delay'.
10875
6198ccd0
MR
108762011-06-11 Martin Rudalics <rudalics@gmx.at>
10877
10878 * window.c (delete_deletable_window): Re-add.
10879 (Fset_window_configuration): Rewrite to handle dead buffers and
10880 consequently deletable windows.
10881 (window_tree, Fwindow_tree): Remove. Supply functionality in
10882 window.el.
10883 (compare_window_configurations): Simplify code.
10884
b6e3633c
AS
108852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10886
1ab0dee5
AS
10887 * image.c (imagemagick_load_image): Fix type mismatch.
10888 (Fimagemagick_types): Likewise.
10889
b6e3633c
AS
10890 * window.h (replace_buffer_in_windows): Declare.
10891
9397e56f
MR
108922011-06-11 Martin Rudalics <rudalics@gmx.at>
10893
10894 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10895 Qclone_number. Remove external declaration of Qdelete_window.
10896 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10897 code.
640c8776
SM
10898 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10899 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10900 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10901 buffer list implementation.
10902 (other_buffer_safely): New function.
10903 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10904 calls to replace_buffer_in_windows and
10905 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10906 if allowed.
10907 (record_buffer): Inhibit quitting and rewrite using quittable
10908 functions. Run Qbuffer_list_update_hook if allowed.
10909 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10910 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10911 Move switch-to-buffer to window.el.
9397e56f
MR
10912 (bury-buffer): Move to window.el.
10913 (Vbuffer_list_update_hook): New variable.
10914
10915 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10916 section.
10917
10918 * window.h (resize_frame_windows): Move up in code.
10919 (Fwindow_frame): Remove EXFUN.
10920 (replace_buffer_in_all_windows): Remove prototype.
10921 (replace_buffer_in_windows_safely): Add prototype.
10922
10923 * window.c: Declare Qdelete_window static again. Move down
10924 declaration of select_count.
10925 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10926 (Fother_window): Move to window.el.
10927 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10928 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10929 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10930 window.el.
10931 (replace_buffer_in_windows): Implement by calling
10932 Qreplace_buffer_in_windows.
10933 (replace_buffer_in_all_windows): Remove with some functionality
10934 moved into replace_buffer_in_windows_safely.
10935 (replace_buffer_in_windows_safely): New function.
10936 (select_window_norecord, select_frame_norecord): Move in front
10937 of run_window_configuration_change_hook. Remove now obsolete
10938 declarations.
640c8776
SM
10939 (Fset_window_buffer): Rewrite doc-string.
10940 Call Qrecord_window_buffer.
9397e56f
MR
10941 (keys_of_window): Move binding for other-window to window.el.
10942
b50691aa
CY
109432011-06-11 Chong Yidong <cyd@stupidchicken.com>
10944
10945 * dispextern.h (struct image): Replace data member, whose int_val
10946 and ptr_val fields were not used by anything, with a single
10947 lisp_val object.
10948
10949 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10950 (gif_clear_image, gif_load, imagemagick_load_image)
10951 (gs_clear_image, gs_load): Callers changed.
10952
3f754b86
PE
109532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10954
cca69397
PE
10955 * buffer.h: Include <time.h>, for time_t.
10956 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10957
109e28d0
PE
10958 Fix minor problems found by static checking.
10959
60737f02
PE
10960 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10961
4b66faf3
PE
10962 Make identifiers static if they are not used in other modules.
10963 * data.c (Qcompiled_function, Qframe, Qvector):
10964 * image.c (QimageMagick, Qsvg):
10965 * minibuf.c (Qmetadata):
10966 * window.c (resize_window_check, resize_root_window): Now static.
10967 * window.h (resize_window_check, resize_root_window): Remove decls.
10968
109e28d0
PE
10969 * window.c (window_deletion_count, delete_deletable_window):
10970 Remove; unused.
46a4ce9e
PE
10971 (window_body_lines): Now static.
10972 (Fdelete_other_windows_internal): Mark vars as initialized.
10973 Make sure 'resize_failed' is initialized.
10974 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10975 (resize_window_apply): Remove unused local.
10976 * window.h (delete_deletable_window): Remove decl.
10977
109e28d0 10978 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10979 (imagemagick_load_image): Fix pointer signedness problem by changing
10980 last arg from unsigned char * to char *. All uses changed.
10981 Also, fix a local for similar reasons.
10982 Remove unused locals. Remove locals to avoid shadowing.
10983 (fn_rsvg_handle_free): Remove; unused.
10984 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10985 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10986
3f754b86
PE
10987 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10988
2547adb1
CY
109892011-06-10 Chong Yidong <cyd@stupidchicken.com>
10990
10991 * image.c (gif_load): Fix omitted cast error introduced by
10992 2011-06-06 change.
10993
2c8e37d4
MR
109942011-06-10 Martin Rudalics <rudalics@gmx.at>
10995
10996 * window.h (resize_proportionally, orig_total_lines)
10997 (orig_top_line): Remove from window structure.
10998 (set_window_height, set_window_width, change_window_heights)
10999 (Fdelete_window): Remove prototypes.
11000 (resize_frame_windows): Remove duplicate declaration.
11001
440a42e3
EZ
110022011-06-10 Eli Zaretskii <eliz@gnu.org>
11003
11004 * window.h (resize_frame_windows, resize_window_check)
11005 (delete_deletable_window, resize_root_window)
11006 (resize_frame_windows): Declare prototypes.
11007
11008 * window.c (resize_window_apply): Make definition be "static" to
11009 match the prototype.
11010
562dd5e9
MR
110112011-06-10 Martin Rudalics <rudalics@gmx.at>
11012
11013 * window.c: Remove declarations of Qwindow_size_fixed,
11014 window_min_size_1, window_min_size_2, window_min_size,
11015 size_window, window_fixed_size_p, enlarge_window, delete_window.
11016 Remove static from declaration of Qdelete_window, it's
11017 temporarily needed by Fbury_buffer.
11018 (replace_window): Don't assign orig_top_line and
11019 orig_total_lines.
11020 (Fdelete_window, delete_window): Remove. Window deletion is
11021 handled by window.el.
640c8776
SM
11022 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11023 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11024 (Fdelete_other_windows): Remove. Deleting other windows is
11025 handled by window.el.
11026 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11027 handled in window.el.
11028 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11029 Window minimum sizes are handled in window.el.
11030 (shrink_windows, size_window, set_window_height)
11031 (set_window_width, change_window_heights, window_height)
11032 (window_width, CURBEG, CURSIZE, enlarge_window)
11033 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11034 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11035 handled in window.el.
11036 (make_dummy_parent): Rename to make_parent_window and give it a
11037 second argument horflag.
11038 (make_window): Don't set resize_proportionally any more.
11039 (Fsplit_window): Remove. Windows are split in window.el.
11040 (save_restore_action, save_restore_orig_size)
11041 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11042 Resize mini windows in window.el.
11043 (grow_mini_window, shrink_mini_window): Implement by calling
11044 Qresize_root_window_vertically, resize_window_check and
11045 resize_window_apply.
640c8776
SM
11046 (saved_window, Fset_window_configuration, save_window_save):
11047 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11048 resize_proportionally.
11049 (window_min_height, window_min_width): Move to window.el.
11050 (keys_of_window): Move bindings for delete-other-windows,
11051 split-window, delete-window and enlarge-window to window.el.
11052
11053 * buffer.c: Temporarily extern Qdelete_window.
11054 (Fbury_buffer): Temporarily call Qdelete_window instead of
11055 Fdelete_window (Fbury_buffer will move to window.el soon).
11056
11057 * frame.c (set_menu_bar_lines_1): Remove code handling
11058 orig_top_line and orig_total_lines.
11059
11060 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11061 set_window_height but set heights directly.
11062 (change_frame_size_1): Use resize_frame_windows.
11063
11064 * xdisp.c (init_xdisp): Don't use set_window_height but set
11065 heights directly.
11066
640c8776
SM
11067 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11068 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11069 run_window_configuration_change_hook.
11070
11071 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11072 instead of change_window_heights and run
11073 run_window_configuration_change_hook.
11074
1a13852e
MR
110752011-06-09 Martin Rudalics <rudalics@gmx.at>
11076
11077 * window.c (replace_window): Rename second argument REPLACEMENT to
11078 NEW. New third argument SETFLAG. Rewrite.
11079 (delete_window, make_dummy_parent): Call replace_window with
11080 third argument 1.
11081 (window_list_1): Move down in code.
11082 (run_window_configuration_change_hook): Move set_buffer part
11083 before select_frame_norecord part in order to unwind correctly.
11084 Rename count1 to count.
11085 (recombine_windows, delete_deletable_window, resize_root_window)
11086 (Fdelete_other_windows_internal)
11087 (Frun_window_configuration_change_hook, make_parent_window)
11088 (resize_window_check, resize_window_apply, Fresize_window_apply)
11089 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11090 (Fdelete_window_internal, Fresize_mini_window_internal):
11091 New functions.
1a13852e
MR
11092 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11093
f3d1777e
MR
110942011-06-08 Martin Rudalics <rudalics@gmx.at>
11095
496e208e
MR
11096 * window.h (window): Add some new members to window structure -
11097 normal_lines, normal_cols, new_total, new_normal, clone_number,
11098 splits, nest, prev_buffers, next_buffers.
11099 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11100 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11101
f3d1777e
MR
11102 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11103 Remove.
496e208e
MR
11104 (make_dummy_parent): Set new members of windows structure.
11105 (make_window): Move down in code. Handle new members of window
11106 structure.
11107 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11108 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11109 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11110 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11111 (Fset_window_next_buffers, Fset_window_clone_number):
11112 New functions.
496e208e
MR
11113 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11114 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11115 Doc-string fixes.
11116 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11117 Argument WINDOW can be now internal window too.
11118 (Fwindow_use_time): Move up in code.
11119 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11120 Rewrite doc-string.
11121 (Fset_window_configuration, saved_window)
11122 (Fcurrent_window_configuration, save_window_save): Handle new
11123 members of window structure.
b9e809c2
MR
11124 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11125 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11126 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11127 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11128 Qget_mru_window, Qresize_root_window,
11129 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11130 Qauto_buffer_name; staticpro them.
f3d1777e 11131
abde8f8c
MR
111322011-06-07 Martin Rudalics <rudalics@gmx.at>
11133
11134 * window.c (Fwindow_total_size, Fwindow_left_column)
11135 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11136 (Fwindow_list_1): New functions.
11137 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11138 (Fwindow_width, Fscroll_left, Fscroll_right):
11139 Use window_body_cols instead of window_box_text_cols.
11140 (delete_window, Fset_window_configuration):
11141 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11142 (delete_all_subwindows): Take a window as argument and not a
11143 structure. Rewrite.
190b47e6
MR
11144 (window_loop): Remove handling of GET_LRU_WINDOW and
11145 GET_LARGEST_WINDOW.
11146 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11147
11148 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11149 window_box_text_cols. delete_all_subwindows now takes a
11150 Lisp_Object as argument.
abde8f8c 11151
640c8776
SM
11152 * indent.c (compute_motion, Fcompute_motion):
11153 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11154
fa8a67e6
MR
11155 * frame.c (delete_frame): Call delete_all_subwindows with root
11156 window as argument.
11157
a54e3482
DC
111582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11159
11160 * fns.c (Fputhash): Document return value.
11161
60002bf5
CY
111622011-06-06 Chong Yidong <cyd@stupidchicken.com>
11163
11164 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11165
0c671da6 111662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11167
b862a52a 11168 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11169
be44ca6c
PE
11170 Check for overflow when converting integer to cons and back.
11171 * charset.c (Fdefine_charset_internal, Fdecode_char):
11172 Use cons_to_unsigned to catch overflow.
11173 (Fencode_char): Use INTEGER_TO_CONS.
11174 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11175 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11176 * data.c (long_to_cons, cons_to_long): Remove.
11177 (cons_to_unsigned, cons_to_signed): New functions.
11178 These signal an error for invalid or out-of-range values.
11179 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11180 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11181 * font.c (Ffont_variation_glyphs):
11182 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11183 * lisp.h: Include <intprops.h>.
11184 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11185 (cons_to_signed, cons_to_unsigned): New decls.
11186 (long_to_cons, cons_to_long): Remove decls.
11187 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11188 (Fprimitive_undo): Use CONS_TO_INTEGER.
11189 * xfns.c (Fx_window_property): Likewise.
11190 * xselect.c: Include <limits.h>.
11191 (x_own_selection, selection_data_to_lisp_data):
11192 Use INTEGER_TO_CONS.
11193 (x_handle_selection_request, x_handle_selection_clear)
11194 (x_get_foreign_selection, Fx_disown_selection_internal)
11195 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11196 (lisp_data_to_selection_data): Use cons_to_unsigned.
11197 (x_fill_property_data): Use cons_to_signed.
11198 Report values out of range.
11199
d1f3d2af
PE
11200 Check for buffer and string overflow more precisely.
11201 * buffer.h (BUF_BYTES_MAX): New macro.
11202 * lisp.h (STRING_BYTES_MAX): New macro.
11203 * alloc.c (Fmake_string):
11204 * character.c (string_escape_byte8):
11205 * coding.c (coding_alloc_by_realloc):
11206 * doprnt.c (doprnt):
11207 * editfns.c (Fformat):
11208 * eval.c (verror):
11209 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11210 since they may not be the same number.
11211 * editfns.c (Finsert_char):
11212 * fileio.c (Finsert_file_contents):
11213 Likewise for BUF_BYTES_MAX.
11214
dd52fcea
PE
11215 * image.c: Use ptrdiff_t, not int, for sizes.
11216 (slurp_file): Switch from int to ptrdiff_t.
11217 All uses changed.
11218 (slurp_file): Check that file size fits in both size_t (for
11219 malloc) and ptrdiff_t (for sanity and safety).
11220
7f9bbdbb
PE
11221 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11222 if b->modtime has its maximal value.
11223
dfe18f82
PE
11224 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11225
84acfcf0
PE
11226 Don't assume time_t can fit into int.
11227 * buffer.h (struct buffer.modtime): Now time_t, not int.
11228 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11229 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11230
ccd9a01a
PE
11231 Minor fixes for signed vs unsigned integers.
11232 * character.h (MAYBE_UNIFY_CHAR):
11233 * charset.c (maybe_unify_char):
11234 * keyboard.c (read_char, reorder_modifiers):
11235 XINT -> XFASTINT, since the integer must be nonnegative.
11236 * ftfont.c (ftfont_spec_pattern):
11237 * keymap.c (access_keymap, silly_event_symbol_error):
11238 XUINT -> XFASTINT, since the integer must be nonnegative.
11239 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11240 since it makes no difference and we prefer signed.
11241 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11242 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11243 nonnegative.
11244
d6d100dd
SM
112452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11246
11247 * window.h (Fwindow_frame): Declare.
11248
2b6148e4
PE
112492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11250
11251 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11252 (SPARE_MEMORY): Always define.
11253 (LARGE_REQUEST): Remove.
11254 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11255
f230ecc9
MR
112562011-06-06 Martin Rudalics <rudalics@gmx.at>
11257
727e958e
MR
11258 * lisp.h: Move EXFUNS for Fframe_root_window,
11259 Fframe_first_window and Fset_frame_selected_window to window.h.
11260
11261 * window.h: Move EXFUNS for Fframe_root_window,
11262 Fframe_first_window and Fset_frame_selected_window here from
11263 lisp.h.
11264
11265 * frame.c (Fwindow_frame, Fframe_first_window)
11266 (Fframe_root_window, Fframe_selected_window)
11267 (Fset_frame_selected_window): Move to window.c.
11268 (Factive_minibuffer_window): Move to minibuf.c.
11269 (Fother_visible_frames_p): New function.
11270
11271 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11272
f230ecc9
MR
11273 * window.c (decode_window, decode_any_window): Move up in code.
11274 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11275 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11276 (Fwindow_buffer): Move up and rewrite doc-string.
11277 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11278 (Fwindow_prev): New functions.
727e958e
MR
11279 (Fwindow_frame): Move here from frame.c. Accept any window as
11280 argument.
11281 (Fframe_root_window, Fframe_first_window)
11282 (Fframe_selected_window): Move here from frame.c. Accept frame
11283 or arbitrary window as argument. Update doc-strings.
11284 (Fminibuffer_window): Move up in code.
11285 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11286 (Fset_frame_selected_window): Move here from frame.c.
11287 Marginal rewrite.
727e958e
MR
11288 (Fselected_window, select_window, Fselect_window): Move up in
11289 code. Minor doc-string fixes.
f230ecc9 11290
4d09bcf6
PE
112912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11292
11293 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11294 Do not assume that spare memory exists; that assumption is valid
11295 only if SYSTEM_MALLOC.
11296 (LARGE_REQUEST): New macro, so that the issue of large requests
11297 is separated from the issue of spare memory.
11298
810928a2
AS
112992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11300
172418ad
AS
11301 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11302 format. (Bug#8806)
11303
43f862f7
AS
11304 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11305
810928a2
AS
11306 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11307 before statements.
11308
a059fe24
JD
113092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11310
11311 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11312
11313 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11314
11315 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11316 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11317
989bf368
JB
113182011-06-05 Juanma Barranquero <lekktu@gmail.com>
11319
11320 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11321
4b80f674
CY
113222011-06-04 Chong Yidong <cyd@stupidchicken.com>
11323
11324 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11325 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11326 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11327 New error handlers.
4b80f674
CY
11328 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11329 Obey Vx_select_enable_clipboard_manager. Catch errors in
11330 x_clipboard_manager_save (Bug#8779).
11331 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11332 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11333
99a33b77 113342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11335
11336 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11337
99a33b77 113382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11339
11340 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11341 in the current matrix if keep_current_p is non-zero.
11342
8264569d
EZ
113432011-06-04 Eli Zaretskii <eliz@gnu.org>
11344
11345 * bidi.c (bidi_level_of_next_char): Fix last change.
11346
57f97249
EZ
113472011-06-03 Eli Zaretskii <eliz@gnu.org>
11348
fec2107c 11349 Support bidi reordering of text covered by display properties.
57f97249 11350
fec2107c
EZ
11351 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11352 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11353 (bidi_cache_search, bidi_cache_iterator_state)
11354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11355 (bidi_level_of_next_char, bidi_move_to_visually_next):
11356 Support character positions inside a run of characters covered by a
fec2107c
EZ
11357 display string.
11358 (bidi_paragraph_init, bidi_resolve_explicit_1)
11359 (bidi_level_of_next_char): Call bidi_fetch_char and
11360 bidi_fetch_char_advance instead of FETCH_CHAR and
11361 FETCH_CHAR_ADVANCE.
11362 (bidi_init_it): Initialize new members.
11363 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11364 definitions.
11365 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11366 instead of using explicit *_CHAR codes.
d6d100dd
SM
11367 (bidi_resolve_explicit, bidi_resolve_weak):
11368 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11369 bidirectional text is supported only in multibyte buffers.
11370 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11371 it to initialize the frame_window_p member of struct bidi_it.
11372 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11373 (bidi_resolve_explicit, bidi_resolve_weak)
11374 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11375 bidi_it->nchars is non-positive.
11376 (bidi_level_of_next_char): Don't try to lookup the cache for the
11377 next/previous character if nothing is cached there yet, or if we
11378 were just reseat()'ed to a new position.
c40e2fb2 11379
0e14fe90
EZ
11380 * xdisp.c (set_cursor_from_row): Set start and stop points
11381 according to the row's direction when priming the loop that looks
11382 for the glyph on which to display cursor.
11383 (single_display_spec_intangible_p): Function deleted.
11384 (display_prop_intangible_p): Reimplement to call
11385 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11386 Accept 3 additional arguments needed by handle_display_spec.
11387 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11388 values: lists, `(when COND...)' forms, etc.
11389 (single_display_spec_string_p): Support property values that are
11390 lists with the argument STRING its top-level element.
11391 (display_prop_string_p): Fix the condition for processing a
11392 property that is a list to be consistent with handle_display_spec.
fec2107c 11393 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11394 last portion of handle_display_prop.
11395 (compute_display_string_pos): Accept additional argument
11396 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11397 value of a `display' property is a "replacing spec".
11398 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11399 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11400 the display property, but just return a value indicating whether
11401 the display property will replace the characters it covers.
11402 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11403 frame_window_p members of struct bidi_it.
d6d100dd
SM
11404 (compute_display_string_pos, compute_display_string_end):
11405 New functions.
fec2107c
EZ
11406 (push_it): Accept second argument POSITION, where pop_it should
11407 jump to continue iteration.
11408 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11409
fec2107c
EZ
11410 * keyboard.c (adjust_point_for_property): Adjust the call to
11411 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11412
11413 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11414 (bidi_init_it): Update prototypes.
11415 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11416 (compute_display_string_pos, compute_display_string_end):
11417 Declare prototypes.
fec2107c
EZ
11418 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11419 EMACS_INT.
fc6f18ce 11420
40087514 114212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11422
57f53182
PE
11423 Malloc failure behavior now depends on size of allocation.
11424 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11425 * lisp.h: Change signatures accordingly.
11426 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11427 All callers changed. (Bug#8762)
11428
11429 * gnutls.c: Use Emacs's memory allocators.
11430 Without this change, the gnutls library would invoke malloc etc.
11431 directly, which causes problems on non-SYNC_INPUT hosts, and which
11432 runs afoul of improving memory_full behavior. (Bug#8761)
11433 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11434 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11435 xfree instead of the default malloc, realloc, free.
11436 (Fgnutls_boot): No need to check for memory allocation failure,
11437 since xmalloc does that for us.
11438
ac32cd99 11439 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11440 * category.c (hash_get_category_set):
11441 * ccl.c (ccl_driver):
11442 * charset.c (Fdefine_charset_internal):
11443 * charset.h (struct charset.hash_index):
11444 * composite.c (get_composition_id, gstring_lookup_cache)
11445 (composition_gstring_put_cache):
11446 * composite.h (struct composition.hash_index):
11447 * dispextern.h (struct image.hash):
11448 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11449 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11450 (hashfn_equal, hashfn_user_defined, make_hash_table)
11451 (maybe_resize_hash_table, hash_lookup, hash_put)
11452 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11453 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11454 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11455 * image.c (make_image, search_image_cache, lookup_image)
11456 (xpm_put_color_table_h):
11457 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11458 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11459 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11460 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11461 * alloc.c (allocate_vectorlike):
11462 Check for overflow in vector size calculations.
11463 * ccl.c (ccl_driver):
11464 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11465 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11466 need to be updated by these changes.
40087514
PE
11467 * fns.c (make_hash_table, maybe_resize_hash_table):
11468 Check for integer overflow with large hash tables.
0de4bb68
PE
11469 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11470 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11471 (SXHASH_REDUCE): New macro.
11472 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11473 Use it instead of discarding useful hash info with large hash values.
11474 (sxhash_float): New function.
11475 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11476 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11477 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11478 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11479 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11480 Adjust signatures to match updated version of code.
11481 (consing_since_gc): Now EMACS_INT, since a single hash table can
11482 use more than INT_MAX bytes.
11483
698d32e2
DN
114842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11485
11486 Make it possible to build with GCC-4.6+ -O2 -flto.
11487
11488 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11489
fd6fa53f
SM
114902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11491
11492 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11493 Call minibuffer-inactive-mode.
11494
864db017
JB
114952011-05-31 Juanma Barranquero <lekktu@gmail.com>
11496
11497 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11498 Update dependencies.
11499
2ad0baf4
DN
115002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11501
11502 * data.c (init_data): Remove code for UTS, this system is not
11503 supported anymore.
11504
4fcc2638
DN
115052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11506
11507 Don't force ./temacs to start in terminal mode.
11508
11509 * frame.c (make_initial_frame): Initialize faces in all cases, not
11510 only when CANNOT_DUMP is defined.
11511 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11512
c56e0fd5
DN
115132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11514
11515 * dispnew.c (add_window_display_history): Use const for the string
11516 pointer. Remove declaration, not needed.
11517
333d54da 115182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11519
55d4c1b2 11520 Use 'inline', not 'INLINE'.
333d54da 11521 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11522 * alloc.c, fontset.c (INLINE): Remove.
11523 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11524 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11525 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11526 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11527 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11528
738db178
DN
115292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11530
11531 Make it possible to run ./temacs.
11532
11533 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11534 syms_of_callproc does the same thing. Remove test for
11535 "initialized", do it in the caller.
11536 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11537
620c53a6
SM
115382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11539
11540 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11541 (read_minibuf): Use get_minibuffer.
11542 (syms_of_minibuf): Use DEFSYM.
11543 (Qmetadata): New var.
11544 * data.c (Qbuffer): Don't make it static.
11545 (syms_of_data): Use DEFSYM.
11546
e003a292
PE
115472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11548
11549 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11550 (CCL_CODE_MIN): New macro.
11551
ed008a6d
PE
115522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11553
3687c2ef
PE
11554 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11555
ed008a6d
PE
11556 * eval.c (Qdebug): Now static.
11557 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11558 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11559 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11560
d66c4c7c
CY
115612011-05-29 Chong Yidong <cyd@stupidchicken.com>
11562
11563 * image.c: Various fixes to ImageMagick code comments.
11564 (Fimagemagick_types): Doc fix.
11565
5fbc2025
PE
115662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11567
0196f88a
PE
11568 Minor fixes prompted by GCC 4.6.0 warnings.
11569
11570 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11571
5fbc2025
PE
11572 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11573 (x_clipboard_manager_save_all): Move extern decl to ...
11574 * xterm.h: ... here, so that it can be checked for consistency.
11575
1dd3c2d9
CY
115762011-05-29 Chong Yidong <cyd@stupidchicken.com>
11577
11578 * xselect.c (x_clipboard_manager_save_frame)
11579 (x_clipboard_manager_save_all): New functions.
11580 (Fx_clipboard_manager_save): Lisp function deleted.
11581
11582 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11583 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11584
11585 * xterm.h: Update prototype.
11586
5ba6571d
WX
115872011-05-28 William Xu <william.xwl@gmail.com>
11588
11589 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11590 exiting (Bug#8239).
11591
3eaff834
JM
115922011-05-28 Jim Meyering <meyering@redhat.com>
11593
e1900994 11594 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11595 * fns.c (to_uchar): Define.
11596 (crypto_hash_function): Use it to convert some newly-signed
11597 variables to unsigned, to avoid sign-extension bugs. For example,
11598 without this change, (md5 "truc") would evaluate to
11599 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11600 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11601 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11602
0f6990a7
PE
116032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11604
11605 Integer overflow fixes.
c8a9ca5a 11606
08686060
PE
11607 * dbusbind.c: Serial number integer overflow fixes.
11608 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11609 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11610 to hold a serial number that is too large for a fixnum.
11611 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11612 Check for serial numbers out of range. Decode any serial number
59568bf0 11613 that was so large that it became a float. (Bug#8722)
08686060 11614
2d1fc3c7
PE
11615 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11616 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11617 Use XFASTINT rather than XUINT when numbers are nonnegative.
11618 (xd_append_arg, Fdbus_method_return_internal):
11619 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11620 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11621 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11622 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11623 (Bug#8722)
2d1fc3c7 11624
c8a9ca5a
PE
11625 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11626
519e1d69
PE
11627 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11628
6df6ae42 11629 ccl: Add integer overflow checks.
30569699
PE
11630 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11631 (IN_INT_RANGE): New macros.
11632 (ccl_driver): Use them to check for integer overflow when
11633 decoding a CCL program. Many of the new checks are whether XINT (x)
11634 fits in int; it doesn't always, on 64-bit hosts. The new version
11635 doesn't catch all possible integer overflows, but it's an
847044ea 11636 improvement. (Bug#8719)
30569699 11637
c11285dc
PE
11638 * alloc.c (make_event_array): Use XINT, not XUINT.
11639 There's no need for unsigned here.
11640
fdccd48e
PE
11641 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11642 This follows up to the 2011-05-06 change that substituted uintptr_t
11643 for EMACS_INT. This case wasn't caught back then.
11644
37910ab2
PE
11645 Rework Fformat to avoid integer overflow issues.
11646 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11647 now (part of C89). Include <verify.h>.
11648 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11649 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11650 (Fformat): Avoid the prepass trying to compute sizes; it was only
11651 approximate and thus did not catch overflow reliably. Instead, walk
11652 through the format just once, formatting and computing sizes as we go,
11653 checking for integer overflow at every step, and allocating a larger
11654 buffer as needed. Keep track separately whether the format is
11655 multibyte. Keep only the most-recently calculated precision, rather
11656 than them all. Record whether each argument has been converted to
11657 string. Use EMACS_INT, not int, for byte and char and arg counts.
11658 Support field widths and precisions larger than INT_MAX. Avoid
11659 sprintf's undefined behavior with conversion specifications such as %#d
11660 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11661 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11662 formatting out-of-range floating point numbers with int
9173deec 11663 formats. (Bug#8668)
37910ab2 11664
2e6578fb
PE
11665 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11666
0ae6bdee
PE
11667 * data.c: Avoid integer truncation in expressions involving floats.
11668 * data.c: Include <intprops.h>.
11669 (arith_driver): When there's an integer overflow in an expression
11670 involving floating point, convert the integers to floating point
11671 so that the resulting value does not suffer from catastrophic
11672 integer truncation. For example, on a 64-bit host (* 4
11673 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11674 Do not rely on undefined behavior after integer overflow.
11675
de883a70
PE
11676 merge count_size_as_multibyte, parse_str_to_multibyte
11677 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11678 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11679 Check for integer overflow.
11680 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11681 since it's now a duplicate of the other. This is more of
11682 a character than a buffer op, so better that it's in character.c.
11683 * fns.c, print.c: Adjust to above changes.
11684
2ff916cb
PE
116852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11686
11687 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11688
f1b54466
PE
116892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11690
fb1ac845
PE
11691 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11692 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11693 (x_clipboard_manager_save): Now static.
11694 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11695
f1b54466
PE
11696 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11697 (crypto_hash_function): Now static.
11698 Fix pointer signedness problems. Avoid unnecessary initializations.
11699
a9f737ee
CY
117002011-05-27 Chong Yidong <cyd@stupidchicken.com>
11701
11702 * termhooks.h (Vselection_alist): Make it terminal-local.
11703
11704 * terminal.c (create_terminal): Initialize it.
11705
11706 * xselect.c: Support for clipboard managers.
11707 (Vselection_alist): Move to termhooks.h as terminal-local var.
11708 (LOCAL_SELECTION): New macro.
11709 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11710 (symbol_to_x_atom): Remove gratuitous arg.
11711 (x_handle_selection_request, lisp_data_to_selection_data)
11712 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11713 (x_own_selection, x_get_local_selection, x_convert_selection):
11714 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11715 (some_frame_on_display): Delete unused function.
11716 (Fx_own_selection_internal, Fx_get_selection_internal)
11717 (Fx_disown_selection_internal, Fx_selection_owner_p)
11718 (Fx_selection_exists_p): New optional frame arg.
11719 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11720 (x_handle_selection_clear): Don't treat other terminals with the
11721 same keyboard specially. Use the terminal-local Vselection_alist.
11722 (x_clear_frame_selections): Use Frun_hook_with_args.
11723
11724 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11725
11726 * xterm.h: Add support for those atoms.
11727
e067f0c1
CY
117282011-05-26 Chong Yidong <cyd@stupidchicken.com>
11729
11730 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11731 (converted_selections, conversion_fail_tag): New global variables.
11732 (x_selection_request_lisp_error): Free the above.
11733 (x_get_local_selection): Remove unnecessary code.
11734 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11735 of converted selections stored in converted_selections.
11736 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11737 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11738 (x_convert_selection): New function.
11739 (x_handle_selection_event): Simplify.
11740 (x_get_foreign_selection): Don't ignore incoming requests while
11741 waiting for an answer; this will fail when we implement
11742 SAVE_TARGETS, and seems unnecessary anyway.
11743 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11744 (Vx_sent_selection_functions): Doc fix.
11745
0f4aebc0
LL
117462011-05-26 Leo Liu <sdl.web@gmail.com>
11747
11748 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11749
e61124cd
YM
117502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11751
11752 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11753
11754 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11755 for fringe update if it has periodic bitmap.
ac389d0c 11756 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11757 and fringe_bitmap_periodic_p.
11758
11759 * fringe.c (get_fringe_bitmap_data): New function.
11760 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11761 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11762 row. Mark glyph row for fringe update if periodicity changed.
11763
11764 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11765 for fringe update unless it has periodic bitmap.
11766
f16d9837
KH
117672011-05-25 Kenichi Handa <handa@m17n.org>
11768
11769 * xdisp.c (get_next_display_element): Set correct it->face_id for
11770 a static composition.
11771
e1b90ef6
LL
117722011-05-24 Leo Liu <sdl.web@gmail.com>
11773
11774 * deps.mk (fns.o):
11775 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11776
11777 * fns.c (crypto_hash_function, Fsha1): New function.
11778 (Fmd5): Use crypto_hash_function.
11779 (syms_of_fns): Add Ssha1.
11780
7400048f
PE
117812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11782
11783 * gnutls.c: Remove unused macros.
11784 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11785 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11786 Remove macros that are defined and never used.
11787 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11788
abb71cf4
CY
117892011-05-22 Chong Yidong <cyd@stupidchicken.com>
11790
11791 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11792 (Fx_get_selection_internal): Minor cleanup.
11793 (Fx_own_selection_internal): Rename arguments for consistency with
11794 select.el.
11795
6307db39
PE
117962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11797
11798 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11799
f3d4e0a4
CY
118002011-05-22 Chong Yidong <cyd@stupidchicken.com>
11801
11802 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11803
4d8ade89
YM
118042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11805
11806 * dispnew.c (scrolling_window): Don't exclude the case that the
11807 last enabled row in the desired matrix touches the bottom boundary.
11808
32078c8d
GM
118092011-05-21 Glenn Morris <rgm@gnu.org>
11810
11811 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11812 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11813 and add some more files.
32078c8d 11814
7285dc67
EZ
118152011-05-20 Eli Zaretskii <eliz@gnu.org>
11816
11817 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11818 report_file_error introduced by the change from 2011-05-07.
11819
89d1bd22
PE
118202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11821
11822 * systime.h (Time): Define only if emacs is defined.
11823 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11824 where the include path doesn't have X11/X.h by default. See
11825 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11826
cd394be1 118272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11828
11829 * composite.c (find_automatic_composition): Fix previous change.
11830
b9704ad9
GM
118312011-05-20 Glenn Morris <rgm@gnu.org>
11832
11833 * lisp.mk: New file, split from Makefile.in.
11834 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11835 (shortlisp): Remove.
11836 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11837
4a720484
GM
118382011-05-19 Glenn Morris <rgm@gnu.org>
11839
11840 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11841 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11842 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11843 (lisp): Set the order to that of loadup.el.
11844 (shortlisp): Make it a copy of $lisp.
11845 (SOME_MACHINE_LISP): Remove.
11846 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11847 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11848
a28d4396
KH
118492011-05-18 Kenichi Handa <handa@m17n.org>
11850
11851 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11852 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11853 (find_automatic_composition): Mostly rewrite for efficiency.
11854
a2b1fa8e
JB
118552011-05-18 Juanma Barranquero <lekktu@gmail.com>
11856
11857 * makefile.w32-in: Update dependencies.
11858
8e1f5610
CS
118592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11860
11861 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11862 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11863
7025ee00 118642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11865
cdfa6eab
PE
11866 Fix some integer overflow issues, such as string length overflow.
11867
06d6db33
PE
11868 * insdel.c (count_size_as_multibyte): Check for string overflow.
11869
2b4560a8
PE
11870 * character.c (lisp_string_width): Check for string overflow.
11871 Use EMACS_INT, not int, for string indexes and lengths; in
11872 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11873 the resulting string length overflows an EMACS_INT; instead,
11874 report a string overflow if no precision given. When checking for
11875 precision exhaustion, use a check that cannot possibly have
11876 integer overflow. (Bug#8675)
11877 * character.h (lisp_string_width): Adjust to new signature.
11878
cb93f9be
PE
11879 * alloc.c (string_overflow): New function.
11880 (Fmake_string): Use it. This doesn't change behavior, but saves
11881 a few bytes and will simplify future changes.
11882 * character.c (string_escape_byte8): Likewise.
11883 * lisp.h (string_overflow): New decl.
11884
1a1f3366
PE
11885 Fixups, following up to the user-interface timestamp change.
11886 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11887 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11888 * msdos.c (mouse_get_pos): Likewise.
11889 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11890 * w32gui.h (Time): Define by including "systime.h" rather than by
11891 declaring it ourselves. (Bug#8664)
11892
d4e3e4d3
PE
11893 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11894 * image.c (clear_image_cache): Likewise.
11895
f6a24d19
PE
11896 * term.c (term_mouse_position): Don't assume time_t wraparound.
11897
08dc5ae6
PE
11898 Be more systematic about user-interface timestamps.
11899 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11900 and sometimes 'EMACS_UINT', to represent these timestamps.
11901 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11902 This makes the code easier to follow, and makes it easier to catch
11903 integer overflow bugs such as Bug#8664.
11904 * frame.c (Fmouse_position, Fmouse_pixel_position):
11905 Use Time, not unsigned long, for user-interface timestamps.
11906 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11907 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11908 * keyboard.h (last_event_timestamp): Likewise.
11909 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11910 * menu.h (xmenu_show): Likewise.
11911 * term.c (term_mouse_position): Likewise.
11912 * termhooks.h (struct input_event.timestamp): Likewise.
11913 (struct terminal.mouse_position_hook): Likewise.
11914 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11915 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11916 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11917 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11918 what it was before.
11919 * menu.h, termhooks.h: Include "systime.h", for Time.
11920
8e55734a
PE
11921 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11922 Don't assume that the difference between two unsigned long values
11923 can fit into an integer. At this point, we know button_down_time
11924 <= event->timestamp, so the difference must be nonnegative, so
11925 there's no need to cast the result if double-click-time is
11926 nonnegative, as it should be; check that it's nonnegative, just in
11927 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11928 apart (about 25 days). (Bug#8664)
8e55734a 11929
841f1b75 11930 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11931 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11932
3e26f69c
PE
11933 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11934 that always fit in int. Use a sentinel instead of a counter, to
11935 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11936 * frame.h (struct frame): Use int for menu_bar_items_used
11937 instead of EMACS_INT, since it always fits in int.
3e26f69c 11938
5cc152c0
PE
11939 * menu.c (grow_menu_items): Check for int overflow.
11940
d89eb65e
PE
11941 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11942
5235bd3e
PE
11943 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11944 Before, the code was not consistent. These values cannot exceed
11945 2**31 - 1 so there's no need to make them unsigned.
11946 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11947 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11948 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11949 as modifiers.
11950 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11951
bc827e23
PE
11952 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11953 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11954 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11955 presumably because the widths might not match.
11956
78eb494e
PE
11957 * window.c (size_window): Avoid needless test at loop start.
11958
04f2d78b
CB
119592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11960
11961 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11962
d2fc7e3d 119632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11964
11965 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11966
d2fc7e3d 119672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11968
11969 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11970 `width' to `bar_area_x' and `bar_area_width', respectively.
11971 (x_scroll_run): Take account of fringe background extension.
11972
04f2d78b
CB
11973 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11974 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11975 `bar_area_width', respectively.
11976 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11977 background extension.
11978
79b70037
GM
119792011-05-10 Jim Meyering <meyering@redhat.com>
11980
11981 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11982
2f142cc5
JB
119832011-05-10 Juanma Barranquero <lekktu@gmail.com>
11984
11985 * image.c (Finit_image_library): Return t for built-in image types,
11986 like pbm and xbm. (Bug#8640)
11987
57679c86
AS
119882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11989
11990 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11991
888c9e86
EZ
119922011-05-07 Eli Zaretskii <eliz@gnu.org>
11993
b0512a1d
EZ
11994 * w32console.c (Fset_screen_color): Doc fix.
11995 (Fget_screen_color): New function.
11996 (syms_of_ntterm): Defsubr it.
11997
7285dc67
EZ
11998 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11999 unlink the temporary file if Fcall_process didn't create it in the
12000 first place.
12001 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12002 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12003 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12004 cue to call_process_cleanup not to close that handle.
12005
4d3fcc8e
BK
120062011-05-07 Ben Key <bkey76@gmail.com>
12007
12008 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12009 one of two shell specific rules, either bootstrap-temacs-CMD or
12010 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12011 to the previous implementation of the bootstrap-temacs rule.
12012 The bootstrap-temacs-CMD rule is similar to the previous
12013 implementation of the bootstrap-temacs rule except that it
12014 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12015 variable.
12016
12017 These changes, along with some changes to nt/configure.bat,
12018 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12019 earlier fix to add support for --cflags and --ldflags options
12020 that include quotes so that it works whether make uses cmd or
12021 sh as the shell.
12022
b4289b64
MA
120232011-05-06 Michael Albinus <michael.albinus@gmx.de>
12024
12025 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12026 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12027 is a constant.
12028 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12029 a string. Handle both cases.
12030 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12031 (Fdbus_register_method): Use Qinvalid_function.
12032
af4c0e28
JB
120332011-05-06 Juanma Barranquero <lekktu@gmail.com>
12034
12035 * makefile.w32-in: Update dependencies.
12036 (LISP_H): Add inttypes.h and stdin.h.
12037 (PROCESS_H): Add unistd.h.
12038
c51453d9
EZ
120392011-05-06 Eli Zaretskii <eliz@gnu.org>
12040
12041 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12042 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12043
8ff0ac3c 120442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12045
4c4b566b
PE
12046 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12047
aab2b9b5
PE
12048 * term.c (vfatal): Remove stray call to va_end.
12049 It's not needed and the C Standard doesn't allow it here anyway.
12050
c378da0b
PE
12051 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12052 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12053
288b08c7
PE
12054 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12055 bytes.
12056
e3601888
PE
12057 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12058
db6c0e74
PE
12059 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12060
dd5963ea
PE
12061 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12062
88c9450f
PE
12063 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12064
2f9442b8
PE
12065 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12066
c032b5f8
PE
12067 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12068 * charset.c (Fdefine_charset_internal): Don't initialize
12069 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12070 32-bit int (Bug#8600).
a108c10b
PE
12071
12072 * lread.c (read_integer): Be more consistent with string-to-number.
12073 Use string_to_number to do the actual conversion; this avoids
12074 rounding errors and fixes some other screwups. Without this fix,
12075 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12076 (digit_to_number): Move earlier, for benefit of read_integer.
12077 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12078 not a digit in any supported base. (Bug#8602)
a108c10b 12079
ad5f9eea
PE
12080 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12081
aec1708a
PE
12082 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12083 to match comment at start of function. This also removes a
12084 GCC warning about overflow in a 32+64-bit port.
12085
47be4ab5
PE
12086 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12087
371cac43
PE
12088 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12089 Reported by Stefan Monnier in
12090 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12091 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12092 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12093
d01a7826
PE
12094 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12095 (EMACS_UINTPTR): Likewise, with uintptr_t.
12096
7fd47d5c
PE
12097 * lisp.h: Prefer 64-bit EMACS_INT if available.
12098 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12099 on 32-bit hosts that have 64-bit int, so that they can access
12100 large files.
122b0c86
PE
12101 However, temporarily disable this change unless the temporary
12102 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12103
8727937b
PE
12104 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12105
8ac068ac
PE
12106 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12107 This removes an assumption that EMACS_INT and long are the same
12108 width as pointers. The assumption is true for Emacs porting targets
12109 now, but we want to make other targets possible.
12110 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12111 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12112 In the rest of the code, change types of integers that hold casted
12113 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12114 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12115 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12116 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12117 No need to cast type when ORing.
12118 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12119 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12120 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12121 assume EMACS_INT is the same width as char *.
12122 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12123 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12124 Remove no-longer-needed casts.
12125 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12126 (xg_tool_bar_help_callback, xg_make_tool_item):
12127 Use EMACS_INTPTR to hold an integer
12128 that will be cast to void *; this can avoid a GCC warning
12129 if EMACS_INT is not the same width as void *.
12130 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12131 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12132 (current_message_1, set_message_1):
12133 Use a local to convert to proper width without a cast.
12134 * xmenu.c (dialog_selection_callback): Likewise.
12135
ede49d71
PE
12136 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12137 Also, don't assume VALBITS / RAND_BITS is less than 5,
12138 and don't rely on undefined behavior when shifting a 1 left into
12139 the sign bit.
12140 * lisp.h (get_random): Change signature to match.
12141
2f30ecd0
PE
12142 * lread.c (hash_string): Use size_t, not int, for hash computation.
12143 Normally we prefer signed values; but hashing is special, because
12144 it's better to use unsigned division on hash table sizes so that
12145 the remainder is nonnegative. Also, size_t is the natural width
12146 for hashing into memory. The previous code used 'int', which doesn't
12147 retain enough info to hash well into very large tables.
12148 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12149
2a866e7b
PE
12150 * dbusbind.c: Don't possibly lose pointer info when converting.
12151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12152 Use XPNTR rather than XHASH, so that the high-order bits of
12153 the pointer aren't lost when converting through void *.
12154
51639eac
PE
12155 * eval.c (Fautoload): Don't double-shift a pointer.
12156
92394119
PE
12157 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12158
dbdb9a7c
JB
121592011-05-06 Juanma Barranquero <lekktu@gmail.com>
12160
12161 * gnutls.c (DEF_GNUTLS_FN):
12162 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12163
db7a0b4f
AS
121642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12165
12166 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12167 marker. (Bug#8610)
12168
cd394be1 121692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12170
12171 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12172 New version that can reserve upto 2GB of heap space.
12173
f7ff1b0f 121742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12175
12176 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12177
639c109b
TZ
121782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12179
12180 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12181 `gnutls_certificate_set_x509_key_file'.
12182
d2127135
JB
121832011-05-05 Juanma Barranquero <lekktu@gmail.com>
12184
12185 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12186 Update dependencies.
12187
e968f4f3
JB
121882011-05-04 Juanma Barranquero <lekktu@gmail.com>
12189
12190 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12191 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12192 Remove unused parameter `fildes'.
12193 * process.c (read_process_output, send_process): Don't pass it.
12194
84d358f0
JB
121952011-05-04 Juanma Barranquero <lekktu@gmail.com>
12196
12197 Fix previous change: the library cache is defined in w32.c.
12198 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12199 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12200
0898ca10
JB
122012011-05-04 Juanma Barranquero <lekktu@gmail.com>
12202
12203 Implement dynamic loading of GnuTLS on Windows.
12204
12205 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12206 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12207 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12208 Declare.
12209
12210 * gnutls.c (Qgnutls_dll): Define.
12211 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12212 (gnutls_*): Declare function pointers.
12213 (init_gnutls_functions): New function to initialize function pointers.
12214 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12215 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12216 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12217 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12218 (emacs_gnutls_write, emacs_gnutls_read)
12219 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12220 (Fgnutls_available_p): New function.
12221 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12222 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12223 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12224
12225 * image.c: Include w32.h.
12226 (Vimage_type_cache): Delete.
12227 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12228 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12229 (w32_delayed_load): Move to w32.c.
12230
12231 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12232
12233 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12234 (w32_delayed_load): Move from image.c. When loading a library, record
12235 its filename in the :loaded-from property of the library id.
12236 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12237 Initialize and staticpro them.
12238 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12239
12240 * process.c: Include lisp.h before w32.h, not after.
12241 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12242 instead of gnutls_record_check_pending.
12243
12244 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12245
ff4de4aa
TZ
122462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12247
12248 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12249 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12250 as passed in.
12251
abe95abb
JD
122522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12253
12254 * xterm.c (x_set_frame_alpha): Do not set property on anything
12255 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12256
e16e55d4
JB
122572011-05-02 Juanma Barranquero <lekktu@gmail.com>
12258
12259 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12260
bafcf6a5
JB
122612011-05-02 Juanma Barranquero <lekktu@gmail.com>
12262
12263 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12264 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12265 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12266 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12267 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12268 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12269 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12270 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12271 (Qgnutls_bootprop_callbacks_verify): Make static.
12272
e7a6747f
AS
122732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12274
19ed11ba
AS
12275 * callproc.c: Indentation fixup.
12276
e7a6747f 12277 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12278 (wait_for_termination, interruptible_wait_for_termination):
12279 Move after wait_for_termination_1.
e7a6747f 12280
1ef14cb4
LMI
122812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12282
12283 * sysdep.c (interruptible_wait_for_termination): New function
12284 which is like wait_for_termination, but allows keyboard
12285 interruptions.
12286
12287 * callproc.c (Fcall_process): Add (:file "file") as an option for
12288 the STDOUT buffer.
12289 (Fcall_process_region): Ditto.
12290
330d880c
EZ
122912011-04-30 Eli Zaretskii <eliz@gnu.org>
12292
8db90b73
EZ
12293 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12294 rather than `XVECTOR (FOO)->size'.
12295
330d880c
EZ
12296 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12297 inttypes.h, as a gnulib replacement is used if it not available in
12298 system headers.
12299
15cbd324
EZ
123002011-04-21 Eli Zaretskii <eliz@gnu.org>
12301
12302 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12303 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12304 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12305
12306 * coding.c (coding_alloc_by_realloc): Error out if destination
12307 will grow beyond MOST_POSITIVE_FIXNUM.
12308 (decode_coding_emacs_mule): Abort if there isn't enough place in
12309 charbuf for the composition carryover bytes. Reserve an extra
12310 space for up to 2 characters produced in a loop.
12311 (decode_coding_iso_2022): Abort if there isn't enough place in
12312 charbuf for the composition carryover bytes.
12313
123142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12315
ae940cca
EZ
12316 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12317 aborting when %lld or %lll format is passed.
12318 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12319 %llo or %llx format is passed. (Bug#8545)
12320
03ab8921
EZ
12321 * window.c (window_scroll_line_based): Use a marker instead of
12322 simple variables to record original value of point. (Bug#7952)
12323
afda1437
EZ
12324 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12325 produced by %s or %c overflows available buffer space. (Bug#8545)
12326
f76dee0c
PE
123272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12328
12329 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12330 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12331
fdc5744d
JB
123322011-04-28 Juanma Barranquero <lekktu@gmail.com>
12333
12334 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12335
638f053a
JB
123362011-04-28 Juanma Barranquero <lekktu@gmail.com>
12337
12338 * keyboard.c (Qdelayed_warnings_hook): Define.
12339 (command_loop_1): Run `delayed-warnings-hook'
12340 if Vdelayed_warnings_list is non-nil.
12341 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12342 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12343
d178f871
EZ
123442011-04-28 Eli Zaretskii <eliz@gnu.org>
12345
12346 * doprnt.c (doprnt): Don't return value smaller than the buffer
12347 size if the message was truncated. (Bug#8545).
12348
b124fd93
JB
123492011-04-28 Juanma Barranquero <lekktu@gmail.com>
12350
12351 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12352 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12353
e810457d
PE
123542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12355
12356 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12357
ea51cceb
JB
123582011-04-27 Juanma Barranquero <lekktu@gmail.com>
12359
12360 * makefile.w32-in: Update dependencies.
12361
94dcfacf
EZ
123622011-04-27 Eli Zaretskii <eliz@gnu.org>
12363
12364 Improve `doprnt' and its usage. (Bug#8545)
12365 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12366 `format_end'. Remove support for %l as a conversion specifier.
12367 Don't use xrealloc. Improve diagnostics when the %l size modifier
12368 is used. Update the commentary.
12369
12370 * eval.c (verror): Simplify calculation of size_t.
12371
12372 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12373 messages.
12374
f61f41d7
PE
123752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12376
12377 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12378 change.
12379
96fb4434
PE
123802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12381
12382 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12383 This makes this file independent of the recent pseudovector change.
12384
671875da 123852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12386
69e9b5a3
PE
12387 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12388
b5f869a7 12389 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12390 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12391 Remove unused local.
c8926152 12392 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12393
841a1577 12394 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12395 GCC 4.6.0 optimizes based on type-based alias analysis.
12396 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12397 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12398 != &v->size, and therefore "v->size = 1; b->size = 2; return
12399 v->size;" must therefore return 1. This assumption is incorrect
12400 for Emacs, since it type-puns struct Lisp_Vector * with many other
12401 types. To fix this problem, this patch adds a new type struct
f904488f 12402 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12403 and pseudovectors, and helps optimizing compilers not get fooled
12404 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12405 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12406 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12407 the size member.
eab3844f
PE
12408 (XSETPVECTYPE): Rewrite in terms of new macro.
12409 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12410 This is a bit clearer, and further avoids the possibility of
12411 undesirable aliasing.
12412 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12413 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12414 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12415 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12416 (ASIZE): Now uses header.size rather than size.
12417 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12418 to avoid the hassle of writing XVECTOR (foo)->header.size.
12419 (struct vectorlike_header): New type.
eab3844f
PE
12420 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12421 object, to help avoid aliasing.
12422 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12423 (SUBRP): Likewise, since Lisp_Subr is a special case.
12424 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12425 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12426 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12427 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12428 changed to be "header.size" and "header.next".
12429 * buffer.h (struct buffer): Likewise.
12430 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12431 * frame.h (struct frame): Likewise.
12432 * process.h (struct Lisp_Process): Likewise.
12433 * termhooks.h (struct terminal): Likewise.
12434 * window.c (struct save_window_data, struct saved_window): Likewise.
12435 * window.h (struct window): Likewise.
12436 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12437 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12438 * buffer.c (init_buffer_once): Likewise.
12439 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12440 special case.
12441 * process.c (Fformat_network_address): Use local var for size,
12442 for brevity.
12443
0df1eac5
PE
12444 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12445
847ab9d1 12446 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12447 * data.c (atof): Remove decl; no longer used or needed.
12448 (digit_to_number): Move to lread.c.
12449 (Fstring_to_number): Use new string_to_number function, to be
12450 consistent with how the Lisp reader treats infinities and NaNs.
12451 Do not assume that floating-point numbers represent EMACS_INT
12452 without losing information; this is not true on most 64-bit hosts.
12453 Avoid double-rounding errors, by insisting on integers when
12454 parsing non-base-10 numbers, as the documentation specifies.
12455 * lisp.h (string_to_number): New decl, replacing ...
12456 (isfloat_string): Remove.
bc0a5c13 12457 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12458 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12459 appears to have been a coding error. Similarly, do not accept
12460 strings like +-1e0 as floating point numbers. Do not report
12461 overflow for integer overflows unless the base is not 10 which
12462 means we have no simple and reliable way to continue.
12463 Break out the floating-point parsing into a new
12464 function string_to_number, so that Fstring_to_number parses
12465 floating point numbers consistently with the Lisp reader.
04f2d78b 12466 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12467 (E_CHAR, EXP_INT): Remove, replacing with ...
12468 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12469 (string_to_number): New function, replacing isfloat_string.
12470 This function checks for valid syntax and produces the resulting
12471 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12472 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12473 so that overflow for non-base-10 numbers is reported only when
12474 there's no portable and simple way to convert to floating point.
452f4150 12475
67769ffc
PE
12476 * textprop.c (set_text_properties_1): Rewrite for clarity,
12477 and to avoid GCC warning about integer overflow.
12478
c20db43f
PE
12479 * intervals.h (struct interval): Use EMACS_INT for members
12480 where EMACS_UINT might cause problems. See
12481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12482 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12483 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12484 All uses changed.
37aa2f85
PE
12485 (offset_intervals): Tell GCC not to worry about length overflow
12486 when negating a negative length.
c20db43f 12487
2538aa2f
PE
12488 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12489 (overrun_check_free): Likewise.
12490
f2d3008d
PE
12491 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12492 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12493 word size.
12494
ec8df744
PE
12495 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12496 (gnutls_make_error): Rename local to avoid shadowing.
12497 (gnutls_emacs_global_deinit): ifdef out; not used.
12498 (Fgnutls_boot): Use const for pointer to readonly storage.
12499 Comment out unused local. Fix pointer signedness problems.
12500
640ee02d
PE
12501 * lread.c (openp): Don't stuff size_t into an 'int'.
12502 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12503 about possible signed overflow.
12504
6048fb2a
PE
12505 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12506 (GDK_KEY_g): Don't define if already defined.
12507 (xg_prepare_tooltip): Avoid pointer signedness problem.
12508 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12509
fa3c87e1
PE
12510 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12511 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12512
2172544b
PE
12513 * xfns.c (Fx_window_property): Simplify a bit,
12514 to make a bit faster and to avoid GCC 4.6.0 warning.
12515 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12516
9b821a21
PE
12517 * fns.c (internal_equal): Don't assume size_t fits in int.
12518
3c616cfa
PE
12519 * alloc.c (compact_small_strings): Tighten assertion a little.
12520
c2982e87
PE
12521 Replace pEd with more-general pI, and fix some printf arg casts.
12522 * lisp.h (pI): New macro, generalizing old pEd macro to other
12523 conversion specifiers. For example, use "...%"pI"d..." rather
12524 than "...%"pEd"...".
12525 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12526 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12527 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12528 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12529 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12530 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12531 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12532 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12533 64-bit hosts.
12534 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12535 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12536 * print.c (safe_debug_print, print_object): Likewise.
12537 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12538 to int.
6f04d126
PE
12539 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12540 avoiding the 0 flag, which is not portable.
c2982e87
PE
12541 * process.c (Fmake_network_process): Use pI to avoid cast.
12542 * region-cache.c (pp_cache): Likewise.
12543 * xdisp.c (decode_mode_spec): Likewise.
12544 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12545 behavior on 64-bit hosts with printf arg.
6f04d126 12546 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12547 (x_stop_queuing_selection_requests): Likewise.
12548 (x_get_window_property): Don't truncate byte count to an 'int'
12549 when tracing.
0b432f21 12550
5e073ec7
PE
12551 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12552 here, since it parses constructs like leading '-' and spaces,
12553 which are not wanted; and it overflows with large numbers.
12554 Instead, simply match F[0-9]+, which is what is wanted anyway.
12555
36372bf9
PE
12556 * alloc.c: Remove unportable assumptions about struct layout.
12557 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12558 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12559 (allocate_vectorlike, make_pure_vector): Use the new macros,
12560 plus offsetof, to remove unportable assumptions about struct layout.
12561 These assumptions hold on all porting targets that I know of, but
12562 they are not guaranteed, they're easy to remove, and removing them
12563 makes further changes easier.
12564
0b432f21
PE
12565 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12566 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12567 (string_overrun_cookie): Now const. Use initializers that
12568 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12569 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12570 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12571 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12572 multiple of sizeof (EMACS_INT); it need not be, if
12573 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12574 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12575
895009e1
JB
125762011-04-26 Juanma Barranquero <lekktu@gmail.com>
12577
12578 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12579
6a7a1b0b
TZ
125802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12581
12582 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12583 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12584 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12585
841a1577 125862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12587
12588 * lisp.h (Qdebug): List symbol.
895009e1 12589 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12590 * keyboard.c (debug-on-event): New variable.
12591 (handle_user_signal): Break into debugger when debug-on-event
12592 matches the current signal symbol.
12593
f2d3ba6f
DN
125942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12595
12596 * alloc.c (check_sblock, check_string_bytes)
12597 (check_string_free_list): Convert to standard C.
12598
42ce4c63
TZ
125992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12600
12601 * w32.c (emacs_gnutls_push): Fix typo.
12602
825cd63c
EZ
126032011-04-25 Eli Zaretskii <eliz@gnu.org>
12604
fb11d64d
EZ
12605 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12606 "cast to pointer from integer of different size".
12607
825cd63c
EZ
12608 Improve doprnt and its use in verror. (Bug#8545)
12609 * doprnt.c (doprnt): Document the set of format control sequences
12610 supported by the function. Use SAFE_ALLOCA instead of always
12611 using `alloca'.
12612
12613 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12614 is one byte too soon. Don't use xrealloc; instead xfree and
12615 xmalloc anew.
12616
e061a11b
TZ
126172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12618
12619 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12620 callbacks stage.
12621
12622 * gnutls.c: Renamed global_initialized to
12623 gnutls_global_initialized. Added internals for the
12624 :verify-hostname-error, :verify-error, and :verify-flags
12625 parameters of `gnutls-boot' and documented those parameters in the
12626 docstring. Start callback support.
9173deec
JB
12627 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12628 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12629 on error. Return error code.
e061a11b
TZ
12630 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12631 (emacs_gnutls_read): Likewise.
12632 (Fgnutls_boot): Return handshake error code.
12633 (emacs_gnutls_handle_error): New function.
12634 (wsaerror_to_errno): Likewise.
12635
12636 * w32.h (emacs_gnutls_pull): Add prototype.
12637 (emacs_gnutls_push): Likewise.
12638
12639 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12640 (emacs_gnutls_push): Likewise.
12641
126422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12643
12644 * process.c (wait_reading_process_output): Check if GnuTLS
12645 buffered some data internally if no FDs are set for TLS
12646 connections.
12647
12648 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12649 (LIBS): Link to USER_LIBS.
12650 ($(BLD)/gnutls.$(0)): New target.
12651
fa6996bc
EZ
126522011-04-24 Eli Zaretskii <eliz@gnu.org>
12653
eb35682e
EZ
12654 * xdisp.c (handle_single_display_spec): Rename the
12655 display_replaced_before_p argument into display_replaced_p, to
12656 make it consistent with the commentary. Fix typos in the
12657 commentary.
12658
e2ad650c
EZ
12659 * textprop.c (syms_of_textprop): Remove dead code.
12660 (copy_text_properties): Delete obsolete commentary about an
12661 interface that was deleted long ago. Fix typos in the description
12662 of arguments.
12663
1b2de274
EZ
12664 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12665 to changes in oldXMenu/XMenu.h from 2011-04-16.
12666 <menu_help_message, prev_menu_help_message>: Constify.
12667 (IT_menu_make_room): menu->help_text is now `const char **';
12668 adjust.
12669
12670 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12671 to changes in oldXMenu/XMenu.h from 2011-04-16.
12672 (struct XMenu): Declare `help_text' `const char **'.
12673
12674 * xfaces.c <Qunspecified>: Make extern again.
12675
12676 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12677 required by POSIX.
1b2de274 12678
762b15be
EZ
12679 * doc.c (get_doc_string): Improve the format passed to `error'.
12680
12681 * doprnt.c (doprnt): Improve commentary.
12682
12683 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12684
12685 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12686 them with etags.
12687
f1052e5d
EZ
12688 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12689 changes in globals.h immediately force recompilation.
762b15be
EZ
12690 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12691 $(CURDIR)/s/ms-w32.h.
12692 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12693
fa6996bc
EZ
12694 * character.c (Fchar_direction): Function deleted.
12695 (syms_of_character): Don't defsubr it.
12696 <char-direction-table>: Deleted.
12697
e6c3da20
EZ
126982011-04-23 Eli Zaretskii <eliz@gnu.org>
12699
12700 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12701 * doprnt.c: Include limits.h.
12702 (SIZE_MAX): New macro.
04f2d78b
CB
12703 (doprnt): Return a size_t value. 2nd arg is now size_t.
12704 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12705 Improve overflow protection. Support `l' modifier for integer
12706 conversions. Support %l conversion. Don't assume an EMACS_INT
12707 argument for integer conversions and for %c.
12708
12709 * lisp.h (doprnt): Restore prototype.
12710
12711 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12712 $(SRC)/character.h.
12713
12714 * Makefile.in (base_obj): Add back doprnt.o.
12715
12716 * deps.mk (doprnt.o): Add back prerequisites.
12717 (callint.o): Depend on character.h.
12718
12719 * eval.c (internal_lisp_condition_case): Include the handler
12720 representation in the error message.
12721 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12722 when breaking from the loop.
12723
12724 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12725
12726 * callint.c (Fcall_interactively): When displaying error message
12727 about invalid control letter, pass the character's codepoint, not
12728 a pointer to its multibyte form. Improve display of the character
12729 in octal and display also its hex code.
12730
12731 * character.c (char_string): Use %x to display the (unsigned)
12732 codepoint of an invalid character, to avoid displaying a bogus
12733 negative value.
12734
12735 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12736 `error', not SYMBOL_NAME itself.
12737
12738 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12739 character arguments to `error'.
12740
12741 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12742 to `error' in error message about FINAL_CHAR argument. Make sure
12743 FINAL_CHAR is a character, and use %c when it is passed as
12744 argument to `error'.
12745
4ffd0d6b 127462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12747
12748 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12749
12750 * w32.c: Include <time.h>.
12751 (sys_localtime): New function.
12752
4ffd0d6b 127532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12754
12755 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12756
4ffd0d6b 12757 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12758
4ffd0d6b 127592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12760
4ffd0d6b
GM
12761 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12762 zombies (Bug#8467).
aac0c6e3 12763
04c56954
EZ
127642011-04-19 Eli Zaretskii <eliz@gnu.org>
12765
12766 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12767 gl_state.e_property when gl_state.object is Qt.
12768
12769 * insdel.c (make_gap_larger): Remove limitation of buffer size
12770 to <= INT_MAX.
12771
16a43933
CY
127722011-04-18 Chong Yidong <cyd@stupidchicken.com>
12773
12774 * xdisp.c (lookup_glyphless_char_display)
12775 (produce_glyphless_glyph): Handle cons cell entry in
12776 glyphless-char-display.
12777 (Vglyphless_char_display): Document it.
12778
12779 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12780 glyphless-char-display.
12781
4581706e
CY
127822011-04-17 Chong Yidong <cyd@stupidchicken.com>
12783
12784 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12785
12786 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12787
12788 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12789 definition for no-X builds.
12790
4887c6e2 127912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12792
fd35b6f9
PE
12793 Static checks with GCC 4.6.0 and non-default toolkits.
12794
5c1ccb01
PE
12795 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12796
006c5daa
PE
12797 * process.c (keyboard_bit_set): Define only if SIGIO.
12798 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12799 (send_process): Repair possible setjmp clobbering.
12800
efc736d3
PE
12801 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12802
4e2fe2e6
PE
12803 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12804
f97334a2
PE
12805 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12806
4e75f29d
PE
12807 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12808 Define only if needed.
12809
90efadd1
PE
12810 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12811 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12812 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12813
3c647824
PE
12814 * dispextern.h (struct redisplay_interface): Rename param
12815 to avoid shadowing.
e264f262 12816 * termhooks.h (struct terminal): Likewise.
761383f4 12817 * xterm.c (xembed_send_message): Likewise.
3c647824 12818
b58c5c4a
PE
12819 * insdel.c (make_gap_smaller): Define only if
12820 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12821
cad59032
PE
12822 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12823 it.
12824
c339dc2e
PE
12825 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12826 so that we aren't warned about unused symbols.
12827
91a3e27b
PE
12828 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12829
399c71d3 12830 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12831
8ffc96f5
PE
12832 * xfns.c (x_real_positions): Mark locals as initialized.
12833
eef9bc79
PE
12834 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12835
098db9dd
PE
12836 * xterm.c: Fix problems found by static analysis with other toolkits.
12837 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12838 (x_dispatch_event): Declare static if USE_GTK, and
12839 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12840 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12841 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12842 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12843 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12844
eb18f6cc
PE
12845 * xmenu.c (menu_help_callback): Pointer type fixes.
12846 Use const pointers when pointing at readonly data. Avoid pointer
12847 signedness clashes.
12848 (FALSE): Remove unused macro.
12849 (update_frame_menubar): Remove unused decl.
12850
1fe72bf8
PE
12851 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12852
60d9e1db
PE
12853 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12854 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12855 (single_menu_item): Rename local to avoid shadowing.
12856
39261c26
PE
12857 * keyboard.c (make_lispy_event): Remove unused local var.
12858
018c5e19
PE
12859 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12860 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12861
63d2b86e
PE
12862 * bitmaps: Change bitmaps from unsigned char back to the X11
12863 compatible char. Avoid the old compiler warnings about
12864 out-of-range initializers by using, for example, '\xab' rather
12865 than 0xab.
12866
aefd87e1
PE
12867 * xgselect.c (xgselect_initialize): Check vs interface
12868 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12869
bf501fb9
PE
12870 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12871
e9829fdf
PE
12872 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12873 to read-only memory.
12874
1086c095
PE
12875 * fns.c (vector): Remove; this old hack is no longer needed.
12876
2baccd04 12877 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12878 Remove unused var.
dde42981 12879 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12880
72391843 12881 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12882
436c16df 12883 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12884 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12885 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12886
92bb796d 12887 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12888 (x_term_init): Remove local to avoid shadowing.
92bb796d 12889
764430a3 12890 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12891
12892 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12893 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12894
d1dfb56c
EZ
128952011-04-16 Eli Zaretskii <eliz@gnu.org>
12896
c4354cb4
EZ
12897 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12898
d1dfb56c
EZ
12899 Fix regex.c, syntax.c and friends for buffers > 2GB.
12900 * syntax.h (struct gl_state_s): Declare character position members
12901 EMACS_INT.
12902
12903 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12904
04f2d78b
CB
12905 * textprop.c (verify_interval_modification, interval_of):
12906 Declare arguments EMACS_INT.
d1dfb56c
EZ
12907
12908 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12909 EMACS_INT.
12910
12911 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12912
12913 * indent.c (Fvertical_motion): Local variable it_start is now
12914 EMACS_INT.
12915
12916 * regex.c (re_match, re_match_2, re_match_2_internal)
12917 (bcmp_translate, regcomp, regexec, print_double_string)
12918 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12919 (re_compile_pattern, re_exec): Declare arguments and local
12920 variables `size_t' and `ssize_t' and return values `regoff_t', as
12921 appropriate.
12922 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12923 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12924 <compile_stack_type>: `size' and `avail' are now `size_t'.
12925
12926 * regex.h <regoff_t>: Use ssize_t, not int.
12927 (re_search, re_search_2, re_match, re_match_2): Arguments that
12928 specify buffer/string position and length are now ssize_t and
12929 size_t. Return type is regoff_t.
12930
613052cd
BK
129312011-04-16 Ben Key <bkey76@gmail.com>
12932
12933 * nsfont.m: Fixed bugs in ns_get_family and
12934 ns_descriptor_to_entity that were caused by using free to
12935 deallocate memory blocks that were allocated by xmalloc (via
12936 xstrdup). This caused Emacs to crash when compiled with
12937 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12938 --enable-checking=xmallocoverrun). xfree is now used to
12939 deallocate these memory blocks.
12940
4170f62f 129412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12942
71b41406
PE
12943 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12944
9587a89d
PE
12945 emacs_write: Accept and return EMACS_INT for sizes.
12946 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12947 et seq.
12948 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12949 Accept and return EMACS_INT.
12950 (emacs_gnutls_write): Return the number of bytes written on
12951 partial writes.
12952 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12953 (emacs_read, emacs_write): Remove check for negative size, as the
12954 Emacs source code has been audited now.
9587a89d
PE
12955 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12956 (emacs_read, emacs_write): Use it.
273a5f82
PE
12957 * process.c (send_process): Adjust to the new signatures of
12958 emacs_write and emacs_gnutls_write. Do not attempt to store
12959 a byte offset into an 'int'; it might overflow.
9587a89d 12960 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12961
3e047f51
PE
12962 * sound.c: Don't assume sizes fit in 'int'.
12963 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12964 Return EMACS_INT, not int.
3e047f51 12965 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12966 Accept EMACS_INT, not int.
12967 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12968 record read return values.
12969
cc39a9db
BK
129702011-04-15 Ben Key <bkey76@gmail.com>
12971
c9d0ec6d
JB
12972 * keyboard.c (Qundefined): Don't declare static since it is used
12973 in nsfns.m.
12974 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12975 static since they are used in nsfont.m.
cc39a9db 12976
6c60eb9f
SM
129772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12978
12979 * process.c (Qprocessp): Don't declare static.
12980 * lisp.h (Qprocessp): Declare again.
12981
7990b61a
JB
129822011-04-15 Juanma Barranquero <lekktu@gmail.com>
12983
12984 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12985
5d4cb038
PE
129862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12987
8bd7b830 12988 Improve C-level modularity by making more things 'static'.
cd64ea1d 12989
e3b27b31
PE
12990 Don't publish debugger-only interfaces to other modules.
12991 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12992 (verify_bytepos, count_markers): Move decls to the only modules
12993 that need them.
12994 * region-cache.h (pp_cache): Likewise.
12995 * window.h (check_all_windows): Likewise.
12996 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12997
5d4cb038
PE
12998 * sysdep.c (croak): Now static, if
12999 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13000 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13001
13002 * alloc.c (refill_memory_reserve): Now static if
13003 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13004 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13005
e87b6180
PE
13006 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13007 Define only if USE_LUCID.
13008
ac64929e
PE
13009 * xrdb.c (x_customization_string, x_rm_string): Now static.
13010
6f37259d
PE
13011 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13012 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13013
1683e3ab
PE
13014 * xdisp.c (draw_row_with_mouse_face): Now static.
13015 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13016
de9c2632
PE
13017 * window.h (check_all_windows): Mark externally visible.
13018
2b96acb7
PE
13019 * window.c (window_deletion_count): Now static.
13020
13021 * undo.c: Make symbols static if they're not exported.
13022 (last_undo_buffer, last_boundary_position, pending_boundary):
13023 Now static.
13024
50436f33
PE
13025 * textprop.c (interval_insert_behind_hooks): Now static.
13026 (interval_insert_in_front_hooks): Likewise.
13027
64520e5c
PE
13028 * term.c: Make symbols static if they're not exported.
13029 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13030 (max_frame_lines, tty_set_terminal_modes):
13031 (tty_reset_terminal_modes, tty_turn_off_highlight):
13032 (get_tty_terminal): Now static.
13033 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13034 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13035 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13036 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13037 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13038
1fa53021
PE
13039 * sysdep.c: Make symbols static if they're not exported.
13040 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13041 Now static.
13042 (sigprocmask_set, full_mask): Remove; unused.
13043 (wait_debugging): Mark as visible.
13044 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13045 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13046
d4b43b22
PE
13047 * syntax.c (syntax_temp): Define only if !__GNUC__.
13048
b7c513d0
PE
13049 * sound.c (current_sound_device, current_sound): Now static.
13050
989b29ad
PE
13051 * search.c (searchbufs, searchbuf_head): Now static.
13052
13a55a78
PE
13053 * scroll.c (scroll_cost): Remove; unused.
13054 * dispextern.h (scroll_cost): Remove decl.
13055
de68a1fc
PE
13056 * region-cache.h (pp_cache): Mark as externally visible.
13057
40ccffa6
PE
13058 * process.c: Make symbols static if they're not exported.
13059 (process_tick, update_tick, create_process, chan_process):
13060 (Vprocess_alist, proc_buffered_char, datagram_access):
13061 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13062 (deactivate_process): Mark defn as static, as well as decl.
13063 * lisp.h (create_process): Remove decl.
13064 * process.h (chan_process, Vprocess_alist): Remove decls.
13065
ad64fc97
PE
13066 * print.c: Make symbols static if they're not exported.
13067 (print_depth, new_backquote_output, being_printed, print_buffer):
13068 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13069 (print_interval, print_number_index, initial_stderr_stream):
13070 Now static.
13071 * lisp.h (Fprinc): Remove decl.
13072 (debug_output_compilation_hack): Mark as externally visible.
13073
adddb265
PE
13074 * sysdep.c (croak): Move decl from here to syssignal.h.
13075 * syssignal.h (croak): Put it here, so the API can be checked when
13076 'croak' is called from dissociate_if_controlling_tty.
13077
1717ede2
PE
13078 * minibuf.c: Make symbols static if they're not exported.
13079 (minibuf_save_list, choose_minibuf_frame): Now static.
13080 * lisp.h (choose_minibuf_frame): Remove decl.
13081
fa5fb2bc
PE
13082 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13083
1e3890d1
PE
13084 * lread.c: Make symbols static if they're not exported.
13085 (read_objects, initial_obarray, oblookup_last_bucket_number):
13086 Now static.
13087 (make_symbol): Remove; unused.
13088 * lisp.h (initial_obarray, make_symbol): Remove decls.
13089
8a1414fa
PE
13090 * keyboard.c: Make symbols static if they're not exported.
13091 (single_kboard, recent_keys_index, total_keys, recent_keys):
13092 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13093 (this_single_command_key_start, echoing, last_auto_save):
13094 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13095 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13096 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13097 (Vlispy_mouse_stem, double_click_count):
13098 Now static.
13099 (force_auto_save_soon): Define only if SIGDANGER.
13100 (ignore_mouse_drag_p): Now static if
13101 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13102 (print_help): Remove; unused.
13103 (stop_character, last_timer_event): Mark as externally visible.
13104 * keyboard.h (ignore_mouse_drag_p): Declare only if
13105 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13106 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13107 * lisp.h (echoing): Remove decl.
13108 (force_auto_save_soon): Declare only if SIGDANGER.
13109 * xdisp.c (redisplay_window): Simplify code, to make it more
13110 obvious that ignore_mouse_drag_p is not accessed if !defined
13111 USE_GTK && !defined HAVE_NS.
13112
93ea6e8f
PE
13113 * intervals.c: Make symbols static if they're not exported.
13114 (merge_properties_sticky, merge_interval_right, delete_interval):
13115 Now static.
13116 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13117
77382fcc
PE
13118 * insdel.c: Make symbols static if they're not exported.
13119 However, leave prepare_to_modify_buffer alone. It's never
13120 called from outside this function, but that appears to be a bug.
13121 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13122 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13123 (adjust_after_replace_noundo): Remove; unused.
13124 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13125 (signal_before_change): Remove decls.
77382fcc 13126
9306c32e
PE
13127 * indent.c (val_compute_motion, val_vmotion): Now static.
13128
cd44d2eb
PE
13129 * image.c: Make symbols static if they're not exported.
13130 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13131 if USE_GTK.
13132 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13133 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13134
ad9a7a06
PE
13135 * fringe.c (standard_bitmaps): Now static.
13136 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13137
81626931
PE
13138 * frame.c: Make symbols static if they're not exported.
13139 (x_report_frame_params, make_terminal_frame): Now static.
13140 (get_frame_param): Now static, unless HAVE_NS.
13141 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13142 (x_get_resource_string): Remove; not used.
13143 * frame.h (make_terminal_frame, x_report_frame_params):
13144 (x_get_resource_string); Remove decls.
13145 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13146 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13147
239f9db9
PE
13148 * font.c, fontset.c: Make symbols static if they're not exported.
13149 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13150 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13151 * font.c (font_close_object): Now static.
13152 * font.h (font_close_object): Remove.
13153 * fontset.c (FONTSET_OBJLIST): Remove.
13154 (free_realized_fontset) #if-0 the body, which does nothing.
13155 (face_suitable_for_char_p): #if-0, as it's never called.
13156 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13157 * xfaces.c (face_at_string_position):
13158 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13159 since 0 is always ASCII.
13160
dfcf3579
PE
13161 * fns.c (weak_hash_tables): Now static.
13162
5045092b
PE
13163 * fileio.c: Make symbols static if they're not exported.
13164 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13165 (Vwrite_region_annotation_buffers): Now static.
13166
57a96f5c
PE
13167 * eval.c: Make symbols static if they're not exported.
13168 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13169 * lisp.h (backtrace_list): Remove decl.
13170
35f08c38
PE
13171 * emacs.c: Make symbols static if they're not exported.
13172 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13173 (fatal_error_code, fatal_error_signal_hook, standard_args):
13174 Now static.
13175 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13176 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13177 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13178 * lisp.h (fatal_error_signal_hook): Remove decl.
13179 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13180
f44bd759
PE
13181 * editfns.c: Move a (normally-unused) function to its only use.
13182 * editfns.c, lisp.h (get_operating_system_release): Remove.
13183 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13184 worth the hassle of breaking this out.
13185
b532497d
PE
13186 * xterm.c: Make symbols static if they're not exported.
13187 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13188 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13189 (x_destroy_window, x_delete_display):
13190 Now static.
13191 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13192 (x_mouse_leave): Remove; unused.
13193 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13194 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13195 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13196 Remove decls.
13197 (x_mouse_leave): Declare only if WINDOWSNT.
13198 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13199 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13200 USE_X_TOOLKIT.
13201
1675728f
PE
13202 * ftxfont.c: Make symbols static if they're not exported.
13203 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13204 HAVE_FREETYPE.
13205 * font.h (ftxfont_driver): Likewise.
13206
e4cebfca
PE
13207 * xfns.c: Make symbols static if they're not exported.
13208 (x_last_font_name, x_display_info_for_name):
13209 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13210 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13211 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13212 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13213 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13214 (last_show_tip_args): Now static.
13215 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13216 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13217 (x_screen_planes): Remove; unused.
13218 * dispextern.h (x_screen_planes): Remove decl.
13219
5bf46f05
PE
13220 * dispnew.c: Make symbols static if they're not exported.
13221 * dispextern.h (redraw_garbaged_frames, scrolling):
13222 (increment_row_positions): Remove.
13223 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13224 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13225 Now static.
13226 (redraw_garbaged_frames): Remove; unused.
13227
435f4c28
PE
13228 * xfaces.c: Make symbols static if they're not exported.
13229 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13230 Remove decls.
13231 * xterm.h (defined_color): Remove decls.
13232 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13233 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13234 (menu_face_changed_default, defined_color, free_realized_face):
13235 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13236 (ascii_face_of_lisp_face): Remove; unused.
13237
8524aef3
PE
13238 * xdisp.c: Make symbols static if they're not exported.
13239 * dispextern.h (scratch_glyph_row, window_box_edges):
13240 (glyph_to_pixel_coords, set_cursor_from_row):
13241 (get_next_display_element, set_iterator_to_next):
13242 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13243 (show_mouse_face): Remove decls
13244 * frame.h (message_buf_print): Likewise.
13245 * lisp.h (pop_message, set_message, check_point_in_composition):
13246 Likewise.
13247 * xterm.h (set_vertical_scroll_bar): Likewise.
13248 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13249 (message_buf_print, scratch_glyph_row, displayed_buffer):
13250 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13251 (get_next_display_element, show_mouse_face, window_box_edges):
13252 (frame_to_window_pixel_xy, check_point_in_composition):
13253 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13254 (glyph_to_pixel_coords): Remove; unused.
13255
16390cd2
PE
13256 * dired.c (file_name_completion): Now static.
13257
13258 * dbusbind.c (xd_in_read_queued_messages): Now static.
13259
a25f4dfa
PE
13260 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13261 * data.c (circular_list_error): Remove.
13262
14a9c8df
PE
13263 * commands.h (last_point_position, last_point_position_buffer):
13264 (last_point_position_window): Remove decls.
13265 * keyboard.c: Make these variables static.
13266
04f2d78b
CB
13267 * coding.h (coding, code_convert_region, encode_coding_gap):
13268 Remove decls.
74ab6df5
PE
13269 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13270 (iso_code_class, detect_coding, code_convert_region): Now static.
13271 (encode_coding_gap): Remove; unused.
13272
38dfbee1
PE
13273 * chartab.c (chartab_chars, chartab_bits): Now static.
13274
a2cb4e63
PE
13275 * charset.h (charset_iso_8859_1): Remove decl.
13276 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13277 Now static.
13278
127198fd
PE
13279 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13280 * ccl.c (Vccl_program_table): Now static.
13281 (check_ccl_update): Remove; unused.
13282
d85b608f
PE
13283 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13284 * category.h: ... from here.
13285 * category.c (check_category_table, set_category_set): Now static.
13286
31cd66f3
PE
13287 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13288 * lisp.h: Remove these decls.
13289
c358e587
PE
13290 * buffer.c (buffer_count): Remove unused var.
13291
e78aecca
PE
13292 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13293 so that it's not optimized away.
13294 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13295 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13296 exported only to the debugger.
13297
e192d7d3 13298 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13299 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13300
92470028
PE
13301 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13302 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13303 was inaccessible from Lisp.
13304 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13305 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13306
244ed907
PE
13307 alloc.c: Import and export fewer symbols, and remove unused items.
13308 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13309 is defined.
13310 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13311 it's not optimized away by whole-program optimization.
13312 (message_enable_multibyte, free_misc): Remove.
13313 (catchlist, handlerlist, mark_backtrace):
13314 Declare only if BYTE_MARK_STACK.
13315 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13316 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13317 (message_enable_multibyte): Remove decl.
13318 (free_misc, interval_free_list, float_block, float_block_index):
13319 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13320 (cons_free_list, last_marked_index):
13321 Now static.
13322 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13323 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13324 (mark_backtrace): Define only if BYTE_MARK_STACK.
13325 * xdisp.c (message_enable_multibyte): Now static.
13326
61c2b50e 13327 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13328 This makes it easier for human readers (and static analyzers)
13329 to see whether these variables are used from other modules.
13330 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13331 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13332 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13333 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13334 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13335 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13336 * xmenu.c, xselect.c:
13337 Declare Q* vars static if they are not used in other modules.
13338 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13339 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13340 Remove decls of unexported vars.
13341 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13342
95c82688
PE
13343 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13344
16a97296
PE
13345 Make Emacs functions such as Fatom 'static' by default.
13346 This makes it easier for human readers (and static analyzers)
13347 to see whether these functions can be called from other modules.
13348 DEFUN now defines a static function. To make the function external
13349 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13350 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13351 (Finit_image_library):
16a97296
PE
13352 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13353 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13354 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13355 Remove decls, since these functions are now static.
13356 (Funintern, Fget_internal_run_time): New decls, since these functions
13357 were already external.
95c82688 13358
16a97296
PE
13359 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13360 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13361 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13362 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13363 * keyboard.c, keymap.c, lread.c:
13364 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13365 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13366 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13367 Mark functions with DEFUE instead of DEFUN,
13368 if they are used in other modules.
13369 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13370 decls for now-static functions.
13371 * buffer.h (Fdelete_overlay): Remove decl.
13372 * callproc.c (Fgetenv_internal): Mark as internal.
13373 * composite.c (Fremove_list_of_text_properties): Remove decl.
13374 (Fcomposition_get_gstring): New forward static decl.
13375 * composite.h (Fcomposite_get_gstring): Remove decl.
13376 * dired.c (Ffile_attributes): New forward static decl.
13377 * doc.c (Fdocumntation_property): New forward static decl.
13378 * eval.c (Ffetch_bytecode): New forward static decl.
13379 (Funintern): Remove extern decl; now in .h file where it belongs.
13380 * fileio.c (Fmake_symbolic_link): New forward static decl.
13381 * image.c (Finit_image_library): New forward static decl.
13382 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13383 * intervals.h (Fprevious_property_change):
13384 (Fremove_list_of_text_properties): Remove decls.
13385 * keyboard.c (Fthis_command_keys): Remove decl.
13386 (Fcommand_execute): New forward static decl.
13387 * keymap.c (Flookup_key): New forward static decl.
13388 (Fcopy_keymap): Now static.
13389 * keymap.h (Flookup_key): Remove decl.
13390 * process.c (Fget_process): New forward static decl.
13391 (Fprocess_datagram_address): Mark as internal.
13392 * syntax.c (Fsyntax_table_p): New forward static decl.
13393 (skip_chars): Remove duplicate decl.
13394 * textprop.c (Fprevious_property_change): New forward static decl.
13395 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13396 Now internal.
13397 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13398 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13399
785bbd42
PE
13400 * editfns.c (Fformat): Remove unreachable code.
13401
8b913b57
AS
134022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13403
13404 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13405 change. (Bug#8496)
13406
a6744a35
EZ
134072011-04-13 Eli Zaretskii <eliz@gnu.org>
13408
13409 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13410 when at ZV. (Bug#8487)
13411
e7974947
AS
134122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13413
baad03f0
AS
13414 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13415 (Bug#8437)
13416 * keyboard.c (parse_tool_bar_item): Likewise.
13417 * sound.c (sound_cleanup, alsa_close): Likewise.
13418 * termcap.c (tgetent): Likewise.
13419 * xfns.c (x_default_font_parameter): Likewise.
13420 * xsettings.c (read_and_apply_settings): Likewise.
13421
e7974947
AS
13422 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13423 (overrun_check_free): Protoize.
13424
28272684
PE
134252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13426
13427 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13428 since callers should never pass a negative size.
13429 Change the signature to match that of plain 'read' and 'write'; see
13430 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13431 * lisp.h: Update prototypes of emacs_write and emacs_read.
13432
11997c76
EZ
134332011-04-11 Eli Zaretskii <eliz@gnu.org>
13434
13435 * xdisp.c (redisplay_window): Don't try to determine the character
13436 position of the scroll margin if the window start point w->startp
e896f03c 13437 is outside the buffer's accessible region. (Bug#8468)
11997c76 13438
8a2cbd72
EZ
134392011-04-10 Eli Zaretskii <eliz@gnu.org>
13440
13441 Fix write-region and its subroutines for buffers > 2GB.
13442 * fileio.c (a_write, e_write): Modify declaration of arguments and
13443 local variables to support buffers larger than 2GB.
13444 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13445
13446 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13447 argument, local variables, and return value.
13448
13449 * lisp.h: Update prototypes of emacs_write and emacs_read.
13450
13451 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13452
4073e537 134532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13454
1ebfdcb6
PE
13455 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13456
b2ded58d
PE
13457 Fix more problems found by GCC 4.6.0's static checks.
13458
7d66342c
PE
13459 * xdisp.c (vmessage): Use a better test for character truncation.
13460
bbf47d44
PE
13461 * charset.c (load_charset_map): <, not <=, for optimization,
13462 and to avoid potential problems with integer overflow.
9248994d 13463 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13464 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13465 * editfns.c (Fformat): Likewise.
1e69125e 13466 * syntax.c (skip_chars): Likewise.
3befa583 13467
e3019616
PE
13468 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13469 This also lets GCC 4.6.0 generate slightly better loop code.
13470
becfa255
PE
13471 * callint.c (Fcall_interactively): <, not <=, for optimization.
13472 (Fcall_interactively): Count the number of arguments produced,
13473 not the number of arguments given. This is simpler and lets GCC
13474 4.6.0 generate slightly better code.
13475
dae0cd48
PE
13476 * ftfont.c: Distingish more carefully between FcChar8 and char.
13477 The previous code passed unsigned char * to a functions like
13478 strlen and xstrcasecmp that expect char *, which does not
13479 conform to the C standard.
13480 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13481 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13482 char * when the C standard requires it.
13483
76032d70
PE
13484 * keyboard.c (read_char): Remove unused var.
13485
eb3f1cc8
PE
13486 * eval.c: Port to Windows vsnprintf (Bug#8435).
13487 Include <limits.h>.
13488 (SIZE_MAX): Define if the headers do not.
13489 (verror): Do not give up if vsnprintf returns a negative count.
13490 Instead, grow the buffer. This ports to Windows vsnprintf, which
13491 does not conform to C99. Problem reported by Eli Zaretskii.
13492 Also, simplify the allocation scheme, by avoiding the need for
13493 calling realloc, and removing the ALLOCATED variable.
13494
70476b54
PE
13495 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13496
12020a9e
PE
13497 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13498 But keep the doprint source code for now, as we might revamp it
13499 and use it again (Bug#8435).
ea6c7ae6
PE
13500 * lisp.h (doprnt): Remove.
13501 * Makefile.in (base_obj): Remove doprnt.o.
13502 * deps.mk (doprnt.o): Remove.
13503
5fdb398c
PE
13504 error: Print 32- and 64-bit integers portably (Bug#8435).
13505 Without this change, on typical 64-bit hosts error ("...%d...", N)
13506 was used to print both 32- and 64-bit integers N, which relied on
13507 undefined behavior.
61bdb816 13508 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13509 * lisp.h (error, verror): Mark as printf-like functions.
13510 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13511 Report overflow in size calculations when allocating printf buffer.
13512 Do not truncate output string at its first null byte.
13513 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13514 Truncate the output at a character boundary, since vsnprintf does not
13515 do that.
13516 * charset.c (check_iso_charset_parameter): Convert internal
13517 character to string before calling 'error', since %c now has the
13518 printf meaning.
13519 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13520 overflow when computing char to be passed to 'error'. Do not
13521 pass Lisp_Object to 'error'; pass the integer instead.
13522 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13523 formatted with plain %d.
13524
b189fa66
PE
13525 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13526
bff87ef0
PE
13527 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13528
7e2cac20
PE
13529 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13530
ce4d90b5
PE
13531 * xterm.c (x_catch_errors): Remove duplicate declaration.
13532
266c9547
PE
13533 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13534
79c49ad2
PE
13535 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13536
368f4090
JM
135372011-04-10 Jim Meyering <meyering@redhat.com>
13538
13539 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13540 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13541 return ssize_t not "int", and use size_t as the buffer length.
13542 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13543 * gnutls.h: Update declarations.
13544 * process.c (read_process_output): Use ssize_t, to match.
13545 (send_process): Likewise.
13546
a32d4040
CY
135472011-04-09 Chong Yidong <cyd@stupidchicken.com>
13548
13549 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13550
8546720e 135512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13552
04f2d78b
CB
13553 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13554 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13555
8546720e
GM
13556 * xterm.c (handle_one_xevent):
13557 * xmenu.c (create_and_show_popup_menu):
13558 * xselect.c (x_decline_selection_request)
13559 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13560
0a2f5c1a 135612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13562
13563 Fix some uses of `int' instead of EMACS_INT.
13564 * search.c (string_match_1, fast_string_match)
13565 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13566 (scan_buffer, find_next_newline_no_quit)
13567 (find_before_next_newline, search_command, Freplace_match)
13568 (Fmatch_data): Make some `int' variables be EMACS_INT.
13569
13570 * xdisp.c (display_count_lines): 3rd argument and return value now
13571 EMACS_INT. All callers changed.
13572 (pint2hrstr): Last argument is now EMACS_INT.
13573
13574 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13575 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13576 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13577 (decode_coding_utf_16, decode_coding_emacs_mule)
13578 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13579 (decode_coding_ccl, decode_coding_charset)
13580 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13581 (decode_coding_iso_2022, decode_coding_emacs_mule)
13582 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13583 <char_offset, last_offset>: Declare EMACS_INT.
13584 (encode_coding_utf_8, encode_coding_utf_16)
13585 (encode_coding_emacs_mule, encode_invocation_designation)
13586 (encode_designation_at_bol, encode_coding_iso_2022)
13587 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13588 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13589 Declare EMACS_INT.
13590 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13591 (encode_invocation_designation): Last argument P_NCHARS is now
13592 EMACS_INT.
13593 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13594 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13595
13596 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13597 All users changed.
13598
13599 * ccl.c (Fccl_execute_on_string): Declare some variables
13600 EMACS_INT.
13601
8546720e 136022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13603
13604 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13605
4e19a977
CS
136062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13607
13608 * process.c (Fformat_network_address): Doc fix.
13609
87302331
R
136102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13611
ee7683eb 13612 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13613
cbb59342
CY
136142011-04-08 Chong Yidong <cyd@stupidchicken.com>
13615
13616 * keyboard.c (read_char): Call Lisp function help-form-show,
13617 instead of using internal_with_output_to_temp_buffer.
13618 (Qhelp_form_show): New var.
e0d38eeb 13619 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13620
13621 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13622
13623 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13624
e67a13ab
CY
136252011-04-06 Chong Yidong <cyd@stupidchicken.com>
13626
04f2d78b
CB
13627 * process.c (Flist_processes): Remove to Lisp.
13628 (list_processes_1): Delete.
e67a13ab 13629
973f782d
EZ
136302011-04-06 Eli Zaretskii <eliz@gnu.org>
13631
7c106b1e
EZ
13632 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13633
973f782d
EZ
13634 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13635
41cf7d1a 136362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13637
ca23cc88
PE
13638 Fix more problems found by GCC 4.6.0's static checks.
13639
f390e2d5
PE
13640 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13641
42eea0d0
PE
13642 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13643
b69769da 13644 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13645
f9541e84
PE
13646 * xdisp.c (vmessage): Mark as a printf-like function.
13647
13841b55
PE
13648 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13649
c136c10f
PE
13650 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13651
5e2d4a30
PE
13652 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13653 printf-like functions.
13654 (tiff_load): Add casts to remove these marks before passing them
13655 to system-supplied API.
13656
583f48b9
PE
13657 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13658
b25d760e
PE
13659 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13660 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13661 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13662 directly, rather than having caller test rule sign. This avoids
13663 some unnecessary tests.
13664 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13665 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13666 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13667
bc7b6697 13668 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13669 (xfont_open): Avoid unnecessary tests.
bc7b6697 13670
27ccc379
PE
13671 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13672
dcd5c89a
PE
13673 * composite.h, composite.c (composition_gstring_put_cache):
13674 Use EMACS_INT, not int, for length.
13675
b13a45c6
PE
13676 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13677 breaking out part of COMPOSITION_DECODE_RULE.
13678 (COMPOSITION_DECODE_RULE): Use it.
13679 * composite.c (get_composition_id): Remove unused local vars,
13680 by using the new macro.
13681
1e792e4d
PE
13682 * textprop.c (set_text_properties_1): Change while to do-while,
13683 since the condition is always true at first.
13684
dc6c6455 13685 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13686 (interval_deletion_adjustment): Return unsigned value.
13687 All uses changed.
dc6c6455 13688
aba7731a
PE
13689 * process.c (list_processes_1, create_pty, read_process_output):
13690 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13691 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13692 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13693 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13694 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13695
fdfc4bf3
PE
13696 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13697
fca8fe46 13698 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13699 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13700
06a0259a 13701 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13702 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13703 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13704
e7b9e80f
PE
13705 * print.c (print_error_message): Avoid int overflow.
13706
56201685
PE
13707 * font.c (font_list_entities): Redo for clarity,
13708 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13709
78834453 13710 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13711 (font_score): Avoid potential overflow in diff calculation.
78834453 13712
0bc0b309 13713 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13714 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13715
e610eaca
PE
13716 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13717
b895abce
PE
13718 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13719 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13720 can always succeed if overflow has undefined behavior.
13721
1f1d9321 13722 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13723 (wordify): Omit three unnecessary tests.
1f1d9321 13724
c59478bc
PE
13725 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13726 All callers changed. This avoids the need for an unused var.
13727
79b73827
PE
13728 * casefiddle.c (casify_region): Remove var that is set but not used.
13729
a4db5dfe
PE
13730 * dired.c (file_name_completion): Remove var that is set but not used.
13731
43aae36e
PE
13732 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13733
2a47c44d 13734 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13735 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13736
a37c69bf
PE
13737 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13738 Check for integer overflow on size calculations.
13739
328ab8e7
PE
13740 * buffer.c (Fprevious_overlay_change): Remove var that is set
13741 but not used.
13742
e5a2a5cb
PE
13743 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13744 Remove vars that are set but not used.
8d84a6eb 13745 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13746 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13747
a60e5f68
PE
13748 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13749
f661cb61 13750 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13751 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13752
f0397f5a
PE
13753 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13754 that are set but not used.
13755
8664db06 13756 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13757 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13758
6abdaa4a
PE
13759 * xselect.c (x_get_local_selection, x_handle_property_notify):
13760 Remove vars that are set but not used.
13761
0ce7538d 13762 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13763 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13764
9ae848fc
PE
13765 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13766 Remove var that is set but not used.
0b918413
PE
13767 (scroll_bar_windows_size): Now size_t, not int.
13768 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13769 Check for overflow.
9ae848fc 13770
a5a62657
PE
13771 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13772 (map_tty_color) [!defined MSDOS]: Likewise.
13773
5c5cdd39
PE
13774 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13775
66ebf983
PE
13776 * coding.c: Remove vars that are set but not used.
13777 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13778 All callers changed.
13779 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13780 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13781 (decode_coding_charset): Remove vars that are set but not used.
13782
1be4d761
PE
13783 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13784 that is set but not used.
13785
47553fa8
PE
13786 * print.c (print_object): Remove var that is set but not used.
13787
1f7196bf 13788 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13789 The gnulib version avoids calling malloc in the usual case,
13790 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13791 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13792 * filelock.c (current_lock_owner): Likewise.
13793 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13794 * sysdep.c: Include allocator.h, careadlinkat.h.
13795 (emacs_no_realloc_allocator): New static constant.
13796 (emacs_readlink): New function.
fdb61804
PE
13797 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13798 ../lib/careadlinkat.h.
d1fdcab7 13799
f84c17c7
SM
138002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13801
13802 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13803 first non-nil return value).
13804
ef3862ad
JD
138052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13806
13807 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13808 if not defined (Bug#8403).
13809
376a7006
JB
138102011-04-02 Juanma Barranquero <lekktu@gmail.com>
13811
13812 * xdisp.c (display_count_lines): Remove parameter `start',
13813 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13814 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13815 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13816 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13817 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13818 and thereabouts. All callers changed.
13819 (get_per_char_metric): Remove parameter `f', unused since
13820 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13821
6ca3801d
JM
138222011-04-02 Jim Meyering <meyering@redhat.com>
13823
13824 do not dereference NULL upon failed strdup
13825 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13826 (ns_get_family): Likewise.
13827
d8e2b5ba
JB
138282011-04-02 Juanma Barranquero <lekktu@gmail.com>
13829
13830 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13831
8c74fcbd
JD
138322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13833
13834 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13835 later (Bug#8403).
13836
7200d79c
SM
138372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13838
03408648 13839 Add lexical binding.
7200d79c 13840
03408648
SM
13841 * window.c (Ftemp_output_buffer_show): New fun.
13842 (Fsave_window_excursion):
13843 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13844
13845 * lread.c (lisp_file_lexically_bound_p): New function.
13846 (Fload): Bind Qlexical_binding.
13847 (readevalloop): Remove `evalfun' arg.
13848 Bind Qinternal_interpreter_environment.
13849 (Feval_buffer): Bind Qlexical_binding.
13850 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13851 Mark as dynamic.
13852 (syms_of_lread): Declare `lexical-binding'.
13853
13854 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13855
13856 * keyboard.c (eval_dyn): New fun.
13857 (menu_item_eval_property): Use it.
ca105506
SM
13858
13859 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13860
03408648
SM
13861 * fns.c (concat, mapcar1): Accept byte-code-functions.
13862
13863 * eval.c (Fsetq): Handle lexical vars.
13864 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13865 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13866 (FletX, Flet): Obey lexical binding.
13867 (Fcommandp): Handle closures.
13868 (Feval): New `lexical' arg.
13869 (eval_sub): New function extracted from Feval. Use it almost
13870 everywhere where Feval was used. Look up vars in lexical env.
13871 Handle closures.
13872 (Ffunctionp): Move from subr.el.
13873 (Ffuncall): Handle closures.
13874 (apply_lambda): Remove `eval_flags'.
13875 (funcall_lambda): Handle closures and new byte-code-functions.
13876 (Fspecial_variable_p): New function.
13877 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13878 but without exporting it to Lisp.
23aba0ea 13879
23aba0ea 13880 * doc.c (Fdocumentation, store_function_docstring):
03408648 13881 * data.c (Finteractive_form): Handle closures.
23aba0ea 13882
03408648
SM
13883 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13884 interactive spec.
ba83908c 13885
04f2d78b
CB
13886 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13887 New byte-codes.
03408648
SM
13888 (exec_byte_code): New function extracted from Fbyte_code to handle new
13889 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13890
03408648 13891 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13892
03408648 13893 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13894
e2abce01
JB
138952011-03-31 Juanma Barranquero <lekktu@gmail.com>
13896
13897 * xdisp.c (redisplay_internal): Fix prototype.
13898
63696a73 138992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13900
63696a73 13901 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13902 (try_scrolling): Use it when setting scroll_limit.
13903 Limit scrolling to 100 screen lines.
63696a73
EZ
13904 (redisplay_window): Even when falling back on "recentering",
13905 position point in the window according to scroll-conservatively,
13906 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13907
13908 (try_scrolling): When point is above the window, allow searching
13909 as far as scroll_max, or one screenful, to compute vertical
13910 distance from PT to the scroll margin position. This prevents
13911 try_scrolling from unnecessarily failing when
13912 scroll-conservatively is set to a value slightly larger than the
13913 window height. Clean up the case of PT below the margin at bottom
13914 of window: scroll_max can no longer be INT_MAX. When aggressive
13915 scrolling is in use, don't let point enter the opposite scroll
13916 margin as result of the scroll.
13917 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13918 threshold of 100 lines for never-recentering scrolling.
13919
e4cc2dfc
JB
139202011-03-31 Juanma Barranquero <lekktu@gmail.com>
13921
13922 * dispextern.h (move_it_by_lines):
13923 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13924 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13925 (message_log_check_duplicate): Remove parameters `prev_bol' and
13926 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13927 (redisplay_internal): Remove parameter `preserve_echo_area',
13928 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13929
13930 * indent.c (Fvertical_motion):
13931 * window.c (window_scroll_pixel_based, Frecenter):
13932 Don't pass `need_y_p' to `move_it_by_lines'.
13933
1c470562
SM
139342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13935
44f230aa
SM
13936 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13937 steal a few bits to be more compact.
13938 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13939 Remove unneeded casts.
13940
1c470562
SM
13941 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13942
888adce9
ZK
139432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13944
13945 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13946 binding" message (bug#7967).
13947
f838ed7b
PE
139482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13949
77861b95
PE
13950 Fix more problems found by GCC 4.6.0's static checks.
13951
de6dbc14
PE
13952 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13953 Remove unused local var.
13954
f838ed7b
PE
13955 * editfns.c (Fmessage_box): Remove unused local var.
13956
792c7b2b
PE
13957 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13958 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13959 Omit unused local vars.
c499e557 13960 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13961 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13962 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13963 Omit unused local var.
13964
ba0165e1
PE
13965 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13966 Don't assume string length fits in int.
32ad8845 13967 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13968 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13969
3c59b4c9
PE
13970 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13971 instead of alloca (Bug#8344).
13972
a3eed478 13973 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13974 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13975
eb4d412d
PE
13976 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13977
1658b401
PE
13978 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13979 concerns.
13980
13981 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13982
13983 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13984
9a2c6e05
PE
13985 * keyboard.c (syms_of_keyboard): Use the same style as later
13986 in this function when indexing through an array. This also
13987 works around GCC bug 48267.
13988
03d0a109
PE
13989 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13990
44f730c8
PE
13991 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13992
fe75f926
PE
13993 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13994 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13995
ffa8c828
PE
13996 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13997 This avoids undefined behavior on integer overflow, and is a bit
13998 more convenient anyway since it is compared to a size_t variable.
13999
c5101a77
PE
14000 Variadic C functions now count arguments with size_t, not int.
14001 This avoids an unnecessary limitation on 64-bit machines, which
14002 caused (substring ...) to crash on large vectors (Bug#8344).
14003 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14004 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14005 All variadic functions and their callers changed accordingly.
c5101a77
PE
14006 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14007 * data.c (arith_driver, float_arith_driver): Likewise.
14008 * editfns.c (general_insert_function): Likewise.
14009 * eval.c (struct backtrace.nargs, interactive_p)
14010 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14011 (funcall_lambda, mark_backtrace): Likewise.
14012 * fns.c (concat): Likewise.
14013 * frame.c (x_set_frame_parameters): Likewise.
14014 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14015 0 if not found, not -1. All callers changed.
14016
dd3f25f7
PE
14017 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14018 (stack_copy_size): Now size_t, not int.
14019 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14020
461c2ab9
JB
140212011-03-28 Juanma Barranquero <lekktu@gmail.com>
14022
14023 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14024 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14025 All callers changed.
14026
14027 * lisp.h (multibyte_char_to_unibyte):
14028 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14029 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14030 * character.h (CHAR_TO_BYTE8):
14031 * cmds.c (internal_self_insert):
14032 * editfns.c (general_insert_function):
14033 * keymap.c (push_key_description):
14034 * search.c (Freplace_match):
14035 * xdisp.c (message_dolog, set_message_1): All callers changed.
14036
f6d62986
SM
140372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14038
14039 * keyboard.c (safe_run_hook_funcall): New function.
14040 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14041 don't set the hook to nil, but remove the offending function instead.
14042 (Qcommand_hook_internal): Remove, unused.
14043 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14044 Vcommand_hook_internal.
14045
14046 * eval.c (enum run_hooks_condition): Remove.
14047 (funcall_nil, funcall_not): New functions.
14048 (run_hook_with_args): Call each function through a `funcall' argument.
14049 Remove `cond' argument, now redundant.
14050 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14051 (Frun_hook_with_args_until_failure): Adjust accordingly.
14052 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14053
1db5b1ad
JB
140542011-03-28 Juanma Barranquero <lekktu@gmail.com>
14055
14056 * dispextern.h (string_buffer_position): Remove declaration.
14057
14058 * print.c (strout): Remove parameter `multibyte', unused since
14059 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14060
14061 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14062 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14063 All callers changed.
14064
14065 * w32.c (_wsa_errlist): Use braces for struct initializers.
14066
14067 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14068 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14069 All callers changed.
14070 (string_buffer_position): Likewise. Also, make static (it's never
14071 used outside xdisp.c).
14072 (cursor_row_p): Remove parameter `w', unused since
14073 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14074 (decode_mode_spec): Remove parameter `precision', introduced during
14075 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14076 All callers changed.
14077
5ffb62aa
JD
140782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14079
14080 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14081
461c2ab9 140822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14083
14084 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14085 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14086 (ns_update_auto_hide_menu_bar): New functions.
14087 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14088 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14089 ns_constrain_all_frames.
14090 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14091 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14092
5c380ffb
JD
140932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14094
14095 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14096
9af30bdf
GM
140972011-03-27 Glenn Morris <rgm@gnu.org>
14098
14099 * syssignal.h: Replace RETSIGTYPE with void.
14100 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14101 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14102 Replace SIGTYPE with void everywhere.
14103 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14104 * s/template.h (SIGTYPE): Remove commented out definition.
14105
e2abce01
JB
141062011-03-26 Eli Zaretskii <eliz@gnu.org>
14107
14108 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14109 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14110
f868cd8a
JB
141112011-03-26 Juanma Barranquero <lekktu@gmail.com>
14112
59eb0929
JB
14113 * w32.c (read_unc_volume): Use parameter `henum', instead of
14114 global variable `wget_enum_handle'.
14115
14116 * keymap.c (describe_vector): Remove parameters `indices' and
14117 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14118 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14119
f868cd8a
JB
14120 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14121
14122 * keyboard.c (timer_check): Remove parameter `do_it_now',
14123 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14124 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14125 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14126
14127 * keyboard.c (read_char):
14128 * w32menu.c (w32_menu_display_help):
14129 * xmenu.c (show_help_event, menu_help_callback):
14130 Adjust calls to `show_help_echo'.
14131
14132 * gtkutil.c (xg_maybe_add_timer):
14133 * keyboard.c (readable_events):
14134 * process.c (wait_reading_process_output):
14135 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14136
14137 * insdel.c (adjust_markers_gap_motion):
14138 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14139 (gap_left, gap_right): Don't call it.
14140
2ecf6fdb
CY
141412011-03-25 Chong Yidong <cyd@stupidchicken.com>
14142
14143 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14144 incurred during fontification.
14145
6b1f9ba4
JB
141462011-03-25 Juanma Barranquero <lekktu@gmail.com>
14147
14148 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14149 (DEFVAR_PER_BUFFER): Don't pass it.
14150
14151 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14152 (scrolling_window): Don't pass it.
14153
0f4a96b5
JB
141542011-03-25 Juanma Barranquero <lekktu@gmail.com>
14155
14156 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14157
14158 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14159 and `suffix'.
14160 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14161 of variables specific to SELinux and computation of `encoded_absname'.
14162
14163 * image.c (XPutPixel): Remove unused variable `height'.
14164
14165 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14166
14167 * unexw32.c (get_section_info): Remove unused variable `section'.
14168
14169 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14170 (system_process_attributes): Remove unused variable `sess'.
14171 (sys_read): Remove unused variable `err'.
14172
14173 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14174 (w32_wnd_proc): Remove unused variable `isdead'.
14175 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14176 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14177 (x_create_tip_frame): Remove unused variable `tem'.
14178
14179 * w32inevt.c (w32_console_read_socket):
14180 Remove unused variable `no_events'.
14181
14182 * w32term.c (x_draw_composite_glyph_string_foreground):
14183 Remove unused variable `width'.
14184
1149507c
JB
141852011-03-24 Juanma Barranquero <lekktu@gmail.com>
14186
14187 * w32term.c (x_set_glyph_string_clipping):
14188 Don't pass uninitialized region to CombineRgn.
14189
9c88f339
JB
141902011-03-23 Juanma Barranquero <lekktu@gmail.com>
14191
14192 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14193 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14194 (Fx_close_connection): Remove unused variable `i'.
14195
14196 * w32font.c (w32font_draw): Return number of glyphs.
14197 (w32font_open_internal): Remove unused variable `i'.
14198 (w32font_driver): Add missing initializer.
14199
14200 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14201 (fill_in_menu): Remove unused variable `items_added'.
14202
14203 * w32term.c (last_mouse_press_frame): Remove static global variable.
14204 (w32_clip_to_row): Remove unused variable `f'.
14205 (x_delete_terminal): Remove unused variable `i'.
14206
14207 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14208 (NOTHING): Remove unused static global variable.
14209 (uniscribe_check_otf): Remove unused variable `table'.
14210 (uniscribe_font_driver): Add missing initializers.
14211
dee091a3
JD
142122011-03-23 Julien Danjou <julien@danjou.info>
14213
14214 * term.c (Fsuspend_tty, Fresume_tty):
14215 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14216 * window.c (temp_output_buffer_show):
14217 * insdel.c (signal_before_change):
14218 * frame.c (Fhandle_switch_frame):
14219 * fileio.c (Fdo_auto_save):
14220 * emacs.c (Fkill_emacs):
14221 * editfns.c (save_excursion_restore):
14222 * cmds.c (internal_self_insert):
14223 * callint.c (Fcall_interactively):
14224 * buffer.c (Fkill_all_local_variables):
14225 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14226 Use Frun_hooks.
0f4a96b5 14227 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14228 unconditionally since it does the check itself.
dee091a3 14229
2c520ab5 142302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14231
c9c49752
PE
14232 Fix more problems found by GCC 4.5.2's static checks.
14233
8abc3f12
PE
14234 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14235 the first time through the loop, since we know p0 < p1 then.
14236 This also avoids a gcc -Wstrict-overflow warning.
14237
a2d26660
PE
14238 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14239 leading to a memory leak, possible in functions like
14240 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14241 of objects (Bug#8318).
a2d26660 14242
916c72e9
PE
14243 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14244 that could (at least in theory) be that large.
14245
19ab8a18
PE
14246 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14247 This is less likely to overflow, and avoids undefined behavior if
14248 overflow does occur. All callers changed. Use strtoul to scan
14249 for the unsigned long integer.
b7cbbd6f
PE
14250 (pint2hrstr): Simplify and tune code slightly.
14251 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14252
f0641eff
PE
14253 * scroll.c (do_scrolling): Work around GCC bug 48228.
14254 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14255
7f650bb9
PE
14256 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14257 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14258 (validate_x_resource_name): Simplify count usage.
14259 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14260
37dd57d1
PE
14261 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14262 fail (Bug#8306).
81e56e61 14263
699979fc 14264 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14265
401bf9b4
PE
14266 * process.c (Fmake_network_process): Use socklen_t, not int,
14267 where POSIX says socklen_t is required in portable programs.
14268 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14269 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14270 (Fmake_network_process, server_accept_connection):
14271 (wait_reading_process_output, read_process_output):
14272 Likewise.
14273
b93aacde
PE
14274 * process.c: Rename or move locals to avoid shadowing.
14275 (list_processes_1, Fmake_network_process):
14276 (read_process_output_error_handler, exec_sentinel_error_handler):
14277 Rename or move locals.
4dc343ee 14278 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14279 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14280 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14281 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14282 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14283
af8a867c 14284 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14285 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14286 Include tparam.h instead, since it declares them.
af8a867c
PE
14287 * cm.h (PC): Remove extern decl; tparam.h now does this.
14288 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14289 * terminfo.c: Include tparam.h, to check interfaces.
14290 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14291 (tparam): Adjust signature to match interface in tparam.h;
14292 this removes some undefined behavior. Check that outstring and len
14293 are zero, which they always are with Emacs.
14294 * tparam.h (PC, BC, UP): New extern decls.
14295
0248044d 14296 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14297 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14298
8ff096c1 14299 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14300 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14301 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14302 (ftfont_list): Remove unused local.
49eaafba
PE
14303 (get_adstyle_property, ftfont_pattern_entity):
14304 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14305 Rename locals to avoid shadowing.
8ff096c1 14306
e2be39f6
PE
14307 * xfont.c (xfont_list_family): Mark var as initialized.
14308
c9735e30
PE
14309 * xml.c (make_dom): Now static.
14310
8f5201ae
PE
14311 * composite.c (composition_compute_stop_pos): Rename local to
14312 avoid shadowing.
b246f932
PE
14313 (composition_reseat_it): Remove unused locals.
14314 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14315 (composition_update_it): Mark var as initialized.
11b61122
PE
14316 (find_automatic_composition): Mark vars as initialized,
14317 with a FIXME (Bug#8290).
8f5201ae 14318
760fbc2c
PE
14319 character.h: Rename locals to avoid shadowing.
14320 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14321 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14322 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14323 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14324 to avoid shadowing.
14325
ff08eb85
PE
14326 * textprop.c (property_change_between_p): Remove; unused.
14327
fc7bf025
PE
14328 * intervals.c (interval_start_pos): Now static.
14329
235d7abc
PE
14330 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14331
44f230aa
SM
14332 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14333 Rename locals to avoid shadowing.
3e7d6594 14334
50060332
PE
14335 * sound.c (wav_play, au_play, Fplay_sound_internal):
14336 Fix pointer signedness.
d01f234b 14337 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14338 (wav_play): Initialize a variable to 0, to prevent undefined
14339 behavior (Bug#8278).
50060332 14340
c4fc4e30
PE
14341 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14342
918436ed
PE
14343 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14344
c939f91b
PE
14345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14346 clobbering (Bug#8298).
b9c7f648
PE
14347 * sysdep.c (sys_subshell): Likewise.
14348 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14349
6bd8c144
PE
14350 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14351 This should get cleaned up, so that child_setup has the
14352 same signature on all platforms.
14353
7710357c 14354 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14355 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14356
c59da222
CY
143572011-03-22 Chong Yidong <cyd@stupidchicken.com>
14358
14359 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14360 not to be necessary, and produces flickering.
14361
66b87493
GM
143622011-03-20 Glenn Morris <rgm@gnu.org>
14363
14364 * config.in: Remove file.
14365
45b6f6d5
JB
143662011-03-20 Juanma Barranquero <lekktu@gmail.com>
14367
14368 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14369 are now in src/globals.h.
14370 (syms_of_minibuf): Remove spurious & from previous change.
14371
cd394be1 143722011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14373
14374 * minibuf.c (completing-read-function): New variable.
14375 (completing-read-default): Rename from completing-read.
14376 (completing-read): Call completing-read-function.
14377
b14e3e21
CY
143782011-03-19 Juanma Barranquero <lekktu@gmail.com>
14379
14380 * xfaces.c (Fx_load_color_file):
14381 Read color file from absolute filename (bug#8250).
14382
f2b726e6
JB
143832011-03-19 Juanma Barranquero <lekktu@gmail.com>
14384
14385 * makefile.w32-in: Update dependencies.
14386
09f6ff02
EZ
143872011-03-17 Eli Zaretskii <eliz@gnu.org>
14388
14389 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14390
29a6015a
PE
143912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14392
a3a6c54e
PE
14393 Fix more problems found by GCC 4.5.2's static checks.
14394
b766f867
PE
14395 * process.c (make_serial_process_unwind, send_process_trap):
14396 (sigchld_handler): Now static.
14397
be02381c
PE
14398 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14399 That way, the code declares only the vars that it needs.
14400 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14401 * s/cygwin.h (PTY_ITERATION): Likewise.
14402 * s/darwin.h (PTY_ITERATION): Likewise.
14403 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14404
57048744
PE
14405 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14406 * process.c (allocate_pty): Don't declare stb unless it's needed.
14407
7914961c 14408 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14409 (CONSTANTLIM): Remove; unused.
14410 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14411 Define only if needed.
7914961c 14412
b3967b18
PE
14413 * unexelf.c (unexec): Name an expression,
14414 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14415 Use a different way to cause a compilation error if anyone uses
14416 n rather than nn, a way that does not involve shadowing.
73366a00 14417 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14418
29a6015a
PE
14419 * deps.mk (unexalpha.o): Remove; unused.
14420
43cfc33e 14421 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14422 * unexec.h: New file.
ce701a33
PE
14423 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14424 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14425 Depend on unexec.h.
14426 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14427 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14428 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14429 Change as necessary to match prototype in unexec.h.
ce701a33 14430
01f44d5a
PE
14431 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14432 shadowing.
4f63c6bb 14433 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14434
a6670b0b
PE
14435 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14436 Rename locals to avoid shadowing.
14437
cef2010d 14438 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14439 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14440
d4d7173a
PE
14441 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14442
f08b802a
PE
14443 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14444 warning when compiling print.c.
14445
3ddb0639
PE
14446 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14447 instead of using an uninitialized var.
5ad03b97 14448 (font_sort_entities): Mark var as initialized.
3ddb0639 14449
170a2692
PE
14450 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14451
e663c700
PE
14452 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14453 pointers to constants.
89bc529a 14454 (font_parse_fcname): Remove unused vars.
7b81e2d0 14455 (font_delete_unmatched): Now static.
ea838e10 14456 (font_get_spec): Remove; unused.
13a547c6
PE
14457 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14458 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14459 Rename or move locals to avoid shadowing.
e663c700 14460
2a80c887 14461 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14462 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14463
1384fa33 14464 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14465 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14466
8b2c52e9
PE
14467 * alloc.c (mark_backtrace): Move decl from here ...
14468 * lisp.h: ... to here, so that it can be checked.
14469
475545b5 14470 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14471 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14472 (lisp_indirect_variable): Name an expression,
14473 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14474 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14475
b1349114 14476 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14477 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14478 Use const pointer when appropriate.
b1349114 14479
a2928364
PE
14480 * lisp.h (get_system_name, get_operating_system_release):
14481 Move decls here, to check interfaces.
14482 * process.c (get_operating_system_release): Move decl to lisp.h.
14483 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14484 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14485 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14486 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14487 (Fformat_time_string, Fencode_time, Finsert_char):
14488 (Ftranslate_region_internal, Fformat):
14489 Rename or remove local vars to avoid shadowing.
9710023e 14490 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14491
a415e694
PE
14492 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14493 avoid shadowing.
14494
8ef4622d
PE
14495 * lisp.h (eassert): Check that the argument compiles, even if
14496 ENABLE_CHECKING is not defined.
14497
946f9a5b
PE
14498 * data.c (Findirect_variable): Name an expression, to avoid
14499 gcc -Wbad-function-cast warning.
112396d6 14500 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14501 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14502 (Fmake_variable_buffer_local, Fmake_local_variable):
14503 Mark variables as initialized.
52746918 14504 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14505
e5aab7e7 14506 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14507 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14508 Rename locals to avoid shadowing.
dff45157
PE
14509 (mark_stack): Move local variables into the #ifdef region where
14510 they're used.
7bc26fdb
PE
14511 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14512 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14513 needed otherwise.
14514 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14515 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14516 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14517
e5aab7e7
PE
14518 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14519 avoids undefined behavior in theory.
14520
4da60324
PE
14521 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14522
88043301
PE
14523 Use functions, not macros, for up- and down-casing (Bug#8254).
14524 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14525 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14526 to use the following functions instead of these macros.
14527 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14528 EMACS_INT, since callers assume the returned value fits in int.
14529 (upcase1): Likewise, for UPCASE_TABLE.
14530 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14531 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14532 the race-condition problem in the old DOWNCASE.
88043301 14533
19ed5445
PE
14534 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14535 Rename locals to avoid shadowing.
14536 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14537 (regex_compile, re_search_2, re_match_2_internal):
14538 Remove unused local vars.
952db0d7
PE
14539 (FREE_VAR): Rewrite so as not to use empty "else",
14540 which gcc can warn about.
da053e48 14541 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14542 (RETALLOC_IF): Define only if needed.
14543 (WORDCHAR_P): Likewise. This one is never needed, but is used
14544 only in a comment talking about a compiler bug, so put inside
14545 the #if 0 of that comment.
14546 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14547 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14548 Remove; unused.
19ed5445 14549
1f3561e4 14550 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14551 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14552 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14553
ded6f8f7
PE
14554 * search.c (simple_search): Remove unused var.
14555
dbd37a95
PE
14556 * dired.c (compile_pattern): Move decl from here ...
14557 * lisp.h: ... to here, so that it can be checked.
14558 (struct re_registers): New forward decl.
14559
7e47afad
PE
14560 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14561
85f24f61
PE
14562 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14563 All uses changed.
14564 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14565 Rename locals to avoid shadowing.
5671df8f 14566 (Fvertical_motion): Mark locals as initialized.
85f24f61 14567
181aa2be 14568 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14569 (casify_region): Mark local as initialized.
181aa2be 14570
930d429c
PE
14571 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14572
7082eac6
PE
14573 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14574 New macros, so that the caller can use some names other than
14575 gcpro1, gcpro2, etc.
14576 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14577 of the new macros.
14578 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14579 argument, for consistency with GCPRO2_VAR, etc: it is now the
14580 prefix of the variable, not the variable itself. All uses
14581 changed.
38b2c076
PE
14582 * dired.c (directory_files_internal, file_name_completion):
14583 Rename locals to avoid shadowing.
14584
15206ed9
PE
14585 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14586 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14587 dired.c's scmp function, had undefined behavior.
14588 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14589 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14590 * buffer.h: ... to here, because these macros use current_buffer,
14591 and the new implementation with inline functions needs to have
14592 current_buffer in scope now, rather than later when the macros
14593 are used.
14594 (downcase, upcase1): New static inline functions.
14595 (DOWNCASE, UPCASE1): Reimplement using these functions.
14596 This avoids undefined behavior in expressions like
14597 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14598 from race conditions in accessing the global variables
14599 case_temp1 and case_temp2.
14600 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14601 * lisp.h (case_temp1, case_temp2): Remove their decls.
14602 * character.h (ASCII_CHAR_P): Move from here ...
14603 * lisp.h: ... to here, so that the inline functions mentioned
14604 above can use them.
14605
4a6bea26
PE
14606 * dired.c (directory_files_internal_unwind): Now static.
14607
f14b7e14
PE
14608 * fileio.c (file_name_as_directory, directory_file_name):
14609 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14610 Now static.
2893f146
PE
14611 (file_name_as_directory): Use const pointers when appropriate.
14612 (Fexpand_file_name): Likewise. In particular, newdir might
14613 point at constant storage, so make it a const pointer.
fd4ead52 14614 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14615 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14616 signedness issues.
f839df0c
PE
14617 (Fset_file_times, Finsert_file_contents, auto_save_error):
14618 Rename locals to avoid shadowing.
f14b7e14 14619
5716756e 14620 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14621 (Ftry_completion, Fall_completions): Rename or remove locals
14622 to avoid shadowing.
5716756e 14623
b4c3046a
PE
14624 * marker.c (bytepos_to_charpos): Remove; unused.
14625
b45db522
PE
14626 * lisp.h (verify_bytepos, count_markers): New decls,
14627 so that gcc does not warn that these functions aren't declared.
14628
85876d07
PE
14629 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14630 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14631 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14632 (copy_text): Remove unused local var.
85876d07 14633
03d78a21 14634 * filelock.c (within_one_second): Now static.
b3dd38ab 14635 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14636
5df8f01b
PE
14637 * buffer.c (fix_overlays_before): Mark locals as initialized.
14638 (fix_start_end_in_overlays): Likewise. This function should be
14639 simplified by using pointers-to-pointers, but that's a different
14640 matter.
b1d876f1 14641 (switch_to_buffer_1): Now static.
8f54f30a
PE
14642 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14643 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14644
a70072c9 14645 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14646 Fix pointer signedness issue.
edced198
PE
14647 (sys_subshell): Mark local as volatile if checking for lint,
14648 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14649 (MAXPATHLEN): Define only if needed.
a70072c9 14650
a0977c44
PE
14651 * process.c (serial_open, serial_configure): Move decls from here ...
14652 * systty.h: ... to here, so that they can be checked.
14653
a884fdcc
PE
14654 * fns.c (get_random, seed_random): Move extern decls from here ...
14655 * lisp.h: ... to here, so that they can be checked.
14656
604efe86 14657 * sysdep.c (reset_io): Now static.
b8950c94 14658 (wait_for_termination_signal): Remove; unused.
604efe86 14659
38fc62d9
PE
14660 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14661 (copy_keymap_item, append_key, push_text_char_description):
14662 Now static.
1004a21a 14663 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14664 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14665 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14666 (describe_map_tree):
14667 Rename locals to avoid shadowing.
38fc62d9 14668
2f2650da
PE
14669 * keyboard.c: Declare functions static if they are not used elsewhere.
14670 (echo_char, echo_dash, cmd_error, top_level_2):
14671 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14672 (read_char, kbd_buffer_get_event, make_lispy_position):
14673 (make_lispy_event, make_lispy_movement, apply_modifiers):
14674 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14675 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14676 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14677 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14678 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14679
a053e86c 14680 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14681 (mark_kboards): Move decl here ...
14682 * alloc.c (mark_kboards): ... from here.
a053e86c 14683
4752793e
PE
14684 * lisp.h (force_auto_save_soon): New decl.
14685
74f10ca7 14686 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14687 (DEFINE_DUMMY_FUNCTION): New macro.
14688 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14689 Use it.
c03cd23f
PE
14690 (main): Add casts to avoid warnings
14691 if GCC considers string literals to be constants.
74f10ca7 14692
022e70d4
PE
14693 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14694
59d6fe83
PE
14695 * dbusbind.c: Pointer signedness fixes.
14696 (xd_signature, xd_append_arg, xd_initialize):
14697 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14698 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14699 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14700 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14701
78320123
PE
14702 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14703 if GCC considers string literals to be constants.
49cebcca 14704 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14705
35ac2a97
SM
147062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14707
fb103ca9
SM
14708 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14709 (print_preprocess, print_object): New macro to fix last change.
14710
35ac2a97
SM
14711 * print.c (print_preprocess): Don't forget font objects.
14712
62973b41
JB
147132011-03-16 Juanma Barranquero <lekktu@gmail.com>
14714
14715 * emacs.c (USAGE3): Doc fixes.
14716
0e48bb22
AS
147172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14718
14719 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14720 structure.
14721
7684e57b
JB
147222011-03-14 Juanma Barranquero <lekktu@gmail.com>
14723
14724 * lisp.h (VWindow_system, Qfile_name_history):
14725 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14726 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14727 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14728
14729 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14730 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14731
14732 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14733 * w32console.c (detect_input_pending, read_input_pending)
14734 (encode_terminal_code):
14735 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14736 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14737 (w32_system_caret_y, Qfile_name_history):
14738 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14739 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14740 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14741 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14742 * w32proc.c (Qlocal, report_file_error):
14743 * w32term.c (Vwindow_system, updating_frame):
14744 * w32uniscribe.c (initialized, uniscribe_font_driver):
14745 Remove unneeded extern declarations.
14746
2aa46d6c
CY
147472011-03-14 Chong Yidong <cyd@stupidchicken.com>
14748
c96bbc66 14749 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14750
cffc6f3b
CY
147512011-03-13 Chong Yidong <cyd@stupidchicken.com>
14752
14753 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14754 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14755 These macros can no longer be used for assignment.
14756
44f230aa
SM
14757 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14758 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14759 (record_buffer_markers, fetch_buffer_markers): New functions for
14760 recording and fetching special buffer markers.
14761 (set_buffer_internal_1, set_buffer_temp): Use them.
14762
14763 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14764
14765 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14766
14767 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14768 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14769
14770 * xdisp.c (hscroll_window_tree):
14771 (reconsider_clip_changes): Use PT instead of BUF_PT.
14772
d251f04b
EZ
147732011-03-13 Eli Zaretskii <eliz@gnu.org>
14774
14775 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14776 $(EMACS_ROOT)/lib/intprops.h.
14777
f0c77cd1
PE
147782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14779
3eca4629
PE
14780 Fix more problems found by GCC 4.5.2's static checks.
14781
7c86ee98
PE
14782 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14783 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14784 (xg_free_frame_widgets): Make it clear that a local variable is
14785 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14786 (gdk_window_get_screen): Make it clear that this macro is needed
14787 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14788 (int_gtk_range_get_value): New function, which avoids a diagnostic
14789 from gcc -Wbad-function-cast.
14790 (xg_set_toolkit_scroll_bar_thumb): Use it.
14791 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14792 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14793 (get_utf8_string, xg_get_file_with_chooser):
14794 Rename locals to avoid shadowing.
14795 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14796
41729b81
PE
14797 * xgselect.c (xg_select): Remove unused var.
14798
f0c77cd1
PE
14799 * image.c (four_corners_best): Mark locals as initialized.
14800 (gif_load): Initialize transparent_p to zero (Bug#8238).
14801 Mark another local as initialized.
ec6cf4c6 14802 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14803
ce0ad53d 14804 * image.c (clear_image_cache): Now static.
d5d5a617 14805 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14806 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14807 (x_edge_detection): Remove unnecessary cast that
14808 gcc -Wbad-function-cast diagnoses.
2037898d 14809 (gif_load): Fix pointer signedness.
6ae141d6
PE
14810 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14811 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14812
33383987 148132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14814
d32df629
PE
14815 Improve quality of tests for time stamp overflow.
14816 For example, without this patch (encode-time 0 0 0 1 1
14817 1152921504606846976) returns the obviously-bogus value (-948597
14818 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14819 reports time overflow. See
14820 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14821 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14822 * editfns.c: Include limits.h and intprops.h.
14823 (TIME_T_MIN, TIME_T_MAX): New macros.
14824 (time_overflow): Move earlier, to before first use.
14825 (hi_time, lo_time): New functions, for an accurate test for
14826 out-of-range times.
14827 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14828 (Fget_internal_run_time): Don't assume time_t fits in int.
14829 (make_time): Use list2 instead of Fcons twice.
14830 (Fdecode_time): More accurate test for out-of-range times.
14831 (check_tm_member): New function.
14832 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14833 (lisp_time_argument): Don't rely on undefined left-shift and
14834 right-shift behavior when checking for time stamp overflow.
8be6f318 14835
fe31d94c
PE
14836 * editfns.c (time_overflow): New function, refactoring common code.
14837 (Fformat_time_string, Fdecode_time, Fencode_time):
14838 (Fcurrent_time_string): Use it.
14839
8be6f318
PE
14840 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14841 * dired.c (make_time): Move to ...
14842 * editfns.c (make_time): ... here.
14843 * systime.h: Note the move.
14844
09d9db2c 148452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14846
126bc0dc
YM
14847 * fringe.c (update_window_fringes): Remove unused variables.
14848
c47cbdfd
YM
14849 * unexmacosx.c (copy_data_segment): Also copy __got section.
14850 (Bug#8223)
14851
7ac80be9
EZ
148522011-03-12 Eli Zaretskii <eliz@gnu.org>
14853
c96bbc66 14854 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14855 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14856 Constify `char *' arguments and their references according to
14857 prototypes in tparam.h.
14858
ecb0f94d 14859 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14860
7ac80be9
EZ
14861 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14862 Adapt all references accordingly.
14863
14864 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14865
ef1fd07e
TT
148662011-03-11 Tom Tromey <tromey@redhat.com>
14867
14868 * buffer.c (syms_of_buffer): Remove obsolete comment.
14869
7ef4b50c
EZ
148702011-03-11 Eli Zaretskii <eliz@gnu.org>
14871
14872 * termhooks.h (encode_terminal_code): Declare prototype.
14873
14874 * msdos.c (encode_terminal_code): Don't declare prototype.
14875
14876 * term.c (encode_terminal_code): Now external again, used by
14877 w32console.c and msdos.c.
14878
44f230aa
SM
14879 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14880 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14881
4b1ec863 148822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14883
1714f52b 14884 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14885
4b1ec863
PE
14886 * fringe.c (update_window_fringes): Mark locals as initialized
14887 (Bug#8227).
14888 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14889
524c7aa6
PE
14890 * alloc.c (mark_fringe_data): Move decl from here ...
14891 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14892 to check its interface.
14893 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14894
a5c0af81 14895 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14896 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14897 (fontset_font): Mark local as initialized.
a9a06e0b 14898 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14899
b4716021
PE
14900 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14901
811e9bac 14902 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14903 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14904 (x_own_selection, Fx_disown_selection_internal): Rename locals
14905 to avoid shadowing.
14906 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14907
7e3ab302
PE
14908 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14909 so that the caller can use some name other than gcpro1.
14910 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14911 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14912 (Fx_backspace_delete_keys_p):
14913 Use them to avoid shadowing, and rename vars to avoid shadowing.
14914 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14915 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14916 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14917 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14918 Remove unused locals.
7e3ab302
PE
14919 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14920 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14921 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14922 macros.
f78faa98 14923
e2b13473
PE
14924 * xterm.h (x_mouse_leave): New decl.
14925
77f23912
PE
14926 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14927 Remove unused functions.
cdf4ba58
PE
14928 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14929 (x_calc_absolute_position): Now static.
7411c686 14930 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14931 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14932 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14933 unless they are used.
38d0b34a
PE
14934 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14935 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14936 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14937 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14938 (x_error_catcher, x_connection_closed, x_error_handler):
14939 (x_error_quitter, xembed_send_message, x_iconify_frame):
14940 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14941 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14942 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14943
44f230aa
SM
14944 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14945 Rename or move locals to avoid shadowing.
6b463e58 14946 (tty_defined_color, merge_face_heights): Now static.
5967d051 14947 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14948 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14949 does not deduce is never used uninitialized.
73719eba
PE
14950 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14951 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14952
426994c3 14953 * terminal.c (store_terminal_param): Now static.
5489860b 14954
032f1620 14955 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14956 (set_frame_menubar): Remove unused local.
d4323972 14957 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14958 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14959 since they might point to immutable storage.
281585b0
PE
14960 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14961 since it's unused otherwise.
032f1620 14962
367c19e5 14963 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14964 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14965 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14966 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14967 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14968 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14969 does not deduce are never used uninitialized.
70739cbe 14970
07b48fa9
PE
14971 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14972
8868a238 14973 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14974 * window.c (window_loop, size_window):
14975 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14976
7e5cf297 14977 * window.c (display_buffer): Now static.
d6550a9f
PE
14978 (size_window): Mark variables that gcc -Wuninitialized
14979 does not deduce are never used uninitialized.
a586633d
PE
14980 * window.h (check_all_windows): New decl, to forestall
14981 gcc -Wmissing-prototypes diagnostic.
5b555da1 14982 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14983
f6095868
PE
14984 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14985 shadowing.
14986 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14987 Include <limits.h>.
14988 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14989 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14990 (load_charset_map): Mark variables that gcc -Wuninitialized
14991 does not deduce are never used uninitialized.
53df7c11 14992 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14993
f38b440c
PE
14994 * coding.c (coding_set_source, coding_set_destination):
14995 Use "else { /* comment */ }" rather than "else /* comment */;"
14996 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14997 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14998 a block, when the outer 'i' will do.
14999 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15000 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15001 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15002 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15003 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15004 Rename locals to avoid shadowing.
15005 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15006 * coding.c (emacs_mule_char, encode_invocation_designation):
15007 Now static, since they're not used elsewhere.
413bb2db 15008 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15009 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15010 (decode_coding_emacs_mule): Mark variables that gcc
15011 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15012 (detect_coding_iso_2022): Initialize a local variable that might
15013 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15014 this initialization is needed. (Bug#8211)
5f58e762
PE
15015 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15016 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15017 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15018 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15019 Remove unused macros.
f38b440c 15020
232b38b9 15021 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15022 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15023 * character.c (string_count_byte8): Likewise.
232b38b9 15024
fb90da1b
PE
15025 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15026 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15027
fb93dbc2
PE
15028 * chartab.c (copy_sub_char_table): Now static, since it's not used
15029 elsewhere.
5c156ace
PE
15030 (sub_char_table_ref_and_range, char_table_ref_and_range):
15031 Rename locals to avoid shadowing.
bbcd0949 15032 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15033
7d3b3862 15034 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15035 (BIDI_BOB): Remove unused macro.
7d3b3862 15036
6be7d3da
PE
15037 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15038 deduce are never used uninitialized.
c2ed9c8b 15039 * term.c (encode_terminal_code): Likewise.
6be7d3da 15040
75f8807f 15041 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15042
50938595
PE
15043 * tparam.h: New file.
15044 * term.c, tparam.h: Include it.
15045 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15046 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15047 Move these decls to tparam.h, and make them agree with what
15048 is actually in tparam.c. The previous trick of using incompatible
15049 decls in different modules does not conform to the C standard.
15050 All callers of tparam changed to use tparam's actual API.
15051 * tparam.c (tparam1, tparam, tgoto):
15052 Use const pointers where appropriate.
15053
fbceeba2
PE
15054 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15055 * cm.h (struct cm): Likewise.
15056 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15057 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15058 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15059 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15060 (turn_on_face, init_tty): Likewise.
15061 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15062
7f3f1250
PE
15063 * term.c (term_mouse_position): Rename local to avoid shadowing.
15064
e6ca6543
PE
15065 * alloc.c (mark_ttys): Move decl from here ...
15066 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15067
c40f8d15
AS
150682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15069
15070 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15071
cfe0661d
JB
150722011-03-09 Juanma Barranquero <lekktu@gmail.com>
15073
15074 * search.c (compile_pattern_1): Remove argument regp, unused since
15075 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15076 (compile_pattern): Don't pass it.
15077
0afb4571
J
150782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15079
15080 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15081 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15082 for ! HAVE_GTK3.
15083 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15084
15085 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15086
15087 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15088 gdk_window_get_screen, gdk_window_get_geometry,
15089 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15090 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15091 (xg_get_pixbuf_from_pixmap): New function.
15092 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15093 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15094 Call xg_get_pixbuf_from_pixmap instead of
15095 gdk_pixbuf_get_from_drawable.
15096 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15097 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15098 (xg_check_special_colors): Use GtkStyleContext and its functions
15099 for HAVE_GTK3.
15100 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15101 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15102 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15103 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15104 Call gtk_widget_get_preferred_size.
0afb4571
J
15105 (xg_frame_resized): gdk_window_get_geometry only takes 5
15106 parameters.
44f230aa
SM
15107 (xg_win_to_widget, xg_event_is_for_menubar):
15108 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15109 (xg_set_widget_bg): New function.
15110 (delete_cb): New function.
895009e1 15111 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15112 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15113 (xg_set_background_color): Call xg_set_widget_bg.
15114 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15115 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15116 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15117 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15118 if ! HAVE_GTK3.
15119 (update_frame_tool_bar): Call gtk_widget_hide.
15120 (xg_initialize): Use GDK_KEY_g.
15121
15122 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15123 if ! HAVE_GTK3
15124 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15125
15126 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15127 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15128 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15129
1c2cc4ef
JB
151302011-03-08 Juanma Barranquero <lekktu@gmail.com>
15131
15132 * w32xfns.c (select_palette): Check success of RealizePalette against
15133 GDI_ERROR, not zero.
15134
33383987 15135See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15136
15137;; Local Variables:
15138;; coding: utf-8
aac0c6e3
MR
15139;; End:
15140
2f097256 15141 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15142
15143 This file is part of GNU Emacs.
15144
15145 GNU Emacs is free software: you can redistribute it and/or modify
15146 it under the terms of the GNU General Public License as published by
15147 the Free Software Foundation, either version 3 of the License, or
15148 (at your option) any later version.
15149
15150 GNU Emacs is distributed in the hope that it will be useful,
15151 but WITHOUT ANY WARRANTY; without even the implied warranty of
15152 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15153 GNU General Public License for more details.
15154
15155 You should have received a copy of the GNU General Public License
15156 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.