* src/lread.c (syms_of_lread): Initialize Vlexical_binding.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
14ae4239
BT
12012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2
3 * lread.c (syms_of_lread): Initialize Vlexical_binding.
4
32bcadb4
JD
52012-08-11 Jan Djärv <jan.h.d@swipnet.se>
6
3d29b2ce
JD
7 * nsterm.m (not_in_argv): New function.
8 (application:openFile, application:openTempFile:):
9 (application:openFileWithoutUI:, application:openFiles:): Open file
10 if not_in_argv returns non-zero (bug#12171).
11
32bcadb4 12 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
13 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
14 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
15 (xg_get_font_name): Use those functions/macros here.
16 Reported by Frans Oilinki <moilinki@gmail.com>.
17
9ff9402d 182012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
19
20 * unexmacosx.c (copy_data_segment): Copy initialized data in
21 statically linked libraries from input file rather than memory.
22
db74a5fc
YM
23 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
24 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
25 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
26
25e65510
GM
272012-08-10 Glenn Morris <rgm@gnu.org>
28
29 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
30 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
31
7961135c
DA
322012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
33
34 Fix last change to allow compilation with low optimization levels.
35 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
36 Reported by Jan Djärv <jan.h.d@swipnet.se>.
37
42b3a444
DA
382012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Use common inline syntax in intervals.h.
41 * intervals.h (INTERVALS_INLINE): New macro.
42 Change all users from LISP_INLINE.
43
9fb0c957
DA
442012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
45
46 Define Qnone once for all platforms.
47 * frame.c (Qnone): Define here.
48 (syms_of_frame): DEFSYM it.
49 * lisp.h (Qnone): New declaration.
50 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
51 * xfns.c: Remove duplication. Adjust users.
52
65e8ee52
DA
532012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Remove unused macros from intervals.h.
56 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
57 * intervals.c: Adjust comment.
58
9b855fd6
EZ
592012-08-10 Eli Zaretskii <eliz@gnu.org>
60
61 * w32fns.c <w32_unicode_gui>: New static variable.
62 (globals_of_w32fns): Initialize it according to os_subtype.
63 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
64 testing os_subtype.
65
39cb9e56 662012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
67 Eli Zaretskii <eliz@gnu.org>
68
69 Fix bug #10299 with Unicode characters sent by customized
70 keyboards created by MSKLC.
71 * w32fns.c (INIT_WINDOW_CLASS): New macro.
72 (w32_init_class): Use it to initialize the Emacs class with either
73 ANSI or Unicode API calls.
74 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
75 later.
76 (w32_wnd_proc): If the character code sent by WM_CHAR or
77 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
78 original message. Call DefWindowProcW on NT and later.
79
9374581a
GM
802012-08-10 Glenn Morris <rgm@gnu.org>
81
4b94e8cf
GM
82 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
83
9374581a
GM
84 * lisp.h (DIRECTORY_SEP): Let configure set it.
85
a2752828
DA
862012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Use TSET for write access to Lisp_Object slots of struct terminal.
89 * termhooks.h (TSET): New macro.
90 * coding.c, terminal.c, xselect.c: Adjust users.
91
cc92c454
SM
922012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
93
94 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
95 the failing expression, include them in the error message.
96 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
97 * lisp.h (internal_condition_case_n): Update declaration.
98
4cb3e6b3
DA
992012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
100
101 Inline functions to examine and change buffer overlays.
102 * buffer.c (unchain_both): New function.
103 * buffer.h (buffer_get_overlays, buffer_set_overlays):
104 (buffer_has_overlays): New function.
105 (enum overlay_type): New enum.
106 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
107 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
108
8707c1e5
DA
1092012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Inline functions to examine and change buffer intervals.
112 * alloc.c (mark_interval_tree): Remove.
113 (MARK_INTERVAL_TREE): Simplify.
114 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
115 * intervals.c (buffer_balance_intervals): New function.
116 (graft_intervals_into_buffer): Adjust indentation.
117 (set_intervals_multibyte): Simplify.
118 * buffer.h (BUF_INTERVALS): Remove.
119 (buffer_get_intervals, buffer_set_intervals): New function.
120 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
121 * intervals.c, textprop.c: Adjust users.
122
ad8c997f
DA
1232012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Inline functions to examine and change string intervals.
126 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
127 (string_get_intervals, string_set_intervals): New function.
128 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
129 * lread.c, print.c, textprop.c: Adjust users.
130
32ac3a6b
GM
1312012-08-08 Glenn Morris <rgm@gnu.org>
132
133 * lisp.mk (lisp): Remove language/persian.elc.
134
77c7bcb1
DA
1352012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
136
137 Cleanup intervals.
138 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
139 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
140 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
141 Adjust comment. Move under #if 0.
77c7bcb1
DA
142 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
143 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
144
9c08a8d4
DA
1452012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Check total length of intervals with eassert.
148 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
149 * intervals.c: Change all users to eassert.
150
26d16b35
EZ
1512012-08-07 Eli Zaretskii <eliz@gnu.org>
152
14ae4239
BT
153 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
154 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
155 INTERNAL_FIELD in Lisp_Cons.
156
c644523b
DA
1572012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
158
159 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
160 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
161 name since all xname users are fixed long time ago. Do not
162 use INTERNAL_FIELD.
163 (set_symbol_name, set_symbol_function, set_symbol_plist):
164 (set_symbol_next, set_overlay_plist): New function.
165 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
166 (struct Lisp_Overlay): Likewise.
167 (CVAR, MVAR, SVAR): Remove.
168 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
169 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
170 * xterm.c: Adjust users.
171 * .gdbinit: Change to use name field of struct Lisp_Symbol
172 where appropriate.
173
6a3d20cc
DA
1742012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Basic functions to set Lisp_Object and pointer slots of intervals.
177 * intervals.h (interval_set_parent, interval_set_object):
178 (interval_set_left, interval_set_right, interval_set_plist):
179 (interval_copy_parent): New function.
180 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
181 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
182 Adjust indentation.
6a3d20cc
DA
183 (INTERVAL_SIZE): Remove. Adjust users.
184 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
185
4d2b044c
DA
1862012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
189 * process.h (PGET): Remove.
190 (struct Lisp_Process): Do not use INTERNAL_FIELD.
191 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
192
d3d50620
DA
1932012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
194
195 Drop WGET and revert read access to Lisp_Objects slots of struct window.
196 * window.h (WGET): Remove.
197 (struct window): Do not use INTERNAL_FIELD.
198 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
199 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
200 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
201 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
202 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
203 Adjust users.
204
d10a51dc
CY
2052012-08-07 Chong Yidong <cyd@gnu.org>
206
207 * window.c (Fwindow_edges, Fwindow_pixel_edges)
208 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
209 (Fdelete_window_internal): Signal an error if the window is not on
210 a live frame (Bug#12025).
211
e69b0960
DA
2122012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
215 * frame.h (FGET): Remove.
216 (struct frame): Do not use INTERNAL_FIELD.
217 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
218 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
219 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
220 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
221
25a20a3a
JB
2222012-08-06 Juanma Barranquero <lekktu@gmail.com>
223
224 * w32.c: Silence compiler warnings.
225 (map_w32_filename): Remove unused variable `is_fat'.
226 (chase_symlinks): Add parentheses around expression.
227
1c6f11f4
GM
2282012-08-06 Glenn Morris <rgm@gnu.org>
229
1db4583a
GM
230 * sysdep.c: Respect BROKEN_GETWD.
231
1c6f11f4
GM
232 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
233 Let configure handle it.
234 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
235
2b90362b
DA
2362012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
237
238 Use GCALIGNMENT where appropriate.
239 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
240 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
241 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
242
5f50daf2
EZ
2432012-08-06 Eli Zaretskii <eliz@gnu.org>
244
14ae4239
BT
245 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
246 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 247
cbcc7007
SM
2482012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
249
250 * buffer.h (struct buffer): Revert `indirections' to a simple int;
251 that should be sufficient for everyone.
252
4d365fa4
JD
2532012-08-06 Jan Djärv <jan.h.d@swipnet.se>
254
255 * keyboard.c (timer_check_2): Add break so timer_check returns next
256 timeout.
257
dd86bd82
DA
2582012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Fix Windows build errors introduced after converting to WGET and WSET.
261 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
262 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
263
054e1668
JD
2642012-08-06 Jan Djärv <jan.h.d@swipnet.se>
265
266 * nsterm.m (ns_frame_rehighlight): Use FSET.
267
268 * nsmenu.m (ns_update_menubar): Use FSET.
269
21238f11
DA
2702012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
271
272 Separate read and write access to Lisp_Object slots of Lisp_Process.
273 * process.h (PGET, PSET): New macros similar to AREF and ASET.
274 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
275
077288cf
DA
2762012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
277
278 Separate read and write access to Lisp_Object slots of struct window.
279 * window.h (WGET, WSET): New macros similar to AREF and ASET.
280 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
281 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
282 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
283 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
284 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
285 Adjust users.
286
71688bd7
DA
2872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Fix Windows build errors introduced after converting to FGET and FSET.
290 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
291 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
292 (w32_judge_scroll_bars): Change to use FSET.
293 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
294
f99bac93
DA
2952012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Fix replacement typo.
298 * window.c (replace_window): Set root_window instead of
299 selected_window. This fixes a total window subsystem
300 malfunction reported by Bastien Guerry <bzg@gnu.org>.
301
8c2a0f2d
GM
3022012-08-06 Glenn Morris <rgm@gnu.org>
303
304 * lisp.mk (lisp): Add language/persian.elc.
305
edd74c35
DA
3062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
307
308 Separate read and write access to Lisp_Object slots of struct frame.
309 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
310 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
311 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
312 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
313 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
314
8671676c
AS
3152012-08-05 Andreas Schwab <schwab@linux-m68k.org>
316
317 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
318
663e2b3f
DA
3192012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
320
321 Generalize common compile-time constants.
322 * lisp.h (header_size, bool_header_size, word_size): Now here.
323 (struct Lisp_Vector): Add comment.
324 (struct Lisp_Bool_Vector): Move up to define handy constants.
325 (VECSIZE, PSEUDOVECSIZE): Simplify.
326 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
327 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
328 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
329 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
330 * xfont.c, xmenu.c: Use word_size where appropriate.
331
d32e47af
LM
3322012-08-05 Lawrence Mitchell <wence@gmx.li>
333
334 * search.c (Freplace_match): Treat \? in the replacement text
335 literally (Bug#8161).
336
e5d9c0d1
CY
3372012-08-05 Chong Yidong <cyd@gnu.org>
338
339 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
340 * frame.c (Vdelete_frame_functions):
341 * emacs.c (Vkill_emacs_hook): Doc fix.
342
8da0576b
EZ
3432012-08-04 Eli Zaretskii <eliz@gnu.org>
344
345 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
346 --with-x-toolkit=no builds.
347 Reported by Carsten Mattner <carstenmattner@gmail.com>.
348
02676e5d
CY
3492012-08-04 Chong Yidong <cyd@gnu.org>
350
351 * syntax.c (Fmodify_syntax_entry): Doc fix.
352
97147da9
EZ
3532012-08-04 Eli Zaretskii <eliz@gnu.org>
354
76151e2c
EZ
355 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
356 * w32.c (init_environment): Change the default values of many
357 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
358 them into environment when they were not already defined.
359 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 360 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
361 (check_windows_init_file): Now external, not static.
362 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
363 called when Vload_path is already set up.
364
365 * w32.h (check_windows_init_file): Add prototype.
366
367 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
368 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
369 compatibility with Posix platforms.
370 (main): Move the call to check_windows_init_file to here from
371 w32.c.
372 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
373 any, in the DEFALT argument into the root of the Emacs build or
374 installation tree, as appropriate.
375
376 * callproc.c (init_callproc_1): Call decode_env_path instead of
377 doing its equivalent by hand.
378 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
379 the code that sets Vexec_path run on MS-Windows.
380
381 * lread.c (init_lread): Add comments to #ifdef's.
382
97147da9
EZ
383 * msdos.c (dos_set_window_size, IT_update_begin)
384 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
385 instead of direct references.
386
185ee146
PE
3872012-08-04 Paul Eggert <eggert@cs.ucla.edu>
388
389 Export DEFAULT_REHASH_* to GDB.
390 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
391 Now constants, not macros.
392
8834c57a
PE
3932012-08-03 Paul Eggert <eggert@cs.ucla.edu>
394
98c6f1e3
PE
395 Remove unnecessary casts involving pointers.
396 These casts are no longer needed now that we assume C89 or later,
397 since they involve casting to or from void *.
398 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
399 (make_pure_float, make_pure_vector):
400 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
401 * macros.c (Fstart_kbd_macro):
402 * menu.c (find_and_return_menu_selection):
403 * minibuf.c (read_minibuf_noninteractive):
404 * sysdep.c (closedir):
405 * xdisp.c (x_produce_glyphs):
406 * xfaces.c (compare_fonts_by_sort_order):
407 * xfns.c (x_real_positions, select_visual):
408 * xselect.c (x_stop_queuing_selection_requests)
409 (x_get_window_property, x_get_window_property_as_lisp_data):
410 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
411 Remove unnecessary pointer casts.
412 * alloc.c (record_xmalloc): New function.
413 * lisp.h (record_xmalloc): New decl.
414 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
415 more like a function. This is because the pointer cast is not
416 needed. All uses changed.
417 * print.c (print_string, print_error_message): Avoid length recalc.
418
8834c57a
PE
419 Improve fix for macroexp crash with debugging (Bug#12118).
420 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
421 ARRAY_MARK_FLAG when checking subscripts, because ASET is
422 not supposed to be invoked from the garbage collector.
423 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
424 (gc_aset): New function, which is like ASET but can be
425 used in the garbage collector.
426 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
427 (set_hash_index): Use it instead of ASET.
428
6dad7178
EZ
4292012-08-03 Eli Zaretskii <eliz@gnu.org>
430
431 Support symlinks on latest versions of MS-Windows.
432 * w32.c: Include winioctl.h and aclapi.h.
433 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
434 (revert_to_self): Forward declarations of static functions.
435 <static BOOL g_b_init_get_security_info>:
436 <g_b_init_create_symbolic_link>: New static flags.
437 (globals_of_w32): Initialize them to zero.
438 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
439 (map_w32_filename): Improve commentary. Simplify switch.
440 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
441 headers (most versions of MinGW w32api don't).
442 (get_security_info, create_symbolic_link)
443 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
444 New functions.
445 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
446 in the argument file name.
447 (sys_access): Call unc_volume_file_attributes only if
448 GetFileAttributes fails with network-related error codes.
449 (sys_rename): Diagnose renaming of a symlink when the user doesn't
450 have the required privileges.
14ae4239 451 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
452 get_file_security_desc.
453 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
454 with addition of handling of symlinks and support for 'lstat'.
455 If possible, get file's attributes and security information by
6dad7178
EZ
456 handle, not by name. Produce S_IFLNK bit for symlinks, when
457 called from 'lstat'.
458 (stat, lstat): New functions, call 'stat_worker'.
459 (symlink, readlink, careadlinkat): Rewritten to create and resolve
460 symlinks when the underlying filesystem supports them.
461
f162bcc3
PE
4622012-08-02 Paul Eggert <eggert@cs.ucla.edu>
463
79ea6c20
PE
464 Fix macroexp crash on Windows with debugging (Bug#12118).
465 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
466 checking subscripts; problem introduced with the recent
467 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
468 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
469 since it's used in non-static inline functions now.
470
c0ce93fd
PE
471 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
472 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 473
f162bcc3
PE
474 Use C99-style 'extern inline' if available.
475 * buffer.h (BUFFER_INLINE):
476 * category.h (CATEGORY_INLINE):
477 * character.h (CHARACTER_INLINE):
478 * charset.h (CHARSET_INLINE):
479 * composite.h (COMPOSITE_INLINE):
480 * dispextern.h (DISPEXTERN_INLINE):
481 * lisp.h (LISP_INLINE):
482 * systime.h (SYSTIME_INLINE):
483 New macro, replacing 'static inline' in this header.
484 * buffer.h, category.h, character.h, charset.h, composite.h:
485 * dispextern.h, lisp.h, systime.h:
486 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
487 * alloc.c (LISP_INLINE):
488 * buffer.c (BUFFER_INLINE):
489 * category.c (CATEGORY_INLINE):
490 * character.c (CHARACTER_INLINE):
491 * charset.c (CHARSET_INLINE):
492 * composite.c (COMPOSITE_INLINE):
493 * dispnew.c (DISPEXTERN_INLINE):
494 * sysdep.c (SYSTIME_INLINE):
495 Define to EXTERN_INLINE, so that the corresponding functions
496 are compiled into code.
497 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
498 (INLINE_HEADER_END): New macros.
499 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
500 since it's used in non-static inline functions now.
a8333d03 501 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 502
837b365b
GM
5032012-08-02 Glenn Morris <rgm@gnu.org>
504
d66b744d
GM
505 * s/: Remove empty directory.
506
837b365b
GM
507 * s/ms-w32.h: Move to ../nt/inc.
508 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
509 Update for new ms-w32.h location.
510
13294f95
PE
5112012-08-02 Paul Eggert <eggert@cs.ucla.edu>
512
513 Port to Solaris 8.
514 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
515
90df0db3
GM
5162012-08-02 Glenn Morris <rgm@gnu.org>
517
518 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
519 hard-coding the path separator.
520
4939150c
PE
5212012-08-01 Paul Eggert <eggert@cs.ucla.edu>
522
523 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
524 This how ASET and AREF are supposed to work, and makes
525 it easier to think about future improvements. See
526 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
527 * charset.h (set_charset_attr): New function.
528 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
529 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
530 (aref_addr): New function. All uses of &AREF(...) changed.
531 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
532 (set_hash_index): New functions. All lvalue-style uses of
533 HASH_KEY etc. changed.
534 * keyboard.c (set_prop): New function. All lvalue-style uses
535 of PROP changed.
536
947b2afd
AA
5372012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
538
539 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
540 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
541 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
542 * nsfns.m (ns_set_name_as_filename): Likewise.
543 * nsmenu.m (ns_update_menubar): Likewise.
544 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
545
4f5d0325
EZ
5462012-08-01 Eli Zaretskii <eliz@gnu.org>
547
2008beae
EZ
548 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
549 Adapt to latest changes in field names of the corresponding Lisp
288479f6 550 objects.
2008beae 551
4f5d0325
EZ
552 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
553
fe3cc771
GM
5542012-08-01 Glenn Morris <rgm@gnu.org>
555
556 * s/msdos.h: Remove file.
557 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
558 * Makefile.in (S_FILE): Remove.
559 (config_h): Remove S_FILE.
560
c90acc54
JB
5612012-08-01 Juanma Barranquero <lekktu@gmail.com>
562
563 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
564 Remove; moved to nt/config.nt.
565
d8a05828
DA
5662012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
567
568 Use INTERNAL_FIELD for conses and overlays.
569 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
570 Remove obsolete comment.
571 (MVAR): New macro.
572 (struct Lisp_Overlay): Use INTERNAL_FIELD.
573 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
574
8271d590
DA
5752012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Use INTERNAL_FIELD for symbols.
578 * lisp.h (SVAR): New macro. Adjust users.
579 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
580 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
581
3193acd2
DA
5822012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
583
584 Use INTERNAL_FIELD for processes.
585 * process.h (PVAR): New macro. Adjust style.
586 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
587 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
588
3a45383a
DA
5892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
590
591 Use INTERNAL_FIELD for windows.
592 * window.h (WVAR): New macro.
593 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
594 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
595 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
596 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
597 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
598 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
599
c1dbc63c
PE
6002012-08-01 Paul Eggert <eggert@cs.ucla.edu>
601
602 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
603
5c0c0e8a
GM
6042012-08-01 Glenn Morris <rgm@gnu.org>
605
606 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
607 Move to configure.ac.
608
552a99b4
JB
6092012-08-01 Juanma Barranquero <lekktu@gmail.com>
610
611 * makefile.w32-in (CONFIG_H): Update dependencies.
612 (CONF_POST_H): New macro.
613
614 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
615
8d8e2dfe
GM
6162012-07-31 Glenn Morris <rgm@gnu.org>
617
bc96620a
GM
618 * Makefile.in (S_FILE): No longer set by configure.
619
476b1b2d
GM
620 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
621 is available.
622 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
623
b2c7a106
GM
624 * process.h (NULL_DEVICE):
625 * emacs.c (SEPCHAR):
626 * editfns.c (USER_FULL_NAME): Let configure set them.
627
d53d062a
GM
628 * s/README, s/template.h: Remove files.
629
4515017f
GM
630 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
631
8d8e2dfe
GM
632 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
633 Move to configure.ac.
634
5b20b3cc
EZ
6352012-07-31 Eli Zaretskii <eliz@gnu.org>
636
1e0afd9a
EZ
637 * .gdbinit (xframe): Adapt to introduction of FVAR and the
638 resulting renaming of 'struct frame' members.
639
5b20b3cc
EZ
640 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
641
642 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
643 after introduction of FVAR.
644
f1310128
JD
6452012-07-31 Jan Djärv <jan.h.d@swipnet.se>
646
79e721e0
JD
647 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
648
649 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
650 instead of compositeToPoint.
651 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
652
8d7c7eed 653 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 654
e34f7f79
DA
6552012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
656
657 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
658 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 659 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
660 (BVAR): Change to use INTERNAL_FIELD.
661 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
662 (KVAR): Change to use INTERNAL_FIELD.
663 * frame.h (FVAR): New macro.
664 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
665 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
666 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
667 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
668 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
669
c09bfb2f
DA
6702012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
671
672 Miscellaneous fixes for non-default X toolkits.
673 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
674 * xterm.c (x_frame_of_widget): Remove redundant prototype.
675 Move under #ifdef USE_LUCID.
676 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
677 definition and usage to avoid warnings.
678
14c114ae
JD
6792012-07-31 Jan Djärv <jan.h.d@swipnet.se>
680
681 * nsterm.m (openFiles): Fix previous checkin.
682
3bd21e82
PE
6832012-07-31 Paul Eggert <eggert@cs.ucla.edu>
684
685 * indent.c (compute_motion): Remove unused local.
686
c1529ded
GM
6872012-07-31 Glenn Morris <rgm@gnu.org>
688
400d5621
GM
689 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
690
268e2432
GM
691 * conf_post.h [USG5_4]:
692 Move remaining contents of s/usg5-4-common.h here.
693 * s/usg5-4-common.h: Remove file.
694
7552f3ee
GM
695 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
696 * s/irix6-5.h: Remove file.
697
6a381852
GM
698 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
699 * s/darwin.h: Remove file.
700
c1529ded
GM
701 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
702 * s/hpux10-20.h: Remove file, which is now empty.
703
b429a4ee
GM
7042012-07-30 Glenn Morris <rgm@gnu.org>
705
706 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
707 * Makefile.in (config_h): Add conf_post.h.
708 * makefile.w32-in (CONFIG_H): Add conf_post.h.
709
adff3182
JD
7102012-07-30 Jan Djärv <jan.h.d@swipnet.se>
711
712 * nsterm.m (ns_do_open_file): New variable.
b9031d69 713 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
714 (openFile, openTempFile, openFileWithoutUI, openFiles):
715 Open files only if ns_do_open_file.
adff3182 716
c32af1e4
PE
7172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
718
7393bcbb
PE
719 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
720 This no-op macro hasn't been needed for many years.
721 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
722
c32af1e4
PE
723 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
724 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
725 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
726 gdb_make_enums_visible.
727 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
728 (DIRECTORY_SEP): Now a constant, not a macro.
729
302fc036
EZ
7302012-07-30 Eli Zaretskii <eliz@gnu.org>
731
732 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
733 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
734
735 * w32term.c <w32_keyboard_codepage>: Renamed from
736 keyboard_codepage and now external. All users changed.
737
738 * w32term.h: Add declaration of w32_keyboard_codepage.
739
740 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
741 the codepage to translate keys to Unicode. If this argument is
742 -1, use the value returned by GetConsoleCP. All callers changed.
743
88fb40b4
PE
7442012-07-30 Paul Eggert <eggert@cs.ucla.edu>
745
0aee6912
PE
746 Update .PHONY listings in makefiles.
747 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
748 bootstrap-clean, distclean, maintainer-clean, versioclean,
749 extraclean, frc.
750
88fb40b4
PE
751 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
752 This is a bit clearer. Fix some commentary typos.
753
0a763bd1
GM
7542012-07-30 Glenn Morris <rgm@gnu.org>
755
32bac6d6
GM
756 * s/netbsd.h: Let configure include signal.h if needed.
757 Remove file, which is now empty.
758
b65e7c46
GM
759 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
760 Let configure set them.
761 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
762 No more need to undefine.
0a763bd1 763
169304bd
AS
7642012-07-30 Andreas Schwab <schwab@linux-m68k.org>
765
766 * keymap.c (Fkey_description): Don't remove 0x80 bit from
767 non-single-byte char when adding meta modifier. (Bug#12090)
768
6cd7a139
DA
7692012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Convert safe_call to use variable number of arguments.
772 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
773 (safe_call2): Fix comment.
774 * lisp.h (safe_call): Adjust prototype.
775 * coding.c (encode_coding_object): Change to use safe_call2.
776 * xfaces.c (merge_face_heights): Change to use safe_call1.
777
d34d6ffc
GM
7782012-07-30 Glenn Morris <rgm@gnu.org>
779
7b8a48e4 780 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 781 does that unconditionally. Remove file, which is now empty.
7b8a48e4 782
d34d6ffc
GM
783 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
784 Remove empty files.
785
03a660a6
PE
7862012-07-30 Paul Eggert <eggert@cs.ucla.edu>
787
788 Export to GDB most of lisp.h's remaining object-like macros.
789 * lisp.h (min, max): Move earlier, because they're used earlier now.
790 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
791 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
792 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
793 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
794 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
795 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
796 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
797 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
798 Now constants, for GDB. They need not be macros.
799 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
800 Now constants, for GDB, as well as macros, for static initializers.
801 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
802 Move to after the definition of struct Lisp_Char_Table,
803 since the former now needs that type defined.
804 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
805 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
806 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
807 New enums, for gdb_make_enums_visible.
808 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 809 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
810 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
811 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
812 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
813 enum maxargs, enum MAX_ALLOCA.
814 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
815 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
816 no longer needed, now that they are done in lisp.h.
817
e499d0ee
DA
8182012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Cleanup string bytes checking.
821 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
822 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
823 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
824 (check_sblock, compact_small_strings): Simplify.
825
d5040d2d
PE
8262012-07-29 Paul Eggert <eggert@cs.ucla.edu>
827
828 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
829 These macros are confusing and no longer need to be defined, as
830 the enum values now suffice. All uses replaced with definiens.
831 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
832
7f259ae6
JB
8332012-07-29 Juanma Barranquero <lekktu@gmail.com>
834
835 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
836 ($(BLD)/w32console.$(O)): Update dependencies.
837
7e63e0c3
DA
8382012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
841 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
842 time. Adjust users.
843 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
844
ffd817eb
JD
8452012-07-29 Jan Djärv <jan.h.d@swipnet.se>
846
847 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
848 setting sitelisp (Bug#12010).
849
417a7a0e
EZ
8502012-07-29 Eli Zaretskii <eliz@gnu.org>
851
14ae4239 852 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
853
854 * w32heap.c (cache_system_info):
855 * w32.c (sys_rename):
856 * w32proc.c (find_child_console, sys_kill): All users changed.
857
387d4d92
PE
8582012-07-29 Paul Eggert <eggert@cs.ucla.edu>
859
860 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
861
55a6cca6
EZ
8622012-07-29 Eli Zaretskii <eliz@gnu.org>
863
864 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
865
dbcf001c
DA
8662012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
867
868 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
869 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
870 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 871
e2688e4a
DA
8722012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
873
874 Generalize marker debugging code under MARKER_DEBUG and use eassert.
875 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
876 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
877 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
878 (replace_range, replace_range_2, del_range_2): Change to eassert.
879 * marker.c (byte_char_debug_check): Adjust style.
880
b46a6a83
PE
8812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
882
883 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
884 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
885 long-ago-commented-out code that talks about "WIN32".
886 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
887 All uses changed.
888
e32a5799
PE
8892012-07-28 Paul Eggert <eggert@cs.ucla.edu>
890
891 Use Gnulib stdalign module (Bug#9772, Bug#9960).
892 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
893 Simplify by using alignof.
894 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
895 * lisp.h: Include <stdalign.h>.
896 (GCALIGNMENT): New macro and constant.
897 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
898 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
899 (stdalign): New macro, if not already defined.
900
df81cd29
EZ
9012012-07-28 Eli Zaretskii <eliz@gnu.org>
902
01bd1b0d
EZ
903 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
904 * w32inevt.c: Include w32inevt.h.
905 (w32_read_console_input): New inline function, calls either
906 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
907 w32_console_unicode_input.
908 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
909 (w32_kbd_patch_key, key_event): Use the codepage returned by
910 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
911 (key_event): use uChar.UnicodeChar only if
912 w32_console_unicode_input is non-zero.
913
914 * w32console.c: Include w32heap.h.
915 <w32_console_unicode_input>: New global variable.
916 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
917 family of Windows, zero otherwise.
918
919 * w32inevt.h: Declare w32_console_unicode_input.
920
df81cd29
EZ
921 * xdisp.c (init_iterator): Don't reference tip_frame in a build
922 --without-x. (Bug#11742)
923
c20fdd9e
PE
9242012-07-27 Paul Eggert <eggert@cs.ucla.edu>
925
926 Adjust GDB to reflect pvec_type changes (Bug#12036).
927 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
928 2012-07-04 changes to pseudovector representation.
929 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 930
32770973 9312012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
932
933 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
934 bus address.
935 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
936
3438fe21
EZ
9372012-07-27 Eli Zaretskii <eliz@gnu.org>
938
bcfbc9de
EZ
939 * alloc.c (listn): Fix the order the arguments are consed onto the
940 list.
941
3438fe21
EZ
942 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
943 enumeration constants, as PURE and HEAP are too general, and clash
944 with other headers and sources, such as gmalloc.c and the
945 MS-Windows system headers. All users changed.
946
eeaea515
DA
9472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
948
949 Revert last save_excursion_save and save_excursion_restore changes.
950 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
951 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
952
073c88c2
DA
9532012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
954
955 Fix recently-introduced typos in Windows port.
956 Reported by Martin Rudalics <rudalics@gmx.at>.
957 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 958 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 959
4706125e
PE
9602012-07-27 Paul Eggert <eggert@cs.ucla.edu>
961
962 Improve GDB symbol export (Bug#12036).
963 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
964 arms of an 'if', not using conditional expressions; otherwise GDB
965 complains about the types in the unevaluated arm when the argument
966 is an integer literal.
967 (xgetint): Simplify expression.
968 * alloc.c (gdb_make_enums_visible): New constant. This ports to
969 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
970 Zaretskii in <http://bugs.gnu.org/12036#13>.
971 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
972 needed now that we have gdb_make_enums_visible.
973 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
974 (enum enum_USE_LSB_TAG):
975 New enum types, packaging up enums that need to be exported to GDB.
976
694b6c97
DA
9772012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
978
979 Utility function to make a list from specified amount of objects.
980 * lisp.h (enum constype): New datatype.
981 (listn): New prototype.
982 * alloc.c (listn): New function.
983 (Fmemory_use_count, syms_of_alloc): Use it.
984 * buffer.c (syms_of_buffer): Likewise.
985 * callint.c (syms_of_callint): Likewise.
986 * charset.c (define_charset_internal): Likewise.
987 * coding.c (syms_of_coding): Likewise.
988 * keymap.c (syms_of_keymap): Likewise.
989 * search.c (syms_of_search): Likewise.
990 * syntax.c (syms_of_syntax): Likewise.
991 * w32.c (init_environment): Likewise.
992 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
993 * xdisp.c (syms_of_xdisp): Likewise.
994 * xfns.c (syms_of_xfns): Likewise.
995
6195f384
DA
9962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
997
998 Fast save_excursion_save and save_excursion_restore.
999 * lisp.h (struct Lisp_Excursion): New data type.
1000 (PVEC_EXCURSION): New pseudovector type.
1001 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1002 to deal with it. Adjust comments.
1003 (init_marker, attach_marker): New prototype.
1004 (unchain_marker): Adjust prototype.
1005 * marker.c (attach_marker): Change to global.
1006 (init_marker): New function.
1007 * alloc.c (Fmake_marker, build_marker): Use it.
1008 (build_marker): More easserts.
1009 (mark_object): Handle struct Lisp_Excursion.
1010 * editfns.c (save_excursion_save, save_excursion_restore):
1011 Reimplement to use struct Lisp_Excursion. Add comments.
1012
5eceb8fb
PE
10132012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 Fix export of symbols to GDB (Bug#12036).
1016 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1017 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1018 emacs.c, as this is a more-suitable home. Had this been done earlier
1019 the fix for 12036 would have avoided some of the problems noted in
1020 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1021 would have been more obvious.
562157c8
PE
1022 * emacs.c: Do not include <verify.h>; no longer needed.
1023 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1024 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1025 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1026 Remove; now done in lisp.h.
1027 * lisp.h (PUBLISH_TO_GDB): New macro.
1028 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1029 (DATA_SEG_BITS): Use it.
1030 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1031 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1032 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1033 not be usable in #if. This simplifies things.
1034
d6749401
JB
10352012-07-26 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1038
1781b9e9
PE
10392012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1040
d89518db 1041 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1042 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1043 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1044 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1045 Adjust to changes in lisp.h and emacs.c, by using
1046 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1047 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1048 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1049 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1050 instead of gdb_valbits.
1051 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1052 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1053 instead of gdb_array_mark_flag.
1054 (xboolvector): Get size from $->size, not $->header.size.
1055 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1056 (xreload, hook-run, hookpost-run): Remove.
1057 * emacs.c: Include <verify.h>.
1058 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1059 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1060 Remove.
1061 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1062 (gdb_USE_LSB_TAG): New enum constants.
1063 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1064 Also define these as enum constants, so they're visible to GDB.
1065 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1066 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1067 as constants, so they're visible to GDB.
1068 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1069 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1070 Now enum constants, not macros, so they're visible to GDB.
1071 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1072 more convenient now. All uses changed.
1073 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1074 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1075
3628596a
DA
10762012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Explicitly free restriction data that are not needed anymore.
1079 * editfns.c (save_restriction_restore): Free restriction data.
1080
7abaf5cc
SM
10812012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1082
1083 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1084 add argument, tune behavior, and adjust all callers.
1085
71f88e00
PE
10862012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 Use typedef for EMACS_INT, EMACS_UINT.
1089 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1090 than macros. This simplifies debugging in the usual case, since
1091 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1092 and it allows expressions involving EMACS_INT casts.
1093 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1094
57ec3034
JD
10952012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1096
1097 * nsterm.m (ns_read_socket): Return early if there is a modal
1098 window (Bug#12043).
1099
8137e7b3
MR
11002012-07-25 Martin Rudalics <rudalics@gmx.at>
1101
1102 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1103 that FOCUS-FRAME can be omitted.
1104
04e9897c
DA
11052012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1106
1107 Adjust buffer text indirection counters at the end of Fkill_buffer.
1108 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1109 buffer is definitely dead. This should really fix an issue reported
1110 by Christoph Scholtes again. (Bug#12007).
1111 (init_buffer_once): Initialize indirection counters of
1112 buffer_defaults and buffer_local_symbols (for sanity and safety).
1113
8a0484e1
EZ
11142012-07-24 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1117 and continuation glyphs on tooltip frames, leave them at zero.
1118 Avoids continued lines in tooltips. (Bug#11832)
1119
fa691a83
DA
11202012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Simplify copy_overlay.
04e9897c 1123 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1124 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1125
436bc8e0
EZ
11262012-07-23 Eli Zaretskii <eliz@gnu.org>
1127
1128 * print.c (print_object): Don't crash when a frame's name is nil
1129 or invalid. (Bug#12025)
1130
1131 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1132 it signals an error when a tooltip frame is being created.
1133
d7a7fda3
DA
11342012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 Cleanup miscellaneous objects allocation and initialization.
1137 * alloc.c (allocate_misc): Change to static. Add argument to
1138 specify the subtype. Adjust comment and users.
1139 (build_overlay): New function.
1140 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1141 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1142 (allocate_misc): Remove prototype.
1143 (build_overlay): Add prototype.
1144
11452012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1146
1147 Swap buffer text indirection counters in Fbuffer_swap_text.
1148 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1149 This avoids crash reported by Christoph Scholtes at
1150 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1151
9d7fa573
JD
11522012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * nsmenu.m (Popdown_data): New struct.
1155 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1156 free Popdown_data.
1157 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1158 (initWithContentRect): Make imgView and contentView non-static
1159 and autorelease them. Also autorelease img and matrix (Bug#12005).
1160 (dealloc): Remove (Bug#12005).
1161
0dd6d66d
DA
11622012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 Adjust consing_since_gc when objects are explicitly freed.
1165 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1166 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1167 (free_cons, free_misc): Subtract object size from consing_since_gc.
1168
d36d71df
DA
11692012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 Simplify and cleanup markers positioning code.
1172 * marker.c (attach_marker): More useful eassert.
1173 (live_buffer, set_marker_internal): New function.
1174 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1175 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1176
fb9ea40f
PE
11772012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1180 as it's limited by the amount of memory, not by INT_MAX.
1181
2d5c5f7d
EZ
11822012-07-21 Eli Zaretskii <eliz@gnu.org>
1183
07fb592e
EZ
1184 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1185 in special-event-map. See the discussion at
1186 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1187 for the reasons.
1188
37a9eac8 1189 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1190 info.dwItemData. Fixes crashes on 64-bit Windows.
1191 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1192
c4328746
JD
11932012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1196 (conversationIdentifier): Return value is NSInteger.
784051c4 1197 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1198
6e5d1c12
CY
11992012-07-21 Chong Yidong <cyd@gnu.org>
1200
1201 * window.c (decode_any_window): Signal an error if the window is
1202 on a dead frame (Bug#11984).
1203
9928463d
DA
12042012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 Add indirection counting to speed up Fkill_buffer.
1207 * buffer.h (struct buffer): New member.
1208 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1209 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1210 base buffer indirection counter.
1211 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1212 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1213 through buffer list if indirection counter is 0.
1214
f8643a6b
DA
12152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1216
1217 Extend the value returned by Fgarbage_collect with heap statistics.
1218 * alloc.c (Qheap): New symbol.
1219 (syms_of_alloc): DEFSYM it.
1220 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1221 (Fmemory_free): Remove.
1222 (syms_of_alloc): Don't defsubr it.
1223 * buffer.c (Fcompact_buffer): Remove.
1224 (syms_of_buffer): Don't defsubr it.
1225
dac616ff
DA
12262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 Make maybe_gc inline.
1229 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1230 * lisp.h (consing_since_gc, gc_relative_threshold)
1231 (memory_full_cons_threshold): Revert declaration.
1232 (maybe_gc): Remove prototype, define as inline.
1233 * alloc.c: Remove old commented-out code.
1234 (consing_since_gc, gc_relative_threshold)
1235 (memory_full_cons_threshold): Revert to global.
1236 (maybe_gc): Remove.
1237
d7ea76b4
DA
12382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1239
1240 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1241 * lisp.h (build_unibyte_string): New function.
1242 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1243 * sysdep.c, w32fns.c, xfns.c: Use it.
1244 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1245 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1246 Adjust users accordingly.
1247 * font.h (font_open_by_name): Adjust prototype.
1248
765e61e3
DA
12492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1250
1251 Cleanup calls to Fgarbage_collect.
1252 * lisp.h (maybe_gc): New prototype.
1253 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1254 Remove declarations.
1255 * alloc.c (maybe_gc): New function.
1256 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1257 Make them static.
1258 * bytecode.c (MAYBE_GC): Use maybe_gc.
1259 * eval.c (eval_sub, Ffuncall): Likewise.
1260 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1261 to avoid dependency from auto-save feature.
1262
52b852c7
PE
12632012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1266 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1267 'for_each_per_buffer_object_at'.
1268 All uses changed. It's better to use upper-case for macros that
1269 cannot be implemented as functions, to give the reader a clue
1270 that they're special.
1271
5db81e33
SM
12722012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1273
1274 * alloc.c (Fgarbage_collect): Tweak docstring.
1275
5b835e1d
DA
12762012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1277
1278 Tweak the value returned from Fgarbage_collect again.
1279 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1280 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1281 Adjust documentation.
1282 (total_vector_bytes): Rename to total_vector_slots, adjust
1283 accounting.
1284 (total_free_vector_bytes): Rename to total_free_vector_slots,
1285 adjust accounting.
1286 (Qstring_bytes, Qvector_slots): New symbols.
1287 (syms_of_alloc): DEFSYM them.
1288
9cd47b72
DA
12892012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1290
1291 Buffer compaction primitive which may be used from Lisp.
1292 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1293 (syms_of_buffer): Register Fcompact_buffer.
1294 * alloc.c (Fgarbage_collect): Use compact_buffer.
1295 * buffer.h (compact_buffer): New prototype.
1296 (struct buffer_text): New member.
1297
d17337e5
DA
12982012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 New macro to iterate over all buffers, miscellaneous cleanups.
1301 * lisp.h (all_buffers): Remove declaration.
1302 * buffer.h (all_buffers): Add declaration, with comment.
1303 (for_each_buffer): New macro.
1304 * alloc.c (Fgarbage_collect, mark_object): Use it.
1305 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1306 (init_buffer): Likewise.
1307 * data.c (Fset_default): Likewise.
1308 * coding.c (code_conversion_restore): Remove redundant check
1309 for dead buffer.
1310 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1311
60cfd278
AS
13122012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1313
1314 Fix bug that created negative-length intervals.
1315 * intervals.c (merge_interval_right, merge_interval_left):
1316 Do not zero out this interval if it is absorbed by its children,
1317 as this interval's total length doesn't change in that case. See
1318 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1319
d06714cb
PE
13202012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1321
83713154
PE
1322 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1323 when invoking (make-bool-vector N t) and N is a positive
1324 multiple of 8 -- the last 8 bits were mistakenly cleared.
1325
d06714cb
PE
1326 Remove some struct layout assumptions in bool vectors.
1327 * alloc.c (bool_header_size): New constant.
1328 (header_size, word_size): Move earlier, as they're now used earlier.
1329 Use 'word_size' in a few more places, where it's appropriate.
1330 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1331 padding before the data member of a bool vector.
1332 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1333 than doing the check by hand with an abort ().
1334
464d5a5e
SM
13352012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1336
5fbc0409
SM
1337 * eval.c (Fdefvar): Don't check constants since we only set the var if
1338 it's not yet defined anyway (bug#11904).
1339
464d5a5e
SM
1340 * lisp.h (last_undo_boundary): Declare new var.
1341 * keyboard.c (command_loop_1): Set it.
1342 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1343 were auto-added by the command loop (bug#11774).
1344
8dc2e44a
AS
13452012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1346
1347 * w32font.c (Qsymbol): Remove local definition.
1348 (syms_of_w32font): Don't DEFSYM it.
1349
169925ec
DA
13502012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1351
1352 Fix sweep_vectors to handle large bool vectors correctly.
1353 * alloc.c (sweep_vectors): Account total_vector_bytes for
1354 bool vectors larger than VBLOCK_BYTES_MAX.
1355
5fbfb018
CY
13562012-07-18 Chong Yidong <cyd@gnu.org>
1357
1358 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1359 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1360
3ab6e069
DA
13612012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 Return more descriptive data from Fgarbage_collect.
1364 Suggested by Stefan Monnier in
1365 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1366 * alloc.c (bounded_number): New function.
1367 (total_buffers, total_vectors): New variable.
1368 (total_string_size): Rename to total_string_bytes, adjust users.
1369 (total_vector_size): Rename to total_vector_bytes, adjust users.
1370 (sweep_vectors): Account total_vectors and total_vector_bytes.
1371 (Fgarbage_collect): New return value. Adjust documentation.
1372 (gc_sweep): Account total_buffers.
1373 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1374 (VECTOR_SIZE): Remove.
1375 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1376 (Qinterval, Qmisc): New symbols.
1377 (syms_of_data): Initialize them.
1378 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1379 (Qcons, Qbuffer): New declarations.
1380
6d02fe5b
PE
13812012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1384 Round up, not down. Improve doc.
1385
b7ffe040
DA
13862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 Restore old code in allocate_string_data to avoid Faset breakage.
1389 Reported by Julien Danjou <julien@danjou.info> in
1390 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1391 * alloc.c (allocate_string_data): Restore old code with minor
1392 adjustments, fix comment to explain this subtle issue.
1393
4dc7c8d5
SM
13942012-07-17 Eli Zaretskii <eliz@gnu.org>
1395
1396 Remove FILE_SYSTEM_CASE.
1397 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1398
1399 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1400 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1401 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1402 call-process-region passes it through expand-file-name.
1403
1404 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1405
14062012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1407
1408 Fix crash when creating indirect buffer (Bug#11917)
1409 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1410 Don't handle unbound variables specially if non-zero.
1411 (Fbuffer_local_variables): Pass zero.
1412 (clone_per_buffer_values): Pass non-zero.
1413
14142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1415
1416 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1417 to make the loop interruptible.
1418
14192012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1420
1421 * gnutls.c (emacs_gnutls_handshake): Only retry if
1422 GNUTLS_E_INTERRUPTED.
1423
cce7fefc
DA
14242012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 Cleanup and convert miscellaneous checks to eassert.
1427 * alloc.c (mark_interval): Fix comment, partially rephrase
1428 old comment from intervals.h (see below).
1429 * intervals.c (find_interval, adjust_intervals_for_insertion)
1430 (delete_interval, adjust_intervals_for_deletion)
1431 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1432 Convert to eassert.
1433 (adjust_intervals_for_insertion, make_new_interval):
1434 Remove obsolete and unused code.
1435 * intervals.h (struct interval): Remove obsolete comment.
1436 * textprotp.c (erase_properties): Remove unused code.
1437 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1438 (Fremove_list_of_text_properties): Convert to eassert.
1439
9ea10cc3
CY
14402012-07-17 Chong Yidong <cyd@gnu.org>
1441
1442 * editfns.c (Finsert_char): Doc fix.
1443
3900d5de
DA
14442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1445
1446 Fix previous change to make Fmemory_free always accurate.
1447 * alloc.c (make_interval): Update total_free_intervals.
1448 (make_float): Likewise for total_free_floats.
1449 (free_cons, Fcons): Likewise for total_free_conses.
1450 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1451 Likewise for total_free_vector_bytes.
1452 (Fmake_symbol): Likewise for total_free_symbols.
1453 (bytes_free): Remove.
1454
7098646f
DA
14552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 Simple free memory accounting feature.
1458 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1459 (sweep_vectors): Accumulate size of free vectors.
1460 (Fgarbage_collect): Setup bytes_free.
1461 (Fmemory_free): New function.
1462 (syms_of_alloc): Register it.
1463
22657b40
DA
14642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1465
1466 Cleanup overlays checking.
1467 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1468 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1469 eassert and OVERLAYP.
1470 (sort_overlays): Change to use OVERLAYP.
1471
ddfc8813
RK
14722012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1473
1474 * editfns.c (Finsert_char): Make it interactive, and make the
1475 second arg optional. Copy interactive spec and docstring from
1476 ucs-insert.
1477
7c26cf3c
PE
14782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1481 Unlike the other wrapped functions, fabs has an unspecified
1482 effect on errno.
1483
5d127af9
JD
14842012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1485
1486 * nsterm.m (keyDown): Interpret flags without left/right bits
1487 as the left key (Bug#11670).
1488
6a0dd1d7
DA
14892012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1490
1491 Remove empty and useless init functions.
1492 * lisp.h (init_character_once, init_fns, init_image)
1493 (init_filelock, init_sound): Remove prototype.
1494 * character.c (init_character_once): Remove.
1495 * filelock.c (init_filelock): Likewise.
1496 * fns.c (init_fns): Likewise.
1497 * image.c (init_image): Likewise.
1498 * sound.c (init_sound): Likewise.
1499 * emacs.c (main): Adjust accordingly.
1500
7a6136fd
DA
15012012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1502
1503 * gtkutil.h: Tiny cleanups.
1504 (use_old_gtk_file_dialog): Remove useless declaration.
1505 (xg_uses_old_file_dialog): Add suggested const attribute.
1506
ce811ad9
EZ
15072012-07-15 Eli Zaretskii <eliz@gnu.org>
1508
1509 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1510 (bidi_paragraph_init): Use it to limit search forward for a strong
1511 directional character in abnormally large paragraphs full of
1512 neutral or weak characters. (Bug#11943)
1513
c9adfeaa
SF
15142012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1515
1516 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1517 the toolbar (Bug#9451).
1518 (xg_make_tool_item): Give the widget event box a transparent
1519 background.
1520
fff62aa9
DA
15212012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1522
1523 Cleanup basic allocation variables and functions.
1524 * alloc.c (ignore_warnings, init_intervals, init_float)
1525 (init_cons, init_symbol, init_marker): Remove.
1526 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1527 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1528 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1529 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1530 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1531 (staticidx, init_alloc_once, init_strings, free_ablock):
1532 Remove redundant initialization.
1533 * fns.c (init_weak_hash_tables): Remove.
1534 * lisp.h (init_weak_hash_tables): Remove prototype.
1535
9730daca
DA
15362012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1537
1538 Use zero_vector where appropriate.
1539 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1540 accordingly.
1541 * lisp.h (zero_vector): New declaration.
1542 * font.c (null_vector): Remove.
1543 (syms_of_font): Remove initialization and staticpro.
1544 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1545 * keymap.c (Faccessible_keymaps): Likewise.
1546
2e2d2a13
LL
15472012-07-15 Leo Liu <sdl.web@gmail.com>
1548
1549 * fringe.c: Fix typo in comments.
1550
cd276f6e
LL
15512012-07-14 Leo Liu <sdl.web@gmail.com>
1552
1553 * fringe.c: Add a new bitmap exclamation-mark.
1554
5a1131d9
EZ
15552012-07-14 Eli Zaretskii <eliz@gnu.org>
1556
1557 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1558
1559 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1560 (HAVE_MENUS): Don't define, defined by editing config.in with
1561 msdos/sed2v2.inp.
1562 (GMALLOC_INHIBIT_VALLOC): Don't define.
1563 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1564
22e983b7
JB
15652012-07-14 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1568
5b3f250f
GM
15692012-07-14 Glenn Morris <rgm@gnu.org>
1570
1571 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1572 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1573 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1574
33d63ff4
GM
15752012-07-13 Glenn Morris <rgm@gnu.org>
1576
5b633342
GM
1577 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1578
33d63ff4
GM
1579 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1580 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1581
b55b9f85
JD
15822012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1583
0dc8cf50
JD
1584 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1585 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1586 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1587 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1588 where appropriate.
1589 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1590 as boolean expression.
1591 (x_set_window_size): Remove unused variable toolbar.
1592 (ns_get_color_default, ns_mod_to_lisp): Remove.
1593 (ns_mouse_position): Remove unused variables xchar and ychar.
1594 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1595 (ns_set_vertical_scroll_bar): Remove unused variable count.
1596 (ns_delete_terminal): Remove unused variable i.
1597 (ns_term_init): Remove unused variables r, g and b.
1598 (mouseDown): Remove unused variable window.
1599 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1600 (initFrameFromEmacs): Remove unused variable vbextra.
1601 (mouseEntered): Remove unused variables p and dpyinfo.
1602 (mouseExited): Remove unused variables p and r.
1603 (ns_define_frame_cursor, ns_clear_frame_area)
1604 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1605 (menuDown): Assign [sender tag] to variable and cast the variable.
1606
1607 * nsterm.h (menuDown): Add id as type to argument sender.
1608 (ns_display_info_for_name): Add Lisp_Object argument.
1609 (ns_term_init): Add Lisp_Object argument.
1610 (ns_map_event_to_object): Add void argument.
1611 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1612 prototype with arguments and only declare if __OBJC__.
1613 (nxatoms_of_nsselect): Add void argument.
1614 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1615 (ns_alloc_autorelease_pool): Add void argument.
1616 (ns_release_autorelease_pool): Add void* argument.
1617 (ns_get_defaults_value): Add const char* argument.
1618
1619 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1620 (initFromContents): Use SSDATA where appropriate.
1621 (ns_update_menubar): Add braces to ambigous if-else.
1622 (initWithTitle): Put () around assignment in if statement.
1623 (ns_menu_show): Remove unused variables window and keymap.
1624 (update_frame_tool_bar): Remove unused variable selected_p.
1625 (initWithContentRect): Remove unused variable this_cmd_name.
1626
1627 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1628 appropriate.
1629 (setXBMColor): Remove unused variable len.
1630 (setPixmapData): Put () around assignment in loop statement.
1631
1632 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1633 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1634 where appropriate.
1635 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1636 around assignment in loop statement.
1637 (nsfont_open): Remove unused variable i.
1638 (nsfont_open): Remove unused variable len.
1639 (nsfont_draw): Remove unused variable cs.
1640
1641 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1642 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1643 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1644 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1645 (Fns_font_name, Fns_perform_service)
1646 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1647 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1648 (ns_set_name): Remove unused variable view.
1649 (x_set_menu_bar_lines): Remove unused variable olines.
1650 (x_set_tool_bar_lines): Remove unused variable root_window.
1651 (Fns_list_colors): Put () around assignment in while statement.
1652 (Fns_perform_service): Remove unused variable len.
1653 (Fns_display_usable_bounds): Remove unused variable top.
1654 (syms_of_nsfns): Remove unused variable i.
1655
b55b9f85
JD
1656 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1657 memcpy (Bug#11907).
1658
ed9265fc 16592012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1660
1661 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1662 and free it with DestroyExceptionInfo (Bug#11558).
1663
ef099b57
JB
16642012-07-13 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1667 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1668 Set here, not in nt/config.nt.
1669
ea814a5d
EZ
16702012-07-13 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1673 cursor overflow into the last glyph on display line when the right
1674 fringe is off. (Bug#11832)
1675
1a952767
PE
16762012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * xdisp.c (produce_special_glyphs): Now static.
1679 * dispextern.h (produce_special_glyphs): Remove decl.
1680
983188fd
GM
16812012-07-13 Glenn Morris <rgm@gnu.org>
1682
8d7c7eed 1683 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1684 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1685
983188fd
GM
1686 * s/usg5-4-common.h (USG, USG5):
1687 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1688 * s/sol2-6.h (SOLARIS2):
1689 * s/irix6-5.h (IRIX6_5):
1690 * s/hpux10-20.h (USG, USG5, HPUX):
1691 * s/gnu-linux.h (USG, GNU_LINUX):
1692 * s/freebsd.h (BSD_SYSTEM):
1693 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1694 * s/cygwin.h (CYGWIN):
1695 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1696 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1697
d1e68667 16982012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1699
1700 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1701
6de0e799
GM
17022012-07-13 Glenn Morris <rgm@gnu.org>
1703
739ae010
GM
1704 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1705
dbee5793
GM
1706 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1707
6de0e799
GM
1708 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1709 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1710
b82da769
GM
17112012-07-12 Glenn Morris <rgm@gnu.org>
1712
4fae5a7a 1713 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1714
1715 * process.c (init_process_emacs): Rename from init_process.
1716 The old name is also the name of a Mach system call.
1717 * lisp.h, emacs.c: Update for this name change.
1718 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1719 longer needed.
1720
5a979817
EZ
17212012-07-12 Eli Zaretskii <eliz@gnu.org>
1722
1723 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1724 memmove call that removes glyphs covered by the left truncation
1725 glyph. Improve commentary.
1726 (display_line): Fix display of continuation glyphs on GUI frames
1727 when the right fringe is turned off and variable-size fonts are
1728 used in the window. Move the code that appends a stretch glyph to
1729 produce_special_glyphs, so that it could be used for truncation
1730 and continuation glyphs alike.
1731 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1732 glyph of a suitably computed width, to align the special glyphs at
1733 the window margin. Code moved from display_line. (Bug#11832)
1734
3e91a053
GM
17352012-07-12 Glenn Morris <rgm@gnu.org>
1736
ba9e4b84
GM
1737 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1738
1739 * s/gnu-linux.h, s/hpux10-20.h:
1740 Do not unconditionally define HAVE_XRMSETDATABASE.
1741
3e91a053
GM
1742 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1743
b300b1f4
PE
17442012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Fix typos that broke OS X build.
1747 Reported by Randal L. Schwartz in
1748 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1749 * nsterm.m (ns_timeout): Add missing local decl.
1750 (ns_get_color): snprintf -> sprintf, to fix typo.
1751
6e777848
GM
17522012-07-12 Glenn Morris <rgm@gnu.org>
1753
3f922c37
GM
1754 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1755 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1756 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1757 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1758
0ab7b23a
GM
1759 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1760 Move PTY_OPEN to configure.
1761
6e777848
GM
1762 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1763 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1764 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1765
4a7edc24
DA
17662012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1767
1768 Use empty_unibyte_string where applicable.
1769 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1770 * lread.c (read1): Likewise.
1771 * xsettings.c (syms_of_xsettings): Likewise.
1772
308aab79
GM
17732012-07-12 Glenn Morris <rgm@gnu.org>
1774
42bd1719
GM
1775 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1776 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1777 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1778 * s/hpux10-20.h (RUN_TIME_REMAP):
1779 * s/bsd-common.h (TABDLY): Move to configure.
1780
1781 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1782
1783 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1784
ea0bbd17 1785 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1786 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1787
1788 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1789
308aab79
GM
1790 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1791 * s/template.h: Move NARROWPROTO to configure.
1792
ee1cf5cf
GM
17932012-07-11 Glenn Morris <rgm@gnu.org>
1794
30fe9bf4
GM
1795 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1796 unused since 2011-01-17 change to systty.h.
1797
ee1cf5cf
GM
1798 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1799 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1800 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1801
63e47e07
PE
18022012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1805
c43fb4c3
GM
18062012-07-11 Glenn Morris <rgm@gnu.org>
1807
1808 * s/darwin.h, s/gnu-linux.h, s/template.h:
1809 Move INTERRUPT_INPUT to configure.
1810
e8df9267
DA
18112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1812
1813 Minor adjustments to interning code.
1814 * lisp.h (intern, intern_c_string): Redefine as static inline
1815 wrappers for intern_1 and intern_c_string_1, respectively.
1816 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1817 * lread.c (intern_1, intern_c_string_1, oblookup):
1818 Simplify Vobarray checking.
e8df9267
DA
1819 * font.c (font_intern_prop): Likewise. Adjust comment.
1820 * w32font.c (intern_font_name): Likewise.
1821
34348bd4
AS
18222012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1823
d96a1e0c
AS
1824 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1825
34348bd4
AS
1826 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1827 of Fcar/Fcdr if possible.
1828 * font.c (check_otf_features): Likewise.
1829 * fontset.c (Fnew_fontset): Likewise.
1830 * gnutls.c (Fgnutls_boot): Likewise.
1831 * minibuf.c (read_minibuf): Likewise.
1832 * msdos.c (IT_set_frame_parameters): Likewise.
1833 * xmenu.c (Fx_popup_dialog): Likewise.
1834 * w32menu.c (Fx_popup_dialog): Likewise.
1835
c8add24e
GM
18362012-07-11 Glenn Morris <rgm@gnu.org>
1837
4b575b3c
GM
1838 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1839 since nothing has defined it on these platforms.
1840
09f4e3b0
GM
1841 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1842 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1843
172bedef
GM
1844 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1845 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1846 Move CLASH_DETECTION to configure.
1847
249685df
GM
1848 * s/gnu.h: Remove file, which is now empty.
1849
c8add24e
GM
1850 * s/gnu.h, s/gnu-linux.h:
1851 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1852
b41253a3
JW
18532012-07-11 John Wiegley <johnw@newartisans.com>
1854
1855 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1856 function attribute, so we only use it if it exists in the
1857 compiler.
1858
d923b542
DA
18592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1860
1861 Avoid call to strlen in fast_c_string_match_ignore_case.
1862 * search.c (fast_c_string_match_ignore_case): Change to use
1863 length argument. Adjust users accordingly.
1864 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1865
5ebbef1d
PE
18662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1867
bb352260
PE
1868 Assume mkdir, rmdir.
1869 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1870 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1871
57054ddd
PE
1872 Assume rename.
1873 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1874
b747d3f7
PE
1875 Assume perror.
1876 * s/hpux10-20.h (HAVE_PERROR): Remove.
1877 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1878 Remove dummy definition, as this problem was obsolete long ago.
1879
5ebbef1d
PE
1880 Assume strerror.
1881 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1882
984e7f30
DA
18832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1884
1885 Avoid calls to strlen in font processing functions.
1886 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1887 (font_open_by_name): Change to use length argument.
1888 Adjust users accordingly.
d923b542
DA
1889 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1890 Adjust prototypes.
1891 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1892 Change to return ptrdiff_t.
984e7f30
DA
1893 (xfont_list_pattern, xfont_match): Use length returned by
1894 xfont_decode_coding_xlfd.
1895 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1896
20e94fdd
GM
18972012-07-11 Glenn Morris <rgm@gnu.org>
1898
9d596af3
GM
1899 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1900 Move DONT_REOPEN_PTY to configure.
1901
20e94fdd
GM
1902 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1903 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1904
e99a530f
PE
19052012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1906
22ffb973
PE
1907 Remove "#define unix" that is no longer needed (Bug#11905).
1908 * s/aix4-2.h (unix): Remove; no longer needed.
1909
e9a9ae03
PE
1910 EMACS_TIME simplification (Bug#11875).
1911 This replaces macros (which typically do not work in GDB)
1912 with functions, typedefs and enums, making the code easier to debug.
1913 The functional style also makes code easier to read and maintain.
1914 * systime.h: Include <sys/time.h> on all hosts, not just if
1915 WINDOWSNT, since 'struct timeval' is needed in general.
1916 (EMACS_TIME): Now a typedef, not a macro.
1917 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1918 not macros.
1919 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1920 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1921 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1922 (EMACS_TIME_LE): Now functions, not macros.
1923 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1924 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1925 which are not functions. All uses rewritten to use:
1926 (make_emacs_time): New function.
1927 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1928 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1929 not functions. All uses rewritten to use the following, respectively:
1930 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1931 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1932 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1933 * fileio.c (Fcopy_file):
1934 * xterm.c (XTflash): Get the current time closer to when it's used.
1935 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1936
ffacb126
PE
1937 * bytecode.c (targets): Suppress -Woverride-init warnings.
1938
e99a530f
PE
1939 Simplify by avoiding confusing use of strncpy etc.
1940 * doc.c (Fsnarf_documentation):
1941 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1942 * frame.c (Fmake_terminal_frame):
1943 * gtkutil.c (get_utf8_string):
1944 * lread.c (openp):
1945 * nsmenu.m (ns_update_menubar):
1946 * regex.c (regerror):
1947 Prefer memcpy to strncpy and strncat when either will do.
1948 * fileio.c (Fsubstitute_in_file_name):
1949 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1950 (menu_separator_name_p):
1951 * nsmenu.m (ns_update_menubar):
1952 Prefer memcmp to strncmp when either will do.
1953 * nsterm.m: Include <ftoastr.h>.
1954 (ns_get_color):
1955 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1956 Prefer snprintf to strncpy.
1957 * nsterm.m (ns_term_init):
1958 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1959 * nsterm.m (ns_term_init):
1960 Avoid the need for strncpy, by using build_string or
1961 make_unibyte_string directly. Use dtoastr, not snprintf.
1962 * process.c (Fmake_network_process): Diagnose service names that
1963 are too long, rather than silently truncating them or creating
1964 non-null-terminated names.
1965 (Fnetwork_interface_info): Likewise, for interface names.
1966 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1967 Prefer sprintf to strncat.
1968 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1969 Prefer vsnprintf to vsprintf + strncpy.
1970
c59592b3
GM
19712012-07-10 Glenn Morris <rgm@gnu.org>
1972
1973 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1974 Clarify fallback case.
1975
7d7bbefd
DA
19762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1977
1978 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1979 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1980 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1981 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1982 where argument type is known to be a Lisp_Cons.
1983
3a4c8000
TT
19842012-07-10 Tom Tromey <tromey@redhat.com>
1985
1986 * bytecode.c (BYTE_CODE_THREADED): New macro.
1987 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1988 (enum byte_code_op): New type.
1989 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1990 (exec_byte_code): Use them. Use token threading when applicable.
1991
2a0213a6
DA
19922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 Optimize pure C strings initialization.
1995 * lisp.h (make_pure_string): Fix prototype.
1996 (build_pure_c_string): New function, defined as static inline. This
1997 provides a better opportunity to optimize away calls to strlen when
1998 the function is called with compile-time constant argument.
1999 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2000 argument, adjust users accordingly. Use build_pure_c_string where
2001 appropriate.
2002 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2003 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2004 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2005
cb1caeaf
DA
20062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 Avoid calls to strlen in miscellaneous functions.
2009 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2010 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2011 * lread.c (openp): Likewise.
2012
c293e30c
DA
20132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 Avoid calls to strlen in path processing functions.
2016 * fileio.c (file_name_as_directory): Add comment. Change to add
2017 srclen argument and return the length of result. Adjust users
2018 accordingly.
2019 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2020 swap 1st and 2nd arguments to obey the common convention.
2021 Adjust users accordingly.
c293e30c
DA
2022 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2023
9e059e3f
GM
20242012-07-10 Glenn Morris <rgm@gnu.org>
2025
d02eb359
GM
2026 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2027 Move PENDING_OUTPUT_COUNT definition to configure.
2028
882cf227
GM
2029 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2030 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2031 * s/gnu.h (DATA_START): Move definitions to configure.
2032
af6e839f
GM
2033 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2034 We include usg5-4-common.h, which defines them both.
2035
40289a12
GM
2036 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2037 O_RDONLY already includes it).
2038
9e059e3f
GM
2039 Stop ns builds setting the EMACSLOADPATH environment variable.
2040 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2041 Now it does not set EMACSLOADPATH, just returns the load-path string.
2042 * nsterm.h: Update accordingly.
2043 * lread.c [HAVE_NS]: Include nsterm.h.
2044 (init_lread) [HAVE_NS]: Use ns_load_path.
2045 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2046
7c4e8ec0
GM
20472012-07-09 Glenn Morris <rgm@gnu.org>
2048
d4f600ff
GM
2049 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2050 since the included bsd-common.h does so.
2051
cbb31951
GM
2052 Stop ns builds setting the EMACSPATH environment variable.
2053 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2054 (ns_init_paths): Do not set EMACSPATH.
2055 * nsterm.h (ns_exec_path): Add it.
2056 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2057 Use ns_exec_path.
2058
7c4e8ec0
GM
2059 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2060
26bccfae
PE
20612012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2062
a0bee46f
PE
2063 * process.c (wait_reading_process_output): 'waitchannels' was unset
2064 when read_kbd || !NILP (wait_for_cell); fix this.
2065
5994c183
PE
2066 Add GCC-style 'const' attribute to functions that can use it.
2067 * character.h (char_resolve_modifier_mask):
2068 * keyboard.h (make_ctrl_char):
2069 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2070 (init_character_once, next_almost_prime, init_fns, init_image)
2071 (flush_pending_output, init_sound):
2072 * mem-limits.h (start_of_data):
2073 * menu.h (finish_menu_items):
2074 Add ATTRIBUTE_CONST.
2075 * emacs.c (DEFINE_DUMMY_FUNCTION):
2076 Declare the dummy function with ATTRIBUTE_CONST.
2077 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2078 Add decls with ATTRIBUTE_CONST.
2079
26bccfae
PE
2080 Minor improvements to make_formatted_string.
2081 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2082 where int is good enough, as vsprintf returns an int.
2083 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2084
a8290ec3
DA
20852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 Use make_formatted_string to avoid double length calculation.
2088 * lisp.h (make_formatted_string): New prototype.
2089 * alloc.c (make_formatted_string): New function.
2090 * buffer.c (Fgenerate_new_buffer_name): Use it.
2091 * dbus.c (syms_of_dbusbind): Likewise.
2092 * editfns.c (Fcurrent_time_zone): Likewise.
2093 * filelock.c (get_boot_time): Likewise.
2094 * frame.c (make_terminal_frame, set_term_frame_name)
2095 (x_report_frame_params): Likewise.
2096 * image.c (gs_load): Likewise.
2097 * minibuf.c (get_minibuffer): Likewise.
2098 * msdos.c (dos_set_window_size): Likewise.
2099 * process.c (make_process): Likewise.
2100 * xdisp.c (ensure_echo_area_buffers): Likewise.
2101 * xsettings.c (apply_xft_settings): Likewise.
2102
d01ba2f1
GM
21032012-07-09 Glenn Morris <rgm@gnu.org>
2104
2105 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2106 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2107 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2108 * nsterm.h (ns_etc_directory): Add it.
2109 * callproc.c [HAVE_NS]: Include nsterm.h.
2110 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2111
f1f924b6
DA
21122012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2113
2114 Move marker debugging code under MARKER_DEBUG.
2115 * marker.c (MARKER_DEBUG): Move marker debugging code under
2116 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2117 for bootstrap with --enable-checking (~3x slowdown reported
2118 by Juanma Barranquero <lekktu@gmail.com>).
2119 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2120
ab531b66
PE
21212012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2124 See <http://bugs.gnu.org/11825#29>.
2125
c4b3bc8a
EZ
21262012-07-08 Eli Zaretskii <eliz@gnu.org>
2127
2128 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2129 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2130 (display_line): Add commentary about displaying truncation glyphs
2131 on GUI frames.
2132 (produce_special_glyphs): Move here from term.c.
2133
2134 * term.c (produce_special_glyphs): Move to xdisp.c.
2135
2136 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2137 section.
c4b3bc8a 2138
b676b881
AS
21392012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2140
f17c5273
AS
2141 * xdisp.c (display_line): Avoid warning about implicit declaration
2142 of FRAME_FONT.
2143
298819b9
AS
2144 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2145
b676b881
AS
2146 * lisp.h: Remove empty conditional.
2147
6045c4fd
PE
21482012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2149
b3350bf9
PE
2150 * lread.c (load_path_check): Now static.
2151
6045c4fd
PE
2152 Fix some minor --with-ns problems found by static checking.
2153 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2154 (x_set_font) [!HAVE_X_WINDOWS]:
2155 * image.c (xpm_load_image) [HAVE_NS]:
2156 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2157 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2158 Remove unused local.
2159 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2160 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2161 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2162 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2163 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2164 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2165 Fix pointer signedness problem.
2166 * xfaces.c (FRAME_X_FONT_TABLE):
2167 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2168
929e7845
GM
21692012-07-07 Glenn Morris <rgm@gnu.org>
2170
2171 * lread.c (load_path_check): New function, split from init_lread.
2172 (init_lread): Reorganize. Motivation:
2173 If EMACSLOADPATH is set, check/warn about that rather than the
2174 defaults, which we are not going to use. Hence we can remove
2175 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2176 Don't warn if site-lisp directories are missing.
2177 If not installed, start from a blank load-path, since
2178 PATH_LOADSEARCH refers to the eventual installation directories.
2179
58dd0aa4
EZ
21802012-07-07 Eli Zaretskii <eliz@gnu.org>
2181
2182 Support truncation and continuation glyphs on GUI frames, when
2183 fringes are disabled. (Bug#11832)
2184 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2185 continuation glyphs even if on GUI frames.
2186 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2187 or both, are absent.
2188 (start_display, move_it_in_display_line_to): Handle the case of a
2189 GUI frame without a fringe to display continuation or truncation
2190 glyphs.
2191 (insert_left_trunc_glyphs): Support GUI frames: make sure
2192 truncation glyphs overwrite enough glyphs from the current line to
2193 have sufficient space in pixels.
2194 (display_line): Support truncation and continuation glyphs on GUI
2195 frames. If some spare pixels are left on the line after inserting
2196 the truncation glyphs, fill that space with a stretch glyph of a
2197 suitably computed width.
2198
2199 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2200 produce_glyphs, to support GUI sessions.
2201
31571fd7
PE
22022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2203
5a16b9bc
PE
2204 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2205
f3047c75
PE
2206 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2207
31571fd7
PE
2208 Do not require float-time's arg to fit in time_t (Bug#11825).
2209 This works better on hosts where time_t is unsigned, and where
2210 float-time is applied to the (negative) difference between two times.
2211 * editfns.c (decode_time_components): Last arg is now double *,
2212 not int *, and means to store all the result as a double, without
2213 worrying about whether the seconds part fits in time_t.
2214 All callers changed.
2215 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2216 All callers changed.
2217 (Ffloat_time): Do not fail merely because the specified time falls
2218 outside of time_t range.
2219
4516fbef
GM
22202012-07-07 Glenn Morris <rgm@gnu.org>
2221
2222 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2223 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2224 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2225
07adc2c6
JB
22262012-07-07 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2229 Update dependencies.
2230
2231 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2232
fd573f31
PE
22332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2234
fee5959d
PE
2235 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2236 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2237 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2238 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2239 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2240 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2241
fd573f31
PE
2242 * xfont.c (compare_font_names): Redo to omit the need for casts.
2243
ddadbc0e
AS
22442012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2245
fca8d6b6
AS
2246 * xfns.c (Fx_change_window_property): Doc fix.
2247 * w32fns.c (Fx_change_window_property): Doc fix.
2248
ddadbc0e
AS
2249 * w32fns.c (Fx_window_property): Accept the same arguments as the
2250 X Windows version. Doc fix.
2251 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2252
ed9265fc 22532012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2254 Eli Zaretskii <eliz@gnu.org>
2255
2256 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2257 Windows-specific code from nt/config.nt moved here.
2258 Obsolete settings removed.
2259
216ee680
PE
22602012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * process.c: Avoid unnecessary calls to gettime.
2263 (wait_reading_process_output): Don't get the time of day
2264 when gobbling data immediately and not waiting, as there's no need
2265 for it in that case. This removes a FIXME.
2266
bdd091e4
JD
22672012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2268
2269 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2270 is defined (Bug#11768).
2271
9d44f8ce
DA
22722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2273
2274 Fix marker debugging code.
2275 * marker.c (byte_char_debug_check): Do not perform the check
2276 if buffer is not multibyte.
090bd7cb
JB
2277 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2278 Call byte_char_debug_check with correct arguments.
9d44f8ce 2279
90fc4786
DA
22802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2281
2282 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2283 * marker.c (byte_char_debug_check, count_markers):
2284 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2285 (byte_debug_flag): Remove.
2286 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2287 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2288
7b7ae965
DA
22892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2290
4e57b342
DA
2291 Avoid code repetition in marker-related functions.
2292 * marker.c (attach_marker): New function.
2293 (Fset_marker, set_marker_restricted, set_marker_both)
2294 (set_marker_restricted_both): Use it.
2295 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2296 Consistently rename charno to charpos.
2297 (marker_position): Add eassert.
2298 (marker_byte_position): Convert to eassert.
2299
23002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2301
2302 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2303 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2304 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2305
657924ff
DA
23062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Introduce fast path for the widely used marker operation.
2309 * alloc.c (build_marker): New function.
2310 * lisp.h (build_marker): New prototype.
2311 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2312 * composite.c (autocmp_chars): Likewise.
2313 * editfns.c (buildmark): Remove.
2314 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2315 (save_restriction_save): Use build_marker.
2316 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2317 * window.c (save_window_save): Likewise.
2318
041a49a6
DA
23192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2320
2321 Do not use Fdelete_overlay in delete_all_overlays
2322 to avoid redundant calls to unchain_overlay.
2323 * buffer.c (drop_overlay): New function.
2324 (delete_all_overlays, Fdelete_overlay): Use it.
2325 * minibuf.c (get_minibuffer): Fix comment.
2326
7dca65a4
PE
23272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Port to OpenBSD 5.1 amd64.
2330 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2331 This is needed for OpenBSD, and should be harmless on all BSD systems.
2332 Also, include <sys/sysctl.h>, as it should be available on all
2333 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2334 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2335 use p_pid member, not kp_proc.pid.
2336
8eb876e2
GM
23372012-07-06 Glenn Morris <rgm@gnu.org>
2338
2339 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2340
38182d90
PE
23412012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 More xmalloc and related cleanup.
2344 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2345 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2346 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2347 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2348 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2349 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2350 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2351 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2352 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2353 * xterm.c:
2354 Omit needless casts involving void * pointers and allocation.
2355 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2356 as the former is more robust if P's type is changed.
2357 Prefer xzalloc to xmalloc + memset 0.
2358 Simplify malloc-or-realloc to realloc.
2359 Don't worry about xmalloc returning a null pointer.
2360 Prefer xstrdup to xmalloc + strcpy.
2361 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2362 growing it.
2363 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2364 alloca of a constant.
2365
6dd5a677
EZ
23662012-07-05 Eli Zaretskii <eliz@gnu.org>
2367
2368 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2369 hscroll is larger than the line width. Fixes long and futile
2370 looping inside extend_face_to_end_of_line (on a TTY) producing
2371 glyphs that are not needed and thrown away.
2372
6b312f0f
DA
23732012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 * marker.c (set_marker_restricted_both): Simplify by using
2376 clip_to_bounds.
2377
f520ef9b
PE
23782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2381
383b7c95
JD
23822012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2383
2384 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2385 not defined (Bug#11768).
2386 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2387 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2388 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2389 followed by gtk_box_set_homogeneous (Bug#11768).
2390 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2391 (update_theme_scrollbar_width, xg_create_scroll_bar):
2392 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2393 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2394 (is_box_type): New function (Bug#11768).
2395 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2396 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2397 with default display (Bug#11768).
2398
d6e7bf45
EZ
23992012-07-05 Eli Zaretskii <eliz@gnu.org>
2400
2401 * xdisp.c (window_hscroll_limited): New function.
2402 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2403 coordinates when window's hscroll is set to insanely large
2404 values. (Bug#11857)
2405
431391ec
JB
24062012-07-05 Juanma Barranquero <lekktu@gmail.com>
2407
2408 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2409 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2410
23f86fce
DA
24112012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2412
2413 Cleanup xmalloc.
2414 * lisp.h (xzalloc): New prototype. Omit needless casts.
2415 * alloc.c (xzalloc): New function. Omit needless casts.
2416 * charset.c: Omit needless casts. Convert all calls to
2417 xmalloc with following memset to xzalloc.
2418 * dispnew.c: Likewise.
2419 * fringe.c: Likewise.
2420 * image.c: Likewise.
2421 * sound.c: Likewise.
2422 * term.c: Likewise.
2423 * w32fns.c: Likewise.
2424 * w32font.c: Likewise.
2425 * w32term.c: Likewise.
2426 * xfaces.c: Likewise.
2427 * xfns.c: Likewise.
2428 * xterm.c: Likewise.
2429 * atimer.c: Omit needless casts.
2430 * buffer.c: Likewise.
2431 * callproc.c: Likewise.
2432 * ccl.c: Likewise.
2433 * coding.c: Likewise.
2434 * composite.c: Likewise.
2435 * doc.c: Likewise.
2436 * doprnt.c: Likewise.
2437 * editfns.c: Likewise.
2438 * emacs.c: Likewise.
2439 * eval.c: Likewise.
2440 * filelock.c: Likewise.
2441 * fns.c: Likewise.
2442 * gtkutil.c: Likewise.
2443 * keyboard.c: Likewise.
2444 * lisp.h: Likewise.
2445 * lread.c: Likewise.
2446 * minibuf.c: Likewise.
2447 * msdos.c: Likewise.
2448 * print.c: Likewise.
2449 * process.c: Likewise.
2450 * region-cache.c: Likewise.
2451 * search.c: Likewise.
2452 * sysdep.c: Likewise.
2453 * termcap.c: Likewise.
2454 * terminal.c: Likewise.
2455 * tparam.c: Likewise.
2456 * w16select.c: Likewise.
2457 * w32.c: Likewise.
2458 * w32reg.c: Likewise.
2459 * w32select.c: Likewise.
2460 * w32uniscribe.c: Likewise.
2461 * widget.c: Likewise.
2462 * xdisp.c: Likewise.
2463 * xmenu.c: Likewise.
2464 * xrdb.c: Likewise.
2465 * xselect.c: Likewise.
2466
0497dc44
PE
24672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * fileio.c (time_error_value): Check the right error number.
2470 Problem reported by Troels Nielsen in
2471 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2472
356e7178
PE
24732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2474
4e71fd89
PE
2475 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2476 This should be fixed in a better way; see Eli Zaretskii in
2477 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2478 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2479
f0941253
PE
2480 * fileio.c (time_error_value): Rename from special_mtime.
2481 The old name's problems were noted by Eli Zaretskii in
2482 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2483
065c9eb4
PE
2484 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2485 This variable's comment says Emacs needs at least one GDB-visible
2486 symbol of type enum pvec_type, to work around GDB problems.
2487 The symbol's value doesn't matter.
2488
356e7178
PE
2489 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2490 that causes compilation to fail on pre-C99 compilers.
2491
ed9265fc 24922012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2493
2494 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2495 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2496
3884d954
DA
24972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2498
d209e2fb 2499 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2500 headers for buffer_defaults and buffer_local_symbols.
2501 Reported by Juanma Barranquero <lekktu@gmail.com>.
2502
ee28be33
SM
25032012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2504
2505 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2506 * lisp.h (enum pvec_type): Use fewer bits.
2507 (PSEUDOVECTOR_SIZE_BITS): New constant.
2508 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2509 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2510 change in pvec_type.
2511 (PSEUDOVECTOR_TYPEP): New macro.
2512 (TYPED_PSEUDOVECTORP): Use it.
2513 * fns.c (internal_equal): Adapt code to extract pvectype.
2514 * emacs.c (gdb_pvec_type): Update type.
2515 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2516 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2517 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2518 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2519 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2520 abusing vector->header.next.nbytes.
2521 (live_vector_p): Use PVEC_TYPE.
2522 (mark_object): Adapt code to extract pvectype. Use switch.
2523
c7f2cd7f
PE
25242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2527 Tighten new eassert a bit.
2528
8ce70ed2
DA
25292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2530
2531 Fix compilation with --enable-gcc-warnings and -O1
2532 optimization level.
2533 * doprnt.c (doprnt): Change type of tem to int, initialize
2534 to avoid compiler warning. Add eassert.
2535 * search.c (simple_search): Initialize match_byte to avoid
2536 compiler warning. Add eassert.
2537
dea7f1e5
PE
25382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2539
24a212eb
PE
2540 Avoid weird behavior with large horizontal scrolls.
2541 Without this change, for example, large hscroll values would
2542 mess up Emacs's display on Fedora 15 x86, presumably due to
2543 overflows in int calculations in the display code.
2544 Also, if buffers had long lines, Emacs would freeze.
2545 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2546 (set_window_hscroll): New function, containing the old guts of
2547 Fset_window_hscroll. Return the clipped value.
2548 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2549 This avoids the need to check against PTRDIFF_MAX.
2550
dea7f1e5
PE
2551 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2552
76046526
DA
25532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2554
2555 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2556
39adff0d
PE
25572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2558
63807d47
PE
2559 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2560 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2561 since GCC 4.4.6 issues a bogus warning for them.
2562
39adff0d
PE
2563 Fix bugs in file timestamp newness comparisons.
2564 * fileio.c (Ffile_newer_than_file_p):
2565 * lread.c (Fload): Use full timestamp resolution of files,
2566 not just the 1-second resolution, so that files that are only
2567 slightly newer still count as newer.
2568 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2569 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2570
dbeed9a6
PE
25712012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 * fileio.c: Improve handling of file time marker. (Bug#11852)
2574 (special_mtime): New function.
2575 (Finsert_file_contents, Fverify_visited_file_modtime):
2576 Use it to set special mtime values consistently.
2577
636334d6
AS
25782012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2579
2580 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2581 marker for non-existing file. (Bug#11852)
2582
e2017fe2
GM
25832012-07-03 Glenn Morris <rgm@gnu.org>
2584
2585 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2586 and did not make it into globals.h).
2587
404dbd37
TT
25882012-07-03 Tom Tromey <tromey@redhat.com>
2589
2590 * window.c (Fset_window_margins, Fset_window_fringes)
2591 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2592 * textprop.c (Fprevious_property_change): No longer static.
2593 * syntax.c (Fsyntax_table_p): No longer static.
2594 * process.c (Fget_process, Fprocess_datagram_address): No longer
2595 static.
2596 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2597 * keyboard.c (Fcommand_execute): No longer static.
2598 Remove EXFUN.
2599 * insdel.c (Fcombine_after_change_execute): No longer static.
2600 * image.c (Finit_image_library): No longer static.
2601 * fileio.c (Fmake_symbolic_link): No longer static.
2602 * eval.c (Ffetch_bytecode): No longer static.
2603 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2604 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2605 No longer static.
404dbd37
TT
2606 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2607 static.
2608 * dired.c (Ffile_attributes): No longer static.
2609 * composite.c (Fcomposition_get_gstring): No longer static.
2610 * callproc.c (Fgetenv_internal): No longer static.
2611
2612 * ccl.h: Remove EXFUNs.
2613 * buffer.h: Remove EXFUNs.
2614 * dispextern.h: Remove EXFUNs.
2615 * intervals.h: Remove EXFUNs.
2616 * fontset.h: Remove EXFUN.
2617 * font.h: Remove EXFUNs.
2618 * dosfns.c (system_process_attributes): Remove EXFUN.
2619 * keymap.h: Remove EXFUNs.
2620 * lisp.h: Remove EXFUNs.
2621 * w32term.h: Remove EXFUNs.
2622 * window.h: Remove EXFUNs.
2623 * xsettings.h: Remove EXFUN.
2624 * xterm.h: Remove EXFUN.
2625
8e4fd1e1
GM
26262012-07-03 Glenn Morris <rgm@gnu.org>
2627
2628 * lisp.h (Frandom): Make it visible to C.
2629 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2630 buffer for invisible buffers. (Bug#1229)
2631
ca95b3eb
DA
26322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2633
2634 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2635 values which aren't power of 2.
14ae4239
BT
2636 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2637 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2638 accordingly.
2639
7555c33f
SM
26402012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2641
2642 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2643
2644 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2645
d12e8f5a
DA
26462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 * alloc.c (allocate_vector_block): Remove redundant
2649 calls to mallopt if DOUG_LEA_MALLOC is defined.
2650 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2651 avoid calls to mallopt if zero_vector is returned.
2652
296094c3
DA
26532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2654
2655 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2656 is enabled, avoid dereferencing NULL current_sblock if
2657 running undumped.
2658
36429c89
DA
26592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2660
2661 Cleanup basic buffer management.
2662 * buffer.h (struct buffer): Change layout to use generic vector
2663 marking code. Fix some comments. Change type of 'clip_changed'
2664 to bitfield. Remove unused #ifndef old.
2665 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2666 (GET_OVERLAYS_AT): Fix indentation.
2667 (for_each_per_buffer_object_at): New macro.
2668 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2669 (Fbuffer_local_variables): Use it.
2670 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2671 * alloc.c (allocate_buffer): Adjust to match new layout of
2672 struct buffer. Fix comment.
2673 (mark_overlay): New function.
2674 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2675 Lisp area of struct buffer.
2676 (mark_object): Use it. Adjust marking of misc objects
2677 and related comments.
2678
3b3e4cac
PE
26792012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2682 wrapper that is not needed because the wrapped code is a no-op (zero
2683 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2684 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2685
cf5c0175
DA
26862012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2687
2688 * alloc.c (mark_buffer): Simplify. Remove prototype.
2689 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2690 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2691 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2692 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2693
ca26824c
GM
26942012-06-30 Glenn Morris <rgm@gnu.org>
2695
2e4c5312
GM
2696 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2697
ca26824c
GM
2698 * epaths.in (PATH_SITELOADSEARCH): New.
2699 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2700 This is rather than relying on --enable-locallisppath elements
2701 having "site-lisp" in their names. (Bug#10208#25, 11658)
2702
0d23c240
EZ
27032012-06-30 Eli Zaretskii <eliz@gnu.org>
2704
c9240d7a
EZ
2705 * w32proc.c (sys_select): Accept and ignore one more argument.
2706
2707 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2708
0d23c240 2709 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2710 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2711
2712 * sysdep.c: Don't include dos.h and dosfns.h.
2713
2714 * process.c (sys_select):
2715 * msdos.c (sys_select): Accept one more argument and ignore it.
2716
2717 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2718 adapt data types and code to that.
2719
2720 * dosfns.c:
2721 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2722 which clashes with the gnulib function of the same name.
2723
af5a5a98
AS
27242012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2725
c5e4379c
AS
2726 * font.c (font_style_to_value, font_style_symbolic)
2727 (font_prop_validate_style): Add type checks for values in
2728 font_style_table.
2729
af5a5a98
AS
2730 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2731 argument.
2732 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2733 uses.
2734
8d38f461
EZ
27352012-06-29 Eli Zaretskii <eliz@gnu.org>
2736
2e5a6631
EZ
2737 * xdisp.c (try_window_id): Undo last change.
2738
8d38f461
EZ
2739 * w32.c (getwd): Adjust commentary about startup_dir.
2740 (init_environment): Always call sys_access, even in non-MSVC
2741 builds. Don't chdir to the directory of the Emacs executable.
2742 This undoes code from 1997 which was justified by the need to
2743 "avoid conflicts when removing and renaming directories". But its
2744 downside was that every relative file name was being interpreted
2745 relative to the directory of the Emacs executable, which can never
2746 be TRT. In particular, it broke sys_access when called with
2747 relative file names.
2748 (sys_access): Map GetLastError to errno.
2749
2af3565e
DA
27502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2751
2752 * window.h (struct window): Change type of 'fringes_outside_margins'
2753 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2754 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2755 Adjust comment.
2756 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2757 to ptrdiff_t.
2758
c8d3a25c 27592012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2760
c8d3a25c
GM
2761 * gnutls.c (emacs_gnutls_handshake):
2762 Add QUIT to make the loop interruptible.
57570cd3 2763
c8d3a25c 27642012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2765
c8d3a25c
GM
2766 * charset.c (init_charset): Make lack of etc/charsets fatal.
2767
3e984ee8
DA
27682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2769
2770 * editfns.c (region_limit): Fix type mismatch.
2771
ef884f23
DA
27722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2773
2774 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2775 undefined. Convert from xassert to eassert.
2776 * nsmenu.m: Convert from xassert to eassert.
2777 * nsterm.m: Likewise.
2778
7d7e0027
SM
27792012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2780
2781 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2782
aa754e6a
PE
27832012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 Avoid integer overflow on scroll-left and scroll-right.
2786 * window.c (HSCROLL_MAX): New macro.
2787 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2788 overflow when requested scroll falls outside ptrdiff_t range.
2789
80b00b08
DA
27902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2791
2792 * window.h (struct window): Change type of 'hscroll',
2793 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2794 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2795 Adjust users accordingly.
2796 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2797 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2798 from EMACS_INT to ptrdiff_t.
2799 (make_window): Omit redundant initialization.
2800
62b2bcf6
JB
28012012-06-28 Juanma Barranquero <lekktu@gmail.com>
2802
2803 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2804
45942c7d
DA
28052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2806
2807 * window.h (struct window): Change type of 'use_time' and
2808 'sequence_number' from Lisp_Object to int.
2809 * frame.c (make_frame): Adjust users accordingly.
2810 * print.c (print_object): Likewise.
2811 * window.c (select_window, Fwindow_use_time, make_parent_window)
2812 (make_window): Likewise.
2813
e509cfa6
DA
28142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2815
2816 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2817 enabled with --enable-checking=[all,glyphs] configure option.
2818 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2819 adjust comments accordingly.
2820 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2821 undefined, adjust comments accordingly.
2822 * image.c: Likewise.
2823 * scroll.c: Likewise.
2824 * w32fns.c: Likewise.
2825 * w32term.c: Likewise.
2826 * xdisp.c: Likewise.
2827 * xfaces.c: Likewise.
2828 * xfns.c: Likewise.
2829 * xterm.c: Likewise.
2830
a54e2c05
DA
28312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2832
2833 Generalize run-time debugging checks.
2834 * dispextern.h (XASSERTS): Remove.
2835 * fontset.c (xassert): Remove.
2836 Convert from xassert to eassert.
2837 * alloc.c: Convert from xassert to eassert.
2838 * bidi.c: Likewise.
2839 * dispnew.c: Likewise.
2840 * fns.c: Likewise.
2841 * fringe.c: Likewise.
2842 * ftfont.c: Likewise.
2843 * gtkutil.c: Likewise.
2844 * image.c: Likewise.
2845 * keyboard.c: Likewise.
2846 * menu.c: Likewise.
2847 * process.c: Likewise.
2848 * scroll.c: Likewise.
2849 * sound.c: Likewise.
2850 * term.c: Likewise.
2851 * w32console.c: Likewise.
2852 * w32fns.c: Likewise.
2853 * w32term.c: Likewise.
2854 * window.c: Likewise.
2855 * xdisp.c: Likewise.
2856 * xfaces.c: Likewise.
2857 * xfns.c: Likewise.
2858 * xselect.c: Likewise.
2859 * xterm.c: Likewise.
2860
1ec4b7b2
SM
28612012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2862
2863 * fns.c (maybe_resize_hash_table): Output message when growing the
2864 purify-hashtable.
2865
2014308a
DA
28662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2867
2868 * alloc.c (allocate_string_data): Remove dead code.
2869 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2870 avoid GCC warning about unused macro.
2871
246155eb
DA
28722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2873
2874 * alloc.c (allocate_string): Omit intervals initialization.
2875 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2876 as in make_pure_string and make_pure_c_string.
2877
43184b7b
DA
28782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2879
d209e2fb 2880 * alloc.c (allocate_string): Fix last change.
43184b7b 2881
3fe6dd74
DA
28822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2883
d209e2fb 2884 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2885 to memset, add explicit initialization where appropriate.
2886
1ba6038a
GM
28872012-06-27 Glenn Morris <rgm@gnu.org>
2888
2889 * lisp.mk (lisp): Remove paths.elc.
2890
c89926a5
CY
28912012-06-27 Chong Yidong <cyd@gnu.org>
2892
2893 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2894
ed6b3510
JW
28952012-06-26 John Wiegley <johnw@newartisans.com>
2896
1ec4b7b2 2897 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2898 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2899
ed6b3510
JW
2900 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2901 when building with Clang.
2902
8edd4a2b
SM
29032012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2904
2905 * eval.c (Fapply): Allow calling it with a single argument.
2906
f6f62d1b
EZ
29072012-06-26 Eli Zaretskii <eliz@gnu.org>
2908
2909 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2910 _stricmp and _strnicmp.
2911 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2912
62efea5e
DA
29132012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2914
2915 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2916 allocated window.
2917 (allocate_process): Likewise for new process.
8edd4a2b 2918 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2919 (allocate_frame): Likewise.
2920 * frame.c (make_frame): Omit redundant initialization.
2921 * window.c (make_parent_window): Use memset.
2922 (make_window): Omit redundant initialization.
2923 * process.c (make_process): Omit redundant initialization.
2924 * terminal.c (create_terminal): Likewise.
2925
42997f4d
DA
29262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 * term.c (delete_tty): Remove redundant call to memset.
2929
1130ecfc
DA
29302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2931
2932 * alloc.c: Remove build_string.
2933 * lisp.h: Define build_string as static inline. This provides
2934 a better opportunity to optimize away calls to strlen when the
2935 function is called with compile-time constant argument.
2936 * image.c (imagemagick_error): Convert to build_string.
2937 * w32proc.c (sys_spawnve): Likewise.
2938 * xterm.c (x_term_init): Likewise.
2939
cf38a720
PE
29402012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2941
99027bdd
PE
2942 Use sprintf return value instead of invoking strlen on result.
2943 In the old days this wasn't portable, since some sprintf
2944 implementations returned char *. But they died out years ago and
2945 Emacs already assumes sprintf returns int.
2946 Similarly for float_to_string.
2947 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2948 * ccl.c (ccl_driver):
2949 * character.c (string_escape_byte8):
2950 * data.c (Fnumber_to_string):
2951 * doprnt.c (doprnt):
2952 * print.c (print_object):
2953 * xdisp.c (message_dolog):
2954 * xfns.c (syms_of_xfns):
2955 Use sprintf or float_to_string result to avoid need to call strlen.
2956 * data.c (Fnumber_to_string):
2957 Use make_unibyte_string, since the string must be ASCII.
2958 * lisp.h, print.c (float_to_string): Now returns int length.
2959 * term.c (produce_glyphless_glyph):
2960 Use sprintf result rather than recomputing it.
2961
cf38a720
PE
2962 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2963 * Makefile.in (ALL_CFLAGS):
2964 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2965 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2966
3511c784
DA
29672012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2968
0a08eb21 2969 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2970 strcasecmp if available.
2971 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2972
fb7da12e
AS
29732012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2974
2975 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2976 Avoid comma operator.
2977 * menu.c (push_submenu_start, push_submenu_end)
2978 (push_left_right_boundary, push_menu_pane): Likewise.
2979 * msdos.c (dos_rawgetc): Likewise.
2980
afa2ffd8
DA
29812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2982
2983 * xfns.c (xic_create_fontsetname): Remove redundant calls
2984 to memset.
2985
b3b4476b
PE
29862012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2987
4495ff38
PE
2988 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2989 sprintf already null-terminates its output.
2990
b3b4476b
PE
2991 * xfns.c (x_window): Remove redundant cast.
2992
b00876c9
DA
29932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2994
2995 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2996 `const char *' to `char *' to avoid compiler warning.
2997
d188e26b
PE
29982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2999
885d1d74
PE
3000 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3001 instead of truncating it to 63 (admittedly a generous limit).
3002
d188e26b
PE
3003 * process.c: Fix spelling and caps in comments.
3004
e2f560b1
DN
30052012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3006
e86db54b 3007 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3008 * sysdep.c (setpgrp): Remove definition, not used in this file.
3009
7583a3a1
JB
30102012-06-24 Juanma Barranquero <lekktu@gmail.com>
3011
3012 * makefile.w32-in: Update dependencies.
3013
696056c2
EZ
30142012-06-24 Eli Zaretskii <eliz@gnu.org>
3015
3016 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3017 (SYSTIME_H): Add nt/inc/sys/time.h.
3018
3019 * systime.h [WINDOWSNT]: Include sys/time.h.
3020
3021 * s/ms-w32.h (struct timespec): Definition moved from
3022 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3023
845ca893
PE
30242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3027 * buffer.h (buffer_slot_type_mismatch):
3028 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3029 * eval.c (unwind_to_catch):
3030 * image.c (my_png_error, my_error_exit):
3031 * keyboard.c (quit_throw_to_read_char, user_error)
3032 (Fexit_recursive_edit, Fabort_recursive_edit):
3033 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3034 (wrong_type_argument, buffer_overflow, __executable_start)
3035 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3036 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3037 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3038 (fatal):
3039 (child_setup) [!DOS_NT]:
3040 * lread.c (end_of_file_error, invalid_syntax):
3041 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3042 * puresize.h (pure_write_error):
3043 * search.c (matcher_overflow):
3044 * sound.c (sound_perror, alsa_sound_perror):
3045 * sysdep.c, syssignal.h (croak):
3046 * term.c (maybe_fatal, vfatal):
3047 * textprop.c (text_read_only):
3048 * undo.c (user_error):
3049 * unexmacosx.c (unexec_error):
3050 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3051 Use _Noreturn rather than NO_RETURN.
3052 No need for separate decl merely because of _Noreturn.
3053 * sound.c (sound_warning, parse_sound):
3054 Remove unnecessary forward decls.
3055
f1dd8073
PE
30562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3059 * lisp.h (WAIT_READING_MAX): New macro.
3060 * dispnew.c (Fsleep_for, sit_for):
3061 * keyboard.c (kbd_buffer_get_event):
3062 * process.c (Faccept_process_output):
3063 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3064 This improves on the previous patch, which introduced a bug
3065 when time_t is unsigned and as wide as intmax_t.
3066 See <http://bugs.gnu.org/9000#51>.
3067
b82c1755
EZ
30682012-06-23 Eli Zaretskii <eliz@gnu.org>
3069
3070 * dispnew.c (sit_for, Fsleep_for):
3071 * keyboard.c (kbd_buffer_get_event):
3072 * process.c (Faccept_process_output): Avoid compiler warnings when
3073 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3074
ca300656
JB
30752012-06-23 Juanma Barranquero <lekktu@gmail.com>
3076
049ec95b
JB
3077 * makefile.w32-in: Update dependencies.
3078
ca300656
JB
3079 * w32.c (ltime): Add return type and declare static.
3080 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3081
db7b8d06
PE
30822012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3085 Privately reported by Herbert J. Skuhra.
3086 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3087 All uses changed.
3088 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3089 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3090
0bd8297f
EZ
30912012-06-23 Eli Zaretskii <eliz@gnu.org>
3092
96512555
EZ
3093 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3094 last argument of make_unibyte_string.
3095
0bd8297f
EZ
3096 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3097 language ID in the event parameters.
3098
3099 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3100 event.code, not the obscure "character set ID".
3101
63def6b6
CY
31022012-06-23 Chong Yidong <cyd@gnu.org>
3103
3104 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3105
e8a02204
EZ
31062012-06-23 Eli Zaretskii <eliz@gnu.org>
3107
388cdec0
EZ
3108 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3109 * w32.c (fdutimens): New function.
3110
3111 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3112
3113 * s/ms-w32.h (pselect): Redirect to sys_select.
3114
3115 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3116
e8a02204
EZ
3117 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3118 in the logic of incrementing and decrementing the value of
3119 use_relocatable_buffers.
3120
d054f3fb
PE
31212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3124 Privately reported by Herbert J. Skuhra.
3125 [__FreeBSD__]: Remove "*/" typo after "#include".
3126 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3127 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3128 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3129 Don't assume EMACS_TIME and struct timeval are the same type.
3130
d35af63c
PE
31312012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Support higher-resolution time stamps (Bug#9000).
3134 The time stamps are only nanosecond-resolution at the C level,
3135 since that's the best that any real-world system supports now.
3136 But they are picosecond-resolution at the Lisp level, as that's
3137 easy, and leaves room for future OS improvements.
3138
3139 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3140 (LIBES): Use it.
3141
3142 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3143 Don't get current time unless it's needed.
3144
3145 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3146 now provides it if it's absent.
3147 (start_atimer): Port to higher-res time stamps.
3148 Check for time stamp overflow. Don't get current time more
3149 often than is needed.
3150
3151 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3152 Include systime.h, not time.h.
3153 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3154
3155 * dired.c: Include stat-time.h.
3156 (Ffile-attributes): File times now have higher resolution.
3157
3158 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3159 (struct image): Timestamp now has higher resolution.
3160
3161 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3162 has at least microseconds now. All uses removed.
3163 (update_frame, update_single_window, update_window, update_frame_1)
3164 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3165
3166 * editfns.c (time_overflow): Now extern.
3167 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3168 (float-time, Fformat_time_string, Fcurrent_time_string)
3169 (Fcurrent_time_zone): Accept and generate higher-resolution
3170 time stamps.
3171 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3172 (decode_time_components, lisp_seconds_argument): New functions.
3173 (make_time): Now static.
3174 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3175 Report an error if the time is invalid, rather than having the caller
3176 do that.
3177
3178 * fileio.c: Include <stat-time.h>
3179 (Fcopy_file): Copy higher-resolution time stamps.
3180 Prefer to set the time stamp via a file descriptor if that works.
3181 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3182 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3183 (Fvisited_file_modtime, Fset_visited_file_modtime):
3184 Support higher-resolution time stamps.
3185
3186 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3187
3188 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3189
3190 * image.c (prepare_image_for_display, clear_image_cache)
3191 (lookup_image): Port to higer-resolution time stamps.
3192
3193 * keyboard.c (start_polling, bind_polling_period):
3194 Check for time stamp overflow.
3195 (read_char, kbd_buffer_get_event, timer_start_idle)
3196 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3197 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3198 Port to higher-resolution time stamps. Do not assume time_t is signed.
3199 (decode_timer): New function. Timers are now vectors of length 9,
3200 not 8, to accommodate the picosecond component.
3201 (timer_check_2): Use it.
3202
3203 * nsterm.m (select_timeout, timeval_subtract): Remove.
3204 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3205 as they're a bit more accurate and handle overflow better.
3206 (ns_select): Change prototype to be compatible with pselect.
3207 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3208 * nsterm.h (ns_select): Adjust prototype.
3209
3210 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3211 us-resolution time stamps.
3212 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3213
3214 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3215
3216 * lisp.h (time_overflow): New decl.
3217 (wait_reading_process_output): First arg is now intmax_t, not int,
3218 to accommodate larger waits.
3219
3220 * process.h (struct Lisp_Process.read_output_delay):
3221 Now counts nanoseconds, not microseconds.
3222 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3223 EMACS_HAS_USECS.
3224 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3225 (wait_reading_process_output):
3226 Port to ns-resolution time stamps.
3227 (Faccept_process_output, wait_reading_process_output):
3228 Check for time stamp overflow. Do not assume time_t is signed.
3229 (select_wrapper): Remove; we now use pselect.
3230 (Fprocess_attributes): Now generates ns-resolution time stamps.
3231
3232 * sysdep.c: Include utimens.h. Don't include utime.h
3233 or worry about struct utimbuf; gnulib does that for us now.
3234 (gettimeofday): Remove; gnulib provides a substitute.
3235 (make_timeval): New function.
3236 (set_file_times): Now sets ns-resolution time stamps.
3237 New arg FD; all uses changed.
3238 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3239 (system_process_attributes):
3240 Now returns ns-resolution time stamp. All uses changed.
3241 Check for time stamp overflow.
3242
3243 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3244 provides a substitute now.
3245
3246 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3247 since it guarantees struct timespec.
3248 (EMACS_TIME): Now struct timespec, so that we can support
3249 ns-resolution time stamps.
3250 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3251 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3252 (EMACS_USECS): Remove.
3253 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3254 so multiply the arg by 1000 before storing it.
3255 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3256 New macros.
3257 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3258 Port to ns-resolution time stamps.
3259 (EMACS_TIME_NEG_P): Remove; replaced by....
3260 (EMACS_TIME_SIGN): New macro.
3261 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3262 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3263 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3264 (make_timeval, make_lisp_time, decode_time_components): New decls.
3265 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3266 that it mishandled time_t overflow. You can't compare by subtracting!
3267 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3268 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3269
3270 * term.c: Include <sys/time.h>.
3271 (timeval_to_Time): New function, for proper overflow wraparound.
3272 (term_mouse_position, term_mouse_click): Use it.
3273
3274 * undo.c (record_first_change): Support higher-resolution time stamps
3275 in the undo buffer.
3276 (Fprimitive_undo): Use them when restoring time stamps.
3277
3278 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3279 (w32_get_internal_run_time):
3280 Port to higher-resolution Emacs time stamps.
3281 (ltime): Now accepts single 64-bit integer, as that's more convenient
3282 for callers.
3283
3284 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3285
3286 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3287 for compatibility with pselect. Support ns-resolution time stamps.
3288
3289 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3290
3291 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3292 Check for time stamp overflow, and support ns-resolution time stamps.
3293
3294 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3295 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3296 (timeval_subtract): Remove; no longer needed.
3297 (XTflash, XTring_bell, x_wait_for_event):
3298 Port to ns-resolution time stamps. Don't assume time_t is signed.
3299
b6a92dfe
CY
33002012-06-22 Chong Yidong <cyd@gnu.org>
3301
3302 * xdisp.c (x_consider_frame_title): Revert last change.
3303
d251c37c
EZ
33042012-06-22 Eli Zaretskii <eliz@gnu.org>
3305
3306 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3307 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3308 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3309 staticidx goes up to 1597 out of 1600 = 0x640.)
3310
f10deafb
PE
33112012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3314 Otherwise, the umask might be mistakenly 0 while handling input signals.
3315
ec6de1e2
SM
33162012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3317
3318 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3319
28be1ada
DA
33202012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3321
3322 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3323 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3324 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3325 access to `contents' member of Lisp_Vector objects with AREF and ASET
3326 where appropriate.
3327
c6bf3022
CY
33282012-06-19 Chong Yidong <cyd@gnu.org>
3329
3330 * frame.c (delete_frame): When selecting a frame on a different
3331 text terminal, do not alter the terminal's top-frame.
3332
3333 * xdisp.c (format_mode_line_unwind_data): Record the target
3334 frame's selected window and its terminal's top-frame.
3335 (unwind_format_mode_line): Restore them.
3336 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3337 Callers changed.
3338 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3339 since tty frames can be explicitly named.
3340 (prepare_menu_bars): Likewise.
3341
3342 * term.c (Ftty_top_frame): New function.
3343
defd4196
PE
33442012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 Port byte-code-meter to modern targets.
3347 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3348 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3349 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3350 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3351 (METER_1, METER_2): Simplify.
3352
1053a871
SM
33532012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3354
3355 * data.c (Fdefalias): Return `symbol' (bug#11686).
3356
b7e8d081
MR
33572012-06-18 Martin Rudalics <rudalics@gmx.at>
3358
3359 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3360 gets killed during executing of this function (Bug#11665).
3361 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3362 (Vkill_buffer_query_functions): In doc-string say that functions
3363 run by this hook should not change the current buffer.
3364
7ea2b339
PE
33652012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 Fix recently-introduced process.c problems found by static checking.
3368 * process.c (write_queue_push, write_queue_pop, send_process):
3369 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3370 (write_queue_pop): Fix pointer signedness problem.
3371 (send_process): Remove unused local.
3372
96a313a1
CY
33732012-06-17 Chong Yidong <cyd@gnu.org>
3374
3375 * xdisp.c (redisplay_internal): No need to redisplay terminal
3376 frames that are not on top.
3377
20ca2e94
TN
33782012-06-17 Troels Nielsen <bn.troels@gmail.com>
3379
3380 * process.c (make_process): Initialize write_queue.
3381 (write_queue_push, write_queue_pop): New functions.
3382 (send_process): Use them to maintain correct ordering of process
3383 writes (Bug#10815).
3384
9a900ca9
PE
33852012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3386
310fbfa8
PE
3387 * lisp.h (eassert): Assume C89 or later.
3388 This removes the need for CHECK.
3389 (CHECK): Remove. Its comments about always evaluating its
3390 argument were confusing, as 'eassert' typically does not evaluate
3391 its argument.
3392
27bb1ca4
PE
3393 * coding.c (produce_chars): Use ptrdiff_t, not int.
3394
9a900ca9
PE
3395 * xterm.c (x_draw_underwave): Check for integer overflow.
3396 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3397
41b7f8bc 33982012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3399
3400 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3401 referenced (Bug#11583).
3402
9b0e3eba
AA
34032012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3404
3405 Implement wave-style variant of underlining.
3406 * dispextern.h (face_underline_type): New enum.
3407 (face): Add field for underline type.
3408 * nsterm.m (ns_draw_underwave): New function.
3409 (ns_draw_text_decoration): Use it.
3410 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3411 New functions.
3412 (x_draw_glyph_string): Use them.
3413 * xfaces.c (Qline, Qwave): New Lisp objects.
3414 (check_lface_attrs, merge_face_ref)
1053a871
SM
3415 (Finternal_set_lisp_face_attribute, realize_x_face):
3416 Handle wave-style underline face attributes.
9b0e3eba
AA
3417 * xterm.c (x_draw_underwave): New function.
3418 (x_draw_glyph_string): Use it.
3419
0fb52f11
JB
34202012-06-16 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3423 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3424 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3425 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3426 ($(BLD)/w32select.$(O)): Update dependencies.
3427
e5560ff7
AS
34282012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3429
3430 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3431 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3432 * character.c (_fetch_multibyte_char_p): Remove.
3433 * alloc.c: Include "character.h" before "buffer.h".
3434 * bidi.c: Likewise.
3435 * buffer.c: Likewise.
3436 * bytecode.c: Likewise.
3437 * callint.c: Likewise.
3438 * callproc.c: Likewise.
3439 * casefiddle.c: Likewise.
3440 * casetab.c: Likewise.
3441 * category.c: Likewise.
3442 * cmds.c: Likewise.
3443 * coding.c: Likewise.
3444 * composite.c: Likewise.
3445 * dired.c: Likewise.
3446 * dispnew.c: Likewise.
3447 * doc.c: Likewise.
3448 * dosfns.c: Likewise.
3449 * editfns.c: Likewise.
3450 * emacs.c: Likewise.
3451 * fileio.c: Likewise.
3452 * filelock.c: Likewise.
3453 * font.c: Likewise.
3454 * fontset.c: Likewise.
3455 * fringe.c: Likewise.
3456 * indent.c: Likewise.
3457 * insdel.c: Likewise.
3458 * intervals.c: Likewise.
3459 * keyboard.c: Likewise.
3460 * keymap.c: Likewise.
3461 * lread.c: Likewise.
3462 * macros.c: Likewise.
3463 * marker.c: Likewise.
3464 * minibuf.c: Likewise.
3465 * nsfns.m: Likewise.
3466 * nsmenu.m: Likewise.
3467 * print.c: Likewise.
3468 * process.c: Likewise.
3469 * regex.c: Likewise.
3470 * region-cache.c: Likewise.
3471 * search.c: Likewise.
3472 * syntax.c: Likewise.
3473 * term.c: Likewise.
3474 * textprop.c: Likewise.
3475 * undo.c: Likewise.
3476 * unexsol.c: Likewise.
3477 * w16select.c: Likewise.
3478 * w32fns.c: Likewise.
3479 * w32menu.c: Likewise.
3480 * window.c: Likewise.
3481 * xdisp.c: Likewise.
3482 * xfns.c: Likewise.
3483 * xmenu.c: Likewise.
3484 * xml.c: Likewise.
3485 * xselect.c: Likewise.
3486
2f07e6af
EZ
34872012-06-16 Eli Zaretskii <eliz@gnu.org>
3488
1053a871
SM
3489 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3490 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3491 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3492 row.
3493 (handle_face_prop): Use chunk-relative overlay string index when
3494 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3495 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3496 the rightmost. (Bug#11720)
2f07e6af 3497
29b83cec
AS
34982012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3499
3500 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3501 (CATEGORY_MEMBER): Enforce 1/0 value.
3502 * category.c (_temp_category_set): Remove.
3503
4c5501e9
EZ
35042012-06-16 Eli Zaretskii <eliz@gnu.org>
3505
3506 * window.c (Fdelete_other_windows_internal)
3507 (Fdelete_window_internal): Don't access frame's mouse highlight
3508 info of the initial frame. (Bug#11677)
3509
2b570124
PE
35102012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3511
e93864f9
PE
3512 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3513 Assume USE_2_TAGS_FOR_INTS.
3514 (xreload): Adjust $tagmask width to match recent lisp.h change.
3515
2b570124
PE
3516 Simplify lisp.h in minor ways that should not affect code.
3517 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3518 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3519 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3520 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3521 (INTTYPEBITS): New macro, for clarity.
3522 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3523 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3524 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3525 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3526 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3527
81755f69
JB
35282012-06-13 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3531
16192a57
GM
35322012-06-13 Glenn Morris <rgm@gnu.org>
3533
3534 * s/bsd-common.h (BSD4_3):
3535 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3536
646b5f55
AS
35372012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3538
3539 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3540 instead of union.
3541 (XLI, XIL): Define.
1053a871
SM
3542 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3543 Use them.
3544 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3545 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3546 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3547 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3548 * frame.c (delete_frame): Remove outdated comment.
3549 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3550 USE_LISP_UNION_TYPE.
3551 (Fw32_unregister_hot_key): Likewise.
3552 (Fw32_toggle_lock_key): Likewise.
3553 * w32menu.c (add_menu_item): Likewise.
3554 (w32_menu_display_help): Use XIL instead of checking
3555 USE_LISP_UNION_TYPE.
3556 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3557 (init_heap): Likewise.
3558 * w32term.c (w32_read_socket): Update comment.
3559
1d3823c9
GM
35602012-06-13 Glenn Morris <rgm@gnu.org>
3561
c62ff706
GM
3562 * s/usg5-4-common.h, src/s/unixware.h:
3563 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3564
1d3823c9
GM
3565 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3566
bfe3e0a2
PE
35672012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3568
3569 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3570 * alloc.c (make_number) [!defined make_number]:
3571 Remove, as lisp.h always defines this now.
3572 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3573 (roundup_size): Verify that it is a power of 2.
3574 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3575 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3576 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3577 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3578 USE_LSB_TAG now is always defined to be either 0 or 1.
3579 All uses changed.
3580 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3581 code works fine either way, and efficiency is not a concern here,
3582 as the union type is for debugging, not for production.
3583 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3584 Use an inline function on all platforms when using the union type,
3585 since this is simpler and 'static inline' can be used portably
3586 within Emacs now.
3587 (LISP_INITIALLY_ZERO): New macro.
3588 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3589 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3590
45fa9c0f
GM
35912012-06-12 Glenn Morris <rgm@gnu.org>
3592
b4492cba
GM
3593 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3594
3595 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3596
45fa9c0f
GM
3597 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3598 Move BROKEN_SIGIO to configure.
3599
3600 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3601 Move NO_TERMIO to configure.
3602
0e25d334
CY
36032012-06-12 Chong Yidong <cyd@gnu.org>
3604
3605 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3606 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3607 MagickExportImagePixels is undefined.
3608
43682bb6
PE
36092012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * image.c (imagemagick_load_image): Remove unused label.
3612
a9be7d2b
GM
36132012-06-11 Glenn Morris <rgm@gnu.org>
3614
3615 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3616 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3617 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3618 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3619
3017f87f
SM
36202012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3621
3622 * alloc.c (make_byte_code): New function.
3623 (Fmake_byte_code): Use it. Don't purify here.
3624 * lread.c (read1): Use it as well to avoid extra allocation.
3625
1b9b4cf4
CY
36262012-06-11 Chong Yidong <cyd@gnu.org>
3627
3628 * image.c (imagemagick_load_image): Implement transparency.
3629
95988fcf
AS
36302012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3631
3632 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3633 account for preceding backslashes. (Bug#11663)
3634
cd4eb164
CY
36352012-06-09 Chong Yidong <cyd@gnu.org>
3636
3637 * term.c: Support italics in capable terminals (Bug#9652).
3638 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3639 (turn_on_face): Output using TS_enter_italic_mode if available.
3640 Don't handle unused blinking and alt-charset cases.
3641 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3642 and tty_alt_charset_p cases.
3643 (tty_capable_p, init_tty): Support italics.
3644
3645 * termchar.h (struct tty_display_info): Add field for italics.
3646 Remove unused blink field.
3647
3648 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3649 Handle slant.
3650
3651 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3652 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3653 tty_alt_charset_p. Add tty_italic_p.
3654
ff88beb8
MA
36552012-06-09 Michael Albinus <michael.albinus@gmx.de>
3656
3657 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3658 dbus_type_is_basic if available.
3659 (xd_extract_signed, xd_extract_unsigned): Rename from
3660 extract_signed and extract_unsigned, respectively. Adapt callers.
3661
44286096
CY
36622012-06-09 Chong Yidong <cyd@gnu.org>
3663
1682701f
CY
3664 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3665
44286096
CY
3666 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3667 case (Bug#9752).
3668
d86feb17
PE
36692012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * xdisp.c (vmessage): Treat frame message as multibyte.
3672 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3673 would generate the diagnostic "Making \302\247 buffer-local while
3674 let-bound!".
3675
d5c20fe8
EZ
36762012-06-08 Eli Zaretskii <eliz@gnu.org>
3677
3678 * dispnew.c (showing_window_margins_p): Undo last change, which
3679 was done due to an inadvertent commit.
3680 (adjust_frame_glyphs_for_frame_redisplay): Do call
3681 showing_window_margins_p.
3682
513749ee
SM
36832012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3684
3685 * eval.c (Fmake_var_non_special): New primitive.
3686 (syms_of_eval): Defsubr it.
3687 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3688
d4a8f5c1
JB
36892012-06-08 Juanma Barranquero <lekktu@gmail.com>
3690
3691 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3692 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3693
8bbbc977
EZ
36942012-06-08 Eli Zaretskii <eliz@gnu.org>
3695
3696 * alloc.c (allocate_vectorlike): Fix last change.
3697
f3372c87
DA
36982012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3699
3700 Block-based vector allocation of small vectors.
3701 * lisp.h (struct vectorlike_header): New field `nbytes',
3702 adjust comment accordingly.
3703 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3704 to denote vector blocks. Adjust users (live_vector_p,
3705 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3706 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3707 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3708 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3709 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3710 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3711 (roundup_size): New constant.
3712 (struct vector_block): New data type.
3713 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3714 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3715 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3716 (sweep_vectors): New functions.
3717 (allocate_vectorlike): Return `zero_vector' as the only vector of
3718 0 items. Allocate new vector from block if vector size is less than
3719 or equal to VBLOCK_BYTES_MAX.
3720 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3721 (init_alloc_once): Add call to init_vectors.
3722
4f18a4ed
SM
37232012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3724
3725 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3726
86f158bc
PE
37272012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 * doprnt.c (doprnt): Truncate multibyte char correctly.
3730 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3731 would mishandle a string argument "Xc" if X was a multibyte
3732 character of length 2: it would truncate after X's first byte
3733 rather than including all of X.
3734
c5cfcbe0
CY
37352012-06-06 Chong Yidong <cyd@gnu.org>
3736
3737 * buffer.c (word_wrap): Doc fix.
3738
c05cf390
PE
37392012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3740
3741 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3742
0c3461de
GM
37432012-06-03 Glenn Morris <rgm@gnu.org>
3744
3745 * xdisp.c (tool-bar-style): Doc fix.
3746
c71232db
UM
37472012-06-03 Ulrich Müller <ulm@gentoo.org>
3748
3749 * Makefile.in (PAXCTL): Define.
3750 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3751 binary via PaX flags if the paxctl utility is available.
3752 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3753 Restore PaX flags to their default. (Bug#11398)
3754
383f7350
CY
37552012-06-03 Chong Yidong <cyd@gnu.org>
3756
3757 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3758 buffer (Bug#11226).
3759
5f2c76c6
CY
37602012-06-03 Chong Yidong <cyd@gnu.org>
3761
3762 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3763 (note_mode_line_or_margin_highlight): If there is no help echo,
3764 use mode-line-default-help-echo. Handle the case where the mouse
3765 position is past the end of the mode line string.
3766
3767 * buffer.c (buffer_local_value_1): New function, split from
3768 Fbuffer_local_value; can return Qunbound.
3769 (Fbuffer_local_value): Use it.
3770 (Vmode_line_format): Docstring tweaks.
3771
773d47f6
PE
37722012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 * sysdep.c (system_process_attributes): Improve comment.
3775
f2d6a3df
SM
37762012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3777
3778 * keyboard.c: Export real-this-command to Elisp.
3779 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3780 and DEFVAR it. Update all users.
3781
63810350
PE
37822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3783
7bd5c1f4
PE
3784 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3785
63810350
PE
3786 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3787 Convert pctcpu and pctmem to Lisp float properly.
3788 Let the compiler fold better, as 100.0/0x8000 is exact.
3789
a2821611
AS
37902012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3791
3792 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3793 cons_block.
3794
5fceba1d
PE
37952012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3798
c98ff5dd
DA
37992012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3800
3801 For a 'struct window', replace some Lisp_Object fields to
3802 bitfields where appropriate, remove unused fields.
3803 * window.h (struct window): Remove unused 'last_mark_x' and
3804 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3805 change it's type from Lisp_Object to bitfield.
3806 Change type of 'force_start', 'optional_new_start',
3807 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3808 fields from Lisp_Object to bitfield. Adjust users accordingly.
3809
ca34e0be
PE
38102012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Pacify gcc -Wdouble-precision when using Xaw.
3813 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3814 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3815 Use 'float' consistently, rather than 'float' in most places
3816 and 'double' in a couple of places.
3817
efc00ab1 38182012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3819
3820 * xdisp.c (handle_stop): Detect whether we have overlay strings
3821 loaded by testing it->current.overlay_string_index to be
3822 non-negative, instead of checking whether n_overlay_strings is
3823 positive. (Bug#11587)
3824
efc00ab1 38252012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3826
3827 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3828
3829 * doc.c (Fsubstitute_command_keys): Doc fix.
3830
efc00ab1 38312012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3832
3833 * search.c (search_buffer): Remove calls to
3834 r_alloc_inhibit_buffer_relocation, as it is now called by
3835 maybe_unify_char, which was the cause of relocation of buffer text
3836 in bug#11519.
3837
efc00ab1 38382012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3839
3840 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3841 for the duration of call to load_charset, to avoid problems with
3842 callers of maybe_unify_char that access buffer text through C
3843 pointers.
3844
3845 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3846 decrement the inhibition flag, instead of just setting or
3847 resetting it.
3848
ba93a187
PE
38492012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 Remove obsolete '#define static' cruft.
3852 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3853 This #undef was "temporary" in 2000; it is no longer needed
3854 now that '#define static' has gone away.
3855 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3856 (gray_bitmap_bits): Remove; no longer needed.
3857 All uses replaced with definiens.
3858 * xterm.c: Include "bitmaps/gray.xbm".
3859
9e4bf381
PE
38602012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3861
3862 Clean up __executable_start, monstartup when --enable-profiling.
3863 The following changes affect the code only when profiling.
3864 * dispnew.c (__executable_start): Rename from safe_bcopy.
3865 Define only on platforms that need it.
3866 * emacs.c: Include <sys/gmon.h> when profiling.
3867 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3868 (__executable_start): Remove decl, since lisp.h does it now.
3869 (safe_bcopy): Remove decl; no longer has that name.
3870 (main): Coalesce #if into single bit of code, for simplicity.
3871 Cast pointers to uintptr_t, since standard libraries want integers
3872 and not pointers.
3873 * lisp.h (__executable_start): New decl.
3874
32d72c2f
GM
38752012-05-31 Glenn Morris <rgm@gnu.org>
3876
3877 * image.c (Fimagemagick_types): Doc fix.
3878
baac5bc7
JM
38792012-05-30 Jim Meyering <meyering@redhat.com>
3880
3881 * callproc.c (Fcall_process_region): Include directory component
3882 in mkstemp error message (Bug#11586).
3883
72cb32cf
PE
38842012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * alloc.c, lisp.h (make_pure_vector): Now static.
3887
61b108cc
SM
38882012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3889
3890 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3891 Move to byte-run.el.
3892 (Fautoload): Do the hash-doc more carefully.
3893 * data.c (Fdefalias): Purify definition, except for keymaps.
3894 (Qdefun): Move from eval.c.
3895 * lisp.h (Qdefun): Remove.
3896 * lread.c (read1): Tiny simplification.
3897
471fe23d
TN
38982012-05-29 Troels Nielsen <bn.troels@gmail.com>
3899
934f3f58 3900 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3901 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3902 Bug#9642, but explicitly check that the buffer the overlay would
3903 be moved to is live and rearrange lines to make sure that errors
3904 will not put the overlay in an inconsistent state.
3905 (Fdelete_overlay): Cosmetics.
3906
85d0efd1
EZ
39072012-05-28 Eli Zaretskii <eliz@gnu.org>
3908
3909 * w32term.c (my_bring_window_to_top): New function.
3910 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3911 could be different from the original one.
3912 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3913 (Bug#11513)
3914
3915 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3916 by calling BringWindowToTop.
3917
3918 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3919 (WM_EMACS_END): Increase by one.
3920
da92a98c
PE
39212012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3924 This avoids undefined behavior that might cause the eassert
3925 to not catch an out-of-range value.
3926
74d1f848
JB
39272012-05-28 Juanma Barranquero <lekktu@gmail.com>
3928
3929 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3930 Update dependencies.
3931
9e1a06fc
EZ
39322012-05-27 Eli Zaretskii <eliz@gnu.org>
3933
3934 * bidi.c (bidi_mirror_char): Fix last change.
3935
f3dd7312
AS
39362012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3937
3938 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3939 when referring to sectname field in printf format.
3940
81899c91
PE
39412012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3942
57b81a9f
PE
3943 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3944 Only r_alloc_inhibit_buffer_relocation needed to be added;
3945 the others were already declared.
3946
81899c91
PE
3947 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3948 before checking whether it's out of range. Put the check inside
3949 eassert. See
3950 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3951
33017faf 39522012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3953
3954 * callproc.c (Fcall_process): Restore a line that was accidentally
3955 commented out in the 2011-02-13 change (bug#11547).
3956
33017faf 39572012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3958
3959 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3960 defined on ralloc.c.
3961
3962 * buffer.c [REL_ALLOC]: Remove prototypes of
3963 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3964 they are now on lisp.h.
3965
3966 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3967
3968 * search.c (search_buffer): Use it to inhibit relocation of buffer
3969 text while re_search_2 is doing its job, because re_search_2 is
3970 passed C pointers to buffer text. (Bug#11519)
3971
23415acf
EZ
3972 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3973 Update value to 24.
3974
44e27368
EZ
3975 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3976 state after an additional call to move_it_in_display_line_to, keep
3977 the values of it->max_ascent and it->max_descent found for the
3978 entire line.
3979 (pos_visible_p): Revert the comparison against bottom_y to what it
3980 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3981 (Bug#11464)
3982
c1892f11
PE
39832012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Fix coding-related core dumps with gcc -ftrapv.
3986 The code was computing A - B, where A and B are pointers, and B is
3987 random garbage. This can lead to core dumps on platforms that
3988 have special pointer registers, and it also leads to core dumps on
3989 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3990 A - B only when B is initialized properly.
3991 * coding.c (coding_set_source, coding_set_destination): Return void.
3992 (coding_change_source, coding_change_destinations): New functions,
3993 with the old behaviors of coding_set_source and coding_set_destination.
3994 All callers that need an offset changed to use these new functions.
3995
eb7afdad
GM
39962012-05-26 Glenn Morris <rgm@gnu.org>
3997
3998 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3999
f12fdf02
EZ
40002012-05-26 Eli Zaretskii <eliz@gnu.org>
4001
53a63be6 4002 Extend mouse support on W32 text-mode console.
61b108cc
SM
4003 * xdisp.c (draw_row_with_mouse_face):
4004 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4005
eb3f6f01 4006 * w32console.c: Include window.h.
61b108cc
SM
4007 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4008 New functions.
eb3f6f01
EZ
4009 (initialize_w32_display): Initialize mouse-highlight data.
4010
53a63be6
EZ
4011 * w32inevt.c: Include termchar.h and window.h.
4012 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4013 moves, call note_mouse_highlight. If help_echo changed, call
4014 gen_help_event to produce help-echo message in the echo area.
4015 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4016 highlight info.
4017
4cfd81f6
PE
40182012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4019
4020 * lread.c (read1): Simplify slightly to avoid an overflow warning
4021 with GCC 4.7.0 on x86-64.
4022
4446092a
EZ
40232012-05-26 Eli Zaretskii <eliz@gnu.org>
4024
4025 * bidi.c (bidi_mirror_char): Revert last change: an int is
4026 definitely wide enough here.
4027
42b2a986 40282012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4029
42b2a986 4030 Fix integer width and related bugs (Bug#9874).
eb106a49 4031 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4032 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4033 (string_bytes, check_sblock, allocate_string_data):
4034 (compact_small_strings, Fmake_bool_vector, make_string)
4035 (make_unibyte_string, make_multibyte_string)
4036 (make_string_from_bytes, make_specified_string)
4037 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4038 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4039 (mark_vectorlike):
4040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4041 (allocate_pseudovector):
4042 Use int, not EMACS_INT, where int is wide enough.
4043 (inhibit_garbage_collection, Fgarbage_collect):
4044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4045 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4046 int might not be wide enough.
4047 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4048 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4049 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4050 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4051 (bidi_level_of_next_char, bidi_move_to_visually_next):
4052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4053 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4054 (Fkill_buffer, Fset_buffer_major_mode)
4055 (advance_to_char_boundary, Fbuffer_swap_text)
4056 (Fset_buffer_multibyte, overlays_at, overlays_in)
4057 (overlay_touches_p, struct sortvec, record_overlay_string)
4058 (overlay_strings, recenter_overlay_lists)
4059 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4060 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4061 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4062 (Foverlay_recenter, last_overlay_modification_hooks_used)
4063 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4065 (validate_region): Omit unnecessary test for b <= e,
4066 since that's guaranteed by the previous test.
d311d28c
PE
4067 (adjust_overlays_for_delete): Avoid pos + length overflow.
4068 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4069 (report_overlay_modification):
4070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4071 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4072 Omit pointer cast, which isn't needed anyway, and doesn't work
4073 after the EMACS_INT -> ptrdiff_t change.
02481186 4074 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4075 * buffer.h: Adjust decls to match defn changes elsewhere.
4076 (struct buffer_text, struct buffer):
4077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4078 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4079 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4080 not int, to avoid needless 32-bit limit on 64-bit hosts.
4081 (exec_byte_code): Use tighter memory-full test, one that checks
4082 for alloca overflow. Don't compute the address of the object just
4083 before an array, as that's not portable. Use EMACS_INT, not
4084 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4085 * callint.c (Fcall_interactively):
4086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4087 * callproc.c (call_process_kill, Fcall_process):
4088 Don't assume pid_t fits into an Emacs fixnum.
4089 (call_process_cleanup, Fcall_process, child_setup):
4090 Don't assume pid_t fits into int.
4091 (call_process_cleanup, Fcall_process, delete_temp_file)
4092 (Fcall_process_region):
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 (Fcall_process): Simplify handling of volatile integers.
4095 Use int, not EMACS_INT, where int will do.
4096 * casefiddle.c (casify_object, casify_region, operate_on_word)
4097 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4099 (casify_object): Avoid integer overflow when overallocating buffer.
4100 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4101 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4102 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4103 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4104 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4105 integers are now checked earlier. All uses replaced with XINT.
4106 (ccl_driver):
4107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4108 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4109 (ccl_driver, Fregister_code_conversion_map):
4110 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4111 (resolve_symbol_ccl_program): Check that vector header is in range.
4112 Always copy the vector, so that we can check its contents reliably
4113 now rather than having to recheck each instruction as it's being
4114 executed. Check that vector words fit in 'int'.
4115 (ccl_get_compiled_code, Fregister_ccl_program)
4116 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4117 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4118 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4119 contents are in range.
4120 (Fccl_execute_on_string): Check that status is in range.
4121 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4122 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4123 Accept and return EMACS_INT, not int, because callers can pass values
4124 out of 'int' range.
4125 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4126 (multibyte_chars_in_text, parse_str_as_multibyte)
4127 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4128 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4129 (string_escape_byte8, Fget_byte):
4130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4131 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4132 avoid mishandling large integers.
4133 * character.h: Adjust decls to match defn changes elsewhere.
4134 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4135 (Ffind_charset_region):
4136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4137 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4138 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4139 Don't assume fixnum fits in int.
d311d28c
PE
4140 (load_charset_map_from_vector, Fmap_charset_chars):
4141 Remove now-unnecessary CHECK_NATNUMs.
4142 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4143 Don't rely on undefined behavior with signed left shift overflow.
4144 Don't assume unsigned int fits into fixnum, or that fixnum fits
4145 into unsigned int. Don't require max_code to be a valid fixnum;
4146 that's not true for gb10830 4-byte on a 32-bit host. Allow
4147 invalid_code to be a cons, for the same reason. Require code_offset
4148 to be a character. Avoid int overflow if max_char is close
4149 to INT_MAX.
4150 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4151 this is intended anyway and avoids some undefined behavior.
4152 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4153 INDEX_TO_CODE_POINT, as that's what it expects.
4154 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4155 * charset.h (DECODE_CHAR): Return int, not unsigned;
4156 this is what was intended anyway, and it avoids undefined behavior.
4157 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4158 integer-overflow issues.
4159 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4160 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4161 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4162 * chartab.c (Fmake_char_table, Fset_char_table_range)
4163 (uniprop_get_decoder, uniprop_get_encoder):
4164 Don't assume fixnum fits in int.
4165 * cmds.c (move_point): New function, that does the gist of
4166 Fforward_char and Fbackward_char, but does so while checking
4167 for integer overflow more accurately.
c96e5d6a 4168 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4169 (Fforward_line, Fend_of_line, internal_self_insert)
4170 (internal_self_insert):
4171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4172 Fix a FIXME, by checking for integer overflow when calculating
4173 target_clm and actual_clm.
4174 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4175 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4176 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4177 (coding_alloc_by_making_gap, alloc_destination)
4178 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4179 (encode_coding_utf_16, detect_coding_emacs_mule)
4180 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4181 (detect_coding_iso_2022, decode_coding_iso_2022)
4182 (encode_invocation_designation, encode_designation_at_bol)
4183 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4184 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4185 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4186 (encode_coding_ccl, encode_coding_raw_text)
4187 (detect_coding_charset, decode_coding_charset)
4188 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4189 (produce_composition, produce_charset, produce_annotation)
4190 (decode_coding, handle_composition_annotation)
4191 (handle_charset_annotation, consume_chars, decode_coding_gap)
4192 (decode_coding_object, encode_coding_object, detect_coding_system)
4193 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4194 (code_convert_region, code_convert_string)
8f50130c
PE
4195 (Fdefine_coding_system_internal)
4196 (coding_set_source, coding_set_destination):
d311d28c
PE
4197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4198 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4199 (Fdefine_coding_system_internal):
4200 Don't assume fixnums fit in int.
4201 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4202 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4203 (Funencodable_char_position, Fcheck_coding_systems_region)
4204 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4206 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4207 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4208 Don't access memory outside of the args array.
d311d28c 4209 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4210 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4211 result of ENCODE_CHAR.
d311d28c
PE
4212 * coding.h: Adjust decls to match defn changes elsewhere.
4213 (struct coding_system):
4214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4215 * composite.c (get_composition_id, find_composition)
4216 (run_composition_function, update_compositions)
4217 (compose_text, composition_gstring_put_cache)
4218 (composition_gstring_p, composition_gstring_width)
4219 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4220 (composition_compute_stop_pos, composition_reseat_it)
4221 (composition_update_it, struct position_record)
4222 (find_automatic_composition, composition_adjust_point)
4223 (Fcomposition_get_gstring, Ffind_composition_internal):
4224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4225 (update_compositions):
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4227 * composite.h: Adjust decls to match defn changes elsewhere.
4228 (struct composition):
4229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4230 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4231 Do not attempt to compute the address of the object just before a
4232 buffer; this is not portable.
4233 (Faref, Faset):
4234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4235 (Faset): Use int, not EMACS_INT, where int is wide enough.
4236 (Fstring_to_number): Don't assume fixnums fit in int.
4237 (Frem): Don't assume arg is nonnegative.
4238 * dbusbind.c (xd_append_arg): Check for integers out of range.
4239 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4240 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4241 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4242 (xd_get_connection_references): Return ptrdiff_t, not int.
4243 All uses changed.
4244 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4245 (xd_read_message_1):
4246 Use int, not unsigned, where the dbus API uses int.
4247 (Fdbus_message_internal): Don't overflow mtype.
4248 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4249 * dired.c (directory_files_internal, file_name_completion, scmp)
4250 (file_name_completion_stat):
4251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4252 (file_name_completion): Don't overflow matchcount.
4253 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4254 * dispextern.h: Adjust decls to match defn changes elsewhere.
4255 (struct text_pos, struct glyph, struct bidi_saved_info)
4256 (struct bidi_string_data, struct bidi_it, struct composition_it)
4257 (struct it):
4258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4259 (struct display_pos, struct composition_it, struct it):
4260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4261 * dispnew.c (increment_matrix_positions)
4262 (increment_row_positions, mode_line_string)
4263 (marginal_area_string):
4264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4265 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4267 (duration_to_sec_usec): New function, to check for overflow better.
4268 (Fsleep_for, sit_for): Use it.
4269 * doc.c (get_doc_string, store_function_docstring):
4270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4271 (get_doc_string, Fsnarf_documentation):
4272 Use int, not EMACS_INT, where int is wide enough.
4273 (get_doc_string):
4274 Use SAFE_ALLOCA, not alloca.
4275 Check for overflow when converting EMACS_INT to off_t.
4276 * doprnt.c (doprnt):
4277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4278 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4279 Don't assume uid_t fits into fixnum.
4280 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4281 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4282 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4283 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4284 (general_insert_function)
4285 (Finsert_char, make_buffer_string, make_buffer_string_both)
4286 (update_buffer_properties, Fbuffer_substring)
4287 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4288 (Fsubst_char_in_region, check_translation)
4289 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4290 (transpose_markers, Ftranspose_regions):
4291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4292 (clip_to_bounds): Move to lisp.h as an inline function).
4293 (Fconstrain_to_field): Don't assume integers are nonnegative.
4294 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4295 (Fsubst_char_in_region, Fsave_restriction):
4296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4297 (Femacs_pid): Don't assume pid_t fits into fixnum.
4298 (lo_time): Use int, not EMACS_INT, when int suffices.
4299 (lisp_time_argument): Check for usec out of range.
4300 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4301 (Fuser_login_name, Fuser_full_name): Signal an error
4302 if a uid argument is out of range, rather than relying on
4303 undefined behavior.
c8d5c857
PE
4304 (Fformat_time_string): Remove now-unnecessary check.
4305 lisp_time_argument checks for out-of-range usec now.
243e0530 4306 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4307 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4308 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4309 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4310 (init_cmdargs, Fdump_emacs):
4311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4312 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4313 the bottom (typically) 32 bits of the fixnum.
4314 * eval.c (specpdl_size, call_debugger):
4315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4316 (when_entered_debugger, Fbacktrace_debug):
4317 Don't assume fixnum can fit in int.
4318 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4319 the object just before a buffer; this is not portable.
4320 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4321 (grow_specpdl, unbind_to):
4322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4323 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4324 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4325 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4326 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4327 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4329 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4330 (a_write, e_write):
4331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4332 (Fcopy_file, non_regular_nbytes, read_non_regular)
4333 (Finsert_file_contents):
4334 Use int, not EMACS_INT, where int is wide enough.
4335 (READ_BUF_SIZE): Verify that it fits in int.
4336 (Finsert_file_contents): Check that counts are in proper range,
4337 rather than assuming fixnums fit into ptrdiff_t etc.
4338 Don't assume fixnums fit into int.
125b3835 4339 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4340 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4341 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4342 (string_char_to_byte, string_byte_to_char)
4343 (string_make_multibyte, string_to_multibyte)
4344 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4345 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4346 (substring_both, Fdelete, internal_equal, Ffillarray)
4347 (Fclear_string, mapcar1)
4348 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4349 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4350 (larger_vector, make_hash_table, maybe_resize_hash_table)
4351 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4352 (Fmaphash, secure_hash):
4353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4354 (concat): Check for string index and length overflow.
4355 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4356 (Frequire):
4357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4358 (larger_vector): New API (vec, incr_min, size_max) replaces old
4359 one (vec, new_size, init). This catches size overflow.
4360 INIT was removed because it was always Qnil.
4361 All callers changed.
4362 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4363 the upper bound on a hash table index size.
4364 (make_hash_table, maybe_resize_hash_table): Use it.
4365 (secure_hash): Computer start_byte and end_byte only after
4366 they're known to be in ptrdiff_t range.
4367 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4368 (Ffont_get_glyphs, Ffont_at):
4369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4370 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4371 (Flist_fonts, Fopen_font):
4372 Don't assume fixnum can fit in int.
4373 (check_gstring): Don't assume index can fit in int.
4374 (font_match_p): Check that fixnum is a character, not a nonnegative
4375 fixnum, since the later code needs to stuff it into an int.
4376 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4377 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4378 conversion overflow issues.
4379 (Fopen_font): Check for integer out of range.
4380 (Ffont_get_glyphs): Don't assume index can fit in int.
4381 * font.h: Adjust decls to match defn changes elsewhere.
4382 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4383 integer overflow.
4384 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4385 printmax_t, where ptrdiff_t is wide enough.
4386 (Finternal_char_font):
4387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4388 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4389 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4390 (Fset_frame_position, x_set_frame_parameters)
4391 (x_set_line_spacing, x_set_border_width)
4392 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4393 Check that fixnums are in proper range for system types.
4394 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4396 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4397 Use SAFE_ALLOCA_LISP, not alloca.
4398 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4399 intptr_t is wide enough.
4400 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4401 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4402 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4403 Check for fixnum out of range.
4404 * ftfont.c (ftfont_list): Don't assume index fits in int.
4405 Check that fixnums are in proper range for system types.
4406 (ftfont_shape_by_flt):
4407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4408 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4410 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4411 Check that fixnums are in proper range for system types.
4412 * gnutls.h: Adjust decls to match defn changes elsewhere.
4413 * gtkutil.c (xg_dialog_run):
4414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4415 (update_frame_tool_bar):
4416 Check that fixnums are in proper range for system types.
4417 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4418 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4419 * indent.c (last_known_column, last_known_column_point):
4420 (current_column_bol_cache):
4421 (skip_invisible, current_column, check_display_width):
4422 (check_display_width, scan_for_column, current_column_1)
4423 (Findent_to, Fcurrent_indentation, position_indentation)
4424 (indented_beyond_p, Fmove_to_column, compute_motion):
4425 (Fcompute_motion, Fvertical_motion):
4426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4427 (last_known_column_modified): Use EMACS_INT, not int.
4428 (check_display_width):
4429 (Fcompute_motion):
4430 Check that fixnums and floats are in proper range for system types.
4431 (compute_motion): Don't assume index or fixnum fits in int.
4432 (compute_motion, Fcompute_motion):
4433 Use int, not EMACS_INT, when it is wide enough.
4434 (vmotion): Omit local var start_hpos that is always 0; that way
4435 we don't need to worry about overflow in expressions involving it.
4436 * indent.h: Adjust decls to match defn changes elsewhere.
4437 (struct position):
4438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4439 Use int, not EMACS_INT, where int is wide enough.
4440 Remove unused members ovstring_chars_done and tab_offset;
4441 all uses removed.
4442 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4443 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4444 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4445 (make_gap, copy_text, insert, insert_and_inherit)
4446 (insert_before_markers, insert_before_markers_and_inherit)
4447 (insert_1, count_combining_before, count_combining_after)
4448 (insert_1_both, insert_from_string)
4449 (insert_from_string_before_markers, insert_from_string_1)
4450 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4451 (adjust_after_replace, adjust_after_insert, replace_range)
4452 (replace_range_2, del_range, del_range_1, del_range_byte)
4453 (del_range_both, del_range_2, modify_region)
4454 (prepare_to_modify_buffer, signal_before_change)
4455 (signal_after_change, Fcombine_after_change_execute):
4456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4457 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4458 (balance_an_interval, split_interval_right, split_interval_left)
4459 (find_interval, next_interval, update_interval)
4460 (adjust_intervals_for_insertion, delete_node, delete_interval)
4461 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4462 (static_offset_intervals, offset_intervals)
4463 (merge_interval_right, merge_interval_left, make_new_interval)
4464 (graft_intervals_into_buffer, temp_set_point_both)
4465 (temp_set_point, set_point, adjust_for_invis_intang)
4466 (set_point_both, move_if_not_intangible, get_property_and_range)
4467 (get_local_map, copy_intervals, copy_intervals_to_string)
4468 (compare_string_intervals, set_intervals_multibyte_1):
4469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4470 * intervals.h: Adjust decls to match defn changes elsewhere.
4471 (struct interval):
4472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4473 * keyboard.c (this_command_key_count, this_single_command_key_start)
4474 (before_command_key_count, before_command_echo_length, echo_now)
4475 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4476 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4477 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4478 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4480 (last_non_minibuf_size, last_point_position, echo_truncate)
4481 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4482 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4483 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4484 (stuff_buffered_input):
4485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4486 (last_auto_save, command_loop_1, read_char):
4487 Use EMACS_INT, not int, to avoid integer overflow.
4488 (record_char): Avoid overflow in total_keys computation.
4489 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4490 * keyboard.h: Adjust decls to match defn changes elsewhere.
4491 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4492 (Fkey_description, Fdescribe_vector, Flookup_key):
4493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4494 (click_position): New function, to check that positions are in range.
4495 (Fcurrent_active_maps):
4496 (describe_command):
4497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4498 (Faccessible_keymaps, Fkey_description):
4499 (preferred_sequence_p):
4500 Don't assume fixnum can fit into int.
4501 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4502 Check for integer overflow in size calculations.
4503 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4504 avoid mishandling large integers.
4505 * lisp.h: Adjust decls to match defn changes elsewhere.
4506 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4507 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4508 (struct Lisp_Marker):
4509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4510 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4511 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4512 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4513 All callers changed.
4514 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4515 Assume the arg has valid form, since it always does.
4516 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4517 unsigned integer system type.
4518 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4519 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4521 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4522 (duration_to_sec_usec): New decl.
4523 * lread.c (read_from_string_index, read_from_string_index_byte)
4524 (read_from_string_limit, readchar, unreadchar, openp)
4525 (read_internal_start, read1, oblookup):
4526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4527 (Fload, readevalloop, Feval_buffer, Feval_region):
4528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4529 (openp): Check for out-of-range argument to 'access'.
4530 (read1): Use int, not EMACS_INT, where int is wide enough.
4531 Don't assume fixnum fits into int.
6efdadfd 4532 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4533 (read_filtered_event): Use duration_to_sec_usec
4534 to do proper overflow checking on durations.
d311d28c
PE
4535 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4536 in size calculation.
4537 (Fexecute_kbd_macro):
4538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4539 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4540 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4541 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4542 (set_marker_both, set_marker_restricted_both, marker_position)
4543 (marker_byte_position, Fbuffer_has_markers_at):
4544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4545 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4546 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4547 It now merely ensures that the menu is large enough, without
4548 necessarily growing it, as this avoids some integer overflow issues.
4549 All callers changed.
4550 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4552 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4553 Use SAFE_ALLOCA_LISP, not alloca.
4554 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4555 to EMACS_INT. Check that fixnums are in proper range for system types.
4556 * minibuf.c (minibuf_prompt_width, string_to_object)
4557 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4558 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4560 (get_minibuffer, read_minibuf_unwind):
4561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4562 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4563 this simplifies overflow checking. All callers changed.
4564 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4565 (Ftest_completion):
4566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4567 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4568 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4569 Check that fixnums are in proper range for system types.
4570 (Fx_create_frame, Fx_show_tip):
4571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4572 * nsfont.m (ns_findfonts, nsfont_list_family):
4573 Don't assume fixnum fits in long.
4574 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4576 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4577 wide enough.
17fdb222 4578 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4580 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4581 (PRINTDECLARE, PRINTPREPARE):
4582 (strout, print_string):
4583 (print, print_preprocess, print_check_string_charset_prop)
4584 (print_object):
4585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4586 (PRINTDECLARE):
4587 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4589 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4590 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4591 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4592 (print_error_message): Use SAFE_ALLOCA, not alloca.
4593 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4594 (print_depth, new_backquote_output, print_number_index):
4595 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4596 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4597 (Fset_process_window_size, Fformat_network_address)
4598 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4599 (sigchld_handler):
d311d28c 4600 Check that fixnums are in proper range for system types.
d44287d4 4601 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4602 Check for process-ids out of pid_t range rather than relying on
4603 undefined behavior.
e4d81efc 4604 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4605 (Fformat_network_address, read_process_output, send_process)
4606 (Fprocess_send_region, status_notify):
4607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4608 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4609 (wait_reading_process_output, read_process_output, exec_sentinel):
4610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4611 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4612 (Faccept_process_output): Use duration_to_sec_usec to do proper
4613 overflow checking on durations.
dde14581
PE
4614 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4615 Don't assume pid_t fits in int.
02481186
PE
4616 * process.h (struct Lisp_Process): Members tick and update_tick
4617 are now of type EMACS_INT, not int.
b62b53e8
PE
4618 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4619 configured --with-wide-int.
d311d28c
PE
4620 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4621 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4622 * search.c (looking_at_1, string_match_1):
4623 (fast_string_match, fast_c_string_match_ignore_case)
4624 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4625 (scan_newline, find_before_next_newline, search_command)
4626 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4627 (set_search_regs, wordify):
4628 (Freplace_match):
4629 (Fmatch_data):
4630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4631 (string_match_1, search_buffer, set_search_regs):
4632 (Fmatch_data):
4633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4634 (wordify): Check for overflow in size calculation.
4635 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4636 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4637 Check that fixnums are in proper range for system types.
4638 * sound.c (struct sound_device)
4639 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4641 (Fplay_sound_internal):
4642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4643 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4644 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4645 (Fparse_partial_sexp):
4646 Don't assume fixnums can fit in int.
4647 (struct lisp_parse_state, find_start_pos, find_start_value)
4648 (find_start_value_byte, find_start_begv)
4649 (update_syntax_table, char_quoted, dec_bytepos)
4650 (find_defun_start, prev_char_comend_first, back_comment):
4651 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4652 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4654 (Finternal_describe_syntax_value): Check that match_lisp is a
4655 character, not an integer, since the code stuffs it into int.
4656 (scan_words, scan_sexps_forward):
4657 Check that fixnums are in proper range for system types.
4658 (Fforward_word):
4659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4660 (scan_sexps_forward):
4661 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4662 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4663 * syntax.h: Adjust decls to match defn changes elsewhere.
4664 (struct gl_state_s):
4665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4666 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4667 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4668 * sysdep.c (wait_for_termination_1, wait_for_termination)
4669 (interruptible_wait_for_termination, mkdir):
4670 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4671 (emacs_read, emacs_write):
4672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4673 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4674 and double all fit in int.
d311d28c
PE
4675 * term.c (set_tty_color_mode):
4676 Check that fixnums are in proper range for system types.
4677 * termhooks.h (struct input_event):
4678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4679 * textprop.c (validate_interval_range, interval_of)
4680 (Fadd_text_properties, set_text_properties_1)
4681 (Fremove_text_properties, Fremove_list_of_text_properties)
4682 (Ftext_property_any, Ftext_property_not_all)
4683 (copy_text_properties, text_property_list, extend_property_ranges)
4684 (verify_interval_modification):
4685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4686 (Fnext_single_char_property_change)
4687 (Fprevious_single_char_property_change):
4688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4689 (copy_text_properties):
4690 Check for integer overflow in index calculation.
d311d28c
PE
4691 * undo.c (last_boundary_position, record_point, record_insert)
4692 (record_delete, record_marker_adjustment, record_change)
4693 (record_property_change):
4694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4695 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4697 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4698 (Fx_hide_tip, Fx_file_dialog):
4699 * w32menu.c (set_frame_menubar):
4700 Use ptrdiff_t, not int, for consistency with rest of code.
4701 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4702 (select_window, Fdelete_other_windows_internal)
4703 (window_scroll_pixel_based, window_scroll_line_based)
4704 (Frecenter, Fset_window_configuration):
4705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4706 (Fset_window_hscroll, run_window_configuration_change_hook)
4707 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4708 (Fscroll_other_window, Frecenter):
d311d28c
PE
4709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4710 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4711 Don't assume fixnum fits in int.
4712 (Fset_window_scroll_bars):
4713 Check that fixnums are in proper range for system types.
4714 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4715 (string_pos, c_string_pos, number_of_chars, init_iterator)
4716 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4717 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4718 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4719 (face_before_or_after_it_pos, handle_invisible_prop)
4720 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4721 (display_prop_intangible_p, string_buffer_position_lim)
4722 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4723 (get_overlay_strings_1, get_overlay_strings)
4724 (iterate_out_of_display_property, forward_to_next_line_start)
4725 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4726 (get_next_display_element, set_iterator_to_next)
4727 (get_visually_first_element, compute_stop_pos_backwards)
4728 (handle_stop_backwards, next_element_from_buffer)
4729 (move_it_in_display_line_to, move_it_in_display_line)
4730 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4731 (add_to_log, message_dolog, message_log_check_duplicate)
4732 (message2, message2_nolog, message3, message3_nolog
4733 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4734 (current_message_1, truncate_echo_area, truncate_message_1)
4735 (set_message, set_message_1, store_mode_line_noprop)
4736 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4737 (text_outside_line_unchanged_p, check_point_in_composition)
4738 (reconsider_clip_changes)
4739 (redisplay_internal, set_cursor_from_row, try_scrolling)
4740 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4741 (redisplay_window, find_last_unchanged_at_beg_row)
4742 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4743 (trailing_whitespace_p, find_row_edges, display_line)
4744 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4745 (display_mode_element, store_mode_line_string)
4746 (pint2str, pint2hrstr, decode_mode_spec)
4747 (display_count_lines, display_string, draw_glyphs)
4748 (x_produce_glyphs, x_insert_glyphs)
4749 (rows_from_pos_range, mouse_face_from_buffer_pos)
4750 (fast_find_string_pos, mouse_face_from_string_pos)
4751 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4753 (safe_call, init_from_display_pos, handle_fontified_prop)
4754 (handle_single_display_spec, load_overlay_strings)
4755 (with_echo_area_buffer, setup_echo_area_for_printing)
4756 (display_echo_area, echo_area_display)
4757 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4758 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4759 (redisplay_window, dump_glyph_row, display_mode_line)
4760 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4761 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4763 (handle_single_display_spec, build_desired_tool_bar_string)
4764 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4765 (get_specified_cursor_type):
4766 Check that fixnums are in proper range for system types.
4767 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4768 (Flookup_image_map):
4769 Don't assume fixnums fit in int.
4770 (compare_overlay_entries):
4771 Avoid mishandling comparisons due to subtraction overflow.
4772 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4773 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4774 (handle_tool_bar_click):
4775 Use int, not unsigned, since we prefer signed and the signedness
4776 doesn't matter here.
4777 (get_next_display_element, next_element_from_display_vector):
4778 Use int, not EMACS_INT, when int is wide enough.
4779 (start_hourglass): Use duration_to_sec_usec to do proper
4780 overflow checking on durations.
4781 * xfaces.c (Fbitmap_spec_p):
4782 Check that fixnums are in proper range for system types.
4783 (compare_fonts_by_sort_order):
4784 Avoid mishandling comparisons due to subtraction overflow.
4785 (Fx_family_fonts, realize_basic_faces):
4786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4787 (Fx_family_fonts):
4788 Don't assume fixnum fits in int.
4789 Use SAFE_ALLOCA_LISP, not alloca.
4790 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4791 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4792 (face_at_buffer_position, face_for_overlay_string)
4793 (face_at_string_position):
4794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4795 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4796 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4797 (Fx_show_tip):
4798 Check that fixnums are in proper range for system types.
4799 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4800 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4802 (Fx_change_window_property): Don't assume fixnums fit in int.
4803 * xfont.c (xfont_chars_supported):
4804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4805 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4806 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4808 * xml.c (parse_region):
4809 * xrdb.c (magic_file_p):
4810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4811 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4812 (x_get_local_selection, x_reply_selection_request)
4813 (x_handle_selection_request, wait_for_property_change):
4814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4815 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4816 short is wide enough.
4817 (x_send_client_event): Don't assume fixnum fits in int.
4818 * xterm.c (x_x_to_emacs_modifiers):
4819 Don't assume EMACS_INT overflows nicely into int.
4820 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4821 may come from Lisp.
4822 (handle_one_xevent): NATNUMP can eval its arg twice.
4823 (x_connection_closed):
4824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4825 * xterm.h: Adjust decls to match defn changes elsewhere.
4826 (struct scroll_bar): Use struct vectorlike_header
4827 rather than rolling our own approximation.
4828 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4829
c6574eb5
GM
48302012-05-25 Glenn Morris <rgm@gnu.org>
4831
4832 * lisp.mk (lisp): Update for more files being compiled now.
4833
e8d32c7e
SM
48342012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4835
48def666
SM
4836 * lread.c: Remove `read_pure' which makes no difference.
4837 (read_pure): Remove var.
4838 (unreadpure): Remove function.
4839 (readevalloop): Don't call read_list with -1 flag.
4840 (read1, read_vector): Don't test read_pure any more.
4841 (read_list): Simplify.
4842
e8d32c7e
SM
4843 * fileio.c, character.h: Minor style tweaks.
4844
4b2addb7
DA
48452012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4846
4847 * window.h (clip_changed): Remove useless declaration.
4848
584461b2
JB
48492012-05-22 Juanma Barranquero <lekktu@gmail.com>
4850
4851 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4852 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4853
34374650
PE
48542012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4855
4856 Remove src/m/*.
4857 This directory predates autoconf and is no longer needed nowadays.
4858 Move its few remaining bits of functionality to where they're needed.
4859 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4860 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4861 * m/template.h: Remove.
4862 * Makefile.in (M_FILE): Remove. All uses removed.
4863 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4864 * lisp.h (USE_LSB_TAG):
4865 * mem-limits.h (EXCEEDS_LISP_PTR):
4866 Use VAL_MAX, not VALBITS, in #if.
4867 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4868 (EMACS_UINT): Define unconditionally now.
4869 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4870 (BITS_PER_EMACS_INT): New constants, replacing
4871 what used to be in config.h, but not useful in #if.
4872 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4873 define them any more.
4874 (VAL_MAX): New macro.
4875 (VALMASK): Use it.
4876 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4877 BITS_PER_EMACS_INT, in #if.
4878 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4879 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4880 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4881 * s/ms-w32.h (DATA_START):
4882 Move here from removed file m/intel386.h.
4883 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4884 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4885
261cb4bb
PE
48862012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 Assume C89 or later.
4889 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4890 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4891 (xrealloc):
4892 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4893 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4894 * textprop.c, tparam.c (NULL): Remove.
4895 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4896 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4897 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4898 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4899 * xterm.c (input_signal_count): Assume volatile works.
4900
ff23cd9f
KB
49012012-05-21 Ken Brown <kbrown@cornell.edu>
4902
4903 * xgselect.c (xg_select): Fix first argument in call to 'select'
4904 (bug#11508).
4905
1b170bc6
KB
49062012-05-20 Ken Brown <kbrown@cornell.edu>
4907
4908 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4909 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4910
b2f4d39f
KB
49112012-05-19 Ken Brown <kbrown@cornell.edu>
4912
4913 * xfns.c (x_in_use): Remove `static' qualifier.
4914 * xterm.h (x_in_use): Declare.
4915 * xgselect.c: Include xterm.h.
4916 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4917 and `display_arg' (bug#9754).
4918
003fdae2
PE
49192012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4920
9232a6d9
PE
4921 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4922
003fdae2
PE
4923 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4924 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4925
784b56e2
EZ
49262012-05-18 Eli Zaretskii <eliz@gnu.org>
4927
4928 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4929
4930 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4931 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4932
4933 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4934 reference to image_cache->refcount.
4935 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4936
a0a79cde
JL
49372012-05-17 Juri Linkov <juri@jurta.org>
4938
4939 * search.c (Fword_search_regexp, Fword_search_backward)
4940 (Fword_search_forward, Fword_search_backward_lax)
4941 (Fword_search_forward_lax): Move functions to isearch.el
4942 (bug#10145, bug#11381).
4943
b0572523
PE
49442012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4947
9660f5fc
SM
49482012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4949
4950 * lread.c (init_obarray): Declare Qt and Qnil as special.
4951
4374de83
GM
49522012-05-14 Glenn Morris <rgm@gnu.org>
4953
4954 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4955 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4956
dc44c39a
PE
49572012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4958
078c97cb
PE
4959 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4960
dc44c39a
PE
4961 * unexaix.c: Port to more-recent AIX compilers.
4962 (report_error, report_error_1, make_hdr, copy_sym)
4963 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4964 Make arguments const char *, not char *, to avoid violations of C
4965 standard and to fix some AIX warnings reported by Gilles Pion.
4966
e18afed7 49672012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4968
4969 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4970 already have overlays loaded.
4971 (handle_single_display_spec): Before returning without displaying
4972 fringe bitmap, synchronize the bidi iterator with the main display
4973 iterator, by calling iterate_out_of_display_property.
4974 (iterate_out_of_display_property): Detect buffer iteration by
4975 testing that it->string is a Lisp string.
4976 (get_next_display_element): When the current object is exhausted,
4977 and there's something on it->stack, call set_iterator_to_next to
4978 proceed with what's on the stack, instead of returning zero.
4979 (set_iterator_to_next): If called at the end of a Lisp string,
4980 proceed to consider_string_end without incrementing string
4981 position. Don't increment display vector index past the end of
4982 the display vector. (Bug#11417)
c8fb9dc6
EZ
4983 (pos_visible_p): Don't report a position visible when move_it_to
4984 stopped at the last line of window, which happens to be scanned
4985 backwards by the bidi iteration. (Bug#11464)
ac268e67 4986
e18afed7 49872012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4988
4989 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4990 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4991 are on a TTY, and thus unable to display on the fringes.
4992 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4993 so we need to signal to the caller that this is a "replacing"
4994 display spec. This fixes display when the spec is invalid or we
4995 are on a TTY.
4996
e18afed7 49972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4998
4999 * unexaix.c (make_hdr): Fix typo in prototype.
5000 This bug broke the build on AIX. Problem reported by Gilles Pion.
5001
9d0a235a
MA
50022012-05-14 Michael Albinus <michael.albinus@gmx.de>
5003
5004 * keyboard.c (kbd_buffer_get_event): Read special events also in
5005 batch mode. (Bug#11415)
5006
9e6b06ed
GM
50072012-05-12 Glenn Morris <rgm@gnu.org>
5008
5009 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5010
c1a1d7a3
EZ
50112012-05-12 Eli Zaretskii <eliz@gnu.org>
5012
5013 * lisp.mk (lisp): Add newcomment.elc.
5014
3fe7cdc8
GM
50152012-05-12 Glenn Morris <rgm@gnu.org>
5016
5017 * Makefile.in (MKDIR_P): New, set by configure.
5018 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5019
53f7d2c0
PE
50202012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5021
5022 Remove unused function hourglass_started.
5023 * dispextern.h (hourglass_started):
5024 * w32fns.c (hourglass_started):
5025 * xdisp.c (hourglass_started): Remove.
5026
75aafb17
JB
50272012-05-10 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5030 Update dependencies.
5031
12959e8e
PE
50322012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5033
97107e2e
PE
5034 * xgselect.c (xg_select): Put maxfds+1 into a var.
5035 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5036
12959e8e
PE
5037 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5038
836d29b3
DA
50392012-05-10 Dave Abrahams <dave@boostpro.com>
5040
5041 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5042 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5043
5cb67954
MA
50442012-05-09 Michael Albinus <michael.albinus@gmx.de>
5045
5046 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5047 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5048 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5049 Initialize xd_registered_buses.
5050
3478ec45
PE
50512012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5052
b263a6b0
PE
5053 Untag more efficiently if USE_LSB_TAG.
5054 This is based on a proposal by YAMAMOTO Mitsuharu in
5055 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5056 For an admittedly artificial (nth 8000 longlist) benchmark on
5057 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5058 Emacs's overall text size by 1%.
5059 * lisp.h (XUNTAG): New macro.
5060 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5061 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5062 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5063 * eval.c (Fautoload):
5064 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5065 * frame.h (XFRAME): Use XUNTAG.
5066
3478ec45
PE
5067 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5068 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5069 Remove unportable assumptions about print widths of types like
5070 dbus_uint32_t.
5071 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5072 intptr_t when converting between pointer and integer, to avoid GCC
5073 warnings about wrong width.
5074
666b903b 50752012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5076
5077 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5078 stack for each reader_thread, instead of defaulting to 8MB
5079 determined by the linker. This avoids failures in creating
5080 subprocesses on Windows 7, see the discussion in this thread:
5081 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5082
b120cc17
JC
50832012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5084
5085 Fix up display of the *Minibuf-0* buffer in the mini window.
5086 * keyboard.c (read_char): Don't clear the echo area if there's no
5087 message to clear.
5088 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5089 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5090
9a4b36f8
MA
50912012-05-07 Michael Albinus <michael.albinus@gmx.de>
5092
5093 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5094 batch mode.
5095
e5f9458f
CY
50962012-05-06 Chong Yidong <cyd@gnu.org>
5097
5098 * lisp.mk (lisp): Update.
5099
eceeb5fc 51002012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5101
5102 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5103
71873e2b
SM
51042012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * data.c (PUT_ERROR): New macro.
5107 (syms_of_data): Use it. Add new error type `user-error'.
5108 * undo.c (user_error): New function.
5109 (Fprimitive_undo): Use it.
5110 * print.c (print_error_message): Adjust print style for `user-error'.
5111 * keyboard.c (user_error): New function.
5112 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5113
ab0fa4e4
PE
51142012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 Do not limit current-time-string to years 1000..9999.
5117 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5118 (Fcurrent_time_string): Support any year that is supported by the
5119 underlying localtime representation. Don't use asctime, as it
5120 has undefined behavior for years outside the range -999..9999.
5121
7ed806a7
PE
51222012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 Fix race conditions involving setenv, gmtime, localtime, asctime.
5125 Without this fix, interrupts could mess up code that uses these
5126 nonreentrant functions, since setting TZ invalidates existing
5127 tm_zone or tzname values, and since most of these functions return
5128 pointers to static storage.
5129 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5130 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5131 Grow the critical sections to include not just invoking
5132 localtime/gmtime, but also accessing these functions' results
5133 including their tm_zone values if any, and any related TZ setting.
5134 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5135 so that the struct tm is saved in the critical section.
5136 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5137 motivated by the fact that memory allocation needs to be outside
5138 the critical section.
5139
0c16dfed
DA
51402012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5141
5142 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5143 with RESET_INTERVAL.
5144
5145 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5146 Remove duplicated buffer name initialization.
5147
3f83ace8
JM
51482012-05-02 Jim Meyering <jim@meyering.net>
5149
5150 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5151
c7b8541e
JM
5152 * xfns.c (x_window): Use xstrdup (Bug#11375).
5153
90207a15 51542012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5155
5156 * xdisp.c (pos_visible_p): If already at a newline from the
5157 display string before the 'while' loop, don't walk back the glyphs
5158 from it3.glyph_row. Solves assertion violation when the display
5159 string begins with a newline (egg.el). (Bug#11367)
5160
b593d6a9
AH
51612012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5164 Move to simple.el.
5165
4737362e
GM
51662012-05-01 Glenn Morris <rgm@gnu.org>
5167
99cf43f9
GM
5168 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5169 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5170 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5171 All were removed before 23.1.
5172
9311dcff
GM
5173 * dispnew.c: Remove HAVE_LIBNCURSES test;
5174 it is always true on relevant platforms.
5175
4d5c6349
GM
5176 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5177 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5178
4737362e
GM
5179 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5180
74dd3a6b
AS
51812012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5182
5183 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5184 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5185 Remove.
5186
13c379ee
PE
51872012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 Do not avoid creating empty evaporating overlays (Bug#9642).
5190 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5191 That is, do not delete an evaporating overlay if it becomes
5192 empty after its bounds are adjusted to fit within its buffer.
5193 This fix caused other problems, and I'm reverting it until we get
5194 to the bottom of them.
5195
a8e7d6d7 51962012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5197
5198 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5199
a8e7d6d7 52002012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5201
5202 * xdisp.c (pos_visible_p): If the window start position is beyond
5203 ZV, start the display from buffer beginning. Prevents assertion
5204 violation in init_iterator when the minibuffer window is scrolled
5205 via the scroll bar.
5206
5207 * window.c (window_scroll_pixel_based): Likewise.
5208
a8e7d6d7 52092012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5210
5211 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5212
a8e7d6d7 52132012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5214
5215 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5216 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5217
a8e7d6d7 52182012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5219
b593d6a9
AH
5220 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5221 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5222
1c6900d9
EZ
52232012-04-26 Eli Zaretskii <eliz@gnu.org>
5224
4c3fa1d9
EZ
5225 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5226 display element, check also the underlying string or buffer
5227 character. (Bug#11341)
5228
1c6900d9
EZ
5229 * w32menu.c: Include w32heap.h.
5230 (add_menu_item): If the call to AppendMenuW (via
5231 unicode_append_menu) fails, disable Unicode menus only if we are
5232 running on Windows 9X/Me.
5233
42bf8205
AS
52342012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5235
5236 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5237 (xgetint): Add missing shift for LSB tags.
5238
b1bac16e
MR
52392012-04-24 Martin Rudalics <rudalics@gmx.at>
5240
5241 * keyboard.c (read_char): Don't wipe echo area for select window
5242 events: These might get delayed via `mouse-autoselect-window'
5243 (Bug#11304).
5244
d69621cc
JB
52452012-04-24 Juanma Barranquero <lekktu@gmail.com>
5246
5247 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5248 manipulation of :loaded-from data.
5249
02fd101b
JB
52502012-04-23 Juanma Barranquero <lekktu@gmail.com>
5251
5252 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5253 now a cons (bug#11311).
5254
888bec30
PE
52552012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5256
89a438bd
PE
5257 Do not create empty overlays with the evaporate property (Bug#9642).
5258 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5259 if it becomes empty after its bounds are adjusted to fit within
5260 its buffer. Without this fix, in a nonempty buffer (let ((o
5261 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5262 yields an empty overlay that has the evaporate property, which is
5263 not supposed to happen.
5264
1068fe4d
PE
5265 Fix minor GTK3 problems found by static checking.
5266 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5267 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5268 (struct _EmacsFixedClass, emacs_fixed_get_type):
5269 Move decls here from emacsgtkfixed.h, since they needn't be public.
5270 (emacs_fixed_get_type): Now static.
5271 (emacs_fixed_class_init): Omit unused local.
5272 (emacs_fixed_child_type): Remove; unused.
5273 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5274 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5275 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5276 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5277 (EMACS_FIXED_GET_CLASS): Remove; unused.
5278 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5279
888bec30
PE
5280 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5281 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5282
de85e130
PE
52832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5284
d0baac98 5285 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5286 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5287 (__malloc_size_t, __malloc_ptrdiff_t):
5288 Remove. All uses removed, replaced by the definiens if needed,
5289 since we can assume C89 or better now.
5290 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5291 (protect_malloc_state, align, get_contiguous_space)
5292 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5293 (malloc_atfork_handler_child, malloc_enable_thread)
5294 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5295 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5296 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5297 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5298 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5299 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5300 Define using prototypes, not old style.
5301 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5302 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5303 (align): Don't assume that signed integer overflow wraps around.
5304 Omit unused local var.
5305 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5306 (_free_internal_nolock, memalign, mallochook, reallochook):
5307 Omit no-longer-needed casts.
5308 (valloc): Use getpagesize, not __getpagesize.
5309 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5310 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5311
de85e130
PE
5312 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5313
dcbf5805
MA
53142012-04-22 Michael Albinus <michael.albinus@gmx.de>
5315
5316 Move functions from C to Lisp. Make non-blocking method calls
5317 the default. Implement further D-Bus standard interfaces.
5318
5319 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5320 (QCdbus_request_name_allow_replacement)
5321 (QCdbus_request_name_replace_existing)
5322 (QCdbus_request_name_do_not_queue)
5323 (QCdbus_request_name_reply_primary_owner)
5324 (QCdbus_request_name_reply_in_queue)
5325 (QCdbus_request_name_reply_exists)
5326 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5327 (QCdbus_registered_serial, QCdbus_registered_method)
5328 (QCdbus_registered_signal): New Lisp objects.
5329 (XD_DEBUG_MESSAGE): Use sizeof.
5330 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5331 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5332 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5333 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5334 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5335 (xd_signature, xd_append_arg): Allow float for integer types.
5336 (xd_get_connection_references): New function.
b593d6a9
AH
5337 (xd_get_connection_address): Rename from xd_initialize.
5338 Return cached address.
dcbf5805
MA
5339 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5340 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5341 level.
5342 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5343 Return number of refcounts.
dcbf5805
MA
5344 (Fdbus_get_unique_name): Make stronger parameter check.
5345 (Fdbus_message_internal): New defun.
5346 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5347 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5348 (Fdbus_send_signal, Fdbus_register_service)
5349 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5350 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5351 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5352 (Vdbus_compiled_version, Vdbus_runtime_version)
5353 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5354 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5355 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5356 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5357 Adapt docstring.
dcbf5805 5358
52828e02
PE
53592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5360
da05bc4c
PE
5361 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5362 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5363 Do not assume ptrdiff_t is the same width as 'int'.
5364
52828e02
PE
5365 * alloc.c: Handle unusual debugging option combinations.
5366 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5367 since the two debugging options are incompatible.
5368 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5369 is defined.
5370 (mem_init, mem_insert, mem_insert_fixup):
5371 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5372 (NEED_MEM_INSERT): Remove; no longer needed.
5373
f01769f9
LL
53742012-04-22 Leo Liu <sdl.web@gmail.com>
5375
5376 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5377
5790543d
PE
53782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5379
5380 * sysdep.c [__FreeBSD__]: Minor cleanups.
5381 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5382 Use Emacs indenting style more consistently. Avoid some casts.
5383 Use 'double' consistently rather than mixing 'float' and 'double'.
5384
b91b7e4d
EW
53852012-04-21 Eduard Wiebe <usenet@pusto.de>
5386
b593d6a9
AH
5387 * sysdep.c (list_system_processes, system_process_attributes):
5388 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5389
6114eb15
AS
53902012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5391
5392 * lisp.mk (lisp): Update.
5393
2f38dff7
PE
53942012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5395
5396 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5397 It is never used otherwise.
5398
4ae29f89
SM
53992012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5400
5401 * print.c (print_preprocess): Only check print_depth if print-circle
5402 is nil.
5403 (print_object): Check for cycles even when print-circle is nil and
5404 print-gensym is t, but only check print_depth if print-circle is nil.
5405
f30d612a
CY
54062012-04-20 Chong Yidong <cyd@gnu.org>
5407
5408 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5409 set the status to "failed" and ensure that sentinel is run.
5410
c07a4c0b 54112012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5412
5413 * process.c (Fset_process_inherit_coding_system_flag)
5414 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5415 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5416
c07a4c0b 54172012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5418
5419 * xdisp.c (string_buffer_position_lim): Limit starting position to
5420 BEGV.
5421 (set_cursor_from_row): If called for a mode-line or header-line
5422 row, return zero immediately.
5423 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5424 farther than the first row after the header line, if any.
5425 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5426 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5427
c07a4c0b 54282012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5429
4ae29f89
SM
5430 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5431 (bug#11238).
ad3a2b41 5432
c07a4c0b 54332012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54342012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5435
5436 configure: new option --enable-gcc-warnings (Bug#11207)
5437 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5438 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5439 (ALL_CFLAGS): Use new macros rather than old.
5440 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5441 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5442 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5443 -Wunused-result, -Wunused-variable. This should go away once
5444 the Emacs and Gnulib regex code is merged.
5445 (xmalloc, xrealloc): Now static.
5446
aba027e8
PE
54472012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5448
5449 * dired.c (Fsystem_groups): Remove unused local.
5450
e5a36063
GM
54512012-04-17 Glenn Morris <rgm@gnu.org>
5452
5453 * dired.c (Fsystem_users): Doc fix.
5454
316411f0
DA
54552012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5456
5457 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5458 (syms_of_dired): Add them.
5459
9426aba4
PE
54602012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5461
b62a57be
PE
5462 Fix minor alloc.c problems found by static checking.
5463 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5464 New extern decls, to avoid calling undeclared functions.
5465 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5466 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5467 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5468 (NEED_MEM_INSERT): New macro.
5469 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5470 Remove one incorrect comment and fix another.
b62a57be 5471
3539f31f
PE
5472 Fix minor ralloc.c problems found by static checking.
5473 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5474 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5475 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5476 (r_alloc_sbrk): Now static.
5477
a041960a
PE
5478 Improve ralloc.c interface checking.
5479 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5480 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5481 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5482 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5483 [REL_ALLOC]: ... to here, to check interface.
5484 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5485 Remove decls. This fixes an "It stinks!".
5486
9426aba4
PE
5487 * alloc.c (which_symbols): Fix alignment issue / type clash.
5488
d55c12ed
AS
54892012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5490
5491 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5492 (struct Lisp_Misc_Any): Likewise.
5493 (struct Lisp_Free): Likewise.
5494 * alloc.c (union aligned_Lisp_Symbol): Define.
5495 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5496 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5497 (union aligned_Lisp_Misc): Define.
5498 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5499 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5500 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5501
b948ce8b
PE
55022012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5503
5504 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5505 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5506 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5507 * s/netbsd.h, s/sol2-6.h:
5508 Remove definition of GC_MARK_STACK, since the default now works.
5509 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5510 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5511 no longer the default.
5512 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5513
35dc09a1 55142012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5515
35dc09a1
GM
5516 * lread.c (lisp_file_lexically_bound_p):
5517 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5518
35dc09a1
GM
55192012-04-14 Eli Zaretskii <eliz@gnu.org>
5520
5521 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5522 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5523
55242012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5525
5526 * nsterm.m (constrainFrameRect): Always constrain when there is only
5527 one screen (Bug#10962).
5528
bcd86815
KB
55292012-04-13 Ken Brown <kbrown@cornell.edu>
5530
5531 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5532
c25df26e
RT
55332012-04-13 Reuben Thomas <rrt@sc3d.org>
5534
5535 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5536
0fc59f1e
DC
55372012-04-11 Daniel Colascione <dancol@dancol.org>
5538
5539 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5540 against is gone. It's better to use vfork now so that when Cygwin
5541 gains a new, working vfork, we use it automatically (bug#10398).
5542
de8c03dc
SM
55432012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5544
5545 * window.c (save_window_save): Obey window-point-insertion-type.
5546
2f097256
GM
55472012-04-11 Glenn Morris <rgm@gnu.org>
5548
5549 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5550
453b951e
SM
55512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5552
5553 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5554
75f1671a 55552012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5556
5557 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5558 (force_quit_count): New var.
5559 (handle_interrupt): Use it.
5560
2a8ce227
JB
55612012-04-10 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * w32.c (w32_delayed_load): Record the full path of the library
5564 being loaded (bug#10424).
5565
935396c0
GM
55662012-04-09 Glenn Morris <rgm@gnu.org>
5567
05920a43
GM
5568 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5569 not just in the obarray, before snarfing them. (Bug#11036)
5570
935396c0
GM
5571 * Makefile.in ($(leimdir)/leim-list.el):
5572 Pass EMACS rather than BUILT_EMACS.
5573
a18ecafa
TZ
55742012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5575
5576 * process.c (make_process):
5577 * process.h: Add integer `gnutls_handshakes_tried' member to
5578 process struct.
5579
6bbef4e5
JC
5580 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5581 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5582
5583 * gnutls.c (gnutls_log_function2i): Convenience log function.
5584 (emacs_gnutls_read): Use new log functions,
5585 `gnutls_handshakes_tried' process member, and
5586 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5587 attempts per process (connection).
5588
b4d3bc10
CY
55892012-04-09 Chong Yidong <cyd@gnu.org>
5590
5591 * eval.c (Fuser_variable_p, user_variable_p_eh)
5592 (lisp_indirect_variable): Functions deleted.
5593 (Fdefvar): Caller changed.
5594
5595 * callint.c (Finteractive, Fcall_interactively):
5596 * minibuf.c (Fread_variable): Callers changed.
5597
70f4d973
EZ
55982012-04-09 Eli Zaretskii <eliz@gnu.org>
5599
5600 * xdisp.c (set_cursor_from_row): If the display string appears in
5601 the buffer at position that is closer to point than the position
5602 after the display string, display the cursor on the first glyph of
5603 the display string. Fixes cursor display when a 'display' text
5604 property immediately follows invisible text. (Bug#11094)
5605
cb3c2e3e
PE
56062012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5607
5608 composite.c: use 'double' consistently
5609 * composite.c (get_composition_id): Use 'double' consistently
5610 instead of converting 'float' to 'double' and vice versa; this is
5611 easier to understand and avoids a GCC warning.
5612
fd06db5d
GM
56132012-04-09 Glenn Morris <rgm@gnu.org>
5614
50fe702a
GM
5615 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5616 preparation for dumping it with emacs. (Bug#4789)
5617 (leimdir): New variable.
5618 ($(leimdir)/leim-list.el): New rule.
5619 (emacs$(EXEEXT)): Depend on leim-list.el.
5620
fd06db5d
GM
5621 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5622 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5623 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5624
55c131ee
AS
56252012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5626
5627 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5628 proper alignment.
5629
9209588f
JB
56302012-04-07 Juanma Barranquero <lekktu@gmail.com>
5631
5632 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5633 Remove unused local variable.
5634
e3fb2efb
PE
56352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5638 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5639 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5640 objects, as mark_maybe_pointer will catch them otherwise.
5641 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5642 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5643
b5385551
PE
56442012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 Fix typo that broke non-Windows builds.
5647 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5648
9078ead6
EZ
56492012-04-07 Eli Zaretskii <eliz@gnu.org>
5650
5651 Support building on MS-Windows with libxml2.
5652
5653 * makefile.w32-in (OBJ2): Add xml.$(O).
5654 (GLOBAL_SOURCES): Add xml.c.
5655 ($(BLD)/xml.$(O)): New dependency list.
5656
5657 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5658 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5659 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5660 [!WINDOWSNT]: New macros.
5661 (init_libxml2_functions, libxml2_loaded_p): New functions.
5662 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5663 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5664 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5665 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5666 linked in).
6bbef4e5
JC
5667 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5668 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5669 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5670
5671 * emacs.c: Don't include libxml/parser.h.
5672 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5673 xmlCleanupParser directly.
5674
5675 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5676
3811fdf3
EZ
56772012-04-07 Eli Zaretskii <eliz@gnu.org>
5678
5679 * indent.c (Fvertical_motion): If there is a display string at
5680 point, use it.vpos to compute how many lines to backtrack after
5681 move_it_to point. (Bug#11133)
5682
2f8e16b2
EZ
56832012-04-06 Eli Zaretskii <eliz@gnu.org>
5684
5685 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5686 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5687 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5688 macros related to unification of CJK characters. For the details,
5689 see the discussion following the message here:
5690 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5691
3d439cd1
CY
56922012-04-04 Chong Yidong <cyd@gnu.org>
5693
5694 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5695
8bc53d00
EZ
56962012-04-01 Eli Zaretskii <eliz@gnu.org>
5697
5698 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5699 instead of alloca. (Bug#11138)
5700
3b0512a3
AS
57012012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5702
5703 * w32menu.c (is_simple_dialog): Properly check lisp types.
5704 (Bug#11141)
5705
8427ddd2
EZ
57062012-03-31 Eli Zaretskii <eliz@gnu.org>
5707
979022ef
EZ
5708 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5709 position we get to after a call to move_it_to fails the
5710 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5711 only if we wind up in a string from display property. (Bug#11063)
5712
a6b1c7cc
EZ
5713 * window.c (Fdelete_other_windows_internal): Invalidate the row
5714 and column information about mouse highlight, so that redisplay
5715 restores it after reallocating the glyph matrices. (Bug#7464)
5716
8427ddd2
EZ
5717 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5718 string comes from a `display' text property, use the buffer
5719 position of that property as if we actually saw that position in
5720 the row's glyphs.
697ba24b
EZ
5721 (move_it_by_lines): Remove the assertion that
5722 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5723 violated when there's a before-string at the beginning of a line.
5724 (Bug#11063)
8427ddd2 5725
65a0a738
EZ
57262012-03-30 Eli Zaretskii <eliz@gnu.org>
5727
5728 * xdisp.c (append_space_for_newline): If the default face was
5729 remapped, use the remapped face for the appended newline.
5730 (extend_face_to_end_of_line): Use the remapped default face for
5731 extending the face to the end of the line.
5732 (display_line): Call extend_face_to_end_of_line when the default
5733 face was remapped. (Bug#11068)
5734
581355cc
EZ
57352012-03-29 Eli Zaretskii <eliz@gnu.org>
5736
5737 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5738
e8fc049f
SM
57392012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5740
5741 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5742
4fb9a543
GM
57432012-03-27 Glenn Morris <rgm@gnu.org>
5744
5745 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5746 Doc fixes.
5747
679910f1
KH
57482012-03-26 Kenichi Handa <handa@m17n.org>
5749
5750 * dispextern.h (struct glyph): Fix previous change. Change the
5751 bit length of glyphless.ch to 25 (Bug#11082).
5752
90d49b7f
CY
57532012-03-26 Chong Yidong <cyd@gnu.org>
5754
5755 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5756 (command_loop_1): Use it; inhibit selection update for
5757 handle-select-window too (Bug#8996).
5758
f514f6f0
FP
57592012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5760
e8fc049f 5761 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5762
bf43fa51
KH
57632012-03-25 Kenichi Handa <handa@m17n.org>
5764
5765 * dispextern.h (struct glyph): Change the bit length of
5766 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5767
8a0c01dd
EZ
57682012-03-24 Eli Zaretskii <eliz@gnu.org>
5769
5770 * s/ms-w32.h (tzname): Include time.h before redirecting to
5771 _tzname. Fixes the MSVC build. (Bug#9960)
5772
7d1c3a76
AS
57732012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5774
8ed79523
AS
5775 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5776 characters.
5777
7d1c3a76
AS
5778 * xterm.c (XTread_socket): Only modify handling_signal if
5779 !SYNC_INPUT. (Bug#11080)
5780
e99a9b8b
EZ
57812012-03-23 Eli Zaretskii <eliz@gnu.org>
5782
5783 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5784 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5785 when fetching a multibyte character consumes more bytes than
5786 CHAR_BYTES returns, due to unification of CJK characters in
5787 string_char. (Bug#11073)
5788
5063c0e1
TN
57892012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5790
5791 * process.c (wait_reading_process_output): Handle pty disconnect
5792 by refraining from sending oneself a SIGCHLD (bug#10933).
5793
9f851fbd
CY
57942012-03-22 Chong Yidong <cyd@gnu.org>
5795
5796 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5797
5063c0e1 5798 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5799 Mark string as coming from a prefix property.
5800 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5801 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5802
fb5b8aca
CY
58032012-03-21 Chong Yidong <cyd@gnu.org>
5804
5805 * xfaces.c (Vface_remapping_alist): Doc fix.
5806
62356a1b
EZ
58072012-03-20 Eli Zaretskii <eliz@gnu.org>
5808
5809 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5810 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5811 Doc fixes.
62356a1b 5812
025de85b
CY
58132012-03-20 Chong Yidong <cyd@gnu.org>
5814
5815 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5816 to reflect default non-nil value of redisplay-dont-pause.
5817
4827f94e
KH
58182012-03-19 Kenichi Handa <handa@m17n.org>
5819
5820 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5821 it fit in a valid range (Bug#11003).
5822
e50a24a2
EZ
58232012-03-18 Eli Zaretskii <eliz@gnu.org>
5824
5825 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5826 that is not from display property, accept the row as a "cursor
5827 row" if one of the string's character has a non-nil `cursor'
5828 property. Fixes cursor positioning when there are newlines in
5829 overlay strings, e.g. in icomplete.el. (Bug#11035)
5830
9af5ed87
PE
58312012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5834
d1f55f16
CY
58352012-03-12 Chong Yidong <cyd@gnu.org>
5836
5837 * eval.c (inhibit_lisp_code): Rename from
5838 inhibit_window_configuration_change_hook; move from window.c.
5839
5840 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5841 * window.c (run_window_configuration_change_hook)
5842 (syms_of_window): Callers changed.
5843
66c5eebd
CY
58442012-03-11 Chong Yidong <cyd@gnu.org>
5845
413df973
CY
5846 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5847
66c5eebd
CY
5848 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5849
1de11f56
CY
58502012-03-10 Chong Yidong <cyd@gnu.org>
5851
5852 * frame.c (other_visible_frames): Don't assume the selected frame
5853 is visible (Bug#10955).
5854
cae07000
SM
58552012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5856
5857 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5858
89c94350
JD
58592012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5860
5861 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5862 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5863 zero (Bug#10954).
5864
999dd333
GM
58652012-03-03 Glenn Morris <rgm@gnu.org>
5866
01a6dcc8 5867 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5868
de0100f2
EZ
58692012-03-02 Eli Zaretskii <eliz@gnu.org>
5870
5871 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5872 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5873 (redisplay_window, next_element_from_string): Fix typos in
5874 comments.
3e441275
EZ
5875 (redisplay_window): Pass to move_it_vertically the margin in
5876 pixels, not in screen lines.
de0100f2 5877
96a72ee9
GM
58782012-03-02 Glenn Morris <rgm@gnu.org>
5879
5880 * buffer.c (buffer-list-update-hook): Doc fix.
5881
312508d7
EZ
58822012-02-29 Eli Zaretskii <eliz@gnu.org>
5883
5884 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5885 push_it before setting up the iterator for the first overlay
5886 string, even if we have an empty string loaded.
5887 (next_overlay_string): If there's an empty string on the iterator
5888 stack, pop the stack. (Bug#10903)
5889
27f3c637
PE
58902012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5891
5892 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5893 Suggested by Stefan Monnier in
5894 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5895 * alloc.c (widen_to_Lisp_Object): New static function.
5896 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5897 and widening them to Lisp_Objects. This would work even if
5898 USE_LSB_TAG is defined and wide integers are used, which might
5899 happen in a future version of Emacs.
5900
3c9dfce6
CY
59012012-02-25 Chong Yidong <cyd@gnu.org>
5902
fa74b241
CY
5903 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5904 Doc fix.
5905
3c9dfce6
CY
5906 * xselect.c (Fx_selection_exists_p): Doc fix.
5907 (x_clipboard_manager_save_all): Print an informative message
5908 before saving to clipboard manager.
5909
9486df08
CY
59102012-02-24 Chong Yidong <cyd@gnu.org>
5911
5912 * keyboard.c (process_special_events): Handle all X selection
5913 requests in kbd_buffer, not just the next one (Bug#8869).
5914
f01d3321
CY
59152012-02-23 Chong Yidong <cyd@gnu.org>
5916
5917 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5918 call when setting menu-bar-lines and tool-bar-lines parameters.
5919 (unwind_create_frame_1): New helper function.
5920
5921 * window.c (inhibit_window_configuration_change_hook): New var.
5922 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5923 (syms_of_window): Initialize it.
f01d3321 5924
86b847b6
CY
59252012-02-22 Chong Yidong <cyd@gnu.org>
5926
5927 * xterm.c (x_draw_image_relief): Add missing type check for
5928 Vtool_bar_button_margin (Bug#10743).
5929
a59225b1
CY
59302012-02-21 Chong Yidong <cyd@gnu.org>
5931
5932 * fileio.c (Vfile_name_handler_alist): Doc fix.
5933
5934 * buffer.c (Fget_file_buffer): Protect against invalid file
5935 handler return value.
5936
310f5bd4
PE
59372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5938
cb3a28cc
PE
5939 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5940 when computing $valmask.
5941
310f5bd4
PE
5942 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5943 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5944 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5945 It's useless in that case, and it can cause problems on hosts
5946 that allocate halves of EMACS_INT values separately.
5947 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5948 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5949 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5950 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5951 it avoids undefined behavior on hosts where shifting right by more
5952 than the word width has undefined behavior.
5953
2375c96a
CY
59542012-02-19 Chong Yidong <cyd@gnu.org>
5955
5956 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5957 (Funhandled_file_name_directory, Ffile_name_as_directory)
5958 (Fdirectory_file_name, Fexpand_file_name)
5959 (Fsubstitute_in_file_name): Protect against invalid file handler
5960 return values (Bug#10845).
5961
3eb49e71
EZ
59622012-02-18 Eli Zaretskii <eliz@gnu.org>
5963
5964 * .gdbinit (pitx): Fix incorrect references to fields of the
5965 iterator stack.
5966
7b926f3f
CY
59672012-02-17 Chong Yidong <cyd@gnu.org>
5968
5969 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5970
11273115
PE
59712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5972
5973 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5974 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5975
c3a70e2b
CY
59762012-02-15 Chong Yidong <cyd@gnu.org>
5977
5978 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5979 marked as special. Also, starting docstrings with * is obsolete.
5980
0ca43699
AS
59812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5982
5983 * gnutls.c (emacs_gnutls_write): Fix last change.
5984
2e8f3c56
LI
59852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5986
5987 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5988 send_process.
5989
af70074f
SM
59902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5991
5992 * keymap.c (Fsingle_key_description): Handle char ranges.
5993
95986d52
CY
59942012-02-12 Chong Yidong <cyd@gnu.org>
5995
afd83bd1
CY
5996 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5997 as that creates a dangerous corner case.
5998
95986d52
CY
5999 * window.c (Fdelete_window_internal): Invalidate the mouse
6000 highlight (Bug#9904).
6001
bd7da63e
GM
60022012-02-12 Glenn Morris <rgm@gnu.org>
6003
6004 * xselect.c (Fx_own_selection_internal)
6005 (Fx_get_selection_internal, Fx_disown_selection_internal)
6006 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6007 * nsselect.m (Fx_own_selection_internal)
6008 (Fx_disown_selection_internal, Fx_selection_exists_p)
6009 (Fx_selection_owner_p, Fx_get_selection_internal):
6010 Sync docs and argument specs with the xselect.c versions.
6011
77abcbc2
LI
60122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6013
6014 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6015
90b671e2
EZ
60162012-02-11 Eli Zaretskii <eliz@gnu.org>
6017
1c0ca0b7
EZ
6018 * w32select.c (Fx_selection_exists_p): Sync doc string and
6019 argument list with xselect.c. (Bug#10783)
6020
6021 * w16select.c (Fx_selection_exists_p): Sync doc string and
6022 argument list with xselect.c. (Bug#10783)
90b671e2 6023
49241268
GM
60242012-02-10 Glenn Morris <rgm@gnu.org>
6025
6026 * fns.c (Fsecure_hash): Doc fix.
6027
f998bbe7 60282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6029
6030 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6031
0992bd9c
CY
60322012-02-07 Chong Yidong <cyd@gnu.org>
6033
6034 * buffer.c (Fbuffer_local_variables)
6035 (buffer_lisp_local_variables): Handle unbound vars correctly;
6036 don't let Qunbound leak into Lisp.
6037
af008560
GM
60382012-02-07 Glenn Morris <rgm@gnu.org>
6039
dd605cc4
GM
6040 * image.c (Fimagemagick_types): Doc fix.
6041
af008560
GM
6042 * image.c (imagemagick-render-type): Change it from a lisp object
6043 to an integer. Move the doc here from the lisp manual.
6044 Treat all values not equal to 0 the same.
6045
1449fa1d
CY
60462012-02-06 Chong Yidong <cyd@gnu.org>
6047
6048 * doc.c (store_function_docstring): Avoid applying docstring of
6049 alias to base function (Bug#2603).
6050
3723ec07
AS
60512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6052
6053 * .gdbinit (pp1, pv1): Remove redundant defines.
6054 (pr): Use pp.
6055
79c1cc1e
CY
60562012-02-04 Chong Yidong <cyd@gnu.org>
6057
6058 * nsterm.m: Declare a global (Bug#10694).
6059
d7f29f8e
EZ
60602012-02-04 Eli Zaretskii <eliz@gnu.org>
6061
cae07000
SM
6062 * w32.c (get_emacs_configuration_options):
6063 Include --enable-checking, if specified, in the return value.
d7f29f8e 6064
3b95a6f9
MR
60652012-02-04 Martin Rudalics <rudalics@gmx.at>
6066
6067 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6068 after rounding frame sizes. (Bug#9723)
6069
d6fa96a6
EZ
60702012-02-04 Eli Zaretskii <eliz@gnu.org>
6071
6072 * keyboard.c (adjust_point_for_property): Don't position point
6073 before BEGV. (Bug#10696)
6074
df0b2940
PE
60752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6076
6077 Handle overflow when computing char display width (Bug#9496).
6078 * character.c (char_width): Return EMACS_INT, not int.
6079 (char_width, c_string_width): Check for overflow when
6080 computing the width; this is possible now that individual
6081 characters can have unbounded width. Problem introduced
6082 by merge from Emacs 23 on 2012-01-19.
6083
6bee44d6
MA
60842012-02-02 Michael Albinus <michael.albinus@gmx.de>
6085
6086 * dbusbind.c (Fdbus_register_method): Mention the return value
6087 :ignore in the docstring.
6088
44f92739
GM
60892012-02-02 Glenn Morris <rgm@gnu.org>
6090
1b9f60cc
GM
6091 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6092
44f92739
GM
6093 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6094 Unconditionally set to t. (Bug#10673)
6095 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6096 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6097 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6098
c5d3843c
KH
60992012-02-02 Kenichi Handa <handa@m17n.org>
6100
6101 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6102 0, do not call append_composite_glyph.
6103
159462d4 61042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6105
6106 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6107 NULL (Bug#6988).
6108 (x_produce_glyphs): If the component of a composition is a null
6109 string, set it->pixel_width to 1 to avoid zero-width glyph.
6110
78cef877
EZ
61112012-02-01 Eli Zaretskii <eliz@gnu.org>
6112
6113 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6114 first 2 arguments are identical. This makes inserting large
6115 output from a subprocess an order of magnitude faster on
6116 MS-Windows, where all sbrk'ed memory is always contiguous.
6117
97897668
GM
61182012-01-31 Glenn Morris <rgm@gnu.org>
6119
6120 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6121 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6122 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6123
31fd3586
GM
61242012-01-29 Glenn Morris <rgm@gnu.org>
6125
6126 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6127
0e24a8b2
CY
61282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6129
6130 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6131
cc0adcb0
CY
61322012-01-28 Chong Yidong <cyd@gnu.org>
6133
6134 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6135
acc28cb9
CY
61362012-01-26 Chong Yidong <cyd@gnu.org>
6137
9c69cfb7
CY
6138 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6139
acc28cb9
CY
6140 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6141 repeat counts (Bug#10507).
6142
48da7392
GM
61432012-01-26 Glenn Morris <rgm@gnu.org>
6144
6145 * lread.c (syms_of_lread): Doc fix.
6146
14af5f7f
CY
61472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6148
6149 * coding.c (encode_designation_at_bol): Change return value to
6150 EMACS_INT.
6151
0b21c100
CY
61522012-01-25 Chong Yidong <cyd@gnu.org>
6153
6154 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6155
3c2907f7
CY
61562012-01-21 Chong Yidong <cyd@gnu.org>
6157
6158 * floatfns.c (Fcopysign): Make the second argument non-optional,
6159 since nil is not allowed anyway.
6160
959ad23f
AS
61612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6162
6163 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6164 (send_process): Likewise.
6165
34a02f46
MR
61662012-01-19 Martin Rudalics <rudalics@gmx.at>
6167
6168 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6169 (Vwindow_persistent_parameters): Do not use Qstate.
6170 Rewrite doc-strings.
34a02f46 6171
1259009a 61722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6173
6174 * character.c (char_width): New function.
70d4fdf6
GM
6175 (Fchar_width, c_string_width, lisp_string_width):
6176 Use char_width (Bug#9496).
25ed9e61 6177
6a6ee00d
MR
61782012-01-16 Martin Rudalics <rudalics@gmx.at>
6179
6180 * window.c (Vwindow_persistent_parameters): New variable.
6181 (Fset_window_configuration, save_window_save): Handle persistent
6182 window parameters.
6183
c85efaf7
EZ
61842012-01-14 Eli Zaretskii <eliz@gnu.org>
6185
6186 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6187 thrashing the stack of the thread. (Bug#9087)
6188
5944709e
PE
61892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6190
6191 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6192
e71f5d99
EZ
61932012-01-11 Eli Zaretskii <eliz@gnu.org>
6194
6195 * xdisp.c (rows_from_pos_range): Handle the case where the
6196 highlight ends on a newline. (Bug#10464)
6197 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6198 he end column for display of highlight that ends on a newline
6199 before a R2L line.
6200
ce316182
GM
62012012-01-11 Glenn Morris <rgm@gnu.org>
6202
6203 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6204 from load-path also when installation-directory is nil. (Bug#10208)
6205
5b43da69
GM
62062012-01-10 Glenn Morris <rgm@gnu.org>
6207
74cc8ff9
GM
6208 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6209
7d8d6e4e
GM
6210 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6211 Update template values to be closer to their typical values these days.
5b43da69 6212
a0db8d43
EZ
62132012-01-09 Eli Zaretskii <eliz@gnu.org>
6214
6215 * xdisp.c (rows_from_pos_range): Accept additional argument
6216 DISP_STRING, and accept any glyph in a row whose object is that
6217 string as eligible for mouse highlight. Fixes mouse highlight of
6218 display strings from overlays. (Bug#10464)
6219
9a0115ab 62202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6221
b9110d6a 6222 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6223 * fileio.c (auto_saving_dir_umask): New static var.
6224 (Fmake_directory_internal): Use it.
6225 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6226 creating the directory. The old code temporarily assigns
6227 too-generous permissions to the directory.
6228 (do_auto_save_eh): Clear it.
b9110d6a 6229 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6230 that the var is always cleared.
6231
6c1bd3f3
EZ
62322012-01-07 Eli Zaretskii <eliz@gnu.org>
6233
6234 * search.c (scan_buffer): Pass character positions to
6235 know_region_cache, not byte positions. (Bug#6540)
6236
069d2b50
L
62372012-01-07 LynX <_LynX@bk.ru> (tiny change)
6238
6239 * w32.c (sys_rename): Report EXDEV when rename of a directory
6240 fails because the target is on another logical disk. (Bug#10284)
6241
75bf0d33
DB
62422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6243
6244 * xterm.c (x_embed_request_focus): New function.
6245
6246 * xterm.h: Add prototype.
6247
6248 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6249
1c6e5a32
GM
62502012-01-05 Glenn Morris <rgm@gnu.org>
6251
6252 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6253
651e947e
EZ
62542012-01-01 Eli Zaretskii <eliz@gnu.org>
6255
6256 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6257 Load gnutls_transport_set_lowat only if GnuTLS version is below
6258 2.11.1.
6259 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6260 GnuTLS versions below 2.11.1.
6261
3778cdd8
AL
62622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6263
6264 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6265 to the doc string advising against its use for altering the way
6266 windows are scrolled.
6267
0e5317f7
KH
62682011-12-28 Kenichi Handa <handa@m17n.org>
6269
6270 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6271 coding-system ASCII compatible only when it does not produce BOM
6272 on encoding (Bug#10383).
6273
93d5ca1f
JD
62742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6275
6276 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6277 can scroll.
6278 (create_and_show_popup_menu): Always use menu_position_func for
6279 Gtk3 (Bug#10361).
6280
ca22b785
AS
62812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6282
6283 * callint.c (Fcall_interactively): Don't truncate prompt string.
6284
d048e1e6
EZ
62852011-12-23 Eli Zaretskii <eliz@gnu.org>
6286
6287 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6288 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6289 resumed from there (after widening). (Bug#10360)
d048e1e6 6290
5ccaba1f
JD
62912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6292
6293 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6294
204ee57f
JD
62952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6296
b81d40f0
JB
6297 * nsterm.m (x_free_frame_resources):
6298 Release f->output_data.ns->miniimage.
204ee57f
JD
6299 (ns_index_color): Fix indentation. Do not retain
6300 color_table->colors[i].
6301
6302 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6303 before returning.
6304
6305 * nsfns.m (x_set_background_color): Assign return value from
6306 ns_index_color to face-background instead of NSColor*.
6307 (ns_implicitly_set_icon_type): Fix indentation.
6308 Change assignment in for loop to comparison.
6309
6310 * emacs.c (ns_pool): New variable.
6311 (main): Assign ns_pool.
6312 (Fkill_emacs): Call ns_release_autorelease_pool.
6313
6314 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6315 autorelease fdesc, release fdAttrs and tdict.
6316 (ns_get_covering_families): Release charset.
6317 (ns_findfonts): Release NSFontDescriptor created with new.
6318 (ns_uni_to_glyphs): Fix indentation.
6319 (setString): Release attrStr before assigning new value.
6320
c803b2b7
JD
63212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6322
678f4426
JD
6323 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6324 and NS_IMPL_COCOA.
6325 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6326 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6327
cd394be1 63282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6329
5fecd5fc
JD
6330 * nsterm.m (ns_term_init): Subscribe for notifications
6331 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6332 to method trackingNotification in EmacsMenu.
6333
6334 * nsmenu.m (trackingMenu): New variable.
3771cb17 6335 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6336 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6337 from Aquamacs (Bug#7030).
678f4426
JD
6338
63392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6340
c803b2b7
JD
6341 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6342 (symbol_to_nsstring): Fix indentation.
6343 (ns_symbol_to_pb): New function.
cae07000
SM
6344 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6345 (Fns_rotate_cut_buffers_internal): Remove.
6346 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6347 Fns_store_cut_buffer_internal.
6348 (ns_get_foreign_selection, Fx_own_selection_internal)
6349 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6350 (Fns_get_selection_internal, Fns_store_selection_internal):
6351 Use ns_symbol_to_pb and check if return value is nil.
6352 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6353 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6354 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6355 renamed to Sns_store_selection_internal.
6356 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6357 and remove this function.
6358 (ns_handle_selection_clear): Remove, never used.
6359 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6360 here.
6361
e1b01a3a
KB
63622011-12-17 Ken Brown <kbrown@cornell.edu>
6363
6364 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6365 GID is unknown (Bug#10257).
6366
2adb6e85
PE
63672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6370 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6371 which caused a build failure on GNU/Linux IA-64. This problem was
6372 introduced by my 2011-10-07 patch.
6373
d1d7b339
JL
63742011-12-15 Juri Linkov <juri@jurta.org>
6375
6376 * image.c (imagemagick_error): New function. (Bug#10112)
6377 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6378 Use `imagemagick_error' where ImageMagick functions return
6379 `MagickFalse'.
6380 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6381 proper order.
6382
100d5755
KH
63832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6384
6385 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6386 fill background (Bug#8992).
6387
454592a6
MR
63882011-12-13 Martin Rudalics <rudalics@gmx.at>
6389
6390 * window.c (Vwindow_combination_resize)
6391 (Vwindow_combination_limit): Use t instead of non-nil in
6392 doc-strings.
61d4b438
MR
6393 (Vrecenter_redisplay): Add first sentence of doc-string on
6394 separate line.
53524d93 6395 (Frecenter): Fix doc-string typo.
454592a6 6396
3633e3aa
KH
63972011-12-11 Kenichi Handa <handa@m17n.org>
6398
6399 * coding.c (Funencodable_char_position): Pay attention to the
6400 buffer text relocation (Bug#9389).
6401
7b9d523a 64022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6403
7b9d523a
JD
6404 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6405 gtk_init (Bug#10100).
6406
b73189c6
EZ
64072011-12-10 Eli Zaretskii <eliz@gnu.org>
6408
6409 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6410 IT->string is nil. (Bug#10263)
6411
f7dfe5d6
JD
64122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6413
83faebb4
JD
6414 * nsterm.h (x_free_frame_resources): Declare.
6415
f7dfe5d6
JD
6416 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6417 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6418
6419 * nsterm.h (ns_get_defaults_value): Declare.
6420
6421 * nsterm.m (ns_default): Call ns_get_defaults_value.
6422
7cd4e72c
EZ
64232011-12-09 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6426 (Bug#10170)
6427
b34d7317
YM
64282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6429
6430 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6431 that where the value of an _OBJC_* symbol points to is in the .bss
6432 section (Bug#10240).
6433
76470ad1
KH
64342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6435
6436 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6437 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6438
745fff94
KH
64392011-12-08 Kenichi Handa <handa@m17n.org>
6440
6441 * ftfont.c (get_adstyle_property): Fix previous change
6442 (Bug#10233).
6443
6e44397c
JB
64442011-12-07 Juanma Barranquero <lekktu@gmail.com>
6445
6446 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6447 dirs from the default value of EMACSLOADPATH (bug#10208).
6448
7efa6272
GM
64492011-12-07 Glenn Morris <rgm@gnu.org>
6450
6451 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6452 installation and source directories as well. (Bug#10208)
6453
f6fc4d87
CY
64542011-12-06 Chong Yidong <cyd@gnu.org>
6455
6456 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6457
2bf26180
GM
64582011-12-06 Glenn Morris <rgm@gnu.org>
6459
6460 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6461 as an error, not just -1. (Bug#10217)
6462
3a6ad4f0
CY
64632011-12-05 Chong Yidong <cyd@gnu.org>
6464
6465 * keyboard.c (process_special_events): New function.
6466 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6467
75a3b399
PE
64682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6469
6470 * coding.c (encode_designation_at_bol): Don't use uninitialized
6471 local variable (Bug#9318).
6472
c3c9e25e
KH
64732011-12-05 Kenichi Handa <handa@m17n.org>
6474
6475 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6476 return Qnil (Bug#8046, Bug#10193).
6477
5eb05ea3
KH
64782011-12-05 Kenichi Handa <handa@m17n.org>
6479
6480 * coding.c (encode_designation_at_bol): New args charbuf_end and
6481 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6482 (coding_set_source): Return how many bytes coding->source was
6483 relocated.
6484 (coding_set_destination): Return how many bytes
6485 coding->destination was relocated.
6486 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6487 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6488
64892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6490
6491 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6492 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6493 macro (Bug#9318).
6494
64952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6496
6497 The following changes are to fix Bug#9318.
6498
a79703f5 6499 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6500 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6501 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6502 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6503
7dbda6df
JB
65042011-12-05 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * lisp.h (process_quit_flag): Fix external declaration.
6507
6d5eb5b0
SM
65082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6509
6510 Don't macro-inline non-performance-critical code.
6511 * eval.c (process_quit_flag): New function.
6512 * lisp.h (QUIT): Use it.
6513
a0c3fad0
JD
65142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6515
6516 * nsfns.m (get_geometry_from_preferences): New function.
6517 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6518
6c07aac2
AS
65192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6520
6521 * emacs.c (Qkill_emacs): Define.
6522 (syms_of_emacs): Initialize it.
6523 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6524 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6525 (quit_throw_to_read_char): Add parameter `from_signal'.
6526 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6527 * lisp.h (QUIT): Call Fkill_emacs if requested.
6528
c052ead4
JD
65292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6530
6531 * widget.c (update_wm_hints): Return if wmshell is null.
6532 (widget_update_wm_size_hints): New function.
6533
6534 * widget.h (widget_update_wm_size_hints): Declare.
6535
6536 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6537 widget_update_wm_size_hints (Bug#10104).
6538
9e49252b
EZ
65392011-12-03 Eli Zaretskii <eliz@gnu.org>
6540
6541 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6542 before a newline, prepare the bidi iterator for consuming the
6543 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6544 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6545
02b16839
JL
65462011-12-02 Juri Linkov <juri@jurta.org>
6547
6548 * search.c (Fword_search_regexp): New Lisp function created from
6549 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6550 (Fword_search_backward, Fword_search_forward)
6551 (Fword_search_backward_lax, Fword_search_forward_lax):
6552 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6553 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6554
0068070e
SM
65552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6556
6557 * fileio.c (Finsert_file_contents): Move after-change-function call
6558 to before the "handled:" label, since all "goto handled" appear in
6559 cases where the *-change-functions have already been properly called
6560 (bug#10117).
6561
3360a3fc
AS
65622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6563
6564 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6565 waiting for input. (Bug#10169)
6566
73d6c093
EZ
65672011-11-30 Eli Zaretskii <eliz@gnu.org>
6568
6569 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6570 verifies glyph row's hash code--we have just reallocated the
6571 glyphs, so their contents can be complete garbage. (Bug#10164)
6572
febe6bea
JB
65732011-11-30 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6576
801a4313
EZ
65772011-11-30 Eli Zaretskii <eliz@gnu.org>
6578
6579 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6580 attributes are tested _before_ calling verify_row_hash, to protect
6581 against GCC re-ordering of the tests. (Bug#10164)
6582
2b56b87e
JD
65832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6584
6585 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6586
6587 * xterm.c (handle_one_xevent): Only set async_visible and friends
6588 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6589 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6590 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6591
dbf31225
PE
65922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6595 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6596 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6597 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6598 All uses changed to use GCPRO1 etc.
6599 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6600 Revert to old implementation (i.e., before 2011-03-11).
6601
1305621b
YM
66022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6603
6604 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6605 of scroll runs so as to avoid assigning disabled bogus rows and
6606 unnecessary graphics copy operations.
6607
8c9afb46
EZ
66082011-11-27 Eli Zaretskii <eliz@gnu.org>
6609
6610 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6611 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6612 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6613 (malloc, free, realloc, calloc): Redirect to e_* only when
6614 compiling Emacs.
6615
6616 * lisp.h (GCTYPEBITS): Move before first use.
6617 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6618 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6619 this macro definition.
6620
6621 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6622 _MSC_VER.
6623
54e9e3bf
JD
66242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6625
6d5eb5b0
SM
6626 * gtkutil.c (xg_create_frame_widgets):
6627 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6628 present with Gtk+ 2.0.
6629
83aca1cb
PE
66302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 * fileio.c (Finsert_file_contents): Undo previous change; see
6633 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6634
5b76caa4
PE
66352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6636
6637 Rename locals to avoid shadowing.
6638 * fileio.c (Finsert_file_contents):
6639 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6640 * process.c (wait_reading_process_output):
6641 Rename inner 'proc' to 'p' to avoid shadowing.
6642 Indent for consistency with usual Emacs style.
6643
8c535114
EZ
66442011-11-25 Eli Zaretskii <eliz@gnu.org>
6645
6646 * xdisp.c (redisplay_window): If cursor row is not fully visible
6647 after recentering, and scroll-conservatively is set to a large
6648 number, scroll window by a few more lines to make the cursor fully
6649 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6650 (start_display): Don't move to the next line if the display should
6651 start at a newline that is part of a display vector or an overlay
6652 string. (Bug#10119)
8c535114 6653
fa4fdb5c
JL
66542011-11-24 Juri Linkov <juri@jurta.org>
6655
6656 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6657 after the `MagickPingImage' call. (Bug#10112)
6658
90ec88df
CY
66592011-11-23 Chong Yidong <cyd@gnu.org>
6660
6661 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6662
56e2e794
MR
66632011-11-23 Martin Rudalics <rudalics@gmx.at>
6664
6665 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6666 making another buffer current. (Bug#10114)
6667
b6e64c41
GM
66682011-11-23 Glenn Morris <rgm@gnu.org>
6669
6670 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6671
6b21de18
CY
66722011-11-23 Chong Yidong <cyd@gnu.org>
6673
6674 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6675 using it (Bug#5984).
6676
b12cd789
EZ
66772011-11-22 Eli Zaretskii <eliz@gnu.org>
6678
6679 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6680 and header-lines, as they don't have one computed for them.
6681 (Bug#10098)
6682
6683 * .gdbinit (prow): Make displayed values more self-explaining.
6684 Add row's hash code.
6685
261b6fd4
LMI
66862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6687
6688 * process.c (wait_reading_process_output): Fix asynchrounous
6689 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6690 (wait_reading_process_output): Add comment and URL.
261b6fd4 6691
e7cfd277
JD
66922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6693
6694 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6695
a9b9b7f5
CY
66962011-11-21 Chong Yidong <cyd@gnu.org>
6697
6698 * window.c (Fnext_window, Fprevious_window): Doc fix.
6699
b0d15b4f
SM
67002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6701
6702 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6703
fe7a3057
JB
67042011-11-20 Juanma Barranquero <lekktu@gmail.com>
6705
6706 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6707
d2999b1a
MR
67082011-11-20 Martin Rudalics <rudalics@gmx.at>
6709
6710 * window.c (Fset_window_combination_limit): Rename argument
6711 STATUS to LIMIT.
6712 (Vwindow_combination_limit): Remove "status" from doc-string.
6713
d5ff9cd0
AS
67142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6715
6716 * m/ibms390.h: Remove.
6717 * m/ibms390x.h: Don't include "ibms390.h".
6718
a5bb9bd3
SM
67192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6720
6721 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6722 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6723
cd1181db
JB
67242011-11-20 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * casetab.c (Fset_case_table):
6727 * charset.c (Fcharset_after): Fix typos.
6728
615a3b8d 67292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6730
17e845af
PE
6731 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6732 Otherwise, valgrind does not work on some platforms.
6733 Problem reported by Andreas Schwab in
6a0bf43d
PE
6734 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6735 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6736 is set, removing the need for VIRT_ADDRESS_VARIES.
6737 (PURE_P): Use a more-efficient implementation that needs just one
6738 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6739 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6740 to 4 (xorl, subq, cmpq, setbe).
6741 * alloc.c (pure): Always extern now, since that's the
6742 VIRT_ADDR_VARIES behavior.
6743 (PURE_POINTER_P): Use a single comparison, not two, for
6744 consistency with the new puresize.h.
6745 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6746 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6747 Remove VIRT_ADDR_VARIES no longer needed.
6748
f8fe6f96
EZ
67492011-11-19 Eli Zaretskii <eliz@gnu.org>
6750
6751 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6752 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6753 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6754 behave as if the cursor position were at the window margin.
6755
6756 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6757 and the cursor position is out of bounds, behave as if the cursor
6758 position were at the window margin. (Bug#10075)
6759
df05a53c
CY
67602011-11-18 Chong Yidong <cyd@gnu.org>
6761
6762 * window.c (Fwindow_combination_limit): Make first argument
6763 non-optional, since it is meaningless for live windows like the
6764 selected window.
61ccba97 6765
2071918e
DA
67662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6767
6768 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6769
b50a28de
SM
67702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6771
6772 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6773 (graft_intervals_into_buffer): Simplify.
6774
015137db
EZ
67752011-11-18 Eli Zaretskii <eliz@gnu.org>
6776
6777 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6778 hash values of the two rows.
6779 (copy_row_except_pointers): Preserve the used[] arrays and the
6780 hash values of the two rows. (Bug#10035)
68c95424 6781 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6782
6783 * xdisp.c (row_hash): New function, body extracted from
6784 compute_line_metrics.
6785 (compute_line_metrics): Call row_hash, instead of computing the
6786 hash code inline.
6787
6788 * dispnew.c (verify_row_hash): Call row_hash for computing the
6789 hash code of a row, instead of duplicating code from xdisp.c.
6790
6791 * dispextern.h (row_hash): Add prototype.
6792
a2addb04
TH
67932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6794
6795 * frame.c (delete_frame): Don't delete the terminal when the last
6796 X frame is closed if emacs is built with GTK toolkit.
6797
df85d315
JB
67982011-11-17 Juanma Barranquero <lekktu@gmail.com>
6799
6800 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6801
a0c2d0ae
MR
68022011-11-17 Martin Rudalics <rudalics@gmx.at>
6803
6804 * window.c (Vwindow_splits): Rename to
6805 Vwindow_combination_resize. Suggested by Juri Linkov.
6806 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6807 of Vwindow_splits.
6808
58179cce
JB
68092011-11-16 Juanma Barranquero <lekktu@gmail.com>
6810
7877f373
JB
6811 * nsfns.m (Fns_font_name):
6812 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6813
b6f67890
MR
68142011-11-16 Martin Rudalics <rudalics@gmx.at>
6815
6816 * window.h (window): Rename slot "nest" to "combination_limit".
6817 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6818 (Fset_window_nest): Rename to Fset_window_combination_limit.
6819 (Vwindow_nest): Rename to Vwindow_combination_limit.
6820 (recombine_windows, make_parent_window, make_window)
6821 (Fsplit_window_internal, saved_window)
6822 (Fset_window_configuration, save_window_save): Rename all
6823 occurrences of window_nest to window_combination_limit.
6824
c7015153
JB
68252011-11-15 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * image.c (imagemagick_load_image): Fix typo.
6828
322ad6ec
EZ
68292011-11-14 Eli Zaretskii <eliz@gnu.org>
6830
6831 * xdisp.c (display_line): Move the call to
6832 highlight_trailing_whitespace before the call to
6833 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6834 faces of all the glyphs to compute ROW's hash value.
6835 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6836
f067b8ec
JB
68372011-11-14 Juanma Barranquero <lekktu@gmail.com>
6838
6839 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6840 just return (bug#10044).
6841
1e5b2111
EZ
68422011-11-12 Eli Zaretskii <eliz@gnu.org>
6843
7ef3cbd5
EZ
6844 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6845 with user-defined heap size. Bump the default size of the temacs
6846 heap to 27MB, to avoid memory warning when running temacs.
6847 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6848
1e5b2111
EZ
6849 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6850 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6851 (verify_row_hash) [XASSERTS]: New function.
6852 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6853 that the hash value of glyph rows is correct.
1e5b2111 6854
89d61221
MR
68552011-11-12 Martin Rudalics <rudalics@gmx.at>
6856
6857 * window.h (window): Remove splits slot.
6858 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6859 (Fdelete_other_windows_internal, make_parent_window)
6860 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6861 (Fset_window_configuration, save_window_save): Don't deal with
6862 split status of windows.
6863 (saved_window): Remove splits slot.
6864 (Vwindow_splits): Rewrite doc-string.
6865
97f18cc8
JD
68662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6867
6868 * xfns.c (unwind_create_frame):
6869 * nsfns.m (unwind_create_frame):
6870 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6871 Vframe_list (Bug#9999).
6872
22a648b4
DA
68732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6874
0b381c7e 6875 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6876
659afede
KH
68772011-11-11 Kenichi Handa <handa@m17n.org>
6878
6879 * callproc.c (Fcall_process): Set the member dst_multibyte of
6880 process_coding.
6881
9ac0394b
KH
68822011-11-11 Johan Bockgård <bojohan@gnu.org>
6883
6884 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6885 avoid a crash (bug#9496).
6886
2fbdc249
CY
68872011-11-09 Chong Yidong <cyd@gnu.org>
6888
6889 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6890 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6891
ac6b1f81
PE
68922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6895
09db192c
PE
68962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6897
6898 Avoid some portability problems by eschewing 'extern inline' functions.
6899 The trivial performance wins aren't worth the portability hassles; see
6900 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6901 et seq.
6902 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6903 (window_box_width, window_box_left, window_box_left_offset)
6904 (window_box_right, window_box_right_offset): Undo previous change,
6905 by removing the "extern"s.
6906 * intervals.c (adjust_intervals_for_insertion)
6907 (adjust_intervals_for_deletion): Undo previous change,
6908 making these static again.
6909 (offset_intervals, temp_set_point_both, temp_set_point)
6910 (copy_intervals_to_string): No longer inline.
6911 * xdisp.c (window_text_bottom_y, window_box_width)
6912 (window_box_height, window_box_left_offset)
6913 (window_box_right_offset, window_box_left, window_box_right)
6914 (window_box): No longer inline.
6915
105216ed
CY
69162011-11-08 Chong Yidong <cyd@gnu.org>
6917
6918 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6919 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6920 Signal an error if not a live window.
105216ed
CY
6921 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6922 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6923
ae9e237f
JB
69242011-11-07 Juanma Barranquero <lekktu@gmail.com>
6925
6926 * lisp.h (syms_of_abbrev): Remove declaration.
6927 Reported by CHENG Gao <chenggao@royau.me>.
6928
c7aa8333
EZ
69292011-11-07 Eli Zaretskii <eliz@gnu.org>
6930
6931 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6932 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6933 of temacs in GUI mode.
6934
be7f5545
MR
69352011-11-07 Martin Rudalics <rudalics@gmx.at>
6936
6937 * window.h: Declare delete_all_child_windows instead of
6938 delete_all_subwindows.
6939 * window.c (Fwindow_nest, Fset_window_nest)
6940 (Fset_window_new_total, Fset_window_new_normal)
6941 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6942 (delete_all_subwindows): Rename to delete_all_child_windows.
6943 (Fdelete_other_windows_internal, Fset_window_configuration):
6944 Call delete_all_child_windows instead of delete_all_subwindows.
6945 * frame.c (delete_frame): Call delete_all_child_windows instead
6946 of delete_all_subwindows.
6947
ca78dc43
PE
69482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6949
6950 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6951 This is also needed for porting to any host where GC_MARK_STACK is
6952 not GC_MAKE_GCPROS_NOOPS.
6953 (which_symbols): Use it.
6954
a0241d01
KH
69552011-11-07 Kenichi Handa <handa@m17n.org>
6956
6957 * coding.c (coding_set_destination): Check coding->src_pos only
6958 when coding->src_object is a buffer (bug#9910).
6959
6960 * process.c (send_process): Set the member src_multibyte of coding
6961 to 0 (bug#9911) when sending a unibyte text.
6962
6963 * callproc.c (Fcall_process): Set the member src_multibyte of
6964 process_coding to 0 (bug#9912).
6965
a64bfdfa 69662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6967
6968 * xmenu.c (cleanup_widget_value_tree): New function.
6969 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6970 calling free_menubar_widget_value_tree directly (Bug#9830).
6971
cb41b32a
PE
69722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6973
6974 Fix some portability problems with 'inline'.
6975 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6976 (window_box_width, window_box_left, window_box_left_offset)
6977 (window_box_right, window_box_right_offset): Declare extern.
6978 Otherwise, these inline functions do not conform to C99 and
6979 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6980 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6981 * intervals.c (adjust_intervals_for_insertion)
6982 (adjust_intervals_for_deletion): Now extern, because otherwise the
6983 extern inline functions 'offset_intervals' couldn't refer to it.
6984 (static_offset_intervals): Remove.
6985 (offset_intervals): Rewrite using the old contents of
6986 static_offset_intervals. The old version didn't conform to C99
6987 because an extern inline function contained a reference to an
6988 identifier with static linkage.
6989
b7041366
AS
69902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6991
6992 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6993 GC.
6994
88a37c4d
EZ
69952011-11-06 Eli Zaretskii <eliz@gnu.org>
6996
6997 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6998 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6999 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7000 return Qleft_to_right.
7001
49745b39
CY
70022011-11-06 Chong Yidong <cyd@gnu.org>
7003
7004 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7005 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7006 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7007 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7008 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7009 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7010 (Fwindow_vscroll): Doc fix.
7011 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7012 argument, since it makes no sense to pass a live window and for
7013 consistency with window-child.
7014
1f05cd82
CS
70152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7016
7017 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7018 support MSVC.
7019
22610910
JR
70202011-11-05 Jason Rumney <jasonr@gnu.org>
7021
7022 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7023 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7024 fonts (Bug#6029).
7025 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7026 bitwise arithmetic preventing use of unicode-sip and non-truetype
7027 opentype fonts.
7028
a06776b2
EZ
70292011-11-05 Eli Zaretskii <eliz@gnu.org>
7030
3ad924ba
EZ
7031 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7032 "emacs"-only part.
7033
a06776b2
EZ
7034 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7035 initialization code to keep similarity to xfns.c after changes
7036 from 2011-11-05.
7037
c9e7db78
JD
70382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7039
a97f8f3f
JD
7040 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7041 (unwind_create_frame): New function (Bug#9943).
7042 (Fx_create_frame): Restructure code to be more similar to the one in
7043 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7044 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7045 Move terminal->reference_count++ just before making the frame official
7046 (Bug#9943).
7047
7048 * nsterm.m (x_free_frame_resources): New function.
7049 (x_destroy_window): Move code to x_free_frame_resources.
7050
c9e7db78 7051 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7052 (Fx_create_frame, x_create_tip_frame):
7053 Move terminal->reference_count++ just before making the frame
75f1671a 7054 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7055 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7056
a6fc3b5c
EZ
70572011-11-05 Eli Zaretskii <eliz@gnu.org>
7058
7059 Support MSVC build with newer versions of Visual Studio.
7060 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7061 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7062 nt/gmake.defs.
7063
7064 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7065 which are not supported by MSVC.
7066 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7067 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7068 bitfields.
7069 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7070 types in bitfields.
7071 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7072
7073 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7074
58179cce 70752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7076
7077 Support MSVC build with newer versions of Visual Studio.
7078 * w32.c: Don't include w32api.h for MSVC.
7079 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7080
7081 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7082 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7083 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7084 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7085 e_* cousins.
7086 (alloca) [_MSC_VER]: Define to _alloca.
7087
7088 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7089
7090 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7091
a58c13ed
EZ
70922011-11-04 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (note_mouse_highlight): If either of
7095 previous/next-single-property-change returns nil, treat that as
7096 the beginning or the end of the buffer. (Bug#9955)
7097
fe0b6370
JD
70982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7099
a58c13ed 7100 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7101 label is not null (Bug#9951).
7102 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7103 may be NULL.
7104
89bd5ee1
EZ
71052011-11-04 Eli Zaretskii <eliz@gnu.org>
7106
7107 * window.c (Fwindow_body_size): Mention in the doc string that the
7108 return value is in frame's canonical units. (Bug#9949)
7109
84c3edb9
EZ
71102011-11-03 Eli Zaretskii <eliz@gnu.org>
7111
4e2fb5c7
EZ
7112 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7113
84c3edb9 7114 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7115 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7116 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7117
bc17a887
EZ
71182011-11-01 Eli Zaretskii <eliz@gnu.org>
7119
7120 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7121 Don't stop backward scan on the continuation glyph, even though
7122 its CHARPOS is positive.
6d5eb5b0
SM
7123 (mouse_face_from_buffer_pos, note_mouse_highlight):
7124 Rename cover_string to disp_string.
bc17a887 7125
4ee88440
MR
71262011-11-01 Martin Rudalics <rudalics@gmx.at>
7127
7128 * window.c (temp_output_buffer_show): Don't use
7129 Vtemp_buffer_show_specifiers.
7130 (Vtemp_buffer_show_specifiers): Remove unused variable.
7131
c2ff3c02
EZ
71322011-10-30 Eli Zaretskii <eliz@gnu.org>
7133
7134 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7135 past the beginning of the current glyph matrix.
7136
58179cce 71372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7138
7139 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7140 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7141 HAVE_GTK3 (Bug#9869).
b77a6a7f 7142
3b574623
JD
7143 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7144 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7145
b77a6a7f
JD
7146 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7147
7148 * xterm.c: Declare x_handle_net_wm_state to return int.
7149 (handle_one_xevent): Check if we are iconified but don't have
7150 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7151 (get_current_wm_state): Return non-zero if not hidden,
7152 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7153 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7154 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7155 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7156
196e41e4
PE
71572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7158
7159 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7160 so that this new function doesn't get optimized away by a
7161 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7162
021f2e1a
AS
71632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7164
7165 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7166
8b058d44
EZ
71672011-10-29 Eli Zaretskii <eliz@gnu.org>
7168
7169 Fix the `xbytecode' command.
7170 * .gdbinit (xprintbytestr): New command.
b50a28de 7171 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7172 (xbytecode): Print the byte-code string as well.
7173
4452fb80
EZ
71742011-10-29 Kim Storm <storm@cua.dk>
7175
8b058d44
EZ
7176 * alloc.c (which_symbols): New function.
7177
21b72067
AS
71782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7179
7180 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7181 line. (Bug#9903)
7182
83ed7b5c
GM
71832011-10-29 Glenn Morris <rgm@gnu.org>
7184
7185 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7186 Not clear what it was for, and it causes various bugs. (Bug#9839)
7187
5a7a728b
EZ
71882011-10-28 Eli Zaretskii <eliz@gnu.org>
7189
7190 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7191 possible random value that matches one of those tested as
7192 condition to clear the mouse face.
7193
d3d0842f
CY
71942011-10-28 Chong Yidong <cyd@gnu.org>
7195
7196 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7197
31b39d13
DN
71982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7199
7200 * window.c (make_window): Initialize phys_cursor_on_p.
7201
9aba6043
SM
72022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7203
7204 * lisp.h (struct Lisp_Symbol): Update comments.
7205
c20992f4
JB
72062011-10-28 Juanma Barranquero <lekktu@gmail.com>
7207
7208 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7209
db4f02f2
EZ
72102011-10-28 Eli Zaretskii <eliz@gnu.org>
7211
7212 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7213 <oslsachem@gmail.com> for helping to debug this.
7214
7215 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7216 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7217 (g_b_init_get_glyph_outline_w): New static variables.
7218 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7219 (GetGlyphOutlineW_Proc): New typedefs.
7220 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7221 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7222 New functions.
7223 (w32font_open_internal, compute_metrics):
7224 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7225 instead of calling the "wide" APIs directly.
7226
7227 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7228
7229 * w32.h (syms_of_w32font): Add prototype.
7230
87e68db4
JB
72312011-10-27 Juanma Barranquero <lekktu@gmail.com>
7232
7233 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7234 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7235 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7236 (Fmove_to_window_line): Doc fix.
7237
435c1d67
CY
72382011-10-27 Chong Yidong <cyd@gnu.org>
7239
7240 * process.c (make_process): Set gnutls_state to NULL.
7241
7242 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7243 non-NULL, regardless of GNUTLS_INITSTAGE.
7244 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7245 an error. Set process slots as soon as we allocate them.
7246
7247 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7248
9c6c6f49
CY
72492011-10-27 Chong Yidong <cyd@gnu.org>
7250
9aba6043
SM
7251 * gnutls.c (emacs_gnutls_deinit): New function.
7252 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7253 (Fgnutls_deinit, Fgnutls_boot): Use it.
7254
7255 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7256 (deactivate_process): Call emacs_gnutls_deinit.
7257
657d08d3
JB
72582011-10-27 Juanma Barranquero <lekktu@gmail.com>
7259
7260 * image.c (x_create_x_image_and_pixmap):
7261 * w32.c (sys_rename, w32_delayed_load):
7262 * w32font.c (fill_in_logfont):
7263 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7264
5430d399
JB
72652011-10-26 Juanma Barranquero <lekktu@gmail.com>
7266
7267 * w32fns.c (w32_default_color_map): New function,
7268 extracted from Fw32_default_color_map.
a7ef684b 7269 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7270
fe0055fa
PE
72712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7272
7273 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7274
e6346438
SM
72752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7276
7277 * keyboard.c (test_undefined): New function (bug#9751).
7278 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7279
e112cc37
ET
72802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7281
7282 * sysdep.c (init_sys_modes): Fix the check for the controlling
7283 terminal (Bug#6649).
7284
7b5d6677
EZ
72852011-10-20 Eli Zaretskii <eliz@gnu.org>
7286
7287 * dispextern.h (struct bidi_it): New member next_en_type.
7288
7289 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7290 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7291 current character, check also for next_en_type being WEAK_EN.
7292 (bidi_resolve_weak): Don't enter the expensive loop if the current
7293 position is before next_en_pos. Record the bidi type of the first
7294 non-ET, non-BN character we find, in addition to its position.
7295 (bidi_level_of_next_char): Invalidate next_en_type when
7296 next_en_pos is over-stepped.
7297
7da0b018
PE
72982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7299
7300 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7301 * editfns.c: Rewrite current-time-zone so that it invokes
7302 the equivalent of (format-time-string "%Z") to get the time zone name.
7303 This fixes a bug when the time zone name contains characters that
7304 need converting from the system time locale to Emacs internal format.
7305 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7306 that patch fixed format-time-string to do the conversion, but
7307 I forgot to fix current-time-zone.
7308 (format_time_string): New function, containing most of
7309 what Fformat_time_string used to contain.
7310 (Fformat_time_string): Rewrite in terms of format_time_string.
7311 This doesn't change this function's behavior.
7312 (current-time-zone): Rewrite to use format_time_string.
7313 This fixes the bug reported by Michael Schierl in
7314 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7315 Jason Rumney's 2007-06-07 change worked around this bug, but
7316 didn't fix it.
7317 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7318
8547b010
EZ
73192011-10-19 Eli Zaretskii <eliz@gnu.org>
7320
7321 * xdisp.c (start_display): If the character at POS is displayed
7322 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7323 (try_window_reusing_current_matrix): If a line ends in a display
7324 vector or the next line starts in a display vector, continue
7325 redrawing the window even though the character position of
7326 start_row was reached.
8547b010
EZ
7327 (Bug#9771, part 2)
7328
4e948d15
CY
73292011-10-18 Chong Yidong <cyd@gnu.org>
7330
7331 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7332 with nobreak-char-display too.
7333
4787455f
EZ
73342011-10-18 Eli Zaretskii <eliz@gnu.org>
7335
7336 Fix part 3 of bug#9771.
7337 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7338 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7339 non-neutral characters if the current character is a paragraph
7340 separator (a.k.a. Newline). This avoids running the same
7341 expensive loop twice, once when we consume the preceding newline
7342 and the other time when the line actually needs to be displayed.
7343 Avoid the loop when we see neutrals on the base embedding level
7344 following a character whose directionality is the same as the
7345 paragraph's. This avoids running the expensive loop when a line
7346 ends in a long sequence of neutrals, like control characters.
7347 Add assertion against STRONG_AL type. Slightly rearrange code
7348 that determines the type of a neutral given the first non-neutral
7349 that follows it.
7350 (bidi_level_of_next_char): Set next_en_pos to zero when
7351 invalidating its info.
7352
2c91f553
EZ
73532011-10-17 Eli Zaretskii <eliz@gnu.org>
7354
7355 * xdisp.c (push_display_prop): Determine whether to record string
7356 or buffer position by IT->string, not by IT->method. Allow
7357 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7358 (move_it_vertically_backward): Don't look for character position
7359 immediately after the newline when in a continuation line.
7360 (Bug#9771, part 1)
2c91f553 7361
c7b08b0d
MR
73622011-10-15 Martin Rudalics <rudalics@gmx.at>
7363
7364 * window.c (coordinates_in_window): Rewrite and delabelize
7365 vertical border check. (Bug#5357) (Bug#9618)
7366
6b02f655
SM
73672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7368
7369 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7370 errors in XSetWindowBorder (bug#9310).
7371
81d40c92
DA
73722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7373
7374 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7375 avoid crash when xmalloc overrun checking is enabled.
7376
d4172c3b
EZ
73772011-10-13 Eli Zaretskii <eliz@gnu.org>
7378
7379 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7380 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7381 cursor motion with <left> and <right> arrow keys.
7382
7383 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7384 some callers set that themselves.
7385
b00eea75
EZ
73862011-10-12 Eli Zaretskii <eliz@gnu.org>
7387
7388 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7389 display string and the previous row comes from the same string and
7390 is empty. (Bug#9739) (Bug#9738)
7391
8fe012c4
SM
73922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7393
7394 * doc.c (get_doc_string): Encode file name (bug#9735).
7395
0074aef2
EZ
73962011-10-12 Eli Zaretskii <eliz@gnu.org>
7397
79beb178
EZ
7398 * bidi.c (bidi_level_of_next_char):
7399 * xdisp.c (get_visually_first_element): Remove old incorrect
7400 comments regarding the Unicode Line Separator character.
7401
0074aef2
EZ
7402 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7403
6e4b3fbe
DA
74042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7405
7406 * alloc.c (Fgc_status): Do not access beyond zombies array
7407 boundary if nzombies > MAX_ZOMBIES.
7408 * alloc.c (dump_zombies): Add missing format specifier.
7409
0324f3af
PE
74102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7411
b5525cac
PE
7412 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7413 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7414
0324f3af
PE
7415 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7416 Some packages use them to denote characters with modifiers.
7417
e9b5f888
AS
74182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7419
7420 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7421 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7422 matching a pp-number. Rename parameter var to var1.
7423
127827c0
SM
74242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7425
7426 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7427
c8fd3bd0
GM
74282011-10-08 Glenn Morris <rgm@gnu.org>
7429
7430 * callint.c (Fcall_interactively): Give a more explicit error for the
7431 'c' case with a non-character input. (Bug#8479)
7432
352ec8ff
EZ
74332011-10-08 Eli Zaretskii <eliz@gnu.org>
7434
03669ccb
EZ
7435 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7436 lines.
7061c986
EZ
7437 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7438 lines that are hscrolled on the left.
03669ccb 7439
352ec8ff
EZ
7440 * dispnew.c (buffer_posn_from_coords): Account for a possible
7441 presence of header-line. (Bug#4426)
7442
a66cfb1c
SM
74432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7444
6b02f655
SM
7445 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7446 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7447
7c5ee88e
PE
74482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7449
7450 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7451 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7452 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7453 this makes Emacs dump core during garbage collection on rare
7454 occasions. sizeof is obviously inferior to offsetof here, so
7455 stick with offsetof.
7456 (GC_POINTER_ALIGNMENT): New macro.
7457 (mark_memory): Omit 3rd (offset) arg; caller changed.
7458 Don't assume EMACS_INT alignment is the same as pointer alignment.
7459
df1bbe5b
SM
74602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7461
7462 * keyboard.c (read_key_sequence_remapped): New var.
7463 (read_key_sequence): Compute remapping in the right buffer.
7464 (command_loop_1): Use read_key_sequence's remapping directly.
7465
51553db6
SM
74662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7467
32c1fffd
SM
7468 * dired.c (file_name_completion): Don't expand file name.
7469 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7470 before checking file name handler.
7471
51553db6
SM
7472 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7473 they've been requested explicitly (bug#9591).
7474
b6bd1599 74752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7476
7477 * keymap.c (Fsingle_key_description): Use make_specified_string
7478 instead of build_string to build string from push_key_description.
7479 (Bug#5193)
7480
f701dc2a
PE
74812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7482
4222c55d
PE
7483 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7484 This fixes a Y2038 bug on 64-bit hosts.
7485 * buffer.c (reset_buffer):
7486 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7487 (Fclear_buffer_auto_save_failure):
7488 Use 0, not -1, to represent an unset failure time, since time_t
7489 might not be signed.
7490
f701dc2a
PE
7491 Remove dependency on glibc malloc internals.
7492 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7493 Move back here from lisp.h, but with their new implementations.
7494 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7495 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7496 * charset.c (charset_table_init): New static var.
7497 (syms_of_charset): Use it instead of xmalloc. This removes a
7498 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7499 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7500 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7501 Move back to alloc.c.
7502 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7503 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7504
9ceebf39
JD
75052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7506
7507 * nsterm.m (windowDidResize): Call x_set_window_size only when
7508 ns_in_resize is true. Otherwise set pixelwidth/height and
7509 call change_frame_size (Bug#9628).
7510
cb993c58
PE
75112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7512
3930c88b
PE
7513 Port --enable-checking=all to Fedora 14 x86-64.
7514 * charset.c (syms_of_charset): Also account for glibc malloc's
7515 internal overhead when calculating the initial malloc maximum.
7516
cb993c58
PE
7517 Port --enable-checking=all to Fedora 14 x86.
7518 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7519 Move to lisp.h.
7520 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7521 (overrun_check_realloc, overrun_check_free):
7522 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7523 That way, xmalloc returns a properly-aligned pointer even if
7524 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7525 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7526 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7527 into account when calculating the initial malloc maximum.
7528 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7529 Move here from alloc.c, so that charset.c can use it too.
7530 Properly align; the old code wasn't right for common 32-bit hosts
7531 when configured with --enable-checking=all.
7532 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7533 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7534
31bed486
EZ
75352011-09-29 Eli Zaretskii <eliz@gnu.org>
7536
04c70788 7537 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7538 use EDOM.
7539
fbcaa2f3
EZ
75402011-09-28 Eli Zaretskii <eliz@gnu.org>
7541
7542 * xdisp.c (compute_display_string_end): If there's no display
7543 string at CHARPOS, return -1.
7544
7545 * bidi.c (bidi_fetch_char): When compute_display_string_end
7546 returns a negative value, treat the character as a normal
7547 character not covered by a display string. (Bug#9624)
7548
a239d4e9
JB
75492011-09-28 Juanma Barranquero <lekktu@gmail.com>
7550
7551 * lread.c (Fread_from_string): Fix typo in docstring.
7552
88652fd5
EZ
75532011-09-27 Eli Zaretskii <eliz@gnu.org>
7554
7555 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7556 newline, reseat the iterator instead of bidi-iterating there one
7557 character at a time. (Bug#9610)
32c1fffd
SM
7558 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7559 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7560
ed497dd4
AS
75612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7562
7563 * lread.c (readevalloop): Use correct code for NBSP.
7564 (read1): Likewise. (Bug#9608)
7565
b2bf61aa
MA
75662011-09-25 Michael Albinus <michael.albinus@gmx.de>
7567
7568 * dbusbind.c (Fdbus_register_signal): When service is not
7569 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7570
32bbb17c
GM
75712011-09-25 Glenn Morris <rgm@gnu.org>
7572
7573 * buffer.c (truncate-lines): Doc fix.
7574
94e0933e
CY
75752011-09-24 Chong Yidong <cyd@stupidchicken.com>
7576
7577 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7578 (Fset_window_next_buffers): Doc fix.
7579
cddde921
GM
75802011-09-24 Glenn Morris <rgm@gnu.org>
7581
7582 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7583
1260aef1
PE
75842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7585
25b4bfa0
PE
7586 Fix minor problems found by static checking.
7587 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7588 * indent.c (Fvertical_motion): Fix == vs = typo.
7589
e3cbd34b
EZ
75902011-09-24 Eli Zaretskii <eliz@gnu.org>
7591
a66cfb1c
SM
7592 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7593 Default value is now t. Doc fix.
6bf7006f 7594
e3cbd34b 7595 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7596 logic when moving up, not only when moving down. Fix the
e3cbd34b 7597 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7598 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7599
7600 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7601 CHARPOS is covered by a display string which includes newlines.
7602 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7603 is covered by a display string with embedded newlines.
7604
a3de0cbd
MA
76052011-09-24 Michael Albinus <michael.albinus@gmx.de>
7606
7607 * dbusbind.c (Fdbus_register_signal): Add match rule to
7608 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7609 (Fdbus_register_method, Vdbus_registered_objects_table):
7610 Fix docstring.
a3de0cbd 7611
b260039d
JM
76122011-09-24 Jim Meyering <meyering@redhat.com>
7613
32c1fffd 7614 do not ignore write error for any output size
b260039d
JM
7615 The previous change was incomplete.
7616 While it makes emacs --batch detect the vast majority of stdout
7617 write failures, errors were still ignored whenever the output size is
7618 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7619 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7620 && echo FAIL: ignored write error
7621 FAIL: ignored write error
7622 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7623 && echo FAIL: ignored write error
7624 FAIL: ignored write error
7625 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7626
8eca8a7c
AS
76272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7628
7629 * emacs.c (Fkill_emacs): In noninteractive mode exit
7630 non-successfully if a write error occurred on stdout. (Bug#9574)
7631
3341db62
EZ
76322011-09-21 Eli Zaretskii <eliz@gnu.org>
7633
7634 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7635 the xassert test.
7636
7637 * dispextern.h (struct it): Update the comment documenting what
7638 can it->OBJECT be.
7639
8c203dbf
EZ
76402011-09-20 Eli Zaretskii <eliz@gnu.org>
7641
7642 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7643 a display string, extend search for cursor position to end of row.
7644 (find_row_edges): If the row ends in a newline from a display
7645 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7646 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7647 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7648 non-empty line. Fixes confusing cursor motion with arrow keys at
7649 the beginning of a line that starts with whitespace.
8c203dbf 7650
a4824228
LMI
76512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7652
7653 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7654 (bug#9493).
7655
33ed493b
CY
76562011-09-18 Chong Yidong <cyd@stupidchicken.com>
7657
7658 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7659 boolean (Bug#9154).
7660
56cd55c8
EZ
76612011-09-18 Eli Zaretskii <eliz@gnu.org>
7662
7663 * xdisp.c (display_line): Record maximum and minimum buffer
7664 positions even if no glyphs were produced (e.g., by a zero-width
7665 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7666 buffer positions that will be removed from the glyph row because
7667 they don't fit.
c02dcedf
EZ
7668 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7669 column is beyond frame width: don't subtract 1 "pixel" when
7670 computing width of the stretch.
3e62b7e0
EZ
7671 (reseat_at_next_visible_line_start): Undo the change made on
7672 2011-09-17 that saved paragraph information and restored it after
7673 the call to `reseat'. (Bug#9545)
56cd55c8 7674
5ed99d36 76752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7676
7677 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7678 and turn window cursor on if cleared (Bug#9415).
7679
5ed99d36 76802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7681
7682 * search.c (boyer_moore): Take unibyte characters from pattern
7683 literally. (Bug#9458)
7684
9bade7b2
EZ
76852011-09-18 Eli Zaretskii <eliz@gnu.org>
7686
7687 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7688
e5e9d610
PE
76892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7690
87e4427a
PE
7691 Fix minor problem found by static checking.
7692 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7693 initialized, to pacify gcc -Wuninitialized.
7694
e5e9d610
PE
7695 * fileio.c: Report proper errno when syscall falls.
7696 (Finsert_file_contents): Save and restore errno,
7697 so that report_file_error outputs the correct diagnostic.
7698 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7699
a1674f0b
EZ
77002011-09-18 Eli Zaretskii <eliz@gnu.org>
7701
7702 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7703
fbfb6dd4
EZ
77042011-09-17 Eli Zaretskii <eliz@gnu.org>
7705
7706 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7707 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7708
bb187662
EZ
77092011-09-17 Eli Zaretskii <eliz@gnu.org>
7710
1137e8b8 7711 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7712 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7713
7714 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7715 (bidi_find_paragraph_start): Search back for paragraph beginning
7716 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7717 (bidi_move_to_visually_next): Only trigger paragraph-related
7718 computations when the last character is a newline or at EOB, not
7719 just any NEUTRAL_B. (Bug#9470)
7720
bb187662
EZ
7721 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7722 truncated lines if point is covered by a display string. (Bug#9524)
7723
2e621251
PE
77242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7725
7726 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7727 (cons_to_x_long): New function.
7728 (lisp_data_to_selection_data): Use it. Correct the test for
7729 short-versus-long data; it was negated. Break out of vector
7730 loop, for efficiency, when a long datum is discovered.
7731
91a15bc6
SM
77322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7733
7734 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7735
b41c3a35
EZ
77362011-09-16 Eli Zaretskii <eliz@gnu.org>
7737
7738 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7739 GCC PR/17406) by declaring this function with external scope.
7740
7812ba2d
PE
77412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7742
7743 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7744 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7745
cf7edc2a
AS
77462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7747
7748 * editfns.c (Fformat): Correctly handle text properties on "%%".
7749
bd01620e
EZ
77502011-09-15 Eli Zaretskii <eliz@gnu.org>
7751
7752 * xterm.c (x_draw_composite_glyph_string_foreground):
7753 * w32term.c (x_draw_composite_glyph_string_foreground):
7754 * term.c (encode_terminal_code):
7755 * composite.c (composition_update_it, get_composition_id):
7756 * xdisp.c (get_next_display_element)
7757 (fill_composite_glyph_string): Add comments about special meaning
7758 of TAB characters in a composition.
7759
a02719a3
PE
77602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7761
7762 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7763 This occurs when processing a multibyte format.
7764 Problem reported by Wolfgang Jenker.
a02719a3 7765
72589a3c
JB
77662011-09-15 Johan Bockgård <bojohan@gnu.org>
7767
7768 * xdisp.c (try_cursor_movement): Only check for exact match if
7769 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7770
1c14176c
PE
77712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7772
7773 Remove unused external symbols.
7774 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7775 * xdisp.c (calc_pixel_width_or_height): Now static.
7776 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7777 * indent.c (check_display_width):
7778 * w32term.c: Fix comment to match code.
7779 * xterm.c, xterm.h (x_catching_errors): Remove.
7780
d2eea5b5
PE
77812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7782
7783 * xselect.c: Use signed conversions more consistently (Bug#9498).
7784 (selection_data_to_lisp_data): Assume incoming selection data are
7785 signed integers, not unsigned. This is to be consistent with
7786 outgoing selection data, which was modified to use signed integers
7787 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7788 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7789 expects long, not unsigned long.
7790
46888499
EZ
77912011-09-14 Eli Zaretskii <eliz@gnu.org>
7792
7793 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7794 computation of loop end. Reported by Johan Bockgård
7795 <bojohan@gnu.org>.
7796
ef8ef9fb
CY
77972011-09-13 Chong Yidong <cyd@stupidchicken.com>
7798
7799 * frame.c (Fother_visible_frames_p): Function deleted.
7800
fa819fed
EZ
78012011-09-12 Eli Zaretskii <eliz@gnu.org>
7802
7803 * indent.c (compute_motion): Process display vector front to back
7804 rather than the other way around. (Bug#2496)
7805
2ba8e008
SM
78062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7807
7808 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7809
20f53c69
CY
78102011-09-11 Chong Yidong <cyd@stupidchicken.com>
7811
7812 * minibuf.c (Fread_from_minibuffer): Doc fix.
7813
d562d7a4
EZ
78142011-09-11 Eli Zaretskii <eliz@gnu.org>
7815
7816 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7817 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7818
1c4d7f3d
LMI
78192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7820
7821 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7822 value for non-existent files.
7823
b885bf36
EZ
78242011-09-11 Eli Zaretskii <eliz@gnu.org>
7825
7826 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7827 set its "size" to -1. This will set the modtime_size field of
7828 the corresponding buffer to -1, which is what
7829 verify-visited-file-modtime expects for files that do not exist.
7830 (Bug#9139)
7831
6612f0bf
PE
78322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7833
7834 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7835 here ...
7836 * lisp.h: ... from here. push_key_description is no longer
7837 defined in keyboard.c, so its declaration should not be in
7838 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7839 logically belongs with push_key_description.
7840
dfb3f755
PE
78412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7842
7843 * buffer.h: Include <sys/types.h> instead of <time.h>.
7844 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7845 Problem reported by Herbert J. Skuhra.
7846
3134906c
LMI
78472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7848
7849 * xml.c (parse_region): Make the parsing work for
7850 non-comment-starting XML files again (bug#9144).
7851
8d903f4e
AS
78522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7853
7854 * image.c (gif_load): Fix calculation of bottom and right corner.
7855 (Bug#9468)
7856
80ad64f4
EZ
78572011-09-10 Eli Zaretskii <eliz@gnu.org>
7858
7859 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7860 redisplay in small windows.
7861
208a048d
EZ
78622011-09-09 Eli Zaretskii <eliz@gnu.org>
7863
7864 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7865
9b1c252e
MR
78662011-09-08 Martin Rudalics <rudalics@gmx.at>
7867
7868 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7869 Operate on live windows only.
7870
2949f33b
JB
78712011-09-08 Juanma Barranquero <lekktu@gmail.com>
7872
7873 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7874
e08dcafd
EZ
78752011-09-07 Eli Zaretskii <eliz@gnu.org>
7876
7877 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7878 only under bidi iteration.
7879
115b96bd
JD
78802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7881
7882 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7883
c8199d0f
PE
78842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7885
7886 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7887 Without this fix, the command to link temacs failed due to an
7888 undefined symbol __builtin_isnan. This is because
7889 /usr/include/iso/math_c99.h #defines isnan(x) to
7890 __builtin_isnan(x), but the bundled gcc, which identifies itself
7891 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7892 a __builtin_isnan.
7893 * floatfns.c (isnan): #undef, and then #define to a clone of
7894 what's in data.c.
7895 (Fisnan): Always define, since it's always available now.
7896 (syms_of_floatfns): Always define isnan at the Lisp level.
7897
e39b275c 78982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7899
7900 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7901
b2db44d9 79022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7903
f4af5137 7904 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7905 The previous code assumed that file offsets (off_t values) fit in
7906 EMACS_INT variables, which is not true on typical 32-bit hosts.
7907 The code messed up by falsely reporting buffer overflow in cases
7908 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7909 when "big" contains more than 2**29 bytes, even though this
7910 inserts just one byte and does not overflow the buffer.
7911 (Finsert_file_contents): Store file offsets as off_t
7912 values, not as EMACS_INT values. Check for overflow when
7913 converting between EMACS_INT and off_t. When checking for
7914 buffer overflow or for overlap, take the offsets into account.
7915 Don't use EMACS_INT for small values where int suffices.
7916 When checking for overlap, fix a typo: ZV was used where
7917 ZV_BYTE was intended.
7918 (Fwrite_region): Don't assume off_t fits into 'long'.
7919 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7920
ecfc0a49
MA
79212011-09-05 Michael Albinus <michael.albinus@gmx.de>
7922
7923 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7924
6511acf2 79252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7926
0999621a 7927 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7928
7929 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7930 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7931 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7932 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7933 (modify_event_symbol): Do not assume that the length of
7934 name_alist_or_stem is safe to alloca and fits in int.
7935 (Fexecute_extended_command): Likewise for function name and binding.
7936 (Frecursion_depth): Wrap around reliably on integer overflow.
7937 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7938 since some callers pass EMACS_INT values.
7939 (Fsingle_key_description): Don't crash if symbol name contains more
7940 than MAX_ALLOCA bytes.
7941 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7942 (get_minibuffer): Arg is now EMACS_INT, not int.
7943 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7944 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7945 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7946
2be7d702
PE
7947 * dbusbind.c (signature_cat): New function.
7948 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7949 Do not overrun buffer; instead, report string overflow.
7950
9d1df220
PE
7951 * dispnew.c (add_window_display_history): Don't overrun buffer.
7952 Truncate instead; this is OK since it's just a log.
7953
33ef5c64
PE
7954 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7955 even if the time zone offset is outlandishly large.
7956 Don't mishandle offset == INT_MIN.
7957
66c6fdd5
PE
7958 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7959 when creating daemon; the previous buffer-overflow check was incorrect.
7960
d749b01b
PE
7961 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7962 which has the guts of the old verror function.
7963
b5cd1905
PE
7964 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7965 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7966
6e1a67fb
PE
7967 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7968 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7969 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7970 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7971 length of string rather than counting it via multiple sprintfs;
7972 that's simpler and more reliable.
c21721cc
PE
7973 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7974 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7975 sprintf, in case result does not fit in int.
7976
c57b67fc
PE
7977 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7978 (fontset_from_font): Print it.
7979
8a401434
PE
7980 * frame.c (tty_frame_count): Now printmax_t, not int.
7981 (make_terminal_frame, set_term_frame_name): Print it.
7982 (x_report_frame_params): In X, window IDs are unsigned long,
7983 not signed long, so print them as unsigned.
7984 (validate_x_resource_name): Check for implausibly long names,
7985 and don't assume name length fits in 'int'.
7986 (x_get_resource_string): Don't blindly alloca invocation name;
7987 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7988 not fit in int.
7989
6e1a67fb
PE
7990 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7991 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7992 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7993
0df02bf3
PE
7994 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7995 Use esprintf, not sprintf, in case result does not fit in int.
7996
48e30793
PE
7997 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7998 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7999 it as a large positive number.
8000 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8001 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8002
a66ff6d8
PE
8003 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8004 in case result does not fit in int.
8005
aca216ff
PE
8006 * print.c (float_to_string): Detect width overflow more reliably.
8007 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8008 buffer overrun. Don't assume list length fits in 'int'. Treat
8009 print length of 0 as 0, not as infinity; to be consistent with other
8010 uses of print length in this function. Don't overflow print length
8011 index. Don't assume hash table size fits in 'long', or that
8012 vectorlike size fits in 'unsigned long'.
8013
31c286f7
PE
8014 * process.c (make_process): Use printmax_t, not int, to format
8015 process-name gensyms.
8016
55e5faa1
PE
8017 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8018
80f2e268
PE
8019 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8020 to avoid potential buffer overrun.
8021
670741ab
PE
8022 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8023 if X resource line is longer than 512 bytes.
8024
b7163a50
PE
8025 * xfns.c (x_window): Make sprintf buffer a bit bigger
8026 to avoid potential buffer overrun.
8027
ae58ff1f
PE
8028 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8029
c43c8a6a
PE
8030 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8031
3f8236f4
PE
80322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8033
53e9fe90 8034 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8035 Without these, Emacs silently mishandles large integers sometimes.
8036 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8037 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8038
6511acf2
PE
8039 * xdisp.c (try_window_id): Check Emacs fixnum range before
8040 converting to 'int'.
806add1d 8041
6511acf2 8042 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8043 Check that an Emacs fixnum is in range before assigning it to 'int'.
8044 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8045 values converted from Emacs fixnums.
8046 (Frecenter): Don't wrap around a line count if it is out of 'int'
8047 range; instead, treat it as an extreme value.
8048 (Fset_window_configuration, compare_window_configurations):
8049 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8050
6511acf2
PE
8051 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8052 that can exceed INT_MAX. Check that EMACS_INT value is in range
8053 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8054 (match_limit): Don't assume that a fixnum can fit in 'int'.
8055
6511acf2 8056 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8057 exceed INT_MAX.
8058
6511acf2 8059 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8060 (Fvertical_motion): Don't wrap around LINES values that don't fit
8061 in 'int'. Instead, treat them as extreme values. This is good
8062 enough for windows, which can't have more than INT_MAX lines anyway.
8063
fcb901a7
LMI
80642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8065
0f2f6b6d
LMI
8066 * Require libxml/parser.h to avoid compilation warning.
8067
fcb901a7
LMI
8068 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8069
8070 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8071 since this reportedly can destroy thread storage.
8072
6e20a0d4
CY
80732011-08-30 Chong Yidong <cyd@stupidchicken.com>
8074
8075 * syntax.c (find_defun_start): Update all cache variables if
8076 exiting early (Bug#9401).
8077
148ae00e
EZ
80782011-08-30 Eli Zaretskii <eliz@gnu.org>
8079
f6cfbd8f
EZ
8080 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8081
148ae00e
EZ
8082 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8083 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8084 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8085
8086 * term.c (tty_append_glyph): New function.
8087 (produce_stretch_glyph): Static function and its prototype deleted.
8088
a66cfb1c
SM
8089 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8090 Add prototypes.
148ae00e 8091
c4a07a4c
PE
80922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8093
8094 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8095 when checking :margin (Bug#9390).
8096 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8097 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8098 so that the name doesn't mislead. All uses changed.
8099
6bc8cd65
JB
81002011-08-28 Johan Bockgård <bojohan@gnu.org>
8101
8102 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8103 set_tty_hooks.
8104
dca4927e
EZ
81052011-08-27 Eli Zaretskii <eliz@gnu.org>
8106
8107 * xdisp.c (move_it_to): Don't bail out early when reaching
8108 position beyond to_charpos, if we are scanning backwards.
8109 (move_it_vertically_backward): When DY == 0, make sure we get to
8110 the first character in the line after the newline.
8111
f2cad773
PE
81122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8113
8114 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8115 (ccl_driver): Do not generate an out-of-range pointer.
8116 (Fccl_execute_on_string): Remove unnecessary check for
8117 integer overflow, noted by Stefan Monnier in
8118 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8119 Remove a FIXME that didn't need fixing.
8120 Simplify the newly-introduced buffer reallocation code.
8121
0cae2cdb
JB
81222011-08-27 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8125
5fc295a4 81262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8127
70c60eb2 8128 Integer and memory overflow issues (Bug#9196).
726e0ab1 8129
d31850da
PE
8130 * doc.c (get_doc_string): Rework so that
8131 get_doc_string_buffer_size is the actual buffer size, rather than
8132 being 1 less than the actual buffer size; this makes xpalloc more
8133 convenient.
8134
a69fbedb
PE
8135 * image.c (x_allocate_bitmap_record, cache_image):
8136 * xselect.c (Fx_register_dnd_atom):
8137 Simplify previous changes by using xpalloc.
8138
fe5c5d37
PE
8139 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8140 since either will do and ptrdiff_t is convenient with xpalloc.
8141
0065d054
PE
8142 * charset.c (charset_table_size)
8143 (struct charset_sort_data.priority): Now ptrdiff_t.
8144 (charset_compare): Don't overflow if priorities differ greatly.
8145 (Fsort_charsets): Don't assume list length fits in int.
8146 Check for size-calculation overflow when allocating sort data.
8147 (syms_of_charset): Allocate an initial charset table that is
8148 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8149
8150 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8151
8152 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8153 The actual value is always <= INT_MAX, and leaving it unsigned made
8154 overflow checking harder.
8155
8156 * dispextern.h (struct glyph_matrix.rows_allocated)
8157 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8158 with xpalloc. The values are still always <= INT_MAX.
8159
8160 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8161
8162 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8163 (SAFE_NALLOCA): New macro.
8164
8165 * region-cache.c (struct boundary.pos, find_cache_boundary)
8166 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8167 (set_cache_region, invalidate_region_cache)
8168 (revalidate_region_cache, know_region_cache, region_cache_forward)
8169 (region_cache_backward, pp_cache):
8170 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8171 so that ptrdiff_t * can be passed to xpalloc.
8172 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8173 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8174 (pp_cache): Don't assume cache_len fits in int.
8175 * region-cache.h: Adjust extern decls to match.
8176
8177 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8178 EMACS_INT, since either will do, for xpalloc.
8179
8180 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8181 (xnmalloc, xnrealloc, xpalloc): New functions.
8182
726e0ab1
PE
8183 * bidi.c (bidi_shelve_header_size): New constant.
8184 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8185 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8186
51f30bc5 8187 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8188 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8189 (overlay_strings):
8190 Don't update size of array until after memory allocation succeeds,
8191 because xmalloc/xrealloc may not return.
0065d054
PE
8192 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8193 now that we have proper integer overflow checking.
8194 (record_overlay_string, overlay_strings): Catch overflows when
8195 calculating size of overlay_str_buf.
726e0ab1 8196
0065d054
PE
8197 * callproc.c (Fcall_process): Check for size overflow when
8198 calculating size of args2.
8199 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8200 Normally we prefer signed values, but sticking with ptrdiff_t would
8201 require adding more-complicated checks.
726e0ab1
PE
8202
8203 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8204 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8205 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8206 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8207
8208 * character.c (Fstring): Check for size-calculation overflow.
8209
8210 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8211 unnecessary integer overflow. Check for size overflow.
8212 (encode_coding_object): Don't update size until xmalloc succeeds.
8213
8214 * composite.c (get_composition_id): Check for overflow in glyph
8215 length calculations.
8216
8217 Integer and memory overflow fixes for display code.
8218 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8219 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8220 (scrolling_window): Check for overflow in size calculations.
8221 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8222 Don't assume glyph table len fits in int.
8223 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8224 (row_table_size): Now ptrdiff_t, not int.
8225 (scrolling_window): Avoid overflow in size calculations.
8226 Don't update size until allocation succeeds.
8227 * fns.c (concat): Check for overflow in size calculations.
8228 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8229 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8230 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8231
8232 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8233 (get_doc_string): Check for size calculation overflow.
8234 Don't update size until allocation succeeds.
8235 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8236 EMACS_INT, where ptrdiff_t will do.
8237 (Fsubstitute_command_keys): Check for string overflow.
8238
8239 * editfns.c (set_time_zone_rule): Don't assume environment length
8240 fits in int.
8241 (message_length): Now ptrdiff_t, not int.
8242 (Fmessage_box): Don't update size until allocation succeeds.
8243 Don't assume message length fits in int.
8244 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8245
0065d054
PE
8246 * emacs.c (main): Do not reallocate argv, since there is a null at
8247 the end that can be overwritten, and this way there's no need to
8248 worry about size-calculation overflow.
8249 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8250
8251 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8252 alloc succeeds.
8253 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8254
8255 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8256 (x_set_scroll_bar_width, x_figure_window_size):
8257 Check for integer overflow.
8258 (x_set_alpha): Do not assume XINT fits in int.
8259
8260 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8261 This is for the members text_lines, text_cols, total_lines, total_cols,
8262 where the system imposes an 'int' limit.
8263
8264 * fringe.c (Fdefine_fringe_bitmap):
8265 Don't update size until alloc works.
8266
8267 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8268 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8269
8270 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8271 Check for size-calculation overflow.
8272 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8273 do, as we prefer signed integers.
8274 (id_to_widget.max_size, id_to_widget.used)
8275 (xg_store_widget_in_map, xg_remove_widget_from_map)
8276 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8277 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8278 Use and return ptrdiff_t, not int.
8279 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8280 * gtkutil.h: Change prototypes to match the above.
8281
8282 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8283 are duplicate now that they've been promoted to lisp.h.
8284 (x_allocate_bitmap_record, x_alloc_image_color)
8285 (make_image_cache, cache_image, xpm_load):
8286 Don't update size until alloc is done.
8287 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8288 (x_detect_edges):
3256efce 8289 Check for size calculation overflow.
726e0ab1
PE
8290 (ct_colors_allocated_max): New constant.
8291 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8292 overflow.
3256efce 8293
726e0ab1
PE
8294 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8295 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8296 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8297 Use ptrdiff_t, not int, to count maps.
8298 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8299 calculations. Don't update size until allocation succeeds.
8300 Redo calculations to avoid overflow.
726e0ab1
PE
8301 * keyboard.h: Change prototypes to match the above.
8302
8303 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8304 to count maps.
8305 (current_minor_maps): Check for size calculation overflow.
8306 * keymap.h: Change prototypes to match the above.
8307
8308 * lread.c (read1, init_obarray): Don't update size until alloc done.
8309
8310 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8311 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8312
726e0ab1
PE
8313 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8314 Now ptrdiff_t, not int.
8315 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8316 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8317
8318 * process.c (Fnetwork_interface_list): Check for overflow
8319 in size calculation.
8320
8321 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8322
8323 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8324 overflow. Don't bother calling xmalloc when xrealloc will do.
8325
8326 * search.c (Freplace_match): Check for size calculation overflow.
8327 (Fset_match_data): Don't assume list lengths fit in 'int'.
8328
8329 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8330 for command line length. Do not attempt to address one before the
8331 beginning of an array, as that's not portable.
8332
8333 * term.c (max_frame_lines): Remove; unused.
8334 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8335 not int.
8336 (encode_terminal_code, calculate_costs): Check for size
8337 calculation overflow.
8338 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8339 table lengths and related sizes. Don't update size until alloc
8340 done. Redo calculations to avoid overflow.
8341 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8342
8343 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8344 subtracting pointers.
8345 (gobble_line): Check for overflow more carefully. Don't update size
8346 until alloc done.
8347
8348 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8349 Don't update size until alloc done.
8350 Redo size calculations to avoid overflow.
8351 Check for size calculation overflow.
0065d054 8352 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8353
8354 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8355 Use ptrdiff_t, not int, for sizes.
8356 (store_mode_line_noprop_char): Don't update size until alloc done.
8357
0065d054
PE
8358 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8359 Use ptrdiff_t, not int, for sizes.
8360 (Finternal_make_lisp_face, cache_face):
8361 Check for size calculation overflow.
8362 (cache_face): Treat size calculation overflows as if they were
8363 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8364
8365 * xfns.c (x_encode_text, x_set_name_internal)
8366 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8367 sizes, since they can exceed INT_MAX in size. Check for size
8368 calculation overflow.
8369
0065d054
PE
8370 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8371 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8372 Don't update size until alloc done.
8373
0065d054 8374 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8375 as sprintf is limited to int lengths.
1d526e2f 8376
252c5ee1
PE
8377 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8378 (X_LONG_MIN): New macros.
864d7ce7
PE
8379 Use them to make the following changes clearer.
8380 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8381 This change doesn't affect the value now, but it may help remind
8382 future maintainers not to raise the value too much later.
8383 (SELECTION_QUANTUM): Remove, replacing with ...
8384 (selection_quantum): ... new function, which avoids overflow.
8385 All uses changed.
8386 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8387 assumption that selection length fits in 'int'.
8388 (x_reply_selection_request, x_handle_selection_request)
8389 (x_get_window_property, receive_incremental_selection)
8390 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8391 (lisp_data_to_selection_data, clean_local_selection_data):
8392 Use ptrdiff_t, not int, to record length of selection.
8393 (x_reply_selection_request, x_get_window_property)
8394 (receive_incremental_selection, x_property_data_to_lisp):
8395 Redo calculations to avoid overflow.
8396 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8397 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8398 something.
8399 (x_get_window_property, receive_incremental_selection)
8400 (lisp_data_to_selection_data, x_property_data_to_lisp):
8401 Check for size-calculation overflow.
8402 (x_get_window_property, receive_incremental_selection)
8403 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8404 Don't store size until memory allocation succeeds.
8405 (x_get_window_property): Plug memory leak on memory exhaustion.
8406 Don't double-block input; malloc is safe here. Don't assume 2**34
8407 - 4 fits in unsigned long. Add an xassert to check
8408 XGetWindowProperty overflow. Be more careful about overflow
8409 calculations, and distinguish size from memory overflow better.
8410 (receive_incremental_selection): When tracing, don't assume
8411 unsigned int is less than INT_MAX.
8412 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8413 harmful) conversions of unsigned short to int.
8414 (lisp_data_to_selection_data): Don't assume that integers
8415 in the range -65535 through -1 fit in an X unsigned short.
8416 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8417 result parameters unless successful. Rely on cons_to_unsigned
8418 to report problems with elements; the old code wasn't right anyway.
8419 (x_check_property_data): Check for int overflow; we cannot use
8420 a wider type due to X limits.
8421 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8422
726e0ab1 8423 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8424
0065d054
PE
8425 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8426 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8427 (x_color_cells): Don't store size until memory allocation succeeds.
8428 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8429 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8430 (x_term_init): Don't assume length fits in int (sprintf is limited
8431 to int size).
bc18e09d 8432
ebfa62c0
PE
8433 Use ptrdiff_t for composition IDs.
8434 * character.c (lisp_string_width):
8435 * composite.c (composition_table_size, n_compositions)
8436 (get_composition_id, composition_gstring_from_id):
8437 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8438 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8439 * window.c (Frecenter):
8440 Use ptrdiff_t, not int, for composition IDs.
8441 * composite.c (get_composition_id): Check for integer overflow.
8442 * composite.h: Adjust prototypes to match the above changes.
8443
d3411f89
PE
8444 Use ptrdiff_t for hash table indexes.
8445 * category.c (hash_get_category_set):
8446 * ccl.c (ccl_driver):
8447 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8448 * coding.c (coding_system_charset_list, detect_coding_system):
8449 * coding.h (struct coding_system.id):
8450 * composite.c (get_composition_id, gstring_lookup_cache):
8451 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8452 * image.c (xpm_get_color_table_h):
8453 * lisp.h (hash_lookup, hash_put):
8454 * minibuf.c (Ftest_completion):
8455 Use ptrdiff_t for hash table indexes, not int (which is too
8456 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8457 32-bit --with-wide-int hosts).
8458
e097a6fa
PE
8459 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8460 Add a FIXME comment about memory leaks.
8461 (syms_of_charset): Don't assume xmalloc returns.
8462
5637687f
PE
8463 Don't assume that stated character widths fit in int.
8464 * character.c (Fchar_width, c_string_width, lisp_string_width):
8465 * character.h (CHAR_WIDTH):
8466 * indent.c (MULTIBYTE_BYTES_WIDTH):
8467 Use sanitize_char_width to avoid undefined and/or bad behavior
8468 with outlandish widths.
a66cfb1c 8469 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8470 now that we have two such functions. All uses changed.
8471 (sanitize_char_width): New inline function.
8472
a2271ba2
PE
8473 Don't assume that tab-width fits in int.
8474 * character.h (sanitize_width): New inline function.
8475 (SANE_TAB_WIDTH): New macro.
8476 (ASCII_CHAR_WIDTH): Use it.
8477 * indent.c (sane_tab_width): Remove. All uses replaced by
8478 SANE_TAB_WIDTH (current_buffer).
8479 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8480
18c52557
PE
8481 * fileio.c: Integer overflow issues with file modes.
8482 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8483
caeeedc1
PE
8484 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8485 Remove unreachable code.
8486 (read_hex, load_charset_map_from_file): Check for integer overflow.
8487
6df6ae42 8488 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8489 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8490 (x_send_scroll_bar_event): Likewise. Check that the size does not
8491 exceed limits imposed by XClientMessageEvent, as well as the usual
8492 ptrdiff_t and size_t limits.
8493
b13995db
PE
8494 * keyboard.c: Overflow, signedness and related fixes.
8495 (make_lispy_movement): Use same integer type in forward decl
8496 that is used in the definition.
8497 (read_key_sequence, keyremap_step):
8498 Change bufsize argument back to int, undoing my 2011-03-30 change.
8499 We prefer signed types, and int is wide enough here.
8500 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8501 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8502 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8503 length, not size_t. Use ptrdiff_t for index, not int.
8504 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8505 possibility of integer overflow.
8506
13464394
PE
8507 Overflow, signedness and related fixes for images.
8508
8509 * dispextern.h (struct it.stack[0].u.image.image_id)
8510 (struct_it.image_id, struct image.id, struct image_cache.size)
8511 (struct image_cache.used, struct image_cache.ref_count):
8512 * gtkutil.c (update_frame_tool_bar):
8513 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8514 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8515 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8516 * nsmenu.m (update_frame_tool_bar):
8517 * xdisp.c (calc_pixel_width_or_height):
8518 * xfns.c (image_cache_refcount):
8519 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8520 on typical 64-bit hosts.
8521
8522 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8523 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8524 Omit unnecessary casts to int.
8525 (parse_image_spec): Check that integers fall into 'int' range
8526 when the callers expect that.
8527 (image_ascent): Redo ascent calculation to avoid int overflow.
8528 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8529 (lookup_image): Remove unnecessary tests.
8530 (xbm_image_p): Locals are now of int, not EMACS_INT,
8531 since parse_image_check makes sure they fit into int.
8532 (png_load, gif_load, svg_load_image):
8533 Prefer int to unsigned where either will do.
8534 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8535 old tiff_error_handler and tiff_warning_handler.
8536 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8537 stack buffer overflows. It uses only the features of vsnprintf
8538 that are common to both POSIX and native Microsoft.
8539 (tiff_error_handler, tiff_warning_handler): Use it.
8540 (tiff_load, gif_load, imagemagick_load_image):
8541 Don't assume :index value fits in 'int'.
8542 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8543 (imagemagick_load_image): Check that crop parameters fit into
8544 the integer types that MagickCropImage accepts. Don't assume
8545 Vimagemagick_render_type has a nonnegative value. Don't assume
8546 size_t fits in 'long'.
8547 (gs_load): Use printmax_t to print the widest integers possible.
8548 Check for integer overflow when computing image height and width.
8549
c11821d4
EZ
85502011-08-26 Eli Zaretskii <eliz@gnu.org>
8551
8552 * xdisp.c (redisplay_window): Don't force window start if point
8553 will be invisible in the resulting window. (Bug#9324)
8554
0c95fcf7
EZ
85552011-08-25 Eli Zaretskii <eliz@gnu.org>
8556
8557 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8558 the display spec is of the form `(space ...)'.
8559 (handle_display_spec): Return the value returned by
8560 handle_single_display_spec, not just 1 or zero.
8561 (handle_single_display_spec): If the display spec is of the form
8562 `(space ...)', and specifies display in the text area, return 2
8563 rather than 1.
fee65a97 8564 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8565 accurately, and prefer exact match for point under bidi.
8566 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8567
8568 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8569 into disp_prop; all users changed.
8570
8571 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8572 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8573 for the text covered by the display property.
8574
e4ed06f1
CY
85752011-08-25 Chong Yidong <cyd@stupidchicken.com>
8576
8577 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8578 Change return value to nil.
8579 (Frecord_buffer): Delete unused function.
8580
f67cdd7f
EZ
85812011-08-24 Eli Zaretskii <eliz@gnu.org>
8582
5980d4c6
EZ
8583 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8584 buffers, return left-to-right.
8610fe8b
EZ
8585 (set_cursor_from_row): Consider candidate row a win if its glyph
8586 represents a newline and point is on that newline. Fixes cursor
8587 positioning on the newline at EOL of R2L text within L2R
8588 paragraph, and vice versa.
8589 (try_cursor_movement): Check continued rows, in addition to
8590 continuation rows. Fixes unwarranted scroll when point enters a
8591 continued line of R2L text within an L2R paragraph, or vice versa.
8592 (cursor_row_p): Consider the case of point being equal to
8593 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8594 from the end of a short line to the beginning of a continued line
8595 of R2L text within L2R paragraph.
8596 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8597 composed characters.
5980d4c6 8598
f67cdd7f
EZ
8599 * bidi.c (bidi_check_type): Use xassert.
8600 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8601 members.
8602
bca633fb
EZ
86032011-08-23 Eli Zaretskii <eliz@gnu.org>
8604
8605 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8606 a character.
8607
4a5885a7
CY
86082011-08-23 Chong Yidong <cyd@stupidchicken.com>
8609
8610 * nsfont.m (ns_otf_to_script): Fix typo.
8611
0902a04e
KH
86122011-08-22 Kenichi Handa <handa@m17n.org>
8613
8614 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8615 extra slot even if the purpose is char-code-property-table.
8616
1a2e6670
EZ
86172011-08-23 Eli Zaretskii <eliz@gnu.org>
8618
8ddde651
EZ
8619 * xdisp.c (redisplay_window): When computing centering_position,
8620 account for the height of the header line. (Bug#8874)
8621
425cc014
EZ
8622 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8623 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8624 candidate is selected by the mouse, and that candidate has a
8625 composed character under the mouse.
8626
1a2e6670
EZ
8627 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8628 coordinates reported by pos-visible-in-window-p for a composed
8629 character in column zero.
8630
8b76d6f8
SM
86312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8632
8633 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8634
dac347dd
EZ
86352011-08-22 Eli Zaretskii <eliz@gnu.org>
8636
8637 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8638 consider it a hit if to_charpos is anywhere in the range of the
8639 composed buffer positions.
8640
e013fb34
CY
86412011-08-22 Chong Yidong <cyd@stupidchicken.com>
8642
8643 * image.c (gif_load): Don't assume that each subimage has the same
8644 dimensions as the base image. Handle disposal method that is
8645 "undefined" by the gif spec (Bug#9335).
8646
bd1ba3e8
CY
86472011-08-20 Chong Yidong <cyd@stupidchicken.com>
8648
8649 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8650 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8651
54a1215b
EZ
86522011-08-19 Eli Zaretskii <eliz@gnu.org>
8653
823564e5
EZ
8654 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8655 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8656 from an Org mode buffer to a Speedbar frame.
8657
54a1215b
EZ
8658 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8659 a composition, take its buffer position from IT->cmp_it.charpos.
8660 Fixes cursor positioning at the beginning of a line that begins
8661 with a composed character.
8662
9778ebcc
EZ
86632011-08-18 Eli Zaretskii <eliz@gnu.org>
8664
0be6ee06
EZ
8665 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8666 character bidirectional type, use STRONG_L instead. Fixes crashes
8667 in a buffer produced by `describe-categories'.
8668
9778ebcc
EZ
8669 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8670 members before the level stack, so they would be saved and
8671 restored when copying iterator state. Fixes incorrect reordering
8672 around TABs covered by display properties.
8673
156bffbe
AS
86742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8675
6b02f655 8676 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8677
72ad093b
CY
86782011-08-17 Chong Yidong <cyd@stupidchicken.com>
8679
8680 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8681 (internal_condition_case_2, internal_condition_case_n):
8682 Remove unnecessary aborts (Bug#9081).
72ad093b 8683
35774242
EZ
86842011-08-17 Eli Zaretskii <eliz@gnu.org>
8685
8686 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8687 has no `load' handler, try opening the file locally. (Bug#9311)
8688
db76dd85
KB
86892011-08-16 Ken Brown <kbrown@cornell.edu>
8690
8691 * gmalloc.c: Expand comment.
8692
b215eee5
EZ
86932011-08-16 Eli Zaretskii <eliz@gnu.org>
8694
8695 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8696 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8697
a4579d33
KB
86982011-08-16 Ken Brown <kbrown@cornell.edu>
8699
8700 Fix memory allocation problems in Cygwin build (Bug#9273).
8701
8702 * unexcw.c ( __malloc_initialized): Declare external variable.
8703 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8704
8b76d6f8
SM
8705 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8706 New variables.
a4579d33
KB
8707 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8708 dumped emacs.
8709 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8710 in the static heap.
8711 [CYGWIN] (special_realloc): New function.
8712 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8713 requests to realloc storage in the static heap.
8714
3ebec551
PE
87152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8716
8717 * bidi.c (bidi_initialize): Remove unused local.
8718
9fd8be00
EZ
87192011-08-15 Eli Zaretskii <eliz@gnu.org>
8720
6b02f655
SM
8721 * bidimirror.h:
8722 * biditype.h: Remove file.
8723 * makefile.w32-in ($(BLD)/bidi.$(O)):
8724 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8725
8726 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8727
8728 * chartab.c: Improve commentary for the uniprop_table API.
8729
32413314
EZ
8730 * bidi.c (bidi_paragraph_init): Support zero value of
8731 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8732 (bidi_initialize): Use uniprop_table instead of including
8733 biditype.h and bidimirror.h.
32413314 8734
9fd8be00
EZ
8735 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8736 coordinates of the iterator when restoring from ppos_it.
8737 (Bug#9296)
8738
5cf2b69b
KH
87392011-08-14 Kenichi Handa <handa@m17n.org>
8740
8741 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8742 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8743
daf17d00
EZ
87442011-08-14 Eli Zaretskii <eliz@gnu.org>
8745
8746 * xdisp.c (move_it_in_display_line_to): Don't invoke
8747 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8748 ppos_it. Fixes vertical cursor motion when line beginning is
8749 covered by an image. (Bug#9296)
8750
08e3161a
JD
87512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8752
8753 * nsterm.h (ns_run_ascript): Declare.
8754 (NSAPP_DATA2_RUNASSCRIPT): Define.
8755
8756 * nsfns.m (as_script, as_result, as_status): New static variables.
8757 (ns_run_ascript): New function.
5e617bc2 8758 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8759 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8760 the event loop. Get status from as_status (Bug#7276).
8761
8762 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8763 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8764 the event loop (Bug#7276).
8765
a3720aa2
AS
87662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8767
8768 * gnutls.c (QCgnutls_bootprop_priority)
8769 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8770 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8771 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8772 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8773 (QCgnutls_bootprop_verify_hostname_error)
8774 (QCgnutls_bootprop_callbacks_verify): Rename from
8775 Qgnutls_bootprop_..., all uses changed.
8776
8777 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8778 uses changed.
8779
0a0d27fb
PE
87802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8781
19d5c50c
PE
8782 * xfaces.c (Qframe_set_background_mode): Now static.
8783 * dispextern.h (Qframe_set_background_mode): Remove decl.
8784
0a0d27fb
PE
8785 * process.c (Fnetwork_interface_info): Declare local only if needed.
8786
377538cb
JD
87872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8788
8789 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8790 (Fnetwork_interface_list): Allocate in increments of bytes instead
8791 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8792 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8793 sockaddr.
8794 (struct ifflag_def): notrailers is smart on OSX.
8795 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8796 Get hardware address with getifaddrs if available.
8797
08fff70c
EZ
87982011-08-12 Eli Zaretskii <eliz@gnu.org>
8799
8800 * xdisp.c (iterate_out_of_display_property): xassert that
8801 IT->position is set to within IT->object's boundaries. Break from
8802 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8803 when IT->position is set up wrongly due to some bug.
8804 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8805 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8806 entry. Force push_it to save on the stack the current
8807 buffer/string position, to be restored by pop_it. Fix flags in
8808 the iterator structure wrt the object coming from a display
8809 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8810 properties. (Bug#9284)
8811
7be1c708 88122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8813
7be1c708
CY
8814 * fontset.c (fontset_get_font_group): Add proper type checks.
8815 (Bug#9172)
aac0c6e3 8816
7be1c708 88172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8818
7be1c708
CY
8819 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8820 and LC_VERSION_MIN_MACOSX.
8821 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8822 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8823
97bb72a6
EZ
88242011-08-08 Eli Zaretskii <eliz@gnu.org>
8825
8826 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8827 no-display-properties-and-no-overlays under bidi display.
8828 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8829 properties and overlays.
97bb72a6 8830
d5617611
CY
88312011-08-08 Chong Yidong <cyd@stupidchicken.com>
8832
37e11a63
CY
8833 * editfns.c (Fset_time_zone_rule): Document relationship with the
8834 setenv function.
8835
d5617611
CY
8836 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8837 the font entity extracted from the cache (Bug#8109).
8838
58872834
CY
88392011-08-07 Chong Yidong <cyd@stupidchicken.com>
8840
8841 * composite.c (autocmp_chars): Don't reset point. That is done by
8842 restore_point_unwind (Bug#5984).
8843
75bfc667
JL
88442011-08-07 Juri Linkov <juri@jurta.org>
8845
8846 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8847 to show the arg `TIME' instead of `TIMEVAL'.
8848
d1410150
EZ
88492011-08-06 Eli Zaretskii <eliz@gnu.org>
8850
8851 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8852 display property strides EOL and includes a newline, as in
8853 longlines-mode. (Bug#9254)
75b771e4
EZ
8854 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8855 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8856
8857 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8858 is non-zero, even if the data buffer is NULL. Fixes a crash in
8859 vertical-motion with longlines-mode. (Bug#9254)
8860
35928349
EZ
88612011-08-05 Eli Zaretskii <eliz@gnu.org>
8862
ec7cc85b
EZ
8863 * bidi.c <bidi_cache_total_alloc>: Now static.
8864 (bidi_initialize): Initialize bidi_cache_total_alloc.
8865
8b76d6f8 8866 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8867 cache. (Bug#9221)
8868
8869 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8870 amount allocated this far in `bidi_cache_total_alloc'.
8871 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8872 non-zero, only free the data buffer without restoring the cache
8873 contents. All callers changed.
8874
8875 * dispextern.h (bidi_unshelve_cache): Update prototype.
8876
8877 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8878 (move_it_in_display_line, move_it_to)
8879 (move_it_vertically_backward, move_it_by_lines): Replace the call
8880 to xfree to an equivalent call to bidi_unshelve_cache.
8881 (move_it_in_display_line_to): Fix logic of returning
412b6358 8882 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8883
e2e2423b
EZ
88842011-08-05 Eli Zaretskii <eliz@gnu.org>
8885
8886 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8887 came from a string character with a `cursor' property. (Bug#9229)
8888
ae9e757a
JD
88892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * Makefile.in (LIB_PTHREAD): New variable.
8892 (LIBES): Add LIB_PTHREAD (Bug#9216).
8893
8894 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8895 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8896
213bd7f2
AS
88972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8898
6b02f655 8899 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8900
99aaf75f
JD
89012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8902
8903 * xterm.c (x_find_topmost_parent): New function.
8904 (x_set_frame_alpha): Find topmost parent window with
8905 x_find_topmost_parent and set the property there also (bug#9181).
8906 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8907
c74e9d86
PE
89082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8909
8910 * callproc.c (Fcall_process): Avoid vfork clobbering
8911 the local vars buffer, coding_systems, current_dir.
8912
640c8776
SM
89132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8914
8915 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8916
f26d0e4c
PE
89172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8918
8a10d76c
PE
8919 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8920 so that it is not optimized away.
8921
f26d0e4c
PE
8922 * xdisp.c (compute_display_string_pos): Remove unused local.
8923
55439c61
EZ
89242011-08-02 Eli Zaretskii <eliz@gnu.org>
8925
8926 Fix slow cursor motion and scrolling in large buffers with
8927 selective display, like Org Mode buffers. (Bug#9218)
8928
8929 * dispextern.h (struct bidi_it): New member disp_prop_p.
8930
8931 * xdisp.c: Remove one-slot cache of display string positions.
8932 (compute_display_string_pos): Accept an additional argument
5e617bc2 8933 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8934 for a display string or property. If found, set DISP_PROP_P
8935 non-zero.
8936
8937 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8938 DISP_PROP_P, and pass it to compute_display_string_pos.
8939 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8940 non-zero. All callers of bidi_fetch_char changed.
8941
fb33fa43
SM
89422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8943
8944 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8945
b099e063
DM
89462010-12-03 Don March <don@ohspite.net>
8947
8948 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8949 last character M-[char] is translated to ESC [char] (bug#7541).
8950
5cc7f7af
KH
89512011-08-02 Kenichi Handa <handa@m17n.org>
8952
d0fffa3f 8953 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8954
8955 * chartab.c (uniprop_table): Make it non-static.
8956
525d5e6e
EZ
89572011-08-01 Eli Zaretskii <eliz@gnu.org>
8958
8959 * xdisp.c (forward_to_next_line_start): Accept additional argument
8960 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8961 on the newline.
8962 (reseat_at_next_visible_line_start): Use the bidi iterator state
8963 returned by forward_to_next_line_start to restore the state of
8964 it->bidi_it after backing up to previous newline. (Bug#9212)
8965
31011111
AS
89662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8967
8968 * regex.c (re_comp): Protoize.
8969 (re_exec): Fix return type.
8970 (regexec): Fix type of `ret'. (Bug#9203)
8971
476371c4
PE
89722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8973
e5d76069
PE
8974 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8975 This is needed if max-image-size is a floating-point number.
8976
9a79b20c
AS
89772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8978
8979 * print.c (print_object): Print empty symbol as ##.
8980
8981 * lread.c (read1): Read ## as empty symbol.
8982
d8c2fa78
AA
89832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8984
8985 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8986 setting frame foreground color (Bug#9175).
8987 (x_set_background_color): Likewise.
8988
ffe57a7a
AA
8989 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8990 contents (Bug#9176).
8991 (EmacsTooltip -init): Remove bezels and add shadows to
8992 tooltip windows.
8993
bf3492a5
AA
8994 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8995 or scroll bar (Bug#8470).
8996
d55e9c53
AA
8997 * nsfont.m (nsfont_open): Remove assignment to voffset and
8998 unnecessary vars hshink, expand, hd, full_height, min_height.
8999 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9000
9001 * nsterm.h (nsfont_info): Remove voffset field.
9002
d8c2fa78 90032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9004
9005 Implement strike-through and overline on NextStep (Bug#8863).
9006
9007 * nsfont.m (nsfont_open): Use underline position provided by font,
9008 instead of hard-coded value of 2.
9009 (nsfont_draw): Call ns_draw_text_decoration instead.
9010
9011 * nsterm.h: Add declaration for ns_draw_text_decoration.
9012
9013 * nsterm.m (ns_draw_text_decoration): New function for drawing
9014 underline, overline, and strike-through.
9015 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9016 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9017 accommodate underlining, etc.
4843aac3 9018
4cc60b9b
EZ
90192011-07-28 Eli Zaretskii <eliz@gnu.org>
9020
bc7ece87
EZ
9021 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9022 default.
4cc60b9b 9023
476371c4
PE
90242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9025
66606eea
PE
9026 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9027 Without this fix, if a signal arrives just after memory fills up,
9028 'malloc' might be invoked reentrantly.
9029
476371c4
PE
9030 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9031 In other words, assume that every image size is allowed, on non-X
9032 hosts. This assumption is probably wrong, but it lets Emacs compile.
9033
f3fcc40d
AS
90342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9035
9036 * regex.c (re_iswctype): Convert return values to boolean.
9037
350c992f
EZ
90382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9039
9040 * xdisp.c (compute_display_string_pos): Don't use cached display
9041 string position if the buffer had its restriction changed.
9042 (Bug#9184)
9043
5266b4bb
PE
90442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9045
9046 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9047
2573a837 90482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9049
41f55ccd 9050 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9051
39e378da
PE
9052 * bidi.c: Integer size and overflow fixes.
9053 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9054 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9055 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9056 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9057 (bidi_find_other_level_edge):
9058 Use ptrdiff_t instead of EMACS_INT where either will do.
9059 This works better on 32-bit hosts configured --with-wide-int.
9060 (bidi_cache_ensure_space): Check for size-calculation overflow.
9061 Use % rather than repeated addition, for better worst-case speed.
9062 Don't set bidi_cache_size until after xrealloc returns, because it
9063 might not return.
9064 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9065 (bidi_cache_ensure_space): Also check that the bidi cache size
9066 does not exceed that of the largest Lisp string or buffer. See Eli
9067 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9068
5e927815
PE
9069 * alloc.c (__malloc_size_t): Remove.
9070 All uses replaced by size_t. See Andreas Schwab's note
9071 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9072
ca4aa935
PE
9073 * image.c: Improve checking for integer overflow.
9074 (check_image_size): Assume that f is nonnull, since
9075 it is always nonnull in practice. This is one less thing to
9076 worry about when checking for integer overflow later.
9077 (x_check_image_size): New function, which checks for integer
9078 overflow issues inside X.
9079 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9080 This removes the need for a memory_full check.
9081 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9082 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9083 (xbm_read_bitmap_data): Change locals back to 'int', since
9084 their values must fit in 'int'.
9085 (xpm_load_image, png_load, tiff_load):
9086 Invoke x_create_x_image_and_pixmap earlier,
9087 to avoid much needless work if the image is too large.
9088 (tiff_load): Treat overly large images as if
9089 x_create_x_image_and_pixmap failed, not as malloc failures.
9090 (gs_load): Use x_check_image_size.
9091
5f8f9cc2
PE
9092 * gtkutil.c: Omit integer casts.
9093 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9094 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9095
5adf60bc
PE
9096 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9097
c8907a93
PE
9098 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9099 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9100 would wrongly return t on a 64-bit host.
9101
e3c25c68
PE
9102 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9103 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9104 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9105 and therefore cause GCC to emit a bogus diagnostic in some cases.
9106
3f791afe
PE
9107 * image.c: Integer signedness and overflow and related fixes.
9108 This is not an exhaustive set of fixes, but it's time to
9109 record what I've got.
9110 (lookup_pixel_color, check_image_size): Remove redundant decls.
9111 (check_image_size): Don't assume that arbitrary EMACS_INT values
9112 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9113 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9114 (tiff_load, imagemagick_load_image):
9115 Check for overflow in size calculations.
9116 (x_create_x_image_and_pixmap): Remove unnecessary test for
9117 xmalloc returning NULL; that can't happen.
9118 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9119 (xpm_color_bucket): Use better integer hashing function.
9120 (xpm_cache_color): Don't possibly over-allocate memory.
9121 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9122 (gif_memory_source):
9123 Use ptrdiff_t, not int or size_t, to record sizes.
9124 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9125 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9126 either works, as we prefer signed integers.
9127 (tiff_read_from_memory, tiff_write_from_memory):
9128 Return tsize_t, not size_t, since that's what the TIFF API wants.
9129 (tiff_read_from_memory): Don't fail simply because the read would
9130 go past EOF; instead, return a short read.
9131 (tiff_load): Omit no-longer-needed casts.
9132 (Fimagemagick_types): Don't assume size fits into 'int'.
9133
3cc5a532
PE
9134 Improve hashing quality when configured --with-wide-int.
9135 * fns.c (hash_string): New function, taken from sxhash_string.
9136 Do not discard information about ASCII character case; this
9137 discarding is no longer needed.
9138 (sxhash-string): Use it. Change sig to match it. Caller changed.
9139 * lisp.h: Declare it.
9140 * lread.c (hash_string): Remove, since we now use fns.c's version.
9141 The fns.c version returns a wider integer if --with-wide-int is
9142 specified, so this should help the quality of the hashing a bit.
9143
b312a492
PE
9144 * emacs.c: Integer overflow minor fix.
9145 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9146 Define only if GNU_LINUX.
9147 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9148
dfd153ae
PE
9149 * dispnew.c: Integer signedness and overflow fixes.
9150 Remove unnecessary forward decls, that were a maintenance hassle.
9151 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9152 All uses changed.
9153 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9154 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9155 (prepare_desired_row, line_draw_cost):
9156 Use int, not unsigned, where either works.
9157 (save_current_matrix, restore_current_matrix):
9158 Use ptrdiff_t, not size_t, where either works.
9159 (init_display): Check for overflow more accurately, and without
9160 relying on undefined behavior.
9161
a81d11a3
PE
9162 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9163 Remove, replacing with the new symbols in lisp.h. All uses changed.
9164 * fileio.c (make_temp_name):
9165 * filelock.c (lock_file_1, lock_file):
9166 * xdisp.c (message_dolog):
9167 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9168 Use pMd etc. instead.
9169 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9170 replacing the pWIDE etc. symbols removed from editfns.c.
9171
3300e6fd
PE
9172 * keyboard.h (num_input_events): Now uintmax_t.
9173 This is (very slightly) less likely to mess up due to wraparound.
9174 All uses changed.
9175
fd05c7e9
PE
9176 * buffer.c: Integer signedness fixes.
9177 (alloc_buffer_text, enlarge_buffer_text):
9178 Use ptrdiff_t rather than size_t when either will do, as we prefer
9179 signed integers.
9180
903fe15d
PE
9181 * alloc.c: Integer signedness and overflow fixes.
9182 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9183 (__malloc_size_t): Default to size_t, not to int.
9184 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9185 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9186 Prefer ptrdiff_t to size_t when either would do, as we prefer
9187 signed integers.
9188 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9189 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9190 Now const. Initialize with values that are in range even if char
9191 is signed.
9192 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9193 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9194 These functions do the right thing with sizes > 2**32.
9195 (check_depth): Now ptrdiff_t, not int.
9196 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9197 Adjust to new way of storing sizes. Check for size overflow bugs
9198 in rest of code.
9199 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9200 slightly wrong anyway, as it missed one instance of
9201 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9202 (refill_memory_reserve): Omit needless cast to size_t.
9203 (mark_object_loop_halt): Mark as externally visible.
9204
ac82cc6a
PE
9205 * xselect.c: Integer signedness and overflow fixes.
9206 (Fx_register_dnd_atom, x_handle_dnd_message):
9207 Use ptrdiff_t, not size_t, since we prefer signed.
9208 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9209 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9210 x_dnd_atoms_size and x_dnd_atoms_length.
9211
c2d1e36d
PE
9212 * doprnt.c: Prefer signed to unsigned when either works.
9213 * eval.c (verror):
9214 * doprnt.c (doprnt):
9215 * lisp.h (doprnt):
9216 * xdisp.c (vmessage):
9217 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9218 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9219 prefer signed arithmetic to avoid comparison confusion.
9220 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9221 but is a bit tricky.
9222
0e926e56
PE
9223 Assume freestanding C89 headers, string.h, stdlib.h.
9224 * data.c, doprnt.c, floatfns.c, print.c:
9225 Include float.h unconditionally.
9226 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9227 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9228 * regex.c: Likewise for stddef.h, string.h.
9229 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9230 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9231 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9232 (STDC_HEADERS): Remove obsolete defines.
9233 * sysdep.c: Include limits.h unconditionally.
9234
9cfdb3ec
PE
9235 Assume support for memcmp, memcpy, memmove, memset.
9236 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9237 * regex.c (memcmp, memcpy):
9238 Remove; we assume C89 now.
9239
9240 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9241 (__malloc_safe_bcopy): Remove; no longer needed.
9242
cf950e6b 9243 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9244 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9245 well either way, and we prefer signed to unsigned.
9246
dbf38e02
LMI
92472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9248
9249 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9250 closes the connection while we're reading (bug#9182).
9251
d6f0886c 92522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9253
d6f0886c
JD
9254 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9255 are specified (Bug#9168).
24e0f6b1 9256
2eb1f9e6
PE
92572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9258
9259 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9260 Found by GCC static checking and --with-wide-int on a 32-bit host.
9261
22381272 92622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9263
9264 * xdisp.c (compute_display_string_pos): Fix logic of caching
9265 previous display string position. Initialize cached_prev_pos to
9266 -1. Fixes slow-down at the beginning of a buffer.
9267
f25e39b4
EZ
92682011-07-24 Eli Zaretskii <eliz@gnu.org>
9269
9270 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9271 for attrs[LFACE_FONTSET_INDEX].
9272
04c4b52e
PE
92732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9274
9275 * xml.c (parse_region): Remove unused local
9276 that was recently introduced.
9277
c1734fbd
EZ
92782011-07-23 Eli Zaretskii <eliz@gnu.org>
9279
be18c5a5
EZ
9280 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9281 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9282
c1734fbd
EZ
9283 * xdisp.c (move_it_in_display_line_to): Record the best matching
9284 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9285 exit if none of the characters scanned was an exact match.
9286 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9287 when exact match is impossible due to invisible text, and the
9288 lines are truncated.
9289
a258d627
JD
92902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9291
9292 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9293 for OSX >= 10.7.
9294
b6d5a689
EZ
92952011-07-22 Eli Zaretskii <eliz@gnu.org>
9296
0f74f785
EZ
9297 Fix a significant slow-down of cursor motion with C-n, C-p,
9298 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9299 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9300 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9301 (next_element_from_buffer): Call compute_stop_pos_backwards to
9302 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9303 base_level_stop.
9304 (reseat): Don't look for prev_stop, as that could mean a very long
9305 run.
9306 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9307 <cached_disp_overlay_modiff>: Cache for last found display string
9308 position.
551918c1 9309 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9310 about the same buffer in the same area of character positions, and
9311 the buffer wasn't changed since the time the display string
9312 position was cached.
551918c1 9313
b2d0c91a
EZ
93142011-07-22 Eli Zaretskii <eliz@gnu.org>
9315
9316 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9317 is an integer, which is important for empty lines. (Bug#9149)
9318
043604ee
CY
93192011-07-22 Chong Yidong <cyd@stupidchicken.com>
9320
9321 * frame.c (Fmodify_frame_parameters): In tty case, update the
9322 default face if necessary (Bug#4238).
9323
da4adb04
CY
93242011-07-21 Chong Yidong <cyd@stupidchicken.com>
9325
9326 * editfns.c (Fstring_to_char): No need to explain what a character
9327 is in the docstring (Bug#6576).
9328
9abd0532
LMI
93292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9330
9331 * xml.c (parse_region): Make sure we always return a tree.
9332
36881d16
HK
93332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9334
9335 * xml.c (parse_region): If a document contains only comments,
9336 return that, too.
9337
1e98674d
LMI
93382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9339
9340 * xml.c (make_dom): Return comments, too.
9341
590bd467
PE
93422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9343
9344 Port to OpenBSD.
9345 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9346 and the surrounding thread.
9347 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9348 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9349 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9350 timer goes off.
9351 * s/openbsd.h (BROKEN_SIGIO): Define.
9352 * unexelf.c (unexec) [__OpenBSD__]:
9353 Don't update the .mdebug section of the Alpha COFF symbol table.
9354
f41628b2
LMI
93552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9356
9357 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9358 (bug#8460).
9359
b59b67c5
PE
93602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9361
15e3a074
PE
9362 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9363 This fixes some race conditions on the permissions of any newly
9364 created file.
9365
41bed37d
PE
9366 * alloc.c (valid_pointer_p): Use pipe, not open.
9367 This fixes some permissions issues when debugging.
9368
b59b67c5
PE
9369 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9370 If fchown fails to set both uid and gid, try to set just gid,
9371 as that is sometimes allowed. Adjust the file's mode to eliminate
9372 setuid or setgid bits that are inappropriate if fchown fails.
9373
925a6be7
SM
93742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9375
9376 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9377 to compare Lisp_Objects.
9378 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9379 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9380 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9381
52968808
AS
93822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9383
0a6a104b
AS
9384 * lread.c (read_integer): Unread even EOF character.
9385 (read1): Likewise. Properly record start position of symbol.
9386
52968808
AS
9387 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9388 symbol character follows.
9389
9e381cdd
PE
93902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9391
9392 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9393 This works around a problem with the previous change to Fcopy_file.
9394 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9395 and without this change, GCC might complain about discarding
9396 fchown's return value.
9397
b5641435
JB
93982011-07-16 Juanma Barranquero <lekktu@gmail.com>
9399
9400 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9401
a8031457
PE
94022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9403
9404 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9405
dd889327
LMI
94062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9407
750c33f7
LMI
9408 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9409 it's used from the C level.
9410
dd889327
LMI
9411 * process.c: Use the same condition for POLL_FOR_INPUT in both
9412 keyboard.c and process.c (bug#1858).
9413
87e86684
LM
94142011-07-09 Lawrence Mitchell <wence@gmx.li>
9415
9416 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9417 (Fgnutls_boot): Use it.
9418
64348f40
AS
94192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9420
9421 * doc.c (Fsubstitute_command_keys): Revert last change.
9422
1d698799
LMI
94232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9424
f863868c
LMI
9425 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9426 quotes the next character, and doesn't affect other longer
9427 sequences (bug#8935).
9428
1d698799
LMI
9429 * lread.c (syms_of_lread): Clarify that is isn't only
9430 `eval-buffer' and `eval-defun' that's affected by
9431 `lexical-binding' (bug#8460).
9432
aa4b6df6
EZ
94332011-07-15 Eli Zaretskii <eliz@gnu.org>
9434
9435 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9436 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9437
5d856da6
PE
94382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9439
ad6042bb
PE
9440 Fix minor problems found by static checking.
9441 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9442 (elsz): Now a signed constant, not a size_t var. We prefer signed
9443 types to unsigned, to avoid integer comparison confusion. Without
9444 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9445 "cannot optimize loop, the loop counter may overflow", a symptom
9446 of the confusion.
f00bbb22 9447 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9448 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9449
6468f31c
LMI
94502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9451
49080b10
LMI
9452 * search.c (Fre_search_backward): Mention `case-fold-search' in
9453 all the re_search_* functions (bug#8138).
9454
6468f31c
LMI
9455 * keyboard.c (Fopen_dribble_file): Document when the file is
9456 closed (bug#8056).
9457
c965adc5
EZ
94582011-07-14 Eli Zaretskii <eliz@gnu.org>
9459
df9733bf
EZ
9460 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9461 bidi_cache_idx.
9462
0bb23927
EZ
9463 Support bidi reordering of display and overlay strings.
9464 * xdisp.c (compute_display_string_pos)
9465 (compute_display_string_end): Accept additional argument STRING.
9466 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9467 (reseat_to_string): Initialize bidi_it->string.s and
9468 bidi_it->string.schars.
9469 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9470 NULL (avoids a crash in bidi_paragraph_init).
9471 Initialize itb.string.lstring.
0bb23927
EZ
9472 (init_iterator): Call bidi_init_it only of a valid
9473 buffer position was specified. Initialize paragraph_embedding to
9474 L2R.
9475 (reseat_to_string): Initialize the bidi iterator.
9476 (display_string): If we need to ignore text properties of
9477 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9478 original value of -1 will not work with bidi.)
9479 (compute_display_string_pos): First arg is now struct
9480 `text_pos *'; all callers changed. Support display properties on
9481 Lisp strings.
9482 (compute_display_string_end): Support display properties on Lisp
9483 strings.
9484 (init_iterator, reseat_1, reseat_to_string): Initialize the
9485 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9486 when iterating on a string not from display properties).
640c8776
SM
9487 (compute_display_string_pos, compute_display_string_end):
9488 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9489 arrow keys.
9490 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9491 base_level_stop; instead, set base_level_stop to BEGV.
9492 Fixes crashes in vertical-motion.
0bb23927
EZ
9493 (next_element_from_buffer): Improve commentary for when
9494 the iterator is before prev_stop.
9495 (init_iterator): Initialize bidi_p from the default value of
9496 bidi-display-reordering, not from buffer-local value. Use the
9497 buffer-local value only if initializing for buffer iteration.
9498 (handle_invisible_prop): Support invisible properties on strings
9499 that are being bidi-reordered.
9500 (set_iterator_to_next): Support bidi reordering of C strings and
9501 Lisp strings.
9502 (next_element_from_string): Support bidi reordering of Lisp
9503 strings.
9504 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9505 (display_string): Support display of R2L glyph rows.
9506 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9507 (init_iterator): Don't initialize it->bidi_p for strings
9508 here.
9509 (reseat_to_string): Initialize it->bidi_p for strings here.
9510 (next_element_from_string, next_element_from_c_string)
9511 (next_element_from_buffer): Add xassert's for correspondence
9512 between IT's object being iterated and it->bidi_it.string
9513 structure.
9514 (face_before_or_after_it_pos): Support bidi iteration.
9515 (next_element_from_c_string): Handle the case of the first string
9516 character that is not the first one in the visual order.
9517 (get_visually_first_element): New function, refactored from common
9518 parts of next_element_from_buffer, next_element_from_string, and
9519 next_element_from_c_string.
9520 (tool_bar_lines_needed, redisplay_tool_bar)
9521 (display_menu_bar): Force left-to-right direction. Add a FIXME
9522 comment for making that be controlled by a user option.
9523 (push_it, pop_it): Save and restore the state of the
9524 bidi iterator. Save and restore the bidi_p flag.
9525 (pop_it): Iterate out of display property for string iteration as
9526 well.
9527 (iterate_out_of_display_property): Support iteration over strings.
9528 (handle_single_display_spec): Set up it->bidi_it for iteration
9529 over a display string, and call bidi_init_it.
9530 (handle_single_display_spec, next_overlay_string)
9531 (get_overlay_strings_1, push_display_prop): Set up the bidi
9532 iterator for displaying display or overlay strings.
9533 (forward_to_next_line_start): Don't use the shortcut if
9534 bidi-iterating.
9535 (back_to_previous_visible_line_start): If handle_display_prop
9536 pushed the iterator stack, restore the internal state of the bidi
9537 iterator by calling bidi_pop_it same number of times.
9538 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9539 and we are bidi-iterating, don't decrement the iterator position;
9540 instead, set the first_elt flag in the bidi iterator, to produce
9541 the same effect.
9542 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9543 (push_display_prop): xassert that we are iterating a buffer.
9544 (push_it, pop_it): Save and restore paragraph_embedding member.
9545 (handle_single_display_spec, next_overlay_string)
9546 (get_overlay_strings_1, reseat_1, reseat_to_string)
9547 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9548 correctly. Don't assume unibyte strings are not bidi-reordered.
9549 (compute_display_string_pos)
9550 (compute_display_string_end): Fix handling the case of C string.
9551 (push_it, pop_it): Save and restore from_disp_prop_p.
9552 (handle_single_display_spec, push_display_prop): Set the
9553 from_disp_prop_p flag.
9554 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9555 (pop_it): Call iterate_out_of_display_property only if we are
9556 popping after iteration over a string that came from a display
9557 property. Fix a typo in popping stretch info. Add an assertion
9558 for verifying that the iterator position is in sync with the bidi
9559 iterator.
9560 (handle_single_display_spec, get_overlay_strings_1)
9561 (push_display_prop): Fix initialization of paragraph direction for
9562 string when that of the parent object is not yet determined.
9563 (reseat_1): Call bidi_init_it to resync the bidi
9564 iterator with IT's position. (Bug#7616)
9565 (find_row_edges): If ROW->start.pos gives position
9566 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9567 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9568 Reset the from_disp_prop_p flag.
9569 (SAVE_IT, RESTORE_IT): New macros.
9570 (pos_visible_p, face_before_or_after_it_pos)
9571 (back_to_previous_visible_line_start)
9572 (move_it_in_display_line_to, move_it_in_display_line)
9573 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9574 (try_scrolling, redisplay_window, display_line): Use them when
9575 saving a temporary copy of the iterator and restoring it back.
9576 (back_to_previous_visible_line_start, reseat_1)
9577 (init_iterator): Empty the bidi cache "stack".
9578 (move_it_in_display_line_to): If iterator ended up at
9579 EOL, but we never saw any buffer positions smaller than
9580 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9581 motion in bidi-reordered lines.
9582 (move_it_in_display_line_to): Record prev_method and prev_pos
9583 immediately before the call to set_iterator_to_next. Fixes cursor
9584 motion in bidi-reordered lines with stretch glyphs and strings
9585 displayed in margins. (Bug#8133) (Bug#8867)
9586 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9587 TO_CHARPOS.
640c8776
SM
9588 (pos_visible_p): Support positions in bidi-reordered lines.
9589 Save and restore bidi cache.
0bb23927
EZ
9590
9591 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9592 (bidi_paragraph_info): Delete unused struct.
9593 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9594 (bidi_cache_start): New variable.
9595 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9596 to zero.
9597 (bidi_cache_fetch_state, bidi_cache_search)
9598 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9599 (bidi_cache_find, bidi_peek_at_next_level)
9600 (bidi_level_of_next_char, bidi_find_other_level_edge)
9601 (bidi_move_to_visually_next): Compare cache index with
9602 bidi_cache_start rather than with zero.
9603 (bidi_fetch_char): Accept new argument STRING; all callers
9604 changed. Support iteration over a string. Support strings with
9605 display properties. Support unibyte strings. Fix the type of
9606 `len' according to what STRING_CHAR_AND_LENGTH expects.
9607 (bidi_paragraph_init, bidi_resolve_explicit_1)
9608 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9609 (bidi_level_of_next_char, bidi_move_to_visually_next):
9610 Support iteration over a string.
0bb23927
EZ
9611 (bidi_set_sor_type, bidi_resolve_explicit_1)
9612 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9613 can now be zero (for strings); special values 0 and -1 were
9614 changed to -1 and -2, respectively.
9615 (bidi_char_at_pos): New function.
9616 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9617 Call it instead of FETCH_MULTIBYTE_CHAR.
9618 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9619 initialized to valid values.
9620 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9621 values.
9622 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9623 the test for valid cached positions. Fix the logic for looking up
9624 the sentinel state in the cache. GCPRO the Lisp string we are
9625 iterating.
9626 (bidi_push_it, bidi_pop_it): New functions.
9627 (bidi_initialize): Initialize the bidi cache start stack pointer.
9628 (bidi_cache_ensure_space): New function, refactored from part of
9629 bidi_cache_iterator_state. Don't assume the required size is just
9630 one BIDI_CACHE_CHUNK away.
9631 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9632 (bidi_count_bytes, bidi_char_at_pos): New functions.
9633 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9634 always valid if bidi_cache_idx is valid.
9635 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9636 is valid if it's going to be used.
9637 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9638 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9639 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9640 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9641 (bidi_find_other_level_edge, bidi_cache_start_stack):
9642 All variables related to cache indices are now EMACS_INT.
c965adc5 9643
0bb23927
EZ
9644 * dispextern.h (struct bidi_string_data): New structure.
9645 (struct bidi_it): New member `string'. Make flag members be 1-bit
9646 fields, and put them last in the struct.
640c8776
SM
9647 (compute_display_string_pos, compute_display_string_end):
9648 Update prototypes.
0bb23927
EZ
9649 (bidi_push_it, bidi_pop_it): Add prototypes.
9650 (struct iterator_stack_entry): New members bidi_p,
9651 paragraph_embedding, and from_disp_prop_p.
9652 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9653 (bidi_shelve_cache, bidi_unshelve_cache):
9654 Declare prototypes.
0bb23927
EZ
9655
9656 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9657 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9658 and vector-like objects.
9659
9660 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9661 cache around display iteration.
9662
9663 * window.c (Fwindow_end, window_scroll_pixel_based)
9664 (displayed_window_lines, Frecenter): Save and restore the bidi
9665 cache around display iteration.
9666
3bbd2265
LMI
96672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9668
9669 * editfns.c (Fdelete_region): Clarify the use of the named
9670 parameters (bug#6788).
9671
adc47434
MR
96722011-07-14 Martin Rudalics <rudalics@gmx.at>
9673
9674 * indent.c (Fvertical_motion): Set and restore w->pointm when
9675 saving and restoring the window's buffer (Bug#9006).
9676
837c31f8
LMI
96772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9678
9679 * editfns.c (Fstring_to_char): Clarify just what is returned
9680 (bug#6576). Text by Eli Zaretskii.
9681
ac389d0c
JB
96822011-07-13 Juanma Barranquero <lekktu@gmail.com>
9683
9684 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9685
0be0ce47
EZ
96862011-07-13 Eli Zaretskii <eliz@gnu.org>
9687
9688 * buffer.c (mmap_find): Fix a typo.
9689
cd18e7e3
JB
96902011-07-13 Johan Bockgård <bojohan@gnu.org>
9691
9692 Fix execution of x selection hooks.
9693 * xselect.c (Qx_lost_selection_functions)
9694 (Qx_sent_selection_functions): New vars.
9695 (syms_of_xselect): DEFSYM them.
9696 (x_handle_selection_request): Pass Qx_sent_selection_functions
9697 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9698 (x_handle_selection_clear,x_clear_frame_selections):
9699 Pass Qx_lost_selection_functions rather than
9700 Vx_lost_selection_functions to Frun_hook_with_args.
9701
47ea7f44
PE
97022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9703
ac389d0c 9704 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9705 The old code sometimes used this field without initializing it.
9706
47ea7f44
PE
9707 * alloc.c (gc_sweep): Don't read past end of array.
9708 In theory, the old code could also have corrupted Emacs internals,
9709 though it'd be very unlikely.
9710
bc985c87
AS
97112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9712
9713 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9714 argument. (Bug#4026)
bc985c87 9715
0cf34688
LMI
97162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9717
b3dadd76
LMI
9718 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9719 key" (bug#4257).
9720
0cf34688
LMI
9721 * window.c (Fset_window_start): Doc fix (bug#4199).
9722 (Fset_window_hscroll): Ditto.
9723
270768cd
PE
97242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9725
077e3dda 9726 Fix minor new problems caught by GCC 4.6.1.
270768cd 9727 * term.c (init_tty): Remove unused local.
490011a6 9728 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9729 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9730 not used otherwise.
270768cd 9731
b1f58454
CY
97322011-07-12 Chong Yidong <cyd@stupidchicken.com>
9733
9734 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9735
22b9578d
LMI
97362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9737
6e70ab07
LMI
9738 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9739 are the mini-buffer and the echo area (bug#3320).
9740
22b9578d
LMI
9741 * term.c (init_tty): Remove support for supdup, c10 and perq
9742 terminals, which are no longer supported (bug#1482).
9743
8974cc9f
JB
97442011-07-10 Johan Bockgård <bojohan@gnu.org>
9745
9746 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9747
a560d974
JD
97482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9749
9750 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9751 for non-popups (Bug#3642).
9752
1dae0f0a
AS
97532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9754
268c2c36 9755 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9756 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9757 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9758 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9759 * data.c (fmod): Likewise.
9760 * dispnew.c (swap_glyphs_in_rows): Likewise.
9761 * emacs.c (memory_warning_signal): Likewise.
9762 * floatfns.c (float_error): Likewise.
9763 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9764 (otf_open, font_otf_capability, generate_otf_features)
9765 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9766 Likewise.
9767 * image.c (pbm_read_file): Likewise.
9768 * indent.c (string_display_width): Likewise.
9769 * intervals.c (check_for_interval, search_for_interval)
9770 (inc_interval_count, count_intervals, root_interval)
9771 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9772 * lread.c (defalias): Likewise.
268c2c36 9773 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9774 * regex.c (set_image_of_range_1, set_image_of_range)
9775 (regex_grow_registers): Likewise.
9776 * sysdep.c (strerror): Likewise.
9777 * termcap.c (valid_filename_p, tprint, main): Likewise.
9778 * tparam.c (main): Likewise.
9779 * unexhp9k800.c (run_time_remap, save_data_space)
9780 (update_file_ptrs, read_header, write_header, calculate_checksum)
9781 (copy_file, copy_rest, display_header): Likewise.
9782 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9783 Likewise.
9784 * xdisp.c (check_it): Likewise.
9785 * xfaces.c (register_color, unregister_color, unregister_colors):
9786 Likewise.
9787 * xfns.c (print_fontset_result): Likewise.
9788 * xrdb.c (member, fatal, main): Likewise.
9789
99033785
PE
97902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9791
9792 Fix minor problems found by static checking (Bug#9031).
9793 * chartab.c (char_table_set_range, map_sub_char_table):
9794 Remove unused locals.
9795 (uniprop_table): Now static.
9796 * composite.c (_work_char): Remove unused static var.
9797
9cb2ac56
JB
97982011-07-09 Juanma Barranquero <lekktu@gmail.com>
9799
9800 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9801
f25661f0
JD
98022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9803
9804 * gtkutil.c (qttip_cb): Remove code without function.
9805
8278c4fe
EZ
98062011-07-09 Eli Zaretskii <eliz@gnu.org>
9807
9808 * w32.c (pthread_sigmask): New stub.
9809
1692ae2d 98102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9811
8a6ebd58 9812 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9813 sigprocmask is portable only for single-threaded applications, and
9814 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9815 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9816 (LIBES): Use it.
9817 * callproc.c (Fcall_process):
9818 * process.c (create_process):
9819 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9820 Use pthread_sigmask, not sigprocmask.
123403e4 9821
1b854618
JD
98222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9823
9824 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9825 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9826 wrong (Bug#8591).
9827
3fe4b549
JD
98282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9829
0ce7e563
JD
9830 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9831 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9832 (xg_hide_tooltip): Fix comment.
9833
3fe4b549
JD
9834 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9835 in registerServicesMenuSendTypes.
9836 (validRequestorForSendType): Don't check ns_return_types.
9837
9838 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9839 ns_return_type.
9840
5df75e47
JR
98412011-07-08 Jason Rumney <jasonr@gnu.org>
9842
22610910
JR
9843 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9844 SH_SHOW for hidden windows (Bug#5482).
9845
5df75e47
JR
9846 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9847 frame struct members of non-existent frames (Bug#6284).
9848
699c10bd
JD
98492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9850
4393663b
JD
9851 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9852 variable firstTime not needed on OSX >= 10.6.
9853 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9854 >= 10.5. Use setKnobProportion, setDoubleValue.
9855
9856 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9857 (MAC_OS_X_VERSION_10_5): Define if not defined.
9858 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9859 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9860 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9861
9862 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9863 cString and lossyCString on OSX >= 10.4.
4393663b 9864
58179cce 9865 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9866 sizeToFit on OSX >= 10.2.
9867
9868 * nsimage.m (allocInitFromFile): Don't use deprecated method
9869 bestRepresentationForDevice on OSX >= 10.6.
9870
9871 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9872 to avoid warning.
9873
9874 * emacs.c: Declare unexec_init_emacs_zone.
9875
a63e0781
JD
9876 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9877
699c10bd
JD
9878 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9879
9880 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9881 on svcsMenu (Bug#8842).
9882
9883 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9884 ns_return_types.
9885 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9886
9887 * nsterm.m (QUTF8_STRING): Declare.
9888 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9889 (validRequestorForSendType): Return type is (id).
9890 Change indexOfObjectIdenticalTo to indexOfObject.
9891 Check if we have local selection before returning self (Bug#8842).
9892 (writeSelectionToPasteboard): Put local selection into paste board
9893 if we have a local selection (Bug#8842).
9894 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9895
9896 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9897 (ns_get_local_selection): Declare.
9898
54e10184
LMI
98992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9900
9888ff71
LMI
9901 * keymap.c (describe_map_tree): Don't insert a double newline at
9902 the end of the buffer (bug#1169) and return whether we inserted
9903 something.
9904
54e10184
LMI
9905 * callint.c (Fcall_interactively): Change "reading args" to
9906 "providing args" to try to clarify what it does (bug#1010).
9907
15fa4783
KH
99082011-07-07 Kenichi Handa <handa@m17n.org>
9909
9910 * composite.c (composition_compute_stop_pos): Ignore a static
9911 composition starting before CHARPOS (Bug#8915).
9912
9913 * xdisp.c (handle_composition_prop): Likewise.
9914
a8815b00
EZ
99152011-07-07 Eli Zaretskii <eliz@gnu.org>
9916
9917 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9918 (Bug#9015)
9919
ef7b981d 99202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9921
9922 * character.h (unicode_category_t): New enum type.
9923
9924 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9925 (Qchar_code_property_table): New variable.
9926 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9927 (UNIPROP_COMPRESSED_FORM_P): New macros.
9928 (char_table_ascii): Uncompress the compressed values.
9929 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9930 Uncompress the compressed values.
ac389d0c 9931 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9932 (char_table_ref_and_range): Uncompress the compressed values.
9933 (sub_char_table_set): New arg is_uniprop. Callers changed.
9934 Uncompress the compressed values.
9935 (sub_char_table_set_range): Args changed. Callers changed.
9936 (char_table_set_range): Adjuted for the above change.
9937 (map_sub_char_table): Delete args default_val and parent. Add arg
9938 top. Give decoded values to a Lisp function.
640c8776 9939 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9940 values to a Lisp function. Gcpro more variables.
9941 (uniprop_table_uncompress)
9942 (uniprop_decode_value_run_length): New functions.
9943 (uniprop_decoder, uniprop_decoder_count): New variables.
9944 (uniprop_get_decoder, uniprop_encode_value_character)
9945 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9946 New functions.
9947 (uniprop_encoder, uniprop_encoder_count): New variables.
9948 (uniprop_get_encoder, uniprop_table)
9949 (Funicode_property_table_internal, Fget_unicode_property_internal)
9950 (Fput_unicode_property_internal): New functions.
9951 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9952 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9953 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9954 char-code-property-alist.
9955
640c8776 9956 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9957 Vunicode_category_table.
9958
640c8776 9959 * font.c (font_range): Adjust for the change of
c805dec0
KH
9960 Vunicode_category_table.
9961
76b397fb
DN
99622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9963
9964 * m/iris4d.h: Remove file, move contents ...
9965 * s/irix6-5.h: ... here.
9966
22b4128e
PE
99672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9968
9969 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9970 * alloc.c (mark_buffer):
9971 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9972 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9973 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9974 This isn't true in general, and it's particularly not true
9975 if Emacs is configured with --with-wide-int.
9976 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9977 New macros, used in the buffer.c change.
9978
869795d6
JD
99792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9980
9981 * xsettings.c: Use both GConf and GSettings if both are available.
9982 (store_config_changed_event): Add comment.
9983 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9984 (store_tool_bar_style_changed): New functions.
5e617bc2 9985 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9986 (struct xsettings): Move font inside HAVE_XFT.
9987 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9988 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9989 Move inside HAVE_XFT.
640c8776 9990 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9991 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9992 also.
9993 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9994 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9995 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9996 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9997 (parse_settings): Move check for font inside HAVE_XFT.
9998 (read_settings, apply_xft_settings): Add comment.
9999 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10000 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10001 call store_font_name_changed.
10002 (xft_settings_event): Add comment.
10003 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10004 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10005 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10006 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10007 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10008 (xsettings_get_system_font, xsettings_get_system_normal_font):
10009 Add comment.
869795d6 10010
d8ed26bd
PE
100112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10012
10013 Random fixes. E.g., (random) never returned negative values.
10014 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10015 subseconds part to the entropy, as that's a bit more random.
10016 Prefer signed to unsigned, since the signedness doesn't matter and
10017 in general we prefer signed. When given a limit, use a
10018 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10019 latter isn't right if USE_2_TAGS_FOR_INTS.
10020 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10021 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10022
cabf1cac
SM
100232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10024
10025 * textprop.c (text_property_stickiness):
10026 Obey Vtext_property_default_nonsticky.
10027 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10028 * w32fns.c (syms_of_w32fns):
10029 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10030
6e9b2be9
PE
100312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10032
10033 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10034 This is more efficient than Ffile_directory_p and avoids a minor race.
10035
90186c68
LMI
100362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10037
7c301272
LMI
10038 * buffer.c (Foverlay_put): Say what the return value is
10039 (bug#7835).
10040
c4f2d8d4
LMI
10041 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10042 is a directory before asking whether to use the file name
10043 (bug#7564).
ad637907
LMI
10044 (barf_or_query_if_file_exists): Make the "File is a directory"
10045 error be more correct.
c4f2d8d4 10046
90186c68
LMI
10047 * fns.c (Frequire): Remove the mention of the .gz files, since
10048 that's installation-specific, but keep the mention of
10049 `get-load-suffixes'.
10050
da64016e
PE
100512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10052
10053 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10054 Report string overflow if the output is too long.
10055
7d47b580
JB
100562011-07-04 Juanma Barranquero <lekktu@gmail.com>
10057
a555cb87
JB
10058 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10059 (syms_of_gnutls): Remove duplicate DEFSYM for
10060 Qgnutls_bootprop_verify_hostname_error, an error for
10061 Qgnutls_bootprop_verify_error (which is no longer used).
10062
7d47b580
JB
10063 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10064 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10065 Also (re)move comments that are misplaced or no longer relevant.
10066
1e49bfab
LMI
100672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10068
10069 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10070
1485f4c0
CY
100712011-07-03 Chong Yidong <cyd@stupidchicken.com>
10072
10073 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10074 and background color parameters if they have been changed.
10075
a9ab721e
LMI
100762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10077
10078 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10079
cf7cff57
PE
100802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10081
2e13213d
PE
10082 * xsettings.c (SYSTEM_FONT): Define only when used.
10083 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10084
cf7cff57
PE
10085 * keymap.c (access_keymap_1): Now static.
10086
7a8e04f7
CY
100872011-07-02 Chong Yidong <cyd@stupidchicken.com>
10088
10089 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10090 leave any prefix arg for the up event (Bug#1586).
10091
61352f62
LMI
100922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10093
69bb1ef7
LMI
10094 * lread.c (syms_of_lread): Mention single symbols defined by
10095 `defvar' or `defconst' (bug#7154).
10096
61352f62 10097 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10098 (Frequire): Mention get-load-suffixes.
61352f62 10099
28545e04
MR
101002011-07-02 Martin Rudalics <rudalics@gmx.at>
10101
10102 * window.h (window): Remove clone_number slot.
10103 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10104 Remove.
10105 (make_parent_window, make_window, saved_window)
10106 (Fset_window_configuration, save_window_save): Don't deal with
10107 clone numbers.
10108 * buffer.c (Qclone_number): Remove declaration.
10109 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10110
3349e122
SM
101112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10112
10113 Add multiple inheritance to keymaps.
10114 * keymap.c (Fmake_composed_keymap): New function.
10115 (Fset_keymap_parent): Simplify.
10116 (fix_submap_inheritance): Remove.
10117 (access_keymap_1): New function extracted from access_keymap to handle
10118 embedded parents and handle lists of maps.
10119 (access_keymap): Use it.
10120 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10121 (Fcopy_keymap): Handle embedded parents.
10122 (Fcommand_remapping, define_as_prefix): Simplify.
10123 (Fkey_binding): Simplify.
10124 (syms_of_keymap): Move minibuffer-local-completion-map,
10125 minibuffer-local-filename-completion-map,
10126 minibuffer-local-must-match-map, and
10127 minibuffer-local-filename-must-match-map to Elisp.
10128 (syms_of_keymap): Defsubr make-composed-keymap.
10129 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10130 (parse_menu_item): Trivial simplification.
10131
3279eb87
GM
101322011-07-01 Glenn Morris <rgm@gnu.org>
10133
10134 * Makefile.in (SETTINGS_LIBS): Fix typo.
10135
39cb9e56 101362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10137
10138 * coding.c (Fencode_coding_string): Record the last coding system
10139 used, as the function doc string says (bug#8738).
10140
0949d2b6
JD
101412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10142
10143 * xsettings.c (store_monospaced_changed): Take new font as arg and
10144 check for change against current_mono_font.
10145 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10146 (emacs_settings_constructor, emacs_settings_get_property)
10147 (emacs_settings_set_property, emacs_settings_class_init)
10148 (emacs_settings_init, gsettings_obj): Remove.
10149 (something_changedCB): New function for HAVE_GSETTINGS.
10150 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10151 with value as argument.
10152 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10153 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10154 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10155 "changed".
10156
10157 * xgselect.c: Add defined (HAVE_GSETTINGS).
10158 (xgselect_initialize): Ditto.
10159
10160 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10161 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10162 xg_select.
10163
bbc6b304
PE
101642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10165
10166 * eval.c (struct backtrace): Simplify and port the data structure.
10167 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10168 signed bit field, as this assumption is not portable and it makes
10169 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10170 "char debug_on_exit : 1" as this is not portable either; instead,
10171 use the portable "unsigned int debug_on_exit : 1". Remove unused
10172 member evalargs. Remove obsolete comments about cc bombing out.
10173
9851bfc5
JD
101742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10175
51bb811f 10176 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10177 Let HAVE_GSETTINGS override HAVE_GCONF.
10178 (store_monospaced_changed): New function.
10179 (EMACS_SETTINGS): A new type derived from GObject to handle
10180 GSettings notifications.
10181 (emacs_settings_constructor, emacs_settings_get_property)
10182 (emacs_settings_set_property, emacs_settings_class_init):
10183 New functions.
10184 (gsettings_client, gsettings_obj): New variables.
10185 (GSETTINGS_SCHEMA): New define.
10186 (something_changedCB): Call store_monospaced_changed.
10187 (init_gsettings): New function.
10188 (xsettings_initialize): Call init_gsettings.
10189 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10190 to NULL.
10191
640c8776 10192 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10193 GCONF_CFLAGS/LIBS.
10194
5386012d
MR
101952011-06-29 Martin Rudalics <rudalics@gmx.at>
10196
10197 * window.c (resize_root_window, grow_mini_window)
10198 (shrink_mini_window): Rename Qresize_root_window to
10199 Qwindow_resize_root_window and Qresize_root_window_vertically to
10200 Qwindow_resize_root_window_vertically.
10201
f13e0b08
PE
102022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10203
10204 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10205
94515237
JB
102062011-06-27 Juanma Barranquero <lekktu@gmail.com>
10207
10208 * makefile.w32-in: Redesign dependencies so they reflect more
10209 clearly which files are directly included by each source file,
10210 and not through other includes.
10211
e43b6e43
MR
102122011-06-27 Martin Rudalics <rudalics@gmx.at>
10213
10214 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10215 (sort_overlays, overlay_strings): When an overlay's clone number
10216 matches the window's clone number process the overlay even if
10217 the overlay's window property doesn't match the current window.
10218
d68443dc
MR
10219 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10220 (Fwindow_hchild): Rename to Fwindow_left_child.
10221 (Fwindow_next): Rename to Fwindow_next_sibling.
10222 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10223 (resize_window_check): Rename to window_resize_check.
10224 (resize_window_apply): Rename to window_resize_apply.
10225 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10226 (Fdelete_other_windows_internal, resize_frame_windows)
10227 (Fsplit_window_internal, Fdelete_window_internal)
10228 (grow_mini_window, shrink_mini_window)
10229 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10230
c7e73be5
JD
102312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10232
10233 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10234 (emacs_fixed_set_min_size): Remove.
10235 (emacs_fixed_new): Take frame as argument.
10236
10237 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10238 (_EmacsFixedPrivate): Remove minwidth/height.
10239 Add struct frame *f.
10240 (emacs_fixed_init): Initialize priv->f.
10241 (get_parent_class, emacs_fixed_set_min_size): Remove.
10242 (emacs_fixed_new): Set priv->f to argument.
10243 (emacs_fixed_get_preferred_width)
10244 (emacs_fixed_get_preferred_height): Use min_width/height from
10245 frames size_hint to set minimum and natural (Bug#8919).
10246 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10247 and use min_width/height from frames size_hint to set
10248 min_width/height (Bug#8919).
10249
10250 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10251 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10252 Fix indentation.
c7e73be5 10253
cf99dcf8
EZ
102542011-06-26 Eli Zaretskii <eliz@gnu.org>
10255
10256 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10257 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10258 called at ZV.
10259
029529ac
CY
102602011-06-26 Chong Yidong <cyd@stupidchicken.com>
10261
10262 * process.c (wait_reading_process_output): Bypass select if
10263 waiting for a cell while ignoring keyboard input, and input is
10264 pending. Suggested by Jan Djärv (Bug#8869).
10265
7a7ef429
PE
102662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10267
10268 Use gnulib's dup2 module instead of rolling our own.
10269 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10270
11fdef7d 102712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10272
10273 * dispnew.c (scrolling_window): Before scrolling, turn off a
10274 mouse-highlight in the window being scrolled.
10275
cd3520a4
JB
102762011-06-24 Juanma Barranquero <lekktu@gmail.com>
10277
10278 Move DEFSYM to lisp.h and use everywhere.
10279
10280 * character.h (DEFSYM): Move declaration...
10281 * lisp.h (DEFSYM): ...here.
10282
10283 * gnutls.c:
10284 * minibuf.c:
10285 * w32menu.c:
10286 * w32proc.c:
10287 * w32select.c: Don't include character.h.
10288
10289 * alloc.c (syms_of_alloc):
10290 * buffer.c (syms_of_buffer):
10291 * bytecode.c (syms_of_bytecode):
10292 * callint.c (syms_of_callint):
10293 * casefiddle.c (syms_of_casefiddle):
10294 * casetab.c (init_casetab_once):
10295 * category.c (init_category_once, syms_of_category):
10296 * ccl.c (syms_of_ccl):
10297 * cmds.c (syms_of_cmds):
10298 * composite.c (syms_of_composite):
10299 * dbusbind.c (syms_of_dbusbind):
10300 * dired.c (syms_of_dired):
10301 * dispnew.c (syms_of_display):
10302 * doc.c (syms_of_doc):
10303 * editfns.c (syms_of_editfns):
10304 * emacs.c (syms_of_emacs):
10305 * eval.c (syms_of_eval):
10306 * fileio.c (syms_of_fileio):
10307 * fns.c (syms_of_fns):
10308 * frame.c (syms_of_frame):
10309 * fringe.c (syms_of_fringe):
10310 * insdel.c (syms_of_insdel):
10311 * keymap.c (syms_of_keymap):
10312 * lread.c (init_obarray, syms_of_lread):
10313 * macros.c (syms_of_macros):
10314 * msdos.c (syms_of_msdos):
10315 * print.c (syms_of_print):
10316 * process.c (syms_of_process):
10317 * search.c (syms_of_search):
10318 * sound.c (syms_of_sound):
10319 * syntax.c (init_syntax_once, syms_of_syntax):
10320 * terminal.c (syms_of_terminal):
10321 * textprop.c (syms_of_textprop):
10322 * undo.c (syms_of_undo):
10323 * w32.c (globals_of_w32):
10324 * window.c (syms_of_window):
10325 * xdisp.c (syms_of_xdisp):
10326 * xfaces.c (syms_of_xfaces):
10327 * xfns.c (syms_of_xfns):
10328 * xmenu.c (syms_of_xmenu):
10329 * xsettings.c (syms_of_xsettings):
10330 * xterm.c (syms_of_xterm): Use DEFSYM.
10331
4228cf16
TZ
103322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10333
cd3520a4 10334 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10335
7fcccf1e
PE
103362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10337
7efb4e0e
PE
10338 Integer and buffer overflow fixes (Bug#8873).
10339
ff5844ad
PE
10340 * print.c (printchar, strout): Check for string overflow.
10341 (PRINTPREPARE, printchar, strout):
10342 Don't set size unless allocation succeeds.
10343
90532f02
PE
10344 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10345 for sizes. Check for string overflow more accurately.
10346 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10347
6d84508d
PE
10348 * macros.c: Integer and buffer overflow fixes.
10349 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10350 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10351 Use ptrdiff_t, not int, for sizes.
10352 Don't increment bufsize until after realloc succeeds.
10353 Check for size-calculation overflow.
10354 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10355
437b2cb4
PE
10356 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10357
8b9ac8b4
PE
10358 * lread.c: Integer overflow fixes.
10359 (read_integer): Radix is now EMACS_INT, not int,
10360 to improve quality of diagnostics for out-of-range radices.
10361 Calculate buffer size correctly for out-of-range radices.
10362 (read1): Check for integer overflow in radices, and in
10363 read-circle numbers.
82cb60d3
PE
10364 (read_escape): Avoid int overflow.
10365 (Fload, openp, read_buffer_size, read1)
10366 (substitute_object_recurse, read_vector, read_list, map_obarray):
10367 Use ptrdiff_t, not int, for sizes.
10368 (read1): Use EMACS_INT, not int, for sizes.
20270765 10369 Check for size overflow.
8b9ac8b4 10370
7fcccf1e
PE
10371 * image.c (cache_image): Check for size arithmetic overflow.
10372
bfbbd7e7
PE
10373 * lread.c: Integer overflow issues.
10374 (saved_doc_string_size, saved_doc_string_length)
10375 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10376 Now ptrdiff_t, not int.
10377 (read1): Don't assume doc string length fits in int. Check for
10378 out-of-range doc string lengths.
10379 (read_list): Don't assume file position fits in int.
39019e54 10380 (read_escape): Check for hex character overflow.
bfbbd7e7 10381
4e323265
LL
103822011-06-22 Leo Liu <sdl.web@gmail.com>
10383
10384 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10385 Move to minibuffer.el.
10386
85fece3e
PE
103872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10388
20b84ce9 10389 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10390 The following patches are for when GLYPH_DEBUG && !XASSERT.
10391 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10392 * dispnew.c (flush_stdout):
10393 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10394 Mark as externally visible.
10395 * dispnew.c (check_window_matrix_pointers): Now static.
10396 * dispnew.c (window_to_frame_vpos):
10397 * xfns.c (unwind_create_frame):
10398 * xterm.c (x_check_font): Remove unused local.
10399 * scroll.c (CHECK_BOUNDS):
10400 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10401 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10402 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10403 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10404 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10405 Now static.
10406 (debug_method_add): Use va_list and vsprintf rather than relying
10407 on undefined behavior with wrong number of arguments.
10408 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10409 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10410 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10411 since we're not interested in debugging glyphs with old libraries.
10412 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10413 GCC 4.6.0's static checking.
10414
0766b489
PE
104152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10416
31fd4b32
PE
10417 Integer overflow and signedness fixes (Bug#8873).
10418 A few related buffer overrun fixes, too.
10419
b79e8648
PE
10420 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10421
0766b489
PE
10422 * dispextern.h (struct face.stipple):
10423 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10424 (x_bitmap_mask, x_allocate_bitmap_record)
10425 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10426 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10427 (x_create_bitmap_from_xpm_data):
10428 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10429 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10430 (.bitmaps_last):
10431 * xfaces.c (load_pixmap):
10432 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10433 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10434 (.bitmaps_last, struct x_output.icon_bitmap):
10435 Use ptrdiff_t, not int, for bitmap indexes.
10436 (x_allocate_bitmap_record): Check for size overflow.
10437 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10438
b081724f
PE
10439 Use ptrdiff_t, not int, for overlay counts.
10440 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10441 * editfns.c (overlays_around, get_pos_property):
10442 * textprop.c (get_char_property_and_overlay):
10443 * xdisp.c (next_overlay_change, note_mouse_highlight):
10444 * xfaces.c (face_at_buffer_position):
21514da7
PE
10445 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10446 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10447 (Fnext_overlay_change, Fprevious_overlay_change)
10448 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10449 Use ptrdiff_t, not int, for sizes.
21514da7 10450 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10451
3de73e5e
PE
10452 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10453
2606c57b
PE
10454 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10455 (x_session_initialize): Do not assume string length fits in int.
10456
aaafe47a
PE
10457 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10458 This is unlikely, but can occur if DPI is outlandish.
10459
2674ddc8 10460 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10461 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10462
28154962
PE
10463 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10464 * xrdb.c (magic_file_p, search_magic_path):
10465 Omit last arg SUFFIX; it was always 0. All callers changed.
10466 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10467
7de51af5
PE
10468 * xfont.c (xfont_match): Avoid need for strlen.
10469
25ed6cc3
PE
10470 * xfns.c: Don't assume strlen fits in int.
10471 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10472
4eab31dd
PE
10473 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10474 not unsigned long, as we prefer signed integers. All callers changed.
10475 Detect integer overflow in repeat count.
10476 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10477 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10478
171e2a58
PE
10479 * termcap.c: Don't assume sizes fit in int and never overflow.
10480 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10481 (gobble_line): Check for size-calculation overflow.
10482
ad39faca 10483 * minibuf.c (Fread_buffer):
6e5bb2dc 10484 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10485 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10486 Don't assume string length fits in int.
10487
52c61c22 10488 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10489 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10490
b5b8c9e5
PE
10491 * font.c: Don't assume string length fits in int.
10492 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10493 Use ptrdiff_t, not int.
ccd6111c
PE
10494 (font_intern_prop): Don't assume string length fits in int.
10495 Don't assume integer property fits in fixnum.
10496 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10497
882f0d81 10498 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10499 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10500 Reformulate so as not to need the command string.
10501 Invoke gzip -cd rather than gunzip, as it's more portable.
10502 (lock_info_type, lock_file_1, lock_file):
10503 Don't assume pid_t and time_t fit in unsigned long.
10504 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10505 (current_lock_owner): Prefer signed type for sizes.
10506 Use memcpy, not strncpy, where memcpy is what is really wanted.
10507 Don't assume (via atoi) that time_t and pid_t fit in int.
10508 Check for time_t and/or pid_t out of range, e.g., via a network share.
10509 Don't alloca where an auto var works fine.
10510
93f4cf88
PE
10511 * fileio.c: Fix some integer overflow issues.
10512 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10513 Don't assume string length fits in int.
10514 (directory_file_name): Don't assume string length fits in long.
10515 (make_temp_name): Don't assume pid fits in int, or that its print
10516 length is less than 20.
10517
f3e92b69
PE
10518 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10519
1bfdaf10
PE
10520 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10521
35016e9a
PE
10522 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10523
3d1e65a1
PE
10524 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10525 We prefer signed integers, even for size calculations.
10526
0b963a93
PE
10527 * emacs.c: Don't assume string length fits in 'int'.
10528 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10529 (main): Don't invoke strlen when not needed.
10530
573f4b54
PE
10531 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10532 (XD_DEBUG_MESSAGE): Don't waste a byte.
10533
989f33ba
PE
10534 * callproc.c (getenv_internal_1, getenv_internal)
10535 (Fgetenv_internal):
965d34eb
PE
10536 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10537
e4d29b33
PE
10538 * lread.c (invalid_syntax): Omit length argument.
10539 All uses changed. This doesn't fix a bug, but it simplifies the
10540 code away from its former Hollerith-constant appearance, and it's
10541 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10542 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10543
eb49b136
PE
10544 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10545 This didn't break anything, but it didn't help either.
10546 It's confusing to put a bogus integer in a place where the actual
10547 value does not matter.
9f62aeb1 10548 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10549 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10550
15375a22
PE
10551 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10552 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10553 implementation.
b61cc01c
PE
10554 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10555 We prefer signed types, and the value cannot exceed the EMACS_INT
10556 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10557 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10558 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10559 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10560
53b2623d
PE
10561 * indent.c (sane_tab_width): New function.
10562 (current_column, scan_for_column, Findent_to, position_indentation)
10563 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10564 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10565
51cab52b 10566 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10567
f2ed8a70
PE
10568 * lisp.h (lint_assume): New macro.
10569 * composite.c (composition_gstring_put_cache):
10570 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10571
abe80cc6
PE
10572 * editfns.c, insdel.c:
10573 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10574
b02c740e
PE
10575 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10576
ebc96716
PE
10577 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10578
b4e50fa0 10579 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10580 Use much-faster test for byte-length change.
311d5d7c 10581 Don't assume string byte-length fits in 'int'.
a4cf38e4 10582 Check that character arg fits in 'int'.
85461888 10583 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10584
c0c1ee9f
PE
10585 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10586
a498d7f4
PE
10587 * fns.c (concat): Catch string overflow earlier.
10588 Do not rely on integer wraparound.
10589
51cab52b
PE
10590 * dispextern.h (struct it.overlay_strings_charpos)
10591 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10592 * xdisp.c (forward_to_next_line_start)
10593 (back_to_previous_visible_line_start)
10594 (reseat_at_next_visible_line_start, next_element_from_buffer):
10595 Don't arbitrarily truncate the value of 'selective' to int.
10596
76031fad
PE
10597 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10598
5eb55db9
PE
10599 * composite.c: Don't truncate sizes to 'int'.
10600 (composition_gstring_p, composition_reseat_it)
10601 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10602 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10603 not EMACS_UINT, for indexes.
5eb55db9 10604
0703a717
PE
10605 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10606
d6202519
PE
10607 * buffer.c: Include <verify.h>.
10608 (struct sortvec.priority, struct sortstr.priority):
8961a454 10609 Now EMACS_INT, not int.
c20998a7 10610 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10611 (struct sortstr.size, record_overlay_string)
10612 (struct sortstrlist.size, struct sortlist.used):
10613 Don't truncate size to int.
10614 (record_overlay_string): Check for size-calculation overflow.
d6202519 10615 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10616
d5a19415
JM
106172011-06-22 Jim Meyering <meyering@redhat.com>
10618
029529ac 10619 Don't leak an XBM-image-sized buffer
d5a19415
JM
10620 * image.c (xbm_load): Free the image buffer after using it.
10621
a9041e6c
PE
106222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10623
10624 Port to Sun C.
10625 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10626 that Sun C diagnosed.
10627 * fns.c (secure_hash): Fix pointer signedness issue.
10628 * intervals.c (static_offset_intervals): New function.
10629 (offset_intervals): Use it.
10630
7f3f739f
LL
106312011-06-21 Leo Liu <sdl.web@gmail.com>
10632
10633 * deps.mk (fns.o):
10634 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10635 sha512.h.
10636
10637 * fns.c (secure_hash): Rename from crypto_hash_function and change
10638 the first arg to accept symbols.
5b66d427 10639 (Fsecure_hash): New primitive.
7f3f739f
LL
10640 (syms_of_fns): New symbols.
10641
76147d94
DD
106422011-06-20 Deniz Dogan <deniz@dogan.se>
10643
10644 * process.c (Fset_process_buffer): Clarify return value in
10645 docstring.
10646
7d7d0045
CY
106472011-06-18 Chong Yidong <cyd@stupidchicken.com>
10648
10649 * dispnew.c (add_window_display_history): Use BVAR.
10650
10651 * xdisp.c (debug_method_add): Use BVAR.
10652 (check_window_end, dump_glyph_matrix, dump_glyph)
10653 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10654
10655 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10656 Likewise.
10657
10658 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10659 check till after the cache is created in init_frame_faces.
10660
ff2bc410
SM
106612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10662
10663 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10664
28177add
PE
106652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10666
dd3482fe
PE
10667 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10668 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10669 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10670
393d71f3 10671 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10672 * fileio.c (Finsert_file_contents):
10673 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10674 Remove the old (too-loose) buffer overflow checks.
10675 They weren't needed, since make_gap checks for buffer overflow.
10676 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10677 The old code merely checked for Emacs fixnum overflow, and relied
10678 on undefined (wraparound) behavior. The new code avoids undefined
10679 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10680
2e6813b0 10681 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10682 Tune. Don't use wider integers than needed. Don't use alloca.
10683 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10684
599a9e4f
PE
10685 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10686
99561444
PE
10687 * insdel.c, lisp.h (buffer_overflow): New function.
10688 (insert_from_buffer_1, replace_range, replace_range_2):
10689 * insdel.c (make_gap_larger):
10690 * editfns.c (Finsert_char):
10691 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10692
28177add
PE
10693 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10694
e69dafad
PE
106952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10696
4baa020d 10697 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10698
b1c46f02
PE
10699 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10700 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10701
e69dafad
PE
10702 * fileio.c: Don't assume EMACS_INT fits in off_t.
10703 (emacs_lseek): New static function.
10704 (Finsert_file_contents, Fwrite_region): Use it.
10705 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10706
566684ea
PE
10707 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10708
e6966cd6
PE
10709 * fns.c: Don't overflow int when computing a list length.
10710 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10711 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10712 truncation on 64-bit hosts. Check for QUIT every
10713 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10714 faster and is responsive enough.
10715 (Flength): Report an error instead of overflowing an integer.
10716 (Fsafe_length): Return a float if the value is not representable
10717 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10718 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10719 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10720
dd0b0efb
PE
10721 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10722 (header_size, word_size): New constants.
10723 (allocate_vectorlike): Don't check size overflow here.
10724 (allocate_vector): Check it here instead, since this is the only
10725 caller of allocate_vectorlike that could cause overflow.
10726 Check that the new vector's length is representable as a fixnum.
10727
86fe5cfe
PE
10728 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10729 The previous code was bogus. For example, next_almost_prime (32)
10730 returned 39, which is undesirable as it is a multiple of 3; and
10731 next_almost_prime (24) returned 25, which is a multiple of 5 so
10732 why was the code bothering to check for multiples of 7?
10733
80e88859
PE
10734 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10735
4a2f0ad6
PE
10736 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10737
f66c7cf8
PE
10738 Variadic C functions now count arguments with ptrdiff_t.
10739 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10740 Back then I didn't know that the Emacs coding style prefers signed int.
10741 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10742 were being counted with int, which may truncate counts on 64-bit
10743 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10744 * lisp.h (struct Lisp_Subr.function.aMANY)
10745 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10746 Arg counts are now ptrdiff_t, not size_t.
10747 All variadic functions and their callers changed accordingly.
10748 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10749 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10750 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10751 * callint.c (Fcall_interactively): Check arg count for overflow,
10752 to avoid potential buffer overrun. Use signed char, not 'int',
10753 for 'varies' array, so that we needn't bother to check its size
10754 calculation for overflow.
10755 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10756 * eval.c (apply_lambda):
10757 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10758 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10759 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10760
a1759b76
PE
10761 * callint.c (Fcall_interactively): Don't use index var as event count.
10762
d96be9fc
PE
10763 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10764 * mem-limits.h (SIZE): Remove; no longer used.
10765
a690a978 10766 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10767
578c21e6
PE
10768 Remove unnecessary casts.
10769 * xterm.c (x_term_init):
10770 * xfns.c (x_set_border_pixel):
10771 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10772 These aren't needed now that we assume ANSI C.
10773
96f53c6c
PE
10774 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10775 It's more likely to cause problems (due to unsigned overflow)
10776 than to cure them.
10777
83c77d31
PE
10778 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10779
ee2079f1
PE
10780 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10781
6da65536
PE
10782 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10783
7147c4a4
PE
10784 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10785
193e32d9
PE
10786 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10787
e5533da6
PE
10788 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10789
9910e595
PE
10790 GLYPH_CODE_FACE returns EMACS_INT, not int.
10791 * dispextern.h (merge_faces):
10792 * xfaces.c (merge_faces):
01103c44
PE
10793 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10794 Don't assume EMACS_INT fits in int.
9910e595 10795
2638320e
PE
10796 * character.h (CHAR_VALID_P): Remove unused parameter.
10797 * fontset.c, lisp.h, xdisp.c: All uses changed.
10798
045eb8d9
PE
10799 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10800
c1f134b5
PE
10801 * fns.c (concat): Minor tuning based on overflow analysis.
10802 This doesn't fix any bugs. Use int to hold character, instead
10803 of constantly refetching from Emacs object. Use XFASTINT, not
10804 XINT, for value known to be a character. Don't bother comparing
10805 a single byte to 0400, as it's always less.
10806
395fcb93 10807 * floatfns.c (Fexpt):
327eeec8
PE
10808 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10809
abbd3d23
PE
10810 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10811 for characters.
10812
684a03ef
PE
10813 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10814
0fed43f3
PE
10815 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10816 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10817 incorrectly succeed when S was a string, because 4294967386 was
10818 truncated before it was used.
10819
8fd02eb7
PE
10820 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10821 Otherwise, an out-of-range integer could cause undefined behavior
10822 on a 64-bit host.
10823
f8c86b69
PE
10824 * composite.c: Use int, not EMACS_INT, for characters.
10825 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10826 EMACS_INT, for values that are known to be in character range.
10827 This doesn't fix any bugs but is the usual style inside Emacs and
10828 may generate better code on 32-bit machines.
10829
34206dd2
PE
10830 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10831 This is for reasons similar to the recent CHAR_STRING fix.
10832 * charset.c (Fencode_char): Check that character arg is actually
10833 a character. Pass an int to ENCODE_CHAR.
10834 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10835 wider than 'int', as a compile-time check to prevent future regressions
10836 in this area.
10837
c5958d4c 10838 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10839
10840 Make sure a 64-bit char is never passed to CHAR_STRING.
10841 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10842 by silently ignoring the top 32 bits, allowing some values
10843 that were far too large to be valid characters.
10844 * character.h: Include <verify.h>.
10845 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10846 arguments are no wider than unsigned, as a compile-time check
10847 to prevent future regressions in this area.
10848 * data.c (Faset):
01103c44 10849 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10850 (Fsubst_char_in_region):
10851 * fns.c (concat):
10852 * xdisp.c (decode_mode_spec_coding):
10853 Adjust to CHAR_STRING's new requirement.
10854 * editfns.c (Finsert_char, Fsubst_char_in_region):
10855 * fns.c (concat): Check that character args are actually
10856 characters. Without this test, these functions did the wrong
10857 thing with wildly out-of-range values on 64-bit hosts.
10858
d37ca623
PE
10859 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10860 These casts should not be needed on 32-bit hosts, either.
10861 * keyboard.c (read_char):
10862 * lread.c (Fload): Remove casts to unsigned.
10863
ea204efb
PE
10864 * lisp.h (UNSIGNED_CMP): New macro.
10865 This fixes comparison bugs on 64-bit hosts.
10866 (ASCII_CHAR_P): Use it.
10867 * casefiddle.c (casify_object):
01103c44 10868 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10869 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10870 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10871 * dispextern.h (FACE_FROM_ID):
10872 * keyboard.c (read_char): Use UNSIGNED_CMP.
10873
41cb286c
PE
10874 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10875 not to EMACS_INT, to avoid GCC warning.
10876
4a1b9832
PE
10877 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10878
55daad71
PE
10879 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10880 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10881 isn't needed on 32-bit machines.
8f95c75c 10882
01103c44
PE
10883 * buffer.c (Fgenerate_new_buffer_name):
10884 Use EMACS_INT for count, not int.
0ceccced 10885 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10886
10887 * data.c (Qcompiled_function): Now static.
10888
c6f072e7
PE
10889 * window.c (window_body_lines): Now static.
10890
20ce5912
PE
10891 * image.c (gif_load): Rename local to avoid shadowing.
10892
9c4c5f81
PE
10893 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10894 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10895 * alloc.c (make_save_value): Integer argument is now of type
10896 ptrdiff_t, not int.
10897 (mark_object): Use ptrdiff_t, not int.
10898 * lisp.h (pD): New macro.
10899 * print.c (print_object): Use it.
10900
c0c5c8ae
PE
10901 * alloc.c: Use EMACS_INT, not int, to count objects.
10902 (total_conses, total_markers, total_symbols, total_vector_size)
10903 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10904 (total_free_floats, total_floats, total_free_intervals)
10905 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10906 Now EMACS_INT, not int. All uses changed.
10907 (Fgarbage_collect): Compute overall total using a double, so that
10908 integer overflow is less likely to be a problem. Check for overflow
10909 when converting back to an integer.
5a25e253
PE
10910 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10911 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10912 These were 'int' variables that could overflow on 64-bit hosts;
10913 they were never used, so remove them instead of repairing them.
211a0b2a 10914 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10915 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10916 Previously, this ceilinged at INT_MAX, but that doesn't work on
10917 64-bit machines.
e46bb31a 10918 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10919
c78baabf 10920 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10921 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10922 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10923 when a (possibly-narrower) signed value would do just as well.
10924 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10925
c9d624c6
PE
10926 * alloc.c: Catch some string size overflows that we were missing.
10927 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10928 for convenience in STRING_BYTES_MAX.
10929 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10930 The definition here is exact; the one in lisp.h was approximate.
10931 (allocate_string_data): Check for string overflow. This catches
10932 some instances we weren't catching before. Also, it catches
10933 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10934 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10935 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10936
c9d624c6
PE
10937 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10938 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10939 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10940
353032ce
PE
10941 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10942
2bccce07
PE
10943 * alloc.c (Fmake_string): Check for out-of-range init.
10944
0ac30604
SM
109452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10946
10947 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10948
c195f2de
JD
109492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10950
10951 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10952 xg_get_default_scrollbar_width.
10953
10954 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10955 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10956 (style_changed_cb): Call update_theme_scrollbar_width and call
10957 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10958 all frames (Bug#8505).
10959 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10960 Call gtk_window_set_resizable if HAVE_GTK3.
10961 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10962 and height if HAVE_GTK3 (Bug#8505).
10963 (scroll_bar_width_for_theme): New variable.
10964 (update_theme_scrollbar_width): New function.
10965 (xg_get_default_scrollbar_width): Move code to
10966 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10967 (xg_initialize): Call update_theme_scrollbar_width.
10968
10969 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10970
10971 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10972
e10ac9f1
MR
109732011-06-12 Martin Rudalics <rudalics@gmx.at>
10974
10975 * frame.c (make_frame): Call other_buffer_safely instead of
10976 other_buffer.
10977
10978 * window.c (temp_output_buffer_show): Call display_buffer with
10979 second argument Vtemp_buffer_show_specifiers and reset latter
10980 immediately after the call.
10981 (Vtemp_buffer_show_specifiers): New variable.
10982 (auto_window_vscroll_p, next_screen_context_lines)
10983 (Vscroll_preserve_screen_position): Remove leading asterisks from
10984 doc-strings.
10985
2d3c217e 109862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10987
7b7f97e8 10988 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10989 * buffer.c (Qclone_number): Remove for now, as it's unused.
10990 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10991 (record_buffer): Remove unused local.
10992 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10993 (set_frame_buffer_list): Remove; unused.
10994 * frame.h (other_visible_frames): Remove decl.
10995 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10996 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10997 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10998 if HAVE_GPM.
10999 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11000 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11001 Define only if HAVE_GPM.
11002 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11003 (update_hints_inhibit): Remove; never set. All uses removed.
11004 * widgetprv.h (emacsFrameClassRec): Remove decl.
11005 * window.c (delete_deletable_window): Now returns void, since it
11006 wasn't returning anything.
11007 (compare_window_configurations): Remove unused locals.
11008 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11009 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11010 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11011 the same widths as pointers. This follows up on the 2011-05-06 patch.
11012 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11013 * xterm.h: Likewise.
11014 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11015
1384b89e
JB
110162011-06-12 Juanma Barranquero <lekktu@gmail.com>
11017
11018 * makefile.w32-in: Update dependencies.
11019 (LISP_H): Add lib/intprops.h.
11020
1100a63c
CY
110212011-06-11 Chong Yidong <cyd@stupidchicken.com>
11022
11023 * image.c (gif_load): Add animation frame delay to the metadata.
11024 (syms_of_image): Use DEFSYM. New symbol `delay'.
11025
6198ccd0
MR
110262011-06-11 Martin Rudalics <rudalics@gmx.at>
11027
11028 * window.c (delete_deletable_window): Re-add.
11029 (Fset_window_configuration): Rewrite to handle dead buffers and
11030 consequently deletable windows.
11031 (window_tree, Fwindow_tree): Remove. Supply functionality in
11032 window.el.
11033 (compare_window_configurations): Simplify code.
11034
b6e3633c
AS
110352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11036
1ab0dee5
AS
11037 * image.c (imagemagick_load_image): Fix type mismatch.
11038 (Fimagemagick_types): Likewise.
11039
b6e3633c
AS
11040 * window.h (replace_buffer_in_windows): Declare.
11041
9397e56f
MR
110422011-06-11 Martin Rudalics <rudalics@gmx.at>
11043
11044 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11045 Qclone_number. Remove external declaration of Qdelete_window.
11046 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11047 code.
640c8776
SM
11048 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11049 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11050 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11051 buffer list implementation.
11052 (other_buffer_safely): New function.
11053 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11054 calls to replace_buffer_in_windows and
11055 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11056 if allowed.
11057 (record_buffer): Inhibit quitting and rewrite using quittable
11058 functions. Run Qbuffer_list_update_hook if allowed.
11059 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11060 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11061 Move switch-to-buffer to window.el.
9397e56f
MR
11062 (bury-buffer): Move to window.el.
11063 (Vbuffer_list_update_hook): New variable.
11064
11065 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11066 section.
11067
11068 * window.h (resize_frame_windows): Move up in code.
11069 (Fwindow_frame): Remove EXFUN.
11070 (replace_buffer_in_all_windows): Remove prototype.
11071 (replace_buffer_in_windows_safely): Add prototype.
11072
11073 * window.c: Declare Qdelete_window static again. Move down
11074 declaration of select_count.
11075 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11076 (Fother_window): Move to window.el.
11077 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11078 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11079 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11080 window.el.
11081 (replace_buffer_in_windows): Implement by calling
11082 Qreplace_buffer_in_windows.
11083 (replace_buffer_in_all_windows): Remove with some functionality
11084 moved into replace_buffer_in_windows_safely.
11085 (replace_buffer_in_windows_safely): New function.
11086 (select_window_norecord, select_frame_norecord): Move in front
11087 of run_window_configuration_change_hook. Remove now obsolete
11088 declarations.
640c8776
SM
11089 (Fset_window_buffer): Rewrite doc-string.
11090 Call Qrecord_window_buffer.
9397e56f
MR
11091 (keys_of_window): Move binding for other-window to window.el.
11092
b50691aa
CY
110932011-06-11 Chong Yidong <cyd@stupidchicken.com>
11094
11095 * dispextern.h (struct image): Replace data member, whose int_val
11096 and ptr_val fields were not used by anything, with a single
11097 lisp_val object.
11098
11099 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11100 (gif_clear_image, gif_load, imagemagick_load_image)
11101 (gs_clear_image, gs_load): Callers changed.
11102
3f754b86
PE
111032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11104
cca69397
PE
11105 * buffer.h: Include <time.h>, for time_t.
11106 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11107
109e28d0
PE
11108 Fix minor problems found by static checking.
11109
60737f02
PE
11110 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11111
4b66faf3
PE
11112 Make identifiers static if they are not used in other modules.
11113 * data.c (Qcompiled_function, Qframe, Qvector):
11114 * image.c (QimageMagick, Qsvg):
11115 * minibuf.c (Qmetadata):
11116 * window.c (resize_window_check, resize_root_window): Now static.
11117 * window.h (resize_window_check, resize_root_window): Remove decls.
11118
109e28d0
PE
11119 * window.c (window_deletion_count, delete_deletable_window):
11120 Remove; unused.
46a4ce9e
PE
11121 (window_body_lines): Now static.
11122 (Fdelete_other_windows_internal): Mark vars as initialized.
11123 Make sure 'resize_failed' is initialized.
11124 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11125 (resize_window_apply): Remove unused local.
11126 * window.h (delete_deletable_window): Remove decl.
11127
109e28d0 11128 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11129 (imagemagick_load_image): Fix pointer signedness problem by changing
11130 last arg from unsigned char * to char *. All uses changed.
11131 Also, fix a local for similar reasons.
11132 Remove unused locals. Remove locals to avoid shadowing.
11133 (fn_rsvg_handle_free): Remove; unused.
11134 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11135 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11136
3f754b86
PE
11137 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11138
2547adb1
CY
111392011-06-10 Chong Yidong <cyd@stupidchicken.com>
11140
11141 * image.c (gif_load): Fix omitted cast error introduced by
11142 2011-06-06 change.
11143
2c8e37d4
MR
111442011-06-10 Martin Rudalics <rudalics@gmx.at>
11145
11146 * window.h (resize_proportionally, orig_total_lines)
11147 (orig_top_line): Remove from window structure.
11148 (set_window_height, set_window_width, change_window_heights)
11149 (Fdelete_window): Remove prototypes.
11150 (resize_frame_windows): Remove duplicate declaration.
11151
440a42e3
EZ
111522011-06-10 Eli Zaretskii <eliz@gnu.org>
11153
11154 * window.h (resize_frame_windows, resize_window_check)
11155 (delete_deletable_window, resize_root_window)
11156 (resize_frame_windows): Declare prototypes.
11157
11158 * window.c (resize_window_apply): Make definition be "static" to
11159 match the prototype.
11160
562dd5e9
MR
111612011-06-10 Martin Rudalics <rudalics@gmx.at>
11162
11163 * window.c: Remove declarations of Qwindow_size_fixed,
11164 window_min_size_1, window_min_size_2, window_min_size,
11165 size_window, window_fixed_size_p, enlarge_window, delete_window.
11166 Remove static from declaration of Qdelete_window, it's
11167 temporarily needed by Fbury_buffer.
11168 (replace_window): Don't assign orig_top_line and
11169 orig_total_lines.
11170 (Fdelete_window, delete_window): Remove. Window deletion is
11171 handled by window.el.
640c8776
SM
11172 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11173 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11174 (Fdelete_other_windows): Remove. Deleting other windows is
11175 handled by window.el.
11176 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11177 handled in window.el.
11178 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11179 Window minimum sizes are handled in window.el.
11180 (shrink_windows, size_window, set_window_height)
11181 (set_window_width, change_window_heights, window_height)
11182 (window_width, CURBEG, CURSIZE, enlarge_window)
11183 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11184 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11185 handled in window.el.
11186 (make_dummy_parent): Rename to make_parent_window and give it a
11187 second argument horflag.
11188 (make_window): Don't set resize_proportionally any more.
11189 (Fsplit_window): Remove. Windows are split in window.el.
11190 (save_restore_action, save_restore_orig_size)
11191 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11192 Resize mini windows in window.el.
11193 (grow_mini_window, shrink_mini_window): Implement by calling
11194 Qresize_root_window_vertically, resize_window_check and
11195 resize_window_apply.
640c8776
SM
11196 (saved_window, Fset_window_configuration, save_window_save):
11197 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11198 resize_proportionally.
11199 (window_min_height, window_min_width): Move to window.el.
11200 (keys_of_window): Move bindings for delete-other-windows,
11201 split-window, delete-window and enlarge-window to window.el.
11202
11203 * buffer.c: Temporarily extern Qdelete_window.
11204 (Fbury_buffer): Temporarily call Qdelete_window instead of
11205 Fdelete_window (Fbury_buffer will move to window.el soon).
11206
11207 * frame.c (set_menu_bar_lines_1): Remove code handling
11208 orig_top_line and orig_total_lines.
11209
11210 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11211 set_window_height but set heights directly.
11212 (change_frame_size_1): Use resize_frame_windows.
11213
11214 * xdisp.c (init_xdisp): Don't use set_window_height but set
11215 heights directly.
11216
640c8776
SM
11217 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11218 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11219 run_window_configuration_change_hook.
11220
11221 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11222 instead of change_window_heights and run
11223 run_window_configuration_change_hook.
11224
1a13852e
MR
112252011-06-09 Martin Rudalics <rudalics@gmx.at>
11226
11227 * window.c (replace_window): Rename second argument REPLACEMENT to
11228 NEW. New third argument SETFLAG. Rewrite.
11229 (delete_window, make_dummy_parent): Call replace_window with
11230 third argument 1.
11231 (window_list_1): Move down in code.
11232 (run_window_configuration_change_hook): Move set_buffer part
11233 before select_frame_norecord part in order to unwind correctly.
11234 Rename count1 to count.
11235 (recombine_windows, delete_deletable_window, resize_root_window)
11236 (Fdelete_other_windows_internal)
11237 (Frun_window_configuration_change_hook, make_parent_window)
11238 (resize_window_check, resize_window_apply, Fresize_window_apply)
11239 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11240 (Fdelete_window_internal, Fresize_mini_window_internal):
11241 New functions.
1a13852e
MR
11242 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11243
f3d1777e
MR
112442011-06-08 Martin Rudalics <rudalics@gmx.at>
11245
496e208e
MR
11246 * window.h (window): Add some new members to window structure -
11247 normal_lines, normal_cols, new_total, new_normal, clone_number,
11248 splits, nest, prev_buffers, next_buffers.
11249 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11250 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11251
f3d1777e
MR
11252 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11253 Remove.
496e208e
MR
11254 (make_dummy_parent): Set new members of windows structure.
11255 (make_window): Move down in code. Handle new members of window
11256 structure.
11257 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11258 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11259 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11260 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11261 (Fset_window_next_buffers, Fset_window_clone_number):
11262 New functions.
496e208e
MR
11263 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11264 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11265 Doc-string fixes.
11266 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11267 Argument WINDOW can be now internal window too.
11268 (Fwindow_use_time): Move up in code.
11269 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11270 Rewrite doc-string.
11271 (Fset_window_configuration, saved_window)
11272 (Fcurrent_window_configuration, save_window_save): Handle new
11273 members of window structure.
b9e809c2
MR
11274 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11275 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11276 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11277 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11278 Qget_mru_window, Qresize_root_window,
11279 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11280 Qauto_buffer_name; staticpro them.
f3d1777e 11281
abde8f8c
MR
112822011-06-07 Martin Rudalics <rudalics@gmx.at>
11283
11284 * window.c (Fwindow_total_size, Fwindow_left_column)
11285 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11286 (Fwindow_list_1): New functions.
11287 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11288 (Fwindow_width, Fscroll_left, Fscroll_right):
11289 Use window_body_cols instead of window_box_text_cols.
11290 (delete_window, Fset_window_configuration):
11291 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11292 (delete_all_subwindows): Take a window as argument and not a
11293 structure. Rewrite.
190b47e6
MR
11294 (window_loop): Remove handling of GET_LRU_WINDOW and
11295 GET_LARGEST_WINDOW.
11296 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11297
11298 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11299 window_box_text_cols. delete_all_subwindows now takes a
11300 Lisp_Object as argument.
abde8f8c 11301
640c8776
SM
11302 * indent.c (compute_motion, Fcompute_motion):
11303 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11304
fa8a67e6
MR
11305 * frame.c (delete_frame): Call delete_all_subwindows with root
11306 window as argument.
11307
a54e3482
DC
113082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11309
11310 * fns.c (Fputhash): Document return value.
11311
60002bf5
CY
113122011-06-06 Chong Yidong <cyd@stupidchicken.com>
11313
11314 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11315
0c671da6 113162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11317
b862a52a 11318 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11319
be44ca6c
PE
11320 Check for overflow when converting integer to cons and back.
11321 * charset.c (Fdefine_charset_internal, Fdecode_char):
11322 Use cons_to_unsigned to catch overflow.
11323 (Fencode_char): Use INTEGER_TO_CONS.
11324 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11325 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11326 * data.c (long_to_cons, cons_to_long): Remove.
11327 (cons_to_unsigned, cons_to_signed): New functions.
11328 These signal an error for invalid or out-of-range values.
11329 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11330 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11331 * font.c (Ffont_variation_glyphs):
11332 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11333 * lisp.h: Include <intprops.h>.
11334 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11335 (cons_to_signed, cons_to_unsigned): New decls.
11336 (long_to_cons, cons_to_long): Remove decls.
11337 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11338 (Fprimitive_undo): Use CONS_TO_INTEGER.
11339 * xfns.c (Fx_window_property): Likewise.
11340 * xselect.c: Include <limits.h>.
11341 (x_own_selection, selection_data_to_lisp_data):
11342 Use INTEGER_TO_CONS.
11343 (x_handle_selection_request, x_handle_selection_clear)
11344 (x_get_foreign_selection, Fx_disown_selection_internal)
11345 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11346 (lisp_data_to_selection_data): Use cons_to_unsigned.
11347 (x_fill_property_data): Use cons_to_signed.
11348 Report values out of range.
11349
d1f3d2af
PE
11350 Check for buffer and string overflow more precisely.
11351 * buffer.h (BUF_BYTES_MAX): New macro.
11352 * lisp.h (STRING_BYTES_MAX): New macro.
11353 * alloc.c (Fmake_string):
11354 * character.c (string_escape_byte8):
11355 * coding.c (coding_alloc_by_realloc):
11356 * doprnt.c (doprnt):
11357 * editfns.c (Fformat):
11358 * eval.c (verror):
11359 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11360 since they may not be the same number.
11361 * editfns.c (Finsert_char):
11362 * fileio.c (Finsert_file_contents):
11363 Likewise for BUF_BYTES_MAX.
11364
dd52fcea
PE
11365 * image.c: Use ptrdiff_t, not int, for sizes.
11366 (slurp_file): Switch from int to ptrdiff_t.
11367 All uses changed.
11368 (slurp_file): Check that file size fits in both size_t (for
11369 malloc) and ptrdiff_t (for sanity and safety).
11370
7f9bbdbb
PE
11371 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11372 if b->modtime has its maximal value.
11373
dfe18f82
PE
11374 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11375
84acfcf0
PE
11376 Don't assume time_t can fit into int.
11377 * buffer.h (struct buffer.modtime): Now time_t, not int.
11378 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11379 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11380
ccd9a01a
PE
11381 Minor fixes for signed vs unsigned integers.
11382 * character.h (MAYBE_UNIFY_CHAR):
11383 * charset.c (maybe_unify_char):
11384 * keyboard.c (read_char, reorder_modifiers):
11385 XINT -> XFASTINT, since the integer must be nonnegative.
11386 * ftfont.c (ftfont_spec_pattern):
11387 * keymap.c (access_keymap, silly_event_symbol_error):
11388 XUINT -> XFASTINT, since the integer must be nonnegative.
11389 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11390 since it makes no difference and we prefer signed.
11391 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11392 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11393 nonnegative.
11394
d6d100dd
SM
113952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11396
11397 * window.h (Fwindow_frame): Declare.
11398
2b6148e4
PE
113992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11400
11401 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11402 (SPARE_MEMORY): Always define.
11403 (LARGE_REQUEST): Remove.
11404 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11405
f230ecc9
MR
114062011-06-06 Martin Rudalics <rudalics@gmx.at>
11407
727e958e
MR
11408 * lisp.h: Move EXFUNS for Fframe_root_window,
11409 Fframe_first_window and Fset_frame_selected_window to window.h.
11410
11411 * window.h: Move EXFUNS for Fframe_root_window,
11412 Fframe_first_window and Fset_frame_selected_window here from
11413 lisp.h.
11414
11415 * frame.c (Fwindow_frame, Fframe_first_window)
11416 (Fframe_root_window, Fframe_selected_window)
11417 (Fset_frame_selected_window): Move to window.c.
11418 (Factive_minibuffer_window): Move to minibuf.c.
11419 (Fother_visible_frames_p): New function.
11420
11421 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11422
f230ecc9
MR
11423 * window.c (decode_window, decode_any_window): Move up in code.
11424 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11425 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11426 (Fwindow_buffer): Move up and rewrite doc-string.
11427 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11428 (Fwindow_prev): New functions.
727e958e
MR
11429 (Fwindow_frame): Move here from frame.c. Accept any window as
11430 argument.
11431 (Fframe_root_window, Fframe_first_window)
11432 (Fframe_selected_window): Move here from frame.c. Accept frame
11433 or arbitrary window as argument. Update doc-strings.
11434 (Fminibuffer_window): Move up in code.
11435 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11436 (Fset_frame_selected_window): Move here from frame.c.
11437 Marginal rewrite.
727e958e
MR
11438 (Fselected_window, select_window, Fselect_window): Move up in
11439 code. Minor doc-string fixes.
f230ecc9 11440
4d09bcf6
PE
114412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11442
11443 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11444 Do not assume that spare memory exists; that assumption is valid
11445 only if SYSTEM_MALLOC.
11446 (LARGE_REQUEST): New macro, so that the issue of large requests
11447 is separated from the issue of spare memory.
11448
810928a2
AS
114492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11450
172418ad
AS
11451 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11452 format. (Bug#8806)
11453
43f862f7
AS
11454 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11455
810928a2
AS
11456 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11457 before statements.
11458
a059fe24
JD
114592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11460
11461 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11462
11463 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11464
11465 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11466 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11467
989bf368
JB
114682011-06-05 Juanma Barranquero <lekktu@gmail.com>
11469
11470 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11471
4b80f674
CY
114722011-06-04 Chong Yidong <cyd@stupidchicken.com>
11473
11474 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11475 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11476 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11477 New error handlers.
4b80f674
CY
11478 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11479 Obey Vx_select_enable_clipboard_manager. Catch errors in
11480 x_clipboard_manager_save (Bug#8779).
11481 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11482 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11483
99a33b77 114842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11485
11486 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11487
99a33b77 114882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11489
11490 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11491 in the current matrix if keep_current_p is non-zero.
11492
8264569d
EZ
114932011-06-04 Eli Zaretskii <eliz@gnu.org>
11494
11495 * bidi.c (bidi_level_of_next_char): Fix last change.
11496
57f97249
EZ
114972011-06-03 Eli Zaretskii <eliz@gnu.org>
11498
fec2107c 11499 Support bidi reordering of text covered by display properties.
57f97249 11500
fec2107c
EZ
11501 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11502 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11503 (bidi_cache_search, bidi_cache_iterator_state)
11504 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11505 (bidi_level_of_next_char, bidi_move_to_visually_next):
11506 Support character positions inside a run of characters covered by a
fec2107c
EZ
11507 display string.
11508 (bidi_paragraph_init, bidi_resolve_explicit_1)
11509 (bidi_level_of_next_char): Call bidi_fetch_char and
11510 bidi_fetch_char_advance instead of FETCH_CHAR and
11511 FETCH_CHAR_ADVANCE.
11512 (bidi_init_it): Initialize new members.
11513 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11514 definitions.
11515 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11516 instead of using explicit *_CHAR codes.
d6d100dd
SM
11517 (bidi_resolve_explicit, bidi_resolve_weak):
11518 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11519 bidirectional text is supported only in multibyte buffers.
11520 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11521 it to initialize the frame_window_p member of struct bidi_it.
11522 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11523 (bidi_resolve_explicit, bidi_resolve_weak)
11524 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11525 bidi_it->nchars is non-positive.
11526 (bidi_level_of_next_char): Don't try to lookup the cache for the
11527 next/previous character if nothing is cached there yet, or if we
11528 were just reseat()'ed to a new position.
c40e2fb2 11529
0e14fe90
EZ
11530 * xdisp.c (set_cursor_from_row): Set start and stop points
11531 according to the row's direction when priming the loop that looks
11532 for the glyph on which to display cursor.
11533 (single_display_spec_intangible_p): Function deleted.
11534 (display_prop_intangible_p): Reimplement to call
11535 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11536 Accept 3 additional arguments needed by handle_display_spec.
11537 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11538 values: lists, `(when COND...)' forms, etc.
11539 (single_display_spec_string_p): Support property values that are
11540 lists with the argument STRING its top-level element.
11541 (display_prop_string_p): Fix the condition for processing a
11542 property that is a list to be consistent with handle_display_spec.
fec2107c 11543 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11544 last portion of handle_display_prop.
11545 (compute_display_string_pos): Accept additional argument
11546 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11547 value of a `display' property is a "replacing spec".
11548 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11549 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11550 the display property, but just return a value indicating whether
11551 the display property will replace the characters it covers.
11552 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11553 frame_window_p members of struct bidi_it.
d6d100dd
SM
11554 (compute_display_string_pos, compute_display_string_end):
11555 New functions.
fec2107c
EZ
11556 (push_it): Accept second argument POSITION, where pop_it should
11557 jump to continue iteration.
11558 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11559
fec2107c
EZ
11560 * keyboard.c (adjust_point_for_property): Adjust the call to
11561 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11562
11563 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11564 (bidi_init_it): Update prototypes.
11565 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11566 (compute_display_string_pos, compute_display_string_end):
11567 Declare prototypes.
fec2107c
EZ
11568 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11569 EMACS_INT.
fc6f18ce 11570
40087514 115712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11572
57f53182
PE
11573 Malloc failure behavior now depends on size of allocation.
11574 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11575 * lisp.h: Change signatures accordingly.
11576 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11577 All callers changed. (Bug#8762)
11578
11579 * gnutls.c: Use Emacs's memory allocators.
11580 Without this change, the gnutls library would invoke malloc etc.
11581 directly, which causes problems on non-SYNC_INPUT hosts, and which
11582 runs afoul of improving memory_full behavior. (Bug#8761)
11583 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11584 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11585 xfree instead of the default malloc, realloc, free.
11586 (Fgnutls_boot): No need to check for memory allocation failure,
11587 since xmalloc does that for us.
11588
ac32cd99 11589 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11590 * category.c (hash_get_category_set):
11591 * ccl.c (ccl_driver):
11592 * charset.c (Fdefine_charset_internal):
11593 * charset.h (struct charset.hash_index):
11594 * composite.c (get_composition_id, gstring_lookup_cache)
11595 (composition_gstring_put_cache):
11596 * composite.h (struct composition.hash_index):
11597 * dispextern.h (struct image.hash):
11598 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11599 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11600 (hashfn_equal, hashfn_user_defined, make_hash_table)
11601 (maybe_resize_hash_table, hash_lookup, hash_put)
11602 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11603 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11604 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11605 * image.c (make_image, search_image_cache, lookup_image)
11606 (xpm_put_color_table_h):
11607 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11608 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11609 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11610 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11611 * alloc.c (allocate_vectorlike):
11612 Check for overflow in vector size calculations.
11613 * ccl.c (ccl_driver):
11614 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11615 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11616 need to be updated by these changes.
40087514
PE
11617 * fns.c (make_hash_table, maybe_resize_hash_table):
11618 Check for integer overflow with large hash tables.
0de4bb68
PE
11619 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11620 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11621 (SXHASH_REDUCE): New macro.
11622 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11623 Use it instead of discarding useful hash info with large hash values.
11624 (sxhash_float): New function.
11625 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11626 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11627 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11628 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11629 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11630 Adjust signatures to match updated version of code.
11631 (consing_since_gc): Now EMACS_INT, since a single hash table can
11632 use more than INT_MAX bytes.
11633
698d32e2
DN
116342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11635
11636 Make it possible to build with GCC-4.6+ -O2 -flto.
11637
11638 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11639
fd6fa53f
SM
116402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11641
11642 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11643 Call minibuffer-inactive-mode.
11644
864db017
JB
116452011-05-31 Juanma Barranquero <lekktu@gmail.com>
11646
11647 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11648 Update dependencies.
11649
2ad0baf4
DN
116502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11651
11652 * data.c (init_data): Remove code for UTS, this system is not
11653 supported anymore.
11654
4fcc2638
DN
116552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11656
11657 Don't force ./temacs to start in terminal mode.
11658
11659 * frame.c (make_initial_frame): Initialize faces in all cases, not
11660 only when CANNOT_DUMP is defined.
11661 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11662
c56e0fd5
DN
116632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11664
11665 * dispnew.c (add_window_display_history): Use const for the string
11666 pointer. Remove declaration, not needed.
11667
333d54da 116682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11669
55d4c1b2 11670 Use 'inline', not 'INLINE'.
333d54da 11671 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11672 * alloc.c, fontset.c (INLINE): Remove.
11673 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11674 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11675 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11676 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11677 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11678
738db178
DN
116792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11680
11681 Make it possible to run ./temacs.
11682
11683 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11684 syms_of_callproc does the same thing. Remove test for
11685 "initialized", do it in the caller.
11686 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11687
620c53a6
SM
116882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11689
11690 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11691 (read_minibuf): Use get_minibuffer.
11692 (syms_of_minibuf): Use DEFSYM.
11693 (Qmetadata): New var.
11694 * data.c (Qbuffer): Don't make it static.
11695 (syms_of_data): Use DEFSYM.
11696
e003a292
PE
116972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11698
11699 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11700 (CCL_CODE_MIN): New macro.
11701
ed008a6d
PE
117022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11703
3687c2ef
PE
11704 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11705
ed008a6d
PE
11706 * eval.c (Qdebug): Now static.
11707 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11708 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11709 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11710
d66c4c7c
CY
117112011-05-29 Chong Yidong <cyd@stupidchicken.com>
11712
11713 * image.c: Various fixes to ImageMagick code comments.
11714 (Fimagemagick_types): Doc fix.
11715
5fbc2025
PE
117162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11717
0196f88a
PE
11718 Minor fixes prompted by GCC 4.6.0 warnings.
11719
11720 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11721
5fbc2025
PE
11722 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11723 (x_clipboard_manager_save_all): Move extern decl to ...
11724 * xterm.h: ... here, so that it can be checked for consistency.
11725
1dd3c2d9
CY
117262011-05-29 Chong Yidong <cyd@stupidchicken.com>
11727
11728 * xselect.c (x_clipboard_manager_save_frame)
11729 (x_clipboard_manager_save_all): New functions.
11730 (Fx_clipboard_manager_save): Lisp function deleted.
11731
11732 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11733 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11734
11735 * xterm.h: Update prototype.
11736
5ba6571d
WX
117372011-05-28 William Xu <william.xwl@gmail.com>
11738
11739 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11740 exiting (Bug#8239).
11741
3eaff834
JM
117422011-05-28 Jim Meyering <meyering@redhat.com>
11743
e1900994 11744 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11745 * fns.c (to_uchar): Define.
11746 (crypto_hash_function): Use it to convert some newly-signed
11747 variables to unsigned, to avoid sign-extension bugs. For example,
11748 without this change, (md5 "truc") would evaluate to
11749 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11750 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11751 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11752
0f6990a7
PE
117532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11754
11755 Integer overflow fixes.
c8a9ca5a 11756
08686060
PE
11757 * dbusbind.c: Serial number integer overflow fixes.
11758 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11759 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11760 to hold a serial number that is too large for a fixnum.
11761 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11762 Check for serial numbers out of range. Decode any serial number
59568bf0 11763 that was so large that it became a float. (Bug#8722)
08686060 11764
2d1fc3c7
PE
11765 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11766 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11767 Use XFASTINT rather than XUINT when numbers are nonnegative.
11768 (xd_append_arg, Fdbus_method_return_internal):
11769 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11770 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11771 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11772 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11773 (Bug#8722)
2d1fc3c7 11774
c8a9ca5a
PE
11775 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11776
519e1d69
PE
11777 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11778
6df6ae42 11779 ccl: Add integer overflow checks.
30569699
PE
11780 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11781 (IN_INT_RANGE): New macros.
11782 (ccl_driver): Use them to check for integer overflow when
11783 decoding a CCL program. Many of the new checks are whether XINT (x)
11784 fits in int; it doesn't always, on 64-bit hosts. The new version
11785 doesn't catch all possible integer overflows, but it's an
847044ea 11786 improvement. (Bug#8719)
30569699 11787
c11285dc
PE
11788 * alloc.c (make_event_array): Use XINT, not XUINT.
11789 There's no need for unsigned here.
11790
fdccd48e
PE
11791 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11792 This follows up to the 2011-05-06 change that substituted uintptr_t
11793 for EMACS_INT. This case wasn't caught back then.
11794
37910ab2
PE
11795 Rework Fformat to avoid integer overflow issues.
11796 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11797 now (part of C89). Include <verify.h>.
11798 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11799 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11800 (Fformat): Avoid the prepass trying to compute sizes; it was only
11801 approximate and thus did not catch overflow reliably. Instead, walk
11802 through the format just once, formatting and computing sizes as we go,
11803 checking for integer overflow at every step, and allocating a larger
11804 buffer as needed. Keep track separately whether the format is
11805 multibyte. Keep only the most-recently calculated precision, rather
11806 than them all. Record whether each argument has been converted to
11807 string. Use EMACS_INT, not int, for byte and char and arg counts.
11808 Support field widths and precisions larger than INT_MAX. Avoid
11809 sprintf's undefined behavior with conversion specifications such as %#d
11810 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11811 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11812 formatting out-of-range floating point numbers with int
9173deec 11813 formats. (Bug#8668)
37910ab2 11814
2e6578fb
PE
11815 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11816
0ae6bdee
PE
11817 * data.c: Avoid integer truncation in expressions involving floats.
11818 * data.c: Include <intprops.h>.
11819 (arith_driver): When there's an integer overflow in an expression
11820 involving floating point, convert the integers to floating point
11821 so that the resulting value does not suffer from catastrophic
11822 integer truncation. For example, on a 64-bit host (* 4
11823 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11824 Do not rely on undefined behavior after integer overflow.
11825
de883a70
PE
11826 merge count_size_as_multibyte, parse_str_to_multibyte
11827 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11828 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11829 Check for integer overflow.
11830 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11831 since it's now a duplicate of the other. This is more of
11832 a character than a buffer op, so better that it's in character.c.
11833 * fns.c, print.c: Adjust to above changes.
11834
2ff916cb
PE
118352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11836
11837 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11838
f1b54466
PE
118392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11840
fb1ac845
PE
11841 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11842 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11843 (x_clipboard_manager_save): Now static.
11844 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11845
f1b54466
PE
11846 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11847 (crypto_hash_function): Now static.
11848 Fix pointer signedness problems. Avoid unnecessary initializations.
11849
a9f737ee
CY
118502011-05-27 Chong Yidong <cyd@stupidchicken.com>
11851
11852 * termhooks.h (Vselection_alist): Make it terminal-local.
11853
11854 * terminal.c (create_terminal): Initialize it.
11855
11856 * xselect.c: Support for clipboard managers.
11857 (Vselection_alist): Move to termhooks.h as terminal-local var.
11858 (LOCAL_SELECTION): New macro.
11859 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11860 (symbol_to_x_atom): Remove gratuitous arg.
11861 (x_handle_selection_request, lisp_data_to_selection_data)
11862 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11863 (x_own_selection, x_get_local_selection, x_convert_selection):
11864 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11865 (some_frame_on_display): Delete unused function.
11866 (Fx_own_selection_internal, Fx_get_selection_internal)
11867 (Fx_disown_selection_internal, Fx_selection_owner_p)
11868 (Fx_selection_exists_p): New optional frame arg.
11869 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11870 (x_handle_selection_clear): Don't treat other terminals with the
11871 same keyboard specially. Use the terminal-local Vselection_alist.
11872 (x_clear_frame_selections): Use Frun_hook_with_args.
11873
11874 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11875
11876 * xterm.h: Add support for those atoms.
11877
e067f0c1
CY
118782011-05-26 Chong Yidong <cyd@stupidchicken.com>
11879
11880 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11881 (converted_selections, conversion_fail_tag): New global variables.
11882 (x_selection_request_lisp_error): Free the above.
11883 (x_get_local_selection): Remove unnecessary code.
11884 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11885 of converted selections stored in converted_selections.
11886 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11887 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11888 (x_convert_selection): New function.
11889 (x_handle_selection_event): Simplify.
11890 (x_get_foreign_selection): Don't ignore incoming requests while
11891 waiting for an answer; this will fail when we implement
11892 SAVE_TARGETS, and seems unnecessary anyway.
11893 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11894 (Vx_sent_selection_functions): Doc fix.
11895
0f4aebc0
LL
118962011-05-26 Leo Liu <sdl.web@gmail.com>
11897
11898 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11899
e61124cd
YM
119002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11901
11902 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11903
11904 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11905 for fringe update if it has periodic bitmap.
ac389d0c 11906 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11907 and fringe_bitmap_periodic_p.
11908
11909 * fringe.c (get_fringe_bitmap_data): New function.
11910 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11911 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11912 row. Mark glyph row for fringe update if periodicity changed.
11913
11914 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11915 for fringe update unless it has periodic bitmap.
11916
f16d9837
KH
119172011-05-25 Kenichi Handa <handa@m17n.org>
11918
11919 * xdisp.c (get_next_display_element): Set correct it->face_id for
11920 a static composition.
11921
e1b90ef6
LL
119222011-05-24 Leo Liu <sdl.web@gmail.com>
11923
11924 * deps.mk (fns.o):
11925 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11926
11927 * fns.c (crypto_hash_function, Fsha1): New function.
11928 (Fmd5): Use crypto_hash_function.
11929 (syms_of_fns): Add Ssha1.
11930
7400048f
PE
119312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11932
11933 * gnutls.c: Remove unused macros.
11934 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11935 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11936 Remove macros that are defined and never used.
11937 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11938
abb71cf4
CY
119392011-05-22 Chong Yidong <cyd@stupidchicken.com>
11940
11941 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11942 (Fx_get_selection_internal): Minor cleanup.
11943 (Fx_own_selection_internal): Rename arguments for consistency with
11944 select.el.
11945
6307db39
PE
119462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11947
11948 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11949
f3d4e0a4
CY
119502011-05-22 Chong Yidong <cyd@stupidchicken.com>
11951
11952 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11953
4d8ade89
YM
119542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11955
11956 * dispnew.c (scrolling_window): Don't exclude the case that the
11957 last enabled row in the desired matrix touches the bottom boundary.
11958
32078c8d
GM
119592011-05-21 Glenn Morris <rgm@gnu.org>
11960
11961 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11962 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11963 and add some more files.
32078c8d 11964
7285dc67
EZ
119652011-05-20 Eli Zaretskii <eliz@gnu.org>
11966
11967 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11968 report_file_error introduced by the change from 2011-05-07.
11969
89d1bd22
PE
119702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11971
11972 * systime.h (Time): Define only if emacs is defined.
11973 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11974 where the include path doesn't have X11/X.h by default. See
11975 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11976
cd394be1 119772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11978
11979 * composite.c (find_automatic_composition): Fix previous change.
11980
b9704ad9
GM
119812011-05-20 Glenn Morris <rgm@gnu.org>
11982
11983 * lisp.mk: New file, split from Makefile.in.
11984 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11985 (shortlisp): Remove.
11986 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11987
4a720484
GM
119882011-05-19 Glenn Morris <rgm@gnu.org>
11989
11990 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11991 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11992 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11993 (lisp): Set the order to that of loadup.el.
11994 (shortlisp): Make it a copy of $lisp.
11995 (SOME_MACHINE_LISP): Remove.
11996 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11997 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11998
a28d4396
KH
119992011-05-18 Kenichi Handa <handa@m17n.org>
12000
12001 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12002 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12003 (find_automatic_composition): Mostly rewrite for efficiency.
12004
a2b1fa8e
JB
120052011-05-18 Juanma Barranquero <lekktu@gmail.com>
12006
12007 * makefile.w32-in: Update dependencies.
12008
8e1f5610
CS
120092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12010
12011 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12012 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12013
7025ee00 120142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12015
cdfa6eab
PE
12016 Fix some integer overflow issues, such as string length overflow.
12017
06d6db33
PE
12018 * insdel.c (count_size_as_multibyte): Check for string overflow.
12019
2b4560a8
PE
12020 * character.c (lisp_string_width): Check for string overflow.
12021 Use EMACS_INT, not int, for string indexes and lengths; in
12022 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12023 the resulting string length overflows an EMACS_INT; instead,
12024 report a string overflow if no precision given. When checking for
12025 precision exhaustion, use a check that cannot possibly have
12026 integer overflow. (Bug#8675)
12027 * character.h (lisp_string_width): Adjust to new signature.
12028
cb93f9be
PE
12029 * alloc.c (string_overflow): New function.
12030 (Fmake_string): Use it. This doesn't change behavior, but saves
12031 a few bytes and will simplify future changes.
12032 * character.c (string_escape_byte8): Likewise.
12033 * lisp.h (string_overflow): New decl.
12034
1a1f3366
PE
12035 Fixups, following up to the user-interface timestamp change.
12036 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12037 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12038 * msdos.c (mouse_get_pos): Likewise.
12039 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12040 * w32gui.h (Time): Define by including "systime.h" rather than by
12041 declaring it ourselves. (Bug#8664)
12042
d4e3e4d3
PE
12043 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12044 * image.c (clear_image_cache): Likewise.
12045
f6a24d19
PE
12046 * term.c (term_mouse_position): Don't assume time_t wraparound.
12047
08dc5ae6
PE
12048 Be more systematic about user-interface timestamps.
12049 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12050 and sometimes 'EMACS_UINT', to represent these timestamps.
12051 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12052 This makes the code easier to follow, and makes it easier to catch
12053 integer overflow bugs such as Bug#8664.
12054 * frame.c (Fmouse_position, Fmouse_pixel_position):
12055 Use Time, not unsigned long, for user-interface timestamps.
12056 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12057 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12058 * keyboard.h (last_event_timestamp): Likewise.
12059 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12060 * menu.h (xmenu_show): Likewise.
12061 * term.c (term_mouse_position): Likewise.
12062 * termhooks.h (struct input_event.timestamp): Likewise.
12063 (struct terminal.mouse_position_hook): Likewise.
12064 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12065 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12066 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12067 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12068 what it was before.
12069 * menu.h, termhooks.h: Include "systime.h", for Time.
12070
8e55734a
PE
12071 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12072 Don't assume that the difference between two unsigned long values
12073 can fit into an integer. At this point, we know button_down_time
12074 <= event->timestamp, so the difference must be nonnegative, so
12075 there's no need to cast the result if double-click-time is
12076 nonnegative, as it should be; check that it's nonnegative, just in
12077 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12078 apart (about 25 days). (Bug#8664)
8e55734a 12079
841f1b75 12080 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12081 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12082
3e26f69c
PE
12083 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12084 that always fit in int. Use a sentinel instead of a counter, to
12085 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12086 * frame.h (struct frame): Use int for menu_bar_items_used
12087 instead of EMACS_INT, since it always fits in int.
3e26f69c 12088
5cc152c0
PE
12089 * menu.c (grow_menu_items): Check for int overflow.
12090
d89eb65e
PE
12091 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12092
5235bd3e
PE
12093 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12094 Before, the code was not consistent. These values cannot exceed
12095 2**31 - 1 so there's no need to make them unsigned.
12096 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12097 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12098 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12099 as modifiers.
12100 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12101
bc827e23
PE
12102 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12103 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12104 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12105 presumably because the widths might not match.
12106
78eb494e
PE
12107 * window.c (size_window): Avoid needless test at loop start.
12108
04f2d78b
CB
121092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12110
12111 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12112
d2fc7e3d 121132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12114
12115 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12116
d2fc7e3d 121172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12118
12119 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12120 `width' to `bar_area_x' and `bar_area_width', respectively.
12121 (x_scroll_run): Take account of fringe background extension.
12122
04f2d78b
CB
12123 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12124 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12125 `bar_area_width', respectively.
12126 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12127 background extension.
12128
79b70037
GM
121292011-05-10 Jim Meyering <meyering@redhat.com>
12130
12131 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12132
2f142cc5
JB
121332011-05-10 Juanma Barranquero <lekktu@gmail.com>
12134
12135 * image.c (Finit_image_library): Return t for built-in image types,
12136 like pbm and xbm. (Bug#8640)
12137
57679c86
AS
121382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12139
12140 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12141
888c9e86
EZ
121422011-05-07 Eli Zaretskii <eliz@gnu.org>
12143
b0512a1d
EZ
12144 * w32console.c (Fset_screen_color): Doc fix.
12145 (Fget_screen_color): New function.
12146 (syms_of_ntterm): Defsubr it.
12147
7285dc67
EZ
12148 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12149 unlink the temporary file if Fcall_process didn't create it in the
12150 first place.
12151 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12152 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12153 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12154 cue to call_process_cleanup not to close that handle.
12155
4d3fcc8e
BK
121562011-05-07 Ben Key <bkey76@gmail.com>
12157
12158 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12159 one of two shell specific rules, either bootstrap-temacs-CMD or
12160 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12161 to the previous implementation of the bootstrap-temacs rule.
12162 The bootstrap-temacs-CMD rule is similar to the previous
12163 implementation of the bootstrap-temacs rule except that it
12164 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12165 variable.
12166
12167 These changes, along with some changes to nt/configure.bat,
12168 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12169 earlier fix to add support for --cflags and --ldflags options
12170 that include quotes so that it works whether make uses cmd or
12171 sh as the shell.
12172
b4289b64
MA
121732011-05-06 Michael Albinus <michael.albinus@gmx.de>
12174
12175 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12176 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12177 is a constant.
12178 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12179 a string. Handle both cases.
12180 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12181 (Fdbus_register_method): Use Qinvalid_function.
12182
af4c0e28
JB
121832011-05-06 Juanma Barranquero <lekktu@gmail.com>
12184
12185 * makefile.w32-in: Update dependencies.
12186 (LISP_H): Add inttypes.h and stdin.h.
12187 (PROCESS_H): Add unistd.h.
12188
c51453d9
EZ
121892011-05-06 Eli Zaretskii <eliz@gnu.org>
12190
12191 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12192 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12193
8ff0ac3c 121942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12195
4c4b566b
PE
12196 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12197
aab2b9b5
PE
12198 * term.c (vfatal): Remove stray call to va_end.
12199 It's not needed and the C Standard doesn't allow it here anyway.
12200
c378da0b
PE
12201 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12202 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12203
288b08c7
PE
12204 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12205 bytes.
12206
e3601888
PE
12207 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12208
db6c0e74
PE
12209 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12210
dd5963ea
PE
12211 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12212
88c9450f
PE
12213 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12214
2f9442b8
PE
12215 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12216
c032b5f8
PE
12217 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12218 * charset.c (Fdefine_charset_internal): Don't initialize
12219 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12220 32-bit int (Bug#8600).
a108c10b
PE
12221
12222 * lread.c (read_integer): Be more consistent with string-to-number.
12223 Use string_to_number to do the actual conversion; this avoids
12224 rounding errors and fixes some other screwups. Without this fix,
12225 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12226 (digit_to_number): Move earlier, for benefit of read_integer.
12227 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12228 not a digit in any supported base. (Bug#8602)
a108c10b 12229
ad5f9eea
PE
12230 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12231
aec1708a
PE
12232 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12233 to match comment at start of function. This also removes a
12234 GCC warning about overflow in a 32+64-bit port.
12235
47be4ab5
PE
12236 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12237
371cac43
PE
12238 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12239 Reported by Stefan Monnier in
12240 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12241 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12242 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12243
d01a7826
PE
12244 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12245 (EMACS_UINTPTR): Likewise, with uintptr_t.
12246
7fd47d5c
PE
12247 * lisp.h: Prefer 64-bit EMACS_INT if available.
12248 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12249 on 32-bit hosts that have 64-bit int, so that they can access
12250 large files.
122b0c86
PE
12251 However, temporarily disable this change unless the temporary
12252 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12253
8727937b
PE
12254 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12255
8ac068ac
PE
12256 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12257 This removes an assumption that EMACS_INT and long are the same
12258 width as pointers. The assumption is true for Emacs porting targets
12259 now, but we want to make other targets possible.
12260 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12261 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12262 In the rest of the code, change types of integers that hold casted
12263 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12264 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12265 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12266 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12267 No need to cast type when ORing.
12268 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12269 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12270 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12271 assume EMACS_INT is the same width as char *.
12272 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12273 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12274 Remove no-longer-needed casts.
12275 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12276 (xg_tool_bar_help_callback, xg_make_tool_item):
12277 Use EMACS_INTPTR to hold an integer
12278 that will be cast to void *; this can avoid a GCC warning
12279 if EMACS_INT is not the same width as void *.
12280 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12281 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12282 (current_message_1, set_message_1):
12283 Use a local to convert to proper width without a cast.
12284 * xmenu.c (dialog_selection_callback): Likewise.
12285
ede49d71
PE
12286 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12287 Also, don't assume VALBITS / RAND_BITS is less than 5,
12288 and don't rely on undefined behavior when shifting a 1 left into
12289 the sign bit.
12290 * lisp.h (get_random): Change signature to match.
12291
2f30ecd0
PE
12292 * lread.c (hash_string): Use size_t, not int, for hash computation.
12293 Normally we prefer signed values; but hashing is special, because
12294 it's better to use unsigned division on hash table sizes so that
12295 the remainder is nonnegative. Also, size_t is the natural width
12296 for hashing into memory. The previous code used 'int', which doesn't
12297 retain enough info to hash well into very large tables.
12298 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12299
2a866e7b
PE
12300 * dbusbind.c: Don't possibly lose pointer info when converting.
12301 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12302 Use XPNTR rather than XHASH, so that the high-order bits of
12303 the pointer aren't lost when converting through void *.
12304
51639eac
PE
12305 * eval.c (Fautoload): Don't double-shift a pointer.
12306
92394119
PE
12307 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12308
dbdb9a7c
JB
123092011-05-06 Juanma Barranquero <lekktu@gmail.com>
12310
12311 * gnutls.c (DEF_GNUTLS_FN):
12312 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12313
db7a0b4f
AS
123142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12315
12316 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12317 marker. (Bug#8610)
12318
cd394be1 123192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12320
12321 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12322 New version that can reserve upto 2GB of heap space.
12323
f7ff1b0f 123242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12325
12326 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12327
639c109b
TZ
123282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12329
12330 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12331 `gnutls_certificate_set_x509_key_file'.
12332
d2127135
JB
123332011-05-05 Juanma Barranquero <lekktu@gmail.com>
12334
12335 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12336 Update dependencies.
12337
e968f4f3
JB
123382011-05-04 Juanma Barranquero <lekktu@gmail.com>
12339
12340 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12341 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12342 Remove unused parameter `fildes'.
12343 * process.c (read_process_output, send_process): Don't pass it.
12344
84d358f0
JB
123452011-05-04 Juanma Barranquero <lekktu@gmail.com>
12346
12347 Fix previous change: the library cache is defined in w32.c.
12348 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12349 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12350
0898ca10
JB
123512011-05-04 Juanma Barranquero <lekktu@gmail.com>
12352
12353 Implement dynamic loading of GnuTLS on Windows.
12354
12355 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12356 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12357 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12358 Declare.
12359
12360 * gnutls.c (Qgnutls_dll): Define.
12361 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12362 (gnutls_*): Declare function pointers.
12363 (init_gnutls_functions): New function to initialize function pointers.
12364 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12365 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12366 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12367 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12368 (emacs_gnutls_write, emacs_gnutls_read)
12369 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12370 (Fgnutls_available_p): New function.
12371 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12372 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12373 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12374
12375 * image.c: Include w32.h.
12376 (Vimage_type_cache): Delete.
12377 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12378 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12379 (w32_delayed_load): Move to w32.c.
12380
12381 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12382
12383 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12384 (w32_delayed_load): Move from image.c. When loading a library, record
12385 its filename in the :loaded-from property of the library id.
12386 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12387 Initialize and staticpro them.
12388 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12389
12390 * process.c: Include lisp.h before w32.h, not after.
12391 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12392 instead of gnutls_record_check_pending.
12393
12394 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12395
ff4de4aa
TZ
123962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12397
12398 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12399 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12400 as passed in.
12401
abe95abb
JD
124022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12403
12404 * xterm.c (x_set_frame_alpha): Do not set property on anything
12405 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12406
e16e55d4
JB
124072011-05-02 Juanma Barranquero <lekktu@gmail.com>
12408
12409 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12410
bafcf6a5
JB
124112011-05-02 Juanma Barranquero <lekktu@gmail.com>
12412
12413 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12414 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12415 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12416 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12417 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12418 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12419 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12420 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12421 (Qgnutls_bootprop_callbacks_verify): Make static.
12422
e7a6747f
AS
124232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12424
19ed11ba
AS
12425 * callproc.c: Indentation fixup.
12426
e7a6747f 12427 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12428 (wait_for_termination, interruptible_wait_for_termination):
12429 Move after wait_for_termination_1.
e7a6747f 12430
1ef14cb4
LMI
124312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12432
12433 * sysdep.c (interruptible_wait_for_termination): New function
12434 which is like wait_for_termination, but allows keyboard
12435 interruptions.
12436
12437 * callproc.c (Fcall_process): Add (:file "file") as an option for
12438 the STDOUT buffer.
12439 (Fcall_process_region): Ditto.
12440
330d880c
EZ
124412011-04-30 Eli Zaretskii <eliz@gnu.org>
12442
8db90b73
EZ
12443 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12444 rather than `XVECTOR (FOO)->size'.
12445
330d880c
EZ
12446 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12447 inttypes.h, as a gnulib replacement is used if it not available in
12448 system headers.
12449
15cbd324
EZ
124502011-04-21 Eli Zaretskii <eliz@gnu.org>
12451
12452 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12453 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12454 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12455
12456 * coding.c (coding_alloc_by_realloc): Error out if destination
12457 will grow beyond MOST_POSITIVE_FIXNUM.
12458 (decode_coding_emacs_mule): Abort if there isn't enough place in
12459 charbuf for the composition carryover bytes. Reserve an extra
12460 space for up to 2 characters produced in a loop.
12461 (decode_coding_iso_2022): Abort if there isn't enough place in
12462 charbuf for the composition carryover bytes.
12463
124642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12465
ae940cca
EZ
12466 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12467 aborting when %lld or %lll format is passed.
12468 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12469 %llo or %llx format is passed. (Bug#8545)
12470
03ab8921
EZ
12471 * window.c (window_scroll_line_based): Use a marker instead of
12472 simple variables to record original value of point. (Bug#7952)
12473
afda1437
EZ
12474 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12475 produced by %s or %c overflows available buffer space. (Bug#8545)
12476
f76dee0c
PE
124772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12478
12479 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12480 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12481
fdc5744d
JB
124822011-04-28 Juanma Barranquero <lekktu@gmail.com>
12483
12484 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12485
638f053a
JB
124862011-04-28 Juanma Barranquero <lekktu@gmail.com>
12487
12488 * keyboard.c (Qdelayed_warnings_hook): Define.
12489 (command_loop_1): Run `delayed-warnings-hook'
12490 if Vdelayed_warnings_list is non-nil.
12491 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12492 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12493
d178f871
EZ
124942011-04-28 Eli Zaretskii <eliz@gnu.org>
12495
12496 * doprnt.c (doprnt): Don't return value smaller than the buffer
12497 size if the message was truncated. (Bug#8545).
12498
b124fd93
JB
124992011-04-28 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12502 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12503
e810457d
PE
125042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12505
12506 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12507
ea51cceb
JB
125082011-04-27 Juanma Barranquero <lekktu@gmail.com>
12509
12510 * makefile.w32-in: Update dependencies.
12511
94dcfacf
EZ
125122011-04-27 Eli Zaretskii <eliz@gnu.org>
12513
12514 Improve `doprnt' and its usage. (Bug#8545)
12515 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12516 `format_end'. Remove support for %l as a conversion specifier.
12517 Don't use xrealloc. Improve diagnostics when the %l size modifier
12518 is used. Update the commentary.
12519
12520 * eval.c (verror): Simplify calculation of size_t.
12521
12522 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12523 messages.
12524
f61f41d7
PE
125252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12526
12527 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12528 change.
12529
96fb4434
PE
125302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12531
12532 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12533 This makes this file independent of the recent pseudovector change.
12534
671875da 125352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12536
69e9b5a3
PE
12537 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12538
b5f869a7 12539 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12540 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12541 Remove unused local.
c8926152 12542 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12543
841a1577 12544 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12545 GCC 4.6.0 optimizes based on type-based alias analysis.
12546 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12547 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12548 != &v->size, and therefore "v->size = 1; b->size = 2; return
12549 v->size;" must therefore return 1. This assumption is incorrect
12550 for Emacs, since it type-puns struct Lisp_Vector * with many other
12551 types. To fix this problem, this patch adds a new type struct
f904488f 12552 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12553 and pseudovectors, and helps optimizing compilers not get fooled
12554 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12555 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12556 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12557 the size member.
eab3844f
PE
12558 (XSETPVECTYPE): Rewrite in terms of new macro.
12559 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12560 This is a bit clearer, and further avoids the possibility of
12561 undesirable aliasing.
12562 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12563 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12564 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12565 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12566 (ASIZE): Now uses header.size rather than size.
12567 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12568 to avoid the hassle of writing XVECTOR (foo)->header.size.
12569 (struct vectorlike_header): New type.
eab3844f
PE
12570 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12571 object, to help avoid aliasing.
12572 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12573 (SUBRP): Likewise, since Lisp_Subr is a special case.
12574 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12575 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12576 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12577 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12578 changed to be "header.size" and "header.next".
12579 * buffer.h (struct buffer): Likewise.
12580 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12581 * frame.h (struct frame): Likewise.
12582 * process.h (struct Lisp_Process): Likewise.
12583 * termhooks.h (struct terminal): Likewise.
12584 * window.c (struct save_window_data, struct saved_window): Likewise.
12585 * window.h (struct window): Likewise.
12586 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12587 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12588 * buffer.c (init_buffer_once): Likewise.
12589 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12590 special case.
12591 * process.c (Fformat_network_address): Use local var for size,
12592 for brevity.
12593
0df1eac5
PE
12594 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12595
847ab9d1 12596 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12597 * data.c (atof): Remove decl; no longer used or needed.
12598 (digit_to_number): Move to lread.c.
12599 (Fstring_to_number): Use new string_to_number function, to be
12600 consistent with how the Lisp reader treats infinities and NaNs.
12601 Do not assume that floating-point numbers represent EMACS_INT
12602 without losing information; this is not true on most 64-bit hosts.
12603 Avoid double-rounding errors, by insisting on integers when
12604 parsing non-base-10 numbers, as the documentation specifies.
12605 * lisp.h (string_to_number): New decl, replacing ...
12606 (isfloat_string): Remove.
bc0a5c13 12607 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12608 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12609 appears to have been a coding error. Similarly, do not accept
12610 strings like +-1e0 as floating point numbers. Do not report
12611 overflow for integer overflows unless the base is not 10 which
12612 means we have no simple and reliable way to continue.
12613 Break out the floating-point parsing into a new
12614 function string_to_number, so that Fstring_to_number parses
12615 floating point numbers consistently with the Lisp reader.
04f2d78b 12616 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12617 (E_CHAR, EXP_INT): Remove, replacing with ...
12618 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12619 (string_to_number): New function, replacing isfloat_string.
12620 This function checks for valid syntax and produces the resulting
12621 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12622 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12623 so that overflow for non-base-10 numbers is reported only when
12624 there's no portable and simple way to convert to floating point.
452f4150 12625
67769ffc
PE
12626 * textprop.c (set_text_properties_1): Rewrite for clarity,
12627 and to avoid GCC warning about integer overflow.
12628
c20db43f
PE
12629 * intervals.h (struct interval): Use EMACS_INT for members
12630 where EMACS_UINT might cause problems. See
12631 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12632 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12633 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12634 All uses changed.
37aa2f85
PE
12635 (offset_intervals): Tell GCC not to worry about length overflow
12636 when negating a negative length.
c20db43f 12637
2538aa2f
PE
12638 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12639 (overrun_check_free): Likewise.
12640
f2d3008d
PE
12641 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12642 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12643 word size.
12644
ec8df744
PE
12645 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12646 (gnutls_make_error): Rename local to avoid shadowing.
12647 (gnutls_emacs_global_deinit): ifdef out; not used.
12648 (Fgnutls_boot): Use const for pointer to readonly storage.
12649 Comment out unused local. Fix pointer signedness problems.
12650
640ee02d
PE
12651 * lread.c (openp): Don't stuff size_t into an 'int'.
12652 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12653 about possible signed overflow.
12654
6048fb2a
PE
12655 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12656 (GDK_KEY_g): Don't define if already defined.
12657 (xg_prepare_tooltip): Avoid pointer signedness problem.
12658 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12659
fa3c87e1
PE
12660 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12661 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12662
2172544b
PE
12663 * xfns.c (Fx_window_property): Simplify a bit,
12664 to make a bit faster and to avoid GCC 4.6.0 warning.
12665 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12666
9b821a21
PE
12667 * fns.c (internal_equal): Don't assume size_t fits in int.
12668
3c616cfa
PE
12669 * alloc.c (compact_small_strings): Tighten assertion a little.
12670
c2982e87
PE
12671 Replace pEd with more-general pI, and fix some printf arg casts.
12672 * lisp.h (pI): New macro, generalizing old pEd macro to other
12673 conversion specifiers. For example, use "...%"pI"d..." rather
12674 than "...%"pEd"...".
12675 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12676 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12677 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12678 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12679 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12680 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12681 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12682 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12683 64-bit hosts.
12684 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12685 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12686 * print.c (safe_debug_print, print_object): Likewise.
12687 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12688 to int.
6f04d126
PE
12689 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12690 avoiding the 0 flag, which is not portable.
c2982e87
PE
12691 * process.c (Fmake_network_process): Use pI to avoid cast.
12692 * region-cache.c (pp_cache): Likewise.
12693 * xdisp.c (decode_mode_spec): Likewise.
12694 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12695 behavior on 64-bit hosts with printf arg.
6f04d126 12696 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12697 (x_stop_queuing_selection_requests): Likewise.
12698 (x_get_window_property): Don't truncate byte count to an 'int'
12699 when tracing.
0b432f21 12700
5e073ec7
PE
12701 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12702 here, since it parses constructs like leading '-' and spaces,
12703 which are not wanted; and it overflows with large numbers.
12704 Instead, simply match F[0-9]+, which is what is wanted anyway.
12705
36372bf9
PE
12706 * alloc.c: Remove unportable assumptions about struct layout.
12707 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12708 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12709 (allocate_vectorlike, make_pure_vector): Use the new macros,
12710 plus offsetof, to remove unportable assumptions about struct layout.
12711 These assumptions hold on all porting targets that I know of, but
12712 they are not guaranteed, they're easy to remove, and removing them
12713 makes further changes easier.
12714
0b432f21
PE
12715 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12716 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12717 (string_overrun_cookie): Now const. Use initializers that
12718 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12719 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12720 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12721 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12722 multiple of sizeof (EMACS_INT); it need not be, if
12723 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12724 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12725
895009e1
JB
127262011-04-26 Juanma Barranquero <lekktu@gmail.com>
12727
12728 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12729
6a7a1b0b
TZ
127302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12731
12732 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12733 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12734 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12735
841a1577 127362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12737
12738 * lisp.h (Qdebug): List symbol.
895009e1 12739 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12740 * keyboard.c (debug-on-event): New variable.
12741 (handle_user_signal): Break into debugger when debug-on-event
12742 matches the current signal symbol.
12743
f2d3ba6f
DN
127442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12745
12746 * alloc.c (check_sblock, check_string_bytes)
12747 (check_string_free_list): Convert to standard C.
12748
42ce4c63
TZ
127492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12750
12751 * w32.c (emacs_gnutls_push): Fix typo.
12752
825cd63c
EZ
127532011-04-25 Eli Zaretskii <eliz@gnu.org>
12754
fb11d64d
EZ
12755 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12756 "cast to pointer from integer of different size".
12757
825cd63c
EZ
12758 Improve doprnt and its use in verror. (Bug#8545)
12759 * doprnt.c (doprnt): Document the set of format control sequences
12760 supported by the function. Use SAFE_ALLOCA instead of always
12761 using `alloca'.
12762
12763 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12764 is one byte too soon. Don't use xrealloc; instead xfree and
12765 xmalloc anew.
12766
e061a11b
TZ
127672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12768
12769 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12770 callbacks stage.
12771
12772 * gnutls.c: Renamed global_initialized to
12773 gnutls_global_initialized. Added internals for the
12774 :verify-hostname-error, :verify-error, and :verify-flags
12775 parameters of `gnutls-boot' and documented those parameters in the
12776 docstring. Start callback support.
9173deec
JB
12777 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12778 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12779 on error. Return error code.
e061a11b
TZ
12780 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12781 (emacs_gnutls_read): Likewise.
12782 (Fgnutls_boot): Return handshake error code.
12783 (emacs_gnutls_handle_error): New function.
12784 (wsaerror_to_errno): Likewise.
12785
12786 * w32.h (emacs_gnutls_pull): Add prototype.
12787 (emacs_gnutls_push): Likewise.
12788
12789 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12790 (emacs_gnutls_push): Likewise.
12791
127922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12793
12794 * process.c (wait_reading_process_output): Check if GnuTLS
12795 buffered some data internally if no FDs are set for TLS
12796 connections.
12797
12798 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12799 (LIBS): Link to USER_LIBS.
12800 ($(BLD)/gnutls.$(0)): New target.
12801
fa6996bc
EZ
128022011-04-24 Eli Zaretskii <eliz@gnu.org>
12803
eb35682e
EZ
12804 * xdisp.c (handle_single_display_spec): Rename the
12805 display_replaced_before_p argument into display_replaced_p, to
12806 make it consistent with the commentary. Fix typos in the
12807 commentary.
12808
e2ad650c
EZ
12809 * textprop.c (syms_of_textprop): Remove dead code.
12810 (copy_text_properties): Delete obsolete commentary about an
12811 interface that was deleted long ago. Fix typos in the description
12812 of arguments.
12813
1b2de274
EZ
12814 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12815 to changes in oldXMenu/XMenu.h from 2011-04-16.
12816 <menu_help_message, prev_menu_help_message>: Constify.
12817 (IT_menu_make_room): menu->help_text is now `const char **';
12818 adjust.
12819
12820 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12821 to changes in oldXMenu/XMenu.h from 2011-04-16.
12822 (struct XMenu): Declare `help_text' `const char **'.
12823
12824 * xfaces.c <Qunspecified>: Make extern again.
12825
12826 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12827 required by POSIX.
1b2de274 12828
762b15be
EZ
12829 * doc.c (get_doc_string): Improve the format passed to `error'.
12830
12831 * doprnt.c (doprnt): Improve commentary.
12832
12833 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12834
12835 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12836 them with etags.
12837
f1052e5d
EZ
12838 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12839 changes in globals.h immediately force recompilation.
762b15be
EZ
12840 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12841 $(CURDIR)/s/ms-w32.h.
12842 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12843
fa6996bc
EZ
12844 * character.c (Fchar_direction): Function deleted.
12845 (syms_of_character): Don't defsubr it.
12846 <char-direction-table>: Deleted.
12847
e6c3da20
EZ
128482011-04-23 Eli Zaretskii <eliz@gnu.org>
12849
12850 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12851 * doprnt.c: Include limits.h.
12852 (SIZE_MAX): New macro.
04f2d78b
CB
12853 (doprnt): Return a size_t value. 2nd arg is now size_t.
12854 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12855 Improve overflow protection. Support `l' modifier for integer
12856 conversions. Support %l conversion. Don't assume an EMACS_INT
12857 argument for integer conversions and for %c.
12858
12859 * lisp.h (doprnt): Restore prototype.
12860
12861 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12862 $(SRC)/character.h.
12863
12864 * Makefile.in (base_obj): Add back doprnt.o.
12865
12866 * deps.mk (doprnt.o): Add back prerequisites.
12867 (callint.o): Depend on character.h.
12868
12869 * eval.c (internal_lisp_condition_case): Include the handler
12870 representation in the error message.
12871 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12872 when breaking from the loop.
12873
12874 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12875
12876 * callint.c (Fcall_interactively): When displaying error message
12877 about invalid control letter, pass the character's codepoint, not
12878 a pointer to its multibyte form. Improve display of the character
12879 in octal and display also its hex code.
12880
12881 * character.c (char_string): Use %x to display the (unsigned)
12882 codepoint of an invalid character, to avoid displaying a bogus
12883 negative value.
12884
12885 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12886 `error', not SYMBOL_NAME itself.
12887
12888 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12889 character arguments to `error'.
12890
12891 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12892 to `error' in error message about FINAL_CHAR argument. Make sure
12893 FINAL_CHAR is a character, and use %c when it is passed as
12894 argument to `error'.
12895
4ffd0d6b 128962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12897
12898 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12899
12900 * w32.c: Include <time.h>.
12901 (sys_localtime): New function.
12902
4ffd0d6b 129032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12904
12905 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12906
4ffd0d6b 12907 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12908
4ffd0d6b 129092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12910
4ffd0d6b
GM
12911 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12912 zombies (Bug#8467).
aac0c6e3 12913
04c56954
EZ
129142011-04-19 Eli Zaretskii <eliz@gnu.org>
12915
12916 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12917 gl_state.e_property when gl_state.object is Qt.
12918
12919 * insdel.c (make_gap_larger): Remove limitation of buffer size
12920 to <= INT_MAX.
12921
16a43933
CY
129222011-04-18 Chong Yidong <cyd@stupidchicken.com>
12923
12924 * xdisp.c (lookup_glyphless_char_display)
12925 (produce_glyphless_glyph): Handle cons cell entry in
12926 glyphless-char-display.
12927 (Vglyphless_char_display): Document it.
12928
12929 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12930 glyphless-char-display.
12931
4581706e
CY
129322011-04-17 Chong Yidong <cyd@stupidchicken.com>
12933
12934 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12935
12936 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12937
12938 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12939 definition for no-X builds.
12940
4887c6e2 129412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12942
fd35b6f9
PE
12943 Static checks with GCC 4.6.0 and non-default toolkits.
12944
5c1ccb01
PE
12945 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12946
006c5daa
PE
12947 * process.c (keyboard_bit_set): Define only if SIGIO.
12948 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12949 (send_process): Repair possible setjmp clobbering.
12950
efc736d3
PE
12951 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12952
4e2fe2e6
PE
12953 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12954
f97334a2
PE
12955 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12956
4e75f29d
PE
12957 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12958 Define only if needed.
12959
90efadd1
PE
12960 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12961 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12962 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12963
3c647824
PE
12964 * dispextern.h (struct redisplay_interface): Rename param
12965 to avoid shadowing.
e264f262 12966 * termhooks.h (struct terminal): Likewise.
761383f4 12967 * xterm.c (xembed_send_message): Likewise.
3c647824 12968
b58c5c4a
PE
12969 * insdel.c (make_gap_smaller): Define only if
12970 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12971
cad59032
PE
12972 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12973 it.
12974
c339dc2e
PE
12975 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12976 so that we aren't warned about unused symbols.
12977
91a3e27b
PE
12978 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12979
399c71d3 12980 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12981
8ffc96f5
PE
12982 * xfns.c (x_real_positions): Mark locals as initialized.
12983
eef9bc79
PE
12984 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12985
098db9dd
PE
12986 * xterm.c: Fix problems found by static analysis with other toolkits.
12987 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12988 (x_dispatch_event): Declare static if USE_GTK, and
12989 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12990 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12991 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12992 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12993 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12994
eb18f6cc
PE
12995 * xmenu.c (menu_help_callback): Pointer type fixes.
12996 Use const pointers when pointing at readonly data. Avoid pointer
12997 signedness clashes.
12998 (FALSE): Remove unused macro.
12999 (update_frame_menubar): Remove unused decl.
13000
1fe72bf8
PE
13001 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13002
60d9e1db
PE
13003 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13004 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13005 (single_menu_item): Rename local to avoid shadowing.
13006
39261c26
PE
13007 * keyboard.c (make_lispy_event): Remove unused local var.
13008
018c5e19
PE
13009 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13010 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13011
63d2b86e
PE
13012 * bitmaps: Change bitmaps from unsigned char back to the X11
13013 compatible char. Avoid the old compiler warnings about
13014 out-of-range initializers by using, for example, '\xab' rather
13015 than 0xab.
13016
aefd87e1
PE
13017 * xgselect.c (xgselect_initialize): Check vs interface
13018 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13019
bf501fb9
PE
13020 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13021
e9829fdf
PE
13022 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13023 to read-only memory.
13024
1086c095
PE
13025 * fns.c (vector): Remove; this old hack is no longer needed.
13026
2baccd04 13027 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13028 Remove unused var.
dde42981 13029 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13030
72391843 13031 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13032
436c16df 13033 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13034 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13035 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13036
92bb796d 13037 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13038 (x_term_init): Remove local to avoid shadowing.
92bb796d 13039
764430a3 13040 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13041
13042 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13043 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13044
d1dfb56c
EZ
130452011-04-16 Eli Zaretskii <eliz@gnu.org>
13046
c4354cb4
EZ
13047 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13048
d1dfb56c
EZ
13049 Fix regex.c, syntax.c and friends for buffers > 2GB.
13050 * syntax.h (struct gl_state_s): Declare character position members
13051 EMACS_INT.
13052
13053 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13054
04f2d78b
CB
13055 * textprop.c (verify_interval_modification, interval_of):
13056 Declare arguments EMACS_INT.
d1dfb56c
EZ
13057
13058 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13059 EMACS_INT.
13060
13061 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13062
13063 * indent.c (Fvertical_motion): Local variable it_start is now
13064 EMACS_INT.
13065
13066 * regex.c (re_match, re_match_2, re_match_2_internal)
13067 (bcmp_translate, regcomp, regexec, print_double_string)
13068 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13069 (re_compile_pattern, re_exec): Declare arguments and local
13070 variables `size_t' and `ssize_t' and return values `regoff_t', as
13071 appropriate.
13072 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13073 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13074 <compile_stack_type>: `size' and `avail' are now `size_t'.
13075
13076 * regex.h <regoff_t>: Use ssize_t, not int.
13077 (re_search, re_search_2, re_match, re_match_2): Arguments that
13078 specify buffer/string position and length are now ssize_t and
13079 size_t. Return type is regoff_t.
13080
613052cd
BK
130812011-04-16 Ben Key <bkey76@gmail.com>
13082
13083 * nsfont.m: Fixed bugs in ns_get_family and
13084 ns_descriptor_to_entity that were caused by using free to
13085 deallocate memory blocks that were allocated by xmalloc (via
13086 xstrdup). This caused Emacs to crash when compiled with
13087 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13088 --enable-checking=xmallocoverrun). xfree is now used to
13089 deallocate these memory blocks.
13090
4170f62f 130912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13092
71b41406
PE
13093 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13094
9587a89d
PE
13095 emacs_write: Accept and return EMACS_INT for sizes.
13096 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13097 et seq.
13098 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13099 Accept and return EMACS_INT.
13100 (emacs_gnutls_write): Return the number of bytes written on
13101 partial writes.
13102 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13103 (emacs_read, emacs_write): Remove check for negative size, as the
13104 Emacs source code has been audited now.
9587a89d
PE
13105 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13106 (emacs_read, emacs_write): Use it.
273a5f82
PE
13107 * process.c (send_process): Adjust to the new signatures of
13108 emacs_write and emacs_gnutls_write. Do not attempt to store
13109 a byte offset into an 'int'; it might overflow.
9587a89d 13110 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13111
3e047f51
PE
13112 * sound.c: Don't assume sizes fit in 'int'.
13113 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13114 Return EMACS_INT, not int.
3e047f51 13115 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13116 Accept EMACS_INT, not int.
13117 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13118 record read return values.
13119
cc39a9db
BK
131202011-04-15 Ben Key <bkey76@gmail.com>
13121
c9d0ec6d
JB
13122 * keyboard.c (Qundefined): Don't declare static since it is used
13123 in nsfns.m.
13124 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13125 static since they are used in nsfont.m.
cc39a9db 13126
6c60eb9f
SM
131272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13128
13129 * process.c (Qprocessp): Don't declare static.
13130 * lisp.h (Qprocessp): Declare again.
13131
7990b61a
JB
131322011-04-15 Juanma Barranquero <lekktu@gmail.com>
13133
13134 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13135
5d4cb038
PE
131362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13137
8bd7b830 13138 Improve C-level modularity by making more things 'static'.
cd64ea1d 13139
e3b27b31
PE
13140 Don't publish debugger-only interfaces to other modules.
13141 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13142 (verify_bytepos, count_markers): Move decls to the only modules
13143 that need them.
13144 * region-cache.h (pp_cache): Likewise.
13145 * window.h (check_all_windows): Likewise.
13146 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13147
5d4cb038
PE
13148 * sysdep.c (croak): Now static, if
13149 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13150 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13151
13152 * alloc.c (refill_memory_reserve): Now static if
13153 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13154 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13155
e87b6180
PE
13156 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13157 Define only if USE_LUCID.
13158
ac64929e
PE
13159 * xrdb.c (x_customization_string, x_rm_string): Now static.
13160
6f37259d
PE
13161 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13162 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13163
1683e3ab
PE
13164 * xdisp.c (draw_row_with_mouse_face): Now static.
13165 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13166
de9c2632
PE
13167 * window.h (check_all_windows): Mark externally visible.
13168
2b96acb7
PE
13169 * window.c (window_deletion_count): Now static.
13170
13171 * undo.c: Make symbols static if they're not exported.
13172 (last_undo_buffer, last_boundary_position, pending_boundary):
13173 Now static.
13174
50436f33
PE
13175 * textprop.c (interval_insert_behind_hooks): Now static.
13176 (interval_insert_in_front_hooks): Likewise.
13177
64520e5c
PE
13178 * term.c: Make symbols static if they're not exported.
13179 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13180 (max_frame_lines, tty_set_terminal_modes):
13181 (tty_reset_terminal_modes, tty_turn_off_highlight):
13182 (get_tty_terminal): Now static.
13183 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13184 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13185 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13186 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13187 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13188
1fa53021
PE
13189 * sysdep.c: Make symbols static if they're not exported.
13190 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13191 Now static.
13192 (sigprocmask_set, full_mask): Remove; unused.
13193 (wait_debugging): Mark as visible.
13194 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13195 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13196
d4b43b22
PE
13197 * syntax.c (syntax_temp): Define only if !__GNUC__.
13198
b7c513d0
PE
13199 * sound.c (current_sound_device, current_sound): Now static.
13200
989b29ad
PE
13201 * search.c (searchbufs, searchbuf_head): Now static.
13202
13a55a78
PE
13203 * scroll.c (scroll_cost): Remove; unused.
13204 * dispextern.h (scroll_cost): Remove decl.
13205
de68a1fc
PE
13206 * region-cache.h (pp_cache): Mark as externally visible.
13207
40ccffa6
PE
13208 * process.c: Make symbols static if they're not exported.
13209 (process_tick, update_tick, create_process, chan_process):
13210 (Vprocess_alist, proc_buffered_char, datagram_access):
13211 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13212 (deactivate_process): Mark defn as static, as well as decl.
13213 * lisp.h (create_process): Remove decl.
13214 * process.h (chan_process, Vprocess_alist): Remove decls.
13215
ad64fc97
PE
13216 * print.c: Make symbols static if they're not exported.
13217 (print_depth, new_backquote_output, being_printed, print_buffer):
13218 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13219 (print_interval, print_number_index, initial_stderr_stream):
13220 Now static.
13221 * lisp.h (Fprinc): Remove decl.
13222 (debug_output_compilation_hack): Mark as externally visible.
13223
adddb265
PE
13224 * sysdep.c (croak): Move decl from here to syssignal.h.
13225 * syssignal.h (croak): Put it here, so the API can be checked when
13226 'croak' is called from dissociate_if_controlling_tty.
13227
1717ede2
PE
13228 * minibuf.c: Make symbols static if they're not exported.
13229 (minibuf_save_list, choose_minibuf_frame): Now static.
13230 * lisp.h (choose_minibuf_frame): Remove decl.
13231
fa5fb2bc
PE
13232 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13233
1e3890d1
PE
13234 * lread.c: Make symbols static if they're not exported.
13235 (read_objects, initial_obarray, oblookup_last_bucket_number):
13236 Now static.
13237 (make_symbol): Remove; unused.
13238 * lisp.h (initial_obarray, make_symbol): Remove decls.
13239
8a1414fa
PE
13240 * keyboard.c: Make symbols static if they're not exported.
13241 (single_kboard, recent_keys_index, total_keys, recent_keys):
13242 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13243 (this_single_command_key_start, echoing, last_auto_save):
13244 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13245 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13246 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13247 (Vlispy_mouse_stem, double_click_count):
13248 Now static.
13249 (force_auto_save_soon): Define only if SIGDANGER.
13250 (ignore_mouse_drag_p): Now static if
13251 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13252 (print_help): Remove; unused.
13253 (stop_character, last_timer_event): Mark as externally visible.
13254 * keyboard.h (ignore_mouse_drag_p): Declare only if
13255 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13256 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13257 * lisp.h (echoing): Remove decl.
13258 (force_auto_save_soon): Declare only if SIGDANGER.
13259 * xdisp.c (redisplay_window): Simplify code, to make it more
13260 obvious that ignore_mouse_drag_p is not accessed if !defined
13261 USE_GTK && !defined HAVE_NS.
13262
93ea6e8f
PE
13263 * intervals.c: Make symbols static if they're not exported.
13264 (merge_properties_sticky, merge_interval_right, delete_interval):
13265 Now static.
13266 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13267
77382fcc
PE
13268 * insdel.c: Make symbols static if they're not exported.
13269 However, leave prepare_to_modify_buffer alone. It's never
13270 called from outside this function, but that appears to be a bug.
13271 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13272 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13273 (adjust_after_replace_noundo): Remove; unused.
13274 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13275 (signal_before_change): Remove decls.
77382fcc 13276
9306c32e
PE
13277 * indent.c (val_compute_motion, val_vmotion): Now static.
13278
cd44d2eb
PE
13279 * image.c: Make symbols static if they're not exported.
13280 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13281 if USE_GTK.
13282 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13283 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13284
ad9a7a06
PE
13285 * fringe.c (standard_bitmaps): Now static.
13286 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13287
81626931
PE
13288 * frame.c: Make symbols static if they're not exported.
13289 (x_report_frame_params, make_terminal_frame): Now static.
13290 (get_frame_param): Now static, unless HAVE_NS.
13291 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13292 (x_get_resource_string): Remove; not used.
13293 * frame.h (make_terminal_frame, x_report_frame_params):
13294 (x_get_resource_string); Remove decls.
13295 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13296 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13297
239f9db9
PE
13298 * font.c, fontset.c: Make symbols static if they're not exported.
13299 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13300 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13301 * font.c (font_close_object): Now static.
13302 * font.h (font_close_object): Remove.
13303 * fontset.c (FONTSET_OBJLIST): Remove.
13304 (free_realized_fontset) #if-0 the body, which does nothing.
13305 (face_suitable_for_char_p): #if-0, as it's never called.
13306 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13307 * xfaces.c (face_at_string_position):
13308 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13309 since 0 is always ASCII.
13310
dfcf3579
PE
13311 * fns.c (weak_hash_tables): Now static.
13312
5045092b
PE
13313 * fileio.c: Make symbols static if they're not exported.
13314 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13315 (Vwrite_region_annotation_buffers): Now static.
13316
57a96f5c
PE
13317 * eval.c: Make symbols static if they're not exported.
13318 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13319 * lisp.h (backtrace_list): Remove decl.
13320
35f08c38
PE
13321 * emacs.c: Make symbols static if they're not exported.
13322 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13323 (fatal_error_code, fatal_error_signal_hook, standard_args):
13324 Now static.
13325 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13326 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13327 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13328 * lisp.h (fatal_error_signal_hook): Remove decl.
13329 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13330
f44bd759
PE
13331 * editfns.c: Move a (normally-unused) function to its only use.
13332 * editfns.c, lisp.h (get_operating_system_release): Remove.
13333 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13334 worth the hassle of breaking this out.
13335
b532497d
PE
13336 * xterm.c: Make symbols static if they're not exported.
13337 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13338 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13339 (x_destroy_window, x_delete_display):
13340 Now static.
13341 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13342 (x_mouse_leave): Remove; unused.
13343 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13344 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13345 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13346 Remove decls.
13347 (x_mouse_leave): Declare only if WINDOWSNT.
13348 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13349 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13350 USE_X_TOOLKIT.
13351
1675728f
PE
13352 * ftxfont.c: Make symbols static if they're not exported.
13353 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13354 HAVE_FREETYPE.
13355 * font.h (ftxfont_driver): Likewise.
13356
e4cebfca
PE
13357 * xfns.c: Make symbols static if they're not exported.
13358 (x_last_font_name, x_display_info_for_name):
13359 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13360 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13361 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13362 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13363 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13364 (last_show_tip_args): Now static.
13365 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13366 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13367 (x_screen_planes): Remove; unused.
13368 * dispextern.h (x_screen_planes): Remove decl.
13369
5bf46f05
PE
13370 * dispnew.c: Make symbols static if they're not exported.
13371 * dispextern.h (redraw_garbaged_frames, scrolling):
13372 (increment_row_positions): Remove.
13373 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13374 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13375 Now static.
13376 (redraw_garbaged_frames): Remove; unused.
13377
435f4c28
PE
13378 * xfaces.c: Make symbols static if they're not exported.
13379 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13380 Remove decls.
13381 * xterm.h (defined_color): Remove decls.
13382 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13383 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13384 (menu_face_changed_default, defined_color, free_realized_face):
13385 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13386 (ascii_face_of_lisp_face): Remove; unused.
13387
8524aef3
PE
13388 * xdisp.c: Make symbols static if they're not exported.
13389 * dispextern.h (scratch_glyph_row, window_box_edges):
13390 (glyph_to_pixel_coords, set_cursor_from_row):
13391 (get_next_display_element, set_iterator_to_next):
13392 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13393 (show_mouse_face): Remove decls
13394 * frame.h (message_buf_print): Likewise.
13395 * lisp.h (pop_message, set_message, check_point_in_composition):
13396 Likewise.
13397 * xterm.h (set_vertical_scroll_bar): Likewise.
13398 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13399 (message_buf_print, scratch_glyph_row, displayed_buffer):
13400 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13401 (get_next_display_element, show_mouse_face, window_box_edges):
13402 (frame_to_window_pixel_xy, check_point_in_composition):
13403 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13404 (glyph_to_pixel_coords): Remove; unused.
13405
16390cd2
PE
13406 * dired.c (file_name_completion): Now static.
13407
13408 * dbusbind.c (xd_in_read_queued_messages): Now static.
13409
a25f4dfa
PE
13410 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13411 * data.c (circular_list_error): Remove.
13412
14a9c8df
PE
13413 * commands.h (last_point_position, last_point_position_buffer):
13414 (last_point_position_window): Remove decls.
13415 * keyboard.c: Make these variables static.
13416
04f2d78b
CB
13417 * coding.h (coding, code_convert_region, encode_coding_gap):
13418 Remove decls.
74ab6df5
PE
13419 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13420 (iso_code_class, detect_coding, code_convert_region): Now static.
13421 (encode_coding_gap): Remove; unused.
13422
38dfbee1
PE
13423 * chartab.c (chartab_chars, chartab_bits): Now static.
13424
a2cb4e63
PE
13425 * charset.h (charset_iso_8859_1): Remove decl.
13426 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13427 Now static.
13428
127198fd
PE
13429 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13430 * ccl.c (Vccl_program_table): Now static.
13431 (check_ccl_update): Remove; unused.
13432
d85b608f
PE
13433 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13434 * category.h: ... from here.
13435 * category.c (check_category_table, set_category_set): Now static.
13436
31cd66f3
PE
13437 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13438 * lisp.h: Remove these decls.
13439
c358e587
PE
13440 * buffer.c (buffer_count): Remove unused var.
13441
e78aecca
PE
13442 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13443 so that it's not optimized away.
13444 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13445 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13446 exported only to the debugger.
13447
e192d7d3 13448 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13449 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13450
92470028
PE
13451 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13452 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13453 was inaccessible from Lisp.
13454 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13455 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13456
244ed907
PE
13457 alloc.c: Import and export fewer symbols, and remove unused items.
13458 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13459 is defined.
13460 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13461 it's not optimized away by whole-program optimization.
13462 (message_enable_multibyte, free_misc): Remove.
13463 (catchlist, handlerlist, mark_backtrace):
13464 Declare only if BYTE_MARK_STACK.
13465 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13466 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13467 (message_enable_multibyte): Remove decl.
13468 (free_misc, interval_free_list, float_block, float_block_index):
13469 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13470 (cons_free_list, last_marked_index):
13471 Now static.
13472 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13473 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13474 (mark_backtrace): Define only if BYTE_MARK_STACK.
13475 * xdisp.c (message_enable_multibyte): Now static.
13476
61c2b50e 13477 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13478 This makes it easier for human readers (and static analyzers)
13479 to see whether these variables are used from other modules.
13480 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13481 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13482 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13483 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13484 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13485 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13486 * xmenu.c, xselect.c:
13487 Declare Q* vars static if they are not used in other modules.
13488 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13489 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13490 Remove decls of unexported vars.
13491 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13492
95c82688
PE
13493 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13494
16a97296
PE
13495 Make Emacs functions such as Fatom 'static' by default.
13496 This makes it easier for human readers (and static analyzers)
13497 to see whether these functions can be called from other modules.
13498 DEFUN now defines a static function. To make the function external
13499 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13500 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13501 (Finit_image_library):
16a97296
PE
13502 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13503 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13504 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13505 Remove decls, since these functions are now static.
13506 (Funintern, Fget_internal_run_time): New decls, since these functions
13507 were already external.
95c82688 13508
16a97296
PE
13509 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13510 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13511 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13512 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13513 * keyboard.c, keymap.c, lread.c:
13514 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13515 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13516 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13517 Mark functions with DEFUE instead of DEFUN,
13518 if they are used in other modules.
13519 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13520 decls for now-static functions.
13521 * buffer.h (Fdelete_overlay): Remove decl.
13522 * callproc.c (Fgetenv_internal): Mark as internal.
13523 * composite.c (Fremove_list_of_text_properties): Remove decl.
13524 (Fcomposition_get_gstring): New forward static decl.
13525 * composite.h (Fcomposite_get_gstring): Remove decl.
13526 * dired.c (Ffile_attributes): New forward static decl.
13527 * doc.c (Fdocumntation_property): New forward static decl.
13528 * eval.c (Ffetch_bytecode): New forward static decl.
13529 (Funintern): Remove extern decl; now in .h file where it belongs.
13530 * fileio.c (Fmake_symbolic_link): New forward static decl.
13531 * image.c (Finit_image_library): New forward static decl.
13532 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13533 * intervals.h (Fprevious_property_change):
13534 (Fremove_list_of_text_properties): Remove decls.
13535 * keyboard.c (Fthis_command_keys): Remove decl.
13536 (Fcommand_execute): New forward static decl.
13537 * keymap.c (Flookup_key): New forward static decl.
13538 (Fcopy_keymap): Now static.
13539 * keymap.h (Flookup_key): Remove decl.
13540 * process.c (Fget_process): New forward static decl.
13541 (Fprocess_datagram_address): Mark as internal.
13542 * syntax.c (Fsyntax_table_p): New forward static decl.
13543 (skip_chars): Remove duplicate decl.
13544 * textprop.c (Fprevious_property_change): New forward static decl.
13545 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13546 Now internal.
13547 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13548 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13549
785bbd42
PE
13550 * editfns.c (Fformat): Remove unreachable code.
13551
8b913b57
AS
135522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13553
13554 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13555 change. (Bug#8496)
13556
a6744a35
EZ
135572011-04-13 Eli Zaretskii <eliz@gnu.org>
13558
13559 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13560 when at ZV. (Bug#8487)
13561
e7974947
AS
135622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13563
baad03f0
AS
13564 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13565 (Bug#8437)
13566 * keyboard.c (parse_tool_bar_item): Likewise.
13567 * sound.c (sound_cleanup, alsa_close): Likewise.
13568 * termcap.c (tgetent): Likewise.
13569 * xfns.c (x_default_font_parameter): Likewise.
13570 * xsettings.c (read_and_apply_settings): Likewise.
13571
e7974947
AS
13572 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13573 (overrun_check_free): Protoize.
13574
28272684
PE
135752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13576
13577 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13578 since callers should never pass a negative size.
13579 Change the signature to match that of plain 'read' and 'write'; see
13580 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13581 * lisp.h: Update prototypes of emacs_write and emacs_read.
13582
11997c76
EZ
135832011-04-11 Eli Zaretskii <eliz@gnu.org>
13584
13585 * xdisp.c (redisplay_window): Don't try to determine the character
13586 position of the scroll margin if the window start point w->startp
e896f03c 13587 is outside the buffer's accessible region. (Bug#8468)
11997c76 13588
8a2cbd72
EZ
135892011-04-10 Eli Zaretskii <eliz@gnu.org>
13590
13591 Fix write-region and its subroutines for buffers > 2GB.
13592 * fileio.c (a_write, e_write): Modify declaration of arguments and
13593 local variables to support buffers larger than 2GB.
13594 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13595
13596 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13597 argument, local variables, and return value.
13598
13599 * lisp.h: Update prototypes of emacs_write and emacs_read.
13600
13601 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13602
4073e537 136032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13604
1ebfdcb6
PE
13605 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13606
b2ded58d
PE
13607 Fix more problems found by GCC 4.6.0's static checks.
13608
7d66342c
PE
13609 * xdisp.c (vmessage): Use a better test for character truncation.
13610
bbf47d44
PE
13611 * charset.c (load_charset_map): <, not <=, for optimization,
13612 and to avoid potential problems with integer overflow.
9248994d 13613 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13614 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13615 * editfns.c (Fformat): Likewise.
1e69125e 13616 * syntax.c (skip_chars): Likewise.
3befa583 13617
e3019616
PE
13618 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13619 This also lets GCC 4.6.0 generate slightly better loop code.
13620
becfa255
PE
13621 * callint.c (Fcall_interactively): <, not <=, for optimization.
13622 (Fcall_interactively): Count the number of arguments produced,
13623 not the number of arguments given. This is simpler and lets GCC
13624 4.6.0 generate slightly better code.
13625
dae0cd48
PE
13626 * ftfont.c: Distingish more carefully between FcChar8 and char.
13627 The previous code passed unsigned char * to a functions like
13628 strlen and xstrcasecmp that expect char *, which does not
13629 conform to the C standard.
13630 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13631 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13632 char * when the C standard requires it.
13633
76032d70
PE
13634 * keyboard.c (read_char): Remove unused var.
13635
eb3f1cc8
PE
13636 * eval.c: Port to Windows vsnprintf (Bug#8435).
13637 Include <limits.h>.
13638 (SIZE_MAX): Define if the headers do not.
13639 (verror): Do not give up if vsnprintf returns a negative count.
13640 Instead, grow the buffer. This ports to Windows vsnprintf, which
13641 does not conform to C99. Problem reported by Eli Zaretskii.
13642 Also, simplify the allocation scheme, by avoiding the need for
13643 calling realloc, and removing the ALLOCATED variable.
13644
70476b54
PE
13645 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13646
12020a9e
PE
13647 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13648 But keep the doprint source code for now, as we might revamp it
13649 and use it again (Bug#8435).
ea6c7ae6
PE
13650 * lisp.h (doprnt): Remove.
13651 * Makefile.in (base_obj): Remove doprnt.o.
13652 * deps.mk (doprnt.o): Remove.
13653
5fdb398c
PE
13654 error: Print 32- and 64-bit integers portably (Bug#8435).
13655 Without this change, on typical 64-bit hosts error ("...%d...", N)
13656 was used to print both 32- and 64-bit integers N, which relied on
13657 undefined behavior.
61bdb816 13658 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13659 * lisp.h (error, verror): Mark as printf-like functions.
13660 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13661 Report overflow in size calculations when allocating printf buffer.
13662 Do not truncate output string at its first null byte.
13663 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13664 Truncate the output at a character boundary, since vsnprintf does not
13665 do that.
13666 * charset.c (check_iso_charset_parameter): Convert internal
13667 character to string before calling 'error', since %c now has the
13668 printf meaning.
13669 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13670 overflow when computing char to be passed to 'error'. Do not
13671 pass Lisp_Object to 'error'; pass the integer instead.
13672 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13673 formatted with plain %d.
13674
b189fa66
PE
13675 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13676
bff87ef0
PE
13677 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13678
7e2cac20
PE
13679 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13680
ce4d90b5
PE
13681 * xterm.c (x_catch_errors): Remove duplicate declaration.
13682
266c9547
PE
13683 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13684
79c49ad2
PE
13685 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13686
368f4090
JM
136872011-04-10 Jim Meyering <meyering@redhat.com>
13688
13689 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13690 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13691 return ssize_t not "int", and use size_t as the buffer length.
13692 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13693 * gnutls.h: Update declarations.
13694 * process.c (read_process_output): Use ssize_t, to match.
13695 (send_process): Likewise.
13696
a32d4040
CY
136972011-04-09 Chong Yidong <cyd@stupidchicken.com>
13698
13699 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13700
8546720e 137012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13702
04f2d78b
CB
13703 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13704 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13705
8546720e
GM
13706 * xterm.c (handle_one_xevent):
13707 * xmenu.c (create_and_show_popup_menu):
13708 * xselect.c (x_decline_selection_request)
13709 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13710
0a2f5c1a 137112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13712
13713 Fix some uses of `int' instead of EMACS_INT.
13714 * search.c (string_match_1, fast_string_match)
13715 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13716 (scan_buffer, find_next_newline_no_quit)
13717 (find_before_next_newline, search_command, Freplace_match)
13718 (Fmatch_data): Make some `int' variables be EMACS_INT.
13719
13720 * xdisp.c (display_count_lines): 3rd argument and return value now
13721 EMACS_INT. All callers changed.
13722 (pint2hrstr): Last argument is now EMACS_INT.
13723
13724 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13725 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13726 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13727 (decode_coding_utf_16, decode_coding_emacs_mule)
13728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13729 (decode_coding_ccl, decode_coding_charset)
13730 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13731 (decode_coding_iso_2022, decode_coding_emacs_mule)
13732 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13733 <char_offset, last_offset>: Declare EMACS_INT.
13734 (encode_coding_utf_8, encode_coding_utf_16)
13735 (encode_coding_emacs_mule, encode_invocation_designation)
13736 (encode_designation_at_bol, encode_coding_iso_2022)
13737 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13738 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13739 Declare EMACS_INT.
13740 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13741 (encode_invocation_designation): Last argument P_NCHARS is now
13742 EMACS_INT.
13743 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13744 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13745
13746 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13747 All users changed.
13748
13749 * ccl.c (Fccl_execute_on_string): Declare some variables
13750 EMACS_INT.
13751
8546720e 137522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13753
13754 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13755
4e19a977
CS
137562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13757
13758 * process.c (Fformat_network_address): Doc fix.
13759
87302331
R
137602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13761
ee7683eb 13762 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13763
cbb59342
CY
137642011-04-08 Chong Yidong <cyd@stupidchicken.com>
13765
13766 * keyboard.c (read_char): Call Lisp function help-form-show,
13767 instead of using internal_with_output_to_temp_buffer.
13768 (Qhelp_form_show): New var.
e0d38eeb 13769 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13770
13771 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13772
13773 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13774
e67a13ab
CY
137752011-04-06 Chong Yidong <cyd@stupidchicken.com>
13776
04f2d78b
CB
13777 * process.c (Flist_processes): Remove to Lisp.
13778 (list_processes_1): Delete.
e67a13ab 13779
973f782d
EZ
137802011-04-06 Eli Zaretskii <eliz@gnu.org>
13781
7c106b1e
EZ
13782 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13783
973f782d
EZ
13784 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13785
41cf7d1a 137862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13787
ca23cc88
PE
13788 Fix more problems found by GCC 4.6.0's static checks.
13789
f390e2d5
PE
13790 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13791
42eea0d0
PE
13792 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13793
b69769da 13794 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13795
f9541e84
PE
13796 * xdisp.c (vmessage): Mark as a printf-like function.
13797
13841b55
PE
13798 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13799
c136c10f
PE
13800 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13801
5e2d4a30
PE
13802 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13803 printf-like functions.
13804 (tiff_load): Add casts to remove these marks before passing them
13805 to system-supplied API.
13806
583f48b9
PE
13807 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13808
b25d760e
PE
13809 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13810 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13811 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13812 directly, rather than having caller test rule sign. This avoids
13813 some unnecessary tests.
13814 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13815 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13816 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13817
bc7b6697 13818 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13819 (xfont_open): Avoid unnecessary tests.
bc7b6697 13820
27ccc379
PE
13821 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13822
dcd5c89a
PE
13823 * composite.h, composite.c (composition_gstring_put_cache):
13824 Use EMACS_INT, not int, for length.
13825
b13a45c6
PE
13826 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13827 breaking out part of COMPOSITION_DECODE_RULE.
13828 (COMPOSITION_DECODE_RULE): Use it.
13829 * composite.c (get_composition_id): Remove unused local vars,
13830 by using the new macro.
13831
1e792e4d
PE
13832 * textprop.c (set_text_properties_1): Change while to do-while,
13833 since the condition is always true at first.
13834
dc6c6455 13835 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13836 (interval_deletion_adjustment): Return unsigned value.
13837 All uses changed.
dc6c6455 13838
aba7731a
PE
13839 * process.c (list_processes_1, create_pty, read_process_output):
13840 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13841 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13842 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13843 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13844 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13845
fdfc4bf3
PE
13846 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13847
fca8fe46 13848 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13849 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13850
06a0259a 13851 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13852 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13853 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13854
e7b9e80f
PE
13855 * print.c (print_error_message): Avoid int overflow.
13856
56201685
PE
13857 * font.c (font_list_entities): Redo for clarity,
13858 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13859
78834453 13860 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13861 (font_score): Avoid potential overflow in diff calculation.
78834453 13862
0bc0b309 13863 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13864 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13865
e610eaca
PE
13866 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13867
b895abce
PE
13868 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13869 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13870 can always succeed if overflow has undefined behavior.
13871
1f1d9321 13872 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13873 (wordify): Omit three unnecessary tests.
1f1d9321 13874
c59478bc
PE
13875 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13876 All callers changed. This avoids the need for an unused var.
13877
79b73827
PE
13878 * casefiddle.c (casify_region): Remove var that is set but not used.
13879
a4db5dfe
PE
13880 * dired.c (file_name_completion): Remove var that is set but not used.
13881
43aae36e
PE
13882 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13883
2a47c44d 13884 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13885 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13886
a37c69bf
PE
13887 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13888 Check for integer overflow on size calculations.
13889
328ab8e7
PE
13890 * buffer.c (Fprevious_overlay_change): Remove var that is set
13891 but not used.
13892
e5a2a5cb
PE
13893 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13894 Remove vars that are set but not used.
8d84a6eb 13895 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13896 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13897
a60e5f68
PE
13898 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13899
f661cb61 13900 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13901 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13902
f0397f5a
PE
13903 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13904 that are set but not used.
13905
8664db06 13906 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13907 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13908
6abdaa4a
PE
13909 * xselect.c (x_get_local_selection, x_handle_property_notify):
13910 Remove vars that are set but not used.
13911
0ce7538d 13912 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13913 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13914
9ae848fc
PE
13915 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13916 Remove var that is set but not used.
0b918413
PE
13917 (scroll_bar_windows_size): Now size_t, not int.
13918 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13919 Check for overflow.
9ae848fc 13920
a5a62657
PE
13921 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13922 (map_tty_color) [!defined MSDOS]: Likewise.
13923
5c5cdd39
PE
13924 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13925
66ebf983
PE
13926 * coding.c: Remove vars that are set but not used.
13927 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13928 All callers changed.
13929 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13930 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13931 (decode_coding_charset): Remove vars that are set but not used.
13932
1be4d761
PE
13933 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13934 that is set but not used.
13935
47553fa8
PE
13936 * print.c (print_object): Remove var that is set but not used.
13937
1f7196bf 13938 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13939 The gnulib version avoids calling malloc in the usual case,
13940 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13941 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13942 * filelock.c (current_lock_owner): Likewise.
13943 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13944 * sysdep.c: Include allocator.h, careadlinkat.h.
13945 (emacs_no_realloc_allocator): New static constant.
13946 (emacs_readlink): New function.
fdb61804
PE
13947 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13948 ../lib/careadlinkat.h.
d1fdcab7 13949
f84c17c7
SM
139502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13951
13952 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13953 first non-nil return value).
13954
ef3862ad
JD
139552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13956
13957 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13958 if not defined (Bug#8403).
13959
376a7006
JB
139602011-04-02 Juanma Barranquero <lekktu@gmail.com>
13961
13962 * xdisp.c (display_count_lines): Remove parameter `start',
13963 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13964 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13965 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13966 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13967 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13968 and thereabouts. All callers changed.
13969 (get_per_char_metric): Remove parameter `f', unused since
13970 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13971
6ca3801d
JM
139722011-04-02 Jim Meyering <meyering@redhat.com>
13973
13974 do not dereference NULL upon failed strdup
13975 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13976 (ns_get_family): Likewise.
13977
d8e2b5ba
JB
139782011-04-02 Juanma Barranquero <lekktu@gmail.com>
13979
13980 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13981
8c74fcbd
JD
139822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13983
13984 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13985 later (Bug#8403).
13986
7200d79c
SM
139872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13988
03408648 13989 Add lexical binding.
7200d79c 13990
03408648
SM
13991 * window.c (Ftemp_output_buffer_show): New fun.
13992 (Fsave_window_excursion):
13993 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13994
13995 * lread.c (lisp_file_lexically_bound_p): New function.
13996 (Fload): Bind Qlexical_binding.
13997 (readevalloop): Remove `evalfun' arg.
13998 Bind Qinternal_interpreter_environment.
13999 (Feval_buffer): Bind Qlexical_binding.
14000 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14001 Mark as dynamic.
14002 (syms_of_lread): Declare `lexical-binding'.
14003
14004 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14005
14006 * keyboard.c (eval_dyn): New fun.
14007 (menu_item_eval_property): Use it.
ca105506
SM
14008
14009 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14010
03408648
SM
14011 * fns.c (concat, mapcar1): Accept byte-code-functions.
14012
14013 * eval.c (Fsetq): Handle lexical vars.
14014 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14015 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14016 (FletX, Flet): Obey lexical binding.
14017 (Fcommandp): Handle closures.
14018 (Feval): New `lexical' arg.
14019 (eval_sub): New function extracted from Feval. Use it almost
14020 everywhere where Feval was used. Look up vars in lexical env.
14021 Handle closures.
14022 (Ffunctionp): Move from subr.el.
14023 (Ffuncall): Handle closures.
14024 (apply_lambda): Remove `eval_flags'.
14025 (funcall_lambda): Handle closures and new byte-code-functions.
14026 (Fspecial_variable_p): New function.
14027 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14028 but without exporting it to Lisp.
23aba0ea 14029
23aba0ea 14030 * doc.c (Fdocumentation, store_function_docstring):
03408648 14031 * data.c (Finteractive_form): Handle closures.
23aba0ea 14032
03408648
SM
14033 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14034 interactive spec.
ba83908c 14035
04f2d78b
CB
14036 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14037 New byte-codes.
03408648
SM
14038 (exec_byte_code): New function extracted from Fbyte_code to handle new
14039 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14040
03408648 14041 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14042
03408648 14043 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14044
e2abce01
JB
140452011-03-31 Juanma Barranquero <lekktu@gmail.com>
14046
14047 * xdisp.c (redisplay_internal): Fix prototype.
14048
63696a73 140492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14050
63696a73 14051 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14052 (try_scrolling): Use it when setting scroll_limit.
14053 Limit scrolling to 100 screen lines.
63696a73
EZ
14054 (redisplay_window): Even when falling back on "recentering",
14055 position point in the window according to scroll-conservatively,
14056 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14057
14058 (try_scrolling): When point is above the window, allow searching
14059 as far as scroll_max, or one screenful, to compute vertical
14060 distance from PT to the scroll margin position. This prevents
14061 try_scrolling from unnecessarily failing when
14062 scroll-conservatively is set to a value slightly larger than the
14063 window height. Clean up the case of PT below the margin at bottom
14064 of window: scroll_max can no longer be INT_MAX. When aggressive
14065 scrolling is in use, don't let point enter the opposite scroll
14066 margin as result of the scroll.
14067 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14068 threshold of 100 lines for never-recentering scrolling.
14069
e4cc2dfc
JB
140702011-03-31 Juanma Barranquero <lekktu@gmail.com>
14071
14072 * dispextern.h (move_it_by_lines):
14073 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14074 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14075 (message_log_check_duplicate): Remove parameters `prev_bol' and
14076 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14077 (redisplay_internal): Remove parameter `preserve_echo_area',
14078 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14079
14080 * indent.c (Fvertical_motion):
14081 * window.c (window_scroll_pixel_based, Frecenter):
14082 Don't pass `need_y_p' to `move_it_by_lines'.
14083
1c470562
SM
140842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14085
44f230aa
SM
14086 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14087 steal a few bits to be more compact.
14088 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14089 Remove unneeded casts.
14090
1c470562
SM
14091 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14092
888adce9
ZK
140932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14094
14095 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14096 binding" message (bug#7967).
14097
f838ed7b
PE
140982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14099
77861b95
PE
14100 Fix more problems found by GCC 4.6.0's static checks.
14101
de6dbc14
PE
14102 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14103 Remove unused local var.
14104
f838ed7b
PE
14105 * editfns.c (Fmessage_box): Remove unused local var.
14106
792c7b2b
PE
14107 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14108 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14109 Omit unused local vars.
c499e557 14110 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14111 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14112 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14113 Omit unused local var.
14114
ba0165e1
PE
14115 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14116 Don't assume string length fits in int.
32ad8845 14117 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14118 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14119
3c59b4c9
PE
14120 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14121 instead of alloca (Bug#8344).
14122
a3eed478 14123 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14124 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14125
eb4d412d
PE
14126 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14127
1658b401
PE
14128 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14129 concerns.
14130
14131 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14132
14133 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14134
9a2c6e05
PE
14135 * keyboard.c (syms_of_keyboard): Use the same style as later
14136 in this function when indexing through an array. This also
14137 works around GCC bug 48267.
14138
03d0a109
PE
14139 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14140
44f730c8
PE
14141 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14142
fe75f926
PE
14143 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14144 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14145
ffa8c828
PE
14146 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14147 This avoids undefined behavior on integer overflow, and is a bit
14148 more convenient anyway since it is compared to a size_t variable.
14149
c5101a77
PE
14150 Variadic C functions now count arguments with size_t, not int.
14151 This avoids an unnecessary limitation on 64-bit machines, which
14152 caused (substring ...) to crash on large vectors (Bug#8344).
14153 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14154 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14155 All variadic functions and their callers changed accordingly.
c5101a77
PE
14156 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14157 * data.c (arith_driver, float_arith_driver): Likewise.
14158 * editfns.c (general_insert_function): Likewise.
14159 * eval.c (struct backtrace.nargs, interactive_p)
14160 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14161 (funcall_lambda, mark_backtrace): Likewise.
14162 * fns.c (concat): Likewise.
14163 * frame.c (x_set_frame_parameters): Likewise.
14164 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14165 0 if not found, not -1. All callers changed.
14166
dd3f25f7
PE
14167 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14168 (stack_copy_size): Now size_t, not int.
14169 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14170
461c2ab9
JB
141712011-03-28 Juanma Barranquero <lekktu@gmail.com>
14172
14173 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14174 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14175 All callers changed.
14176
14177 * lisp.h (multibyte_char_to_unibyte):
14178 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14179 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14180 * character.h (CHAR_TO_BYTE8):
14181 * cmds.c (internal_self_insert):
14182 * editfns.c (general_insert_function):
14183 * keymap.c (push_key_description):
14184 * search.c (Freplace_match):
14185 * xdisp.c (message_dolog, set_message_1): All callers changed.
14186
f6d62986
SM
141872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14188
14189 * keyboard.c (safe_run_hook_funcall): New function.
14190 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14191 don't set the hook to nil, but remove the offending function instead.
14192 (Qcommand_hook_internal): Remove, unused.
14193 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14194 Vcommand_hook_internal.
14195
14196 * eval.c (enum run_hooks_condition): Remove.
14197 (funcall_nil, funcall_not): New functions.
14198 (run_hook_with_args): Call each function through a `funcall' argument.
14199 Remove `cond' argument, now redundant.
14200 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14201 (Frun_hook_with_args_until_failure): Adjust accordingly.
14202 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14203
1db5b1ad
JB
142042011-03-28 Juanma Barranquero <lekktu@gmail.com>
14205
14206 * dispextern.h (string_buffer_position): Remove declaration.
14207
14208 * print.c (strout): Remove parameter `multibyte', unused since
14209 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14210
14211 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14212 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14213 All callers changed.
14214
14215 * w32.c (_wsa_errlist): Use braces for struct initializers.
14216
14217 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14218 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14219 All callers changed.
14220 (string_buffer_position): Likewise. Also, make static (it's never
14221 used outside xdisp.c).
14222 (cursor_row_p): Remove parameter `w', unused since
14223 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14224 (decode_mode_spec): Remove parameter `precision', introduced during
14225 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14226 All callers changed.
14227
5ffb62aa
JD
142282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14229
14230 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14231
461c2ab9 142322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14233
14234 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14235 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14236 (ns_update_auto_hide_menu_bar): New functions.
14237 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14238 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14239 ns_constrain_all_frames.
14240 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14241 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14242
5c380ffb
JD
142432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14244
14245 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14246
9af30bdf
GM
142472011-03-27 Glenn Morris <rgm@gnu.org>
14248
14249 * syssignal.h: Replace RETSIGTYPE with void.
14250 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14251 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14252 Replace SIGTYPE with void everywhere.
14253 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14254 * s/template.h (SIGTYPE): Remove commented out definition.
14255
e2abce01
JB
142562011-03-26 Eli Zaretskii <eliz@gnu.org>
14257
14258 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14259 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14260
f868cd8a
JB
142612011-03-26 Juanma Barranquero <lekktu@gmail.com>
14262
59eb0929
JB
14263 * w32.c (read_unc_volume): Use parameter `henum', instead of
14264 global variable `wget_enum_handle'.
14265
14266 * keymap.c (describe_vector): Remove parameters `indices' and
14267 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14268 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14269
f868cd8a
JB
14270 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14271
14272 * keyboard.c (timer_check): Remove parameter `do_it_now',
14273 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14274 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14275 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14276
14277 * keyboard.c (read_char):
14278 * w32menu.c (w32_menu_display_help):
14279 * xmenu.c (show_help_event, menu_help_callback):
14280 Adjust calls to `show_help_echo'.
14281
14282 * gtkutil.c (xg_maybe_add_timer):
14283 * keyboard.c (readable_events):
14284 * process.c (wait_reading_process_output):
14285 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14286
14287 * insdel.c (adjust_markers_gap_motion):
14288 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14289 (gap_left, gap_right): Don't call it.
14290
2ecf6fdb
CY
142912011-03-25 Chong Yidong <cyd@stupidchicken.com>
14292
14293 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14294 incurred during fontification.
14295
6b1f9ba4
JB
142962011-03-25 Juanma Barranquero <lekktu@gmail.com>
14297
14298 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14299 (DEFVAR_PER_BUFFER): Don't pass it.
14300
14301 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14302 (scrolling_window): Don't pass it.
14303
0f4a96b5
JB
143042011-03-25 Juanma Barranquero <lekktu@gmail.com>
14305
14306 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14307
14308 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14309 and `suffix'.
14310 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14311 of variables specific to SELinux and computation of `encoded_absname'.
14312
14313 * image.c (XPutPixel): Remove unused variable `height'.
14314
14315 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14316
14317 * unexw32.c (get_section_info): Remove unused variable `section'.
14318
14319 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14320 (system_process_attributes): Remove unused variable `sess'.
14321 (sys_read): Remove unused variable `err'.
14322
14323 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14324 (w32_wnd_proc): Remove unused variable `isdead'.
14325 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14326 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14327 (x_create_tip_frame): Remove unused variable `tem'.
14328
14329 * w32inevt.c (w32_console_read_socket):
14330 Remove unused variable `no_events'.
14331
14332 * w32term.c (x_draw_composite_glyph_string_foreground):
14333 Remove unused variable `width'.
14334
1149507c
JB
143352011-03-24 Juanma Barranquero <lekktu@gmail.com>
14336
14337 * w32term.c (x_set_glyph_string_clipping):
14338 Don't pass uninitialized region to CombineRgn.
14339
9c88f339
JB
143402011-03-23 Juanma Barranquero <lekktu@gmail.com>
14341
14342 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14343 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14344 (Fx_close_connection): Remove unused variable `i'.
14345
14346 * w32font.c (w32font_draw): Return number of glyphs.
14347 (w32font_open_internal): Remove unused variable `i'.
14348 (w32font_driver): Add missing initializer.
14349
14350 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14351 (fill_in_menu): Remove unused variable `items_added'.
14352
14353 * w32term.c (last_mouse_press_frame): Remove static global variable.
14354 (w32_clip_to_row): Remove unused variable `f'.
14355 (x_delete_terminal): Remove unused variable `i'.
14356
14357 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14358 (NOTHING): Remove unused static global variable.
14359 (uniscribe_check_otf): Remove unused variable `table'.
14360 (uniscribe_font_driver): Add missing initializers.
14361
dee091a3
JD
143622011-03-23 Julien Danjou <julien@danjou.info>
14363
14364 * term.c (Fsuspend_tty, Fresume_tty):
14365 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14366 * window.c (temp_output_buffer_show):
14367 * insdel.c (signal_before_change):
14368 * frame.c (Fhandle_switch_frame):
14369 * fileio.c (Fdo_auto_save):
14370 * emacs.c (Fkill_emacs):
14371 * editfns.c (save_excursion_restore):
14372 * cmds.c (internal_self_insert):
14373 * callint.c (Fcall_interactively):
14374 * buffer.c (Fkill_all_local_variables):
14375 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14376 Use Frun_hooks.
0f4a96b5 14377 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14378 unconditionally since it does the check itself.
dee091a3 14379
2c520ab5 143802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14381
c9c49752
PE
14382 Fix more problems found by GCC 4.5.2's static checks.
14383
8abc3f12
PE
14384 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14385 the first time through the loop, since we know p0 < p1 then.
14386 This also avoids a gcc -Wstrict-overflow warning.
14387
a2d26660
PE
14388 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14389 leading to a memory leak, possible in functions like
14390 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14391 of objects (Bug#8318).
a2d26660 14392
916c72e9
PE
14393 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14394 that could (at least in theory) be that large.
14395
19ab8a18
PE
14396 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14397 This is less likely to overflow, and avoids undefined behavior if
14398 overflow does occur. All callers changed. Use strtoul to scan
14399 for the unsigned long integer.
b7cbbd6f
PE
14400 (pint2hrstr): Simplify and tune code slightly.
14401 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14402
f0641eff
PE
14403 * scroll.c (do_scrolling): Work around GCC bug 48228.
14404 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14405
7f650bb9
PE
14406 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14407 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14408 (validate_x_resource_name): Simplify count usage.
14409 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14410
37dd57d1
PE
14411 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14412 fail (Bug#8306).
81e56e61 14413
699979fc 14414 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14415
401bf9b4
PE
14416 * process.c (Fmake_network_process): Use socklen_t, not int,
14417 where POSIX says socklen_t is required in portable programs.
14418 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14419 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14420 (Fmake_network_process, server_accept_connection):
14421 (wait_reading_process_output, read_process_output):
14422 Likewise.
14423
b93aacde
PE
14424 * process.c: Rename or move locals to avoid shadowing.
14425 (list_processes_1, Fmake_network_process):
14426 (read_process_output_error_handler, exec_sentinel_error_handler):
14427 Rename or move locals.
4dc343ee 14428 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14429 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14430 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14431 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14432 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14433
af8a867c 14434 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14435 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14436 Include tparam.h instead, since it declares them.
af8a867c
PE
14437 * cm.h (PC): Remove extern decl; tparam.h now does this.
14438 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14439 * terminfo.c: Include tparam.h, to check interfaces.
14440 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14441 (tparam): Adjust signature to match interface in tparam.h;
14442 this removes some undefined behavior. Check that outstring and len
14443 are zero, which they always are with Emacs.
14444 * tparam.h (PC, BC, UP): New extern decls.
14445
0248044d 14446 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14447 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14448
8ff096c1 14449 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14450 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14451 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14452 (ftfont_list): Remove unused local.
49eaafba
PE
14453 (get_adstyle_property, ftfont_pattern_entity):
14454 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14455 Rename locals to avoid shadowing.
8ff096c1 14456
e2be39f6
PE
14457 * xfont.c (xfont_list_family): Mark var as initialized.
14458
c9735e30
PE
14459 * xml.c (make_dom): Now static.
14460
8f5201ae
PE
14461 * composite.c (composition_compute_stop_pos): Rename local to
14462 avoid shadowing.
b246f932
PE
14463 (composition_reseat_it): Remove unused locals.
14464 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14465 (composition_update_it): Mark var as initialized.
11b61122
PE
14466 (find_automatic_composition): Mark vars as initialized,
14467 with a FIXME (Bug#8290).
8f5201ae 14468
760fbc2c
PE
14469 character.h: Rename locals to avoid shadowing.
14470 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14471 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14472 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14473 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14474 to avoid shadowing.
14475
ff08eb85
PE
14476 * textprop.c (property_change_between_p): Remove; unused.
14477
fc7bf025
PE
14478 * intervals.c (interval_start_pos): Now static.
14479
235d7abc
PE
14480 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14481
44f230aa
SM
14482 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14483 Rename locals to avoid shadowing.
3e7d6594 14484
50060332
PE
14485 * sound.c (wav_play, au_play, Fplay_sound_internal):
14486 Fix pointer signedness.
d01f234b 14487 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14488 (wav_play): Initialize a variable to 0, to prevent undefined
14489 behavior (Bug#8278).
50060332 14490
c4fc4e30
PE
14491 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14492
918436ed
PE
14493 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14494
c939f91b
PE
14495 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14496 clobbering (Bug#8298).
b9c7f648
PE
14497 * sysdep.c (sys_subshell): Likewise.
14498 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14499
6bd8c144
PE
14500 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14501 This should get cleaned up, so that child_setup has the
14502 same signature on all platforms.
14503
7710357c 14504 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14505 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14506
c59da222
CY
145072011-03-22 Chong Yidong <cyd@stupidchicken.com>
14508
14509 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14510 not to be necessary, and produces flickering.
14511
66b87493
GM
145122011-03-20 Glenn Morris <rgm@gnu.org>
14513
14514 * config.in: Remove file.
14515
45b6f6d5
JB
145162011-03-20 Juanma Barranquero <lekktu@gmail.com>
14517
14518 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14519 are now in src/globals.h.
14520 (syms_of_minibuf): Remove spurious & from previous change.
14521
cd394be1 145222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14523
14524 * minibuf.c (completing-read-function): New variable.
14525 (completing-read-default): Rename from completing-read.
14526 (completing-read): Call completing-read-function.
14527
b14e3e21
CY
145282011-03-19 Juanma Barranquero <lekktu@gmail.com>
14529
14530 * xfaces.c (Fx_load_color_file):
14531 Read color file from absolute filename (bug#8250).
14532
f2b726e6
JB
145332011-03-19 Juanma Barranquero <lekktu@gmail.com>
14534
14535 * makefile.w32-in: Update dependencies.
14536
09f6ff02
EZ
145372011-03-17 Eli Zaretskii <eliz@gnu.org>
14538
14539 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14540
29a6015a
PE
145412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14542
a3a6c54e
PE
14543 Fix more problems found by GCC 4.5.2's static checks.
14544
b766f867
PE
14545 * process.c (make_serial_process_unwind, send_process_trap):
14546 (sigchld_handler): Now static.
14547
be02381c
PE
14548 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14549 That way, the code declares only the vars that it needs.
14550 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14551 * s/cygwin.h (PTY_ITERATION): Likewise.
14552 * s/darwin.h (PTY_ITERATION): Likewise.
14553 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14554
57048744
PE
14555 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14556 * process.c (allocate_pty): Don't declare stb unless it's needed.
14557
7914961c 14558 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14559 (CONSTANTLIM): Remove; unused.
14560 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14561 Define only if needed.
7914961c 14562
b3967b18
PE
14563 * unexelf.c (unexec): Name an expression,
14564 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14565 Use a different way to cause a compilation error if anyone uses
14566 n rather than nn, a way that does not involve shadowing.
73366a00 14567 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14568
29a6015a
PE
14569 * deps.mk (unexalpha.o): Remove; unused.
14570
43cfc33e 14571 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14572 * unexec.h: New file.
ce701a33
PE
14573 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14574 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14575 Depend on unexec.h.
14576 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14577 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14578 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14579 Change as necessary to match prototype in unexec.h.
ce701a33 14580
01f44d5a
PE
14581 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14582 shadowing.
4f63c6bb 14583 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14584
a6670b0b
PE
14585 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14586 Rename locals to avoid shadowing.
14587
cef2010d 14588 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14589 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14590
d4d7173a
PE
14591 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14592
f08b802a
PE
14593 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14594 warning when compiling print.c.
14595
3ddb0639
PE
14596 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14597 instead of using an uninitialized var.
5ad03b97 14598 (font_sort_entities): Mark var as initialized.
3ddb0639 14599
170a2692
PE
14600 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14601
e663c700
PE
14602 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14603 pointers to constants.
89bc529a 14604 (font_parse_fcname): Remove unused vars.
7b81e2d0 14605 (font_delete_unmatched): Now static.
ea838e10 14606 (font_get_spec): Remove; unused.
13a547c6
PE
14607 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14608 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14609 Rename or move locals to avoid shadowing.
e663c700 14610
2a80c887 14611 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14612 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14613
1384fa33 14614 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14615 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14616
8b2c52e9
PE
14617 * alloc.c (mark_backtrace): Move decl from here ...
14618 * lisp.h: ... to here, so that it can be checked.
14619
475545b5 14620 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14621 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14622 (lisp_indirect_variable): Name an expression,
14623 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14624 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14625
b1349114 14626 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14627 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14628 Use const pointer when appropriate.
b1349114 14629
a2928364
PE
14630 * lisp.h (get_system_name, get_operating_system_release):
14631 Move decls here, to check interfaces.
14632 * process.c (get_operating_system_release): Move decl to lisp.h.
14633 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14634 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14635 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14636 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14637 (Fformat_time_string, Fencode_time, Finsert_char):
14638 (Ftranslate_region_internal, Fformat):
14639 Rename or remove local vars to avoid shadowing.
9710023e 14640 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14641
a415e694
PE
14642 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14643 avoid shadowing.
14644
8ef4622d
PE
14645 * lisp.h (eassert): Check that the argument compiles, even if
14646 ENABLE_CHECKING is not defined.
14647
946f9a5b
PE
14648 * data.c (Findirect_variable): Name an expression, to avoid
14649 gcc -Wbad-function-cast warning.
112396d6 14650 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14651 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14652 (Fmake_variable_buffer_local, Fmake_local_variable):
14653 Mark variables as initialized.
52746918 14654 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14655
e5aab7e7 14656 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14657 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14658 Rename locals to avoid shadowing.
dff45157
PE
14659 (mark_stack): Move local variables into the #ifdef region where
14660 they're used.
7bc26fdb
PE
14661 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14662 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14663 needed otherwise.
14664 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14665 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14666 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14667
e5aab7e7
PE
14668 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14669 avoids undefined behavior in theory.
14670
4da60324
PE
14671 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14672
88043301
PE
14673 Use functions, not macros, for up- and down-casing (Bug#8254).
14674 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14675 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14676 to use the following functions instead of these macros.
14677 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14678 EMACS_INT, since callers assume the returned value fits in int.
14679 (upcase1): Likewise, for UPCASE_TABLE.
14680 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14681 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14682 the race-condition problem in the old DOWNCASE.
88043301 14683
19ed5445
PE
14684 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14685 Rename locals to avoid shadowing.
14686 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14687 (regex_compile, re_search_2, re_match_2_internal):
14688 Remove unused local vars.
952db0d7
PE
14689 (FREE_VAR): Rewrite so as not to use empty "else",
14690 which gcc can warn about.
da053e48 14691 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14692 (RETALLOC_IF): Define only if needed.
14693 (WORDCHAR_P): Likewise. This one is never needed, but is used
14694 only in a comment talking about a compiler bug, so put inside
14695 the #if 0 of that comment.
14696 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14697 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14698 Remove; unused.
19ed5445 14699
1f3561e4 14700 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14701 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14702 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14703
ded6f8f7
PE
14704 * search.c (simple_search): Remove unused var.
14705
dbd37a95
PE
14706 * dired.c (compile_pattern): Move decl from here ...
14707 * lisp.h: ... to here, so that it can be checked.
14708 (struct re_registers): New forward decl.
14709
7e47afad
PE
14710 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14711
85f24f61
PE
14712 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14713 All uses changed.
14714 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14715 Rename locals to avoid shadowing.
5671df8f 14716 (Fvertical_motion): Mark locals as initialized.
85f24f61 14717
181aa2be 14718 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14719 (casify_region): Mark local as initialized.
181aa2be 14720
930d429c
PE
14721 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14722
7082eac6
PE
14723 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14724 New macros, so that the caller can use some names other than
14725 gcpro1, gcpro2, etc.
14726 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14727 of the new macros.
14728 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14729 argument, for consistency with GCPRO2_VAR, etc: it is now the
14730 prefix of the variable, not the variable itself. All uses
14731 changed.
38b2c076
PE
14732 * dired.c (directory_files_internal, file_name_completion):
14733 Rename locals to avoid shadowing.
14734
15206ed9
PE
14735 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14736 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14737 dired.c's scmp function, had undefined behavior.
14738 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14739 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14740 * buffer.h: ... to here, because these macros use current_buffer,
14741 and the new implementation with inline functions needs to have
14742 current_buffer in scope now, rather than later when the macros
14743 are used.
14744 (downcase, upcase1): New static inline functions.
14745 (DOWNCASE, UPCASE1): Reimplement using these functions.
14746 This avoids undefined behavior in expressions like
14747 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14748 from race conditions in accessing the global variables
14749 case_temp1 and case_temp2.
14750 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14751 * lisp.h (case_temp1, case_temp2): Remove their decls.
14752 * character.h (ASCII_CHAR_P): Move from here ...
14753 * lisp.h: ... to here, so that the inline functions mentioned
14754 above can use them.
14755
4a6bea26
PE
14756 * dired.c (directory_files_internal_unwind): Now static.
14757
f14b7e14
PE
14758 * fileio.c (file_name_as_directory, directory_file_name):
14759 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14760 Now static.
2893f146
PE
14761 (file_name_as_directory): Use const pointers when appropriate.
14762 (Fexpand_file_name): Likewise. In particular, newdir might
14763 point at constant storage, so make it a const pointer.
fd4ead52 14764 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14765 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14766 signedness issues.
f839df0c
PE
14767 (Fset_file_times, Finsert_file_contents, auto_save_error):
14768 Rename locals to avoid shadowing.
f14b7e14 14769
5716756e 14770 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14771 (Ftry_completion, Fall_completions): Rename or remove locals
14772 to avoid shadowing.
5716756e 14773
b4c3046a
PE
14774 * marker.c (bytepos_to_charpos): Remove; unused.
14775
b45db522
PE
14776 * lisp.h (verify_bytepos, count_markers): New decls,
14777 so that gcc does not warn that these functions aren't declared.
14778
85876d07
PE
14779 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14780 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14781 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14782 (copy_text): Remove unused local var.
85876d07 14783
03d78a21 14784 * filelock.c (within_one_second): Now static.
b3dd38ab 14785 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14786
5df8f01b
PE
14787 * buffer.c (fix_overlays_before): Mark locals as initialized.
14788 (fix_start_end_in_overlays): Likewise. This function should be
14789 simplified by using pointers-to-pointers, but that's a different
14790 matter.
b1d876f1 14791 (switch_to_buffer_1): Now static.
8f54f30a
PE
14792 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14793 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14794
a70072c9 14795 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14796 Fix pointer signedness issue.
edced198
PE
14797 (sys_subshell): Mark local as volatile if checking for lint,
14798 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14799 (MAXPATHLEN): Define only if needed.
a70072c9 14800
a0977c44
PE
14801 * process.c (serial_open, serial_configure): Move decls from here ...
14802 * systty.h: ... to here, so that they can be checked.
14803
a884fdcc
PE
14804 * fns.c (get_random, seed_random): Move extern decls from here ...
14805 * lisp.h: ... to here, so that they can be checked.
14806
604efe86 14807 * sysdep.c (reset_io): Now static.
b8950c94 14808 (wait_for_termination_signal): Remove; unused.
604efe86 14809
38fc62d9
PE
14810 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14811 (copy_keymap_item, append_key, push_text_char_description):
14812 Now static.
1004a21a 14813 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14814 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14815 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14816 (describe_map_tree):
14817 Rename locals to avoid shadowing.
38fc62d9 14818
2f2650da
PE
14819 * keyboard.c: Declare functions static if they are not used elsewhere.
14820 (echo_char, echo_dash, cmd_error, top_level_2):
14821 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14822 (read_char, kbd_buffer_get_event, make_lispy_position):
14823 (make_lispy_event, make_lispy_movement, apply_modifiers):
14824 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14825 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14826 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14827 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14828 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14829
a053e86c 14830 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14831 (mark_kboards): Move decl here ...
14832 * alloc.c (mark_kboards): ... from here.
a053e86c 14833
4752793e
PE
14834 * lisp.h (force_auto_save_soon): New decl.
14835
74f10ca7 14836 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14837 (DEFINE_DUMMY_FUNCTION): New macro.
14838 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14839 Use it.
c03cd23f
PE
14840 (main): Add casts to avoid warnings
14841 if GCC considers string literals to be constants.
74f10ca7 14842
022e70d4
PE
14843 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14844
59d6fe83
PE
14845 * dbusbind.c: Pointer signedness fixes.
14846 (xd_signature, xd_append_arg, xd_initialize):
14847 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14848 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14849 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14850 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14851
78320123
PE
14852 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14853 if GCC considers string literals to be constants.
49cebcca 14854 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14855
35ac2a97
SM
148562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14857
fb103ca9
SM
14858 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14859 (print_preprocess, print_object): New macro to fix last change.
14860
35ac2a97
SM
14861 * print.c (print_preprocess): Don't forget font objects.
14862
62973b41
JB
148632011-03-16 Juanma Barranquero <lekktu@gmail.com>
14864
14865 * emacs.c (USAGE3): Doc fixes.
14866
0e48bb22
AS
148672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14868
14869 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14870 structure.
14871
7684e57b
JB
148722011-03-14 Juanma Barranquero <lekktu@gmail.com>
14873
14874 * lisp.h (VWindow_system, Qfile_name_history):
14875 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14876 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14877 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14878
14879 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14880 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14881
14882 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14883 * w32console.c (detect_input_pending, read_input_pending)
14884 (encode_terminal_code):
14885 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14886 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14887 (w32_system_caret_y, Qfile_name_history):
14888 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14889 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14890 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14891 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14892 * w32proc.c (Qlocal, report_file_error):
14893 * w32term.c (Vwindow_system, updating_frame):
14894 * w32uniscribe.c (initialized, uniscribe_font_driver):
14895 Remove unneeded extern declarations.
14896
2aa46d6c
CY
148972011-03-14 Chong Yidong <cyd@stupidchicken.com>
14898
c96bbc66 14899 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14900
cffc6f3b
CY
149012011-03-13 Chong Yidong <cyd@stupidchicken.com>
14902
14903 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14904 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14905 These macros can no longer be used for assignment.
14906
44f230aa
SM
14907 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14908 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14909 (record_buffer_markers, fetch_buffer_markers): New functions for
14910 recording and fetching special buffer markers.
14911 (set_buffer_internal_1, set_buffer_temp): Use them.
14912
14913 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14914
14915 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14916
14917 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14918 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14919
14920 * xdisp.c (hscroll_window_tree):
14921 (reconsider_clip_changes): Use PT instead of BUF_PT.
14922
d251f04b
EZ
149232011-03-13 Eli Zaretskii <eliz@gnu.org>
14924
14925 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14926 $(EMACS_ROOT)/lib/intprops.h.
14927
f0c77cd1
PE
149282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14929
3eca4629
PE
14930 Fix more problems found by GCC 4.5.2's static checks.
14931
7c86ee98
PE
14932 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14933 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14934 (xg_free_frame_widgets): Make it clear that a local variable is
14935 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14936 (gdk_window_get_screen): Make it clear that this macro is needed
14937 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14938 (int_gtk_range_get_value): New function, which avoids a diagnostic
14939 from gcc -Wbad-function-cast.
14940 (xg_set_toolkit_scroll_bar_thumb): Use it.
14941 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14942 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14943 (get_utf8_string, xg_get_file_with_chooser):
14944 Rename locals to avoid shadowing.
14945 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14946
41729b81
PE
14947 * xgselect.c (xg_select): Remove unused var.
14948
f0c77cd1
PE
14949 * image.c (four_corners_best): Mark locals as initialized.
14950 (gif_load): Initialize transparent_p to zero (Bug#8238).
14951 Mark another local as initialized.
ec6cf4c6 14952 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14953
ce0ad53d 14954 * image.c (clear_image_cache): Now static.
d5d5a617 14955 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14956 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14957 (x_edge_detection): Remove unnecessary cast that
14958 gcc -Wbad-function-cast diagnoses.
2037898d 14959 (gif_load): Fix pointer signedness.
6ae141d6
PE
14960 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14961 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14962
33383987 149632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14964
d32df629
PE
14965 Improve quality of tests for time stamp overflow.
14966 For example, without this patch (encode-time 0 0 0 1 1
14967 1152921504606846976) returns the obviously-bogus value (-948597
14968 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14969 reports time overflow. See
14970 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14971 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14972 * editfns.c: Include limits.h and intprops.h.
14973 (TIME_T_MIN, TIME_T_MAX): New macros.
14974 (time_overflow): Move earlier, to before first use.
14975 (hi_time, lo_time): New functions, for an accurate test for
14976 out-of-range times.
14977 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14978 (Fget_internal_run_time): Don't assume time_t fits in int.
14979 (make_time): Use list2 instead of Fcons twice.
14980 (Fdecode_time): More accurate test for out-of-range times.
14981 (check_tm_member): New function.
14982 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14983 (lisp_time_argument): Don't rely on undefined left-shift and
14984 right-shift behavior when checking for time stamp overflow.
8be6f318 14985
fe31d94c
PE
14986 * editfns.c (time_overflow): New function, refactoring common code.
14987 (Fformat_time_string, Fdecode_time, Fencode_time):
14988 (Fcurrent_time_string): Use it.
14989
8be6f318
PE
14990 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14991 * dired.c (make_time): Move to ...
14992 * editfns.c (make_time): ... here.
14993 * systime.h: Note the move.
14994
09d9db2c 149952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14996
126bc0dc
YM
14997 * fringe.c (update_window_fringes): Remove unused variables.
14998
c47cbdfd
YM
14999 * unexmacosx.c (copy_data_segment): Also copy __got section.
15000 (Bug#8223)
15001
7ac80be9
EZ
150022011-03-12 Eli Zaretskii <eliz@gnu.org>
15003
c96bbc66 15004 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15005 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15006 Constify `char *' arguments and their references according to
15007 prototypes in tparam.h.
15008
ecb0f94d 15009 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15010
7ac80be9
EZ
15011 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15012 Adapt all references accordingly.
15013
15014 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15015
ef1fd07e
TT
150162011-03-11 Tom Tromey <tromey@redhat.com>
15017
15018 * buffer.c (syms_of_buffer): Remove obsolete comment.
15019
7ef4b50c
EZ
150202011-03-11 Eli Zaretskii <eliz@gnu.org>
15021
15022 * termhooks.h (encode_terminal_code): Declare prototype.
15023
15024 * msdos.c (encode_terminal_code): Don't declare prototype.
15025
15026 * term.c (encode_terminal_code): Now external again, used by
15027 w32console.c and msdos.c.
15028
44f230aa
SM
15029 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15030 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15031
4b1ec863 150322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15033
1714f52b 15034 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15035
4b1ec863
PE
15036 * fringe.c (update_window_fringes): Mark locals as initialized
15037 (Bug#8227).
15038 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15039
524c7aa6
PE
15040 * alloc.c (mark_fringe_data): Move decl from here ...
15041 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15042 to check its interface.
15043 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15044
a5c0af81 15045 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15046 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15047 (fontset_font): Mark local as initialized.
a9a06e0b 15048 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15049
b4716021
PE
15050 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15051
811e9bac 15052 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15053 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15054 (x_own_selection, Fx_disown_selection_internal): Rename locals
15055 to avoid shadowing.
15056 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15057
7e3ab302
PE
15058 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15059 so that the caller can use some name other than gcpro1.
15060 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15061 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15062 (Fx_backspace_delete_keys_p):
15063 Use them to avoid shadowing, and rename vars to avoid shadowing.
15064 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15065 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15066 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15067 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15068 Remove unused locals.
7e3ab302
PE
15069 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15070 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15071 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15072 macros.
f78faa98 15073
e2b13473
PE
15074 * xterm.h (x_mouse_leave): New decl.
15075
77f23912
PE
15076 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15077 Remove unused functions.
cdf4ba58
PE
15078 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15079 (x_calc_absolute_position): Now static.
7411c686 15080 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15081 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15082 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15083 unless they are used.
38d0b34a
PE
15084 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15085 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15086 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15087 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15088 (x_error_catcher, x_connection_closed, x_error_handler):
15089 (x_error_quitter, xembed_send_message, x_iconify_frame):
15090 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15091 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15092 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15093
44f230aa
SM
15094 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15095 Rename or move locals to avoid shadowing.
6b463e58 15096 (tty_defined_color, merge_face_heights): Now static.
5967d051 15097 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15098 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15099 does not deduce is never used uninitialized.
73719eba
PE
15100 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15101 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15102
426994c3 15103 * terminal.c (store_terminal_param): Now static.
5489860b 15104
032f1620 15105 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15106 (set_frame_menubar): Remove unused local.
d4323972 15107 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15108 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15109 since they might point to immutable storage.
281585b0
PE
15110 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15111 since it's unused otherwise.
032f1620 15112
367c19e5 15113 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15114 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15115 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15116 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15117 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15118 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15119 does not deduce are never used uninitialized.
70739cbe 15120
07b48fa9
PE
15121 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15122
8868a238 15123 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15124 * window.c (window_loop, size_window):
15125 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15126
7e5cf297 15127 * window.c (display_buffer): Now static.
d6550a9f
PE
15128 (size_window): Mark variables that gcc -Wuninitialized
15129 does not deduce are never used uninitialized.
a586633d
PE
15130 * window.h (check_all_windows): New decl, to forestall
15131 gcc -Wmissing-prototypes diagnostic.
5b555da1 15132 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15133
f6095868
PE
15134 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15135 shadowing.
15136 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15137 Include <limits.h>.
15138 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15139 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15140 (load_charset_map): Mark variables that gcc -Wuninitialized
15141 does not deduce are never used uninitialized.
53df7c11 15142 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15143
f38b440c
PE
15144 * coding.c (coding_set_source, coding_set_destination):
15145 Use "else { /* comment */ }" rather than "else /* comment */;"
15146 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15147 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15148 a block, when the outer 'i' will do.
15149 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15150 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15151 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15152 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15153 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15154 Rename locals to avoid shadowing.
15155 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15156 * coding.c (emacs_mule_char, encode_invocation_designation):
15157 Now static, since they're not used elsewhere.
413bb2db 15158 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15159 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15160 (decode_coding_emacs_mule): Mark variables that gcc
15161 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15162 (detect_coding_iso_2022): Initialize a local variable that might
15163 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15164 this initialization is needed. (Bug#8211)
5f58e762
PE
15165 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15166 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15167 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15168 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15169 Remove unused macros.
f38b440c 15170
232b38b9 15171 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15172 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15173 * character.c (string_count_byte8): Likewise.
232b38b9 15174
fb90da1b
PE
15175 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15176 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15177
fb93dbc2
PE
15178 * chartab.c (copy_sub_char_table): Now static, since it's not used
15179 elsewhere.
5c156ace
PE
15180 (sub_char_table_ref_and_range, char_table_ref_and_range):
15181 Rename locals to avoid shadowing.
bbcd0949 15182 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15183
7d3b3862 15184 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15185 (BIDI_BOB): Remove unused macro.
7d3b3862 15186
6be7d3da
PE
15187 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15188 deduce are never used uninitialized.
c2ed9c8b 15189 * term.c (encode_terminal_code): Likewise.
6be7d3da 15190
75f8807f 15191 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15192
50938595
PE
15193 * tparam.h: New file.
15194 * term.c, tparam.h: Include it.
15195 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15196 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15197 Move these decls to tparam.h, and make them agree with what
15198 is actually in tparam.c. The previous trick of using incompatible
15199 decls in different modules does not conform to the C standard.
15200 All callers of tparam changed to use tparam's actual API.
15201 * tparam.c (tparam1, tparam, tgoto):
15202 Use const pointers where appropriate.
15203
fbceeba2
PE
15204 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15205 * cm.h (struct cm): Likewise.
15206 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15207 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15208 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15209 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15210 (turn_on_face, init_tty): Likewise.
15211 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15212
7f3f1250
PE
15213 * term.c (term_mouse_position): Rename local to avoid shadowing.
15214
e6ca6543
PE
15215 * alloc.c (mark_ttys): Move decl from here ...
15216 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15217
c40f8d15
AS
152182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15219
15220 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15221
cfe0661d
JB
152222011-03-09 Juanma Barranquero <lekktu@gmail.com>
15223
15224 * search.c (compile_pattern_1): Remove argument regp, unused since
15225 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15226 (compile_pattern): Don't pass it.
15227
0afb4571
J
152282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15229
15230 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15231 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15232 for ! HAVE_GTK3.
15233 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15234
15235 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15236
15237 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15238 gdk_window_get_screen, gdk_window_get_geometry,
15239 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15240 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15241 (xg_get_pixbuf_from_pixmap): New function.
15242 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15243 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15244 Call xg_get_pixbuf_from_pixmap instead of
15245 gdk_pixbuf_get_from_drawable.
15246 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15247 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15248 (xg_check_special_colors): Use GtkStyleContext and its functions
15249 for HAVE_GTK3.
15250 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15251 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15252 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15253 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15254 Call gtk_widget_get_preferred_size.
0afb4571
J
15255 (xg_frame_resized): gdk_window_get_geometry only takes 5
15256 parameters.
44f230aa
SM
15257 (xg_win_to_widget, xg_event_is_for_menubar):
15258 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15259 (xg_set_widget_bg): New function.
15260 (delete_cb): New function.
895009e1 15261 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15262 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15263 (xg_set_background_color): Call xg_set_widget_bg.
15264 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15265 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15266 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15267 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15268 if ! HAVE_GTK3.
15269 (update_frame_tool_bar): Call gtk_widget_hide.
15270 (xg_initialize): Use GDK_KEY_g.
15271
15272 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15273 if ! HAVE_GTK3
15274 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15275
15276 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15277 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15278 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15279
1c2cc4ef
JB
152802011-03-08 Juanma Barranquero <lekktu@gmail.com>
15281
15282 * w32xfns.c (select_palette): Check success of RealizePalette against
15283 GDI_ERROR, not zero.
15284
33383987 15285See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15286
15287;; Local Variables:
15288;; coding: utf-8
aac0c6e3
MR
15289;; End:
15290
2f097256 15291 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15292
15293 This file is part of GNU Emacs.
15294
15295 GNU Emacs is free software: you can redistribute it and/or modify
15296 it under the terms of the GNU General Public License as published by
15297 the Free Software Foundation, either version 3 of the License, or
15298 (at your option) any later version.
15299
15300 GNU Emacs is distributed in the hope that it will be useful,
15301 but WITHOUT ANY WARRANTY; without even the implied warranty of
15302 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15303 GNU General Public License for more details.
15304
15305 You should have received a copy of the GNU General Public License
15306 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.