* lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d5040d2d
PE
12012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4 These macros are confusing and no longer need to be defined, as
5 the enum values now suffice. All uses replaced with definiens.
6 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
7
7f259ae6
JB
82012-07-29 Juanma Barranquero <lekktu@gmail.com>
9
10 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
11 ($(BLD)/w32console.$(O)): Update dependencies.
12
7e63e0c3
DA
132012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
14
15 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
16 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
17 time. Adjust users.
18 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
19
ffd817eb
JD
202012-07-29 Jan Djärv <jan.h.d@swipnet.se>
21
22 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
23 setting sitelisp (Bug#12010).
24
417a7a0e
EZ
252012-07-29 Eli Zaretskii <eliz@gnu.org>
26
27 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
28
29 * w32heap.c (cache_system_info):
30 * w32.c (sys_rename):
31 * w32proc.c (find_child_console, sys_kill): All users changed.
32
387d4d92
PE
332012-07-29 Paul Eggert <eggert@cs.ucla.edu>
34
35 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
36
55a6cca6
EZ
372012-07-29 Eli Zaretskii <eliz@gnu.org>
38
39 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
40
dbcf001c
DA
412012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Cleanup statistics calculation in Fgarbage_collect.
44 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
45 zombies percentage calculation. Simplify elapsed time calculation.
46
e2688e4a
DA
472012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
48
49 Generalize marker debugging code under MARKER_DEBUG and use eassert.
50 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
51 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
52 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
53 (replace_range, replace_range_2, del_range_2): Change to eassert.
54 * marker.c (byte_char_debug_check): Adjust style.
55
b46a6a83
PE
562012-07-29 Paul Eggert <eggert@cs.ucla.edu>
57
58 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
59 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
60 long-ago-commented-out code that talks about "WIN32".
61 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
62 All uses changed.
63
e32a5799
PE
642012-07-28 Paul Eggert <eggert@cs.ucla.edu>
65
66 Use Gnulib stdalign module (Bug#9772, Bug#9960).
67 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
68 Simplify by using alignof.
69 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
70 * lisp.h: Include <stdalign.h>.
71 (GCALIGNMENT): New macro and constant.
72 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
73 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
74 (stdalign): New macro, if not already defined.
75
df81cd29
EZ
762012-07-28 Eli Zaretskii <eliz@gnu.org>
77
01bd1b0d
EZ
78 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
79 * w32inevt.c: Include w32inevt.h.
80 (w32_read_console_input): New inline function, calls either
81 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
82 w32_console_unicode_input.
83 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
84 (w32_kbd_patch_key, key_event): Use the codepage returned by
85 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
86 (key_event): use uChar.UnicodeChar only if
87 w32_console_unicode_input is non-zero.
88
89 * w32console.c: Include w32heap.h.
90 <w32_console_unicode_input>: New global variable.
91 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
92 family of Windows, zero otherwise.
93
94 * w32inevt.h: Declare w32_console_unicode_input.
95
df81cd29
EZ
96 * xdisp.c (init_iterator): Don't reference tip_frame in a build
97 --without-x. (Bug#11742)
98
c20fdd9e
PE
992012-07-27 Paul Eggert <eggert@cs.ucla.edu>
100
101 Adjust GDB to reflect pvec_type changes (Bug#12036).
102 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
103 2012-07-04 changes to pseudovector representation. Problem
104 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
105
32770973 1062012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
107
108 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
109 bus address.
110 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
111
3438fe21
EZ
1122012-07-27 Eli Zaretskii <eliz@gnu.org>
113
bcfbc9de
EZ
114 * alloc.c (listn): Fix the order the arguments are consed onto the
115 list.
116
3438fe21
EZ
117 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
118 enumeration constants, as PURE and HEAP are too general, and clash
119 with other headers and sources, such as gmalloc.c and the
120 MS-Windows system headers. All users changed.
121
eeaea515
DA
1222012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Revert last save_excursion_save and save_excursion_restore changes.
125 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
126 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
127
073c88c2
DA
1282012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
129
130 Fix recently-introduced typos in Windows port.
131 Reported by Martin Rudalics <rudalics@gmx.at>.
132 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 133 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 134
4706125e
PE
1352012-07-27 Paul Eggert <eggert@cs.ucla.edu>
136
137 Improve GDB symbol export (Bug#12036).
138 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
139 arms of an 'if', not using conditional expressions; otherwise GDB
140 complains about the types in the unevaluated arm when the argument
141 is an integer literal.
142 (xgetint): Simplify expression.
143 * alloc.c (gdb_make_enums_visible): New constant. This ports to
144 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
145 Zaretskii in <http://bugs.gnu.org/12036#13>.
146 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
147 needed now that we have gdb_make_enums_visible.
148 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
149 (enum enum_USE_LSB_TAG):
150 New enum types, packaging up enums that need to be exported to GDB.
151
694b6c97
DA
1522012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Utility function to make a list from specified amount of objects.
155 * lisp.h (enum constype): New datatype.
156 (listn): New prototype.
157 * alloc.c (listn): New function.
158 (Fmemory_use_count, syms_of_alloc): Use it.
159 * buffer.c (syms_of_buffer): Likewise.
160 * callint.c (syms_of_callint): Likewise.
161 * charset.c (define_charset_internal): Likewise.
162 * coding.c (syms_of_coding): Likewise.
163 * keymap.c (syms_of_keymap): Likewise.
164 * search.c (syms_of_search): Likewise.
165 * syntax.c (syms_of_syntax): Likewise.
166 * w32.c (init_environment): Likewise.
167 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
168 * xdisp.c (syms_of_xdisp): Likewise.
169 * xfns.c (syms_of_xfns): Likewise.
170
6195f384
DA
1712012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Fast save_excursion_save and save_excursion_restore.
174 * lisp.h (struct Lisp_Excursion): New data type.
175 (PVEC_EXCURSION): New pseudovector type.
176 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
177 to deal with it. Adjust comments.
178 (init_marker, attach_marker): New prototype.
179 (unchain_marker): Adjust prototype.
180 * marker.c (attach_marker): Change to global.
181 (init_marker): New function.
182 * alloc.c (Fmake_marker, build_marker): Use it.
183 (build_marker): More easserts.
184 (mark_object): Handle struct Lisp_Excursion.
185 * editfns.c (save_excursion_save, save_excursion_restore):
186 Reimplement to use struct Lisp_Excursion. Add comments.
187
5eceb8fb
PE
1882012-07-26 Paul Eggert <eggert@cs.ucla.edu>
189
190 Fix export of symbols to GDB (Bug#12036).
191 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
192 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
193 emacs.c, as this is a more-suitable home. Had this been done earlier
194 the fix for 12036 would have avoided some of the problems noted in
195 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
196 would have been more obvious.
562157c8
PE
197 * emacs.c: Do not include <verify.h>; no longer needed.
198 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
199 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
200 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
201 Remove; now done in lisp.h.
202 * lisp.h (PUBLISH_TO_GDB): New macro.
203 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
204 (DATA_SEG_BITS): Use it.
205 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
206 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
207 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
208 not be usable in #if. This simplifies things.
209
d6749401
JB
2102012-07-26 Juanma Barranquero <lekktu@gmail.com>
211
212 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
213
1781b9e9
PE
2142012-07-26 Paul Eggert <eggert@cs.ucla.edu>
215
d89518db 216 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
217 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
218 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
219 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
220 Adjust to changes in lisp.h and emacs.c, by using
221 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
222 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
223 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
224 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
225 instead of gdb_valbits.
226 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
227 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
228 instead of gdb_array_mark_flag.
229 (xboolvector): Get size from $->size, not $->header.size.
230 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
231 (xreload, hook-run, hookpost-run): Remove.
232 * emacs.c: Include <verify.h>.
233 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
234 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
235 Remove.
236 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
237 (gdb_USE_LSB_TAG): New enum constants.
238 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
239 Also define these as enum constants, so they're visible to GDB.
240 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
241 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
242 as constants, so they're visible to GDB.
243 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
244 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
245 Now enum constants, not macros, so they're visible to GDB.
246 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
247 more convenient now. All uses changed.
248 (VALMASK) [USE_LSB_TAG]: Also define in this case.
249 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
250
3628596a
DA
2512012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
252
253 Explicitly free restriction data that are not needed anymore.
254 * editfns.c (save_restriction_restore): Free restriction data.
255
7abaf5cc
SM
2562012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
259 add argument, tune behavior, and adjust all callers.
260
71f88e00
PE
2612012-07-25 Paul Eggert <eggert@cs.ucla.edu>
262
263 Use typedef for EMACS_INT, EMACS_UINT.
264 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
265 than macros. This simplifies debugging in the usual case, since
266 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
267 and it allows expressions involving EMACS_INT casts.
268 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
269
57ec3034
JD
2702012-07-25 Jan Djärv <jan.h.d@swipnet.se>
271
272 * nsterm.m (ns_read_socket): Return early if there is a modal
273 window (Bug#12043).
274
8137e7b3
MR
2752012-07-25 Martin Rudalics <rudalics@gmx.at>
276
277 * frame.c (Fredirect_frame_focus): In doc-string don't mention
278 that FOCUS-FRAME can be omitted.
279
04e9897c
DA
2802012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Adjust buffer text indirection counters at the end of Fkill_buffer.
283 * buffer.c (Fkill_buffer): Adjust indirection counters when the
284 buffer is definitely dead. This should really fix an issue reported
285 by Christoph Scholtes again. (Bug#12007).
286 (init_buffer_once): Initialize indirection counters of
287 buffer_defaults and buffer_local_symbols (for sanity and safety).
288
8a0484e1
EZ
2892012-07-24 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (init_iterator): Don't compute dimensions of truncation
292 and continuation glyphs on tooltip frames, leave them at zero.
293 Avoids continued lines in tooltips. (Bug#11832)
294
fa691a83
DA
2952012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Simplify copy_overlay.
04e9897c 298 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
299 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
300
436bc8e0
EZ
3012012-07-23 Eli Zaretskii <eliz@gnu.org>
302
303 * print.c (print_object): Don't crash when a frame's name is nil
304 or invalid. (Bug#12025)
305
306 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
307 it signals an error when a tooltip frame is being created.
308
d7a7fda3
DA
3092012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Cleanup miscellaneous objects allocation and initialization.
312 * alloc.c (allocate_misc): Change to static. Add argument to
313 specify the subtype. Adjust comment and users.
314 (build_overlay): New function.
315 * buffer.c (copy_overlays, Fmake_overlay): Use it.
316 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
317 (allocate_misc): Remove prototype.
318 (build_overlay): Add prototype.
319
3202012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
321
322 Swap buffer text indirection counters in Fbuffer_swap_text.
323 * buffer.c (Fbuffer_swap_text): Swap indirections too.
324 This avoids crash reported by Christoph Scholtes at
325 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
326
9d7fa573
JD
3272012-07-22 Jan Djärv <jan.h.d@swipnet.se>
328
329 * nsmenu.m (Popdown_data): New struct.
330 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
331 free Popdown_data.
332 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
333 (initWithContentRect): Make imgView and contentView non-static
334 and autorelease them. Also autorelease img and matrix (Bug#12005).
335 (dealloc): Remove (Bug#12005).
336
0dd6d66d
DA
3372012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
338
339 Adjust consing_since_gc when objects are explicitly freed.
340 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
341 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
342 (free_cons, free_misc): Subtract object size from consing_since_gc.
343
d36d71df
DA
3442012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Simplify and cleanup markers positioning code.
347 * marker.c (attach_marker): More useful eassert.
348 (live_buffer, set_marker_internal): New function.
349 (Fset_marker, set_marker_restricted): Use set_marker_internal.
350 (set_marker_both, set_marker_restricted_both): Use live_buffer.
351
fb9ea40f
PE
3522012-07-22 Paul Eggert <eggert@cs.ucla.edu>
353
354 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
355 as it's limited by the amount of memory, not by INT_MAX.
356
2d5c5f7d
EZ
3572012-07-21 Eli Zaretskii <eliz@gnu.org>
358
07fb592e
EZ
359 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
360 in special-event-map. See the discussion at
361 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
362 for the reasons.
363
37a9eac8 364 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
365 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
366 Fabrice Popineau <fabrice.popineau@supelec.fr>.
367
c4328746
JD
3682012-07-21 Jan Djärv <jan.h.d@swipnet.se>
369
370 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 371 (conversationIdentifier): Return value is NSInteger.
784051c4 372 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 373
6e5d1c12
CY
3742012-07-21 Chong Yidong <cyd@gnu.org>
375
376 * window.c (decode_any_window): Signal an error if the window is
377 on a dead frame (Bug#11984).
378
9928463d
DA
3792012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
380
381 Add indirection counting to speed up Fkill_buffer.
382 * buffer.h (struct buffer): New member.
383 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
384 (Fmake_indirect_buffer): Set indirection counter to -1, increment
385 base buffer indirection counter.
386 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
387 (Fkill_buffer): Adjust indirection counters as needed, don't walk
388 through buffer list if indirection counter is 0.
389
f8643a6b
DA
3902012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Extend the value returned by Fgarbage_collect with heap statistics.
393 * alloc.c (Qheap): New symbol.
394 (syms_of_alloc): DEFSYM it.
395 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
396 (Fmemory_free): Remove.
397 (syms_of_alloc): Don't defsubr it.
398 * buffer.c (Fcompact_buffer): Remove.
399 (syms_of_buffer): Don't defsubr it.
400
dac616ff
DA
4012012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
402
403 Make maybe_gc inline.
404 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
405 * lisp.h (consing_since_gc, gc_relative_threshold)
406 (memory_full_cons_threshold): Revert declaration.
407 (maybe_gc): Remove prototype, define as inline.
408 * alloc.c: Remove old commented-out code.
409 (consing_since_gc, gc_relative_threshold)
410 (memory_full_cons_threshold): Revert to global.
411 (maybe_gc): Remove.
412
d7ea76b4
DA
4132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
414
415 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
416 * lisp.h (build_unibyte_string): New function.
417 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
418 * sysdep.c, w32fns.c, xfns.c: Use it.
419 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
420 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
421 Adjust users accordingly.
422 * font.h (font_open_by_name): Adjust prototype.
423
765e61e3
DA
4242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
425
426 Cleanup calls to Fgarbage_collect.
427 * lisp.h (maybe_gc): New prototype.
428 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
429 Remove declarations.
430 * alloc.c (maybe_gc): New function.
431 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
432 Make them static.
433 * bytecode.c (MAYBE_GC): Use maybe_gc.
434 * eval.c (eval_sub, Ffuncall): Likewise.
435 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
436 to avoid dependency from auto-save feature.
437
52b852c7
PE
4382012-07-19 Paul Eggert <eggert@cs.ucla.edu>
439
440 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
441 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
442 'for_each_per_buffer_object_at'.
443 All uses changed. It's better to use upper-case for macros that
444 cannot be implemented as functions, to give the reader a clue
445 that they're special.
446
5db81e33
SM
4472012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 * alloc.c (Fgarbage_collect): Tweak docstring.
450
5b835e1d
DA
4512012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Tweak the value returned from Fgarbage_collect again.
454 * alloc.c (Fgarbage_collect): New return value, as confirmed in
455 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
456 Adjust documentation.
457 (total_vector_bytes): Rename to total_vector_slots, adjust
458 accounting.
459 (total_free_vector_bytes): Rename to total_free_vector_slots,
460 adjust accounting.
461 (Qstring_bytes, Qvector_slots): New symbols.
462 (syms_of_alloc): DEFSYM them.
463
9cd47b72
DA
4642012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
465
466 Buffer compaction primitive which may be used from Lisp.
467 * buffer.c (compact_buffer, Fcompact_buffer): New function.
468 (syms_of_buffer): Register Fcompact_buffer.
469 * alloc.c (Fgarbage_collect): Use compact_buffer.
470 * buffer.h (compact_buffer): New prototype.
471 (struct buffer_text): New member.
472
d17337e5
DA
4732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
474
475 New macro to iterate over all buffers, miscellaneous cleanups.
476 * lisp.h (all_buffers): Remove declaration.
477 * buffer.h (all_buffers): Add declaration, with comment.
478 (for_each_buffer): New macro.
479 * alloc.c (Fgarbage_collect, mark_object): Use it.
480 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
481 (init_buffer): Likewise.
482 * data.c (Fset_default): Likewise.
483 * coding.c (code_conversion_restore): Remove redundant check
484 for dead buffer.
485 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
486
60cfd278
AS
4872012-07-18 Andreas Schwab <schwab@linux-m68k.org>
488
489 Fix bug that created negative-length intervals.
490 * intervals.c (merge_interval_right, merge_interval_left):
491 Do not zero out this interval if it is absorbed by its children,
492 as this interval's total length doesn't change in that case. See
493 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
494
d06714cb
PE
4952012-07-18 Paul Eggert <eggert@cs.ucla.edu>
496
83713154
PE
497 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
498 when invoking (make-bool-vector N t) and N is a positive
499 multiple of 8 -- the last 8 bits were mistakenly cleared.
500
d06714cb
PE
501 Remove some struct layout assumptions in bool vectors.
502 * alloc.c (bool_header_size): New constant.
503 (header_size, word_size): Move earlier, as they're now used earlier.
504 Use 'word_size' in a few more places, where it's appropriate.
505 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
506 padding before the data member of a bool vector.
507 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
508 than doing the check by hand with an abort ().
509
464d5a5e
SM
5102012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
511
5fbc0409
SM
512 * eval.c (Fdefvar): Don't check constants since we only set the var if
513 it's not yet defined anyway (bug#11904).
514
464d5a5e
SM
515 * lisp.h (last_undo_boundary): Declare new var.
516 * keyboard.c (command_loop_1): Set it.
517 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
518 were auto-added by the command loop (bug#11774).
519
8dc2e44a
AS
5202012-07-18 Andreas Schwab <schwab@linux-m68k.org>
521
522 * w32font.c (Qsymbol): Remove local definition.
523 (syms_of_w32font): Don't DEFSYM it.
524
169925ec
DA
5252012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
526
527 Fix sweep_vectors to handle large bool vectors correctly.
528 * alloc.c (sweep_vectors): Account total_vector_bytes for
529 bool vectors larger than VBLOCK_BYTES_MAX.
530
5fbfb018
CY
5312012-07-18 Chong Yidong <cyd@gnu.org>
532
533 * frame.c (x_set_frame_parameters): Revert bogus change introduced
534 in 2012-05-25 commit by Paul Eggert (Bug#11738).
535
3ab6e069
DA
5362012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Return more descriptive data from Fgarbage_collect.
539 Suggested by Stefan Monnier in
540 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
541 * alloc.c (bounded_number): New function.
542 (total_buffers, total_vectors): New variable.
543 (total_string_size): Rename to total_string_bytes, adjust users.
544 (total_vector_size): Rename to total_vector_bytes, adjust users.
545 (sweep_vectors): Account total_vectors and total_vector_bytes.
546 (Fgarbage_collect): New return value. Adjust documentation.
547 (gc_sweep): Account total_buffers.
548 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
549 (VECTOR_SIZE): Remove.
550 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
551 (Qinterval, Qmisc): New symbols.
552 (syms_of_data): Initialize them.
553 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
554 (Qcons, Qbuffer): New declarations.
555
6d02fe5b
PE
5562012-07-17 Paul Eggert <eggert@cs.ucla.edu>
557
558 * alloc.c (Fmemory_free): Account for memory-free's own storage.
559 Round up, not down. Improve doc.
560
b7ffe040
DA
5612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Restore old code in allocate_string_data to avoid Faset breakage.
564 Reported by Julien Danjou <julien@danjou.info> in
565 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
566 * alloc.c (allocate_string_data): Restore old code with minor
567 adjustments, fix comment to explain this subtle issue.
568
4dc7c8d5
SM
5692012-07-17 Eli Zaretskii <eliz@gnu.org>
570
571 Remove FILE_SYSTEM_CASE.
572 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
573
574 * fileio.c (FILE_SYSTEM_CASE): Don't define.
575 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
576 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
577 call-process-region passes it through expand-file-name.
578
579 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
580
5812012-07-17 Andreas Schwab <schwab@linux-m68k.org>
582
583 Fix crash when creating indirect buffer (Bug#11917)
584 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
585 Don't handle unbound variables specially if non-zero.
586 (Fbuffer_local_variables): Pass zero.
587 (clone_per_buffer_values): Pass non-zero.
588
5892012-07-17 Andreas Schwab <schwab@linux-m68k.org>
590
591 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
592 to make the loop interruptible.
593
5942012-07-17 Andreas Schwab <schwab@linux-m68k.org>
595
596 * gnutls.c (emacs_gnutls_handshake): Only retry if
597 GNUTLS_E_INTERRUPTED.
598
cce7fefc
DA
5992012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Cleanup and convert miscellaneous checks to eassert.
602 * alloc.c (mark_interval): Fix comment, partially rephrase
603 old comment from intervals.h (see below).
604 * intervals.c (find_interval, adjust_intervals_for_insertion)
605 (delete_interval, adjust_intervals_for_deletion)
606 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
607 Convert to eassert.
608 (adjust_intervals_for_insertion, make_new_interval):
609 Remove obsolete and unused code.
610 * intervals.h (struct interval): Remove obsolete comment.
611 * textprotp.c (erase_properties): Remove unused code.
612 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
613 (Fremove_list_of_text_properties): Convert to eassert.
614
9ea10cc3
CY
6152012-07-17 Chong Yidong <cyd@gnu.org>
616
617 * editfns.c (Finsert_char): Doc fix.
618
3900d5de
DA
6192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
620
621 Fix previous change to make Fmemory_free always accurate.
622 * alloc.c (make_interval): Update total_free_intervals.
623 (make_float): Likewise for total_free_floats.
624 (free_cons, Fcons): Likewise for total_free_conses.
625 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
626 Likewise for total_free_vector_bytes.
627 (Fmake_symbol): Likewise for total_free_symbols.
628 (bytes_free): Remove.
629
7098646f
DA
6302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Simple free memory accounting feature.
633 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
634 (sweep_vectors): Accumulate size of free vectors.
635 (Fgarbage_collect): Setup bytes_free.
636 (Fmemory_free): New function.
637 (syms_of_alloc): Register it.
638
22657b40
DA
6392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
640
641 Cleanup overlays checking.
642 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
643 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
644 eassert and OVERLAYP.
645 (sort_overlays): Change to use OVERLAYP.
646
ddfc8813
RK
6472012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
648
649 * editfns.c (Finsert_char): Make it interactive, and make the
650 second arg optional. Copy interactive spec and docstring from
651 ucs-insert.
652
7c26cf3c
PE
6532012-07-17 Paul Eggert <eggert@cs.ucla.edu>
654
655 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
656 Unlike the other wrapped functions, fabs has an unspecified
657 effect on errno.
658
5d127af9
JD
6592012-07-16 Jan Djärv <jan.h.d@swipnet.se>
660
661 * nsterm.m (keyDown): Interpret flags without left/right bits
662 as the left key (Bug#11670).
663
6a0dd1d7
DA
6642012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
665
666 Remove empty and useless init functions.
667 * lisp.h (init_character_once, init_fns, init_image)
668 (init_filelock, init_sound): Remove prototype.
669 * character.c (init_character_once): Remove.
670 * filelock.c (init_filelock): Likewise.
671 * fns.c (init_fns): Likewise.
672 * image.c (init_image): Likewise.
673 * sound.c (init_sound): Likewise.
674 * emacs.c (main): Adjust accordingly.
675
7a6136fd
DA
6762012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
677
678 * gtkutil.h: Tiny cleanups.
679 (use_old_gtk_file_dialog): Remove useless declaration.
680 (xg_uses_old_file_dialog): Add suggested const attribute.
681
ce811ad9
EZ
6822012-07-15 Eli Zaretskii <eliz@gnu.org>
683
684 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
685 (bidi_paragraph_init): Use it to limit search forward for a strong
686 directional character in abnormally large paragraphs full of
687 neutral or weak characters. (Bug#11943)
688
c9adfeaa
SF
6892012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
690
691 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
692 the toolbar (Bug#9451).
693 (xg_make_tool_item): Give the widget event box a transparent
694 background.
695
fff62aa9
DA
6962012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
697
698 Cleanup basic allocation variables and functions.
699 * alloc.c (ignore_warnings, init_intervals, init_float)
700 (init_cons, init_symbol, init_marker): Remove.
701 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
702 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
703 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
704 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
705 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
706 (staticidx, init_alloc_once, init_strings, free_ablock):
707 Remove redundant initialization.
708 * fns.c (init_weak_hash_tables): Remove.
709 * lisp.h (init_weak_hash_tables): Remove prototype.
710
9730daca
DA
7112012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
712
713 Use zero_vector where appropriate.
714 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
715 accordingly.
716 * lisp.h (zero_vector): New declaration.
717 * font.c (null_vector): Remove.
718 (syms_of_font): Remove initialization and staticpro.
719 (font_list_entities, font_find_for_lface): Change to use zero_vector.
720 * keymap.c (Faccessible_keymaps): Likewise.
721
2e2d2a13
LL
7222012-07-15 Leo Liu <sdl.web@gmail.com>
723
724 * fringe.c: Fix typo in comments.
725
cd276f6e
LL
7262012-07-14 Leo Liu <sdl.web@gmail.com>
727
728 * fringe.c: Add a new bitmap exclamation-mark.
729
5a1131d9
EZ
7302012-07-14 Eli Zaretskii <eliz@gnu.org>
731
732 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
733
734 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
735 (HAVE_MENUS): Don't define, defined by editing config.in with
736 msdos/sed2v2.inp.
737 (GMALLOC_INHIBIT_VALLOC): Don't define.
738 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
739
22e983b7
JB
7402012-07-14 Juanma Barranquero <lekktu@gmail.com>
741
742 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
743
5b3f250f
GM
7442012-07-14 Glenn Morris <rgm@gnu.org>
745
746 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
747 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
748 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
749
33d63ff4
GM
7502012-07-13 Glenn Morris <rgm@gnu.org>
751
5b633342
GM
752 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
753
33d63ff4
GM
754 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
755 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
756
b55b9f85
JD
7572012-07-13 Jan Djärv <jan.h.d@swipnet.se>
758
0dc8cf50
JD
759 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
760 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
761 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
762 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
763 where appropriate.
764 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
765 as boolean expression.
766 (x_set_window_size): Remove unused variable toolbar.
767 (ns_get_color_default, ns_mod_to_lisp): Remove.
768 (ns_mouse_position): Remove unused variables xchar and ychar.
769 (ns_compute_glyph_string_overhangs): Remove unused variable face.
770 (ns_set_vertical_scroll_bar): Remove unused variable count.
771 (ns_delete_terminal): Remove unused variable i.
772 (ns_term_init): Remove unused variables r, g and b.
773 (mouseDown): Remove unused variable window.
774 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
775 (initFrameFromEmacs): Remove unused variable vbextra.
776 (mouseEntered): Remove unused variables p and dpyinfo.
777 (mouseExited): Remove unused variables p and r.
778 (ns_define_frame_cursor, ns_clear_frame_area)
779 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
780 (menuDown): Assign [sender tag] to variable and cast the variable.
781
782 * nsterm.h (menuDown): Add id as type to argument sender.
783 (ns_display_info_for_name): Add Lisp_Object argument.
784 (ns_term_init): Add Lisp_Object argument.
785 (ns_map_event_to_object): Add void argument.
786 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
787 prototype with arguments and only declare if __OBJC__.
788 (nxatoms_of_nsselect): Add void argument.
789 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
790 (ns_alloc_autorelease_pool): Add void argument.
791 (ns_release_autorelease_pool): Add void* argument.
792 (ns_get_defaults_value): Add const char* argument.
793
794 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
795 (initFromContents): Use SSDATA where appropriate.
796 (ns_update_menubar): Add braces to ambigous if-else.
797 (initWithTitle): Put () around assignment in if statement.
798 (ns_menu_show): Remove unused variables window and keymap.
799 (update_frame_tool_bar): Remove unused variable selected_p.
800 (initWithContentRect): Remove unused variable this_cmd_name.
801
802 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
803 appropriate.
804 (setXBMColor): Remove unused variable len.
805 (setPixmapData): Put () around assignment in loop statement.
806
807 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
808 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
809 where appropriate.
810 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
811 around assignment in loop statement.
812 (nsfont_open): Remove unused variable i.
813 (nsfont_open): Remove unused variable len.
814 (nsfont_draw): Remove unused variable cs.
815
816 * nsfns.m (x_set_icon_name, ns_set_name_internal)
817 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
818 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
819 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
820 (Fns_font_name, Fns_perform_service)
821 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
822 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
823 (ns_set_name): Remove unused variable view.
824 (x_set_menu_bar_lines): Remove unused variable olines.
825 (x_set_tool_bar_lines): Remove unused variable root_window.
826 (Fns_list_colors): Put () around assignment in while statement.
827 (Fns_perform_service): Remove unused variable len.
828 (Fns_display_usable_bounds): Remove unused variable top.
829 (syms_of_nsfns): Remove unused variable i.
830
b55b9f85
JD
831 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
832 memcpy (Bug#11907).
833
ed9265fc 8342012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
835
836 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
837 and free it with DestroyExceptionInfo (Bug#11558).
838
ef099b57
JB
8392012-07-13 Juanma Barranquero <lekktu@gmail.com>
840
841 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
842 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
843 Set here, not in nt/config.nt.
844
ea814a5d
EZ
8452012-07-13 Eli Zaretskii <eliz@gnu.org>
846
847 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
848 cursor overflow into the last glyph on display line when the right
849 fringe is off. (Bug#11832)
850
1a952767
PE
8512012-07-13 Paul Eggert <eggert@cs.ucla.edu>
852
853 * xdisp.c (produce_special_glyphs): Now static.
854 * dispextern.h (produce_special_glyphs): Remove decl.
855
983188fd
GM
8562012-07-13 Glenn Morris <rgm@gnu.org>
857
32fb4bb6
GM
858 * s/bsd-common, s/cygwin.h: Remove empty files.
859 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
860
983188fd
GM
861 * s/usg5-4-common.h (USG, USG5):
862 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
863 * s/sol2-6.h (SOLARIS2):
864 * s/irix6-5.h (IRIX6_5):
865 * s/hpux10-20.h (USG, USG5, HPUX):
866 * s/gnu-linux.h (USG, GNU_LINUX):
867 * s/freebsd.h (BSD_SYSTEM):
868 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
869 * s/cygwin.h (CYGWIN):
870 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
871 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
872
d1e68667 8732012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
874
875 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 876
6de0e799
GM
8772012-07-13 Glenn Morris <rgm@gnu.org>
878
739ae010
GM
879 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
880
dbee5793
GM
881 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
882
6de0e799
GM
883 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
884 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
885
b82da769
GM
8862012-07-12 Glenn Morris <rgm@gnu.org>
887
4fae5a7a 888 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
889
890 * process.c (init_process_emacs): Rename from init_process.
891 The old name is also the name of a Mach system call.
892 * lisp.h, emacs.c: Update for this name change.
893 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
894 longer needed.
895
5a979817
EZ
8962012-07-12 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
899 memmove call that removes glyphs covered by the left truncation
900 glyph. Improve commentary.
901 (display_line): Fix display of continuation glyphs on GUI frames
902 when the right fringe is turned off and variable-size fonts are
903 used in the window. Move the code that appends a stretch glyph to
904 produce_special_glyphs, so that it could be used for truncation
905 and continuation glyphs alike.
906 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
907 glyph of a suitably computed width, to align the special glyphs at
908 the window margin. Code moved from display_line. (Bug#11832)
909
3e91a053
GM
9102012-07-12 Glenn Morris <rgm@gnu.org>
911
ba9e4b84
GM
912 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
913
914 * s/gnu-linux.h, s/hpux10-20.h:
915 Do not unconditionally define HAVE_XRMSETDATABASE.
916
3e91a053
GM
917 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
918
b300b1f4
PE
9192012-07-12 Paul Eggert <eggert@cs.ucla.edu>
920
921 Fix typos that broke OS X build.
922 Reported by Randal L. Schwartz in
923 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
924 * nsterm.m (ns_timeout): Add missing local decl.
925 (ns_get_color): snprintf -> sprintf, to fix typo.
926
6e777848
GM
9272012-07-12 Glenn Morris <rgm@gnu.org>
928
3f922c37
GM
929 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
930 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
931 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
932 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
933
0ab7b23a
GM
934 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
935 Move PTY_OPEN to configure.
936
6e777848
GM
937 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
938 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
939 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
940
4a7edc24
DA
9412012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Use empty_unibyte_string where applicable.
944 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
945 * lread.c (read1): Likewise.
946 * xsettings.c (syms_of_xsettings): Likewise.
947
308aab79
GM
9482012-07-12 Glenn Morris <rgm@gnu.org>
949
42bd1719
GM
950 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
951 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
952 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
953 * s/hpux10-20.h (RUN_TIME_REMAP):
954 * s/bsd-common.h (TABDLY): Move to configure.
955
956 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
957
958 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
959
ea0bbd17 960 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 961 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
962
963 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 964
308aab79
GM
965 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
966 * s/template.h: Move NARROWPROTO to configure.
967
ee1cf5cf
GM
9682012-07-11 Glenn Morris <rgm@gnu.org>
969
30fe9bf4
GM
970 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
971 unused since 2011-01-17 change to systty.h.
972
ee1cf5cf
GM
973 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
974 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
975 Move HAVE_PTYS and HAVE_SOCKETS to configure.
976
63e47e07
PE
9772012-07-11 Paul Eggert <eggert@cs.ucla.edu>
978
979 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
980
c43fb4c3
GM
9812012-07-11 Glenn Morris <rgm@gnu.org>
982
983 * s/darwin.h, s/gnu-linux.h, s/template.h:
984 Move INTERRUPT_INPUT to configure.
985
e8df9267
DA
9862012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
987
988 Minor adjustments to interning code.
989 * lisp.h (intern, intern_c_string): Redefine as static inline
990 wrappers for intern_1 and intern_c_string_1, respectively.
991 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
992 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
993 Vobarray checking.
e8df9267
DA
994 * font.c (font_intern_prop): Likewise. Adjust comment.
995 * w32font.c (intern_font_name): Likewise.
996
34348bd4
AS
9972012-07-11 Andreas Schwab <schwab@linux-m68k.org>
998
d96a1e0c
AS
999 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1000
34348bd4
AS
1001 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1002 of Fcar/Fcdr if possible.
1003 * font.c (check_otf_features): Likewise.
1004 * fontset.c (Fnew_fontset): Likewise.
1005 * gnutls.c (Fgnutls_boot): Likewise.
1006 * minibuf.c (read_minibuf): Likewise.
1007 * msdos.c (IT_set_frame_parameters): Likewise.
1008 * xmenu.c (Fx_popup_dialog): Likewise.
1009 * w32menu.c (Fx_popup_dialog): Likewise.
1010
c8add24e
GM
10112012-07-11 Glenn Morris <rgm@gnu.org>
1012
4b575b3c
GM
1013 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1014 since nothing has defined it on these platforms.
1015
09f4e3b0
GM
1016 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1017 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1018
172bedef
GM
1019 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1020 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1021 Move CLASH_DETECTION to configure.
1022
249685df
GM
1023 * s/gnu.h: Remove file, which is now empty.
1024
c8add24e
GM
1025 * s/gnu.h, s/gnu-linux.h:
1026 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1027
b41253a3
JW
10282012-07-11 John Wiegley <johnw@newartisans.com>
1029
1030 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1031 function attribute, so we only use it if it exists in the
1032 compiler.
1033
d923b542
DA
10342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Avoid call to strlen in fast_c_string_match_ignore_case.
1037 * search.c (fast_c_string_match_ignore_case): Change to use
1038 length argument. Adjust users accordingly.
1039 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1040
5ebbef1d
PE
10412012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1042
bb352260
PE
1043 Assume mkdir, rmdir.
1044 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1045 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1046
57054ddd
PE
1047 Assume rename.
1048 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1049
b747d3f7
PE
1050 Assume perror.
1051 * s/hpux10-20.h (HAVE_PERROR): Remove.
1052 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1053 Remove dummy definition, as this problem was obsolete long ago.
1054
5ebbef1d
PE
1055 Assume strerror.
1056 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1057
984e7f30
DA
10582012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 Avoid calls to strlen in font processing functions.
1061 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1062 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1063 users accordingly.
d923b542
DA
1064 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1065 Adjust prototypes.
1066 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1067 Change to return ptrdiff_t.
984e7f30
DA
1068 (xfont_list_pattern, xfont_match): Use length returned by
1069 xfont_decode_coding_xlfd.
1070 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1071
20e94fdd
GM
10722012-07-11 Glenn Morris <rgm@gnu.org>
1073
9d596af3
GM
1074 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1075 Move DONT_REOPEN_PTY to configure.
1076
20e94fdd
GM
1077 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1078 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1079
e99a530f
PE
10802012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1081
22ffb973
PE
1082 Remove "#define unix" that is no longer needed (Bug#11905).
1083 * s/aix4-2.h (unix): Remove; no longer needed.
1084
e9a9ae03
PE
1085 EMACS_TIME simplification (Bug#11875).
1086 This replaces macros (which typically do not work in GDB)
1087 with functions, typedefs and enums, making the code easier to debug.
1088 The functional style also makes code easier to read and maintain.
1089 * systime.h: Include <sys/time.h> on all hosts, not just if
1090 WINDOWSNT, since 'struct timeval' is needed in general.
1091 (EMACS_TIME): Now a typedef, not a macro.
1092 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1093 not macros.
1094 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1095 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1096 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1097 (EMACS_TIME_LE): Now functions, not macros.
1098 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1099 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1100 which are not functions. All uses rewritten to use:
1101 (make_emacs_time): New function.
1102 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1103 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1104 not functions. All uses rewritten to use the following, respectively:
1105 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1106 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1107 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1108 * fileio.c (Fcopy_file):
1109 * xterm.c (XTflash): Get the current time closer to when it's used.
1110 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1111
ffacb126
PE
1112 * bytecode.c (targets): Suppress -Woverride-init warnings.
1113
e99a530f
PE
1114 Simplify by avoiding confusing use of strncpy etc.
1115 * doc.c (Fsnarf_documentation):
1116 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1117 * frame.c (Fmake_terminal_frame):
1118 * gtkutil.c (get_utf8_string):
1119 * lread.c (openp):
1120 * nsmenu.m (ns_update_menubar):
1121 * regex.c (regerror):
1122 Prefer memcpy to strncpy and strncat when either will do.
1123 * fileio.c (Fsubstitute_in_file_name):
1124 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1125 (menu_separator_name_p):
1126 * nsmenu.m (ns_update_menubar):
1127 Prefer memcmp to strncmp when either will do.
1128 * nsterm.m: Include <ftoastr.h>.
1129 (ns_get_color):
1130 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1131 Prefer snprintf to strncpy.
1132 * nsterm.m (ns_term_init):
1133 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1134 * nsterm.m (ns_term_init):
1135 Avoid the need for strncpy, by using build_string or
1136 make_unibyte_string directly. Use dtoastr, not snprintf.
1137 * process.c (Fmake_network_process): Diagnose service names that
1138 are too long, rather than silently truncating them or creating
1139 non-null-terminated names.
1140 (Fnetwork_interface_info): Likewise, for interface names.
1141 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1142 Prefer sprintf to strncat.
1143 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1144 Prefer vsnprintf to vsprintf + strncpy.
1145
c59592b3
GM
11462012-07-10 Glenn Morris <rgm@gnu.org>
1147
1148 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1149 Clarify fallback case.
1150
7d7bbefd
DA
11512012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1152
1153 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1154 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1155 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1156 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1157 where argument type is known to be a Lisp_Cons.
1158
3a4c8000
TT
11592012-07-10 Tom Tromey <tromey@redhat.com>
1160
1161 * bytecode.c (BYTE_CODE_THREADED): New macro.
1162 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1163 (enum byte_code_op): New type.
1164 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1165 (exec_byte_code): Use them. Use token threading when applicable.
1166
2a0213a6
DA
11672012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 Optimize pure C strings initialization.
1170 * lisp.h (make_pure_string): Fix prototype.
1171 (build_pure_c_string): New function, defined as static inline. This
1172 provides a better opportunity to optimize away calls to strlen when
1173 the function is called with compile-time constant argument.
1174 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1175 argument, adjust users accordingly. Use build_pure_c_string where
1176 appropriate.
1177 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1178 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1179 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1180
cb1caeaf
DA
11812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Avoid calls to strlen in miscellaneous functions.
1184 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1185 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1186 * lread.c (openp): Likewise.
1187
c293e30c
DA
11882012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 Avoid calls to strlen in path processing functions.
1191 * fileio.c (file_name_as_directory): Add comment. Change to add
1192 srclen argument and return the length of result. Adjust users
1193 accordingly.
1194 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1195 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1196 users accordingly.
1197 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1198
9e059e3f
GM
11992012-07-10 Glenn Morris <rgm@gnu.org>
1200
d02eb359
GM
1201 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1202 Move PENDING_OUTPUT_COUNT definition to configure.
1203
882cf227
GM
1204 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1205 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1206 * s/gnu.h (DATA_START): Move definitions to configure.
1207
af6e839f
GM
1208 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1209 We include usg5-4-common.h, which defines them both.
1210
40289a12
GM
1211 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1212 O_RDONLY already includes it).
1213
9e059e3f
GM
1214 Stop ns builds setting the EMACSLOADPATH environment variable.
1215 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1216 Now it does not set EMACSLOADPATH, just returns the load-path string.
1217 * nsterm.h: Update accordingly.
1218 * lread.c [HAVE_NS]: Include nsterm.h.
1219 (init_lread) [HAVE_NS]: Use ns_load_path.
1220 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1221
7c4e8ec0
GM
12222012-07-09 Glenn Morris <rgm@gnu.org>
1223
d4f600ff
GM
1224 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1225 since the included bsd-common.h does so.
1226
cbb31951
GM
1227 Stop ns builds setting the EMACSPATH environment variable.
1228 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1229 (ns_init_paths): Do not set EMACSPATH.
1230 * nsterm.h (ns_exec_path): Add it.
1231 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1232 Use ns_exec_path.
1233
7c4e8ec0
GM
1234 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1235
26bccfae
PE
12362012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1237
a0bee46f
PE
1238 * process.c (wait_reading_process_output): 'waitchannels' was unset
1239 when read_kbd || !NILP (wait_for_cell); fix this.
1240
5994c183
PE
1241 Add GCC-style 'const' attribute to functions that can use it.
1242 * character.h (char_resolve_modifier_mask):
1243 * keyboard.h (make_ctrl_char):
1244 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1245 (init_character_once, next_almost_prime, init_fns, init_image)
1246 (flush_pending_output, init_sound):
1247 * mem-limits.h (start_of_data):
1248 * menu.h (finish_menu_items):
1249 Add ATTRIBUTE_CONST.
1250 * emacs.c (DEFINE_DUMMY_FUNCTION):
1251 Declare the dummy function with ATTRIBUTE_CONST.
1252 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1253 Add decls with ATTRIBUTE_CONST.
1254
26bccfae
PE
1255 Minor improvements to make_formatted_string.
1256 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1257 where int is good enough, as vsprintf returns an int.
1258 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1259
a8290ec3
DA
12602012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Use make_formatted_string to avoid double length calculation.
1263 * lisp.h (make_formatted_string): New prototype.
1264 * alloc.c (make_formatted_string): New function.
1265 * buffer.c (Fgenerate_new_buffer_name): Use it.
1266 * dbus.c (syms_of_dbusbind): Likewise.
1267 * editfns.c (Fcurrent_time_zone): Likewise.
1268 * filelock.c (get_boot_time): Likewise.
1269 * frame.c (make_terminal_frame, set_term_frame_name)
1270 (x_report_frame_params): Likewise.
1271 * image.c (gs_load): Likewise.
1272 * minibuf.c (get_minibuffer): Likewise.
1273 * msdos.c (dos_set_window_size): Likewise.
1274 * process.c (make_process): Likewise.
1275 * xdisp.c (ensure_echo_area_buffers): Likewise.
1276 * xsettings.c (apply_xft_settings): Likewise.
1277
d01ba2f1
GM
12782012-07-09 Glenn Morris <rgm@gnu.org>
1279
1280 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1281 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1282 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1283 * nsterm.h (ns_etc_directory): Add it.
1284 * callproc.c [HAVE_NS]: Include nsterm.h.
1285 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1286
f1f924b6
DA
12872012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 Move marker debugging code under MARKER_DEBUG.
1290 * marker.c (MARKER_DEBUG): Move marker debugging code under
1291 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1292 for bootstrap with --enable-checking (~3x slowdown reported
1293 by Juanma Barranquero <lekktu@gmail.com>).
1294 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1295
ab531b66
PE
12962012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1299 See <http://bugs.gnu.org/11825#29>.
1300
c4b3bc8a
EZ
13012012-07-08 Eli Zaretskii <eliz@gnu.org>
1302
1303 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1304 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1305 (display_line): Add commentary about displaying truncation glyphs
1306 on GUI frames.
1307 (produce_special_glyphs): Move here from term.c.
1308
1309 * term.c (produce_special_glyphs): Move to xdisp.c.
1310
1311 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1312 section.
c4b3bc8a 1313
b676b881
AS
13142012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1315
f17c5273
AS
1316 * xdisp.c (display_line): Avoid warning about implicit declaration
1317 of FRAME_FONT.
1318
298819b9
AS
1319 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1320
b676b881
AS
1321 * lisp.h: Remove empty conditional.
1322
6045c4fd
PE
13232012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1324
b3350bf9
PE
1325 * lread.c (load_path_check): Now static.
1326
6045c4fd
PE
1327 Fix some minor --with-ns problems found by static checking.
1328 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1329 (x_set_font) [!HAVE_X_WINDOWS]:
1330 * image.c (xpm_load_image) [HAVE_NS]:
1331 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1332 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1333 Remove unused local.
1334 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1335 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1336 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1337 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1338 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1339 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1340 Fix pointer signedness problem.
1341 * xfaces.c (FRAME_X_FONT_TABLE):
1342 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1343
929e7845
GM
13442012-07-07 Glenn Morris <rgm@gnu.org>
1345
1346 * lread.c (load_path_check): New function, split from init_lread.
1347 (init_lread): Reorganize. Motivation:
1348 If EMACSLOADPATH is set, check/warn about that rather than the
1349 defaults, which we are not going to use. Hence we can remove
1350 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1351 Don't warn if site-lisp directories are missing.
1352 If not installed, start from a blank load-path, since
1353 PATH_LOADSEARCH refers to the eventual installation directories.
1354
58dd0aa4
EZ
13552012-07-07 Eli Zaretskii <eliz@gnu.org>
1356
1357 Support truncation and continuation glyphs on GUI frames, when
1358 fringes are disabled. (Bug#11832)
1359 * xdisp.c (init_iterator): Get dimensions of truncation and
1360 continuation glyphs even if on GUI frames. Adjust
1361 it->last_visible_x on GUI frames when the left or right fringes,
1362 or both, are absent.
1363 (start_display, move_it_in_display_line_to): Handle the case of a
1364 GUI frame without a fringe to display continuation or truncation
1365 glyphs.
1366 (insert_left_trunc_glyphs): Support GUI frames: make sure
1367 truncation glyphs overwrite enough glyphs from the current line to
1368 have sufficient space in pixels.
1369 (display_line): Support truncation and continuation glyphs on GUI
1370 frames. If some spare pixels are left on the line after inserting
1371 the truncation glyphs, fill that space with a stretch glyph of a
1372 suitably computed width.
1373
1374 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1375 produce_glyphs, to support GUI sessions.
1376
31571fd7
PE
13772012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1378
5a16b9bc
PE
1379 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1380
f3047c75
PE
1381 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1382
31571fd7
PE
1383 Do not require float-time's arg to fit in time_t (Bug#11825).
1384 This works better on hosts where time_t is unsigned, and where
1385 float-time is applied to the (negative) difference between two times.
1386 * editfns.c (decode_time_components): Last arg is now double *,
1387 not int *, and means to store all the result as a double, without
1388 worrying about whether the seconds part fits in time_t.
1389 All callers changed.
1390 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1391 All callers changed.
1392 (Ffloat_time): Do not fail merely because the specified time falls
1393 outside of time_t range.
1394
4516fbef
GM
13952012-07-07 Glenn Morris <rgm@gnu.org>
1396
1397 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1398 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1399 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1400
07adc2c6
JB
14012012-07-07 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1404 Update dependencies.
1405
1406 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1407
fd573f31
PE
14082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1409
fee5959d
PE
1410 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1411 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1412 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1413 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1414 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1415 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1416
fd573f31
PE
1417 * xfont.c (compare_font_names): Redo to omit the need for casts.
1418
ddadbc0e
AS
14192012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1420
fca8d6b6
AS
1421 * xfns.c (Fx_change_window_property): Doc fix.
1422 * w32fns.c (Fx_change_window_property): Doc fix.
1423
ddadbc0e
AS
1424 * w32fns.c (Fx_window_property): Accept the same arguments as the
1425 X Windows version. Doc fix.
1426 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1427
ed9265fc 14282012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1429 Eli Zaretskii <eliz@gnu.org>
1430
1431 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1432 Windows-specific code from nt/config.nt moved here.
1433 Obsolete settings removed.
1434
216ee680
PE
14352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * process.c: Avoid unnecessary calls to gettime.
1438 (wait_reading_process_output): Don't get the time of day
1439 when gobbling data immediately and not waiting, as there's no need
1440 for it in that case. This removes a FIXME.
1441
bdd091e4
JD
14422012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1443
1444 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1445 is defined (Bug#11768).
1446
9d44f8ce
DA
14472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 Fix marker debugging code.
1450 * marker.c (byte_char_debug_check): Do not perform the check
1451 if buffer is not multibyte.
090bd7cb
JB
1452 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1453 Call byte_char_debug_check with correct arguments.
9d44f8ce 1454
90fc4786
DA
14552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1458 * marker.c (byte_char_debug_check, count_markers):
1459 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1460 (byte_debug_flag): Remove.
1461 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1462 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1463
7b7ae965
DA
14642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1465
4e57b342
DA
1466 Avoid code repetition in marker-related functions.
1467 * marker.c (attach_marker): New function.
1468 (Fset_marker, set_marker_restricted, set_marker_both)
1469 (set_marker_restricted_both): Use it.
1470 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1471 Consistently rename charno to charpos.
1472 (marker_position): Add eassert.
1473 (marker_byte_position): Convert to eassert.
1474
14752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1478 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1479 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1480
657924ff
DA
14812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 Introduce fast path for the widely used marker operation.
1484 * alloc.c (build_marker): New function.
1485 * lisp.h (build_marker): New prototype.
1486 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1487 * composite.c (autocmp_chars): Likewise.
1488 * editfns.c (buildmark): Remove.
1489 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1490 (save_restriction_save): Use build_marker.
1491 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1492 * window.c (save_window_save): Likewise.
1493
041a49a6
DA
14942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1495
1496 Do not use Fdelete_overlay in delete_all_overlays
1497 to avoid redundant calls to unchain_overlay.
1498 * buffer.c (drop_overlay): New function.
1499 (delete_all_overlays, Fdelete_overlay): Use it.
1500 * minibuf.c (get_minibuffer): Fix comment.
1501
7dca65a4
PE
15022012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 Port to OpenBSD 5.1 amd64.
1505 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1506 This is needed for OpenBSD, and should be harmless on all BSD systems.
1507 Also, include <sys/sysctl.h>, as it should be available on all
1508 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1509 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1510 use p_pid member, not kp_proc.pid.
1511
8eb876e2
GM
15122012-07-06 Glenn Morris <rgm@gnu.org>
1513
1514 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1515
38182d90
PE
15162012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 More xmalloc and related cleanup.
1519 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1520 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1521 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1522 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1523 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1524 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1525 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1526 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1527 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1528 * xterm.c:
1529 Omit needless casts involving void * pointers and allocation.
1530 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1531 as the former is more robust if P's type is changed.
1532 Prefer xzalloc to xmalloc + memset 0.
1533 Simplify malloc-or-realloc to realloc.
1534 Don't worry about xmalloc returning a null pointer.
1535 Prefer xstrdup to xmalloc + strcpy.
1536 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1537 growing it.
1538 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1539 alloca of a constant.
1540
6dd5a677
EZ
15412012-07-05 Eli Zaretskii <eliz@gnu.org>
1542
1543 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1544 hscroll is larger than the line width. Fixes long and futile
1545 looping inside extend_face_to_end_of_line (on a TTY) producing
1546 glyphs that are not needed and thrown away.
1547
6b312f0f
DA
15482012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1549
1550 * marker.c (set_marker_restricted_both): Simplify by using
1551 clip_to_bounds.
1552
f520ef9b
PE
15532012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1556
383b7c95
JD
15572012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1558
1559 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1560 not defined (Bug#11768).
1561 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1562 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1563 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1564 followed by gtk_box_set_homogeneous (Bug#11768).
1565 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1566 (update_theme_scrollbar_width, xg_create_scroll_bar):
1567 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1568 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1569 (is_box_type): New function (Bug#11768).
1570 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1571 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1572 with default display (Bug#11768).
1573
d6e7bf45
EZ
15742012-07-05 Eli Zaretskii <eliz@gnu.org>
1575
1576 * xdisp.c (window_hscroll_limited): New function.
1577 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1578 coordinates when window's hscroll is set to insanely large
1579 values. (Bug#11857)
1580
431391ec
JB
15812012-07-05 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1584 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1585
23f86fce
DA
15862012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1587
1588 Cleanup xmalloc.
1589 * lisp.h (xzalloc): New prototype. Omit needless casts.
1590 * alloc.c (xzalloc): New function. Omit needless casts.
1591 * charset.c: Omit needless casts. Convert all calls to
1592 xmalloc with following memset to xzalloc.
1593 * dispnew.c: Likewise.
1594 * fringe.c: Likewise.
1595 * image.c: Likewise.
1596 * sound.c: Likewise.
1597 * term.c: Likewise.
1598 * w32fns.c: Likewise.
1599 * w32font.c: Likewise.
1600 * w32term.c: Likewise.
1601 * xfaces.c: Likewise.
1602 * xfns.c: Likewise.
1603 * xterm.c: Likewise.
1604 * atimer.c: Omit needless casts.
1605 * buffer.c: Likewise.
1606 * callproc.c: Likewise.
1607 * ccl.c: Likewise.
1608 * coding.c: Likewise.
1609 * composite.c: Likewise.
1610 * doc.c: Likewise.
1611 * doprnt.c: Likewise.
1612 * editfns.c: Likewise.
1613 * emacs.c: Likewise.
1614 * eval.c: Likewise.
1615 * filelock.c: Likewise.
1616 * fns.c: Likewise.
1617 * gtkutil.c: Likewise.
1618 * keyboard.c: Likewise.
1619 * lisp.h: Likewise.
1620 * lread.c: Likewise.
1621 * minibuf.c: Likewise.
1622 * msdos.c: Likewise.
1623 * print.c: Likewise.
1624 * process.c: Likewise.
1625 * region-cache.c: Likewise.
1626 * search.c: Likewise.
1627 * sysdep.c: Likewise.
1628 * termcap.c: Likewise.
1629 * terminal.c: Likewise.
1630 * tparam.c: Likewise.
1631 * w16select.c: Likewise.
1632 * w32.c: Likewise.
1633 * w32reg.c: Likewise.
1634 * w32select.c: Likewise.
1635 * w32uniscribe.c: Likewise.
1636 * widget.c: Likewise.
1637 * xdisp.c: Likewise.
1638 * xmenu.c: Likewise.
1639 * xrdb.c: Likewise.
1640 * xselect.c: Likewise.
1641
0497dc44
PE
16422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 * fileio.c (time_error_value): Check the right error number.
1645 Problem reported by Troels Nielsen in
1646 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1647
356e7178
PE
16482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1649
4e71fd89
PE
1650 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1651 This should be fixed in a better way; see Eli Zaretskii in
1652 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1653 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1654
f0941253
PE
1655 * fileio.c (time_error_value): Rename from special_mtime.
1656 The old name's problems were noted by Eli Zaretskii in
1657 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1658
065c9eb4
PE
1659 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1660 This variable's comment says Emacs needs at least one GDB-visible
1661 symbol of type enum pvec_type, to work around GDB problems.
1662 The symbol's value doesn't matter.
1663
356e7178
PE
1664 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1665 that causes compilation to fail on pre-C99 compilers.
1666
ed9265fc 16672012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1668
1669 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1670 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1671
3884d954
DA
16722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1673
d209e2fb 1674 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1675 headers for buffer_defaults and buffer_local_symbols.
1676 Reported by Juanma Barranquero <lekktu@gmail.com>.
1677
ee28be33
SM
16782012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1681 * lisp.h (enum pvec_type): Use fewer bits.
1682 (PSEUDOVECTOR_SIZE_BITS): New constant.
1683 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1684 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1685 change in pvec_type.
1686 (PSEUDOVECTOR_TYPEP): New macro.
1687 (TYPED_PSEUDOVECTORP): Use it.
1688 * fns.c (internal_equal): Adapt code to extract pvectype.
1689 * emacs.c (gdb_pvec_type): Update type.
1690 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1691 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1692 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1693 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1694 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1695 abusing vector->header.next.nbytes.
1696 (live_vector_p): Use PVEC_TYPE.
1697 (mark_object): Adapt code to extract pvectype. Use switch.
1698
c7f2cd7f
PE
16992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1700
1701 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1702 Tighten new eassert a bit.
1703
8ce70ed2
DA
17042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 Fix compilation with --enable-gcc-warnings and -O1
1707 optimization level.
1708 * doprnt.c (doprnt): Change type of tem to int, initialize
1709 to avoid compiler warning. Add eassert.
1710 * search.c (simple_search): Initialize match_byte to avoid
1711 compiler warning. Add eassert.
1712
dea7f1e5
PE
17132012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1714
24a212eb
PE
1715 Avoid weird behavior with large horizontal scrolls.
1716 Without this change, for example, large hscroll values would
1717 mess up Emacs's display on Fedora 15 x86, presumably due to
1718 overflows in int calculations in the display code.
1719 Also, if buffers had long lines, Emacs would freeze.
1720 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1721 (set_window_hscroll): New function, containing the old guts of
1722 Fset_window_hscroll. Return the clipped value.
1723 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1724 This avoids the need to check against PTRDIFF_MAX.
1725
dea7f1e5
PE
1726 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1727
76046526
DA
17282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1731
39adff0d
PE
17322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1733
63807d47
PE
1734 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1735 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1736 since GCC 4.4.6 issues a bogus warning for them.
1737
39adff0d
PE
1738 Fix bugs in file timestamp newness comparisons.
1739 * fileio.c (Ffile_newer_than_file_p):
1740 * lread.c (Fload): Use full timestamp resolution of files,
1741 not just the 1-second resolution, so that files that are only
1742 slightly newer still count as newer.
1743 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1744 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1745
dbeed9a6
PE
17462012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 * fileio.c: Improve handling of file time marker. (Bug#11852)
1749 (special_mtime): New function.
1750 (Finsert_file_contents, Fverify_visited_file_modtime):
1751 Use it to set special mtime values consistently.
1752
636334d6
AS
17532012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1754
1755 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1756 marker for non-existing file. (Bug#11852)
1757
e2017fe2
GM
17582012-07-03 Glenn Morris <rgm@gnu.org>
1759
1760 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1761 and did not make it into globals.h).
1762
404dbd37
TT
17632012-07-03 Tom Tromey <tromey@redhat.com>
1764
1765 * window.c (Fset_window_margins, Fset_window_fringes)
1766 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1767 * textprop.c (Fprevious_property_change): No longer static.
1768 * syntax.c (Fsyntax_table_p): No longer static.
1769 * process.c (Fget_process, Fprocess_datagram_address): No longer
1770 static.
1771 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1772 * keyboard.c (Fcommand_execute): No longer static.
1773 Remove EXFUN.
1774 * insdel.c (Fcombine_after_change_execute): No longer static.
1775 * image.c (Finit_image_library): No longer static.
1776 * fileio.c (Fmake_symbolic_link): No longer static.
1777 * eval.c (Ffetch_bytecode): No longer static.
1778 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1779 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1780 No longer static.
404dbd37
TT
1781 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1782 static.
1783 * dired.c (Ffile_attributes): No longer static.
1784 * composite.c (Fcomposition_get_gstring): No longer static.
1785 * callproc.c (Fgetenv_internal): No longer static.
1786
1787 * ccl.h: Remove EXFUNs.
1788 * buffer.h: Remove EXFUNs.
1789 * dispextern.h: Remove EXFUNs.
1790 * intervals.h: Remove EXFUNs.
1791 * fontset.h: Remove EXFUN.
1792 * font.h: Remove EXFUNs.
1793 * dosfns.c (system_process_attributes): Remove EXFUN.
1794 * keymap.h: Remove EXFUNs.
1795 * lisp.h: Remove EXFUNs.
1796 * w32term.h: Remove EXFUNs.
1797 * window.h: Remove EXFUNs.
1798 * xsettings.h: Remove EXFUN.
1799 * xterm.h: Remove EXFUN.
1800
8e4fd1e1
GM
18012012-07-03 Glenn Morris <rgm@gnu.org>
1802
1803 * lisp.h (Frandom): Make it visible to C.
1804 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1805 buffer for invisible buffers. (Bug#1229)
1806
ca95b3eb
DA
18072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1810 values which aren't power of 2.
1811 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1812 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1813 accordingly.
1814
7555c33f
SM
18152012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1818
1819 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1820
d12e8f5a
DA
18212012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 * alloc.c (allocate_vector_block): Remove redundant
1824 calls to mallopt if DOUG_LEA_MALLOC is defined.
1825 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1826 avoid calls to mallopt if zero_vector is returned.
1827
296094c3
DA
18282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1829
1830 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1831 is enabled, avoid dereferencing NULL current_sblock if
1832 running undumped.
1833
36429c89
DA
18342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1835
1836 Cleanup basic buffer management.
1837 * buffer.h (struct buffer): Change layout to use generic vector
1838 marking code. Fix some comments. Change type of 'clip_changed'
1839 to bitfield. Remove unused #ifndef old.
1840 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1841 (GET_OVERLAYS_AT): Fix indentation.
1842 (for_each_per_buffer_object_at): New macro.
1843 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1844 (Fbuffer_local_variables): Use it.
1845 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1846 * alloc.c (allocate_buffer): Adjust to match new layout of
1847 struct buffer. Fix comment.
1848 (mark_overlay): New function.
1849 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1850 Lisp area of struct buffer.
1851 (mark_object): Use it. Adjust marking of misc objects
1852 and related comments.
1853
3b3e4cac
PE
18542012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1857 wrapper that is not needed because the wrapped code is a no-op (zero
1858 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1859 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1860
cf5c0175
DA
18612012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 * alloc.c (mark_buffer): Simplify. Remove prototype.
1864 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1865 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1866 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1867 redundant calls to mark_vectorlike for bool vectors.
1868
ca26824c
GM
18692012-06-30 Glenn Morris <rgm@gnu.org>
1870
2e4c5312
GM
1871 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1872
ca26824c
GM
1873 * epaths.in (PATH_SITELOADSEARCH): New.
1874 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1875 This is rather than relying on --enable-locallisppath elements
1876 having "site-lisp" in their names. (Bug#10208#25, 11658)
1877
0d23c240
EZ
18782012-06-30 Eli Zaretskii <eliz@gnu.org>
1879
c9240d7a
EZ
1880 * w32proc.c (sys_select): Accept and ignore one more argument.
1881
1882 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1883
0d23c240 1884 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1885 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1886
1887 * sysdep.c: Don't include dos.h and dosfns.h.
1888
1889 * process.c (sys_select):
1890 * msdos.c (sys_select): Accept one more argument and ignore it.
1891
1892 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1893 adapt data types and code to that.
1894
1895 * dosfns.c:
1896 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1897 which clashes with the gnulib function of the same name.
1898
af5a5a98
AS
18992012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1900
c5e4379c
AS
1901 * font.c (font_style_to_value, font_style_symbolic)
1902 (font_prop_validate_style): Add type checks for values in
1903 font_style_table.
1904
af5a5a98
AS
1905 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1906 argument.
1907 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1908 uses.
1909
8d38f461
EZ
19102012-06-29 Eli Zaretskii <eliz@gnu.org>
1911
2e5a6631
EZ
1912 * xdisp.c (try_window_id): Undo last change.
1913
8d38f461
EZ
1914 * w32.c (getwd): Adjust commentary about startup_dir.
1915 (init_environment): Always call sys_access, even in non-MSVC
1916 builds. Don't chdir to the directory of the Emacs executable.
1917 This undoes code from 1997 which was justified by the need to
1918 "avoid conflicts when removing and renaming directories". But its
1919 downside was that every relative file name was being interpreted
1920 relative to the directory of the Emacs executable, which can never
1921 be TRT. In particular, it broke sys_access when called with
1922 relative file names.
1923 (sys_access): Map GetLastError to errno.
1924
2af3565e
DA
19252012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1926
1927 * window.h (struct window): Change type of 'fringes_outside_margins'
1928 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1929 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1930 Adjust comment.
1931 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1932 to ptrdiff_t.
1933
c8d3a25c 19342012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1935
c8d3a25c
GM
1936 * gnutls.c (emacs_gnutls_handshake):
1937 Add QUIT to make the loop interruptible.
57570cd3 1938
c8d3a25c 19392012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1940
c8d3a25c
GM
1941 * charset.c (init_charset): Make lack of etc/charsets fatal.
1942
3e984ee8
DA
19432012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 * editfns.c (region_limit): Fix type mismatch.
1946
ef884f23
DA
19472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1948
1949 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1950 undefined. Convert from xassert to eassert.
1951 * nsmenu.m: Convert from xassert to eassert.
1952 * nsterm.m: Likewise.
1953
7d7e0027
SM
19542012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1955
1956 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1957
aa754e6a
PE
19582012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 Avoid integer overflow on scroll-left and scroll-right.
1961 * window.c (HSCROLL_MAX): New macro.
1962 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1963 overflow when requested scroll falls outside ptrdiff_t range.
1964
80b00b08
DA
19652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1966
1967 * window.h (struct window): Change type of 'hscroll',
1968 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1969 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1970 Adjust users accordingly.
1971 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1972 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1973 from EMACS_INT to ptrdiff_t.
1974 (make_window): Omit redundant initialization.
1975
62b2bcf6
JB
19762012-06-28 Juanma Barranquero <lekktu@gmail.com>
1977
1978 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1979
45942c7d
DA
19802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1981
1982 * window.h (struct window): Change type of 'use_time' and
1983 'sequence_number' from Lisp_Object to int.
1984 * frame.c (make_frame): Adjust users accordingly.
1985 * print.c (print_object): Likewise.
1986 * window.c (select_window, Fwindow_use_time, make_parent_window)
1987 (make_window): Likewise.
1988
e509cfa6
DA
19892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1990
1991 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1992 enabled with --enable-checking=[all,glyphs] configure option.
1993 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1994 adjust comments accordingly.
1995 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1996 undefined, adjust comments accordingly.
1997 * image.c: Likewise.
1998 * scroll.c: Likewise.
1999 * w32fns.c: Likewise.
2000 * w32term.c: Likewise.
2001 * xdisp.c: Likewise.
2002 * xfaces.c: Likewise.
2003 * xfns.c: Likewise.
2004 * xterm.c: Likewise.
2005
a54e2c05
DA
20062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 Generalize run-time debugging checks.
2009 * dispextern.h (XASSERTS): Remove.
2010 * fontset.c (xassert): Remove.
2011 Convert from xassert to eassert.
2012 * alloc.c: Convert from xassert to eassert.
2013 * bidi.c: Likewise.
2014 * dispnew.c: Likewise.
2015 * fns.c: Likewise.
2016 * fringe.c: Likewise.
2017 * ftfont.c: Likewise.
2018 * gtkutil.c: Likewise.
2019 * image.c: Likewise.
2020 * keyboard.c: Likewise.
2021 * menu.c: Likewise.
2022 * process.c: Likewise.
2023 * scroll.c: Likewise.
2024 * sound.c: Likewise.
2025 * term.c: Likewise.
2026 * w32console.c: Likewise.
2027 * w32fns.c: Likewise.
2028 * w32term.c: Likewise.
2029 * window.c: Likewise.
2030 * xdisp.c: Likewise.
2031 * xfaces.c: Likewise.
2032 * xfns.c: Likewise.
2033 * xselect.c: Likewise.
2034 * xterm.c: Likewise.
2035
1ec4b7b2
SM
20362012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2037
2038 * fns.c (maybe_resize_hash_table): Output message when growing the
2039 purify-hashtable.
2040
2014308a
DA
20412012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2042
2043 * alloc.c (allocate_string_data): Remove dead code.
2044 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2045 avoid GCC warning about unused macro.
2046
246155eb
DA
20472012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * alloc.c (allocate_string): Omit intervals initialization.
2050 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2051 as in make_pure_string and make_pure_c_string.
2052
43184b7b
DA
20532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2054
d209e2fb 2055 * alloc.c (allocate_string): Fix last change.
43184b7b 2056
3fe6dd74
DA
20572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2058
d209e2fb 2059 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2060 to memset, add explicit initialization where appropriate.
2061
1ba6038a
GM
20622012-06-27 Glenn Morris <rgm@gnu.org>
2063
2064 * lisp.mk (lisp): Remove paths.elc.
2065
c89926a5
CY
20662012-06-27 Chong Yidong <cyd@gnu.org>
2067
2068 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2069
ed6b3510
JW
20702012-06-26 John Wiegley <johnw@newartisans.com>
2071
1ec4b7b2 2072 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2073 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2074
ed6b3510
JW
2075 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2076 when building with Clang.
2077
8edd4a2b
SM
20782012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2079
2080 * eval.c (Fapply): Allow calling it with a single argument.
2081
f6f62d1b
EZ
20822012-06-26 Eli Zaretskii <eliz@gnu.org>
2083
2084 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2085 _stricmp and _strnicmp.
2086 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2087
62efea5e
DA
20882012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2089
2090 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2091 allocated window.
2092 (allocate_process): Likewise for new process.
8edd4a2b 2093 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2094 (allocate_frame): Likewise.
2095 * frame.c (make_frame): Omit redundant initialization.
2096 * window.c (make_parent_window): Use memset.
2097 (make_window): Omit redundant initialization.
2098 * process.c (make_process): Omit redundant initialization.
2099 * terminal.c (create_terminal): Likewise.
2100
42997f4d
DA
21012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2102
2103 * term.c (delete_tty): Remove redundant call to memset.
2104
1130ecfc
DA
21052012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2106
2107 * alloc.c: Remove build_string.
2108 * lisp.h: Define build_string as static inline. This provides
2109 a better opportunity to optimize away calls to strlen when the
2110 function is called with compile-time constant argument.
2111 * image.c (imagemagick_error): Convert to build_string.
2112 * w32proc.c (sys_spawnve): Likewise.
2113 * xterm.c (x_term_init): Likewise.
2114
cf38a720
PE
21152012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2116
99027bdd
PE
2117 Use sprintf return value instead of invoking strlen on result.
2118 In the old days this wasn't portable, since some sprintf
2119 implementations returned char *. But they died out years ago and
2120 Emacs already assumes sprintf returns int.
2121 Similarly for float_to_string.
2122 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2123 * ccl.c (ccl_driver):
2124 * character.c (string_escape_byte8):
2125 * data.c (Fnumber_to_string):
2126 * doprnt.c (doprnt):
2127 * print.c (print_object):
2128 * xdisp.c (message_dolog):
2129 * xfns.c (syms_of_xfns):
2130 Use sprintf or float_to_string result to avoid need to call strlen.
2131 * data.c (Fnumber_to_string):
2132 Use make_unibyte_string, since the string must be ASCII.
2133 * lisp.h, print.c (float_to_string): Now returns int length.
2134 * term.c (produce_glyphless_glyph):
2135 Use sprintf result rather than recomputing it.
2136
cf38a720
PE
2137 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2138 * Makefile.in (ALL_CFLAGS):
2139 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2140 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2141
3511c784
DA
21422012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2143
0a08eb21 2144 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2145 strcasecmp if available.
2146 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2147
fb7da12e
AS
21482012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2149
2150 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2151 Avoid comma operator.
2152 * menu.c (push_submenu_start, push_submenu_end)
2153 (push_left_right_boundary, push_menu_pane): Likewise.
2154 * msdos.c (dos_rawgetc): Likewise.
2155
afa2ffd8
DA
21562012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2157
2158 * xfns.c (xic_create_fontsetname): Remove redundant calls
2159 to memset.
2160
b3b4476b
PE
21612012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2162
4495ff38
PE
2163 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2164 sprintf already null-terminates its output.
2165
b3b4476b
PE
2166 * xfns.c (x_window): Remove redundant cast.
2167
b00876c9
DA
21682012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2171 `const char *' to `char *' to avoid compiler warning.
2172
d188e26b
PE
21732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2174
885d1d74
PE
2175 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2176 instead of truncating it to 63 (admittedly a generous limit).
2177
d188e26b
PE
2178 * process.c: Fix spelling and caps in comments.
2179
e2f560b1
DN
21802012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2181
e86db54b 2182 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2183 * sysdep.c (setpgrp): Remove definition, not used in this file.
2184
7583a3a1
JB
21852012-06-24 Juanma Barranquero <lekktu@gmail.com>
2186
2187 * makefile.w32-in: Update dependencies.
2188
696056c2
EZ
21892012-06-24 Eli Zaretskii <eliz@gnu.org>
2190
2191 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2192 (SYSTIME_H): Add nt/inc/sys/time.h.
2193
2194 * systime.h [WINDOWSNT]: Include sys/time.h.
2195
2196 * s/ms-w32.h (struct timespec): Definition moved from
2197 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2198
845ca893
PE
21992012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2202 * buffer.h (buffer_slot_type_mismatch):
2203 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2204 * eval.c (unwind_to_catch):
2205 * image.c (my_png_error, my_error_exit):
2206 * keyboard.c (quit_throw_to_read_char, user_error)
2207 (Fexit_recursive_edit, Fabort_recursive_edit):
2208 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2209 (wrong_type_argument, buffer_overflow, __executable_start)
2210 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2211 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2212 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2213 (fatal):
2214 (child_setup) [!DOS_NT]:
2215 * lread.c (end_of_file_error, invalid_syntax):
2216 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2217 * puresize.h (pure_write_error):
2218 * search.c (matcher_overflow):
2219 * sound.c (sound_perror, alsa_sound_perror):
2220 * sysdep.c, syssignal.h (croak):
2221 * term.c (maybe_fatal, vfatal):
2222 * textprop.c (text_read_only):
2223 * undo.c (user_error):
2224 * unexmacosx.c (unexec_error):
2225 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2226 Use _Noreturn rather than NO_RETURN.
2227 No need for separate decl merely because of _Noreturn.
2228 * sound.c (sound_warning, parse_sound):
2229 Remove unnecessary forward decls.
2230
f1dd8073
PE
22312012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2234 * lisp.h (WAIT_READING_MAX): New macro.
2235 * dispnew.c (Fsleep_for, sit_for):
2236 * keyboard.c (kbd_buffer_get_event):
2237 * process.c (Faccept_process_output):
2238 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2239 This improves on the previous patch, which introduced a bug
2240 when time_t is unsigned and as wide as intmax_t.
2241 See <http://bugs.gnu.org/9000#51>.
2242
b82c1755
EZ
22432012-06-23 Eli Zaretskii <eliz@gnu.org>
2244
2245 * dispnew.c (sit_for, Fsleep_for):
2246 * keyboard.c (kbd_buffer_get_event):
2247 * process.c (Faccept_process_output): Avoid compiler warnings when
2248 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2249
ca300656
JB
22502012-06-23 Juanma Barranquero <lekktu@gmail.com>
2251
049ec95b
JB
2252 * makefile.w32-in: Update dependencies.
2253
ca300656
JB
2254 * w32.c (ltime): Add return type and declare static.
2255 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2256
db7b8d06
PE
22572012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2260 Privately reported by Herbert J. Skuhra.
2261 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2262 All uses changed.
2263 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2264 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2265
0bd8297f
EZ
22662012-06-23 Eli Zaretskii <eliz@gnu.org>
2267
96512555
EZ
2268 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2269 last argument of make_unibyte_string.
2270
0bd8297f
EZ
2271 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2272 language ID in the event parameters.
2273
2274 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2275 event.code, not the obscure "character set ID".
2276
63def6b6
CY
22772012-06-23 Chong Yidong <cyd@gnu.org>
2278
2279 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2280
e8a02204
EZ
22812012-06-23 Eli Zaretskii <eliz@gnu.org>
2282
388cdec0
EZ
2283 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2284 * w32.c (fdutimens): New function.
2285
2286 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2287
2288 * s/ms-w32.h (pselect): Redirect to sys_select.
2289
2290 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2291
e8a02204
EZ
2292 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2293 in the logic of incrementing and decrementing the value of
2294 use_relocatable_buffers.
2295
d054f3fb
PE
22962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2297
2298 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2299 Privately reported by Herbert J. Skuhra.
2300 [__FreeBSD__]: Remove "*/" typo after "#include".
2301 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2302 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2303 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2304 Don't assume EMACS_TIME and struct timeval are the same type.
2305
d35af63c
PE
23062012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Support higher-resolution time stamps (Bug#9000).
2309 The time stamps are only nanosecond-resolution at the C level,
2310 since that's the best that any real-world system supports now.
2311 But they are picosecond-resolution at the Lisp level, as that's
2312 easy, and leaves room for future OS improvements.
2313
2314 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2315 (LIBES): Use it.
2316
2317 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2318 Don't get current time unless it's needed.
2319
2320 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2321 now provides it if it's absent.
2322 (start_atimer): Port to higher-res time stamps.
2323 Check for time stamp overflow. Don't get current time more
2324 often than is needed.
2325
2326 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2327 Include systime.h, not time.h.
2328 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2329
2330 * dired.c: Include stat-time.h.
2331 (Ffile-attributes): File times now have higher resolution.
2332
2333 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2334 (struct image): Timestamp now has higher resolution.
2335
2336 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2337 has at least microseconds now. All uses removed.
2338 (update_frame, update_single_window, update_window, update_frame_1)
2339 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2340
2341 * editfns.c (time_overflow): Now extern.
2342 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2343 (float-time, Fformat_time_string, Fcurrent_time_string)
2344 (Fcurrent_time_zone): Accept and generate higher-resolution
2345 time stamps.
2346 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2347 (decode_time_components, lisp_seconds_argument): New functions.
2348 (make_time): Now static.
2349 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2350 Report an error if the time is invalid, rather than having the caller
2351 do that.
2352
2353 * fileio.c: Include <stat-time.h>
2354 (Fcopy_file): Copy higher-resolution time stamps.
2355 Prefer to set the time stamp via a file descriptor if that works.
2356 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2357 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2358 (Fvisited_file_modtime, Fset_visited_file_modtime):
2359 Support higher-resolution time stamps.
2360
2361 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2362
2363 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2364
2365 * image.c (prepare_image_for_display, clear_image_cache)
2366 (lookup_image): Port to higer-resolution time stamps.
2367
2368 * keyboard.c (start_polling, bind_polling_period):
2369 Check for time stamp overflow.
2370 (read_char, kbd_buffer_get_event, timer_start_idle)
2371 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2372 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2373 Port to higher-resolution time stamps. Do not assume time_t is signed.
2374 (decode_timer): New function. Timers are now vectors of length 9,
2375 not 8, to accommodate the picosecond component.
2376 (timer_check_2): Use it.
2377
2378 * nsterm.m (select_timeout, timeval_subtract): Remove.
2379 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2380 as they're a bit more accurate and handle overflow better.
2381 (ns_select): Change prototype to be compatible with pselect.
2382 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2383 * nsterm.h (ns_select): Adjust prototype.
2384
2385 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2386 us-resolution time stamps.
2387 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2388
2389 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2390
2391 * lisp.h (time_overflow): New decl.
2392 (wait_reading_process_output): First arg is now intmax_t, not int,
2393 to accommodate larger waits.
2394
2395 * process.h (struct Lisp_Process.read_output_delay):
2396 Now counts nanoseconds, not microseconds.
2397 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2398 EMACS_HAS_USECS.
2399 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2400 (wait_reading_process_output):
2401 Port to ns-resolution time stamps.
2402 (Faccept_process_output, wait_reading_process_output):
2403 Check for time stamp overflow. Do not assume time_t is signed.
2404 (select_wrapper): Remove; we now use pselect.
2405 (Fprocess_attributes): Now generates ns-resolution time stamps.
2406
2407 * sysdep.c: Include utimens.h. Don't include utime.h
2408 or worry about struct utimbuf; gnulib does that for us now.
2409 (gettimeofday): Remove; gnulib provides a substitute.
2410 (make_timeval): New function.
2411 (set_file_times): Now sets ns-resolution time stamps.
2412 New arg FD; all uses changed.
2413 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2414 (system_process_attributes):
2415 Now returns ns-resolution time stamp. All uses changed.
2416 Check for time stamp overflow.
2417
2418 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2419 provides a substitute now.
2420
2421 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2422 since it guarantees struct timespec.
2423 (EMACS_TIME): Now struct timespec, so that we can support
2424 ns-resolution time stamps.
2425 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2426 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2427 (EMACS_USECS): Remove.
2428 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2429 so multiply the arg by 1000 before storing it.
2430 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2431 New macros.
2432 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2433 Port to ns-resolution time stamps.
2434 (EMACS_TIME_NEG_P): Remove; replaced by....
2435 (EMACS_TIME_SIGN): New macro.
2436 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2437 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2438 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2439 (make_timeval, make_lisp_time, decode_time_components): New decls.
2440 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2441 that it mishandled time_t overflow. You can't compare by subtracting!
2442 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2443 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2444
2445 * term.c: Include <sys/time.h>.
2446 (timeval_to_Time): New function, for proper overflow wraparound.
2447 (term_mouse_position, term_mouse_click): Use it.
2448
2449 * undo.c (record_first_change): Support higher-resolution time stamps
2450 in the undo buffer.
2451 (Fprimitive_undo): Use them when restoring time stamps.
2452
2453 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2454 (w32_get_internal_run_time):
2455 Port to higher-resolution Emacs time stamps.
2456 (ltime): Now accepts single 64-bit integer, as that's more convenient
2457 for callers.
2458
2459 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2460
2461 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2462 for compatibility with pselect. Support ns-resolution time stamps.
2463
2464 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2465
2466 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2467 Check for time stamp overflow, and support ns-resolution time stamps.
2468
2469 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2470 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2471 (timeval_subtract): Remove; no longer needed.
2472 (XTflash, XTring_bell, x_wait_for_event):
2473 Port to ns-resolution time stamps. Don't assume time_t is signed.
2474
b6a92dfe
CY
24752012-06-22 Chong Yidong <cyd@gnu.org>
2476
2477 * xdisp.c (x_consider_frame_title): Revert last change.
2478
d251c37c
EZ
24792012-06-22 Eli Zaretskii <eliz@gnu.org>
2480
2481 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2482 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2483 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2484 staticidx goes up to 1597 out of 1600 = 0x640.)
2485
f10deafb
PE
24862012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2489 Otherwise, the umask might be mistakenly 0 while handling input signals.
2490
ec6de1e2
SM
24912012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2492
2493 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2494
28be1ada
DA
24952012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2498 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2499 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2500 access to `contents' member of Lisp_Vector objects with AREF and ASET
2501 where appropriate.
2502
c6bf3022
CY
25032012-06-19 Chong Yidong <cyd@gnu.org>
2504
2505 * frame.c (delete_frame): When selecting a frame on a different
2506 text terminal, do not alter the terminal's top-frame.
2507
2508 * xdisp.c (format_mode_line_unwind_data): Record the target
2509 frame's selected window and its terminal's top-frame.
2510 (unwind_format_mode_line): Restore them.
2511 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2512 Callers changed.
2513 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2514 since tty frames can be explicitly named.
2515 (prepare_menu_bars): Likewise.
2516
2517 * term.c (Ftty_top_frame): New function.
2518
defd4196
PE
25192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 Port byte-code-meter to modern targets.
2522 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2523 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2524 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2525 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2526 (METER_1, METER_2): Simplify.
2527
1053a871
SM
25282012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2529
2530 * data.c (Fdefalias): Return `symbol' (bug#11686).
2531
b7e8d081
MR
25322012-06-18 Martin Rudalics <rudalics@gmx.at>
2533
2534 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2535 gets killed during executing of this function (Bug#11665).
2536 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2537 (Vkill_buffer_query_functions): In doc-string say that functions
2538 run by this hook should not change the current buffer.
2539
7ea2b339
PE
25402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 Fix recently-introduced process.c problems found by static checking.
2543 * process.c (write_queue_push, write_queue_pop, send_process):
2544 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2545 (write_queue_pop): Fix pointer signedness problem.
2546 (send_process): Remove unused local.
2547
96a313a1
CY
25482012-06-17 Chong Yidong <cyd@gnu.org>
2549
2550 * xdisp.c (redisplay_internal): No need to redisplay terminal
2551 frames that are not on top.
2552
20ca2e94
TN
25532012-06-17 Troels Nielsen <bn.troels@gmail.com>
2554
2555 * process.c (make_process): Initialize write_queue.
2556 (write_queue_push, write_queue_pop): New functions.
2557 (send_process): Use them to maintain correct ordering of process
2558 writes (Bug#10815).
2559
9a900ca9
PE
25602012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2561
310fbfa8
PE
2562 * lisp.h (eassert): Assume C89 or later.
2563 This removes the need for CHECK.
2564 (CHECK): Remove. Its comments about always evaluating its
2565 argument were confusing, as 'eassert' typically does not evaluate
2566 its argument.
2567
27bb1ca4
PE
2568 * coding.c (produce_chars): Use ptrdiff_t, not int.
2569
9a900ca9
PE
2570 * xterm.c (x_draw_underwave): Check for integer overflow.
2571 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2572
41b7f8bc 25732012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2574
2575 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2576 referenced (Bug#11583).
2577
9b0e3eba
AA
25782012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2579
2580 Implement wave-style variant of underlining.
2581 * dispextern.h (face_underline_type): New enum.
2582 (face): Add field for underline type.
2583 * nsterm.m (ns_draw_underwave): New function.
2584 (ns_draw_text_decoration): Use it.
2585 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2586 New functions.
2587 (x_draw_glyph_string): Use them.
2588 * xfaces.c (Qline, Qwave): New Lisp objects.
2589 (check_lface_attrs, merge_face_ref)
1053a871
SM
2590 (Finternal_set_lisp_face_attribute, realize_x_face):
2591 Handle wave-style underline face attributes.
9b0e3eba
AA
2592 * xterm.c (x_draw_underwave): New function.
2593 (x_draw_glyph_string): Use it.
2594
0fb52f11
JB
25952012-06-16 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2598 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2599 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2600 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2601 ($(BLD)/w32select.$(O)): Update dependencies.
2602
e5560ff7
AS
26032012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2604
2605 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2606 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2607 * character.c (_fetch_multibyte_char_p): Remove.
2608 * alloc.c: Include "character.h" before "buffer.h".
2609 * bidi.c: Likewise.
2610 * buffer.c: Likewise.
2611 * bytecode.c: Likewise.
2612 * callint.c: Likewise.
2613 * callproc.c: Likewise.
2614 * casefiddle.c: Likewise.
2615 * casetab.c: Likewise.
2616 * category.c: Likewise.
2617 * cmds.c: Likewise.
2618 * coding.c: Likewise.
2619 * composite.c: Likewise.
2620 * dired.c: Likewise.
2621 * dispnew.c: Likewise.
2622 * doc.c: Likewise.
2623 * dosfns.c: Likewise.
2624 * editfns.c: Likewise.
2625 * emacs.c: Likewise.
2626 * fileio.c: Likewise.
2627 * filelock.c: Likewise.
2628 * font.c: Likewise.
2629 * fontset.c: Likewise.
2630 * fringe.c: Likewise.
2631 * indent.c: Likewise.
2632 * insdel.c: Likewise.
2633 * intervals.c: Likewise.
2634 * keyboard.c: Likewise.
2635 * keymap.c: Likewise.
2636 * lread.c: Likewise.
2637 * macros.c: Likewise.
2638 * marker.c: Likewise.
2639 * minibuf.c: Likewise.
2640 * nsfns.m: Likewise.
2641 * nsmenu.m: Likewise.
2642 * print.c: Likewise.
2643 * process.c: Likewise.
2644 * regex.c: Likewise.
2645 * region-cache.c: Likewise.
2646 * search.c: Likewise.
2647 * syntax.c: Likewise.
2648 * term.c: Likewise.
2649 * textprop.c: Likewise.
2650 * undo.c: Likewise.
2651 * unexsol.c: Likewise.
2652 * w16select.c: Likewise.
2653 * w32fns.c: Likewise.
2654 * w32menu.c: Likewise.
2655 * window.c: Likewise.
2656 * xdisp.c: Likewise.
2657 * xfns.c: Likewise.
2658 * xmenu.c: Likewise.
2659 * xml.c: Likewise.
2660 * xselect.c: Likewise.
2661
2f07e6af
EZ
26622012-06-16 Eli Zaretskii <eliz@gnu.org>
2663
1053a871
SM
2664 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2665 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2666 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2667 row.
2668 (handle_face_prop): Use chunk-relative overlay string index when
2669 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2670 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2671 the rightmost. (Bug#11720)
2f07e6af 2672
29b83cec
AS
26732012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2674
2675 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2676 (CATEGORY_MEMBER): Enforce 1/0 value.
2677 * category.c (_temp_category_set): Remove.
2678
4c5501e9
EZ
26792012-06-16 Eli Zaretskii <eliz@gnu.org>
2680
2681 * window.c (Fdelete_other_windows_internal)
2682 (Fdelete_window_internal): Don't access frame's mouse highlight
2683 info of the initial frame. (Bug#11677)
2684
2b570124
PE
26852012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2686
e93864f9
PE
2687 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2688 Assume USE_2_TAGS_FOR_INTS.
2689 (xreload): Adjust $tagmask width to match recent lisp.h change.
2690
2b570124
PE
2691 Simplify lisp.h in minor ways that should not affect code.
2692 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2693 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2694 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2695 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2696 (INTTYPEBITS): New macro, for clarity.
2697 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2698 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2699 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2700 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2701 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2702
81755f69
JB
27032012-06-13 Juanma Barranquero <lekktu@gmail.com>
2704
2705 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2706
16192a57
GM
27072012-06-13 Glenn Morris <rgm@gnu.org>
2708
2709 * s/bsd-common.h (BSD4_3):
2710 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2711
646b5f55
AS
27122012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2713
2714 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2715 instead of union.
2716 (XLI, XIL): Define.
1053a871
SM
2717 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2718 Use them.
2719 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2720 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2721 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2722 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2723 * frame.c (delete_frame): Remove outdated comment.
2724 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2725 USE_LISP_UNION_TYPE.
2726 (Fw32_unregister_hot_key): Likewise.
2727 (Fw32_toggle_lock_key): Likewise.
2728 * w32menu.c (add_menu_item): Likewise.
2729 (w32_menu_display_help): Use XIL instead of checking
2730 USE_LISP_UNION_TYPE.
2731 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2732 (init_heap): Likewise.
2733 * w32term.c (w32_read_socket): Update comment.
2734
1d3823c9
GM
27352012-06-13 Glenn Morris <rgm@gnu.org>
2736
c62ff706
GM
2737 * s/usg5-4-common.h, src/s/unixware.h:
2738 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2739
1d3823c9
GM
2740 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2741
bfe3e0a2
PE
27422012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2745 * alloc.c (make_number) [!defined make_number]:
2746 Remove, as lisp.h always defines this now.
2747 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2748 (roundup_size): Verify that it is a power of 2.
2749 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2750 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2751 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2752 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2753 USE_LSB_TAG now is always defined to be either 0 or 1.
2754 All uses changed.
2755 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2756 code works fine either way, and efficiency is not a concern here,
2757 as the union type is for debugging, not for production.
2758 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2759 Use an inline function on all platforms when using the union type,
2760 since this is simpler and 'static inline' can be used portably
2761 within Emacs now.
2762 (LISP_INITIALLY_ZERO): New macro.
2763 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2764 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2765
45fa9c0f
GM
27662012-06-12 Glenn Morris <rgm@gnu.org>
2767
b4492cba
GM
2768 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2769
2770 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2771
45fa9c0f
GM
2772 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2773 Move BROKEN_SIGIO to configure.
2774
2775 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2776 Move NO_TERMIO to configure.
2777
0e25d334
CY
27782012-06-12 Chong Yidong <cyd@gnu.org>
2779
2780 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2781 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2782 MagickExportImagePixels is undefined.
2783
43682bb6
PE
27842012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * image.c (imagemagick_load_image): Remove unused label.
2787
a9be7d2b
GM
27882012-06-11 Glenn Morris <rgm@gnu.org>
2789
2790 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2791 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2792 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2793 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2794
3017f87f
SM
27952012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2796
2797 * alloc.c (make_byte_code): New function.
2798 (Fmake_byte_code): Use it. Don't purify here.
2799 * lread.c (read1): Use it as well to avoid extra allocation.
2800
1b9b4cf4
CY
28012012-06-11 Chong Yidong <cyd@gnu.org>
2802
2803 * image.c (imagemagick_load_image): Implement transparency.
2804
95988fcf
AS
28052012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2806
2807 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2808 account for preceding backslashes. (Bug#11663)
2809
cd4eb164
CY
28102012-06-09 Chong Yidong <cyd@gnu.org>
2811
2812 * term.c: Support italics in capable terminals (Bug#9652).
2813 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2814 (turn_on_face): Output using TS_enter_italic_mode if available.
2815 Don't handle unused blinking and alt-charset cases.
2816 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2817 and tty_alt_charset_p cases.
2818 (tty_capable_p, init_tty): Support italics.
2819
2820 * termchar.h (struct tty_display_info): Add field for italics.
2821 Remove unused blink field.
2822
2823 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2824 Handle slant.
2825
2826 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2827 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2828 tty_alt_charset_p. Add tty_italic_p.
2829
ff88beb8
MA
28302012-06-09 Michael Albinus <michael.albinus@gmx.de>
2831
2832 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2833 dbus_type_is_basic if available.
2834 (xd_extract_signed, xd_extract_unsigned): Rename from
2835 extract_signed and extract_unsigned, respectively. Adapt callers.
2836
44286096
CY
28372012-06-09 Chong Yidong <cyd@gnu.org>
2838
1682701f
CY
2839 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2840
44286096
CY
2841 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2842 case (Bug#9752).
2843
d86feb17
PE
28442012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2845
2846 * xdisp.c (vmessage): Treat frame message as multibyte.
2847 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2848 would generate the diagnostic "Making \302\247 buffer-local while
2849 let-bound!".
2850
d5c20fe8
EZ
28512012-06-08 Eli Zaretskii <eliz@gnu.org>
2852
2853 * dispnew.c (showing_window_margins_p): Undo last change, which
2854 was done due to an inadvertent commit.
2855 (adjust_frame_glyphs_for_frame_redisplay): Do call
2856 showing_window_margins_p.
2857
513749ee
SM
28582012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * eval.c (Fmake_var_non_special): New primitive.
2861 (syms_of_eval): Defsubr it.
2862 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2863
d4a8f5c1
JB
28642012-06-08 Juanma Barranquero <lekktu@gmail.com>
2865
2866 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2867 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2868
8bbbc977
EZ
28692012-06-08 Eli Zaretskii <eliz@gnu.org>
2870
2871 * alloc.c (allocate_vectorlike): Fix last change.
2872
f3372c87
DA
28732012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2874
2875 Block-based vector allocation of small vectors.
2876 * lisp.h (struct vectorlike_header): New field `nbytes',
2877 adjust comment accordingly.
2878 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2879 to denote vector blocks. Adjust users (live_vector_p,
2880 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2881 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2882 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2883 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2884 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2885 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2886 (roundup_size): New constant.
2887 (struct vector_block): New data type.
2888 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2889 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2890 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2891 (sweep_vectors): New functions.
2892 (allocate_vectorlike): Return `zero_vector' as the only vector of
2893 0 items. Allocate new vector from block if vector size is less than
2894 or equal to VBLOCK_BYTES_MAX.
2895 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2896 (init_alloc_once): Add call to init_vectors.
2897
4f18a4ed
SM
28982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2899
2900 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2901
86f158bc
PE
29022012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 * doprnt.c (doprnt): Truncate multibyte char correctly.
2905 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2906 would mishandle a string argument "Xc" if X was a multibyte
2907 character of length 2: it would truncate after X's first byte
2908 rather than including all of X.
2909
c5cfcbe0
CY
29102012-06-06 Chong Yidong <cyd@gnu.org>
2911
2912 * buffer.c (word_wrap): Doc fix.
2913
c05cf390
PE
29142012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2917
0c3461de
GM
29182012-06-03 Glenn Morris <rgm@gnu.org>
2919
2920 * xdisp.c (tool-bar-style): Doc fix.
2921
c71232db
UM
29222012-06-03 Ulrich Müller <ulm@gentoo.org>
2923
2924 * Makefile.in (PAXCTL): Define.
2925 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2926 binary via PaX flags if the paxctl utility is available.
2927 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2928 Restore PaX flags to their default. (Bug#11398)
2929
383f7350
CY
29302012-06-03 Chong Yidong <cyd@gnu.org>
2931
2932 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2933 buffer (Bug#11226).
2934
5f2c76c6
CY
29352012-06-03 Chong Yidong <cyd@gnu.org>
2936
2937 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2938 (note_mode_line_or_margin_highlight): If there is no help echo,
2939 use mode-line-default-help-echo. Handle the case where the mouse
2940 position is past the end of the mode line string.
2941
2942 * buffer.c (buffer_local_value_1): New function, split from
2943 Fbuffer_local_value; can return Qunbound.
2944 (Fbuffer_local_value): Use it.
2945 (Vmode_line_format): Docstring tweaks.
2946
773d47f6
PE
29472012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 * sysdep.c (system_process_attributes): Improve comment.
2950
f2d6a3df
SM
29512012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2952
2953 * keyboard.c: Export real-this-command to Elisp.
2954 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2955 and DEFVAR it. Update all users.
2956
63810350
PE
29572012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2958
7bd5c1f4
PE
2959 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2960
63810350
PE
2961 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2962 Convert pctcpu and pctmem to Lisp float properly.
2963 Let the compiler fold better, as 100.0/0x8000 is exact.
2964
a2821611
AS
29652012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2966
2967 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2968 cons_block.
2969
5fceba1d
PE
29702012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2973
c98ff5dd
DA
29742012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2975
2976 For a 'struct window', replace some Lisp_Object fields to
2977 bitfields where appropriate, remove unused fields.
2978 * window.h (struct window): Remove unused 'last_mark_x' and
2979 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2980 change it's type from Lisp_Object to bitfield.
2981 Change type of 'force_start', 'optional_new_start',
2982 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2983 fields from Lisp_Object to bitfield. Adjust users accordingly.
2984
ca34e0be
PE
29852012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 Pacify gcc -Wdouble-precision when using Xaw.
2988 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2989 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2990 Use 'float' consistently, rather than 'float' in most places
2991 and 'double' in a couple of places.
2992
efc00ab1 29932012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2994
2995 * xdisp.c (handle_stop): Detect whether we have overlay strings
2996 loaded by testing it->current.overlay_string_index to be
2997 non-negative, instead of checking whether n_overlay_strings is
2998 positive. (Bug#11587)
2999
efc00ab1 30002012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3001
3002 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3003
3004 * doc.c (Fsubstitute_command_keys): Doc fix.
3005
efc00ab1 30062012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3007
3008 * search.c (search_buffer): Remove calls to
3009 r_alloc_inhibit_buffer_relocation, as it is now called by
3010 maybe_unify_char, which was the cause of relocation of buffer text
3011 in bug#11519.
3012
efc00ab1 30132012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3014
3015 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3016 for the duration of call to load_charset, to avoid problems with
3017 callers of maybe_unify_char that access buffer text through C
3018 pointers.
3019
3020 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3021 decrement the inhibition flag, instead of just setting or
3022 resetting it.
3023
ba93a187
PE
30242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 Remove obsolete '#define static' cruft.
3027 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3028 This #undef was "temporary" in 2000; it is no longer needed
3029 now that '#define static' has gone away.
3030 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3031 (gray_bitmap_bits): Remove; no longer needed.
3032 All uses replaced with definiens.
3033 * xterm.c: Include "bitmaps/gray.xbm".
3034
9e4bf381
PE
30352012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3036
3037 Clean up __executable_start, monstartup when --enable-profiling.
3038 The following changes affect the code only when profiling.
3039 * dispnew.c (__executable_start): Rename from safe_bcopy.
3040 Define only on platforms that need it.
3041 * emacs.c: Include <sys/gmon.h> when profiling.
3042 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3043 (__executable_start): Remove decl, since lisp.h does it now.
3044 (safe_bcopy): Remove decl; no longer has that name.
3045 (main): Coalesce #if into single bit of code, for simplicity.
3046 Cast pointers to uintptr_t, since standard libraries want integers
3047 and not pointers.
3048 * lisp.h (__executable_start): New decl.
3049
32d72c2f
GM
30502012-05-31 Glenn Morris <rgm@gnu.org>
3051
3052 * image.c (Fimagemagick_types): Doc fix.
3053
baac5bc7
JM
30542012-05-30 Jim Meyering <meyering@redhat.com>
3055
3056 * callproc.c (Fcall_process_region): Include directory component
3057 in mkstemp error message (Bug#11586).
3058
72cb32cf
PE
30592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3060
3061 * alloc.c, lisp.h (make_pure_vector): Now static.
3062
61b108cc
SM
30632012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3064
3065 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3066 Move to byte-run.el.
3067 (Fautoload): Do the hash-doc more carefully.
3068 * data.c (Fdefalias): Purify definition, except for keymaps.
3069 (Qdefun): Move from eval.c.
3070 * lisp.h (Qdefun): Remove.
3071 * lread.c (read1): Tiny simplification.
3072
471fe23d
TN
30732012-05-29 Troels Nielsen <bn.troels@gmail.com>
3074
934f3f58 3075 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3076 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3077 Bug#9642, but explicitly check that the buffer the overlay would
3078 be moved to is live and rearrange lines to make sure that errors
3079 will not put the overlay in an inconsistent state.
3080 (Fdelete_overlay): Cosmetics.
3081
85d0efd1
EZ
30822012-05-28 Eli Zaretskii <eliz@gnu.org>
3083
3084 * w32term.c (my_bring_window_to_top): New function.
3085 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3086 could be different from the original one.
3087 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3088 (Bug#11513)
3089
3090 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3091 by calling BringWindowToTop.
3092
3093 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3094 (WM_EMACS_END): Increase by one.
3095
da92a98c
PE
30962012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3099 This avoids undefined behavior that might cause the eassert
3100 to not catch an out-of-range value.
3101
74d1f848
JB
31022012-05-28 Juanma Barranquero <lekktu@gmail.com>
3103
3104 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3105 Update dependencies.
3106
9e1a06fc
EZ
31072012-05-27 Eli Zaretskii <eliz@gnu.org>
3108
3109 * bidi.c (bidi_mirror_char): Fix last change.
3110
f3dd7312
AS
31112012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3112
3113 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3114 when referring to sectname field in printf format.
3115
81899c91
PE
31162012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3117
57b81a9f
PE
3118 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3119 Only r_alloc_inhibit_buffer_relocation needed to be added;
3120 the others were already declared.
3121
81899c91
PE
3122 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3123 before checking whether it's out of range. Put the check inside
3124 eassert. See
3125 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3126
33017faf 31272012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3128
3129 * callproc.c (Fcall_process): Restore a line that was accidentally
3130 commented out in the 2011-02-13 change (bug#11547).
3131
33017faf 31322012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3133
3134 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3135 defined on ralloc.c.
3136
3137 * buffer.c [REL_ALLOC]: Remove prototypes of
3138 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3139 they are now on lisp.h.
3140
3141 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3142
3143 * search.c (search_buffer): Use it to inhibit relocation of buffer
3144 text while re_search_2 is doing its job, because re_search_2 is
3145 passed C pointers to buffer text. (Bug#11519)
3146
23415acf
EZ
3147 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3148 Update value to 24.
3149
44e27368
EZ
3150 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3151 state after an additional call to move_it_in_display_line_to, keep
3152 the values of it->max_ascent and it->max_descent found for the
3153 entire line.
3154 (pos_visible_p): Revert the comparison against bottom_y to what it
3155 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3156 (Bug#11464)
3157
c1892f11
PE
31582012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 Fix coding-related core dumps with gcc -ftrapv.
3161 The code was computing A - B, where A and B are pointers, and B is
3162 random garbage. This can lead to core dumps on platforms that
3163 have special pointer registers, and it also leads to core dumps on
3164 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3165 A - B only when B is initialized properly.
3166 * coding.c (coding_set_source, coding_set_destination): Return void.
3167 (coding_change_source, coding_change_destinations): New functions,
3168 with the old behaviors of coding_set_source and coding_set_destination.
3169 All callers that need an offset changed to use these new functions.
3170
eb7afdad
GM
31712012-05-26 Glenn Morris <rgm@gnu.org>
3172
3173 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3174
f12fdf02
EZ
31752012-05-26 Eli Zaretskii <eliz@gnu.org>
3176
53a63be6 3177 Extend mouse support on W32 text-mode console.
61b108cc
SM
3178 * xdisp.c (draw_row_with_mouse_face):
3179 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3180
eb3f6f01 3181 * w32console.c: Include window.h.
61b108cc
SM
3182 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3183 New functions.
eb3f6f01
EZ
3184 (initialize_w32_display): Initialize mouse-highlight data.
3185
53a63be6
EZ
3186 * w32inevt.c: Include termchar.h and window.h.
3187 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3188 moves, call note_mouse_highlight. If help_echo changed, call
3189 gen_help_event to produce help-echo message in the echo area.
3190 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3191 highlight info.
3192
4cfd81f6
PE
31932012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3194
3195 * lread.c (read1): Simplify slightly to avoid an overflow warning
3196 with GCC 4.7.0 on x86-64.
3197
4446092a
EZ
31982012-05-26 Eli Zaretskii <eliz@gnu.org>
3199
3200 * bidi.c (bidi_mirror_char): Revert last change: an int is
3201 definitely wide enough here.
3202
42b2a986 32032012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3204
42b2a986 3205 Fix integer width and related bugs (Bug#9874).
eb106a49 3206 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3207 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3208 (string_bytes, check_sblock, allocate_string_data):
3209 (compact_small_strings, Fmake_bool_vector, make_string)
3210 (make_unibyte_string, make_multibyte_string)
3211 (make_string_from_bytes, make_specified_string)
3212 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3213 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3214 (mark_vectorlike):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 (allocate_pseudovector):
3217 Use int, not EMACS_INT, where int is wide enough.
3218 (inhibit_garbage_collection, Fgarbage_collect):
3219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3220 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3221 int might not be wide enough.
3222 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3223 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3224 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3225 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3226 (bidi_level_of_next_char, bidi_move_to_visually_next):
3227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3228 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3229 (Fkill_buffer, Fset_buffer_major_mode)
3230 (advance_to_char_boundary, Fbuffer_swap_text)
3231 (Fset_buffer_multibyte, overlays_at, overlays_in)
3232 (overlay_touches_p, struct sortvec, record_overlay_string)
3233 (overlay_strings, recenter_overlay_lists)
3234 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3235 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3236 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3237 (Foverlay_recenter, last_overlay_modification_hooks_used)
3238 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3240 (validate_region): Omit unnecessary test for b <= e,
3241 since that's guaranteed by the previous test.
d311d28c
PE
3242 (adjust_overlays_for_delete): Avoid pos + length overflow.
3243 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3244 (report_overlay_modification):
3245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3246 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3247 Omit pointer cast, which isn't needed anyway, and doesn't work
3248 after the EMACS_INT -> ptrdiff_t change.
02481186 3249 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3250 * buffer.h: Adjust decls to match defn changes elsewhere.
3251 (struct buffer_text, struct buffer):
3252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3253 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3254 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3255 not int, to avoid needless 32-bit limit on 64-bit hosts.
3256 (exec_byte_code): Use tighter memory-full test, one that checks
3257 for alloca overflow. Don't compute the address of the object just
3258 before an array, as that's not portable. Use EMACS_INT, not
3259 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3260 * callint.c (Fcall_interactively):
3261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3262 * callproc.c (call_process_kill, Fcall_process):
3263 Don't assume pid_t fits into an Emacs fixnum.
3264 (call_process_cleanup, Fcall_process, child_setup):
3265 Don't assume pid_t fits into int.
3266 (call_process_cleanup, Fcall_process, delete_temp_file)
3267 (Fcall_process_region):
3268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3269 (Fcall_process): Simplify handling of volatile integers.
3270 Use int, not EMACS_INT, where int will do.
3271 * casefiddle.c (casify_object, casify_region, operate_on_word)
3272 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3274 (casify_object): Avoid integer overflow when overallocating buffer.
3275 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3276 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3277 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3278 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3279 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3280 integers are now checked earlier. All uses replaced with XINT.
3281 (ccl_driver):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3284 (ccl_driver, Fregister_code_conversion_map):
3285 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3286 (resolve_symbol_ccl_program): Check that vector header is in range.
3287 Always copy the vector, so that we can check its contents reliably
3288 now rather than having to recheck each instruction as it's being
3289 executed. Check that vector words fit in 'int'.
3290 (ccl_get_compiled_code, Fregister_ccl_program)
3291 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3292 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3293 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3294 contents are in range.
3295 (Fccl_execute_on_string): Check that status is in range.
3296 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3297 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3298 Accept and return EMACS_INT, not int, because callers can pass values
3299 out of 'int' range.
3300 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3301 (multibyte_chars_in_text, parse_str_as_multibyte)
3302 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3303 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3304 (string_escape_byte8, Fget_byte):
3305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3306 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3307 avoid mishandling large integers.
3308 * character.h: Adjust decls to match defn changes elsewhere.
3309 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3310 (Ffind_charset_region):
3311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3312 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3313 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3314 Don't assume fixnum fits in int.
d311d28c
PE
3315 (load_charset_map_from_vector, Fmap_charset_chars):
3316 Remove now-unnecessary CHECK_NATNUMs.
3317 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3318 Don't rely on undefined behavior with signed left shift overflow.
3319 Don't assume unsigned int fits into fixnum, or that fixnum fits
3320 into unsigned int. Don't require max_code to be a valid fixnum;
3321 that's not true for gb10830 4-byte on a 32-bit host. Allow
3322 invalid_code to be a cons, for the same reason. Require code_offset
3323 to be a character. Avoid int overflow if max_char is close
3324 to INT_MAX.
3325 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3326 this is intended anyway and avoids some undefined behavior.
3327 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3328 INDEX_TO_CODE_POINT, as that's what it expects.
3329 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3330 * charset.h (DECODE_CHAR): Return int, not unsigned;
3331 this is what was intended anyway, and it avoids undefined behavior.
3332 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3333 integer-overflow issues.
3334 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3335 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3336 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3337 * chartab.c (Fmake_char_table, Fset_char_table_range)
3338 (uniprop_get_decoder, uniprop_get_encoder):
3339 Don't assume fixnum fits in int.
3340 * cmds.c (move_point): New function, that does the gist of
3341 Fforward_char and Fbackward_char, but does so while checking
3342 for integer overflow more accurately.
c96e5d6a 3343 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3344 (Fforward_line, Fend_of_line, internal_self_insert)
3345 (internal_self_insert):
3346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3347 Fix a FIXME, by checking for integer overflow when calculating
3348 target_clm and actual_clm.
3349 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3350 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3351 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3352 (coding_alloc_by_making_gap, alloc_destination)
3353 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3354 (encode_coding_utf_16, detect_coding_emacs_mule)
3355 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3356 (detect_coding_iso_2022, decode_coding_iso_2022)
3357 (encode_invocation_designation, encode_designation_at_bol)
3358 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3359 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3360 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3361 (encode_coding_ccl, encode_coding_raw_text)
3362 (detect_coding_charset, decode_coding_charset)
3363 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3364 (produce_composition, produce_charset, produce_annotation)
3365 (decode_coding, handle_composition_annotation)
3366 (handle_charset_annotation, consume_chars, decode_coding_gap)
3367 (decode_coding_object, encode_coding_object, detect_coding_system)
3368 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3369 (code_convert_region, code_convert_string)
8f50130c
PE
3370 (Fdefine_coding_system_internal)
3371 (coding_set_source, coding_set_destination):
d311d28c
PE
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3373 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3374 (Fdefine_coding_system_internal):
3375 Don't assume fixnums fit in int.
3376 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3377 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3378 (Funencodable_char_position, Fcheck_coding_systems_region)
3379 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3381 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3382 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3383 Don't access memory outside of the args array.
d311d28c 3384 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3385 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3386 result of ENCODE_CHAR.
d311d28c
PE
3387 * coding.h: Adjust decls to match defn changes elsewhere.
3388 (struct coding_system):
3389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3390 * composite.c (get_composition_id, find_composition)
3391 (run_composition_function, update_compositions)
3392 (compose_text, composition_gstring_put_cache)
3393 (composition_gstring_p, composition_gstring_width)
3394 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3395 (composition_compute_stop_pos, composition_reseat_it)
3396 (composition_update_it, struct position_record)
3397 (find_automatic_composition, composition_adjust_point)
3398 (Fcomposition_get_gstring, Ffind_composition_internal):
3399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3400 (update_compositions):
3401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3402 * composite.h: Adjust decls to match defn changes elsewhere.
3403 (struct composition):
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3406 Do not attempt to compute the address of the object just before a
3407 buffer; this is not portable.
3408 (Faref, Faset):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (Faset): Use int, not EMACS_INT, where int is wide enough.
3411 (Fstring_to_number): Don't assume fixnums fit in int.
3412 (Frem): Don't assume arg is nonnegative.
3413 * dbusbind.c (xd_append_arg): Check for integers out of range.
3414 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3415 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3416 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3417 (xd_get_connection_references): Return ptrdiff_t, not int.
3418 All uses changed.
3419 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3420 (xd_read_message_1):
3421 Use int, not unsigned, where the dbus API uses int.
3422 (Fdbus_message_internal): Don't overflow mtype.
3423 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3424 * dired.c (directory_files_internal, file_name_completion, scmp)
3425 (file_name_completion_stat):
3426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3427 (file_name_completion): Don't overflow matchcount.
3428 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3429 * dispextern.h: Adjust decls to match defn changes elsewhere.
3430 (struct text_pos, struct glyph, struct bidi_saved_info)
3431 (struct bidi_string_data, struct bidi_it, struct composition_it)
3432 (struct it):
3433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3434 (struct display_pos, struct composition_it, struct it):
3435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3436 * dispnew.c (increment_matrix_positions)
3437 (increment_row_positions, mode_line_string)
3438 (marginal_area_string):
3439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3440 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3442 (duration_to_sec_usec): New function, to check for overflow better.
3443 (Fsleep_for, sit_for): Use it.
3444 * doc.c (get_doc_string, store_function_docstring):
3445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3446 (get_doc_string, Fsnarf_documentation):
3447 Use int, not EMACS_INT, where int is wide enough.
3448 (get_doc_string):
3449 Use SAFE_ALLOCA, not alloca.
3450 Check for overflow when converting EMACS_INT to off_t.
3451 * doprnt.c (doprnt):
3452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3453 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3454 Don't assume uid_t fits into fixnum.
3455 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3456 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3457 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3458 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3459 (general_insert_function)
3460 (Finsert_char, make_buffer_string, make_buffer_string_both)
3461 (update_buffer_properties, Fbuffer_substring)
3462 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3463 (Fsubst_char_in_region, check_translation)
3464 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3465 (transpose_markers, Ftranspose_regions):
3466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3467 (clip_to_bounds): Move to lisp.h as an inline function).
3468 (Fconstrain_to_field): Don't assume integers are nonnegative.
3469 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3470 (Fsubst_char_in_region, Fsave_restriction):
3471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3472 (Femacs_pid): Don't assume pid_t fits into fixnum.
3473 (lo_time): Use int, not EMACS_INT, when int suffices.
3474 (lisp_time_argument): Check for usec out of range.
3475 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3476 (Fuser_login_name, Fuser_full_name): Signal an error
3477 if a uid argument is out of range, rather than relying on
3478 undefined behavior.
c8d5c857
PE
3479 (Fformat_time_string): Remove now-unnecessary check.
3480 lisp_time_argument checks for out-of-range usec now.
243e0530 3481 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3482 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3483 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3484 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3485 (init_cmdargs, Fdump_emacs):
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3488 the bottom (typically) 32 bits of the fixnum.
3489 * eval.c (specpdl_size, call_debugger):
3490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3491 (when_entered_debugger, Fbacktrace_debug):
3492 Don't assume fixnum can fit in int.
3493 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3494 the object just before a buffer; this is not portable.
3495 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3496 (grow_specpdl, unbind_to):
3497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3498 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3499 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3500 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3501 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3502 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3504 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3505 (a_write, e_write):
3506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3507 (Fcopy_file, non_regular_nbytes, read_non_regular)
3508 (Finsert_file_contents):
3509 Use int, not EMACS_INT, where int is wide enough.
3510 (READ_BUF_SIZE): Verify that it fits in int.
3511 (Finsert_file_contents): Check that counts are in proper range,
3512 rather than assuming fixnums fit into ptrdiff_t etc.
3513 Don't assume fixnums fit into int.
125b3835 3514 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3515 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3516 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3517 (string_char_to_byte, string_byte_to_char)
3518 (string_make_multibyte, string_to_multibyte)
3519 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3520 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3521 (substring_both, Fdelete, internal_equal, Ffillarray)
3522 (Fclear_string, mapcar1)
3523 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3524 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3525 (larger_vector, make_hash_table, maybe_resize_hash_table)
3526 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3527 (Fmaphash, secure_hash):
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3529 (concat): Check for string index and length overflow.
3530 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3531 (Frequire):
3532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3533 (larger_vector): New API (vec, incr_min, size_max) replaces old
3534 one (vec, new_size, init). This catches size overflow.
3535 INIT was removed because it was always Qnil.
3536 All callers changed.
3537 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3538 the upper bound on a hash table index size.
3539 (make_hash_table, maybe_resize_hash_table): Use it.
3540 (secure_hash): Computer start_byte and end_byte only after
3541 they're known to be in ptrdiff_t range.
3542 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3543 (Ffont_get_glyphs, Ffont_at):
3544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3545 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3546 (Flist_fonts, Fopen_font):
3547 Don't assume fixnum can fit in int.
3548 (check_gstring): Don't assume index can fit in int.
3549 (font_match_p): Check that fixnum is a character, not a nonnegative
3550 fixnum, since the later code needs to stuff it into an int.
3551 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3552 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3553 conversion overflow issues.
3554 (Fopen_font): Check for integer out of range.
3555 (Ffont_get_glyphs): Don't assume index can fit in int.
3556 * font.h: Adjust decls to match defn changes elsewhere.
3557 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3558 integer overflow.
3559 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3560 printmax_t, where ptrdiff_t is wide enough.
3561 (Finternal_char_font):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3564 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3565 (Fset_frame_position, x_set_frame_parameters)
3566 (x_set_line_spacing, x_set_border_width)
3567 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3568 Check that fixnums are in proper range for system types.
3569 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3571 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3572 Use SAFE_ALLOCA_LISP, not alloca.
3573 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3574 intptr_t is wide enough.
3575 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3576 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3577 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3578 Check for fixnum out of range.
3579 * ftfont.c (ftfont_list): Don't assume index fits in int.
3580 Check that fixnums are in proper range for system types.
3581 (ftfont_shape_by_flt):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3583 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3585 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3586 Check that fixnums are in proper range for system types.
3587 * gnutls.h: Adjust decls to match defn changes elsewhere.
3588 * gtkutil.c (xg_dialog_run):
3589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3590 (update_frame_tool_bar):
3591 Check that fixnums are in proper range for system types.
3592 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3593 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3594 * indent.c (last_known_column, last_known_column_point):
3595 (current_column_bol_cache):
3596 (skip_invisible, current_column, check_display_width):
3597 (check_display_width, scan_for_column, current_column_1)
3598 (Findent_to, Fcurrent_indentation, position_indentation)
3599 (indented_beyond_p, Fmove_to_column, compute_motion):
3600 (Fcompute_motion, Fvertical_motion):
3601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3602 (last_known_column_modified): Use EMACS_INT, not int.
3603 (check_display_width):
3604 (Fcompute_motion):
3605 Check that fixnums and floats are in proper range for system types.
3606 (compute_motion): Don't assume index or fixnum fits in int.
3607 (compute_motion, Fcompute_motion):
3608 Use int, not EMACS_INT, when it is wide enough.
3609 (vmotion): Omit local var start_hpos that is always 0; that way
3610 we don't need to worry about overflow in expressions involving it.
3611 * indent.h: Adjust decls to match defn changes elsewhere.
3612 (struct position):
3613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3614 Use int, not EMACS_INT, where int is wide enough.
3615 Remove unused members ovstring_chars_done and tab_offset;
3616 all uses removed.
3617 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3618 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3619 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3620 (make_gap, copy_text, insert, insert_and_inherit)
3621 (insert_before_markers, insert_before_markers_and_inherit)
3622 (insert_1, count_combining_before, count_combining_after)
3623 (insert_1_both, insert_from_string)
3624 (insert_from_string_before_markers, insert_from_string_1)
3625 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3626 (adjust_after_replace, adjust_after_insert, replace_range)
3627 (replace_range_2, del_range, del_range_1, del_range_byte)
3628 (del_range_both, del_range_2, modify_region)
3629 (prepare_to_modify_buffer, signal_before_change)
3630 (signal_after_change, Fcombine_after_change_execute):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3633 (balance_an_interval, split_interval_right, split_interval_left)
3634 (find_interval, next_interval, update_interval)
3635 (adjust_intervals_for_insertion, delete_node, delete_interval)
3636 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3637 (static_offset_intervals, offset_intervals)
3638 (merge_interval_right, merge_interval_left, make_new_interval)
3639 (graft_intervals_into_buffer, temp_set_point_both)
3640 (temp_set_point, set_point, adjust_for_invis_intang)
3641 (set_point_both, move_if_not_intangible, get_property_and_range)
3642 (get_local_map, copy_intervals, copy_intervals_to_string)
3643 (compare_string_intervals, set_intervals_multibyte_1):
3644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3645 * intervals.h: Adjust decls to match defn changes elsewhere.
3646 (struct interval):
3647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3648 * keyboard.c (this_command_key_count, this_single_command_key_start)
3649 (before_command_key_count, before_command_echo_length, echo_now)
3650 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3651 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3652 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3653 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3655 (last_non_minibuf_size, last_point_position, echo_truncate)
3656 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3657 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3658 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3659 (stuff_buffered_input):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (last_auto_save, command_loop_1, read_char):
3662 Use EMACS_INT, not int, to avoid integer overflow.
3663 (record_char): Avoid overflow in total_keys computation.
3664 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3665 * keyboard.h: Adjust decls to match defn changes elsewhere.
3666 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3667 (Fkey_description, Fdescribe_vector, Flookup_key):
3668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3669 (click_position): New function, to check that positions are in range.
3670 (Fcurrent_active_maps):
3671 (describe_command):
3672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3673 (Faccessible_keymaps, Fkey_description):
3674 (preferred_sequence_p):
3675 Don't assume fixnum can fit into int.
3676 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3677 Check for integer overflow in size calculations.
3678 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3679 avoid mishandling large integers.
3680 * lisp.h: Adjust decls to match defn changes elsewhere.
3681 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3682 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3683 (struct Lisp_Marker):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3686 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3687 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3688 All callers changed.
3689 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3690 Assume the arg has valid form, since it always does.
3691 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3692 unsigned integer system type.
3693 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3694 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3696 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3697 (duration_to_sec_usec): New decl.
3698 * lread.c (read_from_string_index, read_from_string_index_byte)
3699 (read_from_string_limit, readchar, unreadchar, openp)
3700 (read_internal_start, read1, oblookup):
3701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3702 (Fload, readevalloop, Feval_buffer, Feval_region):
3703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3704 (openp): Check for out-of-range argument to 'access'.
3705 (read1): Use int, not EMACS_INT, where int is wide enough.
3706 Don't assume fixnum fits into int.
6efdadfd 3707 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3708 (read_filtered_event): Use duration_to_sec_usec
3709 to do proper overflow checking on durations.
d311d28c
PE
3710 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3711 in size calculation.
3712 (Fexecute_kbd_macro):
3713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3714 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3715 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3716 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3717 (set_marker_both, set_marker_restricted_both, marker_position)
3718 (marker_byte_position, Fbuffer_has_markers_at):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3720 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3721 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3722 It now merely ensures that the menu is large enough, without
3723 necessarily growing it, as this avoids some integer overflow issues.
3724 All callers changed.
3725 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3727 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3728 Use SAFE_ALLOCA_LISP, not alloca.
3729 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3730 to EMACS_INT. Check that fixnums are in proper range for system types.
3731 * minibuf.c (minibuf_prompt_width, string_to_object)
3732 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3733 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3735 (get_minibuffer, read_minibuf_unwind):
3736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3737 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3738 this simplifies overflow checking. All callers changed.
3739 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3740 (Ftest_completion):
3741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3742 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3743 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3744 Check that fixnums are in proper range for system types.
3745 (Fx_create_frame, Fx_show_tip):
3746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3747 * nsfont.m (ns_findfonts, nsfont_list_family):
3748 Don't assume fixnum fits in long.
3749 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3752 wide enough.
17fdb222 3753 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3755 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3756 (PRINTDECLARE, PRINTPREPARE):
3757 (strout, print_string):
3758 (print, print_preprocess, print_check_string_charset_prop)
3759 (print_object):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 (PRINTDECLARE):
3762 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3764 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3765 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3766 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3767 (print_error_message): Use SAFE_ALLOCA, not alloca.
3768 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3769 (print_depth, new_backquote_output, print_number_index):
3770 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3771 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3772 (Fset_process_window_size, Fformat_network_address)
3773 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3774 (sigchld_handler):
d311d28c 3775 Check that fixnums are in proper range for system types.
d44287d4 3776 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3777 Check for process-ids out of pid_t range rather than relying on
3778 undefined behavior.
e4d81efc 3779 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3780 (Fformat_network_address, read_process_output, send_process)
3781 (Fprocess_send_region, status_notify):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3784 (wait_reading_process_output, read_process_output, exec_sentinel):
3785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3786 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3787 (Faccept_process_output): Use duration_to_sec_usec to do proper
3788 overflow checking on durations.
dde14581
PE
3789 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3790 Don't assume pid_t fits in int.
02481186
PE
3791 * process.h (struct Lisp_Process): Members tick and update_tick
3792 are now of type EMACS_INT, not int.
b62b53e8
PE
3793 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3794 configured --with-wide-int.
d311d28c
PE
3795 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3796 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3797 * search.c (looking_at_1, string_match_1):
3798 (fast_string_match, fast_c_string_match_ignore_case)
3799 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3800 (scan_newline, find_before_next_newline, search_command)
3801 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3802 (set_search_regs, wordify):
3803 (Freplace_match):
3804 (Fmatch_data):
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (string_match_1, search_buffer, set_search_regs):
3807 (Fmatch_data):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (wordify): Check for overflow in size calculation.
3810 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3811 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3812 Check that fixnums are in proper range for system types.
3813 * sound.c (struct sound_device)
3814 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3816 (Fplay_sound_internal):
3817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3818 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3819 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3820 (Fparse_partial_sexp):
3821 Don't assume fixnums can fit in int.
3822 (struct lisp_parse_state, find_start_pos, find_start_value)
3823 (find_start_value_byte, find_start_begv)
3824 (update_syntax_table, char_quoted, dec_bytepos)
3825 (find_defun_start, prev_char_comend_first, back_comment):
3826 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3827 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (Finternal_describe_syntax_value): Check that match_lisp is a
3830 character, not an integer, since the code stuffs it into int.
3831 (scan_words, scan_sexps_forward):
3832 Check that fixnums are in proper range for system types.
3833 (Fforward_word):
3834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3835 (scan_sexps_forward):
3836 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3837 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3838 * syntax.h: Adjust decls to match defn changes elsewhere.
3839 (struct gl_state_s):
3840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3841 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3842 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3843 * sysdep.c (wait_for_termination_1, wait_for_termination)
3844 (interruptible_wait_for_termination, mkdir):
3845 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3846 (emacs_read, emacs_write):
3847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3848 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3849 and double all fit in int.
d311d28c
PE
3850 * term.c (set_tty_color_mode):
3851 Check that fixnums are in proper range for system types.
3852 * termhooks.h (struct input_event):
3853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3854 * textprop.c (validate_interval_range, interval_of)
3855 (Fadd_text_properties, set_text_properties_1)
3856 (Fremove_text_properties, Fremove_list_of_text_properties)
3857 (Ftext_property_any, Ftext_property_not_all)
3858 (copy_text_properties, text_property_list, extend_property_ranges)
3859 (verify_interval_modification):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 (Fnext_single_char_property_change)
3862 (Fprevious_single_char_property_change):
3863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3864 (copy_text_properties):
3865 Check for integer overflow in index calculation.
d311d28c
PE
3866 * undo.c (last_boundary_position, record_point, record_insert)
3867 (record_delete, record_marker_adjustment, record_change)
3868 (record_property_change):
3869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3870 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3872 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3873 (Fx_hide_tip, Fx_file_dialog):
3874 * w32menu.c (set_frame_menubar):
3875 Use ptrdiff_t, not int, for consistency with rest of code.
3876 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3877 (select_window, Fdelete_other_windows_internal)
3878 (window_scroll_pixel_based, window_scroll_line_based)
3879 (Frecenter, Fset_window_configuration):
3880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3881 (Fset_window_hscroll, run_window_configuration_change_hook)
3882 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3883 (Fscroll_other_window, Frecenter):
d311d28c
PE
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3885 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3886 Don't assume fixnum fits in int.
3887 (Fset_window_scroll_bars):
3888 Check that fixnums are in proper range for system types.
3889 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3890 (string_pos, c_string_pos, number_of_chars, init_iterator)
3891 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3892 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3893 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3894 (face_before_or_after_it_pos, handle_invisible_prop)
3895 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3896 (display_prop_intangible_p, string_buffer_position_lim)
3897 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3898 (get_overlay_strings_1, get_overlay_strings)
3899 (iterate_out_of_display_property, forward_to_next_line_start)
3900 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3901 (get_next_display_element, set_iterator_to_next)
3902 (get_visually_first_element, compute_stop_pos_backwards)
3903 (handle_stop_backwards, next_element_from_buffer)
3904 (move_it_in_display_line_to, move_it_in_display_line)
3905 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3906 (add_to_log, message_dolog, message_log_check_duplicate)
3907 (message2, message2_nolog, message3, message3_nolog
3908 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3909 (current_message_1, truncate_echo_area, truncate_message_1)
3910 (set_message, set_message_1, store_mode_line_noprop)
3911 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3912 (text_outside_line_unchanged_p, check_point_in_composition)
3913 (reconsider_clip_changes)
3914 (redisplay_internal, set_cursor_from_row, try_scrolling)
3915 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3916 (redisplay_window, find_last_unchanged_at_beg_row)
3917 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3918 (trailing_whitespace_p, find_row_edges, display_line)
3919 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3920 (display_mode_element, store_mode_line_string)
3921 (pint2str, pint2hrstr, decode_mode_spec)
3922 (display_count_lines, display_string, draw_glyphs)
3923 (x_produce_glyphs, x_insert_glyphs)
3924 (rows_from_pos_range, mouse_face_from_buffer_pos)
3925 (fast_find_string_pos, mouse_face_from_string_pos)
3926 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (safe_call, init_from_display_pos, handle_fontified_prop)
3929 (handle_single_display_spec, load_overlay_strings)
3930 (with_echo_area_buffer, setup_echo_area_for_printing)
3931 (display_echo_area, echo_area_display)
3932 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3933 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3934 (redisplay_window, dump_glyph_row, display_mode_line)
3935 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3936 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3938 (handle_single_display_spec, build_desired_tool_bar_string)
3939 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3940 (get_specified_cursor_type):
3941 Check that fixnums are in proper range for system types.
3942 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3943 (Flookup_image_map):
3944 Don't assume fixnums fit in int.
3945 (compare_overlay_entries):
3946 Avoid mishandling comparisons due to subtraction overflow.
3947 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3948 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3949 (handle_tool_bar_click):
3950 Use int, not unsigned, since we prefer signed and the signedness
3951 doesn't matter here.
3952 (get_next_display_element, next_element_from_display_vector):
3953 Use int, not EMACS_INT, when int is wide enough.
3954 (start_hourglass): Use duration_to_sec_usec to do proper
3955 overflow checking on durations.
3956 * xfaces.c (Fbitmap_spec_p):
3957 Check that fixnums are in proper range for system types.
3958 (compare_fonts_by_sort_order):
3959 Avoid mishandling comparisons due to subtraction overflow.
3960 (Fx_family_fonts, realize_basic_faces):
3961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3962 (Fx_family_fonts):
3963 Don't assume fixnum fits in int.
3964 Use SAFE_ALLOCA_LISP, not alloca.
3965 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3966 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3967 (face_at_buffer_position, face_for_overlay_string)
3968 (face_at_string_position):
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3970 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3971 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3972 (Fx_show_tip):
3973 Check that fixnums are in proper range for system types.
3974 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3975 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3977 (Fx_change_window_property): Don't assume fixnums fit in int.
3978 * xfont.c (xfont_chars_supported):
3979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3980 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3981 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3983 * xml.c (parse_region):
3984 * xrdb.c (magic_file_p):
3985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3986 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3987 (x_get_local_selection, x_reply_selection_request)
3988 (x_handle_selection_request, wait_for_property_change):
3989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3990 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3991 short is wide enough.
3992 (x_send_client_event): Don't assume fixnum fits in int.
3993 * xterm.c (x_x_to_emacs_modifiers):
3994 Don't assume EMACS_INT overflows nicely into int.
3995 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3996 may come from Lisp.
3997 (handle_one_xevent): NATNUMP can eval its arg twice.
3998 (x_connection_closed):
3999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4000 * xterm.h: Adjust decls to match defn changes elsewhere.
4001 (struct scroll_bar): Use struct vectorlike_header
4002 rather than rolling our own approximation.
4003 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4004
c6574eb5
GM
40052012-05-25 Glenn Morris <rgm@gnu.org>
4006
4007 * lisp.mk (lisp): Update for more files being compiled now.
4008
e8d32c7e
SM
40092012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4010
48def666
SM
4011 * lread.c: Remove `read_pure' which makes no difference.
4012 (read_pure): Remove var.
4013 (unreadpure): Remove function.
4014 (readevalloop): Don't call read_list with -1 flag.
4015 (read1, read_vector): Don't test read_pure any more.
4016 (read_list): Simplify.
4017
e8d32c7e
SM
4018 * fileio.c, character.h: Minor style tweaks.
4019
4b2addb7
DA
40202012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4021
4022 * window.h (clip_changed): Remove useless declaration.
4023
584461b2
JB
40242012-05-22 Juanma Barranquero <lekktu@gmail.com>
4025
4026 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4027 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4028
34374650
PE
40292012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 Remove src/m/*.
4032 This directory predates autoconf and is no longer needed nowadays.
4033 Move its few remaining bits of functionality to where they're needed.
4034 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4035 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4036 * m/template.h: Remove.
4037 * Makefile.in (M_FILE): Remove. All uses removed.
4038 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4039 * lisp.h (USE_LSB_TAG):
4040 * mem-limits.h (EXCEEDS_LISP_PTR):
4041 Use VAL_MAX, not VALBITS, in #if.
4042 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4043 (EMACS_UINT): Define unconditionally now.
4044 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4045 (BITS_PER_EMACS_INT): New constants, replacing
4046 what used to be in config.h, but not useful in #if.
4047 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4048 define them any more.
4049 (VAL_MAX): New macro.
4050 (VALMASK): Use it.
4051 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4052 BITS_PER_EMACS_INT, in #if.
4053 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4054 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4055 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4056 * s/ms-w32.h (DATA_START):
4057 Move here from removed file m/intel386.h.
4058 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4059 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4060
261cb4bb
PE
40612012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 Assume C89 or later.
4064 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4065 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4066 (xrealloc):
4067 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4068 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4069 * textprop.c, tparam.c (NULL): Remove.
4070 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4071 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4072 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4073 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4074 * xterm.c (input_signal_count): Assume volatile works.
4075
ff23cd9f
KB
40762012-05-21 Ken Brown <kbrown@cornell.edu>
4077
4078 * xgselect.c (xg_select): Fix first argument in call to 'select'
4079 (bug#11508).
4080
1b170bc6
KB
40812012-05-20 Ken Brown <kbrown@cornell.edu>
4082
4083 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4084 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4085
b2f4d39f
KB
40862012-05-19 Ken Brown <kbrown@cornell.edu>
4087
4088 * xfns.c (x_in_use): Remove `static' qualifier.
4089 * xterm.h (x_in_use): Declare.
4090 * xgselect.c: Include xterm.h.
4091 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4092 and `display_arg' (bug#9754).
4093
003fdae2
PE
40942012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4095
9232a6d9
PE
4096 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4097
003fdae2
PE
4098 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4099 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4100
784b56e2
EZ
41012012-05-18 Eli Zaretskii <eliz@gnu.org>
4102
4103 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4104
4105 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4106 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4107
4108 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4109 reference to image_cache->refcount.
4110 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4111
a0a79cde
JL
41122012-05-17 Juri Linkov <juri@jurta.org>
4113
4114 * search.c (Fword_search_regexp, Fword_search_backward)
4115 (Fword_search_forward, Fword_search_backward_lax)
4116 (Fword_search_forward_lax): Move functions to isearch.el
4117 (bug#10145, bug#11381).
4118
b0572523
PE
41192012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4122
9660f5fc
SM
41232012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * lread.c (init_obarray): Declare Qt and Qnil as special.
4126
4374de83
GM
41272012-05-14 Glenn Morris <rgm@gnu.org>
4128
4129 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4130 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4131
dc44c39a
PE
41322012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4133
078c97cb
PE
4134 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4135
dc44c39a
PE
4136 * unexaix.c: Port to more-recent AIX compilers.
4137 (report_error, report_error_1, make_hdr, copy_sym)
4138 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4139 Make arguments const char *, not char *, to avoid violations of C
4140 standard and to fix some AIX warnings reported by Gilles Pion.
4141
e18afed7 41422012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4143
4144 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4145 already have overlays loaded.
4146 (handle_single_display_spec): Before returning without displaying
4147 fringe bitmap, synchronize the bidi iterator with the main display
4148 iterator, by calling iterate_out_of_display_property.
4149 (iterate_out_of_display_property): Detect buffer iteration by
4150 testing that it->string is a Lisp string.
4151 (get_next_display_element): When the current object is exhausted,
4152 and there's something on it->stack, call set_iterator_to_next to
4153 proceed with what's on the stack, instead of returning zero.
4154 (set_iterator_to_next): If called at the end of a Lisp string,
4155 proceed to consider_string_end without incrementing string
4156 position. Don't increment display vector index past the end of
4157 the display vector. (Bug#11417)
c8fb9dc6
EZ
4158 (pos_visible_p): Don't report a position visible when move_it_to
4159 stopped at the last line of window, which happens to be scanned
4160 backwards by the bidi iteration. (Bug#11464)
ac268e67 4161
e18afed7 41622012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4163
4164 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4165 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4166 are on a TTY, and thus unable to display on the fringes.
4167 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4168 so we need to signal to the caller that this is a "replacing"
4169 display spec. This fixes display when the spec is invalid or we
4170 are on a TTY.
4171
e18afed7 41722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4173
4174 * unexaix.c (make_hdr): Fix typo in prototype.
4175 This bug broke the build on AIX. Problem reported by Gilles Pion.
4176
9d0a235a
MA
41772012-05-14 Michael Albinus <michael.albinus@gmx.de>
4178
4179 * keyboard.c (kbd_buffer_get_event): Read special events also in
4180 batch mode. (Bug#11415)
4181
9e6b06ed
GM
41822012-05-12 Glenn Morris <rgm@gnu.org>
4183
4184 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4185
c1a1d7a3
EZ
41862012-05-12 Eli Zaretskii <eliz@gnu.org>
4187
4188 * lisp.mk (lisp): Add newcomment.elc.
4189
3fe7cdc8
GM
41902012-05-12 Glenn Morris <rgm@gnu.org>
4191
4192 * Makefile.in (MKDIR_P): New, set by configure.
4193 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4194
53f7d2c0
PE
41952012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4196
4197 Remove unused function hourglass_started.
4198 * dispextern.h (hourglass_started):
4199 * w32fns.c (hourglass_started):
4200 * xdisp.c (hourglass_started): Remove.
4201
75aafb17
JB
42022012-05-10 Juanma Barranquero <lekktu@gmail.com>
4203
4204 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4205 Update dependencies.
4206
12959e8e
PE
42072012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4208
97107e2e
PE
4209 * xgselect.c (xg_select): Put maxfds+1 into a var.
4210 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4211
12959e8e
PE
4212 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4213
836d29b3
DA
42142012-05-10 Dave Abrahams <dave@boostpro.com>
4215
4216 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4217 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4218
5cb67954
MA
42192012-05-09 Michael Albinus <michael.albinus@gmx.de>
4220
4221 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4222 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4223 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4224 Initialize xd_registered_buses.
4225
3478ec45
PE
42262012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4227
b263a6b0
PE
4228 Untag more efficiently if USE_LSB_TAG.
4229 This is based on a proposal by YAMAMOTO Mitsuharu in
4230 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4231 For an admittedly artificial (nth 8000 longlist) benchmark on
4232 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4233 Emacs's overall text size by 1%.
4234 * lisp.h (XUNTAG): New macro.
4235 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4236 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4237 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4238 * eval.c (Fautoload):
4239 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4240 * frame.h (XFRAME): Use XUNTAG.
4241
3478ec45
PE
4242 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4243 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4244 Remove unportable assumptions about print widths of types like
4245 dbus_uint32_t.
4246 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4247 intptr_t when converting between pointer and integer, to avoid GCC
4248 warnings about wrong width.
4249
666b903b 42502012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4251
4252 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4253 stack for each reader_thread, instead of defaulting to 8MB
4254 determined by the linker. This avoids failures in creating
4255 subprocesses on Windows 7, see the discussion in this thread:
4256 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4257
b120cc17
JC
42582012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4259
4260 Fix up display of the *Minibuf-0* buffer in the mini window.
4261 * keyboard.c (read_char): Don't clear the echo area if there's no
4262 message to clear.
4263 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4264 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4265
9a4b36f8
MA
42662012-05-07 Michael Albinus <michael.albinus@gmx.de>
4267
4268 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4269 batch mode.
4270
e5f9458f
CY
42712012-05-06 Chong Yidong <cyd@gnu.org>
4272
4273 * lisp.mk (lisp): Update.
4274
eceeb5fc 42752012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4276
4277 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4278
71873e2b
SM
42792012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * data.c (PUT_ERROR): New macro.
4282 (syms_of_data): Use it. Add new error type `user-error'.
4283 * undo.c (user_error): New function.
4284 (Fprimitive_undo): Use it.
4285 * print.c (print_error_message): Adjust print style for `user-error'.
4286 * keyboard.c (user_error): New function.
4287 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4288
ab0fa4e4
PE
42892012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 Do not limit current-time-string to years 1000..9999.
4292 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4293 (Fcurrent_time_string): Support any year that is supported by the
4294 underlying localtime representation. Don't use asctime, as it
4295 has undefined behavior for years outside the range -999..9999.
4296
7ed806a7
PE
42972012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 Fix race conditions involving setenv, gmtime, localtime, asctime.
4300 Without this fix, interrupts could mess up code that uses these
4301 nonreentrant functions, since setting TZ invalidates existing
4302 tm_zone or tzname values, and since most of these functions return
4303 pointers to static storage.
4304 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4305 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4306 Grow the critical sections to include not just invoking
4307 localtime/gmtime, but also accessing these functions' results
4308 including their tm_zone values if any, and any related TZ setting.
4309 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4310 so that the struct tm is saved in the critical section.
4311 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4312 motivated by the fact that memory allocation needs to be outside
4313 the critical section.
4314
0c16dfed
DA
43152012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4316
4317 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4318 with RESET_INTERVAL.
4319
4320 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4321 Remove duplicated buffer name initialization.
4322
3f83ace8
JM
43232012-05-02 Jim Meyering <jim@meyering.net>
4324
4325 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4326
c7b8541e
JM
4327 * xfns.c (x_window): Use xstrdup (Bug#11375).
4328
90207a15 43292012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4330
4331 * xdisp.c (pos_visible_p): If already at a newline from the
4332 display string before the 'while' loop, don't walk back the glyphs
4333 from it3.glyph_row. Solves assertion violation when the display
4334 string begins with a newline (egg.el). (Bug#11367)
4335
b593d6a9
AH
43362012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4337
4338 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4339 Move to simple.el.
4340
4737362e
GM
43412012-05-01 Glenn Morris <rgm@gnu.org>
4342
99cf43f9
GM
4343 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4344 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4345 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4346 All were removed before 23.1.
4347
9311dcff
GM
4348 * dispnew.c: Remove HAVE_LIBNCURSES test;
4349 it is always true on relevant platforms.
4350
4d5c6349
GM
4351 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4352 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4353
4737362e
GM
4354 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4355
74dd3a6b
AS
43562012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4357
4358 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4359 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4360 Remove.
4361
13c379ee
PE
43622012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4363
4364 Do not avoid creating empty evaporating overlays (Bug#9642).
4365 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4366 That is, do not delete an evaporating overlay if it becomes
4367 empty after its bounds are adjusted to fit within its buffer.
4368 This fix caused other problems, and I'm reverting it until we get
4369 to the bottom of them.
4370
a8e7d6d7 43712012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4372
4373 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4374
a8e7d6d7 43752012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4376
4377 * xdisp.c (pos_visible_p): If the window start position is beyond
4378 ZV, start the display from buffer beginning. Prevents assertion
4379 violation in init_iterator when the minibuffer window is scrolled
4380 via the scroll bar.
4381
4382 * window.c (window_scroll_pixel_based): Likewise.
4383
a8e7d6d7 43842012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4385
4386 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4387
a8e7d6d7 43882012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4389
4390 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4391 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4392
a8e7d6d7 43932012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4394
b593d6a9
AH
4395 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4396 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4397
1c6900d9
EZ
43982012-04-26 Eli Zaretskii <eliz@gnu.org>
4399
4c3fa1d9
EZ
4400 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4401 display element, check also the underlying string or buffer
4402 character. (Bug#11341)
4403
1c6900d9
EZ
4404 * w32menu.c: Include w32heap.h.
4405 (add_menu_item): If the call to AppendMenuW (via
4406 unicode_append_menu) fails, disable Unicode menus only if we are
4407 running on Windows 9X/Me.
4408
42bf8205
AS
44092012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4410
4411 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4412 (xgetint): Add missing shift for LSB tags.
4413
b1bac16e
MR
44142012-04-24 Martin Rudalics <rudalics@gmx.at>
4415
4416 * keyboard.c (read_char): Don't wipe echo area for select window
4417 events: These might get delayed via `mouse-autoselect-window'
4418 (Bug#11304).
4419
d69621cc
JB
44202012-04-24 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4423 manipulation of :loaded-from data.
4424
02fd101b
JB
44252012-04-23 Juanma Barranquero <lekktu@gmail.com>
4426
4427 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4428 now a cons (bug#11311).
4429
888bec30
PE
44302012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4431
89a438bd
PE
4432 Do not create empty overlays with the evaporate property (Bug#9642).
4433 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4434 if it becomes empty after its bounds are adjusted to fit within
4435 its buffer. Without this fix, in a nonempty buffer (let ((o
4436 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4437 yields an empty overlay that has the evaporate property, which is
4438 not supposed to happen.
4439
1068fe4d
PE
4440 Fix minor GTK3 problems found by static checking.
4441 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4442 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4443 (struct _EmacsFixedClass, emacs_fixed_get_type):
4444 Move decls here from emacsgtkfixed.h, since they needn't be public.
4445 (emacs_fixed_get_type): Now static.
4446 (emacs_fixed_class_init): Omit unused local.
4447 (emacs_fixed_child_type): Remove; unused.
4448 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4449 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4450 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4451 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4452 (EMACS_FIXED_GET_CLASS): Remove; unused.
4453 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4454
888bec30
PE
4455 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4456 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4457
de85e130
PE
44582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4459
d0baac98 4460 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4461 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4462 (__malloc_size_t, __malloc_ptrdiff_t):
4463 Remove. All uses removed, replaced by the definiens if needed,
4464 since we can assume C89 or better now.
4465 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4466 (protect_malloc_state, align, get_contiguous_space)
4467 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4468 (malloc_atfork_handler_child, malloc_enable_thread)
4469 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4470 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4471 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4472 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4473 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4474 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4475 Define using prototypes, not old style.
4476 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4477 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4478 (align): Don't assume that signed integer overflow wraps around.
4479 Omit unused local var.
4480 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4481 (_free_internal_nolock, memalign, mallochook, reallochook):
4482 Omit no-longer-needed casts.
4483 (valloc): Use getpagesize, not __getpagesize.
4484 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4485 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4486
de85e130
PE
4487 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4488
dcbf5805
MA
44892012-04-22 Michael Albinus <michael.albinus@gmx.de>
4490
4491 Move functions from C to Lisp. Make non-blocking method calls
4492 the default. Implement further D-Bus standard interfaces.
4493
4494 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4495 (QCdbus_request_name_allow_replacement)
4496 (QCdbus_request_name_replace_existing)
4497 (QCdbus_request_name_do_not_queue)
4498 (QCdbus_request_name_reply_primary_owner)
4499 (QCdbus_request_name_reply_in_queue)
4500 (QCdbus_request_name_reply_exists)
4501 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4502 (QCdbus_registered_serial, QCdbus_registered_method)
4503 (QCdbus_registered_signal): New Lisp objects.
4504 (XD_DEBUG_MESSAGE): Use sizeof.
4505 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4506 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4507 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4508 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4509 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4510 (xd_signature, xd_append_arg): Allow float for integer types.
4511 (xd_get_connection_references): New function.
b593d6a9
AH
4512 (xd_get_connection_address): Rename from xd_initialize.
4513 Return cached address.
dcbf5805
MA
4514 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4515 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4516 level.
4517 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4518 Return number of refcounts.
dcbf5805
MA
4519 (Fdbus_get_unique_name): Make stronger parameter check.
4520 (Fdbus_message_internal): New defun.
4521 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4522 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4523 (Fdbus_send_signal, Fdbus_register_service)
4524 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4525 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4526 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4527 (Vdbus_compiled_version, Vdbus_runtime_version)
4528 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4529 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4530 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4531 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4532 Adapt docstring.
dcbf5805 4533
52828e02
PE
45342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4535
da05bc4c
PE
4536 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4537 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4538 Do not assume ptrdiff_t is the same width as 'int'.
4539
52828e02
PE
4540 * alloc.c: Handle unusual debugging option combinations.
4541 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4542 since the two debugging options are incompatible.
4543 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4544 is defined.
4545 (mem_init, mem_insert, mem_insert_fixup):
4546 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4547 (NEED_MEM_INSERT): Remove; no longer needed.
4548
f01769f9
LL
45492012-04-22 Leo Liu <sdl.web@gmail.com>
4550
4551 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4552
5790543d
PE
45532012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4554
4555 * sysdep.c [__FreeBSD__]: Minor cleanups.
4556 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4557 Use Emacs indenting style more consistently. Avoid some casts.
4558 Use 'double' consistently rather than mixing 'float' and 'double'.
4559
b91b7e4d
EW
45602012-04-21 Eduard Wiebe <usenet@pusto.de>
4561
b593d6a9
AH
4562 * sysdep.c (list_system_processes, system_process_attributes):
4563 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4564
6114eb15
AS
45652012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4566
4567 * lisp.mk (lisp): Update.
4568
2f38dff7
PE
45692012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4572 It is never used otherwise.
4573
4ae29f89
SM
45742012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4575
4576 * print.c (print_preprocess): Only check print_depth if print-circle
4577 is nil.
4578 (print_object): Check for cycles even when print-circle is nil and
4579 print-gensym is t, but only check print_depth if print-circle is nil.
4580
f30d612a
CY
45812012-04-20 Chong Yidong <cyd@gnu.org>
4582
4583 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4584 set the status to "failed" and ensure that sentinel is run.
4585
c07a4c0b 45862012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4587
4588 * process.c (Fset_process_inherit_coding_system_flag)
4589 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4590 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4591
c07a4c0b 45922012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4593
4594 * xdisp.c (string_buffer_position_lim): Limit starting position to
4595 BEGV.
4596 (set_cursor_from_row): If called for a mode-line or header-line
4597 row, return zero immediately.
4598 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4599 farther than the first row after the header line, if any.
4600 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4601 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4602
c07a4c0b 46032012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4604
4ae29f89
SM
4605 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4606 (bug#11238).
ad3a2b41 4607
c07a4c0b 46082012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 46092012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4610
4611 configure: new option --enable-gcc-warnings (Bug#11207)
4612 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4613 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4614 (ALL_CFLAGS): Use new macros rather than old.
4615 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4616 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4617 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4618 -Wunused-result, -Wunused-variable. This should go away once
4619 the Emacs and Gnulib regex code is merged.
4620 (xmalloc, xrealloc): Now static.
4621
aba027e8
PE
46222012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 * dired.c (Fsystem_groups): Remove unused local.
4625
e5a36063
GM
46262012-04-17 Glenn Morris <rgm@gnu.org>
4627
4628 * dired.c (Fsystem_users): Doc fix.
4629
316411f0
DA
46302012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4631
4632 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4633 (syms_of_dired): Add them.
4634
9426aba4
PE
46352012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4636
b62a57be
PE
4637 Fix minor alloc.c problems found by static checking.
4638 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4639 New extern decls, to avoid calling undeclared functions.
4640 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4641 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4642 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4643 (NEED_MEM_INSERT): New macro.
4644 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4645 Remove one incorrect comment and fix another.
b62a57be 4646
3539f31f
PE
4647 Fix minor ralloc.c problems found by static checking.
4648 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4649 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4650 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4651 (r_alloc_sbrk): Now static.
4652
a041960a
PE
4653 Improve ralloc.c interface checking.
4654 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4655 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4656 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4657 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4658 [REL_ALLOC]: ... to here, to check interface.
4659 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4660 Remove decls. This fixes an "It stinks!".
4661
9426aba4
PE
4662 * alloc.c (which_symbols): Fix alignment issue / type clash.
4663
d55c12ed
AS
46642012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4665
4666 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4667 (struct Lisp_Misc_Any): Likewise.
4668 (struct Lisp_Free): Likewise.
4669 * alloc.c (union aligned_Lisp_Symbol): Define.
4670 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4671 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4672 (union aligned_Lisp_Misc): Define.
4673 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4674 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4675 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4676
b948ce8b
PE
46772012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4678
4679 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4680 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4681 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4682 * s/netbsd.h, s/sol2-6.h:
4683 Remove definition of GC_MARK_STACK, since the default now works.
4684 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4685 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4686 no longer the default.
4687 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4688
35dc09a1 46892012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4690
35dc09a1
GM
4691 * lread.c (lisp_file_lexically_bound_p):
4692 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4693
35dc09a1
GM
46942012-04-14 Eli Zaretskii <eliz@gnu.org>
4695
4696 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4697 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4698
46992012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4700
4701 * nsterm.m (constrainFrameRect): Always constrain when there is only
4702 one screen (Bug#10962).
4703
bcd86815
KB
47042012-04-13 Ken Brown <kbrown@cornell.edu>
4705
4706 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4707
c25df26e
RT
47082012-04-13 Reuben Thomas <rrt@sc3d.org>
4709
4710 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4711
0fc59f1e
DC
47122012-04-11 Daniel Colascione <dancol@dancol.org>
4713
4714 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4715 against is gone. It's better to use vfork now so that when Cygwin
4716 gains a new, working vfork, we use it automatically (bug#10398).
4717
de8c03dc
SM
47182012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4719
4720 * window.c (save_window_save): Obey window-point-insertion-type.
4721
2f097256
GM
47222012-04-11 Glenn Morris <rgm@gnu.org>
4723
4724 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4725
453b951e
SM
47262012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4727
4728 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4729
75f1671a 47302012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4731
4732 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4733 (force_quit_count): New var.
4734 (handle_interrupt): Use it.
4735
2a8ce227
JB
47362012-04-10 Juanma Barranquero <lekktu@gmail.com>
4737
4738 * w32.c (w32_delayed_load): Record the full path of the library
4739 being loaded (bug#10424).
4740
935396c0
GM
47412012-04-09 Glenn Morris <rgm@gnu.org>
4742
05920a43
GM
4743 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4744 not just in the obarray, before snarfing them. (Bug#11036)
4745
935396c0
GM
4746 * Makefile.in ($(leimdir)/leim-list.el):
4747 Pass EMACS rather than BUILT_EMACS.
4748
a18ecafa
TZ
47492012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4750
4751 * process.c (make_process):
4752 * process.h: Add integer `gnutls_handshakes_tried' member to
4753 process struct.
4754
6bbef4e5
JC
4755 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4756 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4757
4758 * gnutls.c (gnutls_log_function2i): Convenience log function.
4759 (emacs_gnutls_read): Use new log functions,
4760 `gnutls_handshakes_tried' process member, and
4761 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4762 attempts per process (connection).
4763
b4d3bc10
CY
47642012-04-09 Chong Yidong <cyd@gnu.org>
4765
4766 * eval.c (Fuser_variable_p, user_variable_p_eh)
4767 (lisp_indirect_variable): Functions deleted.
4768 (Fdefvar): Caller changed.
4769
4770 * callint.c (Finteractive, Fcall_interactively):
4771 * minibuf.c (Fread_variable): Callers changed.
4772
70f4d973
EZ
47732012-04-09 Eli Zaretskii <eliz@gnu.org>
4774
4775 * xdisp.c (set_cursor_from_row): If the display string appears in
4776 the buffer at position that is closer to point than the position
4777 after the display string, display the cursor on the first glyph of
4778 the display string. Fixes cursor display when a 'display' text
4779 property immediately follows invisible text. (Bug#11094)
4780
cb3c2e3e
PE
47812012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 composite.c: use 'double' consistently
4784 * composite.c (get_composition_id): Use 'double' consistently
4785 instead of converting 'float' to 'double' and vice versa; this is
4786 easier to understand and avoids a GCC warning.
4787
fd06db5d
GM
47882012-04-09 Glenn Morris <rgm@gnu.org>
4789
50fe702a
GM
4790 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4791 preparation for dumping it with emacs. (Bug#4789)
4792 (leimdir): New variable.
4793 ($(leimdir)/leim-list.el): New rule.
4794 (emacs$(EXEEXT)): Depend on leim-list.el.
4795
fd06db5d
GM
4796 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4797 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4798 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4799
55c131ee
AS
48002012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4801
4802 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4803 proper alignment.
4804
9209588f
JB
48052012-04-07 Juanma Barranquero <lekktu@gmail.com>
4806
4807 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4808 Remove unused local variable.
4809
e3fb2efb
PE
48102012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4811
4812 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4813 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4814 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4815 objects, as mark_maybe_pointer will catch them otherwise.
4816 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4817 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4818
b5385551
PE
48192012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 Fix typo that broke non-Windows builds.
4822 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4823
9078ead6
EZ
48242012-04-07 Eli Zaretskii <eliz@gnu.org>
4825
4826 Support building on MS-Windows with libxml2.
4827
4828 * makefile.w32-in (OBJ2): Add xml.$(O).
4829 (GLOBAL_SOURCES): Add xml.c.
4830 ($(BLD)/xml.$(O)): New dependency list.
4831
4832 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4833 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4834 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4835 [!WINDOWSNT]: New macros.
4836 (init_libxml2_functions, libxml2_loaded_p): New functions.
4837 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4838 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4839 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4840 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4841 linked in).
6bbef4e5
JC
4842 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4843 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4844 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4845
4846 * emacs.c: Don't include libxml/parser.h.
4847 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4848 xmlCleanupParser directly.
4849
4850 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4851
3811fdf3
EZ
48522012-04-07 Eli Zaretskii <eliz@gnu.org>
4853
4854 * indent.c (Fvertical_motion): If there is a display string at
4855 point, use it.vpos to compute how many lines to backtrack after
4856 move_it_to point. (Bug#11133)
4857
2f8e16b2
EZ
48582012-04-06 Eli Zaretskii <eliz@gnu.org>
4859
4860 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4861 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4862 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4863 macros related to unification of CJK characters. For the details,
4864 see the discussion following the message here:
4865 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4866
3d439cd1
CY
48672012-04-04 Chong Yidong <cyd@gnu.org>
4868
4869 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4870
8bc53d00
EZ
48712012-04-01 Eli Zaretskii <eliz@gnu.org>
4872
4873 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4874 instead of alloca. (Bug#11138)
4875
3b0512a3
AS
48762012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4877
4878 * w32menu.c (is_simple_dialog): Properly check lisp types.
4879 (Bug#11141)
4880
8427ddd2
EZ
48812012-03-31 Eli Zaretskii <eliz@gnu.org>
4882
979022ef
EZ
4883 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4884 position we get to after a call to move_it_to fails the
4885 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4886 only if we wind up in a string from display property. (Bug#11063)
4887
a6b1c7cc
EZ
4888 * window.c (Fdelete_other_windows_internal): Invalidate the row
4889 and column information about mouse highlight, so that redisplay
4890 restores it after reallocating the glyph matrices. (Bug#7464)
4891
8427ddd2
EZ
4892 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4893 string comes from a `display' text property, use the buffer
4894 position of that property as if we actually saw that position in
4895 the row's glyphs.
697ba24b
EZ
4896 (move_it_by_lines): Remove the assertion that
4897 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4898 violated when there's a before-string at the beginning of a line.
4899 (Bug#11063)
8427ddd2 4900
65a0a738
EZ
49012012-03-30 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (append_space_for_newline): If the default face was
4904 remapped, use the remapped face for the appended newline.
4905 (extend_face_to_end_of_line): Use the remapped default face for
4906 extending the face to the end of the line.
4907 (display_line): Call extend_face_to_end_of_line when the default
4908 face was remapped. (Bug#11068)
4909
581355cc
EZ
49102012-03-29 Eli Zaretskii <eliz@gnu.org>
4911
4912 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4913
e8fc049f
SM
49142012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4915
4916 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4917
4fb9a543
GM
49182012-03-27 Glenn Morris <rgm@gnu.org>
4919
4920 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4921 Doc fixes.
4922
679910f1
KH
49232012-03-26 Kenichi Handa <handa@m17n.org>
4924
4925 * dispextern.h (struct glyph): Fix previous change. Change the
4926 bit length of glyphless.ch to 25 (Bug#11082).
4927
90d49b7f
CY
49282012-03-26 Chong Yidong <cyd@gnu.org>
4929
4930 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4931 (command_loop_1): Use it; inhibit selection update for
4932 handle-select-window too (Bug#8996).
4933
f514f6f0
FP
49342012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4935
e8fc049f 4936 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4937
bf43fa51
KH
49382012-03-25 Kenichi Handa <handa@m17n.org>
4939
4940 * dispextern.h (struct glyph): Change the bit length of
4941 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4942
8a0c01dd
EZ
49432012-03-24 Eli Zaretskii <eliz@gnu.org>
4944
4945 * s/ms-w32.h (tzname): Include time.h before redirecting to
4946 _tzname. Fixes the MSVC build. (Bug#9960)
4947
7d1c3a76
AS
49482012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4949
8ed79523
AS
4950 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4951 characters.
4952
7d1c3a76
AS
4953 * xterm.c (XTread_socket): Only modify handling_signal if
4954 !SYNC_INPUT. (Bug#11080)
4955
e99a9b8b
EZ
49562012-03-23 Eli Zaretskii <eliz@gnu.org>
4957
4958 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4959 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4960 when fetching a multibyte character consumes more bytes than
4961 CHAR_BYTES returns, due to unification of CJK characters in
4962 string_char. (Bug#11073)
4963
5063c0e1
TN
49642012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4965
4966 * process.c (wait_reading_process_output): Handle pty disconnect
4967 by refraining from sending oneself a SIGCHLD (bug#10933).
4968
9f851fbd
CY
49692012-03-22 Chong Yidong <cyd@gnu.org>
4970
4971 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4972
5063c0e1 4973 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4974 Mark string as coming from a prefix property.
4975 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4976 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4977
fb5b8aca
CY
49782012-03-21 Chong Yidong <cyd@gnu.org>
4979
4980 * xfaces.c (Vface_remapping_alist): Doc fix.
4981
62356a1b
EZ
49822012-03-20 Eli Zaretskii <eliz@gnu.org>
4983
4984 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4985 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4986 Doc fixes.
62356a1b 4987
025de85b
CY
49882012-03-20 Chong Yidong <cyd@gnu.org>
4989
4990 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4991 to reflect default non-nil value of redisplay-dont-pause.
4992
4827f94e
KH
49932012-03-19 Kenichi Handa <handa@m17n.org>
4994
4995 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4996 it fit in a valid range (Bug#11003).
4997
e50a24a2
EZ
49982012-03-18 Eli Zaretskii <eliz@gnu.org>
4999
5000 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5001 that is not from display property, accept the row as a "cursor
5002 row" if one of the string's character has a non-nil `cursor'
5003 property. Fixes cursor positioning when there are newlines in
5004 overlay strings, e.g. in icomplete.el. (Bug#11035)
5005
9af5ed87
PE
50062012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5007
5008 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5009
d1f55f16
CY
50102012-03-12 Chong Yidong <cyd@gnu.org>
5011
5012 * eval.c (inhibit_lisp_code): Rename from
5013 inhibit_window_configuration_change_hook; move from window.c.
5014
5015 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5016 * window.c (run_window_configuration_change_hook)
5017 (syms_of_window): Callers changed.
5018
66c5eebd
CY
50192012-03-11 Chong Yidong <cyd@gnu.org>
5020
413df973
CY
5021 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5022
66c5eebd
CY
5023 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5024
1de11f56
CY
50252012-03-10 Chong Yidong <cyd@gnu.org>
5026
5027 * frame.c (other_visible_frames): Don't assume the selected frame
5028 is visible (Bug#10955).
5029
cae07000
SM
50302012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5031
5032 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5033
89c94350
JD
50342012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5035
5036 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5037 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5038 zero (Bug#10954).
5039
999dd333
GM
50402012-03-03 Glenn Morris <rgm@gnu.org>
5041
01a6dcc8 5042 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5043
de0100f2
EZ
50442012-03-02 Eli Zaretskii <eliz@gnu.org>
5045
5046 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5047 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5048 (redisplay_window, next_element_from_string): Fix typos in
5049 comments.
3e441275
EZ
5050 (redisplay_window): Pass to move_it_vertically the margin in
5051 pixels, not in screen lines.
de0100f2 5052
96a72ee9
GM
50532012-03-02 Glenn Morris <rgm@gnu.org>
5054
5055 * buffer.c (buffer-list-update-hook): Doc fix.
5056
312508d7
EZ
50572012-02-29 Eli Zaretskii <eliz@gnu.org>
5058
5059 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5060 push_it before setting up the iterator for the first overlay
5061 string, even if we have an empty string loaded.
5062 (next_overlay_string): If there's an empty string on the iterator
5063 stack, pop the stack. (Bug#10903)
5064
27f3c637
PE
50652012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5066
5067 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5068 Suggested by Stefan Monnier in
5069 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5070 * alloc.c (widen_to_Lisp_Object): New static function.
5071 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5072 and widening them to Lisp_Objects. This would work even if
5073 USE_LSB_TAG is defined and wide integers are used, which might
5074 happen in a future version of Emacs.
5075
3c9dfce6
CY
50762012-02-25 Chong Yidong <cyd@gnu.org>
5077
fa74b241
CY
5078 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5079 Doc fix.
5080
3c9dfce6
CY
5081 * xselect.c (Fx_selection_exists_p): Doc fix.
5082 (x_clipboard_manager_save_all): Print an informative message
5083 before saving to clipboard manager.
5084
9486df08
CY
50852012-02-24 Chong Yidong <cyd@gnu.org>
5086
5087 * keyboard.c (process_special_events): Handle all X selection
5088 requests in kbd_buffer, not just the next one (Bug#8869).
5089
f01d3321
CY
50902012-02-23 Chong Yidong <cyd@gnu.org>
5091
5092 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5093 call when setting menu-bar-lines and tool-bar-lines parameters.
5094 (unwind_create_frame_1): New helper function.
5095
5096 * window.c (inhibit_window_configuration_change_hook): New var.
5097 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5098 (syms_of_window): Initialize it.
f01d3321 5099
86b847b6
CY
51002012-02-22 Chong Yidong <cyd@gnu.org>
5101
5102 * xterm.c (x_draw_image_relief): Add missing type check for
5103 Vtool_bar_button_margin (Bug#10743).
5104
a59225b1
CY
51052012-02-21 Chong Yidong <cyd@gnu.org>
5106
5107 * fileio.c (Vfile_name_handler_alist): Doc fix.
5108
5109 * buffer.c (Fget_file_buffer): Protect against invalid file
5110 handler return value.
5111
310f5bd4
PE
51122012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5113
cb3a28cc
PE
5114 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5115 when computing $valmask.
5116
310f5bd4
PE
5117 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5118 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5119 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5120 It's useless in that case, and it can cause problems on hosts
5121 that allocate halves of EMACS_INT values separately.
5122 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5123 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5124 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5125 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5126 it avoids undefined behavior on hosts where shifting right by more
5127 than the word width has undefined behavior.
5128
2375c96a
CY
51292012-02-19 Chong Yidong <cyd@gnu.org>
5130
5131 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5132 (Funhandled_file_name_directory, Ffile_name_as_directory)
5133 (Fdirectory_file_name, Fexpand_file_name)
5134 (Fsubstitute_in_file_name): Protect against invalid file handler
5135 return values (Bug#10845).
5136
3eb49e71
EZ
51372012-02-18 Eli Zaretskii <eliz@gnu.org>
5138
5139 * .gdbinit (pitx): Fix incorrect references to fields of the
5140 iterator stack.
5141
7b926f3f
CY
51422012-02-17 Chong Yidong <cyd@gnu.org>
5143
5144 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5145
11273115
PE
51462012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5149 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5150
c3a70e2b
CY
51512012-02-15 Chong Yidong <cyd@gnu.org>
5152
5153 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5154 marked as special. Also, starting docstrings with * is obsolete.
5155
0ca43699
AS
51562012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5157
5158 * gnutls.c (emacs_gnutls_write): Fix last change.
5159
2e8f3c56
LI
51602012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5161
5162 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5163 send_process.
5164
af70074f
SM
51652012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5166
5167 * keymap.c (Fsingle_key_description): Handle char ranges.
5168
95986d52
CY
51692012-02-12 Chong Yidong <cyd@gnu.org>
5170
afd83bd1
CY
5171 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5172 as that creates a dangerous corner case.
5173
95986d52
CY
5174 * window.c (Fdelete_window_internal): Invalidate the mouse
5175 highlight (Bug#9904).
5176
bd7da63e
GM
51772012-02-12 Glenn Morris <rgm@gnu.org>
5178
5179 * xselect.c (Fx_own_selection_internal)
5180 (Fx_get_selection_internal, Fx_disown_selection_internal)
5181 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5182 * nsselect.m (Fx_own_selection_internal)
5183 (Fx_disown_selection_internal, Fx_selection_exists_p)
5184 (Fx_selection_owner_p, Fx_get_selection_internal):
5185 Sync docs and argument specs with the xselect.c versions.
5186
77abcbc2
LI
51872012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5188
5189 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5190
90b671e2
EZ
51912012-02-11 Eli Zaretskii <eliz@gnu.org>
5192
1c0ca0b7
EZ
5193 * w32select.c (Fx_selection_exists_p): Sync doc string and
5194 argument list with xselect.c. (Bug#10783)
5195
5196 * w16select.c (Fx_selection_exists_p): Sync doc string and
5197 argument list with xselect.c. (Bug#10783)
90b671e2 5198
49241268
GM
51992012-02-10 Glenn Morris <rgm@gnu.org>
5200
5201 * fns.c (Fsecure_hash): Doc fix.
5202
f998bbe7 52032012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5204
5205 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5206
0992bd9c
CY
52072012-02-07 Chong Yidong <cyd@gnu.org>
5208
5209 * buffer.c (Fbuffer_local_variables)
5210 (buffer_lisp_local_variables): Handle unbound vars correctly;
5211 don't let Qunbound leak into Lisp.
5212
af008560
GM
52132012-02-07 Glenn Morris <rgm@gnu.org>
5214
dd605cc4
GM
5215 * image.c (Fimagemagick_types): Doc fix.
5216
af008560
GM
5217 * image.c (imagemagick-render-type): Change it from a lisp object
5218 to an integer. Move the doc here from the lisp manual.
5219 Treat all values not equal to 0 the same.
5220
1449fa1d
CY
52212012-02-06 Chong Yidong <cyd@gnu.org>
5222
5223 * doc.c (store_function_docstring): Avoid applying docstring of
5224 alias to base function (Bug#2603).
5225
3723ec07
AS
52262012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5227
5228 * .gdbinit (pp1, pv1): Remove redundant defines.
5229 (pr): Use pp.
5230
79c1cc1e
CY
52312012-02-04 Chong Yidong <cyd@gnu.org>
5232
5233 * nsterm.m: Declare a global (Bug#10694).
5234
d7f29f8e
EZ
52352012-02-04 Eli Zaretskii <eliz@gnu.org>
5236
cae07000
SM
5237 * w32.c (get_emacs_configuration_options):
5238 Include --enable-checking, if specified, in the return value.
d7f29f8e 5239
3b95a6f9
MR
52402012-02-04 Martin Rudalics <rudalics@gmx.at>
5241
5242 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5243 after rounding frame sizes. (Bug#9723)
5244
d6fa96a6
EZ
52452012-02-04 Eli Zaretskii <eliz@gnu.org>
5246
5247 * keyboard.c (adjust_point_for_property): Don't position point
5248 before BEGV. (Bug#10696)
5249
df0b2940
PE
52502012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5251
5252 Handle overflow when computing char display width (Bug#9496).
5253 * character.c (char_width): Return EMACS_INT, not int.
5254 (char_width, c_string_width): Check for overflow when
5255 computing the width; this is possible now that individual
5256 characters can have unbounded width. Problem introduced
5257 by merge from Emacs 23 on 2012-01-19.
5258
6bee44d6
MA
52592012-02-02 Michael Albinus <michael.albinus@gmx.de>
5260
5261 * dbusbind.c (Fdbus_register_method): Mention the return value
5262 :ignore in the docstring.
5263
44f92739
GM
52642012-02-02 Glenn Morris <rgm@gnu.org>
5265
1b9f60cc
GM
5266 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5267
44f92739
GM
5268 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5269 Unconditionally set to t. (Bug#10673)
5270 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5271 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5272 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5273
c5d3843c
KH
52742012-02-02 Kenichi Handa <handa@m17n.org>
5275
5276 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5277 0, do not call append_composite_glyph.
5278
159462d4 52792012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5280
5281 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5282 NULL (Bug#6988).
5283 (x_produce_glyphs): If the component of a composition is a null
5284 string, set it->pixel_width to 1 to avoid zero-width glyph.
5285
78cef877
EZ
52862012-02-01 Eli Zaretskii <eliz@gnu.org>
5287
5288 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5289 first 2 arguments are identical. This makes inserting large
5290 output from a subprocess an order of magnitude faster on
5291 MS-Windows, where all sbrk'ed memory is always contiguous.
5292
97897668
GM
52932012-01-31 Glenn Morris <rgm@gnu.org>
5294
5295 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5296 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5297 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5298
31fd3586
GM
52992012-01-29 Glenn Morris <rgm@gnu.org>
5300
5301 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5302
0e24a8b2
CY
53032012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5304
5305 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5306
cc0adcb0
CY
53072012-01-28 Chong Yidong <cyd@gnu.org>
5308
5309 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5310
acc28cb9
CY
53112012-01-26 Chong Yidong <cyd@gnu.org>
5312
9c69cfb7
CY
5313 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5314
acc28cb9
CY
5315 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5316 repeat counts (Bug#10507).
5317
48da7392
GM
53182012-01-26 Glenn Morris <rgm@gnu.org>
5319
5320 * lread.c (syms_of_lread): Doc fix.
5321
14af5f7f
CY
53222012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5323
5324 * coding.c (encode_designation_at_bol): Change return value to
5325 EMACS_INT.
5326
0b21c100
CY
53272012-01-25 Chong Yidong <cyd@gnu.org>
5328
5329 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5330
3c2907f7
CY
53312012-01-21 Chong Yidong <cyd@gnu.org>
5332
5333 * floatfns.c (Fcopysign): Make the second argument non-optional,
5334 since nil is not allowed anyway.
5335
959ad23f
AS
53362012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5337
5338 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5339 (send_process): Likewise.
5340
34a02f46
MR
53412012-01-19 Martin Rudalics <rudalics@gmx.at>
5342
5343 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5344 (Vwindow_persistent_parameters): Do not use Qstate.
5345 Rewrite doc-strings.
34a02f46 5346
1259009a 53472012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5348
5349 * character.c (char_width): New function.
70d4fdf6
GM
5350 (Fchar_width, c_string_width, lisp_string_width):
5351 Use char_width (Bug#9496).
25ed9e61 5352
6a6ee00d
MR
53532012-01-16 Martin Rudalics <rudalics@gmx.at>
5354
5355 * window.c (Vwindow_persistent_parameters): New variable.
5356 (Fset_window_configuration, save_window_save): Handle persistent
5357 window parameters.
5358
c85efaf7
EZ
53592012-01-14 Eli Zaretskii <eliz@gnu.org>
5360
5361 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5362 thrashing the stack of the thread. (Bug#9087)
5363
5944709e
PE
53642012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5365
5366 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5367
e71f5d99
EZ
53682012-01-11 Eli Zaretskii <eliz@gnu.org>
5369
5370 * xdisp.c (rows_from_pos_range): Handle the case where the
5371 highlight ends on a newline. (Bug#10464)
5372 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5373 he end column for display of highlight that ends on a newline
5374 before a R2L line.
5375
ce316182
GM
53762012-01-11 Glenn Morris <rgm@gnu.org>
5377
5378 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5379 from load-path also when installation-directory is nil. (Bug#10208)
5380
5b43da69
GM
53812012-01-10 Glenn Morris <rgm@gnu.org>
5382
74cc8ff9
GM
5383 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5384
7d8d6e4e
GM
5385 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5386 Update template values to be closer to their typical values these days.
5b43da69 5387
a0db8d43
EZ
53882012-01-09 Eli Zaretskii <eliz@gnu.org>
5389
5390 * xdisp.c (rows_from_pos_range): Accept additional argument
5391 DISP_STRING, and accept any glyph in a row whose object is that
5392 string as eligible for mouse highlight. Fixes mouse highlight of
5393 display strings from overlays. (Bug#10464)
5394
9a0115ab 53952012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5396
b9110d6a 5397 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5398 * fileio.c (auto_saving_dir_umask): New static var.
5399 (Fmake_directory_internal): Use it.
5400 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5401 creating the directory. The old code temporarily assigns
5402 too-generous permissions to the directory.
5403 (do_auto_save_eh): Clear it.
b9110d6a 5404 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5405 that the var is always cleared.
5406
6c1bd3f3
EZ
54072012-01-07 Eli Zaretskii <eliz@gnu.org>
5408
5409 * search.c (scan_buffer): Pass character positions to
5410 know_region_cache, not byte positions. (Bug#6540)
5411
069d2b50
L
54122012-01-07 LynX <_LynX@bk.ru> (tiny change)
5413
5414 * w32.c (sys_rename): Report EXDEV when rename of a directory
5415 fails because the target is on another logical disk. (Bug#10284)
5416
75bf0d33
DB
54172012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5418
5419 * xterm.c (x_embed_request_focus): New function.
5420
5421 * xterm.h: Add prototype.
5422
5423 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5424
1c6e5a32
GM
54252012-01-05 Glenn Morris <rgm@gnu.org>
5426
5427 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5428
651e947e
EZ
54292012-01-01 Eli Zaretskii <eliz@gnu.org>
5430
5431 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5432 Load gnutls_transport_set_lowat only if GnuTLS version is below
5433 2.11.1.
5434 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5435 GnuTLS versions below 2.11.1.
5436
3778cdd8
AL
54372011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5438
5439 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5440 to the doc string advising against its use for altering the way
5441 windows are scrolled.
5442
0e5317f7
KH
54432011-12-28 Kenichi Handa <handa@m17n.org>
5444
5445 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5446 coding-system ASCII compatible only when it does not produce BOM
5447 on encoding (Bug#10383).
5448
93d5ca1f
JD
54492011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5450
5451 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5452 can scroll.
5453 (create_and_show_popup_menu): Always use menu_position_func for
5454 Gtk3 (Bug#10361).
5455
ca22b785
AS
54562011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5457
5458 * callint.c (Fcall_interactively): Don't truncate prompt string.
5459
d048e1e6
EZ
54602011-12-23 Eli Zaretskii <eliz@gnu.org>
5461
5462 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5463 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5464 resumed from there (after widening). (Bug#10360)
d048e1e6 5465
5ccaba1f
JD
54662011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5467
5468 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5469
204ee57f
JD
54702011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5471
b81d40f0
JB
5472 * nsterm.m (x_free_frame_resources):
5473 Release f->output_data.ns->miniimage.
204ee57f
JD
5474 (ns_index_color): Fix indentation. Do not retain
5475 color_table->colors[i].
5476
5477 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5478 before returning.
5479
5480 * nsfns.m (x_set_background_color): Assign return value from
5481 ns_index_color to face-background instead of NSColor*.
5482 (ns_implicitly_set_icon_type): Fix indentation.
5483 Change assignment in for loop to comparison.
5484
5485 * emacs.c (ns_pool): New variable.
5486 (main): Assign ns_pool.
5487 (Fkill_emacs): Call ns_release_autorelease_pool.
5488
5489 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5490 autorelease fdesc, release fdAttrs and tdict.
5491 (ns_get_covering_families): Release charset.
5492 (ns_findfonts): Release NSFontDescriptor created with new.
5493 (ns_uni_to_glyphs): Fix indentation.
5494 (setString): Release attrStr before assigning new value.
5495
c803b2b7
JD
54962011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5497
678f4426
JD
5498 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5499 and NS_IMPL_COCOA.
5500 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5501 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5502
cd394be1 55032011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5504
5fecd5fc
JD
5505 * nsterm.m (ns_term_init): Subscribe for notifications
5506 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5507 to method trackingNotification in EmacsMenu.
5508
5509 * nsmenu.m (trackingMenu): New variable.
3771cb17 5510 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5511 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5512 from Aquamacs (Bug#7030).
678f4426
JD
5513
55142011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5515
c803b2b7
JD
5516 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5517 (symbol_to_nsstring): Fix indentation.
5518 (ns_symbol_to_pb): New function.
cae07000
SM
5519 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5520 (Fns_rotate_cut_buffers_internal): Remove.
5521 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5522 Fns_store_cut_buffer_internal.
5523 (ns_get_foreign_selection, Fx_own_selection_internal)
5524 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5525 (Fns_get_selection_internal, Fns_store_selection_internal):
5526 Use ns_symbol_to_pb and check if return value is nil.
5527 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5528 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5529 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5530 renamed to Sns_store_selection_internal.
5531 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5532 and remove this function.
5533 (ns_handle_selection_clear): Remove, never used.
5534 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5535 here.
5536
e1b01a3a
KB
55372011-12-17 Ken Brown <kbrown@cornell.edu>
5538
5539 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5540 GID is unknown (Bug#10257).
5541
2adb6e85
PE
55422011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5545 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5546 which caused a build failure on GNU/Linux IA-64. This problem was
5547 introduced by my 2011-10-07 patch.
5548
d1d7b339
JL
55492011-12-15 Juri Linkov <juri@jurta.org>
5550
5551 * image.c (imagemagick_error): New function. (Bug#10112)
5552 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5553 Use `imagemagick_error' where ImageMagick functions return
5554 `MagickFalse'.
5555 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5556 proper order.
5557
100d5755
KH
55582011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5559
5560 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5561 fill background (Bug#8992).
5562
454592a6
MR
55632011-12-13 Martin Rudalics <rudalics@gmx.at>
5564
5565 * window.c (Vwindow_combination_resize)
5566 (Vwindow_combination_limit): Use t instead of non-nil in
5567 doc-strings.
61d4b438
MR
5568 (Vrecenter_redisplay): Add first sentence of doc-string on
5569 separate line.
53524d93 5570 (Frecenter): Fix doc-string typo.
454592a6 5571
3633e3aa
KH
55722011-12-11 Kenichi Handa <handa@m17n.org>
5573
5574 * coding.c (Funencodable_char_position): Pay attention to the
5575 buffer text relocation (Bug#9389).
5576
7b9d523a 55772011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5578
7b9d523a
JD
5579 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5580 gtk_init (Bug#10100).
5581
b73189c6
EZ
55822011-12-10 Eli Zaretskii <eliz@gnu.org>
5583
5584 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5585 IT->string is nil. (Bug#10263)
5586
f7dfe5d6
JD
55872011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5588
83faebb4
JD
5589 * nsterm.h (x_free_frame_resources): Declare.
5590
f7dfe5d6
JD
5591 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5592 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5593
5594 * nsterm.h (ns_get_defaults_value): Declare.
5595
5596 * nsterm.m (ns_default): Call ns_get_defaults_value.
5597
7cd4e72c
EZ
55982011-12-09 Eli Zaretskii <eliz@gnu.org>
5599
5600 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5601 (Bug#10170)
5602
b34d7317
YM
56032011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5604
5605 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5606 that where the value of an _OBJC_* symbol points to is in the .bss
5607 section (Bug#10240).
5608
76470ad1
KH
56092011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5610
5611 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5612 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5613
745fff94
KH
56142011-12-08 Kenichi Handa <handa@m17n.org>
5615
5616 * ftfont.c (get_adstyle_property): Fix previous change
5617 (Bug#10233).
5618
6e44397c
JB
56192011-12-07 Juanma Barranquero <lekktu@gmail.com>
5620
5621 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5622 dirs from the default value of EMACSLOADPATH (bug#10208).
5623
7efa6272
GM
56242011-12-07 Glenn Morris <rgm@gnu.org>
5625
5626 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5627 installation and source directories as well. (Bug#10208)
5628
f6fc4d87
CY
56292011-12-06 Chong Yidong <cyd@gnu.org>
5630
5631 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5632
2bf26180
GM
56332011-12-06 Glenn Morris <rgm@gnu.org>
5634
5635 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5636 as an error, not just -1. (Bug#10217)
5637
3a6ad4f0
CY
56382011-12-05 Chong Yidong <cyd@gnu.org>
5639
5640 * keyboard.c (process_special_events): New function.
5641 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5642
75a3b399
PE
56432011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 * coding.c (encode_designation_at_bol): Don't use uninitialized
5646 local variable (Bug#9318).
5647
c3c9e25e
KH
56482011-12-05 Kenichi Handa <handa@m17n.org>
5649
5650 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5651 return Qnil (Bug#8046, Bug#10193).
5652
5eb05ea3
KH
56532011-12-05 Kenichi Handa <handa@m17n.org>
5654
5655 * coding.c (encode_designation_at_bol): New args charbuf_end and
5656 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5657 (coding_set_source): Return how many bytes coding->source was
5658 relocated.
5659 (coding_set_destination): Return how many bytes
5660 coding->destination was relocated.
5661 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5662 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5663
56642011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5665
5666 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5667 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5668 macro (Bug#9318).
5669
56702011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5671
5672 The following changes are to fix Bug#9318.
5673
a79703f5 5674 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5675 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5676 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5677 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5678
7dbda6df
JB
56792011-12-05 Juanma Barranquero <lekktu@gmail.com>
5680
5681 * lisp.h (process_quit_flag): Fix external declaration.
5682
6d5eb5b0
SM
56832011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5684
5685 Don't macro-inline non-performance-critical code.
5686 * eval.c (process_quit_flag): New function.
5687 * lisp.h (QUIT): Use it.
5688
a0c3fad0
JD
56892011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5690
5691 * nsfns.m (get_geometry_from_preferences): New function.
5692 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5693
6c07aac2
AS
56942011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5695
5696 * emacs.c (Qkill_emacs): Define.
5697 (syms_of_emacs): Initialize it.
5698 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5699 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5700 (quit_throw_to_read_char): Add parameter `from_signal'.
5701 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5702 * lisp.h (QUIT): Call Fkill_emacs if requested.
5703
c052ead4
JD
57042011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5705
5706 * widget.c (update_wm_hints): Return if wmshell is null.
5707 (widget_update_wm_size_hints): New function.
5708
5709 * widget.h (widget_update_wm_size_hints): Declare.
5710
5711 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5712 widget_update_wm_size_hints (Bug#10104).
5713
9e49252b
EZ
57142011-12-03 Eli Zaretskii <eliz@gnu.org>
5715
5716 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5717 before a newline, prepare the bidi iterator for consuming the
5718 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5719 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5720
02b16839
JL
57212011-12-02 Juri Linkov <juri@jurta.org>
5722
5723 * search.c (Fword_search_regexp): New Lisp function created from
5724 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5725 (Fword_search_backward, Fword_search_forward)
5726 (Fword_search_backward_lax, Fword_search_forward_lax):
5727 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5728 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5729
0068070e
SM
57302011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5731
5732 * fileio.c (Finsert_file_contents): Move after-change-function call
5733 to before the "handled:" label, since all "goto handled" appear in
5734 cases where the *-change-functions have already been properly called
5735 (bug#10117).
5736
3360a3fc
AS
57372011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5738
5739 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5740 waiting for input. (Bug#10169)
5741
73d6c093
EZ
57422011-11-30 Eli Zaretskii <eliz@gnu.org>
5743
5744 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5745 verifies glyph row's hash code--we have just reallocated the
5746 glyphs, so their contents can be complete garbage. (Bug#10164)
5747
febe6bea
JB
57482011-11-30 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5751
801a4313
EZ
57522011-11-30 Eli Zaretskii <eliz@gnu.org>
5753
5754 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5755 attributes are tested _before_ calling verify_row_hash, to protect
5756 against GCC re-ordering of the tests. (Bug#10164)
5757
2b56b87e
JD
57582011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5759
5760 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5761
5762 * xterm.c (handle_one_xevent): Only set async_visible and friends
5763 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5764 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5765 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5766
dbf31225
PE
57672011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5768
5769 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5770 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5771 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5772 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5773 All uses changed to use GCPRO1 etc.
5774 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5775 Revert to old implementation (i.e., before 2011-03-11).
5776
1305621b
YM
57772011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5778
5779 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5780 of scroll runs so as to avoid assigning disabled bogus rows and
5781 unnecessary graphics copy operations.
5782
8c9afb46
EZ
57832011-11-27 Eli Zaretskii <eliz@gnu.org>
5784
5785 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5786 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5787 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5788 (malloc, free, realloc, calloc): Redirect to e_* only when
5789 compiling Emacs.
5790
5791 * lisp.h (GCTYPEBITS): Move before first use.
5792 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5793 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5794 this macro definition.
5795
5796 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5797 _MSC_VER.
5798
54e9e3bf
JD
57992011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5800
6d5eb5b0
SM
5801 * gtkutil.c (xg_create_frame_widgets):
5802 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5803 present with Gtk+ 2.0.
5804
83aca1cb
PE
58052011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5806
5807 * fileio.c (Finsert_file_contents): Undo previous change; see
5808 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5809
5b76caa4
PE
58102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5811
5812 Rename locals to avoid shadowing.
5813 * fileio.c (Finsert_file_contents):
5814 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5815 * process.c (wait_reading_process_output):
5816 Rename inner 'proc' to 'p' to avoid shadowing.
5817 Indent for consistency with usual Emacs style.
5818
8c535114
EZ
58192011-11-25 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (redisplay_window): If cursor row is not fully visible
5822 after recentering, and scroll-conservatively is set to a large
5823 number, scroll window by a few more lines to make the cursor fully
5824 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5825 (start_display): Don't move to the next line if the display should
5826 start at a newline that is part of a display vector or an overlay
5827 string. (Bug#10119)
8c535114 5828
fa4fdb5c
JL
58292011-11-24 Juri Linkov <juri@jurta.org>
5830
5831 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5832 after the `MagickPingImage' call. (Bug#10112)
5833
90ec88df
CY
58342011-11-23 Chong Yidong <cyd@gnu.org>
5835
5836 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5837
56e2e794
MR
58382011-11-23 Martin Rudalics <rudalics@gmx.at>
5839
5840 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5841 making another buffer current. (Bug#10114)
5842
b6e64c41
GM
58432011-11-23 Glenn Morris <rgm@gnu.org>
5844
5845 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5846
6b21de18
CY
58472011-11-23 Chong Yidong <cyd@gnu.org>
5848
5849 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5850 using it (Bug#5984).
5851
b12cd789
EZ
58522011-11-22 Eli Zaretskii <eliz@gnu.org>
5853
5854 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5855 and header-lines, as they don't have one computed for them.
5856 (Bug#10098)
5857
5858 * .gdbinit (prow): Make displayed values more self-explaining.
5859 Add row's hash code.
5860
261b6fd4
LMI
58612011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5862
5863 * process.c (wait_reading_process_output): Fix asynchrounous
5864 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5865 (wait_reading_process_output): Add comment and URL.
261b6fd4 5866
e7cfd277
JD
58672011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5868
5869 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5870
a9b9b7f5
CY
58712011-11-21 Chong Yidong <cyd@gnu.org>
5872
5873 * window.c (Fnext_window, Fprevious_window): Doc fix.
5874
b0d15b4f
SM
58752011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5876
5877 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5878
fe7a3057
JB
58792011-11-20 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5882
d2999b1a
MR
58832011-11-20 Martin Rudalics <rudalics@gmx.at>
5884
5885 * window.c (Fset_window_combination_limit): Rename argument
5886 STATUS to LIMIT.
5887 (Vwindow_combination_limit): Remove "status" from doc-string.
5888
d5ff9cd0
AS
58892011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5890
5891 * m/ibms390.h: Remove.
5892 * m/ibms390x.h: Don't include "ibms390.h".
5893
a5bb9bd3
SM
58942011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5895
5896 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5897 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5898
cd1181db
JB
58992011-11-20 Juanma Barranquero <lekktu@gmail.com>
5900
5901 * casetab.c (Fset_case_table):
5902 * charset.c (Fcharset_after): Fix typos.
5903
615a3b8d 59042011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5905
17e845af
PE
5906 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5907 Otherwise, valgrind does not work on some platforms.
5908 Problem reported by Andreas Schwab in
6a0bf43d
PE
5909 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5910 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5911 is set, removing the need for VIRT_ADDRESS_VARIES.
5912 (PURE_P): Use a more-efficient implementation that needs just one
5913 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5914 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5915 to 4 (xorl, subq, cmpq, setbe).
5916 * alloc.c (pure): Always extern now, since that's the
5917 VIRT_ADDR_VARIES behavior.
5918 (PURE_POINTER_P): Use a single comparison, not two, for
5919 consistency with the new puresize.h.
5920 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5921 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5922 Remove VIRT_ADDR_VARIES no longer needed.
5923
f8fe6f96
EZ
59242011-11-19 Eli Zaretskii <eliz@gnu.org>
5925
5926 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5927 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5928 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5929 behave as if the cursor position were at the window margin.
5930
5931 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5932 and the cursor position is out of bounds, behave as if the cursor
5933 position were at the window margin. (Bug#10075)
5934
df05a53c
CY
59352011-11-18 Chong Yidong <cyd@gnu.org>
5936
5937 * window.c (Fwindow_combination_limit): Make first argument
5938 non-optional, since it is meaningless for live windows like the
5939 selected window.
61ccba97 5940
2071918e
DA
59412011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5942
5943 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5944
b50a28de
SM
59452011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5946
5947 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5948 (graft_intervals_into_buffer): Simplify.
5949
015137db
EZ
59502011-11-18 Eli Zaretskii <eliz@gnu.org>
5951
5952 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5953 hash values of the two rows.
5954 (copy_row_except_pointers): Preserve the used[] arrays and the
5955 hash values of the two rows. (Bug#10035)
68c95424 5956 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5957
5958 * xdisp.c (row_hash): New function, body extracted from
5959 compute_line_metrics.
5960 (compute_line_metrics): Call row_hash, instead of computing the
5961 hash code inline.
5962
5963 * dispnew.c (verify_row_hash): Call row_hash for computing the
5964 hash code of a row, instead of duplicating code from xdisp.c.
5965
5966 * dispextern.h (row_hash): Add prototype.
5967
a2addb04
TH
59682011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5969
5970 * frame.c (delete_frame): Don't delete the terminal when the last
5971 X frame is closed if emacs is built with GTK toolkit.
5972
df85d315
JB
59732011-11-17 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5976
a0c2d0ae
MR
59772011-11-17 Martin Rudalics <rudalics@gmx.at>
5978
5979 * window.c (Vwindow_splits): Rename to
5980 Vwindow_combination_resize. Suggested by Juri Linkov.
5981 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5982 of Vwindow_splits.
5983
58179cce
JB
59842011-11-16 Juanma Barranquero <lekktu@gmail.com>
5985
7877f373
JB
5986 * nsfns.m (Fns_font_name):
5987 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5988
b6f67890
MR
59892011-11-16 Martin Rudalics <rudalics@gmx.at>
5990
5991 * window.h (window): Rename slot "nest" to "combination_limit".
5992 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5993 (Fset_window_nest): Rename to Fset_window_combination_limit.
5994 (Vwindow_nest): Rename to Vwindow_combination_limit.
5995 (recombine_windows, make_parent_window, make_window)
5996 (Fsplit_window_internal, saved_window)
5997 (Fset_window_configuration, save_window_save): Rename all
5998 occurrences of window_nest to window_combination_limit.
5999
c7015153
JB
60002011-11-15 Juanma Barranquero <lekktu@gmail.com>
6001
6002 * image.c (imagemagick_load_image): Fix typo.
6003
322ad6ec
EZ
60042011-11-14 Eli Zaretskii <eliz@gnu.org>
6005
6006 * xdisp.c (display_line): Move the call to
6007 highlight_trailing_whitespace before the call to
6008 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6009 faces of all the glyphs to compute ROW's hash value.
6010 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6011
f067b8ec
JB
60122011-11-14 Juanma Barranquero <lekktu@gmail.com>
6013
6014 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6015 just return (bug#10044).
6016
1e5b2111
EZ
60172011-11-12 Eli Zaretskii <eliz@gnu.org>
6018
7ef3cbd5
EZ
6019 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6020 with user-defined heap size. Bump the default size of the temacs
6021 heap to 27MB, to avoid memory warning when running temacs.
6022 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6023
1e5b2111
EZ
6024 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6025 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6026 (verify_row_hash) [XASSERTS]: New function.
6027 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6028 that the hash value of glyph rows is correct.
1e5b2111 6029
89d61221
MR
60302011-11-12 Martin Rudalics <rudalics@gmx.at>
6031
6032 * window.h (window): Remove splits slot.
6033 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6034 (Fdelete_other_windows_internal, make_parent_window)
6035 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6036 (Fset_window_configuration, save_window_save): Don't deal with
6037 split status of windows.
6038 (saved_window): Remove splits slot.
6039 (Vwindow_splits): Rewrite doc-string.
6040
97f18cc8
JD
60412011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6042
6043 * xfns.c (unwind_create_frame):
6044 * nsfns.m (unwind_create_frame):
6045 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6046 Vframe_list (Bug#9999).
6047
22a648b4
DA
60482011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6049
0b381c7e 6050 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6051
659afede
KH
60522011-11-11 Kenichi Handa <handa@m17n.org>
6053
6054 * callproc.c (Fcall_process): Set the member dst_multibyte of
6055 process_coding.
6056
9ac0394b
KH
60572011-11-11 Johan Bockgård <bojohan@gnu.org>
6058
6059 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6060 avoid a crash (bug#9496).
6061
2fbdc249
CY
60622011-11-09 Chong Yidong <cyd@gnu.org>
6063
6064 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6065 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6066
ac6b1f81
PE
60672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6070
09db192c
PE
60712011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 Avoid some portability problems by eschewing 'extern inline' functions.
6074 The trivial performance wins aren't worth the portability hassles; see
6075 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6076 et seq.
6077 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6078 (window_box_width, window_box_left, window_box_left_offset)
6079 (window_box_right, window_box_right_offset): Undo previous change,
6080 by removing the "extern"s.
6081 * intervals.c (adjust_intervals_for_insertion)
6082 (adjust_intervals_for_deletion): Undo previous change,
6083 making these static again.
6084 (offset_intervals, temp_set_point_both, temp_set_point)
6085 (copy_intervals_to_string): No longer inline.
6086 * xdisp.c (window_text_bottom_y, window_box_width)
6087 (window_box_height, window_box_left_offset)
6088 (window_box_right_offset, window_box_left, window_box_right)
6089 (window_box): No longer inline.
6090
105216ed
CY
60912011-11-08 Chong Yidong <cyd@gnu.org>
6092
6093 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6094 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6095 Signal an error if not a live window.
105216ed
CY
6096 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6097 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6098
ae9e237f
JB
60992011-11-07 Juanma Barranquero <lekktu@gmail.com>
6100
6101 * lisp.h (syms_of_abbrev): Remove declaration.
6102 Reported by CHENG Gao <chenggao@royau.me>.
6103
c7aa8333
EZ
61042011-11-07 Eli Zaretskii <eliz@gnu.org>
6105
6106 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6107 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6108 of temacs in GUI mode.
6109
be7f5545
MR
61102011-11-07 Martin Rudalics <rudalics@gmx.at>
6111
6112 * window.h: Declare delete_all_child_windows instead of
6113 delete_all_subwindows.
6114 * window.c (Fwindow_nest, Fset_window_nest)
6115 (Fset_window_new_total, Fset_window_new_normal)
6116 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6117 (delete_all_subwindows): Rename to delete_all_child_windows.
6118 (Fdelete_other_windows_internal, Fset_window_configuration):
6119 Call delete_all_child_windows instead of delete_all_subwindows.
6120 * frame.c (delete_frame): Call delete_all_child_windows instead
6121 of delete_all_subwindows.
6122
ca78dc43
PE
61232011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6124
6125 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6126 This is also needed for porting to any host where GC_MARK_STACK is
6127 not GC_MAKE_GCPROS_NOOPS.
6128 (which_symbols): Use it.
6129
a0241d01
KH
61302011-11-07 Kenichi Handa <handa@m17n.org>
6131
6132 * coding.c (coding_set_destination): Check coding->src_pos only
6133 when coding->src_object is a buffer (bug#9910).
6134
6135 * process.c (send_process): Set the member src_multibyte of coding
6136 to 0 (bug#9911) when sending a unibyte text.
6137
6138 * callproc.c (Fcall_process): Set the member src_multibyte of
6139 process_coding to 0 (bug#9912).
6140
a64bfdfa 61412011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6142
6143 * xmenu.c (cleanup_widget_value_tree): New function.
6144 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6145 calling free_menubar_widget_value_tree directly (Bug#9830).
6146
cb41b32a
PE
61472011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6148
6149 Fix some portability problems with 'inline'.
6150 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6151 (window_box_width, window_box_left, window_box_left_offset)
6152 (window_box_right, window_box_right_offset): Declare extern.
6153 Otherwise, these inline functions do not conform to C99 and
6154 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6155 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6156 * intervals.c (adjust_intervals_for_insertion)
6157 (adjust_intervals_for_deletion): Now extern, because otherwise the
6158 extern inline functions 'offset_intervals' couldn't refer to it.
6159 (static_offset_intervals): Remove.
6160 (offset_intervals): Rewrite using the old contents of
6161 static_offset_intervals. The old version didn't conform to C99
6162 because an extern inline function contained a reference to an
6163 identifier with static linkage.
6164
b7041366
AS
61652011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6166
6167 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6168 GC.
6169
88a37c4d
EZ
61702011-11-06 Eli Zaretskii <eliz@gnu.org>
6171
6172 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6173 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6174 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6175 return Qleft_to_right.
6176
49745b39
CY
61772011-11-06 Chong Yidong <cyd@gnu.org>
6178
6179 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6180 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6181 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6182 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6183 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6184 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6185 (Fwindow_vscroll): Doc fix.
6186 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6187 argument, since it makes no sense to pass a live window and for
6188 consistency with window-child.
6189
1f05cd82
CS
61902011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6191
6192 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6193 support MSVC.
6194
22610910
JR
61952011-11-05 Jason Rumney <jasonr@gnu.org>
6196
6197 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6198 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6199 fonts (Bug#6029).
6200 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6201 bitwise arithmetic preventing use of unicode-sip and non-truetype
6202 opentype fonts.
6203
a06776b2
EZ
62042011-11-05 Eli Zaretskii <eliz@gnu.org>
6205
3ad924ba
EZ
6206 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6207 "emacs"-only part.
6208
a06776b2
EZ
6209 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6210 initialization code to keep similarity to xfns.c after changes
6211 from 2011-11-05.
6212
c9e7db78
JD
62132011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6214
a97f8f3f
JD
6215 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6216 (unwind_create_frame): New function (Bug#9943).
6217 (Fx_create_frame): Restructure code to be more similar to the one in
6218 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6219 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6220 Move terminal->reference_count++ just before making the frame official
6221 (Bug#9943).
6222
6223 * nsterm.m (x_free_frame_resources): New function.
6224 (x_destroy_window): Move code to x_free_frame_resources.
6225
c9e7db78 6226 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6227 (Fx_create_frame, x_create_tip_frame):
6228 Move terminal->reference_count++ just before making the frame
75f1671a 6229 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6230 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6231
a6fc3b5c
EZ
62322011-11-05 Eli Zaretskii <eliz@gnu.org>
6233
6234 Support MSVC build with newer versions of Visual Studio.
6235 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6236 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6237 nt/gmake.defs.
6238
6239 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6240 which are not supported by MSVC.
6241 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6242 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6243 bitfields.
6244 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6245 types in bitfields.
6246 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6247
6248 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6249
58179cce 62502011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6251
6252 Support MSVC build with newer versions of Visual Studio.
6253 * w32.c: Don't include w32api.h for MSVC.
6254 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6255
6256 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6257 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6258 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6259 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6260 e_* cousins.
6261 (alloca) [_MSC_VER]: Define to _alloca.
6262
6263 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6264
6265 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6266
a58c13ed
EZ
62672011-11-04 Eli Zaretskii <eliz@gnu.org>
6268
6269 * xdisp.c (note_mouse_highlight): If either of
6270 previous/next-single-property-change returns nil, treat that as
6271 the beginning or the end of the buffer. (Bug#9955)
6272
fe0b6370
JD
62732011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6274
a58c13ed 6275 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6276 label is not null (Bug#9951).
6277 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6278 may be NULL.
6279
89bd5ee1
EZ
62802011-11-04 Eli Zaretskii <eliz@gnu.org>
6281
6282 * window.c (Fwindow_body_size): Mention in the doc string that the
6283 return value is in frame's canonical units. (Bug#9949)
6284
84c3edb9
EZ
62852011-11-03 Eli Zaretskii <eliz@gnu.org>
6286
4e2fb5c7
EZ
6287 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6288
84c3edb9 6289 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6290 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6291 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6292
bc17a887
EZ
62932011-11-01 Eli Zaretskii <eliz@gnu.org>
6294
6295 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6296 Don't stop backward scan on the continuation glyph, even though
6297 its CHARPOS is positive.
6d5eb5b0
SM
6298 (mouse_face_from_buffer_pos, note_mouse_highlight):
6299 Rename cover_string to disp_string.
bc17a887 6300
4ee88440
MR
63012011-11-01 Martin Rudalics <rudalics@gmx.at>
6302
6303 * window.c (temp_output_buffer_show): Don't use
6304 Vtemp_buffer_show_specifiers.
6305 (Vtemp_buffer_show_specifiers): Remove unused variable.
6306
c2ff3c02
EZ
63072011-10-30 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6310 past the beginning of the current glyph matrix.
6311
58179cce 63122011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6313
6314 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6315 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6316 HAVE_GTK3 (Bug#9869).
b77a6a7f 6317
3b574623
JD
6318 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6319 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6320
b77a6a7f
JD
6321 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6322
6323 * xterm.c: Declare x_handle_net_wm_state to return int.
6324 (handle_one_xevent): Check if we are iconified but don't have
6325 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6326 (get_current_wm_state): Return non-zero if not hidden,
6327 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6328 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6329 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6330 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6331
196e41e4
PE
63322011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6333
6334 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6335 so that this new function doesn't get optimized away by a
6336 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6337
021f2e1a
AS
63382011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6339
6340 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6341
8b058d44
EZ
63422011-10-29 Eli Zaretskii <eliz@gnu.org>
6343
6344 Fix the `xbytecode' command.
6345 * .gdbinit (xprintbytestr): New command.
b50a28de 6346 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6347 (xbytecode): Print the byte-code string as well.
6348
4452fb80
EZ
63492011-10-29 Kim Storm <storm@cua.dk>
6350
8b058d44
EZ
6351 * alloc.c (which_symbols): New function.
6352
21b72067
AS
63532011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6354
6355 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6356 line. (Bug#9903)
6357
83ed7b5c
GM
63582011-10-29 Glenn Morris <rgm@gnu.org>
6359
6360 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6361 Not clear what it was for, and it causes various bugs. (Bug#9839)
6362
5a7a728b
EZ
63632011-10-28 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6366 possible random value that matches one of those tested as
6367 condition to clear the mouse face.
6368
d3d0842f
CY
63692011-10-28 Chong Yidong <cyd@gnu.org>
6370
6371 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6372
31b39d13
DN
63732011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6374
6375 * window.c (make_window): Initialize phys_cursor_on_p.
6376
9aba6043
SM
63772011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6378
6379 * lisp.h (struct Lisp_Symbol): Update comments.
6380
c20992f4
JB
63812011-10-28 Juanma Barranquero <lekktu@gmail.com>
6382
6383 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6384
db4f02f2
EZ
63852011-10-28 Eli Zaretskii <eliz@gnu.org>
6386
6387 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6388 <oslsachem@gmail.com> for helping to debug this.
6389
6390 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6391 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6392 (g_b_init_get_glyph_outline_w): New static variables.
6393 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6394 (GetGlyphOutlineW_Proc): New typedefs.
6395 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6396 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6397 New functions.
6398 (w32font_open_internal, compute_metrics):
6399 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6400 instead of calling the "wide" APIs directly.
6401
6402 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6403
6404 * w32.h (syms_of_w32font): Add prototype.
6405
87e68db4
JB
64062011-10-27 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6409 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6410 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6411 (Fmove_to_window_line): Doc fix.
6412
435c1d67
CY
64132011-10-27 Chong Yidong <cyd@gnu.org>
6414
6415 * process.c (make_process): Set gnutls_state to NULL.
6416
6417 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6418 non-NULL, regardless of GNUTLS_INITSTAGE.
6419 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6420 an error. Set process slots as soon as we allocate them.
6421
6422 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6423
9c6c6f49
CY
64242011-10-27 Chong Yidong <cyd@gnu.org>
6425
9aba6043
SM
6426 * gnutls.c (emacs_gnutls_deinit): New function.
6427 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6428 (Fgnutls_deinit, Fgnutls_boot): Use it.
6429
6430 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6431 (deactivate_process): Call emacs_gnutls_deinit.
6432
657d08d3
JB
64332011-10-27 Juanma Barranquero <lekktu@gmail.com>
6434
6435 * image.c (x_create_x_image_and_pixmap):
6436 * w32.c (sys_rename, w32_delayed_load):
6437 * w32font.c (fill_in_logfont):
6438 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6439
5430d399
JB
64402011-10-26 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * w32fns.c (w32_default_color_map): New function,
6443 extracted from Fw32_default_color_map.
a7ef684b 6444 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6445
fe0055fa
PE
64462011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6447
6448 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6449
e6346438
SM
64502011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6451
6452 * keyboard.c (test_undefined): New function (bug#9751).
6453 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6454
e112cc37
ET
64552011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6456
6457 * sysdep.c (init_sys_modes): Fix the check for the controlling
6458 terminal (Bug#6649).
6459
7b5d6677
EZ
64602011-10-20 Eli Zaretskii <eliz@gnu.org>
6461
6462 * dispextern.h (struct bidi_it): New member next_en_type.
6463
6464 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6465 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6466 current character, check also for next_en_type being WEAK_EN.
6467 (bidi_resolve_weak): Don't enter the expensive loop if the current
6468 position is before next_en_pos. Record the bidi type of the first
6469 non-ET, non-BN character we find, in addition to its position.
6470 (bidi_level_of_next_char): Invalidate next_en_type when
6471 next_en_pos is over-stepped.
6472
7da0b018
PE
64732011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6474
6475 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6476 * editfns.c: Rewrite current-time-zone so that it invokes
6477 the equivalent of (format-time-string "%Z") to get the time zone name.
6478 This fixes a bug when the time zone name contains characters that
6479 need converting from the system time locale to Emacs internal format.
6480 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6481 that patch fixed format-time-string to do the conversion, but
6482 I forgot to fix current-time-zone.
6483 (format_time_string): New function, containing most of
6484 what Fformat_time_string used to contain.
6485 (Fformat_time_string): Rewrite in terms of format_time_string.
6486 This doesn't change this function's behavior.
6487 (current-time-zone): Rewrite to use format_time_string.
6488 This fixes the bug reported by Michael Schierl in
6489 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6490 Jason Rumney's 2007-06-07 change worked around this bug, but
6491 didn't fix it.
6492 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6493
8547b010
EZ
64942011-10-19 Eli Zaretskii <eliz@gnu.org>
6495
6496 * xdisp.c (start_display): If the character at POS is displayed
6497 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6498 (try_window_reusing_current_matrix): If a line ends in a display
6499 vector or the next line starts in a display vector, continue
6500 redrawing the window even though the character position of
6501 start_row was reached.
8547b010
EZ
6502 (Bug#9771, part 2)
6503
4e948d15
CY
65042011-10-18 Chong Yidong <cyd@gnu.org>
6505
6506 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6507 with nobreak-char-display too.
6508
4787455f
EZ
65092011-10-18 Eli Zaretskii <eliz@gnu.org>
6510
6511 Fix part 3 of bug#9771.
6512 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6513 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6514 non-neutral characters if the current character is a paragraph
6515 separator (a.k.a. Newline). This avoids running the same
6516 expensive loop twice, once when we consume the preceding newline
6517 and the other time when the line actually needs to be displayed.
6518 Avoid the loop when we see neutrals on the base embedding level
6519 following a character whose directionality is the same as the
6520 paragraph's. This avoids running the expensive loop when a line
6521 ends in a long sequence of neutrals, like control characters.
6522 Add assertion against STRONG_AL type. Slightly rearrange code
6523 that determines the type of a neutral given the first non-neutral
6524 that follows it.
6525 (bidi_level_of_next_char): Set next_en_pos to zero when
6526 invalidating its info.
6527
2c91f553
EZ
65282011-10-17 Eli Zaretskii <eliz@gnu.org>
6529
6530 * xdisp.c (push_display_prop): Determine whether to record string
6531 or buffer position by IT->string, not by IT->method. Allow
6532 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6533 (move_it_vertically_backward): Don't look for character position
6534 immediately after the newline when in a continuation line.
6535 (Bug#9771, part 1)
2c91f553 6536
c7b08b0d
MR
65372011-10-15 Martin Rudalics <rudalics@gmx.at>
6538
6539 * window.c (coordinates_in_window): Rewrite and delabelize
6540 vertical border check. (Bug#5357) (Bug#9618)
6541
6b02f655
SM
65422011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6543
6544 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6545 errors in XSetWindowBorder (bug#9310).
6546
81d40c92
DA
65472011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6548
6549 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6550 avoid crash when xmalloc overrun checking is enabled.
6551
d4172c3b
EZ
65522011-10-13 Eli Zaretskii <eliz@gnu.org>
6553
6554 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6555 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6556 cursor motion with <left> and <right> arrow keys.
6557
6558 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6559 some callers set that themselves.
6560
b00eea75
EZ
65612011-10-12 Eli Zaretskii <eliz@gnu.org>
6562
6563 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6564 display string and the previous row comes from the same string and
6565 is empty. (Bug#9739) (Bug#9738)
6566
8fe012c4
SM
65672011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6568
6569 * doc.c (get_doc_string): Encode file name (bug#9735).
6570
0074aef2
EZ
65712011-10-12 Eli Zaretskii <eliz@gnu.org>
6572
79beb178
EZ
6573 * bidi.c (bidi_level_of_next_char):
6574 * xdisp.c (get_visually_first_element): Remove old incorrect
6575 comments regarding the Unicode Line Separator character.
6576
0074aef2
EZ
6577 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6578
6e4b3fbe
DA
65792011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6580
6581 * alloc.c (Fgc_status): Do not access beyond zombies array
6582 boundary if nzombies > MAX_ZOMBIES.
6583 * alloc.c (dump_zombies): Add missing format specifier.
6584
0324f3af
PE
65852011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6586
b5525cac
PE
6587 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6588 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6589
0324f3af
PE
6590 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6591 Some packages use them to denote characters with modifiers.
6592
e9b5f888
AS
65932011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6594
6595 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6596 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6597 matching a pp-number. Rename parameter var to var1.
6598
127827c0
SM
65992011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6600
6601 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6602
c8fd3bd0
GM
66032011-10-08 Glenn Morris <rgm@gnu.org>
6604
6605 * callint.c (Fcall_interactively): Give a more explicit error for the
6606 'c' case with a non-character input. (Bug#8479)
6607
352ec8ff
EZ
66082011-10-08 Eli Zaretskii <eliz@gnu.org>
6609
03669ccb
EZ
6610 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6611 lines.
7061c986
EZ
6612 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6613 lines that are hscrolled on the left.
03669ccb 6614
352ec8ff
EZ
6615 * dispnew.c (buffer_posn_from_coords): Account for a possible
6616 presence of header-line. (Bug#4426)
6617
a66cfb1c
SM
66182011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6619
6b02f655
SM
6620 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6621 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6622
7c5ee88e
PE
66232011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6624
6625 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6626 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6627 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6628 this makes Emacs dump core during garbage collection on rare
6629 occasions. sizeof is obviously inferior to offsetof here, so
6630 stick with offsetof.
6631 (GC_POINTER_ALIGNMENT): New macro.
6632 (mark_memory): Omit 3rd (offset) arg; caller changed.
6633 Don't assume EMACS_INT alignment is the same as pointer alignment.
6634
df1bbe5b
SM
66352011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6636
6637 * keyboard.c (read_key_sequence_remapped): New var.
6638 (read_key_sequence): Compute remapping in the right buffer.
6639 (command_loop_1): Use read_key_sequence's remapping directly.
6640
51553db6
SM
66412011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6642
32c1fffd
SM
6643 * dired.c (file_name_completion): Don't expand file name.
6644 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6645 before checking file name handler.
6646
51553db6
SM
6647 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6648 they've been requested explicitly (bug#9591).
6649
b6bd1599 66502011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6651
6652 * keymap.c (Fsingle_key_description): Use make_specified_string
6653 instead of build_string to build string from push_key_description.
6654 (Bug#5193)
6655
f701dc2a
PE
66562011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6657
4222c55d
PE
6658 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6659 This fixes a Y2038 bug on 64-bit hosts.
6660 * buffer.c (reset_buffer):
6661 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6662 (Fclear_buffer_auto_save_failure):
6663 Use 0, not -1, to represent an unset failure time, since time_t
6664 might not be signed.
6665
f701dc2a
PE
6666 Remove dependency on glibc malloc internals.
6667 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6668 Move back here from lisp.h, but with their new implementations.
6669 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6670 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6671 * charset.c (charset_table_init): New static var.
6672 (syms_of_charset): Use it instead of xmalloc. This removes a
6673 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6674 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6675 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6676 Move back to alloc.c.
6677 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6678 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6679
9ceebf39
JD
66802011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6681
6682 * nsterm.m (windowDidResize): Call x_set_window_size only when
6683 ns_in_resize is true. Otherwise set pixelwidth/height and
6684 call change_frame_size (Bug#9628).
6685
cb993c58
PE
66862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6687
3930c88b
PE
6688 Port --enable-checking=all to Fedora 14 x86-64.
6689 * charset.c (syms_of_charset): Also account for glibc malloc's
6690 internal overhead when calculating the initial malloc maximum.
6691
cb993c58
PE
6692 Port --enable-checking=all to Fedora 14 x86.
6693 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6694 Move to lisp.h.
6695 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6696 (overrun_check_realloc, overrun_check_free):
6697 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6698 That way, xmalloc returns a properly-aligned pointer even if
6699 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6700 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6701 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6702 into account when calculating the initial malloc maximum.
6703 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6704 Move here from alloc.c, so that charset.c can use it too.
6705 Properly align; the old code wasn't right for common 32-bit hosts
6706 when configured with --enable-checking=all.
6707 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6708 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6709
31bed486
EZ
67102011-09-29 Eli Zaretskii <eliz@gnu.org>
6711
04c70788 6712 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6713 use EDOM.
6714
fbcaa2f3
EZ
67152011-09-28 Eli Zaretskii <eliz@gnu.org>
6716
6717 * xdisp.c (compute_display_string_end): If there's no display
6718 string at CHARPOS, return -1.
6719
6720 * bidi.c (bidi_fetch_char): When compute_display_string_end
6721 returns a negative value, treat the character as a normal
6722 character not covered by a display string. (Bug#9624)
6723
a239d4e9
JB
67242011-09-28 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * lread.c (Fread_from_string): Fix typo in docstring.
6727
88652fd5
EZ
67282011-09-27 Eli Zaretskii <eliz@gnu.org>
6729
6730 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6731 newline, reseat the iterator instead of bidi-iterating there one
6732 character at a time. (Bug#9610)
32c1fffd
SM
6733 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6734 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6735
ed497dd4
AS
67362011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6737
6738 * lread.c (readevalloop): Use correct code for NBSP.
6739 (read1): Likewise. (Bug#9608)
6740
b2bf61aa
MA
67412011-09-25 Michael Albinus <michael.albinus@gmx.de>
6742
6743 * dbusbind.c (Fdbus_register_signal): When service is not
6744 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6745
32bbb17c
GM
67462011-09-25 Glenn Morris <rgm@gnu.org>
6747
6748 * buffer.c (truncate-lines): Doc fix.
6749
94e0933e
CY
67502011-09-24 Chong Yidong <cyd@stupidchicken.com>
6751
6752 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6753 (Fset_window_next_buffers): Doc fix.
6754
cddde921
GM
67552011-09-24 Glenn Morris <rgm@gnu.org>
6756
6757 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6758
1260aef1
PE
67592011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6760
25b4bfa0
PE
6761 Fix minor problems found by static checking.
6762 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6763 * indent.c (Fvertical_motion): Fix == vs = typo.
6764
e3cbd34b
EZ
67652011-09-24 Eli Zaretskii <eliz@gnu.org>
6766
a66cfb1c
SM
6767 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6768 Default value is now t. Doc fix.
6bf7006f 6769
e3cbd34b 6770 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6771 logic when moving up, not only when moving down. Fix the
e3cbd34b 6772 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6773 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6774
6775 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6776 CHARPOS is covered by a display string which includes newlines.
6777 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6778 is covered by a display string with embedded newlines.
6779
a3de0cbd
MA
67802011-09-24 Michael Albinus <michael.albinus@gmx.de>
6781
6782 * dbusbind.c (Fdbus_register_signal): Add match rule to
6783 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6784 (Fdbus_register_method, Vdbus_registered_objects_table):
6785 Fix docstring.
a3de0cbd 6786
b260039d
JM
67872011-09-24 Jim Meyering <meyering@redhat.com>
6788
32c1fffd 6789 do not ignore write error for any output size
b260039d
JM
6790 The previous change was incomplete.
6791 While it makes emacs --batch detect the vast majority of stdout
6792 write failures, errors were still ignored whenever the output size is
6793 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6794 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6795 && echo FAIL: ignored write error
6796 FAIL: ignored write error
6797 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6798 && echo FAIL: ignored write error
6799 FAIL: ignored write error
6800 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6801
8eca8a7c
AS
68022011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6803
6804 * emacs.c (Fkill_emacs): In noninteractive mode exit
6805 non-successfully if a write error occurred on stdout. (Bug#9574)
6806
3341db62
EZ
68072011-09-21 Eli Zaretskii <eliz@gnu.org>
6808
6809 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6810 the xassert test.
6811
6812 * dispextern.h (struct it): Update the comment documenting what
6813 can it->OBJECT be.
6814
8c203dbf
EZ
68152011-09-20 Eli Zaretskii <eliz@gnu.org>
6816
6817 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6818 a display string, extend search for cursor position to end of row.
6819 (find_row_edges): If the row ends in a newline from a display
6820 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6821 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6822 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6823 non-empty line. Fixes confusing cursor motion with arrow keys at
6824 the beginning of a line that starts with whitespace.
8c203dbf 6825
a4824228
LMI
68262011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6827
6828 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6829 (bug#9493).
6830
33ed493b
CY
68312011-09-18 Chong Yidong <cyd@stupidchicken.com>
6832
6833 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6834 boolean (Bug#9154).
6835
56cd55c8
EZ
68362011-09-18 Eli Zaretskii <eliz@gnu.org>
6837
6838 * xdisp.c (display_line): Record maximum and minimum buffer
6839 positions even if no glyphs were produced (e.g., by a zero-width
6840 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6841 buffer positions that will be removed from the glyph row because
6842 they don't fit.
c02dcedf
EZ
6843 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6844 column is beyond frame width: don't subtract 1 "pixel" when
6845 computing width of the stretch.
3e62b7e0
EZ
6846 (reseat_at_next_visible_line_start): Undo the change made on
6847 2011-09-17 that saved paragraph information and restored it after
6848 the call to `reseat'. (Bug#9545)
56cd55c8 6849
5ed99d36 68502011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6851
6852 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6853 and turn window cursor on if cleared (Bug#9415).
6854
5ed99d36 68552011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6856
6857 * search.c (boyer_moore): Take unibyte characters from pattern
6858 literally. (Bug#9458)
6859
9bade7b2
EZ
68602011-09-18 Eli Zaretskii <eliz@gnu.org>
6861
6862 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6863
e5e9d610
PE
68642011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6865
87e4427a
PE
6866 Fix minor problem found by static checking.
6867 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6868 initialized, to pacify gcc -Wuninitialized.
6869
e5e9d610
PE
6870 * fileio.c: Report proper errno when syscall falls.
6871 (Finsert_file_contents): Save and restore errno,
6872 so that report_file_error outputs the correct diagnostic.
6873 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6874
a1674f0b
EZ
68752011-09-18 Eli Zaretskii <eliz@gnu.org>
6876
6877 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6878
fbfb6dd4
EZ
68792011-09-17 Eli Zaretskii <eliz@gnu.org>
6880
6881 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6882 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6883
bb187662
EZ
68842011-09-17 Eli Zaretskii <eliz@gnu.org>
6885
1137e8b8 6886 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6887 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6888
6889 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6890 (bidi_find_paragraph_start): Search back for paragraph beginning
6891 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6892 (bidi_move_to_visually_next): Only trigger paragraph-related
6893 computations when the last character is a newline or at EOB, not
6894 just any NEUTRAL_B. (Bug#9470)
6895
bb187662
EZ
6896 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6897 truncated lines if point is covered by a display string. (Bug#9524)
6898
2e621251
PE
68992011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6900
6901 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6902 (cons_to_x_long): New function.
6903 (lisp_data_to_selection_data): Use it. Correct the test for
6904 short-versus-long data; it was negated. Break out of vector
6905 loop, for efficiency, when a long datum is discovered.
6906
91a15bc6
SM
69072011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6908
6909 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6910
b41c3a35
EZ
69112011-09-16 Eli Zaretskii <eliz@gnu.org>
6912
6913 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6914 GCC PR/17406) by declaring this function with external scope.
6915
7812ba2d
PE
69162011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6917
6918 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6919 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6920
cf7edc2a
AS
69212011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6922
6923 * editfns.c (Fformat): Correctly handle text properties on "%%".
6924
bd01620e
EZ
69252011-09-15 Eli Zaretskii <eliz@gnu.org>
6926
6927 * xterm.c (x_draw_composite_glyph_string_foreground):
6928 * w32term.c (x_draw_composite_glyph_string_foreground):
6929 * term.c (encode_terminal_code):
6930 * composite.c (composition_update_it, get_composition_id):
6931 * xdisp.c (get_next_display_element)
6932 (fill_composite_glyph_string): Add comments about special meaning
6933 of TAB characters in a composition.
6934
a02719a3
PE
69352011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6936
6937 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6938 This occurs when processing a multibyte format.
6939 Problem reported by Wolfgang Jenker.
a02719a3 6940
72589a3c
JB
69412011-09-15 Johan Bockgård <bojohan@gnu.org>
6942
6943 * xdisp.c (try_cursor_movement): Only check for exact match if
6944 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6945
1c14176c
PE
69462011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6947
6948 Remove unused external symbols.
6949 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6950 * xdisp.c (calc_pixel_width_or_height): Now static.
6951 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6952 * indent.c (check_display_width):
6953 * w32term.c: Fix comment to match code.
6954 * xterm.c, xterm.h (x_catching_errors): Remove.
6955
d2eea5b5
PE
69562011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6957
6958 * xselect.c: Use signed conversions more consistently (Bug#9498).
6959 (selection_data_to_lisp_data): Assume incoming selection data are
6960 signed integers, not unsigned. This is to be consistent with
6961 outgoing selection data, which was modified to use signed integers
6962 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6963 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6964 expects long, not unsigned long.
6965
46888499
EZ
69662011-09-14 Eli Zaretskii <eliz@gnu.org>
6967
6968 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6969 computation of loop end. Reported by Johan Bockgård
6970 <bojohan@gnu.org>.
6971
ef8ef9fb
CY
69722011-09-13 Chong Yidong <cyd@stupidchicken.com>
6973
6974 * frame.c (Fother_visible_frames_p): Function deleted.
6975
fa819fed
EZ
69762011-09-12 Eli Zaretskii <eliz@gnu.org>
6977
6978 * indent.c (compute_motion): Process display vector front to back
6979 rather than the other way around. (Bug#2496)
6980
2ba8e008
SM
69812011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6982
6983 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6984
20f53c69
CY
69852011-09-11 Chong Yidong <cyd@stupidchicken.com>
6986
6987 * minibuf.c (Fread_from_minibuffer): Doc fix.
6988
d562d7a4
EZ
69892011-09-11 Eli Zaretskii <eliz@gnu.org>
6990
6991 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6992 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6993
1c4d7f3d
LMI
69942011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6995
6996 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6997 value for non-existent files.
6998
b885bf36
EZ
69992011-09-11 Eli Zaretskii <eliz@gnu.org>
7000
7001 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7002 set its "size" to -1. This will set the modtime_size field of
7003 the corresponding buffer to -1, which is what
7004 verify-visited-file-modtime expects for files that do not exist.
7005 (Bug#9139)
7006
6612f0bf
PE
70072011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7008
7009 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7010 here ...
7011 * lisp.h: ... from here. push_key_description is no longer
7012 defined in keyboard.c, so its declaration should not be in
7013 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7014 logically belongs with push_key_description.
7015
dfb3f755
PE
70162011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7017
7018 * buffer.h: Include <sys/types.h> instead of <time.h>.
7019 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7020 Problem reported by Herbert J. Skuhra.
7021
3134906c
LMI
70222011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023
7024 * xml.c (parse_region): Make the parsing work for
7025 non-comment-starting XML files again (bug#9144).
7026
8d903f4e
AS
70272011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7028
7029 * image.c (gif_load): Fix calculation of bottom and right corner.
7030 (Bug#9468)
7031
80ad64f4
EZ
70322011-09-10 Eli Zaretskii <eliz@gnu.org>
7033
7034 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7035 redisplay in small windows.
7036
208a048d
EZ
70372011-09-09 Eli Zaretskii <eliz@gnu.org>
7038
7039 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7040
9b1c252e
MR
70412011-09-08 Martin Rudalics <rudalics@gmx.at>
7042
7043 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7044 Operate on live windows only.
7045
2949f33b
JB
70462011-09-08 Juanma Barranquero <lekktu@gmail.com>
7047
7048 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7049
e08dcafd
EZ
70502011-09-07 Eli Zaretskii <eliz@gnu.org>
7051
7052 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7053 only under bidi iteration.
7054
115b96bd
JD
70552011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7056
7057 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7058
c8199d0f
PE
70592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7060
7061 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7062 Without this fix, the command to link temacs failed due to an
7063 undefined symbol __builtin_isnan. This is because
7064 /usr/include/iso/math_c99.h #defines isnan(x) to
7065 __builtin_isnan(x), but the bundled gcc, which identifies itself
7066 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7067 a __builtin_isnan.
7068 * floatfns.c (isnan): #undef, and then #define to a clone of
7069 what's in data.c.
7070 (Fisnan): Always define, since it's always available now.
7071 (syms_of_floatfns): Always define isnan at the Lisp level.
7072
e39b275c 70732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7074
7075 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7076
b2db44d9 70772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7078
f4af5137 7079 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7080 The previous code assumed that file offsets (off_t values) fit in
7081 EMACS_INT variables, which is not true on typical 32-bit hosts.
7082 The code messed up by falsely reporting buffer overflow in cases
7083 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7084 when "big" contains more than 2**29 bytes, even though this
7085 inserts just one byte and does not overflow the buffer.
7086 (Finsert_file_contents): Store file offsets as off_t
7087 values, not as EMACS_INT values. Check for overflow when
7088 converting between EMACS_INT and off_t. When checking for
7089 buffer overflow or for overlap, take the offsets into account.
7090 Don't use EMACS_INT for small values where int suffices.
7091 When checking for overlap, fix a typo: ZV was used where
7092 ZV_BYTE was intended.
7093 (Fwrite_region): Don't assume off_t fits into 'long'.
7094 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7095
ecfc0a49
MA
70962011-09-05 Michael Albinus <michael.albinus@gmx.de>
7097
7098 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7099
6511acf2 71002011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7101
0999621a 7102 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7103
7104 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7105 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7106 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7107 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7108 (modify_event_symbol): Do not assume that the length of
7109 name_alist_or_stem is safe to alloca and fits in int.
7110 (Fexecute_extended_command): Likewise for function name and binding.
7111 (Frecursion_depth): Wrap around reliably on integer overflow.
7112 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7113 since some callers pass EMACS_INT values.
7114 (Fsingle_key_description): Don't crash if symbol name contains more
7115 than MAX_ALLOCA bytes.
7116 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7117 (get_minibuffer): Arg is now EMACS_INT, not int.
7118 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7119 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7120 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7121
2be7d702
PE
7122 * dbusbind.c (signature_cat): New function.
7123 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7124 Do not overrun buffer; instead, report string overflow.
7125
9d1df220
PE
7126 * dispnew.c (add_window_display_history): Don't overrun buffer.
7127 Truncate instead; this is OK since it's just a log.
7128
33ef5c64
PE
7129 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7130 even if the time zone offset is outlandishly large.
7131 Don't mishandle offset == INT_MIN.
7132
66c6fdd5
PE
7133 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7134 when creating daemon; the previous buffer-overflow check was incorrect.
7135
d749b01b
PE
7136 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7137 which has the guts of the old verror function.
7138
b5cd1905
PE
7139 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7140 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7141
6e1a67fb
PE
7142 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7143 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7144 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7145 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7146 length of string rather than counting it via multiple sprintfs;
7147 that's simpler and more reliable.
c21721cc
PE
7148 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7149 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7150 sprintf, in case result does not fit in int.
7151
c57b67fc
PE
7152 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7153 (fontset_from_font): Print it.
7154
8a401434
PE
7155 * frame.c (tty_frame_count): Now printmax_t, not int.
7156 (make_terminal_frame, set_term_frame_name): Print it.
7157 (x_report_frame_params): In X, window IDs are unsigned long,
7158 not signed long, so print them as unsigned.
7159 (validate_x_resource_name): Check for implausibly long names,
7160 and don't assume name length fits in 'int'.
7161 (x_get_resource_string): Don't blindly alloca invocation name;
7162 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7163 not fit in int.
7164
6e1a67fb
PE
7165 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7166 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7167 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7168
0df02bf3
PE
7169 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7170 Use esprintf, not sprintf, in case result does not fit in int.
7171
48e30793
PE
7172 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7173 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7174 it as a large positive number.
7175 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7176 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7177
a66ff6d8
PE
7178 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7179 in case result does not fit in int.
7180
aca216ff
PE
7181 * print.c (float_to_string): Detect width overflow more reliably.
7182 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7183 buffer overrun. Don't assume list length fits in 'int'. Treat
7184 print length of 0 as 0, not as infinity; to be consistent with other
7185 uses of print length in this function. Don't overflow print length
7186 index. Don't assume hash table size fits in 'long', or that
7187 vectorlike size fits in 'unsigned long'.
7188
31c286f7
PE
7189 * process.c (make_process): Use printmax_t, not int, to format
7190 process-name gensyms.
7191
55e5faa1
PE
7192 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7193
80f2e268
PE
7194 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7195 to avoid potential buffer overrun.
7196
670741ab
PE
7197 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7198 if X resource line is longer than 512 bytes.
7199
b7163a50
PE
7200 * xfns.c (x_window): Make sprintf buffer a bit bigger
7201 to avoid potential buffer overrun.
7202
ae58ff1f
PE
7203 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7204
c43c8a6a
PE
7205 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7206
3f8236f4
PE
72072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7208
53e9fe90 7209 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7210 Without these, Emacs silently mishandles large integers sometimes.
7211 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7212 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7213
6511acf2
PE
7214 * xdisp.c (try_window_id): Check Emacs fixnum range before
7215 converting to 'int'.
806add1d 7216
6511acf2 7217 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7218 Check that an Emacs fixnum is in range before assigning it to 'int'.
7219 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7220 values converted from Emacs fixnums.
7221 (Frecenter): Don't wrap around a line count if it is out of 'int'
7222 range; instead, treat it as an extreme value.
7223 (Fset_window_configuration, compare_window_configurations):
7224 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7225
6511acf2
PE
7226 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7227 that can exceed INT_MAX. Check that EMACS_INT value is in range
7228 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7229 (match_limit): Don't assume that a fixnum can fit in 'int'.
7230
6511acf2 7231 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7232 exceed INT_MAX.
7233
6511acf2 7234 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7235 (Fvertical_motion): Don't wrap around LINES values that don't fit
7236 in 'int'. Instead, treat them as extreme values. This is good
7237 enough for windows, which can't have more than INT_MAX lines anyway.
7238
fcb901a7
LMI
72392011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7240
0f2f6b6d
LMI
7241 * Require libxml/parser.h to avoid compilation warning.
7242
fcb901a7
LMI
7243 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7244
7245 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7246 since this reportedly can destroy thread storage.
7247
6e20a0d4
CY
72482011-08-30 Chong Yidong <cyd@stupidchicken.com>
7249
7250 * syntax.c (find_defun_start): Update all cache variables if
7251 exiting early (Bug#9401).
7252
148ae00e
EZ
72532011-08-30 Eli Zaretskii <eliz@gnu.org>
7254
f6cfbd8f
EZ
7255 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7256
148ae00e
EZ
7257 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7258 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7259 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7260
7261 * term.c (tty_append_glyph): New function.
7262 (produce_stretch_glyph): Static function and its prototype deleted.
7263
a66cfb1c
SM
7264 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7265 Add prototypes.
148ae00e 7266
c4a07a4c
PE
72672011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7268
7269 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7270 when checking :margin (Bug#9390).
7271 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7272 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7273 so that the name doesn't mislead. All uses changed.
7274
6bc8cd65
JB
72752011-08-28 Johan Bockgård <bojohan@gnu.org>
7276
7277 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7278 set_tty_hooks.
7279
dca4927e
EZ
72802011-08-27 Eli Zaretskii <eliz@gnu.org>
7281
7282 * xdisp.c (move_it_to): Don't bail out early when reaching
7283 position beyond to_charpos, if we are scanning backwards.
7284 (move_it_vertically_backward): When DY == 0, make sure we get to
7285 the first character in the line after the newline.
7286
f2cad773
PE
72872011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7288
7289 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7290 (ccl_driver): Do not generate an out-of-range pointer.
7291 (Fccl_execute_on_string): Remove unnecessary check for
7292 integer overflow, noted by Stefan Monnier in
7293 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7294 Remove a FIXME that didn't need fixing.
7295 Simplify the newly-introduced buffer reallocation code.
7296
0cae2cdb
JB
72972011-08-27 Juanma Barranquero <lekktu@gmail.com>
7298
7299 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7300
5fc295a4 73012011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7302
70c60eb2 7303 Integer and memory overflow issues (Bug#9196).
726e0ab1 7304
d31850da
PE
7305 * doc.c (get_doc_string): Rework so that
7306 get_doc_string_buffer_size is the actual buffer size, rather than
7307 being 1 less than the actual buffer size; this makes xpalloc more
7308 convenient.
7309
a69fbedb
PE
7310 * image.c (x_allocate_bitmap_record, cache_image):
7311 * xselect.c (Fx_register_dnd_atom):
7312 Simplify previous changes by using xpalloc.
7313
fe5c5d37
PE
7314 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7315 since either will do and ptrdiff_t is convenient with xpalloc.
7316
0065d054
PE
7317 * charset.c (charset_table_size)
7318 (struct charset_sort_data.priority): Now ptrdiff_t.
7319 (charset_compare): Don't overflow if priorities differ greatly.
7320 (Fsort_charsets): Don't assume list length fits in int.
7321 Check for size-calculation overflow when allocating sort data.
7322 (syms_of_charset): Allocate an initial charset table that is
7323 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7324
7325 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7326
7327 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7328 The actual value is always <= INT_MAX, and leaving it unsigned made
7329 overflow checking harder.
7330
7331 * dispextern.h (struct glyph_matrix.rows_allocated)
7332 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7333 with xpalloc. The values are still always <= INT_MAX.
7334
7335 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7336
7337 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7338 (SAFE_NALLOCA): New macro.
7339
7340 * region-cache.c (struct boundary.pos, find_cache_boundary)
7341 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7342 (set_cache_region, invalidate_region_cache)
7343 (revalidate_region_cache, know_region_cache, region_cache_forward)
7344 (region_cache_backward, pp_cache):
7345 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7346 so that ptrdiff_t * can be passed to xpalloc.
7347 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7348 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7349 (pp_cache): Don't assume cache_len fits in int.
7350 * region-cache.h: Adjust extern decls to match.
7351
7352 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7353 EMACS_INT, since either will do, for xpalloc.
7354
7355 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7356 (xnmalloc, xnrealloc, xpalloc): New functions.
7357
726e0ab1
PE
7358 * bidi.c (bidi_shelve_header_size): New constant.
7359 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7360 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7361
51f30bc5 7362 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7363 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7364 (overlay_strings):
7365 Don't update size of array until after memory allocation succeeds,
7366 because xmalloc/xrealloc may not return.
0065d054
PE
7367 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7368 now that we have proper integer overflow checking.
7369 (record_overlay_string, overlay_strings): Catch overflows when
7370 calculating size of overlay_str_buf.
726e0ab1 7371
0065d054
PE
7372 * callproc.c (Fcall_process): Check for size overflow when
7373 calculating size of args2.
7374 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7375 Normally we prefer signed values, but sticking with ptrdiff_t would
7376 require adding more-complicated checks.
726e0ab1
PE
7377
7378 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7379 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7380 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7381 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7382
7383 * character.c (Fstring): Check for size-calculation overflow.
7384
7385 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7386 unnecessary integer overflow. Check for size overflow.
7387 (encode_coding_object): Don't update size until xmalloc succeeds.
7388
7389 * composite.c (get_composition_id): Check for overflow in glyph
7390 length calculations.
7391
7392 Integer and memory overflow fixes for display code.
7393 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7394 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7395 (scrolling_window): Check for overflow in size calculations.
7396 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7397 Don't assume glyph table len fits in int.
7398 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7399 (row_table_size): Now ptrdiff_t, not int.
7400 (scrolling_window): Avoid overflow in size calculations.
7401 Don't update size until allocation succeeds.
7402 * fns.c (concat): Check for overflow in size calculations.
7403 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7404 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7405 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7406
7407 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7408 (get_doc_string): Check for size calculation overflow.
7409 Don't update size until allocation succeeds.
7410 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7411 EMACS_INT, where ptrdiff_t will do.
7412 (Fsubstitute_command_keys): Check for string overflow.
7413
7414 * editfns.c (set_time_zone_rule): Don't assume environment length
7415 fits in int.
7416 (message_length): Now ptrdiff_t, not int.
7417 (Fmessage_box): Don't update size until allocation succeeds.
7418 Don't assume message length fits in int.
7419 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7420
0065d054
PE
7421 * emacs.c (main): Do not reallocate argv, since there is a null at
7422 the end that can be overwritten, and this way there's no need to
7423 worry about size-calculation overflow.
7424 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7425
7426 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7427 alloc succeeds.
7428 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7429
7430 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7431 (x_set_scroll_bar_width, x_figure_window_size):
7432 Check for integer overflow.
7433 (x_set_alpha): Do not assume XINT fits in int.
7434
7435 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7436 This is for the members text_lines, text_cols, total_lines, total_cols,
7437 where the system imposes an 'int' limit.
7438
7439 * fringe.c (Fdefine_fringe_bitmap):
7440 Don't update size until alloc works.
7441
7442 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7443 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7444
7445 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7446 Check for size-calculation overflow.
7447 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7448 do, as we prefer signed integers.
7449 (id_to_widget.max_size, id_to_widget.used)
7450 (xg_store_widget_in_map, xg_remove_widget_from_map)
7451 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7452 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7453 Use and return ptrdiff_t, not int.
7454 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7455 * gtkutil.h: Change prototypes to match the above.
7456
7457 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7458 are duplicate now that they've been promoted to lisp.h.
7459 (x_allocate_bitmap_record, x_alloc_image_color)
7460 (make_image_cache, cache_image, xpm_load):
7461 Don't update size until alloc is done.
7462 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7463 (x_detect_edges):
3256efce 7464 Check for size calculation overflow.
726e0ab1
PE
7465 (ct_colors_allocated_max): New constant.
7466 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7467 overflow.
3256efce 7468
726e0ab1
PE
7469 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7470 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7471 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7472 Use ptrdiff_t, not int, to count maps.
7473 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7474 calculations. Don't update size until allocation succeeds.
7475 Redo calculations to avoid overflow.
726e0ab1
PE
7476 * keyboard.h: Change prototypes to match the above.
7477
7478 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7479 to count maps.
7480 (current_minor_maps): Check for size calculation overflow.
7481 * keymap.h: Change prototypes to match the above.
7482
7483 * lread.c (read1, init_obarray): Don't update size until alloc done.
7484
7485 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7486 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7487
726e0ab1
PE
7488 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7489 Now ptrdiff_t, not int.
7490 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7491 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7492
7493 * process.c (Fnetwork_interface_list): Check for overflow
7494 in size calculation.
7495
7496 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7497
7498 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7499 overflow. Don't bother calling xmalloc when xrealloc will do.
7500
7501 * search.c (Freplace_match): Check for size calculation overflow.
7502 (Fset_match_data): Don't assume list lengths fit in 'int'.
7503
7504 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7505 for command line length. Do not attempt to address one before the
7506 beginning of an array, as that's not portable.
7507
7508 * term.c (max_frame_lines): Remove; unused.
7509 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7510 not int.
7511 (encode_terminal_code, calculate_costs): Check for size
7512 calculation overflow.
7513 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7514 table lengths and related sizes. Don't update size until alloc
7515 done. Redo calculations to avoid overflow.
7516 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7517
7518 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7519 subtracting pointers.
7520 (gobble_line): Check for overflow more carefully. Don't update size
7521 until alloc done.
7522
7523 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7524 Don't update size until alloc done.
7525 Redo size calculations to avoid overflow.
7526 Check for size calculation overflow.
0065d054 7527 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7528
7529 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7530 Use ptrdiff_t, not int, for sizes.
7531 (store_mode_line_noprop_char): Don't update size until alloc done.
7532
0065d054
PE
7533 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7534 Use ptrdiff_t, not int, for sizes.
7535 (Finternal_make_lisp_face, cache_face):
7536 Check for size calculation overflow.
7537 (cache_face): Treat size calculation overflows as if they were
7538 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7539
7540 * xfns.c (x_encode_text, x_set_name_internal)
7541 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7542 sizes, since they can exceed INT_MAX in size. Check for size
7543 calculation overflow.
7544
0065d054
PE
7545 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7546 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7547 Don't update size until alloc done.
7548
0065d054 7549 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7550 as sprintf is limited to int lengths.
1d526e2f 7551
252c5ee1
PE
7552 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7553 (X_LONG_MIN): New macros.
864d7ce7
PE
7554 Use them to make the following changes clearer.
7555 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7556 This change doesn't affect the value now, but it may help remind
7557 future maintainers not to raise the value too much later.
7558 (SELECTION_QUANTUM): Remove, replacing with ...
7559 (selection_quantum): ... new function, which avoids overflow.
7560 All uses changed.
7561 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7562 assumption that selection length fits in 'int'.
7563 (x_reply_selection_request, x_handle_selection_request)
7564 (x_get_window_property, receive_incremental_selection)
7565 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7566 (lisp_data_to_selection_data, clean_local_selection_data):
7567 Use ptrdiff_t, not int, to record length of selection.
7568 (x_reply_selection_request, x_get_window_property)
7569 (receive_incremental_selection, x_property_data_to_lisp):
7570 Redo calculations to avoid overflow.
7571 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7572 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7573 something.
7574 (x_get_window_property, receive_incremental_selection)
7575 (lisp_data_to_selection_data, x_property_data_to_lisp):
7576 Check for size-calculation overflow.
7577 (x_get_window_property, receive_incremental_selection)
7578 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7579 Don't store size until memory allocation succeeds.
7580 (x_get_window_property): Plug memory leak on memory exhaustion.
7581 Don't double-block input; malloc is safe here. Don't assume 2**34
7582 - 4 fits in unsigned long. Add an xassert to check
7583 XGetWindowProperty overflow. Be more careful about overflow
7584 calculations, and distinguish size from memory overflow better.
7585 (receive_incremental_selection): When tracing, don't assume
7586 unsigned int is less than INT_MAX.
7587 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7588 harmful) conversions of unsigned short to int.
7589 (lisp_data_to_selection_data): Don't assume that integers
7590 in the range -65535 through -1 fit in an X unsigned short.
7591 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7592 result parameters unless successful. Rely on cons_to_unsigned
7593 to report problems with elements; the old code wasn't right anyway.
7594 (x_check_property_data): Check for int overflow; we cannot use
7595 a wider type due to X limits.
7596 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7597
726e0ab1 7598 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7599
0065d054
PE
7600 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7601 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7602 (x_color_cells): Don't store size until memory allocation succeeds.
7603 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7604 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7605 (x_term_init): Don't assume length fits in int (sprintf is limited
7606 to int size).
bc18e09d 7607
ebfa62c0
PE
7608 Use ptrdiff_t for composition IDs.
7609 * character.c (lisp_string_width):
7610 * composite.c (composition_table_size, n_compositions)
7611 (get_composition_id, composition_gstring_from_id):
7612 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7613 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7614 * window.c (Frecenter):
7615 Use ptrdiff_t, not int, for composition IDs.
7616 * composite.c (get_composition_id): Check for integer overflow.
7617 * composite.h: Adjust prototypes to match the above changes.
7618
d3411f89
PE
7619 Use ptrdiff_t for hash table indexes.
7620 * category.c (hash_get_category_set):
7621 * ccl.c (ccl_driver):
7622 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7623 * coding.c (coding_system_charset_list, detect_coding_system):
7624 * coding.h (struct coding_system.id):
7625 * composite.c (get_composition_id, gstring_lookup_cache):
7626 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7627 * image.c (xpm_get_color_table_h):
7628 * lisp.h (hash_lookup, hash_put):
7629 * minibuf.c (Ftest_completion):
7630 Use ptrdiff_t for hash table indexes, not int (which is too
7631 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7632 32-bit --with-wide-int hosts).
7633
e097a6fa
PE
7634 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7635 Add a FIXME comment about memory leaks.
7636 (syms_of_charset): Don't assume xmalloc returns.
7637
5637687f
PE
7638 Don't assume that stated character widths fit in int.
7639 * character.c (Fchar_width, c_string_width, lisp_string_width):
7640 * character.h (CHAR_WIDTH):
7641 * indent.c (MULTIBYTE_BYTES_WIDTH):
7642 Use sanitize_char_width to avoid undefined and/or bad behavior
7643 with outlandish widths.
a66cfb1c 7644 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7645 now that we have two such functions. All uses changed.
7646 (sanitize_char_width): New inline function.
7647
a2271ba2
PE
7648 Don't assume that tab-width fits in int.
7649 * character.h (sanitize_width): New inline function.
7650 (SANE_TAB_WIDTH): New macro.
7651 (ASCII_CHAR_WIDTH): Use it.
7652 * indent.c (sane_tab_width): Remove. All uses replaced by
7653 SANE_TAB_WIDTH (current_buffer).
7654 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7655
18c52557
PE
7656 * fileio.c: Integer overflow issues with file modes.
7657 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7658
caeeedc1
PE
7659 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7660 Remove unreachable code.
7661 (read_hex, load_charset_map_from_file): Check for integer overflow.
7662
6df6ae42 7663 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7664 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7665 (x_send_scroll_bar_event): Likewise. Check that the size does not
7666 exceed limits imposed by XClientMessageEvent, as well as the usual
7667 ptrdiff_t and size_t limits.
7668
b13995db
PE
7669 * keyboard.c: Overflow, signedness and related fixes.
7670 (make_lispy_movement): Use same integer type in forward decl
7671 that is used in the definition.
7672 (read_key_sequence, keyremap_step):
7673 Change bufsize argument back to int, undoing my 2011-03-30 change.
7674 We prefer signed types, and int is wide enough here.
7675 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7676 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7677 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7678 length, not size_t. Use ptrdiff_t for index, not int.
7679 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7680 possibility of integer overflow.
7681
13464394
PE
7682 Overflow, signedness and related fixes for images.
7683
7684 * dispextern.h (struct it.stack[0].u.image.image_id)
7685 (struct_it.image_id, struct image.id, struct image_cache.size)
7686 (struct image_cache.used, struct image_cache.ref_count):
7687 * gtkutil.c (update_frame_tool_bar):
7688 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7689 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7690 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7691 * nsmenu.m (update_frame_tool_bar):
7692 * xdisp.c (calc_pixel_width_or_height):
7693 * xfns.c (image_cache_refcount):
7694 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7695 on typical 64-bit hosts.
7696
7697 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7698 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7699 Omit unnecessary casts to int.
7700 (parse_image_spec): Check that integers fall into 'int' range
7701 when the callers expect that.
7702 (image_ascent): Redo ascent calculation to avoid int overflow.
7703 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7704 (lookup_image): Remove unnecessary tests.
7705 (xbm_image_p): Locals are now of int, not EMACS_INT,
7706 since parse_image_check makes sure they fit into int.
7707 (png_load, gif_load, svg_load_image):
7708 Prefer int to unsigned where either will do.
7709 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7710 old tiff_error_handler and tiff_warning_handler.
7711 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7712 stack buffer overflows. It uses only the features of vsnprintf
7713 that are common to both POSIX and native Microsoft.
7714 (tiff_error_handler, tiff_warning_handler): Use it.
7715 (tiff_load, gif_load, imagemagick_load_image):
7716 Don't assume :index value fits in 'int'.
7717 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7718 (imagemagick_load_image): Check that crop parameters fit into
7719 the integer types that MagickCropImage accepts. Don't assume
7720 Vimagemagick_render_type has a nonnegative value. Don't assume
7721 size_t fits in 'long'.
7722 (gs_load): Use printmax_t to print the widest integers possible.
7723 Check for integer overflow when computing image height and width.
7724
c11821d4
EZ
77252011-08-26 Eli Zaretskii <eliz@gnu.org>
7726
7727 * xdisp.c (redisplay_window): Don't force window start if point
7728 will be invisible in the resulting window. (Bug#9324)
7729
0c95fcf7
EZ
77302011-08-25 Eli Zaretskii <eliz@gnu.org>
7731
7732 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7733 the display spec is of the form `(space ...)'.
7734 (handle_display_spec): Return the value returned by
7735 handle_single_display_spec, not just 1 or zero.
7736 (handle_single_display_spec): If the display spec is of the form
7737 `(space ...)', and specifies display in the text area, return 2
7738 rather than 1.
fee65a97 7739 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7740 accurately, and prefer exact match for point under bidi.
7741 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7742
7743 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7744 into disp_prop; all users changed.
7745
7746 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7747 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7748 for the text covered by the display property.
7749
e4ed06f1
CY
77502011-08-25 Chong Yidong <cyd@stupidchicken.com>
7751
7752 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7753 Change return value to nil.
7754 (Frecord_buffer): Delete unused function.
7755
f67cdd7f
EZ
77562011-08-24 Eli Zaretskii <eliz@gnu.org>
7757
5980d4c6
EZ
7758 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7759 buffers, return left-to-right.
8610fe8b
EZ
7760 (set_cursor_from_row): Consider candidate row a win if its glyph
7761 represents a newline and point is on that newline. Fixes cursor
7762 positioning on the newline at EOL of R2L text within L2R
7763 paragraph, and vice versa.
7764 (try_cursor_movement): Check continued rows, in addition to
7765 continuation rows. Fixes unwarranted scroll when point enters a
7766 continued line of R2L text within an L2R paragraph, or vice versa.
7767 (cursor_row_p): Consider the case of point being equal to
7768 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7769 from the end of a short line to the beginning of a continued line
7770 of R2L text within L2R paragraph.
7771 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7772 composed characters.
5980d4c6 7773
f67cdd7f
EZ
7774 * bidi.c (bidi_check_type): Use xassert.
7775 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7776 members.
7777
bca633fb
EZ
77782011-08-23 Eli Zaretskii <eliz@gnu.org>
7779
7780 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7781 a character.
7782
4a5885a7
CY
77832011-08-23 Chong Yidong <cyd@stupidchicken.com>
7784
7785 * nsfont.m (ns_otf_to_script): Fix typo.
7786
0902a04e
KH
77872011-08-22 Kenichi Handa <handa@m17n.org>
7788
7789 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7790 extra slot even if the purpose is char-code-property-table.
7791
1a2e6670
EZ
77922011-08-23 Eli Zaretskii <eliz@gnu.org>
7793
8ddde651
EZ
7794 * xdisp.c (redisplay_window): When computing centering_position,
7795 account for the height of the header line. (Bug#8874)
7796
425cc014
EZ
7797 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7798 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7799 candidate is selected by the mouse, and that candidate has a
7800 composed character under the mouse.
7801
1a2e6670
EZ
7802 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7803 coordinates reported by pos-visible-in-window-p for a composed
7804 character in column zero.
7805
8b76d6f8
SM
78062011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7807
7808 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7809
dac347dd
EZ
78102011-08-22 Eli Zaretskii <eliz@gnu.org>
7811
7812 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7813 consider it a hit if to_charpos is anywhere in the range of the
7814 composed buffer positions.
7815
e013fb34
CY
78162011-08-22 Chong Yidong <cyd@stupidchicken.com>
7817
7818 * image.c (gif_load): Don't assume that each subimage has the same
7819 dimensions as the base image. Handle disposal method that is
7820 "undefined" by the gif spec (Bug#9335).
7821
bd1ba3e8
CY
78222011-08-20 Chong Yidong <cyd@stupidchicken.com>
7823
7824 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7825 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7826
54a1215b
EZ
78272011-08-19 Eli Zaretskii <eliz@gnu.org>
7828
823564e5
EZ
7829 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7830 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7831 from an Org mode buffer to a Speedbar frame.
7832
54a1215b
EZ
7833 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7834 a composition, take its buffer position from IT->cmp_it.charpos.
7835 Fixes cursor positioning at the beginning of a line that begins
7836 with a composed character.
7837
9778ebcc
EZ
78382011-08-18 Eli Zaretskii <eliz@gnu.org>
7839
0be6ee06
EZ
7840 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7841 character bidirectional type, use STRONG_L instead. Fixes crashes
7842 in a buffer produced by `describe-categories'.
7843
9778ebcc
EZ
7844 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7845 members before the level stack, so they would be saved and
7846 restored when copying iterator state. Fixes incorrect reordering
7847 around TABs covered by display properties.
7848
156bffbe
AS
78492011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7850
6b02f655 7851 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7852
72ad093b
CY
78532011-08-17 Chong Yidong <cyd@stupidchicken.com>
7854
7855 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7856 (internal_condition_case_2, internal_condition_case_n):
7857 Remove unnecessary aborts (Bug#9081).
72ad093b 7858
35774242
EZ
78592011-08-17 Eli Zaretskii <eliz@gnu.org>
7860
7861 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7862 has no `load' handler, try opening the file locally. (Bug#9311)
7863
db76dd85
KB
78642011-08-16 Ken Brown <kbrown@cornell.edu>
7865
7866 * gmalloc.c: Expand comment.
7867
b215eee5
EZ
78682011-08-16 Eli Zaretskii <eliz@gnu.org>
7869
7870 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7871 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7872
a4579d33
KB
78732011-08-16 Ken Brown <kbrown@cornell.edu>
7874
7875 Fix memory allocation problems in Cygwin build (Bug#9273).
7876
7877 * unexcw.c ( __malloc_initialized): Declare external variable.
7878 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7879
8b76d6f8
SM
7880 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7881 New variables.
a4579d33
KB
7882 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7883 dumped emacs.
7884 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7885 in the static heap.
7886 [CYGWIN] (special_realloc): New function.
7887 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7888 requests to realloc storage in the static heap.
7889
3ebec551
PE
78902011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7891
7892 * bidi.c (bidi_initialize): Remove unused local.
7893
9fd8be00
EZ
78942011-08-15 Eli Zaretskii <eliz@gnu.org>
7895
6b02f655
SM
7896 * bidimirror.h:
7897 * biditype.h: Remove file.
7898 * makefile.w32-in ($(BLD)/bidi.$(O)):
7899 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7900
7901 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7902
7903 * chartab.c: Improve commentary for the uniprop_table API.
7904
32413314
EZ
7905 * bidi.c (bidi_paragraph_init): Support zero value of
7906 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7907 (bidi_initialize): Use uniprop_table instead of including
7908 biditype.h and bidimirror.h.
32413314 7909
9fd8be00
EZ
7910 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7911 coordinates of the iterator when restoring from ppos_it.
7912 (Bug#9296)
7913
5cf2b69b
KH
79142011-08-14 Kenichi Handa <handa@m17n.org>
7915
7916 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7917 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7918
daf17d00
EZ
79192011-08-14 Eli Zaretskii <eliz@gnu.org>
7920
7921 * xdisp.c (move_it_in_display_line_to): Don't invoke
7922 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7923 ppos_it. Fixes vertical cursor motion when line beginning is
7924 covered by an image. (Bug#9296)
7925
08e3161a
JD
79262011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7927
7928 * nsterm.h (ns_run_ascript): Declare.
7929 (NSAPP_DATA2_RUNASSCRIPT): Define.
7930
7931 * nsfns.m (as_script, as_result, as_status): New static variables.
7932 (ns_run_ascript): New function.
5e617bc2 7933 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7934 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7935 the event loop. Get status from as_status (Bug#7276).
7936
7937 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7938 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7939 the event loop (Bug#7276).
7940
a3720aa2
AS
79412011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7942
7943 * gnutls.c (QCgnutls_bootprop_priority)
7944 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7945 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7946 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7947 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7948 (QCgnutls_bootprop_verify_hostname_error)
7949 (QCgnutls_bootprop_callbacks_verify): Rename from
7950 Qgnutls_bootprop_..., all uses changed.
7951
7952 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7953 uses changed.
7954
0a0d27fb
PE
79552011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7956
19d5c50c
PE
7957 * xfaces.c (Qframe_set_background_mode): Now static.
7958 * dispextern.h (Qframe_set_background_mode): Remove decl.
7959
0a0d27fb
PE
7960 * process.c (Fnetwork_interface_info): Declare local only if needed.
7961
377538cb
JD
79622011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7963
7964 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7965 (Fnetwork_interface_list): Allocate in increments of bytes instead
7966 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7967 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7968 sockaddr.
7969 (struct ifflag_def): notrailers is smart on OSX.
7970 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7971 Get hardware address with getifaddrs if available.
7972
08fff70c
EZ
79732011-08-12 Eli Zaretskii <eliz@gnu.org>
7974
7975 * xdisp.c (iterate_out_of_display_property): xassert that
7976 IT->position is set to within IT->object's boundaries. Break from
7977 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7978 when IT->position is set up wrongly due to some bug.
7979 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7980 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7981 entry. Force push_it to save on the stack the current
7982 buffer/string position, to be restored by pop_it. Fix flags in
7983 the iterator structure wrt the object coming from a display
7984 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7985 properties. (Bug#9284)
7986
7be1c708 79872011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7988
7be1c708
CY
7989 * fontset.c (fontset_get_font_group): Add proper type checks.
7990 (Bug#9172)
aac0c6e3 7991
7be1c708 79922011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7993
7be1c708
CY
7994 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7995 and LC_VERSION_MIN_MACOSX.
7996 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7997 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7998
97bb72a6
EZ
79992011-08-08 Eli Zaretskii <eliz@gnu.org>
8000
8001 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8002 no-display-properties-and-no-overlays under bidi display.
8003 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8004 properties and overlays.
97bb72a6 8005
d5617611
CY
80062011-08-08 Chong Yidong <cyd@stupidchicken.com>
8007
37e11a63
CY
8008 * editfns.c (Fset_time_zone_rule): Document relationship with the
8009 setenv function.
8010
d5617611
CY
8011 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8012 the font entity extracted from the cache (Bug#8109).
8013
58872834
CY
80142011-08-07 Chong Yidong <cyd@stupidchicken.com>
8015
8016 * composite.c (autocmp_chars): Don't reset point. That is done by
8017 restore_point_unwind (Bug#5984).
8018
75bfc667
JL
80192011-08-07 Juri Linkov <juri@jurta.org>
8020
8021 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8022 to show the arg `TIME' instead of `TIMEVAL'.
8023
d1410150
EZ
80242011-08-06 Eli Zaretskii <eliz@gnu.org>
8025
8026 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8027 display property strides EOL and includes a newline, as in
8028 longlines-mode. (Bug#9254)
75b771e4
EZ
8029 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8030 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8031
8032 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8033 is non-zero, even if the data buffer is NULL. Fixes a crash in
8034 vertical-motion with longlines-mode. (Bug#9254)
8035
35928349
EZ
80362011-08-05 Eli Zaretskii <eliz@gnu.org>
8037
ec7cc85b
EZ
8038 * bidi.c <bidi_cache_total_alloc>: Now static.
8039 (bidi_initialize): Initialize bidi_cache_total_alloc.
8040
8b76d6f8 8041 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8042 cache. (Bug#9221)
8043
8044 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8045 amount allocated this far in `bidi_cache_total_alloc'.
8046 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8047 non-zero, only free the data buffer without restoring the cache
8048 contents. All callers changed.
8049
8050 * dispextern.h (bidi_unshelve_cache): Update prototype.
8051
8052 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8053 (move_it_in_display_line, move_it_to)
8054 (move_it_vertically_backward, move_it_by_lines): Replace the call
8055 to xfree to an equivalent call to bidi_unshelve_cache.
8056 (move_it_in_display_line_to): Fix logic of returning
412b6358 8057 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8058
e2e2423b
EZ
80592011-08-05 Eli Zaretskii <eliz@gnu.org>
8060
8061 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8062 came from a string character with a `cursor' property. (Bug#9229)
8063
ae9e757a
JD
80642011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8065
8066 * Makefile.in (LIB_PTHREAD): New variable.
8067 (LIBES): Add LIB_PTHREAD (Bug#9216).
8068
8069 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8070 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8071
213bd7f2
AS
80722011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8073
6b02f655 8074 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8075
99aaf75f
JD
80762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8077
8078 * xterm.c (x_find_topmost_parent): New function.
8079 (x_set_frame_alpha): Find topmost parent window with
8080 x_find_topmost_parent and set the property there also (bug#9181).
8081 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8082
c74e9d86
PE
80832011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8084
8085 * callproc.c (Fcall_process): Avoid vfork clobbering
8086 the local vars buffer, coding_systems, current_dir.
8087
640c8776
SM
80882011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8089
8090 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8091
f26d0e4c
PE
80922011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8093
8a10d76c
PE
8094 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8095 so that it is not optimized away.
8096
f26d0e4c
PE
8097 * xdisp.c (compute_display_string_pos): Remove unused local.
8098
55439c61
EZ
80992011-08-02 Eli Zaretskii <eliz@gnu.org>
8100
8101 Fix slow cursor motion and scrolling in large buffers with
8102 selective display, like Org Mode buffers. (Bug#9218)
8103
8104 * dispextern.h (struct bidi_it): New member disp_prop_p.
8105
8106 * xdisp.c: Remove one-slot cache of display string positions.
8107 (compute_display_string_pos): Accept an additional argument
5e617bc2 8108 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8109 for a display string or property. If found, set DISP_PROP_P
8110 non-zero.
8111
8112 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8113 DISP_PROP_P, and pass it to compute_display_string_pos.
8114 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8115 non-zero. All callers of bidi_fetch_char changed.
8116
fb33fa43
SM
81172011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8118
8119 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8120
b099e063
DM
81212010-12-03 Don March <don@ohspite.net>
8122
8123 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8124 last character M-[char] is translated to ESC [char] (bug#7541).
8125
5cc7f7af
KH
81262011-08-02 Kenichi Handa <handa@m17n.org>
8127
d0fffa3f 8128 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8129
8130 * chartab.c (uniprop_table): Make it non-static.
8131
525d5e6e
EZ
81322011-08-01 Eli Zaretskii <eliz@gnu.org>
8133
8134 * xdisp.c (forward_to_next_line_start): Accept additional argument
8135 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8136 on the newline.
8137 (reseat_at_next_visible_line_start): Use the bidi iterator state
8138 returned by forward_to_next_line_start to restore the state of
8139 it->bidi_it after backing up to previous newline. (Bug#9212)
8140
31011111
AS
81412011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8142
8143 * regex.c (re_comp): Protoize.
8144 (re_exec): Fix return type.
8145 (regexec): Fix type of `ret'. (Bug#9203)
8146
476371c4
PE
81472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8148
e5d76069
PE
8149 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8150 This is needed if max-image-size is a floating-point number.
8151
9a79b20c
AS
81522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8153
8154 * print.c (print_object): Print empty symbol as ##.
8155
8156 * lread.c (read1): Read ## as empty symbol.
8157
d8c2fa78
AA
81582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8159
8160 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8161 setting frame foreground color (Bug#9175).
8162 (x_set_background_color): Likewise.
8163
ffe57a7a
AA
8164 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8165 contents (Bug#9176).
8166 (EmacsTooltip -init): Remove bezels and add shadows to
8167 tooltip windows.
8168
bf3492a5
AA
8169 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8170 or scroll bar (Bug#8470).
8171
d55e9c53
AA
8172 * nsfont.m (nsfont_open): Remove assignment to voffset and
8173 unnecessary vars hshink, expand, hd, full_height, min_height.
8174 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8175
8176 * nsterm.h (nsfont_info): Remove voffset field.
8177
d8c2fa78 81782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8179
8180 Implement strike-through and overline on NextStep (Bug#8863).
8181
8182 * nsfont.m (nsfont_open): Use underline position provided by font,
8183 instead of hard-coded value of 2.
8184 (nsfont_draw): Call ns_draw_text_decoration instead.
8185
8186 * nsterm.h: Add declaration for ns_draw_text_decoration.
8187
8188 * nsterm.m (ns_draw_text_decoration): New function for drawing
8189 underline, overline, and strike-through.
8190 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8191 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8192 accommodate underlining, etc.
4843aac3 8193
4cc60b9b
EZ
81942011-07-28 Eli Zaretskii <eliz@gnu.org>
8195
bc7ece87
EZ
8196 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8197 default.
4cc60b9b 8198
476371c4
PE
81992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8200
66606eea
PE
8201 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8202 Without this fix, if a signal arrives just after memory fills up,
8203 'malloc' might be invoked reentrantly.
8204
476371c4
PE
8205 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8206 In other words, assume that every image size is allowed, on non-X
8207 hosts. This assumption is probably wrong, but it lets Emacs compile.
8208
f3fcc40d
AS
82092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8210
8211 * regex.c (re_iswctype): Convert return values to boolean.
8212
350c992f
EZ
82132011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8214
8215 * xdisp.c (compute_display_string_pos): Don't use cached display
8216 string position if the buffer had its restriction changed.
8217 (Bug#9184)
8218
5266b4bb
PE
82192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8220
8221 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8222
2573a837 82232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8224
41f55ccd 8225 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8226
39e378da
PE
8227 * bidi.c: Integer size and overflow fixes.
8228 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8229 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8230 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8231 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8232 (bidi_find_other_level_edge):
8233 Use ptrdiff_t instead of EMACS_INT where either will do.
8234 This works better on 32-bit hosts configured --with-wide-int.
8235 (bidi_cache_ensure_space): Check for size-calculation overflow.
8236 Use % rather than repeated addition, for better worst-case speed.
8237 Don't set bidi_cache_size until after xrealloc returns, because it
8238 might not return.
8239 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8240 (bidi_cache_ensure_space): Also check that the bidi cache size
8241 does not exceed that of the largest Lisp string or buffer. See Eli
8242 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8243
5e927815
PE
8244 * alloc.c (__malloc_size_t): Remove.
8245 All uses replaced by size_t. See Andreas Schwab's note
8246 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8247
ca4aa935
PE
8248 * image.c: Improve checking for integer overflow.
8249 (check_image_size): Assume that f is nonnull, since
8250 it is always nonnull in practice. This is one less thing to
8251 worry about when checking for integer overflow later.
8252 (x_check_image_size): New function, which checks for integer
8253 overflow issues inside X.
8254 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8255 This removes the need for a memory_full check.
8256 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8257 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8258 (xbm_read_bitmap_data): Change locals back to 'int', since
8259 their values must fit in 'int'.
8260 (xpm_load_image, png_load, tiff_load):
8261 Invoke x_create_x_image_and_pixmap earlier,
8262 to avoid much needless work if the image is too large.
8263 (tiff_load): Treat overly large images as if
8264 x_create_x_image_and_pixmap failed, not as malloc failures.
8265 (gs_load): Use x_check_image_size.
8266
5f8f9cc2
PE
8267 * gtkutil.c: Omit integer casts.
8268 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8269 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8270
5adf60bc
PE
8271 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8272
c8907a93
PE
8273 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8274 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8275 would wrongly return t on a 64-bit host.
8276
e3c25c68
PE
8277 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8278 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8279 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8280 and therefore cause GCC to emit a bogus diagnostic in some cases.
8281
3f791afe
PE
8282 * image.c: Integer signedness and overflow and related fixes.
8283 This is not an exhaustive set of fixes, but it's time to
8284 record what I've got.
8285 (lookup_pixel_color, check_image_size): Remove redundant decls.
8286 (check_image_size): Don't assume that arbitrary EMACS_INT values
8287 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8288 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8289 (tiff_load, imagemagick_load_image):
8290 Check for overflow in size calculations.
8291 (x_create_x_image_and_pixmap): Remove unnecessary test for
8292 xmalloc returning NULL; that can't happen.
8293 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8294 (xpm_color_bucket): Use better integer hashing function.
8295 (xpm_cache_color): Don't possibly over-allocate memory.
8296 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8297 (gif_memory_source):
8298 Use ptrdiff_t, not int or size_t, to record sizes.
8299 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8300 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8301 either works, as we prefer signed integers.
8302 (tiff_read_from_memory, tiff_write_from_memory):
8303 Return tsize_t, not size_t, since that's what the TIFF API wants.
8304 (tiff_read_from_memory): Don't fail simply because the read would
8305 go past EOF; instead, return a short read.
8306 (tiff_load): Omit no-longer-needed casts.
8307 (Fimagemagick_types): Don't assume size fits into 'int'.
8308
3cc5a532
PE
8309 Improve hashing quality when configured --with-wide-int.
8310 * fns.c (hash_string): New function, taken from sxhash_string.
8311 Do not discard information about ASCII character case; this
8312 discarding is no longer needed.
8313 (sxhash-string): Use it. Change sig to match it. Caller changed.
8314 * lisp.h: Declare it.
8315 * lread.c (hash_string): Remove, since we now use fns.c's version.
8316 The fns.c version returns a wider integer if --with-wide-int is
8317 specified, so this should help the quality of the hashing a bit.
8318
b312a492
PE
8319 * emacs.c: Integer overflow minor fix.
8320 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8321 Define only if GNU_LINUX.
8322 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8323
dfd153ae
PE
8324 * dispnew.c: Integer signedness and overflow fixes.
8325 Remove unnecessary forward decls, that were a maintenance hassle.
8326 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8327 All uses changed.
8328 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8329 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8330 (prepare_desired_row, line_draw_cost):
8331 Use int, not unsigned, where either works.
8332 (save_current_matrix, restore_current_matrix):
8333 Use ptrdiff_t, not size_t, where either works.
8334 (init_display): Check for overflow more accurately, and without
8335 relying on undefined behavior.
8336
a81d11a3
PE
8337 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8338 Remove, replacing with the new symbols in lisp.h. All uses changed.
8339 * fileio.c (make_temp_name):
8340 * filelock.c (lock_file_1, lock_file):
8341 * xdisp.c (message_dolog):
8342 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8343 Use pMd etc. instead.
8344 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8345 replacing the pWIDE etc. symbols removed from editfns.c.
8346
3300e6fd
PE
8347 * keyboard.h (num_input_events): Now uintmax_t.
8348 This is (very slightly) less likely to mess up due to wraparound.
8349 All uses changed.
8350
fd05c7e9
PE
8351 * buffer.c: Integer signedness fixes.
8352 (alloc_buffer_text, enlarge_buffer_text):
8353 Use ptrdiff_t rather than size_t when either will do, as we prefer
8354 signed integers.
8355
903fe15d
PE
8356 * alloc.c: Integer signedness and overflow fixes.
8357 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8358 (__malloc_size_t): Default to size_t, not to int.
8359 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8360 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8361 Prefer ptrdiff_t to size_t when either would do, as we prefer
8362 signed integers.
8363 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8364 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8365 Now const. Initialize with values that are in range even if char
8366 is signed.
8367 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8368 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8369 These functions do the right thing with sizes > 2**32.
8370 (check_depth): Now ptrdiff_t, not int.
8371 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8372 Adjust to new way of storing sizes. Check for size overflow bugs
8373 in rest of code.
8374 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8375 slightly wrong anyway, as it missed one instance of
8376 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8377 (refill_memory_reserve): Omit needless cast to size_t.
8378 (mark_object_loop_halt): Mark as externally visible.
8379
ac82cc6a
PE
8380 * xselect.c: Integer signedness and overflow fixes.
8381 (Fx_register_dnd_atom, x_handle_dnd_message):
8382 Use ptrdiff_t, not size_t, since we prefer signed.
8383 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8384 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8385 x_dnd_atoms_size and x_dnd_atoms_length.
8386
c2d1e36d
PE
8387 * doprnt.c: Prefer signed to unsigned when either works.
8388 * eval.c (verror):
8389 * doprnt.c (doprnt):
8390 * lisp.h (doprnt):
8391 * xdisp.c (vmessage):
8392 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8393 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8394 prefer signed arithmetic to avoid comparison confusion.
8395 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8396 but is a bit tricky.
8397
0e926e56
PE
8398 Assume freestanding C89 headers, string.h, stdlib.h.
8399 * data.c, doprnt.c, floatfns.c, print.c:
8400 Include float.h unconditionally.
8401 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8402 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8403 * regex.c: Likewise for stddef.h, string.h.
8404 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8405 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8406 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8407 (STDC_HEADERS): Remove obsolete defines.
8408 * sysdep.c: Include limits.h unconditionally.
8409
9cfdb3ec
PE
8410 Assume support for memcmp, memcpy, memmove, memset.
8411 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8412 * regex.c (memcmp, memcpy):
8413 Remove; we assume C89 now.
8414
8415 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8416 (__malloc_safe_bcopy): Remove; no longer needed.
8417
cf950e6b 8418 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8419 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8420 well either way, and we prefer signed to unsigned.
8421
dbf38e02
LMI
84222011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8423
8424 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8425 closes the connection while we're reading (bug#9182).
8426
d6f0886c 84272011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8428
d6f0886c
JD
8429 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8430 are specified (Bug#9168).
24e0f6b1 8431
2eb1f9e6
PE
84322011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8433
8434 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8435 Found by GCC static checking and --with-wide-int on a 32-bit host.
8436
22381272 84372011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8438
8439 * xdisp.c (compute_display_string_pos): Fix logic of caching
8440 previous display string position. Initialize cached_prev_pos to
8441 -1. Fixes slow-down at the beginning of a buffer.
8442
f25e39b4
EZ
84432011-07-24 Eli Zaretskii <eliz@gnu.org>
8444
8445 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8446 for attrs[LFACE_FONTSET_INDEX].
8447
04c4b52e
PE
84482011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8449
8450 * xml.c (parse_region): Remove unused local
8451 that was recently introduced.
8452
c1734fbd
EZ
84532011-07-23 Eli Zaretskii <eliz@gnu.org>
8454
be18c5a5
EZ
8455 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8456 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8457
c1734fbd
EZ
8458 * xdisp.c (move_it_in_display_line_to): Record the best matching
8459 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8460 exit if none of the characters scanned was an exact match.
8461 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8462 when exact match is impossible due to invisible text, and the
8463 lines are truncated.
8464
a258d627
JD
84652011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8466
8467 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8468 for OSX >= 10.7.
8469
b6d5a689
EZ
84702011-07-22 Eli Zaretskii <eliz@gnu.org>
8471
0f74f785
EZ
8472 Fix a significant slow-down of cursor motion with C-n, C-p,
8473 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8474 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8475 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8476 (next_element_from_buffer): Call compute_stop_pos_backwards to
8477 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8478 base_level_stop.
8479 (reseat): Don't look for prev_stop, as that could mean a very long
8480 run.
8481 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8482 <cached_disp_overlay_modiff>: Cache for last found display string
8483 position.
551918c1 8484 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8485 about the same buffer in the same area of character positions, and
8486 the buffer wasn't changed since the time the display string
8487 position was cached.
551918c1 8488
b2d0c91a
EZ
84892011-07-22 Eli Zaretskii <eliz@gnu.org>
8490
8491 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8492 is an integer, which is important for empty lines. (Bug#9149)
8493
043604ee
CY
84942011-07-22 Chong Yidong <cyd@stupidchicken.com>
8495
8496 * frame.c (Fmodify_frame_parameters): In tty case, update the
8497 default face if necessary (Bug#4238).
8498
da4adb04
CY
84992011-07-21 Chong Yidong <cyd@stupidchicken.com>
8500
8501 * editfns.c (Fstring_to_char): No need to explain what a character
8502 is in the docstring (Bug#6576).
8503
9abd0532
LMI
85042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8505
8506 * xml.c (parse_region): Make sure we always return a tree.
8507
36881d16
HK
85082011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8509
8510 * xml.c (parse_region): If a document contains only comments,
8511 return that, too.
8512
1e98674d
LMI
85132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8514
8515 * xml.c (make_dom): Return comments, too.
8516
590bd467
PE
85172011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8518
8519 Port to OpenBSD.
8520 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8521 and the surrounding thread.
8522 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8523 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8524 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8525 timer goes off.
8526 * s/openbsd.h (BROKEN_SIGIO): Define.
8527 * unexelf.c (unexec) [__OpenBSD__]:
8528 Don't update the .mdebug section of the Alpha COFF symbol table.
8529
f41628b2
LMI
85302011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8531
8532 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8533 (bug#8460).
8534
b59b67c5
PE
85352011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8536
15e3a074
PE
8537 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8538 This fixes some race conditions on the permissions of any newly
8539 created file.
8540
41bed37d
PE
8541 * alloc.c (valid_pointer_p): Use pipe, not open.
8542 This fixes some permissions issues when debugging.
8543
b59b67c5
PE
8544 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8545 If fchown fails to set both uid and gid, try to set just gid,
8546 as that is sometimes allowed. Adjust the file's mode to eliminate
8547 setuid or setgid bits that are inappropriate if fchown fails.
8548
925a6be7
SM
85492011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8550
8551 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8552 to compare Lisp_Objects.
8553 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8554 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8555 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8556
52968808
AS
85572011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8558
0a6a104b
AS
8559 * lread.c (read_integer): Unread even EOF character.
8560 (read1): Likewise. Properly record start position of symbol.
8561
52968808
AS
8562 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8563 symbol character follows.
8564
9e381cdd
PE
85652011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8566
8567 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8568 This works around a problem with the previous change to Fcopy_file.
8569 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8570 and without this change, GCC might complain about discarding
8571 fchown's return value.
8572
b5641435
JB
85732011-07-16 Juanma Barranquero <lekktu@gmail.com>
8574
8575 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8576
a8031457
PE
85772011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8578
8579 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8580
dd889327
LMI
85812011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8582
750c33f7
LMI
8583 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8584 it's used from the C level.
8585
dd889327
LMI
8586 * process.c: Use the same condition for POLL_FOR_INPUT in both
8587 keyboard.c and process.c (bug#1858).
8588
87e86684
LM
85892011-07-09 Lawrence Mitchell <wence@gmx.li>
8590
8591 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8592 (Fgnutls_boot): Use it.
8593
64348f40
AS
85942011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8595
8596 * doc.c (Fsubstitute_command_keys): Revert last change.
8597
1d698799
LMI
85982011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8599
f863868c
LMI
8600 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8601 quotes the next character, and doesn't affect other longer
8602 sequences (bug#8935).
8603
1d698799
LMI
8604 * lread.c (syms_of_lread): Clarify that is isn't only
8605 `eval-buffer' and `eval-defun' that's affected by
8606 `lexical-binding' (bug#8460).
8607
aa4b6df6
EZ
86082011-07-15 Eli Zaretskii <eliz@gnu.org>
8609
8610 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8611 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8612
5d856da6
PE
86132011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8614
ad6042bb
PE
8615 Fix minor problems found by static checking.
8616 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8617 (elsz): Now a signed constant, not a size_t var. We prefer signed
8618 types to unsigned, to avoid integer comparison confusion. Without
8619 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8620 "cannot optimize loop, the loop counter may overflow", a symptom
8621 of the confusion.
f00bbb22 8622 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8623 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8624
6468f31c
LMI
86252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8626
49080b10
LMI
8627 * search.c (Fre_search_backward): Mention `case-fold-search' in
8628 all the re_search_* functions (bug#8138).
8629
6468f31c
LMI
8630 * keyboard.c (Fopen_dribble_file): Document when the file is
8631 closed (bug#8056).
8632
c965adc5
EZ
86332011-07-14 Eli Zaretskii <eliz@gnu.org>
8634
df9733bf
EZ
8635 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8636 bidi_cache_idx.
8637
0bb23927
EZ
8638 Support bidi reordering of display and overlay strings.
8639 * xdisp.c (compute_display_string_pos)
8640 (compute_display_string_end): Accept additional argument STRING.
8641 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8642 (reseat_to_string): Initialize bidi_it->string.s and
8643 bidi_it->string.schars.
8644 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8645 NULL (avoids a crash in bidi_paragraph_init).
8646 Initialize itb.string.lstring.
0bb23927
EZ
8647 (init_iterator): Call bidi_init_it only of a valid
8648 buffer position was specified. Initialize paragraph_embedding to
8649 L2R.
8650 (reseat_to_string): Initialize the bidi iterator.
8651 (display_string): If we need to ignore text properties of
8652 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8653 original value of -1 will not work with bidi.)
8654 (compute_display_string_pos): First arg is now struct
8655 `text_pos *'; all callers changed. Support display properties on
8656 Lisp strings.
8657 (compute_display_string_end): Support display properties on Lisp
8658 strings.
8659 (init_iterator, reseat_1, reseat_to_string): Initialize the
8660 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8661 when iterating on a string not from display properties).
640c8776
SM
8662 (compute_display_string_pos, compute_display_string_end):
8663 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8664 arrow keys.
8665 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8666 base_level_stop; instead, set base_level_stop to BEGV.
8667 Fixes crashes in vertical-motion.
0bb23927
EZ
8668 (next_element_from_buffer): Improve commentary for when
8669 the iterator is before prev_stop.
8670 (init_iterator): Initialize bidi_p from the default value of
8671 bidi-display-reordering, not from buffer-local value. Use the
8672 buffer-local value only if initializing for buffer iteration.
8673 (handle_invisible_prop): Support invisible properties on strings
8674 that are being bidi-reordered.
8675 (set_iterator_to_next): Support bidi reordering of C strings and
8676 Lisp strings.
8677 (next_element_from_string): Support bidi reordering of Lisp
8678 strings.
8679 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8680 (display_string): Support display of R2L glyph rows.
8681 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8682 (init_iterator): Don't initialize it->bidi_p for strings
8683 here.
8684 (reseat_to_string): Initialize it->bidi_p for strings here.
8685 (next_element_from_string, next_element_from_c_string)
8686 (next_element_from_buffer): Add xassert's for correspondence
8687 between IT's object being iterated and it->bidi_it.string
8688 structure.
8689 (face_before_or_after_it_pos): Support bidi iteration.
8690 (next_element_from_c_string): Handle the case of the first string
8691 character that is not the first one in the visual order.
8692 (get_visually_first_element): New function, refactored from common
8693 parts of next_element_from_buffer, next_element_from_string, and
8694 next_element_from_c_string.
8695 (tool_bar_lines_needed, redisplay_tool_bar)
8696 (display_menu_bar): Force left-to-right direction. Add a FIXME
8697 comment for making that be controlled by a user option.
8698 (push_it, pop_it): Save and restore the state of the
8699 bidi iterator. Save and restore the bidi_p flag.
8700 (pop_it): Iterate out of display property for string iteration as
8701 well.
8702 (iterate_out_of_display_property): Support iteration over strings.
8703 (handle_single_display_spec): Set up it->bidi_it for iteration
8704 over a display string, and call bidi_init_it.
8705 (handle_single_display_spec, next_overlay_string)
8706 (get_overlay_strings_1, push_display_prop): Set up the bidi
8707 iterator for displaying display or overlay strings.
8708 (forward_to_next_line_start): Don't use the shortcut if
8709 bidi-iterating.
8710 (back_to_previous_visible_line_start): If handle_display_prop
8711 pushed the iterator stack, restore the internal state of the bidi
8712 iterator by calling bidi_pop_it same number of times.
8713 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8714 and we are bidi-iterating, don't decrement the iterator position;
8715 instead, set the first_elt flag in the bidi iterator, to produce
8716 the same effect.
8717 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8718 (push_display_prop): xassert that we are iterating a buffer.
8719 (push_it, pop_it): Save and restore paragraph_embedding member.
8720 (handle_single_display_spec, next_overlay_string)
8721 (get_overlay_strings_1, reseat_1, reseat_to_string)
8722 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8723 correctly. Don't assume unibyte strings are not bidi-reordered.
8724 (compute_display_string_pos)
8725 (compute_display_string_end): Fix handling the case of C string.
8726 (push_it, pop_it): Save and restore from_disp_prop_p.
8727 (handle_single_display_spec, push_display_prop): Set the
8728 from_disp_prop_p flag.
8729 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8730 (pop_it): Call iterate_out_of_display_property only if we are
8731 popping after iteration over a string that came from a display
8732 property. Fix a typo in popping stretch info. Add an assertion
8733 for verifying that the iterator position is in sync with the bidi
8734 iterator.
8735 (handle_single_display_spec, get_overlay_strings_1)
8736 (push_display_prop): Fix initialization of paragraph direction for
8737 string when that of the parent object is not yet determined.
8738 (reseat_1): Call bidi_init_it to resync the bidi
8739 iterator with IT's position. (Bug#7616)
8740 (find_row_edges): If ROW->start.pos gives position
8741 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8742 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8743 Reset the from_disp_prop_p flag.
8744 (SAVE_IT, RESTORE_IT): New macros.
8745 (pos_visible_p, face_before_or_after_it_pos)
8746 (back_to_previous_visible_line_start)
8747 (move_it_in_display_line_to, move_it_in_display_line)
8748 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8749 (try_scrolling, redisplay_window, display_line): Use them when
8750 saving a temporary copy of the iterator and restoring it back.
8751 (back_to_previous_visible_line_start, reseat_1)
8752 (init_iterator): Empty the bidi cache "stack".
8753 (move_it_in_display_line_to): If iterator ended up at
8754 EOL, but we never saw any buffer positions smaller than
8755 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8756 motion in bidi-reordered lines.
8757 (move_it_in_display_line_to): Record prev_method and prev_pos
8758 immediately before the call to set_iterator_to_next. Fixes cursor
8759 motion in bidi-reordered lines with stretch glyphs and strings
8760 displayed in margins. (Bug#8133) (Bug#8867)
8761 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8762 TO_CHARPOS.
640c8776
SM
8763 (pos_visible_p): Support positions in bidi-reordered lines.
8764 Save and restore bidi cache.
0bb23927
EZ
8765
8766 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8767 (bidi_paragraph_info): Delete unused struct.
8768 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8769 (bidi_cache_start): New variable.
8770 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8771 to zero.
8772 (bidi_cache_fetch_state, bidi_cache_search)
8773 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8774 (bidi_cache_find, bidi_peek_at_next_level)
8775 (bidi_level_of_next_char, bidi_find_other_level_edge)
8776 (bidi_move_to_visually_next): Compare cache index with
8777 bidi_cache_start rather than with zero.
8778 (bidi_fetch_char): Accept new argument STRING; all callers
8779 changed. Support iteration over a string. Support strings with
8780 display properties. Support unibyte strings. Fix the type of
8781 `len' according to what STRING_CHAR_AND_LENGTH expects.
8782 (bidi_paragraph_init, bidi_resolve_explicit_1)
8783 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8784 (bidi_level_of_next_char, bidi_move_to_visually_next):
8785 Support iteration over a string.
0bb23927
EZ
8786 (bidi_set_sor_type, bidi_resolve_explicit_1)
8787 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8788 can now be zero (for strings); special values 0 and -1 were
8789 changed to -1 and -2, respectively.
8790 (bidi_char_at_pos): New function.
8791 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8792 Call it instead of FETCH_MULTIBYTE_CHAR.
8793 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8794 initialized to valid values.
8795 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8796 values.
8797 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8798 the test for valid cached positions. Fix the logic for looking up
8799 the sentinel state in the cache. GCPRO the Lisp string we are
8800 iterating.
8801 (bidi_push_it, bidi_pop_it): New functions.
8802 (bidi_initialize): Initialize the bidi cache start stack pointer.
8803 (bidi_cache_ensure_space): New function, refactored from part of
8804 bidi_cache_iterator_state. Don't assume the required size is just
8805 one BIDI_CACHE_CHUNK away.
8806 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8807 (bidi_count_bytes, bidi_char_at_pos): New functions.
8808 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8809 always valid if bidi_cache_idx is valid.
8810 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8811 is valid if it's going to be used.
8812 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8813 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8814 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8815 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8816 (bidi_find_other_level_edge, bidi_cache_start_stack):
8817 All variables related to cache indices are now EMACS_INT.
c965adc5 8818
0bb23927
EZ
8819 * dispextern.h (struct bidi_string_data): New structure.
8820 (struct bidi_it): New member `string'. Make flag members be 1-bit
8821 fields, and put them last in the struct.
640c8776
SM
8822 (compute_display_string_pos, compute_display_string_end):
8823 Update prototypes.
0bb23927
EZ
8824 (bidi_push_it, bidi_pop_it): Add prototypes.
8825 (struct iterator_stack_entry): New members bidi_p,
8826 paragraph_embedding, and from_disp_prop_p.
8827 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8828 (bidi_shelve_cache, bidi_unshelve_cache):
8829 Declare prototypes.
0bb23927
EZ
8830
8831 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8832 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8833 and vector-like objects.
8834
8835 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8836 cache around display iteration.
8837
8838 * window.c (Fwindow_end, window_scroll_pixel_based)
8839 (displayed_window_lines, Frecenter): Save and restore the bidi
8840 cache around display iteration.
8841
3bbd2265
LMI
88422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8843
8844 * editfns.c (Fdelete_region): Clarify the use of the named
8845 parameters (bug#6788).
8846
adc47434
MR
88472011-07-14 Martin Rudalics <rudalics@gmx.at>
8848
8849 * indent.c (Fvertical_motion): Set and restore w->pointm when
8850 saving and restoring the window's buffer (Bug#9006).
8851
837c31f8
LMI
88522011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8853
8854 * editfns.c (Fstring_to_char): Clarify just what is returned
8855 (bug#6576). Text by Eli Zaretskii.
8856
ac389d0c
JB
88572011-07-13 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8860
0be0ce47
EZ
88612011-07-13 Eli Zaretskii <eliz@gnu.org>
8862
8863 * buffer.c (mmap_find): Fix a typo.
8864
cd18e7e3
JB
88652011-07-13 Johan Bockgård <bojohan@gnu.org>
8866
8867 Fix execution of x selection hooks.
8868 * xselect.c (Qx_lost_selection_functions)
8869 (Qx_sent_selection_functions): New vars.
8870 (syms_of_xselect): DEFSYM them.
8871 (x_handle_selection_request): Pass Qx_sent_selection_functions
8872 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8873 (x_handle_selection_clear,x_clear_frame_selections):
8874 Pass Qx_lost_selection_functions rather than
8875 Vx_lost_selection_functions to Frun_hook_with_args.
8876
47ea7f44
PE
88772011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8878
ac389d0c 8879 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8880 The old code sometimes used this field without initializing it.
8881
47ea7f44
PE
8882 * alloc.c (gc_sweep): Don't read past end of array.
8883 In theory, the old code could also have corrupted Emacs internals,
8884 though it'd be very unlikely.
8885
bc985c87
AS
88862011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8887
8888 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8889 argument. (Bug#4026)
bc985c87 8890
0cf34688
LMI
88912011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8892
b3dadd76
LMI
8893 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8894 key" (bug#4257).
8895
0cf34688
LMI
8896 * window.c (Fset_window_start): Doc fix (bug#4199).
8897 (Fset_window_hscroll): Ditto.
8898
270768cd
PE
88992011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8900
077e3dda 8901 Fix minor new problems caught by GCC 4.6.1.
270768cd 8902 * term.c (init_tty): Remove unused local.
490011a6 8903 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8904 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8905 not used otherwise.
270768cd 8906
b1f58454
CY
89072011-07-12 Chong Yidong <cyd@stupidchicken.com>
8908
8909 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8910
22b9578d
LMI
89112011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8912
6e70ab07
LMI
8913 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8914 are the mini-buffer and the echo area (bug#3320).
8915
22b9578d
LMI
8916 * term.c (init_tty): Remove support for supdup, c10 and perq
8917 terminals, which are no longer supported (bug#1482).
8918
8974cc9f
JB
89192011-07-10 Johan Bockgård <bojohan@gnu.org>
8920
8921 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8922
a560d974
JD
89232011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8924
8925 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8926 for non-popups (Bug#3642).
8927
1dae0f0a
AS
89282011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8929
268c2c36 8930 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8931 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8932 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8933 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8934 * data.c (fmod): Likewise.
8935 * dispnew.c (swap_glyphs_in_rows): Likewise.
8936 * emacs.c (memory_warning_signal): Likewise.
8937 * floatfns.c (float_error): Likewise.
8938 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8939 (otf_open, font_otf_capability, generate_otf_features)
8940 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8941 Likewise.
8942 * image.c (pbm_read_file): Likewise.
8943 * indent.c (string_display_width): Likewise.
8944 * intervals.c (check_for_interval, search_for_interval)
8945 (inc_interval_count, count_intervals, root_interval)
8946 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8947 * lread.c (defalias): Likewise.
268c2c36 8948 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8949 * regex.c (set_image_of_range_1, set_image_of_range)
8950 (regex_grow_registers): Likewise.
8951 * sysdep.c (strerror): Likewise.
8952 * termcap.c (valid_filename_p, tprint, main): Likewise.
8953 * tparam.c (main): Likewise.
8954 * unexhp9k800.c (run_time_remap, save_data_space)
8955 (update_file_ptrs, read_header, write_header, calculate_checksum)
8956 (copy_file, copy_rest, display_header): Likewise.
8957 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8958 Likewise.
8959 * xdisp.c (check_it): Likewise.
8960 * xfaces.c (register_color, unregister_color, unregister_colors):
8961 Likewise.
8962 * xfns.c (print_fontset_result): Likewise.
8963 * xrdb.c (member, fatal, main): Likewise.
8964
99033785
PE
89652011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8966
8967 Fix minor problems found by static checking (Bug#9031).
8968 * chartab.c (char_table_set_range, map_sub_char_table):
8969 Remove unused locals.
8970 (uniprop_table): Now static.
8971 * composite.c (_work_char): Remove unused static var.
8972
9cb2ac56
JB
89732011-07-09 Juanma Barranquero <lekktu@gmail.com>
8974
8975 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8976
f25661f0
JD
89772011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8978
8979 * gtkutil.c (qttip_cb): Remove code without function.
8980
8278c4fe
EZ
89812011-07-09 Eli Zaretskii <eliz@gnu.org>
8982
8983 * w32.c (pthread_sigmask): New stub.
8984
1692ae2d 89852011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8986
8a6ebd58 8987 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8988 sigprocmask is portable only for single-threaded applications, and
8989 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8990 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8991 (LIBES): Use it.
8992 * callproc.c (Fcall_process):
8993 * process.c (create_process):
8994 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8995 Use pthread_sigmask, not sigprocmask.
123403e4 8996
1b854618
JD
89972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8998
8999 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9000 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9001 wrong (Bug#8591).
9002
3fe4b549
JD
90032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9004
0ce7e563
JD
9005 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9006 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9007 (xg_hide_tooltip): Fix comment.
9008
3fe4b549
JD
9009 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9010 in registerServicesMenuSendTypes.
9011 (validRequestorForSendType): Don't check ns_return_types.
9012
9013 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9014 ns_return_type.
9015
5df75e47
JR
90162011-07-08 Jason Rumney <jasonr@gnu.org>
9017
22610910
JR
9018 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9019 SH_SHOW for hidden windows (Bug#5482).
9020
5df75e47
JR
9021 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9022 frame struct members of non-existent frames (Bug#6284).
9023
699c10bd
JD
90242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9025
4393663b
JD
9026 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9027 variable firstTime not needed on OSX >= 10.6.
9028 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9029 >= 10.5. Use setKnobProportion, setDoubleValue.
9030
9031 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9032 (MAC_OS_X_VERSION_10_5): Define if not defined.
9033 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9034 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9035 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9036
9037 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9038 cString and lossyCString on OSX >= 10.4.
4393663b 9039
58179cce 9040 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9041 sizeToFit on OSX >= 10.2.
9042
9043 * nsimage.m (allocInitFromFile): Don't use deprecated method
9044 bestRepresentationForDevice on OSX >= 10.6.
9045
9046 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9047 to avoid warning.
9048
9049 * emacs.c: Declare unexec_init_emacs_zone.
9050
a63e0781
JD
9051 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9052
699c10bd
JD
9053 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9054
9055 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9056 on svcsMenu (Bug#8842).
9057
9058 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9059 ns_return_types.
9060 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9061
9062 * nsterm.m (QUTF8_STRING): Declare.
9063 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9064 (validRequestorForSendType): Return type is (id).
9065 Change indexOfObjectIdenticalTo to indexOfObject.
9066 Check if we have local selection before returning self (Bug#8842).
9067 (writeSelectionToPasteboard): Put local selection into paste board
9068 if we have a local selection (Bug#8842).
9069 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9070
9071 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9072 (ns_get_local_selection): Declare.
9073
54e10184
LMI
90742011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9075
9888ff71
LMI
9076 * keymap.c (describe_map_tree): Don't insert a double newline at
9077 the end of the buffer (bug#1169) and return whether we inserted
9078 something.
9079
54e10184
LMI
9080 * callint.c (Fcall_interactively): Change "reading args" to
9081 "providing args" to try to clarify what it does (bug#1010).
9082
15fa4783
KH
90832011-07-07 Kenichi Handa <handa@m17n.org>
9084
9085 * composite.c (composition_compute_stop_pos): Ignore a static
9086 composition starting before CHARPOS (Bug#8915).
9087
9088 * xdisp.c (handle_composition_prop): Likewise.
9089
a8815b00
EZ
90902011-07-07 Eli Zaretskii <eliz@gnu.org>
9091
9092 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9093 (Bug#9015)
9094
ef7b981d 90952011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9096
9097 * character.h (unicode_category_t): New enum type.
9098
9099 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9100 (Qchar_code_property_table): New variable.
9101 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9102 (UNIPROP_COMPRESSED_FORM_P): New macros.
9103 (char_table_ascii): Uncompress the compressed values.
9104 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9105 Uncompress the compressed values.
ac389d0c 9106 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9107 (char_table_ref_and_range): Uncompress the compressed values.
9108 (sub_char_table_set): New arg is_uniprop. Callers changed.
9109 Uncompress the compressed values.
9110 (sub_char_table_set_range): Args changed. Callers changed.
9111 (char_table_set_range): Adjuted for the above change.
9112 (map_sub_char_table): Delete args default_val and parent. Add arg
9113 top. Give decoded values to a Lisp function.
640c8776 9114 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9115 values to a Lisp function. Gcpro more variables.
9116 (uniprop_table_uncompress)
9117 (uniprop_decode_value_run_length): New functions.
9118 (uniprop_decoder, uniprop_decoder_count): New variables.
9119 (uniprop_get_decoder, uniprop_encode_value_character)
9120 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9121 New functions.
9122 (uniprop_encoder, uniprop_encoder_count): New variables.
9123 (uniprop_get_encoder, uniprop_table)
9124 (Funicode_property_table_internal, Fget_unicode_property_internal)
9125 (Fput_unicode_property_internal): New functions.
9126 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9127 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9128 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9129 char-code-property-alist.
9130
640c8776 9131 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9132 Vunicode_category_table.
9133
640c8776 9134 * font.c (font_range): Adjust for the change of
c805dec0
KH
9135 Vunicode_category_table.
9136
76b397fb
DN
91372011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9138
9139 * m/iris4d.h: Remove file, move contents ...
9140 * s/irix6-5.h: ... here.
9141
22b4128e
PE
91422011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9143
9144 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9145 * alloc.c (mark_buffer):
9146 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9147 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9148 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9149 This isn't true in general, and it's particularly not true
9150 if Emacs is configured with --with-wide-int.
9151 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9152 New macros, used in the buffer.c change.
9153
869795d6
JD
91542011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9155
9156 * xsettings.c: Use both GConf and GSettings if both are available.
9157 (store_config_changed_event): Add comment.
9158 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9159 (store_tool_bar_style_changed): New functions.
5e617bc2 9160 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9161 (struct xsettings): Move font inside HAVE_XFT.
9162 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9163 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9164 Move inside HAVE_XFT.
640c8776 9165 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9166 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9167 also.
9168 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9169 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9170 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9171 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9172 (parse_settings): Move check for font inside HAVE_XFT.
9173 (read_settings, apply_xft_settings): Add comment.
9174 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9175 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9176 call store_font_name_changed.
9177 (xft_settings_event): Add comment.
9178 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9179 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9180 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9181 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9182 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9183 (xsettings_get_system_font, xsettings_get_system_normal_font):
9184 Add comment.
869795d6 9185
d8ed26bd
PE
91862011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9187
9188 Random fixes. E.g., (random) never returned negative values.
9189 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9190 subseconds part to the entropy, as that's a bit more random.
9191 Prefer signed to unsigned, since the signedness doesn't matter and
9192 in general we prefer signed. When given a limit, use a
9193 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9194 latter isn't right if USE_2_TAGS_FOR_INTS.
9195 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9196 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9197
cabf1cac
SM
91982011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9199
9200 * textprop.c (text_property_stickiness):
9201 Obey Vtext_property_default_nonsticky.
9202 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9203 * w32fns.c (syms_of_w32fns):
9204 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9205
6e9b2be9
PE
92062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9207
9208 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9209 This is more efficient than Ffile_directory_p and avoids a minor race.
9210
90186c68
LMI
92112011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9212
7c301272
LMI
9213 * buffer.c (Foverlay_put): Say what the return value is
9214 (bug#7835).
9215
c4f2d8d4
LMI
9216 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9217 is a directory before asking whether to use the file name
9218 (bug#7564).
ad637907
LMI
9219 (barf_or_query_if_file_exists): Make the "File is a directory"
9220 error be more correct.
c4f2d8d4 9221
90186c68
LMI
9222 * fns.c (Frequire): Remove the mention of the .gz files, since
9223 that's installation-specific, but keep the mention of
9224 `get-load-suffixes'.
9225
da64016e
PE
92262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9227
9228 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9229 Report string overflow if the output is too long.
9230
7d47b580
JB
92312011-07-04 Juanma Barranquero <lekktu@gmail.com>
9232
a555cb87
JB
9233 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9234 (syms_of_gnutls): Remove duplicate DEFSYM for
9235 Qgnutls_bootprop_verify_hostname_error, an error for
9236 Qgnutls_bootprop_verify_error (which is no longer used).
9237
7d47b580
JB
9238 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9239 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9240 Also (re)move comments that are misplaced or no longer relevant.
9241
1e49bfab
LMI
92422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9243
9244 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9245
1485f4c0
CY
92462011-07-03 Chong Yidong <cyd@stupidchicken.com>
9247
9248 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9249 and background color parameters if they have been changed.
9250
a9ab721e
LMI
92512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9252
9253 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9254
cf7cff57
PE
92552011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9256
2e13213d
PE
9257 * xsettings.c (SYSTEM_FONT): Define only when used.
9258 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9259
cf7cff57
PE
9260 * keymap.c (access_keymap_1): Now static.
9261
7a8e04f7
CY
92622011-07-02 Chong Yidong <cyd@stupidchicken.com>
9263
9264 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9265 leave any prefix arg for the up event (Bug#1586).
9266
61352f62
LMI
92672011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9268
69bb1ef7
LMI
9269 * lread.c (syms_of_lread): Mention single symbols defined by
9270 `defvar' or `defconst' (bug#7154).
9271
61352f62 9272 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9273 (Frequire): Mention get-load-suffixes.
61352f62 9274
28545e04
MR
92752011-07-02 Martin Rudalics <rudalics@gmx.at>
9276
9277 * window.h (window): Remove clone_number slot.
9278 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9279 Remove.
9280 (make_parent_window, make_window, saved_window)
9281 (Fset_window_configuration, save_window_save): Don't deal with
9282 clone numbers.
9283 * buffer.c (Qclone_number): Remove declaration.
9284 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9285
3349e122
SM
92862011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9287
9288 Add multiple inheritance to keymaps.
9289 * keymap.c (Fmake_composed_keymap): New function.
9290 (Fset_keymap_parent): Simplify.
9291 (fix_submap_inheritance): Remove.
9292 (access_keymap_1): New function extracted from access_keymap to handle
9293 embedded parents and handle lists of maps.
9294 (access_keymap): Use it.
9295 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9296 (Fcopy_keymap): Handle embedded parents.
9297 (Fcommand_remapping, define_as_prefix): Simplify.
9298 (Fkey_binding): Simplify.
9299 (syms_of_keymap): Move minibuffer-local-completion-map,
9300 minibuffer-local-filename-completion-map,
9301 minibuffer-local-must-match-map, and
9302 minibuffer-local-filename-must-match-map to Elisp.
9303 (syms_of_keymap): Defsubr make-composed-keymap.
9304 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9305 (parse_menu_item): Trivial simplification.
9306
3279eb87
GM
93072011-07-01 Glenn Morris <rgm@gnu.org>
9308
9309 * Makefile.in (SETTINGS_LIBS): Fix typo.
9310
4550efdf
KI
93112011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9312
9313 * coding.c (Fencode_coding_string): Record the last coding system
9314 used, as the function doc string says (bug#8738).
9315
0949d2b6
JD
93162011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9317
9318 * xsettings.c (store_monospaced_changed): Take new font as arg and
9319 check for change against current_mono_font.
9320 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9321 (emacs_settings_constructor, emacs_settings_get_property)
9322 (emacs_settings_set_property, emacs_settings_class_init)
9323 (emacs_settings_init, gsettings_obj): Remove.
9324 (something_changedCB): New function for HAVE_GSETTINGS.
9325 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9326 with value as argument.
9327 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9328 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9329 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9330 "changed".
9331
9332 * xgselect.c: Add defined (HAVE_GSETTINGS).
9333 (xgselect_initialize): Ditto.
9334
9335 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9336 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9337 xg_select.
9338
bbc6b304
PE
93392011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9340
9341 * eval.c (struct backtrace): Simplify and port the data structure.
9342 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9343 signed bit field, as this assumption is not portable and it makes
9344 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9345 "char debug_on_exit : 1" as this is not portable either; instead,
9346 use the portable "unsigned int debug_on_exit : 1". Remove unused
9347 member evalargs. Remove obsolete comments about cc bombing out.
9348
9851bfc5
JD
93492011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9350
51bb811f 9351 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9352 Let HAVE_GSETTINGS override HAVE_GCONF.
9353 (store_monospaced_changed): New function.
9354 (EMACS_SETTINGS): A new type derived from GObject to handle
9355 GSettings notifications.
9356 (emacs_settings_constructor, emacs_settings_get_property)
9357 (emacs_settings_set_property, emacs_settings_class_init):
9358 New functions.
9359 (gsettings_client, gsettings_obj): New variables.
9360 (GSETTINGS_SCHEMA): New define.
9361 (something_changedCB): Call store_monospaced_changed.
9362 (init_gsettings): New function.
9363 (xsettings_initialize): Call init_gsettings.
9364 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9365 to NULL.
9366
640c8776 9367 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9368 GCONF_CFLAGS/LIBS.
9369
5386012d
MR
93702011-06-29 Martin Rudalics <rudalics@gmx.at>
9371
9372 * window.c (resize_root_window, grow_mini_window)
9373 (shrink_mini_window): Rename Qresize_root_window to
9374 Qwindow_resize_root_window and Qresize_root_window_vertically to
9375 Qwindow_resize_root_window_vertically.
9376
f13e0b08
PE
93772011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9378
9379 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9380
94515237
JB
93812011-06-27 Juanma Barranquero <lekktu@gmail.com>
9382
9383 * makefile.w32-in: Redesign dependencies so they reflect more
9384 clearly which files are directly included by each source file,
9385 and not through other includes.
9386
e43b6e43
MR
93872011-06-27 Martin Rudalics <rudalics@gmx.at>
9388
9389 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9390 (sort_overlays, overlay_strings): When an overlay's clone number
9391 matches the window's clone number process the overlay even if
9392 the overlay's window property doesn't match the current window.
9393
d68443dc
MR
9394 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9395 (Fwindow_hchild): Rename to Fwindow_left_child.
9396 (Fwindow_next): Rename to Fwindow_next_sibling.
9397 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9398 (resize_window_check): Rename to window_resize_check.
9399 (resize_window_apply): Rename to window_resize_apply.
9400 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9401 (Fdelete_other_windows_internal, resize_frame_windows)
9402 (Fsplit_window_internal, Fdelete_window_internal)
9403 (grow_mini_window, shrink_mini_window)
9404 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9405
c7e73be5
JD
94062011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9407
9408 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9409 (emacs_fixed_set_min_size): Remove.
9410 (emacs_fixed_new): Take frame as argument.
9411
9412 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9413 (_EmacsFixedPrivate): Remove minwidth/height.
9414 Add struct frame *f.
9415 (emacs_fixed_init): Initialize priv->f.
9416 (get_parent_class, emacs_fixed_set_min_size): Remove.
9417 (emacs_fixed_new): Set priv->f to argument.
9418 (emacs_fixed_get_preferred_width)
9419 (emacs_fixed_get_preferred_height): Use min_width/height from
9420 frames size_hint to set minimum and natural (Bug#8919).
9421 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9422 and use min_width/height from frames size_hint to set
9423 min_width/height (Bug#8919).
9424
9425 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9426 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9427 Fix indentation.
c7e73be5 9428
cf99dcf8
EZ
94292011-06-26 Eli Zaretskii <eliz@gnu.org>
9430
9431 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9432 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9433 called at ZV.
9434
029529ac
CY
94352011-06-26 Chong Yidong <cyd@stupidchicken.com>
9436
9437 * process.c (wait_reading_process_output): Bypass select if
9438 waiting for a cell while ignoring keyboard input, and input is
9439 pending. Suggested by Jan Djärv (Bug#8869).
9440
7a7ef429
PE
94412011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9442
9443 Use gnulib's dup2 module instead of rolling our own.
9444 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9445
11fdef7d 94462011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9447
9448 * dispnew.c (scrolling_window): Before scrolling, turn off a
9449 mouse-highlight in the window being scrolled.
9450
cd3520a4
JB
94512011-06-24 Juanma Barranquero <lekktu@gmail.com>
9452
9453 Move DEFSYM to lisp.h and use everywhere.
9454
9455 * character.h (DEFSYM): Move declaration...
9456 * lisp.h (DEFSYM): ...here.
9457
9458 * gnutls.c:
9459 * minibuf.c:
9460 * w32menu.c:
9461 * w32proc.c:
9462 * w32select.c: Don't include character.h.
9463
9464 * alloc.c (syms_of_alloc):
9465 * buffer.c (syms_of_buffer):
9466 * bytecode.c (syms_of_bytecode):
9467 * callint.c (syms_of_callint):
9468 * casefiddle.c (syms_of_casefiddle):
9469 * casetab.c (init_casetab_once):
9470 * category.c (init_category_once, syms_of_category):
9471 * ccl.c (syms_of_ccl):
9472 * cmds.c (syms_of_cmds):
9473 * composite.c (syms_of_composite):
9474 * dbusbind.c (syms_of_dbusbind):
9475 * dired.c (syms_of_dired):
9476 * dispnew.c (syms_of_display):
9477 * doc.c (syms_of_doc):
9478 * editfns.c (syms_of_editfns):
9479 * emacs.c (syms_of_emacs):
9480 * eval.c (syms_of_eval):
9481 * fileio.c (syms_of_fileio):
9482 * fns.c (syms_of_fns):
9483 * frame.c (syms_of_frame):
9484 * fringe.c (syms_of_fringe):
9485 * insdel.c (syms_of_insdel):
9486 * keymap.c (syms_of_keymap):
9487 * lread.c (init_obarray, syms_of_lread):
9488 * macros.c (syms_of_macros):
9489 * msdos.c (syms_of_msdos):
9490 * print.c (syms_of_print):
9491 * process.c (syms_of_process):
9492 * search.c (syms_of_search):
9493 * sound.c (syms_of_sound):
9494 * syntax.c (init_syntax_once, syms_of_syntax):
9495 * terminal.c (syms_of_terminal):
9496 * textprop.c (syms_of_textprop):
9497 * undo.c (syms_of_undo):
9498 * w32.c (globals_of_w32):
9499 * window.c (syms_of_window):
9500 * xdisp.c (syms_of_xdisp):
9501 * xfaces.c (syms_of_xfaces):
9502 * xfns.c (syms_of_xfns):
9503 * xmenu.c (syms_of_xmenu):
9504 * xsettings.c (syms_of_xsettings):
9505 * xterm.c (syms_of_xterm): Use DEFSYM.
9506
4228cf16
TZ
95072011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9508
cd3520a4 9509 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9510
7fcccf1e
PE
95112011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9512
7efb4e0e
PE
9513 Integer and buffer overflow fixes (Bug#8873).
9514
ff5844ad
PE
9515 * print.c (printchar, strout): Check for string overflow.
9516 (PRINTPREPARE, printchar, strout):
9517 Don't set size unless allocation succeeds.
9518
90532f02
PE
9519 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9520 for sizes. Check for string overflow more accurately.
9521 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9522
6d84508d
PE
9523 * macros.c: Integer and buffer overflow fixes.
9524 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9525 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9526 Use ptrdiff_t, not int, for sizes.
9527 Don't increment bufsize until after realloc succeeds.
9528 Check for size-calculation overflow.
9529 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9530
437b2cb4
PE
9531 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9532
8b9ac8b4
PE
9533 * lread.c: Integer overflow fixes.
9534 (read_integer): Radix is now EMACS_INT, not int,
9535 to improve quality of diagnostics for out-of-range radices.
9536 Calculate buffer size correctly for out-of-range radices.
9537 (read1): Check for integer overflow in radices, and in
9538 read-circle numbers.
82cb60d3
PE
9539 (read_escape): Avoid int overflow.
9540 (Fload, openp, read_buffer_size, read1)
9541 (substitute_object_recurse, read_vector, read_list, map_obarray):
9542 Use ptrdiff_t, not int, for sizes.
9543 (read1): Use EMACS_INT, not int, for sizes.
20270765 9544 Check for size overflow.
8b9ac8b4 9545
7fcccf1e
PE
9546 * image.c (cache_image): Check for size arithmetic overflow.
9547
bfbbd7e7
PE
9548 * lread.c: Integer overflow issues.
9549 (saved_doc_string_size, saved_doc_string_length)
9550 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9551 Now ptrdiff_t, not int.
9552 (read1): Don't assume doc string length fits in int. Check for
9553 out-of-range doc string lengths.
9554 (read_list): Don't assume file position fits in int.
39019e54 9555 (read_escape): Check for hex character overflow.
bfbbd7e7 9556
4e323265
LL
95572011-06-22 Leo Liu <sdl.web@gmail.com>
9558
9559 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9560 Move to minibuffer.el.
9561
85fece3e
PE
95622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9563
20b84ce9 9564 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9565 The following patches are for when GLYPH_DEBUG && !XASSERT.
9566 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9567 * dispnew.c (flush_stdout):
9568 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9569 Mark as externally visible.
9570 * dispnew.c (check_window_matrix_pointers): Now static.
9571 * dispnew.c (window_to_frame_vpos):
9572 * xfns.c (unwind_create_frame):
9573 * xterm.c (x_check_font): Remove unused local.
9574 * scroll.c (CHECK_BOUNDS):
9575 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9576 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9577 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9578 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9579 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9580 Now static.
9581 (debug_method_add): Use va_list and vsprintf rather than relying
9582 on undefined behavior with wrong number of arguments.
9583 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9584 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9585 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9586 since we're not interested in debugging glyphs with old libraries.
9587 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9588 GCC 4.6.0's static checking.
9589
0766b489
PE
95902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9591
31fd4b32
PE
9592 Integer overflow and signedness fixes (Bug#8873).
9593 A few related buffer overrun fixes, too.
9594
b79e8648
PE
9595 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9596
0766b489
PE
9597 * dispextern.h (struct face.stipple):
9598 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9599 (x_bitmap_mask, x_allocate_bitmap_record)
9600 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9601 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9602 (x_create_bitmap_from_xpm_data):
9603 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9604 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9605 (.bitmaps_last):
9606 * xfaces.c (load_pixmap):
9607 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9608 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9609 (.bitmaps_last, struct x_output.icon_bitmap):
9610 Use ptrdiff_t, not int, for bitmap indexes.
9611 (x_allocate_bitmap_record): Check for size overflow.
9612 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9613
b081724f
PE
9614 Use ptrdiff_t, not int, for overlay counts.
9615 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9616 * editfns.c (overlays_around, get_pos_property):
9617 * textprop.c (get_char_property_and_overlay):
9618 * xdisp.c (next_overlay_change, note_mouse_highlight):
9619 * xfaces.c (face_at_buffer_position):
21514da7
PE
9620 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9621 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9622 (Fnext_overlay_change, Fprevious_overlay_change)
9623 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9624 Use ptrdiff_t, not int, for sizes.
21514da7 9625 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9626
3de73e5e
PE
9627 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9628
2606c57b
PE
9629 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9630 (x_session_initialize): Do not assume string length fits in int.
9631
aaafe47a
PE
9632 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9633 This is unlikely, but can occur if DPI is outlandish.
9634
2674ddc8 9635 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9636 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9637
28154962
PE
9638 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9639 * xrdb.c (magic_file_p, search_magic_path):
9640 Omit last arg SUFFIX; it was always 0. All callers changed.
9641 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9642
7de51af5
PE
9643 * xfont.c (xfont_match): Avoid need for strlen.
9644
25ed6cc3
PE
9645 * xfns.c: Don't assume strlen fits in int.
9646 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9647
4eab31dd
PE
9648 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9649 not unsigned long, as we prefer signed integers. All callers changed.
9650 Detect integer overflow in repeat count.
9651 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9652 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9653
171e2a58
PE
9654 * termcap.c: Don't assume sizes fit in int and never overflow.
9655 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9656 (gobble_line): Check for size-calculation overflow.
9657
ad39faca 9658 * minibuf.c (Fread_buffer):
6e5bb2dc 9659 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9660 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9661 Don't assume string length fits in int.
9662
52c61c22 9663 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9664 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9665
b5b8c9e5
PE
9666 * font.c: Don't assume string length fits in int.
9667 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9668 Use ptrdiff_t, not int.
ccd6111c
PE
9669 (font_intern_prop): Don't assume string length fits in int.
9670 Don't assume integer property fits in fixnum.
9671 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9672
882f0d81 9673 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9674 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9675 Reformulate so as not to need the command string.
9676 Invoke gzip -cd rather than gunzip, as it's more portable.
9677 (lock_info_type, lock_file_1, lock_file):
9678 Don't assume pid_t and time_t fit in unsigned long.
9679 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9680 (current_lock_owner): Prefer signed type for sizes.
9681 Use memcpy, not strncpy, where memcpy is what is really wanted.
9682 Don't assume (via atoi) that time_t and pid_t fit in int.
9683 Check for time_t and/or pid_t out of range, e.g., via a network share.
9684 Don't alloca where an auto var works fine.
9685
93f4cf88
PE
9686 * fileio.c: Fix some integer overflow issues.
9687 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9688 Don't assume string length fits in int.
9689 (directory_file_name): Don't assume string length fits in long.
9690 (make_temp_name): Don't assume pid fits in int, or that its print
9691 length is less than 20.
9692
f3e92b69
PE
9693 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9694
1bfdaf10
PE
9695 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9696
35016e9a
PE
9697 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9698
3d1e65a1
PE
9699 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9700 We prefer signed integers, even for size calculations.
9701
0b963a93
PE
9702 * emacs.c: Don't assume string length fits in 'int'.
9703 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9704 (main): Don't invoke strlen when not needed.
9705
573f4b54
PE
9706 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9707 (XD_DEBUG_MESSAGE): Don't waste a byte.
9708
989f33ba
PE
9709 * callproc.c (getenv_internal_1, getenv_internal)
9710 (Fgetenv_internal):
965d34eb
PE
9711 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9712
e4d29b33
PE
9713 * lread.c (invalid_syntax): Omit length argument.
9714 All uses changed. This doesn't fix a bug, but it simplifies the
9715 code away from its former Hollerith-constant appearance, and it's
9716 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9717 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9718
eb49b136
PE
9719 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9720 This didn't break anything, but it didn't help either.
9721 It's confusing to put a bogus integer in a place where the actual
9722 value does not matter.
9f62aeb1 9723 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9724 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9725
15375a22
PE
9726 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9727 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9728 implementation.
b61cc01c
PE
9729 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9730 We prefer signed types, and the value cannot exceed the EMACS_INT
9731 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9732 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9733 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9734 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9735
53b2623d
PE
9736 * indent.c (sane_tab_width): New function.
9737 (current_column, scan_for_column, Findent_to, position_indentation)
9738 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9739 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9740
51cab52b 9741 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9742
f2ed8a70
PE
9743 * lisp.h (lint_assume): New macro.
9744 * composite.c (composition_gstring_put_cache):
9745 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9746
abe80cc6
PE
9747 * editfns.c, insdel.c:
9748 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9749
b02c740e
PE
9750 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9751
ebc96716
PE
9752 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9753
b4e50fa0 9754 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9755 Use much-faster test for byte-length change.
311d5d7c 9756 Don't assume string byte-length fits in 'int'.
a4cf38e4 9757 Check that character arg fits in 'int'.
85461888 9758 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9759
c0c1ee9f
PE
9760 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9761
a498d7f4
PE
9762 * fns.c (concat): Catch string overflow earlier.
9763 Do not rely on integer wraparound.
9764
51cab52b
PE
9765 * dispextern.h (struct it.overlay_strings_charpos)
9766 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9767 * xdisp.c (forward_to_next_line_start)
9768 (back_to_previous_visible_line_start)
9769 (reseat_at_next_visible_line_start, next_element_from_buffer):
9770 Don't arbitrarily truncate the value of 'selective' to int.
9771
76031fad
PE
9772 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9773
5eb55db9
PE
9774 * composite.c: Don't truncate sizes to 'int'.
9775 (composition_gstring_p, composition_reseat_it)
9776 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9777 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9778 not EMACS_UINT, for indexes.
5eb55db9 9779
0703a717
PE
9780 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9781
d6202519
PE
9782 * buffer.c: Include <verify.h>.
9783 (struct sortvec.priority, struct sortstr.priority):
8961a454 9784 Now EMACS_INT, not int.
c20998a7 9785 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9786 (struct sortstr.size, record_overlay_string)
9787 (struct sortstrlist.size, struct sortlist.used):
9788 Don't truncate size to int.
9789 (record_overlay_string): Check for size-calculation overflow.
d6202519 9790 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9791
d5a19415
JM
97922011-06-22 Jim Meyering <meyering@redhat.com>
9793
029529ac 9794 Don't leak an XBM-image-sized buffer
d5a19415
JM
9795 * image.c (xbm_load): Free the image buffer after using it.
9796
a9041e6c
PE
97972011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9798
9799 Port to Sun C.
9800 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9801 that Sun C diagnosed.
9802 * fns.c (secure_hash): Fix pointer signedness issue.
9803 * intervals.c (static_offset_intervals): New function.
9804 (offset_intervals): Use it.
9805
7f3f739f
LL
98062011-06-21 Leo Liu <sdl.web@gmail.com>
9807
9808 * deps.mk (fns.o):
9809 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9810 sha512.h.
9811
9812 * fns.c (secure_hash): Rename from crypto_hash_function and change
9813 the first arg to accept symbols.
5b66d427 9814 (Fsecure_hash): New primitive.
7f3f739f
LL
9815 (syms_of_fns): New symbols.
9816
76147d94
DD
98172011-06-20 Deniz Dogan <deniz@dogan.se>
9818
9819 * process.c (Fset_process_buffer): Clarify return value in
9820 docstring.
9821
7d7d0045
CY
98222011-06-18 Chong Yidong <cyd@stupidchicken.com>
9823
9824 * dispnew.c (add_window_display_history): Use BVAR.
9825
9826 * xdisp.c (debug_method_add): Use BVAR.
9827 (check_window_end, dump_glyph_matrix, dump_glyph)
9828 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9829
9830 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9831 Likewise.
9832
9833 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9834 check till after the cache is created in init_frame_faces.
9835
ff2bc410
SM
98362011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9837
9838 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9839
28177add
PE
98402011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9841
dd3482fe
PE
9842 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9843 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9844 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9845
393d71f3 9846 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9847 * fileio.c (Finsert_file_contents):
9848 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9849 Remove the old (too-loose) buffer overflow checks.
9850 They weren't needed, since make_gap checks for buffer overflow.
9851 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9852 The old code merely checked for Emacs fixnum overflow, and relied
9853 on undefined (wraparound) behavior. The new code avoids undefined
9854 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9855
2e6813b0 9856 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9857 Tune. Don't use wider integers than needed. Don't use alloca.
9858 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9859
599a9e4f
PE
9860 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9861
99561444
PE
9862 * insdel.c, lisp.h (buffer_overflow): New function.
9863 (insert_from_buffer_1, replace_range, replace_range_2):
9864 * insdel.c (make_gap_larger):
9865 * editfns.c (Finsert_char):
9866 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9867
28177add
PE
9868 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9869
e69dafad
PE
98702011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9871
4baa020d 9872 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9873
b1c46f02
PE
9874 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9875 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9876
e69dafad
PE
9877 * fileio.c: Don't assume EMACS_INT fits in off_t.
9878 (emacs_lseek): New static function.
9879 (Finsert_file_contents, Fwrite_region): Use it.
9880 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9881
566684ea
PE
9882 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9883
e6966cd6
PE
9884 * fns.c: Don't overflow int when computing a list length.
9885 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9886 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9887 truncation on 64-bit hosts. Check for QUIT every
9888 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9889 faster and is responsive enough.
9890 (Flength): Report an error instead of overflowing an integer.
9891 (Fsafe_length): Return a float if the value is not representable
9892 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9893 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9894 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9895
dd0b0efb
PE
9896 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9897 (header_size, word_size): New constants.
9898 (allocate_vectorlike): Don't check size overflow here.
9899 (allocate_vector): Check it here instead, since this is the only
9900 caller of allocate_vectorlike that could cause overflow.
9901 Check that the new vector's length is representable as a fixnum.
9902
86fe5cfe
PE
9903 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9904 The previous code was bogus. For example, next_almost_prime (32)
9905 returned 39, which is undesirable as it is a multiple of 3; and
9906 next_almost_prime (24) returned 25, which is a multiple of 5 so
9907 why was the code bothering to check for multiples of 7?
9908
80e88859
PE
9909 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9910
4a2f0ad6
PE
9911 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9912
f66c7cf8
PE
9913 Variadic C functions now count arguments with ptrdiff_t.
9914 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9915 Back then I didn't know that the Emacs coding style prefers signed int.
9916 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9917 were being counted with int, which may truncate counts on 64-bit
9918 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9919 * lisp.h (struct Lisp_Subr.function.aMANY)
9920 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9921 Arg counts are now ptrdiff_t, not size_t.
9922 All variadic functions and their callers changed accordingly.
9923 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9924 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9925 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9926 * callint.c (Fcall_interactively): Check arg count for overflow,
9927 to avoid potential buffer overrun. Use signed char, not 'int',
9928 for 'varies' array, so that we needn't bother to check its size
9929 calculation for overflow.
9930 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9931 * eval.c (apply_lambda):
9932 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9933 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9934 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9935
a1759b76
PE
9936 * callint.c (Fcall_interactively): Don't use index var as event count.
9937
d96be9fc
PE
9938 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9939 * mem-limits.h (SIZE): Remove; no longer used.
9940
a690a978 9941 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9942
578c21e6
PE
9943 Remove unnecessary casts.
9944 * xterm.c (x_term_init):
9945 * xfns.c (x_set_border_pixel):
9946 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9947 These aren't needed now that we assume ANSI C.
9948
96f53c6c
PE
9949 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9950 It's more likely to cause problems (due to unsigned overflow)
9951 than to cure them.
9952
83c77d31
PE
9953 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9954
ee2079f1
PE
9955 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9956
6da65536
PE
9957 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9958
7147c4a4
PE
9959 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9960
193e32d9
PE
9961 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9962
e5533da6
PE
9963 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9964
9910e595
PE
9965 GLYPH_CODE_FACE returns EMACS_INT, not int.
9966 * dispextern.h (merge_faces):
9967 * xfaces.c (merge_faces):
01103c44
PE
9968 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9969 Don't assume EMACS_INT fits in int.
9910e595 9970
2638320e
PE
9971 * character.h (CHAR_VALID_P): Remove unused parameter.
9972 * fontset.c, lisp.h, xdisp.c: All uses changed.
9973
045eb8d9
PE
9974 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9975
c1f134b5
PE
9976 * fns.c (concat): Minor tuning based on overflow analysis.
9977 This doesn't fix any bugs. Use int to hold character, instead
9978 of constantly refetching from Emacs object. Use XFASTINT, not
9979 XINT, for value known to be a character. Don't bother comparing
9980 a single byte to 0400, as it's always less.
9981
395fcb93 9982 * floatfns.c (Fexpt):
327eeec8
PE
9983 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9984
abbd3d23
PE
9985 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9986 for characters.
9987
684a03ef
PE
9988 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9989
0fed43f3
PE
9990 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9991 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9992 incorrectly succeed when S was a string, because 4294967386 was
9993 truncated before it was used.
9994
8fd02eb7
PE
9995 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9996 Otherwise, an out-of-range integer could cause undefined behavior
9997 on a 64-bit host.
9998
f8c86b69
PE
9999 * composite.c: Use int, not EMACS_INT, for characters.
10000 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10001 EMACS_INT, for values that are known to be in character range.
10002 This doesn't fix any bugs but is the usual style inside Emacs and
10003 may generate better code on 32-bit machines.
10004
34206dd2
PE
10005 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10006 This is for reasons similar to the recent CHAR_STRING fix.
10007 * charset.c (Fencode_char): Check that character arg is actually
10008 a character. Pass an int to ENCODE_CHAR.
10009 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10010 wider than 'int', as a compile-time check to prevent future regressions
10011 in this area.
10012
c5958d4c 10013 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10014
10015 Make sure a 64-bit char is never passed to CHAR_STRING.
10016 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10017 by silently ignoring the top 32 bits, allowing some values
10018 that were far too large to be valid characters.
10019 * character.h: Include <verify.h>.
10020 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10021 arguments are no wider than unsigned, as a compile-time check
10022 to prevent future regressions in this area.
10023 * data.c (Faset):
01103c44 10024 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10025 (Fsubst_char_in_region):
10026 * fns.c (concat):
10027 * xdisp.c (decode_mode_spec_coding):
10028 Adjust to CHAR_STRING's new requirement.
10029 * editfns.c (Finsert_char, Fsubst_char_in_region):
10030 * fns.c (concat): Check that character args are actually
10031 characters. Without this test, these functions did the wrong
10032 thing with wildly out-of-range values on 64-bit hosts.
10033
d37ca623
PE
10034 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10035 These casts should not be needed on 32-bit hosts, either.
10036 * keyboard.c (read_char):
10037 * lread.c (Fload): Remove casts to unsigned.
10038
ea204efb
PE
10039 * lisp.h (UNSIGNED_CMP): New macro.
10040 This fixes comparison bugs on 64-bit hosts.
10041 (ASCII_CHAR_P): Use it.
10042 * casefiddle.c (casify_object):
01103c44 10043 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10044 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10045 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10046 * dispextern.h (FACE_FROM_ID):
10047 * keyboard.c (read_char): Use UNSIGNED_CMP.
10048
41cb286c
PE
10049 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10050 not to EMACS_INT, to avoid GCC warning.
10051
4a1b9832
PE
10052 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10053
55daad71
PE
10054 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10055 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10056 isn't needed on 32-bit machines.
8f95c75c 10057
01103c44
PE
10058 * buffer.c (Fgenerate_new_buffer_name):
10059 Use EMACS_INT for count, not int.
0ceccced 10060 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10061
10062 * data.c (Qcompiled_function): Now static.
10063
c6f072e7
PE
10064 * window.c (window_body_lines): Now static.
10065
20ce5912
PE
10066 * image.c (gif_load): Rename local to avoid shadowing.
10067
9c4c5f81
PE
10068 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10069 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10070 * alloc.c (make_save_value): Integer argument is now of type
10071 ptrdiff_t, not int.
10072 (mark_object): Use ptrdiff_t, not int.
10073 * lisp.h (pD): New macro.
10074 * print.c (print_object): Use it.
10075
c0c5c8ae
PE
10076 * alloc.c: Use EMACS_INT, not int, to count objects.
10077 (total_conses, total_markers, total_symbols, total_vector_size)
10078 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10079 (total_free_floats, total_floats, total_free_intervals)
10080 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10081 Now EMACS_INT, not int. All uses changed.
10082 (Fgarbage_collect): Compute overall total using a double, so that
10083 integer overflow is less likely to be a problem. Check for overflow
10084 when converting back to an integer.
5a25e253
PE
10085 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10086 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10087 These were 'int' variables that could overflow on 64-bit hosts;
10088 they were never used, so remove them instead of repairing them.
211a0b2a 10089 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10090 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10091 Previously, this ceilinged at INT_MAX, but that doesn't work on
10092 64-bit machines.
e46bb31a 10093 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10094
c78baabf 10095 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10096 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10097 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10098 when a (possibly-narrower) signed value would do just as well.
10099 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10100
c9d624c6
PE
10101 * alloc.c: Catch some string size overflows that we were missing.
10102 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10103 for convenience in STRING_BYTES_MAX.
10104 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10105 The definition here is exact; the one in lisp.h was approximate.
10106 (allocate_string_data): Check for string overflow. This catches
10107 some instances we weren't catching before. Also, it catches
10108 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10109 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10110 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10111
c9d624c6
PE
10112 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10113 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10114 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10115
353032ce
PE
10116 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10117
2bccce07
PE
10118 * alloc.c (Fmake_string): Check for out-of-range init.
10119
0ac30604
SM
101202011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10121
10122 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10123
c195f2de
JD
101242011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10125
10126 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10127 xg_get_default_scrollbar_width.
10128
10129 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10130 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10131 (style_changed_cb): Call update_theme_scrollbar_width and call
10132 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10133 all frames (Bug#8505).
10134 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10135 Call gtk_window_set_resizable if HAVE_GTK3.
10136 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10137 and height if HAVE_GTK3 (Bug#8505).
10138 (scroll_bar_width_for_theme): New variable.
10139 (update_theme_scrollbar_width): New function.
10140 (xg_get_default_scrollbar_width): Move code to
10141 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10142 (xg_initialize): Call update_theme_scrollbar_width.
10143
10144 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10145
10146 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10147
e10ac9f1
MR
101482011-06-12 Martin Rudalics <rudalics@gmx.at>
10149
10150 * frame.c (make_frame): Call other_buffer_safely instead of
10151 other_buffer.
10152
10153 * window.c (temp_output_buffer_show): Call display_buffer with
10154 second argument Vtemp_buffer_show_specifiers and reset latter
10155 immediately after the call.
10156 (Vtemp_buffer_show_specifiers): New variable.
10157 (auto_window_vscroll_p, next_screen_context_lines)
10158 (Vscroll_preserve_screen_position): Remove leading asterisks from
10159 doc-strings.
10160
2d3c217e 101612011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10162
7b7f97e8 10163 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10164 * buffer.c (Qclone_number): Remove for now, as it's unused.
10165 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10166 (record_buffer): Remove unused local.
10167 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10168 (set_frame_buffer_list): Remove; unused.
10169 * frame.h (other_visible_frames): Remove decl.
10170 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10171 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10172 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10173 if HAVE_GPM.
10174 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10175 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10176 Define only if HAVE_GPM.
10177 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10178 (update_hints_inhibit): Remove; never set. All uses removed.
10179 * widgetprv.h (emacsFrameClassRec): Remove decl.
10180 * window.c (delete_deletable_window): Now returns void, since it
10181 wasn't returning anything.
10182 (compare_window_configurations): Remove unused locals.
10183 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10184 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10185 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10186 the same widths as pointers. This follows up on the 2011-05-06 patch.
10187 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10188 * xterm.h: Likewise.
10189 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10190
1384b89e
JB
101912011-06-12 Juanma Barranquero <lekktu@gmail.com>
10192
10193 * makefile.w32-in: Update dependencies.
10194 (LISP_H): Add lib/intprops.h.
10195
1100a63c
CY
101962011-06-11 Chong Yidong <cyd@stupidchicken.com>
10197
10198 * image.c (gif_load): Add animation frame delay to the metadata.
10199 (syms_of_image): Use DEFSYM. New symbol `delay'.
10200
6198ccd0
MR
102012011-06-11 Martin Rudalics <rudalics@gmx.at>
10202
10203 * window.c (delete_deletable_window): Re-add.
10204 (Fset_window_configuration): Rewrite to handle dead buffers and
10205 consequently deletable windows.
10206 (window_tree, Fwindow_tree): Remove. Supply functionality in
10207 window.el.
10208 (compare_window_configurations): Simplify code.
10209
b6e3633c
AS
102102011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10211
1ab0dee5
AS
10212 * image.c (imagemagick_load_image): Fix type mismatch.
10213 (Fimagemagick_types): Likewise.
10214
b6e3633c
AS
10215 * window.h (replace_buffer_in_windows): Declare.
10216
9397e56f
MR
102172011-06-11 Martin Rudalics <rudalics@gmx.at>
10218
10219 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10220 Qclone_number. Remove external declaration of Qdelete_window.
10221 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10222 code.
640c8776
SM
10223 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10224 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10225 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10226 buffer list implementation.
10227 (other_buffer_safely): New function.
10228 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10229 calls to replace_buffer_in_windows and
10230 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10231 if allowed.
10232 (record_buffer): Inhibit quitting and rewrite using quittable
10233 functions. Run Qbuffer_list_update_hook if allowed.
10234 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10235 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10236 Move switch-to-buffer to window.el.
9397e56f
MR
10237 (bury-buffer): Move to window.el.
10238 (Vbuffer_list_update_hook): New variable.
10239
10240 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10241 section.
10242
10243 * window.h (resize_frame_windows): Move up in code.
10244 (Fwindow_frame): Remove EXFUN.
10245 (replace_buffer_in_all_windows): Remove prototype.
10246 (replace_buffer_in_windows_safely): Add prototype.
10247
10248 * window.c: Declare Qdelete_window static again. Move down
10249 declaration of select_count.
10250 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10251 (Fother_window): Move to window.el.
10252 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10253 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10254 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10255 window.el.
10256 (replace_buffer_in_windows): Implement by calling
10257 Qreplace_buffer_in_windows.
10258 (replace_buffer_in_all_windows): Remove with some functionality
10259 moved into replace_buffer_in_windows_safely.
10260 (replace_buffer_in_windows_safely): New function.
10261 (select_window_norecord, select_frame_norecord): Move in front
10262 of run_window_configuration_change_hook. Remove now obsolete
10263 declarations.
640c8776
SM
10264 (Fset_window_buffer): Rewrite doc-string.
10265 Call Qrecord_window_buffer.
9397e56f
MR
10266 (keys_of_window): Move binding for other-window to window.el.
10267
b50691aa
CY
102682011-06-11 Chong Yidong <cyd@stupidchicken.com>
10269
10270 * dispextern.h (struct image): Replace data member, whose int_val
10271 and ptr_val fields were not used by anything, with a single
10272 lisp_val object.
10273
10274 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10275 (gif_clear_image, gif_load, imagemagick_load_image)
10276 (gs_clear_image, gs_load): Callers changed.
10277
3f754b86
PE
102782011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10279
cca69397
PE
10280 * buffer.h: Include <time.h>, for time_t.
10281 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10282
109e28d0
PE
10283 Fix minor problems found by static checking.
10284
60737f02
PE
10285 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10286
4b66faf3
PE
10287 Make identifiers static if they are not used in other modules.
10288 * data.c (Qcompiled_function, Qframe, Qvector):
10289 * image.c (QimageMagick, Qsvg):
10290 * minibuf.c (Qmetadata):
10291 * window.c (resize_window_check, resize_root_window): Now static.
10292 * window.h (resize_window_check, resize_root_window): Remove decls.
10293
109e28d0
PE
10294 * window.c (window_deletion_count, delete_deletable_window):
10295 Remove; unused.
46a4ce9e
PE
10296 (window_body_lines): Now static.
10297 (Fdelete_other_windows_internal): Mark vars as initialized.
10298 Make sure 'resize_failed' is initialized.
10299 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10300 (resize_window_apply): Remove unused local.
10301 * window.h (delete_deletable_window): Remove decl.
10302
109e28d0 10303 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10304 (imagemagick_load_image): Fix pointer signedness problem by changing
10305 last arg from unsigned char * to char *. All uses changed.
10306 Also, fix a local for similar reasons.
10307 Remove unused locals. Remove locals to avoid shadowing.
10308 (fn_rsvg_handle_free): Remove; unused.
10309 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10310 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10311
3f754b86
PE
10312 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10313
2547adb1
CY
103142011-06-10 Chong Yidong <cyd@stupidchicken.com>
10315
10316 * image.c (gif_load): Fix omitted cast error introduced by
10317 2011-06-06 change.
10318
2c8e37d4
MR
103192011-06-10 Martin Rudalics <rudalics@gmx.at>
10320
10321 * window.h (resize_proportionally, orig_total_lines)
10322 (orig_top_line): Remove from window structure.
10323 (set_window_height, set_window_width, change_window_heights)
10324 (Fdelete_window): Remove prototypes.
10325 (resize_frame_windows): Remove duplicate declaration.
10326
440a42e3
EZ
103272011-06-10 Eli Zaretskii <eliz@gnu.org>
10328
10329 * window.h (resize_frame_windows, resize_window_check)
10330 (delete_deletable_window, resize_root_window)
10331 (resize_frame_windows): Declare prototypes.
10332
10333 * window.c (resize_window_apply): Make definition be "static" to
10334 match the prototype.
10335
562dd5e9
MR
103362011-06-10 Martin Rudalics <rudalics@gmx.at>
10337
10338 * window.c: Remove declarations of Qwindow_size_fixed,
10339 window_min_size_1, window_min_size_2, window_min_size,
10340 size_window, window_fixed_size_p, enlarge_window, delete_window.
10341 Remove static from declaration of Qdelete_window, it's
10342 temporarily needed by Fbury_buffer.
10343 (replace_window): Don't assign orig_top_line and
10344 orig_total_lines.
10345 (Fdelete_window, delete_window): Remove. Window deletion is
10346 handled by window.el.
640c8776
SM
10347 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10348 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10349 (Fdelete_other_windows): Remove. Deleting other windows is
10350 handled by window.el.
10351 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10352 handled in window.el.
10353 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10354 Window minimum sizes are handled in window.el.
10355 (shrink_windows, size_window, set_window_height)
10356 (set_window_width, change_window_heights, window_height)
10357 (window_width, CURBEG, CURSIZE, enlarge_window)
10358 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10359 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10360 handled in window.el.
10361 (make_dummy_parent): Rename to make_parent_window and give it a
10362 second argument horflag.
10363 (make_window): Don't set resize_proportionally any more.
10364 (Fsplit_window): Remove. Windows are split in window.el.
10365 (save_restore_action, save_restore_orig_size)
10366 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10367 Resize mini windows in window.el.
10368 (grow_mini_window, shrink_mini_window): Implement by calling
10369 Qresize_root_window_vertically, resize_window_check and
10370 resize_window_apply.
640c8776
SM
10371 (saved_window, Fset_window_configuration, save_window_save):
10372 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10373 resize_proportionally.
10374 (window_min_height, window_min_width): Move to window.el.
10375 (keys_of_window): Move bindings for delete-other-windows,
10376 split-window, delete-window and enlarge-window to window.el.
10377
10378 * buffer.c: Temporarily extern Qdelete_window.
10379 (Fbury_buffer): Temporarily call Qdelete_window instead of
10380 Fdelete_window (Fbury_buffer will move to window.el soon).
10381
10382 * frame.c (set_menu_bar_lines_1): Remove code handling
10383 orig_top_line and orig_total_lines.
10384
10385 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10386 set_window_height but set heights directly.
10387 (change_frame_size_1): Use resize_frame_windows.
10388
10389 * xdisp.c (init_xdisp): Don't use set_window_height but set
10390 heights directly.
10391
640c8776
SM
10392 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10393 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10394 run_window_configuration_change_hook.
10395
10396 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10397 instead of change_window_heights and run
10398 run_window_configuration_change_hook.
10399
1a13852e
MR
104002011-06-09 Martin Rudalics <rudalics@gmx.at>
10401
10402 * window.c (replace_window): Rename second argument REPLACEMENT to
10403 NEW. New third argument SETFLAG. Rewrite.
10404 (delete_window, make_dummy_parent): Call replace_window with
10405 third argument 1.
10406 (window_list_1): Move down in code.
10407 (run_window_configuration_change_hook): Move set_buffer part
10408 before select_frame_norecord part in order to unwind correctly.
10409 Rename count1 to count.
10410 (recombine_windows, delete_deletable_window, resize_root_window)
10411 (Fdelete_other_windows_internal)
10412 (Frun_window_configuration_change_hook, make_parent_window)
10413 (resize_window_check, resize_window_apply, Fresize_window_apply)
10414 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10415 (Fdelete_window_internal, Fresize_mini_window_internal):
10416 New functions.
1a13852e
MR
10417 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10418
f3d1777e
MR
104192011-06-08 Martin Rudalics <rudalics@gmx.at>
10420
496e208e
MR
10421 * window.h (window): Add some new members to window structure -
10422 normal_lines, normal_cols, new_total, new_normal, clone_number,
10423 splits, nest, prev_buffers, next_buffers.
10424 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10425 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10426
f3d1777e
MR
10427 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10428 Remove.
496e208e
MR
10429 (make_dummy_parent): Set new members of windows structure.
10430 (make_window): Move down in code. Handle new members of window
10431 structure.
10432 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10433 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10434 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10435 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10436 (Fset_window_next_buffers, Fset_window_clone_number):
10437 New functions.
496e208e
MR
10438 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10439 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10440 Doc-string fixes.
10441 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10442 Argument WINDOW can be now internal window too.
10443 (Fwindow_use_time): Move up in code.
10444 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10445 Rewrite doc-string.
10446 (Fset_window_configuration, saved_window)
10447 (Fcurrent_window_configuration, save_window_save): Handle new
10448 members of window structure.
b9e809c2
MR
10449 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10450 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10451 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10452 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10453 Qget_mru_window, Qresize_root_window,
10454 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10455 Qauto_buffer_name; staticpro them.
f3d1777e 10456
abde8f8c
MR
104572011-06-07 Martin Rudalics <rudalics@gmx.at>
10458
10459 * window.c (Fwindow_total_size, Fwindow_left_column)
10460 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10461 (Fwindow_list_1): New functions.
10462 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10463 (Fwindow_width, Fscroll_left, Fscroll_right):
10464 Use window_body_cols instead of window_box_text_cols.
10465 (delete_window, Fset_window_configuration):
10466 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10467 (delete_all_subwindows): Take a window as argument and not a
10468 structure. Rewrite.
190b47e6
MR
10469 (window_loop): Remove handling of GET_LRU_WINDOW and
10470 GET_LARGEST_WINDOW.
10471 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10472
10473 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10474 window_box_text_cols. delete_all_subwindows now takes a
10475 Lisp_Object as argument.
abde8f8c 10476
640c8776
SM
10477 * indent.c (compute_motion, Fcompute_motion):
10478 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10479
fa8a67e6
MR
10480 * frame.c (delete_frame): Call delete_all_subwindows with root
10481 window as argument.
10482
a54e3482
DC
104832011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10484
10485 * fns.c (Fputhash): Document return value.
10486
60002bf5
CY
104872011-06-06 Chong Yidong <cyd@stupidchicken.com>
10488
10489 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10490
0c671da6 104912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10492
b862a52a 10493 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10494
be44ca6c
PE
10495 Check for overflow when converting integer to cons and back.
10496 * charset.c (Fdefine_charset_internal, Fdecode_char):
10497 Use cons_to_unsigned to catch overflow.
10498 (Fencode_char): Use INTEGER_TO_CONS.
10499 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10500 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10501 * data.c (long_to_cons, cons_to_long): Remove.
10502 (cons_to_unsigned, cons_to_signed): New functions.
10503 These signal an error for invalid or out-of-range values.
10504 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10505 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10506 * font.c (Ffont_variation_glyphs):
10507 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10508 * lisp.h: Include <intprops.h>.
10509 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10510 (cons_to_signed, cons_to_unsigned): New decls.
10511 (long_to_cons, cons_to_long): Remove decls.
10512 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10513 (Fprimitive_undo): Use CONS_TO_INTEGER.
10514 * xfns.c (Fx_window_property): Likewise.
10515 * xselect.c: Include <limits.h>.
10516 (x_own_selection, selection_data_to_lisp_data):
10517 Use INTEGER_TO_CONS.
10518 (x_handle_selection_request, x_handle_selection_clear)
10519 (x_get_foreign_selection, Fx_disown_selection_internal)
10520 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10521 (lisp_data_to_selection_data): Use cons_to_unsigned.
10522 (x_fill_property_data): Use cons_to_signed.
10523 Report values out of range.
10524
d1f3d2af
PE
10525 Check for buffer and string overflow more precisely.
10526 * buffer.h (BUF_BYTES_MAX): New macro.
10527 * lisp.h (STRING_BYTES_MAX): New macro.
10528 * alloc.c (Fmake_string):
10529 * character.c (string_escape_byte8):
10530 * coding.c (coding_alloc_by_realloc):
10531 * doprnt.c (doprnt):
10532 * editfns.c (Fformat):
10533 * eval.c (verror):
10534 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10535 since they may not be the same number.
10536 * editfns.c (Finsert_char):
10537 * fileio.c (Finsert_file_contents):
10538 Likewise for BUF_BYTES_MAX.
10539
dd52fcea
PE
10540 * image.c: Use ptrdiff_t, not int, for sizes.
10541 (slurp_file): Switch from int to ptrdiff_t.
10542 All uses changed.
10543 (slurp_file): Check that file size fits in both size_t (for
10544 malloc) and ptrdiff_t (for sanity and safety).
10545
7f9bbdbb
PE
10546 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10547 if b->modtime has its maximal value.
10548
dfe18f82
PE
10549 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10550
84acfcf0
PE
10551 Don't assume time_t can fit into int.
10552 * buffer.h (struct buffer.modtime): Now time_t, not int.
10553 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10554 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10555
ccd9a01a
PE
10556 Minor fixes for signed vs unsigned integers.
10557 * character.h (MAYBE_UNIFY_CHAR):
10558 * charset.c (maybe_unify_char):
10559 * keyboard.c (read_char, reorder_modifiers):
10560 XINT -> XFASTINT, since the integer must be nonnegative.
10561 * ftfont.c (ftfont_spec_pattern):
10562 * keymap.c (access_keymap, silly_event_symbol_error):
10563 XUINT -> XFASTINT, since the integer must be nonnegative.
10564 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10565 since it makes no difference and we prefer signed.
10566 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10567 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10568 nonnegative.
10569
d6d100dd
SM
105702011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10571
10572 * window.h (Fwindow_frame): Declare.
10573
2b6148e4
PE
105742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10575
10576 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10577 (SPARE_MEMORY): Always define.
10578 (LARGE_REQUEST): Remove.
10579 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10580
f230ecc9
MR
105812011-06-06 Martin Rudalics <rudalics@gmx.at>
10582
727e958e
MR
10583 * lisp.h: Move EXFUNS for Fframe_root_window,
10584 Fframe_first_window and Fset_frame_selected_window to window.h.
10585
10586 * window.h: Move EXFUNS for Fframe_root_window,
10587 Fframe_first_window and Fset_frame_selected_window here from
10588 lisp.h.
10589
10590 * frame.c (Fwindow_frame, Fframe_first_window)
10591 (Fframe_root_window, Fframe_selected_window)
10592 (Fset_frame_selected_window): Move to window.c.
10593 (Factive_minibuffer_window): Move to minibuf.c.
10594 (Fother_visible_frames_p): New function.
10595
10596 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10597
f230ecc9
MR
10598 * window.c (decode_window, decode_any_window): Move up in code.
10599 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10600 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10601 (Fwindow_buffer): Move up and rewrite doc-string.
10602 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10603 (Fwindow_prev): New functions.
727e958e
MR
10604 (Fwindow_frame): Move here from frame.c. Accept any window as
10605 argument.
10606 (Fframe_root_window, Fframe_first_window)
10607 (Fframe_selected_window): Move here from frame.c. Accept frame
10608 or arbitrary window as argument. Update doc-strings.
10609 (Fminibuffer_window): Move up in code.
10610 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10611 (Fset_frame_selected_window): Move here from frame.c.
10612 Marginal rewrite.
727e958e
MR
10613 (Fselected_window, select_window, Fselect_window): Move up in
10614 code. Minor doc-string fixes.
f230ecc9 10615
4d09bcf6
PE
106162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10617
10618 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10619 Do not assume that spare memory exists; that assumption is valid
10620 only if SYSTEM_MALLOC.
10621 (LARGE_REQUEST): New macro, so that the issue of large requests
10622 is separated from the issue of spare memory.
10623
810928a2
AS
106242011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10625
172418ad
AS
10626 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10627 format. (Bug#8806)
10628
43f862f7
AS
10629 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10630
810928a2
AS
10631 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10632 before statements.
10633
a059fe24
JD
106342011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10635
10636 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10637
10638 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10639
10640 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10641 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10642
989bf368
JB
106432011-06-05 Juanma Barranquero <lekktu@gmail.com>
10644
10645 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10646
4b80f674
CY
106472011-06-04 Chong Yidong <cyd@stupidchicken.com>
10648
10649 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10650 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10651 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10652 New error handlers.
4b80f674
CY
10653 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10654 Obey Vx_select_enable_clipboard_manager. Catch errors in
10655 x_clipboard_manager_save (Bug#8779).
10656 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10657 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10658
99a33b77 106592011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10660
10661 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10662
99a33b77 106632011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10664
10665 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10666 in the current matrix if keep_current_p is non-zero.
10667
8264569d
EZ
106682011-06-04 Eli Zaretskii <eliz@gnu.org>
10669
10670 * bidi.c (bidi_level_of_next_char): Fix last change.
10671
57f97249
EZ
106722011-06-03 Eli Zaretskii <eliz@gnu.org>
10673
fec2107c 10674 Support bidi reordering of text covered by display properties.
57f97249 10675
fec2107c
EZ
10676 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10677 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10678 (bidi_cache_search, bidi_cache_iterator_state)
10679 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10680 (bidi_level_of_next_char, bidi_move_to_visually_next):
10681 Support character positions inside a run of characters covered by a
fec2107c
EZ
10682 display string.
10683 (bidi_paragraph_init, bidi_resolve_explicit_1)
10684 (bidi_level_of_next_char): Call bidi_fetch_char and
10685 bidi_fetch_char_advance instead of FETCH_CHAR and
10686 FETCH_CHAR_ADVANCE.
10687 (bidi_init_it): Initialize new members.
10688 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10689 definitions.
10690 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10691 instead of using explicit *_CHAR codes.
d6d100dd
SM
10692 (bidi_resolve_explicit, bidi_resolve_weak):
10693 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10694 bidirectional text is supported only in multibyte buffers.
10695 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10696 it to initialize the frame_window_p member of struct bidi_it.
10697 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10698 (bidi_resolve_explicit, bidi_resolve_weak)
10699 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10700 bidi_it->nchars is non-positive.
10701 (bidi_level_of_next_char): Don't try to lookup the cache for the
10702 next/previous character if nothing is cached there yet, or if we
10703 were just reseat()'ed to a new position.
c40e2fb2 10704
0e14fe90
EZ
10705 * xdisp.c (set_cursor_from_row): Set start and stop points
10706 according to the row's direction when priming the loop that looks
10707 for the glyph on which to display cursor.
10708 (single_display_spec_intangible_p): Function deleted.
10709 (display_prop_intangible_p): Reimplement to call
10710 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10711 Accept 3 additional arguments needed by handle_display_spec.
10712 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10713 values: lists, `(when COND...)' forms, etc.
10714 (single_display_spec_string_p): Support property values that are
10715 lists with the argument STRING its top-level element.
10716 (display_prop_string_p): Fix the condition for processing a
10717 property that is a list to be consistent with handle_display_spec.
fec2107c 10718 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10719 last portion of handle_display_prop.
10720 (compute_display_string_pos): Accept additional argument
10721 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10722 value of a `display' property is a "replacing spec".
10723 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10724 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10725 the display property, but just return a value indicating whether
10726 the display property will replace the characters it covers.
10727 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10728 frame_window_p members of struct bidi_it.
d6d100dd
SM
10729 (compute_display_string_pos, compute_display_string_end):
10730 New functions.
fec2107c
EZ
10731 (push_it): Accept second argument POSITION, where pop_it should
10732 jump to continue iteration.
10733 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10734
fec2107c
EZ
10735 * keyboard.c (adjust_point_for_property): Adjust the call to
10736 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10737
10738 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10739 (bidi_init_it): Update prototypes.
10740 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10741 (compute_display_string_pos, compute_display_string_end):
10742 Declare prototypes.
fec2107c
EZ
10743 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10744 EMACS_INT.
fc6f18ce 10745
40087514 107462011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10747
57f53182
PE
10748 Malloc failure behavior now depends on size of allocation.
10749 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10750 * lisp.h: Change signatures accordingly.
10751 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10752 All callers changed. (Bug#8762)
10753
10754 * gnutls.c: Use Emacs's memory allocators.
10755 Without this change, the gnutls library would invoke malloc etc.
10756 directly, which causes problems on non-SYNC_INPUT hosts, and which
10757 runs afoul of improving memory_full behavior. (Bug#8761)
10758 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10759 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10760 xfree instead of the default malloc, realloc, free.
10761 (Fgnutls_boot): No need to check for memory allocation failure,
10762 since xmalloc does that for us.
10763
ac32cd99 10764 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10765 * category.c (hash_get_category_set):
10766 * ccl.c (ccl_driver):
10767 * charset.c (Fdefine_charset_internal):
10768 * charset.h (struct charset.hash_index):
10769 * composite.c (get_composition_id, gstring_lookup_cache)
10770 (composition_gstring_put_cache):
10771 * composite.h (struct composition.hash_index):
10772 * dispextern.h (struct image.hash):
10773 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10774 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10775 (hashfn_equal, hashfn_user_defined, make_hash_table)
10776 (maybe_resize_hash_table, hash_lookup, hash_put)
10777 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10778 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10779 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10780 * image.c (make_image, search_image_cache, lookup_image)
10781 (xpm_put_color_table_h):
10782 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10783 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10784 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10785 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10786 * alloc.c (allocate_vectorlike):
10787 Check for overflow in vector size calculations.
10788 * ccl.c (ccl_driver):
10789 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10790 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10791 need to be updated by these changes.
40087514
PE
10792 * fns.c (make_hash_table, maybe_resize_hash_table):
10793 Check for integer overflow with large hash tables.
0de4bb68
PE
10794 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10795 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10796 (SXHASH_REDUCE): New macro.
10797 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10798 Use it instead of discarding useful hash info with large hash values.
10799 (sxhash_float): New function.
10800 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10801 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10802 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10803 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10804 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10805 Adjust signatures to match updated version of code.
10806 (consing_since_gc): Now EMACS_INT, since a single hash table can
10807 use more than INT_MAX bytes.
10808
698d32e2
DN
108092011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10810
10811 Make it possible to build with GCC-4.6+ -O2 -flto.
10812
10813 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10814
fd6fa53f
SM
108152011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10816
10817 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10818 Call minibuffer-inactive-mode.
10819
864db017
JB
108202011-05-31 Juanma Barranquero <lekktu@gmail.com>
10821
10822 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10823 Update dependencies.
10824
2ad0baf4
DN
108252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10826
10827 * data.c (init_data): Remove code for UTS, this system is not
10828 supported anymore.
10829
4fcc2638
DN
108302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10831
10832 Don't force ./temacs to start in terminal mode.
10833
10834 * frame.c (make_initial_frame): Initialize faces in all cases, not
10835 only when CANNOT_DUMP is defined.
10836 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10837
c56e0fd5
DN
108382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10839
10840 * dispnew.c (add_window_display_history): Use const for the string
10841 pointer. Remove declaration, not needed.
10842
333d54da 108432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10844
55d4c1b2 10845 Use 'inline', not 'INLINE'.
333d54da 10846 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10847 * alloc.c, fontset.c (INLINE): Remove.
10848 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10849 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10850 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10851 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10852 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10853
738db178
DN
108542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10855
10856 Make it possible to run ./temacs.
10857
10858 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10859 syms_of_callproc does the same thing. Remove test for
10860 "initialized", do it in the caller.
10861 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10862
620c53a6
SM
108632011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10864
10865 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10866 (read_minibuf): Use get_minibuffer.
10867 (syms_of_minibuf): Use DEFSYM.
10868 (Qmetadata): New var.
10869 * data.c (Qbuffer): Don't make it static.
10870 (syms_of_data): Use DEFSYM.
10871
e003a292
PE
108722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10873
10874 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10875 (CCL_CODE_MIN): New macro.
10876
ed008a6d
PE
108772011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10878
3687c2ef
PE
10879 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10880
ed008a6d
PE
10881 * eval.c (Qdebug): Now static.
10882 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10883 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10884 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10885
d66c4c7c
CY
108862011-05-29 Chong Yidong <cyd@stupidchicken.com>
10887
10888 * image.c: Various fixes to ImageMagick code comments.
10889 (Fimagemagick_types): Doc fix.
10890
5fbc2025
PE
108912011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10892
0196f88a
PE
10893 Minor fixes prompted by GCC 4.6.0 warnings.
10894
10895 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10896
5fbc2025
PE
10897 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10898 (x_clipboard_manager_save_all): Move extern decl to ...
10899 * xterm.h: ... here, so that it can be checked for consistency.
10900
1dd3c2d9
CY
109012011-05-29 Chong Yidong <cyd@stupidchicken.com>
10902
10903 * xselect.c (x_clipboard_manager_save_frame)
10904 (x_clipboard_manager_save_all): New functions.
10905 (Fx_clipboard_manager_save): Lisp function deleted.
10906
10907 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10908 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10909
10910 * xterm.h: Update prototype.
10911
5ba6571d
WX
109122011-05-28 William Xu <william.xwl@gmail.com>
10913
10914 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10915 exiting (Bug#8239).
10916
3eaff834
JM
109172011-05-28 Jim Meyering <meyering@redhat.com>
10918
e1900994 10919 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10920 * fns.c (to_uchar): Define.
10921 (crypto_hash_function): Use it to convert some newly-signed
10922 variables to unsigned, to avoid sign-extension bugs. For example,
10923 without this change, (md5 "truc") would evaluate to
10924 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10925 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10926 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10927
0f6990a7
PE
109282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10929
10930 Integer overflow fixes.
c8a9ca5a 10931
08686060
PE
10932 * dbusbind.c: Serial number integer overflow fixes.
10933 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10934 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10935 to hold a serial number that is too large for a fixnum.
10936 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10937 Check for serial numbers out of range. Decode any serial number
59568bf0 10938 that was so large that it became a float. (Bug#8722)
08686060 10939
2d1fc3c7
PE
10940 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10941 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10942 Use XFASTINT rather than XUINT when numbers are nonnegative.
10943 (xd_append_arg, Fdbus_method_return_internal):
10944 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10945 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10946 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10947 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10948 (Bug#8722)
2d1fc3c7 10949
c8a9ca5a
PE
10950 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10951
519e1d69
PE
10952 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10953
6df6ae42 10954 ccl: Add integer overflow checks.
30569699
PE
10955 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10956 (IN_INT_RANGE): New macros.
10957 (ccl_driver): Use them to check for integer overflow when
10958 decoding a CCL program. Many of the new checks are whether XINT (x)
10959 fits in int; it doesn't always, on 64-bit hosts. The new version
10960 doesn't catch all possible integer overflows, but it's an
847044ea 10961 improvement. (Bug#8719)
30569699 10962
c11285dc
PE
10963 * alloc.c (make_event_array): Use XINT, not XUINT.
10964 There's no need for unsigned here.
10965
fdccd48e
PE
10966 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10967 This follows up to the 2011-05-06 change that substituted uintptr_t
10968 for EMACS_INT. This case wasn't caught back then.
10969
37910ab2
PE
10970 Rework Fformat to avoid integer overflow issues.
10971 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10972 now (part of C89). Include <verify.h>.
10973 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10974 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10975 (Fformat): Avoid the prepass trying to compute sizes; it was only
10976 approximate and thus did not catch overflow reliably. Instead, walk
10977 through the format just once, formatting and computing sizes as we go,
10978 checking for integer overflow at every step, and allocating a larger
10979 buffer as needed. Keep track separately whether the format is
10980 multibyte. Keep only the most-recently calculated precision, rather
10981 than them all. Record whether each argument has been converted to
10982 string. Use EMACS_INT, not int, for byte and char and arg counts.
10983 Support field widths and precisions larger than INT_MAX. Avoid
10984 sprintf's undefined behavior with conversion specifications such as %#d
10985 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10986 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10987 formatting out-of-range floating point numbers with int
9173deec 10988 formats. (Bug#8668)
37910ab2 10989
2e6578fb
PE
10990 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10991
0ae6bdee
PE
10992 * data.c: Avoid integer truncation in expressions involving floats.
10993 * data.c: Include <intprops.h>.
10994 (arith_driver): When there's an integer overflow in an expression
10995 involving floating point, convert the integers to floating point
10996 so that the resulting value does not suffer from catastrophic
10997 integer truncation. For example, on a 64-bit host (* 4
10998 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10999 Do not rely on undefined behavior after integer overflow.
11000
de883a70
PE
11001 merge count_size_as_multibyte, parse_str_to_multibyte
11002 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11003 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11004 Check for integer overflow.
11005 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11006 since it's now a duplicate of the other. This is more of
11007 a character than a buffer op, so better that it's in character.c.
11008 * fns.c, print.c: Adjust to above changes.
11009
2ff916cb
PE
110102011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11011
11012 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11013
f1b54466
PE
110142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11015
fb1ac845
PE
11016 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11017 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11018 (x_clipboard_manager_save): Now static.
11019 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11020
f1b54466
PE
11021 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11022 (crypto_hash_function): Now static.
11023 Fix pointer signedness problems. Avoid unnecessary initializations.
11024
a9f737ee
CY
110252011-05-27 Chong Yidong <cyd@stupidchicken.com>
11026
11027 * termhooks.h (Vselection_alist): Make it terminal-local.
11028
11029 * terminal.c (create_terminal): Initialize it.
11030
11031 * xselect.c: Support for clipboard managers.
11032 (Vselection_alist): Move to termhooks.h as terminal-local var.
11033 (LOCAL_SELECTION): New macro.
11034 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11035 (symbol_to_x_atom): Remove gratuitous arg.
11036 (x_handle_selection_request, lisp_data_to_selection_data)
11037 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11038 (x_own_selection, x_get_local_selection, x_convert_selection):
11039 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11040 (some_frame_on_display): Delete unused function.
11041 (Fx_own_selection_internal, Fx_get_selection_internal)
11042 (Fx_disown_selection_internal, Fx_selection_owner_p)
11043 (Fx_selection_exists_p): New optional frame arg.
11044 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11045 (x_handle_selection_clear): Don't treat other terminals with the
11046 same keyboard specially. Use the terminal-local Vselection_alist.
11047 (x_clear_frame_selections): Use Frun_hook_with_args.
11048
11049 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11050
11051 * xterm.h: Add support for those atoms.
11052
e067f0c1
CY
110532011-05-26 Chong Yidong <cyd@stupidchicken.com>
11054
11055 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11056 (converted_selections, conversion_fail_tag): New global variables.
11057 (x_selection_request_lisp_error): Free the above.
11058 (x_get_local_selection): Remove unnecessary code.
11059 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11060 of converted selections stored in converted_selections.
11061 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11062 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11063 (x_convert_selection): New function.
11064 (x_handle_selection_event): Simplify.
11065 (x_get_foreign_selection): Don't ignore incoming requests while
11066 waiting for an answer; this will fail when we implement
11067 SAVE_TARGETS, and seems unnecessary anyway.
11068 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11069 (Vx_sent_selection_functions): Doc fix.
11070
0f4aebc0
LL
110712011-05-26 Leo Liu <sdl.web@gmail.com>
11072
11073 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11074
e61124cd
YM
110752011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11076
11077 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11078
11079 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11080 for fringe update if it has periodic bitmap.
ac389d0c 11081 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11082 and fringe_bitmap_periodic_p.
11083
11084 * fringe.c (get_fringe_bitmap_data): New function.
11085 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11086 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11087 row. Mark glyph row for fringe update if periodicity changed.
11088
11089 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11090 for fringe update unless it has periodic bitmap.
11091
f16d9837
KH
110922011-05-25 Kenichi Handa <handa@m17n.org>
11093
11094 * xdisp.c (get_next_display_element): Set correct it->face_id for
11095 a static composition.
11096
e1b90ef6
LL
110972011-05-24 Leo Liu <sdl.web@gmail.com>
11098
11099 * deps.mk (fns.o):
11100 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11101
11102 * fns.c (crypto_hash_function, Fsha1): New function.
11103 (Fmd5): Use crypto_hash_function.
11104 (syms_of_fns): Add Ssha1.
11105
7400048f
PE
111062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11107
11108 * gnutls.c: Remove unused macros.
11109 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11110 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11111 Remove macros that are defined and never used.
11112 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11113
abb71cf4
CY
111142011-05-22 Chong Yidong <cyd@stupidchicken.com>
11115
11116 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11117 (Fx_get_selection_internal): Minor cleanup.
11118 (Fx_own_selection_internal): Rename arguments for consistency with
11119 select.el.
11120
6307db39
PE
111212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11122
11123 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11124
f3d4e0a4
CY
111252011-05-22 Chong Yidong <cyd@stupidchicken.com>
11126
11127 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11128
4d8ade89
YM
111292011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11130
11131 * dispnew.c (scrolling_window): Don't exclude the case that the
11132 last enabled row in the desired matrix touches the bottom boundary.
11133
32078c8d
GM
111342011-05-21 Glenn Morris <rgm@gnu.org>
11135
11136 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11137 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11138 and add some more files.
32078c8d 11139
7285dc67
EZ
111402011-05-20 Eli Zaretskii <eliz@gnu.org>
11141
11142 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11143 report_file_error introduced by the change from 2011-05-07.
11144
89d1bd22
PE
111452011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11146
11147 * systime.h (Time): Define only if emacs is defined.
11148 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11149 where the include path doesn't have X11/X.h by default. See
11150 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11151
cd394be1 111522011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11153
11154 * composite.c (find_automatic_composition): Fix previous change.
11155
b9704ad9
GM
111562011-05-20 Glenn Morris <rgm@gnu.org>
11157
11158 * lisp.mk: New file, split from Makefile.in.
11159 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11160 (shortlisp): Remove.
11161 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11162
4a720484
GM
111632011-05-19 Glenn Morris <rgm@gnu.org>
11164
11165 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11166 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11167 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11168 (lisp): Set the order to that of loadup.el.
11169 (shortlisp): Make it a copy of $lisp.
11170 (SOME_MACHINE_LISP): Remove.
11171 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11172 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11173
a28d4396
KH
111742011-05-18 Kenichi Handa <handa@m17n.org>
11175
11176 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11177 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11178 (find_automatic_composition): Mostly rewrite for efficiency.
11179
a2b1fa8e
JB
111802011-05-18 Juanma Barranquero <lekktu@gmail.com>
11181
11182 * makefile.w32-in: Update dependencies.
11183
8e1f5610
CS
111842011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11185
11186 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11187 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11188
7025ee00 111892011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11190
cdfa6eab
PE
11191 Fix some integer overflow issues, such as string length overflow.
11192
06d6db33
PE
11193 * insdel.c (count_size_as_multibyte): Check for string overflow.
11194
2b4560a8
PE
11195 * character.c (lisp_string_width): Check for string overflow.
11196 Use EMACS_INT, not int, for string indexes and lengths; in
11197 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11198 the resulting string length overflows an EMACS_INT; instead,
11199 report a string overflow if no precision given. When checking for
11200 precision exhaustion, use a check that cannot possibly have
11201 integer overflow. (Bug#8675)
11202 * character.h (lisp_string_width): Adjust to new signature.
11203
cb93f9be
PE
11204 * alloc.c (string_overflow): New function.
11205 (Fmake_string): Use it. This doesn't change behavior, but saves
11206 a few bytes and will simplify future changes.
11207 * character.c (string_escape_byte8): Likewise.
11208 * lisp.h (string_overflow): New decl.
11209
1a1f3366
PE
11210 Fixups, following up to the user-interface timestamp change.
11211 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11212 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11213 * msdos.c (mouse_get_pos): Likewise.
11214 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11215 * w32gui.h (Time): Define by including "systime.h" rather than by
11216 declaring it ourselves. (Bug#8664)
11217
d4e3e4d3
PE
11218 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11219 * image.c (clear_image_cache): Likewise.
11220
f6a24d19
PE
11221 * term.c (term_mouse_position): Don't assume time_t wraparound.
11222
08dc5ae6
PE
11223 Be more systematic about user-interface timestamps.
11224 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11225 and sometimes 'EMACS_UINT', to represent these timestamps.
11226 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11227 This makes the code easier to follow, and makes it easier to catch
11228 integer overflow bugs such as Bug#8664.
11229 * frame.c (Fmouse_position, Fmouse_pixel_position):
11230 Use Time, not unsigned long, for user-interface timestamps.
11231 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11232 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11233 * keyboard.h (last_event_timestamp): Likewise.
11234 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11235 * menu.h (xmenu_show): Likewise.
11236 * term.c (term_mouse_position): Likewise.
11237 * termhooks.h (struct input_event.timestamp): Likewise.
11238 (struct terminal.mouse_position_hook): Likewise.
11239 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11240 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11241 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11242 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11243 what it was before.
11244 * menu.h, termhooks.h: Include "systime.h", for Time.
11245
8e55734a
PE
11246 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11247 Don't assume that the difference between two unsigned long values
11248 can fit into an integer. At this point, we know button_down_time
11249 <= event->timestamp, so the difference must be nonnegative, so
11250 there's no need to cast the result if double-click-time is
11251 nonnegative, as it should be; check that it's nonnegative, just in
11252 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11253 apart (about 25 days). (Bug#8664)
8e55734a 11254
841f1b75 11255 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11256 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11257
3e26f69c
PE
11258 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11259 that always fit in int. Use a sentinel instead of a counter, to
11260 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11261 * frame.h (struct frame): Use int for menu_bar_items_used
11262 instead of EMACS_INT, since it always fits in int.
3e26f69c 11263
5cc152c0
PE
11264 * menu.c (grow_menu_items): Check for int overflow.
11265
d89eb65e
PE
11266 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11267
5235bd3e
PE
11268 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11269 Before, the code was not consistent. These values cannot exceed
11270 2**31 - 1 so there's no need to make them unsigned.
11271 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11272 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11273 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11274 as modifiers.
11275 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11276
bc827e23
PE
11277 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11278 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11279 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11280 presumably because the widths might not match.
11281
78eb494e
PE
11282 * window.c (size_window): Avoid needless test at loop start.
11283
04f2d78b
CB
112842011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11285
11286 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11287
d2fc7e3d 112882011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11289
11290 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11291
d2fc7e3d 112922011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11293
11294 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11295 `width' to `bar_area_x' and `bar_area_width', respectively.
11296 (x_scroll_run): Take account of fringe background extension.
11297
04f2d78b
CB
11298 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11299 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11300 `bar_area_width', respectively.
11301 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11302 background extension.
11303
79b70037
GM
113042011-05-10 Jim Meyering <meyering@redhat.com>
11305
11306 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11307
2f142cc5
JB
113082011-05-10 Juanma Barranquero <lekktu@gmail.com>
11309
11310 * image.c (Finit_image_library): Return t for built-in image types,
11311 like pbm and xbm. (Bug#8640)
11312
57679c86
AS
113132011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11314
11315 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11316
888c9e86
EZ
113172011-05-07 Eli Zaretskii <eliz@gnu.org>
11318
b0512a1d
EZ
11319 * w32console.c (Fset_screen_color): Doc fix.
11320 (Fget_screen_color): New function.
11321 (syms_of_ntterm): Defsubr it.
11322
7285dc67
EZ
11323 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11324 unlink the temporary file if Fcall_process didn't create it in the
11325 first place.
11326 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11327 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11328 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11329 cue to call_process_cleanup not to close that handle.
11330
4d3fcc8e
BK
113312011-05-07 Ben Key <bkey76@gmail.com>
11332
11333 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11334 one of two shell specific rules, either bootstrap-temacs-CMD or
11335 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11336 to the previous implementation of the bootstrap-temacs rule.
11337 The bootstrap-temacs-CMD rule is similar to the previous
11338 implementation of the bootstrap-temacs rule except that it
11339 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11340 variable.
11341
11342 These changes, along with some changes to nt/configure.bat,
11343 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11344 earlier fix to add support for --cflags and --ldflags options
11345 that include quotes so that it works whether make uses cmd or
11346 sh as the shell.
11347
b4289b64
MA
113482011-05-06 Michael Albinus <michael.albinus@gmx.de>
11349
11350 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11351 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11352 is a constant.
11353 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11354 a string. Handle both cases.
11355 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11356 (Fdbus_register_method): Use Qinvalid_function.
11357
af4c0e28
JB
113582011-05-06 Juanma Barranquero <lekktu@gmail.com>
11359
11360 * makefile.w32-in: Update dependencies.
11361 (LISP_H): Add inttypes.h and stdin.h.
11362 (PROCESS_H): Add unistd.h.
11363
c51453d9
EZ
113642011-05-06 Eli Zaretskii <eliz@gnu.org>
11365
11366 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11367 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11368
8ff0ac3c 113692011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11370
4c4b566b
PE
11371 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11372
aab2b9b5
PE
11373 * term.c (vfatal): Remove stray call to va_end.
11374 It's not needed and the C Standard doesn't allow it here anyway.
11375
c378da0b
PE
11376 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11377 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11378
288b08c7
PE
11379 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11380 bytes.
11381
e3601888
PE
11382 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11383
db6c0e74
PE
11384 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11385
dd5963ea
PE
11386 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11387
88c9450f
PE
11388 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11389
2f9442b8
PE
11390 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11391
c032b5f8
PE
11392 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11393 * charset.c (Fdefine_charset_internal): Don't initialize
11394 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11395 32-bit int (Bug#8600).
a108c10b
PE
11396
11397 * lread.c (read_integer): Be more consistent with string-to-number.
11398 Use string_to_number to do the actual conversion; this avoids
11399 rounding errors and fixes some other screwups. Without this fix,
11400 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11401 (digit_to_number): Move earlier, for benefit of read_integer.
11402 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11403 not a digit in any supported base. (Bug#8602)
a108c10b 11404
ad5f9eea
PE
11405 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11406
aec1708a
PE
11407 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11408 to match comment at start of function. This also removes a
11409 GCC warning about overflow in a 32+64-bit port.
11410
47be4ab5
PE
11411 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11412
371cac43
PE
11413 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11414 Reported by Stefan Monnier in
11415 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11416 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11417 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11418
d01a7826
PE
11419 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11420 (EMACS_UINTPTR): Likewise, with uintptr_t.
11421
7fd47d5c
PE
11422 * lisp.h: Prefer 64-bit EMACS_INT if available.
11423 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11424 on 32-bit hosts that have 64-bit int, so that they can access
11425 large files.
122b0c86
PE
11426 However, temporarily disable this change unless the temporary
11427 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11428
8727937b
PE
11429 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11430
8ac068ac
PE
11431 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11432 This removes an assumption that EMACS_INT and long are the same
11433 width as pointers. The assumption is true for Emacs porting targets
11434 now, but we want to make other targets possible.
11435 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11436 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11437 In the rest of the code, change types of integers that hold casted
11438 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11439 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11440 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11441 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11442 No need to cast type when ORing.
11443 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11444 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11445 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11446 assume EMACS_INT is the same width as char *.
11447 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11448 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11449 Remove no-longer-needed casts.
11450 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11451 (xg_tool_bar_help_callback, xg_make_tool_item):
11452 Use EMACS_INTPTR to hold an integer
11453 that will be cast to void *; this can avoid a GCC warning
11454 if EMACS_INT is not the same width as void *.
11455 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11456 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11457 (current_message_1, set_message_1):
11458 Use a local to convert to proper width without a cast.
11459 * xmenu.c (dialog_selection_callback): Likewise.
11460
ede49d71
PE
11461 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11462 Also, don't assume VALBITS / RAND_BITS is less than 5,
11463 and don't rely on undefined behavior when shifting a 1 left into
11464 the sign bit.
11465 * lisp.h (get_random): Change signature to match.
11466
2f30ecd0
PE
11467 * lread.c (hash_string): Use size_t, not int, for hash computation.
11468 Normally we prefer signed values; but hashing is special, because
11469 it's better to use unsigned division on hash table sizes so that
11470 the remainder is nonnegative. Also, size_t is the natural width
11471 for hashing into memory. The previous code used 'int', which doesn't
11472 retain enough info to hash well into very large tables.
11473 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11474
2a866e7b
PE
11475 * dbusbind.c: Don't possibly lose pointer info when converting.
11476 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11477 Use XPNTR rather than XHASH, so that the high-order bits of
11478 the pointer aren't lost when converting through void *.
11479
51639eac
PE
11480 * eval.c (Fautoload): Don't double-shift a pointer.
11481
92394119
PE
11482 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11483
dbdb9a7c
JB
114842011-05-06 Juanma Barranquero <lekktu@gmail.com>
11485
11486 * gnutls.c (DEF_GNUTLS_FN):
11487 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11488
db7a0b4f
AS
114892011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11490
11491 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11492 marker. (Bug#8610)
11493
cd394be1 114942011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11495
11496 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11497 New version that can reserve upto 2GB of heap space.
11498
f7ff1b0f 114992011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11500
11501 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11502
639c109b
TZ
115032011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11504
11505 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11506 `gnutls_certificate_set_x509_key_file'.
11507
d2127135
JB
115082011-05-05 Juanma Barranquero <lekktu@gmail.com>
11509
11510 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11511 Update dependencies.
11512
e968f4f3
JB
115132011-05-04 Juanma Barranquero <lekktu@gmail.com>
11514
11515 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11516 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11517 Remove unused parameter `fildes'.
11518 * process.c (read_process_output, send_process): Don't pass it.
11519
84d358f0
JB
115202011-05-04 Juanma Barranquero <lekktu@gmail.com>
11521
11522 Fix previous change: the library cache is defined in w32.c.
11523 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11524 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11525
0898ca10
JB
115262011-05-04 Juanma Barranquero <lekktu@gmail.com>
11527
11528 Implement dynamic loading of GnuTLS on Windows.
11529
11530 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11531 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11532 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11533 Declare.
11534
11535 * gnutls.c (Qgnutls_dll): Define.
11536 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11537 (gnutls_*): Declare function pointers.
11538 (init_gnutls_functions): New function to initialize function pointers.
11539 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11540 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11541 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11542 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11543 (emacs_gnutls_write, emacs_gnutls_read)
11544 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11545 (Fgnutls_available_p): New function.
11546 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11547 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11548 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11549
11550 * image.c: Include w32.h.
11551 (Vimage_type_cache): Delete.
11552 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11553 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11554 (w32_delayed_load): Move to w32.c.
11555
11556 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11557
11558 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11559 (w32_delayed_load): Move from image.c. When loading a library, record
11560 its filename in the :loaded-from property of the library id.
11561 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11562 Initialize and staticpro them.
11563 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11564
11565 * process.c: Include lisp.h before w32.h, not after.
11566 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11567 instead of gnutls_record_check_pending.
11568
11569 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11570
ff4de4aa
TZ
115712011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11572
11573 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11574 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11575 as passed in.
11576
abe95abb
JD
115772011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11578
11579 * xterm.c (x_set_frame_alpha): Do not set property on anything
11580 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11581
e16e55d4
JB
115822011-05-02 Juanma Barranquero <lekktu@gmail.com>
11583
11584 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11585
bafcf6a5
JB
115862011-05-02 Juanma Barranquero <lekktu@gmail.com>
11587
11588 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11589 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11590 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11591 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11592 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11593 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11594 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11595 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11596 (Qgnutls_bootprop_callbacks_verify): Make static.
11597
e7a6747f
AS
115982011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11599
19ed11ba
AS
11600 * callproc.c: Indentation fixup.
11601
e7a6747f 11602 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11603 (wait_for_termination, interruptible_wait_for_termination):
11604 Move after wait_for_termination_1.
e7a6747f 11605
1ef14cb4
LMI
116062011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11607
11608 * sysdep.c (interruptible_wait_for_termination): New function
11609 which is like wait_for_termination, but allows keyboard
11610 interruptions.
11611
11612 * callproc.c (Fcall_process): Add (:file "file") as an option for
11613 the STDOUT buffer.
11614 (Fcall_process_region): Ditto.
11615
330d880c
EZ
116162011-04-30 Eli Zaretskii <eliz@gnu.org>
11617
8db90b73
EZ
11618 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11619 rather than `XVECTOR (FOO)->size'.
11620
330d880c
EZ
11621 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11622 inttypes.h, as a gnulib replacement is used if it not available in
11623 system headers.
11624
15cbd324
EZ
116252011-04-21 Eli Zaretskii <eliz@gnu.org>
11626
11627 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11628 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11629 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11630
11631 * coding.c (coding_alloc_by_realloc): Error out if destination
11632 will grow beyond MOST_POSITIVE_FIXNUM.
11633 (decode_coding_emacs_mule): Abort if there isn't enough place in
11634 charbuf for the composition carryover bytes. Reserve an extra
11635 space for up to 2 characters produced in a loop.
11636 (decode_coding_iso_2022): Abort if there isn't enough place in
11637 charbuf for the composition carryover bytes.
11638
116392011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11640
ae940cca
EZ
11641 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11642 aborting when %lld or %lll format is passed.
11643 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11644 %llo or %llx format is passed. (Bug#8545)
11645
03ab8921
EZ
11646 * window.c (window_scroll_line_based): Use a marker instead of
11647 simple variables to record original value of point. (Bug#7952)
11648
afda1437
EZ
11649 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11650 produced by %s or %c overflows available buffer space. (Bug#8545)
11651
f76dee0c
PE
116522011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11653
11654 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11655 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11656
fdc5744d
JB
116572011-04-28 Juanma Barranquero <lekktu@gmail.com>
11658
11659 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11660
638f053a
JB
116612011-04-28 Juanma Barranquero <lekktu@gmail.com>
11662
11663 * keyboard.c (Qdelayed_warnings_hook): Define.
11664 (command_loop_1): Run `delayed-warnings-hook'
11665 if Vdelayed_warnings_list is non-nil.
11666 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11667 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11668
d178f871
EZ
116692011-04-28 Eli Zaretskii <eliz@gnu.org>
11670
11671 * doprnt.c (doprnt): Don't return value smaller than the buffer
11672 size if the message was truncated. (Bug#8545).
11673
b124fd93
JB
116742011-04-28 Juanma Barranquero <lekktu@gmail.com>
11675
11676 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11677 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11678
e810457d
PE
116792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11680
11681 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11682
ea51cceb
JB
116832011-04-27 Juanma Barranquero <lekktu@gmail.com>
11684
11685 * makefile.w32-in: Update dependencies.
11686
94dcfacf
EZ
116872011-04-27 Eli Zaretskii <eliz@gnu.org>
11688
11689 Improve `doprnt' and its usage. (Bug#8545)
11690 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11691 `format_end'. Remove support for %l as a conversion specifier.
11692 Don't use xrealloc. Improve diagnostics when the %l size modifier
11693 is used. Update the commentary.
11694
11695 * eval.c (verror): Simplify calculation of size_t.
11696
11697 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11698 messages.
11699
f61f41d7
PE
117002011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11701
11702 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11703 change.
11704
96fb4434
PE
117052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11706
11707 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11708 This makes this file independent of the recent pseudovector change.
11709
671875da 117102011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11711
69e9b5a3
PE
11712 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11713
b5f869a7 11714 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11715 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11716 Remove unused local.
c8926152 11717 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11718
841a1577 11719 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11720 GCC 4.6.0 optimizes based on type-based alias analysis.
11721 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11722 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11723 != &v->size, and therefore "v->size = 1; b->size = 2; return
11724 v->size;" must therefore return 1. This assumption is incorrect
11725 for Emacs, since it type-puns struct Lisp_Vector * with many other
11726 types. To fix this problem, this patch adds a new type struct
f904488f 11727 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11728 and pseudovectors, and helps optimizing compilers not get fooled
11729 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11730 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11731 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11732 the size member.
eab3844f
PE
11733 (XSETPVECTYPE): Rewrite in terms of new macro.
11734 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11735 This is a bit clearer, and further avoids the possibility of
11736 undesirable aliasing.
11737 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11738 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11739 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11740 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11741 (ASIZE): Now uses header.size rather than size.
11742 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11743 to avoid the hassle of writing XVECTOR (foo)->header.size.
11744 (struct vectorlike_header): New type.
eab3844f
PE
11745 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11746 object, to help avoid aliasing.
11747 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11748 (SUBRP): Likewise, since Lisp_Subr is a special case.
11749 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11750 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11751 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11752 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11753 changed to be "header.size" and "header.next".
11754 * buffer.h (struct buffer): Likewise.
11755 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11756 * frame.h (struct frame): Likewise.
11757 * process.h (struct Lisp_Process): Likewise.
11758 * termhooks.h (struct terminal): Likewise.
11759 * window.c (struct save_window_data, struct saved_window): Likewise.
11760 * window.h (struct window): Likewise.
11761 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11762 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11763 * buffer.c (init_buffer_once): Likewise.
11764 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11765 special case.
11766 * process.c (Fformat_network_address): Use local var for size,
11767 for brevity.
11768
0df1eac5
PE
11769 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11770
847ab9d1 11771 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11772 * data.c (atof): Remove decl; no longer used or needed.
11773 (digit_to_number): Move to lread.c.
11774 (Fstring_to_number): Use new string_to_number function, to be
11775 consistent with how the Lisp reader treats infinities and NaNs.
11776 Do not assume that floating-point numbers represent EMACS_INT
11777 without losing information; this is not true on most 64-bit hosts.
11778 Avoid double-rounding errors, by insisting on integers when
11779 parsing non-base-10 numbers, as the documentation specifies.
11780 * lisp.h (string_to_number): New decl, replacing ...
11781 (isfloat_string): Remove.
bc0a5c13 11782 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11783 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11784 appears to have been a coding error. Similarly, do not accept
11785 strings like +-1e0 as floating point numbers. Do not report
11786 overflow for integer overflows unless the base is not 10 which
11787 means we have no simple and reliable way to continue.
11788 Break out the floating-point parsing into a new
11789 function string_to_number, so that Fstring_to_number parses
11790 floating point numbers consistently with the Lisp reader.
04f2d78b 11791 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11792 (E_CHAR, EXP_INT): Remove, replacing with ...
11793 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11794 (string_to_number): New function, replacing isfloat_string.
11795 This function checks for valid syntax and produces the resulting
11796 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11797 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11798 so that overflow for non-base-10 numbers is reported only when
11799 there's no portable and simple way to convert to floating point.
452f4150 11800
67769ffc
PE
11801 * textprop.c (set_text_properties_1): Rewrite for clarity,
11802 and to avoid GCC warning about integer overflow.
11803
c20db43f
PE
11804 * intervals.h (struct interval): Use EMACS_INT for members
11805 where EMACS_UINT might cause problems. See
11806 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11807 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11808 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11809 All uses changed.
37aa2f85
PE
11810 (offset_intervals): Tell GCC not to worry about length overflow
11811 when negating a negative length.
c20db43f 11812
2538aa2f
PE
11813 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11814 (overrun_check_free): Likewise.
11815
f2d3008d
PE
11816 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11817 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11818 word size.
11819
ec8df744
PE
11820 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11821 (gnutls_make_error): Rename local to avoid shadowing.
11822 (gnutls_emacs_global_deinit): ifdef out; not used.
11823 (Fgnutls_boot): Use const for pointer to readonly storage.
11824 Comment out unused local. Fix pointer signedness problems.
11825
640ee02d
PE
11826 * lread.c (openp): Don't stuff size_t into an 'int'.
11827 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11828 about possible signed overflow.
11829
6048fb2a
PE
11830 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11831 (GDK_KEY_g): Don't define if already defined.
11832 (xg_prepare_tooltip): Avoid pointer signedness problem.
11833 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11834
fa3c87e1
PE
11835 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11836 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11837
2172544b
PE
11838 * xfns.c (Fx_window_property): Simplify a bit,
11839 to make a bit faster and to avoid GCC 4.6.0 warning.
11840 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11841
9b821a21
PE
11842 * fns.c (internal_equal): Don't assume size_t fits in int.
11843
3c616cfa
PE
11844 * alloc.c (compact_small_strings): Tighten assertion a little.
11845
c2982e87
PE
11846 Replace pEd with more-general pI, and fix some printf arg casts.
11847 * lisp.h (pI): New macro, generalizing old pEd macro to other
11848 conversion specifiers. For example, use "...%"pI"d..." rather
11849 than "...%"pEd"...".
11850 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11851 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11852 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11853 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11854 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11855 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11856 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11857 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11858 64-bit hosts.
11859 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11860 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11861 * print.c (safe_debug_print, print_object): Likewise.
11862 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11863 to int.
6f04d126
PE
11864 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11865 avoiding the 0 flag, which is not portable.
c2982e87
PE
11866 * process.c (Fmake_network_process): Use pI to avoid cast.
11867 * region-cache.c (pp_cache): Likewise.
11868 * xdisp.c (decode_mode_spec): Likewise.
11869 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11870 behavior on 64-bit hosts with printf arg.
6f04d126 11871 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11872 (x_stop_queuing_selection_requests): Likewise.
11873 (x_get_window_property): Don't truncate byte count to an 'int'
11874 when tracing.
0b432f21 11875
5e073ec7
PE
11876 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11877 here, since it parses constructs like leading '-' and spaces,
11878 which are not wanted; and it overflows with large numbers.
11879 Instead, simply match F[0-9]+, which is what is wanted anyway.
11880
36372bf9
PE
11881 * alloc.c: Remove unportable assumptions about struct layout.
11882 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11883 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11884 (allocate_vectorlike, make_pure_vector): Use the new macros,
11885 plus offsetof, to remove unportable assumptions about struct layout.
11886 These assumptions hold on all porting targets that I know of, but
11887 they are not guaranteed, they're easy to remove, and removing them
11888 makes further changes easier.
11889
0b432f21
PE
11890 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11891 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11892 (string_overrun_cookie): Now const. Use initializers that
11893 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11894 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11895 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11896 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11897 multiple of sizeof (EMACS_INT); it need not be, if
11898 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11899 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11900
895009e1
JB
119012011-04-26 Juanma Barranquero <lekktu@gmail.com>
11902
11903 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11904
6a7a1b0b
TZ
119052011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11906
11907 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11908 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11909 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11910
841a1577 119112011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11912
11913 * lisp.h (Qdebug): List symbol.
895009e1 11914 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11915 * keyboard.c (debug-on-event): New variable.
11916 (handle_user_signal): Break into debugger when debug-on-event
11917 matches the current signal symbol.
11918
f2d3ba6f
DN
119192011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11920
11921 * alloc.c (check_sblock, check_string_bytes)
11922 (check_string_free_list): Convert to standard C.
11923
42ce4c63
TZ
119242011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11925
11926 * w32.c (emacs_gnutls_push): Fix typo.
11927
825cd63c
EZ
119282011-04-25 Eli Zaretskii <eliz@gnu.org>
11929
fb11d64d
EZ
11930 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11931 "cast to pointer from integer of different size".
11932
825cd63c
EZ
11933 Improve doprnt and its use in verror. (Bug#8545)
11934 * doprnt.c (doprnt): Document the set of format control sequences
11935 supported by the function. Use SAFE_ALLOCA instead of always
11936 using `alloca'.
11937
11938 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11939 is one byte too soon. Don't use xrealloc; instead xfree and
11940 xmalloc anew.
11941
e061a11b
TZ
119422011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11943
11944 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11945 callbacks stage.
11946
11947 * gnutls.c: Renamed global_initialized to
11948 gnutls_global_initialized. Added internals for the
11949 :verify-hostname-error, :verify-error, and :verify-flags
11950 parameters of `gnutls-boot' and documented those parameters in the
11951 docstring. Start callback support.
9173deec
JB
11952 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11953 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11954 on error. Return error code.
e061a11b
TZ
11955 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11956 (emacs_gnutls_read): Likewise.
11957 (Fgnutls_boot): Return handshake error code.
11958 (emacs_gnutls_handle_error): New function.
11959 (wsaerror_to_errno): Likewise.
11960
11961 * w32.h (emacs_gnutls_pull): Add prototype.
11962 (emacs_gnutls_push): Likewise.
11963
11964 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11965 (emacs_gnutls_push): Likewise.
11966
119672011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11968
11969 * process.c (wait_reading_process_output): Check if GnuTLS
11970 buffered some data internally if no FDs are set for TLS
11971 connections.
11972
11973 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11974 (LIBS): Link to USER_LIBS.
11975 ($(BLD)/gnutls.$(0)): New target.
11976
fa6996bc
EZ
119772011-04-24 Eli Zaretskii <eliz@gnu.org>
11978
eb35682e
EZ
11979 * xdisp.c (handle_single_display_spec): Rename the
11980 display_replaced_before_p argument into display_replaced_p, to
11981 make it consistent with the commentary. Fix typos in the
11982 commentary.
11983
e2ad650c
EZ
11984 * textprop.c (syms_of_textprop): Remove dead code.
11985 (copy_text_properties): Delete obsolete commentary about an
11986 interface that was deleted long ago. Fix typos in the description
11987 of arguments.
11988
1b2de274
EZ
11989 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11990 to changes in oldXMenu/XMenu.h from 2011-04-16.
11991 <menu_help_message, prev_menu_help_message>: Constify.
11992 (IT_menu_make_room): menu->help_text is now `const char **';
11993 adjust.
11994
11995 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11996 to changes in oldXMenu/XMenu.h from 2011-04-16.
11997 (struct XMenu): Declare `help_text' `const char **'.
11998
11999 * xfaces.c <Qunspecified>: Make extern again.
12000
12001 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12002 required by POSIX.
1b2de274 12003
762b15be
EZ
12004 * doc.c (get_doc_string): Improve the format passed to `error'.
12005
12006 * doprnt.c (doprnt): Improve commentary.
12007
12008 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12009
12010 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12011 them with etags.
12012
f1052e5d
EZ
12013 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12014 changes in globals.h immediately force recompilation.
762b15be
EZ
12015 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12016 $(CURDIR)/s/ms-w32.h.
12017 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12018
fa6996bc
EZ
12019 * character.c (Fchar_direction): Function deleted.
12020 (syms_of_character): Don't defsubr it.
12021 <char-direction-table>: Deleted.
12022
e6c3da20
EZ
120232011-04-23 Eli Zaretskii <eliz@gnu.org>
12024
12025 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12026 * doprnt.c: Include limits.h.
12027 (SIZE_MAX): New macro.
04f2d78b
CB
12028 (doprnt): Return a size_t value. 2nd arg is now size_t.
12029 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12030 Improve overflow protection. Support `l' modifier for integer
12031 conversions. Support %l conversion. Don't assume an EMACS_INT
12032 argument for integer conversions and for %c.
12033
12034 * lisp.h (doprnt): Restore prototype.
12035
12036 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12037 $(SRC)/character.h.
12038
12039 * Makefile.in (base_obj): Add back doprnt.o.
12040
12041 * deps.mk (doprnt.o): Add back prerequisites.
12042 (callint.o): Depend on character.h.
12043
12044 * eval.c (internal_lisp_condition_case): Include the handler
12045 representation in the error message.
12046 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12047 when breaking from the loop.
12048
12049 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12050
12051 * callint.c (Fcall_interactively): When displaying error message
12052 about invalid control letter, pass the character's codepoint, not
12053 a pointer to its multibyte form. Improve display of the character
12054 in octal and display also its hex code.
12055
12056 * character.c (char_string): Use %x to display the (unsigned)
12057 codepoint of an invalid character, to avoid displaying a bogus
12058 negative value.
12059
12060 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12061 `error', not SYMBOL_NAME itself.
12062
12063 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12064 character arguments to `error'.
12065
12066 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12067 to `error' in error message about FINAL_CHAR argument. Make sure
12068 FINAL_CHAR is a character, and use %c when it is passed as
12069 argument to `error'.
12070
4ffd0d6b 120712011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12072
12073 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12074
12075 * w32.c: Include <time.h>.
12076 (sys_localtime): New function.
12077
4ffd0d6b 120782011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12079
12080 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12081
4ffd0d6b 12082 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12083
4ffd0d6b 120842011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12085
4ffd0d6b
GM
12086 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12087 zombies (Bug#8467).
aac0c6e3 12088
04c56954
EZ
120892011-04-19 Eli Zaretskii <eliz@gnu.org>
12090
12091 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12092 gl_state.e_property when gl_state.object is Qt.
12093
12094 * insdel.c (make_gap_larger): Remove limitation of buffer size
12095 to <= INT_MAX.
12096
16a43933
CY
120972011-04-18 Chong Yidong <cyd@stupidchicken.com>
12098
12099 * xdisp.c (lookup_glyphless_char_display)
12100 (produce_glyphless_glyph): Handle cons cell entry in
12101 glyphless-char-display.
12102 (Vglyphless_char_display): Document it.
12103
12104 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12105 glyphless-char-display.
12106
4581706e
CY
121072011-04-17 Chong Yidong <cyd@stupidchicken.com>
12108
12109 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12110
12111 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12112
12113 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12114 definition for no-X builds.
12115
4887c6e2 121162011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12117
fd35b6f9
PE
12118 Static checks with GCC 4.6.0 and non-default toolkits.
12119
5c1ccb01
PE
12120 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12121
006c5daa
PE
12122 * process.c (keyboard_bit_set): Define only if SIGIO.
12123 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12124 (send_process): Repair possible setjmp clobbering.
12125
efc736d3
PE
12126 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12127
4e2fe2e6
PE
12128 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12129
f97334a2
PE
12130 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12131
4e75f29d
PE
12132 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12133 Define only if needed.
12134
90efadd1
PE
12135 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12136 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12137 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12138
3c647824
PE
12139 * dispextern.h (struct redisplay_interface): Rename param
12140 to avoid shadowing.
e264f262 12141 * termhooks.h (struct terminal): Likewise.
761383f4 12142 * xterm.c (xembed_send_message): Likewise.
3c647824 12143
b58c5c4a
PE
12144 * insdel.c (make_gap_smaller): Define only if
12145 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12146
cad59032
PE
12147 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12148 it.
12149
c339dc2e
PE
12150 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12151 so that we aren't warned about unused symbols.
12152
91a3e27b
PE
12153 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12154
399c71d3 12155 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12156
8ffc96f5
PE
12157 * xfns.c (x_real_positions): Mark locals as initialized.
12158
eef9bc79
PE
12159 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12160
098db9dd
PE
12161 * xterm.c: Fix problems found by static analysis with other toolkits.
12162 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12163 (x_dispatch_event): Declare static if USE_GTK, and
12164 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12165 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12166 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12167 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12168 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12169
eb18f6cc
PE
12170 * xmenu.c (menu_help_callback): Pointer type fixes.
12171 Use const pointers when pointing at readonly data. Avoid pointer
12172 signedness clashes.
12173 (FALSE): Remove unused macro.
12174 (update_frame_menubar): Remove unused decl.
12175
1fe72bf8
PE
12176 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12177
60d9e1db
PE
12178 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12179 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12180 (single_menu_item): Rename local to avoid shadowing.
12181
39261c26
PE
12182 * keyboard.c (make_lispy_event): Remove unused local var.
12183
018c5e19
PE
12184 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12185 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12186
63d2b86e
PE
12187 * bitmaps: Change bitmaps from unsigned char back to the X11
12188 compatible char. Avoid the old compiler warnings about
12189 out-of-range initializers by using, for example, '\xab' rather
12190 than 0xab.
12191
aefd87e1
PE
12192 * xgselect.c (xgselect_initialize): Check vs interface
12193 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12194
bf501fb9
PE
12195 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12196
e9829fdf
PE
12197 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12198 to read-only memory.
12199
1086c095
PE
12200 * fns.c (vector): Remove; this old hack is no longer needed.
12201
2baccd04 12202 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12203 Remove unused var.
dde42981 12204 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12205
72391843 12206 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12207
436c16df 12208 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12209 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12210 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12211
92bb796d 12212 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12213 (x_term_init): Remove local to avoid shadowing.
92bb796d 12214
764430a3 12215 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12216
12217 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12218 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12219
d1dfb56c
EZ
122202011-04-16 Eli Zaretskii <eliz@gnu.org>
12221
c4354cb4
EZ
12222 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12223
d1dfb56c
EZ
12224 Fix regex.c, syntax.c and friends for buffers > 2GB.
12225 * syntax.h (struct gl_state_s): Declare character position members
12226 EMACS_INT.
12227
12228 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12229
04f2d78b
CB
12230 * textprop.c (verify_interval_modification, interval_of):
12231 Declare arguments EMACS_INT.
d1dfb56c
EZ
12232
12233 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12234 EMACS_INT.
12235
12236 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12237
12238 * indent.c (Fvertical_motion): Local variable it_start is now
12239 EMACS_INT.
12240
12241 * regex.c (re_match, re_match_2, re_match_2_internal)
12242 (bcmp_translate, regcomp, regexec, print_double_string)
12243 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12244 (re_compile_pattern, re_exec): Declare arguments and local
12245 variables `size_t' and `ssize_t' and return values `regoff_t', as
12246 appropriate.
12247 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12248 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12249 <compile_stack_type>: `size' and `avail' are now `size_t'.
12250
12251 * regex.h <regoff_t>: Use ssize_t, not int.
12252 (re_search, re_search_2, re_match, re_match_2): Arguments that
12253 specify buffer/string position and length are now ssize_t and
12254 size_t. Return type is regoff_t.
12255
613052cd
BK
122562011-04-16 Ben Key <bkey76@gmail.com>
12257
12258 * nsfont.m: Fixed bugs in ns_get_family and
12259 ns_descriptor_to_entity that were caused by using free to
12260 deallocate memory blocks that were allocated by xmalloc (via
12261 xstrdup). This caused Emacs to crash when compiled with
12262 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12263 --enable-checking=xmallocoverrun). xfree is now used to
12264 deallocate these memory blocks.
12265
4170f62f 122662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12267
71b41406
PE
12268 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12269
9587a89d
PE
12270 emacs_write: Accept and return EMACS_INT for sizes.
12271 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12272 et seq.
12273 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12274 Accept and return EMACS_INT.
12275 (emacs_gnutls_write): Return the number of bytes written on
12276 partial writes.
12277 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12278 (emacs_read, emacs_write): Remove check for negative size, as the
12279 Emacs source code has been audited now.
9587a89d
PE
12280 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12281 (emacs_read, emacs_write): Use it.
273a5f82
PE
12282 * process.c (send_process): Adjust to the new signatures of
12283 emacs_write and emacs_gnutls_write. Do not attempt to store
12284 a byte offset into an 'int'; it might overflow.
9587a89d 12285 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12286
3e047f51
PE
12287 * sound.c: Don't assume sizes fit in 'int'.
12288 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12289 Return EMACS_INT, not int.
3e047f51 12290 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12291 Accept EMACS_INT, not int.
12292 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12293 record read return values.
12294
cc39a9db
BK
122952011-04-15 Ben Key <bkey76@gmail.com>
12296
c9d0ec6d
JB
12297 * keyboard.c (Qundefined): Don't declare static since it is used
12298 in nsfns.m.
12299 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12300 static since they are used in nsfont.m.
cc39a9db 12301
6c60eb9f
SM
123022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12303
12304 * process.c (Qprocessp): Don't declare static.
12305 * lisp.h (Qprocessp): Declare again.
12306
7990b61a
JB
123072011-04-15 Juanma Barranquero <lekktu@gmail.com>
12308
12309 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12310
5d4cb038
PE
123112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12312
8bd7b830 12313 Improve C-level modularity by making more things 'static'.
cd64ea1d 12314
e3b27b31
PE
12315 Don't publish debugger-only interfaces to other modules.
12316 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12317 (verify_bytepos, count_markers): Move decls to the only modules
12318 that need them.
12319 * region-cache.h (pp_cache): Likewise.
12320 * window.h (check_all_windows): Likewise.
12321 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12322
5d4cb038
PE
12323 * sysdep.c (croak): Now static, if
12324 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12325 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12326
12327 * alloc.c (refill_memory_reserve): Now static if
12328 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12329 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12330
e87b6180
PE
12331 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12332 Define only if USE_LUCID.
12333
ac64929e
PE
12334 * xrdb.c (x_customization_string, x_rm_string): Now static.
12335
6f37259d
PE
12336 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12337 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12338
1683e3ab
PE
12339 * xdisp.c (draw_row_with_mouse_face): Now static.
12340 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12341
de9c2632
PE
12342 * window.h (check_all_windows): Mark externally visible.
12343
2b96acb7
PE
12344 * window.c (window_deletion_count): Now static.
12345
12346 * undo.c: Make symbols static if they're not exported.
12347 (last_undo_buffer, last_boundary_position, pending_boundary):
12348 Now static.
12349
50436f33
PE
12350 * textprop.c (interval_insert_behind_hooks): Now static.
12351 (interval_insert_in_front_hooks): Likewise.
12352
64520e5c
PE
12353 * term.c: Make symbols static if they're not exported.
12354 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12355 (max_frame_lines, tty_set_terminal_modes):
12356 (tty_reset_terminal_modes, tty_turn_off_highlight):
12357 (get_tty_terminal): Now static.
12358 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12359 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12360 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12361 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12362 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12363
1fa53021
PE
12364 * sysdep.c: Make symbols static if they're not exported.
12365 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12366 Now static.
12367 (sigprocmask_set, full_mask): Remove; unused.
12368 (wait_debugging): Mark as visible.
12369 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12370 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12371
d4b43b22
PE
12372 * syntax.c (syntax_temp): Define only if !__GNUC__.
12373
b7c513d0
PE
12374 * sound.c (current_sound_device, current_sound): Now static.
12375
989b29ad
PE
12376 * search.c (searchbufs, searchbuf_head): Now static.
12377
13a55a78
PE
12378 * scroll.c (scroll_cost): Remove; unused.
12379 * dispextern.h (scroll_cost): Remove decl.
12380
de68a1fc
PE
12381 * region-cache.h (pp_cache): Mark as externally visible.
12382
40ccffa6
PE
12383 * process.c: Make symbols static if they're not exported.
12384 (process_tick, update_tick, create_process, chan_process):
12385 (Vprocess_alist, proc_buffered_char, datagram_access):
12386 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12387 (deactivate_process): Mark defn as static, as well as decl.
12388 * lisp.h (create_process): Remove decl.
12389 * process.h (chan_process, Vprocess_alist): Remove decls.
12390
ad64fc97
PE
12391 * print.c: Make symbols static if they're not exported.
12392 (print_depth, new_backquote_output, being_printed, print_buffer):
12393 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12394 (print_interval, print_number_index, initial_stderr_stream):
12395 Now static.
12396 * lisp.h (Fprinc): Remove decl.
12397 (debug_output_compilation_hack): Mark as externally visible.
12398
adddb265
PE
12399 * sysdep.c (croak): Move decl from here to syssignal.h.
12400 * syssignal.h (croak): Put it here, so the API can be checked when
12401 'croak' is called from dissociate_if_controlling_tty.
12402
1717ede2
PE
12403 * minibuf.c: Make symbols static if they're not exported.
12404 (minibuf_save_list, choose_minibuf_frame): Now static.
12405 * lisp.h (choose_minibuf_frame): Remove decl.
12406
fa5fb2bc
PE
12407 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12408
1e3890d1
PE
12409 * lread.c: Make symbols static if they're not exported.
12410 (read_objects, initial_obarray, oblookup_last_bucket_number):
12411 Now static.
12412 (make_symbol): Remove; unused.
12413 * lisp.h (initial_obarray, make_symbol): Remove decls.
12414
8a1414fa
PE
12415 * keyboard.c: Make symbols static if they're not exported.
12416 (single_kboard, recent_keys_index, total_keys, recent_keys):
12417 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12418 (this_single_command_key_start, echoing, last_auto_save):
12419 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12420 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12421 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12422 (Vlispy_mouse_stem, double_click_count):
12423 Now static.
12424 (force_auto_save_soon): Define only if SIGDANGER.
12425 (ignore_mouse_drag_p): Now static if
12426 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12427 (print_help): Remove; unused.
12428 (stop_character, last_timer_event): Mark as externally visible.
12429 * keyboard.h (ignore_mouse_drag_p): Declare only if
12430 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12431 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12432 * lisp.h (echoing): Remove decl.
12433 (force_auto_save_soon): Declare only if SIGDANGER.
12434 * xdisp.c (redisplay_window): Simplify code, to make it more
12435 obvious that ignore_mouse_drag_p is not accessed if !defined
12436 USE_GTK && !defined HAVE_NS.
12437
93ea6e8f
PE
12438 * intervals.c: Make symbols static if they're not exported.
12439 (merge_properties_sticky, merge_interval_right, delete_interval):
12440 Now static.
12441 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12442
77382fcc
PE
12443 * insdel.c: Make symbols static if they're not exported.
12444 However, leave prepare_to_modify_buffer alone. It's never
12445 called from outside this function, but that appears to be a bug.
12446 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12447 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12448 (adjust_after_replace_noundo): Remove; unused.
12449 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12450 (signal_before_change): Remove decls.
77382fcc 12451
9306c32e
PE
12452 * indent.c (val_compute_motion, val_vmotion): Now static.
12453
cd44d2eb
PE
12454 * image.c: Make symbols static if they're not exported.
12455 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12456 if USE_GTK.
12457 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12458 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12459
ad9a7a06
PE
12460 * fringe.c (standard_bitmaps): Now static.
12461 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12462
81626931
PE
12463 * frame.c: Make symbols static if they're not exported.
12464 (x_report_frame_params, make_terminal_frame): Now static.
12465 (get_frame_param): Now static, unless HAVE_NS.
12466 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12467 (x_get_resource_string): Remove; not used.
12468 * frame.h (make_terminal_frame, x_report_frame_params):
12469 (x_get_resource_string); Remove decls.
12470 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12471 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12472
239f9db9
PE
12473 * font.c, fontset.c: Make symbols static if they're not exported.
12474 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12475 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12476 * font.c (font_close_object): Now static.
12477 * font.h (font_close_object): Remove.
12478 * fontset.c (FONTSET_OBJLIST): Remove.
12479 (free_realized_fontset) #if-0 the body, which does nothing.
12480 (face_suitable_for_char_p): #if-0, as it's never called.
12481 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12482 * xfaces.c (face_at_string_position):
12483 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12484 since 0 is always ASCII.
12485
dfcf3579
PE
12486 * fns.c (weak_hash_tables): Now static.
12487
5045092b
PE
12488 * fileio.c: Make symbols static if they're not exported.
12489 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12490 (Vwrite_region_annotation_buffers): Now static.
12491
57a96f5c
PE
12492 * eval.c: Make symbols static if they're not exported.
12493 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12494 * lisp.h (backtrace_list): Remove decl.
12495
35f08c38
PE
12496 * emacs.c: Make symbols static if they're not exported.
12497 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12498 (fatal_error_code, fatal_error_signal_hook, standard_args):
12499 Now static.
12500 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12501 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12502 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12503 * lisp.h (fatal_error_signal_hook): Remove decl.
12504 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12505
f44bd759
PE
12506 * editfns.c: Move a (normally-unused) function to its only use.
12507 * editfns.c, lisp.h (get_operating_system_release): Remove.
12508 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12509 worth the hassle of breaking this out.
12510
b532497d
PE
12511 * xterm.c: Make symbols static if they're not exported.
12512 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12513 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12514 (x_destroy_window, x_delete_display):
12515 Now static.
12516 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12517 (x_mouse_leave): Remove; unused.
12518 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12519 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12520 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12521 Remove decls.
12522 (x_mouse_leave): Declare only if WINDOWSNT.
12523 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12524 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12525 USE_X_TOOLKIT.
12526
1675728f
PE
12527 * ftxfont.c: Make symbols static if they're not exported.
12528 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12529 HAVE_FREETYPE.
12530 * font.h (ftxfont_driver): Likewise.
12531
e4cebfca
PE
12532 * xfns.c: Make symbols static if they're not exported.
12533 (x_last_font_name, x_display_info_for_name):
12534 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12535 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12536 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12537 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12538 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12539 (last_show_tip_args): Now static.
12540 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12541 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12542 (x_screen_planes): Remove; unused.
12543 * dispextern.h (x_screen_planes): Remove decl.
12544
5bf46f05
PE
12545 * dispnew.c: Make symbols static if they're not exported.
12546 * dispextern.h (redraw_garbaged_frames, scrolling):
12547 (increment_row_positions): Remove.
12548 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12549 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12550 Now static.
12551 (redraw_garbaged_frames): Remove; unused.
12552
435f4c28
PE
12553 * xfaces.c: Make symbols static if they're not exported.
12554 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12555 Remove decls.
12556 * xterm.h (defined_color): Remove decls.
12557 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12558 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12559 (menu_face_changed_default, defined_color, free_realized_face):
12560 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12561 (ascii_face_of_lisp_face): Remove; unused.
12562
8524aef3
PE
12563 * xdisp.c: Make symbols static if they're not exported.
12564 * dispextern.h (scratch_glyph_row, window_box_edges):
12565 (glyph_to_pixel_coords, set_cursor_from_row):
12566 (get_next_display_element, set_iterator_to_next):
12567 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12568 (show_mouse_face): Remove decls
12569 * frame.h (message_buf_print): Likewise.
12570 * lisp.h (pop_message, set_message, check_point_in_composition):
12571 Likewise.
12572 * xterm.h (set_vertical_scroll_bar): Likewise.
12573 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12574 (message_buf_print, scratch_glyph_row, displayed_buffer):
12575 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12576 (get_next_display_element, show_mouse_face, window_box_edges):
12577 (frame_to_window_pixel_xy, check_point_in_composition):
12578 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12579 (glyph_to_pixel_coords): Remove; unused.
12580
16390cd2
PE
12581 * dired.c (file_name_completion): Now static.
12582
12583 * dbusbind.c (xd_in_read_queued_messages): Now static.
12584
a25f4dfa
PE
12585 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12586 * data.c (circular_list_error): Remove.
12587
14a9c8df
PE
12588 * commands.h (last_point_position, last_point_position_buffer):
12589 (last_point_position_window): Remove decls.
12590 * keyboard.c: Make these variables static.
12591
04f2d78b
CB
12592 * coding.h (coding, code_convert_region, encode_coding_gap):
12593 Remove decls.
74ab6df5
PE
12594 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12595 (iso_code_class, detect_coding, code_convert_region): Now static.
12596 (encode_coding_gap): Remove; unused.
12597
38dfbee1
PE
12598 * chartab.c (chartab_chars, chartab_bits): Now static.
12599
a2cb4e63
PE
12600 * charset.h (charset_iso_8859_1): Remove decl.
12601 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12602 Now static.
12603
127198fd
PE
12604 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12605 * ccl.c (Vccl_program_table): Now static.
12606 (check_ccl_update): Remove; unused.
12607
d85b608f
PE
12608 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12609 * category.h: ... from here.
12610 * category.c (check_category_table, set_category_set): Now static.
12611
31cd66f3
PE
12612 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12613 * lisp.h: Remove these decls.
12614
c358e587
PE
12615 * buffer.c (buffer_count): Remove unused var.
12616
e78aecca
PE
12617 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12618 so that it's not optimized away.
12619 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12620 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12621 exported only to the debugger.
12622
e192d7d3 12623 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12624 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12625
92470028
PE
12626 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12627 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12628 was inaccessible from Lisp.
12629 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12630 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12631
244ed907
PE
12632 alloc.c: Import and export fewer symbols, and remove unused items.
12633 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12634 is defined.
12635 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12636 it's not optimized away by whole-program optimization.
12637 (message_enable_multibyte, free_misc): Remove.
12638 (catchlist, handlerlist, mark_backtrace):
12639 Declare only if BYTE_MARK_STACK.
12640 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12641 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12642 (message_enable_multibyte): Remove decl.
12643 (free_misc, interval_free_list, float_block, float_block_index):
12644 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12645 (cons_free_list, last_marked_index):
12646 Now static.
12647 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12648 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12649 (mark_backtrace): Define only if BYTE_MARK_STACK.
12650 * xdisp.c (message_enable_multibyte): Now static.
12651
61c2b50e 12652 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12653 This makes it easier for human readers (and static analyzers)
12654 to see whether these variables are used from other modules.
12655 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12656 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12657 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12658 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12659 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12660 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12661 * xmenu.c, xselect.c:
12662 Declare Q* vars static if they are not used in other modules.
12663 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12664 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12665 Remove decls of unexported vars.
12666 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12667
95c82688
PE
12668 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12669
16a97296
PE
12670 Make Emacs functions such as Fatom 'static' by default.
12671 This makes it easier for human readers (and static analyzers)
12672 to see whether these functions can be called from other modules.
12673 DEFUN now defines a static function. To make the function external
12674 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12675 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12676 (Finit_image_library):
16a97296
PE
12677 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12678 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12679 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12680 Remove decls, since these functions are now static.
12681 (Funintern, Fget_internal_run_time): New decls, since these functions
12682 were already external.
95c82688 12683
16a97296
PE
12684 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12685 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12686 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12687 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12688 * keyboard.c, keymap.c, lread.c:
12689 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12690 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12691 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12692 Mark functions with DEFUE instead of DEFUN,
12693 if they are used in other modules.
12694 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12695 decls for now-static functions.
12696 * buffer.h (Fdelete_overlay): Remove decl.
12697 * callproc.c (Fgetenv_internal): Mark as internal.
12698 * composite.c (Fremove_list_of_text_properties): Remove decl.
12699 (Fcomposition_get_gstring): New forward static decl.
12700 * composite.h (Fcomposite_get_gstring): Remove decl.
12701 * dired.c (Ffile_attributes): New forward static decl.
12702 * doc.c (Fdocumntation_property): New forward static decl.
12703 * eval.c (Ffetch_bytecode): New forward static decl.
12704 (Funintern): Remove extern decl; now in .h file where it belongs.
12705 * fileio.c (Fmake_symbolic_link): New forward static decl.
12706 * image.c (Finit_image_library): New forward static decl.
12707 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12708 * intervals.h (Fprevious_property_change):
12709 (Fremove_list_of_text_properties): Remove decls.
12710 * keyboard.c (Fthis_command_keys): Remove decl.
12711 (Fcommand_execute): New forward static decl.
12712 * keymap.c (Flookup_key): New forward static decl.
12713 (Fcopy_keymap): Now static.
12714 * keymap.h (Flookup_key): Remove decl.
12715 * process.c (Fget_process): New forward static decl.
12716 (Fprocess_datagram_address): Mark as internal.
12717 * syntax.c (Fsyntax_table_p): New forward static decl.
12718 (skip_chars): Remove duplicate decl.
12719 * textprop.c (Fprevious_property_change): New forward static decl.
12720 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12721 Now internal.
12722 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12723 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12724
785bbd42
PE
12725 * editfns.c (Fformat): Remove unreachable code.
12726
8b913b57
AS
127272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12728
12729 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12730 change. (Bug#8496)
12731
a6744a35
EZ
127322011-04-13 Eli Zaretskii <eliz@gnu.org>
12733
12734 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12735 when at ZV. (Bug#8487)
12736
e7974947
AS
127372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12738
baad03f0
AS
12739 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12740 (Bug#8437)
12741 * keyboard.c (parse_tool_bar_item): Likewise.
12742 * sound.c (sound_cleanup, alsa_close): Likewise.
12743 * termcap.c (tgetent): Likewise.
12744 * xfns.c (x_default_font_parameter): Likewise.
12745 * xsettings.c (read_and_apply_settings): Likewise.
12746
e7974947
AS
12747 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12748 (overrun_check_free): Protoize.
12749
28272684
PE
127502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12751
12752 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12753 since callers should never pass a negative size.
12754 Change the signature to match that of plain 'read' and 'write'; see
12755 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12756 * lisp.h: Update prototypes of emacs_write and emacs_read.
12757
11997c76
EZ
127582011-04-11 Eli Zaretskii <eliz@gnu.org>
12759
12760 * xdisp.c (redisplay_window): Don't try to determine the character
12761 position of the scroll margin if the window start point w->startp
e896f03c 12762 is outside the buffer's accessible region. (Bug#8468)
11997c76 12763
8a2cbd72
EZ
127642011-04-10 Eli Zaretskii <eliz@gnu.org>
12765
12766 Fix write-region and its subroutines for buffers > 2GB.
12767 * fileio.c (a_write, e_write): Modify declaration of arguments and
12768 local variables to support buffers larger than 2GB.
12769 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12770
12771 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12772 argument, local variables, and return value.
12773
12774 * lisp.h: Update prototypes of emacs_write and emacs_read.
12775
12776 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12777
4073e537 127782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12779
1ebfdcb6
PE
12780 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12781
b2ded58d
PE
12782 Fix more problems found by GCC 4.6.0's static checks.
12783
7d66342c
PE
12784 * xdisp.c (vmessage): Use a better test for character truncation.
12785
bbf47d44
PE
12786 * charset.c (load_charset_map): <, not <=, for optimization,
12787 and to avoid potential problems with integer overflow.
9248994d 12788 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12789 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12790 * editfns.c (Fformat): Likewise.
1e69125e 12791 * syntax.c (skip_chars): Likewise.
3befa583 12792
e3019616
PE
12793 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12794 This also lets GCC 4.6.0 generate slightly better loop code.
12795
becfa255
PE
12796 * callint.c (Fcall_interactively): <, not <=, for optimization.
12797 (Fcall_interactively): Count the number of arguments produced,
12798 not the number of arguments given. This is simpler and lets GCC
12799 4.6.0 generate slightly better code.
12800
dae0cd48
PE
12801 * ftfont.c: Distingish more carefully between FcChar8 and char.
12802 The previous code passed unsigned char * to a functions like
12803 strlen and xstrcasecmp that expect char *, which does not
12804 conform to the C standard.
12805 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12806 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12807 char * when the C standard requires it.
12808
76032d70
PE
12809 * keyboard.c (read_char): Remove unused var.
12810
eb3f1cc8
PE
12811 * eval.c: Port to Windows vsnprintf (Bug#8435).
12812 Include <limits.h>.
12813 (SIZE_MAX): Define if the headers do not.
12814 (verror): Do not give up if vsnprintf returns a negative count.
12815 Instead, grow the buffer. This ports to Windows vsnprintf, which
12816 does not conform to C99. Problem reported by Eli Zaretskii.
12817 Also, simplify the allocation scheme, by avoiding the need for
12818 calling realloc, and removing the ALLOCATED variable.
12819
70476b54
PE
12820 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12821
12020a9e
PE
12822 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12823 But keep the doprint source code for now, as we might revamp it
12824 and use it again (Bug#8435).
ea6c7ae6
PE
12825 * lisp.h (doprnt): Remove.
12826 * Makefile.in (base_obj): Remove doprnt.o.
12827 * deps.mk (doprnt.o): Remove.
12828
5fdb398c
PE
12829 error: Print 32- and 64-bit integers portably (Bug#8435).
12830 Without this change, on typical 64-bit hosts error ("...%d...", N)
12831 was used to print both 32- and 64-bit integers N, which relied on
12832 undefined behavior.
61bdb816 12833 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12834 * lisp.h (error, verror): Mark as printf-like functions.
12835 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12836 Report overflow in size calculations when allocating printf buffer.
12837 Do not truncate output string at its first null byte.
12838 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12839 Truncate the output at a character boundary, since vsnprintf does not
12840 do that.
12841 * charset.c (check_iso_charset_parameter): Convert internal
12842 character to string before calling 'error', since %c now has the
12843 printf meaning.
12844 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12845 overflow when computing char to be passed to 'error'. Do not
12846 pass Lisp_Object to 'error'; pass the integer instead.
12847 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12848 formatted with plain %d.
12849
b189fa66
PE
12850 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12851
bff87ef0
PE
12852 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12853
7e2cac20
PE
12854 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12855
ce4d90b5
PE
12856 * xterm.c (x_catch_errors): Remove duplicate declaration.
12857
266c9547
PE
12858 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12859
79c49ad2
PE
12860 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12861
368f4090
JM
128622011-04-10 Jim Meyering <meyering@redhat.com>
12863
12864 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12865 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12866 return ssize_t not "int", and use size_t as the buffer length.
12867 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12868 * gnutls.h: Update declarations.
12869 * process.c (read_process_output): Use ssize_t, to match.
12870 (send_process): Likewise.
12871
a32d4040
CY
128722011-04-09 Chong Yidong <cyd@stupidchicken.com>
12873
12874 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12875
8546720e 128762011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12877
04f2d78b
CB
12878 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12879 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12880
8546720e
GM
12881 * xterm.c (handle_one_xevent):
12882 * xmenu.c (create_and_show_popup_menu):
12883 * xselect.c (x_decline_selection_request)
12884 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12885
0a2f5c1a 128862011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12887
12888 Fix some uses of `int' instead of EMACS_INT.
12889 * search.c (string_match_1, fast_string_match)
12890 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12891 (scan_buffer, find_next_newline_no_quit)
12892 (find_before_next_newline, search_command, Freplace_match)
12893 (Fmatch_data): Make some `int' variables be EMACS_INT.
12894
12895 * xdisp.c (display_count_lines): 3rd argument and return value now
12896 EMACS_INT. All callers changed.
12897 (pint2hrstr): Last argument is now EMACS_INT.
12898
12899 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12900 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12901 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12902 (decode_coding_utf_16, decode_coding_emacs_mule)
12903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12904 (decode_coding_ccl, decode_coding_charset)
12905 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12906 (decode_coding_iso_2022, decode_coding_emacs_mule)
12907 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12908 <char_offset, last_offset>: Declare EMACS_INT.
12909 (encode_coding_utf_8, encode_coding_utf_16)
12910 (encode_coding_emacs_mule, encode_invocation_designation)
12911 (encode_designation_at_bol, encode_coding_iso_2022)
12912 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12913 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12914 Declare EMACS_INT.
12915 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12916 (encode_invocation_designation): Last argument P_NCHARS is now
12917 EMACS_INT.
12918 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12919 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12920
12921 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12922 All users changed.
12923
12924 * ccl.c (Fccl_execute_on_string): Declare some variables
12925 EMACS_INT.
12926
8546720e 129272011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12928
12929 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12930
4e19a977
CS
129312011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12932
12933 * process.c (Fformat_network_address): Doc fix.
12934
87302331
R
129352011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12936
ee7683eb 12937 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12938
cbb59342
CY
129392011-04-08 Chong Yidong <cyd@stupidchicken.com>
12940
12941 * keyboard.c (read_char): Call Lisp function help-form-show,
12942 instead of using internal_with_output_to_temp_buffer.
12943 (Qhelp_form_show): New var.
e0d38eeb 12944 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12945
12946 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12947
12948 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12949
e67a13ab
CY
129502011-04-06 Chong Yidong <cyd@stupidchicken.com>
12951
04f2d78b
CB
12952 * process.c (Flist_processes): Remove to Lisp.
12953 (list_processes_1): Delete.
e67a13ab 12954
973f782d
EZ
129552011-04-06 Eli Zaretskii <eliz@gnu.org>
12956
7c106b1e
EZ
12957 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12958
973f782d
EZ
12959 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12960
41cf7d1a 129612011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12962
ca23cc88
PE
12963 Fix more problems found by GCC 4.6.0's static checks.
12964
f390e2d5
PE
12965 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12966
42eea0d0
PE
12967 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12968
b69769da 12969 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12970
f9541e84
PE
12971 * xdisp.c (vmessage): Mark as a printf-like function.
12972
13841b55
PE
12973 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12974
c136c10f
PE
12975 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12976
5e2d4a30
PE
12977 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12978 printf-like functions.
12979 (tiff_load): Add casts to remove these marks before passing them
12980 to system-supplied API.
12981
583f48b9
PE
12982 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12983
b25d760e
PE
12984 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12985 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12986 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12987 directly, rather than having caller test rule sign. This avoids
12988 some unnecessary tests.
12989 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12990 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12991 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12992
bc7b6697 12993 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12994 (xfont_open): Avoid unnecessary tests.
bc7b6697 12995
27ccc379
PE
12996 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12997
dcd5c89a
PE
12998 * composite.h, composite.c (composition_gstring_put_cache):
12999 Use EMACS_INT, not int, for length.
13000
b13a45c6
PE
13001 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13002 breaking out part of COMPOSITION_DECODE_RULE.
13003 (COMPOSITION_DECODE_RULE): Use it.
13004 * composite.c (get_composition_id): Remove unused local vars,
13005 by using the new macro.
13006
1e792e4d
PE
13007 * textprop.c (set_text_properties_1): Change while to do-while,
13008 since the condition is always true at first.
13009
dc6c6455 13010 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13011 (interval_deletion_adjustment): Return unsigned value.
13012 All uses changed.
dc6c6455 13013
aba7731a
PE
13014 * process.c (list_processes_1, create_pty, read_process_output):
13015 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13016 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13017 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13018 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13019 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13020
fdfc4bf3
PE
13021 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13022
fca8fe46 13023 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13024 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13025
06a0259a 13026 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13027 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13028 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13029
e7b9e80f
PE
13030 * print.c (print_error_message): Avoid int overflow.
13031
56201685
PE
13032 * font.c (font_list_entities): Redo for clarity,
13033 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13034
78834453 13035 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13036 (font_score): Avoid potential overflow in diff calculation.
78834453 13037
0bc0b309 13038 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13039 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13040
e610eaca
PE
13041 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13042
b895abce
PE
13043 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13044 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13045 can always succeed if overflow has undefined behavior.
13046
1f1d9321 13047 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13048 (wordify): Omit three unnecessary tests.
1f1d9321 13049
c59478bc
PE
13050 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13051 All callers changed. This avoids the need for an unused var.
13052
79b73827
PE
13053 * casefiddle.c (casify_region): Remove var that is set but not used.
13054
a4db5dfe
PE
13055 * dired.c (file_name_completion): Remove var that is set but not used.
13056
43aae36e
PE
13057 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13058
2a47c44d 13059 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13060 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13061
a37c69bf
PE
13062 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13063 Check for integer overflow on size calculations.
13064
328ab8e7
PE
13065 * buffer.c (Fprevious_overlay_change): Remove var that is set
13066 but not used.
13067
e5a2a5cb
PE
13068 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13069 Remove vars that are set but not used.
8d84a6eb 13070 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13071 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13072
a60e5f68
PE
13073 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13074
f661cb61 13075 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13076 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13077
f0397f5a
PE
13078 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13079 that are set but not used.
13080
8664db06 13081 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13082 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13083
6abdaa4a
PE
13084 * xselect.c (x_get_local_selection, x_handle_property_notify):
13085 Remove vars that are set but not used.
13086
0ce7538d 13087 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13088 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13089
9ae848fc
PE
13090 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13091 Remove var that is set but not used.
0b918413
PE
13092 (scroll_bar_windows_size): Now size_t, not int.
13093 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13094 Check for overflow.
9ae848fc 13095
a5a62657
PE
13096 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13097 (map_tty_color) [!defined MSDOS]: Likewise.
13098
5c5cdd39
PE
13099 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13100
66ebf983
PE
13101 * coding.c: Remove vars that are set but not used.
13102 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13103 All callers changed.
13104 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13105 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13106 (decode_coding_charset): Remove vars that are set but not used.
13107
1be4d761
PE
13108 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13109 that is set but not used.
13110
47553fa8
PE
13111 * print.c (print_object): Remove var that is set but not used.
13112
1f7196bf 13113 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13114 The gnulib version avoids calling malloc in the usual case,
13115 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13116 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13117 * filelock.c (current_lock_owner): Likewise.
13118 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13119 * sysdep.c: Include allocator.h, careadlinkat.h.
13120 (emacs_no_realloc_allocator): New static constant.
13121 (emacs_readlink): New function.
fdb61804
PE
13122 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13123 ../lib/careadlinkat.h.
d1fdcab7 13124
f84c17c7
SM
131252011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13126
13127 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13128 first non-nil return value).
13129
ef3862ad
JD
131302011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13131
13132 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13133 if not defined (Bug#8403).
13134
376a7006
JB
131352011-04-02 Juanma Barranquero <lekktu@gmail.com>
13136
13137 * xdisp.c (display_count_lines): Remove parameter `start',
13138 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13139 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13140 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13141 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13142 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13143 and thereabouts. All callers changed.
13144 (get_per_char_metric): Remove parameter `f', unused since
13145 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13146
6ca3801d
JM
131472011-04-02 Jim Meyering <meyering@redhat.com>
13148
13149 do not dereference NULL upon failed strdup
13150 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13151 (ns_get_family): Likewise.
13152
d8e2b5ba
JB
131532011-04-02 Juanma Barranquero <lekktu@gmail.com>
13154
13155 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13156
8c74fcbd
JD
131572011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13158
13159 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13160 later (Bug#8403).
13161
7200d79c
SM
131622011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13163
03408648 13164 Add lexical binding.
7200d79c 13165
03408648
SM
13166 * window.c (Ftemp_output_buffer_show): New fun.
13167 (Fsave_window_excursion):
13168 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13169
13170 * lread.c (lisp_file_lexically_bound_p): New function.
13171 (Fload): Bind Qlexical_binding.
13172 (readevalloop): Remove `evalfun' arg.
13173 Bind Qinternal_interpreter_environment.
13174 (Feval_buffer): Bind Qlexical_binding.
13175 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13176 Mark as dynamic.
13177 (syms_of_lread): Declare `lexical-binding'.
13178
13179 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13180
13181 * keyboard.c (eval_dyn): New fun.
13182 (menu_item_eval_property): Use it.
ca105506
SM
13183
13184 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13185
03408648
SM
13186 * fns.c (concat, mapcar1): Accept byte-code-functions.
13187
13188 * eval.c (Fsetq): Handle lexical vars.
13189 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13190 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13191 (FletX, Flet): Obey lexical binding.
13192 (Fcommandp): Handle closures.
13193 (Feval): New `lexical' arg.
13194 (eval_sub): New function extracted from Feval. Use it almost
13195 everywhere where Feval was used. Look up vars in lexical env.
13196 Handle closures.
13197 (Ffunctionp): Move from subr.el.
13198 (Ffuncall): Handle closures.
13199 (apply_lambda): Remove `eval_flags'.
13200 (funcall_lambda): Handle closures and new byte-code-functions.
13201 (Fspecial_variable_p): New function.
13202 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13203 but without exporting it to Lisp.
23aba0ea 13204
23aba0ea 13205 * doc.c (Fdocumentation, store_function_docstring):
03408648 13206 * data.c (Finteractive_form): Handle closures.
23aba0ea 13207
03408648
SM
13208 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13209 interactive spec.
ba83908c 13210
04f2d78b
CB
13211 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13212 New byte-codes.
03408648
SM
13213 (exec_byte_code): New function extracted from Fbyte_code to handle new
13214 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13215
03408648 13216 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13217
03408648 13218 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13219
e2abce01
JB
132202011-03-31 Juanma Barranquero <lekktu@gmail.com>
13221
13222 * xdisp.c (redisplay_internal): Fix prototype.
13223
63696a73 132242011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13225
63696a73 13226 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13227 (try_scrolling): Use it when setting scroll_limit.
13228 Limit scrolling to 100 screen lines.
63696a73
EZ
13229 (redisplay_window): Even when falling back on "recentering",
13230 position point in the window according to scroll-conservatively,
13231 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13232
13233 (try_scrolling): When point is above the window, allow searching
13234 as far as scroll_max, or one screenful, to compute vertical
13235 distance from PT to the scroll margin position. This prevents
13236 try_scrolling from unnecessarily failing when
13237 scroll-conservatively is set to a value slightly larger than the
13238 window height. Clean up the case of PT below the margin at bottom
13239 of window: scroll_max can no longer be INT_MAX. When aggressive
13240 scrolling is in use, don't let point enter the opposite scroll
13241 margin as result of the scroll.
13242 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13243 threshold of 100 lines for never-recentering scrolling.
13244
e4cc2dfc
JB
132452011-03-31 Juanma Barranquero <lekktu@gmail.com>
13246
13247 * dispextern.h (move_it_by_lines):
13248 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13249 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13250 (message_log_check_duplicate): Remove parameters `prev_bol' and
13251 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13252 (redisplay_internal): Remove parameter `preserve_echo_area',
13253 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13254
13255 * indent.c (Fvertical_motion):
13256 * window.c (window_scroll_pixel_based, Frecenter):
13257 Don't pass `need_y_p' to `move_it_by_lines'.
13258
1c470562
SM
132592011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13260
44f230aa
SM
13261 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13262 steal a few bits to be more compact.
13263 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13264 Remove unneeded casts.
13265
1c470562
SM
13266 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13267
888adce9
ZK
132682011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13269
13270 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13271 binding" message (bug#7967).
13272
f838ed7b
PE
132732011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13274
77861b95
PE
13275 Fix more problems found by GCC 4.6.0's static checks.
13276
de6dbc14
PE
13277 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13278 Remove unused local var.
13279
f838ed7b
PE
13280 * editfns.c (Fmessage_box): Remove unused local var.
13281
792c7b2b
PE
13282 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13283 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13284 Omit unused local vars.
c499e557 13285 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13286 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13287 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13288 Omit unused local var.
13289
ba0165e1
PE
13290 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13291 Don't assume string length fits in int.
32ad8845 13292 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13293 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13294
3c59b4c9
PE
13295 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13296 instead of alloca (Bug#8344).
13297
a3eed478 13298 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13299 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13300
eb4d412d
PE
13301 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13302
1658b401
PE
13303 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13304 concerns.
13305
13306 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13307
13308 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13309
9a2c6e05
PE
13310 * keyboard.c (syms_of_keyboard): Use the same style as later
13311 in this function when indexing through an array. This also
13312 works around GCC bug 48267.
13313
03d0a109
PE
13314 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13315
44f730c8
PE
13316 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13317
fe75f926
PE
13318 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13319 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13320
ffa8c828
PE
13321 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13322 This avoids undefined behavior on integer overflow, and is a bit
13323 more convenient anyway since it is compared to a size_t variable.
13324
c5101a77
PE
13325 Variadic C functions now count arguments with size_t, not int.
13326 This avoids an unnecessary limitation on 64-bit machines, which
13327 caused (substring ...) to crash on large vectors (Bug#8344).
13328 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13329 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13330 All variadic functions and their callers changed accordingly.
c5101a77
PE
13331 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13332 * data.c (arith_driver, float_arith_driver): Likewise.
13333 * editfns.c (general_insert_function): Likewise.
13334 * eval.c (struct backtrace.nargs, interactive_p)
13335 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13336 (funcall_lambda, mark_backtrace): Likewise.
13337 * fns.c (concat): Likewise.
13338 * frame.c (x_set_frame_parameters): Likewise.
13339 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13340 0 if not found, not -1. All callers changed.
13341
dd3f25f7
PE
13342 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13343 (stack_copy_size): Now size_t, not int.
13344 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13345
461c2ab9
JB
133462011-03-28 Juanma Barranquero <lekktu@gmail.com>
13347
13348 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13349 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13350 All callers changed.
13351
13352 * lisp.h (multibyte_char_to_unibyte):
13353 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13354 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13355 * character.h (CHAR_TO_BYTE8):
13356 * cmds.c (internal_self_insert):
13357 * editfns.c (general_insert_function):
13358 * keymap.c (push_key_description):
13359 * search.c (Freplace_match):
13360 * xdisp.c (message_dolog, set_message_1): All callers changed.
13361
f6d62986
SM
133622011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13363
13364 * keyboard.c (safe_run_hook_funcall): New function.
13365 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13366 don't set the hook to nil, but remove the offending function instead.
13367 (Qcommand_hook_internal): Remove, unused.
13368 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13369 Vcommand_hook_internal.
13370
13371 * eval.c (enum run_hooks_condition): Remove.
13372 (funcall_nil, funcall_not): New functions.
13373 (run_hook_with_args): Call each function through a `funcall' argument.
13374 Remove `cond' argument, now redundant.
13375 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13376 (Frun_hook_with_args_until_failure): Adjust accordingly.
13377 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13378
1db5b1ad
JB
133792011-03-28 Juanma Barranquero <lekktu@gmail.com>
13380
13381 * dispextern.h (string_buffer_position): Remove declaration.
13382
13383 * print.c (strout): Remove parameter `multibyte', unused since
13384 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13385
13386 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13387 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13388 All callers changed.
13389
13390 * w32.c (_wsa_errlist): Use braces for struct initializers.
13391
13392 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13393 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13394 All callers changed.
13395 (string_buffer_position): Likewise. Also, make static (it's never
13396 used outside xdisp.c).
13397 (cursor_row_p): Remove parameter `w', unused since
13398 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13399 (decode_mode_spec): Remove parameter `precision', introduced during
13400 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13401 All callers changed.
13402
5ffb62aa
JD
134032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13404
13405 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13406
461c2ab9 134072011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13408
13409 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13410 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13411 (ns_update_auto_hide_menu_bar): New functions.
13412 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13413 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13414 ns_constrain_all_frames.
13415 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13416 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13417
5c380ffb
JD
134182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13419
13420 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13421
9af30bdf
GM
134222011-03-27 Glenn Morris <rgm@gnu.org>
13423
13424 * syssignal.h: Replace RETSIGTYPE with void.
13425 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13426 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13427 Replace SIGTYPE with void everywhere.
13428 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13429 * s/template.h (SIGTYPE): Remove commented out definition.
13430
e2abce01
JB
134312011-03-26 Eli Zaretskii <eliz@gnu.org>
13432
13433 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13434 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13435
f868cd8a
JB
134362011-03-26 Juanma Barranquero <lekktu@gmail.com>
13437
59eb0929
JB
13438 * w32.c (read_unc_volume): Use parameter `henum', instead of
13439 global variable `wget_enum_handle'.
13440
13441 * keymap.c (describe_vector): Remove parameters `indices' and
13442 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13443 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13444
f868cd8a
JB
13445 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13446
13447 * keyboard.c (timer_check): Remove parameter `do_it_now',
13448 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13449 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13450 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13451
13452 * keyboard.c (read_char):
13453 * w32menu.c (w32_menu_display_help):
13454 * xmenu.c (show_help_event, menu_help_callback):
13455 Adjust calls to `show_help_echo'.
13456
13457 * gtkutil.c (xg_maybe_add_timer):
13458 * keyboard.c (readable_events):
13459 * process.c (wait_reading_process_output):
13460 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13461
13462 * insdel.c (adjust_markers_gap_motion):
13463 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13464 (gap_left, gap_right): Don't call it.
13465
2ecf6fdb
CY
134662011-03-25 Chong Yidong <cyd@stupidchicken.com>
13467
13468 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13469 incurred during fontification.
13470
6b1f9ba4
JB
134712011-03-25 Juanma Barranquero <lekktu@gmail.com>
13472
13473 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13474 (DEFVAR_PER_BUFFER): Don't pass it.
13475
13476 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13477 (scrolling_window): Don't pass it.
13478
0f4a96b5
JB
134792011-03-25 Juanma Barranquero <lekktu@gmail.com>
13480
13481 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13482
13483 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13484 and `suffix'.
13485 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13486 of variables specific to SELinux and computation of `encoded_absname'.
13487
13488 * image.c (XPutPixel): Remove unused variable `height'.
13489
13490 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13491
13492 * unexw32.c (get_section_info): Remove unused variable `section'.
13493
13494 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13495 (system_process_attributes): Remove unused variable `sess'.
13496 (sys_read): Remove unused variable `err'.
13497
13498 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13499 (w32_wnd_proc): Remove unused variable `isdead'.
13500 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13501 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13502 (x_create_tip_frame): Remove unused variable `tem'.
13503
13504 * w32inevt.c (w32_console_read_socket):
13505 Remove unused variable `no_events'.
13506
13507 * w32term.c (x_draw_composite_glyph_string_foreground):
13508 Remove unused variable `width'.
13509
1149507c
JB
135102011-03-24 Juanma Barranquero <lekktu@gmail.com>
13511
13512 * w32term.c (x_set_glyph_string_clipping):
13513 Don't pass uninitialized region to CombineRgn.
13514
9c88f339
JB
135152011-03-23 Juanma Barranquero <lekktu@gmail.com>
13516
13517 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13518 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13519 (Fx_close_connection): Remove unused variable `i'.
13520
13521 * w32font.c (w32font_draw): Return number of glyphs.
13522 (w32font_open_internal): Remove unused variable `i'.
13523 (w32font_driver): Add missing initializer.
13524
13525 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13526 (fill_in_menu): Remove unused variable `items_added'.
13527
13528 * w32term.c (last_mouse_press_frame): Remove static global variable.
13529 (w32_clip_to_row): Remove unused variable `f'.
13530 (x_delete_terminal): Remove unused variable `i'.
13531
13532 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13533 (NOTHING): Remove unused static global variable.
13534 (uniscribe_check_otf): Remove unused variable `table'.
13535 (uniscribe_font_driver): Add missing initializers.
13536
dee091a3
JD
135372011-03-23 Julien Danjou <julien@danjou.info>
13538
13539 * term.c (Fsuspend_tty, Fresume_tty):
13540 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13541 * window.c (temp_output_buffer_show):
13542 * insdel.c (signal_before_change):
13543 * frame.c (Fhandle_switch_frame):
13544 * fileio.c (Fdo_auto_save):
13545 * emacs.c (Fkill_emacs):
13546 * editfns.c (save_excursion_restore):
13547 * cmds.c (internal_self_insert):
13548 * callint.c (Fcall_interactively):
13549 * buffer.c (Fkill_all_local_variables):
13550 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13551 Use Frun_hooks.
0f4a96b5 13552 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13553 unconditionally since it does the check itself.
dee091a3 13554
2c520ab5 135552011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13556
c9c49752
PE
13557 Fix more problems found by GCC 4.5.2's static checks.
13558
8abc3f12
PE
13559 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13560 the first time through the loop, since we know p0 < p1 then.
13561 This also avoids a gcc -Wstrict-overflow warning.
13562
a2d26660
PE
13563 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13564 leading to a memory leak, possible in functions like
13565 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13566 of objects (Bug#8318).
a2d26660 13567
916c72e9
PE
13568 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13569 that could (at least in theory) be that large.
13570
19ab8a18
PE
13571 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13572 This is less likely to overflow, and avoids undefined behavior if
13573 overflow does occur. All callers changed. Use strtoul to scan
13574 for the unsigned long integer.
b7cbbd6f
PE
13575 (pint2hrstr): Simplify and tune code slightly.
13576 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13577
f0641eff
PE
13578 * scroll.c (do_scrolling): Work around GCC bug 48228.
13579 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13580
7f650bb9
PE
13581 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13582 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13583 (validate_x_resource_name): Simplify count usage.
13584 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13585
37dd57d1
PE
13586 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13587 fail (Bug#8306).
81e56e61 13588
699979fc 13589 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13590
401bf9b4
PE
13591 * process.c (Fmake_network_process): Use socklen_t, not int,
13592 where POSIX says socklen_t is required in portable programs.
13593 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13594 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13595 (Fmake_network_process, server_accept_connection):
13596 (wait_reading_process_output, read_process_output):
13597 Likewise.
13598
b93aacde
PE
13599 * process.c: Rename or move locals to avoid shadowing.
13600 (list_processes_1, Fmake_network_process):
13601 (read_process_output_error_handler, exec_sentinel_error_handler):
13602 Rename or move locals.
4dc343ee 13603 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13604 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13605 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13606 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13607 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13608
af8a867c 13609 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13610 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13611 Include tparam.h instead, since it declares them.
af8a867c
PE
13612 * cm.h (PC): Remove extern decl; tparam.h now does this.
13613 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13614 * terminfo.c: Include tparam.h, to check interfaces.
13615 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13616 (tparam): Adjust signature to match interface in tparam.h;
13617 this removes some undefined behavior. Check that outstring and len
13618 are zero, which they always are with Emacs.
13619 * tparam.h (PC, BC, UP): New extern decls.
13620
0248044d 13621 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13622 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13623
8ff096c1 13624 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13625 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13626 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13627 (ftfont_list): Remove unused local.
49eaafba
PE
13628 (get_adstyle_property, ftfont_pattern_entity):
13629 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13630 Rename locals to avoid shadowing.
8ff096c1 13631
e2be39f6
PE
13632 * xfont.c (xfont_list_family): Mark var as initialized.
13633
c9735e30
PE
13634 * xml.c (make_dom): Now static.
13635
8f5201ae
PE
13636 * composite.c (composition_compute_stop_pos): Rename local to
13637 avoid shadowing.
b246f932
PE
13638 (composition_reseat_it): Remove unused locals.
13639 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13640 (composition_update_it): Mark var as initialized.
11b61122
PE
13641 (find_automatic_composition): Mark vars as initialized,
13642 with a FIXME (Bug#8290).
8f5201ae 13643
760fbc2c
PE
13644 character.h: Rename locals to avoid shadowing.
13645 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13646 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13647 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13648 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13649 to avoid shadowing.
13650
ff08eb85
PE
13651 * textprop.c (property_change_between_p): Remove; unused.
13652
fc7bf025
PE
13653 * intervals.c (interval_start_pos): Now static.
13654
235d7abc
PE
13655 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13656
44f230aa
SM
13657 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13658 Rename locals to avoid shadowing.
3e7d6594 13659
50060332
PE
13660 * sound.c (wav_play, au_play, Fplay_sound_internal):
13661 Fix pointer signedness.
d01f234b 13662 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13663 (wav_play): Initialize a variable to 0, to prevent undefined
13664 behavior (Bug#8278).
50060332 13665
c4fc4e30
PE
13666 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13667
918436ed
PE
13668 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13669
c939f91b
PE
13670 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13671 clobbering (Bug#8298).
b9c7f648
PE
13672 * sysdep.c (sys_subshell): Likewise.
13673 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13674
6bd8c144
PE
13675 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13676 This should get cleaned up, so that child_setup has the
13677 same signature on all platforms.
13678
7710357c 13679 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13680 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13681
c59da222
CY
136822011-03-22 Chong Yidong <cyd@stupidchicken.com>
13683
13684 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13685 not to be necessary, and produces flickering.
13686
66b87493
GM
136872011-03-20 Glenn Morris <rgm@gnu.org>
13688
13689 * config.in: Remove file.
13690
45b6f6d5
JB
136912011-03-20 Juanma Barranquero <lekktu@gmail.com>
13692
13693 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13694 are now in src/globals.h.
13695 (syms_of_minibuf): Remove spurious & from previous change.
13696
cd394be1 136972011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13698
13699 * minibuf.c (completing-read-function): New variable.
13700 (completing-read-default): Rename from completing-read.
13701 (completing-read): Call completing-read-function.
13702
b14e3e21
CY
137032011-03-19 Juanma Barranquero <lekktu@gmail.com>
13704
13705 * xfaces.c (Fx_load_color_file):
13706 Read color file from absolute filename (bug#8250).
13707
f2b726e6
JB
137082011-03-19 Juanma Barranquero <lekktu@gmail.com>
13709
13710 * makefile.w32-in: Update dependencies.
13711
09f6ff02
EZ
137122011-03-17 Eli Zaretskii <eliz@gnu.org>
13713
13714 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13715
29a6015a
PE
137162011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13717
a3a6c54e
PE
13718 Fix more problems found by GCC 4.5.2's static checks.
13719
b766f867
PE
13720 * process.c (make_serial_process_unwind, send_process_trap):
13721 (sigchld_handler): Now static.
13722
be02381c
PE
13723 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13724 That way, the code declares only the vars that it needs.
13725 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13726 * s/cygwin.h (PTY_ITERATION): Likewise.
13727 * s/darwin.h (PTY_ITERATION): Likewise.
13728 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13729
57048744
PE
13730 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13731 * process.c (allocate_pty): Don't declare stb unless it's needed.
13732
7914961c 13733 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13734 (CONSTANTLIM): Remove; unused.
13735 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13736 Define only if needed.
7914961c 13737
b3967b18
PE
13738 * unexelf.c (unexec): Name an expression,
13739 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13740 Use a different way to cause a compilation error if anyone uses
13741 n rather than nn, a way that does not involve shadowing.
73366a00 13742 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13743
29a6015a
PE
13744 * deps.mk (unexalpha.o): Remove; unused.
13745
43cfc33e 13746 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13747 * unexec.h: New file.
ce701a33
PE
13748 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13749 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13750 Depend on unexec.h.
13751 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13752 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13753 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13754 Change as necessary to match prototype in unexec.h.
ce701a33 13755
01f44d5a
PE
13756 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13757 shadowing.
4f63c6bb 13758 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13759
a6670b0b
PE
13760 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13761 Rename locals to avoid shadowing.
13762
cef2010d 13763 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13764 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13765
d4d7173a
PE
13766 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13767
f08b802a
PE
13768 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13769 warning when compiling print.c.
13770
3ddb0639
PE
13771 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13772 instead of using an uninitialized var.
5ad03b97 13773 (font_sort_entities): Mark var as initialized.
3ddb0639 13774
170a2692
PE
13775 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13776
e663c700
PE
13777 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13778 pointers to constants.
89bc529a 13779 (font_parse_fcname): Remove unused vars.
7b81e2d0 13780 (font_delete_unmatched): Now static.
ea838e10 13781 (font_get_spec): Remove; unused.
13a547c6
PE
13782 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13783 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13784 Rename or move locals to avoid shadowing.
e663c700 13785
2a80c887 13786 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13787 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13788
1384fa33 13789 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13790 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13791
8b2c52e9
PE
13792 * alloc.c (mark_backtrace): Move decl from here ...
13793 * lisp.h: ... to here, so that it can be checked.
13794
475545b5 13795 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13796 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13797 (lisp_indirect_variable): Name an expression,
13798 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13799 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13800
b1349114 13801 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13802 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13803 Use const pointer when appropriate.
b1349114 13804
a2928364
PE
13805 * lisp.h (get_system_name, get_operating_system_release):
13806 Move decls here, to check interfaces.
13807 * process.c (get_operating_system_release): Move decl to lisp.h.
13808 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13809 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13810 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13811 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13812 (Fformat_time_string, Fencode_time, Finsert_char):
13813 (Ftranslate_region_internal, Fformat):
13814 Rename or remove local vars to avoid shadowing.
9710023e 13815 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13816
a415e694
PE
13817 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13818 avoid shadowing.
13819
8ef4622d
PE
13820 * lisp.h (eassert): Check that the argument compiles, even if
13821 ENABLE_CHECKING is not defined.
13822
946f9a5b
PE
13823 * data.c (Findirect_variable): Name an expression, to avoid
13824 gcc -Wbad-function-cast warning.
112396d6 13825 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13826 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13827 (Fmake_variable_buffer_local, Fmake_local_variable):
13828 Mark variables as initialized.
52746918 13829 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13830
e5aab7e7 13831 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13832 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13833 Rename locals to avoid shadowing.
dff45157
PE
13834 (mark_stack): Move local variables into the #ifdef region where
13835 they're used.
7bc26fdb
PE
13836 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13837 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13838 needed otherwise.
13839 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13840 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13841 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13842
e5aab7e7
PE
13843 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13844 avoids undefined behavior in theory.
13845
4da60324
PE
13846 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13847
88043301
PE
13848 Use functions, not macros, for up- and down-casing (Bug#8254).
13849 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13850 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13851 to use the following functions instead of these macros.
13852 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13853 EMACS_INT, since callers assume the returned value fits in int.
13854 (upcase1): Likewise, for UPCASE_TABLE.
13855 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13856 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13857 the race-condition problem in the old DOWNCASE.
88043301 13858
19ed5445
PE
13859 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13860 Rename locals to avoid shadowing.
13861 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13862 (regex_compile, re_search_2, re_match_2_internal):
13863 Remove unused local vars.
952db0d7
PE
13864 (FREE_VAR): Rewrite so as not to use empty "else",
13865 which gcc can warn about.
da053e48 13866 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13867 (RETALLOC_IF): Define only if needed.
13868 (WORDCHAR_P): Likewise. This one is never needed, but is used
13869 only in a comment talking about a compiler bug, so put inside
13870 the #if 0 of that comment.
13871 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13872 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13873 Remove; unused.
19ed5445 13874
1f3561e4 13875 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13876 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13877 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13878
ded6f8f7
PE
13879 * search.c (simple_search): Remove unused var.
13880
dbd37a95
PE
13881 * dired.c (compile_pattern): Move decl from here ...
13882 * lisp.h: ... to here, so that it can be checked.
13883 (struct re_registers): New forward decl.
13884
7e47afad
PE
13885 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13886
85f24f61
PE
13887 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13888 All uses changed.
13889 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13890 Rename locals to avoid shadowing.
5671df8f 13891 (Fvertical_motion): Mark locals as initialized.
85f24f61 13892
181aa2be 13893 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13894 (casify_region): Mark local as initialized.
181aa2be 13895
930d429c
PE
13896 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13897
7082eac6
PE
13898 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13899 New macros, so that the caller can use some names other than
13900 gcpro1, gcpro2, etc.
13901 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13902 of the new macros.
13903 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13904 argument, for consistency with GCPRO2_VAR, etc: it is now the
13905 prefix of the variable, not the variable itself. All uses
13906 changed.
38b2c076
PE
13907 * dired.c (directory_files_internal, file_name_completion):
13908 Rename locals to avoid shadowing.
13909
15206ed9
PE
13910 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13911 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13912 dired.c's scmp function, had undefined behavior.
13913 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13914 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13915 * buffer.h: ... to here, because these macros use current_buffer,
13916 and the new implementation with inline functions needs to have
13917 current_buffer in scope now, rather than later when the macros
13918 are used.
13919 (downcase, upcase1): New static inline functions.
13920 (DOWNCASE, UPCASE1): Reimplement using these functions.
13921 This avoids undefined behavior in expressions like
13922 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13923 from race conditions in accessing the global variables
13924 case_temp1 and case_temp2.
13925 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13926 * lisp.h (case_temp1, case_temp2): Remove their decls.
13927 * character.h (ASCII_CHAR_P): Move from here ...
13928 * lisp.h: ... to here, so that the inline functions mentioned
13929 above can use them.
13930
4a6bea26
PE
13931 * dired.c (directory_files_internal_unwind): Now static.
13932
f14b7e14
PE
13933 * fileio.c (file_name_as_directory, directory_file_name):
13934 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13935 Now static.
2893f146
PE
13936 (file_name_as_directory): Use const pointers when appropriate.
13937 (Fexpand_file_name): Likewise. In particular, newdir might
13938 point at constant storage, so make it a const pointer.
fd4ead52 13939 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13940 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13941 signedness issues.
f839df0c
PE
13942 (Fset_file_times, Finsert_file_contents, auto_save_error):
13943 Rename locals to avoid shadowing.
f14b7e14 13944
5716756e 13945 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13946 (Ftry_completion, Fall_completions): Rename or remove locals
13947 to avoid shadowing.
5716756e 13948
b4c3046a
PE
13949 * marker.c (bytepos_to_charpos): Remove; unused.
13950
b45db522
PE
13951 * lisp.h (verify_bytepos, count_markers): New decls,
13952 so that gcc does not warn that these functions aren't declared.
13953
85876d07
PE
13954 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13955 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13956 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13957 (copy_text): Remove unused local var.
85876d07 13958
03d78a21 13959 * filelock.c (within_one_second): Now static.
b3dd38ab 13960 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13961
5df8f01b
PE
13962 * buffer.c (fix_overlays_before): Mark locals as initialized.
13963 (fix_start_end_in_overlays): Likewise. This function should be
13964 simplified by using pointers-to-pointers, but that's a different
13965 matter.
b1d876f1 13966 (switch_to_buffer_1): Now static.
8f54f30a
PE
13967 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13968 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13969
a70072c9 13970 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13971 Fix pointer signedness issue.
edced198
PE
13972 (sys_subshell): Mark local as volatile if checking for lint,
13973 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13974 (MAXPATHLEN): Define only if needed.
a70072c9 13975
a0977c44
PE
13976 * process.c (serial_open, serial_configure): Move decls from here ...
13977 * systty.h: ... to here, so that they can be checked.
13978
a884fdcc
PE
13979 * fns.c (get_random, seed_random): Move extern decls from here ...
13980 * lisp.h: ... to here, so that they can be checked.
13981
604efe86 13982 * sysdep.c (reset_io): Now static.
b8950c94 13983 (wait_for_termination_signal): Remove; unused.
604efe86 13984
38fc62d9
PE
13985 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13986 (copy_keymap_item, append_key, push_text_char_description):
13987 Now static.
1004a21a 13988 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13989 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13990 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13991 (describe_map_tree):
13992 Rename locals to avoid shadowing.
38fc62d9 13993
2f2650da
PE
13994 * keyboard.c: Declare functions static if they are not used elsewhere.
13995 (echo_char, echo_dash, cmd_error, top_level_2):
13996 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13997 (read_char, kbd_buffer_get_event, make_lispy_position):
13998 (make_lispy_event, make_lispy_movement, apply_modifiers):
13999 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14000 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14001 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14002 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14003 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14004
a053e86c 14005 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14006 (mark_kboards): Move decl here ...
14007 * alloc.c (mark_kboards): ... from here.
a053e86c 14008
4752793e
PE
14009 * lisp.h (force_auto_save_soon): New decl.
14010
74f10ca7 14011 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14012 (DEFINE_DUMMY_FUNCTION): New macro.
14013 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14014 Use it.
c03cd23f
PE
14015 (main): Add casts to avoid warnings
14016 if GCC considers string literals to be constants.
74f10ca7 14017
022e70d4
PE
14018 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14019
59d6fe83
PE
14020 * dbusbind.c: Pointer signedness fixes.
14021 (xd_signature, xd_append_arg, xd_initialize):
14022 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14024 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14025 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14026
78320123
PE
14027 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14028 if GCC considers string literals to be constants.
49cebcca 14029 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14030
35ac2a97
SM
140312011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14032
fb103ca9
SM
14033 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14034 (print_preprocess, print_object): New macro to fix last change.
14035
35ac2a97
SM
14036 * print.c (print_preprocess): Don't forget font objects.
14037
62973b41
JB
140382011-03-16 Juanma Barranquero <lekktu@gmail.com>
14039
14040 * emacs.c (USAGE3): Doc fixes.
14041
0e48bb22
AS
140422011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14043
14044 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14045 structure.
14046
7684e57b
JB
140472011-03-14 Juanma Barranquero <lekktu@gmail.com>
14048
14049 * lisp.h (VWindow_system, Qfile_name_history):
14050 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14051 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14052 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14053
14054 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14055 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14056
14057 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14058 * w32console.c (detect_input_pending, read_input_pending)
14059 (encode_terminal_code):
14060 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14061 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14062 (w32_system_caret_y, Qfile_name_history):
14063 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14064 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14065 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14066 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14067 * w32proc.c (Qlocal, report_file_error):
14068 * w32term.c (Vwindow_system, updating_frame):
14069 * w32uniscribe.c (initialized, uniscribe_font_driver):
14070 Remove unneeded extern declarations.
14071
2aa46d6c
CY
140722011-03-14 Chong Yidong <cyd@stupidchicken.com>
14073
c96bbc66 14074 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14075
cffc6f3b
CY
140762011-03-13 Chong Yidong <cyd@stupidchicken.com>
14077
14078 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14079 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14080 These macros can no longer be used for assignment.
14081
44f230aa
SM
14082 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14083 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14084 (record_buffer_markers, fetch_buffer_markers): New functions for
14085 recording and fetching special buffer markers.
14086 (set_buffer_internal_1, set_buffer_temp): Use them.
14087
14088 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14089
14090 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14091
14092 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14093 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14094
14095 * xdisp.c (hscroll_window_tree):
14096 (reconsider_clip_changes): Use PT instead of BUF_PT.
14097
d251f04b
EZ
140982011-03-13 Eli Zaretskii <eliz@gnu.org>
14099
14100 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14101 $(EMACS_ROOT)/lib/intprops.h.
14102
f0c77cd1
PE
141032011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14104
3eca4629
PE
14105 Fix more problems found by GCC 4.5.2's static checks.
14106
7c86ee98
PE
14107 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14108 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14109 (xg_free_frame_widgets): Make it clear that a local variable is
14110 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14111 (gdk_window_get_screen): Make it clear that this macro is needed
14112 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14113 (int_gtk_range_get_value): New function, which avoids a diagnostic
14114 from gcc -Wbad-function-cast.
14115 (xg_set_toolkit_scroll_bar_thumb): Use it.
14116 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14117 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14118 (get_utf8_string, xg_get_file_with_chooser):
14119 Rename locals to avoid shadowing.
14120 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14121
41729b81
PE
14122 * xgselect.c (xg_select): Remove unused var.
14123
f0c77cd1
PE
14124 * image.c (four_corners_best): Mark locals as initialized.
14125 (gif_load): Initialize transparent_p to zero (Bug#8238).
14126 Mark another local as initialized.
ec6cf4c6 14127 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14128
ce0ad53d 14129 * image.c (clear_image_cache): Now static.
d5d5a617 14130 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14131 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14132 (x_edge_detection): Remove unnecessary cast that
14133 gcc -Wbad-function-cast diagnoses.
2037898d 14134 (gif_load): Fix pointer signedness.
6ae141d6
PE
14135 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14136 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14137
33383987 141382011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14139
d32df629
PE
14140 Improve quality of tests for time stamp overflow.
14141 For example, without this patch (encode-time 0 0 0 1 1
14142 1152921504606846976) returns the obviously-bogus value (-948597
14143 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14144 reports time overflow. See
14145 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14146 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14147 * editfns.c: Include limits.h and intprops.h.
14148 (TIME_T_MIN, TIME_T_MAX): New macros.
14149 (time_overflow): Move earlier, to before first use.
14150 (hi_time, lo_time): New functions, for an accurate test for
14151 out-of-range times.
14152 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14153 (Fget_internal_run_time): Don't assume time_t fits in int.
14154 (make_time): Use list2 instead of Fcons twice.
14155 (Fdecode_time): More accurate test for out-of-range times.
14156 (check_tm_member): New function.
14157 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14158 (lisp_time_argument): Don't rely on undefined left-shift and
14159 right-shift behavior when checking for time stamp overflow.
8be6f318 14160
fe31d94c
PE
14161 * editfns.c (time_overflow): New function, refactoring common code.
14162 (Fformat_time_string, Fdecode_time, Fencode_time):
14163 (Fcurrent_time_string): Use it.
14164
8be6f318
PE
14165 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14166 * dired.c (make_time): Move to ...
14167 * editfns.c (make_time): ... here.
14168 * systime.h: Note the move.
14169
09d9db2c 141702011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14171
126bc0dc
YM
14172 * fringe.c (update_window_fringes): Remove unused variables.
14173
c47cbdfd
YM
14174 * unexmacosx.c (copy_data_segment): Also copy __got section.
14175 (Bug#8223)
14176
7ac80be9
EZ
141772011-03-12 Eli Zaretskii <eliz@gnu.org>
14178
c96bbc66 14179 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14180 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14181 Constify `char *' arguments and their references according to
14182 prototypes in tparam.h.
14183
ecb0f94d 14184 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14185
7ac80be9
EZ
14186 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14187 Adapt all references accordingly.
14188
14189 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14190
ef1fd07e
TT
141912011-03-11 Tom Tromey <tromey@redhat.com>
14192
14193 * buffer.c (syms_of_buffer): Remove obsolete comment.
14194
7ef4b50c
EZ
141952011-03-11 Eli Zaretskii <eliz@gnu.org>
14196
14197 * termhooks.h (encode_terminal_code): Declare prototype.
14198
14199 * msdos.c (encode_terminal_code): Don't declare prototype.
14200
14201 * term.c (encode_terminal_code): Now external again, used by
14202 w32console.c and msdos.c.
14203
44f230aa
SM
14204 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14205 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14206
4b1ec863 142072011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14208
1714f52b 14209 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14210
4b1ec863
PE
14211 * fringe.c (update_window_fringes): Mark locals as initialized
14212 (Bug#8227).
14213 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14214
524c7aa6
PE
14215 * alloc.c (mark_fringe_data): Move decl from here ...
14216 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14217 to check its interface.
14218 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14219
a5c0af81 14220 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14221 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14222 (fontset_font): Mark local as initialized.
a9a06e0b 14223 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14224
b4716021
PE
14225 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14226
811e9bac 14227 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14228 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14229 (x_own_selection, Fx_disown_selection_internal): Rename locals
14230 to avoid shadowing.
14231 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14232
7e3ab302
PE
14233 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14234 so that the caller can use some name other than gcpro1.
14235 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14236 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14237 (Fx_backspace_delete_keys_p):
14238 Use them to avoid shadowing, and rename vars to avoid shadowing.
14239 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14240 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14241 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14242 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14243 Remove unused locals.
7e3ab302
PE
14244 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14245 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14246 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14247 macros.
f78faa98 14248
e2b13473
PE
14249 * xterm.h (x_mouse_leave): New decl.
14250
77f23912
PE
14251 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14252 Remove unused functions.
cdf4ba58
PE
14253 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14254 (x_calc_absolute_position): Now static.
7411c686 14255 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14256 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14257 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14258 unless they are used.
38d0b34a
PE
14259 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14260 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14261 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14262 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14263 (x_error_catcher, x_connection_closed, x_error_handler):
14264 (x_error_quitter, xembed_send_message, x_iconify_frame):
14265 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14266 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14267 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14268
44f230aa
SM
14269 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14270 Rename or move locals to avoid shadowing.
6b463e58 14271 (tty_defined_color, merge_face_heights): Now static.
5967d051 14272 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14273 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14274 does not deduce is never used uninitialized.
73719eba
PE
14275 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14276 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14277
426994c3 14278 * terminal.c (store_terminal_param): Now static.
5489860b 14279
032f1620 14280 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14281 (set_frame_menubar): Remove unused local.
d4323972 14282 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14283 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14284 since they might point to immutable storage.
281585b0
PE
14285 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14286 since it's unused otherwise.
032f1620 14287
367c19e5 14288 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14289 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14290 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14291 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14292 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14293 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14294 does not deduce are never used uninitialized.
70739cbe 14295
07b48fa9
PE
14296 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14297
8868a238 14298 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14299 * window.c (window_loop, size_window):
14300 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14301
7e5cf297 14302 * window.c (display_buffer): Now static.
d6550a9f
PE
14303 (size_window): Mark variables that gcc -Wuninitialized
14304 does not deduce are never used uninitialized.
a586633d
PE
14305 * window.h (check_all_windows): New decl, to forestall
14306 gcc -Wmissing-prototypes diagnostic.
5b555da1 14307 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14308
f6095868
PE
14309 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14310 shadowing.
14311 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14312 Include <limits.h>.
14313 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14314 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14315 (load_charset_map): Mark variables that gcc -Wuninitialized
14316 does not deduce are never used uninitialized.
53df7c11 14317 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14318
f38b440c
PE
14319 * coding.c (coding_set_source, coding_set_destination):
14320 Use "else { /* comment */ }" rather than "else /* comment */;"
14321 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14322 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14323 a block, when the outer 'i' will do.
14324 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14325 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14326 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14327 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14328 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14329 Rename locals to avoid shadowing.
14330 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14331 * coding.c (emacs_mule_char, encode_invocation_designation):
14332 Now static, since they're not used elsewhere.
413bb2db 14333 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14334 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14335 (decode_coding_emacs_mule): Mark variables that gcc
14336 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14337 (detect_coding_iso_2022): Initialize a local variable that might
14338 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14339 this initialization is needed. (Bug#8211)
5f58e762
PE
14340 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14341 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14342 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14343 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14344 Remove unused macros.
f38b440c 14345
232b38b9 14346 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14347 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14348 * character.c (string_count_byte8): Likewise.
232b38b9 14349
fb90da1b
PE
14350 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14351 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14352
fb93dbc2
PE
14353 * chartab.c (copy_sub_char_table): Now static, since it's not used
14354 elsewhere.
5c156ace
PE
14355 (sub_char_table_ref_and_range, char_table_ref_and_range):
14356 Rename locals to avoid shadowing.
bbcd0949 14357 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14358
7d3b3862 14359 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14360 (BIDI_BOB): Remove unused macro.
7d3b3862 14361
6be7d3da
PE
14362 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14363 deduce are never used uninitialized.
c2ed9c8b 14364 * term.c (encode_terminal_code): Likewise.
6be7d3da 14365
75f8807f 14366 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14367
50938595
PE
14368 * tparam.h: New file.
14369 * term.c, tparam.h: Include it.
14370 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14371 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14372 Move these decls to tparam.h, and make them agree with what
14373 is actually in tparam.c. The previous trick of using incompatible
14374 decls in different modules does not conform to the C standard.
14375 All callers of tparam changed to use tparam's actual API.
14376 * tparam.c (tparam1, tparam, tgoto):
14377 Use const pointers where appropriate.
14378
fbceeba2
PE
14379 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14380 * cm.h (struct cm): Likewise.
14381 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14382 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14383 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14384 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14385 (turn_on_face, init_tty): Likewise.
14386 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14387
7f3f1250
PE
14388 * term.c (term_mouse_position): Rename local to avoid shadowing.
14389
e6ca6543
PE
14390 * alloc.c (mark_ttys): Move decl from here ...
14391 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14392
c40f8d15
AS
143932011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14394
14395 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14396
cfe0661d
JB
143972011-03-09 Juanma Barranquero <lekktu@gmail.com>
14398
14399 * search.c (compile_pattern_1): Remove argument regp, unused since
14400 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14401 (compile_pattern): Don't pass it.
14402
0afb4571
J
144032011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14404
14405 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14406 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14407 for ! HAVE_GTK3.
14408 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14409
14410 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14411
14412 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14413 gdk_window_get_screen, gdk_window_get_geometry,
14414 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14415 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14416 (xg_get_pixbuf_from_pixmap): New function.
14417 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14418 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14419 Call xg_get_pixbuf_from_pixmap instead of
14420 gdk_pixbuf_get_from_drawable.
14421 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14422 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14423 (xg_check_special_colors): Use GtkStyleContext and its functions
14424 for HAVE_GTK3.
14425 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14426 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14427 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14428 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14429 Call gtk_widget_get_preferred_size.
0afb4571
J
14430 (xg_frame_resized): gdk_window_get_geometry only takes 5
14431 parameters.
44f230aa
SM
14432 (xg_win_to_widget, xg_event_is_for_menubar):
14433 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14434 (xg_set_widget_bg): New function.
14435 (delete_cb): New function.
895009e1 14436 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14437 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14438 (xg_set_background_color): Call xg_set_widget_bg.
14439 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14440 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14441 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14442 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14443 if ! HAVE_GTK3.
14444 (update_frame_tool_bar): Call gtk_widget_hide.
14445 (xg_initialize): Use GDK_KEY_g.
14446
14447 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14448 if ! HAVE_GTK3
14449 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14450
14451 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14452 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14453 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14454
1c2cc4ef
JB
144552011-03-08 Juanma Barranquero <lekktu@gmail.com>
14456
14457 * w32xfns.c (select_palette): Check success of RealizePalette against
14458 GDI_ERROR, not zero.
14459
33383987 14460See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14461
14462;; Local Variables:
14463;; coding: utf-8
aac0c6e3
MR
14464;; End:
14465
2f097256 14466 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14467
14468 This file is part of GNU Emacs.
14469
14470 GNU Emacs is free software: you can redistribute it and/or modify
14471 it under the terms of the GNU General Public License as published by
14472 the Free Software Foundation, either version 3 of the License, or
14473 (at your option) any later version.
14474
14475 GNU Emacs is distributed in the hope that it will be useful,
14476 but WITHOUT ANY WARRANTY; without even the implied warranty of
14477 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14478 GNU General Public License for more details.
14479
14480 You should have received a copy of the GNU General Public License
14481 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.