Don't use the abbreviation "win" to refer to Windows (Bug#10421).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b46a6a83
PE
12012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
5 long-ago-commented-out code that talks about "WIN32".
6 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
7 All uses changed.
8
e32a5799
PE
92012-07-28 Paul Eggert <eggert@cs.ucla.edu>
10
11 Use Gnulib stdalign module (Bug#9772, Bug#9960).
12 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
13 Simplify by using alignof.
14 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
15 * lisp.h: Include <stdalign.h>.
16 (GCALIGNMENT): New macro and constant.
17 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
18 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
19 (stdalign): New macro, if not already defined.
20
df81cd29
EZ
212012-07-28 Eli Zaretskii <eliz@gnu.org>
22
01bd1b0d
EZ
23 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
24 * w32inevt.c: Include w32inevt.h.
25 (w32_read_console_input): New inline function, calls either
26 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
27 w32_console_unicode_input.
28 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
29 (w32_kbd_patch_key, key_event): Use the codepage returned by
30 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
31 (key_event): use uChar.UnicodeChar only if
32 w32_console_unicode_input is non-zero.
33
34 * w32console.c: Include w32heap.h.
35 <w32_console_unicode_input>: New global variable.
36 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
37 family of Windows, zero otherwise.
38
39 * w32inevt.h: Declare w32_console_unicode_input.
40
df81cd29
EZ
41 * xdisp.c (init_iterator): Don't reference tip_frame in a build
42 --without-x. (Bug#11742)
43
c20fdd9e
PE
442012-07-27 Paul Eggert <eggert@cs.ucla.edu>
45
46 Adjust GDB to reflect pvec_type changes (Bug#12036).
47 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
48 2012-07-04 changes to pseudovector representation. Problem
49 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
50
32770973 512012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
52
53 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
54 bus address.
55 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
56
3438fe21
EZ
572012-07-27 Eli Zaretskii <eliz@gnu.org>
58
bcfbc9de
EZ
59 * alloc.c (listn): Fix the order the arguments are consed onto the
60 list.
61
3438fe21
EZ
62 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
63 enumeration constants, as PURE and HEAP are too general, and clash
64 with other headers and sources, such as gmalloc.c and the
65 MS-Windows system headers. All users changed.
66
eeaea515
DA
672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
68
69 Revert last save_excursion_save and save_excursion_restore changes.
70 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
71 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
72
073c88c2
DA
732012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Fix recently-introduced typos in Windows port.
76 Reported by Martin Rudalics <rudalics@gmx.at>.
77 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 78 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 79
4706125e
PE
802012-07-27 Paul Eggert <eggert@cs.ucla.edu>
81
82 Improve GDB symbol export (Bug#12036).
83 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
84 arms of an 'if', not using conditional expressions; otherwise GDB
85 complains about the types in the unevaluated arm when the argument
86 is an integer literal.
87 (xgetint): Simplify expression.
88 * alloc.c (gdb_make_enums_visible): New constant. This ports to
89 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
90 Zaretskii in <http://bugs.gnu.org/12036#13>.
91 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
92 needed now that we have gdb_make_enums_visible.
93 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
94 (enum enum_USE_LSB_TAG):
95 New enum types, packaging up enums that need to be exported to GDB.
96
694b6c97
DA
972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Utility function to make a list from specified amount of objects.
100 * lisp.h (enum constype): New datatype.
101 (listn): New prototype.
102 * alloc.c (listn): New function.
103 (Fmemory_use_count, syms_of_alloc): Use it.
104 * buffer.c (syms_of_buffer): Likewise.
105 * callint.c (syms_of_callint): Likewise.
106 * charset.c (define_charset_internal): Likewise.
107 * coding.c (syms_of_coding): Likewise.
108 * keymap.c (syms_of_keymap): Likewise.
109 * search.c (syms_of_search): Likewise.
110 * syntax.c (syms_of_syntax): Likewise.
111 * w32.c (init_environment): Likewise.
112 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
113 * xdisp.c (syms_of_xdisp): Likewise.
114 * xfns.c (syms_of_xfns): Likewise.
115
6195f384
DA
1162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Fast save_excursion_save and save_excursion_restore.
119 * lisp.h (struct Lisp_Excursion): New data type.
120 (PVEC_EXCURSION): New pseudovector type.
121 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
122 to deal with it. Adjust comments.
123 (init_marker, attach_marker): New prototype.
124 (unchain_marker): Adjust prototype.
125 * marker.c (attach_marker): Change to global.
126 (init_marker): New function.
127 * alloc.c (Fmake_marker, build_marker): Use it.
128 (build_marker): More easserts.
129 (mark_object): Handle struct Lisp_Excursion.
130 * editfns.c (save_excursion_save, save_excursion_restore):
131 Reimplement to use struct Lisp_Excursion. Add comments.
132
5eceb8fb
PE
1332012-07-26 Paul Eggert <eggert@cs.ucla.edu>
134
135 Fix export of symbols to GDB (Bug#12036).
136 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
137 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
138 emacs.c, as this is a more-suitable home. Had this been done earlier
139 the fix for 12036 would have avoided some of the problems noted in
140 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
141 would have been more obvious.
562157c8
PE
142 * emacs.c: Do not include <verify.h>; no longer needed.
143 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
144 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
145 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
146 Remove; now done in lisp.h.
147 * lisp.h (PUBLISH_TO_GDB): New macro.
148 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
149 (DATA_SEG_BITS): Use it.
150 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
151 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
152 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
153 not be usable in #if. This simplifies things.
154
d6749401
JB
1552012-07-26 Juanma Barranquero <lekktu@gmail.com>
156
157 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
158
1781b9e9
PE
1592012-07-26 Paul Eggert <eggert@cs.ucla.edu>
160
d89518db 161 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
162 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
163 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
164 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
165 Adjust to changes in lisp.h and emacs.c, by using
166 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
167 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
168 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
169 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
170 instead of gdb_valbits.
171 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
172 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
173 instead of gdb_array_mark_flag.
174 (xboolvector): Get size from $->size, not $->header.size.
175 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
176 (xreload, hook-run, hookpost-run): Remove.
177 * emacs.c: Include <verify.h>.
178 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
179 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
180 Remove.
181 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
182 (gdb_USE_LSB_TAG): New enum constants.
183 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
184 Also define these as enum constants, so they're visible to GDB.
185 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
186 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
187 as constants, so they're visible to GDB.
188 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
189 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
190 Now enum constants, not macros, so they're visible to GDB.
191 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
192 more convenient now. All uses changed.
193 (VALMASK) [USE_LSB_TAG]: Also define in this case.
194 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
195
3628596a
DA
1962012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Explicitly free restriction data that are not needed anymore.
199 * editfns.c (save_restriction_restore): Free restriction data.
200
7abaf5cc
SM
2012012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
202
203 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
204 add argument, tune behavior, and adjust all callers.
205
71f88e00
PE
2062012-07-25 Paul Eggert <eggert@cs.ucla.edu>
207
208 Use typedef for EMACS_INT, EMACS_UINT.
209 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
210 than macros. This simplifies debugging in the usual case, since
211 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
212 and it allows expressions involving EMACS_INT casts.
213 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
214
57ec3034
JD
2152012-07-25 Jan Djärv <jan.h.d@swipnet.se>
216
217 * nsterm.m (ns_read_socket): Return early if there is a modal
218 window (Bug#12043).
219
8137e7b3
MR
2202012-07-25 Martin Rudalics <rudalics@gmx.at>
221
222 * frame.c (Fredirect_frame_focus): In doc-string don't mention
223 that FOCUS-FRAME can be omitted.
224
04e9897c
DA
2252012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
226
227 Adjust buffer text indirection counters at the end of Fkill_buffer.
228 * buffer.c (Fkill_buffer): Adjust indirection counters when the
229 buffer is definitely dead. This should really fix an issue reported
230 by Christoph Scholtes again. (Bug#12007).
231 (init_buffer_once): Initialize indirection counters of
232 buffer_defaults and buffer_local_symbols (for sanity and safety).
233
8a0484e1
EZ
2342012-07-24 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (init_iterator): Don't compute dimensions of truncation
237 and continuation glyphs on tooltip frames, leave them at zero.
238 Avoids continued lines in tooltips. (Bug#11832)
239
fa691a83
DA
2402012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Simplify copy_overlay.
04e9897c 243 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
244 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
245
436bc8e0
EZ
2462012-07-23 Eli Zaretskii <eliz@gnu.org>
247
248 * print.c (print_object): Don't crash when a frame's name is nil
249 or invalid. (Bug#12025)
250
251 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
252 it signals an error when a tooltip frame is being created.
253
d7a7fda3
DA
2542012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
255
256 Cleanup miscellaneous objects allocation and initialization.
257 * alloc.c (allocate_misc): Change to static. Add argument to
258 specify the subtype. Adjust comment and users.
259 (build_overlay): New function.
260 * buffer.c (copy_overlays, Fmake_overlay): Use it.
261 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
262 (allocate_misc): Remove prototype.
263 (build_overlay): Add prototype.
264
2652012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
266
267 Swap buffer text indirection counters in Fbuffer_swap_text.
268 * buffer.c (Fbuffer_swap_text): Swap indirections too.
269 This avoids crash reported by Christoph Scholtes at
270 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
271
9d7fa573
JD
2722012-07-22 Jan Djärv <jan.h.d@swipnet.se>
273
274 * nsmenu.m (Popdown_data): New struct.
275 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
276 free Popdown_data.
277 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
278 (initWithContentRect): Make imgView and contentView non-static
279 and autorelease them. Also autorelease img and matrix (Bug#12005).
280 (dealloc): Remove (Bug#12005).
281
0dd6d66d
DA
2822012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
283
284 Adjust consing_since_gc when objects are explicitly freed.
285 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
286 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
287 (free_cons, free_misc): Subtract object size from consing_since_gc.
288
d36d71df
DA
2892012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
290
291 Simplify and cleanup markers positioning code.
292 * marker.c (attach_marker): More useful eassert.
293 (live_buffer, set_marker_internal): New function.
294 (Fset_marker, set_marker_restricted): Use set_marker_internal.
295 (set_marker_both, set_marker_restricted_both): Use live_buffer.
296
fb9ea40f
PE
2972012-07-22 Paul Eggert <eggert@cs.ucla.edu>
298
299 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
300 as it's limited by the amount of memory, not by INT_MAX.
301
2d5c5f7d
EZ
3022012-07-21 Eli Zaretskii <eliz@gnu.org>
303
07fb592e
EZ
304 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
305 in special-event-map. See the discussion at
306 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
307 for the reasons.
308
37a9eac8 309 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
310 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
311 Fabrice Popineau <fabrice.popineau@supelec.fr>.
312
c4328746
JD
3132012-07-21 Jan Djärv <jan.h.d@swipnet.se>
314
315 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 316 (conversationIdentifier): Return value is NSInteger.
784051c4 317 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 318
6e5d1c12
CY
3192012-07-21 Chong Yidong <cyd@gnu.org>
320
321 * window.c (decode_any_window): Signal an error if the window is
322 on a dead frame (Bug#11984).
323
9928463d
DA
3242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
325
326 Add indirection counting to speed up Fkill_buffer.
327 * buffer.h (struct buffer): New member.
328 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
329 (Fmake_indirect_buffer): Set indirection counter to -1, increment
330 base buffer indirection counter.
331 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
332 (Fkill_buffer): Adjust indirection counters as needed, don't walk
333 through buffer list if indirection counter is 0.
334
f8643a6b
DA
3352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
336
337 Extend the value returned by Fgarbage_collect with heap statistics.
338 * alloc.c (Qheap): New symbol.
339 (syms_of_alloc): DEFSYM it.
340 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
341 (Fmemory_free): Remove.
342 (syms_of_alloc): Don't defsubr it.
343 * buffer.c (Fcompact_buffer): Remove.
344 (syms_of_buffer): Don't defsubr it.
345
dac616ff
DA
3462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
347
348 Make maybe_gc inline.
349 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
350 * lisp.h (consing_since_gc, gc_relative_threshold)
351 (memory_full_cons_threshold): Revert declaration.
352 (maybe_gc): Remove prototype, define as inline.
353 * alloc.c: Remove old commented-out code.
354 (consing_since_gc, gc_relative_threshold)
355 (memory_full_cons_threshold): Revert to global.
356 (maybe_gc): Remove.
357
d7ea76b4
DA
3582012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
359
360 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
361 * lisp.h (build_unibyte_string): New function.
362 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
363 * sysdep.c, w32fns.c, xfns.c: Use it.
364 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
365 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
366 Adjust users accordingly.
367 * font.h (font_open_by_name): Adjust prototype.
368
765e61e3
DA
3692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
370
371 Cleanup calls to Fgarbage_collect.
372 * lisp.h (maybe_gc): New prototype.
373 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
374 Remove declarations.
375 * alloc.c (maybe_gc): New function.
376 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
377 Make them static.
378 * bytecode.c (MAYBE_GC): Use maybe_gc.
379 * eval.c (eval_sub, Ffuncall): Likewise.
380 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
381 to avoid dependency from auto-save feature.
382
52b852c7
PE
3832012-07-19 Paul Eggert <eggert@cs.ucla.edu>
384
385 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
386 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
387 'for_each_per_buffer_object_at'.
388 All uses changed. It's better to use upper-case for macros that
389 cannot be implemented as functions, to give the reader a clue
390 that they're special.
391
5db81e33
SM
3922012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * alloc.c (Fgarbage_collect): Tweak docstring.
395
5b835e1d
DA
3962012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Tweak the value returned from Fgarbage_collect again.
399 * alloc.c (Fgarbage_collect): New return value, as confirmed in
400 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
401 Adjust documentation.
402 (total_vector_bytes): Rename to total_vector_slots, adjust
403 accounting.
404 (total_free_vector_bytes): Rename to total_free_vector_slots,
405 adjust accounting.
406 (Qstring_bytes, Qvector_slots): New symbols.
407 (syms_of_alloc): DEFSYM them.
408
9cd47b72
DA
4092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
410
411 Buffer compaction primitive which may be used from Lisp.
412 * buffer.c (compact_buffer, Fcompact_buffer): New function.
413 (syms_of_buffer): Register Fcompact_buffer.
414 * alloc.c (Fgarbage_collect): Use compact_buffer.
415 * buffer.h (compact_buffer): New prototype.
416 (struct buffer_text): New member.
417
d17337e5
DA
4182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
419
420 New macro to iterate over all buffers, miscellaneous cleanups.
421 * lisp.h (all_buffers): Remove declaration.
422 * buffer.h (all_buffers): Add declaration, with comment.
423 (for_each_buffer): New macro.
424 * alloc.c (Fgarbage_collect, mark_object): Use it.
425 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
426 (init_buffer): Likewise.
427 * data.c (Fset_default): Likewise.
428 * coding.c (code_conversion_restore): Remove redundant check
429 for dead buffer.
430 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
431
60cfd278
AS
4322012-07-18 Andreas Schwab <schwab@linux-m68k.org>
433
434 Fix bug that created negative-length intervals.
435 * intervals.c (merge_interval_right, merge_interval_left):
436 Do not zero out this interval if it is absorbed by its children,
437 as this interval's total length doesn't change in that case. See
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
439
d06714cb
PE
4402012-07-18 Paul Eggert <eggert@cs.ucla.edu>
441
83713154
PE
442 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
443 when invoking (make-bool-vector N t) and N is a positive
444 multiple of 8 -- the last 8 bits were mistakenly cleared.
445
d06714cb
PE
446 Remove some struct layout assumptions in bool vectors.
447 * alloc.c (bool_header_size): New constant.
448 (header_size, word_size): Move earlier, as they're now used earlier.
449 Use 'word_size' in a few more places, where it's appropriate.
450 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
451 padding before the data member of a bool vector.
452 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
453 than doing the check by hand with an abort ().
454
464d5a5e
SM
4552012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
456
5fbc0409
SM
457 * eval.c (Fdefvar): Don't check constants since we only set the var if
458 it's not yet defined anyway (bug#11904).
459
464d5a5e
SM
460 * lisp.h (last_undo_boundary): Declare new var.
461 * keyboard.c (command_loop_1): Set it.
462 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
463 were auto-added by the command loop (bug#11774).
464
8dc2e44a
AS
4652012-07-18 Andreas Schwab <schwab@linux-m68k.org>
466
467 * w32font.c (Qsymbol): Remove local definition.
468 (syms_of_w32font): Don't DEFSYM it.
469
169925ec
DA
4702012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Fix sweep_vectors to handle large bool vectors correctly.
473 * alloc.c (sweep_vectors): Account total_vector_bytes for
474 bool vectors larger than VBLOCK_BYTES_MAX.
475
5fbfb018
CY
4762012-07-18 Chong Yidong <cyd@gnu.org>
477
478 * frame.c (x_set_frame_parameters): Revert bogus change introduced
479 in 2012-05-25 commit by Paul Eggert (Bug#11738).
480
3ab6e069
DA
4812012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
482
483 Return more descriptive data from Fgarbage_collect.
484 Suggested by Stefan Monnier in
485 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
486 * alloc.c (bounded_number): New function.
487 (total_buffers, total_vectors): New variable.
488 (total_string_size): Rename to total_string_bytes, adjust users.
489 (total_vector_size): Rename to total_vector_bytes, adjust users.
490 (sweep_vectors): Account total_vectors and total_vector_bytes.
491 (Fgarbage_collect): New return value. Adjust documentation.
492 (gc_sweep): Account total_buffers.
493 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
494 (VECTOR_SIZE): Remove.
495 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
496 (Qinterval, Qmisc): New symbols.
497 (syms_of_data): Initialize them.
498 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
499 (Qcons, Qbuffer): New declarations.
500
6d02fe5b
PE
5012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
502
503 * alloc.c (Fmemory_free): Account for memory-free's own storage.
504 Round up, not down. Improve doc.
505
b7ffe040
DA
5062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Restore old code in allocate_string_data to avoid Faset breakage.
509 Reported by Julien Danjou <julien@danjou.info> in
510 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
511 * alloc.c (allocate_string_data): Restore old code with minor
512 adjustments, fix comment to explain this subtle issue.
513
4dc7c8d5
SM
5142012-07-17 Eli Zaretskii <eliz@gnu.org>
515
516 Remove FILE_SYSTEM_CASE.
517 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
518
519 * fileio.c (FILE_SYSTEM_CASE): Don't define.
520 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
521 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
522 call-process-region passes it through expand-file-name.
523
524 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
525
5262012-07-17 Andreas Schwab <schwab@linux-m68k.org>
527
528 Fix crash when creating indirect buffer (Bug#11917)
529 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
530 Don't handle unbound variables specially if non-zero.
531 (Fbuffer_local_variables): Pass zero.
532 (clone_per_buffer_values): Pass non-zero.
533
5342012-07-17 Andreas Schwab <schwab@linux-m68k.org>
535
536 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
537 to make the loop interruptible.
538
5392012-07-17 Andreas Schwab <schwab@linux-m68k.org>
540
541 * gnutls.c (emacs_gnutls_handshake): Only retry if
542 GNUTLS_E_INTERRUPTED.
543
cce7fefc
DA
5442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Cleanup and convert miscellaneous checks to eassert.
547 * alloc.c (mark_interval): Fix comment, partially rephrase
548 old comment from intervals.h (see below).
549 * intervals.c (find_interval, adjust_intervals_for_insertion)
550 (delete_interval, adjust_intervals_for_deletion)
551 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
552 Convert to eassert.
553 (adjust_intervals_for_insertion, make_new_interval):
554 Remove obsolete and unused code.
555 * intervals.h (struct interval): Remove obsolete comment.
556 * textprotp.c (erase_properties): Remove unused code.
557 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
558 (Fremove_list_of_text_properties): Convert to eassert.
559
9ea10cc3
CY
5602012-07-17 Chong Yidong <cyd@gnu.org>
561
562 * editfns.c (Finsert_char): Doc fix.
563
3900d5de
DA
5642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
565
566 Fix previous change to make Fmemory_free always accurate.
567 * alloc.c (make_interval): Update total_free_intervals.
568 (make_float): Likewise for total_free_floats.
569 (free_cons, Fcons): Likewise for total_free_conses.
570 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
571 Likewise for total_free_vector_bytes.
572 (Fmake_symbol): Likewise for total_free_symbols.
573 (bytes_free): Remove.
574
7098646f
DA
5752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Simple free memory accounting feature.
578 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
579 (sweep_vectors): Accumulate size of free vectors.
580 (Fgarbage_collect): Setup bytes_free.
581 (Fmemory_free): New function.
582 (syms_of_alloc): Register it.
583
22657b40
DA
5842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Cleanup overlays checking.
587 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
588 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
589 eassert and OVERLAYP.
590 (sort_overlays): Change to use OVERLAYP.
591
ddfc8813
RK
5922012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
593
594 * editfns.c (Finsert_char): Make it interactive, and make the
595 second arg optional. Copy interactive spec and docstring from
596 ucs-insert.
597
7c26cf3c
PE
5982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
599
600 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
601 Unlike the other wrapped functions, fabs has an unspecified
602 effect on errno.
603
5d127af9
JD
6042012-07-16 Jan Djärv <jan.h.d@swipnet.se>
605
606 * nsterm.m (keyDown): Interpret flags without left/right bits
607 as the left key (Bug#11670).
608
6a0dd1d7
DA
6092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Remove empty and useless init functions.
612 * lisp.h (init_character_once, init_fns, init_image)
613 (init_filelock, init_sound): Remove prototype.
614 * character.c (init_character_once): Remove.
615 * filelock.c (init_filelock): Likewise.
616 * fns.c (init_fns): Likewise.
617 * image.c (init_image): Likewise.
618 * sound.c (init_sound): Likewise.
619 * emacs.c (main): Adjust accordingly.
620
7a6136fd
DA
6212012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
622
623 * gtkutil.h: Tiny cleanups.
624 (use_old_gtk_file_dialog): Remove useless declaration.
625 (xg_uses_old_file_dialog): Add suggested const attribute.
626
ce811ad9
EZ
6272012-07-15 Eli Zaretskii <eliz@gnu.org>
628
629 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
630 (bidi_paragraph_init): Use it to limit search forward for a strong
631 directional character in abnormally large paragraphs full of
632 neutral or weak characters. (Bug#11943)
633
c9adfeaa
SF
6342012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
635
636 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
637 the toolbar (Bug#9451).
638 (xg_make_tool_item): Give the widget event box a transparent
639 background.
640
fff62aa9
DA
6412012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
642
643 Cleanup basic allocation variables and functions.
644 * alloc.c (ignore_warnings, init_intervals, init_float)
645 (init_cons, init_symbol, init_marker): Remove.
646 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
647 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
648 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
649 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
650 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
651 (staticidx, init_alloc_once, init_strings, free_ablock):
652 Remove redundant initialization.
653 * fns.c (init_weak_hash_tables): Remove.
654 * lisp.h (init_weak_hash_tables): Remove prototype.
655
9730daca
DA
6562012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
657
658 Use zero_vector where appropriate.
659 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
660 accordingly.
661 * lisp.h (zero_vector): New declaration.
662 * font.c (null_vector): Remove.
663 (syms_of_font): Remove initialization and staticpro.
664 (font_list_entities, font_find_for_lface): Change to use zero_vector.
665 * keymap.c (Faccessible_keymaps): Likewise.
666
2e2d2a13
LL
6672012-07-15 Leo Liu <sdl.web@gmail.com>
668
669 * fringe.c: Fix typo in comments.
670
cd276f6e
LL
6712012-07-14 Leo Liu <sdl.web@gmail.com>
672
673 * fringe.c: Add a new bitmap exclamation-mark.
674
5a1131d9
EZ
6752012-07-14 Eli Zaretskii <eliz@gnu.org>
676
677 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
678
679 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
680 (HAVE_MENUS): Don't define, defined by editing config.in with
681 msdos/sed2v2.inp.
682 (GMALLOC_INHIBIT_VALLOC): Don't define.
683 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
684
22e983b7
JB
6852012-07-14 Juanma Barranquero <lekktu@gmail.com>
686
687 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
688
5b3f250f
GM
6892012-07-14 Glenn Morris <rgm@gnu.org>
690
691 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
692 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
693 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
694
33d63ff4
GM
6952012-07-13 Glenn Morris <rgm@gnu.org>
696
5b633342
GM
697 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
698
33d63ff4
GM
699 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
700 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
701
b55b9f85
JD
7022012-07-13 Jan Djärv <jan.h.d@swipnet.se>
703
0dc8cf50
JD
704 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
705 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
706 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
707 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
708 where appropriate.
709 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
710 as boolean expression.
711 (x_set_window_size): Remove unused variable toolbar.
712 (ns_get_color_default, ns_mod_to_lisp): Remove.
713 (ns_mouse_position): Remove unused variables xchar and ychar.
714 (ns_compute_glyph_string_overhangs): Remove unused variable face.
715 (ns_set_vertical_scroll_bar): Remove unused variable count.
716 (ns_delete_terminal): Remove unused variable i.
717 (ns_term_init): Remove unused variables r, g and b.
718 (mouseDown): Remove unused variable window.
719 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
720 (initFrameFromEmacs): Remove unused variable vbextra.
721 (mouseEntered): Remove unused variables p and dpyinfo.
722 (mouseExited): Remove unused variables p and r.
723 (ns_define_frame_cursor, ns_clear_frame_area)
724 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
725 (menuDown): Assign [sender tag] to variable and cast the variable.
726
727 * nsterm.h (menuDown): Add id as type to argument sender.
728 (ns_display_info_for_name): Add Lisp_Object argument.
729 (ns_term_init): Add Lisp_Object argument.
730 (ns_map_event_to_object): Add void argument.
731 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
732 prototype with arguments and only declare if __OBJC__.
733 (nxatoms_of_nsselect): Add void argument.
734 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
735 (ns_alloc_autorelease_pool): Add void argument.
736 (ns_release_autorelease_pool): Add void* argument.
737 (ns_get_defaults_value): Add const char* argument.
738
739 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
740 (initFromContents): Use SSDATA where appropriate.
741 (ns_update_menubar): Add braces to ambigous if-else.
742 (initWithTitle): Put () around assignment in if statement.
743 (ns_menu_show): Remove unused variables window and keymap.
744 (update_frame_tool_bar): Remove unused variable selected_p.
745 (initWithContentRect): Remove unused variable this_cmd_name.
746
747 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
748 appropriate.
749 (setXBMColor): Remove unused variable len.
750 (setPixmapData): Put () around assignment in loop statement.
751
752 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
753 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
754 where appropriate.
755 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
756 around assignment in loop statement.
757 (nsfont_open): Remove unused variable i.
758 (nsfont_open): Remove unused variable len.
759 (nsfont_draw): Remove unused variable cs.
760
761 * nsfns.m (x_set_icon_name, ns_set_name_internal)
762 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
763 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
764 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
765 (Fns_font_name, Fns_perform_service)
766 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
767 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
768 (ns_set_name): Remove unused variable view.
769 (x_set_menu_bar_lines): Remove unused variable olines.
770 (x_set_tool_bar_lines): Remove unused variable root_window.
771 (Fns_list_colors): Put () around assignment in while statement.
772 (Fns_perform_service): Remove unused variable len.
773 (Fns_display_usable_bounds): Remove unused variable top.
774 (syms_of_nsfns): Remove unused variable i.
775
b55b9f85
JD
776 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
777 memcpy (Bug#11907).
778
ed9265fc 7792012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
780
781 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
782 and free it with DestroyExceptionInfo (Bug#11558).
783
ef099b57
JB
7842012-07-13 Juanma Barranquero <lekktu@gmail.com>
785
786 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
787 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
788 Set here, not in nt/config.nt.
789
ea814a5d
EZ
7902012-07-13 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
793 cursor overflow into the last glyph on display line when the right
794 fringe is off. (Bug#11832)
795
1a952767
PE
7962012-07-13 Paul Eggert <eggert@cs.ucla.edu>
797
798 * xdisp.c (produce_special_glyphs): Now static.
799 * dispextern.h (produce_special_glyphs): Remove decl.
800
983188fd
GM
8012012-07-13 Glenn Morris <rgm@gnu.org>
802
32fb4bb6
GM
803 * s/bsd-common, s/cygwin.h: Remove empty files.
804 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
805
983188fd
GM
806 * s/usg5-4-common.h (USG, USG5):
807 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
808 * s/sol2-6.h (SOLARIS2):
809 * s/irix6-5.h (IRIX6_5):
810 * s/hpux10-20.h (USG, USG5, HPUX):
811 * s/gnu-linux.h (USG, GNU_LINUX):
812 * s/freebsd.h (BSD_SYSTEM):
813 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
814 * s/cygwin.h (CYGWIN):
815 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
816 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
817
d1e68667 8182012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
819
820 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 821
6de0e799
GM
8222012-07-13 Glenn Morris <rgm@gnu.org>
823
739ae010
GM
824 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
825
dbee5793
GM
826 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
827
6de0e799
GM
828 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
829 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
830
b82da769
GM
8312012-07-12 Glenn Morris <rgm@gnu.org>
832
4fae5a7a 833 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
834
835 * process.c (init_process_emacs): Rename from init_process.
836 The old name is also the name of a Mach system call.
837 * lisp.h, emacs.c: Update for this name change.
838 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
839 longer needed.
840
5a979817
EZ
8412012-07-12 Eli Zaretskii <eliz@gnu.org>
842
843 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
844 memmove call that removes glyphs covered by the left truncation
845 glyph. Improve commentary.
846 (display_line): Fix display of continuation glyphs on GUI frames
847 when the right fringe is turned off and variable-size fonts are
848 used in the window. Move the code that appends a stretch glyph to
849 produce_special_glyphs, so that it could be used for truncation
850 and continuation glyphs alike.
851 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
852 glyph of a suitably computed width, to align the special glyphs at
853 the window margin. Code moved from display_line. (Bug#11832)
854
3e91a053
GM
8552012-07-12 Glenn Morris <rgm@gnu.org>
856
ba9e4b84
GM
857 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
858
859 * s/gnu-linux.h, s/hpux10-20.h:
860 Do not unconditionally define HAVE_XRMSETDATABASE.
861
3e91a053
GM
862 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
863
b300b1f4
PE
8642012-07-12 Paul Eggert <eggert@cs.ucla.edu>
865
866 Fix typos that broke OS X build.
867 Reported by Randal L. Schwartz in
868 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
869 * nsterm.m (ns_timeout): Add missing local decl.
870 (ns_get_color): snprintf -> sprintf, to fix typo.
871
6e777848
GM
8722012-07-12 Glenn Morris <rgm@gnu.org>
873
3f922c37
GM
874 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
875 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
876 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
877 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
878
0ab7b23a
GM
879 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
880 Move PTY_OPEN to configure.
881
6e777848
GM
882 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
883 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
884 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
885
4a7edc24
DA
8862012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
887
888 Use empty_unibyte_string where applicable.
889 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
890 * lread.c (read1): Likewise.
891 * xsettings.c (syms_of_xsettings): Likewise.
892
308aab79
GM
8932012-07-12 Glenn Morris <rgm@gnu.org>
894
42bd1719
GM
895 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
896 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
897 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
898 * s/hpux10-20.h (RUN_TIME_REMAP):
899 * s/bsd-common.h (TABDLY): Move to configure.
900
901 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
902
903 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
904
ea0bbd17 905 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 906 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
907
908 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 909
308aab79
GM
910 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
911 * s/template.h: Move NARROWPROTO to configure.
912
ee1cf5cf
GM
9132012-07-11 Glenn Morris <rgm@gnu.org>
914
30fe9bf4
GM
915 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
916 unused since 2011-01-17 change to systty.h.
917
ee1cf5cf
GM
918 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
919 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
920 Move HAVE_PTYS and HAVE_SOCKETS to configure.
921
63e47e07
PE
9222012-07-11 Paul Eggert <eggert@cs.ucla.edu>
923
924 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
925
c43fb4c3
GM
9262012-07-11 Glenn Morris <rgm@gnu.org>
927
928 * s/darwin.h, s/gnu-linux.h, s/template.h:
929 Move INTERRUPT_INPUT to configure.
930
e8df9267
DA
9312012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
932
933 Minor adjustments to interning code.
934 * lisp.h (intern, intern_c_string): Redefine as static inline
935 wrappers for intern_1 and intern_c_string_1, respectively.
936 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
937 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
938 Vobarray checking.
e8df9267
DA
939 * font.c (font_intern_prop): Likewise. Adjust comment.
940 * w32font.c (intern_font_name): Likewise.
941
34348bd4
AS
9422012-07-11 Andreas Schwab <schwab@linux-m68k.org>
943
d96a1e0c
AS
944 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
945
34348bd4
AS
946 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
947 of Fcar/Fcdr if possible.
948 * font.c (check_otf_features): Likewise.
949 * fontset.c (Fnew_fontset): Likewise.
950 * gnutls.c (Fgnutls_boot): Likewise.
951 * minibuf.c (read_minibuf): Likewise.
952 * msdos.c (IT_set_frame_parameters): Likewise.
953 * xmenu.c (Fx_popup_dialog): Likewise.
954 * w32menu.c (Fx_popup_dialog): Likewise.
955
c8add24e
GM
9562012-07-11 Glenn Morris <rgm@gnu.org>
957
4b575b3c
GM
958 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
959 since nothing has defined it on these platforms.
960
09f4e3b0
GM
961 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
962 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
963
172bedef
GM
964 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
965 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
966 Move CLASH_DETECTION to configure.
967
249685df
GM
968 * s/gnu.h: Remove file, which is now empty.
969
c8add24e
GM
970 * s/gnu.h, s/gnu-linux.h:
971 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
972
b41253a3
JW
9732012-07-11 John Wiegley <johnw@newartisans.com>
974
975 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
976 function attribute, so we only use it if it exists in the
977 compiler.
978
d923b542
DA
9792012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
980
981 Avoid call to strlen in fast_c_string_match_ignore_case.
982 * search.c (fast_c_string_match_ignore_case): Change to use
983 length argument. Adjust users accordingly.
984 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
985
5ebbef1d
PE
9862012-07-11 Paul Eggert <eggert@cs.ucla.edu>
987
bb352260
PE
988 Assume mkdir, rmdir.
989 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
990 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
991
57054ddd
PE
992 Assume rename.
993 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
994
b747d3f7
PE
995 Assume perror.
996 * s/hpux10-20.h (HAVE_PERROR): Remove.
997 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
998 Remove dummy definition, as this problem was obsolete long ago.
999
5ebbef1d
PE
1000 Assume strerror.
1001 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1002
984e7f30
DA
10032012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 Avoid calls to strlen in font processing functions.
1006 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1007 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1008 users accordingly.
d923b542
DA
1009 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1010 Adjust prototypes.
1011 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1012 Change to return ptrdiff_t.
984e7f30
DA
1013 (xfont_list_pattern, xfont_match): Use length returned by
1014 xfont_decode_coding_xlfd.
1015 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1016
20e94fdd
GM
10172012-07-11 Glenn Morris <rgm@gnu.org>
1018
9d596af3
GM
1019 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1020 Move DONT_REOPEN_PTY to configure.
1021
20e94fdd
GM
1022 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1023 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1024
e99a530f
PE
10252012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1026
22ffb973
PE
1027 Remove "#define unix" that is no longer needed (Bug#11905).
1028 * s/aix4-2.h (unix): Remove; no longer needed.
1029
e9a9ae03
PE
1030 EMACS_TIME simplification (Bug#11875).
1031 This replaces macros (which typically do not work in GDB)
1032 with functions, typedefs and enums, making the code easier to debug.
1033 The functional style also makes code easier to read and maintain.
1034 * systime.h: Include <sys/time.h> on all hosts, not just if
1035 WINDOWSNT, since 'struct timeval' is needed in general.
1036 (EMACS_TIME): Now a typedef, not a macro.
1037 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1038 not macros.
1039 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1040 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1041 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1042 (EMACS_TIME_LE): Now functions, not macros.
1043 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1044 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1045 which are not functions. All uses rewritten to use:
1046 (make_emacs_time): New function.
1047 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1048 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1049 not functions. All uses rewritten to use the following, respectively:
1050 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1051 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1052 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1053 * fileio.c (Fcopy_file):
1054 * xterm.c (XTflash): Get the current time closer to when it's used.
1055 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1056
ffacb126
PE
1057 * bytecode.c (targets): Suppress -Woverride-init warnings.
1058
e99a530f
PE
1059 Simplify by avoiding confusing use of strncpy etc.
1060 * doc.c (Fsnarf_documentation):
1061 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1062 * frame.c (Fmake_terminal_frame):
1063 * gtkutil.c (get_utf8_string):
1064 * lread.c (openp):
1065 * nsmenu.m (ns_update_menubar):
1066 * regex.c (regerror):
1067 Prefer memcpy to strncpy and strncat when either will do.
1068 * fileio.c (Fsubstitute_in_file_name):
1069 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1070 (menu_separator_name_p):
1071 * nsmenu.m (ns_update_menubar):
1072 Prefer memcmp to strncmp when either will do.
1073 * nsterm.m: Include <ftoastr.h>.
1074 (ns_get_color):
1075 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1076 Prefer snprintf to strncpy.
1077 * nsterm.m (ns_term_init):
1078 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1079 * nsterm.m (ns_term_init):
1080 Avoid the need for strncpy, by using build_string or
1081 make_unibyte_string directly. Use dtoastr, not snprintf.
1082 * process.c (Fmake_network_process): Diagnose service names that
1083 are too long, rather than silently truncating them or creating
1084 non-null-terminated names.
1085 (Fnetwork_interface_info): Likewise, for interface names.
1086 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1087 Prefer sprintf to strncat.
1088 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1089 Prefer vsnprintf to vsprintf + strncpy.
1090
c59592b3
GM
10912012-07-10 Glenn Morris <rgm@gnu.org>
1092
1093 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1094 Clarify fallback case.
1095
7d7bbefd
DA
10962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1097
1098 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1099 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1100 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1101 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1102 where argument type is known to be a Lisp_Cons.
1103
3a4c8000
TT
11042012-07-10 Tom Tromey <tromey@redhat.com>
1105
1106 * bytecode.c (BYTE_CODE_THREADED): New macro.
1107 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1108 (enum byte_code_op): New type.
1109 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1110 (exec_byte_code): Use them. Use token threading when applicable.
1111
2a0213a6
DA
11122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1113
1114 Optimize pure C strings initialization.
1115 * lisp.h (make_pure_string): Fix prototype.
1116 (build_pure_c_string): New function, defined as static inline. This
1117 provides a better opportunity to optimize away calls to strlen when
1118 the function is called with compile-time constant argument.
1119 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1120 argument, adjust users accordingly. Use build_pure_c_string where
1121 appropriate.
1122 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1123 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1124 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1125
cb1caeaf
DA
11262012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1127
1128 Avoid calls to strlen in miscellaneous functions.
1129 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1130 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1131 * lread.c (openp): Likewise.
1132
c293e30c
DA
11332012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 Avoid calls to strlen in path processing functions.
1136 * fileio.c (file_name_as_directory): Add comment. Change to add
1137 srclen argument and return the length of result. Adjust users
1138 accordingly.
1139 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1140 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1141 users accordingly.
1142 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1143
9e059e3f
GM
11442012-07-10 Glenn Morris <rgm@gnu.org>
1145
d02eb359
GM
1146 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1147 Move PENDING_OUTPUT_COUNT definition to configure.
1148
882cf227
GM
1149 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1150 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1151 * s/gnu.h (DATA_START): Move definitions to configure.
1152
af6e839f
GM
1153 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1154 We include usg5-4-common.h, which defines them both.
1155
40289a12
GM
1156 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1157 O_RDONLY already includes it).
1158
9e059e3f
GM
1159 Stop ns builds setting the EMACSLOADPATH environment variable.
1160 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1161 Now it does not set EMACSLOADPATH, just returns the load-path string.
1162 * nsterm.h: Update accordingly.
1163 * lread.c [HAVE_NS]: Include nsterm.h.
1164 (init_lread) [HAVE_NS]: Use ns_load_path.
1165 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1166
7c4e8ec0
GM
11672012-07-09 Glenn Morris <rgm@gnu.org>
1168
d4f600ff
GM
1169 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1170 since the included bsd-common.h does so.
1171
cbb31951
GM
1172 Stop ns builds setting the EMACSPATH environment variable.
1173 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1174 (ns_init_paths): Do not set EMACSPATH.
1175 * nsterm.h (ns_exec_path): Add it.
1176 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1177 Use ns_exec_path.
1178
7c4e8ec0
GM
1179 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1180
26bccfae
PE
11812012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1182
a0bee46f
PE
1183 * process.c (wait_reading_process_output): 'waitchannels' was unset
1184 when read_kbd || !NILP (wait_for_cell); fix this.
1185
5994c183
PE
1186 Add GCC-style 'const' attribute to functions that can use it.
1187 * character.h (char_resolve_modifier_mask):
1188 * keyboard.h (make_ctrl_char):
1189 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1190 (init_character_once, next_almost_prime, init_fns, init_image)
1191 (flush_pending_output, init_sound):
1192 * mem-limits.h (start_of_data):
1193 * menu.h (finish_menu_items):
1194 Add ATTRIBUTE_CONST.
1195 * emacs.c (DEFINE_DUMMY_FUNCTION):
1196 Declare the dummy function with ATTRIBUTE_CONST.
1197 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1198 Add decls with ATTRIBUTE_CONST.
1199
26bccfae
PE
1200 Minor improvements to make_formatted_string.
1201 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1202 where int is good enough, as vsprintf returns an int.
1203 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1204
a8290ec3
DA
12052012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Use make_formatted_string to avoid double length calculation.
1208 * lisp.h (make_formatted_string): New prototype.
1209 * alloc.c (make_formatted_string): New function.
1210 * buffer.c (Fgenerate_new_buffer_name): Use it.
1211 * dbus.c (syms_of_dbusbind): Likewise.
1212 * editfns.c (Fcurrent_time_zone): Likewise.
1213 * filelock.c (get_boot_time): Likewise.
1214 * frame.c (make_terminal_frame, set_term_frame_name)
1215 (x_report_frame_params): Likewise.
1216 * image.c (gs_load): Likewise.
1217 * minibuf.c (get_minibuffer): Likewise.
1218 * msdos.c (dos_set_window_size): Likewise.
1219 * process.c (make_process): Likewise.
1220 * xdisp.c (ensure_echo_area_buffers): Likewise.
1221 * xsettings.c (apply_xft_settings): Likewise.
1222
d01ba2f1
GM
12232012-07-09 Glenn Morris <rgm@gnu.org>
1224
1225 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1226 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1227 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1228 * nsterm.h (ns_etc_directory): Add it.
1229 * callproc.c [HAVE_NS]: Include nsterm.h.
1230 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1231
f1f924b6
DA
12322012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1233
1234 Move marker debugging code under MARKER_DEBUG.
1235 * marker.c (MARKER_DEBUG): Move marker debugging code under
1236 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1237 for bootstrap with --enable-checking (~3x slowdown reported
1238 by Juanma Barranquero <lekktu@gmail.com>).
1239 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1240
ab531b66
PE
12412012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1244 See <http://bugs.gnu.org/11825#29>.
1245
c4b3bc8a
EZ
12462012-07-08 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1249 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1250 (display_line): Add commentary about displaying truncation glyphs
1251 on GUI frames.
1252 (produce_special_glyphs): Move here from term.c.
1253
1254 * term.c (produce_special_glyphs): Move to xdisp.c.
1255
1256 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1257 section.
c4b3bc8a 1258
b676b881
AS
12592012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1260
f17c5273
AS
1261 * xdisp.c (display_line): Avoid warning about implicit declaration
1262 of FRAME_FONT.
1263
298819b9
AS
1264 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1265
b676b881
AS
1266 * lisp.h: Remove empty conditional.
1267
6045c4fd
PE
12682012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1269
b3350bf9
PE
1270 * lread.c (load_path_check): Now static.
1271
6045c4fd
PE
1272 Fix some minor --with-ns problems found by static checking.
1273 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1274 (x_set_font) [!HAVE_X_WINDOWS]:
1275 * image.c (xpm_load_image) [HAVE_NS]:
1276 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1277 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1278 Remove unused local.
1279 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1280 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1281 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1282 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1283 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1284 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1285 Fix pointer signedness problem.
1286 * xfaces.c (FRAME_X_FONT_TABLE):
1287 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1288
929e7845
GM
12892012-07-07 Glenn Morris <rgm@gnu.org>
1290
1291 * lread.c (load_path_check): New function, split from init_lread.
1292 (init_lread): Reorganize. Motivation:
1293 If EMACSLOADPATH is set, check/warn about that rather than the
1294 defaults, which we are not going to use. Hence we can remove
1295 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1296 Don't warn if site-lisp directories are missing.
1297 If not installed, start from a blank load-path, since
1298 PATH_LOADSEARCH refers to the eventual installation directories.
1299
58dd0aa4
EZ
13002012-07-07 Eli Zaretskii <eliz@gnu.org>
1301
1302 Support truncation and continuation glyphs on GUI frames, when
1303 fringes are disabled. (Bug#11832)
1304 * xdisp.c (init_iterator): Get dimensions of truncation and
1305 continuation glyphs even if on GUI frames. Adjust
1306 it->last_visible_x on GUI frames when the left or right fringes,
1307 or both, are absent.
1308 (start_display, move_it_in_display_line_to): Handle the case of a
1309 GUI frame without a fringe to display continuation or truncation
1310 glyphs.
1311 (insert_left_trunc_glyphs): Support GUI frames: make sure
1312 truncation glyphs overwrite enough glyphs from the current line to
1313 have sufficient space in pixels.
1314 (display_line): Support truncation and continuation glyphs on GUI
1315 frames. If some spare pixels are left on the line after inserting
1316 the truncation glyphs, fill that space with a stretch glyph of a
1317 suitably computed width.
1318
1319 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1320 produce_glyphs, to support GUI sessions.
1321
31571fd7
PE
13222012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1323
5a16b9bc
PE
1324 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1325
f3047c75
PE
1326 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1327
31571fd7
PE
1328 Do not require float-time's arg to fit in time_t (Bug#11825).
1329 This works better on hosts where time_t is unsigned, and where
1330 float-time is applied to the (negative) difference between two times.
1331 * editfns.c (decode_time_components): Last arg is now double *,
1332 not int *, and means to store all the result as a double, without
1333 worrying about whether the seconds part fits in time_t.
1334 All callers changed.
1335 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1336 All callers changed.
1337 (Ffloat_time): Do not fail merely because the specified time falls
1338 outside of time_t range.
1339
4516fbef
GM
13402012-07-07 Glenn Morris <rgm@gnu.org>
1341
1342 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1343 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1344 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1345
07adc2c6
JB
13462012-07-07 Juanma Barranquero <lekktu@gmail.com>
1347
1348 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1349 Update dependencies.
1350
1351 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1352
fd573f31
PE
13532012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1354
fee5959d
PE
1355 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1356 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1357 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1358 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1359 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1360 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1361
fd573f31
PE
1362 * xfont.c (compare_font_names): Redo to omit the need for casts.
1363
ddadbc0e
AS
13642012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1365
fca8d6b6
AS
1366 * xfns.c (Fx_change_window_property): Doc fix.
1367 * w32fns.c (Fx_change_window_property): Doc fix.
1368
ddadbc0e
AS
1369 * w32fns.c (Fx_window_property): Accept the same arguments as the
1370 X Windows version. Doc fix.
1371 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1372
ed9265fc 13732012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1374 Eli Zaretskii <eliz@gnu.org>
1375
1376 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1377 Windows-specific code from nt/config.nt moved here.
1378 Obsolete settings removed.
1379
216ee680
PE
13802012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 * process.c: Avoid unnecessary calls to gettime.
1383 (wait_reading_process_output): Don't get the time of day
1384 when gobbling data immediately and not waiting, as there's no need
1385 for it in that case. This removes a FIXME.
1386
bdd091e4
JD
13872012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1390 is defined (Bug#11768).
1391
9d44f8ce
DA
13922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1393
1394 Fix marker debugging code.
1395 * marker.c (byte_char_debug_check): Do not perform the check
1396 if buffer is not multibyte.
090bd7cb
JB
1397 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1398 Call byte_char_debug_check with correct arguments.
9d44f8ce 1399
90fc4786
DA
14002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1403 * marker.c (byte_char_debug_check, count_markers):
1404 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1405 (byte_debug_flag): Remove.
1406 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1407 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1408
7b7ae965
DA
14092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1410
4e57b342
DA
1411 Avoid code repetition in marker-related functions.
1412 * marker.c (attach_marker): New function.
1413 (Fset_marker, set_marker_restricted, set_marker_both)
1414 (set_marker_restricted_both): Use it.
1415 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1416 Consistently rename charno to charpos.
1417 (marker_position): Add eassert.
1418 (marker_byte_position): Convert to eassert.
1419
14202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1423 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1424 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1425
657924ff
DA
14262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 Introduce fast path for the widely used marker operation.
1429 * alloc.c (build_marker): New function.
1430 * lisp.h (build_marker): New prototype.
1431 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1432 * composite.c (autocmp_chars): Likewise.
1433 * editfns.c (buildmark): Remove.
1434 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1435 (save_restriction_save): Use build_marker.
1436 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1437 * window.c (save_window_save): Likewise.
1438
041a49a6
DA
14392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1440
1441 Do not use Fdelete_overlay in delete_all_overlays
1442 to avoid redundant calls to unchain_overlay.
1443 * buffer.c (drop_overlay): New function.
1444 (delete_all_overlays, Fdelete_overlay): Use it.
1445 * minibuf.c (get_minibuffer): Fix comment.
1446
7dca65a4
PE
14472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 Port to OpenBSD 5.1 amd64.
1450 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1451 This is needed for OpenBSD, and should be harmless on all BSD systems.
1452 Also, include <sys/sysctl.h>, as it should be available on all
1453 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1454 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1455 use p_pid member, not kp_proc.pid.
1456
8eb876e2
GM
14572012-07-06 Glenn Morris <rgm@gnu.org>
1458
1459 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1460
38182d90
PE
14612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 More xmalloc and related cleanup.
1464 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1465 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1466 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1467 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1468 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1469 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1470 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1471 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1472 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1473 * xterm.c:
1474 Omit needless casts involving void * pointers and allocation.
1475 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1476 as the former is more robust if P's type is changed.
1477 Prefer xzalloc to xmalloc + memset 0.
1478 Simplify malloc-or-realloc to realloc.
1479 Don't worry about xmalloc returning a null pointer.
1480 Prefer xstrdup to xmalloc + strcpy.
1481 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1482 growing it.
1483 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1484 alloca of a constant.
1485
6dd5a677
EZ
14862012-07-05 Eli Zaretskii <eliz@gnu.org>
1487
1488 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1489 hscroll is larger than the line width. Fixes long and futile
1490 looping inside extend_face_to_end_of_line (on a TTY) producing
1491 glyphs that are not needed and thrown away.
1492
6b312f0f
DA
14932012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1494
1495 * marker.c (set_marker_restricted_both): Simplify by using
1496 clip_to_bounds.
1497
f520ef9b
PE
14982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1501
383b7c95
JD
15022012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1503
1504 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1505 not defined (Bug#11768).
1506 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1507 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1508 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1509 followed by gtk_box_set_homogeneous (Bug#11768).
1510 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1511 (update_theme_scrollbar_width, xg_create_scroll_bar):
1512 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1513 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1514 (is_box_type): New function (Bug#11768).
1515 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1516 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1517 with default display (Bug#11768).
1518
d6e7bf45
EZ
15192012-07-05 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (window_hscroll_limited): New function.
1522 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1523 coordinates when window's hscroll is set to insanely large
1524 values. (Bug#11857)
1525
431391ec
JB
15262012-07-05 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1529 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1530
23f86fce
DA
15312012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1532
1533 Cleanup xmalloc.
1534 * lisp.h (xzalloc): New prototype. Omit needless casts.
1535 * alloc.c (xzalloc): New function. Omit needless casts.
1536 * charset.c: Omit needless casts. Convert all calls to
1537 xmalloc with following memset to xzalloc.
1538 * dispnew.c: Likewise.
1539 * fringe.c: Likewise.
1540 * image.c: Likewise.
1541 * sound.c: Likewise.
1542 * term.c: Likewise.
1543 * w32fns.c: Likewise.
1544 * w32font.c: Likewise.
1545 * w32term.c: Likewise.
1546 * xfaces.c: Likewise.
1547 * xfns.c: Likewise.
1548 * xterm.c: Likewise.
1549 * atimer.c: Omit needless casts.
1550 * buffer.c: Likewise.
1551 * callproc.c: Likewise.
1552 * ccl.c: Likewise.
1553 * coding.c: Likewise.
1554 * composite.c: Likewise.
1555 * doc.c: Likewise.
1556 * doprnt.c: Likewise.
1557 * editfns.c: Likewise.
1558 * emacs.c: Likewise.
1559 * eval.c: Likewise.
1560 * filelock.c: Likewise.
1561 * fns.c: Likewise.
1562 * gtkutil.c: Likewise.
1563 * keyboard.c: Likewise.
1564 * lisp.h: Likewise.
1565 * lread.c: Likewise.
1566 * minibuf.c: Likewise.
1567 * msdos.c: Likewise.
1568 * print.c: Likewise.
1569 * process.c: Likewise.
1570 * region-cache.c: Likewise.
1571 * search.c: Likewise.
1572 * sysdep.c: Likewise.
1573 * termcap.c: Likewise.
1574 * terminal.c: Likewise.
1575 * tparam.c: Likewise.
1576 * w16select.c: Likewise.
1577 * w32.c: Likewise.
1578 * w32reg.c: Likewise.
1579 * w32select.c: Likewise.
1580 * w32uniscribe.c: Likewise.
1581 * widget.c: Likewise.
1582 * xdisp.c: Likewise.
1583 * xmenu.c: Likewise.
1584 * xrdb.c: Likewise.
1585 * xselect.c: Likewise.
1586
0497dc44
PE
15872012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * fileio.c (time_error_value): Check the right error number.
1590 Problem reported by Troels Nielsen in
1591 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1592
356e7178
PE
15932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1594
4e71fd89
PE
1595 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1596 This should be fixed in a better way; see Eli Zaretskii in
1597 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1598 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1599
f0941253
PE
1600 * fileio.c (time_error_value): Rename from special_mtime.
1601 The old name's problems were noted by Eli Zaretskii in
1602 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1603
065c9eb4
PE
1604 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1605 This variable's comment says Emacs needs at least one GDB-visible
1606 symbol of type enum pvec_type, to work around GDB problems.
1607 The symbol's value doesn't matter.
1608
356e7178
PE
1609 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1610 that causes compilation to fail on pre-C99 compilers.
1611
ed9265fc 16122012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1613
1614 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1615 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1616
3884d954
DA
16172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1618
d209e2fb 1619 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1620 headers for buffer_defaults and buffer_local_symbols.
1621 Reported by Juanma Barranquero <lekktu@gmail.com>.
1622
ee28be33
SM
16232012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1626 * lisp.h (enum pvec_type): Use fewer bits.
1627 (PSEUDOVECTOR_SIZE_BITS): New constant.
1628 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1629 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1630 change in pvec_type.
1631 (PSEUDOVECTOR_TYPEP): New macro.
1632 (TYPED_PSEUDOVECTORP): Use it.
1633 * fns.c (internal_equal): Adapt code to extract pvectype.
1634 * emacs.c (gdb_pvec_type): Update type.
1635 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1636 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1637 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1638 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1639 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1640 abusing vector->header.next.nbytes.
1641 (live_vector_p): Use PVEC_TYPE.
1642 (mark_object): Adapt code to extract pvectype. Use switch.
1643
c7f2cd7f
PE
16442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1647 Tighten new eassert a bit.
1648
8ce70ed2
DA
16492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1650
1651 Fix compilation with --enable-gcc-warnings and -O1
1652 optimization level.
1653 * doprnt.c (doprnt): Change type of tem to int, initialize
1654 to avoid compiler warning. Add eassert.
1655 * search.c (simple_search): Initialize match_byte to avoid
1656 compiler warning. Add eassert.
1657
dea7f1e5
PE
16582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1659
24a212eb
PE
1660 Avoid weird behavior with large horizontal scrolls.
1661 Without this change, for example, large hscroll values would
1662 mess up Emacs's display on Fedora 15 x86, presumably due to
1663 overflows in int calculations in the display code.
1664 Also, if buffers had long lines, Emacs would freeze.
1665 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1666 (set_window_hscroll): New function, containing the old guts of
1667 Fset_window_hscroll. Return the clipped value.
1668 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1669 This avoids the need to check against PTRDIFF_MAX.
1670
dea7f1e5
PE
1671 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1672
76046526
DA
16732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1674
1675 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1676
39adff0d
PE
16772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1678
63807d47
PE
1679 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1680 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1681 since GCC 4.4.6 issues a bogus warning for them.
1682
39adff0d
PE
1683 Fix bugs in file timestamp newness comparisons.
1684 * fileio.c (Ffile_newer_than_file_p):
1685 * lread.c (Fload): Use full timestamp resolution of files,
1686 not just the 1-second resolution, so that files that are only
1687 slightly newer still count as newer.
1688 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1689 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1690
dbeed9a6
PE
16912012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * fileio.c: Improve handling of file time marker. (Bug#11852)
1694 (special_mtime): New function.
1695 (Finsert_file_contents, Fverify_visited_file_modtime):
1696 Use it to set special mtime values consistently.
1697
636334d6
AS
16982012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1699
1700 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1701 marker for non-existing file. (Bug#11852)
1702
e2017fe2
GM
17032012-07-03 Glenn Morris <rgm@gnu.org>
1704
1705 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1706 and did not make it into globals.h).
1707
404dbd37
TT
17082012-07-03 Tom Tromey <tromey@redhat.com>
1709
1710 * window.c (Fset_window_margins, Fset_window_fringes)
1711 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1712 * textprop.c (Fprevious_property_change): No longer static.
1713 * syntax.c (Fsyntax_table_p): No longer static.
1714 * process.c (Fget_process, Fprocess_datagram_address): No longer
1715 static.
1716 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1717 * keyboard.c (Fcommand_execute): No longer static.
1718 Remove EXFUN.
1719 * insdel.c (Fcombine_after_change_execute): No longer static.
1720 * image.c (Finit_image_library): No longer static.
1721 * fileio.c (Fmake_symbolic_link): No longer static.
1722 * eval.c (Ffetch_bytecode): No longer static.
1723 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1724 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1725 No longer static.
404dbd37
TT
1726 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1727 static.
1728 * dired.c (Ffile_attributes): No longer static.
1729 * composite.c (Fcomposition_get_gstring): No longer static.
1730 * callproc.c (Fgetenv_internal): No longer static.
1731
1732 * ccl.h: Remove EXFUNs.
1733 * buffer.h: Remove EXFUNs.
1734 * dispextern.h: Remove EXFUNs.
1735 * intervals.h: Remove EXFUNs.
1736 * fontset.h: Remove EXFUN.
1737 * font.h: Remove EXFUNs.
1738 * dosfns.c (system_process_attributes): Remove EXFUN.
1739 * keymap.h: Remove EXFUNs.
1740 * lisp.h: Remove EXFUNs.
1741 * w32term.h: Remove EXFUNs.
1742 * window.h: Remove EXFUNs.
1743 * xsettings.h: Remove EXFUN.
1744 * xterm.h: Remove EXFUN.
1745
8e4fd1e1
GM
17462012-07-03 Glenn Morris <rgm@gnu.org>
1747
1748 * lisp.h (Frandom): Make it visible to C.
1749 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1750 buffer for invisible buffers. (Bug#1229)
1751
ca95b3eb
DA
17522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1753
1754 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1755 values which aren't power of 2.
1756 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1757 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1758 accordingly.
1759
7555c33f
SM
17602012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1763
1764 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1765
d12e8f5a
DA
17662012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1767
1768 * alloc.c (allocate_vector_block): Remove redundant
1769 calls to mallopt if DOUG_LEA_MALLOC is defined.
1770 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1771 avoid calls to mallopt if zero_vector is returned.
1772
296094c3
DA
17732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1774
1775 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1776 is enabled, avoid dereferencing NULL current_sblock if
1777 running undumped.
1778
36429c89
DA
17792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1780
1781 Cleanup basic buffer management.
1782 * buffer.h (struct buffer): Change layout to use generic vector
1783 marking code. Fix some comments. Change type of 'clip_changed'
1784 to bitfield. Remove unused #ifndef old.
1785 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1786 (GET_OVERLAYS_AT): Fix indentation.
1787 (for_each_per_buffer_object_at): New macro.
1788 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1789 (Fbuffer_local_variables): Use it.
1790 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1791 * alloc.c (allocate_buffer): Adjust to match new layout of
1792 struct buffer. Fix comment.
1793 (mark_overlay): New function.
1794 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1795 Lisp area of struct buffer.
1796 (mark_object): Use it. Adjust marking of misc objects
1797 and related comments.
1798
3b3e4cac
PE
17992012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1802 wrapper that is not needed because the wrapped code is a no-op (zero
1803 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1804 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1805
cf5c0175
DA
18062012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1807
1808 * alloc.c (mark_buffer): Simplify. Remove prototype.
1809 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1810 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1811 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1812 redundant calls to mark_vectorlike for bool vectors.
1813
ca26824c
GM
18142012-06-30 Glenn Morris <rgm@gnu.org>
1815
2e4c5312
GM
1816 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1817
ca26824c
GM
1818 * epaths.in (PATH_SITELOADSEARCH): New.
1819 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1820 This is rather than relying on --enable-locallisppath elements
1821 having "site-lisp" in their names. (Bug#10208#25, 11658)
1822
0d23c240
EZ
18232012-06-30 Eli Zaretskii <eliz@gnu.org>
1824
c9240d7a
EZ
1825 * w32proc.c (sys_select): Accept and ignore one more argument.
1826
1827 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1828
0d23c240 1829 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1830 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1831
1832 * sysdep.c: Don't include dos.h and dosfns.h.
1833
1834 * process.c (sys_select):
1835 * msdos.c (sys_select): Accept one more argument and ignore it.
1836
1837 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1838 adapt data types and code to that.
1839
1840 * dosfns.c:
1841 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1842 which clashes with the gnulib function of the same name.
1843
af5a5a98
AS
18442012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1845
c5e4379c
AS
1846 * font.c (font_style_to_value, font_style_symbolic)
1847 (font_prop_validate_style): Add type checks for values in
1848 font_style_table.
1849
af5a5a98
AS
1850 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1851 argument.
1852 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1853 uses.
1854
8d38f461
EZ
18552012-06-29 Eli Zaretskii <eliz@gnu.org>
1856
2e5a6631
EZ
1857 * xdisp.c (try_window_id): Undo last change.
1858
8d38f461
EZ
1859 * w32.c (getwd): Adjust commentary about startup_dir.
1860 (init_environment): Always call sys_access, even in non-MSVC
1861 builds. Don't chdir to the directory of the Emacs executable.
1862 This undoes code from 1997 which was justified by the need to
1863 "avoid conflicts when removing and renaming directories". But its
1864 downside was that every relative file name was being interpreted
1865 relative to the directory of the Emacs executable, which can never
1866 be TRT. In particular, it broke sys_access when called with
1867 relative file names.
1868 (sys_access): Map GetLastError to errno.
1869
2af3565e
DA
18702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1871
1872 * window.h (struct window): Change type of 'fringes_outside_margins'
1873 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1874 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1875 Adjust comment.
1876 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1877 to ptrdiff_t.
1878
c8d3a25c 18792012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1880
c8d3a25c
GM
1881 * gnutls.c (emacs_gnutls_handshake):
1882 Add QUIT to make the loop interruptible.
57570cd3 1883
c8d3a25c 18842012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1885
c8d3a25c
GM
1886 * charset.c (init_charset): Make lack of etc/charsets fatal.
1887
3e984ee8
DA
18882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1889
1890 * editfns.c (region_limit): Fix type mismatch.
1891
ef884f23
DA
18922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1893
1894 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1895 undefined. Convert from xassert to eassert.
1896 * nsmenu.m: Convert from xassert to eassert.
1897 * nsterm.m: Likewise.
1898
7d7e0027
SM
18992012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1900
1901 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1902
aa754e6a
PE
19032012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 Avoid integer overflow on scroll-left and scroll-right.
1906 * window.c (HSCROLL_MAX): New macro.
1907 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1908 overflow when requested scroll falls outside ptrdiff_t range.
1909
80b00b08
DA
19102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1911
1912 * window.h (struct window): Change type of 'hscroll',
1913 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1914 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1915 Adjust users accordingly.
1916 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1917 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1918 from EMACS_INT to ptrdiff_t.
1919 (make_window): Omit redundant initialization.
1920
62b2bcf6
JB
19212012-06-28 Juanma Barranquero <lekktu@gmail.com>
1922
1923 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1924
45942c7d
DA
19252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1926
1927 * window.h (struct window): Change type of 'use_time' and
1928 'sequence_number' from Lisp_Object to int.
1929 * frame.c (make_frame): Adjust users accordingly.
1930 * print.c (print_object): Likewise.
1931 * window.c (select_window, Fwindow_use_time, make_parent_window)
1932 (make_window): Likewise.
1933
e509cfa6
DA
19342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1937 enabled with --enable-checking=[all,glyphs] configure option.
1938 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1939 adjust comments accordingly.
1940 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1941 undefined, adjust comments accordingly.
1942 * image.c: Likewise.
1943 * scroll.c: Likewise.
1944 * w32fns.c: Likewise.
1945 * w32term.c: Likewise.
1946 * xdisp.c: Likewise.
1947 * xfaces.c: Likewise.
1948 * xfns.c: Likewise.
1949 * xterm.c: Likewise.
1950
a54e2c05
DA
19512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1952
1953 Generalize run-time debugging checks.
1954 * dispextern.h (XASSERTS): Remove.
1955 * fontset.c (xassert): Remove.
1956 Convert from xassert to eassert.
1957 * alloc.c: Convert from xassert to eassert.
1958 * bidi.c: Likewise.
1959 * dispnew.c: Likewise.
1960 * fns.c: Likewise.
1961 * fringe.c: Likewise.
1962 * ftfont.c: Likewise.
1963 * gtkutil.c: Likewise.
1964 * image.c: Likewise.
1965 * keyboard.c: Likewise.
1966 * menu.c: Likewise.
1967 * process.c: Likewise.
1968 * scroll.c: Likewise.
1969 * sound.c: Likewise.
1970 * term.c: Likewise.
1971 * w32console.c: Likewise.
1972 * w32fns.c: Likewise.
1973 * w32term.c: Likewise.
1974 * window.c: Likewise.
1975 * xdisp.c: Likewise.
1976 * xfaces.c: Likewise.
1977 * xfns.c: Likewise.
1978 * xselect.c: Likewise.
1979 * xterm.c: Likewise.
1980
1ec4b7b2
SM
19812012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * fns.c (maybe_resize_hash_table): Output message when growing the
1984 purify-hashtable.
1985
2014308a
DA
19862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 * alloc.c (allocate_string_data): Remove dead code.
1989 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1990 avoid GCC warning about unused macro.
1991
246155eb
DA
19922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 * alloc.c (allocate_string): Omit intervals initialization.
1995 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1996 as in make_pure_string and make_pure_c_string.
1997
43184b7b
DA
19982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1999
d209e2fb 2000 * alloc.c (allocate_string): Fix last change.
43184b7b 2001
3fe6dd74
DA
20022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2003
d209e2fb 2004 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2005 to memset, add explicit initialization where appropriate.
2006
1ba6038a
GM
20072012-06-27 Glenn Morris <rgm@gnu.org>
2008
2009 * lisp.mk (lisp): Remove paths.elc.
2010
c89926a5
CY
20112012-06-27 Chong Yidong <cyd@gnu.org>
2012
2013 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2014
ed6b3510
JW
20152012-06-26 John Wiegley <johnw@newartisans.com>
2016
1ec4b7b2 2017 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2018 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2019
ed6b3510
JW
2020 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2021 when building with Clang.
2022
8edd4a2b
SM
20232012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2024
2025 * eval.c (Fapply): Allow calling it with a single argument.
2026
f6f62d1b
EZ
20272012-06-26 Eli Zaretskii <eliz@gnu.org>
2028
2029 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2030 _stricmp and _strnicmp.
2031 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2032
62efea5e
DA
20332012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2036 allocated window.
2037 (allocate_process): Likewise for new process.
8edd4a2b 2038 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2039 (allocate_frame): Likewise.
2040 * frame.c (make_frame): Omit redundant initialization.
2041 * window.c (make_parent_window): Use memset.
2042 (make_window): Omit redundant initialization.
2043 * process.c (make_process): Omit redundant initialization.
2044 * terminal.c (create_terminal): Likewise.
2045
42997f4d
DA
20462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 * term.c (delete_tty): Remove redundant call to memset.
2049
1130ecfc
DA
20502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2051
2052 * alloc.c: Remove build_string.
2053 * lisp.h: Define build_string as static inline. This provides
2054 a better opportunity to optimize away calls to strlen when the
2055 function is called with compile-time constant argument.
2056 * image.c (imagemagick_error): Convert to build_string.
2057 * w32proc.c (sys_spawnve): Likewise.
2058 * xterm.c (x_term_init): Likewise.
2059
cf38a720
PE
20602012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2061
99027bdd
PE
2062 Use sprintf return value instead of invoking strlen on result.
2063 In the old days this wasn't portable, since some sprintf
2064 implementations returned char *. But they died out years ago and
2065 Emacs already assumes sprintf returns int.
2066 Similarly for float_to_string.
2067 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2068 * ccl.c (ccl_driver):
2069 * character.c (string_escape_byte8):
2070 * data.c (Fnumber_to_string):
2071 * doprnt.c (doprnt):
2072 * print.c (print_object):
2073 * xdisp.c (message_dolog):
2074 * xfns.c (syms_of_xfns):
2075 Use sprintf or float_to_string result to avoid need to call strlen.
2076 * data.c (Fnumber_to_string):
2077 Use make_unibyte_string, since the string must be ASCII.
2078 * lisp.h, print.c (float_to_string): Now returns int length.
2079 * term.c (produce_glyphless_glyph):
2080 Use sprintf result rather than recomputing it.
2081
cf38a720
PE
2082 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2083 * Makefile.in (ALL_CFLAGS):
2084 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2085 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2086
3511c784
DA
20872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2088
0a08eb21 2089 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2090 strcasecmp if available.
2091 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2092
fb7da12e
AS
20932012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2094
2095 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2096 Avoid comma operator.
2097 * menu.c (push_submenu_start, push_submenu_end)
2098 (push_left_right_boundary, push_menu_pane): Likewise.
2099 * msdos.c (dos_rawgetc): Likewise.
2100
afa2ffd8
DA
21012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2102
2103 * xfns.c (xic_create_fontsetname): Remove redundant calls
2104 to memset.
2105
b3b4476b
PE
21062012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2107
4495ff38
PE
2108 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2109 sprintf already null-terminates its output.
2110
b3b4476b
PE
2111 * xfns.c (x_window): Remove redundant cast.
2112
b00876c9
DA
21132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2114
2115 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2116 `const char *' to `char *' to avoid compiler warning.
2117
d188e26b
PE
21182012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2119
885d1d74
PE
2120 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2121 instead of truncating it to 63 (admittedly a generous limit).
2122
d188e26b
PE
2123 * process.c: Fix spelling and caps in comments.
2124
e2f560b1
DN
21252012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2126
e86db54b 2127 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2128 * sysdep.c (setpgrp): Remove definition, not used in this file.
2129
7583a3a1
JB
21302012-06-24 Juanma Barranquero <lekktu@gmail.com>
2131
2132 * makefile.w32-in: Update dependencies.
2133
696056c2
EZ
21342012-06-24 Eli Zaretskii <eliz@gnu.org>
2135
2136 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2137 (SYSTIME_H): Add nt/inc/sys/time.h.
2138
2139 * systime.h [WINDOWSNT]: Include sys/time.h.
2140
2141 * s/ms-w32.h (struct timespec): Definition moved from
2142 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2143
845ca893
PE
21442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2147 * buffer.h (buffer_slot_type_mismatch):
2148 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2149 * eval.c (unwind_to_catch):
2150 * image.c (my_png_error, my_error_exit):
2151 * keyboard.c (quit_throw_to_read_char, user_error)
2152 (Fexit_recursive_edit, Fabort_recursive_edit):
2153 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2154 (wrong_type_argument, buffer_overflow, __executable_start)
2155 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2156 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2157 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2158 (fatal):
2159 (child_setup) [!DOS_NT]:
2160 * lread.c (end_of_file_error, invalid_syntax):
2161 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2162 * puresize.h (pure_write_error):
2163 * search.c (matcher_overflow):
2164 * sound.c (sound_perror, alsa_sound_perror):
2165 * sysdep.c, syssignal.h (croak):
2166 * term.c (maybe_fatal, vfatal):
2167 * textprop.c (text_read_only):
2168 * undo.c (user_error):
2169 * unexmacosx.c (unexec_error):
2170 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2171 Use _Noreturn rather than NO_RETURN.
2172 No need for separate decl merely because of _Noreturn.
2173 * sound.c (sound_warning, parse_sound):
2174 Remove unnecessary forward decls.
2175
f1dd8073
PE
21762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2179 * lisp.h (WAIT_READING_MAX): New macro.
2180 * dispnew.c (Fsleep_for, sit_for):
2181 * keyboard.c (kbd_buffer_get_event):
2182 * process.c (Faccept_process_output):
2183 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2184 This improves on the previous patch, which introduced a bug
2185 when time_t is unsigned and as wide as intmax_t.
2186 See <http://bugs.gnu.org/9000#51>.
2187
b82c1755
EZ
21882012-06-23 Eli Zaretskii <eliz@gnu.org>
2189
2190 * dispnew.c (sit_for, Fsleep_for):
2191 * keyboard.c (kbd_buffer_get_event):
2192 * process.c (Faccept_process_output): Avoid compiler warnings when
2193 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2194
ca300656
JB
21952012-06-23 Juanma Barranquero <lekktu@gmail.com>
2196
049ec95b
JB
2197 * makefile.w32-in: Update dependencies.
2198
ca300656
JB
2199 * w32.c (ltime): Add return type and declare static.
2200 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2201
db7b8d06
PE
22022012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2205 Privately reported by Herbert J. Skuhra.
2206 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2207 All uses changed.
2208 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2209 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2210
0bd8297f
EZ
22112012-06-23 Eli Zaretskii <eliz@gnu.org>
2212
96512555
EZ
2213 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2214 last argument of make_unibyte_string.
2215
0bd8297f
EZ
2216 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2217 language ID in the event parameters.
2218
2219 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2220 event.code, not the obscure "character set ID".
2221
63def6b6
CY
22222012-06-23 Chong Yidong <cyd@gnu.org>
2223
2224 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2225
e8a02204
EZ
22262012-06-23 Eli Zaretskii <eliz@gnu.org>
2227
388cdec0
EZ
2228 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2229 * w32.c (fdutimens): New function.
2230
2231 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2232
2233 * s/ms-w32.h (pselect): Redirect to sys_select.
2234
2235 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2236
e8a02204
EZ
2237 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2238 in the logic of incrementing and decrementing the value of
2239 use_relocatable_buffers.
2240
d054f3fb
PE
22412012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2244 Privately reported by Herbert J. Skuhra.
2245 [__FreeBSD__]: Remove "*/" typo after "#include".
2246 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2247 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2248 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2249 Don't assume EMACS_TIME and struct timeval are the same type.
2250
d35af63c
PE
22512012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 Support higher-resolution time stamps (Bug#9000).
2254 The time stamps are only nanosecond-resolution at the C level,
2255 since that's the best that any real-world system supports now.
2256 But they are picosecond-resolution at the Lisp level, as that's
2257 easy, and leaves room for future OS improvements.
2258
2259 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2260 (LIBES): Use it.
2261
2262 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2263 Don't get current time unless it's needed.
2264
2265 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2266 now provides it if it's absent.
2267 (start_atimer): Port to higher-res time stamps.
2268 Check for time stamp overflow. Don't get current time more
2269 often than is needed.
2270
2271 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2272 Include systime.h, not time.h.
2273 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2274
2275 * dired.c: Include stat-time.h.
2276 (Ffile-attributes): File times now have higher resolution.
2277
2278 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2279 (struct image): Timestamp now has higher resolution.
2280
2281 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2282 has at least microseconds now. All uses removed.
2283 (update_frame, update_single_window, update_window, update_frame_1)
2284 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2285
2286 * editfns.c (time_overflow): Now extern.
2287 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2288 (float-time, Fformat_time_string, Fcurrent_time_string)
2289 (Fcurrent_time_zone): Accept and generate higher-resolution
2290 time stamps.
2291 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2292 (decode_time_components, lisp_seconds_argument): New functions.
2293 (make_time): Now static.
2294 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2295 Report an error if the time is invalid, rather than having the caller
2296 do that.
2297
2298 * fileio.c: Include <stat-time.h>
2299 (Fcopy_file): Copy higher-resolution time stamps.
2300 Prefer to set the time stamp via a file descriptor if that works.
2301 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2302 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2303 (Fvisited_file_modtime, Fset_visited_file_modtime):
2304 Support higher-resolution time stamps.
2305
2306 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2307
2308 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2309
2310 * image.c (prepare_image_for_display, clear_image_cache)
2311 (lookup_image): Port to higer-resolution time stamps.
2312
2313 * keyboard.c (start_polling, bind_polling_period):
2314 Check for time stamp overflow.
2315 (read_char, kbd_buffer_get_event, timer_start_idle)
2316 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2317 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2318 Port to higher-resolution time stamps. Do not assume time_t is signed.
2319 (decode_timer): New function. Timers are now vectors of length 9,
2320 not 8, to accommodate the picosecond component.
2321 (timer_check_2): Use it.
2322
2323 * nsterm.m (select_timeout, timeval_subtract): Remove.
2324 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2325 as they're a bit more accurate and handle overflow better.
2326 (ns_select): Change prototype to be compatible with pselect.
2327 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2328 * nsterm.h (ns_select): Adjust prototype.
2329
2330 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2331 us-resolution time stamps.
2332 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2333
2334 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2335
2336 * lisp.h (time_overflow): New decl.
2337 (wait_reading_process_output): First arg is now intmax_t, not int,
2338 to accommodate larger waits.
2339
2340 * process.h (struct Lisp_Process.read_output_delay):
2341 Now counts nanoseconds, not microseconds.
2342 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2343 EMACS_HAS_USECS.
2344 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2345 (wait_reading_process_output):
2346 Port to ns-resolution time stamps.
2347 (Faccept_process_output, wait_reading_process_output):
2348 Check for time stamp overflow. Do not assume time_t is signed.
2349 (select_wrapper): Remove; we now use pselect.
2350 (Fprocess_attributes): Now generates ns-resolution time stamps.
2351
2352 * sysdep.c: Include utimens.h. Don't include utime.h
2353 or worry about struct utimbuf; gnulib does that for us now.
2354 (gettimeofday): Remove; gnulib provides a substitute.
2355 (make_timeval): New function.
2356 (set_file_times): Now sets ns-resolution time stamps.
2357 New arg FD; all uses changed.
2358 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2359 (system_process_attributes):
2360 Now returns ns-resolution time stamp. All uses changed.
2361 Check for time stamp overflow.
2362
2363 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2364 provides a substitute now.
2365
2366 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2367 since it guarantees struct timespec.
2368 (EMACS_TIME): Now struct timespec, so that we can support
2369 ns-resolution time stamps.
2370 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2371 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2372 (EMACS_USECS): Remove.
2373 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2374 so multiply the arg by 1000 before storing it.
2375 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2376 New macros.
2377 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2378 Port to ns-resolution time stamps.
2379 (EMACS_TIME_NEG_P): Remove; replaced by....
2380 (EMACS_TIME_SIGN): New macro.
2381 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2382 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2383 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2384 (make_timeval, make_lisp_time, decode_time_components): New decls.
2385 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2386 that it mishandled time_t overflow. You can't compare by subtracting!
2387 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2388 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2389
2390 * term.c: Include <sys/time.h>.
2391 (timeval_to_Time): New function, for proper overflow wraparound.
2392 (term_mouse_position, term_mouse_click): Use it.
2393
2394 * undo.c (record_first_change): Support higher-resolution time stamps
2395 in the undo buffer.
2396 (Fprimitive_undo): Use them when restoring time stamps.
2397
2398 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2399 (w32_get_internal_run_time):
2400 Port to higher-resolution Emacs time stamps.
2401 (ltime): Now accepts single 64-bit integer, as that's more convenient
2402 for callers.
2403
2404 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2405
2406 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2407 for compatibility with pselect. Support ns-resolution time stamps.
2408
2409 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2410
2411 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2412 Check for time stamp overflow, and support ns-resolution time stamps.
2413
2414 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2415 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2416 (timeval_subtract): Remove; no longer needed.
2417 (XTflash, XTring_bell, x_wait_for_event):
2418 Port to ns-resolution time stamps. Don't assume time_t is signed.
2419
b6a92dfe
CY
24202012-06-22 Chong Yidong <cyd@gnu.org>
2421
2422 * xdisp.c (x_consider_frame_title): Revert last change.
2423
d251c37c
EZ
24242012-06-22 Eli Zaretskii <eliz@gnu.org>
2425
2426 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2427 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2428 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2429 staticidx goes up to 1597 out of 1600 = 0x640.)
2430
f10deafb
PE
24312012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2434 Otherwise, the umask might be mistakenly 0 while handling input signals.
2435
ec6de1e2
SM
24362012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2437
2438 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2439
28be1ada
DA
24402012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2441
2442 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2443 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2444 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2445 access to `contents' member of Lisp_Vector objects with AREF and ASET
2446 where appropriate.
2447
c6bf3022
CY
24482012-06-19 Chong Yidong <cyd@gnu.org>
2449
2450 * frame.c (delete_frame): When selecting a frame on a different
2451 text terminal, do not alter the terminal's top-frame.
2452
2453 * xdisp.c (format_mode_line_unwind_data): Record the target
2454 frame's selected window and its terminal's top-frame.
2455 (unwind_format_mode_line): Restore them.
2456 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2457 Callers changed.
2458 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2459 since tty frames can be explicitly named.
2460 (prepare_menu_bars): Likewise.
2461
2462 * term.c (Ftty_top_frame): New function.
2463
defd4196
PE
24642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 Port byte-code-meter to modern targets.
2467 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2468 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2469 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2470 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2471 (METER_1, METER_2): Simplify.
2472
1053a871
SM
24732012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2474
2475 * data.c (Fdefalias): Return `symbol' (bug#11686).
2476
b7e8d081
MR
24772012-06-18 Martin Rudalics <rudalics@gmx.at>
2478
2479 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2480 gets killed during executing of this function (Bug#11665).
2481 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2482 (Vkill_buffer_query_functions): In doc-string say that functions
2483 run by this hook should not change the current buffer.
2484
7ea2b339
PE
24852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 Fix recently-introduced process.c problems found by static checking.
2488 * process.c (write_queue_push, write_queue_pop, send_process):
2489 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2490 (write_queue_pop): Fix pointer signedness problem.
2491 (send_process): Remove unused local.
2492
96a313a1
CY
24932012-06-17 Chong Yidong <cyd@gnu.org>
2494
2495 * xdisp.c (redisplay_internal): No need to redisplay terminal
2496 frames that are not on top.
2497
20ca2e94
TN
24982012-06-17 Troels Nielsen <bn.troels@gmail.com>
2499
2500 * process.c (make_process): Initialize write_queue.
2501 (write_queue_push, write_queue_pop): New functions.
2502 (send_process): Use them to maintain correct ordering of process
2503 writes (Bug#10815).
2504
9a900ca9
PE
25052012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2506
310fbfa8
PE
2507 * lisp.h (eassert): Assume C89 or later.
2508 This removes the need for CHECK.
2509 (CHECK): Remove. Its comments about always evaluating its
2510 argument were confusing, as 'eassert' typically does not evaluate
2511 its argument.
2512
27bb1ca4
PE
2513 * coding.c (produce_chars): Use ptrdiff_t, not int.
2514
9a900ca9
PE
2515 * xterm.c (x_draw_underwave): Check for integer overflow.
2516 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2517
41b7f8bc 25182012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2519
2520 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2521 referenced (Bug#11583).
2522
9b0e3eba
AA
25232012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2524
2525 Implement wave-style variant of underlining.
2526 * dispextern.h (face_underline_type): New enum.
2527 (face): Add field for underline type.
2528 * nsterm.m (ns_draw_underwave): New function.
2529 (ns_draw_text_decoration): Use it.
2530 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2531 New functions.
2532 (x_draw_glyph_string): Use them.
2533 * xfaces.c (Qline, Qwave): New Lisp objects.
2534 (check_lface_attrs, merge_face_ref)
1053a871
SM
2535 (Finternal_set_lisp_face_attribute, realize_x_face):
2536 Handle wave-style underline face attributes.
9b0e3eba
AA
2537 * xterm.c (x_draw_underwave): New function.
2538 (x_draw_glyph_string): Use it.
2539
0fb52f11
JB
25402012-06-16 Juanma Barranquero <lekktu@gmail.com>
2541
2542 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2543 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2544 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2545 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2546 ($(BLD)/w32select.$(O)): Update dependencies.
2547
e5560ff7
AS
25482012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2549
2550 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2551 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2552 * character.c (_fetch_multibyte_char_p): Remove.
2553 * alloc.c: Include "character.h" before "buffer.h".
2554 * bidi.c: Likewise.
2555 * buffer.c: Likewise.
2556 * bytecode.c: Likewise.
2557 * callint.c: Likewise.
2558 * callproc.c: Likewise.
2559 * casefiddle.c: Likewise.
2560 * casetab.c: Likewise.
2561 * category.c: Likewise.
2562 * cmds.c: Likewise.
2563 * coding.c: Likewise.
2564 * composite.c: Likewise.
2565 * dired.c: Likewise.
2566 * dispnew.c: Likewise.
2567 * doc.c: Likewise.
2568 * dosfns.c: Likewise.
2569 * editfns.c: Likewise.
2570 * emacs.c: Likewise.
2571 * fileio.c: Likewise.
2572 * filelock.c: Likewise.
2573 * font.c: Likewise.
2574 * fontset.c: Likewise.
2575 * fringe.c: Likewise.
2576 * indent.c: Likewise.
2577 * insdel.c: Likewise.
2578 * intervals.c: Likewise.
2579 * keyboard.c: Likewise.
2580 * keymap.c: Likewise.
2581 * lread.c: Likewise.
2582 * macros.c: Likewise.
2583 * marker.c: Likewise.
2584 * minibuf.c: Likewise.
2585 * nsfns.m: Likewise.
2586 * nsmenu.m: Likewise.
2587 * print.c: Likewise.
2588 * process.c: Likewise.
2589 * regex.c: Likewise.
2590 * region-cache.c: Likewise.
2591 * search.c: Likewise.
2592 * syntax.c: Likewise.
2593 * term.c: Likewise.
2594 * textprop.c: Likewise.
2595 * undo.c: Likewise.
2596 * unexsol.c: Likewise.
2597 * w16select.c: Likewise.
2598 * w32fns.c: Likewise.
2599 * w32menu.c: Likewise.
2600 * window.c: Likewise.
2601 * xdisp.c: Likewise.
2602 * xfns.c: Likewise.
2603 * xmenu.c: Likewise.
2604 * xml.c: Likewise.
2605 * xselect.c: Likewise.
2606
2f07e6af
EZ
26072012-06-16 Eli Zaretskii <eliz@gnu.org>
2608
1053a871
SM
2609 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2610 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2611 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2612 row.
2613 (handle_face_prop): Use chunk-relative overlay string index when
2614 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2615 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2616 the rightmost. (Bug#11720)
2f07e6af 2617
29b83cec
AS
26182012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2619
2620 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2621 (CATEGORY_MEMBER): Enforce 1/0 value.
2622 * category.c (_temp_category_set): Remove.
2623
4c5501e9
EZ
26242012-06-16 Eli Zaretskii <eliz@gnu.org>
2625
2626 * window.c (Fdelete_other_windows_internal)
2627 (Fdelete_window_internal): Don't access frame's mouse highlight
2628 info of the initial frame. (Bug#11677)
2629
2b570124
PE
26302012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2631
e93864f9
PE
2632 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2633 Assume USE_2_TAGS_FOR_INTS.
2634 (xreload): Adjust $tagmask width to match recent lisp.h change.
2635
2b570124
PE
2636 Simplify lisp.h in minor ways that should not affect code.
2637 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2638 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2639 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2640 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2641 (INTTYPEBITS): New macro, for clarity.
2642 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2643 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2644 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2645 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2646 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2647
81755f69
JB
26482012-06-13 Juanma Barranquero <lekktu@gmail.com>
2649
2650 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2651
16192a57
GM
26522012-06-13 Glenn Morris <rgm@gnu.org>
2653
2654 * s/bsd-common.h (BSD4_3):
2655 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2656
646b5f55
AS
26572012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2658
2659 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2660 instead of union.
2661 (XLI, XIL): Define.
1053a871
SM
2662 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2663 Use them.
2664 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2665 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2666 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2667 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2668 * frame.c (delete_frame): Remove outdated comment.
2669 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2670 USE_LISP_UNION_TYPE.
2671 (Fw32_unregister_hot_key): Likewise.
2672 (Fw32_toggle_lock_key): Likewise.
2673 * w32menu.c (add_menu_item): Likewise.
2674 (w32_menu_display_help): Use XIL instead of checking
2675 USE_LISP_UNION_TYPE.
2676 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2677 (init_heap): Likewise.
2678 * w32term.c (w32_read_socket): Update comment.
2679
1d3823c9
GM
26802012-06-13 Glenn Morris <rgm@gnu.org>
2681
c62ff706
GM
2682 * s/usg5-4-common.h, src/s/unixware.h:
2683 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2684
1d3823c9
GM
2685 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2686
bfe3e0a2
PE
26872012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2690 * alloc.c (make_number) [!defined make_number]:
2691 Remove, as lisp.h always defines this now.
2692 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2693 (roundup_size): Verify that it is a power of 2.
2694 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2695 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2696 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2697 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2698 USE_LSB_TAG now is always defined to be either 0 or 1.
2699 All uses changed.
2700 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2701 code works fine either way, and efficiency is not a concern here,
2702 as the union type is for debugging, not for production.
2703 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2704 Use an inline function on all platforms when using the union type,
2705 since this is simpler and 'static inline' can be used portably
2706 within Emacs now.
2707 (LISP_INITIALLY_ZERO): New macro.
2708 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2709 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2710
45fa9c0f
GM
27112012-06-12 Glenn Morris <rgm@gnu.org>
2712
b4492cba
GM
2713 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2714
2715 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2716
45fa9c0f
GM
2717 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2718 Move BROKEN_SIGIO to configure.
2719
2720 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2721 Move NO_TERMIO to configure.
2722
0e25d334
CY
27232012-06-12 Chong Yidong <cyd@gnu.org>
2724
2725 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2726 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2727 MagickExportImagePixels is undefined.
2728
43682bb6
PE
27292012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * image.c (imagemagick_load_image): Remove unused label.
2732
a9be7d2b
GM
27332012-06-11 Glenn Morris <rgm@gnu.org>
2734
2735 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2736 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2737 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2738 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2739
3017f87f
SM
27402012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2741
2742 * alloc.c (make_byte_code): New function.
2743 (Fmake_byte_code): Use it. Don't purify here.
2744 * lread.c (read1): Use it as well to avoid extra allocation.
2745
1b9b4cf4
CY
27462012-06-11 Chong Yidong <cyd@gnu.org>
2747
2748 * image.c (imagemagick_load_image): Implement transparency.
2749
95988fcf
AS
27502012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2751
2752 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2753 account for preceding backslashes. (Bug#11663)
2754
cd4eb164
CY
27552012-06-09 Chong Yidong <cyd@gnu.org>
2756
2757 * term.c: Support italics in capable terminals (Bug#9652).
2758 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2759 (turn_on_face): Output using TS_enter_italic_mode if available.
2760 Don't handle unused blinking and alt-charset cases.
2761 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2762 and tty_alt_charset_p cases.
2763 (tty_capable_p, init_tty): Support italics.
2764
2765 * termchar.h (struct tty_display_info): Add field for italics.
2766 Remove unused blink field.
2767
2768 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2769 Handle slant.
2770
2771 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2772 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2773 tty_alt_charset_p. Add tty_italic_p.
2774
ff88beb8
MA
27752012-06-09 Michael Albinus <michael.albinus@gmx.de>
2776
2777 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2778 dbus_type_is_basic if available.
2779 (xd_extract_signed, xd_extract_unsigned): Rename from
2780 extract_signed and extract_unsigned, respectively. Adapt callers.
2781
44286096
CY
27822012-06-09 Chong Yidong <cyd@gnu.org>
2783
1682701f
CY
2784 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2785
44286096
CY
2786 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2787 case (Bug#9752).
2788
d86feb17
PE
27892012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * xdisp.c (vmessage): Treat frame message as multibyte.
2792 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2793 would generate the diagnostic "Making \302\247 buffer-local while
2794 let-bound!".
2795
d5c20fe8
EZ
27962012-06-08 Eli Zaretskii <eliz@gnu.org>
2797
2798 * dispnew.c (showing_window_margins_p): Undo last change, which
2799 was done due to an inadvertent commit.
2800 (adjust_frame_glyphs_for_frame_redisplay): Do call
2801 showing_window_margins_p.
2802
513749ee
SM
28032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2804
2805 * eval.c (Fmake_var_non_special): New primitive.
2806 (syms_of_eval): Defsubr it.
2807 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2808
d4a8f5c1
JB
28092012-06-08 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2812 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2813
8bbbc977
EZ
28142012-06-08 Eli Zaretskii <eliz@gnu.org>
2815
2816 * alloc.c (allocate_vectorlike): Fix last change.
2817
f3372c87
DA
28182012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2819
2820 Block-based vector allocation of small vectors.
2821 * lisp.h (struct vectorlike_header): New field `nbytes',
2822 adjust comment accordingly.
2823 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2824 to denote vector blocks. Adjust users (live_vector_p,
2825 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2826 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2827 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2828 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2829 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2830 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2831 (roundup_size): New constant.
2832 (struct vector_block): New data type.
2833 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2834 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2835 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2836 (sweep_vectors): New functions.
2837 (allocate_vectorlike): Return `zero_vector' as the only vector of
2838 0 items. Allocate new vector from block if vector size is less than
2839 or equal to VBLOCK_BYTES_MAX.
2840 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2841 (init_alloc_once): Add call to init_vectors.
2842
4f18a4ed
SM
28432012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2846
86f158bc
PE
28472012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * doprnt.c (doprnt): Truncate multibyte char correctly.
2850 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2851 would mishandle a string argument "Xc" if X was a multibyte
2852 character of length 2: it would truncate after X's first byte
2853 rather than including all of X.
2854
c5cfcbe0
CY
28552012-06-06 Chong Yidong <cyd@gnu.org>
2856
2857 * buffer.c (word_wrap): Doc fix.
2858
c05cf390
PE
28592012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2862
0c3461de
GM
28632012-06-03 Glenn Morris <rgm@gnu.org>
2864
2865 * xdisp.c (tool-bar-style): Doc fix.
2866
c71232db
UM
28672012-06-03 Ulrich Müller <ulm@gentoo.org>
2868
2869 * Makefile.in (PAXCTL): Define.
2870 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2871 binary via PaX flags if the paxctl utility is available.
2872 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2873 Restore PaX flags to their default. (Bug#11398)
2874
383f7350
CY
28752012-06-03 Chong Yidong <cyd@gnu.org>
2876
2877 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2878 buffer (Bug#11226).
2879
5f2c76c6
CY
28802012-06-03 Chong Yidong <cyd@gnu.org>
2881
2882 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2883 (note_mode_line_or_margin_highlight): If there is no help echo,
2884 use mode-line-default-help-echo. Handle the case where the mouse
2885 position is past the end of the mode line string.
2886
2887 * buffer.c (buffer_local_value_1): New function, split from
2888 Fbuffer_local_value; can return Qunbound.
2889 (Fbuffer_local_value): Use it.
2890 (Vmode_line_format): Docstring tweaks.
2891
773d47f6
PE
28922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * sysdep.c (system_process_attributes): Improve comment.
2895
f2d6a3df
SM
28962012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 * keyboard.c: Export real-this-command to Elisp.
2899 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2900 and DEFVAR it. Update all users.
2901
63810350
PE
29022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2903
7bd5c1f4
PE
2904 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2905
63810350
PE
2906 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2907 Convert pctcpu and pctmem to Lisp float properly.
2908 Let the compiler fold better, as 100.0/0x8000 is exact.
2909
a2821611
AS
29102012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2911
2912 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2913 cons_block.
2914
5fceba1d
PE
29152012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2918
c98ff5dd
DA
29192012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2920
2921 For a 'struct window', replace some Lisp_Object fields to
2922 bitfields where appropriate, remove unused fields.
2923 * window.h (struct window): Remove unused 'last_mark_x' and
2924 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2925 change it's type from Lisp_Object to bitfield.
2926 Change type of 'force_start', 'optional_new_start',
2927 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2928 fields from Lisp_Object to bitfield. Adjust users accordingly.
2929
ca34e0be
PE
29302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2931
2932 Pacify gcc -Wdouble-precision when using Xaw.
2933 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2934 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2935 Use 'float' consistently, rather than 'float' in most places
2936 and 'double' in a couple of places.
2937
efc00ab1 29382012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2939
2940 * xdisp.c (handle_stop): Detect whether we have overlay strings
2941 loaded by testing it->current.overlay_string_index to be
2942 non-negative, instead of checking whether n_overlay_strings is
2943 positive. (Bug#11587)
2944
efc00ab1 29452012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2946
2947 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2948
2949 * doc.c (Fsubstitute_command_keys): Doc fix.
2950
efc00ab1 29512012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2952
2953 * search.c (search_buffer): Remove calls to
2954 r_alloc_inhibit_buffer_relocation, as it is now called by
2955 maybe_unify_char, which was the cause of relocation of buffer text
2956 in bug#11519.
2957
efc00ab1 29582012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2959
2960 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2961 for the duration of call to load_charset, to avoid problems with
2962 callers of maybe_unify_char that access buffer text through C
2963 pointers.
2964
2965 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2966 decrement the inhibition flag, instead of just setting or
2967 resetting it.
2968
ba93a187
PE
29692012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 Remove obsolete '#define static' cruft.
2972 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2973 This #undef was "temporary" in 2000; it is no longer needed
2974 now that '#define static' has gone away.
2975 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2976 (gray_bitmap_bits): Remove; no longer needed.
2977 All uses replaced with definiens.
2978 * xterm.c: Include "bitmaps/gray.xbm".
2979
9e4bf381
PE
29802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 Clean up __executable_start, monstartup when --enable-profiling.
2983 The following changes affect the code only when profiling.
2984 * dispnew.c (__executable_start): Rename from safe_bcopy.
2985 Define only on platforms that need it.
2986 * emacs.c: Include <sys/gmon.h> when profiling.
2987 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2988 (__executable_start): Remove decl, since lisp.h does it now.
2989 (safe_bcopy): Remove decl; no longer has that name.
2990 (main): Coalesce #if into single bit of code, for simplicity.
2991 Cast pointers to uintptr_t, since standard libraries want integers
2992 and not pointers.
2993 * lisp.h (__executable_start): New decl.
2994
32d72c2f
GM
29952012-05-31 Glenn Morris <rgm@gnu.org>
2996
2997 * image.c (Fimagemagick_types): Doc fix.
2998
baac5bc7
JM
29992012-05-30 Jim Meyering <meyering@redhat.com>
3000
3001 * callproc.c (Fcall_process_region): Include directory component
3002 in mkstemp error message (Bug#11586).
3003
72cb32cf
PE
30042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3005
3006 * alloc.c, lisp.h (make_pure_vector): Now static.
3007
61b108cc
SM
30082012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3009
3010 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3011 Move to byte-run.el.
3012 (Fautoload): Do the hash-doc more carefully.
3013 * data.c (Fdefalias): Purify definition, except for keymaps.
3014 (Qdefun): Move from eval.c.
3015 * lisp.h (Qdefun): Remove.
3016 * lread.c (read1): Tiny simplification.
3017
471fe23d
TN
30182012-05-29 Troels Nielsen <bn.troels@gmail.com>
3019
934f3f58 3020 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3021 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3022 Bug#9642, but explicitly check that the buffer the overlay would
3023 be moved to is live and rearrange lines to make sure that errors
3024 will not put the overlay in an inconsistent state.
3025 (Fdelete_overlay): Cosmetics.
3026
85d0efd1
EZ
30272012-05-28 Eli Zaretskii <eliz@gnu.org>
3028
3029 * w32term.c (my_bring_window_to_top): New function.
3030 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3031 could be different from the original one.
3032 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3033 (Bug#11513)
3034
3035 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3036 by calling BringWindowToTop.
3037
3038 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3039 (WM_EMACS_END): Increase by one.
3040
da92a98c
PE
30412012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3044 This avoids undefined behavior that might cause the eassert
3045 to not catch an out-of-range value.
3046
74d1f848
JB
30472012-05-28 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3050 Update dependencies.
3051
9e1a06fc
EZ
30522012-05-27 Eli Zaretskii <eliz@gnu.org>
3053
3054 * bidi.c (bidi_mirror_char): Fix last change.
3055
f3dd7312
AS
30562012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3057
3058 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3059 when referring to sectname field in printf format.
3060
81899c91
PE
30612012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3062
57b81a9f
PE
3063 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3064 Only r_alloc_inhibit_buffer_relocation needed to be added;
3065 the others were already declared.
3066
81899c91
PE
3067 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3068 before checking whether it's out of range. Put the check inside
3069 eassert. See
3070 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3071
33017faf 30722012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3073
3074 * callproc.c (Fcall_process): Restore a line that was accidentally
3075 commented out in the 2011-02-13 change (bug#11547).
3076
33017faf 30772012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3078
3079 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3080 defined on ralloc.c.
3081
3082 * buffer.c [REL_ALLOC]: Remove prototypes of
3083 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3084 they are now on lisp.h.
3085
3086 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3087
3088 * search.c (search_buffer): Use it to inhibit relocation of buffer
3089 text while re_search_2 is doing its job, because re_search_2 is
3090 passed C pointers to buffer text. (Bug#11519)
3091
23415acf
EZ
3092 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3093 Update value to 24.
3094
44e27368
EZ
3095 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3096 state after an additional call to move_it_in_display_line_to, keep
3097 the values of it->max_ascent and it->max_descent found for the
3098 entire line.
3099 (pos_visible_p): Revert the comparison against bottom_y to what it
3100 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3101 (Bug#11464)
3102
c1892f11
PE
31032012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Fix coding-related core dumps with gcc -ftrapv.
3106 The code was computing A - B, where A and B are pointers, and B is
3107 random garbage. This can lead to core dumps on platforms that
3108 have special pointer registers, and it also leads to core dumps on
3109 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3110 A - B only when B is initialized properly.
3111 * coding.c (coding_set_source, coding_set_destination): Return void.
3112 (coding_change_source, coding_change_destinations): New functions,
3113 with the old behaviors of coding_set_source and coding_set_destination.
3114 All callers that need an offset changed to use these new functions.
3115
eb7afdad
GM
31162012-05-26 Glenn Morris <rgm@gnu.org>
3117
3118 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3119
f12fdf02
EZ
31202012-05-26 Eli Zaretskii <eliz@gnu.org>
3121
53a63be6 3122 Extend mouse support on W32 text-mode console.
61b108cc
SM
3123 * xdisp.c (draw_row_with_mouse_face):
3124 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3125
eb3f6f01 3126 * w32console.c: Include window.h.
61b108cc
SM
3127 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3128 New functions.
eb3f6f01
EZ
3129 (initialize_w32_display): Initialize mouse-highlight data.
3130
53a63be6
EZ
3131 * w32inevt.c: Include termchar.h and window.h.
3132 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3133 moves, call note_mouse_highlight. If help_echo changed, call
3134 gen_help_event to produce help-echo message in the echo area.
3135 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3136 highlight info.
3137
4cfd81f6
PE
31382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 * lread.c (read1): Simplify slightly to avoid an overflow warning
3141 with GCC 4.7.0 on x86-64.
3142
4446092a
EZ
31432012-05-26 Eli Zaretskii <eliz@gnu.org>
3144
3145 * bidi.c (bidi_mirror_char): Revert last change: an int is
3146 definitely wide enough here.
3147
42b2a986 31482012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3149
42b2a986 3150 Fix integer width and related bugs (Bug#9874).
eb106a49 3151 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3152 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3153 (string_bytes, check_sblock, allocate_string_data):
3154 (compact_small_strings, Fmake_bool_vector, make_string)
3155 (make_unibyte_string, make_multibyte_string)
3156 (make_string_from_bytes, make_specified_string)
3157 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3158 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3159 (mark_vectorlike):
3160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3161 (allocate_pseudovector):
3162 Use int, not EMACS_INT, where int is wide enough.
3163 (inhibit_garbage_collection, Fgarbage_collect):
3164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3165 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3166 int might not be wide enough.
3167 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3168 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3169 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3170 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3171 (bidi_level_of_next_char, bidi_move_to_visually_next):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3173 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3174 (Fkill_buffer, Fset_buffer_major_mode)
3175 (advance_to_char_boundary, Fbuffer_swap_text)
3176 (Fset_buffer_multibyte, overlays_at, overlays_in)
3177 (overlay_touches_p, struct sortvec, record_overlay_string)
3178 (overlay_strings, recenter_overlay_lists)
3179 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3180 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3181 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3182 (Foverlay_recenter, last_overlay_modification_hooks_used)
3183 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3185 (validate_region): Omit unnecessary test for b <= e,
3186 since that's guaranteed by the previous test.
d311d28c
PE
3187 (adjust_overlays_for_delete): Avoid pos + length overflow.
3188 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3189 (report_overlay_modification):
3190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3191 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3192 Omit pointer cast, which isn't needed anyway, and doesn't work
3193 after the EMACS_INT -> ptrdiff_t change.
02481186 3194 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3195 * buffer.h: Adjust decls to match defn changes elsewhere.
3196 (struct buffer_text, struct buffer):
3197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3198 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3199 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3200 not int, to avoid needless 32-bit limit on 64-bit hosts.
3201 (exec_byte_code): Use tighter memory-full test, one that checks
3202 for alloca overflow. Don't compute the address of the object just
3203 before an array, as that's not portable. Use EMACS_INT, not
3204 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3205 * callint.c (Fcall_interactively):
3206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3207 * callproc.c (call_process_kill, Fcall_process):
3208 Don't assume pid_t fits into an Emacs fixnum.
3209 (call_process_cleanup, Fcall_process, child_setup):
3210 Don't assume pid_t fits into int.
3211 (call_process_cleanup, Fcall_process, delete_temp_file)
3212 (Fcall_process_region):
3213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3214 (Fcall_process): Simplify handling of volatile integers.
3215 Use int, not EMACS_INT, where int will do.
3216 * casefiddle.c (casify_object, casify_region, operate_on_word)
3217 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3219 (casify_object): Avoid integer overflow when overallocating buffer.
3220 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3221 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3222 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3223 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3224 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3225 integers are now checked earlier. All uses replaced with XINT.
3226 (ccl_driver):
3227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3228 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3229 (ccl_driver, Fregister_code_conversion_map):
3230 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3231 (resolve_symbol_ccl_program): Check that vector header is in range.
3232 Always copy the vector, so that we can check its contents reliably
3233 now rather than having to recheck each instruction as it's being
3234 executed. Check that vector words fit in 'int'.
3235 (ccl_get_compiled_code, Fregister_ccl_program)
3236 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3237 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3238 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3239 contents are in range.
3240 (Fccl_execute_on_string): Check that status is in range.
3241 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3242 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3243 Accept and return EMACS_INT, not int, because callers can pass values
3244 out of 'int' range.
3245 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3246 (multibyte_chars_in_text, parse_str_as_multibyte)
3247 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3248 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3249 (string_escape_byte8, Fget_byte):
3250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3251 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3252 avoid mishandling large integers.
3253 * character.h: Adjust decls to match defn changes elsewhere.
3254 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3255 (Ffind_charset_region):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3258 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3259 Don't assume fixnum fits in int.
d311d28c
PE
3260 (load_charset_map_from_vector, Fmap_charset_chars):
3261 Remove now-unnecessary CHECK_NATNUMs.
3262 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3263 Don't rely on undefined behavior with signed left shift overflow.
3264 Don't assume unsigned int fits into fixnum, or that fixnum fits
3265 into unsigned int. Don't require max_code to be a valid fixnum;
3266 that's not true for gb10830 4-byte on a 32-bit host. Allow
3267 invalid_code to be a cons, for the same reason. Require code_offset
3268 to be a character. Avoid int overflow if max_char is close
3269 to INT_MAX.
3270 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3271 this is intended anyway and avoids some undefined behavior.
3272 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3273 INDEX_TO_CODE_POINT, as that's what it expects.
3274 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3275 * charset.h (DECODE_CHAR): Return int, not unsigned;
3276 this is what was intended anyway, and it avoids undefined behavior.
3277 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3278 integer-overflow issues.
3279 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3280 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3281 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3282 * chartab.c (Fmake_char_table, Fset_char_table_range)
3283 (uniprop_get_decoder, uniprop_get_encoder):
3284 Don't assume fixnum fits in int.
3285 * cmds.c (move_point): New function, that does the gist of
3286 Fforward_char and Fbackward_char, but does so while checking
3287 for integer overflow more accurately.
c96e5d6a 3288 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3289 (Fforward_line, Fend_of_line, internal_self_insert)
3290 (internal_self_insert):
3291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3292 Fix a FIXME, by checking for integer overflow when calculating
3293 target_clm and actual_clm.
3294 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3295 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3296 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3297 (coding_alloc_by_making_gap, alloc_destination)
3298 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3299 (encode_coding_utf_16, detect_coding_emacs_mule)
3300 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3301 (detect_coding_iso_2022, decode_coding_iso_2022)
3302 (encode_invocation_designation, encode_designation_at_bol)
3303 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3304 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3305 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3306 (encode_coding_ccl, encode_coding_raw_text)
3307 (detect_coding_charset, decode_coding_charset)
3308 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3309 (produce_composition, produce_charset, produce_annotation)
3310 (decode_coding, handle_composition_annotation)
3311 (handle_charset_annotation, consume_chars, decode_coding_gap)
3312 (decode_coding_object, encode_coding_object, detect_coding_system)
3313 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3314 (code_convert_region, code_convert_string)
8f50130c
PE
3315 (Fdefine_coding_system_internal)
3316 (coding_set_source, coding_set_destination):
d311d28c
PE
3317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3318 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3319 (Fdefine_coding_system_internal):
3320 Don't assume fixnums fit in int.
3321 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3322 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3323 (Funencodable_char_position, Fcheck_coding_systems_region)
3324 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3326 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3327 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3328 Don't access memory outside of the args array.
d311d28c 3329 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3330 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3331 result of ENCODE_CHAR.
d311d28c
PE
3332 * coding.h: Adjust decls to match defn changes elsewhere.
3333 (struct coding_system):
3334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3335 * composite.c (get_composition_id, find_composition)
3336 (run_composition_function, update_compositions)
3337 (compose_text, composition_gstring_put_cache)
3338 (composition_gstring_p, composition_gstring_width)
3339 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3340 (composition_compute_stop_pos, composition_reseat_it)
3341 (composition_update_it, struct position_record)
3342 (find_automatic_composition, composition_adjust_point)
3343 (Fcomposition_get_gstring, Ffind_composition_internal):
3344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3345 (update_compositions):
3346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3347 * composite.h: Adjust decls to match defn changes elsewhere.
3348 (struct composition):
3349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3350 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3351 Do not attempt to compute the address of the object just before a
3352 buffer; this is not portable.
3353 (Faref, Faset):
3354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3355 (Faset): Use int, not EMACS_INT, where int is wide enough.
3356 (Fstring_to_number): Don't assume fixnums fit in int.
3357 (Frem): Don't assume arg is nonnegative.
3358 * dbusbind.c (xd_append_arg): Check for integers out of range.
3359 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3360 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3361 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3362 (xd_get_connection_references): Return ptrdiff_t, not int.
3363 All uses changed.
3364 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3365 (xd_read_message_1):
3366 Use int, not unsigned, where the dbus API uses int.
3367 (Fdbus_message_internal): Don't overflow mtype.
3368 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3369 * dired.c (directory_files_internal, file_name_completion, scmp)
3370 (file_name_completion_stat):
3371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3372 (file_name_completion): Don't overflow matchcount.
3373 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3374 * dispextern.h: Adjust decls to match defn changes elsewhere.
3375 (struct text_pos, struct glyph, struct bidi_saved_info)
3376 (struct bidi_string_data, struct bidi_it, struct composition_it)
3377 (struct it):
3378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3379 (struct display_pos, struct composition_it, struct it):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 * dispnew.c (increment_matrix_positions)
3382 (increment_row_positions, mode_line_string)
3383 (marginal_area_string):
3384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3385 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3387 (duration_to_sec_usec): New function, to check for overflow better.
3388 (Fsleep_for, sit_for): Use it.
3389 * doc.c (get_doc_string, store_function_docstring):
3390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3391 (get_doc_string, Fsnarf_documentation):
3392 Use int, not EMACS_INT, where int is wide enough.
3393 (get_doc_string):
3394 Use SAFE_ALLOCA, not alloca.
3395 Check for overflow when converting EMACS_INT to off_t.
3396 * doprnt.c (doprnt):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3399 Don't assume uid_t fits into fixnum.
3400 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3401 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3402 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3403 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3404 (general_insert_function)
3405 (Finsert_char, make_buffer_string, make_buffer_string_both)
3406 (update_buffer_properties, Fbuffer_substring)
3407 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3408 (Fsubst_char_in_region, check_translation)
3409 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3410 (transpose_markers, Ftranspose_regions):
3411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3412 (clip_to_bounds): Move to lisp.h as an inline function).
3413 (Fconstrain_to_field): Don't assume integers are nonnegative.
3414 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3415 (Fsubst_char_in_region, Fsave_restriction):
3416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3417 (Femacs_pid): Don't assume pid_t fits into fixnum.
3418 (lo_time): Use int, not EMACS_INT, when int suffices.
3419 (lisp_time_argument): Check for usec out of range.
3420 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3421 (Fuser_login_name, Fuser_full_name): Signal an error
3422 if a uid argument is out of range, rather than relying on
3423 undefined behavior.
c8d5c857
PE
3424 (Fformat_time_string): Remove now-unnecessary check.
3425 lisp_time_argument checks for out-of-range usec now.
243e0530 3426 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3427 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3428 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3429 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3430 (init_cmdargs, Fdump_emacs):
3431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3432 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3433 the bottom (typically) 32 bits of the fixnum.
3434 * eval.c (specpdl_size, call_debugger):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 (when_entered_debugger, Fbacktrace_debug):
3437 Don't assume fixnum can fit in int.
3438 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3439 the object just before a buffer; this is not portable.
3440 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3441 (grow_specpdl, unbind_to):
3442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3443 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3444 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3445 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3446 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3447 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3449 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3450 (a_write, e_write):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (Fcopy_file, non_regular_nbytes, read_non_regular)
3453 (Finsert_file_contents):
3454 Use int, not EMACS_INT, where int is wide enough.
3455 (READ_BUF_SIZE): Verify that it fits in int.
3456 (Finsert_file_contents): Check that counts are in proper range,
3457 rather than assuming fixnums fit into ptrdiff_t etc.
3458 Don't assume fixnums fit into int.
125b3835 3459 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3460 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3461 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3462 (string_char_to_byte, string_byte_to_char)
3463 (string_make_multibyte, string_to_multibyte)
3464 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3465 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3466 (substring_both, Fdelete, internal_equal, Ffillarray)
3467 (Fclear_string, mapcar1)
3468 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3469 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3470 (larger_vector, make_hash_table, maybe_resize_hash_table)
3471 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3472 (Fmaphash, secure_hash):
3473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3474 (concat): Check for string index and length overflow.
3475 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3476 (Frequire):
3477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3478 (larger_vector): New API (vec, incr_min, size_max) replaces old
3479 one (vec, new_size, init). This catches size overflow.
3480 INIT was removed because it was always Qnil.
3481 All callers changed.
3482 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3483 the upper bound on a hash table index size.
3484 (make_hash_table, maybe_resize_hash_table): Use it.
3485 (secure_hash): Computer start_byte and end_byte only after
3486 they're known to be in ptrdiff_t range.
3487 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3488 (Ffont_get_glyphs, Ffont_at):
3489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3490 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3491 (Flist_fonts, Fopen_font):
3492 Don't assume fixnum can fit in int.
3493 (check_gstring): Don't assume index can fit in int.
3494 (font_match_p): Check that fixnum is a character, not a nonnegative
3495 fixnum, since the later code needs to stuff it into an int.
3496 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3497 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3498 conversion overflow issues.
3499 (Fopen_font): Check for integer out of range.
3500 (Ffont_get_glyphs): Don't assume index can fit in int.
3501 * font.h: Adjust decls to match defn changes elsewhere.
3502 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3503 integer overflow.
3504 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3505 printmax_t, where ptrdiff_t is wide enough.
3506 (Finternal_char_font):
3507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3508 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3509 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3510 (Fset_frame_position, x_set_frame_parameters)
3511 (x_set_line_spacing, x_set_border_width)
3512 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3513 Check that fixnums are in proper range for system types.
3514 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3517 Use SAFE_ALLOCA_LISP, not alloca.
3518 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3519 intptr_t is wide enough.
3520 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3521 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3522 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3523 Check for fixnum out of range.
3524 * ftfont.c (ftfont_list): Don't assume index fits in int.
3525 Check that fixnums are in proper range for system types.
3526 (ftfont_shape_by_flt):
3527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3528 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3530 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3531 Check that fixnums are in proper range for system types.
3532 * gnutls.h: Adjust decls to match defn changes elsewhere.
3533 * gtkutil.c (xg_dialog_run):
3534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3535 (update_frame_tool_bar):
3536 Check that fixnums are in proper range for system types.
3537 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3538 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3539 * indent.c (last_known_column, last_known_column_point):
3540 (current_column_bol_cache):
3541 (skip_invisible, current_column, check_display_width):
3542 (check_display_width, scan_for_column, current_column_1)
3543 (Findent_to, Fcurrent_indentation, position_indentation)
3544 (indented_beyond_p, Fmove_to_column, compute_motion):
3545 (Fcompute_motion, Fvertical_motion):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 (last_known_column_modified): Use EMACS_INT, not int.
3548 (check_display_width):
3549 (Fcompute_motion):
3550 Check that fixnums and floats are in proper range for system types.
3551 (compute_motion): Don't assume index or fixnum fits in int.
3552 (compute_motion, Fcompute_motion):
3553 Use int, not EMACS_INT, when it is wide enough.
3554 (vmotion): Omit local var start_hpos that is always 0; that way
3555 we don't need to worry about overflow in expressions involving it.
3556 * indent.h: Adjust decls to match defn changes elsewhere.
3557 (struct position):
3558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3559 Use int, not EMACS_INT, where int is wide enough.
3560 Remove unused members ovstring_chars_done and tab_offset;
3561 all uses removed.
3562 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3563 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3564 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3565 (make_gap, copy_text, insert, insert_and_inherit)
3566 (insert_before_markers, insert_before_markers_and_inherit)
3567 (insert_1, count_combining_before, count_combining_after)
3568 (insert_1_both, insert_from_string)
3569 (insert_from_string_before_markers, insert_from_string_1)
3570 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3571 (adjust_after_replace, adjust_after_insert, replace_range)
3572 (replace_range_2, del_range, del_range_1, del_range_byte)
3573 (del_range_both, del_range_2, modify_region)
3574 (prepare_to_modify_buffer, signal_before_change)
3575 (signal_after_change, Fcombine_after_change_execute):
3576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3577 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3578 (balance_an_interval, split_interval_right, split_interval_left)
3579 (find_interval, next_interval, update_interval)
3580 (adjust_intervals_for_insertion, delete_node, delete_interval)
3581 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3582 (static_offset_intervals, offset_intervals)
3583 (merge_interval_right, merge_interval_left, make_new_interval)
3584 (graft_intervals_into_buffer, temp_set_point_both)
3585 (temp_set_point, set_point, adjust_for_invis_intang)
3586 (set_point_both, move_if_not_intangible, get_property_and_range)
3587 (get_local_map, copy_intervals, copy_intervals_to_string)
3588 (compare_string_intervals, set_intervals_multibyte_1):
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 * intervals.h: Adjust decls to match defn changes elsewhere.
3591 (struct interval):
3592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3593 * keyboard.c (this_command_key_count, this_single_command_key_start)
3594 (before_command_key_count, before_command_echo_length, echo_now)
3595 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3596 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3597 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3598 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3600 (last_non_minibuf_size, last_point_position, echo_truncate)
3601 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3602 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3603 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3604 (stuff_buffered_input):
3605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3606 (last_auto_save, command_loop_1, read_char):
3607 Use EMACS_INT, not int, to avoid integer overflow.
3608 (record_char): Avoid overflow in total_keys computation.
3609 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3610 * keyboard.h: Adjust decls to match defn changes elsewhere.
3611 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3612 (Fkey_description, Fdescribe_vector, Flookup_key):
3613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3614 (click_position): New function, to check that positions are in range.
3615 (Fcurrent_active_maps):
3616 (describe_command):
3617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3618 (Faccessible_keymaps, Fkey_description):
3619 (preferred_sequence_p):
3620 Don't assume fixnum can fit into int.
3621 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3622 Check for integer overflow in size calculations.
3623 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3624 avoid mishandling large integers.
3625 * lisp.h: Adjust decls to match defn changes elsewhere.
3626 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3627 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3628 (struct Lisp_Marker):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3631 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3632 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3633 All callers changed.
3634 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3635 Assume the arg has valid form, since it always does.
3636 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3637 unsigned integer system type.
3638 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3639 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3641 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3642 (duration_to_sec_usec): New decl.
3643 * lread.c (read_from_string_index, read_from_string_index_byte)
3644 (read_from_string_limit, readchar, unreadchar, openp)
3645 (read_internal_start, read1, oblookup):
3646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3647 (Fload, readevalloop, Feval_buffer, Feval_region):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 (openp): Check for out-of-range argument to 'access'.
3650 (read1): Use int, not EMACS_INT, where int is wide enough.
3651 Don't assume fixnum fits into int.
6efdadfd 3652 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3653 (read_filtered_event): Use duration_to_sec_usec
3654 to do proper overflow checking on durations.
d311d28c
PE
3655 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3656 in size calculation.
3657 (Fexecute_kbd_macro):
3658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3659 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3660 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3661 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3662 (set_marker_both, set_marker_restricted_both, marker_position)
3663 (marker_byte_position, Fbuffer_has_markers_at):
3664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3665 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3666 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3667 It now merely ensures that the menu is large enough, without
3668 necessarily growing it, as this avoids some integer overflow issues.
3669 All callers changed.
3670 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3672 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3673 Use SAFE_ALLOCA_LISP, not alloca.
3674 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3675 to EMACS_INT. Check that fixnums are in proper range for system types.
3676 * minibuf.c (minibuf_prompt_width, string_to_object)
3677 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3678 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3680 (get_minibuffer, read_minibuf_unwind):
3681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3682 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3683 this simplifies overflow checking. All callers changed.
3684 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3685 (Ftest_completion):
3686 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3687 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3688 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3689 Check that fixnums are in proper range for system types.
3690 (Fx_create_frame, Fx_show_tip):
3691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3692 * nsfont.m (ns_findfonts, nsfont_list_family):
3693 Don't assume fixnum fits in long.
3694 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3696 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3697 wide enough.
17fdb222 3698 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3700 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3701 (PRINTDECLARE, PRINTPREPARE):
3702 (strout, print_string):
3703 (print, print_preprocess, print_check_string_charset_prop)
3704 (print_object):
3705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3706 (PRINTDECLARE):
3707 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3709 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3710 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3711 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3712 (print_error_message): Use SAFE_ALLOCA, not alloca.
3713 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3714 (print_depth, new_backquote_output, print_number_index):
3715 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3716 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3717 (Fset_process_window_size, Fformat_network_address)
3718 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3719 (sigchld_handler):
d311d28c 3720 Check that fixnums are in proper range for system types.
d44287d4 3721 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3722 Check for process-ids out of pid_t range rather than relying on
3723 undefined behavior.
e4d81efc 3724 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3725 (Fformat_network_address, read_process_output, send_process)
3726 (Fprocess_send_region, status_notify):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3729 (wait_reading_process_output, read_process_output, exec_sentinel):
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3732 (Faccept_process_output): Use duration_to_sec_usec to do proper
3733 overflow checking on durations.
dde14581
PE
3734 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3735 Don't assume pid_t fits in int.
02481186
PE
3736 * process.h (struct Lisp_Process): Members tick and update_tick
3737 are now of type EMACS_INT, not int.
b62b53e8
PE
3738 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3739 configured --with-wide-int.
d311d28c
PE
3740 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3741 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3742 * search.c (looking_at_1, string_match_1):
3743 (fast_string_match, fast_c_string_match_ignore_case)
3744 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3745 (scan_newline, find_before_next_newline, search_command)
3746 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3747 (set_search_regs, wordify):
3748 (Freplace_match):
3749 (Fmatch_data):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (string_match_1, search_buffer, set_search_regs):
3752 (Fmatch_data):
3753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3754 (wordify): Check for overflow in size calculation.
3755 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3756 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3757 Check that fixnums are in proper range for system types.
3758 * sound.c (struct sound_device)
3759 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 (Fplay_sound_internal):
3762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3763 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3764 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3765 (Fparse_partial_sexp):
3766 Don't assume fixnums can fit in int.
3767 (struct lisp_parse_state, find_start_pos, find_start_value)
3768 (find_start_value_byte, find_start_begv)
3769 (update_syntax_table, char_quoted, dec_bytepos)
3770 (find_defun_start, prev_char_comend_first, back_comment):
3771 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3772 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3774 (Finternal_describe_syntax_value): Check that match_lisp is a
3775 character, not an integer, since the code stuffs it into int.
3776 (scan_words, scan_sexps_forward):
3777 Check that fixnums are in proper range for system types.
3778 (Fforward_word):
3779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3780 (scan_sexps_forward):
3781 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3782 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3783 * syntax.h: Adjust decls to match defn changes elsewhere.
3784 (struct gl_state_s):
3785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3786 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3787 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3788 * sysdep.c (wait_for_termination_1, wait_for_termination)
3789 (interruptible_wait_for_termination, mkdir):
3790 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3791 (emacs_read, emacs_write):
3792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3793 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3794 and double all fit in int.
d311d28c
PE
3795 * term.c (set_tty_color_mode):
3796 Check that fixnums are in proper range for system types.
3797 * termhooks.h (struct input_event):
3798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3799 * textprop.c (validate_interval_range, interval_of)
3800 (Fadd_text_properties, set_text_properties_1)
3801 (Fremove_text_properties, Fremove_list_of_text_properties)
3802 (Ftext_property_any, Ftext_property_not_all)
3803 (copy_text_properties, text_property_list, extend_property_ranges)
3804 (verify_interval_modification):
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (Fnext_single_char_property_change)
3807 (Fprevious_single_char_property_change):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3809 (copy_text_properties):
3810 Check for integer overflow in index calculation.
d311d28c
PE
3811 * undo.c (last_boundary_position, record_point, record_insert)
3812 (record_delete, record_marker_adjustment, record_change)
3813 (record_property_change):
3814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3815 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3817 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3818 (Fx_hide_tip, Fx_file_dialog):
3819 * w32menu.c (set_frame_menubar):
3820 Use ptrdiff_t, not int, for consistency with rest of code.
3821 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3822 (select_window, Fdelete_other_windows_internal)
3823 (window_scroll_pixel_based, window_scroll_line_based)
3824 (Frecenter, Fset_window_configuration):
3825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3826 (Fset_window_hscroll, run_window_configuration_change_hook)
3827 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3828 (Fscroll_other_window, Frecenter):
d311d28c
PE
3829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3830 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3831 Don't assume fixnum fits in int.
3832 (Fset_window_scroll_bars):
3833 Check that fixnums are in proper range for system types.
3834 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3835 (string_pos, c_string_pos, number_of_chars, init_iterator)
3836 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3837 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3838 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3839 (face_before_or_after_it_pos, handle_invisible_prop)
3840 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3841 (display_prop_intangible_p, string_buffer_position_lim)
3842 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3843 (get_overlay_strings_1, get_overlay_strings)
3844 (iterate_out_of_display_property, forward_to_next_line_start)
3845 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3846 (get_next_display_element, set_iterator_to_next)
3847 (get_visually_first_element, compute_stop_pos_backwards)
3848 (handle_stop_backwards, next_element_from_buffer)
3849 (move_it_in_display_line_to, move_it_in_display_line)
3850 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3851 (add_to_log, message_dolog, message_log_check_duplicate)
3852 (message2, message2_nolog, message3, message3_nolog
3853 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3854 (current_message_1, truncate_echo_area, truncate_message_1)
3855 (set_message, set_message_1, store_mode_line_noprop)
3856 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3857 (text_outside_line_unchanged_p, check_point_in_composition)
3858 (reconsider_clip_changes)
3859 (redisplay_internal, set_cursor_from_row, try_scrolling)
3860 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3861 (redisplay_window, find_last_unchanged_at_beg_row)
3862 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3863 (trailing_whitespace_p, find_row_edges, display_line)
3864 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3865 (display_mode_element, store_mode_line_string)
3866 (pint2str, pint2hrstr, decode_mode_spec)
3867 (display_count_lines, display_string, draw_glyphs)
3868 (x_produce_glyphs, x_insert_glyphs)
3869 (rows_from_pos_range, mouse_face_from_buffer_pos)
3870 (fast_find_string_pos, mouse_face_from_string_pos)
3871 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3873 (safe_call, init_from_display_pos, handle_fontified_prop)
3874 (handle_single_display_spec, load_overlay_strings)
3875 (with_echo_area_buffer, setup_echo_area_for_printing)
3876 (display_echo_area, echo_area_display)
3877 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3878 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3879 (redisplay_window, dump_glyph_row, display_mode_line)
3880 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3881 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 (handle_single_display_spec, build_desired_tool_bar_string)
3884 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3885 (get_specified_cursor_type):
3886 Check that fixnums are in proper range for system types.
3887 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3888 (Flookup_image_map):
3889 Don't assume fixnums fit in int.
3890 (compare_overlay_entries):
3891 Avoid mishandling comparisons due to subtraction overflow.
3892 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3893 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3894 (handle_tool_bar_click):
3895 Use int, not unsigned, since we prefer signed and the signedness
3896 doesn't matter here.
3897 (get_next_display_element, next_element_from_display_vector):
3898 Use int, not EMACS_INT, when int is wide enough.
3899 (start_hourglass): Use duration_to_sec_usec to do proper
3900 overflow checking on durations.
3901 * xfaces.c (Fbitmap_spec_p):
3902 Check that fixnums are in proper range for system types.
3903 (compare_fonts_by_sort_order):
3904 Avoid mishandling comparisons due to subtraction overflow.
3905 (Fx_family_fonts, realize_basic_faces):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (Fx_family_fonts):
3908 Don't assume fixnum fits in int.
3909 Use SAFE_ALLOCA_LISP, not alloca.
3910 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3911 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3912 (face_at_buffer_position, face_for_overlay_string)
3913 (face_at_string_position):
3914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3915 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3916 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3917 (Fx_show_tip):
3918 Check that fixnums are in proper range for system types.
3919 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3920 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3922 (Fx_change_window_property): Don't assume fixnums fit in int.
3923 * xfont.c (xfont_chars_supported):
3924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3925 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3926 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3928 * xml.c (parse_region):
3929 * xrdb.c (magic_file_p):
3930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3931 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3932 (x_get_local_selection, x_reply_selection_request)
3933 (x_handle_selection_request, wait_for_property_change):
3934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3935 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3936 short is wide enough.
3937 (x_send_client_event): Don't assume fixnum fits in int.
3938 * xterm.c (x_x_to_emacs_modifiers):
3939 Don't assume EMACS_INT overflows nicely into int.
3940 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3941 may come from Lisp.
3942 (handle_one_xevent): NATNUMP can eval its arg twice.
3943 (x_connection_closed):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 * xterm.h: Adjust decls to match defn changes elsewhere.
3946 (struct scroll_bar): Use struct vectorlike_header
3947 rather than rolling our own approximation.
3948 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3949
c6574eb5
GM
39502012-05-25 Glenn Morris <rgm@gnu.org>
3951
3952 * lisp.mk (lisp): Update for more files being compiled now.
3953
e8d32c7e
SM
39542012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3955
48def666
SM
3956 * lread.c: Remove `read_pure' which makes no difference.
3957 (read_pure): Remove var.
3958 (unreadpure): Remove function.
3959 (readevalloop): Don't call read_list with -1 flag.
3960 (read1, read_vector): Don't test read_pure any more.
3961 (read_list): Simplify.
3962
e8d32c7e
SM
3963 * fileio.c, character.h: Minor style tweaks.
3964
4b2addb7
DA
39652012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3966
3967 * window.h (clip_changed): Remove useless declaration.
3968
584461b2
JB
39692012-05-22 Juanma Barranquero <lekktu@gmail.com>
3970
3971 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3972 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3973
34374650
PE
39742012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3975
3976 Remove src/m/*.
3977 This directory predates autoconf and is no longer needed nowadays.
3978 Move its few remaining bits of functionality to where they're needed.
3979 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3980 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3981 * m/template.h: Remove.
3982 * Makefile.in (M_FILE): Remove. All uses removed.
3983 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3984 * lisp.h (USE_LSB_TAG):
3985 * mem-limits.h (EXCEEDS_LISP_PTR):
3986 Use VAL_MAX, not VALBITS, in #if.
3987 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3988 (EMACS_UINT): Define unconditionally now.
3989 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3990 (BITS_PER_EMACS_INT): New constants, replacing
3991 what used to be in config.h, but not useful in #if.
3992 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3993 define them any more.
3994 (VAL_MAX): New macro.
3995 (VALMASK): Use it.
3996 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3997 BITS_PER_EMACS_INT, in #if.
3998 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3999 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4000 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4001 * s/ms-w32.h (DATA_START):
4002 Move here from removed file m/intel386.h.
4003 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4004 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4005
261cb4bb
PE
40062012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Assume C89 or later.
4009 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4010 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4011 (xrealloc):
4012 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4013 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4014 * textprop.c, tparam.c (NULL): Remove.
4015 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4016 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4017 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4018 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4019 * xterm.c (input_signal_count): Assume volatile works.
4020
ff23cd9f
KB
40212012-05-21 Ken Brown <kbrown@cornell.edu>
4022
4023 * xgselect.c (xg_select): Fix first argument in call to 'select'
4024 (bug#11508).
4025
1b170bc6
KB
40262012-05-20 Ken Brown <kbrown@cornell.edu>
4027
4028 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4029 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4030
b2f4d39f
KB
40312012-05-19 Ken Brown <kbrown@cornell.edu>
4032
4033 * xfns.c (x_in_use): Remove `static' qualifier.
4034 * xterm.h (x_in_use): Declare.
4035 * xgselect.c: Include xterm.h.
4036 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4037 and `display_arg' (bug#9754).
4038
003fdae2
PE
40392012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4040
9232a6d9
PE
4041 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4042
003fdae2
PE
4043 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4044 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4045
784b56e2
EZ
40462012-05-18 Eli Zaretskii <eliz@gnu.org>
4047
4048 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4049
4050 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4051 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4052
4053 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4054 reference to image_cache->refcount.
4055 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4056
a0a79cde
JL
40572012-05-17 Juri Linkov <juri@jurta.org>
4058
4059 * search.c (Fword_search_regexp, Fword_search_backward)
4060 (Fword_search_forward, Fword_search_backward_lax)
4061 (Fword_search_forward_lax): Move functions to isearch.el
4062 (bug#10145, bug#11381).
4063
b0572523
PE
40642012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4067
9660f5fc
SM
40682012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 * lread.c (init_obarray): Declare Qt and Qnil as special.
4071
4374de83
GM
40722012-05-14 Glenn Morris <rgm@gnu.org>
4073
4074 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4075 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4076
dc44c39a
PE
40772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4078
078c97cb
PE
4079 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4080
dc44c39a
PE
4081 * unexaix.c: Port to more-recent AIX compilers.
4082 (report_error, report_error_1, make_hdr, copy_sym)
4083 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4084 Make arguments const char *, not char *, to avoid violations of C
4085 standard and to fix some AIX warnings reported by Gilles Pion.
4086
e18afed7 40872012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4088
4089 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4090 already have overlays loaded.
4091 (handle_single_display_spec): Before returning without displaying
4092 fringe bitmap, synchronize the bidi iterator with the main display
4093 iterator, by calling iterate_out_of_display_property.
4094 (iterate_out_of_display_property): Detect buffer iteration by
4095 testing that it->string is a Lisp string.
4096 (get_next_display_element): When the current object is exhausted,
4097 and there's something on it->stack, call set_iterator_to_next to
4098 proceed with what's on the stack, instead of returning zero.
4099 (set_iterator_to_next): If called at the end of a Lisp string,
4100 proceed to consider_string_end without incrementing string
4101 position. Don't increment display vector index past the end of
4102 the display vector. (Bug#11417)
c8fb9dc6
EZ
4103 (pos_visible_p): Don't report a position visible when move_it_to
4104 stopped at the last line of window, which happens to be scanned
4105 backwards by the bidi iteration. (Bug#11464)
ac268e67 4106
e18afed7 41072012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4108
4109 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4110 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4111 are on a TTY, and thus unable to display on the fringes.
4112 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4113 so we need to signal to the caller that this is a "replacing"
4114 display spec. This fixes display when the spec is invalid or we
4115 are on a TTY.
4116
e18afed7 41172012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4118
4119 * unexaix.c (make_hdr): Fix typo in prototype.
4120 This bug broke the build on AIX. Problem reported by Gilles Pion.
4121
9d0a235a
MA
41222012-05-14 Michael Albinus <michael.albinus@gmx.de>
4123
4124 * keyboard.c (kbd_buffer_get_event): Read special events also in
4125 batch mode. (Bug#11415)
4126
9e6b06ed
GM
41272012-05-12 Glenn Morris <rgm@gnu.org>
4128
4129 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4130
c1a1d7a3
EZ
41312012-05-12 Eli Zaretskii <eliz@gnu.org>
4132
4133 * lisp.mk (lisp): Add newcomment.elc.
4134
3fe7cdc8
GM
41352012-05-12 Glenn Morris <rgm@gnu.org>
4136
4137 * Makefile.in (MKDIR_P): New, set by configure.
4138 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4139
53f7d2c0
PE
41402012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4141
4142 Remove unused function hourglass_started.
4143 * dispextern.h (hourglass_started):
4144 * w32fns.c (hourglass_started):
4145 * xdisp.c (hourglass_started): Remove.
4146
75aafb17
JB
41472012-05-10 Juanma Barranquero <lekktu@gmail.com>
4148
4149 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4150 Update dependencies.
4151
12959e8e
PE
41522012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4153
97107e2e
PE
4154 * xgselect.c (xg_select): Put maxfds+1 into a var.
4155 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4156
12959e8e
PE
4157 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4158
836d29b3
DA
41592012-05-10 Dave Abrahams <dave@boostpro.com>
4160
4161 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4162 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4163
5cb67954
MA
41642012-05-09 Michael Albinus <michael.albinus@gmx.de>
4165
4166 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4167 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4168 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4169 Initialize xd_registered_buses.
4170
3478ec45
PE
41712012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4172
b263a6b0
PE
4173 Untag more efficiently if USE_LSB_TAG.
4174 This is based on a proposal by YAMAMOTO Mitsuharu in
4175 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4176 For an admittedly artificial (nth 8000 longlist) benchmark on
4177 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4178 Emacs's overall text size by 1%.
4179 * lisp.h (XUNTAG): New macro.
4180 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4181 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4182 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4183 * eval.c (Fautoload):
4184 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4185 * frame.h (XFRAME): Use XUNTAG.
4186
3478ec45
PE
4187 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4188 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4189 Remove unportable assumptions about print widths of types like
4190 dbus_uint32_t.
4191 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4192 intptr_t when converting between pointer and integer, to avoid GCC
4193 warnings about wrong width.
4194
666b903b 41952012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4196
4197 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4198 stack for each reader_thread, instead of defaulting to 8MB
4199 determined by the linker. This avoids failures in creating
4200 subprocesses on Windows 7, see the discussion in this thread:
4201 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4202
b120cc17
JC
42032012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4204
4205 Fix up display of the *Minibuf-0* buffer in the mini window.
4206 * keyboard.c (read_char): Don't clear the echo area if there's no
4207 message to clear.
4208 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4209 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4210
9a4b36f8
MA
42112012-05-07 Michael Albinus <michael.albinus@gmx.de>
4212
4213 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4214 batch mode.
4215
e5f9458f
CY
42162012-05-06 Chong Yidong <cyd@gnu.org>
4217
4218 * lisp.mk (lisp): Update.
4219
eceeb5fc 42202012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4221
4222 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4223
71873e2b
SM
42242012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4225
4226 * data.c (PUT_ERROR): New macro.
4227 (syms_of_data): Use it. Add new error type `user-error'.
4228 * undo.c (user_error): New function.
4229 (Fprimitive_undo): Use it.
4230 * print.c (print_error_message): Adjust print style for `user-error'.
4231 * keyboard.c (user_error): New function.
4232 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4233
ab0fa4e4
PE
42342012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 Do not limit current-time-string to years 1000..9999.
4237 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4238 (Fcurrent_time_string): Support any year that is supported by the
4239 underlying localtime representation. Don't use asctime, as it
4240 has undefined behavior for years outside the range -999..9999.
4241
7ed806a7
PE
42422012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 Fix race conditions involving setenv, gmtime, localtime, asctime.
4245 Without this fix, interrupts could mess up code that uses these
4246 nonreentrant functions, since setting TZ invalidates existing
4247 tm_zone or tzname values, and since most of these functions return
4248 pointers to static storage.
4249 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4250 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4251 Grow the critical sections to include not just invoking
4252 localtime/gmtime, but also accessing these functions' results
4253 including their tm_zone values if any, and any related TZ setting.
4254 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4255 so that the struct tm is saved in the critical section.
4256 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4257 motivated by the fact that memory allocation needs to be outside
4258 the critical section.
4259
0c16dfed
DA
42602012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4261
4262 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4263 with RESET_INTERVAL.
4264
4265 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4266 Remove duplicated buffer name initialization.
4267
3f83ace8
JM
42682012-05-02 Jim Meyering <jim@meyering.net>
4269
4270 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4271
c7b8541e
JM
4272 * xfns.c (x_window): Use xstrdup (Bug#11375).
4273
90207a15 42742012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4275
4276 * xdisp.c (pos_visible_p): If already at a newline from the
4277 display string before the 'while' loop, don't walk back the glyphs
4278 from it3.glyph_row. Solves assertion violation when the display
4279 string begins with a newline (egg.el). (Bug#11367)
4280
b593d6a9
AH
42812012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4282
4283 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4284 Move to simple.el.
4285
4737362e
GM
42862012-05-01 Glenn Morris <rgm@gnu.org>
4287
99cf43f9
GM
4288 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4289 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4290 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4291 All were removed before 23.1.
4292
9311dcff
GM
4293 * dispnew.c: Remove HAVE_LIBNCURSES test;
4294 it is always true on relevant platforms.
4295
4d5c6349
GM
4296 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4297 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4298
4737362e
GM
4299 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4300
74dd3a6b
AS
43012012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4302
4303 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4304 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4305 Remove.
4306
13c379ee
PE
43072012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 Do not avoid creating empty evaporating overlays (Bug#9642).
4310 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4311 That is, do not delete an evaporating overlay if it becomes
4312 empty after its bounds are adjusted to fit within its buffer.
4313 This fix caused other problems, and I'm reverting it until we get
4314 to the bottom of them.
4315
a8e7d6d7 43162012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4317
4318 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4319
a8e7d6d7 43202012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4321
4322 * xdisp.c (pos_visible_p): If the window start position is beyond
4323 ZV, start the display from buffer beginning. Prevents assertion
4324 violation in init_iterator when the minibuffer window is scrolled
4325 via the scroll bar.
4326
4327 * window.c (window_scroll_pixel_based): Likewise.
4328
a8e7d6d7 43292012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4330
4331 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4332
a8e7d6d7 43332012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4334
4335 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4336 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4337
a8e7d6d7 43382012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4339
b593d6a9
AH
4340 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4341 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4342
1c6900d9
EZ
43432012-04-26 Eli Zaretskii <eliz@gnu.org>
4344
4c3fa1d9
EZ
4345 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4346 display element, check also the underlying string or buffer
4347 character. (Bug#11341)
4348
1c6900d9
EZ
4349 * w32menu.c: Include w32heap.h.
4350 (add_menu_item): If the call to AppendMenuW (via
4351 unicode_append_menu) fails, disable Unicode menus only if we are
4352 running on Windows 9X/Me.
4353
42bf8205
AS
43542012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4355
4356 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4357 (xgetint): Add missing shift for LSB tags.
4358
b1bac16e
MR
43592012-04-24 Martin Rudalics <rudalics@gmx.at>
4360
4361 * keyboard.c (read_char): Don't wipe echo area for select window
4362 events: These might get delayed via `mouse-autoselect-window'
4363 (Bug#11304).
4364
d69621cc
JB
43652012-04-24 Juanma Barranquero <lekktu@gmail.com>
4366
4367 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4368 manipulation of :loaded-from data.
4369
02fd101b
JB
43702012-04-23 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4373 now a cons (bug#11311).
4374
888bec30
PE
43752012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4376
89a438bd
PE
4377 Do not create empty overlays with the evaporate property (Bug#9642).
4378 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4379 if it becomes empty after its bounds are adjusted to fit within
4380 its buffer. Without this fix, in a nonempty buffer (let ((o
4381 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4382 yields an empty overlay that has the evaporate property, which is
4383 not supposed to happen.
4384
1068fe4d
PE
4385 Fix minor GTK3 problems found by static checking.
4386 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4387 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4388 (struct _EmacsFixedClass, emacs_fixed_get_type):
4389 Move decls here from emacsgtkfixed.h, since they needn't be public.
4390 (emacs_fixed_get_type): Now static.
4391 (emacs_fixed_class_init): Omit unused local.
4392 (emacs_fixed_child_type): Remove; unused.
4393 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4394 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4395 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4396 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4397 (EMACS_FIXED_GET_CLASS): Remove; unused.
4398 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4399
888bec30
PE
4400 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4401 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4402
de85e130
PE
44032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4404
d0baac98 4405 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4406 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4407 (__malloc_size_t, __malloc_ptrdiff_t):
4408 Remove. All uses removed, replaced by the definiens if needed,
4409 since we can assume C89 or better now.
4410 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4411 (protect_malloc_state, align, get_contiguous_space)
4412 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4413 (malloc_atfork_handler_child, malloc_enable_thread)
4414 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4415 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4416 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4417 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4418 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4419 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4420 Define using prototypes, not old style.
4421 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4422 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4423 (align): Don't assume that signed integer overflow wraps around.
4424 Omit unused local var.
4425 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4426 (_free_internal_nolock, memalign, mallochook, reallochook):
4427 Omit no-longer-needed casts.
4428 (valloc): Use getpagesize, not __getpagesize.
4429 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4430 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4431
de85e130
PE
4432 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4433
dcbf5805
MA
44342012-04-22 Michael Albinus <michael.albinus@gmx.de>
4435
4436 Move functions from C to Lisp. Make non-blocking method calls
4437 the default. Implement further D-Bus standard interfaces.
4438
4439 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4440 (QCdbus_request_name_allow_replacement)
4441 (QCdbus_request_name_replace_existing)
4442 (QCdbus_request_name_do_not_queue)
4443 (QCdbus_request_name_reply_primary_owner)
4444 (QCdbus_request_name_reply_in_queue)
4445 (QCdbus_request_name_reply_exists)
4446 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4447 (QCdbus_registered_serial, QCdbus_registered_method)
4448 (QCdbus_registered_signal): New Lisp objects.
4449 (XD_DEBUG_MESSAGE): Use sizeof.
4450 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4451 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4452 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4453 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4454 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4455 (xd_signature, xd_append_arg): Allow float for integer types.
4456 (xd_get_connection_references): New function.
b593d6a9
AH
4457 (xd_get_connection_address): Rename from xd_initialize.
4458 Return cached address.
dcbf5805
MA
4459 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4460 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4461 level.
4462 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4463 Return number of refcounts.
dcbf5805
MA
4464 (Fdbus_get_unique_name): Make stronger parameter check.
4465 (Fdbus_message_internal): New defun.
4466 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4467 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4468 (Fdbus_send_signal, Fdbus_register_service)
4469 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4470 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4471 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4472 (Vdbus_compiled_version, Vdbus_runtime_version)
4473 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4474 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4475 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4476 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4477 Adapt docstring.
dcbf5805 4478
52828e02
PE
44792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4480
da05bc4c
PE
4481 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4482 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4483 Do not assume ptrdiff_t is the same width as 'int'.
4484
52828e02
PE
4485 * alloc.c: Handle unusual debugging option combinations.
4486 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4487 since the two debugging options are incompatible.
4488 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4489 is defined.
4490 (mem_init, mem_insert, mem_insert_fixup):
4491 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4492 (NEED_MEM_INSERT): Remove; no longer needed.
4493
f01769f9
LL
44942012-04-22 Leo Liu <sdl.web@gmail.com>
4495
4496 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4497
5790543d
PE
44982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 * sysdep.c [__FreeBSD__]: Minor cleanups.
4501 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4502 Use Emacs indenting style more consistently. Avoid some casts.
4503 Use 'double' consistently rather than mixing 'float' and 'double'.
4504
b91b7e4d
EW
45052012-04-21 Eduard Wiebe <usenet@pusto.de>
4506
b593d6a9
AH
4507 * sysdep.c (list_system_processes, system_process_attributes):
4508 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4509
6114eb15
AS
45102012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4511
4512 * lisp.mk (lisp): Update.
4513
2f38dff7
PE
45142012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4515
4516 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4517 It is never used otherwise.
4518
4ae29f89
SM
45192012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4520
4521 * print.c (print_preprocess): Only check print_depth if print-circle
4522 is nil.
4523 (print_object): Check for cycles even when print-circle is nil and
4524 print-gensym is t, but only check print_depth if print-circle is nil.
4525
f30d612a
CY
45262012-04-20 Chong Yidong <cyd@gnu.org>
4527
4528 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4529 set the status to "failed" and ensure that sentinel is run.
4530
c07a4c0b 45312012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4532
4533 * process.c (Fset_process_inherit_coding_system_flag)
4534 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4535 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4536
c07a4c0b 45372012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4538
4539 * xdisp.c (string_buffer_position_lim): Limit starting position to
4540 BEGV.
4541 (set_cursor_from_row): If called for a mode-line or header-line
4542 row, return zero immediately.
4543 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4544 farther than the first row after the header line, if any.
4545 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4546 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4547
c07a4c0b 45482012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4549
4ae29f89
SM
4550 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4551 (bug#11238).
ad3a2b41 4552
c07a4c0b 45532012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45542012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4555
4556 configure: new option --enable-gcc-warnings (Bug#11207)
4557 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4558 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4559 (ALL_CFLAGS): Use new macros rather than old.
4560 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4561 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4562 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4563 -Wunused-result, -Wunused-variable. This should go away once
4564 the Emacs and Gnulib regex code is merged.
4565 (xmalloc, xrealloc): Now static.
4566
aba027e8
PE
45672012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * dired.c (Fsystem_groups): Remove unused local.
4570
e5a36063
GM
45712012-04-17 Glenn Morris <rgm@gnu.org>
4572
4573 * dired.c (Fsystem_users): Doc fix.
4574
316411f0
DA
45752012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4576
4577 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4578 (syms_of_dired): Add them.
4579
9426aba4
PE
45802012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4581
b62a57be
PE
4582 Fix minor alloc.c problems found by static checking.
4583 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4584 New extern decls, to avoid calling undeclared functions.
4585 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4586 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4587 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4588 (NEED_MEM_INSERT): New macro.
4589 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4590 Remove one incorrect comment and fix another.
b62a57be 4591
3539f31f
PE
4592 Fix minor ralloc.c problems found by static checking.
4593 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4594 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4595 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4596 (r_alloc_sbrk): Now static.
4597
a041960a
PE
4598 Improve ralloc.c interface checking.
4599 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4600 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4601 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4602 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4603 [REL_ALLOC]: ... to here, to check interface.
4604 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4605 Remove decls. This fixes an "It stinks!".
4606
9426aba4
PE
4607 * alloc.c (which_symbols): Fix alignment issue / type clash.
4608
d55c12ed
AS
46092012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4610
4611 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4612 (struct Lisp_Misc_Any): Likewise.
4613 (struct Lisp_Free): Likewise.
4614 * alloc.c (union aligned_Lisp_Symbol): Define.
4615 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4616 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4617 (union aligned_Lisp_Misc): Define.
4618 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4619 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4620 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4621
b948ce8b
PE
46222012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4625 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4626 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4627 * s/netbsd.h, s/sol2-6.h:
4628 Remove definition of GC_MARK_STACK, since the default now works.
4629 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4630 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4631 no longer the default.
4632 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4633
35dc09a1 46342012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4635
35dc09a1
GM
4636 * lread.c (lisp_file_lexically_bound_p):
4637 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4638
35dc09a1
GM
46392012-04-14 Eli Zaretskii <eliz@gnu.org>
4640
4641 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4642 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4643
46442012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4645
4646 * nsterm.m (constrainFrameRect): Always constrain when there is only
4647 one screen (Bug#10962).
4648
bcd86815
KB
46492012-04-13 Ken Brown <kbrown@cornell.edu>
4650
4651 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4652
c25df26e
RT
46532012-04-13 Reuben Thomas <rrt@sc3d.org>
4654
4655 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4656
0fc59f1e
DC
46572012-04-11 Daniel Colascione <dancol@dancol.org>
4658
4659 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4660 against is gone. It's better to use vfork now so that when Cygwin
4661 gains a new, working vfork, we use it automatically (bug#10398).
4662
de8c03dc
SM
46632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4664
4665 * window.c (save_window_save): Obey window-point-insertion-type.
4666
2f097256
GM
46672012-04-11 Glenn Morris <rgm@gnu.org>
4668
4669 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4670
453b951e
SM
46712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4672
4673 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4674
75f1671a 46752012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4676
4677 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4678 (force_quit_count): New var.
4679 (handle_interrupt): Use it.
4680
2a8ce227
JB
46812012-04-10 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * w32.c (w32_delayed_load): Record the full path of the library
4684 being loaded (bug#10424).
4685
935396c0
GM
46862012-04-09 Glenn Morris <rgm@gnu.org>
4687
05920a43
GM
4688 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4689 not just in the obarray, before snarfing them. (Bug#11036)
4690
935396c0
GM
4691 * Makefile.in ($(leimdir)/leim-list.el):
4692 Pass EMACS rather than BUILT_EMACS.
4693
a18ecafa
TZ
46942012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4695
4696 * process.c (make_process):
4697 * process.h: Add integer `gnutls_handshakes_tried' member to
4698 process struct.
4699
6bbef4e5
JC
4700 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4701 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4702
4703 * gnutls.c (gnutls_log_function2i): Convenience log function.
4704 (emacs_gnutls_read): Use new log functions,
4705 `gnutls_handshakes_tried' process member, and
4706 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4707 attempts per process (connection).
4708
b4d3bc10
CY
47092012-04-09 Chong Yidong <cyd@gnu.org>
4710
4711 * eval.c (Fuser_variable_p, user_variable_p_eh)
4712 (lisp_indirect_variable): Functions deleted.
4713 (Fdefvar): Caller changed.
4714
4715 * callint.c (Finteractive, Fcall_interactively):
4716 * minibuf.c (Fread_variable): Callers changed.
4717
70f4d973
EZ
47182012-04-09 Eli Zaretskii <eliz@gnu.org>
4719
4720 * xdisp.c (set_cursor_from_row): If the display string appears in
4721 the buffer at position that is closer to point than the position
4722 after the display string, display the cursor on the first glyph of
4723 the display string. Fixes cursor display when a 'display' text
4724 property immediately follows invisible text. (Bug#11094)
4725
cb3c2e3e
PE
47262012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 composite.c: use 'double' consistently
4729 * composite.c (get_composition_id): Use 'double' consistently
4730 instead of converting 'float' to 'double' and vice versa; this is
4731 easier to understand and avoids a GCC warning.
4732
fd06db5d
GM
47332012-04-09 Glenn Morris <rgm@gnu.org>
4734
50fe702a
GM
4735 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4736 preparation for dumping it with emacs. (Bug#4789)
4737 (leimdir): New variable.
4738 ($(leimdir)/leim-list.el): New rule.
4739 (emacs$(EXEEXT)): Depend on leim-list.el.
4740
fd06db5d
GM
4741 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4742 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4743 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4744
55c131ee
AS
47452012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4746
4747 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4748 proper alignment.
4749
9209588f
JB
47502012-04-07 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4753 Remove unused local variable.
4754
e3fb2efb
PE
47552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4758 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4759 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4760 objects, as mark_maybe_pointer will catch them otherwise.
4761 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4762 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4763
b5385551
PE
47642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4765
4766 Fix typo that broke non-Windows builds.
4767 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4768
9078ead6
EZ
47692012-04-07 Eli Zaretskii <eliz@gnu.org>
4770
4771 Support building on MS-Windows with libxml2.
4772
4773 * makefile.w32-in (OBJ2): Add xml.$(O).
4774 (GLOBAL_SOURCES): Add xml.c.
4775 ($(BLD)/xml.$(O)): New dependency list.
4776
4777 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4778 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4779 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4780 [!WINDOWSNT]: New macros.
4781 (init_libxml2_functions, libxml2_loaded_p): New functions.
4782 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4783 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4784 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4785 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4786 linked in).
6bbef4e5
JC
4787 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4788 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4789 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4790
4791 * emacs.c: Don't include libxml/parser.h.
4792 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4793 xmlCleanupParser directly.
4794
4795 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4796
3811fdf3
EZ
47972012-04-07 Eli Zaretskii <eliz@gnu.org>
4798
4799 * indent.c (Fvertical_motion): If there is a display string at
4800 point, use it.vpos to compute how many lines to backtrack after
4801 move_it_to point. (Bug#11133)
4802
2f8e16b2
EZ
48032012-04-06 Eli Zaretskii <eliz@gnu.org>
4804
4805 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4806 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4807 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4808 macros related to unification of CJK characters. For the details,
4809 see the discussion following the message here:
4810 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4811
3d439cd1
CY
48122012-04-04 Chong Yidong <cyd@gnu.org>
4813
4814 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4815
8bc53d00
EZ
48162012-04-01 Eli Zaretskii <eliz@gnu.org>
4817
4818 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4819 instead of alloca. (Bug#11138)
4820
3b0512a3
AS
48212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4822
4823 * w32menu.c (is_simple_dialog): Properly check lisp types.
4824 (Bug#11141)
4825
8427ddd2
EZ
48262012-03-31 Eli Zaretskii <eliz@gnu.org>
4827
979022ef
EZ
4828 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4829 position we get to after a call to move_it_to fails the
4830 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4831 only if we wind up in a string from display property. (Bug#11063)
4832
a6b1c7cc
EZ
4833 * window.c (Fdelete_other_windows_internal): Invalidate the row
4834 and column information about mouse highlight, so that redisplay
4835 restores it after reallocating the glyph matrices. (Bug#7464)
4836
8427ddd2
EZ
4837 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4838 string comes from a `display' text property, use the buffer
4839 position of that property as if we actually saw that position in
4840 the row's glyphs.
697ba24b
EZ
4841 (move_it_by_lines): Remove the assertion that
4842 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4843 violated when there's a before-string at the beginning of a line.
4844 (Bug#11063)
8427ddd2 4845
65a0a738
EZ
48462012-03-30 Eli Zaretskii <eliz@gnu.org>
4847
4848 * xdisp.c (append_space_for_newline): If the default face was
4849 remapped, use the remapped face for the appended newline.
4850 (extend_face_to_end_of_line): Use the remapped default face for
4851 extending the face to the end of the line.
4852 (display_line): Call extend_face_to_end_of_line when the default
4853 face was remapped. (Bug#11068)
4854
581355cc
EZ
48552012-03-29 Eli Zaretskii <eliz@gnu.org>
4856
4857 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4858
e8fc049f
SM
48592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4860
4861 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4862
4fb9a543
GM
48632012-03-27 Glenn Morris <rgm@gnu.org>
4864
4865 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4866 Doc fixes.
4867
679910f1
KH
48682012-03-26 Kenichi Handa <handa@m17n.org>
4869
4870 * dispextern.h (struct glyph): Fix previous change. Change the
4871 bit length of glyphless.ch to 25 (Bug#11082).
4872
90d49b7f
CY
48732012-03-26 Chong Yidong <cyd@gnu.org>
4874
4875 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4876 (command_loop_1): Use it; inhibit selection update for
4877 handle-select-window too (Bug#8996).
4878
f514f6f0
FP
48792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4880
e8fc049f 4881 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4882
bf43fa51
KH
48832012-03-25 Kenichi Handa <handa@m17n.org>
4884
4885 * dispextern.h (struct glyph): Change the bit length of
4886 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4887
8a0c01dd
EZ
48882012-03-24 Eli Zaretskii <eliz@gnu.org>
4889
4890 * s/ms-w32.h (tzname): Include time.h before redirecting to
4891 _tzname. Fixes the MSVC build. (Bug#9960)
4892
7d1c3a76
AS
48932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4894
8ed79523
AS
4895 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4896 characters.
4897
7d1c3a76
AS
4898 * xterm.c (XTread_socket): Only modify handling_signal if
4899 !SYNC_INPUT. (Bug#11080)
4900
e99a9b8b
EZ
49012012-03-23 Eli Zaretskii <eliz@gnu.org>
4902
4903 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4904 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4905 when fetching a multibyte character consumes more bytes than
4906 CHAR_BYTES returns, due to unification of CJK characters in
4907 string_char. (Bug#11073)
4908
5063c0e1
TN
49092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4910
4911 * process.c (wait_reading_process_output): Handle pty disconnect
4912 by refraining from sending oneself a SIGCHLD (bug#10933).
4913
9f851fbd
CY
49142012-03-22 Chong Yidong <cyd@gnu.org>
4915
4916 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4917
5063c0e1 4918 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4919 Mark string as coming from a prefix property.
4920 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4921 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4922
fb5b8aca
CY
49232012-03-21 Chong Yidong <cyd@gnu.org>
4924
4925 * xfaces.c (Vface_remapping_alist): Doc fix.
4926
62356a1b
EZ
49272012-03-20 Eli Zaretskii <eliz@gnu.org>
4928
4929 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4930 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4931 Doc fixes.
62356a1b 4932
025de85b
CY
49332012-03-20 Chong Yidong <cyd@gnu.org>
4934
4935 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4936 to reflect default non-nil value of redisplay-dont-pause.
4937
4827f94e
KH
49382012-03-19 Kenichi Handa <handa@m17n.org>
4939
4940 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4941 it fit in a valid range (Bug#11003).
4942
e50a24a2
EZ
49432012-03-18 Eli Zaretskii <eliz@gnu.org>
4944
4945 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4946 that is not from display property, accept the row as a "cursor
4947 row" if one of the string's character has a non-nil `cursor'
4948 property. Fixes cursor positioning when there are newlines in
4949 overlay strings, e.g. in icomplete.el. (Bug#11035)
4950
9af5ed87
PE
49512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4954
d1f55f16
CY
49552012-03-12 Chong Yidong <cyd@gnu.org>
4956
4957 * eval.c (inhibit_lisp_code): Rename from
4958 inhibit_window_configuration_change_hook; move from window.c.
4959
4960 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4961 * window.c (run_window_configuration_change_hook)
4962 (syms_of_window): Callers changed.
4963
66c5eebd
CY
49642012-03-11 Chong Yidong <cyd@gnu.org>
4965
413df973
CY
4966 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4967
66c5eebd
CY
4968 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4969
1de11f56
CY
49702012-03-10 Chong Yidong <cyd@gnu.org>
4971
4972 * frame.c (other_visible_frames): Don't assume the selected frame
4973 is visible (Bug#10955).
4974
cae07000
SM
49752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4976
4977 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4978
89c94350
JD
49792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4980
4981 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4982 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4983 zero (Bug#10954).
4984
999dd333
GM
49852012-03-03 Glenn Morris <rgm@gnu.org>
4986
01a6dcc8 4987 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4988
de0100f2
EZ
49892012-03-02 Eli Zaretskii <eliz@gnu.org>
4990
4991 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4992 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4993 (redisplay_window, next_element_from_string): Fix typos in
4994 comments.
3e441275
EZ
4995 (redisplay_window): Pass to move_it_vertically the margin in
4996 pixels, not in screen lines.
de0100f2 4997
96a72ee9
GM
49982012-03-02 Glenn Morris <rgm@gnu.org>
4999
5000 * buffer.c (buffer-list-update-hook): Doc fix.
5001
312508d7
EZ
50022012-02-29 Eli Zaretskii <eliz@gnu.org>
5003
5004 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5005 push_it before setting up the iterator for the first overlay
5006 string, even if we have an empty string loaded.
5007 (next_overlay_string): If there's an empty string on the iterator
5008 stack, pop the stack. (Bug#10903)
5009
27f3c637
PE
50102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5011
5012 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5013 Suggested by Stefan Monnier in
5014 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5015 * alloc.c (widen_to_Lisp_Object): New static function.
5016 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5017 and widening them to Lisp_Objects. This would work even if
5018 USE_LSB_TAG is defined and wide integers are used, which might
5019 happen in a future version of Emacs.
5020
3c9dfce6
CY
50212012-02-25 Chong Yidong <cyd@gnu.org>
5022
fa74b241
CY
5023 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5024 Doc fix.
5025
3c9dfce6
CY
5026 * xselect.c (Fx_selection_exists_p): Doc fix.
5027 (x_clipboard_manager_save_all): Print an informative message
5028 before saving to clipboard manager.
5029
9486df08
CY
50302012-02-24 Chong Yidong <cyd@gnu.org>
5031
5032 * keyboard.c (process_special_events): Handle all X selection
5033 requests in kbd_buffer, not just the next one (Bug#8869).
5034
f01d3321
CY
50352012-02-23 Chong Yidong <cyd@gnu.org>
5036
5037 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5038 call when setting menu-bar-lines and tool-bar-lines parameters.
5039 (unwind_create_frame_1): New helper function.
5040
5041 * window.c (inhibit_window_configuration_change_hook): New var.
5042 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5043 (syms_of_window): Initialize it.
f01d3321 5044
86b847b6
CY
50452012-02-22 Chong Yidong <cyd@gnu.org>
5046
5047 * xterm.c (x_draw_image_relief): Add missing type check for
5048 Vtool_bar_button_margin (Bug#10743).
5049
a59225b1
CY
50502012-02-21 Chong Yidong <cyd@gnu.org>
5051
5052 * fileio.c (Vfile_name_handler_alist): Doc fix.
5053
5054 * buffer.c (Fget_file_buffer): Protect against invalid file
5055 handler return value.
5056
310f5bd4
PE
50572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5058
cb3a28cc
PE
5059 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5060 when computing $valmask.
5061
310f5bd4
PE
5062 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5063 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5064 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5065 It's useless in that case, and it can cause problems on hosts
5066 that allocate halves of EMACS_INT values separately.
5067 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5068 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5069 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5070 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5071 it avoids undefined behavior on hosts where shifting right by more
5072 than the word width has undefined behavior.
5073
2375c96a
CY
50742012-02-19 Chong Yidong <cyd@gnu.org>
5075
5076 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5077 (Funhandled_file_name_directory, Ffile_name_as_directory)
5078 (Fdirectory_file_name, Fexpand_file_name)
5079 (Fsubstitute_in_file_name): Protect against invalid file handler
5080 return values (Bug#10845).
5081
3eb49e71
EZ
50822012-02-18 Eli Zaretskii <eliz@gnu.org>
5083
5084 * .gdbinit (pitx): Fix incorrect references to fields of the
5085 iterator stack.
5086
7b926f3f
CY
50872012-02-17 Chong Yidong <cyd@gnu.org>
5088
5089 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5090
11273115
PE
50912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5094 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5095
c3a70e2b
CY
50962012-02-15 Chong Yidong <cyd@gnu.org>
5097
5098 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5099 marked as special. Also, starting docstrings with * is obsolete.
5100
0ca43699
AS
51012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5102
5103 * gnutls.c (emacs_gnutls_write): Fix last change.
5104
2e8f3c56
LI
51052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5106
5107 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5108 send_process.
5109
af70074f
SM
51102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5111
5112 * keymap.c (Fsingle_key_description): Handle char ranges.
5113
95986d52
CY
51142012-02-12 Chong Yidong <cyd@gnu.org>
5115
afd83bd1
CY
5116 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5117 as that creates a dangerous corner case.
5118
95986d52
CY
5119 * window.c (Fdelete_window_internal): Invalidate the mouse
5120 highlight (Bug#9904).
5121
bd7da63e
GM
51222012-02-12 Glenn Morris <rgm@gnu.org>
5123
5124 * xselect.c (Fx_own_selection_internal)
5125 (Fx_get_selection_internal, Fx_disown_selection_internal)
5126 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5127 * nsselect.m (Fx_own_selection_internal)
5128 (Fx_disown_selection_internal, Fx_selection_exists_p)
5129 (Fx_selection_owner_p, Fx_get_selection_internal):
5130 Sync docs and argument specs with the xselect.c versions.
5131
77abcbc2
LI
51322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5133
5134 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5135
90b671e2
EZ
51362012-02-11 Eli Zaretskii <eliz@gnu.org>
5137
1c0ca0b7
EZ
5138 * w32select.c (Fx_selection_exists_p): Sync doc string and
5139 argument list with xselect.c. (Bug#10783)
5140
5141 * w16select.c (Fx_selection_exists_p): Sync doc string and
5142 argument list with xselect.c. (Bug#10783)
90b671e2 5143
49241268
GM
51442012-02-10 Glenn Morris <rgm@gnu.org>
5145
5146 * fns.c (Fsecure_hash): Doc fix.
5147
f998bbe7 51482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5149
5150 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5151
0992bd9c
CY
51522012-02-07 Chong Yidong <cyd@gnu.org>
5153
5154 * buffer.c (Fbuffer_local_variables)
5155 (buffer_lisp_local_variables): Handle unbound vars correctly;
5156 don't let Qunbound leak into Lisp.
5157
af008560
GM
51582012-02-07 Glenn Morris <rgm@gnu.org>
5159
dd605cc4
GM
5160 * image.c (Fimagemagick_types): Doc fix.
5161
af008560
GM
5162 * image.c (imagemagick-render-type): Change it from a lisp object
5163 to an integer. Move the doc here from the lisp manual.
5164 Treat all values not equal to 0 the same.
5165
1449fa1d
CY
51662012-02-06 Chong Yidong <cyd@gnu.org>
5167
5168 * doc.c (store_function_docstring): Avoid applying docstring of
5169 alias to base function (Bug#2603).
5170
3723ec07
AS
51712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5172
5173 * .gdbinit (pp1, pv1): Remove redundant defines.
5174 (pr): Use pp.
5175
79c1cc1e
CY
51762012-02-04 Chong Yidong <cyd@gnu.org>
5177
5178 * nsterm.m: Declare a global (Bug#10694).
5179
d7f29f8e
EZ
51802012-02-04 Eli Zaretskii <eliz@gnu.org>
5181
cae07000
SM
5182 * w32.c (get_emacs_configuration_options):
5183 Include --enable-checking, if specified, in the return value.
d7f29f8e 5184
3b95a6f9
MR
51852012-02-04 Martin Rudalics <rudalics@gmx.at>
5186
5187 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5188 after rounding frame sizes. (Bug#9723)
5189
d6fa96a6
EZ
51902012-02-04 Eli Zaretskii <eliz@gnu.org>
5191
5192 * keyboard.c (adjust_point_for_property): Don't position point
5193 before BEGV. (Bug#10696)
5194
df0b2940
PE
51952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 Handle overflow when computing char display width (Bug#9496).
5198 * character.c (char_width): Return EMACS_INT, not int.
5199 (char_width, c_string_width): Check for overflow when
5200 computing the width; this is possible now that individual
5201 characters can have unbounded width. Problem introduced
5202 by merge from Emacs 23 on 2012-01-19.
5203
6bee44d6
MA
52042012-02-02 Michael Albinus <michael.albinus@gmx.de>
5205
5206 * dbusbind.c (Fdbus_register_method): Mention the return value
5207 :ignore in the docstring.
5208
44f92739
GM
52092012-02-02 Glenn Morris <rgm@gnu.org>
5210
1b9f60cc
GM
5211 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5212
44f92739
GM
5213 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5214 Unconditionally set to t. (Bug#10673)
5215 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5216 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5217 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5218
c5d3843c
KH
52192012-02-02 Kenichi Handa <handa@m17n.org>
5220
5221 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5222 0, do not call append_composite_glyph.
5223
159462d4 52242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5225
5226 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5227 NULL (Bug#6988).
5228 (x_produce_glyphs): If the component of a composition is a null
5229 string, set it->pixel_width to 1 to avoid zero-width glyph.
5230
78cef877
EZ
52312012-02-01 Eli Zaretskii <eliz@gnu.org>
5232
5233 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5234 first 2 arguments are identical. This makes inserting large
5235 output from a subprocess an order of magnitude faster on
5236 MS-Windows, where all sbrk'ed memory is always contiguous.
5237
97897668
GM
52382012-01-31 Glenn Morris <rgm@gnu.org>
5239
5240 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5241 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5242 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5243
31fd3586
GM
52442012-01-29 Glenn Morris <rgm@gnu.org>
5245
5246 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5247
0e24a8b2
CY
52482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5249
5250 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5251
cc0adcb0
CY
52522012-01-28 Chong Yidong <cyd@gnu.org>
5253
5254 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5255
acc28cb9
CY
52562012-01-26 Chong Yidong <cyd@gnu.org>
5257
9c69cfb7
CY
5258 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5259
acc28cb9
CY
5260 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5261 repeat counts (Bug#10507).
5262
48da7392
GM
52632012-01-26 Glenn Morris <rgm@gnu.org>
5264
5265 * lread.c (syms_of_lread): Doc fix.
5266
14af5f7f
CY
52672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5268
5269 * coding.c (encode_designation_at_bol): Change return value to
5270 EMACS_INT.
5271
0b21c100
CY
52722012-01-25 Chong Yidong <cyd@gnu.org>
5273
5274 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5275
3c2907f7
CY
52762012-01-21 Chong Yidong <cyd@gnu.org>
5277
5278 * floatfns.c (Fcopysign): Make the second argument non-optional,
5279 since nil is not allowed anyway.
5280
959ad23f
AS
52812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5282
5283 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5284 (send_process): Likewise.
5285
34a02f46
MR
52862012-01-19 Martin Rudalics <rudalics@gmx.at>
5287
5288 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5289 (Vwindow_persistent_parameters): Do not use Qstate.
5290 Rewrite doc-strings.
34a02f46 5291
1259009a 52922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5293
5294 * character.c (char_width): New function.
70d4fdf6
GM
5295 (Fchar_width, c_string_width, lisp_string_width):
5296 Use char_width (Bug#9496).
25ed9e61 5297
6a6ee00d
MR
52982012-01-16 Martin Rudalics <rudalics@gmx.at>
5299
5300 * window.c (Vwindow_persistent_parameters): New variable.
5301 (Fset_window_configuration, save_window_save): Handle persistent
5302 window parameters.
5303
c85efaf7
EZ
53042012-01-14 Eli Zaretskii <eliz@gnu.org>
5305
5306 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5307 thrashing the stack of the thread. (Bug#9087)
5308
5944709e
PE
53092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5312
e71f5d99
EZ
53132012-01-11 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (rows_from_pos_range): Handle the case where the
5316 highlight ends on a newline. (Bug#10464)
5317 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5318 he end column for display of highlight that ends on a newline
5319 before a R2L line.
5320
ce316182
GM
53212012-01-11 Glenn Morris <rgm@gnu.org>
5322
5323 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5324 from load-path also when installation-directory is nil. (Bug#10208)
5325
5b43da69
GM
53262012-01-10 Glenn Morris <rgm@gnu.org>
5327
74cc8ff9
GM
5328 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5329
7d8d6e4e
GM
5330 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5331 Update template values to be closer to their typical values these days.
5b43da69 5332
a0db8d43
EZ
53332012-01-09 Eli Zaretskii <eliz@gnu.org>
5334
5335 * xdisp.c (rows_from_pos_range): Accept additional argument
5336 DISP_STRING, and accept any glyph in a row whose object is that
5337 string as eligible for mouse highlight. Fixes mouse highlight of
5338 display strings from overlays. (Bug#10464)
5339
9a0115ab 53402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5341
b9110d6a 5342 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5343 * fileio.c (auto_saving_dir_umask): New static var.
5344 (Fmake_directory_internal): Use it.
5345 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5346 creating the directory. The old code temporarily assigns
5347 too-generous permissions to the directory.
5348 (do_auto_save_eh): Clear it.
b9110d6a 5349 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5350 that the var is always cleared.
5351
6c1bd3f3
EZ
53522012-01-07 Eli Zaretskii <eliz@gnu.org>
5353
5354 * search.c (scan_buffer): Pass character positions to
5355 know_region_cache, not byte positions. (Bug#6540)
5356
069d2b50
L
53572012-01-07 LynX <_LynX@bk.ru> (tiny change)
5358
5359 * w32.c (sys_rename): Report EXDEV when rename of a directory
5360 fails because the target is on another logical disk. (Bug#10284)
5361
75bf0d33
DB
53622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5363
5364 * xterm.c (x_embed_request_focus): New function.
5365
5366 * xterm.h: Add prototype.
5367
5368 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5369
1c6e5a32
GM
53702012-01-05 Glenn Morris <rgm@gnu.org>
5371
5372 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5373
651e947e
EZ
53742012-01-01 Eli Zaretskii <eliz@gnu.org>
5375
5376 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5377 Load gnutls_transport_set_lowat only if GnuTLS version is below
5378 2.11.1.
5379 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5380 GnuTLS versions below 2.11.1.
5381
3778cdd8
AL
53822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5383
5384 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5385 to the doc string advising against its use for altering the way
5386 windows are scrolled.
5387
0e5317f7
KH
53882011-12-28 Kenichi Handa <handa@m17n.org>
5389
5390 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5391 coding-system ASCII compatible only when it does not produce BOM
5392 on encoding (Bug#10383).
5393
93d5ca1f
JD
53942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5395
5396 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5397 can scroll.
5398 (create_and_show_popup_menu): Always use menu_position_func for
5399 Gtk3 (Bug#10361).
5400
ca22b785
AS
54012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5402
5403 * callint.c (Fcall_interactively): Don't truncate prompt string.
5404
d048e1e6
EZ
54052011-12-23 Eli Zaretskii <eliz@gnu.org>
5406
5407 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5408 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5409 resumed from there (after widening). (Bug#10360)
d048e1e6 5410
5ccaba1f
JD
54112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5412
5413 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5414
204ee57f
JD
54152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5416
b81d40f0
JB
5417 * nsterm.m (x_free_frame_resources):
5418 Release f->output_data.ns->miniimage.
204ee57f
JD
5419 (ns_index_color): Fix indentation. Do not retain
5420 color_table->colors[i].
5421
5422 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5423 before returning.
5424
5425 * nsfns.m (x_set_background_color): Assign return value from
5426 ns_index_color to face-background instead of NSColor*.
5427 (ns_implicitly_set_icon_type): Fix indentation.
5428 Change assignment in for loop to comparison.
5429
5430 * emacs.c (ns_pool): New variable.
5431 (main): Assign ns_pool.
5432 (Fkill_emacs): Call ns_release_autorelease_pool.
5433
5434 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5435 autorelease fdesc, release fdAttrs and tdict.
5436 (ns_get_covering_families): Release charset.
5437 (ns_findfonts): Release NSFontDescriptor created with new.
5438 (ns_uni_to_glyphs): Fix indentation.
5439 (setString): Release attrStr before assigning new value.
5440
c803b2b7
JD
54412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5442
678f4426
JD
5443 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5444 and NS_IMPL_COCOA.
5445 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5446 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5447
cd394be1 54482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5449
5fecd5fc
JD
5450 * nsterm.m (ns_term_init): Subscribe for notifications
5451 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5452 to method trackingNotification in EmacsMenu.
5453
5454 * nsmenu.m (trackingMenu): New variable.
3771cb17 5455 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5456 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5457 from Aquamacs (Bug#7030).
678f4426
JD
5458
54592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5460
c803b2b7
JD
5461 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5462 (symbol_to_nsstring): Fix indentation.
5463 (ns_symbol_to_pb): New function.
cae07000
SM
5464 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5465 (Fns_rotate_cut_buffers_internal): Remove.
5466 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5467 Fns_store_cut_buffer_internal.
5468 (ns_get_foreign_selection, Fx_own_selection_internal)
5469 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5470 (Fns_get_selection_internal, Fns_store_selection_internal):
5471 Use ns_symbol_to_pb and check if return value is nil.
5472 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5473 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5474 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5475 renamed to Sns_store_selection_internal.
5476 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5477 and remove this function.
5478 (ns_handle_selection_clear): Remove, never used.
5479 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5480 here.
5481
e1b01a3a
KB
54822011-12-17 Ken Brown <kbrown@cornell.edu>
5483
5484 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5485 GID is unknown (Bug#10257).
5486
2adb6e85
PE
54872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5488
5489 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5490 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5491 which caused a build failure on GNU/Linux IA-64. This problem was
5492 introduced by my 2011-10-07 patch.
5493
d1d7b339
JL
54942011-12-15 Juri Linkov <juri@jurta.org>
5495
5496 * image.c (imagemagick_error): New function. (Bug#10112)
5497 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5498 Use `imagemagick_error' where ImageMagick functions return
5499 `MagickFalse'.
5500 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5501 proper order.
5502
100d5755
KH
55032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5504
5505 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5506 fill background (Bug#8992).
5507
454592a6
MR
55082011-12-13 Martin Rudalics <rudalics@gmx.at>
5509
5510 * window.c (Vwindow_combination_resize)
5511 (Vwindow_combination_limit): Use t instead of non-nil in
5512 doc-strings.
61d4b438
MR
5513 (Vrecenter_redisplay): Add first sentence of doc-string on
5514 separate line.
53524d93 5515 (Frecenter): Fix doc-string typo.
454592a6 5516
3633e3aa
KH
55172011-12-11 Kenichi Handa <handa@m17n.org>
5518
5519 * coding.c (Funencodable_char_position): Pay attention to the
5520 buffer text relocation (Bug#9389).
5521
7b9d523a 55222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5523
7b9d523a
JD
5524 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5525 gtk_init (Bug#10100).
5526
b73189c6
EZ
55272011-12-10 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5530 IT->string is nil. (Bug#10263)
5531
f7dfe5d6
JD
55322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5533
83faebb4
JD
5534 * nsterm.h (x_free_frame_resources): Declare.
5535
f7dfe5d6
JD
5536 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5537 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5538
5539 * nsterm.h (ns_get_defaults_value): Declare.
5540
5541 * nsterm.m (ns_default): Call ns_get_defaults_value.
5542
7cd4e72c
EZ
55432011-12-09 Eli Zaretskii <eliz@gnu.org>
5544
5545 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5546 (Bug#10170)
5547
b34d7317
YM
55482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5549
5550 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5551 that where the value of an _OBJC_* symbol points to is in the .bss
5552 section (Bug#10240).
5553
76470ad1
KH
55542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5555
5556 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5557 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5558
745fff94
KH
55592011-12-08 Kenichi Handa <handa@m17n.org>
5560
5561 * ftfont.c (get_adstyle_property): Fix previous change
5562 (Bug#10233).
5563
6e44397c
JB
55642011-12-07 Juanma Barranquero <lekktu@gmail.com>
5565
5566 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5567 dirs from the default value of EMACSLOADPATH (bug#10208).
5568
7efa6272
GM
55692011-12-07 Glenn Morris <rgm@gnu.org>
5570
5571 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5572 installation and source directories as well. (Bug#10208)
5573
f6fc4d87
CY
55742011-12-06 Chong Yidong <cyd@gnu.org>
5575
5576 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5577
2bf26180
GM
55782011-12-06 Glenn Morris <rgm@gnu.org>
5579
5580 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5581 as an error, not just -1. (Bug#10217)
5582
3a6ad4f0
CY
55832011-12-05 Chong Yidong <cyd@gnu.org>
5584
5585 * keyboard.c (process_special_events): New function.
5586 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5587
75a3b399
PE
55882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5589
5590 * coding.c (encode_designation_at_bol): Don't use uninitialized
5591 local variable (Bug#9318).
5592
c3c9e25e
KH
55932011-12-05 Kenichi Handa <handa@m17n.org>
5594
5595 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5596 return Qnil (Bug#8046, Bug#10193).
5597
5eb05ea3
KH
55982011-12-05 Kenichi Handa <handa@m17n.org>
5599
5600 * coding.c (encode_designation_at_bol): New args charbuf_end and
5601 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5602 (coding_set_source): Return how many bytes coding->source was
5603 relocated.
5604 (coding_set_destination): Return how many bytes
5605 coding->destination was relocated.
5606 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5607 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5608
56092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5610
5611 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5612 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5613 macro (Bug#9318).
5614
56152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5616
5617 The following changes are to fix Bug#9318.
5618
a79703f5 5619 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5620 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5621 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5622 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5623
7dbda6df
JB
56242011-12-05 Juanma Barranquero <lekktu@gmail.com>
5625
5626 * lisp.h (process_quit_flag): Fix external declaration.
5627
6d5eb5b0
SM
56282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5629
5630 Don't macro-inline non-performance-critical code.
5631 * eval.c (process_quit_flag): New function.
5632 * lisp.h (QUIT): Use it.
5633
a0c3fad0
JD
56342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5635
5636 * nsfns.m (get_geometry_from_preferences): New function.
5637 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5638
6c07aac2
AS
56392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5640
5641 * emacs.c (Qkill_emacs): Define.
5642 (syms_of_emacs): Initialize it.
5643 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5644 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5645 (quit_throw_to_read_char): Add parameter `from_signal'.
5646 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5647 * lisp.h (QUIT): Call Fkill_emacs if requested.
5648
c052ead4
JD
56492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5650
5651 * widget.c (update_wm_hints): Return if wmshell is null.
5652 (widget_update_wm_size_hints): New function.
5653
5654 * widget.h (widget_update_wm_size_hints): Declare.
5655
5656 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5657 widget_update_wm_size_hints (Bug#10104).
5658
9e49252b
EZ
56592011-12-03 Eli Zaretskii <eliz@gnu.org>
5660
5661 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5662 before a newline, prepare the bidi iterator for consuming the
5663 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5664 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5665
02b16839
JL
56662011-12-02 Juri Linkov <juri@jurta.org>
5667
5668 * search.c (Fword_search_regexp): New Lisp function created from
5669 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5670 (Fword_search_backward, Fword_search_forward)
5671 (Fword_search_backward_lax, Fword_search_forward_lax):
5672 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5673 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5674
0068070e
SM
56752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5676
5677 * fileio.c (Finsert_file_contents): Move after-change-function call
5678 to before the "handled:" label, since all "goto handled" appear in
5679 cases where the *-change-functions have already been properly called
5680 (bug#10117).
5681
3360a3fc
AS
56822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5683
5684 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5685 waiting for input. (Bug#10169)
5686
73d6c093
EZ
56872011-11-30 Eli Zaretskii <eliz@gnu.org>
5688
5689 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5690 verifies glyph row's hash code--we have just reallocated the
5691 glyphs, so their contents can be complete garbage. (Bug#10164)
5692
febe6bea
JB
56932011-11-30 Juanma Barranquero <lekktu@gmail.com>
5694
5695 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5696
801a4313
EZ
56972011-11-30 Eli Zaretskii <eliz@gnu.org>
5698
5699 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5700 attributes are tested _before_ calling verify_row_hash, to protect
5701 against GCC re-ordering of the tests. (Bug#10164)
5702
2b56b87e
JD
57032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5704
5705 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5706
5707 * xterm.c (handle_one_xevent): Only set async_visible and friends
5708 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5709 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5710 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5711
dbf31225
PE
57122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5713
5714 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5715 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5716 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5717 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5718 All uses changed to use GCPRO1 etc.
5719 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5720 Revert to old implementation (i.e., before 2011-03-11).
5721
1305621b
YM
57222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5723
5724 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5725 of scroll runs so as to avoid assigning disabled bogus rows and
5726 unnecessary graphics copy operations.
5727
8c9afb46
EZ
57282011-11-27 Eli Zaretskii <eliz@gnu.org>
5729
5730 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5731 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5732 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5733 (malloc, free, realloc, calloc): Redirect to e_* only when
5734 compiling Emacs.
5735
5736 * lisp.h (GCTYPEBITS): Move before first use.
5737 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5738 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5739 this macro definition.
5740
5741 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5742 _MSC_VER.
5743
54e9e3bf
JD
57442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5745
6d5eb5b0
SM
5746 * gtkutil.c (xg_create_frame_widgets):
5747 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5748 present with Gtk+ 2.0.
5749
83aca1cb
PE
57502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 * fileio.c (Finsert_file_contents): Undo previous change; see
5753 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5754
5b76caa4
PE
57552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5756
5757 Rename locals to avoid shadowing.
5758 * fileio.c (Finsert_file_contents):
5759 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5760 * process.c (wait_reading_process_output):
5761 Rename inner 'proc' to 'p' to avoid shadowing.
5762 Indent for consistency with usual Emacs style.
5763
8c535114
EZ
57642011-11-25 Eli Zaretskii <eliz@gnu.org>
5765
5766 * xdisp.c (redisplay_window): If cursor row is not fully visible
5767 after recentering, and scroll-conservatively is set to a large
5768 number, scroll window by a few more lines to make the cursor fully
5769 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5770 (start_display): Don't move to the next line if the display should
5771 start at a newline that is part of a display vector or an overlay
5772 string. (Bug#10119)
8c535114 5773
fa4fdb5c
JL
57742011-11-24 Juri Linkov <juri@jurta.org>
5775
5776 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5777 after the `MagickPingImage' call. (Bug#10112)
5778
90ec88df
CY
57792011-11-23 Chong Yidong <cyd@gnu.org>
5780
5781 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5782
56e2e794
MR
57832011-11-23 Martin Rudalics <rudalics@gmx.at>
5784
5785 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5786 making another buffer current. (Bug#10114)
5787
b6e64c41
GM
57882011-11-23 Glenn Morris <rgm@gnu.org>
5789
5790 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5791
6b21de18
CY
57922011-11-23 Chong Yidong <cyd@gnu.org>
5793
5794 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5795 using it (Bug#5984).
5796
b12cd789
EZ
57972011-11-22 Eli Zaretskii <eliz@gnu.org>
5798
5799 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5800 and header-lines, as they don't have one computed for them.
5801 (Bug#10098)
5802
5803 * .gdbinit (prow): Make displayed values more self-explaining.
5804 Add row's hash code.
5805
261b6fd4
LMI
58062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5807
5808 * process.c (wait_reading_process_output): Fix asynchrounous
5809 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5810 (wait_reading_process_output): Add comment and URL.
261b6fd4 5811
e7cfd277
JD
58122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5813
5814 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5815
a9b9b7f5
CY
58162011-11-21 Chong Yidong <cyd@gnu.org>
5817
5818 * window.c (Fnext_window, Fprevious_window): Doc fix.
5819
b0d15b4f
SM
58202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5821
5822 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5823
fe7a3057
JB
58242011-11-20 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5827
d2999b1a
MR
58282011-11-20 Martin Rudalics <rudalics@gmx.at>
5829
5830 * window.c (Fset_window_combination_limit): Rename argument
5831 STATUS to LIMIT.
5832 (Vwindow_combination_limit): Remove "status" from doc-string.
5833
d5ff9cd0
AS
58342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5835
5836 * m/ibms390.h: Remove.
5837 * m/ibms390x.h: Don't include "ibms390.h".
5838
a5bb9bd3
SM
58392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5842 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5843
cd1181db
JB
58442011-11-20 Juanma Barranquero <lekktu@gmail.com>
5845
5846 * casetab.c (Fset_case_table):
5847 * charset.c (Fcharset_after): Fix typos.
5848
615a3b8d 58492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5850
17e845af
PE
5851 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5852 Otherwise, valgrind does not work on some platforms.
5853 Problem reported by Andreas Schwab in
6a0bf43d
PE
5854 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5855 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5856 is set, removing the need for VIRT_ADDRESS_VARIES.
5857 (PURE_P): Use a more-efficient implementation that needs just one
5858 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5859 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5860 to 4 (xorl, subq, cmpq, setbe).
5861 * alloc.c (pure): Always extern now, since that's the
5862 VIRT_ADDR_VARIES behavior.
5863 (PURE_POINTER_P): Use a single comparison, not two, for
5864 consistency with the new puresize.h.
5865 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5866 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5867 Remove VIRT_ADDR_VARIES no longer needed.
5868
f8fe6f96
EZ
58692011-11-19 Eli Zaretskii <eliz@gnu.org>
5870
5871 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5872 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5873 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5874 behave as if the cursor position were at the window margin.
5875
5876 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5877 and the cursor position is out of bounds, behave as if the cursor
5878 position were at the window margin. (Bug#10075)
5879
df05a53c
CY
58802011-11-18 Chong Yidong <cyd@gnu.org>
5881
5882 * window.c (Fwindow_combination_limit): Make first argument
5883 non-optional, since it is meaningless for live windows like the
5884 selected window.
61ccba97 5885
2071918e
DA
58862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5887
5888 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5889
b50a28de
SM
58902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5891
5892 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5893 (graft_intervals_into_buffer): Simplify.
5894
015137db
EZ
58952011-11-18 Eli Zaretskii <eliz@gnu.org>
5896
5897 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5898 hash values of the two rows.
5899 (copy_row_except_pointers): Preserve the used[] arrays and the
5900 hash values of the two rows. (Bug#10035)
68c95424 5901 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5902
5903 * xdisp.c (row_hash): New function, body extracted from
5904 compute_line_metrics.
5905 (compute_line_metrics): Call row_hash, instead of computing the
5906 hash code inline.
5907
5908 * dispnew.c (verify_row_hash): Call row_hash for computing the
5909 hash code of a row, instead of duplicating code from xdisp.c.
5910
5911 * dispextern.h (row_hash): Add prototype.
5912
a2addb04
TH
59132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5914
5915 * frame.c (delete_frame): Don't delete the terminal when the last
5916 X frame is closed if emacs is built with GTK toolkit.
5917
df85d315
JB
59182011-11-17 Juanma Barranquero <lekktu@gmail.com>
5919
5920 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5921
a0c2d0ae
MR
59222011-11-17 Martin Rudalics <rudalics@gmx.at>
5923
5924 * window.c (Vwindow_splits): Rename to
5925 Vwindow_combination_resize. Suggested by Juri Linkov.
5926 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5927 of Vwindow_splits.
5928
58179cce
JB
59292011-11-16 Juanma Barranquero <lekktu@gmail.com>
5930
7877f373
JB
5931 * nsfns.m (Fns_font_name):
5932 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5933
b6f67890
MR
59342011-11-16 Martin Rudalics <rudalics@gmx.at>
5935
5936 * window.h (window): Rename slot "nest" to "combination_limit".
5937 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5938 (Fset_window_nest): Rename to Fset_window_combination_limit.
5939 (Vwindow_nest): Rename to Vwindow_combination_limit.
5940 (recombine_windows, make_parent_window, make_window)
5941 (Fsplit_window_internal, saved_window)
5942 (Fset_window_configuration, save_window_save): Rename all
5943 occurrences of window_nest to window_combination_limit.
5944
c7015153
JB
59452011-11-15 Juanma Barranquero <lekktu@gmail.com>
5946
5947 * image.c (imagemagick_load_image): Fix typo.
5948
322ad6ec
EZ
59492011-11-14 Eli Zaretskii <eliz@gnu.org>
5950
5951 * xdisp.c (display_line): Move the call to
5952 highlight_trailing_whitespace before the call to
5953 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5954 faces of all the glyphs to compute ROW's hash value.
5955 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5956
f067b8ec
JB
59572011-11-14 Juanma Barranquero <lekktu@gmail.com>
5958
5959 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5960 just return (bug#10044).
5961
1e5b2111
EZ
59622011-11-12 Eli Zaretskii <eliz@gnu.org>
5963
7ef3cbd5
EZ
5964 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5965 with user-defined heap size. Bump the default size of the temacs
5966 heap to 27MB, to avoid memory warning when running temacs.
5967 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5968
1e5b2111
EZ
5969 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5970 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5971 (verify_row_hash) [XASSERTS]: New function.
5972 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5973 that the hash value of glyph rows is correct.
1e5b2111 5974
89d61221
MR
59752011-11-12 Martin Rudalics <rudalics@gmx.at>
5976
5977 * window.h (window): Remove splits slot.
5978 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5979 (Fdelete_other_windows_internal, make_parent_window)
5980 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5981 (Fset_window_configuration, save_window_save): Don't deal with
5982 split status of windows.
5983 (saved_window): Remove splits slot.
5984 (Vwindow_splits): Rewrite doc-string.
5985
97f18cc8
JD
59862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5987
5988 * xfns.c (unwind_create_frame):
5989 * nsfns.m (unwind_create_frame):
5990 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5991 Vframe_list (Bug#9999).
5992
22a648b4
DA
59932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5994
0b381c7e 5995 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5996
659afede
KH
59972011-11-11 Kenichi Handa <handa@m17n.org>
5998
5999 * callproc.c (Fcall_process): Set the member dst_multibyte of
6000 process_coding.
6001
9ac0394b
KH
60022011-11-11 Johan Bockgård <bojohan@gnu.org>
6003
6004 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6005 avoid a crash (bug#9496).
6006
2fbdc249
CY
60072011-11-09 Chong Yidong <cyd@gnu.org>
6008
6009 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6010 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6011
ac6b1f81
PE
60122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6013
6014 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6015
09db192c
PE
60162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6017
6018 Avoid some portability problems by eschewing 'extern inline' functions.
6019 The trivial performance wins aren't worth the portability hassles; see
6020 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6021 et seq.
6022 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6023 (window_box_width, window_box_left, window_box_left_offset)
6024 (window_box_right, window_box_right_offset): Undo previous change,
6025 by removing the "extern"s.
6026 * intervals.c (adjust_intervals_for_insertion)
6027 (adjust_intervals_for_deletion): Undo previous change,
6028 making these static again.
6029 (offset_intervals, temp_set_point_both, temp_set_point)
6030 (copy_intervals_to_string): No longer inline.
6031 * xdisp.c (window_text_bottom_y, window_box_width)
6032 (window_box_height, window_box_left_offset)
6033 (window_box_right_offset, window_box_left, window_box_right)
6034 (window_box): No longer inline.
6035
105216ed
CY
60362011-11-08 Chong Yidong <cyd@gnu.org>
6037
6038 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6039 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6040 Signal an error if not a live window.
105216ed
CY
6041 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6042 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6043
ae9e237f
JB
60442011-11-07 Juanma Barranquero <lekktu@gmail.com>
6045
6046 * lisp.h (syms_of_abbrev): Remove declaration.
6047 Reported by CHENG Gao <chenggao@royau.me>.
6048
c7aa8333
EZ
60492011-11-07 Eli Zaretskii <eliz@gnu.org>
6050
6051 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6052 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6053 of temacs in GUI mode.
6054
be7f5545
MR
60552011-11-07 Martin Rudalics <rudalics@gmx.at>
6056
6057 * window.h: Declare delete_all_child_windows instead of
6058 delete_all_subwindows.
6059 * window.c (Fwindow_nest, Fset_window_nest)
6060 (Fset_window_new_total, Fset_window_new_normal)
6061 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6062 (delete_all_subwindows): Rename to delete_all_child_windows.
6063 (Fdelete_other_windows_internal, Fset_window_configuration):
6064 Call delete_all_child_windows instead of delete_all_subwindows.
6065 * frame.c (delete_frame): Call delete_all_child_windows instead
6066 of delete_all_subwindows.
6067
ca78dc43
PE
60682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6069
6070 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6071 This is also needed for porting to any host where GC_MARK_STACK is
6072 not GC_MAKE_GCPROS_NOOPS.
6073 (which_symbols): Use it.
6074
a0241d01
KH
60752011-11-07 Kenichi Handa <handa@m17n.org>
6076
6077 * coding.c (coding_set_destination): Check coding->src_pos only
6078 when coding->src_object is a buffer (bug#9910).
6079
6080 * process.c (send_process): Set the member src_multibyte of coding
6081 to 0 (bug#9911) when sending a unibyte text.
6082
6083 * callproc.c (Fcall_process): Set the member src_multibyte of
6084 process_coding to 0 (bug#9912).
6085
a64bfdfa 60862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6087
6088 * xmenu.c (cleanup_widget_value_tree): New function.
6089 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6090 calling free_menubar_widget_value_tree directly (Bug#9830).
6091
cb41b32a
PE
60922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6093
6094 Fix some portability problems with 'inline'.
6095 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6096 (window_box_width, window_box_left, window_box_left_offset)
6097 (window_box_right, window_box_right_offset): Declare extern.
6098 Otherwise, these inline functions do not conform to C99 and
6099 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6100 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6101 * intervals.c (adjust_intervals_for_insertion)
6102 (adjust_intervals_for_deletion): Now extern, because otherwise the
6103 extern inline functions 'offset_intervals' couldn't refer to it.
6104 (static_offset_intervals): Remove.
6105 (offset_intervals): Rewrite using the old contents of
6106 static_offset_intervals. The old version didn't conform to C99
6107 because an extern inline function contained a reference to an
6108 identifier with static linkage.
6109
b7041366
AS
61102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6111
6112 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6113 GC.
6114
88a37c4d
EZ
61152011-11-06 Eli Zaretskii <eliz@gnu.org>
6116
6117 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6118 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6119 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6120 return Qleft_to_right.
6121
49745b39
CY
61222011-11-06 Chong Yidong <cyd@gnu.org>
6123
6124 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6125 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6126 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6127 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6128 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6129 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6130 (Fwindow_vscroll): Doc fix.
6131 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6132 argument, since it makes no sense to pass a live window and for
6133 consistency with window-child.
6134
1f05cd82
CS
61352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6136
6137 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6138 support MSVC.
6139
22610910
JR
61402011-11-05 Jason Rumney <jasonr@gnu.org>
6141
6142 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6143 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6144 fonts (Bug#6029).
6145 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6146 bitwise arithmetic preventing use of unicode-sip and non-truetype
6147 opentype fonts.
6148
a06776b2
EZ
61492011-11-05 Eli Zaretskii <eliz@gnu.org>
6150
3ad924ba
EZ
6151 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6152 "emacs"-only part.
6153
a06776b2
EZ
6154 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6155 initialization code to keep similarity to xfns.c after changes
6156 from 2011-11-05.
6157
c9e7db78
JD
61582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6159
a97f8f3f
JD
6160 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6161 (unwind_create_frame): New function (Bug#9943).
6162 (Fx_create_frame): Restructure code to be more similar to the one in
6163 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6164 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6165 Move terminal->reference_count++ just before making the frame official
6166 (Bug#9943).
6167
6168 * nsterm.m (x_free_frame_resources): New function.
6169 (x_destroy_window): Move code to x_free_frame_resources.
6170
c9e7db78 6171 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6172 (Fx_create_frame, x_create_tip_frame):
6173 Move terminal->reference_count++ just before making the frame
75f1671a 6174 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6175 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6176
a6fc3b5c
EZ
61772011-11-05 Eli Zaretskii <eliz@gnu.org>
6178
6179 Support MSVC build with newer versions of Visual Studio.
6180 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6181 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6182 nt/gmake.defs.
6183
6184 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6185 which are not supported by MSVC.
6186 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6187 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6188 bitfields.
6189 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6190 types in bitfields.
6191 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6192
6193 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6194
58179cce 61952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6196
6197 Support MSVC build with newer versions of Visual Studio.
6198 * w32.c: Don't include w32api.h for MSVC.
6199 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6200
6201 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6202 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6203 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6204 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6205 e_* cousins.
6206 (alloca) [_MSC_VER]: Define to _alloca.
6207
6208 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6209
6210 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6211
a58c13ed
EZ
62122011-11-04 Eli Zaretskii <eliz@gnu.org>
6213
6214 * xdisp.c (note_mouse_highlight): If either of
6215 previous/next-single-property-change returns nil, treat that as
6216 the beginning or the end of the buffer. (Bug#9955)
6217
fe0b6370
JD
62182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6219
a58c13ed 6220 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6221 label is not null (Bug#9951).
6222 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6223 may be NULL.
6224
89bd5ee1
EZ
62252011-11-04 Eli Zaretskii <eliz@gnu.org>
6226
6227 * window.c (Fwindow_body_size): Mention in the doc string that the
6228 return value is in frame's canonical units. (Bug#9949)
6229
84c3edb9
EZ
62302011-11-03 Eli Zaretskii <eliz@gnu.org>
6231
4e2fb5c7
EZ
6232 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6233
84c3edb9 6234 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6235 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6236 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6237
bc17a887
EZ
62382011-11-01 Eli Zaretskii <eliz@gnu.org>
6239
6240 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6241 Don't stop backward scan on the continuation glyph, even though
6242 its CHARPOS is positive.
6d5eb5b0
SM
6243 (mouse_face_from_buffer_pos, note_mouse_highlight):
6244 Rename cover_string to disp_string.
bc17a887 6245
4ee88440
MR
62462011-11-01 Martin Rudalics <rudalics@gmx.at>
6247
6248 * window.c (temp_output_buffer_show): Don't use
6249 Vtemp_buffer_show_specifiers.
6250 (Vtemp_buffer_show_specifiers): Remove unused variable.
6251
c2ff3c02
EZ
62522011-10-30 Eli Zaretskii <eliz@gnu.org>
6253
6254 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6255 past the beginning of the current glyph matrix.
6256
58179cce 62572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6258
6259 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6260 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6261 HAVE_GTK3 (Bug#9869).
b77a6a7f 6262
3b574623
JD
6263 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6264 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6265
b77a6a7f
JD
6266 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6267
6268 * xterm.c: Declare x_handle_net_wm_state to return int.
6269 (handle_one_xevent): Check if we are iconified but don't have
6270 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6271 (get_current_wm_state): Return non-zero if not hidden,
6272 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6273 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6274 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6275 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6276
196e41e4
PE
62772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6280 so that this new function doesn't get optimized away by a
6281 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6282
021f2e1a
AS
62832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6284
6285 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6286
8b058d44
EZ
62872011-10-29 Eli Zaretskii <eliz@gnu.org>
6288
6289 Fix the `xbytecode' command.
6290 * .gdbinit (xprintbytestr): New command.
b50a28de 6291 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6292 (xbytecode): Print the byte-code string as well.
6293
4452fb80
EZ
62942011-10-29 Kim Storm <storm@cua.dk>
6295
8b058d44
EZ
6296 * alloc.c (which_symbols): New function.
6297
21b72067
AS
62982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6299
6300 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6301 line. (Bug#9903)
6302
83ed7b5c
GM
63032011-10-29 Glenn Morris <rgm@gnu.org>
6304
6305 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6306 Not clear what it was for, and it causes various bugs. (Bug#9839)
6307
5a7a728b
EZ
63082011-10-28 Eli Zaretskii <eliz@gnu.org>
6309
6310 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6311 possible random value that matches one of those tested as
6312 condition to clear the mouse face.
6313
d3d0842f
CY
63142011-10-28 Chong Yidong <cyd@gnu.org>
6315
6316 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6317
31b39d13
DN
63182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6319
6320 * window.c (make_window): Initialize phys_cursor_on_p.
6321
9aba6043
SM
63222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6323
6324 * lisp.h (struct Lisp_Symbol): Update comments.
6325
c20992f4
JB
63262011-10-28 Juanma Barranquero <lekktu@gmail.com>
6327
6328 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6329
db4f02f2
EZ
63302011-10-28 Eli Zaretskii <eliz@gnu.org>
6331
6332 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6333 <oslsachem@gmail.com> for helping to debug this.
6334
6335 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6336 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6337 (g_b_init_get_glyph_outline_w): New static variables.
6338 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6339 (GetGlyphOutlineW_Proc): New typedefs.
6340 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6341 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6342 New functions.
6343 (w32font_open_internal, compute_metrics):
6344 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6345 instead of calling the "wide" APIs directly.
6346
6347 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6348
6349 * w32.h (syms_of_w32font): Add prototype.
6350
87e68db4
JB
63512011-10-27 Juanma Barranquero <lekktu@gmail.com>
6352
6353 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6354 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6355 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6356 (Fmove_to_window_line): Doc fix.
6357
435c1d67
CY
63582011-10-27 Chong Yidong <cyd@gnu.org>
6359
6360 * process.c (make_process): Set gnutls_state to NULL.
6361
6362 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6363 non-NULL, regardless of GNUTLS_INITSTAGE.
6364 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6365 an error. Set process slots as soon as we allocate them.
6366
6367 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6368
9c6c6f49
CY
63692011-10-27 Chong Yidong <cyd@gnu.org>
6370
9aba6043
SM
6371 * gnutls.c (emacs_gnutls_deinit): New function.
6372 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6373 (Fgnutls_deinit, Fgnutls_boot): Use it.
6374
6375 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6376 (deactivate_process): Call emacs_gnutls_deinit.
6377
657d08d3
JB
63782011-10-27 Juanma Barranquero <lekktu@gmail.com>
6379
6380 * image.c (x_create_x_image_and_pixmap):
6381 * w32.c (sys_rename, w32_delayed_load):
6382 * w32font.c (fill_in_logfont):
6383 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6384
5430d399
JB
63852011-10-26 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * w32fns.c (w32_default_color_map): New function,
6388 extracted from Fw32_default_color_map.
a7ef684b 6389 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6390
fe0055fa
PE
63912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6392
6393 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6394
e6346438
SM
63952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6396
6397 * keyboard.c (test_undefined): New function (bug#9751).
6398 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6399
e112cc37
ET
64002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6401
6402 * sysdep.c (init_sys_modes): Fix the check for the controlling
6403 terminal (Bug#6649).
6404
7b5d6677
EZ
64052011-10-20 Eli Zaretskii <eliz@gnu.org>
6406
6407 * dispextern.h (struct bidi_it): New member next_en_type.
6408
6409 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6410 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6411 current character, check also for next_en_type being WEAK_EN.
6412 (bidi_resolve_weak): Don't enter the expensive loop if the current
6413 position is before next_en_pos. Record the bidi type of the first
6414 non-ET, non-BN character we find, in addition to its position.
6415 (bidi_level_of_next_char): Invalidate next_en_type when
6416 next_en_pos is over-stepped.
6417
7da0b018
PE
64182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6421 * editfns.c: Rewrite current-time-zone so that it invokes
6422 the equivalent of (format-time-string "%Z") to get the time zone name.
6423 This fixes a bug when the time zone name contains characters that
6424 need converting from the system time locale to Emacs internal format.
6425 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6426 that patch fixed format-time-string to do the conversion, but
6427 I forgot to fix current-time-zone.
6428 (format_time_string): New function, containing most of
6429 what Fformat_time_string used to contain.
6430 (Fformat_time_string): Rewrite in terms of format_time_string.
6431 This doesn't change this function's behavior.
6432 (current-time-zone): Rewrite to use format_time_string.
6433 This fixes the bug reported by Michael Schierl in
6434 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6435 Jason Rumney's 2007-06-07 change worked around this bug, but
6436 didn't fix it.
6437 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6438
8547b010
EZ
64392011-10-19 Eli Zaretskii <eliz@gnu.org>
6440
6441 * xdisp.c (start_display): If the character at POS is displayed
6442 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6443 (try_window_reusing_current_matrix): If a line ends in a display
6444 vector or the next line starts in a display vector, continue
6445 redrawing the window even though the character position of
6446 start_row was reached.
8547b010
EZ
6447 (Bug#9771, part 2)
6448
4e948d15
CY
64492011-10-18 Chong Yidong <cyd@gnu.org>
6450
6451 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6452 with nobreak-char-display too.
6453
4787455f
EZ
64542011-10-18 Eli Zaretskii <eliz@gnu.org>
6455
6456 Fix part 3 of bug#9771.
6457 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6458 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6459 non-neutral characters if the current character is a paragraph
6460 separator (a.k.a. Newline). This avoids running the same
6461 expensive loop twice, once when we consume the preceding newline
6462 and the other time when the line actually needs to be displayed.
6463 Avoid the loop when we see neutrals on the base embedding level
6464 following a character whose directionality is the same as the
6465 paragraph's. This avoids running the expensive loop when a line
6466 ends in a long sequence of neutrals, like control characters.
6467 Add assertion against STRONG_AL type. Slightly rearrange code
6468 that determines the type of a neutral given the first non-neutral
6469 that follows it.
6470 (bidi_level_of_next_char): Set next_en_pos to zero when
6471 invalidating its info.
6472
2c91f553
EZ
64732011-10-17 Eli Zaretskii <eliz@gnu.org>
6474
6475 * xdisp.c (push_display_prop): Determine whether to record string
6476 or buffer position by IT->string, not by IT->method. Allow
6477 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6478 (move_it_vertically_backward): Don't look for character position
6479 immediately after the newline when in a continuation line.
6480 (Bug#9771, part 1)
2c91f553 6481
c7b08b0d
MR
64822011-10-15 Martin Rudalics <rudalics@gmx.at>
6483
6484 * window.c (coordinates_in_window): Rewrite and delabelize
6485 vertical border check. (Bug#5357) (Bug#9618)
6486
6b02f655
SM
64872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6488
6489 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6490 errors in XSetWindowBorder (bug#9310).
6491
81d40c92
DA
64922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6493
6494 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6495 avoid crash when xmalloc overrun checking is enabled.
6496
d4172c3b
EZ
64972011-10-13 Eli Zaretskii <eliz@gnu.org>
6498
6499 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6500 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6501 cursor motion with <left> and <right> arrow keys.
6502
6503 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6504 some callers set that themselves.
6505
b00eea75
EZ
65062011-10-12 Eli Zaretskii <eliz@gnu.org>
6507
6508 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6509 display string and the previous row comes from the same string and
6510 is empty. (Bug#9739) (Bug#9738)
6511
8fe012c4
SM
65122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6513
6514 * doc.c (get_doc_string): Encode file name (bug#9735).
6515
0074aef2
EZ
65162011-10-12 Eli Zaretskii <eliz@gnu.org>
6517
79beb178
EZ
6518 * bidi.c (bidi_level_of_next_char):
6519 * xdisp.c (get_visually_first_element): Remove old incorrect
6520 comments regarding the Unicode Line Separator character.
6521
0074aef2
EZ
6522 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6523
6e4b3fbe
DA
65242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6525
6526 * alloc.c (Fgc_status): Do not access beyond zombies array
6527 boundary if nzombies > MAX_ZOMBIES.
6528 * alloc.c (dump_zombies): Add missing format specifier.
6529
0324f3af
PE
65302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6531
b5525cac
PE
6532 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6533 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6534
0324f3af
PE
6535 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6536 Some packages use them to denote characters with modifiers.
6537
e9b5f888
AS
65382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6539
6540 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6541 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6542 matching a pp-number. Rename parameter var to var1.
6543
127827c0
SM
65442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6545
6546 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6547
c8fd3bd0
GM
65482011-10-08 Glenn Morris <rgm@gnu.org>
6549
6550 * callint.c (Fcall_interactively): Give a more explicit error for the
6551 'c' case with a non-character input. (Bug#8479)
6552
352ec8ff
EZ
65532011-10-08 Eli Zaretskii <eliz@gnu.org>
6554
03669ccb
EZ
6555 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6556 lines.
7061c986
EZ
6557 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6558 lines that are hscrolled on the left.
03669ccb 6559
352ec8ff
EZ
6560 * dispnew.c (buffer_posn_from_coords): Account for a possible
6561 presence of header-line. (Bug#4426)
6562
a66cfb1c
SM
65632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6564
6b02f655
SM
6565 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6566 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6567
7c5ee88e
PE
65682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6571 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6572 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6573 this makes Emacs dump core during garbage collection on rare
6574 occasions. sizeof is obviously inferior to offsetof here, so
6575 stick with offsetof.
6576 (GC_POINTER_ALIGNMENT): New macro.
6577 (mark_memory): Omit 3rd (offset) arg; caller changed.
6578 Don't assume EMACS_INT alignment is the same as pointer alignment.
6579
df1bbe5b
SM
65802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6581
6582 * keyboard.c (read_key_sequence_remapped): New var.
6583 (read_key_sequence): Compute remapping in the right buffer.
6584 (command_loop_1): Use read_key_sequence's remapping directly.
6585
51553db6
SM
65862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6587
32c1fffd
SM
6588 * dired.c (file_name_completion): Don't expand file name.
6589 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6590 before checking file name handler.
6591
51553db6
SM
6592 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6593 they've been requested explicitly (bug#9591).
6594
b6bd1599 65952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6596
6597 * keymap.c (Fsingle_key_description): Use make_specified_string
6598 instead of build_string to build string from push_key_description.
6599 (Bug#5193)
6600
f701dc2a
PE
66012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6602
4222c55d
PE
6603 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6604 This fixes a Y2038 bug on 64-bit hosts.
6605 * buffer.c (reset_buffer):
6606 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6607 (Fclear_buffer_auto_save_failure):
6608 Use 0, not -1, to represent an unset failure time, since time_t
6609 might not be signed.
6610
f701dc2a
PE
6611 Remove dependency on glibc malloc internals.
6612 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6613 Move back here from lisp.h, but with their new implementations.
6614 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6615 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6616 * charset.c (charset_table_init): New static var.
6617 (syms_of_charset): Use it instead of xmalloc. This removes a
6618 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6619 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6620 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6621 Move back to alloc.c.
6622 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6623 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6624
9ceebf39
JD
66252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6626
6627 * nsterm.m (windowDidResize): Call x_set_window_size only when
6628 ns_in_resize is true. Otherwise set pixelwidth/height and
6629 call change_frame_size (Bug#9628).
6630
cb993c58
PE
66312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6632
3930c88b
PE
6633 Port --enable-checking=all to Fedora 14 x86-64.
6634 * charset.c (syms_of_charset): Also account for glibc malloc's
6635 internal overhead when calculating the initial malloc maximum.
6636
cb993c58
PE
6637 Port --enable-checking=all to Fedora 14 x86.
6638 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6639 Move to lisp.h.
6640 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6641 (overrun_check_realloc, overrun_check_free):
6642 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6643 That way, xmalloc returns a properly-aligned pointer even if
6644 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6645 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6646 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6647 into account when calculating the initial malloc maximum.
6648 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6649 Move here from alloc.c, so that charset.c can use it too.
6650 Properly align; the old code wasn't right for common 32-bit hosts
6651 when configured with --enable-checking=all.
6652 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6653 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6654
31bed486
EZ
66552011-09-29 Eli Zaretskii <eliz@gnu.org>
6656
04c70788 6657 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6658 use EDOM.
6659
fbcaa2f3
EZ
66602011-09-28 Eli Zaretskii <eliz@gnu.org>
6661
6662 * xdisp.c (compute_display_string_end): If there's no display
6663 string at CHARPOS, return -1.
6664
6665 * bidi.c (bidi_fetch_char): When compute_display_string_end
6666 returns a negative value, treat the character as a normal
6667 character not covered by a display string. (Bug#9624)
6668
a239d4e9
JB
66692011-09-28 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * lread.c (Fread_from_string): Fix typo in docstring.
6672
88652fd5
EZ
66732011-09-27 Eli Zaretskii <eliz@gnu.org>
6674
6675 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6676 newline, reseat the iterator instead of bidi-iterating there one
6677 character at a time. (Bug#9610)
32c1fffd
SM
6678 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6679 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6680
ed497dd4
AS
66812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6682
6683 * lread.c (readevalloop): Use correct code for NBSP.
6684 (read1): Likewise. (Bug#9608)
6685
b2bf61aa
MA
66862011-09-25 Michael Albinus <michael.albinus@gmx.de>
6687
6688 * dbusbind.c (Fdbus_register_signal): When service is not
6689 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6690
32bbb17c
GM
66912011-09-25 Glenn Morris <rgm@gnu.org>
6692
6693 * buffer.c (truncate-lines): Doc fix.
6694
94e0933e
CY
66952011-09-24 Chong Yidong <cyd@stupidchicken.com>
6696
6697 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6698 (Fset_window_next_buffers): Doc fix.
6699
cddde921
GM
67002011-09-24 Glenn Morris <rgm@gnu.org>
6701
6702 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6703
1260aef1
PE
67042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6705
25b4bfa0
PE
6706 Fix minor problems found by static checking.
6707 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6708 * indent.c (Fvertical_motion): Fix == vs = typo.
6709
e3cbd34b
EZ
67102011-09-24 Eli Zaretskii <eliz@gnu.org>
6711
a66cfb1c
SM
6712 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6713 Default value is now t. Doc fix.
6bf7006f 6714
e3cbd34b 6715 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6716 logic when moving up, not only when moving down. Fix the
e3cbd34b 6717 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6718 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6719
6720 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6721 CHARPOS is covered by a display string which includes newlines.
6722 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6723 is covered by a display string with embedded newlines.
6724
a3de0cbd
MA
67252011-09-24 Michael Albinus <michael.albinus@gmx.de>
6726
6727 * dbusbind.c (Fdbus_register_signal): Add match rule to
6728 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6729 (Fdbus_register_method, Vdbus_registered_objects_table):
6730 Fix docstring.
a3de0cbd 6731
b260039d
JM
67322011-09-24 Jim Meyering <meyering@redhat.com>
6733
32c1fffd 6734 do not ignore write error for any output size
b260039d
JM
6735 The previous change was incomplete.
6736 While it makes emacs --batch detect the vast majority of stdout
6737 write failures, errors were still ignored whenever the output size is
6738 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6739 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6740 && echo FAIL: ignored write error
6741 FAIL: ignored write error
6742 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6743 && echo FAIL: ignored write error
6744 FAIL: ignored write error
6745 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6746
8eca8a7c
AS
67472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6748
6749 * emacs.c (Fkill_emacs): In noninteractive mode exit
6750 non-successfully if a write error occurred on stdout. (Bug#9574)
6751
3341db62
EZ
67522011-09-21 Eli Zaretskii <eliz@gnu.org>
6753
6754 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6755 the xassert test.
6756
6757 * dispextern.h (struct it): Update the comment documenting what
6758 can it->OBJECT be.
6759
8c203dbf
EZ
67602011-09-20 Eli Zaretskii <eliz@gnu.org>
6761
6762 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6763 a display string, extend search for cursor position to end of row.
6764 (find_row_edges): If the row ends in a newline from a display
6765 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6766 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6767 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6768 non-empty line. Fixes confusing cursor motion with arrow keys at
6769 the beginning of a line that starts with whitespace.
8c203dbf 6770
a4824228
LMI
67712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6772
6773 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6774 (bug#9493).
6775
33ed493b
CY
67762011-09-18 Chong Yidong <cyd@stupidchicken.com>
6777
6778 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6779 boolean (Bug#9154).
6780
56cd55c8
EZ
67812011-09-18 Eli Zaretskii <eliz@gnu.org>
6782
6783 * xdisp.c (display_line): Record maximum and minimum buffer
6784 positions even if no glyphs were produced (e.g., by a zero-width
6785 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6786 buffer positions that will be removed from the glyph row because
6787 they don't fit.
c02dcedf
EZ
6788 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6789 column is beyond frame width: don't subtract 1 "pixel" when
6790 computing width of the stretch.
3e62b7e0
EZ
6791 (reseat_at_next_visible_line_start): Undo the change made on
6792 2011-09-17 that saved paragraph information and restored it after
6793 the call to `reseat'. (Bug#9545)
56cd55c8 6794
5ed99d36 67952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6796
6797 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6798 and turn window cursor on if cleared (Bug#9415).
6799
5ed99d36 68002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6801
6802 * search.c (boyer_moore): Take unibyte characters from pattern
6803 literally. (Bug#9458)
6804
9bade7b2
EZ
68052011-09-18 Eli Zaretskii <eliz@gnu.org>
6806
6807 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6808
e5e9d610
PE
68092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6810
87e4427a
PE
6811 Fix minor problem found by static checking.
6812 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6813 initialized, to pacify gcc -Wuninitialized.
6814
e5e9d610
PE
6815 * fileio.c: Report proper errno when syscall falls.
6816 (Finsert_file_contents): Save and restore errno,
6817 so that report_file_error outputs the correct diagnostic.
6818 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6819
a1674f0b
EZ
68202011-09-18 Eli Zaretskii <eliz@gnu.org>
6821
6822 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6823
fbfb6dd4
EZ
68242011-09-17 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6827 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6828
bb187662
EZ
68292011-09-17 Eli Zaretskii <eliz@gnu.org>
6830
1137e8b8 6831 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6832 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6833
6834 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6835 (bidi_find_paragraph_start): Search back for paragraph beginning
6836 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6837 (bidi_move_to_visually_next): Only trigger paragraph-related
6838 computations when the last character is a newline or at EOB, not
6839 just any NEUTRAL_B. (Bug#9470)
6840
bb187662
EZ
6841 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6842 truncated lines if point is covered by a display string. (Bug#9524)
6843
2e621251
PE
68442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6845
6846 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6847 (cons_to_x_long): New function.
6848 (lisp_data_to_selection_data): Use it. Correct the test for
6849 short-versus-long data; it was negated. Break out of vector
6850 loop, for efficiency, when a long datum is discovered.
6851
91a15bc6
SM
68522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6853
6854 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6855
b41c3a35
EZ
68562011-09-16 Eli Zaretskii <eliz@gnu.org>
6857
6858 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6859 GCC PR/17406) by declaring this function with external scope.
6860
7812ba2d
PE
68612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6862
6863 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6864 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6865
cf7edc2a
AS
68662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6867
6868 * editfns.c (Fformat): Correctly handle text properties on "%%".
6869
bd01620e
EZ
68702011-09-15 Eli Zaretskii <eliz@gnu.org>
6871
6872 * xterm.c (x_draw_composite_glyph_string_foreground):
6873 * w32term.c (x_draw_composite_glyph_string_foreground):
6874 * term.c (encode_terminal_code):
6875 * composite.c (composition_update_it, get_composition_id):
6876 * xdisp.c (get_next_display_element)
6877 (fill_composite_glyph_string): Add comments about special meaning
6878 of TAB characters in a composition.
6879
a02719a3
PE
68802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6881
6882 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6883 This occurs when processing a multibyte format.
6884 Problem reported by Wolfgang Jenker.
a02719a3 6885
72589a3c
JB
68862011-09-15 Johan Bockgård <bojohan@gnu.org>
6887
6888 * xdisp.c (try_cursor_movement): Only check for exact match if
6889 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6890
1c14176c
PE
68912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6892
6893 Remove unused external symbols.
6894 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6895 * xdisp.c (calc_pixel_width_or_height): Now static.
6896 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6897 * indent.c (check_display_width):
6898 * w32term.c: Fix comment to match code.
6899 * xterm.c, xterm.h (x_catching_errors): Remove.
6900
d2eea5b5
PE
69012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6902
6903 * xselect.c: Use signed conversions more consistently (Bug#9498).
6904 (selection_data_to_lisp_data): Assume incoming selection data are
6905 signed integers, not unsigned. This is to be consistent with
6906 outgoing selection data, which was modified to use signed integers
6907 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6908 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6909 expects long, not unsigned long.
6910
46888499
EZ
69112011-09-14 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6914 computation of loop end. Reported by Johan Bockgård
6915 <bojohan@gnu.org>.
6916
ef8ef9fb
CY
69172011-09-13 Chong Yidong <cyd@stupidchicken.com>
6918
6919 * frame.c (Fother_visible_frames_p): Function deleted.
6920
fa819fed
EZ
69212011-09-12 Eli Zaretskii <eliz@gnu.org>
6922
6923 * indent.c (compute_motion): Process display vector front to back
6924 rather than the other way around. (Bug#2496)
6925
2ba8e008
SM
69262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6927
6928 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6929
20f53c69
CY
69302011-09-11 Chong Yidong <cyd@stupidchicken.com>
6931
6932 * minibuf.c (Fread_from_minibuffer): Doc fix.
6933
d562d7a4
EZ
69342011-09-11 Eli Zaretskii <eliz@gnu.org>
6935
6936 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6937 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6938
1c4d7f3d
LMI
69392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6940
6941 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6942 value for non-existent files.
6943
b885bf36
EZ
69442011-09-11 Eli Zaretskii <eliz@gnu.org>
6945
6946 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6947 set its "size" to -1. This will set the modtime_size field of
6948 the corresponding buffer to -1, which is what
6949 verify-visited-file-modtime expects for files that do not exist.
6950 (Bug#9139)
6951
6612f0bf
PE
69522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6953
6954 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6955 here ...
6956 * lisp.h: ... from here. push_key_description is no longer
6957 defined in keyboard.c, so its declaration should not be in
6958 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6959 logically belongs with push_key_description.
6960
dfb3f755
PE
69612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 * buffer.h: Include <sys/types.h> instead of <time.h>.
6964 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6965 Problem reported by Herbert J. Skuhra.
6966
3134906c
LMI
69672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6968
6969 * xml.c (parse_region): Make the parsing work for
6970 non-comment-starting XML files again (bug#9144).
6971
8d903f4e
AS
69722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6973
6974 * image.c (gif_load): Fix calculation of bottom and right corner.
6975 (Bug#9468)
6976
80ad64f4
EZ
69772011-09-10 Eli Zaretskii <eliz@gnu.org>
6978
6979 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6980 redisplay in small windows.
6981
208a048d
EZ
69822011-09-09 Eli Zaretskii <eliz@gnu.org>
6983
6984 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6985
9b1c252e
MR
69862011-09-08 Martin Rudalics <rudalics@gmx.at>
6987
6988 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6989 Operate on live windows only.
6990
2949f33b
JB
69912011-09-08 Juanma Barranquero <lekktu@gmail.com>
6992
6993 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6994
e08dcafd
EZ
69952011-09-07 Eli Zaretskii <eliz@gnu.org>
6996
6997 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6998 only under bidi iteration.
6999
115b96bd
JD
70002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7001
7002 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7003
c8199d0f
PE
70042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7007 Without this fix, the command to link temacs failed due to an
7008 undefined symbol __builtin_isnan. This is because
7009 /usr/include/iso/math_c99.h #defines isnan(x) to
7010 __builtin_isnan(x), but the bundled gcc, which identifies itself
7011 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7012 a __builtin_isnan.
7013 * floatfns.c (isnan): #undef, and then #define to a clone of
7014 what's in data.c.
7015 (Fisnan): Always define, since it's always available now.
7016 (syms_of_floatfns): Always define isnan at the Lisp level.
7017
e39b275c 70182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7019
7020 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7021
b2db44d9 70222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7023
f4af5137 7024 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7025 The previous code assumed that file offsets (off_t values) fit in
7026 EMACS_INT variables, which is not true on typical 32-bit hosts.
7027 The code messed up by falsely reporting buffer overflow in cases
7028 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7029 when "big" contains more than 2**29 bytes, even though this
7030 inserts just one byte and does not overflow the buffer.
7031 (Finsert_file_contents): Store file offsets as off_t
7032 values, not as EMACS_INT values. Check for overflow when
7033 converting between EMACS_INT and off_t. When checking for
7034 buffer overflow or for overlap, take the offsets into account.
7035 Don't use EMACS_INT for small values where int suffices.
7036 When checking for overlap, fix a typo: ZV was used where
7037 ZV_BYTE was intended.
7038 (Fwrite_region): Don't assume off_t fits into 'long'.
7039 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7040
ecfc0a49
MA
70412011-09-05 Michael Albinus <michael.albinus@gmx.de>
7042
7043 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7044
6511acf2 70452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7046
0999621a 7047 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7048
7049 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7050 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7051 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7052 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7053 (modify_event_symbol): Do not assume that the length of
7054 name_alist_or_stem is safe to alloca and fits in int.
7055 (Fexecute_extended_command): Likewise for function name and binding.
7056 (Frecursion_depth): Wrap around reliably on integer overflow.
7057 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7058 since some callers pass EMACS_INT values.
7059 (Fsingle_key_description): Don't crash if symbol name contains more
7060 than MAX_ALLOCA bytes.
7061 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7062 (get_minibuffer): Arg is now EMACS_INT, not int.
7063 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7064 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7065 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7066
2be7d702
PE
7067 * dbusbind.c (signature_cat): New function.
7068 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7069 Do not overrun buffer; instead, report string overflow.
7070
9d1df220
PE
7071 * dispnew.c (add_window_display_history): Don't overrun buffer.
7072 Truncate instead; this is OK since it's just a log.
7073
33ef5c64
PE
7074 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7075 even if the time zone offset is outlandishly large.
7076 Don't mishandle offset == INT_MIN.
7077
66c6fdd5
PE
7078 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7079 when creating daemon; the previous buffer-overflow check was incorrect.
7080
d749b01b
PE
7081 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7082 which has the guts of the old verror function.
7083
b5cd1905
PE
7084 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7085 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7086
6e1a67fb
PE
7087 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7088 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7089 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7090 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7091 length of string rather than counting it via multiple sprintfs;
7092 that's simpler and more reliable.
c21721cc
PE
7093 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7094 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7095 sprintf, in case result does not fit in int.
7096
c57b67fc
PE
7097 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7098 (fontset_from_font): Print it.
7099
8a401434
PE
7100 * frame.c (tty_frame_count): Now printmax_t, not int.
7101 (make_terminal_frame, set_term_frame_name): Print it.
7102 (x_report_frame_params): In X, window IDs are unsigned long,
7103 not signed long, so print them as unsigned.
7104 (validate_x_resource_name): Check for implausibly long names,
7105 and don't assume name length fits in 'int'.
7106 (x_get_resource_string): Don't blindly alloca invocation name;
7107 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7108 not fit in int.
7109
6e1a67fb
PE
7110 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7111 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7112 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7113
0df02bf3
PE
7114 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7115 Use esprintf, not sprintf, in case result does not fit in int.
7116
48e30793
PE
7117 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7118 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7119 it as a large positive number.
7120 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7121 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7122
a66ff6d8
PE
7123 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7124 in case result does not fit in int.
7125
aca216ff
PE
7126 * print.c (float_to_string): Detect width overflow more reliably.
7127 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7128 buffer overrun. Don't assume list length fits in 'int'. Treat
7129 print length of 0 as 0, not as infinity; to be consistent with other
7130 uses of print length in this function. Don't overflow print length
7131 index. Don't assume hash table size fits in 'long', or that
7132 vectorlike size fits in 'unsigned long'.
7133
31c286f7
PE
7134 * process.c (make_process): Use printmax_t, not int, to format
7135 process-name gensyms.
7136
55e5faa1
PE
7137 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7138
80f2e268
PE
7139 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7140 to avoid potential buffer overrun.
7141
670741ab
PE
7142 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7143 if X resource line is longer than 512 bytes.
7144
b7163a50
PE
7145 * xfns.c (x_window): Make sprintf buffer a bit bigger
7146 to avoid potential buffer overrun.
7147
ae58ff1f
PE
7148 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7149
c43c8a6a
PE
7150 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7151
3f8236f4
PE
71522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7153
53e9fe90 7154 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7155 Without these, Emacs silently mishandles large integers sometimes.
7156 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7157 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7158
6511acf2
PE
7159 * xdisp.c (try_window_id): Check Emacs fixnum range before
7160 converting to 'int'.
806add1d 7161
6511acf2 7162 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7163 Check that an Emacs fixnum is in range before assigning it to 'int'.
7164 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7165 values converted from Emacs fixnums.
7166 (Frecenter): Don't wrap around a line count if it is out of 'int'
7167 range; instead, treat it as an extreme value.
7168 (Fset_window_configuration, compare_window_configurations):
7169 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7170
6511acf2
PE
7171 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7172 that can exceed INT_MAX. Check that EMACS_INT value is in range
7173 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7174 (match_limit): Don't assume that a fixnum can fit in 'int'.
7175
6511acf2 7176 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7177 exceed INT_MAX.
7178
6511acf2 7179 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7180 (Fvertical_motion): Don't wrap around LINES values that don't fit
7181 in 'int'. Instead, treat them as extreme values. This is good
7182 enough for windows, which can't have more than INT_MAX lines anyway.
7183
fcb901a7
LMI
71842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7185
0f2f6b6d
LMI
7186 * Require libxml/parser.h to avoid compilation warning.
7187
fcb901a7
LMI
7188 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7189
7190 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7191 since this reportedly can destroy thread storage.
7192
6e20a0d4
CY
71932011-08-30 Chong Yidong <cyd@stupidchicken.com>
7194
7195 * syntax.c (find_defun_start): Update all cache variables if
7196 exiting early (Bug#9401).
7197
148ae00e
EZ
71982011-08-30 Eli Zaretskii <eliz@gnu.org>
7199
f6cfbd8f
EZ
7200 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7201
148ae00e
EZ
7202 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7203 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7204 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7205
7206 * term.c (tty_append_glyph): New function.
7207 (produce_stretch_glyph): Static function and its prototype deleted.
7208
a66cfb1c
SM
7209 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7210 Add prototypes.
148ae00e 7211
c4a07a4c
PE
72122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7213
7214 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7215 when checking :margin (Bug#9390).
7216 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7217 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7218 so that the name doesn't mislead. All uses changed.
7219
6bc8cd65
JB
72202011-08-28 Johan Bockgård <bojohan@gnu.org>
7221
7222 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7223 set_tty_hooks.
7224
dca4927e
EZ
72252011-08-27 Eli Zaretskii <eliz@gnu.org>
7226
7227 * xdisp.c (move_it_to): Don't bail out early when reaching
7228 position beyond to_charpos, if we are scanning backwards.
7229 (move_it_vertically_backward): When DY == 0, make sure we get to
7230 the first character in the line after the newline.
7231
f2cad773
PE
72322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7233
7234 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7235 (ccl_driver): Do not generate an out-of-range pointer.
7236 (Fccl_execute_on_string): Remove unnecessary check for
7237 integer overflow, noted by Stefan Monnier in
7238 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7239 Remove a FIXME that didn't need fixing.
7240 Simplify the newly-introduced buffer reallocation code.
7241
0cae2cdb
JB
72422011-08-27 Juanma Barranquero <lekktu@gmail.com>
7243
7244 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7245
5fc295a4 72462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7247
70c60eb2 7248 Integer and memory overflow issues (Bug#9196).
726e0ab1 7249
d31850da
PE
7250 * doc.c (get_doc_string): Rework so that
7251 get_doc_string_buffer_size is the actual buffer size, rather than
7252 being 1 less than the actual buffer size; this makes xpalloc more
7253 convenient.
7254
a69fbedb
PE
7255 * image.c (x_allocate_bitmap_record, cache_image):
7256 * xselect.c (Fx_register_dnd_atom):
7257 Simplify previous changes by using xpalloc.
7258
fe5c5d37
PE
7259 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7260 since either will do and ptrdiff_t is convenient with xpalloc.
7261
0065d054
PE
7262 * charset.c (charset_table_size)
7263 (struct charset_sort_data.priority): Now ptrdiff_t.
7264 (charset_compare): Don't overflow if priorities differ greatly.
7265 (Fsort_charsets): Don't assume list length fits in int.
7266 Check for size-calculation overflow when allocating sort data.
7267 (syms_of_charset): Allocate an initial charset table that is
7268 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7269
7270 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7271
7272 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7273 The actual value is always <= INT_MAX, and leaving it unsigned made
7274 overflow checking harder.
7275
7276 * dispextern.h (struct glyph_matrix.rows_allocated)
7277 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7278 with xpalloc. The values are still always <= INT_MAX.
7279
7280 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7281
7282 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7283 (SAFE_NALLOCA): New macro.
7284
7285 * region-cache.c (struct boundary.pos, find_cache_boundary)
7286 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7287 (set_cache_region, invalidate_region_cache)
7288 (revalidate_region_cache, know_region_cache, region_cache_forward)
7289 (region_cache_backward, pp_cache):
7290 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7291 so that ptrdiff_t * can be passed to xpalloc.
7292 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7293 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7294 (pp_cache): Don't assume cache_len fits in int.
7295 * region-cache.h: Adjust extern decls to match.
7296
7297 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7298 EMACS_INT, since either will do, for xpalloc.
7299
7300 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7301 (xnmalloc, xnrealloc, xpalloc): New functions.
7302
726e0ab1
PE
7303 * bidi.c (bidi_shelve_header_size): New constant.
7304 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7305 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7306
51f30bc5 7307 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7308 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7309 (overlay_strings):
7310 Don't update size of array until after memory allocation succeeds,
7311 because xmalloc/xrealloc may not return.
0065d054
PE
7312 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7313 now that we have proper integer overflow checking.
7314 (record_overlay_string, overlay_strings): Catch overflows when
7315 calculating size of overlay_str_buf.
726e0ab1 7316
0065d054
PE
7317 * callproc.c (Fcall_process): Check for size overflow when
7318 calculating size of args2.
7319 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7320 Normally we prefer signed values, but sticking with ptrdiff_t would
7321 require adding more-complicated checks.
726e0ab1
PE
7322
7323 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7324 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7325 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7326 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7327
7328 * character.c (Fstring): Check for size-calculation overflow.
7329
7330 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7331 unnecessary integer overflow. Check for size overflow.
7332 (encode_coding_object): Don't update size until xmalloc succeeds.
7333
7334 * composite.c (get_composition_id): Check for overflow in glyph
7335 length calculations.
7336
7337 Integer and memory overflow fixes for display code.
7338 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7339 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7340 (scrolling_window): Check for overflow in size calculations.
7341 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7342 Don't assume glyph table len fits in int.
7343 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7344 (row_table_size): Now ptrdiff_t, not int.
7345 (scrolling_window): Avoid overflow in size calculations.
7346 Don't update size until allocation succeeds.
7347 * fns.c (concat): Check for overflow in size calculations.
7348 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7349 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7350 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7351
7352 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7353 (get_doc_string): Check for size calculation overflow.
7354 Don't update size until allocation succeeds.
7355 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7356 EMACS_INT, where ptrdiff_t will do.
7357 (Fsubstitute_command_keys): Check for string overflow.
7358
7359 * editfns.c (set_time_zone_rule): Don't assume environment length
7360 fits in int.
7361 (message_length): Now ptrdiff_t, not int.
7362 (Fmessage_box): Don't update size until allocation succeeds.
7363 Don't assume message length fits in int.
7364 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7365
0065d054
PE
7366 * emacs.c (main): Do not reallocate argv, since there is a null at
7367 the end that can be overwritten, and this way there's no need to
7368 worry about size-calculation overflow.
7369 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7370
7371 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7372 alloc succeeds.
7373 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7374
7375 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7376 (x_set_scroll_bar_width, x_figure_window_size):
7377 Check for integer overflow.
7378 (x_set_alpha): Do not assume XINT fits in int.
7379
7380 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7381 This is for the members text_lines, text_cols, total_lines, total_cols,
7382 where the system imposes an 'int' limit.
7383
7384 * fringe.c (Fdefine_fringe_bitmap):
7385 Don't update size until alloc works.
7386
7387 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7388 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7389
7390 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7391 Check for size-calculation overflow.
7392 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7393 do, as we prefer signed integers.
7394 (id_to_widget.max_size, id_to_widget.used)
7395 (xg_store_widget_in_map, xg_remove_widget_from_map)
7396 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7397 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7398 Use and return ptrdiff_t, not int.
7399 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7400 * gtkutil.h: Change prototypes to match the above.
7401
7402 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7403 are duplicate now that they've been promoted to lisp.h.
7404 (x_allocate_bitmap_record, x_alloc_image_color)
7405 (make_image_cache, cache_image, xpm_load):
7406 Don't update size until alloc is done.
7407 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7408 (x_detect_edges):
3256efce 7409 Check for size calculation overflow.
726e0ab1
PE
7410 (ct_colors_allocated_max): New constant.
7411 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7412 overflow.
3256efce 7413
726e0ab1
PE
7414 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7415 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7416 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7417 Use ptrdiff_t, not int, to count maps.
7418 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7419 calculations. Don't update size until allocation succeeds.
7420 Redo calculations to avoid overflow.
726e0ab1
PE
7421 * keyboard.h: Change prototypes to match the above.
7422
7423 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7424 to count maps.
7425 (current_minor_maps): Check for size calculation overflow.
7426 * keymap.h: Change prototypes to match the above.
7427
7428 * lread.c (read1, init_obarray): Don't update size until alloc done.
7429
7430 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7431 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7432
726e0ab1
PE
7433 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7434 Now ptrdiff_t, not int.
7435 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7436 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7437
7438 * process.c (Fnetwork_interface_list): Check for overflow
7439 in size calculation.
7440
7441 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7442
7443 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7444 overflow. Don't bother calling xmalloc when xrealloc will do.
7445
7446 * search.c (Freplace_match): Check for size calculation overflow.
7447 (Fset_match_data): Don't assume list lengths fit in 'int'.
7448
7449 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7450 for command line length. Do not attempt to address one before the
7451 beginning of an array, as that's not portable.
7452
7453 * term.c (max_frame_lines): Remove; unused.
7454 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7455 not int.
7456 (encode_terminal_code, calculate_costs): Check for size
7457 calculation overflow.
7458 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7459 table lengths and related sizes. Don't update size until alloc
7460 done. Redo calculations to avoid overflow.
7461 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7462
7463 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7464 subtracting pointers.
7465 (gobble_line): Check for overflow more carefully. Don't update size
7466 until alloc done.
7467
7468 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7469 Don't update size until alloc done.
7470 Redo size calculations to avoid overflow.
7471 Check for size calculation overflow.
0065d054 7472 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7473
7474 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7475 Use ptrdiff_t, not int, for sizes.
7476 (store_mode_line_noprop_char): Don't update size until alloc done.
7477
0065d054
PE
7478 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7479 Use ptrdiff_t, not int, for sizes.
7480 (Finternal_make_lisp_face, cache_face):
7481 Check for size calculation overflow.
7482 (cache_face): Treat size calculation overflows as if they were
7483 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7484
7485 * xfns.c (x_encode_text, x_set_name_internal)
7486 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7487 sizes, since they can exceed INT_MAX in size. Check for size
7488 calculation overflow.
7489
0065d054
PE
7490 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7491 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7492 Don't update size until alloc done.
7493
0065d054 7494 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7495 as sprintf is limited to int lengths.
1d526e2f 7496
252c5ee1
PE
7497 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7498 (X_LONG_MIN): New macros.
864d7ce7
PE
7499 Use them to make the following changes clearer.
7500 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7501 This change doesn't affect the value now, but it may help remind
7502 future maintainers not to raise the value too much later.
7503 (SELECTION_QUANTUM): Remove, replacing with ...
7504 (selection_quantum): ... new function, which avoids overflow.
7505 All uses changed.
7506 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7507 assumption that selection length fits in 'int'.
7508 (x_reply_selection_request, x_handle_selection_request)
7509 (x_get_window_property, receive_incremental_selection)
7510 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7511 (lisp_data_to_selection_data, clean_local_selection_data):
7512 Use ptrdiff_t, not int, to record length of selection.
7513 (x_reply_selection_request, x_get_window_property)
7514 (receive_incremental_selection, x_property_data_to_lisp):
7515 Redo calculations to avoid overflow.
7516 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7517 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7518 something.
7519 (x_get_window_property, receive_incremental_selection)
7520 (lisp_data_to_selection_data, x_property_data_to_lisp):
7521 Check for size-calculation overflow.
7522 (x_get_window_property, receive_incremental_selection)
7523 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7524 Don't store size until memory allocation succeeds.
7525 (x_get_window_property): Plug memory leak on memory exhaustion.
7526 Don't double-block input; malloc is safe here. Don't assume 2**34
7527 - 4 fits in unsigned long. Add an xassert to check
7528 XGetWindowProperty overflow. Be more careful about overflow
7529 calculations, and distinguish size from memory overflow better.
7530 (receive_incremental_selection): When tracing, don't assume
7531 unsigned int is less than INT_MAX.
7532 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7533 harmful) conversions of unsigned short to int.
7534 (lisp_data_to_selection_data): Don't assume that integers
7535 in the range -65535 through -1 fit in an X unsigned short.
7536 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7537 result parameters unless successful. Rely on cons_to_unsigned
7538 to report problems with elements; the old code wasn't right anyway.
7539 (x_check_property_data): Check for int overflow; we cannot use
7540 a wider type due to X limits.
7541 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7542
726e0ab1 7543 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7544
0065d054
PE
7545 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7546 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7547 (x_color_cells): Don't store size until memory allocation succeeds.
7548 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7549 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7550 (x_term_init): Don't assume length fits in int (sprintf is limited
7551 to int size).
bc18e09d 7552
ebfa62c0
PE
7553 Use ptrdiff_t for composition IDs.
7554 * character.c (lisp_string_width):
7555 * composite.c (composition_table_size, n_compositions)
7556 (get_composition_id, composition_gstring_from_id):
7557 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7558 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7559 * window.c (Frecenter):
7560 Use ptrdiff_t, not int, for composition IDs.
7561 * composite.c (get_composition_id): Check for integer overflow.
7562 * composite.h: Adjust prototypes to match the above changes.
7563
d3411f89
PE
7564 Use ptrdiff_t for hash table indexes.
7565 * category.c (hash_get_category_set):
7566 * ccl.c (ccl_driver):
7567 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7568 * coding.c (coding_system_charset_list, detect_coding_system):
7569 * coding.h (struct coding_system.id):
7570 * composite.c (get_composition_id, gstring_lookup_cache):
7571 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7572 * image.c (xpm_get_color_table_h):
7573 * lisp.h (hash_lookup, hash_put):
7574 * minibuf.c (Ftest_completion):
7575 Use ptrdiff_t for hash table indexes, not int (which is too
7576 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7577 32-bit --with-wide-int hosts).
7578
e097a6fa
PE
7579 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7580 Add a FIXME comment about memory leaks.
7581 (syms_of_charset): Don't assume xmalloc returns.
7582
5637687f
PE
7583 Don't assume that stated character widths fit in int.
7584 * character.c (Fchar_width, c_string_width, lisp_string_width):
7585 * character.h (CHAR_WIDTH):
7586 * indent.c (MULTIBYTE_BYTES_WIDTH):
7587 Use sanitize_char_width to avoid undefined and/or bad behavior
7588 with outlandish widths.
a66cfb1c 7589 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7590 now that we have two such functions. All uses changed.
7591 (sanitize_char_width): New inline function.
7592
a2271ba2
PE
7593 Don't assume that tab-width fits in int.
7594 * character.h (sanitize_width): New inline function.
7595 (SANE_TAB_WIDTH): New macro.
7596 (ASCII_CHAR_WIDTH): Use it.
7597 * indent.c (sane_tab_width): Remove. All uses replaced by
7598 SANE_TAB_WIDTH (current_buffer).
7599 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7600
18c52557
PE
7601 * fileio.c: Integer overflow issues with file modes.
7602 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7603
caeeedc1
PE
7604 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7605 Remove unreachable code.
7606 (read_hex, load_charset_map_from_file): Check for integer overflow.
7607
6df6ae42 7608 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7609 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7610 (x_send_scroll_bar_event): Likewise. Check that the size does not
7611 exceed limits imposed by XClientMessageEvent, as well as the usual
7612 ptrdiff_t and size_t limits.
7613
b13995db
PE
7614 * keyboard.c: Overflow, signedness and related fixes.
7615 (make_lispy_movement): Use same integer type in forward decl
7616 that is used in the definition.
7617 (read_key_sequence, keyremap_step):
7618 Change bufsize argument back to int, undoing my 2011-03-30 change.
7619 We prefer signed types, and int is wide enough here.
7620 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7621 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7622 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7623 length, not size_t. Use ptrdiff_t for index, not int.
7624 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7625 possibility of integer overflow.
7626
13464394
PE
7627 Overflow, signedness and related fixes for images.
7628
7629 * dispextern.h (struct it.stack[0].u.image.image_id)
7630 (struct_it.image_id, struct image.id, struct image_cache.size)
7631 (struct image_cache.used, struct image_cache.ref_count):
7632 * gtkutil.c (update_frame_tool_bar):
7633 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7634 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7635 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7636 * nsmenu.m (update_frame_tool_bar):
7637 * xdisp.c (calc_pixel_width_or_height):
7638 * xfns.c (image_cache_refcount):
7639 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7640 on typical 64-bit hosts.
7641
7642 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7643 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7644 Omit unnecessary casts to int.
7645 (parse_image_spec): Check that integers fall into 'int' range
7646 when the callers expect that.
7647 (image_ascent): Redo ascent calculation to avoid int overflow.
7648 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7649 (lookup_image): Remove unnecessary tests.
7650 (xbm_image_p): Locals are now of int, not EMACS_INT,
7651 since parse_image_check makes sure they fit into int.
7652 (png_load, gif_load, svg_load_image):
7653 Prefer int to unsigned where either will do.
7654 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7655 old tiff_error_handler and tiff_warning_handler.
7656 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7657 stack buffer overflows. It uses only the features of vsnprintf
7658 that are common to both POSIX and native Microsoft.
7659 (tiff_error_handler, tiff_warning_handler): Use it.
7660 (tiff_load, gif_load, imagemagick_load_image):
7661 Don't assume :index value fits in 'int'.
7662 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7663 (imagemagick_load_image): Check that crop parameters fit into
7664 the integer types that MagickCropImage accepts. Don't assume
7665 Vimagemagick_render_type has a nonnegative value. Don't assume
7666 size_t fits in 'long'.
7667 (gs_load): Use printmax_t to print the widest integers possible.
7668 Check for integer overflow when computing image height and width.
7669
c11821d4
EZ
76702011-08-26 Eli Zaretskii <eliz@gnu.org>
7671
7672 * xdisp.c (redisplay_window): Don't force window start if point
7673 will be invisible in the resulting window. (Bug#9324)
7674
0c95fcf7
EZ
76752011-08-25 Eli Zaretskii <eliz@gnu.org>
7676
7677 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7678 the display spec is of the form `(space ...)'.
7679 (handle_display_spec): Return the value returned by
7680 handle_single_display_spec, not just 1 or zero.
7681 (handle_single_display_spec): If the display spec is of the form
7682 `(space ...)', and specifies display in the text area, return 2
7683 rather than 1.
fee65a97 7684 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7685 accurately, and prefer exact match for point under bidi.
7686 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7687
7688 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7689 into disp_prop; all users changed.
7690
7691 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7692 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7693 for the text covered by the display property.
7694
e4ed06f1
CY
76952011-08-25 Chong Yidong <cyd@stupidchicken.com>
7696
7697 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7698 Change return value to nil.
7699 (Frecord_buffer): Delete unused function.
7700
f67cdd7f
EZ
77012011-08-24 Eli Zaretskii <eliz@gnu.org>
7702
5980d4c6
EZ
7703 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7704 buffers, return left-to-right.
8610fe8b
EZ
7705 (set_cursor_from_row): Consider candidate row a win if its glyph
7706 represents a newline and point is on that newline. Fixes cursor
7707 positioning on the newline at EOL of R2L text within L2R
7708 paragraph, and vice versa.
7709 (try_cursor_movement): Check continued rows, in addition to
7710 continuation rows. Fixes unwarranted scroll when point enters a
7711 continued line of R2L text within an L2R paragraph, or vice versa.
7712 (cursor_row_p): Consider the case of point being equal to
7713 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7714 from the end of a short line to the beginning of a continued line
7715 of R2L text within L2R paragraph.
7716 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7717 composed characters.
5980d4c6 7718
f67cdd7f
EZ
7719 * bidi.c (bidi_check_type): Use xassert.
7720 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7721 members.
7722
bca633fb
EZ
77232011-08-23 Eli Zaretskii <eliz@gnu.org>
7724
7725 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7726 a character.
7727
4a5885a7
CY
77282011-08-23 Chong Yidong <cyd@stupidchicken.com>
7729
7730 * nsfont.m (ns_otf_to_script): Fix typo.
7731
0902a04e
KH
77322011-08-22 Kenichi Handa <handa@m17n.org>
7733
7734 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7735 extra slot even if the purpose is char-code-property-table.
7736
1a2e6670
EZ
77372011-08-23 Eli Zaretskii <eliz@gnu.org>
7738
8ddde651
EZ
7739 * xdisp.c (redisplay_window): When computing centering_position,
7740 account for the height of the header line. (Bug#8874)
7741
425cc014
EZ
7742 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7743 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7744 candidate is selected by the mouse, and that candidate has a
7745 composed character under the mouse.
7746
1a2e6670
EZ
7747 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7748 coordinates reported by pos-visible-in-window-p for a composed
7749 character in column zero.
7750
8b76d6f8
SM
77512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7752
7753 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7754
dac347dd
EZ
77552011-08-22 Eli Zaretskii <eliz@gnu.org>
7756
7757 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7758 consider it a hit if to_charpos is anywhere in the range of the
7759 composed buffer positions.
7760
e013fb34
CY
77612011-08-22 Chong Yidong <cyd@stupidchicken.com>
7762
7763 * image.c (gif_load): Don't assume that each subimage has the same
7764 dimensions as the base image. Handle disposal method that is
7765 "undefined" by the gif spec (Bug#9335).
7766
bd1ba3e8
CY
77672011-08-20 Chong Yidong <cyd@stupidchicken.com>
7768
7769 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7770 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7771
54a1215b
EZ
77722011-08-19 Eli Zaretskii <eliz@gnu.org>
7773
823564e5
EZ
7774 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7775 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7776 from an Org mode buffer to a Speedbar frame.
7777
54a1215b
EZ
7778 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7779 a composition, take its buffer position from IT->cmp_it.charpos.
7780 Fixes cursor positioning at the beginning of a line that begins
7781 with a composed character.
7782
9778ebcc
EZ
77832011-08-18 Eli Zaretskii <eliz@gnu.org>
7784
0be6ee06
EZ
7785 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7786 character bidirectional type, use STRONG_L instead. Fixes crashes
7787 in a buffer produced by `describe-categories'.
7788
9778ebcc
EZ
7789 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7790 members before the level stack, so they would be saved and
7791 restored when copying iterator state. Fixes incorrect reordering
7792 around TABs covered by display properties.
7793
156bffbe
AS
77942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7795
6b02f655 7796 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7797
72ad093b
CY
77982011-08-17 Chong Yidong <cyd@stupidchicken.com>
7799
7800 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7801 (internal_condition_case_2, internal_condition_case_n):
7802 Remove unnecessary aborts (Bug#9081).
72ad093b 7803
35774242
EZ
78042011-08-17 Eli Zaretskii <eliz@gnu.org>
7805
7806 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7807 has no `load' handler, try opening the file locally. (Bug#9311)
7808
db76dd85
KB
78092011-08-16 Ken Brown <kbrown@cornell.edu>
7810
7811 * gmalloc.c: Expand comment.
7812
b215eee5
EZ
78132011-08-16 Eli Zaretskii <eliz@gnu.org>
7814
7815 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7816 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7817
a4579d33
KB
78182011-08-16 Ken Brown <kbrown@cornell.edu>
7819
7820 Fix memory allocation problems in Cygwin build (Bug#9273).
7821
7822 * unexcw.c ( __malloc_initialized): Declare external variable.
7823 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7824
8b76d6f8
SM
7825 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7826 New variables.
a4579d33
KB
7827 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7828 dumped emacs.
7829 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7830 in the static heap.
7831 [CYGWIN] (special_realloc): New function.
7832 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7833 requests to realloc storage in the static heap.
7834
3ebec551
PE
78352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7836
7837 * bidi.c (bidi_initialize): Remove unused local.
7838
9fd8be00
EZ
78392011-08-15 Eli Zaretskii <eliz@gnu.org>
7840
6b02f655
SM
7841 * bidimirror.h:
7842 * biditype.h: Remove file.
7843 * makefile.w32-in ($(BLD)/bidi.$(O)):
7844 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7845
7846 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7847
7848 * chartab.c: Improve commentary for the uniprop_table API.
7849
32413314
EZ
7850 * bidi.c (bidi_paragraph_init): Support zero value of
7851 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7852 (bidi_initialize): Use uniprop_table instead of including
7853 biditype.h and bidimirror.h.
32413314 7854
9fd8be00
EZ
7855 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7856 coordinates of the iterator when restoring from ppos_it.
7857 (Bug#9296)
7858
5cf2b69b
KH
78592011-08-14 Kenichi Handa <handa@m17n.org>
7860
7861 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7862 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7863
daf17d00
EZ
78642011-08-14 Eli Zaretskii <eliz@gnu.org>
7865
7866 * xdisp.c (move_it_in_display_line_to): Don't invoke
7867 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7868 ppos_it. Fixes vertical cursor motion when line beginning is
7869 covered by an image. (Bug#9296)
7870
08e3161a
JD
78712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7872
7873 * nsterm.h (ns_run_ascript): Declare.
7874 (NSAPP_DATA2_RUNASSCRIPT): Define.
7875
7876 * nsfns.m (as_script, as_result, as_status): New static variables.
7877 (ns_run_ascript): New function.
5e617bc2 7878 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7879 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7880 the event loop. Get status from as_status (Bug#7276).
7881
7882 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7883 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7884 the event loop (Bug#7276).
7885
a3720aa2
AS
78862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7887
7888 * gnutls.c (QCgnutls_bootprop_priority)
7889 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7890 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7891 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7892 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7893 (QCgnutls_bootprop_verify_hostname_error)
7894 (QCgnutls_bootprop_callbacks_verify): Rename from
7895 Qgnutls_bootprop_..., all uses changed.
7896
7897 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7898 uses changed.
7899
0a0d27fb
PE
79002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7901
19d5c50c
PE
7902 * xfaces.c (Qframe_set_background_mode): Now static.
7903 * dispextern.h (Qframe_set_background_mode): Remove decl.
7904
0a0d27fb
PE
7905 * process.c (Fnetwork_interface_info): Declare local only if needed.
7906
377538cb
JD
79072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7908
7909 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7910 (Fnetwork_interface_list): Allocate in increments of bytes instead
7911 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7912 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7913 sockaddr.
7914 (struct ifflag_def): notrailers is smart on OSX.
7915 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7916 Get hardware address with getifaddrs if available.
7917
08fff70c
EZ
79182011-08-12 Eli Zaretskii <eliz@gnu.org>
7919
7920 * xdisp.c (iterate_out_of_display_property): xassert that
7921 IT->position is set to within IT->object's boundaries. Break from
7922 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7923 when IT->position is set up wrongly due to some bug.
7924 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7925 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7926 entry. Force push_it to save on the stack the current
7927 buffer/string position, to be restored by pop_it. Fix flags in
7928 the iterator structure wrt the object coming from a display
7929 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7930 properties. (Bug#9284)
7931
7be1c708 79322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7933
7be1c708
CY
7934 * fontset.c (fontset_get_font_group): Add proper type checks.
7935 (Bug#9172)
aac0c6e3 7936
7be1c708 79372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7938
7be1c708
CY
7939 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7940 and LC_VERSION_MIN_MACOSX.
7941 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7942 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7943
97bb72a6
EZ
79442011-08-08 Eli Zaretskii <eliz@gnu.org>
7945
7946 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7947 no-display-properties-and-no-overlays under bidi display.
7948 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7949 properties and overlays.
97bb72a6 7950
d5617611
CY
79512011-08-08 Chong Yidong <cyd@stupidchicken.com>
7952
37e11a63
CY
7953 * editfns.c (Fset_time_zone_rule): Document relationship with the
7954 setenv function.
7955
d5617611
CY
7956 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7957 the font entity extracted from the cache (Bug#8109).
7958
58872834
CY
79592011-08-07 Chong Yidong <cyd@stupidchicken.com>
7960
7961 * composite.c (autocmp_chars): Don't reset point. That is done by
7962 restore_point_unwind (Bug#5984).
7963
75bfc667
JL
79642011-08-07 Juri Linkov <juri@jurta.org>
7965
7966 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7967 to show the arg `TIME' instead of `TIMEVAL'.
7968
d1410150
EZ
79692011-08-06 Eli Zaretskii <eliz@gnu.org>
7970
7971 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7972 display property strides EOL and includes a newline, as in
7973 longlines-mode. (Bug#9254)
75b771e4
EZ
7974 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7975 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7976
7977 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7978 is non-zero, even if the data buffer is NULL. Fixes a crash in
7979 vertical-motion with longlines-mode. (Bug#9254)
7980
35928349
EZ
79812011-08-05 Eli Zaretskii <eliz@gnu.org>
7982
ec7cc85b
EZ
7983 * bidi.c <bidi_cache_total_alloc>: Now static.
7984 (bidi_initialize): Initialize bidi_cache_total_alloc.
7985
8b76d6f8 7986 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7987 cache. (Bug#9221)
7988
7989 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7990 amount allocated this far in `bidi_cache_total_alloc'.
7991 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7992 non-zero, only free the data buffer without restoring the cache
7993 contents. All callers changed.
7994
7995 * dispextern.h (bidi_unshelve_cache): Update prototype.
7996
7997 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7998 (move_it_in_display_line, move_it_to)
7999 (move_it_vertically_backward, move_it_by_lines): Replace the call
8000 to xfree to an equivalent call to bidi_unshelve_cache.
8001 (move_it_in_display_line_to): Fix logic of returning
412b6358 8002 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8003
e2e2423b
EZ
80042011-08-05 Eli Zaretskii <eliz@gnu.org>
8005
8006 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8007 came from a string character with a `cursor' property. (Bug#9229)
8008
ae9e757a
JD
80092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8010
8011 * Makefile.in (LIB_PTHREAD): New variable.
8012 (LIBES): Add LIB_PTHREAD (Bug#9216).
8013
8014 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8015 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8016
213bd7f2
AS
80172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8018
6b02f655 8019 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8020
99aaf75f
JD
80212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8022
8023 * xterm.c (x_find_topmost_parent): New function.
8024 (x_set_frame_alpha): Find topmost parent window with
8025 x_find_topmost_parent and set the property there also (bug#9181).
8026 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8027
c74e9d86
PE
80282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8029
8030 * callproc.c (Fcall_process): Avoid vfork clobbering
8031 the local vars buffer, coding_systems, current_dir.
8032
640c8776
SM
80332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8034
8035 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8036
f26d0e4c
PE
80372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8038
8a10d76c
PE
8039 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8040 so that it is not optimized away.
8041
f26d0e4c
PE
8042 * xdisp.c (compute_display_string_pos): Remove unused local.
8043
55439c61
EZ
80442011-08-02 Eli Zaretskii <eliz@gnu.org>
8045
8046 Fix slow cursor motion and scrolling in large buffers with
8047 selective display, like Org Mode buffers. (Bug#9218)
8048
8049 * dispextern.h (struct bidi_it): New member disp_prop_p.
8050
8051 * xdisp.c: Remove one-slot cache of display string positions.
8052 (compute_display_string_pos): Accept an additional argument
5e617bc2 8053 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8054 for a display string or property. If found, set DISP_PROP_P
8055 non-zero.
8056
8057 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8058 DISP_PROP_P, and pass it to compute_display_string_pos.
8059 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8060 non-zero. All callers of bidi_fetch_char changed.
8061
fb33fa43
SM
80622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8063
8064 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8065
b099e063
DM
80662010-12-03 Don March <don@ohspite.net>
8067
8068 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8069 last character M-[char] is translated to ESC [char] (bug#7541).
8070
5cc7f7af
KH
80712011-08-02 Kenichi Handa <handa@m17n.org>
8072
d0fffa3f 8073 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8074
8075 * chartab.c (uniprop_table): Make it non-static.
8076
525d5e6e
EZ
80772011-08-01 Eli Zaretskii <eliz@gnu.org>
8078
8079 * xdisp.c (forward_to_next_line_start): Accept additional argument
8080 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8081 on the newline.
8082 (reseat_at_next_visible_line_start): Use the bidi iterator state
8083 returned by forward_to_next_line_start to restore the state of
8084 it->bidi_it after backing up to previous newline. (Bug#9212)
8085
31011111
AS
80862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8087
8088 * regex.c (re_comp): Protoize.
8089 (re_exec): Fix return type.
8090 (regexec): Fix type of `ret'. (Bug#9203)
8091
476371c4
PE
80922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8093
e5d76069
PE
8094 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8095 This is needed if max-image-size is a floating-point number.
8096
9a79b20c
AS
80972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8098
8099 * print.c (print_object): Print empty symbol as ##.
8100
8101 * lread.c (read1): Read ## as empty symbol.
8102
d8c2fa78
AA
81032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8104
8105 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8106 setting frame foreground color (Bug#9175).
8107 (x_set_background_color): Likewise.
8108
ffe57a7a
AA
8109 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8110 contents (Bug#9176).
8111 (EmacsTooltip -init): Remove bezels and add shadows to
8112 tooltip windows.
8113
bf3492a5
AA
8114 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8115 or scroll bar (Bug#8470).
8116
d55e9c53
AA
8117 * nsfont.m (nsfont_open): Remove assignment to voffset and
8118 unnecessary vars hshink, expand, hd, full_height, min_height.
8119 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8120
8121 * nsterm.h (nsfont_info): Remove voffset field.
8122
d8c2fa78 81232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8124
8125 Implement strike-through and overline on NextStep (Bug#8863).
8126
8127 * nsfont.m (nsfont_open): Use underline position provided by font,
8128 instead of hard-coded value of 2.
8129 (nsfont_draw): Call ns_draw_text_decoration instead.
8130
8131 * nsterm.h: Add declaration for ns_draw_text_decoration.
8132
8133 * nsterm.m (ns_draw_text_decoration): New function for drawing
8134 underline, overline, and strike-through.
8135 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8136 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8137 accommodate underlining, etc.
4843aac3 8138
4cc60b9b
EZ
81392011-07-28 Eli Zaretskii <eliz@gnu.org>
8140
bc7ece87
EZ
8141 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8142 default.
4cc60b9b 8143
476371c4
PE
81442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8145
66606eea
PE
8146 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8147 Without this fix, if a signal arrives just after memory fills up,
8148 'malloc' might be invoked reentrantly.
8149
476371c4
PE
8150 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8151 In other words, assume that every image size is allowed, on non-X
8152 hosts. This assumption is probably wrong, but it lets Emacs compile.
8153
f3fcc40d
AS
81542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8155
8156 * regex.c (re_iswctype): Convert return values to boolean.
8157
350c992f
EZ
81582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8159
8160 * xdisp.c (compute_display_string_pos): Don't use cached display
8161 string position if the buffer had its restriction changed.
8162 (Bug#9184)
8163
5266b4bb
PE
81642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8165
8166 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8167
2573a837 81682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8169
41f55ccd 8170 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8171
39e378da
PE
8172 * bidi.c: Integer size and overflow fixes.
8173 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8174 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8175 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8176 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8177 (bidi_find_other_level_edge):
8178 Use ptrdiff_t instead of EMACS_INT where either will do.
8179 This works better on 32-bit hosts configured --with-wide-int.
8180 (bidi_cache_ensure_space): Check for size-calculation overflow.
8181 Use % rather than repeated addition, for better worst-case speed.
8182 Don't set bidi_cache_size until after xrealloc returns, because it
8183 might not return.
8184 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8185 (bidi_cache_ensure_space): Also check that the bidi cache size
8186 does not exceed that of the largest Lisp string or buffer. See Eli
8187 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8188
5e927815
PE
8189 * alloc.c (__malloc_size_t): Remove.
8190 All uses replaced by size_t. See Andreas Schwab's note
8191 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8192
ca4aa935
PE
8193 * image.c: Improve checking for integer overflow.
8194 (check_image_size): Assume that f is nonnull, since
8195 it is always nonnull in practice. This is one less thing to
8196 worry about when checking for integer overflow later.
8197 (x_check_image_size): New function, which checks for integer
8198 overflow issues inside X.
8199 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8200 This removes the need for a memory_full check.
8201 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8202 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8203 (xbm_read_bitmap_data): Change locals back to 'int', since
8204 their values must fit in 'int'.
8205 (xpm_load_image, png_load, tiff_load):
8206 Invoke x_create_x_image_and_pixmap earlier,
8207 to avoid much needless work if the image is too large.
8208 (tiff_load): Treat overly large images as if
8209 x_create_x_image_and_pixmap failed, not as malloc failures.
8210 (gs_load): Use x_check_image_size.
8211
5f8f9cc2
PE
8212 * gtkutil.c: Omit integer casts.
8213 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8214 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8215
5adf60bc
PE
8216 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8217
c8907a93
PE
8218 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8219 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8220 would wrongly return t on a 64-bit host.
8221
e3c25c68
PE
8222 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8223 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8224 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8225 and therefore cause GCC to emit a bogus diagnostic in some cases.
8226
3f791afe
PE
8227 * image.c: Integer signedness and overflow and related fixes.
8228 This is not an exhaustive set of fixes, but it's time to
8229 record what I've got.
8230 (lookup_pixel_color, check_image_size): Remove redundant decls.
8231 (check_image_size): Don't assume that arbitrary EMACS_INT values
8232 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8233 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8234 (tiff_load, imagemagick_load_image):
8235 Check for overflow in size calculations.
8236 (x_create_x_image_and_pixmap): Remove unnecessary test for
8237 xmalloc returning NULL; that can't happen.
8238 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8239 (xpm_color_bucket): Use better integer hashing function.
8240 (xpm_cache_color): Don't possibly over-allocate memory.
8241 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8242 (gif_memory_source):
8243 Use ptrdiff_t, not int or size_t, to record sizes.
8244 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8245 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8246 either works, as we prefer signed integers.
8247 (tiff_read_from_memory, tiff_write_from_memory):
8248 Return tsize_t, not size_t, since that's what the TIFF API wants.
8249 (tiff_read_from_memory): Don't fail simply because the read would
8250 go past EOF; instead, return a short read.
8251 (tiff_load): Omit no-longer-needed casts.
8252 (Fimagemagick_types): Don't assume size fits into 'int'.
8253
3cc5a532
PE
8254 Improve hashing quality when configured --with-wide-int.
8255 * fns.c (hash_string): New function, taken from sxhash_string.
8256 Do not discard information about ASCII character case; this
8257 discarding is no longer needed.
8258 (sxhash-string): Use it. Change sig to match it. Caller changed.
8259 * lisp.h: Declare it.
8260 * lread.c (hash_string): Remove, since we now use fns.c's version.
8261 The fns.c version returns a wider integer if --with-wide-int is
8262 specified, so this should help the quality of the hashing a bit.
8263
b312a492
PE
8264 * emacs.c: Integer overflow minor fix.
8265 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8266 Define only if GNU_LINUX.
8267 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8268
dfd153ae
PE
8269 * dispnew.c: Integer signedness and overflow fixes.
8270 Remove unnecessary forward decls, that were a maintenance hassle.
8271 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8272 All uses changed.
8273 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8274 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8275 (prepare_desired_row, line_draw_cost):
8276 Use int, not unsigned, where either works.
8277 (save_current_matrix, restore_current_matrix):
8278 Use ptrdiff_t, not size_t, where either works.
8279 (init_display): Check for overflow more accurately, and without
8280 relying on undefined behavior.
8281
a81d11a3
PE
8282 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8283 Remove, replacing with the new symbols in lisp.h. All uses changed.
8284 * fileio.c (make_temp_name):
8285 * filelock.c (lock_file_1, lock_file):
8286 * xdisp.c (message_dolog):
8287 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8288 Use pMd etc. instead.
8289 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8290 replacing the pWIDE etc. symbols removed from editfns.c.
8291
3300e6fd
PE
8292 * keyboard.h (num_input_events): Now uintmax_t.
8293 This is (very slightly) less likely to mess up due to wraparound.
8294 All uses changed.
8295
fd05c7e9
PE
8296 * buffer.c: Integer signedness fixes.
8297 (alloc_buffer_text, enlarge_buffer_text):
8298 Use ptrdiff_t rather than size_t when either will do, as we prefer
8299 signed integers.
8300
903fe15d
PE
8301 * alloc.c: Integer signedness and overflow fixes.
8302 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8303 (__malloc_size_t): Default to size_t, not to int.
8304 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8305 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8306 Prefer ptrdiff_t to size_t when either would do, as we prefer
8307 signed integers.
8308 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8309 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8310 Now const. Initialize with values that are in range even if char
8311 is signed.
8312 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8313 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8314 These functions do the right thing with sizes > 2**32.
8315 (check_depth): Now ptrdiff_t, not int.
8316 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8317 Adjust to new way of storing sizes. Check for size overflow bugs
8318 in rest of code.
8319 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8320 slightly wrong anyway, as it missed one instance of
8321 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8322 (refill_memory_reserve): Omit needless cast to size_t.
8323 (mark_object_loop_halt): Mark as externally visible.
8324
ac82cc6a
PE
8325 * xselect.c: Integer signedness and overflow fixes.
8326 (Fx_register_dnd_atom, x_handle_dnd_message):
8327 Use ptrdiff_t, not size_t, since we prefer signed.
8328 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8329 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8330 x_dnd_atoms_size and x_dnd_atoms_length.
8331
c2d1e36d
PE
8332 * doprnt.c: Prefer signed to unsigned when either works.
8333 * eval.c (verror):
8334 * doprnt.c (doprnt):
8335 * lisp.h (doprnt):
8336 * xdisp.c (vmessage):
8337 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8338 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8339 prefer signed arithmetic to avoid comparison confusion.
8340 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8341 but is a bit tricky.
8342
0e926e56
PE
8343 Assume freestanding C89 headers, string.h, stdlib.h.
8344 * data.c, doprnt.c, floatfns.c, print.c:
8345 Include float.h unconditionally.
8346 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8347 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8348 * regex.c: Likewise for stddef.h, string.h.
8349 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8350 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8351 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8352 (STDC_HEADERS): Remove obsolete defines.
8353 * sysdep.c: Include limits.h unconditionally.
8354
9cfdb3ec
PE
8355 Assume support for memcmp, memcpy, memmove, memset.
8356 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8357 * regex.c (memcmp, memcpy):
8358 Remove; we assume C89 now.
8359
8360 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8361 (__malloc_safe_bcopy): Remove; no longer needed.
8362
cf950e6b 8363 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8364 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8365 well either way, and we prefer signed to unsigned.
8366
dbf38e02
LMI
83672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8368
8369 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8370 closes the connection while we're reading (bug#9182).
8371
d6f0886c 83722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8373
d6f0886c
JD
8374 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8375 are specified (Bug#9168).
24e0f6b1 8376
2eb1f9e6
PE
83772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8378
8379 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8380 Found by GCC static checking and --with-wide-int on a 32-bit host.
8381
22381272 83822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8383
8384 * xdisp.c (compute_display_string_pos): Fix logic of caching
8385 previous display string position. Initialize cached_prev_pos to
8386 -1. Fixes slow-down at the beginning of a buffer.
8387
f25e39b4
EZ
83882011-07-24 Eli Zaretskii <eliz@gnu.org>
8389
8390 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8391 for attrs[LFACE_FONTSET_INDEX].
8392
04c4b52e
PE
83932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8394
8395 * xml.c (parse_region): Remove unused local
8396 that was recently introduced.
8397
c1734fbd
EZ
83982011-07-23 Eli Zaretskii <eliz@gnu.org>
8399
be18c5a5
EZ
8400 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8401 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8402
c1734fbd
EZ
8403 * xdisp.c (move_it_in_display_line_to): Record the best matching
8404 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8405 exit if none of the characters scanned was an exact match.
8406 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8407 when exact match is impossible due to invisible text, and the
8408 lines are truncated.
8409
a258d627
JD
84102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8411
8412 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8413 for OSX >= 10.7.
8414
b6d5a689
EZ
84152011-07-22 Eli Zaretskii <eliz@gnu.org>
8416
0f74f785
EZ
8417 Fix a significant slow-down of cursor motion with C-n, C-p,
8418 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8419 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8420 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8421 (next_element_from_buffer): Call compute_stop_pos_backwards to
8422 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8423 base_level_stop.
8424 (reseat): Don't look for prev_stop, as that could mean a very long
8425 run.
8426 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8427 <cached_disp_overlay_modiff>: Cache for last found display string
8428 position.
551918c1 8429 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8430 about the same buffer in the same area of character positions, and
8431 the buffer wasn't changed since the time the display string
8432 position was cached.
551918c1 8433
b2d0c91a
EZ
84342011-07-22 Eli Zaretskii <eliz@gnu.org>
8435
8436 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8437 is an integer, which is important for empty lines. (Bug#9149)
8438
043604ee
CY
84392011-07-22 Chong Yidong <cyd@stupidchicken.com>
8440
8441 * frame.c (Fmodify_frame_parameters): In tty case, update the
8442 default face if necessary (Bug#4238).
8443
da4adb04
CY
84442011-07-21 Chong Yidong <cyd@stupidchicken.com>
8445
8446 * editfns.c (Fstring_to_char): No need to explain what a character
8447 is in the docstring (Bug#6576).
8448
9abd0532
LMI
84492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8450
8451 * xml.c (parse_region): Make sure we always return a tree.
8452
36881d16
HK
84532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8454
8455 * xml.c (parse_region): If a document contains only comments,
8456 return that, too.
8457
1e98674d
LMI
84582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8459
8460 * xml.c (make_dom): Return comments, too.
8461
590bd467
PE
84622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8463
8464 Port to OpenBSD.
8465 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8466 and the surrounding thread.
8467 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8468 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8469 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8470 timer goes off.
8471 * s/openbsd.h (BROKEN_SIGIO): Define.
8472 * unexelf.c (unexec) [__OpenBSD__]:
8473 Don't update the .mdebug section of the Alpha COFF symbol table.
8474
f41628b2
LMI
84752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8476
8477 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8478 (bug#8460).
8479
b59b67c5
PE
84802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8481
15e3a074
PE
8482 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8483 This fixes some race conditions on the permissions of any newly
8484 created file.
8485
41bed37d
PE
8486 * alloc.c (valid_pointer_p): Use pipe, not open.
8487 This fixes some permissions issues when debugging.
8488
b59b67c5
PE
8489 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8490 If fchown fails to set both uid and gid, try to set just gid,
8491 as that is sometimes allowed. Adjust the file's mode to eliminate
8492 setuid or setgid bits that are inappropriate if fchown fails.
8493
925a6be7
SM
84942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8495
8496 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8497 to compare Lisp_Objects.
8498 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8499 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8500 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8501
52968808
AS
85022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8503
0a6a104b
AS
8504 * lread.c (read_integer): Unread even EOF character.
8505 (read1): Likewise. Properly record start position of symbol.
8506
52968808
AS
8507 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8508 symbol character follows.
8509
9e381cdd
PE
85102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8511
8512 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8513 This works around a problem with the previous change to Fcopy_file.
8514 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8515 and without this change, GCC might complain about discarding
8516 fchown's return value.
8517
b5641435
JB
85182011-07-16 Juanma Barranquero <lekktu@gmail.com>
8519
8520 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8521
a8031457
PE
85222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8523
8524 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8525
dd889327
LMI
85262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8527
750c33f7
LMI
8528 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8529 it's used from the C level.
8530
dd889327
LMI
8531 * process.c: Use the same condition for POLL_FOR_INPUT in both
8532 keyboard.c and process.c (bug#1858).
8533
87e86684
LM
85342011-07-09 Lawrence Mitchell <wence@gmx.li>
8535
8536 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8537 (Fgnutls_boot): Use it.
8538
64348f40
AS
85392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8540
8541 * doc.c (Fsubstitute_command_keys): Revert last change.
8542
1d698799
LMI
85432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8544
f863868c
LMI
8545 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8546 quotes the next character, and doesn't affect other longer
8547 sequences (bug#8935).
8548
1d698799
LMI
8549 * lread.c (syms_of_lread): Clarify that is isn't only
8550 `eval-buffer' and `eval-defun' that's affected by
8551 `lexical-binding' (bug#8460).
8552
aa4b6df6
EZ
85532011-07-15 Eli Zaretskii <eliz@gnu.org>
8554
8555 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8556 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8557
5d856da6
PE
85582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8559
ad6042bb
PE
8560 Fix minor problems found by static checking.
8561 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8562 (elsz): Now a signed constant, not a size_t var. We prefer signed
8563 types to unsigned, to avoid integer comparison confusion. Without
8564 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8565 "cannot optimize loop, the loop counter may overflow", a symptom
8566 of the confusion.
f00bbb22 8567 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8568 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8569
6468f31c
LMI
85702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8571
49080b10
LMI
8572 * search.c (Fre_search_backward): Mention `case-fold-search' in
8573 all the re_search_* functions (bug#8138).
8574
6468f31c
LMI
8575 * keyboard.c (Fopen_dribble_file): Document when the file is
8576 closed (bug#8056).
8577
c965adc5
EZ
85782011-07-14 Eli Zaretskii <eliz@gnu.org>
8579
df9733bf
EZ
8580 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8581 bidi_cache_idx.
8582
0bb23927
EZ
8583 Support bidi reordering of display and overlay strings.
8584 * xdisp.c (compute_display_string_pos)
8585 (compute_display_string_end): Accept additional argument STRING.
8586 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8587 (reseat_to_string): Initialize bidi_it->string.s and
8588 bidi_it->string.schars.
8589 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8590 NULL (avoids a crash in bidi_paragraph_init).
8591 Initialize itb.string.lstring.
0bb23927
EZ
8592 (init_iterator): Call bidi_init_it only of a valid
8593 buffer position was specified. Initialize paragraph_embedding to
8594 L2R.
8595 (reseat_to_string): Initialize the bidi iterator.
8596 (display_string): If we need to ignore text properties of
8597 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8598 original value of -1 will not work with bidi.)
8599 (compute_display_string_pos): First arg is now struct
8600 `text_pos *'; all callers changed. Support display properties on
8601 Lisp strings.
8602 (compute_display_string_end): Support display properties on Lisp
8603 strings.
8604 (init_iterator, reseat_1, reseat_to_string): Initialize the
8605 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8606 when iterating on a string not from display properties).
640c8776
SM
8607 (compute_display_string_pos, compute_display_string_end):
8608 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8609 arrow keys.
8610 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8611 base_level_stop; instead, set base_level_stop to BEGV.
8612 Fixes crashes in vertical-motion.
0bb23927
EZ
8613 (next_element_from_buffer): Improve commentary for when
8614 the iterator is before prev_stop.
8615 (init_iterator): Initialize bidi_p from the default value of
8616 bidi-display-reordering, not from buffer-local value. Use the
8617 buffer-local value only if initializing for buffer iteration.
8618 (handle_invisible_prop): Support invisible properties on strings
8619 that are being bidi-reordered.
8620 (set_iterator_to_next): Support bidi reordering of C strings and
8621 Lisp strings.
8622 (next_element_from_string): Support bidi reordering of Lisp
8623 strings.
8624 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8625 (display_string): Support display of R2L glyph rows.
8626 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8627 (init_iterator): Don't initialize it->bidi_p for strings
8628 here.
8629 (reseat_to_string): Initialize it->bidi_p for strings here.
8630 (next_element_from_string, next_element_from_c_string)
8631 (next_element_from_buffer): Add xassert's for correspondence
8632 between IT's object being iterated and it->bidi_it.string
8633 structure.
8634 (face_before_or_after_it_pos): Support bidi iteration.
8635 (next_element_from_c_string): Handle the case of the first string
8636 character that is not the first one in the visual order.
8637 (get_visually_first_element): New function, refactored from common
8638 parts of next_element_from_buffer, next_element_from_string, and
8639 next_element_from_c_string.
8640 (tool_bar_lines_needed, redisplay_tool_bar)
8641 (display_menu_bar): Force left-to-right direction. Add a FIXME
8642 comment for making that be controlled by a user option.
8643 (push_it, pop_it): Save and restore the state of the
8644 bidi iterator. Save and restore the bidi_p flag.
8645 (pop_it): Iterate out of display property for string iteration as
8646 well.
8647 (iterate_out_of_display_property): Support iteration over strings.
8648 (handle_single_display_spec): Set up it->bidi_it for iteration
8649 over a display string, and call bidi_init_it.
8650 (handle_single_display_spec, next_overlay_string)
8651 (get_overlay_strings_1, push_display_prop): Set up the bidi
8652 iterator for displaying display or overlay strings.
8653 (forward_to_next_line_start): Don't use the shortcut if
8654 bidi-iterating.
8655 (back_to_previous_visible_line_start): If handle_display_prop
8656 pushed the iterator stack, restore the internal state of the bidi
8657 iterator by calling bidi_pop_it same number of times.
8658 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8659 and we are bidi-iterating, don't decrement the iterator position;
8660 instead, set the first_elt flag in the bidi iterator, to produce
8661 the same effect.
8662 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8663 (push_display_prop): xassert that we are iterating a buffer.
8664 (push_it, pop_it): Save and restore paragraph_embedding member.
8665 (handle_single_display_spec, next_overlay_string)
8666 (get_overlay_strings_1, reseat_1, reseat_to_string)
8667 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8668 correctly. Don't assume unibyte strings are not bidi-reordered.
8669 (compute_display_string_pos)
8670 (compute_display_string_end): Fix handling the case of C string.
8671 (push_it, pop_it): Save and restore from_disp_prop_p.
8672 (handle_single_display_spec, push_display_prop): Set the
8673 from_disp_prop_p flag.
8674 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8675 (pop_it): Call iterate_out_of_display_property only if we are
8676 popping after iteration over a string that came from a display
8677 property. Fix a typo in popping stretch info. Add an assertion
8678 for verifying that the iterator position is in sync with the bidi
8679 iterator.
8680 (handle_single_display_spec, get_overlay_strings_1)
8681 (push_display_prop): Fix initialization of paragraph direction for
8682 string when that of the parent object is not yet determined.
8683 (reseat_1): Call bidi_init_it to resync the bidi
8684 iterator with IT's position. (Bug#7616)
8685 (find_row_edges): If ROW->start.pos gives position
8686 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8687 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8688 Reset the from_disp_prop_p flag.
8689 (SAVE_IT, RESTORE_IT): New macros.
8690 (pos_visible_p, face_before_or_after_it_pos)
8691 (back_to_previous_visible_line_start)
8692 (move_it_in_display_line_to, move_it_in_display_line)
8693 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8694 (try_scrolling, redisplay_window, display_line): Use them when
8695 saving a temporary copy of the iterator and restoring it back.
8696 (back_to_previous_visible_line_start, reseat_1)
8697 (init_iterator): Empty the bidi cache "stack".
8698 (move_it_in_display_line_to): If iterator ended up at
8699 EOL, but we never saw any buffer positions smaller than
8700 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8701 motion in bidi-reordered lines.
8702 (move_it_in_display_line_to): Record prev_method and prev_pos
8703 immediately before the call to set_iterator_to_next. Fixes cursor
8704 motion in bidi-reordered lines with stretch glyphs and strings
8705 displayed in margins. (Bug#8133) (Bug#8867)
8706 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8707 TO_CHARPOS.
640c8776
SM
8708 (pos_visible_p): Support positions in bidi-reordered lines.
8709 Save and restore bidi cache.
0bb23927
EZ
8710
8711 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8712 (bidi_paragraph_info): Delete unused struct.
8713 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8714 (bidi_cache_start): New variable.
8715 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8716 to zero.
8717 (bidi_cache_fetch_state, bidi_cache_search)
8718 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8719 (bidi_cache_find, bidi_peek_at_next_level)
8720 (bidi_level_of_next_char, bidi_find_other_level_edge)
8721 (bidi_move_to_visually_next): Compare cache index with
8722 bidi_cache_start rather than with zero.
8723 (bidi_fetch_char): Accept new argument STRING; all callers
8724 changed. Support iteration over a string. Support strings with
8725 display properties. Support unibyte strings. Fix the type of
8726 `len' according to what STRING_CHAR_AND_LENGTH expects.
8727 (bidi_paragraph_init, bidi_resolve_explicit_1)
8728 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8729 (bidi_level_of_next_char, bidi_move_to_visually_next):
8730 Support iteration over a string.
0bb23927
EZ
8731 (bidi_set_sor_type, bidi_resolve_explicit_1)
8732 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8733 can now be zero (for strings); special values 0 and -1 were
8734 changed to -1 and -2, respectively.
8735 (bidi_char_at_pos): New function.
8736 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8737 Call it instead of FETCH_MULTIBYTE_CHAR.
8738 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8739 initialized to valid values.
8740 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8741 values.
8742 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8743 the test for valid cached positions. Fix the logic for looking up
8744 the sentinel state in the cache. GCPRO the Lisp string we are
8745 iterating.
8746 (bidi_push_it, bidi_pop_it): New functions.
8747 (bidi_initialize): Initialize the bidi cache start stack pointer.
8748 (bidi_cache_ensure_space): New function, refactored from part of
8749 bidi_cache_iterator_state. Don't assume the required size is just
8750 one BIDI_CACHE_CHUNK away.
8751 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8752 (bidi_count_bytes, bidi_char_at_pos): New functions.
8753 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8754 always valid if bidi_cache_idx is valid.
8755 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8756 is valid if it's going to be used.
8757 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8758 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8759 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8760 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8761 (bidi_find_other_level_edge, bidi_cache_start_stack):
8762 All variables related to cache indices are now EMACS_INT.
c965adc5 8763
0bb23927
EZ
8764 * dispextern.h (struct bidi_string_data): New structure.
8765 (struct bidi_it): New member `string'. Make flag members be 1-bit
8766 fields, and put them last in the struct.
640c8776
SM
8767 (compute_display_string_pos, compute_display_string_end):
8768 Update prototypes.
0bb23927
EZ
8769 (bidi_push_it, bidi_pop_it): Add prototypes.
8770 (struct iterator_stack_entry): New members bidi_p,
8771 paragraph_embedding, and from_disp_prop_p.
8772 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8773 (bidi_shelve_cache, bidi_unshelve_cache):
8774 Declare prototypes.
0bb23927
EZ
8775
8776 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8777 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8778 and vector-like objects.
8779
8780 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8781 cache around display iteration.
8782
8783 * window.c (Fwindow_end, window_scroll_pixel_based)
8784 (displayed_window_lines, Frecenter): Save and restore the bidi
8785 cache around display iteration.
8786
3bbd2265
LMI
87872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8788
8789 * editfns.c (Fdelete_region): Clarify the use of the named
8790 parameters (bug#6788).
8791
adc47434
MR
87922011-07-14 Martin Rudalics <rudalics@gmx.at>
8793
8794 * indent.c (Fvertical_motion): Set and restore w->pointm when
8795 saving and restoring the window's buffer (Bug#9006).
8796
837c31f8
LMI
87972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8798
8799 * editfns.c (Fstring_to_char): Clarify just what is returned
8800 (bug#6576). Text by Eli Zaretskii.
8801
ac389d0c
JB
88022011-07-13 Juanma Barranquero <lekktu@gmail.com>
8803
8804 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8805
0be0ce47
EZ
88062011-07-13 Eli Zaretskii <eliz@gnu.org>
8807
8808 * buffer.c (mmap_find): Fix a typo.
8809
cd18e7e3
JB
88102011-07-13 Johan Bockgård <bojohan@gnu.org>
8811
8812 Fix execution of x selection hooks.
8813 * xselect.c (Qx_lost_selection_functions)
8814 (Qx_sent_selection_functions): New vars.
8815 (syms_of_xselect): DEFSYM them.
8816 (x_handle_selection_request): Pass Qx_sent_selection_functions
8817 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8818 (x_handle_selection_clear,x_clear_frame_selections):
8819 Pass Qx_lost_selection_functions rather than
8820 Vx_lost_selection_functions to Frun_hook_with_args.
8821
47ea7f44
PE
88222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8823
ac389d0c 8824 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8825 The old code sometimes used this field without initializing it.
8826
47ea7f44
PE
8827 * alloc.c (gc_sweep): Don't read past end of array.
8828 In theory, the old code could also have corrupted Emacs internals,
8829 though it'd be very unlikely.
8830
bc985c87
AS
88312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8832
8833 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8834 argument. (Bug#4026)
bc985c87 8835
0cf34688
LMI
88362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8837
b3dadd76
LMI
8838 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8839 key" (bug#4257).
8840
0cf34688
LMI
8841 * window.c (Fset_window_start): Doc fix (bug#4199).
8842 (Fset_window_hscroll): Ditto.
8843
270768cd
PE
88442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8845
077e3dda 8846 Fix minor new problems caught by GCC 4.6.1.
270768cd 8847 * term.c (init_tty): Remove unused local.
490011a6 8848 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8849 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8850 not used otherwise.
270768cd 8851
b1f58454
CY
88522011-07-12 Chong Yidong <cyd@stupidchicken.com>
8853
8854 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8855
22b9578d
LMI
88562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8857
6e70ab07
LMI
8858 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8859 are the mini-buffer and the echo area (bug#3320).
8860
22b9578d
LMI
8861 * term.c (init_tty): Remove support for supdup, c10 and perq
8862 terminals, which are no longer supported (bug#1482).
8863
8974cc9f
JB
88642011-07-10 Johan Bockgård <bojohan@gnu.org>
8865
8866 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8867
a560d974
JD
88682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8869
8870 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8871 for non-popups (Bug#3642).
8872
1dae0f0a
AS
88732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8874
268c2c36 8875 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8876 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8877 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8878 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8879 * data.c (fmod): Likewise.
8880 * dispnew.c (swap_glyphs_in_rows): Likewise.
8881 * emacs.c (memory_warning_signal): Likewise.
8882 * floatfns.c (float_error): Likewise.
8883 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8884 (otf_open, font_otf_capability, generate_otf_features)
8885 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8886 Likewise.
8887 * image.c (pbm_read_file): Likewise.
8888 * indent.c (string_display_width): Likewise.
8889 * intervals.c (check_for_interval, search_for_interval)
8890 (inc_interval_count, count_intervals, root_interval)
8891 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8892 * lread.c (defalias): Likewise.
268c2c36 8893 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8894 * regex.c (set_image_of_range_1, set_image_of_range)
8895 (regex_grow_registers): Likewise.
8896 * sysdep.c (strerror): Likewise.
8897 * termcap.c (valid_filename_p, tprint, main): Likewise.
8898 * tparam.c (main): Likewise.
8899 * unexhp9k800.c (run_time_remap, save_data_space)
8900 (update_file_ptrs, read_header, write_header, calculate_checksum)
8901 (copy_file, copy_rest, display_header): Likewise.
8902 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8903 Likewise.
8904 * xdisp.c (check_it): Likewise.
8905 * xfaces.c (register_color, unregister_color, unregister_colors):
8906 Likewise.
8907 * xfns.c (print_fontset_result): Likewise.
8908 * xrdb.c (member, fatal, main): Likewise.
8909
99033785
PE
89102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8911
8912 Fix minor problems found by static checking (Bug#9031).
8913 * chartab.c (char_table_set_range, map_sub_char_table):
8914 Remove unused locals.
8915 (uniprop_table): Now static.
8916 * composite.c (_work_char): Remove unused static var.
8917
9cb2ac56
JB
89182011-07-09 Juanma Barranquero <lekktu@gmail.com>
8919
8920 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8921
f25661f0
JD
89222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8923
8924 * gtkutil.c (qttip_cb): Remove code without function.
8925
8278c4fe
EZ
89262011-07-09 Eli Zaretskii <eliz@gnu.org>
8927
8928 * w32.c (pthread_sigmask): New stub.
8929
1692ae2d 89302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8931
8a6ebd58 8932 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8933 sigprocmask is portable only for single-threaded applications, and
8934 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8935 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8936 (LIBES): Use it.
8937 * callproc.c (Fcall_process):
8938 * process.c (create_process):
8939 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8940 Use pthread_sigmask, not sigprocmask.
123403e4 8941
1b854618
JD
89422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8943
8944 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8945 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8946 wrong (Bug#8591).
8947
3fe4b549
JD
89482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8949
0ce7e563
JD
8950 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8951 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8952 (xg_hide_tooltip): Fix comment.
8953
3fe4b549
JD
8954 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8955 in registerServicesMenuSendTypes.
8956 (validRequestorForSendType): Don't check ns_return_types.
8957
8958 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8959 ns_return_type.
8960
5df75e47
JR
89612011-07-08 Jason Rumney <jasonr@gnu.org>
8962
22610910
JR
8963 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8964 SH_SHOW for hidden windows (Bug#5482).
8965
5df75e47
JR
8966 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8967 frame struct members of non-existent frames (Bug#6284).
8968
699c10bd
JD
89692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8970
4393663b
JD
8971 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8972 variable firstTime not needed on OSX >= 10.6.
8973 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8974 >= 10.5. Use setKnobProportion, setDoubleValue.
8975
8976 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8977 (MAC_OS_X_VERSION_10_5): Define if not defined.
8978 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8979 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8980 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8981
8982 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8983 cString and lossyCString on OSX >= 10.4.
4393663b 8984
58179cce 8985 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8986 sizeToFit on OSX >= 10.2.
8987
8988 * nsimage.m (allocInitFromFile): Don't use deprecated method
8989 bestRepresentationForDevice on OSX >= 10.6.
8990
8991 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8992 to avoid warning.
8993
8994 * emacs.c: Declare unexec_init_emacs_zone.
8995
a63e0781
JD
8996 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8997
699c10bd
JD
8998 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8999
9000 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9001 on svcsMenu (Bug#8842).
9002
9003 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9004 ns_return_types.
9005 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9006
9007 * nsterm.m (QUTF8_STRING): Declare.
9008 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9009 (validRequestorForSendType): Return type is (id).
9010 Change indexOfObjectIdenticalTo to indexOfObject.
9011 Check if we have local selection before returning self (Bug#8842).
9012 (writeSelectionToPasteboard): Put local selection into paste board
9013 if we have a local selection (Bug#8842).
9014 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9015
9016 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9017 (ns_get_local_selection): Declare.
9018
54e10184
LMI
90192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9020
9888ff71
LMI
9021 * keymap.c (describe_map_tree): Don't insert a double newline at
9022 the end of the buffer (bug#1169) and return whether we inserted
9023 something.
9024
54e10184
LMI
9025 * callint.c (Fcall_interactively): Change "reading args" to
9026 "providing args" to try to clarify what it does (bug#1010).
9027
15fa4783
KH
90282011-07-07 Kenichi Handa <handa@m17n.org>
9029
9030 * composite.c (composition_compute_stop_pos): Ignore a static
9031 composition starting before CHARPOS (Bug#8915).
9032
9033 * xdisp.c (handle_composition_prop): Likewise.
9034
a8815b00
EZ
90352011-07-07 Eli Zaretskii <eliz@gnu.org>
9036
9037 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9038 (Bug#9015)
9039
ef7b981d 90402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9041
9042 * character.h (unicode_category_t): New enum type.
9043
9044 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9045 (Qchar_code_property_table): New variable.
9046 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9047 (UNIPROP_COMPRESSED_FORM_P): New macros.
9048 (char_table_ascii): Uncompress the compressed values.
9049 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9050 Uncompress the compressed values.
ac389d0c 9051 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9052 (char_table_ref_and_range): Uncompress the compressed values.
9053 (sub_char_table_set): New arg is_uniprop. Callers changed.
9054 Uncompress the compressed values.
9055 (sub_char_table_set_range): Args changed. Callers changed.
9056 (char_table_set_range): Adjuted for the above change.
9057 (map_sub_char_table): Delete args default_val and parent. Add arg
9058 top. Give decoded values to a Lisp function.
640c8776 9059 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9060 values to a Lisp function. Gcpro more variables.
9061 (uniprop_table_uncompress)
9062 (uniprop_decode_value_run_length): New functions.
9063 (uniprop_decoder, uniprop_decoder_count): New variables.
9064 (uniprop_get_decoder, uniprop_encode_value_character)
9065 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9066 New functions.
9067 (uniprop_encoder, uniprop_encoder_count): New variables.
9068 (uniprop_get_encoder, uniprop_table)
9069 (Funicode_property_table_internal, Fget_unicode_property_internal)
9070 (Fput_unicode_property_internal): New functions.
9071 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9072 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9073 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9074 char-code-property-alist.
9075
640c8776 9076 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9077 Vunicode_category_table.
9078
640c8776 9079 * font.c (font_range): Adjust for the change of
c805dec0
KH
9080 Vunicode_category_table.
9081
76b397fb
DN
90822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9083
9084 * m/iris4d.h: Remove file, move contents ...
9085 * s/irix6-5.h: ... here.
9086
22b4128e
PE
90872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9088
9089 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9090 * alloc.c (mark_buffer):
9091 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9092 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9093 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9094 This isn't true in general, and it's particularly not true
9095 if Emacs is configured with --with-wide-int.
9096 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9097 New macros, used in the buffer.c change.
9098
869795d6
JD
90992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9100
9101 * xsettings.c: Use both GConf and GSettings if both are available.
9102 (store_config_changed_event): Add comment.
9103 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9104 (store_tool_bar_style_changed): New functions.
5e617bc2 9105 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9106 (struct xsettings): Move font inside HAVE_XFT.
9107 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9108 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9109 Move inside HAVE_XFT.
640c8776 9110 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9111 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9112 also.
9113 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9114 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9115 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9116 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9117 (parse_settings): Move check for font inside HAVE_XFT.
9118 (read_settings, apply_xft_settings): Add comment.
9119 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9120 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9121 call store_font_name_changed.
9122 (xft_settings_event): Add comment.
9123 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9124 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9125 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9126 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9127 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9128 (xsettings_get_system_font, xsettings_get_system_normal_font):
9129 Add comment.
869795d6 9130
d8ed26bd
PE
91312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9132
9133 Random fixes. E.g., (random) never returned negative values.
9134 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9135 subseconds part to the entropy, as that's a bit more random.
9136 Prefer signed to unsigned, since the signedness doesn't matter and
9137 in general we prefer signed. When given a limit, use a
9138 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9139 latter isn't right if USE_2_TAGS_FOR_INTS.
9140 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9141 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9142
cabf1cac
SM
91432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9144
9145 * textprop.c (text_property_stickiness):
9146 Obey Vtext_property_default_nonsticky.
9147 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9148 * w32fns.c (syms_of_w32fns):
9149 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9150
6e9b2be9
PE
91512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9152
9153 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9154 This is more efficient than Ffile_directory_p and avoids a minor race.
9155
90186c68
LMI
91562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9157
7c301272
LMI
9158 * buffer.c (Foverlay_put): Say what the return value is
9159 (bug#7835).
9160
c4f2d8d4
LMI
9161 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9162 is a directory before asking whether to use the file name
9163 (bug#7564).
ad637907
LMI
9164 (barf_or_query_if_file_exists): Make the "File is a directory"
9165 error be more correct.
c4f2d8d4 9166
90186c68
LMI
9167 * fns.c (Frequire): Remove the mention of the .gz files, since
9168 that's installation-specific, but keep the mention of
9169 `get-load-suffixes'.
9170
da64016e
PE
91712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9172
9173 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9174 Report string overflow if the output is too long.
9175
7d47b580
JB
91762011-07-04 Juanma Barranquero <lekktu@gmail.com>
9177
a555cb87
JB
9178 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9179 (syms_of_gnutls): Remove duplicate DEFSYM for
9180 Qgnutls_bootprop_verify_hostname_error, an error for
9181 Qgnutls_bootprop_verify_error (which is no longer used).
9182
7d47b580
JB
9183 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9184 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9185 Also (re)move comments that are misplaced or no longer relevant.
9186
1e49bfab
LMI
91872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9188
9189 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9190
1485f4c0
CY
91912011-07-03 Chong Yidong <cyd@stupidchicken.com>
9192
9193 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9194 and background color parameters if they have been changed.
9195
a9ab721e
LMI
91962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9197
9198 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9199
cf7cff57
PE
92002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9201
2e13213d
PE
9202 * xsettings.c (SYSTEM_FONT): Define only when used.
9203 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9204
cf7cff57
PE
9205 * keymap.c (access_keymap_1): Now static.
9206
7a8e04f7
CY
92072011-07-02 Chong Yidong <cyd@stupidchicken.com>
9208
9209 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9210 leave any prefix arg for the up event (Bug#1586).
9211
61352f62
LMI
92122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9213
69bb1ef7
LMI
9214 * lread.c (syms_of_lread): Mention single symbols defined by
9215 `defvar' or `defconst' (bug#7154).
9216
61352f62 9217 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9218 (Frequire): Mention get-load-suffixes.
61352f62 9219
28545e04
MR
92202011-07-02 Martin Rudalics <rudalics@gmx.at>
9221
9222 * window.h (window): Remove clone_number slot.
9223 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9224 Remove.
9225 (make_parent_window, make_window, saved_window)
9226 (Fset_window_configuration, save_window_save): Don't deal with
9227 clone numbers.
9228 * buffer.c (Qclone_number): Remove declaration.
9229 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9230
3349e122
SM
92312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9232
9233 Add multiple inheritance to keymaps.
9234 * keymap.c (Fmake_composed_keymap): New function.
9235 (Fset_keymap_parent): Simplify.
9236 (fix_submap_inheritance): Remove.
9237 (access_keymap_1): New function extracted from access_keymap to handle
9238 embedded parents and handle lists of maps.
9239 (access_keymap): Use it.
9240 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9241 (Fcopy_keymap): Handle embedded parents.
9242 (Fcommand_remapping, define_as_prefix): Simplify.
9243 (Fkey_binding): Simplify.
9244 (syms_of_keymap): Move minibuffer-local-completion-map,
9245 minibuffer-local-filename-completion-map,
9246 minibuffer-local-must-match-map, and
9247 minibuffer-local-filename-must-match-map to Elisp.
9248 (syms_of_keymap): Defsubr make-composed-keymap.
9249 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9250 (parse_menu_item): Trivial simplification.
9251
3279eb87
GM
92522011-07-01 Glenn Morris <rgm@gnu.org>
9253
9254 * Makefile.in (SETTINGS_LIBS): Fix typo.
9255
4550efdf
KI
92562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9257
9258 * coding.c (Fencode_coding_string): Record the last coding system
9259 used, as the function doc string says (bug#8738).
9260
0949d2b6
JD
92612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9262
9263 * xsettings.c (store_monospaced_changed): Take new font as arg and
9264 check for change against current_mono_font.
9265 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9266 (emacs_settings_constructor, emacs_settings_get_property)
9267 (emacs_settings_set_property, emacs_settings_class_init)
9268 (emacs_settings_init, gsettings_obj): Remove.
9269 (something_changedCB): New function for HAVE_GSETTINGS.
9270 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9271 with value as argument.
9272 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9273 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9274 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9275 "changed".
9276
9277 * xgselect.c: Add defined (HAVE_GSETTINGS).
9278 (xgselect_initialize): Ditto.
9279
9280 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9281 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9282 xg_select.
9283
bbc6b304
PE
92842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9285
9286 * eval.c (struct backtrace): Simplify and port the data structure.
9287 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9288 signed bit field, as this assumption is not portable and it makes
9289 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9290 "char debug_on_exit : 1" as this is not portable either; instead,
9291 use the portable "unsigned int debug_on_exit : 1". Remove unused
9292 member evalargs. Remove obsolete comments about cc bombing out.
9293
9851bfc5
JD
92942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9295
51bb811f 9296 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9297 Let HAVE_GSETTINGS override HAVE_GCONF.
9298 (store_monospaced_changed): New function.
9299 (EMACS_SETTINGS): A new type derived from GObject to handle
9300 GSettings notifications.
9301 (emacs_settings_constructor, emacs_settings_get_property)
9302 (emacs_settings_set_property, emacs_settings_class_init):
9303 New functions.
9304 (gsettings_client, gsettings_obj): New variables.
9305 (GSETTINGS_SCHEMA): New define.
9306 (something_changedCB): Call store_monospaced_changed.
9307 (init_gsettings): New function.
9308 (xsettings_initialize): Call init_gsettings.
9309 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9310 to NULL.
9311
640c8776 9312 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9313 GCONF_CFLAGS/LIBS.
9314
5386012d
MR
93152011-06-29 Martin Rudalics <rudalics@gmx.at>
9316
9317 * window.c (resize_root_window, grow_mini_window)
9318 (shrink_mini_window): Rename Qresize_root_window to
9319 Qwindow_resize_root_window and Qresize_root_window_vertically to
9320 Qwindow_resize_root_window_vertically.
9321
f13e0b08
PE
93222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9323
9324 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9325
94515237
JB
93262011-06-27 Juanma Barranquero <lekktu@gmail.com>
9327
9328 * makefile.w32-in: Redesign dependencies so they reflect more
9329 clearly which files are directly included by each source file,
9330 and not through other includes.
9331
e43b6e43
MR
93322011-06-27 Martin Rudalics <rudalics@gmx.at>
9333
9334 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9335 (sort_overlays, overlay_strings): When an overlay's clone number
9336 matches the window's clone number process the overlay even if
9337 the overlay's window property doesn't match the current window.
9338
d68443dc
MR
9339 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9340 (Fwindow_hchild): Rename to Fwindow_left_child.
9341 (Fwindow_next): Rename to Fwindow_next_sibling.
9342 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9343 (resize_window_check): Rename to window_resize_check.
9344 (resize_window_apply): Rename to window_resize_apply.
9345 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9346 (Fdelete_other_windows_internal, resize_frame_windows)
9347 (Fsplit_window_internal, Fdelete_window_internal)
9348 (grow_mini_window, shrink_mini_window)
9349 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9350
c7e73be5
JD
93512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9352
9353 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9354 (emacs_fixed_set_min_size): Remove.
9355 (emacs_fixed_new): Take frame as argument.
9356
9357 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9358 (_EmacsFixedPrivate): Remove minwidth/height.
9359 Add struct frame *f.
9360 (emacs_fixed_init): Initialize priv->f.
9361 (get_parent_class, emacs_fixed_set_min_size): Remove.
9362 (emacs_fixed_new): Set priv->f to argument.
9363 (emacs_fixed_get_preferred_width)
9364 (emacs_fixed_get_preferred_height): Use min_width/height from
9365 frames size_hint to set minimum and natural (Bug#8919).
9366 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9367 and use min_width/height from frames size_hint to set
9368 min_width/height (Bug#8919).
9369
9370 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9371 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9372 Fix indentation.
c7e73be5 9373
cf99dcf8
EZ
93742011-06-26 Eli Zaretskii <eliz@gnu.org>
9375
9376 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9377 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9378 called at ZV.
9379
029529ac
CY
93802011-06-26 Chong Yidong <cyd@stupidchicken.com>
9381
9382 * process.c (wait_reading_process_output): Bypass select if
9383 waiting for a cell while ignoring keyboard input, and input is
9384 pending. Suggested by Jan Djärv (Bug#8869).
9385
7a7ef429
PE
93862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9387
9388 Use gnulib's dup2 module instead of rolling our own.
9389 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9390
11fdef7d 93912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9392
9393 * dispnew.c (scrolling_window): Before scrolling, turn off a
9394 mouse-highlight in the window being scrolled.
9395
cd3520a4
JB
93962011-06-24 Juanma Barranquero <lekktu@gmail.com>
9397
9398 Move DEFSYM to lisp.h and use everywhere.
9399
9400 * character.h (DEFSYM): Move declaration...
9401 * lisp.h (DEFSYM): ...here.
9402
9403 * gnutls.c:
9404 * minibuf.c:
9405 * w32menu.c:
9406 * w32proc.c:
9407 * w32select.c: Don't include character.h.
9408
9409 * alloc.c (syms_of_alloc):
9410 * buffer.c (syms_of_buffer):
9411 * bytecode.c (syms_of_bytecode):
9412 * callint.c (syms_of_callint):
9413 * casefiddle.c (syms_of_casefiddle):
9414 * casetab.c (init_casetab_once):
9415 * category.c (init_category_once, syms_of_category):
9416 * ccl.c (syms_of_ccl):
9417 * cmds.c (syms_of_cmds):
9418 * composite.c (syms_of_composite):
9419 * dbusbind.c (syms_of_dbusbind):
9420 * dired.c (syms_of_dired):
9421 * dispnew.c (syms_of_display):
9422 * doc.c (syms_of_doc):
9423 * editfns.c (syms_of_editfns):
9424 * emacs.c (syms_of_emacs):
9425 * eval.c (syms_of_eval):
9426 * fileio.c (syms_of_fileio):
9427 * fns.c (syms_of_fns):
9428 * frame.c (syms_of_frame):
9429 * fringe.c (syms_of_fringe):
9430 * insdel.c (syms_of_insdel):
9431 * keymap.c (syms_of_keymap):
9432 * lread.c (init_obarray, syms_of_lread):
9433 * macros.c (syms_of_macros):
9434 * msdos.c (syms_of_msdos):
9435 * print.c (syms_of_print):
9436 * process.c (syms_of_process):
9437 * search.c (syms_of_search):
9438 * sound.c (syms_of_sound):
9439 * syntax.c (init_syntax_once, syms_of_syntax):
9440 * terminal.c (syms_of_terminal):
9441 * textprop.c (syms_of_textprop):
9442 * undo.c (syms_of_undo):
9443 * w32.c (globals_of_w32):
9444 * window.c (syms_of_window):
9445 * xdisp.c (syms_of_xdisp):
9446 * xfaces.c (syms_of_xfaces):
9447 * xfns.c (syms_of_xfns):
9448 * xmenu.c (syms_of_xmenu):
9449 * xsettings.c (syms_of_xsettings):
9450 * xterm.c (syms_of_xterm): Use DEFSYM.
9451
4228cf16
TZ
94522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9453
cd3520a4 9454 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9455
7fcccf1e
PE
94562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9457
7efb4e0e
PE
9458 Integer and buffer overflow fixes (Bug#8873).
9459
ff5844ad
PE
9460 * print.c (printchar, strout): Check for string overflow.
9461 (PRINTPREPARE, printchar, strout):
9462 Don't set size unless allocation succeeds.
9463
90532f02
PE
9464 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9465 for sizes. Check for string overflow more accurately.
9466 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9467
6d84508d
PE
9468 * macros.c: Integer and buffer overflow fixes.
9469 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9470 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9471 Use ptrdiff_t, not int, for sizes.
9472 Don't increment bufsize until after realloc succeeds.
9473 Check for size-calculation overflow.
9474 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9475
437b2cb4
PE
9476 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9477
8b9ac8b4
PE
9478 * lread.c: Integer overflow fixes.
9479 (read_integer): Radix is now EMACS_INT, not int,
9480 to improve quality of diagnostics for out-of-range radices.
9481 Calculate buffer size correctly for out-of-range radices.
9482 (read1): Check for integer overflow in radices, and in
9483 read-circle numbers.
82cb60d3
PE
9484 (read_escape): Avoid int overflow.
9485 (Fload, openp, read_buffer_size, read1)
9486 (substitute_object_recurse, read_vector, read_list, map_obarray):
9487 Use ptrdiff_t, not int, for sizes.
9488 (read1): Use EMACS_INT, not int, for sizes.
20270765 9489 Check for size overflow.
8b9ac8b4 9490
7fcccf1e
PE
9491 * image.c (cache_image): Check for size arithmetic overflow.
9492
bfbbd7e7
PE
9493 * lread.c: Integer overflow issues.
9494 (saved_doc_string_size, saved_doc_string_length)
9495 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9496 Now ptrdiff_t, not int.
9497 (read1): Don't assume doc string length fits in int. Check for
9498 out-of-range doc string lengths.
9499 (read_list): Don't assume file position fits in int.
39019e54 9500 (read_escape): Check for hex character overflow.
bfbbd7e7 9501
4e323265
LL
95022011-06-22 Leo Liu <sdl.web@gmail.com>
9503
9504 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9505 Move to minibuffer.el.
9506
85fece3e
PE
95072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9508
20b84ce9 9509 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9510 The following patches are for when GLYPH_DEBUG && !XASSERT.
9511 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9512 * dispnew.c (flush_stdout):
9513 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9514 Mark as externally visible.
9515 * dispnew.c (check_window_matrix_pointers): Now static.
9516 * dispnew.c (window_to_frame_vpos):
9517 * xfns.c (unwind_create_frame):
9518 * xterm.c (x_check_font): Remove unused local.
9519 * scroll.c (CHECK_BOUNDS):
9520 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9521 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9522 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9523 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9524 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9525 Now static.
9526 (debug_method_add): Use va_list and vsprintf rather than relying
9527 on undefined behavior with wrong number of arguments.
9528 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9529 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9530 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9531 since we're not interested in debugging glyphs with old libraries.
9532 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9533 GCC 4.6.0's static checking.
9534
0766b489
PE
95352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9536
31fd4b32
PE
9537 Integer overflow and signedness fixes (Bug#8873).
9538 A few related buffer overrun fixes, too.
9539
b79e8648
PE
9540 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9541
0766b489
PE
9542 * dispextern.h (struct face.stipple):
9543 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9544 (x_bitmap_mask, x_allocate_bitmap_record)
9545 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9546 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9547 (x_create_bitmap_from_xpm_data):
9548 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9549 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9550 (.bitmaps_last):
9551 * xfaces.c (load_pixmap):
9552 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9553 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9554 (.bitmaps_last, struct x_output.icon_bitmap):
9555 Use ptrdiff_t, not int, for bitmap indexes.
9556 (x_allocate_bitmap_record): Check for size overflow.
9557 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9558
b081724f
PE
9559 Use ptrdiff_t, not int, for overlay counts.
9560 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9561 * editfns.c (overlays_around, get_pos_property):
9562 * textprop.c (get_char_property_and_overlay):
9563 * xdisp.c (next_overlay_change, note_mouse_highlight):
9564 * xfaces.c (face_at_buffer_position):
21514da7
PE
9565 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9566 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9567 (Fnext_overlay_change, Fprevious_overlay_change)
9568 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9569 Use ptrdiff_t, not int, for sizes.
21514da7 9570 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9571
3de73e5e
PE
9572 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9573
2606c57b
PE
9574 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9575 (x_session_initialize): Do not assume string length fits in int.
9576
aaafe47a
PE
9577 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9578 This is unlikely, but can occur if DPI is outlandish.
9579
2674ddc8 9580 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9581 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9582
28154962
PE
9583 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9584 * xrdb.c (magic_file_p, search_magic_path):
9585 Omit last arg SUFFIX; it was always 0. All callers changed.
9586 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9587
7de51af5
PE
9588 * xfont.c (xfont_match): Avoid need for strlen.
9589
25ed6cc3
PE
9590 * xfns.c: Don't assume strlen fits in int.
9591 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9592
4eab31dd
PE
9593 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9594 not unsigned long, as we prefer signed integers. All callers changed.
9595 Detect integer overflow in repeat count.
9596 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9597 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9598
171e2a58
PE
9599 * termcap.c: Don't assume sizes fit in int and never overflow.
9600 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9601 (gobble_line): Check for size-calculation overflow.
9602
ad39faca 9603 * minibuf.c (Fread_buffer):
6e5bb2dc 9604 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9605 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9606 Don't assume string length fits in int.
9607
52c61c22 9608 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9609 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9610
b5b8c9e5
PE
9611 * font.c: Don't assume string length fits in int.
9612 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9613 Use ptrdiff_t, not int.
ccd6111c
PE
9614 (font_intern_prop): Don't assume string length fits in int.
9615 Don't assume integer property fits in fixnum.
9616 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9617
882f0d81 9618 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9619 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9620 Reformulate so as not to need the command string.
9621 Invoke gzip -cd rather than gunzip, as it's more portable.
9622 (lock_info_type, lock_file_1, lock_file):
9623 Don't assume pid_t and time_t fit in unsigned long.
9624 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9625 (current_lock_owner): Prefer signed type for sizes.
9626 Use memcpy, not strncpy, where memcpy is what is really wanted.
9627 Don't assume (via atoi) that time_t and pid_t fit in int.
9628 Check for time_t and/or pid_t out of range, e.g., via a network share.
9629 Don't alloca where an auto var works fine.
9630
93f4cf88
PE
9631 * fileio.c: Fix some integer overflow issues.
9632 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9633 Don't assume string length fits in int.
9634 (directory_file_name): Don't assume string length fits in long.
9635 (make_temp_name): Don't assume pid fits in int, or that its print
9636 length is less than 20.
9637
f3e92b69
PE
9638 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9639
1bfdaf10
PE
9640 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9641
35016e9a
PE
9642 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9643
3d1e65a1
PE
9644 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9645 We prefer signed integers, even for size calculations.
9646
0b963a93
PE
9647 * emacs.c: Don't assume string length fits in 'int'.
9648 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9649 (main): Don't invoke strlen when not needed.
9650
573f4b54
PE
9651 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9652 (XD_DEBUG_MESSAGE): Don't waste a byte.
9653
989f33ba
PE
9654 * callproc.c (getenv_internal_1, getenv_internal)
9655 (Fgetenv_internal):
965d34eb
PE
9656 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9657
e4d29b33
PE
9658 * lread.c (invalid_syntax): Omit length argument.
9659 All uses changed. This doesn't fix a bug, but it simplifies the
9660 code away from its former Hollerith-constant appearance, and it's
9661 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9662 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9663
eb49b136
PE
9664 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9665 This didn't break anything, but it didn't help either.
9666 It's confusing to put a bogus integer in a place where the actual
9667 value does not matter.
9f62aeb1 9668 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9669 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9670
15375a22
PE
9671 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9672 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9673 implementation.
b61cc01c
PE
9674 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9675 We prefer signed types, and the value cannot exceed the EMACS_INT
9676 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9677 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9678 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9679 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9680
53b2623d
PE
9681 * indent.c (sane_tab_width): New function.
9682 (current_column, scan_for_column, Findent_to, position_indentation)
9683 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9684 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9685
51cab52b 9686 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9687
f2ed8a70
PE
9688 * lisp.h (lint_assume): New macro.
9689 * composite.c (composition_gstring_put_cache):
9690 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9691
abe80cc6
PE
9692 * editfns.c, insdel.c:
9693 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9694
b02c740e
PE
9695 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9696
ebc96716
PE
9697 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9698
b4e50fa0 9699 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9700 Use much-faster test for byte-length change.
311d5d7c 9701 Don't assume string byte-length fits in 'int'.
a4cf38e4 9702 Check that character arg fits in 'int'.
85461888 9703 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9704
c0c1ee9f
PE
9705 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9706
a498d7f4
PE
9707 * fns.c (concat): Catch string overflow earlier.
9708 Do not rely on integer wraparound.
9709
51cab52b
PE
9710 * dispextern.h (struct it.overlay_strings_charpos)
9711 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9712 * xdisp.c (forward_to_next_line_start)
9713 (back_to_previous_visible_line_start)
9714 (reseat_at_next_visible_line_start, next_element_from_buffer):
9715 Don't arbitrarily truncate the value of 'selective' to int.
9716
76031fad
PE
9717 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9718
5eb55db9
PE
9719 * composite.c: Don't truncate sizes to 'int'.
9720 (composition_gstring_p, composition_reseat_it)
9721 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9722 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9723 not EMACS_UINT, for indexes.
5eb55db9 9724
0703a717
PE
9725 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9726
d6202519
PE
9727 * buffer.c: Include <verify.h>.
9728 (struct sortvec.priority, struct sortstr.priority):
8961a454 9729 Now EMACS_INT, not int.
c20998a7 9730 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9731 (struct sortstr.size, record_overlay_string)
9732 (struct sortstrlist.size, struct sortlist.used):
9733 Don't truncate size to int.
9734 (record_overlay_string): Check for size-calculation overflow.
d6202519 9735 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9736
d5a19415
JM
97372011-06-22 Jim Meyering <meyering@redhat.com>
9738
029529ac 9739 Don't leak an XBM-image-sized buffer
d5a19415
JM
9740 * image.c (xbm_load): Free the image buffer after using it.
9741
a9041e6c
PE
97422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9743
9744 Port to Sun C.
9745 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9746 that Sun C diagnosed.
9747 * fns.c (secure_hash): Fix pointer signedness issue.
9748 * intervals.c (static_offset_intervals): New function.
9749 (offset_intervals): Use it.
9750
7f3f739f
LL
97512011-06-21 Leo Liu <sdl.web@gmail.com>
9752
9753 * deps.mk (fns.o):
9754 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9755 sha512.h.
9756
9757 * fns.c (secure_hash): Rename from crypto_hash_function and change
9758 the first arg to accept symbols.
5b66d427 9759 (Fsecure_hash): New primitive.
7f3f739f
LL
9760 (syms_of_fns): New symbols.
9761
76147d94
DD
97622011-06-20 Deniz Dogan <deniz@dogan.se>
9763
9764 * process.c (Fset_process_buffer): Clarify return value in
9765 docstring.
9766
7d7d0045
CY
97672011-06-18 Chong Yidong <cyd@stupidchicken.com>
9768
9769 * dispnew.c (add_window_display_history): Use BVAR.
9770
9771 * xdisp.c (debug_method_add): Use BVAR.
9772 (check_window_end, dump_glyph_matrix, dump_glyph)
9773 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9774
9775 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9776 Likewise.
9777
9778 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9779 check till after the cache is created in init_frame_faces.
9780
ff2bc410
SM
97812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9782
9783 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9784
28177add
PE
97852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9786
dd3482fe
PE
9787 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9788 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9789 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9790
393d71f3 9791 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9792 * fileio.c (Finsert_file_contents):
9793 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9794 Remove the old (too-loose) buffer overflow checks.
9795 They weren't needed, since make_gap checks for buffer overflow.
9796 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9797 The old code merely checked for Emacs fixnum overflow, and relied
9798 on undefined (wraparound) behavior. The new code avoids undefined
9799 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9800
2e6813b0 9801 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9802 Tune. Don't use wider integers than needed. Don't use alloca.
9803 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9804
599a9e4f
PE
9805 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9806
99561444
PE
9807 * insdel.c, lisp.h (buffer_overflow): New function.
9808 (insert_from_buffer_1, replace_range, replace_range_2):
9809 * insdel.c (make_gap_larger):
9810 * editfns.c (Finsert_char):
9811 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9812
28177add
PE
9813 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9814
e69dafad
PE
98152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9816
4baa020d 9817 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9818
b1c46f02
PE
9819 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9820 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9821
e69dafad
PE
9822 * fileio.c: Don't assume EMACS_INT fits in off_t.
9823 (emacs_lseek): New static function.
9824 (Finsert_file_contents, Fwrite_region): Use it.
9825 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9826
566684ea
PE
9827 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9828
e6966cd6
PE
9829 * fns.c: Don't overflow int when computing a list length.
9830 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9831 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9832 truncation on 64-bit hosts. Check for QUIT every
9833 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9834 faster and is responsive enough.
9835 (Flength): Report an error instead of overflowing an integer.
9836 (Fsafe_length): Return a float if the value is not representable
9837 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9838 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9839 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9840
dd0b0efb
PE
9841 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9842 (header_size, word_size): New constants.
9843 (allocate_vectorlike): Don't check size overflow here.
9844 (allocate_vector): Check it here instead, since this is the only
9845 caller of allocate_vectorlike that could cause overflow.
9846 Check that the new vector's length is representable as a fixnum.
9847
86fe5cfe
PE
9848 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9849 The previous code was bogus. For example, next_almost_prime (32)
9850 returned 39, which is undesirable as it is a multiple of 3; and
9851 next_almost_prime (24) returned 25, which is a multiple of 5 so
9852 why was the code bothering to check for multiples of 7?
9853
80e88859
PE
9854 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9855
4a2f0ad6
PE
9856 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9857
f66c7cf8
PE
9858 Variadic C functions now count arguments with ptrdiff_t.
9859 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9860 Back then I didn't know that the Emacs coding style prefers signed int.
9861 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9862 were being counted with int, which may truncate counts on 64-bit
9863 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9864 * lisp.h (struct Lisp_Subr.function.aMANY)
9865 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9866 Arg counts are now ptrdiff_t, not size_t.
9867 All variadic functions and their callers changed accordingly.
9868 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9869 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9870 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9871 * callint.c (Fcall_interactively): Check arg count for overflow,
9872 to avoid potential buffer overrun. Use signed char, not 'int',
9873 for 'varies' array, so that we needn't bother to check its size
9874 calculation for overflow.
9875 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9876 * eval.c (apply_lambda):
9877 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9878 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9879 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9880
a1759b76
PE
9881 * callint.c (Fcall_interactively): Don't use index var as event count.
9882
d96be9fc
PE
9883 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9884 * mem-limits.h (SIZE): Remove; no longer used.
9885
a690a978 9886 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9887
578c21e6
PE
9888 Remove unnecessary casts.
9889 * xterm.c (x_term_init):
9890 * xfns.c (x_set_border_pixel):
9891 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9892 These aren't needed now that we assume ANSI C.
9893
96f53c6c
PE
9894 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9895 It's more likely to cause problems (due to unsigned overflow)
9896 than to cure them.
9897
83c77d31
PE
9898 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9899
ee2079f1
PE
9900 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9901
6da65536
PE
9902 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9903
7147c4a4
PE
9904 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9905
193e32d9
PE
9906 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9907
e5533da6
PE
9908 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9909
9910e595
PE
9910 GLYPH_CODE_FACE returns EMACS_INT, not int.
9911 * dispextern.h (merge_faces):
9912 * xfaces.c (merge_faces):
01103c44
PE
9913 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9914 Don't assume EMACS_INT fits in int.
9910e595 9915
2638320e
PE
9916 * character.h (CHAR_VALID_P): Remove unused parameter.
9917 * fontset.c, lisp.h, xdisp.c: All uses changed.
9918
045eb8d9
PE
9919 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9920
c1f134b5
PE
9921 * fns.c (concat): Minor tuning based on overflow analysis.
9922 This doesn't fix any bugs. Use int to hold character, instead
9923 of constantly refetching from Emacs object. Use XFASTINT, not
9924 XINT, for value known to be a character. Don't bother comparing
9925 a single byte to 0400, as it's always less.
9926
395fcb93 9927 * floatfns.c (Fexpt):
327eeec8
PE
9928 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9929
abbd3d23
PE
9930 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9931 for characters.
9932
684a03ef
PE
9933 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9934
0fed43f3
PE
9935 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9936 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9937 incorrectly succeed when S was a string, because 4294967386 was
9938 truncated before it was used.
9939
8fd02eb7
PE
9940 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9941 Otherwise, an out-of-range integer could cause undefined behavior
9942 on a 64-bit host.
9943
f8c86b69
PE
9944 * composite.c: Use int, not EMACS_INT, for characters.
9945 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9946 EMACS_INT, for values that are known to be in character range.
9947 This doesn't fix any bugs but is the usual style inside Emacs and
9948 may generate better code on 32-bit machines.
9949
34206dd2
PE
9950 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9951 This is for reasons similar to the recent CHAR_STRING fix.
9952 * charset.c (Fencode_char): Check that character arg is actually
9953 a character. Pass an int to ENCODE_CHAR.
9954 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9955 wider than 'int', as a compile-time check to prevent future regressions
9956 in this area.
9957
c5958d4c 9958 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9959
9960 Make sure a 64-bit char is never passed to CHAR_STRING.
9961 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9962 by silently ignoring the top 32 bits, allowing some values
9963 that were far too large to be valid characters.
9964 * character.h: Include <verify.h>.
9965 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9966 arguments are no wider than unsigned, as a compile-time check
9967 to prevent future regressions in this area.
9968 * data.c (Faset):
01103c44 9969 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9970 (Fsubst_char_in_region):
9971 * fns.c (concat):
9972 * xdisp.c (decode_mode_spec_coding):
9973 Adjust to CHAR_STRING's new requirement.
9974 * editfns.c (Finsert_char, Fsubst_char_in_region):
9975 * fns.c (concat): Check that character args are actually
9976 characters. Without this test, these functions did the wrong
9977 thing with wildly out-of-range values on 64-bit hosts.
9978
d37ca623
PE
9979 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9980 These casts should not be needed on 32-bit hosts, either.
9981 * keyboard.c (read_char):
9982 * lread.c (Fload): Remove casts to unsigned.
9983
ea204efb
PE
9984 * lisp.h (UNSIGNED_CMP): New macro.
9985 This fixes comparison bugs on 64-bit hosts.
9986 (ASCII_CHAR_P): Use it.
9987 * casefiddle.c (casify_object):
01103c44 9988 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9989 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9990 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9991 * dispextern.h (FACE_FROM_ID):
9992 * keyboard.c (read_char): Use UNSIGNED_CMP.
9993
41cb286c
PE
9994 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9995 not to EMACS_INT, to avoid GCC warning.
9996
4a1b9832
PE
9997 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9998
55daad71
PE
9999 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10000 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10001 isn't needed on 32-bit machines.
8f95c75c 10002
01103c44
PE
10003 * buffer.c (Fgenerate_new_buffer_name):
10004 Use EMACS_INT for count, not int.
0ceccced 10005 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10006
10007 * data.c (Qcompiled_function): Now static.
10008
c6f072e7
PE
10009 * window.c (window_body_lines): Now static.
10010
20ce5912
PE
10011 * image.c (gif_load): Rename local to avoid shadowing.
10012
9c4c5f81
PE
10013 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10014 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10015 * alloc.c (make_save_value): Integer argument is now of type
10016 ptrdiff_t, not int.
10017 (mark_object): Use ptrdiff_t, not int.
10018 * lisp.h (pD): New macro.
10019 * print.c (print_object): Use it.
10020
c0c5c8ae
PE
10021 * alloc.c: Use EMACS_INT, not int, to count objects.
10022 (total_conses, total_markers, total_symbols, total_vector_size)
10023 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10024 (total_free_floats, total_floats, total_free_intervals)
10025 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10026 Now EMACS_INT, not int. All uses changed.
10027 (Fgarbage_collect): Compute overall total using a double, so that
10028 integer overflow is less likely to be a problem. Check for overflow
10029 when converting back to an integer.
5a25e253
PE
10030 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10031 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10032 These were 'int' variables that could overflow on 64-bit hosts;
10033 they were never used, so remove them instead of repairing them.
211a0b2a 10034 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10035 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10036 Previously, this ceilinged at INT_MAX, but that doesn't work on
10037 64-bit machines.
e46bb31a 10038 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10039
c78baabf 10040 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10041 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10042 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10043 when a (possibly-narrower) signed value would do just as well.
10044 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10045
c9d624c6
PE
10046 * alloc.c: Catch some string size overflows that we were missing.
10047 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10048 for convenience in STRING_BYTES_MAX.
10049 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10050 The definition here is exact; the one in lisp.h was approximate.
10051 (allocate_string_data): Check for string overflow. This catches
10052 some instances we weren't catching before. Also, it catches
10053 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10054 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10055 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10056
c9d624c6
PE
10057 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10058 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10059 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10060
353032ce
PE
10061 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10062
2bccce07
PE
10063 * alloc.c (Fmake_string): Check for out-of-range init.
10064
0ac30604
SM
100652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10066
10067 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10068
c195f2de
JD
100692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10070
10071 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10072 xg_get_default_scrollbar_width.
10073
10074 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10075 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10076 (style_changed_cb): Call update_theme_scrollbar_width and call
10077 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10078 all frames (Bug#8505).
10079 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10080 Call gtk_window_set_resizable if HAVE_GTK3.
10081 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10082 and height if HAVE_GTK3 (Bug#8505).
10083 (scroll_bar_width_for_theme): New variable.
10084 (update_theme_scrollbar_width): New function.
10085 (xg_get_default_scrollbar_width): Move code to
10086 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10087 (xg_initialize): Call update_theme_scrollbar_width.
10088
10089 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10090
10091 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10092
e10ac9f1
MR
100932011-06-12 Martin Rudalics <rudalics@gmx.at>
10094
10095 * frame.c (make_frame): Call other_buffer_safely instead of
10096 other_buffer.
10097
10098 * window.c (temp_output_buffer_show): Call display_buffer with
10099 second argument Vtemp_buffer_show_specifiers and reset latter
10100 immediately after the call.
10101 (Vtemp_buffer_show_specifiers): New variable.
10102 (auto_window_vscroll_p, next_screen_context_lines)
10103 (Vscroll_preserve_screen_position): Remove leading asterisks from
10104 doc-strings.
10105
2d3c217e 101062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10107
7b7f97e8 10108 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10109 * buffer.c (Qclone_number): Remove for now, as it's unused.
10110 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10111 (record_buffer): Remove unused local.
10112 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10113 (set_frame_buffer_list): Remove; unused.
10114 * frame.h (other_visible_frames): Remove decl.
10115 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10116 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10117 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10118 if HAVE_GPM.
10119 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10120 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10121 Define only if HAVE_GPM.
10122 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10123 (update_hints_inhibit): Remove; never set. All uses removed.
10124 * widgetprv.h (emacsFrameClassRec): Remove decl.
10125 * window.c (delete_deletable_window): Now returns void, since it
10126 wasn't returning anything.
10127 (compare_window_configurations): Remove unused locals.
10128 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10129 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10130 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10131 the same widths as pointers. This follows up on the 2011-05-06 patch.
10132 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10133 * xterm.h: Likewise.
10134 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10135
1384b89e
JB
101362011-06-12 Juanma Barranquero <lekktu@gmail.com>
10137
10138 * makefile.w32-in: Update dependencies.
10139 (LISP_H): Add lib/intprops.h.
10140
1100a63c
CY
101412011-06-11 Chong Yidong <cyd@stupidchicken.com>
10142
10143 * image.c (gif_load): Add animation frame delay to the metadata.
10144 (syms_of_image): Use DEFSYM. New symbol `delay'.
10145
6198ccd0
MR
101462011-06-11 Martin Rudalics <rudalics@gmx.at>
10147
10148 * window.c (delete_deletable_window): Re-add.
10149 (Fset_window_configuration): Rewrite to handle dead buffers and
10150 consequently deletable windows.
10151 (window_tree, Fwindow_tree): Remove. Supply functionality in
10152 window.el.
10153 (compare_window_configurations): Simplify code.
10154
b6e3633c
AS
101552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10156
1ab0dee5
AS
10157 * image.c (imagemagick_load_image): Fix type mismatch.
10158 (Fimagemagick_types): Likewise.
10159
b6e3633c
AS
10160 * window.h (replace_buffer_in_windows): Declare.
10161
9397e56f
MR
101622011-06-11 Martin Rudalics <rudalics@gmx.at>
10163
10164 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10165 Qclone_number. Remove external declaration of Qdelete_window.
10166 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10167 code.
640c8776
SM
10168 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10169 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10170 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10171 buffer list implementation.
10172 (other_buffer_safely): New function.
10173 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10174 calls to replace_buffer_in_windows and
10175 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10176 if allowed.
10177 (record_buffer): Inhibit quitting and rewrite using quittable
10178 functions. Run Qbuffer_list_update_hook if allowed.
10179 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10180 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10181 Move switch-to-buffer to window.el.
9397e56f
MR
10182 (bury-buffer): Move to window.el.
10183 (Vbuffer_list_update_hook): New variable.
10184
10185 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10186 section.
10187
10188 * window.h (resize_frame_windows): Move up in code.
10189 (Fwindow_frame): Remove EXFUN.
10190 (replace_buffer_in_all_windows): Remove prototype.
10191 (replace_buffer_in_windows_safely): Add prototype.
10192
10193 * window.c: Declare Qdelete_window static again. Move down
10194 declaration of select_count.
10195 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10196 (Fother_window): Move to window.el.
10197 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10198 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10199 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10200 window.el.
10201 (replace_buffer_in_windows): Implement by calling
10202 Qreplace_buffer_in_windows.
10203 (replace_buffer_in_all_windows): Remove with some functionality
10204 moved into replace_buffer_in_windows_safely.
10205 (replace_buffer_in_windows_safely): New function.
10206 (select_window_norecord, select_frame_norecord): Move in front
10207 of run_window_configuration_change_hook. Remove now obsolete
10208 declarations.
640c8776
SM
10209 (Fset_window_buffer): Rewrite doc-string.
10210 Call Qrecord_window_buffer.
9397e56f
MR
10211 (keys_of_window): Move binding for other-window to window.el.
10212
b50691aa
CY
102132011-06-11 Chong Yidong <cyd@stupidchicken.com>
10214
10215 * dispextern.h (struct image): Replace data member, whose int_val
10216 and ptr_val fields were not used by anything, with a single
10217 lisp_val object.
10218
10219 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10220 (gif_clear_image, gif_load, imagemagick_load_image)
10221 (gs_clear_image, gs_load): Callers changed.
10222
3f754b86
PE
102232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10224
cca69397
PE
10225 * buffer.h: Include <time.h>, for time_t.
10226 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10227
109e28d0
PE
10228 Fix minor problems found by static checking.
10229
60737f02
PE
10230 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10231
4b66faf3
PE
10232 Make identifiers static if they are not used in other modules.
10233 * data.c (Qcompiled_function, Qframe, Qvector):
10234 * image.c (QimageMagick, Qsvg):
10235 * minibuf.c (Qmetadata):
10236 * window.c (resize_window_check, resize_root_window): Now static.
10237 * window.h (resize_window_check, resize_root_window): Remove decls.
10238
109e28d0
PE
10239 * window.c (window_deletion_count, delete_deletable_window):
10240 Remove; unused.
46a4ce9e
PE
10241 (window_body_lines): Now static.
10242 (Fdelete_other_windows_internal): Mark vars as initialized.
10243 Make sure 'resize_failed' is initialized.
10244 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10245 (resize_window_apply): Remove unused local.
10246 * window.h (delete_deletable_window): Remove decl.
10247
109e28d0 10248 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10249 (imagemagick_load_image): Fix pointer signedness problem by changing
10250 last arg from unsigned char * to char *. All uses changed.
10251 Also, fix a local for similar reasons.
10252 Remove unused locals. Remove locals to avoid shadowing.
10253 (fn_rsvg_handle_free): Remove; unused.
10254 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10255 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10256
3f754b86
PE
10257 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10258
2547adb1
CY
102592011-06-10 Chong Yidong <cyd@stupidchicken.com>
10260
10261 * image.c (gif_load): Fix omitted cast error introduced by
10262 2011-06-06 change.
10263
2c8e37d4
MR
102642011-06-10 Martin Rudalics <rudalics@gmx.at>
10265
10266 * window.h (resize_proportionally, orig_total_lines)
10267 (orig_top_line): Remove from window structure.
10268 (set_window_height, set_window_width, change_window_heights)
10269 (Fdelete_window): Remove prototypes.
10270 (resize_frame_windows): Remove duplicate declaration.
10271
440a42e3
EZ
102722011-06-10 Eli Zaretskii <eliz@gnu.org>
10273
10274 * window.h (resize_frame_windows, resize_window_check)
10275 (delete_deletable_window, resize_root_window)
10276 (resize_frame_windows): Declare prototypes.
10277
10278 * window.c (resize_window_apply): Make definition be "static" to
10279 match the prototype.
10280
562dd5e9
MR
102812011-06-10 Martin Rudalics <rudalics@gmx.at>
10282
10283 * window.c: Remove declarations of Qwindow_size_fixed,
10284 window_min_size_1, window_min_size_2, window_min_size,
10285 size_window, window_fixed_size_p, enlarge_window, delete_window.
10286 Remove static from declaration of Qdelete_window, it's
10287 temporarily needed by Fbury_buffer.
10288 (replace_window): Don't assign orig_top_line and
10289 orig_total_lines.
10290 (Fdelete_window, delete_window): Remove. Window deletion is
10291 handled by window.el.
640c8776
SM
10292 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10293 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10294 (Fdelete_other_windows): Remove. Deleting other windows is
10295 handled by window.el.
10296 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10297 handled in window.el.
10298 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10299 Window minimum sizes are handled in window.el.
10300 (shrink_windows, size_window, set_window_height)
10301 (set_window_width, change_window_heights, window_height)
10302 (window_width, CURBEG, CURSIZE, enlarge_window)
10303 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10304 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10305 handled in window.el.
10306 (make_dummy_parent): Rename to make_parent_window and give it a
10307 second argument horflag.
10308 (make_window): Don't set resize_proportionally any more.
10309 (Fsplit_window): Remove. Windows are split in window.el.
10310 (save_restore_action, save_restore_orig_size)
10311 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10312 Resize mini windows in window.el.
10313 (grow_mini_window, shrink_mini_window): Implement by calling
10314 Qresize_root_window_vertically, resize_window_check and
10315 resize_window_apply.
640c8776
SM
10316 (saved_window, Fset_window_configuration, save_window_save):
10317 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10318 resize_proportionally.
10319 (window_min_height, window_min_width): Move to window.el.
10320 (keys_of_window): Move bindings for delete-other-windows,
10321 split-window, delete-window and enlarge-window to window.el.
10322
10323 * buffer.c: Temporarily extern Qdelete_window.
10324 (Fbury_buffer): Temporarily call Qdelete_window instead of
10325 Fdelete_window (Fbury_buffer will move to window.el soon).
10326
10327 * frame.c (set_menu_bar_lines_1): Remove code handling
10328 orig_top_line and orig_total_lines.
10329
10330 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10331 set_window_height but set heights directly.
10332 (change_frame_size_1): Use resize_frame_windows.
10333
10334 * xdisp.c (init_xdisp): Don't use set_window_height but set
10335 heights directly.
10336
640c8776
SM
10337 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10338 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10339 run_window_configuration_change_hook.
10340
10341 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10342 instead of change_window_heights and run
10343 run_window_configuration_change_hook.
10344
1a13852e
MR
103452011-06-09 Martin Rudalics <rudalics@gmx.at>
10346
10347 * window.c (replace_window): Rename second argument REPLACEMENT to
10348 NEW. New third argument SETFLAG. Rewrite.
10349 (delete_window, make_dummy_parent): Call replace_window with
10350 third argument 1.
10351 (window_list_1): Move down in code.
10352 (run_window_configuration_change_hook): Move set_buffer part
10353 before select_frame_norecord part in order to unwind correctly.
10354 Rename count1 to count.
10355 (recombine_windows, delete_deletable_window, resize_root_window)
10356 (Fdelete_other_windows_internal)
10357 (Frun_window_configuration_change_hook, make_parent_window)
10358 (resize_window_check, resize_window_apply, Fresize_window_apply)
10359 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10360 (Fdelete_window_internal, Fresize_mini_window_internal):
10361 New functions.
1a13852e
MR
10362 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10363
f3d1777e
MR
103642011-06-08 Martin Rudalics <rudalics@gmx.at>
10365
496e208e
MR
10366 * window.h (window): Add some new members to window structure -
10367 normal_lines, normal_cols, new_total, new_normal, clone_number,
10368 splits, nest, prev_buffers, next_buffers.
10369 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10370 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10371
f3d1777e
MR
10372 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10373 Remove.
496e208e
MR
10374 (make_dummy_parent): Set new members of windows structure.
10375 (make_window): Move down in code. Handle new members of window
10376 structure.
10377 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10378 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10379 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10380 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10381 (Fset_window_next_buffers, Fset_window_clone_number):
10382 New functions.
496e208e
MR
10383 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10384 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10385 Doc-string fixes.
10386 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10387 Argument WINDOW can be now internal window too.
10388 (Fwindow_use_time): Move up in code.
10389 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10390 Rewrite doc-string.
10391 (Fset_window_configuration, saved_window)
10392 (Fcurrent_window_configuration, save_window_save): Handle new
10393 members of window structure.
b9e809c2
MR
10394 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10395 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10396 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10397 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10398 Qget_mru_window, Qresize_root_window,
10399 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10400 Qauto_buffer_name; staticpro them.
f3d1777e 10401
abde8f8c
MR
104022011-06-07 Martin Rudalics <rudalics@gmx.at>
10403
10404 * window.c (Fwindow_total_size, Fwindow_left_column)
10405 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10406 (Fwindow_list_1): New functions.
10407 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10408 (Fwindow_width, Fscroll_left, Fscroll_right):
10409 Use window_body_cols instead of window_box_text_cols.
10410 (delete_window, Fset_window_configuration):
10411 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10412 (delete_all_subwindows): Take a window as argument and not a
10413 structure. Rewrite.
190b47e6
MR
10414 (window_loop): Remove handling of GET_LRU_WINDOW and
10415 GET_LARGEST_WINDOW.
10416 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10417
10418 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10419 window_box_text_cols. delete_all_subwindows now takes a
10420 Lisp_Object as argument.
abde8f8c 10421
640c8776
SM
10422 * indent.c (compute_motion, Fcompute_motion):
10423 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10424
fa8a67e6
MR
10425 * frame.c (delete_frame): Call delete_all_subwindows with root
10426 window as argument.
10427
a54e3482
DC
104282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10429
10430 * fns.c (Fputhash): Document return value.
10431
60002bf5
CY
104322011-06-06 Chong Yidong <cyd@stupidchicken.com>
10433
10434 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10435
0c671da6 104362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10437
b862a52a 10438 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10439
be44ca6c
PE
10440 Check for overflow when converting integer to cons and back.
10441 * charset.c (Fdefine_charset_internal, Fdecode_char):
10442 Use cons_to_unsigned to catch overflow.
10443 (Fencode_char): Use INTEGER_TO_CONS.
10444 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10445 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10446 * data.c (long_to_cons, cons_to_long): Remove.
10447 (cons_to_unsigned, cons_to_signed): New functions.
10448 These signal an error for invalid or out-of-range values.
10449 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10450 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10451 * font.c (Ffont_variation_glyphs):
10452 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10453 * lisp.h: Include <intprops.h>.
10454 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10455 (cons_to_signed, cons_to_unsigned): New decls.
10456 (long_to_cons, cons_to_long): Remove decls.
10457 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10458 (Fprimitive_undo): Use CONS_TO_INTEGER.
10459 * xfns.c (Fx_window_property): Likewise.
10460 * xselect.c: Include <limits.h>.
10461 (x_own_selection, selection_data_to_lisp_data):
10462 Use INTEGER_TO_CONS.
10463 (x_handle_selection_request, x_handle_selection_clear)
10464 (x_get_foreign_selection, Fx_disown_selection_internal)
10465 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10466 (lisp_data_to_selection_data): Use cons_to_unsigned.
10467 (x_fill_property_data): Use cons_to_signed.
10468 Report values out of range.
10469
d1f3d2af
PE
10470 Check for buffer and string overflow more precisely.
10471 * buffer.h (BUF_BYTES_MAX): New macro.
10472 * lisp.h (STRING_BYTES_MAX): New macro.
10473 * alloc.c (Fmake_string):
10474 * character.c (string_escape_byte8):
10475 * coding.c (coding_alloc_by_realloc):
10476 * doprnt.c (doprnt):
10477 * editfns.c (Fformat):
10478 * eval.c (verror):
10479 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10480 since they may not be the same number.
10481 * editfns.c (Finsert_char):
10482 * fileio.c (Finsert_file_contents):
10483 Likewise for BUF_BYTES_MAX.
10484
dd52fcea
PE
10485 * image.c: Use ptrdiff_t, not int, for sizes.
10486 (slurp_file): Switch from int to ptrdiff_t.
10487 All uses changed.
10488 (slurp_file): Check that file size fits in both size_t (for
10489 malloc) and ptrdiff_t (for sanity and safety).
10490
7f9bbdbb
PE
10491 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10492 if b->modtime has its maximal value.
10493
dfe18f82
PE
10494 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10495
84acfcf0
PE
10496 Don't assume time_t can fit into int.
10497 * buffer.h (struct buffer.modtime): Now time_t, not int.
10498 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10499 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10500
ccd9a01a
PE
10501 Minor fixes for signed vs unsigned integers.
10502 * character.h (MAYBE_UNIFY_CHAR):
10503 * charset.c (maybe_unify_char):
10504 * keyboard.c (read_char, reorder_modifiers):
10505 XINT -> XFASTINT, since the integer must be nonnegative.
10506 * ftfont.c (ftfont_spec_pattern):
10507 * keymap.c (access_keymap, silly_event_symbol_error):
10508 XUINT -> XFASTINT, since the integer must be nonnegative.
10509 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10510 since it makes no difference and we prefer signed.
10511 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10512 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10513 nonnegative.
10514
d6d100dd
SM
105152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10516
10517 * window.h (Fwindow_frame): Declare.
10518
2b6148e4
PE
105192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10520
10521 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10522 (SPARE_MEMORY): Always define.
10523 (LARGE_REQUEST): Remove.
10524 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10525
f230ecc9
MR
105262011-06-06 Martin Rudalics <rudalics@gmx.at>
10527
727e958e
MR
10528 * lisp.h: Move EXFUNS for Fframe_root_window,
10529 Fframe_first_window and Fset_frame_selected_window to window.h.
10530
10531 * window.h: Move EXFUNS for Fframe_root_window,
10532 Fframe_first_window and Fset_frame_selected_window here from
10533 lisp.h.
10534
10535 * frame.c (Fwindow_frame, Fframe_first_window)
10536 (Fframe_root_window, Fframe_selected_window)
10537 (Fset_frame_selected_window): Move to window.c.
10538 (Factive_minibuffer_window): Move to minibuf.c.
10539 (Fother_visible_frames_p): New function.
10540
10541 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10542
f230ecc9
MR
10543 * window.c (decode_window, decode_any_window): Move up in code.
10544 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10545 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10546 (Fwindow_buffer): Move up and rewrite doc-string.
10547 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10548 (Fwindow_prev): New functions.
727e958e
MR
10549 (Fwindow_frame): Move here from frame.c. Accept any window as
10550 argument.
10551 (Fframe_root_window, Fframe_first_window)
10552 (Fframe_selected_window): Move here from frame.c. Accept frame
10553 or arbitrary window as argument. Update doc-strings.
10554 (Fminibuffer_window): Move up in code.
10555 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10556 (Fset_frame_selected_window): Move here from frame.c.
10557 Marginal rewrite.
727e958e
MR
10558 (Fselected_window, select_window, Fselect_window): Move up in
10559 code. Minor doc-string fixes.
f230ecc9 10560
4d09bcf6
PE
105612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10562
10563 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10564 Do not assume that spare memory exists; that assumption is valid
10565 only if SYSTEM_MALLOC.
10566 (LARGE_REQUEST): New macro, so that the issue of large requests
10567 is separated from the issue of spare memory.
10568
810928a2
AS
105692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10570
172418ad
AS
10571 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10572 format. (Bug#8806)
10573
43f862f7
AS
10574 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10575
810928a2
AS
10576 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10577 before statements.
10578
a059fe24
JD
105792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10580
10581 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10582
10583 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10584
10585 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10586 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10587
989bf368
JB
105882011-06-05 Juanma Barranquero <lekktu@gmail.com>
10589
10590 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10591
4b80f674
CY
105922011-06-04 Chong Yidong <cyd@stupidchicken.com>
10593
10594 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10595 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10596 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10597 New error handlers.
4b80f674
CY
10598 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10599 Obey Vx_select_enable_clipboard_manager. Catch errors in
10600 x_clipboard_manager_save (Bug#8779).
10601 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10602 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10603
99a33b77 106042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10605
10606 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10607
99a33b77 106082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10609
10610 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10611 in the current matrix if keep_current_p is non-zero.
10612
8264569d
EZ
106132011-06-04 Eli Zaretskii <eliz@gnu.org>
10614
10615 * bidi.c (bidi_level_of_next_char): Fix last change.
10616
57f97249
EZ
106172011-06-03 Eli Zaretskii <eliz@gnu.org>
10618
fec2107c 10619 Support bidi reordering of text covered by display properties.
57f97249 10620
fec2107c
EZ
10621 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10622 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10623 (bidi_cache_search, bidi_cache_iterator_state)
10624 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10625 (bidi_level_of_next_char, bidi_move_to_visually_next):
10626 Support character positions inside a run of characters covered by a
fec2107c
EZ
10627 display string.
10628 (bidi_paragraph_init, bidi_resolve_explicit_1)
10629 (bidi_level_of_next_char): Call bidi_fetch_char and
10630 bidi_fetch_char_advance instead of FETCH_CHAR and
10631 FETCH_CHAR_ADVANCE.
10632 (bidi_init_it): Initialize new members.
10633 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10634 definitions.
10635 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10636 instead of using explicit *_CHAR codes.
d6d100dd
SM
10637 (bidi_resolve_explicit, bidi_resolve_weak):
10638 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10639 bidirectional text is supported only in multibyte buffers.
10640 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10641 it to initialize the frame_window_p member of struct bidi_it.
10642 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10643 (bidi_resolve_explicit, bidi_resolve_weak)
10644 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10645 bidi_it->nchars is non-positive.
10646 (bidi_level_of_next_char): Don't try to lookup the cache for the
10647 next/previous character if nothing is cached there yet, or if we
10648 were just reseat()'ed to a new position.
c40e2fb2 10649
0e14fe90
EZ
10650 * xdisp.c (set_cursor_from_row): Set start and stop points
10651 according to the row's direction when priming the loop that looks
10652 for the glyph on which to display cursor.
10653 (single_display_spec_intangible_p): Function deleted.
10654 (display_prop_intangible_p): Reimplement to call
10655 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10656 Accept 3 additional arguments needed by handle_display_spec.
10657 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10658 values: lists, `(when COND...)' forms, etc.
10659 (single_display_spec_string_p): Support property values that are
10660 lists with the argument STRING its top-level element.
10661 (display_prop_string_p): Fix the condition for processing a
10662 property that is a list to be consistent with handle_display_spec.
fec2107c 10663 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10664 last portion of handle_display_prop.
10665 (compute_display_string_pos): Accept additional argument
10666 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10667 value of a `display' property is a "replacing spec".
10668 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10669 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10670 the display property, but just return a value indicating whether
10671 the display property will replace the characters it covers.
10672 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10673 frame_window_p members of struct bidi_it.
d6d100dd
SM
10674 (compute_display_string_pos, compute_display_string_end):
10675 New functions.
fec2107c
EZ
10676 (push_it): Accept second argument POSITION, where pop_it should
10677 jump to continue iteration.
10678 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10679
fec2107c
EZ
10680 * keyboard.c (adjust_point_for_property): Adjust the call to
10681 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10682
10683 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10684 (bidi_init_it): Update prototypes.
10685 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10686 (compute_display_string_pos, compute_display_string_end):
10687 Declare prototypes.
fec2107c
EZ
10688 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10689 EMACS_INT.
fc6f18ce 10690
40087514 106912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10692
57f53182
PE
10693 Malloc failure behavior now depends on size of allocation.
10694 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10695 * lisp.h: Change signatures accordingly.
10696 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10697 All callers changed. (Bug#8762)
10698
10699 * gnutls.c: Use Emacs's memory allocators.
10700 Without this change, the gnutls library would invoke malloc etc.
10701 directly, which causes problems on non-SYNC_INPUT hosts, and which
10702 runs afoul of improving memory_full behavior. (Bug#8761)
10703 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10704 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10705 xfree instead of the default malloc, realloc, free.
10706 (Fgnutls_boot): No need to check for memory allocation failure,
10707 since xmalloc does that for us.
10708
ac32cd99 10709 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10710 * category.c (hash_get_category_set):
10711 * ccl.c (ccl_driver):
10712 * charset.c (Fdefine_charset_internal):
10713 * charset.h (struct charset.hash_index):
10714 * composite.c (get_composition_id, gstring_lookup_cache)
10715 (composition_gstring_put_cache):
10716 * composite.h (struct composition.hash_index):
10717 * dispextern.h (struct image.hash):
10718 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10719 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10720 (hashfn_equal, hashfn_user_defined, make_hash_table)
10721 (maybe_resize_hash_table, hash_lookup, hash_put)
10722 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10723 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10724 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10725 * image.c (make_image, search_image_cache, lookup_image)
10726 (xpm_put_color_table_h):
10727 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10728 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10729 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10730 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10731 * alloc.c (allocate_vectorlike):
10732 Check for overflow in vector size calculations.
10733 * ccl.c (ccl_driver):
10734 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10735 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10736 need to be updated by these changes.
40087514
PE
10737 * fns.c (make_hash_table, maybe_resize_hash_table):
10738 Check for integer overflow with large hash tables.
0de4bb68
PE
10739 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10740 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10741 (SXHASH_REDUCE): New macro.
10742 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10743 Use it instead of discarding useful hash info with large hash values.
10744 (sxhash_float): New function.
10745 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10746 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10747 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10748 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10749 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10750 Adjust signatures to match updated version of code.
10751 (consing_since_gc): Now EMACS_INT, since a single hash table can
10752 use more than INT_MAX bytes.
10753
698d32e2
DN
107542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10755
10756 Make it possible to build with GCC-4.6+ -O2 -flto.
10757
10758 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10759
fd6fa53f
SM
107602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10761
10762 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10763 Call minibuffer-inactive-mode.
10764
864db017
JB
107652011-05-31 Juanma Barranquero <lekktu@gmail.com>
10766
10767 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10768 Update dependencies.
10769
2ad0baf4
DN
107702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10771
10772 * data.c (init_data): Remove code for UTS, this system is not
10773 supported anymore.
10774
4fcc2638
DN
107752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10776
10777 Don't force ./temacs to start in terminal mode.
10778
10779 * frame.c (make_initial_frame): Initialize faces in all cases, not
10780 only when CANNOT_DUMP is defined.
10781 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10782
c56e0fd5
DN
107832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10784
10785 * dispnew.c (add_window_display_history): Use const for the string
10786 pointer. Remove declaration, not needed.
10787
333d54da 107882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10789
55d4c1b2 10790 Use 'inline', not 'INLINE'.
333d54da 10791 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10792 * alloc.c, fontset.c (INLINE): Remove.
10793 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10794 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10795 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10796 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10797 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10798
738db178
DN
107992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10800
10801 Make it possible to run ./temacs.
10802
10803 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10804 syms_of_callproc does the same thing. Remove test for
10805 "initialized", do it in the caller.
10806 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10807
620c53a6
SM
108082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10809
10810 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10811 (read_minibuf): Use get_minibuffer.
10812 (syms_of_minibuf): Use DEFSYM.
10813 (Qmetadata): New var.
10814 * data.c (Qbuffer): Don't make it static.
10815 (syms_of_data): Use DEFSYM.
10816
e003a292
PE
108172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10818
10819 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10820 (CCL_CODE_MIN): New macro.
10821
ed008a6d
PE
108222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10823
3687c2ef
PE
10824 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10825
ed008a6d
PE
10826 * eval.c (Qdebug): Now static.
10827 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10828 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10829 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10830
d66c4c7c
CY
108312011-05-29 Chong Yidong <cyd@stupidchicken.com>
10832
10833 * image.c: Various fixes to ImageMagick code comments.
10834 (Fimagemagick_types): Doc fix.
10835
5fbc2025
PE
108362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10837
0196f88a
PE
10838 Minor fixes prompted by GCC 4.6.0 warnings.
10839
10840 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10841
5fbc2025
PE
10842 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10843 (x_clipboard_manager_save_all): Move extern decl to ...
10844 * xterm.h: ... here, so that it can be checked for consistency.
10845
1dd3c2d9
CY
108462011-05-29 Chong Yidong <cyd@stupidchicken.com>
10847
10848 * xselect.c (x_clipboard_manager_save_frame)
10849 (x_clipboard_manager_save_all): New functions.
10850 (Fx_clipboard_manager_save): Lisp function deleted.
10851
10852 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10853 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10854
10855 * xterm.h: Update prototype.
10856
5ba6571d
WX
108572011-05-28 William Xu <william.xwl@gmail.com>
10858
10859 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10860 exiting (Bug#8239).
10861
3eaff834
JM
108622011-05-28 Jim Meyering <meyering@redhat.com>
10863
e1900994 10864 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10865 * fns.c (to_uchar): Define.
10866 (crypto_hash_function): Use it to convert some newly-signed
10867 variables to unsigned, to avoid sign-extension bugs. For example,
10868 without this change, (md5 "truc") would evaluate to
10869 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10870 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10871 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10872
0f6990a7
PE
108732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10874
10875 Integer overflow fixes.
c8a9ca5a 10876
08686060
PE
10877 * dbusbind.c: Serial number integer overflow fixes.
10878 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10879 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10880 to hold a serial number that is too large for a fixnum.
10881 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10882 Check for serial numbers out of range. Decode any serial number
59568bf0 10883 that was so large that it became a float. (Bug#8722)
08686060 10884
2d1fc3c7
PE
10885 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10886 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10887 Use XFASTINT rather than XUINT when numbers are nonnegative.
10888 (xd_append_arg, Fdbus_method_return_internal):
10889 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10890 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10891 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10892 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10893 (Bug#8722)
2d1fc3c7 10894
c8a9ca5a
PE
10895 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10896
519e1d69
PE
10897 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10898
6df6ae42 10899 ccl: Add integer overflow checks.
30569699
PE
10900 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10901 (IN_INT_RANGE): New macros.
10902 (ccl_driver): Use them to check for integer overflow when
10903 decoding a CCL program. Many of the new checks are whether XINT (x)
10904 fits in int; it doesn't always, on 64-bit hosts. The new version
10905 doesn't catch all possible integer overflows, but it's an
847044ea 10906 improvement. (Bug#8719)
30569699 10907
c11285dc
PE
10908 * alloc.c (make_event_array): Use XINT, not XUINT.
10909 There's no need for unsigned here.
10910
fdccd48e
PE
10911 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10912 This follows up to the 2011-05-06 change that substituted uintptr_t
10913 for EMACS_INT. This case wasn't caught back then.
10914
37910ab2
PE
10915 Rework Fformat to avoid integer overflow issues.
10916 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10917 now (part of C89). Include <verify.h>.
10918 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10919 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10920 (Fformat): Avoid the prepass trying to compute sizes; it was only
10921 approximate and thus did not catch overflow reliably. Instead, walk
10922 through the format just once, formatting and computing sizes as we go,
10923 checking for integer overflow at every step, and allocating a larger
10924 buffer as needed. Keep track separately whether the format is
10925 multibyte. Keep only the most-recently calculated precision, rather
10926 than them all. Record whether each argument has been converted to
10927 string. Use EMACS_INT, not int, for byte and char and arg counts.
10928 Support field widths and precisions larger than INT_MAX. Avoid
10929 sprintf's undefined behavior with conversion specifications such as %#d
10930 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10931 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10932 formatting out-of-range floating point numbers with int
9173deec 10933 formats. (Bug#8668)
37910ab2 10934
2e6578fb
PE
10935 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10936
0ae6bdee
PE
10937 * data.c: Avoid integer truncation in expressions involving floats.
10938 * data.c: Include <intprops.h>.
10939 (arith_driver): When there's an integer overflow in an expression
10940 involving floating point, convert the integers to floating point
10941 so that the resulting value does not suffer from catastrophic
10942 integer truncation. For example, on a 64-bit host (* 4
10943 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10944 Do not rely on undefined behavior after integer overflow.
10945
de883a70
PE
10946 merge count_size_as_multibyte, parse_str_to_multibyte
10947 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10948 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10949 Check for integer overflow.
10950 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10951 since it's now a duplicate of the other. This is more of
10952 a character than a buffer op, so better that it's in character.c.
10953 * fns.c, print.c: Adjust to above changes.
10954
2ff916cb
PE
109552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10956
10957 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10958
f1b54466
PE
109592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10960
fb1ac845
PE
10961 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10962 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10963 (x_clipboard_manager_save): Now static.
10964 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10965
f1b54466
PE
10966 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10967 (crypto_hash_function): Now static.
10968 Fix pointer signedness problems. Avoid unnecessary initializations.
10969
a9f737ee
CY
109702011-05-27 Chong Yidong <cyd@stupidchicken.com>
10971
10972 * termhooks.h (Vselection_alist): Make it terminal-local.
10973
10974 * terminal.c (create_terminal): Initialize it.
10975
10976 * xselect.c: Support for clipboard managers.
10977 (Vselection_alist): Move to termhooks.h as terminal-local var.
10978 (LOCAL_SELECTION): New macro.
10979 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10980 (symbol_to_x_atom): Remove gratuitous arg.
10981 (x_handle_selection_request, lisp_data_to_selection_data)
10982 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10983 (x_own_selection, x_get_local_selection, x_convert_selection):
10984 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10985 (some_frame_on_display): Delete unused function.
10986 (Fx_own_selection_internal, Fx_get_selection_internal)
10987 (Fx_disown_selection_internal, Fx_selection_owner_p)
10988 (Fx_selection_exists_p): New optional frame arg.
10989 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10990 (x_handle_selection_clear): Don't treat other terminals with the
10991 same keyboard specially. Use the terminal-local Vselection_alist.
10992 (x_clear_frame_selections): Use Frun_hook_with_args.
10993
10994 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10995
10996 * xterm.h: Add support for those atoms.
10997
e067f0c1
CY
109982011-05-26 Chong Yidong <cyd@stupidchicken.com>
10999
11000 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11001 (converted_selections, conversion_fail_tag): New global variables.
11002 (x_selection_request_lisp_error): Free the above.
11003 (x_get_local_selection): Remove unnecessary code.
11004 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11005 of converted selections stored in converted_selections.
11006 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11007 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11008 (x_convert_selection): New function.
11009 (x_handle_selection_event): Simplify.
11010 (x_get_foreign_selection): Don't ignore incoming requests while
11011 waiting for an answer; this will fail when we implement
11012 SAVE_TARGETS, and seems unnecessary anyway.
11013 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11014 (Vx_sent_selection_functions): Doc fix.
11015
0f4aebc0
LL
110162011-05-26 Leo Liu <sdl.web@gmail.com>
11017
11018 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11019
e61124cd
YM
110202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11021
11022 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11023
11024 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11025 for fringe update if it has periodic bitmap.
ac389d0c 11026 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11027 and fringe_bitmap_periodic_p.
11028
11029 * fringe.c (get_fringe_bitmap_data): New function.
11030 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11031 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11032 row. Mark glyph row for fringe update if periodicity changed.
11033
11034 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11035 for fringe update unless it has periodic bitmap.
11036
f16d9837
KH
110372011-05-25 Kenichi Handa <handa@m17n.org>
11038
11039 * xdisp.c (get_next_display_element): Set correct it->face_id for
11040 a static composition.
11041
e1b90ef6
LL
110422011-05-24 Leo Liu <sdl.web@gmail.com>
11043
11044 * deps.mk (fns.o):
11045 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11046
11047 * fns.c (crypto_hash_function, Fsha1): New function.
11048 (Fmd5): Use crypto_hash_function.
11049 (syms_of_fns): Add Ssha1.
11050
7400048f
PE
110512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11052
11053 * gnutls.c: Remove unused macros.
11054 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11055 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11056 Remove macros that are defined and never used.
11057 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11058
abb71cf4
CY
110592011-05-22 Chong Yidong <cyd@stupidchicken.com>
11060
11061 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11062 (Fx_get_selection_internal): Minor cleanup.
11063 (Fx_own_selection_internal): Rename arguments for consistency with
11064 select.el.
11065
6307db39
PE
110662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11067
11068 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11069
f3d4e0a4
CY
110702011-05-22 Chong Yidong <cyd@stupidchicken.com>
11071
11072 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11073
4d8ade89
YM
110742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11075
11076 * dispnew.c (scrolling_window): Don't exclude the case that the
11077 last enabled row in the desired matrix touches the bottom boundary.
11078
32078c8d
GM
110792011-05-21 Glenn Morris <rgm@gnu.org>
11080
11081 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11082 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11083 and add some more files.
32078c8d 11084
7285dc67
EZ
110852011-05-20 Eli Zaretskii <eliz@gnu.org>
11086
11087 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11088 report_file_error introduced by the change from 2011-05-07.
11089
89d1bd22
PE
110902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11091
11092 * systime.h (Time): Define only if emacs is defined.
11093 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11094 where the include path doesn't have X11/X.h by default. See
11095 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11096
cd394be1 110972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11098
11099 * composite.c (find_automatic_composition): Fix previous change.
11100
b9704ad9
GM
111012011-05-20 Glenn Morris <rgm@gnu.org>
11102
11103 * lisp.mk: New file, split from Makefile.in.
11104 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11105 (shortlisp): Remove.
11106 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11107
4a720484
GM
111082011-05-19 Glenn Morris <rgm@gnu.org>
11109
11110 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11111 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11112 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11113 (lisp): Set the order to that of loadup.el.
11114 (shortlisp): Make it a copy of $lisp.
11115 (SOME_MACHINE_LISP): Remove.
11116 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11117 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11118
a28d4396
KH
111192011-05-18 Kenichi Handa <handa@m17n.org>
11120
11121 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11122 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11123 (find_automatic_composition): Mostly rewrite for efficiency.
11124
a2b1fa8e
JB
111252011-05-18 Juanma Barranquero <lekktu@gmail.com>
11126
11127 * makefile.w32-in: Update dependencies.
11128
8e1f5610
CS
111292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11130
11131 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11132 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11133
7025ee00 111342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11135
cdfa6eab
PE
11136 Fix some integer overflow issues, such as string length overflow.
11137
06d6db33
PE
11138 * insdel.c (count_size_as_multibyte): Check for string overflow.
11139
2b4560a8
PE
11140 * character.c (lisp_string_width): Check for string overflow.
11141 Use EMACS_INT, not int, for string indexes and lengths; in
11142 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11143 the resulting string length overflows an EMACS_INT; instead,
11144 report a string overflow if no precision given. When checking for
11145 precision exhaustion, use a check that cannot possibly have
11146 integer overflow. (Bug#8675)
11147 * character.h (lisp_string_width): Adjust to new signature.
11148
cb93f9be
PE
11149 * alloc.c (string_overflow): New function.
11150 (Fmake_string): Use it. This doesn't change behavior, but saves
11151 a few bytes and will simplify future changes.
11152 * character.c (string_escape_byte8): Likewise.
11153 * lisp.h (string_overflow): New decl.
11154
1a1f3366
PE
11155 Fixups, following up to the user-interface timestamp change.
11156 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11157 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11158 * msdos.c (mouse_get_pos): Likewise.
11159 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11160 * w32gui.h (Time): Define by including "systime.h" rather than by
11161 declaring it ourselves. (Bug#8664)
11162
d4e3e4d3
PE
11163 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11164 * image.c (clear_image_cache): Likewise.
11165
f6a24d19
PE
11166 * term.c (term_mouse_position): Don't assume time_t wraparound.
11167
08dc5ae6
PE
11168 Be more systematic about user-interface timestamps.
11169 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11170 and sometimes 'EMACS_UINT', to represent these timestamps.
11171 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11172 This makes the code easier to follow, and makes it easier to catch
11173 integer overflow bugs such as Bug#8664.
11174 * frame.c (Fmouse_position, Fmouse_pixel_position):
11175 Use Time, not unsigned long, for user-interface timestamps.
11176 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11177 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11178 * keyboard.h (last_event_timestamp): Likewise.
11179 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11180 * menu.h (xmenu_show): Likewise.
11181 * term.c (term_mouse_position): Likewise.
11182 * termhooks.h (struct input_event.timestamp): Likewise.
11183 (struct terminal.mouse_position_hook): Likewise.
11184 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11185 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11186 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11187 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11188 what it was before.
11189 * menu.h, termhooks.h: Include "systime.h", for Time.
11190
8e55734a
PE
11191 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11192 Don't assume that the difference between two unsigned long values
11193 can fit into an integer. At this point, we know button_down_time
11194 <= event->timestamp, so the difference must be nonnegative, so
11195 there's no need to cast the result if double-click-time is
11196 nonnegative, as it should be; check that it's nonnegative, just in
11197 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11198 apart (about 25 days). (Bug#8664)
8e55734a 11199
841f1b75 11200 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11201 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11202
3e26f69c
PE
11203 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11204 that always fit in int. Use a sentinel instead of a counter, to
11205 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11206 * frame.h (struct frame): Use int for menu_bar_items_used
11207 instead of EMACS_INT, since it always fits in int.
3e26f69c 11208
5cc152c0
PE
11209 * menu.c (grow_menu_items): Check for int overflow.
11210
d89eb65e
PE
11211 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11212
5235bd3e
PE
11213 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11214 Before, the code was not consistent. These values cannot exceed
11215 2**31 - 1 so there's no need to make them unsigned.
11216 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11217 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11218 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11219 as modifiers.
11220 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11221
bc827e23
PE
11222 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11223 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11224 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11225 presumably because the widths might not match.
11226
78eb494e
PE
11227 * window.c (size_window): Avoid needless test at loop start.
11228
04f2d78b
CB
112292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11230
11231 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11232
d2fc7e3d 112332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11234
11235 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11236
d2fc7e3d 112372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11238
11239 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11240 `width' to `bar_area_x' and `bar_area_width', respectively.
11241 (x_scroll_run): Take account of fringe background extension.
11242
04f2d78b
CB
11243 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11244 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11245 `bar_area_width', respectively.
11246 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11247 background extension.
11248
79b70037
GM
112492011-05-10 Jim Meyering <meyering@redhat.com>
11250
11251 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11252
2f142cc5
JB
112532011-05-10 Juanma Barranquero <lekktu@gmail.com>
11254
11255 * image.c (Finit_image_library): Return t for built-in image types,
11256 like pbm and xbm. (Bug#8640)
11257
57679c86
AS
112582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11259
11260 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11261
888c9e86
EZ
112622011-05-07 Eli Zaretskii <eliz@gnu.org>
11263
b0512a1d
EZ
11264 * w32console.c (Fset_screen_color): Doc fix.
11265 (Fget_screen_color): New function.
11266 (syms_of_ntterm): Defsubr it.
11267
7285dc67
EZ
11268 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11269 unlink the temporary file if Fcall_process didn't create it in the
11270 first place.
11271 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11272 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11273 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11274 cue to call_process_cleanup not to close that handle.
11275
4d3fcc8e
BK
112762011-05-07 Ben Key <bkey76@gmail.com>
11277
11278 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11279 one of two shell specific rules, either bootstrap-temacs-CMD or
11280 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11281 to the previous implementation of the bootstrap-temacs rule.
11282 The bootstrap-temacs-CMD rule is similar to the previous
11283 implementation of the bootstrap-temacs rule except that it
11284 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11285 variable.
11286
11287 These changes, along with some changes to nt/configure.bat,
11288 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11289 earlier fix to add support for --cflags and --ldflags options
11290 that include quotes so that it works whether make uses cmd or
11291 sh as the shell.
11292
b4289b64
MA
112932011-05-06 Michael Albinus <michael.albinus@gmx.de>
11294
11295 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11296 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11297 is a constant.
11298 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11299 a string. Handle both cases.
11300 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11301 (Fdbus_register_method): Use Qinvalid_function.
11302
af4c0e28
JB
113032011-05-06 Juanma Barranquero <lekktu@gmail.com>
11304
11305 * makefile.w32-in: Update dependencies.
11306 (LISP_H): Add inttypes.h and stdin.h.
11307 (PROCESS_H): Add unistd.h.
11308
c51453d9
EZ
113092011-05-06 Eli Zaretskii <eliz@gnu.org>
11310
11311 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11312 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11313
8ff0ac3c 113142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11315
4c4b566b
PE
11316 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11317
aab2b9b5
PE
11318 * term.c (vfatal): Remove stray call to va_end.
11319 It's not needed and the C Standard doesn't allow it here anyway.
11320
c378da0b
PE
11321 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11322 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11323
288b08c7
PE
11324 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11325 bytes.
11326
e3601888
PE
11327 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11328
db6c0e74
PE
11329 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11330
dd5963ea
PE
11331 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11332
88c9450f
PE
11333 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11334
2f9442b8
PE
11335 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11336
c032b5f8
PE
11337 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11338 * charset.c (Fdefine_charset_internal): Don't initialize
11339 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11340 32-bit int (Bug#8600).
a108c10b
PE
11341
11342 * lread.c (read_integer): Be more consistent with string-to-number.
11343 Use string_to_number to do the actual conversion; this avoids
11344 rounding errors and fixes some other screwups. Without this fix,
11345 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11346 (digit_to_number): Move earlier, for benefit of read_integer.
11347 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11348 not a digit in any supported base. (Bug#8602)
a108c10b 11349
ad5f9eea
PE
11350 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11351
aec1708a
PE
11352 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11353 to match comment at start of function. This also removes a
11354 GCC warning about overflow in a 32+64-bit port.
11355
47be4ab5
PE
11356 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11357
371cac43
PE
11358 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11359 Reported by Stefan Monnier in
11360 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11361 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11362 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11363
d01a7826
PE
11364 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11365 (EMACS_UINTPTR): Likewise, with uintptr_t.
11366
7fd47d5c
PE
11367 * lisp.h: Prefer 64-bit EMACS_INT if available.
11368 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11369 on 32-bit hosts that have 64-bit int, so that they can access
11370 large files.
122b0c86
PE
11371 However, temporarily disable this change unless the temporary
11372 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11373
8727937b
PE
11374 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11375
8ac068ac
PE
11376 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11377 This removes an assumption that EMACS_INT and long are the same
11378 width as pointers. The assumption is true for Emacs porting targets
11379 now, but we want to make other targets possible.
11380 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11381 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11382 In the rest of the code, change types of integers that hold casted
11383 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11384 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11385 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11386 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11387 No need to cast type when ORing.
11388 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11389 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11390 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11391 assume EMACS_INT is the same width as char *.
11392 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11393 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11394 Remove no-longer-needed casts.
11395 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11396 (xg_tool_bar_help_callback, xg_make_tool_item):
11397 Use EMACS_INTPTR to hold an integer
11398 that will be cast to void *; this can avoid a GCC warning
11399 if EMACS_INT is not the same width as void *.
11400 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11401 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11402 (current_message_1, set_message_1):
11403 Use a local to convert to proper width without a cast.
11404 * xmenu.c (dialog_selection_callback): Likewise.
11405
ede49d71
PE
11406 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11407 Also, don't assume VALBITS / RAND_BITS is less than 5,
11408 and don't rely on undefined behavior when shifting a 1 left into
11409 the sign bit.
11410 * lisp.h (get_random): Change signature to match.
11411
2f30ecd0
PE
11412 * lread.c (hash_string): Use size_t, not int, for hash computation.
11413 Normally we prefer signed values; but hashing is special, because
11414 it's better to use unsigned division on hash table sizes so that
11415 the remainder is nonnegative. Also, size_t is the natural width
11416 for hashing into memory. The previous code used 'int', which doesn't
11417 retain enough info to hash well into very large tables.
11418 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11419
2a866e7b
PE
11420 * dbusbind.c: Don't possibly lose pointer info when converting.
11421 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11422 Use XPNTR rather than XHASH, so that the high-order bits of
11423 the pointer aren't lost when converting through void *.
11424
51639eac
PE
11425 * eval.c (Fautoload): Don't double-shift a pointer.
11426
92394119
PE
11427 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11428
dbdb9a7c
JB
114292011-05-06 Juanma Barranquero <lekktu@gmail.com>
11430
11431 * gnutls.c (DEF_GNUTLS_FN):
11432 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11433
db7a0b4f
AS
114342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11435
11436 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11437 marker. (Bug#8610)
11438
cd394be1 114392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11440
11441 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11442 New version that can reserve upto 2GB of heap space.
11443
f7ff1b0f 114442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11445
11446 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11447
639c109b
TZ
114482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11449
11450 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11451 `gnutls_certificate_set_x509_key_file'.
11452
d2127135
JB
114532011-05-05 Juanma Barranquero <lekktu@gmail.com>
11454
11455 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11456 Update dependencies.
11457
e968f4f3
JB
114582011-05-04 Juanma Barranquero <lekktu@gmail.com>
11459
11460 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11461 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11462 Remove unused parameter `fildes'.
11463 * process.c (read_process_output, send_process): Don't pass it.
11464
84d358f0
JB
114652011-05-04 Juanma Barranquero <lekktu@gmail.com>
11466
11467 Fix previous change: the library cache is defined in w32.c.
11468 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11469 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11470
0898ca10
JB
114712011-05-04 Juanma Barranquero <lekktu@gmail.com>
11472
11473 Implement dynamic loading of GnuTLS on Windows.
11474
11475 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11476 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11477 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11478 Declare.
11479
11480 * gnutls.c (Qgnutls_dll): Define.
11481 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11482 (gnutls_*): Declare function pointers.
11483 (init_gnutls_functions): New function to initialize function pointers.
11484 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11485 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11486 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11487 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11488 (emacs_gnutls_write, emacs_gnutls_read)
11489 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11490 (Fgnutls_available_p): New function.
11491 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11492 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11493 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11494
11495 * image.c: Include w32.h.
11496 (Vimage_type_cache): Delete.
11497 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11498 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11499 (w32_delayed_load): Move to w32.c.
11500
11501 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11502
11503 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11504 (w32_delayed_load): Move from image.c. When loading a library, record
11505 its filename in the :loaded-from property of the library id.
11506 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11507 Initialize and staticpro them.
11508 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11509
11510 * process.c: Include lisp.h before w32.h, not after.
11511 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11512 instead of gnutls_record_check_pending.
11513
11514 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11515
ff4de4aa
TZ
115162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11517
11518 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11519 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11520 as passed in.
11521
abe95abb
JD
115222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11523
11524 * xterm.c (x_set_frame_alpha): Do not set property on anything
11525 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11526
e16e55d4
JB
115272011-05-02 Juanma Barranquero <lekktu@gmail.com>
11528
11529 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11530
bafcf6a5
JB
115312011-05-02 Juanma Barranquero <lekktu@gmail.com>
11532
11533 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11534 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11535 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11536 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11537 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11538 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11539 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11540 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11541 (Qgnutls_bootprop_callbacks_verify): Make static.
11542
e7a6747f
AS
115432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11544
19ed11ba
AS
11545 * callproc.c: Indentation fixup.
11546
e7a6747f 11547 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11548 (wait_for_termination, interruptible_wait_for_termination):
11549 Move after wait_for_termination_1.
e7a6747f 11550
1ef14cb4
LMI
115512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11552
11553 * sysdep.c (interruptible_wait_for_termination): New function
11554 which is like wait_for_termination, but allows keyboard
11555 interruptions.
11556
11557 * callproc.c (Fcall_process): Add (:file "file") as an option for
11558 the STDOUT buffer.
11559 (Fcall_process_region): Ditto.
11560
330d880c
EZ
115612011-04-30 Eli Zaretskii <eliz@gnu.org>
11562
8db90b73
EZ
11563 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11564 rather than `XVECTOR (FOO)->size'.
11565
330d880c
EZ
11566 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11567 inttypes.h, as a gnulib replacement is used if it not available in
11568 system headers.
11569
15cbd324
EZ
115702011-04-21 Eli Zaretskii <eliz@gnu.org>
11571
11572 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11573 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11574 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11575
11576 * coding.c (coding_alloc_by_realloc): Error out if destination
11577 will grow beyond MOST_POSITIVE_FIXNUM.
11578 (decode_coding_emacs_mule): Abort if there isn't enough place in
11579 charbuf for the composition carryover bytes. Reserve an extra
11580 space for up to 2 characters produced in a loop.
11581 (decode_coding_iso_2022): Abort if there isn't enough place in
11582 charbuf for the composition carryover bytes.
11583
115842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11585
ae940cca
EZ
11586 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11587 aborting when %lld or %lll format is passed.
11588 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11589 %llo or %llx format is passed. (Bug#8545)
11590
03ab8921
EZ
11591 * window.c (window_scroll_line_based): Use a marker instead of
11592 simple variables to record original value of point. (Bug#7952)
11593
afda1437
EZ
11594 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11595 produced by %s or %c overflows available buffer space. (Bug#8545)
11596
f76dee0c
PE
115972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11598
11599 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11600 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11601
fdc5744d
JB
116022011-04-28 Juanma Barranquero <lekktu@gmail.com>
11603
11604 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11605
638f053a
JB
116062011-04-28 Juanma Barranquero <lekktu@gmail.com>
11607
11608 * keyboard.c (Qdelayed_warnings_hook): Define.
11609 (command_loop_1): Run `delayed-warnings-hook'
11610 if Vdelayed_warnings_list is non-nil.
11611 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11612 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11613
d178f871
EZ
116142011-04-28 Eli Zaretskii <eliz@gnu.org>
11615
11616 * doprnt.c (doprnt): Don't return value smaller than the buffer
11617 size if the message was truncated. (Bug#8545).
11618
b124fd93
JB
116192011-04-28 Juanma Barranquero <lekktu@gmail.com>
11620
11621 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11622 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11623
e810457d
PE
116242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11625
11626 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11627
ea51cceb
JB
116282011-04-27 Juanma Barranquero <lekktu@gmail.com>
11629
11630 * makefile.w32-in: Update dependencies.
11631
94dcfacf
EZ
116322011-04-27 Eli Zaretskii <eliz@gnu.org>
11633
11634 Improve `doprnt' and its usage. (Bug#8545)
11635 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11636 `format_end'. Remove support for %l as a conversion specifier.
11637 Don't use xrealloc. Improve diagnostics when the %l size modifier
11638 is used. Update the commentary.
11639
11640 * eval.c (verror): Simplify calculation of size_t.
11641
11642 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11643 messages.
11644
f61f41d7
PE
116452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11646
11647 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11648 change.
11649
96fb4434
PE
116502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11651
11652 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11653 This makes this file independent of the recent pseudovector change.
11654
671875da 116552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11656
69e9b5a3
PE
11657 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11658
b5f869a7 11659 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11660 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11661 Remove unused local.
c8926152 11662 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11663
841a1577 11664 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11665 GCC 4.6.0 optimizes based on type-based alias analysis.
11666 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11667 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11668 != &v->size, and therefore "v->size = 1; b->size = 2; return
11669 v->size;" must therefore return 1. This assumption is incorrect
11670 for Emacs, since it type-puns struct Lisp_Vector * with many other
11671 types. To fix this problem, this patch adds a new type struct
f904488f 11672 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11673 and pseudovectors, and helps optimizing compilers not get fooled
11674 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11675 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11676 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11677 the size member.
eab3844f
PE
11678 (XSETPVECTYPE): Rewrite in terms of new macro.
11679 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11680 This is a bit clearer, and further avoids the possibility of
11681 undesirable aliasing.
11682 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11683 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11684 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11685 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11686 (ASIZE): Now uses header.size rather than size.
11687 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11688 to avoid the hassle of writing XVECTOR (foo)->header.size.
11689 (struct vectorlike_header): New type.
eab3844f
PE
11690 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11691 object, to help avoid aliasing.
11692 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11693 (SUBRP): Likewise, since Lisp_Subr is a special case.
11694 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11695 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11696 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11697 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11698 changed to be "header.size" and "header.next".
11699 * buffer.h (struct buffer): Likewise.
11700 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11701 * frame.h (struct frame): Likewise.
11702 * process.h (struct Lisp_Process): Likewise.
11703 * termhooks.h (struct terminal): Likewise.
11704 * window.c (struct save_window_data, struct saved_window): Likewise.
11705 * window.h (struct window): Likewise.
11706 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11707 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11708 * buffer.c (init_buffer_once): Likewise.
11709 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11710 special case.
11711 * process.c (Fformat_network_address): Use local var for size,
11712 for brevity.
11713
0df1eac5
PE
11714 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11715
847ab9d1 11716 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11717 * data.c (atof): Remove decl; no longer used or needed.
11718 (digit_to_number): Move to lread.c.
11719 (Fstring_to_number): Use new string_to_number function, to be
11720 consistent with how the Lisp reader treats infinities and NaNs.
11721 Do not assume that floating-point numbers represent EMACS_INT
11722 without losing information; this is not true on most 64-bit hosts.
11723 Avoid double-rounding errors, by insisting on integers when
11724 parsing non-base-10 numbers, as the documentation specifies.
11725 * lisp.h (string_to_number): New decl, replacing ...
11726 (isfloat_string): Remove.
bc0a5c13 11727 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11728 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11729 appears to have been a coding error. Similarly, do not accept
11730 strings like +-1e0 as floating point numbers. Do not report
11731 overflow for integer overflows unless the base is not 10 which
11732 means we have no simple and reliable way to continue.
11733 Break out the floating-point parsing into a new
11734 function string_to_number, so that Fstring_to_number parses
11735 floating point numbers consistently with the Lisp reader.
04f2d78b 11736 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11737 (E_CHAR, EXP_INT): Remove, replacing with ...
11738 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11739 (string_to_number): New function, replacing isfloat_string.
11740 This function checks for valid syntax and produces the resulting
11741 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11742 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11743 so that overflow for non-base-10 numbers is reported only when
11744 there's no portable and simple way to convert to floating point.
452f4150 11745
67769ffc
PE
11746 * textprop.c (set_text_properties_1): Rewrite for clarity,
11747 and to avoid GCC warning about integer overflow.
11748
c20db43f
PE
11749 * intervals.h (struct interval): Use EMACS_INT for members
11750 where EMACS_UINT might cause problems. See
11751 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11752 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11753 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11754 All uses changed.
37aa2f85
PE
11755 (offset_intervals): Tell GCC not to worry about length overflow
11756 when negating a negative length.
c20db43f 11757
2538aa2f
PE
11758 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11759 (overrun_check_free): Likewise.
11760
f2d3008d
PE
11761 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11762 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11763 word size.
11764
ec8df744
PE
11765 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11766 (gnutls_make_error): Rename local to avoid shadowing.
11767 (gnutls_emacs_global_deinit): ifdef out; not used.
11768 (Fgnutls_boot): Use const for pointer to readonly storage.
11769 Comment out unused local. Fix pointer signedness problems.
11770
640ee02d
PE
11771 * lread.c (openp): Don't stuff size_t into an 'int'.
11772 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11773 about possible signed overflow.
11774
6048fb2a
PE
11775 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11776 (GDK_KEY_g): Don't define if already defined.
11777 (xg_prepare_tooltip): Avoid pointer signedness problem.
11778 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11779
fa3c87e1
PE
11780 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11781 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11782
2172544b
PE
11783 * xfns.c (Fx_window_property): Simplify a bit,
11784 to make a bit faster and to avoid GCC 4.6.0 warning.
11785 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11786
9b821a21
PE
11787 * fns.c (internal_equal): Don't assume size_t fits in int.
11788
3c616cfa
PE
11789 * alloc.c (compact_small_strings): Tighten assertion a little.
11790
c2982e87
PE
11791 Replace pEd with more-general pI, and fix some printf arg casts.
11792 * lisp.h (pI): New macro, generalizing old pEd macro to other
11793 conversion specifiers. For example, use "...%"pI"d..." rather
11794 than "...%"pEd"...".
11795 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11796 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11797 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11798 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11799 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11800 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11801 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11802 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11803 64-bit hosts.
11804 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11805 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11806 * print.c (safe_debug_print, print_object): Likewise.
11807 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11808 to int.
6f04d126
PE
11809 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11810 avoiding the 0 flag, which is not portable.
c2982e87
PE
11811 * process.c (Fmake_network_process): Use pI to avoid cast.
11812 * region-cache.c (pp_cache): Likewise.
11813 * xdisp.c (decode_mode_spec): Likewise.
11814 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11815 behavior on 64-bit hosts with printf arg.
6f04d126 11816 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11817 (x_stop_queuing_selection_requests): Likewise.
11818 (x_get_window_property): Don't truncate byte count to an 'int'
11819 when tracing.
0b432f21 11820
5e073ec7
PE
11821 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11822 here, since it parses constructs like leading '-' and spaces,
11823 which are not wanted; and it overflows with large numbers.
11824 Instead, simply match F[0-9]+, which is what is wanted anyway.
11825
36372bf9
PE
11826 * alloc.c: Remove unportable assumptions about struct layout.
11827 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11828 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11829 (allocate_vectorlike, make_pure_vector): Use the new macros,
11830 plus offsetof, to remove unportable assumptions about struct layout.
11831 These assumptions hold on all porting targets that I know of, but
11832 they are not guaranteed, they're easy to remove, and removing them
11833 makes further changes easier.
11834
0b432f21
PE
11835 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11836 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11837 (string_overrun_cookie): Now const. Use initializers that
11838 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11839 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11840 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11841 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11842 multiple of sizeof (EMACS_INT); it need not be, if
11843 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11844 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11845
895009e1
JB
118462011-04-26 Juanma Barranquero <lekktu@gmail.com>
11847
11848 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11849
6a7a1b0b
TZ
118502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11851
11852 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11853 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11854 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11855
841a1577 118562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11857
11858 * lisp.h (Qdebug): List symbol.
895009e1 11859 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11860 * keyboard.c (debug-on-event): New variable.
11861 (handle_user_signal): Break into debugger when debug-on-event
11862 matches the current signal symbol.
11863
f2d3ba6f
DN
118642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11865
11866 * alloc.c (check_sblock, check_string_bytes)
11867 (check_string_free_list): Convert to standard C.
11868
42ce4c63
TZ
118692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11870
11871 * w32.c (emacs_gnutls_push): Fix typo.
11872
825cd63c
EZ
118732011-04-25 Eli Zaretskii <eliz@gnu.org>
11874
fb11d64d
EZ
11875 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11876 "cast to pointer from integer of different size".
11877
825cd63c
EZ
11878 Improve doprnt and its use in verror. (Bug#8545)
11879 * doprnt.c (doprnt): Document the set of format control sequences
11880 supported by the function. Use SAFE_ALLOCA instead of always
11881 using `alloca'.
11882
11883 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11884 is one byte too soon. Don't use xrealloc; instead xfree and
11885 xmalloc anew.
11886
e061a11b
TZ
118872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11888
11889 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11890 callbacks stage.
11891
11892 * gnutls.c: Renamed global_initialized to
11893 gnutls_global_initialized. Added internals for the
11894 :verify-hostname-error, :verify-error, and :verify-flags
11895 parameters of `gnutls-boot' and documented those parameters in the
11896 docstring. Start callback support.
9173deec
JB
11897 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11898 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11899 on error. Return error code.
e061a11b
TZ
11900 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11901 (emacs_gnutls_read): Likewise.
11902 (Fgnutls_boot): Return handshake error code.
11903 (emacs_gnutls_handle_error): New function.
11904 (wsaerror_to_errno): Likewise.
11905
11906 * w32.h (emacs_gnutls_pull): Add prototype.
11907 (emacs_gnutls_push): Likewise.
11908
11909 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11910 (emacs_gnutls_push): Likewise.
11911
119122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11913
11914 * process.c (wait_reading_process_output): Check if GnuTLS
11915 buffered some data internally if no FDs are set for TLS
11916 connections.
11917
11918 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11919 (LIBS): Link to USER_LIBS.
11920 ($(BLD)/gnutls.$(0)): New target.
11921
fa6996bc
EZ
119222011-04-24 Eli Zaretskii <eliz@gnu.org>
11923
eb35682e
EZ
11924 * xdisp.c (handle_single_display_spec): Rename the
11925 display_replaced_before_p argument into display_replaced_p, to
11926 make it consistent with the commentary. Fix typos in the
11927 commentary.
11928
e2ad650c
EZ
11929 * textprop.c (syms_of_textprop): Remove dead code.
11930 (copy_text_properties): Delete obsolete commentary about an
11931 interface that was deleted long ago. Fix typos in the description
11932 of arguments.
11933
1b2de274
EZ
11934 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11935 to changes in oldXMenu/XMenu.h from 2011-04-16.
11936 <menu_help_message, prev_menu_help_message>: Constify.
11937 (IT_menu_make_room): menu->help_text is now `const char **';
11938 adjust.
11939
11940 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11941 to changes in oldXMenu/XMenu.h from 2011-04-16.
11942 (struct XMenu): Declare `help_text' `const char **'.
11943
11944 * xfaces.c <Qunspecified>: Make extern again.
11945
11946 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11947 required by POSIX.
1b2de274 11948
762b15be
EZ
11949 * doc.c (get_doc_string): Improve the format passed to `error'.
11950
11951 * doprnt.c (doprnt): Improve commentary.
11952
11953 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11954
11955 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11956 them with etags.
11957
f1052e5d
EZ
11958 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11959 changes in globals.h immediately force recompilation.
762b15be
EZ
11960 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11961 $(CURDIR)/s/ms-w32.h.
11962 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11963
fa6996bc
EZ
11964 * character.c (Fchar_direction): Function deleted.
11965 (syms_of_character): Don't defsubr it.
11966 <char-direction-table>: Deleted.
11967
e6c3da20
EZ
119682011-04-23 Eli Zaretskii <eliz@gnu.org>
11969
11970 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11971 * doprnt.c: Include limits.h.
11972 (SIZE_MAX): New macro.
04f2d78b
CB
11973 (doprnt): Return a size_t value. 2nd arg is now size_t.
11974 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11975 Improve overflow protection. Support `l' modifier for integer
11976 conversions. Support %l conversion. Don't assume an EMACS_INT
11977 argument for integer conversions and for %c.
11978
11979 * lisp.h (doprnt): Restore prototype.
11980
11981 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11982 $(SRC)/character.h.
11983
11984 * Makefile.in (base_obj): Add back doprnt.o.
11985
11986 * deps.mk (doprnt.o): Add back prerequisites.
11987 (callint.o): Depend on character.h.
11988
11989 * eval.c (internal_lisp_condition_case): Include the handler
11990 representation in the error message.
11991 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11992 when breaking from the loop.
11993
11994 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11995
11996 * callint.c (Fcall_interactively): When displaying error message
11997 about invalid control letter, pass the character's codepoint, not
11998 a pointer to its multibyte form. Improve display of the character
11999 in octal and display also its hex code.
12000
12001 * character.c (char_string): Use %x to display the (unsigned)
12002 codepoint of an invalid character, to avoid displaying a bogus
12003 negative value.
12004
12005 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12006 `error', not SYMBOL_NAME itself.
12007
12008 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12009 character arguments to `error'.
12010
12011 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12012 to `error' in error message about FINAL_CHAR argument. Make sure
12013 FINAL_CHAR is a character, and use %c when it is passed as
12014 argument to `error'.
12015
4ffd0d6b 120162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12017
12018 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12019
12020 * w32.c: Include <time.h>.
12021 (sys_localtime): New function.
12022
4ffd0d6b 120232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12024
12025 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12026
4ffd0d6b 12027 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12028
4ffd0d6b 120292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12030
4ffd0d6b
GM
12031 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12032 zombies (Bug#8467).
aac0c6e3 12033
04c56954
EZ
120342011-04-19 Eli Zaretskii <eliz@gnu.org>
12035
12036 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12037 gl_state.e_property when gl_state.object is Qt.
12038
12039 * insdel.c (make_gap_larger): Remove limitation of buffer size
12040 to <= INT_MAX.
12041
16a43933
CY
120422011-04-18 Chong Yidong <cyd@stupidchicken.com>
12043
12044 * xdisp.c (lookup_glyphless_char_display)
12045 (produce_glyphless_glyph): Handle cons cell entry in
12046 glyphless-char-display.
12047 (Vglyphless_char_display): Document it.
12048
12049 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12050 glyphless-char-display.
12051
4581706e
CY
120522011-04-17 Chong Yidong <cyd@stupidchicken.com>
12053
12054 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12055
12056 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12057
12058 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12059 definition for no-X builds.
12060
4887c6e2 120612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12062
fd35b6f9
PE
12063 Static checks with GCC 4.6.0 and non-default toolkits.
12064
5c1ccb01
PE
12065 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12066
006c5daa
PE
12067 * process.c (keyboard_bit_set): Define only if SIGIO.
12068 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12069 (send_process): Repair possible setjmp clobbering.
12070
efc736d3
PE
12071 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12072
4e2fe2e6
PE
12073 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12074
f97334a2
PE
12075 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12076
4e75f29d
PE
12077 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12078 Define only if needed.
12079
90efadd1
PE
12080 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12081 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12082 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12083
3c647824
PE
12084 * dispextern.h (struct redisplay_interface): Rename param
12085 to avoid shadowing.
e264f262 12086 * termhooks.h (struct terminal): Likewise.
761383f4 12087 * xterm.c (xembed_send_message): Likewise.
3c647824 12088
b58c5c4a
PE
12089 * insdel.c (make_gap_smaller): Define only if
12090 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12091
cad59032
PE
12092 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12093 it.
12094
c339dc2e
PE
12095 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12096 so that we aren't warned about unused symbols.
12097
91a3e27b
PE
12098 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12099
399c71d3 12100 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12101
8ffc96f5
PE
12102 * xfns.c (x_real_positions): Mark locals as initialized.
12103
eef9bc79
PE
12104 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12105
098db9dd
PE
12106 * xterm.c: Fix problems found by static analysis with other toolkits.
12107 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12108 (x_dispatch_event): Declare static if USE_GTK, and
12109 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12110 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12111 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12112 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12113 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12114
eb18f6cc
PE
12115 * xmenu.c (menu_help_callback): Pointer type fixes.
12116 Use const pointers when pointing at readonly data. Avoid pointer
12117 signedness clashes.
12118 (FALSE): Remove unused macro.
12119 (update_frame_menubar): Remove unused decl.
12120
1fe72bf8
PE
12121 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12122
60d9e1db
PE
12123 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12124 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12125 (single_menu_item): Rename local to avoid shadowing.
12126
39261c26
PE
12127 * keyboard.c (make_lispy_event): Remove unused local var.
12128
018c5e19
PE
12129 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12130 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12131
63d2b86e
PE
12132 * bitmaps: Change bitmaps from unsigned char back to the X11
12133 compatible char. Avoid the old compiler warnings about
12134 out-of-range initializers by using, for example, '\xab' rather
12135 than 0xab.
12136
aefd87e1
PE
12137 * xgselect.c (xgselect_initialize): Check vs interface
12138 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12139
bf501fb9
PE
12140 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12141
e9829fdf
PE
12142 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12143 to read-only memory.
12144
1086c095
PE
12145 * fns.c (vector): Remove; this old hack is no longer needed.
12146
2baccd04 12147 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12148 Remove unused var.
dde42981 12149 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12150
72391843 12151 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12152
436c16df 12153 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12154 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12155 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12156
92bb796d 12157 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12158 (x_term_init): Remove local to avoid shadowing.
92bb796d 12159
764430a3 12160 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12161
12162 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12163 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12164
d1dfb56c
EZ
121652011-04-16 Eli Zaretskii <eliz@gnu.org>
12166
c4354cb4
EZ
12167 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12168
d1dfb56c
EZ
12169 Fix regex.c, syntax.c and friends for buffers > 2GB.
12170 * syntax.h (struct gl_state_s): Declare character position members
12171 EMACS_INT.
12172
12173 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12174
04f2d78b
CB
12175 * textprop.c (verify_interval_modification, interval_of):
12176 Declare arguments EMACS_INT.
d1dfb56c
EZ
12177
12178 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12179 EMACS_INT.
12180
12181 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12182
12183 * indent.c (Fvertical_motion): Local variable it_start is now
12184 EMACS_INT.
12185
12186 * regex.c (re_match, re_match_2, re_match_2_internal)
12187 (bcmp_translate, regcomp, regexec, print_double_string)
12188 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12189 (re_compile_pattern, re_exec): Declare arguments and local
12190 variables `size_t' and `ssize_t' and return values `regoff_t', as
12191 appropriate.
12192 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12193 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12194 <compile_stack_type>: `size' and `avail' are now `size_t'.
12195
12196 * regex.h <regoff_t>: Use ssize_t, not int.
12197 (re_search, re_search_2, re_match, re_match_2): Arguments that
12198 specify buffer/string position and length are now ssize_t and
12199 size_t. Return type is regoff_t.
12200
613052cd
BK
122012011-04-16 Ben Key <bkey76@gmail.com>
12202
12203 * nsfont.m: Fixed bugs in ns_get_family and
12204 ns_descriptor_to_entity that were caused by using free to
12205 deallocate memory blocks that were allocated by xmalloc (via
12206 xstrdup). This caused Emacs to crash when compiled with
12207 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12208 --enable-checking=xmallocoverrun). xfree is now used to
12209 deallocate these memory blocks.
12210
4170f62f 122112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12212
71b41406
PE
12213 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12214
9587a89d
PE
12215 emacs_write: Accept and return EMACS_INT for sizes.
12216 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12217 et seq.
12218 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12219 Accept and return EMACS_INT.
12220 (emacs_gnutls_write): Return the number of bytes written on
12221 partial writes.
12222 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12223 (emacs_read, emacs_write): Remove check for negative size, as the
12224 Emacs source code has been audited now.
9587a89d
PE
12225 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12226 (emacs_read, emacs_write): Use it.
273a5f82
PE
12227 * process.c (send_process): Adjust to the new signatures of
12228 emacs_write and emacs_gnutls_write. Do not attempt to store
12229 a byte offset into an 'int'; it might overflow.
9587a89d 12230 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12231
3e047f51
PE
12232 * sound.c: Don't assume sizes fit in 'int'.
12233 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12234 Return EMACS_INT, not int.
3e047f51 12235 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12236 Accept EMACS_INT, not int.
12237 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12238 record read return values.
12239
cc39a9db
BK
122402011-04-15 Ben Key <bkey76@gmail.com>
12241
c9d0ec6d
JB
12242 * keyboard.c (Qundefined): Don't declare static since it is used
12243 in nsfns.m.
12244 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12245 static since they are used in nsfont.m.
cc39a9db 12246
6c60eb9f
SM
122472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12248
12249 * process.c (Qprocessp): Don't declare static.
12250 * lisp.h (Qprocessp): Declare again.
12251
7990b61a
JB
122522011-04-15 Juanma Barranquero <lekktu@gmail.com>
12253
12254 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12255
5d4cb038
PE
122562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12257
8bd7b830 12258 Improve C-level modularity by making more things 'static'.
cd64ea1d 12259
e3b27b31
PE
12260 Don't publish debugger-only interfaces to other modules.
12261 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12262 (verify_bytepos, count_markers): Move decls to the only modules
12263 that need them.
12264 * region-cache.h (pp_cache): Likewise.
12265 * window.h (check_all_windows): Likewise.
12266 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12267
5d4cb038
PE
12268 * sysdep.c (croak): Now static, if
12269 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12270 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12271
12272 * alloc.c (refill_memory_reserve): Now static if
12273 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12274 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12275
e87b6180
PE
12276 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12277 Define only if USE_LUCID.
12278
ac64929e
PE
12279 * xrdb.c (x_customization_string, x_rm_string): Now static.
12280
6f37259d
PE
12281 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12282 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12283
1683e3ab
PE
12284 * xdisp.c (draw_row_with_mouse_face): Now static.
12285 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12286
de9c2632
PE
12287 * window.h (check_all_windows): Mark externally visible.
12288
2b96acb7
PE
12289 * window.c (window_deletion_count): Now static.
12290
12291 * undo.c: Make symbols static if they're not exported.
12292 (last_undo_buffer, last_boundary_position, pending_boundary):
12293 Now static.
12294
50436f33
PE
12295 * textprop.c (interval_insert_behind_hooks): Now static.
12296 (interval_insert_in_front_hooks): Likewise.
12297
64520e5c
PE
12298 * term.c: Make symbols static if they're not exported.
12299 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12300 (max_frame_lines, tty_set_terminal_modes):
12301 (tty_reset_terminal_modes, tty_turn_off_highlight):
12302 (get_tty_terminal): Now static.
12303 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12304 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12305 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12306 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12307 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12308
1fa53021
PE
12309 * sysdep.c: Make symbols static if they're not exported.
12310 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12311 Now static.
12312 (sigprocmask_set, full_mask): Remove; unused.
12313 (wait_debugging): Mark as visible.
12314 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12315 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12316
d4b43b22
PE
12317 * syntax.c (syntax_temp): Define only if !__GNUC__.
12318
b7c513d0
PE
12319 * sound.c (current_sound_device, current_sound): Now static.
12320
989b29ad
PE
12321 * search.c (searchbufs, searchbuf_head): Now static.
12322
13a55a78
PE
12323 * scroll.c (scroll_cost): Remove; unused.
12324 * dispextern.h (scroll_cost): Remove decl.
12325
de68a1fc
PE
12326 * region-cache.h (pp_cache): Mark as externally visible.
12327
40ccffa6
PE
12328 * process.c: Make symbols static if they're not exported.
12329 (process_tick, update_tick, create_process, chan_process):
12330 (Vprocess_alist, proc_buffered_char, datagram_access):
12331 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12332 (deactivate_process): Mark defn as static, as well as decl.
12333 * lisp.h (create_process): Remove decl.
12334 * process.h (chan_process, Vprocess_alist): Remove decls.
12335
ad64fc97
PE
12336 * print.c: Make symbols static if they're not exported.
12337 (print_depth, new_backquote_output, being_printed, print_buffer):
12338 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12339 (print_interval, print_number_index, initial_stderr_stream):
12340 Now static.
12341 * lisp.h (Fprinc): Remove decl.
12342 (debug_output_compilation_hack): Mark as externally visible.
12343
adddb265
PE
12344 * sysdep.c (croak): Move decl from here to syssignal.h.
12345 * syssignal.h (croak): Put it here, so the API can be checked when
12346 'croak' is called from dissociate_if_controlling_tty.
12347
1717ede2
PE
12348 * minibuf.c: Make symbols static if they're not exported.
12349 (minibuf_save_list, choose_minibuf_frame): Now static.
12350 * lisp.h (choose_minibuf_frame): Remove decl.
12351
fa5fb2bc
PE
12352 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12353
1e3890d1
PE
12354 * lread.c: Make symbols static if they're not exported.
12355 (read_objects, initial_obarray, oblookup_last_bucket_number):
12356 Now static.
12357 (make_symbol): Remove; unused.
12358 * lisp.h (initial_obarray, make_symbol): Remove decls.
12359
8a1414fa
PE
12360 * keyboard.c: Make symbols static if they're not exported.
12361 (single_kboard, recent_keys_index, total_keys, recent_keys):
12362 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12363 (this_single_command_key_start, echoing, last_auto_save):
12364 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12365 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12366 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12367 (Vlispy_mouse_stem, double_click_count):
12368 Now static.
12369 (force_auto_save_soon): Define only if SIGDANGER.
12370 (ignore_mouse_drag_p): Now static if
12371 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12372 (print_help): Remove; unused.
12373 (stop_character, last_timer_event): Mark as externally visible.
12374 * keyboard.h (ignore_mouse_drag_p): Declare only if
12375 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12376 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12377 * lisp.h (echoing): Remove decl.
12378 (force_auto_save_soon): Declare only if SIGDANGER.
12379 * xdisp.c (redisplay_window): Simplify code, to make it more
12380 obvious that ignore_mouse_drag_p is not accessed if !defined
12381 USE_GTK && !defined HAVE_NS.
12382
93ea6e8f
PE
12383 * intervals.c: Make symbols static if they're not exported.
12384 (merge_properties_sticky, merge_interval_right, delete_interval):
12385 Now static.
12386 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12387
77382fcc
PE
12388 * insdel.c: Make symbols static if they're not exported.
12389 However, leave prepare_to_modify_buffer alone. It's never
12390 called from outside this function, but that appears to be a bug.
12391 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12392 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12393 (adjust_after_replace_noundo): Remove; unused.
12394 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12395 (signal_before_change): Remove decls.
77382fcc 12396
9306c32e
PE
12397 * indent.c (val_compute_motion, val_vmotion): Now static.
12398
cd44d2eb
PE
12399 * image.c: Make symbols static if they're not exported.
12400 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12401 if USE_GTK.
12402 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12403 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12404
ad9a7a06
PE
12405 * fringe.c (standard_bitmaps): Now static.
12406 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12407
81626931
PE
12408 * frame.c: Make symbols static if they're not exported.
12409 (x_report_frame_params, make_terminal_frame): Now static.
12410 (get_frame_param): Now static, unless HAVE_NS.
12411 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12412 (x_get_resource_string): Remove; not used.
12413 * frame.h (make_terminal_frame, x_report_frame_params):
12414 (x_get_resource_string); Remove decls.
12415 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12416 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12417
239f9db9
PE
12418 * font.c, fontset.c: Make symbols static if they're not exported.
12419 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12420 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12421 * font.c (font_close_object): Now static.
12422 * font.h (font_close_object): Remove.
12423 * fontset.c (FONTSET_OBJLIST): Remove.
12424 (free_realized_fontset) #if-0 the body, which does nothing.
12425 (face_suitable_for_char_p): #if-0, as it's never called.
12426 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12427 * xfaces.c (face_at_string_position):
12428 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12429 since 0 is always ASCII.
12430
dfcf3579
PE
12431 * fns.c (weak_hash_tables): Now static.
12432
5045092b
PE
12433 * fileio.c: Make symbols static if they're not exported.
12434 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12435 (Vwrite_region_annotation_buffers): Now static.
12436
57a96f5c
PE
12437 * eval.c: Make symbols static if they're not exported.
12438 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12439 * lisp.h (backtrace_list): Remove decl.
12440
35f08c38
PE
12441 * emacs.c: Make symbols static if they're not exported.
12442 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12443 (fatal_error_code, fatal_error_signal_hook, standard_args):
12444 Now static.
12445 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12446 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12447 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12448 * lisp.h (fatal_error_signal_hook): Remove decl.
12449 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12450
f44bd759
PE
12451 * editfns.c: Move a (normally-unused) function to its only use.
12452 * editfns.c, lisp.h (get_operating_system_release): Remove.
12453 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12454 worth the hassle of breaking this out.
12455
b532497d
PE
12456 * xterm.c: Make symbols static if they're not exported.
12457 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12458 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12459 (x_destroy_window, x_delete_display):
12460 Now static.
12461 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12462 (x_mouse_leave): Remove; unused.
12463 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12464 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12465 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12466 Remove decls.
12467 (x_mouse_leave): Declare only if WINDOWSNT.
12468 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12469 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12470 USE_X_TOOLKIT.
12471
1675728f
PE
12472 * ftxfont.c: Make symbols static if they're not exported.
12473 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12474 HAVE_FREETYPE.
12475 * font.h (ftxfont_driver): Likewise.
12476
e4cebfca
PE
12477 * xfns.c: Make symbols static if they're not exported.
12478 (x_last_font_name, x_display_info_for_name):
12479 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12480 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12481 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12482 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12483 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12484 (last_show_tip_args): Now static.
12485 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12486 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12487 (x_screen_planes): Remove; unused.
12488 * dispextern.h (x_screen_planes): Remove decl.
12489
5bf46f05
PE
12490 * dispnew.c: Make symbols static if they're not exported.
12491 * dispextern.h (redraw_garbaged_frames, scrolling):
12492 (increment_row_positions): Remove.
12493 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12494 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12495 Now static.
12496 (redraw_garbaged_frames): Remove; unused.
12497
435f4c28
PE
12498 * xfaces.c: Make symbols static if they're not exported.
12499 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12500 Remove decls.
12501 * xterm.h (defined_color): Remove decls.
12502 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12503 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12504 (menu_face_changed_default, defined_color, free_realized_face):
12505 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12506 (ascii_face_of_lisp_face): Remove; unused.
12507
8524aef3
PE
12508 * xdisp.c: Make symbols static if they're not exported.
12509 * dispextern.h (scratch_glyph_row, window_box_edges):
12510 (glyph_to_pixel_coords, set_cursor_from_row):
12511 (get_next_display_element, set_iterator_to_next):
12512 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12513 (show_mouse_face): Remove decls
12514 * frame.h (message_buf_print): Likewise.
12515 * lisp.h (pop_message, set_message, check_point_in_composition):
12516 Likewise.
12517 * xterm.h (set_vertical_scroll_bar): Likewise.
12518 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12519 (message_buf_print, scratch_glyph_row, displayed_buffer):
12520 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12521 (get_next_display_element, show_mouse_face, window_box_edges):
12522 (frame_to_window_pixel_xy, check_point_in_composition):
12523 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12524 (glyph_to_pixel_coords): Remove; unused.
12525
16390cd2
PE
12526 * dired.c (file_name_completion): Now static.
12527
12528 * dbusbind.c (xd_in_read_queued_messages): Now static.
12529
a25f4dfa
PE
12530 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12531 * data.c (circular_list_error): Remove.
12532
14a9c8df
PE
12533 * commands.h (last_point_position, last_point_position_buffer):
12534 (last_point_position_window): Remove decls.
12535 * keyboard.c: Make these variables static.
12536
04f2d78b
CB
12537 * coding.h (coding, code_convert_region, encode_coding_gap):
12538 Remove decls.
74ab6df5
PE
12539 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12540 (iso_code_class, detect_coding, code_convert_region): Now static.
12541 (encode_coding_gap): Remove; unused.
12542
38dfbee1
PE
12543 * chartab.c (chartab_chars, chartab_bits): Now static.
12544
a2cb4e63
PE
12545 * charset.h (charset_iso_8859_1): Remove decl.
12546 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12547 Now static.
12548
127198fd
PE
12549 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12550 * ccl.c (Vccl_program_table): Now static.
12551 (check_ccl_update): Remove; unused.
12552
d85b608f
PE
12553 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12554 * category.h: ... from here.
12555 * category.c (check_category_table, set_category_set): Now static.
12556
31cd66f3
PE
12557 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12558 * lisp.h: Remove these decls.
12559
c358e587
PE
12560 * buffer.c (buffer_count): Remove unused var.
12561
e78aecca
PE
12562 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12563 so that it's not optimized away.
12564 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12565 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12566 exported only to the debugger.
12567
e192d7d3 12568 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12569 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12570
92470028
PE
12571 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12572 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12573 was inaccessible from Lisp.
12574 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12575 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12576
244ed907
PE
12577 alloc.c: Import and export fewer symbols, and remove unused items.
12578 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12579 is defined.
12580 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12581 it's not optimized away by whole-program optimization.
12582 (message_enable_multibyte, free_misc): Remove.
12583 (catchlist, handlerlist, mark_backtrace):
12584 Declare only if BYTE_MARK_STACK.
12585 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12586 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12587 (message_enable_multibyte): Remove decl.
12588 (free_misc, interval_free_list, float_block, float_block_index):
12589 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12590 (cons_free_list, last_marked_index):
12591 Now static.
12592 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12593 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12594 (mark_backtrace): Define only if BYTE_MARK_STACK.
12595 * xdisp.c (message_enable_multibyte): Now static.
12596
61c2b50e 12597 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12598 This makes it easier for human readers (and static analyzers)
12599 to see whether these variables are used from other modules.
12600 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12601 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12602 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12603 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12604 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12605 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12606 * xmenu.c, xselect.c:
12607 Declare Q* vars static if they are not used in other modules.
12608 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12609 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12610 Remove decls of unexported vars.
12611 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12612
95c82688
PE
12613 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12614
16a97296
PE
12615 Make Emacs functions such as Fatom 'static' by default.
12616 This makes it easier for human readers (and static analyzers)
12617 to see whether these functions can be called from other modules.
12618 DEFUN now defines a static function. To make the function external
12619 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12620 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12621 (Finit_image_library):
16a97296
PE
12622 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12623 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12624 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12625 Remove decls, since these functions are now static.
12626 (Funintern, Fget_internal_run_time): New decls, since these functions
12627 were already external.
95c82688 12628
16a97296
PE
12629 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12630 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12631 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12632 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12633 * keyboard.c, keymap.c, lread.c:
12634 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12635 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12636 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12637 Mark functions with DEFUE instead of DEFUN,
12638 if they are used in other modules.
12639 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12640 decls for now-static functions.
12641 * buffer.h (Fdelete_overlay): Remove decl.
12642 * callproc.c (Fgetenv_internal): Mark as internal.
12643 * composite.c (Fremove_list_of_text_properties): Remove decl.
12644 (Fcomposition_get_gstring): New forward static decl.
12645 * composite.h (Fcomposite_get_gstring): Remove decl.
12646 * dired.c (Ffile_attributes): New forward static decl.
12647 * doc.c (Fdocumntation_property): New forward static decl.
12648 * eval.c (Ffetch_bytecode): New forward static decl.
12649 (Funintern): Remove extern decl; now in .h file where it belongs.
12650 * fileio.c (Fmake_symbolic_link): New forward static decl.
12651 * image.c (Finit_image_library): New forward static decl.
12652 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12653 * intervals.h (Fprevious_property_change):
12654 (Fremove_list_of_text_properties): Remove decls.
12655 * keyboard.c (Fthis_command_keys): Remove decl.
12656 (Fcommand_execute): New forward static decl.
12657 * keymap.c (Flookup_key): New forward static decl.
12658 (Fcopy_keymap): Now static.
12659 * keymap.h (Flookup_key): Remove decl.
12660 * process.c (Fget_process): New forward static decl.
12661 (Fprocess_datagram_address): Mark as internal.
12662 * syntax.c (Fsyntax_table_p): New forward static decl.
12663 (skip_chars): Remove duplicate decl.
12664 * textprop.c (Fprevious_property_change): New forward static decl.
12665 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12666 Now internal.
12667 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12668 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12669
785bbd42
PE
12670 * editfns.c (Fformat): Remove unreachable code.
12671
8b913b57
AS
126722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12673
12674 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12675 change. (Bug#8496)
12676
a6744a35
EZ
126772011-04-13 Eli Zaretskii <eliz@gnu.org>
12678
12679 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12680 when at ZV. (Bug#8487)
12681
e7974947
AS
126822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12683
baad03f0
AS
12684 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12685 (Bug#8437)
12686 * keyboard.c (parse_tool_bar_item): Likewise.
12687 * sound.c (sound_cleanup, alsa_close): Likewise.
12688 * termcap.c (tgetent): Likewise.
12689 * xfns.c (x_default_font_parameter): Likewise.
12690 * xsettings.c (read_and_apply_settings): Likewise.
12691
e7974947
AS
12692 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12693 (overrun_check_free): Protoize.
12694
28272684
PE
126952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12696
12697 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12698 since callers should never pass a negative size.
12699 Change the signature to match that of plain 'read' and 'write'; see
12700 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12701 * lisp.h: Update prototypes of emacs_write and emacs_read.
12702
11997c76
EZ
127032011-04-11 Eli Zaretskii <eliz@gnu.org>
12704
12705 * xdisp.c (redisplay_window): Don't try to determine the character
12706 position of the scroll margin if the window start point w->startp
e896f03c 12707 is outside the buffer's accessible region. (Bug#8468)
11997c76 12708
8a2cbd72
EZ
127092011-04-10 Eli Zaretskii <eliz@gnu.org>
12710
12711 Fix write-region and its subroutines for buffers > 2GB.
12712 * fileio.c (a_write, e_write): Modify declaration of arguments and
12713 local variables to support buffers larger than 2GB.
12714 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12715
12716 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12717 argument, local variables, and return value.
12718
12719 * lisp.h: Update prototypes of emacs_write and emacs_read.
12720
12721 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12722
4073e537 127232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12724
1ebfdcb6
PE
12725 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12726
b2ded58d
PE
12727 Fix more problems found by GCC 4.6.0's static checks.
12728
7d66342c
PE
12729 * xdisp.c (vmessage): Use a better test for character truncation.
12730
bbf47d44
PE
12731 * charset.c (load_charset_map): <, not <=, for optimization,
12732 and to avoid potential problems with integer overflow.
9248994d 12733 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12734 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12735 * editfns.c (Fformat): Likewise.
1e69125e 12736 * syntax.c (skip_chars): Likewise.
3befa583 12737
e3019616
PE
12738 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12739 This also lets GCC 4.6.0 generate slightly better loop code.
12740
becfa255
PE
12741 * callint.c (Fcall_interactively): <, not <=, for optimization.
12742 (Fcall_interactively): Count the number of arguments produced,
12743 not the number of arguments given. This is simpler and lets GCC
12744 4.6.0 generate slightly better code.
12745
dae0cd48
PE
12746 * ftfont.c: Distingish more carefully between FcChar8 and char.
12747 The previous code passed unsigned char * to a functions like
12748 strlen and xstrcasecmp that expect char *, which does not
12749 conform to the C standard.
12750 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12751 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12752 char * when the C standard requires it.
12753
76032d70
PE
12754 * keyboard.c (read_char): Remove unused var.
12755
eb3f1cc8
PE
12756 * eval.c: Port to Windows vsnprintf (Bug#8435).
12757 Include <limits.h>.
12758 (SIZE_MAX): Define if the headers do not.
12759 (verror): Do not give up if vsnprintf returns a negative count.
12760 Instead, grow the buffer. This ports to Windows vsnprintf, which
12761 does not conform to C99. Problem reported by Eli Zaretskii.
12762 Also, simplify the allocation scheme, by avoiding the need for
12763 calling realloc, and removing the ALLOCATED variable.
12764
70476b54
PE
12765 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12766
12020a9e
PE
12767 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12768 But keep the doprint source code for now, as we might revamp it
12769 and use it again (Bug#8435).
ea6c7ae6
PE
12770 * lisp.h (doprnt): Remove.
12771 * Makefile.in (base_obj): Remove doprnt.o.
12772 * deps.mk (doprnt.o): Remove.
12773
5fdb398c
PE
12774 error: Print 32- and 64-bit integers portably (Bug#8435).
12775 Without this change, on typical 64-bit hosts error ("...%d...", N)
12776 was used to print both 32- and 64-bit integers N, which relied on
12777 undefined behavior.
61bdb816 12778 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12779 * lisp.h (error, verror): Mark as printf-like functions.
12780 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12781 Report overflow in size calculations when allocating printf buffer.
12782 Do not truncate output string at its first null byte.
12783 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12784 Truncate the output at a character boundary, since vsnprintf does not
12785 do that.
12786 * charset.c (check_iso_charset_parameter): Convert internal
12787 character to string before calling 'error', since %c now has the
12788 printf meaning.
12789 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12790 overflow when computing char to be passed to 'error'. Do not
12791 pass Lisp_Object to 'error'; pass the integer instead.
12792 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12793 formatted with plain %d.
12794
b189fa66
PE
12795 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12796
bff87ef0
PE
12797 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12798
7e2cac20
PE
12799 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12800
ce4d90b5
PE
12801 * xterm.c (x_catch_errors): Remove duplicate declaration.
12802
266c9547
PE
12803 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12804
79c49ad2
PE
12805 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12806
368f4090
JM
128072011-04-10 Jim Meyering <meyering@redhat.com>
12808
12809 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12810 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12811 return ssize_t not "int", and use size_t as the buffer length.
12812 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12813 * gnutls.h: Update declarations.
12814 * process.c (read_process_output): Use ssize_t, to match.
12815 (send_process): Likewise.
12816
a32d4040
CY
128172011-04-09 Chong Yidong <cyd@stupidchicken.com>
12818
12819 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12820
8546720e 128212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12822
04f2d78b
CB
12823 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12824 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12825
8546720e
GM
12826 * xterm.c (handle_one_xevent):
12827 * xmenu.c (create_and_show_popup_menu):
12828 * xselect.c (x_decline_selection_request)
12829 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12830
0a2f5c1a 128312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12832
12833 Fix some uses of `int' instead of EMACS_INT.
12834 * search.c (string_match_1, fast_string_match)
12835 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12836 (scan_buffer, find_next_newline_no_quit)
12837 (find_before_next_newline, search_command, Freplace_match)
12838 (Fmatch_data): Make some `int' variables be EMACS_INT.
12839
12840 * xdisp.c (display_count_lines): 3rd argument and return value now
12841 EMACS_INT. All callers changed.
12842 (pint2hrstr): Last argument is now EMACS_INT.
12843
12844 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12845 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12846 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12847 (decode_coding_utf_16, decode_coding_emacs_mule)
12848 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12849 (decode_coding_ccl, decode_coding_charset)
12850 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12851 (decode_coding_iso_2022, decode_coding_emacs_mule)
12852 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12853 <char_offset, last_offset>: Declare EMACS_INT.
12854 (encode_coding_utf_8, encode_coding_utf_16)
12855 (encode_coding_emacs_mule, encode_invocation_designation)
12856 (encode_designation_at_bol, encode_coding_iso_2022)
12857 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12858 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12859 Declare EMACS_INT.
12860 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12861 (encode_invocation_designation): Last argument P_NCHARS is now
12862 EMACS_INT.
12863 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12864 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12865
12866 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12867 All users changed.
12868
12869 * ccl.c (Fccl_execute_on_string): Declare some variables
12870 EMACS_INT.
12871
8546720e 128722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12873
12874 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12875
4e19a977
CS
128762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12877
12878 * process.c (Fformat_network_address): Doc fix.
12879
87302331
R
128802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12881
ee7683eb 12882 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12883
cbb59342
CY
128842011-04-08 Chong Yidong <cyd@stupidchicken.com>
12885
12886 * keyboard.c (read_char): Call Lisp function help-form-show,
12887 instead of using internal_with_output_to_temp_buffer.
12888 (Qhelp_form_show): New var.
e0d38eeb 12889 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12890
12891 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12892
12893 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12894
e67a13ab
CY
128952011-04-06 Chong Yidong <cyd@stupidchicken.com>
12896
04f2d78b
CB
12897 * process.c (Flist_processes): Remove to Lisp.
12898 (list_processes_1): Delete.
e67a13ab 12899
973f782d
EZ
129002011-04-06 Eli Zaretskii <eliz@gnu.org>
12901
7c106b1e
EZ
12902 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12903
973f782d
EZ
12904 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12905
41cf7d1a 129062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12907
ca23cc88
PE
12908 Fix more problems found by GCC 4.6.0's static checks.
12909
f390e2d5
PE
12910 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12911
42eea0d0
PE
12912 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12913
b69769da 12914 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12915
f9541e84
PE
12916 * xdisp.c (vmessage): Mark as a printf-like function.
12917
13841b55
PE
12918 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12919
c136c10f
PE
12920 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12921
5e2d4a30
PE
12922 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12923 printf-like functions.
12924 (tiff_load): Add casts to remove these marks before passing them
12925 to system-supplied API.
12926
583f48b9
PE
12927 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12928
b25d760e
PE
12929 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12930 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12931 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12932 directly, rather than having caller test rule sign. This avoids
12933 some unnecessary tests.
12934 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12935 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12936 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12937
bc7b6697 12938 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12939 (xfont_open): Avoid unnecessary tests.
bc7b6697 12940
27ccc379
PE
12941 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12942
dcd5c89a
PE
12943 * composite.h, composite.c (composition_gstring_put_cache):
12944 Use EMACS_INT, not int, for length.
12945
b13a45c6
PE
12946 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12947 breaking out part of COMPOSITION_DECODE_RULE.
12948 (COMPOSITION_DECODE_RULE): Use it.
12949 * composite.c (get_composition_id): Remove unused local vars,
12950 by using the new macro.
12951
1e792e4d
PE
12952 * textprop.c (set_text_properties_1): Change while to do-while,
12953 since the condition is always true at first.
12954
dc6c6455 12955 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12956 (interval_deletion_adjustment): Return unsigned value.
12957 All uses changed.
dc6c6455 12958
aba7731a
PE
12959 * process.c (list_processes_1, create_pty, read_process_output):
12960 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12961 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12962 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12963 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12964 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12965
fdfc4bf3
PE
12966 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12967
fca8fe46 12968 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12969 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12970
06a0259a 12971 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12972 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12973 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12974
e7b9e80f
PE
12975 * print.c (print_error_message): Avoid int overflow.
12976
56201685
PE
12977 * font.c (font_list_entities): Redo for clarity,
12978 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12979
78834453 12980 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12981 (font_score): Avoid potential overflow in diff calculation.
78834453 12982
0bc0b309 12983 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12984 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12985
e610eaca
PE
12986 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12987
b895abce
PE
12988 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12989 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12990 can always succeed if overflow has undefined behavior.
12991
1f1d9321 12992 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12993 (wordify): Omit three unnecessary tests.
1f1d9321 12994
c59478bc
PE
12995 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12996 All callers changed. This avoids the need for an unused var.
12997
79b73827
PE
12998 * casefiddle.c (casify_region): Remove var that is set but not used.
12999
a4db5dfe
PE
13000 * dired.c (file_name_completion): Remove var that is set but not used.
13001
43aae36e
PE
13002 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13003
2a47c44d 13004 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13005 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13006
a37c69bf
PE
13007 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13008 Check for integer overflow on size calculations.
13009
328ab8e7
PE
13010 * buffer.c (Fprevious_overlay_change): Remove var that is set
13011 but not used.
13012
e5a2a5cb
PE
13013 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13014 Remove vars that are set but not used.
8d84a6eb 13015 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13016 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13017
a60e5f68
PE
13018 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13019
f661cb61 13020 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13021 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13022
f0397f5a
PE
13023 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13024 that are set but not used.
13025
8664db06 13026 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13027 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13028
6abdaa4a
PE
13029 * xselect.c (x_get_local_selection, x_handle_property_notify):
13030 Remove vars that are set but not used.
13031
0ce7538d 13032 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13033 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13034
9ae848fc
PE
13035 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13036 Remove var that is set but not used.
0b918413
PE
13037 (scroll_bar_windows_size): Now size_t, not int.
13038 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13039 Check for overflow.
9ae848fc 13040
a5a62657
PE
13041 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13042 (map_tty_color) [!defined MSDOS]: Likewise.
13043
5c5cdd39
PE
13044 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13045
66ebf983
PE
13046 * coding.c: Remove vars that are set but not used.
13047 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13048 All callers changed.
13049 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13050 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13051 (decode_coding_charset): Remove vars that are set but not used.
13052
1be4d761
PE
13053 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13054 that is set but not used.
13055
47553fa8
PE
13056 * print.c (print_object): Remove var that is set but not used.
13057
1f7196bf 13058 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13059 The gnulib version avoids calling malloc in the usual case,
13060 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13061 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13062 * filelock.c (current_lock_owner): Likewise.
13063 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13064 * sysdep.c: Include allocator.h, careadlinkat.h.
13065 (emacs_no_realloc_allocator): New static constant.
13066 (emacs_readlink): New function.
fdb61804
PE
13067 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13068 ../lib/careadlinkat.h.
d1fdcab7 13069
f84c17c7
SM
130702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13071
13072 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13073 first non-nil return value).
13074
ef3862ad
JD
130752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13076
13077 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13078 if not defined (Bug#8403).
13079
376a7006
JB
130802011-04-02 Juanma Barranquero <lekktu@gmail.com>
13081
13082 * xdisp.c (display_count_lines): Remove parameter `start',
13083 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13084 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13085 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13086 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13087 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13088 and thereabouts. All callers changed.
13089 (get_per_char_metric): Remove parameter `f', unused since
13090 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13091
6ca3801d
JM
130922011-04-02 Jim Meyering <meyering@redhat.com>
13093
13094 do not dereference NULL upon failed strdup
13095 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13096 (ns_get_family): Likewise.
13097
d8e2b5ba
JB
130982011-04-02 Juanma Barranquero <lekktu@gmail.com>
13099
13100 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13101
8c74fcbd
JD
131022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13103
13104 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13105 later (Bug#8403).
13106
7200d79c
SM
131072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13108
03408648 13109 Add lexical binding.
7200d79c 13110
03408648
SM
13111 * window.c (Ftemp_output_buffer_show): New fun.
13112 (Fsave_window_excursion):
13113 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13114
13115 * lread.c (lisp_file_lexically_bound_p): New function.
13116 (Fload): Bind Qlexical_binding.
13117 (readevalloop): Remove `evalfun' arg.
13118 Bind Qinternal_interpreter_environment.
13119 (Feval_buffer): Bind Qlexical_binding.
13120 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13121 Mark as dynamic.
13122 (syms_of_lread): Declare `lexical-binding'.
13123
13124 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13125
13126 * keyboard.c (eval_dyn): New fun.
13127 (menu_item_eval_property): Use it.
ca105506
SM
13128
13129 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13130
03408648
SM
13131 * fns.c (concat, mapcar1): Accept byte-code-functions.
13132
13133 * eval.c (Fsetq): Handle lexical vars.
13134 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13135 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13136 (FletX, Flet): Obey lexical binding.
13137 (Fcommandp): Handle closures.
13138 (Feval): New `lexical' arg.
13139 (eval_sub): New function extracted from Feval. Use it almost
13140 everywhere where Feval was used. Look up vars in lexical env.
13141 Handle closures.
13142 (Ffunctionp): Move from subr.el.
13143 (Ffuncall): Handle closures.
13144 (apply_lambda): Remove `eval_flags'.
13145 (funcall_lambda): Handle closures and new byte-code-functions.
13146 (Fspecial_variable_p): New function.
13147 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13148 but without exporting it to Lisp.
23aba0ea 13149
23aba0ea 13150 * doc.c (Fdocumentation, store_function_docstring):
03408648 13151 * data.c (Finteractive_form): Handle closures.
23aba0ea 13152
03408648
SM
13153 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13154 interactive spec.
ba83908c 13155
04f2d78b
CB
13156 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13157 New byte-codes.
03408648
SM
13158 (exec_byte_code): New function extracted from Fbyte_code to handle new
13159 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13160
03408648 13161 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13162
03408648 13163 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13164
e2abce01
JB
131652011-03-31 Juanma Barranquero <lekktu@gmail.com>
13166
13167 * xdisp.c (redisplay_internal): Fix prototype.
13168
63696a73 131692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13170
63696a73 13171 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13172 (try_scrolling): Use it when setting scroll_limit.
13173 Limit scrolling to 100 screen lines.
63696a73
EZ
13174 (redisplay_window): Even when falling back on "recentering",
13175 position point in the window according to scroll-conservatively,
13176 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13177
13178 (try_scrolling): When point is above the window, allow searching
13179 as far as scroll_max, or one screenful, to compute vertical
13180 distance from PT to the scroll margin position. This prevents
13181 try_scrolling from unnecessarily failing when
13182 scroll-conservatively is set to a value slightly larger than the
13183 window height. Clean up the case of PT below the margin at bottom
13184 of window: scroll_max can no longer be INT_MAX. When aggressive
13185 scrolling is in use, don't let point enter the opposite scroll
13186 margin as result of the scroll.
13187 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13188 threshold of 100 lines for never-recentering scrolling.
13189
e4cc2dfc
JB
131902011-03-31 Juanma Barranquero <lekktu@gmail.com>
13191
13192 * dispextern.h (move_it_by_lines):
13193 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13194 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13195 (message_log_check_duplicate): Remove parameters `prev_bol' and
13196 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13197 (redisplay_internal): Remove parameter `preserve_echo_area',
13198 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13199
13200 * indent.c (Fvertical_motion):
13201 * window.c (window_scroll_pixel_based, Frecenter):
13202 Don't pass `need_y_p' to `move_it_by_lines'.
13203
1c470562
SM
132042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13205
44f230aa
SM
13206 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13207 steal a few bits to be more compact.
13208 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13209 Remove unneeded casts.
13210
1c470562
SM
13211 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13212
888adce9
ZK
132132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13214
13215 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13216 binding" message (bug#7967).
13217
f838ed7b
PE
132182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13219
77861b95
PE
13220 Fix more problems found by GCC 4.6.0's static checks.
13221
de6dbc14
PE
13222 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13223 Remove unused local var.
13224
f838ed7b
PE
13225 * editfns.c (Fmessage_box): Remove unused local var.
13226
792c7b2b
PE
13227 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13228 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13229 Omit unused local vars.
c499e557 13230 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13231 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13232 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13233 Omit unused local var.
13234
ba0165e1
PE
13235 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13236 Don't assume string length fits in int.
32ad8845 13237 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13238 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13239
3c59b4c9
PE
13240 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13241 instead of alloca (Bug#8344).
13242
a3eed478 13243 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13244 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13245
eb4d412d
PE
13246 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13247
1658b401
PE
13248 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13249 concerns.
13250
13251 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13252
13253 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13254
9a2c6e05
PE
13255 * keyboard.c (syms_of_keyboard): Use the same style as later
13256 in this function when indexing through an array. This also
13257 works around GCC bug 48267.
13258
03d0a109
PE
13259 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13260
44f730c8
PE
13261 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13262
fe75f926
PE
13263 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13264 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13265
ffa8c828
PE
13266 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13267 This avoids undefined behavior on integer overflow, and is a bit
13268 more convenient anyway since it is compared to a size_t variable.
13269
c5101a77
PE
13270 Variadic C functions now count arguments with size_t, not int.
13271 This avoids an unnecessary limitation on 64-bit machines, which
13272 caused (substring ...) to crash on large vectors (Bug#8344).
13273 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13274 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13275 All variadic functions and their callers changed accordingly.
c5101a77
PE
13276 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13277 * data.c (arith_driver, float_arith_driver): Likewise.
13278 * editfns.c (general_insert_function): Likewise.
13279 * eval.c (struct backtrace.nargs, interactive_p)
13280 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13281 (funcall_lambda, mark_backtrace): Likewise.
13282 * fns.c (concat): Likewise.
13283 * frame.c (x_set_frame_parameters): Likewise.
13284 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13285 0 if not found, not -1. All callers changed.
13286
dd3f25f7
PE
13287 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13288 (stack_copy_size): Now size_t, not int.
13289 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13290
461c2ab9
JB
132912011-03-28 Juanma Barranquero <lekktu@gmail.com>
13292
13293 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13294 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13295 All callers changed.
13296
13297 * lisp.h (multibyte_char_to_unibyte):
13298 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13299 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13300 * character.h (CHAR_TO_BYTE8):
13301 * cmds.c (internal_self_insert):
13302 * editfns.c (general_insert_function):
13303 * keymap.c (push_key_description):
13304 * search.c (Freplace_match):
13305 * xdisp.c (message_dolog, set_message_1): All callers changed.
13306
f6d62986
SM
133072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13308
13309 * keyboard.c (safe_run_hook_funcall): New function.
13310 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13311 don't set the hook to nil, but remove the offending function instead.
13312 (Qcommand_hook_internal): Remove, unused.
13313 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13314 Vcommand_hook_internal.
13315
13316 * eval.c (enum run_hooks_condition): Remove.
13317 (funcall_nil, funcall_not): New functions.
13318 (run_hook_with_args): Call each function through a `funcall' argument.
13319 Remove `cond' argument, now redundant.
13320 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13321 (Frun_hook_with_args_until_failure): Adjust accordingly.
13322 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13323
1db5b1ad
JB
133242011-03-28 Juanma Barranquero <lekktu@gmail.com>
13325
13326 * dispextern.h (string_buffer_position): Remove declaration.
13327
13328 * print.c (strout): Remove parameter `multibyte', unused since
13329 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13330
13331 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13332 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13333 All callers changed.
13334
13335 * w32.c (_wsa_errlist): Use braces for struct initializers.
13336
13337 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13338 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13339 All callers changed.
13340 (string_buffer_position): Likewise. Also, make static (it's never
13341 used outside xdisp.c).
13342 (cursor_row_p): Remove parameter `w', unused since
13343 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13344 (decode_mode_spec): Remove parameter `precision', introduced during
13345 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13346 All callers changed.
13347
5ffb62aa
JD
133482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13349
13350 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13351
461c2ab9 133522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13353
13354 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13355 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13356 (ns_update_auto_hide_menu_bar): New functions.
13357 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13358 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13359 ns_constrain_all_frames.
13360 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13361 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13362
5c380ffb
JD
133632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13364
13365 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13366
9af30bdf
GM
133672011-03-27 Glenn Morris <rgm@gnu.org>
13368
13369 * syssignal.h: Replace RETSIGTYPE with void.
13370 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13371 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13372 Replace SIGTYPE with void everywhere.
13373 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13374 * s/template.h (SIGTYPE): Remove commented out definition.
13375
e2abce01
JB
133762011-03-26 Eli Zaretskii <eliz@gnu.org>
13377
13378 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13379 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13380
f868cd8a
JB
133812011-03-26 Juanma Barranquero <lekktu@gmail.com>
13382
59eb0929
JB
13383 * w32.c (read_unc_volume): Use parameter `henum', instead of
13384 global variable `wget_enum_handle'.
13385
13386 * keymap.c (describe_vector): Remove parameters `indices' and
13387 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13388 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13389
f868cd8a
JB
13390 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13391
13392 * keyboard.c (timer_check): Remove parameter `do_it_now',
13393 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13394 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13395 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13396
13397 * keyboard.c (read_char):
13398 * w32menu.c (w32_menu_display_help):
13399 * xmenu.c (show_help_event, menu_help_callback):
13400 Adjust calls to `show_help_echo'.
13401
13402 * gtkutil.c (xg_maybe_add_timer):
13403 * keyboard.c (readable_events):
13404 * process.c (wait_reading_process_output):
13405 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13406
13407 * insdel.c (adjust_markers_gap_motion):
13408 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13409 (gap_left, gap_right): Don't call it.
13410
2ecf6fdb
CY
134112011-03-25 Chong Yidong <cyd@stupidchicken.com>
13412
13413 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13414 incurred during fontification.
13415
6b1f9ba4
JB
134162011-03-25 Juanma Barranquero <lekktu@gmail.com>
13417
13418 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13419 (DEFVAR_PER_BUFFER): Don't pass it.
13420
13421 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13422 (scrolling_window): Don't pass it.
13423
0f4a96b5
JB
134242011-03-25 Juanma Barranquero <lekktu@gmail.com>
13425
13426 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13427
13428 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13429 and `suffix'.
13430 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13431 of variables specific to SELinux and computation of `encoded_absname'.
13432
13433 * image.c (XPutPixel): Remove unused variable `height'.
13434
13435 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13436
13437 * unexw32.c (get_section_info): Remove unused variable `section'.
13438
13439 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13440 (system_process_attributes): Remove unused variable `sess'.
13441 (sys_read): Remove unused variable `err'.
13442
13443 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13444 (w32_wnd_proc): Remove unused variable `isdead'.
13445 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13446 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13447 (x_create_tip_frame): Remove unused variable `tem'.
13448
13449 * w32inevt.c (w32_console_read_socket):
13450 Remove unused variable `no_events'.
13451
13452 * w32term.c (x_draw_composite_glyph_string_foreground):
13453 Remove unused variable `width'.
13454
1149507c
JB
134552011-03-24 Juanma Barranquero <lekktu@gmail.com>
13456
13457 * w32term.c (x_set_glyph_string_clipping):
13458 Don't pass uninitialized region to CombineRgn.
13459
9c88f339
JB
134602011-03-23 Juanma Barranquero <lekktu@gmail.com>
13461
13462 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13463 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13464 (Fx_close_connection): Remove unused variable `i'.
13465
13466 * w32font.c (w32font_draw): Return number of glyphs.
13467 (w32font_open_internal): Remove unused variable `i'.
13468 (w32font_driver): Add missing initializer.
13469
13470 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13471 (fill_in_menu): Remove unused variable `items_added'.
13472
13473 * w32term.c (last_mouse_press_frame): Remove static global variable.
13474 (w32_clip_to_row): Remove unused variable `f'.
13475 (x_delete_terminal): Remove unused variable `i'.
13476
13477 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13478 (NOTHING): Remove unused static global variable.
13479 (uniscribe_check_otf): Remove unused variable `table'.
13480 (uniscribe_font_driver): Add missing initializers.
13481
dee091a3
JD
134822011-03-23 Julien Danjou <julien@danjou.info>
13483
13484 * term.c (Fsuspend_tty, Fresume_tty):
13485 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13486 * window.c (temp_output_buffer_show):
13487 * insdel.c (signal_before_change):
13488 * frame.c (Fhandle_switch_frame):
13489 * fileio.c (Fdo_auto_save):
13490 * emacs.c (Fkill_emacs):
13491 * editfns.c (save_excursion_restore):
13492 * cmds.c (internal_self_insert):
13493 * callint.c (Fcall_interactively):
13494 * buffer.c (Fkill_all_local_variables):
13495 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13496 Use Frun_hooks.
0f4a96b5 13497 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13498 unconditionally since it does the check itself.
dee091a3 13499
2c520ab5 135002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13501
c9c49752
PE
13502 Fix more problems found by GCC 4.5.2's static checks.
13503
8abc3f12
PE
13504 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13505 the first time through the loop, since we know p0 < p1 then.
13506 This also avoids a gcc -Wstrict-overflow warning.
13507
a2d26660
PE
13508 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13509 leading to a memory leak, possible in functions like
13510 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13511 of objects (Bug#8318).
a2d26660 13512
916c72e9
PE
13513 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13514 that could (at least in theory) be that large.
13515
19ab8a18
PE
13516 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13517 This is less likely to overflow, and avoids undefined behavior if
13518 overflow does occur. All callers changed. Use strtoul to scan
13519 for the unsigned long integer.
b7cbbd6f
PE
13520 (pint2hrstr): Simplify and tune code slightly.
13521 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13522
f0641eff
PE
13523 * scroll.c (do_scrolling): Work around GCC bug 48228.
13524 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13525
7f650bb9
PE
13526 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13527 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13528 (validate_x_resource_name): Simplify count usage.
13529 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13530
37dd57d1
PE
13531 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13532 fail (Bug#8306).
81e56e61 13533
699979fc 13534 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13535
401bf9b4
PE
13536 * process.c (Fmake_network_process): Use socklen_t, not int,
13537 where POSIX says socklen_t is required in portable programs.
13538 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13539 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13540 (Fmake_network_process, server_accept_connection):
13541 (wait_reading_process_output, read_process_output):
13542 Likewise.
13543
b93aacde
PE
13544 * process.c: Rename or move locals to avoid shadowing.
13545 (list_processes_1, Fmake_network_process):
13546 (read_process_output_error_handler, exec_sentinel_error_handler):
13547 Rename or move locals.
4dc343ee 13548 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13549 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13550 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13551 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13552 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13553
af8a867c 13554 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13555 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13556 Include tparam.h instead, since it declares them.
af8a867c
PE
13557 * cm.h (PC): Remove extern decl; tparam.h now does this.
13558 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13559 * terminfo.c: Include tparam.h, to check interfaces.
13560 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13561 (tparam): Adjust signature to match interface in tparam.h;
13562 this removes some undefined behavior. Check that outstring and len
13563 are zero, which they always are with Emacs.
13564 * tparam.h (PC, BC, UP): New extern decls.
13565
0248044d 13566 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13567 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13568
8ff096c1 13569 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13570 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13571 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13572 (ftfont_list): Remove unused local.
49eaafba
PE
13573 (get_adstyle_property, ftfont_pattern_entity):
13574 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13575 Rename locals to avoid shadowing.
8ff096c1 13576
e2be39f6
PE
13577 * xfont.c (xfont_list_family): Mark var as initialized.
13578
c9735e30
PE
13579 * xml.c (make_dom): Now static.
13580
8f5201ae
PE
13581 * composite.c (composition_compute_stop_pos): Rename local to
13582 avoid shadowing.
b246f932
PE
13583 (composition_reseat_it): Remove unused locals.
13584 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13585 (composition_update_it): Mark var as initialized.
11b61122
PE
13586 (find_automatic_composition): Mark vars as initialized,
13587 with a FIXME (Bug#8290).
8f5201ae 13588
760fbc2c
PE
13589 character.h: Rename locals to avoid shadowing.
13590 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13591 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13592 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13593 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13594 to avoid shadowing.
13595
ff08eb85
PE
13596 * textprop.c (property_change_between_p): Remove; unused.
13597
fc7bf025
PE
13598 * intervals.c (interval_start_pos): Now static.
13599
235d7abc
PE
13600 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13601
44f230aa
SM
13602 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13603 Rename locals to avoid shadowing.
3e7d6594 13604
50060332
PE
13605 * sound.c (wav_play, au_play, Fplay_sound_internal):
13606 Fix pointer signedness.
d01f234b 13607 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13608 (wav_play): Initialize a variable to 0, to prevent undefined
13609 behavior (Bug#8278).
50060332 13610
c4fc4e30
PE
13611 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13612
918436ed
PE
13613 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13614
c939f91b
PE
13615 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13616 clobbering (Bug#8298).
b9c7f648
PE
13617 * sysdep.c (sys_subshell): Likewise.
13618 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13619
6bd8c144
PE
13620 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13621 This should get cleaned up, so that child_setup has the
13622 same signature on all platforms.
13623
7710357c 13624 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13625 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13626
c59da222
CY
136272011-03-22 Chong Yidong <cyd@stupidchicken.com>
13628
13629 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13630 not to be necessary, and produces flickering.
13631
66b87493
GM
136322011-03-20 Glenn Morris <rgm@gnu.org>
13633
13634 * config.in: Remove file.
13635
45b6f6d5
JB
136362011-03-20 Juanma Barranquero <lekktu@gmail.com>
13637
13638 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13639 are now in src/globals.h.
13640 (syms_of_minibuf): Remove spurious & from previous change.
13641
cd394be1 136422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13643
13644 * minibuf.c (completing-read-function): New variable.
13645 (completing-read-default): Rename from completing-read.
13646 (completing-read): Call completing-read-function.
13647
b14e3e21
CY
136482011-03-19 Juanma Barranquero <lekktu@gmail.com>
13649
13650 * xfaces.c (Fx_load_color_file):
13651 Read color file from absolute filename (bug#8250).
13652
f2b726e6
JB
136532011-03-19 Juanma Barranquero <lekktu@gmail.com>
13654
13655 * makefile.w32-in: Update dependencies.
13656
09f6ff02
EZ
136572011-03-17 Eli Zaretskii <eliz@gnu.org>
13658
13659 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13660
29a6015a
PE
136612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13662
a3a6c54e
PE
13663 Fix more problems found by GCC 4.5.2's static checks.
13664
b766f867
PE
13665 * process.c (make_serial_process_unwind, send_process_trap):
13666 (sigchld_handler): Now static.
13667
be02381c
PE
13668 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13669 That way, the code declares only the vars that it needs.
13670 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13671 * s/cygwin.h (PTY_ITERATION): Likewise.
13672 * s/darwin.h (PTY_ITERATION): Likewise.
13673 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13674
57048744
PE
13675 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13676 * process.c (allocate_pty): Don't declare stb unless it's needed.
13677
7914961c 13678 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13679 (CONSTANTLIM): Remove; unused.
13680 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13681 Define only if needed.
7914961c 13682
b3967b18
PE
13683 * unexelf.c (unexec): Name an expression,
13684 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13685 Use a different way to cause a compilation error if anyone uses
13686 n rather than nn, a way that does not involve shadowing.
73366a00 13687 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13688
29a6015a
PE
13689 * deps.mk (unexalpha.o): Remove; unused.
13690
43cfc33e 13691 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13692 * unexec.h: New file.
ce701a33
PE
13693 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13694 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13695 Depend on unexec.h.
13696 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13697 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13698 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13699 Change as necessary to match prototype in unexec.h.
ce701a33 13700
01f44d5a
PE
13701 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13702 shadowing.
4f63c6bb 13703 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13704
a6670b0b
PE
13705 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13706 Rename locals to avoid shadowing.
13707
cef2010d 13708 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13709 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13710
d4d7173a
PE
13711 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13712
f08b802a
PE
13713 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13714 warning when compiling print.c.
13715
3ddb0639
PE
13716 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13717 instead of using an uninitialized var.
5ad03b97 13718 (font_sort_entities): Mark var as initialized.
3ddb0639 13719
170a2692
PE
13720 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13721
e663c700
PE
13722 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13723 pointers to constants.
89bc529a 13724 (font_parse_fcname): Remove unused vars.
7b81e2d0 13725 (font_delete_unmatched): Now static.
ea838e10 13726 (font_get_spec): Remove; unused.
13a547c6
PE
13727 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13728 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13729 Rename or move locals to avoid shadowing.
e663c700 13730
2a80c887 13731 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13732 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13733
1384fa33 13734 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13735 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13736
8b2c52e9
PE
13737 * alloc.c (mark_backtrace): Move decl from here ...
13738 * lisp.h: ... to here, so that it can be checked.
13739
475545b5 13740 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13741 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13742 (lisp_indirect_variable): Name an expression,
13743 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13744 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13745
b1349114 13746 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13747 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13748 Use const pointer when appropriate.
b1349114 13749
a2928364
PE
13750 * lisp.h (get_system_name, get_operating_system_release):
13751 Move decls here, to check interfaces.
13752 * process.c (get_operating_system_release): Move decl to lisp.h.
13753 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13754 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13755 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13756 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13757 (Fformat_time_string, Fencode_time, Finsert_char):
13758 (Ftranslate_region_internal, Fformat):
13759 Rename or remove local vars to avoid shadowing.
9710023e 13760 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13761
a415e694
PE
13762 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13763 avoid shadowing.
13764
8ef4622d
PE
13765 * lisp.h (eassert): Check that the argument compiles, even if
13766 ENABLE_CHECKING is not defined.
13767
946f9a5b
PE
13768 * data.c (Findirect_variable): Name an expression, to avoid
13769 gcc -Wbad-function-cast warning.
112396d6 13770 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13771 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13772 (Fmake_variable_buffer_local, Fmake_local_variable):
13773 Mark variables as initialized.
52746918 13774 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13775
e5aab7e7 13776 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13777 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13778 Rename locals to avoid shadowing.
dff45157
PE
13779 (mark_stack): Move local variables into the #ifdef region where
13780 they're used.
7bc26fdb
PE
13781 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13782 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13783 needed otherwise.
13784 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13785 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13786 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13787
e5aab7e7
PE
13788 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13789 avoids undefined behavior in theory.
13790
4da60324
PE
13791 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13792
88043301
PE
13793 Use functions, not macros, for up- and down-casing (Bug#8254).
13794 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13795 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13796 to use the following functions instead of these macros.
13797 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13798 EMACS_INT, since callers assume the returned value fits in int.
13799 (upcase1): Likewise, for UPCASE_TABLE.
13800 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13801 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13802 the race-condition problem in the old DOWNCASE.
88043301 13803
19ed5445
PE
13804 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13805 Rename locals to avoid shadowing.
13806 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13807 (regex_compile, re_search_2, re_match_2_internal):
13808 Remove unused local vars.
952db0d7
PE
13809 (FREE_VAR): Rewrite so as not to use empty "else",
13810 which gcc can warn about.
da053e48 13811 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13812 (RETALLOC_IF): Define only if needed.
13813 (WORDCHAR_P): Likewise. This one is never needed, but is used
13814 only in a comment talking about a compiler bug, so put inside
13815 the #if 0 of that comment.
13816 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13817 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13818 Remove; unused.
19ed5445 13819
1f3561e4 13820 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13821 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13822 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13823
ded6f8f7
PE
13824 * search.c (simple_search): Remove unused var.
13825
dbd37a95
PE
13826 * dired.c (compile_pattern): Move decl from here ...
13827 * lisp.h: ... to here, so that it can be checked.
13828 (struct re_registers): New forward decl.
13829
7e47afad
PE
13830 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13831
85f24f61
PE
13832 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13833 All uses changed.
13834 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13835 Rename locals to avoid shadowing.
5671df8f 13836 (Fvertical_motion): Mark locals as initialized.
85f24f61 13837
181aa2be 13838 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13839 (casify_region): Mark local as initialized.
181aa2be 13840
930d429c
PE
13841 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13842
7082eac6
PE
13843 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13844 New macros, so that the caller can use some names other than
13845 gcpro1, gcpro2, etc.
13846 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13847 of the new macros.
13848 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13849 argument, for consistency with GCPRO2_VAR, etc: it is now the
13850 prefix of the variable, not the variable itself. All uses
13851 changed.
38b2c076
PE
13852 * dired.c (directory_files_internal, file_name_completion):
13853 Rename locals to avoid shadowing.
13854
15206ed9
PE
13855 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13856 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13857 dired.c's scmp function, had undefined behavior.
13858 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13859 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13860 * buffer.h: ... to here, because these macros use current_buffer,
13861 and the new implementation with inline functions needs to have
13862 current_buffer in scope now, rather than later when the macros
13863 are used.
13864 (downcase, upcase1): New static inline functions.
13865 (DOWNCASE, UPCASE1): Reimplement using these functions.
13866 This avoids undefined behavior in expressions like
13867 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13868 from race conditions in accessing the global variables
13869 case_temp1 and case_temp2.
13870 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13871 * lisp.h (case_temp1, case_temp2): Remove their decls.
13872 * character.h (ASCII_CHAR_P): Move from here ...
13873 * lisp.h: ... to here, so that the inline functions mentioned
13874 above can use them.
13875
4a6bea26
PE
13876 * dired.c (directory_files_internal_unwind): Now static.
13877
f14b7e14
PE
13878 * fileio.c (file_name_as_directory, directory_file_name):
13879 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13880 Now static.
2893f146
PE
13881 (file_name_as_directory): Use const pointers when appropriate.
13882 (Fexpand_file_name): Likewise. In particular, newdir might
13883 point at constant storage, so make it a const pointer.
fd4ead52 13884 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13885 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13886 signedness issues.
f839df0c
PE
13887 (Fset_file_times, Finsert_file_contents, auto_save_error):
13888 Rename locals to avoid shadowing.
f14b7e14 13889
5716756e 13890 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13891 (Ftry_completion, Fall_completions): Rename or remove locals
13892 to avoid shadowing.
5716756e 13893
b4c3046a
PE
13894 * marker.c (bytepos_to_charpos): Remove; unused.
13895
b45db522
PE
13896 * lisp.h (verify_bytepos, count_markers): New decls,
13897 so that gcc does not warn that these functions aren't declared.
13898
85876d07
PE
13899 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13900 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13901 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13902 (copy_text): Remove unused local var.
85876d07 13903
03d78a21 13904 * filelock.c (within_one_second): Now static.
b3dd38ab 13905 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13906
5df8f01b
PE
13907 * buffer.c (fix_overlays_before): Mark locals as initialized.
13908 (fix_start_end_in_overlays): Likewise. This function should be
13909 simplified by using pointers-to-pointers, but that's a different
13910 matter.
b1d876f1 13911 (switch_to_buffer_1): Now static.
8f54f30a
PE
13912 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13913 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13914
a70072c9 13915 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13916 Fix pointer signedness issue.
edced198
PE
13917 (sys_subshell): Mark local as volatile if checking for lint,
13918 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13919 (MAXPATHLEN): Define only if needed.
a70072c9 13920
a0977c44
PE
13921 * process.c (serial_open, serial_configure): Move decls from here ...
13922 * systty.h: ... to here, so that they can be checked.
13923
a884fdcc
PE
13924 * fns.c (get_random, seed_random): Move extern decls from here ...
13925 * lisp.h: ... to here, so that they can be checked.
13926
604efe86 13927 * sysdep.c (reset_io): Now static.
b8950c94 13928 (wait_for_termination_signal): Remove; unused.
604efe86 13929
38fc62d9
PE
13930 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13931 (copy_keymap_item, append_key, push_text_char_description):
13932 Now static.
1004a21a 13933 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13934 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13935 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13936 (describe_map_tree):
13937 Rename locals to avoid shadowing.
38fc62d9 13938
2f2650da
PE
13939 * keyboard.c: Declare functions static if they are not used elsewhere.
13940 (echo_char, echo_dash, cmd_error, top_level_2):
13941 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13942 (read_char, kbd_buffer_get_event, make_lispy_position):
13943 (make_lispy_event, make_lispy_movement, apply_modifiers):
13944 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13945 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13946 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13947 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13948 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13949
a053e86c 13950 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13951 (mark_kboards): Move decl here ...
13952 * alloc.c (mark_kboards): ... from here.
a053e86c 13953
4752793e
PE
13954 * lisp.h (force_auto_save_soon): New decl.
13955
74f10ca7 13956 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13957 (DEFINE_DUMMY_FUNCTION): New macro.
13958 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13959 Use it.
c03cd23f
PE
13960 (main): Add casts to avoid warnings
13961 if GCC considers string literals to be constants.
74f10ca7 13962
022e70d4
PE
13963 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13964
59d6fe83
PE
13965 * dbusbind.c: Pointer signedness fixes.
13966 (xd_signature, xd_append_arg, xd_initialize):
13967 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13968 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13969 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13970 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13971
78320123
PE
13972 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13973 if GCC considers string literals to be constants.
49cebcca 13974 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13975
35ac2a97
SM
139762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13977
fb103ca9
SM
13978 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13979 (print_preprocess, print_object): New macro to fix last change.
13980
35ac2a97
SM
13981 * print.c (print_preprocess): Don't forget font objects.
13982
62973b41
JB
139832011-03-16 Juanma Barranquero <lekktu@gmail.com>
13984
13985 * emacs.c (USAGE3): Doc fixes.
13986
0e48bb22
AS
139872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13988
13989 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13990 structure.
13991
7684e57b
JB
139922011-03-14 Juanma Barranquero <lekktu@gmail.com>
13993
13994 * lisp.h (VWindow_system, Qfile_name_history):
13995 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13996 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13997 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13998
13999 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14000 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14001
14002 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14003 * w32console.c (detect_input_pending, read_input_pending)
14004 (encode_terminal_code):
14005 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14006 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14007 (w32_system_caret_y, Qfile_name_history):
14008 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14009 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14010 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14011 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14012 * w32proc.c (Qlocal, report_file_error):
14013 * w32term.c (Vwindow_system, updating_frame):
14014 * w32uniscribe.c (initialized, uniscribe_font_driver):
14015 Remove unneeded extern declarations.
14016
2aa46d6c
CY
140172011-03-14 Chong Yidong <cyd@stupidchicken.com>
14018
c96bbc66 14019 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14020
cffc6f3b
CY
140212011-03-13 Chong Yidong <cyd@stupidchicken.com>
14022
14023 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14024 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14025 These macros can no longer be used for assignment.
14026
44f230aa
SM
14027 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14028 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14029 (record_buffer_markers, fetch_buffer_markers): New functions for
14030 recording and fetching special buffer markers.
14031 (set_buffer_internal_1, set_buffer_temp): Use them.
14032
14033 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14034
14035 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14036
14037 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14038 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14039
14040 * xdisp.c (hscroll_window_tree):
14041 (reconsider_clip_changes): Use PT instead of BUF_PT.
14042
d251f04b
EZ
140432011-03-13 Eli Zaretskii <eliz@gnu.org>
14044
14045 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14046 $(EMACS_ROOT)/lib/intprops.h.
14047
f0c77cd1
PE
140482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14049
3eca4629
PE
14050 Fix more problems found by GCC 4.5.2's static checks.
14051
7c86ee98
PE
14052 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14053 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14054 (xg_free_frame_widgets): Make it clear that a local variable is
14055 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14056 (gdk_window_get_screen): Make it clear that this macro is needed
14057 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14058 (int_gtk_range_get_value): New function, which avoids a diagnostic
14059 from gcc -Wbad-function-cast.
14060 (xg_set_toolkit_scroll_bar_thumb): Use it.
14061 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14062 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14063 (get_utf8_string, xg_get_file_with_chooser):
14064 Rename locals to avoid shadowing.
14065 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14066
41729b81
PE
14067 * xgselect.c (xg_select): Remove unused var.
14068
f0c77cd1
PE
14069 * image.c (four_corners_best): Mark locals as initialized.
14070 (gif_load): Initialize transparent_p to zero (Bug#8238).
14071 Mark another local as initialized.
ec6cf4c6 14072 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14073
ce0ad53d 14074 * image.c (clear_image_cache): Now static.
d5d5a617 14075 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14076 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14077 (x_edge_detection): Remove unnecessary cast that
14078 gcc -Wbad-function-cast diagnoses.
2037898d 14079 (gif_load): Fix pointer signedness.
6ae141d6
PE
14080 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14081 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14082
33383987 140832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14084
d32df629
PE
14085 Improve quality of tests for time stamp overflow.
14086 For example, without this patch (encode-time 0 0 0 1 1
14087 1152921504606846976) returns the obviously-bogus value (-948597
14088 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14089 reports time overflow. See
14090 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14091 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14092 * editfns.c: Include limits.h and intprops.h.
14093 (TIME_T_MIN, TIME_T_MAX): New macros.
14094 (time_overflow): Move earlier, to before first use.
14095 (hi_time, lo_time): New functions, for an accurate test for
14096 out-of-range times.
14097 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14098 (Fget_internal_run_time): Don't assume time_t fits in int.
14099 (make_time): Use list2 instead of Fcons twice.
14100 (Fdecode_time): More accurate test for out-of-range times.
14101 (check_tm_member): New function.
14102 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14103 (lisp_time_argument): Don't rely on undefined left-shift and
14104 right-shift behavior when checking for time stamp overflow.
8be6f318 14105
fe31d94c
PE
14106 * editfns.c (time_overflow): New function, refactoring common code.
14107 (Fformat_time_string, Fdecode_time, Fencode_time):
14108 (Fcurrent_time_string): Use it.
14109
8be6f318
PE
14110 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14111 * dired.c (make_time): Move to ...
14112 * editfns.c (make_time): ... here.
14113 * systime.h: Note the move.
14114
09d9db2c 141152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14116
126bc0dc
YM
14117 * fringe.c (update_window_fringes): Remove unused variables.
14118
c47cbdfd
YM
14119 * unexmacosx.c (copy_data_segment): Also copy __got section.
14120 (Bug#8223)
14121
7ac80be9
EZ
141222011-03-12 Eli Zaretskii <eliz@gnu.org>
14123
c96bbc66 14124 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14125 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14126 Constify `char *' arguments and their references according to
14127 prototypes in tparam.h.
14128
ecb0f94d 14129 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14130
7ac80be9
EZ
14131 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14132 Adapt all references accordingly.
14133
14134 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14135
ef1fd07e
TT
141362011-03-11 Tom Tromey <tromey@redhat.com>
14137
14138 * buffer.c (syms_of_buffer): Remove obsolete comment.
14139
7ef4b50c
EZ
141402011-03-11 Eli Zaretskii <eliz@gnu.org>
14141
14142 * termhooks.h (encode_terminal_code): Declare prototype.
14143
14144 * msdos.c (encode_terminal_code): Don't declare prototype.
14145
14146 * term.c (encode_terminal_code): Now external again, used by
14147 w32console.c and msdos.c.
14148
44f230aa
SM
14149 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14150 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14151
4b1ec863 141522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14153
1714f52b 14154 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14155
4b1ec863
PE
14156 * fringe.c (update_window_fringes): Mark locals as initialized
14157 (Bug#8227).
14158 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14159
524c7aa6
PE
14160 * alloc.c (mark_fringe_data): Move decl from here ...
14161 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14162 to check its interface.
14163 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14164
a5c0af81 14165 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14166 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14167 (fontset_font): Mark local as initialized.
a9a06e0b 14168 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14169
b4716021
PE
14170 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14171
811e9bac 14172 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14173 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14174 (x_own_selection, Fx_disown_selection_internal): Rename locals
14175 to avoid shadowing.
14176 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14177
7e3ab302
PE
14178 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14179 so that the caller can use some name other than gcpro1.
14180 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14181 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14182 (Fx_backspace_delete_keys_p):
14183 Use them to avoid shadowing, and rename vars to avoid shadowing.
14184 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14185 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14186 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14187 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14188 Remove unused locals.
7e3ab302
PE
14189 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14190 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14191 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14192 macros.
f78faa98 14193
e2b13473
PE
14194 * xterm.h (x_mouse_leave): New decl.
14195
77f23912
PE
14196 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14197 Remove unused functions.
cdf4ba58
PE
14198 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14199 (x_calc_absolute_position): Now static.
7411c686 14200 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14201 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14202 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14203 unless they are used.
38d0b34a
PE
14204 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14205 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14206 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14207 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14208 (x_error_catcher, x_connection_closed, x_error_handler):
14209 (x_error_quitter, xembed_send_message, x_iconify_frame):
14210 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14211 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14212 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14213
44f230aa
SM
14214 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14215 Rename or move locals to avoid shadowing.
6b463e58 14216 (tty_defined_color, merge_face_heights): Now static.
5967d051 14217 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14218 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14219 does not deduce is never used uninitialized.
73719eba
PE
14220 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14221 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14222
426994c3 14223 * terminal.c (store_terminal_param): Now static.
5489860b 14224
032f1620 14225 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14226 (set_frame_menubar): Remove unused local.
d4323972 14227 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14228 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14229 since they might point to immutable storage.
281585b0
PE
14230 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14231 since it's unused otherwise.
032f1620 14232
367c19e5 14233 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14234 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14235 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14236 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14237 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14238 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14239 does not deduce are never used uninitialized.
70739cbe 14240
07b48fa9
PE
14241 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14242
8868a238 14243 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14244 * window.c (window_loop, size_window):
14245 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14246
7e5cf297 14247 * window.c (display_buffer): Now static.
d6550a9f
PE
14248 (size_window): Mark variables that gcc -Wuninitialized
14249 does not deduce are never used uninitialized.
a586633d
PE
14250 * window.h (check_all_windows): New decl, to forestall
14251 gcc -Wmissing-prototypes diagnostic.
5b555da1 14252 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14253
f6095868
PE
14254 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14255 shadowing.
14256 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14257 Include <limits.h>.
14258 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14259 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14260 (load_charset_map): Mark variables that gcc -Wuninitialized
14261 does not deduce are never used uninitialized.
53df7c11 14262 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14263
f38b440c
PE
14264 * coding.c (coding_set_source, coding_set_destination):
14265 Use "else { /* comment */ }" rather than "else /* comment */;"
14266 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14267 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14268 a block, when the outer 'i' will do.
14269 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14270 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14271 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14272 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14273 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14274 Rename locals to avoid shadowing.
14275 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14276 * coding.c (emacs_mule_char, encode_invocation_designation):
14277 Now static, since they're not used elsewhere.
413bb2db 14278 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14279 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14280 (decode_coding_emacs_mule): Mark variables that gcc
14281 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14282 (detect_coding_iso_2022): Initialize a local variable that might
14283 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14284 this initialization is needed. (Bug#8211)
5f58e762
PE
14285 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14286 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14287 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14288 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14289 Remove unused macros.
f38b440c 14290
232b38b9 14291 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14292 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14293 * character.c (string_count_byte8): Likewise.
232b38b9 14294
fb90da1b
PE
14295 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14296 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14297
fb93dbc2
PE
14298 * chartab.c (copy_sub_char_table): Now static, since it's not used
14299 elsewhere.
5c156ace
PE
14300 (sub_char_table_ref_and_range, char_table_ref_and_range):
14301 Rename locals to avoid shadowing.
bbcd0949 14302 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14303
7d3b3862 14304 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14305 (BIDI_BOB): Remove unused macro.
7d3b3862 14306
6be7d3da
PE
14307 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14308 deduce are never used uninitialized.
c2ed9c8b 14309 * term.c (encode_terminal_code): Likewise.
6be7d3da 14310
75f8807f 14311 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14312
50938595
PE
14313 * tparam.h: New file.
14314 * term.c, tparam.h: Include it.
14315 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14316 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14317 Move these decls to tparam.h, and make them agree with what
14318 is actually in tparam.c. The previous trick of using incompatible
14319 decls in different modules does not conform to the C standard.
14320 All callers of tparam changed to use tparam's actual API.
14321 * tparam.c (tparam1, tparam, tgoto):
14322 Use const pointers where appropriate.
14323
fbceeba2
PE
14324 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14325 * cm.h (struct cm): Likewise.
14326 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14327 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14328 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14329 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14330 (turn_on_face, init_tty): Likewise.
14331 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14332
7f3f1250
PE
14333 * term.c (term_mouse_position): Rename local to avoid shadowing.
14334
e6ca6543
PE
14335 * alloc.c (mark_ttys): Move decl from here ...
14336 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14337
c40f8d15
AS
143382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14339
14340 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14341
cfe0661d
JB
143422011-03-09 Juanma Barranquero <lekktu@gmail.com>
14343
14344 * search.c (compile_pattern_1): Remove argument regp, unused since
14345 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14346 (compile_pattern): Don't pass it.
14347
0afb4571
J
143482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14349
14350 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14351 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14352 for ! HAVE_GTK3.
14353 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14354
14355 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14356
14357 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14358 gdk_window_get_screen, gdk_window_get_geometry,
14359 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14360 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14361 (xg_get_pixbuf_from_pixmap): New function.
14362 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14363 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14364 Call xg_get_pixbuf_from_pixmap instead of
14365 gdk_pixbuf_get_from_drawable.
14366 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14367 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14368 (xg_check_special_colors): Use GtkStyleContext and its functions
14369 for HAVE_GTK3.
14370 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14371 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14372 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14373 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14374 Call gtk_widget_get_preferred_size.
0afb4571
J
14375 (xg_frame_resized): gdk_window_get_geometry only takes 5
14376 parameters.
44f230aa
SM
14377 (xg_win_to_widget, xg_event_is_for_menubar):
14378 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14379 (xg_set_widget_bg): New function.
14380 (delete_cb): New function.
895009e1 14381 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14382 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14383 (xg_set_background_color): Call xg_set_widget_bg.
14384 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14385 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14386 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14387 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14388 if ! HAVE_GTK3.
14389 (update_frame_tool_bar): Call gtk_widget_hide.
14390 (xg_initialize): Use GDK_KEY_g.
14391
14392 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14393 if ! HAVE_GTK3
14394 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14395
14396 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14397 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14398 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14399
1c2cc4ef
JB
144002011-03-08 Juanma Barranquero <lekktu@gmail.com>
14401
14402 * w32xfns.c (select_palette): Check success of RealizePalette against
14403 GDI_ERROR, not zero.
14404
33383987 14405See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14406
14407;; Local Variables:
14408;; coding: utf-8
aac0c6e3
MR
14409;; End:
14410
2f097256 14411 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14412
14413 This file is part of GNU Emacs.
14414
14415 GNU Emacs is free software: you can redistribute it and/or modify
14416 it under the terms of the GNU General Public License as published by
14417 the Free Software Foundation, either version 3 of the License, or
14418 (at your option) any later version.
14419
14420 GNU Emacs is distributed in the hope that it will be useful,
14421 but WITHOUT ANY WARRANTY; without even the implied warranty of
14422 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14423 GNU General Public License for more details.
14424
14425 You should have received a copy of the GNU General Public License
14426 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.