Remove compiler warnings in objective-C files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b55b9f85
JD
12012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2
0dc8cf50
JD
3 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
5 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
6 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
7 where appropriate.
8 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
9 as boolean expression.
10 (x_set_window_size): Remove unused variable toolbar.
11 (ns_get_color_default, ns_mod_to_lisp): Remove.
12 (ns_mouse_position): Remove unused variables xchar and ychar.
13 (ns_compute_glyph_string_overhangs): Remove unused variable face.
14 (ns_set_vertical_scroll_bar): Remove unused variable count.
15 (ns_delete_terminal): Remove unused variable i.
16 (ns_term_init): Remove unused variables r, g and b.
17 (mouseDown): Remove unused variable window.
18 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
19 (initFrameFromEmacs): Remove unused variable vbextra.
20 (mouseEntered): Remove unused variables p and dpyinfo.
21 (mouseExited): Remove unused variables p and r.
22 (ns_define_frame_cursor, ns_clear_frame_area)
23 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
24 (menuDown): Assign [sender tag] to variable and cast the variable.
25
26 * nsterm.h (menuDown): Add id as type to argument sender.
27 (ns_display_info_for_name): Add Lisp_Object argument.
28 (ns_term_init): Add Lisp_Object argument.
29 (ns_map_event_to_object): Add void argument.
30 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
31 prototype with arguments and only declare if __OBJC__.
32 (nxatoms_of_nsselect): Add void argument.
33 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
34 (ns_alloc_autorelease_pool): Add void argument.
35 (ns_release_autorelease_pool): Add void* argument.
36 (ns_get_defaults_value): Add const char* argument.
37
38 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
39 (initFromContents): Use SSDATA where appropriate.
40 (ns_update_menubar): Add braces to ambigous if-else.
41 (initWithTitle): Put () around assignment in if statement.
42 (ns_menu_show): Remove unused variables window and keymap.
43 (update_frame_tool_bar): Remove unused variable selected_p.
44 (initWithContentRect): Remove unused variable this_cmd_name.
45
46 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
47 appropriate.
48 (setXBMColor): Remove unused variable len.
49 (setPixmapData): Put () around assignment in loop statement.
50
51 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
52 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
53 where appropriate.
54 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
55 around assignment in loop statement.
56 (nsfont_open): Remove unused variable i.
57 (nsfont_open): Remove unused variable len.
58 (nsfont_draw): Remove unused variable cs.
59
60 * nsfns.m (x_set_icon_name, ns_set_name_internal)
61 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
62 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
63 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
64 (Fns_font_name, Fns_perform_service)
65 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
66 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
67 (ns_set_name): Remove unused variable view.
68 (x_set_menu_bar_lines): Remove unused variable olines.
69 (x_set_tool_bar_lines): Remove unused variable root_window.
70 (Fns_list_colors): Put () around assignment in while statement.
71 (Fns_perform_service): Remove unused variable len.
72 (Fns_display_usable_bounds): Remove unused variable top.
73 (syms_of_nsfns): Remove unused variable i.
74
b55b9f85
JD
75 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
76 memcpy (Bug#11907).
77
2277de02
JD
782012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
79
80 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
81 and free it with DestroyExceptionInfo (Bug#11558).
82
ef099b57
JB
832012-07-13 Juanma Barranquero <lekktu@gmail.com>
84
85 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
86 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
87 Set here, not in nt/config.nt.
88
ea814a5d
EZ
892012-07-13 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
92 cursor overflow into the last glyph on display line when the right
93 fringe is off. (Bug#11832)
94
1a952767
PE
952012-07-13 Paul Eggert <eggert@cs.ucla.edu>
96
97 * xdisp.c (produce_special_glyphs): Now static.
98 * dispextern.h (produce_special_glyphs): Remove decl.
99
983188fd
GM
1002012-07-13 Glenn Morris <rgm@gnu.org>
101
32fb4bb6
GM
102 * s/bsd-common, s/cygwin.h: Remove empty files.
103 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
104
983188fd
GM
105 * s/usg5-4-common.h (USG, USG5):
106 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
107 * s/sol2-6.h (SOLARIS2):
108 * s/irix6-5.h (IRIX6_5):
109 * s/hpux10-20.h (USG, USG5, HPUX):
110 * s/gnu-linux.h (USG, GNU_LINUX):
111 * s/freebsd.h (BSD_SYSTEM):
112 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
113 * s/cygwin.h (CYGWIN):
114 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
115 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
116
d1e68667 1172012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
118
119 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 120
6de0e799
GM
1212012-07-13 Glenn Morris <rgm@gnu.org>
122
739ae010
GM
123 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
124
dbee5793
GM
125 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
126
6de0e799
GM
127 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
128 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
129
b82da769
GM
1302012-07-12 Glenn Morris <rgm@gnu.org>
131
4fae5a7a 132 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
133
134 * process.c (init_process_emacs): Rename from init_process.
135 The old name is also the name of a Mach system call.
136 * lisp.h, emacs.c: Update for this name change.
137 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
138 longer needed.
139
5a979817
EZ
1402012-07-12 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
143 memmove call that removes glyphs covered by the left truncation
144 glyph. Improve commentary.
145 (display_line): Fix display of continuation glyphs on GUI frames
146 when the right fringe is turned off and variable-size fonts are
147 used in the window. Move the code that appends a stretch glyph to
148 produce_special_glyphs, so that it could be used for truncation
149 and continuation glyphs alike.
150 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
151 glyph of a suitably computed width, to align the special glyphs at
152 the window margin. Code moved from display_line. (Bug#11832)
153
3e91a053
GM
1542012-07-12 Glenn Morris <rgm@gnu.org>
155
ba9e4b84
GM
156 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
157
158 * s/gnu-linux.h, s/hpux10-20.h:
159 Do not unconditionally define HAVE_XRMSETDATABASE.
160
3e91a053
GM
161 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
162
b300b1f4
PE
1632012-07-12 Paul Eggert <eggert@cs.ucla.edu>
164
165 Fix typos that broke OS X build.
166 Reported by Randal L. Schwartz in
167 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
168 * nsterm.m (ns_timeout): Add missing local decl.
169 (ns_get_color): snprintf -> sprintf, to fix typo.
170
6e777848
GM
1712012-07-12 Glenn Morris <rgm@gnu.org>
172
3f922c37
GM
173 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
174 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
175 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
176 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
177
0ab7b23a
GM
178 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
179 Move PTY_OPEN to configure.
180
6e777848
GM
181 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
182 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
183 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
184
4a7edc24
DA
1852012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Use empty_unibyte_string where applicable.
188 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
189 * lread.c (read1): Likewise.
190 * xsettings.c (syms_of_xsettings): Likewise.
191
308aab79
GM
1922012-07-12 Glenn Morris <rgm@gnu.org>
193
42bd1719
GM
194 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
195 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
196 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
197 * s/hpux10-20.h (RUN_TIME_REMAP):
198 * s/bsd-common.h (TABDLY): Move to configure.
199
200 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
201
202 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
203
ea0bbd17 204 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 205 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
206
207 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 208
308aab79
GM
209 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
210 * s/template.h: Move NARROWPROTO to configure.
211
ee1cf5cf
GM
2122012-07-11 Glenn Morris <rgm@gnu.org>
213
30fe9bf4
GM
214 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
215 unused since 2011-01-17 change to systty.h.
216
ee1cf5cf
GM
217 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
218 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
219 Move HAVE_PTYS and HAVE_SOCKETS to configure.
220
63e47e07
PE
2212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
222
223 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
224
c43fb4c3
GM
2252012-07-11 Glenn Morris <rgm@gnu.org>
226
227 * s/darwin.h, s/gnu-linux.h, s/template.h:
228 Move INTERRUPT_INPUT to configure.
229
e8df9267
DA
2302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
231
232 Minor adjustments to interning code.
233 * lisp.h (intern, intern_c_string): Redefine as static inline
234 wrappers for intern_1 and intern_c_string_1, respectively.
235 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
236 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
237 Vobarray checking.
e8df9267
DA
238 * font.c (font_intern_prop): Likewise. Adjust comment.
239 * w32font.c (intern_font_name): Likewise.
240
34348bd4
AS
2412012-07-11 Andreas Schwab <schwab@linux-m68k.org>
242
d96a1e0c
AS
243 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
244
34348bd4
AS
245 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
246 of Fcar/Fcdr if possible.
247 * font.c (check_otf_features): Likewise.
248 * fontset.c (Fnew_fontset): Likewise.
249 * gnutls.c (Fgnutls_boot): Likewise.
250 * minibuf.c (read_minibuf): Likewise.
251 * msdos.c (IT_set_frame_parameters): Likewise.
252 * xmenu.c (Fx_popup_dialog): Likewise.
253 * w32menu.c (Fx_popup_dialog): Likewise.
254
c8add24e
GM
2552012-07-11 Glenn Morris <rgm@gnu.org>
256
4b575b3c
GM
257 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
258 since nothing has defined it on these platforms.
259
09f4e3b0
GM
260 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
261 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
262
172bedef
GM
263 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
264 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
265 Move CLASH_DETECTION to configure.
266
249685df
GM
267 * s/gnu.h: Remove file, which is now empty.
268
c8add24e
GM
269 * s/gnu.h, s/gnu-linux.h:
270 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
271
b41253a3
JW
2722012-07-11 John Wiegley <johnw@newartisans.com>
273
274 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
275 function attribute, so we only use it if it exists in the
276 compiler.
277
d923b542
DA
2782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Avoid call to strlen in fast_c_string_match_ignore_case.
281 * search.c (fast_c_string_match_ignore_case): Change to use
282 length argument. Adjust users accordingly.
283 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
284
5ebbef1d
PE
2852012-07-11 Paul Eggert <eggert@cs.ucla.edu>
286
bb352260
PE
287 Assume mkdir, rmdir.
288 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
289 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
290
57054ddd
PE
291 Assume rename.
292 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
293
b747d3f7
PE
294 Assume perror.
295 * s/hpux10-20.h (HAVE_PERROR): Remove.
296 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
297 Remove dummy definition, as this problem was obsolete long ago.
298
5ebbef1d
PE
299 Assume strerror.
300 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
301
984e7f30
DA
3022012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
303
304 Avoid calls to strlen in font processing functions.
305 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 306 (font_open_by_name): Change to use length argument. Adjust
984e7f30 307 users accordingly.
d923b542
DA
308 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
309 Adjust prototypes.
310 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
311 Change to return ptrdiff_t.
984e7f30
DA
312 (xfont_list_pattern, xfont_match): Use length returned by
313 xfont_decode_coding_xlfd.
314 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
315
20e94fdd
GM
3162012-07-11 Glenn Morris <rgm@gnu.org>
317
9d596af3
GM
318 * s/darwin.h, s/freebsd.h, s/netbsd.h:
319 Move DONT_REOPEN_PTY to configure.
320
20e94fdd
GM
321 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
322 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
323
e99a530f
PE
3242012-07-10 Paul Eggert <eggert@cs.ucla.edu>
325
22ffb973
PE
326 Remove "#define unix" that is no longer needed (Bug#11905).
327 * s/aix4-2.h (unix): Remove; no longer needed.
328
e9a9ae03
PE
329 EMACS_TIME simplification (Bug#11875).
330 This replaces macros (which typically do not work in GDB)
331 with functions, typedefs and enums, making the code easier to debug.
332 The functional style also makes code easier to read and maintain.
333 * systime.h: Include <sys/time.h> on all hosts, not just if
334 WINDOWSNT, since 'struct timeval' is needed in general.
335 (EMACS_TIME): Now a typedef, not a macro.
336 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
337 not macros.
338 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
339 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
340 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
341 (EMACS_TIME_LE): Now functions, not macros.
342 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
343 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
344 which are not functions. All uses rewritten to use:
345 (make_emacs_time): New function.
346 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
347 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
348 not functions. All uses rewritten to use the following, respectively:
349 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
350 (add_emacs_time, sub_emacs_time): New functions.
351 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
352 * fileio.c (Fcopy_file):
353 * xterm.c (XTflash): Get the current time closer to when it's used.
354 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
355
ffacb126
PE
356 * bytecode.c (targets): Suppress -Woverride-init warnings.
357
e99a530f
PE
358 Simplify by avoiding confusing use of strncpy etc.
359 * doc.c (Fsnarf_documentation):
360 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
361 * frame.c (Fmake_terminal_frame):
362 * gtkutil.c (get_utf8_string):
363 * lread.c (openp):
364 * nsmenu.m (ns_update_menubar):
365 * regex.c (regerror):
366 Prefer memcpy to strncpy and strncat when either will do.
367 * fileio.c (Fsubstitute_in_file_name):
368 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
369 (menu_separator_name_p):
370 * nsmenu.m (ns_update_menubar):
371 Prefer memcmp to strncmp when either will do.
372 * nsterm.m: Include <ftoastr.h>.
373 (ns_get_color):
374 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
375 Prefer snprintf to strncpy.
376 * nsterm.m (ns_term_init):
377 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
378 * nsterm.m (ns_term_init):
379 Avoid the need for strncpy, by using build_string or
380 make_unibyte_string directly. Use dtoastr, not snprintf.
381 * process.c (Fmake_network_process): Diagnose service names that
382 are too long, rather than silently truncating them or creating
383 non-null-terminated names.
384 (Fnetwork_interface_info): Likewise, for interface names.
385 * sysdep.c (system_process_attributes) [GNU_LINUX]:
386 Prefer sprintf to strncat.
387 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
388 Prefer vsnprintf to vsprintf + strncpy.
389
c59592b3
GM
3902012-07-10 Glenn Morris <rgm@gnu.org>
391
392 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
393 Clarify fallback case.
394
7d7bbefd
DA
3952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
396
397 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
398 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
399 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 400 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
401 where argument type is known to be a Lisp_Cons.
402
3a4c8000
TT
4032012-07-10 Tom Tromey <tromey@redhat.com>
404
405 * bytecode.c (BYTE_CODE_THREADED): New macro.
406 (BYTE_CODES): New macro. Replaces all old byte-code defines.
407 (enum byte_code_op): New type.
408 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
409 (exec_byte_code): Use them. Use token threading when applicable.
410
2a0213a6
DA
4112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Optimize pure C strings initialization.
414 * lisp.h (make_pure_string): Fix prototype.
415 (build_pure_c_string): New function, defined as static inline. This
416 provides a better opportunity to optimize away calls to strlen when
417 the function is called with compile-time constant argument.
418 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
419 argument, adjust users accordingly. Use build_pure_c_string where
420 appropriate.
421 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
422 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
423 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
424
cb1caeaf
DA
4252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
426
427 Avoid calls to strlen in miscellaneous functions.
428 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
429 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
430 * lread.c (openp): Likewise.
431
c293e30c
DA
4322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Avoid calls to strlen in path processing functions.
435 * fileio.c (file_name_as_directory): Add comment. Change to add
436 srclen argument and return the length of result. Adjust users
437 accordingly.
438 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 439 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
440 users accordingly.
441 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
442
9e059e3f
GM
4432012-07-10 Glenn Morris <rgm@gnu.org>
444
d02eb359
GM
445 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
446 Move PENDING_OUTPUT_COUNT definition to configure.
447
882cf227
GM
448 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
449 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
450 * s/gnu.h (DATA_START): Move definitions to configure.
451
af6e839f
GM
452 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
453 We include usg5-4-common.h, which defines them both.
454
40289a12
GM
455 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
456 O_RDONLY already includes it).
457
9e059e3f
GM
458 Stop ns builds setting the EMACSLOADPATH environment variable.
459 * nsterm.m (ns_load_path): Rename from ns_init_paths.
460 Now it does not set EMACSLOADPATH, just returns the load-path string.
461 * nsterm.h: Update accordingly.
462 * lread.c [HAVE_NS]: Include nsterm.h.
463 (init_lread) [HAVE_NS]: Use ns_load_path.
464 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
465
7c4e8ec0
GM
4662012-07-09 Glenn Morris <rgm@gnu.org>
467
d4f600ff
GM
468 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
469 since the included bsd-common.h does so.
470
cbb31951
GM
471 Stop ns builds setting the EMACSPATH environment variable.
472 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
473 (ns_init_paths): Do not set EMACSPATH.
474 * nsterm.h (ns_exec_path): Add it.
475 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
476 Use ns_exec_path.
477
7c4e8ec0
GM
478 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
479
26bccfae
PE
4802012-07-09 Paul Eggert <eggert@cs.ucla.edu>
481
a0bee46f
PE
482 * process.c (wait_reading_process_output): 'waitchannels' was unset
483 when read_kbd || !NILP (wait_for_cell); fix this.
484
5994c183
PE
485 Add GCC-style 'const' attribute to functions that can use it.
486 * character.h (char_resolve_modifier_mask):
487 * keyboard.h (make_ctrl_char):
488 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
489 (init_character_once, next_almost_prime, init_fns, init_image)
490 (flush_pending_output, init_sound):
491 * mem-limits.h (start_of_data):
492 * menu.h (finish_menu_items):
493 Add ATTRIBUTE_CONST.
494 * emacs.c (DEFINE_DUMMY_FUNCTION):
495 Declare the dummy function with ATTRIBUTE_CONST.
496 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
497 Add decls with ATTRIBUTE_CONST.
498
26bccfae
PE
499 Minor improvements to make_formatted_string.
500 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
501 where int is good enough, as vsprintf returns an int.
502 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
503
a8290ec3
DA
5042012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
505
506 Use make_formatted_string to avoid double length calculation.
507 * lisp.h (make_formatted_string): New prototype.
508 * alloc.c (make_formatted_string): New function.
509 * buffer.c (Fgenerate_new_buffer_name): Use it.
510 * dbus.c (syms_of_dbusbind): Likewise.
511 * editfns.c (Fcurrent_time_zone): Likewise.
512 * filelock.c (get_boot_time): Likewise.
513 * frame.c (make_terminal_frame, set_term_frame_name)
514 (x_report_frame_params): Likewise.
515 * image.c (gs_load): Likewise.
516 * minibuf.c (get_minibuffer): Likewise.
517 * msdos.c (dos_set_window_size): Likewise.
518 * process.c (make_process): Likewise.
519 * xdisp.c (ensure_echo_area_buffers): Likewise.
520 * xsettings.c (apply_xft_settings): Likewise.
521
d01ba2f1
GM
5222012-07-09 Glenn Morris <rgm@gnu.org>
523
524 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
525 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
526 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
527 * nsterm.h (ns_etc_directory): Add it.
528 * callproc.c [HAVE_NS]: Include nsterm.h.
529 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
530
f1f924b6
DA
5312012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Move marker debugging code under MARKER_DEBUG.
534 * marker.c (MARKER_DEBUG): Move marker debugging code under
535 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
536 for bootstrap with --enable-checking (~3x slowdown reported
537 by Juanma Barranquero <lekktu@gmail.com>).
538 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
539
ab531b66
PE
5402012-07-08 Paul Eggert <eggert@cs.ucla.edu>
541
542 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
543 See <http://bugs.gnu.org/11825#29>.
544
c4b3bc8a
EZ
5452012-07-08 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
548 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
549 (display_line): Add commentary about displaying truncation glyphs
550 on GUI frames.
551 (produce_special_glyphs): Move here from term.c.
552
553 * term.c (produce_special_glyphs): Move to xdisp.c.
554
555 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
556 section.
c4b3bc8a 557
b676b881
AS
5582012-07-07 Andreas Schwab <schwab@linux-m68k.org>
559
f17c5273
AS
560 * xdisp.c (display_line): Avoid warning about implicit declaration
561 of FRAME_FONT.
562
298819b9
AS
563 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
564
b676b881
AS
565 * lisp.h: Remove empty conditional.
566
6045c4fd
PE
5672012-07-07 Paul Eggert <eggert@cs.ucla.edu>
568
b3350bf9
PE
569 * lread.c (load_path_check): Now static.
570
6045c4fd
PE
571 Fix some minor --with-ns problems found by static checking.
572 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
573 (x_set_font) [!HAVE_X_WINDOWS]:
574 * image.c (xpm_load_image) [HAVE_NS]:
575 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
576 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
577 Remove unused local.
578 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
579 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
580 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
581 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
582 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
583 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
584 Fix pointer signedness problem.
585 * xfaces.c (FRAME_X_FONT_TABLE):
586 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
587
929e7845
GM
5882012-07-07 Glenn Morris <rgm@gnu.org>
589
590 * lread.c (load_path_check): New function, split from init_lread.
591 (init_lread): Reorganize. Motivation:
592 If EMACSLOADPATH is set, check/warn about that rather than the
593 defaults, which we are not going to use. Hence we can remove
594 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
595 Don't warn if site-lisp directories are missing.
596 If not installed, start from a blank load-path, since
597 PATH_LOADSEARCH refers to the eventual installation directories.
598
58dd0aa4
EZ
5992012-07-07 Eli Zaretskii <eliz@gnu.org>
600
601 Support truncation and continuation glyphs on GUI frames, when
602 fringes are disabled. (Bug#11832)
603 * xdisp.c (init_iterator): Get dimensions of truncation and
604 continuation glyphs even if on GUI frames. Adjust
605 it->last_visible_x on GUI frames when the left or right fringes,
606 or both, are absent.
607 (start_display, move_it_in_display_line_to): Handle the case of a
608 GUI frame without a fringe to display continuation or truncation
609 glyphs.
610 (insert_left_trunc_glyphs): Support GUI frames: make sure
611 truncation glyphs overwrite enough glyphs from the current line to
612 have sufficient space in pixels.
613 (display_line): Support truncation and continuation glyphs on GUI
614 frames. If some spare pixels are left on the line after inserting
615 the truncation glyphs, fill that space with a stretch glyph of a
616 suitably computed width.
617
618 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
619 produce_glyphs, to support GUI sessions.
620
31571fd7
PE
6212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
622
5a16b9bc
PE
623 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
624
f3047c75
PE
625 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
626
31571fd7
PE
627 Do not require float-time's arg to fit in time_t (Bug#11825).
628 This works better on hosts where time_t is unsigned, and where
629 float-time is applied to the (negative) difference between two times.
630 * editfns.c (decode_time_components): Last arg is now double *,
631 not int *, and means to store all the result as a double, without
632 worrying about whether the seconds part fits in time_t.
633 All callers changed.
634 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
635 All callers changed.
636 (Ffloat_time): Do not fail merely because the specified time falls
637 outside of time_t range.
638
4516fbef
GM
6392012-07-07 Glenn Morris <rgm@gnu.org>
640
641 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
642 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
643 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
644
07adc2c6
JB
6452012-07-07 Juanma Barranquero <lekktu@gmail.com>
646
647 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
648 Update dependencies.
649
650 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
651
fd573f31
PE
6522012-07-06 Paul Eggert <eggert@cs.ucla.edu>
653
fee5959d
PE
654 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
655 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
656 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
657 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
658 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
659 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
660
fd573f31
PE
661 * xfont.c (compare_font_names): Redo to omit the need for casts.
662
ddadbc0e
AS
6632012-07-06 Andreas Schwab <schwab@linux-m68k.org>
664
fca8d6b6
AS
665 * xfns.c (Fx_change_window_property): Doc fix.
666 * w32fns.c (Fx_change_window_property): Doc fix.
667
ddadbc0e
AS
668 * w32fns.c (Fx_window_property): Accept the same arguments as the
669 X Windows version. Doc fix.
670 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
671
f247498e
JB
6722012-07-06 Juanma Barranquero <lekktu@gmail.com>
673 Eli Zaretskii <eliz@gnu.org>
674
675 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
676 Windows-specific code from nt/config.nt moved here.
677 Obsolete settings removed.
678
216ee680
PE
6792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
680
681 * process.c: Avoid unnecessary calls to gettime.
682 (wait_reading_process_output): Don't get the time of day
683 when gobbling data immediately and not waiting, as there's no need
684 for it in that case. This removes a FIXME.
685
bdd091e4
JD
6862012-07-06 Jan Djärv <jan.h.d@swipnet.se>
687
688 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
689 is defined (Bug#11768).
690
9d44f8ce
DA
6912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Fix marker debugging code.
694 * marker.c (byte_char_debug_check): Do not perform the check
695 if buffer is not multibyte.
090bd7cb
JB
696 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
697 Call byte_char_debug_check with correct arguments.
9d44f8ce 698
90fc4786
DA
6992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
700
701 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
702 * marker.c (byte_char_debug_check, count_markers):
703 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
704 (byte_debug_flag): Remove.
705 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
706 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
707
7b7ae965
DA
7082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
709
4e57b342
DA
710 Avoid code repetition in marker-related functions.
711 * marker.c (attach_marker): New function.
712 (Fset_marker, set_marker_restricted, set_marker_both)
713 (set_marker_restricted_both): Use it.
714 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
715 Consistently rename charno to charpos.
716 (marker_position): Add eassert.
717 (marker_byte_position): Convert to eassert.
718
7192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
720
721 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 722 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 723 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 724
657924ff
DA
7252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
726
727 Introduce fast path for the widely used marker operation.
728 * alloc.c (build_marker): New function.
729 * lisp.h (build_marker): New prototype.
730 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
731 * composite.c (autocmp_chars): Likewise.
732 * editfns.c (buildmark): Remove.
733 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
734 (save_restriction_save): Use build_marker.
735 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
736 * window.c (save_window_save): Likewise.
737
041a49a6
DA
7382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
739
740 Do not use Fdelete_overlay in delete_all_overlays
741 to avoid redundant calls to unchain_overlay.
742 * buffer.c (drop_overlay): New function.
743 (delete_all_overlays, Fdelete_overlay): Use it.
744 * minibuf.c (get_minibuffer): Fix comment.
745
7dca65a4
PE
7462012-07-06 Paul Eggert <eggert@cs.ucla.edu>
747
748 Port to OpenBSD 5.1 amd64.
749 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
750 This is needed for OpenBSD, and should be harmless on all BSD systems.
751 Also, include <sys/sysctl.h>, as it should be available on all
752 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
753 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
754 use p_pid member, not kp_proc.pid.
755
8eb876e2
GM
7562012-07-06 Glenn Morris <rgm@gnu.org>
757
758 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
759
38182d90
PE
7602012-07-05 Paul Eggert <eggert@cs.ucla.edu>
761
762 More xmalloc and related cleanup.
763 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
764 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
766 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
767 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
768 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
769 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
770 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
771 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
772 * xterm.c:
773 Omit needless casts involving void * pointers and allocation.
774 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
775 as the former is more robust if P's type is changed.
776 Prefer xzalloc to xmalloc + memset 0.
777 Simplify malloc-or-realloc to realloc.
778 Don't worry about xmalloc returning a null pointer.
779 Prefer xstrdup to xmalloc + strcpy.
780 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
781 growing it.
782 * keyboard.c (apply_modifiers_uncached): Prefer local array to
783 alloca of a constant.
784
6dd5a677
EZ
7852012-07-05 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (display_line): Fix horizontal pixel coordinates when
788 hscroll is larger than the line width. Fixes long and futile
789 looping inside extend_face_to_end_of_line (on a TTY) producing
790 glyphs that are not needed and thrown away.
791
6b312f0f
DA
7922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
793
794 * marker.c (set_marker_restricted_both): Simplify by using
795 clip_to_bounds.
796
f520ef9b
PE
7972012-07-05 Paul Eggert <eggert@cs.ucla.edu>
798
799 * editfns.c (region_limit): Simplify by using clip_to_bounds.
800
383b7c95
JD
8012012-07-05 Jan Djärv <jan.h.d@swipnet.se>
802
803 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
804 not defined (Bug#11768).
805 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
806 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
807 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
808 followed by gtk_box_set_homogeneous (Bug#11768).
809 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
810 (update_theme_scrollbar_width, xg_create_scroll_bar):
811 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
812 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
813 (is_box_type): New function (Bug#11768).
814 (xg_tool_item_stale_p): Call is_box_type.
5293d758 815 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
816 with default display (Bug#11768).
817
d6e7bf45
EZ
8182012-07-05 Eli Zaretskii <eliz@gnu.org>
819
820 * xdisp.c (window_hscroll_limited): New function.
821 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
822 coordinates when window's hscroll is set to insanely large
823 values. (Bug#11857)
824
431391ec
JB
8252012-07-05 Juanma Barranquero <lekktu@gmail.com>
826
827 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
828 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
829
23f86fce
DA
8302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
831
832 Cleanup xmalloc.
833 * lisp.h (xzalloc): New prototype. Omit needless casts.
834 * alloc.c (xzalloc): New function. Omit needless casts.
835 * charset.c: Omit needless casts. Convert all calls to
836 xmalloc with following memset to xzalloc.
837 * dispnew.c: Likewise.
838 * fringe.c: Likewise.
839 * image.c: Likewise.
840 * sound.c: Likewise.
841 * term.c: Likewise.
842 * w32fns.c: Likewise.
843 * w32font.c: Likewise.
844 * w32term.c: Likewise.
845 * xfaces.c: Likewise.
846 * xfns.c: Likewise.
847 * xterm.c: Likewise.
848 * atimer.c: Omit needless casts.
849 * buffer.c: Likewise.
850 * callproc.c: Likewise.
851 * ccl.c: Likewise.
852 * coding.c: Likewise.
853 * composite.c: Likewise.
854 * doc.c: Likewise.
855 * doprnt.c: Likewise.
856 * editfns.c: Likewise.
857 * emacs.c: Likewise.
858 * eval.c: Likewise.
859 * filelock.c: Likewise.
860 * fns.c: Likewise.
861 * gtkutil.c: Likewise.
862 * keyboard.c: Likewise.
863 * lisp.h: Likewise.
864 * lread.c: Likewise.
865 * minibuf.c: Likewise.
866 * msdos.c: Likewise.
867 * print.c: Likewise.
868 * process.c: Likewise.
869 * region-cache.c: Likewise.
870 * search.c: Likewise.
871 * sysdep.c: Likewise.
872 * termcap.c: Likewise.
873 * terminal.c: Likewise.
874 * tparam.c: Likewise.
875 * w16select.c: Likewise.
876 * w32.c: Likewise.
877 * w32reg.c: Likewise.
878 * w32select.c: Likewise.
879 * w32uniscribe.c: Likewise.
880 * widget.c: Likewise.
881 * xdisp.c: Likewise.
882 * xmenu.c: Likewise.
883 * xrdb.c: Likewise.
884 * xselect.c: Likewise.
885
0497dc44
PE
8862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
887
888 * fileio.c (time_error_value): Check the right error number.
889 Problem reported by Troels Nielsen in
890 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
891
356e7178
PE
8922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
893
4e71fd89
PE
894 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
895 This should be fixed in a better way; see Eli Zaretskii in
896 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
897 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
898
f0941253
PE
899 * fileio.c (time_error_value): Rename from special_mtime.
900 The old name's problems were noted by Eli Zaretskii in
901 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
902
065c9eb4
PE
903 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
904 This variable's comment says Emacs needs at least one GDB-visible
905 symbol of type enum pvec_type, to work around GDB problems.
906 The symbol's value doesn't matter.
907
356e7178
PE
908 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
909 that causes compilation to fail on pre-C99 compilers.
910
95f61aa2
JB
9112012-07-04 Juanma Barranquero <lekktu@gmail.com>
912
913 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
914 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
915
3884d954
DA
9162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
917
d209e2fb 918 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
919 headers for buffer_defaults and buffer_local_symbols.
920 Reported by Juanma Barranquero <lekktu@gmail.com>.
921
ee28be33
SM
9222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
925 * lisp.h (enum pvec_type): Use fewer bits.
926 (PSEUDOVECTOR_SIZE_BITS): New constant.
927 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
928 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
929 change in pvec_type.
930 (PSEUDOVECTOR_TYPEP): New macro.
931 (TYPED_PSEUDOVECTORP): Use it.
932 * fns.c (internal_equal): Adapt code to extract pvectype.
933 * emacs.c (gdb_pvec_type): Update type.
934 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
935 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
936 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
937 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
938 (sweep_vectors): Use it. Use local var `total_bytes' instead of
939 abusing vector->header.next.nbytes.
940 (live_vector_p): Use PVEC_TYPE.
941 (mark_object): Adapt code to extract pvectype. Use switch.
942
c7f2cd7f
PE
9432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
944
945 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
946 Tighten new eassert a bit.
947
8ce70ed2
DA
9482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
949
950 Fix compilation with --enable-gcc-warnings and -O1
951 optimization level.
952 * doprnt.c (doprnt): Change type of tem to int, initialize
953 to avoid compiler warning. Add eassert.
954 * search.c (simple_search): Initialize match_byte to avoid
955 compiler warning. Add eassert.
956
dea7f1e5
PE
9572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
958
24a212eb
PE
959 Avoid weird behavior with large horizontal scrolls.
960 Without this change, for example, large hscroll values would
961 mess up Emacs's display on Fedora 15 x86, presumably due to
962 overflows in int calculations in the display code.
963 Also, if buffers had long lines, Emacs would freeze.
964 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
965 (set_window_hscroll): New function, containing the old guts of
966 Fset_window_hscroll. Return the clipped value.
967 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
968 This avoids the need to check against PTRDIFF_MAX.
969
dea7f1e5
PE
970 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
971
76046526
DA
9722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
973
974 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
975
39adff0d
PE
9762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
977
63807d47
PE
978 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
979 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
980 since GCC 4.4.6 issues a bogus warning for them.
981
39adff0d
PE
982 Fix bugs in file timestamp newness comparisons.
983 * fileio.c (Ffile_newer_than_file_p):
984 * lread.c (Fload): Use full timestamp resolution of files,
985 not just the 1-second resolution, so that files that are only
986 slightly newer still count as newer.
987 * fileio.c (Ffile_newer_than_file_p): Don't assume file
988 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
989
dbeed9a6
PE
9902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
991
992 * fileio.c: Improve handling of file time marker. (Bug#11852)
993 (special_mtime): New function.
994 (Finsert_file_contents, Fverify_visited_file_modtime):
995 Use it to set special mtime values consistently.
996
636334d6
AS
9972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
998
999 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1000 marker for non-existing file. (Bug#11852)
1001
e2017fe2
GM
10022012-07-03 Glenn Morris <rgm@gnu.org>
1003
1004 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1005 and did not make it into globals.h).
1006
404dbd37
TT
10072012-07-03 Tom Tromey <tromey@redhat.com>
1008
1009 * window.c (Fset_window_margins, Fset_window_fringes)
1010 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1011 * textprop.c (Fprevious_property_change): No longer static.
1012 * syntax.c (Fsyntax_table_p): No longer static.
1013 * process.c (Fget_process, Fprocess_datagram_address): No longer
1014 static.
1015 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1016 * keyboard.c (Fcommand_execute): No longer static.
1017 Remove EXFUN.
1018 * insdel.c (Fcombine_after_change_execute): No longer static.
1019 * image.c (Finit_image_library): No longer static.
1020 * fileio.c (Fmake_symbolic_link): No longer static.
1021 * eval.c (Ffetch_bytecode): No longer static.
1022 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1023 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1024 No longer static.
404dbd37
TT
1025 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1026 static.
1027 * dired.c (Ffile_attributes): No longer static.
1028 * composite.c (Fcomposition_get_gstring): No longer static.
1029 * callproc.c (Fgetenv_internal): No longer static.
1030
1031 * ccl.h: Remove EXFUNs.
1032 * buffer.h: Remove EXFUNs.
1033 * dispextern.h: Remove EXFUNs.
1034 * intervals.h: Remove EXFUNs.
1035 * fontset.h: Remove EXFUN.
1036 * font.h: Remove EXFUNs.
1037 * dosfns.c (system_process_attributes): Remove EXFUN.
1038 * keymap.h: Remove EXFUNs.
1039 * lisp.h: Remove EXFUNs.
1040 * w32term.h: Remove EXFUNs.
1041 * window.h: Remove EXFUNs.
1042 * xsettings.h: Remove EXFUN.
1043 * xterm.h: Remove EXFUN.
1044
8e4fd1e1
GM
10452012-07-03 Glenn Morris <rgm@gnu.org>
1046
1047 * lisp.h (Frandom): Make it visible to C.
1048 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1049 buffer for invisible buffers. (Bug#1229)
1050
ca95b3eb
DA
10512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1054 values which aren't power of 2.
1055 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1056 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1057 accordingly.
1058
7555c33f
SM
10592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1060
1061 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1062
1063 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1064
d12e8f5a
DA
10652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 * alloc.c (allocate_vector_block): Remove redundant
1068 calls to mallopt if DOUG_LEA_MALLOC is defined.
1069 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1070 avoid calls to mallopt if zero_vector is returned.
1071
296094c3
DA
10722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1075 is enabled, avoid dereferencing NULL current_sblock if
1076 running undumped.
1077
36429c89
DA
10782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1079
1080 Cleanup basic buffer management.
1081 * buffer.h (struct buffer): Change layout to use generic vector
1082 marking code. Fix some comments. Change type of 'clip_changed'
1083 to bitfield. Remove unused #ifndef old.
1084 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1085 (GET_OVERLAYS_AT): Fix indentation.
1086 (for_each_per_buffer_object_at): New macro.
1087 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1088 (Fbuffer_local_variables): Use it.
1089 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1090 * alloc.c (allocate_buffer): Adjust to match new layout of
1091 struct buffer. Fix comment.
1092 (mark_overlay): New function.
1093 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1094 Lisp area of struct buffer.
1095 (mark_object): Use it. Adjust marking of misc objects
1096 and related comments.
1097
3b3e4cac
PE
10982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1101 wrapper that is not needed because the wrapped code is a no-op (zero
1102 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1103 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1104
cf5c0175
DA
11052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1106
1107 * alloc.c (mark_buffer): Simplify. Remove prototype.
1108 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1109 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1110 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1111 redundant calls to mark_vectorlike for bool vectors.
1112
ca26824c
GM
11132012-06-30 Glenn Morris <rgm@gnu.org>
1114
2e4c5312
GM
1115 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1116
ca26824c
GM
1117 * epaths.in (PATH_SITELOADSEARCH): New.
1118 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1119 This is rather than relying on --enable-locallisppath elements
1120 having "site-lisp" in their names. (Bug#10208#25, 11658)
1121
0d23c240
EZ
11222012-06-30 Eli Zaretskii <eliz@gnu.org>
1123
c9240d7a
EZ
1124 * w32proc.c (sys_select): Accept and ignore one more argument.
1125
1126 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1127
0d23c240 1128 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1129 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1130
1131 * sysdep.c: Don't include dos.h and dosfns.h.
1132
1133 * process.c (sys_select):
1134 * msdos.c (sys_select): Accept one more argument and ignore it.
1135
1136 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1137 adapt data types and code to that.
1138
1139 * dosfns.c:
1140 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1141 which clashes with the gnulib function of the same name.
1142
af5a5a98
AS
11432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1144
c5e4379c
AS
1145 * font.c (font_style_to_value, font_style_symbolic)
1146 (font_prop_validate_style): Add type checks for values in
1147 font_style_table.
1148
af5a5a98
AS
1149 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1150 argument.
1151 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1152 uses.
1153
8d38f461
EZ
11542012-06-29 Eli Zaretskii <eliz@gnu.org>
1155
2e5a6631
EZ
1156 * xdisp.c (try_window_id): Undo last change.
1157
8d38f461
EZ
1158 * w32.c (getwd): Adjust commentary about startup_dir.
1159 (init_environment): Always call sys_access, even in non-MSVC
1160 builds. Don't chdir to the directory of the Emacs executable.
1161 This undoes code from 1997 which was justified by the need to
1162 "avoid conflicts when removing and renaming directories". But its
1163 downside was that every relative file name was being interpreted
1164 relative to the directory of the Emacs executable, which can never
1165 be TRT. In particular, it broke sys_access when called with
1166 relative file names.
1167 (sys_access): Map GetLastError to errno.
1168
2af3565e
DA
11692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 * window.h (struct window): Change type of 'fringes_outside_margins'
1172 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1173 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1174 Adjust comment.
1175 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1176 to ptrdiff_t.
1177
c8d3a25c 11782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1179
c8d3a25c
GM
1180 * gnutls.c (emacs_gnutls_handshake):
1181 Add QUIT to make the loop interruptible.
57570cd3 1182
c8d3a25c 11832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1184
c8d3a25c
GM
1185 * charset.c (init_charset): Make lack of etc/charsets fatal.
1186
3e984ee8
DA
11872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1188
1189 * editfns.c (region_limit): Fix type mismatch.
1190
ef884f23
DA
11912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1192
1193 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1194 undefined. Convert from xassert to eassert.
1195 * nsmenu.m: Convert from xassert to eassert.
1196 * nsterm.m: Likewise.
1197
7d7e0027
SM
11982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1199
1200 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1201
aa754e6a
PE
12022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Avoid integer overflow on scroll-left and scroll-right.
1205 * window.c (HSCROLL_MAX): New macro.
1206 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1207 overflow when requested scroll falls outside ptrdiff_t range.
1208
80b00b08
DA
12092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1210
1211 * window.h (struct window): Change type of 'hscroll',
1212 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1213 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1214 Adjust users accordingly.
1215 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1216 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1217 from EMACS_INT to ptrdiff_t.
1218 (make_window): Omit redundant initialization.
1219
62b2bcf6
JB
12202012-06-28 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1223
45942c7d
DA
12242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1225
1226 * window.h (struct window): Change type of 'use_time' and
1227 'sequence_number' from Lisp_Object to int.
1228 * frame.c (make_frame): Adjust users accordingly.
1229 * print.c (print_object): Likewise.
1230 * window.c (select_window, Fwindow_use_time, make_parent_window)
1231 (make_window): Likewise.
1232
e509cfa6
DA
12332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1236 enabled with --enable-checking=[all,glyphs] configure option.
1237 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1238 adjust comments accordingly.
1239 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1240 undefined, adjust comments accordingly.
1241 * image.c: Likewise.
1242 * scroll.c: Likewise.
1243 * w32fns.c: Likewise.
1244 * w32term.c: Likewise.
1245 * xdisp.c: Likewise.
1246 * xfaces.c: Likewise.
1247 * xfns.c: Likewise.
1248 * xterm.c: Likewise.
1249
a54e2c05
DA
12502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1251
1252 Generalize run-time debugging checks.
1253 * dispextern.h (XASSERTS): Remove.
1254 * fontset.c (xassert): Remove.
1255 Convert from xassert to eassert.
1256 * alloc.c: Convert from xassert to eassert.
1257 * bidi.c: Likewise.
1258 * dispnew.c: Likewise.
1259 * fns.c: Likewise.
1260 * fringe.c: Likewise.
1261 * ftfont.c: Likewise.
1262 * gtkutil.c: Likewise.
1263 * image.c: Likewise.
1264 * keyboard.c: Likewise.
1265 * menu.c: Likewise.
1266 * process.c: Likewise.
1267 * scroll.c: Likewise.
1268 * sound.c: Likewise.
1269 * term.c: Likewise.
1270 * w32console.c: Likewise.
1271 * w32fns.c: Likewise.
1272 * w32term.c: Likewise.
1273 * window.c: Likewise.
1274 * xdisp.c: Likewise.
1275 * xfaces.c: Likewise.
1276 * xfns.c: Likewise.
1277 * xselect.c: Likewise.
1278 * xterm.c: Likewise.
1279
1ec4b7b2
SM
12802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1281
1282 * fns.c (maybe_resize_hash_table): Output message when growing the
1283 purify-hashtable.
1284
2014308a
DA
12852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 * alloc.c (allocate_string_data): Remove dead code.
1288 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1289 avoid GCC warning about unused macro.
1290
246155eb
DA
12912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1292
1293 * alloc.c (allocate_string): Omit intervals initialization.
1294 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1295 as in make_pure_string and make_pure_c_string.
1296
43184b7b
DA
12972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1298
d209e2fb 1299 * alloc.c (allocate_string): Fix last change.
43184b7b 1300
3fe6dd74
DA
13012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1302
d209e2fb 1303 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1304 to memset, add explicit initialization where appropriate.
1305
1ba6038a
GM
13062012-06-27 Glenn Morris <rgm@gnu.org>
1307
1308 * lisp.mk (lisp): Remove paths.elc.
1309
c89926a5
CY
13102012-06-27 Chong Yidong <cyd@gnu.org>
1311
1312 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1313
ed6b3510
JW
13142012-06-26 John Wiegley <johnw@newartisans.com>
1315
1ec4b7b2 1316 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1317 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1318
ed6b3510
JW
1319 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1320 when building with Clang.
1321
8edd4a2b
SM
13222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1323
1324 * eval.c (Fapply): Allow calling it with a single argument.
1325
f6f62d1b
EZ
13262012-06-26 Eli Zaretskii <eliz@gnu.org>
1327
1328 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1329 _stricmp and _strnicmp.
1330 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1331
62efea5e
DA
13322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1335 allocated window.
1336 (allocate_process): Likewise for new process.
8edd4a2b 1337 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1338 (allocate_frame): Likewise.
1339 * frame.c (make_frame): Omit redundant initialization.
1340 * window.c (make_parent_window): Use memset.
1341 (make_window): Omit redundant initialization.
1342 * process.c (make_process): Omit redundant initialization.
1343 * terminal.c (create_terminal): Likewise.
1344
42997f4d
DA
13452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * term.c (delete_tty): Remove redundant call to memset.
1348
1130ecfc
DA
13492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 * alloc.c: Remove build_string.
1352 * lisp.h: Define build_string as static inline. This provides
1353 a better opportunity to optimize away calls to strlen when the
1354 function is called with compile-time constant argument.
1355 * image.c (imagemagick_error): Convert to build_string.
1356 * w32proc.c (sys_spawnve): Likewise.
1357 * xterm.c (x_term_init): Likewise.
1358
cf38a720
PE
13592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1360
99027bdd
PE
1361 Use sprintf return value instead of invoking strlen on result.
1362 In the old days this wasn't portable, since some sprintf
1363 implementations returned char *. But they died out years ago and
1364 Emacs already assumes sprintf returns int.
1365 Similarly for float_to_string.
1366 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1367 * ccl.c (ccl_driver):
1368 * character.c (string_escape_byte8):
1369 * data.c (Fnumber_to_string):
1370 * doprnt.c (doprnt):
1371 * print.c (print_object):
1372 * xdisp.c (message_dolog):
1373 * xfns.c (syms_of_xfns):
1374 Use sprintf or float_to_string result to avoid need to call strlen.
1375 * data.c (Fnumber_to_string):
1376 Use make_unibyte_string, since the string must be ASCII.
1377 * lisp.h, print.c (float_to_string): Now returns int length.
1378 * term.c (produce_glyphless_glyph):
1379 Use sprintf result rather than recomputing it.
1380
cf38a720
PE
1381 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1382 * Makefile.in (ALL_CFLAGS):
1383 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1384 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1385
3511c784
DA
13862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1387
0a08eb21 1388 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1389 strcasecmp if available.
1390 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1391
fb7da12e
AS
13922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1395 Avoid comma operator.
1396 * menu.c (push_submenu_start, push_submenu_end)
1397 (push_left_right_boundary, push_menu_pane): Likewise.
1398 * msdos.c (dos_rawgetc): Likewise.
1399
afa2ffd8
DA
14002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 * xfns.c (xic_create_fontsetname): Remove redundant calls
1403 to memset.
1404
b3b4476b
PE
14052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1406
4495ff38
PE
1407 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1408 sprintf already null-terminates its output.
1409
b3b4476b
PE
1410 * xfns.c (x_window): Remove redundant cast.
1411
b00876c9
DA
14122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1413
1414 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1415 `const char *' to `char *' to avoid compiler warning.
1416
d188e26b
PE
14172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1418
885d1d74
PE
1419 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1420 instead of truncating it to 63 (admittedly a generous limit).
1421
d188e26b
PE
1422 * process.c: Fix spelling and caps in comments.
1423
e2f560b1
DN
14242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1425
e86db54b 1426 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1427 * sysdep.c (setpgrp): Remove definition, not used in this file.
1428
7583a3a1
JB
14292012-06-24 Juanma Barranquero <lekktu@gmail.com>
1430
1431 * makefile.w32-in: Update dependencies.
1432
696056c2
EZ
14332012-06-24 Eli Zaretskii <eliz@gnu.org>
1434
1435 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1436 (SYSTIME_H): Add nt/inc/sys/time.h.
1437
1438 * systime.h [WINDOWSNT]: Include sys/time.h.
1439
1440 * s/ms-w32.h (struct timespec): Definition moved from
1441 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1442
845ca893
PE
14432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1446 * buffer.h (buffer_slot_type_mismatch):
1447 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1448 * eval.c (unwind_to_catch):
1449 * image.c (my_png_error, my_error_exit):
1450 * keyboard.c (quit_throw_to_read_char, user_error)
1451 (Fexit_recursive_edit, Fabort_recursive_edit):
1452 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1453 (wrong_type_argument, buffer_overflow, __executable_start)
1454 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1455 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1456 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1457 (fatal):
1458 (child_setup) [!DOS_NT]:
1459 * lread.c (end_of_file_error, invalid_syntax):
1460 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1461 * puresize.h (pure_write_error):
1462 * search.c (matcher_overflow):
1463 * sound.c (sound_perror, alsa_sound_perror):
1464 * sysdep.c, syssignal.h (croak):
1465 * term.c (maybe_fatal, vfatal):
1466 * textprop.c (text_read_only):
1467 * undo.c (user_error):
1468 * unexmacosx.c (unexec_error):
1469 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1470 Use _Noreturn rather than NO_RETURN.
1471 No need for separate decl merely because of _Noreturn.
1472 * sound.c (sound_warning, parse_sound):
1473 Remove unnecessary forward decls.
1474
f1dd8073
PE
14752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1478 * lisp.h (WAIT_READING_MAX): New macro.
1479 * dispnew.c (Fsleep_for, sit_for):
1480 * keyboard.c (kbd_buffer_get_event):
1481 * process.c (Faccept_process_output):
1482 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1483 This improves on the previous patch, which introduced a bug
1484 when time_t is unsigned and as wide as intmax_t.
1485 See <http://bugs.gnu.org/9000#51>.
1486
b82c1755
EZ
14872012-06-23 Eli Zaretskii <eliz@gnu.org>
1488
1489 * dispnew.c (sit_for, Fsleep_for):
1490 * keyboard.c (kbd_buffer_get_event):
1491 * process.c (Faccept_process_output): Avoid compiler warnings when
1492 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1493
ca300656
JB
14942012-06-23 Juanma Barranquero <lekktu@gmail.com>
1495
049ec95b
JB
1496 * makefile.w32-in: Update dependencies.
1497
ca300656
JB
1498 * w32.c (ltime): Add return type and declare static.
1499 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1500
db7b8d06
PE
15012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1504 Privately reported by Herbert J. Skuhra.
1505 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1506 All uses changed.
1507 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1508 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1509
0bd8297f
EZ
15102012-06-23 Eli Zaretskii <eliz@gnu.org>
1511
96512555
EZ
1512 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1513 last argument of make_unibyte_string.
1514
0bd8297f
EZ
1515 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1516 language ID in the event parameters.
1517
1518 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1519 event.code, not the obscure "character set ID".
1520
63def6b6
CY
15212012-06-23 Chong Yidong <cyd@gnu.org>
1522
1523 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1524
e8a02204
EZ
15252012-06-23 Eli Zaretskii <eliz@gnu.org>
1526
388cdec0
EZ
1527 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1528 * w32.c (fdutimens): New function.
1529
1530 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1531
1532 * s/ms-w32.h (pselect): Redirect to sys_select.
1533
1534 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1535
e8a02204
EZ
1536 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1537 in the logic of incrementing and decrementing the value of
1538 use_relocatable_buffers.
1539
d054f3fb
PE
15402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1543 Privately reported by Herbert J. Skuhra.
1544 [__FreeBSD__]: Remove "*/" typo after "#include".
1545 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1546 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1547 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1548 Don't assume EMACS_TIME and struct timeval are the same type.
1549
d35af63c
PE
15502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 Support higher-resolution time stamps (Bug#9000).
1553 The time stamps are only nanosecond-resolution at the C level,
1554 since that's the best that any real-world system supports now.
1555 But they are picosecond-resolution at the Lisp level, as that's
1556 easy, and leaves room for future OS improvements.
1557
1558 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1559 (LIBES): Use it.
1560
1561 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1562 Don't get current time unless it's needed.
1563
1564 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1565 now provides it if it's absent.
1566 (start_atimer): Port to higher-res time stamps.
1567 Check for time stamp overflow. Don't get current time more
1568 often than is needed.
1569
1570 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1571 Include systime.h, not time.h.
1572 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1573
1574 * dired.c: Include stat-time.h.
1575 (Ffile-attributes): File times now have higher resolution.
1576
1577 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1578 (struct image): Timestamp now has higher resolution.
1579
1580 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1581 has at least microseconds now. All uses removed.
1582 (update_frame, update_single_window, update_window, update_frame_1)
1583 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1584
1585 * editfns.c (time_overflow): Now extern.
1586 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1587 (float-time, Fformat_time_string, Fcurrent_time_string)
1588 (Fcurrent_time_zone): Accept and generate higher-resolution
1589 time stamps.
1590 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1591 (decode_time_components, lisp_seconds_argument): New functions.
1592 (make_time): Now static.
1593 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1594 Report an error if the time is invalid, rather than having the caller
1595 do that.
1596
1597 * fileio.c: Include <stat-time.h>
1598 (Fcopy_file): Copy higher-resolution time stamps.
1599 Prefer to set the time stamp via a file descriptor if that works.
1600 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1601 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1602 (Fvisited_file_modtime, Fset_visited_file_modtime):
1603 Support higher-resolution time stamps.
1604
1605 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1606
1607 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1608
1609 * image.c (prepare_image_for_display, clear_image_cache)
1610 (lookup_image): Port to higer-resolution time stamps.
1611
1612 * keyboard.c (start_polling, bind_polling_period):
1613 Check for time stamp overflow.
1614 (read_char, kbd_buffer_get_event, timer_start_idle)
1615 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1616 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1617 Port to higher-resolution time stamps. Do not assume time_t is signed.
1618 (decode_timer): New function. Timers are now vectors of length 9,
1619 not 8, to accommodate the picosecond component.
1620 (timer_check_2): Use it.
1621
1622 * nsterm.m (select_timeout, timeval_subtract): Remove.
1623 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1624 as they're a bit more accurate and handle overflow better.
1625 (ns_select): Change prototype to be compatible with pselect.
1626 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1627 * nsterm.h (ns_select): Adjust prototype.
1628
1629 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1630 us-resolution time stamps.
1631 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1632
1633 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1634
1635 * lisp.h (time_overflow): New decl.
1636 (wait_reading_process_output): First arg is now intmax_t, not int,
1637 to accommodate larger waits.
1638
1639 * process.h (struct Lisp_Process.read_output_delay):
1640 Now counts nanoseconds, not microseconds.
1641 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1642 EMACS_HAS_USECS.
1643 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1644 (wait_reading_process_output):
1645 Port to ns-resolution time stamps.
1646 (Faccept_process_output, wait_reading_process_output):
1647 Check for time stamp overflow. Do not assume time_t is signed.
1648 (select_wrapper): Remove; we now use pselect.
1649 (Fprocess_attributes): Now generates ns-resolution time stamps.
1650
1651 * sysdep.c: Include utimens.h. Don't include utime.h
1652 or worry about struct utimbuf; gnulib does that for us now.
1653 (gettimeofday): Remove; gnulib provides a substitute.
1654 (make_timeval): New function.
1655 (set_file_times): Now sets ns-resolution time stamps.
1656 New arg FD; all uses changed.
1657 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1658 (system_process_attributes):
1659 Now returns ns-resolution time stamp. All uses changed.
1660 Check for time stamp overflow.
1661
1662 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1663 provides a substitute now.
1664
1665 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1666 since it guarantees struct timespec.
1667 (EMACS_TIME): Now struct timespec, so that we can support
1668 ns-resolution time stamps.
1669 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1670 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1671 (EMACS_USECS): Remove.
1672 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1673 so multiply the arg by 1000 before storing it.
1674 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1675 New macros.
1676 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1677 Port to ns-resolution time stamps.
1678 (EMACS_TIME_NEG_P): Remove; replaced by....
1679 (EMACS_TIME_SIGN): New macro.
1680 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1681 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1682 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1683 (make_timeval, make_lisp_time, decode_time_components): New decls.
1684 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1685 that it mishandled time_t overflow. You can't compare by subtracting!
1686 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1687 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1688
1689 * term.c: Include <sys/time.h>.
1690 (timeval_to_Time): New function, for proper overflow wraparound.
1691 (term_mouse_position, term_mouse_click): Use it.
1692
1693 * undo.c (record_first_change): Support higher-resolution time stamps
1694 in the undo buffer.
1695 (Fprimitive_undo): Use them when restoring time stamps.
1696
1697 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1698 (w32_get_internal_run_time):
1699 Port to higher-resolution Emacs time stamps.
1700 (ltime): Now accepts single 64-bit integer, as that's more convenient
1701 for callers.
1702
1703 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1704
1705 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1706 for compatibility with pselect. Support ns-resolution time stamps.
1707
1708 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1709
1710 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1711 Check for time stamp overflow, and support ns-resolution time stamps.
1712
1713 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1714 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1715 (timeval_subtract): Remove; no longer needed.
1716 (XTflash, XTring_bell, x_wait_for_event):
1717 Port to ns-resolution time stamps. Don't assume time_t is signed.
1718
b6a92dfe
CY
17192012-06-22 Chong Yidong <cyd@gnu.org>
1720
1721 * xdisp.c (x_consider_frame_title): Revert last change.
1722
d251c37c
EZ
17232012-06-22 Eli Zaretskii <eliz@gnu.org>
1724
1725 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1726 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1727 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1728 staticidx goes up to 1597 out of 1600 = 0x640.)
1729
f10deafb
PE
17302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1733 Otherwise, the umask might be mistakenly 0 while handling input signals.
1734
ec6de1e2
SM
17352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1736
1737 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1738
28be1ada
DA
17392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1740
1741 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1742 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1743 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1744 access to `contents' member of Lisp_Vector objects with AREF and ASET
1745 where appropriate.
1746
c6bf3022
CY
17472012-06-19 Chong Yidong <cyd@gnu.org>
1748
1749 * frame.c (delete_frame): When selecting a frame on a different
1750 text terminal, do not alter the terminal's top-frame.
1751
1752 * xdisp.c (format_mode_line_unwind_data): Record the target
1753 frame's selected window and its terminal's top-frame.
1754 (unwind_format_mode_line): Restore them.
1755 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1756 Callers changed.
1757 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1758 since tty frames can be explicitly named.
1759 (prepare_menu_bars): Likewise.
1760
1761 * term.c (Ftty_top_frame): New function.
1762
defd4196
PE
17632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1764
1765 Port byte-code-meter to modern targets.
1766 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1767 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1768 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1769 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1770 (METER_1, METER_2): Simplify.
1771
1053a871
SM
17722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1773
1774 * data.c (Fdefalias): Return `symbol' (bug#11686).
1775
b7e8d081
MR
17762012-06-18 Martin Rudalics <rudalics@gmx.at>
1777
1778 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1779 gets killed during executing of this function (Bug#11665).
1780 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1781 (Vkill_buffer_query_functions): In doc-string say that functions
1782 run by this hook should not change the current buffer.
1783
7ea2b339
PE
17842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1785
1786 Fix recently-introduced process.c problems found by static checking.
1787 * process.c (write_queue_push, write_queue_pop, send_process):
1788 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1789 (write_queue_pop): Fix pointer signedness problem.
1790 (send_process): Remove unused local.
1791
96a313a1
CY
17922012-06-17 Chong Yidong <cyd@gnu.org>
1793
1794 * xdisp.c (redisplay_internal): No need to redisplay terminal
1795 frames that are not on top.
1796
20ca2e94
TN
17972012-06-17 Troels Nielsen <bn.troels@gmail.com>
1798
1799 * process.c (make_process): Initialize write_queue.
1800 (write_queue_push, write_queue_pop): New functions.
1801 (send_process): Use them to maintain correct ordering of process
1802 writes (Bug#10815).
1803
9a900ca9
PE
18042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1805
310fbfa8
PE
1806 * lisp.h (eassert): Assume C89 or later.
1807 This removes the need for CHECK.
1808 (CHECK): Remove. Its comments about always evaluating its
1809 argument were confusing, as 'eassert' typically does not evaluate
1810 its argument.
1811
27bb1ca4
PE
1812 * coding.c (produce_chars): Use ptrdiff_t, not int.
1813
9a900ca9
PE
1814 * xterm.c (x_draw_underwave): Check for integer overflow.
1815 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1816
41b7f8bc 18172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1818
1819 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1820 referenced (Bug#11583).
1821
9b0e3eba
AA
18222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1823
1824 Implement wave-style variant of underlining.
1825 * dispextern.h (face_underline_type): New enum.
1826 (face): Add field for underline type.
1827 * nsterm.m (ns_draw_underwave): New function.
1828 (ns_draw_text_decoration): Use it.
1829 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1830 New functions.
1831 (x_draw_glyph_string): Use them.
1832 * xfaces.c (Qline, Qwave): New Lisp objects.
1833 (check_lface_attrs, merge_face_ref)
1053a871
SM
1834 (Finternal_set_lisp_face_attribute, realize_x_face):
1835 Handle wave-style underline face attributes.
9b0e3eba
AA
1836 * xterm.c (x_draw_underwave): New function.
1837 (x_draw_glyph_string): Use it.
1838
0fb52f11
JB
18392012-06-16 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1842 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1843 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1844 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1845 ($(BLD)/w32select.$(O)): Update dependencies.
1846
e5560ff7
AS
18472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1850 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1851 * character.c (_fetch_multibyte_char_p): Remove.
1852 * alloc.c: Include "character.h" before "buffer.h".
1853 * bidi.c: Likewise.
1854 * buffer.c: Likewise.
1855 * bytecode.c: Likewise.
1856 * callint.c: Likewise.
1857 * callproc.c: Likewise.
1858 * casefiddle.c: Likewise.
1859 * casetab.c: Likewise.
1860 * category.c: Likewise.
1861 * cmds.c: Likewise.
1862 * coding.c: Likewise.
1863 * composite.c: Likewise.
1864 * dired.c: Likewise.
1865 * dispnew.c: Likewise.
1866 * doc.c: Likewise.
1867 * dosfns.c: Likewise.
1868 * editfns.c: Likewise.
1869 * emacs.c: Likewise.
1870 * fileio.c: Likewise.
1871 * filelock.c: Likewise.
1872 * font.c: Likewise.
1873 * fontset.c: Likewise.
1874 * fringe.c: Likewise.
1875 * indent.c: Likewise.
1876 * insdel.c: Likewise.
1877 * intervals.c: Likewise.
1878 * keyboard.c: Likewise.
1879 * keymap.c: Likewise.
1880 * lread.c: Likewise.
1881 * macros.c: Likewise.
1882 * marker.c: Likewise.
1883 * minibuf.c: Likewise.
1884 * nsfns.m: Likewise.
1885 * nsmenu.m: Likewise.
1886 * print.c: Likewise.
1887 * process.c: Likewise.
1888 * regex.c: Likewise.
1889 * region-cache.c: Likewise.
1890 * search.c: Likewise.
1891 * syntax.c: Likewise.
1892 * term.c: Likewise.
1893 * textprop.c: Likewise.
1894 * undo.c: Likewise.
1895 * unexsol.c: Likewise.
1896 * w16select.c: Likewise.
1897 * w32fns.c: Likewise.
1898 * w32menu.c: Likewise.
1899 * window.c: Likewise.
1900 * xdisp.c: Likewise.
1901 * xfns.c: Likewise.
1902 * xmenu.c: Likewise.
1903 * xml.c: Likewise.
1904 * xselect.c: Likewise.
1905
2f07e6af
EZ
19062012-06-16 Eli Zaretskii <eliz@gnu.org>
1907
1053a871
SM
1908 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1909 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1910 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1911 row.
1912 (handle_face_prop): Use chunk-relative overlay string index when
1913 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1914 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1915 the rightmost. (Bug#11720)
2f07e6af 1916
29b83cec
AS
19172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1918
1919 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1920 (CATEGORY_MEMBER): Enforce 1/0 value.
1921 * category.c (_temp_category_set): Remove.
1922
4c5501e9
EZ
19232012-06-16 Eli Zaretskii <eliz@gnu.org>
1924
1925 * window.c (Fdelete_other_windows_internal)
1926 (Fdelete_window_internal): Don't access frame's mouse highlight
1927 info of the initial frame. (Bug#11677)
1928
2b570124
PE
19292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1930
e93864f9
PE
1931 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1932 Assume USE_2_TAGS_FOR_INTS.
1933 (xreload): Adjust $tagmask width to match recent lisp.h change.
1934
2b570124
PE
1935 Simplify lisp.h in minor ways that should not affect code.
1936 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1937 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1938 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1939 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1940 (INTTYPEBITS): New macro, for clarity.
1941 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1942 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1943 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1944 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1945 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1946
81755f69
JB
19472012-06-13 Juanma Barranquero <lekktu@gmail.com>
1948
1949 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1950
16192a57
GM
19512012-06-13 Glenn Morris <rgm@gnu.org>
1952
1953 * s/bsd-common.h (BSD4_3):
1954 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1955
646b5f55
AS
19562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1957
1958 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1959 instead of union.
1960 (XLI, XIL): Define.
1053a871
SM
1961 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1962 Use them.
1963 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1964 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1965 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1966 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1967 * frame.c (delete_frame): Remove outdated comment.
1968 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1969 USE_LISP_UNION_TYPE.
1970 (Fw32_unregister_hot_key): Likewise.
1971 (Fw32_toggle_lock_key): Likewise.
1972 * w32menu.c (add_menu_item): Likewise.
1973 (w32_menu_display_help): Use XIL instead of checking
1974 USE_LISP_UNION_TYPE.
1975 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1976 (init_heap): Likewise.
1977 * w32term.c (w32_read_socket): Update comment.
1978
1d3823c9
GM
19792012-06-13 Glenn Morris <rgm@gnu.org>
1980
c62ff706
GM
1981 * s/usg5-4-common.h, src/s/unixware.h:
1982 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1983
1d3823c9
GM
1984 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1985
bfe3e0a2
PE
19862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1989 * alloc.c (make_number) [!defined make_number]:
1990 Remove, as lisp.h always defines this now.
1991 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1992 (roundup_size): Verify that it is a power of 2.
1993 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1994 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1995 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1996 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1997 USE_LSB_TAG now is always defined to be either 0 or 1.
1998 All uses changed.
1999 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2000 code works fine either way, and efficiency is not a concern here,
2001 as the union type is for debugging, not for production.
2002 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2003 Use an inline function on all platforms when using the union type,
2004 since this is simpler and 'static inline' can be used portably
2005 within Emacs now.
2006 (LISP_INITIALLY_ZERO): New macro.
2007 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2008 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2009
45fa9c0f
GM
20102012-06-12 Glenn Morris <rgm@gnu.org>
2011
b4492cba
GM
2012 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2013
2014 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2015
45fa9c0f
GM
2016 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2017 Move BROKEN_SIGIO to configure.
2018
2019 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2020 Move NO_TERMIO to configure.
2021
0e25d334
CY
20222012-06-12 Chong Yidong <cyd@gnu.org>
2023
2024 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2025 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2026 MagickExportImagePixels is undefined.
2027
43682bb6
PE
20282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * image.c (imagemagick_load_image): Remove unused label.
2031
a9be7d2b
GM
20322012-06-11 Glenn Morris <rgm@gnu.org>
2033
2034 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2035 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2036 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2037 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2038
3017f87f
SM
20392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2040
2041 * alloc.c (make_byte_code): New function.
2042 (Fmake_byte_code): Use it. Don't purify here.
2043 * lread.c (read1): Use it as well to avoid extra allocation.
2044
1b9b4cf4
CY
20452012-06-11 Chong Yidong <cyd@gnu.org>
2046
2047 * image.c (imagemagick_load_image): Implement transparency.
2048
95988fcf
AS
20492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2050
2051 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2052 account for preceding backslashes. (Bug#11663)
2053
cd4eb164
CY
20542012-06-09 Chong Yidong <cyd@gnu.org>
2055
2056 * term.c: Support italics in capable terminals (Bug#9652).
2057 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2058 (turn_on_face): Output using TS_enter_italic_mode if available.
2059 Don't handle unused blinking and alt-charset cases.
2060 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2061 and tty_alt_charset_p cases.
2062 (tty_capable_p, init_tty): Support italics.
2063
2064 * termchar.h (struct tty_display_info): Add field for italics.
2065 Remove unused blink field.
2066
2067 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2068 Handle slant.
2069
2070 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2071 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2072 tty_alt_charset_p. Add tty_italic_p.
2073
ff88beb8
MA
20742012-06-09 Michael Albinus <michael.albinus@gmx.de>
2075
2076 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2077 dbus_type_is_basic if available.
2078 (xd_extract_signed, xd_extract_unsigned): Rename from
2079 extract_signed and extract_unsigned, respectively. Adapt callers.
2080
44286096
CY
20812012-06-09 Chong Yidong <cyd@gnu.org>
2082
1682701f
CY
2083 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2084
44286096
CY
2085 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2086 case (Bug#9752).
2087
d86feb17
PE
20882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * xdisp.c (vmessage): Treat frame message as multibyte.
2091 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2092 would generate the diagnostic "Making \302\247 buffer-local while
2093 let-bound!".
2094
d5c20fe8
EZ
20952012-06-08 Eli Zaretskii <eliz@gnu.org>
2096
2097 * dispnew.c (showing_window_margins_p): Undo last change, which
2098 was done due to an inadvertent commit.
2099 (adjust_frame_glyphs_for_frame_redisplay): Do call
2100 showing_window_margins_p.
2101
513749ee
SM
21022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2103
2104 * eval.c (Fmake_var_non_special): New primitive.
2105 (syms_of_eval): Defsubr it.
2106 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2107
d4a8f5c1
JB
21082012-06-08 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2111 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2112
8bbbc977
EZ
21132012-06-08 Eli Zaretskii <eliz@gnu.org>
2114
2115 * alloc.c (allocate_vectorlike): Fix last change.
2116
f3372c87
DA
21172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 Block-based vector allocation of small vectors.
2120 * lisp.h (struct vectorlike_header): New field `nbytes',
2121 adjust comment accordingly.
2122 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2123 to denote vector blocks. Adjust users (live_vector_p,
2124 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2125 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2126 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2127 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2128 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2129 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2130 (roundup_size): New constant.
2131 (struct vector_block): New data type.
2132 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2133 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2134 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2135 (sweep_vectors): New functions.
2136 (allocate_vectorlike): Return `zero_vector' as the only vector of
2137 0 items. Allocate new vector from block if vector size is less than
2138 or equal to VBLOCK_BYTES_MAX.
2139 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2140 (init_alloc_once): Add call to init_vectors.
2141
4f18a4ed
SM
21422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2143
2144 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2145
86f158bc
PE
21462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * doprnt.c (doprnt): Truncate multibyte char correctly.
2149 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2150 would mishandle a string argument "Xc" if X was a multibyte
2151 character of length 2: it would truncate after X's first byte
2152 rather than including all of X.
2153
c5cfcbe0
CY
21542012-06-06 Chong Yidong <cyd@gnu.org>
2155
2156 * buffer.c (word_wrap): Doc fix.
2157
c05cf390
PE
21582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2161
0c3461de
GM
21622012-06-03 Glenn Morris <rgm@gnu.org>
2163
2164 * xdisp.c (tool-bar-style): Doc fix.
2165
c71232db
UM
21662012-06-03 Ulrich Müller <ulm@gentoo.org>
2167
2168 * Makefile.in (PAXCTL): Define.
2169 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2170 binary via PaX flags if the paxctl utility is available.
2171 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2172 Restore PaX flags to their default. (Bug#11398)
2173
383f7350
CY
21742012-06-03 Chong Yidong <cyd@gnu.org>
2175
2176 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2177 buffer (Bug#11226).
2178
5f2c76c6
CY
21792012-06-03 Chong Yidong <cyd@gnu.org>
2180
2181 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2182 (note_mode_line_or_margin_highlight): If there is no help echo,
2183 use mode-line-default-help-echo. Handle the case where the mouse
2184 position is past the end of the mode line string.
2185
2186 * buffer.c (buffer_local_value_1): New function, split from
2187 Fbuffer_local_value; can return Qunbound.
2188 (Fbuffer_local_value): Use it.
2189 (Vmode_line_format): Docstring tweaks.
2190
773d47f6
PE
21912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 * sysdep.c (system_process_attributes): Improve comment.
2194
f2d6a3df
SM
21952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2196
2197 * keyboard.c: Export real-this-command to Elisp.
2198 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2199 and DEFVAR it. Update all users.
2200
63810350
PE
22012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2202
7bd5c1f4
PE
2203 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2204
63810350
PE
2205 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2206 Convert pctcpu and pctmem to Lisp float properly.
2207 Let the compiler fold better, as 100.0/0x8000 is exact.
2208
a2821611
AS
22092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2210
2211 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2212 cons_block.
2213
5fceba1d
PE
22142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2217
c98ff5dd
DA
22182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2219
2220 For a 'struct window', replace some Lisp_Object fields to
2221 bitfields where appropriate, remove unused fields.
2222 * window.h (struct window): Remove unused 'last_mark_x' and
2223 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2224 change it's type from Lisp_Object to bitfield.
2225 Change type of 'force_start', 'optional_new_start',
2226 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2227 fields from Lisp_Object to bitfield. Adjust users accordingly.
2228
ca34e0be
PE
22292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Pacify gcc -Wdouble-precision when using Xaw.
2232 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2233 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2234 Use 'float' consistently, rather than 'float' in most places
2235 and 'double' in a couple of places.
2236
efc00ab1 22372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2238
2239 * xdisp.c (handle_stop): Detect whether we have overlay strings
2240 loaded by testing it->current.overlay_string_index to be
2241 non-negative, instead of checking whether n_overlay_strings is
2242 positive. (Bug#11587)
2243
efc00ab1 22442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2245
2246 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2247
2248 * doc.c (Fsubstitute_command_keys): Doc fix.
2249
efc00ab1 22502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2251
2252 * search.c (search_buffer): Remove calls to
2253 r_alloc_inhibit_buffer_relocation, as it is now called by
2254 maybe_unify_char, which was the cause of relocation of buffer text
2255 in bug#11519.
2256
efc00ab1 22572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2258
2259 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2260 for the duration of call to load_charset, to avoid problems with
2261 callers of maybe_unify_char that access buffer text through C
2262 pointers.
2263
2264 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2265 decrement the inhibition flag, instead of just setting or
2266 resetting it.
2267
ba93a187
PE
22682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 Remove obsolete '#define static' cruft.
2271 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2272 This #undef was "temporary" in 2000; it is no longer needed
2273 now that '#define static' has gone away.
2274 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2275 (gray_bitmap_bits): Remove; no longer needed.
2276 All uses replaced with definiens.
2277 * xterm.c: Include "bitmaps/gray.xbm".
2278
9e4bf381
PE
22792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 Clean up __executable_start, monstartup when --enable-profiling.
2282 The following changes affect the code only when profiling.
2283 * dispnew.c (__executable_start): Rename from safe_bcopy.
2284 Define only on platforms that need it.
2285 * emacs.c: Include <sys/gmon.h> when profiling.
2286 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2287 (__executable_start): Remove decl, since lisp.h does it now.
2288 (safe_bcopy): Remove decl; no longer has that name.
2289 (main): Coalesce #if into single bit of code, for simplicity.
2290 Cast pointers to uintptr_t, since standard libraries want integers
2291 and not pointers.
2292 * lisp.h (__executable_start): New decl.
2293
32d72c2f
GM
22942012-05-31 Glenn Morris <rgm@gnu.org>
2295
2296 * image.c (Fimagemagick_types): Doc fix.
2297
baac5bc7
JM
22982012-05-30 Jim Meyering <meyering@redhat.com>
2299
2300 * callproc.c (Fcall_process_region): Include directory component
2301 in mkstemp error message (Bug#11586).
2302
72cb32cf
PE
23032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 * alloc.c, lisp.h (make_pure_vector): Now static.
2306
61b108cc
SM
23072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2308
2309 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2310 Move to byte-run.el.
2311 (Fautoload): Do the hash-doc more carefully.
2312 * data.c (Fdefalias): Purify definition, except for keymaps.
2313 (Qdefun): Move from eval.c.
2314 * lisp.h (Qdefun): Remove.
2315 * lread.c (read1): Tiny simplification.
2316
471fe23d
TN
23172012-05-29 Troels Nielsen <bn.troels@gmail.com>
2318
934f3f58 2319 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2320 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2321 Bug#9642, but explicitly check that the buffer the overlay would
2322 be moved to is live and rearrange lines to make sure that errors
2323 will not put the overlay in an inconsistent state.
2324 (Fdelete_overlay): Cosmetics.
2325
85d0efd1
EZ
23262012-05-28 Eli Zaretskii <eliz@gnu.org>
2327
2328 * w32term.c (my_bring_window_to_top): New function.
2329 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2330 could be different from the original one.
2331 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2332 (Bug#11513)
2333
2334 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2335 by calling BringWindowToTop.
2336
2337 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2338 (WM_EMACS_END): Increase by one.
2339
da92a98c
PE
23402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2343 This avoids undefined behavior that might cause the eassert
2344 to not catch an out-of-range value.
2345
74d1f848
JB
23462012-05-28 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2349 Update dependencies.
2350
9e1a06fc
EZ
23512012-05-27 Eli Zaretskii <eliz@gnu.org>
2352
2353 * bidi.c (bidi_mirror_char): Fix last change.
2354
f3dd7312
AS
23552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2356
2357 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2358 when referring to sectname field in printf format.
2359
81899c91
PE
23602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2361
57b81a9f
PE
2362 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2363 Only r_alloc_inhibit_buffer_relocation needed to be added;
2364 the others were already declared.
2365
81899c91
PE
2366 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2367 before checking whether it's out of range. Put the check inside
2368 eassert. See
2369 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2370
33017faf 23712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2372
2373 * callproc.c (Fcall_process): Restore a line that was accidentally
2374 commented out in the 2011-02-13 change (bug#11547).
2375
33017faf 23762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2377
2378 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2379 defined on ralloc.c.
2380
2381 * buffer.c [REL_ALLOC]: Remove prototypes of
2382 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2383 they are now on lisp.h.
2384
2385 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2386
2387 * search.c (search_buffer): Use it to inhibit relocation of buffer
2388 text while re_search_2 is doing its job, because re_search_2 is
2389 passed C pointers to buffer text. (Bug#11519)
2390
23415acf
EZ
2391 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2392 Update value to 24.
2393
44e27368
EZ
2394 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2395 state after an additional call to move_it_in_display_line_to, keep
2396 the values of it->max_ascent and it->max_descent found for the
2397 entire line.
2398 (pos_visible_p): Revert the comparison against bottom_y to what it
2399 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2400 (Bug#11464)
2401
c1892f11
PE
24022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 Fix coding-related core dumps with gcc -ftrapv.
2405 The code was computing A - B, where A and B are pointers, and B is
2406 random garbage. This can lead to core dumps on platforms that
2407 have special pointer registers, and it also leads to core dumps on
2408 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2409 A - B only when B is initialized properly.
2410 * coding.c (coding_set_source, coding_set_destination): Return void.
2411 (coding_change_source, coding_change_destinations): New functions,
2412 with the old behaviors of coding_set_source and coding_set_destination.
2413 All callers that need an offset changed to use these new functions.
2414
eb7afdad
GM
24152012-05-26 Glenn Morris <rgm@gnu.org>
2416
2417 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2418
f12fdf02
EZ
24192012-05-26 Eli Zaretskii <eliz@gnu.org>
2420
53a63be6 2421 Extend mouse support on W32 text-mode console.
61b108cc
SM
2422 * xdisp.c (draw_row_with_mouse_face):
2423 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2424
eb3f6f01 2425 * w32console.c: Include window.h.
61b108cc
SM
2426 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2427 New functions.
eb3f6f01
EZ
2428 (initialize_w32_display): Initialize mouse-highlight data.
2429
53a63be6
EZ
2430 * w32inevt.c: Include termchar.h and window.h.
2431 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2432 moves, call note_mouse_highlight. If help_echo changed, call
2433 gen_help_event to produce help-echo message in the echo area.
2434 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2435 highlight info.
2436
4cfd81f6
PE
24372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * lread.c (read1): Simplify slightly to avoid an overflow warning
2440 with GCC 4.7.0 on x86-64.
2441
4446092a
EZ
24422012-05-26 Eli Zaretskii <eliz@gnu.org>
2443
2444 * bidi.c (bidi_mirror_char): Revert last change: an int is
2445 definitely wide enough here.
2446
42b2a986 24472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2448
42b2a986 2449 Fix integer width and related bugs (Bug#9874).
eb106a49 2450 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2451 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2452 (string_bytes, check_sblock, allocate_string_data):
2453 (compact_small_strings, Fmake_bool_vector, make_string)
2454 (make_unibyte_string, make_multibyte_string)
2455 (make_string_from_bytes, make_specified_string)
2456 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2457 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2458 (mark_vectorlike):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (allocate_pseudovector):
2461 Use int, not EMACS_INT, where int is wide enough.
2462 (inhibit_garbage_collection, Fgarbage_collect):
2463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2464 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2465 int might not be wide enough.
2466 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2467 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2468 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2469 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2470 (bidi_level_of_next_char, bidi_move_to_visually_next):
2471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2472 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2473 (Fkill_buffer, Fset_buffer_major_mode)
2474 (advance_to_char_boundary, Fbuffer_swap_text)
2475 (Fset_buffer_multibyte, overlays_at, overlays_in)
2476 (overlay_touches_p, struct sortvec, record_overlay_string)
2477 (overlay_strings, recenter_overlay_lists)
2478 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2479 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2480 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2481 (Foverlay_recenter, last_overlay_modification_hooks_used)
2482 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2484 (validate_region): Omit unnecessary test for b <= e,
2485 since that's guaranteed by the previous test.
d311d28c
PE
2486 (adjust_overlays_for_delete): Avoid pos + length overflow.
2487 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2488 (report_overlay_modification):
2489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2490 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2491 Omit pointer cast, which isn't needed anyway, and doesn't work
2492 after the EMACS_INT -> ptrdiff_t change.
02481186 2493 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2494 * buffer.h: Adjust decls to match defn changes elsewhere.
2495 (struct buffer_text, struct buffer):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2498 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2499 not int, to avoid needless 32-bit limit on 64-bit hosts.
2500 (exec_byte_code): Use tighter memory-full test, one that checks
2501 for alloca overflow. Don't compute the address of the object just
2502 before an array, as that's not portable. Use EMACS_INT, not
2503 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2504 * callint.c (Fcall_interactively):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 * callproc.c (call_process_kill, Fcall_process):
2507 Don't assume pid_t fits into an Emacs fixnum.
2508 (call_process_cleanup, Fcall_process, child_setup):
2509 Don't assume pid_t fits into int.
2510 (call_process_cleanup, Fcall_process, delete_temp_file)
2511 (Fcall_process_region):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (Fcall_process): Simplify handling of volatile integers.
2514 Use int, not EMACS_INT, where int will do.
2515 * casefiddle.c (casify_object, casify_region, operate_on_word)
2516 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2518 (casify_object): Avoid integer overflow when overallocating buffer.
2519 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2520 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2521 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2522 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2523 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2524 integers are now checked earlier. All uses replaced with XINT.
2525 (ccl_driver):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2528 (ccl_driver, Fregister_code_conversion_map):
2529 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2530 (resolve_symbol_ccl_program): Check that vector header is in range.
2531 Always copy the vector, so that we can check its contents reliably
2532 now rather than having to recheck each instruction as it's being
2533 executed. Check that vector words fit in 'int'.
2534 (ccl_get_compiled_code, Fregister_ccl_program)
2535 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2536 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2537 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2538 contents are in range.
2539 (Fccl_execute_on_string): Check that status is in range.
2540 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2541 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2542 Accept and return EMACS_INT, not int, because callers can pass values
2543 out of 'int' range.
2544 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2545 (multibyte_chars_in_text, parse_str_as_multibyte)
2546 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2547 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2548 (string_escape_byte8, Fget_byte):
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2550 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2551 avoid mishandling large integers.
2552 * character.h: Adjust decls to match defn changes elsewhere.
2553 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2554 (Ffind_charset_region):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2557 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2558 Don't assume fixnum fits in int.
d311d28c
PE
2559 (load_charset_map_from_vector, Fmap_charset_chars):
2560 Remove now-unnecessary CHECK_NATNUMs.
2561 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2562 Don't rely on undefined behavior with signed left shift overflow.
2563 Don't assume unsigned int fits into fixnum, or that fixnum fits
2564 into unsigned int. Don't require max_code to be a valid fixnum;
2565 that's not true for gb10830 4-byte on a 32-bit host. Allow
2566 invalid_code to be a cons, for the same reason. Require code_offset
2567 to be a character. Avoid int overflow if max_char is close
2568 to INT_MAX.
2569 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2570 this is intended anyway and avoids some undefined behavior.
2571 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2572 INDEX_TO_CODE_POINT, as that's what it expects.
2573 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2574 * charset.h (DECODE_CHAR): Return int, not unsigned;
2575 this is what was intended anyway, and it avoids undefined behavior.
2576 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2577 integer-overflow issues.
2578 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2579 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2580 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2581 * chartab.c (Fmake_char_table, Fset_char_table_range)
2582 (uniprop_get_decoder, uniprop_get_encoder):
2583 Don't assume fixnum fits in int.
2584 * cmds.c (move_point): New function, that does the gist of
2585 Fforward_char and Fbackward_char, but does so while checking
2586 for integer overflow more accurately.
c96e5d6a 2587 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2588 (Fforward_line, Fend_of_line, internal_self_insert)
2589 (internal_self_insert):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 Fix a FIXME, by checking for integer overflow when calculating
2592 target_clm and actual_clm.
2593 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2594 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2595 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2596 (coding_alloc_by_making_gap, alloc_destination)
2597 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2598 (encode_coding_utf_16, detect_coding_emacs_mule)
2599 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2600 (detect_coding_iso_2022, decode_coding_iso_2022)
2601 (encode_invocation_designation, encode_designation_at_bol)
2602 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2603 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2604 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2605 (encode_coding_ccl, encode_coding_raw_text)
2606 (detect_coding_charset, decode_coding_charset)
2607 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2608 (produce_composition, produce_charset, produce_annotation)
2609 (decode_coding, handle_composition_annotation)
2610 (handle_charset_annotation, consume_chars, decode_coding_gap)
2611 (decode_coding_object, encode_coding_object, detect_coding_system)
2612 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2613 (code_convert_region, code_convert_string)
8f50130c
PE
2614 (Fdefine_coding_system_internal)
2615 (coding_set_source, coding_set_destination):
d311d28c
PE
2616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2617 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2618 (Fdefine_coding_system_internal):
2619 Don't assume fixnums fit in int.
2620 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2621 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2622 (Funencodable_char_position, Fcheck_coding_systems_region)
2623 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2625 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2626 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2627 Don't access memory outside of the args array.
d311d28c 2628 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2629 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2630 result of ENCODE_CHAR.
d311d28c
PE
2631 * coding.h: Adjust decls to match defn changes elsewhere.
2632 (struct coding_system):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 * composite.c (get_composition_id, find_composition)
2635 (run_composition_function, update_compositions)
2636 (compose_text, composition_gstring_put_cache)
2637 (composition_gstring_p, composition_gstring_width)
2638 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2639 (composition_compute_stop_pos, composition_reseat_it)
2640 (composition_update_it, struct position_record)
2641 (find_automatic_composition, composition_adjust_point)
2642 (Fcomposition_get_gstring, Ffind_composition_internal):
2643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2644 (update_compositions):
2645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2646 * composite.h: Adjust decls to match defn changes elsewhere.
2647 (struct composition):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2650 Do not attempt to compute the address of the object just before a
2651 buffer; this is not portable.
2652 (Faref, Faset):
2653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2654 (Faset): Use int, not EMACS_INT, where int is wide enough.
2655 (Fstring_to_number): Don't assume fixnums fit in int.
2656 (Frem): Don't assume arg is nonnegative.
2657 * dbusbind.c (xd_append_arg): Check for integers out of range.
2658 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2659 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2660 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2661 (xd_get_connection_references): Return ptrdiff_t, not int.
2662 All uses changed.
2663 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2664 (xd_read_message_1):
2665 Use int, not unsigned, where the dbus API uses int.
2666 (Fdbus_message_internal): Don't overflow mtype.
2667 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2668 * dired.c (directory_files_internal, file_name_completion, scmp)
2669 (file_name_completion_stat):
2670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2671 (file_name_completion): Don't overflow matchcount.
2672 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2673 * dispextern.h: Adjust decls to match defn changes elsewhere.
2674 (struct text_pos, struct glyph, struct bidi_saved_info)
2675 (struct bidi_string_data, struct bidi_it, struct composition_it)
2676 (struct it):
2677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2678 (struct display_pos, struct composition_it, struct it):
2679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2680 * dispnew.c (increment_matrix_positions)
2681 (increment_row_positions, mode_line_string)
2682 (marginal_area_string):
2683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2684 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2686 (duration_to_sec_usec): New function, to check for overflow better.
2687 (Fsleep_for, sit_for): Use it.
2688 * doc.c (get_doc_string, store_function_docstring):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (get_doc_string, Fsnarf_documentation):
2691 Use int, not EMACS_INT, where int is wide enough.
2692 (get_doc_string):
2693 Use SAFE_ALLOCA, not alloca.
2694 Check for overflow when converting EMACS_INT to off_t.
2695 * doprnt.c (doprnt):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2697 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2698 Don't assume uid_t fits into fixnum.
2699 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2700 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2701 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2702 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2703 (general_insert_function)
2704 (Finsert_char, make_buffer_string, make_buffer_string_both)
2705 (update_buffer_properties, Fbuffer_substring)
2706 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2707 (Fsubst_char_in_region, check_translation)
2708 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2709 (transpose_markers, Ftranspose_regions):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2711 (clip_to_bounds): Move to lisp.h as an inline function).
2712 (Fconstrain_to_field): Don't assume integers are nonnegative.
2713 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2714 (Fsubst_char_in_region, Fsave_restriction):
2715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2716 (Femacs_pid): Don't assume pid_t fits into fixnum.
2717 (lo_time): Use int, not EMACS_INT, when int suffices.
2718 (lisp_time_argument): Check for usec out of range.
2719 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2720 (Fuser_login_name, Fuser_full_name): Signal an error
2721 if a uid argument is out of range, rather than relying on
2722 undefined behavior.
c8d5c857
PE
2723 (Fformat_time_string): Remove now-unnecessary check.
2724 lisp_time_argument checks for out-of-range usec now.
243e0530 2725 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2726 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2727 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2728 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2729 (init_cmdargs, Fdump_emacs):
2730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2731 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2732 the bottom (typically) 32 bits of the fixnum.
2733 * eval.c (specpdl_size, call_debugger):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (when_entered_debugger, Fbacktrace_debug):
2736 Don't assume fixnum can fit in int.
2737 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2738 the object just before a buffer; this is not portable.
2739 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2740 (grow_specpdl, unbind_to):
2741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2742 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2743 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2744 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2745 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2746 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2749 (a_write, e_write):
2750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2751 (Fcopy_file, non_regular_nbytes, read_non_regular)
2752 (Finsert_file_contents):
2753 Use int, not EMACS_INT, where int is wide enough.
2754 (READ_BUF_SIZE): Verify that it fits in int.
2755 (Finsert_file_contents): Check that counts are in proper range,
2756 rather than assuming fixnums fit into ptrdiff_t etc.
2757 Don't assume fixnums fit into int.
125b3835 2758 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2759 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2760 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2761 (string_char_to_byte, string_byte_to_char)
2762 (string_make_multibyte, string_to_multibyte)
2763 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2764 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2765 (substring_both, Fdelete, internal_equal, Ffillarray)
2766 (Fclear_string, mapcar1)
2767 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2768 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2769 (larger_vector, make_hash_table, maybe_resize_hash_table)
2770 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2771 (Fmaphash, secure_hash):
2772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2773 (concat): Check for string index and length overflow.
2774 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2775 (Frequire):
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (larger_vector): New API (vec, incr_min, size_max) replaces old
2778 one (vec, new_size, init). This catches size overflow.
2779 INIT was removed because it was always Qnil.
2780 All callers changed.
2781 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2782 the upper bound on a hash table index size.
2783 (make_hash_table, maybe_resize_hash_table): Use it.
2784 (secure_hash): Computer start_byte and end_byte only after
2785 they're known to be in ptrdiff_t range.
2786 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2787 (Ffont_get_glyphs, Ffont_at):
2788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2789 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2790 (Flist_fonts, Fopen_font):
2791 Don't assume fixnum can fit in int.
2792 (check_gstring): Don't assume index can fit in int.
2793 (font_match_p): Check that fixnum is a character, not a nonnegative
2794 fixnum, since the later code needs to stuff it into an int.
2795 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2796 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2797 conversion overflow issues.
2798 (Fopen_font): Check for integer out of range.
2799 (Ffont_get_glyphs): Don't assume index can fit in int.
2800 * font.h: Adjust decls to match defn changes elsewhere.
2801 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2802 integer overflow.
2803 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2804 printmax_t, where ptrdiff_t is wide enough.
2805 (Finternal_char_font):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2808 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2809 (Fset_frame_position, x_set_frame_parameters)
2810 (x_set_line_spacing, x_set_border_width)
2811 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2812 Check that fixnums are in proper range for system types.
2813 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2815 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2816 Use SAFE_ALLOCA_LISP, not alloca.
2817 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2818 intptr_t is wide enough.
2819 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2820 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2821 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2822 Check for fixnum out of range.
2823 * ftfont.c (ftfont_list): Don't assume index fits in int.
2824 Check that fixnums are in proper range for system types.
2825 (ftfont_shape_by_flt):
2826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2827 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2829 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2830 Check that fixnums are in proper range for system types.
2831 * gnutls.h: Adjust decls to match defn changes elsewhere.
2832 * gtkutil.c (xg_dialog_run):
2833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2834 (update_frame_tool_bar):
2835 Check that fixnums are in proper range for system types.
2836 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2837 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2838 * indent.c (last_known_column, last_known_column_point):
2839 (current_column_bol_cache):
2840 (skip_invisible, current_column, check_display_width):
2841 (check_display_width, scan_for_column, current_column_1)
2842 (Findent_to, Fcurrent_indentation, position_indentation)
2843 (indented_beyond_p, Fmove_to_column, compute_motion):
2844 (Fcompute_motion, Fvertical_motion):
2845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2846 (last_known_column_modified): Use EMACS_INT, not int.
2847 (check_display_width):
2848 (Fcompute_motion):
2849 Check that fixnums and floats are in proper range for system types.
2850 (compute_motion): Don't assume index or fixnum fits in int.
2851 (compute_motion, Fcompute_motion):
2852 Use int, not EMACS_INT, when it is wide enough.
2853 (vmotion): Omit local var start_hpos that is always 0; that way
2854 we don't need to worry about overflow in expressions involving it.
2855 * indent.h: Adjust decls to match defn changes elsewhere.
2856 (struct position):
2857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2858 Use int, not EMACS_INT, where int is wide enough.
2859 Remove unused members ovstring_chars_done and tab_offset;
2860 all uses removed.
2861 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2862 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2863 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2864 (make_gap, copy_text, insert, insert_and_inherit)
2865 (insert_before_markers, insert_before_markers_and_inherit)
2866 (insert_1, count_combining_before, count_combining_after)
2867 (insert_1_both, insert_from_string)
2868 (insert_from_string_before_markers, insert_from_string_1)
2869 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2870 (adjust_after_replace, adjust_after_insert, replace_range)
2871 (replace_range_2, del_range, del_range_1, del_range_byte)
2872 (del_range_both, del_range_2, modify_region)
2873 (prepare_to_modify_buffer, signal_before_change)
2874 (signal_after_change, Fcombine_after_change_execute):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2877 (balance_an_interval, split_interval_right, split_interval_left)
2878 (find_interval, next_interval, update_interval)
2879 (adjust_intervals_for_insertion, delete_node, delete_interval)
2880 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2881 (static_offset_intervals, offset_intervals)
2882 (merge_interval_right, merge_interval_left, make_new_interval)
2883 (graft_intervals_into_buffer, temp_set_point_both)
2884 (temp_set_point, set_point, adjust_for_invis_intang)
2885 (set_point_both, move_if_not_intangible, get_property_and_range)
2886 (get_local_map, copy_intervals, copy_intervals_to_string)
2887 (compare_string_intervals, set_intervals_multibyte_1):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2889 * intervals.h: Adjust decls to match defn changes elsewhere.
2890 (struct interval):
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2892 * keyboard.c (this_command_key_count, this_single_command_key_start)
2893 (before_command_key_count, before_command_echo_length, echo_now)
2894 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2895 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2896 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2897 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2899 (last_non_minibuf_size, last_point_position, echo_truncate)
2900 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2901 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2902 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2903 (stuff_buffered_input):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (last_auto_save, command_loop_1, read_char):
2906 Use EMACS_INT, not int, to avoid integer overflow.
2907 (record_char): Avoid overflow in total_keys computation.
2908 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2909 * keyboard.h: Adjust decls to match defn changes elsewhere.
2910 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2911 (Fkey_description, Fdescribe_vector, Flookup_key):
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 (click_position): New function, to check that positions are in range.
2914 (Fcurrent_active_maps):
2915 (describe_command):
2916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2917 (Faccessible_keymaps, Fkey_description):
2918 (preferred_sequence_p):
2919 Don't assume fixnum can fit into int.
2920 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2921 Check for integer overflow in size calculations.
2922 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2923 avoid mishandling large integers.
2924 * lisp.h: Adjust decls to match defn changes elsewhere.
2925 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2926 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2927 (struct Lisp_Marker):
2928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2929 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2930 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2931 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2932 All callers changed.
2933 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2934 Assume the arg has valid form, since it always does.
2935 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2936 unsigned integer system type.
2937 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2938 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2940 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2941 (duration_to_sec_usec): New decl.
2942 * lread.c (read_from_string_index, read_from_string_index_byte)
2943 (read_from_string_limit, readchar, unreadchar, openp)
2944 (read_internal_start, read1, oblookup):
2945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2946 (Fload, readevalloop, Feval_buffer, Feval_region):
2947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2948 (openp): Check for out-of-range argument to 'access'.
2949 (read1): Use int, not EMACS_INT, where int is wide enough.
2950 Don't assume fixnum fits into int.
6efdadfd 2951 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2952 (read_filtered_event): Use duration_to_sec_usec
2953 to do proper overflow checking on durations.
d311d28c
PE
2954 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2955 in size calculation.
2956 (Fexecute_kbd_macro):
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2959 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2960 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2961 (set_marker_both, set_marker_restricted_both, marker_position)
2962 (marker_byte_position, Fbuffer_has_markers_at):
2963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2964 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2965 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2966 It now merely ensures that the menu is large enough, without
2967 necessarily growing it, as this avoids some integer overflow issues.
2968 All callers changed.
2969 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2971 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2972 Use SAFE_ALLOCA_LISP, not alloca.
2973 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2974 to EMACS_INT. Check that fixnums are in proper range for system types.
2975 * minibuf.c (minibuf_prompt_width, string_to_object)
2976 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2977 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2979 (get_minibuffer, read_minibuf_unwind):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2982 this simplifies overflow checking. All callers changed.
2983 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2984 (Ftest_completion):
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2986 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2987 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2988 Check that fixnums are in proper range for system types.
2989 (Fx_create_frame, Fx_show_tip):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 * nsfont.m (ns_findfonts, nsfont_list_family):
2992 Don't assume fixnum fits in long.
2993 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2995 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2996 wide enough.
17fdb222 2997 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2999 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3000 (PRINTDECLARE, PRINTPREPARE):
3001 (strout, print_string):
3002 (print, print_preprocess, print_check_string_charset_prop)
3003 (print_object):
3004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3005 (PRINTDECLARE):
3006 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3008 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3009 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3010 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3011 (print_error_message): Use SAFE_ALLOCA, not alloca.
3012 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3013 (print_depth, new_backquote_output, print_number_index):
3014 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3015 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3016 (Fset_process_window_size, Fformat_network_address)
3017 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3018 (sigchld_handler):
d311d28c 3019 Check that fixnums are in proper range for system types.
d44287d4 3020 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3021 Check for process-ids out of pid_t range rather than relying on
3022 undefined behavior.
e4d81efc 3023 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3024 (Fformat_network_address, read_process_output, send_process)
3025 (Fprocess_send_region, status_notify):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3028 (wait_reading_process_output, read_process_output, exec_sentinel):
3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3030 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3031 (Faccept_process_output): Use duration_to_sec_usec to do proper
3032 overflow checking on durations.
dde14581
PE
3033 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3034 Don't assume pid_t fits in int.
02481186
PE
3035 * process.h (struct Lisp_Process): Members tick and update_tick
3036 are now of type EMACS_INT, not int.
b62b53e8
PE
3037 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3038 configured --with-wide-int.
d311d28c
PE
3039 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3040 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3041 * search.c (looking_at_1, string_match_1):
3042 (fast_string_match, fast_c_string_match_ignore_case)
3043 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3044 (scan_newline, find_before_next_newline, search_command)
3045 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3046 (set_search_regs, wordify):
3047 (Freplace_match):
3048 (Fmatch_data):
3049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3050 (string_match_1, search_buffer, set_search_regs):
3051 (Fmatch_data):
3052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3053 (wordify): Check for overflow in size calculation.
3054 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3055 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3056 Check that fixnums are in proper range for system types.
3057 * sound.c (struct sound_device)
3058 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3060 (Fplay_sound_internal):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3062 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3063 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3064 (Fparse_partial_sexp):
3065 Don't assume fixnums can fit in int.
3066 (struct lisp_parse_state, find_start_pos, find_start_value)
3067 (find_start_value_byte, find_start_begv)
3068 (update_syntax_table, char_quoted, dec_bytepos)
3069 (find_defun_start, prev_char_comend_first, back_comment):
3070 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3071 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (Finternal_describe_syntax_value): Check that match_lisp is a
3074 character, not an integer, since the code stuffs it into int.
3075 (scan_words, scan_sexps_forward):
3076 Check that fixnums are in proper range for system types.
3077 (Fforward_word):
3078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3079 (scan_sexps_forward):
3080 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3081 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3082 * syntax.h: Adjust decls to match defn changes elsewhere.
3083 (struct gl_state_s):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3085 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3086 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3087 * sysdep.c (wait_for_termination_1, wait_for_termination)
3088 (interruptible_wait_for_termination, mkdir):
3089 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3090 (emacs_read, emacs_write):
3091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3092 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3093 and double all fit in int.
d311d28c
PE
3094 * term.c (set_tty_color_mode):
3095 Check that fixnums are in proper range for system types.
3096 * termhooks.h (struct input_event):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3098 * textprop.c (validate_interval_range, interval_of)
3099 (Fadd_text_properties, set_text_properties_1)
3100 (Fremove_text_properties, Fremove_list_of_text_properties)
3101 (Ftext_property_any, Ftext_property_not_all)
3102 (copy_text_properties, text_property_list, extend_property_ranges)
3103 (verify_interval_modification):
3104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3105 (Fnext_single_char_property_change)
3106 (Fprevious_single_char_property_change):
3107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3108 (copy_text_properties):
3109 Check for integer overflow in index calculation.
d311d28c
PE
3110 * undo.c (last_boundary_position, record_point, record_insert)
3111 (record_delete, record_marker_adjustment, record_change)
3112 (record_property_change):
3113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3114 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3116 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3117 (Fx_hide_tip, Fx_file_dialog):
3118 * w32menu.c (set_frame_menubar):
3119 Use ptrdiff_t, not int, for consistency with rest of code.
3120 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3121 (select_window, Fdelete_other_windows_internal)
3122 (window_scroll_pixel_based, window_scroll_line_based)
3123 (Frecenter, Fset_window_configuration):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 (Fset_window_hscroll, run_window_configuration_change_hook)
3126 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3127 (Fscroll_other_window, Frecenter):
d311d28c
PE
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3130 Don't assume fixnum fits in int.
3131 (Fset_window_scroll_bars):
3132 Check that fixnums are in proper range for system types.
3133 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3134 (string_pos, c_string_pos, number_of_chars, init_iterator)
3135 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3136 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3137 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3138 (face_before_or_after_it_pos, handle_invisible_prop)
3139 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3140 (display_prop_intangible_p, string_buffer_position_lim)
3141 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3142 (get_overlay_strings_1, get_overlay_strings)
3143 (iterate_out_of_display_property, forward_to_next_line_start)
3144 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3145 (get_next_display_element, set_iterator_to_next)
3146 (get_visually_first_element, compute_stop_pos_backwards)
3147 (handle_stop_backwards, next_element_from_buffer)
3148 (move_it_in_display_line_to, move_it_in_display_line)
3149 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3150 (add_to_log, message_dolog, message_log_check_duplicate)
3151 (message2, message2_nolog, message3, message3_nolog
3152 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3153 (current_message_1, truncate_echo_area, truncate_message_1)
3154 (set_message, set_message_1, store_mode_line_noprop)
3155 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3156 (text_outside_line_unchanged_p, check_point_in_composition)
3157 (reconsider_clip_changes)
3158 (redisplay_internal, set_cursor_from_row, try_scrolling)
3159 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3160 (redisplay_window, find_last_unchanged_at_beg_row)
3161 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3162 (trailing_whitespace_p, find_row_edges, display_line)
3163 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3164 (display_mode_element, store_mode_line_string)
3165 (pint2str, pint2hrstr, decode_mode_spec)
3166 (display_count_lines, display_string, draw_glyphs)
3167 (x_produce_glyphs, x_insert_glyphs)
3168 (rows_from_pos_range, mouse_face_from_buffer_pos)
3169 (fast_find_string_pos, mouse_face_from_string_pos)
3170 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3172 (safe_call, init_from_display_pos, handle_fontified_prop)
3173 (handle_single_display_spec, load_overlay_strings)
3174 (with_echo_area_buffer, setup_echo_area_for_printing)
3175 (display_echo_area, echo_area_display)
3176 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3177 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3178 (redisplay_window, dump_glyph_row, display_mode_line)
3179 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3180 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3182 (handle_single_display_spec, build_desired_tool_bar_string)
3183 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3184 (get_specified_cursor_type):
3185 Check that fixnums are in proper range for system types.
3186 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3187 (Flookup_image_map):
3188 Don't assume fixnums fit in int.
3189 (compare_overlay_entries):
3190 Avoid mishandling comparisons due to subtraction overflow.
3191 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3192 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3193 (handle_tool_bar_click):
3194 Use int, not unsigned, since we prefer signed and the signedness
3195 doesn't matter here.
3196 (get_next_display_element, next_element_from_display_vector):
3197 Use int, not EMACS_INT, when int is wide enough.
3198 (start_hourglass): Use duration_to_sec_usec to do proper
3199 overflow checking on durations.
3200 * xfaces.c (Fbitmap_spec_p):
3201 Check that fixnums are in proper range for system types.
3202 (compare_fonts_by_sort_order):
3203 Avoid mishandling comparisons due to subtraction overflow.
3204 (Fx_family_fonts, realize_basic_faces):
3205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3206 (Fx_family_fonts):
3207 Don't assume fixnum fits in int.
3208 Use SAFE_ALLOCA_LISP, not alloca.
3209 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3210 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3211 (face_at_buffer_position, face_for_overlay_string)
3212 (face_at_string_position):
3213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3214 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3215 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3216 (Fx_show_tip):
3217 Check that fixnums are in proper range for system types.
3218 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3219 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3221 (Fx_change_window_property): Don't assume fixnums fit in int.
3222 * xfont.c (xfont_chars_supported):
3223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3224 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3225 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3227 * xml.c (parse_region):
3228 * xrdb.c (magic_file_p):
3229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3230 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3231 (x_get_local_selection, x_reply_selection_request)
3232 (x_handle_selection_request, wait_for_property_change):
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3235 short is wide enough.
3236 (x_send_client_event): Don't assume fixnum fits in int.
3237 * xterm.c (x_x_to_emacs_modifiers):
3238 Don't assume EMACS_INT overflows nicely into int.
3239 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3240 may come from Lisp.
3241 (handle_one_xevent): NATNUMP can eval its arg twice.
3242 (x_connection_closed):
3243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3244 * xterm.h: Adjust decls to match defn changes elsewhere.
3245 (struct scroll_bar): Use struct vectorlike_header
3246 rather than rolling our own approximation.
3247 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3248
c6574eb5
GM
32492012-05-25 Glenn Morris <rgm@gnu.org>
3250
3251 * lisp.mk (lisp): Update for more files being compiled now.
3252
e8d32c7e
SM
32532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3254
48def666
SM
3255 * lread.c: Remove `read_pure' which makes no difference.
3256 (read_pure): Remove var.
3257 (unreadpure): Remove function.
3258 (readevalloop): Don't call read_list with -1 flag.
3259 (read1, read_vector): Don't test read_pure any more.
3260 (read_list): Simplify.
3261
e8d32c7e
SM
3262 * fileio.c, character.h: Minor style tweaks.
3263
4b2addb7
DA
32642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3265
3266 * window.h (clip_changed): Remove useless declaration.
3267
584461b2
JB
32682012-05-22 Juanma Barranquero <lekktu@gmail.com>
3269
3270 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3271 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3272
34374650
PE
32732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 Remove src/m/*.
3276 This directory predates autoconf and is no longer needed nowadays.
3277 Move its few remaining bits of functionality to where they're needed.
3278 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3279 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3280 * m/template.h: Remove.
3281 * Makefile.in (M_FILE): Remove. All uses removed.
3282 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3283 * lisp.h (USE_LSB_TAG):
3284 * mem-limits.h (EXCEEDS_LISP_PTR):
3285 Use VAL_MAX, not VALBITS, in #if.
3286 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3287 (EMACS_UINT): Define unconditionally now.
3288 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3289 (BITS_PER_EMACS_INT): New constants, replacing
3290 what used to be in config.h, but not useful in #if.
3291 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3292 define them any more.
3293 (VAL_MAX): New macro.
3294 (VALMASK): Use it.
3295 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3296 BITS_PER_EMACS_INT, in #if.
3297 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3298 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3299 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3300 * s/ms-w32.h (DATA_START):
3301 Move here from removed file m/intel386.h.
3302 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3303 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3304
261cb4bb
PE
33052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 Assume C89 or later.
3308 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3309 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3310 (xrealloc):
3311 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3312 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3313 * textprop.c, tparam.c (NULL): Remove.
3314 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3315 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3316 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3317 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3318 * xterm.c (input_signal_count): Assume volatile works.
3319
ff23cd9f
KB
33202012-05-21 Ken Brown <kbrown@cornell.edu>
3321
3322 * xgselect.c (xg_select): Fix first argument in call to 'select'
3323 (bug#11508).
3324
1b170bc6
KB
33252012-05-20 Ken Brown <kbrown@cornell.edu>
3326
3327 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3328 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3329
b2f4d39f
KB
33302012-05-19 Ken Brown <kbrown@cornell.edu>
3331
3332 * xfns.c (x_in_use): Remove `static' qualifier.
3333 * xterm.h (x_in_use): Declare.
3334 * xgselect.c: Include xterm.h.
3335 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3336 and `display_arg' (bug#9754).
3337
003fdae2
PE
33382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3339
9232a6d9
PE
3340 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3341
003fdae2
PE
3342 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3343 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3344
784b56e2
EZ
33452012-05-18 Eli Zaretskii <eliz@gnu.org>
3346
3347 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3348
3349 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3350 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3351
3352 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3353 reference to image_cache->refcount.
3354 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3355
a0a79cde
JL
33562012-05-17 Juri Linkov <juri@jurta.org>
3357
3358 * search.c (Fword_search_regexp, Fword_search_backward)
3359 (Fword_search_forward, Fword_search_backward_lax)
3360 (Fword_search_forward_lax): Move functions to isearch.el
3361 (bug#10145, bug#11381).
3362
b0572523
PE
33632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3366
9660f5fc
SM
33672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3368
3369 * lread.c (init_obarray): Declare Qt and Qnil as special.
3370
4374de83
GM
33712012-05-14 Glenn Morris <rgm@gnu.org>
3372
3373 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3374 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3375
dc44c39a
PE
33762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3377
078c97cb
PE
3378 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3379
dc44c39a
PE
3380 * unexaix.c: Port to more-recent AIX compilers.
3381 (report_error, report_error_1, make_hdr, copy_sym)
3382 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3383 Make arguments const char *, not char *, to avoid violations of C
3384 standard and to fix some AIX warnings reported by Gilles Pion.
3385
e18afed7 33862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3387
3388 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3389 already have overlays loaded.
3390 (handle_single_display_spec): Before returning without displaying
3391 fringe bitmap, synchronize the bidi iterator with the main display
3392 iterator, by calling iterate_out_of_display_property.
3393 (iterate_out_of_display_property): Detect buffer iteration by
3394 testing that it->string is a Lisp string.
3395 (get_next_display_element): When the current object is exhausted,
3396 and there's something on it->stack, call set_iterator_to_next to
3397 proceed with what's on the stack, instead of returning zero.
3398 (set_iterator_to_next): If called at the end of a Lisp string,
3399 proceed to consider_string_end without incrementing string
3400 position. Don't increment display vector index past the end of
3401 the display vector. (Bug#11417)
c8fb9dc6
EZ
3402 (pos_visible_p): Don't report a position visible when move_it_to
3403 stopped at the last line of window, which happens to be scanned
3404 backwards by the bidi iteration. (Bug#11464)
ac268e67 3405
e18afed7 34062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3407
3408 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3409 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3410 are on a TTY, and thus unable to display on the fringes.
3411 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3412 so we need to signal to the caller that this is a "replacing"
3413 display spec. This fixes display when the spec is invalid or we
3414 are on a TTY.
3415
e18afed7 34162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3417
3418 * unexaix.c (make_hdr): Fix typo in prototype.
3419 This bug broke the build on AIX. Problem reported by Gilles Pion.
3420
9d0a235a
MA
34212012-05-14 Michael Albinus <michael.albinus@gmx.de>
3422
3423 * keyboard.c (kbd_buffer_get_event): Read special events also in
3424 batch mode. (Bug#11415)
3425
9e6b06ed
GM
34262012-05-12 Glenn Morris <rgm@gnu.org>
3427
3428 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3429
c1a1d7a3
EZ
34302012-05-12 Eli Zaretskii <eliz@gnu.org>
3431
3432 * lisp.mk (lisp): Add newcomment.elc.
3433
3fe7cdc8
GM
34342012-05-12 Glenn Morris <rgm@gnu.org>
3435
3436 * Makefile.in (MKDIR_P): New, set by configure.
3437 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3438
53f7d2c0
PE
34392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Remove unused function hourglass_started.
3442 * dispextern.h (hourglass_started):
3443 * w32fns.c (hourglass_started):
3444 * xdisp.c (hourglass_started): Remove.
3445
75aafb17
JB
34462012-05-10 Juanma Barranquero <lekktu@gmail.com>
3447
3448 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3449 Update dependencies.
3450
12959e8e
PE
34512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3452
97107e2e
PE
3453 * xgselect.c (xg_select): Put maxfds+1 into a var.
3454 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3455
12959e8e
PE
3456 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3457
836d29b3
DA
34582012-05-10 Dave Abrahams <dave@boostpro.com>
3459
3460 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3461 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3462
5cb67954
MA
34632012-05-09 Michael Albinus <michael.albinus@gmx.de>
3464
3465 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3466 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3467 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3468 Initialize xd_registered_buses.
3469
3478ec45
PE
34702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3471
b263a6b0
PE
3472 Untag more efficiently if USE_LSB_TAG.
3473 This is based on a proposal by YAMAMOTO Mitsuharu in
3474 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3475 For an admittedly artificial (nth 8000 longlist) benchmark on
3476 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3477 Emacs's overall text size by 1%.
3478 * lisp.h (XUNTAG): New macro.
3479 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3480 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3481 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3482 * eval.c (Fautoload):
3483 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3484 * frame.h (XFRAME): Use XUNTAG.
3485
3478ec45
PE
3486 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3487 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3488 Remove unportable assumptions about print widths of types like
3489 dbus_uint32_t.
3490 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3491 intptr_t when converting between pointer and integer, to avoid GCC
3492 warnings about wrong width.
3493
666b903b 34942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3495
3496 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3497 stack for each reader_thread, instead of defaulting to 8MB
3498 determined by the linker. This avoids failures in creating
3499 subprocesses on Windows 7, see the discussion in this thread:
3500 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3501
b120cc17
JC
35022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3503
3504 Fix up display of the *Minibuf-0* buffer in the mini window.
3505 * keyboard.c (read_char): Don't clear the echo area if there's no
3506 message to clear.
3507 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3508 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3509
9a4b36f8
MA
35102012-05-07 Michael Albinus <michael.albinus@gmx.de>
3511
3512 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3513 batch mode.
3514
e5f9458f
CY
35152012-05-06 Chong Yidong <cyd@gnu.org>
3516
3517 * lisp.mk (lisp): Update.
3518
eceeb5fc 35192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3520
3521 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3522
71873e2b
SM
35232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3524
3525 * data.c (PUT_ERROR): New macro.
3526 (syms_of_data): Use it. Add new error type `user-error'.
3527 * undo.c (user_error): New function.
3528 (Fprimitive_undo): Use it.
3529 * print.c (print_error_message): Adjust print style for `user-error'.
3530 * keyboard.c (user_error): New function.
3531 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3532
ab0fa4e4
PE
35332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 Do not limit current-time-string to years 1000..9999.
3536 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3537 (Fcurrent_time_string): Support any year that is supported by the
3538 underlying localtime representation. Don't use asctime, as it
3539 has undefined behavior for years outside the range -999..9999.
3540
7ed806a7
PE
35412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 Fix race conditions involving setenv, gmtime, localtime, asctime.
3544 Without this fix, interrupts could mess up code that uses these
3545 nonreentrant functions, since setting TZ invalidates existing
3546 tm_zone or tzname values, and since most of these functions return
3547 pointers to static storage.
3548 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3549 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3550 Grow the critical sections to include not just invoking
3551 localtime/gmtime, but also accessing these functions' results
3552 including their tm_zone values if any, and any related TZ setting.
3553 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3554 so that the struct tm is saved in the critical section.
3555 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3556 motivated by the fact that memory allocation needs to be outside
3557 the critical section.
3558
0c16dfed
DA
35592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3560
3561 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3562 with RESET_INTERVAL.
3563
3564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3565 Remove duplicated buffer name initialization.
3566
3f83ace8
JM
35672012-05-02 Jim Meyering <jim@meyering.net>
3568
3569 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3570
c7b8541e
JM
3571 * xfns.c (x_window): Use xstrdup (Bug#11375).
3572
90207a15 35732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3574
3575 * xdisp.c (pos_visible_p): If already at a newline from the
3576 display string before the 'while' loop, don't walk back the glyphs
3577 from it3.glyph_row. Solves assertion violation when the display
3578 string begins with a newline (egg.el). (Bug#11367)
3579
b593d6a9
AH
35802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3581
3582 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3583 Move to simple.el.
3584
4737362e
GM
35852012-05-01 Glenn Morris <rgm@gnu.org>
3586
99cf43f9
GM
3587 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3588 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3589 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3590 All were removed before 23.1.
3591
9311dcff
GM
3592 * dispnew.c: Remove HAVE_LIBNCURSES test;
3593 it is always true on relevant platforms.
3594
4d5c6349
GM
3595 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3596 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3597
4737362e
GM
3598 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3599
74dd3a6b
AS
36002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3601
3602 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3603 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3604 Remove.
3605
13c379ee
PE
36062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 Do not avoid creating empty evaporating overlays (Bug#9642).
3609 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3610 That is, do not delete an evaporating overlay if it becomes
3611 empty after its bounds are adjusted to fit within its buffer.
3612 This fix caused other problems, and I'm reverting it until we get
3613 to the bottom of them.
3614
a8e7d6d7 36152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3616
3617 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3618
a8e7d6d7 36192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3620
3621 * xdisp.c (pos_visible_p): If the window start position is beyond
3622 ZV, start the display from buffer beginning. Prevents assertion
3623 violation in init_iterator when the minibuffer window is scrolled
3624 via the scroll bar.
3625
3626 * window.c (window_scroll_pixel_based): Likewise.
3627
a8e7d6d7 36282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3629
3630 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3631
a8e7d6d7 36322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3633
3634 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3635 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3636
a8e7d6d7 36372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3638
b593d6a9
AH
3639 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3640 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3641
1c6900d9
EZ
36422012-04-26 Eli Zaretskii <eliz@gnu.org>
3643
4c3fa1d9
EZ
3644 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3645 display element, check also the underlying string or buffer
3646 character. (Bug#11341)
3647
1c6900d9
EZ
3648 * w32menu.c: Include w32heap.h.
3649 (add_menu_item): If the call to AppendMenuW (via
3650 unicode_append_menu) fails, disable Unicode menus only if we are
3651 running on Windows 9X/Me.
3652
42bf8205
AS
36532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3654
3655 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3656 (xgetint): Add missing shift for LSB tags.
3657
b1bac16e
MR
36582012-04-24 Martin Rudalics <rudalics@gmx.at>
3659
3660 * keyboard.c (read_char): Don't wipe echo area for select window
3661 events: These might get delayed via `mouse-autoselect-window'
3662 (Bug#11304).
3663
d69621cc
JB
36642012-04-24 Juanma Barranquero <lekktu@gmail.com>
3665
3666 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3667 manipulation of :loaded-from data.
3668
02fd101b
JB
36692012-04-23 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3672 now a cons (bug#11311).
3673
888bec30
PE
36742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3675
89a438bd
PE
3676 Do not create empty overlays with the evaporate property (Bug#9642).
3677 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3678 if it becomes empty after its bounds are adjusted to fit within
3679 its buffer. Without this fix, in a nonempty buffer (let ((o
3680 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3681 yields an empty overlay that has the evaporate property, which is
3682 not supposed to happen.
3683
1068fe4d
PE
3684 Fix minor GTK3 problems found by static checking.
3685 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3686 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3687 (struct _EmacsFixedClass, emacs_fixed_get_type):
3688 Move decls here from emacsgtkfixed.h, since they needn't be public.
3689 (emacs_fixed_get_type): Now static.
3690 (emacs_fixed_class_init): Omit unused local.
3691 (emacs_fixed_child_type): Remove; unused.
3692 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3693 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3694 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3695 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3696 (EMACS_FIXED_GET_CLASS): Remove; unused.
3697 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3698
888bec30
PE
3699 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3700 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3701
de85e130
PE
37022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3703
d0baac98 3704 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3705 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3706 (__malloc_size_t, __malloc_ptrdiff_t):
3707 Remove. All uses removed, replaced by the definiens if needed,
3708 since we can assume C89 or better now.
3709 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3710 (protect_malloc_state, align, get_contiguous_space)
3711 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3712 (malloc_atfork_handler_child, malloc_enable_thread)
3713 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3714 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3715 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3716 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3717 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3718 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3719 Define using prototypes, not old style.
3720 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3721 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3722 (align): Don't assume that signed integer overflow wraps around.
3723 Omit unused local var.
3724 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3725 (_free_internal_nolock, memalign, mallochook, reallochook):
3726 Omit no-longer-needed casts.
3727 (valloc): Use getpagesize, not __getpagesize.
3728 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3729 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3730
de85e130
PE
3731 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3732
dcbf5805
MA
37332012-04-22 Michael Albinus <michael.albinus@gmx.de>
3734
3735 Move functions from C to Lisp. Make non-blocking method calls
3736 the default. Implement further D-Bus standard interfaces.
3737
3738 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3739 (QCdbus_request_name_allow_replacement)
3740 (QCdbus_request_name_replace_existing)
3741 (QCdbus_request_name_do_not_queue)
3742 (QCdbus_request_name_reply_primary_owner)
3743 (QCdbus_request_name_reply_in_queue)
3744 (QCdbus_request_name_reply_exists)
3745 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3746 (QCdbus_registered_serial, QCdbus_registered_method)
3747 (QCdbus_registered_signal): New Lisp objects.
3748 (XD_DEBUG_MESSAGE): Use sizeof.
3749 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3750 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3751 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3752 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3753 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3754 (xd_signature, xd_append_arg): Allow float for integer types.
3755 (xd_get_connection_references): New function.
b593d6a9
AH
3756 (xd_get_connection_address): Rename from xd_initialize.
3757 Return cached address.
dcbf5805
MA
3758 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3759 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3760 level.
3761 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3762 Return number of refcounts.
dcbf5805
MA
3763 (Fdbus_get_unique_name): Make stronger parameter check.
3764 (Fdbus_message_internal): New defun.
3765 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3766 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3767 (Fdbus_send_signal, Fdbus_register_service)
3768 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3769 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3770 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3771 (Vdbus_compiled_version, Vdbus_runtime_version)
3772 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3773 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3774 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3775 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3776 Adapt docstring.
dcbf5805 3777
52828e02
PE
37782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3779
da05bc4c
PE
3780 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3781 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3782 Do not assume ptrdiff_t is the same width as 'int'.
3783
52828e02
PE
3784 * alloc.c: Handle unusual debugging option combinations.
3785 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3786 since the two debugging options are incompatible.
3787 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3788 is defined.
3789 (mem_init, mem_insert, mem_insert_fixup):
3790 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3791 (NEED_MEM_INSERT): Remove; no longer needed.
3792
f01769f9
LL
37932012-04-22 Leo Liu <sdl.web@gmail.com>
3794
3795 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3796
5790543d
PE
37972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 * sysdep.c [__FreeBSD__]: Minor cleanups.
3800 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3801 Use Emacs indenting style more consistently. Avoid some casts.
3802 Use 'double' consistently rather than mixing 'float' and 'double'.
3803
b91b7e4d
EW
38042012-04-21 Eduard Wiebe <usenet@pusto.de>
3805
b593d6a9
AH
3806 * sysdep.c (list_system_processes, system_process_attributes):
3807 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3808
6114eb15
AS
38092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3810
3811 * lisp.mk (lisp): Update.
3812
2f38dff7
PE
38132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3814
3815 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3816 It is never used otherwise.
3817
4ae29f89
SM
38182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3819
3820 * print.c (print_preprocess): Only check print_depth if print-circle
3821 is nil.
3822 (print_object): Check for cycles even when print-circle is nil and
3823 print-gensym is t, but only check print_depth if print-circle is nil.
3824
f30d612a
CY
38252012-04-20 Chong Yidong <cyd@gnu.org>
3826
3827 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3828 set the status to "failed" and ensure that sentinel is run.
3829
c07a4c0b 38302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3831
3832 * process.c (Fset_process_inherit_coding_system_flag)
3833 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3834 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3835
c07a4c0b 38362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3837
3838 * xdisp.c (string_buffer_position_lim): Limit starting position to
3839 BEGV.
3840 (set_cursor_from_row): If called for a mode-line or header-line
3841 row, return zero immediately.
3842 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3843 farther than the first row after the header line, if any.
3844 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3845 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3846
c07a4c0b 38472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3848
4ae29f89
SM
3849 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3850 (bug#11238).
ad3a2b41 3851
c07a4c0b 38522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 38532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3854
3855 configure: new option --enable-gcc-warnings (Bug#11207)
3856 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3857 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3858 (ALL_CFLAGS): Use new macros rather than old.
3859 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3860 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3861 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3862 -Wunused-result, -Wunused-variable. This should go away once
3863 the Emacs and Gnulib regex code is merged.
3864 (xmalloc, xrealloc): Now static.
3865
aba027e8
PE
38662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3867
3868 * dired.c (Fsystem_groups): Remove unused local.
3869
e5a36063
GM
38702012-04-17 Glenn Morris <rgm@gnu.org>
3871
3872 * dired.c (Fsystem_users): Doc fix.
3873
316411f0
DA
38742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3875
3876 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3877 (syms_of_dired): Add them.
3878
9426aba4
PE
38792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3880
b62a57be
PE
3881 Fix minor alloc.c problems found by static checking.
3882 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3883 New extern decls, to avoid calling undeclared functions.
3884 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3885 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3886 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3887 (NEED_MEM_INSERT): New macro.
3888 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3889 Remove one incorrect comment and fix another.
b62a57be 3890
3539f31f
PE
3891 Fix minor ralloc.c problems found by static checking.
3892 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3893 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3894 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3895 (r_alloc_sbrk): Now static.
3896
a041960a
PE
3897 Improve ralloc.c interface checking.
3898 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3899 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3900 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3901 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3902 [REL_ALLOC]: ... to here, to check interface.
3903 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3904 Remove decls. This fixes an "It stinks!".
3905
9426aba4
PE
3906 * alloc.c (which_symbols): Fix alignment issue / type clash.
3907
d55c12ed
AS
39082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3909
3910 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3911 (struct Lisp_Misc_Any): Likewise.
3912 (struct Lisp_Free): Likewise.
3913 * alloc.c (union aligned_Lisp_Symbol): Define.
3914 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3915 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3916 (union aligned_Lisp_Misc): Define.
3917 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3918 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3919 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3920
b948ce8b
PE
39212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3924 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3925 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3926 * s/netbsd.h, s/sol2-6.h:
3927 Remove definition of GC_MARK_STACK, since the default now works.
3928 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3929 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3930 no longer the default.
3931 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3932
35dc09a1 39332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3934
35dc09a1
GM
3935 * lread.c (lisp_file_lexically_bound_p):
3936 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3937
35dc09a1
GM
39382012-04-14 Eli Zaretskii <eliz@gnu.org>
3939
3940 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3941 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3942
39432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3944
3945 * nsterm.m (constrainFrameRect): Always constrain when there is only
3946 one screen (Bug#10962).
3947
bcd86815
KB
39482012-04-13 Ken Brown <kbrown@cornell.edu>
3949
3950 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3951
c25df26e
RT
39522012-04-13 Reuben Thomas <rrt@sc3d.org>
3953
3954 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3955
0fc59f1e
DC
39562012-04-11 Daniel Colascione <dancol@dancol.org>
3957
3958 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3959 against is gone. It's better to use vfork now so that when Cygwin
3960 gains a new, working vfork, we use it automatically (bug#10398).
3961
de8c03dc
SM
39622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3963
3964 * window.c (save_window_save): Obey window-point-insertion-type.
3965
2f097256
GM
39662012-04-11 Glenn Morris <rgm@gnu.org>
3967
3968 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3969
453b951e
SM
39702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3971
3972 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3973
75f1671a 39742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3975
3976 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3977 (force_quit_count): New var.
3978 (handle_interrupt): Use it.
3979
2a8ce227
JB
39802012-04-10 Juanma Barranquero <lekktu@gmail.com>
3981
3982 * w32.c (w32_delayed_load): Record the full path of the library
3983 being loaded (bug#10424).
3984
935396c0
GM
39852012-04-09 Glenn Morris <rgm@gnu.org>
3986
05920a43
GM
3987 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3988 not just in the obarray, before snarfing them. (Bug#11036)
3989
935396c0
GM
3990 * Makefile.in ($(leimdir)/leim-list.el):
3991 Pass EMACS rather than BUILT_EMACS.
3992
a18ecafa
TZ
39932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3994
3995 * process.c (make_process):
3996 * process.h: Add integer `gnutls_handshakes_tried' member to
3997 process struct.
3998
6bbef4e5
JC
3999 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4000 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4001
4002 * gnutls.c (gnutls_log_function2i): Convenience log function.
4003 (emacs_gnutls_read): Use new log functions,
4004 `gnutls_handshakes_tried' process member, and
4005 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4006 attempts per process (connection).
4007
b4d3bc10
CY
40082012-04-09 Chong Yidong <cyd@gnu.org>
4009
4010 * eval.c (Fuser_variable_p, user_variable_p_eh)
4011 (lisp_indirect_variable): Functions deleted.
4012 (Fdefvar): Caller changed.
4013
4014 * callint.c (Finteractive, Fcall_interactively):
4015 * minibuf.c (Fread_variable): Callers changed.
4016
70f4d973
EZ
40172012-04-09 Eli Zaretskii <eliz@gnu.org>
4018
4019 * xdisp.c (set_cursor_from_row): If the display string appears in
4020 the buffer at position that is closer to point than the position
4021 after the display string, display the cursor on the first glyph of
4022 the display string. Fixes cursor display when a 'display' text
4023 property immediately follows invisible text. (Bug#11094)
4024
cb3c2e3e
PE
40252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 composite.c: use 'double' consistently
4028 * composite.c (get_composition_id): Use 'double' consistently
4029 instead of converting 'float' to 'double' and vice versa; this is
4030 easier to understand and avoids a GCC warning.
4031
fd06db5d
GM
40322012-04-09 Glenn Morris <rgm@gnu.org>
4033
50fe702a
GM
4034 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4035 preparation for dumping it with emacs. (Bug#4789)
4036 (leimdir): New variable.
4037 ($(leimdir)/leim-list.el): New rule.
4038 (emacs$(EXEEXT)): Depend on leim-list.el.
4039
fd06db5d
GM
4040 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4041 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4042 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4043
55c131ee
AS
40442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4045
4046 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4047 proper alignment.
4048
9209588f
JB
40492012-04-07 Juanma Barranquero <lekktu@gmail.com>
4050
4051 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4052 Remove unused local variable.
4053
e3fb2efb
PE
40542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4055
4056 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4057 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4058 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4059 objects, as mark_maybe_pointer will catch them otherwise.
4060 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4061 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4062
b5385551
PE
40632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 Fix typo that broke non-Windows builds.
4066 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4067
9078ead6
EZ
40682012-04-07 Eli Zaretskii <eliz@gnu.org>
4069
4070 Support building on MS-Windows with libxml2.
4071
4072 * makefile.w32-in (OBJ2): Add xml.$(O).
4073 (GLOBAL_SOURCES): Add xml.c.
4074 ($(BLD)/xml.$(O)): New dependency list.
4075
4076 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4077 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4078 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4079 [!WINDOWSNT]: New macros.
4080 (init_libxml2_functions, libxml2_loaded_p): New functions.
4081 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4082 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4083 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4084 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4085 linked in).
6bbef4e5
JC
4086 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4087 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4088 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4089
4090 * emacs.c: Don't include libxml/parser.h.
4091 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4092 xmlCleanupParser directly.
4093
4094 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4095
3811fdf3
EZ
40962012-04-07 Eli Zaretskii <eliz@gnu.org>
4097
4098 * indent.c (Fvertical_motion): If there is a display string at
4099 point, use it.vpos to compute how many lines to backtrack after
4100 move_it_to point. (Bug#11133)
4101
2f8e16b2
EZ
41022012-04-06 Eli Zaretskii <eliz@gnu.org>
4103
4104 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4105 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4106 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4107 macros related to unification of CJK characters. For the details,
4108 see the discussion following the message here:
4109 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4110
3d439cd1
CY
41112012-04-04 Chong Yidong <cyd@gnu.org>
4112
4113 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4114
8bc53d00
EZ
41152012-04-01 Eli Zaretskii <eliz@gnu.org>
4116
4117 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4118 instead of alloca. (Bug#11138)
4119
3b0512a3
AS
41202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4121
4122 * w32menu.c (is_simple_dialog): Properly check lisp types.
4123 (Bug#11141)
4124
8427ddd2
EZ
41252012-03-31 Eli Zaretskii <eliz@gnu.org>
4126
979022ef
EZ
4127 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4128 position we get to after a call to move_it_to fails the
4129 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4130 only if we wind up in a string from display property. (Bug#11063)
4131
a6b1c7cc
EZ
4132 * window.c (Fdelete_other_windows_internal): Invalidate the row
4133 and column information about mouse highlight, so that redisplay
4134 restores it after reallocating the glyph matrices. (Bug#7464)
4135
8427ddd2
EZ
4136 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4137 string comes from a `display' text property, use the buffer
4138 position of that property as if we actually saw that position in
4139 the row's glyphs.
697ba24b
EZ
4140 (move_it_by_lines): Remove the assertion that
4141 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4142 violated when there's a before-string at the beginning of a line.
4143 (Bug#11063)
8427ddd2 4144
65a0a738
EZ
41452012-03-30 Eli Zaretskii <eliz@gnu.org>
4146
4147 * xdisp.c (append_space_for_newline): If the default face was
4148 remapped, use the remapped face for the appended newline.
4149 (extend_face_to_end_of_line): Use the remapped default face for
4150 extending the face to the end of the line.
4151 (display_line): Call extend_face_to_end_of_line when the default
4152 face was remapped. (Bug#11068)
4153
581355cc
EZ
41542012-03-29 Eli Zaretskii <eliz@gnu.org>
4155
4156 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4157
e8fc049f
SM
41582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4161
4fb9a543
GM
41622012-03-27 Glenn Morris <rgm@gnu.org>
4163
4164 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4165 Doc fixes.
4166
679910f1
KH
41672012-03-26 Kenichi Handa <handa@m17n.org>
4168
4169 * dispextern.h (struct glyph): Fix previous change. Change the
4170 bit length of glyphless.ch to 25 (Bug#11082).
4171
90d49b7f
CY
41722012-03-26 Chong Yidong <cyd@gnu.org>
4173
4174 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4175 (command_loop_1): Use it; inhibit selection update for
4176 handle-select-window too (Bug#8996).
4177
f514f6f0
FP
41782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4179
e8fc049f 4180 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4181
bf43fa51
KH
41822012-03-25 Kenichi Handa <handa@m17n.org>
4183
4184 * dispextern.h (struct glyph): Change the bit length of
4185 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4186
8a0c01dd
EZ
41872012-03-24 Eli Zaretskii <eliz@gnu.org>
4188
4189 * s/ms-w32.h (tzname): Include time.h before redirecting to
4190 _tzname. Fixes the MSVC build. (Bug#9960)
4191
7d1c3a76
AS
41922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4193
8ed79523
AS
4194 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4195 characters.
4196
7d1c3a76
AS
4197 * xterm.c (XTread_socket): Only modify handling_signal if
4198 !SYNC_INPUT. (Bug#11080)
4199
e99a9b8b
EZ
42002012-03-23 Eli Zaretskii <eliz@gnu.org>
4201
4202 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4203 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4204 when fetching a multibyte character consumes more bytes than
4205 CHAR_BYTES returns, due to unification of CJK characters in
4206 string_char. (Bug#11073)
4207
5063c0e1
TN
42082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4209
4210 * process.c (wait_reading_process_output): Handle pty disconnect
4211 by refraining from sending oneself a SIGCHLD (bug#10933).
4212
9f851fbd
CY
42132012-03-22 Chong Yidong <cyd@gnu.org>
4214
4215 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4216
5063c0e1 4217 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4218 Mark string as coming from a prefix property.
4219 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4220 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4221
fb5b8aca
CY
42222012-03-21 Chong Yidong <cyd@gnu.org>
4223
4224 * xfaces.c (Vface_remapping_alist): Doc fix.
4225
62356a1b
EZ
42262012-03-20 Eli Zaretskii <eliz@gnu.org>
4227
4228 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4229 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4230 Doc fixes.
62356a1b 4231
025de85b
CY
42322012-03-20 Chong Yidong <cyd@gnu.org>
4233
4234 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4235 to reflect default non-nil value of redisplay-dont-pause.
4236
4827f94e
KH
42372012-03-19 Kenichi Handa <handa@m17n.org>
4238
4239 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4240 it fit in a valid range (Bug#11003).
4241
e50a24a2
EZ
42422012-03-18 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4245 that is not from display property, accept the row as a "cursor
4246 row" if one of the string's character has a non-nil `cursor'
4247 property. Fixes cursor positioning when there are newlines in
4248 overlay strings, e.g. in icomplete.el. (Bug#11035)
4249
9af5ed87
PE
42502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4253
d1f55f16
CY
42542012-03-12 Chong Yidong <cyd@gnu.org>
4255
4256 * eval.c (inhibit_lisp_code): Rename from
4257 inhibit_window_configuration_change_hook; move from window.c.
4258
4259 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4260 * window.c (run_window_configuration_change_hook)
4261 (syms_of_window): Callers changed.
4262
66c5eebd
CY
42632012-03-11 Chong Yidong <cyd@gnu.org>
4264
413df973
CY
4265 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4266
66c5eebd
CY
4267 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4268
1de11f56
CY
42692012-03-10 Chong Yidong <cyd@gnu.org>
4270
4271 * frame.c (other_visible_frames): Don't assume the selected frame
4272 is visible (Bug#10955).
4273
cae07000
SM
42742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4277
89c94350
JD
42782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4279
4280 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4281 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4282 zero (Bug#10954).
4283
999dd333
GM
42842012-03-03 Glenn Morris <rgm@gnu.org>
4285
01a6dcc8 4286 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4287
de0100f2
EZ
42882012-03-02 Eli Zaretskii <eliz@gnu.org>
4289
4290 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4291 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4292 (redisplay_window, next_element_from_string): Fix typos in
4293 comments.
3e441275
EZ
4294 (redisplay_window): Pass to move_it_vertically the margin in
4295 pixels, not in screen lines.
de0100f2 4296
96a72ee9
GM
42972012-03-02 Glenn Morris <rgm@gnu.org>
4298
4299 * buffer.c (buffer-list-update-hook): Doc fix.
4300
312508d7
EZ
43012012-02-29 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4304 push_it before setting up the iterator for the first overlay
4305 string, even if we have an empty string loaded.
4306 (next_overlay_string): If there's an empty string on the iterator
4307 stack, pop the stack. (Bug#10903)
4308
27f3c637
PE
43092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4312 Suggested by Stefan Monnier in
4313 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4314 * alloc.c (widen_to_Lisp_Object): New static function.
4315 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4316 and widening them to Lisp_Objects. This would work even if
4317 USE_LSB_TAG is defined and wide integers are used, which might
4318 happen in a future version of Emacs.
4319
3c9dfce6
CY
43202012-02-25 Chong Yidong <cyd@gnu.org>
4321
fa74b241
CY
4322 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4323 Doc fix.
4324
3c9dfce6
CY
4325 * xselect.c (Fx_selection_exists_p): Doc fix.
4326 (x_clipboard_manager_save_all): Print an informative message
4327 before saving to clipboard manager.
4328
9486df08
CY
43292012-02-24 Chong Yidong <cyd@gnu.org>
4330
4331 * keyboard.c (process_special_events): Handle all X selection
4332 requests in kbd_buffer, not just the next one (Bug#8869).
4333
f01d3321
CY
43342012-02-23 Chong Yidong <cyd@gnu.org>
4335
4336 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4337 call when setting menu-bar-lines and tool-bar-lines parameters.
4338 (unwind_create_frame_1): New helper function.
4339
4340 * window.c (inhibit_window_configuration_change_hook): New var.
4341 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4342 (syms_of_window): Initialize it.
f01d3321 4343
86b847b6
CY
43442012-02-22 Chong Yidong <cyd@gnu.org>
4345
4346 * xterm.c (x_draw_image_relief): Add missing type check for
4347 Vtool_bar_button_margin (Bug#10743).
4348
a59225b1
CY
43492012-02-21 Chong Yidong <cyd@gnu.org>
4350
4351 * fileio.c (Vfile_name_handler_alist): Doc fix.
4352
4353 * buffer.c (Fget_file_buffer): Protect against invalid file
4354 handler return value.
4355
310f5bd4
PE
43562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4357
cb3a28cc
PE
4358 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4359 when computing $valmask.
4360
310f5bd4
PE
4361 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4362 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4363 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4364 It's useless in that case, and it can cause problems on hosts
4365 that allocate halves of EMACS_INT values separately.
4366 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4367 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4368 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4369 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4370 it avoids undefined behavior on hosts where shifting right by more
4371 than the word width has undefined behavior.
4372
2375c96a
CY
43732012-02-19 Chong Yidong <cyd@gnu.org>
4374
4375 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4376 (Funhandled_file_name_directory, Ffile_name_as_directory)
4377 (Fdirectory_file_name, Fexpand_file_name)
4378 (Fsubstitute_in_file_name): Protect against invalid file handler
4379 return values (Bug#10845).
4380
3eb49e71
EZ
43812012-02-18 Eli Zaretskii <eliz@gnu.org>
4382
4383 * .gdbinit (pitx): Fix incorrect references to fields of the
4384 iterator stack.
4385
7b926f3f
CY
43862012-02-17 Chong Yidong <cyd@gnu.org>
4387
4388 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4389
11273115
PE
43902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4391
4392 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4393 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4394
c3a70e2b
CY
43952012-02-15 Chong Yidong <cyd@gnu.org>
4396
4397 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4398 marked as special. Also, starting docstrings with * is obsolete.
4399
0ca43699
AS
44002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4401
4402 * gnutls.c (emacs_gnutls_write): Fix last change.
4403
2e8f3c56
LI
44042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4405
4406 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4407 send_process.
4408
af70074f
SM
44092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4410
4411 * keymap.c (Fsingle_key_description): Handle char ranges.
4412
95986d52
CY
44132012-02-12 Chong Yidong <cyd@gnu.org>
4414
afd83bd1
CY
4415 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4416 as that creates a dangerous corner case.
4417
95986d52
CY
4418 * window.c (Fdelete_window_internal): Invalidate the mouse
4419 highlight (Bug#9904).
4420
bd7da63e
GM
44212012-02-12 Glenn Morris <rgm@gnu.org>
4422
4423 * xselect.c (Fx_own_selection_internal)
4424 (Fx_get_selection_internal, Fx_disown_selection_internal)
4425 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4426 * nsselect.m (Fx_own_selection_internal)
4427 (Fx_disown_selection_internal, Fx_selection_exists_p)
4428 (Fx_selection_owner_p, Fx_get_selection_internal):
4429 Sync docs and argument specs with the xselect.c versions.
4430
77abcbc2
LI
44312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4432
4433 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4434
90b671e2
EZ
44352012-02-11 Eli Zaretskii <eliz@gnu.org>
4436
1c0ca0b7
EZ
4437 * w32select.c (Fx_selection_exists_p): Sync doc string and
4438 argument list with xselect.c. (Bug#10783)
4439
4440 * w16select.c (Fx_selection_exists_p): Sync doc string and
4441 argument list with xselect.c. (Bug#10783)
90b671e2 4442
49241268
GM
44432012-02-10 Glenn Morris <rgm@gnu.org>
4444
4445 * fns.c (Fsecure_hash): Doc fix.
4446
f998bbe7 44472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4448
4449 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4450
0992bd9c
CY
44512012-02-07 Chong Yidong <cyd@gnu.org>
4452
4453 * buffer.c (Fbuffer_local_variables)
4454 (buffer_lisp_local_variables): Handle unbound vars correctly;
4455 don't let Qunbound leak into Lisp.
4456
af008560
GM
44572012-02-07 Glenn Morris <rgm@gnu.org>
4458
dd605cc4
GM
4459 * image.c (Fimagemagick_types): Doc fix.
4460
af008560
GM
4461 * image.c (imagemagick-render-type): Change it from a lisp object
4462 to an integer. Move the doc here from the lisp manual.
4463 Treat all values not equal to 0 the same.
4464
1449fa1d
CY
44652012-02-06 Chong Yidong <cyd@gnu.org>
4466
4467 * doc.c (store_function_docstring): Avoid applying docstring of
4468 alias to base function (Bug#2603).
4469
3723ec07
AS
44702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4471
4472 * .gdbinit (pp1, pv1): Remove redundant defines.
4473 (pr): Use pp.
4474
79c1cc1e
CY
44752012-02-04 Chong Yidong <cyd@gnu.org>
4476
4477 * nsterm.m: Declare a global (Bug#10694).
4478
d7f29f8e
EZ
44792012-02-04 Eli Zaretskii <eliz@gnu.org>
4480
cae07000
SM
4481 * w32.c (get_emacs_configuration_options):
4482 Include --enable-checking, if specified, in the return value.
d7f29f8e 4483
3b95a6f9
MR
44842012-02-04 Martin Rudalics <rudalics@gmx.at>
4485
4486 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4487 after rounding frame sizes. (Bug#9723)
4488
d6fa96a6
EZ
44892012-02-04 Eli Zaretskii <eliz@gnu.org>
4490
4491 * keyboard.c (adjust_point_for_property): Don't position point
4492 before BEGV. (Bug#10696)
4493
df0b2940
PE
44942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4495
4496 Handle overflow when computing char display width (Bug#9496).
4497 * character.c (char_width): Return EMACS_INT, not int.
4498 (char_width, c_string_width): Check for overflow when
4499 computing the width; this is possible now that individual
4500 characters can have unbounded width. Problem introduced
4501 by merge from Emacs 23 on 2012-01-19.
4502
6bee44d6
MA
45032012-02-02 Michael Albinus <michael.albinus@gmx.de>
4504
4505 * dbusbind.c (Fdbus_register_method): Mention the return value
4506 :ignore in the docstring.
4507
44f92739
GM
45082012-02-02 Glenn Morris <rgm@gnu.org>
4509
1b9f60cc
GM
4510 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4511
44f92739
GM
4512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4513 Unconditionally set to t. (Bug#10673)
4514 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4515 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4516 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4517
c5d3843c
KH
45182012-02-02 Kenichi Handa <handa@m17n.org>
4519
4520 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4521 0, do not call append_composite_glyph.
4522
159462d4 45232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4524
4525 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4526 NULL (Bug#6988).
4527 (x_produce_glyphs): If the component of a composition is a null
4528 string, set it->pixel_width to 1 to avoid zero-width glyph.
4529
78cef877
EZ
45302012-02-01 Eli Zaretskii <eliz@gnu.org>
4531
4532 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4533 first 2 arguments are identical. This makes inserting large
4534 output from a subprocess an order of magnitude faster on
4535 MS-Windows, where all sbrk'ed memory is always contiguous.
4536
97897668
GM
45372012-01-31 Glenn Morris <rgm@gnu.org>
4538
4539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4540 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4541 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4542
31fd3586
GM
45432012-01-29 Glenn Morris <rgm@gnu.org>
4544
4545 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4546
0e24a8b2
CY
45472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4548
4549 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4550
cc0adcb0
CY
45512012-01-28 Chong Yidong <cyd@gnu.org>
4552
4553 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4554
acc28cb9
CY
45552012-01-26 Chong Yidong <cyd@gnu.org>
4556
9c69cfb7
CY
4557 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4558
acc28cb9
CY
4559 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4560 repeat counts (Bug#10507).
4561
48da7392
GM
45622012-01-26 Glenn Morris <rgm@gnu.org>
4563
4564 * lread.c (syms_of_lread): Doc fix.
4565
14af5f7f
CY
45662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4567
4568 * coding.c (encode_designation_at_bol): Change return value to
4569 EMACS_INT.
4570
0b21c100
CY
45712012-01-25 Chong Yidong <cyd@gnu.org>
4572
4573 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4574
3c2907f7
CY
45752012-01-21 Chong Yidong <cyd@gnu.org>
4576
4577 * floatfns.c (Fcopysign): Make the second argument non-optional,
4578 since nil is not allowed anyway.
4579
959ad23f
AS
45802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4581
4582 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4583 (send_process): Likewise.
4584
34a02f46
MR
45852012-01-19 Martin Rudalics <rudalics@gmx.at>
4586
4587 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4588 (Vwindow_persistent_parameters): Do not use Qstate.
4589 Rewrite doc-strings.
34a02f46 4590
1259009a 45912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4592
4593 * character.c (char_width): New function.
70d4fdf6
GM
4594 (Fchar_width, c_string_width, lisp_string_width):
4595 Use char_width (Bug#9496).
25ed9e61 4596
6a6ee00d
MR
45972012-01-16 Martin Rudalics <rudalics@gmx.at>
4598
4599 * window.c (Vwindow_persistent_parameters): New variable.
4600 (Fset_window_configuration, save_window_save): Handle persistent
4601 window parameters.
4602
c85efaf7
EZ
46032012-01-14 Eli Zaretskii <eliz@gnu.org>
4604
4605 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4606 thrashing the stack of the thread. (Bug#9087)
4607
5944709e
PE
46082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4609
4610 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4611
e71f5d99
EZ
46122012-01-11 Eli Zaretskii <eliz@gnu.org>
4613
4614 * xdisp.c (rows_from_pos_range): Handle the case where the
4615 highlight ends on a newline. (Bug#10464)
4616 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4617 he end column for display of highlight that ends on a newline
4618 before a R2L line.
4619
ce316182
GM
46202012-01-11 Glenn Morris <rgm@gnu.org>
4621
4622 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4623 from load-path also when installation-directory is nil. (Bug#10208)
4624
5b43da69
GM
46252012-01-10 Glenn Morris <rgm@gnu.org>
4626
74cc8ff9
GM
4627 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4628
7d8d6e4e
GM
4629 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4630 Update template values to be closer to their typical values these days.
5b43da69 4631
a0db8d43
EZ
46322012-01-09 Eli Zaretskii <eliz@gnu.org>
4633
4634 * xdisp.c (rows_from_pos_range): Accept additional argument
4635 DISP_STRING, and accept any glyph in a row whose object is that
4636 string as eligible for mouse highlight. Fixes mouse highlight of
4637 display strings from overlays. (Bug#10464)
4638
9a0115ab 46392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4640
b9110d6a 4641 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4642 * fileio.c (auto_saving_dir_umask): New static var.
4643 (Fmake_directory_internal): Use it.
4644 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4645 creating the directory. The old code temporarily assigns
4646 too-generous permissions to the directory.
4647 (do_auto_save_eh): Clear it.
b9110d6a 4648 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4649 that the var is always cleared.
4650
6c1bd3f3
EZ
46512012-01-07 Eli Zaretskii <eliz@gnu.org>
4652
4653 * search.c (scan_buffer): Pass character positions to
4654 know_region_cache, not byte positions. (Bug#6540)
4655
069d2b50
L
46562012-01-07 LynX <_LynX@bk.ru> (tiny change)
4657
4658 * w32.c (sys_rename): Report EXDEV when rename of a directory
4659 fails because the target is on another logical disk. (Bug#10284)
4660
75bf0d33
DB
46612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4662
4663 * xterm.c (x_embed_request_focus): New function.
4664
4665 * xterm.h: Add prototype.
4666
4667 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4668
1c6e5a32
GM
46692012-01-05 Glenn Morris <rgm@gnu.org>
4670
4671 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4672
651e947e
EZ
46732012-01-01 Eli Zaretskii <eliz@gnu.org>
4674
4675 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4676 Load gnutls_transport_set_lowat only if GnuTLS version is below
4677 2.11.1.
4678 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4679 GnuTLS versions below 2.11.1.
4680
3778cdd8
AL
46812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4682
4683 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4684 to the doc string advising against its use for altering the way
4685 windows are scrolled.
4686
0e5317f7
KH
46872011-12-28 Kenichi Handa <handa@m17n.org>
4688
4689 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4690 coding-system ASCII compatible only when it does not produce BOM
4691 on encoding (Bug#10383).
4692
93d5ca1f
JD
46932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4694
4695 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4696 can scroll.
4697 (create_and_show_popup_menu): Always use menu_position_func for
4698 Gtk3 (Bug#10361).
4699
ca22b785
AS
47002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4701
4702 * callint.c (Fcall_interactively): Don't truncate prompt string.
4703
d048e1e6
EZ
47042011-12-23 Eli Zaretskii <eliz@gnu.org>
4705
4706 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4707 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4708 resumed from there (after widening). (Bug#10360)
d048e1e6 4709
5ccaba1f
JD
47102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4711
4712 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4713
204ee57f
JD
47142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4715
b81d40f0
JB
4716 * nsterm.m (x_free_frame_resources):
4717 Release f->output_data.ns->miniimage.
204ee57f
JD
4718 (ns_index_color): Fix indentation. Do not retain
4719 color_table->colors[i].
4720
4721 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4722 before returning.
4723
4724 * nsfns.m (x_set_background_color): Assign return value from
4725 ns_index_color to face-background instead of NSColor*.
4726 (ns_implicitly_set_icon_type): Fix indentation.
4727 Change assignment in for loop to comparison.
4728
4729 * emacs.c (ns_pool): New variable.
4730 (main): Assign ns_pool.
4731 (Fkill_emacs): Call ns_release_autorelease_pool.
4732
4733 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4734 autorelease fdesc, release fdAttrs and tdict.
4735 (ns_get_covering_families): Release charset.
4736 (ns_findfonts): Release NSFontDescriptor created with new.
4737 (ns_uni_to_glyphs): Fix indentation.
4738 (setString): Release attrStr before assigning new value.
4739
c803b2b7
JD
47402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4741
678f4426
JD
4742 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4743 and NS_IMPL_COCOA.
4744 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4745 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4746
cd394be1 47472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4748
5fecd5fc
JD
4749 * nsterm.m (ns_term_init): Subscribe for notifications
4750 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4751 to method trackingNotification in EmacsMenu.
4752
4753 * nsmenu.m (trackingMenu): New variable.
3771cb17 4754 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4755 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4756 from Aquamacs (Bug#7030).
678f4426
JD
4757
47582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4759
c803b2b7
JD
4760 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4761 (symbol_to_nsstring): Fix indentation.
4762 (ns_symbol_to_pb): New function.
cae07000
SM
4763 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4764 (Fns_rotate_cut_buffers_internal): Remove.
4765 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4766 Fns_store_cut_buffer_internal.
4767 (ns_get_foreign_selection, Fx_own_selection_internal)
4768 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4769 (Fns_get_selection_internal, Fns_store_selection_internal):
4770 Use ns_symbol_to_pb and check if return value is nil.
4771 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4772 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4773 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4774 renamed to Sns_store_selection_internal.
4775 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4776 and remove this function.
4777 (ns_handle_selection_clear): Remove, never used.
4778 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4779 here.
4780
e1b01a3a
KB
47812011-12-17 Ken Brown <kbrown@cornell.edu>
4782
4783 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4784 GID is unknown (Bug#10257).
4785
2adb6e85
PE
47862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4789 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4790 which caused a build failure on GNU/Linux IA-64. This problem was
4791 introduced by my 2011-10-07 patch.
4792
d1d7b339
JL
47932011-12-15 Juri Linkov <juri@jurta.org>
4794
4795 * image.c (imagemagick_error): New function. (Bug#10112)
4796 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4797 Use `imagemagick_error' where ImageMagick functions return
4798 `MagickFalse'.
4799 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4800 proper order.
4801
100d5755
KH
48022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4803
4804 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4805 fill background (Bug#8992).
4806
454592a6
MR
48072011-12-13 Martin Rudalics <rudalics@gmx.at>
4808
4809 * window.c (Vwindow_combination_resize)
4810 (Vwindow_combination_limit): Use t instead of non-nil in
4811 doc-strings.
61d4b438
MR
4812 (Vrecenter_redisplay): Add first sentence of doc-string on
4813 separate line.
53524d93 4814 (Frecenter): Fix doc-string typo.
454592a6 4815
3633e3aa
KH
48162011-12-11 Kenichi Handa <handa@m17n.org>
4817
4818 * coding.c (Funencodable_char_position): Pay attention to the
4819 buffer text relocation (Bug#9389).
4820
7b9d523a 48212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4822
7b9d523a
JD
4823 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4824 gtk_init (Bug#10100).
4825
b73189c6
EZ
48262011-12-10 Eli Zaretskii <eliz@gnu.org>
4827
4828 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4829 IT->string is nil. (Bug#10263)
4830
f7dfe5d6
JD
48312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4832
83faebb4
JD
4833 * nsterm.h (x_free_frame_resources): Declare.
4834
f7dfe5d6
JD
4835 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4836 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4837
4838 * nsterm.h (ns_get_defaults_value): Declare.
4839
4840 * nsterm.m (ns_default): Call ns_get_defaults_value.
4841
7cd4e72c
EZ
48422011-12-09 Eli Zaretskii <eliz@gnu.org>
4843
4844 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4845 (Bug#10170)
4846
b34d7317
YM
48472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4848
4849 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4850 that where the value of an _OBJC_* symbol points to is in the .bss
4851 section (Bug#10240).
4852
76470ad1
KH
48532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4854
4855 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4856 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4857
745fff94
KH
48582011-12-08 Kenichi Handa <handa@m17n.org>
4859
4860 * ftfont.c (get_adstyle_property): Fix previous change
4861 (Bug#10233).
4862
6e44397c
JB
48632011-12-07 Juanma Barranquero <lekktu@gmail.com>
4864
4865 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4866 dirs from the default value of EMACSLOADPATH (bug#10208).
4867
7efa6272
GM
48682011-12-07 Glenn Morris <rgm@gnu.org>
4869
4870 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4871 installation and source directories as well. (Bug#10208)
4872
f6fc4d87
CY
48732011-12-06 Chong Yidong <cyd@gnu.org>
4874
4875 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4876
2bf26180
GM
48772011-12-06 Glenn Morris <rgm@gnu.org>
4878
4879 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4880 as an error, not just -1. (Bug#10217)
4881
3a6ad4f0
CY
48822011-12-05 Chong Yidong <cyd@gnu.org>
4883
4884 * keyboard.c (process_special_events): New function.
4885 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4886
75a3b399
PE
48872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 * coding.c (encode_designation_at_bol): Don't use uninitialized
4890 local variable (Bug#9318).
4891
c3c9e25e
KH
48922011-12-05 Kenichi Handa <handa@m17n.org>
4893
4894 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4895 return Qnil (Bug#8046, Bug#10193).
4896
5eb05ea3
KH
48972011-12-05 Kenichi Handa <handa@m17n.org>
4898
4899 * coding.c (encode_designation_at_bol): New args charbuf_end and
4900 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4901 (coding_set_source): Return how many bytes coding->source was
4902 relocated.
4903 (coding_set_destination): Return how many bytes
4904 coding->destination was relocated.
4905 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4906 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4907
49082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4909
4910 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4911 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4912 macro (Bug#9318).
4913
49142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4915
4916 The following changes are to fix Bug#9318.
4917
a79703f5 4918 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4919 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4920 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4921 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4922
7dbda6df
JB
49232011-12-05 Juanma Barranquero <lekktu@gmail.com>
4924
4925 * lisp.h (process_quit_flag): Fix external declaration.
4926
6d5eb5b0
SM
49272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4928
4929 Don't macro-inline non-performance-critical code.
4930 * eval.c (process_quit_flag): New function.
4931 * lisp.h (QUIT): Use it.
4932
a0c3fad0
JD
49332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4934
4935 * nsfns.m (get_geometry_from_preferences): New function.
4936 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4937
6c07aac2
AS
49382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4939
4940 * emacs.c (Qkill_emacs): Define.
4941 (syms_of_emacs): Initialize it.
4942 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4943 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4944 (quit_throw_to_read_char): Add parameter `from_signal'.
4945 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4946 * lisp.h (QUIT): Call Fkill_emacs if requested.
4947
c052ead4
JD
49482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4949
4950 * widget.c (update_wm_hints): Return if wmshell is null.
4951 (widget_update_wm_size_hints): New function.
4952
4953 * widget.h (widget_update_wm_size_hints): Declare.
4954
4955 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4956 widget_update_wm_size_hints (Bug#10104).
4957
9e49252b
EZ
49582011-12-03 Eli Zaretskii <eliz@gnu.org>
4959
4960 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4961 before a newline, prepare the bidi iterator for consuming the
4962 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4963 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4964
02b16839
JL
49652011-12-02 Juri Linkov <juri@jurta.org>
4966
4967 * search.c (Fword_search_regexp): New Lisp function created from
4968 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4969 (Fword_search_backward, Fword_search_forward)
4970 (Fword_search_backward_lax, Fword_search_forward_lax):
4971 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4972 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4973
0068070e
SM
49742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4975
4976 * fileio.c (Finsert_file_contents): Move after-change-function call
4977 to before the "handled:" label, since all "goto handled" appear in
4978 cases where the *-change-functions have already been properly called
4979 (bug#10117).
4980
3360a3fc
AS
49812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4982
4983 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4984 waiting for input. (Bug#10169)
4985
73d6c093
EZ
49862011-11-30 Eli Zaretskii <eliz@gnu.org>
4987
4988 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4989 verifies glyph row's hash code--we have just reallocated the
4990 glyphs, so their contents can be complete garbage. (Bug#10164)
4991
febe6bea
JB
49922011-11-30 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4995
801a4313
EZ
49962011-11-30 Eli Zaretskii <eliz@gnu.org>
4997
4998 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4999 attributes are tested _before_ calling verify_row_hash, to protect
5000 against GCC re-ordering of the tests. (Bug#10164)
5001
2b56b87e
JD
50022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5003
5004 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5005
5006 * xterm.c (handle_one_xevent): Only set async_visible and friends
5007 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5008 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5009 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5010
dbf31225
PE
50112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5012
5013 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5014 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5015 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5016 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5017 All uses changed to use GCPRO1 etc.
5018 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5019 Revert to old implementation (i.e., before 2011-03-11).
5020
1305621b
YM
50212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5022
5023 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5024 of scroll runs so as to avoid assigning disabled bogus rows and
5025 unnecessary graphics copy operations.
5026
8c9afb46
EZ
50272011-11-27 Eli Zaretskii <eliz@gnu.org>
5028
5029 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5030 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5031 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5032 (malloc, free, realloc, calloc): Redirect to e_* only when
5033 compiling Emacs.
5034
5035 * lisp.h (GCTYPEBITS): Move before first use.
5036 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5037 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5038 this macro definition.
5039
5040 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5041 _MSC_VER.
5042
54e9e3bf
JD
50432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5044
6d5eb5b0
SM
5045 * gtkutil.c (xg_create_frame_widgets):
5046 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5047 present with Gtk+ 2.0.
5048
83aca1cb
PE
50492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5050
5051 * fileio.c (Finsert_file_contents): Undo previous change; see
5052 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5053
5b76caa4
PE
50542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 Rename locals to avoid shadowing.
5057 * fileio.c (Finsert_file_contents):
5058 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5059 * process.c (wait_reading_process_output):
5060 Rename inner 'proc' to 'p' to avoid shadowing.
5061 Indent for consistency with usual Emacs style.
5062
8c535114
EZ
50632011-11-25 Eli Zaretskii <eliz@gnu.org>
5064
5065 * xdisp.c (redisplay_window): If cursor row is not fully visible
5066 after recentering, and scroll-conservatively is set to a large
5067 number, scroll window by a few more lines to make the cursor fully
5068 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5069 (start_display): Don't move to the next line if the display should
5070 start at a newline that is part of a display vector or an overlay
5071 string. (Bug#10119)
8c535114 5072
fa4fdb5c
JL
50732011-11-24 Juri Linkov <juri@jurta.org>
5074
5075 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5076 after the `MagickPingImage' call. (Bug#10112)
5077
90ec88df
CY
50782011-11-23 Chong Yidong <cyd@gnu.org>
5079
5080 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5081
56e2e794
MR
50822011-11-23 Martin Rudalics <rudalics@gmx.at>
5083
5084 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5085 making another buffer current. (Bug#10114)
5086
b6e64c41
GM
50872011-11-23 Glenn Morris <rgm@gnu.org>
5088
5089 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5090
6b21de18
CY
50912011-11-23 Chong Yidong <cyd@gnu.org>
5092
5093 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5094 using it (Bug#5984).
5095
b12cd789
EZ
50962011-11-22 Eli Zaretskii <eliz@gnu.org>
5097
5098 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5099 and header-lines, as they don't have one computed for them.
5100 (Bug#10098)
5101
5102 * .gdbinit (prow): Make displayed values more self-explaining.
5103 Add row's hash code.
5104
261b6fd4
LMI
51052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5106
5107 * process.c (wait_reading_process_output): Fix asynchrounous
5108 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5109 (wait_reading_process_output): Add comment and URL.
261b6fd4 5110
e7cfd277
JD
51112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5112
5113 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5114
a9b9b7f5
CY
51152011-11-21 Chong Yidong <cyd@gnu.org>
5116
5117 * window.c (Fnext_window, Fprevious_window): Doc fix.
5118
b0d15b4f
SM
51192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5120
5121 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5122
fe7a3057
JB
51232011-11-20 Juanma Barranquero <lekktu@gmail.com>
5124
5125 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5126
d2999b1a
MR
51272011-11-20 Martin Rudalics <rudalics@gmx.at>
5128
5129 * window.c (Fset_window_combination_limit): Rename argument
5130 STATUS to LIMIT.
5131 (Vwindow_combination_limit): Remove "status" from doc-string.
5132
d5ff9cd0
AS
51332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5134
5135 * m/ibms390.h: Remove.
5136 * m/ibms390x.h: Don't include "ibms390.h".
5137
a5bb9bd3
SM
51382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5139
5140 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5141 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5142
cd1181db
JB
51432011-11-20 Juanma Barranquero <lekktu@gmail.com>
5144
5145 * casetab.c (Fset_case_table):
5146 * charset.c (Fcharset_after): Fix typos.
5147
615a3b8d 51482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5149
17e845af
PE
5150 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5151 Otherwise, valgrind does not work on some platforms.
5152 Problem reported by Andreas Schwab in
6a0bf43d
PE
5153 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5154 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5155 is set, removing the need for VIRT_ADDRESS_VARIES.
5156 (PURE_P): Use a more-efficient implementation that needs just one
5157 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5158 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5159 to 4 (xorl, subq, cmpq, setbe).
5160 * alloc.c (pure): Always extern now, since that's the
5161 VIRT_ADDR_VARIES behavior.
5162 (PURE_POINTER_P): Use a single comparison, not two, for
5163 consistency with the new puresize.h.
5164 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5165 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5166 Remove VIRT_ADDR_VARIES no longer needed.
5167
f8fe6f96
EZ
51682011-11-19 Eli Zaretskii <eliz@gnu.org>
5169
5170 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5171 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5172 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5173 behave as if the cursor position were at the window margin.
5174
5175 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5176 and the cursor position is out of bounds, behave as if the cursor
5177 position were at the window margin. (Bug#10075)
5178
df05a53c
CY
51792011-11-18 Chong Yidong <cyd@gnu.org>
5180
5181 * window.c (Fwindow_combination_limit): Make first argument
5182 non-optional, since it is meaningless for live windows like the
5183 selected window.
61ccba97 5184
2071918e
DA
51852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5186
5187 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5188
b50a28de
SM
51892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5190
5191 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5192 (graft_intervals_into_buffer): Simplify.
5193
015137db
EZ
51942011-11-18 Eli Zaretskii <eliz@gnu.org>
5195
5196 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5197 hash values of the two rows.
5198 (copy_row_except_pointers): Preserve the used[] arrays and the
5199 hash values of the two rows. (Bug#10035)
68c95424 5200 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5201
5202 * xdisp.c (row_hash): New function, body extracted from
5203 compute_line_metrics.
5204 (compute_line_metrics): Call row_hash, instead of computing the
5205 hash code inline.
5206
5207 * dispnew.c (verify_row_hash): Call row_hash for computing the
5208 hash code of a row, instead of duplicating code from xdisp.c.
5209
5210 * dispextern.h (row_hash): Add prototype.
5211
a2addb04
TH
52122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5213
5214 * frame.c (delete_frame): Don't delete the terminal when the last
5215 X frame is closed if emacs is built with GTK toolkit.
5216
df85d315
JB
52172011-11-17 Juanma Barranquero <lekktu@gmail.com>
5218
5219 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5220
a0c2d0ae
MR
52212011-11-17 Martin Rudalics <rudalics@gmx.at>
5222
5223 * window.c (Vwindow_splits): Rename to
5224 Vwindow_combination_resize. Suggested by Juri Linkov.
5225 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5226 of Vwindow_splits.
5227
58179cce
JB
52282011-11-16 Juanma Barranquero <lekktu@gmail.com>
5229
7877f373
JB
5230 * nsfns.m (Fns_font_name):
5231 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5232
b6f67890
MR
52332011-11-16 Martin Rudalics <rudalics@gmx.at>
5234
5235 * window.h (window): Rename slot "nest" to "combination_limit".
5236 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5237 (Fset_window_nest): Rename to Fset_window_combination_limit.
5238 (Vwindow_nest): Rename to Vwindow_combination_limit.
5239 (recombine_windows, make_parent_window, make_window)
5240 (Fsplit_window_internal, saved_window)
5241 (Fset_window_configuration, save_window_save): Rename all
5242 occurrences of window_nest to window_combination_limit.
5243
c7015153
JB
52442011-11-15 Juanma Barranquero <lekktu@gmail.com>
5245
5246 * image.c (imagemagick_load_image): Fix typo.
5247
322ad6ec
EZ
52482011-11-14 Eli Zaretskii <eliz@gnu.org>
5249
5250 * xdisp.c (display_line): Move the call to
5251 highlight_trailing_whitespace before the call to
5252 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5253 faces of all the glyphs to compute ROW's hash value.
5254 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5255
f067b8ec
JB
52562011-11-14 Juanma Barranquero <lekktu@gmail.com>
5257
5258 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5259 just return (bug#10044).
5260
1e5b2111
EZ
52612011-11-12 Eli Zaretskii <eliz@gnu.org>
5262
7ef3cbd5
EZ
5263 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5264 with user-defined heap size. Bump the default size of the temacs
5265 heap to 27MB, to avoid memory warning when running temacs.
5266 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5267
1e5b2111
EZ
5268 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5269 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5270 (verify_row_hash) [XASSERTS]: New function.
5271 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5272 that the hash value of glyph rows is correct.
1e5b2111 5273
89d61221
MR
52742011-11-12 Martin Rudalics <rudalics@gmx.at>
5275
5276 * window.h (window): Remove splits slot.
5277 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5278 (Fdelete_other_windows_internal, make_parent_window)
5279 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5280 (Fset_window_configuration, save_window_save): Don't deal with
5281 split status of windows.
5282 (saved_window): Remove splits slot.
5283 (Vwindow_splits): Rewrite doc-string.
5284
97f18cc8
JD
52852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5286
5287 * xfns.c (unwind_create_frame):
5288 * nsfns.m (unwind_create_frame):
5289 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5290 Vframe_list (Bug#9999).
5291
22a648b4
DA
52922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5293
0b381c7e 5294 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5295
659afede
KH
52962011-11-11 Kenichi Handa <handa@m17n.org>
5297
5298 * callproc.c (Fcall_process): Set the member dst_multibyte of
5299 process_coding.
5300
9ac0394b
KH
53012011-11-11 Johan Bockgård <bojohan@gnu.org>
5302
5303 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5304 avoid a crash (bug#9496).
5305
2fbdc249
CY
53062011-11-09 Chong Yidong <cyd@gnu.org>
5307
5308 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5309 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5310
ac6b1f81
PE
53112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5312
5313 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5314
09db192c
PE
53152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5316
5317 Avoid some portability problems by eschewing 'extern inline' functions.
5318 The trivial performance wins aren't worth the portability hassles; see
5319 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5320 et seq.
5321 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5322 (window_box_width, window_box_left, window_box_left_offset)
5323 (window_box_right, window_box_right_offset): Undo previous change,
5324 by removing the "extern"s.
5325 * intervals.c (adjust_intervals_for_insertion)
5326 (adjust_intervals_for_deletion): Undo previous change,
5327 making these static again.
5328 (offset_intervals, temp_set_point_both, temp_set_point)
5329 (copy_intervals_to_string): No longer inline.
5330 * xdisp.c (window_text_bottom_y, window_box_width)
5331 (window_box_height, window_box_left_offset)
5332 (window_box_right_offset, window_box_left, window_box_right)
5333 (window_box): No longer inline.
5334
105216ed
CY
53352011-11-08 Chong Yidong <cyd@gnu.org>
5336
5337 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5338 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5339 Signal an error if not a live window.
105216ed
CY
5340 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5341 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5342
ae9e237f
JB
53432011-11-07 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * lisp.h (syms_of_abbrev): Remove declaration.
5346 Reported by CHENG Gao <chenggao@royau.me>.
5347
c7aa8333
EZ
53482011-11-07 Eli Zaretskii <eliz@gnu.org>
5349
5350 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5351 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5352 of temacs in GUI mode.
5353
be7f5545
MR
53542011-11-07 Martin Rudalics <rudalics@gmx.at>
5355
5356 * window.h: Declare delete_all_child_windows instead of
5357 delete_all_subwindows.
5358 * window.c (Fwindow_nest, Fset_window_nest)
5359 (Fset_window_new_total, Fset_window_new_normal)
5360 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5361 (delete_all_subwindows): Rename to delete_all_child_windows.
5362 (Fdelete_other_windows_internal, Fset_window_configuration):
5363 Call delete_all_child_windows instead of delete_all_subwindows.
5364 * frame.c (delete_frame): Call delete_all_child_windows instead
5365 of delete_all_subwindows.
5366
ca78dc43
PE
53672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5370 This is also needed for porting to any host where GC_MARK_STACK is
5371 not GC_MAKE_GCPROS_NOOPS.
5372 (which_symbols): Use it.
5373
a0241d01
KH
53742011-11-07 Kenichi Handa <handa@m17n.org>
5375
5376 * coding.c (coding_set_destination): Check coding->src_pos only
5377 when coding->src_object is a buffer (bug#9910).
5378
5379 * process.c (send_process): Set the member src_multibyte of coding
5380 to 0 (bug#9911) when sending a unibyte text.
5381
5382 * callproc.c (Fcall_process): Set the member src_multibyte of
5383 process_coding to 0 (bug#9912).
5384
a64bfdfa 53852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5386
5387 * xmenu.c (cleanup_widget_value_tree): New function.
5388 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5389 calling free_menubar_widget_value_tree directly (Bug#9830).
5390
cb41b32a
PE
53912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5392
5393 Fix some portability problems with 'inline'.
5394 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5395 (window_box_width, window_box_left, window_box_left_offset)
5396 (window_box_right, window_box_right_offset): Declare extern.
5397 Otherwise, these inline functions do not conform to C99 and
5398 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5399 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5400 * intervals.c (adjust_intervals_for_insertion)
5401 (adjust_intervals_for_deletion): Now extern, because otherwise the
5402 extern inline functions 'offset_intervals' couldn't refer to it.
5403 (static_offset_intervals): Remove.
5404 (offset_intervals): Rewrite using the old contents of
5405 static_offset_intervals. The old version didn't conform to C99
5406 because an extern inline function contained a reference to an
5407 identifier with static linkage.
5408
b7041366
AS
54092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5410
5411 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5412 GC.
5413
88a37c4d
EZ
54142011-11-06 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5417 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5418 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5419 return Qleft_to_right.
5420
49745b39
CY
54212011-11-06 Chong Yidong <cyd@gnu.org>
5422
5423 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5424 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5425 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5426 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5427 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5428 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5429 (Fwindow_vscroll): Doc fix.
5430 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5431 argument, since it makes no sense to pass a live window and for
5432 consistency with window-child.
5433
1f05cd82
CS
54342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5435
5436 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5437 support MSVC.
5438
22610910
JR
54392011-11-05 Jason Rumney <jasonr@gnu.org>
5440
5441 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5442 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5443 fonts (Bug#6029).
5444 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5445 bitwise arithmetic preventing use of unicode-sip and non-truetype
5446 opentype fonts.
5447
a06776b2
EZ
54482011-11-05 Eli Zaretskii <eliz@gnu.org>
5449
3ad924ba
EZ
5450 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5451 "emacs"-only part.
5452
a06776b2
EZ
5453 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5454 initialization code to keep similarity to xfns.c after changes
5455 from 2011-11-05.
5456
c9e7db78
JD
54572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5458
a97f8f3f
JD
5459 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5460 (unwind_create_frame): New function (Bug#9943).
5461 (Fx_create_frame): Restructure code to be more similar to the one in
5462 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5463 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5464 Move terminal->reference_count++ just before making the frame official
5465 (Bug#9943).
5466
5467 * nsterm.m (x_free_frame_resources): New function.
5468 (x_destroy_window): Move code to x_free_frame_resources.
5469
c9e7db78 5470 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5471 (Fx_create_frame, x_create_tip_frame):
5472 Move terminal->reference_count++ just before making the frame
75f1671a 5473 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5474 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5475
a6fc3b5c
EZ
54762011-11-05 Eli Zaretskii <eliz@gnu.org>
5477
5478 Support MSVC build with newer versions of Visual Studio.
5479 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5480 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5481 nt/gmake.defs.
5482
5483 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5484 which are not supported by MSVC.
5485 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5486 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5487 bitfields.
5488 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5489 types in bitfields.
5490 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5491
5492 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5493
58179cce 54942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5495
5496 Support MSVC build with newer versions of Visual Studio.
5497 * w32.c: Don't include w32api.h for MSVC.
5498 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5499
5500 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5501 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5502 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5503 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5504 e_* cousins.
5505 (alloca) [_MSC_VER]: Define to _alloca.
5506
5507 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5508
5509 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5510
a58c13ed
EZ
55112011-11-04 Eli Zaretskii <eliz@gnu.org>
5512
5513 * xdisp.c (note_mouse_highlight): If either of
5514 previous/next-single-property-change returns nil, treat that as
5515 the beginning or the end of the buffer. (Bug#9955)
5516
fe0b6370
JD
55172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5518
a58c13ed 5519 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5520 label is not null (Bug#9951).
5521 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5522 may be NULL.
5523
89bd5ee1
EZ
55242011-11-04 Eli Zaretskii <eliz@gnu.org>
5525
5526 * window.c (Fwindow_body_size): Mention in the doc string that the
5527 return value is in frame's canonical units. (Bug#9949)
5528
84c3edb9
EZ
55292011-11-03 Eli Zaretskii <eliz@gnu.org>
5530
4e2fb5c7
EZ
5531 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5532
84c3edb9 5533 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5534 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5535 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5536
bc17a887
EZ
55372011-11-01 Eli Zaretskii <eliz@gnu.org>
5538
5539 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5540 Don't stop backward scan on the continuation glyph, even though
5541 its CHARPOS is positive.
6d5eb5b0
SM
5542 (mouse_face_from_buffer_pos, note_mouse_highlight):
5543 Rename cover_string to disp_string.
bc17a887 5544
4ee88440
MR
55452011-11-01 Martin Rudalics <rudalics@gmx.at>
5546
5547 * window.c (temp_output_buffer_show): Don't use
5548 Vtemp_buffer_show_specifiers.
5549 (Vtemp_buffer_show_specifiers): Remove unused variable.
5550
c2ff3c02
EZ
55512011-10-30 Eli Zaretskii <eliz@gnu.org>
5552
5553 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5554 past the beginning of the current glyph matrix.
5555
58179cce 55562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5557
5558 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5559 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5560 HAVE_GTK3 (Bug#9869).
b77a6a7f 5561
3b574623
JD
5562 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5563 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5564
b77a6a7f
JD
5565 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5566
5567 * xterm.c: Declare x_handle_net_wm_state to return int.
5568 (handle_one_xevent): Check if we are iconified but don't have
5569 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5570 (get_current_wm_state): Return non-zero if not hidden,
5571 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5572 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5573 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5574 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5575
196e41e4
PE
55762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5577
5578 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5579 so that this new function doesn't get optimized away by a
5580 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5581
021f2e1a
AS
55822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5583
5584 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5585
8b058d44
EZ
55862011-10-29 Eli Zaretskii <eliz@gnu.org>
5587
5588 Fix the `xbytecode' command.
5589 * .gdbinit (xprintbytestr): New command.
b50a28de 5590 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5591 (xbytecode): Print the byte-code string as well.
5592
4452fb80
EZ
55932011-10-29 Kim Storm <storm@cua.dk>
5594
8b058d44
EZ
5595 * alloc.c (which_symbols): New function.
5596
21b72067
AS
55972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5598
5599 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5600 line. (Bug#9903)
5601
83ed7b5c
GM
56022011-10-29 Glenn Morris <rgm@gnu.org>
5603
5604 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5605 Not clear what it was for, and it causes various bugs. (Bug#9839)
5606
5a7a728b
EZ
56072011-10-28 Eli Zaretskii <eliz@gnu.org>
5608
5609 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5610 possible random value that matches one of those tested as
5611 condition to clear the mouse face.
5612
d3d0842f
CY
56132011-10-28 Chong Yidong <cyd@gnu.org>
5614
5615 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5616
31b39d13
DN
56172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5618
5619 * window.c (make_window): Initialize phys_cursor_on_p.
5620
9aba6043
SM
56212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5622
5623 * lisp.h (struct Lisp_Symbol): Update comments.
5624
c20992f4
JB
56252011-10-28 Juanma Barranquero <lekktu@gmail.com>
5626
5627 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5628
db4f02f2
EZ
56292011-10-28 Eli Zaretskii <eliz@gnu.org>
5630
5631 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5632 <oslsachem@gmail.com> for helping to debug this.
5633
5634 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5635 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5636 (g_b_init_get_glyph_outline_w): New static variables.
5637 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5638 (GetGlyphOutlineW_Proc): New typedefs.
5639 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5640 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5641 New functions.
5642 (w32font_open_internal, compute_metrics):
5643 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5644 instead of calling the "wide" APIs directly.
5645
5646 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5647
5648 * w32.h (syms_of_w32font): Add prototype.
5649
87e68db4
JB
56502011-10-27 Juanma Barranquero <lekktu@gmail.com>
5651
5652 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5653 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5654 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5655 (Fmove_to_window_line): Doc fix.
5656
435c1d67
CY
56572011-10-27 Chong Yidong <cyd@gnu.org>
5658
5659 * process.c (make_process): Set gnutls_state to NULL.
5660
5661 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5662 non-NULL, regardless of GNUTLS_INITSTAGE.
5663 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5664 an error. Set process slots as soon as we allocate them.
5665
5666 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5667
9c6c6f49
CY
56682011-10-27 Chong Yidong <cyd@gnu.org>
5669
9aba6043
SM
5670 * gnutls.c (emacs_gnutls_deinit): New function.
5671 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5672 (Fgnutls_deinit, Fgnutls_boot): Use it.
5673
5674 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5675 (deactivate_process): Call emacs_gnutls_deinit.
5676
657d08d3
JB
56772011-10-27 Juanma Barranquero <lekktu@gmail.com>
5678
5679 * image.c (x_create_x_image_and_pixmap):
5680 * w32.c (sys_rename, w32_delayed_load):
5681 * w32font.c (fill_in_logfont):
5682 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5683
5430d399
JB
56842011-10-26 Juanma Barranquero <lekktu@gmail.com>
5685
5686 * w32fns.c (w32_default_color_map): New function,
5687 extracted from Fw32_default_color_map.
a7ef684b 5688 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5689
fe0055fa
PE
56902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5691
5692 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5693
e6346438
SM
56942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5695
5696 * keyboard.c (test_undefined): New function (bug#9751).
5697 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5698
e112cc37
ET
56992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5700
5701 * sysdep.c (init_sys_modes): Fix the check for the controlling
5702 terminal (Bug#6649).
5703
7b5d6677
EZ
57042011-10-20 Eli Zaretskii <eliz@gnu.org>
5705
5706 * dispextern.h (struct bidi_it): New member next_en_type.
5707
5708 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5709 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5710 current character, check also for next_en_type being WEAK_EN.
5711 (bidi_resolve_weak): Don't enter the expensive loop if the current
5712 position is before next_en_pos. Record the bidi type of the first
5713 non-ET, non-BN character we find, in addition to its position.
5714 (bidi_level_of_next_char): Invalidate next_en_type when
5715 next_en_pos is over-stepped.
5716
7da0b018
PE
57172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5720 * editfns.c: Rewrite current-time-zone so that it invokes
5721 the equivalent of (format-time-string "%Z") to get the time zone name.
5722 This fixes a bug when the time zone name contains characters that
5723 need converting from the system time locale to Emacs internal format.
5724 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5725 that patch fixed format-time-string to do the conversion, but
5726 I forgot to fix current-time-zone.
5727 (format_time_string): New function, containing most of
5728 what Fformat_time_string used to contain.
5729 (Fformat_time_string): Rewrite in terms of format_time_string.
5730 This doesn't change this function's behavior.
5731 (current-time-zone): Rewrite to use format_time_string.
5732 This fixes the bug reported by Michael Schierl in
5733 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5734 Jason Rumney's 2007-06-07 change worked around this bug, but
5735 didn't fix it.
5736 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5737
8547b010
EZ
57382011-10-19 Eli Zaretskii <eliz@gnu.org>
5739
5740 * xdisp.c (start_display): If the character at POS is displayed
5741 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5742 (try_window_reusing_current_matrix): If a line ends in a display
5743 vector or the next line starts in a display vector, continue
5744 redrawing the window even though the character position of
5745 start_row was reached.
8547b010
EZ
5746 (Bug#9771, part 2)
5747
4e948d15
CY
57482011-10-18 Chong Yidong <cyd@gnu.org>
5749
5750 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5751 with nobreak-char-display too.
5752
4787455f
EZ
57532011-10-18 Eli Zaretskii <eliz@gnu.org>
5754
5755 Fix part 3 of bug#9771.
5756 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5757 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5758 non-neutral characters if the current character is a paragraph
5759 separator (a.k.a. Newline). This avoids running the same
5760 expensive loop twice, once when we consume the preceding newline
5761 and the other time when the line actually needs to be displayed.
5762 Avoid the loop when we see neutrals on the base embedding level
5763 following a character whose directionality is the same as the
5764 paragraph's. This avoids running the expensive loop when a line
5765 ends in a long sequence of neutrals, like control characters.
5766 Add assertion against STRONG_AL type. Slightly rearrange code
5767 that determines the type of a neutral given the first non-neutral
5768 that follows it.
5769 (bidi_level_of_next_char): Set next_en_pos to zero when
5770 invalidating its info.
5771
2c91f553
EZ
57722011-10-17 Eli Zaretskii <eliz@gnu.org>
5773
5774 * xdisp.c (push_display_prop): Determine whether to record string
5775 or buffer position by IT->string, not by IT->method. Allow
5776 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5777 (move_it_vertically_backward): Don't look for character position
5778 immediately after the newline when in a continuation line.
5779 (Bug#9771, part 1)
2c91f553 5780
c7b08b0d
MR
57812011-10-15 Martin Rudalics <rudalics@gmx.at>
5782
5783 * window.c (coordinates_in_window): Rewrite and delabelize
5784 vertical border check. (Bug#5357) (Bug#9618)
5785
6b02f655
SM
57862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5787
5788 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5789 errors in XSetWindowBorder (bug#9310).
5790
81d40c92
DA
57912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5792
5793 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5794 avoid crash when xmalloc overrun checking is enabled.
5795
d4172c3b
EZ
57962011-10-13 Eli Zaretskii <eliz@gnu.org>
5797
5798 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5799 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5800 cursor motion with <left> and <right> arrow keys.
5801
5802 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5803 some callers set that themselves.
5804
b00eea75
EZ
58052011-10-12 Eli Zaretskii <eliz@gnu.org>
5806
5807 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5808 display string and the previous row comes from the same string and
5809 is empty. (Bug#9739) (Bug#9738)
5810
8fe012c4
SM
58112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5812
5813 * doc.c (get_doc_string): Encode file name (bug#9735).
5814
0074aef2
EZ
58152011-10-12 Eli Zaretskii <eliz@gnu.org>
5816
79beb178
EZ
5817 * bidi.c (bidi_level_of_next_char):
5818 * xdisp.c (get_visually_first_element): Remove old incorrect
5819 comments regarding the Unicode Line Separator character.
5820
0074aef2
EZ
5821 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5822
6e4b3fbe
DA
58232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5824
5825 * alloc.c (Fgc_status): Do not access beyond zombies array
5826 boundary if nzombies > MAX_ZOMBIES.
5827 * alloc.c (dump_zombies): Add missing format specifier.
5828
0324f3af
PE
58292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5830
b5525cac
PE
5831 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5832 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5833
0324f3af
PE
5834 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5835 Some packages use them to denote characters with modifiers.
5836
e9b5f888
AS
58372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5838
5839 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5840 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5841 matching a pp-number. Rename parameter var to var1.
5842
127827c0
SM
58432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5844
5845 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5846
c8fd3bd0
GM
58472011-10-08 Glenn Morris <rgm@gnu.org>
5848
5849 * callint.c (Fcall_interactively): Give a more explicit error for the
5850 'c' case with a non-character input. (Bug#8479)
5851
352ec8ff
EZ
58522011-10-08 Eli Zaretskii <eliz@gnu.org>
5853
03669ccb
EZ
5854 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5855 lines.
7061c986
EZ
5856 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5857 lines that are hscrolled on the left.
03669ccb 5858
352ec8ff
EZ
5859 * dispnew.c (buffer_posn_from_coords): Account for a possible
5860 presence of header-line. (Bug#4426)
5861
a66cfb1c
SM
58622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5863
6b02f655
SM
5864 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5865 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5866
7c5ee88e
PE
58672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5868
5869 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5870 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5871 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5872 this makes Emacs dump core during garbage collection on rare
5873 occasions. sizeof is obviously inferior to offsetof here, so
5874 stick with offsetof.
5875 (GC_POINTER_ALIGNMENT): New macro.
5876 (mark_memory): Omit 3rd (offset) arg; caller changed.
5877 Don't assume EMACS_INT alignment is the same as pointer alignment.
5878
df1bbe5b
SM
58792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5880
5881 * keyboard.c (read_key_sequence_remapped): New var.
5882 (read_key_sequence): Compute remapping in the right buffer.
5883 (command_loop_1): Use read_key_sequence's remapping directly.
5884
51553db6
SM
58852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5886
32c1fffd
SM
5887 * dired.c (file_name_completion): Don't expand file name.
5888 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5889 before checking file name handler.
5890
51553db6
SM
5891 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5892 they've been requested explicitly (bug#9591).
5893
b6bd1599 58942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5895
5896 * keymap.c (Fsingle_key_description): Use make_specified_string
5897 instead of build_string to build string from push_key_description.
5898 (Bug#5193)
5899
f701dc2a
PE
59002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5901
4222c55d
PE
5902 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5903 This fixes a Y2038 bug on 64-bit hosts.
5904 * buffer.c (reset_buffer):
5905 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5906 (Fclear_buffer_auto_save_failure):
5907 Use 0, not -1, to represent an unset failure time, since time_t
5908 might not be signed.
5909
f701dc2a
PE
5910 Remove dependency on glibc malloc internals.
5911 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5912 Move back here from lisp.h, but with their new implementations.
5913 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5914 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5915 * charset.c (charset_table_init): New static var.
5916 (syms_of_charset): Use it instead of xmalloc. This removes a
5917 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5918 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5919 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5920 Move back to alloc.c.
5921 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5922 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5923
9ceebf39
JD
59242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5925
5926 * nsterm.m (windowDidResize): Call x_set_window_size only when
5927 ns_in_resize is true. Otherwise set pixelwidth/height and
5928 call change_frame_size (Bug#9628).
5929
cb993c58
PE
59302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5931
3930c88b
PE
5932 Port --enable-checking=all to Fedora 14 x86-64.
5933 * charset.c (syms_of_charset): Also account for glibc malloc's
5934 internal overhead when calculating the initial malloc maximum.
5935
cb993c58
PE
5936 Port --enable-checking=all to Fedora 14 x86.
5937 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5938 Move to lisp.h.
5939 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5940 (overrun_check_realloc, overrun_check_free):
5941 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5942 That way, xmalloc returns a properly-aligned pointer even if
5943 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5944 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5945 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5946 into account when calculating the initial malloc maximum.
5947 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5948 Move here from alloc.c, so that charset.c can use it too.
5949 Properly align; the old code wasn't right for common 32-bit hosts
5950 when configured with --enable-checking=all.
5951 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5952 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5953
31bed486
EZ
59542011-09-29 Eli Zaretskii <eliz@gnu.org>
5955
04c70788 5956 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5957 use EDOM.
5958
fbcaa2f3
EZ
59592011-09-28 Eli Zaretskii <eliz@gnu.org>
5960
5961 * xdisp.c (compute_display_string_end): If there's no display
5962 string at CHARPOS, return -1.
5963
5964 * bidi.c (bidi_fetch_char): When compute_display_string_end
5965 returns a negative value, treat the character as a normal
5966 character not covered by a display string. (Bug#9624)
5967
a239d4e9
JB
59682011-09-28 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * lread.c (Fread_from_string): Fix typo in docstring.
5971
88652fd5
EZ
59722011-09-27 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5975 newline, reseat the iterator instead of bidi-iterating there one
5976 character at a time. (Bug#9610)
32c1fffd
SM
5977 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5978 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5979
ed497dd4
AS
59802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5981
5982 * lread.c (readevalloop): Use correct code for NBSP.
5983 (read1): Likewise. (Bug#9608)
5984
b2bf61aa
MA
59852011-09-25 Michael Albinus <michael.albinus@gmx.de>
5986
5987 * dbusbind.c (Fdbus_register_signal): When service is not
5988 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5989
32bbb17c
GM
59902011-09-25 Glenn Morris <rgm@gnu.org>
5991
5992 * buffer.c (truncate-lines): Doc fix.
5993
94e0933e
CY
59942011-09-24 Chong Yidong <cyd@stupidchicken.com>
5995
5996 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5997 (Fset_window_next_buffers): Doc fix.
5998
cddde921
GM
59992011-09-24 Glenn Morris <rgm@gnu.org>
6000
6001 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6002
1260aef1
PE
60032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6004
25b4bfa0
PE
6005 Fix minor problems found by static checking.
6006 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6007 * indent.c (Fvertical_motion): Fix == vs = typo.
6008
e3cbd34b
EZ
60092011-09-24 Eli Zaretskii <eliz@gnu.org>
6010
a66cfb1c
SM
6011 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6012 Default value is now t. Doc fix.
6bf7006f 6013
e3cbd34b 6014 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6015 logic when moving up, not only when moving down. Fix the
e3cbd34b 6016 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6017 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6018
6019 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6020 CHARPOS is covered by a display string which includes newlines.
6021 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6022 is covered by a display string with embedded newlines.
6023
a3de0cbd
MA
60242011-09-24 Michael Albinus <michael.albinus@gmx.de>
6025
6026 * dbusbind.c (Fdbus_register_signal): Add match rule to
6027 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6028 (Fdbus_register_method, Vdbus_registered_objects_table):
6029 Fix docstring.
a3de0cbd 6030
b260039d
JM
60312011-09-24 Jim Meyering <meyering@redhat.com>
6032
32c1fffd 6033 do not ignore write error for any output size
b260039d
JM
6034 The previous change was incomplete.
6035 While it makes emacs --batch detect the vast majority of stdout
6036 write failures, errors were still ignored whenever the output size is
6037 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6038 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6039 && echo FAIL: ignored write error
6040 FAIL: ignored write error
6041 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6042 && echo FAIL: ignored write error
6043 FAIL: ignored write error
6044 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6045
8eca8a7c
AS
60462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6047
6048 * emacs.c (Fkill_emacs): In noninteractive mode exit
6049 non-successfully if a write error occurred on stdout. (Bug#9574)
6050
3341db62
EZ
60512011-09-21 Eli Zaretskii <eliz@gnu.org>
6052
6053 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6054 the xassert test.
6055
6056 * dispextern.h (struct it): Update the comment documenting what
6057 can it->OBJECT be.
6058
8c203dbf
EZ
60592011-09-20 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6062 a display string, extend search for cursor position to end of row.
6063 (find_row_edges): If the row ends in a newline from a display
6064 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6065 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6066 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6067 non-empty line. Fixes confusing cursor motion with arrow keys at
6068 the beginning of a line that starts with whitespace.
8c203dbf 6069
a4824228
LMI
60702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6071
6072 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6073 (bug#9493).
6074
33ed493b
CY
60752011-09-18 Chong Yidong <cyd@stupidchicken.com>
6076
6077 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6078 boolean (Bug#9154).
6079
56cd55c8
EZ
60802011-09-18 Eli Zaretskii <eliz@gnu.org>
6081
6082 * xdisp.c (display_line): Record maximum and minimum buffer
6083 positions even if no glyphs were produced (e.g., by a zero-width
6084 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6085 buffer positions that will be removed from the glyph row because
6086 they don't fit.
c02dcedf
EZ
6087 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6088 column is beyond frame width: don't subtract 1 "pixel" when
6089 computing width of the stretch.
3e62b7e0
EZ
6090 (reseat_at_next_visible_line_start): Undo the change made on
6091 2011-09-17 that saved paragraph information and restored it after
6092 the call to `reseat'. (Bug#9545)
56cd55c8 6093
5ed99d36 60942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6095
6096 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6097 and turn window cursor on if cleared (Bug#9415).
6098
5ed99d36 60992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6100
6101 * search.c (boyer_moore): Take unibyte characters from pattern
6102 literally. (Bug#9458)
6103
9bade7b2
EZ
61042011-09-18 Eli Zaretskii <eliz@gnu.org>
6105
6106 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6107
e5e9d610
PE
61082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6109
87e4427a
PE
6110 Fix minor problem found by static checking.
6111 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6112 initialized, to pacify gcc -Wuninitialized.
6113
e5e9d610
PE
6114 * fileio.c: Report proper errno when syscall falls.
6115 (Finsert_file_contents): Save and restore errno,
6116 so that report_file_error outputs the correct diagnostic.
6117 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6118
a1674f0b
EZ
61192011-09-18 Eli Zaretskii <eliz@gnu.org>
6120
6121 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6122
fbfb6dd4
EZ
61232011-09-17 Eli Zaretskii <eliz@gnu.org>
6124
6125 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6126 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6127
bb187662
EZ
61282011-09-17 Eli Zaretskii <eliz@gnu.org>
6129
1137e8b8 6130 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6131 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6132
6133 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6134 (bidi_find_paragraph_start): Search back for paragraph beginning
6135 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6136 (bidi_move_to_visually_next): Only trigger paragraph-related
6137 computations when the last character is a newline or at EOB, not
6138 just any NEUTRAL_B. (Bug#9470)
6139
bb187662
EZ
6140 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6141 truncated lines if point is covered by a display string. (Bug#9524)
6142
2e621251
PE
61432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6144
6145 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6146 (cons_to_x_long): New function.
6147 (lisp_data_to_selection_data): Use it. Correct the test for
6148 short-versus-long data; it was negated. Break out of vector
6149 loop, for efficiency, when a long datum is discovered.
6150
91a15bc6
SM
61512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6152
6153 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6154
b41c3a35
EZ
61552011-09-16 Eli Zaretskii <eliz@gnu.org>
6156
6157 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6158 GCC PR/17406) by declaring this function with external scope.
6159
7812ba2d
PE
61602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6161
6162 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6163 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6164
cf7edc2a
AS
61652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6166
6167 * editfns.c (Fformat): Correctly handle text properties on "%%".
6168
bd01620e
EZ
61692011-09-15 Eli Zaretskii <eliz@gnu.org>
6170
6171 * xterm.c (x_draw_composite_glyph_string_foreground):
6172 * w32term.c (x_draw_composite_glyph_string_foreground):
6173 * term.c (encode_terminal_code):
6174 * composite.c (composition_update_it, get_composition_id):
6175 * xdisp.c (get_next_display_element)
6176 (fill_composite_glyph_string): Add comments about special meaning
6177 of TAB characters in a composition.
6178
a02719a3
PE
61792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6180
6181 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6182 This occurs when processing a multibyte format.
6183 Problem reported by Wolfgang Jenker.
a02719a3 6184
72589a3c
JB
61852011-09-15 Johan Bockgård <bojohan@gnu.org>
6186
6187 * xdisp.c (try_cursor_movement): Only check for exact match if
6188 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6189
1c14176c
PE
61902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6191
6192 Remove unused external symbols.
6193 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6194 * xdisp.c (calc_pixel_width_or_height): Now static.
6195 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6196 * indent.c (check_display_width):
6197 * w32term.c: Fix comment to match code.
6198 * xterm.c, xterm.h (x_catching_errors): Remove.
6199
d2eea5b5
PE
62002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 * xselect.c: Use signed conversions more consistently (Bug#9498).
6203 (selection_data_to_lisp_data): Assume incoming selection data are
6204 signed integers, not unsigned. This is to be consistent with
6205 outgoing selection data, which was modified to use signed integers
6206 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6207 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6208 expects long, not unsigned long.
6209
46888499
EZ
62102011-09-14 Eli Zaretskii <eliz@gnu.org>
6211
6212 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6213 computation of loop end. Reported by Johan Bockgård
6214 <bojohan@gnu.org>.
6215
ef8ef9fb
CY
62162011-09-13 Chong Yidong <cyd@stupidchicken.com>
6217
6218 * frame.c (Fother_visible_frames_p): Function deleted.
6219
fa819fed
EZ
62202011-09-12 Eli Zaretskii <eliz@gnu.org>
6221
6222 * indent.c (compute_motion): Process display vector front to back
6223 rather than the other way around. (Bug#2496)
6224
2ba8e008
SM
62252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6226
6227 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6228
20f53c69
CY
62292011-09-11 Chong Yidong <cyd@stupidchicken.com>
6230
6231 * minibuf.c (Fread_from_minibuffer): Doc fix.
6232
d562d7a4
EZ
62332011-09-11 Eli Zaretskii <eliz@gnu.org>
6234
6235 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6236 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6237
1c4d7f3d
LMI
62382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6239
6240 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6241 value for non-existent files.
6242
b885bf36
EZ
62432011-09-11 Eli Zaretskii <eliz@gnu.org>
6244
6245 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6246 set its "size" to -1. This will set the modtime_size field of
6247 the corresponding buffer to -1, which is what
6248 verify-visited-file-modtime expects for files that do not exist.
6249 (Bug#9139)
6250
6612f0bf
PE
62512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6252
6253 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6254 here ...
6255 * lisp.h: ... from here. push_key_description is no longer
6256 defined in keyboard.c, so its declaration should not be in
6257 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6258 logically belongs with push_key_description.
6259
dfb3f755
PE
62602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 * buffer.h: Include <sys/types.h> instead of <time.h>.
6263 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6264 Problem reported by Herbert J. Skuhra.
6265
3134906c
LMI
62662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6267
6268 * xml.c (parse_region): Make the parsing work for
6269 non-comment-starting XML files again (bug#9144).
6270
8d903f4e
AS
62712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6272
6273 * image.c (gif_load): Fix calculation of bottom and right corner.
6274 (Bug#9468)
6275
80ad64f4
EZ
62762011-09-10 Eli Zaretskii <eliz@gnu.org>
6277
6278 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6279 redisplay in small windows.
6280
208a048d
EZ
62812011-09-09 Eli Zaretskii <eliz@gnu.org>
6282
6283 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6284
9b1c252e
MR
62852011-09-08 Martin Rudalics <rudalics@gmx.at>
6286
6287 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6288 Operate on live windows only.
6289
2949f33b
JB
62902011-09-08 Juanma Barranquero <lekktu@gmail.com>
6291
6292 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6293
e08dcafd
EZ
62942011-09-07 Eli Zaretskii <eliz@gnu.org>
6295
6296 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6297 only under bidi iteration.
6298
115b96bd
JD
62992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6300
6301 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6302
c8199d0f
PE
63032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6306 Without this fix, the command to link temacs failed due to an
6307 undefined symbol __builtin_isnan. This is because
6308 /usr/include/iso/math_c99.h #defines isnan(x) to
6309 __builtin_isnan(x), but the bundled gcc, which identifies itself
6310 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6311 a __builtin_isnan.
6312 * floatfns.c (isnan): #undef, and then #define to a clone of
6313 what's in data.c.
6314 (Fisnan): Always define, since it's always available now.
6315 (syms_of_floatfns): Always define isnan at the Lisp level.
6316
e39b275c 63172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6318
6319 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6320
b2db44d9 63212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6322
f4af5137 6323 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6324 The previous code assumed that file offsets (off_t values) fit in
6325 EMACS_INT variables, which is not true on typical 32-bit hosts.
6326 The code messed up by falsely reporting buffer overflow in cases
6327 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6328 when "big" contains more than 2**29 bytes, even though this
6329 inserts just one byte and does not overflow the buffer.
6330 (Finsert_file_contents): Store file offsets as off_t
6331 values, not as EMACS_INT values. Check for overflow when
6332 converting between EMACS_INT and off_t. When checking for
6333 buffer overflow or for overlap, take the offsets into account.
6334 Don't use EMACS_INT for small values where int suffices.
6335 When checking for overlap, fix a typo: ZV was used where
6336 ZV_BYTE was intended.
6337 (Fwrite_region): Don't assume off_t fits into 'long'.
6338 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6339
ecfc0a49
MA
63402011-09-05 Michael Albinus <michael.albinus@gmx.de>
6341
6342 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6343
6511acf2 63442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6345
0999621a 6346 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6347
6348 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6349 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6350 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6351 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6352 (modify_event_symbol): Do not assume that the length of
6353 name_alist_or_stem is safe to alloca and fits in int.
6354 (Fexecute_extended_command): Likewise for function name and binding.
6355 (Frecursion_depth): Wrap around reliably on integer overflow.
6356 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6357 since some callers pass EMACS_INT values.
6358 (Fsingle_key_description): Don't crash if symbol name contains more
6359 than MAX_ALLOCA bytes.
6360 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6361 (get_minibuffer): Arg is now EMACS_INT, not int.
6362 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6363 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6364 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6365
2be7d702
PE
6366 * dbusbind.c (signature_cat): New function.
6367 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6368 Do not overrun buffer; instead, report string overflow.
6369
9d1df220
PE
6370 * dispnew.c (add_window_display_history): Don't overrun buffer.
6371 Truncate instead; this is OK since it's just a log.
6372
33ef5c64
PE
6373 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6374 even if the time zone offset is outlandishly large.
6375 Don't mishandle offset == INT_MIN.
6376
66c6fdd5
PE
6377 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6378 when creating daemon; the previous buffer-overflow check was incorrect.
6379
d749b01b
PE
6380 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6381 which has the guts of the old verror function.
6382
b5cd1905
PE
6383 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6384 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6385
6e1a67fb
PE
6386 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6387 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6388 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6389 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6390 length of string rather than counting it via multiple sprintfs;
6391 that's simpler and more reliable.
c21721cc
PE
6392 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6393 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6394 sprintf, in case result does not fit in int.
6395
c57b67fc
PE
6396 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6397 (fontset_from_font): Print it.
6398
8a401434
PE
6399 * frame.c (tty_frame_count): Now printmax_t, not int.
6400 (make_terminal_frame, set_term_frame_name): Print it.
6401 (x_report_frame_params): In X, window IDs are unsigned long,
6402 not signed long, so print them as unsigned.
6403 (validate_x_resource_name): Check for implausibly long names,
6404 and don't assume name length fits in 'int'.
6405 (x_get_resource_string): Don't blindly alloca invocation name;
6406 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6407 not fit in int.
6408
6e1a67fb
PE
6409 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6410 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6411 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6412
0df02bf3
PE
6413 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6414 Use esprintf, not sprintf, in case result does not fit in int.
6415
48e30793
PE
6416 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6417 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6418 it as a large positive number.
6419 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6420 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6421
a66ff6d8
PE
6422 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6423 in case result does not fit in int.
6424
aca216ff
PE
6425 * print.c (float_to_string): Detect width overflow more reliably.
6426 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6427 buffer overrun. Don't assume list length fits in 'int'. Treat
6428 print length of 0 as 0, not as infinity; to be consistent with other
6429 uses of print length in this function. Don't overflow print length
6430 index. Don't assume hash table size fits in 'long', or that
6431 vectorlike size fits in 'unsigned long'.
6432
31c286f7
PE
6433 * process.c (make_process): Use printmax_t, not int, to format
6434 process-name gensyms.
6435
55e5faa1
PE
6436 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6437
80f2e268
PE
6438 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6439 to avoid potential buffer overrun.
6440
670741ab
PE
6441 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6442 if X resource line is longer than 512 bytes.
6443
b7163a50
PE
6444 * xfns.c (x_window): Make sprintf buffer a bit bigger
6445 to avoid potential buffer overrun.
6446
ae58ff1f
PE
6447 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6448
c43c8a6a
PE
6449 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6450
3f8236f4
PE
64512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6452
53e9fe90 6453 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6454 Without these, Emacs silently mishandles large integers sometimes.
6455 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6456 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6457
6511acf2
PE
6458 * xdisp.c (try_window_id): Check Emacs fixnum range before
6459 converting to 'int'.
806add1d 6460
6511acf2 6461 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6462 Check that an Emacs fixnum is in range before assigning it to 'int'.
6463 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6464 values converted from Emacs fixnums.
6465 (Frecenter): Don't wrap around a line count if it is out of 'int'
6466 range; instead, treat it as an extreme value.
6467 (Fset_window_configuration, compare_window_configurations):
6468 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6469
6511acf2
PE
6470 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6471 that can exceed INT_MAX. Check that EMACS_INT value is in range
6472 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6473 (match_limit): Don't assume that a fixnum can fit in 'int'.
6474
6511acf2 6475 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6476 exceed INT_MAX.
6477
6511acf2 6478 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6479 (Fvertical_motion): Don't wrap around LINES values that don't fit
6480 in 'int'. Instead, treat them as extreme values. This is good
6481 enough for windows, which can't have more than INT_MAX lines anyway.
6482
fcb901a7
LMI
64832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6484
0f2f6b6d
LMI
6485 * Require libxml/parser.h to avoid compilation warning.
6486
fcb901a7
LMI
6487 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6488
6489 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6490 since this reportedly can destroy thread storage.
6491
6e20a0d4
CY
64922011-08-30 Chong Yidong <cyd@stupidchicken.com>
6493
6494 * syntax.c (find_defun_start): Update all cache variables if
6495 exiting early (Bug#9401).
6496
148ae00e
EZ
64972011-08-30 Eli Zaretskii <eliz@gnu.org>
6498
f6cfbd8f
EZ
6499 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6500
148ae00e
EZ
6501 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6502 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6503 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6504
6505 * term.c (tty_append_glyph): New function.
6506 (produce_stretch_glyph): Static function and its prototype deleted.
6507
a66cfb1c
SM
6508 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6509 Add prototypes.
148ae00e 6510
c4a07a4c
PE
65112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6512
6513 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6514 when checking :margin (Bug#9390).
6515 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6516 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6517 so that the name doesn't mislead. All uses changed.
6518
6bc8cd65
JB
65192011-08-28 Johan Bockgård <bojohan@gnu.org>
6520
6521 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6522 set_tty_hooks.
6523
dca4927e
EZ
65242011-08-27 Eli Zaretskii <eliz@gnu.org>
6525
6526 * xdisp.c (move_it_to): Don't bail out early when reaching
6527 position beyond to_charpos, if we are scanning backwards.
6528 (move_it_vertically_backward): When DY == 0, make sure we get to
6529 the first character in the line after the newline.
6530
f2cad773
PE
65312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6532
6533 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6534 (ccl_driver): Do not generate an out-of-range pointer.
6535 (Fccl_execute_on_string): Remove unnecessary check for
6536 integer overflow, noted by Stefan Monnier in
6537 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6538 Remove a FIXME that didn't need fixing.
6539 Simplify the newly-introduced buffer reallocation code.
6540
0cae2cdb
JB
65412011-08-27 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6544
5fc295a4 65452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6546
70c60eb2 6547 Integer and memory overflow issues (Bug#9196).
726e0ab1 6548
d31850da
PE
6549 * doc.c (get_doc_string): Rework so that
6550 get_doc_string_buffer_size is the actual buffer size, rather than
6551 being 1 less than the actual buffer size; this makes xpalloc more
6552 convenient.
6553
a69fbedb
PE
6554 * image.c (x_allocate_bitmap_record, cache_image):
6555 * xselect.c (Fx_register_dnd_atom):
6556 Simplify previous changes by using xpalloc.
6557
fe5c5d37
PE
6558 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6559 since either will do and ptrdiff_t is convenient with xpalloc.
6560
0065d054
PE
6561 * charset.c (charset_table_size)
6562 (struct charset_sort_data.priority): Now ptrdiff_t.
6563 (charset_compare): Don't overflow if priorities differ greatly.
6564 (Fsort_charsets): Don't assume list length fits in int.
6565 Check for size-calculation overflow when allocating sort data.
6566 (syms_of_charset): Allocate an initial charset table that is
6567 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6568
6569 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6570
6571 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6572 The actual value is always <= INT_MAX, and leaving it unsigned made
6573 overflow checking harder.
6574
6575 * dispextern.h (struct glyph_matrix.rows_allocated)
6576 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6577 with xpalloc. The values are still always <= INT_MAX.
6578
6579 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6580
6581 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6582 (SAFE_NALLOCA): New macro.
6583
6584 * region-cache.c (struct boundary.pos, find_cache_boundary)
6585 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6586 (set_cache_region, invalidate_region_cache)
6587 (revalidate_region_cache, know_region_cache, region_cache_forward)
6588 (region_cache_backward, pp_cache):
6589 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6590 so that ptrdiff_t * can be passed to xpalloc.
6591 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6592 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6593 (pp_cache): Don't assume cache_len fits in int.
6594 * region-cache.h: Adjust extern decls to match.
6595
6596 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6597 EMACS_INT, since either will do, for xpalloc.
6598
6599 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6600 (xnmalloc, xnrealloc, xpalloc): New functions.
6601
726e0ab1
PE
6602 * bidi.c (bidi_shelve_header_size): New constant.
6603 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6604 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6605
51f30bc5 6606 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6607 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6608 (overlay_strings):
6609 Don't update size of array until after memory allocation succeeds,
6610 because xmalloc/xrealloc may not return.
0065d054
PE
6611 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6612 now that we have proper integer overflow checking.
6613 (record_overlay_string, overlay_strings): Catch overflows when
6614 calculating size of overlay_str_buf.
726e0ab1 6615
0065d054
PE
6616 * callproc.c (Fcall_process): Check for size overflow when
6617 calculating size of args2.
6618 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6619 Normally we prefer signed values, but sticking with ptrdiff_t would
6620 require adding more-complicated checks.
726e0ab1
PE
6621
6622 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6623 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6624 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6625 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6626
6627 * character.c (Fstring): Check for size-calculation overflow.
6628
6629 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6630 unnecessary integer overflow. Check for size overflow.
6631 (encode_coding_object): Don't update size until xmalloc succeeds.
6632
6633 * composite.c (get_composition_id): Check for overflow in glyph
6634 length calculations.
6635
6636 Integer and memory overflow fixes for display code.
6637 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6638 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6639 (scrolling_window): Check for overflow in size calculations.
6640 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6641 Don't assume glyph table len fits in int.
6642 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6643 (row_table_size): Now ptrdiff_t, not int.
6644 (scrolling_window): Avoid overflow in size calculations.
6645 Don't update size until allocation succeeds.
6646 * fns.c (concat): Check for overflow in size calculations.
6647 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6648 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6649 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6650
6651 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6652 (get_doc_string): Check for size calculation overflow.
6653 Don't update size until allocation succeeds.
6654 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6655 EMACS_INT, where ptrdiff_t will do.
6656 (Fsubstitute_command_keys): Check for string overflow.
6657
6658 * editfns.c (set_time_zone_rule): Don't assume environment length
6659 fits in int.
6660 (message_length): Now ptrdiff_t, not int.
6661 (Fmessage_box): Don't update size until allocation succeeds.
6662 Don't assume message length fits in int.
6663 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6664
0065d054
PE
6665 * emacs.c (main): Do not reallocate argv, since there is a null at
6666 the end that can be overwritten, and this way there's no need to
6667 worry about size-calculation overflow.
6668 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6669
6670 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6671 alloc succeeds.
6672 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6673
6674 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6675 (x_set_scroll_bar_width, x_figure_window_size):
6676 Check for integer overflow.
6677 (x_set_alpha): Do not assume XINT fits in int.
6678
6679 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6680 This is for the members text_lines, text_cols, total_lines, total_cols,
6681 where the system imposes an 'int' limit.
6682
6683 * fringe.c (Fdefine_fringe_bitmap):
6684 Don't update size until alloc works.
6685
6686 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6687 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6688
6689 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6690 Check for size-calculation overflow.
6691 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6692 do, as we prefer signed integers.
6693 (id_to_widget.max_size, id_to_widget.used)
6694 (xg_store_widget_in_map, xg_remove_widget_from_map)
6695 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6696 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6697 Use and return ptrdiff_t, not int.
6698 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6699 * gtkutil.h: Change prototypes to match the above.
6700
6701 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6702 are duplicate now that they've been promoted to lisp.h.
6703 (x_allocate_bitmap_record, x_alloc_image_color)
6704 (make_image_cache, cache_image, xpm_load):
6705 Don't update size until alloc is done.
6706 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6707 (x_detect_edges):
3256efce 6708 Check for size calculation overflow.
726e0ab1
PE
6709 (ct_colors_allocated_max): New constant.
6710 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6711 overflow.
3256efce 6712
726e0ab1
PE
6713 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6714 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6715 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6716 Use ptrdiff_t, not int, to count maps.
6717 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6718 calculations. Don't update size until allocation succeeds.
6719 Redo calculations to avoid overflow.
726e0ab1
PE
6720 * keyboard.h: Change prototypes to match the above.
6721
6722 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6723 to count maps.
6724 (current_minor_maps): Check for size calculation overflow.
6725 * keymap.h: Change prototypes to match the above.
6726
6727 * lread.c (read1, init_obarray): Don't update size until alloc done.
6728
6729 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6730 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6731
726e0ab1
PE
6732 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6733 Now ptrdiff_t, not int.
6734 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6735 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6736
6737 * process.c (Fnetwork_interface_list): Check for overflow
6738 in size calculation.
6739
6740 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6741
6742 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6743 overflow. Don't bother calling xmalloc when xrealloc will do.
6744
6745 * search.c (Freplace_match): Check for size calculation overflow.
6746 (Fset_match_data): Don't assume list lengths fit in 'int'.
6747
6748 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6749 for command line length. Do not attempt to address one before the
6750 beginning of an array, as that's not portable.
6751
6752 * term.c (max_frame_lines): Remove; unused.
6753 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6754 not int.
6755 (encode_terminal_code, calculate_costs): Check for size
6756 calculation overflow.
6757 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6758 table lengths and related sizes. Don't update size until alloc
6759 done. Redo calculations to avoid overflow.
6760 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6761
6762 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6763 subtracting pointers.
6764 (gobble_line): Check for overflow more carefully. Don't update size
6765 until alloc done.
6766
6767 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6768 Don't update size until alloc done.
6769 Redo size calculations to avoid overflow.
6770 Check for size calculation overflow.
0065d054 6771 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6772
6773 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6774 Use ptrdiff_t, not int, for sizes.
6775 (store_mode_line_noprop_char): Don't update size until alloc done.
6776
0065d054
PE
6777 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6778 Use ptrdiff_t, not int, for sizes.
6779 (Finternal_make_lisp_face, cache_face):
6780 Check for size calculation overflow.
6781 (cache_face): Treat size calculation overflows as if they were
6782 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6783
6784 * xfns.c (x_encode_text, x_set_name_internal)
6785 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6786 sizes, since they can exceed INT_MAX in size. Check for size
6787 calculation overflow.
6788
0065d054
PE
6789 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6790 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6791 Don't update size until alloc done.
6792
0065d054 6793 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6794 as sprintf is limited to int lengths.
1d526e2f 6795
252c5ee1
PE
6796 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6797 (X_LONG_MIN): New macros.
864d7ce7
PE
6798 Use them to make the following changes clearer.
6799 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6800 This change doesn't affect the value now, but it may help remind
6801 future maintainers not to raise the value too much later.
6802 (SELECTION_QUANTUM): Remove, replacing with ...
6803 (selection_quantum): ... new function, which avoids overflow.
6804 All uses changed.
6805 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6806 assumption that selection length fits in 'int'.
6807 (x_reply_selection_request, x_handle_selection_request)
6808 (x_get_window_property, receive_incremental_selection)
6809 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6810 (lisp_data_to_selection_data, clean_local_selection_data):
6811 Use ptrdiff_t, not int, to record length of selection.
6812 (x_reply_selection_request, x_get_window_property)
6813 (receive_incremental_selection, x_property_data_to_lisp):
6814 Redo calculations to avoid overflow.
6815 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6816 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6817 something.
6818 (x_get_window_property, receive_incremental_selection)
6819 (lisp_data_to_selection_data, x_property_data_to_lisp):
6820 Check for size-calculation overflow.
6821 (x_get_window_property, receive_incremental_selection)
6822 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6823 Don't store size until memory allocation succeeds.
6824 (x_get_window_property): Plug memory leak on memory exhaustion.
6825 Don't double-block input; malloc is safe here. Don't assume 2**34
6826 - 4 fits in unsigned long. Add an xassert to check
6827 XGetWindowProperty overflow. Be more careful about overflow
6828 calculations, and distinguish size from memory overflow better.
6829 (receive_incremental_selection): When tracing, don't assume
6830 unsigned int is less than INT_MAX.
6831 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6832 harmful) conversions of unsigned short to int.
6833 (lisp_data_to_selection_data): Don't assume that integers
6834 in the range -65535 through -1 fit in an X unsigned short.
6835 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6836 result parameters unless successful. Rely on cons_to_unsigned
6837 to report problems with elements; the old code wasn't right anyway.
6838 (x_check_property_data): Check for int overflow; we cannot use
6839 a wider type due to X limits.
6840 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6841
726e0ab1 6842 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6843
0065d054
PE
6844 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6845 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6846 (x_color_cells): Don't store size until memory allocation succeeds.
6847 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6848 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6849 (x_term_init): Don't assume length fits in int (sprintf is limited
6850 to int size).
bc18e09d 6851
ebfa62c0
PE
6852 Use ptrdiff_t for composition IDs.
6853 * character.c (lisp_string_width):
6854 * composite.c (composition_table_size, n_compositions)
6855 (get_composition_id, composition_gstring_from_id):
6856 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6857 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6858 * window.c (Frecenter):
6859 Use ptrdiff_t, not int, for composition IDs.
6860 * composite.c (get_composition_id): Check for integer overflow.
6861 * composite.h: Adjust prototypes to match the above changes.
6862
d3411f89
PE
6863 Use ptrdiff_t for hash table indexes.
6864 * category.c (hash_get_category_set):
6865 * ccl.c (ccl_driver):
6866 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6867 * coding.c (coding_system_charset_list, detect_coding_system):
6868 * coding.h (struct coding_system.id):
6869 * composite.c (get_composition_id, gstring_lookup_cache):
6870 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6871 * image.c (xpm_get_color_table_h):
6872 * lisp.h (hash_lookup, hash_put):
6873 * minibuf.c (Ftest_completion):
6874 Use ptrdiff_t for hash table indexes, not int (which is too
6875 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6876 32-bit --with-wide-int hosts).
6877
e097a6fa
PE
6878 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6879 Add a FIXME comment about memory leaks.
6880 (syms_of_charset): Don't assume xmalloc returns.
6881
5637687f
PE
6882 Don't assume that stated character widths fit in int.
6883 * character.c (Fchar_width, c_string_width, lisp_string_width):
6884 * character.h (CHAR_WIDTH):
6885 * indent.c (MULTIBYTE_BYTES_WIDTH):
6886 Use sanitize_char_width to avoid undefined and/or bad behavior
6887 with outlandish widths.
a66cfb1c 6888 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6889 now that we have two such functions. All uses changed.
6890 (sanitize_char_width): New inline function.
6891
a2271ba2
PE
6892 Don't assume that tab-width fits in int.
6893 * character.h (sanitize_width): New inline function.
6894 (SANE_TAB_WIDTH): New macro.
6895 (ASCII_CHAR_WIDTH): Use it.
6896 * indent.c (sane_tab_width): Remove. All uses replaced by
6897 SANE_TAB_WIDTH (current_buffer).
6898 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6899
18c52557
PE
6900 * fileio.c: Integer overflow issues with file modes.
6901 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6902
caeeedc1
PE
6903 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6904 Remove unreachable code.
6905 (read_hex, load_charset_map_from_file): Check for integer overflow.
6906
6df6ae42 6907 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6908 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6909 (x_send_scroll_bar_event): Likewise. Check that the size does not
6910 exceed limits imposed by XClientMessageEvent, as well as the usual
6911 ptrdiff_t and size_t limits.
6912
b13995db
PE
6913 * keyboard.c: Overflow, signedness and related fixes.
6914 (make_lispy_movement): Use same integer type in forward decl
6915 that is used in the definition.
6916 (read_key_sequence, keyremap_step):
6917 Change bufsize argument back to int, undoing my 2011-03-30 change.
6918 We prefer signed types, and int is wide enough here.
6919 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6920 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6921 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6922 length, not size_t. Use ptrdiff_t for index, not int.
6923 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6924 possibility of integer overflow.
6925
13464394
PE
6926 Overflow, signedness and related fixes for images.
6927
6928 * dispextern.h (struct it.stack[0].u.image.image_id)
6929 (struct_it.image_id, struct image.id, struct image_cache.size)
6930 (struct image_cache.used, struct image_cache.ref_count):
6931 * gtkutil.c (update_frame_tool_bar):
6932 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6933 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6934 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6935 * nsmenu.m (update_frame_tool_bar):
6936 * xdisp.c (calc_pixel_width_or_height):
6937 * xfns.c (image_cache_refcount):
6938 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6939 on typical 64-bit hosts.
6940
6941 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6942 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6943 Omit unnecessary casts to int.
6944 (parse_image_spec): Check that integers fall into 'int' range
6945 when the callers expect that.
6946 (image_ascent): Redo ascent calculation to avoid int overflow.
6947 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6948 (lookup_image): Remove unnecessary tests.
6949 (xbm_image_p): Locals are now of int, not EMACS_INT,
6950 since parse_image_check makes sure they fit into int.
6951 (png_load, gif_load, svg_load_image):
6952 Prefer int to unsigned where either will do.
6953 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6954 old tiff_error_handler and tiff_warning_handler.
6955 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6956 stack buffer overflows. It uses only the features of vsnprintf
6957 that are common to both POSIX and native Microsoft.
6958 (tiff_error_handler, tiff_warning_handler): Use it.
6959 (tiff_load, gif_load, imagemagick_load_image):
6960 Don't assume :index value fits in 'int'.
6961 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6962 (imagemagick_load_image): Check that crop parameters fit into
6963 the integer types that MagickCropImage accepts. Don't assume
6964 Vimagemagick_render_type has a nonnegative value. Don't assume
6965 size_t fits in 'long'.
6966 (gs_load): Use printmax_t to print the widest integers possible.
6967 Check for integer overflow when computing image height and width.
6968
c11821d4
EZ
69692011-08-26 Eli Zaretskii <eliz@gnu.org>
6970
6971 * xdisp.c (redisplay_window): Don't force window start if point
6972 will be invisible in the resulting window. (Bug#9324)
6973
0c95fcf7
EZ
69742011-08-25 Eli Zaretskii <eliz@gnu.org>
6975
6976 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6977 the display spec is of the form `(space ...)'.
6978 (handle_display_spec): Return the value returned by
6979 handle_single_display_spec, not just 1 or zero.
6980 (handle_single_display_spec): If the display spec is of the form
6981 `(space ...)', and specifies display in the text area, return 2
6982 rather than 1.
fee65a97 6983 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6984 accurately, and prefer exact match for point under bidi.
6985 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6986
6987 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6988 into disp_prop; all users changed.
6989
6990 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6991 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6992 for the text covered by the display property.
6993
e4ed06f1
CY
69942011-08-25 Chong Yidong <cyd@stupidchicken.com>
6995
6996 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6997 Change return value to nil.
6998 (Frecord_buffer): Delete unused function.
6999
f67cdd7f
EZ
70002011-08-24 Eli Zaretskii <eliz@gnu.org>
7001
5980d4c6
EZ
7002 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7003 buffers, return left-to-right.
8610fe8b
EZ
7004 (set_cursor_from_row): Consider candidate row a win if its glyph
7005 represents a newline and point is on that newline. Fixes cursor
7006 positioning on the newline at EOL of R2L text within L2R
7007 paragraph, and vice versa.
7008 (try_cursor_movement): Check continued rows, in addition to
7009 continuation rows. Fixes unwarranted scroll when point enters a
7010 continued line of R2L text within an L2R paragraph, or vice versa.
7011 (cursor_row_p): Consider the case of point being equal to
7012 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7013 from the end of a short line to the beginning of a continued line
7014 of R2L text within L2R paragraph.
7015 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7016 composed characters.
5980d4c6 7017
f67cdd7f
EZ
7018 * bidi.c (bidi_check_type): Use xassert.
7019 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7020 members.
7021
bca633fb
EZ
70222011-08-23 Eli Zaretskii <eliz@gnu.org>
7023
7024 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7025 a character.
7026
4a5885a7
CY
70272011-08-23 Chong Yidong <cyd@stupidchicken.com>
7028
7029 * nsfont.m (ns_otf_to_script): Fix typo.
7030
0902a04e
KH
70312011-08-22 Kenichi Handa <handa@m17n.org>
7032
7033 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7034 extra slot even if the purpose is char-code-property-table.
7035
1a2e6670
EZ
70362011-08-23 Eli Zaretskii <eliz@gnu.org>
7037
8ddde651
EZ
7038 * xdisp.c (redisplay_window): When computing centering_position,
7039 account for the height of the header line. (Bug#8874)
7040
425cc014
EZ
7041 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7042 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7043 candidate is selected by the mouse, and that candidate has a
7044 composed character under the mouse.
7045
1a2e6670
EZ
7046 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7047 coordinates reported by pos-visible-in-window-p for a composed
7048 character in column zero.
7049
8b76d6f8
SM
70502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7051
7052 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7053
dac347dd
EZ
70542011-08-22 Eli Zaretskii <eliz@gnu.org>
7055
7056 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7057 consider it a hit if to_charpos is anywhere in the range of the
7058 composed buffer positions.
7059
e013fb34
CY
70602011-08-22 Chong Yidong <cyd@stupidchicken.com>
7061
7062 * image.c (gif_load): Don't assume that each subimage has the same
7063 dimensions as the base image. Handle disposal method that is
7064 "undefined" by the gif spec (Bug#9335).
7065
bd1ba3e8
CY
70662011-08-20 Chong Yidong <cyd@stupidchicken.com>
7067
7068 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7069 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7070
54a1215b
EZ
70712011-08-19 Eli Zaretskii <eliz@gnu.org>
7072
823564e5
EZ
7073 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7074 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7075 from an Org mode buffer to a Speedbar frame.
7076
54a1215b
EZ
7077 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7078 a composition, take its buffer position from IT->cmp_it.charpos.
7079 Fixes cursor positioning at the beginning of a line that begins
7080 with a composed character.
7081
9778ebcc
EZ
70822011-08-18 Eli Zaretskii <eliz@gnu.org>
7083
0be6ee06
EZ
7084 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7085 character bidirectional type, use STRONG_L instead. Fixes crashes
7086 in a buffer produced by `describe-categories'.
7087
9778ebcc
EZ
7088 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7089 members before the level stack, so they would be saved and
7090 restored when copying iterator state. Fixes incorrect reordering
7091 around TABs covered by display properties.
7092
156bffbe
AS
70932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7094
6b02f655 7095 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7096
72ad093b
CY
70972011-08-17 Chong Yidong <cyd@stupidchicken.com>
7098
7099 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7100 (internal_condition_case_2, internal_condition_case_n):
7101 Remove unnecessary aborts (Bug#9081).
72ad093b 7102
35774242
EZ
71032011-08-17 Eli Zaretskii <eliz@gnu.org>
7104
7105 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7106 has no `load' handler, try opening the file locally. (Bug#9311)
7107
db76dd85
KB
71082011-08-16 Ken Brown <kbrown@cornell.edu>
7109
7110 * gmalloc.c: Expand comment.
7111
b215eee5
EZ
71122011-08-16 Eli Zaretskii <eliz@gnu.org>
7113
7114 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7115 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7116
a4579d33
KB
71172011-08-16 Ken Brown <kbrown@cornell.edu>
7118
7119 Fix memory allocation problems in Cygwin build (Bug#9273).
7120
7121 * unexcw.c ( __malloc_initialized): Declare external variable.
7122 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7123
8b76d6f8
SM
7124 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7125 New variables.
a4579d33
KB
7126 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7127 dumped emacs.
7128 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7129 in the static heap.
7130 [CYGWIN] (special_realloc): New function.
7131 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7132 requests to realloc storage in the static heap.
7133
3ebec551
PE
71342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 * bidi.c (bidi_initialize): Remove unused local.
7137
9fd8be00
EZ
71382011-08-15 Eli Zaretskii <eliz@gnu.org>
7139
6b02f655
SM
7140 * bidimirror.h:
7141 * biditype.h: Remove file.
7142 * makefile.w32-in ($(BLD)/bidi.$(O)):
7143 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7144
7145 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7146
7147 * chartab.c: Improve commentary for the uniprop_table API.
7148
32413314
EZ
7149 * bidi.c (bidi_paragraph_init): Support zero value of
7150 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7151 (bidi_initialize): Use uniprop_table instead of including
7152 biditype.h and bidimirror.h.
32413314 7153
9fd8be00
EZ
7154 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7155 coordinates of the iterator when restoring from ppos_it.
7156 (Bug#9296)
7157
5cf2b69b
KH
71582011-08-14 Kenichi Handa <handa@m17n.org>
7159
7160 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7161 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7162
daf17d00
EZ
71632011-08-14 Eli Zaretskii <eliz@gnu.org>
7164
7165 * xdisp.c (move_it_in_display_line_to): Don't invoke
7166 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7167 ppos_it. Fixes vertical cursor motion when line beginning is
7168 covered by an image. (Bug#9296)
7169
08e3161a
JD
71702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7171
7172 * nsterm.h (ns_run_ascript): Declare.
7173 (NSAPP_DATA2_RUNASSCRIPT): Define.
7174
7175 * nsfns.m (as_script, as_result, as_status): New static variables.
7176 (ns_run_ascript): New function.
5e617bc2 7177 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7178 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7179 the event loop. Get status from as_status (Bug#7276).
7180
7181 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7182 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7183 the event loop (Bug#7276).
7184
a3720aa2
AS
71852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7186
7187 * gnutls.c (QCgnutls_bootprop_priority)
7188 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7189 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7190 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7191 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7192 (QCgnutls_bootprop_verify_hostname_error)
7193 (QCgnutls_bootprop_callbacks_verify): Rename from
7194 Qgnutls_bootprop_..., all uses changed.
7195
7196 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7197 uses changed.
7198
0a0d27fb
PE
71992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7200
19d5c50c
PE
7201 * xfaces.c (Qframe_set_background_mode): Now static.
7202 * dispextern.h (Qframe_set_background_mode): Remove decl.
7203
0a0d27fb
PE
7204 * process.c (Fnetwork_interface_info): Declare local only if needed.
7205
377538cb
JD
72062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7207
7208 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7209 (Fnetwork_interface_list): Allocate in increments of bytes instead
7210 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7211 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7212 sockaddr.
7213 (struct ifflag_def): notrailers is smart on OSX.
7214 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7215 Get hardware address with getifaddrs if available.
7216
08fff70c
EZ
72172011-08-12 Eli Zaretskii <eliz@gnu.org>
7218
7219 * xdisp.c (iterate_out_of_display_property): xassert that
7220 IT->position is set to within IT->object's boundaries. Break from
7221 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7222 when IT->position is set up wrongly due to some bug.
7223 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7224 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7225 entry. Force push_it to save on the stack the current
7226 buffer/string position, to be restored by pop_it. Fix flags in
7227 the iterator structure wrt the object coming from a display
7228 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7229 properties. (Bug#9284)
7230
7be1c708 72312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7232
7be1c708
CY
7233 * fontset.c (fontset_get_font_group): Add proper type checks.
7234 (Bug#9172)
aac0c6e3 7235
7be1c708 72362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7237
7be1c708
CY
7238 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7239 and LC_VERSION_MIN_MACOSX.
7240 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7241 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7242
97bb72a6
EZ
72432011-08-08 Eli Zaretskii <eliz@gnu.org>
7244
7245 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7246 no-display-properties-and-no-overlays under bidi display.
7247 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7248 properties and overlays.
97bb72a6 7249
d5617611
CY
72502011-08-08 Chong Yidong <cyd@stupidchicken.com>
7251
37e11a63
CY
7252 * editfns.c (Fset_time_zone_rule): Document relationship with the
7253 setenv function.
7254
d5617611
CY
7255 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7256 the font entity extracted from the cache (Bug#8109).
7257
58872834
CY
72582011-08-07 Chong Yidong <cyd@stupidchicken.com>
7259
7260 * composite.c (autocmp_chars): Don't reset point. That is done by
7261 restore_point_unwind (Bug#5984).
7262
75bfc667
JL
72632011-08-07 Juri Linkov <juri@jurta.org>
7264
7265 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7266 to show the arg `TIME' instead of `TIMEVAL'.
7267
d1410150
EZ
72682011-08-06 Eli Zaretskii <eliz@gnu.org>
7269
7270 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7271 display property strides EOL and includes a newline, as in
7272 longlines-mode. (Bug#9254)
75b771e4
EZ
7273 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7274 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7275
7276 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7277 is non-zero, even if the data buffer is NULL. Fixes a crash in
7278 vertical-motion with longlines-mode. (Bug#9254)
7279
35928349
EZ
72802011-08-05 Eli Zaretskii <eliz@gnu.org>
7281
ec7cc85b
EZ
7282 * bidi.c <bidi_cache_total_alloc>: Now static.
7283 (bidi_initialize): Initialize bidi_cache_total_alloc.
7284
8b76d6f8 7285 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7286 cache. (Bug#9221)
7287
7288 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7289 amount allocated this far in `bidi_cache_total_alloc'.
7290 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7291 non-zero, only free the data buffer without restoring the cache
7292 contents. All callers changed.
7293
7294 * dispextern.h (bidi_unshelve_cache): Update prototype.
7295
7296 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7297 (move_it_in_display_line, move_it_to)
7298 (move_it_vertically_backward, move_it_by_lines): Replace the call
7299 to xfree to an equivalent call to bidi_unshelve_cache.
7300 (move_it_in_display_line_to): Fix logic of returning
412b6358 7301 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7302
e2e2423b
EZ
73032011-08-05 Eli Zaretskii <eliz@gnu.org>
7304
7305 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7306 came from a string character with a `cursor' property. (Bug#9229)
7307
ae9e757a
JD
73082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7309
7310 * Makefile.in (LIB_PTHREAD): New variable.
7311 (LIBES): Add LIB_PTHREAD (Bug#9216).
7312
7313 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7314 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7315
213bd7f2
AS
73162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7317
6b02f655 7318 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7319
99aaf75f
JD
73202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7321
7322 * xterm.c (x_find_topmost_parent): New function.
7323 (x_set_frame_alpha): Find topmost parent window with
7324 x_find_topmost_parent and set the property there also (bug#9181).
7325 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7326
c74e9d86
PE
73272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7328
7329 * callproc.c (Fcall_process): Avoid vfork clobbering
7330 the local vars buffer, coding_systems, current_dir.
7331
640c8776
SM
73322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7333
7334 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7335
f26d0e4c
PE
73362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7337
8a10d76c
PE
7338 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7339 so that it is not optimized away.
7340
f26d0e4c
PE
7341 * xdisp.c (compute_display_string_pos): Remove unused local.
7342
55439c61
EZ
73432011-08-02 Eli Zaretskii <eliz@gnu.org>
7344
7345 Fix slow cursor motion and scrolling in large buffers with
7346 selective display, like Org Mode buffers. (Bug#9218)
7347
7348 * dispextern.h (struct bidi_it): New member disp_prop_p.
7349
7350 * xdisp.c: Remove one-slot cache of display string positions.
7351 (compute_display_string_pos): Accept an additional argument
5e617bc2 7352 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7353 for a display string or property. If found, set DISP_PROP_P
7354 non-zero.
7355
7356 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7357 DISP_PROP_P, and pass it to compute_display_string_pos.
7358 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7359 non-zero. All callers of bidi_fetch_char changed.
7360
fb33fa43
SM
73612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7362
7363 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7364
b099e063
DM
73652010-12-03 Don March <don@ohspite.net>
7366
7367 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7368 last character M-[char] is translated to ESC [char] (bug#7541).
7369
5cc7f7af
KH
73702011-08-02 Kenichi Handa <handa@m17n.org>
7371
d0fffa3f 7372 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7373
7374 * chartab.c (uniprop_table): Make it non-static.
7375
525d5e6e
EZ
73762011-08-01 Eli Zaretskii <eliz@gnu.org>
7377
7378 * xdisp.c (forward_to_next_line_start): Accept additional argument
7379 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7380 on the newline.
7381 (reseat_at_next_visible_line_start): Use the bidi iterator state
7382 returned by forward_to_next_line_start to restore the state of
7383 it->bidi_it after backing up to previous newline. (Bug#9212)
7384
31011111
AS
73852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7386
7387 * regex.c (re_comp): Protoize.
7388 (re_exec): Fix return type.
7389 (regexec): Fix type of `ret'. (Bug#9203)
7390
476371c4
PE
73912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7392
e5d76069
PE
7393 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7394 This is needed if max-image-size is a floating-point number.
7395
9a79b20c
AS
73962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7397
7398 * print.c (print_object): Print empty symbol as ##.
7399
7400 * lread.c (read1): Read ## as empty symbol.
7401
d8c2fa78
AA
74022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7403
7404 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7405 setting frame foreground color (Bug#9175).
7406 (x_set_background_color): Likewise.
7407
ffe57a7a
AA
7408 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7409 contents (Bug#9176).
7410 (EmacsTooltip -init): Remove bezels and add shadows to
7411 tooltip windows.
7412
bf3492a5
AA
7413 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7414 or scroll bar (Bug#8470).
7415
d55e9c53
AA
7416 * nsfont.m (nsfont_open): Remove assignment to voffset and
7417 unnecessary vars hshink, expand, hd, full_height, min_height.
7418 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7419
7420 * nsterm.h (nsfont_info): Remove voffset field.
7421
d8c2fa78 74222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7423
7424 Implement strike-through and overline on NextStep (Bug#8863).
7425
7426 * nsfont.m (nsfont_open): Use underline position provided by font,
7427 instead of hard-coded value of 2.
7428 (nsfont_draw): Call ns_draw_text_decoration instead.
7429
7430 * nsterm.h: Add declaration for ns_draw_text_decoration.
7431
7432 * nsterm.m (ns_draw_text_decoration): New function for drawing
7433 underline, overline, and strike-through.
7434 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7435 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7436 accommodate underlining, etc.
4843aac3 7437
4cc60b9b
EZ
74382011-07-28 Eli Zaretskii <eliz@gnu.org>
7439
bc7ece87
EZ
7440 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7441 default.
4cc60b9b 7442
476371c4
PE
74432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7444
66606eea
PE
7445 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7446 Without this fix, if a signal arrives just after memory fills up,
7447 'malloc' might be invoked reentrantly.
7448
476371c4
PE
7449 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7450 In other words, assume that every image size is allowed, on non-X
7451 hosts. This assumption is probably wrong, but it lets Emacs compile.
7452
f3fcc40d
AS
74532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7454
7455 * regex.c (re_iswctype): Convert return values to boolean.
7456
350c992f
EZ
74572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7458
7459 * xdisp.c (compute_display_string_pos): Don't use cached display
7460 string position if the buffer had its restriction changed.
7461 (Bug#9184)
7462
5266b4bb
PE
74632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7464
7465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7466
2573a837 74672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7468
41f55ccd 7469 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7470
39e378da
PE
7471 * bidi.c: Integer size and overflow fixes.
7472 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7473 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7474 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7475 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7476 (bidi_find_other_level_edge):
7477 Use ptrdiff_t instead of EMACS_INT where either will do.
7478 This works better on 32-bit hosts configured --with-wide-int.
7479 (bidi_cache_ensure_space): Check for size-calculation overflow.
7480 Use % rather than repeated addition, for better worst-case speed.
7481 Don't set bidi_cache_size until after xrealloc returns, because it
7482 might not return.
7483 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7484 (bidi_cache_ensure_space): Also check that the bidi cache size
7485 does not exceed that of the largest Lisp string or buffer. See Eli
7486 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7487
5e927815
PE
7488 * alloc.c (__malloc_size_t): Remove.
7489 All uses replaced by size_t. See Andreas Schwab's note
7490 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7491
ca4aa935
PE
7492 * image.c: Improve checking for integer overflow.
7493 (check_image_size): Assume that f is nonnull, since
7494 it is always nonnull in practice. This is one less thing to
7495 worry about when checking for integer overflow later.
7496 (x_check_image_size): New function, which checks for integer
7497 overflow issues inside X.
7498 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7499 This removes the need for a memory_full check.
7500 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7501 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7502 (xbm_read_bitmap_data): Change locals back to 'int', since
7503 their values must fit in 'int'.
7504 (xpm_load_image, png_load, tiff_load):
7505 Invoke x_create_x_image_and_pixmap earlier,
7506 to avoid much needless work if the image is too large.
7507 (tiff_load): Treat overly large images as if
7508 x_create_x_image_and_pixmap failed, not as malloc failures.
7509 (gs_load): Use x_check_image_size.
7510
5f8f9cc2
PE
7511 * gtkutil.c: Omit integer casts.
7512 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7513 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7514
5adf60bc
PE
7515 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7516
c8907a93
PE
7517 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7518 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7519 would wrongly return t on a 64-bit host.
7520
e3c25c68
PE
7521 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7522 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7523 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7524 and therefore cause GCC to emit a bogus diagnostic in some cases.
7525
3f791afe
PE
7526 * image.c: Integer signedness and overflow and related fixes.
7527 This is not an exhaustive set of fixes, but it's time to
7528 record what I've got.
7529 (lookup_pixel_color, check_image_size): Remove redundant decls.
7530 (check_image_size): Don't assume that arbitrary EMACS_INT values
7531 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7532 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7533 (tiff_load, imagemagick_load_image):
7534 Check for overflow in size calculations.
7535 (x_create_x_image_and_pixmap): Remove unnecessary test for
7536 xmalloc returning NULL; that can't happen.
7537 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7538 (xpm_color_bucket): Use better integer hashing function.
7539 (xpm_cache_color): Don't possibly over-allocate memory.
7540 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7541 (gif_memory_source):
7542 Use ptrdiff_t, not int or size_t, to record sizes.
7543 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7544 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7545 either works, as we prefer signed integers.
7546 (tiff_read_from_memory, tiff_write_from_memory):
7547 Return tsize_t, not size_t, since that's what the TIFF API wants.
7548 (tiff_read_from_memory): Don't fail simply because the read would
7549 go past EOF; instead, return a short read.
7550 (tiff_load): Omit no-longer-needed casts.
7551 (Fimagemagick_types): Don't assume size fits into 'int'.
7552
3cc5a532
PE
7553 Improve hashing quality when configured --with-wide-int.
7554 * fns.c (hash_string): New function, taken from sxhash_string.
7555 Do not discard information about ASCII character case; this
7556 discarding is no longer needed.
7557 (sxhash-string): Use it. Change sig to match it. Caller changed.
7558 * lisp.h: Declare it.
7559 * lread.c (hash_string): Remove, since we now use fns.c's version.
7560 The fns.c version returns a wider integer if --with-wide-int is
7561 specified, so this should help the quality of the hashing a bit.
7562
b312a492
PE
7563 * emacs.c: Integer overflow minor fix.
7564 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7565 Define only if GNU_LINUX.
7566 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7567
dfd153ae
PE
7568 * dispnew.c: Integer signedness and overflow fixes.
7569 Remove unnecessary forward decls, that were a maintenance hassle.
7570 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7571 All uses changed.
7572 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7573 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7574 (prepare_desired_row, line_draw_cost):
7575 Use int, not unsigned, where either works.
7576 (save_current_matrix, restore_current_matrix):
7577 Use ptrdiff_t, not size_t, where either works.
7578 (init_display): Check for overflow more accurately, and without
7579 relying on undefined behavior.
7580
a81d11a3
PE
7581 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7582 Remove, replacing with the new symbols in lisp.h. All uses changed.
7583 * fileio.c (make_temp_name):
7584 * filelock.c (lock_file_1, lock_file):
7585 * xdisp.c (message_dolog):
7586 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7587 Use pMd etc. instead.
7588 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7589 replacing the pWIDE etc. symbols removed from editfns.c.
7590
3300e6fd
PE
7591 * keyboard.h (num_input_events): Now uintmax_t.
7592 This is (very slightly) less likely to mess up due to wraparound.
7593 All uses changed.
7594
fd05c7e9
PE
7595 * buffer.c: Integer signedness fixes.
7596 (alloc_buffer_text, enlarge_buffer_text):
7597 Use ptrdiff_t rather than size_t when either will do, as we prefer
7598 signed integers.
7599
903fe15d
PE
7600 * alloc.c: Integer signedness and overflow fixes.
7601 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7602 (__malloc_size_t): Default to size_t, not to int.
7603 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7604 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7605 Prefer ptrdiff_t to size_t when either would do, as we prefer
7606 signed integers.
7607 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7608 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7609 Now const. Initialize with values that are in range even if char
7610 is signed.
7611 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7612 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7613 These functions do the right thing with sizes > 2**32.
7614 (check_depth): Now ptrdiff_t, not int.
7615 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7616 Adjust to new way of storing sizes. Check for size overflow bugs
7617 in rest of code.
7618 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7619 slightly wrong anyway, as it missed one instance of
7620 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7621 (refill_memory_reserve): Omit needless cast to size_t.
7622 (mark_object_loop_halt): Mark as externally visible.
7623
ac82cc6a
PE
7624 * xselect.c: Integer signedness and overflow fixes.
7625 (Fx_register_dnd_atom, x_handle_dnd_message):
7626 Use ptrdiff_t, not size_t, since we prefer signed.
7627 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7628 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7629 x_dnd_atoms_size and x_dnd_atoms_length.
7630
c2d1e36d
PE
7631 * doprnt.c: Prefer signed to unsigned when either works.
7632 * eval.c (verror):
7633 * doprnt.c (doprnt):
7634 * lisp.h (doprnt):
7635 * xdisp.c (vmessage):
7636 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7637 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7638 prefer signed arithmetic to avoid comparison confusion.
7639 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7640 but is a bit tricky.
7641
0e926e56
PE
7642 Assume freestanding C89 headers, string.h, stdlib.h.
7643 * data.c, doprnt.c, floatfns.c, print.c:
7644 Include float.h unconditionally.
7645 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7646 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7647 * regex.c: Likewise for stddef.h, string.h.
7648 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7649 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7650 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7651 (STDC_HEADERS): Remove obsolete defines.
7652 * sysdep.c: Include limits.h unconditionally.
7653
9cfdb3ec
PE
7654 Assume support for memcmp, memcpy, memmove, memset.
7655 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7656 * regex.c (memcmp, memcpy):
7657 Remove; we assume C89 now.
7658
7659 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7660 (__malloc_safe_bcopy): Remove; no longer needed.
7661
cf950e6b 7662 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7663 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7664 well either way, and we prefer signed to unsigned.
7665
dbf38e02
LMI
76662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7667
7668 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7669 closes the connection while we're reading (bug#9182).
7670
d6f0886c 76712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7672
d6f0886c
JD
7673 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7674 are specified (Bug#9168).
24e0f6b1 7675
2eb1f9e6
PE
76762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7677
7678 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7679 Found by GCC static checking and --with-wide-int on a 32-bit host.
7680
22381272 76812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7682
7683 * xdisp.c (compute_display_string_pos): Fix logic of caching
7684 previous display string position. Initialize cached_prev_pos to
7685 -1. Fixes slow-down at the beginning of a buffer.
7686
f25e39b4
EZ
76872011-07-24 Eli Zaretskii <eliz@gnu.org>
7688
7689 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7690 for attrs[LFACE_FONTSET_INDEX].
7691
04c4b52e
PE
76922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7693
7694 * xml.c (parse_region): Remove unused local
7695 that was recently introduced.
7696
c1734fbd
EZ
76972011-07-23 Eli Zaretskii <eliz@gnu.org>
7698
be18c5a5
EZ
7699 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7700 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7701
c1734fbd
EZ
7702 * xdisp.c (move_it_in_display_line_to): Record the best matching
7703 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7704 exit if none of the characters scanned was an exact match.
7705 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7706 when exact match is impossible due to invisible text, and the
7707 lines are truncated.
7708
a258d627
JD
77092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7710
7711 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7712 for OSX >= 10.7.
7713
b6d5a689
EZ
77142011-07-22 Eli Zaretskii <eliz@gnu.org>
7715
0f74f785
EZ
7716 Fix a significant slow-down of cursor motion with C-n, C-p,
7717 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7718 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7719 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7720 (next_element_from_buffer): Call compute_stop_pos_backwards to
7721 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7722 base_level_stop.
7723 (reseat): Don't look for prev_stop, as that could mean a very long
7724 run.
7725 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7726 <cached_disp_overlay_modiff>: Cache for last found display string
7727 position.
551918c1 7728 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7729 about the same buffer in the same area of character positions, and
7730 the buffer wasn't changed since the time the display string
7731 position was cached.
551918c1 7732
b2d0c91a
EZ
77332011-07-22 Eli Zaretskii <eliz@gnu.org>
7734
7735 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7736 is an integer, which is important for empty lines. (Bug#9149)
7737
043604ee
CY
77382011-07-22 Chong Yidong <cyd@stupidchicken.com>
7739
7740 * frame.c (Fmodify_frame_parameters): In tty case, update the
7741 default face if necessary (Bug#4238).
7742
da4adb04
CY
77432011-07-21 Chong Yidong <cyd@stupidchicken.com>
7744
7745 * editfns.c (Fstring_to_char): No need to explain what a character
7746 is in the docstring (Bug#6576).
7747
9abd0532
LMI
77482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7749
7750 * xml.c (parse_region): Make sure we always return a tree.
7751
36881d16
HK
77522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7753
7754 * xml.c (parse_region): If a document contains only comments,
7755 return that, too.
7756
1e98674d
LMI
77572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7758
7759 * xml.c (make_dom): Return comments, too.
7760
590bd467
PE
77612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7762
7763 Port to OpenBSD.
7764 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7765 and the surrounding thread.
7766 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7767 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7768 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7769 timer goes off.
7770 * s/openbsd.h (BROKEN_SIGIO): Define.
7771 * unexelf.c (unexec) [__OpenBSD__]:
7772 Don't update the .mdebug section of the Alpha COFF symbol table.
7773
f41628b2
LMI
77742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7775
7776 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7777 (bug#8460).
7778
b59b67c5
PE
77792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7780
15e3a074
PE
7781 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7782 This fixes some race conditions on the permissions of any newly
7783 created file.
7784
41bed37d
PE
7785 * alloc.c (valid_pointer_p): Use pipe, not open.
7786 This fixes some permissions issues when debugging.
7787
b59b67c5
PE
7788 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7789 If fchown fails to set both uid and gid, try to set just gid,
7790 as that is sometimes allowed. Adjust the file's mode to eliminate
7791 setuid or setgid bits that are inappropriate if fchown fails.
7792
925a6be7
SM
77932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7794
7795 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7796 to compare Lisp_Objects.
7797 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7798 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7799 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7800
52968808
AS
78012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7802
0a6a104b
AS
7803 * lread.c (read_integer): Unread even EOF character.
7804 (read1): Likewise. Properly record start position of symbol.
7805
52968808
AS
7806 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7807 symbol character follows.
7808
9e381cdd
PE
78092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7810
7811 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7812 This works around a problem with the previous change to Fcopy_file.
7813 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7814 and without this change, GCC might complain about discarding
7815 fchown's return value.
7816
b5641435
JB
78172011-07-16 Juanma Barranquero <lekktu@gmail.com>
7818
7819 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7820
a8031457
PE
78212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7822
7823 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7824
dd889327
LMI
78252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7826
750c33f7
LMI
7827 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7828 it's used from the C level.
7829
dd889327
LMI
7830 * process.c: Use the same condition for POLL_FOR_INPUT in both
7831 keyboard.c and process.c (bug#1858).
7832
87e86684
LM
78332011-07-09 Lawrence Mitchell <wence@gmx.li>
7834
7835 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7836 (Fgnutls_boot): Use it.
7837
64348f40
AS
78382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7839
7840 * doc.c (Fsubstitute_command_keys): Revert last change.
7841
1d698799
LMI
78422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7843
f863868c
LMI
7844 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7845 quotes the next character, and doesn't affect other longer
7846 sequences (bug#8935).
7847
1d698799
LMI
7848 * lread.c (syms_of_lread): Clarify that is isn't only
7849 `eval-buffer' and `eval-defun' that's affected by
7850 `lexical-binding' (bug#8460).
7851
aa4b6df6
EZ
78522011-07-15 Eli Zaretskii <eliz@gnu.org>
7853
7854 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7855 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7856
5d856da6
PE
78572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7858
ad6042bb
PE
7859 Fix minor problems found by static checking.
7860 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7861 (elsz): Now a signed constant, not a size_t var. We prefer signed
7862 types to unsigned, to avoid integer comparison confusion. Without
7863 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7864 "cannot optimize loop, the loop counter may overflow", a symptom
7865 of the confusion.
f00bbb22 7866 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7867 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7868
6468f31c
LMI
78692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7870
49080b10
LMI
7871 * search.c (Fre_search_backward): Mention `case-fold-search' in
7872 all the re_search_* functions (bug#8138).
7873
6468f31c
LMI
7874 * keyboard.c (Fopen_dribble_file): Document when the file is
7875 closed (bug#8056).
7876
c965adc5
EZ
78772011-07-14 Eli Zaretskii <eliz@gnu.org>
7878
df9733bf
EZ
7879 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7880 bidi_cache_idx.
7881
0bb23927
EZ
7882 Support bidi reordering of display and overlay strings.
7883 * xdisp.c (compute_display_string_pos)
7884 (compute_display_string_end): Accept additional argument STRING.
7885 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7886 (reseat_to_string): Initialize bidi_it->string.s and
7887 bidi_it->string.schars.
7888 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7889 NULL (avoids a crash in bidi_paragraph_init).
7890 Initialize itb.string.lstring.
0bb23927
EZ
7891 (init_iterator): Call bidi_init_it only of a valid
7892 buffer position was specified. Initialize paragraph_embedding to
7893 L2R.
7894 (reseat_to_string): Initialize the bidi iterator.
7895 (display_string): If we need to ignore text properties of
7896 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7897 original value of -1 will not work with bidi.)
7898 (compute_display_string_pos): First arg is now struct
7899 `text_pos *'; all callers changed. Support display properties on
7900 Lisp strings.
7901 (compute_display_string_end): Support display properties on Lisp
7902 strings.
7903 (init_iterator, reseat_1, reseat_to_string): Initialize the
7904 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7905 when iterating on a string not from display properties).
640c8776
SM
7906 (compute_display_string_pos, compute_display_string_end):
7907 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7908 arrow keys.
7909 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7910 base_level_stop; instead, set base_level_stop to BEGV.
7911 Fixes crashes in vertical-motion.
0bb23927
EZ
7912 (next_element_from_buffer): Improve commentary for when
7913 the iterator is before prev_stop.
7914 (init_iterator): Initialize bidi_p from the default value of
7915 bidi-display-reordering, not from buffer-local value. Use the
7916 buffer-local value only if initializing for buffer iteration.
7917 (handle_invisible_prop): Support invisible properties on strings
7918 that are being bidi-reordered.
7919 (set_iterator_to_next): Support bidi reordering of C strings and
7920 Lisp strings.
7921 (next_element_from_string): Support bidi reordering of Lisp
7922 strings.
7923 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7924 (display_string): Support display of R2L glyph rows.
7925 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7926 (init_iterator): Don't initialize it->bidi_p for strings
7927 here.
7928 (reseat_to_string): Initialize it->bidi_p for strings here.
7929 (next_element_from_string, next_element_from_c_string)
7930 (next_element_from_buffer): Add xassert's for correspondence
7931 between IT's object being iterated and it->bidi_it.string
7932 structure.
7933 (face_before_or_after_it_pos): Support bidi iteration.
7934 (next_element_from_c_string): Handle the case of the first string
7935 character that is not the first one in the visual order.
7936 (get_visually_first_element): New function, refactored from common
7937 parts of next_element_from_buffer, next_element_from_string, and
7938 next_element_from_c_string.
7939 (tool_bar_lines_needed, redisplay_tool_bar)
7940 (display_menu_bar): Force left-to-right direction. Add a FIXME
7941 comment for making that be controlled by a user option.
7942 (push_it, pop_it): Save and restore the state of the
7943 bidi iterator. Save and restore the bidi_p flag.
7944 (pop_it): Iterate out of display property for string iteration as
7945 well.
7946 (iterate_out_of_display_property): Support iteration over strings.
7947 (handle_single_display_spec): Set up it->bidi_it for iteration
7948 over a display string, and call bidi_init_it.
7949 (handle_single_display_spec, next_overlay_string)
7950 (get_overlay_strings_1, push_display_prop): Set up the bidi
7951 iterator for displaying display or overlay strings.
7952 (forward_to_next_line_start): Don't use the shortcut if
7953 bidi-iterating.
7954 (back_to_previous_visible_line_start): If handle_display_prop
7955 pushed the iterator stack, restore the internal state of the bidi
7956 iterator by calling bidi_pop_it same number of times.
7957 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7958 and we are bidi-iterating, don't decrement the iterator position;
7959 instead, set the first_elt flag in the bidi iterator, to produce
7960 the same effect.
7961 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7962 (push_display_prop): xassert that we are iterating a buffer.
7963 (push_it, pop_it): Save and restore paragraph_embedding member.
7964 (handle_single_display_spec, next_overlay_string)
7965 (get_overlay_strings_1, reseat_1, reseat_to_string)
7966 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7967 correctly. Don't assume unibyte strings are not bidi-reordered.
7968 (compute_display_string_pos)
7969 (compute_display_string_end): Fix handling the case of C string.
7970 (push_it, pop_it): Save and restore from_disp_prop_p.
7971 (handle_single_display_spec, push_display_prop): Set the
7972 from_disp_prop_p flag.
7973 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7974 (pop_it): Call iterate_out_of_display_property only if we are
7975 popping after iteration over a string that came from a display
7976 property. Fix a typo in popping stretch info. Add an assertion
7977 for verifying that the iterator position is in sync with the bidi
7978 iterator.
7979 (handle_single_display_spec, get_overlay_strings_1)
7980 (push_display_prop): Fix initialization of paragraph direction for
7981 string when that of the parent object is not yet determined.
7982 (reseat_1): Call bidi_init_it to resync the bidi
7983 iterator with IT's position. (Bug#7616)
7984 (find_row_edges): If ROW->start.pos gives position
7985 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7986 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7987 Reset the from_disp_prop_p flag.
7988 (SAVE_IT, RESTORE_IT): New macros.
7989 (pos_visible_p, face_before_or_after_it_pos)
7990 (back_to_previous_visible_line_start)
7991 (move_it_in_display_line_to, move_it_in_display_line)
7992 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7993 (try_scrolling, redisplay_window, display_line): Use them when
7994 saving a temporary copy of the iterator and restoring it back.
7995 (back_to_previous_visible_line_start, reseat_1)
7996 (init_iterator): Empty the bidi cache "stack".
7997 (move_it_in_display_line_to): If iterator ended up at
7998 EOL, but we never saw any buffer positions smaller than
7999 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8000 motion in bidi-reordered lines.
8001 (move_it_in_display_line_to): Record prev_method and prev_pos
8002 immediately before the call to set_iterator_to_next. Fixes cursor
8003 motion in bidi-reordered lines with stretch glyphs and strings
8004 displayed in margins. (Bug#8133) (Bug#8867)
8005 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8006 TO_CHARPOS.
640c8776
SM
8007 (pos_visible_p): Support positions in bidi-reordered lines.
8008 Save and restore bidi cache.
0bb23927
EZ
8009
8010 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8011 (bidi_paragraph_info): Delete unused struct.
8012 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8013 (bidi_cache_start): New variable.
8014 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8015 to zero.
8016 (bidi_cache_fetch_state, bidi_cache_search)
8017 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8018 (bidi_cache_find, bidi_peek_at_next_level)
8019 (bidi_level_of_next_char, bidi_find_other_level_edge)
8020 (bidi_move_to_visually_next): Compare cache index with
8021 bidi_cache_start rather than with zero.
8022 (bidi_fetch_char): Accept new argument STRING; all callers
8023 changed. Support iteration over a string. Support strings with
8024 display properties. Support unibyte strings. Fix the type of
8025 `len' according to what STRING_CHAR_AND_LENGTH expects.
8026 (bidi_paragraph_init, bidi_resolve_explicit_1)
8027 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8028 (bidi_level_of_next_char, bidi_move_to_visually_next):
8029 Support iteration over a string.
0bb23927
EZ
8030 (bidi_set_sor_type, bidi_resolve_explicit_1)
8031 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8032 can now be zero (for strings); special values 0 and -1 were
8033 changed to -1 and -2, respectively.
8034 (bidi_char_at_pos): New function.
8035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8036 Call it instead of FETCH_MULTIBYTE_CHAR.
8037 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8038 initialized to valid values.
8039 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8040 values.
8041 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8042 the test for valid cached positions. Fix the logic for looking up
8043 the sentinel state in the cache. GCPRO the Lisp string we are
8044 iterating.
8045 (bidi_push_it, bidi_pop_it): New functions.
8046 (bidi_initialize): Initialize the bidi cache start stack pointer.
8047 (bidi_cache_ensure_space): New function, refactored from part of
8048 bidi_cache_iterator_state. Don't assume the required size is just
8049 one BIDI_CACHE_CHUNK away.
8050 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8051 (bidi_count_bytes, bidi_char_at_pos): New functions.
8052 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8053 always valid if bidi_cache_idx is valid.
8054 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8055 is valid if it's going to be used.
8056 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8057 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8058 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8059 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8060 (bidi_find_other_level_edge, bidi_cache_start_stack):
8061 All variables related to cache indices are now EMACS_INT.
c965adc5 8062
0bb23927
EZ
8063 * dispextern.h (struct bidi_string_data): New structure.
8064 (struct bidi_it): New member `string'. Make flag members be 1-bit
8065 fields, and put them last in the struct.
640c8776
SM
8066 (compute_display_string_pos, compute_display_string_end):
8067 Update prototypes.
0bb23927
EZ
8068 (bidi_push_it, bidi_pop_it): Add prototypes.
8069 (struct iterator_stack_entry): New members bidi_p,
8070 paragraph_embedding, and from_disp_prop_p.
8071 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8072 (bidi_shelve_cache, bidi_unshelve_cache):
8073 Declare prototypes.
0bb23927
EZ
8074
8075 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8076 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8077 and vector-like objects.
8078
8079 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8080 cache around display iteration.
8081
8082 * window.c (Fwindow_end, window_scroll_pixel_based)
8083 (displayed_window_lines, Frecenter): Save and restore the bidi
8084 cache around display iteration.
8085
3bbd2265
LMI
80862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8087
8088 * editfns.c (Fdelete_region): Clarify the use of the named
8089 parameters (bug#6788).
8090
adc47434
MR
80912011-07-14 Martin Rudalics <rudalics@gmx.at>
8092
8093 * indent.c (Fvertical_motion): Set and restore w->pointm when
8094 saving and restoring the window's buffer (Bug#9006).
8095
837c31f8
LMI
80962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8097
8098 * editfns.c (Fstring_to_char): Clarify just what is returned
8099 (bug#6576). Text by Eli Zaretskii.
8100
ac389d0c
JB
81012011-07-13 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8104
0be0ce47
EZ
81052011-07-13 Eli Zaretskii <eliz@gnu.org>
8106
8107 * buffer.c (mmap_find): Fix a typo.
8108
cd18e7e3
JB
81092011-07-13 Johan Bockgård <bojohan@gnu.org>
8110
8111 Fix execution of x selection hooks.
8112 * xselect.c (Qx_lost_selection_functions)
8113 (Qx_sent_selection_functions): New vars.
8114 (syms_of_xselect): DEFSYM them.
8115 (x_handle_selection_request): Pass Qx_sent_selection_functions
8116 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8117 (x_handle_selection_clear,x_clear_frame_selections):
8118 Pass Qx_lost_selection_functions rather than
8119 Vx_lost_selection_functions to Frun_hook_with_args.
8120
47ea7f44
PE
81212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8122
ac389d0c 8123 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8124 The old code sometimes used this field without initializing it.
8125
47ea7f44
PE
8126 * alloc.c (gc_sweep): Don't read past end of array.
8127 In theory, the old code could also have corrupted Emacs internals,
8128 though it'd be very unlikely.
8129
bc985c87
AS
81302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8131
8132 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8133 argument. (Bug#4026)
bc985c87 8134
0cf34688
LMI
81352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8136
b3dadd76
LMI
8137 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8138 key" (bug#4257).
8139
0cf34688
LMI
8140 * window.c (Fset_window_start): Doc fix (bug#4199).
8141 (Fset_window_hscroll): Ditto.
8142
270768cd
PE
81432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8144
077e3dda 8145 Fix minor new problems caught by GCC 4.6.1.
270768cd 8146 * term.c (init_tty): Remove unused local.
490011a6 8147 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8148 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8149 not used otherwise.
270768cd 8150
b1f58454
CY
81512011-07-12 Chong Yidong <cyd@stupidchicken.com>
8152
8153 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8154
22b9578d
LMI
81552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8156
6e70ab07
LMI
8157 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8158 are the mini-buffer and the echo area (bug#3320).
8159
22b9578d
LMI
8160 * term.c (init_tty): Remove support for supdup, c10 and perq
8161 terminals, which are no longer supported (bug#1482).
8162
8974cc9f
JB
81632011-07-10 Johan Bockgård <bojohan@gnu.org>
8164
8165 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8166
a560d974
JD
81672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8168
8169 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8170 for non-popups (Bug#3642).
8171
1dae0f0a
AS
81722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8173
268c2c36 8174 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8175 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8176 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8177 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8178 * data.c (fmod): Likewise.
8179 * dispnew.c (swap_glyphs_in_rows): Likewise.
8180 * emacs.c (memory_warning_signal): Likewise.
8181 * floatfns.c (float_error): Likewise.
8182 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8183 (otf_open, font_otf_capability, generate_otf_features)
8184 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8185 Likewise.
8186 * image.c (pbm_read_file): Likewise.
8187 * indent.c (string_display_width): Likewise.
8188 * intervals.c (check_for_interval, search_for_interval)
8189 (inc_interval_count, count_intervals, root_interval)
8190 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8191 * lread.c (defalias): Likewise.
268c2c36 8192 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8193 * regex.c (set_image_of_range_1, set_image_of_range)
8194 (regex_grow_registers): Likewise.
8195 * sysdep.c (strerror): Likewise.
8196 * termcap.c (valid_filename_p, tprint, main): Likewise.
8197 * tparam.c (main): Likewise.
8198 * unexhp9k800.c (run_time_remap, save_data_space)
8199 (update_file_ptrs, read_header, write_header, calculate_checksum)
8200 (copy_file, copy_rest, display_header): Likewise.
8201 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8202 Likewise.
8203 * xdisp.c (check_it): Likewise.
8204 * xfaces.c (register_color, unregister_color, unregister_colors):
8205 Likewise.
8206 * xfns.c (print_fontset_result): Likewise.
8207 * xrdb.c (member, fatal, main): Likewise.
8208
99033785
PE
82092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8210
8211 Fix minor problems found by static checking (Bug#9031).
8212 * chartab.c (char_table_set_range, map_sub_char_table):
8213 Remove unused locals.
8214 (uniprop_table): Now static.
8215 * composite.c (_work_char): Remove unused static var.
8216
9cb2ac56
JB
82172011-07-09 Juanma Barranquero <lekktu@gmail.com>
8218
8219 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8220
f25661f0
JD
82212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8222
8223 * gtkutil.c (qttip_cb): Remove code without function.
8224
8278c4fe
EZ
82252011-07-09 Eli Zaretskii <eliz@gnu.org>
8226
8227 * w32.c (pthread_sigmask): New stub.
8228
1692ae2d 82292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8230
8a6ebd58 8231 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8232 sigprocmask is portable only for single-threaded applications, and
8233 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8234 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8235 (LIBES): Use it.
8236 * callproc.c (Fcall_process):
8237 * process.c (create_process):
8238 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8239 Use pthread_sigmask, not sigprocmask.
123403e4 8240
1b854618
JD
82412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8242
8243 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8244 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8245 wrong (Bug#8591).
8246
3fe4b549
JD
82472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8248
0ce7e563
JD
8249 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8250 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8251 (xg_hide_tooltip): Fix comment.
8252
3fe4b549
JD
8253 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8254 in registerServicesMenuSendTypes.
8255 (validRequestorForSendType): Don't check ns_return_types.
8256
8257 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8258 ns_return_type.
8259
5df75e47
JR
82602011-07-08 Jason Rumney <jasonr@gnu.org>
8261
22610910
JR
8262 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8263 SH_SHOW for hidden windows (Bug#5482).
8264
5df75e47
JR
8265 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8266 frame struct members of non-existent frames (Bug#6284).
8267
699c10bd
JD
82682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8269
4393663b
JD
8270 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8271 variable firstTime not needed on OSX >= 10.6.
8272 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8273 >= 10.5. Use setKnobProportion, setDoubleValue.
8274
8275 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8276 (MAC_OS_X_VERSION_10_5): Define if not defined.
8277 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8278 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8279 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8280
8281 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8282 cString and lossyCString on OSX >= 10.4.
4393663b 8283
58179cce 8284 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8285 sizeToFit on OSX >= 10.2.
8286
8287 * nsimage.m (allocInitFromFile): Don't use deprecated method
8288 bestRepresentationForDevice on OSX >= 10.6.
8289
8290 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8291 to avoid warning.
8292
8293 * emacs.c: Declare unexec_init_emacs_zone.
8294
a63e0781
JD
8295 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8296
699c10bd
JD
8297 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8298
8299 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8300 on svcsMenu (Bug#8842).
8301
8302 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8303 ns_return_types.
8304 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8305
8306 * nsterm.m (QUTF8_STRING): Declare.
8307 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8308 (validRequestorForSendType): Return type is (id).
8309 Change indexOfObjectIdenticalTo to indexOfObject.
8310 Check if we have local selection before returning self (Bug#8842).
8311 (writeSelectionToPasteboard): Put local selection into paste board
8312 if we have a local selection (Bug#8842).
8313 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8314
8315 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8316 (ns_get_local_selection): Declare.
8317
54e10184
LMI
83182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8319
9888ff71
LMI
8320 * keymap.c (describe_map_tree): Don't insert a double newline at
8321 the end of the buffer (bug#1169) and return whether we inserted
8322 something.
8323
54e10184
LMI
8324 * callint.c (Fcall_interactively): Change "reading args" to
8325 "providing args" to try to clarify what it does (bug#1010).
8326
15fa4783
KH
83272011-07-07 Kenichi Handa <handa@m17n.org>
8328
8329 * composite.c (composition_compute_stop_pos): Ignore a static
8330 composition starting before CHARPOS (Bug#8915).
8331
8332 * xdisp.c (handle_composition_prop): Likewise.
8333
a8815b00
EZ
83342011-07-07 Eli Zaretskii <eliz@gnu.org>
8335
8336 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8337 (Bug#9015)
8338
ef7b981d 83392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8340
8341 * character.h (unicode_category_t): New enum type.
8342
8343 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8344 (Qchar_code_property_table): New variable.
8345 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8346 (UNIPROP_COMPRESSED_FORM_P): New macros.
8347 (char_table_ascii): Uncompress the compressed values.
8348 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8349 Uncompress the compressed values.
ac389d0c 8350 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8351 (char_table_ref_and_range): Uncompress the compressed values.
8352 (sub_char_table_set): New arg is_uniprop. Callers changed.
8353 Uncompress the compressed values.
8354 (sub_char_table_set_range): Args changed. Callers changed.
8355 (char_table_set_range): Adjuted for the above change.
8356 (map_sub_char_table): Delete args default_val and parent. Add arg
8357 top. Give decoded values to a Lisp function.
640c8776 8358 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8359 values to a Lisp function. Gcpro more variables.
8360 (uniprop_table_uncompress)
8361 (uniprop_decode_value_run_length): New functions.
8362 (uniprop_decoder, uniprop_decoder_count): New variables.
8363 (uniprop_get_decoder, uniprop_encode_value_character)
8364 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8365 New functions.
8366 (uniprop_encoder, uniprop_encoder_count): New variables.
8367 (uniprop_get_encoder, uniprop_table)
8368 (Funicode_property_table_internal, Fget_unicode_property_internal)
8369 (Fput_unicode_property_internal): New functions.
8370 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8371 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8372 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8373 char-code-property-alist.
8374
640c8776 8375 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8376 Vunicode_category_table.
8377
640c8776 8378 * font.c (font_range): Adjust for the change of
c805dec0
KH
8379 Vunicode_category_table.
8380
76b397fb
DN
83812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8382
8383 * m/iris4d.h: Remove file, move contents ...
8384 * s/irix6-5.h: ... here.
8385
22b4128e
PE
83862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8387
8388 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8389 * alloc.c (mark_buffer):
8390 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8391 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8392 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8393 This isn't true in general, and it's particularly not true
8394 if Emacs is configured with --with-wide-int.
8395 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8396 New macros, used in the buffer.c change.
8397
869795d6
JD
83982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8399
8400 * xsettings.c: Use both GConf and GSettings if both are available.
8401 (store_config_changed_event): Add comment.
8402 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8403 (store_tool_bar_style_changed): New functions.
5e617bc2 8404 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8405 (struct xsettings): Move font inside HAVE_XFT.
8406 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8407 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8408 Move inside HAVE_XFT.
640c8776 8409 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8410 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8411 also.
8412 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8413 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8414 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8415 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8416 (parse_settings): Move check for font inside HAVE_XFT.
8417 (read_settings, apply_xft_settings): Add comment.
8418 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8419 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8420 call store_font_name_changed.
8421 (xft_settings_event): Add comment.
8422 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8423 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8424 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8425 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8426 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8427 (xsettings_get_system_font, xsettings_get_system_normal_font):
8428 Add comment.
869795d6 8429
d8ed26bd
PE
84302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8431
8432 Random fixes. E.g., (random) never returned negative values.
8433 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8434 subseconds part to the entropy, as that's a bit more random.
8435 Prefer signed to unsigned, since the signedness doesn't matter and
8436 in general we prefer signed. When given a limit, use a
8437 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8438 latter isn't right if USE_2_TAGS_FOR_INTS.
8439 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8440 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8441
cabf1cac
SM
84422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8443
8444 * textprop.c (text_property_stickiness):
8445 Obey Vtext_property_default_nonsticky.
8446 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8447 * w32fns.c (syms_of_w32fns):
8448 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8449
6e9b2be9
PE
84502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8451
8452 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8453 This is more efficient than Ffile_directory_p and avoids a minor race.
8454
90186c68
LMI
84552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8456
7c301272
LMI
8457 * buffer.c (Foverlay_put): Say what the return value is
8458 (bug#7835).
8459
c4f2d8d4
LMI
8460 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8461 is a directory before asking whether to use the file name
8462 (bug#7564).
ad637907
LMI
8463 (barf_or_query_if_file_exists): Make the "File is a directory"
8464 error be more correct.
c4f2d8d4 8465
90186c68
LMI
8466 * fns.c (Frequire): Remove the mention of the .gz files, since
8467 that's installation-specific, but keep the mention of
8468 `get-load-suffixes'.
8469
da64016e
PE
84702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8471
8472 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8473 Report string overflow if the output is too long.
8474
7d47b580
JB
84752011-07-04 Juanma Barranquero <lekktu@gmail.com>
8476
a555cb87
JB
8477 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8478 (syms_of_gnutls): Remove duplicate DEFSYM for
8479 Qgnutls_bootprop_verify_hostname_error, an error for
8480 Qgnutls_bootprop_verify_error (which is no longer used).
8481
7d47b580
JB
8482 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8483 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8484 Also (re)move comments that are misplaced or no longer relevant.
8485
1e49bfab
LMI
84862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8487
8488 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8489
1485f4c0
CY
84902011-07-03 Chong Yidong <cyd@stupidchicken.com>
8491
8492 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8493 and background color parameters if they have been changed.
8494
a9ab721e
LMI
84952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8496
8497 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8498
cf7cff57
PE
84992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8500
2e13213d
PE
8501 * xsettings.c (SYSTEM_FONT): Define only when used.
8502 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8503
cf7cff57
PE
8504 * keymap.c (access_keymap_1): Now static.
8505
7a8e04f7
CY
85062011-07-02 Chong Yidong <cyd@stupidchicken.com>
8507
8508 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8509 leave any prefix arg for the up event (Bug#1586).
8510
61352f62
LMI
85112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8512
69bb1ef7
LMI
8513 * lread.c (syms_of_lread): Mention single symbols defined by
8514 `defvar' or `defconst' (bug#7154).
8515
61352f62 8516 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8517 (Frequire): Mention get-load-suffixes.
61352f62 8518
28545e04
MR
85192011-07-02 Martin Rudalics <rudalics@gmx.at>
8520
8521 * window.h (window): Remove clone_number slot.
8522 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8523 Remove.
8524 (make_parent_window, make_window, saved_window)
8525 (Fset_window_configuration, save_window_save): Don't deal with
8526 clone numbers.
8527 * buffer.c (Qclone_number): Remove declaration.
8528 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8529
3349e122
SM
85302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8531
8532 Add multiple inheritance to keymaps.
8533 * keymap.c (Fmake_composed_keymap): New function.
8534 (Fset_keymap_parent): Simplify.
8535 (fix_submap_inheritance): Remove.
8536 (access_keymap_1): New function extracted from access_keymap to handle
8537 embedded parents and handle lists of maps.
8538 (access_keymap): Use it.
8539 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8540 (Fcopy_keymap): Handle embedded parents.
8541 (Fcommand_remapping, define_as_prefix): Simplify.
8542 (Fkey_binding): Simplify.
8543 (syms_of_keymap): Move minibuffer-local-completion-map,
8544 minibuffer-local-filename-completion-map,
8545 minibuffer-local-must-match-map, and
8546 minibuffer-local-filename-must-match-map to Elisp.
8547 (syms_of_keymap): Defsubr make-composed-keymap.
8548 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8549 (parse_menu_item): Trivial simplification.
8550
3279eb87
GM
85512011-07-01 Glenn Morris <rgm@gnu.org>
8552
8553 * Makefile.in (SETTINGS_LIBS): Fix typo.
8554
4550efdf
KI
85552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8556
8557 * coding.c (Fencode_coding_string): Record the last coding system
8558 used, as the function doc string says (bug#8738).
8559
0949d2b6
JD
85602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8561
8562 * xsettings.c (store_monospaced_changed): Take new font as arg and
8563 check for change against current_mono_font.
8564 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8565 (emacs_settings_constructor, emacs_settings_get_property)
8566 (emacs_settings_set_property, emacs_settings_class_init)
8567 (emacs_settings_init, gsettings_obj): Remove.
8568 (something_changedCB): New function for HAVE_GSETTINGS.
8569 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8570 with value as argument.
8571 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8572 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8573 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8574 "changed".
8575
8576 * xgselect.c: Add defined (HAVE_GSETTINGS).
8577 (xgselect_initialize): Ditto.
8578
8579 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8580 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8581 xg_select.
8582
bbc6b304
PE
85832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8584
8585 * eval.c (struct backtrace): Simplify and port the data structure.
8586 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8587 signed bit field, as this assumption is not portable and it makes
8588 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8589 "char debug_on_exit : 1" as this is not portable either; instead,
8590 use the portable "unsigned int debug_on_exit : 1". Remove unused
8591 member evalargs. Remove obsolete comments about cc bombing out.
8592
9851bfc5
JD
85932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8594
51bb811f 8595 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8596 Let HAVE_GSETTINGS override HAVE_GCONF.
8597 (store_monospaced_changed): New function.
8598 (EMACS_SETTINGS): A new type derived from GObject to handle
8599 GSettings notifications.
8600 (emacs_settings_constructor, emacs_settings_get_property)
8601 (emacs_settings_set_property, emacs_settings_class_init):
8602 New functions.
8603 (gsettings_client, gsettings_obj): New variables.
8604 (GSETTINGS_SCHEMA): New define.
8605 (something_changedCB): Call store_monospaced_changed.
8606 (init_gsettings): New function.
8607 (xsettings_initialize): Call init_gsettings.
8608 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8609 to NULL.
8610
640c8776 8611 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8612 GCONF_CFLAGS/LIBS.
8613
5386012d
MR
86142011-06-29 Martin Rudalics <rudalics@gmx.at>
8615
8616 * window.c (resize_root_window, grow_mini_window)
8617 (shrink_mini_window): Rename Qresize_root_window to
8618 Qwindow_resize_root_window and Qresize_root_window_vertically to
8619 Qwindow_resize_root_window_vertically.
8620
f13e0b08
PE
86212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8622
8623 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8624
94515237
JB
86252011-06-27 Juanma Barranquero <lekktu@gmail.com>
8626
8627 * makefile.w32-in: Redesign dependencies so they reflect more
8628 clearly which files are directly included by each source file,
8629 and not through other includes.
8630
e43b6e43
MR
86312011-06-27 Martin Rudalics <rudalics@gmx.at>
8632
8633 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8634 (sort_overlays, overlay_strings): When an overlay's clone number
8635 matches the window's clone number process the overlay even if
8636 the overlay's window property doesn't match the current window.
8637
d68443dc
MR
8638 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8639 (Fwindow_hchild): Rename to Fwindow_left_child.
8640 (Fwindow_next): Rename to Fwindow_next_sibling.
8641 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8642 (resize_window_check): Rename to window_resize_check.
8643 (resize_window_apply): Rename to window_resize_apply.
8644 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8645 (Fdelete_other_windows_internal, resize_frame_windows)
8646 (Fsplit_window_internal, Fdelete_window_internal)
8647 (grow_mini_window, shrink_mini_window)
8648 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8649
c7e73be5
JD
86502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8651
8652 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8653 (emacs_fixed_set_min_size): Remove.
8654 (emacs_fixed_new): Take frame as argument.
8655
8656 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8657 (_EmacsFixedPrivate): Remove minwidth/height.
8658 Add struct frame *f.
8659 (emacs_fixed_init): Initialize priv->f.
8660 (get_parent_class, emacs_fixed_set_min_size): Remove.
8661 (emacs_fixed_new): Set priv->f to argument.
8662 (emacs_fixed_get_preferred_width)
8663 (emacs_fixed_get_preferred_height): Use min_width/height from
8664 frames size_hint to set minimum and natural (Bug#8919).
8665 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8666 and use min_width/height from frames size_hint to set
8667 min_width/height (Bug#8919).
8668
8669 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8670 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8671 Fix indentation.
c7e73be5 8672
cf99dcf8
EZ
86732011-06-26 Eli Zaretskii <eliz@gnu.org>
8674
8675 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8676 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8677 called at ZV.
8678
029529ac
CY
86792011-06-26 Chong Yidong <cyd@stupidchicken.com>
8680
8681 * process.c (wait_reading_process_output): Bypass select if
8682 waiting for a cell while ignoring keyboard input, and input is
8683 pending. Suggested by Jan Djärv (Bug#8869).
8684
7a7ef429
PE
86852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8686
8687 Use gnulib's dup2 module instead of rolling our own.
8688 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8689
11fdef7d 86902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8691
8692 * dispnew.c (scrolling_window): Before scrolling, turn off a
8693 mouse-highlight in the window being scrolled.
8694
cd3520a4
JB
86952011-06-24 Juanma Barranquero <lekktu@gmail.com>
8696
8697 Move DEFSYM to lisp.h and use everywhere.
8698
8699 * character.h (DEFSYM): Move declaration...
8700 * lisp.h (DEFSYM): ...here.
8701
8702 * gnutls.c:
8703 * minibuf.c:
8704 * w32menu.c:
8705 * w32proc.c:
8706 * w32select.c: Don't include character.h.
8707
8708 * alloc.c (syms_of_alloc):
8709 * buffer.c (syms_of_buffer):
8710 * bytecode.c (syms_of_bytecode):
8711 * callint.c (syms_of_callint):
8712 * casefiddle.c (syms_of_casefiddle):
8713 * casetab.c (init_casetab_once):
8714 * category.c (init_category_once, syms_of_category):
8715 * ccl.c (syms_of_ccl):
8716 * cmds.c (syms_of_cmds):
8717 * composite.c (syms_of_composite):
8718 * dbusbind.c (syms_of_dbusbind):
8719 * dired.c (syms_of_dired):
8720 * dispnew.c (syms_of_display):
8721 * doc.c (syms_of_doc):
8722 * editfns.c (syms_of_editfns):
8723 * emacs.c (syms_of_emacs):
8724 * eval.c (syms_of_eval):
8725 * fileio.c (syms_of_fileio):
8726 * fns.c (syms_of_fns):
8727 * frame.c (syms_of_frame):
8728 * fringe.c (syms_of_fringe):
8729 * insdel.c (syms_of_insdel):
8730 * keymap.c (syms_of_keymap):
8731 * lread.c (init_obarray, syms_of_lread):
8732 * macros.c (syms_of_macros):
8733 * msdos.c (syms_of_msdos):
8734 * print.c (syms_of_print):
8735 * process.c (syms_of_process):
8736 * search.c (syms_of_search):
8737 * sound.c (syms_of_sound):
8738 * syntax.c (init_syntax_once, syms_of_syntax):
8739 * terminal.c (syms_of_terminal):
8740 * textprop.c (syms_of_textprop):
8741 * undo.c (syms_of_undo):
8742 * w32.c (globals_of_w32):
8743 * window.c (syms_of_window):
8744 * xdisp.c (syms_of_xdisp):
8745 * xfaces.c (syms_of_xfaces):
8746 * xfns.c (syms_of_xfns):
8747 * xmenu.c (syms_of_xmenu):
8748 * xsettings.c (syms_of_xsettings):
8749 * xterm.c (syms_of_xterm): Use DEFSYM.
8750
4228cf16
TZ
87512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8752
cd3520a4 8753 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8754
7fcccf1e
PE
87552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8756
7efb4e0e
PE
8757 Integer and buffer overflow fixes (Bug#8873).
8758
ff5844ad
PE
8759 * print.c (printchar, strout): Check for string overflow.
8760 (PRINTPREPARE, printchar, strout):
8761 Don't set size unless allocation succeeds.
8762
90532f02
PE
8763 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8764 for sizes. Check for string overflow more accurately.
8765 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8766
6d84508d
PE
8767 * macros.c: Integer and buffer overflow fixes.
8768 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8769 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8770 Use ptrdiff_t, not int, for sizes.
8771 Don't increment bufsize until after realloc succeeds.
8772 Check for size-calculation overflow.
8773 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8774
437b2cb4
PE
8775 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8776
8b9ac8b4
PE
8777 * lread.c: Integer overflow fixes.
8778 (read_integer): Radix is now EMACS_INT, not int,
8779 to improve quality of diagnostics for out-of-range radices.
8780 Calculate buffer size correctly for out-of-range radices.
8781 (read1): Check for integer overflow in radices, and in
8782 read-circle numbers.
82cb60d3
PE
8783 (read_escape): Avoid int overflow.
8784 (Fload, openp, read_buffer_size, read1)
8785 (substitute_object_recurse, read_vector, read_list, map_obarray):
8786 Use ptrdiff_t, not int, for sizes.
8787 (read1): Use EMACS_INT, not int, for sizes.
20270765 8788 Check for size overflow.
8b9ac8b4 8789
7fcccf1e
PE
8790 * image.c (cache_image): Check for size arithmetic overflow.
8791
bfbbd7e7
PE
8792 * lread.c: Integer overflow issues.
8793 (saved_doc_string_size, saved_doc_string_length)
8794 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8795 Now ptrdiff_t, not int.
8796 (read1): Don't assume doc string length fits in int. Check for
8797 out-of-range doc string lengths.
8798 (read_list): Don't assume file position fits in int.
39019e54 8799 (read_escape): Check for hex character overflow.
bfbbd7e7 8800
4e323265
LL
88012011-06-22 Leo Liu <sdl.web@gmail.com>
8802
8803 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8804 Move to minibuffer.el.
8805
85fece3e
PE
88062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8807
20b84ce9 8808 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8809 The following patches are for when GLYPH_DEBUG && !XASSERT.
8810 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8811 * dispnew.c (flush_stdout):
8812 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8813 Mark as externally visible.
8814 * dispnew.c (check_window_matrix_pointers): Now static.
8815 * dispnew.c (window_to_frame_vpos):
8816 * xfns.c (unwind_create_frame):
8817 * xterm.c (x_check_font): Remove unused local.
8818 * scroll.c (CHECK_BOUNDS):
8819 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8820 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8821 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8822 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8823 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8824 Now static.
8825 (debug_method_add): Use va_list and vsprintf rather than relying
8826 on undefined behavior with wrong number of arguments.
8827 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8828 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8829 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8830 since we're not interested in debugging glyphs with old libraries.
8831 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8832 GCC 4.6.0's static checking.
8833
0766b489
PE
88342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8835
31fd4b32
PE
8836 Integer overflow and signedness fixes (Bug#8873).
8837 A few related buffer overrun fixes, too.
8838
b79e8648
PE
8839 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8840
0766b489
PE
8841 * dispextern.h (struct face.stipple):
8842 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8843 (x_bitmap_mask, x_allocate_bitmap_record)
8844 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8845 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8846 (x_create_bitmap_from_xpm_data):
8847 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8848 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8849 (.bitmaps_last):
8850 * xfaces.c (load_pixmap):
8851 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8852 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8853 (.bitmaps_last, struct x_output.icon_bitmap):
8854 Use ptrdiff_t, not int, for bitmap indexes.
8855 (x_allocate_bitmap_record): Check for size overflow.
8856 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8857
b081724f
PE
8858 Use ptrdiff_t, not int, for overlay counts.
8859 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8860 * editfns.c (overlays_around, get_pos_property):
8861 * textprop.c (get_char_property_and_overlay):
8862 * xdisp.c (next_overlay_change, note_mouse_highlight):
8863 * xfaces.c (face_at_buffer_position):
21514da7
PE
8864 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8865 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8866 (Fnext_overlay_change, Fprevious_overlay_change)
8867 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8868 Use ptrdiff_t, not int, for sizes.
21514da7 8869 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8870
3de73e5e
PE
8871 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8872
2606c57b
PE
8873 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8874 (x_session_initialize): Do not assume string length fits in int.
8875
aaafe47a
PE
8876 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8877 This is unlikely, but can occur if DPI is outlandish.
8878
2674ddc8 8879 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8880 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8881
28154962
PE
8882 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8883 * xrdb.c (magic_file_p, search_magic_path):
8884 Omit last arg SUFFIX; it was always 0. All callers changed.
8885 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8886
7de51af5
PE
8887 * xfont.c (xfont_match): Avoid need for strlen.
8888
25ed6cc3
PE
8889 * xfns.c: Don't assume strlen fits in int.
8890 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8891
4eab31dd
PE
8892 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8893 not unsigned long, as we prefer signed integers. All callers changed.
8894 Detect integer overflow in repeat count.
8895 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8896 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8897
171e2a58
PE
8898 * termcap.c: Don't assume sizes fit in int and never overflow.
8899 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8900 (gobble_line): Check for size-calculation overflow.
8901
ad39faca 8902 * minibuf.c (Fread_buffer):
6e5bb2dc 8903 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8904 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8905 Don't assume string length fits in int.
8906
52c61c22 8907 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8908 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8909
b5b8c9e5
PE
8910 * font.c: Don't assume string length fits in int.
8911 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8912 Use ptrdiff_t, not int.
ccd6111c
PE
8913 (font_intern_prop): Don't assume string length fits in int.
8914 Don't assume integer property fits in fixnum.
8915 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8916
882f0d81 8917 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8918 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8919 Reformulate so as not to need the command string.
8920 Invoke gzip -cd rather than gunzip, as it's more portable.
8921 (lock_info_type, lock_file_1, lock_file):
8922 Don't assume pid_t and time_t fit in unsigned long.
8923 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8924 (current_lock_owner): Prefer signed type for sizes.
8925 Use memcpy, not strncpy, where memcpy is what is really wanted.
8926 Don't assume (via atoi) that time_t and pid_t fit in int.
8927 Check for time_t and/or pid_t out of range, e.g., via a network share.
8928 Don't alloca where an auto var works fine.
8929
93f4cf88
PE
8930 * fileio.c: Fix some integer overflow issues.
8931 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8932 Don't assume string length fits in int.
8933 (directory_file_name): Don't assume string length fits in long.
8934 (make_temp_name): Don't assume pid fits in int, or that its print
8935 length is less than 20.
8936
f3e92b69
PE
8937 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8938
1bfdaf10
PE
8939 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8940
35016e9a
PE
8941 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8942
3d1e65a1
PE
8943 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8944 We prefer signed integers, even for size calculations.
8945
0b963a93
PE
8946 * emacs.c: Don't assume string length fits in 'int'.
8947 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8948 (main): Don't invoke strlen when not needed.
8949
573f4b54
PE
8950 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8951 (XD_DEBUG_MESSAGE): Don't waste a byte.
8952
989f33ba
PE
8953 * callproc.c (getenv_internal_1, getenv_internal)
8954 (Fgetenv_internal):
965d34eb
PE
8955 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8956
e4d29b33
PE
8957 * lread.c (invalid_syntax): Omit length argument.
8958 All uses changed. This doesn't fix a bug, but it simplifies the
8959 code away from its former Hollerith-constant appearance, and it's
8960 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8961 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8962
eb49b136
PE
8963 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8964 This didn't break anything, but it didn't help either.
8965 It's confusing to put a bogus integer in a place where the actual
8966 value does not matter.
9f62aeb1 8967 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8968 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8969
15375a22
PE
8970 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8971 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8972 implementation.
b61cc01c
PE
8973 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8974 We prefer signed types, and the value cannot exceed the EMACS_INT
8975 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8976 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8977 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8978 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8979
53b2623d
PE
8980 * indent.c (sane_tab_width): New function.
8981 (current_column, scan_for_column, Findent_to, position_indentation)
8982 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8983 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8984
51cab52b 8985 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8986
f2ed8a70
PE
8987 * lisp.h (lint_assume): New macro.
8988 * composite.c (composition_gstring_put_cache):
8989 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8990
abe80cc6
PE
8991 * editfns.c, insdel.c:
8992 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8993
b02c740e
PE
8994 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8995
ebc96716
PE
8996 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8997
b4e50fa0 8998 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8999 Use much-faster test for byte-length change.
311d5d7c 9000 Don't assume string byte-length fits in 'int'.
a4cf38e4 9001 Check that character arg fits in 'int'.
85461888 9002 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9003
c0c1ee9f
PE
9004 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9005
a498d7f4
PE
9006 * fns.c (concat): Catch string overflow earlier.
9007 Do not rely on integer wraparound.
9008
51cab52b
PE
9009 * dispextern.h (struct it.overlay_strings_charpos)
9010 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9011 * xdisp.c (forward_to_next_line_start)
9012 (back_to_previous_visible_line_start)
9013 (reseat_at_next_visible_line_start, next_element_from_buffer):
9014 Don't arbitrarily truncate the value of 'selective' to int.
9015
76031fad
PE
9016 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9017
5eb55db9
PE
9018 * composite.c: Don't truncate sizes to 'int'.
9019 (composition_gstring_p, composition_reseat_it)
9020 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9021 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9022 not EMACS_UINT, for indexes.
5eb55db9 9023
0703a717
PE
9024 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9025
d6202519
PE
9026 * buffer.c: Include <verify.h>.
9027 (struct sortvec.priority, struct sortstr.priority):
8961a454 9028 Now EMACS_INT, not int.
c20998a7 9029 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9030 (struct sortstr.size, record_overlay_string)
9031 (struct sortstrlist.size, struct sortlist.used):
9032 Don't truncate size to int.
9033 (record_overlay_string): Check for size-calculation overflow.
d6202519 9034 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9035
d5a19415
JM
90362011-06-22 Jim Meyering <meyering@redhat.com>
9037
029529ac 9038 Don't leak an XBM-image-sized buffer
d5a19415
JM
9039 * image.c (xbm_load): Free the image buffer after using it.
9040
a9041e6c
PE
90412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9042
9043 Port to Sun C.
9044 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9045 that Sun C diagnosed.
9046 * fns.c (secure_hash): Fix pointer signedness issue.
9047 * intervals.c (static_offset_intervals): New function.
9048 (offset_intervals): Use it.
9049
7f3f739f
LL
90502011-06-21 Leo Liu <sdl.web@gmail.com>
9051
9052 * deps.mk (fns.o):
9053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9054 sha512.h.
9055
9056 * fns.c (secure_hash): Rename from crypto_hash_function and change
9057 the first arg to accept symbols.
5b66d427 9058 (Fsecure_hash): New primitive.
7f3f739f
LL
9059 (syms_of_fns): New symbols.
9060
76147d94
DD
90612011-06-20 Deniz Dogan <deniz@dogan.se>
9062
9063 * process.c (Fset_process_buffer): Clarify return value in
9064 docstring.
9065
7d7d0045
CY
90662011-06-18 Chong Yidong <cyd@stupidchicken.com>
9067
9068 * dispnew.c (add_window_display_history): Use BVAR.
9069
9070 * xdisp.c (debug_method_add): Use BVAR.
9071 (check_window_end, dump_glyph_matrix, dump_glyph)
9072 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9073
9074 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9075 Likewise.
9076
9077 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9078 check till after the cache is created in init_frame_faces.
9079
ff2bc410
SM
90802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9081
9082 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9083
28177add
PE
90842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9085
dd3482fe
PE
9086 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9087 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9088 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9089
393d71f3 9090 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9091 * fileio.c (Finsert_file_contents):
9092 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9093 Remove the old (too-loose) buffer overflow checks.
9094 They weren't needed, since make_gap checks for buffer overflow.
9095 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9096 The old code merely checked for Emacs fixnum overflow, and relied
9097 on undefined (wraparound) behavior. The new code avoids undefined
9098 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9099
2e6813b0 9100 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9101 Tune. Don't use wider integers than needed. Don't use alloca.
9102 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9103
599a9e4f
PE
9104 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9105
99561444
PE
9106 * insdel.c, lisp.h (buffer_overflow): New function.
9107 (insert_from_buffer_1, replace_range, replace_range_2):
9108 * insdel.c (make_gap_larger):
9109 * editfns.c (Finsert_char):
9110 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9111
28177add
PE
9112 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9113
e69dafad
PE
91142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9115
4baa020d 9116 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9117
b1c46f02
PE
9118 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9119 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9120
e69dafad
PE
9121 * fileio.c: Don't assume EMACS_INT fits in off_t.
9122 (emacs_lseek): New static function.
9123 (Finsert_file_contents, Fwrite_region): Use it.
9124 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9125
566684ea
PE
9126 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9127
e6966cd6
PE
9128 * fns.c: Don't overflow int when computing a list length.
9129 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9130 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9131 truncation on 64-bit hosts. Check for QUIT every
9132 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9133 faster and is responsive enough.
9134 (Flength): Report an error instead of overflowing an integer.
9135 (Fsafe_length): Return a float if the value is not representable
9136 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9137 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9138 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9139
dd0b0efb
PE
9140 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9141 (header_size, word_size): New constants.
9142 (allocate_vectorlike): Don't check size overflow here.
9143 (allocate_vector): Check it here instead, since this is the only
9144 caller of allocate_vectorlike that could cause overflow.
9145 Check that the new vector's length is representable as a fixnum.
9146
86fe5cfe
PE
9147 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9148 The previous code was bogus. For example, next_almost_prime (32)
9149 returned 39, which is undesirable as it is a multiple of 3; and
9150 next_almost_prime (24) returned 25, which is a multiple of 5 so
9151 why was the code bothering to check for multiples of 7?
9152
80e88859
PE
9153 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9154
4a2f0ad6
PE
9155 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9156
f66c7cf8
PE
9157 Variadic C functions now count arguments with ptrdiff_t.
9158 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9159 Back then I didn't know that the Emacs coding style prefers signed int.
9160 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9161 were being counted with int, which may truncate counts on 64-bit
9162 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9163 * lisp.h (struct Lisp_Subr.function.aMANY)
9164 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9165 Arg counts are now ptrdiff_t, not size_t.
9166 All variadic functions and their callers changed accordingly.
9167 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9168 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9169 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9170 * callint.c (Fcall_interactively): Check arg count for overflow,
9171 to avoid potential buffer overrun. Use signed char, not 'int',
9172 for 'varies' array, so that we needn't bother to check its size
9173 calculation for overflow.
9174 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9175 * eval.c (apply_lambda):
9176 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9177 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9178 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9179
a1759b76
PE
9180 * callint.c (Fcall_interactively): Don't use index var as event count.
9181
d96be9fc
PE
9182 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9183 * mem-limits.h (SIZE): Remove; no longer used.
9184
a690a978 9185 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9186
578c21e6
PE
9187 Remove unnecessary casts.
9188 * xterm.c (x_term_init):
9189 * xfns.c (x_set_border_pixel):
9190 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9191 These aren't needed now that we assume ANSI C.
9192
96f53c6c
PE
9193 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9194 It's more likely to cause problems (due to unsigned overflow)
9195 than to cure them.
9196
83c77d31
PE
9197 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9198
ee2079f1
PE
9199 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9200
6da65536
PE
9201 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9202
7147c4a4
PE
9203 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9204
193e32d9
PE
9205 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9206
e5533da6
PE
9207 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9208
9910e595
PE
9209 GLYPH_CODE_FACE returns EMACS_INT, not int.
9210 * dispextern.h (merge_faces):
9211 * xfaces.c (merge_faces):
01103c44
PE
9212 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9213 Don't assume EMACS_INT fits in int.
9910e595 9214
2638320e
PE
9215 * character.h (CHAR_VALID_P): Remove unused parameter.
9216 * fontset.c, lisp.h, xdisp.c: All uses changed.
9217
045eb8d9
PE
9218 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9219
c1f134b5
PE
9220 * fns.c (concat): Minor tuning based on overflow analysis.
9221 This doesn't fix any bugs. Use int to hold character, instead
9222 of constantly refetching from Emacs object. Use XFASTINT, not
9223 XINT, for value known to be a character. Don't bother comparing
9224 a single byte to 0400, as it's always less.
9225
395fcb93 9226 * floatfns.c (Fexpt):
327eeec8
PE
9227 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9228
abbd3d23
PE
9229 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9230 for characters.
9231
684a03ef
PE
9232 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9233
0fed43f3
PE
9234 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9235 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9236 incorrectly succeed when S was a string, because 4294967386 was
9237 truncated before it was used.
9238
8fd02eb7
PE
9239 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9240 Otherwise, an out-of-range integer could cause undefined behavior
9241 on a 64-bit host.
9242
f8c86b69
PE
9243 * composite.c: Use int, not EMACS_INT, for characters.
9244 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9245 EMACS_INT, for values that are known to be in character range.
9246 This doesn't fix any bugs but is the usual style inside Emacs and
9247 may generate better code on 32-bit machines.
9248
34206dd2
PE
9249 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9250 This is for reasons similar to the recent CHAR_STRING fix.
9251 * charset.c (Fencode_char): Check that character arg is actually
9252 a character. Pass an int to ENCODE_CHAR.
9253 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9254 wider than 'int', as a compile-time check to prevent future regressions
9255 in this area.
9256
c5958d4c 9257 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9258
9259 Make sure a 64-bit char is never passed to CHAR_STRING.
9260 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9261 by silently ignoring the top 32 bits, allowing some values
9262 that were far too large to be valid characters.
9263 * character.h: Include <verify.h>.
9264 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9265 arguments are no wider than unsigned, as a compile-time check
9266 to prevent future regressions in this area.
9267 * data.c (Faset):
01103c44 9268 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9269 (Fsubst_char_in_region):
9270 * fns.c (concat):
9271 * xdisp.c (decode_mode_spec_coding):
9272 Adjust to CHAR_STRING's new requirement.
9273 * editfns.c (Finsert_char, Fsubst_char_in_region):
9274 * fns.c (concat): Check that character args are actually
9275 characters. Without this test, these functions did the wrong
9276 thing with wildly out-of-range values on 64-bit hosts.
9277
d37ca623
PE
9278 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9279 These casts should not be needed on 32-bit hosts, either.
9280 * keyboard.c (read_char):
9281 * lread.c (Fload): Remove casts to unsigned.
9282
ea204efb
PE
9283 * lisp.h (UNSIGNED_CMP): New macro.
9284 This fixes comparison bugs on 64-bit hosts.
9285 (ASCII_CHAR_P): Use it.
9286 * casefiddle.c (casify_object):
01103c44 9287 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9288 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9289 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9290 * dispextern.h (FACE_FROM_ID):
9291 * keyboard.c (read_char): Use UNSIGNED_CMP.
9292
41cb286c
PE
9293 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9294 not to EMACS_INT, to avoid GCC warning.
9295
4a1b9832
PE
9296 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9297
55daad71
PE
9298 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9299 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9300 isn't needed on 32-bit machines.
8f95c75c 9301
01103c44
PE
9302 * buffer.c (Fgenerate_new_buffer_name):
9303 Use EMACS_INT for count, not int.
0ceccced 9304 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9305
9306 * data.c (Qcompiled_function): Now static.
9307
c6f072e7
PE
9308 * window.c (window_body_lines): Now static.
9309
20ce5912
PE
9310 * image.c (gif_load): Rename local to avoid shadowing.
9311
9c4c5f81
PE
9312 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9313 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9314 * alloc.c (make_save_value): Integer argument is now of type
9315 ptrdiff_t, not int.
9316 (mark_object): Use ptrdiff_t, not int.
9317 * lisp.h (pD): New macro.
9318 * print.c (print_object): Use it.
9319
c0c5c8ae
PE
9320 * alloc.c: Use EMACS_INT, not int, to count objects.
9321 (total_conses, total_markers, total_symbols, total_vector_size)
9322 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9323 (total_free_floats, total_floats, total_free_intervals)
9324 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9325 Now EMACS_INT, not int. All uses changed.
9326 (Fgarbage_collect): Compute overall total using a double, so that
9327 integer overflow is less likely to be a problem. Check for overflow
9328 when converting back to an integer.
5a25e253
PE
9329 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9330 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9331 These were 'int' variables that could overflow on 64-bit hosts;
9332 they were never used, so remove them instead of repairing them.
211a0b2a 9333 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9334 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9335 Previously, this ceilinged at INT_MAX, but that doesn't work on
9336 64-bit machines.
e46bb31a 9337 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9338
c78baabf 9339 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9340 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9341 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9342 when a (possibly-narrower) signed value would do just as well.
9343 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9344
c9d624c6
PE
9345 * alloc.c: Catch some string size overflows that we were missing.
9346 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9347 for convenience in STRING_BYTES_MAX.
9348 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9349 The definition here is exact; the one in lisp.h was approximate.
9350 (allocate_string_data): Check for string overflow. This catches
9351 some instances we weren't catching before. Also, it catches
9352 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9353 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9354 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9355
c9d624c6
PE
9356 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9357 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9358 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9359
353032ce
PE
9360 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9361
2bccce07
PE
9362 * alloc.c (Fmake_string): Check for out-of-range init.
9363
0ac30604
SM
93642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9365
9366 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9367
c195f2de
JD
93682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9369
9370 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9371 xg_get_default_scrollbar_width.
9372
9373 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9374 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9375 (style_changed_cb): Call update_theme_scrollbar_width and call
9376 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9377 all frames (Bug#8505).
9378 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9379 Call gtk_window_set_resizable if HAVE_GTK3.
9380 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9381 and height if HAVE_GTK3 (Bug#8505).
9382 (scroll_bar_width_for_theme): New variable.
9383 (update_theme_scrollbar_width): New function.
9384 (xg_get_default_scrollbar_width): Move code to
9385 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9386 (xg_initialize): Call update_theme_scrollbar_width.
9387
9388 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9389
9390 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9391
e10ac9f1
MR
93922011-06-12 Martin Rudalics <rudalics@gmx.at>
9393
9394 * frame.c (make_frame): Call other_buffer_safely instead of
9395 other_buffer.
9396
9397 * window.c (temp_output_buffer_show): Call display_buffer with
9398 second argument Vtemp_buffer_show_specifiers and reset latter
9399 immediately after the call.
9400 (Vtemp_buffer_show_specifiers): New variable.
9401 (auto_window_vscroll_p, next_screen_context_lines)
9402 (Vscroll_preserve_screen_position): Remove leading asterisks from
9403 doc-strings.
9404
2d3c217e 94052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9406
7b7f97e8 9407 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9408 * buffer.c (Qclone_number): Remove for now, as it's unused.
9409 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9410 (record_buffer): Remove unused local.
9411 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9412 (set_frame_buffer_list): Remove; unused.
9413 * frame.h (other_visible_frames): Remove decl.
9414 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9415 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9416 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9417 if HAVE_GPM.
9418 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9419 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9420 Define only if HAVE_GPM.
9421 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9422 (update_hints_inhibit): Remove; never set. All uses removed.
9423 * widgetprv.h (emacsFrameClassRec): Remove decl.
9424 * window.c (delete_deletable_window): Now returns void, since it
9425 wasn't returning anything.
9426 (compare_window_configurations): Remove unused locals.
9427 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9428 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9429 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9430 the same widths as pointers. This follows up on the 2011-05-06 patch.
9431 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9432 * xterm.h: Likewise.
9433 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9434
1384b89e
JB
94352011-06-12 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * makefile.w32-in: Update dependencies.
9438 (LISP_H): Add lib/intprops.h.
9439
1100a63c
CY
94402011-06-11 Chong Yidong <cyd@stupidchicken.com>
9441
9442 * image.c (gif_load): Add animation frame delay to the metadata.
9443 (syms_of_image): Use DEFSYM. New symbol `delay'.
9444
6198ccd0
MR
94452011-06-11 Martin Rudalics <rudalics@gmx.at>
9446
9447 * window.c (delete_deletable_window): Re-add.
9448 (Fset_window_configuration): Rewrite to handle dead buffers and
9449 consequently deletable windows.
9450 (window_tree, Fwindow_tree): Remove. Supply functionality in
9451 window.el.
9452 (compare_window_configurations): Simplify code.
9453
b6e3633c
AS
94542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9455
1ab0dee5
AS
9456 * image.c (imagemagick_load_image): Fix type mismatch.
9457 (Fimagemagick_types): Likewise.
9458
b6e3633c
AS
9459 * window.h (replace_buffer_in_windows): Declare.
9460
9397e56f
MR
94612011-06-11 Martin Rudalics <rudalics@gmx.at>
9462
9463 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9464 Qclone_number. Remove external declaration of Qdelete_window.
9465 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9466 code.
640c8776
SM
9467 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9468 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9469 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9470 buffer list implementation.
9471 (other_buffer_safely): New function.
9472 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9473 calls to replace_buffer_in_windows and
9474 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9475 if allowed.
9476 (record_buffer): Inhibit quitting and rewrite using quittable
9477 functions. Run Qbuffer_list_update_hook if allowed.
9478 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9479 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9480 Move switch-to-buffer to window.el.
9397e56f
MR
9481 (bury-buffer): Move to window.el.
9482 (Vbuffer_list_update_hook): New variable.
9483
9484 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9485 section.
9486
9487 * window.h (resize_frame_windows): Move up in code.
9488 (Fwindow_frame): Remove EXFUN.
9489 (replace_buffer_in_all_windows): Remove prototype.
9490 (replace_buffer_in_windows_safely): Add prototype.
9491
9492 * window.c: Declare Qdelete_window static again. Move down
9493 declaration of select_count.
9494 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9495 (Fother_window): Move to window.el.
9496 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9497 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9498 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9499 window.el.
9500 (replace_buffer_in_windows): Implement by calling
9501 Qreplace_buffer_in_windows.
9502 (replace_buffer_in_all_windows): Remove with some functionality
9503 moved into replace_buffer_in_windows_safely.
9504 (replace_buffer_in_windows_safely): New function.
9505 (select_window_norecord, select_frame_norecord): Move in front
9506 of run_window_configuration_change_hook. Remove now obsolete
9507 declarations.
640c8776
SM
9508 (Fset_window_buffer): Rewrite doc-string.
9509 Call Qrecord_window_buffer.
9397e56f
MR
9510 (keys_of_window): Move binding for other-window to window.el.
9511
b50691aa
CY
95122011-06-11 Chong Yidong <cyd@stupidchicken.com>
9513
9514 * dispextern.h (struct image): Replace data member, whose int_val
9515 and ptr_val fields were not used by anything, with a single
9516 lisp_val object.
9517
9518 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9519 (gif_clear_image, gif_load, imagemagick_load_image)
9520 (gs_clear_image, gs_load): Callers changed.
9521
3f754b86
PE
95222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9523
cca69397
PE
9524 * buffer.h: Include <time.h>, for time_t.
9525 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9526
109e28d0
PE
9527 Fix minor problems found by static checking.
9528
60737f02
PE
9529 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9530
4b66faf3
PE
9531 Make identifiers static if they are not used in other modules.
9532 * data.c (Qcompiled_function, Qframe, Qvector):
9533 * image.c (QimageMagick, Qsvg):
9534 * minibuf.c (Qmetadata):
9535 * window.c (resize_window_check, resize_root_window): Now static.
9536 * window.h (resize_window_check, resize_root_window): Remove decls.
9537
109e28d0
PE
9538 * window.c (window_deletion_count, delete_deletable_window):
9539 Remove; unused.
46a4ce9e
PE
9540 (window_body_lines): Now static.
9541 (Fdelete_other_windows_internal): Mark vars as initialized.
9542 Make sure 'resize_failed' is initialized.
9543 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9544 (resize_window_apply): Remove unused local.
9545 * window.h (delete_deletable_window): Remove decl.
9546
109e28d0 9547 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9548 (imagemagick_load_image): Fix pointer signedness problem by changing
9549 last arg from unsigned char * to char *. All uses changed.
9550 Also, fix a local for similar reasons.
9551 Remove unused locals. Remove locals to avoid shadowing.
9552 (fn_rsvg_handle_free): Remove; unused.
9553 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9554 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9555
3f754b86
PE
9556 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9557
2547adb1
CY
95582011-06-10 Chong Yidong <cyd@stupidchicken.com>
9559
9560 * image.c (gif_load): Fix omitted cast error introduced by
9561 2011-06-06 change.
9562
2c8e37d4
MR
95632011-06-10 Martin Rudalics <rudalics@gmx.at>
9564
9565 * window.h (resize_proportionally, orig_total_lines)
9566 (orig_top_line): Remove from window structure.
9567 (set_window_height, set_window_width, change_window_heights)
9568 (Fdelete_window): Remove prototypes.
9569 (resize_frame_windows): Remove duplicate declaration.
9570
440a42e3
EZ
95712011-06-10 Eli Zaretskii <eliz@gnu.org>
9572
9573 * window.h (resize_frame_windows, resize_window_check)
9574 (delete_deletable_window, resize_root_window)
9575 (resize_frame_windows): Declare prototypes.
9576
9577 * window.c (resize_window_apply): Make definition be "static" to
9578 match the prototype.
9579
562dd5e9
MR
95802011-06-10 Martin Rudalics <rudalics@gmx.at>
9581
9582 * window.c: Remove declarations of Qwindow_size_fixed,
9583 window_min_size_1, window_min_size_2, window_min_size,
9584 size_window, window_fixed_size_p, enlarge_window, delete_window.
9585 Remove static from declaration of Qdelete_window, it's
9586 temporarily needed by Fbury_buffer.
9587 (replace_window): Don't assign orig_top_line and
9588 orig_total_lines.
9589 (Fdelete_window, delete_window): Remove. Window deletion is
9590 handled by window.el.
640c8776
SM
9591 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9592 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9593 (Fdelete_other_windows): Remove. Deleting other windows is
9594 handled by window.el.
9595 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9596 handled in window.el.
9597 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9598 Window minimum sizes are handled in window.el.
9599 (shrink_windows, size_window, set_window_height)
9600 (set_window_width, change_window_heights, window_height)
9601 (window_width, CURBEG, CURSIZE, enlarge_window)
9602 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9603 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9604 handled in window.el.
9605 (make_dummy_parent): Rename to make_parent_window and give it a
9606 second argument horflag.
9607 (make_window): Don't set resize_proportionally any more.
9608 (Fsplit_window): Remove. Windows are split in window.el.
9609 (save_restore_action, save_restore_orig_size)
9610 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9611 Resize mini windows in window.el.
9612 (grow_mini_window, shrink_mini_window): Implement by calling
9613 Qresize_root_window_vertically, resize_window_check and
9614 resize_window_apply.
640c8776
SM
9615 (saved_window, Fset_window_configuration, save_window_save):
9616 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9617 resize_proportionally.
9618 (window_min_height, window_min_width): Move to window.el.
9619 (keys_of_window): Move bindings for delete-other-windows,
9620 split-window, delete-window and enlarge-window to window.el.
9621
9622 * buffer.c: Temporarily extern Qdelete_window.
9623 (Fbury_buffer): Temporarily call Qdelete_window instead of
9624 Fdelete_window (Fbury_buffer will move to window.el soon).
9625
9626 * frame.c (set_menu_bar_lines_1): Remove code handling
9627 orig_top_line and orig_total_lines.
9628
9629 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9630 set_window_height but set heights directly.
9631 (change_frame_size_1): Use resize_frame_windows.
9632
9633 * xdisp.c (init_xdisp): Don't use set_window_height but set
9634 heights directly.
9635
640c8776
SM
9636 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9637 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9638 run_window_configuration_change_hook.
9639
9640 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9641 instead of change_window_heights and run
9642 run_window_configuration_change_hook.
9643
1a13852e
MR
96442011-06-09 Martin Rudalics <rudalics@gmx.at>
9645
9646 * window.c (replace_window): Rename second argument REPLACEMENT to
9647 NEW. New third argument SETFLAG. Rewrite.
9648 (delete_window, make_dummy_parent): Call replace_window with
9649 third argument 1.
9650 (window_list_1): Move down in code.
9651 (run_window_configuration_change_hook): Move set_buffer part
9652 before select_frame_norecord part in order to unwind correctly.
9653 Rename count1 to count.
9654 (recombine_windows, delete_deletable_window, resize_root_window)
9655 (Fdelete_other_windows_internal)
9656 (Frun_window_configuration_change_hook, make_parent_window)
9657 (resize_window_check, resize_window_apply, Fresize_window_apply)
9658 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9659 (Fdelete_window_internal, Fresize_mini_window_internal):
9660 New functions.
1a13852e
MR
9661 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9662
f3d1777e
MR
96632011-06-08 Martin Rudalics <rudalics@gmx.at>
9664
496e208e
MR
9665 * window.h (window): Add some new members to window structure -
9666 normal_lines, normal_cols, new_total, new_normal, clone_number,
9667 splits, nest, prev_buffers, next_buffers.
9668 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9669 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9670
f3d1777e
MR
9671 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9672 Remove.
496e208e
MR
9673 (make_dummy_parent): Set new members of windows structure.
9674 (make_window): Move down in code. Handle new members of window
9675 structure.
9676 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9677 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9678 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9679 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9680 (Fset_window_next_buffers, Fset_window_clone_number):
9681 New functions.
496e208e
MR
9682 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9683 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9684 Doc-string fixes.
9685 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9686 Argument WINDOW can be now internal window too.
9687 (Fwindow_use_time): Move up in code.
9688 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9689 Rewrite doc-string.
9690 (Fset_window_configuration, saved_window)
9691 (Fcurrent_window_configuration, save_window_save): Handle new
9692 members of window structure.
b9e809c2
MR
9693 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9694 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9695 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9696 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9697 Qget_mru_window, Qresize_root_window,
9698 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9699 Qauto_buffer_name; staticpro them.
f3d1777e 9700
abde8f8c
MR
97012011-06-07 Martin Rudalics <rudalics@gmx.at>
9702
9703 * window.c (Fwindow_total_size, Fwindow_left_column)
9704 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9705 (Fwindow_list_1): New functions.
9706 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9707 (Fwindow_width, Fscroll_left, Fscroll_right):
9708 Use window_body_cols instead of window_box_text_cols.
9709 (delete_window, Fset_window_configuration):
9710 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9711 (delete_all_subwindows): Take a window as argument and not a
9712 structure. Rewrite.
190b47e6
MR
9713 (window_loop): Remove handling of GET_LRU_WINDOW and
9714 GET_LARGEST_WINDOW.
9715 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9716
9717 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9718 window_box_text_cols. delete_all_subwindows now takes a
9719 Lisp_Object as argument.
abde8f8c 9720
640c8776
SM
9721 * indent.c (compute_motion, Fcompute_motion):
9722 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9723
fa8a67e6
MR
9724 * frame.c (delete_frame): Call delete_all_subwindows with root
9725 window as argument.
9726
a54e3482
DC
97272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9728
9729 * fns.c (Fputhash): Document return value.
9730
60002bf5
CY
97312011-06-06 Chong Yidong <cyd@stupidchicken.com>
9732
9733 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9734
0c671da6 97352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9736
b862a52a 9737 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9738
be44ca6c
PE
9739 Check for overflow when converting integer to cons and back.
9740 * charset.c (Fdefine_charset_internal, Fdecode_char):
9741 Use cons_to_unsigned to catch overflow.
9742 (Fencode_char): Use INTEGER_TO_CONS.
9743 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9744 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9745 * data.c (long_to_cons, cons_to_long): Remove.
9746 (cons_to_unsigned, cons_to_signed): New functions.
9747 These signal an error for invalid or out-of-range values.
9748 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9749 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9750 * font.c (Ffont_variation_glyphs):
9751 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9752 * lisp.h: Include <intprops.h>.
9753 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9754 (cons_to_signed, cons_to_unsigned): New decls.
9755 (long_to_cons, cons_to_long): Remove decls.
9756 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9757 (Fprimitive_undo): Use CONS_TO_INTEGER.
9758 * xfns.c (Fx_window_property): Likewise.
9759 * xselect.c: Include <limits.h>.
9760 (x_own_selection, selection_data_to_lisp_data):
9761 Use INTEGER_TO_CONS.
9762 (x_handle_selection_request, x_handle_selection_clear)
9763 (x_get_foreign_selection, Fx_disown_selection_internal)
9764 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9765 (lisp_data_to_selection_data): Use cons_to_unsigned.
9766 (x_fill_property_data): Use cons_to_signed.
9767 Report values out of range.
9768
d1f3d2af
PE
9769 Check for buffer and string overflow more precisely.
9770 * buffer.h (BUF_BYTES_MAX): New macro.
9771 * lisp.h (STRING_BYTES_MAX): New macro.
9772 * alloc.c (Fmake_string):
9773 * character.c (string_escape_byte8):
9774 * coding.c (coding_alloc_by_realloc):
9775 * doprnt.c (doprnt):
9776 * editfns.c (Fformat):
9777 * eval.c (verror):
9778 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9779 since they may not be the same number.
9780 * editfns.c (Finsert_char):
9781 * fileio.c (Finsert_file_contents):
9782 Likewise for BUF_BYTES_MAX.
9783
dd52fcea
PE
9784 * image.c: Use ptrdiff_t, not int, for sizes.
9785 (slurp_file): Switch from int to ptrdiff_t.
9786 All uses changed.
9787 (slurp_file): Check that file size fits in both size_t (for
9788 malloc) and ptrdiff_t (for sanity and safety).
9789
7f9bbdbb
PE
9790 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9791 if b->modtime has its maximal value.
9792
dfe18f82
PE
9793 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9794
84acfcf0
PE
9795 Don't assume time_t can fit into int.
9796 * buffer.h (struct buffer.modtime): Now time_t, not int.
9797 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9798 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9799
ccd9a01a
PE
9800 Minor fixes for signed vs unsigned integers.
9801 * character.h (MAYBE_UNIFY_CHAR):
9802 * charset.c (maybe_unify_char):
9803 * keyboard.c (read_char, reorder_modifiers):
9804 XINT -> XFASTINT, since the integer must be nonnegative.
9805 * ftfont.c (ftfont_spec_pattern):
9806 * keymap.c (access_keymap, silly_event_symbol_error):
9807 XUINT -> XFASTINT, since the integer must be nonnegative.
9808 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9809 since it makes no difference and we prefer signed.
9810 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9811 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9812 nonnegative.
9813
d6d100dd
SM
98142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9815
9816 * window.h (Fwindow_frame): Declare.
9817
2b6148e4
PE
98182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9819
9820 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9821 (SPARE_MEMORY): Always define.
9822 (LARGE_REQUEST): Remove.
9823 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9824
f230ecc9
MR
98252011-06-06 Martin Rudalics <rudalics@gmx.at>
9826
727e958e
MR
9827 * lisp.h: Move EXFUNS for Fframe_root_window,
9828 Fframe_first_window and Fset_frame_selected_window to window.h.
9829
9830 * window.h: Move EXFUNS for Fframe_root_window,
9831 Fframe_first_window and Fset_frame_selected_window here from
9832 lisp.h.
9833
9834 * frame.c (Fwindow_frame, Fframe_first_window)
9835 (Fframe_root_window, Fframe_selected_window)
9836 (Fset_frame_selected_window): Move to window.c.
9837 (Factive_minibuffer_window): Move to minibuf.c.
9838 (Fother_visible_frames_p): New function.
9839
9840 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9841
f230ecc9
MR
9842 * window.c (decode_window, decode_any_window): Move up in code.
9843 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9844 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9845 (Fwindow_buffer): Move up and rewrite doc-string.
9846 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9847 (Fwindow_prev): New functions.
727e958e
MR
9848 (Fwindow_frame): Move here from frame.c. Accept any window as
9849 argument.
9850 (Fframe_root_window, Fframe_first_window)
9851 (Fframe_selected_window): Move here from frame.c. Accept frame
9852 or arbitrary window as argument. Update doc-strings.
9853 (Fminibuffer_window): Move up in code.
9854 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9855 (Fset_frame_selected_window): Move here from frame.c.
9856 Marginal rewrite.
727e958e
MR
9857 (Fselected_window, select_window, Fselect_window): Move up in
9858 code. Minor doc-string fixes.
f230ecc9 9859
4d09bcf6
PE
98602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9861
9862 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9863 Do not assume that spare memory exists; that assumption is valid
9864 only if SYSTEM_MALLOC.
9865 (LARGE_REQUEST): New macro, so that the issue of large requests
9866 is separated from the issue of spare memory.
9867
810928a2
AS
98682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9869
172418ad
AS
9870 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9871 format. (Bug#8806)
9872
43f862f7
AS
9873 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9874
810928a2
AS
9875 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9876 before statements.
9877
a059fe24
JD
98782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9879
9880 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9881
9882 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9883
9884 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9885 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9886
989bf368
JB
98872011-06-05 Juanma Barranquero <lekktu@gmail.com>
9888
9889 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9890
4b80f674
CY
98912011-06-04 Chong Yidong <cyd@stupidchicken.com>
9892
9893 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9894 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9895 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9896 New error handlers.
4b80f674
CY
9897 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9898 Obey Vx_select_enable_clipboard_manager. Catch errors in
9899 x_clipboard_manager_save (Bug#8779).
9900 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9901 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9902
99a33b77 99032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9904
9905 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9906
99a33b77 99072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9908
9909 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9910 in the current matrix if keep_current_p is non-zero.
9911
8264569d
EZ
99122011-06-04 Eli Zaretskii <eliz@gnu.org>
9913
9914 * bidi.c (bidi_level_of_next_char): Fix last change.
9915
57f97249
EZ
99162011-06-03 Eli Zaretskii <eliz@gnu.org>
9917
fec2107c 9918 Support bidi reordering of text covered by display properties.
57f97249 9919
fec2107c
EZ
9920 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9921 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9922 (bidi_cache_search, bidi_cache_iterator_state)
9923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9924 (bidi_level_of_next_char, bidi_move_to_visually_next):
9925 Support character positions inside a run of characters covered by a
fec2107c
EZ
9926 display string.
9927 (bidi_paragraph_init, bidi_resolve_explicit_1)
9928 (bidi_level_of_next_char): Call bidi_fetch_char and
9929 bidi_fetch_char_advance instead of FETCH_CHAR and
9930 FETCH_CHAR_ADVANCE.
9931 (bidi_init_it): Initialize new members.
9932 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9933 definitions.
9934 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9935 instead of using explicit *_CHAR codes.
d6d100dd
SM
9936 (bidi_resolve_explicit, bidi_resolve_weak):
9937 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9938 bidirectional text is supported only in multibyte buffers.
9939 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9940 it to initialize the frame_window_p member of struct bidi_it.
9941 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9942 (bidi_resolve_explicit, bidi_resolve_weak)
9943 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9944 bidi_it->nchars is non-positive.
9945 (bidi_level_of_next_char): Don't try to lookup the cache for the
9946 next/previous character if nothing is cached there yet, or if we
9947 were just reseat()'ed to a new position.
c40e2fb2 9948
0e14fe90
EZ
9949 * xdisp.c (set_cursor_from_row): Set start and stop points
9950 according to the row's direction when priming the loop that looks
9951 for the glyph on which to display cursor.
9952 (single_display_spec_intangible_p): Function deleted.
9953 (display_prop_intangible_p): Reimplement to call
9954 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9955 Accept 3 additional arguments needed by handle_display_spec.
9956 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9957 values: lists, `(when COND...)' forms, etc.
9958 (single_display_spec_string_p): Support property values that are
9959 lists with the argument STRING its top-level element.
9960 (display_prop_string_p): Fix the condition for processing a
9961 property that is a list to be consistent with handle_display_spec.
fec2107c 9962 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9963 last portion of handle_display_prop.
9964 (compute_display_string_pos): Accept additional argument
9965 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9966 value of a `display' property is a "replacing spec".
9967 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9968 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9969 the display property, but just return a value indicating whether
9970 the display property will replace the characters it covers.
9971 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9972 frame_window_p members of struct bidi_it.
d6d100dd
SM
9973 (compute_display_string_pos, compute_display_string_end):
9974 New functions.
fec2107c
EZ
9975 (push_it): Accept second argument POSITION, where pop_it should
9976 jump to continue iteration.
9977 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9978
fec2107c
EZ
9979 * keyboard.c (adjust_point_for_property): Adjust the call to
9980 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9981
9982 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9983 (bidi_init_it): Update prototypes.
9984 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9985 (compute_display_string_pos, compute_display_string_end):
9986 Declare prototypes.
fec2107c
EZ
9987 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9988 EMACS_INT.
fc6f18ce 9989
40087514 99902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9991
57f53182
PE
9992 Malloc failure behavior now depends on size of allocation.
9993 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9994 * lisp.h: Change signatures accordingly.
9995 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9996 All callers changed. (Bug#8762)
9997
9998 * gnutls.c: Use Emacs's memory allocators.
9999 Without this change, the gnutls library would invoke malloc etc.
10000 directly, which causes problems on non-SYNC_INPUT hosts, and which
10001 runs afoul of improving memory_full behavior. (Bug#8761)
10002 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10003 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10004 xfree instead of the default malloc, realloc, free.
10005 (Fgnutls_boot): No need to check for memory allocation failure,
10006 since xmalloc does that for us.
10007
ac32cd99 10008 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10009 * category.c (hash_get_category_set):
10010 * ccl.c (ccl_driver):
10011 * charset.c (Fdefine_charset_internal):
10012 * charset.h (struct charset.hash_index):
10013 * composite.c (get_composition_id, gstring_lookup_cache)
10014 (composition_gstring_put_cache):
10015 * composite.h (struct composition.hash_index):
10016 * dispextern.h (struct image.hash):
10017 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10018 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10019 (hashfn_equal, hashfn_user_defined, make_hash_table)
10020 (maybe_resize_hash_table, hash_lookup, hash_put)
10021 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10022 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10023 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10024 * image.c (make_image, search_image_cache, lookup_image)
10025 (xpm_put_color_table_h):
10026 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10027 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10028 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10029 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10030 * alloc.c (allocate_vectorlike):
10031 Check for overflow in vector size calculations.
10032 * ccl.c (ccl_driver):
10033 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10034 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10035 need to be updated by these changes.
40087514
PE
10036 * fns.c (make_hash_table, maybe_resize_hash_table):
10037 Check for integer overflow with large hash tables.
0de4bb68
PE
10038 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10039 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10040 (SXHASH_REDUCE): New macro.
10041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10042 Use it instead of discarding useful hash info with large hash values.
10043 (sxhash_float): New function.
10044 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10045 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10046 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10047 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10048 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10049 Adjust signatures to match updated version of code.
10050 (consing_since_gc): Now EMACS_INT, since a single hash table can
10051 use more than INT_MAX bytes.
10052
698d32e2
DN
100532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10054
10055 Make it possible to build with GCC-4.6+ -O2 -flto.
10056
10057 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10058
fd6fa53f
SM
100592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10060
10061 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10062 Call minibuffer-inactive-mode.
10063
864db017
JB
100642011-05-31 Juanma Barranquero <lekktu@gmail.com>
10065
10066 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10067 Update dependencies.
10068
2ad0baf4
DN
100692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10070
10071 * data.c (init_data): Remove code for UTS, this system is not
10072 supported anymore.
10073
4fcc2638
DN
100742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10075
10076 Don't force ./temacs to start in terminal mode.
10077
10078 * frame.c (make_initial_frame): Initialize faces in all cases, not
10079 only when CANNOT_DUMP is defined.
10080 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10081
c56e0fd5
DN
100822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10083
10084 * dispnew.c (add_window_display_history): Use const for the string
10085 pointer. Remove declaration, not needed.
10086
333d54da 100872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10088
55d4c1b2 10089 Use 'inline', not 'INLINE'.
333d54da 10090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10091 * alloc.c, fontset.c (INLINE): Remove.
10092 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10093 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10094 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10095 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10096 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10097
738db178
DN
100982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10099
10100 Make it possible to run ./temacs.
10101
10102 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10103 syms_of_callproc does the same thing. Remove test for
10104 "initialized", do it in the caller.
10105 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10106
620c53a6
SM
101072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10108
10109 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10110 (read_minibuf): Use get_minibuffer.
10111 (syms_of_minibuf): Use DEFSYM.
10112 (Qmetadata): New var.
10113 * data.c (Qbuffer): Don't make it static.
10114 (syms_of_data): Use DEFSYM.
10115
e003a292
PE
101162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10117
10118 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10119 (CCL_CODE_MIN): New macro.
10120
ed008a6d
PE
101212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10122
3687c2ef
PE
10123 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10124
ed008a6d
PE
10125 * eval.c (Qdebug): Now static.
10126 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10127 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10128 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10129
d66c4c7c
CY
101302011-05-29 Chong Yidong <cyd@stupidchicken.com>
10131
10132 * image.c: Various fixes to ImageMagick code comments.
10133 (Fimagemagick_types): Doc fix.
10134
5fbc2025
PE
101352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10136
0196f88a
PE
10137 Minor fixes prompted by GCC 4.6.0 warnings.
10138
10139 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10140
5fbc2025
PE
10141 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10142 (x_clipboard_manager_save_all): Move extern decl to ...
10143 * xterm.h: ... here, so that it can be checked for consistency.
10144
1dd3c2d9
CY
101452011-05-29 Chong Yidong <cyd@stupidchicken.com>
10146
10147 * xselect.c (x_clipboard_manager_save_frame)
10148 (x_clipboard_manager_save_all): New functions.
10149 (Fx_clipboard_manager_save): Lisp function deleted.
10150
10151 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10152 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10153
10154 * xterm.h: Update prototype.
10155
5ba6571d
WX
101562011-05-28 William Xu <william.xwl@gmail.com>
10157
10158 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10159 exiting (Bug#8239).
10160
3eaff834
JM
101612011-05-28 Jim Meyering <meyering@redhat.com>
10162
e1900994 10163 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10164 * fns.c (to_uchar): Define.
10165 (crypto_hash_function): Use it to convert some newly-signed
10166 variables to unsigned, to avoid sign-extension bugs. For example,
10167 without this change, (md5 "truc") would evaluate to
10168 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10169 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10170 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10171
0f6990a7
PE
101722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10173
10174 Integer overflow fixes.
c8a9ca5a 10175
08686060
PE
10176 * dbusbind.c: Serial number integer overflow fixes.
10177 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10178 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10179 to hold a serial number that is too large for a fixnum.
10180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10181 Check for serial numbers out of range. Decode any serial number
59568bf0 10182 that was so large that it became a float. (Bug#8722)
08686060 10183
2d1fc3c7
PE
10184 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10185 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10186 Use XFASTINT rather than XUINT when numbers are nonnegative.
10187 (xd_append_arg, Fdbus_method_return_internal):
10188 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10189 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10190 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10191 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10192 (Bug#8722)
2d1fc3c7 10193
c8a9ca5a
PE
10194 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10195
519e1d69
PE
10196 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10197
6df6ae42 10198 ccl: Add integer overflow checks.
30569699
PE
10199 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10200 (IN_INT_RANGE): New macros.
10201 (ccl_driver): Use them to check for integer overflow when
10202 decoding a CCL program. Many of the new checks are whether XINT (x)
10203 fits in int; it doesn't always, on 64-bit hosts. The new version
10204 doesn't catch all possible integer overflows, but it's an
847044ea 10205 improvement. (Bug#8719)
30569699 10206
c11285dc
PE
10207 * alloc.c (make_event_array): Use XINT, not XUINT.
10208 There's no need for unsigned here.
10209
fdccd48e
PE
10210 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10211 This follows up to the 2011-05-06 change that substituted uintptr_t
10212 for EMACS_INT. This case wasn't caught back then.
10213
37910ab2
PE
10214 Rework Fformat to avoid integer overflow issues.
10215 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10216 now (part of C89). Include <verify.h>.
10217 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10218 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10219 (Fformat): Avoid the prepass trying to compute sizes; it was only
10220 approximate and thus did not catch overflow reliably. Instead, walk
10221 through the format just once, formatting and computing sizes as we go,
10222 checking for integer overflow at every step, and allocating a larger
10223 buffer as needed. Keep track separately whether the format is
10224 multibyte. Keep only the most-recently calculated precision, rather
10225 than them all. Record whether each argument has been converted to
10226 string. Use EMACS_INT, not int, for byte and char and arg counts.
10227 Support field widths and precisions larger than INT_MAX. Avoid
10228 sprintf's undefined behavior with conversion specifications such as %#d
10229 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10230 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10231 formatting out-of-range floating point numbers with int
9173deec 10232 formats. (Bug#8668)
37910ab2 10233
2e6578fb
PE
10234 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10235
0ae6bdee
PE
10236 * data.c: Avoid integer truncation in expressions involving floats.
10237 * data.c: Include <intprops.h>.
10238 (arith_driver): When there's an integer overflow in an expression
10239 involving floating point, convert the integers to floating point
10240 so that the resulting value does not suffer from catastrophic
10241 integer truncation. For example, on a 64-bit host (* 4
10242 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10243 Do not rely on undefined behavior after integer overflow.
10244
de883a70
PE
10245 merge count_size_as_multibyte, parse_str_to_multibyte
10246 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10247 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10248 Check for integer overflow.
10249 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10250 since it's now a duplicate of the other. This is more of
10251 a character than a buffer op, so better that it's in character.c.
10252 * fns.c, print.c: Adjust to above changes.
10253
2ff916cb
PE
102542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10255
10256 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10257
f1b54466
PE
102582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10259
fb1ac845
PE
10260 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10261 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10262 (x_clipboard_manager_save): Now static.
10263 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10264
f1b54466
PE
10265 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10266 (crypto_hash_function): Now static.
10267 Fix pointer signedness problems. Avoid unnecessary initializations.
10268
a9f737ee
CY
102692011-05-27 Chong Yidong <cyd@stupidchicken.com>
10270
10271 * termhooks.h (Vselection_alist): Make it terminal-local.
10272
10273 * terminal.c (create_terminal): Initialize it.
10274
10275 * xselect.c: Support for clipboard managers.
10276 (Vselection_alist): Move to termhooks.h as terminal-local var.
10277 (LOCAL_SELECTION): New macro.
10278 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10279 (symbol_to_x_atom): Remove gratuitous arg.
10280 (x_handle_selection_request, lisp_data_to_selection_data)
10281 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10282 (x_own_selection, x_get_local_selection, x_convert_selection):
10283 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10284 (some_frame_on_display): Delete unused function.
10285 (Fx_own_selection_internal, Fx_get_selection_internal)
10286 (Fx_disown_selection_internal, Fx_selection_owner_p)
10287 (Fx_selection_exists_p): New optional frame arg.
10288 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10289 (x_handle_selection_clear): Don't treat other terminals with the
10290 same keyboard specially. Use the terminal-local Vselection_alist.
10291 (x_clear_frame_selections): Use Frun_hook_with_args.
10292
10293 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10294
10295 * xterm.h: Add support for those atoms.
10296
e067f0c1
CY
102972011-05-26 Chong Yidong <cyd@stupidchicken.com>
10298
10299 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10300 (converted_selections, conversion_fail_tag): New global variables.
10301 (x_selection_request_lisp_error): Free the above.
10302 (x_get_local_selection): Remove unnecessary code.
10303 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10304 of converted selections stored in converted_selections.
10305 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10306 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10307 (x_convert_selection): New function.
10308 (x_handle_selection_event): Simplify.
10309 (x_get_foreign_selection): Don't ignore incoming requests while
10310 waiting for an answer; this will fail when we implement
10311 SAVE_TARGETS, and seems unnecessary anyway.
10312 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10313 (Vx_sent_selection_functions): Doc fix.
10314
0f4aebc0
LL
103152011-05-26 Leo Liu <sdl.web@gmail.com>
10316
10317 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10318
e61124cd
YM
103192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10320
10321 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10322
10323 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10324 for fringe update if it has periodic bitmap.
ac389d0c 10325 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10326 and fringe_bitmap_periodic_p.
10327
10328 * fringe.c (get_fringe_bitmap_data): New function.
10329 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10330 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10331 row. Mark glyph row for fringe update if periodicity changed.
10332
10333 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10334 for fringe update unless it has periodic bitmap.
10335
f16d9837
KH
103362011-05-25 Kenichi Handa <handa@m17n.org>
10337
10338 * xdisp.c (get_next_display_element): Set correct it->face_id for
10339 a static composition.
10340
e1b90ef6
LL
103412011-05-24 Leo Liu <sdl.web@gmail.com>
10342
10343 * deps.mk (fns.o):
10344 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10345
10346 * fns.c (crypto_hash_function, Fsha1): New function.
10347 (Fmd5): Use crypto_hash_function.
10348 (syms_of_fns): Add Ssha1.
10349
7400048f
PE
103502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10351
10352 * gnutls.c: Remove unused macros.
10353 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10354 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10355 Remove macros that are defined and never used.
10356 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10357
abb71cf4
CY
103582011-05-22 Chong Yidong <cyd@stupidchicken.com>
10359
10360 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10361 (Fx_get_selection_internal): Minor cleanup.
10362 (Fx_own_selection_internal): Rename arguments for consistency with
10363 select.el.
10364
6307db39
PE
103652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10366
10367 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10368
f3d4e0a4
CY
103692011-05-22 Chong Yidong <cyd@stupidchicken.com>
10370
10371 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10372
4d8ade89
YM
103732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10374
10375 * dispnew.c (scrolling_window): Don't exclude the case that the
10376 last enabled row in the desired matrix touches the bottom boundary.
10377
32078c8d
GM
103782011-05-21 Glenn Morris <rgm@gnu.org>
10379
10380 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10381 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10382 and add some more files.
32078c8d 10383
7285dc67
EZ
103842011-05-20 Eli Zaretskii <eliz@gnu.org>
10385
10386 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10387 report_file_error introduced by the change from 2011-05-07.
10388
89d1bd22
PE
103892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10390
10391 * systime.h (Time): Define only if emacs is defined.
10392 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10393 where the include path doesn't have X11/X.h by default. See
10394 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10395
cd394be1 103962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10397
10398 * composite.c (find_automatic_composition): Fix previous change.
10399
b9704ad9
GM
104002011-05-20 Glenn Morris <rgm@gnu.org>
10401
10402 * lisp.mk: New file, split from Makefile.in.
10403 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10404 (shortlisp): Remove.
10405 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10406
4a720484
GM
104072011-05-19 Glenn Morris <rgm@gnu.org>
10408
10409 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10410 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10411 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10412 (lisp): Set the order to that of loadup.el.
10413 (shortlisp): Make it a copy of $lisp.
10414 (SOME_MACHINE_LISP): Remove.
10415 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10416 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10417
a28d4396
KH
104182011-05-18 Kenichi Handa <handa@m17n.org>
10419
10420 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10421 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10422 (find_automatic_composition): Mostly rewrite for efficiency.
10423
a2b1fa8e
JB
104242011-05-18 Juanma Barranquero <lekktu@gmail.com>
10425
10426 * makefile.w32-in: Update dependencies.
10427
8e1f5610
CS
104282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10429
10430 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10431 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10432
7025ee00 104332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10434
cdfa6eab
PE
10435 Fix some integer overflow issues, such as string length overflow.
10436
06d6db33
PE
10437 * insdel.c (count_size_as_multibyte): Check for string overflow.
10438
2b4560a8
PE
10439 * character.c (lisp_string_width): Check for string overflow.
10440 Use EMACS_INT, not int, for string indexes and lengths; in
10441 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10442 the resulting string length overflows an EMACS_INT; instead,
10443 report a string overflow if no precision given. When checking for
10444 precision exhaustion, use a check that cannot possibly have
10445 integer overflow. (Bug#8675)
10446 * character.h (lisp_string_width): Adjust to new signature.
10447
cb93f9be
PE
10448 * alloc.c (string_overflow): New function.
10449 (Fmake_string): Use it. This doesn't change behavior, but saves
10450 a few bytes and will simplify future changes.
10451 * character.c (string_escape_byte8): Likewise.
10452 * lisp.h (string_overflow): New decl.
10453
1a1f3366
PE
10454 Fixups, following up to the user-interface timestamp change.
10455 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10456 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10457 * msdos.c (mouse_get_pos): Likewise.
10458 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10459 * w32gui.h (Time): Define by including "systime.h" rather than by
10460 declaring it ourselves. (Bug#8664)
10461
d4e3e4d3
PE
10462 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10463 * image.c (clear_image_cache): Likewise.
10464
f6a24d19
PE
10465 * term.c (term_mouse_position): Don't assume time_t wraparound.
10466
08dc5ae6
PE
10467 Be more systematic about user-interface timestamps.
10468 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10469 and sometimes 'EMACS_UINT', to represent these timestamps.
10470 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10471 This makes the code easier to follow, and makes it easier to catch
10472 integer overflow bugs such as Bug#8664.
10473 * frame.c (Fmouse_position, Fmouse_pixel_position):
10474 Use Time, not unsigned long, for user-interface timestamps.
10475 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10476 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10477 * keyboard.h (last_event_timestamp): Likewise.
10478 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10479 * menu.h (xmenu_show): Likewise.
10480 * term.c (term_mouse_position): Likewise.
10481 * termhooks.h (struct input_event.timestamp): Likewise.
10482 (struct terminal.mouse_position_hook): Likewise.
10483 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10484 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10485 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10486 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10487 what it was before.
10488 * menu.h, termhooks.h: Include "systime.h", for Time.
10489
8e55734a
PE
10490 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10491 Don't assume that the difference between two unsigned long values
10492 can fit into an integer. At this point, we know button_down_time
10493 <= event->timestamp, so the difference must be nonnegative, so
10494 there's no need to cast the result if double-click-time is
10495 nonnegative, as it should be; check that it's nonnegative, just in
10496 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10497 apart (about 25 days). (Bug#8664)
8e55734a 10498
841f1b75 10499 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10500 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10501
3e26f69c
PE
10502 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10503 that always fit in int. Use a sentinel instead of a counter, to
10504 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10505 * frame.h (struct frame): Use int for menu_bar_items_used
10506 instead of EMACS_INT, since it always fits in int.
3e26f69c 10507
5cc152c0
PE
10508 * menu.c (grow_menu_items): Check for int overflow.
10509
d89eb65e
PE
10510 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10511
5235bd3e
PE
10512 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10513 Before, the code was not consistent. These values cannot exceed
10514 2**31 - 1 so there's no need to make them unsigned.
10515 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10516 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10517 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10518 as modifiers.
10519 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10520
bc827e23
PE
10521 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10522 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10523 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10524 presumably because the widths might not match.
10525
78eb494e
PE
10526 * window.c (size_window): Avoid needless test at loop start.
10527
04f2d78b
CB
105282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10529
10530 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10531
d2fc7e3d 105322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10533
10534 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10535
d2fc7e3d 105362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10537
10538 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10539 `width' to `bar_area_x' and `bar_area_width', respectively.
10540 (x_scroll_run): Take account of fringe background extension.
10541
04f2d78b
CB
10542 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10543 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10544 `bar_area_width', respectively.
10545 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10546 background extension.
10547
79b70037
GM
105482011-05-10 Jim Meyering <meyering@redhat.com>
10549
10550 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10551
2f142cc5
JB
105522011-05-10 Juanma Barranquero <lekktu@gmail.com>
10553
10554 * image.c (Finit_image_library): Return t for built-in image types,
10555 like pbm and xbm. (Bug#8640)
10556
57679c86
AS
105572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10558
10559 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10560
888c9e86
EZ
105612011-05-07 Eli Zaretskii <eliz@gnu.org>
10562
b0512a1d
EZ
10563 * w32console.c (Fset_screen_color): Doc fix.
10564 (Fget_screen_color): New function.
10565 (syms_of_ntterm): Defsubr it.
10566
7285dc67
EZ
10567 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10568 unlink the temporary file if Fcall_process didn't create it in the
10569 first place.
10570 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10571 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10572 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10573 cue to call_process_cleanup not to close that handle.
10574
4d3fcc8e
BK
105752011-05-07 Ben Key <bkey76@gmail.com>
10576
10577 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10578 one of two shell specific rules, either bootstrap-temacs-CMD or
10579 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10580 to the previous implementation of the bootstrap-temacs rule.
10581 The bootstrap-temacs-CMD rule is similar to the previous
10582 implementation of the bootstrap-temacs rule except that it
10583 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10584 variable.
10585
10586 These changes, along with some changes to nt/configure.bat,
10587 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10588 earlier fix to add support for --cflags and --ldflags options
10589 that include quotes so that it works whether make uses cmd or
10590 sh as the shell.
10591
b4289b64
MA
105922011-05-06 Michael Albinus <michael.albinus@gmx.de>
10593
10594 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10595 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10596 is a constant.
10597 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10598 a string. Handle both cases.
10599 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10600 (Fdbus_register_method): Use Qinvalid_function.
10601
af4c0e28
JB
106022011-05-06 Juanma Barranquero <lekktu@gmail.com>
10603
10604 * makefile.w32-in: Update dependencies.
10605 (LISP_H): Add inttypes.h and stdin.h.
10606 (PROCESS_H): Add unistd.h.
10607
c51453d9
EZ
106082011-05-06 Eli Zaretskii <eliz@gnu.org>
10609
10610 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10611 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10612
8ff0ac3c 106132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10614
4c4b566b
PE
10615 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10616
aab2b9b5
PE
10617 * term.c (vfatal): Remove stray call to va_end.
10618 It's not needed and the C Standard doesn't allow it here anyway.
10619
c378da0b
PE
10620 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10621 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10622
288b08c7
PE
10623 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10624 bytes.
10625
e3601888
PE
10626 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10627
db6c0e74
PE
10628 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10629
dd5963ea
PE
10630 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10631
88c9450f
PE
10632 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10633
2f9442b8
PE
10634 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10635
c032b5f8
PE
10636 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10637 * charset.c (Fdefine_charset_internal): Don't initialize
10638 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10639 32-bit int (Bug#8600).
a108c10b
PE
10640
10641 * lread.c (read_integer): Be more consistent with string-to-number.
10642 Use string_to_number to do the actual conversion; this avoids
10643 rounding errors and fixes some other screwups. Without this fix,
10644 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10645 (digit_to_number): Move earlier, for benefit of read_integer.
10646 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10647 not a digit in any supported base. (Bug#8602)
a108c10b 10648
ad5f9eea
PE
10649 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10650
aec1708a
PE
10651 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10652 to match comment at start of function. This also removes a
10653 GCC warning about overflow in a 32+64-bit port.
10654
47be4ab5
PE
10655 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10656
371cac43
PE
10657 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10658 Reported by Stefan Monnier in
10659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10661 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10662
d01a7826
PE
10663 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10664 (EMACS_UINTPTR): Likewise, with uintptr_t.
10665
7fd47d5c
PE
10666 * lisp.h: Prefer 64-bit EMACS_INT if available.
10667 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10668 on 32-bit hosts that have 64-bit int, so that they can access
10669 large files.
122b0c86
PE
10670 However, temporarily disable this change unless the temporary
10671 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10672
8727937b
PE
10673 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10674
8ac068ac
PE
10675 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10676 This removes an assumption that EMACS_INT and long are the same
10677 width as pointers. The assumption is true for Emacs porting targets
10678 now, but we want to make other targets possible.
10679 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10680 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10681 In the rest of the code, change types of integers that hold casted
10682 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10683 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10684 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10685 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10686 No need to cast type when ORing.
10687 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10688 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10689 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10690 assume EMACS_INT is the same width as char *.
10691 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10692 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10693 Remove no-longer-needed casts.
10694 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10695 (xg_tool_bar_help_callback, xg_make_tool_item):
10696 Use EMACS_INTPTR to hold an integer
10697 that will be cast to void *; this can avoid a GCC warning
10698 if EMACS_INT is not the same width as void *.
10699 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10700 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10701 (current_message_1, set_message_1):
10702 Use a local to convert to proper width without a cast.
10703 * xmenu.c (dialog_selection_callback): Likewise.
10704
ede49d71
PE
10705 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10706 Also, don't assume VALBITS / RAND_BITS is less than 5,
10707 and don't rely on undefined behavior when shifting a 1 left into
10708 the sign bit.
10709 * lisp.h (get_random): Change signature to match.
10710
2f30ecd0
PE
10711 * lread.c (hash_string): Use size_t, not int, for hash computation.
10712 Normally we prefer signed values; but hashing is special, because
10713 it's better to use unsigned division on hash table sizes so that
10714 the remainder is nonnegative. Also, size_t is the natural width
10715 for hashing into memory. The previous code used 'int', which doesn't
10716 retain enough info to hash well into very large tables.
10717 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10718
2a866e7b
PE
10719 * dbusbind.c: Don't possibly lose pointer info when converting.
10720 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10721 Use XPNTR rather than XHASH, so that the high-order bits of
10722 the pointer aren't lost when converting through void *.
10723
51639eac
PE
10724 * eval.c (Fautoload): Don't double-shift a pointer.
10725
92394119
PE
10726 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10727
dbdb9a7c
JB
107282011-05-06 Juanma Barranquero <lekktu@gmail.com>
10729
10730 * gnutls.c (DEF_GNUTLS_FN):
10731 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10732
db7a0b4f
AS
107332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10734
10735 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10736 marker. (Bug#8610)
10737
cd394be1 107382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10739
10740 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10741 New version that can reserve upto 2GB of heap space.
10742
f7ff1b0f 107432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10744
10745 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10746
639c109b
TZ
107472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10748
10749 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10750 `gnutls_certificate_set_x509_key_file'.
10751
d2127135
JB
107522011-05-05 Juanma Barranquero <lekktu@gmail.com>
10753
10754 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10755 Update dependencies.
10756
e968f4f3
JB
107572011-05-04 Juanma Barranquero <lekktu@gmail.com>
10758
10759 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10760 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10761 Remove unused parameter `fildes'.
10762 * process.c (read_process_output, send_process): Don't pass it.
10763
84d358f0
JB
107642011-05-04 Juanma Barranquero <lekktu@gmail.com>
10765
10766 Fix previous change: the library cache is defined in w32.c.
10767 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10768 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10769
0898ca10
JB
107702011-05-04 Juanma Barranquero <lekktu@gmail.com>
10771
10772 Implement dynamic loading of GnuTLS on Windows.
10773
10774 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10775 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10777 Declare.
10778
10779 * gnutls.c (Qgnutls_dll): Define.
10780 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10781 (gnutls_*): Declare function pointers.
10782 (init_gnutls_functions): New function to initialize function pointers.
10783 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10784 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10785 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10786 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10787 (emacs_gnutls_write, emacs_gnutls_read)
10788 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10789 (Fgnutls_available_p): New function.
10790 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10791 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10792 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10793
10794 * image.c: Include w32.h.
10795 (Vimage_type_cache): Delete.
10796 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10797 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10798 (w32_delayed_load): Move to w32.c.
10799
10800 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10801
10802 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10803 (w32_delayed_load): Move from image.c. When loading a library, record
10804 its filename in the :loaded-from property of the library id.
10805 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10806 Initialize and staticpro them.
10807 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10808
10809 * process.c: Include lisp.h before w32.h, not after.
10810 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10811 instead of gnutls_record_check_pending.
10812
10813 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10814
ff4de4aa
TZ
108152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10816
10817 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10818 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10819 as passed in.
10820
abe95abb
JD
108212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10822
10823 * xterm.c (x_set_frame_alpha): Do not set property on anything
10824 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10825
e16e55d4
JB
108262011-05-02 Juanma Barranquero <lekktu@gmail.com>
10827
10828 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10829
bafcf6a5
JB
108302011-05-02 Juanma Barranquero <lekktu@gmail.com>
10831
10832 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10833 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10834 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10835 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10836 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10837 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10838 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10839 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10840 (Qgnutls_bootprop_callbacks_verify): Make static.
10841
e7a6747f
AS
108422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10843
19ed11ba
AS
10844 * callproc.c: Indentation fixup.
10845
e7a6747f 10846 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10847 (wait_for_termination, interruptible_wait_for_termination):
10848 Move after wait_for_termination_1.
e7a6747f 10849
1ef14cb4
LMI
108502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10851
10852 * sysdep.c (interruptible_wait_for_termination): New function
10853 which is like wait_for_termination, but allows keyboard
10854 interruptions.
10855
10856 * callproc.c (Fcall_process): Add (:file "file") as an option for
10857 the STDOUT buffer.
10858 (Fcall_process_region): Ditto.
10859
330d880c
EZ
108602011-04-30 Eli Zaretskii <eliz@gnu.org>
10861
8db90b73
EZ
10862 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10863 rather than `XVECTOR (FOO)->size'.
10864
330d880c
EZ
10865 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10866 inttypes.h, as a gnulib replacement is used if it not available in
10867 system headers.
10868
15cbd324
EZ
108692011-04-21 Eli Zaretskii <eliz@gnu.org>
10870
10871 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10872 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10873 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10874
10875 * coding.c (coding_alloc_by_realloc): Error out if destination
10876 will grow beyond MOST_POSITIVE_FIXNUM.
10877 (decode_coding_emacs_mule): Abort if there isn't enough place in
10878 charbuf for the composition carryover bytes. Reserve an extra
10879 space for up to 2 characters produced in a loop.
10880 (decode_coding_iso_2022): Abort if there isn't enough place in
10881 charbuf for the composition carryover bytes.
10882
108832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10884
ae940cca
EZ
10885 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10886 aborting when %lld or %lll format is passed.
10887 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10888 %llo or %llx format is passed. (Bug#8545)
10889
03ab8921
EZ
10890 * window.c (window_scroll_line_based): Use a marker instead of
10891 simple variables to record original value of point. (Bug#7952)
10892
afda1437
EZ
10893 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10894 produced by %s or %c overflows available buffer space. (Bug#8545)
10895
f76dee0c
PE
108962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10897
10898 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10899 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10900
fdc5744d
JB
109012011-04-28 Juanma Barranquero <lekktu@gmail.com>
10902
10903 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10904
638f053a
JB
109052011-04-28 Juanma Barranquero <lekktu@gmail.com>
10906
10907 * keyboard.c (Qdelayed_warnings_hook): Define.
10908 (command_loop_1): Run `delayed-warnings-hook'
10909 if Vdelayed_warnings_list is non-nil.
10910 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10911 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10912
d178f871
EZ
109132011-04-28 Eli Zaretskii <eliz@gnu.org>
10914
10915 * doprnt.c (doprnt): Don't return value smaller than the buffer
10916 size if the message was truncated. (Bug#8545).
10917
b124fd93
JB
109182011-04-28 Juanma Barranquero <lekktu@gmail.com>
10919
10920 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10921 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10922
e810457d
PE
109232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10924
10925 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10926
ea51cceb
JB
109272011-04-27 Juanma Barranquero <lekktu@gmail.com>
10928
10929 * makefile.w32-in: Update dependencies.
10930
94dcfacf
EZ
109312011-04-27 Eli Zaretskii <eliz@gnu.org>
10932
10933 Improve `doprnt' and its usage. (Bug#8545)
10934 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10935 `format_end'. Remove support for %l as a conversion specifier.
10936 Don't use xrealloc. Improve diagnostics when the %l size modifier
10937 is used. Update the commentary.
10938
10939 * eval.c (verror): Simplify calculation of size_t.
10940
10941 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10942 messages.
10943
f61f41d7
PE
109442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10945
10946 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10947 change.
10948
96fb4434
PE
109492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10950
10951 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10952 This makes this file independent of the recent pseudovector change.
10953
671875da 109542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10955
69e9b5a3
PE
10956 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10957
b5f869a7 10958 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10959 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10960 Remove unused local.
c8926152 10961 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10962
841a1577 10963 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10964 GCC 4.6.0 optimizes based on type-based alias analysis.
10965 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10966 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10967 != &v->size, and therefore "v->size = 1; b->size = 2; return
10968 v->size;" must therefore return 1. This assumption is incorrect
10969 for Emacs, since it type-puns struct Lisp_Vector * with many other
10970 types. To fix this problem, this patch adds a new type struct
f904488f 10971 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10972 and pseudovectors, and helps optimizing compilers not get fooled
10973 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10974 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10975 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10976 the size member.
eab3844f
PE
10977 (XSETPVECTYPE): Rewrite in terms of new macro.
10978 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10979 This is a bit clearer, and further avoids the possibility of
10980 undesirable aliasing.
10981 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10982 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10983 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10984 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10985 (ASIZE): Now uses header.size rather than size.
10986 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10987 to avoid the hassle of writing XVECTOR (foo)->header.size.
10988 (struct vectorlike_header): New type.
eab3844f
PE
10989 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10990 object, to help avoid aliasing.
10991 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10992 (SUBRP): Likewise, since Lisp_Subr is a special case.
10993 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10994 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10995 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10996 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10997 changed to be "header.size" and "header.next".
10998 * buffer.h (struct buffer): Likewise.
10999 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11000 * frame.h (struct frame): Likewise.
11001 * process.h (struct Lisp_Process): Likewise.
11002 * termhooks.h (struct terminal): Likewise.
11003 * window.c (struct save_window_data, struct saved_window): Likewise.
11004 * window.h (struct window): Likewise.
11005 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11006 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11007 * buffer.c (init_buffer_once): Likewise.
11008 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11009 special case.
11010 * process.c (Fformat_network_address): Use local var for size,
11011 for brevity.
11012
0df1eac5
PE
11013 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11014
847ab9d1 11015 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11016 * data.c (atof): Remove decl; no longer used or needed.
11017 (digit_to_number): Move to lread.c.
11018 (Fstring_to_number): Use new string_to_number function, to be
11019 consistent with how the Lisp reader treats infinities and NaNs.
11020 Do not assume that floating-point numbers represent EMACS_INT
11021 without losing information; this is not true on most 64-bit hosts.
11022 Avoid double-rounding errors, by insisting on integers when
11023 parsing non-base-10 numbers, as the documentation specifies.
11024 * lisp.h (string_to_number): New decl, replacing ...
11025 (isfloat_string): Remove.
bc0a5c13 11026 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11027 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11028 appears to have been a coding error. Similarly, do not accept
11029 strings like +-1e0 as floating point numbers. Do not report
11030 overflow for integer overflows unless the base is not 10 which
11031 means we have no simple and reliable way to continue.
11032 Break out the floating-point parsing into a new
11033 function string_to_number, so that Fstring_to_number parses
11034 floating point numbers consistently with the Lisp reader.
04f2d78b 11035 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11036 (E_CHAR, EXP_INT): Remove, replacing with ...
11037 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11038 (string_to_number): New function, replacing isfloat_string.
11039 This function checks for valid syntax and produces the resulting
11040 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11041 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11042 so that overflow for non-base-10 numbers is reported only when
11043 there's no portable and simple way to convert to floating point.
452f4150 11044
67769ffc
PE
11045 * textprop.c (set_text_properties_1): Rewrite for clarity,
11046 and to avoid GCC warning about integer overflow.
11047
c20db43f
PE
11048 * intervals.h (struct interval): Use EMACS_INT for members
11049 where EMACS_UINT might cause problems. See
11050 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11051 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11052 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11053 All uses changed.
37aa2f85
PE
11054 (offset_intervals): Tell GCC not to worry about length overflow
11055 when negating a negative length.
c20db43f 11056
2538aa2f
PE
11057 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11058 (overrun_check_free): Likewise.
11059
f2d3008d
PE
11060 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11061 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11062 word size.
11063
ec8df744
PE
11064 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11065 (gnutls_make_error): Rename local to avoid shadowing.
11066 (gnutls_emacs_global_deinit): ifdef out; not used.
11067 (Fgnutls_boot): Use const for pointer to readonly storage.
11068 Comment out unused local. Fix pointer signedness problems.
11069
640ee02d
PE
11070 * lread.c (openp): Don't stuff size_t into an 'int'.
11071 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11072 about possible signed overflow.
11073
6048fb2a
PE
11074 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11075 (GDK_KEY_g): Don't define if already defined.
11076 (xg_prepare_tooltip): Avoid pointer signedness problem.
11077 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11078
fa3c87e1
PE
11079 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11080 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11081
2172544b
PE
11082 * xfns.c (Fx_window_property): Simplify a bit,
11083 to make a bit faster and to avoid GCC 4.6.0 warning.
11084 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11085
9b821a21
PE
11086 * fns.c (internal_equal): Don't assume size_t fits in int.
11087
3c616cfa
PE
11088 * alloc.c (compact_small_strings): Tighten assertion a little.
11089
c2982e87
PE
11090 Replace pEd with more-general pI, and fix some printf arg casts.
11091 * lisp.h (pI): New macro, generalizing old pEd macro to other
11092 conversion specifiers. For example, use "...%"pI"d..." rather
11093 than "...%"pEd"...".
11094 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11095 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11096 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11097 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11098 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11099 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11100 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11101 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11102 64-bit hosts.
11103 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11104 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11105 * print.c (safe_debug_print, print_object): Likewise.
11106 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11107 to int.
6f04d126
PE
11108 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11109 avoiding the 0 flag, which is not portable.
c2982e87
PE
11110 * process.c (Fmake_network_process): Use pI to avoid cast.
11111 * region-cache.c (pp_cache): Likewise.
11112 * xdisp.c (decode_mode_spec): Likewise.
11113 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11114 behavior on 64-bit hosts with printf arg.
6f04d126 11115 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11116 (x_stop_queuing_selection_requests): Likewise.
11117 (x_get_window_property): Don't truncate byte count to an 'int'
11118 when tracing.
0b432f21 11119
5e073ec7
PE
11120 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11121 here, since it parses constructs like leading '-' and spaces,
11122 which are not wanted; and it overflows with large numbers.
11123 Instead, simply match F[0-9]+, which is what is wanted anyway.
11124
36372bf9
PE
11125 * alloc.c: Remove unportable assumptions about struct layout.
11126 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11127 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11128 (allocate_vectorlike, make_pure_vector): Use the new macros,
11129 plus offsetof, to remove unportable assumptions about struct layout.
11130 These assumptions hold on all porting targets that I know of, but
11131 they are not guaranteed, they're easy to remove, and removing them
11132 makes further changes easier.
11133
0b432f21
PE
11134 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11135 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11136 (string_overrun_cookie): Now const. Use initializers that
11137 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11138 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11139 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11140 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11141 multiple of sizeof (EMACS_INT); it need not be, if
11142 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11143 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11144
895009e1
JB
111452011-04-26 Juanma Barranquero <lekktu@gmail.com>
11146
11147 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11148
6a7a1b0b
TZ
111492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11150
11151 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11152 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11153 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11154
841a1577 111552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11156
11157 * lisp.h (Qdebug): List symbol.
895009e1 11158 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11159 * keyboard.c (debug-on-event): New variable.
11160 (handle_user_signal): Break into debugger when debug-on-event
11161 matches the current signal symbol.
11162
f2d3ba6f
DN
111632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11164
11165 * alloc.c (check_sblock, check_string_bytes)
11166 (check_string_free_list): Convert to standard C.
11167
42ce4c63
TZ
111682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11169
11170 * w32.c (emacs_gnutls_push): Fix typo.
11171
825cd63c
EZ
111722011-04-25 Eli Zaretskii <eliz@gnu.org>
11173
fb11d64d
EZ
11174 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11175 "cast to pointer from integer of different size".
11176
825cd63c
EZ
11177 Improve doprnt and its use in verror. (Bug#8545)
11178 * doprnt.c (doprnt): Document the set of format control sequences
11179 supported by the function. Use SAFE_ALLOCA instead of always
11180 using `alloca'.
11181
11182 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11183 is one byte too soon. Don't use xrealloc; instead xfree and
11184 xmalloc anew.
11185
e061a11b
TZ
111862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11187
11188 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11189 callbacks stage.
11190
11191 * gnutls.c: Renamed global_initialized to
11192 gnutls_global_initialized. Added internals for the
11193 :verify-hostname-error, :verify-error, and :verify-flags
11194 parameters of `gnutls-boot' and documented those parameters in the
11195 docstring. Start callback support.
9173deec
JB
11196 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11197 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11198 on error. Return error code.
e061a11b
TZ
11199 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11200 (emacs_gnutls_read): Likewise.
11201 (Fgnutls_boot): Return handshake error code.
11202 (emacs_gnutls_handle_error): New function.
11203 (wsaerror_to_errno): Likewise.
11204
11205 * w32.h (emacs_gnutls_pull): Add prototype.
11206 (emacs_gnutls_push): Likewise.
11207
11208 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11209 (emacs_gnutls_push): Likewise.
11210
112112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11212
11213 * process.c (wait_reading_process_output): Check if GnuTLS
11214 buffered some data internally if no FDs are set for TLS
11215 connections.
11216
11217 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11218 (LIBS): Link to USER_LIBS.
11219 ($(BLD)/gnutls.$(0)): New target.
11220
fa6996bc
EZ
112212011-04-24 Eli Zaretskii <eliz@gnu.org>
11222
eb35682e
EZ
11223 * xdisp.c (handle_single_display_spec): Rename the
11224 display_replaced_before_p argument into display_replaced_p, to
11225 make it consistent with the commentary. Fix typos in the
11226 commentary.
11227
e2ad650c
EZ
11228 * textprop.c (syms_of_textprop): Remove dead code.
11229 (copy_text_properties): Delete obsolete commentary about an
11230 interface that was deleted long ago. Fix typos in the description
11231 of arguments.
11232
1b2de274
EZ
11233 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11234 to changes in oldXMenu/XMenu.h from 2011-04-16.
11235 <menu_help_message, prev_menu_help_message>: Constify.
11236 (IT_menu_make_room): menu->help_text is now `const char **';
11237 adjust.
11238
11239 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11240 to changes in oldXMenu/XMenu.h from 2011-04-16.
11241 (struct XMenu): Declare `help_text' `const char **'.
11242
11243 * xfaces.c <Qunspecified>: Make extern again.
11244
11245 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11246 required by POSIX.
1b2de274 11247
762b15be
EZ
11248 * doc.c (get_doc_string): Improve the format passed to `error'.
11249
11250 * doprnt.c (doprnt): Improve commentary.
11251
11252 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11253
11254 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11255 them with etags.
11256
f1052e5d
EZ
11257 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11258 changes in globals.h immediately force recompilation.
762b15be
EZ
11259 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11260 $(CURDIR)/s/ms-w32.h.
11261 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11262
fa6996bc
EZ
11263 * character.c (Fchar_direction): Function deleted.
11264 (syms_of_character): Don't defsubr it.
11265 <char-direction-table>: Deleted.
11266
e6c3da20
EZ
112672011-04-23 Eli Zaretskii <eliz@gnu.org>
11268
11269 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11270 * doprnt.c: Include limits.h.
11271 (SIZE_MAX): New macro.
04f2d78b
CB
11272 (doprnt): Return a size_t value. 2nd arg is now size_t.
11273 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11274 Improve overflow protection. Support `l' modifier for integer
11275 conversions. Support %l conversion. Don't assume an EMACS_INT
11276 argument for integer conversions and for %c.
11277
11278 * lisp.h (doprnt): Restore prototype.
11279
11280 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11281 $(SRC)/character.h.
11282
11283 * Makefile.in (base_obj): Add back doprnt.o.
11284
11285 * deps.mk (doprnt.o): Add back prerequisites.
11286 (callint.o): Depend on character.h.
11287
11288 * eval.c (internal_lisp_condition_case): Include the handler
11289 representation in the error message.
11290 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11291 when breaking from the loop.
11292
11293 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11294
11295 * callint.c (Fcall_interactively): When displaying error message
11296 about invalid control letter, pass the character's codepoint, not
11297 a pointer to its multibyte form. Improve display of the character
11298 in octal and display also its hex code.
11299
11300 * character.c (char_string): Use %x to display the (unsigned)
11301 codepoint of an invalid character, to avoid displaying a bogus
11302 negative value.
11303
11304 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11305 `error', not SYMBOL_NAME itself.
11306
11307 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11308 character arguments to `error'.
11309
11310 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11311 to `error' in error message about FINAL_CHAR argument. Make sure
11312 FINAL_CHAR is a character, and use %c when it is passed as
11313 argument to `error'.
11314
4ffd0d6b 113152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11316
11317 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11318
11319 * w32.c: Include <time.h>.
11320 (sys_localtime): New function.
11321
4ffd0d6b 113222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11323
11324 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11325
4ffd0d6b 11326 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11327
4ffd0d6b 113282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11329
4ffd0d6b
GM
11330 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11331 zombies (Bug#8467).
aac0c6e3 11332
04c56954
EZ
113332011-04-19 Eli Zaretskii <eliz@gnu.org>
11334
11335 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11336 gl_state.e_property when gl_state.object is Qt.
11337
11338 * insdel.c (make_gap_larger): Remove limitation of buffer size
11339 to <= INT_MAX.
11340
16a43933
CY
113412011-04-18 Chong Yidong <cyd@stupidchicken.com>
11342
11343 * xdisp.c (lookup_glyphless_char_display)
11344 (produce_glyphless_glyph): Handle cons cell entry in
11345 glyphless-char-display.
11346 (Vglyphless_char_display): Document it.
11347
11348 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11349 glyphless-char-display.
11350
4581706e
CY
113512011-04-17 Chong Yidong <cyd@stupidchicken.com>
11352
11353 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11354
11355 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11356
11357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11358 definition for no-X builds.
11359
4887c6e2 113602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11361
fd35b6f9
PE
11362 Static checks with GCC 4.6.0 and non-default toolkits.
11363
5c1ccb01
PE
11364 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11365
006c5daa
PE
11366 * process.c (keyboard_bit_set): Define only if SIGIO.
11367 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11368 (send_process): Repair possible setjmp clobbering.
11369
efc736d3
PE
11370 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11371
4e2fe2e6
PE
11372 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11373
f97334a2
PE
11374 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11375
4e75f29d
PE
11376 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11377 Define only if needed.
11378
90efadd1
PE
11379 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11380 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11381 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11382
3c647824
PE
11383 * dispextern.h (struct redisplay_interface): Rename param
11384 to avoid shadowing.
e264f262 11385 * termhooks.h (struct terminal): Likewise.
761383f4 11386 * xterm.c (xembed_send_message): Likewise.
3c647824 11387
b58c5c4a
PE
11388 * insdel.c (make_gap_smaller): Define only if
11389 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11390
cad59032
PE
11391 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11392 it.
11393
c339dc2e
PE
11394 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11395 so that we aren't warned about unused symbols.
11396
91a3e27b
PE
11397 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11398
399c71d3 11399 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11400
8ffc96f5
PE
11401 * xfns.c (x_real_positions): Mark locals as initialized.
11402
eef9bc79
PE
11403 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11404
098db9dd
PE
11405 * xterm.c: Fix problems found by static analysis with other toolkits.
11406 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11407 (x_dispatch_event): Declare static if USE_GTK, and
11408 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11409 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11410 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11411 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11412 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11413
eb18f6cc
PE
11414 * xmenu.c (menu_help_callback): Pointer type fixes.
11415 Use const pointers when pointing at readonly data. Avoid pointer
11416 signedness clashes.
11417 (FALSE): Remove unused macro.
11418 (update_frame_menubar): Remove unused decl.
11419
1fe72bf8
PE
11420 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11421
60d9e1db
PE
11422 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11423 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11424 (single_menu_item): Rename local to avoid shadowing.
11425
39261c26
PE
11426 * keyboard.c (make_lispy_event): Remove unused local var.
11427
018c5e19
PE
11428 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11429 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11430
63d2b86e
PE
11431 * bitmaps: Change bitmaps from unsigned char back to the X11
11432 compatible char. Avoid the old compiler warnings about
11433 out-of-range initializers by using, for example, '\xab' rather
11434 than 0xab.
11435
aefd87e1
PE
11436 * xgselect.c (xgselect_initialize): Check vs interface
11437 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11438
bf501fb9
PE
11439 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11440
e9829fdf
PE
11441 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11442 to read-only memory.
11443
1086c095
PE
11444 * fns.c (vector): Remove; this old hack is no longer needed.
11445
2baccd04 11446 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11447 Remove unused var.
dde42981 11448 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11449
72391843 11450 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11451
436c16df 11452 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11453 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11454 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11455
92bb796d 11456 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11457 (x_term_init): Remove local to avoid shadowing.
92bb796d 11458
764430a3 11459 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11460
11461 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11462 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11463
d1dfb56c
EZ
114642011-04-16 Eli Zaretskii <eliz@gnu.org>
11465
c4354cb4
EZ
11466 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11467
d1dfb56c
EZ
11468 Fix regex.c, syntax.c and friends for buffers > 2GB.
11469 * syntax.h (struct gl_state_s): Declare character position members
11470 EMACS_INT.
11471
11472 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11473
04f2d78b
CB
11474 * textprop.c (verify_interval_modification, interval_of):
11475 Declare arguments EMACS_INT.
d1dfb56c
EZ
11476
11477 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11478 EMACS_INT.
11479
11480 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11481
11482 * indent.c (Fvertical_motion): Local variable it_start is now
11483 EMACS_INT.
11484
11485 * regex.c (re_match, re_match_2, re_match_2_internal)
11486 (bcmp_translate, regcomp, regexec, print_double_string)
11487 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11488 (re_compile_pattern, re_exec): Declare arguments and local
11489 variables `size_t' and `ssize_t' and return values `regoff_t', as
11490 appropriate.
11491 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11492 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11493 <compile_stack_type>: `size' and `avail' are now `size_t'.
11494
11495 * regex.h <regoff_t>: Use ssize_t, not int.
11496 (re_search, re_search_2, re_match, re_match_2): Arguments that
11497 specify buffer/string position and length are now ssize_t and
11498 size_t. Return type is regoff_t.
11499
613052cd
BK
115002011-04-16 Ben Key <bkey76@gmail.com>
11501
11502 * nsfont.m: Fixed bugs in ns_get_family and
11503 ns_descriptor_to_entity that were caused by using free to
11504 deallocate memory blocks that were allocated by xmalloc (via
11505 xstrdup). This caused Emacs to crash when compiled with
11506 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11507 --enable-checking=xmallocoverrun). xfree is now used to
11508 deallocate these memory blocks.
11509
4170f62f 115102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11511
71b41406
PE
11512 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11513
9587a89d
PE
11514 emacs_write: Accept and return EMACS_INT for sizes.
11515 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11516 et seq.
11517 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11518 Accept and return EMACS_INT.
11519 (emacs_gnutls_write): Return the number of bytes written on
11520 partial writes.
11521 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11522 (emacs_read, emacs_write): Remove check for negative size, as the
11523 Emacs source code has been audited now.
9587a89d
PE
11524 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11525 (emacs_read, emacs_write): Use it.
273a5f82
PE
11526 * process.c (send_process): Adjust to the new signatures of
11527 emacs_write and emacs_gnutls_write. Do not attempt to store
11528 a byte offset into an 'int'; it might overflow.
9587a89d 11529 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11530
3e047f51
PE
11531 * sound.c: Don't assume sizes fit in 'int'.
11532 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11533 Return EMACS_INT, not int.
3e047f51 11534 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11535 Accept EMACS_INT, not int.
11536 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11537 record read return values.
11538
cc39a9db
BK
115392011-04-15 Ben Key <bkey76@gmail.com>
11540
c9d0ec6d
JB
11541 * keyboard.c (Qundefined): Don't declare static since it is used
11542 in nsfns.m.
11543 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11544 static since they are used in nsfont.m.
cc39a9db 11545
6c60eb9f
SM
115462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11547
11548 * process.c (Qprocessp): Don't declare static.
11549 * lisp.h (Qprocessp): Declare again.
11550
7990b61a
JB
115512011-04-15 Juanma Barranquero <lekktu@gmail.com>
11552
11553 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11554
5d4cb038
PE
115552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11556
8bd7b830 11557 Improve C-level modularity by making more things 'static'.
cd64ea1d 11558
e3b27b31
PE
11559 Don't publish debugger-only interfaces to other modules.
11560 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11561 (verify_bytepos, count_markers): Move decls to the only modules
11562 that need them.
11563 * region-cache.h (pp_cache): Likewise.
11564 * window.h (check_all_windows): Likewise.
11565 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11566
5d4cb038
PE
11567 * sysdep.c (croak): Now static, if
11568 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11569 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11570
11571 * alloc.c (refill_memory_reserve): Now static if
11572 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11573 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11574
e87b6180
PE
11575 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11576 Define only if USE_LUCID.
11577
ac64929e
PE
11578 * xrdb.c (x_customization_string, x_rm_string): Now static.
11579
6f37259d
PE
11580 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11581 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11582
1683e3ab
PE
11583 * xdisp.c (draw_row_with_mouse_face): Now static.
11584 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11585
de9c2632
PE
11586 * window.h (check_all_windows): Mark externally visible.
11587
2b96acb7
PE
11588 * window.c (window_deletion_count): Now static.
11589
11590 * undo.c: Make symbols static if they're not exported.
11591 (last_undo_buffer, last_boundary_position, pending_boundary):
11592 Now static.
11593
50436f33
PE
11594 * textprop.c (interval_insert_behind_hooks): Now static.
11595 (interval_insert_in_front_hooks): Likewise.
11596
64520e5c
PE
11597 * term.c: Make symbols static if they're not exported.
11598 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11599 (max_frame_lines, tty_set_terminal_modes):
11600 (tty_reset_terminal_modes, tty_turn_off_highlight):
11601 (get_tty_terminal): Now static.
11602 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11603 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11604 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11605 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11606 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11607
1fa53021
PE
11608 * sysdep.c: Make symbols static if they're not exported.
11609 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11610 Now static.
11611 (sigprocmask_set, full_mask): Remove; unused.
11612 (wait_debugging): Mark as visible.
11613 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11614 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11615
d4b43b22
PE
11616 * syntax.c (syntax_temp): Define only if !__GNUC__.
11617
b7c513d0
PE
11618 * sound.c (current_sound_device, current_sound): Now static.
11619
989b29ad
PE
11620 * search.c (searchbufs, searchbuf_head): Now static.
11621
13a55a78
PE
11622 * scroll.c (scroll_cost): Remove; unused.
11623 * dispextern.h (scroll_cost): Remove decl.
11624
de68a1fc
PE
11625 * region-cache.h (pp_cache): Mark as externally visible.
11626
40ccffa6
PE
11627 * process.c: Make symbols static if they're not exported.
11628 (process_tick, update_tick, create_process, chan_process):
11629 (Vprocess_alist, proc_buffered_char, datagram_access):
11630 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11631 (deactivate_process): Mark defn as static, as well as decl.
11632 * lisp.h (create_process): Remove decl.
11633 * process.h (chan_process, Vprocess_alist): Remove decls.
11634
ad64fc97
PE
11635 * print.c: Make symbols static if they're not exported.
11636 (print_depth, new_backquote_output, being_printed, print_buffer):
11637 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11638 (print_interval, print_number_index, initial_stderr_stream):
11639 Now static.
11640 * lisp.h (Fprinc): Remove decl.
11641 (debug_output_compilation_hack): Mark as externally visible.
11642
adddb265
PE
11643 * sysdep.c (croak): Move decl from here to syssignal.h.
11644 * syssignal.h (croak): Put it here, so the API can be checked when
11645 'croak' is called from dissociate_if_controlling_tty.
11646
1717ede2
PE
11647 * minibuf.c: Make symbols static if they're not exported.
11648 (minibuf_save_list, choose_minibuf_frame): Now static.
11649 * lisp.h (choose_minibuf_frame): Remove decl.
11650
fa5fb2bc
PE
11651 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11652
1e3890d1
PE
11653 * lread.c: Make symbols static if they're not exported.
11654 (read_objects, initial_obarray, oblookup_last_bucket_number):
11655 Now static.
11656 (make_symbol): Remove; unused.
11657 * lisp.h (initial_obarray, make_symbol): Remove decls.
11658
8a1414fa
PE
11659 * keyboard.c: Make symbols static if they're not exported.
11660 (single_kboard, recent_keys_index, total_keys, recent_keys):
11661 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11662 (this_single_command_key_start, echoing, last_auto_save):
11663 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11664 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11665 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11666 (Vlispy_mouse_stem, double_click_count):
11667 Now static.
11668 (force_auto_save_soon): Define only if SIGDANGER.
11669 (ignore_mouse_drag_p): Now static if
11670 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11671 (print_help): Remove; unused.
11672 (stop_character, last_timer_event): Mark as externally visible.
11673 * keyboard.h (ignore_mouse_drag_p): Declare only if
11674 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11675 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11676 * lisp.h (echoing): Remove decl.
11677 (force_auto_save_soon): Declare only if SIGDANGER.
11678 * xdisp.c (redisplay_window): Simplify code, to make it more
11679 obvious that ignore_mouse_drag_p is not accessed if !defined
11680 USE_GTK && !defined HAVE_NS.
11681
93ea6e8f
PE
11682 * intervals.c: Make symbols static if they're not exported.
11683 (merge_properties_sticky, merge_interval_right, delete_interval):
11684 Now static.
11685 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11686
77382fcc
PE
11687 * insdel.c: Make symbols static if they're not exported.
11688 However, leave prepare_to_modify_buffer alone. It's never
11689 called from outside this function, but that appears to be a bug.
11690 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11691 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11692 (adjust_after_replace_noundo): Remove; unused.
11693 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11694 (signal_before_change): Remove decls.
77382fcc 11695
9306c32e
PE
11696 * indent.c (val_compute_motion, val_vmotion): Now static.
11697
cd44d2eb
PE
11698 * image.c: Make symbols static if they're not exported.
11699 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11700 if USE_GTK.
11701 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11702 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11703
ad9a7a06
PE
11704 * fringe.c (standard_bitmaps): Now static.
11705 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11706
81626931
PE
11707 * frame.c: Make symbols static if they're not exported.
11708 (x_report_frame_params, make_terminal_frame): Now static.
11709 (get_frame_param): Now static, unless HAVE_NS.
11710 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11711 (x_get_resource_string): Remove; not used.
11712 * frame.h (make_terminal_frame, x_report_frame_params):
11713 (x_get_resource_string); Remove decls.
11714 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11715 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11716
239f9db9
PE
11717 * font.c, fontset.c: Make symbols static if they're not exported.
11718 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11719 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11720 * font.c (font_close_object): Now static.
11721 * font.h (font_close_object): Remove.
11722 * fontset.c (FONTSET_OBJLIST): Remove.
11723 (free_realized_fontset) #if-0 the body, which does nothing.
11724 (face_suitable_for_char_p): #if-0, as it's never called.
11725 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11726 * xfaces.c (face_at_string_position):
11727 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11728 since 0 is always ASCII.
11729
dfcf3579
PE
11730 * fns.c (weak_hash_tables): Now static.
11731
5045092b
PE
11732 * fileio.c: Make symbols static if they're not exported.
11733 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11734 (Vwrite_region_annotation_buffers): Now static.
11735
57a96f5c
PE
11736 * eval.c: Make symbols static if they're not exported.
11737 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11738 * lisp.h (backtrace_list): Remove decl.
11739
35f08c38
PE
11740 * emacs.c: Make symbols static if they're not exported.
11741 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11742 (fatal_error_code, fatal_error_signal_hook, standard_args):
11743 Now static.
11744 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11745 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11746 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11747 * lisp.h (fatal_error_signal_hook): Remove decl.
11748 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11749
f44bd759
PE
11750 * editfns.c: Move a (normally-unused) function to its only use.
11751 * editfns.c, lisp.h (get_operating_system_release): Remove.
11752 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11753 worth the hassle of breaking this out.
11754
b532497d
PE
11755 * xterm.c: Make symbols static if they're not exported.
11756 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11757 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11758 (x_destroy_window, x_delete_display):
11759 Now static.
11760 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11761 (x_mouse_leave): Remove; unused.
11762 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11763 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11764 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11765 Remove decls.
11766 (x_mouse_leave): Declare only if WINDOWSNT.
11767 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11768 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11769 USE_X_TOOLKIT.
11770
1675728f
PE
11771 * ftxfont.c: Make symbols static if they're not exported.
11772 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11773 HAVE_FREETYPE.
11774 * font.h (ftxfont_driver): Likewise.
11775
e4cebfca
PE
11776 * xfns.c: Make symbols static if they're not exported.
11777 (x_last_font_name, x_display_info_for_name):
11778 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11779 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11780 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11781 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11782 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11783 (last_show_tip_args): Now static.
11784 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11785 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11786 (x_screen_planes): Remove; unused.
11787 * dispextern.h (x_screen_planes): Remove decl.
11788
5bf46f05
PE
11789 * dispnew.c: Make symbols static if they're not exported.
11790 * dispextern.h (redraw_garbaged_frames, scrolling):
11791 (increment_row_positions): Remove.
11792 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11793 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11794 Now static.
11795 (redraw_garbaged_frames): Remove; unused.
11796
435f4c28
PE
11797 * xfaces.c: Make symbols static if they're not exported.
11798 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11799 Remove decls.
11800 * xterm.h (defined_color): Remove decls.
11801 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11802 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11803 (menu_face_changed_default, defined_color, free_realized_face):
11804 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11805 (ascii_face_of_lisp_face): Remove; unused.
11806
8524aef3
PE
11807 * xdisp.c: Make symbols static if they're not exported.
11808 * dispextern.h (scratch_glyph_row, window_box_edges):
11809 (glyph_to_pixel_coords, set_cursor_from_row):
11810 (get_next_display_element, set_iterator_to_next):
11811 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11812 (show_mouse_face): Remove decls
11813 * frame.h (message_buf_print): Likewise.
11814 * lisp.h (pop_message, set_message, check_point_in_composition):
11815 Likewise.
11816 * xterm.h (set_vertical_scroll_bar): Likewise.
11817 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11818 (message_buf_print, scratch_glyph_row, displayed_buffer):
11819 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11820 (get_next_display_element, show_mouse_face, window_box_edges):
11821 (frame_to_window_pixel_xy, check_point_in_composition):
11822 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11823 (glyph_to_pixel_coords): Remove; unused.
11824
16390cd2
PE
11825 * dired.c (file_name_completion): Now static.
11826
11827 * dbusbind.c (xd_in_read_queued_messages): Now static.
11828
a25f4dfa
PE
11829 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11830 * data.c (circular_list_error): Remove.
11831
14a9c8df
PE
11832 * commands.h (last_point_position, last_point_position_buffer):
11833 (last_point_position_window): Remove decls.
11834 * keyboard.c: Make these variables static.
11835
04f2d78b
CB
11836 * coding.h (coding, code_convert_region, encode_coding_gap):
11837 Remove decls.
74ab6df5
PE
11838 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11839 (iso_code_class, detect_coding, code_convert_region): Now static.
11840 (encode_coding_gap): Remove; unused.
11841
38dfbee1
PE
11842 * chartab.c (chartab_chars, chartab_bits): Now static.
11843
a2cb4e63
PE
11844 * charset.h (charset_iso_8859_1): Remove decl.
11845 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11846 Now static.
11847
127198fd
PE
11848 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11849 * ccl.c (Vccl_program_table): Now static.
11850 (check_ccl_update): Remove; unused.
11851
d85b608f
PE
11852 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11853 * category.h: ... from here.
11854 * category.c (check_category_table, set_category_set): Now static.
11855
31cd66f3
PE
11856 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11857 * lisp.h: Remove these decls.
11858
c358e587
PE
11859 * buffer.c (buffer_count): Remove unused var.
11860
e78aecca
PE
11861 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11862 so that it's not optimized away.
11863 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11864 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11865 exported only to the debugger.
11866
e192d7d3 11867 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11868 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11869
92470028
PE
11870 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11871 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11872 was inaccessible from Lisp.
11873 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11874 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11875
244ed907
PE
11876 alloc.c: Import and export fewer symbols, and remove unused items.
11877 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11878 is defined.
11879 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11880 it's not optimized away by whole-program optimization.
11881 (message_enable_multibyte, free_misc): Remove.
11882 (catchlist, handlerlist, mark_backtrace):
11883 Declare only if BYTE_MARK_STACK.
11884 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11885 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11886 (message_enable_multibyte): Remove decl.
11887 (free_misc, interval_free_list, float_block, float_block_index):
11888 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11889 (cons_free_list, last_marked_index):
11890 Now static.
11891 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11892 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11893 (mark_backtrace): Define only if BYTE_MARK_STACK.
11894 * xdisp.c (message_enable_multibyte): Now static.
11895
61c2b50e 11896 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11897 This makes it easier for human readers (and static analyzers)
11898 to see whether these variables are used from other modules.
11899 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11900 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11901 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11902 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11903 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11904 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11905 * xmenu.c, xselect.c:
11906 Declare Q* vars static if they are not used in other modules.
11907 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11908 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11909 Remove decls of unexported vars.
11910 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11911
95c82688
PE
11912 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11913
16a97296
PE
11914 Make Emacs functions such as Fatom 'static' by default.
11915 This makes it easier for human readers (and static analyzers)
11916 to see whether these functions can be called from other modules.
11917 DEFUN now defines a static function. To make the function external
11918 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11919 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11920 (Finit_image_library):
16a97296
PE
11921 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11922 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11923 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11924 Remove decls, since these functions are now static.
11925 (Funintern, Fget_internal_run_time): New decls, since these functions
11926 were already external.
95c82688 11927
16a97296
PE
11928 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11929 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11930 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11931 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11932 * keyboard.c, keymap.c, lread.c:
11933 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11934 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11935 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11936 Mark functions with DEFUE instead of DEFUN,
11937 if they are used in other modules.
11938 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11939 decls for now-static functions.
11940 * buffer.h (Fdelete_overlay): Remove decl.
11941 * callproc.c (Fgetenv_internal): Mark as internal.
11942 * composite.c (Fremove_list_of_text_properties): Remove decl.
11943 (Fcomposition_get_gstring): New forward static decl.
11944 * composite.h (Fcomposite_get_gstring): Remove decl.
11945 * dired.c (Ffile_attributes): New forward static decl.
11946 * doc.c (Fdocumntation_property): New forward static decl.
11947 * eval.c (Ffetch_bytecode): New forward static decl.
11948 (Funintern): Remove extern decl; now in .h file where it belongs.
11949 * fileio.c (Fmake_symbolic_link): New forward static decl.
11950 * image.c (Finit_image_library): New forward static decl.
11951 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11952 * intervals.h (Fprevious_property_change):
11953 (Fremove_list_of_text_properties): Remove decls.
11954 * keyboard.c (Fthis_command_keys): Remove decl.
11955 (Fcommand_execute): New forward static decl.
11956 * keymap.c (Flookup_key): New forward static decl.
11957 (Fcopy_keymap): Now static.
11958 * keymap.h (Flookup_key): Remove decl.
11959 * process.c (Fget_process): New forward static decl.
11960 (Fprocess_datagram_address): Mark as internal.
11961 * syntax.c (Fsyntax_table_p): New forward static decl.
11962 (skip_chars): Remove duplicate decl.
11963 * textprop.c (Fprevious_property_change): New forward static decl.
11964 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11965 Now internal.
11966 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11967 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11968
785bbd42
PE
11969 * editfns.c (Fformat): Remove unreachable code.
11970
8b913b57
AS
119712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11972
11973 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11974 change. (Bug#8496)
11975
a6744a35
EZ
119762011-04-13 Eli Zaretskii <eliz@gnu.org>
11977
11978 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11979 when at ZV. (Bug#8487)
11980
e7974947
AS
119812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11982
baad03f0
AS
11983 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11984 (Bug#8437)
11985 * keyboard.c (parse_tool_bar_item): Likewise.
11986 * sound.c (sound_cleanup, alsa_close): Likewise.
11987 * termcap.c (tgetent): Likewise.
11988 * xfns.c (x_default_font_parameter): Likewise.
11989 * xsettings.c (read_and_apply_settings): Likewise.
11990
e7974947
AS
11991 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11992 (overrun_check_free): Protoize.
11993
28272684
PE
119942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11995
11996 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11997 since callers should never pass a negative size.
11998 Change the signature to match that of plain 'read' and 'write'; see
11999 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12000 * lisp.h: Update prototypes of emacs_write and emacs_read.
12001
11997c76
EZ
120022011-04-11 Eli Zaretskii <eliz@gnu.org>
12003
12004 * xdisp.c (redisplay_window): Don't try to determine the character
12005 position of the scroll margin if the window start point w->startp
e896f03c 12006 is outside the buffer's accessible region. (Bug#8468)
11997c76 12007
8a2cbd72
EZ
120082011-04-10 Eli Zaretskii <eliz@gnu.org>
12009
12010 Fix write-region and its subroutines for buffers > 2GB.
12011 * fileio.c (a_write, e_write): Modify declaration of arguments and
12012 local variables to support buffers larger than 2GB.
12013 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12014
12015 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12016 argument, local variables, and return value.
12017
12018 * lisp.h: Update prototypes of emacs_write and emacs_read.
12019
12020 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12021
4073e537 120222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12023
1ebfdcb6
PE
12024 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12025
b2ded58d
PE
12026 Fix more problems found by GCC 4.6.0's static checks.
12027
7d66342c
PE
12028 * xdisp.c (vmessage): Use a better test for character truncation.
12029
bbf47d44
PE
12030 * charset.c (load_charset_map): <, not <=, for optimization,
12031 and to avoid potential problems with integer overflow.
9248994d 12032 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12033 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12034 * editfns.c (Fformat): Likewise.
1e69125e 12035 * syntax.c (skip_chars): Likewise.
3befa583 12036
e3019616
PE
12037 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12038 This also lets GCC 4.6.0 generate slightly better loop code.
12039
becfa255
PE
12040 * callint.c (Fcall_interactively): <, not <=, for optimization.
12041 (Fcall_interactively): Count the number of arguments produced,
12042 not the number of arguments given. This is simpler and lets GCC
12043 4.6.0 generate slightly better code.
12044
dae0cd48
PE
12045 * ftfont.c: Distingish more carefully between FcChar8 and char.
12046 The previous code passed unsigned char * to a functions like
12047 strlen and xstrcasecmp that expect char *, which does not
12048 conform to the C standard.
12049 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12050 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12051 char * when the C standard requires it.
12052
76032d70
PE
12053 * keyboard.c (read_char): Remove unused var.
12054
eb3f1cc8
PE
12055 * eval.c: Port to Windows vsnprintf (Bug#8435).
12056 Include <limits.h>.
12057 (SIZE_MAX): Define if the headers do not.
12058 (verror): Do not give up if vsnprintf returns a negative count.
12059 Instead, grow the buffer. This ports to Windows vsnprintf, which
12060 does not conform to C99. Problem reported by Eli Zaretskii.
12061 Also, simplify the allocation scheme, by avoiding the need for
12062 calling realloc, and removing the ALLOCATED variable.
12063
70476b54
PE
12064 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12065
12020a9e
PE
12066 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12067 But keep the doprint source code for now, as we might revamp it
12068 and use it again (Bug#8435).
ea6c7ae6
PE
12069 * lisp.h (doprnt): Remove.
12070 * Makefile.in (base_obj): Remove doprnt.o.
12071 * deps.mk (doprnt.o): Remove.
12072
5fdb398c
PE
12073 error: Print 32- and 64-bit integers portably (Bug#8435).
12074 Without this change, on typical 64-bit hosts error ("...%d...", N)
12075 was used to print both 32- and 64-bit integers N, which relied on
12076 undefined behavior.
61bdb816 12077 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12078 * lisp.h (error, verror): Mark as printf-like functions.
12079 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12080 Report overflow in size calculations when allocating printf buffer.
12081 Do not truncate output string at its first null byte.
12082 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12083 Truncate the output at a character boundary, since vsnprintf does not
12084 do that.
12085 * charset.c (check_iso_charset_parameter): Convert internal
12086 character to string before calling 'error', since %c now has the
12087 printf meaning.
12088 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12089 overflow when computing char to be passed to 'error'. Do not
12090 pass Lisp_Object to 'error'; pass the integer instead.
12091 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12092 formatted with plain %d.
12093
b189fa66
PE
12094 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12095
bff87ef0
PE
12096 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12097
7e2cac20
PE
12098 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12099
ce4d90b5
PE
12100 * xterm.c (x_catch_errors): Remove duplicate declaration.
12101
266c9547
PE
12102 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12103
79c49ad2
PE
12104 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12105
368f4090
JM
121062011-04-10 Jim Meyering <meyering@redhat.com>
12107
12108 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12109 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12110 return ssize_t not "int", and use size_t as the buffer length.
12111 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12112 * gnutls.h: Update declarations.
12113 * process.c (read_process_output): Use ssize_t, to match.
12114 (send_process): Likewise.
12115
a32d4040
CY
121162011-04-09 Chong Yidong <cyd@stupidchicken.com>
12117
12118 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12119
8546720e 121202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12121
04f2d78b
CB
12122 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12123 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12124
8546720e
GM
12125 * xterm.c (handle_one_xevent):
12126 * xmenu.c (create_and_show_popup_menu):
12127 * xselect.c (x_decline_selection_request)
12128 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12129
0a2f5c1a 121302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12131
12132 Fix some uses of `int' instead of EMACS_INT.
12133 * search.c (string_match_1, fast_string_match)
12134 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12135 (scan_buffer, find_next_newline_no_quit)
12136 (find_before_next_newline, search_command, Freplace_match)
12137 (Fmatch_data): Make some `int' variables be EMACS_INT.
12138
12139 * xdisp.c (display_count_lines): 3rd argument and return value now
12140 EMACS_INT. All callers changed.
12141 (pint2hrstr): Last argument is now EMACS_INT.
12142
12143 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12144 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12145 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12146 (decode_coding_utf_16, decode_coding_emacs_mule)
12147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12148 (decode_coding_ccl, decode_coding_charset)
12149 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12150 (decode_coding_iso_2022, decode_coding_emacs_mule)
12151 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12152 <char_offset, last_offset>: Declare EMACS_INT.
12153 (encode_coding_utf_8, encode_coding_utf_16)
12154 (encode_coding_emacs_mule, encode_invocation_designation)
12155 (encode_designation_at_bol, encode_coding_iso_2022)
12156 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12157 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12158 Declare EMACS_INT.
12159 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12160 (encode_invocation_designation): Last argument P_NCHARS is now
12161 EMACS_INT.
12162 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12163 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12164
12165 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12166 All users changed.
12167
12168 * ccl.c (Fccl_execute_on_string): Declare some variables
12169 EMACS_INT.
12170
8546720e 121712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12172
12173 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12174
4e19a977
CS
121752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12176
12177 * process.c (Fformat_network_address): Doc fix.
12178
87302331
R
121792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12180
ee7683eb 12181 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12182
cbb59342
CY
121832011-04-08 Chong Yidong <cyd@stupidchicken.com>
12184
12185 * keyboard.c (read_char): Call Lisp function help-form-show,
12186 instead of using internal_with_output_to_temp_buffer.
12187 (Qhelp_form_show): New var.
e0d38eeb 12188 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12189
12190 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12191
12192 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12193
e67a13ab
CY
121942011-04-06 Chong Yidong <cyd@stupidchicken.com>
12195
04f2d78b
CB
12196 * process.c (Flist_processes): Remove to Lisp.
12197 (list_processes_1): Delete.
e67a13ab 12198
973f782d
EZ
121992011-04-06 Eli Zaretskii <eliz@gnu.org>
12200
7c106b1e
EZ
12201 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12202
973f782d
EZ
12203 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12204
41cf7d1a 122052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12206
ca23cc88
PE
12207 Fix more problems found by GCC 4.6.0's static checks.
12208
f390e2d5
PE
12209 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12210
42eea0d0
PE
12211 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12212
b69769da 12213 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12214
f9541e84
PE
12215 * xdisp.c (vmessage): Mark as a printf-like function.
12216
13841b55
PE
12217 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12218
c136c10f
PE
12219 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12220
5e2d4a30
PE
12221 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12222 printf-like functions.
12223 (tiff_load): Add casts to remove these marks before passing them
12224 to system-supplied API.
12225
583f48b9
PE
12226 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12227
b25d760e
PE
12228 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12229 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12230 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12231 directly, rather than having caller test rule sign. This avoids
12232 some unnecessary tests.
12233 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12234 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12235 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12236
bc7b6697 12237 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12238 (xfont_open): Avoid unnecessary tests.
bc7b6697 12239
27ccc379
PE
12240 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12241
dcd5c89a
PE
12242 * composite.h, composite.c (composition_gstring_put_cache):
12243 Use EMACS_INT, not int, for length.
12244
b13a45c6
PE
12245 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12246 breaking out part of COMPOSITION_DECODE_RULE.
12247 (COMPOSITION_DECODE_RULE): Use it.
12248 * composite.c (get_composition_id): Remove unused local vars,
12249 by using the new macro.
12250
1e792e4d
PE
12251 * textprop.c (set_text_properties_1): Change while to do-while,
12252 since the condition is always true at first.
12253
dc6c6455 12254 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12255 (interval_deletion_adjustment): Return unsigned value.
12256 All uses changed.
dc6c6455 12257
aba7731a
PE
12258 * process.c (list_processes_1, create_pty, read_process_output):
12259 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12260 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12261 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12262 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12263 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12264
fdfc4bf3
PE
12265 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12266
fca8fe46 12267 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12268 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12269
06a0259a 12270 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12271 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12272 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12273
e7b9e80f
PE
12274 * print.c (print_error_message): Avoid int overflow.
12275
56201685
PE
12276 * font.c (font_list_entities): Redo for clarity,
12277 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12278
78834453 12279 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12280 (font_score): Avoid potential overflow in diff calculation.
78834453 12281
0bc0b309 12282 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12283 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12284
e610eaca
PE
12285 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12286
b895abce
PE
12287 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12288 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12289 can always succeed if overflow has undefined behavior.
12290
1f1d9321 12291 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12292 (wordify): Omit three unnecessary tests.
1f1d9321 12293
c59478bc
PE
12294 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12295 All callers changed. This avoids the need for an unused var.
12296
79b73827
PE
12297 * casefiddle.c (casify_region): Remove var that is set but not used.
12298
a4db5dfe
PE
12299 * dired.c (file_name_completion): Remove var that is set but not used.
12300
43aae36e
PE
12301 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12302
2a47c44d 12303 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12304 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12305
a37c69bf
PE
12306 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12307 Check for integer overflow on size calculations.
12308
328ab8e7
PE
12309 * buffer.c (Fprevious_overlay_change): Remove var that is set
12310 but not used.
12311
e5a2a5cb
PE
12312 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12313 Remove vars that are set but not used.
8d84a6eb 12314 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12315 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12316
a60e5f68
PE
12317 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12318
f661cb61 12319 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12320 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12321
f0397f5a
PE
12322 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12323 that are set but not used.
12324
8664db06 12325 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12326 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12327
6abdaa4a
PE
12328 * xselect.c (x_get_local_selection, x_handle_property_notify):
12329 Remove vars that are set but not used.
12330
0ce7538d 12331 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12332 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12333
9ae848fc
PE
12334 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12335 Remove var that is set but not used.
0b918413
PE
12336 (scroll_bar_windows_size): Now size_t, not int.
12337 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12338 Check for overflow.
9ae848fc 12339
a5a62657
PE
12340 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12341 (map_tty_color) [!defined MSDOS]: Likewise.
12342
5c5cdd39
PE
12343 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12344
66ebf983
PE
12345 * coding.c: Remove vars that are set but not used.
12346 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12347 All callers changed.
12348 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12349 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12350 (decode_coding_charset): Remove vars that are set but not used.
12351
1be4d761
PE
12352 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12353 that is set but not used.
12354
47553fa8
PE
12355 * print.c (print_object): Remove var that is set but not used.
12356
1f7196bf 12357 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12358 The gnulib version avoids calling malloc in the usual case,
12359 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12360 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12361 * filelock.c (current_lock_owner): Likewise.
12362 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12363 * sysdep.c: Include allocator.h, careadlinkat.h.
12364 (emacs_no_realloc_allocator): New static constant.
12365 (emacs_readlink): New function.
fdb61804
PE
12366 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12367 ../lib/careadlinkat.h.
d1fdcab7 12368
f84c17c7
SM
123692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12370
12371 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12372 first non-nil return value).
12373
ef3862ad
JD
123742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12375
12376 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12377 if not defined (Bug#8403).
12378
376a7006
JB
123792011-04-02 Juanma Barranquero <lekktu@gmail.com>
12380
12381 * xdisp.c (display_count_lines): Remove parameter `start',
12382 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12383 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12384 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12385 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12386 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12387 and thereabouts. All callers changed.
12388 (get_per_char_metric): Remove parameter `f', unused since
12389 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12390
6ca3801d
JM
123912011-04-02 Jim Meyering <meyering@redhat.com>
12392
12393 do not dereference NULL upon failed strdup
12394 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12395 (ns_get_family): Likewise.
12396
d8e2b5ba
JB
123972011-04-02 Juanma Barranquero <lekktu@gmail.com>
12398
12399 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12400
8c74fcbd
JD
124012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12402
12403 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12404 later (Bug#8403).
12405
7200d79c
SM
124062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12407
03408648 12408 Add lexical binding.
7200d79c 12409
03408648
SM
12410 * window.c (Ftemp_output_buffer_show): New fun.
12411 (Fsave_window_excursion):
12412 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12413
12414 * lread.c (lisp_file_lexically_bound_p): New function.
12415 (Fload): Bind Qlexical_binding.
12416 (readevalloop): Remove `evalfun' arg.
12417 Bind Qinternal_interpreter_environment.
12418 (Feval_buffer): Bind Qlexical_binding.
12419 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12420 Mark as dynamic.
12421 (syms_of_lread): Declare `lexical-binding'.
12422
12423 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12424
12425 * keyboard.c (eval_dyn): New fun.
12426 (menu_item_eval_property): Use it.
ca105506
SM
12427
12428 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12429
03408648
SM
12430 * fns.c (concat, mapcar1): Accept byte-code-functions.
12431
12432 * eval.c (Fsetq): Handle lexical vars.
12433 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12434 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12435 (FletX, Flet): Obey lexical binding.
12436 (Fcommandp): Handle closures.
12437 (Feval): New `lexical' arg.
12438 (eval_sub): New function extracted from Feval. Use it almost
12439 everywhere where Feval was used. Look up vars in lexical env.
12440 Handle closures.
12441 (Ffunctionp): Move from subr.el.
12442 (Ffuncall): Handle closures.
12443 (apply_lambda): Remove `eval_flags'.
12444 (funcall_lambda): Handle closures and new byte-code-functions.
12445 (Fspecial_variable_p): New function.
12446 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12447 but without exporting it to Lisp.
23aba0ea 12448
23aba0ea 12449 * doc.c (Fdocumentation, store_function_docstring):
03408648 12450 * data.c (Finteractive_form): Handle closures.
23aba0ea 12451
03408648
SM
12452 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12453 interactive spec.
ba83908c 12454
04f2d78b
CB
12455 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12456 New byte-codes.
03408648
SM
12457 (exec_byte_code): New function extracted from Fbyte_code to handle new
12458 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12459
03408648 12460 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12461
03408648 12462 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12463
e2abce01
JB
124642011-03-31 Juanma Barranquero <lekktu@gmail.com>
12465
12466 * xdisp.c (redisplay_internal): Fix prototype.
12467
63696a73 124682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12469
63696a73 12470 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12471 (try_scrolling): Use it when setting scroll_limit.
12472 Limit scrolling to 100 screen lines.
63696a73
EZ
12473 (redisplay_window): Even when falling back on "recentering",
12474 position point in the window according to scroll-conservatively,
12475 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12476
12477 (try_scrolling): When point is above the window, allow searching
12478 as far as scroll_max, or one screenful, to compute vertical
12479 distance from PT to the scroll margin position. This prevents
12480 try_scrolling from unnecessarily failing when
12481 scroll-conservatively is set to a value slightly larger than the
12482 window height. Clean up the case of PT below the margin at bottom
12483 of window: scroll_max can no longer be INT_MAX. When aggressive
12484 scrolling is in use, don't let point enter the opposite scroll
12485 margin as result of the scroll.
12486 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12487 threshold of 100 lines for never-recentering scrolling.
12488
e4cc2dfc
JB
124892011-03-31 Juanma Barranquero <lekktu@gmail.com>
12490
12491 * dispextern.h (move_it_by_lines):
12492 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12493 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12494 (message_log_check_duplicate): Remove parameters `prev_bol' and
12495 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12496 (redisplay_internal): Remove parameter `preserve_echo_area',
12497 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12498
12499 * indent.c (Fvertical_motion):
12500 * window.c (window_scroll_pixel_based, Frecenter):
12501 Don't pass `need_y_p' to `move_it_by_lines'.
12502
1c470562
SM
125032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12504
44f230aa
SM
12505 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12506 steal a few bits to be more compact.
12507 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12508 Remove unneeded casts.
12509
1c470562
SM
12510 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12511
888adce9
ZK
125122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12513
12514 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12515 binding" message (bug#7967).
12516
f838ed7b
PE
125172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12518
77861b95
PE
12519 Fix more problems found by GCC 4.6.0's static checks.
12520
de6dbc14
PE
12521 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12522 Remove unused local var.
12523
f838ed7b
PE
12524 * editfns.c (Fmessage_box): Remove unused local var.
12525
792c7b2b
PE
12526 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12527 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12528 Omit unused local vars.
c499e557 12529 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12530 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12531 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12532 Omit unused local var.
12533
ba0165e1
PE
12534 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12535 Don't assume string length fits in int.
32ad8845 12536 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12537 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12538
3c59b4c9
PE
12539 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12540 instead of alloca (Bug#8344).
12541
a3eed478 12542 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12543 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12544
eb4d412d
PE
12545 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12546
1658b401
PE
12547 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12548 concerns.
12549
12550 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12551
12552 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12553
9a2c6e05
PE
12554 * keyboard.c (syms_of_keyboard): Use the same style as later
12555 in this function when indexing through an array. This also
12556 works around GCC bug 48267.
12557
03d0a109
PE
12558 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12559
44f730c8
PE
12560 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12561
fe75f926
PE
12562 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12563 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12564
ffa8c828
PE
12565 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12566 This avoids undefined behavior on integer overflow, and is a bit
12567 more convenient anyway since it is compared to a size_t variable.
12568
c5101a77
PE
12569 Variadic C functions now count arguments with size_t, not int.
12570 This avoids an unnecessary limitation on 64-bit machines, which
12571 caused (substring ...) to crash on large vectors (Bug#8344).
12572 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12573 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12574 All variadic functions and their callers changed accordingly.
c5101a77
PE
12575 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12576 * data.c (arith_driver, float_arith_driver): Likewise.
12577 * editfns.c (general_insert_function): Likewise.
12578 * eval.c (struct backtrace.nargs, interactive_p)
12579 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12580 (funcall_lambda, mark_backtrace): Likewise.
12581 * fns.c (concat): Likewise.
12582 * frame.c (x_set_frame_parameters): Likewise.
12583 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12584 0 if not found, not -1. All callers changed.
12585
dd3f25f7
PE
12586 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12587 (stack_copy_size): Now size_t, not int.
12588 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12589
461c2ab9
JB
125902011-03-28 Juanma Barranquero <lekktu@gmail.com>
12591
12592 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12593 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12594 All callers changed.
12595
12596 * lisp.h (multibyte_char_to_unibyte):
12597 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12598 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12599 * character.h (CHAR_TO_BYTE8):
12600 * cmds.c (internal_self_insert):
12601 * editfns.c (general_insert_function):
12602 * keymap.c (push_key_description):
12603 * search.c (Freplace_match):
12604 * xdisp.c (message_dolog, set_message_1): All callers changed.
12605
f6d62986
SM
126062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12607
12608 * keyboard.c (safe_run_hook_funcall): New function.
12609 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12610 don't set the hook to nil, but remove the offending function instead.
12611 (Qcommand_hook_internal): Remove, unused.
12612 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12613 Vcommand_hook_internal.
12614
12615 * eval.c (enum run_hooks_condition): Remove.
12616 (funcall_nil, funcall_not): New functions.
12617 (run_hook_with_args): Call each function through a `funcall' argument.
12618 Remove `cond' argument, now redundant.
12619 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12620 (Frun_hook_with_args_until_failure): Adjust accordingly.
12621 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12622
1db5b1ad
JB
126232011-03-28 Juanma Barranquero <lekktu@gmail.com>
12624
12625 * dispextern.h (string_buffer_position): Remove declaration.
12626
12627 * print.c (strout): Remove parameter `multibyte', unused since
12628 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12629
12630 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12631 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12632 All callers changed.
12633
12634 * w32.c (_wsa_errlist): Use braces for struct initializers.
12635
12636 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12637 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12638 All callers changed.
12639 (string_buffer_position): Likewise. Also, make static (it's never
12640 used outside xdisp.c).
12641 (cursor_row_p): Remove parameter `w', unused since
12642 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12643 (decode_mode_spec): Remove parameter `precision', introduced during
12644 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12645 All callers changed.
12646
5ffb62aa
JD
126472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12648
12649 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12650
461c2ab9 126512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12652
12653 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12654 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12655 (ns_update_auto_hide_menu_bar): New functions.
12656 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12657 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12658 ns_constrain_all_frames.
12659 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12660 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12661
5c380ffb
JD
126622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12663
12664 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12665
9af30bdf
GM
126662011-03-27 Glenn Morris <rgm@gnu.org>
12667
12668 * syssignal.h: Replace RETSIGTYPE with void.
12669 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12670 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12671 Replace SIGTYPE with void everywhere.
12672 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12673 * s/template.h (SIGTYPE): Remove commented out definition.
12674
e2abce01
JB
126752011-03-26 Eli Zaretskii <eliz@gnu.org>
12676
12677 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12678 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12679
f868cd8a
JB
126802011-03-26 Juanma Barranquero <lekktu@gmail.com>
12681
59eb0929
JB
12682 * w32.c (read_unc_volume): Use parameter `henum', instead of
12683 global variable `wget_enum_handle'.
12684
12685 * keymap.c (describe_vector): Remove parameters `indices' and
12686 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12687 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12688
f868cd8a
JB
12689 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12690
12691 * keyboard.c (timer_check): Remove parameter `do_it_now',
12692 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12693 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12694 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12695
12696 * keyboard.c (read_char):
12697 * w32menu.c (w32_menu_display_help):
12698 * xmenu.c (show_help_event, menu_help_callback):
12699 Adjust calls to `show_help_echo'.
12700
12701 * gtkutil.c (xg_maybe_add_timer):
12702 * keyboard.c (readable_events):
12703 * process.c (wait_reading_process_output):
12704 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12705
12706 * insdel.c (adjust_markers_gap_motion):
12707 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12708 (gap_left, gap_right): Don't call it.
12709
2ecf6fdb
CY
127102011-03-25 Chong Yidong <cyd@stupidchicken.com>
12711
12712 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12713 incurred during fontification.
12714
6b1f9ba4
JB
127152011-03-25 Juanma Barranquero <lekktu@gmail.com>
12716
12717 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12718 (DEFVAR_PER_BUFFER): Don't pass it.
12719
12720 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12721 (scrolling_window): Don't pass it.
12722
0f4a96b5
JB
127232011-03-25 Juanma Barranquero <lekktu@gmail.com>
12724
12725 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12726
12727 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12728 and `suffix'.
12729 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12730 of variables specific to SELinux and computation of `encoded_absname'.
12731
12732 * image.c (XPutPixel): Remove unused variable `height'.
12733
12734 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12735
12736 * unexw32.c (get_section_info): Remove unused variable `section'.
12737
12738 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12739 (system_process_attributes): Remove unused variable `sess'.
12740 (sys_read): Remove unused variable `err'.
12741
12742 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12743 (w32_wnd_proc): Remove unused variable `isdead'.
12744 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12745 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12746 (x_create_tip_frame): Remove unused variable `tem'.
12747
12748 * w32inevt.c (w32_console_read_socket):
12749 Remove unused variable `no_events'.
12750
12751 * w32term.c (x_draw_composite_glyph_string_foreground):
12752 Remove unused variable `width'.
12753
1149507c
JB
127542011-03-24 Juanma Barranquero <lekktu@gmail.com>
12755
12756 * w32term.c (x_set_glyph_string_clipping):
12757 Don't pass uninitialized region to CombineRgn.
12758
9c88f339
JB
127592011-03-23 Juanma Barranquero <lekktu@gmail.com>
12760
12761 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12762 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12763 (Fx_close_connection): Remove unused variable `i'.
12764
12765 * w32font.c (w32font_draw): Return number of glyphs.
12766 (w32font_open_internal): Remove unused variable `i'.
12767 (w32font_driver): Add missing initializer.
12768
12769 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12770 (fill_in_menu): Remove unused variable `items_added'.
12771
12772 * w32term.c (last_mouse_press_frame): Remove static global variable.
12773 (w32_clip_to_row): Remove unused variable `f'.
12774 (x_delete_terminal): Remove unused variable `i'.
12775
12776 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12777 (NOTHING): Remove unused static global variable.
12778 (uniscribe_check_otf): Remove unused variable `table'.
12779 (uniscribe_font_driver): Add missing initializers.
12780
dee091a3
JD
127812011-03-23 Julien Danjou <julien@danjou.info>
12782
12783 * term.c (Fsuspend_tty, Fresume_tty):
12784 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12785 * window.c (temp_output_buffer_show):
12786 * insdel.c (signal_before_change):
12787 * frame.c (Fhandle_switch_frame):
12788 * fileio.c (Fdo_auto_save):
12789 * emacs.c (Fkill_emacs):
12790 * editfns.c (save_excursion_restore):
12791 * cmds.c (internal_self_insert):
12792 * callint.c (Fcall_interactively):
12793 * buffer.c (Fkill_all_local_variables):
12794 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12795 Use Frun_hooks.
0f4a96b5 12796 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12797 unconditionally since it does the check itself.
dee091a3 12798
2c520ab5 127992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12800
c9c49752
PE
12801 Fix more problems found by GCC 4.5.2's static checks.
12802
8abc3f12
PE
12803 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12804 the first time through the loop, since we know p0 < p1 then.
12805 This also avoids a gcc -Wstrict-overflow warning.
12806
a2d26660
PE
12807 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12808 leading to a memory leak, possible in functions like
12809 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12810 of objects (Bug#8318).
a2d26660 12811
916c72e9
PE
12812 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12813 that could (at least in theory) be that large.
12814
19ab8a18
PE
12815 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12816 This is less likely to overflow, and avoids undefined behavior if
12817 overflow does occur. All callers changed. Use strtoul to scan
12818 for the unsigned long integer.
b7cbbd6f
PE
12819 (pint2hrstr): Simplify and tune code slightly.
12820 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12821
f0641eff
PE
12822 * scroll.c (do_scrolling): Work around GCC bug 48228.
12823 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12824
7f650bb9
PE
12825 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12826 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12827 (validate_x_resource_name): Simplify count usage.
12828 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12829
37dd57d1
PE
12830 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12831 fail (Bug#8306).
81e56e61 12832
699979fc 12833 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12834
401bf9b4
PE
12835 * process.c (Fmake_network_process): Use socklen_t, not int,
12836 where POSIX says socklen_t is required in portable programs.
12837 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12838 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12839 (Fmake_network_process, server_accept_connection):
12840 (wait_reading_process_output, read_process_output):
12841 Likewise.
12842
b93aacde
PE
12843 * process.c: Rename or move locals to avoid shadowing.
12844 (list_processes_1, Fmake_network_process):
12845 (read_process_output_error_handler, exec_sentinel_error_handler):
12846 Rename or move locals.
4dc343ee 12847 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12848 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12849 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12850 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12851 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12852
af8a867c 12853 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12854 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12855 Include tparam.h instead, since it declares them.
af8a867c
PE
12856 * cm.h (PC): Remove extern decl; tparam.h now does this.
12857 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12858 * terminfo.c: Include tparam.h, to check interfaces.
12859 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12860 (tparam): Adjust signature to match interface in tparam.h;
12861 this removes some undefined behavior. Check that outstring and len
12862 are zero, which they always are with Emacs.
12863 * tparam.h (PC, BC, UP): New extern decls.
12864
0248044d 12865 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12866 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12867
8ff096c1 12868 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12869 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12870 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12871 (ftfont_list): Remove unused local.
49eaafba
PE
12872 (get_adstyle_property, ftfont_pattern_entity):
12873 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12874 Rename locals to avoid shadowing.
8ff096c1 12875
e2be39f6
PE
12876 * xfont.c (xfont_list_family): Mark var as initialized.
12877
c9735e30
PE
12878 * xml.c (make_dom): Now static.
12879
8f5201ae
PE
12880 * composite.c (composition_compute_stop_pos): Rename local to
12881 avoid shadowing.
b246f932
PE
12882 (composition_reseat_it): Remove unused locals.
12883 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12884 (composition_update_it): Mark var as initialized.
11b61122
PE
12885 (find_automatic_composition): Mark vars as initialized,
12886 with a FIXME (Bug#8290).
8f5201ae 12887
760fbc2c
PE
12888 character.h: Rename locals to avoid shadowing.
12889 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12890 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12891 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12892 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12893 to avoid shadowing.
12894
ff08eb85
PE
12895 * textprop.c (property_change_between_p): Remove; unused.
12896
fc7bf025
PE
12897 * intervals.c (interval_start_pos): Now static.
12898
235d7abc
PE
12899 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12900
44f230aa
SM
12901 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12902 Rename locals to avoid shadowing.
3e7d6594 12903
50060332
PE
12904 * sound.c (wav_play, au_play, Fplay_sound_internal):
12905 Fix pointer signedness.
d01f234b 12906 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12907 (wav_play): Initialize a variable to 0, to prevent undefined
12908 behavior (Bug#8278).
50060332 12909
c4fc4e30
PE
12910 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12911
918436ed
PE
12912 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12913
c939f91b
PE
12914 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12915 clobbering (Bug#8298).
b9c7f648
PE
12916 * sysdep.c (sys_subshell): Likewise.
12917 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12918
6bd8c144
PE
12919 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12920 This should get cleaned up, so that child_setup has the
12921 same signature on all platforms.
12922
7710357c 12923 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12924 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12925
c59da222
CY
129262011-03-22 Chong Yidong <cyd@stupidchicken.com>
12927
12928 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12929 not to be necessary, and produces flickering.
12930
66b87493
GM
129312011-03-20 Glenn Morris <rgm@gnu.org>
12932
12933 * config.in: Remove file.
12934
45b6f6d5
JB
129352011-03-20 Juanma Barranquero <lekktu@gmail.com>
12936
12937 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12938 are now in src/globals.h.
12939 (syms_of_minibuf): Remove spurious & from previous change.
12940
cd394be1 129412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12942
12943 * minibuf.c (completing-read-function): New variable.
12944 (completing-read-default): Rename from completing-read.
12945 (completing-read): Call completing-read-function.
12946
b14e3e21
CY
129472011-03-19 Juanma Barranquero <lekktu@gmail.com>
12948
12949 * xfaces.c (Fx_load_color_file):
12950 Read color file from absolute filename (bug#8250).
12951
f2b726e6
JB
129522011-03-19 Juanma Barranquero <lekktu@gmail.com>
12953
12954 * makefile.w32-in: Update dependencies.
12955
09f6ff02
EZ
129562011-03-17 Eli Zaretskii <eliz@gnu.org>
12957
12958 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12959
29a6015a
PE
129602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12961
a3a6c54e
PE
12962 Fix more problems found by GCC 4.5.2's static checks.
12963
b766f867
PE
12964 * process.c (make_serial_process_unwind, send_process_trap):
12965 (sigchld_handler): Now static.
12966
be02381c
PE
12967 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12968 That way, the code declares only the vars that it needs.
12969 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12970 * s/cygwin.h (PTY_ITERATION): Likewise.
12971 * s/darwin.h (PTY_ITERATION): Likewise.
12972 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12973
57048744
PE
12974 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12975 * process.c (allocate_pty): Don't declare stb unless it's needed.
12976
7914961c 12977 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12978 (CONSTANTLIM): Remove; unused.
12979 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12980 Define only if needed.
7914961c 12981
b3967b18
PE
12982 * unexelf.c (unexec): Name an expression,
12983 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12984 Use a different way to cause a compilation error if anyone uses
12985 n rather than nn, a way that does not involve shadowing.
73366a00 12986 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12987
29a6015a
PE
12988 * deps.mk (unexalpha.o): Remove; unused.
12989
43cfc33e 12990 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12991 * unexec.h: New file.
ce701a33
PE
12992 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12993 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12994 Depend on unexec.h.
12995 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12996 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12997 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12998 Change as necessary to match prototype in unexec.h.
ce701a33 12999
01f44d5a
PE
13000 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13001 shadowing.
4f63c6bb 13002 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13003
a6670b0b
PE
13004 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13005 Rename locals to avoid shadowing.
13006
cef2010d 13007 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13008 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13009
d4d7173a
PE
13010 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13011
f08b802a
PE
13012 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13013 warning when compiling print.c.
13014
3ddb0639
PE
13015 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13016 instead of using an uninitialized var.
5ad03b97 13017 (font_sort_entities): Mark var as initialized.
3ddb0639 13018
170a2692
PE
13019 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13020
e663c700
PE
13021 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13022 pointers to constants.
89bc529a 13023 (font_parse_fcname): Remove unused vars.
7b81e2d0 13024 (font_delete_unmatched): Now static.
ea838e10 13025 (font_get_spec): Remove; unused.
13a547c6
PE
13026 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13027 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13028 Rename or move locals to avoid shadowing.
e663c700 13029
2a80c887 13030 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13031 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13032
1384fa33 13033 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13034 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13035
8b2c52e9
PE
13036 * alloc.c (mark_backtrace): Move decl from here ...
13037 * lisp.h: ... to here, so that it can be checked.
13038
475545b5 13039 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13040 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13041 (lisp_indirect_variable): Name an expression,
13042 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13043 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13044
b1349114 13045 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13046 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13047 Use const pointer when appropriate.
b1349114 13048
a2928364
PE
13049 * lisp.h (get_system_name, get_operating_system_release):
13050 Move decls here, to check interfaces.
13051 * process.c (get_operating_system_release): Move decl to lisp.h.
13052 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13053 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13054 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13055 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13056 (Fformat_time_string, Fencode_time, Finsert_char):
13057 (Ftranslate_region_internal, Fformat):
13058 Rename or remove local vars to avoid shadowing.
9710023e 13059 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13060
a415e694
PE
13061 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13062 avoid shadowing.
13063
8ef4622d
PE
13064 * lisp.h (eassert): Check that the argument compiles, even if
13065 ENABLE_CHECKING is not defined.
13066
946f9a5b
PE
13067 * data.c (Findirect_variable): Name an expression, to avoid
13068 gcc -Wbad-function-cast warning.
112396d6 13069 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13070 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13071 (Fmake_variable_buffer_local, Fmake_local_variable):
13072 Mark variables as initialized.
52746918 13073 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13074
e5aab7e7 13075 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13076 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13077 Rename locals to avoid shadowing.
dff45157
PE
13078 (mark_stack): Move local variables into the #ifdef region where
13079 they're used.
7bc26fdb
PE
13080 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13081 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13082 needed otherwise.
13083 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13084 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13085 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13086
e5aab7e7
PE
13087 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13088 avoids undefined behavior in theory.
13089
4da60324
PE
13090 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13091
88043301
PE
13092 Use functions, not macros, for up- and down-casing (Bug#8254).
13093 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13095 to use the following functions instead of these macros.
13096 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13097 EMACS_INT, since callers assume the returned value fits in int.
13098 (upcase1): Likewise, for UPCASE_TABLE.
13099 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13100 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13101 the race-condition problem in the old DOWNCASE.
88043301 13102
19ed5445
PE
13103 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13104 Rename locals to avoid shadowing.
13105 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13106 (regex_compile, re_search_2, re_match_2_internal):
13107 Remove unused local vars.
952db0d7
PE
13108 (FREE_VAR): Rewrite so as not to use empty "else",
13109 which gcc can warn about.
da053e48 13110 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13111 (RETALLOC_IF): Define only if needed.
13112 (WORDCHAR_P): Likewise. This one is never needed, but is used
13113 only in a comment talking about a compiler bug, so put inside
13114 the #if 0 of that comment.
13115 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13116 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13117 Remove; unused.
19ed5445 13118
1f3561e4 13119 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13120 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13121 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13122
ded6f8f7
PE
13123 * search.c (simple_search): Remove unused var.
13124
dbd37a95
PE
13125 * dired.c (compile_pattern): Move decl from here ...
13126 * lisp.h: ... to here, so that it can be checked.
13127 (struct re_registers): New forward decl.
13128
7e47afad
PE
13129 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13130
85f24f61
PE
13131 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13132 All uses changed.
13133 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13134 Rename locals to avoid shadowing.
5671df8f 13135 (Fvertical_motion): Mark locals as initialized.
85f24f61 13136
181aa2be 13137 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13138 (casify_region): Mark local as initialized.
181aa2be 13139
930d429c
PE
13140 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13141
7082eac6
PE
13142 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13143 New macros, so that the caller can use some names other than
13144 gcpro1, gcpro2, etc.
13145 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13146 of the new macros.
13147 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13148 argument, for consistency with GCPRO2_VAR, etc: it is now the
13149 prefix of the variable, not the variable itself. All uses
13150 changed.
38b2c076
PE
13151 * dired.c (directory_files_internal, file_name_completion):
13152 Rename locals to avoid shadowing.
13153
15206ed9
PE
13154 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13155 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13156 dired.c's scmp function, had undefined behavior.
13157 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13159 * buffer.h: ... to here, because these macros use current_buffer,
13160 and the new implementation with inline functions needs to have
13161 current_buffer in scope now, rather than later when the macros
13162 are used.
13163 (downcase, upcase1): New static inline functions.
13164 (DOWNCASE, UPCASE1): Reimplement using these functions.
13165 This avoids undefined behavior in expressions like
13166 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13167 from race conditions in accessing the global variables
13168 case_temp1 and case_temp2.
13169 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13170 * lisp.h (case_temp1, case_temp2): Remove their decls.
13171 * character.h (ASCII_CHAR_P): Move from here ...
13172 * lisp.h: ... to here, so that the inline functions mentioned
13173 above can use them.
13174
4a6bea26
PE
13175 * dired.c (directory_files_internal_unwind): Now static.
13176
f14b7e14
PE
13177 * fileio.c (file_name_as_directory, directory_file_name):
13178 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13179 Now static.
2893f146
PE
13180 (file_name_as_directory): Use const pointers when appropriate.
13181 (Fexpand_file_name): Likewise. In particular, newdir might
13182 point at constant storage, so make it a const pointer.
fd4ead52 13183 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13184 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13185 signedness issues.
f839df0c
PE
13186 (Fset_file_times, Finsert_file_contents, auto_save_error):
13187 Rename locals to avoid shadowing.
f14b7e14 13188
5716756e 13189 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13190 (Ftry_completion, Fall_completions): Rename or remove locals
13191 to avoid shadowing.
5716756e 13192
b4c3046a
PE
13193 * marker.c (bytepos_to_charpos): Remove; unused.
13194
b45db522
PE
13195 * lisp.h (verify_bytepos, count_markers): New decls,
13196 so that gcc does not warn that these functions aren't declared.
13197
85876d07
PE
13198 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13199 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13200 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13201 (copy_text): Remove unused local var.
85876d07 13202
03d78a21 13203 * filelock.c (within_one_second): Now static.
b3dd38ab 13204 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13205
5df8f01b
PE
13206 * buffer.c (fix_overlays_before): Mark locals as initialized.
13207 (fix_start_end_in_overlays): Likewise. This function should be
13208 simplified by using pointers-to-pointers, but that's a different
13209 matter.
b1d876f1 13210 (switch_to_buffer_1): Now static.
8f54f30a
PE
13211 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13212 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13213
a70072c9 13214 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13215 Fix pointer signedness issue.
edced198
PE
13216 (sys_subshell): Mark local as volatile if checking for lint,
13217 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13218 (MAXPATHLEN): Define only if needed.
a70072c9 13219
a0977c44
PE
13220 * process.c (serial_open, serial_configure): Move decls from here ...
13221 * systty.h: ... to here, so that they can be checked.
13222
a884fdcc
PE
13223 * fns.c (get_random, seed_random): Move extern decls from here ...
13224 * lisp.h: ... to here, so that they can be checked.
13225
604efe86 13226 * sysdep.c (reset_io): Now static.
b8950c94 13227 (wait_for_termination_signal): Remove; unused.
604efe86 13228
38fc62d9
PE
13229 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13230 (copy_keymap_item, append_key, push_text_char_description):
13231 Now static.
1004a21a 13232 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13233 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13234 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13235 (describe_map_tree):
13236 Rename locals to avoid shadowing.
38fc62d9 13237
2f2650da
PE
13238 * keyboard.c: Declare functions static if they are not used elsewhere.
13239 (echo_char, echo_dash, cmd_error, top_level_2):
13240 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13241 (read_char, kbd_buffer_get_event, make_lispy_position):
13242 (make_lispy_event, make_lispy_movement, apply_modifiers):
13243 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13244 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13245 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13246 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13247 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13248
a053e86c 13249 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13250 (mark_kboards): Move decl here ...
13251 * alloc.c (mark_kboards): ... from here.
a053e86c 13252
4752793e
PE
13253 * lisp.h (force_auto_save_soon): New decl.
13254
74f10ca7 13255 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13256 (DEFINE_DUMMY_FUNCTION): New macro.
13257 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13258 Use it.
c03cd23f
PE
13259 (main): Add casts to avoid warnings
13260 if GCC considers string literals to be constants.
74f10ca7 13261
022e70d4
PE
13262 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13263
59d6fe83
PE
13264 * dbusbind.c: Pointer signedness fixes.
13265 (xd_signature, xd_append_arg, xd_initialize):
13266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13267 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13268 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13269 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13270
78320123
PE
13271 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13272 if GCC considers string literals to be constants.
49cebcca 13273 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13274
35ac2a97
SM
132752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13276
fb103ca9
SM
13277 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13278 (print_preprocess, print_object): New macro to fix last change.
13279
35ac2a97
SM
13280 * print.c (print_preprocess): Don't forget font objects.
13281
62973b41
JB
132822011-03-16 Juanma Barranquero <lekktu@gmail.com>
13283
13284 * emacs.c (USAGE3): Doc fixes.
13285
0e48bb22
AS
132862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13287
13288 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13289 structure.
13290
7684e57b
JB
132912011-03-14 Juanma Barranquero <lekktu@gmail.com>
13292
13293 * lisp.h (VWindow_system, Qfile_name_history):
13294 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13295 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13296 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13297
13298 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13299 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13300
13301 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13302 * w32console.c (detect_input_pending, read_input_pending)
13303 (encode_terminal_code):
13304 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13305 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13306 (w32_system_caret_y, Qfile_name_history):
13307 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13308 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13309 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13310 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13311 * w32proc.c (Qlocal, report_file_error):
13312 * w32term.c (Vwindow_system, updating_frame):
13313 * w32uniscribe.c (initialized, uniscribe_font_driver):
13314 Remove unneeded extern declarations.
13315
2aa46d6c
CY
133162011-03-14 Chong Yidong <cyd@stupidchicken.com>
13317
c96bbc66 13318 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13319
cffc6f3b
CY
133202011-03-13 Chong Yidong <cyd@stupidchicken.com>
13321
13322 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13323 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13324 These macros can no longer be used for assignment.
13325
44f230aa
SM
13326 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13327 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13328 (record_buffer_markers, fetch_buffer_markers): New functions for
13329 recording and fetching special buffer markers.
13330 (set_buffer_internal_1, set_buffer_temp): Use them.
13331
13332 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13333
13334 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13335
13336 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13337 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13338
13339 * xdisp.c (hscroll_window_tree):
13340 (reconsider_clip_changes): Use PT instead of BUF_PT.
13341
d251f04b
EZ
133422011-03-13 Eli Zaretskii <eliz@gnu.org>
13343
13344 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13345 $(EMACS_ROOT)/lib/intprops.h.
13346
f0c77cd1
PE
133472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13348
3eca4629
PE
13349 Fix more problems found by GCC 4.5.2's static checks.
13350
7c86ee98
PE
13351 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13352 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13353 (xg_free_frame_widgets): Make it clear that a local variable is
13354 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13355 (gdk_window_get_screen): Make it clear that this macro is needed
13356 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13357 (int_gtk_range_get_value): New function, which avoids a diagnostic
13358 from gcc -Wbad-function-cast.
13359 (xg_set_toolkit_scroll_bar_thumb): Use it.
13360 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13361 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13362 (get_utf8_string, xg_get_file_with_chooser):
13363 Rename locals to avoid shadowing.
13364 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13365
41729b81
PE
13366 * xgselect.c (xg_select): Remove unused var.
13367
f0c77cd1
PE
13368 * image.c (four_corners_best): Mark locals as initialized.
13369 (gif_load): Initialize transparent_p to zero (Bug#8238).
13370 Mark another local as initialized.
ec6cf4c6 13371 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13372
ce0ad53d 13373 * image.c (clear_image_cache): Now static.
d5d5a617 13374 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13375 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13376 (x_edge_detection): Remove unnecessary cast that
13377 gcc -Wbad-function-cast diagnoses.
2037898d 13378 (gif_load): Fix pointer signedness.
6ae141d6
PE
13379 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13380 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13381
33383987 133822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13383
d32df629
PE
13384 Improve quality of tests for time stamp overflow.
13385 For example, without this patch (encode-time 0 0 0 1 1
13386 1152921504606846976) returns the obviously-bogus value (-948597
13387 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13388 reports time overflow. See
13389 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13390 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13391 * editfns.c: Include limits.h and intprops.h.
13392 (TIME_T_MIN, TIME_T_MAX): New macros.
13393 (time_overflow): Move earlier, to before first use.
13394 (hi_time, lo_time): New functions, for an accurate test for
13395 out-of-range times.
13396 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13397 (Fget_internal_run_time): Don't assume time_t fits in int.
13398 (make_time): Use list2 instead of Fcons twice.
13399 (Fdecode_time): More accurate test for out-of-range times.
13400 (check_tm_member): New function.
13401 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13402 (lisp_time_argument): Don't rely on undefined left-shift and
13403 right-shift behavior when checking for time stamp overflow.
8be6f318 13404
fe31d94c
PE
13405 * editfns.c (time_overflow): New function, refactoring common code.
13406 (Fformat_time_string, Fdecode_time, Fencode_time):
13407 (Fcurrent_time_string): Use it.
13408
8be6f318
PE
13409 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13410 * dired.c (make_time): Move to ...
13411 * editfns.c (make_time): ... here.
13412 * systime.h: Note the move.
13413
09d9db2c 134142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13415
126bc0dc
YM
13416 * fringe.c (update_window_fringes): Remove unused variables.
13417
c47cbdfd
YM
13418 * unexmacosx.c (copy_data_segment): Also copy __got section.
13419 (Bug#8223)
13420
7ac80be9
EZ
134212011-03-12 Eli Zaretskii <eliz@gnu.org>
13422
c96bbc66 13423 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13424 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13425 Constify `char *' arguments and their references according to
13426 prototypes in tparam.h.
13427
ecb0f94d 13428 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13429
7ac80be9
EZ
13430 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13431 Adapt all references accordingly.
13432
13433 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13434
ef1fd07e
TT
134352011-03-11 Tom Tromey <tromey@redhat.com>
13436
13437 * buffer.c (syms_of_buffer): Remove obsolete comment.
13438
7ef4b50c
EZ
134392011-03-11 Eli Zaretskii <eliz@gnu.org>
13440
13441 * termhooks.h (encode_terminal_code): Declare prototype.
13442
13443 * msdos.c (encode_terminal_code): Don't declare prototype.
13444
13445 * term.c (encode_terminal_code): Now external again, used by
13446 w32console.c and msdos.c.
13447
44f230aa
SM
13448 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13449 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13450
4b1ec863 134512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13452
1714f52b 13453 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13454
4b1ec863
PE
13455 * fringe.c (update_window_fringes): Mark locals as initialized
13456 (Bug#8227).
13457 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13458
524c7aa6
PE
13459 * alloc.c (mark_fringe_data): Move decl from here ...
13460 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13461 to check its interface.
13462 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13463
a5c0af81 13464 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13465 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13466 (fontset_font): Mark local as initialized.
a9a06e0b 13467 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13468
b4716021
PE
13469 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13470
811e9bac 13471 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13472 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13473 (x_own_selection, Fx_disown_selection_internal): Rename locals
13474 to avoid shadowing.
13475 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13476
7e3ab302
PE
13477 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13478 so that the caller can use some name other than gcpro1.
13479 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13480 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13481 (Fx_backspace_delete_keys_p):
13482 Use them to avoid shadowing, and rename vars to avoid shadowing.
13483 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13484 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13485 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13486 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13487 Remove unused locals.
7e3ab302
PE
13488 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13489 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13490 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13491 macros.
f78faa98 13492
e2b13473
PE
13493 * xterm.h (x_mouse_leave): New decl.
13494
77f23912
PE
13495 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13496 Remove unused functions.
cdf4ba58
PE
13497 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13498 (x_calc_absolute_position): Now static.
7411c686 13499 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13500 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13501 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13502 unless they are used.
38d0b34a
PE
13503 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13504 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13505 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13506 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13507 (x_error_catcher, x_connection_closed, x_error_handler):
13508 (x_error_quitter, xembed_send_message, x_iconify_frame):
13509 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13510 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13511 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13512
44f230aa
SM
13513 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13514 Rename or move locals to avoid shadowing.
6b463e58 13515 (tty_defined_color, merge_face_heights): Now static.
5967d051 13516 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13517 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13518 does not deduce is never used uninitialized.
73719eba
PE
13519 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13520 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13521
426994c3 13522 * terminal.c (store_terminal_param): Now static.
5489860b 13523
032f1620 13524 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13525 (set_frame_menubar): Remove unused local.
d4323972 13526 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13527 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13528 since they might point to immutable storage.
281585b0
PE
13529 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13530 since it's unused otherwise.
032f1620 13531
367c19e5 13532 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13533 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13534 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13535 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13536 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13537 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13538 does not deduce are never used uninitialized.
70739cbe 13539
07b48fa9
PE
13540 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13541
8868a238 13542 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13543 * window.c (window_loop, size_window):
13544 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13545
7e5cf297 13546 * window.c (display_buffer): Now static.
d6550a9f
PE
13547 (size_window): Mark variables that gcc -Wuninitialized
13548 does not deduce are never used uninitialized.
a586633d
PE
13549 * window.h (check_all_windows): New decl, to forestall
13550 gcc -Wmissing-prototypes diagnostic.
5b555da1 13551 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13552
f6095868
PE
13553 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13554 shadowing.
13555 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13556 Include <limits.h>.
13557 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13558 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13559 (load_charset_map): Mark variables that gcc -Wuninitialized
13560 does not deduce are never used uninitialized.
53df7c11 13561 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13562
f38b440c
PE
13563 * coding.c (coding_set_source, coding_set_destination):
13564 Use "else { /* comment */ }" rather than "else /* comment */;"
13565 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13566 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13567 a block, when the outer 'i' will do.
13568 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13569 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13571 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13572 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13573 Rename locals to avoid shadowing.
13574 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13575 * coding.c (emacs_mule_char, encode_invocation_designation):
13576 Now static, since they're not used elsewhere.
413bb2db 13577 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13578 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13579 (decode_coding_emacs_mule): Mark variables that gcc
13580 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13581 (detect_coding_iso_2022): Initialize a local variable that might
13582 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13583 this initialization is needed. (Bug#8211)
5f58e762
PE
13584 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13585 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13586 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13587 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13588 Remove unused macros.
f38b440c 13589
232b38b9 13590 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13591 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13592 * character.c (string_count_byte8): Likewise.
232b38b9 13593
fb90da1b
PE
13594 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13595 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13596
fb93dbc2
PE
13597 * chartab.c (copy_sub_char_table): Now static, since it's not used
13598 elsewhere.
5c156ace
PE
13599 (sub_char_table_ref_and_range, char_table_ref_and_range):
13600 Rename locals to avoid shadowing.
bbcd0949 13601 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13602
7d3b3862 13603 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13604 (BIDI_BOB): Remove unused macro.
7d3b3862 13605
6be7d3da
PE
13606 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13607 deduce are never used uninitialized.
c2ed9c8b 13608 * term.c (encode_terminal_code): Likewise.
6be7d3da 13609
75f8807f 13610 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13611
50938595
PE
13612 * tparam.h: New file.
13613 * term.c, tparam.h: Include it.
13614 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13615 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13616 Move these decls to tparam.h, and make them agree with what
13617 is actually in tparam.c. The previous trick of using incompatible
13618 decls in different modules does not conform to the C standard.
13619 All callers of tparam changed to use tparam's actual API.
13620 * tparam.c (tparam1, tparam, tgoto):
13621 Use const pointers where appropriate.
13622
fbceeba2
PE
13623 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13624 * cm.h (struct cm): Likewise.
13625 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13626 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13627 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13628 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13629 (turn_on_face, init_tty): Likewise.
13630 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13631
7f3f1250
PE
13632 * term.c (term_mouse_position): Rename local to avoid shadowing.
13633
e6ca6543
PE
13634 * alloc.c (mark_ttys): Move decl from here ...
13635 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13636
c40f8d15
AS
136372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13638
13639 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13640
cfe0661d
JB
136412011-03-09 Juanma Barranquero <lekktu@gmail.com>
13642
13643 * search.c (compile_pattern_1): Remove argument regp, unused since
13644 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13645 (compile_pattern): Don't pass it.
13646
0afb4571
J
136472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13648
13649 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13650 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13651 for ! HAVE_GTK3.
13652 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13653
13654 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13655
13656 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13657 gdk_window_get_screen, gdk_window_get_geometry,
13658 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13659 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13660 (xg_get_pixbuf_from_pixmap): New function.
13661 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13662 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13663 Call xg_get_pixbuf_from_pixmap instead of
13664 gdk_pixbuf_get_from_drawable.
13665 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13666 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13667 (xg_check_special_colors): Use GtkStyleContext and its functions
13668 for HAVE_GTK3.
13669 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13670 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13671 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13672 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13673 Call gtk_widget_get_preferred_size.
0afb4571
J
13674 (xg_frame_resized): gdk_window_get_geometry only takes 5
13675 parameters.
44f230aa
SM
13676 (xg_win_to_widget, xg_event_is_for_menubar):
13677 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13678 (xg_set_widget_bg): New function.
13679 (delete_cb): New function.
895009e1 13680 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13681 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13682 (xg_set_background_color): Call xg_set_widget_bg.
13683 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13684 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13685 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13686 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13687 if ! HAVE_GTK3.
13688 (update_frame_tool_bar): Call gtk_widget_hide.
13689 (xg_initialize): Use GDK_KEY_g.
13690
13691 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13692 if ! HAVE_GTK3
13693 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13694
13695 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13696 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13697 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13698
1c2cc4ef
JB
136992011-03-08 Juanma Barranquero <lekktu@gmail.com>
13700
13701 * w32xfns.c (select_palette): Check success of RealizePalette against
13702 GDI_ERROR, not zero.
13703
33383987 13704See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13705
13706;; Local Variables:
13707;; coding: utf-8
aac0c6e3
MR
13708;; End:
13709
2f097256 13710 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13711
13712 This file is part of GNU Emacs.
13713
13714 GNU Emacs is free software: you can redistribute it and/or modify
13715 it under the terms of the GNU General Public License as published by
13716 the Free Software Foundation, either version 3 of the License, or
13717 (at your option) any later version.
13718
13719 GNU Emacs is distributed in the hope that it will be useful,
13720 but WITHOUT ANY WARRANTY; without even the implied warranty of
13721 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13722 GNU General Public License for more details.
13723
13724 You should have received a copy of the GNU General Public License
13725 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.