Stop ns builds setting the EMACSPATH environment variable
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7c4e8ec0
GM
12012-07-09 Glenn Morris <rgm@gnu.org>
2
cbb31951
GM
3 Stop ns builds setting the EMACSPATH environment variable.
4 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5 (ns_init_paths): Do not set EMACSPATH.
6 * nsterm.h (ns_exec_path): Add it.
7 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
8 Use ns_exec_path.
9
7c4e8ec0
GM
10 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
11
26bccfae
PE
122012-07-09 Paul Eggert <eggert@cs.ucla.edu>
13
a0bee46f
PE
14 * process.c (wait_reading_process_output): 'waitchannels' was unset
15 when read_kbd || !NILP (wait_for_cell); fix this.
16
5994c183
PE
17 Add GCC-style 'const' attribute to functions that can use it.
18 * character.h (char_resolve_modifier_mask):
19 * keyboard.h (make_ctrl_char):
20 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
21 (init_character_once, next_almost_prime, init_fns, init_image)
22 (flush_pending_output, init_sound):
23 * mem-limits.h (start_of_data):
24 * menu.h (finish_menu_items):
25 Add ATTRIBUTE_CONST.
26 * emacs.c (DEFINE_DUMMY_FUNCTION):
27 Declare the dummy function with ATTRIBUTE_CONST.
28 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
29 Add decls with ATTRIBUTE_CONST.
30
26bccfae
PE
31 Minor improvements to make_formatted_string.
32 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
33 where int is good enough, as vsprintf returns an int.
34 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
35
a8290ec3
DA
362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
37
38 Use make_formatted_string to avoid double length calculation.
39 * lisp.h (make_formatted_string): New prototype.
40 * alloc.c (make_formatted_string): New function.
41 * buffer.c (Fgenerate_new_buffer_name): Use it.
42 * dbus.c (syms_of_dbusbind): Likewise.
43 * editfns.c (Fcurrent_time_zone): Likewise.
44 * filelock.c (get_boot_time): Likewise.
45 * frame.c (make_terminal_frame, set_term_frame_name)
46 (x_report_frame_params): Likewise.
47 * image.c (gs_load): Likewise.
48 * minibuf.c (get_minibuffer): Likewise.
49 * msdos.c (dos_set_window_size): Likewise.
50 * process.c (make_process): Likewise.
51 * xdisp.c (ensure_echo_area_buffers): Likewise.
52 * xsettings.c (apply_xft_settings): Likewise.
53
d01ba2f1
GM
542012-07-09 Glenn Morris <rgm@gnu.org>
55
56 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
57 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
58 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
59 * nsterm.h (ns_etc_directory): Add it.
60 * callproc.c [HAVE_NS]: Include nsterm.h.
61 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
62
f1f924b6
DA
632012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Move marker debugging code under MARKER_DEBUG.
66 * marker.c (MARKER_DEBUG): Move marker debugging code under
67 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
68 for bootstrap with --enable-checking (~3x slowdown reported
69 by Juanma Barranquero <lekktu@gmail.com>).
70 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
71
ab531b66
PE
722012-07-08 Paul Eggert <eggert@cs.ucla.edu>
73
74 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
75 See <http://bugs.gnu.org/11825#29>.
76
c4b3bc8a
EZ
772012-07-08 Eli Zaretskii <eliz@gnu.org>
78
79 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
80 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
81 (display_line): Add commentary about displaying truncation glyphs
82 on GUI frames.
83 (produce_special_glyphs): Move here from term.c.
84
85 * term.c (produce_special_glyphs): Move to xdisp.c.
86
87 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
88 section.
c4b3bc8a 89
b676b881
AS
902012-07-07 Andreas Schwab <schwab@linux-m68k.org>
91
f17c5273
AS
92 * xdisp.c (display_line): Avoid warning about implicit declaration
93 of FRAME_FONT.
94
298819b9
AS
95 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
96
b676b881
AS
97 * lisp.h: Remove empty conditional.
98
6045c4fd
PE
992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
100
b3350bf9
PE
101 * lread.c (load_path_check): Now static.
102
6045c4fd
PE
103 Fix some minor --with-ns problems found by static checking.
104 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
105 (x_set_font) [!HAVE_X_WINDOWS]:
106 * image.c (xpm_load_image) [HAVE_NS]:
107 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
108 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
109 Remove unused local.
110 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
111 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
112 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
113 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
114 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
115 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
116 Fix pointer signedness problem.
117 * xfaces.c (FRAME_X_FONT_TABLE):
118 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
119
929e7845
GM
1202012-07-07 Glenn Morris <rgm@gnu.org>
121
122 * lread.c (load_path_check): New function, split from init_lread.
123 (init_lread): Reorganize. Motivation:
124 If EMACSLOADPATH is set, check/warn about that rather than the
125 defaults, which we are not going to use. Hence we can remove
126 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
127 Don't warn if site-lisp directories are missing.
128 If not installed, start from a blank load-path, since
129 PATH_LOADSEARCH refers to the eventual installation directories.
130
58dd0aa4
EZ
1312012-07-07 Eli Zaretskii <eliz@gnu.org>
132
133 Support truncation and continuation glyphs on GUI frames, when
134 fringes are disabled. (Bug#11832)
135 * xdisp.c (init_iterator): Get dimensions of truncation and
136 continuation glyphs even if on GUI frames. Adjust
137 it->last_visible_x on GUI frames when the left or right fringes,
138 or both, are absent.
139 (start_display, move_it_in_display_line_to): Handle the case of a
140 GUI frame without a fringe to display continuation or truncation
141 glyphs.
142 (insert_left_trunc_glyphs): Support GUI frames: make sure
143 truncation glyphs overwrite enough glyphs from the current line to
144 have sufficient space in pixels.
145 (display_line): Support truncation and continuation glyphs on GUI
146 frames. If some spare pixels are left on the line after inserting
147 the truncation glyphs, fill that space with a stretch glyph of a
148 suitably computed width.
149
150 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
151 produce_glyphs, to support GUI sessions.
152
31571fd7
PE
1532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
154
5a16b9bc
PE
155 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
156
f3047c75
PE
157 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
158
31571fd7
PE
159 Do not require float-time's arg to fit in time_t (Bug#11825).
160 This works better on hosts where time_t is unsigned, and where
161 float-time is applied to the (negative) difference between two times.
162 * editfns.c (decode_time_components): Last arg is now double *,
163 not int *, and means to store all the result as a double, without
164 worrying about whether the seconds part fits in time_t.
165 All callers changed.
166 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
167 All callers changed.
168 (Ffloat_time): Do not fail merely because the specified time falls
169 outside of time_t range.
170
4516fbef
GM
1712012-07-07 Glenn Morris <rgm@gnu.org>
172
173 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
174 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
175 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
176
07adc2c6
JB
1772012-07-07 Juanma Barranquero <lekktu@gmail.com>
178
179 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
180 Update dependencies.
181
182 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
183
fd573f31
PE
1842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
185
fee5959d
PE
186 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
187 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
188 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
189 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
190 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
191 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
192
fd573f31
PE
193 * xfont.c (compare_font_names): Redo to omit the need for casts.
194
ddadbc0e
AS
1952012-07-06 Andreas Schwab <schwab@linux-m68k.org>
196
fca8d6b6
AS
197 * xfns.c (Fx_change_window_property): Doc fix.
198 * w32fns.c (Fx_change_window_property): Doc fix.
199
ddadbc0e
AS
200 * w32fns.c (Fx_window_property): Accept the same arguments as the
201 X Windows version. Doc fix.
202 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
203
f247498e
JB
2042012-07-06 Juanma Barranquero <lekktu@gmail.com>
205 Eli Zaretskii <eliz@gnu.org>
206
207 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
208 Windows-specific code from nt/config.nt moved here.
209 Obsolete settings removed.
210
216ee680
PE
2112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
212
213 * process.c: Avoid unnecessary calls to gettime.
214 (wait_reading_process_output): Don't get the time of day
215 when gobbling data immediately and not waiting, as there's no need
216 for it in that case. This removes a FIXME.
217
bdd091e4
JD
2182012-07-06 Jan Djärv <jan.h.d@swipnet.se>
219
220 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
221 is defined (Bug#11768).
222
9d44f8ce
DA
2232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
224
225 Fix marker debugging code.
226 * marker.c (byte_char_debug_check): Do not perform the check
227 if buffer is not multibyte.
090bd7cb
JB
228 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
229 Call byte_char_debug_check with correct arguments.
9d44f8ce 230
90fc4786
DA
2312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
232
233 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
234 * marker.c (byte_char_debug_check, count_markers):
235 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
236 (byte_debug_flag): Remove.
237 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
238 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
239
7b7ae965
DA
2402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
241
4e57b342
DA
242 Avoid code repetition in marker-related functions.
243 * marker.c (attach_marker): New function.
244 (Fset_marker, set_marker_restricted, set_marker_both)
245 (set_marker_restricted_both): Use it.
246 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
247 Consistently rename charno to charpos.
248 (marker_position): Add eassert.
249 (marker_byte_position): Convert to eassert.
250
2512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
252
253 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 254 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 255 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 256
657924ff
DA
2572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
258
259 Introduce fast path for the widely used marker operation.
260 * alloc.c (build_marker): New function.
261 * lisp.h (build_marker): New prototype.
262 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
263 * composite.c (autocmp_chars): Likewise.
264 * editfns.c (buildmark): Remove.
265 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
266 (save_restriction_save): Use build_marker.
267 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
268 * window.c (save_window_save): Likewise.
269
041a49a6
DA
2702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
271
272 Do not use Fdelete_overlay in delete_all_overlays
273 to avoid redundant calls to unchain_overlay.
274 * buffer.c (drop_overlay): New function.
275 (delete_all_overlays, Fdelete_overlay): Use it.
276 * minibuf.c (get_minibuffer): Fix comment.
277
7dca65a4
PE
2782012-07-06 Paul Eggert <eggert@cs.ucla.edu>
279
280 Port to OpenBSD 5.1 amd64.
281 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
282 This is needed for OpenBSD, and should be harmless on all BSD systems.
283 Also, include <sys/sysctl.h>, as it should be available on all
284 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
285 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
286 use p_pid member, not kp_proc.pid.
287
8eb876e2
GM
2882012-07-06 Glenn Morris <rgm@gnu.org>
289
290 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
291
38182d90
PE
2922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
293
294 More xmalloc and related cleanup.
295 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
296 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
297 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
298 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
299 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
300 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
301 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
302 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
303 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
304 * xterm.c:
305 Omit needless casts involving void * pointers and allocation.
306 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
307 as the former is more robust if P's type is changed.
308 Prefer xzalloc to xmalloc + memset 0.
309 Simplify malloc-or-realloc to realloc.
310 Don't worry about xmalloc returning a null pointer.
311 Prefer xstrdup to xmalloc + strcpy.
312 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
313 growing it.
314 * keyboard.c (apply_modifiers_uncached): Prefer local array to
315 alloca of a constant.
316
6dd5a677
EZ
3172012-07-05 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (display_line): Fix horizontal pixel coordinates when
320 hscroll is larger than the line width. Fixes long and futile
321 looping inside extend_face_to_end_of_line (on a TTY) producing
322 glyphs that are not needed and thrown away.
323
6b312f0f
DA
3242012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
325
326 * marker.c (set_marker_restricted_both): Simplify by using
327 clip_to_bounds.
328
f520ef9b
PE
3292012-07-05 Paul Eggert <eggert@cs.ucla.edu>
330
331 * editfns.c (region_limit): Simplify by using clip_to_bounds.
332
383b7c95
JD
3332012-07-05 Jan Djärv <jan.h.d@swipnet.se>
334
335 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
336 not defined (Bug#11768).
337 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
338 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
339 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
340 followed by gtk_box_set_homogeneous (Bug#11768).
341 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
342 (update_theme_scrollbar_width, xg_create_scroll_bar):
343 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
344 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
345 (is_box_type): New function (Bug#11768).
346 (xg_tool_item_stale_p): Call is_box_type.
5293d758 347 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
348 with default display (Bug#11768).
349
d6e7bf45
EZ
3502012-07-05 Eli Zaretskii <eliz@gnu.org>
351
352 * xdisp.c (window_hscroll_limited): New function.
353 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
354 coordinates when window's hscroll is set to insanely large
355 values. (Bug#11857)
356
431391ec
JB
3572012-07-05 Juanma Barranquero <lekktu@gmail.com>
358
359 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
360 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
361
23f86fce
DA
3622012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Cleanup xmalloc.
365 * lisp.h (xzalloc): New prototype. Omit needless casts.
366 * alloc.c (xzalloc): New function. Omit needless casts.
367 * charset.c: Omit needless casts. Convert all calls to
368 xmalloc with following memset to xzalloc.
369 * dispnew.c: Likewise.
370 * fringe.c: Likewise.
371 * image.c: Likewise.
372 * sound.c: Likewise.
373 * term.c: Likewise.
374 * w32fns.c: Likewise.
375 * w32font.c: Likewise.
376 * w32term.c: Likewise.
377 * xfaces.c: Likewise.
378 * xfns.c: Likewise.
379 * xterm.c: Likewise.
380 * atimer.c: Omit needless casts.
381 * buffer.c: Likewise.
382 * callproc.c: Likewise.
383 * ccl.c: Likewise.
384 * coding.c: Likewise.
385 * composite.c: Likewise.
386 * doc.c: Likewise.
387 * doprnt.c: Likewise.
388 * editfns.c: Likewise.
389 * emacs.c: Likewise.
390 * eval.c: Likewise.
391 * filelock.c: Likewise.
392 * fns.c: Likewise.
393 * gtkutil.c: Likewise.
394 * keyboard.c: Likewise.
395 * lisp.h: Likewise.
396 * lread.c: Likewise.
397 * minibuf.c: Likewise.
398 * msdos.c: Likewise.
399 * print.c: Likewise.
400 * process.c: Likewise.
401 * region-cache.c: Likewise.
402 * search.c: Likewise.
403 * sysdep.c: Likewise.
404 * termcap.c: Likewise.
405 * terminal.c: Likewise.
406 * tparam.c: Likewise.
407 * w16select.c: Likewise.
408 * w32.c: Likewise.
409 * w32reg.c: Likewise.
410 * w32select.c: Likewise.
411 * w32uniscribe.c: Likewise.
412 * widget.c: Likewise.
413 * xdisp.c: Likewise.
414 * xmenu.c: Likewise.
415 * xrdb.c: Likewise.
416 * xselect.c: Likewise.
417
0497dc44
PE
4182012-07-05 Paul Eggert <eggert@cs.ucla.edu>
419
420 * fileio.c (time_error_value): Check the right error number.
421 Problem reported by Troels Nielsen in
422 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
423
356e7178
PE
4242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
425
4e71fd89
PE
426 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
427 This should be fixed in a better way; see Eli Zaretskii in
428 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
429 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
430
f0941253
PE
431 * fileio.c (time_error_value): Rename from special_mtime.
432 The old name's problems were noted by Eli Zaretskii in
433 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
434
065c9eb4
PE
435 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
436 This variable's comment says Emacs needs at least one GDB-visible
437 symbol of type enum pvec_type, to work around GDB problems.
438 The symbol's value doesn't matter.
439
356e7178
PE
440 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
441 that causes compilation to fail on pre-C99 compilers.
442
95f61aa2
JB
4432012-07-04 Juanma Barranquero <lekktu@gmail.com>
444
445 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
446 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
447
3884d954
DA
4482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
449
d209e2fb 450 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
451 headers for buffer_defaults and buffer_local_symbols.
452 Reported by Juanma Barranquero <lekktu@gmail.com>.
453
ee28be33
SM
4542012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
455
456 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
457 * lisp.h (enum pvec_type): Use fewer bits.
458 (PSEUDOVECTOR_SIZE_BITS): New constant.
459 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
460 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
461 change in pvec_type.
462 (PSEUDOVECTOR_TYPEP): New macro.
463 (TYPED_PSEUDOVECTORP): Use it.
464 * fns.c (internal_equal): Adapt code to extract pvectype.
465 * emacs.c (gdb_pvec_type): Update type.
466 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
467 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
468 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
469 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
470 (sweep_vectors): Use it. Use local var `total_bytes' instead of
471 abusing vector->header.next.nbytes.
472 (live_vector_p): Use PVEC_TYPE.
473 (mark_object): Adapt code to extract pvectype. Use switch.
474
c7f2cd7f
PE
4752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
476
477 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
478 Tighten new eassert a bit.
479
8ce70ed2
DA
4802012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Fix compilation with --enable-gcc-warnings and -O1
483 optimization level.
484 * doprnt.c (doprnt): Change type of tem to int, initialize
485 to avoid compiler warning. Add eassert.
486 * search.c (simple_search): Initialize match_byte to avoid
487 compiler warning. Add eassert.
488
dea7f1e5
PE
4892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
490
24a212eb
PE
491 Avoid weird behavior with large horizontal scrolls.
492 Without this change, for example, large hscroll values would
493 mess up Emacs's display on Fedora 15 x86, presumably due to
494 overflows in int calculations in the display code.
495 Also, if buffers had long lines, Emacs would freeze.
496 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
497 (set_window_hscroll): New function, containing the old guts of
498 Fset_window_hscroll. Return the clipped value.
499 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
500 This avoids the need to check against PTRDIFF_MAX.
501
dea7f1e5
PE
502 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
503
76046526
DA
5042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
505
506 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
507
39adff0d
PE
5082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
509
63807d47
PE
510 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
511 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
512 since GCC 4.4.6 issues a bogus warning for them.
513
39adff0d
PE
514 Fix bugs in file timestamp newness comparisons.
515 * fileio.c (Ffile_newer_than_file_p):
516 * lread.c (Fload): Use full timestamp resolution of files,
517 not just the 1-second resolution, so that files that are only
518 slightly newer still count as newer.
519 * fileio.c (Ffile_newer_than_file_p): Don't assume file
520 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
521
dbeed9a6
PE
5222012-07-03 Paul Eggert <eggert@cs.ucla.edu>
523
524 * fileio.c: Improve handling of file time marker. (Bug#11852)
525 (special_mtime): New function.
526 (Finsert_file_contents, Fverify_visited_file_modtime):
527 Use it to set special mtime values consistently.
528
636334d6
AS
5292012-07-03 Andreas Schwab <schwab@linux-m68k.org>
530
531 * fileio.c (Finsert_file_contents): Properly handle st_mtime
532 marker for non-existing file. (Bug#11852)
533
e2017fe2
GM
5342012-07-03 Glenn Morris <rgm@gnu.org>
535
536 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
537 and did not make it into globals.h).
538
404dbd37
TT
5392012-07-03 Tom Tromey <tromey@redhat.com>
540
541 * window.c (Fset_window_margins, Fset_window_fringes)
542 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
543 * textprop.c (Fprevious_property_change): No longer static.
544 * syntax.c (Fsyntax_table_p): No longer static.
545 * process.c (Fget_process, Fprocess_datagram_address): No longer
546 static.
547 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
548 * keyboard.c (Fcommand_execute): No longer static.
549 Remove EXFUN.
550 * insdel.c (Fcombine_after_change_execute): No longer static.
551 * image.c (Finit_image_library): No longer static.
552 * fileio.c (Fmake_symbolic_link): No longer static.
553 * eval.c (Ffetch_bytecode): No longer static.
554 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
555 * doc.c (Fdocumentation_property, Fsnarf_documentation):
556 No longer static.
404dbd37
TT
557 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
558 static.
559 * dired.c (Ffile_attributes): No longer static.
560 * composite.c (Fcomposition_get_gstring): No longer static.
561 * callproc.c (Fgetenv_internal): No longer static.
562
563 * ccl.h: Remove EXFUNs.
564 * buffer.h: Remove EXFUNs.
565 * dispextern.h: Remove EXFUNs.
566 * intervals.h: Remove EXFUNs.
567 * fontset.h: Remove EXFUN.
568 * font.h: Remove EXFUNs.
569 * dosfns.c (system_process_attributes): Remove EXFUN.
570 * keymap.h: Remove EXFUNs.
571 * lisp.h: Remove EXFUNs.
572 * w32term.h: Remove EXFUNs.
573 * window.h: Remove EXFUNs.
574 * xsettings.h: Remove EXFUN.
575 * xterm.h: Remove EXFUN.
576
8e4fd1e1
GM
5772012-07-03 Glenn Morris <rgm@gnu.org>
578
579 * lisp.h (Frandom): Make it visible to C.
580 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
581 buffer for invisible buffers. (Bug#1229)
582
ca95b3eb
DA
5832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
586 values which aren't power of 2.
587 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
588 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
589 accordingly.
590
7555c33f
SM
5912012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
592
593 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
594
595 * alloc.c (mark_object): Revert part of last patch to use `switch'.
596
d12e8f5a
DA
5972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * alloc.c (allocate_vector_block): Remove redundant
600 calls to mallopt if DOUG_LEA_MALLOC is defined.
601 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
602 avoid calls to mallopt if zero_vector is returned.
603
296094c3
DA
6042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
605
606 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
607 is enabled, avoid dereferencing NULL current_sblock if
608 running undumped.
609
36429c89
DA
6102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
611
612 Cleanup basic buffer management.
613 * buffer.h (struct buffer): Change layout to use generic vector
614 marking code. Fix some comments. Change type of 'clip_changed'
615 to bitfield. Remove unused #ifndef old.
616 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
617 (GET_OVERLAYS_AT): Fix indentation.
618 (for_each_per_buffer_object_at): New macro.
619 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
620 (Fbuffer_local_variables): Use it.
621 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
622 * alloc.c (allocate_buffer): Adjust to match new layout of
623 struct buffer. Fix comment.
624 (mark_overlay): New function.
625 (mark_buffer): Use it. Use mark_vectorlike to mark normal
626 Lisp area of struct buffer.
627 (mark_object): Use it. Adjust marking of misc objects
628 and related comments.
629
3b3e4cac
PE
6302012-07-02 Paul Eggert <eggert@cs.ucla.edu>
631
632 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
633 wrapper that is not needed because the wrapped code is a no-op (zero
634 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
635 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
636
cf5c0175
DA
6372012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
638
639 * alloc.c (mark_buffer): Simplify. Remove prototype.
640 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 641 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
642 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
643 redundant calls to mark_vectorlike for bool vectors.
644
ca26824c
GM
6452012-06-30 Glenn Morris <rgm@gnu.org>
646
2e4c5312
GM
647 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
648
ca26824c
GM
649 * epaths.in (PATH_SITELOADSEARCH): New.
650 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
651 This is rather than relying on --enable-locallisppath elements
652 having "site-lisp" in their names. (Bug#10208#25, 11658)
653
0d23c240
EZ
6542012-06-30 Eli Zaretskii <eliz@gnu.org>
655
c9240d7a
EZ
656 * w32proc.c (sys_select): Accept and ignore one more argument.
657
658 * w32.c (emacs_gnutls_pull): Call select with one more argument.
659
0d23c240 660 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 661 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
662
663 * sysdep.c: Don't include dos.h and dosfns.h.
664
665 * process.c (sys_select):
666 * msdos.c (sys_select): Accept one more argument and ignore it.
667
668 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
669 adapt data types and code to that.
670
671 * dosfns.c:
672 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
673 which clashes with the gnulib function of the same name.
674
af5a5a98
AS
6752012-06-30 Andreas Schwab <schwab@linux-m68k.org>
676
c5e4379c
AS
677 * font.c (font_style_to_value, font_style_symbolic)
678 (font_prop_validate_style): Add type checks for values in
679 font_style_table.
680
af5a5a98
AS
681 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
682 argument.
683 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
684 uses.
685
8d38f461
EZ
6862012-06-29 Eli Zaretskii <eliz@gnu.org>
687
2e5a6631
EZ
688 * xdisp.c (try_window_id): Undo last change.
689
8d38f461
EZ
690 * w32.c (getwd): Adjust commentary about startup_dir.
691 (init_environment): Always call sys_access, even in non-MSVC
692 builds. Don't chdir to the directory of the Emacs executable.
693 This undoes code from 1997 which was justified by the need to
694 "avoid conflicts when removing and renaming directories". But its
695 downside was that every relative file name was being interpreted
696 relative to the directory of the Emacs executable, which can never
697 be TRT. In particular, it broke sys_access when called with
698 relative file names.
699 (sys_access): Map GetLastError to errno.
700
2af3565e
DA
7012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
702
703 * window.h (struct window): Change type of 'fringes_outside_margins'
704 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 705 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
706 Adjust comment.
707 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
708 to ptrdiff_t.
709
c8d3a25c 7102012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 711
c8d3a25c
GM
712 * gnutls.c (emacs_gnutls_handshake):
713 Add QUIT to make the loop interruptible.
57570cd3 714
c8d3a25c 7152012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 716
c8d3a25c
GM
717 * charset.c (init_charset): Make lack of etc/charsets fatal.
718
3e984ee8
DA
7192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
720
721 * editfns.c (region_limit): Fix type mismatch.
722
ef884f23
DA
7232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
724
725 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
726 undefined. Convert from xassert to eassert.
727 * nsmenu.m: Convert from xassert to eassert.
728 * nsterm.m: Likewise.
729
7d7e0027
SM
7302012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * editfns.c (region_limit): Clip to narrowing (bug#11770).
733
aa754e6a
PE
7342012-06-28 Paul Eggert <eggert@cs.ucla.edu>
735
736 Avoid integer overflow on scroll-left and scroll-right.
737 * window.c (HSCROLL_MAX): New macro.
738 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
739 overflow when requested scroll falls outside ptrdiff_t range.
740
80b00b08
DA
7412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
742
743 * window.h (struct window): Change type of 'hscroll',
744 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
745 'last_modified' and 'last_overlay_modified' to EMACS_INT.
746 Adjust users accordingly.
747 * xdisp.c (try_cursor_movement): Replace type check with eassert.
748 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
749 from EMACS_INT to ptrdiff_t.
750 (make_window): Omit redundant initialization.
751
62b2bcf6
JB
7522012-06-28 Juanma Barranquero <lekktu@gmail.com>
753
754 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
755
45942c7d
DA
7562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
757
758 * window.h (struct window): Change type of 'use_time' and
759 'sequence_number' from Lisp_Object to int.
760 * frame.c (make_frame): Adjust users accordingly.
761 * print.c (print_object): Likewise.
762 * window.c (select_window, Fwindow_use_time, make_parent_window)
763 (make_window): Likewise.
764
e509cfa6
DA
7652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
766
767 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
768 enabled with --enable-checking=[all,glyphs] configure option.
769 Fix GLYPH_DEBUG usage assuming that it may be undefined,
770 adjust comments accordingly.
771 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
772 undefined, adjust comments accordingly.
773 * image.c: Likewise.
774 * scroll.c: Likewise.
775 * w32fns.c: Likewise.
776 * w32term.c: Likewise.
777 * xdisp.c: Likewise.
778 * xfaces.c: Likewise.
779 * xfns.c: Likewise.
780 * xterm.c: Likewise.
781
a54e2c05
DA
7822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
783
784 Generalize run-time debugging checks.
785 * dispextern.h (XASSERTS): Remove.
786 * fontset.c (xassert): Remove.
787 Convert from xassert to eassert.
788 * alloc.c: Convert from xassert to eassert.
789 * bidi.c: Likewise.
790 * dispnew.c: Likewise.
791 * fns.c: Likewise.
792 * fringe.c: Likewise.
793 * ftfont.c: Likewise.
794 * gtkutil.c: Likewise.
795 * image.c: Likewise.
796 * keyboard.c: Likewise.
797 * menu.c: Likewise.
798 * process.c: Likewise.
799 * scroll.c: Likewise.
800 * sound.c: Likewise.
801 * term.c: Likewise.
802 * w32console.c: Likewise.
803 * w32fns.c: Likewise.
804 * w32term.c: Likewise.
805 * window.c: Likewise.
806 * xdisp.c: Likewise.
807 * xfaces.c: Likewise.
808 * xfns.c: Likewise.
809 * xselect.c: Likewise.
810 * xterm.c: Likewise.
811
1ec4b7b2
SM
8122012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
813
814 * fns.c (maybe_resize_hash_table): Output message when growing the
815 purify-hashtable.
816
2014308a
DA
8172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
818
819 * alloc.c (allocate_string_data): Remove dead code.
820 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
821 avoid GCC warning about unused macro.
822
246155eb
DA
8232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
824
825 * alloc.c (allocate_string): Omit intervals initialization.
826 * alloc.c (make_uninit_multibyte_string): Initialize intervals
827 as in make_pure_string and make_pure_c_string.
828
43184b7b
DA
8292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
830
d209e2fb 831 * alloc.c (allocate_string): Fix last change.
43184b7b 832
3fe6dd74
DA
8332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
834
d209e2fb 835 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
836 to memset, add explicit initialization where appropriate.
837
1ba6038a
GM
8382012-06-27 Glenn Morris <rgm@gnu.org>
839
840 * lisp.mk (lisp): Remove paths.elc.
841
c89926a5
CY
8422012-06-27 Chong Yidong <cyd@gnu.org>
843
844 * doc.c (Fsubstitute_command_keys): Fix punctuation.
845
ed6b3510
JW
8462012-06-26 John Wiegley <johnw@newartisans.com>
847
1ec4b7b2 848 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
849 on Mac OS X Lion: __mod_init_func and __mod_term_func.
850
ed6b3510
JW
851 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
852 when building with Clang.
853
8edd4a2b
SM
8542012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * eval.c (Fapply): Allow calling it with a single argument.
857
f6f62d1b
EZ
8582012-06-26 Eli Zaretskii <eliz@gnu.org>
859
860 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
861 _stricmp and _strnicmp.
862 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
863
62efea5e
DA
8642012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
865
866 * alloc.c (allocate_window): Zero out non-Lisp part of newly
867 allocated window.
868 (allocate_process): Likewise for new process.
8edd4a2b 869 (allocate_terminal): Change to use offsetof.
62efea5e
DA
870 (allocate_frame): Likewise.
871 * frame.c (make_frame): Omit redundant initialization.
872 * window.c (make_parent_window): Use memset.
873 (make_window): Omit redundant initialization.
874 * process.c (make_process): Omit redundant initialization.
875 * terminal.c (create_terminal): Likewise.
876
42997f4d
DA
8772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * term.c (delete_tty): Remove redundant call to memset.
880
1130ecfc
DA
8812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
882
883 * alloc.c: Remove build_string.
884 * lisp.h: Define build_string as static inline. This provides
885 a better opportunity to optimize away calls to strlen when the
886 function is called with compile-time constant argument.
887 * image.c (imagemagick_error): Convert to build_string.
888 * w32proc.c (sys_spawnve): Likewise.
889 * xterm.c (x_term_init): Likewise.
890
cf38a720
PE
8912012-06-26 Paul Eggert <eggert@cs.ucla.edu>
892
99027bdd
PE
893 Use sprintf return value instead of invoking strlen on result.
894 In the old days this wasn't portable, since some sprintf
895 implementations returned char *. But they died out years ago and
896 Emacs already assumes sprintf returns int.
897 Similarly for float_to_string.
898 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
899 * ccl.c (ccl_driver):
900 * character.c (string_escape_byte8):
901 * data.c (Fnumber_to_string):
902 * doprnt.c (doprnt):
903 * print.c (print_object):
904 * xdisp.c (message_dolog):
905 * xfns.c (syms_of_xfns):
906 Use sprintf or float_to_string result to avoid need to call strlen.
907 * data.c (Fnumber_to_string):
908 Use make_unibyte_string, since the string must be ASCII.
909 * lisp.h, print.c (float_to_string): Now returns int length.
910 * term.c (produce_glyphless_glyph):
911 Use sprintf result rather than recomputing it.
912
cf38a720
PE
913 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
914 * Makefile.in (ALL_CFLAGS):
915 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
916 * gmalloc.c, regex.c: Include <config.h> unconditionally.
917
3511c784
DA
9182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
919
0a08eb21 920 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
921 strcasecmp if available.
922 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
923
fb7da12e
AS
9242012-06-25 Andreas Schwab <schwab@linux-m68k.org>
925
926 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
927 Avoid comma operator.
928 * menu.c (push_submenu_start, push_submenu_end)
929 (push_left_right_boundary, push_menu_pane): Likewise.
930 * msdos.c (dos_rawgetc): Likewise.
931
afa2ffd8
DA
9322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
933
934 * xfns.c (xic_create_fontsetname): Remove redundant calls
935 to memset.
936
b3b4476b
PE
9372012-06-25 Paul Eggert <eggert@cs.ucla.edu>
938
4495ff38
PE
939 * gtkutil.c (get_utf8_string): Remove redundant assignment.
940 sprintf already null-terminates its output.
941
b3b4476b
PE
942 * xfns.c (x_window): Remove redundant cast.
943
b00876c9
DA
9442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
945
946 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
947 `const char *' to `char *' to avoid compiler warning.
948
d188e26b
PE
9492012-06-24 Paul Eggert <eggert@cs.ucla.edu>
950
885d1d74
PE
951 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
952 instead of truncating it to 63 (admittedly a generous limit).
953
d188e26b
PE
954 * process.c: Fix spelling and caps in comments.
955
e2f560b1
DN
9562012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
957
e86db54b 958 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
959 * sysdep.c (setpgrp): Remove definition, not used in this file.
960
7583a3a1
JB
9612012-06-24 Juanma Barranquero <lekktu@gmail.com>
962
963 * makefile.w32-in: Update dependencies.
964
696056c2
EZ
9652012-06-24 Eli Zaretskii <eliz@gnu.org>
966
967 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
968 (SYSTIME_H): Add nt/inc/sys/time.h.
969
970 * systime.h [WINDOWSNT]: Include sys/time.h.
971
972 * s/ms-w32.h (struct timespec): Definition moved from
973 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
974
845ca893
PE
9752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
976
977 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
978 * buffer.h (buffer_slot_type_mismatch):
979 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
980 * eval.c (unwind_to_catch):
981 * image.c (my_png_error, my_error_exit):
982 * keyboard.c (quit_throw_to_read_char, user_error)
983 (Fexit_recursive_edit, Fabort_recursive_edit):
984 * lisp.h (die, args_out_of_range, args_out_of_range_3)
985 (wrong_type_argument, buffer_overflow, __executable_start)
986 (memory_full, buffer_memory_full, string_overflow, Fthrow)
987 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
988 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
989 (fatal):
990 (child_setup) [!DOS_NT]:
991 * lread.c (end_of_file_error, invalid_syntax):
992 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
993 * puresize.h (pure_write_error):
994 * search.c (matcher_overflow):
995 * sound.c (sound_perror, alsa_sound_perror):
996 * sysdep.c, syssignal.h (croak):
997 * term.c (maybe_fatal, vfatal):
998 * textprop.c (text_read_only):
999 * undo.c (user_error):
1000 * unexmacosx.c (unexec_error):
1001 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1002 Use _Noreturn rather than NO_RETURN.
1003 No need for separate decl merely because of _Noreturn.
1004 * sound.c (sound_warning, parse_sound):
1005 Remove unnecessary forward decls.
1006
f1dd8073
PE
10072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1010 * lisp.h (WAIT_READING_MAX): New macro.
1011 * dispnew.c (Fsleep_for, sit_for):
1012 * keyboard.c (kbd_buffer_get_event):
1013 * process.c (Faccept_process_output):
1014 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1015 This improves on the previous patch, which introduced a bug
1016 when time_t is unsigned and as wide as intmax_t.
1017 See <http://bugs.gnu.org/9000#51>.
1018
b82c1755
EZ
10192012-06-23 Eli Zaretskii <eliz@gnu.org>
1020
1021 * dispnew.c (sit_for, Fsleep_for):
1022 * keyboard.c (kbd_buffer_get_event):
1023 * process.c (Faccept_process_output): Avoid compiler warnings when
1024 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1025
ca300656
JB
10262012-06-23 Juanma Barranquero <lekktu@gmail.com>
1027
049ec95b
JB
1028 * makefile.w32-in: Update dependencies.
1029
ca300656
JB
1030 * w32.c (ltime): Add return type and declare static.
1031 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1032
db7b8d06
PE
10332012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1036 Privately reported by Herbert J. Skuhra.
1037 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1038 All uses changed.
1039 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1040 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1041
0bd8297f
EZ
10422012-06-23 Eli Zaretskii <eliz@gnu.org>
1043
96512555
EZ
1044 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1045 last argument of make_unibyte_string.
1046
0bd8297f
EZ
1047 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1048 language ID in the event parameters.
1049
1050 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1051 event.code, not the obscure "character set ID".
1052
63def6b6
CY
10532012-06-23 Chong Yidong <cyd@gnu.org>
1054
1055 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1056
e8a02204
EZ
10572012-06-23 Eli Zaretskii <eliz@gnu.org>
1058
388cdec0
EZ
1059 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1060 * w32.c (fdutimens): New function.
1061
1062 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1063
1064 * s/ms-w32.h (pselect): Redirect to sys_select.
1065
1066 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1067
e8a02204
EZ
1068 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1069 in the logic of incrementing and decrementing the value of
1070 use_relocatable_buffers.
1071
d054f3fb
PE
10722012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1075 Privately reported by Herbert J. Skuhra.
1076 [__FreeBSD__]: Remove "*/" typo after "#include".
1077 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1078 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1079 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1080 Don't assume EMACS_TIME and struct timeval are the same type.
1081
d35af63c
PE
10822012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 Support higher-resolution time stamps (Bug#9000).
1085 The time stamps are only nanosecond-resolution at the C level,
1086 since that's the best that any real-world system supports now.
1087 But they are picosecond-resolution at the Lisp level, as that's
1088 easy, and leaves room for future OS improvements.
1089
1090 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1091 (LIBES): Use it.
1092
1093 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1094 Don't get current time unless it's needed.
1095
1096 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1097 now provides it if it's absent.
1098 (start_atimer): Port to higher-res time stamps.
1099 Check for time stamp overflow. Don't get current time more
1100 often than is needed.
1101
1102 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1103 Include systime.h, not time.h.
1104 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1105
1106 * dired.c: Include stat-time.h.
1107 (Ffile-attributes): File times now have higher resolution.
1108
1109 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1110 (struct image): Timestamp now has higher resolution.
1111
1112 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1113 has at least microseconds now. All uses removed.
1114 (update_frame, update_single_window, update_window, update_frame_1)
1115 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1116
1117 * editfns.c (time_overflow): Now extern.
1118 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1119 (float-time, Fformat_time_string, Fcurrent_time_string)
1120 (Fcurrent_time_zone): Accept and generate higher-resolution
1121 time stamps.
1122 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1123 (decode_time_components, lisp_seconds_argument): New functions.
1124 (make_time): Now static.
1125 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1126 Report an error if the time is invalid, rather than having the caller
1127 do that.
1128
1129 * fileio.c: Include <stat-time.h>
1130 (Fcopy_file): Copy higher-resolution time stamps.
1131 Prefer to set the time stamp via a file descriptor if that works.
1132 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1133 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1134 (Fvisited_file_modtime, Fset_visited_file_modtime):
1135 Support higher-resolution time stamps.
1136
1137 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1138
1139 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1140
1141 * image.c (prepare_image_for_display, clear_image_cache)
1142 (lookup_image): Port to higer-resolution time stamps.
1143
1144 * keyboard.c (start_polling, bind_polling_period):
1145 Check for time stamp overflow.
1146 (read_char, kbd_buffer_get_event, timer_start_idle)
1147 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1148 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1149 Port to higher-resolution time stamps. Do not assume time_t is signed.
1150 (decode_timer): New function. Timers are now vectors of length 9,
1151 not 8, to accommodate the picosecond component.
1152 (timer_check_2): Use it.
1153
1154 * nsterm.m (select_timeout, timeval_subtract): Remove.
1155 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1156 as they're a bit more accurate and handle overflow better.
1157 (ns_select): Change prototype to be compatible with pselect.
1158 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1159 * nsterm.h (ns_select): Adjust prototype.
1160
1161 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1162 us-resolution time stamps.
1163 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1164
1165 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1166
1167 * lisp.h (time_overflow): New decl.
1168 (wait_reading_process_output): First arg is now intmax_t, not int,
1169 to accommodate larger waits.
1170
1171 * process.h (struct Lisp_Process.read_output_delay):
1172 Now counts nanoseconds, not microseconds.
1173 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1174 EMACS_HAS_USECS.
1175 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1176 (wait_reading_process_output):
1177 Port to ns-resolution time stamps.
1178 (Faccept_process_output, wait_reading_process_output):
1179 Check for time stamp overflow. Do not assume time_t is signed.
1180 (select_wrapper): Remove; we now use pselect.
1181 (Fprocess_attributes): Now generates ns-resolution time stamps.
1182
1183 * sysdep.c: Include utimens.h. Don't include utime.h
1184 or worry about struct utimbuf; gnulib does that for us now.
1185 (gettimeofday): Remove; gnulib provides a substitute.
1186 (make_timeval): New function.
1187 (set_file_times): Now sets ns-resolution time stamps.
1188 New arg FD; all uses changed.
1189 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1190 (system_process_attributes):
1191 Now returns ns-resolution time stamp. All uses changed.
1192 Check for time stamp overflow.
1193
1194 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1195 provides a substitute now.
1196
1197 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1198 since it guarantees struct timespec.
1199 (EMACS_TIME): Now struct timespec, so that we can support
1200 ns-resolution time stamps.
1201 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1202 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1203 (EMACS_USECS): Remove.
1204 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1205 so multiply the arg by 1000 before storing it.
1206 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1207 New macros.
1208 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1209 Port to ns-resolution time stamps.
1210 (EMACS_TIME_NEG_P): Remove; replaced by....
1211 (EMACS_TIME_SIGN): New macro.
1212 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1213 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1214 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1215 (make_timeval, make_lisp_time, decode_time_components): New decls.
1216 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1217 that it mishandled time_t overflow. You can't compare by subtracting!
1218 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1219 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1220
1221 * term.c: Include <sys/time.h>.
1222 (timeval_to_Time): New function, for proper overflow wraparound.
1223 (term_mouse_position, term_mouse_click): Use it.
1224
1225 * undo.c (record_first_change): Support higher-resolution time stamps
1226 in the undo buffer.
1227 (Fprimitive_undo): Use them when restoring time stamps.
1228
1229 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1230 (w32_get_internal_run_time):
1231 Port to higher-resolution Emacs time stamps.
1232 (ltime): Now accepts single 64-bit integer, as that's more convenient
1233 for callers.
1234
1235 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1236
1237 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1238 for compatibility with pselect. Support ns-resolution time stamps.
1239
1240 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1241
1242 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1243 Check for time stamp overflow, and support ns-resolution time stamps.
1244
1245 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1246 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1247 (timeval_subtract): Remove; no longer needed.
1248 (XTflash, XTring_bell, x_wait_for_event):
1249 Port to ns-resolution time stamps. Don't assume time_t is signed.
1250
b6a92dfe
CY
12512012-06-22 Chong Yidong <cyd@gnu.org>
1252
1253 * xdisp.c (x_consider_frame_title): Revert last change.
1254
d251c37c
EZ
12552012-06-22 Eli Zaretskii <eliz@gnu.org>
1256
1257 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1258 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1259 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1260 staticidx goes up to 1597 out of 1600 = 0x640.)
1261
f10deafb
PE
12622012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1265 Otherwise, the umask might be mistakenly 0 while handling input signals.
1266
ec6de1e2
SM
12672012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1268
1269 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1270
28be1ada
DA
12712012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1272
1273 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1274 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1275 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1276 access to `contents' member of Lisp_Vector objects with AREF and ASET
1277 where appropriate.
1278
c6bf3022
CY
12792012-06-19 Chong Yidong <cyd@gnu.org>
1280
1281 * frame.c (delete_frame): When selecting a frame on a different
1282 text terminal, do not alter the terminal's top-frame.
1283
1284 * xdisp.c (format_mode_line_unwind_data): Record the target
1285 frame's selected window and its terminal's top-frame.
1286 (unwind_format_mode_line): Restore them.
1287 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1288 Callers changed.
1289 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1290 since tty frames can be explicitly named.
1291 (prepare_menu_bars): Likewise.
1292
1293 * term.c (Ftty_top_frame): New function.
1294
defd4196
PE
12952012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 Port byte-code-meter to modern targets.
1298 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1299 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1300 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1301 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1302 (METER_1, METER_2): Simplify.
1303
1053a871
SM
13042012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1305
1306 * data.c (Fdefalias): Return `symbol' (bug#11686).
1307
b7e8d081
MR
13082012-06-18 Martin Rudalics <rudalics@gmx.at>
1309
1310 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1311 gets killed during executing of this function (Bug#11665).
1312 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1313 (Vkill_buffer_query_functions): In doc-string say that functions
1314 run by this hook should not change the current buffer.
1315
7ea2b339
PE
13162012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 Fix recently-introduced process.c problems found by static checking.
1319 * process.c (write_queue_push, write_queue_pop, send_process):
1320 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1321 (write_queue_pop): Fix pointer signedness problem.
1322 (send_process): Remove unused local.
1323
96a313a1
CY
13242012-06-17 Chong Yidong <cyd@gnu.org>
1325
1326 * xdisp.c (redisplay_internal): No need to redisplay terminal
1327 frames that are not on top.
1328
20ca2e94
TN
13292012-06-17 Troels Nielsen <bn.troels@gmail.com>
1330
1331 * process.c (make_process): Initialize write_queue.
1332 (write_queue_push, write_queue_pop): New functions.
1333 (send_process): Use them to maintain correct ordering of process
1334 writes (Bug#10815).
1335
9a900ca9
PE
13362012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1337
310fbfa8
PE
1338 * lisp.h (eassert): Assume C89 or later.
1339 This removes the need for CHECK.
1340 (CHECK): Remove. Its comments about always evaluating its
1341 argument were confusing, as 'eassert' typically does not evaluate
1342 its argument.
1343
27bb1ca4
PE
1344 * coding.c (produce_chars): Use ptrdiff_t, not int.
1345
9a900ca9
PE
1346 * xterm.c (x_draw_underwave): Check for integer overflow.
1347 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1348
41b7f8bc 13492012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1350
1351 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1352 referenced (Bug#11583).
1353
9b0e3eba
AA
13542012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1355
1356 Implement wave-style variant of underlining.
1357 * dispextern.h (face_underline_type): New enum.
1358 (face): Add field for underline type.
1359 * nsterm.m (ns_draw_underwave): New function.
1360 (ns_draw_text_decoration): Use it.
1361 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1362 New functions.
1363 (x_draw_glyph_string): Use them.
1364 * xfaces.c (Qline, Qwave): New Lisp objects.
1365 (check_lface_attrs, merge_face_ref)
1053a871
SM
1366 (Finternal_set_lisp_face_attribute, realize_x_face):
1367 Handle wave-style underline face attributes.
9b0e3eba
AA
1368 * xterm.c (x_draw_underwave): New function.
1369 (x_draw_glyph_string): Use it.
1370
0fb52f11
JB
13712012-06-16 Juanma Barranquero <lekktu@gmail.com>
1372
1373 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1374 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1375 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1376 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1377 ($(BLD)/w32select.$(O)): Update dependencies.
1378
e5560ff7
AS
13792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1380
1381 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1382 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1383 * character.c (_fetch_multibyte_char_p): Remove.
1384 * alloc.c: Include "character.h" before "buffer.h".
1385 * bidi.c: Likewise.
1386 * buffer.c: Likewise.
1387 * bytecode.c: Likewise.
1388 * callint.c: Likewise.
1389 * callproc.c: Likewise.
1390 * casefiddle.c: Likewise.
1391 * casetab.c: Likewise.
1392 * category.c: Likewise.
1393 * cmds.c: Likewise.
1394 * coding.c: Likewise.
1395 * composite.c: Likewise.
1396 * dired.c: Likewise.
1397 * dispnew.c: Likewise.
1398 * doc.c: Likewise.
1399 * dosfns.c: Likewise.
1400 * editfns.c: Likewise.
1401 * emacs.c: Likewise.
1402 * fileio.c: Likewise.
1403 * filelock.c: Likewise.
1404 * font.c: Likewise.
1405 * fontset.c: Likewise.
1406 * fringe.c: Likewise.
1407 * indent.c: Likewise.
1408 * insdel.c: Likewise.
1409 * intervals.c: Likewise.
1410 * keyboard.c: Likewise.
1411 * keymap.c: Likewise.
1412 * lread.c: Likewise.
1413 * macros.c: Likewise.
1414 * marker.c: Likewise.
1415 * minibuf.c: Likewise.
1416 * nsfns.m: Likewise.
1417 * nsmenu.m: Likewise.
1418 * print.c: Likewise.
1419 * process.c: Likewise.
1420 * regex.c: Likewise.
1421 * region-cache.c: Likewise.
1422 * search.c: Likewise.
1423 * syntax.c: Likewise.
1424 * term.c: Likewise.
1425 * textprop.c: Likewise.
1426 * undo.c: Likewise.
1427 * unexsol.c: Likewise.
1428 * w16select.c: Likewise.
1429 * w32fns.c: Likewise.
1430 * w32menu.c: Likewise.
1431 * window.c: Likewise.
1432 * xdisp.c: Likewise.
1433 * xfns.c: Likewise.
1434 * xmenu.c: Likewise.
1435 * xml.c: Likewise.
1436 * xselect.c: Likewise.
1437
2f07e6af
EZ
14382012-06-16 Eli Zaretskii <eliz@gnu.org>
1439
1053a871
SM
1440 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1441 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1442 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1443 row.
1444 (handle_face_prop): Use chunk-relative overlay string index when
1445 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1446 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1447 the rightmost. (Bug#11720)
2f07e6af 1448
29b83cec
AS
14492012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1450
1451 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1452 (CATEGORY_MEMBER): Enforce 1/0 value.
1453 * category.c (_temp_category_set): Remove.
1454
4c5501e9
EZ
14552012-06-16 Eli Zaretskii <eliz@gnu.org>
1456
1457 * window.c (Fdelete_other_windows_internal)
1458 (Fdelete_window_internal): Don't access frame's mouse highlight
1459 info of the initial frame. (Bug#11677)
1460
2b570124
PE
14612012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1462
e93864f9
PE
1463 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1464 Assume USE_2_TAGS_FOR_INTS.
1465 (xreload): Adjust $tagmask width to match recent lisp.h change.
1466
2b570124
PE
1467 Simplify lisp.h in minor ways that should not affect code.
1468 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1469 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1470 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1471 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1472 (INTTYPEBITS): New macro, for clarity.
1473 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1474 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1475 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1476 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1477 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1478
81755f69
JB
14792012-06-13 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1482
16192a57
GM
14832012-06-13 Glenn Morris <rgm@gnu.org>
1484
1485 * s/bsd-common.h (BSD4_3):
1486 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1487
646b5f55
AS
14882012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1491 instead of union.
1492 (XLI, XIL): Define.
1053a871
SM
1493 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1494 Use them.
1495 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1496 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1497 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1498 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1499 * frame.c (delete_frame): Remove outdated comment.
1500 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1501 USE_LISP_UNION_TYPE.
1502 (Fw32_unregister_hot_key): Likewise.
1503 (Fw32_toggle_lock_key): Likewise.
1504 * w32menu.c (add_menu_item): Likewise.
1505 (w32_menu_display_help): Use XIL instead of checking
1506 USE_LISP_UNION_TYPE.
1507 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1508 (init_heap): Likewise.
1509 * w32term.c (w32_read_socket): Update comment.
1510
1d3823c9
GM
15112012-06-13 Glenn Morris <rgm@gnu.org>
1512
c62ff706
GM
1513 * s/usg5-4-common.h, src/s/unixware.h:
1514 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1515
1d3823c9
GM
1516 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1517
bfe3e0a2
PE
15182012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1521 * alloc.c (make_number) [!defined make_number]:
1522 Remove, as lisp.h always defines this now.
1523 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1524 (roundup_size): Verify that it is a power of 2.
1525 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1526 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1527 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1528 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1529 USE_LSB_TAG now is always defined to be either 0 or 1.
1530 All uses changed.
1531 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1532 code works fine either way, and efficiency is not a concern here,
1533 as the union type is for debugging, not for production.
1534 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1535 Use an inline function on all platforms when using the union type,
1536 since this is simpler and 'static inline' can be used portably
1537 within Emacs now.
1538 (LISP_INITIALLY_ZERO): New macro.
1539 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1540 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1541
45fa9c0f
GM
15422012-06-12 Glenn Morris <rgm@gnu.org>
1543
b4492cba
GM
1544 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1545
1546 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1547
45fa9c0f
GM
1548 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1549 Move BROKEN_SIGIO to configure.
1550
1551 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1552 Move NO_TERMIO to configure.
1553
0e25d334
CY
15542012-06-12 Chong Yidong <cyd@gnu.org>
1555
1556 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1557 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1558 MagickExportImagePixels is undefined.
1559
43682bb6
PE
15602012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 * image.c (imagemagick_load_image): Remove unused label.
1563
a9be7d2b
GM
15642012-06-11 Glenn Morris <rgm@gnu.org>
1565
1566 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1567 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1568 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1569 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1570
3017f87f
SM
15712012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1572
1573 * alloc.c (make_byte_code): New function.
1574 (Fmake_byte_code): Use it. Don't purify here.
1575 * lread.c (read1): Use it as well to avoid extra allocation.
1576
1b9b4cf4
CY
15772012-06-11 Chong Yidong <cyd@gnu.org>
1578
1579 * image.c (imagemagick_load_image): Implement transparency.
1580
95988fcf
AS
15812012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1582
1583 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1584 account for preceding backslashes. (Bug#11663)
1585
cd4eb164
CY
15862012-06-09 Chong Yidong <cyd@gnu.org>
1587
1588 * term.c: Support italics in capable terminals (Bug#9652).
1589 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1590 (turn_on_face): Output using TS_enter_italic_mode if available.
1591 Don't handle unused blinking and alt-charset cases.
1592 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1593 and tty_alt_charset_p cases.
1594 (tty_capable_p, init_tty): Support italics.
1595
1596 * termchar.h (struct tty_display_info): Add field for italics.
1597 Remove unused blink field.
1598
1599 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1600 Handle slant.
1601
1602 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1603 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1604 tty_alt_charset_p. Add tty_italic_p.
1605
ff88beb8
MA
16062012-06-09 Michael Albinus <michael.albinus@gmx.de>
1607
1608 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1609 dbus_type_is_basic if available.
1610 (xd_extract_signed, xd_extract_unsigned): Rename from
1611 extract_signed and extract_unsigned, respectively. Adapt callers.
1612
44286096
CY
16132012-06-09 Chong Yidong <cyd@gnu.org>
1614
1682701f
CY
1615 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1616
44286096
CY
1617 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1618 case (Bug#9752).
1619
d86feb17
PE
16202012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * xdisp.c (vmessage): Treat frame message as multibyte.
1623 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1624 would generate the diagnostic "Making \302\247 buffer-local while
1625 let-bound!".
1626
d5c20fe8
EZ
16272012-06-08 Eli Zaretskii <eliz@gnu.org>
1628
1629 * dispnew.c (showing_window_margins_p): Undo last change, which
1630 was done due to an inadvertent commit.
1631 (adjust_frame_glyphs_for_frame_redisplay): Do call
1632 showing_window_margins_p.
1633
513749ee
SM
16342012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * eval.c (Fmake_var_non_special): New primitive.
1637 (syms_of_eval): Defsubr it.
1638 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1639
d4a8f5c1
JB
16402012-06-08 Juanma Barranquero <lekktu@gmail.com>
1641
1642 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1643 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1644
8bbbc977
EZ
16452012-06-08 Eli Zaretskii <eliz@gnu.org>
1646
1647 * alloc.c (allocate_vectorlike): Fix last change.
1648
f3372c87
DA
16492012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1650
1651 Block-based vector allocation of small vectors.
1652 * lisp.h (struct vectorlike_header): New field `nbytes',
1653 adjust comment accordingly.
1654 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1655 to denote vector blocks. Adjust users (live_vector_p,
1656 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1657 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1658 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1659 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1660 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1661 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1662 (roundup_size): New constant.
1663 (struct vector_block): New data type.
1664 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1665 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1666 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1667 (sweep_vectors): New functions.
1668 (allocate_vectorlike): Return `zero_vector' as the only vector of
1669 0 items. Allocate new vector from block if vector size is less than
1670 or equal to VBLOCK_BYTES_MAX.
1671 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1672 (init_alloc_once): Add call to init_vectors.
1673
4f18a4ed
SM
16742012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1675
1676 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1677
86f158bc
PE
16782012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * doprnt.c (doprnt): Truncate multibyte char correctly.
1681 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1682 would mishandle a string argument "Xc" if X was a multibyte
1683 character of length 2: it would truncate after X's first byte
1684 rather than including all of X.
1685
c5cfcbe0
CY
16862012-06-06 Chong Yidong <cyd@gnu.org>
1687
1688 * buffer.c (word_wrap): Doc fix.
1689
c05cf390
PE
16902012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1693
0c3461de
GM
16942012-06-03 Glenn Morris <rgm@gnu.org>
1695
1696 * xdisp.c (tool-bar-style): Doc fix.
1697
c71232db
UM
16982012-06-03 Ulrich Müller <ulm@gentoo.org>
1699
1700 * Makefile.in (PAXCTL): Define.
1701 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1702 binary via PaX flags if the paxctl utility is available.
1703 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1704 Restore PaX flags to their default. (Bug#11398)
1705
383f7350
CY
17062012-06-03 Chong Yidong <cyd@gnu.org>
1707
1708 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1709 buffer (Bug#11226).
1710
5f2c76c6
CY
17112012-06-03 Chong Yidong <cyd@gnu.org>
1712
1713 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1714 (note_mode_line_or_margin_highlight): If there is no help echo,
1715 use mode-line-default-help-echo. Handle the case where the mouse
1716 position is past the end of the mode line string.
1717
1718 * buffer.c (buffer_local_value_1): New function, split from
1719 Fbuffer_local_value; can return Qunbound.
1720 (Fbuffer_local_value): Use it.
1721 (Vmode_line_format): Docstring tweaks.
1722
773d47f6
PE
17232012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * sysdep.c (system_process_attributes): Improve comment.
1726
f2d6a3df
SM
17272012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * keyboard.c: Export real-this-command to Elisp.
1730 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1731 and DEFVAR it. Update all users.
1732
63810350
PE
17332012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1734
7bd5c1f4
PE
1735 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1736
63810350
PE
1737 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1738 Convert pctcpu and pctmem to Lisp float properly.
1739 Let the compiler fold better, as 100.0/0x8000 is exact.
1740
a2821611
AS
17412012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1742
1743 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1744 cons_block.
1745
5fceba1d
PE
17462012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1749
c98ff5dd
DA
17502012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 For a 'struct window', replace some Lisp_Object fields to
1753 bitfields where appropriate, remove unused fields.
1754 * window.h (struct window): Remove unused 'last_mark_x' and
1755 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1756 change it's type from Lisp_Object to bitfield.
1757 Change type of 'force_start', 'optional_new_start',
1758 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1759 fields from Lisp_Object to bitfield. Adjust users accordingly.
1760
ca34e0be
PE
17612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Pacify gcc -Wdouble-precision when using Xaw.
1764 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1765 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1766 Use 'float' consistently, rather than 'float' in most places
1767 and 'double' in a couple of places.
1768
efc00ab1 17692012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1770
1771 * xdisp.c (handle_stop): Detect whether we have overlay strings
1772 loaded by testing it->current.overlay_string_index to be
1773 non-negative, instead of checking whether n_overlay_strings is
1774 positive. (Bug#11587)
1775
efc00ab1 17762012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1777
1778 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1779
1780 * doc.c (Fsubstitute_command_keys): Doc fix.
1781
efc00ab1 17822012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1783
1784 * search.c (search_buffer): Remove calls to
1785 r_alloc_inhibit_buffer_relocation, as it is now called by
1786 maybe_unify_char, which was the cause of relocation of buffer text
1787 in bug#11519.
1788
efc00ab1 17892012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1790
1791 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1792 for the duration of call to load_charset, to avoid problems with
1793 callers of maybe_unify_char that access buffer text through C
1794 pointers.
1795
1796 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1797 decrement the inhibition flag, instead of just setting or
1798 resetting it.
1799
ba93a187
PE
18002012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 Remove obsolete '#define static' cruft.
1803 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1804 This #undef was "temporary" in 2000; it is no longer needed
1805 now that '#define static' has gone away.
1806 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1807 (gray_bitmap_bits): Remove; no longer needed.
1808 All uses replaced with definiens.
1809 * xterm.c: Include "bitmaps/gray.xbm".
1810
9e4bf381
PE
18112012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 Clean up __executable_start, monstartup when --enable-profiling.
1814 The following changes affect the code only when profiling.
1815 * dispnew.c (__executable_start): Rename from safe_bcopy.
1816 Define only on platforms that need it.
1817 * emacs.c: Include <sys/gmon.h> when profiling.
1818 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1819 (__executable_start): Remove decl, since lisp.h does it now.
1820 (safe_bcopy): Remove decl; no longer has that name.
1821 (main): Coalesce #if into single bit of code, for simplicity.
1822 Cast pointers to uintptr_t, since standard libraries want integers
1823 and not pointers.
1824 * lisp.h (__executable_start): New decl.
1825
32d72c2f
GM
18262012-05-31 Glenn Morris <rgm@gnu.org>
1827
1828 * image.c (Fimagemagick_types): Doc fix.
1829
baac5bc7
JM
18302012-05-30 Jim Meyering <meyering@redhat.com>
1831
1832 * callproc.c (Fcall_process_region): Include directory component
1833 in mkstemp error message (Bug#11586).
1834
72cb32cf
PE
18352012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * alloc.c, lisp.h (make_pure_vector): Now static.
1838
61b108cc
SM
18392012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1840
1841 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1842 Move to byte-run.el.
1843 (Fautoload): Do the hash-doc more carefully.
1844 * data.c (Fdefalias): Purify definition, except for keymaps.
1845 (Qdefun): Move from eval.c.
1846 * lisp.h (Qdefun): Remove.
1847 * lread.c (read1): Tiny simplification.
1848
471fe23d
TN
18492012-05-29 Troels Nielsen <bn.troels@gmail.com>
1850
934f3f58 1851 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1852 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1853 Bug#9642, but explicitly check that the buffer the overlay would
1854 be moved to is live and rearrange lines to make sure that errors
1855 will not put the overlay in an inconsistent state.
1856 (Fdelete_overlay): Cosmetics.
1857
85d0efd1
EZ
18582012-05-28 Eli Zaretskii <eliz@gnu.org>
1859
1860 * w32term.c (my_bring_window_to_top): New function.
1861 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1862 could be different from the original one.
1863 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1864 (Bug#11513)
1865
1866 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1867 by calling BringWindowToTop.
1868
1869 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1870 (WM_EMACS_END): Increase by one.
1871
da92a98c
PE
18722012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1875 This avoids undefined behavior that might cause the eassert
1876 to not catch an out-of-range value.
1877
74d1f848
JB
18782012-05-28 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1881 Update dependencies.
1882
9e1a06fc
EZ
18832012-05-27 Eli Zaretskii <eliz@gnu.org>
1884
1885 * bidi.c (bidi_mirror_char): Fix last change.
1886
f3dd7312
AS
18872012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1890 when referring to sectname field in printf format.
1891
81899c91
PE
18922012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1893
57b81a9f
PE
1894 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1895 Only r_alloc_inhibit_buffer_relocation needed to be added;
1896 the others were already declared.
1897
81899c91
PE
1898 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1899 before checking whether it's out of range. Put the check inside
1900 eassert. See
1901 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1902
33017faf 19032012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1904
1905 * callproc.c (Fcall_process): Restore a line that was accidentally
1906 commented out in the 2011-02-13 change (bug#11547).
1907
33017faf 19082012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1909
1910 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1911 defined on ralloc.c.
1912
1913 * buffer.c [REL_ALLOC]: Remove prototypes of
1914 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1915 they are now on lisp.h.
1916
1917 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1918
1919 * search.c (search_buffer): Use it to inhibit relocation of buffer
1920 text while re_search_2 is doing its job, because re_search_2 is
1921 passed C pointers to buffer text. (Bug#11519)
1922
23415acf
EZ
1923 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1924 Update value to 24.
1925
44e27368
EZ
1926 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1927 state after an additional call to move_it_in_display_line_to, keep
1928 the values of it->max_ascent and it->max_descent found for the
1929 entire line.
1930 (pos_visible_p): Revert the comparison against bottom_y to what it
1931 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1932 (Bug#11464)
1933
c1892f11
PE
19342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Fix coding-related core dumps with gcc -ftrapv.
1937 The code was computing A - B, where A and B are pointers, and B is
1938 random garbage. This can lead to core dumps on platforms that
1939 have special pointer registers, and it also leads to core dumps on
1940 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1941 A - B only when B is initialized properly.
1942 * coding.c (coding_set_source, coding_set_destination): Return void.
1943 (coding_change_source, coding_change_destinations): New functions,
1944 with the old behaviors of coding_set_source and coding_set_destination.
1945 All callers that need an offset changed to use these new functions.
1946
eb7afdad
GM
19472012-05-26 Glenn Morris <rgm@gnu.org>
1948
1949 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1950
f12fdf02
EZ
19512012-05-26 Eli Zaretskii <eliz@gnu.org>
1952
53a63be6 1953 Extend mouse support on W32 text-mode console.
61b108cc
SM
1954 * xdisp.c (draw_row_with_mouse_face):
1955 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1956
eb3f6f01 1957 * w32console.c: Include window.h.
61b108cc
SM
1958 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1959 New functions.
eb3f6f01
EZ
1960 (initialize_w32_display): Initialize mouse-highlight data.
1961
53a63be6
EZ
1962 * w32inevt.c: Include termchar.h and window.h.
1963 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1964 moves, call note_mouse_highlight. If help_echo changed, call
1965 gen_help_event to produce help-echo message in the echo area.
1966 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1967 highlight info.
1968
4cfd81f6
PE
19692012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 * lread.c (read1): Simplify slightly to avoid an overflow warning
1972 with GCC 4.7.0 on x86-64.
1973
4446092a
EZ
19742012-05-26 Eli Zaretskii <eliz@gnu.org>
1975
1976 * bidi.c (bidi_mirror_char): Revert last change: an int is
1977 definitely wide enough here.
1978
42b2a986 19792012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1980
42b2a986 1981 Fix integer width and related bugs (Bug#9874).
eb106a49 1982 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1983 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1984 (string_bytes, check_sblock, allocate_string_data):
1985 (compact_small_strings, Fmake_bool_vector, make_string)
1986 (make_unibyte_string, make_multibyte_string)
1987 (make_string_from_bytes, make_specified_string)
1988 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1989 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1990 (mark_vectorlike):
1991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1992 (allocate_pseudovector):
1993 Use int, not EMACS_INT, where int is wide enough.
1994 (inhibit_garbage_collection, Fgarbage_collect):
1995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1996 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1997 int might not be wide enough.
1998 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1999 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2000 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2001 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2002 (bidi_level_of_next_char, bidi_move_to_visually_next):
2003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2004 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2005 (Fkill_buffer, Fset_buffer_major_mode)
2006 (advance_to_char_boundary, Fbuffer_swap_text)
2007 (Fset_buffer_multibyte, overlays_at, overlays_in)
2008 (overlay_touches_p, struct sortvec, record_overlay_string)
2009 (overlay_strings, recenter_overlay_lists)
2010 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2011 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2012 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2013 (Foverlay_recenter, last_overlay_modification_hooks_used)
2014 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2016 (validate_region): Omit unnecessary test for b <= e,
2017 since that's guaranteed by the previous test.
d311d28c
PE
2018 (adjust_overlays_for_delete): Avoid pos + length overflow.
2019 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2020 (report_overlay_modification):
2021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2022 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2023 Omit pointer cast, which isn't needed anyway, and doesn't work
2024 after the EMACS_INT -> ptrdiff_t change.
02481186 2025 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2026 * buffer.h: Adjust decls to match defn changes elsewhere.
2027 (struct buffer_text, struct buffer):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2030 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2031 not int, to avoid needless 32-bit limit on 64-bit hosts.
2032 (exec_byte_code): Use tighter memory-full test, one that checks
2033 for alloca overflow. Don't compute the address of the object just
2034 before an array, as that's not portable. Use EMACS_INT, not
2035 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2036 * callint.c (Fcall_interactively):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 * callproc.c (call_process_kill, Fcall_process):
2039 Don't assume pid_t fits into an Emacs fixnum.
2040 (call_process_cleanup, Fcall_process, child_setup):
2041 Don't assume pid_t fits into int.
2042 (call_process_cleanup, Fcall_process, delete_temp_file)
2043 (Fcall_process_region):
2044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2045 (Fcall_process): Simplify handling of volatile integers.
2046 Use int, not EMACS_INT, where int will do.
2047 * casefiddle.c (casify_object, casify_region, operate_on_word)
2048 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (casify_object): Avoid integer overflow when overallocating buffer.
2051 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2052 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2053 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2054 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2055 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2056 integers are now checked earlier. All uses replaced with XINT.
2057 (ccl_driver):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2060 (ccl_driver, Fregister_code_conversion_map):
2061 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2062 (resolve_symbol_ccl_program): Check that vector header is in range.
2063 Always copy the vector, so that we can check its contents reliably
2064 now rather than having to recheck each instruction as it's being
2065 executed. Check that vector words fit in 'int'.
2066 (ccl_get_compiled_code, Fregister_ccl_program)
2067 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2068 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2069 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2070 contents are in range.
2071 (Fccl_execute_on_string): Check that status is in range.
2072 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2073 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2074 Accept and return EMACS_INT, not int, because callers can pass values
2075 out of 'int' range.
2076 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2077 (multibyte_chars_in_text, parse_str_as_multibyte)
2078 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2079 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2080 (string_escape_byte8, Fget_byte):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2082 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2083 avoid mishandling large integers.
2084 * character.h: Adjust decls to match defn changes elsewhere.
2085 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2086 (Ffind_charset_region):
2087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2088 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2089 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2090 Don't assume fixnum fits in int.
d311d28c
PE
2091 (load_charset_map_from_vector, Fmap_charset_chars):
2092 Remove now-unnecessary CHECK_NATNUMs.
2093 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2094 Don't rely on undefined behavior with signed left shift overflow.
2095 Don't assume unsigned int fits into fixnum, or that fixnum fits
2096 into unsigned int. Don't require max_code to be a valid fixnum;
2097 that's not true for gb10830 4-byte on a 32-bit host. Allow
2098 invalid_code to be a cons, for the same reason. Require code_offset
2099 to be a character. Avoid int overflow if max_char is close
2100 to INT_MAX.
2101 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2102 this is intended anyway and avoids some undefined behavior.
2103 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2104 INDEX_TO_CODE_POINT, as that's what it expects.
2105 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2106 * charset.h (DECODE_CHAR): Return int, not unsigned;
2107 this is what was intended anyway, and it avoids undefined behavior.
2108 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2109 integer-overflow issues.
2110 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2111 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2112 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2113 * chartab.c (Fmake_char_table, Fset_char_table_range)
2114 (uniprop_get_decoder, uniprop_get_encoder):
2115 Don't assume fixnum fits in int.
2116 * cmds.c (move_point): New function, that does the gist of
2117 Fforward_char and Fbackward_char, but does so while checking
2118 for integer overflow more accurately.
c96e5d6a 2119 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2120 (Fforward_line, Fend_of_line, internal_self_insert)
2121 (internal_self_insert):
2122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2123 Fix a FIXME, by checking for integer overflow when calculating
2124 target_clm and actual_clm.
2125 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2126 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2127 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2128 (coding_alloc_by_making_gap, alloc_destination)
2129 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2130 (encode_coding_utf_16, detect_coding_emacs_mule)
2131 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2132 (detect_coding_iso_2022, decode_coding_iso_2022)
2133 (encode_invocation_designation, encode_designation_at_bol)
2134 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2135 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2136 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2137 (encode_coding_ccl, encode_coding_raw_text)
2138 (detect_coding_charset, decode_coding_charset)
2139 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2140 (produce_composition, produce_charset, produce_annotation)
2141 (decode_coding, handle_composition_annotation)
2142 (handle_charset_annotation, consume_chars, decode_coding_gap)
2143 (decode_coding_object, encode_coding_object, detect_coding_system)
2144 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2145 (code_convert_region, code_convert_string)
8f50130c
PE
2146 (Fdefine_coding_system_internal)
2147 (coding_set_source, coding_set_destination):
d311d28c
PE
2148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2149 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2150 (Fdefine_coding_system_internal):
2151 Don't assume fixnums fit in int.
2152 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2153 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2154 (Funencodable_char_position, Fcheck_coding_systems_region)
2155 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2157 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2158 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2159 Don't access memory outside of the args array.
d311d28c 2160 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2161 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2162 result of ENCODE_CHAR.
d311d28c
PE
2163 * coding.h: Adjust decls to match defn changes elsewhere.
2164 (struct coding_system):
2165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2166 * composite.c (get_composition_id, find_composition)
2167 (run_composition_function, update_compositions)
2168 (compose_text, composition_gstring_put_cache)
2169 (composition_gstring_p, composition_gstring_width)
2170 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2171 (composition_compute_stop_pos, composition_reseat_it)
2172 (composition_update_it, struct position_record)
2173 (find_automatic_composition, composition_adjust_point)
2174 (Fcomposition_get_gstring, Ffind_composition_internal):
2175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2176 (update_compositions):
2177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2178 * composite.h: Adjust decls to match defn changes elsewhere.
2179 (struct composition):
2180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2181 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2182 Do not attempt to compute the address of the object just before a
2183 buffer; this is not portable.
2184 (Faref, Faset):
2185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2186 (Faset): Use int, not EMACS_INT, where int is wide enough.
2187 (Fstring_to_number): Don't assume fixnums fit in int.
2188 (Frem): Don't assume arg is nonnegative.
2189 * dbusbind.c (xd_append_arg): Check for integers out of range.
2190 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2191 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2192 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2193 (xd_get_connection_references): Return ptrdiff_t, not int.
2194 All uses changed.
2195 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2196 (xd_read_message_1):
2197 Use int, not unsigned, where the dbus API uses int.
2198 (Fdbus_message_internal): Don't overflow mtype.
2199 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2200 * dired.c (directory_files_internal, file_name_completion, scmp)
2201 (file_name_completion_stat):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 (file_name_completion): Don't overflow matchcount.
2204 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2205 * dispextern.h: Adjust decls to match defn changes elsewhere.
2206 (struct text_pos, struct glyph, struct bidi_saved_info)
2207 (struct bidi_string_data, struct bidi_it, struct composition_it)
2208 (struct it):
2209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 (struct display_pos, struct composition_it, struct it):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 * dispnew.c (increment_matrix_positions)
2213 (increment_row_positions, mode_line_string)
2214 (marginal_area_string):
2215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2216 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2218 (duration_to_sec_usec): New function, to check for overflow better.
2219 (Fsleep_for, sit_for): Use it.
2220 * doc.c (get_doc_string, store_function_docstring):
2221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2222 (get_doc_string, Fsnarf_documentation):
2223 Use int, not EMACS_INT, where int is wide enough.
2224 (get_doc_string):
2225 Use SAFE_ALLOCA, not alloca.
2226 Check for overflow when converting EMACS_INT to off_t.
2227 * doprnt.c (doprnt):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2230 Don't assume uid_t fits into fixnum.
2231 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2232 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2233 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2234 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2235 (general_insert_function)
2236 (Finsert_char, make_buffer_string, make_buffer_string_both)
2237 (update_buffer_properties, Fbuffer_substring)
2238 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2239 (Fsubst_char_in_region, check_translation)
2240 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2241 (transpose_markers, Ftranspose_regions):
2242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2243 (clip_to_bounds): Move to lisp.h as an inline function).
2244 (Fconstrain_to_field): Don't assume integers are nonnegative.
2245 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2246 (Fsubst_char_in_region, Fsave_restriction):
2247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2248 (Femacs_pid): Don't assume pid_t fits into fixnum.
2249 (lo_time): Use int, not EMACS_INT, when int suffices.
2250 (lisp_time_argument): Check for usec out of range.
2251 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2252 (Fuser_login_name, Fuser_full_name): Signal an error
2253 if a uid argument is out of range, rather than relying on
2254 undefined behavior.
c8d5c857
PE
2255 (Fformat_time_string): Remove now-unnecessary check.
2256 lisp_time_argument checks for out-of-range usec now.
243e0530 2257 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2258 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2259 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2260 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2261 (init_cmdargs, Fdump_emacs):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2264 the bottom (typically) 32 bits of the fixnum.
2265 * eval.c (specpdl_size, call_debugger):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (when_entered_debugger, Fbacktrace_debug):
2268 Don't assume fixnum can fit in int.
2269 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2270 the object just before a buffer; this is not portable.
2271 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2272 (grow_specpdl, unbind_to):
2273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2274 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2275 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2276 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2277 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2278 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2281 (a_write, e_write):
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 (Fcopy_file, non_regular_nbytes, read_non_regular)
2284 (Finsert_file_contents):
2285 Use int, not EMACS_INT, where int is wide enough.
2286 (READ_BUF_SIZE): Verify that it fits in int.
2287 (Finsert_file_contents): Check that counts are in proper range,
2288 rather than assuming fixnums fit into ptrdiff_t etc.
2289 Don't assume fixnums fit into int.
125b3835 2290 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2291 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2292 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2293 (string_char_to_byte, string_byte_to_char)
2294 (string_make_multibyte, string_to_multibyte)
2295 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2296 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2297 (substring_both, Fdelete, internal_equal, Ffillarray)
2298 (Fclear_string, mapcar1)
2299 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2300 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2301 (larger_vector, make_hash_table, maybe_resize_hash_table)
2302 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2303 (Fmaphash, secure_hash):
2304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2305 (concat): Check for string index and length overflow.
2306 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2307 (Frequire):
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 (larger_vector): New API (vec, incr_min, size_max) replaces old
2310 one (vec, new_size, init). This catches size overflow.
2311 INIT was removed because it was always Qnil.
2312 All callers changed.
2313 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2314 the upper bound on a hash table index size.
2315 (make_hash_table, maybe_resize_hash_table): Use it.
2316 (secure_hash): Computer start_byte and end_byte only after
2317 they're known to be in ptrdiff_t range.
2318 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2319 (Ffont_get_glyphs, Ffont_at):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2322 (Flist_fonts, Fopen_font):
2323 Don't assume fixnum can fit in int.
2324 (check_gstring): Don't assume index can fit in int.
2325 (font_match_p): Check that fixnum is a character, not a nonnegative
2326 fixnum, since the later code needs to stuff it into an int.
2327 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2328 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2329 conversion overflow issues.
2330 (Fopen_font): Check for integer out of range.
2331 (Ffont_get_glyphs): Don't assume index can fit in int.
2332 * font.h: Adjust decls to match defn changes elsewhere.
2333 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2334 integer overflow.
2335 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2336 printmax_t, where ptrdiff_t is wide enough.
2337 (Finternal_char_font):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2339 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2340 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2341 (Fset_frame_position, x_set_frame_parameters)
2342 (x_set_line_spacing, x_set_border_width)
2343 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2344 Check that fixnums are in proper range for system types.
2345 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2347 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2348 Use SAFE_ALLOCA_LISP, not alloca.
2349 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2350 intptr_t is wide enough.
2351 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2352 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2353 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2354 Check for fixnum out of range.
2355 * ftfont.c (ftfont_list): Don't assume index fits in int.
2356 Check that fixnums are in proper range for system types.
2357 (ftfont_shape_by_flt):
2358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2359 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2361 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2362 Check that fixnums are in proper range for system types.
2363 * gnutls.h: Adjust decls to match defn changes elsewhere.
2364 * gtkutil.c (xg_dialog_run):
2365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2366 (update_frame_tool_bar):
2367 Check that fixnums are in proper range for system types.
2368 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2369 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2370 * indent.c (last_known_column, last_known_column_point):
2371 (current_column_bol_cache):
2372 (skip_invisible, current_column, check_display_width):
2373 (check_display_width, scan_for_column, current_column_1)
2374 (Findent_to, Fcurrent_indentation, position_indentation)
2375 (indented_beyond_p, Fmove_to_column, compute_motion):
2376 (Fcompute_motion, Fvertical_motion):
2377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2378 (last_known_column_modified): Use EMACS_INT, not int.
2379 (check_display_width):
2380 (Fcompute_motion):
2381 Check that fixnums and floats are in proper range for system types.
2382 (compute_motion): Don't assume index or fixnum fits in int.
2383 (compute_motion, Fcompute_motion):
2384 Use int, not EMACS_INT, when it is wide enough.
2385 (vmotion): Omit local var start_hpos that is always 0; that way
2386 we don't need to worry about overflow in expressions involving it.
2387 * indent.h: Adjust decls to match defn changes elsewhere.
2388 (struct position):
2389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2390 Use int, not EMACS_INT, where int is wide enough.
2391 Remove unused members ovstring_chars_done and tab_offset;
2392 all uses removed.
2393 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2394 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2395 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2396 (make_gap, copy_text, insert, insert_and_inherit)
2397 (insert_before_markers, insert_before_markers_and_inherit)
2398 (insert_1, count_combining_before, count_combining_after)
2399 (insert_1_both, insert_from_string)
2400 (insert_from_string_before_markers, insert_from_string_1)
2401 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2402 (adjust_after_replace, adjust_after_insert, replace_range)
2403 (replace_range_2, del_range, del_range_1, del_range_byte)
2404 (del_range_both, del_range_2, modify_region)
2405 (prepare_to_modify_buffer, signal_before_change)
2406 (signal_after_change, Fcombine_after_change_execute):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2409 (balance_an_interval, split_interval_right, split_interval_left)
2410 (find_interval, next_interval, update_interval)
2411 (adjust_intervals_for_insertion, delete_node, delete_interval)
2412 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2413 (static_offset_intervals, offset_intervals)
2414 (merge_interval_right, merge_interval_left, make_new_interval)
2415 (graft_intervals_into_buffer, temp_set_point_both)
2416 (temp_set_point, set_point, adjust_for_invis_intang)
2417 (set_point_both, move_if_not_intangible, get_property_and_range)
2418 (get_local_map, copy_intervals, copy_intervals_to_string)
2419 (compare_string_intervals, set_intervals_multibyte_1):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 * intervals.h: Adjust decls to match defn changes elsewhere.
2422 (struct interval):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 * keyboard.c (this_command_key_count, this_single_command_key_start)
2425 (before_command_key_count, before_command_echo_length, echo_now)
2426 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2427 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2428 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2429 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 (last_non_minibuf_size, last_point_position, echo_truncate)
2432 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2433 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2434 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2435 (stuff_buffered_input):
2436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2437 (last_auto_save, command_loop_1, read_char):
2438 Use EMACS_INT, not int, to avoid integer overflow.
2439 (record_char): Avoid overflow in total_keys computation.
2440 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2441 * keyboard.h: Adjust decls to match defn changes elsewhere.
2442 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2443 (Fkey_description, Fdescribe_vector, Flookup_key):
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 (click_position): New function, to check that positions are in range.
2446 (Fcurrent_active_maps):
2447 (describe_command):
2448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2449 (Faccessible_keymaps, Fkey_description):
2450 (preferred_sequence_p):
2451 Don't assume fixnum can fit into int.
2452 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2453 Check for integer overflow in size calculations.
2454 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2455 avoid mishandling large integers.
2456 * lisp.h: Adjust decls to match defn changes elsewhere.
2457 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2458 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2459 (struct Lisp_Marker):
2460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2461 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2462 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2463 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2464 All callers changed.
2465 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2466 Assume the arg has valid form, since it always does.
2467 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2468 unsigned integer system type.
2469 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2470 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2472 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2473 (duration_to_sec_usec): New decl.
2474 * lread.c (read_from_string_index, read_from_string_index_byte)
2475 (read_from_string_limit, readchar, unreadchar, openp)
2476 (read_internal_start, read1, oblookup):
2477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2478 (Fload, readevalloop, Feval_buffer, Feval_region):
2479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2480 (openp): Check for out-of-range argument to 'access'.
2481 (read1): Use int, not EMACS_INT, where int is wide enough.
2482 Don't assume fixnum fits into int.
6efdadfd 2483 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2484 (read_filtered_event): Use duration_to_sec_usec
2485 to do proper overflow checking on durations.
d311d28c
PE
2486 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2487 in size calculation.
2488 (Fexecute_kbd_macro):
2489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2490 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2491 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2492 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2493 (set_marker_both, set_marker_restricted_both, marker_position)
2494 (marker_byte_position, Fbuffer_has_markers_at):
2495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2496 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2497 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2498 It now merely ensures that the menu is large enough, without
2499 necessarily growing it, as this avoids some integer overflow issues.
2500 All callers changed.
2501 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2503 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2504 Use SAFE_ALLOCA_LISP, not alloca.
2505 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2506 to EMACS_INT. Check that fixnums are in proper range for system types.
2507 * minibuf.c (minibuf_prompt_width, string_to_object)
2508 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2509 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (get_minibuffer, read_minibuf_unwind):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2514 this simplifies overflow checking. All callers changed.
2515 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2516 (Ftest_completion):
2517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2518 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2519 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2520 Check that fixnums are in proper range for system types.
2521 (Fx_create_frame, Fx_show_tip):
2522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2523 * nsfont.m (ns_findfonts, nsfont_list_family):
2524 Don't assume fixnum fits in long.
2525 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2527 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2528 wide enough.
17fdb222 2529 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2532 (PRINTDECLARE, PRINTPREPARE):
2533 (strout, print_string):
2534 (print, print_preprocess, print_check_string_charset_prop)
2535 (print_object):
2536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2537 (PRINTDECLARE):
2538 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2540 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2541 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2542 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2543 (print_error_message): Use SAFE_ALLOCA, not alloca.
2544 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2545 (print_depth, new_backquote_output, print_number_index):
2546 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2547 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2548 (Fset_process_window_size, Fformat_network_address)
2549 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2550 (sigchld_handler):
d311d28c 2551 Check that fixnums are in proper range for system types.
d44287d4 2552 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2553 Check for process-ids out of pid_t range rather than relying on
2554 undefined behavior.
e4d81efc 2555 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2556 (Fformat_network_address, read_process_output, send_process)
2557 (Fprocess_send_region, status_notify):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2559 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2560 (wait_reading_process_output, read_process_output, exec_sentinel):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2563 (Faccept_process_output): Use duration_to_sec_usec to do proper
2564 overflow checking on durations.
dde14581
PE
2565 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2566 Don't assume pid_t fits in int.
02481186
PE
2567 * process.h (struct Lisp_Process): Members tick and update_tick
2568 are now of type EMACS_INT, not int.
b62b53e8
PE
2569 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2570 configured --with-wide-int.
d311d28c
PE
2571 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2572 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2573 * search.c (looking_at_1, string_match_1):
2574 (fast_string_match, fast_c_string_match_ignore_case)
2575 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2576 (scan_newline, find_before_next_newline, search_command)
2577 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2578 (set_search_regs, wordify):
2579 (Freplace_match):
2580 (Fmatch_data):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (string_match_1, search_buffer, set_search_regs):
2583 (Fmatch_data):
2584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2585 (wordify): Check for overflow in size calculation.
2586 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2587 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2588 Check that fixnums are in proper range for system types.
2589 * sound.c (struct sound_device)
2590 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2592 (Fplay_sound_internal):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2594 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2595 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2596 (Fparse_partial_sexp):
2597 Don't assume fixnums can fit in int.
2598 (struct lisp_parse_state, find_start_pos, find_start_value)
2599 (find_start_value_byte, find_start_begv)
2600 (update_syntax_table, char_quoted, dec_bytepos)
2601 (find_defun_start, prev_char_comend_first, back_comment):
2602 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2603 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2605 (Finternal_describe_syntax_value): Check that match_lisp is a
2606 character, not an integer, since the code stuffs it into int.
2607 (scan_words, scan_sexps_forward):
2608 Check that fixnums are in proper range for system types.
2609 (Fforward_word):
2610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2611 (scan_sexps_forward):
2612 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2613 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2614 * syntax.h: Adjust decls to match defn changes elsewhere.
2615 (struct gl_state_s):
2616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2617 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2618 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2619 * sysdep.c (wait_for_termination_1, wait_for_termination)
2620 (interruptible_wait_for_termination, mkdir):
2621 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2622 (emacs_read, emacs_write):
2623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2624 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2625 and double all fit in int.
d311d28c
PE
2626 * term.c (set_tty_color_mode):
2627 Check that fixnums are in proper range for system types.
2628 * termhooks.h (struct input_event):
2629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2630 * textprop.c (validate_interval_range, interval_of)
2631 (Fadd_text_properties, set_text_properties_1)
2632 (Fremove_text_properties, Fremove_list_of_text_properties)
2633 (Ftext_property_any, Ftext_property_not_all)
2634 (copy_text_properties, text_property_list, extend_property_ranges)
2635 (verify_interval_modification):
2636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2637 (Fnext_single_char_property_change)
2638 (Fprevious_single_char_property_change):
2639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2640 (copy_text_properties):
2641 Check for integer overflow in index calculation.
d311d28c
PE
2642 * undo.c (last_boundary_position, record_point, record_insert)
2643 (record_delete, record_marker_adjustment, record_change)
2644 (record_property_change):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2648 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2649 (Fx_hide_tip, Fx_file_dialog):
2650 * w32menu.c (set_frame_menubar):
2651 Use ptrdiff_t, not int, for consistency with rest of code.
2652 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2653 (select_window, Fdelete_other_windows_internal)
2654 (window_scroll_pixel_based, window_scroll_line_based)
2655 (Frecenter, Fset_window_configuration):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 (Fset_window_hscroll, run_window_configuration_change_hook)
2658 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2659 (Fscroll_other_window, Frecenter):
d311d28c
PE
2660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2661 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2662 Don't assume fixnum fits in int.
2663 (Fset_window_scroll_bars):
2664 Check that fixnums are in proper range for system types.
2665 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2666 (string_pos, c_string_pos, number_of_chars, init_iterator)
2667 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2668 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2669 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2670 (face_before_or_after_it_pos, handle_invisible_prop)
2671 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2672 (display_prop_intangible_p, string_buffer_position_lim)
2673 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2674 (get_overlay_strings_1, get_overlay_strings)
2675 (iterate_out_of_display_property, forward_to_next_line_start)
2676 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2677 (get_next_display_element, set_iterator_to_next)
2678 (get_visually_first_element, compute_stop_pos_backwards)
2679 (handle_stop_backwards, next_element_from_buffer)
2680 (move_it_in_display_line_to, move_it_in_display_line)
2681 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2682 (add_to_log, message_dolog, message_log_check_duplicate)
2683 (message2, message2_nolog, message3, message3_nolog
2684 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2685 (current_message_1, truncate_echo_area, truncate_message_1)
2686 (set_message, set_message_1, store_mode_line_noprop)
2687 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2688 (text_outside_line_unchanged_p, check_point_in_composition)
2689 (reconsider_clip_changes)
2690 (redisplay_internal, set_cursor_from_row, try_scrolling)
2691 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2692 (redisplay_window, find_last_unchanged_at_beg_row)
2693 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2694 (trailing_whitespace_p, find_row_edges, display_line)
2695 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2696 (display_mode_element, store_mode_line_string)
2697 (pint2str, pint2hrstr, decode_mode_spec)
2698 (display_count_lines, display_string, draw_glyphs)
2699 (x_produce_glyphs, x_insert_glyphs)
2700 (rows_from_pos_range, mouse_face_from_buffer_pos)
2701 (fast_find_string_pos, mouse_face_from_string_pos)
2702 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2704 (safe_call, init_from_display_pos, handle_fontified_prop)
2705 (handle_single_display_spec, load_overlay_strings)
2706 (with_echo_area_buffer, setup_echo_area_for_printing)
2707 (display_echo_area, echo_area_display)
2708 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2709 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2710 (redisplay_window, dump_glyph_row, display_mode_line)
2711 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2712 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2714 (handle_single_display_spec, build_desired_tool_bar_string)
2715 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2716 (get_specified_cursor_type):
2717 Check that fixnums are in proper range for system types.
2718 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2719 (Flookup_image_map):
2720 Don't assume fixnums fit in int.
2721 (compare_overlay_entries):
2722 Avoid mishandling comparisons due to subtraction overflow.
2723 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2724 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2725 (handle_tool_bar_click):
2726 Use int, not unsigned, since we prefer signed and the signedness
2727 doesn't matter here.
2728 (get_next_display_element, next_element_from_display_vector):
2729 Use int, not EMACS_INT, when int is wide enough.
2730 (start_hourglass): Use duration_to_sec_usec to do proper
2731 overflow checking on durations.
2732 * xfaces.c (Fbitmap_spec_p):
2733 Check that fixnums are in proper range for system types.
2734 (compare_fonts_by_sort_order):
2735 Avoid mishandling comparisons due to subtraction overflow.
2736 (Fx_family_fonts, realize_basic_faces):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (Fx_family_fonts):
2739 Don't assume fixnum fits in int.
2740 Use SAFE_ALLOCA_LISP, not alloca.
2741 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2742 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2743 (face_at_buffer_position, face_for_overlay_string)
2744 (face_at_string_position):
2745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2746 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2747 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2748 (Fx_show_tip):
2749 Check that fixnums are in proper range for system types.
2750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2751 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2753 (Fx_change_window_property): Don't assume fixnums fit in int.
2754 * xfont.c (xfont_chars_supported):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2757 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 * xml.c (parse_region):
2760 * xrdb.c (magic_file_p):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2763 (x_get_local_selection, x_reply_selection_request)
2764 (x_handle_selection_request, wait_for_property_change):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2767 short is wide enough.
2768 (x_send_client_event): Don't assume fixnum fits in int.
2769 * xterm.c (x_x_to_emacs_modifiers):
2770 Don't assume EMACS_INT overflows nicely into int.
2771 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2772 may come from Lisp.
2773 (handle_one_xevent): NATNUMP can eval its arg twice.
2774 (x_connection_closed):
2775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2776 * xterm.h: Adjust decls to match defn changes elsewhere.
2777 (struct scroll_bar): Use struct vectorlike_header
2778 rather than rolling our own approximation.
2779 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2780
c6574eb5
GM
27812012-05-25 Glenn Morris <rgm@gnu.org>
2782
2783 * lisp.mk (lisp): Update for more files being compiled now.
2784
e8d32c7e
SM
27852012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2786
48def666
SM
2787 * lread.c: Remove `read_pure' which makes no difference.
2788 (read_pure): Remove var.
2789 (unreadpure): Remove function.
2790 (readevalloop): Don't call read_list with -1 flag.
2791 (read1, read_vector): Don't test read_pure any more.
2792 (read_list): Simplify.
2793
e8d32c7e
SM
2794 * fileio.c, character.h: Minor style tweaks.
2795
4b2addb7
DA
27962012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2797
2798 * window.h (clip_changed): Remove useless declaration.
2799
584461b2
JB
28002012-05-22 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2803 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2804
34374650
PE
28052012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 Remove src/m/*.
2808 This directory predates autoconf and is no longer needed nowadays.
2809 Move its few remaining bits of functionality to where they're needed.
2810 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2811 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2812 * m/template.h: Remove.
2813 * Makefile.in (M_FILE): Remove. All uses removed.
2814 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2815 * lisp.h (USE_LSB_TAG):
2816 * mem-limits.h (EXCEEDS_LISP_PTR):
2817 Use VAL_MAX, not VALBITS, in #if.
2818 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2819 (EMACS_UINT): Define unconditionally now.
2820 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2821 (BITS_PER_EMACS_INT): New constants, replacing
2822 what used to be in config.h, but not useful in #if.
2823 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2824 define them any more.
2825 (VAL_MAX): New macro.
2826 (VALMASK): Use it.
2827 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2828 BITS_PER_EMACS_INT, in #if.
2829 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2830 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2831 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2832 * s/ms-w32.h (DATA_START):
2833 Move here from removed file m/intel386.h.
2834 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2835 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2836
261cb4bb
PE
28372012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Assume C89 or later.
2840 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2841 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2842 (xrealloc):
2843 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2844 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2845 * textprop.c, tparam.c (NULL): Remove.
2846 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2847 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2848 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2849 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2850 * xterm.c (input_signal_count): Assume volatile works.
2851
ff23cd9f
KB
28522012-05-21 Ken Brown <kbrown@cornell.edu>
2853
2854 * xgselect.c (xg_select): Fix first argument in call to 'select'
2855 (bug#11508).
2856
1b170bc6
KB
28572012-05-20 Ken Brown <kbrown@cornell.edu>
2858
2859 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2860 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2861
b2f4d39f
KB
28622012-05-19 Ken Brown <kbrown@cornell.edu>
2863
2864 * xfns.c (x_in_use): Remove `static' qualifier.
2865 * xterm.h (x_in_use): Declare.
2866 * xgselect.c: Include xterm.h.
2867 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2868 and `display_arg' (bug#9754).
2869
003fdae2
PE
28702012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2871
9232a6d9
PE
2872 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2873
003fdae2
PE
2874 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2875 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2876
784b56e2
EZ
28772012-05-18 Eli Zaretskii <eliz@gnu.org>
2878
2879 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2880
2881 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2882 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2883
2884 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2885 reference to image_cache->refcount.
2886 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2887
a0a79cde
JL
28882012-05-17 Juri Linkov <juri@jurta.org>
2889
2890 * search.c (Fword_search_regexp, Fword_search_backward)
2891 (Fword_search_forward, Fword_search_backward_lax)
2892 (Fword_search_forward_lax): Move functions to isearch.el
2893 (bug#10145, bug#11381).
2894
b0572523
PE
28952012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2898
9660f5fc
SM
28992012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2900
2901 * lread.c (init_obarray): Declare Qt and Qnil as special.
2902
4374de83
GM
29032012-05-14 Glenn Morris <rgm@gnu.org>
2904
2905 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2906 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2907
dc44c39a
PE
29082012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2909
078c97cb
PE
2910 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2911
dc44c39a
PE
2912 * unexaix.c: Port to more-recent AIX compilers.
2913 (report_error, report_error_1, make_hdr, copy_sym)
2914 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2915 Make arguments const char *, not char *, to avoid violations of C
2916 standard and to fix some AIX warnings reported by Gilles Pion.
2917
e18afed7 29182012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2919
2920 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2921 already have overlays loaded.
2922 (handle_single_display_spec): Before returning without displaying
2923 fringe bitmap, synchronize the bidi iterator with the main display
2924 iterator, by calling iterate_out_of_display_property.
2925 (iterate_out_of_display_property): Detect buffer iteration by
2926 testing that it->string is a Lisp string.
2927 (get_next_display_element): When the current object is exhausted,
2928 and there's something on it->stack, call set_iterator_to_next to
2929 proceed with what's on the stack, instead of returning zero.
2930 (set_iterator_to_next): If called at the end of a Lisp string,
2931 proceed to consider_string_end without incrementing string
2932 position. Don't increment display vector index past the end of
2933 the display vector. (Bug#11417)
c8fb9dc6
EZ
2934 (pos_visible_p): Don't report a position visible when move_it_to
2935 stopped at the last line of window, which happens to be scanned
2936 backwards by the bidi iteration. (Bug#11464)
ac268e67 2937
e18afed7 29382012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2939
2940 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2941 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2942 are on a TTY, and thus unable to display on the fringes.
2943 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2944 so we need to signal to the caller that this is a "replacing"
2945 display spec. This fixes display when the spec is invalid or we
2946 are on a TTY.
2947
e18afed7 29482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2949
2950 * unexaix.c (make_hdr): Fix typo in prototype.
2951 This bug broke the build on AIX. Problem reported by Gilles Pion.
2952
9d0a235a
MA
29532012-05-14 Michael Albinus <michael.albinus@gmx.de>
2954
2955 * keyboard.c (kbd_buffer_get_event): Read special events also in
2956 batch mode. (Bug#11415)
2957
9e6b06ed
GM
29582012-05-12 Glenn Morris <rgm@gnu.org>
2959
2960 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2961
c1a1d7a3
EZ
29622012-05-12 Eli Zaretskii <eliz@gnu.org>
2963
2964 * lisp.mk (lisp): Add newcomment.elc.
2965
3fe7cdc8
GM
29662012-05-12 Glenn Morris <rgm@gnu.org>
2967
2968 * Makefile.in (MKDIR_P): New, set by configure.
2969 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2970
53f7d2c0
PE
29712012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2972
2973 Remove unused function hourglass_started.
2974 * dispextern.h (hourglass_started):
2975 * w32fns.c (hourglass_started):
2976 * xdisp.c (hourglass_started): Remove.
2977
75aafb17
JB
29782012-05-10 Juanma Barranquero <lekktu@gmail.com>
2979
2980 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2981 Update dependencies.
2982
12959e8e
PE
29832012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2984
97107e2e
PE
2985 * xgselect.c (xg_select): Put maxfds+1 into a var.
2986 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2987
12959e8e
PE
2988 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2989
836d29b3
DA
29902012-05-10 Dave Abrahams <dave@boostpro.com>
2991
2992 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2993 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2994
5cb67954
MA
29952012-05-09 Michael Albinus <michael.albinus@gmx.de>
2996
2997 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2998 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2999 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3000 Initialize xd_registered_buses.
3001
3478ec45
PE
30022012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3003
b263a6b0
PE
3004 Untag more efficiently if USE_LSB_TAG.
3005 This is based on a proposal by YAMAMOTO Mitsuharu in
3006 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3007 For an admittedly artificial (nth 8000 longlist) benchmark on
3008 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3009 Emacs's overall text size by 1%.
3010 * lisp.h (XUNTAG): New macro.
3011 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3012 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3013 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3014 * eval.c (Fautoload):
3015 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3016 * frame.h (XFRAME): Use XUNTAG.
3017
3478ec45
PE
3018 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3019 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3020 Remove unportable assumptions about print widths of types like
3021 dbus_uint32_t.
3022 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3023 intptr_t when converting between pointer and integer, to avoid GCC
3024 warnings about wrong width.
3025
666b903b 30262012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3027
3028 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3029 stack for each reader_thread, instead of defaulting to 8MB
3030 determined by the linker. This avoids failures in creating
3031 subprocesses on Windows 7, see the discussion in this thread:
3032 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3033
b120cc17
JC
30342012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3035
3036 Fix up display of the *Minibuf-0* buffer in the mini window.
3037 * keyboard.c (read_char): Don't clear the echo area if there's no
3038 message to clear.
3039 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3040 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3041
9a4b36f8
MA
30422012-05-07 Michael Albinus <michael.albinus@gmx.de>
3043
3044 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3045 batch mode.
3046
e5f9458f
CY
30472012-05-06 Chong Yidong <cyd@gnu.org>
3048
3049 * lisp.mk (lisp): Update.
3050
eceeb5fc 30512012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3052
3053 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3054
71873e2b
SM
30552012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3056
3057 * data.c (PUT_ERROR): New macro.
3058 (syms_of_data): Use it. Add new error type `user-error'.
3059 * undo.c (user_error): New function.
3060 (Fprimitive_undo): Use it.
3061 * print.c (print_error_message): Adjust print style for `user-error'.
3062 * keyboard.c (user_error): New function.
3063 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3064
ab0fa4e4
PE
30652012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 Do not limit current-time-string to years 1000..9999.
3068 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3069 (Fcurrent_time_string): Support any year that is supported by the
3070 underlying localtime representation. Don't use asctime, as it
3071 has undefined behavior for years outside the range -999..9999.
3072
7ed806a7
PE
30732012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 Fix race conditions involving setenv, gmtime, localtime, asctime.
3076 Without this fix, interrupts could mess up code that uses these
3077 nonreentrant functions, since setting TZ invalidates existing
3078 tm_zone or tzname values, and since most of these functions return
3079 pointers to static storage.
3080 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3081 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3082 Grow the critical sections to include not just invoking
3083 localtime/gmtime, but also accessing these functions' results
3084 including their tm_zone values if any, and any related TZ setting.
3085 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3086 so that the struct tm is saved in the critical section.
3087 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3088 motivated by the fact that memory allocation needs to be outside
3089 the critical section.
3090
0c16dfed
DA
30912012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3092
3093 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3094 with RESET_INTERVAL.
3095
3096 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3097 Remove duplicated buffer name initialization.
3098
3f83ace8
JM
30992012-05-02 Jim Meyering <jim@meyering.net>
3100
3101 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3102
c7b8541e
JM
3103 * xfns.c (x_window): Use xstrdup (Bug#11375).
3104
90207a15 31052012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3106
3107 * xdisp.c (pos_visible_p): If already at a newline from the
3108 display string before the 'while' loop, don't walk back the glyphs
3109 from it3.glyph_row. Solves assertion violation when the display
3110 string begins with a newline (egg.el). (Bug#11367)
3111
b593d6a9
AH
31122012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3113
3114 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3115 Move to simple.el.
3116
4737362e
GM
31172012-05-01 Glenn Morris <rgm@gnu.org>
3118
99cf43f9
GM
3119 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3120 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3121 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3122 All were removed before 23.1.
3123
9311dcff
GM
3124 * dispnew.c: Remove HAVE_LIBNCURSES test;
3125 it is always true on relevant platforms.
3126
4d5c6349
GM
3127 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3128 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3129
4737362e
GM
3130 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3131
74dd3a6b
AS
31322012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3133
3134 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3135 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3136 Remove.
3137
13c379ee
PE
31382012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 Do not avoid creating empty evaporating overlays (Bug#9642).
3141 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3142 That is, do not delete an evaporating overlay if it becomes
3143 empty after its bounds are adjusted to fit within its buffer.
3144 This fix caused other problems, and I'm reverting it until we get
3145 to the bottom of them.
3146
a8e7d6d7 31472012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3148
3149 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3150
a8e7d6d7 31512012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3152
3153 * xdisp.c (pos_visible_p): If the window start position is beyond
3154 ZV, start the display from buffer beginning. Prevents assertion
3155 violation in init_iterator when the minibuffer window is scrolled
3156 via the scroll bar.
3157
3158 * window.c (window_scroll_pixel_based): Likewise.
3159
a8e7d6d7 31602012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3161
3162 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3163
a8e7d6d7 31642012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3165
3166 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3167 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3168
a8e7d6d7 31692012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3170
b593d6a9
AH
3171 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3172 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3173
1c6900d9
EZ
31742012-04-26 Eli Zaretskii <eliz@gnu.org>
3175
4c3fa1d9
EZ
3176 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3177 display element, check also the underlying string or buffer
3178 character. (Bug#11341)
3179
1c6900d9
EZ
3180 * w32menu.c: Include w32heap.h.
3181 (add_menu_item): If the call to AppendMenuW (via
3182 unicode_append_menu) fails, disable Unicode menus only if we are
3183 running on Windows 9X/Me.
3184
42bf8205
AS
31852012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3186
3187 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3188 (xgetint): Add missing shift for LSB tags.
3189
b1bac16e
MR
31902012-04-24 Martin Rudalics <rudalics@gmx.at>
3191
3192 * keyboard.c (read_char): Don't wipe echo area for select window
3193 events: These might get delayed via `mouse-autoselect-window'
3194 (Bug#11304).
3195
d69621cc
JB
31962012-04-24 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3199 manipulation of :loaded-from data.
3200
02fd101b
JB
32012012-04-23 Juanma Barranquero <lekktu@gmail.com>
3202
3203 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3204 now a cons (bug#11311).
3205
888bec30
PE
32062012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3207
89a438bd
PE
3208 Do not create empty overlays with the evaporate property (Bug#9642).
3209 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3210 if it becomes empty after its bounds are adjusted to fit within
3211 its buffer. Without this fix, in a nonempty buffer (let ((o
3212 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3213 yields an empty overlay that has the evaporate property, which is
3214 not supposed to happen.
3215
1068fe4d
PE
3216 Fix minor GTK3 problems found by static checking.
3217 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3218 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3219 (struct _EmacsFixedClass, emacs_fixed_get_type):
3220 Move decls here from emacsgtkfixed.h, since they needn't be public.
3221 (emacs_fixed_get_type): Now static.
3222 (emacs_fixed_class_init): Omit unused local.
3223 (emacs_fixed_child_type): Remove; unused.
3224 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3225 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3226 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3227 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3228 (EMACS_FIXED_GET_CLASS): Remove; unused.
3229 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3230
888bec30
PE
3231 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3232 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3233
de85e130
PE
32342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3235
d0baac98 3236 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3237 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3238 (__malloc_size_t, __malloc_ptrdiff_t):
3239 Remove. All uses removed, replaced by the definiens if needed,
3240 since we can assume C89 or better now.
3241 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3242 (protect_malloc_state, align, get_contiguous_space)
3243 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3244 (malloc_atfork_handler_child, malloc_enable_thread)
3245 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3246 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3247 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3248 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3249 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3250 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3251 Define using prototypes, not old style.
3252 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3253 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3254 (align): Don't assume that signed integer overflow wraps around.
3255 Omit unused local var.
3256 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3257 (_free_internal_nolock, memalign, mallochook, reallochook):
3258 Omit no-longer-needed casts.
3259 (valloc): Use getpagesize, not __getpagesize.
3260 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3261 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3262
de85e130
PE
3263 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3264
dcbf5805
MA
32652012-04-22 Michael Albinus <michael.albinus@gmx.de>
3266
3267 Move functions from C to Lisp. Make non-blocking method calls
3268 the default. Implement further D-Bus standard interfaces.
3269
3270 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3271 (QCdbus_request_name_allow_replacement)
3272 (QCdbus_request_name_replace_existing)
3273 (QCdbus_request_name_do_not_queue)
3274 (QCdbus_request_name_reply_primary_owner)
3275 (QCdbus_request_name_reply_in_queue)
3276 (QCdbus_request_name_reply_exists)
3277 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3278 (QCdbus_registered_serial, QCdbus_registered_method)
3279 (QCdbus_registered_signal): New Lisp objects.
3280 (XD_DEBUG_MESSAGE): Use sizeof.
3281 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3282 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3283 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3284 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3285 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3286 (xd_signature, xd_append_arg): Allow float for integer types.
3287 (xd_get_connection_references): New function.
b593d6a9
AH
3288 (xd_get_connection_address): Rename from xd_initialize.
3289 Return cached address.
dcbf5805
MA
3290 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3291 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3292 level.
3293 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3294 Return number of refcounts.
dcbf5805
MA
3295 (Fdbus_get_unique_name): Make stronger parameter check.
3296 (Fdbus_message_internal): New defun.
3297 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3298 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3299 (Fdbus_send_signal, Fdbus_register_service)
3300 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3301 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3302 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3303 (Vdbus_compiled_version, Vdbus_runtime_version)
3304 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3305 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3306 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3307 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3308 Adapt docstring.
dcbf5805 3309
52828e02
PE
33102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3311
da05bc4c
PE
3312 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3313 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3314 Do not assume ptrdiff_t is the same width as 'int'.
3315
52828e02
PE
3316 * alloc.c: Handle unusual debugging option combinations.
3317 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3318 since the two debugging options are incompatible.
3319 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3320 is defined.
3321 (mem_init, mem_insert, mem_insert_fixup):
3322 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3323 (NEED_MEM_INSERT): Remove; no longer needed.
3324
f01769f9
LL
33252012-04-22 Leo Liu <sdl.web@gmail.com>
3326
3327 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3328
5790543d
PE
33292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3330
3331 * sysdep.c [__FreeBSD__]: Minor cleanups.
3332 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3333 Use Emacs indenting style more consistently. Avoid some casts.
3334 Use 'double' consistently rather than mixing 'float' and 'double'.
3335
b91b7e4d
EW
33362012-04-21 Eduard Wiebe <usenet@pusto.de>
3337
b593d6a9
AH
3338 * sysdep.c (list_system_processes, system_process_attributes):
3339 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3340
6114eb15
AS
33412012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3342
3343 * lisp.mk (lisp): Update.
3344
2f38dff7
PE
33452012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3348 It is never used otherwise.
3349
4ae29f89
SM
33502012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3351
3352 * print.c (print_preprocess): Only check print_depth if print-circle
3353 is nil.
3354 (print_object): Check for cycles even when print-circle is nil and
3355 print-gensym is t, but only check print_depth if print-circle is nil.
3356
f30d612a
CY
33572012-04-20 Chong Yidong <cyd@gnu.org>
3358
3359 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3360 set the status to "failed" and ensure that sentinel is run.
3361
c07a4c0b 33622012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3363
3364 * process.c (Fset_process_inherit_coding_system_flag)
3365 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3366 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3367
c07a4c0b 33682012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3369
3370 * xdisp.c (string_buffer_position_lim): Limit starting position to
3371 BEGV.
3372 (set_cursor_from_row): If called for a mode-line or header-line
3373 row, return zero immediately.
3374 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3375 farther than the first row after the header line, if any.
3376 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3377 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3378
c07a4c0b 33792012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3380
4ae29f89
SM
3381 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3382 (bug#11238).
ad3a2b41 3383
c07a4c0b 33842012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33852012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3386
3387 configure: new option --enable-gcc-warnings (Bug#11207)
3388 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3389 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3390 (ALL_CFLAGS): Use new macros rather than old.
3391 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3392 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3393 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3394 -Wunused-result, -Wunused-variable. This should go away once
3395 the Emacs and Gnulib regex code is merged.
3396 (xmalloc, xrealloc): Now static.
3397
aba027e8
PE
33982012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * dired.c (Fsystem_groups): Remove unused local.
3401
e5a36063
GM
34022012-04-17 Glenn Morris <rgm@gnu.org>
3403
3404 * dired.c (Fsystem_users): Doc fix.
3405
316411f0
DA
34062012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3407
3408 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3409 (syms_of_dired): Add them.
3410
9426aba4
PE
34112012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3412
b62a57be
PE
3413 Fix minor alloc.c problems found by static checking.
3414 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3415 New extern decls, to avoid calling undeclared functions.
3416 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3417 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3418 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3419 (NEED_MEM_INSERT): New macro.
3420 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3421 Remove one incorrect comment and fix another.
b62a57be 3422
3539f31f
PE
3423 Fix minor ralloc.c problems found by static checking.
3424 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3425 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3426 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3427 (r_alloc_sbrk): Now static.
3428
a041960a
PE
3429 Improve ralloc.c interface checking.
3430 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3431 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3432 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3433 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3434 [REL_ALLOC]: ... to here, to check interface.
3435 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3436 Remove decls. This fixes an "It stinks!".
3437
9426aba4
PE
3438 * alloc.c (which_symbols): Fix alignment issue / type clash.
3439
d55c12ed
AS
34402012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3441
3442 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3443 (struct Lisp_Misc_Any): Likewise.
3444 (struct Lisp_Free): Likewise.
3445 * alloc.c (union aligned_Lisp_Symbol): Define.
3446 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3447 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3448 (union aligned_Lisp_Misc): Define.
3449 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3450 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3451 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3452
b948ce8b
PE
34532012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3456 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3457 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3458 * s/netbsd.h, s/sol2-6.h:
3459 Remove definition of GC_MARK_STACK, since the default now works.
3460 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3461 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3462 no longer the default.
3463 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3464
35dc09a1 34652012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3466
35dc09a1
GM
3467 * lread.c (lisp_file_lexically_bound_p):
3468 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3469
35dc09a1
GM
34702012-04-14 Eli Zaretskii <eliz@gnu.org>
3471
3472 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3473 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3474
34752012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3476
3477 * nsterm.m (constrainFrameRect): Always constrain when there is only
3478 one screen (Bug#10962).
3479
bcd86815
KB
34802012-04-13 Ken Brown <kbrown@cornell.edu>
3481
3482 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3483
c25df26e
RT
34842012-04-13 Reuben Thomas <rrt@sc3d.org>
3485
3486 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3487
0fc59f1e
DC
34882012-04-11 Daniel Colascione <dancol@dancol.org>
3489
3490 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3491 against is gone. It's better to use vfork now so that when Cygwin
3492 gains a new, working vfork, we use it automatically (bug#10398).
3493
de8c03dc
SM
34942012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3495
3496 * window.c (save_window_save): Obey window-point-insertion-type.
3497
2f097256
GM
34982012-04-11 Glenn Morris <rgm@gnu.org>
3499
3500 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3501
453b951e
SM
35022012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3503
3504 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3505
75f1671a 35062012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3507
3508 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3509 (force_quit_count): New var.
3510 (handle_interrupt): Use it.
3511
2a8ce227
JB
35122012-04-10 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * w32.c (w32_delayed_load): Record the full path of the library
3515 being loaded (bug#10424).
3516
935396c0
GM
35172012-04-09 Glenn Morris <rgm@gnu.org>
3518
05920a43
GM
3519 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3520 not just in the obarray, before snarfing them. (Bug#11036)
3521
935396c0
GM
3522 * Makefile.in ($(leimdir)/leim-list.el):
3523 Pass EMACS rather than BUILT_EMACS.
3524
a18ecafa
TZ
35252012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3526
3527 * process.c (make_process):
3528 * process.h: Add integer `gnutls_handshakes_tried' member to
3529 process struct.
3530
6bbef4e5
JC
3531 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3532 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3533
3534 * gnutls.c (gnutls_log_function2i): Convenience log function.
3535 (emacs_gnutls_read): Use new log functions,
3536 `gnutls_handshakes_tried' process member, and
3537 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3538 attempts per process (connection).
3539
b4d3bc10
CY
35402012-04-09 Chong Yidong <cyd@gnu.org>
3541
3542 * eval.c (Fuser_variable_p, user_variable_p_eh)
3543 (lisp_indirect_variable): Functions deleted.
3544 (Fdefvar): Caller changed.
3545
3546 * callint.c (Finteractive, Fcall_interactively):
3547 * minibuf.c (Fread_variable): Callers changed.
3548
70f4d973
EZ
35492012-04-09 Eli Zaretskii <eliz@gnu.org>
3550
3551 * xdisp.c (set_cursor_from_row): If the display string appears in
3552 the buffer at position that is closer to point than the position
3553 after the display string, display the cursor on the first glyph of
3554 the display string. Fixes cursor display when a 'display' text
3555 property immediately follows invisible text. (Bug#11094)
3556
cb3c2e3e
PE
35572012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3558
3559 composite.c: use 'double' consistently
3560 * composite.c (get_composition_id): Use 'double' consistently
3561 instead of converting 'float' to 'double' and vice versa; this is
3562 easier to understand and avoids a GCC warning.
3563
fd06db5d
GM
35642012-04-09 Glenn Morris <rgm@gnu.org>
3565
50fe702a
GM
3566 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3567 preparation for dumping it with emacs. (Bug#4789)
3568 (leimdir): New variable.
3569 ($(leimdir)/leim-list.el): New rule.
3570 (emacs$(EXEEXT)): Depend on leim-list.el.
3571
fd06db5d
GM
3572 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3573 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3574 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3575
55c131ee
AS
35762012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3579 proper alignment.
3580
9209588f
JB
35812012-04-07 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3584 Remove unused local variable.
3585
e3fb2efb
PE
35862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3587
3588 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3589 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3590 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3591 objects, as mark_maybe_pointer will catch them otherwise.
3592 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3593 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3594
b5385551
PE
35952012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Fix typo that broke non-Windows builds.
3598 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3599
9078ead6
EZ
36002012-04-07 Eli Zaretskii <eliz@gnu.org>
3601
3602 Support building on MS-Windows with libxml2.
3603
3604 * makefile.w32-in (OBJ2): Add xml.$(O).
3605 (GLOBAL_SOURCES): Add xml.c.
3606 ($(BLD)/xml.$(O)): New dependency list.
3607
3608 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3609 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3610 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3611 [!WINDOWSNT]: New macros.
3612 (init_libxml2_functions, libxml2_loaded_p): New functions.
3613 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3614 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3615 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3616 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3617 linked in).
6bbef4e5
JC
3618 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3619 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3620 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3621
3622 * emacs.c: Don't include libxml/parser.h.
3623 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3624 xmlCleanupParser directly.
3625
3626 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3627
3811fdf3
EZ
36282012-04-07 Eli Zaretskii <eliz@gnu.org>
3629
3630 * indent.c (Fvertical_motion): If there is a display string at
3631 point, use it.vpos to compute how many lines to backtrack after
3632 move_it_to point. (Bug#11133)
3633
2f8e16b2
EZ
36342012-04-06 Eli Zaretskii <eliz@gnu.org>
3635
3636 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3637 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3638 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3639 macros related to unification of CJK characters. For the details,
3640 see the discussion following the message here:
3641 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3642
3d439cd1
CY
36432012-04-04 Chong Yidong <cyd@gnu.org>
3644
3645 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3646
8bc53d00
EZ
36472012-04-01 Eli Zaretskii <eliz@gnu.org>
3648
3649 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3650 instead of alloca. (Bug#11138)
3651
3b0512a3
AS
36522012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3653
3654 * w32menu.c (is_simple_dialog): Properly check lisp types.
3655 (Bug#11141)
3656
8427ddd2
EZ
36572012-03-31 Eli Zaretskii <eliz@gnu.org>
3658
979022ef
EZ
3659 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3660 position we get to after a call to move_it_to fails the
3661 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3662 only if we wind up in a string from display property. (Bug#11063)
3663
a6b1c7cc
EZ
3664 * window.c (Fdelete_other_windows_internal): Invalidate the row
3665 and column information about mouse highlight, so that redisplay
3666 restores it after reallocating the glyph matrices. (Bug#7464)
3667
8427ddd2
EZ
3668 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3669 string comes from a `display' text property, use the buffer
3670 position of that property as if we actually saw that position in
3671 the row's glyphs.
697ba24b
EZ
3672 (move_it_by_lines): Remove the assertion that
3673 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3674 violated when there's a before-string at the beginning of a line.
3675 (Bug#11063)
8427ddd2 3676
65a0a738
EZ
36772012-03-30 Eli Zaretskii <eliz@gnu.org>
3678
3679 * xdisp.c (append_space_for_newline): If the default face was
3680 remapped, use the remapped face for the appended newline.
3681 (extend_face_to_end_of_line): Use the remapped default face for
3682 extending the face to the end of the line.
3683 (display_line): Call extend_face_to_end_of_line when the default
3684 face was remapped. (Bug#11068)
3685
581355cc
EZ
36862012-03-29 Eli Zaretskii <eliz@gnu.org>
3687
3688 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3689
e8fc049f
SM
36902012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3691
3692 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3693
4fb9a543
GM
36942012-03-27 Glenn Morris <rgm@gnu.org>
3695
3696 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3697 Doc fixes.
3698
679910f1
KH
36992012-03-26 Kenichi Handa <handa@m17n.org>
3700
3701 * dispextern.h (struct glyph): Fix previous change. Change the
3702 bit length of glyphless.ch to 25 (Bug#11082).
3703
90d49b7f
CY
37042012-03-26 Chong Yidong <cyd@gnu.org>
3705
3706 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3707 (command_loop_1): Use it; inhibit selection update for
3708 handle-select-window too (Bug#8996).
3709
f514f6f0
FP
37102012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3711
e8fc049f 3712 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3713
bf43fa51
KH
37142012-03-25 Kenichi Handa <handa@m17n.org>
3715
3716 * dispextern.h (struct glyph): Change the bit length of
3717 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3718
8a0c01dd
EZ
37192012-03-24 Eli Zaretskii <eliz@gnu.org>
3720
3721 * s/ms-w32.h (tzname): Include time.h before redirecting to
3722 _tzname. Fixes the MSVC build. (Bug#9960)
3723
7d1c3a76
AS
37242012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3725
8ed79523
AS
3726 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3727 characters.
3728
7d1c3a76
AS
3729 * xterm.c (XTread_socket): Only modify handling_signal if
3730 !SYNC_INPUT. (Bug#11080)
3731
e99a9b8b
EZ
37322012-03-23 Eli Zaretskii <eliz@gnu.org>
3733
3734 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3735 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3736 when fetching a multibyte character consumes more bytes than
3737 CHAR_BYTES returns, due to unification of CJK characters in
3738 string_char. (Bug#11073)
3739
5063c0e1
TN
37402012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3741
3742 * process.c (wait_reading_process_output): Handle pty disconnect
3743 by refraining from sending oneself a SIGCHLD (bug#10933).
3744
9f851fbd
CY
37452012-03-22 Chong Yidong <cyd@gnu.org>
3746
3747 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3748
5063c0e1 3749 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3750 Mark string as coming from a prefix property.
3751 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3752 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3753
fb5b8aca
CY
37542012-03-21 Chong Yidong <cyd@gnu.org>
3755
3756 * xfaces.c (Vface_remapping_alist): Doc fix.
3757
62356a1b
EZ
37582012-03-20 Eli Zaretskii <eliz@gnu.org>
3759
3760 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3761 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3762 Doc fixes.
62356a1b 3763
025de85b
CY
37642012-03-20 Chong Yidong <cyd@gnu.org>
3765
3766 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3767 to reflect default non-nil value of redisplay-dont-pause.
3768
4827f94e
KH
37692012-03-19 Kenichi Handa <handa@m17n.org>
3770
3771 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3772 it fit in a valid range (Bug#11003).
3773
e50a24a2
EZ
37742012-03-18 Eli Zaretskii <eliz@gnu.org>
3775
3776 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3777 that is not from display property, accept the row as a "cursor
3778 row" if one of the string's character has a non-nil `cursor'
3779 property. Fixes cursor positioning when there are newlines in
3780 overlay strings, e.g. in icomplete.el. (Bug#11035)
3781
9af5ed87
PE
37822012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3785
d1f55f16
CY
37862012-03-12 Chong Yidong <cyd@gnu.org>
3787
3788 * eval.c (inhibit_lisp_code): Rename from
3789 inhibit_window_configuration_change_hook; move from window.c.
3790
3791 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3792 * window.c (run_window_configuration_change_hook)
3793 (syms_of_window): Callers changed.
3794
66c5eebd
CY
37952012-03-11 Chong Yidong <cyd@gnu.org>
3796
413df973
CY
3797 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3798
66c5eebd
CY
3799 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3800
1de11f56
CY
38012012-03-10 Chong Yidong <cyd@gnu.org>
3802
3803 * frame.c (other_visible_frames): Don't assume the selected frame
3804 is visible (Bug#10955).
3805
cae07000
SM
38062012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3807
3808 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3809
89c94350
JD
38102012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3813 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3814 zero (Bug#10954).
3815
999dd333
GM
38162012-03-03 Glenn Morris <rgm@gnu.org>
3817
01a6dcc8 3818 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3819
de0100f2
EZ
38202012-03-02 Eli Zaretskii <eliz@gnu.org>
3821
3822 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3823 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3824 (redisplay_window, next_element_from_string): Fix typos in
3825 comments.
3e441275
EZ
3826 (redisplay_window): Pass to move_it_vertically the margin in
3827 pixels, not in screen lines.
de0100f2 3828
96a72ee9
GM
38292012-03-02 Glenn Morris <rgm@gnu.org>
3830
3831 * buffer.c (buffer-list-update-hook): Doc fix.
3832
312508d7
EZ
38332012-02-29 Eli Zaretskii <eliz@gnu.org>
3834
3835 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3836 push_it before setting up the iterator for the first overlay
3837 string, even if we have an empty string loaded.
3838 (next_overlay_string): If there's an empty string on the iterator
3839 stack, pop the stack. (Bug#10903)
3840
27f3c637
PE
38412012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3844 Suggested by Stefan Monnier in
3845 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3846 * alloc.c (widen_to_Lisp_Object): New static function.
3847 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3848 and widening them to Lisp_Objects. This would work even if
3849 USE_LSB_TAG is defined and wide integers are used, which might
3850 happen in a future version of Emacs.
3851
3c9dfce6
CY
38522012-02-25 Chong Yidong <cyd@gnu.org>
3853
fa74b241
CY
3854 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3855 Doc fix.
3856
3c9dfce6
CY
3857 * xselect.c (Fx_selection_exists_p): Doc fix.
3858 (x_clipboard_manager_save_all): Print an informative message
3859 before saving to clipboard manager.
3860
9486df08
CY
38612012-02-24 Chong Yidong <cyd@gnu.org>
3862
3863 * keyboard.c (process_special_events): Handle all X selection
3864 requests in kbd_buffer, not just the next one (Bug#8869).
3865
f01d3321
CY
38662012-02-23 Chong Yidong <cyd@gnu.org>
3867
3868 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3869 call when setting menu-bar-lines and tool-bar-lines parameters.
3870 (unwind_create_frame_1): New helper function.
3871
3872 * window.c (inhibit_window_configuration_change_hook): New var.
3873 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3874 (syms_of_window): Initialize it.
f01d3321 3875
86b847b6
CY
38762012-02-22 Chong Yidong <cyd@gnu.org>
3877
3878 * xterm.c (x_draw_image_relief): Add missing type check for
3879 Vtool_bar_button_margin (Bug#10743).
3880
a59225b1
CY
38812012-02-21 Chong Yidong <cyd@gnu.org>
3882
3883 * fileio.c (Vfile_name_handler_alist): Doc fix.
3884
3885 * buffer.c (Fget_file_buffer): Protect against invalid file
3886 handler return value.
3887
310f5bd4
PE
38882012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3889
cb3a28cc
PE
3890 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3891 when computing $valmask.
3892
310f5bd4
PE
3893 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3894 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3895 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3896 It's useless in that case, and it can cause problems on hosts
3897 that allocate halves of EMACS_INT values separately.
3898 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3899 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3900 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3901 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3902 it avoids undefined behavior on hosts where shifting right by more
3903 than the word width has undefined behavior.
3904
2375c96a
CY
39052012-02-19 Chong Yidong <cyd@gnu.org>
3906
3907 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3908 (Funhandled_file_name_directory, Ffile_name_as_directory)
3909 (Fdirectory_file_name, Fexpand_file_name)
3910 (Fsubstitute_in_file_name): Protect against invalid file handler
3911 return values (Bug#10845).
3912
3eb49e71
EZ
39132012-02-18 Eli Zaretskii <eliz@gnu.org>
3914
3915 * .gdbinit (pitx): Fix incorrect references to fields of the
3916 iterator stack.
3917
7b926f3f
CY
39182012-02-17 Chong Yidong <cyd@gnu.org>
3919
3920 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3921
11273115
PE
39222012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3925 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3926
c3a70e2b
CY
39272012-02-15 Chong Yidong <cyd@gnu.org>
3928
3929 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3930 marked as special. Also, starting docstrings with * is obsolete.
3931
0ca43699
AS
39322012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * gnutls.c (emacs_gnutls_write): Fix last change.
3935
2e8f3c56
LI
39362012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3937
3938 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3939 send_process.
3940
af70074f
SM
39412012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3942
3943 * keymap.c (Fsingle_key_description): Handle char ranges.
3944
95986d52
CY
39452012-02-12 Chong Yidong <cyd@gnu.org>
3946
afd83bd1
CY
3947 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3948 as that creates a dangerous corner case.
3949
95986d52
CY
3950 * window.c (Fdelete_window_internal): Invalidate the mouse
3951 highlight (Bug#9904).
3952
bd7da63e
GM
39532012-02-12 Glenn Morris <rgm@gnu.org>
3954
3955 * xselect.c (Fx_own_selection_internal)
3956 (Fx_get_selection_internal, Fx_disown_selection_internal)
3957 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3958 * nsselect.m (Fx_own_selection_internal)
3959 (Fx_disown_selection_internal, Fx_selection_exists_p)
3960 (Fx_selection_owner_p, Fx_get_selection_internal):
3961 Sync docs and argument specs with the xselect.c versions.
3962
77abcbc2
LI
39632012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3964
3965 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3966
90b671e2
EZ
39672012-02-11 Eli Zaretskii <eliz@gnu.org>
3968
1c0ca0b7
EZ
3969 * w32select.c (Fx_selection_exists_p): Sync doc string and
3970 argument list with xselect.c. (Bug#10783)
3971
3972 * w16select.c (Fx_selection_exists_p): Sync doc string and
3973 argument list with xselect.c. (Bug#10783)
90b671e2 3974
49241268
GM
39752012-02-10 Glenn Morris <rgm@gnu.org>
3976
3977 * fns.c (Fsecure_hash): Doc fix.
3978
f998bbe7 39792012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3980
3981 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3982
0992bd9c
CY
39832012-02-07 Chong Yidong <cyd@gnu.org>
3984
3985 * buffer.c (Fbuffer_local_variables)
3986 (buffer_lisp_local_variables): Handle unbound vars correctly;
3987 don't let Qunbound leak into Lisp.
3988
af008560
GM
39892012-02-07 Glenn Morris <rgm@gnu.org>
3990
dd605cc4
GM
3991 * image.c (Fimagemagick_types): Doc fix.
3992
af008560
GM
3993 * image.c (imagemagick-render-type): Change it from a lisp object
3994 to an integer. Move the doc here from the lisp manual.
3995 Treat all values not equal to 0 the same.
3996
1449fa1d
CY
39972012-02-06 Chong Yidong <cyd@gnu.org>
3998
3999 * doc.c (store_function_docstring): Avoid applying docstring of
4000 alias to base function (Bug#2603).
4001
3723ec07
AS
40022012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4003
4004 * .gdbinit (pp1, pv1): Remove redundant defines.
4005 (pr): Use pp.
4006
79c1cc1e
CY
40072012-02-04 Chong Yidong <cyd@gnu.org>
4008
4009 * nsterm.m: Declare a global (Bug#10694).
4010
d7f29f8e
EZ
40112012-02-04 Eli Zaretskii <eliz@gnu.org>
4012
cae07000
SM
4013 * w32.c (get_emacs_configuration_options):
4014 Include --enable-checking, if specified, in the return value.
d7f29f8e 4015
3b95a6f9
MR
40162012-02-04 Martin Rudalics <rudalics@gmx.at>
4017
4018 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4019 after rounding frame sizes. (Bug#9723)
4020
d6fa96a6
EZ
40212012-02-04 Eli Zaretskii <eliz@gnu.org>
4022
4023 * keyboard.c (adjust_point_for_property): Don't position point
4024 before BEGV. (Bug#10696)
4025
df0b2940
PE
40262012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4027
4028 Handle overflow when computing char display width (Bug#9496).
4029 * character.c (char_width): Return EMACS_INT, not int.
4030 (char_width, c_string_width): Check for overflow when
4031 computing the width; this is possible now that individual
4032 characters can have unbounded width. Problem introduced
4033 by merge from Emacs 23 on 2012-01-19.
4034
6bee44d6
MA
40352012-02-02 Michael Albinus <michael.albinus@gmx.de>
4036
4037 * dbusbind.c (Fdbus_register_method): Mention the return value
4038 :ignore in the docstring.
4039
44f92739
GM
40402012-02-02 Glenn Morris <rgm@gnu.org>
4041
1b9f60cc
GM
4042 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4043
44f92739
GM
4044 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4045 Unconditionally set to t. (Bug#10673)
4046 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4047 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4048 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4049
c5d3843c
KH
40502012-02-02 Kenichi Handa <handa@m17n.org>
4051
4052 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4053 0, do not call append_composite_glyph.
4054
159462d4 40552012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4056
4057 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4058 NULL (Bug#6988).
4059 (x_produce_glyphs): If the component of a composition is a null
4060 string, set it->pixel_width to 1 to avoid zero-width glyph.
4061
78cef877
EZ
40622012-02-01 Eli Zaretskii <eliz@gnu.org>
4063
4064 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4065 first 2 arguments are identical. This makes inserting large
4066 output from a subprocess an order of magnitude faster on
4067 MS-Windows, where all sbrk'ed memory is always contiguous.
4068
97897668
GM
40692012-01-31 Glenn Morris <rgm@gnu.org>
4070
4071 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4072 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4073 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4074
31fd3586
GM
40752012-01-29 Glenn Morris <rgm@gnu.org>
4076
4077 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4078
0e24a8b2
CY
40792012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4080
4081 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4082
cc0adcb0
CY
40832012-01-28 Chong Yidong <cyd@gnu.org>
4084
4085 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4086
acc28cb9
CY
40872012-01-26 Chong Yidong <cyd@gnu.org>
4088
9c69cfb7
CY
4089 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4090
acc28cb9
CY
4091 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4092 repeat counts (Bug#10507).
4093
48da7392
GM
40942012-01-26 Glenn Morris <rgm@gnu.org>
4095
4096 * lread.c (syms_of_lread): Doc fix.
4097
14af5f7f
CY
40982012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4099
4100 * coding.c (encode_designation_at_bol): Change return value to
4101 EMACS_INT.
4102
0b21c100
CY
41032012-01-25 Chong Yidong <cyd@gnu.org>
4104
4105 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4106
3c2907f7
CY
41072012-01-21 Chong Yidong <cyd@gnu.org>
4108
4109 * floatfns.c (Fcopysign): Make the second argument non-optional,
4110 since nil is not allowed anyway.
4111
959ad23f
AS
41122012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4113
4114 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4115 (send_process): Likewise.
4116
34a02f46
MR
41172012-01-19 Martin Rudalics <rudalics@gmx.at>
4118
4119 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4120 (Vwindow_persistent_parameters): Do not use Qstate.
4121 Rewrite doc-strings.
34a02f46 4122
1259009a 41232012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4124
4125 * character.c (char_width): New function.
70d4fdf6
GM
4126 (Fchar_width, c_string_width, lisp_string_width):
4127 Use char_width (Bug#9496).
25ed9e61 4128
6a6ee00d
MR
41292012-01-16 Martin Rudalics <rudalics@gmx.at>
4130
4131 * window.c (Vwindow_persistent_parameters): New variable.
4132 (Fset_window_configuration, save_window_save): Handle persistent
4133 window parameters.
4134
c85efaf7
EZ
41352012-01-14 Eli Zaretskii <eliz@gnu.org>
4136
4137 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4138 thrashing the stack of the thread. (Bug#9087)
4139
5944709e
PE
41402012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4141
4142 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4143
e71f5d99
EZ
41442012-01-11 Eli Zaretskii <eliz@gnu.org>
4145
4146 * xdisp.c (rows_from_pos_range): Handle the case where the
4147 highlight ends on a newline. (Bug#10464)
4148 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4149 he end column for display of highlight that ends on a newline
4150 before a R2L line.
4151
ce316182
GM
41522012-01-11 Glenn Morris <rgm@gnu.org>
4153
4154 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4155 from load-path also when installation-directory is nil. (Bug#10208)
4156
5b43da69
GM
41572012-01-10 Glenn Morris <rgm@gnu.org>
4158
74cc8ff9
GM
4159 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4160
7d8d6e4e
GM
4161 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4162 Update template values to be closer to their typical values these days.
5b43da69 4163
a0db8d43
EZ
41642012-01-09 Eli Zaretskii <eliz@gnu.org>
4165
4166 * xdisp.c (rows_from_pos_range): Accept additional argument
4167 DISP_STRING, and accept any glyph in a row whose object is that
4168 string as eligible for mouse highlight. Fixes mouse highlight of
4169 display strings from overlays. (Bug#10464)
4170
9a0115ab 41712012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4172
b9110d6a 4173 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4174 * fileio.c (auto_saving_dir_umask): New static var.
4175 (Fmake_directory_internal): Use it.
4176 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4177 creating the directory. The old code temporarily assigns
4178 too-generous permissions to the directory.
4179 (do_auto_save_eh): Clear it.
b9110d6a 4180 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4181 that the var is always cleared.
4182
6c1bd3f3
EZ
41832012-01-07 Eli Zaretskii <eliz@gnu.org>
4184
4185 * search.c (scan_buffer): Pass character positions to
4186 know_region_cache, not byte positions. (Bug#6540)
4187
069d2b50
L
41882012-01-07 LynX <_LynX@bk.ru> (tiny change)
4189
4190 * w32.c (sys_rename): Report EXDEV when rename of a directory
4191 fails because the target is on another logical disk. (Bug#10284)
4192
75bf0d33
DB
41932012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4194
4195 * xterm.c (x_embed_request_focus): New function.
4196
4197 * xterm.h: Add prototype.
4198
4199 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4200
1c6e5a32
GM
42012012-01-05 Glenn Morris <rgm@gnu.org>
4202
4203 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4204
651e947e
EZ
42052012-01-01 Eli Zaretskii <eliz@gnu.org>
4206
4207 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4208 Load gnutls_transport_set_lowat only if GnuTLS version is below
4209 2.11.1.
4210 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4211 GnuTLS versions below 2.11.1.
4212
3778cdd8
AL
42132011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4214
4215 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4216 to the doc string advising against its use for altering the way
4217 windows are scrolled.
4218
0e5317f7
KH
42192011-12-28 Kenichi Handa <handa@m17n.org>
4220
4221 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4222 coding-system ASCII compatible only when it does not produce BOM
4223 on encoding (Bug#10383).
4224
93d5ca1f
JD
42252011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4226
4227 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4228 can scroll.
4229 (create_and_show_popup_menu): Always use menu_position_func for
4230 Gtk3 (Bug#10361).
4231
ca22b785
AS
42322011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4233
4234 * callint.c (Fcall_interactively): Don't truncate prompt string.
4235
d048e1e6
EZ
42362011-12-23 Eli Zaretskii <eliz@gnu.org>
4237
4238 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4239 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4240 resumed from there (after widening). (Bug#10360)
d048e1e6 4241
5ccaba1f
JD
42422011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4243
4244 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4245
204ee57f
JD
42462011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4247
b81d40f0
JB
4248 * nsterm.m (x_free_frame_resources):
4249 Release f->output_data.ns->miniimage.
204ee57f
JD
4250 (ns_index_color): Fix indentation. Do not retain
4251 color_table->colors[i].
4252
4253 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4254 before returning.
4255
4256 * nsfns.m (x_set_background_color): Assign return value from
4257 ns_index_color to face-background instead of NSColor*.
4258 (ns_implicitly_set_icon_type): Fix indentation.
4259 Change assignment in for loop to comparison.
4260
4261 * emacs.c (ns_pool): New variable.
4262 (main): Assign ns_pool.
4263 (Fkill_emacs): Call ns_release_autorelease_pool.
4264
4265 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4266 autorelease fdesc, release fdAttrs and tdict.
4267 (ns_get_covering_families): Release charset.
4268 (ns_findfonts): Release NSFontDescriptor created with new.
4269 (ns_uni_to_glyphs): Fix indentation.
4270 (setString): Release attrStr before assigning new value.
4271
c803b2b7
JD
42722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4273
678f4426
JD
4274 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4275 and NS_IMPL_COCOA.
4276 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4277 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4278
cd394be1 42792011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4280
5fecd5fc
JD
4281 * nsterm.m (ns_term_init): Subscribe for notifications
4282 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4283 to method trackingNotification in EmacsMenu.
4284
4285 * nsmenu.m (trackingMenu): New variable.
3771cb17 4286 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4287 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4288 from Aquamacs (Bug#7030).
678f4426
JD
4289
42902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4291
c803b2b7
JD
4292 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4293 (symbol_to_nsstring): Fix indentation.
4294 (ns_symbol_to_pb): New function.
cae07000
SM
4295 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4296 (Fns_rotate_cut_buffers_internal): Remove.
4297 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4298 Fns_store_cut_buffer_internal.
4299 (ns_get_foreign_selection, Fx_own_selection_internal)
4300 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4301 (Fns_get_selection_internal, Fns_store_selection_internal):
4302 Use ns_symbol_to_pb and check if return value is nil.
4303 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4304 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4305 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4306 renamed to Sns_store_selection_internal.
4307 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4308 and remove this function.
4309 (ns_handle_selection_clear): Remove, never used.
4310 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4311 here.
4312
e1b01a3a
KB
43132011-12-17 Ken Brown <kbrown@cornell.edu>
4314
4315 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4316 GID is unknown (Bug#10257).
4317
2adb6e85
PE
43182011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4319
4320 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4321 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4322 which caused a build failure on GNU/Linux IA-64. This problem was
4323 introduced by my 2011-10-07 patch.
4324
d1d7b339
JL
43252011-12-15 Juri Linkov <juri@jurta.org>
4326
4327 * image.c (imagemagick_error): New function. (Bug#10112)
4328 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4329 Use `imagemagick_error' where ImageMagick functions return
4330 `MagickFalse'.
4331 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4332 proper order.
4333
100d5755
KH
43342011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4335
4336 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4337 fill background (Bug#8992).
4338
454592a6
MR
43392011-12-13 Martin Rudalics <rudalics@gmx.at>
4340
4341 * window.c (Vwindow_combination_resize)
4342 (Vwindow_combination_limit): Use t instead of non-nil in
4343 doc-strings.
61d4b438
MR
4344 (Vrecenter_redisplay): Add first sentence of doc-string on
4345 separate line.
53524d93 4346 (Frecenter): Fix doc-string typo.
454592a6 4347
3633e3aa
KH
43482011-12-11 Kenichi Handa <handa@m17n.org>
4349
4350 * coding.c (Funencodable_char_position): Pay attention to the
4351 buffer text relocation (Bug#9389).
4352
7b9d523a 43532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4354
7b9d523a
JD
4355 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4356 gtk_init (Bug#10100).
4357
b73189c6
EZ
43582011-12-10 Eli Zaretskii <eliz@gnu.org>
4359
4360 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4361 IT->string is nil. (Bug#10263)
4362
f7dfe5d6
JD
43632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4364
83faebb4
JD
4365 * nsterm.h (x_free_frame_resources): Declare.
4366
f7dfe5d6
JD
4367 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4368 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4369
4370 * nsterm.h (ns_get_defaults_value): Declare.
4371
4372 * nsterm.m (ns_default): Call ns_get_defaults_value.
4373
7cd4e72c
EZ
43742011-12-09 Eli Zaretskii <eliz@gnu.org>
4375
4376 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4377 (Bug#10170)
4378
b34d7317
YM
43792011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4380
4381 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4382 that where the value of an _OBJC_* symbol points to is in the .bss
4383 section (Bug#10240).
4384
76470ad1
KH
43852011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4386
4387 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4388 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4389
745fff94
KH
43902011-12-08 Kenichi Handa <handa@m17n.org>
4391
4392 * ftfont.c (get_adstyle_property): Fix previous change
4393 (Bug#10233).
4394
6e44397c
JB
43952011-12-07 Juanma Barranquero <lekktu@gmail.com>
4396
4397 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4398 dirs from the default value of EMACSLOADPATH (bug#10208).
4399
7efa6272
GM
44002011-12-07 Glenn Morris <rgm@gnu.org>
4401
4402 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4403 installation and source directories as well. (Bug#10208)
4404
f6fc4d87
CY
44052011-12-06 Chong Yidong <cyd@gnu.org>
4406
4407 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4408
2bf26180
GM
44092011-12-06 Glenn Morris <rgm@gnu.org>
4410
4411 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4412 as an error, not just -1. (Bug#10217)
4413
3a6ad4f0
CY
44142011-12-05 Chong Yidong <cyd@gnu.org>
4415
4416 * keyboard.c (process_special_events): New function.
4417 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4418
75a3b399
PE
44192011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 * coding.c (encode_designation_at_bol): Don't use uninitialized
4422 local variable (Bug#9318).
4423
c3c9e25e
KH
44242011-12-05 Kenichi Handa <handa@m17n.org>
4425
4426 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4427 return Qnil (Bug#8046, Bug#10193).
4428
5eb05ea3
KH
44292011-12-05 Kenichi Handa <handa@m17n.org>
4430
4431 * coding.c (encode_designation_at_bol): New args charbuf_end and
4432 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4433 (coding_set_source): Return how many bytes coding->source was
4434 relocated.
4435 (coding_set_destination): Return how many bytes
4436 coding->destination was relocated.
4437 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4438 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4439
44402011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4441
4442 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4443 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4444 macro (Bug#9318).
4445
44462011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4447
4448 The following changes are to fix Bug#9318.
4449
a79703f5 4450 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4451 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4452 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4453 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4454
7dbda6df
JB
44552011-12-05 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * lisp.h (process_quit_flag): Fix external declaration.
4458
6d5eb5b0
SM
44592011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4460
4461 Don't macro-inline non-performance-critical code.
4462 * eval.c (process_quit_flag): New function.
4463 * lisp.h (QUIT): Use it.
4464
a0c3fad0
JD
44652011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4466
4467 * nsfns.m (get_geometry_from_preferences): New function.
4468 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4469
6c07aac2
AS
44702011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4471
4472 * emacs.c (Qkill_emacs): Define.
4473 (syms_of_emacs): Initialize it.
4474 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4475 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4476 (quit_throw_to_read_char): Add parameter `from_signal'.
4477 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4478 * lisp.h (QUIT): Call Fkill_emacs if requested.
4479
c052ead4
JD
44802011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4481
4482 * widget.c (update_wm_hints): Return if wmshell is null.
4483 (widget_update_wm_size_hints): New function.
4484
4485 * widget.h (widget_update_wm_size_hints): Declare.
4486
4487 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4488 widget_update_wm_size_hints (Bug#10104).
4489
9e49252b
EZ
44902011-12-03 Eli Zaretskii <eliz@gnu.org>
4491
4492 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4493 before a newline, prepare the bidi iterator for consuming the
4494 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4495 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4496
02b16839
JL
44972011-12-02 Juri Linkov <juri@jurta.org>
4498
4499 * search.c (Fword_search_regexp): New Lisp function created from
4500 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4501 (Fword_search_backward, Fword_search_forward)
4502 (Fword_search_backward_lax, Fword_search_forward_lax):
4503 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4504 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4505
0068070e
SM
45062011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4507
4508 * fileio.c (Finsert_file_contents): Move after-change-function call
4509 to before the "handled:" label, since all "goto handled" appear in
4510 cases where the *-change-functions have already been properly called
4511 (bug#10117).
4512
3360a3fc
AS
45132011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4514
4515 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4516 waiting for input. (Bug#10169)
4517
73d6c093
EZ
45182011-11-30 Eli Zaretskii <eliz@gnu.org>
4519
4520 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4521 verifies glyph row's hash code--we have just reallocated the
4522 glyphs, so their contents can be complete garbage. (Bug#10164)
4523
febe6bea
JB
45242011-11-30 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4527
801a4313
EZ
45282011-11-30 Eli Zaretskii <eliz@gnu.org>
4529
4530 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4531 attributes are tested _before_ calling verify_row_hash, to protect
4532 against GCC re-ordering of the tests. (Bug#10164)
4533
2b56b87e
JD
45342011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4535
4536 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4537
4538 * xterm.c (handle_one_xevent): Only set async_visible and friends
4539 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4540 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4541 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4542
dbf31225
PE
45432011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4544
4545 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4546 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4547 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4548 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4549 All uses changed to use GCPRO1 etc.
4550 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4551 Revert to old implementation (i.e., before 2011-03-11).
4552
1305621b
YM
45532011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4554
4555 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4556 of scroll runs so as to avoid assigning disabled bogus rows and
4557 unnecessary graphics copy operations.
4558
8c9afb46
EZ
45592011-11-27 Eli Zaretskii <eliz@gnu.org>
4560
4561 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4562 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4563 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4564 (malloc, free, realloc, calloc): Redirect to e_* only when
4565 compiling Emacs.
4566
4567 * lisp.h (GCTYPEBITS): Move before first use.
4568 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4569 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4570 this macro definition.
4571
4572 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4573 _MSC_VER.
4574
54e9e3bf
JD
45752011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4576
6d5eb5b0
SM
4577 * gtkutil.c (xg_create_frame_widgets):
4578 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4579 present with Gtk+ 2.0.
4580
83aca1cb
PE
45812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * fileio.c (Finsert_file_contents): Undo previous change; see
4584 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4585
5b76caa4
PE
45862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 Rename locals to avoid shadowing.
4589 * fileio.c (Finsert_file_contents):
4590 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4591 * process.c (wait_reading_process_output):
4592 Rename inner 'proc' to 'p' to avoid shadowing.
4593 Indent for consistency with usual Emacs style.
4594
8c535114
EZ
45952011-11-25 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (redisplay_window): If cursor row is not fully visible
4598 after recentering, and scroll-conservatively is set to a large
4599 number, scroll window by a few more lines to make the cursor fully
4600 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4601 (start_display): Don't move to the next line if the display should
4602 start at a newline that is part of a display vector or an overlay
4603 string. (Bug#10119)
8c535114 4604
fa4fdb5c
JL
46052011-11-24 Juri Linkov <juri@jurta.org>
4606
4607 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4608 after the `MagickPingImage' call. (Bug#10112)
4609
90ec88df
CY
46102011-11-23 Chong Yidong <cyd@gnu.org>
4611
4612 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4613
56e2e794
MR
46142011-11-23 Martin Rudalics <rudalics@gmx.at>
4615
4616 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4617 making another buffer current. (Bug#10114)
4618
b6e64c41
GM
46192011-11-23 Glenn Morris <rgm@gnu.org>
4620
4621 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4622
6b21de18
CY
46232011-11-23 Chong Yidong <cyd@gnu.org>
4624
4625 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4626 using it (Bug#5984).
4627
b12cd789
EZ
46282011-11-22 Eli Zaretskii <eliz@gnu.org>
4629
4630 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4631 and header-lines, as they don't have one computed for them.
4632 (Bug#10098)
4633
4634 * .gdbinit (prow): Make displayed values more self-explaining.
4635 Add row's hash code.
4636
261b6fd4
LMI
46372011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638
4639 * process.c (wait_reading_process_output): Fix asynchrounous
4640 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4641 (wait_reading_process_output): Add comment and URL.
261b6fd4 4642
e7cfd277
JD
46432011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4644
4645 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4646
a9b9b7f5
CY
46472011-11-21 Chong Yidong <cyd@gnu.org>
4648
4649 * window.c (Fnext_window, Fprevious_window): Doc fix.
4650
b0d15b4f
SM
46512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4652
4653 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4654
fe7a3057
JB
46552011-11-20 Juanma Barranquero <lekktu@gmail.com>
4656
4657 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4658
d2999b1a
MR
46592011-11-20 Martin Rudalics <rudalics@gmx.at>
4660
4661 * window.c (Fset_window_combination_limit): Rename argument
4662 STATUS to LIMIT.
4663 (Vwindow_combination_limit): Remove "status" from doc-string.
4664
d5ff9cd0
AS
46652011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4666
4667 * m/ibms390.h: Remove.
4668 * m/ibms390x.h: Don't include "ibms390.h".
4669
a5bb9bd3
SM
46702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4671
4672 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4673 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4674
cd1181db
JB
46752011-11-20 Juanma Barranquero <lekktu@gmail.com>
4676
4677 * casetab.c (Fset_case_table):
4678 * charset.c (Fcharset_after): Fix typos.
4679
615a3b8d 46802011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4681
17e845af
PE
4682 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4683 Otherwise, valgrind does not work on some platforms.
4684 Problem reported by Andreas Schwab in
6a0bf43d
PE
4685 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4686 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4687 is set, removing the need for VIRT_ADDRESS_VARIES.
4688 (PURE_P): Use a more-efficient implementation that needs just one
4689 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4690 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4691 to 4 (xorl, subq, cmpq, setbe).
4692 * alloc.c (pure): Always extern now, since that's the
4693 VIRT_ADDR_VARIES behavior.
4694 (PURE_POINTER_P): Use a single comparison, not two, for
4695 consistency with the new puresize.h.
4696 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4697 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4698 Remove VIRT_ADDR_VARIES no longer needed.
4699
f8fe6f96
EZ
47002011-11-19 Eli Zaretskii <eliz@gnu.org>
4701
4702 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4703 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4704 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4705 behave as if the cursor position were at the window margin.
4706
4707 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4708 and the cursor position is out of bounds, behave as if the cursor
4709 position were at the window margin. (Bug#10075)
4710
df05a53c
CY
47112011-11-18 Chong Yidong <cyd@gnu.org>
4712
4713 * window.c (Fwindow_combination_limit): Make first argument
4714 non-optional, since it is meaningless for live windows like the
4715 selected window.
61ccba97 4716
2071918e
DA
47172011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4718
4719 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4720
b50a28de
SM
47212011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4724 (graft_intervals_into_buffer): Simplify.
4725
015137db
EZ
47262011-11-18 Eli Zaretskii <eliz@gnu.org>
4727
4728 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4729 hash values of the two rows.
4730 (copy_row_except_pointers): Preserve the used[] arrays and the
4731 hash values of the two rows. (Bug#10035)
68c95424 4732 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4733
4734 * xdisp.c (row_hash): New function, body extracted from
4735 compute_line_metrics.
4736 (compute_line_metrics): Call row_hash, instead of computing the
4737 hash code inline.
4738
4739 * dispnew.c (verify_row_hash): Call row_hash for computing the
4740 hash code of a row, instead of duplicating code from xdisp.c.
4741
4742 * dispextern.h (row_hash): Add prototype.
4743
a2addb04
TH
47442011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4745
4746 * frame.c (delete_frame): Don't delete the terminal when the last
4747 X frame is closed if emacs is built with GTK toolkit.
4748
df85d315
JB
47492011-11-17 Juanma Barranquero <lekktu@gmail.com>
4750
4751 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4752
a0c2d0ae
MR
47532011-11-17 Martin Rudalics <rudalics@gmx.at>
4754
4755 * window.c (Vwindow_splits): Rename to
4756 Vwindow_combination_resize. Suggested by Juri Linkov.
4757 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4758 of Vwindow_splits.
4759
58179cce
JB
47602011-11-16 Juanma Barranquero <lekktu@gmail.com>
4761
7877f373
JB
4762 * nsfns.m (Fns_font_name):
4763 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4764
b6f67890
MR
47652011-11-16 Martin Rudalics <rudalics@gmx.at>
4766
4767 * window.h (window): Rename slot "nest" to "combination_limit".
4768 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4769 (Fset_window_nest): Rename to Fset_window_combination_limit.
4770 (Vwindow_nest): Rename to Vwindow_combination_limit.
4771 (recombine_windows, make_parent_window, make_window)
4772 (Fsplit_window_internal, saved_window)
4773 (Fset_window_configuration, save_window_save): Rename all
4774 occurrences of window_nest to window_combination_limit.
4775
c7015153
JB
47762011-11-15 Juanma Barranquero <lekktu@gmail.com>
4777
4778 * image.c (imagemagick_load_image): Fix typo.
4779
322ad6ec
EZ
47802011-11-14 Eli Zaretskii <eliz@gnu.org>
4781
4782 * xdisp.c (display_line): Move the call to
4783 highlight_trailing_whitespace before the call to
4784 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4785 faces of all the glyphs to compute ROW's hash value.
4786 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4787
f067b8ec
JB
47882011-11-14 Juanma Barranquero <lekktu@gmail.com>
4789
4790 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4791 just return (bug#10044).
4792
1e5b2111
EZ
47932011-11-12 Eli Zaretskii <eliz@gnu.org>
4794
7ef3cbd5
EZ
4795 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4796 with user-defined heap size. Bump the default size of the temacs
4797 heap to 27MB, to avoid memory warning when running temacs.
4798 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4799
1e5b2111
EZ
4800 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4801 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4802 (verify_row_hash) [XASSERTS]: New function.
4803 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4804 that the hash value of glyph rows is correct.
1e5b2111 4805
89d61221
MR
48062011-11-12 Martin Rudalics <rudalics@gmx.at>
4807
4808 * window.h (window): Remove splits slot.
4809 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4810 (Fdelete_other_windows_internal, make_parent_window)
4811 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4812 (Fset_window_configuration, save_window_save): Don't deal with
4813 split status of windows.
4814 (saved_window): Remove splits slot.
4815 (Vwindow_splits): Rewrite doc-string.
4816
97f18cc8
JD
48172011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4818
4819 * xfns.c (unwind_create_frame):
4820 * nsfns.m (unwind_create_frame):
4821 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4822 Vframe_list (Bug#9999).
4823
22a648b4
DA
48242011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4825
0b381c7e 4826 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4827
659afede
KH
48282011-11-11 Kenichi Handa <handa@m17n.org>
4829
4830 * callproc.c (Fcall_process): Set the member dst_multibyte of
4831 process_coding.
4832
9ac0394b
KH
48332011-11-11 Johan Bockgård <bojohan@gnu.org>
4834
4835 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4836 avoid a crash (bug#9496).
4837
2fbdc249
CY
48382011-11-09 Chong Yidong <cyd@gnu.org>
4839
4840 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4841 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4842
ac6b1f81
PE
48432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4846
09db192c
PE
48472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4848
4849 Avoid some portability problems by eschewing 'extern inline' functions.
4850 The trivial performance wins aren't worth the portability hassles; see
4851 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4852 et seq.
4853 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4854 (window_box_width, window_box_left, window_box_left_offset)
4855 (window_box_right, window_box_right_offset): Undo previous change,
4856 by removing the "extern"s.
4857 * intervals.c (adjust_intervals_for_insertion)
4858 (adjust_intervals_for_deletion): Undo previous change,
4859 making these static again.
4860 (offset_intervals, temp_set_point_both, temp_set_point)
4861 (copy_intervals_to_string): No longer inline.
4862 * xdisp.c (window_text_bottom_y, window_box_width)
4863 (window_box_height, window_box_left_offset)
4864 (window_box_right_offset, window_box_left, window_box_right)
4865 (window_box): No longer inline.
4866
105216ed
CY
48672011-11-08 Chong Yidong <cyd@gnu.org>
4868
4869 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4870 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4871 Signal an error if not a live window.
105216ed
CY
4872 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4873 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4874
ae9e237f
JB
48752011-11-07 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * lisp.h (syms_of_abbrev): Remove declaration.
4878 Reported by CHENG Gao <chenggao@royau.me>.
4879
c7aa8333
EZ
48802011-11-07 Eli Zaretskii <eliz@gnu.org>
4881
4882 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4883 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4884 of temacs in GUI mode.
4885
be7f5545
MR
48862011-11-07 Martin Rudalics <rudalics@gmx.at>
4887
4888 * window.h: Declare delete_all_child_windows instead of
4889 delete_all_subwindows.
4890 * window.c (Fwindow_nest, Fset_window_nest)
4891 (Fset_window_new_total, Fset_window_new_normal)
4892 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4893 (delete_all_subwindows): Rename to delete_all_child_windows.
4894 (Fdelete_other_windows_internal, Fset_window_configuration):
4895 Call delete_all_child_windows instead of delete_all_subwindows.
4896 * frame.c (delete_frame): Call delete_all_child_windows instead
4897 of delete_all_subwindows.
4898
ca78dc43
PE
48992011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4902 This is also needed for porting to any host where GC_MARK_STACK is
4903 not GC_MAKE_GCPROS_NOOPS.
4904 (which_symbols): Use it.
4905
a0241d01
KH
49062011-11-07 Kenichi Handa <handa@m17n.org>
4907
4908 * coding.c (coding_set_destination): Check coding->src_pos only
4909 when coding->src_object is a buffer (bug#9910).
4910
4911 * process.c (send_process): Set the member src_multibyte of coding
4912 to 0 (bug#9911) when sending a unibyte text.
4913
4914 * callproc.c (Fcall_process): Set the member src_multibyte of
4915 process_coding to 0 (bug#9912).
4916
a64bfdfa 49172011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4918
4919 * xmenu.c (cleanup_widget_value_tree): New function.
4920 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4921 calling free_menubar_widget_value_tree directly (Bug#9830).
4922
cb41b32a
PE
49232011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4924
4925 Fix some portability problems with 'inline'.
4926 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4927 (window_box_width, window_box_left, window_box_left_offset)
4928 (window_box_right, window_box_right_offset): Declare extern.
4929 Otherwise, these inline functions do not conform to C99 and
4930 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4931 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4932 * intervals.c (adjust_intervals_for_insertion)
4933 (adjust_intervals_for_deletion): Now extern, because otherwise the
4934 extern inline functions 'offset_intervals' couldn't refer to it.
4935 (static_offset_intervals): Remove.
4936 (offset_intervals): Rewrite using the old contents of
4937 static_offset_intervals. The old version didn't conform to C99
4938 because an extern inline function contained a reference to an
4939 identifier with static linkage.
4940
b7041366
AS
49412011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4942
4943 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4944 GC.
4945
88a37c4d
EZ
49462011-11-06 Eli Zaretskii <eliz@gnu.org>
4947
4948 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4949 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4950 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4951 return Qleft_to_right.
4952
49745b39
CY
49532011-11-06 Chong Yidong <cyd@gnu.org>
4954
4955 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4956 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4957 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4958 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4959 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4960 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4961 (Fwindow_vscroll): Doc fix.
4962 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4963 argument, since it makes no sense to pass a live window and for
4964 consistency with window-child.
4965
1f05cd82
CS
49662011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4967
4968 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4969 support MSVC.
4970
22610910
JR
49712011-11-05 Jason Rumney <jasonr@gnu.org>
4972
4973 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4974 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4975 fonts (Bug#6029).
4976 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4977 bitwise arithmetic preventing use of unicode-sip and non-truetype
4978 opentype fonts.
4979
a06776b2
EZ
49802011-11-05 Eli Zaretskii <eliz@gnu.org>
4981
3ad924ba
EZ
4982 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4983 "emacs"-only part.
4984
a06776b2
EZ
4985 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4986 initialization code to keep similarity to xfns.c after changes
4987 from 2011-11-05.
4988
c9e7db78
JD
49892011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4990
a97f8f3f
JD
4991 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4992 (unwind_create_frame): New function (Bug#9943).
4993 (Fx_create_frame): Restructure code to be more similar to the one in
4994 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4995 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4996 Move terminal->reference_count++ just before making the frame official
4997 (Bug#9943).
4998
4999 * nsterm.m (x_free_frame_resources): New function.
5000 (x_destroy_window): Move code to x_free_frame_resources.
5001
c9e7db78 5002 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5003 (Fx_create_frame, x_create_tip_frame):
5004 Move terminal->reference_count++ just before making the frame
75f1671a 5005 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5006 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5007
a6fc3b5c
EZ
50082011-11-05 Eli Zaretskii <eliz@gnu.org>
5009
5010 Support MSVC build with newer versions of Visual Studio.
5011 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5012 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5013 nt/gmake.defs.
5014
5015 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5016 which are not supported by MSVC.
5017 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5018 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5019 bitfields.
5020 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5021 types in bitfields.
5022 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5023
5024 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5025
58179cce 50262011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5027
5028 Support MSVC build with newer versions of Visual Studio.
5029 * w32.c: Don't include w32api.h for MSVC.
5030 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5031
5032 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5033 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5034 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5035 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5036 e_* cousins.
5037 (alloca) [_MSC_VER]: Define to _alloca.
5038
5039 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5040
5041 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5042
a58c13ed
EZ
50432011-11-04 Eli Zaretskii <eliz@gnu.org>
5044
5045 * xdisp.c (note_mouse_highlight): If either of
5046 previous/next-single-property-change returns nil, treat that as
5047 the beginning or the end of the buffer. (Bug#9955)
5048
fe0b6370
JD
50492011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5050
a58c13ed 5051 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5052 label is not null (Bug#9951).
5053 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5054 may be NULL.
5055
89bd5ee1
EZ
50562011-11-04 Eli Zaretskii <eliz@gnu.org>
5057
5058 * window.c (Fwindow_body_size): Mention in the doc string that the
5059 return value is in frame's canonical units. (Bug#9949)
5060
84c3edb9
EZ
50612011-11-03 Eli Zaretskii <eliz@gnu.org>
5062
4e2fb5c7
EZ
5063 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5064
84c3edb9 5065 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5066 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5067 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5068
bc17a887
EZ
50692011-11-01 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5072 Don't stop backward scan on the continuation glyph, even though
5073 its CHARPOS is positive.
6d5eb5b0
SM
5074 (mouse_face_from_buffer_pos, note_mouse_highlight):
5075 Rename cover_string to disp_string.
bc17a887 5076
4ee88440
MR
50772011-11-01 Martin Rudalics <rudalics@gmx.at>
5078
5079 * window.c (temp_output_buffer_show): Don't use
5080 Vtemp_buffer_show_specifiers.
5081 (Vtemp_buffer_show_specifiers): Remove unused variable.
5082
c2ff3c02
EZ
50832011-10-30 Eli Zaretskii <eliz@gnu.org>
5084
5085 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5086 past the beginning of the current glyph matrix.
5087
58179cce 50882011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5089
5090 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5091 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5092 HAVE_GTK3 (Bug#9869).
b77a6a7f 5093
3b574623
JD
5094 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5095 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5096
b77a6a7f
JD
5097 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5098
5099 * xterm.c: Declare x_handle_net_wm_state to return int.
5100 (handle_one_xevent): Check if we are iconified but don't have
5101 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5102 (get_current_wm_state): Return non-zero if not hidden,
5103 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5104 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5105 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5106 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5107
196e41e4
PE
51082011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5111 so that this new function doesn't get optimized away by a
5112 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5113
021f2e1a
AS
51142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5115
5116 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5117
8b058d44
EZ
51182011-10-29 Eli Zaretskii <eliz@gnu.org>
5119
5120 Fix the `xbytecode' command.
5121 * .gdbinit (xprintbytestr): New command.
b50a28de 5122 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5123 (xbytecode): Print the byte-code string as well.
5124
4452fb80
EZ
51252011-10-29 Kim Storm <storm@cua.dk>
5126
8b058d44
EZ
5127 * alloc.c (which_symbols): New function.
5128
21b72067
AS
51292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5130
5131 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5132 line. (Bug#9903)
5133
83ed7b5c
GM
51342011-10-29 Glenn Morris <rgm@gnu.org>
5135
5136 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5137 Not clear what it was for, and it causes various bugs. (Bug#9839)
5138
5a7a728b
EZ
51392011-10-28 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5142 possible random value that matches one of those tested as
5143 condition to clear the mouse face.
5144
d3d0842f
CY
51452011-10-28 Chong Yidong <cyd@gnu.org>
5146
5147 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5148
31b39d13
DN
51492011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5150
5151 * window.c (make_window): Initialize phys_cursor_on_p.
5152
9aba6043
SM
51532011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5154
5155 * lisp.h (struct Lisp_Symbol): Update comments.
5156
c20992f4
JB
51572011-10-28 Juanma Barranquero <lekktu@gmail.com>
5158
5159 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5160
db4f02f2
EZ
51612011-10-28 Eli Zaretskii <eliz@gnu.org>
5162
5163 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5164 <oslsachem@gmail.com> for helping to debug this.
5165
5166 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5167 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5168 (g_b_init_get_glyph_outline_w): New static variables.
5169 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5170 (GetGlyphOutlineW_Proc): New typedefs.
5171 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5172 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5173 New functions.
5174 (w32font_open_internal, compute_metrics):
5175 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5176 instead of calling the "wide" APIs directly.
5177
5178 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5179
5180 * w32.h (syms_of_w32font): Add prototype.
5181
87e68db4
JB
51822011-10-27 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5185 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5186 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5187 (Fmove_to_window_line): Doc fix.
5188
435c1d67
CY
51892011-10-27 Chong Yidong <cyd@gnu.org>
5190
5191 * process.c (make_process): Set gnutls_state to NULL.
5192
5193 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5194 non-NULL, regardless of GNUTLS_INITSTAGE.
5195 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5196 an error. Set process slots as soon as we allocate them.
5197
5198 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5199
9c6c6f49
CY
52002011-10-27 Chong Yidong <cyd@gnu.org>
5201
9aba6043
SM
5202 * gnutls.c (emacs_gnutls_deinit): New function.
5203 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5204 (Fgnutls_deinit, Fgnutls_boot): Use it.
5205
5206 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5207 (deactivate_process): Call emacs_gnutls_deinit.
5208
657d08d3
JB
52092011-10-27 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * image.c (x_create_x_image_and_pixmap):
5212 * w32.c (sys_rename, w32_delayed_load):
5213 * w32font.c (fill_in_logfont):
5214 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5215
5430d399
JB
52162011-10-26 Juanma Barranquero <lekktu@gmail.com>
5217
5218 * w32fns.c (w32_default_color_map): New function,
5219 extracted from Fw32_default_color_map.
a7ef684b 5220 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5221
fe0055fa
PE
52222011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5225
e6346438
SM
52262011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5227
5228 * keyboard.c (test_undefined): New function (bug#9751).
5229 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5230
e112cc37
ET
52312011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5232
5233 * sysdep.c (init_sys_modes): Fix the check for the controlling
5234 terminal (Bug#6649).
5235
7b5d6677
EZ
52362011-10-20 Eli Zaretskii <eliz@gnu.org>
5237
5238 * dispextern.h (struct bidi_it): New member next_en_type.
5239
5240 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5241 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5242 current character, check also for next_en_type being WEAK_EN.
5243 (bidi_resolve_weak): Don't enter the expensive loop if the current
5244 position is before next_en_pos. Record the bidi type of the first
5245 non-ET, non-BN character we find, in addition to its position.
5246 (bidi_level_of_next_char): Invalidate next_en_type when
5247 next_en_pos is over-stepped.
5248
7da0b018
PE
52492011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5250
5251 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5252 * editfns.c: Rewrite current-time-zone so that it invokes
5253 the equivalent of (format-time-string "%Z") to get the time zone name.
5254 This fixes a bug when the time zone name contains characters that
5255 need converting from the system time locale to Emacs internal format.
5256 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5257 that patch fixed format-time-string to do the conversion, but
5258 I forgot to fix current-time-zone.
5259 (format_time_string): New function, containing most of
5260 what Fformat_time_string used to contain.
5261 (Fformat_time_string): Rewrite in terms of format_time_string.
5262 This doesn't change this function's behavior.
5263 (current-time-zone): Rewrite to use format_time_string.
5264 This fixes the bug reported by Michael Schierl in
5265 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5266 Jason Rumney's 2007-06-07 change worked around this bug, but
5267 didn't fix it.
5268 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5269
8547b010
EZ
52702011-10-19 Eli Zaretskii <eliz@gnu.org>
5271
5272 * xdisp.c (start_display): If the character at POS is displayed
5273 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5274 (try_window_reusing_current_matrix): If a line ends in a display
5275 vector or the next line starts in a display vector, continue
5276 redrawing the window even though the character position of
5277 start_row was reached.
8547b010
EZ
5278 (Bug#9771, part 2)
5279
4e948d15
CY
52802011-10-18 Chong Yidong <cyd@gnu.org>
5281
5282 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5283 with nobreak-char-display too.
5284
4787455f
EZ
52852011-10-18 Eli Zaretskii <eliz@gnu.org>
5286
5287 Fix part 3 of bug#9771.
5288 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5289 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5290 non-neutral characters if the current character is a paragraph
5291 separator (a.k.a. Newline). This avoids running the same
5292 expensive loop twice, once when we consume the preceding newline
5293 and the other time when the line actually needs to be displayed.
5294 Avoid the loop when we see neutrals on the base embedding level
5295 following a character whose directionality is the same as the
5296 paragraph's. This avoids running the expensive loop when a line
5297 ends in a long sequence of neutrals, like control characters.
5298 Add assertion against STRONG_AL type. Slightly rearrange code
5299 that determines the type of a neutral given the first non-neutral
5300 that follows it.
5301 (bidi_level_of_next_char): Set next_en_pos to zero when
5302 invalidating its info.
5303
2c91f553
EZ
53042011-10-17 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (push_display_prop): Determine whether to record string
5307 or buffer position by IT->string, not by IT->method. Allow
5308 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5309 (move_it_vertically_backward): Don't look for character position
5310 immediately after the newline when in a continuation line.
5311 (Bug#9771, part 1)
2c91f553 5312
c7b08b0d
MR
53132011-10-15 Martin Rudalics <rudalics@gmx.at>
5314
5315 * window.c (coordinates_in_window): Rewrite and delabelize
5316 vertical border check. (Bug#5357) (Bug#9618)
5317
6b02f655
SM
53182011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5319
5320 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5321 errors in XSetWindowBorder (bug#9310).
5322
81d40c92
DA
53232011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5324
5325 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5326 avoid crash when xmalloc overrun checking is enabled.
5327
d4172c3b
EZ
53282011-10-13 Eli Zaretskii <eliz@gnu.org>
5329
5330 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5331 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5332 cursor motion with <left> and <right> arrow keys.
5333
5334 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5335 some callers set that themselves.
5336
b00eea75
EZ
53372011-10-12 Eli Zaretskii <eliz@gnu.org>
5338
5339 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5340 display string and the previous row comes from the same string and
5341 is empty. (Bug#9739) (Bug#9738)
5342
8fe012c4
SM
53432011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5344
5345 * doc.c (get_doc_string): Encode file name (bug#9735).
5346
0074aef2
EZ
53472011-10-12 Eli Zaretskii <eliz@gnu.org>
5348
79beb178
EZ
5349 * bidi.c (bidi_level_of_next_char):
5350 * xdisp.c (get_visually_first_element): Remove old incorrect
5351 comments regarding the Unicode Line Separator character.
5352
0074aef2
EZ
5353 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5354
6e4b3fbe
DA
53552011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5356
5357 * alloc.c (Fgc_status): Do not access beyond zombies array
5358 boundary if nzombies > MAX_ZOMBIES.
5359 * alloc.c (dump_zombies): Add missing format specifier.
5360
0324f3af
PE
53612011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5362
b5525cac
PE
5363 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5364 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5365
0324f3af
PE
5366 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5367 Some packages use them to denote characters with modifiers.
5368
e9b5f888
AS
53692011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5370
5371 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5372 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5373 matching a pp-number. Rename parameter var to var1.
5374
127827c0
SM
53752011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5376
5377 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5378
c8fd3bd0
GM
53792011-10-08 Glenn Morris <rgm@gnu.org>
5380
5381 * callint.c (Fcall_interactively): Give a more explicit error for the
5382 'c' case with a non-character input. (Bug#8479)
5383
352ec8ff
EZ
53842011-10-08 Eli Zaretskii <eliz@gnu.org>
5385
03669ccb
EZ
5386 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5387 lines.
7061c986
EZ
5388 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5389 lines that are hscrolled on the left.
03669ccb 5390
352ec8ff
EZ
5391 * dispnew.c (buffer_posn_from_coords): Account for a possible
5392 presence of header-line. (Bug#4426)
5393
a66cfb1c
SM
53942011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5395
6b02f655
SM
5396 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5397 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5398
7c5ee88e
PE
53992011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5400
5401 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5402 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5403 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5404 this makes Emacs dump core during garbage collection on rare
5405 occasions. sizeof is obviously inferior to offsetof here, so
5406 stick with offsetof.
5407 (GC_POINTER_ALIGNMENT): New macro.
5408 (mark_memory): Omit 3rd (offset) arg; caller changed.
5409 Don't assume EMACS_INT alignment is the same as pointer alignment.
5410
df1bbe5b
SM
54112011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5412
5413 * keyboard.c (read_key_sequence_remapped): New var.
5414 (read_key_sequence): Compute remapping in the right buffer.
5415 (command_loop_1): Use read_key_sequence's remapping directly.
5416
51553db6
SM
54172011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5418
32c1fffd
SM
5419 * dired.c (file_name_completion): Don't expand file name.
5420 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5421 before checking file name handler.
5422
51553db6
SM
5423 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5424 they've been requested explicitly (bug#9591).
5425
b6bd1599 54262011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5427
5428 * keymap.c (Fsingle_key_description): Use make_specified_string
5429 instead of build_string to build string from push_key_description.
5430 (Bug#5193)
5431
f701dc2a
PE
54322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5433
4222c55d
PE
5434 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5435 This fixes a Y2038 bug on 64-bit hosts.
5436 * buffer.c (reset_buffer):
5437 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5438 (Fclear_buffer_auto_save_failure):
5439 Use 0, not -1, to represent an unset failure time, since time_t
5440 might not be signed.
5441
f701dc2a
PE
5442 Remove dependency on glibc malloc internals.
5443 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5444 Move back here from lisp.h, but with their new implementations.
5445 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5446 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5447 * charset.c (charset_table_init): New static var.
5448 (syms_of_charset): Use it instead of xmalloc. This removes a
5449 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5450 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5451 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5452 Move back to alloc.c.
5453 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5454 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5455
9ceebf39
JD
54562011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5457
5458 * nsterm.m (windowDidResize): Call x_set_window_size only when
5459 ns_in_resize is true. Otherwise set pixelwidth/height and
5460 call change_frame_size (Bug#9628).
5461
cb993c58
PE
54622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5463
3930c88b
PE
5464 Port --enable-checking=all to Fedora 14 x86-64.
5465 * charset.c (syms_of_charset): Also account for glibc malloc's
5466 internal overhead when calculating the initial malloc maximum.
5467
cb993c58
PE
5468 Port --enable-checking=all to Fedora 14 x86.
5469 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5470 Move to lisp.h.
5471 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5472 (overrun_check_realloc, overrun_check_free):
5473 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5474 That way, xmalloc returns a properly-aligned pointer even if
5475 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5476 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5477 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5478 into account when calculating the initial malloc maximum.
5479 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5480 Move here from alloc.c, so that charset.c can use it too.
5481 Properly align; the old code wasn't right for common 32-bit hosts
5482 when configured with --enable-checking=all.
5483 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5484 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5485
31bed486
EZ
54862011-09-29 Eli Zaretskii <eliz@gnu.org>
5487
04c70788 5488 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5489 use EDOM.
5490
fbcaa2f3
EZ
54912011-09-28 Eli Zaretskii <eliz@gnu.org>
5492
5493 * xdisp.c (compute_display_string_end): If there's no display
5494 string at CHARPOS, return -1.
5495
5496 * bidi.c (bidi_fetch_char): When compute_display_string_end
5497 returns a negative value, treat the character as a normal
5498 character not covered by a display string. (Bug#9624)
5499
a239d4e9
JB
55002011-09-28 Juanma Barranquero <lekktu@gmail.com>
5501
5502 * lread.c (Fread_from_string): Fix typo in docstring.
5503
88652fd5
EZ
55042011-09-27 Eli Zaretskii <eliz@gnu.org>
5505
5506 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5507 newline, reseat the iterator instead of bidi-iterating there one
5508 character at a time. (Bug#9610)
32c1fffd
SM
5509 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5510 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5511
ed497dd4
AS
55122011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5513
5514 * lread.c (readevalloop): Use correct code for NBSP.
5515 (read1): Likewise. (Bug#9608)
5516
b2bf61aa
MA
55172011-09-25 Michael Albinus <michael.albinus@gmx.de>
5518
5519 * dbusbind.c (Fdbus_register_signal): When service is not
5520 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5521
32bbb17c
GM
55222011-09-25 Glenn Morris <rgm@gnu.org>
5523
5524 * buffer.c (truncate-lines): Doc fix.
5525
94e0933e
CY
55262011-09-24 Chong Yidong <cyd@stupidchicken.com>
5527
5528 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5529 (Fset_window_next_buffers): Doc fix.
5530
cddde921
GM
55312011-09-24 Glenn Morris <rgm@gnu.org>
5532
5533 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5534
1260aef1
PE
55352011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5536
25b4bfa0
PE
5537 Fix minor problems found by static checking.
5538 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5539 * indent.c (Fvertical_motion): Fix == vs = typo.
5540
e3cbd34b
EZ
55412011-09-24 Eli Zaretskii <eliz@gnu.org>
5542
a66cfb1c
SM
5543 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5544 Default value is now t. Doc fix.
6bf7006f 5545
e3cbd34b 5546 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5547 logic when moving up, not only when moving down. Fix the
e3cbd34b 5548 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5549 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5550
5551 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5552 CHARPOS is covered by a display string which includes newlines.
5553 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5554 is covered by a display string with embedded newlines.
5555
a3de0cbd
MA
55562011-09-24 Michael Albinus <michael.albinus@gmx.de>
5557
5558 * dbusbind.c (Fdbus_register_signal): Add match rule to
5559 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5560 (Fdbus_register_method, Vdbus_registered_objects_table):
5561 Fix docstring.
a3de0cbd 5562
b260039d
JM
55632011-09-24 Jim Meyering <meyering@redhat.com>
5564
32c1fffd 5565 do not ignore write error for any output size
b260039d
JM
5566 The previous change was incomplete.
5567 While it makes emacs --batch detect the vast majority of stdout
5568 write failures, errors were still ignored whenever the output size is
5569 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5570 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5571 && echo FAIL: ignored write error
5572 FAIL: ignored write error
5573 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5574 && echo FAIL: ignored write error
5575 FAIL: ignored write error
5576 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5577
8eca8a7c
AS
55782011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5579
5580 * emacs.c (Fkill_emacs): In noninteractive mode exit
5581 non-successfully if a write error occurred on stdout. (Bug#9574)
5582
3341db62
EZ
55832011-09-21 Eli Zaretskii <eliz@gnu.org>
5584
5585 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5586 the xassert test.
5587
5588 * dispextern.h (struct it): Update the comment documenting what
5589 can it->OBJECT be.
5590
8c203dbf
EZ
55912011-09-20 Eli Zaretskii <eliz@gnu.org>
5592
5593 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5594 a display string, extend search for cursor position to end of row.
5595 (find_row_edges): If the row ends in a newline from a display
5596 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5597 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5598 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5599 non-empty line. Fixes confusing cursor motion with arrow keys at
5600 the beginning of a line that starts with whitespace.
8c203dbf 5601
a4824228
LMI
56022011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5603
5604 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5605 (bug#9493).
5606
33ed493b
CY
56072011-09-18 Chong Yidong <cyd@stupidchicken.com>
5608
5609 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5610 boolean (Bug#9154).
5611
56cd55c8
EZ
56122011-09-18 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (display_line): Record maximum and minimum buffer
5615 positions even if no glyphs were produced (e.g., by a zero-width
5616 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5617 buffer positions that will be removed from the glyph row because
5618 they don't fit.
c02dcedf
EZ
5619 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5620 column is beyond frame width: don't subtract 1 "pixel" when
5621 computing width of the stretch.
3e62b7e0
EZ
5622 (reseat_at_next_visible_line_start): Undo the change made on
5623 2011-09-17 that saved paragraph information and restored it after
5624 the call to `reseat'. (Bug#9545)
56cd55c8 5625
5ed99d36 56262011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5627
5628 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5629 and turn window cursor on if cleared (Bug#9415).
5630
5ed99d36 56312011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5632
5633 * search.c (boyer_moore): Take unibyte characters from pattern
5634 literally. (Bug#9458)
5635
9bade7b2
EZ
56362011-09-18 Eli Zaretskii <eliz@gnu.org>
5637
5638 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5639
e5e9d610
PE
56402011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5641
87e4427a
PE
5642 Fix minor problem found by static checking.
5643 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5644 initialized, to pacify gcc -Wuninitialized.
5645
e5e9d610
PE
5646 * fileio.c: Report proper errno when syscall falls.
5647 (Finsert_file_contents): Save and restore errno,
5648 so that report_file_error outputs the correct diagnostic.
5649 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5650
a1674f0b
EZ
56512011-09-18 Eli Zaretskii <eliz@gnu.org>
5652
5653 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5654
fbfb6dd4
EZ
56552011-09-17 Eli Zaretskii <eliz@gnu.org>
5656
5657 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5658 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5659
bb187662
EZ
56602011-09-17 Eli Zaretskii <eliz@gnu.org>
5661
1137e8b8 5662 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5663 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5664
5665 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5666 (bidi_find_paragraph_start): Search back for paragraph beginning
5667 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5668 (bidi_move_to_visually_next): Only trigger paragraph-related
5669 computations when the last character is a newline or at EOB, not
5670 just any NEUTRAL_B. (Bug#9470)
5671
bb187662
EZ
5672 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5673 truncated lines if point is covered by a display string. (Bug#9524)
5674
2e621251
PE
56752011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5676
5677 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5678 (cons_to_x_long): New function.
5679 (lisp_data_to_selection_data): Use it. Correct the test for
5680 short-versus-long data; it was negated. Break out of vector
5681 loop, for efficiency, when a long datum is discovered.
5682
91a15bc6
SM
56832011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5684
5685 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5686
b41c3a35
EZ
56872011-09-16 Eli Zaretskii <eliz@gnu.org>
5688
5689 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5690 GCC PR/17406) by declaring this function with external scope.
5691
7812ba2d
PE
56922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5693
5694 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5695 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5696
cf7edc2a
AS
56972011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5698
5699 * editfns.c (Fformat): Correctly handle text properties on "%%".
5700
bd01620e
EZ
57012011-09-15 Eli Zaretskii <eliz@gnu.org>
5702
5703 * xterm.c (x_draw_composite_glyph_string_foreground):
5704 * w32term.c (x_draw_composite_glyph_string_foreground):
5705 * term.c (encode_terminal_code):
5706 * composite.c (composition_update_it, get_composition_id):
5707 * xdisp.c (get_next_display_element)
5708 (fill_composite_glyph_string): Add comments about special meaning
5709 of TAB characters in a composition.
5710
a02719a3
PE
57112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5712
5713 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5714 This occurs when processing a multibyte format.
5715 Problem reported by Wolfgang Jenker.
a02719a3 5716
72589a3c
JB
57172011-09-15 Johan Bockgård <bojohan@gnu.org>
5718
5719 * xdisp.c (try_cursor_movement): Only check for exact match if
5720 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5721
1c14176c
PE
57222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 Remove unused external symbols.
5725 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5726 * xdisp.c (calc_pixel_width_or_height): Now static.
5727 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5728 * indent.c (check_display_width):
5729 * w32term.c: Fix comment to match code.
5730 * xterm.c, xterm.h (x_catching_errors): Remove.
5731
d2eea5b5
PE
57322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5733
5734 * xselect.c: Use signed conversions more consistently (Bug#9498).
5735 (selection_data_to_lisp_data): Assume incoming selection data are
5736 signed integers, not unsigned. This is to be consistent with
5737 outgoing selection data, which was modified to use signed integers
5738 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5739 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5740 expects long, not unsigned long.
5741
46888499
EZ
57422011-09-14 Eli Zaretskii <eliz@gnu.org>
5743
5744 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5745 computation of loop end. Reported by Johan Bockgård
5746 <bojohan@gnu.org>.
5747
ef8ef9fb
CY
57482011-09-13 Chong Yidong <cyd@stupidchicken.com>
5749
5750 * frame.c (Fother_visible_frames_p): Function deleted.
5751
fa819fed
EZ
57522011-09-12 Eli Zaretskii <eliz@gnu.org>
5753
5754 * indent.c (compute_motion): Process display vector front to back
5755 rather than the other way around. (Bug#2496)
5756
2ba8e008
SM
57572011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5758
5759 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5760
20f53c69
CY
57612011-09-11 Chong Yidong <cyd@stupidchicken.com>
5762
5763 * minibuf.c (Fread_from_minibuffer): Doc fix.
5764
d562d7a4
EZ
57652011-09-11 Eli Zaretskii <eliz@gnu.org>
5766
5767 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5768 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5769
1c4d7f3d
LMI
57702011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5771
5772 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5773 value for non-existent files.
5774
b885bf36
EZ
57752011-09-11 Eli Zaretskii <eliz@gnu.org>
5776
5777 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5778 set its "size" to -1. This will set the modtime_size field of
5779 the corresponding buffer to -1, which is what
5780 verify-visited-file-modtime expects for files that do not exist.
5781 (Bug#9139)
5782
6612f0bf
PE
57832011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5786 here ...
5787 * lisp.h: ... from here. push_key_description is no longer
5788 defined in keyboard.c, so its declaration should not be in
5789 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5790 logically belongs with push_key_description.
5791
dfb3f755
PE
57922011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5793
5794 * buffer.h: Include <sys/types.h> instead of <time.h>.
5795 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5796 Problem reported by Herbert J. Skuhra.
5797
3134906c
LMI
57982011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5799
5800 * xml.c (parse_region): Make the parsing work for
5801 non-comment-starting XML files again (bug#9144).
5802
8d903f4e
AS
58032011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5804
5805 * image.c (gif_load): Fix calculation of bottom and right corner.
5806 (Bug#9468)
5807
80ad64f4
EZ
58082011-09-10 Eli Zaretskii <eliz@gnu.org>
5809
5810 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5811 redisplay in small windows.
5812
208a048d
EZ
58132011-09-09 Eli Zaretskii <eliz@gnu.org>
5814
5815 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5816
9b1c252e
MR
58172011-09-08 Martin Rudalics <rudalics@gmx.at>
5818
5819 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5820 Operate on live windows only.
5821
2949f33b
JB
58222011-09-08 Juanma Barranquero <lekktu@gmail.com>
5823
5824 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5825
e08dcafd
EZ
58262011-09-07 Eli Zaretskii <eliz@gnu.org>
5827
5828 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5829 only under bidi iteration.
5830
115b96bd
JD
58312011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5832
5833 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5834
c8199d0f
PE
58352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5836
5837 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5838 Without this fix, the command to link temacs failed due to an
5839 undefined symbol __builtin_isnan. This is because
5840 /usr/include/iso/math_c99.h #defines isnan(x) to
5841 __builtin_isnan(x), but the bundled gcc, which identifies itself
5842 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5843 a __builtin_isnan.
5844 * floatfns.c (isnan): #undef, and then #define to a clone of
5845 what's in data.c.
5846 (Fisnan): Always define, since it's always available now.
5847 (syms_of_floatfns): Always define isnan at the Lisp level.
5848
e39b275c 58492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5850
5851 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5852
b2db44d9 58532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5854
f4af5137 5855 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5856 The previous code assumed that file offsets (off_t values) fit in
5857 EMACS_INT variables, which is not true on typical 32-bit hosts.
5858 The code messed up by falsely reporting buffer overflow in cases
5859 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5860 when "big" contains more than 2**29 bytes, even though this
5861 inserts just one byte and does not overflow the buffer.
5862 (Finsert_file_contents): Store file offsets as off_t
5863 values, not as EMACS_INT values. Check for overflow when
5864 converting between EMACS_INT and off_t. When checking for
5865 buffer overflow or for overlap, take the offsets into account.
5866 Don't use EMACS_INT for small values where int suffices.
5867 When checking for overlap, fix a typo: ZV was used where
5868 ZV_BYTE was intended.
5869 (Fwrite_region): Don't assume off_t fits into 'long'.
5870 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5871
ecfc0a49
MA
58722011-09-05 Michael Albinus <michael.albinus@gmx.de>
5873
5874 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5875
6511acf2 58762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5877
0999621a 5878 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5879
5880 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5881 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5882 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5883 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5884 (modify_event_symbol): Do not assume that the length of
5885 name_alist_or_stem is safe to alloca and fits in int.
5886 (Fexecute_extended_command): Likewise for function name and binding.
5887 (Frecursion_depth): Wrap around reliably on integer overflow.
5888 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5889 since some callers pass EMACS_INT values.
5890 (Fsingle_key_description): Don't crash if symbol name contains more
5891 than MAX_ALLOCA bytes.
5892 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5893 (get_minibuffer): Arg is now EMACS_INT, not int.
5894 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5895 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5896 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5897
2be7d702
PE
5898 * dbusbind.c (signature_cat): New function.
5899 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5900 Do not overrun buffer; instead, report string overflow.
5901
9d1df220
PE
5902 * dispnew.c (add_window_display_history): Don't overrun buffer.
5903 Truncate instead; this is OK since it's just a log.
5904
33ef5c64
PE
5905 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5906 even if the time zone offset is outlandishly large.
5907 Don't mishandle offset == INT_MIN.
5908
66c6fdd5
PE
5909 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5910 when creating daemon; the previous buffer-overflow check was incorrect.
5911
d749b01b
PE
5912 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5913 which has the guts of the old verror function.
5914
b5cd1905
PE
5915 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5916 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5917
6e1a67fb
PE
5918 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5919 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5920 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5921 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5922 length of string rather than counting it via multiple sprintfs;
5923 that's simpler and more reliable.
c21721cc
PE
5924 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5925 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5926 sprintf, in case result does not fit in int.
5927
c57b67fc
PE
5928 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5929 (fontset_from_font): Print it.
5930
8a401434
PE
5931 * frame.c (tty_frame_count): Now printmax_t, not int.
5932 (make_terminal_frame, set_term_frame_name): Print it.
5933 (x_report_frame_params): In X, window IDs are unsigned long,
5934 not signed long, so print them as unsigned.
5935 (validate_x_resource_name): Check for implausibly long names,
5936 and don't assume name length fits in 'int'.
5937 (x_get_resource_string): Don't blindly alloca invocation name;
5938 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5939 not fit in int.
5940
6e1a67fb
PE
5941 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5942 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5943 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5944
0df02bf3
PE
5945 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5946 Use esprintf, not sprintf, in case result does not fit in int.
5947
48e30793
PE
5948 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5949 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5950 it as a large positive number.
5951 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5952 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5953
a66ff6d8
PE
5954 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5955 in case result does not fit in int.
5956
aca216ff
PE
5957 * print.c (float_to_string): Detect width overflow more reliably.
5958 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5959 buffer overrun. Don't assume list length fits in 'int'. Treat
5960 print length of 0 as 0, not as infinity; to be consistent with other
5961 uses of print length in this function. Don't overflow print length
5962 index. Don't assume hash table size fits in 'long', or that
5963 vectorlike size fits in 'unsigned long'.
5964
31c286f7
PE
5965 * process.c (make_process): Use printmax_t, not int, to format
5966 process-name gensyms.
5967
55e5faa1
PE
5968 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5969
80f2e268
PE
5970 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5971 to avoid potential buffer overrun.
5972
670741ab
PE
5973 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5974 if X resource line is longer than 512 bytes.
5975
b7163a50
PE
5976 * xfns.c (x_window): Make sprintf buffer a bit bigger
5977 to avoid potential buffer overrun.
5978
ae58ff1f
PE
5979 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5980
c43c8a6a
PE
5981 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5982
3f8236f4
PE
59832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5984
53e9fe90 5985 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5986 Without these, Emacs silently mishandles large integers sometimes.
5987 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5988 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5989
6511acf2
PE
5990 * xdisp.c (try_window_id): Check Emacs fixnum range before
5991 converting to 'int'.
806add1d 5992
6511acf2 5993 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5994 Check that an Emacs fixnum is in range before assigning it to 'int'.
5995 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5996 values converted from Emacs fixnums.
5997 (Frecenter): Don't wrap around a line count if it is out of 'int'
5998 range; instead, treat it as an extreme value.
5999 (Fset_window_configuration, compare_window_configurations):
6000 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6001
6511acf2
PE
6002 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6003 that can exceed INT_MAX. Check that EMACS_INT value is in range
6004 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6005 (match_limit): Don't assume that a fixnum can fit in 'int'.
6006
6511acf2 6007 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6008 exceed INT_MAX.
6009
6511acf2 6010 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6011 (Fvertical_motion): Don't wrap around LINES values that don't fit
6012 in 'int'. Instead, treat them as extreme values. This is good
6013 enough for windows, which can't have more than INT_MAX lines anyway.
6014
fcb901a7
LMI
60152011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6016
0f2f6b6d
LMI
6017 * Require libxml/parser.h to avoid compilation warning.
6018
fcb901a7
LMI
6019 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6020
6021 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6022 since this reportedly can destroy thread storage.
6023
6e20a0d4
CY
60242011-08-30 Chong Yidong <cyd@stupidchicken.com>
6025
6026 * syntax.c (find_defun_start): Update all cache variables if
6027 exiting early (Bug#9401).
6028
148ae00e
EZ
60292011-08-30 Eli Zaretskii <eliz@gnu.org>
6030
f6cfbd8f
EZ
6031 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6032
148ae00e
EZ
6033 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6034 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6035 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6036
6037 * term.c (tty_append_glyph): New function.
6038 (produce_stretch_glyph): Static function and its prototype deleted.
6039
a66cfb1c
SM
6040 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6041 Add prototypes.
148ae00e 6042
c4a07a4c
PE
60432011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6046 when checking :margin (Bug#9390).
6047 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6048 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6049 so that the name doesn't mislead. All uses changed.
6050
6bc8cd65
JB
60512011-08-28 Johan Bockgård <bojohan@gnu.org>
6052
6053 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6054 set_tty_hooks.
6055
dca4927e
EZ
60562011-08-27 Eli Zaretskii <eliz@gnu.org>
6057
6058 * xdisp.c (move_it_to): Don't bail out early when reaching
6059 position beyond to_charpos, if we are scanning backwards.
6060 (move_it_vertically_backward): When DY == 0, make sure we get to
6061 the first character in the line after the newline.
6062
f2cad773
PE
60632011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6066 (ccl_driver): Do not generate an out-of-range pointer.
6067 (Fccl_execute_on_string): Remove unnecessary check for
6068 integer overflow, noted by Stefan Monnier in
6069 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6070 Remove a FIXME that didn't need fixing.
6071 Simplify the newly-introduced buffer reallocation code.
6072
0cae2cdb
JB
60732011-08-27 Juanma Barranquero <lekktu@gmail.com>
6074
6075 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6076
5fc295a4 60772011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6078
70c60eb2 6079 Integer and memory overflow issues (Bug#9196).
726e0ab1 6080
d31850da
PE
6081 * doc.c (get_doc_string): Rework so that
6082 get_doc_string_buffer_size is the actual buffer size, rather than
6083 being 1 less than the actual buffer size; this makes xpalloc more
6084 convenient.
6085
a69fbedb
PE
6086 * image.c (x_allocate_bitmap_record, cache_image):
6087 * xselect.c (Fx_register_dnd_atom):
6088 Simplify previous changes by using xpalloc.
6089
fe5c5d37
PE
6090 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6091 since either will do and ptrdiff_t is convenient with xpalloc.
6092
0065d054
PE
6093 * charset.c (charset_table_size)
6094 (struct charset_sort_data.priority): Now ptrdiff_t.
6095 (charset_compare): Don't overflow if priorities differ greatly.
6096 (Fsort_charsets): Don't assume list length fits in int.
6097 Check for size-calculation overflow when allocating sort data.
6098 (syms_of_charset): Allocate an initial charset table that is
6099 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6100
6101 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6102
6103 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6104 The actual value is always <= INT_MAX, and leaving it unsigned made
6105 overflow checking harder.
6106
6107 * dispextern.h (struct glyph_matrix.rows_allocated)
6108 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6109 with xpalloc. The values are still always <= INT_MAX.
6110
6111 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6112
6113 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6114 (SAFE_NALLOCA): New macro.
6115
6116 * region-cache.c (struct boundary.pos, find_cache_boundary)
6117 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6118 (set_cache_region, invalidate_region_cache)
6119 (revalidate_region_cache, know_region_cache, region_cache_forward)
6120 (region_cache_backward, pp_cache):
6121 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6122 so that ptrdiff_t * can be passed to xpalloc.
6123 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6124 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6125 (pp_cache): Don't assume cache_len fits in int.
6126 * region-cache.h: Adjust extern decls to match.
6127
6128 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6129 EMACS_INT, since either will do, for xpalloc.
6130
6131 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6132 (xnmalloc, xnrealloc, xpalloc): New functions.
6133
726e0ab1
PE
6134 * bidi.c (bidi_shelve_header_size): New constant.
6135 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6136 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6137
51f30bc5 6138 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6139 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6140 (overlay_strings):
6141 Don't update size of array until after memory allocation succeeds,
6142 because xmalloc/xrealloc may not return.
0065d054
PE
6143 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6144 now that we have proper integer overflow checking.
6145 (record_overlay_string, overlay_strings): Catch overflows when
6146 calculating size of overlay_str_buf.
726e0ab1 6147
0065d054
PE
6148 * callproc.c (Fcall_process): Check for size overflow when
6149 calculating size of args2.
6150 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6151 Normally we prefer signed values, but sticking with ptrdiff_t would
6152 require adding more-complicated checks.
726e0ab1
PE
6153
6154 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6155 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6156 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6157 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6158
6159 * character.c (Fstring): Check for size-calculation overflow.
6160
6161 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6162 unnecessary integer overflow. Check for size overflow.
6163 (encode_coding_object): Don't update size until xmalloc succeeds.
6164
6165 * composite.c (get_composition_id): Check for overflow in glyph
6166 length calculations.
6167
6168 Integer and memory overflow fixes for display code.
6169 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6170 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6171 (scrolling_window): Check for overflow in size calculations.
6172 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6173 Don't assume glyph table len fits in int.
6174 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6175 (row_table_size): Now ptrdiff_t, not int.
6176 (scrolling_window): Avoid overflow in size calculations.
6177 Don't update size until allocation succeeds.
6178 * fns.c (concat): Check for overflow in size calculations.
6179 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6180 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6181 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6182
6183 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6184 (get_doc_string): Check for size calculation overflow.
6185 Don't update size until allocation succeeds.
6186 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6187 EMACS_INT, where ptrdiff_t will do.
6188 (Fsubstitute_command_keys): Check for string overflow.
6189
6190 * editfns.c (set_time_zone_rule): Don't assume environment length
6191 fits in int.
6192 (message_length): Now ptrdiff_t, not int.
6193 (Fmessage_box): Don't update size until allocation succeeds.
6194 Don't assume message length fits in int.
6195 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6196
0065d054
PE
6197 * emacs.c (main): Do not reallocate argv, since there is a null at
6198 the end that can be overwritten, and this way there's no need to
6199 worry about size-calculation overflow.
6200 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6201
6202 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6203 alloc succeeds.
6204 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6205
6206 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6207 (x_set_scroll_bar_width, x_figure_window_size):
6208 Check for integer overflow.
6209 (x_set_alpha): Do not assume XINT fits in int.
6210
6211 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6212 This is for the members text_lines, text_cols, total_lines, total_cols,
6213 where the system imposes an 'int' limit.
6214
6215 * fringe.c (Fdefine_fringe_bitmap):
6216 Don't update size until alloc works.
6217
6218 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6219 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6220
6221 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6222 Check for size-calculation overflow.
6223 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6224 do, as we prefer signed integers.
6225 (id_to_widget.max_size, id_to_widget.used)
6226 (xg_store_widget_in_map, xg_remove_widget_from_map)
6227 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6228 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6229 Use and return ptrdiff_t, not int.
6230 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6231 * gtkutil.h: Change prototypes to match the above.
6232
6233 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6234 are duplicate now that they've been promoted to lisp.h.
6235 (x_allocate_bitmap_record, x_alloc_image_color)
6236 (make_image_cache, cache_image, xpm_load):
6237 Don't update size until alloc is done.
6238 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6239 (x_detect_edges):
3256efce 6240 Check for size calculation overflow.
726e0ab1
PE
6241 (ct_colors_allocated_max): New constant.
6242 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6243 overflow.
3256efce 6244
726e0ab1
PE
6245 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6246 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6247 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6248 Use ptrdiff_t, not int, to count maps.
6249 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6250 calculations. Don't update size until allocation succeeds.
6251 Redo calculations to avoid overflow.
726e0ab1
PE
6252 * keyboard.h: Change prototypes to match the above.
6253
6254 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6255 to count maps.
6256 (current_minor_maps): Check for size calculation overflow.
6257 * keymap.h: Change prototypes to match the above.
6258
6259 * lread.c (read1, init_obarray): Don't update size until alloc done.
6260
6261 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6262 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6263
726e0ab1
PE
6264 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6265 Now ptrdiff_t, not int.
6266 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6267 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6268
6269 * process.c (Fnetwork_interface_list): Check for overflow
6270 in size calculation.
6271
6272 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6273
6274 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6275 overflow. Don't bother calling xmalloc when xrealloc will do.
6276
6277 * search.c (Freplace_match): Check for size calculation overflow.
6278 (Fset_match_data): Don't assume list lengths fit in 'int'.
6279
6280 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6281 for command line length. Do not attempt to address one before the
6282 beginning of an array, as that's not portable.
6283
6284 * term.c (max_frame_lines): Remove; unused.
6285 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6286 not int.
6287 (encode_terminal_code, calculate_costs): Check for size
6288 calculation overflow.
6289 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6290 table lengths and related sizes. Don't update size until alloc
6291 done. Redo calculations to avoid overflow.
6292 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6293
6294 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6295 subtracting pointers.
6296 (gobble_line): Check for overflow more carefully. Don't update size
6297 until alloc done.
6298
6299 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6300 Don't update size until alloc done.
6301 Redo size calculations to avoid overflow.
6302 Check for size calculation overflow.
0065d054 6303 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6304
6305 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6306 Use ptrdiff_t, not int, for sizes.
6307 (store_mode_line_noprop_char): Don't update size until alloc done.
6308
0065d054
PE
6309 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6310 Use ptrdiff_t, not int, for sizes.
6311 (Finternal_make_lisp_face, cache_face):
6312 Check for size calculation overflow.
6313 (cache_face): Treat size calculation overflows as if they were
6314 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6315
6316 * xfns.c (x_encode_text, x_set_name_internal)
6317 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6318 sizes, since they can exceed INT_MAX in size. Check for size
6319 calculation overflow.
6320
0065d054
PE
6321 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6322 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6323 Don't update size until alloc done.
6324
0065d054 6325 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6326 as sprintf is limited to int lengths.
1d526e2f 6327
252c5ee1
PE
6328 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6329 (X_LONG_MIN): New macros.
864d7ce7
PE
6330 Use them to make the following changes clearer.
6331 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6332 This change doesn't affect the value now, but it may help remind
6333 future maintainers not to raise the value too much later.
6334 (SELECTION_QUANTUM): Remove, replacing with ...
6335 (selection_quantum): ... new function, which avoids overflow.
6336 All uses changed.
6337 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6338 assumption that selection length fits in 'int'.
6339 (x_reply_selection_request, x_handle_selection_request)
6340 (x_get_window_property, receive_incremental_selection)
6341 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6342 (lisp_data_to_selection_data, clean_local_selection_data):
6343 Use ptrdiff_t, not int, to record length of selection.
6344 (x_reply_selection_request, x_get_window_property)
6345 (receive_incremental_selection, x_property_data_to_lisp):
6346 Redo calculations to avoid overflow.
6347 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6348 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6349 something.
6350 (x_get_window_property, receive_incremental_selection)
6351 (lisp_data_to_selection_data, x_property_data_to_lisp):
6352 Check for size-calculation overflow.
6353 (x_get_window_property, receive_incremental_selection)
6354 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6355 Don't store size until memory allocation succeeds.
6356 (x_get_window_property): Plug memory leak on memory exhaustion.
6357 Don't double-block input; malloc is safe here. Don't assume 2**34
6358 - 4 fits in unsigned long. Add an xassert to check
6359 XGetWindowProperty overflow. Be more careful about overflow
6360 calculations, and distinguish size from memory overflow better.
6361 (receive_incremental_selection): When tracing, don't assume
6362 unsigned int is less than INT_MAX.
6363 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6364 harmful) conversions of unsigned short to int.
6365 (lisp_data_to_selection_data): Don't assume that integers
6366 in the range -65535 through -1 fit in an X unsigned short.
6367 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6368 result parameters unless successful. Rely on cons_to_unsigned
6369 to report problems with elements; the old code wasn't right anyway.
6370 (x_check_property_data): Check for int overflow; we cannot use
6371 a wider type due to X limits.
6372 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6373
726e0ab1 6374 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6375
0065d054
PE
6376 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6377 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6378 (x_color_cells): Don't store size until memory allocation succeeds.
6379 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6380 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6381 (x_term_init): Don't assume length fits in int (sprintf is limited
6382 to int size).
bc18e09d 6383
ebfa62c0
PE
6384 Use ptrdiff_t for composition IDs.
6385 * character.c (lisp_string_width):
6386 * composite.c (composition_table_size, n_compositions)
6387 (get_composition_id, composition_gstring_from_id):
6388 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6389 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6390 * window.c (Frecenter):
6391 Use ptrdiff_t, not int, for composition IDs.
6392 * composite.c (get_composition_id): Check for integer overflow.
6393 * composite.h: Adjust prototypes to match the above changes.
6394
d3411f89
PE
6395 Use ptrdiff_t for hash table indexes.
6396 * category.c (hash_get_category_set):
6397 * ccl.c (ccl_driver):
6398 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6399 * coding.c (coding_system_charset_list, detect_coding_system):
6400 * coding.h (struct coding_system.id):
6401 * composite.c (get_composition_id, gstring_lookup_cache):
6402 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6403 * image.c (xpm_get_color_table_h):
6404 * lisp.h (hash_lookup, hash_put):
6405 * minibuf.c (Ftest_completion):
6406 Use ptrdiff_t for hash table indexes, not int (which is too
6407 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6408 32-bit --with-wide-int hosts).
6409
e097a6fa
PE
6410 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6411 Add a FIXME comment about memory leaks.
6412 (syms_of_charset): Don't assume xmalloc returns.
6413
5637687f
PE
6414 Don't assume that stated character widths fit in int.
6415 * character.c (Fchar_width, c_string_width, lisp_string_width):
6416 * character.h (CHAR_WIDTH):
6417 * indent.c (MULTIBYTE_BYTES_WIDTH):
6418 Use sanitize_char_width to avoid undefined and/or bad behavior
6419 with outlandish widths.
a66cfb1c 6420 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6421 now that we have two such functions. All uses changed.
6422 (sanitize_char_width): New inline function.
6423
a2271ba2
PE
6424 Don't assume that tab-width fits in int.
6425 * character.h (sanitize_width): New inline function.
6426 (SANE_TAB_WIDTH): New macro.
6427 (ASCII_CHAR_WIDTH): Use it.
6428 * indent.c (sane_tab_width): Remove. All uses replaced by
6429 SANE_TAB_WIDTH (current_buffer).
6430 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6431
18c52557
PE
6432 * fileio.c: Integer overflow issues with file modes.
6433 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6434
caeeedc1
PE
6435 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6436 Remove unreachable code.
6437 (read_hex, load_charset_map_from_file): Check for integer overflow.
6438
6df6ae42 6439 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6440 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6441 (x_send_scroll_bar_event): Likewise. Check that the size does not
6442 exceed limits imposed by XClientMessageEvent, as well as the usual
6443 ptrdiff_t and size_t limits.
6444
b13995db
PE
6445 * keyboard.c: Overflow, signedness and related fixes.
6446 (make_lispy_movement): Use same integer type in forward decl
6447 that is used in the definition.
6448 (read_key_sequence, keyremap_step):
6449 Change bufsize argument back to int, undoing my 2011-03-30 change.
6450 We prefer signed types, and int is wide enough here.
6451 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6452 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6453 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6454 length, not size_t. Use ptrdiff_t for index, not int.
6455 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6456 possibility of integer overflow.
6457
13464394
PE
6458 Overflow, signedness and related fixes for images.
6459
6460 * dispextern.h (struct it.stack[0].u.image.image_id)
6461 (struct_it.image_id, struct image.id, struct image_cache.size)
6462 (struct image_cache.used, struct image_cache.ref_count):
6463 * gtkutil.c (update_frame_tool_bar):
6464 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6465 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6466 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6467 * nsmenu.m (update_frame_tool_bar):
6468 * xdisp.c (calc_pixel_width_or_height):
6469 * xfns.c (image_cache_refcount):
6470 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6471 on typical 64-bit hosts.
6472
6473 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6474 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6475 Omit unnecessary casts to int.
6476 (parse_image_spec): Check that integers fall into 'int' range
6477 when the callers expect that.
6478 (image_ascent): Redo ascent calculation to avoid int overflow.
6479 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6480 (lookup_image): Remove unnecessary tests.
6481 (xbm_image_p): Locals are now of int, not EMACS_INT,
6482 since parse_image_check makes sure they fit into int.
6483 (png_load, gif_load, svg_load_image):
6484 Prefer int to unsigned where either will do.
6485 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6486 old tiff_error_handler and tiff_warning_handler.
6487 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6488 stack buffer overflows. It uses only the features of vsnprintf
6489 that are common to both POSIX and native Microsoft.
6490 (tiff_error_handler, tiff_warning_handler): Use it.
6491 (tiff_load, gif_load, imagemagick_load_image):
6492 Don't assume :index value fits in 'int'.
6493 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6494 (imagemagick_load_image): Check that crop parameters fit into
6495 the integer types that MagickCropImage accepts. Don't assume
6496 Vimagemagick_render_type has a nonnegative value. Don't assume
6497 size_t fits in 'long'.
6498 (gs_load): Use printmax_t to print the widest integers possible.
6499 Check for integer overflow when computing image height and width.
6500
c11821d4
EZ
65012011-08-26 Eli Zaretskii <eliz@gnu.org>
6502
6503 * xdisp.c (redisplay_window): Don't force window start if point
6504 will be invisible in the resulting window. (Bug#9324)
6505
0c95fcf7
EZ
65062011-08-25 Eli Zaretskii <eliz@gnu.org>
6507
6508 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6509 the display spec is of the form `(space ...)'.
6510 (handle_display_spec): Return the value returned by
6511 handle_single_display_spec, not just 1 or zero.
6512 (handle_single_display_spec): If the display spec is of the form
6513 `(space ...)', and specifies display in the text area, return 2
6514 rather than 1.
fee65a97 6515 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6516 accurately, and prefer exact match for point under bidi.
6517 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6518
6519 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6520 into disp_prop; all users changed.
6521
6522 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6523 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6524 for the text covered by the display property.
6525
e4ed06f1
CY
65262011-08-25 Chong Yidong <cyd@stupidchicken.com>
6527
6528 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6529 Change return value to nil.
6530 (Frecord_buffer): Delete unused function.
6531
f67cdd7f
EZ
65322011-08-24 Eli Zaretskii <eliz@gnu.org>
6533
5980d4c6
EZ
6534 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6535 buffers, return left-to-right.
8610fe8b
EZ
6536 (set_cursor_from_row): Consider candidate row a win if its glyph
6537 represents a newline and point is on that newline. Fixes cursor
6538 positioning on the newline at EOL of R2L text within L2R
6539 paragraph, and vice versa.
6540 (try_cursor_movement): Check continued rows, in addition to
6541 continuation rows. Fixes unwarranted scroll when point enters a
6542 continued line of R2L text within an L2R paragraph, or vice versa.
6543 (cursor_row_p): Consider the case of point being equal to
6544 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6545 from the end of a short line to the beginning of a continued line
6546 of R2L text within L2R paragraph.
6547 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6548 composed characters.
5980d4c6 6549
f67cdd7f
EZ
6550 * bidi.c (bidi_check_type): Use xassert.
6551 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6552 members.
6553
bca633fb
EZ
65542011-08-23 Eli Zaretskii <eliz@gnu.org>
6555
6556 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6557 a character.
6558
4a5885a7
CY
65592011-08-23 Chong Yidong <cyd@stupidchicken.com>
6560
6561 * nsfont.m (ns_otf_to_script): Fix typo.
6562
0902a04e
KH
65632011-08-22 Kenichi Handa <handa@m17n.org>
6564
6565 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6566 extra slot even if the purpose is char-code-property-table.
6567
1a2e6670
EZ
65682011-08-23 Eli Zaretskii <eliz@gnu.org>
6569
8ddde651
EZ
6570 * xdisp.c (redisplay_window): When computing centering_position,
6571 account for the height of the header line. (Bug#8874)
6572
425cc014
EZ
6573 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6574 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6575 candidate is selected by the mouse, and that candidate has a
6576 composed character under the mouse.
6577
1a2e6670
EZ
6578 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6579 coordinates reported by pos-visible-in-window-p for a composed
6580 character in column zero.
6581
8b76d6f8
SM
65822011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6583
6584 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6585
dac347dd
EZ
65862011-08-22 Eli Zaretskii <eliz@gnu.org>
6587
6588 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6589 consider it a hit if to_charpos is anywhere in the range of the
6590 composed buffer positions.
6591
e013fb34
CY
65922011-08-22 Chong Yidong <cyd@stupidchicken.com>
6593
6594 * image.c (gif_load): Don't assume that each subimage has the same
6595 dimensions as the base image. Handle disposal method that is
6596 "undefined" by the gif spec (Bug#9335).
6597
bd1ba3e8
CY
65982011-08-20 Chong Yidong <cyd@stupidchicken.com>
6599
6600 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6601 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6602
54a1215b
EZ
66032011-08-19 Eli Zaretskii <eliz@gnu.org>
6604
823564e5
EZ
6605 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6606 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6607 from an Org mode buffer to a Speedbar frame.
6608
54a1215b
EZ
6609 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6610 a composition, take its buffer position from IT->cmp_it.charpos.
6611 Fixes cursor positioning at the beginning of a line that begins
6612 with a composed character.
6613
9778ebcc
EZ
66142011-08-18 Eli Zaretskii <eliz@gnu.org>
6615
0be6ee06
EZ
6616 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6617 character bidirectional type, use STRONG_L instead. Fixes crashes
6618 in a buffer produced by `describe-categories'.
6619
9778ebcc
EZ
6620 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6621 members before the level stack, so they would be saved and
6622 restored when copying iterator state. Fixes incorrect reordering
6623 around TABs covered by display properties.
6624
156bffbe
AS
66252011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6626
6b02f655 6627 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6628
72ad093b
CY
66292011-08-17 Chong Yidong <cyd@stupidchicken.com>
6630
6631 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6632 (internal_condition_case_2, internal_condition_case_n):
6633 Remove unnecessary aborts (Bug#9081).
72ad093b 6634
35774242
EZ
66352011-08-17 Eli Zaretskii <eliz@gnu.org>
6636
6637 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6638 has no `load' handler, try opening the file locally. (Bug#9311)
6639
db76dd85
KB
66402011-08-16 Ken Brown <kbrown@cornell.edu>
6641
6642 * gmalloc.c: Expand comment.
6643
b215eee5
EZ
66442011-08-16 Eli Zaretskii <eliz@gnu.org>
6645
6646 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6647 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6648
a4579d33
KB
66492011-08-16 Ken Brown <kbrown@cornell.edu>
6650
6651 Fix memory allocation problems in Cygwin build (Bug#9273).
6652
6653 * unexcw.c ( __malloc_initialized): Declare external variable.
6654 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6655
8b76d6f8
SM
6656 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6657 New variables.
a4579d33
KB
6658 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6659 dumped emacs.
6660 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6661 in the static heap.
6662 [CYGWIN] (special_realloc): New function.
6663 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6664 requests to realloc storage in the static heap.
6665
3ebec551
PE
66662011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * bidi.c (bidi_initialize): Remove unused local.
6669
9fd8be00
EZ
66702011-08-15 Eli Zaretskii <eliz@gnu.org>
6671
6b02f655
SM
6672 * bidimirror.h:
6673 * biditype.h: Remove file.
6674 * makefile.w32-in ($(BLD)/bidi.$(O)):
6675 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6676
6677 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6678
6679 * chartab.c: Improve commentary for the uniprop_table API.
6680
32413314
EZ
6681 * bidi.c (bidi_paragraph_init): Support zero value of
6682 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6683 (bidi_initialize): Use uniprop_table instead of including
6684 biditype.h and bidimirror.h.
32413314 6685
9fd8be00
EZ
6686 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6687 coordinates of the iterator when restoring from ppos_it.
6688 (Bug#9296)
6689
5cf2b69b
KH
66902011-08-14 Kenichi Handa <handa@m17n.org>
6691
6692 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6693 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6694
daf17d00
EZ
66952011-08-14 Eli Zaretskii <eliz@gnu.org>
6696
6697 * xdisp.c (move_it_in_display_line_to): Don't invoke
6698 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6699 ppos_it. Fixes vertical cursor motion when line beginning is
6700 covered by an image. (Bug#9296)
6701
08e3161a
JD
67022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6703
6704 * nsterm.h (ns_run_ascript): Declare.
6705 (NSAPP_DATA2_RUNASSCRIPT): Define.
6706
6707 * nsfns.m (as_script, as_result, as_status): New static variables.
6708 (ns_run_ascript): New function.
5e617bc2 6709 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6710 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6711 the event loop. Get status from as_status (Bug#7276).
6712
6713 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6714 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6715 the event loop (Bug#7276).
6716
a3720aa2
AS
67172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6718
6719 * gnutls.c (QCgnutls_bootprop_priority)
6720 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6721 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6722 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6723 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6724 (QCgnutls_bootprop_verify_hostname_error)
6725 (QCgnutls_bootprop_callbacks_verify): Rename from
6726 Qgnutls_bootprop_..., all uses changed.
6727
6728 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6729 uses changed.
6730
0a0d27fb
PE
67312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6732
19d5c50c
PE
6733 * xfaces.c (Qframe_set_background_mode): Now static.
6734 * dispextern.h (Qframe_set_background_mode): Remove decl.
6735
0a0d27fb
PE
6736 * process.c (Fnetwork_interface_info): Declare local only if needed.
6737
377538cb
JD
67382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6739
6740 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6741 (Fnetwork_interface_list): Allocate in increments of bytes instead
6742 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6743 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6744 sockaddr.
6745 (struct ifflag_def): notrailers is smart on OSX.
6746 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6747 Get hardware address with getifaddrs if available.
6748
08fff70c
EZ
67492011-08-12 Eli Zaretskii <eliz@gnu.org>
6750
6751 * xdisp.c (iterate_out_of_display_property): xassert that
6752 IT->position is set to within IT->object's boundaries. Break from
6753 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6754 when IT->position is set up wrongly due to some bug.
6755 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6756 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6757 entry. Force push_it to save on the stack the current
6758 buffer/string position, to be restored by pop_it. Fix flags in
6759 the iterator structure wrt the object coming from a display
6760 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6761 properties. (Bug#9284)
6762
7be1c708 67632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6764
7be1c708
CY
6765 * fontset.c (fontset_get_font_group): Add proper type checks.
6766 (Bug#9172)
aac0c6e3 6767
7be1c708 67682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6769
7be1c708
CY
6770 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6771 and LC_VERSION_MIN_MACOSX.
6772 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6773 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6774
97bb72a6
EZ
67752011-08-08 Eli Zaretskii <eliz@gnu.org>
6776
6777 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6778 no-display-properties-and-no-overlays under bidi display.
6779 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6780 properties and overlays.
97bb72a6 6781
d5617611
CY
67822011-08-08 Chong Yidong <cyd@stupidchicken.com>
6783
37e11a63
CY
6784 * editfns.c (Fset_time_zone_rule): Document relationship with the
6785 setenv function.
6786
d5617611
CY
6787 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6788 the font entity extracted from the cache (Bug#8109).
6789
58872834
CY
67902011-08-07 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * composite.c (autocmp_chars): Don't reset point. That is done by
6793 restore_point_unwind (Bug#5984).
6794
75bfc667
JL
67952011-08-07 Juri Linkov <juri@jurta.org>
6796
6797 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6798 to show the arg `TIME' instead of `TIMEVAL'.
6799
d1410150
EZ
68002011-08-06 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6803 display property strides EOL and includes a newline, as in
6804 longlines-mode. (Bug#9254)
75b771e4
EZ
6805 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6806 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6807
6808 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6809 is non-zero, even if the data buffer is NULL. Fixes a crash in
6810 vertical-motion with longlines-mode. (Bug#9254)
6811
35928349
EZ
68122011-08-05 Eli Zaretskii <eliz@gnu.org>
6813
ec7cc85b
EZ
6814 * bidi.c <bidi_cache_total_alloc>: Now static.
6815 (bidi_initialize): Initialize bidi_cache_total_alloc.
6816
8b76d6f8 6817 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6818 cache. (Bug#9221)
6819
6820 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6821 amount allocated this far in `bidi_cache_total_alloc'.
6822 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6823 non-zero, only free the data buffer without restoring the cache
6824 contents. All callers changed.
6825
6826 * dispextern.h (bidi_unshelve_cache): Update prototype.
6827
6828 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6829 (move_it_in_display_line, move_it_to)
6830 (move_it_vertically_backward, move_it_by_lines): Replace the call
6831 to xfree to an equivalent call to bidi_unshelve_cache.
6832 (move_it_in_display_line_to): Fix logic of returning
412b6358 6833 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6834
e2e2423b
EZ
68352011-08-05 Eli Zaretskii <eliz@gnu.org>
6836
6837 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6838 came from a string character with a `cursor' property. (Bug#9229)
6839
ae9e757a
JD
68402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6841
6842 * Makefile.in (LIB_PTHREAD): New variable.
6843 (LIBES): Add LIB_PTHREAD (Bug#9216).
6844
6845 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6846 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6847
213bd7f2
AS
68482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6849
6b02f655 6850 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6851
99aaf75f
JD
68522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6853
6854 * xterm.c (x_find_topmost_parent): New function.
6855 (x_set_frame_alpha): Find topmost parent window with
6856 x_find_topmost_parent and set the property there also (bug#9181).
6857 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6858
c74e9d86
PE
68592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6860
6861 * callproc.c (Fcall_process): Avoid vfork clobbering
6862 the local vars buffer, coding_systems, current_dir.
6863
640c8776
SM
68642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6865
6866 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6867
f26d0e4c
PE
68682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6869
8a10d76c
PE
6870 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6871 so that it is not optimized away.
6872
f26d0e4c
PE
6873 * xdisp.c (compute_display_string_pos): Remove unused local.
6874
55439c61
EZ
68752011-08-02 Eli Zaretskii <eliz@gnu.org>
6876
6877 Fix slow cursor motion and scrolling in large buffers with
6878 selective display, like Org Mode buffers. (Bug#9218)
6879
6880 * dispextern.h (struct bidi_it): New member disp_prop_p.
6881
6882 * xdisp.c: Remove one-slot cache of display string positions.
6883 (compute_display_string_pos): Accept an additional argument
5e617bc2 6884 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6885 for a display string or property. If found, set DISP_PROP_P
6886 non-zero.
6887
6888 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6889 DISP_PROP_P, and pass it to compute_display_string_pos.
6890 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6891 non-zero. All callers of bidi_fetch_char changed.
6892
fb33fa43
SM
68932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6894
6895 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6896
b099e063
DM
68972010-12-03 Don March <don@ohspite.net>
6898
6899 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6900 last character M-[char] is translated to ESC [char] (bug#7541).
6901
5cc7f7af
KH
69022011-08-02 Kenichi Handa <handa@m17n.org>
6903
d0fffa3f 6904 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6905
6906 * chartab.c (uniprop_table): Make it non-static.
6907
525d5e6e
EZ
69082011-08-01 Eli Zaretskii <eliz@gnu.org>
6909
6910 * xdisp.c (forward_to_next_line_start): Accept additional argument
6911 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6912 on the newline.
6913 (reseat_at_next_visible_line_start): Use the bidi iterator state
6914 returned by forward_to_next_line_start to restore the state of
6915 it->bidi_it after backing up to previous newline. (Bug#9212)
6916
31011111
AS
69172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6918
6919 * regex.c (re_comp): Protoize.
6920 (re_exec): Fix return type.
6921 (regexec): Fix type of `ret'. (Bug#9203)
6922
476371c4
PE
69232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6924
e5d76069
PE
6925 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6926 This is needed if max-image-size is a floating-point number.
6927
9a79b20c
AS
69282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6929
6930 * print.c (print_object): Print empty symbol as ##.
6931
6932 * lread.c (read1): Read ## as empty symbol.
6933
d8c2fa78
AA
69342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6935
6936 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6937 setting frame foreground color (Bug#9175).
6938 (x_set_background_color): Likewise.
6939
ffe57a7a
AA
6940 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6941 contents (Bug#9176).
6942 (EmacsTooltip -init): Remove bezels and add shadows to
6943 tooltip windows.
6944
bf3492a5
AA
6945 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6946 or scroll bar (Bug#8470).
6947
d55e9c53
AA
6948 * nsfont.m (nsfont_open): Remove assignment to voffset and
6949 unnecessary vars hshink, expand, hd, full_height, min_height.
6950 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6951
6952 * nsterm.h (nsfont_info): Remove voffset field.
6953
d8c2fa78 69542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6955
6956 Implement strike-through and overline on NextStep (Bug#8863).
6957
6958 * nsfont.m (nsfont_open): Use underline position provided by font,
6959 instead of hard-coded value of 2.
6960 (nsfont_draw): Call ns_draw_text_decoration instead.
6961
6962 * nsterm.h: Add declaration for ns_draw_text_decoration.
6963
6964 * nsterm.m (ns_draw_text_decoration): New function for drawing
6965 underline, overline, and strike-through.
6966 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6967 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6968 accommodate underlining, etc.
4843aac3 6969
4cc60b9b
EZ
69702011-07-28 Eli Zaretskii <eliz@gnu.org>
6971
bc7ece87
EZ
6972 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6973 default.
4cc60b9b 6974
476371c4
PE
69752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6976
66606eea
PE
6977 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6978 Without this fix, if a signal arrives just after memory fills up,
6979 'malloc' might be invoked reentrantly.
6980
476371c4
PE
6981 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6982 In other words, assume that every image size is allowed, on non-X
6983 hosts. This assumption is probably wrong, but it lets Emacs compile.
6984
f3fcc40d
AS
69852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6986
6987 * regex.c (re_iswctype): Convert return values to boolean.
6988
350c992f
EZ
69892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6990
6991 * xdisp.c (compute_display_string_pos): Don't use cached display
6992 string position if the buffer had its restriction changed.
6993 (Bug#9184)
6994
5266b4bb
PE
69952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6996
6997 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6998
2573a837 69992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7000
41f55ccd 7001 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7002
39e378da
PE
7003 * bidi.c: Integer size and overflow fixes.
7004 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7005 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7006 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7007 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7008 (bidi_find_other_level_edge):
7009 Use ptrdiff_t instead of EMACS_INT where either will do.
7010 This works better on 32-bit hosts configured --with-wide-int.
7011 (bidi_cache_ensure_space): Check for size-calculation overflow.
7012 Use % rather than repeated addition, for better worst-case speed.
7013 Don't set bidi_cache_size until after xrealloc returns, because it
7014 might not return.
7015 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7016 (bidi_cache_ensure_space): Also check that the bidi cache size
7017 does not exceed that of the largest Lisp string or buffer. See Eli
7018 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7019
5e927815
PE
7020 * alloc.c (__malloc_size_t): Remove.
7021 All uses replaced by size_t. See Andreas Schwab's note
7022 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7023
ca4aa935
PE
7024 * image.c: Improve checking for integer overflow.
7025 (check_image_size): Assume that f is nonnull, since
7026 it is always nonnull in practice. This is one less thing to
7027 worry about when checking for integer overflow later.
7028 (x_check_image_size): New function, which checks for integer
7029 overflow issues inside X.
7030 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7031 This removes the need for a memory_full check.
7032 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7033 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7034 (xbm_read_bitmap_data): Change locals back to 'int', since
7035 their values must fit in 'int'.
7036 (xpm_load_image, png_load, tiff_load):
7037 Invoke x_create_x_image_and_pixmap earlier,
7038 to avoid much needless work if the image is too large.
7039 (tiff_load): Treat overly large images as if
7040 x_create_x_image_and_pixmap failed, not as malloc failures.
7041 (gs_load): Use x_check_image_size.
7042
5f8f9cc2
PE
7043 * gtkutil.c: Omit integer casts.
7044 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7045 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7046
5adf60bc
PE
7047 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7048
c8907a93
PE
7049 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7050 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7051 would wrongly return t on a 64-bit host.
7052
e3c25c68
PE
7053 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7054 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7055 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7056 and therefore cause GCC to emit a bogus diagnostic in some cases.
7057
3f791afe
PE
7058 * image.c: Integer signedness and overflow and related fixes.
7059 This is not an exhaustive set of fixes, but it's time to
7060 record what I've got.
7061 (lookup_pixel_color, check_image_size): Remove redundant decls.
7062 (check_image_size): Don't assume that arbitrary EMACS_INT values
7063 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7064 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7065 (tiff_load, imagemagick_load_image):
7066 Check for overflow in size calculations.
7067 (x_create_x_image_and_pixmap): Remove unnecessary test for
7068 xmalloc returning NULL; that can't happen.
7069 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7070 (xpm_color_bucket): Use better integer hashing function.
7071 (xpm_cache_color): Don't possibly over-allocate memory.
7072 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7073 (gif_memory_source):
7074 Use ptrdiff_t, not int or size_t, to record sizes.
7075 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7076 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7077 either works, as we prefer signed integers.
7078 (tiff_read_from_memory, tiff_write_from_memory):
7079 Return tsize_t, not size_t, since that's what the TIFF API wants.
7080 (tiff_read_from_memory): Don't fail simply because the read would
7081 go past EOF; instead, return a short read.
7082 (tiff_load): Omit no-longer-needed casts.
7083 (Fimagemagick_types): Don't assume size fits into 'int'.
7084
3cc5a532
PE
7085 Improve hashing quality when configured --with-wide-int.
7086 * fns.c (hash_string): New function, taken from sxhash_string.
7087 Do not discard information about ASCII character case; this
7088 discarding is no longer needed.
7089 (sxhash-string): Use it. Change sig to match it. Caller changed.
7090 * lisp.h: Declare it.
7091 * lread.c (hash_string): Remove, since we now use fns.c's version.
7092 The fns.c version returns a wider integer if --with-wide-int is
7093 specified, so this should help the quality of the hashing a bit.
7094
b312a492
PE
7095 * emacs.c: Integer overflow minor fix.
7096 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7097 Define only if GNU_LINUX.
7098 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7099
dfd153ae
PE
7100 * dispnew.c: Integer signedness and overflow fixes.
7101 Remove unnecessary forward decls, that were a maintenance hassle.
7102 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7103 All uses changed.
7104 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7105 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7106 (prepare_desired_row, line_draw_cost):
7107 Use int, not unsigned, where either works.
7108 (save_current_matrix, restore_current_matrix):
7109 Use ptrdiff_t, not size_t, where either works.
7110 (init_display): Check for overflow more accurately, and without
7111 relying on undefined behavior.
7112
a81d11a3
PE
7113 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7114 Remove, replacing with the new symbols in lisp.h. All uses changed.
7115 * fileio.c (make_temp_name):
7116 * filelock.c (lock_file_1, lock_file):
7117 * xdisp.c (message_dolog):
7118 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7119 Use pMd etc. instead.
7120 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7121 replacing the pWIDE etc. symbols removed from editfns.c.
7122
3300e6fd
PE
7123 * keyboard.h (num_input_events): Now uintmax_t.
7124 This is (very slightly) less likely to mess up due to wraparound.
7125 All uses changed.
7126
fd05c7e9
PE
7127 * buffer.c: Integer signedness fixes.
7128 (alloc_buffer_text, enlarge_buffer_text):
7129 Use ptrdiff_t rather than size_t when either will do, as we prefer
7130 signed integers.
7131
903fe15d
PE
7132 * alloc.c: Integer signedness and overflow fixes.
7133 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7134 (__malloc_size_t): Default to size_t, not to int.
7135 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7136 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7137 Prefer ptrdiff_t to size_t when either would do, as we prefer
7138 signed integers.
7139 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7140 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7141 Now const. Initialize with values that are in range even if char
7142 is signed.
7143 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7144 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7145 These functions do the right thing with sizes > 2**32.
7146 (check_depth): Now ptrdiff_t, not int.
7147 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7148 Adjust to new way of storing sizes. Check for size overflow bugs
7149 in rest of code.
7150 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7151 slightly wrong anyway, as it missed one instance of
7152 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7153 (refill_memory_reserve): Omit needless cast to size_t.
7154 (mark_object_loop_halt): Mark as externally visible.
7155
ac82cc6a
PE
7156 * xselect.c: Integer signedness and overflow fixes.
7157 (Fx_register_dnd_atom, x_handle_dnd_message):
7158 Use ptrdiff_t, not size_t, since we prefer signed.
7159 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7160 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7161 x_dnd_atoms_size and x_dnd_atoms_length.
7162
c2d1e36d
PE
7163 * doprnt.c: Prefer signed to unsigned when either works.
7164 * eval.c (verror):
7165 * doprnt.c (doprnt):
7166 * lisp.h (doprnt):
7167 * xdisp.c (vmessage):
7168 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7169 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7170 prefer signed arithmetic to avoid comparison confusion.
7171 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7172 but is a bit tricky.
7173
0e926e56
PE
7174 Assume freestanding C89 headers, string.h, stdlib.h.
7175 * data.c, doprnt.c, floatfns.c, print.c:
7176 Include float.h unconditionally.
7177 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7178 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7179 * regex.c: Likewise for stddef.h, string.h.
7180 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7181 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7182 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7183 (STDC_HEADERS): Remove obsolete defines.
7184 * sysdep.c: Include limits.h unconditionally.
7185
9cfdb3ec
PE
7186 Assume support for memcmp, memcpy, memmove, memset.
7187 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7188 * regex.c (memcmp, memcpy):
7189 Remove; we assume C89 now.
7190
7191 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7192 (__malloc_safe_bcopy): Remove; no longer needed.
7193
cf950e6b 7194 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7195 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7196 well either way, and we prefer signed to unsigned.
7197
dbf38e02
LMI
71982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7199
7200 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7201 closes the connection while we're reading (bug#9182).
7202
d6f0886c 72032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7204
d6f0886c
JD
7205 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7206 are specified (Bug#9168).
24e0f6b1 7207
2eb1f9e6
PE
72082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7209
7210 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7211 Found by GCC static checking and --with-wide-int on a 32-bit host.
7212
22381272 72132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7214
7215 * xdisp.c (compute_display_string_pos): Fix logic of caching
7216 previous display string position. Initialize cached_prev_pos to
7217 -1. Fixes slow-down at the beginning of a buffer.
7218
f25e39b4
EZ
72192011-07-24 Eli Zaretskii <eliz@gnu.org>
7220
7221 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7222 for attrs[LFACE_FONTSET_INDEX].
7223
04c4b52e
PE
72242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7225
7226 * xml.c (parse_region): Remove unused local
7227 that was recently introduced.
7228
c1734fbd
EZ
72292011-07-23 Eli Zaretskii <eliz@gnu.org>
7230
be18c5a5
EZ
7231 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7232 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7233
c1734fbd
EZ
7234 * xdisp.c (move_it_in_display_line_to): Record the best matching
7235 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7236 exit if none of the characters scanned was an exact match.
7237 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7238 when exact match is impossible due to invisible text, and the
7239 lines are truncated.
7240
a258d627
JD
72412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7242
7243 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7244 for OSX >= 10.7.
7245
b6d5a689
EZ
72462011-07-22 Eli Zaretskii <eliz@gnu.org>
7247
0f74f785
EZ
7248 Fix a significant slow-down of cursor motion with C-n, C-p,
7249 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7250 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7251 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7252 (next_element_from_buffer): Call compute_stop_pos_backwards to
7253 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7254 base_level_stop.
7255 (reseat): Don't look for prev_stop, as that could mean a very long
7256 run.
7257 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7258 <cached_disp_overlay_modiff>: Cache for last found display string
7259 position.
551918c1 7260 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7261 about the same buffer in the same area of character positions, and
7262 the buffer wasn't changed since the time the display string
7263 position was cached.
551918c1 7264
b2d0c91a
EZ
72652011-07-22 Eli Zaretskii <eliz@gnu.org>
7266
7267 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7268 is an integer, which is important for empty lines. (Bug#9149)
7269
043604ee
CY
72702011-07-22 Chong Yidong <cyd@stupidchicken.com>
7271
7272 * frame.c (Fmodify_frame_parameters): In tty case, update the
7273 default face if necessary (Bug#4238).
7274
da4adb04
CY
72752011-07-21 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * editfns.c (Fstring_to_char): No need to explain what a character
7278 is in the docstring (Bug#6576).
7279
9abd0532
LMI
72802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7281
7282 * xml.c (parse_region): Make sure we always return a tree.
7283
36881d16
HK
72842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7285
7286 * xml.c (parse_region): If a document contains only comments,
7287 return that, too.
7288
1e98674d
LMI
72892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7290
7291 * xml.c (make_dom): Return comments, too.
7292
590bd467
PE
72932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7294
7295 Port to OpenBSD.
7296 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7297 and the surrounding thread.
7298 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7299 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7300 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7301 timer goes off.
7302 * s/openbsd.h (BROKEN_SIGIO): Define.
7303 * unexelf.c (unexec) [__OpenBSD__]:
7304 Don't update the .mdebug section of the Alpha COFF symbol table.
7305
f41628b2
LMI
73062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7307
7308 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7309 (bug#8460).
7310
b59b67c5
PE
73112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7312
15e3a074
PE
7313 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7314 This fixes some race conditions on the permissions of any newly
7315 created file.
7316
41bed37d
PE
7317 * alloc.c (valid_pointer_p): Use pipe, not open.
7318 This fixes some permissions issues when debugging.
7319
b59b67c5
PE
7320 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7321 If fchown fails to set both uid and gid, try to set just gid,
7322 as that is sometimes allowed. Adjust the file's mode to eliminate
7323 setuid or setgid bits that are inappropriate if fchown fails.
7324
925a6be7
SM
73252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7326
7327 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7328 to compare Lisp_Objects.
7329 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7330 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7331 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7332
52968808
AS
73332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7334
0a6a104b
AS
7335 * lread.c (read_integer): Unread even EOF character.
7336 (read1): Likewise. Properly record start position of symbol.
7337
52968808
AS
7338 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7339 symbol character follows.
7340
9e381cdd
PE
73412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7342
7343 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7344 This works around a problem with the previous change to Fcopy_file.
7345 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7346 and without this change, GCC might complain about discarding
7347 fchown's return value.
7348
b5641435
JB
73492011-07-16 Juanma Barranquero <lekktu@gmail.com>
7350
7351 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7352
a8031457
PE
73532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7354
7355 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7356
dd889327
LMI
73572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7358
750c33f7
LMI
7359 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7360 it's used from the C level.
7361
dd889327
LMI
7362 * process.c: Use the same condition for POLL_FOR_INPUT in both
7363 keyboard.c and process.c (bug#1858).
7364
87e86684
LM
73652011-07-09 Lawrence Mitchell <wence@gmx.li>
7366
7367 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7368 (Fgnutls_boot): Use it.
7369
64348f40
AS
73702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7371
7372 * doc.c (Fsubstitute_command_keys): Revert last change.
7373
1d698799
LMI
73742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7375
f863868c
LMI
7376 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7377 quotes the next character, and doesn't affect other longer
7378 sequences (bug#8935).
7379
1d698799
LMI
7380 * lread.c (syms_of_lread): Clarify that is isn't only
7381 `eval-buffer' and `eval-defun' that's affected by
7382 `lexical-binding' (bug#8460).
7383
aa4b6df6
EZ
73842011-07-15 Eli Zaretskii <eliz@gnu.org>
7385
7386 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7387 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7388
5d856da6
PE
73892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7390
ad6042bb
PE
7391 Fix minor problems found by static checking.
7392 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7393 (elsz): Now a signed constant, not a size_t var. We prefer signed
7394 types to unsigned, to avoid integer comparison confusion. Without
7395 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7396 "cannot optimize loop, the loop counter may overflow", a symptom
7397 of the confusion.
f00bbb22 7398 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7399 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7400
6468f31c
LMI
74012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7402
49080b10
LMI
7403 * search.c (Fre_search_backward): Mention `case-fold-search' in
7404 all the re_search_* functions (bug#8138).
7405
6468f31c
LMI
7406 * keyboard.c (Fopen_dribble_file): Document when the file is
7407 closed (bug#8056).
7408
c965adc5
EZ
74092011-07-14 Eli Zaretskii <eliz@gnu.org>
7410
df9733bf
EZ
7411 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7412 bidi_cache_idx.
7413
0bb23927
EZ
7414 Support bidi reordering of display and overlay strings.
7415 * xdisp.c (compute_display_string_pos)
7416 (compute_display_string_end): Accept additional argument STRING.
7417 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7418 (reseat_to_string): Initialize bidi_it->string.s and
7419 bidi_it->string.schars.
7420 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7421 NULL (avoids a crash in bidi_paragraph_init).
7422 Initialize itb.string.lstring.
0bb23927
EZ
7423 (init_iterator): Call bidi_init_it only of a valid
7424 buffer position was specified. Initialize paragraph_embedding to
7425 L2R.
7426 (reseat_to_string): Initialize the bidi iterator.
7427 (display_string): If we need to ignore text properties of
7428 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7429 original value of -1 will not work with bidi.)
7430 (compute_display_string_pos): First arg is now struct
7431 `text_pos *'; all callers changed. Support display properties on
7432 Lisp strings.
7433 (compute_display_string_end): Support display properties on Lisp
7434 strings.
7435 (init_iterator, reseat_1, reseat_to_string): Initialize the
7436 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7437 when iterating on a string not from display properties).
640c8776
SM
7438 (compute_display_string_pos, compute_display_string_end):
7439 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7440 arrow keys.
7441 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7442 base_level_stop; instead, set base_level_stop to BEGV.
7443 Fixes crashes in vertical-motion.
0bb23927
EZ
7444 (next_element_from_buffer): Improve commentary for when
7445 the iterator is before prev_stop.
7446 (init_iterator): Initialize bidi_p from the default value of
7447 bidi-display-reordering, not from buffer-local value. Use the
7448 buffer-local value only if initializing for buffer iteration.
7449 (handle_invisible_prop): Support invisible properties on strings
7450 that are being bidi-reordered.
7451 (set_iterator_to_next): Support bidi reordering of C strings and
7452 Lisp strings.
7453 (next_element_from_string): Support bidi reordering of Lisp
7454 strings.
7455 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7456 (display_string): Support display of R2L glyph rows.
7457 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7458 (init_iterator): Don't initialize it->bidi_p for strings
7459 here.
7460 (reseat_to_string): Initialize it->bidi_p for strings here.
7461 (next_element_from_string, next_element_from_c_string)
7462 (next_element_from_buffer): Add xassert's for correspondence
7463 between IT's object being iterated and it->bidi_it.string
7464 structure.
7465 (face_before_or_after_it_pos): Support bidi iteration.
7466 (next_element_from_c_string): Handle the case of the first string
7467 character that is not the first one in the visual order.
7468 (get_visually_first_element): New function, refactored from common
7469 parts of next_element_from_buffer, next_element_from_string, and
7470 next_element_from_c_string.
7471 (tool_bar_lines_needed, redisplay_tool_bar)
7472 (display_menu_bar): Force left-to-right direction. Add a FIXME
7473 comment for making that be controlled by a user option.
7474 (push_it, pop_it): Save and restore the state of the
7475 bidi iterator. Save and restore the bidi_p flag.
7476 (pop_it): Iterate out of display property for string iteration as
7477 well.
7478 (iterate_out_of_display_property): Support iteration over strings.
7479 (handle_single_display_spec): Set up it->bidi_it for iteration
7480 over a display string, and call bidi_init_it.
7481 (handle_single_display_spec, next_overlay_string)
7482 (get_overlay_strings_1, push_display_prop): Set up the bidi
7483 iterator for displaying display or overlay strings.
7484 (forward_to_next_line_start): Don't use the shortcut if
7485 bidi-iterating.
7486 (back_to_previous_visible_line_start): If handle_display_prop
7487 pushed the iterator stack, restore the internal state of the bidi
7488 iterator by calling bidi_pop_it same number of times.
7489 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7490 and we are bidi-iterating, don't decrement the iterator position;
7491 instead, set the first_elt flag in the bidi iterator, to produce
7492 the same effect.
7493 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7494 (push_display_prop): xassert that we are iterating a buffer.
7495 (push_it, pop_it): Save and restore paragraph_embedding member.
7496 (handle_single_display_spec, next_overlay_string)
7497 (get_overlay_strings_1, reseat_1, reseat_to_string)
7498 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7499 correctly. Don't assume unibyte strings are not bidi-reordered.
7500 (compute_display_string_pos)
7501 (compute_display_string_end): Fix handling the case of C string.
7502 (push_it, pop_it): Save and restore from_disp_prop_p.
7503 (handle_single_display_spec, push_display_prop): Set the
7504 from_disp_prop_p flag.
7505 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7506 (pop_it): Call iterate_out_of_display_property only if we are
7507 popping after iteration over a string that came from a display
7508 property. Fix a typo in popping stretch info. Add an assertion
7509 for verifying that the iterator position is in sync with the bidi
7510 iterator.
7511 (handle_single_display_spec, get_overlay_strings_1)
7512 (push_display_prop): Fix initialization of paragraph direction for
7513 string when that of the parent object is not yet determined.
7514 (reseat_1): Call bidi_init_it to resync the bidi
7515 iterator with IT's position. (Bug#7616)
7516 (find_row_edges): If ROW->start.pos gives position
7517 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7518 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7519 Reset the from_disp_prop_p flag.
7520 (SAVE_IT, RESTORE_IT): New macros.
7521 (pos_visible_p, face_before_or_after_it_pos)
7522 (back_to_previous_visible_line_start)
7523 (move_it_in_display_line_to, move_it_in_display_line)
7524 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7525 (try_scrolling, redisplay_window, display_line): Use them when
7526 saving a temporary copy of the iterator and restoring it back.
7527 (back_to_previous_visible_line_start, reseat_1)
7528 (init_iterator): Empty the bidi cache "stack".
7529 (move_it_in_display_line_to): If iterator ended up at
7530 EOL, but we never saw any buffer positions smaller than
7531 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7532 motion in bidi-reordered lines.
7533 (move_it_in_display_line_to): Record prev_method and prev_pos
7534 immediately before the call to set_iterator_to_next. Fixes cursor
7535 motion in bidi-reordered lines with stretch glyphs and strings
7536 displayed in margins. (Bug#8133) (Bug#8867)
7537 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7538 TO_CHARPOS.
640c8776
SM
7539 (pos_visible_p): Support positions in bidi-reordered lines.
7540 Save and restore bidi cache.
0bb23927
EZ
7541
7542 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7543 (bidi_paragraph_info): Delete unused struct.
7544 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7545 (bidi_cache_start): New variable.
7546 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7547 to zero.
7548 (bidi_cache_fetch_state, bidi_cache_search)
7549 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7550 (bidi_cache_find, bidi_peek_at_next_level)
7551 (bidi_level_of_next_char, bidi_find_other_level_edge)
7552 (bidi_move_to_visually_next): Compare cache index with
7553 bidi_cache_start rather than with zero.
7554 (bidi_fetch_char): Accept new argument STRING; all callers
7555 changed. Support iteration over a string. Support strings with
7556 display properties. Support unibyte strings. Fix the type of
7557 `len' according to what STRING_CHAR_AND_LENGTH expects.
7558 (bidi_paragraph_init, bidi_resolve_explicit_1)
7559 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7560 (bidi_level_of_next_char, bidi_move_to_visually_next):
7561 Support iteration over a string.
0bb23927
EZ
7562 (bidi_set_sor_type, bidi_resolve_explicit_1)
7563 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7564 can now be zero (for strings); special values 0 and -1 were
7565 changed to -1 and -2, respectively.
7566 (bidi_char_at_pos): New function.
7567 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7568 Call it instead of FETCH_MULTIBYTE_CHAR.
7569 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7570 initialized to valid values.
7571 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7572 values.
7573 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7574 the test for valid cached positions. Fix the logic for looking up
7575 the sentinel state in the cache. GCPRO the Lisp string we are
7576 iterating.
7577 (bidi_push_it, bidi_pop_it): New functions.
7578 (bidi_initialize): Initialize the bidi cache start stack pointer.
7579 (bidi_cache_ensure_space): New function, refactored from part of
7580 bidi_cache_iterator_state. Don't assume the required size is just
7581 one BIDI_CACHE_CHUNK away.
7582 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7583 (bidi_count_bytes, bidi_char_at_pos): New functions.
7584 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7585 always valid if bidi_cache_idx is valid.
7586 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7587 is valid if it's going to be used.
7588 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7589 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7590 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7591 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7592 (bidi_find_other_level_edge, bidi_cache_start_stack):
7593 All variables related to cache indices are now EMACS_INT.
c965adc5 7594
0bb23927
EZ
7595 * dispextern.h (struct bidi_string_data): New structure.
7596 (struct bidi_it): New member `string'. Make flag members be 1-bit
7597 fields, and put them last in the struct.
640c8776
SM
7598 (compute_display_string_pos, compute_display_string_end):
7599 Update prototypes.
0bb23927
EZ
7600 (bidi_push_it, bidi_pop_it): Add prototypes.
7601 (struct iterator_stack_entry): New members bidi_p,
7602 paragraph_embedding, and from_disp_prop_p.
7603 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7604 (bidi_shelve_cache, bidi_unshelve_cache):
7605 Declare prototypes.
0bb23927
EZ
7606
7607 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7608 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7609 and vector-like objects.
7610
7611 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7612 cache around display iteration.
7613
7614 * window.c (Fwindow_end, window_scroll_pixel_based)
7615 (displayed_window_lines, Frecenter): Save and restore the bidi
7616 cache around display iteration.
7617
3bbd2265
LMI
76182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7619
7620 * editfns.c (Fdelete_region): Clarify the use of the named
7621 parameters (bug#6788).
7622
adc47434
MR
76232011-07-14 Martin Rudalics <rudalics@gmx.at>
7624
7625 * indent.c (Fvertical_motion): Set and restore w->pointm when
7626 saving and restoring the window's buffer (Bug#9006).
7627
837c31f8
LMI
76282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7629
7630 * editfns.c (Fstring_to_char): Clarify just what is returned
7631 (bug#6576). Text by Eli Zaretskii.
7632
ac389d0c
JB
76332011-07-13 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7636
0be0ce47
EZ
76372011-07-13 Eli Zaretskii <eliz@gnu.org>
7638
7639 * buffer.c (mmap_find): Fix a typo.
7640
cd18e7e3
JB
76412011-07-13 Johan Bockgård <bojohan@gnu.org>
7642
7643 Fix execution of x selection hooks.
7644 * xselect.c (Qx_lost_selection_functions)
7645 (Qx_sent_selection_functions): New vars.
7646 (syms_of_xselect): DEFSYM them.
7647 (x_handle_selection_request): Pass Qx_sent_selection_functions
7648 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7649 (x_handle_selection_clear,x_clear_frame_selections):
7650 Pass Qx_lost_selection_functions rather than
7651 Vx_lost_selection_functions to Frun_hook_with_args.
7652
47ea7f44
PE
76532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7654
ac389d0c 7655 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7656 The old code sometimes used this field without initializing it.
7657
47ea7f44
PE
7658 * alloc.c (gc_sweep): Don't read past end of array.
7659 In theory, the old code could also have corrupted Emacs internals,
7660 though it'd be very unlikely.
7661
bc985c87
AS
76622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7663
7664 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7665 argument. (Bug#4026)
bc985c87 7666
0cf34688
LMI
76672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7668
b3dadd76
LMI
7669 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7670 key" (bug#4257).
7671
0cf34688
LMI
7672 * window.c (Fset_window_start): Doc fix (bug#4199).
7673 (Fset_window_hscroll): Ditto.
7674
270768cd
PE
76752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7676
077e3dda 7677 Fix minor new problems caught by GCC 4.6.1.
270768cd 7678 * term.c (init_tty): Remove unused local.
490011a6 7679 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7680 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7681 not used otherwise.
270768cd 7682
b1f58454
CY
76832011-07-12 Chong Yidong <cyd@stupidchicken.com>
7684
7685 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7686
22b9578d
LMI
76872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7688
6e70ab07
LMI
7689 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7690 are the mini-buffer and the echo area (bug#3320).
7691
22b9578d
LMI
7692 * term.c (init_tty): Remove support for supdup, c10 and perq
7693 terminals, which are no longer supported (bug#1482).
7694
8974cc9f
JB
76952011-07-10 Johan Bockgård <bojohan@gnu.org>
7696
7697 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7698
a560d974
JD
76992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7700
7701 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7702 for non-popups (Bug#3642).
7703
1dae0f0a
AS
77042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7705
268c2c36 7706 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7707 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7708 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7709 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7710 * data.c (fmod): Likewise.
7711 * dispnew.c (swap_glyphs_in_rows): Likewise.
7712 * emacs.c (memory_warning_signal): Likewise.
7713 * floatfns.c (float_error): Likewise.
7714 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7715 (otf_open, font_otf_capability, generate_otf_features)
7716 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7717 Likewise.
7718 * image.c (pbm_read_file): Likewise.
7719 * indent.c (string_display_width): Likewise.
7720 * intervals.c (check_for_interval, search_for_interval)
7721 (inc_interval_count, count_intervals, root_interval)
7722 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7723 * lread.c (defalias): Likewise.
268c2c36 7724 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7725 * regex.c (set_image_of_range_1, set_image_of_range)
7726 (regex_grow_registers): Likewise.
7727 * sysdep.c (strerror): Likewise.
7728 * termcap.c (valid_filename_p, tprint, main): Likewise.
7729 * tparam.c (main): Likewise.
7730 * unexhp9k800.c (run_time_remap, save_data_space)
7731 (update_file_ptrs, read_header, write_header, calculate_checksum)
7732 (copy_file, copy_rest, display_header): Likewise.
7733 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7734 Likewise.
7735 * xdisp.c (check_it): Likewise.
7736 * xfaces.c (register_color, unregister_color, unregister_colors):
7737 Likewise.
7738 * xfns.c (print_fontset_result): Likewise.
7739 * xrdb.c (member, fatal, main): Likewise.
7740
99033785
PE
77412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7742
7743 Fix minor problems found by static checking (Bug#9031).
7744 * chartab.c (char_table_set_range, map_sub_char_table):
7745 Remove unused locals.
7746 (uniprop_table): Now static.
7747 * composite.c (_work_char): Remove unused static var.
7748
9cb2ac56
JB
77492011-07-09 Juanma Barranquero <lekktu@gmail.com>
7750
7751 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7752
f25661f0
JD
77532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7754
7755 * gtkutil.c (qttip_cb): Remove code without function.
7756
8278c4fe
EZ
77572011-07-09 Eli Zaretskii <eliz@gnu.org>
7758
7759 * w32.c (pthread_sigmask): New stub.
7760
1692ae2d 77612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7762
8a6ebd58 7763 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7764 sigprocmask is portable only for single-threaded applications, and
7765 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7766 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7767 (LIBES): Use it.
7768 * callproc.c (Fcall_process):
7769 * process.c (create_process):
7770 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7771 Use pthread_sigmask, not sigprocmask.
123403e4 7772
1b854618
JD
77732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7774
7775 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7776 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7777 wrong (Bug#8591).
7778
3fe4b549
JD
77792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7780
0ce7e563
JD
7781 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7782 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7783 (xg_hide_tooltip): Fix comment.
7784
3fe4b549
JD
7785 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7786 in registerServicesMenuSendTypes.
7787 (validRequestorForSendType): Don't check ns_return_types.
7788
7789 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7790 ns_return_type.
7791
5df75e47
JR
77922011-07-08 Jason Rumney <jasonr@gnu.org>
7793
22610910
JR
7794 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7795 SH_SHOW for hidden windows (Bug#5482).
7796
5df75e47
JR
7797 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7798 frame struct members of non-existent frames (Bug#6284).
7799
699c10bd
JD
78002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7801
4393663b
JD
7802 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7803 variable firstTime not needed on OSX >= 10.6.
7804 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7805 >= 10.5. Use setKnobProportion, setDoubleValue.
7806
7807 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7808 (MAC_OS_X_VERSION_10_5): Define if not defined.
7809 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7810 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7811 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7812
7813 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7814 cString and lossyCString on OSX >= 10.4.
4393663b 7815
58179cce 7816 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7817 sizeToFit on OSX >= 10.2.
7818
7819 * nsimage.m (allocInitFromFile): Don't use deprecated method
7820 bestRepresentationForDevice on OSX >= 10.6.
7821
7822 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7823 to avoid warning.
7824
7825 * emacs.c: Declare unexec_init_emacs_zone.
7826
a63e0781
JD
7827 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7828
699c10bd
JD
7829 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7830
7831 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7832 on svcsMenu (Bug#8842).
7833
7834 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7835 ns_return_types.
7836 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7837
7838 * nsterm.m (QUTF8_STRING): Declare.
7839 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7840 (validRequestorForSendType): Return type is (id).
7841 Change indexOfObjectIdenticalTo to indexOfObject.
7842 Check if we have local selection before returning self (Bug#8842).
7843 (writeSelectionToPasteboard): Put local selection into paste board
7844 if we have a local selection (Bug#8842).
7845 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7846
7847 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7848 (ns_get_local_selection): Declare.
7849
54e10184
LMI
78502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7851
9888ff71
LMI
7852 * keymap.c (describe_map_tree): Don't insert a double newline at
7853 the end of the buffer (bug#1169) and return whether we inserted
7854 something.
7855
54e10184
LMI
7856 * callint.c (Fcall_interactively): Change "reading args" to
7857 "providing args" to try to clarify what it does (bug#1010).
7858
15fa4783
KH
78592011-07-07 Kenichi Handa <handa@m17n.org>
7860
7861 * composite.c (composition_compute_stop_pos): Ignore a static
7862 composition starting before CHARPOS (Bug#8915).
7863
7864 * xdisp.c (handle_composition_prop): Likewise.
7865
a8815b00
EZ
78662011-07-07 Eli Zaretskii <eliz@gnu.org>
7867
7868 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7869 (Bug#9015)
7870
ef7b981d 78712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7872
7873 * character.h (unicode_category_t): New enum type.
7874
7875 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7876 (Qchar_code_property_table): New variable.
7877 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7878 (UNIPROP_COMPRESSED_FORM_P): New macros.
7879 (char_table_ascii): Uncompress the compressed values.
7880 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7881 Uncompress the compressed values.
ac389d0c 7882 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7883 (char_table_ref_and_range): Uncompress the compressed values.
7884 (sub_char_table_set): New arg is_uniprop. Callers changed.
7885 Uncompress the compressed values.
7886 (sub_char_table_set_range): Args changed. Callers changed.
7887 (char_table_set_range): Adjuted for the above change.
7888 (map_sub_char_table): Delete args default_val and parent. Add arg
7889 top. Give decoded values to a Lisp function.
640c8776 7890 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7891 values to a Lisp function. Gcpro more variables.
7892 (uniprop_table_uncompress)
7893 (uniprop_decode_value_run_length): New functions.
7894 (uniprop_decoder, uniprop_decoder_count): New variables.
7895 (uniprop_get_decoder, uniprop_encode_value_character)
7896 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7897 New functions.
7898 (uniprop_encoder, uniprop_encoder_count): New variables.
7899 (uniprop_get_encoder, uniprop_table)
7900 (Funicode_property_table_internal, Fget_unicode_property_internal)
7901 (Fput_unicode_property_internal): New functions.
7902 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7903 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7904 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7905 char-code-property-alist.
7906
640c8776 7907 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7908 Vunicode_category_table.
7909
640c8776 7910 * font.c (font_range): Adjust for the change of
c805dec0
KH
7911 Vunicode_category_table.
7912
76b397fb
DN
79132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7914
7915 * m/iris4d.h: Remove file, move contents ...
7916 * s/irix6-5.h: ... here.
7917
22b4128e
PE
79182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7919
7920 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7921 * alloc.c (mark_buffer):
7922 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7923 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7924 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7925 This isn't true in general, and it's particularly not true
7926 if Emacs is configured with --with-wide-int.
7927 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7928 New macros, used in the buffer.c change.
7929
869795d6
JD
79302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7931
7932 * xsettings.c: Use both GConf and GSettings if both are available.
7933 (store_config_changed_event): Add comment.
7934 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7935 (store_tool_bar_style_changed): New functions.
5e617bc2 7936 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7937 (struct xsettings): Move font inside HAVE_XFT.
7938 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7939 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7940 Move inside HAVE_XFT.
640c8776 7941 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7942 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7943 also.
7944 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7945 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7946 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7947 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7948 (parse_settings): Move check for font inside HAVE_XFT.
7949 (read_settings, apply_xft_settings): Add comment.
7950 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7951 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7952 call store_font_name_changed.
7953 (xft_settings_event): Add comment.
7954 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7955 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7956 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7957 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7958 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7959 (xsettings_get_system_font, xsettings_get_system_normal_font):
7960 Add comment.
869795d6 7961
d8ed26bd
PE
79622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7963
7964 Random fixes. E.g., (random) never returned negative values.
7965 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7966 subseconds part to the entropy, as that's a bit more random.
7967 Prefer signed to unsigned, since the signedness doesn't matter and
7968 in general we prefer signed. When given a limit, use a
7969 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7970 latter isn't right if USE_2_TAGS_FOR_INTS.
7971 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7972 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7973
cabf1cac
SM
79742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7975
7976 * textprop.c (text_property_stickiness):
7977 Obey Vtext_property_default_nonsticky.
7978 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7979 * w32fns.c (syms_of_w32fns):
7980 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7981
6e9b2be9
PE
79822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7983
7984 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7985 This is more efficient than Ffile_directory_p and avoids a minor race.
7986
90186c68
LMI
79872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7988
7c301272
LMI
7989 * buffer.c (Foverlay_put): Say what the return value is
7990 (bug#7835).
7991
c4f2d8d4
LMI
7992 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7993 is a directory before asking whether to use the file name
7994 (bug#7564).
ad637907
LMI
7995 (barf_or_query_if_file_exists): Make the "File is a directory"
7996 error be more correct.
c4f2d8d4 7997
90186c68
LMI
7998 * fns.c (Frequire): Remove the mention of the .gz files, since
7999 that's installation-specific, but keep the mention of
8000 `get-load-suffixes'.
8001
da64016e
PE
80022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8003
8004 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8005 Report string overflow if the output is too long.
8006
7d47b580
JB
80072011-07-04 Juanma Barranquero <lekktu@gmail.com>
8008
a555cb87
JB
8009 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8010 (syms_of_gnutls): Remove duplicate DEFSYM for
8011 Qgnutls_bootprop_verify_hostname_error, an error for
8012 Qgnutls_bootprop_verify_error (which is no longer used).
8013
7d47b580
JB
8014 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8015 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8016 Also (re)move comments that are misplaced or no longer relevant.
8017
1e49bfab
LMI
80182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8019
8020 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8021
1485f4c0
CY
80222011-07-03 Chong Yidong <cyd@stupidchicken.com>
8023
8024 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8025 and background color parameters if they have been changed.
8026
a9ab721e
LMI
80272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8028
8029 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8030
cf7cff57
PE
80312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8032
2e13213d
PE
8033 * xsettings.c (SYSTEM_FONT): Define only when used.
8034 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8035
cf7cff57
PE
8036 * keymap.c (access_keymap_1): Now static.
8037
7a8e04f7
CY
80382011-07-02 Chong Yidong <cyd@stupidchicken.com>
8039
8040 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8041 leave any prefix arg for the up event (Bug#1586).
8042
61352f62
LMI
80432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8044
69bb1ef7
LMI
8045 * lread.c (syms_of_lread): Mention single symbols defined by
8046 `defvar' or `defconst' (bug#7154).
8047
61352f62 8048 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8049 (Frequire): Mention get-load-suffixes.
61352f62 8050
28545e04
MR
80512011-07-02 Martin Rudalics <rudalics@gmx.at>
8052
8053 * window.h (window): Remove clone_number slot.
8054 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8055 Remove.
8056 (make_parent_window, make_window, saved_window)
8057 (Fset_window_configuration, save_window_save): Don't deal with
8058 clone numbers.
8059 * buffer.c (Qclone_number): Remove declaration.
8060 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8061
3349e122
SM
80622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8063
8064 Add multiple inheritance to keymaps.
8065 * keymap.c (Fmake_composed_keymap): New function.
8066 (Fset_keymap_parent): Simplify.
8067 (fix_submap_inheritance): Remove.
8068 (access_keymap_1): New function extracted from access_keymap to handle
8069 embedded parents and handle lists of maps.
8070 (access_keymap): Use it.
8071 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8072 (Fcopy_keymap): Handle embedded parents.
8073 (Fcommand_remapping, define_as_prefix): Simplify.
8074 (Fkey_binding): Simplify.
8075 (syms_of_keymap): Move minibuffer-local-completion-map,
8076 minibuffer-local-filename-completion-map,
8077 minibuffer-local-must-match-map, and
8078 minibuffer-local-filename-must-match-map to Elisp.
8079 (syms_of_keymap): Defsubr make-composed-keymap.
8080 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8081 (parse_menu_item): Trivial simplification.
8082
3279eb87
GM
80832011-07-01 Glenn Morris <rgm@gnu.org>
8084
8085 * Makefile.in (SETTINGS_LIBS): Fix typo.
8086
4550efdf
KI
80872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8088
8089 * coding.c (Fencode_coding_string): Record the last coding system
8090 used, as the function doc string says (bug#8738).
8091
0949d2b6
JD
80922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8093
8094 * xsettings.c (store_monospaced_changed): Take new font as arg and
8095 check for change against current_mono_font.
8096 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8097 (emacs_settings_constructor, emacs_settings_get_property)
8098 (emacs_settings_set_property, emacs_settings_class_init)
8099 (emacs_settings_init, gsettings_obj): Remove.
8100 (something_changedCB): New function for HAVE_GSETTINGS.
8101 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8102 with value as argument.
8103 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8104 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8105 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8106 "changed".
8107
8108 * xgselect.c: Add defined (HAVE_GSETTINGS).
8109 (xgselect_initialize): Ditto.
8110
8111 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8112 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8113 xg_select.
8114
bbc6b304
PE
81152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8116
8117 * eval.c (struct backtrace): Simplify and port the data structure.
8118 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8119 signed bit field, as this assumption is not portable and it makes
8120 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8121 "char debug_on_exit : 1" as this is not portable either; instead,
8122 use the portable "unsigned int debug_on_exit : 1". Remove unused
8123 member evalargs. Remove obsolete comments about cc bombing out.
8124
9851bfc5
JD
81252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8126
51bb811f 8127 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8128 Let HAVE_GSETTINGS override HAVE_GCONF.
8129 (store_monospaced_changed): New function.
8130 (EMACS_SETTINGS): A new type derived from GObject to handle
8131 GSettings notifications.
8132 (emacs_settings_constructor, emacs_settings_get_property)
8133 (emacs_settings_set_property, emacs_settings_class_init):
8134 New functions.
8135 (gsettings_client, gsettings_obj): New variables.
8136 (GSETTINGS_SCHEMA): New define.
8137 (something_changedCB): Call store_monospaced_changed.
8138 (init_gsettings): New function.
8139 (xsettings_initialize): Call init_gsettings.
8140 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8141 to NULL.
8142
640c8776 8143 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8144 GCONF_CFLAGS/LIBS.
8145
5386012d
MR
81462011-06-29 Martin Rudalics <rudalics@gmx.at>
8147
8148 * window.c (resize_root_window, grow_mini_window)
8149 (shrink_mini_window): Rename Qresize_root_window to
8150 Qwindow_resize_root_window and Qresize_root_window_vertically to
8151 Qwindow_resize_root_window_vertically.
8152
f13e0b08
PE
81532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8154
8155 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8156
94515237
JB
81572011-06-27 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * makefile.w32-in: Redesign dependencies so they reflect more
8160 clearly which files are directly included by each source file,
8161 and not through other includes.
8162
e43b6e43
MR
81632011-06-27 Martin Rudalics <rudalics@gmx.at>
8164
8165 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8166 (sort_overlays, overlay_strings): When an overlay's clone number
8167 matches the window's clone number process the overlay even if
8168 the overlay's window property doesn't match the current window.
8169
d68443dc
MR
8170 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8171 (Fwindow_hchild): Rename to Fwindow_left_child.
8172 (Fwindow_next): Rename to Fwindow_next_sibling.
8173 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8174 (resize_window_check): Rename to window_resize_check.
8175 (resize_window_apply): Rename to window_resize_apply.
8176 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8177 (Fdelete_other_windows_internal, resize_frame_windows)
8178 (Fsplit_window_internal, Fdelete_window_internal)
8179 (grow_mini_window, shrink_mini_window)
8180 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8181
c7e73be5
JD
81822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8183
8184 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8185 (emacs_fixed_set_min_size): Remove.
8186 (emacs_fixed_new): Take frame as argument.
8187
8188 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8189 (_EmacsFixedPrivate): Remove minwidth/height.
8190 Add struct frame *f.
8191 (emacs_fixed_init): Initialize priv->f.
8192 (get_parent_class, emacs_fixed_set_min_size): Remove.
8193 (emacs_fixed_new): Set priv->f to argument.
8194 (emacs_fixed_get_preferred_width)
8195 (emacs_fixed_get_preferred_height): Use min_width/height from
8196 frames size_hint to set minimum and natural (Bug#8919).
8197 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8198 and use min_width/height from frames size_hint to set
8199 min_width/height (Bug#8919).
8200
8201 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8202 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8203 Fix indentation.
c7e73be5 8204
cf99dcf8
EZ
82052011-06-26 Eli Zaretskii <eliz@gnu.org>
8206
8207 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8208 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8209 called at ZV.
8210
029529ac
CY
82112011-06-26 Chong Yidong <cyd@stupidchicken.com>
8212
8213 * process.c (wait_reading_process_output): Bypass select if
8214 waiting for a cell while ignoring keyboard input, and input is
8215 pending. Suggested by Jan Djärv (Bug#8869).
8216
7a7ef429
PE
82172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8218
8219 Use gnulib's dup2 module instead of rolling our own.
8220 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8221
11fdef7d 82222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8223
8224 * dispnew.c (scrolling_window): Before scrolling, turn off a
8225 mouse-highlight in the window being scrolled.
8226
cd3520a4
JB
82272011-06-24 Juanma Barranquero <lekktu@gmail.com>
8228
8229 Move DEFSYM to lisp.h and use everywhere.
8230
8231 * character.h (DEFSYM): Move declaration...
8232 * lisp.h (DEFSYM): ...here.
8233
8234 * gnutls.c:
8235 * minibuf.c:
8236 * w32menu.c:
8237 * w32proc.c:
8238 * w32select.c: Don't include character.h.
8239
8240 * alloc.c (syms_of_alloc):
8241 * buffer.c (syms_of_buffer):
8242 * bytecode.c (syms_of_bytecode):
8243 * callint.c (syms_of_callint):
8244 * casefiddle.c (syms_of_casefiddle):
8245 * casetab.c (init_casetab_once):
8246 * category.c (init_category_once, syms_of_category):
8247 * ccl.c (syms_of_ccl):
8248 * cmds.c (syms_of_cmds):
8249 * composite.c (syms_of_composite):
8250 * dbusbind.c (syms_of_dbusbind):
8251 * dired.c (syms_of_dired):
8252 * dispnew.c (syms_of_display):
8253 * doc.c (syms_of_doc):
8254 * editfns.c (syms_of_editfns):
8255 * emacs.c (syms_of_emacs):
8256 * eval.c (syms_of_eval):
8257 * fileio.c (syms_of_fileio):
8258 * fns.c (syms_of_fns):
8259 * frame.c (syms_of_frame):
8260 * fringe.c (syms_of_fringe):
8261 * insdel.c (syms_of_insdel):
8262 * keymap.c (syms_of_keymap):
8263 * lread.c (init_obarray, syms_of_lread):
8264 * macros.c (syms_of_macros):
8265 * msdos.c (syms_of_msdos):
8266 * print.c (syms_of_print):
8267 * process.c (syms_of_process):
8268 * search.c (syms_of_search):
8269 * sound.c (syms_of_sound):
8270 * syntax.c (init_syntax_once, syms_of_syntax):
8271 * terminal.c (syms_of_terminal):
8272 * textprop.c (syms_of_textprop):
8273 * undo.c (syms_of_undo):
8274 * w32.c (globals_of_w32):
8275 * window.c (syms_of_window):
8276 * xdisp.c (syms_of_xdisp):
8277 * xfaces.c (syms_of_xfaces):
8278 * xfns.c (syms_of_xfns):
8279 * xmenu.c (syms_of_xmenu):
8280 * xsettings.c (syms_of_xsettings):
8281 * xterm.c (syms_of_xterm): Use DEFSYM.
8282
4228cf16
TZ
82832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8284
cd3520a4 8285 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8286
7fcccf1e
PE
82872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8288
7efb4e0e
PE
8289 Integer and buffer overflow fixes (Bug#8873).
8290
ff5844ad
PE
8291 * print.c (printchar, strout): Check for string overflow.
8292 (PRINTPREPARE, printchar, strout):
8293 Don't set size unless allocation succeeds.
8294
90532f02
PE
8295 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8296 for sizes. Check for string overflow more accurately.
8297 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8298
6d84508d
PE
8299 * macros.c: Integer and buffer overflow fixes.
8300 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8301 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8302 Use ptrdiff_t, not int, for sizes.
8303 Don't increment bufsize until after realloc succeeds.
8304 Check for size-calculation overflow.
8305 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8306
437b2cb4
PE
8307 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8308
8b9ac8b4
PE
8309 * lread.c: Integer overflow fixes.
8310 (read_integer): Radix is now EMACS_INT, not int,
8311 to improve quality of diagnostics for out-of-range radices.
8312 Calculate buffer size correctly for out-of-range radices.
8313 (read1): Check for integer overflow in radices, and in
8314 read-circle numbers.
82cb60d3
PE
8315 (read_escape): Avoid int overflow.
8316 (Fload, openp, read_buffer_size, read1)
8317 (substitute_object_recurse, read_vector, read_list, map_obarray):
8318 Use ptrdiff_t, not int, for sizes.
8319 (read1): Use EMACS_INT, not int, for sizes.
20270765 8320 Check for size overflow.
8b9ac8b4 8321
7fcccf1e
PE
8322 * image.c (cache_image): Check for size arithmetic overflow.
8323
bfbbd7e7
PE
8324 * lread.c: Integer overflow issues.
8325 (saved_doc_string_size, saved_doc_string_length)
8326 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8327 Now ptrdiff_t, not int.
8328 (read1): Don't assume doc string length fits in int. Check for
8329 out-of-range doc string lengths.
8330 (read_list): Don't assume file position fits in int.
39019e54 8331 (read_escape): Check for hex character overflow.
bfbbd7e7 8332
4e323265
LL
83332011-06-22 Leo Liu <sdl.web@gmail.com>
8334
8335 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8336 Move to minibuffer.el.
8337
85fece3e
PE
83382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8339
20b84ce9 8340 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8341 The following patches are for when GLYPH_DEBUG && !XASSERT.
8342 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8343 * dispnew.c (flush_stdout):
8344 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8345 Mark as externally visible.
8346 * dispnew.c (check_window_matrix_pointers): Now static.
8347 * dispnew.c (window_to_frame_vpos):
8348 * xfns.c (unwind_create_frame):
8349 * xterm.c (x_check_font): Remove unused local.
8350 * scroll.c (CHECK_BOUNDS):
8351 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8352 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8353 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8354 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8355 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8356 Now static.
8357 (debug_method_add): Use va_list and vsprintf rather than relying
8358 on undefined behavior with wrong number of arguments.
8359 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8360 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8361 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8362 since we're not interested in debugging glyphs with old libraries.
8363 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8364 GCC 4.6.0's static checking.
8365
0766b489
PE
83662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8367
31fd4b32
PE
8368 Integer overflow and signedness fixes (Bug#8873).
8369 A few related buffer overrun fixes, too.
8370
b79e8648
PE
8371 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8372
0766b489
PE
8373 * dispextern.h (struct face.stipple):
8374 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8375 (x_bitmap_mask, x_allocate_bitmap_record)
8376 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8377 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8378 (x_create_bitmap_from_xpm_data):
8379 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8380 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8381 (.bitmaps_last):
8382 * xfaces.c (load_pixmap):
8383 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8384 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8385 (.bitmaps_last, struct x_output.icon_bitmap):
8386 Use ptrdiff_t, not int, for bitmap indexes.
8387 (x_allocate_bitmap_record): Check for size overflow.
8388 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8389
b081724f
PE
8390 Use ptrdiff_t, not int, for overlay counts.
8391 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8392 * editfns.c (overlays_around, get_pos_property):
8393 * textprop.c (get_char_property_and_overlay):
8394 * xdisp.c (next_overlay_change, note_mouse_highlight):
8395 * xfaces.c (face_at_buffer_position):
21514da7
PE
8396 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8397 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8398 (Fnext_overlay_change, Fprevious_overlay_change)
8399 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8400 Use ptrdiff_t, not int, for sizes.
21514da7 8401 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8402
3de73e5e
PE
8403 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8404
2606c57b
PE
8405 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8406 (x_session_initialize): Do not assume string length fits in int.
8407
aaafe47a
PE
8408 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8409 This is unlikely, but can occur if DPI is outlandish.
8410
2674ddc8 8411 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8412 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8413
28154962
PE
8414 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8415 * xrdb.c (magic_file_p, search_magic_path):
8416 Omit last arg SUFFIX; it was always 0. All callers changed.
8417 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8418
7de51af5
PE
8419 * xfont.c (xfont_match): Avoid need for strlen.
8420
25ed6cc3
PE
8421 * xfns.c: Don't assume strlen fits in int.
8422 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8423
4eab31dd
PE
8424 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8425 not unsigned long, as we prefer signed integers. All callers changed.
8426 Detect integer overflow in repeat count.
8427 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8428 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8429
171e2a58
PE
8430 * termcap.c: Don't assume sizes fit in int and never overflow.
8431 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8432 (gobble_line): Check for size-calculation overflow.
8433
ad39faca 8434 * minibuf.c (Fread_buffer):
6e5bb2dc 8435 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8436 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8437 Don't assume string length fits in int.
8438
52c61c22 8439 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8440 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8441
b5b8c9e5
PE
8442 * font.c: Don't assume string length fits in int.
8443 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8444 Use ptrdiff_t, not int.
ccd6111c
PE
8445 (font_intern_prop): Don't assume string length fits in int.
8446 Don't assume integer property fits in fixnum.
8447 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8448
882f0d81 8449 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8450 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8451 Reformulate so as not to need the command string.
8452 Invoke gzip -cd rather than gunzip, as it's more portable.
8453 (lock_info_type, lock_file_1, lock_file):
8454 Don't assume pid_t and time_t fit in unsigned long.
8455 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8456 (current_lock_owner): Prefer signed type for sizes.
8457 Use memcpy, not strncpy, where memcpy is what is really wanted.
8458 Don't assume (via atoi) that time_t and pid_t fit in int.
8459 Check for time_t and/or pid_t out of range, e.g., via a network share.
8460 Don't alloca where an auto var works fine.
8461
93f4cf88
PE
8462 * fileio.c: Fix some integer overflow issues.
8463 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8464 Don't assume string length fits in int.
8465 (directory_file_name): Don't assume string length fits in long.
8466 (make_temp_name): Don't assume pid fits in int, or that its print
8467 length is less than 20.
8468
f3e92b69
PE
8469 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8470
1bfdaf10
PE
8471 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8472
35016e9a
PE
8473 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8474
3d1e65a1
PE
8475 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8476 We prefer signed integers, even for size calculations.
8477
0b963a93
PE
8478 * emacs.c: Don't assume string length fits in 'int'.
8479 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8480 (main): Don't invoke strlen when not needed.
8481
573f4b54
PE
8482 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8483 (XD_DEBUG_MESSAGE): Don't waste a byte.
8484
989f33ba
PE
8485 * callproc.c (getenv_internal_1, getenv_internal)
8486 (Fgetenv_internal):
965d34eb
PE
8487 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8488
e4d29b33
PE
8489 * lread.c (invalid_syntax): Omit length argument.
8490 All uses changed. This doesn't fix a bug, but it simplifies the
8491 code away from its former Hollerith-constant appearance, and it's
8492 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8493 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8494
eb49b136
PE
8495 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8496 This didn't break anything, but it didn't help either.
8497 It's confusing to put a bogus integer in a place where the actual
8498 value does not matter.
9f62aeb1 8499 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8500 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8501
15375a22
PE
8502 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8503 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8504 implementation.
b61cc01c
PE
8505 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8506 We prefer signed types, and the value cannot exceed the EMACS_INT
8507 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8508 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8509 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8510 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8511
53b2623d
PE
8512 * indent.c (sane_tab_width): New function.
8513 (current_column, scan_for_column, Findent_to, position_indentation)
8514 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8515 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8516
51cab52b 8517 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8518
f2ed8a70
PE
8519 * lisp.h (lint_assume): New macro.
8520 * composite.c (composition_gstring_put_cache):
8521 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8522
abe80cc6
PE
8523 * editfns.c, insdel.c:
8524 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8525
b02c740e
PE
8526 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8527
ebc96716
PE
8528 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8529
b4e50fa0 8530 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8531 Use much-faster test for byte-length change.
311d5d7c 8532 Don't assume string byte-length fits in 'int'.
a4cf38e4 8533 Check that character arg fits in 'int'.
85461888 8534 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8535
c0c1ee9f
PE
8536 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8537
a498d7f4
PE
8538 * fns.c (concat): Catch string overflow earlier.
8539 Do not rely on integer wraparound.
8540
51cab52b
PE
8541 * dispextern.h (struct it.overlay_strings_charpos)
8542 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8543 * xdisp.c (forward_to_next_line_start)
8544 (back_to_previous_visible_line_start)
8545 (reseat_at_next_visible_line_start, next_element_from_buffer):
8546 Don't arbitrarily truncate the value of 'selective' to int.
8547
76031fad
PE
8548 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8549
5eb55db9
PE
8550 * composite.c: Don't truncate sizes to 'int'.
8551 (composition_gstring_p, composition_reseat_it)
8552 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8553 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8554 not EMACS_UINT, for indexes.
5eb55db9 8555
0703a717
PE
8556 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8557
d6202519
PE
8558 * buffer.c: Include <verify.h>.
8559 (struct sortvec.priority, struct sortstr.priority):
8961a454 8560 Now EMACS_INT, not int.
c20998a7 8561 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8562 (struct sortstr.size, record_overlay_string)
8563 (struct sortstrlist.size, struct sortlist.used):
8564 Don't truncate size to int.
8565 (record_overlay_string): Check for size-calculation overflow.
d6202519 8566 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8567
d5a19415
JM
85682011-06-22 Jim Meyering <meyering@redhat.com>
8569
029529ac 8570 Don't leak an XBM-image-sized buffer
d5a19415
JM
8571 * image.c (xbm_load): Free the image buffer after using it.
8572
a9041e6c
PE
85732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8574
8575 Port to Sun C.
8576 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8577 that Sun C diagnosed.
8578 * fns.c (secure_hash): Fix pointer signedness issue.
8579 * intervals.c (static_offset_intervals): New function.
8580 (offset_intervals): Use it.
8581
7f3f739f
LL
85822011-06-21 Leo Liu <sdl.web@gmail.com>
8583
8584 * deps.mk (fns.o):
8585 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8586 sha512.h.
8587
8588 * fns.c (secure_hash): Rename from crypto_hash_function and change
8589 the first arg to accept symbols.
5b66d427 8590 (Fsecure_hash): New primitive.
7f3f739f
LL
8591 (syms_of_fns): New symbols.
8592
76147d94
DD
85932011-06-20 Deniz Dogan <deniz@dogan.se>
8594
8595 * process.c (Fset_process_buffer): Clarify return value in
8596 docstring.
8597
7d7d0045
CY
85982011-06-18 Chong Yidong <cyd@stupidchicken.com>
8599
8600 * dispnew.c (add_window_display_history): Use BVAR.
8601
8602 * xdisp.c (debug_method_add): Use BVAR.
8603 (check_window_end, dump_glyph_matrix, dump_glyph)
8604 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8605
8606 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8607 Likewise.
8608
8609 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8610 check till after the cache is created in init_frame_faces.
8611
ff2bc410
SM
86122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8613
8614 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8615
28177add
PE
86162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8617
dd3482fe
PE
8618 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8619 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8620 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8621
393d71f3 8622 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8623 * fileio.c (Finsert_file_contents):
8624 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8625 Remove the old (too-loose) buffer overflow checks.
8626 They weren't needed, since make_gap checks for buffer overflow.
8627 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8628 The old code merely checked for Emacs fixnum overflow, and relied
8629 on undefined (wraparound) behavior. The new code avoids undefined
8630 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8631
2e6813b0 8632 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8633 Tune. Don't use wider integers than needed. Don't use alloca.
8634 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8635
599a9e4f
PE
8636 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8637
99561444
PE
8638 * insdel.c, lisp.h (buffer_overflow): New function.
8639 (insert_from_buffer_1, replace_range, replace_range_2):
8640 * insdel.c (make_gap_larger):
8641 * editfns.c (Finsert_char):
8642 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8643
28177add
PE
8644 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8645
e69dafad
PE
86462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8647
4baa020d 8648 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8649
b1c46f02
PE
8650 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8651 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8652
e69dafad
PE
8653 * fileio.c: Don't assume EMACS_INT fits in off_t.
8654 (emacs_lseek): New static function.
8655 (Finsert_file_contents, Fwrite_region): Use it.
8656 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8657
566684ea
PE
8658 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8659
e6966cd6
PE
8660 * fns.c: Don't overflow int when computing a list length.
8661 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8662 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8663 truncation on 64-bit hosts. Check for QUIT every
8664 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8665 faster and is responsive enough.
8666 (Flength): Report an error instead of overflowing an integer.
8667 (Fsafe_length): Return a float if the value is not representable
8668 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8669 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8670 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8671
dd0b0efb
PE
8672 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8673 (header_size, word_size): New constants.
8674 (allocate_vectorlike): Don't check size overflow here.
8675 (allocate_vector): Check it here instead, since this is the only
8676 caller of allocate_vectorlike that could cause overflow.
8677 Check that the new vector's length is representable as a fixnum.
8678
86fe5cfe
PE
8679 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8680 The previous code was bogus. For example, next_almost_prime (32)
8681 returned 39, which is undesirable as it is a multiple of 3; and
8682 next_almost_prime (24) returned 25, which is a multiple of 5 so
8683 why was the code bothering to check for multiples of 7?
8684
80e88859
PE
8685 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8686
4a2f0ad6
PE
8687 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8688
f66c7cf8
PE
8689 Variadic C functions now count arguments with ptrdiff_t.
8690 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8691 Back then I didn't know that the Emacs coding style prefers signed int.
8692 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8693 were being counted with int, which may truncate counts on 64-bit
8694 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8695 * lisp.h (struct Lisp_Subr.function.aMANY)
8696 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8697 Arg counts are now ptrdiff_t, not size_t.
8698 All variadic functions and their callers changed accordingly.
8699 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8700 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8701 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8702 * callint.c (Fcall_interactively): Check arg count for overflow,
8703 to avoid potential buffer overrun. Use signed char, not 'int',
8704 for 'varies' array, so that we needn't bother to check its size
8705 calculation for overflow.
8706 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8707 * eval.c (apply_lambda):
8708 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8709 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8710 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8711
a1759b76
PE
8712 * callint.c (Fcall_interactively): Don't use index var as event count.
8713
d96be9fc
PE
8714 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8715 * mem-limits.h (SIZE): Remove; no longer used.
8716
a690a978 8717 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8718
578c21e6
PE
8719 Remove unnecessary casts.
8720 * xterm.c (x_term_init):
8721 * xfns.c (x_set_border_pixel):
8722 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8723 These aren't needed now that we assume ANSI C.
8724
96f53c6c
PE
8725 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8726 It's more likely to cause problems (due to unsigned overflow)
8727 than to cure them.
8728
83c77d31
PE
8729 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8730
ee2079f1
PE
8731 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8732
6da65536
PE
8733 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8734
7147c4a4
PE
8735 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8736
193e32d9
PE
8737 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8738
e5533da6
PE
8739 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8740
9910e595
PE
8741 GLYPH_CODE_FACE returns EMACS_INT, not int.
8742 * dispextern.h (merge_faces):
8743 * xfaces.c (merge_faces):
01103c44
PE
8744 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8745 Don't assume EMACS_INT fits in int.
9910e595 8746
2638320e
PE
8747 * character.h (CHAR_VALID_P): Remove unused parameter.
8748 * fontset.c, lisp.h, xdisp.c: All uses changed.
8749
045eb8d9
PE
8750 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8751
c1f134b5
PE
8752 * fns.c (concat): Minor tuning based on overflow analysis.
8753 This doesn't fix any bugs. Use int to hold character, instead
8754 of constantly refetching from Emacs object. Use XFASTINT, not
8755 XINT, for value known to be a character. Don't bother comparing
8756 a single byte to 0400, as it's always less.
8757
395fcb93 8758 * floatfns.c (Fexpt):
327eeec8
PE
8759 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8760
abbd3d23
PE
8761 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8762 for characters.
8763
684a03ef
PE
8764 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8765
0fed43f3
PE
8766 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8767 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8768 incorrectly succeed when S was a string, because 4294967386 was
8769 truncated before it was used.
8770
8fd02eb7
PE
8771 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8772 Otherwise, an out-of-range integer could cause undefined behavior
8773 on a 64-bit host.
8774
f8c86b69
PE
8775 * composite.c: Use int, not EMACS_INT, for characters.
8776 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8777 EMACS_INT, for values that are known to be in character range.
8778 This doesn't fix any bugs but is the usual style inside Emacs and
8779 may generate better code on 32-bit machines.
8780
34206dd2
PE
8781 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8782 This is for reasons similar to the recent CHAR_STRING fix.
8783 * charset.c (Fencode_char): Check that character arg is actually
8784 a character. Pass an int to ENCODE_CHAR.
8785 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8786 wider than 'int', as a compile-time check to prevent future regressions
8787 in this area.
8788
c5958d4c 8789 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8790
8791 Make sure a 64-bit char is never passed to CHAR_STRING.
8792 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8793 by silently ignoring the top 32 bits, allowing some values
8794 that were far too large to be valid characters.
8795 * character.h: Include <verify.h>.
8796 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8797 arguments are no wider than unsigned, as a compile-time check
8798 to prevent future regressions in this area.
8799 * data.c (Faset):
01103c44 8800 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8801 (Fsubst_char_in_region):
8802 * fns.c (concat):
8803 * xdisp.c (decode_mode_spec_coding):
8804 Adjust to CHAR_STRING's new requirement.
8805 * editfns.c (Finsert_char, Fsubst_char_in_region):
8806 * fns.c (concat): Check that character args are actually
8807 characters. Without this test, these functions did the wrong
8808 thing with wildly out-of-range values on 64-bit hosts.
8809
d37ca623
PE
8810 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8811 These casts should not be needed on 32-bit hosts, either.
8812 * keyboard.c (read_char):
8813 * lread.c (Fload): Remove casts to unsigned.
8814
ea204efb
PE
8815 * lisp.h (UNSIGNED_CMP): New macro.
8816 This fixes comparison bugs on 64-bit hosts.
8817 (ASCII_CHAR_P): Use it.
8818 * casefiddle.c (casify_object):
01103c44 8819 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8820 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8821 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8822 * dispextern.h (FACE_FROM_ID):
8823 * keyboard.c (read_char): Use UNSIGNED_CMP.
8824
41cb286c
PE
8825 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8826 not to EMACS_INT, to avoid GCC warning.
8827
4a1b9832
PE
8828 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8829
55daad71
PE
8830 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8831 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8832 isn't needed on 32-bit machines.
8f95c75c 8833
01103c44
PE
8834 * buffer.c (Fgenerate_new_buffer_name):
8835 Use EMACS_INT for count, not int.
0ceccced 8836 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8837
8838 * data.c (Qcompiled_function): Now static.
8839
c6f072e7
PE
8840 * window.c (window_body_lines): Now static.
8841
20ce5912
PE
8842 * image.c (gif_load): Rename local to avoid shadowing.
8843
9c4c5f81
PE
8844 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8845 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8846 * alloc.c (make_save_value): Integer argument is now of type
8847 ptrdiff_t, not int.
8848 (mark_object): Use ptrdiff_t, not int.
8849 * lisp.h (pD): New macro.
8850 * print.c (print_object): Use it.
8851
c0c5c8ae
PE
8852 * alloc.c: Use EMACS_INT, not int, to count objects.
8853 (total_conses, total_markers, total_symbols, total_vector_size)
8854 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8855 (total_free_floats, total_floats, total_free_intervals)
8856 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8857 Now EMACS_INT, not int. All uses changed.
8858 (Fgarbage_collect): Compute overall total using a double, so that
8859 integer overflow is less likely to be a problem. Check for overflow
8860 when converting back to an integer.
5a25e253
PE
8861 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8862 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8863 These were 'int' variables that could overflow on 64-bit hosts;
8864 they were never used, so remove them instead of repairing them.
211a0b2a 8865 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8866 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8867 Previously, this ceilinged at INT_MAX, but that doesn't work on
8868 64-bit machines.
e46bb31a 8869 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8870
c78baabf 8871 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8872 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8873 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8874 when a (possibly-narrower) signed value would do just as well.
8875 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8876
c9d624c6
PE
8877 * alloc.c: Catch some string size overflows that we were missing.
8878 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8879 for convenience in STRING_BYTES_MAX.
8880 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8881 The definition here is exact; the one in lisp.h was approximate.
8882 (allocate_string_data): Check for string overflow. This catches
8883 some instances we weren't catching before. Also, it catches
8884 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8885 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8886 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8887
c9d624c6
PE
8888 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8889 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8890 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8891
353032ce
PE
8892 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8893
2bccce07
PE
8894 * alloc.c (Fmake_string): Check for out-of-range init.
8895
0ac30604
SM
88962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8897
8898 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8899
c195f2de
JD
89002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8901
8902 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8903 xg_get_default_scrollbar_width.
8904
8905 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8906 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8907 (style_changed_cb): Call update_theme_scrollbar_width and call
8908 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8909 all frames (Bug#8505).
8910 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8911 Call gtk_window_set_resizable if HAVE_GTK3.
8912 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8913 and height if HAVE_GTK3 (Bug#8505).
8914 (scroll_bar_width_for_theme): New variable.
8915 (update_theme_scrollbar_width): New function.
8916 (xg_get_default_scrollbar_width): Move code to
8917 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8918 (xg_initialize): Call update_theme_scrollbar_width.
8919
8920 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8921
8922 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8923
e10ac9f1
MR
89242011-06-12 Martin Rudalics <rudalics@gmx.at>
8925
8926 * frame.c (make_frame): Call other_buffer_safely instead of
8927 other_buffer.
8928
8929 * window.c (temp_output_buffer_show): Call display_buffer with
8930 second argument Vtemp_buffer_show_specifiers and reset latter
8931 immediately after the call.
8932 (Vtemp_buffer_show_specifiers): New variable.
8933 (auto_window_vscroll_p, next_screen_context_lines)
8934 (Vscroll_preserve_screen_position): Remove leading asterisks from
8935 doc-strings.
8936
2d3c217e 89372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8938
7b7f97e8 8939 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8940 * buffer.c (Qclone_number): Remove for now, as it's unused.
8941 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8942 (record_buffer): Remove unused local.
8943 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8944 (set_frame_buffer_list): Remove; unused.
8945 * frame.h (other_visible_frames): Remove decl.
8946 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8947 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8948 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8949 if HAVE_GPM.
8950 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8951 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8952 Define only if HAVE_GPM.
8953 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8954 (update_hints_inhibit): Remove; never set. All uses removed.
8955 * widgetprv.h (emacsFrameClassRec): Remove decl.
8956 * window.c (delete_deletable_window): Now returns void, since it
8957 wasn't returning anything.
8958 (compare_window_configurations): Remove unused locals.
8959 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8960 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8961 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8962 the same widths as pointers. This follows up on the 2011-05-06 patch.
8963 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8964 * xterm.h: Likewise.
8965 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8966
1384b89e
JB
89672011-06-12 Juanma Barranquero <lekktu@gmail.com>
8968
8969 * makefile.w32-in: Update dependencies.
8970 (LISP_H): Add lib/intprops.h.
8971
1100a63c
CY
89722011-06-11 Chong Yidong <cyd@stupidchicken.com>
8973
8974 * image.c (gif_load): Add animation frame delay to the metadata.
8975 (syms_of_image): Use DEFSYM. New symbol `delay'.
8976
6198ccd0
MR
89772011-06-11 Martin Rudalics <rudalics@gmx.at>
8978
8979 * window.c (delete_deletable_window): Re-add.
8980 (Fset_window_configuration): Rewrite to handle dead buffers and
8981 consequently deletable windows.
8982 (window_tree, Fwindow_tree): Remove. Supply functionality in
8983 window.el.
8984 (compare_window_configurations): Simplify code.
8985
b6e3633c
AS
89862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8987
1ab0dee5
AS
8988 * image.c (imagemagick_load_image): Fix type mismatch.
8989 (Fimagemagick_types): Likewise.
8990
b6e3633c
AS
8991 * window.h (replace_buffer_in_windows): Declare.
8992
9397e56f
MR
89932011-06-11 Martin Rudalics <rudalics@gmx.at>
8994
8995 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8996 Qclone_number. Remove external declaration of Qdelete_window.
8997 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8998 code.
640c8776
SM
8999 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9000 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9001 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9002 buffer list implementation.
9003 (other_buffer_safely): New function.
9004 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9005 calls to replace_buffer_in_windows and
9006 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9007 if allowed.
9008 (record_buffer): Inhibit quitting and rewrite using quittable
9009 functions. Run Qbuffer_list_update_hook if allowed.
9010 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9011 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9012 Move switch-to-buffer to window.el.
9397e56f
MR
9013 (bury-buffer): Move to window.el.
9014 (Vbuffer_list_update_hook): New variable.
9015
9016 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9017 section.
9018
9019 * window.h (resize_frame_windows): Move up in code.
9020 (Fwindow_frame): Remove EXFUN.
9021 (replace_buffer_in_all_windows): Remove prototype.
9022 (replace_buffer_in_windows_safely): Add prototype.
9023
9024 * window.c: Declare Qdelete_window static again. Move down
9025 declaration of select_count.
9026 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9027 (Fother_window): Move to window.el.
9028 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9029 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9030 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9031 window.el.
9032 (replace_buffer_in_windows): Implement by calling
9033 Qreplace_buffer_in_windows.
9034 (replace_buffer_in_all_windows): Remove with some functionality
9035 moved into replace_buffer_in_windows_safely.
9036 (replace_buffer_in_windows_safely): New function.
9037 (select_window_norecord, select_frame_norecord): Move in front
9038 of run_window_configuration_change_hook. Remove now obsolete
9039 declarations.
640c8776
SM
9040 (Fset_window_buffer): Rewrite doc-string.
9041 Call Qrecord_window_buffer.
9397e56f
MR
9042 (keys_of_window): Move binding for other-window to window.el.
9043
b50691aa
CY
90442011-06-11 Chong Yidong <cyd@stupidchicken.com>
9045
9046 * dispextern.h (struct image): Replace data member, whose int_val
9047 and ptr_val fields were not used by anything, with a single
9048 lisp_val object.
9049
9050 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9051 (gif_clear_image, gif_load, imagemagick_load_image)
9052 (gs_clear_image, gs_load): Callers changed.
9053
3f754b86
PE
90542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9055
cca69397
PE
9056 * buffer.h: Include <time.h>, for time_t.
9057 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9058
109e28d0
PE
9059 Fix minor problems found by static checking.
9060
60737f02
PE
9061 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9062
4b66faf3
PE
9063 Make identifiers static if they are not used in other modules.
9064 * data.c (Qcompiled_function, Qframe, Qvector):
9065 * image.c (QimageMagick, Qsvg):
9066 * minibuf.c (Qmetadata):
9067 * window.c (resize_window_check, resize_root_window): Now static.
9068 * window.h (resize_window_check, resize_root_window): Remove decls.
9069
109e28d0
PE
9070 * window.c (window_deletion_count, delete_deletable_window):
9071 Remove; unused.
46a4ce9e
PE
9072 (window_body_lines): Now static.
9073 (Fdelete_other_windows_internal): Mark vars as initialized.
9074 Make sure 'resize_failed' is initialized.
9075 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9076 (resize_window_apply): Remove unused local.
9077 * window.h (delete_deletable_window): Remove decl.
9078
109e28d0 9079 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9080 (imagemagick_load_image): Fix pointer signedness problem by changing
9081 last arg from unsigned char * to char *. All uses changed.
9082 Also, fix a local for similar reasons.
9083 Remove unused locals. Remove locals to avoid shadowing.
9084 (fn_rsvg_handle_free): Remove; unused.
9085 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9086 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9087
3f754b86
PE
9088 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9089
2547adb1
CY
90902011-06-10 Chong Yidong <cyd@stupidchicken.com>
9091
9092 * image.c (gif_load): Fix omitted cast error introduced by
9093 2011-06-06 change.
9094
2c8e37d4
MR
90952011-06-10 Martin Rudalics <rudalics@gmx.at>
9096
9097 * window.h (resize_proportionally, orig_total_lines)
9098 (orig_top_line): Remove from window structure.
9099 (set_window_height, set_window_width, change_window_heights)
9100 (Fdelete_window): Remove prototypes.
9101 (resize_frame_windows): Remove duplicate declaration.
9102
440a42e3
EZ
91032011-06-10 Eli Zaretskii <eliz@gnu.org>
9104
9105 * window.h (resize_frame_windows, resize_window_check)
9106 (delete_deletable_window, resize_root_window)
9107 (resize_frame_windows): Declare prototypes.
9108
9109 * window.c (resize_window_apply): Make definition be "static" to
9110 match the prototype.
9111
562dd5e9
MR
91122011-06-10 Martin Rudalics <rudalics@gmx.at>
9113
9114 * window.c: Remove declarations of Qwindow_size_fixed,
9115 window_min_size_1, window_min_size_2, window_min_size,
9116 size_window, window_fixed_size_p, enlarge_window, delete_window.
9117 Remove static from declaration of Qdelete_window, it's
9118 temporarily needed by Fbury_buffer.
9119 (replace_window): Don't assign orig_top_line and
9120 orig_total_lines.
9121 (Fdelete_window, delete_window): Remove. Window deletion is
9122 handled by window.el.
640c8776
SM
9123 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9124 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9125 (Fdelete_other_windows): Remove. Deleting other windows is
9126 handled by window.el.
9127 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9128 handled in window.el.
9129 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9130 Window minimum sizes are handled in window.el.
9131 (shrink_windows, size_window, set_window_height)
9132 (set_window_width, change_window_heights, window_height)
9133 (window_width, CURBEG, CURSIZE, enlarge_window)
9134 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9135 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9136 handled in window.el.
9137 (make_dummy_parent): Rename to make_parent_window and give it a
9138 second argument horflag.
9139 (make_window): Don't set resize_proportionally any more.
9140 (Fsplit_window): Remove. Windows are split in window.el.
9141 (save_restore_action, save_restore_orig_size)
9142 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9143 Resize mini windows in window.el.
9144 (grow_mini_window, shrink_mini_window): Implement by calling
9145 Qresize_root_window_vertically, resize_window_check and
9146 resize_window_apply.
640c8776
SM
9147 (saved_window, Fset_window_configuration, save_window_save):
9148 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9149 resize_proportionally.
9150 (window_min_height, window_min_width): Move to window.el.
9151 (keys_of_window): Move bindings for delete-other-windows,
9152 split-window, delete-window and enlarge-window to window.el.
9153
9154 * buffer.c: Temporarily extern Qdelete_window.
9155 (Fbury_buffer): Temporarily call Qdelete_window instead of
9156 Fdelete_window (Fbury_buffer will move to window.el soon).
9157
9158 * frame.c (set_menu_bar_lines_1): Remove code handling
9159 orig_top_line and orig_total_lines.
9160
9161 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9162 set_window_height but set heights directly.
9163 (change_frame_size_1): Use resize_frame_windows.
9164
9165 * xdisp.c (init_xdisp): Don't use set_window_height but set
9166 heights directly.
9167
640c8776
SM
9168 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9169 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9170 run_window_configuration_change_hook.
9171
9172 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9173 instead of change_window_heights and run
9174 run_window_configuration_change_hook.
9175
1a13852e
MR
91762011-06-09 Martin Rudalics <rudalics@gmx.at>
9177
9178 * window.c (replace_window): Rename second argument REPLACEMENT to
9179 NEW. New third argument SETFLAG. Rewrite.
9180 (delete_window, make_dummy_parent): Call replace_window with
9181 third argument 1.
9182 (window_list_1): Move down in code.
9183 (run_window_configuration_change_hook): Move set_buffer part
9184 before select_frame_norecord part in order to unwind correctly.
9185 Rename count1 to count.
9186 (recombine_windows, delete_deletable_window, resize_root_window)
9187 (Fdelete_other_windows_internal)
9188 (Frun_window_configuration_change_hook, make_parent_window)
9189 (resize_window_check, resize_window_apply, Fresize_window_apply)
9190 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9191 (Fdelete_window_internal, Fresize_mini_window_internal):
9192 New functions.
1a13852e
MR
9193 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9194
f3d1777e
MR
91952011-06-08 Martin Rudalics <rudalics@gmx.at>
9196
496e208e
MR
9197 * window.h (window): Add some new members to window structure -
9198 normal_lines, normal_cols, new_total, new_normal, clone_number,
9199 splits, nest, prev_buffers, next_buffers.
9200 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9201 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9202
f3d1777e
MR
9203 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9204 Remove.
496e208e
MR
9205 (make_dummy_parent): Set new members of windows structure.
9206 (make_window): Move down in code. Handle new members of window
9207 structure.
9208 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9209 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9210 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9211 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9212 (Fset_window_next_buffers, Fset_window_clone_number):
9213 New functions.
496e208e
MR
9214 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9215 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9216 Doc-string fixes.
9217 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9218 Argument WINDOW can be now internal window too.
9219 (Fwindow_use_time): Move up in code.
9220 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9221 Rewrite doc-string.
9222 (Fset_window_configuration, saved_window)
9223 (Fcurrent_window_configuration, save_window_save): Handle new
9224 members of window structure.
b9e809c2
MR
9225 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9226 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9227 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9228 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9229 Qget_mru_window, Qresize_root_window,
9230 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9231 Qauto_buffer_name; staticpro them.
f3d1777e 9232
abde8f8c
MR
92332011-06-07 Martin Rudalics <rudalics@gmx.at>
9234
9235 * window.c (Fwindow_total_size, Fwindow_left_column)
9236 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9237 (Fwindow_list_1): New functions.
9238 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9239 (Fwindow_width, Fscroll_left, Fscroll_right):
9240 Use window_body_cols instead of window_box_text_cols.
9241 (delete_window, Fset_window_configuration):
9242 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9243 (delete_all_subwindows): Take a window as argument and not a
9244 structure. Rewrite.
190b47e6
MR
9245 (window_loop): Remove handling of GET_LRU_WINDOW and
9246 GET_LARGEST_WINDOW.
9247 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9248
9249 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9250 window_box_text_cols. delete_all_subwindows now takes a
9251 Lisp_Object as argument.
abde8f8c 9252
640c8776
SM
9253 * indent.c (compute_motion, Fcompute_motion):
9254 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9255
fa8a67e6
MR
9256 * frame.c (delete_frame): Call delete_all_subwindows with root
9257 window as argument.
9258
a54e3482
DC
92592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9260
9261 * fns.c (Fputhash): Document return value.
9262
60002bf5
CY
92632011-06-06 Chong Yidong <cyd@stupidchicken.com>
9264
9265 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9266
0c671da6 92672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9268
b862a52a 9269 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9270
be44ca6c
PE
9271 Check for overflow when converting integer to cons and back.
9272 * charset.c (Fdefine_charset_internal, Fdecode_char):
9273 Use cons_to_unsigned to catch overflow.
9274 (Fencode_char): Use INTEGER_TO_CONS.
9275 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9276 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9277 * data.c (long_to_cons, cons_to_long): Remove.
9278 (cons_to_unsigned, cons_to_signed): New functions.
9279 These signal an error for invalid or out-of-range values.
9280 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9281 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9282 * font.c (Ffont_variation_glyphs):
9283 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9284 * lisp.h: Include <intprops.h>.
9285 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9286 (cons_to_signed, cons_to_unsigned): New decls.
9287 (long_to_cons, cons_to_long): Remove decls.
9288 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9289 (Fprimitive_undo): Use CONS_TO_INTEGER.
9290 * xfns.c (Fx_window_property): Likewise.
9291 * xselect.c: Include <limits.h>.
9292 (x_own_selection, selection_data_to_lisp_data):
9293 Use INTEGER_TO_CONS.
9294 (x_handle_selection_request, x_handle_selection_clear)
9295 (x_get_foreign_selection, Fx_disown_selection_internal)
9296 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9297 (lisp_data_to_selection_data): Use cons_to_unsigned.
9298 (x_fill_property_data): Use cons_to_signed.
9299 Report values out of range.
9300
d1f3d2af
PE
9301 Check for buffer and string overflow more precisely.
9302 * buffer.h (BUF_BYTES_MAX): New macro.
9303 * lisp.h (STRING_BYTES_MAX): New macro.
9304 * alloc.c (Fmake_string):
9305 * character.c (string_escape_byte8):
9306 * coding.c (coding_alloc_by_realloc):
9307 * doprnt.c (doprnt):
9308 * editfns.c (Fformat):
9309 * eval.c (verror):
9310 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9311 since they may not be the same number.
9312 * editfns.c (Finsert_char):
9313 * fileio.c (Finsert_file_contents):
9314 Likewise for BUF_BYTES_MAX.
9315
dd52fcea
PE
9316 * image.c: Use ptrdiff_t, not int, for sizes.
9317 (slurp_file): Switch from int to ptrdiff_t.
9318 All uses changed.
9319 (slurp_file): Check that file size fits in both size_t (for
9320 malloc) and ptrdiff_t (for sanity and safety).
9321
7f9bbdbb
PE
9322 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9323 if b->modtime has its maximal value.
9324
dfe18f82
PE
9325 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9326
84acfcf0
PE
9327 Don't assume time_t can fit into int.
9328 * buffer.h (struct buffer.modtime): Now time_t, not int.
9329 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9330 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9331
ccd9a01a
PE
9332 Minor fixes for signed vs unsigned integers.
9333 * character.h (MAYBE_UNIFY_CHAR):
9334 * charset.c (maybe_unify_char):
9335 * keyboard.c (read_char, reorder_modifiers):
9336 XINT -> XFASTINT, since the integer must be nonnegative.
9337 * ftfont.c (ftfont_spec_pattern):
9338 * keymap.c (access_keymap, silly_event_symbol_error):
9339 XUINT -> XFASTINT, since the integer must be nonnegative.
9340 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9341 since it makes no difference and we prefer signed.
9342 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9343 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9344 nonnegative.
9345
d6d100dd
SM
93462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9347
9348 * window.h (Fwindow_frame): Declare.
9349
2b6148e4
PE
93502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9351
9352 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9353 (SPARE_MEMORY): Always define.
9354 (LARGE_REQUEST): Remove.
9355 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9356
f230ecc9
MR
93572011-06-06 Martin Rudalics <rudalics@gmx.at>
9358
727e958e
MR
9359 * lisp.h: Move EXFUNS for Fframe_root_window,
9360 Fframe_first_window and Fset_frame_selected_window to window.h.
9361
9362 * window.h: Move EXFUNS for Fframe_root_window,
9363 Fframe_first_window and Fset_frame_selected_window here from
9364 lisp.h.
9365
9366 * frame.c (Fwindow_frame, Fframe_first_window)
9367 (Fframe_root_window, Fframe_selected_window)
9368 (Fset_frame_selected_window): Move to window.c.
9369 (Factive_minibuffer_window): Move to minibuf.c.
9370 (Fother_visible_frames_p): New function.
9371
9372 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9373
f230ecc9
MR
9374 * window.c (decode_window, decode_any_window): Move up in code.
9375 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9376 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9377 (Fwindow_buffer): Move up and rewrite doc-string.
9378 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9379 (Fwindow_prev): New functions.
727e958e
MR
9380 (Fwindow_frame): Move here from frame.c. Accept any window as
9381 argument.
9382 (Fframe_root_window, Fframe_first_window)
9383 (Fframe_selected_window): Move here from frame.c. Accept frame
9384 or arbitrary window as argument. Update doc-strings.
9385 (Fminibuffer_window): Move up in code.
9386 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9387 (Fset_frame_selected_window): Move here from frame.c.
9388 Marginal rewrite.
727e958e
MR
9389 (Fselected_window, select_window, Fselect_window): Move up in
9390 code. Minor doc-string fixes.
f230ecc9 9391
4d09bcf6
PE
93922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9393
9394 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9395 Do not assume that spare memory exists; that assumption is valid
9396 only if SYSTEM_MALLOC.
9397 (LARGE_REQUEST): New macro, so that the issue of large requests
9398 is separated from the issue of spare memory.
9399
810928a2
AS
94002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9401
172418ad
AS
9402 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9403 format. (Bug#8806)
9404
43f862f7
AS
9405 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9406
810928a2
AS
9407 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9408 before statements.
9409
a059fe24
JD
94102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9411
9412 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9413
9414 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9415
9416 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9417 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9418
989bf368
JB
94192011-06-05 Juanma Barranquero <lekktu@gmail.com>
9420
9421 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9422
4b80f674
CY
94232011-06-04 Chong Yidong <cyd@stupidchicken.com>
9424
9425 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9426 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9427 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9428 New error handlers.
4b80f674
CY
9429 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9430 Obey Vx_select_enable_clipboard_manager. Catch errors in
9431 x_clipboard_manager_save (Bug#8779).
9432 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9433 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9434
99a33b77 94352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9436
9437 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9438
99a33b77 94392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9440
9441 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9442 in the current matrix if keep_current_p is non-zero.
9443
8264569d
EZ
94442011-06-04 Eli Zaretskii <eliz@gnu.org>
9445
9446 * bidi.c (bidi_level_of_next_char): Fix last change.
9447
57f97249
EZ
94482011-06-03 Eli Zaretskii <eliz@gnu.org>
9449
fec2107c 9450 Support bidi reordering of text covered by display properties.
57f97249 9451
fec2107c
EZ
9452 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9453 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9454 (bidi_cache_search, bidi_cache_iterator_state)
9455 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9456 (bidi_level_of_next_char, bidi_move_to_visually_next):
9457 Support character positions inside a run of characters covered by a
fec2107c
EZ
9458 display string.
9459 (bidi_paragraph_init, bidi_resolve_explicit_1)
9460 (bidi_level_of_next_char): Call bidi_fetch_char and
9461 bidi_fetch_char_advance instead of FETCH_CHAR and
9462 FETCH_CHAR_ADVANCE.
9463 (bidi_init_it): Initialize new members.
9464 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9465 definitions.
9466 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9467 instead of using explicit *_CHAR codes.
d6d100dd
SM
9468 (bidi_resolve_explicit, bidi_resolve_weak):
9469 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9470 bidirectional text is supported only in multibyte buffers.
9471 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9472 it to initialize the frame_window_p member of struct bidi_it.
9473 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9474 (bidi_resolve_explicit, bidi_resolve_weak)
9475 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9476 bidi_it->nchars is non-positive.
9477 (bidi_level_of_next_char): Don't try to lookup the cache for the
9478 next/previous character if nothing is cached there yet, or if we
9479 were just reseat()'ed to a new position.
c40e2fb2 9480
0e14fe90
EZ
9481 * xdisp.c (set_cursor_from_row): Set start and stop points
9482 according to the row's direction when priming the loop that looks
9483 for the glyph on which to display cursor.
9484 (single_display_spec_intangible_p): Function deleted.
9485 (display_prop_intangible_p): Reimplement to call
9486 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9487 Accept 3 additional arguments needed by handle_display_spec.
9488 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9489 values: lists, `(when COND...)' forms, etc.
9490 (single_display_spec_string_p): Support property values that are
9491 lists with the argument STRING its top-level element.
9492 (display_prop_string_p): Fix the condition for processing a
9493 property that is a list to be consistent with handle_display_spec.
fec2107c 9494 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9495 last portion of handle_display_prop.
9496 (compute_display_string_pos): Accept additional argument
9497 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9498 value of a `display' property is a "replacing spec".
9499 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9500 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9501 the display property, but just return a value indicating whether
9502 the display property will replace the characters it covers.
9503 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9504 frame_window_p members of struct bidi_it.
d6d100dd
SM
9505 (compute_display_string_pos, compute_display_string_end):
9506 New functions.
fec2107c
EZ
9507 (push_it): Accept second argument POSITION, where pop_it should
9508 jump to continue iteration.
9509 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9510
fec2107c
EZ
9511 * keyboard.c (adjust_point_for_property): Adjust the call to
9512 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9513
9514 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9515 (bidi_init_it): Update prototypes.
9516 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9517 (compute_display_string_pos, compute_display_string_end):
9518 Declare prototypes.
fec2107c
EZ
9519 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9520 EMACS_INT.
fc6f18ce 9521
40087514 95222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9523
57f53182
PE
9524 Malloc failure behavior now depends on size of allocation.
9525 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9526 * lisp.h: Change signatures accordingly.
9527 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9528 All callers changed. (Bug#8762)
9529
9530 * gnutls.c: Use Emacs's memory allocators.
9531 Without this change, the gnutls library would invoke malloc etc.
9532 directly, which causes problems on non-SYNC_INPUT hosts, and which
9533 runs afoul of improving memory_full behavior. (Bug#8761)
9534 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9535 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9536 xfree instead of the default malloc, realloc, free.
9537 (Fgnutls_boot): No need to check for memory allocation failure,
9538 since xmalloc does that for us.
9539
ac32cd99 9540 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9541 * category.c (hash_get_category_set):
9542 * ccl.c (ccl_driver):
9543 * charset.c (Fdefine_charset_internal):
9544 * charset.h (struct charset.hash_index):
9545 * composite.c (get_composition_id, gstring_lookup_cache)
9546 (composition_gstring_put_cache):
9547 * composite.h (struct composition.hash_index):
9548 * dispextern.h (struct image.hash):
9549 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9550 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9551 (hashfn_equal, hashfn_user_defined, make_hash_table)
9552 (maybe_resize_hash_table, hash_lookup, hash_put)
9553 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9554 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9555 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9556 * image.c (make_image, search_image_cache, lookup_image)
9557 (xpm_put_color_table_h):
9558 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9559 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9560 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9561 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9562 * alloc.c (allocate_vectorlike):
9563 Check for overflow in vector size calculations.
9564 * ccl.c (ccl_driver):
9565 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9566 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9567 need to be updated by these changes.
40087514
PE
9568 * fns.c (make_hash_table, maybe_resize_hash_table):
9569 Check for integer overflow with large hash tables.
0de4bb68
PE
9570 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9571 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9572 (SXHASH_REDUCE): New macro.
9573 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9574 Use it instead of discarding useful hash info with large hash values.
9575 (sxhash_float): New function.
9576 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9577 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9578 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9579 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9580 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9581 Adjust signatures to match updated version of code.
9582 (consing_since_gc): Now EMACS_INT, since a single hash table can
9583 use more than INT_MAX bytes.
9584
698d32e2
DN
95852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9586
9587 Make it possible to build with GCC-4.6+ -O2 -flto.
9588
9589 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9590
fd6fa53f
SM
95912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9592
9593 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9594 Call minibuffer-inactive-mode.
9595
864db017
JB
95962011-05-31 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9599 Update dependencies.
9600
2ad0baf4
DN
96012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9602
9603 * data.c (init_data): Remove code for UTS, this system is not
9604 supported anymore.
9605
4fcc2638
DN
96062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9607
9608 Don't force ./temacs to start in terminal mode.
9609
9610 * frame.c (make_initial_frame): Initialize faces in all cases, not
9611 only when CANNOT_DUMP is defined.
9612 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9613
c56e0fd5
DN
96142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9615
9616 * dispnew.c (add_window_display_history): Use const for the string
9617 pointer. Remove declaration, not needed.
9618
333d54da 96192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9620
55d4c1b2 9621 Use 'inline', not 'INLINE'.
333d54da 9622 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9623 * alloc.c, fontset.c (INLINE): Remove.
9624 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9625 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9626 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9627 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9628 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9629
738db178
DN
96302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9631
9632 Make it possible to run ./temacs.
9633
9634 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9635 syms_of_callproc does the same thing. Remove test for
9636 "initialized", do it in the caller.
9637 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9638
620c53a6
SM
96392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9640
9641 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9642 (read_minibuf): Use get_minibuffer.
9643 (syms_of_minibuf): Use DEFSYM.
9644 (Qmetadata): New var.
9645 * data.c (Qbuffer): Don't make it static.
9646 (syms_of_data): Use DEFSYM.
9647
e003a292
PE
96482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9649
9650 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9651 (CCL_CODE_MIN): New macro.
9652
ed008a6d
PE
96532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9654
3687c2ef
PE
9655 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9656
ed008a6d
PE
9657 * eval.c (Qdebug): Now static.
9658 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9659 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9660 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9661
d66c4c7c
CY
96622011-05-29 Chong Yidong <cyd@stupidchicken.com>
9663
9664 * image.c: Various fixes to ImageMagick code comments.
9665 (Fimagemagick_types): Doc fix.
9666
5fbc2025
PE
96672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9668
0196f88a
PE
9669 Minor fixes prompted by GCC 4.6.0 warnings.
9670
9671 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9672
5fbc2025
PE
9673 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9674 (x_clipboard_manager_save_all): Move extern decl to ...
9675 * xterm.h: ... here, so that it can be checked for consistency.
9676
1dd3c2d9
CY
96772011-05-29 Chong Yidong <cyd@stupidchicken.com>
9678
9679 * xselect.c (x_clipboard_manager_save_frame)
9680 (x_clipboard_manager_save_all): New functions.
9681 (Fx_clipboard_manager_save): Lisp function deleted.
9682
9683 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9684 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9685
9686 * xterm.h: Update prototype.
9687
5ba6571d
WX
96882011-05-28 William Xu <william.xwl@gmail.com>
9689
9690 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9691 exiting (Bug#8239).
9692
3eaff834
JM
96932011-05-28 Jim Meyering <meyering@redhat.com>
9694
e1900994 9695 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9696 * fns.c (to_uchar): Define.
9697 (crypto_hash_function): Use it to convert some newly-signed
9698 variables to unsigned, to avoid sign-extension bugs. For example,
9699 without this change, (md5 "truc") would evaluate to
9700 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9701 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9702 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9703
0f6990a7
PE
97042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9705
9706 Integer overflow fixes.
c8a9ca5a 9707
08686060
PE
9708 * dbusbind.c: Serial number integer overflow fixes.
9709 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9710 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9711 to hold a serial number that is too large for a fixnum.
9712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9713 Check for serial numbers out of range. Decode any serial number
59568bf0 9714 that was so large that it became a float. (Bug#8722)
08686060 9715
2d1fc3c7
PE
9716 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9717 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9718 Use XFASTINT rather than XUINT when numbers are nonnegative.
9719 (xd_append_arg, Fdbus_method_return_internal):
9720 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9721 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9722 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9723 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9724 (Bug#8722)
2d1fc3c7 9725
c8a9ca5a
PE
9726 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9727
519e1d69
PE
9728 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9729
6df6ae42 9730 ccl: Add integer overflow checks.
30569699
PE
9731 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9732 (IN_INT_RANGE): New macros.
9733 (ccl_driver): Use them to check for integer overflow when
9734 decoding a CCL program. Many of the new checks are whether XINT (x)
9735 fits in int; it doesn't always, on 64-bit hosts. The new version
9736 doesn't catch all possible integer overflows, but it's an
847044ea 9737 improvement. (Bug#8719)
30569699 9738
c11285dc
PE
9739 * alloc.c (make_event_array): Use XINT, not XUINT.
9740 There's no need for unsigned here.
9741
fdccd48e
PE
9742 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9743 This follows up to the 2011-05-06 change that substituted uintptr_t
9744 for EMACS_INT. This case wasn't caught back then.
9745
37910ab2
PE
9746 Rework Fformat to avoid integer overflow issues.
9747 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9748 now (part of C89). Include <verify.h>.
9749 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9750 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9751 (Fformat): Avoid the prepass trying to compute sizes; it was only
9752 approximate and thus did not catch overflow reliably. Instead, walk
9753 through the format just once, formatting and computing sizes as we go,
9754 checking for integer overflow at every step, and allocating a larger
9755 buffer as needed. Keep track separately whether the format is
9756 multibyte. Keep only the most-recently calculated precision, rather
9757 than them all. Record whether each argument has been converted to
9758 string. Use EMACS_INT, not int, for byte and char and arg counts.
9759 Support field widths and precisions larger than INT_MAX. Avoid
9760 sprintf's undefined behavior with conversion specifications such as %#d
9761 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9762 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9763 formatting out-of-range floating point numbers with int
9173deec 9764 formats. (Bug#8668)
37910ab2 9765
2e6578fb
PE
9766 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9767
0ae6bdee
PE
9768 * data.c: Avoid integer truncation in expressions involving floats.
9769 * data.c: Include <intprops.h>.
9770 (arith_driver): When there's an integer overflow in an expression
9771 involving floating point, convert the integers to floating point
9772 so that the resulting value does not suffer from catastrophic
9773 integer truncation. For example, on a 64-bit host (* 4
9774 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9775 Do not rely on undefined behavior after integer overflow.
9776
de883a70
PE
9777 merge count_size_as_multibyte, parse_str_to_multibyte
9778 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9779 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9780 Check for integer overflow.
9781 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9782 since it's now a duplicate of the other. This is more of
9783 a character than a buffer op, so better that it's in character.c.
9784 * fns.c, print.c: Adjust to above changes.
9785
2ff916cb
PE
97862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9787
9788 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9789
f1b54466
PE
97902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9791
fb1ac845
PE
9792 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9793 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9794 (x_clipboard_manager_save): Now static.
9795 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9796
f1b54466
PE
9797 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9798 (crypto_hash_function): Now static.
9799 Fix pointer signedness problems. Avoid unnecessary initializations.
9800
a9f737ee
CY
98012011-05-27 Chong Yidong <cyd@stupidchicken.com>
9802
9803 * termhooks.h (Vselection_alist): Make it terminal-local.
9804
9805 * terminal.c (create_terminal): Initialize it.
9806
9807 * xselect.c: Support for clipboard managers.
9808 (Vselection_alist): Move to termhooks.h as terminal-local var.
9809 (LOCAL_SELECTION): New macro.
9810 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9811 (symbol_to_x_atom): Remove gratuitous arg.
9812 (x_handle_selection_request, lisp_data_to_selection_data)
9813 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9814 (x_own_selection, x_get_local_selection, x_convert_selection):
9815 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9816 (some_frame_on_display): Delete unused function.
9817 (Fx_own_selection_internal, Fx_get_selection_internal)
9818 (Fx_disown_selection_internal, Fx_selection_owner_p)
9819 (Fx_selection_exists_p): New optional frame arg.
9820 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9821 (x_handle_selection_clear): Don't treat other terminals with the
9822 same keyboard specially. Use the terminal-local Vselection_alist.
9823 (x_clear_frame_selections): Use Frun_hook_with_args.
9824
9825 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9826
9827 * xterm.h: Add support for those atoms.
9828
e067f0c1
CY
98292011-05-26 Chong Yidong <cyd@stupidchicken.com>
9830
9831 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9832 (converted_selections, conversion_fail_tag): New global variables.
9833 (x_selection_request_lisp_error): Free the above.
9834 (x_get_local_selection): Remove unnecessary code.
9835 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9836 of converted selections stored in converted_selections.
9837 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9838 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9839 (x_convert_selection): New function.
9840 (x_handle_selection_event): Simplify.
9841 (x_get_foreign_selection): Don't ignore incoming requests while
9842 waiting for an answer; this will fail when we implement
9843 SAVE_TARGETS, and seems unnecessary anyway.
9844 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9845 (Vx_sent_selection_functions): Doc fix.
9846
0f4aebc0
LL
98472011-05-26 Leo Liu <sdl.web@gmail.com>
9848
9849 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9850
e61124cd
YM
98512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9852
9853 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9854
9855 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9856 for fringe update if it has periodic bitmap.
ac389d0c 9857 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9858 and fringe_bitmap_periodic_p.
9859
9860 * fringe.c (get_fringe_bitmap_data): New function.
9861 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9862 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9863 row. Mark glyph row for fringe update if periodicity changed.
9864
9865 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9866 for fringe update unless it has periodic bitmap.
9867
f16d9837
KH
98682011-05-25 Kenichi Handa <handa@m17n.org>
9869
9870 * xdisp.c (get_next_display_element): Set correct it->face_id for
9871 a static composition.
9872
e1b90ef6
LL
98732011-05-24 Leo Liu <sdl.web@gmail.com>
9874
9875 * deps.mk (fns.o):
9876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9877
9878 * fns.c (crypto_hash_function, Fsha1): New function.
9879 (Fmd5): Use crypto_hash_function.
9880 (syms_of_fns): Add Ssha1.
9881
7400048f
PE
98822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9883
9884 * gnutls.c: Remove unused macros.
9885 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9886 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9887 Remove macros that are defined and never used.
9888 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9889
abb71cf4
CY
98902011-05-22 Chong Yidong <cyd@stupidchicken.com>
9891
9892 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9893 (Fx_get_selection_internal): Minor cleanup.
9894 (Fx_own_selection_internal): Rename arguments for consistency with
9895 select.el.
9896
6307db39
PE
98972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9898
9899 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9900
f3d4e0a4
CY
99012011-05-22 Chong Yidong <cyd@stupidchicken.com>
9902
9903 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9904
4d8ade89
YM
99052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9906
9907 * dispnew.c (scrolling_window): Don't exclude the case that the
9908 last enabled row in the desired matrix touches the bottom boundary.
9909
32078c8d
GM
99102011-05-21 Glenn Morris <rgm@gnu.org>
9911
9912 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9913 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9914 and add some more files.
32078c8d 9915
7285dc67
EZ
99162011-05-20 Eli Zaretskii <eliz@gnu.org>
9917
9918 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9919 report_file_error introduced by the change from 2011-05-07.
9920
89d1bd22
PE
99212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9922
9923 * systime.h (Time): Define only if emacs is defined.
9924 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9925 where the include path doesn't have X11/X.h by default. See
9926 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9927
cd394be1 99282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9929
9930 * composite.c (find_automatic_composition): Fix previous change.
9931
b9704ad9
GM
99322011-05-20 Glenn Morris <rgm@gnu.org>
9933
9934 * lisp.mk: New file, split from Makefile.in.
9935 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9936 (shortlisp): Remove.
9937 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9938
4a720484
GM
99392011-05-19 Glenn Morris <rgm@gnu.org>
9940
9941 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9942 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9943 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9944 (lisp): Set the order to that of loadup.el.
9945 (shortlisp): Make it a copy of $lisp.
9946 (SOME_MACHINE_LISP): Remove.
9947 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9948 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9949
a28d4396
KH
99502011-05-18 Kenichi Handa <handa@m17n.org>
9951
9952 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9953 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9954 (find_automatic_composition): Mostly rewrite for efficiency.
9955
a2b1fa8e
JB
99562011-05-18 Juanma Barranquero <lekktu@gmail.com>
9957
9958 * makefile.w32-in: Update dependencies.
9959
8e1f5610
CS
99602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9961
9962 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9963 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9964
7025ee00 99652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9966
cdfa6eab
PE
9967 Fix some integer overflow issues, such as string length overflow.
9968
06d6db33
PE
9969 * insdel.c (count_size_as_multibyte): Check for string overflow.
9970
2b4560a8
PE
9971 * character.c (lisp_string_width): Check for string overflow.
9972 Use EMACS_INT, not int, for string indexes and lengths; in
9973 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9974 the resulting string length overflows an EMACS_INT; instead,
9975 report a string overflow if no precision given. When checking for
9976 precision exhaustion, use a check that cannot possibly have
9977 integer overflow. (Bug#8675)
9978 * character.h (lisp_string_width): Adjust to new signature.
9979
cb93f9be
PE
9980 * alloc.c (string_overflow): New function.
9981 (Fmake_string): Use it. This doesn't change behavior, but saves
9982 a few bytes and will simplify future changes.
9983 * character.c (string_escape_byte8): Likewise.
9984 * lisp.h (string_overflow): New decl.
9985
1a1f3366
PE
9986 Fixups, following up to the user-interface timestamp change.
9987 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9988 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9989 * msdos.c (mouse_get_pos): Likewise.
9990 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9991 * w32gui.h (Time): Define by including "systime.h" rather than by
9992 declaring it ourselves. (Bug#8664)
9993
d4e3e4d3
PE
9994 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9995 * image.c (clear_image_cache): Likewise.
9996
f6a24d19
PE
9997 * term.c (term_mouse_position): Don't assume time_t wraparound.
9998
08dc5ae6
PE
9999 Be more systematic about user-interface timestamps.
10000 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10001 and sometimes 'EMACS_UINT', to represent these timestamps.
10002 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10003 This makes the code easier to follow, and makes it easier to catch
10004 integer overflow bugs such as Bug#8664.
10005 * frame.c (Fmouse_position, Fmouse_pixel_position):
10006 Use Time, not unsigned long, for user-interface timestamps.
10007 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10008 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10009 * keyboard.h (last_event_timestamp): Likewise.
10010 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10011 * menu.h (xmenu_show): Likewise.
10012 * term.c (term_mouse_position): Likewise.
10013 * termhooks.h (struct input_event.timestamp): Likewise.
10014 (struct terminal.mouse_position_hook): Likewise.
10015 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10016 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10017 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10018 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10019 what it was before.
10020 * menu.h, termhooks.h: Include "systime.h", for Time.
10021
8e55734a
PE
10022 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10023 Don't assume that the difference between two unsigned long values
10024 can fit into an integer. At this point, we know button_down_time
10025 <= event->timestamp, so the difference must be nonnegative, so
10026 there's no need to cast the result if double-click-time is
10027 nonnegative, as it should be; check that it's nonnegative, just in
10028 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10029 apart (about 25 days). (Bug#8664)
8e55734a 10030
841f1b75 10031 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10032 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10033
3e26f69c
PE
10034 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10035 that always fit in int. Use a sentinel instead of a counter, to
10036 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10037 * frame.h (struct frame): Use int for menu_bar_items_used
10038 instead of EMACS_INT, since it always fits in int.
3e26f69c 10039
5cc152c0
PE
10040 * menu.c (grow_menu_items): Check for int overflow.
10041
d89eb65e
PE
10042 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10043
5235bd3e
PE
10044 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10045 Before, the code was not consistent. These values cannot exceed
10046 2**31 - 1 so there's no need to make them unsigned.
10047 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10048 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10049 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10050 as modifiers.
10051 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10052
bc827e23
PE
10053 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10054 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10055 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10056 presumably because the widths might not match.
10057
78eb494e
PE
10058 * window.c (size_window): Avoid needless test at loop start.
10059
04f2d78b
CB
100602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10061
10062 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10063
d2fc7e3d 100642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10065
10066 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10067
d2fc7e3d 100682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10069
10070 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10071 `width' to `bar_area_x' and `bar_area_width', respectively.
10072 (x_scroll_run): Take account of fringe background extension.
10073
04f2d78b
CB
10074 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10075 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10076 `bar_area_width', respectively.
10077 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10078 background extension.
10079
79b70037
GM
100802011-05-10 Jim Meyering <meyering@redhat.com>
10081
10082 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10083
2f142cc5
JB
100842011-05-10 Juanma Barranquero <lekktu@gmail.com>
10085
10086 * image.c (Finit_image_library): Return t for built-in image types,
10087 like pbm and xbm. (Bug#8640)
10088
57679c86
AS
100892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10090
10091 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10092
888c9e86
EZ
100932011-05-07 Eli Zaretskii <eliz@gnu.org>
10094
b0512a1d
EZ
10095 * w32console.c (Fset_screen_color): Doc fix.
10096 (Fget_screen_color): New function.
10097 (syms_of_ntterm): Defsubr it.
10098
7285dc67
EZ
10099 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10100 unlink the temporary file if Fcall_process didn't create it in the
10101 first place.
10102 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10103 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10104 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10105 cue to call_process_cleanup not to close that handle.
10106
4d3fcc8e
BK
101072011-05-07 Ben Key <bkey76@gmail.com>
10108
10109 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10110 one of two shell specific rules, either bootstrap-temacs-CMD or
10111 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10112 to the previous implementation of the bootstrap-temacs rule.
10113 The bootstrap-temacs-CMD rule is similar to the previous
10114 implementation of the bootstrap-temacs rule except that it
10115 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10116 variable.
10117
10118 These changes, along with some changes to nt/configure.bat,
10119 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10120 earlier fix to add support for --cflags and --ldflags options
10121 that include quotes so that it works whether make uses cmd or
10122 sh as the shell.
10123
b4289b64
MA
101242011-05-06 Michael Albinus <michael.albinus@gmx.de>
10125
10126 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10127 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10128 is a constant.
10129 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10130 a string. Handle both cases.
10131 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10132 (Fdbus_register_method): Use Qinvalid_function.
10133
af4c0e28
JB
101342011-05-06 Juanma Barranquero <lekktu@gmail.com>
10135
10136 * makefile.w32-in: Update dependencies.
10137 (LISP_H): Add inttypes.h and stdin.h.
10138 (PROCESS_H): Add unistd.h.
10139
c51453d9
EZ
101402011-05-06 Eli Zaretskii <eliz@gnu.org>
10141
10142 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10143 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10144
8ff0ac3c 101452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10146
4c4b566b
PE
10147 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10148
aab2b9b5
PE
10149 * term.c (vfatal): Remove stray call to va_end.
10150 It's not needed and the C Standard doesn't allow it here anyway.
10151
c378da0b
PE
10152 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10153 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10154
288b08c7
PE
10155 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10156 bytes.
10157
e3601888
PE
10158 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10159
db6c0e74
PE
10160 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10161
dd5963ea
PE
10162 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10163
88c9450f
PE
10164 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10165
2f9442b8
PE
10166 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10167
c032b5f8
PE
10168 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10169 * charset.c (Fdefine_charset_internal): Don't initialize
10170 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10171 32-bit int (Bug#8600).
a108c10b
PE
10172
10173 * lread.c (read_integer): Be more consistent with string-to-number.
10174 Use string_to_number to do the actual conversion; this avoids
10175 rounding errors and fixes some other screwups. Without this fix,
10176 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10177 (digit_to_number): Move earlier, for benefit of read_integer.
10178 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10179 not a digit in any supported base. (Bug#8602)
a108c10b 10180
ad5f9eea
PE
10181 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10182
aec1708a
PE
10183 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10184 to match comment at start of function. This also removes a
10185 GCC warning about overflow in a 32+64-bit port.
10186
47be4ab5
PE
10187 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10188
371cac43
PE
10189 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10190 Reported by Stefan Monnier in
10191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10192 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10193 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10194
d01a7826
PE
10195 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10196 (EMACS_UINTPTR): Likewise, with uintptr_t.
10197
7fd47d5c
PE
10198 * lisp.h: Prefer 64-bit EMACS_INT if available.
10199 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10200 on 32-bit hosts that have 64-bit int, so that they can access
10201 large files.
122b0c86
PE
10202 However, temporarily disable this change unless the temporary
10203 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10204
8727937b
PE
10205 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10206
8ac068ac
PE
10207 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10208 This removes an assumption that EMACS_INT and long are the same
10209 width as pointers. The assumption is true for Emacs porting targets
10210 now, but we want to make other targets possible.
10211 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10212 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10213 In the rest of the code, change types of integers that hold casted
10214 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10215 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10216 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10217 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10218 No need to cast type when ORing.
10219 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10220 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10221 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10222 assume EMACS_INT is the same width as char *.
10223 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10224 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10225 Remove no-longer-needed casts.
10226 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10227 (xg_tool_bar_help_callback, xg_make_tool_item):
10228 Use EMACS_INTPTR to hold an integer
10229 that will be cast to void *; this can avoid a GCC warning
10230 if EMACS_INT is not the same width as void *.
10231 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10232 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10233 (current_message_1, set_message_1):
10234 Use a local to convert to proper width without a cast.
10235 * xmenu.c (dialog_selection_callback): Likewise.
10236
ede49d71
PE
10237 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10238 Also, don't assume VALBITS / RAND_BITS is less than 5,
10239 and don't rely on undefined behavior when shifting a 1 left into
10240 the sign bit.
10241 * lisp.h (get_random): Change signature to match.
10242
2f30ecd0
PE
10243 * lread.c (hash_string): Use size_t, not int, for hash computation.
10244 Normally we prefer signed values; but hashing is special, because
10245 it's better to use unsigned division on hash table sizes so that
10246 the remainder is nonnegative. Also, size_t is the natural width
10247 for hashing into memory. The previous code used 'int', which doesn't
10248 retain enough info to hash well into very large tables.
10249 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10250
2a866e7b
PE
10251 * dbusbind.c: Don't possibly lose pointer info when converting.
10252 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10253 Use XPNTR rather than XHASH, so that the high-order bits of
10254 the pointer aren't lost when converting through void *.
10255
51639eac
PE
10256 * eval.c (Fautoload): Don't double-shift a pointer.
10257
92394119
PE
10258 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10259
dbdb9a7c
JB
102602011-05-06 Juanma Barranquero <lekktu@gmail.com>
10261
10262 * gnutls.c (DEF_GNUTLS_FN):
10263 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10264
db7a0b4f
AS
102652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10266
10267 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10268 marker. (Bug#8610)
10269
cd394be1 102702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10271
10272 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10273 New version that can reserve upto 2GB of heap space.
10274
f7ff1b0f 102752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10276
10277 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10278
639c109b
TZ
102792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10280
10281 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10282 `gnutls_certificate_set_x509_key_file'.
10283
d2127135
JB
102842011-05-05 Juanma Barranquero <lekktu@gmail.com>
10285
10286 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10287 Update dependencies.
10288
e968f4f3
JB
102892011-05-04 Juanma Barranquero <lekktu@gmail.com>
10290
10291 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10292 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10293 Remove unused parameter `fildes'.
10294 * process.c (read_process_output, send_process): Don't pass it.
10295
84d358f0
JB
102962011-05-04 Juanma Barranquero <lekktu@gmail.com>
10297
10298 Fix previous change: the library cache is defined in w32.c.
10299 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10300 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10301
0898ca10
JB
103022011-05-04 Juanma Barranquero <lekktu@gmail.com>
10303
10304 Implement dynamic loading of GnuTLS on Windows.
10305
10306 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10307 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10308 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10309 Declare.
10310
10311 * gnutls.c (Qgnutls_dll): Define.
10312 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10313 (gnutls_*): Declare function pointers.
10314 (init_gnutls_functions): New function to initialize function pointers.
10315 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10316 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10318 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10319 (emacs_gnutls_write, emacs_gnutls_read)
10320 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10321 (Fgnutls_available_p): New function.
10322 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10323 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10324 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10325
10326 * image.c: Include w32.h.
10327 (Vimage_type_cache): Delete.
10328 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10329 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10330 (w32_delayed_load): Move to w32.c.
10331
10332 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10333
10334 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10335 (w32_delayed_load): Move from image.c. When loading a library, record
10336 its filename in the :loaded-from property of the library id.
10337 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10338 Initialize and staticpro them.
10339 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10340
10341 * process.c: Include lisp.h before w32.h, not after.
10342 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10343 instead of gnutls_record_check_pending.
10344
10345 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10346
ff4de4aa
TZ
103472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10348
10349 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10350 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10351 as passed in.
10352
abe95abb
JD
103532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10354
10355 * xterm.c (x_set_frame_alpha): Do not set property on anything
10356 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10357
e16e55d4
JB
103582011-05-02 Juanma Barranquero <lekktu@gmail.com>
10359
10360 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10361
bafcf6a5
JB
103622011-05-02 Juanma Barranquero <lekktu@gmail.com>
10363
10364 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10365 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10366 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10367 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10368 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10369 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10370 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10371 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10372 (Qgnutls_bootprop_callbacks_verify): Make static.
10373
e7a6747f
AS
103742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10375
19ed11ba
AS
10376 * callproc.c: Indentation fixup.
10377
e7a6747f 10378 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10379 (wait_for_termination, interruptible_wait_for_termination):
10380 Move after wait_for_termination_1.
e7a6747f 10381
1ef14cb4
LMI
103822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10383
10384 * sysdep.c (interruptible_wait_for_termination): New function
10385 which is like wait_for_termination, but allows keyboard
10386 interruptions.
10387
10388 * callproc.c (Fcall_process): Add (:file "file") as an option for
10389 the STDOUT buffer.
10390 (Fcall_process_region): Ditto.
10391
330d880c
EZ
103922011-04-30 Eli Zaretskii <eliz@gnu.org>
10393
8db90b73
EZ
10394 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10395 rather than `XVECTOR (FOO)->size'.
10396
330d880c
EZ
10397 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10398 inttypes.h, as a gnulib replacement is used if it not available in
10399 system headers.
10400
15cbd324
EZ
104012011-04-21 Eli Zaretskii <eliz@gnu.org>
10402
10403 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10404 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10405 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10406
10407 * coding.c (coding_alloc_by_realloc): Error out if destination
10408 will grow beyond MOST_POSITIVE_FIXNUM.
10409 (decode_coding_emacs_mule): Abort if there isn't enough place in
10410 charbuf for the composition carryover bytes. Reserve an extra
10411 space for up to 2 characters produced in a loop.
10412 (decode_coding_iso_2022): Abort if there isn't enough place in
10413 charbuf for the composition carryover bytes.
10414
104152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10416
ae940cca
EZ
10417 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10418 aborting when %lld or %lll format is passed.
10419 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10420 %llo or %llx format is passed. (Bug#8545)
10421
03ab8921
EZ
10422 * window.c (window_scroll_line_based): Use a marker instead of
10423 simple variables to record original value of point. (Bug#7952)
10424
afda1437
EZ
10425 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10426 produced by %s or %c overflows available buffer space. (Bug#8545)
10427
f76dee0c
PE
104282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10429
10430 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10431 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10432
fdc5744d
JB
104332011-04-28 Juanma Barranquero <lekktu@gmail.com>
10434
10435 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10436
638f053a
JB
104372011-04-28 Juanma Barranquero <lekktu@gmail.com>
10438
10439 * keyboard.c (Qdelayed_warnings_hook): Define.
10440 (command_loop_1): Run `delayed-warnings-hook'
10441 if Vdelayed_warnings_list is non-nil.
10442 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10443 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10444
d178f871
EZ
104452011-04-28 Eli Zaretskii <eliz@gnu.org>
10446
10447 * doprnt.c (doprnt): Don't return value smaller than the buffer
10448 size if the message was truncated. (Bug#8545).
10449
b124fd93
JB
104502011-04-28 Juanma Barranquero <lekktu@gmail.com>
10451
10452 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10453 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10454
e810457d
PE
104552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10456
10457 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10458
ea51cceb
JB
104592011-04-27 Juanma Barranquero <lekktu@gmail.com>
10460
10461 * makefile.w32-in: Update dependencies.
10462
94dcfacf
EZ
104632011-04-27 Eli Zaretskii <eliz@gnu.org>
10464
10465 Improve `doprnt' and its usage. (Bug#8545)
10466 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10467 `format_end'. Remove support for %l as a conversion specifier.
10468 Don't use xrealloc. Improve diagnostics when the %l size modifier
10469 is used. Update the commentary.
10470
10471 * eval.c (verror): Simplify calculation of size_t.
10472
10473 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10474 messages.
10475
f61f41d7
PE
104762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10477
10478 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10479 change.
10480
96fb4434
PE
104812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10482
10483 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10484 This makes this file independent of the recent pseudovector change.
10485
671875da 104862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10487
69e9b5a3
PE
10488 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10489
b5f869a7 10490 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10491 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10492 Remove unused local.
c8926152 10493 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10494
841a1577 10495 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10496 GCC 4.6.0 optimizes based on type-based alias analysis.
10497 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10498 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10499 != &v->size, and therefore "v->size = 1; b->size = 2; return
10500 v->size;" must therefore return 1. This assumption is incorrect
10501 for Emacs, since it type-puns struct Lisp_Vector * with many other
10502 types. To fix this problem, this patch adds a new type struct
f904488f 10503 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10504 and pseudovectors, and helps optimizing compilers not get fooled
10505 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10506 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10507 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10508 the size member.
eab3844f
PE
10509 (XSETPVECTYPE): Rewrite in terms of new macro.
10510 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10511 This is a bit clearer, and further avoids the possibility of
10512 undesirable aliasing.
10513 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10514 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10515 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10516 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10517 (ASIZE): Now uses header.size rather than size.
10518 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10519 to avoid the hassle of writing XVECTOR (foo)->header.size.
10520 (struct vectorlike_header): New type.
eab3844f
PE
10521 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10522 object, to help avoid aliasing.
10523 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10524 (SUBRP): Likewise, since Lisp_Subr is a special case.
10525 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10526 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10527 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10528 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10529 changed to be "header.size" and "header.next".
10530 * buffer.h (struct buffer): Likewise.
10531 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10532 * frame.h (struct frame): Likewise.
10533 * process.h (struct Lisp_Process): Likewise.
10534 * termhooks.h (struct terminal): Likewise.
10535 * window.c (struct save_window_data, struct saved_window): Likewise.
10536 * window.h (struct window): Likewise.
10537 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10538 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10539 * buffer.c (init_buffer_once): Likewise.
10540 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10541 special case.
10542 * process.c (Fformat_network_address): Use local var for size,
10543 for brevity.
10544
0df1eac5
PE
10545 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10546
847ab9d1 10547 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10548 * data.c (atof): Remove decl; no longer used or needed.
10549 (digit_to_number): Move to lread.c.
10550 (Fstring_to_number): Use new string_to_number function, to be
10551 consistent with how the Lisp reader treats infinities and NaNs.
10552 Do not assume that floating-point numbers represent EMACS_INT
10553 without losing information; this is not true on most 64-bit hosts.
10554 Avoid double-rounding errors, by insisting on integers when
10555 parsing non-base-10 numbers, as the documentation specifies.
10556 * lisp.h (string_to_number): New decl, replacing ...
10557 (isfloat_string): Remove.
bc0a5c13 10558 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10559 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10560 appears to have been a coding error. Similarly, do not accept
10561 strings like +-1e0 as floating point numbers. Do not report
10562 overflow for integer overflows unless the base is not 10 which
10563 means we have no simple and reliable way to continue.
10564 Break out the floating-point parsing into a new
10565 function string_to_number, so that Fstring_to_number parses
10566 floating point numbers consistently with the Lisp reader.
04f2d78b 10567 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10568 (E_CHAR, EXP_INT): Remove, replacing with ...
10569 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10570 (string_to_number): New function, replacing isfloat_string.
10571 This function checks for valid syntax and produces the resulting
10572 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10573 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10574 so that overflow for non-base-10 numbers is reported only when
10575 there's no portable and simple way to convert to floating point.
452f4150 10576
67769ffc
PE
10577 * textprop.c (set_text_properties_1): Rewrite for clarity,
10578 and to avoid GCC warning about integer overflow.
10579
c20db43f
PE
10580 * intervals.h (struct interval): Use EMACS_INT for members
10581 where EMACS_UINT might cause problems. See
10582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10583 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10584 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10585 All uses changed.
37aa2f85
PE
10586 (offset_intervals): Tell GCC not to worry about length overflow
10587 when negating a negative length.
c20db43f 10588
2538aa2f
PE
10589 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10590 (overrun_check_free): Likewise.
10591
f2d3008d
PE
10592 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10593 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10594 word size.
10595
ec8df744
PE
10596 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10597 (gnutls_make_error): Rename local to avoid shadowing.
10598 (gnutls_emacs_global_deinit): ifdef out; not used.
10599 (Fgnutls_boot): Use const for pointer to readonly storage.
10600 Comment out unused local. Fix pointer signedness problems.
10601
640ee02d
PE
10602 * lread.c (openp): Don't stuff size_t into an 'int'.
10603 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10604 about possible signed overflow.
10605
6048fb2a
PE
10606 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10607 (GDK_KEY_g): Don't define if already defined.
10608 (xg_prepare_tooltip): Avoid pointer signedness problem.
10609 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10610
fa3c87e1
PE
10611 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10612 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10613
2172544b
PE
10614 * xfns.c (Fx_window_property): Simplify a bit,
10615 to make a bit faster and to avoid GCC 4.6.0 warning.
10616 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10617
9b821a21
PE
10618 * fns.c (internal_equal): Don't assume size_t fits in int.
10619
3c616cfa
PE
10620 * alloc.c (compact_small_strings): Tighten assertion a little.
10621
c2982e87
PE
10622 Replace pEd with more-general pI, and fix some printf arg casts.
10623 * lisp.h (pI): New macro, generalizing old pEd macro to other
10624 conversion specifiers. For example, use "...%"pI"d..." rather
10625 than "...%"pEd"...".
10626 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10627 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10628 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10629 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10630 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10631 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10632 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10633 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10634 64-bit hosts.
10635 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10636 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10637 * print.c (safe_debug_print, print_object): Likewise.
10638 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10639 to int.
6f04d126
PE
10640 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10641 avoiding the 0 flag, which is not portable.
c2982e87
PE
10642 * process.c (Fmake_network_process): Use pI to avoid cast.
10643 * region-cache.c (pp_cache): Likewise.
10644 * xdisp.c (decode_mode_spec): Likewise.
10645 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10646 behavior on 64-bit hosts with printf arg.
6f04d126 10647 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10648 (x_stop_queuing_selection_requests): Likewise.
10649 (x_get_window_property): Don't truncate byte count to an 'int'
10650 when tracing.
0b432f21 10651
5e073ec7
PE
10652 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10653 here, since it parses constructs like leading '-' and spaces,
10654 which are not wanted; and it overflows with large numbers.
10655 Instead, simply match F[0-9]+, which is what is wanted anyway.
10656
36372bf9
PE
10657 * alloc.c: Remove unportable assumptions about struct layout.
10658 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10659 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10660 (allocate_vectorlike, make_pure_vector): Use the new macros,
10661 plus offsetof, to remove unportable assumptions about struct layout.
10662 These assumptions hold on all porting targets that I know of, but
10663 they are not guaranteed, they're easy to remove, and removing them
10664 makes further changes easier.
10665
0b432f21
PE
10666 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10667 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10668 (string_overrun_cookie): Now const. Use initializers that
10669 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10670 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10671 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10672 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10673 multiple of sizeof (EMACS_INT); it need not be, if
10674 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10675 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10676
895009e1
JB
106772011-04-26 Juanma Barranquero <lekktu@gmail.com>
10678
10679 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10680
6a7a1b0b
TZ
106812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10682
10683 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10684 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10685 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10686
841a1577 106872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10688
10689 * lisp.h (Qdebug): List symbol.
895009e1 10690 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10691 * keyboard.c (debug-on-event): New variable.
10692 (handle_user_signal): Break into debugger when debug-on-event
10693 matches the current signal symbol.
10694
f2d3ba6f
DN
106952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10696
10697 * alloc.c (check_sblock, check_string_bytes)
10698 (check_string_free_list): Convert to standard C.
10699
42ce4c63
TZ
107002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10701
10702 * w32.c (emacs_gnutls_push): Fix typo.
10703
825cd63c
EZ
107042011-04-25 Eli Zaretskii <eliz@gnu.org>
10705
fb11d64d
EZ
10706 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10707 "cast to pointer from integer of different size".
10708
825cd63c
EZ
10709 Improve doprnt and its use in verror. (Bug#8545)
10710 * doprnt.c (doprnt): Document the set of format control sequences
10711 supported by the function. Use SAFE_ALLOCA instead of always
10712 using `alloca'.
10713
10714 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10715 is one byte too soon. Don't use xrealloc; instead xfree and
10716 xmalloc anew.
10717
e061a11b
TZ
107182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10719
10720 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10721 callbacks stage.
10722
10723 * gnutls.c: Renamed global_initialized to
10724 gnutls_global_initialized. Added internals for the
10725 :verify-hostname-error, :verify-error, and :verify-flags
10726 parameters of `gnutls-boot' and documented those parameters in the
10727 docstring. Start callback support.
9173deec
JB
10728 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10729 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10730 on error. Return error code.
e061a11b
TZ
10731 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10732 (emacs_gnutls_read): Likewise.
10733 (Fgnutls_boot): Return handshake error code.
10734 (emacs_gnutls_handle_error): New function.
10735 (wsaerror_to_errno): Likewise.
10736
10737 * w32.h (emacs_gnutls_pull): Add prototype.
10738 (emacs_gnutls_push): Likewise.
10739
10740 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10741 (emacs_gnutls_push): Likewise.
10742
107432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10744
10745 * process.c (wait_reading_process_output): Check if GnuTLS
10746 buffered some data internally if no FDs are set for TLS
10747 connections.
10748
10749 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10750 (LIBS): Link to USER_LIBS.
10751 ($(BLD)/gnutls.$(0)): New target.
10752
fa6996bc
EZ
107532011-04-24 Eli Zaretskii <eliz@gnu.org>
10754
eb35682e
EZ
10755 * xdisp.c (handle_single_display_spec): Rename the
10756 display_replaced_before_p argument into display_replaced_p, to
10757 make it consistent with the commentary. Fix typos in the
10758 commentary.
10759
e2ad650c
EZ
10760 * textprop.c (syms_of_textprop): Remove dead code.
10761 (copy_text_properties): Delete obsolete commentary about an
10762 interface that was deleted long ago. Fix typos in the description
10763 of arguments.
10764
1b2de274
EZ
10765 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10766 to changes in oldXMenu/XMenu.h from 2011-04-16.
10767 <menu_help_message, prev_menu_help_message>: Constify.
10768 (IT_menu_make_room): menu->help_text is now `const char **';
10769 adjust.
10770
10771 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10772 to changes in oldXMenu/XMenu.h from 2011-04-16.
10773 (struct XMenu): Declare `help_text' `const char **'.
10774
10775 * xfaces.c <Qunspecified>: Make extern again.
10776
10777 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10778 required by POSIX.
1b2de274 10779
762b15be
EZ
10780 * doc.c (get_doc_string): Improve the format passed to `error'.
10781
10782 * doprnt.c (doprnt): Improve commentary.
10783
10784 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10785
10786 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10787 them with etags.
10788
f1052e5d
EZ
10789 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10790 changes in globals.h immediately force recompilation.
762b15be
EZ
10791 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10792 $(CURDIR)/s/ms-w32.h.
10793 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10794
fa6996bc
EZ
10795 * character.c (Fchar_direction): Function deleted.
10796 (syms_of_character): Don't defsubr it.
10797 <char-direction-table>: Deleted.
10798
e6c3da20
EZ
107992011-04-23 Eli Zaretskii <eliz@gnu.org>
10800
10801 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10802 * doprnt.c: Include limits.h.
10803 (SIZE_MAX): New macro.
04f2d78b
CB
10804 (doprnt): Return a size_t value. 2nd arg is now size_t.
10805 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10806 Improve overflow protection. Support `l' modifier for integer
10807 conversions. Support %l conversion. Don't assume an EMACS_INT
10808 argument for integer conversions and for %c.
10809
10810 * lisp.h (doprnt): Restore prototype.
10811
10812 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10813 $(SRC)/character.h.
10814
10815 * Makefile.in (base_obj): Add back doprnt.o.
10816
10817 * deps.mk (doprnt.o): Add back prerequisites.
10818 (callint.o): Depend on character.h.
10819
10820 * eval.c (internal_lisp_condition_case): Include the handler
10821 representation in the error message.
10822 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10823 when breaking from the loop.
10824
10825 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10826
10827 * callint.c (Fcall_interactively): When displaying error message
10828 about invalid control letter, pass the character's codepoint, not
10829 a pointer to its multibyte form. Improve display of the character
10830 in octal and display also its hex code.
10831
10832 * character.c (char_string): Use %x to display the (unsigned)
10833 codepoint of an invalid character, to avoid displaying a bogus
10834 negative value.
10835
10836 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10837 `error', not SYMBOL_NAME itself.
10838
10839 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10840 character arguments to `error'.
10841
10842 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10843 to `error' in error message about FINAL_CHAR argument. Make sure
10844 FINAL_CHAR is a character, and use %c when it is passed as
10845 argument to `error'.
10846
4ffd0d6b 108472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10848
10849 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10850
10851 * w32.c: Include <time.h>.
10852 (sys_localtime): New function.
10853
4ffd0d6b 108542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10855
10856 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10857
4ffd0d6b 10858 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10859
4ffd0d6b 108602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10861
4ffd0d6b
GM
10862 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10863 zombies (Bug#8467).
aac0c6e3 10864
04c56954
EZ
108652011-04-19 Eli Zaretskii <eliz@gnu.org>
10866
10867 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10868 gl_state.e_property when gl_state.object is Qt.
10869
10870 * insdel.c (make_gap_larger): Remove limitation of buffer size
10871 to <= INT_MAX.
10872
16a43933
CY
108732011-04-18 Chong Yidong <cyd@stupidchicken.com>
10874
10875 * xdisp.c (lookup_glyphless_char_display)
10876 (produce_glyphless_glyph): Handle cons cell entry in
10877 glyphless-char-display.
10878 (Vglyphless_char_display): Document it.
10879
10880 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10881 glyphless-char-display.
10882
4581706e
CY
108832011-04-17 Chong Yidong <cyd@stupidchicken.com>
10884
10885 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10886
10887 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10888
10889 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10890 definition for no-X builds.
10891
4887c6e2 108922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10893
fd35b6f9
PE
10894 Static checks with GCC 4.6.0 and non-default toolkits.
10895
5c1ccb01
PE
10896 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10897
006c5daa
PE
10898 * process.c (keyboard_bit_set): Define only if SIGIO.
10899 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10900 (send_process): Repair possible setjmp clobbering.
10901
efc736d3
PE
10902 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10903
4e2fe2e6
PE
10904 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10905
f97334a2
PE
10906 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10907
4e75f29d
PE
10908 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10909 Define only if needed.
10910
90efadd1
PE
10911 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10912 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10913 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10914
3c647824
PE
10915 * dispextern.h (struct redisplay_interface): Rename param
10916 to avoid shadowing.
e264f262 10917 * termhooks.h (struct terminal): Likewise.
761383f4 10918 * xterm.c (xembed_send_message): Likewise.
3c647824 10919
b58c5c4a
PE
10920 * insdel.c (make_gap_smaller): Define only if
10921 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10922
cad59032
PE
10923 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10924 it.
10925
c339dc2e
PE
10926 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10927 so that we aren't warned about unused symbols.
10928
91a3e27b
PE
10929 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10930
399c71d3 10931 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10932
8ffc96f5
PE
10933 * xfns.c (x_real_positions): Mark locals as initialized.
10934
eef9bc79
PE
10935 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10936
098db9dd
PE
10937 * xterm.c: Fix problems found by static analysis with other toolkits.
10938 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10939 (x_dispatch_event): Declare static if USE_GTK, and
10940 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10941 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10942 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10943 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10944 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10945
eb18f6cc
PE
10946 * xmenu.c (menu_help_callback): Pointer type fixes.
10947 Use const pointers when pointing at readonly data. Avoid pointer
10948 signedness clashes.
10949 (FALSE): Remove unused macro.
10950 (update_frame_menubar): Remove unused decl.
10951
1fe72bf8
PE
10952 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10953
60d9e1db
PE
10954 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10955 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10956 (single_menu_item): Rename local to avoid shadowing.
10957
39261c26
PE
10958 * keyboard.c (make_lispy_event): Remove unused local var.
10959
018c5e19
PE
10960 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10961 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10962
63d2b86e
PE
10963 * bitmaps: Change bitmaps from unsigned char back to the X11
10964 compatible char. Avoid the old compiler warnings about
10965 out-of-range initializers by using, for example, '\xab' rather
10966 than 0xab.
10967
aefd87e1
PE
10968 * xgselect.c (xgselect_initialize): Check vs interface
10969 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10970
bf501fb9
PE
10971 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10972
e9829fdf
PE
10973 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10974 to read-only memory.
10975
1086c095
PE
10976 * fns.c (vector): Remove; this old hack is no longer needed.
10977
2baccd04 10978 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10979 Remove unused var.
dde42981 10980 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10981
72391843 10982 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10983
436c16df 10984 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10985 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10986 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10987
92bb796d 10988 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10989 (x_term_init): Remove local to avoid shadowing.
92bb796d 10990
764430a3 10991 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10992
10993 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10994 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10995
d1dfb56c
EZ
109962011-04-16 Eli Zaretskii <eliz@gnu.org>
10997
c4354cb4
EZ
10998 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10999
d1dfb56c
EZ
11000 Fix regex.c, syntax.c and friends for buffers > 2GB.
11001 * syntax.h (struct gl_state_s): Declare character position members
11002 EMACS_INT.
11003
11004 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11005
04f2d78b
CB
11006 * textprop.c (verify_interval_modification, interval_of):
11007 Declare arguments EMACS_INT.
d1dfb56c
EZ
11008
11009 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11010 EMACS_INT.
11011
11012 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11013
11014 * indent.c (Fvertical_motion): Local variable it_start is now
11015 EMACS_INT.
11016
11017 * regex.c (re_match, re_match_2, re_match_2_internal)
11018 (bcmp_translate, regcomp, regexec, print_double_string)
11019 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11020 (re_compile_pattern, re_exec): Declare arguments and local
11021 variables `size_t' and `ssize_t' and return values `regoff_t', as
11022 appropriate.
11023 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11024 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11025 <compile_stack_type>: `size' and `avail' are now `size_t'.
11026
11027 * regex.h <regoff_t>: Use ssize_t, not int.
11028 (re_search, re_search_2, re_match, re_match_2): Arguments that
11029 specify buffer/string position and length are now ssize_t and
11030 size_t. Return type is regoff_t.
11031
613052cd
BK
110322011-04-16 Ben Key <bkey76@gmail.com>
11033
11034 * nsfont.m: Fixed bugs in ns_get_family and
11035 ns_descriptor_to_entity that were caused by using free to
11036 deallocate memory blocks that were allocated by xmalloc (via
11037 xstrdup). This caused Emacs to crash when compiled with
11038 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11039 --enable-checking=xmallocoverrun). xfree is now used to
11040 deallocate these memory blocks.
11041
4170f62f 110422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11043
71b41406
PE
11044 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11045
9587a89d
PE
11046 emacs_write: Accept and return EMACS_INT for sizes.
11047 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11048 et seq.
11049 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11050 Accept and return EMACS_INT.
11051 (emacs_gnutls_write): Return the number of bytes written on
11052 partial writes.
11053 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11054 (emacs_read, emacs_write): Remove check for negative size, as the
11055 Emacs source code has been audited now.
9587a89d
PE
11056 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11057 (emacs_read, emacs_write): Use it.
273a5f82
PE
11058 * process.c (send_process): Adjust to the new signatures of
11059 emacs_write and emacs_gnutls_write. Do not attempt to store
11060 a byte offset into an 'int'; it might overflow.
9587a89d 11061 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11062
3e047f51
PE
11063 * sound.c: Don't assume sizes fit in 'int'.
11064 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11065 Return EMACS_INT, not int.
3e047f51 11066 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11067 Accept EMACS_INT, not int.
11068 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11069 record read return values.
11070
cc39a9db
BK
110712011-04-15 Ben Key <bkey76@gmail.com>
11072
c9d0ec6d
JB
11073 * keyboard.c (Qundefined): Don't declare static since it is used
11074 in nsfns.m.
11075 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11076 static since they are used in nsfont.m.
cc39a9db 11077
6c60eb9f
SM
110782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11079
11080 * process.c (Qprocessp): Don't declare static.
11081 * lisp.h (Qprocessp): Declare again.
11082
7990b61a
JB
110832011-04-15 Juanma Barranquero <lekktu@gmail.com>
11084
11085 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11086
5d4cb038
PE
110872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11088
8bd7b830 11089 Improve C-level modularity by making more things 'static'.
cd64ea1d 11090
e3b27b31
PE
11091 Don't publish debugger-only interfaces to other modules.
11092 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11093 (verify_bytepos, count_markers): Move decls to the only modules
11094 that need them.
11095 * region-cache.h (pp_cache): Likewise.
11096 * window.h (check_all_windows): Likewise.
11097 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11098
5d4cb038
PE
11099 * sysdep.c (croak): Now static, if
11100 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11101 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11102
11103 * alloc.c (refill_memory_reserve): Now static if
11104 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11105 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11106
e87b6180
PE
11107 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11108 Define only if USE_LUCID.
11109
ac64929e
PE
11110 * xrdb.c (x_customization_string, x_rm_string): Now static.
11111
6f37259d
PE
11112 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11113 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11114
1683e3ab
PE
11115 * xdisp.c (draw_row_with_mouse_face): Now static.
11116 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11117
de9c2632
PE
11118 * window.h (check_all_windows): Mark externally visible.
11119
2b96acb7
PE
11120 * window.c (window_deletion_count): Now static.
11121
11122 * undo.c: Make symbols static if they're not exported.
11123 (last_undo_buffer, last_boundary_position, pending_boundary):
11124 Now static.
11125
50436f33
PE
11126 * textprop.c (interval_insert_behind_hooks): Now static.
11127 (interval_insert_in_front_hooks): Likewise.
11128
64520e5c
PE
11129 * term.c: Make symbols static if they're not exported.
11130 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11131 (max_frame_lines, tty_set_terminal_modes):
11132 (tty_reset_terminal_modes, tty_turn_off_highlight):
11133 (get_tty_terminal): Now static.
11134 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11135 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11136 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11137 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11138 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11139
1fa53021
PE
11140 * sysdep.c: Make symbols static if they're not exported.
11141 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11142 Now static.
11143 (sigprocmask_set, full_mask): Remove; unused.
11144 (wait_debugging): Mark as visible.
11145 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11146 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11147
d4b43b22
PE
11148 * syntax.c (syntax_temp): Define only if !__GNUC__.
11149
b7c513d0
PE
11150 * sound.c (current_sound_device, current_sound): Now static.
11151
989b29ad
PE
11152 * search.c (searchbufs, searchbuf_head): Now static.
11153
13a55a78
PE
11154 * scroll.c (scroll_cost): Remove; unused.
11155 * dispextern.h (scroll_cost): Remove decl.
11156
de68a1fc
PE
11157 * region-cache.h (pp_cache): Mark as externally visible.
11158
40ccffa6
PE
11159 * process.c: Make symbols static if they're not exported.
11160 (process_tick, update_tick, create_process, chan_process):
11161 (Vprocess_alist, proc_buffered_char, datagram_access):
11162 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11163 (deactivate_process): Mark defn as static, as well as decl.
11164 * lisp.h (create_process): Remove decl.
11165 * process.h (chan_process, Vprocess_alist): Remove decls.
11166
ad64fc97
PE
11167 * print.c: Make symbols static if they're not exported.
11168 (print_depth, new_backquote_output, being_printed, print_buffer):
11169 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11170 (print_interval, print_number_index, initial_stderr_stream):
11171 Now static.
11172 * lisp.h (Fprinc): Remove decl.
11173 (debug_output_compilation_hack): Mark as externally visible.
11174
adddb265
PE
11175 * sysdep.c (croak): Move decl from here to syssignal.h.
11176 * syssignal.h (croak): Put it here, so the API can be checked when
11177 'croak' is called from dissociate_if_controlling_tty.
11178
1717ede2
PE
11179 * minibuf.c: Make symbols static if they're not exported.
11180 (minibuf_save_list, choose_minibuf_frame): Now static.
11181 * lisp.h (choose_minibuf_frame): Remove decl.
11182
fa5fb2bc
PE
11183 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11184
1e3890d1
PE
11185 * lread.c: Make symbols static if they're not exported.
11186 (read_objects, initial_obarray, oblookup_last_bucket_number):
11187 Now static.
11188 (make_symbol): Remove; unused.
11189 * lisp.h (initial_obarray, make_symbol): Remove decls.
11190
8a1414fa
PE
11191 * keyboard.c: Make symbols static if they're not exported.
11192 (single_kboard, recent_keys_index, total_keys, recent_keys):
11193 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11194 (this_single_command_key_start, echoing, last_auto_save):
11195 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11196 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11197 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11198 (Vlispy_mouse_stem, double_click_count):
11199 Now static.
11200 (force_auto_save_soon): Define only if SIGDANGER.
11201 (ignore_mouse_drag_p): Now static if
11202 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11203 (print_help): Remove; unused.
11204 (stop_character, last_timer_event): Mark as externally visible.
11205 * keyboard.h (ignore_mouse_drag_p): Declare only if
11206 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11207 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11208 * lisp.h (echoing): Remove decl.
11209 (force_auto_save_soon): Declare only if SIGDANGER.
11210 * xdisp.c (redisplay_window): Simplify code, to make it more
11211 obvious that ignore_mouse_drag_p is not accessed if !defined
11212 USE_GTK && !defined HAVE_NS.
11213
93ea6e8f
PE
11214 * intervals.c: Make symbols static if they're not exported.
11215 (merge_properties_sticky, merge_interval_right, delete_interval):
11216 Now static.
11217 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11218
77382fcc
PE
11219 * insdel.c: Make symbols static if they're not exported.
11220 However, leave prepare_to_modify_buffer alone. It's never
11221 called from outside this function, but that appears to be a bug.
11222 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11223 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11224 (adjust_after_replace_noundo): Remove; unused.
11225 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11226 (signal_before_change): Remove decls.
77382fcc 11227
9306c32e
PE
11228 * indent.c (val_compute_motion, val_vmotion): Now static.
11229
cd44d2eb
PE
11230 * image.c: Make symbols static if they're not exported.
11231 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11232 if USE_GTK.
11233 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11234 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11235
ad9a7a06
PE
11236 * fringe.c (standard_bitmaps): Now static.
11237 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11238
81626931
PE
11239 * frame.c: Make symbols static if they're not exported.
11240 (x_report_frame_params, make_terminal_frame): Now static.
11241 (get_frame_param): Now static, unless HAVE_NS.
11242 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11243 (x_get_resource_string): Remove; not used.
11244 * frame.h (make_terminal_frame, x_report_frame_params):
11245 (x_get_resource_string); Remove decls.
11246 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11247 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11248
239f9db9
PE
11249 * font.c, fontset.c: Make symbols static if they're not exported.
11250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11251 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11252 * font.c (font_close_object): Now static.
11253 * font.h (font_close_object): Remove.
11254 * fontset.c (FONTSET_OBJLIST): Remove.
11255 (free_realized_fontset) #if-0 the body, which does nothing.
11256 (face_suitable_for_char_p): #if-0, as it's never called.
11257 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11258 * xfaces.c (face_at_string_position):
11259 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11260 since 0 is always ASCII.
11261
dfcf3579
PE
11262 * fns.c (weak_hash_tables): Now static.
11263
5045092b
PE
11264 * fileio.c: Make symbols static if they're not exported.
11265 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11266 (Vwrite_region_annotation_buffers): Now static.
11267
57a96f5c
PE
11268 * eval.c: Make symbols static if they're not exported.
11269 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11270 * lisp.h (backtrace_list): Remove decl.
11271
35f08c38
PE
11272 * emacs.c: Make symbols static if they're not exported.
11273 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11274 (fatal_error_code, fatal_error_signal_hook, standard_args):
11275 Now static.
11276 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11277 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11278 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11279 * lisp.h (fatal_error_signal_hook): Remove decl.
11280 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11281
f44bd759
PE
11282 * editfns.c: Move a (normally-unused) function to its only use.
11283 * editfns.c, lisp.h (get_operating_system_release): Remove.
11284 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11285 worth the hassle of breaking this out.
11286
b532497d
PE
11287 * xterm.c: Make symbols static if they're not exported.
11288 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11289 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11290 (x_destroy_window, x_delete_display):
11291 Now static.
11292 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11293 (x_mouse_leave): Remove; unused.
11294 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11295 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11296 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11297 Remove decls.
11298 (x_mouse_leave): Declare only if WINDOWSNT.
11299 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11300 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11301 USE_X_TOOLKIT.
11302
1675728f
PE
11303 * ftxfont.c: Make symbols static if they're not exported.
11304 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11305 HAVE_FREETYPE.
11306 * font.h (ftxfont_driver): Likewise.
11307
e4cebfca
PE
11308 * xfns.c: Make symbols static if they're not exported.
11309 (x_last_font_name, x_display_info_for_name):
11310 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11311 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11312 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11313 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11314 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11315 (last_show_tip_args): Now static.
11316 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11317 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11318 (x_screen_planes): Remove; unused.
11319 * dispextern.h (x_screen_planes): Remove decl.
11320
5bf46f05
PE
11321 * dispnew.c: Make symbols static if they're not exported.
11322 * dispextern.h (redraw_garbaged_frames, scrolling):
11323 (increment_row_positions): Remove.
11324 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11325 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11326 Now static.
11327 (redraw_garbaged_frames): Remove; unused.
11328
435f4c28
PE
11329 * xfaces.c: Make symbols static if they're not exported.
11330 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11331 Remove decls.
11332 * xterm.h (defined_color): Remove decls.
11333 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11334 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11335 (menu_face_changed_default, defined_color, free_realized_face):
11336 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11337 (ascii_face_of_lisp_face): Remove; unused.
11338
8524aef3
PE
11339 * xdisp.c: Make symbols static if they're not exported.
11340 * dispextern.h (scratch_glyph_row, window_box_edges):
11341 (glyph_to_pixel_coords, set_cursor_from_row):
11342 (get_next_display_element, set_iterator_to_next):
11343 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11344 (show_mouse_face): Remove decls
11345 * frame.h (message_buf_print): Likewise.
11346 * lisp.h (pop_message, set_message, check_point_in_composition):
11347 Likewise.
11348 * xterm.h (set_vertical_scroll_bar): Likewise.
11349 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11350 (message_buf_print, scratch_glyph_row, displayed_buffer):
11351 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11352 (get_next_display_element, show_mouse_face, window_box_edges):
11353 (frame_to_window_pixel_xy, check_point_in_composition):
11354 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11355 (glyph_to_pixel_coords): Remove; unused.
11356
16390cd2
PE
11357 * dired.c (file_name_completion): Now static.
11358
11359 * dbusbind.c (xd_in_read_queued_messages): Now static.
11360
a25f4dfa
PE
11361 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11362 * data.c (circular_list_error): Remove.
11363
14a9c8df
PE
11364 * commands.h (last_point_position, last_point_position_buffer):
11365 (last_point_position_window): Remove decls.
11366 * keyboard.c: Make these variables static.
11367
04f2d78b
CB
11368 * coding.h (coding, code_convert_region, encode_coding_gap):
11369 Remove decls.
74ab6df5
PE
11370 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11371 (iso_code_class, detect_coding, code_convert_region): Now static.
11372 (encode_coding_gap): Remove; unused.
11373
38dfbee1
PE
11374 * chartab.c (chartab_chars, chartab_bits): Now static.
11375
a2cb4e63
PE
11376 * charset.h (charset_iso_8859_1): Remove decl.
11377 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11378 Now static.
11379
127198fd
PE
11380 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11381 * ccl.c (Vccl_program_table): Now static.
11382 (check_ccl_update): Remove; unused.
11383
d85b608f
PE
11384 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11385 * category.h: ... from here.
11386 * category.c (check_category_table, set_category_set): Now static.
11387
31cd66f3
PE
11388 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11389 * lisp.h: Remove these decls.
11390
c358e587
PE
11391 * buffer.c (buffer_count): Remove unused var.
11392
e78aecca
PE
11393 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11394 so that it's not optimized away.
11395 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11396 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11397 exported only to the debugger.
11398
e192d7d3 11399 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11400 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11401
92470028
PE
11402 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11403 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11404 was inaccessible from Lisp.
11405 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11406 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11407
244ed907
PE
11408 alloc.c: Import and export fewer symbols, and remove unused items.
11409 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11410 is defined.
11411 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11412 it's not optimized away by whole-program optimization.
11413 (message_enable_multibyte, free_misc): Remove.
11414 (catchlist, handlerlist, mark_backtrace):
11415 Declare only if BYTE_MARK_STACK.
11416 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11417 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11418 (message_enable_multibyte): Remove decl.
11419 (free_misc, interval_free_list, float_block, float_block_index):
11420 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11421 (cons_free_list, last_marked_index):
11422 Now static.
11423 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11424 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11425 (mark_backtrace): Define only if BYTE_MARK_STACK.
11426 * xdisp.c (message_enable_multibyte): Now static.
11427
61c2b50e 11428 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11429 This makes it easier for human readers (and static analyzers)
11430 to see whether these variables are used from other modules.
11431 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11432 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11433 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11434 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11435 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11436 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11437 * xmenu.c, xselect.c:
11438 Declare Q* vars static if they are not used in other modules.
11439 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11440 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11441 Remove decls of unexported vars.
11442 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11443
95c82688
PE
11444 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11445
16a97296
PE
11446 Make Emacs functions such as Fatom 'static' by default.
11447 This makes it easier for human readers (and static analyzers)
11448 to see whether these functions can be called from other modules.
11449 DEFUN now defines a static function. To make the function external
11450 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11451 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11452 (Finit_image_library):
16a97296
PE
11453 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11454 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11455 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11456 Remove decls, since these functions are now static.
11457 (Funintern, Fget_internal_run_time): New decls, since these functions
11458 were already external.
95c82688 11459
16a97296
PE
11460 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11461 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11462 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11463 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11464 * keyboard.c, keymap.c, lread.c:
11465 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11466 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11467 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11468 Mark functions with DEFUE instead of DEFUN,
11469 if they are used in other modules.
11470 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11471 decls for now-static functions.
11472 * buffer.h (Fdelete_overlay): Remove decl.
11473 * callproc.c (Fgetenv_internal): Mark as internal.
11474 * composite.c (Fremove_list_of_text_properties): Remove decl.
11475 (Fcomposition_get_gstring): New forward static decl.
11476 * composite.h (Fcomposite_get_gstring): Remove decl.
11477 * dired.c (Ffile_attributes): New forward static decl.
11478 * doc.c (Fdocumntation_property): New forward static decl.
11479 * eval.c (Ffetch_bytecode): New forward static decl.
11480 (Funintern): Remove extern decl; now in .h file where it belongs.
11481 * fileio.c (Fmake_symbolic_link): New forward static decl.
11482 * image.c (Finit_image_library): New forward static decl.
11483 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11484 * intervals.h (Fprevious_property_change):
11485 (Fremove_list_of_text_properties): Remove decls.
11486 * keyboard.c (Fthis_command_keys): Remove decl.
11487 (Fcommand_execute): New forward static decl.
11488 * keymap.c (Flookup_key): New forward static decl.
11489 (Fcopy_keymap): Now static.
11490 * keymap.h (Flookup_key): Remove decl.
11491 * process.c (Fget_process): New forward static decl.
11492 (Fprocess_datagram_address): Mark as internal.
11493 * syntax.c (Fsyntax_table_p): New forward static decl.
11494 (skip_chars): Remove duplicate decl.
11495 * textprop.c (Fprevious_property_change): New forward static decl.
11496 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11497 Now internal.
11498 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11499 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11500
785bbd42
PE
11501 * editfns.c (Fformat): Remove unreachable code.
11502
8b913b57
AS
115032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11504
11505 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11506 change. (Bug#8496)
11507
a6744a35
EZ
115082011-04-13 Eli Zaretskii <eliz@gnu.org>
11509
11510 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11511 when at ZV. (Bug#8487)
11512
e7974947
AS
115132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11514
baad03f0
AS
11515 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11516 (Bug#8437)
11517 * keyboard.c (parse_tool_bar_item): Likewise.
11518 * sound.c (sound_cleanup, alsa_close): Likewise.
11519 * termcap.c (tgetent): Likewise.
11520 * xfns.c (x_default_font_parameter): Likewise.
11521 * xsettings.c (read_and_apply_settings): Likewise.
11522
e7974947
AS
11523 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11524 (overrun_check_free): Protoize.
11525
28272684
PE
115262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11527
11528 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11529 since callers should never pass a negative size.
11530 Change the signature to match that of plain 'read' and 'write'; see
11531 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11532 * lisp.h: Update prototypes of emacs_write and emacs_read.
11533
11997c76
EZ
115342011-04-11 Eli Zaretskii <eliz@gnu.org>
11535
11536 * xdisp.c (redisplay_window): Don't try to determine the character
11537 position of the scroll margin if the window start point w->startp
e896f03c 11538 is outside the buffer's accessible region. (Bug#8468)
11997c76 11539
8a2cbd72
EZ
115402011-04-10 Eli Zaretskii <eliz@gnu.org>
11541
11542 Fix write-region and its subroutines for buffers > 2GB.
11543 * fileio.c (a_write, e_write): Modify declaration of arguments and
11544 local variables to support buffers larger than 2GB.
11545 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11546
11547 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11548 argument, local variables, and return value.
11549
11550 * lisp.h: Update prototypes of emacs_write and emacs_read.
11551
11552 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11553
4073e537 115542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11555
1ebfdcb6
PE
11556 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11557
b2ded58d
PE
11558 Fix more problems found by GCC 4.6.0's static checks.
11559
7d66342c
PE
11560 * xdisp.c (vmessage): Use a better test for character truncation.
11561
bbf47d44
PE
11562 * charset.c (load_charset_map): <, not <=, for optimization,
11563 and to avoid potential problems with integer overflow.
9248994d 11564 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11565 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11566 * editfns.c (Fformat): Likewise.
1e69125e 11567 * syntax.c (skip_chars): Likewise.
3befa583 11568
e3019616
PE
11569 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11570 This also lets GCC 4.6.0 generate slightly better loop code.
11571
becfa255
PE
11572 * callint.c (Fcall_interactively): <, not <=, for optimization.
11573 (Fcall_interactively): Count the number of arguments produced,
11574 not the number of arguments given. This is simpler and lets GCC
11575 4.6.0 generate slightly better code.
11576
dae0cd48
PE
11577 * ftfont.c: Distingish more carefully between FcChar8 and char.
11578 The previous code passed unsigned char * to a functions like
11579 strlen and xstrcasecmp that expect char *, which does not
11580 conform to the C standard.
11581 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11582 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11583 char * when the C standard requires it.
11584
76032d70
PE
11585 * keyboard.c (read_char): Remove unused var.
11586
eb3f1cc8
PE
11587 * eval.c: Port to Windows vsnprintf (Bug#8435).
11588 Include <limits.h>.
11589 (SIZE_MAX): Define if the headers do not.
11590 (verror): Do not give up if vsnprintf returns a negative count.
11591 Instead, grow the buffer. This ports to Windows vsnprintf, which
11592 does not conform to C99. Problem reported by Eli Zaretskii.
11593 Also, simplify the allocation scheme, by avoiding the need for
11594 calling realloc, and removing the ALLOCATED variable.
11595
70476b54
PE
11596 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11597
12020a9e
PE
11598 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11599 But keep the doprint source code for now, as we might revamp it
11600 and use it again (Bug#8435).
ea6c7ae6
PE
11601 * lisp.h (doprnt): Remove.
11602 * Makefile.in (base_obj): Remove doprnt.o.
11603 * deps.mk (doprnt.o): Remove.
11604
5fdb398c
PE
11605 error: Print 32- and 64-bit integers portably (Bug#8435).
11606 Without this change, on typical 64-bit hosts error ("...%d...", N)
11607 was used to print both 32- and 64-bit integers N, which relied on
11608 undefined behavior.
61bdb816 11609 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11610 * lisp.h (error, verror): Mark as printf-like functions.
11611 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11612 Report overflow in size calculations when allocating printf buffer.
11613 Do not truncate output string at its first null byte.
11614 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11615 Truncate the output at a character boundary, since vsnprintf does not
11616 do that.
11617 * charset.c (check_iso_charset_parameter): Convert internal
11618 character to string before calling 'error', since %c now has the
11619 printf meaning.
11620 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11621 overflow when computing char to be passed to 'error'. Do not
11622 pass Lisp_Object to 'error'; pass the integer instead.
11623 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11624 formatted with plain %d.
11625
b189fa66
PE
11626 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11627
bff87ef0
PE
11628 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11629
7e2cac20
PE
11630 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11631
ce4d90b5
PE
11632 * xterm.c (x_catch_errors): Remove duplicate declaration.
11633
266c9547
PE
11634 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11635
79c49ad2
PE
11636 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11637
368f4090
JM
116382011-04-10 Jim Meyering <meyering@redhat.com>
11639
11640 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11641 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11642 return ssize_t not "int", and use size_t as the buffer length.
11643 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11644 * gnutls.h: Update declarations.
11645 * process.c (read_process_output): Use ssize_t, to match.
11646 (send_process): Likewise.
11647
a32d4040
CY
116482011-04-09 Chong Yidong <cyd@stupidchicken.com>
11649
11650 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11651
8546720e 116522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11653
04f2d78b
CB
11654 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11655 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11656
8546720e
GM
11657 * xterm.c (handle_one_xevent):
11658 * xmenu.c (create_and_show_popup_menu):
11659 * xselect.c (x_decline_selection_request)
11660 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11661
0a2f5c1a 116622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11663
11664 Fix some uses of `int' instead of EMACS_INT.
11665 * search.c (string_match_1, fast_string_match)
11666 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11667 (scan_buffer, find_next_newline_no_quit)
11668 (find_before_next_newline, search_command, Freplace_match)
11669 (Fmatch_data): Make some `int' variables be EMACS_INT.
11670
11671 * xdisp.c (display_count_lines): 3rd argument and return value now
11672 EMACS_INT. All callers changed.
11673 (pint2hrstr): Last argument is now EMACS_INT.
11674
11675 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11676 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11677 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11678 (decode_coding_utf_16, decode_coding_emacs_mule)
11679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11680 (decode_coding_ccl, decode_coding_charset)
11681 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11682 (decode_coding_iso_2022, decode_coding_emacs_mule)
11683 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11684 <char_offset, last_offset>: Declare EMACS_INT.
11685 (encode_coding_utf_8, encode_coding_utf_16)
11686 (encode_coding_emacs_mule, encode_invocation_designation)
11687 (encode_designation_at_bol, encode_coding_iso_2022)
11688 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11689 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11690 Declare EMACS_INT.
11691 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11692 (encode_invocation_designation): Last argument P_NCHARS is now
11693 EMACS_INT.
11694 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11695 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11696
11697 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11698 All users changed.
11699
11700 * ccl.c (Fccl_execute_on_string): Declare some variables
11701 EMACS_INT.
11702
8546720e 117032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11704
11705 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11706
4e19a977
CS
117072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11708
11709 * process.c (Fformat_network_address): Doc fix.
11710
87302331
R
117112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11712
ee7683eb 11713 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11714
cbb59342
CY
117152011-04-08 Chong Yidong <cyd@stupidchicken.com>
11716
11717 * keyboard.c (read_char): Call Lisp function help-form-show,
11718 instead of using internal_with_output_to_temp_buffer.
11719 (Qhelp_form_show): New var.
e0d38eeb 11720 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11721
11722 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11723
11724 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11725
e67a13ab
CY
117262011-04-06 Chong Yidong <cyd@stupidchicken.com>
11727
04f2d78b
CB
11728 * process.c (Flist_processes): Remove to Lisp.
11729 (list_processes_1): Delete.
e67a13ab 11730
973f782d
EZ
117312011-04-06 Eli Zaretskii <eliz@gnu.org>
11732
7c106b1e
EZ
11733 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11734
973f782d
EZ
11735 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11736
41cf7d1a 117372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11738
ca23cc88
PE
11739 Fix more problems found by GCC 4.6.0's static checks.
11740
f390e2d5
PE
11741 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11742
42eea0d0
PE
11743 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11744
b69769da 11745 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11746
f9541e84
PE
11747 * xdisp.c (vmessage): Mark as a printf-like function.
11748
13841b55
PE
11749 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11750
c136c10f
PE
11751 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11752
5e2d4a30
PE
11753 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11754 printf-like functions.
11755 (tiff_load): Add casts to remove these marks before passing them
11756 to system-supplied API.
11757
583f48b9
PE
11758 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11759
b25d760e
PE
11760 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11761 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11762 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11763 directly, rather than having caller test rule sign. This avoids
11764 some unnecessary tests.
11765 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11766 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11767 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11768
bc7b6697 11769 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11770 (xfont_open): Avoid unnecessary tests.
bc7b6697 11771
27ccc379
PE
11772 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11773
dcd5c89a
PE
11774 * composite.h, composite.c (composition_gstring_put_cache):
11775 Use EMACS_INT, not int, for length.
11776
b13a45c6
PE
11777 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11778 breaking out part of COMPOSITION_DECODE_RULE.
11779 (COMPOSITION_DECODE_RULE): Use it.
11780 * composite.c (get_composition_id): Remove unused local vars,
11781 by using the new macro.
11782
1e792e4d
PE
11783 * textprop.c (set_text_properties_1): Change while to do-while,
11784 since the condition is always true at first.
11785
dc6c6455 11786 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11787 (interval_deletion_adjustment): Return unsigned value.
11788 All uses changed.
dc6c6455 11789
aba7731a
PE
11790 * process.c (list_processes_1, create_pty, read_process_output):
11791 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11792 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11793 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11794 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11795 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11796
fdfc4bf3
PE
11797 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11798
fca8fe46 11799 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11800 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11801
06a0259a 11802 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11803 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11804 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11805
e7b9e80f
PE
11806 * print.c (print_error_message): Avoid int overflow.
11807
56201685
PE
11808 * font.c (font_list_entities): Redo for clarity,
11809 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11810
78834453 11811 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11812 (font_score): Avoid potential overflow in diff calculation.
78834453 11813
0bc0b309 11814 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11815 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11816
e610eaca
PE
11817 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11818
b895abce
PE
11819 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11820 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11821 can always succeed if overflow has undefined behavior.
11822
1f1d9321 11823 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11824 (wordify): Omit three unnecessary tests.
1f1d9321 11825
c59478bc
PE
11826 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11827 All callers changed. This avoids the need for an unused var.
11828
79b73827
PE
11829 * casefiddle.c (casify_region): Remove var that is set but not used.
11830
a4db5dfe
PE
11831 * dired.c (file_name_completion): Remove var that is set but not used.
11832
43aae36e
PE
11833 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11834
2a47c44d 11835 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11836 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11837
a37c69bf
PE
11838 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11839 Check for integer overflow on size calculations.
11840
328ab8e7
PE
11841 * buffer.c (Fprevious_overlay_change): Remove var that is set
11842 but not used.
11843
e5a2a5cb
PE
11844 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11845 Remove vars that are set but not used.
8d84a6eb 11846 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11847 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11848
a60e5f68
PE
11849 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11850
f661cb61 11851 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11852 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11853
f0397f5a
PE
11854 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11855 that are set but not used.
11856
8664db06 11857 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11858 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11859
6abdaa4a
PE
11860 * xselect.c (x_get_local_selection, x_handle_property_notify):
11861 Remove vars that are set but not used.
11862
0ce7538d 11863 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11864 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11865
9ae848fc
PE
11866 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11867 Remove var that is set but not used.
0b918413
PE
11868 (scroll_bar_windows_size): Now size_t, not int.
11869 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11870 Check for overflow.
9ae848fc 11871
a5a62657
PE
11872 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11873 (map_tty_color) [!defined MSDOS]: Likewise.
11874
5c5cdd39
PE
11875 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11876
66ebf983
PE
11877 * coding.c: Remove vars that are set but not used.
11878 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11879 All callers changed.
11880 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11881 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11882 (decode_coding_charset): Remove vars that are set but not used.
11883
1be4d761
PE
11884 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11885 that is set but not used.
11886
47553fa8
PE
11887 * print.c (print_object): Remove var that is set but not used.
11888
1f7196bf 11889 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11890 The gnulib version avoids calling malloc in the usual case,
11891 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11892 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11893 * filelock.c (current_lock_owner): Likewise.
11894 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11895 * sysdep.c: Include allocator.h, careadlinkat.h.
11896 (emacs_no_realloc_allocator): New static constant.
11897 (emacs_readlink): New function.
fdb61804
PE
11898 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11899 ../lib/careadlinkat.h.
d1fdcab7 11900
f84c17c7
SM
119012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11902
11903 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11904 first non-nil return value).
11905
ef3862ad
JD
119062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11907
11908 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11909 if not defined (Bug#8403).
11910
376a7006
JB
119112011-04-02 Juanma Barranquero <lekktu@gmail.com>
11912
11913 * xdisp.c (display_count_lines): Remove parameter `start',
11914 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11915 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11916 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11917 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11918 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11919 and thereabouts. All callers changed.
11920 (get_per_char_metric): Remove parameter `f', unused since
11921 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11922
6ca3801d
JM
119232011-04-02 Jim Meyering <meyering@redhat.com>
11924
11925 do not dereference NULL upon failed strdup
11926 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11927 (ns_get_family): Likewise.
11928
d8e2b5ba
JB
119292011-04-02 Juanma Barranquero <lekktu@gmail.com>
11930
11931 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11932
8c74fcbd
JD
119332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11934
11935 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11936 later (Bug#8403).
11937
7200d79c
SM
119382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11939
03408648 11940 Add lexical binding.
7200d79c 11941
03408648
SM
11942 * window.c (Ftemp_output_buffer_show): New fun.
11943 (Fsave_window_excursion):
11944 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11945
11946 * lread.c (lisp_file_lexically_bound_p): New function.
11947 (Fload): Bind Qlexical_binding.
11948 (readevalloop): Remove `evalfun' arg.
11949 Bind Qinternal_interpreter_environment.
11950 (Feval_buffer): Bind Qlexical_binding.
11951 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11952 Mark as dynamic.
11953 (syms_of_lread): Declare `lexical-binding'.
11954
11955 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11956
11957 * keyboard.c (eval_dyn): New fun.
11958 (menu_item_eval_property): Use it.
ca105506
SM
11959
11960 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11961
03408648
SM
11962 * fns.c (concat, mapcar1): Accept byte-code-functions.
11963
11964 * eval.c (Fsetq): Handle lexical vars.
11965 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11966 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11967 (FletX, Flet): Obey lexical binding.
11968 (Fcommandp): Handle closures.
11969 (Feval): New `lexical' arg.
11970 (eval_sub): New function extracted from Feval. Use it almost
11971 everywhere where Feval was used. Look up vars in lexical env.
11972 Handle closures.
11973 (Ffunctionp): Move from subr.el.
11974 (Ffuncall): Handle closures.
11975 (apply_lambda): Remove `eval_flags'.
11976 (funcall_lambda): Handle closures and new byte-code-functions.
11977 (Fspecial_variable_p): New function.
11978 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11979 but without exporting it to Lisp.
23aba0ea 11980
23aba0ea 11981 * doc.c (Fdocumentation, store_function_docstring):
03408648 11982 * data.c (Finteractive_form): Handle closures.
23aba0ea 11983
03408648
SM
11984 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11985 interactive spec.
ba83908c 11986
04f2d78b
CB
11987 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11988 New byte-codes.
03408648
SM
11989 (exec_byte_code): New function extracted from Fbyte_code to handle new
11990 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11991
03408648 11992 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11993
03408648 11994 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11995
e2abce01
JB
119962011-03-31 Juanma Barranquero <lekktu@gmail.com>
11997
11998 * xdisp.c (redisplay_internal): Fix prototype.
11999
63696a73 120002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12001
63696a73 12002 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12003 (try_scrolling): Use it when setting scroll_limit.
12004 Limit scrolling to 100 screen lines.
63696a73
EZ
12005 (redisplay_window): Even when falling back on "recentering",
12006 position point in the window according to scroll-conservatively,
12007 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12008
12009 (try_scrolling): When point is above the window, allow searching
12010 as far as scroll_max, or one screenful, to compute vertical
12011 distance from PT to the scroll margin position. This prevents
12012 try_scrolling from unnecessarily failing when
12013 scroll-conservatively is set to a value slightly larger than the
12014 window height. Clean up the case of PT below the margin at bottom
12015 of window: scroll_max can no longer be INT_MAX. When aggressive
12016 scrolling is in use, don't let point enter the opposite scroll
12017 margin as result of the scroll.
12018 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12019 threshold of 100 lines for never-recentering scrolling.
12020
e4cc2dfc
JB
120212011-03-31 Juanma Barranquero <lekktu@gmail.com>
12022
12023 * dispextern.h (move_it_by_lines):
12024 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12025 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12026 (message_log_check_duplicate): Remove parameters `prev_bol' and
12027 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12028 (redisplay_internal): Remove parameter `preserve_echo_area',
12029 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12030
12031 * indent.c (Fvertical_motion):
12032 * window.c (window_scroll_pixel_based, Frecenter):
12033 Don't pass `need_y_p' to `move_it_by_lines'.
12034
1c470562
SM
120352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12036
44f230aa
SM
12037 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12038 steal a few bits to be more compact.
12039 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12040 Remove unneeded casts.
12041
1c470562
SM
12042 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12043
888adce9
ZK
120442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12045
12046 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12047 binding" message (bug#7967).
12048
f838ed7b
PE
120492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12050
77861b95
PE
12051 Fix more problems found by GCC 4.6.0's static checks.
12052
de6dbc14
PE
12053 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12054 Remove unused local var.
12055
f838ed7b
PE
12056 * editfns.c (Fmessage_box): Remove unused local var.
12057
792c7b2b
PE
12058 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12059 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12060 Omit unused local vars.
c499e557 12061 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12062 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12063 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12064 Omit unused local var.
12065
ba0165e1
PE
12066 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12067 Don't assume string length fits in int.
32ad8845 12068 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12069 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12070
3c59b4c9
PE
12071 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12072 instead of alloca (Bug#8344).
12073
a3eed478 12074 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12075 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12076
eb4d412d
PE
12077 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12078
1658b401
PE
12079 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12080 concerns.
12081
12082 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12083
12084 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12085
9a2c6e05
PE
12086 * keyboard.c (syms_of_keyboard): Use the same style as later
12087 in this function when indexing through an array. This also
12088 works around GCC bug 48267.
12089
03d0a109
PE
12090 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12091
44f730c8
PE
12092 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12093
fe75f926
PE
12094 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12095 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12096
ffa8c828
PE
12097 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12098 This avoids undefined behavior on integer overflow, and is a bit
12099 more convenient anyway since it is compared to a size_t variable.
12100
c5101a77
PE
12101 Variadic C functions now count arguments with size_t, not int.
12102 This avoids an unnecessary limitation on 64-bit machines, which
12103 caused (substring ...) to crash on large vectors (Bug#8344).
12104 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12105 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12106 All variadic functions and their callers changed accordingly.
c5101a77
PE
12107 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12108 * data.c (arith_driver, float_arith_driver): Likewise.
12109 * editfns.c (general_insert_function): Likewise.
12110 * eval.c (struct backtrace.nargs, interactive_p)
12111 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12112 (funcall_lambda, mark_backtrace): Likewise.
12113 * fns.c (concat): Likewise.
12114 * frame.c (x_set_frame_parameters): Likewise.
12115 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12116 0 if not found, not -1. All callers changed.
12117
dd3f25f7
PE
12118 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12119 (stack_copy_size): Now size_t, not int.
12120 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12121
461c2ab9
JB
121222011-03-28 Juanma Barranquero <lekktu@gmail.com>
12123
12124 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12125 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12126 All callers changed.
12127
12128 * lisp.h (multibyte_char_to_unibyte):
12129 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12130 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12131 * character.h (CHAR_TO_BYTE8):
12132 * cmds.c (internal_self_insert):
12133 * editfns.c (general_insert_function):
12134 * keymap.c (push_key_description):
12135 * search.c (Freplace_match):
12136 * xdisp.c (message_dolog, set_message_1): All callers changed.
12137
f6d62986
SM
121382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12139
12140 * keyboard.c (safe_run_hook_funcall): New function.
12141 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12142 don't set the hook to nil, but remove the offending function instead.
12143 (Qcommand_hook_internal): Remove, unused.
12144 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12145 Vcommand_hook_internal.
12146
12147 * eval.c (enum run_hooks_condition): Remove.
12148 (funcall_nil, funcall_not): New functions.
12149 (run_hook_with_args): Call each function through a `funcall' argument.
12150 Remove `cond' argument, now redundant.
12151 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12152 (Frun_hook_with_args_until_failure): Adjust accordingly.
12153 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12154
1db5b1ad
JB
121552011-03-28 Juanma Barranquero <lekktu@gmail.com>
12156
12157 * dispextern.h (string_buffer_position): Remove declaration.
12158
12159 * print.c (strout): Remove parameter `multibyte', unused since
12160 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12161
12162 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12163 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12164 All callers changed.
12165
12166 * w32.c (_wsa_errlist): Use braces for struct initializers.
12167
12168 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12169 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12170 All callers changed.
12171 (string_buffer_position): Likewise. Also, make static (it's never
12172 used outside xdisp.c).
12173 (cursor_row_p): Remove parameter `w', unused since
12174 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12175 (decode_mode_spec): Remove parameter `precision', introduced during
12176 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12177 All callers changed.
12178
5ffb62aa
JD
121792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12180
12181 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12182
461c2ab9 121832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12184
12185 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12186 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12187 (ns_update_auto_hide_menu_bar): New functions.
12188 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12189 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12190 ns_constrain_all_frames.
12191 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12192 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12193
5c380ffb
JD
121942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12195
12196 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12197
9af30bdf
GM
121982011-03-27 Glenn Morris <rgm@gnu.org>
12199
12200 * syssignal.h: Replace RETSIGTYPE with void.
12201 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12202 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12203 Replace SIGTYPE with void everywhere.
12204 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12205 * s/template.h (SIGTYPE): Remove commented out definition.
12206
e2abce01
JB
122072011-03-26 Eli Zaretskii <eliz@gnu.org>
12208
12209 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12210 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12211
f868cd8a
JB
122122011-03-26 Juanma Barranquero <lekktu@gmail.com>
12213
59eb0929
JB
12214 * w32.c (read_unc_volume): Use parameter `henum', instead of
12215 global variable `wget_enum_handle'.
12216
12217 * keymap.c (describe_vector): Remove parameters `indices' and
12218 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12219 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12220
f868cd8a
JB
12221 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12222
12223 * keyboard.c (timer_check): Remove parameter `do_it_now',
12224 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12225 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12226 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12227
12228 * keyboard.c (read_char):
12229 * w32menu.c (w32_menu_display_help):
12230 * xmenu.c (show_help_event, menu_help_callback):
12231 Adjust calls to `show_help_echo'.
12232
12233 * gtkutil.c (xg_maybe_add_timer):
12234 * keyboard.c (readable_events):
12235 * process.c (wait_reading_process_output):
12236 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12237
12238 * insdel.c (adjust_markers_gap_motion):
12239 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12240 (gap_left, gap_right): Don't call it.
12241
2ecf6fdb
CY
122422011-03-25 Chong Yidong <cyd@stupidchicken.com>
12243
12244 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12245 incurred during fontification.
12246
6b1f9ba4
JB
122472011-03-25 Juanma Barranquero <lekktu@gmail.com>
12248
12249 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12250 (DEFVAR_PER_BUFFER): Don't pass it.
12251
12252 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12253 (scrolling_window): Don't pass it.
12254
0f4a96b5
JB
122552011-03-25 Juanma Barranquero <lekktu@gmail.com>
12256
12257 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12258
12259 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12260 and `suffix'.
12261 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12262 of variables specific to SELinux and computation of `encoded_absname'.
12263
12264 * image.c (XPutPixel): Remove unused variable `height'.
12265
12266 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12267
12268 * unexw32.c (get_section_info): Remove unused variable `section'.
12269
12270 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12271 (system_process_attributes): Remove unused variable `sess'.
12272 (sys_read): Remove unused variable `err'.
12273
12274 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12275 (w32_wnd_proc): Remove unused variable `isdead'.
12276 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12277 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12278 (x_create_tip_frame): Remove unused variable `tem'.
12279
12280 * w32inevt.c (w32_console_read_socket):
12281 Remove unused variable `no_events'.
12282
12283 * w32term.c (x_draw_composite_glyph_string_foreground):
12284 Remove unused variable `width'.
12285
1149507c
JB
122862011-03-24 Juanma Barranquero <lekktu@gmail.com>
12287
12288 * w32term.c (x_set_glyph_string_clipping):
12289 Don't pass uninitialized region to CombineRgn.
12290
9c88f339
JB
122912011-03-23 Juanma Barranquero <lekktu@gmail.com>
12292
12293 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12294 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12295 (Fx_close_connection): Remove unused variable `i'.
12296
12297 * w32font.c (w32font_draw): Return number of glyphs.
12298 (w32font_open_internal): Remove unused variable `i'.
12299 (w32font_driver): Add missing initializer.
12300
12301 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12302 (fill_in_menu): Remove unused variable `items_added'.
12303
12304 * w32term.c (last_mouse_press_frame): Remove static global variable.
12305 (w32_clip_to_row): Remove unused variable `f'.
12306 (x_delete_terminal): Remove unused variable `i'.
12307
12308 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12309 (NOTHING): Remove unused static global variable.
12310 (uniscribe_check_otf): Remove unused variable `table'.
12311 (uniscribe_font_driver): Add missing initializers.
12312
dee091a3
JD
123132011-03-23 Julien Danjou <julien@danjou.info>
12314
12315 * term.c (Fsuspend_tty, Fresume_tty):
12316 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12317 * window.c (temp_output_buffer_show):
12318 * insdel.c (signal_before_change):
12319 * frame.c (Fhandle_switch_frame):
12320 * fileio.c (Fdo_auto_save):
12321 * emacs.c (Fkill_emacs):
12322 * editfns.c (save_excursion_restore):
12323 * cmds.c (internal_self_insert):
12324 * callint.c (Fcall_interactively):
12325 * buffer.c (Fkill_all_local_variables):
12326 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12327 Use Frun_hooks.
0f4a96b5 12328 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12329 unconditionally since it does the check itself.
dee091a3 12330
2c520ab5 123312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12332
c9c49752
PE
12333 Fix more problems found by GCC 4.5.2's static checks.
12334
8abc3f12
PE
12335 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12336 the first time through the loop, since we know p0 < p1 then.
12337 This also avoids a gcc -Wstrict-overflow warning.
12338
a2d26660
PE
12339 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12340 leading to a memory leak, possible in functions like
12341 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12342 of objects (Bug#8318).
a2d26660 12343
916c72e9
PE
12344 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12345 that could (at least in theory) be that large.
12346
19ab8a18
PE
12347 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12348 This is less likely to overflow, and avoids undefined behavior if
12349 overflow does occur. All callers changed. Use strtoul to scan
12350 for the unsigned long integer.
b7cbbd6f
PE
12351 (pint2hrstr): Simplify and tune code slightly.
12352 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12353
f0641eff
PE
12354 * scroll.c (do_scrolling): Work around GCC bug 48228.
12355 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12356
7f650bb9
PE
12357 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12358 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12359 (validate_x_resource_name): Simplify count usage.
12360 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12361
37dd57d1
PE
12362 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12363 fail (Bug#8306).
81e56e61 12364
699979fc 12365 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12366
401bf9b4
PE
12367 * process.c (Fmake_network_process): Use socklen_t, not int,
12368 where POSIX says socklen_t is required in portable programs.
12369 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12370 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12371 (Fmake_network_process, server_accept_connection):
12372 (wait_reading_process_output, read_process_output):
12373 Likewise.
12374
b93aacde
PE
12375 * process.c: Rename or move locals to avoid shadowing.
12376 (list_processes_1, Fmake_network_process):
12377 (read_process_output_error_handler, exec_sentinel_error_handler):
12378 Rename or move locals.
4dc343ee 12379 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12380 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12381 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12382 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12383 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12384
af8a867c 12385 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12386 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12387 Include tparam.h instead, since it declares them.
af8a867c
PE
12388 * cm.h (PC): Remove extern decl; tparam.h now does this.
12389 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12390 * terminfo.c: Include tparam.h, to check interfaces.
12391 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12392 (tparam): Adjust signature to match interface in tparam.h;
12393 this removes some undefined behavior. Check that outstring and len
12394 are zero, which they always are with Emacs.
12395 * tparam.h (PC, BC, UP): New extern decls.
12396
0248044d 12397 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12398 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12399
8ff096c1 12400 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12401 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12402 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12403 (ftfont_list): Remove unused local.
49eaafba
PE
12404 (get_adstyle_property, ftfont_pattern_entity):
12405 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12406 Rename locals to avoid shadowing.
8ff096c1 12407
e2be39f6
PE
12408 * xfont.c (xfont_list_family): Mark var as initialized.
12409
c9735e30
PE
12410 * xml.c (make_dom): Now static.
12411
8f5201ae
PE
12412 * composite.c (composition_compute_stop_pos): Rename local to
12413 avoid shadowing.
b246f932
PE
12414 (composition_reseat_it): Remove unused locals.
12415 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12416 (composition_update_it): Mark var as initialized.
11b61122
PE
12417 (find_automatic_composition): Mark vars as initialized,
12418 with a FIXME (Bug#8290).
8f5201ae 12419
760fbc2c
PE
12420 character.h: Rename locals to avoid shadowing.
12421 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12422 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12423 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12424 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12425 to avoid shadowing.
12426
ff08eb85
PE
12427 * textprop.c (property_change_between_p): Remove; unused.
12428
fc7bf025
PE
12429 * intervals.c (interval_start_pos): Now static.
12430
235d7abc
PE
12431 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12432
44f230aa
SM
12433 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12434 Rename locals to avoid shadowing.
3e7d6594 12435
50060332
PE
12436 * sound.c (wav_play, au_play, Fplay_sound_internal):
12437 Fix pointer signedness.
d01f234b 12438 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12439 (wav_play): Initialize a variable to 0, to prevent undefined
12440 behavior (Bug#8278).
50060332 12441
c4fc4e30
PE
12442 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12443
918436ed
PE
12444 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12445
c939f91b
PE
12446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12447 clobbering (Bug#8298).
b9c7f648
PE
12448 * sysdep.c (sys_subshell): Likewise.
12449 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12450
6bd8c144
PE
12451 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12452 This should get cleaned up, so that child_setup has the
12453 same signature on all platforms.
12454
7710357c 12455 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12456 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12457
c59da222
CY
124582011-03-22 Chong Yidong <cyd@stupidchicken.com>
12459
12460 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12461 not to be necessary, and produces flickering.
12462
66b87493
GM
124632011-03-20 Glenn Morris <rgm@gnu.org>
12464
12465 * config.in: Remove file.
12466
45b6f6d5
JB
124672011-03-20 Juanma Barranquero <lekktu@gmail.com>
12468
12469 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12470 are now in src/globals.h.
12471 (syms_of_minibuf): Remove spurious & from previous change.
12472
cd394be1 124732011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12474
12475 * minibuf.c (completing-read-function): New variable.
12476 (completing-read-default): Rename from completing-read.
12477 (completing-read): Call completing-read-function.
12478
b14e3e21
CY
124792011-03-19 Juanma Barranquero <lekktu@gmail.com>
12480
12481 * xfaces.c (Fx_load_color_file):
12482 Read color file from absolute filename (bug#8250).
12483
f2b726e6
JB
124842011-03-19 Juanma Barranquero <lekktu@gmail.com>
12485
12486 * makefile.w32-in: Update dependencies.
12487
09f6ff02
EZ
124882011-03-17 Eli Zaretskii <eliz@gnu.org>
12489
12490 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12491
29a6015a
PE
124922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12493
a3a6c54e
PE
12494 Fix more problems found by GCC 4.5.2's static checks.
12495
b766f867
PE
12496 * process.c (make_serial_process_unwind, send_process_trap):
12497 (sigchld_handler): Now static.
12498
be02381c
PE
12499 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12500 That way, the code declares only the vars that it needs.
12501 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12502 * s/cygwin.h (PTY_ITERATION): Likewise.
12503 * s/darwin.h (PTY_ITERATION): Likewise.
12504 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12505
57048744
PE
12506 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12507 * process.c (allocate_pty): Don't declare stb unless it's needed.
12508
7914961c 12509 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12510 (CONSTANTLIM): Remove; unused.
12511 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12512 Define only if needed.
7914961c 12513
b3967b18
PE
12514 * unexelf.c (unexec): Name an expression,
12515 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12516 Use a different way to cause a compilation error if anyone uses
12517 n rather than nn, a way that does not involve shadowing.
73366a00 12518 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12519
29a6015a
PE
12520 * deps.mk (unexalpha.o): Remove; unused.
12521
43cfc33e 12522 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12523 * unexec.h: New file.
ce701a33
PE
12524 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12525 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12526 Depend on unexec.h.
12527 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12528 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12529 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12530 Change as necessary to match prototype in unexec.h.
ce701a33 12531
01f44d5a
PE
12532 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12533 shadowing.
4f63c6bb 12534 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12535
a6670b0b
PE
12536 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12537 Rename locals to avoid shadowing.
12538
cef2010d 12539 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12540 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12541
d4d7173a
PE
12542 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12543
f08b802a
PE
12544 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12545 warning when compiling print.c.
12546
3ddb0639
PE
12547 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12548 instead of using an uninitialized var.
5ad03b97 12549 (font_sort_entities): Mark var as initialized.
3ddb0639 12550
170a2692
PE
12551 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12552
e663c700
PE
12553 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12554 pointers to constants.
89bc529a 12555 (font_parse_fcname): Remove unused vars.
7b81e2d0 12556 (font_delete_unmatched): Now static.
ea838e10 12557 (font_get_spec): Remove; unused.
13a547c6
PE
12558 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12559 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12560 Rename or move locals to avoid shadowing.
e663c700 12561
2a80c887 12562 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12563 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12564
1384fa33 12565 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12566 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12567
8b2c52e9
PE
12568 * alloc.c (mark_backtrace): Move decl from here ...
12569 * lisp.h: ... to here, so that it can be checked.
12570
475545b5 12571 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12572 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12573 (lisp_indirect_variable): Name an expression,
12574 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12575 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12576
b1349114 12577 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12578 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12579 Use const pointer when appropriate.
b1349114 12580
a2928364
PE
12581 * lisp.h (get_system_name, get_operating_system_release):
12582 Move decls here, to check interfaces.
12583 * process.c (get_operating_system_release): Move decl to lisp.h.
12584 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12585 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12586 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12587 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12588 (Fformat_time_string, Fencode_time, Finsert_char):
12589 (Ftranslate_region_internal, Fformat):
12590 Rename or remove local vars to avoid shadowing.
9710023e 12591 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12592
a415e694
PE
12593 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12594 avoid shadowing.
12595
8ef4622d
PE
12596 * lisp.h (eassert): Check that the argument compiles, even if
12597 ENABLE_CHECKING is not defined.
12598
946f9a5b
PE
12599 * data.c (Findirect_variable): Name an expression, to avoid
12600 gcc -Wbad-function-cast warning.
112396d6 12601 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12602 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12603 (Fmake_variable_buffer_local, Fmake_local_variable):
12604 Mark variables as initialized.
52746918 12605 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12606
e5aab7e7 12607 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12608 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12609 Rename locals to avoid shadowing.
dff45157
PE
12610 (mark_stack): Move local variables into the #ifdef region where
12611 they're used.
7bc26fdb
PE
12612 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12613 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12614 needed otherwise.
12615 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12616 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12617 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12618
e5aab7e7
PE
12619 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12620 avoids undefined behavior in theory.
12621
4da60324
PE
12622 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12623
88043301
PE
12624 Use functions, not macros, for up- and down-casing (Bug#8254).
12625 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12627 to use the following functions instead of these macros.
12628 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12629 EMACS_INT, since callers assume the returned value fits in int.
12630 (upcase1): Likewise, for UPCASE_TABLE.
12631 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12632 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12633 the race-condition problem in the old DOWNCASE.
88043301 12634
19ed5445
PE
12635 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12636 Rename locals to avoid shadowing.
12637 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12638 (regex_compile, re_search_2, re_match_2_internal):
12639 Remove unused local vars.
952db0d7
PE
12640 (FREE_VAR): Rewrite so as not to use empty "else",
12641 which gcc can warn about.
da053e48 12642 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12643 (RETALLOC_IF): Define only if needed.
12644 (WORDCHAR_P): Likewise. This one is never needed, but is used
12645 only in a comment talking about a compiler bug, so put inside
12646 the #if 0 of that comment.
12647 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12648 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12649 Remove; unused.
19ed5445 12650
1f3561e4 12651 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12652 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12653 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12654
ded6f8f7
PE
12655 * search.c (simple_search): Remove unused var.
12656
dbd37a95
PE
12657 * dired.c (compile_pattern): Move decl from here ...
12658 * lisp.h: ... to here, so that it can be checked.
12659 (struct re_registers): New forward decl.
12660
7e47afad
PE
12661 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12662
85f24f61
PE
12663 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12664 All uses changed.
12665 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12666 Rename locals to avoid shadowing.
5671df8f 12667 (Fvertical_motion): Mark locals as initialized.
85f24f61 12668
181aa2be 12669 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12670 (casify_region): Mark local as initialized.
181aa2be 12671
930d429c
PE
12672 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12673
7082eac6
PE
12674 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12675 New macros, so that the caller can use some names other than
12676 gcpro1, gcpro2, etc.
12677 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12678 of the new macros.
12679 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12680 argument, for consistency with GCPRO2_VAR, etc: it is now the
12681 prefix of the variable, not the variable itself. All uses
12682 changed.
38b2c076
PE
12683 * dired.c (directory_files_internal, file_name_completion):
12684 Rename locals to avoid shadowing.
12685
15206ed9
PE
12686 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12687 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12688 dired.c's scmp function, had undefined behavior.
12689 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12691 * buffer.h: ... to here, because these macros use current_buffer,
12692 and the new implementation with inline functions needs to have
12693 current_buffer in scope now, rather than later when the macros
12694 are used.
12695 (downcase, upcase1): New static inline functions.
12696 (DOWNCASE, UPCASE1): Reimplement using these functions.
12697 This avoids undefined behavior in expressions like
12698 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12699 from race conditions in accessing the global variables
12700 case_temp1 and case_temp2.
12701 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12702 * lisp.h (case_temp1, case_temp2): Remove their decls.
12703 * character.h (ASCII_CHAR_P): Move from here ...
12704 * lisp.h: ... to here, so that the inline functions mentioned
12705 above can use them.
12706
4a6bea26
PE
12707 * dired.c (directory_files_internal_unwind): Now static.
12708
f14b7e14
PE
12709 * fileio.c (file_name_as_directory, directory_file_name):
12710 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12711 Now static.
2893f146
PE
12712 (file_name_as_directory): Use const pointers when appropriate.
12713 (Fexpand_file_name): Likewise. In particular, newdir might
12714 point at constant storage, so make it a const pointer.
fd4ead52 12715 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12716 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12717 signedness issues.
f839df0c
PE
12718 (Fset_file_times, Finsert_file_contents, auto_save_error):
12719 Rename locals to avoid shadowing.
f14b7e14 12720
5716756e 12721 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12722 (Ftry_completion, Fall_completions): Rename or remove locals
12723 to avoid shadowing.
5716756e 12724
b4c3046a
PE
12725 * marker.c (bytepos_to_charpos): Remove; unused.
12726
b45db522
PE
12727 * lisp.h (verify_bytepos, count_markers): New decls,
12728 so that gcc does not warn that these functions aren't declared.
12729
85876d07
PE
12730 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12731 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12732 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12733 (copy_text): Remove unused local var.
85876d07 12734
03d78a21 12735 * filelock.c (within_one_second): Now static.
b3dd38ab 12736 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12737
5df8f01b
PE
12738 * buffer.c (fix_overlays_before): Mark locals as initialized.
12739 (fix_start_end_in_overlays): Likewise. This function should be
12740 simplified by using pointers-to-pointers, but that's a different
12741 matter.
b1d876f1 12742 (switch_to_buffer_1): Now static.
8f54f30a
PE
12743 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12744 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12745
a70072c9 12746 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12747 Fix pointer signedness issue.
edced198
PE
12748 (sys_subshell): Mark local as volatile if checking for lint,
12749 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12750 (MAXPATHLEN): Define only if needed.
a70072c9 12751
a0977c44
PE
12752 * process.c (serial_open, serial_configure): Move decls from here ...
12753 * systty.h: ... to here, so that they can be checked.
12754
a884fdcc
PE
12755 * fns.c (get_random, seed_random): Move extern decls from here ...
12756 * lisp.h: ... to here, so that they can be checked.
12757
604efe86 12758 * sysdep.c (reset_io): Now static.
b8950c94 12759 (wait_for_termination_signal): Remove; unused.
604efe86 12760
38fc62d9
PE
12761 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12762 (copy_keymap_item, append_key, push_text_char_description):
12763 Now static.
1004a21a 12764 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12765 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12766 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12767 (describe_map_tree):
12768 Rename locals to avoid shadowing.
38fc62d9 12769
2f2650da
PE
12770 * keyboard.c: Declare functions static if they are not used elsewhere.
12771 (echo_char, echo_dash, cmd_error, top_level_2):
12772 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12773 (read_char, kbd_buffer_get_event, make_lispy_position):
12774 (make_lispy_event, make_lispy_movement, apply_modifiers):
12775 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12776 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12777 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12778 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12779 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12780
a053e86c 12781 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12782 (mark_kboards): Move decl here ...
12783 * alloc.c (mark_kboards): ... from here.
a053e86c 12784
4752793e
PE
12785 * lisp.h (force_auto_save_soon): New decl.
12786
74f10ca7 12787 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12788 (DEFINE_DUMMY_FUNCTION): New macro.
12789 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12790 Use it.
c03cd23f
PE
12791 (main): Add casts to avoid warnings
12792 if GCC considers string literals to be constants.
74f10ca7 12793
022e70d4
PE
12794 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12795
59d6fe83
PE
12796 * dbusbind.c: Pointer signedness fixes.
12797 (xd_signature, xd_append_arg, xd_initialize):
12798 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12800 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12801 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12802
78320123
PE
12803 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12804 if GCC considers string literals to be constants.
49cebcca 12805 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12806
35ac2a97
SM
128072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12808
fb103ca9
SM
12809 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12810 (print_preprocess, print_object): New macro to fix last change.
12811
35ac2a97
SM
12812 * print.c (print_preprocess): Don't forget font objects.
12813
62973b41
JB
128142011-03-16 Juanma Barranquero <lekktu@gmail.com>
12815
12816 * emacs.c (USAGE3): Doc fixes.
12817
0e48bb22
AS
128182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12819
12820 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12821 structure.
12822
7684e57b
JB
128232011-03-14 Juanma Barranquero <lekktu@gmail.com>
12824
12825 * lisp.h (VWindow_system, Qfile_name_history):
12826 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12827 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12828 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12829
12830 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12831 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12832
12833 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12834 * w32console.c (detect_input_pending, read_input_pending)
12835 (encode_terminal_code):
12836 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12837 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12838 (w32_system_caret_y, Qfile_name_history):
12839 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12840 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12841 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12842 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12843 * w32proc.c (Qlocal, report_file_error):
12844 * w32term.c (Vwindow_system, updating_frame):
12845 * w32uniscribe.c (initialized, uniscribe_font_driver):
12846 Remove unneeded extern declarations.
12847
2aa46d6c
CY
128482011-03-14 Chong Yidong <cyd@stupidchicken.com>
12849
c96bbc66 12850 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12851
cffc6f3b
CY
128522011-03-13 Chong Yidong <cyd@stupidchicken.com>
12853
12854 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12855 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12856 These macros can no longer be used for assignment.
12857
44f230aa
SM
12858 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12859 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12860 (record_buffer_markers, fetch_buffer_markers): New functions for
12861 recording and fetching special buffer markers.
12862 (set_buffer_internal_1, set_buffer_temp): Use them.
12863
12864 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12865
12866 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12867
12868 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12869 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12870
12871 * xdisp.c (hscroll_window_tree):
12872 (reconsider_clip_changes): Use PT instead of BUF_PT.
12873
d251f04b
EZ
128742011-03-13 Eli Zaretskii <eliz@gnu.org>
12875
12876 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12877 $(EMACS_ROOT)/lib/intprops.h.
12878
f0c77cd1
PE
128792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12880
3eca4629
PE
12881 Fix more problems found by GCC 4.5.2's static checks.
12882
7c86ee98
PE
12883 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12884 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12885 (xg_free_frame_widgets): Make it clear that a local variable is
12886 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12887 (gdk_window_get_screen): Make it clear that this macro is needed
12888 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12889 (int_gtk_range_get_value): New function, which avoids a diagnostic
12890 from gcc -Wbad-function-cast.
12891 (xg_set_toolkit_scroll_bar_thumb): Use it.
12892 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12893 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12894 (get_utf8_string, xg_get_file_with_chooser):
12895 Rename locals to avoid shadowing.
12896 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12897
41729b81
PE
12898 * xgselect.c (xg_select): Remove unused var.
12899
f0c77cd1
PE
12900 * image.c (four_corners_best): Mark locals as initialized.
12901 (gif_load): Initialize transparent_p to zero (Bug#8238).
12902 Mark another local as initialized.
ec6cf4c6 12903 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12904
ce0ad53d 12905 * image.c (clear_image_cache): Now static.
d5d5a617 12906 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12907 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12908 (x_edge_detection): Remove unnecessary cast that
12909 gcc -Wbad-function-cast diagnoses.
2037898d 12910 (gif_load): Fix pointer signedness.
6ae141d6
PE
12911 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12912 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12913
33383987 129142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12915
d32df629
PE
12916 Improve quality of tests for time stamp overflow.
12917 For example, without this patch (encode-time 0 0 0 1 1
12918 1152921504606846976) returns the obviously-bogus value (-948597
12919 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12920 reports time overflow. See
12921 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12922 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12923 * editfns.c: Include limits.h and intprops.h.
12924 (TIME_T_MIN, TIME_T_MAX): New macros.
12925 (time_overflow): Move earlier, to before first use.
12926 (hi_time, lo_time): New functions, for an accurate test for
12927 out-of-range times.
12928 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12929 (Fget_internal_run_time): Don't assume time_t fits in int.
12930 (make_time): Use list2 instead of Fcons twice.
12931 (Fdecode_time): More accurate test for out-of-range times.
12932 (check_tm_member): New function.
12933 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12934 (lisp_time_argument): Don't rely on undefined left-shift and
12935 right-shift behavior when checking for time stamp overflow.
8be6f318 12936
fe31d94c
PE
12937 * editfns.c (time_overflow): New function, refactoring common code.
12938 (Fformat_time_string, Fdecode_time, Fencode_time):
12939 (Fcurrent_time_string): Use it.
12940
8be6f318
PE
12941 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12942 * dired.c (make_time): Move to ...
12943 * editfns.c (make_time): ... here.
12944 * systime.h: Note the move.
12945
09d9db2c 129462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12947
126bc0dc
YM
12948 * fringe.c (update_window_fringes): Remove unused variables.
12949
c47cbdfd
YM
12950 * unexmacosx.c (copy_data_segment): Also copy __got section.
12951 (Bug#8223)
12952
7ac80be9
EZ
129532011-03-12 Eli Zaretskii <eliz@gnu.org>
12954
c96bbc66 12955 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12956 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12957 Constify `char *' arguments and their references according to
12958 prototypes in tparam.h.
12959
ecb0f94d 12960 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12961
7ac80be9
EZ
12962 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12963 Adapt all references accordingly.
12964
12965 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12966
ef1fd07e
TT
129672011-03-11 Tom Tromey <tromey@redhat.com>
12968
12969 * buffer.c (syms_of_buffer): Remove obsolete comment.
12970
7ef4b50c
EZ
129712011-03-11 Eli Zaretskii <eliz@gnu.org>
12972
12973 * termhooks.h (encode_terminal_code): Declare prototype.
12974
12975 * msdos.c (encode_terminal_code): Don't declare prototype.
12976
12977 * term.c (encode_terminal_code): Now external again, used by
12978 w32console.c and msdos.c.
12979
44f230aa
SM
12980 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12981 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12982
4b1ec863 129832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12984
1714f52b 12985 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12986
4b1ec863
PE
12987 * fringe.c (update_window_fringes): Mark locals as initialized
12988 (Bug#8227).
12989 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12990
524c7aa6
PE
12991 * alloc.c (mark_fringe_data): Move decl from here ...
12992 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12993 to check its interface.
12994 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12995
a5c0af81 12996 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12997 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12998 (fontset_font): Mark local as initialized.
a9a06e0b 12999 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13000
b4716021
PE
13001 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13002
811e9bac 13003 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13004 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13005 (x_own_selection, Fx_disown_selection_internal): Rename locals
13006 to avoid shadowing.
13007 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13008
7e3ab302
PE
13009 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13010 so that the caller can use some name other than gcpro1.
13011 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13012 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13013 (Fx_backspace_delete_keys_p):
13014 Use them to avoid shadowing, and rename vars to avoid shadowing.
13015 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13016 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13017 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13018 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13019 Remove unused locals.
7e3ab302
PE
13020 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13021 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13022 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13023 macros.
f78faa98 13024
e2b13473
PE
13025 * xterm.h (x_mouse_leave): New decl.
13026
77f23912
PE
13027 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13028 Remove unused functions.
cdf4ba58
PE
13029 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13030 (x_calc_absolute_position): Now static.
7411c686 13031 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13032 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13033 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13034 unless they are used.
38d0b34a
PE
13035 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13036 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13037 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13038 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13039 (x_error_catcher, x_connection_closed, x_error_handler):
13040 (x_error_quitter, xembed_send_message, x_iconify_frame):
13041 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13042 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13043 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13044
44f230aa
SM
13045 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13046 Rename or move locals to avoid shadowing.
6b463e58 13047 (tty_defined_color, merge_face_heights): Now static.
5967d051 13048 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13049 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13050 does not deduce is never used uninitialized.
73719eba
PE
13051 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13052 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13053
426994c3 13054 * terminal.c (store_terminal_param): Now static.
5489860b 13055
032f1620 13056 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13057 (set_frame_menubar): Remove unused local.
d4323972 13058 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13059 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13060 since they might point to immutable storage.
281585b0
PE
13061 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13062 since it's unused otherwise.
032f1620 13063
367c19e5 13064 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13065 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13066 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13067 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13068 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13069 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13070 does not deduce are never used uninitialized.
70739cbe 13071
07b48fa9
PE
13072 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13073
8868a238 13074 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13075 * window.c (window_loop, size_window):
13076 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13077
7e5cf297 13078 * window.c (display_buffer): Now static.
d6550a9f
PE
13079 (size_window): Mark variables that gcc -Wuninitialized
13080 does not deduce are never used uninitialized.
a586633d
PE
13081 * window.h (check_all_windows): New decl, to forestall
13082 gcc -Wmissing-prototypes diagnostic.
5b555da1 13083 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13084
f6095868
PE
13085 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13086 shadowing.
13087 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13088 Include <limits.h>.
13089 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13090 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13091 (load_charset_map): Mark variables that gcc -Wuninitialized
13092 does not deduce are never used uninitialized.
53df7c11 13093 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13094
f38b440c
PE
13095 * coding.c (coding_set_source, coding_set_destination):
13096 Use "else { /* comment */ }" rather than "else /* comment */;"
13097 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13098 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13099 a block, when the outer 'i' will do.
13100 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13101 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13103 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13104 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13105 Rename locals to avoid shadowing.
13106 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13107 * coding.c (emacs_mule_char, encode_invocation_designation):
13108 Now static, since they're not used elsewhere.
413bb2db 13109 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13110 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13111 (decode_coding_emacs_mule): Mark variables that gcc
13112 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13113 (detect_coding_iso_2022): Initialize a local variable that might
13114 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13115 this initialization is needed. (Bug#8211)
5f58e762
PE
13116 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13117 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13118 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13119 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13120 Remove unused macros.
f38b440c 13121
232b38b9 13122 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13123 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13124 * character.c (string_count_byte8): Likewise.
232b38b9 13125
fb90da1b
PE
13126 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13127 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13128
fb93dbc2
PE
13129 * chartab.c (copy_sub_char_table): Now static, since it's not used
13130 elsewhere.
5c156ace
PE
13131 (sub_char_table_ref_and_range, char_table_ref_and_range):
13132 Rename locals to avoid shadowing.
bbcd0949 13133 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13134
7d3b3862 13135 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13136 (BIDI_BOB): Remove unused macro.
7d3b3862 13137
6be7d3da
PE
13138 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13139 deduce are never used uninitialized.
c2ed9c8b 13140 * term.c (encode_terminal_code): Likewise.
6be7d3da 13141
75f8807f 13142 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13143
50938595
PE
13144 * tparam.h: New file.
13145 * term.c, tparam.h: Include it.
13146 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13147 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13148 Move these decls to tparam.h, and make them agree with what
13149 is actually in tparam.c. The previous trick of using incompatible
13150 decls in different modules does not conform to the C standard.
13151 All callers of tparam changed to use tparam's actual API.
13152 * tparam.c (tparam1, tparam, tgoto):
13153 Use const pointers where appropriate.
13154
fbceeba2
PE
13155 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13156 * cm.h (struct cm): Likewise.
13157 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13158 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13159 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13160 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13161 (turn_on_face, init_tty): Likewise.
13162 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13163
7f3f1250
PE
13164 * term.c (term_mouse_position): Rename local to avoid shadowing.
13165
e6ca6543
PE
13166 * alloc.c (mark_ttys): Move decl from here ...
13167 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13168
c40f8d15
AS
131692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13170
13171 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13172
cfe0661d
JB
131732011-03-09 Juanma Barranquero <lekktu@gmail.com>
13174
13175 * search.c (compile_pattern_1): Remove argument regp, unused since
13176 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13177 (compile_pattern): Don't pass it.
13178
0afb4571
J
131792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13180
13181 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13182 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13183 for ! HAVE_GTK3.
13184 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13185
13186 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13187
13188 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13189 gdk_window_get_screen, gdk_window_get_geometry,
13190 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13191 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13192 (xg_get_pixbuf_from_pixmap): New function.
13193 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13194 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13195 Call xg_get_pixbuf_from_pixmap instead of
13196 gdk_pixbuf_get_from_drawable.
13197 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13198 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13199 (xg_check_special_colors): Use GtkStyleContext and its functions
13200 for HAVE_GTK3.
13201 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13202 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13203 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13204 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13205 Call gtk_widget_get_preferred_size.
0afb4571
J
13206 (xg_frame_resized): gdk_window_get_geometry only takes 5
13207 parameters.
44f230aa
SM
13208 (xg_win_to_widget, xg_event_is_for_menubar):
13209 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13210 (xg_set_widget_bg): New function.
13211 (delete_cb): New function.
895009e1 13212 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13213 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13214 (xg_set_background_color): Call xg_set_widget_bg.
13215 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13216 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13217 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13218 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13219 if ! HAVE_GTK3.
13220 (update_frame_tool_bar): Call gtk_widget_hide.
13221 (xg_initialize): Use GDK_KEY_g.
13222
13223 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13224 if ! HAVE_GTK3
13225 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13226
13227 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13228 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13229 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13230
1c2cc4ef
JB
132312011-03-08 Juanma Barranquero <lekktu@gmail.com>
13232
13233 * w32xfns.c (select_palette): Check success of RealizePalette against
13234 GDI_ERROR, not zero.
13235
33383987 13236See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13237
13238;; Local Variables:
13239;; coding: utf-8
aac0c6e3
MR
13240;; End:
13241
2f097256 13242 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13243
13244 This file is part of GNU Emacs.
13245
13246 GNU Emacs is free software: you can redistribute it and/or modify
13247 it under the terms of the GNU General Public License as published by
13248 the Free Software Foundation, either version 3 of the License, or
13249 (at your option) any later version.
13250
13251 GNU Emacs is distributed in the hope that it will be useful,
13252 but WITHOUT ANY WARRANTY; without even the implied warranty of
13253 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13254 GNU General Public License for more details.
13255
13256 You should have received a copy of the GNU General Public License
13257 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.