1 2012-07-09 Glenn Morris <rgm@gnu.org>
3 Stop ns builds setting the EMACSPATH environment variable.
4 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5 (ns_init_paths): Do not set EMACSPATH.
6 * nsterm.h (ns_exec_path): Add it.
7 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
10 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
12 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
14 * process.c (wait_reading_process_output): 'waitchannels' was unset
15 when read_kbd || !NILP (wait_for_cell); fix this.
17 Add GCC-style 'const' attribute to functions that can use it.
18 * character.h (char_resolve_modifier_mask):
19 * keyboard.h (make_ctrl_char):
20 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
21 (init_character_once, next_almost_prime, init_fns, init_image)
22 (flush_pending_output, init_sound):
23 * mem-limits.h (start_of_data):
24 * menu.h (finish_menu_items):
26 * emacs.c (DEFINE_DUMMY_FUNCTION):
27 Declare the dummy function with ATTRIBUTE_CONST.
28 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
29 Add decls with ATTRIBUTE_CONST.
31 Minor improvements to make_formatted_string.
32 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
33 where int is good enough, as vsprintf returns an int.
34 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
36 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
38 Use make_formatted_string to avoid double length calculation.
39 * lisp.h (make_formatted_string): New prototype.
40 * alloc.c (make_formatted_string): New function.
41 * buffer.c (Fgenerate_new_buffer_name): Use it.
42 * dbus.c (syms_of_dbusbind): Likewise.
43 * editfns.c (Fcurrent_time_zone): Likewise.
44 * filelock.c (get_boot_time): Likewise.
45 * frame.c (make_terminal_frame, set_term_frame_name)
46 (x_report_frame_params): Likewise.
47 * image.c (gs_load): Likewise.
48 * minibuf.c (get_minibuffer): Likewise.
49 * msdos.c (dos_set_window_size): Likewise.
50 * process.c (make_process): Likewise.
51 * xdisp.c (ensure_echo_area_buffers): Likewise.
52 * xsettings.c (apply_xft_settings): Likewise.
54 2012-07-09 Glenn Morris <rgm@gnu.org>
56 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
57 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
58 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
59 * nsterm.h (ns_etc_directory): Add it.
60 * callproc.c [HAVE_NS]: Include nsterm.h.
61 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
63 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
65 Move marker debugging code under MARKER_DEBUG.
66 * marker.c (MARKER_DEBUG): Move marker debugging code under
67 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
68 for bootstrap with --enable-checking (~3x slowdown reported
69 by Juanma Barranquero <lekktu@gmail.com>).
70 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
72 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
74 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
75 See <http://bugs.gnu.org/11825#29>.
77 2012-07-08 Eli Zaretskii <eliz@gnu.org>
79 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
80 has no font, use the frame's font. (Bug#11813)
81 (display_line): Add commentary about displaying truncation glyphs
83 (produce_special_glyphs): Move here from term.c.
85 * term.c (produce_special_glyphs): Move to xdisp.c.
87 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
90 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
92 * xdisp.c (display_line): Avoid warning about implicit declaration
95 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
97 * lisp.h: Remove empty conditional.
99 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
101 * lread.c (load_path_check): Now static.
103 Fix some minor --with-ns problems found by static checking.
104 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
105 (x_set_font) [!HAVE_X_WINDOWS]:
106 * image.c (xpm_load_image) [HAVE_NS]:
107 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
108 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
110 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
111 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
112 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
113 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
114 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
115 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
116 Fix pointer signedness problem.
117 * xfaces.c (FRAME_X_FONT_TABLE):
118 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
120 2012-07-07 Glenn Morris <rgm@gnu.org>
122 * lread.c (load_path_check): New function, split from init_lread.
123 (init_lread): Reorganize. Motivation:
124 If EMACSLOADPATH is set, check/warn about that rather than the
125 defaults, which we are not going to use. Hence we can remove
126 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
127 Don't warn if site-lisp directories are missing.
128 If not installed, start from a blank load-path, since
129 PATH_LOADSEARCH refers to the eventual installation directories.
131 2012-07-07 Eli Zaretskii <eliz@gnu.org>
133 Support truncation and continuation glyphs on GUI frames, when
134 fringes are disabled. (Bug#11832)
135 * xdisp.c (init_iterator): Get dimensions of truncation and
136 continuation glyphs even if on GUI frames. Adjust
137 it->last_visible_x on GUI frames when the left or right fringes,
139 (start_display, move_it_in_display_line_to): Handle the case of a
140 GUI frame without a fringe to display continuation or truncation
142 (insert_left_trunc_glyphs): Support GUI frames: make sure
143 truncation glyphs overwrite enough glyphs from the current line to
144 have sufficient space in pixels.
145 (display_line): Support truncation and continuation glyphs on GUI
146 frames. If some spare pixels are left on the line after inserting
147 the truncation glyphs, fill that space with a stretch glyph of a
148 suitably computed width.
150 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
151 produce_glyphs, to support GUI sessions.
153 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
155 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
157 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
159 Do not require float-time's arg to fit in time_t (Bug#11825).
160 This works better on hosts where time_t is unsigned, and where
161 float-time is applied to the (negative) difference between two times.
162 * editfns.c (decode_time_components): Last arg is now double *,
163 not int *, and means to store all the result as a double, without
164 worrying about whether the seconds part fits in time_t.
166 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
168 (Ffloat_time): Do not fail merely because the specified time falls
169 outside of time_t range.
171 2012-07-07 Glenn Morris <rgm@gnu.org>
173 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
174 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
175 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
177 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
179 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
182 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
184 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
186 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
187 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
188 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
189 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
190 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
191 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
193 * xfont.c (compare_font_names): Redo to omit the need for casts.
195 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
197 * xfns.c (Fx_change_window_property): Doc fix.
198 * w32fns.c (Fx_change_window_property): Doc fix.
200 * w32fns.c (Fx_window_property): Accept the same arguments as the
201 X Windows version. Doc fix.
202 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
204 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
205 Eli Zaretskii <eliz@gnu.org>
207 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
208 Windows-specific code from nt/config.nt moved here.
209 Obsolete settings removed.
211 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
213 * process.c: Avoid unnecessary calls to gettime.
214 (wait_reading_process_output): Don't get the time of day
215 when gobbling data immediately and not waiting, as there's no need
216 for it in that case. This removes a FIXME.
218 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
220 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
221 is defined (Bug#11768).
223 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
225 Fix marker debugging code.
226 * marker.c (byte_char_debug_check): Do not perform the check
227 if buffer is not multibyte.
228 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
229 Call byte_char_debug_check with correct arguments.
231 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
233 Compile marker debugging code only if ENABLE_CHECKING is defined.
234 * marker.c (byte_char_debug_check, count_markers):
235 Use only if ENABLE_CHECKING is defined.
236 (byte_debug_flag): Remove.
237 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
238 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
240 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
242 Avoid code repetition in marker-related functions.
243 * marker.c (attach_marker): New function.
244 (Fset_marker, set_marker_restricted, set_marker_both)
245 (set_marker_restricted_both): Use it.
246 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
247 Consistently rename charno to charpos.
248 (marker_position): Add eassert.
249 (marker_byte_position): Convert to eassert.
251 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
253 Simplify list operations in unchain_overlay and unchain_marker.
254 * buffer.c (unchain_overlay): Simplify. Add comment.
255 * marker.c (unchain_marker): Simplify. Fix comments.
257 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
259 Introduce fast path for the widely used marker operation.
260 * alloc.c (build_marker): New function.
261 * lisp.h (build_marker): New prototype.
262 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
263 * composite.c (autocmp_chars): Likewise.
264 * editfns.c (buildmark): Remove.
265 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
266 (save_restriction_save): Use build_marker.
267 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
268 * window.c (save_window_save): Likewise.
270 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
272 Do not use Fdelete_overlay in delete_all_overlays
273 to avoid redundant calls to unchain_overlay.
274 * buffer.c (drop_overlay): New function.
275 (delete_all_overlays, Fdelete_overlay): Use it.
276 * minibuf.c (get_minibuffer): Fix comment.
278 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
280 Port to OpenBSD 5.1 amd64.
281 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
282 This is needed for OpenBSD, and should be harmless on all BSD systems.
283 Also, include <sys/sysctl.h>, as it should be available on all
284 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
285 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
286 use p_pid member, not kp_proc.pid.
288 2012-07-06 Glenn Morris <rgm@gnu.org>
290 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
292 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
294 More xmalloc and related cleanup.
295 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
296 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
297 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
298 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
299 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
300 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
301 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
302 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
303 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
305 Omit needless casts involving void * pointers and allocation.
306 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
307 as the former is more robust if P's type is changed.
308 Prefer xzalloc to xmalloc + memset 0.
309 Simplify malloc-or-realloc to realloc.
310 Don't worry about xmalloc returning a null pointer.
311 Prefer xstrdup to xmalloc + strcpy.
312 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
314 * keyboard.c (apply_modifiers_uncached): Prefer local array to
315 alloca of a constant.
317 2012-07-05 Eli Zaretskii <eliz@gnu.org>
319 * xdisp.c (display_line): Fix horizontal pixel coordinates when
320 hscroll is larger than the line width. Fixes long and futile
321 looping inside extend_face_to_end_of_line (on a TTY) producing
322 glyphs that are not needed and thrown away.
324 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
326 * marker.c (set_marker_restricted_both): Simplify by using
329 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
331 * editfns.c (region_limit): Simplify by using clip_to_bounds.
333 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
335 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
336 not defined (Bug#11768).
337 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
338 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
339 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
340 followed by gtk_box_set_homogeneous (Bug#11768).
341 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
342 (update_theme_scrollbar_width, xg_create_scroll_bar):
343 Use gtk_scrollbar_new (Bug#11768).
344 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
345 (is_box_type): New function (Bug#11768).
346 (xg_tool_item_stale_p): Call is_box_type.
347 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
348 with default display (Bug#11768).
350 2012-07-05 Eli Zaretskii <eliz@gnu.org>
352 * xdisp.c (window_hscroll_limited): New function.
353 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
354 coordinates when window's hscroll is set to insanely large
357 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
359 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
360 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
362 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
365 * lisp.h (xzalloc): New prototype. Omit needless casts.
366 * alloc.c (xzalloc): New function. Omit needless casts.
367 * charset.c: Omit needless casts. Convert all calls to
368 xmalloc with following memset to xzalloc.
369 * dispnew.c: Likewise.
370 * fringe.c: Likewise.
374 * w32fns.c: Likewise.
375 * w32font.c: Likewise.
376 * w32term.c: Likewise.
377 * xfaces.c: Likewise.
380 * atimer.c: Omit needless casts.
381 * buffer.c: Likewise.
382 * callproc.c: Likewise.
384 * coding.c: Likewise.
385 * composite.c: Likewise.
387 * doprnt.c: Likewise.
388 * editfns.c: Likewise.
391 * filelock.c: Likewise.
393 * gtkutil.c: Likewise.
394 * keyboard.c: Likewise.
397 * minibuf.c: Likewise.
400 * process.c: Likewise.
401 * region-cache.c: Likewise.
402 * search.c: Likewise.
403 * sysdep.c: Likewise.
404 * termcap.c: Likewise.
405 * terminal.c: Likewise.
406 * tparam.c: Likewise.
407 * w16select.c: Likewise.
409 * w32reg.c: Likewise.
410 * w32select.c: Likewise.
411 * w32uniscribe.c: Likewise.
412 * widget.c: Likewise.
416 * xselect.c: Likewise.
418 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
420 * fileio.c (time_error_value): Check the right error number.
421 Problem reported by Troels Nielsen in
422 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
424 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
426 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
427 This should be fixed in a better way; see Eli Zaretskii in
428 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
429 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
431 * fileio.c (time_error_value): Rename from special_mtime.
432 The old name's problems were noted by Eli Zaretskii in
433 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
435 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
436 This variable's comment says Emacs needs at least one GDB-visible
437 symbol of type enum pvec_type, to work around GDB problems.
438 The symbol's value doesn't matter.
440 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
441 that causes compilation to fail on pre-C99 compilers.
443 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
445 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
446 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
448 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
450 * buffer.c (init_buffer_once): Fix initialization of
451 headers for buffer_defaults and buffer_local_symbols.
452 Reported by Juanma Barranquero <lekktu@gmail.com>.
454 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
456 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
457 * lisp.h (enum pvec_type): Use fewer bits.
458 (PSEUDOVECTOR_SIZE_BITS): New constant.
459 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
460 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
462 (PSEUDOVECTOR_TYPEP): New macro.
463 (TYPED_PSEUDOVECTORP): Use it.
464 * fns.c (internal_equal): Adapt code to extract pvectype.
465 * emacs.c (gdb_pvec_type): Update type.
466 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
467 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
468 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
469 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
470 (sweep_vectors): Use it. Use local var `total_bytes' instead of
471 abusing vector->header.next.nbytes.
472 (live_vector_p): Use PVEC_TYPE.
473 (mark_object): Adapt code to extract pvectype. Use switch.
475 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
477 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
478 Tighten new eassert a bit.
480 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
482 Fix compilation with --enable-gcc-warnings and -O1
484 * doprnt.c (doprnt): Change type of tem to int, initialize
485 to avoid compiler warning. Add eassert.
486 * search.c (simple_search): Initialize match_byte to avoid
487 compiler warning. Add eassert.
489 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
491 Avoid weird behavior with large horizontal scrolls.
492 Without this change, for example, large hscroll values would
493 mess up Emacs's display on Fedora 15 x86, presumably due to
494 overflows in int calculations in the display code.
495 Also, if buffers had long lines, Emacs would freeze.
496 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
497 (set_window_hscroll): New function, containing the old guts of
498 Fset_window_hscroll. Return the clipped value.
499 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
500 This avoids the need to check against PTRDIFF_MAX.
502 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
504 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
506 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
508 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
510 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
511 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
512 since GCC 4.4.6 issues a bogus warning for them.
514 Fix bugs in file timestamp newness comparisons.
515 * fileio.c (Ffile_newer_than_file_p):
516 * lread.c (Fload): Use full timestamp resolution of files,
517 not just the 1-second resolution, so that files that are only
518 slightly newer still count as newer.
519 * fileio.c (Ffile_newer_than_file_p): Don't assume file
520 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
522 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
524 * fileio.c: Improve handling of file time marker. (Bug#11852)
525 (special_mtime): New function.
526 (Finsert_file_contents, Fverify_visited_file_modtime):
527 Use it to set special mtime values consistently.
529 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
531 * fileio.c (Finsert_file_contents): Properly handle st_mtime
532 marker for non-existing file. (Bug#11852)
534 2012-07-03 Glenn Morris <rgm@gnu.org>
536 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
537 and did not make it into globals.h).
539 2012-07-03 Tom Tromey <tromey@redhat.com>
541 * window.c (Fset_window_margins, Fset_window_fringes)
542 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
543 * textprop.c (Fprevious_property_change): No longer static.
544 * syntax.c (Fsyntax_table_p): No longer static.
545 * process.c (Fget_process, Fprocess_datagram_address): No longer
547 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
548 * keyboard.c (Fcommand_execute): No longer static.
550 * insdel.c (Fcombine_after_change_execute): No longer static.
551 * image.c (Finit_image_library): No longer static.
552 * fileio.c (Fmake_symbolic_link): No longer static.
553 * eval.c (Ffetch_bytecode): No longer static.
554 * editfns.c (Fuser_full_name): No longer static.
555 * doc.c (Fdocumentation_property, Fsnarf_documentation):
557 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
559 * dired.c (Ffile_attributes): No longer static.
560 * composite.c (Fcomposition_get_gstring): No longer static.
561 * callproc.c (Fgetenv_internal): No longer static.
563 * ccl.h: Remove EXFUNs.
564 * buffer.h: Remove EXFUNs.
565 * dispextern.h: Remove EXFUNs.
566 * intervals.h: Remove EXFUNs.
567 * fontset.h: Remove EXFUN.
568 * font.h: Remove EXFUNs.
569 * dosfns.c (system_process_attributes): Remove EXFUN.
570 * keymap.h: Remove EXFUNs.
571 * lisp.h: Remove EXFUNs.
572 * w32term.h: Remove EXFUNs.
573 * window.h: Remove EXFUNs.
574 * xsettings.h: Remove EXFUN.
575 * xterm.h: Remove EXFUN.
577 2012-07-03 Glenn Morris <rgm@gnu.org>
579 * lisp.h (Frandom): Make it visible to C.
580 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
581 buffer for invisible buffers. (Bug#1229)
583 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
585 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
586 values which aren't power of 2.
587 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
588 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
591 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
593 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
595 * alloc.c (mark_object): Revert part of last patch to use `switch'.
597 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
599 * alloc.c (allocate_vector_block): Remove redundant
600 calls to mallopt if DOUG_LEA_MALLOC is defined.
601 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
602 avoid calls to mallopt if zero_vector is returned.
604 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
606 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
607 is enabled, avoid dereferencing NULL current_sblock if
610 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
612 Cleanup basic buffer management.
613 * buffer.h (struct buffer): Change layout to use generic vector
614 marking code. Fix some comments. Change type of 'clip_changed'
615 to bitfield. Remove unused #ifndef old.
616 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
617 (GET_OVERLAYS_AT): Fix indentation.
618 (for_each_per_buffer_object_at): New macro.
619 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
620 (Fbuffer_local_variables): Use it.
621 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
622 * alloc.c (allocate_buffer): Adjust to match new layout of
623 struct buffer. Fix comment.
624 (mark_overlay): New function.
625 (mark_buffer): Use it. Use mark_vectorlike to mark normal
626 Lisp area of struct buffer.
627 (mark_object): Use it. Adjust marking of misc objects
628 and related comments.
630 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
632 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
633 wrapper that is not needed because the wrapped code is a no-op (zero
634 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
635 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
637 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
639 * alloc.c (mark_buffer): Simplify. Remove prototype.
640 (mark_object): Add comment. Reorganize marking of vector-like
641 objects. Use CHECK_LIVE for all vector-like objects except buffers
642 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
643 redundant calls to mark_vectorlike for bool vectors.
645 2012-06-30 Glenn Morris <rgm@gnu.org>
647 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
649 * epaths.in (PATH_SITELOADSEARCH): New.
650 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
651 This is rather than relying on --enable-locallisppath elements
652 having "site-lisp" in their names. (Bug#10208#25, 11658)
654 2012-06-30 Eli Zaretskii <eliz@gnu.org>
656 * w32proc.c (sys_select): Accept and ignore one more argument.
658 * w32.c (emacs_gnutls_pull): Call select with one more argument.
660 * sysselect.h [DOS_NT]: Don't include sys/select.h.
661 (pselect) [!MS_DOS]: Redirect to sys_select.
663 * sysdep.c: Don't include dos.h and dosfns.h.
665 * process.c (sys_select):
666 * msdos.c (sys_select): Accept one more argument and ignore it.
668 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
669 adapt data types and code to that.
672 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
673 which clashes with the gnulib function of the same name.
675 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
677 * font.c (font_style_to_value, font_style_symbolic)
678 (font_prop_validate_style): Add type checks for values in
681 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
683 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
686 2012-06-29 Eli Zaretskii <eliz@gnu.org>
688 * xdisp.c (try_window_id): Undo last change.
690 * w32.c (getwd): Adjust commentary about startup_dir.
691 (init_environment): Always call sys_access, even in non-MSVC
692 builds. Don't chdir to the directory of the Emacs executable.
693 This undoes code from 1997 which was justified by the need to
694 "avoid conflicts when removing and renaming directories". But its
695 downside was that every relative file name was being interpreted
696 relative to the directory of the Emacs executable, which can never
697 be TRT. In particular, it broke sys_access when called with
699 (sys_access): Map GetLastError to errno.
701 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
703 * window.h (struct window): Change type of 'fringes_outside_margins'
704 to bitfield. Fix comment. Adjust users accordingly.
705 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
707 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
710 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
712 * gnutls.c (emacs_gnutls_handshake):
713 Add QUIT to make the loop interruptible.
715 2012-06-29 Glenn Morris <rgm@gnu.org>
717 * charset.c (init_charset): Make lack of etc/charsets fatal.
719 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
721 * editfns.c (region_limit): Fix type mismatch.
723 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
725 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
726 undefined. Convert from xassert to eassert.
727 * nsmenu.m: Convert from xassert to eassert.
728 * nsterm.m: Likewise.
730 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
732 * editfns.c (region_limit): Clip to narrowing (bug#11770).
734 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
736 Avoid integer overflow on scroll-left and scroll-right.
737 * window.c (HSCROLL_MAX): New macro.
738 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
739 overflow when requested scroll falls outside ptrdiff_t range.
741 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
743 * window.h (struct window): Change type of 'hscroll',
744 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
745 'last_modified' and 'last_overlay_modified' to EMACS_INT.
746 Adjust users accordingly.
747 * xdisp.c (try_cursor_movement): Replace type check with eassert.
748 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
749 from EMACS_INT to ptrdiff_t.
750 (make_window): Omit redundant initialization.
752 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
754 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
756 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
758 * window.h (struct window): Change type of 'use_time' and
759 'sequence_number' from Lisp_Object to int.
760 * frame.c (make_frame): Adjust users accordingly.
761 * print.c (print_object): Likewise.
762 * window.c (select_window, Fwindow_use_time, make_parent_window)
763 (make_window): Likewise.
765 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
767 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
768 enabled with --enable-checking=[all,glyphs] configure option.
769 Fix GLYPH_DEBUG usage assuming that it may be undefined,
770 adjust comments accordingly.
771 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
772 undefined, adjust comments accordingly.
774 * scroll.c: Likewise.
775 * w32fns.c: Likewise.
776 * w32term.c: Likewise.
778 * xfaces.c: Likewise.
782 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
784 Generalize run-time debugging checks.
785 * dispextern.h (XASSERTS): Remove.
786 * fontset.c (xassert): Remove.
787 Convert from xassert to eassert.
788 * alloc.c: Convert from xassert to eassert.
790 * dispnew.c: Likewise.
792 * fringe.c: Likewise.
793 * ftfont.c: Likewise.
794 * gtkutil.c: Likewise.
796 * keyboard.c: Likewise.
798 * process.c: Likewise.
799 * scroll.c: Likewise.
802 * w32console.c: Likewise.
803 * w32fns.c: Likewise.
804 * w32term.c: Likewise.
805 * window.c: Likewise.
807 * xfaces.c: Likewise.
809 * xselect.c: Likewise.
812 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
814 * fns.c (maybe_resize_hash_table): Output message when growing the
817 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
819 * alloc.c (allocate_string_data): Remove dead code.
820 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
821 avoid GCC warning about unused macro.
823 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
825 * alloc.c (allocate_string): Omit intervals initialization.
826 * alloc.c (make_uninit_multibyte_string): Initialize intervals
827 as in make_pure_string and make_pure_c_string.
829 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
831 * alloc.c (allocate_string): Fix last change.
833 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
835 * alloc.c (allocate_string): Remove two redundant calls
836 to memset, add explicit initialization where appropriate.
838 2012-06-27 Glenn Morris <rgm@gnu.org>
840 * lisp.mk (lisp): Remove paths.elc.
842 2012-06-27 Chong Yidong <cyd@gnu.org>
844 * doc.c (Fsubstitute_command_keys): Fix punctuation.
846 2012-06-26 John Wiegley <johnw@newartisans.com>
848 * unexmacosx.c (copy_data_segment): Add two section names used
849 on Mac OS X Lion: __mod_init_func and __mod_term_func.
851 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
852 when building with Clang.
854 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
856 * eval.c (Fapply): Allow calling it with a single argument.
858 2012-06-26 Eli Zaretskii <eliz@gnu.org>
860 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
861 _stricmp and _strnicmp.
862 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
864 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
866 * alloc.c (allocate_window): Zero out non-Lisp part of newly
868 (allocate_process): Likewise for new process.
869 (allocate_terminal): Change to use offsetof.
870 (allocate_frame): Likewise.
871 * frame.c (make_frame): Omit redundant initialization.
872 * window.c (make_parent_window): Use memset.
873 (make_window): Omit redundant initialization.
874 * process.c (make_process): Omit redundant initialization.
875 * terminal.c (create_terminal): Likewise.
877 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
879 * term.c (delete_tty): Remove redundant call to memset.
881 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
883 * alloc.c: Remove build_string.
884 * lisp.h: Define build_string as static inline. This provides
885 a better opportunity to optimize away calls to strlen when the
886 function is called with compile-time constant argument.
887 * image.c (imagemagick_error): Convert to build_string.
888 * w32proc.c (sys_spawnve): Likewise.
889 * xterm.c (x_term_init): Likewise.
891 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
893 Use sprintf return value instead of invoking strlen on result.
894 In the old days this wasn't portable, since some sprintf
895 implementations returned char *. But they died out years ago and
896 Emacs already assumes sprintf returns int.
897 Similarly for float_to_string.
898 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
899 * ccl.c (ccl_driver):
900 * character.c (string_escape_byte8):
901 * data.c (Fnumber_to_string):
903 * print.c (print_object):
904 * xdisp.c (message_dolog):
905 * xfns.c (syms_of_xfns):
906 Use sprintf or float_to_string result to avoid need to call strlen.
907 * data.c (Fnumber_to_string):
908 Use make_unibyte_string, since the string must be ASCII.
909 * lisp.h, print.c (float_to_string): Now returns int length.
910 * term.c (produce_glyphless_glyph):
911 Use sprintf result rather than recomputing it.
913 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
914 * Makefile.in (ALL_CFLAGS):
915 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
916 * gmalloc.c, regex.c: Include <config.h> unconditionally.
918 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
920 * dispextern.h (xstrcasecmp): Define to library function
921 strcasecmp if available.
922 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
924 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
926 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
927 Avoid comma operator.
928 * menu.c (push_submenu_start, push_submenu_end)
929 (push_left_right_boundary, push_menu_pane): Likewise.
930 * msdos.c (dos_rawgetc): Likewise.
932 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
934 * xfns.c (xic_create_fontsetname): Remove redundant calls
937 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
939 * gtkutil.c (get_utf8_string): Remove redundant assignment.
940 sprintf already null-terminates its output.
942 * xfns.c (x_window): Remove redundant cast.
944 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
946 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
947 `const char *' to `char *' to avoid compiler warning.
949 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
951 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
952 instead of truncating it to 63 (admittedly a generous limit).
954 * process.c: Fix spelling and caps in comments.
956 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
958 * emacs.c (setpgrp): Remove definition, unused.
959 * sysdep.c (setpgrp): Remove definition, not used in this file.
961 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
963 * makefile.w32-in: Update dependencies.
965 2012-06-24 Eli Zaretskii <eliz@gnu.org>
967 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
968 (SYSTIME_H): Add nt/inc/sys/time.h.
970 * systime.h [WINDOWSNT]: Include sys/time.h.
972 * s/ms-w32.h (struct timespec): Definition moved from
973 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
975 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
977 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
978 * buffer.h (buffer_slot_type_mismatch):
979 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
980 * eval.c (unwind_to_catch):
981 * image.c (my_png_error, my_error_exit):
982 * keyboard.c (quit_throw_to_read_char, user_error)
983 (Fexit_recursive_edit, Fabort_recursive_edit):
984 * lisp.h (die, args_out_of_range, args_out_of_range_3)
985 (wrong_type_argument, buffer_overflow, __executable_start)
986 (memory_full, buffer_memory_full, string_overflow, Fthrow)
987 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
988 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
990 (child_setup) [!DOS_NT]:
991 * lread.c (end_of_file_error, invalid_syntax):
992 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
993 * puresize.h (pure_write_error):
994 * search.c (matcher_overflow):
995 * sound.c (sound_perror, alsa_sound_perror):
996 * sysdep.c, syssignal.h (croak):
997 * term.c (maybe_fatal, vfatal):
998 * textprop.c (text_read_only):
999 * undo.c (user_error):
1000 * unexmacosx.c (unexec_error):
1001 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1002 Use _Noreturn rather than NO_RETURN.
1003 No need for separate decl merely because of _Noreturn.
1004 * sound.c (sound_warning, parse_sound):
1005 Remove unnecessary forward decls.
1007 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1009 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1010 * lisp.h (WAIT_READING_MAX): New macro.
1011 * dispnew.c (Fsleep_for, sit_for):
1012 * keyboard.c (kbd_buffer_get_event):
1013 * process.c (Faccept_process_output):
1014 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1015 This improves on the previous patch, which introduced a bug
1016 when time_t is unsigned and as wide as intmax_t.
1017 See <http://bugs.gnu.org/9000#51>.
1019 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1021 * dispnew.c (sit_for, Fsleep_for):
1022 * keyboard.c (kbd_buffer_get_event):
1023 * process.c (Faccept_process_output): Avoid compiler warnings when
1024 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1026 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1028 * makefile.w32-in: Update dependencies.
1030 * w32.c (ltime): Add return type and declare static.
1031 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1033 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1035 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1036 Privately reported by Herbert J. Skuhra.
1037 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1039 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1040 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1042 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1044 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1045 last argument of make_unibyte_string.
1047 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1048 language ID in the event parameters.
1050 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1051 event.code, not the obscure "character set ID".
1053 2012-06-23 Chong Yidong <cyd@gnu.org>
1055 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1057 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1059 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1060 * w32.c (fdutimens): New function.
1062 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1064 * s/ms-w32.h (pselect): Redirect to sys_select.
1066 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1068 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1069 in the logic of incrementing and decrementing the value of
1070 use_relocatable_buffers.
1072 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1074 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1075 Privately reported by Herbert J. Skuhra.
1076 [__FreeBSD__]: Remove "*/" typo after "#include".
1077 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1078 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1079 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1080 Don't assume EMACS_TIME and struct timeval are the same type.
1082 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1084 Support higher-resolution time stamps (Bug#9000).
1085 The time stamps are only nanosecond-resolution at the C level,
1086 since that's the best that any real-world system supports now.
1087 But they are picosecond-resolution at the Lisp level, as that's
1088 easy, and leaves room for future OS improvements.
1090 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1093 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1094 Don't get current time unless it's needed.
1096 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1097 now provides it if it's absent.
1098 (start_atimer): Port to higher-res time stamps.
1099 Check for time stamp overflow. Don't get current time more
1100 often than is needed.
1102 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1103 Include systime.h, not time.h.
1104 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1106 * dired.c: Include stat-time.h.
1107 (Ffile-attributes): File times now have higher resolution.
1109 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1110 (struct image): Timestamp now has higher resolution.
1112 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1113 has at least microseconds now. All uses removed.
1114 (update_frame, update_single_window, update_window, update_frame_1)
1115 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1117 * editfns.c (time_overflow): Now extern.
1118 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1119 (float-time, Fformat_time_string, Fcurrent_time_string)
1120 (Fcurrent_time_zone): Accept and generate higher-resolution
1122 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1123 (decode_time_components, lisp_seconds_argument): New functions.
1124 (make_time): Now static.
1125 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1126 Report an error if the time is invalid, rather than having the caller
1129 * fileio.c: Include <stat-time.h>
1130 (Fcopy_file): Copy higher-resolution time stamps.
1131 Prefer to set the time stamp via a file descriptor if that works.
1132 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1133 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1134 (Fvisited_file_modtime, Fset_visited_file_modtime):
1135 Support higher-resolution time stamps.
1137 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1139 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1141 * image.c (prepare_image_for_display, clear_image_cache)
1142 (lookup_image): Port to higer-resolution time stamps.
1144 * keyboard.c (start_polling, bind_polling_period):
1145 Check for time stamp overflow.
1146 (read_char, kbd_buffer_get_event, timer_start_idle)
1147 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1148 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1149 Port to higher-resolution time stamps. Do not assume time_t is signed.
1150 (decode_timer): New function. Timers are now vectors of length 9,
1151 not 8, to accommodate the picosecond component.
1152 (timer_check_2): Use it.
1154 * nsterm.m (select_timeout, timeval_subtract): Remove.
1155 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1156 as they're a bit more accurate and handle overflow better.
1157 (ns_select): Change prototype to be compatible with pselect.
1158 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1159 * nsterm.h (ns_select): Adjust prototype.
1161 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1162 us-resolution time stamps.
1163 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1165 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1167 * lisp.h (time_overflow): New decl.
1168 (wait_reading_process_output): First arg is now intmax_t, not int,
1169 to accommodate larger waits.
1171 * process.h (struct Lisp_Process.read_output_delay):
1172 Now counts nanoseconds, not microseconds.
1173 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1175 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1176 (wait_reading_process_output):
1177 Port to ns-resolution time stamps.
1178 (Faccept_process_output, wait_reading_process_output):
1179 Check for time stamp overflow. Do not assume time_t is signed.
1180 (select_wrapper): Remove; we now use pselect.
1181 (Fprocess_attributes): Now generates ns-resolution time stamps.
1183 * sysdep.c: Include utimens.h. Don't include utime.h
1184 or worry about struct utimbuf; gnulib does that for us now.
1185 (gettimeofday): Remove; gnulib provides a substitute.
1186 (make_timeval): New function.
1187 (set_file_times): Now sets ns-resolution time stamps.
1188 New arg FD; all uses changed.
1189 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1190 (system_process_attributes):
1191 Now returns ns-resolution time stamp. All uses changed.
1192 Check for time stamp overflow.
1194 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1195 provides a substitute now.
1197 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1198 since it guarantees struct timespec.
1199 (EMACS_TIME): Now struct timespec, so that we can support
1200 ns-resolution time stamps.
1201 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1202 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1203 (EMACS_USECS): Remove.
1204 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1205 so multiply the arg by 1000 before storing it.
1206 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1208 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1209 Port to ns-resolution time stamps.
1210 (EMACS_TIME_NEG_P): Remove; replaced by....
1211 (EMACS_TIME_SIGN): New macro.
1212 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1213 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1214 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1215 (make_timeval, make_lisp_time, decode_time_components): New decls.
1216 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1217 that it mishandled time_t overflow. You can't compare by subtracting!
1218 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1219 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1221 * term.c: Include <sys/time.h>.
1222 (timeval_to_Time): New function, for proper overflow wraparound.
1223 (term_mouse_position, term_mouse_click): Use it.
1225 * undo.c (record_first_change): Support higher-resolution time stamps
1227 (Fprimitive_undo): Use them when restoring time stamps.
1229 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1230 (w32_get_internal_run_time):
1231 Port to higher-resolution Emacs time stamps.
1232 (ltime): Now accepts single 64-bit integer, as that's more convenient
1235 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1237 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1238 for compatibility with pselect. Support ns-resolution time stamps.
1240 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1242 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1243 Check for time stamp overflow, and support ns-resolution time stamps.
1245 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1246 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1247 (timeval_subtract): Remove; no longer needed.
1248 (XTflash, XTring_bell, x_wait_for_event):
1249 Port to ns-resolution time stamps. Don't assume time_t is signed.
1251 2012-06-22 Chong Yidong <cyd@gnu.org>
1253 * xdisp.c (x_consider_frame_title): Revert last change.
1255 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1257 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1258 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1259 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1260 staticidx goes up to 1597 out of 1600 = 0x640.)
1262 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1264 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1265 Otherwise, the umask might be mistakenly 0 while handling input signals.
1267 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1269 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1271 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1273 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1274 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1275 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1276 access to `contents' member of Lisp_Vector objects with AREF and ASET
1279 2012-06-19 Chong Yidong <cyd@gnu.org>
1281 * frame.c (delete_frame): When selecting a frame on a different
1282 text terminal, do not alter the terminal's top-frame.
1284 * xdisp.c (format_mode_line_unwind_data): Record the target
1285 frame's selected window and its terminal's top-frame.
1286 (unwind_format_mode_line): Restore them.
1287 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1289 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1290 since tty frames can be explicitly named.
1291 (prepare_menu_bars): Likewise.
1293 * term.c (Ftty_top_frame): New function.
1295 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1297 Port byte-code-meter to modern targets.
1298 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1299 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1300 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1301 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1302 (METER_1, METER_2): Simplify.
1304 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1306 * data.c (Fdefalias): Return `symbol' (bug#11686).
1308 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1310 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1311 gets killed during executing of this function (Bug#11665).
1312 Try to always return Qt when the buffer has been actually killed.
1313 (Vkill_buffer_query_functions): In doc-string say that functions
1314 run by this hook should not change the current buffer.
1316 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1318 Fix recently-introduced process.c problems found by static checking.
1319 * process.c (write_queue_push, write_queue_pop, send_process):
1320 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1321 (write_queue_pop): Fix pointer signedness problem.
1322 (send_process): Remove unused local.
1324 2012-06-17 Chong Yidong <cyd@gnu.org>
1326 * xdisp.c (redisplay_internal): No need to redisplay terminal
1327 frames that are not on top.
1329 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1331 * process.c (make_process): Initialize write_queue.
1332 (write_queue_push, write_queue_pop): New functions.
1333 (send_process): Use them to maintain correct ordering of process
1336 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1338 * lisp.h (eassert): Assume C89 or later.
1339 This removes the need for CHECK.
1340 (CHECK): Remove. Its comments about always evaluating its
1341 argument were confusing, as 'eassert' typically does not evaluate
1344 * coding.c (produce_chars): Use ptrdiff_t, not int.
1346 * xterm.c (x_draw_underwave): Check for integer overflow.
1347 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1349 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1351 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1352 referenced (Bug#11583).
1354 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1356 Implement wave-style variant of underlining.
1357 * dispextern.h (face_underline_type): New enum.
1358 (face): Add field for underline type.
1359 * nsterm.m (ns_draw_underwave): New function.
1360 (ns_draw_text_decoration): Use it.
1361 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1363 (x_draw_glyph_string): Use them.
1364 * xfaces.c (Qline, Qwave): New Lisp objects.
1365 (check_lface_attrs, merge_face_ref)
1366 (Finternal_set_lisp_face_attribute, realize_x_face):
1367 Handle wave-style underline face attributes.
1368 * xterm.c (x_draw_underwave): New function.
1369 (x_draw_glyph_string): Use it.
1371 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1373 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1374 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1375 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1376 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1377 ($(BLD)/w32select.$(O)): Update dependencies.
1379 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1381 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1382 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1383 * character.c (_fetch_multibyte_char_p): Remove.
1384 * alloc.c: Include "character.h" before "buffer.h".
1386 * buffer.c: Likewise.
1387 * bytecode.c: Likewise.
1388 * callint.c: Likewise.
1389 * callproc.c: Likewise.
1390 * casefiddle.c: Likewise.
1391 * casetab.c: Likewise.
1392 * category.c: Likewise.
1394 * coding.c: Likewise.
1395 * composite.c: Likewise.
1396 * dired.c: Likewise.
1397 * dispnew.c: Likewise.
1399 * dosfns.c: Likewise.
1400 * editfns.c: Likewise.
1401 * emacs.c: Likewise.
1402 * fileio.c: Likewise.
1403 * filelock.c: Likewise.
1405 * fontset.c: Likewise.
1406 * fringe.c: Likewise.
1407 * indent.c: Likewise.
1408 * insdel.c: Likewise.
1409 * intervals.c: Likewise.
1410 * keyboard.c: Likewise.
1411 * keymap.c: Likewise.
1412 * lread.c: Likewise.
1413 * macros.c: Likewise.
1414 * marker.c: Likewise.
1415 * minibuf.c: Likewise.
1416 * nsfns.m: Likewise.
1417 * nsmenu.m: Likewise.
1418 * print.c: Likewise.
1419 * process.c: Likewise.
1420 * regex.c: Likewise.
1421 * region-cache.c: Likewise.
1422 * search.c: Likewise.
1423 * syntax.c: Likewise.
1425 * textprop.c: Likewise.
1427 * unexsol.c: Likewise.
1428 * w16select.c: Likewise.
1429 * w32fns.c: Likewise.
1430 * w32menu.c: Likewise.
1431 * window.c: Likewise.
1432 * xdisp.c: Likewise.
1434 * xmenu.c: Likewise.
1436 * xselect.c: Likewise.
1438 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1440 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1441 If all the glyphs of the glyph row came from strings, and we have no
1442 cursor positioning clues, put the cursor on the first glyph of the
1444 (handle_face_prop): Use chunk-relative overlay string index when
1445 indexing into it->string_overlays array. (Bug#11653)
1446 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1447 the rightmost. (Bug#11720)
1449 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1451 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1452 (CATEGORY_MEMBER): Enforce 1/0 value.
1453 * category.c (_temp_category_set): Remove.
1455 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1457 * window.c (Fdelete_other_windows_internal)
1458 (Fdelete_window_internal): Don't access frame's mouse highlight
1459 info of the initial frame. (Bug#11677)
1461 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1463 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1464 Assume USE_2_TAGS_FOR_INTS.
1465 (xreload): Adjust $tagmask width to match recent lisp.h change.
1467 Simplify lisp.h in minor ways that should not affect code.
1468 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1469 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1470 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1471 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1472 (INTTYPEBITS): New macro, for clarity.
1473 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1474 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1475 Simplify now that USE_LSB_TAG is always defined.
1476 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1477 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1479 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1481 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1483 2012-06-13 Glenn Morris <rgm@gnu.org>
1485 * s/bsd-common.h (BSD4_3):
1486 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1488 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1490 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1493 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1495 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1496 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1497 * alloc.c (widen_to_Lisp_Object): Remove.
1498 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1499 * frame.c (delete_frame): Remove outdated comment.
1500 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1501 USE_LISP_UNION_TYPE.
1502 (Fw32_unregister_hot_key): Likewise.
1503 (Fw32_toggle_lock_key): Likewise.
1504 * w32menu.c (add_menu_item): Likewise.
1505 (w32_menu_display_help): Use XIL instead of checking
1506 USE_LISP_UNION_TYPE.
1507 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1508 (init_heap): Likewise.
1509 * w32term.c (w32_read_socket): Update comment.
1511 2012-06-13 Glenn Morris <rgm@gnu.org>
1513 * s/usg5-4-common.h, src/s/unixware.h:
1514 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1516 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1518 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1520 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1521 * alloc.c (make_number) [!defined make_number]:
1522 Remove, as lisp.h always defines this now.
1523 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1524 (roundup_size): Verify that it is a power of 2.
1525 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1526 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1527 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1528 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1529 USE_LSB_TAG now is always defined to be either 0 or 1.
1531 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1532 code works fine either way, and efficiency is not a concern here,
1533 as the union type is for debugging, not for production.
1534 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1535 Use an inline function on all platforms when using the union type,
1536 since this is simpler and 'static inline' can be used portably
1538 (LISP_INITIALLY_ZERO): New macro.
1539 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1540 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1542 2012-06-12 Glenn Morris <rgm@gnu.org>
1544 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1546 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1548 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1549 Move BROKEN_SIGIO to configure.
1551 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1552 Move NO_TERMIO to configure.
1554 2012-06-12 Chong Yidong <cyd@gnu.org>
1556 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1557 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1558 MagickExportImagePixels is undefined.
1560 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1562 * image.c (imagemagick_load_image): Remove unused label.
1564 2012-06-11 Glenn Morris <rgm@gnu.org>
1566 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1567 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1568 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1569 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1571 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * alloc.c (make_byte_code): New function.
1574 (Fmake_byte_code): Use it. Don't purify here.
1575 * lread.c (read1): Use it as well to avoid extra allocation.
1577 2012-06-11 Chong Yidong <cyd@gnu.org>
1579 * image.c (imagemagick_load_image): Implement transparency.
1581 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1583 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1584 account for preceding backslashes. (Bug#11663)
1586 2012-06-09 Chong Yidong <cyd@gnu.org>
1588 * term.c: Support italics in capable terminals (Bug#9652).
1589 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1590 (turn_on_face): Output using TS_enter_italic_mode if available.
1591 Don't handle unused blinking and alt-charset cases.
1592 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1593 and tty_alt_charset_p cases.
1594 (tty_capable_p, init_tty): Support italics.
1596 * termchar.h (struct tty_display_info): Add field for italics.
1597 Remove unused blink field.
1599 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1602 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1603 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1604 tty_alt_charset_p. Add tty_italic_p.
1606 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1608 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1609 dbus_type_is_basic if available.
1610 (xd_extract_signed, xd_extract_unsigned): Rename from
1611 extract_signed and extract_unsigned, respectively. Adapt callers.
1613 2012-06-09 Chong Yidong <cyd@gnu.org>
1615 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1617 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1620 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1622 * xdisp.c (vmessage): Treat frame message as multibyte.
1623 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1624 would generate the diagnostic "Making \302\247 buffer-local while
1627 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1629 * dispnew.c (showing_window_margins_p): Undo last change, which
1630 was done due to an inadvertent commit.
1631 (adjust_frame_glyphs_for_frame_redisplay): Do call
1632 showing_window_margins_p.
1634 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1636 * eval.c (Fmake_var_non_special): New primitive.
1637 (syms_of_eval): Defsubr it.
1638 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1640 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1642 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1643 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1645 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1647 * alloc.c (allocate_vectorlike): Fix last change.
1649 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1651 Block-based vector allocation of small vectors.
1652 * lisp.h (struct vectorlike_header): New field `nbytes',
1653 adjust comment accordingly.
1654 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1655 to denote vector blocks. Adjust users (live_vector_p,
1656 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1657 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1658 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1659 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1660 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1661 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1662 (roundup_size): New constant.
1663 (struct vector_block): New data type.
1664 (vector_blocks, vector_free_lists, zero_vector): New variables.
1665 (all_vectors): Rename to `large_vectors'.
1666 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1667 (sweep_vectors): New functions.
1668 (allocate_vectorlike): Return `zero_vector' as the only vector of
1669 0 items. Allocate new vector from block if vector size is less than
1670 or equal to VBLOCK_BYTES_MAX.
1671 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1672 (init_alloc_once): Add call to init_vectors.
1674 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1676 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1678 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1680 * doprnt.c (doprnt): Truncate multibyte char correctly.
1681 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1682 would mishandle a string argument "Xc" if X was a multibyte
1683 character of length 2: it would truncate after X's first byte
1684 rather than including all of X.
1686 2012-06-06 Chong Yidong <cyd@gnu.org>
1688 * buffer.c (word_wrap): Doc fix.
1690 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1692 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1694 2012-06-03 Glenn Morris <rgm@gnu.org>
1696 * xdisp.c (tool-bar-style): Doc fix.
1698 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1700 * Makefile.in (PAXCTL): Define.
1701 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1702 binary via PaX flags if the paxctl utility is available.
1703 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1704 Restore PaX flags to their default. (Bug#11398)
1706 2012-06-03 Chong Yidong <cyd@gnu.org>
1708 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1711 2012-06-03 Chong Yidong <cyd@gnu.org>
1713 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1714 (note_mode_line_or_margin_highlight): If there is no help echo,
1715 use mode-line-default-help-echo. Handle the case where the mouse
1716 position is past the end of the mode line string.
1718 * buffer.c (buffer_local_value_1): New function, split from
1719 Fbuffer_local_value; can return Qunbound.
1720 (Fbuffer_local_value): Use it.
1721 (Vmode_line_format): Docstring tweaks.
1723 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1725 * sysdep.c (system_process_attributes): Improve comment.
1727 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1729 * keyboard.c: Export real-this-command to Elisp.
1730 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1731 and DEFVAR it. Update all users.
1733 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1735 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1737 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1738 Convert pctcpu and pctmem to Lisp float properly.
1739 Let the compiler fold better, as 100.0/0x8000 is exact.
1741 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1743 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1746 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1748 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1750 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1752 For a 'struct window', replace some Lisp_Object fields to
1753 bitfields where appropriate, remove unused fields.
1754 * window.h (struct window): Remove unused 'last_mark_x' and
1755 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1756 change it's type from Lisp_Object to bitfield.
1757 Change type of 'force_start', 'optional_new_start',
1758 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1759 fields from Lisp_Object to bitfield. Adjust users accordingly.
1761 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1763 Pacify gcc -Wdouble-precision when using Xaw.
1764 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1765 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1766 Use 'float' consistently, rather than 'float' in most places
1767 and 'double' in a couple of places.
1769 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1771 * xdisp.c (handle_stop): Detect whether we have overlay strings
1772 loaded by testing it->current.overlay_string_index to be
1773 non-negative, instead of checking whether n_overlay_strings is
1774 positive. (Bug#11587)
1776 2012-05-31 Chong Yidong <cyd@gnu.org>
1778 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1780 * doc.c (Fsubstitute_command_keys): Doc fix.
1782 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1784 * search.c (search_buffer): Remove calls to
1785 r_alloc_inhibit_buffer_relocation, as it is now called by
1786 maybe_unify_char, which was the cause of relocation of buffer text
1789 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1791 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1792 for the duration of call to load_charset, to avoid problems with
1793 callers of maybe_unify_char that access buffer text through C
1796 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1797 decrement the inhibition flag, instead of just setting or
1800 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1802 Remove obsolete '#define static' cruft.
1803 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1804 This #undef was "temporary" in 2000; it is no longer needed
1805 now that '#define static' has gone away.
1806 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1807 (gray_bitmap_bits): Remove; no longer needed.
1808 All uses replaced with definiens.
1809 * xterm.c: Include "bitmaps/gray.xbm".
1811 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1813 Clean up __executable_start, monstartup when --enable-profiling.
1814 The following changes affect the code only when profiling.
1815 * dispnew.c (__executable_start): Rename from safe_bcopy.
1816 Define only on platforms that need it.
1817 * emacs.c: Include <sys/gmon.h> when profiling.
1818 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1819 (__executable_start): Remove decl, since lisp.h does it now.
1820 (safe_bcopy): Remove decl; no longer has that name.
1821 (main): Coalesce #if into single bit of code, for simplicity.
1822 Cast pointers to uintptr_t, since standard libraries want integers
1824 * lisp.h (__executable_start): New decl.
1826 2012-05-31 Glenn Morris <rgm@gnu.org>
1828 * image.c (Fimagemagick_types): Doc fix.
1830 2012-05-30 Jim Meyering <meyering@redhat.com>
1832 * callproc.c (Fcall_process_region): Include directory component
1833 in mkstemp error message (Bug#11586).
1835 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1837 * alloc.c, lisp.h (make_pure_vector): Now static.
1839 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1841 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1842 Move to byte-run.el.
1843 (Fautoload): Do the hash-doc more carefully.
1844 * data.c (Fdefalias): Purify definition, except for keymaps.
1845 (Qdefun): Move from eval.c.
1846 * lisp.h (Qdefun): Remove.
1847 * lread.c (read1): Tiny simplification.
1849 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1851 Do not create empty overlays with the evaporate property (Bug#9642).
1852 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1853 Bug#9642, but explicitly check that the buffer the overlay would
1854 be moved to is live and rearrange lines to make sure that errors
1855 will not put the overlay in an inconsistent state.
1856 (Fdelete_overlay): Cosmetics.
1858 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1860 * w32term.c (my_bring_window_to_top): New function.
1861 (x_raise_frame): Use handle returned by DeferWindowPos, which
1862 could be different from the original one.
1863 Call my_bring_window_to_top instead of my_set_foreground_window.
1866 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1867 by calling BringWindowToTop.
1869 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1870 (WM_EMACS_END): Increase by one.
1872 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1874 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1875 This avoids undefined behavior that might cause the eassert
1876 to not catch an out-of-range value.
1878 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1880 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1881 Update dependencies.
1883 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1885 * bidi.c (bidi_mirror_char): Fix last change.
1887 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1889 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1890 when referring to sectname field in printf format.
1892 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1894 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1895 Only r_alloc_inhibit_buffer_relocation needed to be added;
1896 the others were already declared.
1898 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1899 before checking whether it's out of range. Put the check inside
1901 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1903 2012-05-27 Ken Brown <kbrown@cornell.edu>
1905 * callproc.c (Fcall_process): Restore a line that was accidentally
1906 commented out in the 2011-02-13 change (bug#11547).
1908 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1910 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1911 defined on ralloc.c.
1913 * buffer.c [REL_ALLOC]: Remove prototypes of
1914 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1915 they are now on lisp.h.
1917 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1919 * search.c (search_buffer): Use it to inhibit relocation of buffer
1920 text while re_search_2 is doing its job, because re_search_2 is
1921 passed C pointers to buffer text. (Bug#11519)
1923 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1926 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1927 state after an additional call to move_it_in_display_line_to, keep
1928 the values of it->max_ascent and it->max_descent found for the
1930 (pos_visible_p): Revert the comparison against bottom_y to what it
1931 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1934 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1936 Fix coding-related core dumps with gcc -ftrapv.
1937 The code was computing A - B, where A and B are pointers, and B is
1938 random garbage. This can lead to core dumps on platforms that
1939 have special pointer registers, and it also leads to core dumps on
1940 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1941 A - B only when B is initialized properly.
1942 * coding.c (coding_set_source, coding_set_destination): Return void.
1943 (coding_change_source, coding_change_destinations): New functions,
1944 with the old behaviors of coding_set_source and coding_set_destination.
1945 All callers that need an offset changed to use these new functions.
1947 2012-05-26 Glenn Morris <rgm@gnu.org>
1949 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1951 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1953 Extend mouse support on W32 text-mode console.
1954 * xdisp.c (draw_row_with_mouse_face):
1955 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1957 * w32console.c: Include window.h.
1958 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1960 (initialize_w32_display): Initialize mouse-highlight data.
1962 * w32inevt.c: Include termchar.h and window.h.
1963 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1964 moves, call note_mouse_highlight. If help_echo changed, call
1965 gen_help_event to produce help-echo message in the echo area.
1966 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1969 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1971 * lread.c (read1): Simplify slightly to avoid an overflow warning
1972 with GCC 4.7.0 on x86-64.
1974 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1976 * bidi.c (bidi_mirror_char): Revert last change: an int is
1977 definitely wide enough here.
1979 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1981 Fix integer width and related bugs (Bug#9874).
1982 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1983 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1984 (string_bytes, check_sblock, allocate_string_data):
1985 (compact_small_strings, Fmake_bool_vector, make_string)
1986 (make_unibyte_string, make_multibyte_string)
1987 (make_string_from_bytes, make_specified_string)
1988 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1989 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1992 (allocate_pseudovector):
1993 Use int, not EMACS_INT, where int is wide enough.
1994 (inhibit_garbage_collection, Fgarbage_collect):
1995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1996 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1997 int might not be wide enough.
1998 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1999 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2000 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2001 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2002 (bidi_level_of_next_char, bidi_move_to_visually_next):
2003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2004 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2005 (Fkill_buffer, Fset_buffer_major_mode)
2006 (advance_to_char_boundary, Fbuffer_swap_text)
2007 (Fset_buffer_multibyte, overlays_at, overlays_in)
2008 (overlay_touches_p, struct sortvec, record_overlay_string)
2009 (overlay_strings, recenter_overlay_lists)
2010 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2011 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2012 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2013 (Foverlay_recenter, last_overlay_modification_hooks_used)
2014 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2016 (validate_region): Omit unnecessary test for b <= e,
2017 since that's guaranteed by the previous test.
2018 (adjust_overlays_for_delete): Avoid pos + length overflow.
2019 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2020 (report_overlay_modification):
2021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2022 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2023 Omit pointer cast, which isn't needed anyway, and doesn't work
2024 after the EMACS_INT -> ptrdiff_t change.
2025 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2026 * buffer.h: Adjust decls to match defn changes elsewhere.
2027 (struct buffer_text, struct buffer):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 Use EMACS_INT, not int, where int might not be wide enough.
2030 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2031 not int, to avoid needless 32-bit limit on 64-bit hosts.
2032 (exec_byte_code): Use tighter memory-full test, one that checks
2033 for alloca overflow. Don't compute the address of the object just
2034 before an array, as that's not portable. Use EMACS_INT, not
2035 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2036 * callint.c (Fcall_interactively):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 * callproc.c (call_process_kill, Fcall_process):
2039 Don't assume pid_t fits into an Emacs fixnum.
2040 (call_process_cleanup, Fcall_process, child_setup):
2041 Don't assume pid_t fits into int.
2042 (call_process_cleanup, Fcall_process, delete_temp_file)
2043 (Fcall_process_region):
2044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2045 (Fcall_process): Simplify handling of volatile integers.
2046 Use int, not EMACS_INT, where int will do.
2047 * casefiddle.c (casify_object, casify_region, operate_on_word)
2048 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (casify_object): Avoid integer overflow when overallocating buffer.
2051 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2052 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2053 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2054 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2055 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2056 integers are now checked earlier. All uses replaced with XINT.
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 For CCL_MapSingle, check that content and value are in int range.
2060 (ccl_driver, Fregister_code_conversion_map):
2061 Check that Vcode_version_map_vector is a vector.
2062 (resolve_symbol_ccl_program): Check that vector header is in range.
2063 Always copy the vector, so that we can check its contents reliably
2064 now rather than having to recheck each instruction as it's being
2065 executed. Check that vector words fit in 'int'.
2066 (ccl_get_compiled_code, Fregister_ccl_program)
2067 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2068 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2069 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2070 contents are in range.
2071 (Fccl_execute_on_string): Check that status is in range.
2072 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2073 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2074 Accept and return EMACS_INT, not int, because callers can pass values
2076 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2077 (multibyte_chars_in_text, parse_str_as_multibyte)
2078 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2079 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2080 (string_escape_byte8, Fget_byte):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2082 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2083 avoid mishandling large integers.
2084 * character.h: Adjust decls to match defn changes elsewhere.
2085 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2086 (Ffind_charset_region):
2087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2088 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2089 (load_charset_map_from_vector, Fdefine_charset_internal):
2090 Don't assume fixnum fits in int.
2091 (load_charset_map_from_vector, Fmap_charset_chars):
2092 Remove now-unnecessary CHECK_NATNUMs.
2093 (Fdefine_charset_internal): Check ranges here, more carefully.
2094 Don't rely on undefined behavior with signed left shift overflow.
2095 Don't assume unsigned int fits into fixnum, or that fixnum fits
2096 into unsigned int. Don't require max_code to be a valid fixnum;
2097 that's not true for gb10830 4-byte on a 32-bit host. Allow
2098 invalid_code to be a cons, for the same reason. Require code_offset
2099 to be a character. Avoid int overflow if max_char is close
2101 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2102 this is intended anyway and avoids some undefined behavior.
2103 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2104 INDEX_TO_CODE_POINT, as that's what it expects.
2105 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2106 * charset.h (DECODE_CHAR): Return int, not unsigned;
2107 this is what was intended anyway, and it avoids undefined behavior.
2108 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2109 integer-overflow issues.
2110 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2111 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2112 where the argument is EMACS_INT, and this behavior is not intended.
2113 * chartab.c (Fmake_char_table, Fset_char_table_range)
2114 (uniprop_get_decoder, uniprop_get_encoder):
2115 Don't assume fixnum fits in int.
2116 * cmds.c (move_point): New function, that does the gist of
2117 Fforward_char and Fbackward_char, but does so while checking
2118 for integer overflow more accurately.
2119 (Fforward_char, Fbackward_char): Use it.
2120 (Fforward_line, Fend_of_line, internal_self_insert)
2121 (internal_self_insert):
2122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2123 Fix a FIXME, by checking for integer overflow when calculating
2124 target_clm and actual_clm.
2125 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2126 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2127 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2128 (coding_alloc_by_making_gap, alloc_destination)
2129 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2130 (encode_coding_utf_16, detect_coding_emacs_mule)
2131 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2132 (detect_coding_iso_2022, decode_coding_iso_2022)
2133 (encode_invocation_designation, encode_designation_at_bol)
2134 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2135 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2136 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2137 (encode_coding_ccl, encode_coding_raw_text)
2138 (detect_coding_charset, decode_coding_charset)
2139 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2140 (produce_composition, produce_charset, produce_annotation)
2141 (decode_coding, handle_composition_annotation)
2142 (handle_charset_annotation, consume_chars, decode_coding_gap)
2143 (decode_coding_object, encode_coding_object, detect_coding_system)
2144 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2145 (code_convert_region, code_convert_string)
2146 (Fdefine_coding_system_internal)
2147 (coding_set_source, coding_set_destination):
2148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2149 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2150 (Fdefine_coding_system_internal):
2151 Don't assume fixnums fit in int.
2152 (decode_coding_gap, decode_coding_object, encode_coding_object)
2153 (Fread_coding_system, Fdetect_coding_region)
2154 (Funencodable_char_position, Fcheck_coding_systems_region)
2155 (get_translation, handle_composition_annotation, consume_chars):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2157 (consume_chars): Rewrite to not calculate an address outside buffer.
2158 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2159 Don't access memory outside of the args array.
2160 (Fdefine_coding_system_internal): Check for charset-id overflow.
2161 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2162 result of ENCODE_CHAR.
2163 * coding.h: Adjust decls to match defn changes elsewhere.
2164 (struct coding_system):
2165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2166 * composite.c (get_composition_id, find_composition)
2167 (run_composition_function, update_compositions)
2168 (compose_text, composition_gstring_put_cache)
2169 (composition_gstring_p, composition_gstring_width)
2170 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2171 (composition_compute_stop_pos, composition_reseat_it)
2172 (composition_update_it, struct position_record)
2173 (find_automatic_composition, composition_adjust_point)
2174 (Fcomposition_get_gstring, Ffind_composition_internal):
2175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2176 (update_compositions):
2177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2178 * composite.h: Adjust decls to match defn changes elsewhere.
2179 (struct composition):
2180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2181 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2182 Do not attempt to compute the address of the object just before a
2183 buffer; this is not portable.
2185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2186 (Faset): Use int, not EMACS_INT, where int is wide enough.
2187 (Fstring_to_number): Don't assume fixnums fit in int.
2188 (Frem): Don't assume arg is nonnegative.
2189 * dbusbind.c (xd_append_arg): Check for integers out of range.
2190 (Fdbus_call_method): Don't overflow the timeout int.
2191 (extract_signed, extract_unsigned): New functions.
2192 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2193 (xd_get_connection_references): Return ptrdiff_t, not int.
2195 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2196 (xd_read_message_1):
2197 Use int, not unsigned, where the dbus API uses int.
2198 (Fdbus_message_internal): Don't overflow mtype.
2199 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2200 * dired.c (directory_files_internal, file_name_completion, scmp)
2201 (file_name_completion_stat):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 (file_name_completion): Don't overflow matchcount.
2204 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2205 * dispextern.h: Adjust decls to match defn changes elsewhere.
2206 (struct text_pos, struct glyph, struct bidi_saved_info)
2207 (struct bidi_string_data, struct bidi_it, struct composition_it)
2209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 (struct display_pos, struct composition_it, struct it):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 * dispnew.c (increment_matrix_positions)
2213 (increment_row_positions, mode_line_string)
2214 (marginal_area_string):
2215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2216 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2218 (duration_to_sec_usec): New function, to check for overflow better.
2219 (Fsleep_for, sit_for): Use it.
2220 * doc.c (get_doc_string, store_function_docstring):
2221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2222 (get_doc_string, Fsnarf_documentation):
2223 Use int, not EMACS_INT, where int is wide enough.
2225 Use SAFE_ALLOCA, not alloca.
2226 Check for overflow when converting EMACS_INT to off_t.
2227 * doprnt.c (doprnt):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2230 Don't assume uid_t fits into fixnum.
2231 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2232 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2233 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2234 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2235 (general_insert_function)
2236 (Finsert_char, make_buffer_string, make_buffer_string_both)
2237 (update_buffer_properties, Fbuffer_substring)
2238 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2239 (Fsubst_char_in_region, check_translation)
2240 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2241 (transpose_markers, Ftranspose_regions):
2242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2243 (clip_to_bounds): Move to lisp.h as an inline function).
2244 (Fconstrain_to_field): Don't assume integers are nonnegative.
2245 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2246 (Fsubst_char_in_region, Fsave_restriction):
2247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2248 (Femacs_pid): Don't assume pid_t fits into fixnum.
2249 (lo_time): Use int, not EMACS_INT, when int suffices.
2250 (lisp_time_argument): Check for usec out of range.
2251 (Fencode_time): Don't assume fixnum fits in int.
2252 (Fuser_login_name, Fuser_full_name): Signal an error
2253 if a uid argument is out of range, rather than relying on
2255 (Fformat_time_string): Remove now-unnecessary check.
2256 lisp_time_argument checks for out-of-range usec now.
2257 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2258 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2259 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2260 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2261 (init_cmdargs, Fdump_emacs):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2264 the bottom (typically) 32 bits of the fixnum.
2265 * eval.c (specpdl_size, call_debugger):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (when_entered_debugger, Fbacktrace_debug):
2268 Don't assume fixnum can fit in int.
2269 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2270 the object just before a buffer; this is not portable.
2271 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2272 (grow_specpdl, unbind_to):
2273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2274 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2275 (grow_specpdl): Simplify allocation by using xpalloc.
2276 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2277 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2278 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 (Fcopy_file, non_regular_nbytes, read_non_regular)
2284 (Finsert_file_contents):
2285 Use int, not EMACS_INT, where int is wide enough.
2286 (READ_BUF_SIZE): Verify that it fits in int.
2287 (Finsert_file_contents): Check that counts are in proper range,
2288 rather than assuming fixnums fit into ptrdiff_t etc.
2289 Don't assume fixnums fit into int.
2290 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2291 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2292 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2293 (string_char_to_byte, string_byte_to_char)
2294 (string_make_multibyte, string_to_multibyte)
2295 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2296 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2297 (substring_both, Fdelete, internal_equal, Ffillarray)
2298 (Fclear_string, mapcar1)
2299 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2300 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2301 (larger_vector, make_hash_table, maybe_resize_hash_table)
2302 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2303 (Fmaphash, secure_hash):
2304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2305 (concat): Check for string index and length overflow.
2306 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 (larger_vector): New API (vec, incr_min, size_max) replaces old
2310 one (vec, new_size, init). This catches size overflow.
2311 INIT was removed because it was always Qnil.
2312 All callers changed.
2313 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2314 the upper bound on a hash table index size.
2315 (make_hash_table, maybe_resize_hash_table): Use it.
2316 (secure_hash): Computer start_byte and end_byte only after
2317 they're known to be in ptrdiff_t range.
2318 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2319 (Ffont_get_glyphs, Ffont_at):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2322 (Flist_fonts, Fopen_font):
2323 Don't assume fixnum can fit in int.
2324 (check_gstring): Don't assume index can fit in int.
2325 (font_match_p): Check that fixnum is a character, not a nonnegative
2326 fixnum, since the later code needs to stuff it into an int.
2327 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2328 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2329 conversion overflow issues.
2330 (Fopen_font): Check for integer out of range.
2331 (Ffont_get_glyphs): Don't assume index can fit in int.
2332 * font.h: Adjust decls to match defn changes elsewhere.
2333 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2335 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2336 printmax_t, where ptrdiff_t is wide enough.
2337 (Finternal_char_font):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2339 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2340 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2341 (Fset_frame_position, x_set_frame_parameters)
2342 (x_set_line_spacing, x_set_border_width)
2343 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2344 Check that fixnums are in proper range for system types.
2345 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2347 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2348 Use SAFE_ALLOCA_LISP, not alloca.
2349 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2350 intptr_t is wide enough.
2351 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2352 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2353 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2354 Check for fixnum out of range.
2355 * ftfont.c (ftfont_list): Don't assume index fits in int.
2356 Check that fixnums are in proper range for system types.
2357 (ftfont_shape_by_flt):
2358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2359 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2361 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2362 Check that fixnums are in proper range for system types.
2363 * gnutls.h: Adjust decls to match defn changes elsewhere.
2364 * gtkutil.c (xg_dialog_run):
2365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2366 (update_frame_tool_bar):
2367 Check that fixnums are in proper range for system types.
2368 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2369 (lookup_image): Check that fixnums are in range for system types.
2370 * indent.c (last_known_column, last_known_column_point):
2371 (current_column_bol_cache):
2372 (skip_invisible, current_column, check_display_width):
2373 (check_display_width, scan_for_column, current_column_1)
2374 (Findent_to, Fcurrent_indentation, position_indentation)
2375 (indented_beyond_p, Fmove_to_column, compute_motion):
2376 (Fcompute_motion, Fvertical_motion):
2377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2378 (last_known_column_modified): Use EMACS_INT, not int.
2379 (check_display_width):
2381 Check that fixnums and floats are in proper range for system types.
2382 (compute_motion): Don't assume index or fixnum fits in int.
2383 (compute_motion, Fcompute_motion):
2384 Use int, not EMACS_INT, when it is wide enough.
2385 (vmotion): Omit local var start_hpos that is always 0; that way
2386 we don't need to worry about overflow in expressions involving it.
2387 * indent.h: Adjust decls to match defn changes elsewhere.
2389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2390 Use int, not EMACS_INT, where int is wide enough.
2391 Remove unused members ovstring_chars_done and tab_offset;
2393 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2394 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2395 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2396 (make_gap, copy_text, insert, insert_and_inherit)
2397 (insert_before_markers, insert_before_markers_and_inherit)
2398 (insert_1, count_combining_before, count_combining_after)
2399 (insert_1_both, insert_from_string)
2400 (insert_from_string_before_markers, insert_from_string_1)
2401 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2402 (adjust_after_replace, adjust_after_insert, replace_range)
2403 (replace_range_2, del_range, del_range_1, del_range_byte)
2404 (del_range_both, del_range_2, modify_region)
2405 (prepare_to_modify_buffer, signal_before_change)
2406 (signal_after_change, Fcombine_after_change_execute):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2409 (balance_an_interval, split_interval_right, split_interval_left)
2410 (find_interval, next_interval, update_interval)
2411 (adjust_intervals_for_insertion, delete_node, delete_interval)
2412 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2413 (static_offset_intervals, offset_intervals)
2414 (merge_interval_right, merge_interval_left, make_new_interval)
2415 (graft_intervals_into_buffer, temp_set_point_both)
2416 (temp_set_point, set_point, adjust_for_invis_intang)
2417 (set_point_both, move_if_not_intangible, get_property_and_range)
2418 (get_local_map, copy_intervals, copy_intervals_to_string)
2419 (compare_string_intervals, set_intervals_multibyte_1):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 * intervals.h: Adjust decls to match defn changes elsewhere.
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 * keyboard.c (this_command_key_count, this_single_command_key_start)
2425 (before_command_key_count, before_command_echo_length, echo_now)
2426 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2427 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2428 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2429 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 (last_non_minibuf_size, last_point_position, echo_truncate)
2432 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2433 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2434 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2435 (stuff_buffered_input):
2436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2437 (last_auto_save, command_loop_1, read_char):
2438 Use EMACS_INT, not int, to avoid integer overflow.
2439 (record_char): Avoid overflow in total_keys computation.
2440 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2441 * keyboard.h: Adjust decls to match defn changes elsewhere.
2442 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2443 (Fkey_description, Fdescribe_vector, Flookup_key):
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 (click_position): New function, to check that positions are in range.
2446 (Fcurrent_active_maps):
2448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2449 (Faccessible_keymaps, Fkey_description):
2450 (preferred_sequence_p):
2451 Don't assume fixnum can fit into int.
2452 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2453 Check for integer overflow in size calculations.
2454 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2455 avoid mishandling large integers.
2456 * lisp.h: Adjust decls to match defn changes elsewhere.
2457 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2458 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2459 (struct Lisp_Marker):
2460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2461 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2462 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2463 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2464 All callers changed.
2465 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2466 Assume the arg has valid form, since it always does.
2467 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2468 unsigned integer system type.
2469 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2470 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2472 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2473 (duration_to_sec_usec): New decl.
2474 * lread.c (read_from_string_index, read_from_string_index_byte)
2475 (read_from_string_limit, readchar, unreadchar, openp)
2476 (read_internal_start, read1, oblookup):
2477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2478 (Fload, readevalloop, Feval_buffer, Feval_region):
2479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2480 (openp): Check for out-of-range argument to 'access'.
2481 (read1): Use int, not EMACS_INT, where int is wide enough.
2482 Don't assume fixnum fits into int.
2483 Fix off-by-one error that can read outside a buffer.
2484 (read_filtered_event): Use duration_to_sec_usec
2485 to do proper overflow checking on durations.
2486 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2487 in size calculation.
2488 (Fexecute_kbd_macro):
2489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2490 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2491 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2492 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2493 (set_marker_both, set_marker_restricted_both, marker_position)
2494 (marker_byte_position, Fbuffer_has_markers_at):
2495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2496 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2497 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2498 It now merely ensures that the menu is large enough, without
2499 necessarily growing it, as this avoids some integer overflow issues.
2500 All callers changed.
2501 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2503 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2504 Use SAFE_ALLOCA_LISP, not alloca.
2505 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2506 to EMACS_INT. Check that fixnums are in proper range for system types.
2507 * minibuf.c (minibuf_prompt_width, string_to_object)
2508 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2509 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (get_minibuffer, read_minibuf_unwind):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2514 this simplifies overflow checking. All callers changed.
2515 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2518 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2519 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2520 Check that fixnums are in proper range for system types.
2521 (Fx_create_frame, Fx_show_tip):
2522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2523 * nsfont.m (ns_findfonts, nsfont_list_family):
2524 Don't assume fixnum fits in long.
2525 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2527 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2529 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2532 (PRINTDECLARE, PRINTPREPARE):
2533 (strout, print_string):
2534 (print, print_preprocess, print_check_string_charset_prop)
2536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2538 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2540 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2541 (printchar, strout): Use xpalloc to catch size calculation overflow.
2542 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2543 (print_error_message): Use SAFE_ALLOCA, not alloca.
2544 (print_object): Use int, not EMACS_INT, where int is wide enough.
2545 (print_depth, new_backquote_output, print_number_index):
2546 Use ptrdiff_t, not int, where int might not be wide enough.
2547 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2548 (Fset_process_window_size, Fformat_network_address)
2549 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2551 Check that fixnums are in proper range for system types.
2552 (Fsignal_process): Simplify by avoiding a goto.
2553 Check for process-ids out of pid_t range rather than relying on
2555 (process_tick, update_tick): Use EMACS_INT, not int.
2556 (Fformat_network_address, read_process_output, send_process)
2557 (Fprocess_send_region, status_notify):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2559 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2560 (wait_reading_process_output, read_process_output, exec_sentinel):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2563 (Faccept_process_output): Use duration_to_sec_usec to do proper
2564 overflow checking on durations.
2565 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2566 Don't assume pid_t fits in int.
2567 * process.h (struct Lisp_Process): Members tick and update_tick
2568 are now of type EMACS_INT, not int.
2569 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2570 configured --with-wide-int.
2571 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2572 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2573 * search.c (looking_at_1, string_match_1):
2574 (fast_string_match, fast_c_string_match_ignore_case)
2575 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2576 (scan_newline, find_before_next_newline, search_command)
2577 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2578 (set_search_regs, wordify):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (string_match_1, search_buffer, set_search_regs):
2584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2585 (wordify): Check for overflow in size calculation.
2586 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2587 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2588 Check that fixnums are in proper range for system types.
2589 * sound.c (struct sound_device)
2590 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2592 (Fplay_sound_internal):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2594 * syntax.c (struct lisp_parse_state, find_start_modiff)
2595 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2596 (Fparse_partial_sexp):
2597 Don't assume fixnums can fit in int.
2598 (struct lisp_parse_state, find_start_pos, find_start_value)
2599 (find_start_value_byte, find_start_begv)
2600 (update_syntax_table, char_quoted, dec_bytepos)
2601 (find_defun_start, prev_char_comend_first, back_comment):
2602 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2603 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2605 (Finternal_describe_syntax_value): Check that match_lisp is a
2606 character, not an integer, since the code stuffs it into int.
2607 (scan_words, scan_sexps_forward):
2608 Check that fixnums are in proper range for system types.
2610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2611 (scan_sexps_forward):
2612 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2613 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2614 * syntax.h: Adjust decls to match defn changes elsewhere.
2615 (struct gl_state_s):
2616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2617 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2618 MOST_POSITIVE_FIXNUM.
2619 * sysdep.c (wait_for_termination_1, wait_for_termination)
2620 (interruptible_wait_for_termination, mkdir):
2621 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2622 (emacs_read, emacs_write):
2623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2624 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2625 and double all fit in int.
2626 * term.c (set_tty_color_mode):
2627 Check that fixnums are in proper range for system types.
2628 * termhooks.h (struct input_event):
2629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2630 * textprop.c (validate_interval_range, interval_of)
2631 (Fadd_text_properties, set_text_properties_1)
2632 (Fremove_text_properties, Fremove_list_of_text_properties)
2633 (Ftext_property_any, Ftext_property_not_all)
2634 (copy_text_properties, text_property_list, extend_property_ranges)
2635 (verify_interval_modification):
2636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2637 (Fnext_single_char_property_change)
2638 (Fprevious_single_char_property_change):
2639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2640 (copy_text_properties):
2641 Check for integer overflow in index calculation.
2642 * undo.c (last_boundary_position, record_point, record_insert)
2643 (record_delete, record_marker_adjustment, record_change)
2644 (record_property_change):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2648 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2649 (Fx_hide_tip, Fx_file_dialog):
2650 * w32menu.c (set_frame_menubar):
2651 Use ptrdiff_t, not int, for consistency with rest of code.
2652 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2653 (select_window, Fdelete_other_windows_internal)
2654 (window_scroll_pixel_based, window_scroll_line_based)
2655 (Frecenter, Fset_window_configuration):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 (Fset_window_hscroll, run_window_configuration_change_hook)
2658 (set_window_buffer, temp_output_buffer_show, scroll_command)
2659 (Fscroll_other_window, Frecenter):
2660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2661 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2662 Don't assume fixnum fits in int.
2663 (Fset_window_scroll_bars):
2664 Check that fixnums are in proper range for system types.
2665 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2666 (string_pos, c_string_pos, number_of_chars, init_iterator)
2667 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2668 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2669 (compute_display_string_end, handle_face_prop)
2670 (face_before_or_after_it_pos, handle_invisible_prop)
2671 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2672 (display_prop_intangible_p, string_buffer_position_lim)
2673 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2674 (get_overlay_strings_1, get_overlay_strings)
2675 (iterate_out_of_display_property, forward_to_next_line_start)
2676 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2677 (get_next_display_element, set_iterator_to_next)
2678 (get_visually_first_element, compute_stop_pos_backwards)
2679 (handle_stop_backwards, next_element_from_buffer)
2680 (move_it_in_display_line_to, move_it_in_display_line)
2681 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2682 (add_to_log, message_dolog, message_log_check_duplicate)
2683 (message2, message2_nolog, message3, message3_nolog
2684 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2685 (current_message_1, truncate_echo_area, truncate_message_1)
2686 (set_message, set_message_1, store_mode_line_noprop)
2687 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2688 (text_outside_line_unchanged_p, check_point_in_composition)
2689 (reconsider_clip_changes)
2690 (redisplay_internal, set_cursor_from_row, try_scrolling)
2691 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2692 (redisplay_window, find_last_unchanged_at_beg_row)
2693 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2694 (trailing_whitespace_p, find_row_edges, display_line)
2695 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2696 (display_mode_element, store_mode_line_string)
2697 (pint2str, pint2hrstr, decode_mode_spec)
2698 (display_count_lines, display_string, draw_glyphs)
2699 (x_produce_glyphs, x_insert_glyphs)
2700 (rows_from_pos_range, mouse_face_from_buffer_pos)
2701 (fast_find_string_pos, mouse_face_from_string_pos)
2702 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2704 (safe_call, init_from_display_pos, handle_fontified_prop)
2705 (handle_single_display_spec, load_overlay_strings)
2706 (with_echo_area_buffer, setup_echo_area_for_printing)
2707 (display_echo_area, echo_area_display)
2708 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2709 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2710 (redisplay_window, dump_glyph_row, display_mode_line)
2711 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2712 (handle_display_spec, display_prop_string_p):
2713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2714 (handle_single_display_spec, build_desired_tool_bar_string)
2715 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2716 (get_specified_cursor_type):
2717 Check that fixnums are in proper range for system types.
2718 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2719 (Flookup_image_map):
2720 Don't assume fixnums fit in int.
2721 (compare_overlay_entries):
2722 Avoid mishandling comparisons due to subtraction overflow.
2723 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2724 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2725 (handle_tool_bar_click):
2726 Use int, not unsigned, since we prefer signed and the signedness
2727 doesn't matter here.
2728 (get_next_display_element, next_element_from_display_vector):
2729 Use int, not EMACS_INT, when int is wide enough.
2730 (start_hourglass): Use duration_to_sec_usec to do proper
2731 overflow checking on durations.
2732 * xfaces.c (Fbitmap_spec_p):
2733 Check that fixnums are in proper range for system types.
2734 (compare_fonts_by_sort_order):
2735 Avoid mishandling comparisons due to subtraction overflow.
2736 (Fx_family_fonts, realize_basic_faces):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2739 Don't assume fixnum fits in int.
2740 Use SAFE_ALLOCA_LISP, not alloca.
2741 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2742 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2743 (face_at_buffer_position, face_for_overlay_string)
2744 (face_at_string_position):
2745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2746 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2747 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2749 Check that fixnums are in proper range for system types.
2750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2751 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2753 (Fx_change_window_property): Don't assume fixnums fit in int.
2754 * xfont.c (xfont_chars_supported):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2757 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 * xml.c (parse_region):
2760 * xrdb.c (magic_file_p):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2763 (x_get_local_selection, x_reply_selection_request)
2764 (x_handle_selection_request, wait_for_property_change):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2767 short is wide enough.
2768 (x_send_client_event): Don't assume fixnum fits in int.
2769 * xterm.c (x_x_to_emacs_modifiers):
2770 Don't assume EMACS_INT overflows nicely into int.
2771 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2773 (handle_one_xevent): NATNUMP can eval its arg twice.
2774 (x_connection_closed):
2775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2776 * xterm.h: Adjust decls to match defn changes elsewhere.
2777 (struct scroll_bar): Use struct vectorlike_header
2778 rather than rolling our own approximation.
2779 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2781 2012-05-25 Glenn Morris <rgm@gnu.org>
2783 * lisp.mk (lisp): Update for more files being compiled now.
2785 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2787 * lread.c: Remove `read_pure' which makes no difference.
2788 (read_pure): Remove var.
2789 (unreadpure): Remove function.
2790 (readevalloop): Don't call read_list with -1 flag.
2791 (read1, read_vector): Don't test read_pure any more.
2792 (read_list): Simplify.
2794 * fileio.c, character.h: Minor style tweaks.
2796 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2798 * window.h (clip_changed): Remove useless declaration.
2800 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2802 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2803 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2805 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2808 This directory predates autoconf and is no longer needed nowadays.
2809 Move its few remaining bits of functionality to where they're needed.
2810 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2811 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2812 * m/template.h: Remove.
2813 * Makefile.in (M_FILE): Remove. All uses removed.
2814 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2815 * lisp.h (USE_LSB_TAG):
2816 * mem-limits.h (EXCEEDS_LISP_PTR):
2817 Use VAL_MAX, not VALBITS, in #if.
2818 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2819 (EMACS_UINT): Define unconditionally now.
2820 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2821 (BITS_PER_EMACS_INT): New constants, replacing
2822 what used to be in config.h, but not useful in #if.
2823 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2824 define them any more.
2825 (VAL_MAX): New macro.
2827 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2828 BITS_PER_EMACS_INT, in #if.
2829 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2830 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2831 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2832 * s/ms-w32.h (DATA_START):
2833 Move here from removed file m/intel386.h.
2834 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2835 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2837 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2839 Assume C89 or later.
2840 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2841 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2843 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2844 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2845 * textprop.c, tparam.c (NULL): Remove.
2846 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2847 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2848 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2849 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2850 * xterm.c (input_signal_count): Assume volatile works.
2852 2012-05-21 Ken Brown <kbrown@cornell.edu>
2854 * xgselect.c (xg_select): Fix first argument in call to 'select'
2857 2012-05-20 Ken Brown <kbrown@cornell.edu>
2859 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2860 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2862 2012-05-19 Ken Brown <kbrown@cornell.edu>
2864 * xfns.c (x_in_use): Remove `static' qualifier.
2865 * xterm.h (x_in_use): Declare.
2866 * xgselect.c: Include xterm.h.
2867 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2868 and `display_arg' (bug#9754).
2870 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2872 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2874 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2875 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2877 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2879 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2881 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2882 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2884 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2885 reference to image_cache->refcount.
2886 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2888 2012-05-17 Juri Linkov <juri@jurta.org>
2890 * search.c (Fword_search_regexp, Fword_search_backward)
2891 (Fword_search_forward, Fword_search_backward_lax)
2892 (Fword_search_forward_lax): Move functions to isearch.el
2893 (bug#10145, bug#11381).
2895 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2897 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2899 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2901 * lread.c (init_obarray): Declare Qt and Qnil as special.
2903 2012-05-14 Glenn Morris <rgm@gnu.org>
2905 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2906 Put "libexec" before "bin", for the sake of init_callproc_1.
2908 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2910 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2912 * unexaix.c: Port to more-recent AIX compilers.
2913 (report_error, report_error_1, make_hdr, copy_sym)
2914 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2915 Make arguments const char *, not char *, to avoid violations of C
2916 standard and to fix some AIX warnings reported by Gilles Pion.
2918 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2920 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2921 already have overlays loaded.
2922 (handle_single_display_spec): Before returning without displaying
2923 fringe bitmap, synchronize the bidi iterator with the main display
2924 iterator, by calling iterate_out_of_display_property.
2925 (iterate_out_of_display_property): Detect buffer iteration by
2926 testing that it->string is a Lisp string.
2927 (get_next_display_element): When the current object is exhausted,
2928 and there's something on it->stack, call set_iterator_to_next to
2929 proceed with what's on the stack, instead of returning zero.
2930 (set_iterator_to_next): If called at the end of a Lisp string,
2931 proceed to consider_string_end without incrementing string
2932 position. Don't increment display vector index past the end of
2933 the display vector. (Bug#11417)
2934 (pos_visible_p): Don't report a position visible when move_it_to
2935 stopped at the last line of window, which happens to be scanned
2936 backwards by the bidi iteration. (Bug#11464)
2938 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2940 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2941 and right-margin display specs even if the spec is invalid or we
2942 are on a TTY, and thus unable to display on the fringes.
2943 That's because the text with the property will not be displayed anyway,
2944 so we need to signal to the caller that this is a "replacing"
2945 display spec. This fixes display when the spec is invalid or we
2948 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2950 * unexaix.c (make_hdr): Fix typo in prototype.
2951 This bug broke the build on AIX. Problem reported by Gilles Pion.
2953 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2955 * keyboard.c (kbd_buffer_get_event): Read special events also in
2956 batch mode. (Bug#11415)
2958 2012-05-12 Glenn Morris <rgm@gnu.org>
2960 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2962 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2964 * lisp.mk (lisp): Add newcomment.elc.
2966 2012-05-12 Glenn Morris <rgm@gnu.org>
2968 * Makefile.in (MKDIR_P): New, set by configure.
2969 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2971 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2973 Remove unused function hourglass_started.
2974 * dispextern.h (hourglass_started):
2975 * w32fns.c (hourglass_started):
2976 * xdisp.c (hourglass_started): Remove.
2978 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2980 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2981 Update dependencies.
2983 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2985 * xgselect.c (xg_select): Put maxfds+1 into a var.
2986 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2988 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2990 2012-05-10 Dave Abrahams <dave@boostpro.com>
2992 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2993 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2995 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2997 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2998 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2999 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3000 Initialize xd_registered_buses.
3002 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3004 Untag more efficiently if USE_LSB_TAG.
3005 This is based on a proposal by YAMAMOTO Mitsuharu in
3006 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3007 For an admittedly artificial (nth 8000 longlist) benchmark on
3008 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3009 Emacs's overall text size by 1%.
3010 * lisp.h (XUNTAG): New macro.
3011 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3012 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3013 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3014 * eval.c (Fautoload):
3015 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3016 * frame.h (XFRAME): Use XUNTAG.
3018 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3019 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3020 Remove unportable assumptions about print widths of types like
3022 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3023 intptr_t when converting between pointer and integer, to avoid GCC
3024 warnings about wrong width.
3026 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3028 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3029 stack for each reader_thread, instead of defaulting to 8MB
3030 determined by the linker. This avoids failures in creating
3031 subprocesses on Windows 7, see the discussion in this thread:
3032 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3034 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3036 Fix up display of the *Minibuf-0* buffer in the mini window.
3037 * keyboard.c (read_char): Don't clear the echo area if there's no
3039 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3040 contents of *Minibuf-0*) if there's no message displayed in its stead.
3042 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3044 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3047 2012-05-06 Chong Yidong <cyd@gnu.org>
3049 * lisp.mk (lisp): Update.
3051 2012-05-05 Jim Meyering <meyering@redhat.com>
3053 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3055 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3057 * data.c (PUT_ERROR): New macro.
3058 (syms_of_data): Use it. Add new error type `user-error'.
3059 * undo.c (user_error): New function.
3060 (Fprimitive_undo): Use it.
3061 * print.c (print_error_message): Adjust print style for `user-error'.
3062 * keyboard.c (user_error): New function.
3063 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3065 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3067 Do not limit current-time-string to years 1000..9999.
3068 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3069 (Fcurrent_time_string): Support any year that is supported by the
3070 underlying localtime representation. Don't use asctime, as it
3071 has undefined behavior for years outside the range -999..9999.
3073 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3075 Fix race conditions involving setenv, gmtime, localtime, asctime.
3076 Without this fix, interrupts could mess up code that uses these
3077 nonreentrant functions, since setting TZ invalidates existing
3078 tm_zone or tzname values, and since most of these functions return
3079 pointers to static storage.
3080 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3081 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3082 Grow the critical sections to include not just invoking
3083 localtime/gmtime, but also accessing these functions' results
3084 including their tm_zone values if any, and any related TZ setting.
3085 (format_time_string): Last arg is now struct tm *, not struct tm **,
3086 so that the struct tm is saved in the critical section.
3087 All callers changed. Simplify allocation of initial buffer, partly
3088 motivated by the fact that memory allocation needs to be outside
3089 the critical section.
3091 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3093 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3094 with RESET_INTERVAL.
3096 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3097 Remove duplicated buffer name initialization.
3099 2012-05-02 Jim Meyering <jim@meyering.net>
3101 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3103 * xfns.c (x_window): Use xstrdup (Bug#11375).
3105 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3107 * xdisp.c (pos_visible_p): If already at a newline from the
3108 display string before the 'while' loop, don't walk back the glyphs
3109 from it3.glyph_row. Solves assertion violation when the display
3110 string begins with a newline (egg.el). (Bug#11367)
3112 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3114 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3117 2012-05-01 Glenn Morris <rgm@gnu.org>
3119 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3120 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3121 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3122 All were removed before 23.1.
3124 * dispnew.c: Remove HAVE_LIBNCURSES test;
3125 it is always true on relevant platforms.
3127 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3128 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3130 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3132 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3134 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3135 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3138 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3140 Do not avoid creating empty evaporating overlays (Bug#9642).
3141 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3142 That is, do not delete an evaporating overlay if it becomes
3143 empty after its bounds are adjusted to fit within its buffer.
3144 This fix caused other problems, and I'm reverting it until we get
3145 to the bottom of them.
3147 2012-04-27 Chong Yidong <cyd@gnu.org>
3149 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3151 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3153 * xdisp.c (pos_visible_p): If the window start position is beyond
3154 ZV, start the display from buffer beginning. Prevents assertion
3155 violation in init_iterator when the minibuffer window is scrolled
3158 * window.c (window_scroll_pixel_based): Likewise.
3160 2012-04-27 Chong Yidong <cyd@gnu.org>
3162 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3164 2012-04-27 Glenn Morris <rgm@gnu.org>
3166 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3167 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3169 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3171 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3172 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3174 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3176 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3177 display element, check also the underlying string or buffer
3178 character. (Bug#11341)
3180 * w32menu.c: Include w32heap.h.
3181 (add_menu_item): If the call to AppendMenuW (via
3182 unicode_append_menu) fails, disable Unicode menus only if we are
3183 running on Windows 9X/Me.
3185 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3187 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3188 (xgetint): Add missing shift for LSB tags.
3190 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3192 * keyboard.c (read_char): Don't wipe echo area for select window
3193 events: These might get delayed via `mouse-autoselect-window'
3196 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3198 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3199 manipulation of :loaded-from data.
3201 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3203 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3204 now a cons (bug#11311).
3206 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3208 Do not create empty overlays with the evaporate property (Bug#9642).
3209 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3210 if it becomes empty after its bounds are adjusted to fit within
3211 its buffer. Without this fix, in a nonempty buffer (let ((o
3212 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3213 yields an empty overlay that has the evaporate property, which is
3214 not supposed to happen.
3216 Fix minor GTK3 problems found by static checking.
3217 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3218 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3219 (struct _EmacsFixedClass, emacs_fixed_get_type):
3220 Move decls here from emacsgtkfixed.h, since they needn't be public.
3221 (emacs_fixed_get_type): Now static.
3222 (emacs_fixed_class_init): Omit unused local.
3223 (emacs_fixed_child_type): Remove; unused.
3224 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3225 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3226 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3227 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3228 (EMACS_FIXED_GET_CLASS): Remove; unused.
3229 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3231 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3232 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3234 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3236 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3237 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3238 (__malloc_size_t, __malloc_ptrdiff_t):
3239 Remove. All uses removed, replaced by the definiens if needed,
3240 since we can assume C89 or better now.
3241 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3242 (protect_malloc_state, align, get_contiguous_space)
3243 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3244 (malloc_atfork_handler_child, malloc_enable_thread)
3245 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3246 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3247 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3248 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3249 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3250 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3251 Define using prototypes, not old style.
3252 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3253 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3254 (align): Don't assume that signed integer overflow wraps around.
3255 Omit unused local var.
3256 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3257 (_free_internal_nolock, memalign, mallochook, reallochook):
3258 Omit no-longer-needed casts.
3259 (valloc): Use getpagesize, not __getpagesize.
3260 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3261 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3263 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3265 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3267 Move functions from C to Lisp. Make non-blocking method calls
3268 the default. Implement further D-Bus standard interfaces.
3270 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3271 (QCdbus_request_name_allow_replacement)
3272 (QCdbus_request_name_replace_existing)
3273 (QCdbus_request_name_do_not_queue)
3274 (QCdbus_request_name_reply_primary_owner)
3275 (QCdbus_request_name_reply_in_queue)
3276 (QCdbus_request_name_reply_exists)
3277 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3278 (QCdbus_registered_serial, QCdbus_registered_method)
3279 (QCdbus_registered_signal): New Lisp objects.
3280 (XD_DEBUG_MESSAGE): Use sizeof.
3281 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3282 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3283 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3284 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3285 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3286 (xd_signature, xd_append_arg): Allow float for integer types.
3287 (xd_get_connection_references): New function.
3288 (xd_get_connection_address): Rename from xd_initialize.
3289 Return cached address.
3290 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3291 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3293 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3294 Return number of refcounts.
3295 (Fdbus_get_unique_name): Make stronger parameter check.
3296 (Fdbus_message_internal): New defun.
3297 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3298 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3299 (Fdbus_send_signal, Fdbus_register_service)
3300 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3301 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3302 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3303 (Vdbus_compiled_version, Vdbus_runtime_version)
3304 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3305 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3306 (Vdbus_message_type_signal): New defvars.
3307 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3310 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3312 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3313 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3314 Do not assume ptrdiff_t is the same width as 'int'.
3316 * alloc.c: Handle unusual debugging option combinations.
3317 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3318 since the two debugging options are incompatible.
3319 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3321 (mem_init, mem_insert, mem_insert_fixup):
3322 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3323 (NEED_MEM_INSERT): Remove; no longer needed.
3325 2012-04-22 Leo Liu <sdl.web@gmail.com>
3327 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3329 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3331 * sysdep.c [__FreeBSD__]: Minor cleanups.
3332 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3333 Use Emacs indenting style more consistently. Avoid some casts.
3334 Use 'double' consistently rather than mixing 'float' and 'double'.
3336 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3338 * sysdep.c (list_system_processes, system_process_attributes):
3339 Add implementation for FreeBSD (Bug#5243).
3341 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3343 * lisp.mk (lisp): Update.
3345 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3347 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3348 It is never used otherwise.
3350 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3352 * print.c (print_preprocess): Only check print_depth if print-circle
3354 (print_object): Check for cycles even when print-circle is nil and
3355 print-gensym is t, but only check print_depth if print-circle is nil.
3357 2012-04-20 Chong Yidong <cyd@gnu.org>
3359 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3360 set the status to "failed" and ensure that sentinel is run.
3362 2012-04-20 Glenn Morris <rgm@gnu.org>
3364 * process.c (Fset_process_inherit_coding_system_flag)
3365 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3366 (Fmake_network_process, Fmake_serial_process): Doc fix.
3368 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3370 * xdisp.c (string_buffer_position_lim): Limit starting position to
3372 (set_cursor_from_row): If called for a mode-line or header-line
3373 row, return zero immediately.
3374 (try_cursor_movement): If inside continuation line, don't back up
3375 farther than the first row after the header line, if any.
3376 Don't consider the header-line row as "partially visible", even if
3377 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3379 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3381 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3384 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3385 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3387 configure: new option --enable-gcc-warnings (Bug#11207)
3388 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3389 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3390 (ALL_CFLAGS): Use new macros rather than old.
3391 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3392 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3393 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3394 -Wunused-result, -Wunused-variable. This should go away once
3395 the Emacs and Gnulib regex code is merged.
3396 (xmalloc, xrealloc): Now static.
3398 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3400 * dired.c (Fsystem_groups): Remove unused local.
3402 2012-04-17 Glenn Morris <rgm@gnu.org>
3404 * dired.c (Fsystem_users): Doc fix.
3406 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3408 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3409 (syms_of_dired): Add them.
3411 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3413 Fix minor alloc.c problems found by static checking.
3414 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3415 New extern decls, to avoid calling undeclared functions.
3416 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3417 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3418 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3419 (NEED_MEM_INSERT): New macro.
3420 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3421 Remove one incorrect comment and fix another.
3423 Fix minor ralloc.c problems found by static checking.
3424 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3425 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3426 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3427 (r_alloc_sbrk): Now static.
3429 Improve ralloc.c interface checking.
3430 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3431 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3432 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3433 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3434 [REL_ALLOC]: ... to here, to check interface.
3435 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3436 Remove decls. This fixes an "It stinks!".
3438 * alloc.c (which_symbols): Fix alignment issue / type clash.
3440 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3442 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3443 (struct Lisp_Misc_Any): Likewise.
3444 (struct Lisp_Free): Likewise.
3445 * alloc.c (union aligned_Lisp_Symbol): Define.
3446 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3447 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3448 (union aligned_Lisp_Misc): Define.
3449 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3450 aligned_Lisp_Misc instead of union Lisp_Misc.
3451 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3453 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3455 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3456 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3457 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3458 * s/netbsd.h, s/sol2-6.h:
3459 Remove definition of GC_MARK_STACK, since the default now works.
3460 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3461 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3462 no longer the default.
3463 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3465 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3467 * lread.c (lisp_file_lexically_bound_p):
3468 Fix hang at ";-*-\n" (bug#11238).
3470 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3472 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3473 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3475 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3477 * nsterm.m (constrainFrameRect): Always constrain when there is only
3478 one screen (Bug#10962).
3480 2012-04-13 Ken Brown <kbrown@cornell.edu>
3482 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3484 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3486 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3488 2012-04-11 Daniel Colascione <dancol@dancol.org>
3490 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3491 against is gone. It's better to use vfork now so that when Cygwin
3492 gains a new, working vfork, we use it automatically (bug#10398).
3494 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3496 * window.c (save_window_save): Obey window-point-insertion-type.
3498 2012-04-11 Glenn Morris <rgm@gnu.org>
3500 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3502 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3504 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3506 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3508 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3509 (force_quit_count): New var.
3510 (handle_interrupt): Use it.
3512 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3514 * w32.c (w32_delayed_load): Record the full path of the library
3515 being loaded (bug#10424).
3517 2012-04-09 Glenn Morris <rgm@gnu.org>
3519 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3520 not just in the obarray, before snarfing them. (Bug#11036)
3522 * Makefile.in ($(leimdir)/leim-list.el):
3523 Pass EMACS rather than BUILT_EMACS.
3525 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3527 * process.c (make_process):
3528 * process.h: Add integer `gnutls_handshakes_tried' member to
3531 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3532 Add convenience `GNUTLS_LOG2i' macro.
3534 * gnutls.c (gnutls_log_function2i): Convenience log function.
3535 (emacs_gnutls_read): Use new log functions,
3536 `gnutls_handshakes_tried' process member, and
3537 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3538 attempts per process (connection).
3540 2012-04-09 Chong Yidong <cyd@gnu.org>
3542 * eval.c (Fuser_variable_p, user_variable_p_eh)
3543 (lisp_indirect_variable): Functions deleted.
3544 (Fdefvar): Caller changed.
3546 * callint.c (Finteractive, Fcall_interactively):
3547 * minibuf.c (Fread_variable): Callers changed.
3549 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3551 * xdisp.c (set_cursor_from_row): If the display string appears in
3552 the buffer at position that is closer to point than the position
3553 after the display string, display the cursor on the first glyph of
3554 the display string. Fixes cursor display when a 'display' text
3555 property immediately follows invisible text. (Bug#11094)
3557 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3559 composite.c: use 'double' consistently
3560 * composite.c (get_composition_id): Use 'double' consistently
3561 instead of converting 'float' to 'double' and vice versa; this is
3562 easier to understand and avoids a GCC warning.
3564 2012-04-09 Glenn Morris <rgm@gnu.org>
3566 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3567 preparation for dumping it with emacs. (Bug#4789)
3568 (leimdir): New variable.
3569 ($(leimdir)/leim-list.el): New rule.
3570 (emacs$(EXEEXT)): Depend on leim-list.el.
3572 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3573 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3574 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3576 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3578 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3581 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3583 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3584 Remove unused local variable.
3586 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3588 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3589 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3590 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3591 objects, as mark_maybe_pointer will catch them otherwise.
3592 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3593 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3595 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3597 Fix typo that broke non-Windows builds.
3598 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3600 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3602 Support building on MS-Windows with libxml2.
3604 * makefile.w32-in (OBJ2): Add xml.$(O).
3605 (GLOBAL_SOURCES): Add xml.c.
3606 ($(BLD)/xml.$(O)): New dependency list.
3608 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3609 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3610 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3611 [!WINDOWSNT]: New macros.
3612 (init_libxml2_functions, libxml2_loaded_p): New functions.
3613 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3614 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3615 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3616 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3618 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3619 Call init_libxml2_functions before calling libxml2 functions.
3620 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3622 * emacs.c: Don't include libxml/parser.h.
3623 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3624 xmlCleanupParser directly.
3626 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3628 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3630 * indent.c (Fvertical_motion): If there is a display string at
3631 point, use it.vpos to compute how many lines to backtrack after
3632 move_it_to point. (Bug#11133)
3634 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3636 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3637 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3638 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3639 macros related to unification of CJK characters. For the details,
3640 see the discussion following the message here:
3641 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3643 2012-04-04 Chong Yidong <cyd@gnu.org>
3645 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3647 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3649 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3650 instead of alloca. (Bug#11138)
3652 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3654 * w32menu.c (is_simple_dialog): Properly check lisp types.
3657 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3659 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3660 position we get to after a call to move_it_to fails the
3661 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3662 only if we wind up in a string from display property. (Bug#11063)
3664 * window.c (Fdelete_other_windows_internal): Invalidate the row
3665 and column information about mouse highlight, so that redisplay
3666 restores it after reallocating the glyph matrices. (Bug#7464)
3668 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3669 string comes from a `display' text property, use the buffer
3670 position of that property as if we actually saw that position in
3672 (move_it_by_lines): Remove the assertion that
3673 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3674 violated when there's a before-string at the beginning of a line.
3677 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (append_space_for_newline): If the default face was
3680 remapped, use the remapped face for the appended newline.
3681 (extend_face_to_end_of_line): Use the remapped default face for
3682 extending the face to the end of the line.
3683 (display_line): Call extend_face_to_end_of_line when the default
3684 face was remapped. (Bug#11068)
3686 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3688 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3690 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3692 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3694 2012-03-27 Glenn Morris <rgm@gnu.org>
3696 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3699 2012-03-26 Kenichi Handa <handa@m17n.org>
3701 * dispextern.h (struct glyph): Fix previous change. Change the
3702 bit length of glyphless.ch to 25 (Bug#11082).
3704 2012-03-26 Chong Yidong <cyd@gnu.org>
3706 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3707 (command_loop_1): Use it; inhibit selection update for
3708 handle-select-window too (Bug#8996).
3710 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3712 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3714 2012-03-25 Kenichi Handa <handa@m17n.org>
3716 * dispextern.h (struct glyph): Change the bit length of
3717 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3719 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3721 * s/ms-w32.h (tzname): Include time.h before redirecting to
3722 _tzname. Fixes the MSVC build. (Bug#9960)
3724 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3726 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3729 * xterm.c (XTread_socket): Only modify handling_signal if
3730 !SYNC_INPUT. (Bug#11080)
3732 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3734 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3735 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3736 when fetching a multibyte character consumes more bytes than
3737 CHAR_BYTES returns, due to unification of CJK characters in
3738 string_char. (Bug#11073)
3740 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3742 * process.c (wait_reading_process_output): Handle pty disconnect
3743 by refraining from sending oneself a SIGCHLD (bug#10933).
3745 2012-03-22 Chong Yidong <cyd@gnu.org>
3747 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3749 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3750 Mark string as coming from a prefix property.
3751 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3752 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3754 2012-03-21 Chong Yidong <cyd@gnu.org>
3756 * xfaces.c (Vface_remapping_alist): Doc fix.
3758 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3760 * w32proc.c (Fw32_set_console_codepage)
3761 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3764 2012-03-20 Chong Yidong <cyd@gnu.org>
3766 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3767 to reflect default non-nil value of redisplay-dont-pause.
3769 2012-03-19 Kenichi Handa <handa@m17n.org>
3771 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3772 it fit in a valid range (Bug#11003).
3774 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3776 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3777 that is not from display property, accept the row as a "cursor
3778 row" if one of the string's character has a non-nil `cursor'
3779 property. Fixes cursor positioning when there are newlines in
3780 overlay strings, e.g. in icomplete.el. (Bug#11035)
3782 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3784 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3786 2012-03-12 Chong Yidong <cyd@gnu.org>
3788 * eval.c (inhibit_lisp_code): Rename from
3789 inhibit_window_configuration_change_hook; move from window.c.
3791 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3792 * window.c (run_window_configuration_change_hook)
3793 (syms_of_window): Callers changed.
3795 2012-03-11 Chong Yidong <cyd@gnu.org>
3797 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3799 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3801 2012-03-10 Chong Yidong <cyd@gnu.org>
3803 * frame.c (other_visible_frames): Don't assume the selected frame
3804 is visible (Bug#10955).
3806 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3808 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3810 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3812 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3813 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3816 2012-03-03 Glenn Morris <rgm@gnu.org>
3818 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3820 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3822 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3823 position past the first glyph_row that ends at ZV. (Bug#10902)
3824 (redisplay_window, next_element_from_string): Fix typos in
3826 (redisplay_window): Pass to move_it_vertically the margin in
3827 pixels, not in screen lines.
3829 2012-03-02 Glenn Morris <rgm@gnu.org>
3831 * buffer.c (buffer-list-update-hook): Doc fix.
3833 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3835 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3836 push_it before setting up the iterator for the first overlay
3837 string, even if we have an empty string loaded.
3838 (next_overlay_string): If there's an empty string on the iterator
3839 stack, pop the stack. (Bug#10903)
3841 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3843 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3844 Suggested by Stefan Monnier in
3845 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3846 * alloc.c (widen_to_Lisp_Object): New static function.
3847 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3848 and widening them to Lisp_Objects. This would work even if
3849 USE_LSB_TAG is defined and wide integers are used, which might
3850 happen in a future version of Emacs.
3852 2012-02-25 Chong Yidong <cyd@gnu.org>
3854 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3857 * xselect.c (Fx_selection_exists_p): Doc fix.
3858 (x_clipboard_manager_save_all): Print an informative message
3859 before saving to clipboard manager.
3861 2012-02-24 Chong Yidong <cyd@gnu.org>
3863 * keyboard.c (process_special_events): Handle all X selection
3864 requests in kbd_buffer, not just the next one (Bug#8869).
3866 2012-02-23 Chong Yidong <cyd@gnu.org>
3868 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3869 call when setting menu-bar-lines and tool-bar-lines parameters.
3870 (unwind_create_frame_1): New helper function.
3872 * window.c (inhibit_window_configuration_change_hook): New var.
3873 (run_window_configuration_change_hook): Obey it.
3874 (syms_of_window): Initialize it.
3876 2012-02-22 Chong Yidong <cyd@gnu.org>
3878 * xterm.c (x_draw_image_relief): Add missing type check for
3879 Vtool_bar_button_margin (Bug#10743).
3881 2012-02-21 Chong Yidong <cyd@gnu.org>
3883 * fileio.c (Vfile_name_handler_alist): Doc fix.
3885 * buffer.c (Fget_file_buffer): Protect against invalid file
3886 handler return value.
3888 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3890 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3891 when computing $valmask.
3893 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3894 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3895 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3896 It's useless in that case, and it can cause problems on hosts
3897 that allocate halves of EMACS_INT values separately.
3898 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3899 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3900 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3901 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3902 it avoids undefined behavior on hosts where shifting right by more
3903 than the word width has undefined behavior.
3905 2012-02-19 Chong Yidong <cyd@gnu.org>
3907 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3908 (Funhandled_file_name_directory, Ffile_name_as_directory)
3909 (Fdirectory_file_name, Fexpand_file_name)
3910 (Fsubstitute_in_file_name): Protect against invalid file handler
3911 return values (Bug#10845).
3913 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3915 * .gdbinit (pitx): Fix incorrect references to fields of the
3918 2012-02-17 Chong Yidong <cyd@gnu.org>
3920 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3922 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3924 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3925 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3927 2012-02-15 Chong Yidong <cyd@gnu.org>
3929 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3930 marked as special. Also, starting docstrings with * is obsolete.
3932 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3934 * gnutls.c (emacs_gnutls_write): Fix last change.
3936 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3938 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3941 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3943 * keymap.c (Fsingle_key_description): Handle char ranges.
3945 2012-02-12 Chong Yidong <cyd@gnu.org>
3947 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3948 as that creates a dangerous corner case.
3950 * window.c (Fdelete_window_internal): Invalidate the mouse
3951 highlight (Bug#9904).
3953 2012-02-12 Glenn Morris <rgm@gnu.org>
3955 * xselect.c (Fx_own_selection_internal)
3956 (Fx_get_selection_internal, Fx_disown_selection_internal)
3957 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3958 * nsselect.m (Fx_own_selection_internal)
3959 (Fx_disown_selection_internal, Fx_selection_exists_p)
3960 (Fx_selection_owner_p, Fx_get_selection_internal):
3961 Sync docs and argument specs with the xselect.c versions.
3963 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3965 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3967 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3969 * w32select.c (Fx_selection_exists_p): Sync doc string and
3970 argument list with xselect.c. (Bug#10783)
3972 * w16select.c (Fx_selection_exists_p): Sync doc string and
3973 argument list with xselect.c. (Bug#10783)
3975 2012-02-10 Glenn Morris <rgm@gnu.org>
3977 * fns.c (Fsecure_hash): Doc fix.
3979 2012-02-09 Kenichi Handa <handa@m17n.org>
3981 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3983 2012-02-07 Chong Yidong <cyd@gnu.org>
3985 * buffer.c (Fbuffer_local_variables)
3986 (buffer_lisp_local_variables): Handle unbound vars correctly;
3987 don't let Qunbound leak into Lisp.
3989 2012-02-07 Glenn Morris <rgm@gnu.org>
3991 * image.c (Fimagemagick_types): Doc fix.
3993 * image.c (imagemagick-render-type): Change it from a lisp object
3994 to an integer. Move the doc here from the lisp manual.
3995 Treat all values not equal to 0 the same.
3997 2012-02-06 Chong Yidong <cyd@gnu.org>
3999 * doc.c (store_function_docstring): Avoid applying docstring of
4000 alias to base function (Bug#2603).
4002 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4004 * .gdbinit (pp1, pv1): Remove redundant defines.
4007 2012-02-04 Chong Yidong <cyd@gnu.org>
4009 * nsterm.m: Declare a global (Bug#10694).
4011 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4013 * w32.c (get_emacs_configuration_options):
4014 Include --enable-checking, if specified, in the return value.
4016 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4018 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4019 after rounding frame sizes. (Bug#9723)
4021 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4023 * keyboard.c (adjust_point_for_property): Don't position point
4024 before BEGV. (Bug#10696)
4026 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4028 Handle overflow when computing char display width (Bug#9496).
4029 * character.c (char_width): Return EMACS_INT, not int.
4030 (char_width, c_string_width): Check for overflow when
4031 computing the width; this is possible now that individual
4032 characters can have unbounded width. Problem introduced
4033 by merge from Emacs 23 on 2012-01-19.
4035 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4037 * dbusbind.c (Fdbus_register_method): Mention the return value
4038 :ignore in the docstring.
4040 2012-02-02 Glenn Morris <rgm@gnu.org>
4042 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4044 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4045 Unconditionally set to t. (Bug#10673)
4046 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4047 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4048 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4050 2012-02-02 Kenichi Handa <handa@m17n.org>
4052 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4053 0, do not call append_composite_glyph.
4055 2012-02-02 Kenichi Handa <handa@m17n.org>
4057 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4059 (x_produce_glyphs): If the component of a composition is a null
4060 string, set it->pixel_width to 1 to avoid zero-width glyph.
4062 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4064 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4065 first 2 arguments are identical. This makes inserting large
4066 output from a subprocess an order of magnitude faster on
4067 MS-Windows, where all sbrk'ed memory is always contiguous.
4069 2012-01-31 Glenn Morris <rgm@gnu.org>
4071 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4072 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4073 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4075 2012-01-29 Glenn Morris <rgm@gnu.org>
4077 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4079 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4081 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4083 2012-01-28 Chong Yidong <cyd@gnu.org>
4085 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4087 2012-01-26 Chong Yidong <cyd@gnu.org>
4089 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4091 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4092 repeat counts (Bug#10507).
4094 2012-01-26 Glenn Morris <rgm@gnu.org>
4096 * lread.c (syms_of_lread): Doc fix.
4098 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4100 * coding.c (encode_designation_at_bol): Change return value to
4103 2012-01-25 Chong Yidong <cyd@gnu.org>
4105 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4107 2012-01-21 Chong Yidong <cyd@gnu.org>
4109 * floatfns.c (Fcopysign): Make the second argument non-optional,
4110 since nil is not allowed anyway.
4112 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4114 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4115 (send_process): Likewise.
4117 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4119 * window.c (save_window_save, Fcurrent_window_configuration)
4120 (Vwindow_persistent_parameters): Do not use Qstate.
4121 Rewrite doc-strings.
4123 2012-01-19 Kenichi Handa <handa@m17n.org>
4125 * character.c (char_width): New function.
4126 (Fchar_width, c_string_width, lisp_string_width):
4127 Use char_width (Bug#9496).
4129 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4131 * window.c (Vwindow_persistent_parameters): New variable.
4132 (Fset_window_configuration, save_window_save): Handle persistent
4135 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4137 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4138 thrashing the stack of the thread. (Bug#9087)
4140 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4142 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4144 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4146 * xdisp.c (rows_from_pos_range): Handle the case where the
4147 highlight ends on a newline. (Bug#10464)
4148 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4149 he end column for display of highlight that ends on a newline
4152 2012-01-11 Glenn Morris <rgm@gnu.org>
4154 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4155 from load-path also when installation-directory is nil. (Bug#10208)
4157 2012-01-10 Glenn Morris <rgm@gnu.org>
4159 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4161 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4162 Update template values to be closer to their typical values these days.
4164 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4166 * xdisp.c (rows_from_pos_range): Accept additional argument
4167 DISP_STRING, and accept any glyph in a row whose object is that
4168 string as eligible for mouse highlight. Fixes mouse highlight of
4169 display strings from overlays. (Bug#10464)
4171 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4173 emacs: fix an auto-save permissions race condition (Bug#10400)
4174 * fileio.c (auto_saving_dir_umask): New static var.
4175 (Fmake_directory_internal): Use it.
4176 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4177 creating the directory. The old code temporarily assigns
4178 too-generous permissions to the directory.
4179 (do_auto_save_eh): Clear it.
4180 (Fdo_auto_save): Catch all errors, not just file errors, so
4181 that the var is always cleared.
4183 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4185 * search.c (scan_buffer): Pass character positions to
4186 know_region_cache, not byte positions. (Bug#6540)
4188 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4190 * w32.c (sys_rename): Report EXDEV when rename of a directory
4191 fails because the target is on another logical disk. (Bug#10284)
4193 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4195 * xterm.c (x_embed_request_focus): New function.
4197 * xterm.h: Add prototype.
4199 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4201 2012-01-05 Glenn Morris <rgm@gnu.org>
4203 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4205 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4207 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4208 Load gnutls_transport_set_lowat only if GnuTLS version is below
4210 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4211 GnuTLS versions below 2.11.1.
4213 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4215 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4216 to the doc string advising against its use for altering the way
4217 windows are scrolled.
4219 2011-12-28 Kenichi Handa <handa@m17n.org>
4221 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4222 coding-system ASCII compatible only when it does not produce BOM
4223 on encoding (Bug#10383).
4225 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4227 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4229 (create_and_show_popup_menu): Always use menu_position_func for
4232 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4234 * callint.c (Fcall_interactively): Don't truncate prompt string.
4236 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4238 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4239 property that ends at ZV, so that the bidi iteration could be
4240 resumed from there (after widening). (Bug#10360)
4242 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4244 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4246 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4248 * nsterm.m (x_free_frame_resources):
4249 Release f->output_data.ns->miniimage.
4250 (ns_index_color): Fix indentation. Do not retain
4251 color_table->colors[i].
4253 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4256 * nsfns.m (x_set_background_color): Assign return value from
4257 ns_index_color to face-background instead of NSColor*.
4258 (ns_implicitly_set_icon_type): Fix indentation.
4259 Change assignment in for loop to comparison.
4261 * emacs.c (ns_pool): New variable.
4262 (main): Assign ns_pool.
4263 (Fkill_emacs): Call ns_release_autorelease_pool.
4265 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4266 autorelease fdesc, release fdAttrs and tdict.
4267 (ns_get_covering_families): Release charset.
4268 (ns_findfonts): Release NSFontDescriptor created with new.
4269 (ns_uni_to_glyphs): Fix indentation.
4270 (setString): Release attrStr before assigning new value.
4272 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4274 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4276 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4277 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4279 2011-12-18 David Reitter <reitter@cmu.edu>
4281 * nsterm.m (ns_term_init): Subscribe for notifications
4282 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4283 to method trackingNotification in EmacsMenu.
4285 * nsmenu.m (trackingMenu): New variable.
4286 (trackingNotification): New method (from Aquamacs).
4287 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4288 from Aquamacs (Bug#7030).
4290 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4292 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4293 (symbol_to_nsstring): Fix indentation.
4294 (ns_symbol_to_pb): New function.
4295 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4296 (Fns_rotate_cut_buffers_internal): Remove.
4297 (Fns_store_selection_internal): Rename from
4298 Fns_store_cut_buffer_internal.
4299 (ns_get_foreign_selection, Fx_own_selection_internal)
4300 (Fx_disown_selection_internal, Fx_selection_exists_p)
4301 (Fns_get_selection_internal, Fns_store_selection_internal):
4302 Use ns_symbol_to_pb and check if return value is nil.
4303 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4304 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4305 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4306 renamed to Sns_store_selection_internal.
4307 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4308 and remove this function.
4309 (ns_handle_selection_clear): Remove, never used.
4310 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4313 2011-12-17 Ken Brown <kbrown@cornell.edu>
4315 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4316 GID is unknown (Bug#10257).
4318 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4320 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4321 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4322 which caused a build failure on GNU/Linux IA-64. This problem was
4323 introduced by my 2011-10-07 patch.
4325 2011-12-15 Juri Linkov <juri@jurta.org>
4327 * image.c (imagemagick_error): New function. (Bug#10112)
4328 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4329 Use `imagemagick_error' where ImageMagick functions return
4331 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4334 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4336 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4337 fill background (Bug#8992).
4339 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4341 * window.c (Vwindow_combination_resize)
4342 (Vwindow_combination_limit): Use t instead of non-nil in
4344 (Vrecenter_redisplay): Add first sentence of doc-string on
4346 (Frecenter): Fix doc-string typo.
4348 2011-12-11 Kenichi Handa <handa@m17n.org>
4350 * coding.c (Funencodable_char_position): Pay attention to the
4351 buffer text relocation (Bug#9389).
4353 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4355 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4356 gtk_init (Bug#10100).
4358 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4360 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4361 IT->string is nil. (Bug#10263)
4363 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4365 * nsterm.h (x_free_frame_resources): Declare.
4367 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4368 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4370 * nsterm.h (ns_get_defaults_value): Declare.
4372 * nsterm.m (ns_default): Call ns_get_defaults_value.
4374 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4376 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4379 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4381 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4382 that where the value of an _OBJC_* symbol points to is in the .bss
4383 section (Bug#10240).
4385 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4387 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4388 after the loop to call ccl_driver at least once (Bug#8619).
4390 2011-12-08 Kenichi Handa <handa@m17n.org>
4392 * ftfont.c (get_adstyle_property): Fix previous change
4395 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4397 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4398 dirs from the default value of EMACSLOADPATH (bug#10208).
4400 2011-12-07 Glenn Morris <rgm@gnu.org>
4402 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4403 installation and source directories as well. (Bug#10208)
4405 2011-12-06 Chong Yidong <cyd@gnu.org>
4407 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4409 2011-12-06 Glenn Morris <rgm@gnu.org>
4411 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4412 as an error, not just -1. (Bug#10217)
4414 2011-12-05 Chong Yidong <cyd@gnu.org>
4416 * keyboard.c (process_special_events): New function.
4417 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4419 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4421 * coding.c (encode_designation_at_bol): Don't use uninitialized
4422 local variable (Bug#9318).
4424 2011-12-05 Kenichi Handa <handa@m17n.org>
4426 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4427 return Qnil (Bug#8046, Bug#10193).
4429 2011-12-05 Kenichi Handa <handa@m17n.org>
4431 * coding.c (encode_designation_at_bol): New args charbuf_end and
4432 dst. Return the number of produced bytes. Callers changed.
4433 (coding_set_source): Return how many bytes coding->source was
4435 (coding_set_destination): Return how many bytes
4436 coding->destination was relocated.
4437 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4438 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4440 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4442 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4443 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4446 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4448 The following changes are to fix Bug#9318.
4450 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4451 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4452 (encode_coding_iso_2022, encode_coding_sjis)
4453 (encode_coding_big5, encode_coding_charset): Use the above macros.
4455 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4457 * lisp.h (process_quit_flag): Fix external declaration.
4459 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4461 Don't macro-inline non-performance-critical code.
4462 * eval.c (process_quit_flag): New function.
4463 * lisp.h (QUIT): Use it.
4465 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4467 * nsfns.m (get_geometry_from_preferences): New function.
4468 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4470 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4472 * emacs.c (Qkill_emacs): Define.
4473 (syms_of_emacs): Initialize it.
4474 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4475 Qquit_flag to `kill-emacs' instead.
4476 (quit_throw_to_read_char): Add parameter `from_signal'.
4477 All callers changed. Call Fkill_emacs if requested and safe.
4478 * lisp.h (QUIT): Call Fkill_emacs if requested.
4480 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4482 * widget.c (update_wm_hints): Return if wmshell is null.
4483 (widget_update_wm_size_hints): New function.
4485 * widget.h (widget_update_wm_size_hints): Declare.
4487 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4488 widget_update_wm_size_hints (Bug#10104).
4490 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4492 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4493 before a newline, prepare the bidi iterator for consuming the
4494 newline, and keep the current paragraph direction. (Bug#10183)
4495 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4497 2011-12-02 Juri Linkov <juri@jurta.org>
4499 * search.c (Fword_search_regexp): New Lisp function created from
4500 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4501 (Fword_search_backward, Fword_search_forward)
4502 (Fword_search_backward_lax, Fword_search_forward_lax):
4503 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4504 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4506 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4508 * fileio.c (Finsert_file_contents): Move after-change-function call
4509 to before the "handled:" label, since all "goto handled" appear in
4510 cases where the *-change-functions have already been properly called
4513 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4515 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4516 waiting for input. (Bug#10169)
4518 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4520 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4521 verifies glyph row's hash code--we have just reallocated the
4522 glyphs, so their contents can be complete garbage. (Bug#10164)
4524 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4526 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4528 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4530 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4531 attributes are tested _before_ calling verify_row_hash, to protect
4532 against GCC re-ordering of the tests. (Bug#10164)
4534 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4536 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4538 * xterm.c (handle_one_xevent): Only set async_visible and friends
4539 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4540 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4541 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4543 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4545 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4546 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4547 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4548 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4549 All uses changed to use GCPRO1 etc.
4550 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4551 Revert to old implementation (i.e., before 2011-03-11).
4553 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4555 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4556 of scroll runs so as to avoid assigning disabled bogus rows and
4557 unnecessary graphics copy operations.
4559 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4561 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4562 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4563 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4564 (malloc, free, realloc, calloc): Redirect to e_* only when
4567 * lisp.h (GCTYPEBITS): Move before first use.
4568 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4569 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4570 this macro definition.
4572 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4575 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4577 * gtkutil.c (xg_create_frame_widgets):
4578 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4579 present with Gtk+ 2.0.
4581 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4583 * fileio.c (Finsert_file_contents): Undo previous change; see
4584 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4586 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4588 Rename locals to avoid shadowing.
4589 * fileio.c (Finsert_file_contents):
4590 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4591 * process.c (wait_reading_process_output):
4592 Rename inner 'proc' to 'p' to avoid shadowing.
4593 Indent for consistency with usual Emacs style.
4595 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4597 * xdisp.c (redisplay_window): If cursor row is not fully visible
4598 after recentering, and scroll-conservatively is set to a large
4599 number, scroll window by a few more lines to make the cursor fully
4600 visible and out of scroll-margin. (Bug#10105)
4601 (start_display): Don't move to the next line if the display should
4602 start at a newline that is part of a display vector or an overlay
4605 2011-11-24 Juri Linkov <juri@jurta.org>
4607 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4608 after the `MagickPingImage' call. (Bug#10112)
4610 2011-11-23 Chong Yidong <cyd@gnu.org>
4612 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4614 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4616 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4617 making another buffer current. (Bug#10114)
4619 2011-11-23 Glenn Morris <rgm@gnu.org>
4621 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4623 2011-11-23 Chong Yidong <cyd@gnu.org>
4625 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4626 using it (Bug#5984).
4628 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4630 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4631 and header-lines, as they don't have one computed for them.
4634 * .gdbinit (prow): Make displayed values more self-explaining.
4635 Add row's hash code.
4637 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4639 * process.c (wait_reading_process_output): Fix asynchrounous
4640 GnuTLS socket handling on some versions of the GnuTLS library.
4641 (wait_reading_process_output): Add comment and URL.
4643 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4645 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4647 2011-11-21 Chong Yidong <cyd@gnu.org>
4649 * window.c (Fnext_window, Fprevious_window): Doc fix.
4651 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4653 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4655 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4657 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4659 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4661 * window.c (Fset_window_combination_limit): Rename argument
4663 (Vwindow_combination_limit): Remove "status" from doc-string.
4665 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4667 * m/ibms390.h: Remove.
4668 * m/ibms390x.h: Don't include "ibms390.h".
4670 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4672 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4673 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4675 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4677 * casetab.c (Fset_case_table):
4678 * charset.c (Fcharset_after): Fix typos.
4680 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4682 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4683 Otherwise, valgrind does not work on some platforms.
4684 Problem reported by Andreas Schwab in
4685 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4686 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4687 is set, removing the need for VIRT_ADDRESS_VARIES.
4688 (PURE_P): Use a more-efficient implementation that needs just one
4689 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4690 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4691 to 4 (xorl, subq, cmpq, setbe).
4692 * alloc.c (pure): Always extern now, since that's the
4693 VIRT_ADDR_VARIES behavior.
4694 (PURE_POINTER_P): Use a single comparison, not two, for
4695 consistency with the new puresize.h.
4696 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4697 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4698 Remove VIRT_ADDR_VARIES no longer needed.
4700 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4702 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4703 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4704 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4705 behave as if the cursor position were at the window margin.
4707 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4708 and the cursor position is out of bounds, behave as if the cursor
4709 position were at the window margin. (Bug#10075)
4711 2011-11-18 Chong Yidong <cyd@gnu.org>
4713 * window.c (Fwindow_combination_limit): Make first argument
4714 non-optional, since it is meaningless for live windows like the
4717 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4719 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4721 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4723 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4724 (graft_intervals_into_buffer): Simplify.
4726 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4728 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4729 hash values of the two rows.
4730 (copy_row_except_pointers): Preserve the used[] arrays and the
4731 hash values of the two rows. (Bug#10035)
4732 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4734 * xdisp.c (row_hash): New function, body extracted from
4735 compute_line_metrics.
4736 (compute_line_metrics): Call row_hash, instead of computing the
4739 * dispnew.c (verify_row_hash): Call row_hash for computing the
4740 hash code of a row, instead of duplicating code from xdisp.c.
4742 * dispextern.h (row_hash): Add prototype.
4744 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4746 * frame.c (delete_frame): Don't delete the terminal when the last
4747 X frame is closed if emacs is built with GTK toolkit.
4749 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4751 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4753 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4755 * window.c (Vwindow_splits): Rename to
4756 Vwindow_combination_resize. Suggested by Juri Linkov.
4757 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4760 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4762 * nsfns.m (Fns_font_name):
4763 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4765 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4767 * window.h (window): Rename slot "nest" to "combination_limit".
4768 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4769 (Fset_window_nest): Rename to Fset_window_combination_limit.
4770 (Vwindow_nest): Rename to Vwindow_combination_limit.
4771 (recombine_windows, make_parent_window, make_window)
4772 (Fsplit_window_internal, saved_window)
4773 (Fset_window_configuration, save_window_save): Rename all
4774 occurrences of window_nest to window_combination_limit.
4776 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4778 * image.c (imagemagick_load_image): Fix typo.
4780 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4782 * xdisp.c (display_line): Move the call to
4783 highlight_trailing_whitespace before the call to
4784 compute_line_metrics, since the latter needs to see the final
4785 faces of all the glyphs to compute ROW's hash value.
4786 Fixes assertion violations in row_equal_p. (Bug#10035)
4788 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4790 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4791 just return (bug#10044).
4793 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4795 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4796 with user-defined heap size. Bump the default size of the temacs
4797 heap to 27MB, to avoid memory warning when running temacs.
4798 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4800 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4801 current_matrix and desired_matrix. (Bug#9990)
4802 (verify_row_hash) [XASSERTS]: New function.
4803 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4804 that the hash value of glyph rows is correct.
4806 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4808 * window.h (window): Remove splits slot.
4809 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4810 (Fdelete_other_windows_internal, make_parent_window)
4811 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4812 (Fset_window_configuration, save_window_save): Don't deal with
4813 split status of windows.
4814 (saved_window): Remove splits slot.
4815 (Vwindow_splits): Rewrite doc-string.
4817 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4819 * xfns.c (unwind_create_frame):
4820 * nsfns.m (unwind_create_frame):
4821 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4822 Vframe_list (Bug#9999).
4824 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4826 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4828 2011-11-11 Kenichi Handa <handa@m17n.org>
4830 * callproc.c (Fcall_process): Set the member dst_multibyte of
4833 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4835 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4836 avoid a crash (bug#9496).
4838 2011-11-09 Chong Yidong <cyd@gnu.org>
4840 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4841 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4843 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4845 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4847 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4849 Avoid some portability problems by eschewing 'extern inline' functions.
4850 The trivial performance wins aren't worth the portability hassles; see
4851 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4853 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4854 (window_box_width, window_box_left, window_box_left_offset)
4855 (window_box_right, window_box_right_offset): Undo previous change,
4856 by removing the "extern"s.
4857 * intervals.c (adjust_intervals_for_insertion)
4858 (adjust_intervals_for_deletion): Undo previous change,
4859 making these static again.
4860 (offset_intervals, temp_set_point_both, temp_set_point)
4861 (copy_intervals_to_string): No longer inline.
4862 * xdisp.c (window_text_bottom_y, window_box_width)
4863 (window_box_height, window_box_left_offset)
4864 (window_box_right_offset, window_box_left, window_box_right)
4865 (window_box): No longer inline.
4867 2011-11-08 Chong Yidong <cyd@gnu.org>
4869 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4870 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4871 Signal an error if not a live window.
4872 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4873 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4875 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4877 * lisp.h (syms_of_abbrev): Remove declaration.
4878 Reported by CHENG Gao <chenggao@royau.me>.
4880 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4882 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4883 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4884 of temacs in GUI mode.
4886 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4888 * window.h: Declare delete_all_child_windows instead of
4889 delete_all_subwindows.
4890 * window.c (Fwindow_nest, Fset_window_nest)
4891 (Fset_window_new_total, Fset_window_new_normal)
4892 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4893 (delete_all_subwindows): Rename to delete_all_child_windows.
4894 (Fdelete_other_windows_internal, Fset_window_configuration):
4895 Call delete_all_child_windows instead of delete_all_subwindows.
4896 * frame.c (delete_frame): Call delete_all_child_windows instead
4897 of delete_all_subwindows.
4899 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4901 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4902 This is also needed for porting to any host where GC_MARK_STACK is
4903 not GC_MAKE_GCPROS_NOOPS.
4904 (which_symbols): Use it.
4906 2011-11-07 Kenichi Handa <handa@m17n.org>
4908 * coding.c (coding_set_destination): Check coding->src_pos only
4909 when coding->src_object is a buffer (bug#9910).
4911 * process.c (send_process): Set the member src_multibyte of coding
4912 to 0 (bug#9911) when sending a unibyte text.
4914 * callproc.c (Fcall_process): Set the member src_multibyte of
4915 process_coding to 0 (bug#9912).
4917 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4919 * xmenu.c (cleanup_widget_value_tree): New function.
4920 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4921 calling free_menubar_widget_value_tree directly (Bug#9830).
4923 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4925 Fix some portability problems with 'inline'.
4926 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4927 (window_box_width, window_box_left, window_box_left_offset)
4928 (window_box_right, window_box_right_offset): Declare extern.
4929 Otherwise, these inline functions do not conform to C99 and
4930 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4931 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4932 * intervals.c (adjust_intervals_for_insertion)
4933 (adjust_intervals_for_deletion): Now extern, because otherwise the
4934 extern inline functions 'offset_intervals' couldn't refer to it.
4935 (static_offset_intervals): Remove.
4936 (offset_intervals): Rewrite using the old contents of
4937 static_offset_intervals. The old version didn't conform to C99
4938 because an extern inline function contained a reference to an
4939 identifier with static linkage.
4941 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4943 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4946 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4949 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4950 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4951 return Qleft_to_right.
4953 2011-11-06 Chong Yidong <cyd@gnu.org>
4955 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4956 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4957 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4958 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4959 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4960 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4961 (Fwindow_vscroll): Doc fix.
4962 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4963 argument, since it makes no sense to pass a live window and for
4964 consistency with window-child.
4966 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4968 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4971 2011-11-05 Jason Rumney <jasonr@gnu.org>
4973 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4974 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4976 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4977 bitwise arithmetic preventing use of unicode-sip and non-truetype
4980 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4982 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4985 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4986 initialization code to keep similarity to xfns.c after changes
4989 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4991 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4992 (unwind_create_frame): New function (Bug#9943).
4993 (Fx_create_frame): Restructure code to be more similar to the one in
4994 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4995 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4996 Move terminal->reference_count++ just before making the frame official
4999 * nsterm.m (x_free_frame_resources): New function.
5000 (x_destroy_window): Move code to x_free_frame_resources.
5002 * xfns.c (unwind_create_frame): Fix comment.
5003 (Fx_create_frame, x_create_tip_frame):
5004 Move terminal->reference_count++ just before making the frame
5005 official. Move initialization of image_cache_refcount and
5006 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5008 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5010 Support MSVC build with newer versions of Visual Studio.
5011 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5012 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5015 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5016 which are not supported by MSVC.
5017 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5018 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5020 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5022 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5024 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5026 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5028 Support MSVC build with newer versions of Visual Studio.
5029 * w32.c: Don't include w32api.h for MSVC.
5030 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5032 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5033 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5034 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5035 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5037 (alloca) [_MSC_VER]: Define to _alloca.
5039 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5041 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5043 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5045 * xdisp.c (note_mouse_highlight): If either of
5046 previous/next-single-property-change returns nil, treat that as
5047 the beginning or the end of the buffer. (Bug#9955)
5049 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5051 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5052 label is not null (Bug#9951).
5053 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5056 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5058 * window.c (Fwindow_body_size): Mention in the doc string that the
5059 return value is in frame's canonical units. (Bug#9949)
5061 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5063 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5065 * w32fns.c (unwind_create_frame): If needed, free the glyph
5066 matrices of the partially constructed frame. (Bug#9943)
5067 * xfns.c (unwind_create_frame): Likewise.
5069 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5071 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5072 Don't stop backward scan on the continuation glyph, even though
5073 its CHARPOS is positive.
5074 (mouse_face_from_buffer_pos, note_mouse_highlight):
5075 Rename cover_string to disp_string.
5077 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5079 * window.c (temp_output_buffer_show): Don't use
5080 Vtemp_buffer_show_specifiers.
5081 (Vtemp_buffer_show_specifiers): Remove unused variable.
5083 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5085 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5086 past the beginning of the current glyph matrix.
5088 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5090 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5091 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5092 HAVE_GTK3 (Bug#9869).
5094 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5095 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5097 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5099 * xterm.c: Declare x_handle_net_wm_state to return int.
5100 (handle_one_xevent): Check if we are iconified but don't have
5101 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5102 (get_current_wm_state): Return non-zero if not hidden,
5103 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5104 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5105 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5106 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5108 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5110 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5111 so that this new function doesn't get optimized away by a
5112 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5114 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5116 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5118 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5120 Fix the `xbytecode' command.
5121 * .gdbinit (xprintbytestr): New command.
5122 (xwhichsymbols): Rename from `which'; all callers changed.
5123 (xbytecode): Print the byte-code string as well.
5125 2011-10-29 Kim Storm <storm@cua.dk>
5127 * alloc.c (which_symbols): New function.
5129 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5131 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5134 2011-10-29 Glenn Morris <rgm@gnu.org>
5136 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5137 Not clear what it was for, and it causes various bugs. (Bug#9839)
5139 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5141 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5142 possible random value that matches one of those tested as
5143 condition to clear the mouse face.
5145 2011-10-28 Chong Yidong <cyd@gnu.org>
5147 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5149 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5151 * window.c (make_window): Initialize phys_cursor_on_p.
5153 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5155 * lisp.h (struct Lisp_Symbol): Update comments.
5157 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5159 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5161 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5163 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5164 <oslsachem@gmail.com> for helping to debug this.
5166 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5167 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5168 (g_b_init_get_glyph_outline_w): New static variables.
5169 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5170 (GetGlyphOutlineW_Proc): New typedefs.
5171 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5172 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5174 (w32font_open_internal, compute_metrics):
5175 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5176 instead of calling the "wide" APIs directly.
5178 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5180 * w32.h (syms_of_w32font): Add prototype.
5182 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5184 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5185 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5186 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5187 (Fmove_to_window_line): Doc fix.
5189 2011-10-27 Chong Yidong <cyd@gnu.org>
5191 * process.c (make_process): Set gnutls_state to NULL.
5193 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5194 non-NULL, regardless of GNUTLS_INITSTAGE.
5195 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5196 an error. Set process slots as soon as we allocate them.
5198 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5200 2011-10-27 Chong Yidong <cyd@gnu.org>
5202 * gnutls.c (emacs_gnutls_deinit): New function.
5203 Deallocate credentials structures as well as calling gnutls_deinit.
5204 (Fgnutls_deinit, Fgnutls_boot): Use it.
5206 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5207 (deactivate_process): Call emacs_gnutls_deinit.
5209 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5211 * image.c (x_create_x_image_and_pixmap):
5212 * w32.c (sys_rename, w32_delayed_load):
5213 * w32font.c (fill_in_logfont):
5214 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5216 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5218 * w32fns.c (w32_default_color_map): New function,
5219 extracted from Fw32_default_color_map.
5220 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5222 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5224 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5226 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5228 * keyboard.c (test_undefined): New function (bug#9751).
5229 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5231 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5233 * sysdep.c (init_sys_modes): Fix the check for the controlling
5234 terminal (Bug#6649).
5236 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5238 * dispextern.h (struct bidi_it): New member next_en_type.
5240 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5241 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5242 current character, check also for next_en_type being WEAK_EN.
5243 (bidi_resolve_weak): Don't enter the expensive loop if the current
5244 position is before next_en_pos. Record the bidi type of the first
5245 non-ET, non-BN character we find, in addition to its position.
5246 (bidi_level_of_next_char): Invalidate next_en_type when
5247 next_en_pos is over-stepped.
5249 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5251 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5252 * editfns.c: Rewrite current-time-zone so that it invokes
5253 the equivalent of (format-time-string "%Z") to get the time zone name.
5254 This fixes a bug when the time zone name contains characters that
5255 need converting from the system time locale to Emacs internal format.
5256 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5257 that patch fixed format-time-string to do the conversion, but
5258 I forgot to fix current-time-zone.
5259 (format_time_string): New function, containing most of
5260 what Fformat_time_string used to contain.
5261 (Fformat_time_string): Rewrite in terms of format_time_string.
5262 This doesn't change this function's behavior.
5263 (current-time-zone): Rewrite to use format_time_string.
5264 This fixes the bug reported by Michael Schierl in
5265 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5266 Jason Rumney's 2007-06-07 change worked around this bug, but
5268 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5270 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5272 * xdisp.c (start_display): If the character at POS is displayed
5273 via a display vector, reset IT->current.dpvec_index to zero.
5274 (try_window_reusing_current_matrix): If a line ends in a display
5275 vector or the next line starts in a display vector, continue
5276 redrawing the window even though the character position of
5277 start_row was reached.
5280 2011-10-18 Chong Yidong <cyd@gnu.org>
5282 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5283 with nobreak-char-display too.
5285 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5287 Fix part 3 of bug#9771.
5288 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5289 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5290 non-neutral characters if the current character is a paragraph
5291 separator (a.k.a. Newline). This avoids running the same
5292 expensive loop twice, once when we consume the preceding newline
5293 and the other time when the line actually needs to be displayed.
5294 Avoid the loop when we see neutrals on the base embedding level
5295 following a character whose directionality is the same as the
5296 paragraph's. This avoids running the expensive loop when a line
5297 ends in a long sequence of neutrals, like control characters.
5298 Add assertion against STRONG_AL type. Slightly rearrange code
5299 that determines the type of a neutral given the first non-neutral
5301 (bidi_level_of_next_char): Set next_en_pos to zero when
5302 invalidating its info.
5304 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5306 * xdisp.c (push_display_prop): Determine whether to record string
5307 or buffer position by IT->string, not by IT->method. Allow
5308 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5309 (move_it_vertically_backward): Don't look for character position
5310 immediately after the newline when in a continuation line.
5313 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5315 * window.c (coordinates_in_window): Rewrite and delabelize
5316 vertical border check. (Bug#5357) (Bug#9618)
5318 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5320 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5321 errors in XSetWindowBorder (bug#9310).
5323 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5325 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5326 avoid crash when xmalloc overrun checking is enabled.
5328 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5330 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5331 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5332 cursor motion with <left> and <right> arrow keys.
5334 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5335 some callers set that themselves.
5337 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5339 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5340 display string and the previous row comes from the same string and
5341 is empty. (Bug#9739) (Bug#9738)
5343 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5345 * doc.c (get_doc_string): Encode file name (bug#9735).
5347 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5349 * bidi.c (bidi_level_of_next_char):
5350 * xdisp.c (get_visually_first_element): Remove old incorrect
5351 comments regarding the Unicode Line Separator character.
5353 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5355 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5357 * alloc.c (Fgc_status): Do not access beyond zombies array
5358 boundary if nzombies > MAX_ZOMBIES.
5359 * alloc.c (dump_zombies): Add missing format specifier.
5361 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5363 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5364 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5366 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5367 Some packages use them to denote characters with modifiers.
5369 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5371 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5372 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5373 matching a pp-number. Rename parameter var to var1.
5375 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5377 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5379 2011-10-08 Glenn Morris <rgm@gnu.org>
5381 * callint.c (Fcall_interactively): Give a more explicit error for the
5382 'c' case with a non-character input. (Bug#8479)
5384 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5386 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5388 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5389 lines that are hscrolled on the left.
5391 * dispnew.c (buffer_posn_from_coords): Account for a possible
5392 presence of header-line. (Bug#4426)
5394 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5396 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5397 Don't advertise functionality which we discourage or doesn't work.
5399 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5401 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5402 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5403 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5404 this makes Emacs dump core during garbage collection on rare
5405 occasions. sizeof is obviously inferior to offsetof here, so
5406 stick with offsetof.
5407 (GC_POINTER_ALIGNMENT): New macro.
5408 (mark_memory): Omit 3rd (offset) arg; caller changed.
5409 Don't assume EMACS_INT alignment is the same as pointer alignment.
5411 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5413 * keyboard.c (read_key_sequence_remapped): New var.
5414 (read_key_sequence): Compute remapping in the right buffer.
5415 (command_loop_1): Use read_key_sequence's remapping directly.
5417 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5419 * dired.c (file_name_completion): Don't expand file name.
5420 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5421 before checking file name handler.
5423 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5424 they've been requested explicitly (bug#9591).
5426 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5428 * keymap.c (Fsingle_key_description): Use make_specified_string
5429 instead of build_string to build string from push_key_description.
5432 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5434 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5435 This fixes a Y2038 bug on 64-bit hosts.
5436 * buffer.c (reset_buffer):
5437 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5438 (Fclear_buffer_auto_save_failure):
5439 Use 0, not -1, to represent an unset failure time, since time_t
5440 might not be signed.
5442 Remove dependency on glibc malloc internals.
5443 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5444 Move back here from lisp.h, but with their new implementations.
5445 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5446 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5447 * charset.c (charset_table_init): New static var.
5448 (syms_of_charset): Use it instead of xmalloc. This removes a
5449 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5450 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5451 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5452 Move back to alloc.c.
5453 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5454 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5456 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5458 * nsterm.m (windowDidResize): Call x_set_window_size only when
5459 ns_in_resize is true. Otherwise set pixelwidth/height and
5460 call change_frame_size (Bug#9628).
5462 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5464 Port --enable-checking=all to Fedora 14 x86-64.
5465 * charset.c (syms_of_charset): Also account for glibc malloc's
5466 internal overhead when calculating the initial malloc maximum.
5468 Port --enable-checking=all to Fedora 14 x86.
5469 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5471 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5472 (overrun_check_realloc, overrun_check_free):
5473 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5474 That way, xmalloc returns a properly-aligned pointer even if
5475 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5476 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5477 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5478 into account when calculating the initial malloc maximum.
5479 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5480 Move here from alloc.c, so that charset.c can use it too.
5481 Properly align; the old code wasn't right for common 32-bit hosts
5482 when configured with --enable-checking=all.
5483 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5484 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5486 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5488 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5491 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5493 * xdisp.c (compute_display_string_end): If there's no display
5494 string at CHARPOS, return -1.
5496 * bidi.c (bidi_fetch_char): When compute_display_string_end
5497 returns a negative value, treat the character as a normal
5498 character not covered by a display string. (Bug#9624)
5500 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5502 * lread.c (Fread_from_string): Fix typo in docstring.
5504 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5506 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5507 newline, reseat the iterator instead of bidi-iterating there one
5508 character at a time. (Bug#9610)
5509 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5510 TO_CHARPOS if the bidi iterator is at base embedding level.
5512 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5514 * lread.c (readevalloop): Use correct code for NBSP.
5515 (read1): Likewise. (Bug#9608)
5517 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5519 * dbusbind.c (Fdbus_register_signal): When service is not
5520 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5522 2011-09-25 Glenn Morris <rgm@gnu.org>
5524 * buffer.c (truncate-lines): Doc fix.
5526 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5528 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5529 (Fset_window_next_buffers): Doc fix.
5531 2011-09-24 Glenn Morris <rgm@gnu.org>
5533 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5535 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5537 Fix minor problems found by static checking.
5538 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5539 * indent.c (Fvertical_motion): Fix == vs = typo.
5541 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5543 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5544 Default value is now t. Doc fix.
5546 * indent.c (Fvertical_motion): Compute and apply the overshoot
5547 logic when moving up, not only when moving down. Fix the
5548 confusing name and values of the it_overshoot_expected variable;
5549 logic changes accordingly. (Bug#9254) (Bug#9549)
5551 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5552 CHARPOS is covered by a display string which includes newlines.
5553 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5554 is covered by a display string with embedded newlines.
5556 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5558 * dbusbind.c (Fdbus_register_signal): Add match rule to
5559 Vdbus_registered_objects_table. (Bug#9581)
5560 (Fdbus_register_method, Vdbus_registered_objects_table):
5563 2011-09-24 Jim Meyering <meyering@redhat.com>
5565 do not ignore write error for any output size
5566 The previous change was incomplete.
5567 While it makes emacs --batch detect the vast majority of stdout
5568 write failures, errors were still ignored whenever the output size is
5569 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5570 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5571 && echo FAIL: ignored write error
5572 FAIL: ignored write error
5573 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5574 && echo FAIL: ignored write error
5575 FAIL: ignored write error
5576 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5578 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5580 * emacs.c (Fkill_emacs): In noninteractive mode exit
5581 non-successfully if a write error occurred on stdout. (Bug#9574)
5583 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5585 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5588 * dispextern.h (struct it): Update the comment documenting what
5591 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5593 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5594 a display string, extend search for cursor position to end of row.
5595 (find_row_edges): If the row ends in a newline from a display
5596 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5597 Handle the case of a display string with multiple newlines.
5598 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5599 non-empty line. Fixes confusing cursor motion with arrow keys at
5600 the beginning of a line that starts with whitespace.
5602 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5604 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5607 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5609 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5612 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5614 * xdisp.c (display_line): Record maximum and minimum buffer
5615 positions even if no glyphs were produced (e.g., by a zero-width
5616 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5617 buffer positions that will be removed from the glyph row because
5619 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5620 column is beyond frame width: don't subtract 1 "pixel" when
5621 computing width of the stretch.
5622 (reseat_at_next_visible_line_start): Undo the change made on
5623 2011-09-17 that saved paragraph information and restored it after
5624 the call to `reseat'. (Bug#9545)
5626 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5628 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5629 and turn window cursor on if cleared (Bug#9415).
5631 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5633 * search.c (boyer_moore): Take unibyte characters from pattern
5634 literally. (Bug#9458)
5636 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5638 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5640 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5642 Fix minor problem found by static checking.
5643 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5644 initialized, to pacify gcc -Wuninitialized.
5646 * fileio.c: Report proper errno when syscall falls.
5647 (Finsert_file_contents): Save and restore errno,
5648 so that report_file_error outputs the correct diagnostic.
5649 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5651 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5653 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5655 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5658 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5660 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5662 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5663 about the current paragraph and restore it after the call to reseat.
5665 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5666 (bidi_find_paragraph_start): Search back for paragraph beginning
5667 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5668 (bidi_move_to_visually_next): Only trigger paragraph-related
5669 computations when the last character is a newline or at EOB, not
5670 just any NEUTRAL_B. (Bug#9470)
5672 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5673 truncated lines if point is covered by a display string. (Bug#9524)
5675 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5677 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5678 (cons_to_x_long): New function.
5679 (lisp_data_to_selection_data): Use it. Correct the test for
5680 short-versus-long data; it was negated. Break out of vector
5681 loop, for efficiency, when a long datum is discovered.
5683 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5685 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5687 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5689 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5690 GCC PR/17406) by declaring this function with external scope.
5692 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5694 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5695 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5697 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5699 * editfns.c (Fformat): Correctly handle text properties on "%%".
5701 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5703 * xterm.c (x_draw_composite_glyph_string_foreground):
5704 * w32term.c (x_draw_composite_glyph_string_foreground):
5705 * term.c (encode_terminal_code):
5706 * composite.c (composition_update_it, get_composition_id):
5707 * xdisp.c (get_next_display_element)
5708 (fill_composite_glyph_string): Add comments about special meaning
5709 of TAB characters in a composition.
5711 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5713 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5714 This occurs when processing a multibyte format.
5715 Problem reported by Wolfgang Jenker.
5717 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5719 * xdisp.c (try_cursor_movement): Only check for exact match if
5720 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5722 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5724 Remove unused external symbols.
5725 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5726 * xdisp.c (calc_pixel_width_or_height): Now static.
5727 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5728 * indent.c (check_display_width):
5729 * w32term.c: Fix comment to match code.
5730 * xterm.c, xterm.h (x_catching_errors): Remove.
5732 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5734 * xselect.c: Use signed conversions more consistently (Bug#9498).
5735 (selection_data_to_lisp_data): Assume incoming selection data are
5736 signed integers, not unsigned. This is to be consistent with
5737 outgoing selection data, which was modified to use signed integers
5738 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5739 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5740 expects long, not unsigned long.
5742 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5744 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5745 computation of loop end. Reported by Johan Bockgård
5748 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5750 * frame.c (Fother_visible_frames_p): Function deleted.
5752 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5754 * indent.c (compute_motion): Process display vector front to back
5755 rather than the other way around. (Bug#2496)
5757 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5759 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5761 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5763 * minibuf.c (Fread_from_minibuffer): Doc fix.
5765 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5768 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5770 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5772 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5773 value for non-existent files.
5775 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5777 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5778 set its "size" to -1. This will set the modtime_size field of
5779 the corresponding buffer to -1, which is what
5780 verify-visited-file-modtime expects for files that do not exist.
5783 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5785 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5787 * lisp.h: ... from here. push_key_description is no longer
5788 defined in keyboard.c, so its declaration should not be in
5789 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5790 logically belongs with push_key_description.
5792 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5794 * buffer.h: Include <sys/types.h> instead of <time.h>.
5795 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5796 Problem reported by Herbert J. Skuhra.
5798 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5800 * xml.c (parse_region): Make the parsing work for
5801 non-comment-starting XML files again (bug#9144).
5803 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5805 * image.c (gif_load): Fix calculation of bottom and right corner.
5808 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5810 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5811 redisplay in small windows.
5813 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5815 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5817 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5819 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5820 Operate on live windows only.
5822 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5824 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5826 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5828 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5829 only under bidi iteration.
5831 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5833 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5835 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5837 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5838 Without this fix, the command to link temacs failed due to an
5839 undefined symbol __builtin_isnan. This is because
5840 /usr/include/iso/math_c99.h #defines isnan(x) to
5841 __builtin_isnan(x), but the bundled gcc, which identifies itself
5842 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5844 * floatfns.c (isnan): #undef, and then #define to a clone of
5846 (Fisnan): Always define, since it's always available now.
5847 (syms_of_floatfns): Always define isnan at the Lisp level.
5849 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5851 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5853 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5855 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5856 The previous code assumed that file offsets (off_t values) fit in
5857 EMACS_INT variables, which is not true on typical 32-bit hosts.
5858 The code messed up by falsely reporting buffer overflow in cases
5859 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5860 when "big" contains more than 2**29 bytes, even though this
5861 inserts just one byte and does not overflow the buffer.
5862 (Finsert_file_contents): Store file offsets as off_t
5863 values, not as EMACS_INT values. Check for overflow when
5864 converting between EMACS_INT and off_t. When checking for
5865 buffer overflow or for overlap, take the offsets into account.
5866 Don't use EMACS_INT for small values where int suffices.
5867 When checking for overlap, fix a typo: ZV was used where
5868 ZV_BYTE was intended.
5869 (Fwrite_region): Don't assume off_t fits into 'long'.
5870 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5872 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5874 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5876 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5878 sprintf-related integer and memory overflow issues (Bug#9412).
5880 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5881 (esprintf, exprintf, evxprintf): New functions.
5882 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5883 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5884 (modify_event_symbol): Do not assume that the length of
5885 name_alist_or_stem is safe to alloca and fits in int.
5886 (Fexecute_extended_command): Likewise for function name and binding.
5887 (Frecursion_depth): Wrap around reliably on integer overflow.
5888 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5889 since some callers pass EMACS_INT values.
5890 (Fsingle_key_description): Don't crash if symbol name contains more
5891 than MAX_ALLOCA bytes.
5892 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5893 (get_minibuffer): Arg is now EMACS_INT, not int.
5894 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5895 (esprintf, exprintf, evxprintf): New decls.
5896 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5898 * dbusbind.c (signature_cat): New function.
5899 (xd_signature, Fdbus_register_signal):
5900 Do not overrun buffer; instead, report string overflow.
5902 * dispnew.c (add_window_display_history): Don't overrun buffer.
5903 Truncate instead; this is OK since it's just a log.
5905 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5906 even if the time zone offset is outlandishly large.
5907 Don't mishandle offset == INT_MIN.
5909 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5910 when creating daemon; the previous buffer-overflow check was incorrect.
5912 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5913 which has the guts of the old verror function.
5915 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5916 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5918 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5919 (font_unparse_xlfd): Don't blindly alloca long strings.
5920 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5921 fits in int, when using sprintf. Use single snprintf to count
5922 length of string rather than counting it via multiple sprintfs;
5923 that's simpler and more reliable.
5924 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5925 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5926 sprintf, in case result does not fit in int.
5928 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5929 (fontset_from_font): Print it.
5931 * frame.c (tty_frame_count): Now printmax_t, not int.
5932 (make_terminal_frame, set_term_frame_name): Print it.
5933 (x_report_frame_params): In X, window IDs are unsigned long,
5934 not signed long, so print them as unsigned.
5935 (validate_x_resource_name): Check for implausibly long names,
5936 and don't assume name length fits in 'int'.
5937 (x_get_resource_string): Don't blindly alloca invocation name;
5938 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5941 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5942 (xg_check_special_colors, xg_set_geometry):
5943 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5945 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5946 Use esprintf, not sprintf, in case result does not fit in int.
5948 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5949 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5950 it as a large positive number.
5951 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5952 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5954 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5955 in case result does not fit in int.
5957 * print.c (float_to_string): Detect width overflow more reliably.
5958 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5959 buffer overrun. Don't assume list length fits in 'int'. Treat
5960 print length of 0 as 0, not as infinity; to be consistent with other
5961 uses of print length in this function. Don't overflow print length
5962 index. Don't assume hash table size fits in 'long', or that
5963 vectorlike size fits in 'unsigned long'.
5965 * process.c (make_process): Use printmax_t, not int, to format
5966 process-name gensyms.
5968 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5970 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5971 to avoid potential buffer overrun.
5973 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5974 if X resource line is longer than 512 bytes.
5976 * xfns.c (x_window): Make sprintf buffer a bit bigger
5977 to avoid potential buffer overrun.
5979 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5981 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5983 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5985 Integer overflow fixes for scrolling, etc.
5986 Without these, Emacs silently mishandles large integers sometimes.
5987 For example, "C-u 4294967297 M-x recenter" was treated as if
5988 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5990 * xdisp.c (try_window_id): Check Emacs fixnum range before
5991 converting to 'int'.
5993 * window.c (window_scroll_line_based, Frecenter):
5994 Check that an Emacs fixnum is in range before assigning it to 'int'.
5995 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5996 values converted from Emacs fixnums.
5997 (Frecenter): Don't wrap around a line count if it is out of 'int'
5998 range; instead, treat it as an extreme value.
5999 (Fset_window_configuration, compare_window_configurations):
6000 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6002 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6003 that can exceed INT_MAX. Check that EMACS_INT value is in range
6004 before assigning it to the (possibly-narrower) index.
6005 (match_limit): Don't assume that a fixnum can fit in 'int'.
6007 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6010 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6011 (Fvertical_motion): Don't wrap around LINES values that don't fit
6012 in 'int'. Instead, treat them as extreme values. This is good
6013 enough for windows, which can't have more than INT_MAX lines anyway.
6015 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6017 * Require libxml/parser.h to avoid compilation warning.
6019 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6021 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6022 since this reportedly can destroy thread storage.
6024 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6026 * syntax.c (find_defun_start): Update all cache variables if
6027 exiting early (Bug#9401).
6029 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6031 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6033 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6034 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6035 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6037 * term.c (tty_append_glyph): New function.
6038 (produce_stretch_glyph): Static function and its prototype deleted.
6040 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6043 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6045 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6046 when checking :margin (Bug#9390).
6047 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6048 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6049 so that the name doesn't mislead. All uses changed.
6051 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6053 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6056 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6058 * xdisp.c (move_it_to): Don't bail out early when reaching
6059 position beyond to_charpos, if we are scanning backwards.
6060 (move_it_vertically_backward): When DY == 0, make sure we get to
6061 the first character in the line after the newline.
6063 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6065 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6066 (ccl_driver): Do not generate an out-of-range pointer.
6067 (Fccl_execute_on_string): Remove unnecessary check for
6068 integer overflow, noted by Stefan Monnier in
6069 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6070 Remove a FIXME that didn't need fixing.
6071 Simplify the newly-introduced buffer reallocation code.
6073 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6075 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6077 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6079 Integer and memory overflow issues (Bug#9196).
6081 * doc.c (get_doc_string): Rework so that
6082 get_doc_string_buffer_size is the actual buffer size, rather than
6083 being 1 less than the actual buffer size; this makes xpalloc more
6086 * image.c (x_allocate_bitmap_record, cache_image):
6087 * xselect.c (Fx_register_dnd_atom):
6088 Simplify previous changes by using xpalloc.
6090 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6091 since either will do and ptrdiff_t is convenient with xpalloc.
6093 * charset.c (charset_table_size)
6094 (struct charset_sort_data.priority): Now ptrdiff_t.
6095 (charset_compare): Don't overflow if priorities differ greatly.
6096 (Fsort_charsets): Don't assume list length fits in int.
6097 Check for size-calculation overflow when allocating sort data.
6098 (syms_of_charset): Allocate an initial charset table that is
6099 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6101 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6103 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6104 The actual value is always <= INT_MAX, and leaving it unsigned made
6105 overflow checking harder.
6107 * dispextern.h (struct glyph_matrix.rows_allocated)
6108 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6109 with xpalloc. The values are still always <= INT_MAX.
6111 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6113 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6114 (SAFE_NALLOCA): New macro.
6116 * region-cache.c (struct boundary.pos, find_cache_boundary)
6117 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6118 (set_cache_region, invalidate_region_cache)
6119 (revalidate_region_cache, know_region_cache, region_cache_forward)
6120 (region_cache_backward, pp_cache):
6121 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6122 so that ptrdiff_t * can be passed to xpalloc.
6123 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6124 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6125 (pp_cache): Don't assume cache_len fits in int.
6126 * region-cache.h: Adjust extern decls to match.
6128 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6129 EMACS_INT, since either will do, for xpalloc.
6131 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6132 (xnmalloc, xnrealloc, xpalloc): New functions.
6134 * bidi.c (bidi_shelve_header_size): New constant.
6135 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6136 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6138 * bidi.c (bidi_cache_shrink):
6139 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6141 Don't update size of array until after memory allocation succeeds,
6142 because xmalloc/xrealloc may not return.
6143 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6144 now that we have proper integer overflow checking.
6145 (record_overlay_string, overlay_strings): Catch overflows when
6146 calculating size of overlay_str_buf.
6148 * callproc.c (Fcall_process): Check for size overflow when
6149 calculating size of args2.
6150 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6151 Normally we prefer signed values, but sticking with ptrdiff_t would
6152 require adding more-complicated checks.
6154 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6155 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6156 Redo buffer-overflow calculations to avoid integer overflow.
6157 Add a FIXME comment where memory seems to be over-allocated.
6159 * character.c (Fstring): Check for size-calculation overflow.
6161 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6162 unnecessary integer overflow. Check for size overflow.
6163 (encode_coding_object): Don't update size until xmalloc succeeds.
6165 * composite.c (get_composition_id): Check for overflow in glyph
6166 length calculations.
6168 Integer and memory overflow fixes for display code.
6169 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6170 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6171 (scrolling_window): Check for overflow in size calculations.
6172 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6173 Don't assume glyph table len fits in int.
6174 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6175 (row_table_size): Now ptrdiff_t, not int.
6176 (scrolling_window): Avoid overflow in size calculations.
6177 Don't update size until allocation succeeds.
6178 * fns.c (concat): Check for overflow in size calculations.
6179 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6180 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6181 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6183 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6184 (get_doc_string): Check for size calculation overflow.
6185 Don't update size until allocation succeeds.
6186 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6187 EMACS_INT, where ptrdiff_t will do.
6188 (Fsubstitute_command_keys): Check for string overflow.
6190 * editfns.c (set_time_zone_rule): Don't assume environment length
6192 (message_length): Now ptrdiff_t, not int.
6193 (Fmessage_box): Don't update size until allocation succeeds.
6194 Don't assume message length fits in int.
6195 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6197 * emacs.c (main): Do not reallocate argv, since there is a null at
6198 the end that can be overwritten, and this way there's no need to
6199 worry about size-calculation overflow.
6200 (sort_args): Check for size-calculation overflow.
6202 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6204 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6206 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6207 (x_set_scroll_bar_width, x_figure_window_size):
6208 Check for integer overflow.
6209 (x_set_alpha): Do not assume XINT fits in int.
6211 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6212 This is for the members text_lines, text_cols, total_lines, total_cols,
6213 where the system imposes an 'int' limit.
6215 * fringe.c (Fdefine_fringe_bitmap):
6216 Don't update size until alloc works.
6218 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6219 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6221 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6222 Check for size-calculation overflow.
6223 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6224 do, as we prefer signed integers.
6225 (id_to_widget.max_size, id_to_widget.used)
6226 (xg_store_widget_in_map, xg_remove_widget_from_map)
6227 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6228 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6229 Use and return ptrdiff_t, not int.
6230 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6231 * gtkutil.h: Change prototypes to match the above.
6233 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6234 are duplicate now that they've been promoted to lisp.h.
6235 (x_allocate_bitmap_record, x_alloc_image_color)
6236 (make_image_cache, cache_image, xpm_load):
6237 Don't update size until alloc is done.
6238 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6240 Check for size calculation overflow.
6241 (ct_colors_allocated_max): New constant.
6242 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6245 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6246 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6247 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6248 Use ptrdiff_t, not int, to count maps.
6249 (read_char_minibuf_menu_prompt): Check for overflow in size
6250 calculations. Don't update size until allocation succeeds.
6251 Redo calculations to avoid overflow.
6252 * keyboard.h: Change prototypes to match the above.
6254 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6256 (current_minor_maps): Check for size calculation overflow.
6257 * keymap.h: Change prototypes to match the above.
6259 * lread.c (read1, init_obarray): Don't update size until alloc done.
6261 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6262 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6264 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6265 Now ptrdiff_t, not int.
6266 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6267 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6269 * process.c (Fnetwork_interface_list): Check for overflow
6270 in size calculation.
6272 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6274 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6275 overflow. Don't bother calling xmalloc when xrealloc will do.
6277 * search.c (Freplace_match): Check for size calculation overflow.
6278 (Fset_match_data): Don't assume list lengths fit in 'int'.
6280 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6281 for command line length. Do not attempt to address one before the
6282 beginning of an array, as that's not portable.
6284 * term.c (max_frame_lines): Remove; unused.
6285 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6287 (encode_terminal_code, calculate_costs): Check for size
6288 calculation overflow.
6289 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6290 table lengths and related sizes. Don't update size until alloc
6291 done. Redo calculations to avoid overflow.
6292 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6294 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6295 subtracting pointers.
6296 (gobble_line): Check for overflow more carefully. Don't update size
6299 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6300 Don't update size until alloc done.
6301 Redo size calculations to avoid overflow.
6302 Check for size calculation overflow.
6303 (main) [DEBUG]: Fix typo in invoking tparam1.
6305 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6306 Use ptrdiff_t, not int, for sizes.
6307 (store_mode_line_noprop_char): Don't update size until alloc done.
6309 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6310 Use ptrdiff_t, not int, for sizes.
6311 (Finternal_make_lisp_face, cache_face):
6312 Check for size calculation overflow.
6313 (cache_face): Treat size calculation overflows as if they were
6314 memory exhaustion (the usual treatment), rather than aborting.
6316 * xfns.c (x_encode_text, x_set_name_internal)
6317 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6318 sizes, since they can exceed INT_MAX in size. Check for size
6319 calculation overflow.
6321 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6322 (xg_select): Check for size calculation overflow.
6323 Don't update size until alloc done.
6325 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6326 as sprintf is limited to int lengths.
6328 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6329 (X_LONG_MIN): New macros.
6330 Use them to make the following changes clearer.
6331 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6332 This change doesn't affect the value now, but it may help remind
6333 future maintainers not to raise the value too much later.
6334 (SELECTION_QUANTUM): Remove, replacing with ...
6335 (selection_quantum): ... new function, which avoids overflow.
6337 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6338 assumption that selection length fits in 'int'.
6339 (x_reply_selection_request, x_handle_selection_request)
6340 (x_get_window_property, receive_incremental_selection)
6341 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6342 (lisp_data_to_selection_data, clean_local_selection_data):
6343 Use ptrdiff_t, not int, to record length of selection.
6344 (x_reply_selection_request, x_get_window_property)
6345 (receive_incremental_selection, x_property_data_to_lisp):
6346 Redo calculations to avoid overflow.
6347 (x_reply_selection_request): When sending hint, ceiling it at
6348 X_LONG_MAX rather than relying on wraparound overflow to send
6350 (x_get_window_property, receive_incremental_selection)
6351 (lisp_data_to_selection_data, x_property_data_to_lisp):
6352 Check for size-calculation overflow.
6353 (x_get_window_property, receive_incremental_selection)
6354 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6355 Don't store size until memory allocation succeeds.
6356 (x_get_window_property): Plug memory leak on memory exhaustion.
6357 Don't double-block input; malloc is safe here. Don't assume 2**34
6358 - 4 fits in unsigned long. Add an xassert to check
6359 XGetWindowProperty overflow. Be more careful about overflow
6360 calculations, and distinguish size from memory overflow better.
6361 (receive_incremental_selection): When tracing, don't assume
6362 unsigned int is less than INT_MAX.
6363 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6364 harmful) conversions of unsigned short to int.
6365 (lisp_data_to_selection_data): Don't assume that integers
6366 in the range -65535 through -1 fit in an X unsigned short.
6367 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6368 result parameters unless successful. Rely on cons_to_unsigned
6369 to report problems with elements; the old code wasn't right anyway.
6370 (x_check_property_data): Check for int overflow; we cannot use
6371 a wider type due to X limits.
6372 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6374 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6376 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6377 (x_term_init): Check for size calculation overflow.
6378 (x_color_cells): Don't store size until memory allocation succeeds.
6379 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6380 Don't assume alloca size is less than MAX_ALLOCA.
6381 (x_term_init): Don't assume length fits in int (sprintf is limited
6384 Use ptrdiff_t for composition IDs.
6385 * character.c (lisp_string_width):
6386 * composite.c (composition_table_size, n_compositions)
6387 (get_composition_id, composition_gstring_from_id):
6388 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6389 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6390 * window.c (Frecenter):
6391 Use ptrdiff_t, not int, for composition IDs.
6392 * composite.c (get_composition_id): Check for integer overflow.
6393 * composite.h: Adjust prototypes to match the above changes.
6395 Use ptrdiff_t for hash table indexes.
6396 * category.c (hash_get_category_set):
6397 * ccl.c (ccl_driver):
6398 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6399 * coding.c (coding_system_charset_list, detect_coding_system):
6400 * coding.h (struct coding_system.id):
6401 * composite.c (get_composition_id, gstring_lookup_cache):
6402 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6403 * image.c (xpm_get_color_table_h):
6404 * lisp.h (hash_lookup, hash_put):
6405 * minibuf.c (Ftest_completion):
6406 Use ptrdiff_t for hash table indexes, not int (which is too
6407 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6408 32-bit --with-wide-int hosts).
6410 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6411 Add a FIXME comment about memory leaks.
6412 (syms_of_charset): Don't assume xmalloc returns.
6414 Don't assume that stated character widths fit in int.
6415 * character.c (Fchar_width, c_string_width, lisp_string_width):
6416 * character.h (CHAR_WIDTH):
6417 * indent.c (MULTIBYTE_BYTES_WIDTH):
6418 Use sanitize_char_width to avoid undefined and/or bad behavior
6419 with outlandish widths.
6420 * character.h (sanitize_tab_width): Rename from sanitize_width,
6421 now that we have two such functions. All uses changed.
6422 (sanitize_char_width): New inline function.
6424 Don't assume that tab-width fits in int.
6425 * character.h (sanitize_width): New inline function.
6426 (SANE_TAB_WIDTH): New macro.
6427 (ASCII_CHAR_WIDTH): Use it.
6428 * indent.c (sane_tab_width): Remove. All uses replaced by
6429 SANE_TAB_WIDTH (current_buffer).
6430 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6432 * fileio.c: Integer overflow issues with file modes.
6433 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6435 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6436 Remove unreachable code.
6437 (read_hex, load_charset_map_from_file): Check for integer overflow.
6439 * xterm.c: Don't go over XClientMessageEvent limit.
6440 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6441 (x_send_scroll_bar_event): Likewise. Check that the size does not
6442 exceed limits imposed by XClientMessageEvent, as well as the usual
6443 ptrdiff_t and size_t limits.
6445 * keyboard.c: Overflow, signedness and related fixes.
6446 (make_lispy_movement): Use same integer type in forward decl
6447 that is used in the definition.
6448 (read_key_sequence, keyremap_step):
6449 Change bufsize argument back to int, undoing my 2011-03-30 change.
6450 We prefer signed types, and int is wide enough here.
6451 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6452 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6453 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6454 length, not size_t. Use ptrdiff_t for index, not int.
6455 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6456 possibility of integer overflow.
6458 Overflow, signedness and related fixes for images.
6460 * dispextern.h (struct it.stack[0].u.image.image_id)
6461 (struct_it.image_id, struct image.id, struct image_cache.size)
6462 (struct image_cache.used, struct image_cache.ref_count):
6463 * gtkutil.c (update_frame_tool_bar):
6464 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6465 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6466 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6467 * nsmenu.m (update_frame_tool_bar):
6468 * xdisp.c (calc_pixel_width_or_height):
6469 * xfns.c (image_cache_refcount):
6470 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6471 on typical 64-bit hosts.
6473 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6474 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6475 Omit unnecessary casts to int.
6476 (parse_image_spec): Check that integers fall into 'int' range
6477 when the callers expect that.
6478 (image_ascent): Redo ascent calculation to avoid int overflow.
6479 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6480 (lookup_image): Remove unnecessary tests.
6481 (xbm_image_p): Locals are now of int, not EMACS_INT,
6482 since parse_image_check makes sure they fit into int.
6483 (png_load, gif_load, svg_load_image):
6484 Prefer int to unsigned where either will do.
6485 (tiff_handler): New function, combining the cores of the
6486 old tiff_error_handler and tiff_warning_handler.
6487 This function is rewritten to use vsnprintf and thereby avoid
6488 stack buffer overflows. It uses only the features of vsnprintf
6489 that are common to both POSIX and native Microsoft.
6490 (tiff_error_handler, tiff_warning_handler): Use it.
6491 (tiff_load, gif_load, imagemagick_load_image):
6492 Don't assume :index value fits in 'int'.
6493 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6494 (imagemagick_load_image): Check that crop parameters fit into
6495 the integer types that MagickCropImage accepts. Don't assume
6496 Vimagemagick_render_type has a nonnegative value. Don't assume
6497 size_t fits in 'long'.
6498 (gs_load): Use printmax_t to print the widest integers possible.
6499 Check for integer overflow when computing image height and width.
6501 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6503 * xdisp.c (redisplay_window): Don't force window start if point
6504 will be invisible in the resulting window. (Bug#9324)
6506 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6508 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6509 the display spec is of the form `(space ...)'.
6510 (handle_display_spec): Return the value returned by
6511 handle_single_display_spec, not just 1 or zero.
6512 (handle_single_display_spec): If the display spec is of the form
6513 `(space ...)', and specifies display in the text area, return 2
6515 (try_cursor_movement): Check for the need to scroll more
6516 accurately, and prefer exact match for point under bidi.
6517 Don't advance `row' beyond the last row of the window.
6519 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6520 into disp_prop; all users changed.
6522 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6523 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6524 for the text covered by the display property.
6526 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6528 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6529 Change return value to nil.
6530 (Frecord_buffer): Delete unused function.
6532 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6534 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6535 buffers, return left-to-right.
6536 (set_cursor_from_row): Consider candidate row a win if its glyph
6537 represents a newline and point is on that newline. Fixes cursor
6538 positioning on the newline at EOL of R2L text within L2R
6539 paragraph, and vice versa.
6540 (try_cursor_movement): Check continued rows, in addition to
6541 continuation rows. Fixes unwarranted scroll when point enters a
6542 continued line of R2L text within an L2R paragraph, or vice versa.
6543 (cursor_row_p): Consider the case of point being equal to
6544 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6545 from the end of a short line to the beginning of a continued line
6546 of R2L text within L2R paragraph.
6547 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6548 composed characters.
6550 * bidi.c (bidi_check_type): Use xassert.
6551 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6554 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6556 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6559 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6561 * nsfont.m (ns_otf_to_script): Fix typo.
6563 2011-08-22 Kenichi Handa <handa@m17n.org>
6565 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6566 extra slot even if the purpose is char-code-property-table.
6568 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6570 * xdisp.c (redisplay_window): When computing centering_position,
6571 account for the height of the header line. (Bug#8874)
6573 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6574 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6575 candidate is selected by the mouse, and that candidate has a
6576 composed character under the mouse.
6578 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6579 coordinates reported by pos-visible-in-window-p for a composed
6580 character in column zero.
6582 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6584 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6586 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6588 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6589 consider it a hit if to_charpos is anywhere in the range of the
6590 composed buffer positions.
6592 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6594 * image.c (gif_load): Don't assume that each subimage has the same
6595 dimensions as the base image. Handle disposal method that is
6596 "undefined" by the gif spec (Bug#9335).
6598 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6600 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6601 (Fcondition_case): Document `debug' symbol in error handler.
6603 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6605 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6606 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6607 from an Org mode buffer to a Speedbar frame.
6609 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6610 a composition, take its buffer position from IT->cmp_it.charpos.
6611 Fixes cursor positioning at the beginning of a line that begins
6612 with a composed character.
6614 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6616 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6617 character bidirectional type, use STRONG_L instead. Fixes crashes
6618 in a buffer produced by `describe-categories'.
6620 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6621 members before the level stack, so they would be saved and
6622 restored when copying iterator state. Fixes incorrect reordering
6623 around TABs covered by display properties.
6625 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6627 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6629 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6631 * eval.c (internal_condition_case, internal_condition_case_1)
6632 (internal_condition_case_2, internal_condition_case_n):
6633 Remove unnecessary aborts (Bug#9081).
6635 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6637 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6638 has no `load' handler, try opening the file locally. (Bug#9311)
6640 2011-08-16 Ken Brown <kbrown@cornell.edu>
6642 * gmalloc.c: Expand comment.
6644 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6646 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6647 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6649 2011-08-16 Ken Brown <kbrown@cornell.edu>
6651 Fix memory allocation problems in Cygwin build (Bug#9273).
6653 * unexcw.c ( __malloc_initialized): Declare external variable.
6654 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6656 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6658 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6660 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6662 [CYGWIN] (special_realloc): New function.
6663 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6664 requests to realloc storage in the static heap.
6666 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6668 * bidi.c (bidi_initialize): Remove unused local.
6670 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6673 * biditype.h: Remove file.
6674 * makefile.w32-in ($(BLD)/bidi.$(O)):
6675 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6677 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6679 * chartab.c: Improve commentary for the uniprop_table API.
6681 * bidi.c (bidi_paragraph_init): Support zero value of
6682 bidi_ignore_explicit_marks_for_paragraph_level.
6683 (bidi_initialize): Use uniprop_table instead of including
6684 biditype.h and bidimirror.h.
6686 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6687 coordinates of the iterator when restoring from ppos_it.
6690 2011-08-14 Kenichi Handa <handa@m17n.org>
6692 * process.c (create_process): Call setup_process_coding_systems
6693 after the pid of the process is set to -1 (Bug#8162).
6695 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6697 * xdisp.c (move_it_in_display_line_to): Don't invoke
6698 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6699 ppos_it. Fixes vertical cursor motion when line beginning is
6700 covered by an image. (Bug#9296)
6702 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6704 * nsterm.h (ns_run_ascript): Declare.
6705 (NSAPP_DATA2_RUNASSCRIPT): Define.
6707 * nsfns.m (as_script, as_result, as_status): New static variables.
6708 (ns_run_ascript): New function.
6709 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6710 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6711 the event loop. Get status from as_status (Bug#7276).
6713 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6714 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6715 the event loop (Bug#7276).
6717 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6719 * gnutls.c (QCgnutls_bootprop_priority)
6720 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6721 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6722 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6723 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6724 (QCgnutls_bootprop_verify_hostname_error)
6725 (QCgnutls_bootprop_callbacks_verify): Rename from
6726 Qgnutls_bootprop_..., all uses changed.
6728 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6731 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6733 * xfaces.c (Qframe_set_background_mode): Now static.
6734 * dispextern.h (Qframe_set_background_mode): Remove decl.
6736 * process.c (Fnetwork_interface_info): Declare local only if needed.
6738 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6740 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6741 (Fnetwork_interface_list): Allocate in increments of bytes instead
6742 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6743 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6745 (struct ifflag_def): notrailers is smart on OSX.
6746 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6747 Get hardware address with getifaddrs if available.
6749 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6751 * xdisp.c (iterate_out_of_display_property): xassert that
6752 IT->position is set to within IT->object's boundaries. Break from
6753 the loop as soon as EOB is reached; avoids infloops in redisplay
6754 when IT->position is set up wrongly due to some bug.
6755 Set IT->current to match the bidi iterator unconditionally.
6756 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6757 entry. Force push_it to save on the stack the current
6758 buffer/string position, to be restored by pop_it. Fix flags in
6759 the iterator structure wrt the object coming from a display
6760 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6761 properties. (Bug#9284)
6763 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6765 * fontset.c (fontset_get_font_group): Add proper type checks.
6768 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6770 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6771 and LC_VERSION_MIN_MACOSX.
6772 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6773 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6775 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6777 * xdisp.c (forward_to_next_line_start): Allow to use the
6778 no-display-properties-and-no-overlays under bidi display.
6779 Set disp_pos in the bidi iterator to avoid searches for display
6780 properties and overlays.
6782 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6784 * editfns.c (Fset_time_zone_rule): Document relationship with the
6787 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6788 the font entity extracted from the cache (Bug#8109).
6790 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6792 * composite.c (autocmp_chars): Don't reset point. That is done by
6793 restore_point_unwind (Bug#5984).
6795 2011-08-07 Juri Linkov <juri@jurta.org>
6797 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6798 to show the arg `TIME' instead of `TIMEVAL'.
6800 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6802 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6803 display property strides EOL and includes a newline, as in
6804 longlines-mode. (Bug#9254)
6805 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6806 word-wrap under bidirectional display. (Bug#9224)
6808 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6809 is non-zero, even if the data buffer is NULL. Fixes a crash in
6810 vertical-motion with longlines-mode. (Bug#9254)
6812 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6814 * bidi.c <bidi_cache_total_alloc>: Now static.
6815 (bidi_initialize): Initialize bidi_cache_total_alloc.
6817 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6820 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6821 amount allocated this far in `bidi_cache_total_alloc'.
6822 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6823 non-zero, only free the data buffer without restoring the cache
6824 contents. All callers changed.
6826 * dispextern.h (bidi_unshelve_cache): Update prototype.
6828 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6829 (move_it_in_display_line, move_it_to)
6830 (move_it_vertically_backward, move_it_by_lines): Replace the call
6831 to xfree to an equivalent call to bidi_unshelve_cache.
6832 (move_it_in_display_line_to): Fix logic of returning
6833 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6835 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6837 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6838 came from a string character with a `cursor' property. (Bug#9229)
6840 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6842 * Makefile.in (LIB_PTHREAD): New variable.
6843 (LIBES): Add LIB_PTHREAD (Bug#9216).
6845 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6846 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6848 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6850 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6852 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6854 * xterm.c (x_find_topmost_parent): New function.
6855 (x_set_frame_alpha): Find topmost parent window with
6856 x_find_topmost_parent and set the property there also (bug#9181).
6857 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6859 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6861 * callproc.c (Fcall_process): Avoid vfork clobbering
6862 the local vars buffer, coding_systems, current_dir.
6864 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6866 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6868 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6870 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6871 so that it is not optimized away.
6873 * xdisp.c (compute_display_string_pos): Remove unused local.
6875 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6877 Fix slow cursor motion and scrolling in large buffers with
6878 selective display, like Org Mode buffers. (Bug#9218)
6880 * dispextern.h (struct bidi_it): New member disp_prop_p.
6882 * xdisp.c: Remove one-slot cache of display string positions.
6883 (compute_display_string_pos): Accept an additional argument
6884 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6885 for a display string or property. If found, set DISP_PROP_P
6888 * bidi.c (bidi_fetch_char): Accept an additional argument
6889 DISP_PROP_P, and pass it to compute_display_string_pos.
6890 Only handle text covered by a display string if DISP_PROP_P is returned
6891 non-zero. All callers of bidi_fetch_char changed.
6893 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6895 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6897 2010-12-03 Don March <don@ohspite.net>
6899 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6900 last character M-[char] is translated to ESC [char] (bug#7541).
6902 2011-08-02 Kenichi Handa <handa@m17n.org>
6904 * lisp.h (uniprop_table): Extern it.
6906 * chartab.c (uniprop_table): Make it non-static.
6908 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6910 * xdisp.c (forward_to_next_line_start): Accept additional argument
6911 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6913 (reseat_at_next_visible_line_start): Use the bidi iterator state
6914 returned by forward_to_next_line_start to restore the state of
6915 it->bidi_it after backing up to previous newline. (Bug#9212)
6917 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6919 * regex.c (re_comp): Protoize.
6920 (re_exec): Fix return type.
6921 (regexec): Fix type of `ret'. (Bug#9203)
6923 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6925 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6926 This is needed if max-image-size is a floating-point number.
6928 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6930 * print.c (print_object): Print empty symbol as ##.
6932 * lread.c (read1): Read ## as empty symbol.
6934 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6936 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6937 setting frame foreground color (Bug#9175).
6938 (x_set_background_color): Likewise.
6940 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6941 contents (Bug#9176).
6942 (EmacsTooltip -init): Remove bezels and add shadows to
6945 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6946 or scroll bar (Bug#8470).
6948 * nsfont.m (nsfont_open): Remove assignment to voffset and
6949 unnecessary vars hshink, expand, hd, full_height, min_height.
6950 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6952 * nsterm.h (nsfont_info): Remove voffset field.
6954 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6956 Implement strike-through and overline on NextStep (Bug#8863).
6958 * nsfont.m (nsfont_open): Use underline position provided by font,
6959 instead of hard-coded value of 2.
6960 (nsfont_draw): Call ns_draw_text_decoration instead.
6962 * nsterm.h: Add declaration for ns_draw_text_decoration.
6964 * nsterm.m (ns_draw_text_decoration): New function for drawing
6965 underline, overline, and strike-through.
6966 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6967 ns_draw_text_decoration. Change treatment of cursor drawing to
6968 accommodate underlining, etc.
6970 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6972 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6975 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6977 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6978 Without this fix, if a signal arrives just after memory fills up,
6979 'malloc' might be invoked reentrantly.
6981 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6982 In other words, assume that every image size is allowed, on non-X
6983 hosts. This assumption is probably wrong, but it lets Emacs compile.
6985 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6987 * regex.c (re_iswctype): Convert return values to boolean.
6989 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6991 * xdisp.c (compute_display_string_pos): Don't use cached display
6992 string position if the buffer had its restriction changed.
6995 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6997 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6999 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7001 Integer signedness and overflow and related fixes. (Bug#9079)
7003 * bidi.c: Integer size and overflow fixes.
7004 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7005 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7006 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7007 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7008 (bidi_find_other_level_edge):
7009 Use ptrdiff_t instead of EMACS_INT where either will do.
7010 This works better on 32-bit hosts configured --with-wide-int.
7011 (bidi_cache_ensure_space): Check for size-calculation overflow.
7012 Use % rather than repeated addition, for better worst-case speed.
7013 Don't set bidi_cache_size until after xrealloc returns, because it
7015 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7016 (bidi_cache_ensure_space): Also check that the bidi cache size
7017 does not exceed that of the largest Lisp string or buffer. See Eli
7018 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7020 * alloc.c (__malloc_size_t): Remove.
7021 All uses replaced by size_t. See Andreas Schwab's note
7022 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7024 * image.c: Improve checking for integer overflow.
7025 (check_image_size): Assume that f is nonnull, since
7026 it is always nonnull in practice. This is one less thing to
7027 worry about when checking for integer overflow later.
7028 (x_check_image_size): New function, which checks for integer
7029 overflow issues inside X.
7030 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7031 This removes the need for a memory_full check.
7032 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7033 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7034 (xbm_read_bitmap_data): Change locals back to 'int', since
7035 their values must fit in 'int'.
7036 (xpm_load_image, png_load, tiff_load):
7037 Invoke x_create_x_image_and_pixmap earlier,
7038 to avoid much needless work if the image is too large.
7039 (tiff_load): Treat overly large images as if
7040 x_create_x_image_and_pixmap failed, not as malloc failures.
7041 (gs_load): Use x_check_image_size.
7043 * gtkutil.c: Omit integer casts.
7044 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7045 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7047 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7049 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7050 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7051 would wrongly return t on a 64-bit host.
7053 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7054 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7055 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7056 and therefore cause GCC to emit a bogus diagnostic in some cases.
7058 * image.c: Integer signedness and overflow and related fixes.
7059 This is not an exhaustive set of fixes, but it's time to
7060 record what I've got.
7061 (lookup_pixel_color, check_image_size): Remove redundant decls.
7062 (check_image_size): Don't assume that arbitrary EMACS_INT values
7063 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7064 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7065 (tiff_load, imagemagick_load_image):
7066 Check for overflow in size calculations.
7067 (x_create_x_image_and_pixmap): Remove unnecessary test for
7068 xmalloc returning NULL; that can't happen.
7069 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7070 (xpm_color_bucket): Use better integer hashing function.
7071 (xpm_cache_color): Don't possibly over-allocate memory.
7072 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7073 (gif_memory_source):
7074 Use ptrdiff_t, not int or size_t, to record sizes.
7075 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7076 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7077 either works, as we prefer signed integers.
7078 (tiff_read_from_memory, tiff_write_from_memory):
7079 Return tsize_t, not size_t, since that's what the TIFF API wants.
7080 (tiff_read_from_memory): Don't fail simply because the read would
7081 go past EOF; instead, return a short read.
7082 (tiff_load): Omit no-longer-needed casts.
7083 (Fimagemagick_types): Don't assume size fits into 'int'.
7085 Improve hashing quality when configured --with-wide-int.
7086 * fns.c (hash_string): New function, taken from sxhash_string.
7087 Do not discard information about ASCII character case; this
7088 discarding is no longer needed.
7089 (sxhash-string): Use it. Change sig to match it. Caller changed.
7090 * lisp.h: Declare it.
7091 * lread.c (hash_string): Remove, since we now use fns.c's version.
7092 The fns.c version returns a wider integer if --with-wide-int is
7093 specified, so this should help the quality of the hashing a bit.
7095 * emacs.c: Integer overflow minor fix.
7096 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7097 Define only if GNU_LINUX.
7098 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7100 * dispnew.c: Integer signedness and overflow fixes.
7101 Remove unnecessary forward decls, that were a maintenance hassle.
7102 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7104 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7105 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7106 (prepare_desired_row, line_draw_cost):
7107 Use int, not unsigned, where either works.
7108 (save_current_matrix, restore_current_matrix):
7109 Use ptrdiff_t, not size_t, where either works.
7110 (init_display): Check for overflow more accurately, and without
7111 relying on undefined behavior.
7113 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7114 Remove, replacing with the new symbols in lisp.h. All uses changed.
7115 * fileio.c (make_temp_name):
7116 * filelock.c (lock_file_1, lock_file):
7117 * xdisp.c (message_dolog):
7118 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7119 Use pMd etc. instead.
7120 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7121 replacing the pWIDE etc. symbols removed from editfns.c.
7123 * keyboard.h (num_input_events): Now uintmax_t.
7124 This is (very slightly) less likely to mess up due to wraparound.
7127 * buffer.c: Integer signedness fixes.
7128 (alloc_buffer_text, enlarge_buffer_text):
7129 Use ptrdiff_t rather than size_t when either will do, as we prefer
7132 * alloc.c: Integer signedness and overflow fixes.
7133 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7134 (__malloc_size_t): Default to size_t, not to int.
7135 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7136 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7137 Prefer ptrdiff_t to size_t when either would do, as we prefer
7139 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7140 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7141 Now const. Initialize with values that are in range even if char
7143 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7144 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7145 These functions do the right thing with sizes > 2**32.
7146 (check_depth): Now ptrdiff_t, not int.
7147 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7148 Adjust to new way of storing sizes. Check for size overflow bugs
7150 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7151 slightly wrong anyway, as it missed one instance of
7152 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7153 (refill_memory_reserve): Omit needless cast to size_t.
7154 (mark_object_loop_halt): Mark as externally visible.
7156 * xselect.c: Integer signedness and overflow fixes.
7157 (Fx_register_dnd_atom, x_handle_dnd_message):
7158 Use ptrdiff_t, not size_t, since we prefer signed.
7159 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7160 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7161 x_dnd_atoms_size and x_dnd_atoms_length.
7163 * doprnt.c: Prefer signed to unsigned when either works.
7165 * doprnt.c (doprnt):
7167 * xdisp.c (vmessage):
7168 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7169 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7170 prefer signed arithmetic to avoid comparison confusion.
7171 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7172 but is a bit tricky.
7174 Assume freestanding C89 headers, string.h, stdlib.h.
7175 * data.c, doprnt.c, floatfns.c, print.c:
7176 Include float.h unconditionally.
7177 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7178 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7179 * regex.c: Likewise for stddef.h, string.h.
7180 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7181 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7182 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7183 (STDC_HEADERS): Remove obsolete defines.
7184 * sysdep.c: Include limits.h unconditionally.
7186 Assume support for memcmp, memcpy, memmove, memset.
7187 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7188 * regex.c (memcmp, memcpy):
7189 Remove; we assume C89 now.
7191 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7192 (__malloc_safe_bcopy): Remove; no longer needed.
7194 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7195 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7196 well either way, and we prefer signed to unsigned.
7198 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7200 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7201 closes the connection while we're reading (bug#9182).
7203 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7205 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7206 are specified (Bug#9168).
7208 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7210 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7211 Found by GCC static checking and --with-wide-int on a 32-bit host.
7213 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7215 * xdisp.c (compute_display_string_pos): Fix logic of caching
7216 previous display string position. Initialize cached_prev_pos to
7217 -1. Fixes slow-down at the beginning of a buffer.
7219 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7221 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7222 for attrs[LFACE_FONTSET_INDEX].
7224 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7226 * xml.c (parse_region): Remove unused local
7227 that was recently introduced.
7229 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7231 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7232 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7234 * xdisp.c (move_it_in_display_line_to): Record the best matching
7235 position for TO_CHARPOS while scanning the line, and restore it on
7236 exit if none of the characters scanned was an exact match.
7237 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7238 when exact match is impossible due to invisible text, and the
7239 lines are truncated.
7241 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7243 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7246 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7248 Fix a significant slow-down of cursor motion with C-n, C-p,
7249 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7250 auto-repeat under bidi redisplay in fontified buffers.
7251 * xdisp.c (compute_stop_pos_backwards): New function.
7252 (next_element_from_buffer): Call compute_stop_pos_backwards to
7253 find a suitable prev_stop when we find ourselves before
7255 (reseat): Don't look for prev_stop, as that could mean a very long
7257 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7258 <cached_disp_overlay_modiff>: Cache for last found display string
7260 (compute_display_string_pos): Return the cached position if asked
7261 about the same buffer in the same area of character positions, and
7262 the buffer wasn't changed since the time the display string
7263 position was cached.
7265 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7267 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7268 is an integer, which is important for empty lines. (Bug#9149)
7270 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7272 * frame.c (Fmodify_frame_parameters): In tty case, update the
7273 default face if necessary (Bug#4238).
7275 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7277 * editfns.c (Fstring_to_char): No need to explain what a character
7278 is in the docstring (Bug#6576).
7280 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7282 * xml.c (parse_region): Make sure we always return a tree.
7284 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7286 * xml.c (parse_region): If a document contains only comments,
7289 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7291 * xml.c (make_dom): Return comments, too.
7293 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7296 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7297 and the surrounding thread.
7298 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7299 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7300 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7302 * s/openbsd.h (BROKEN_SIGIO): Define.
7303 * unexelf.c (unexec) [__OpenBSD__]:
7304 Don't update the .mdebug section of the Alpha COFF symbol table.
7306 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7308 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7311 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7313 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7314 This fixes some race conditions on the permissions of any newly
7317 * alloc.c (valid_pointer_p): Use pipe, not open.
7318 This fixes some permissions issues when debugging.
7320 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7321 If fchown fails to set both uid and gid, try to set just gid,
7322 as that is sometimes allowed. Adjust the file's mode to eliminate
7323 setuid or setgid bits that are inappropriate if fchown fails.
7325 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7327 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7328 to compare Lisp_Objects.
7329 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7330 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7331 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7333 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7335 * lread.c (read_integer): Unread even EOF character.
7336 (read1): Likewise. Properly record start position of symbol.
7338 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7339 symbol character follows.
7341 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7343 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7344 This works around a problem with the previous change to Fcopy_file.
7345 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7346 and without this change, GCC might complain about discarding
7347 fchown's return value.
7349 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7351 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7353 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7355 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7357 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7359 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7360 it's used from the C level.
7362 * process.c: Use the same condition for POLL_FOR_INPUT in both
7363 keyboard.c and process.c (bug#1858).
7365 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7367 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7368 (Fgnutls_boot): Use it.
7370 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7372 * doc.c (Fsubstitute_command_keys): Revert last change.
7374 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7376 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7377 quotes the next character, and doesn't affect other longer
7378 sequences (bug#8935).
7380 * lread.c (syms_of_lread): Clarify that is isn't only
7381 `eval-buffer' and `eval-defun' that's affected by
7382 `lexical-binding' (bug#8460).
7384 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7386 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7387 bidi redisplay when a line includes both an image and is truncated.
7389 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7391 Fix minor problems found by static checking.
7392 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7393 (elsz): Now a signed constant, not a size_t var. We prefer signed
7394 types to unsigned, to avoid integer comparison confusion. Without
7395 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7396 "cannot optimize loop, the loop counter may overflow", a symptom
7398 * indent.c (Fvertical_motion): Mark locals as initialized.
7399 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7401 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7403 * search.c (Fre_search_backward): Mention `case-fold-search' in
7404 all the re_search_* functions (bug#8138).
7406 * keyboard.c (Fopen_dribble_file): Document when the file is
7409 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7411 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7414 Support bidi reordering of display and overlay strings.
7415 * xdisp.c (compute_display_string_pos)
7416 (compute_display_string_end): Accept additional argument STRING.
7417 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7418 (reseat_to_string): Initialize bidi_it->string.s and
7419 bidi_it->string.schars.
7420 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7421 NULL (avoids a crash in bidi_paragraph_init).
7422 Initialize itb.string.lstring.
7423 (init_iterator): Call bidi_init_it only of a valid
7424 buffer position was specified. Initialize paragraph_embedding to
7426 (reseat_to_string): Initialize the bidi iterator.
7427 (display_string): If we need to ignore text properties of
7428 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7429 original value of -1 will not work with bidi.)
7430 (compute_display_string_pos): First arg is now struct
7431 `text_pos *'; all callers changed. Support display properties on
7433 (compute_display_string_end): Support display properties on Lisp
7435 (init_iterator, reseat_1, reseat_to_string): Initialize the
7436 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7437 when iterating on a string not from display properties).
7438 (compute_display_string_pos, compute_display_string_end):
7439 Fix calculation of the object to scan. Fixes an error when using
7441 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7442 base_level_stop; instead, set base_level_stop to BEGV.
7443 Fixes crashes in vertical-motion.
7444 (next_element_from_buffer): Improve commentary for when
7445 the iterator is before prev_stop.
7446 (init_iterator): Initialize bidi_p from the default value of
7447 bidi-display-reordering, not from buffer-local value. Use the
7448 buffer-local value only if initializing for buffer iteration.
7449 (handle_invisible_prop): Support invisible properties on strings
7450 that are being bidi-reordered.
7451 (set_iterator_to_next): Support bidi reordering of C strings and
7453 (next_element_from_string): Support bidi reordering of Lisp
7455 (handle_stop_backwards): Support Lisp strings as well.
7456 (display_string): Support display of R2L glyph rows.
7457 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7458 (init_iterator): Don't initialize it->bidi_p for strings
7460 (reseat_to_string): Initialize it->bidi_p for strings here.
7461 (next_element_from_string, next_element_from_c_string)
7462 (next_element_from_buffer): Add xassert's for correspondence
7463 between IT's object being iterated and it->bidi_it.string
7465 (face_before_or_after_it_pos): Support bidi iteration.
7466 (next_element_from_c_string): Handle the case of the first string
7467 character that is not the first one in the visual order.
7468 (get_visually_first_element): New function, refactored from common
7469 parts of next_element_from_buffer, next_element_from_string, and
7470 next_element_from_c_string.
7471 (tool_bar_lines_needed, redisplay_tool_bar)
7472 (display_menu_bar): Force left-to-right direction. Add a FIXME
7473 comment for making that be controlled by a user option.
7474 (push_it, pop_it): Save and restore the state of the
7475 bidi iterator. Save and restore the bidi_p flag.
7476 (pop_it): Iterate out of display property for string iteration as
7478 (iterate_out_of_display_property): Support iteration over strings.
7479 (handle_single_display_spec): Set up it->bidi_it for iteration
7480 over a display string, and call bidi_init_it.
7481 (handle_single_display_spec, next_overlay_string)
7482 (get_overlay_strings_1, push_display_prop): Set up the bidi
7483 iterator for displaying display or overlay strings.
7484 (forward_to_next_line_start): Don't use the shortcut if
7486 (back_to_previous_visible_line_start): If handle_display_prop
7487 pushed the iterator stack, restore the internal state of the bidi
7488 iterator by calling bidi_pop_it same number of times.
7489 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7490 and we are bidi-iterating, don't decrement the iterator position;
7491 instead, set the first_elt flag in the bidi iterator, to produce
7493 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7494 (push_display_prop): xassert that we are iterating a buffer.
7495 (push_it, pop_it): Save and restore paragraph_embedding member.
7496 (handle_single_display_spec, next_overlay_string)
7497 (get_overlay_strings_1, reseat_1, reseat_to_string)
7498 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7499 correctly. Don't assume unibyte strings are not bidi-reordered.
7500 (compute_display_string_pos)
7501 (compute_display_string_end): Fix handling the case of C string.
7502 (push_it, pop_it): Save and restore from_disp_prop_p.
7503 (handle_single_display_spec, push_display_prop): Set the
7504 from_disp_prop_p flag.
7505 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7506 (pop_it): Call iterate_out_of_display_property only if we are
7507 popping after iteration over a string that came from a display
7508 property. Fix a typo in popping stretch info. Add an assertion
7509 for verifying that the iterator position is in sync with the bidi
7511 (handle_single_display_spec, get_overlay_strings_1)
7512 (push_display_prop): Fix initialization of paragraph direction for
7513 string when that of the parent object is not yet determined.
7514 (reseat_1): Call bidi_init_it to resync the bidi
7515 iterator with IT's position. (Bug#7616)
7516 (find_row_edges): If ROW->start.pos gives position
7517 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7518 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7519 Reset the from_disp_prop_p flag.
7520 (SAVE_IT, RESTORE_IT): New macros.
7521 (pos_visible_p, face_before_or_after_it_pos)
7522 (back_to_previous_visible_line_start)
7523 (move_it_in_display_line_to, move_it_in_display_line)
7524 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7525 (try_scrolling, redisplay_window, display_line): Use them when
7526 saving a temporary copy of the iterator and restoring it back.
7527 (back_to_previous_visible_line_start, reseat_1)
7528 (init_iterator): Empty the bidi cache "stack".
7529 (move_it_in_display_line_to): If iterator ended up at
7530 EOL, but we never saw any buffer positions smaller than
7531 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7532 motion in bidi-reordered lines.
7533 (move_it_in_display_line_to): Record prev_method and prev_pos
7534 immediately before the call to set_iterator_to_next. Fixes cursor
7535 motion in bidi-reordered lines with stretch glyphs and strings
7536 displayed in margins. (Bug#8133) (Bug#8867)
7537 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7539 (pos_visible_p): Support positions in bidi-reordered lines.
7540 Save and restore bidi cache.
7542 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7543 (bidi_paragraph_info): Delete unused struct.
7544 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7545 (bidi_cache_start): New variable.
7546 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7548 (bidi_cache_fetch_state, bidi_cache_search)
7549 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7550 (bidi_cache_find, bidi_peek_at_next_level)
7551 (bidi_level_of_next_char, bidi_find_other_level_edge)
7552 (bidi_move_to_visually_next): Compare cache index with
7553 bidi_cache_start rather than with zero.
7554 (bidi_fetch_char): Accept new argument STRING; all callers
7555 changed. Support iteration over a string. Support strings with
7556 display properties. Support unibyte strings. Fix the type of
7557 `len' according to what STRING_CHAR_AND_LENGTH expects.
7558 (bidi_paragraph_init, bidi_resolve_explicit_1)
7559 (bidi_resolve_explicit, bidi_resolve_weak)
7560 (bidi_level_of_next_char, bidi_move_to_visually_next):
7561 Support iteration over a string.
7562 (bidi_set_sor_type, bidi_resolve_explicit_1)
7563 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7564 can now be zero (for strings); special values 0 and -1 were
7565 changed to -1 and -2, respectively.
7566 (bidi_char_at_pos): New function.
7567 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7568 Call it instead of FETCH_MULTIBYTE_CHAR.
7569 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7570 initialized to valid values.
7571 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7573 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7574 the test for valid cached positions. Fix the logic for looking up
7575 the sentinel state in the cache. GCPRO the Lisp string we are
7577 (bidi_push_it, bidi_pop_it): New functions.
7578 (bidi_initialize): Initialize the bidi cache start stack pointer.
7579 (bidi_cache_ensure_space): New function, refactored from part of
7580 bidi_cache_iterator_state. Don't assume the required size is just
7581 one BIDI_CACHE_CHUNK away.
7582 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7583 (bidi_count_bytes, bidi_char_at_pos): New functions.
7584 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7585 always valid if bidi_cache_idx is valid.
7586 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7587 is valid if it's going to be used.
7588 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7589 (bidi_cache_fetch_state, bidi_cache_search)
7590 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7591 (bidi_cache_iterator_state, bidi_cache_find)
7592 (bidi_find_other_level_edge, bidi_cache_start_stack):
7593 All variables related to cache indices are now EMACS_INT.
7595 * dispextern.h (struct bidi_string_data): New structure.
7596 (struct bidi_it): New member `string'. Make flag members be 1-bit
7597 fields, and put them last in the struct.
7598 (compute_display_string_pos, compute_display_string_end):
7600 (bidi_push_it, bidi_pop_it): Add prototypes.
7601 (struct iterator_stack_entry): New members bidi_p,
7602 paragraph_embedding, and from_disp_prop_p.
7603 (struct it): Member bidi_p is now a bit field 1 bit wide.
7604 (bidi_shelve_cache, bidi_unshelve_cache):
7607 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7608 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7609 and vector-like objects.
7611 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7612 cache around display iteration.
7614 * window.c (Fwindow_end, window_scroll_pixel_based)
7615 (displayed_window_lines, Frecenter): Save and restore the bidi
7616 cache around display iteration.
7618 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7620 * editfns.c (Fdelete_region): Clarify the use of the named
7621 parameters (bug#6788).
7623 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7625 * indent.c (Fvertical_motion): Set and restore w->pointm when
7626 saving and restoring the window's buffer (Bug#9006).
7628 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7630 * editfns.c (Fstring_to_char): Clarify just what is returned
7631 (bug#6576). Text by Eli Zaretskii.
7633 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7635 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7637 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7639 * buffer.c (mmap_find): Fix a typo.
7641 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7643 Fix execution of x selection hooks.
7644 * xselect.c (Qx_lost_selection_functions)
7645 (Qx_sent_selection_functions): New vars.
7646 (syms_of_xselect): DEFSYM them.
7647 (x_handle_selection_request): Pass Qx_sent_selection_functions
7648 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7649 (x_handle_selection_clear,x_clear_frame_selections):
7650 Pass Qx_lost_selection_functions rather than
7651 Vx_lost_selection_functions to Frun_hook_with_args.
7653 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7655 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7656 The old code sometimes used this field without initializing it.
7658 * alloc.c (gc_sweep): Don't read past end of array.
7659 In theory, the old code could also have corrupted Emacs internals,
7660 though it'd be very unlikely.
7662 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7664 * character.c (Fcharacterp): Don't advertise optional ignored
7665 argument. (Bug#4026)
7667 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7669 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7672 * window.c (Fset_window_start): Doc fix (bug#4199).
7673 (Fset_window_hscroll): Ditto.
7675 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7677 Fix minor new problems caught by GCC 4.6.1.
7678 * term.c (init_tty): Remove unused local.
7679 * xsettings.c (store_monospaced_changed): Define this function only
7680 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7683 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7685 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7687 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7689 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7690 are the mini-buffer and the echo area (bug#3320).
7692 * term.c (init_tty): Remove support for supdup, c10 and perq
7693 terminals, which are no longer supported (bug#1482).
7695 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7697 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7699 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7701 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7702 for non-popups (Bug#3642).
7704 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7706 * alloc.c (reset_malloc_hooks): Protoize.
7707 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7708 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7709 * cm.c (losecursor): Likewise.
7710 * data.c (fmod): Likewise.
7711 * dispnew.c (swap_glyphs_in_rows): Likewise.
7712 * emacs.c (memory_warning_signal): Likewise.
7713 * floatfns.c (float_error): Likewise.
7714 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7715 (otf_open, font_otf_capability, generate_otf_features)
7716 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7718 * image.c (pbm_read_file): Likewise.
7719 * indent.c (string_display_width): Likewise.
7720 * intervals.c (check_for_interval, search_for_interval)
7721 (inc_interval_count, count_intervals, root_interval)
7722 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7723 * lread.c (defalias): Likewise.
7724 * ralloc.c (r_alloc_check): Likewise.
7725 * regex.c (set_image_of_range_1, set_image_of_range)
7726 (regex_grow_registers): Likewise.
7727 * sysdep.c (strerror): Likewise.
7728 * termcap.c (valid_filename_p, tprint, main): Likewise.
7729 * tparam.c (main): Likewise.
7730 * unexhp9k800.c (run_time_remap, save_data_space)
7731 (update_file_ptrs, read_header, write_header, calculate_checksum)
7732 (copy_file, copy_rest, display_header): Likewise.
7733 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7735 * xdisp.c (check_it): Likewise.
7736 * xfaces.c (register_color, unregister_color, unregister_colors):
7738 * xfns.c (print_fontset_result): Likewise.
7739 * xrdb.c (member, fatal, main): Likewise.
7741 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7743 Fix minor problems found by static checking (Bug#9031).
7744 * chartab.c (char_table_set_range, map_sub_char_table):
7745 Remove unused locals.
7746 (uniprop_table): Now static.
7747 * composite.c (_work_char): Remove unused static var.
7749 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7751 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7753 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7755 * gtkutil.c (qttip_cb): Remove code without function.
7757 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7759 * w32.c (pthread_sigmask): New stub.
7761 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7763 Use pthread_sigmask, not sigprocmask (Bug#9010).
7764 sigprocmask is portable only for single-threaded applications, and
7765 Emacs can be multi-threaded when it uses GTK.
7766 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7768 * callproc.c (Fcall_process):
7769 * process.c (create_process):
7770 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7771 Use pthread_sigmask, not sigprocmask.
7773 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7775 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7776 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7779 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7781 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7782 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7783 (xg_hide_tooltip): Fix comment.
7785 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7786 in registerServicesMenuSendTypes.
7787 (validRequestorForSendType): Don't check ns_return_types.
7789 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7792 2011-07-08 Jason Rumney <jasonr@gnu.org>
7794 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7795 SH_SHOW for hidden windows (Bug#5482).
7797 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7798 frame struct members of non-existent frames (Bug#6284).
7800 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7802 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7803 variable firstTime not needed on OSX >= 10.6.
7804 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7805 >= 10.5. Use setKnobProportion, setDoubleValue.
7807 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7808 (MAC_OS_X_VERSION_10_5): Define if not defined.
7809 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7810 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7811 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7813 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7814 cString and lossyCString on OSX >= 10.4.
7816 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7817 sizeToFit on OSX >= 10.2.
7819 * nsimage.m (allocInitFromFile): Don't use deprecated method
7820 bestRepresentationForDevice on OSX >= 10.6.
7822 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7825 * emacs.c: Declare unexec_init_emacs_zone.
7827 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7829 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7831 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7832 on svcsMenu (Bug#8842).
7834 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7836 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7838 * nsterm.m (QUTF8_STRING): Declare.
7839 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7840 (validRequestorForSendType): Return type is (id).
7841 Change indexOfObjectIdenticalTo to indexOfObject.
7842 Check if we have local selection before returning self (Bug#8842).
7843 (writeSelectionToPasteboard): Put local selection into paste board
7844 if we have a local selection (Bug#8842).
7845 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7847 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7848 (ns_get_local_selection): Declare.
7850 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7852 * keymap.c (describe_map_tree): Don't insert a double newline at
7853 the end of the buffer (bug#1169) and return whether we inserted
7856 * callint.c (Fcall_interactively): Change "reading args" to
7857 "providing args" to try to clarify what it does (bug#1010).
7859 2011-07-07 Kenichi Handa <handa@m17n.org>
7861 * composite.c (composition_compute_stop_pos): Ignore a static
7862 composition starting before CHARPOS (Bug#8915).
7864 * xdisp.c (handle_composition_prop): Likewise.
7866 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7868 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7871 2011-07-07 Kenichi Handa <handa@m17n.org>
7873 * character.h (unicode_category_t): New enum type.
7875 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7876 (Qchar_code_property_table): New variable.
7877 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7878 (UNIPROP_COMPRESSED_FORM_P): New macros.
7879 (char_table_ascii): Uncompress the compressed values.
7880 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7881 Uncompress the compressed values.
7882 (sub_char_table_ref_and_range): Likewise.
7883 (char_table_ref_and_range): Uncompress the compressed values.
7884 (sub_char_table_set): New arg is_uniprop. Callers changed.
7885 Uncompress the compressed values.
7886 (sub_char_table_set_range): Args changed. Callers changed.
7887 (char_table_set_range): Adjuted for the above change.
7888 (map_sub_char_table): Delete args default_val and parent. Add arg
7889 top. Give decoded values to a Lisp function.
7890 (map_char_table): Adjust for the above change. Give decoded
7891 values to a Lisp function. Gcpro more variables.
7892 (uniprop_table_uncompress)
7893 (uniprop_decode_value_run_length): New functions.
7894 (uniprop_decoder, uniprop_decoder_count): New variables.
7895 (uniprop_get_decoder, uniprop_encode_value_character)
7896 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7898 (uniprop_encoder, uniprop_encoder_count): New variables.
7899 (uniprop_get_encoder, uniprop_table)
7900 (Funicode_property_table_internal, Fget_unicode_property_internal)
7901 (Fput_unicode_property_internal): New functions.
7902 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7903 Sunicode_property_table_internal, Sget_unicode_property_internal,
7904 and Sput_unicode_property_internal. Defvar_lisp
7905 char-code-property-alist.
7907 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7908 Vunicode_category_table.
7910 * font.c (font_range): Adjust for the change of
7911 Vunicode_category_table.
7913 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7915 * m/iris4d.h: Remove file, move contents ...
7916 * s/irix6-5.h: ... here.
7918 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7920 Remove unportable assumption about struct layout (Bug#8884).
7921 * alloc.c (mark_buffer):
7922 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7923 (clone_per_buffer_values): Don't assume that
7924 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7925 This isn't true in general, and it's particularly not true
7926 if Emacs is configured with --with-wide-int.
7927 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7928 New macros, used in the buffer.c change.
7930 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7932 * xsettings.c: Use both GConf and GSettings if both are available.
7933 (store_config_changed_event): Add comment.
7934 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7935 (store_tool_bar_style_changed): New functions.
7936 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7937 (struct xsettings): Move font inside HAVE_XFT.
7938 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7939 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7940 Move inside HAVE_XFT.
7941 (something_changed_gsettingsCB): Rename from something_changedCB.
7942 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7944 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7945 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7946 (something_changed_gconfCB): Rename from something_changedCB.
7947 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7948 (parse_settings): Move check for font inside HAVE_XFT.
7949 (read_settings, apply_xft_settings): Add comment.
7950 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7951 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7952 call store_font_name_changed.
7953 (xft_settings_event): Add comment.
7954 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7955 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7956 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7957 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7958 (xsettings_initialize): Call init_gsettings last.
7959 (xsettings_get_system_font, xsettings_get_system_normal_font):
7962 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7964 Random fixes. E.g., (random) never returned negative values.
7965 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7966 subseconds part to the entropy, as that's a bit more random.
7967 Prefer signed to unsigned, since the signedness doesn't matter and
7968 in general we prefer signed. When given a limit, use a
7969 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7970 latter isn't right if USE_2_TAGS_FOR_INTS.
7971 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7972 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7974 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7976 * textprop.c (text_property_stickiness):
7977 Obey Vtext_property_default_nonsticky.
7978 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7979 * w32fns.c (syms_of_w32fns):
7980 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7982 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7984 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7985 This is more efficient than Ffile_directory_p and avoids a minor race.
7987 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7989 * buffer.c (Foverlay_put): Say what the return value is
7992 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7993 is a directory before asking whether to use the file name
7995 (barf_or_query_if_file_exists): Make the "File is a directory"
7996 error be more correct.
7998 * fns.c (Frequire): Remove the mention of the .gz files, since
7999 that's installation-specific, but keep the mention of
8000 `get-load-suffixes'.
8002 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8004 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8005 Report string overflow if the output is too long.
8007 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8009 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8010 (syms_of_gnutls): Remove duplicate DEFSYM for
8011 Qgnutls_bootprop_verify_hostname_error, an error for
8012 Qgnutls_bootprop_verify_error (which is no longer used).
8014 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8015 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8016 Also (re)move comments that are misplaced or no longer relevant.
8018 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8020 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8022 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8024 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8025 and background color parameters if they have been changed.
8027 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8029 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8031 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8033 * xsettings.c (SYSTEM_FONT): Define only when used.
8034 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8036 * keymap.c (access_keymap_1): Now static.
8038 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8040 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8041 leave any prefix arg for the up event (Bug#1586).
8043 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8045 * lread.c (syms_of_lread): Mention single symbols defined by
8046 `defvar' or `defconst' (bug#7154).
8048 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8049 (Frequire): Mention get-load-suffixes.
8051 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8053 * window.h (window): Remove clone_number slot.
8054 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8056 (make_parent_window, make_window, saved_window)
8057 (Fset_window_configuration, save_window_save): Don't deal with
8059 * buffer.c (Qclone_number): Remove declaration.
8060 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8062 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8064 Add multiple inheritance to keymaps.
8065 * keymap.c (Fmake_composed_keymap): New function.
8066 (Fset_keymap_parent): Simplify.
8067 (fix_submap_inheritance): Remove.
8068 (access_keymap_1): New function extracted from access_keymap to handle
8069 embedded parents and handle lists of maps.
8070 (access_keymap): Use it.
8071 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8072 (Fcopy_keymap): Handle embedded parents.
8073 (Fcommand_remapping, define_as_prefix): Simplify.
8074 (Fkey_binding): Simplify.
8075 (syms_of_keymap): Move minibuffer-local-completion-map,
8076 minibuffer-local-filename-completion-map,
8077 minibuffer-local-must-match-map, and
8078 minibuffer-local-filename-must-match-map to Elisp.
8079 (syms_of_keymap): Defsubr make-composed-keymap.
8080 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8081 (parse_menu_item): Trivial simplification.
8083 2011-07-01 Glenn Morris <rgm@gnu.org>
8085 * Makefile.in (SETTINGS_LIBS): Fix typo.
8087 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8089 * coding.c (Fencode_coding_string): Record the last coding system
8090 used, as the function doc string says (bug#8738).
8092 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8094 * xsettings.c (store_monospaced_changed): Take new font as arg and
8095 check for change against current_mono_font.
8096 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8097 (emacs_settings_constructor, emacs_settings_get_property)
8098 (emacs_settings_set_property, emacs_settings_class_init)
8099 (emacs_settings_init, gsettings_obj): Remove.
8100 (something_changedCB): New function for HAVE_GSETTINGS.
8101 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8102 with value as argument.
8103 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8104 g_settings_new (Bug#8967). Do not create gsettings_obj.
8105 Remove calls to g_settings_bind. Connect something_changedCB to
8108 * xgselect.c: Add defined (HAVE_GSETTINGS).
8109 (xgselect_initialize): Ditto.
8111 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8112 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8115 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8117 * eval.c (struct backtrace): Simplify and port the data structure.
8118 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8119 signed bit field, as this assumption is not portable and it makes
8120 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8121 "char debug_on_exit : 1" as this is not portable either; instead,
8122 use the portable "unsigned int debug_on_exit : 1". Remove unused
8123 member evalargs. Remove obsolete comments about cc bombing out.
8125 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8127 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8128 Let HAVE_GSETTINGS override HAVE_GCONF.
8129 (store_monospaced_changed): New function.
8130 (EMACS_SETTINGS): A new type derived from GObject to handle
8131 GSettings notifications.
8132 (emacs_settings_constructor, emacs_settings_get_property)
8133 (emacs_settings_set_property, emacs_settings_class_init):
8135 (gsettings_client, gsettings_obj): New variables.
8136 (GSETTINGS_SCHEMA): New define.
8137 (something_changedCB): Call store_monospaced_changed.
8138 (init_gsettings): New function.
8139 (xsettings_initialize): Call init_gsettings.
8140 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8143 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8146 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8148 * window.c (resize_root_window, grow_mini_window)
8149 (shrink_mini_window): Rename Qresize_root_window to
8150 Qwindow_resize_root_window and Qresize_root_window_vertically to
8151 Qwindow_resize_root_window_vertically.
8153 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8155 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8157 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8159 * makefile.w32-in: Redesign dependencies so they reflect more
8160 clearly which files are directly included by each source file,
8161 and not through other includes.
8163 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8165 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8166 (sort_overlays, overlay_strings): When an overlay's clone number
8167 matches the window's clone number process the overlay even if
8168 the overlay's window property doesn't match the current window.
8170 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8171 (Fwindow_hchild): Rename to Fwindow_left_child.
8172 (Fwindow_next): Rename to Fwindow_next_sibling.
8173 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8174 (resize_window_check): Rename to window_resize_check.
8175 (resize_window_apply): Rename to window_resize_apply.
8176 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8177 (Fdelete_other_windows_internal, resize_frame_windows)
8178 (Fsplit_window_internal, Fdelete_window_internal)
8179 (grow_mini_window, shrink_mini_window)
8180 (Fresize_mini_window_internal): Fix callers accordingly.
8182 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8184 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8185 (emacs_fixed_set_min_size): Remove.
8186 (emacs_fixed_new): Take frame as argument.
8188 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8189 (_EmacsFixedPrivate): Remove minwidth/height.
8190 Add struct frame *f.
8191 (emacs_fixed_init): Initialize priv->f.
8192 (get_parent_class, emacs_fixed_set_min_size): Remove.
8193 (emacs_fixed_new): Set priv->f to argument.
8194 (emacs_fixed_get_preferred_width)
8195 (emacs_fixed_get_preferred_height): Use min_width/height from
8196 frames size_hint to set minimum and natural (Bug#8919).
8197 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8198 and use min_width/height from frames size_hint to set
8199 min_width/height (Bug#8919).
8201 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8202 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8205 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8207 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8208 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8211 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8213 * process.c (wait_reading_process_output): Bypass select if
8214 waiting for a cell while ignoring keyboard input, and input is
8215 pending. Suggested by Jan Djärv (Bug#8869).
8217 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8219 Use gnulib's dup2 module instead of rolling our own.
8220 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8222 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8224 * dispnew.c (scrolling_window): Before scrolling, turn off a
8225 mouse-highlight in the window being scrolled.
8227 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8229 Move DEFSYM to lisp.h and use everywhere.
8231 * character.h (DEFSYM): Move declaration...
8232 * lisp.h (DEFSYM): ...here.
8238 * w32select.c: Don't include character.h.
8240 * alloc.c (syms_of_alloc):
8241 * buffer.c (syms_of_buffer):
8242 * bytecode.c (syms_of_bytecode):
8243 * callint.c (syms_of_callint):
8244 * casefiddle.c (syms_of_casefiddle):
8245 * casetab.c (init_casetab_once):
8246 * category.c (init_category_once, syms_of_category):
8247 * ccl.c (syms_of_ccl):
8248 * cmds.c (syms_of_cmds):
8249 * composite.c (syms_of_composite):
8250 * dbusbind.c (syms_of_dbusbind):
8251 * dired.c (syms_of_dired):
8252 * dispnew.c (syms_of_display):
8253 * doc.c (syms_of_doc):
8254 * editfns.c (syms_of_editfns):
8255 * emacs.c (syms_of_emacs):
8256 * eval.c (syms_of_eval):
8257 * fileio.c (syms_of_fileio):
8258 * fns.c (syms_of_fns):
8259 * frame.c (syms_of_frame):
8260 * fringe.c (syms_of_fringe):
8261 * insdel.c (syms_of_insdel):
8262 * keymap.c (syms_of_keymap):
8263 * lread.c (init_obarray, syms_of_lread):
8264 * macros.c (syms_of_macros):
8265 * msdos.c (syms_of_msdos):
8266 * print.c (syms_of_print):
8267 * process.c (syms_of_process):
8268 * search.c (syms_of_search):
8269 * sound.c (syms_of_sound):
8270 * syntax.c (init_syntax_once, syms_of_syntax):
8271 * terminal.c (syms_of_terminal):
8272 * textprop.c (syms_of_textprop):
8273 * undo.c (syms_of_undo):
8274 * w32.c (globals_of_w32):
8275 * window.c (syms_of_window):
8276 * xdisp.c (syms_of_xdisp):
8277 * xfaces.c (syms_of_xfaces):
8278 * xfns.c (syms_of_xfns):
8279 * xmenu.c (syms_of_xmenu):
8280 * xsettings.c (syms_of_xsettings):
8281 * xterm.c (syms_of_xterm): Use DEFSYM.
8283 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8285 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8287 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8289 Integer and buffer overflow fixes (Bug#8873).
8291 * print.c (printchar, strout): Check for string overflow.
8292 (PRINTPREPARE, printchar, strout):
8293 Don't set size unless allocation succeeds.
8295 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8296 for sizes. Check for string overflow more accurately.
8297 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8299 * macros.c: Integer and buffer overflow fixes.
8300 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8301 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8302 Use ptrdiff_t, not int, for sizes.
8303 Don't increment bufsize until after realloc succeeds.
8304 Check for size-calculation overflow.
8305 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8307 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8309 * lread.c: Integer overflow fixes.
8310 (read_integer): Radix is now EMACS_INT, not int,
8311 to improve quality of diagnostics for out-of-range radices.
8312 Calculate buffer size correctly for out-of-range radices.
8313 (read1): Check for integer overflow in radices, and in
8314 read-circle numbers.
8315 (read_escape): Avoid int overflow.
8316 (Fload, openp, read_buffer_size, read1)
8317 (substitute_object_recurse, read_vector, read_list, map_obarray):
8318 Use ptrdiff_t, not int, for sizes.
8319 (read1): Use EMACS_INT, not int, for sizes.
8320 Check for size overflow.
8322 * image.c (cache_image): Check for size arithmetic overflow.
8324 * lread.c: Integer overflow issues.
8325 (saved_doc_string_size, saved_doc_string_length)
8326 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8327 Now ptrdiff_t, not int.
8328 (read1): Don't assume doc string length fits in int. Check for
8329 out-of-range doc string lengths.
8330 (read_list): Don't assume file position fits in int.
8331 (read_escape): Check for hex character overflow.
8333 2011-06-22 Leo Liu <sdl.web@gmail.com>
8335 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8336 Move to minibuffer.el.
8338 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8340 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8341 The following patches are for when GLYPH_DEBUG && !XASSERT.
8342 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8343 * dispnew.c (flush_stdout):
8344 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8345 Mark as externally visible.
8346 * dispnew.c (check_window_matrix_pointers): Now static.
8347 * dispnew.c (window_to_frame_vpos):
8348 * xfns.c (unwind_create_frame):
8349 * xterm.c (x_check_font): Remove unused local.
8350 * scroll.c (CHECK_BOUNDS):
8351 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8352 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8353 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8354 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8355 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8357 (debug_method_add): Use va_list and vsprintf rather than relying
8358 on undefined behavior with wrong number of arguments.
8359 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8360 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8361 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8362 since we're not interested in debugging glyphs with old libraries.
8363 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8364 GCC 4.6.0's static checking.
8366 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8368 Integer overflow and signedness fixes (Bug#8873).
8369 A few related buffer overrun fixes, too.
8371 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8373 * dispextern.h (struct face.stipple):
8374 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8375 (x_bitmap_mask, x_allocate_bitmap_record)
8376 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8377 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8378 (x_create_bitmap_from_xpm_data):
8379 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8380 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8382 * xfaces.c (load_pixmap):
8383 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8384 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8385 (.bitmaps_last, struct x_output.icon_bitmap):
8386 Use ptrdiff_t, not int, for bitmap indexes.
8387 (x_allocate_bitmap_record): Check for size overflow.
8388 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8390 Use ptrdiff_t, not int, for overlay counts.
8391 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8392 * editfns.c (overlays_around, get_pos_property):
8393 * textprop.c (get_char_property_and_overlay):
8394 * xdisp.c (next_overlay_change, note_mouse_highlight):
8395 * xfaces.c (face_at_buffer_position):
8396 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8397 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8398 (Fnext_overlay_change, Fprevious_overlay_change)
8399 (mouse_face_overlay_overlaps, Foverlays_in):
8400 Use ptrdiff_t, not int, for sizes.
8401 (overlays_at, overlays_in): Check for size-calculation overflow.
8403 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8405 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8406 (x_session_initialize): Do not assume string length fits in int.
8408 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8409 This is unlikely, but can occur if DPI is outlandish.
8411 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8412 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8414 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8415 * xrdb.c (magic_file_p, search_magic_path):
8416 Omit last arg SUFFIX; it was always 0. All callers changed.
8417 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8419 * xfont.c (xfont_match): Avoid need for strlen.
8421 * xfns.c: Don't assume strlen fits in int.
8422 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8424 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8425 not unsigned long, as we prefer signed integers. All callers changed.
8426 Detect integer overflow in repeat count.
8427 (message_dolog): Don't assume print length fits in 39 bytes.
8428 (display_mode_element): Don't assume strlen fits in int.
8430 * termcap.c: Don't assume sizes fit in int and never overflow.
8431 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8432 (gobble_line): Check for size-calculation overflow.
8434 * minibuf.c (Fread_buffer):
8435 * lread.c (intern, intern_c_string):
8436 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8437 Don't assume string length fits in int.
8439 * keyboard.c (parse_tool_bar_item):
8440 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8442 * font.c: Don't assume string length fits in int.
8443 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8444 Use ptrdiff_t, not int.
8445 (font_intern_prop): Don't assume string length fits in int.
8446 Don't assume integer property fits in fixnum.
8447 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8449 * filelock.c: Fix some buffer overrun and integer overflow issues.
8450 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8451 Reformulate so as not to need the command string.
8452 Invoke gzip -cd rather than gunzip, as it's more portable.
8453 (lock_info_type, lock_file_1, lock_file):
8454 Don't assume pid_t and time_t fit in unsigned long.
8455 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8456 (current_lock_owner): Prefer signed type for sizes.
8457 Use memcpy, not strncpy, where memcpy is what is really wanted.
8458 Don't assume (via atoi) that time_t and pid_t fit in int.
8459 Check for time_t and/or pid_t out of range, e.g., via a network share.
8460 Don't alloca where an auto var works fine.
8462 * fileio.c: Fix some integer overflow issues.
8463 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8464 Don't assume string length fits in int.
8465 (directory_file_name): Don't assume string length fits in long.
8466 (make_temp_name): Don't assume pid fits in int, or that its print
8467 length is less than 20.
8469 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8471 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8473 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8475 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8476 We prefer signed integers, even for size calculations.
8478 * emacs.c: Don't assume string length fits in 'int'.
8479 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8480 (main): Don't invoke strlen when not needed.
8482 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8483 (XD_DEBUG_MESSAGE): Don't waste a byte.
8485 * callproc.c (getenv_internal_1, getenv_internal)
8487 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8489 * lread.c (invalid_syntax): Omit length argument.
8490 All uses changed. This doesn't fix a bug, but it simplifies the
8491 code away from its former Hollerith-constant appearance, and it's
8492 one less 'int' to worry about when looking at integer-overflow issues.
8493 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8495 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8496 This didn't break anything, but it didn't help either.
8497 It's confusing to put a bogus integer in a place where the actual
8498 value does not matter.
8499 (LIST_END_P): Remove unused macro and its bogus comment.
8500 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8502 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8503 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8505 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8506 We prefer signed types, and the value cannot exceed the EMACS_INT
8507 range anyway (because otherwise the length would not be representable).
8508 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8509 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8510 This avoids a GCC warning when WIDE_EMACS_INT.
8512 * indent.c (sane_tab_width): New function.
8513 (current_column, scan_for_column, Findent_to, position_indentation)
8514 (compute_motion): Use it. This is just for clarity.
8515 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8517 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8519 * lisp.h (lint_assume): New macro.
8520 * composite.c (composition_gstring_put_cache):
8521 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8523 * editfns.c, insdel.c:
8524 Omit unnecessary forward decls, to simplify future changes.
8526 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8528 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8530 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8531 Use much-faster test for byte-length change.
8532 Don't assume string byte-length fits in 'int'.
8533 Check that character arg fits in 'int'.
8534 (mapcar1): Declare byte as byte, for clarity.
8536 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8538 * fns.c (concat): Catch string overflow earlier.
8539 Do not rely on integer wraparound.
8541 * dispextern.h (struct it.overlay_strings_charpos)
8542 (struct it.selective): Now EMACS_INT, not int.
8543 * xdisp.c (forward_to_next_line_start)
8544 (back_to_previous_visible_line_start)
8545 (reseat_at_next_visible_line_start, next_element_from_buffer):
8546 Don't arbitrarily truncate the value of 'selective' to int.
8548 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8550 * composite.c: Don't truncate sizes to 'int'.
8551 (composition_gstring_p, composition_reseat_it)
8552 (composition_adjust_point): Use EMACS_INT, not int.
8553 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8554 not EMACS_UINT, for indexes.
8556 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8558 * buffer.c: Include <verify.h>.
8559 (struct sortvec.priority, struct sortstr.priority):
8560 Now EMACS_INT, not int.
8561 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8562 (struct sortstr.size, record_overlay_string)
8563 (struct sortstrlist.size, struct sortlist.used):
8564 Don't truncate size to int.
8565 (record_overlay_string): Check for size-calculation overflow.
8566 (init_buffer_once): Check at compile-time, not run-time.
8568 2011-06-22 Jim Meyering <meyering@redhat.com>
8570 Don't leak an XBM-image-sized buffer
8571 * image.c (xbm_load): Free the image buffer after using it.
8573 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8576 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8577 that Sun C diagnosed.
8578 * fns.c (secure_hash): Fix pointer signedness issue.
8579 * intervals.c (static_offset_intervals): New function.
8580 (offset_intervals): Use it.
8582 2011-06-21 Leo Liu <sdl.web@gmail.com>
8585 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8588 * fns.c (secure_hash): Rename from crypto_hash_function and change
8589 the first arg to accept symbols.
8590 (Fsecure_hash): New primitive.
8591 (syms_of_fns): New symbols.
8593 2011-06-20 Deniz Dogan <deniz@dogan.se>
8595 * process.c (Fset_process_buffer): Clarify return value in
8598 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8600 * dispnew.c (add_window_display_history): Use BVAR.
8602 * xdisp.c (debug_method_add): Use BVAR.
8603 (check_window_end, dump_glyph_matrix, dump_glyph)
8604 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8606 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8609 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8610 check till after the cache is created in init_frame_faces.
8612 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8614 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8616 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8618 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8619 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8620 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8622 Improve buffer-overflow checking (Bug#8873).
8623 * fileio.c (Finsert_file_contents):
8624 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8625 Remove the old (too-loose) buffer overflow checks.
8626 They weren't needed, since make_gap checks for buffer overflow.
8627 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8628 The old code merely checked for Emacs fixnum overflow, and relied
8629 on undefined (wraparound) behavior. The new code avoids undefined
8630 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8632 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8633 Tune. Don't use wider integers than needed. Don't use alloca.
8634 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8636 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8638 * insdel.c, lisp.h (buffer_overflow): New function.
8639 (insert_from_buffer_1, replace_range, replace_range_2):
8640 * insdel.c (make_gap_larger):
8641 * editfns.c (Finsert_char):
8642 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8644 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8646 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8648 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8650 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8651 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8653 * fileio.c: Don't assume EMACS_INT fits in off_t.
8654 (emacs_lseek): New static function.
8655 (Finsert_file_contents, Fwrite_region): Use it.
8656 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8658 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8660 * fns.c: Don't overflow int when computing a list length.
8661 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8662 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8663 truncation on 64-bit hosts. Check for QUIT every
8664 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8665 faster and is responsive enough.
8666 (Flength): Report an error instead of overflowing an integer.
8667 (Fsafe_length): Return a float if the value is not representable
8668 as a fixnum. This shouldn't happen except in contrived situations.
8669 (Fnthcdr, Fsort): Don't assume list length fits in int.
8670 (Fcopy_sequence): Don't assume vector length fits in int.
8672 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8673 (header_size, word_size): New constants.
8674 (allocate_vectorlike): Don't check size overflow here.
8675 (allocate_vector): Check it here instead, since this is the only
8676 caller of allocate_vectorlike that could cause overflow.
8677 Check that the new vector's length is representable as a fixnum.
8679 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8680 The previous code was bogus. For example, next_almost_prime (32)
8681 returned 39, which is undesirable as it is a multiple of 3; and
8682 next_almost_prime (24) returned 25, which is a multiple of 5 so
8683 why was the code bothering to check for multiples of 7?
8685 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8687 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8689 Variadic C functions now count arguments with ptrdiff_t.
8690 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8691 Back then I didn't know that the Emacs coding style prefers signed int.
8692 Also, in the meantime I found a few more instances where arguments
8693 were being counted with int, which may truncate counts on 64-bit
8694 machines, or EMACS_INT, which may be unnecessarily wide.
8695 * lisp.h (struct Lisp_Subr.function.aMANY)
8696 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8697 Arg counts are now ptrdiff_t, not size_t.
8698 All variadic functions and their callers changed accordingly.
8699 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8700 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8701 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8702 * callint.c (Fcall_interactively): Check arg count for overflow,
8703 to avoid potential buffer overrun. Use signed char, not 'int',
8704 for 'varies' array, so that we needn't bother to check its size
8705 calculation for overflow.
8706 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8707 * eval.c (apply_lambda):
8708 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8709 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8710 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8712 * callint.c (Fcall_interactively): Don't use index var as event count.
8714 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8715 * mem-limits.h (SIZE): Remove; no longer used.
8717 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8719 Remove unnecessary casts.
8720 * xterm.c (x_term_init):
8721 * xfns.c (x_set_border_pixel):
8722 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8723 These aren't needed now that we assume ANSI C.
8725 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8726 It's more likely to cause problems (due to unsigned overflow)
8729 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8731 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8733 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8735 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8737 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8739 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8741 GLYPH_CODE_FACE returns EMACS_INT, not int.
8742 * dispextern.h (merge_faces):
8743 * xfaces.c (merge_faces):
8744 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8745 Don't assume EMACS_INT fits in int.
8747 * character.h (CHAR_VALID_P): Remove unused parameter.
8748 * fontset.c, lisp.h, xdisp.c: All uses changed.
8750 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8752 * fns.c (concat): Minor tuning based on overflow analysis.
8753 This doesn't fix any bugs. Use int to hold character, instead
8754 of constantly refetching from Emacs object. Use XFASTINT, not
8755 XINT, for value known to be a character. Don't bother comparing
8756 a single byte to 0400, as it's always less.
8758 * floatfns.c (Fexpt):
8759 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8761 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8764 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8766 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8767 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8768 incorrectly succeed when S was a string, because 4294967386 was
8769 truncated before it was used.
8771 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8772 Otherwise, an out-of-range integer could cause undefined behavior
8775 * composite.c: Use int, not EMACS_INT, for characters.
8776 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8777 EMACS_INT, for values that are known to be in character range.
8778 This doesn't fix any bugs but is the usual style inside Emacs and
8779 may generate better code on 32-bit machines.
8781 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8782 This is for reasons similar to the recent CHAR_STRING fix.
8783 * charset.c (Fencode_char): Check that character arg is actually
8784 a character. Pass an int to ENCODE_CHAR.
8785 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8786 wider than 'int', as a compile-time check to prevent future regressions
8789 * character.c (char_string): Remove unnecessary casts.
8791 Make sure a 64-bit char is never passed to CHAR_STRING.
8792 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8793 by silently ignoring the top 32 bits, allowing some values
8794 that were far too large to be valid characters.
8795 * character.h: Include <verify.h>.
8796 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8797 arguments are no wider than unsigned, as a compile-time check
8798 to prevent future regressions in this area.
8800 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8801 (Fsubst_char_in_region):
8803 * xdisp.c (decode_mode_spec_coding):
8804 Adjust to CHAR_STRING's new requirement.
8805 * editfns.c (Finsert_char, Fsubst_char_in_region):
8806 * fns.c (concat): Check that character args are actually
8807 characters. Without this test, these functions did the wrong
8808 thing with wildly out-of-range values on 64-bit hosts.
8810 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8811 These casts should not be needed on 32-bit hosts, either.
8812 * keyboard.c (read_char):
8813 * lread.c (Fload): Remove casts to unsigned.
8815 * lisp.h (UNSIGNED_CMP): New macro.
8816 This fixes comparison bugs on 64-bit hosts.
8817 (ASCII_CHAR_P): Use it.
8818 * casefiddle.c (casify_object):
8819 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8820 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8821 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8822 * dispextern.h (FACE_FROM_ID):
8823 * keyboard.c (read_char): Use UNSIGNED_CMP.
8825 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8826 not to EMACS_INT, to avoid GCC warning.
8828 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8830 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8831 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8832 isn't needed on 32-bit machines.
8834 * buffer.c (Fgenerate_new_buffer_name):
8835 Use EMACS_INT for count, not int.
8836 (advance_to_char_boundary): Return EMACS_INT, not int.
8838 * data.c (Qcompiled_function): Now static.
8840 * window.c (window_body_lines): Now static.
8842 * image.c (gif_load): Rename local to avoid shadowing.
8844 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8845 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8846 * alloc.c (make_save_value): Integer argument is now of type
8848 (mark_object): Use ptrdiff_t, not int.
8849 * lisp.h (pD): New macro.
8850 * print.c (print_object): Use it.
8852 * alloc.c: Use EMACS_INT, not int, to count objects.
8853 (total_conses, total_markers, total_symbols, total_vector_size)
8854 (total_free_conses, total_free_markers, total_free_symbols)
8855 (total_free_floats, total_floats, total_free_intervals)
8856 (total_intervals, total_strings, total_free_strings):
8857 Now EMACS_INT, not int. All uses changed.
8858 (Fgarbage_collect): Compute overall total using a double, so that
8859 integer overflow is less likely to be a problem. Check for overflow
8860 when converting back to an integer.
8861 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8862 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8863 These were 'int' variables that could overflow on 64-bit hosts;
8864 they were never used, so remove them instead of repairing them.
8865 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8866 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8867 Previously, this ceilinged at INT_MAX, but that doesn't work on
8869 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8871 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8872 (allocate_vectorlike): Check for ptrdiff_t overflow.
8873 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8874 when a (possibly-narrower) signed value would do just as well.
8875 We prefer using signed arithmetic, to avoid comparison confusion.
8877 * alloc.c: Catch some string size overflows that we were missing.
8878 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8879 for convenience in STRING_BYTES_MAX.
8880 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8881 The definition here is exact; the one in lisp.h was approximate.
8882 (allocate_string_data): Check for string overflow. This catches
8883 some instances we weren't catching before. Also, it catches
8884 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8885 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8886 and ptrdiff_t and EMACS_INT are both 64 bits.
8888 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8889 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8890 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8892 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8894 * alloc.c (Fmake_string): Check for out-of-range init.
8896 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8898 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8900 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8902 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8903 xg_get_default_scrollbar_width.
8905 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8906 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8907 (style_changed_cb): Call update_theme_scrollbar_width and call
8908 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8909 all frames (Bug#8505).
8910 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8911 Call gtk_window_set_resizable if HAVE_GTK3.
8912 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8913 and height if HAVE_GTK3 (Bug#8505).
8914 (scroll_bar_width_for_theme): New variable.
8915 (update_theme_scrollbar_width): New function.
8916 (xg_get_default_scrollbar_width): Move code to
8917 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8918 (xg_initialize): Call update_theme_scrollbar_width.
8920 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8922 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8924 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8926 * frame.c (make_frame): Call other_buffer_safely instead of
8929 * window.c (temp_output_buffer_show): Call display_buffer with
8930 second argument Vtemp_buffer_show_specifiers and reset latter
8931 immediately after the call.
8932 (Vtemp_buffer_show_specifiers): New variable.
8933 (auto_window_vscroll_p, next_screen_context_lines)
8934 (Vscroll_preserve_screen_position): Remove leading asterisks from
8937 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8939 Fix minor problems found by GCC 4.6.0 static checking.
8940 * buffer.c (Qclone_number): Remove for now, as it's unused.
8941 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8942 (record_buffer): Remove unused local.
8943 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8944 (set_frame_buffer_list): Remove; unused.
8945 * frame.h (other_visible_frames): Remove decl.
8946 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8947 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8948 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8950 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8951 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8952 Define only if HAVE_GPM.
8953 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8954 (update_hints_inhibit): Remove; never set. All uses removed.
8955 * widgetprv.h (emacsFrameClassRec): Remove decl.
8956 * window.c (delete_deletable_window): Now returns void, since it
8957 wasn't returning anything.
8958 (compare_window_configurations): Remove unused locals.
8959 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8960 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8961 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8962 the same widths as pointers. This follows up on the 2011-05-06 patch.
8963 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8964 * xterm.h: Likewise.
8965 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8967 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8969 * makefile.w32-in: Update dependencies.
8970 (LISP_H): Add lib/intprops.h.
8972 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8974 * image.c (gif_load): Add animation frame delay to the metadata.
8975 (syms_of_image): Use DEFSYM. New symbol `delay'.
8977 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8979 * window.c (delete_deletable_window): Re-add.
8980 (Fset_window_configuration): Rewrite to handle dead buffers and
8981 consequently deletable windows.
8982 (window_tree, Fwindow_tree): Remove. Supply functionality in
8984 (compare_window_configurations): Simplify code.
8986 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8988 * image.c (imagemagick_load_image): Fix type mismatch.
8989 (Fimagemagick_types): Likewise.
8991 * window.h (replace_buffer_in_windows): Declare.
8993 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8995 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8996 Qclone_number. Remove external declaration of Qdelete_window.
8997 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8999 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9000 Run Qbuffer_list_update_hook if allowed.
9001 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9002 buffer list implementation.
9003 (other_buffer_safely): New function.
9004 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9005 calls to replace_buffer_in_windows and
9006 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9008 (record_buffer): Inhibit quitting and rewrite using quittable
9009 functions. Run Qbuffer_list_update_hook if allowed.
9010 (Frecord_buffer, Funrecord_buffer): New functions.
9011 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9012 Move switch-to-buffer to window.el.
9013 (bury-buffer): Move to window.el.
9014 (Vbuffer_list_update_hook): New variable.
9016 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9019 * window.h (resize_frame_windows): Move up in code.
9020 (Fwindow_frame): Remove EXFUN.
9021 (replace_buffer_in_all_windows): Remove prototype.
9022 (replace_buffer_in_windows_safely): Add prototype.
9024 * window.c: Declare Qdelete_window static again. Move down
9025 declaration of select_count.
9026 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9027 (Fother_window): Move to window.el.
9028 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9029 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9030 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9032 (replace_buffer_in_windows): Implement by calling
9033 Qreplace_buffer_in_windows.
9034 (replace_buffer_in_all_windows): Remove with some functionality
9035 moved into replace_buffer_in_windows_safely.
9036 (replace_buffer_in_windows_safely): New function.
9037 (select_window_norecord, select_frame_norecord): Move in front
9038 of run_window_configuration_change_hook. Remove now obsolete
9040 (Fset_window_buffer): Rewrite doc-string.
9041 Call Qrecord_window_buffer.
9042 (keys_of_window): Move binding for other-window to window.el.
9044 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9046 * dispextern.h (struct image): Replace data member, whose int_val
9047 and ptr_val fields were not used by anything, with a single
9050 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9051 (gif_clear_image, gif_load, imagemagick_load_image)
9052 (gs_clear_image, gs_load): Callers changed.
9054 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9056 * buffer.h: Include <time.h>, for time_t.
9057 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9059 Fix minor problems found by static checking.
9061 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9063 Make identifiers static if they are not used in other modules.
9064 * data.c (Qcompiled_function, Qframe, Qvector):
9065 * image.c (QimageMagick, Qsvg):
9066 * minibuf.c (Qmetadata):
9067 * window.c (resize_window_check, resize_root_window): Now static.
9068 * window.h (resize_window_check, resize_root_window): Remove decls.
9070 * window.c (window_deletion_count, delete_deletable_window):
9072 (window_body_lines): Now static.
9073 (Fdelete_other_windows_internal): Mark vars as initialized.
9074 Make sure 'resize_failed' is initialized.
9075 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9076 (resize_window_apply): Remove unused local.
9077 * window.h (delete_deletable_window): Remove decl.
9079 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9080 (imagemagick_load_image): Fix pointer signedness problem by changing
9081 last arg from unsigned char * to char *. All uses changed.
9082 Also, fix a local for similar reasons.
9083 Remove unused locals. Remove locals to avoid shadowing.
9084 (fn_rsvg_handle_free): Remove; unused.
9085 (svg_load, svg_load_image): Fix pointer signedness problem.
9086 (imagemagick_load_image): Don't use garbage pointer image_wand.
9088 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9090 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9092 * image.c (gif_load): Fix omitted cast error introduced by
9095 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9097 * window.h (resize_proportionally, orig_total_lines)
9098 (orig_top_line): Remove from window structure.
9099 (set_window_height, set_window_width, change_window_heights)
9100 (Fdelete_window): Remove prototypes.
9101 (resize_frame_windows): Remove duplicate declaration.
9103 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9105 * window.h (resize_frame_windows, resize_window_check)
9106 (delete_deletable_window, resize_root_window)
9107 (resize_frame_windows): Declare prototypes.
9109 * window.c (resize_window_apply): Make definition be "static" to
9110 match the prototype.
9112 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9114 * window.c: Remove declarations of Qwindow_size_fixed,
9115 window_min_size_1, window_min_size_2, window_min_size,
9116 size_window, window_fixed_size_p, enlarge_window, delete_window.
9117 Remove static from declaration of Qdelete_window, it's
9118 temporarily needed by Fbury_buffer.
9119 (replace_window): Don't assign orig_top_line and
9121 (Fdelete_window, delete_window): Remove. Window deletion is
9122 handled by window.el.
9123 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9124 Replace Fdelete_window calls with calls to Qdelete_window.
9125 (Fdelete_other_windows): Remove. Deleting other windows is
9126 handled by window.el.
9127 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9128 handled in window.el.
9129 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9130 Window minimum sizes are handled in window.el.
9131 (shrink_windows, size_window, set_window_height)
9132 (set_window_width, change_window_heights, window_height)
9133 (window_width, CURBEG, CURSIZE, enlarge_window)
9134 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9135 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9136 handled in window.el.
9137 (make_dummy_parent): Rename to make_parent_window and give it a
9138 second argument horflag.
9139 (make_window): Don't set resize_proportionally any more.
9140 (Fsplit_window): Remove. Windows are split in window.el.
9141 (save_restore_action, save_restore_orig_size)
9142 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9143 Resize mini windows in window.el.
9144 (grow_mini_window, shrink_mini_window): Implement by calling
9145 Qresize_root_window_vertically, resize_window_check and
9146 resize_window_apply.
9147 (saved_window, Fset_window_configuration, save_window_save):
9148 Do not handle orig_top_line, orig_total_lines, and
9149 resize_proportionally.
9150 (window_min_height, window_min_width): Move to window.el.
9151 (keys_of_window): Move bindings for delete-other-windows,
9152 split-window, delete-window and enlarge-window to window.el.
9154 * buffer.c: Temporarily extern Qdelete_window.
9155 (Fbury_buffer): Temporarily call Qdelete_window instead of
9156 Fdelete_window (Fbury_buffer will move to window.el soon).
9158 * frame.c (set_menu_bar_lines_1): Remove code handling
9159 orig_top_line and orig_total_lines.
9161 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9162 set_window_height but set heights directly.
9163 (change_frame_size_1): Use resize_frame_windows.
9165 * xdisp.c (init_xdisp): Don't use set_window_height but set
9168 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9169 Use resize_frame_windows instead of change_window_heights and run
9170 run_window_configuration_change_hook.
9172 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9173 instead of change_window_heights and run
9174 run_window_configuration_change_hook.
9176 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9178 * window.c (replace_window): Rename second argument REPLACEMENT to
9179 NEW. New third argument SETFLAG. Rewrite.
9180 (delete_window, make_dummy_parent): Call replace_window with
9182 (window_list_1): Move down in code.
9183 (run_window_configuration_change_hook): Move set_buffer part
9184 before select_frame_norecord part in order to unwind correctly.
9185 Rename count1 to count.
9186 (recombine_windows, delete_deletable_window, resize_root_window)
9187 (Fdelete_other_windows_internal)
9188 (Frun_window_configuration_change_hook, make_parent_window)
9189 (resize_window_check, resize_window_apply, Fresize_window_apply)
9190 (resize_frame_windows, Fsplit_window_internal)
9191 (Fdelete_window_internal, Fresize_mini_window_internal):
9193 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9195 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9197 * window.h (window): Add some new members to window structure -
9198 normal_lines, normal_cols, new_total, new_normal, clone_number,
9199 splits, nest, prev_buffers, next_buffers.
9200 (WINDOW_TOTAL_SIZE): Move here from window.c.
9201 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9203 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9205 (make_dummy_parent): Set new members of windows structure.
9206 (make_window): Move down in code. Handle new members of window
9208 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9209 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9210 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9211 (Fset_window_prev_buffers, Fwindow_next_buffers)
9212 (Fset_window_next_buffers, Fset_window_clone_number):
9214 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9215 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9217 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9218 Argument WINDOW can be now internal window too.
9219 (Fwindow_use_time): Move up in code.
9220 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9222 (Fset_window_configuration, saved_window)
9223 (Fcurrent_window_configuration, save_window_save): Handle new
9224 members of window structure.
9225 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9226 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9227 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9228 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9229 Qget_mru_window, Qresize_root_window,
9230 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9231 Qauto_buffer_name; staticpro them.
9233 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9235 * window.c (Fwindow_total_size, Fwindow_left_column)
9236 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9237 (Fwindow_list_1): New functions.
9238 (window_box_text_cols): Replace with window_body_cols.
9239 (Fwindow_width, Fscroll_left, Fscroll_right):
9240 Use window_body_cols instead of window_box_text_cols.
9241 (delete_window, Fset_window_configuration):
9242 Call delete_all_subwindows with window as argument.
9243 (delete_all_subwindows): Take a window as argument and not a
9245 (window_loop): Remove handling of GET_LRU_WINDOW and
9247 (Fget_lru_window, Fget_largest_window): Move to window.el.
9249 * window.h: Extern window_body_cols instead of
9250 window_box_text_cols. delete_all_subwindows now takes a
9251 Lisp_Object as argument.
9253 * indent.c (compute_motion, Fcompute_motion):
9254 Use window_body_cols instead of window_box_text_cols.
9256 * frame.c (delete_frame): Call delete_all_subwindows with root
9259 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9261 * fns.c (Fputhash): Document return value.
9263 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9265 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9267 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9269 Cons<->int and similar integer overflow fixes (Bug#8794).
9271 Check for overflow when converting integer to cons and back.
9272 * charset.c (Fdefine_charset_internal, Fdecode_char):
9273 Use cons_to_unsigned to catch overflow.
9274 (Fencode_char): Use INTEGER_TO_CONS.
9275 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9276 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9277 * data.c (long_to_cons, cons_to_long): Remove.
9278 (cons_to_unsigned, cons_to_signed): New functions.
9279 These signal an error for invalid or out-of-range values.
9280 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9281 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9282 * font.c (Ffont_variation_glyphs):
9283 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9284 * lisp.h: Include <intprops.h>.
9285 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9286 (cons_to_signed, cons_to_unsigned): New decls.
9287 (long_to_cons, cons_to_long): Remove decls.
9288 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9289 (Fprimitive_undo): Use CONS_TO_INTEGER.
9290 * xfns.c (Fx_window_property): Likewise.
9291 * xselect.c: Include <limits.h>.
9292 (x_own_selection, selection_data_to_lisp_data):
9293 Use INTEGER_TO_CONS.
9294 (x_handle_selection_request, x_handle_selection_clear)
9295 (x_get_foreign_selection, Fx_disown_selection_internal)
9296 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9297 (lisp_data_to_selection_data): Use cons_to_unsigned.
9298 (x_fill_property_data): Use cons_to_signed.
9299 Report values out of range.
9301 Check for buffer and string overflow more precisely.
9302 * buffer.h (BUF_BYTES_MAX): New macro.
9303 * lisp.h (STRING_BYTES_MAX): New macro.
9304 * alloc.c (Fmake_string):
9305 * character.c (string_escape_byte8):
9306 * coding.c (coding_alloc_by_realloc):
9307 * doprnt.c (doprnt):
9308 * editfns.c (Fformat):
9310 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9311 since they may not be the same number.
9312 * editfns.c (Finsert_char):
9313 * fileio.c (Finsert_file_contents):
9314 Likewise for BUF_BYTES_MAX.
9316 * image.c: Use ptrdiff_t, not int, for sizes.
9317 (slurp_file): Switch from int to ptrdiff_t.
9319 (slurp_file): Check that file size fits in both size_t (for
9320 malloc) and ptrdiff_t (for sanity and safety).
9322 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9323 if b->modtime has its maximal value.
9325 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9327 Don't assume time_t can fit into int.
9328 * buffer.h (struct buffer.modtime): Now time_t, not int.
9329 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9330 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9332 Minor fixes for signed vs unsigned integers.
9333 * character.h (MAYBE_UNIFY_CHAR):
9334 * charset.c (maybe_unify_char):
9335 * keyboard.c (read_char, reorder_modifiers):
9336 XINT -> XFASTINT, since the integer must be nonnegative.
9337 * ftfont.c (ftfont_spec_pattern):
9338 * keymap.c (access_keymap, silly_event_symbol_error):
9339 XUINT -> XFASTINT, since the integer must be nonnegative.
9340 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9341 since it makes no difference and we prefer signed.
9342 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9343 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9346 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9348 * window.h (Fwindow_frame): Declare.
9350 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9352 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9353 (SPARE_MEMORY): Always define.
9354 (LARGE_REQUEST): Remove.
9355 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9357 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9359 * lisp.h: Move EXFUNS for Fframe_root_window,
9360 Fframe_first_window and Fset_frame_selected_window to window.h.
9362 * window.h: Move EXFUNS for Fframe_root_window,
9363 Fframe_first_window and Fset_frame_selected_window here from
9366 * frame.c (Fwindow_frame, Fframe_first_window)
9367 (Fframe_root_window, Fframe_selected_window)
9368 (Fset_frame_selected_window): Move to window.c.
9369 (Factive_minibuffer_window): Move to minibuf.c.
9370 (Fother_visible_frames_p): New function.
9372 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9374 * window.c (decode_window, decode_any_window): Move up in code.
9375 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9376 (inhibit_frame_unsplittable): Remove unused variable.
9377 (Fwindow_buffer): Move up and rewrite doc-string.
9378 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9379 (Fwindow_prev): New functions.
9380 (Fwindow_frame): Move here from frame.c. Accept any window as
9382 (Fframe_root_window, Fframe_first_window)
9383 (Fframe_selected_window): Move here from frame.c. Accept frame
9384 or arbitrary window as argument. Update doc-strings.
9385 (Fminibuffer_window): Move up in code.
9386 (Fwindow_minibuffer_p): Move up in code and simplify.
9387 (Fset_frame_selected_window): Move here from frame.c.
9389 (Fselected_window, select_window, Fselect_window): Move up in
9390 code. Minor doc-string fixes.
9392 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9394 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9395 Do not assume that spare memory exists; that assumption is valid
9396 only if SYSTEM_MALLOC.
9397 (LARGE_REQUEST): New macro, so that the issue of large requests
9398 is separated from the issue of spare memory.
9400 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9402 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9405 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9407 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9410 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9412 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9414 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9416 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9417 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9419 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9421 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9423 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9425 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9426 (x_clipboard_manager_save): Add return value.
9427 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9429 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9430 Obey Vx_select_enable_clipboard_manager. Catch errors in
9431 x_clipboard_manager_save (Bug#8779).
9432 (Vx_select_enable_clipboard_manager): New variable.
9433 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9435 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9437 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9439 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9441 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9442 in the current matrix if keep_current_p is non-zero.
9444 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9446 * bidi.c (bidi_level_of_next_char): Fix last change.
9448 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9450 Support bidi reordering of text covered by display properties.
9452 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9453 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9454 (bidi_cache_search, bidi_cache_iterator_state)
9455 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9456 (bidi_level_of_next_char, bidi_move_to_visually_next):
9457 Support character positions inside a run of characters covered by a
9459 (bidi_paragraph_init, bidi_resolve_explicit_1)
9460 (bidi_level_of_next_char): Call bidi_fetch_char and
9461 bidi_fetch_char_advance instead of FETCH_CHAR and
9463 (bidi_init_it): Initialize new members.
9464 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9466 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9467 instead of using explicit *_CHAR codes.
9468 (bidi_resolve_explicit, bidi_resolve_weak):
9469 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9470 bidirectional text is supported only in multibyte buffers.
9471 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9472 it to initialize the frame_window_p member of struct bidi_it.
9473 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9474 (bidi_resolve_explicit, bidi_resolve_weak)
9475 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9476 bidi_it->nchars is non-positive.
9477 (bidi_level_of_next_char): Don't try to lookup the cache for the
9478 next/previous character if nothing is cached there yet, or if we
9479 were just reseat()'ed to a new position.
9481 * xdisp.c (set_cursor_from_row): Set start and stop points
9482 according to the row's direction when priming the loop that looks
9483 for the glyph on which to display cursor.
9484 (single_display_spec_intangible_p): Function deleted.
9485 (display_prop_intangible_p): Reimplement to call
9486 handle_display_spec instead of single_display_spec_intangible_p.
9487 Accept 3 additional arguments needed by handle_display_spec.
9488 This fixes incorrect cursor motion across display property with complex
9489 values: lists, `(when COND...)' forms, etc.
9490 (single_display_spec_string_p): Support property values that are
9491 lists with the argument STRING its top-level element.
9492 (display_prop_string_p): Fix the condition for processing a
9493 property that is a list to be consistent with handle_display_spec.
9494 (handle_display_spec): New function, refactored from the
9495 last portion of handle_display_prop.
9496 (compute_display_string_pos): Accept additional argument
9497 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9498 value of a `display' property is a "replacing spec".
9499 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9500 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9501 the display property, but just return a value indicating whether
9502 the display property will replace the characters it covers.
9503 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9504 frame_window_p members of struct bidi_it.
9505 (compute_display_string_pos, compute_display_string_end):
9507 (push_it): Accept second argument POSITION, where pop_it should
9508 jump to continue iteration.
9509 (reseat_1): Initialize bidi_it.disp_pos.
9511 * keyboard.c (adjust_point_for_property): Adjust the call to
9512 display_prop_intangible_p to its new signature.
9514 * dispextern.h (struct bidi_it): New member frame_window_p.
9515 (bidi_init_it): Update prototypes.
9516 (display_prop_intangible_p): Update prototype.
9517 (compute_display_string_pos, compute_display_string_end):
9519 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9522 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9524 Malloc failure behavior now depends on size of allocation.
9525 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9526 * lisp.h: Change signatures accordingly.
9527 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9528 All callers changed. (Bug#8762)
9530 * gnutls.c: Use Emacs's memory allocators.
9531 Without this change, the gnutls library would invoke malloc etc.
9532 directly, which causes problems on non-SYNC_INPUT hosts, and which
9533 runs afoul of improving memory_full behavior. (Bug#8761)
9534 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9535 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9536 xfree instead of the default malloc, realloc, free.
9537 (Fgnutls_boot): No need to check for memory allocation failure,
9538 since xmalloc does that for us.
9540 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9541 * category.c (hash_get_category_set):
9542 * ccl.c (ccl_driver):
9543 * charset.c (Fdefine_charset_internal):
9544 * charset.h (struct charset.hash_index):
9545 * composite.c (get_composition_id, gstring_lookup_cache)
9546 (composition_gstring_put_cache):
9547 * composite.h (struct composition.hash_index):
9548 * dispextern.h (struct image.hash):
9549 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9550 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9551 (hashfn_equal, hashfn_user_defined, make_hash_table)
9552 (maybe_resize_hash_table, hash_lookup, hash_put)
9553 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9554 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9555 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9556 * image.c (make_image, search_image_cache, lookup_image)
9557 (xpm_put_color_table_h):
9558 * lisp.h (struct Lisp_Hash_Table):
9559 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9560 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9561 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9562 * alloc.c (allocate_vectorlike):
9563 Check for overflow in vector size calculations.
9564 * ccl.c (ccl_driver):
9565 Check for overflow when converting EMACS_INT to int.
9566 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9567 need to be updated by these changes.
9568 * fns.c (make_hash_table, maybe_resize_hash_table):
9569 Check for integer overflow with large hash tables.
9570 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9571 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9572 (SXHASH_REDUCE): New macro.
9573 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9574 Use it instead of discarding useful hash info with large hash values.
9575 (sxhash_float): New function.
9576 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9577 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9578 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9579 Rewrite to use FIXNUM_BITS, as this simplifies things.
9580 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9581 Adjust signatures to match updated version of code.
9582 (consing_since_gc): Now EMACS_INT, since a single hash table can
9583 use more than INT_MAX bytes.
9585 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9587 Make it possible to build with GCC-4.6+ -O2 -flto.
9589 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9591 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9593 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9594 Call minibuffer-inactive-mode.
9596 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9598 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9599 Update dependencies.
9601 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9603 * data.c (init_data): Remove code for UTS, this system is not
9606 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9608 Don't force ./temacs to start in terminal mode.
9610 * frame.c (make_initial_frame): Initialize faces in all cases, not
9611 only when CANNOT_DUMP is defined.
9612 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9614 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9616 * dispnew.c (add_window_display_history): Use const for the string
9617 pointer. Remove declaration, not needed.
9619 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9621 Use 'inline', not 'INLINE'.
9622 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9623 * alloc.c, fontset.c (INLINE): Remove.
9624 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9625 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9626 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9627 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9628 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9630 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9632 Make it possible to run ./temacs.
9634 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9635 syms_of_callproc does the same thing. Remove test for
9636 "initialized", do it in the caller.
9637 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9639 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9641 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9642 (read_minibuf): Use get_minibuffer.
9643 (syms_of_minibuf): Use DEFSYM.
9644 (Qmetadata): New var.
9645 * data.c (Qbuffer): Don't make it static.
9646 (syms_of_data): Use DEFSYM.
9648 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9650 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9651 (CCL_CODE_MIN): New macro.
9653 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9655 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9657 * eval.c (Qdebug): Now static.
9658 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9659 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9660 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9662 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9664 * image.c: Various fixes to ImageMagick code comments.
9665 (Fimagemagick_types): Doc fix.
9667 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9669 Minor fixes prompted by GCC 4.6.0 warnings.
9671 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9673 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9674 (x_clipboard_manager_save_all): Move extern decl to ...
9675 * xterm.h: ... here, so that it can be checked for consistency.
9677 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9679 * xselect.c (x_clipboard_manager_save_frame)
9680 (x_clipboard_manager_save_all): New functions.
9681 (Fx_clipboard_manager_save): Lisp function deleted.
9683 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9684 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9686 * xterm.h: Update prototype.
9688 2011-05-28 William Xu <william.xwl@gmail.com>
9690 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9693 2011-05-28 Jim Meyering <meyering@redhat.com>
9695 Avoid a sign-extension bug in crypto_hash_function.
9696 * fns.c (to_uchar): Define.
9697 (crypto_hash_function): Use it to convert some newly-signed
9698 variables to unsigned, to avoid sign-extension bugs. For example,
9699 without this change, (md5 "truc") would evaluate to
9700 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9701 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9702 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9704 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9706 Integer overflow fixes.
9708 * dbusbind.c: Serial number integer overflow fixes.
9709 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9710 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9711 to hold a serial number that is too large for a fixnum.
9712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9713 Check for serial numbers out of range. Decode any serial number
9714 that was so large that it became a float. (Bug#8722)
9716 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9717 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9718 Use XFASTINT rather than XUINT when numbers are nonnegative.
9719 (xd_append_arg, Fdbus_method_return_internal):
9720 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9721 arguments, check that Lisp number is nonnegative, rather than
9722 silently wrapping negative numbers around. (Bug#8722)
9723 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9726 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9728 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9730 ccl: Add integer overflow checks.
9731 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9732 (IN_INT_RANGE): New macros.
9733 (ccl_driver): Use them to check for integer overflow when
9734 decoding a CCL program. Many of the new checks are whether XINT (x)
9735 fits in int; it doesn't always, on 64-bit hosts. The new version
9736 doesn't catch all possible integer overflows, but it's an
9737 improvement. (Bug#8719)
9739 * alloc.c (make_event_array): Use XINT, not XUINT.
9740 There's no need for unsigned here.
9742 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9743 This follows up to the 2011-05-06 change that substituted uintptr_t
9744 for EMACS_INT. This case wasn't caught back then.
9746 Rework Fformat to avoid integer overflow issues.
9747 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9748 now (part of C89). Include <verify.h>.
9749 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9750 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9751 (Fformat): Avoid the prepass trying to compute sizes; it was only
9752 approximate and thus did not catch overflow reliably. Instead, walk
9753 through the format just once, formatting and computing sizes as we go,
9754 checking for integer overflow at every step, and allocating a larger
9755 buffer as needed. Keep track separately whether the format is
9756 multibyte. Keep only the most-recently calculated precision, rather
9757 than them all. Record whether each argument has been converted to
9758 string. Use EMACS_INT, not int, for byte and char and arg counts.
9759 Support field widths and precisions larger than INT_MAX. Avoid
9760 sprintf's undefined behavior with conversion specifications such as %#d
9761 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9762 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9763 formatting out-of-range floating point numbers with int
9766 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9768 * data.c: Avoid integer truncation in expressions involving floats.
9769 * data.c: Include <intprops.h>.
9770 (arith_driver): When there's an integer overflow in an expression
9771 involving floating point, convert the integers to floating point
9772 so that the resulting value does not suffer from catastrophic
9773 integer truncation. For example, on a 64-bit host (* 4
9774 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9775 Do not rely on undefined behavior after integer overflow.
9777 merge count_size_as_multibyte, parse_str_to_multibyte
9778 * character.c, character.h (count_size_as_multibyte):
9779 Rename from parse_str_to_multibyte; all uses changed.
9780 Check for integer overflow.
9781 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9782 since it's now a duplicate of the other. This is more of
9783 a character than a buffer op, so better that it's in character.c.
9784 * fns.c, print.c: Adjust to above changes.
9786 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9788 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9790 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9792 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9793 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9794 (x_clipboard_manager_save): Now static.
9795 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9797 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9798 (crypto_hash_function): Now static.
9799 Fix pointer signedness problems. Avoid unnecessary initializations.
9801 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9803 * termhooks.h (Vselection_alist): Make it terminal-local.
9805 * terminal.c (create_terminal): Initialize it.
9807 * xselect.c: Support for clipboard managers.
9808 (Vselection_alist): Move to termhooks.h as terminal-local var.
9809 (LOCAL_SELECTION): New macro.
9810 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9811 (symbol_to_x_atom): Remove gratuitous arg.
9812 (x_handle_selection_request, lisp_data_to_selection_data)
9813 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9814 (x_own_selection, x_get_local_selection, x_convert_selection):
9815 New arg, specifying work frame. Use terminal-local Vselection_alist.
9816 (some_frame_on_display): Delete unused function.
9817 (Fx_own_selection_internal, Fx_get_selection_internal)
9818 (Fx_disown_selection_internal, Fx_selection_owner_p)
9819 (Fx_selection_exists_p): New optional frame arg.
9820 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9821 (x_handle_selection_clear): Don't treat other terminals with the
9822 same keyboard specially. Use the terminal-local Vselection_alist.
9823 (x_clear_frame_selections): Use Frun_hook_with_args.
9825 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9827 * xterm.h: Add support for those atoms.
9829 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9831 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9832 (converted_selections, conversion_fail_tag): New global variables.
9833 (x_selection_request_lisp_error): Free the above.
9834 (x_get_local_selection): Remove unnecessary code.
9835 (x_reply_selection_request): Args changed; handle arbitrary array
9836 of converted selections stored in converted_selections.
9837 Separate the XChangeProperty and SelectionNotify steps.
9838 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9839 (x_convert_selection): New function.
9840 (x_handle_selection_event): Simplify.
9841 (x_get_foreign_selection): Don't ignore incoming requests while
9842 waiting for an answer; this will fail when we implement
9843 SAVE_TARGETS, and seems unnecessary anyway.
9844 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9845 (Vx_sent_selection_functions): Doc fix.
9847 2011-05-26 Leo Liu <sdl.web@gmail.com>
9849 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9851 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9853 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9855 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9856 for fringe update if it has periodic bitmap.
9857 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9858 and fringe_bitmap_periodic_p.
9860 * fringe.c (get_fringe_bitmap_data): New function.
9861 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9862 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9863 row. Mark glyph row for fringe update if periodicity changed.
9865 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9866 for fringe update unless it has periodic bitmap.
9868 2011-05-25 Kenichi Handa <handa@m17n.org>
9870 * xdisp.c (get_next_display_element): Set correct it->face_id for
9871 a static composition.
9873 2011-05-24 Leo Liu <sdl.web@gmail.com>
9876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9878 * fns.c (crypto_hash_function, Fsha1): New function.
9879 (Fmd5): Use crypto_hash_function.
9880 (syms_of_fns): Add Ssha1.
9882 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9884 * gnutls.c: Remove unused macros.
9885 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9886 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9887 Remove macros that are defined and never used.
9888 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9890 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9892 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9893 (Fx_get_selection_internal): Minor cleanup.
9894 (Fx_own_selection_internal): Rename arguments for consistency with
9897 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9899 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9901 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9903 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9905 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9907 * dispnew.c (scrolling_window): Don't exclude the case that the
9908 last enabled row in the desired matrix touches the bottom boundary.
9910 2011-05-21 Glenn Morris <rgm@gnu.org>
9912 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9913 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9914 and add some more files.
9916 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9918 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9919 report_file_error introduced by the change from 2011-05-07.
9921 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9923 * systime.h (Time): Define only if emacs is defined.
9924 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9925 where the include path doesn't have X11/X.h by default. See
9926 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9928 2011-05-20 Kenichi Handa <handa@m17n.org>
9930 * composite.c (find_automatic_composition): Fix previous change.
9932 2011-05-20 Glenn Morris <rgm@gnu.org>
9934 * lisp.mk: New file, split from Makefile.in.
9935 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9936 (shortlisp): Remove.
9937 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9939 2011-05-19 Glenn Morris <rgm@gnu.org>
9941 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9942 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9943 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9944 (lisp): Set the order to that of loadup.el.
9945 (shortlisp): Make it a copy of $lisp.
9946 (SOME_MACHINE_LISP): Remove.
9947 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9948 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9950 2011-05-18 Kenichi Handa <handa@m17n.org>
9952 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9953 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9954 (find_automatic_composition): Mostly rewrite for efficiency.
9956 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9958 * makefile.w32-in: Update dependencies.
9960 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9962 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9963 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9965 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9967 Fix some integer overflow issues, such as string length overflow.
9969 * insdel.c (count_size_as_multibyte): Check for string overflow.
9971 * character.c (lisp_string_width): Check for string overflow.
9972 Use EMACS_INT, not int, for string indexes and lengths; in
9973 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9974 the resulting string length overflows an EMACS_INT; instead,
9975 report a string overflow if no precision given. When checking for
9976 precision exhaustion, use a check that cannot possibly have
9977 integer overflow. (Bug#8675)
9978 * character.h (lisp_string_width): Adjust to new signature.
9980 * alloc.c (string_overflow): New function.
9981 (Fmake_string): Use it. This doesn't change behavior, but saves
9982 a few bytes and will simplify future changes.
9983 * character.c (string_escape_byte8): Likewise.
9984 * lisp.h (string_overflow): New decl.
9986 Fixups, following up to the user-interface timestamp change.
9987 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9988 for UI timestamps, instead of unsigned long.
9989 * msdos.c (mouse_get_pos): Likewise.
9990 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9991 * w32gui.h (Time): Define by including "systime.h" rather than by
9992 declaring it ourselves. (Bug#8664)
9994 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9995 * image.c (clear_image_cache): Likewise.
9997 * term.c (term_mouse_position): Don't assume time_t wraparound.
9999 Be more systematic about user-interface timestamps.
10000 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10001 and sometimes 'EMACS_UINT', to represent these timestamps.
10002 This change causes it to use 'Time' uniformly, as that's what X uses.
10003 This makes the code easier to follow, and makes it easier to catch
10004 integer overflow bugs such as Bug#8664.
10005 * frame.c (Fmouse_position, Fmouse_pixel_position):
10006 Use Time, not unsigned long, for user-interface timestamps.
10007 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10008 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10009 * keyboard.h (last_event_timestamp): Likewise.
10010 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10011 * menu.h (xmenu_show): Likewise.
10012 * term.c (term_mouse_position): Likewise.
10013 * termhooks.h (struct input_event.timestamp): Likewise.
10014 (struct terminal.mouse_position_hook): Likewise.
10015 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10016 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10017 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10018 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10019 what it was before.
10020 * menu.h, termhooks.h: Include "systime.h", for Time.
10022 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10023 Don't assume that the difference between two unsigned long values
10024 can fit into an integer. At this point, we know button_down_time
10025 <= event->timestamp, so the difference must be nonnegative, so
10026 there's no need to cast the result if double-click-time is
10027 nonnegative, as it should be; check that it's nonnegative, just in
10028 case. This bug is triggered when events are more than 2**31 ms
10029 apart (about 25 days). (Bug#8664)
10031 * xselect.c (last_event_timestamp): Remove duplicate decl.
10032 (x_own_selection): Remove needless cast to unsigned long.
10034 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10035 that always fit in int. Use a sentinel instead of a counter, to
10036 avoid a temp and to allay GCC's concerns about possible int overflow.
10037 * frame.h (struct frame): Use int for menu_bar_items_used
10038 instead of EMACS_INT, since it always fits in int.
10040 * menu.c (grow_menu_items): Check for int overflow.
10042 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10044 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10045 Before, the code was not consistent. These values cannot exceed
10046 2**31 - 1 so there's no need to make them unsigned.
10047 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10048 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10049 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10051 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10053 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10054 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10055 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10056 presumably because the widths might not match.
10058 * window.c (size_window): Avoid needless test at loop start.
10060 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10062 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10064 2011-05-12 Drew Adams <drew.adams@oracle.com>
10066 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10068 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10070 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10071 `width' to `bar_area_x' and `bar_area_width', respectively.
10072 (x_scroll_run): Take account of fringe background extension.
10074 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10075 Rename local vars `left' and `width' to `bar_area_x' and
10076 `bar_area_width', respectively.
10077 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10078 background extension.
10080 2011-05-10 Jim Meyering <meyering@redhat.com>
10082 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10084 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10086 * image.c (Finit_image_library): Return t for built-in image types,
10087 like pbm and xbm. (Bug#8640)
10089 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10091 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10093 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10095 * w32console.c (Fset_screen_color): Doc fix.
10096 (Fget_screen_color): New function.
10097 (syms_of_ntterm): Defsubr it.
10099 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10100 unlink the temporary file if Fcall_process didn't create it in the
10102 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10103 child process will be redirected to a file specified with `:file'.
10104 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10105 cue to call_process_cleanup not to close that handle.
10107 2011-05-07 Ben Key <bkey76@gmail.com>
10109 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10110 one of two shell specific rules, either bootstrap-temacs-CMD or
10111 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10112 to the previous implementation of the bootstrap-temacs rule.
10113 The bootstrap-temacs-CMD rule is similar to the previous
10114 implementation of the bootstrap-temacs rule except that it
10115 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10118 These changes, along with some changes to nt/configure.bat,
10119 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10120 earlier fix to add support for --cflags and --ldflags options
10121 that include quotes so that it works whether make uses cmd or
10124 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10126 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10127 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10129 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10130 a string. Handle both cases.
10131 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10132 (Fdbus_register_method): Use Qinvalid_function.
10134 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10136 * makefile.w32-in: Update dependencies.
10137 (LISP_H): Add inttypes.h and stdin.h.
10138 (PROCESS_H): Add unistd.h.
10140 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10142 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10143 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10145 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10147 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10149 * term.c (vfatal): Remove stray call to va_end.
10150 It's not needed and the C Standard doesn't allow it here anyway.
10152 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10153 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10155 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10158 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10160 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10162 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10164 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10166 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10168 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10169 * charset.c (Fdefine_charset_internal): Don't initialize
10170 charset.code_space[15]. The value was garbage, on hosts with
10171 32-bit int (Bug#8600).
10173 * lread.c (read_integer): Be more consistent with string-to-number.
10174 Use string_to_number to do the actual conversion; this avoids
10175 rounding errors and fixes some other screwups. Without this fix,
10176 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10177 (digit_to_number): Move earlier, for benefit of read_integer.
10178 Return -1 if the digit is out of range for the base, -2 if it is
10179 not a digit in any supported base. (Bug#8602)
10181 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10183 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10184 to match comment at start of function. This also removes a
10185 GCC warning about overflow in a 32+64-bit port.
10187 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10189 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10190 Reported by Stefan Monnier in
10191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10192 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10193 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10195 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10196 (EMACS_UINTPTR): Likewise, with uintptr_t.
10198 * lisp.h: Prefer 64-bit EMACS_INT if available.
10199 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10200 on 32-bit hosts that have 64-bit int, so that they can access
10202 However, temporarily disable this change unless the temporary
10203 symbol WIDE_EMACS_INT is defined.
10205 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10207 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10208 This removes an assumption that EMACS_INT and long are the same
10209 width as pointers. The assumption is true for Emacs porting targets
10210 now, but we want to make other targets possible.
10211 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10212 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10213 In the rest of the code, change types of integers that hold casted
10214 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10215 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10216 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10217 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10218 No need to cast type when ORing.
10219 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10220 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10221 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10222 assume EMACS_INT is the same width as char *.
10223 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10224 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10225 Remove no-longer-needed casts.
10226 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10227 (xg_tool_bar_help_callback, xg_make_tool_item):
10228 Use EMACS_INTPTR to hold an integer
10229 that will be cast to void *; this can avoid a GCC warning
10230 if EMACS_INT is not the same width as void *.
10231 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10232 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10233 (current_message_1, set_message_1):
10234 Use a local to convert to proper width without a cast.
10235 * xmenu.c (dialog_selection_callback): Likewise.
10237 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10238 Also, don't assume VALBITS / RAND_BITS is less than 5,
10239 and don't rely on undefined behavior when shifting a 1 left into
10241 * lisp.h (get_random): Change signature to match.
10243 * lread.c (hash_string): Use size_t, not int, for hash computation.
10244 Normally we prefer signed values; but hashing is special, because
10245 it's better to use unsigned division on hash table sizes so that
10246 the remainder is nonnegative. Also, size_t is the natural width
10247 for hashing into memory. The previous code used 'int', which doesn't
10248 retain enough info to hash well into very large tables.
10249 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10251 * dbusbind.c: Don't possibly lose pointer info when converting.
10252 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10253 Use XPNTR rather than XHASH, so that the high-order bits of
10254 the pointer aren't lost when converting through void *.
10256 * eval.c (Fautoload): Don't double-shift a pointer.
10258 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10260 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10262 * gnutls.c (DEF_GNUTLS_FN):
10263 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10265 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10267 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10270 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10272 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10273 New version that can reserve upto 2GB of heap space.
10275 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10277 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10279 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10281 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10282 `gnutls_certificate_set_x509_key_file'.
10284 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10286 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10287 Update dependencies.
10289 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10291 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10292 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10293 Remove unused parameter `fildes'.
10294 * process.c (read_process_output, send_process): Don't pass it.
10296 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10298 Fix previous change: the library cache is defined in w32.c.
10299 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10300 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10302 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10304 Implement dynamic loading of GnuTLS on Windows.
10306 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10307 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10308 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10311 * gnutls.c (Qgnutls_dll): Define.
10312 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10313 (gnutls_*): Declare function pointers.
10314 (init_gnutls_functions): New function to initialize function pointers.
10315 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10316 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10318 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10319 (emacs_gnutls_write, emacs_gnutls_read)
10320 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10321 (Fgnutls_available_p): New function.
10322 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10323 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10324 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10326 * image.c: Include w32.h.
10327 (Vimage_type_cache): Delete.
10328 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10329 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10330 (w32_delayed_load): Move to w32.c.
10332 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10334 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10335 (w32_delayed_load): Move from image.c. When loading a library, record
10336 its filename in the :loaded-from property of the library id.
10337 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10338 Initialize and staticpro them.
10339 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10341 * process.c: Include lisp.h before w32.h, not after.
10342 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10343 instead of gnutls_record_check_pending.
10345 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10347 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10349 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10350 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10353 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10355 * xterm.c (x_set_frame_alpha): Do not set property on anything
10356 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10358 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10360 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10362 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10364 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10365 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10366 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10367 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10368 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10369 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10370 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10371 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10372 (Qgnutls_bootprop_callbacks_verify): Make static.
10374 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10376 * callproc.c: Indentation fixup.
10378 * sysdep.c (wait_for_termination_1): Make static.
10379 (wait_for_termination, interruptible_wait_for_termination):
10380 Move after wait_for_termination_1.
10382 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10384 * sysdep.c (interruptible_wait_for_termination): New function
10385 which is like wait_for_termination, but allows keyboard
10388 * callproc.c (Fcall_process): Add (:file "file") as an option for
10390 (Fcall_process_region): Ditto.
10392 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10394 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10395 rather than `XVECTOR (FOO)->size'.
10397 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10398 inttypes.h, as a gnulib replacement is used if it not available in
10401 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10403 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10404 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10405 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10407 * coding.c (coding_alloc_by_realloc): Error out if destination
10408 will grow beyond MOST_POSITIVE_FIXNUM.
10409 (decode_coding_emacs_mule): Abort if there isn't enough place in
10410 charbuf for the composition carryover bytes. Reserve an extra
10411 space for up to 2 characters produced in a loop.
10412 (decode_coding_iso_2022): Abort if there isn't enough place in
10413 charbuf for the composition carryover bytes.
10415 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10417 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10418 aborting when %lld or %lll format is passed.
10419 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10420 %llo or %llx format is passed. (Bug#8545)
10422 * window.c (window_scroll_line_based): Use a marker instead of
10423 simple variables to record original value of point. (Bug#7952)
10425 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10426 produced by %s or %c overflows available buffer space. (Bug#8545)
10428 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10430 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10431 (SIZE_MAX): Move defn after all includes, as they might #define it.
10433 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10435 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10437 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10439 * keyboard.c (Qdelayed_warnings_hook): Define.
10440 (command_loop_1): Run `delayed-warnings-hook'
10441 if Vdelayed_warnings_list is non-nil.
10442 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10443 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10445 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10447 * doprnt.c (doprnt): Don't return value smaller than the buffer
10448 size if the message was truncated. (Bug#8545).
10450 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10452 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10453 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10455 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10457 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10459 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10461 * makefile.w32-in: Update dependencies.
10463 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10465 Improve `doprnt' and its usage. (Bug#8545)
10466 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10467 `format_end'. Remove support for %l as a conversion specifier.
10468 Don't use xrealloc. Improve diagnostics when the %l size modifier
10469 is used. Update the commentary.
10471 * eval.c (verror): Simplify calculation of size_t.
10473 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10476 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10478 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10481 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10483 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10484 This makes this file independent of the recent pseudovector change.
10486 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10488 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10490 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10491 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10492 Remove unused local.
10493 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10495 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10496 GCC 4.6.0 optimizes based on type-based alias analysis.
10497 For example, if b is of type struct buffer * and v of type struct
10498 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10499 != &v->size, and therefore "v->size = 1; b->size = 2; return
10500 v->size;" must therefore return 1. This assumption is incorrect
10501 for Emacs, since it type-puns struct Lisp_Vector * with many other
10502 types. To fix this problem, this patch adds a new type struct
10503 vectorlike_header that documents the constraints on layout of vectors
10504 and pseudovectors, and helps optimizing compilers not get fooled
10505 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10506 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10507 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10509 (XSETPVECTYPE): Rewrite in terms of new macro.
10510 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10511 This is a bit clearer, and further avoids the possibility of
10512 undesirable aliasing.
10513 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10514 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10515 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10516 since Lisp_Subr is a special case (no "next" field).
10517 (ASIZE): Now uses header.size rather than size.
10518 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10519 to avoid the hassle of writing XVECTOR (foo)->header.size.
10520 (struct vectorlike_header): New type.
10521 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10522 object, to help avoid aliasing.
10523 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10524 (SUBRP): Likewise, since Lisp_Subr is a special case.
10525 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10526 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10527 (struct Lisp_Hash_Table): Combine first two members into a single
10528 struct vectorlike_header member. All uses of "size" and "next" members
10529 changed to be "header.size" and "header.next".
10530 * buffer.h (struct buffer): Likewise.
10531 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10532 * frame.h (struct frame): Likewise.
10533 * process.h (struct Lisp_Process): Likewise.
10534 * termhooks.h (struct terminal): Likewise.
10535 * window.c (struct save_window_data, struct saved_window): Likewise.
10536 * window.h (struct window): Likewise.
10537 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10538 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10539 * buffer.c (init_buffer_once): Likewise.
10540 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10542 * process.c (Fformat_network_address): Use local var for size,
10545 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10547 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10548 * data.c (atof): Remove decl; no longer used or needed.
10549 (digit_to_number): Move to lread.c.
10550 (Fstring_to_number): Use new string_to_number function, to be
10551 consistent with how the Lisp reader treats infinities and NaNs.
10552 Do not assume that floating-point numbers represent EMACS_INT
10553 without losing information; this is not true on most 64-bit hosts.
10554 Avoid double-rounding errors, by insisting on integers when
10555 parsing non-base-10 numbers, as the documentation specifies.
10556 * lisp.h (string_to_number): New decl, replacing ...
10557 (isfloat_string): Remove.
10558 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10559 (read1): Do not accept +. and -. as integers; this
10560 appears to have been a coding error. Similarly, do not accept
10561 strings like +-1e0 as floating point numbers. Do not report
10562 overflow for integer overflows unless the base is not 10 which
10563 means we have no simple and reliable way to continue.
10564 Break out the floating-point parsing into a new
10565 function string_to_number, so that Fstring_to_number parses
10566 floating point numbers consistently with the Lisp reader.
10567 (digit_to_number): Move here from data.c. Make it static inline.
10568 (E_CHAR, EXP_INT): Remove, replacing with ...
10569 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10570 (string_to_number): New function, replacing isfloat_string.
10571 This function checks for valid syntax and produces the resulting
10572 Lisp float number too. Rework it so that string-to-number
10573 no longer mishandles examples like "1.0e+". Use strtoumax,
10574 so that overflow for non-base-10 numbers is reported only when
10575 there's no portable and simple way to convert to floating point.
10577 * textprop.c (set_text_properties_1): Rewrite for clarity,
10578 and to avoid GCC warning about integer overflow.
10580 * intervals.h (struct interval): Use EMACS_INT for members
10581 where EMACS_UINT might cause problems. See
10582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10583 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10584 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10586 (offset_intervals): Tell GCC not to worry about length overflow
10587 when negating a negative length.
10589 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10590 (overrun_check_free): Likewise.
10592 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10593 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10596 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10597 (gnutls_make_error): Rename local to avoid shadowing.
10598 (gnutls_emacs_global_deinit): ifdef out; not used.
10599 (Fgnutls_boot): Use const for pointer to readonly storage.
10600 Comment out unused local. Fix pointer signedness problems.
10602 * lread.c (openp): Don't stuff size_t into an 'int'.
10603 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10604 about possible signed overflow.
10606 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10607 (GDK_KEY_g): Don't define if already defined.
10608 (xg_prepare_tooltip): Avoid pointer signedness problem.
10609 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10611 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10612 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10614 * xfns.c (Fx_window_property): Simplify a bit,
10615 to make a bit faster and to avoid GCC 4.6.0 warning.
10616 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10618 * fns.c (internal_equal): Don't assume size_t fits in int.
10620 * alloc.c (compact_small_strings): Tighten assertion a little.
10622 Replace pEd with more-general pI, and fix some printf arg casts.
10623 * lisp.h (pI): New macro, generalizing old pEd macro to other
10624 conversion specifiers. For example, use "...%"pI"d..." rather
10625 than "...%"pEd"...".
10626 (pEd): Remove. All uses replaced with similar uses of pI.
10627 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10628 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10629 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10630 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10631 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10632 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10633 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10635 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10636 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10637 * print.c (safe_debug_print, print_object): Likewise.
10638 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10640 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10641 avoiding the 0 flag, which is not portable.
10642 * process.c (Fmake_network_process): Use pI to avoid cast.
10643 * region-cache.c (pp_cache): Likewise.
10644 * xdisp.c (decode_mode_spec): Likewise.
10645 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10646 behavior on 64-bit hosts with printf arg.
10647 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10648 (x_stop_queuing_selection_requests): Likewise.
10649 (x_get_window_property): Don't truncate byte count to an 'int'
10652 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10653 here, since it parses constructs like leading '-' and spaces,
10654 which are not wanted; and it overflows with large numbers.
10655 Instead, simply match F[0-9]+, which is what is wanted anyway.
10657 * alloc.c: Remove unportable assumptions about struct layout.
10658 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10659 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10660 (allocate_vectorlike, make_pure_vector): Use the new macros,
10661 plus offsetof, to remove unportable assumptions about struct layout.
10662 These assumptions hold on all porting targets that I know of, but
10663 they are not guaranteed, they're easy to remove, and removing them
10664 makes further changes easier.
10666 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10667 This doesn't fix a bug but makes the code clearer.
10668 (string_overrun_cookie): Now const. Use initializers that
10669 don't formally overflow signed char, to avoid warnings.
10670 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10671 can cause Emacs to crash when string overrun checking is enabled.
10672 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10673 multiple of sizeof (EMACS_INT); it need not be, if
10674 alignof(EMACS_INT) < sizeof (EMACS_INT).
10675 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10677 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10679 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10681 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10683 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10684 supposed to be handshaking. (Bug#8556)
10685 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10687 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10689 * lisp.h (Qdebug): List symbol.
10690 * eval.c (Qdebug): Restore global linkage.
10691 * keyboard.c (debug-on-event): New variable.
10692 (handle_user_signal): Break into debugger when debug-on-event
10693 matches the current signal symbol.
10695 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10697 * alloc.c (check_sblock, check_string_bytes)
10698 (check_string_free_list): Convert to standard C.
10700 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10702 * w32.c (emacs_gnutls_push): Fix typo.
10704 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10706 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10707 "cast to pointer from integer of different size".
10709 Improve doprnt and its use in verror. (Bug#8545)
10710 * doprnt.c (doprnt): Document the set of format control sequences
10711 supported by the function. Use SAFE_ALLOCA instead of always
10714 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10715 is one byte too soon. Don't use xrealloc; instead xfree and
10718 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10720 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10723 * gnutls.c: Renamed global_initialized to
10724 gnutls_global_initialized. Added internals for the
10725 :verify-hostname-error, :verify-error, and :verify-flags
10726 parameters of `gnutls-boot' and documented those parameters in the
10727 docstring. Start callback support.
10728 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10729 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10730 on error. Return error code.
10731 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10732 (emacs_gnutls_read): Likewise.
10733 (Fgnutls_boot): Return handshake error code.
10734 (emacs_gnutls_handle_error): New function.
10735 (wsaerror_to_errno): Likewise.
10737 * w32.h (emacs_gnutls_pull): Add prototype.
10738 (emacs_gnutls_push): Likewise.
10740 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10741 (emacs_gnutls_push): Likewise.
10743 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10745 * process.c (wait_reading_process_output): Check if GnuTLS
10746 buffered some data internally if no FDs are set for TLS
10749 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10750 (LIBS): Link to USER_LIBS.
10751 ($(BLD)/gnutls.$(0)): New target.
10753 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10755 * xdisp.c (handle_single_display_spec): Rename the
10756 display_replaced_before_p argument into display_replaced_p, to
10757 make it consistent with the commentary. Fix typos in the
10760 * textprop.c (syms_of_textprop): Remove dead code.
10761 (copy_text_properties): Delete obsolete commentary about an
10762 interface that was deleted long ago. Fix typos in the description
10765 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10766 to changes in oldXMenu/XMenu.h from 2011-04-16.
10767 <menu_help_message, prev_menu_help_message>: Constify.
10768 (IT_menu_make_room): menu->help_text is now `const char **';
10771 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10772 to changes in oldXMenu/XMenu.h from 2011-04-16.
10773 (struct XMenu): Declare `help_text' `const char **'.
10775 * xfaces.c <Qunspecified>: Make extern again.
10777 * syntax.c: Include sys/types.h before including regex.h, as
10780 * doc.c (get_doc_string): Improve the format passed to `error'.
10782 * doprnt.c (doprnt): Improve commentary.
10784 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10786 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10789 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10790 changes in globals.h immediately force recompilation.
10791 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10792 $(CURDIR)/s/ms-w32.h.
10793 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10795 * character.c (Fchar_direction): Function deleted.
10796 (syms_of_character): Don't defsubr it.
10797 <char-direction-table>: Deleted.
10799 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10801 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10802 * doprnt.c: Include limits.h.
10803 (SIZE_MAX): New macro.
10804 (doprnt): Return a size_t value. 2nd arg is now size_t.
10805 Many local variables are now size_t instead of int or unsigned.
10806 Improve overflow protection. Support `l' modifier for integer
10807 conversions. Support %l conversion. Don't assume an EMACS_INT
10808 argument for integer conversions and for %c.
10810 * lisp.h (doprnt): Restore prototype.
10812 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10813 $(SRC)/character.h.
10815 * Makefile.in (base_obj): Add back doprnt.o.
10817 * deps.mk (doprnt.o): Add back prerequisites.
10818 (callint.o): Depend on character.h.
10820 * eval.c (internal_lisp_condition_case): Include the handler
10821 representation in the error message.
10822 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10823 when breaking from the loop.
10825 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10827 * callint.c (Fcall_interactively): When displaying error message
10828 about invalid control letter, pass the character's codepoint, not
10829 a pointer to its multibyte form. Improve display of the character
10830 in octal and display also its hex code.
10832 * character.c (char_string): Use %x to display the (unsigned)
10833 codepoint of an invalid character, to avoid displaying a bogus
10836 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10837 `error', not SYMBOL_NAME itself.
10839 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10840 character arguments to `error'.
10842 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10843 to `error' in error message about FINAL_CHAR argument. Make sure
10844 FINAL_CHAR is a character, and use %c when it is passed as
10845 argument to `error'.
10847 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10849 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10851 * w32.c: Include <time.h>.
10852 (sys_localtime): New function.
10854 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10856 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10858 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10860 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10862 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10863 zombies (Bug#8467).
10865 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10867 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10868 gl_state.e_property when gl_state.object is Qt.
10870 * insdel.c (make_gap_larger): Remove limitation of buffer size
10873 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10875 * xdisp.c (lookup_glyphless_char_display)
10876 (produce_glyphless_glyph): Handle cons cell entry in
10877 glyphless-char-display.
10878 (Vglyphless_char_display): Document it.
10880 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10881 glyphless-char-display.
10883 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10885 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10887 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10889 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10890 definition for no-X builds.
10892 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10894 Static checks with GCC 4.6.0 and non-default toolkits.
10896 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10898 * process.c (keyboard_bit_set): Define only if SIGIO.
10899 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10900 (send_process): Repair possible setjmp clobbering.
10902 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10904 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10906 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10908 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10909 Define only if needed.
10911 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10912 by pacifying GCC about it. Maybe it's time to retire it?
10913 * xfaces.c (USG, __TIMEVAL__): Likewise.
10915 * dispextern.h (struct redisplay_interface): Rename param
10916 to avoid shadowing.
10917 * termhooks.h (struct terminal): Likewise.
10918 * xterm.c (xembed_send_message): Likewise.
10920 * insdel.c (make_gap_smaller): Define only if
10921 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10923 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10926 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10927 so that we aren't warned about unused symbols.
10929 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10931 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10933 * xfns.c (x_real_positions): Mark locals as initialized.
10935 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10937 * xterm.c: Fix problems found by static analysis with other toolkits.
10938 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10939 (x_dispatch_event): Declare static if USE_GTK, and
10940 define if USE_GTK || USE_X_TOOLKIT.
10941 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10942 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10943 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10944 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10946 * xmenu.c (menu_help_callback): Pointer type fixes.
10947 Use const pointers when pointing at readonly data. Avoid pointer
10948 signedness clashes.
10949 (FALSE): Remove unused macro.
10950 (update_frame_menubar): Remove unused decl.
10952 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10954 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10955 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10956 (single_menu_item): Rename local to avoid shadowing.
10958 * keyboard.c (make_lispy_event): Remove unused local var.
10960 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10961 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10963 * bitmaps: Change bitmaps from unsigned char back to the X11
10964 compatible char. Avoid the old compiler warnings about
10965 out-of-range initializers by using, for example, '\xab' rather
10968 * xgselect.c (xgselect_initialize): Check vs interface
10969 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10971 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10973 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10974 to read-only memory.
10976 * fns.c (vector): Remove; this old hack is no longer needed.
10978 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10980 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10982 * xrdb.c (x_load_resources): Omit unused local.
10984 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10985 (x_window): Rename locals to avoid shadowing.
10986 (USG): Use the kludged USG macro, to pacify gcc.
10988 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10989 (x_term_init): Remove local to avoid shadowing.
10991 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10993 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10994 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10996 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10998 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11000 Fix regex.c, syntax.c and friends for buffers > 2GB.
11001 * syntax.h (struct gl_state_s): Declare character position members
11004 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11006 * textprop.c (verify_interval_modification, interval_of):
11007 Declare arguments EMACS_INT.
11009 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11012 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11014 * indent.c (Fvertical_motion): Local variable it_start is now
11017 * regex.c (re_match, re_match_2, re_match_2_internal)
11018 (bcmp_translate, regcomp, regexec, print_double_string)
11019 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11020 (re_compile_pattern, re_exec): Declare arguments and local
11021 variables `size_t' and `ssize_t' and return values `regoff_t', as
11023 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11024 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11025 <compile_stack_type>: `size' and `avail' are now `size_t'.
11027 * regex.h <regoff_t>: Use ssize_t, not int.
11028 (re_search, re_search_2, re_match, re_match_2): Arguments that
11029 specify buffer/string position and length are now ssize_t and
11030 size_t. Return type is regoff_t.
11032 2011-04-16 Ben Key <bkey76@gmail.com>
11034 * nsfont.m: Fixed bugs in ns_get_family and
11035 ns_descriptor_to_entity that were caused by using free to
11036 deallocate memory blocks that were allocated by xmalloc (via
11037 xstrdup). This caused Emacs to crash when compiled with
11038 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11039 --enable-checking=xmallocoverrun). xfree is now used to
11040 deallocate these memory blocks.
11042 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11044 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11046 emacs_write: Accept and return EMACS_INT for sizes.
11047 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11049 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11050 Accept and return EMACS_INT.
11051 (emacs_gnutls_write): Return the number of bytes written on
11053 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11054 (emacs_read, emacs_write): Remove check for negative size, as the
11055 Emacs source code has been audited now.
11056 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11057 (emacs_read, emacs_write): Use it.
11058 * process.c (send_process): Adjust to the new signatures of
11059 emacs_write and emacs_gnutls_write. Do not attempt to store
11060 a byte offset into an 'int'; it might overflow.
11061 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11063 * sound.c: Don't assume sizes fit in 'int'.
11064 (struct sound_device.period_size, alsa_period_size):
11065 Return EMACS_INT, not int.
11066 (struct sound_device.write, vox_write, alsa_write):
11067 Accept EMACS_INT, not int.
11068 (wav_play, au_play): Use EMACS_INT to store sizes and to
11069 record read return values.
11071 2011-04-15 Ben Key <bkey76@gmail.com>
11073 * keyboard.c (Qundefined): Don't declare static since it is used
11075 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11076 static since they are used in nsfont.m.
11078 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11080 * process.c (Qprocessp): Don't declare static.
11081 * lisp.h (Qprocessp): Declare again.
11083 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11085 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11087 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11089 Improve C-level modularity by making more things 'static'.
11091 Don't publish debugger-only interfaces to other modules.
11092 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11093 (verify_bytepos, count_markers): Move decls to the only modules
11095 * region-cache.h (pp_cache): Likewise.
11096 * window.h (check_all_windows): Likewise.
11097 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11099 * sysdep.c (croak): Now static, if
11100 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11101 * syssignal.h (croak): Declare only if not static.
11103 * alloc.c (refill_memory_reserve): Now static if
11104 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11105 * lisp.h (refill_memory_reserve): Declare only if not static.
11107 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11108 Define only if USE_LUCID.
11110 * xrdb.c (x_customization_string, x_rm_string): Now static.
11112 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11113 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11115 * xdisp.c (draw_row_with_mouse_face): Now static.
11116 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11118 * window.h (check_all_windows): Mark externally visible.
11120 * window.c (window_deletion_count): Now static.
11122 * undo.c: Make symbols static if they're not exported.
11123 (last_undo_buffer, last_boundary_position, pending_boundary):
11126 * textprop.c (interval_insert_behind_hooks): Now static.
11127 (interval_insert_in_front_hooks): Likewise.
11129 * term.c: Make symbols static if they're not exported.
11130 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11131 (max_frame_lines, tty_set_terminal_modes):
11132 (tty_reset_terminal_modes, tty_turn_off_highlight):
11133 (get_tty_terminal): Now static.
11134 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11135 * termhooks.h (term_mouse_moveto): Do not declare if
11136 HAVE_WINDOW_SYSTEM.
11137 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11138 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11140 * sysdep.c: Make symbols static if they're not exported.
11141 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11143 (sigprocmask_set, full_mask): Remove; unused.
11144 (wait_debugging): Mark as visible.
11145 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11146 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11148 * syntax.c (syntax_temp): Define only if !__GNUC__.
11150 * sound.c (current_sound_device, current_sound): Now static.
11152 * search.c (searchbufs, searchbuf_head): Now static.
11154 * scroll.c (scroll_cost): Remove; unused.
11155 * dispextern.h (scroll_cost): Remove decl.
11157 * region-cache.h (pp_cache): Mark as externally visible.
11159 * process.c: Make symbols static if they're not exported.
11160 (process_tick, update_tick, create_process, chan_process):
11161 (Vprocess_alist, proc_buffered_char, datagram_access):
11162 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11163 (deactivate_process): Mark defn as static, as well as decl.
11164 * lisp.h (create_process): Remove decl.
11165 * process.h (chan_process, Vprocess_alist): Remove decls.
11167 * print.c: Make symbols static if they're not exported.
11168 (print_depth, new_backquote_output, being_printed, print_buffer):
11169 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11170 (print_interval, print_number_index, initial_stderr_stream):
11172 * lisp.h (Fprinc): Remove decl.
11173 (debug_output_compilation_hack): Mark as externally visible.
11175 * sysdep.c (croak): Move decl from here to syssignal.h.
11176 * syssignal.h (croak): Put it here, so the API can be checked when
11177 'croak' is called from dissociate_if_controlling_tty.
11179 * minibuf.c: Make symbols static if they're not exported.
11180 (minibuf_save_list, choose_minibuf_frame): Now static.
11181 * lisp.h (choose_minibuf_frame): Remove decl.
11183 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11185 * lread.c: Make symbols static if they're not exported.
11186 (read_objects, initial_obarray, oblookup_last_bucket_number):
11188 (make_symbol): Remove; unused.
11189 * lisp.h (initial_obarray, make_symbol): Remove decls.
11191 * keyboard.c: Make symbols static if they're not exported.
11192 (single_kboard, recent_keys_index, total_keys, recent_keys):
11193 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11194 (this_single_command_key_start, echoing, last_auto_save):
11195 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11196 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11197 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11198 (Vlispy_mouse_stem, double_click_count):
11200 (force_auto_save_soon): Define only if SIGDANGER.
11201 (ignore_mouse_drag_p): Now static if
11202 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11203 (print_help): Remove; unused.
11204 (stop_character, last_timer_event): Mark as externally visible.
11205 * keyboard.h (ignore_mouse_drag_p): Declare only if
11206 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11207 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11208 * lisp.h (echoing): Remove decl.
11209 (force_auto_save_soon): Declare only if SIGDANGER.
11210 * xdisp.c (redisplay_window): Simplify code, to make it more
11211 obvious that ignore_mouse_drag_p is not accessed if !defined
11212 USE_GTK && !defined HAVE_NS.
11214 * intervals.c: Make symbols static if they're not exported.
11215 (merge_properties_sticky, merge_interval_right, delete_interval):
11217 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11219 * insdel.c: Make symbols static if they're not exported.
11220 However, leave prepare_to_modify_buffer alone. It's never
11221 called from outside this function, but that appears to be a bug.
11222 (combine_after_change_list, combine_after_change_buffer):
11223 (adjust_after_replace, signal_before_change): Now static.
11224 (adjust_after_replace_noundo): Remove; unused.
11225 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11226 (signal_before_change): Remove decls.
11228 * indent.c (val_compute_motion, val_vmotion): Now static.
11230 * image.c: Make symbols static if they're not exported.
11231 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11233 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11234 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11236 * fringe.c (standard_bitmaps): Now static.
11237 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11239 * frame.c: Make symbols static if they're not exported.
11240 (x_report_frame_params, make_terminal_frame): Now static.
11241 (get_frame_param): Now static, unless HAVE_NS.
11242 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11243 (x_get_resource_string): Remove; not used.
11244 * frame.h (make_terminal_frame, x_report_frame_params):
11245 (x_get_resource_string); Remove decls.
11246 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11247 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11249 * font.c, fontset.c: Make symbols static if they're not exported.
11250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11251 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11252 * font.c (font_close_object): Now static.
11253 * font.h (font_close_object): Remove.
11254 * fontset.c (FONTSET_OBJLIST): Remove.
11255 (free_realized_fontset) #if-0 the body, which does nothing.
11256 (face_suitable_for_char_p): #if-0, as it's never called.
11257 * fontset.h (face_suitable_for_char_p): Remove decl.
11258 * xfaces.c (face_at_string_position):
11259 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11260 since 0 is always ASCII.
11262 * fns.c (weak_hash_tables): Now static.
11264 * fileio.c: Make symbols static if they're not exported.
11265 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11266 (Vwrite_region_annotation_buffers): Now static.
11268 * eval.c: Make symbols static if they're not exported.
11269 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11270 * lisp.h (backtrace_list): Remove decl.
11272 * emacs.c: Make symbols static if they're not exported.
11273 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11274 (fatal_error_code, fatal_error_signal_hook, standard_args):
11276 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11277 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11278 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11279 * lisp.h (fatal_error_signal_hook): Remove decl.
11280 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11282 * editfns.c: Move a (normally-unused) function to its only use.
11283 * editfns.c, lisp.h (get_operating_system_release): Remove.
11284 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11285 worth the hassle of breaking this out.
11287 * xterm.c: Make symbols static if they're not exported.
11288 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11289 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11290 (x_destroy_window, x_delete_display):
11292 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11293 (x_mouse_leave): Remove; unused.
11294 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11295 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11296 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11298 (x_mouse_leave): Declare only if WINDOWSNT.
11299 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11300 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11303 * ftxfont.c: Make symbols static if they're not exported.
11304 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11306 * font.h (ftxfont_driver): Likewise.
11308 * xfns.c: Make symbols static if they're not exported.
11309 (x_last_font_name, x_display_info_for_name):
11310 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11311 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11312 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11313 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11314 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11315 (last_show_tip_args): Now static.
11316 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11317 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11318 (x_screen_planes): Remove; unused.
11319 * dispextern.h (x_screen_planes): Remove decl.
11321 * dispnew.c: Make symbols static if they're not exported.
11322 * dispextern.h (redraw_garbaged_frames, scrolling):
11323 (increment_row_positions): Remove.
11324 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11325 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11327 (redraw_garbaged_frames): Remove; unused.
11329 * xfaces.c: Make symbols static if they're not exported.
11330 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11332 * xterm.h (defined_color): Remove decls.
11333 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11334 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11335 (menu_face_changed_default, defined_color, free_realized_face):
11336 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11337 (ascii_face_of_lisp_face): Remove; unused.
11339 * xdisp.c: Make symbols static if they're not exported.
11340 * dispextern.h (scratch_glyph_row, window_box_edges):
11341 (glyph_to_pixel_coords, set_cursor_from_row):
11342 (get_next_display_element, set_iterator_to_next):
11343 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11344 (show_mouse_face): Remove decls
11345 * frame.h (message_buf_print): Likewise.
11346 * lisp.h (pop_message, set_message, check_point_in_composition):
11348 * xterm.h (set_vertical_scroll_bar): Likewise.
11349 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11350 (message_buf_print, scratch_glyph_row, displayed_buffer):
11351 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11352 (get_next_display_element, show_mouse_face, window_box_edges):
11353 (frame_to_window_pixel_xy, check_point_in_composition):
11354 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11355 (glyph_to_pixel_coords): Remove; unused.
11357 * dired.c (file_name_completion): Now static.
11359 * dbusbind.c (xd_in_read_queued_messages): Now static.
11361 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11362 * data.c (circular_list_error): Remove.
11364 * commands.h (last_point_position, last_point_position_buffer):
11365 (last_point_position_window): Remove decls.
11366 * keyboard.c: Make these variables static.
11368 * coding.h (coding, code_convert_region, encode_coding_gap):
11370 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11371 (iso_code_class, detect_coding, code_convert_region): Now static.
11372 (encode_coding_gap): Remove; unused.
11374 * chartab.c (chartab_chars, chartab_bits): Now static.
11376 * charset.h (charset_iso_8859_1): Remove decl.
11377 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11380 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11381 * ccl.c (Vccl_program_table): Now static.
11382 (check_ccl_update): Remove; unused.
11384 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11385 * category.h: ... from here.
11386 * category.c (check_category_table, set_category_set): Now static.
11388 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11389 * lisp.h: Remove these decls.
11391 * buffer.c (buffer_count): Remove unused var.
11393 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11394 so that it's not optimized away.
11395 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11396 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11397 exported only to the debugger.
11399 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11400 * atimer.h (run_all_atimers): Remove; not exported.
11402 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11403 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11404 was inaccessible from Lisp.
11405 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11406 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11408 alloc.c: Import and export fewer symbols, and remove unused items.
11409 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11411 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11412 it's not optimized away by whole-program optimization.
11413 (message_enable_multibyte, free_misc): Remove.
11414 (catchlist, handlerlist, mark_backtrace):
11415 Declare only if BYTE_MARK_STACK.
11416 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11417 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11418 (message_enable_multibyte): Remove decl.
11419 (free_misc, interval_free_list, float_block, float_block_index):
11420 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11421 (cons_free_list, last_marked_index):
11423 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11424 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11425 (mark_backtrace): Define only if BYTE_MARK_STACK.
11426 * xdisp.c (message_enable_multibyte): Now static.
11428 Declare Lisp_Object Q* variables to be 'static' if not exported.
11429 This makes it easier for human readers (and static analyzers)
11430 to see whether these variables are used from other modules.
11431 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11432 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11433 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11434 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11435 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11436 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11437 * xmenu.c, xselect.c:
11438 Declare Q* vars static if they are not used in other modules.
11439 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11440 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11441 Remove decls of unexported vars.
11442 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11444 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11446 Make Emacs functions such as Fatom 'static' by default.
11447 This makes it easier for human readers (and static analyzers)
11448 to see whether these functions can be called from other modules.
11449 DEFUN now defines a static function. To make the function external
11450 so that it can be used in other C modules, use the new macro DEFUE.
11451 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11452 (Finit_image_library):
11453 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11454 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11455 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11456 Remove decls, since these functions are now static.
11457 (Funintern, Fget_internal_run_time): New decls, since these functions
11458 were already external.
11460 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11461 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11462 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11463 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11464 * keyboard.c, keymap.c, lread.c:
11465 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11466 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11467 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11468 Mark functions with DEFUE instead of DEFUN,
11469 if they are used in other modules.
11470 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11471 decls for now-static functions.
11472 * buffer.h (Fdelete_overlay): Remove decl.
11473 * callproc.c (Fgetenv_internal): Mark as internal.
11474 * composite.c (Fremove_list_of_text_properties): Remove decl.
11475 (Fcomposition_get_gstring): New forward static decl.
11476 * composite.h (Fcomposite_get_gstring): Remove decl.
11477 * dired.c (Ffile_attributes): New forward static decl.
11478 * doc.c (Fdocumntation_property): New forward static decl.
11479 * eval.c (Ffetch_bytecode): New forward static decl.
11480 (Funintern): Remove extern decl; now in .h file where it belongs.
11481 * fileio.c (Fmake_symbolic_link): New forward static decl.
11482 * image.c (Finit_image_library): New forward static decl.
11483 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11484 * intervals.h (Fprevious_property_change):
11485 (Fremove_list_of_text_properties): Remove decls.
11486 * keyboard.c (Fthis_command_keys): Remove decl.
11487 (Fcommand_execute): New forward static decl.
11488 * keymap.c (Flookup_key): New forward static decl.
11489 (Fcopy_keymap): Now static.
11490 * keymap.h (Flookup_key): Remove decl.
11491 * process.c (Fget_process): New forward static decl.
11492 (Fprocess_datagram_address): Mark as internal.
11493 * syntax.c (Fsyntax_table_p): New forward static decl.
11494 (skip_chars): Remove duplicate decl.
11495 * textprop.c (Fprevious_property_change): New forward static decl.
11496 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11498 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11499 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11501 * editfns.c (Fformat): Remove unreachable code.
11503 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11505 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11508 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11510 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11511 when at ZV. (Bug#8487)
11513 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11515 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11517 * keyboard.c (parse_tool_bar_item): Likewise.
11518 * sound.c (sound_cleanup, alsa_close): Likewise.
11519 * termcap.c (tgetent): Likewise.
11520 * xfns.c (x_default_font_parameter): Likewise.
11521 * xsettings.c (read_and_apply_settings): Likewise.
11523 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11524 (overrun_check_free): Protoize.
11526 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11528 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11529 since callers should never pass a negative size.
11530 Change the signature to match that of plain 'read' and 'write'; see
11531 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11532 * lisp.h: Update prototypes of emacs_write and emacs_read.
11534 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11536 * xdisp.c (redisplay_window): Don't try to determine the character
11537 position of the scroll margin if the window start point w->startp
11538 is outside the buffer's accessible region. (Bug#8468)
11540 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11542 Fix write-region and its subroutines for buffers > 2GB.
11543 * fileio.c (a_write, e_write): Modify declaration of arguments and
11544 local variables to support buffers larger than 2GB.
11545 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11547 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11548 argument, local variables, and return value.
11550 * lisp.h: Update prototypes of emacs_write and emacs_read.
11552 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11554 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11556 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11558 Fix more problems found by GCC 4.6.0's static checks.
11560 * xdisp.c (vmessage): Use a better test for character truncation.
11562 * charset.c (load_charset_map): <, not <=, for optimization,
11563 and to avoid potential problems with integer overflow.
11564 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11565 * casetab.c (set_identity, shuffle): Likewise.
11566 * editfns.c (Fformat): Likewise.
11567 * syntax.c (skip_chars): Likewise.
11569 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11570 This also lets GCC 4.6.0 generate slightly better loop code.
11572 * callint.c (Fcall_interactively): <, not <=, for optimization.
11573 (Fcall_interactively): Count the number of arguments produced,
11574 not the number of arguments given. This is simpler and lets GCC
11575 4.6.0 generate slightly better code.
11577 * ftfont.c: Distingish more carefully between FcChar8 and char.
11578 The previous code passed unsigned char * to a functions like
11579 strlen and xstrcasecmp that expect char *, which does not
11580 conform to the C standard.
11581 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11582 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11583 char * when the C standard requires it.
11585 * keyboard.c (read_char): Remove unused var.
11587 * eval.c: Port to Windows vsnprintf (Bug#8435).
11588 Include <limits.h>.
11589 (SIZE_MAX): Define if the headers do not.
11590 (verror): Do not give up if vsnprintf returns a negative count.
11591 Instead, grow the buffer. This ports to Windows vsnprintf, which
11592 does not conform to C99. Problem reported by Eli Zaretskii.
11593 Also, simplify the allocation scheme, by avoiding the need for
11594 calling realloc, and removing the ALLOCATED variable.
11596 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11598 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11599 But keep the doprint source code for now, as we might revamp it
11600 and use it again (Bug#8435).
11601 * lisp.h (doprnt): Remove.
11602 * Makefile.in (base_obj): Remove doprnt.o.
11603 * deps.mk (doprnt.o): Remove.
11605 error: Print 32- and 64-bit integers portably (Bug#8435).
11606 Without this change, on typical 64-bit hosts error ("...%d...", N)
11607 was used to print both 32- and 64-bit integers N, which relied on
11608 undefined behavior.
11609 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11610 * lisp.h (error, verror): Mark as printf-like functions.
11611 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11612 Report overflow in size calculations when allocating printf buffer.
11613 Do not truncate output string at its first null byte.
11614 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11615 Truncate the output at a character boundary, since vsnprintf does not
11617 * charset.c (check_iso_charset_parameter): Convert internal
11618 character to string before calling 'error', since %c now has the
11620 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11621 overflow when computing char to be passed to 'error'. Do not
11622 pass Lisp_Object to 'error'; pass the integer instead.
11623 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11624 formatted with plain %d.
11626 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11628 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11630 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11632 * xterm.c (x_catch_errors): Remove duplicate declaration.
11634 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11636 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11638 2011-04-10 Jim Meyering <meyering@redhat.com>
11640 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11641 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11642 return ssize_t not "int", and use size_t as the buffer length.
11643 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11644 * gnutls.h: Update declarations.
11645 * process.c (read_process_output): Use ssize_t, to match.
11646 (send_process): Likewise.
11648 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11650 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11652 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11654 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11655 Use unsigned char, to match FcChar8 type definition.
11657 * xterm.c (handle_one_xevent):
11658 * xmenu.c (create_and_show_popup_menu):
11659 * xselect.c (x_decline_selection_request)
11660 (x_reply_selection_request): Avoid type-punned deref of X events.
11662 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11664 Fix some uses of `int' instead of EMACS_INT.
11665 * search.c (string_match_1, fast_string_match)
11666 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11667 (scan_buffer, find_next_newline_no_quit)
11668 (find_before_next_newline, search_command, Freplace_match)
11669 (Fmatch_data): Make some `int' variables be EMACS_INT.
11671 * xdisp.c (display_count_lines): 3rd argument and return value now
11672 EMACS_INT. All callers changed.
11673 (pint2hrstr): Last argument is now EMACS_INT.
11675 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11676 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11677 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11678 (decode_coding_utf_16, decode_coding_emacs_mule)
11679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11680 (decode_coding_ccl, decode_coding_charset)
11681 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11682 (decode_coding_iso_2022, decode_coding_emacs_mule)
11683 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11684 <char_offset, last_offset>: Declare EMACS_INT.
11685 (encode_coding_utf_8, encode_coding_utf_16)
11686 (encode_coding_emacs_mule, encode_invocation_designation)
11687 (encode_designation_at_bol, encode_coding_iso_2022)
11688 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11689 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11691 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11692 (encode_invocation_designation): Last argument P_NCHARS is now
11694 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11695 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11697 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11700 * ccl.c (Fccl_execute_on_string): Declare some variables
11703 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11705 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11707 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11709 * process.c (Fformat_network_address): Doc fix.
11711 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11713 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11715 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11717 * keyboard.c (read_char): Call Lisp function help-form-show,
11718 instead of using internal_with_output_to_temp_buffer.
11719 (Qhelp_form_show): New var.
11720 (syms_of_keyboard): Use DEFSYM macro.
11722 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11724 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11726 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11728 * process.c (Flist_processes): Remove to Lisp.
11729 (list_processes_1): Delete.
11731 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11733 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11735 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11737 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11739 Fix more problems found by GCC 4.6.0's static checks.
11741 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11743 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11745 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11747 * xdisp.c (vmessage): Mark as a printf-like function.
11749 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11751 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11753 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11754 printf-like functions.
11755 (tiff_load): Add casts to remove these marks before passing them
11756 to system-supplied API.
11758 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11760 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11761 This avoids several warnings with gcc -Wstrict-overflow.
11762 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11763 directly, rather than having caller test rule sign. This avoids
11764 some unnecessary tests.
11765 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11766 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11767 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11769 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11770 (xfont_open): Avoid unnecessary tests.
11772 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11774 * composite.h, composite.c (composition_gstring_put_cache):
11775 Use EMACS_INT, not int, for length.
11777 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11778 breaking out part of COMPOSITION_DECODE_RULE.
11779 (COMPOSITION_DECODE_RULE): Use it.
11780 * composite.c (get_composition_id): Remove unused local vars,
11781 by using the new macro.
11783 * textprop.c (set_text_properties_1): Change while to do-while,
11784 since the condition is always true at first.
11786 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11787 (interval_deletion_adjustment): Return unsigned value.
11790 * process.c (list_processes_1, create_pty, read_process_output):
11791 (exec_sentinel): Remove vars that were set but not used.
11792 (create_pty): Remove unnecessary "volatile"s.
11793 (Fnetwork_interface_info): Avoid possibility of int overflow.
11794 (read_process_output): Do adaptive read buffering even if carryover.
11795 (read_process_output): Simplify nbytes computation if buffered.
11797 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11799 * syntax.c (scan_words): Remove var that was set but not used.
11800 (update_syntax_table): Use unsigned instead of int.
11802 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11803 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11804 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11806 * print.c (print_error_message): Avoid int overflow.
11808 * font.c (font_list_entities): Redo for clarity,
11809 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11811 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11812 (font_score): Avoid potential overflow in diff calculation.
11814 * fns.c (substring_both): Remove var that is set but not used.
11815 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11817 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11819 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11820 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11821 can always succeed if overflow has undefined behavior.
11823 * search.c (boyer_moore, wordify): Remove vars set but not used.
11824 (wordify): Omit three unnecessary tests.
11826 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11827 All callers changed. This avoids the need for an unused var.
11829 * casefiddle.c (casify_region): Remove var that is set but not used.
11831 * dired.c (file_name_completion): Remove var that is set but not used.
11833 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11835 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11836 (Finsert_file_contents): Remove unnecessary code checking fd.
11838 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11839 Check for integer overflow on size calculations.
11841 * buffer.c (Fprevious_overlay_change): Remove var that is set
11844 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11845 Remove vars that are set but not used.
11846 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11847 (timer_check_2): Mark vars as initialized.
11849 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11851 * image.c (lookup_image): Remove var that is set but not used.
11852 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11854 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11855 that are set but not used.
11857 * xfns.c (make_invisible_cursor): Don't return garbage
11858 if XCreateBitmapFromData fails (Bug#8410).
11860 * xselect.c (x_get_local_selection, x_handle_property_notify):
11861 Remove vars that are set but not used.
11863 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11864 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11866 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11867 Remove var that is set but not used.
11868 (scroll_bar_windows_size): Now size_t, not int.
11869 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11870 Check for overflow.
11872 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11873 (map_tty_color) [!defined MSDOS]: Likewise.
11875 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11877 * coding.c: Remove vars that are set but not used.
11878 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11879 All callers changed.
11880 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11881 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11882 (decode_coding_charset): Remove vars that are set but not used.
11884 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11885 that is set but not used.
11887 * print.c (print_object): Remove var that is set but not used.
11889 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11890 The gnulib version avoids calling malloc in the usual case,
11891 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11892 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11893 * filelock.c (current_lock_owner): Likewise.
11894 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11895 * sysdep.c: Include allocator.h, careadlinkat.h.
11896 (emacs_no_realloc_allocator): New static constant.
11897 (emacs_readlink): New function.
11898 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11899 ../lib/careadlinkat.h.
11901 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11903 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11904 first non-nil return value).
11906 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11908 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11909 if not defined (Bug#8403).
11911 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11913 * xdisp.c (display_count_lines): Remove parameter `start',
11914 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11915 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11916 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11917 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11918 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11919 and thereabouts. All callers changed.
11920 (get_per_char_metric): Remove parameter `f', unused since
11921 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11923 2011-04-02 Jim Meyering <meyering@redhat.com>
11925 do not dereference NULL upon failed strdup
11926 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11927 (ns_get_family): Likewise.
11929 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11931 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11933 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11935 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11938 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11940 Add lexical binding.
11942 * window.c (Ftemp_output_buffer_show): New fun.
11943 (Fsave_window_excursion):
11944 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11946 * lread.c (lisp_file_lexically_bound_p): New function.
11947 (Fload): Bind Qlexical_binding.
11948 (readevalloop): Remove `evalfun' arg.
11949 Bind Qinternal_interpreter_environment.
11950 (Feval_buffer): Bind Qlexical_binding.
11951 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11953 (syms_of_lread): Declare `lexical-binding'.
11955 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11957 * keyboard.c (eval_dyn): New fun.
11958 (menu_item_eval_property): Use it.
11960 * image.c (parse_image_spec): Use Ffunctionp.
11962 * fns.c (concat, mapcar1): Accept byte-code-functions.
11964 * eval.c (Fsetq): Handle lexical vars.
11965 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11966 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11967 (FletX, Flet): Obey lexical binding.
11968 (Fcommandp): Handle closures.
11969 (Feval): New `lexical' arg.
11970 (eval_sub): New function extracted from Feval. Use it almost
11971 everywhere where Feval was used. Look up vars in lexical env.
11973 (Ffunctionp): Move from subr.el.
11974 (Ffuncall): Handle closures.
11975 (apply_lambda): Remove `eval_flags'.
11976 (funcall_lambda): Handle closures and new byte-code-functions.
11977 (Fspecial_variable_p): New function.
11978 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11979 but without exporting it to Lisp.
11981 * doc.c (Fdocumentation, store_function_docstring):
11982 * data.c (Finteractive_form): Handle closures.
11984 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11987 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11989 (exec_byte_code): New function extracted from Fbyte_code to handle new
11990 calling convention for byte-code-functions. Add new byte-codes.
11992 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11994 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11996 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11998 * xdisp.c (redisplay_internal): Fix prototype.
12000 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12002 * xdisp.c (SCROLL_LIMIT): New macro.
12003 (try_scrolling): Use it when setting scroll_limit.
12004 Limit scrolling to 100 screen lines.
12005 (redisplay_window): Even when falling back on "recentering",
12006 position point in the window according to scroll-conservatively,
12007 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12009 (try_scrolling): When point is above the window, allow searching
12010 as far as scroll_max, or one screenful, to compute vertical
12011 distance from PT to the scroll margin position. This prevents
12012 try_scrolling from unnecessarily failing when
12013 scroll-conservatively is set to a value slightly larger than the
12014 window height. Clean up the case of PT below the margin at bottom
12015 of window: scroll_max can no longer be INT_MAX. When aggressive
12016 scrolling is in use, don't let point enter the opposite scroll
12017 margin as result of the scroll.
12018 (syms_of_xdisp) <scroll-conservatively>: Document the
12019 threshold of 100 lines for never-recentering scrolling.
12021 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12023 * dispextern.h (move_it_by_lines):
12024 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12025 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12026 (message_log_check_duplicate): Remove parameters `prev_bol' and
12027 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12028 (redisplay_internal): Remove parameter `preserve_echo_area',
12029 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12031 * indent.c (Fvertical_motion):
12032 * window.c (window_scroll_pixel_based, Frecenter):
12033 Don't pass `need_y_p' to `move_it_by_lines'.
12035 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12037 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12038 steal a few bits to be more compact.
12039 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12040 Remove unneeded casts.
12042 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12044 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12046 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12047 binding" message (bug#7967).
12049 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12051 Fix more problems found by GCC 4.6.0's static checks.
12053 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12054 Remove unused local var.
12056 * editfns.c (Fmessage_box): Remove unused local var.
12058 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12059 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12060 Omit unused local vars.
12061 * window.c (shrink_windows): Omit unused local var.
12062 * menu.c (digest_single_submenu): Omit unused local var.
12063 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12064 Omit unused local var.
12066 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12067 Don't assume string length fits in int.
12068 (keyremap_step, read_key_sequence): Use size_t for sizes.
12069 (read_key_sequence): Don't check last_real_key_start redundantly.
12071 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12072 instead of alloca (Bug#8344).
12074 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12075 (Fbacktrace_frame): Don't assume nframes fits in int.
12077 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12079 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12082 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12084 * cm.c (calccost): Turn while-do into do-while, for clarity.
12086 * keyboard.c (syms_of_keyboard): Use the same style as later
12087 in this function when indexing through an array. This also
12088 works around GCC bug 48267.
12090 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12092 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12094 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12095 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12097 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12098 This avoids undefined behavior on integer overflow, and is a bit
12099 more convenient anyway since it is compared to a size_t variable.
12101 Variadic C functions now count arguments with size_t, not int.
12102 This avoids an unnecessary limitation on 64-bit machines, which
12103 caused (substring ...) to crash on large vectors (Bug#8344).
12104 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12105 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12106 All variadic functions and their callers changed accordingly.
12107 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12108 * data.c (arith_driver, float_arith_driver): Likewise.
12109 * editfns.c (general_insert_function): Likewise.
12110 * eval.c (struct backtrace.nargs, interactive_p)
12111 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12112 (funcall_lambda, mark_backtrace): Likewise.
12113 * fns.c (concat): Likewise.
12114 * frame.c (x_set_frame_parameters): Likewise.
12115 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12116 0 if not found, not -1. All callers changed.
12118 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12119 (stack_copy_size): Now size_t, not int.
12120 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12122 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12124 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12125 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12126 All callers changed.
12128 * lisp.h (multibyte_char_to_unibyte):
12129 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12130 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12131 * character.h (CHAR_TO_BYTE8):
12132 * cmds.c (internal_self_insert):
12133 * editfns.c (general_insert_function):
12134 * keymap.c (push_key_description):
12135 * search.c (Freplace_match):
12136 * xdisp.c (message_dolog, set_message_1): All callers changed.
12138 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12140 * keyboard.c (safe_run_hook_funcall): New function.
12141 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12142 don't set the hook to nil, but remove the offending function instead.
12143 (Qcommand_hook_internal): Remove, unused.
12144 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12145 Vcommand_hook_internal.
12147 * eval.c (enum run_hooks_condition): Remove.
12148 (funcall_nil, funcall_not): New functions.
12149 (run_hook_with_args): Call each function through a `funcall' argument.
12150 Remove `cond' argument, now redundant.
12151 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12152 (Frun_hook_with_args_until_failure): Adjust accordingly.
12153 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12155 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12157 * dispextern.h (string_buffer_position): Remove declaration.
12159 * print.c (strout): Remove parameter `multibyte', unused since
12160 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12162 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12163 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12164 All callers changed.
12166 * w32.c (_wsa_errlist): Use braces for struct initializers.
12168 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12169 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12170 All callers changed.
12171 (string_buffer_position): Likewise. Also, make static (it's never
12172 used outside xdisp.c).
12173 (cursor_row_p): Remove parameter `w', unused since
12174 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12175 (decode_mode_spec): Remove parameter `precision', introduced during
12176 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12177 All callers changed.
12179 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12181 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12183 2011-03-27 Anders Lindgren <andlind@gmail.com>
12185 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12186 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12187 (ns_update_auto_hide_menu_bar): New functions.
12188 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12189 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12190 ns_constrain_all_frames.
12191 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12192 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12194 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12196 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12198 2011-03-27 Glenn Morris <rgm@gnu.org>
12200 * syssignal.h: Replace RETSIGTYPE with void.
12201 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12202 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12203 Replace SIGTYPE with void everywhere.
12204 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12205 * s/template.h (SIGTYPE): Remove commented out definition.
12207 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12209 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12210 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12212 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12214 * w32.c (read_unc_volume): Use parameter `henum', instead of
12215 global variable `wget_enum_handle'.
12217 * keymap.c (describe_vector): Remove parameters `indices' and
12218 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12219 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12221 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12223 * keyboard.c (timer_check): Remove parameter `do_it_now',
12224 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12225 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12226 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12228 * keyboard.c (read_char):
12229 * w32menu.c (w32_menu_display_help):
12230 * xmenu.c (show_help_event, menu_help_callback):
12231 Adjust calls to `show_help_echo'.
12233 * gtkutil.c (xg_maybe_add_timer):
12234 * keyboard.c (readable_events):
12235 * process.c (wait_reading_process_output):
12236 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12238 * insdel.c (adjust_markers_gap_motion):
12239 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12240 (gap_left, gap_right): Don't call it.
12242 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12244 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12245 incurred during fontification.
12247 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12249 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12250 (DEFVAR_PER_BUFFER): Don't pass it.
12252 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12253 (scrolling_window): Don't pass it.
12255 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12257 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12259 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12261 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12262 of variables specific to SELinux and computation of `encoded_absname'.
12264 * image.c (XPutPixel): Remove unused variable `height'.
12266 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12268 * unexw32.c (get_section_info): Remove unused variable `section'.
12270 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12271 (system_process_attributes): Remove unused variable `sess'.
12272 (sys_read): Remove unused variable `err'.
12274 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12275 (w32_wnd_proc): Remove unused variable `isdead'.
12276 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12277 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12278 (x_create_tip_frame): Remove unused variable `tem'.
12280 * w32inevt.c (w32_console_read_socket):
12281 Remove unused variable `no_events'.
12283 * w32term.c (x_draw_composite_glyph_string_foreground):
12284 Remove unused variable `width'.
12286 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12288 * w32term.c (x_set_glyph_string_clipping):
12289 Don't pass uninitialized region to CombineRgn.
12291 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12293 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12294 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12295 (Fx_close_connection): Remove unused variable `i'.
12297 * w32font.c (w32font_draw): Return number of glyphs.
12298 (w32font_open_internal): Remove unused variable `i'.
12299 (w32font_driver): Add missing initializer.
12301 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12302 (fill_in_menu): Remove unused variable `items_added'.
12304 * w32term.c (last_mouse_press_frame): Remove static global variable.
12305 (w32_clip_to_row): Remove unused variable `f'.
12306 (x_delete_terminal): Remove unused variable `i'.
12308 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12309 (NOTHING): Remove unused static global variable.
12310 (uniscribe_check_otf): Remove unused variable `table'.
12311 (uniscribe_font_driver): Add missing initializers.
12313 2011-03-23 Julien Danjou <julien@danjou.info>
12315 * term.c (Fsuspend_tty, Fresume_tty):
12316 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12317 * window.c (temp_output_buffer_show):
12318 * insdel.c (signal_before_change):
12319 * frame.c (Fhandle_switch_frame):
12320 * fileio.c (Fdo_auto_save):
12321 * emacs.c (Fkill_emacs):
12322 * editfns.c (save_excursion_restore):
12323 * cmds.c (internal_self_insert):
12324 * callint.c (Fcall_interactively):
12325 * buffer.c (Fkill_all_local_variables):
12326 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12328 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12329 unconditionally since it does the check itself.
12331 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12333 Fix more problems found by GCC 4.5.2's static checks.
12335 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12336 the first time through the loop, since we know p0 < p1 then.
12337 This also avoids a gcc -Wstrict-overflow warning.
12339 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12340 leading to a memory leak, possible in functions like
12341 load_charset_map_from_file that can allocate an unbounded number
12342 of objects (Bug#8318).
12344 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12345 that could (at least in theory) be that large.
12347 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12348 This is less likely to overflow, and avoids undefined behavior if
12349 overflow does occur. All callers changed. Use strtoul to scan
12350 for the unsigned long integer.
12351 (pint2hrstr): Simplify and tune code slightly.
12352 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12354 * scroll.c (do_scrolling): Work around GCC bug 48228.
12355 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12357 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12358 This also avoids a warning with gcc -Wstrict-overflow.
12359 (validate_x_resource_name): Simplify count usage.
12360 This also avoids a warning with gcc -Wstrict-overflow.
12362 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12365 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12367 * process.c (Fmake_network_process): Use socklen_t, not int,
12368 where POSIX says socklen_t is required in portable programs.
12369 This fixes a porting bug on hosts like 64-bit HP-UX, where
12370 socklen_t is wider than int (Bug#8277).
12371 (Fmake_network_process, server_accept_connection):
12372 (wait_reading_process_output, read_process_output):
12375 * process.c: Rename or move locals to avoid shadowing.
12376 (list_processes_1, Fmake_network_process):
12377 (read_process_output_error_handler, exec_sentinel_error_handler):
12378 Rename or move locals.
12379 (Fmake_network_process): Define label "retry_connect" only if needed.
12380 (Fnetwork_interface_info): Fix pointer signedness.
12381 (process_send_signal): Add cast to avoid pointer signedness problem.
12382 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12383 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12385 Make tparam.h and terminfo.c consistent.
12386 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12387 Include tparam.h instead, since it declares them.
12388 * cm.h (PC): Remove extern decl; tparam.h now does this.
12389 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12390 * terminfo.c: Include tparam.h, to check interfaces.
12391 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12392 (tparam): Adjust signature to match interface in tparam.h;
12393 this removes some undefined behavior. Check that outstring and len
12394 are zero, which they always are with Emacs.
12395 * tparam.h (PC, BC, UP): New extern decls.
12397 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12398 (xftfont_open): Rename locals to avoid shadowing.
12400 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12401 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12402 (OTF_TAG_SYM): Omit macro if not needed.
12403 (ftfont_list): Remove unused local.
12404 (get_adstyle_property, ftfont_pattern_entity):
12405 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12406 Rename locals to avoid shadowing.
12408 * xfont.c (xfont_list_family): Mark var as initialized.
12410 * xml.c (make_dom): Now static.
12412 * composite.c (composition_compute_stop_pos): Rename local to
12414 (composition_reseat_it): Remove unused locals.
12415 (find_automatic_composition, composition_adjust_point): Likewise.
12416 (composition_update_it): Mark var as initialized.
12417 (find_automatic_composition): Mark vars as initialized,
12418 with a FIXME (Bug#8290).
12420 character.h: Rename locals to avoid shadowing.
12421 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12422 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12423 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12424 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12425 to avoid shadowing.
12427 * textprop.c (property_change_between_p): Remove; unused.
12429 * intervals.c (interval_start_pos): Now static.
12431 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12433 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12434 Rename locals to avoid shadowing.
12436 * sound.c (wav_play, au_play, Fplay_sound_internal):
12437 Fix pointer signedness.
12438 (alsa_choose_format): Remove unused local var.
12439 (wav_play): Initialize a variable to 0, to prevent undefined
12440 behavior (Bug#8278).
12442 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12444 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12447 clobbering (Bug#8298).
12448 * sysdep.c (sys_subshell): Likewise.
12449 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12451 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12452 This should get cleaned up, so that child_setup has the
12453 same signature on all platforms.
12455 * callproc.c (call_process_cleanup): Now static.
12456 (relocate_fd): Rename locals to avoid shadowing.
12458 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12460 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12461 not to be necessary, and produces flickering.
12463 2011-03-20 Glenn Morris <rgm@gnu.org>
12465 * config.in: Remove file.
12467 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12469 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12470 are now in src/globals.h.
12471 (syms_of_minibuf): Remove spurious & from previous change.
12473 2011-03-20 Leo Liu <sdl.web@gmail.com>
12475 * minibuf.c (completing-read-function): New variable.
12476 (completing-read-default): Rename from completing-read.
12477 (completing-read): Call completing-read-function.
12479 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12481 * xfaces.c (Fx_load_color_file):
12482 Read color file from absolute filename (bug#8250).
12484 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12486 * makefile.w32-in: Update dependencies.
12488 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12490 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12492 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12494 Fix more problems found by GCC 4.5.2's static checks.
12496 * process.c (make_serial_process_unwind, send_process_trap):
12497 (sigchld_handler): Now static.
12499 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12500 That way, the code declares only the vars that it needs.
12501 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12502 * s/cygwin.h (PTY_ITERATION): Likewise.
12503 * s/darwin.h (PTY_ITERATION): Likewise.
12504 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12506 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12507 * process.c (allocate_pty): Don't declare stb unless it's needed.
12509 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12510 (CONSTANTLIM): Remove; unused.
12511 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12512 Define only if needed.
12514 * unexelf.c (unexec): Name an expression,
12515 to avoid gcc -Wbad-function-cast warning.
12516 Use a different way to cause a compilation error if anyone uses
12517 n rather than nn, a way that does not involve shadowing.
12518 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12520 * deps.mk (unexalpha.o): Remove; unused.
12522 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12523 * unexec.h: New file.
12524 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12525 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12526 Depend on unexec.h.
12527 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12528 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12529 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12530 Change as necessary to match prototype in unexec.h.
12532 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12534 (back_comment, skip_chars): Mark vars as initialized.
12536 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12537 Rename locals to avoid shadowing.
12539 * lread.c (read1): Rewrite so as not to use empty "else".
12540 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12542 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12544 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12545 warning when compiling print.c.
12547 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12548 instead of using an uninitialized var.
12549 (font_sort_entities): Mark var as initialized.
12551 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12553 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12554 pointers to constants.
12555 (font_parse_fcname): Remove unused vars.
12556 (font_delete_unmatched): Now static.
12557 (font_get_spec): Remove; unused.
12558 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12559 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12560 Rename or move locals to avoid shadowing.
12562 * fns.c (require_nesting_list, require_unwind): Now static.
12563 (Ffillarray): Rename locals to avoid shadowing.
12565 * floatfns.c (domain_error2): Define only if needed.
12566 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12568 * alloc.c (mark_backtrace): Move decl from here ...
12569 * lisp.h: ... to here, so that it can be checked.
12571 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12572 (Fdefvar): Rewrite so as not to use empty "else".
12573 (lisp_indirect_variable): Name an expression,
12574 to avoid gcc -Wbad-function-cast warning.
12575 (Fdefvar): Rename locals to avoid shadowing.
12577 * callint.c (quotify_arg, quotify_args): Now static.
12578 (Fcall_interactively): Rename locals to avoid shadowing.
12579 Use const pointer when appropriate.
12581 * lisp.h (get_system_name, get_operating_system_release):
12582 Move decls here, to check interfaces.
12583 * process.c (get_operating_system_release): Move decl to lisp.h.
12584 * xrdb.c (get_system_name): Likewise.
12585 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12586 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12587 some of which prompt warnings from gcc -Wbad-function-cast.
12588 (Fformat_time_string, Fencode_time, Finsert_char):
12589 (Ftranslate_region_internal, Fformat):
12590 Rename or remove local vars to avoid shadowing.
12591 (Ftranslate_region_internal): Mark var as initialized.
12593 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12596 * lisp.h (eassert): Check that the argument compiles, even if
12597 ENABLE_CHECKING is not defined.
12599 * data.c (Findirect_variable): Name an expression, to avoid
12600 gcc -Wbad-function-cast warning.
12601 (default_value, arithcompare, arith_driver, arith_error): Now static.
12602 (store_symval_forwarding): Rename local to avoid shadowing.
12603 (Fmake_variable_buffer_local, Fmake_local_variable):
12604 Mark variables as initialized.
12605 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12607 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12608 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12609 Rename locals to avoid shadowing.
12610 (mark_stack): Move local variables into the #ifdef region where
12612 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12613 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12615 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12616 (GC_STRING_CHARS): Remove; not used.
12617 (Fmemory_limit): Cast sbrk's returned value to char *.
12619 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12620 avoids undefined behavior in theory.
12622 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12624 Use functions, not macros, for up- and down-casing (Bug#8254).
12625 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12627 to use the following functions instead of these macros.
12628 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12629 EMACS_INT, since callers assume the returned value fits in int.
12630 (upcase1): Likewise, for UPCASE_TABLE.
12631 (uppercasep, lowercasep, upcase): New static inline functions.
12632 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12633 the race-condition problem in the old DOWNCASE.
12635 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12636 Rename locals to avoid shadowing.
12637 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12638 (regex_compile, re_search_2, re_match_2_internal):
12639 Remove unused local vars.
12640 (FREE_VAR): Rewrite so as not to use empty "else",
12641 which gcc can warn about.
12642 (regex_compile, re_match_2_internal): Mark locals as initialized.
12643 (RETALLOC_IF): Define only if needed.
12644 (WORDCHAR_P): Likewise. This one is never needed, but is used
12645 only in a comment talking about a compiler bug, so put inside
12646 the #if 0 of that comment.
12647 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12648 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12651 * search.c (boyer_moore): Rename locals to avoid shadowing.
12652 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12653 (PREV_CHAR_BOUNDARY): Likewise.
12655 * search.c (simple_search): Remove unused var.
12657 * dired.c (compile_pattern): Move decl from here ...
12658 * lisp.h: ... to here, so that it can be checked.
12659 (struct re_registers): New forward decl.
12661 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12663 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12665 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12666 Rename locals to avoid shadowing.
12667 (Fvertical_motion): Mark locals as initialized.
12669 * casefiddle.c (casify_object, casify_region): Now static.
12670 (casify_region): Mark local as initialized.
12672 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12674 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12675 New macros, so that the caller can use some names other than
12676 gcpro1, gcpro2, etc.
12677 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12679 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12680 argument, for consistency with GCPRO2_VAR, etc: it is now the
12681 prefix of the variable, not the variable itself. All uses
12683 * dired.c (directory_files_internal, file_name_completion):
12684 Rename locals to avoid shadowing.
12686 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12687 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12688 dired.c's scmp function, had undefined behavior.
12689 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12691 * buffer.h: ... to here, because these macros use current_buffer,
12692 and the new implementation with inline functions needs to have
12693 current_buffer in scope now, rather than later when the macros
12695 (downcase, upcase1): New static inline functions.
12696 (DOWNCASE, UPCASE1): Reimplement using these functions.
12697 This avoids undefined behavior in expressions like
12698 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12699 from race conditions in accessing the global variables
12700 case_temp1 and case_temp2.
12701 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12702 * lisp.h (case_temp1, case_temp2): Remove their decls.
12703 * character.h (ASCII_CHAR_P): Move from here ...
12704 * lisp.h: ... to here, so that the inline functions mentioned
12705 above can use them.
12707 * dired.c (directory_files_internal_unwind): Now static.
12709 * fileio.c (file_name_as_directory, directory_file_name):
12710 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12712 (file_name_as_directory): Use const pointers when appropriate.
12713 (Fexpand_file_name): Likewise. In particular, newdir might
12714 point at constant storage, so make it a const pointer.
12715 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12716 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12718 (Fset_file_times, Finsert_file_contents, auto_save_error):
12719 Rename locals to avoid shadowing.
12721 * minibuf.c (choose_minibuf_frame_1): Now static.
12722 (Ftry_completion, Fall_completions): Rename or remove locals
12723 to avoid shadowing.
12725 * marker.c (bytepos_to_charpos): Remove; unused.
12727 * lisp.h (verify_bytepos, count_markers): New decls,
12728 so that gcc does not warn that these functions aren't declared.
12730 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12731 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12732 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12733 (copy_text): Remove unused local var.
12735 * filelock.c (within_one_second): Now static.
12736 (lock_file_1): Rename local to avoid shadowing.
12738 * buffer.c (fix_overlays_before): Mark locals as initialized.
12739 (fix_start_end_in_overlays): Likewise. This function should be
12740 simplified by using pointers-to-pointers, but that's a different
12742 (switch_to_buffer_1): Now static.
12743 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12744 (report_overlay_modification): Rename locals to avoid shadowing.
12746 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12747 Fix pointer signedness issue.
12748 (sys_subshell): Mark local as volatile if checking for lint,
12749 to suppress a gcc -Wclobbered warning that does not seem to be right.
12750 (MAXPATHLEN): Define only if needed.
12752 * process.c (serial_open, serial_configure): Move decls from here ...
12753 * systty.h: ... to here, so that they can be checked.
12755 * fns.c (get_random, seed_random): Move extern decls from here ...
12756 * lisp.h: ... to here, so that they can be checked.
12758 * sysdep.c (reset_io): Now static.
12759 (wait_for_termination_signal): Remove; unused.
12761 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12762 (copy_keymap_item, append_key, push_text_char_description):
12764 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12765 (DENSE_TABLE_SIZE): Remove; unused.
12766 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12767 (describe_map_tree):
12768 Rename locals to avoid shadowing.
12770 * keyboard.c: Declare functions static if they are not used elsewhere.
12771 (echo_char, echo_dash, cmd_error, top_level_2):
12772 (poll_for_input, handle_async_input): Now static.
12773 (read_char, kbd_buffer_get_event, make_lispy_position):
12774 (make_lispy_event, make_lispy_movement, apply_modifiers):
12775 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12776 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12777 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12778 (read_key_sequence, read_char): Mark locals as initialized.
12779 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12781 * keyboard.h (make_ctrl_char): New decl.
12782 (mark_kboards): Move decl here ...
12783 * alloc.c (mark_kboards): ... from here.
12785 * lisp.h (force_auto_save_soon): New decl.
12787 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12788 (DEFINE_DUMMY_FUNCTION): New macro.
12789 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12791 (main): Add casts to avoid warnings
12792 if GCC considers string literals to be constants.
12794 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12796 * dbusbind.c: Pointer signedness fixes.
12797 (xd_signature, xd_append_arg, xd_initialize):
12798 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12800 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12801 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12803 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12804 if GCC considers string literals to be constants.
12805 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12807 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12809 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12810 (print_preprocess, print_object): New macro to fix last change.
12812 * print.c (print_preprocess): Don't forget font objects.
12814 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12816 * emacs.c (USAGE3): Doc fixes.
12818 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12820 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12823 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12825 * lisp.h (VWindow_system, Qfile_name_history):
12826 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12827 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12828 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12830 * w32select.c: Don't #include "keyboard.h".
12831 (run_protected): Add extern declaration for waiting_for_input.
12833 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12834 * w32console.c (detect_input_pending, read_input_pending)
12835 (encode_terminal_code):
12836 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12837 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12838 (w32_system_caret_y, Qfile_name_history):
12839 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12840 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12841 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12842 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12843 * w32proc.c (Qlocal, report_file_error):
12844 * w32term.c (Vwindow_system, updating_frame):
12845 * w32uniscribe.c (initialized, uniscribe_font_driver):
12846 Remove unneeded extern declarations.
12848 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12850 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12852 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12854 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12855 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12856 These macros can no longer be used for assignment.
12858 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12859 Assign struct members directly, instead of using BUF_BEGV etc.
12860 (record_buffer_markers, fetch_buffer_markers): New functions for
12861 recording and fetching special buffer markers.
12862 (set_buffer_internal_1, set_buffer_temp): Use them.
12864 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12866 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12868 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12869 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12871 * xdisp.c (hscroll_window_tree):
12872 (reconsider_clip_changes): Use PT instead of BUF_PT.
12874 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12876 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12877 $(EMACS_ROOT)/lib/intprops.h.
12879 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12881 Fix more problems found by GCC 4.5.2's static checks.
12883 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12884 to unsigned char * to avoid compiler diagnostic.
12885 (xg_free_frame_widgets): Make it clear that a local variable is
12886 needed only if USE_GTK_TOOLTIP.
12887 (gdk_window_get_screen): Make it clear that this macro is needed
12888 only if USE_GTK_TOOLTIP.
12889 (int_gtk_range_get_value): New function, which avoids a diagnostic
12890 from gcc -Wbad-function-cast.
12891 (xg_set_toolkit_scroll_bar_thumb): Use it.
12892 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12893 diagnostic from gcc -Wbad-function-cast.
12894 (get_utf8_string, xg_get_file_with_chooser):
12895 Rename locals to avoid shadowing.
12896 (create_dialog): Move locals to avoid shadowing.
12898 * xgselect.c (xg_select): Remove unused var.
12900 * image.c (four_corners_best): Mark locals as initialized.
12901 (gif_load): Initialize transparent_p to zero (Bug#8238).
12902 Mark another local as initialized.
12903 (my_png_error, my_error_exit): Mark with NO_RETURN.
12905 * image.c (clear_image_cache): Now static.
12906 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12907 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12908 (x_edge_detection): Remove unnecessary cast that
12909 gcc -Wbad-function-cast diagnoses.
12910 (gif_load): Fix pointer signedness.
12911 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12912 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12914 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12916 Improve quality of tests for time stamp overflow.
12917 For example, without this patch (encode-time 0 0 0 1 1
12918 1152921504606846976) returns the obviously-bogus value (-948597
12919 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12920 reports time overflow. See
12921 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12922 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12923 * editfns.c: Include limits.h and intprops.h.
12924 (TIME_T_MIN, TIME_T_MAX): New macros.
12925 (time_overflow): Move earlier, to before first use.
12926 (hi_time, lo_time): New functions, for an accurate test for
12927 out-of-range times.
12928 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12929 (Fget_internal_run_time): Don't assume time_t fits in int.
12930 (make_time): Use list2 instead of Fcons twice.
12931 (Fdecode_time): More accurate test for out-of-range times.
12932 (check_tm_member): New function.
12933 (Fencode_time): Use it, to test for out-of-range times.
12934 (lisp_time_argument): Don't rely on undefined left-shift and
12935 right-shift behavior when checking for time stamp overflow.
12937 * editfns.c (time_overflow): New function, refactoring common code.
12938 (Fformat_time_string, Fdecode_time, Fencode_time):
12939 (Fcurrent_time_string): Use it.
12941 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12942 * dired.c (make_time): Move to ...
12943 * editfns.c (make_time): ... here.
12944 * systime.h: Note the move.
12946 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12948 * fringe.c (update_window_fringes): Remove unused variables.
12950 * unexmacosx.c (copy_data_segment): Also copy __got section.
12953 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12955 * termcap.c [MSDOS]: Include "msdos.h".
12956 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12957 Constify `char *' arguments and their references according to
12958 prototypes in tparam.h.
12960 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12962 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12963 Adapt all references accordingly.
12965 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12967 2011-03-11 Tom Tromey <tromey@redhat.com>
12969 * buffer.c (syms_of_buffer): Remove obsolete comment.
12971 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12973 * termhooks.h (encode_terminal_code): Declare prototype.
12975 * msdos.c (encode_terminal_code): Don't declare prototype.
12977 * term.c (encode_terminal_code): Now external again, used by
12978 w32console.c and msdos.c.
12980 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12981 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12983 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12985 Fix some minor problems found by GCC 4.5.2's static checks.
12987 * fringe.c (update_window_fringes): Mark locals as initialized
12989 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12991 * alloc.c (mark_fringe_data): Move decl from here ...
12992 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12993 to check its interface.
12994 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12996 * fontset.c (free_realized_fontset): Now static.
12997 (Fset_fontset_font): Rename local to avoid shadowing.
12998 (fontset_font): Mark local as initialized.
12999 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13001 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13003 * xselect.c (x_disown_buffer_selections): Remove; not used.
13004 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13005 (x_own_selection, Fx_disown_selection_internal): Rename locals
13006 to avoid shadowing.
13007 (x_handle_dnd_message): Remove local to avoid shadowing.
13009 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13010 so that the caller can use some name other than gcpro1.
13011 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13012 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13013 (Fx_backspace_delete_keys_p):
13014 Use them to avoid shadowing, and rename vars to avoid shadowing.
13015 (x_decode_color, x_set_name, x_window): Now static.
13016 (Fx_create_frame): Add braces to silence GCC warning.
13017 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13018 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13019 Remove unused locals.
13020 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13021 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13022 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13025 * xterm.h (x_mouse_leave): New decl.
13027 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13028 Remove unused functions.
13029 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13030 (x_calc_absolute_position): Now static.
13031 (XTread_socket): Don't define label "out" unless it's used.
13032 Don't declare local "event" unless it's used.
13033 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13034 unless they are used.
13035 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13036 (x_fatal_error_signal): Remove; not used.
13037 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13038 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13039 (x_error_catcher, x_connection_closed, x_error_handler):
13040 (x_error_quitter, xembed_send_message, x_iconify_frame):
13041 (my_log_handler): Rename locals to avoid shadowing.
13042 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13043 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13045 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13046 Rename or move locals to avoid shadowing.
13047 (tty_defined_color, merge_face_heights): Now static.
13048 (free_realized_faces_for_fontset): Remove; not used.
13049 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13050 does not deduce is never used uninitialized.
13051 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13052 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13054 * terminal.c (store_terminal_param): Now static.
13056 * xmenu.c (menu_highlight_callback): Now static.
13057 (set_frame_menubar): Remove unused local.
13058 (xmenu_show): Rename parameter to avoid shadowing.
13059 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13060 since they might point to immutable storage.
13061 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13062 since it's unused otherwise.
13064 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13065 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13066 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13067 avoids a gcc -Wuninitialized diagnostic.
13068 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13069 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13070 does not deduce are never used uninitialized.
13072 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13074 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13075 * window.c (window_loop, size_window):
13076 (run_window_configuration_change_hook, enlarge_window): Likewise.
13078 * window.c (display_buffer): Now static.
13079 (size_window): Mark variables that gcc -Wuninitialized
13080 does not deduce are never used uninitialized.
13081 * window.h (check_all_windows): New decl, to forestall
13082 gcc -Wmissing-prototypes diagnostic.
13083 * dispextern.h (bidi_dump_cached_states): Likewise.
13085 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13087 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13088 Include <limits.h>.
13089 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13090 and to avoid gcc -Wuninitialized warning.
13091 (load_charset_map): Mark variables that gcc -Wuninitialized
13092 does not deduce are never used uninitialized.
13093 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13095 * coding.c (coding_set_source, coding_set_destination):
13096 Use "else { /* comment */ }" rather than "else /* comment */;"
13097 for clarity, and to avoid gcc -Wempty-body warning.
13098 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13099 a block, when the outer 'i' will do.
13100 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13101 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13103 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13104 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13105 Rename locals to avoid shadowing.
13106 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13107 * coding.c (emacs_mule_char, encode_invocation_designation):
13108 Now static, since they're not used elsewhere.
13109 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13110 (decode_coding_object, encode_coding_object, detect_coding_system):
13111 (decode_coding_emacs_mule): Mark variables that gcc
13112 -Wuninitialized does not deduce are never used uninitialized.
13113 (detect_coding_iso_2022): Initialize a local variable that might
13114 be used uninitialized. Leave a FIXME because it's not clear that
13115 this initialization is needed. (Bug#8211)
13116 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13117 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13118 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13119 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13120 Remove unused macros.
13122 * category.c (hash_get_category_set): Remove unused local var.
13123 (copy_category_table): Now static, since it's not used elsewhere.
13124 * character.c (string_count_byte8): Likewise.
13126 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13127 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13129 * chartab.c (copy_sub_char_table): Now static, since it's not used
13131 (sub_char_table_ref_and_range, char_table_ref_and_range):
13132 Rename locals to avoid shadowing.
13133 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13135 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13136 (BIDI_BOB): Remove unused macro.
13138 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13139 deduce are never used uninitialized.
13140 * term.c (encode_terminal_code): Likewise.
13142 * term.c (encode_terminal_code): Now static. Remove unused local.
13144 * tparam.h: New file.
13145 * term.c, tparam.h: Include it.
13146 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13147 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13148 Move these decls to tparam.h, and make them agree with what
13149 is actually in tparam.c. The previous trick of using incompatible
13150 decls in different modules does not conform to the C standard.
13151 All callers of tparam changed to use tparam's actual API.
13152 * tparam.c (tparam1, tparam, tgoto):
13153 Use const pointers where appropriate.
13155 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13156 * cm.h (struct cm): Likewise.
13157 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13158 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13159 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13160 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13161 (turn_on_face, init_tty): Likewise.
13162 * termchar.h (struct tty_display_info): Likewise.
13164 * term.c (term_mouse_position): Rename local to avoid shadowing.
13166 * alloc.c (mark_ttys): Move decl from here ...
13167 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13169 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13171 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13173 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13175 * search.c (compile_pattern_1): Remove argument regp, unused since
13176 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13177 (compile_pattern): Don't pass it.
13179 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13181 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13182 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13184 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13186 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13188 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13189 gdk_window_get_screen, gdk_window_get_geometry,
13190 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13191 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13192 (xg_get_pixbuf_from_pixmap): New function.
13193 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13194 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13195 Call xg_get_pixbuf_from_pixmap instead of
13196 gdk_pixbuf_get_from_drawable.
13197 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13198 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13199 (xg_check_special_colors): Use GtkStyleContext and its functions
13201 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13202 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13203 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13204 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13205 Call gtk_widget_get_preferred_size.
13206 (xg_frame_resized): gdk_window_get_geometry only takes 5
13208 (xg_win_to_widget, xg_event_is_for_menubar):
13209 Call gdk_x11_window_lookup_for_display.
13210 (xg_set_widget_bg): New function.
13211 (delete_cb): New function.
13212 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13213 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13214 (xg_set_background_color): Call xg_set_widget_bg.
13215 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13216 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13217 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13218 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13220 (update_frame_tool_bar): Call gtk_widget_hide.
13221 (xg_initialize): Use GDK_KEY_g.
13223 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13225 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13227 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13228 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13229 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13231 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13233 * w32xfns.c (select_palette): Check success of RealizePalette against
13234 GDI_ERROR, not zero.
13236 See ChangeLog.11 for earlier changes.
13238 ;; Local Variables:
13242 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13244 This file is part of GNU Emacs.
13246 GNU Emacs is free software: you can redistribute it and/or modify
13247 it under the terms of the GNU General Public License as published by
13248 the Free Software Foundation, either version 3 of the License, or
13249 (at your option) any later version.
13251 GNU Emacs is distributed in the hope that it will be useful,
13252 but WITHOUT ANY WARRANTY; without even the implied warranty of
13253 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13254 GNU General Public License for more details.
13256 You should have received a copy of the GNU General Public License
13257 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.