1 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
7 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
8 not defined (Bug#11768).
9 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
10 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
11 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
12 followed by gtk_box_set_homogeneous (Bug#11768).
13 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
14 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
15 gtk_scrollbar_new (Bug#11768).
16 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
17 (is_box_type): New function (Bug#11768).
18 (xg_tool_item_stale_p): Call is_box_type.
19 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
20 with default display (Bug#11768).
22 2012-07-05 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (window_hscroll_limited): New function.
25 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
26 coordinates when window's hscroll is set to insanely large
29 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
31 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
32 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
34 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
37 * lisp.h (xzalloc): New prototype. Omit needless casts.
38 * alloc.c (xzalloc): New function. Omit needless casts.
39 * charset.c: Omit needless casts. Convert all calls to
40 xmalloc with following memset to xzalloc.
41 * dispnew.c: Likewise.
47 * w32font.c: Likewise.
48 * w32term.c: Likewise.
52 * atimer.c: Omit needless casts.
54 * callproc.c: Likewise.
57 * composite.c: Likewise.
60 * editfns.c: Likewise.
63 * filelock.c: Likewise.
65 * gtkutil.c: Likewise.
66 * keyboard.c: Likewise.
69 * minibuf.c: Likewise.
72 * process.c: Likewise.
73 * region-cache.c: Likewise.
76 * termcap.c: Likewise.
77 * terminal.c: Likewise.
79 * w16select.c: Likewise.
82 * w32select.c: Likewise.
83 * w32uniscribe.c: Likewise.
88 * xselect.c: Likewise.
90 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
92 * fileio.c (time_error_value): Check the right error number.
93 Problem reported by Troels Nielsen in
94 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
96 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
98 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
99 This should be fixed in a better way; see Eli Zaretskii in
100 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
101 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
103 * fileio.c (time_error_value): Rename from special_mtime.
104 The old name's problems were noted by Eli Zaretskii in
105 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
107 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
108 This variable's comment says Emacs needs at least one GDB-visible
109 symbol of type enum pvec_type, to work around GDB problems.
110 The symbol's value doesn't matter.
112 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
113 that causes compilation to fail on pre-C99 compilers.
115 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
117 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
118 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
120 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
122 * buffer.c (init_buffer_once): Fix initialization of
123 headers for buffer_defaults and buffer_local_symbols.
124 Reported by Juanma Barranquero <lekktu@gmail.com>.
126 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
128 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
129 * lisp.h (enum pvec_type): Use fewer bits.
130 (PSEUDOVECTOR_SIZE_BITS): New constant.
131 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
132 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
134 (PSEUDOVECTOR_TYPEP): New macro.
135 (TYPED_PSEUDOVECTORP): Use it.
136 * fns.c (internal_equal): Adapt code to extract pvectype.
137 * emacs.c (gdb_pvec_type): Update type.
138 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
139 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
140 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
141 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
142 (sweep_vectors): Use it. Use local var `total_bytes' instead of
143 abusing vector->header.next.nbytes.
144 (live_vector_p): Use PVEC_TYPE.
145 (mark_object): Adapt code to extract pvectype. Use switch.
147 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
149 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
150 Tighten new eassert a bit.
152 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
154 Fix compilation with --enable-gcc-warnings and -O1
156 * doprnt.c (doprnt): Change type of tem to int, initialize
157 to avoid compiler warning. Add eassert.
158 * search.c (simple_search): Initialize match_byte to avoid
159 compiler warning. Add eassert.
161 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
163 Avoid weird behavior with large horizontal scrolls.
164 Without this change, for example, large hscroll values would
165 mess up Emacs's display on Fedora 15 x86, presumably due to
166 overflows in int calculations in the display code.
167 Also, if buffers had long lines, Emacs would freeze.
168 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
169 (set_window_hscroll): New function, containing the old guts of
170 Fset_window_hscroll. Return the clipped value.
171 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
172 This avoids the need to check against PTRDIFF_MAX.
174 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
176 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
178 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
180 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
182 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
183 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
184 since GCC 4.4.6 issues a bogus warning for them.
186 Fix bugs in file timestamp newness comparisons.
187 * fileio.c (Ffile_newer_than_file_p):
188 * lread.c (Fload): Use full timestamp resolution of files,
189 not just the 1-second resolution, so that files that are only
190 slightly newer still count as newer.
191 * fileio.c (Ffile_newer_than_file_p): Don't assume file
192 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
194 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
196 * fileio.c: Improve handling of file time marker. (Bug#11852)
197 (special_mtime): New function.
198 (Finsert_file_contents, Fverify_visited_file_modtime):
199 Use it to set special mtime values consistently.
201 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
203 * fileio.c (Finsert_file_contents): Properly handle st_mtime
204 marker for non-existing file. (Bug#11852)
206 2012-07-03 Glenn Morris <rgm@gnu.org>
208 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
209 and did not make it into globals.h).
211 2012-07-03 Tom Tromey <tromey@redhat.com>
213 * window.c (Fset_window_margins, Fset_window_fringes)
214 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
215 * textprop.c (Fprevious_property_change): No longer static.
216 * syntax.c (Fsyntax_table_p): No longer static.
217 * process.c (Fget_process, Fprocess_datagram_address): No longer
219 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
220 * keyboard.c (Fcommand_execute): No longer static.
222 * insdel.c (Fcombine_after_change_execute): No longer static.
223 * image.c (Finit_image_library): No longer static.
224 * fileio.c (Fmake_symbolic_link): No longer static.
225 * eval.c (Ffetch_bytecode): No longer static.
226 * editfns.c (Fuser_full_name): No longer static.
227 * doc.c (Fdocumentation_property, Fsnarf_documentation):
229 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
231 * dired.c (Ffile_attributes): No longer static.
232 * composite.c (Fcomposition_get_gstring): No longer static.
233 * callproc.c (Fgetenv_internal): No longer static.
235 * ccl.h: Remove EXFUNs.
236 * buffer.h: Remove EXFUNs.
237 * dispextern.h: Remove EXFUNs.
238 * intervals.h: Remove EXFUNs.
239 * fontset.h: Remove EXFUN.
240 * font.h: Remove EXFUNs.
241 * dosfns.c (system_process_attributes): Remove EXFUN.
242 * keymap.h: Remove EXFUNs.
243 * lisp.h: Remove EXFUNs.
244 * w32term.h: Remove EXFUNs.
245 * window.h: Remove EXFUNs.
246 * xsettings.h: Remove EXFUN.
247 * xterm.h: Remove EXFUN.
249 2012-07-03 Glenn Morris <rgm@gnu.org>
251 * lisp.h (Frandom): Make it visible to C.
252 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
253 buffer for invisible buffers. (Bug#1229)
255 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
257 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
258 values which aren't power of 2.
259 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
260 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
263 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
265 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
267 * alloc.c (mark_object): Revert part of last patch to use `switch'.
269 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
271 * alloc.c (allocate_vector_block): Remove redundant
272 calls to mallopt if DOUG_LEA_MALLOC is defined.
273 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
274 avoid calls to mallopt if zero_vector is returned.
276 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
278 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
279 is enabled, avoid dereferencing NULL current_sblock if
282 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
284 Cleanup basic buffer management.
285 * buffer.h (struct buffer): Change layout to use generic vector
286 marking code. Fix some comments. Change type of 'clip_changed'
287 to bitfield. Remove unused #ifndef old.
288 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
289 (GET_OVERLAYS_AT): Fix indentation.
290 (for_each_per_buffer_object_at): New macro.
291 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
292 (Fbuffer_local_variables): Use it.
293 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
294 * alloc.c (allocate_buffer): Adjust to match new layout of
295 struct buffer. Fix comment.
296 (mark_overlay): New function.
297 (mark_buffer): Use it. Use mark_vectorlike to mark normal
298 Lisp area of struct buffer.
299 (mark_object): Use it. Adjust marking of misc objects
300 and related comments.
302 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
304 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
305 wrapper that is not needed because the wrapped code is a no-op (zero
306 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
307 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
309 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
311 * alloc.c (mark_buffer): Simplify. Remove prototype.
312 (mark_object): Add comment. Reorganize marking of vector-like
313 objects. Use CHECK_LIVE for all vector-like objects except buffers
314 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
315 redundant calls to mark_vectorlike for bool vectors.
317 2012-06-30 Glenn Morris <rgm@gnu.org>
319 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
321 * epaths.in (PATH_SITELOADSEARCH): New.
322 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
323 This is rather than relying on --enable-locallisppath elements
324 having "site-lisp" in their names. (Bug#10208#25, 11658)
326 2012-06-30 Eli Zaretskii <eliz@gnu.org>
328 * w32proc.c (sys_select): Accept and ignore one more argument.
330 * w32.c (emacs_gnutls_pull): Call select with one more argument.
332 * sysselect.h [DOS_NT]: Don't include sys/select.h.
333 (pselect) [!MS_DOS]: Redirect to sys_select.
335 * sysdep.c: Don't include dos.h and dosfns.h.
337 * process.c (sys_select):
338 * msdos.c (sys_select): Accept one more argument and ignore it.
340 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
341 adapt data types and code to that.
344 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
345 which clashes with the gnulib function of the same name.
347 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
349 * font.c (font_style_to_value, font_style_symbolic)
350 (font_prop_validate_style): Add type checks for values in
353 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
355 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
358 2012-06-29 Eli Zaretskii <eliz@gnu.org>
360 * xdisp.c (try_window_id): Undo last change.
362 * w32.c (getwd): Adjust commentary about startup_dir.
363 (init_environment): Always call sys_access, even in non-MSVC
364 builds. Don't chdir to the directory of the Emacs executable.
365 This undoes code from 1997 which was justified by the need to
366 "avoid conflicts when removing and renaming directories". But its
367 downside was that every relative file name was being interpreted
368 relative to the directory of the Emacs executable, which can never
369 be TRT. In particular, it broke sys_access when called with
371 (sys_access): Map GetLastError to errno.
373 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
375 * window.h (struct window): Change type of 'fringes_outside_margins'
376 to bitfield. Fix comment. Adjust users accordingly.
377 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
379 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
382 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
384 * gnutls.c (emacs_gnutls_handshake):
385 Add QUIT to make the loop interruptible.
387 2012-06-29 Glenn Morris <rgm@gnu.org>
389 * charset.c (init_charset): Make lack of etc/charsets fatal.
391 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
393 * editfns.c (region_limit): Fix type mismatch.
395 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
397 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
398 undefined. Convert from xassert to eassert.
399 * nsmenu.m: Convert from xassert to eassert.
400 * nsterm.m: Likewise.
402 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
404 * editfns.c (region_limit): Clip to narrowing (bug#11770).
406 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
408 Avoid integer overflow on scroll-left and scroll-right.
409 * window.c (HSCROLL_MAX): New macro.
410 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
411 overflow when requested scroll falls outside ptrdiff_t range.
413 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
415 * window.h (struct window): Change type of 'hscroll',
416 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
417 'last_modified' and 'last_overlay_modified' to EMACS_INT.
418 Adjust users accordingly.
419 * xdisp.c (try_cursor_movement): Replace type check with eassert.
420 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
421 from EMACS_INT to ptrdiff_t.
422 (make_window): Omit redundant initialization.
424 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
426 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
428 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
430 * window.h (struct window): Change type of 'use_time' and
431 'sequence_number' from Lisp_Object to int.
432 * frame.c (make_frame): Adjust users accordingly.
433 * print.c (print_object): Likewise.
434 * window.c (select_window, Fwindow_use_time, make_parent_window)
435 (make_window): Likewise.
437 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
439 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
440 enabled with --enable-checking=[all,glyphs] configure option.
441 Fix GLYPH_DEBUG usage assuming that it may be undefined,
442 adjust comments accordingly.
443 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
444 undefined, adjust comments accordingly.
446 * scroll.c: Likewise.
447 * w32fns.c: Likewise.
448 * w32term.c: Likewise.
450 * xfaces.c: Likewise.
454 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
456 Generalize run-time debugging checks.
457 * dispextern.h (XASSERTS): Remove.
458 * fontset.c (xassert): Remove.
459 Convert from xassert to eassert.
460 * alloc.c: Convert from xassert to eassert.
462 * dispnew.c: Likewise.
464 * fringe.c: Likewise.
465 * ftfont.c: Likewise.
466 * gtkutil.c: Likewise.
468 * keyboard.c: Likewise.
470 * process.c: Likewise.
471 * scroll.c: Likewise.
474 * w32console.c: Likewise.
475 * w32fns.c: Likewise.
476 * w32term.c: Likewise.
477 * window.c: Likewise.
479 * xfaces.c: Likewise.
481 * xselect.c: Likewise.
484 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
486 * fns.c (maybe_resize_hash_table): Output message when growing the
489 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
491 * alloc.c (allocate_string_data): Remove dead code.
492 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
493 avoid GCC warning about unused macro.
495 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
497 * alloc.c (allocate_string): Omit intervals initialization.
498 * alloc.c (make_uninit_multibyte_string): Initialize intervals
499 as in make_pure_string and make_pure_c_string.
501 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
503 * alloc.c (allocate_string): Fix last change.
505 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
507 * alloc.c (allocate_string): Remove two redundant calls
508 to memset, add explicit initialization where appropriate.
510 2012-06-27 Glenn Morris <rgm@gnu.org>
512 * lisp.mk (lisp): Remove paths.elc.
514 2012-06-27 Chong Yidong <cyd@gnu.org>
516 * doc.c (Fsubstitute_command_keys): Fix punctuation.
518 2012-06-26 John Wiegley <johnw@newartisans.com>
520 * unexmacosx.c (copy_data_segment): Add two section names used
521 on Mac OS X Lion: __mod_init_func and __mod_term_func.
523 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
524 when building with Clang.
526 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
528 * eval.c (Fapply): Allow calling it with a single argument.
530 2012-06-26 Eli Zaretskii <eliz@gnu.org>
532 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
533 _stricmp and _strnicmp.
534 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
536 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
538 * alloc.c (allocate_window): Zero out non-Lisp part of newly
540 (allocate_process): Likewise for new process.
541 (allocate_terminal): Change to use offsetof.
542 (allocate_frame): Likewise.
543 * frame.c (make_frame): Omit redundant initialization.
544 * window.c (make_parent_window): Use memset.
545 (make_window): Omit redundant initialization.
546 * process.c (make_process): Omit redundant initialization.
547 * terminal.c (create_terminal): Likewise.
549 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
551 * term.c (delete_tty): Remove redundant call to memset.
553 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
555 * alloc.c: Remove build_string.
556 * lisp.h: Define build_string as static inline. This provides
557 a better opportunity to optimize away calls to strlen when the
558 function is called with compile-time constant argument.
559 * image.c (imagemagick_error): Convert to build_string.
560 * w32proc.c (sys_spawnve): Likewise.
561 * xterm.c (x_term_init): Likewise.
563 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
565 Use sprintf return value instead of invoking strlen on result.
566 In the old days this wasn't portable, since some sprintf
567 implementations returned char *. But they died out years ago and
568 Emacs already assumes sprintf returns int.
569 Similarly for float_to_string.
570 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
571 * ccl.c (ccl_driver):
572 * character.c (string_escape_byte8):
573 * data.c (Fnumber_to_string):
575 * print.c (print_object):
576 * xdisp.c (message_dolog):
577 * xfns.c (syms_of_xfns):
578 Use sprintf or float_to_string result to avoid need to call strlen.
579 * data.c (Fnumber_to_string):
580 Use make_unibyte_string, since the string must be ASCII.
581 * lisp.h, print.c (float_to_string): Now returns int length.
582 * term.c (produce_glyphless_glyph):
583 Use sprintf result rather than recomputing it.
585 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
586 * Makefile.in (ALL_CFLAGS):
587 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
588 * gmalloc.c, regex.c: Include <config.h> unconditionally.
590 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
592 * dispextern.h (xstrcasecmp): Define to library function
593 strcasecmp if available.
594 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
596 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
598 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
599 Avoid comma operator.
600 * menu.c (push_submenu_start, push_submenu_end)
601 (push_left_right_boundary, push_menu_pane): Likewise.
602 * msdos.c (dos_rawgetc): Likewise.
604 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
606 * xfns.c (xic_create_fontsetname): Remove redundant calls
609 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
611 * gtkutil.c (get_utf8_string): Remove redundant assignment.
612 sprintf already null-terminates its output.
614 * xfns.c (x_window): Remove redundant cast.
616 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
618 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
619 `const char *' to `char *' to avoid compiler warning.
621 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
623 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
624 instead of truncating it to 63 (admittedly a generous limit).
626 * process.c: Fix spelling and caps in comments.
628 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
630 * emacs.c (setpgrp): Remove definition, unused.
631 * sysdep.c (setpgrp): Remove definition, not used in this file.
633 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
635 * makefile.w32-in: Update dependencies.
637 2012-06-24 Eli Zaretskii <eliz@gnu.org>
639 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
640 (SYSTIME_H): Add nt/inc/sys/time.h.
642 * systime.h [WINDOWSNT]: Include sys/time.h.
644 * s/ms-w32.h (struct timespec): Definition moved from
645 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
647 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
649 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
650 * buffer.h (buffer_slot_type_mismatch):
651 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
652 * eval.c (unwind_to_catch):
653 * image.c (my_png_error, my_error_exit):
654 * keyboard.c (quit_throw_to_read_char, user_error)
655 (Fexit_recursive_edit, Fabort_recursive_edit):
656 * lisp.h (die, args_out_of_range, args_out_of_range_3)
657 (wrong_type_argument, buffer_overflow, __executable_start)
658 (memory_full, buffer_memory_full, string_overflow, Fthrow)
659 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
660 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
662 (child_setup) [!DOS_NT]:
663 * lread.c (end_of_file_error, invalid_syntax):
664 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
665 * puresize.h (pure_write_error):
666 * search.c (matcher_overflow):
667 * sound.c (sound_perror, alsa_sound_perror):
668 * sysdep.c, syssignal.h (croak):
669 * term.c (maybe_fatal, vfatal):
670 * textprop.c (text_read_only):
671 * undo.c (user_error):
672 * unexmacosx.c (unexec_error):
673 * xterm.c (x_ins_del_lines, x_delete_glyphs):
674 Use _Noreturn rather than NO_RETURN.
675 No need for separate decl merely because of _Noreturn.
676 * sound.c (sound_warning, parse_sound):
677 Remove unnecessary forward decls.
679 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
681 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
682 * lisp.h (WAIT_READING_MAX): New macro.
683 * dispnew.c (Fsleep_for, sit_for):
684 * keyboard.c (kbd_buffer_get_event):
685 * process.c (Faccept_process_output):
686 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
687 This improves on the previous patch, which introduced a bug
688 when time_t is unsigned and as wide as intmax_t.
689 See <http://bugs.gnu.org/9000#51>.
691 2012-06-23 Eli Zaretskii <eliz@gnu.org>
693 * dispnew.c (sit_for, Fsleep_for):
694 * keyboard.c (kbd_buffer_get_event):
695 * process.c (Faccept_process_output): Avoid compiler warnings when
696 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
698 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
700 * makefile.w32-in: Update dependencies.
702 * w32.c (ltime): Add return type and declare static.
703 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
705 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
707 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
708 Privately reported by Herbert J. Skuhra.
709 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
711 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
712 not make_lisp_timeval, when the argument is of type EMACS_TIME.
714 2012-06-23 Eli Zaretskii <eliz@gnu.org>
716 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
717 last argument of make_unibyte_string.
719 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
720 language ID in the event parameters.
722 * w32term.c (w32_read_socket): Put the new keyboard codepage into
723 event.code, not the obscure "character set ID".
725 2012-06-23 Chong Yidong <cyd@gnu.org>
727 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
729 2012-06-23 Eli Zaretskii <eliz@gnu.org>
731 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
732 * w32.c (fdutimens): New function.
734 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
736 * s/ms-w32.h (pselect): Redirect to sys_select.
738 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
740 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
741 in the logic of incrementing and decrementing the value of
742 use_relocatable_buffers.
744 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
746 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
747 Privately reported by Herbert J. Skuhra.
748 [__FreeBSD__]: Remove "*/" typo after "#include".
749 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
750 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
751 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
752 Don't assume EMACS_TIME and struct timeval are the same type.
754 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
756 Support higher-resolution time stamps (Bug#9000).
757 The time stamps are only nanosecond-resolution at the C level,
758 since that's the best that any real-world system supports now.
759 But they are picosecond-resolution at the Lisp level, as that's
760 easy, and leaves room for future OS improvements.
762 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
765 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
766 Don't get current time unless it's needed.
768 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
769 now provides it if it's absent.
770 (start_atimer): Port to higher-res time stamps.
771 Check for time stamp overflow. Don't get current time more
772 often than is needed.
774 * buffer.h (struct buffer): Buffer modtime now has high resolution.
775 Include systime.h, not time.h.
776 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
778 * dired.c: Include stat-time.h.
779 (Ffile-attributes): File times now have higher resolution.
781 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
782 (struct image): Timestamp now has higher resolution.
784 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
785 has at least microseconds now. All uses removed.
786 (update_frame, update_single_window, update_window, update_frame_1)
787 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
789 * editfns.c (time_overflow): Now extern.
790 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
791 (float-time, Fformat_time_string, Fcurrent_time_string)
792 (Fcurrent_time_zone): Accept and generate higher-resolution
794 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
795 (decode_time_components, lisp_seconds_argument): New functions.
796 (make_time): Now static.
797 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
798 Report an error if the time is invalid, rather than having the caller
801 * fileio.c: Include <stat-time.h>
802 (Fcopy_file): Copy higher-resolution time stamps.
803 Prefer to set the time stamp via a file descriptor if that works.
804 (Fset_file_times, Finsert_file_contents, Fwrite_region)
805 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
806 (Fvisited_file_modtime, Fset_visited_file_modtime):
807 Support higher-resolution time stamps.
809 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
811 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
813 * image.c (prepare_image_for_display, clear_image_cache)
814 (lookup_image): Port to higer-resolution time stamps.
816 * keyboard.c (start_polling, bind_polling_period):
817 Check for time stamp overflow.
818 (read_char, kbd_buffer_get_event, timer_start_idle)
819 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
820 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
821 Port to higher-resolution time stamps. Do not assume time_t is signed.
822 (decode_timer): New function. Timers are now vectors of length 9,
823 not 8, to accommodate the picosecond component.
824 (timer_check_2): Use it.
826 * nsterm.m (select_timeout, timeval_subtract): Remove.
827 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
828 as they're a bit more accurate and handle overflow better.
829 (ns_select): Change prototype to be compatible with pselect.
830 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
831 * nsterm.h (ns_select): Adjust prototype.
833 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
834 us-resolution time stamps.
835 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
837 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
839 * lisp.h (time_overflow): New decl.
840 (wait_reading_process_output): First arg is now intmax_t, not int,
841 to accommodate larger waits.
843 * process.h (struct Lisp_Process.read_output_delay):
844 Now counts nanoseconds, not microseconds.
845 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
847 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
848 (wait_reading_process_output):
849 Port to ns-resolution time stamps.
850 (Faccept_process_output, wait_reading_process_output):
851 Check for time stamp overflow. Do not assume time_t is signed.
852 (select_wrapper): Remove; we now use pselect.
853 (Fprocess_attributes): Now generates ns-resolution time stamps.
855 * sysdep.c: Include utimens.h. Don't include utime.h
856 or worry about struct utimbuf; gnulib does that for us now.
857 (gettimeofday): Remove; gnulib provides a substitute.
858 (make_timeval): New function.
859 (set_file_times): Now sets ns-resolution time stamps.
860 New arg FD; all uses changed.
861 (time_from_jiffies, ltime_from_jiffies, get_up_time)
862 (system_process_attributes):
863 Now returns ns-resolution time stamp. All uses changed.
864 Check for time stamp overflow.
866 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
867 provides a substitute now.
869 * systime.h: Include timespec.h rather than sys/time.h and time.h,
870 since it guarantees struct timespec.
871 (EMACS_TIME): Now struct timespec, so that we can support
872 ns-resolution time stamps.
873 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
874 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
875 (EMACS_USECS): Remove.
876 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
877 so multiply the arg by 1000 before storing it.
878 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
880 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
881 Port to ns-resolution time stamps.
882 (EMACS_TIME_NEG_P): Remove; replaced by....
883 (EMACS_TIME_SIGN): New macro.
884 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
885 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
886 (set_file_times, make_time, lisp_time_argument): Adjust signature.
887 (make_timeval, make_lisp_time, decode_time_components): New decls.
888 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
889 that it mishandled time_t overflow. You can't compare by subtracting!
890 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
891 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
893 * term.c: Include <sys/time.h>.
894 (timeval_to_Time): New function, for proper overflow wraparound.
895 (term_mouse_position, term_mouse_click): Use it.
897 * undo.c (record_first_change): Support higher-resolution time stamps
899 (Fprimitive_undo): Use them when restoring time stamps.
901 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
902 (w32_get_internal_run_time):
903 Port to higher-resolution Emacs time stamps.
904 (ltime): Now accepts single 64-bit integer, as that's more convenient
907 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
909 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
910 for compatibility with pselect. Support ns-resolution time stamps.
912 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
914 * xselect.c (wait_for_property_change, x_get_foreign_selection):
915 Check for time stamp overflow, and support ns-resolution time stamps.
917 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
918 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
919 (timeval_subtract): Remove; no longer needed.
920 (XTflash, XTring_bell, x_wait_for_event):
921 Port to ns-resolution time stamps. Don't assume time_t is signed.
923 2012-06-22 Chong Yidong <cyd@gnu.org>
925 * xdisp.c (x_consider_frame_title): Revert last change.
927 2012-06-22 Eli Zaretskii <eliz@gnu.org>
929 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
930 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
931 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
932 staticidx goes up to 1597 out of 1600 = 0x640.)
934 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
936 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
937 Otherwise, the umask might be mistakenly 0 while handling input signals.
939 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
941 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
943 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
945 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
946 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
947 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
948 access to `contents' member of Lisp_Vector objects with AREF and ASET
951 2012-06-19 Chong Yidong <cyd@gnu.org>
953 * frame.c (delete_frame): When selecting a frame on a different
954 text terminal, do not alter the terminal's top-frame.
956 * xdisp.c (format_mode_line_unwind_data): Record the target
957 frame's selected window and its terminal's top-frame.
958 (unwind_format_mode_line): Restore them.
959 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
961 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
962 since tty frames can be explicitly named.
963 (prepare_menu_bars): Likewise.
965 * term.c (Ftty_top_frame): New function.
967 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
969 Port byte-code-meter to modern targets.
970 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
971 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
972 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
973 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
974 (METER_1, METER_2): Simplify.
976 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
978 * data.c (Fdefalias): Return `symbol' (bug#11686).
980 2012-06-18 Martin Rudalics <rudalics@gmx.at>
982 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
983 gets killed during executing of this function (Bug#11665).
984 Try to always return Qt when the buffer has been actually killed.
985 (Vkill_buffer_query_functions): In doc-string say that functions
986 run by this hook should not change the current buffer.
988 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
990 Fix recently-introduced process.c problems found by static checking.
991 * process.c (write_queue_push, write_queue_pop, send_process):
992 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
993 (write_queue_pop): Fix pointer signedness problem.
994 (send_process): Remove unused local.
996 2012-06-17 Chong Yidong <cyd@gnu.org>
998 * xdisp.c (redisplay_internal): No need to redisplay terminal
999 frames that are not on top.
1001 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1003 * process.c (make_process): Initialize write_queue.
1004 (write_queue_push, write_queue_pop): New functions.
1005 (send_process): Use them to maintain correct ordering of process
1008 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1010 * lisp.h (eassert): Assume C89 or later.
1011 This removes the need for CHECK.
1012 (CHECK): Remove. Its comments about always evaluating its
1013 argument were confusing, as 'eassert' typically does not evaluate
1016 * coding.c (produce_chars): Use ptrdiff_t, not int.
1018 * xterm.c (x_draw_underwave): Check for integer overflow.
1019 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1021 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1023 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1024 referenced (Bug#11583).
1026 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1028 Implement wave-style variant of underlining.
1029 * dispextern.h (face_underline_type): New enum.
1030 (face): Add field for underline type.
1031 * nsterm.m (ns_draw_underwave): New function.
1032 (ns_draw_text_decoration): Use it.
1033 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1035 (x_draw_glyph_string): Use them.
1036 * xfaces.c (Qline, Qwave): New Lisp objects.
1037 (check_lface_attrs, merge_face_ref)
1038 (Finternal_set_lisp_face_attribute, realize_x_face):
1039 Handle wave-style underline face attributes.
1040 * xterm.c (x_draw_underwave): New function.
1041 (x_draw_glyph_string): Use it.
1043 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1045 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1046 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1047 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1048 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1049 ($(BLD)/w32select.$(O)): Update dependencies.
1051 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1053 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1054 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1055 * character.c (_fetch_multibyte_char_p): Remove.
1056 * alloc.c: Include "character.h" before "buffer.h".
1058 * buffer.c: Likewise.
1059 * bytecode.c: Likewise.
1060 * callint.c: Likewise.
1061 * callproc.c: Likewise.
1062 * casefiddle.c: Likewise.
1063 * casetab.c: Likewise.
1064 * category.c: Likewise.
1066 * coding.c: Likewise.
1067 * composite.c: Likewise.
1068 * dired.c: Likewise.
1069 * dispnew.c: Likewise.
1071 * dosfns.c: Likewise.
1072 * editfns.c: Likewise.
1073 * emacs.c: Likewise.
1074 * fileio.c: Likewise.
1075 * filelock.c: Likewise.
1077 * fontset.c: Likewise.
1078 * fringe.c: Likewise.
1079 * indent.c: Likewise.
1080 * insdel.c: Likewise.
1081 * intervals.c: Likewise.
1082 * keyboard.c: Likewise.
1083 * keymap.c: Likewise.
1084 * lread.c: Likewise.
1085 * macros.c: Likewise.
1086 * marker.c: Likewise.
1087 * minibuf.c: Likewise.
1088 * nsfns.m: Likewise.
1089 * nsmenu.m: Likewise.
1090 * print.c: Likewise.
1091 * process.c: Likewise.
1092 * regex.c: Likewise.
1093 * region-cache.c: Likewise.
1094 * search.c: Likewise.
1095 * syntax.c: Likewise.
1097 * textprop.c: Likewise.
1099 * unexsol.c: Likewise.
1100 * w16select.c: Likewise.
1101 * w32fns.c: Likewise.
1102 * w32menu.c: Likewise.
1103 * window.c: Likewise.
1104 * xdisp.c: Likewise.
1106 * xmenu.c: Likewise.
1108 * xselect.c: Likewise.
1110 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1112 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1113 If all the glyphs of the glyph row came from strings, and we have no
1114 cursor positioning clues, put the cursor on the first glyph of the
1116 (handle_face_prop): Use chunk-relative overlay string index when
1117 indexing into it->string_overlays array. (Bug#11653)
1118 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1119 the rightmost. (Bug#11720)
1121 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1123 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1124 (CATEGORY_MEMBER): Enforce 1/0 value.
1125 * category.c (_temp_category_set): Remove.
1127 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1129 * window.c (Fdelete_other_windows_internal)
1130 (Fdelete_window_internal): Don't access frame's mouse highlight
1131 info of the initial frame. (Bug#11677)
1133 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1135 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1136 Assume USE_2_TAGS_FOR_INTS.
1137 (xreload): Adjust $tagmask width to match recent lisp.h change.
1139 Simplify lisp.h in minor ways that should not affect code.
1140 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1141 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1142 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1143 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1144 (INTTYPEBITS): New macro, for clarity.
1145 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1146 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1147 Simplify now that USE_LSB_TAG is always defined.
1148 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1149 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1151 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1153 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1155 2012-06-13 Glenn Morris <rgm@gnu.org>
1157 * s/bsd-common.h (BSD4_3):
1158 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1160 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1162 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1165 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1167 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1168 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1169 * alloc.c (widen_to_Lisp_Object): Remove.
1170 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1171 * frame.c (delete_frame): Remove outdated comment.
1172 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1173 USE_LISP_UNION_TYPE.
1174 (Fw32_unregister_hot_key): Likewise.
1175 (Fw32_toggle_lock_key): Likewise.
1176 * w32menu.c (add_menu_item): Likewise.
1177 (w32_menu_display_help): Use XIL instead of checking
1178 USE_LISP_UNION_TYPE.
1179 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1180 (init_heap): Likewise.
1181 * w32term.c (w32_read_socket): Update comment.
1183 2012-06-13 Glenn Morris <rgm@gnu.org>
1185 * s/usg5-4-common.h, src/s/unixware.h:
1186 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1188 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1190 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1192 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1193 * alloc.c (make_number) [!defined make_number]:
1194 Remove, as lisp.h always defines this now.
1195 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1196 (roundup_size): Verify that it is a power of 2.
1197 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1198 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1199 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1200 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1201 USE_LSB_TAG now is always defined to be either 0 or 1.
1203 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1204 code works fine either way, and efficiency is not a concern here,
1205 as the union type is for debugging, not for production.
1206 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1207 Use an inline function on all platforms when using the union type,
1208 since this is simpler and 'static inline' can be used portably
1210 (LISP_INITIALLY_ZERO): New macro.
1211 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1212 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1214 2012-06-12 Glenn Morris <rgm@gnu.org>
1216 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1218 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1220 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1221 Move BROKEN_SIGIO to configure.
1223 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1224 Move NO_TERMIO to configure.
1226 2012-06-12 Chong Yidong <cyd@gnu.org>
1228 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1229 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1230 MagickExportImagePixels is undefined.
1232 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1234 * image.c (imagemagick_load_image): Remove unused label.
1236 2012-06-11 Glenn Morris <rgm@gnu.org>
1238 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1239 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1240 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1241 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1243 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1245 * alloc.c (make_byte_code): New function.
1246 (Fmake_byte_code): Use it. Don't purify here.
1247 * lread.c (read1): Use it as well to avoid extra allocation.
1249 2012-06-11 Chong Yidong <cyd@gnu.org>
1251 * image.c (imagemagick_load_image): Implement transparency.
1253 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1255 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1256 account for preceding backslashes. (Bug#11663)
1258 2012-06-09 Chong Yidong <cyd@gnu.org>
1260 * term.c: Support italics in capable terminals (Bug#9652).
1261 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1262 (turn_on_face): Output using TS_enter_italic_mode if available.
1263 Don't handle unused blinking and alt-charset cases.
1264 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1265 and tty_alt_charset_p cases.
1266 (tty_capable_p, init_tty): Support italics.
1268 * termchar.h (struct tty_display_info): Add field for italics.
1269 Remove unused blink field.
1271 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1274 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1275 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1276 tty_alt_charset_p. Add tty_italic_p.
1278 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1280 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1281 dbus_type_is_basic if available.
1282 (xd_extract_signed, xd_extract_unsigned): Rename from
1283 extract_signed and extract_unsigned, respectively. Adapt callers.
1285 2012-06-09 Chong Yidong <cyd@gnu.org>
1287 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1289 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1292 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1294 * xdisp.c (vmessage): Treat frame message as multibyte.
1295 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1296 would generate the diagnostic "Making \302\247 buffer-local while
1299 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1301 * dispnew.c (showing_window_margins_p): Undo last change, which
1302 was done due to an inadvertent commit.
1303 (adjust_frame_glyphs_for_frame_redisplay): Do call
1304 showing_window_margins_p.
1306 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1308 * eval.c (Fmake_var_non_special): New primitive.
1309 (syms_of_eval): Defsubr it.
1310 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1312 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1314 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1315 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1317 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1319 * alloc.c (allocate_vectorlike): Fix last change.
1321 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1323 Block-based vector allocation of small vectors.
1324 * lisp.h (struct vectorlike_header): New field `nbytes',
1325 adjust comment accordingly.
1326 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1327 to denote vector blocks. Adjust users (live_vector_p,
1328 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1329 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1330 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1331 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1332 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1333 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1334 (roundup_size): New constant.
1335 (struct vector_block): New data type.
1336 (vector_blocks, vector_free_lists, zero_vector): New variables.
1337 (all_vectors): Rename to `large_vectors'.
1338 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1339 (sweep_vectors): New functions.
1340 (allocate_vectorlike): Return `zero_vector' as the only vector of
1341 0 items. Allocate new vector from block if vector size is less than
1342 or equal to VBLOCK_BYTES_MAX.
1343 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1344 (init_alloc_once): Add call to init_vectors.
1346 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1348 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1350 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1352 * doprnt.c (doprnt): Truncate multibyte char correctly.
1353 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1354 would mishandle a string argument "Xc" if X was a multibyte
1355 character of length 2: it would truncate after X's first byte
1356 rather than including all of X.
1358 2012-06-06 Chong Yidong <cyd@gnu.org>
1360 * buffer.c (word_wrap): Doc fix.
1362 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1364 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1366 2012-06-03 Glenn Morris <rgm@gnu.org>
1368 * xdisp.c (tool-bar-style): Doc fix.
1370 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1372 * Makefile.in (PAXCTL): Define.
1373 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1374 binary via PaX flags if the paxctl utility is available.
1375 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1376 Restore PaX flags to their default. (Bug#11398)
1378 2012-06-03 Chong Yidong <cyd@gnu.org>
1380 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1383 2012-06-03 Chong Yidong <cyd@gnu.org>
1385 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1386 (note_mode_line_or_margin_highlight): If there is no help echo,
1387 use mode-line-default-help-echo. Handle the case where the mouse
1388 position is past the end of the mode line string.
1390 * buffer.c (buffer_local_value_1): New function, split from
1391 Fbuffer_local_value; can return Qunbound.
1392 (Fbuffer_local_value): Use it.
1393 (Vmode_line_format): Docstring tweaks.
1395 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1397 * sysdep.c (system_process_attributes): Improve comment.
1399 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1401 * keyboard.c: Export real-this-command to Elisp.
1402 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1403 and DEFVAR it. Update all users.
1405 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1407 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1409 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1410 Convert pctcpu and pctmem to Lisp float properly.
1411 Let the compiler fold better, as 100.0/0x8000 is exact.
1413 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1415 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1418 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1420 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1422 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1424 For a 'struct window', replace some Lisp_Object fields to
1425 bitfields where appropriate, remove unused fields.
1426 * window.h (struct window): Remove unused 'last_mark_x' and
1427 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1428 change it's type from Lisp_Object to bitfield.
1429 Change type of 'force_start', 'optional_new_start',
1430 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1431 fields from Lisp_Object to bitfield. Adjust users accordingly.
1433 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1435 Pacify gcc -Wdouble-precision when using Xaw.
1436 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1437 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1438 Use 'float' consistently, rather than 'float' in most places
1439 and 'double' in a couple of places.
1441 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1443 * xdisp.c (handle_stop): Detect whether we have overlay strings
1444 loaded by testing it->current.overlay_string_index to be
1445 non-negative, instead of checking whether n_overlay_strings is
1446 positive. (Bug#11587)
1448 2012-05-31 Chong Yidong <cyd@gnu.org>
1450 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1452 * doc.c (Fsubstitute_command_keys): Doc fix.
1454 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1456 * search.c (search_buffer): Remove calls to
1457 r_alloc_inhibit_buffer_relocation, as it is now called by
1458 maybe_unify_char, which was the cause of relocation of buffer text
1461 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1463 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1464 for the duration of call to load_charset, to avoid problems with
1465 callers of maybe_unify_char that access buffer text through C
1468 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1469 decrement the inhibition flag, instead of just setting or
1472 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1474 Remove obsolete '#define static' cruft.
1475 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1476 This #undef was "temporary" in 2000; it is no longer needed
1477 now that '#define static' has gone away.
1478 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1479 (gray_bitmap_bits): Remove; no longer needed.
1480 All uses replaced with definiens.
1481 * xterm.c: Include "bitmaps/gray.xbm".
1483 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1485 Clean up __executable_start, monstartup when --enable-profiling.
1486 The following changes affect the code only when profiling.
1487 * dispnew.c (__executable_start): Rename from safe_bcopy.
1488 Define only on platforms that need it.
1489 * emacs.c: Include <sys/gmon.h> when profiling.
1490 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1491 (__executable_start): Remove decl, since lisp.h does it now.
1492 (safe_bcopy): Remove decl; no longer has that name.
1493 (main): Coalesce #if into single bit of code, for simplicity.
1494 Cast pointers to uintptr_t, since standard libraries want integers
1496 * lisp.h (__executable_start): New decl.
1498 2012-05-31 Glenn Morris <rgm@gnu.org>
1500 * image.c (Fimagemagick_types): Doc fix.
1502 2012-05-30 Jim Meyering <meyering@redhat.com>
1504 * callproc.c (Fcall_process_region): Include directory component
1505 in mkstemp error message (Bug#11586).
1507 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1509 * alloc.c, lisp.h (make_pure_vector): Now static.
1511 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1513 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1514 Move to byte-run.el.
1515 (Fautoload): Do the hash-doc more carefully.
1516 * data.c (Fdefalias): Purify definition, except for keymaps.
1517 (Qdefun): Move from eval.c.
1518 * lisp.h (Qdefun): Remove.
1519 * lread.c (read1): Tiny simplification.
1521 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1523 Do not create empty overlays with the evaporate property (Bug#9642).
1524 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1525 Bug#9642, but explicitly check that the buffer the overlay would
1526 be moved to is live and rearrange lines to make sure that errors
1527 will not put the overlay in an inconsistent state.
1528 (Fdelete_overlay): Cosmetics.
1530 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1532 * w32term.c (my_bring_window_to_top): New function.
1533 (x_raise_frame): Use handle returned by DeferWindowPos, which
1534 could be different from the original one.
1535 Call my_bring_window_to_top instead of my_set_foreground_window.
1538 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1539 by calling BringWindowToTop.
1541 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1542 (WM_EMACS_END): Increase by one.
1544 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1546 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1547 This avoids undefined behavior that might cause the eassert
1548 to not catch an out-of-range value.
1550 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1552 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1553 Update dependencies.
1555 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1557 * bidi.c (bidi_mirror_char): Fix last change.
1559 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1561 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1562 when referring to sectname field in printf format.
1564 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1566 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1567 Only r_alloc_inhibit_buffer_relocation needed to be added;
1568 the others were already declared.
1570 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1571 before checking whether it's out of range. Put the check inside
1573 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1575 2012-05-27 Ken Brown <kbrown@cornell.edu>
1577 * callproc.c (Fcall_process): Restore a line that was accidentally
1578 commented out in the 2011-02-13 change (bug#11547).
1580 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1582 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1583 defined on ralloc.c.
1585 * buffer.c [REL_ALLOC]: Remove prototypes of
1586 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1587 they are now on lisp.h.
1589 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1591 * search.c (search_buffer): Use it to inhibit relocation of buffer
1592 text while re_search_2 is doing its job, because re_search_2 is
1593 passed C pointers to buffer text. (Bug#11519)
1595 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1598 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1599 state after an additional call to move_it_in_display_line_to, keep
1600 the values of it->max_ascent and it->max_descent found for the
1602 (pos_visible_p): Revert the comparison against bottom_y to what it
1603 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1606 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1608 Fix coding-related core dumps with gcc -ftrapv.
1609 The code was computing A - B, where A and B are pointers, and B is
1610 random garbage. This can lead to core dumps on platforms that
1611 have special pointer registers, and it also leads to core dumps on
1612 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1613 A - B only when B is initialized properly.
1614 * coding.c (coding_set_source, coding_set_destination): Return void.
1615 (coding_change_source, coding_change_destinations): New functions,
1616 with the old behaviors of coding_set_source and coding_set_destination.
1617 All callers that need an offset changed to use these new functions.
1619 2012-05-26 Glenn Morris <rgm@gnu.org>
1621 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1623 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1625 Extend mouse support on W32 text-mode console.
1626 * xdisp.c (draw_row_with_mouse_face):
1627 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1629 * w32console.c: Include window.h.
1630 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1632 (initialize_w32_display): Initialize mouse-highlight data.
1634 * w32inevt.c: Include termchar.h and window.h.
1635 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1636 moves, call note_mouse_highlight. If help_echo changed, call
1637 gen_help_event to produce help-echo message in the echo area.
1638 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1641 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1643 * lread.c (read1): Simplify slightly to avoid an overflow warning
1644 with GCC 4.7.0 on x86-64.
1646 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1648 * bidi.c (bidi_mirror_char): Revert last change: an int is
1649 definitely wide enough here.
1651 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1653 Fix integer width and related bugs (Bug#9874).
1654 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1655 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1656 (string_bytes, check_sblock, allocate_string_data):
1657 (compact_small_strings, Fmake_bool_vector, make_string)
1658 (make_unibyte_string, make_multibyte_string)
1659 (make_string_from_bytes, make_specified_string)
1660 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1661 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1664 (allocate_pseudovector):
1665 Use int, not EMACS_INT, where int is wide enough.
1666 (inhibit_garbage_collection, Fgarbage_collect):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1669 int might not be wide enough.
1670 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1671 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1672 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1673 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1674 (bidi_level_of_next_char, bidi_move_to_visually_next):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1677 (Fkill_buffer, Fset_buffer_major_mode)
1678 (advance_to_char_boundary, Fbuffer_swap_text)
1679 (Fset_buffer_multibyte, overlays_at, overlays_in)
1680 (overlay_touches_p, struct sortvec, record_overlay_string)
1681 (overlay_strings, recenter_overlay_lists)
1682 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1683 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1684 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1685 (Foverlay_recenter, last_overlay_modification_hooks_used)
1686 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1688 (validate_region): Omit unnecessary test for b <= e,
1689 since that's guaranteed by the previous test.
1690 (adjust_overlays_for_delete): Avoid pos + length overflow.
1691 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1692 (report_overlay_modification):
1693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1694 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1695 Omit pointer cast, which isn't needed anyway, and doesn't work
1696 after the EMACS_INT -> ptrdiff_t change.
1697 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1698 * buffer.h: Adjust decls to match defn changes elsewhere.
1699 (struct buffer_text, struct buffer):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 Use EMACS_INT, not int, where int might not be wide enough.
1702 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1703 not int, to avoid needless 32-bit limit on 64-bit hosts.
1704 (exec_byte_code): Use tighter memory-full test, one that checks
1705 for alloca overflow. Don't compute the address of the object just
1706 before an array, as that's not portable. Use EMACS_INT, not
1707 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1708 * callint.c (Fcall_interactively):
1709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1710 * callproc.c (call_process_kill, Fcall_process):
1711 Don't assume pid_t fits into an Emacs fixnum.
1712 (call_process_cleanup, Fcall_process, child_setup):
1713 Don't assume pid_t fits into int.
1714 (call_process_cleanup, Fcall_process, delete_temp_file)
1715 (Fcall_process_region):
1716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1717 (Fcall_process): Simplify handling of volatile integers.
1718 Use int, not EMACS_INT, where int will do.
1719 * casefiddle.c (casify_object, casify_region, operate_on_word)
1720 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1722 (casify_object): Avoid integer overflow when overallocating buffer.
1723 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1724 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1725 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1726 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1727 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1728 integers are now checked earlier. All uses replaced with XINT.
1730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1731 For CCL_MapSingle, check that content and value are in int range.
1732 (ccl_driver, Fregister_code_conversion_map):
1733 Check that Vcode_version_map_vector is a vector.
1734 (resolve_symbol_ccl_program): Check that vector header is in range.
1735 Always copy the vector, so that we can check its contents reliably
1736 now rather than having to recheck each instruction as it's being
1737 executed. Check that vector words fit in 'int'.
1738 (ccl_get_compiled_code, Fregister_ccl_program)
1739 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1740 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1741 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1742 contents are in range.
1743 (Fccl_execute_on_string): Check that status is in range.
1744 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1745 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1746 Accept and return EMACS_INT, not int, because callers can pass values
1748 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1749 (multibyte_chars_in_text, parse_str_as_multibyte)
1750 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1751 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1752 (string_escape_byte8, Fget_byte):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1754 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1755 avoid mishandling large integers.
1756 * character.h: Adjust decls to match defn changes elsewhere.
1757 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1758 (Ffind_charset_region):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1761 (load_charset_map_from_vector, Fdefine_charset_internal):
1762 Don't assume fixnum fits in int.
1763 (load_charset_map_from_vector, Fmap_charset_chars):
1764 Remove now-unnecessary CHECK_NATNUMs.
1765 (Fdefine_charset_internal): Check ranges here, more carefully.
1766 Don't rely on undefined behavior with signed left shift overflow.
1767 Don't assume unsigned int fits into fixnum, or that fixnum fits
1768 into unsigned int. Don't require max_code to be a valid fixnum;
1769 that's not true for gb10830 4-byte on a 32-bit host. Allow
1770 invalid_code to be a cons, for the same reason. Require code_offset
1771 to be a character. Avoid int overflow if max_char is close
1773 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1774 this is intended anyway and avoids some undefined behavior.
1775 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1776 INDEX_TO_CODE_POINT, as that's what it expects.
1777 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1778 * charset.h (DECODE_CHAR): Return int, not unsigned;
1779 this is what was intended anyway, and it avoids undefined behavior.
1780 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1781 integer-overflow issues.
1782 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1783 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1784 where the argument is EMACS_INT, and this behavior is not intended.
1785 * chartab.c (Fmake_char_table, Fset_char_table_range)
1786 (uniprop_get_decoder, uniprop_get_encoder):
1787 Don't assume fixnum fits in int.
1788 * cmds.c (move_point): New function, that does the gist of
1789 Fforward_char and Fbackward_char, but does so while checking
1790 for integer overflow more accurately.
1791 (Fforward_char, Fbackward_char): Use it.
1792 (Fforward_line, Fend_of_line, internal_self_insert)
1793 (internal_self_insert):
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 Fix a FIXME, by checking for integer overflow when calculating
1796 target_clm and actual_clm.
1797 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1798 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1799 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1800 (coding_alloc_by_making_gap, alloc_destination)
1801 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1802 (encode_coding_utf_16, detect_coding_emacs_mule)
1803 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1804 (detect_coding_iso_2022, decode_coding_iso_2022)
1805 (encode_invocation_designation, encode_designation_at_bol)
1806 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1807 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1808 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1809 (encode_coding_ccl, encode_coding_raw_text)
1810 (detect_coding_charset, decode_coding_charset)
1811 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1812 (produce_composition, produce_charset, produce_annotation)
1813 (decode_coding, handle_composition_annotation)
1814 (handle_charset_annotation, consume_chars, decode_coding_gap)
1815 (decode_coding_object, encode_coding_object, detect_coding_system)
1816 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1817 (code_convert_region, code_convert_string)
1818 (Fdefine_coding_system_internal)
1819 (coding_set_source, coding_set_destination):
1820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1821 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1822 (Fdefine_coding_system_internal):
1823 Don't assume fixnums fit in int.
1824 (decode_coding_gap, decode_coding_object, encode_coding_object)
1825 (Fread_coding_system, Fdetect_coding_region)
1826 (Funencodable_char_position, Fcheck_coding_systems_region)
1827 (get_translation, handle_composition_annotation, consume_chars):
1828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1829 (consume_chars): Rewrite to not calculate an address outside buffer.
1830 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1831 Don't access memory outside of the args array.
1832 (Fdefine_coding_system_internal): Check for charset-id overflow.
1833 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1834 result of ENCODE_CHAR.
1835 * coding.h: Adjust decls to match defn changes elsewhere.
1836 (struct coding_system):
1837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1838 * composite.c (get_composition_id, find_composition)
1839 (run_composition_function, update_compositions)
1840 (compose_text, composition_gstring_put_cache)
1841 (composition_gstring_p, composition_gstring_width)
1842 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1843 (composition_compute_stop_pos, composition_reseat_it)
1844 (composition_update_it, struct position_record)
1845 (find_automatic_composition, composition_adjust_point)
1846 (Fcomposition_get_gstring, Ffind_composition_internal):
1847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1848 (update_compositions):
1849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1850 * composite.h: Adjust decls to match defn changes elsewhere.
1851 (struct composition):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1854 Do not attempt to compute the address of the object just before a
1855 buffer; this is not portable.
1857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1858 (Faset): Use int, not EMACS_INT, where int is wide enough.
1859 (Fstring_to_number): Don't assume fixnums fit in int.
1860 (Frem): Don't assume arg is nonnegative.
1861 * dbusbind.c (xd_append_arg): Check for integers out of range.
1862 (Fdbus_call_method): Don't overflow the timeout int.
1863 (extract_signed, extract_unsigned): New functions.
1864 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1865 (xd_get_connection_references): Return ptrdiff_t, not int.
1867 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1868 (xd_read_message_1):
1869 Use int, not unsigned, where the dbus API uses int.
1870 (Fdbus_message_internal): Don't overflow mtype.
1871 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1872 * dired.c (directory_files_internal, file_name_completion, scmp)
1873 (file_name_completion_stat):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1875 (file_name_completion): Don't overflow matchcount.
1876 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1877 * dispextern.h: Adjust decls to match defn changes elsewhere.
1878 (struct text_pos, struct glyph, struct bidi_saved_info)
1879 (struct bidi_string_data, struct bidi_it, struct composition_it)
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (struct display_pos, struct composition_it, struct it):
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 * dispnew.c (increment_matrix_positions)
1885 (increment_row_positions, mode_line_string)
1886 (marginal_area_string):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1888 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (duration_to_sec_usec): New function, to check for overflow better.
1891 (Fsleep_for, sit_for): Use it.
1892 * doc.c (get_doc_string, store_function_docstring):
1893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1894 (get_doc_string, Fsnarf_documentation):
1895 Use int, not EMACS_INT, where int is wide enough.
1897 Use SAFE_ALLOCA, not alloca.
1898 Check for overflow when converting EMACS_INT to off_t.
1899 * doprnt.c (doprnt):
1900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1901 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1902 Don't assume uid_t fits into fixnum.
1903 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1904 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1905 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1906 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1907 (general_insert_function)
1908 (Finsert_char, make_buffer_string, make_buffer_string_both)
1909 (update_buffer_properties, Fbuffer_substring)
1910 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1911 (Fsubst_char_in_region, check_translation)
1912 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1913 (transpose_markers, Ftranspose_regions):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (clip_to_bounds): Move to lisp.h as an inline function).
1916 (Fconstrain_to_field): Don't assume integers are nonnegative.
1917 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1918 (Fsubst_char_in_region, Fsave_restriction):
1919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1920 (Femacs_pid): Don't assume pid_t fits into fixnum.
1921 (lo_time): Use int, not EMACS_INT, when int suffices.
1922 (lisp_time_argument): Check for usec out of range.
1923 (Fencode_time): Don't assume fixnum fits in int.
1924 (Fuser_login_name, Fuser_full_name): Signal an error
1925 if a uid argument is out of range, rather than relying on
1927 (Fformat_time_string): Remove now-unnecessary check.
1928 lisp_time_argument checks for out-of-range usec now.
1929 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1930 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1931 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1932 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1933 (init_cmdargs, Fdump_emacs):
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1936 the bottom (typically) 32 bits of the fixnum.
1937 * eval.c (specpdl_size, call_debugger):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (when_entered_debugger, Fbacktrace_debug):
1940 Don't assume fixnum can fit in int.
1941 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1942 the object just before a buffer; this is not portable.
1943 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1944 (grow_specpdl, unbind_to):
1945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1946 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1947 (grow_specpdl): Simplify allocation by using xpalloc.
1948 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1949 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1950 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1952 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1955 (Fcopy_file, non_regular_nbytes, read_non_regular)
1956 (Finsert_file_contents):
1957 Use int, not EMACS_INT, where int is wide enough.
1958 (READ_BUF_SIZE): Verify that it fits in int.
1959 (Finsert_file_contents): Check that counts are in proper range,
1960 rather than assuming fixnums fit into ptrdiff_t etc.
1961 Don't assume fixnums fit into int.
1962 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1963 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1964 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1965 (string_char_to_byte, string_byte_to_char)
1966 (string_make_multibyte, string_to_multibyte)
1967 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1968 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1969 (substring_both, Fdelete, internal_equal, Ffillarray)
1970 (Fclear_string, mapcar1)
1971 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1972 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1973 (larger_vector, make_hash_table, maybe_resize_hash_table)
1974 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1975 (Fmaphash, secure_hash):
1976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1977 (concat): Check for string index and length overflow.
1978 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 (larger_vector): New API (vec, incr_min, size_max) replaces old
1982 one (vec, new_size, init). This catches size overflow.
1983 INIT was removed because it was always Qnil.
1984 All callers changed.
1985 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1986 the upper bound on a hash table index size.
1987 (make_hash_table, maybe_resize_hash_table): Use it.
1988 (secure_hash): Computer start_byte and end_byte only after
1989 they're known to be in ptrdiff_t range.
1990 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1991 (Ffont_get_glyphs, Ffont_at):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1994 (Flist_fonts, Fopen_font):
1995 Don't assume fixnum can fit in int.
1996 (check_gstring): Don't assume index can fit in int.
1997 (font_match_p): Check that fixnum is a character, not a nonnegative
1998 fixnum, since the later code needs to stuff it into an int.
1999 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2000 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2001 conversion overflow issues.
2002 (Fopen_font): Check for integer out of range.
2003 (Ffont_get_glyphs): Don't assume index can fit in int.
2004 * font.h: Adjust decls to match defn changes elsewhere.
2005 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2007 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2008 printmax_t, where ptrdiff_t is wide enough.
2009 (Finternal_char_font):
2010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2011 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2012 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2013 (Fset_frame_position, x_set_frame_parameters)
2014 (x_set_line_spacing, x_set_border_width)
2015 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2016 Check that fixnums are in proper range for system types.
2017 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2019 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2020 Use SAFE_ALLOCA_LISP, not alloca.
2021 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2022 intptr_t is wide enough.
2023 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2024 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2025 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2026 Check for fixnum out of range.
2027 * ftfont.c (ftfont_list): Don't assume index fits in int.
2028 Check that fixnums are in proper range for system types.
2029 (ftfont_shape_by_flt):
2030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2031 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2033 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2034 Check that fixnums are in proper range for system types.
2035 * gnutls.h: Adjust decls to match defn changes elsewhere.
2036 * gtkutil.c (xg_dialog_run):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 (update_frame_tool_bar):
2039 Check that fixnums are in proper range for system types.
2040 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2041 (lookup_image): Check that fixnums are in range for system types.
2042 * indent.c (last_known_column, last_known_column_point):
2043 (current_column_bol_cache):
2044 (skip_invisible, current_column, check_display_width):
2045 (check_display_width, scan_for_column, current_column_1)
2046 (Findent_to, Fcurrent_indentation, position_indentation)
2047 (indented_beyond_p, Fmove_to_column, compute_motion):
2048 (Fcompute_motion, Fvertical_motion):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (last_known_column_modified): Use EMACS_INT, not int.
2051 (check_display_width):
2053 Check that fixnums and floats are in proper range for system types.
2054 (compute_motion): Don't assume index or fixnum fits in int.
2055 (compute_motion, Fcompute_motion):
2056 Use int, not EMACS_INT, when it is wide enough.
2057 (vmotion): Omit local var start_hpos that is always 0; that way
2058 we don't need to worry about overflow in expressions involving it.
2059 * indent.h: Adjust decls to match defn changes elsewhere.
2061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2062 Use int, not EMACS_INT, where int is wide enough.
2063 Remove unused members ovstring_chars_done and tab_offset;
2065 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2066 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2067 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2068 (make_gap, copy_text, insert, insert_and_inherit)
2069 (insert_before_markers, insert_before_markers_and_inherit)
2070 (insert_1, count_combining_before, count_combining_after)
2071 (insert_1_both, insert_from_string)
2072 (insert_from_string_before_markers, insert_from_string_1)
2073 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2074 (adjust_after_replace, adjust_after_insert, replace_range)
2075 (replace_range_2, del_range, del_range_1, del_range_byte)
2076 (del_range_both, del_range_2, modify_region)
2077 (prepare_to_modify_buffer, signal_before_change)
2078 (signal_after_change, Fcombine_after_change_execute):
2079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2080 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2081 (balance_an_interval, split_interval_right, split_interval_left)
2082 (find_interval, next_interval, update_interval)
2083 (adjust_intervals_for_insertion, delete_node, delete_interval)
2084 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2085 (static_offset_intervals, offset_intervals)
2086 (merge_interval_right, merge_interval_left, make_new_interval)
2087 (graft_intervals_into_buffer, temp_set_point_both)
2088 (temp_set_point, set_point, adjust_for_invis_intang)
2089 (set_point_both, move_if_not_intangible, get_property_and_range)
2090 (get_local_map, copy_intervals, copy_intervals_to_string)
2091 (compare_string_intervals, set_intervals_multibyte_1):
2092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2093 * intervals.h: Adjust decls to match defn changes elsewhere.
2095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2096 * keyboard.c (this_command_key_count, this_single_command_key_start)
2097 (before_command_key_count, before_command_echo_length, echo_now)
2098 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2099 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2100 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2101 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2103 (last_non_minibuf_size, last_point_position, echo_truncate)
2104 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2105 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2106 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2107 (stuff_buffered_input):
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2109 (last_auto_save, command_loop_1, read_char):
2110 Use EMACS_INT, not int, to avoid integer overflow.
2111 (record_char): Avoid overflow in total_keys computation.
2112 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2113 * keyboard.h: Adjust decls to match defn changes elsewhere.
2114 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2115 (Fkey_description, Fdescribe_vector, Flookup_key):
2116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2117 (click_position): New function, to check that positions are in range.
2118 (Fcurrent_active_maps):
2120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2121 (Faccessible_keymaps, Fkey_description):
2122 (preferred_sequence_p):
2123 Don't assume fixnum can fit into int.
2124 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2125 Check for integer overflow in size calculations.
2126 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2127 avoid mishandling large integers.
2128 * lisp.h: Adjust decls to match defn changes elsewhere.
2129 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2130 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2131 (struct Lisp_Marker):
2132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2133 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2134 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2135 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2136 All callers changed.
2137 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2138 Assume the arg has valid form, since it always does.
2139 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2140 unsigned integer system type.
2141 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2142 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2144 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2145 (duration_to_sec_usec): New decl.
2146 * lread.c (read_from_string_index, read_from_string_index_byte)
2147 (read_from_string_limit, readchar, unreadchar, openp)
2148 (read_internal_start, read1, oblookup):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (Fload, readevalloop, Feval_buffer, Feval_region):
2151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2152 (openp): Check for out-of-range argument to 'access'.
2153 (read1): Use int, not EMACS_INT, where int is wide enough.
2154 Don't assume fixnum fits into int.
2155 Fix off-by-one error that can read outside a buffer.
2156 (read_filtered_event): Use duration_to_sec_usec
2157 to do proper overflow checking on durations.
2158 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2159 in size calculation.
2160 (Fexecute_kbd_macro):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2163 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2164 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2165 (set_marker_both, set_marker_restricted_both, marker_position)
2166 (marker_byte_position, Fbuffer_has_markers_at):
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2169 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2170 It now merely ensures that the menu is large enough, without
2171 necessarily growing it, as this avoids some integer overflow issues.
2172 All callers changed.
2173 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2175 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2176 Use SAFE_ALLOCA_LISP, not alloca.
2177 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2178 to EMACS_INT. Check that fixnums are in proper range for system types.
2179 * minibuf.c (minibuf_prompt_width, string_to_object)
2180 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2181 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 (get_minibuffer, read_minibuf_unwind):
2184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2185 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2186 this simplifies overflow checking. All callers changed.
2187 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2190 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2191 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2192 Check that fixnums are in proper range for system types.
2193 (Fx_create_frame, Fx_show_tip):
2194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2195 * nsfont.m (ns_findfonts, nsfont_list_family):
2196 Don't assume fixnum fits in long.
2197 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2199 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2201 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2204 (PRINTDECLARE, PRINTPREPARE):
2205 (strout, print_string):
2206 (print, print_preprocess, print_check_string_charset_prop)
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2213 (printchar, strout): Use xpalloc to catch size calculation overflow.
2214 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2215 (print_error_message): Use SAFE_ALLOCA, not alloca.
2216 (print_object): Use int, not EMACS_INT, where int is wide enough.
2217 (print_depth, new_backquote_output, print_number_index):
2218 Use ptrdiff_t, not int, where int might not be wide enough.
2219 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2220 (Fset_process_window_size, Fformat_network_address)
2221 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2223 Check that fixnums are in proper range for system types.
2224 (Fsignal_process): Simplify by avoiding a goto.
2225 Check for process-ids out of pid_t range rather than relying on
2227 (process_tick, update_tick): Use EMACS_INT, not int.
2228 (Fformat_network_address, read_process_output, send_process)
2229 (Fprocess_send_region, status_notify):
2230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2231 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2232 (wait_reading_process_output, read_process_output, exec_sentinel):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2235 (Faccept_process_output): Use duration_to_sec_usec to do proper
2236 overflow checking on durations.
2237 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2238 Don't assume pid_t fits in int.
2239 * process.h (struct Lisp_Process): Members tick and update_tick
2240 are now of type EMACS_INT, not int.
2241 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2242 configured --with-wide-int.
2243 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2244 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2245 * search.c (looking_at_1, string_match_1):
2246 (fast_string_match, fast_c_string_match_ignore_case)
2247 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2248 (scan_newline, find_before_next_newline, search_command)
2249 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2250 (set_search_regs, wordify):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 (string_match_1, search_buffer, set_search_regs):
2256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2257 (wordify): Check for overflow in size calculation.
2258 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2259 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2260 Check that fixnums are in proper range for system types.
2261 * sound.c (struct sound_device)
2262 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2264 (Fplay_sound_internal):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2266 * syntax.c (struct lisp_parse_state, find_start_modiff)
2267 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2268 (Fparse_partial_sexp):
2269 Don't assume fixnums can fit in int.
2270 (struct lisp_parse_state, find_start_pos, find_start_value)
2271 (find_start_value_byte, find_start_begv)
2272 (update_syntax_table, char_quoted, dec_bytepos)
2273 (find_defun_start, prev_char_comend_first, back_comment):
2274 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2275 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2277 (Finternal_describe_syntax_value): Check that match_lisp is a
2278 character, not an integer, since the code stuffs it into int.
2279 (scan_words, scan_sexps_forward):
2280 Check that fixnums are in proper range for system types.
2282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2283 (scan_sexps_forward):
2284 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2285 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2286 * syntax.h: Adjust decls to match defn changes elsewhere.
2287 (struct gl_state_s):
2288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2289 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2290 MOST_POSITIVE_FIXNUM.
2291 * sysdep.c (wait_for_termination_1, wait_for_termination)
2292 (interruptible_wait_for_termination, mkdir):
2293 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2294 (emacs_read, emacs_write):
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2297 and double all fit in int.
2298 * term.c (set_tty_color_mode):
2299 Check that fixnums are in proper range for system types.
2300 * termhooks.h (struct input_event):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 * textprop.c (validate_interval_range, interval_of)
2303 (Fadd_text_properties, set_text_properties_1)
2304 (Fremove_text_properties, Fremove_list_of_text_properties)
2305 (Ftext_property_any, Ftext_property_not_all)
2306 (copy_text_properties, text_property_list, extend_property_ranges)
2307 (verify_interval_modification):
2308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2309 (Fnext_single_char_property_change)
2310 (Fprevious_single_char_property_change):
2311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2312 (copy_text_properties):
2313 Check for integer overflow in index calculation.
2314 * undo.c (last_boundary_position, record_point, record_insert)
2315 (record_delete, record_marker_adjustment, record_change)
2316 (record_property_change):
2317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2318 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2321 (Fx_hide_tip, Fx_file_dialog):
2322 * w32menu.c (set_frame_menubar):
2323 Use ptrdiff_t, not int, for consistency with rest of code.
2324 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2325 (select_window, Fdelete_other_windows_internal)
2326 (window_scroll_pixel_based, window_scroll_line_based)
2327 (Frecenter, Fset_window_configuration):
2328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2329 (Fset_window_hscroll, run_window_configuration_change_hook)
2330 (set_window_buffer, temp_output_buffer_show, scroll_command)
2331 (Fscroll_other_window, Frecenter):
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2334 Don't assume fixnum fits in int.
2335 (Fset_window_scroll_bars):
2336 Check that fixnums are in proper range for system types.
2337 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2338 (string_pos, c_string_pos, number_of_chars, init_iterator)
2339 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2340 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2341 (compute_display_string_end, handle_face_prop)
2342 (face_before_or_after_it_pos, handle_invisible_prop)
2343 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2344 (display_prop_intangible_p, string_buffer_position_lim)
2345 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2346 (get_overlay_strings_1, get_overlay_strings)
2347 (iterate_out_of_display_property, forward_to_next_line_start)
2348 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2349 (get_next_display_element, set_iterator_to_next)
2350 (get_visually_first_element, compute_stop_pos_backwards)
2351 (handle_stop_backwards, next_element_from_buffer)
2352 (move_it_in_display_line_to, move_it_in_display_line)
2353 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2354 (add_to_log, message_dolog, message_log_check_duplicate)
2355 (message2, message2_nolog, message3, message3_nolog
2356 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2357 (current_message_1, truncate_echo_area, truncate_message_1)
2358 (set_message, set_message_1, store_mode_line_noprop)
2359 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2360 (text_outside_line_unchanged_p, check_point_in_composition)
2361 (reconsider_clip_changes)
2362 (redisplay_internal, set_cursor_from_row, try_scrolling)
2363 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2364 (redisplay_window, find_last_unchanged_at_beg_row)
2365 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2366 (trailing_whitespace_p, find_row_edges, display_line)
2367 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2368 (display_mode_element, store_mode_line_string)
2369 (pint2str, pint2hrstr, decode_mode_spec)
2370 (display_count_lines, display_string, draw_glyphs)
2371 (x_produce_glyphs, x_insert_glyphs)
2372 (rows_from_pos_range, mouse_face_from_buffer_pos)
2373 (fast_find_string_pos, mouse_face_from_string_pos)
2374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2376 (safe_call, init_from_display_pos, handle_fontified_prop)
2377 (handle_single_display_spec, load_overlay_strings)
2378 (with_echo_area_buffer, setup_echo_area_for_printing)
2379 (display_echo_area, echo_area_display)
2380 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2381 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2382 (redisplay_window, dump_glyph_row, display_mode_line)
2383 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2384 (handle_display_spec, display_prop_string_p):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (handle_single_display_spec, build_desired_tool_bar_string)
2387 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2388 (get_specified_cursor_type):
2389 Check that fixnums are in proper range for system types.
2390 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2391 (Flookup_image_map):
2392 Don't assume fixnums fit in int.
2393 (compare_overlay_entries):
2394 Avoid mishandling comparisons due to subtraction overflow.
2395 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2396 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2397 (handle_tool_bar_click):
2398 Use int, not unsigned, since we prefer signed and the signedness
2399 doesn't matter here.
2400 (get_next_display_element, next_element_from_display_vector):
2401 Use int, not EMACS_INT, when int is wide enough.
2402 (start_hourglass): Use duration_to_sec_usec to do proper
2403 overflow checking on durations.
2404 * xfaces.c (Fbitmap_spec_p):
2405 Check that fixnums are in proper range for system types.
2406 (compare_fonts_by_sort_order):
2407 Avoid mishandling comparisons due to subtraction overflow.
2408 (Fx_family_fonts, realize_basic_faces):
2409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2411 Don't assume fixnum fits in int.
2412 Use SAFE_ALLOCA_LISP, not alloca.
2413 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2414 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2415 (face_at_buffer_position, face_for_overlay_string)
2416 (face_at_string_position):
2417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2418 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2421 Check that fixnums are in proper range for system types.
2422 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2423 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2425 (Fx_change_window_property): Don't assume fixnums fit in int.
2426 * xfont.c (xfont_chars_supported):
2427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2428 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2429 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 * xml.c (parse_region):
2432 * xrdb.c (magic_file_p):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2435 (x_get_local_selection, x_reply_selection_request)
2436 (x_handle_selection_request, wait_for_property_change):
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2439 short is wide enough.
2440 (x_send_client_event): Don't assume fixnum fits in int.
2441 * xterm.c (x_x_to_emacs_modifiers):
2442 Don't assume EMACS_INT overflows nicely into int.
2443 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2445 (handle_one_xevent): NATNUMP can eval its arg twice.
2446 (x_connection_closed):
2447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2448 * xterm.h: Adjust decls to match defn changes elsewhere.
2449 (struct scroll_bar): Use struct vectorlike_header
2450 rather than rolling our own approximation.
2451 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2453 2012-05-25 Glenn Morris <rgm@gnu.org>
2455 * lisp.mk (lisp): Update for more files being compiled now.
2457 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2459 * lread.c: Remove `read_pure' which makes no difference.
2460 (read_pure): Remove var.
2461 (unreadpure): Remove function.
2462 (readevalloop): Don't call read_list with -1 flag.
2463 (read1, read_vector): Don't test read_pure any more.
2464 (read_list): Simplify.
2466 * fileio.c, character.h: Minor style tweaks.
2468 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2470 * window.h (clip_changed): Remove useless declaration.
2472 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2474 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2475 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2477 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2480 This directory predates autoconf and is no longer needed nowadays.
2481 Move its few remaining bits of functionality to where they're needed.
2482 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2483 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2484 * m/template.h: Remove.
2485 * Makefile.in (M_FILE): Remove. All uses removed.
2486 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2487 * lisp.h (USE_LSB_TAG):
2488 * mem-limits.h (EXCEEDS_LISP_PTR):
2489 Use VAL_MAX, not VALBITS, in #if.
2490 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2491 (EMACS_UINT): Define unconditionally now.
2492 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2493 (BITS_PER_EMACS_INT): New constants, replacing
2494 what used to be in config.h, but not useful in #if.
2495 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2496 define them any more.
2497 (VAL_MAX): New macro.
2499 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2500 BITS_PER_EMACS_INT, in #if.
2501 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2502 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2503 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2504 * s/ms-w32.h (DATA_START):
2505 Move here from removed file m/intel386.h.
2506 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2507 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2509 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2511 Assume C89 or later.
2512 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2513 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2515 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2516 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2517 * textprop.c, tparam.c (NULL): Remove.
2518 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2519 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2520 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2521 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2522 * xterm.c (input_signal_count): Assume volatile works.
2524 2012-05-21 Ken Brown <kbrown@cornell.edu>
2526 * xgselect.c (xg_select): Fix first argument in call to 'select'
2529 2012-05-20 Ken Brown <kbrown@cornell.edu>
2531 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2532 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2534 2012-05-19 Ken Brown <kbrown@cornell.edu>
2536 * xfns.c (x_in_use): Remove `static' qualifier.
2537 * xterm.h (x_in_use): Declare.
2538 * xgselect.c: Include xterm.h.
2539 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2540 and `display_arg' (bug#9754).
2542 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2544 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2546 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2547 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2549 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2551 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2553 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2554 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2556 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2557 reference to image_cache->refcount.
2558 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2560 2012-05-17 Juri Linkov <juri@jurta.org>
2562 * search.c (Fword_search_regexp, Fword_search_backward)
2563 (Fword_search_forward, Fword_search_backward_lax)
2564 (Fword_search_forward_lax): Move functions to isearch.el
2565 (bug#10145, bug#11381).
2567 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2569 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2571 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2573 * lread.c (init_obarray): Declare Qt and Qnil as special.
2575 2012-05-14 Glenn Morris <rgm@gnu.org>
2577 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2578 Put "libexec" before "bin", for the sake of init_callproc_1.
2580 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2582 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2584 * unexaix.c: Port to more-recent AIX compilers.
2585 (report_error, report_error_1, make_hdr, copy_sym)
2586 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2587 Make arguments const char *, not char *, to avoid violations of C
2588 standard and to fix some AIX warnings reported by Gilles Pion.
2590 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2592 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2593 already have overlays loaded.
2594 (handle_single_display_spec): Before returning without displaying
2595 fringe bitmap, synchronize the bidi iterator with the main display
2596 iterator, by calling iterate_out_of_display_property.
2597 (iterate_out_of_display_property): Detect buffer iteration by
2598 testing that it->string is a Lisp string.
2599 (get_next_display_element): When the current object is exhausted,
2600 and there's something on it->stack, call set_iterator_to_next to
2601 proceed with what's on the stack, instead of returning zero.
2602 (set_iterator_to_next): If called at the end of a Lisp string,
2603 proceed to consider_string_end without incrementing string
2604 position. Don't increment display vector index past the end of
2605 the display vector. (Bug#11417)
2606 (pos_visible_p): Don't report a position visible when move_it_to
2607 stopped at the last line of window, which happens to be scanned
2608 backwards by the bidi iteration. (Bug#11464)
2610 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2612 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2613 and right-margin display specs even if the spec is invalid or we
2614 are on a TTY, and thus unable to display on the fringes.
2615 That's because the text with the property will not be displayed anyway,
2616 so we need to signal to the caller that this is a "replacing"
2617 display spec. This fixes display when the spec is invalid or we
2620 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2622 * unexaix.c (make_hdr): Fix typo in prototype.
2623 This bug broke the build on AIX. Problem reported by Gilles Pion.
2625 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2627 * keyboard.c (kbd_buffer_get_event): Read special events also in
2628 batch mode. (Bug#11415)
2630 2012-05-12 Glenn Morris <rgm@gnu.org>
2632 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2634 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2636 * lisp.mk (lisp): Add newcomment.elc.
2638 2012-05-12 Glenn Morris <rgm@gnu.org>
2640 * Makefile.in (MKDIR_P): New, set by configure.
2641 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2643 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2645 Remove unused function hourglass_started.
2646 * dispextern.h (hourglass_started):
2647 * w32fns.c (hourglass_started):
2648 * xdisp.c (hourglass_started): Remove.
2650 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2652 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2653 Update dependencies.
2655 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2657 * xgselect.c (xg_select): Put maxfds+1 into a var.
2658 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2660 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2662 2012-05-10 Dave Abrahams <dave@boostpro.com>
2664 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2665 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2667 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2669 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2670 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2671 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2672 Initialize xd_registered_buses.
2674 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2676 Untag more efficiently if USE_LSB_TAG.
2677 This is based on a proposal by YAMAMOTO Mitsuharu in
2678 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2679 For an admittedly artificial (nth 8000 longlist) benchmark on
2680 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2681 Emacs's overall text size by 1%.
2682 * lisp.h (XUNTAG): New macro.
2683 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2684 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2685 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2686 * eval.c (Fautoload):
2687 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2688 * frame.h (XFRAME): Use XUNTAG.
2690 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2691 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2692 Remove unportable assumptions about print widths of types like
2694 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2695 intptr_t when converting between pointer and integer, to avoid GCC
2696 warnings about wrong width.
2698 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2700 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2701 stack for each reader_thread, instead of defaulting to 8MB
2702 determined by the linker. This avoids failures in creating
2703 subprocesses on Windows 7, see the discussion in this thread:
2704 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2706 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2708 Fix up display of the *Minibuf-0* buffer in the mini window.
2709 * keyboard.c (read_char): Don't clear the echo area if there's no
2711 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2712 contents of *Minibuf-0*) if there's no message displayed in its stead.
2714 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2716 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2719 2012-05-06 Chong Yidong <cyd@gnu.org>
2721 * lisp.mk (lisp): Update.
2723 2012-05-05 Jim Meyering <meyering@redhat.com>
2725 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2727 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2729 * data.c (PUT_ERROR): New macro.
2730 (syms_of_data): Use it. Add new error type `user-error'.
2731 * undo.c (user_error): New function.
2732 (Fprimitive_undo): Use it.
2733 * print.c (print_error_message): Adjust print style for `user-error'.
2734 * keyboard.c (user_error): New function.
2735 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2737 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2739 Do not limit current-time-string to years 1000..9999.
2740 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2741 (Fcurrent_time_string): Support any year that is supported by the
2742 underlying localtime representation. Don't use asctime, as it
2743 has undefined behavior for years outside the range -999..9999.
2745 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2747 Fix race conditions involving setenv, gmtime, localtime, asctime.
2748 Without this fix, interrupts could mess up code that uses these
2749 nonreentrant functions, since setting TZ invalidates existing
2750 tm_zone or tzname values, and since most of these functions return
2751 pointers to static storage.
2752 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2753 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2754 Grow the critical sections to include not just invoking
2755 localtime/gmtime, but also accessing these functions' results
2756 including their tm_zone values if any, and any related TZ setting.
2757 (format_time_string): Last arg is now struct tm *, not struct tm **,
2758 so that the struct tm is saved in the critical section.
2759 All callers changed. Simplify allocation of initial buffer, partly
2760 motivated by the fact that memory allocation needs to be outside
2761 the critical section.
2763 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2765 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2766 with RESET_INTERVAL.
2768 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2769 Remove duplicated buffer name initialization.
2771 2012-05-02 Jim Meyering <jim@meyering.net>
2773 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2775 * xfns.c (x_window): Use xstrdup (Bug#11375).
2777 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2779 * xdisp.c (pos_visible_p): If already at a newline from the
2780 display string before the 'while' loop, don't walk back the glyphs
2781 from it3.glyph_row. Solves assertion violation when the display
2782 string begins with a newline (egg.el). (Bug#11367)
2784 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2786 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2789 2012-05-01 Glenn Morris <rgm@gnu.org>
2791 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2792 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2793 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2794 All were removed before 23.1.
2796 * dispnew.c: Remove HAVE_LIBNCURSES test;
2797 it is always true on relevant platforms.
2799 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2800 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2802 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2804 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2806 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2807 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2810 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2812 Do not avoid creating empty evaporating overlays (Bug#9642).
2813 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2814 That is, do not delete an evaporating overlay if it becomes
2815 empty after its bounds are adjusted to fit within its buffer.
2816 This fix caused other problems, and I'm reverting it until we get
2817 to the bottom of them.
2819 2012-04-27 Chong Yidong <cyd@gnu.org>
2821 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2823 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2825 * xdisp.c (pos_visible_p): If the window start position is beyond
2826 ZV, start the display from buffer beginning. Prevents assertion
2827 violation in init_iterator when the minibuffer window is scrolled
2830 * window.c (window_scroll_pixel_based): Likewise.
2832 2012-04-27 Chong Yidong <cyd@gnu.org>
2834 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2836 2012-04-27 Glenn Morris <rgm@gnu.org>
2838 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2839 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2841 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2843 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2844 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2846 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2848 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2849 display element, check also the underlying string or buffer
2850 character. (Bug#11341)
2852 * w32menu.c: Include w32heap.h.
2853 (add_menu_item): If the call to AppendMenuW (via
2854 unicode_append_menu) fails, disable Unicode menus only if we are
2855 running on Windows 9X/Me.
2857 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2859 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2860 (xgetint): Add missing shift for LSB tags.
2862 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2864 * keyboard.c (read_char): Don't wipe echo area for select window
2865 events: These might get delayed via `mouse-autoselect-window'
2868 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2870 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2871 manipulation of :loaded-from data.
2873 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2875 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2876 now a cons (bug#11311).
2878 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2880 Do not create empty overlays with the evaporate property (Bug#9642).
2881 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2882 if it becomes empty after its bounds are adjusted to fit within
2883 its buffer. Without this fix, in a nonempty buffer (let ((o
2884 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2885 yields an empty overlay that has the evaporate property, which is
2886 not supposed to happen.
2888 Fix minor GTK3 problems found by static checking.
2889 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2890 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2891 (struct _EmacsFixedClass, emacs_fixed_get_type):
2892 Move decls here from emacsgtkfixed.h, since they needn't be public.
2893 (emacs_fixed_get_type): Now static.
2894 (emacs_fixed_class_init): Omit unused local.
2895 (emacs_fixed_child_type): Remove; unused.
2896 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2897 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2898 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2899 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2900 (EMACS_FIXED_GET_CLASS): Remove; unused.
2901 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2903 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2904 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2906 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2908 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2909 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2910 (__malloc_size_t, __malloc_ptrdiff_t):
2911 Remove. All uses removed, replaced by the definiens if needed,
2912 since we can assume C89 or better now.
2913 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2914 (protect_malloc_state, align, get_contiguous_space)
2915 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2916 (malloc_atfork_handler_child, malloc_enable_thread)
2917 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2918 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2919 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2920 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2921 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2922 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2923 Define using prototypes, not old style.
2924 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2925 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2926 (align): Don't assume that signed integer overflow wraps around.
2927 Omit unused local var.
2928 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2929 (_free_internal_nolock, memalign, mallochook, reallochook):
2930 Omit no-longer-needed casts.
2931 (valloc): Use getpagesize, not __getpagesize.
2932 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2933 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2935 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2937 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2939 Move functions from C to Lisp. Make non-blocking method calls
2940 the default. Implement further D-Bus standard interfaces.
2942 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2943 (QCdbus_request_name_allow_replacement)
2944 (QCdbus_request_name_replace_existing)
2945 (QCdbus_request_name_do_not_queue)
2946 (QCdbus_request_name_reply_primary_owner)
2947 (QCdbus_request_name_reply_in_queue)
2948 (QCdbus_request_name_reply_exists)
2949 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2950 (QCdbus_registered_serial, QCdbus_registered_method)
2951 (QCdbus_registered_signal): New Lisp objects.
2952 (XD_DEBUG_MESSAGE): Use sizeof.
2953 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2954 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2955 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2956 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2957 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2958 (xd_signature, xd_append_arg): Allow float for integer types.
2959 (xd_get_connection_references): New function.
2960 (xd_get_connection_address): Rename from xd_initialize.
2961 Return cached address.
2962 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2963 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2965 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2966 Return number of refcounts.
2967 (Fdbus_get_unique_name): Make stronger parameter check.
2968 (Fdbus_message_internal): New defun.
2969 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2970 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2971 (Fdbus_send_signal, Fdbus_register_service)
2972 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2973 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2974 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2975 (Vdbus_compiled_version, Vdbus_runtime_version)
2976 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2977 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2978 (Vdbus_message_type_signal): New defvars.
2979 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2982 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2984 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2985 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2986 Do not assume ptrdiff_t is the same width as 'int'.
2988 * alloc.c: Handle unusual debugging option combinations.
2989 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2990 since the two debugging options are incompatible.
2991 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2993 (mem_init, mem_insert, mem_insert_fixup):
2994 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2995 (NEED_MEM_INSERT): Remove; no longer needed.
2997 2012-04-22 Leo Liu <sdl.web@gmail.com>
2999 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3001 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3003 * sysdep.c [__FreeBSD__]: Minor cleanups.
3004 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3005 Use Emacs indenting style more consistently. Avoid some casts.
3006 Use 'double' consistently rather than mixing 'float' and 'double'.
3008 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3010 * sysdep.c (list_system_processes, system_process_attributes):
3011 Add implementation for FreeBSD (Bug#5243).
3013 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3015 * lisp.mk (lisp): Update.
3017 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3019 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3020 It is never used otherwise.
3022 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3024 * print.c (print_preprocess): Only check print_depth if print-circle
3026 (print_object): Check for cycles even when print-circle is nil and
3027 print-gensym is t, but only check print_depth if print-circle is nil.
3029 2012-04-20 Chong Yidong <cyd@gnu.org>
3031 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3032 set the status to "failed" and ensure that sentinel is run.
3034 2012-04-20 Glenn Morris <rgm@gnu.org>
3036 * process.c (Fset_process_inherit_coding_system_flag)
3037 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3038 (Fmake_network_process, Fmake_serial_process): Doc fix.
3040 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3042 * xdisp.c (string_buffer_position_lim): Limit starting position to
3044 (set_cursor_from_row): If called for a mode-line or header-line
3045 row, return zero immediately.
3046 (try_cursor_movement): If inside continuation line, don't back up
3047 farther than the first row after the header line, if any.
3048 Don't consider the header-line row as "partially visible", even if
3049 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3051 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3053 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3056 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3057 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3059 configure: new option --enable-gcc-warnings (Bug#11207)
3060 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3061 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3062 (ALL_CFLAGS): Use new macros rather than old.
3063 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3064 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3065 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3066 -Wunused-result, -Wunused-variable. This should go away once
3067 the Emacs and Gnulib regex code is merged.
3068 (xmalloc, xrealloc): Now static.
3070 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3072 * dired.c (Fsystem_groups): Remove unused local.
3074 2012-04-17 Glenn Morris <rgm@gnu.org>
3076 * dired.c (Fsystem_users): Doc fix.
3078 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3080 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3081 (syms_of_dired): Add them.
3083 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3085 Fix minor alloc.c problems found by static checking.
3086 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3087 New extern decls, to avoid calling undeclared functions.
3088 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3089 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3090 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3091 (NEED_MEM_INSERT): New macro.
3092 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3093 Remove one incorrect comment and fix another.
3095 Fix minor ralloc.c problems found by static checking.
3096 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3097 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3098 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3099 (r_alloc_sbrk): Now static.
3101 Improve ralloc.c interface checking.
3102 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3103 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3104 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3105 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3106 [REL_ALLOC]: ... to here, to check interface.
3107 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3108 Remove decls. This fixes an "It stinks!".
3110 * alloc.c (which_symbols): Fix alignment issue / type clash.
3112 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3114 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3115 (struct Lisp_Misc_Any): Likewise.
3116 (struct Lisp_Free): Likewise.
3117 * alloc.c (union aligned_Lisp_Symbol): Define.
3118 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3119 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3120 (union aligned_Lisp_Misc): Define.
3121 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3122 aligned_Lisp_Misc instead of union Lisp_Misc.
3123 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3125 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3127 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3128 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3129 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3130 * s/netbsd.h, s/sol2-6.h:
3131 Remove definition of GC_MARK_STACK, since the default now works.
3132 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3133 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3134 no longer the default.
3135 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3137 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3139 * lread.c (lisp_file_lexically_bound_p):
3140 Fix hang at ";-*-\n" (bug#11238).
3142 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3147 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3149 * nsterm.m (constrainFrameRect): Always constrain when there is only
3150 one screen (Bug#10962).
3152 2012-04-13 Ken Brown <kbrown@cornell.edu>
3154 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3156 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3158 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3160 2012-04-11 Daniel Colascione <dancol@dancol.org>
3162 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3163 against is gone. It's better to use vfork now so that when Cygwin
3164 gains a new, working vfork, we use it automatically (bug#10398).
3166 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3168 * window.c (save_window_save): Obey window-point-insertion-type.
3170 2012-04-11 Glenn Morris <rgm@gnu.org>
3172 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3174 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3178 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3180 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3181 (force_quit_count): New var.
3182 (handle_interrupt): Use it.
3184 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3186 * w32.c (w32_delayed_load): Record the full path of the library
3187 being loaded (bug#10424).
3189 2012-04-09 Glenn Morris <rgm@gnu.org>
3191 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3192 not just in the obarray, before snarfing them. (Bug#11036)
3194 * Makefile.in ($(leimdir)/leim-list.el):
3195 Pass EMACS rather than BUILT_EMACS.
3197 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3199 * process.c (make_process):
3200 * process.h: Add integer `gnutls_handshakes_tried' member to
3203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3204 Add convenience `GNUTLS_LOG2i' macro.
3206 * gnutls.c (gnutls_log_function2i): Convenience log function.
3207 (emacs_gnutls_read): Use new log functions,
3208 `gnutls_handshakes_tried' process member, and
3209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3210 attempts per process (connection).
3212 2012-04-09 Chong Yidong <cyd@gnu.org>
3214 * eval.c (Fuser_variable_p, user_variable_p_eh)
3215 (lisp_indirect_variable): Functions deleted.
3216 (Fdefvar): Caller changed.
3218 * callint.c (Finteractive, Fcall_interactively):
3219 * minibuf.c (Fread_variable): Callers changed.
3221 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3223 * xdisp.c (set_cursor_from_row): If the display string appears in
3224 the buffer at position that is closer to point than the position
3225 after the display string, display the cursor on the first glyph of
3226 the display string. Fixes cursor display when a 'display' text
3227 property immediately follows invisible text. (Bug#11094)
3229 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3231 composite.c: use 'double' consistently
3232 * composite.c (get_composition_id): Use 'double' consistently
3233 instead of converting 'float' to 'double' and vice versa; this is
3234 easier to understand and avoids a GCC warning.
3236 2012-04-09 Glenn Morris <rgm@gnu.org>
3238 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3239 preparation for dumping it with emacs. (Bug#4789)
3240 (leimdir): New variable.
3241 ($(leimdir)/leim-list.el): New rule.
3242 (emacs$(EXEEXT)): Depend on leim-list.el.
3244 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3245 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3246 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3248 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3250 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3253 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3255 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3256 Remove unused local variable.
3258 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3260 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3262 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3263 objects, as mark_maybe_pointer will catch them otherwise.
3264 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3265 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3267 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3269 Fix typo that broke non-Windows builds.
3270 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3272 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3274 Support building on MS-Windows with libxml2.
3276 * makefile.w32-in (OBJ2): Add xml.$(O).
3277 (GLOBAL_SOURCES): Add xml.c.
3278 ($(BLD)/xml.$(O)): New dependency list.
3280 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3281 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3282 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3283 [!WINDOWSNT]: New macros.
3284 (init_libxml2_functions, libxml2_loaded_p): New functions.
3285 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3286 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3287 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3288 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3290 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3291 Call init_libxml2_functions before calling libxml2 functions.
3292 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3294 * emacs.c: Don't include libxml/parser.h.
3295 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3296 xmlCleanupParser directly.
3298 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3300 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3302 * indent.c (Fvertical_motion): If there is a display string at
3303 point, use it.vpos to compute how many lines to backtrack after
3304 move_it_to point. (Bug#11133)
3306 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3308 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3309 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3310 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3311 macros related to unification of CJK characters. For the details,
3312 see the discussion following the message here:
3313 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3315 2012-04-04 Chong Yidong <cyd@gnu.org>
3317 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3319 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3321 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3322 instead of alloca. (Bug#11138)
3324 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3326 * w32menu.c (is_simple_dialog): Properly check lisp types.
3329 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3331 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3332 position we get to after a call to move_it_to fails the
3333 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3334 only if we wind up in a string from display property. (Bug#11063)
3336 * window.c (Fdelete_other_windows_internal): Invalidate the row
3337 and column information about mouse highlight, so that redisplay
3338 restores it after reallocating the glyph matrices. (Bug#7464)
3340 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3341 string comes from a `display' text property, use the buffer
3342 position of that property as if we actually saw that position in
3344 (move_it_by_lines): Remove the assertion that
3345 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3346 violated when there's a before-string at the beginning of a line.
3349 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3351 * xdisp.c (append_space_for_newline): If the default face was
3352 remapped, use the remapped face for the appended newline.
3353 (extend_face_to_end_of_line): Use the remapped default face for
3354 extending the face to the end of the line.
3355 (display_line): Call extend_face_to_end_of_line when the default
3356 face was remapped. (Bug#11068)
3358 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3360 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3362 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3364 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3366 2012-03-27 Glenn Morris <rgm@gnu.org>
3368 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3371 2012-03-26 Kenichi Handa <handa@m17n.org>
3373 * dispextern.h (struct glyph): Fix previous change. Change the
3374 bit length of glyphless.ch to 25 (Bug#11082).
3376 2012-03-26 Chong Yidong <cyd@gnu.org>
3378 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3379 (command_loop_1): Use it; inhibit selection update for
3380 handle-select-window too (Bug#8996).
3382 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3384 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3386 2012-03-25 Kenichi Handa <handa@m17n.org>
3388 * dispextern.h (struct glyph): Change the bit length of
3389 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3391 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3393 * s/ms-w32.h (tzname): Include time.h before redirecting to
3394 _tzname. Fixes the MSVC build. (Bug#9960)
3396 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3398 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3401 * xterm.c (XTread_socket): Only modify handling_signal if
3402 !SYNC_INPUT. (Bug#11080)
3404 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3406 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3407 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3408 when fetching a multibyte character consumes more bytes than
3409 CHAR_BYTES returns, due to unification of CJK characters in
3410 string_char. (Bug#11073)
3412 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3414 * process.c (wait_reading_process_output): Handle pty disconnect
3415 by refraining from sending oneself a SIGCHLD (bug#10933).
3417 2012-03-22 Chong Yidong <cyd@gnu.org>
3419 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3421 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3422 Mark string as coming from a prefix property.
3423 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3424 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3426 2012-03-21 Chong Yidong <cyd@gnu.org>
3428 * xfaces.c (Vface_remapping_alist): Doc fix.
3430 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3432 * w32proc.c (Fw32_set_console_codepage)
3433 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3436 2012-03-20 Chong Yidong <cyd@gnu.org>
3438 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3439 to reflect default non-nil value of redisplay-dont-pause.
3441 2012-03-19 Kenichi Handa <handa@m17n.org>
3443 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3444 it fit in a valid range (Bug#11003).
3446 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3448 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3449 that is not from display property, accept the row as a "cursor
3450 row" if one of the string's character has a non-nil `cursor'
3451 property. Fixes cursor positioning when there are newlines in
3452 overlay strings, e.g. in icomplete.el. (Bug#11035)
3454 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3456 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3458 2012-03-12 Chong Yidong <cyd@gnu.org>
3460 * eval.c (inhibit_lisp_code): Rename from
3461 inhibit_window_configuration_change_hook; move from window.c.
3463 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3464 * window.c (run_window_configuration_change_hook)
3465 (syms_of_window): Callers changed.
3467 2012-03-11 Chong Yidong <cyd@gnu.org>
3469 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3471 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3473 2012-03-10 Chong Yidong <cyd@gnu.org>
3475 * frame.c (other_visible_frames): Don't assume the selected frame
3476 is visible (Bug#10955).
3478 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3480 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3482 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3484 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3485 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3488 2012-03-03 Glenn Morris <rgm@gnu.org>
3490 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3492 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3494 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3495 position past the first glyph_row that ends at ZV. (Bug#10902)
3496 (redisplay_window, next_element_from_string): Fix typos in
3498 (redisplay_window): Pass to move_it_vertically the margin in
3499 pixels, not in screen lines.
3501 2012-03-02 Glenn Morris <rgm@gnu.org>
3503 * buffer.c (buffer-list-update-hook): Doc fix.
3505 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3507 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3508 push_it before setting up the iterator for the first overlay
3509 string, even if we have an empty string loaded.
3510 (next_overlay_string): If there's an empty string on the iterator
3511 stack, pop the stack. (Bug#10903)
3513 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3515 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3516 Suggested by Stefan Monnier in
3517 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3518 * alloc.c (widen_to_Lisp_Object): New static function.
3519 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3520 and widening them to Lisp_Objects. This would work even if
3521 USE_LSB_TAG is defined and wide integers are used, which might
3522 happen in a future version of Emacs.
3524 2012-02-25 Chong Yidong <cyd@gnu.org>
3526 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3529 * xselect.c (Fx_selection_exists_p): Doc fix.
3530 (x_clipboard_manager_save_all): Print an informative message
3531 before saving to clipboard manager.
3533 2012-02-24 Chong Yidong <cyd@gnu.org>
3535 * keyboard.c (process_special_events): Handle all X selection
3536 requests in kbd_buffer, not just the next one (Bug#8869).
3538 2012-02-23 Chong Yidong <cyd@gnu.org>
3540 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3541 call when setting menu-bar-lines and tool-bar-lines parameters.
3542 (unwind_create_frame_1): New helper function.
3544 * window.c (inhibit_window_configuration_change_hook): New var.
3545 (run_window_configuration_change_hook): Obey it.
3546 (syms_of_window): Initialize it.
3548 2012-02-22 Chong Yidong <cyd@gnu.org>
3550 * xterm.c (x_draw_image_relief): Add missing type check for
3551 Vtool_bar_button_margin (Bug#10743).
3553 2012-02-21 Chong Yidong <cyd@gnu.org>
3555 * fileio.c (Vfile_name_handler_alist): Doc fix.
3557 * buffer.c (Fget_file_buffer): Protect against invalid file
3558 handler return value.
3560 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3562 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3563 when computing $valmask.
3565 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3566 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3567 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3568 It's useless in that case, and it can cause problems on hosts
3569 that allocate halves of EMACS_INT values separately.
3570 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3572 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3573 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3574 it avoids undefined behavior on hosts where shifting right by more
3575 than the word width has undefined behavior.
3577 2012-02-19 Chong Yidong <cyd@gnu.org>
3579 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3580 (Funhandled_file_name_directory, Ffile_name_as_directory)
3581 (Fdirectory_file_name, Fexpand_file_name)
3582 (Fsubstitute_in_file_name): Protect against invalid file handler
3583 return values (Bug#10845).
3585 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3587 * .gdbinit (pitx): Fix incorrect references to fields of the
3590 2012-02-17 Chong Yidong <cyd@gnu.org>
3592 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3594 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3596 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3597 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3599 2012-02-15 Chong Yidong <cyd@gnu.org>
3601 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3602 marked as special. Also, starting docstrings with * is obsolete.
3604 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3606 * gnutls.c (emacs_gnutls_write): Fix last change.
3608 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3610 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3613 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3615 * keymap.c (Fsingle_key_description): Handle char ranges.
3617 2012-02-12 Chong Yidong <cyd@gnu.org>
3619 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3620 as that creates a dangerous corner case.
3622 * window.c (Fdelete_window_internal): Invalidate the mouse
3623 highlight (Bug#9904).
3625 2012-02-12 Glenn Morris <rgm@gnu.org>
3627 * xselect.c (Fx_own_selection_internal)
3628 (Fx_get_selection_internal, Fx_disown_selection_internal)
3629 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3630 * nsselect.m (Fx_own_selection_internal)
3631 (Fx_disown_selection_internal, Fx_selection_exists_p)
3632 (Fx_selection_owner_p, Fx_get_selection_internal):
3633 Sync docs and argument specs with the xselect.c versions.
3635 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3637 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3639 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3641 * w32select.c (Fx_selection_exists_p): Sync doc string and
3642 argument list with xselect.c. (Bug#10783)
3644 * w16select.c (Fx_selection_exists_p): Sync doc string and
3645 argument list with xselect.c. (Bug#10783)
3647 2012-02-10 Glenn Morris <rgm@gnu.org>
3649 * fns.c (Fsecure_hash): Doc fix.
3651 2012-02-09 Kenichi Handa <handa@m17n.org>
3653 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3655 2012-02-07 Chong Yidong <cyd@gnu.org>
3657 * buffer.c (Fbuffer_local_variables)
3658 (buffer_lisp_local_variables): Handle unbound vars correctly;
3659 don't let Qunbound leak into Lisp.
3661 2012-02-07 Glenn Morris <rgm@gnu.org>
3663 * image.c (Fimagemagick_types): Doc fix.
3665 * image.c (imagemagick-render-type): Change it from a lisp object
3666 to an integer. Move the doc here from the lisp manual.
3667 Treat all values not equal to 0 the same.
3669 2012-02-06 Chong Yidong <cyd@gnu.org>
3671 * doc.c (store_function_docstring): Avoid applying docstring of
3672 alias to base function (Bug#2603).
3674 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3676 * .gdbinit (pp1, pv1): Remove redundant defines.
3679 2012-02-04 Chong Yidong <cyd@gnu.org>
3681 * nsterm.m: Declare a global (Bug#10694).
3683 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3685 * w32.c (get_emacs_configuration_options):
3686 Include --enable-checking, if specified, in the return value.
3688 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3690 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3691 after rounding frame sizes. (Bug#9723)
3693 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3695 * keyboard.c (adjust_point_for_property): Don't position point
3696 before BEGV. (Bug#10696)
3698 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3700 Handle overflow when computing char display width (Bug#9496).
3701 * character.c (char_width): Return EMACS_INT, not int.
3702 (char_width, c_string_width): Check for overflow when
3703 computing the width; this is possible now that individual
3704 characters can have unbounded width. Problem introduced
3705 by merge from Emacs 23 on 2012-01-19.
3707 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3709 * dbusbind.c (Fdbus_register_method): Mention the return value
3710 :ignore in the docstring.
3712 2012-02-02 Glenn Morris <rgm@gnu.org>
3714 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3716 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3717 Unconditionally set to t. (Bug#10673)
3718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3719 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3720 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3722 2012-02-02 Kenichi Handa <handa@m17n.org>
3724 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3725 0, do not call append_composite_glyph.
3727 2012-02-02 Kenichi Handa <handa@m17n.org>
3729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3731 (x_produce_glyphs): If the component of a composition is a null
3732 string, set it->pixel_width to 1 to avoid zero-width glyph.
3734 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3736 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3737 first 2 arguments are identical. This makes inserting large
3738 output from a subprocess an order of magnitude faster on
3739 MS-Windows, where all sbrk'ed memory is always contiguous.
3741 2012-01-31 Glenn Morris <rgm@gnu.org>
3743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3747 2012-01-29 Glenn Morris <rgm@gnu.org>
3749 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3751 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3753 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3755 2012-01-28 Chong Yidong <cyd@gnu.org>
3757 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3759 2012-01-26 Chong Yidong <cyd@gnu.org>
3761 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3763 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3764 repeat counts (Bug#10507).
3766 2012-01-26 Glenn Morris <rgm@gnu.org>
3768 * lread.c (syms_of_lread): Doc fix.
3770 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3772 * coding.c (encode_designation_at_bol): Change return value to
3775 2012-01-25 Chong Yidong <cyd@gnu.org>
3777 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3779 2012-01-21 Chong Yidong <cyd@gnu.org>
3781 * floatfns.c (Fcopysign): Make the second argument non-optional,
3782 since nil is not allowed anyway.
3784 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3786 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3787 (send_process): Likewise.
3789 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3791 * window.c (save_window_save, Fcurrent_window_configuration)
3792 (Vwindow_persistent_parameters): Do not use Qstate.
3793 Rewrite doc-strings.
3795 2012-01-19 Kenichi Handa <handa@m17n.org>
3797 * character.c (char_width): New function.
3798 (Fchar_width, c_string_width, lisp_string_width):
3799 Use char_width (Bug#9496).
3801 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3803 * window.c (Vwindow_persistent_parameters): New variable.
3804 (Fset_window_configuration, save_window_save): Handle persistent
3807 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3809 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3810 thrashing the stack of the thread. (Bug#9087)
3812 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3814 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3816 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3818 * xdisp.c (rows_from_pos_range): Handle the case where the
3819 highlight ends on a newline. (Bug#10464)
3820 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3821 he end column for display of highlight that ends on a newline
3824 2012-01-11 Glenn Morris <rgm@gnu.org>
3826 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3827 from load-path also when installation-directory is nil. (Bug#10208)
3829 2012-01-10 Glenn Morris <rgm@gnu.org>
3831 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3833 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3834 Update template values to be closer to their typical values these days.
3836 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3838 * xdisp.c (rows_from_pos_range): Accept additional argument
3839 DISP_STRING, and accept any glyph in a row whose object is that
3840 string as eligible for mouse highlight. Fixes mouse highlight of
3841 display strings from overlays. (Bug#10464)
3843 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3845 emacs: fix an auto-save permissions race condition (Bug#10400)
3846 * fileio.c (auto_saving_dir_umask): New static var.
3847 (Fmake_directory_internal): Use it.
3848 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3849 creating the directory. The old code temporarily assigns
3850 too-generous permissions to the directory.
3851 (do_auto_save_eh): Clear it.
3852 (Fdo_auto_save): Catch all errors, not just file errors, so
3853 that the var is always cleared.
3855 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3857 * search.c (scan_buffer): Pass character positions to
3858 know_region_cache, not byte positions. (Bug#6540)
3860 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3862 * w32.c (sys_rename): Report EXDEV when rename of a directory
3863 fails because the target is on another logical disk. (Bug#10284)
3865 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3867 * xterm.c (x_embed_request_focus): New function.
3869 * xterm.h: Add prototype.
3871 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3873 2012-01-05 Glenn Morris <rgm@gnu.org>
3875 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3877 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3879 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3880 Load gnutls_transport_set_lowat only if GnuTLS version is below
3882 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3883 GnuTLS versions below 2.11.1.
3885 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3887 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3888 to the doc string advising against its use for altering the way
3889 windows are scrolled.
3891 2011-12-28 Kenichi Handa <handa@m17n.org>
3893 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3894 coding-system ASCII compatible only when it does not produce BOM
3895 on encoding (Bug#10383).
3897 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3899 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3901 (create_and_show_popup_menu): Always use menu_position_func for
3904 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3906 * callint.c (Fcall_interactively): Don't truncate prompt string.
3908 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3910 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3911 property that ends at ZV, so that the bidi iteration could be
3912 resumed from there (after widening). (Bug#10360)
3914 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3916 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3918 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3920 * nsterm.m (x_free_frame_resources):
3921 Release f->output_data.ns->miniimage.
3922 (ns_index_color): Fix indentation. Do not retain
3923 color_table->colors[i].
3925 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3928 * nsfns.m (x_set_background_color): Assign return value from
3929 ns_index_color to face-background instead of NSColor*.
3930 (ns_implicitly_set_icon_type): Fix indentation.
3931 Change assignment in for loop to comparison.
3933 * emacs.c (ns_pool): New variable.
3934 (main): Assign ns_pool.
3935 (Fkill_emacs): Call ns_release_autorelease_pool.
3937 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3938 autorelease fdesc, release fdAttrs and tdict.
3939 (ns_get_covering_families): Release charset.
3940 (ns_findfonts): Release NSFontDescriptor created with new.
3941 (ns_uni_to_glyphs): Fix indentation.
3942 (setString): Release attrStr before assigning new value.
3944 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3946 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3948 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3949 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3951 2011-12-18 David Reitter <reitter@cmu.edu>
3953 * nsterm.m (ns_term_init): Subscribe for notifications
3954 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3955 to method trackingNotification in EmacsMenu.
3957 * nsmenu.m (trackingMenu): New variable.
3958 (trackingNotification): New method (from Aquamacs).
3959 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3960 from Aquamacs (Bug#7030).
3962 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3964 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3965 (symbol_to_nsstring): Fix indentation.
3966 (ns_symbol_to_pb): New function.
3967 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3968 (Fns_rotate_cut_buffers_internal): Remove.
3969 (Fns_store_selection_internal): Rename from
3970 Fns_store_cut_buffer_internal.
3971 (ns_get_foreign_selection, Fx_own_selection_internal)
3972 (Fx_disown_selection_internal, Fx_selection_exists_p)
3973 (Fns_get_selection_internal, Fns_store_selection_internal):
3974 Use ns_symbol_to_pb and check if return value is nil.
3975 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3976 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3977 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3978 renamed to Sns_store_selection_internal.
3979 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3980 and remove this function.
3981 (ns_handle_selection_clear): Remove, never used.
3982 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3985 2011-12-17 Ken Brown <kbrown@cornell.edu>
3987 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3988 GID is unknown (Bug#10257).
3990 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3992 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3993 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3994 which caused a build failure on GNU/Linux IA-64. This problem was
3995 introduced by my 2011-10-07 patch.
3997 2011-12-15 Juri Linkov <juri@jurta.org>
3999 * image.c (imagemagick_error): New function. (Bug#10112)
4000 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4001 Use `imagemagick_error' where ImageMagick functions return
4003 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4006 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4008 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4009 fill background (Bug#8992).
4011 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4013 * window.c (Vwindow_combination_resize)
4014 (Vwindow_combination_limit): Use t instead of non-nil in
4016 (Vrecenter_redisplay): Add first sentence of doc-string on
4018 (Frecenter): Fix doc-string typo.
4020 2011-12-11 Kenichi Handa <handa@m17n.org>
4022 * coding.c (Funencodable_char_position): Pay attention to the
4023 buffer text relocation (Bug#9389).
4025 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4027 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4028 gtk_init (Bug#10100).
4030 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4032 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4033 IT->string is nil. (Bug#10263)
4035 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4037 * nsterm.h (x_free_frame_resources): Declare.
4039 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4040 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4042 * nsterm.h (ns_get_defaults_value): Declare.
4044 * nsterm.m (ns_default): Call ns_get_defaults_value.
4046 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4048 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4051 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4053 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4054 that where the value of an _OBJC_* symbol points to is in the .bss
4055 section (Bug#10240).
4057 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4059 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4060 after the loop to call ccl_driver at least once (Bug#8619).
4062 2011-12-08 Kenichi Handa <handa@m17n.org>
4064 * ftfont.c (get_adstyle_property): Fix previous change
4067 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4069 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4070 dirs from the default value of EMACSLOADPATH (bug#10208).
4072 2011-12-07 Glenn Morris <rgm@gnu.org>
4074 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4075 installation and source directories as well. (Bug#10208)
4077 2011-12-06 Chong Yidong <cyd@gnu.org>
4079 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4081 2011-12-06 Glenn Morris <rgm@gnu.org>
4083 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4084 as an error, not just -1. (Bug#10217)
4086 2011-12-05 Chong Yidong <cyd@gnu.org>
4088 * keyboard.c (process_special_events): New function.
4089 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4091 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4093 * coding.c (encode_designation_at_bol): Don't use uninitialized
4094 local variable (Bug#9318).
4096 2011-12-05 Kenichi Handa <handa@m17n.org>
4098 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4099 return Qnil (Bug#8046, Bug#10193).
4101 2011-12-05 Kenichi Handa <handa@m17n.org>
4103 * coding.c (encode_designation_at_bol): New args charbuf_end and
4104 dst. Return the number of produced bytes. Callers changed.
4105 (coding_set_source): Return how many bytes coding->source was
4107 (coding_set_destination): Return how many bytes
4108 coding->destination was relocated.
4109 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4110 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4112 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4114 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4115 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4118 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4120 The following changes are to fix Bug#9318.
4122 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4123 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4124 (encode_coding_iso_2022, encode_coding_sjis)
4125 (encode_coding_big5, encode_coding_charset): Use the above macros.
4127 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4129 * lisp.h (process_quit_flag): Fix external declaration.
4131 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4133 Don't macro-inline non-performance-critical code.
4134 * eval.c (process_quit_flag): New function.
4135 * lisp.h (QUIT): Use it.
4137 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4139 * nsfns.m (get_geometry_from_preferences): New function.
4140 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4142 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4144 * emacs.c (Qkill_emacs): Define.
4145 (syms_of_emacs): Initialize it.
4146 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4147 Qquit_flag to `kill-emacs' instead.
4148 (quit_throw_to_read_char): Add parameter `from_signal'.
4149 All callers changed. Call Fkill_emacs if requested and safe.
4150 * lisp.h (QUIT): Call Fkill_emacs if requested.
4152 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4154 * widget.c (update_wm_hints): Return if wmshell is null.
4155 (widget_update_wm_size_hints): New function.
4157 * widget.h (widget_update_wm_size_hints): Declare.
4159 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4160 widget_update_wm_size_hints (Bug#10104).
4162 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4164 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4165 before a newline, prepare the bidi iterator for consuming the
4166 newline, and keep the current paragraph direction. (Bug#10183)
4167 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4169 2011-12-02 Juri Linkov <juri@jurta.org>
4171 * search.c (Fword_search_regexp): New Lisp function created from
4172 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4173 (Fword_search_backward, Fword_search_forward)
4174 (Fword_search_backward_lax, Fword_search_forward_lax):
4175 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4176 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4178 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4180 * fileio.c (Finsert_file_contents): Move after-change-function call
4181 to before the "handled:" label, since all "goto handled" appear in
4182 cases where the *-change-functions have already been properly called
4185 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4187 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4188 waiting for input. (Bug#10169)
4190 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4192 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4193 verifies glyph row's hash code--we have just reallocated the
4194 glyphs, so their contents can be complete garbage. (Bug#10164)
4196 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4200 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4203 attributes are tested _before_ calling verify_row_hash, to protect
4204 against GCC re-ordering of the tests. (Bug#10164)
4206 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4208 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4210 * xterm.c (handle_one_xevent): Only set async_visible and friends
4211 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4212 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4213 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4215 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4217 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4218 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4219 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4221 All uses changed to use GCPRO1 etc.
4222 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4223 Revert to old implementation (i.e., before 2011-03-11).
4225 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4227 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4228 of scroll runs so as to avoid assigning disabled bogus rows and
4229 unnecessary graphics copy operations.
4231 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4233 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4234 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4235 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4236 (malloc, free, realloc, calloc): Redirect to e_* only when
4239 * lisp.h (GCTYPEBITS): Move before first use.
4240 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4241 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4242 this macro definition.
4244 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4247 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4249 * gtkutil.c (xg_create_frame_widgets):
4250 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4251 present with Gtk+ 2.0.
4253 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4255 * fileio.c (Finsert_file_contents): Undo previous change; see
4256 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4258 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4260 Rename locals to avoid shadowing.
4261 * fileio.c (Finsert_file_contents):
4262 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4263 * process.c (wait_reading_process_output):
4264 Rename inner 'proc' to 'p' to avoid shadowing.
4265 Indent for consistency with usual Emacs style.
4267 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4269 * xdisp.c (redisplay_window): If cursor row is not fully visible
4270 after recentering, and scroll-conservatively is set to a large
4271 number, scroll window by a few more lines to make the cursor fully
4272 visible and out of scroll-margin. (Bug#10105)
4273 (start_display): Don't move to the next line if the display should
4274 start at a newline that is part of a display vector or an overlay
4277 2011-11-24 Juri Linkov <juri@jurta.org>
4279 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4280 after the `MagickPingImage' call. (Bug#10112)
4282 2011-11-23 Chong Yidong <cyd@gnu.org>
4284 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4286 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4288 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4289 making another buffer current. (Bug#10114)
4291 2011-11-23 Glenn Morris <rgm@gnu.org>
4293 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4295 2011-11-23 Chong Yidong <cyd@gnu.org>
4297 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4298 using it (Bug#5984).
4300 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4302 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4303 and header-lines, as they don't have one computed for them.
4306 * .gdbinit (prow): Make displayed values more self-explaining.
4307 Add row's hash code.
4309 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4311 * process.c (wait_reading_process_output): Fix asynchrounous
4312 GnuTLS socket handling on some versions of the GnuTLS library.
4313 (wait_reading_process_output): Add comment and URL.
4315 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4317 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4319 2011-11-21 Chong Yidong <cyd@gnu.org>
4321 * window.c (Fnext_window, Fprevious_window): Doc fix.
4323 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4325 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4327 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4329 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4331 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4333 * window.c (Fset_window_combination_limit): Rename argument
4335 (Vwindow_combination_limit): Remove "status" from doc-string.
4337 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4339 * m/ibms390.h: Remove.
4340 * m/ibms390x.h: Don't include "ibms390.h".
4342 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4344 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4345 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4347 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4349 * casetab.c (Fset_case_table):
4350 * charset.c (Fcharset_after): Fix typos.
4352 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4354 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4355 Otherwise, valgrind does not work on some platforms.
4356 Problem reported by Andreas Schwab in
4357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4358 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4359 is set, removing the need for VIRT_ADDRESS_VARIES.
4360 (PURE_P): Use a more-efficient implementation that needs just one
4361 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4362 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4363 to 4 (xorl, subq, cmpq, setbe).
4364 * alloc.c (pure): Always extern now, since that's the
4365 VIRT_ADDR_VARIES behavior.
4366 (PURE_POINTER_P): Use a single comparison, not two, for
4367 consistency with the new puresize.h.
4368 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4369 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4370 Remove VIRT_ADDR_VARIES no longer needed.
4372 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4374 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4375 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4376 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4377 behave as if the cursor position were at the window margin.
4379 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4380 and the cursor position is out of bounds, behave as if the cursor
4381 position were at the window margin. (Bug#10075)
4383 2011-11-18 Chong Yidong <cyd@gnu.org>
4385 * window.c (Fwindow_combination_limit): Make first argument
4386 non-optional, since it is meaningless for live windows like the
4389 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4391 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4393 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4395 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4396 (graft_intervals_into_buffer): Simplify.
4398 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4400 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4401 hash values of the two rows.
4402 (copy_row_except_pointers): Preserve the used[] arrays and the
4403 hash values of the two rows. (Bug#10035)
4404 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4406 * xdisp.c (row_hash): New function, body extracted from
4407 compute_line_metrics.
4408 (compute_line_metrics): Call row_hash, instead of computing the
4411 * dispnew.c (verify_row_hash): Call row_hash for computing the
4412 hash code of a row, instead of duplicating code from xdisp.c.
4414 * dispextern.h (row_hash): Add prototype.
4416 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4418 * frame.c (delete_frame): Don't delete the terminal when the last
4419 X frame is closed if emacs is built with GTK toolkit.
4421 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4423 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4425 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4427 * window.c (Vwindow_splits): Rename to
4428 Vwindow_combination_resize. Suggested by Juri Linkov.
4429 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4432 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4434 * nsfns.m (Fns_font_name):
4435 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4437 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4439 * window.h (window): Rename slot "nest" to "combination_limit".
4440 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4441 (Fset_window_nest): Rename to Fset_window_combination_limit.
4442 (Vwindow_nest): Rename to Vwindow_combination_limit.
4443 (recombine_windows, make_parent_window, make_window)
4444 (Fsplit_window_internal, saved_window)
4445 (Fset_window_configuration, save_window_save): Rename all
4446 occurrences of window_nest to window_combination_limit.
4448 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4450 * image.c (imagemagick_load_image): Fix typo.
4452 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4454 * xdisp.c (display_line): Move the call to
4455 highlight_trailing_whitespace before the call to
4456 compute_line_metrics, since the latter needs to see the final
4457 faces of all the glyphs to compute ROW's hash value.
4458 Fixes assertion violations in row_equal_p. (Bug#10035)
4460 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4462 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4463 just return (bug#10044).
4465 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4467 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4468 with user-defined heap size. Bump the default size of the temacs
4469 heap to 27MB, to avoid memory warning when running temacs.
4470 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4472 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4473 current_matrix and desired_matrix. (Bug#9990)
4474 (verify_row_hash) [XASSERTS]: New function.
4475 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4476 that the hash value of glyph rows is correct.
4478 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4480 * window.h (window): Remove splits slot.
4481 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4482 (Fdelete_other_windows_internal, make_parent_window)
4483 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4484 (Fset_window_configuration, save_window_save): Don't deal with
4485 split status of windows.
4486 (saved_window): Remove splits slot.
4487 (Vwindow_splits): Rewrite doc-string.
4489 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4491 * xfns.c (unwind_create_frame):
4492 * nsfns.m (unwind_create_frame):
4493 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4494 Vframe_list (Bug#9999).
4496 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4498 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4500 2011-11-11 Kenichi Handa <handa@m17n.org>
4502 * callproc.c (Fcall_process): Set the member dst_multibyte of
4505 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4507 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4508 avoid a crash (bug#9496).
4510 2011-11-09 Chong Yidong <cyd@gnu.org>
4512 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4513 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4515 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4517 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4519 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4521 Avoid some portability problems by eschewing 'extern inline' functions.
4522 The trivial performance wins aren't worth the portability hassles; see
4523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4526 (window_box_width, window_box_left, window_box_left_offset)
4527 (window_box_right, window_box_right_offset): Undo previous change,
4528 by removing the "extern"s.
4529 * intervals.c (adjust_intervals_for_insertion)
4530 (adjust_intervals_for_deletion): Undo previous change,
4531 making these static again.
4532 (offset_intervals, temp_set_point_both, temp_set_point)
4533 (copy_intervals_to_string): No longer inline.
4534 * xdisp.c (window_text_bottom_y, window_box_width)
4535 (window_box_height, window_box_left_offset)
4536 (window_box_right_offset, window_box_left, window_box_right)
4537 (window_box): No longer inline.
4539 2011-11-08 Chong Yidong <cyd@gnu.org>
4541 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4542 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4543 Signal an error if not a live window.
4544 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4545 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4547 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4549 * lisp.h (syms_of_abbrev): Remove declaration.
4550 Reported by CHENG Gao <chenggao@royau.me>.
4552 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4554 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4555 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4556 of temacs in GUI mode.
4558 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4560 * window.h: Declare delete_all_child_windows instead of
4561 delete_all_subwindows.
4562 * window.c (Fwindow_nest, Fset_window_nest)
4563 (Fset_window_new_total, Fset_window_new_normal)
4564 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4565 (delete_all_subwindows): Rename to delete_all_child_windows.
4566 (Fdelete_other_windows_internal, Fset_window_configuration):
4567 Call delete_all_child_windows instead of delete_all_subwindows.
4568 * frame.c (delete_frame): Call delete_all_child_windows instead
4569 of delete_all_subwindows.
4571 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4573 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4574 This is also needed for porting to any host where GC_MARK_STACK is
4575 not GC_MAKE_GCPROS_NOOPS.
4576 (which_symbols): Use it.
4578 2011-11-07 Kenichi Handa <handa@m17n.org>
4580 * coding.c (coding_set_destination): Check coding->src_pos only
4581 when coding->src_object is a buffer (bug#9910).
4583 * process.c (send_process): Set the member src_multibyte of coding
4584 to 0 (bug#9911) when sending a unibyte text.
4586 * callproc.c (Fcall_process): Set the member src_multibyte of
4587 process_coding to 0 (bug#9912).
4589 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4591 * xmenu.c (cleanup_widget_value_tree): New function.
4592 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4593 calling free_menubar_widget_value_tree directly (Bug#9830).
4595 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4597 Fix some portability problems with 'inline'.
4598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4599 (window_box_width, window_box_left, window_box_left_offset)
4600 (window_box_right, window_box_right_offset): Declare extern.
4601 Otherwise, these inline functions do not conform to C99 and
4602 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4603 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4604 * intervals.c (adjust_intervals_for_insertion)
4605 (adjust_intervals_for_deletion): Now extern, because otherwise the
4606 extern inline functions 'offset_intervals' couldn't refer to it.
4607 (static_offset_intervals): Remove.
4608 (offset_intervals): Rewrite using the old contents of
4609 static_offset_intervals. The old version didn't conform to C99
4610 because an extern inline function contained a reference to an
4611 identifier with static linkage.
4613 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4615 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4618 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4620 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4621 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4622 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4623 return Qleft_to_right.
4625 2011-11-06 Chong Yidong <cyd@gnu.org>
4627 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4628 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4629 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4630 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4631 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4632 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4633 (Fwindow_vscroll): Doc fix.
4634 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4635 argument, since it makes no sense to pass a live window and for
4636 consistency with window-child.
4638 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4640 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4643 2011-11-05 Jason Rumney <jasonr@gnu.org>
4645 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4646 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4648 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4649 bitwise arithmetic preventing use of unicode-sip and non-truetype
4652 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4654 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4657 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4658 initialization code to keep similarity to xfns.c after changes
4661 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4663 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4664 (unwind_create_frame): New function (Bug#9943).
4665 (Fx_create_frame): Restructure code to be more similar to the one in
4666 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4667 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4668 Move terminal->reference_count++ just before making the frame official
4671 * nsterm.m (x_free_frame_resources): New function.
4672 (x_destroy_window): Move code to x_free_frame_resources.
4674 * xfns.c (unwind_create_frame): Fix comment.
4675 (Fx_create_frame, x_create_tip_frame):
4676 Move terminal->reference_count++ just before making the frame
4677 official. Move initialization of image_cache_refcount and
4678 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4680 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4682 Support MSVC build with newer versions of Visual Studio.
4683 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4684 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4687 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4688 which are not supported by MSVC.
4689 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4690 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4692 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4694 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4696 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4698 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4700 Support MSVC build with newer versions of Visual Studio.
4701 * w32.c: Don't include w32api.h for MSVC.
4702 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4704 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4705 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4706 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4707 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4709 (alloca) [_MSC_VER]: Define to _alloca.
4711 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4713 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4715 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4717 * xdisp.c (note_mouse_highlight): If either of
4718 previous/next-single-property-change returns nil, treat that as
4719 the beginning or the end of the buffer. (Bug#9955)
4721 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4723 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4724 label is not null (Bug#9951).
4725 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4728 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4730 * window.c (Fwindow_body_size): Mention in the doc string that the
4731 return value is in frame's canonical units. (Bug#9949)
4733 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4735 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4737 * w32fns.c (unwind_create_frame): If needed, free the glyph
4738 matrices of the partially constructed frame. (Bug#9943)
4739 * xfns.c (unwind_create_frame): Likewise.
4741 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4743 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4744 Don't stop backward scan on the continuation glyph, even though
4745 its CHARPOS is positive.
4746 (mouse_face_from_buffer_pos, note_mouse_highlight):
4747 Rename cover_string to disp_string.
4749 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4751 * window.c (temp_output_buffer_show): Don't use
4752 Vtemp_buffer_show_specifiers.
4753 (Vtemp_buffer_show_specifiers): Remove unused variable.
4755 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4757 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4758 past the beginning of the current glyph matrix.
4760 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4762 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4763 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4764 HAVE_GTK3 (Bug#9869).
4766 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4767 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4769 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4771 * xterm.c: Declare x_handle_net_wm_state to return int.
4772 (handle_one_xevent): Check if we are iconified but don't have
4773 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4774 (get_current_wm_state): Return non-zero if not hidden,
4775 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4776 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4777 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4778 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4780 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4782 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4783 so that this new function doesn't get optimized away by a
4784 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4786 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4788 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4790 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4792 Fix the `xbytecode' command.
4793 * .gdbinit (xprintbytestr): New command.
4794 (xwhichsymbols): Rename from `which'; all callers changed.
4795 (xbytecode): Print the byte-code string as well.
4797 2011-10-29 Kim Storm <storm@cua.dk>
4799 * alloc.c (which_symbols): New function.
4801 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4803 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4806 2011-10-29 Glenn Morris <rgm@gnu.org>
4808 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4809 Not clear what it was for, and it causes various bugs. (Bug#9839)
4811 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4813 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4814 possible random value that matches one of those tested as
4815 condition to clear the mouse face.
4817 2011-10-28 Chong Yidong <cyd@gnu.org>
4819 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4821 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4823 * window.c (make_window): Initialize phys_cursor_on_p.
4825 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4827 * lisp.h (struct Lisp_Symbol): Update comments.
4829 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4831 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4833 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4835 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4836 <oslsachem@gmail.com> for helping to debug this.
4838 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4839 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4840 (g_b_init_get_glyph_outline_w): New static variables.
4841 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4842 (GetGlyphOutlineW_Proc): New typedefs.
4843 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4844 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4846 (w32font_open_internal, compute_metrics):
4847 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4848 instead of calling the "wide" APIs directly.
4850 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4852 * w32.h (syms_of_w32font): Add prototype.
4854 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4856 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4857 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4858 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4859 (Fmove_to_window_line): Doc fix.
4861 2011-10-27 Chong Yidong <cyd@gnu.org>
4863 * process.c (make_process): Set gnutls_state to NULL.
4865 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4866 non-NULL, regardless of GNUTLS_INITSTAGE.
4867 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4868 an error. Set process slots as soon as we allocate them.
4870 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4872 2011-10-27 Chong Yidong <cyd@gnu.org>
4874 * gnutls.c (emacs_gnutls_deinit): New function.
4875 Deallocate credentials structures as well as calling gnutls_deinit.
4876 (Fgnutls_deinit, Fgnutls_boot): Use it.
4878 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4879 (deactivate_process): Call emacs_gnutls_deinit.
4881 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4883 * image.c (x_create_x_image_and_pixmap):
4884 * w32.c (sys_rename, w32_delayed_load):
4885 * w32font.c (fill_in_logfont):
4886 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4888 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4890 * w32fns.c (w32_default_color_map): New function,
4891 extracted from Fw32_default_color_map.
4892 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4894 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4896 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4898 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4900 * keyboard.c (test_undefined): New function (bug#9751).
4901 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4903 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4905 * sysdep.c (init_sys_modes): Fix the check for the controlling
4906 terminal (Bug#6649).
4908 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4910 * dispextern.h (struct bidi_it): New member next_en_type.
4912 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4913 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4914 current character, check also for next_en_type being WEAK_EN.
4915 (bidi_resolve_weak): Don't enter the expensive loop if the current
4916 position is before next_en_pos. Record the bidi type of the first
4917 non-ET, non-BN character we find, in addition to its position.
4918 (bidi_level_of_next_char): Invalidate next_en_type when
4919 next_en_pos is over-stepped.
4921 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4923 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4924 * editfns.c: Rewrite current-time-zone so that it invokes
4925 the equivalent of (format-time-string "%Z") to get the time zone name.
4926 This fixes a bug when the time zone name contains characters that
4927 need converting from the system time locale to Emacs internal format.
4928 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4929 that patch fixed format-time-string to do the conversion, but
4930 I forgot to fix current-time-zone.
4931 (format_time_string): New function, containing most of
4932 what Fformat_time_string used to contain.
4933 (Fformat_time_string): Rewrite in terms of format_time_string.
4934 This doesn't change this function's behavior.
4935 (current-time-zone): Rewrite to use format_time_string.
4936 This fixes the bug reported by Michael Schierl in
4937 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4938 Jason Rumney's 2007-06-07 change worked around this bug, but
4940 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4942 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (start_display): If the character at POS is displayed
4945 via a display vector, reset IT->current.dpvec_index to zero.
4946 (try_window_reusing_current_matrix): If a line ends in a display
4947 vector or the next line starts in a display vector, continue
4948 redrawing the window even though the character position of
4949 start_row was reached.
4952 2011-10-18 Chong Yidong <cyd@gnu.org>
4954 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4955 with nobreak-char-display too.
4957 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4959 Fix part 3 of bug#9771.
4960 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4961 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4962 non-neutral characters if the current character is a paragraph
4963 separator (a.k.a. Newline). This avoids running the same
4964 expensive loop twice, once when we consume the preceding newline
4965 and the other time when the line actually needs to be displayed.
4966 Avoid the loop when we see neutrals on the base embedding level
4967 following a character whose directionality is the same as the
4968 paragraph's. This avoids running the expensive loop when a line
4969 ends in a long sequence of neutrals, like control characters.
4970 Add assertion against STRONG_AL type. Slightly rearrange code
4971 that determines the type of a neutral given the first non-neutral
4973 (bidi_level_of_next_char): Set next_en_pos to zero when
4974 invalidating its info.
4976 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4978 * xdisp.c (push_display_prop): Determine whether to record string
4979 or buffer position by IT->string, not by IT->method. Allow
4980 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4981 (move_it_vertically_backward): Don't look for character position
4982 immediately after the newline when in a continuation line.
4985 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4987 * window.c (coordinates_in_window): Rewrite and delabelize
4988 vertical border check. (Bug#5357) (Bug#9618)
4990 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4992 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4993 errors in XSetWindowBorder (bug#9310).
4995 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4997 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4998 avoid crash when xmalloc overrun checking is enabled.
5000 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5002 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5003 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5004 cursor motion with <left> and <right> arrow keys.
5006 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5007 some callers set that themselves.
5009 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5011 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5012 display string and the previous row comes from the same string and
5013 is empty. (Bug#9739) (Bug#9738)
5015 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5017 * doc.c (get_doc_string): Encode file name (bug#9735).
5019 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5021 * bidi.c (bidi_level_of_next_char):
5022 * xdisp.c (get_visually_first_element): Remove old incorrect
5023 comments regarding the Unicode Line Separator character.
5025 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5027 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5029 * alloc.c (Fgc_status): Do not access beyond zombies array
5030 boundary if nzombies > MAX_ZOMBIES.
5031 * alloc.c (dump_zombies): Add missing format specifier.
5033 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5035 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5036 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5038 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5039 Some packages use them to denote characters with modifiers.
5041 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5044 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5045 matching a pp-number. Rename parameter var to var1.
5047 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5049 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5051 2011-10-08 Glenn Morris <rgm@gnu.org>
5053 * callint.c (Fcall_interactively): Give a more explicit error for the
5054 'c' case with a non-character input. (Bug#8479)
5056 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5058 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5060 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5061 lines that are hscrolled on the left.
5063 * dispnew.c (buffer_posn_from_coords): Account for a possible
5064 presence of header-line. (Bug#4426)
5066 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5068 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5069 Don't advertise functionality which we discourage or doesn't work.
5071 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5073 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5074 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5075 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5076 this makes Emacs dump core during garbage collection on rare
5077 occasions. sizeof is obviously inferior to offsetof here, so
5078 stick with offsetof.
5079 (GC_POINTER_ALIGNMENT): New macro.
5080 (mark_memory): Omit 3rd (offset) arg; caller changed.
5081 Don't assume EMACS_INT alignment is the same as pointer alignment.
5083 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5085 * keyboard.c (read_key_sequence_remapped): New var.
5086 (read_key_sequence): Compute remapping in the right buffer.
5087 (command_loop_1): Use read_key_sequence's remapping directly.
5089 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5091 * dired.c (file_name_completion): Don't expand file name.
5092 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5093 before checking file name handler.
5095 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5096 they've been requested explicitly (bug#9591).
5098 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5100 * keymap.c (Fsingle_key_description): Use make_specified_string
5101 instead of build_string to build string from push_key_description.
5104 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5106 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5107 This fixes a Y2038 bug on 64-bit hosts.
5108 * buffer.c (reset_buffer):
5109 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5110 (Fclear_buffer_auto_save_failure):
5111 Use 0, not -1, to represent an unset failure time, since time_t
5112 might not be signed.
5114 Remove dependency on glibc malloc internals.
5115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5116 Move back here from lisp.h, but with their new implementations.
5117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5118 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5119 * charset.c (charset_table_init): New static var.
5120 (syms_of_charset): Use it instead of xmalloc. This removes a
5121 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5122 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5123 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5124 Move back to alloc.c.
5125 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5126 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5128 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5130 * nsterm.m (windowDidResize): Call x_set_window_size only when
5131 ns_in_resize is true. Otherwise set pixelwidth/height and
5132 call change_frame_size (Bug#9628).
5134 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5136 Port --enable-checking=all to Fedora 14 x86-64.
5137 * charset.c (syms_of_charset): Also account for glibc malloc's
5138 internal overhead when calculating the initial malloc maximum.
5140 Port --enable-checking=all to Fedora 14 x86.
5141 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5143 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5144 (overrun_check_realloc, overrun_check_free):
5145 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5146 That way, xmalloc returns a properly-aligned pointer even if
5147 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5148 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5149 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5150 into account when calculating the initial malloc maximum.
5151 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5152 Move here from alloc.c, so that charset.c can use it too.
5153 Properly align; the old code wasn't right for common 32-bit hosts
5154 when configured with --enable-checking=all.
5155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5156 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5158 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5160 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5163 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5165 * xdisp.c (compute_display_string_end): If there's no display
5166 string at CHARPOS, return -1.
5168 * bidi.c (bidi_fetch_char): When compute_display_string_end
5169 returns a negative value, treat the character as a normal
5170 character not covered by a display string. (Bug#9624)
5172 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5174 * lread.c (Fread_from_string): Fix typo in docstring.
5176 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5178 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5179 newline, reseat the iterator instead of bidi-iterating there one
5180 character at a time. (Bug#9610)
5181 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5182 TO_CHARPOS if the bidi iterator is at base embedding level.
5184 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5186 * lread.c (readevalloop): Use correct code for NBSP.
5187 (read1): Likewise. (Bug#9608)
5189 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5191 * dbusbind.c (Fdbus_register_signal): When service is not
5192 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5194 2011-09-25 Glenn Morris <rgm@gnu.org>
5196 * buffer.c (truncate-lines): Doc fix.
5198 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5200 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5201 (Fset_window_next_buffers): Doc fix.
5203 2011-09-24 Glenn Morris <rgm@gnu.org>
5205 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5207 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5209 Fix minor problems found by static checking.
5210 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5211 * indent.c (Fvertical_motion): Fix == vs = typo.
5213 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5215 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5216 Default value is now t. Doc fix.
5218 * indent.c (Fvertical_motion): Compute and apply the overshoot
5219 logic when moving up, not only when moving down. Fix the
5220 confusing name and values of the it_overshoot_expected variable;
5221 logic changes accordingly. (Bug#9254) (Bug#9549)
5223 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5224 CHARPOS is covered by a display string which includes newlines.
5225 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5226 is covered by a display string with embedded newlines.
5228 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5230 * dbusbind.c (Fdbus_register_signal): Add match rule to
5231 Vdbus_registered_objects_table. (Bug#9581)
5232 (Fdbus_register_method, Vdbus_registered_objects_table):
5235 2011-09-24 Jim Meyering <meyering@redhat.com>
5237 do not ignore write error for any output size
5238 The previous change was incomplete.
5239 While it makes emacs --batch detect the vast majority of stdout
5240 write failures, errors were still ignored whenever the output size is
5241 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5242 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5243 && echo FAIL: ignored write error
5244 FAIL: ignored write error
5245 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5246 && echo FAIL: ignored write error
5247 FAIL: ignored write error
5248 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5250 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5252 * emacs.c (Fkill_emacs): In noninteractive mode exit
5253 non-successfully if a write error occurred on stdout. (Bug#9574)
5255 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5257 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5260 * dispextern.h (struct it): Update the comment documenting what
5263 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5265 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5266 a display string, extend search for cursor position to end of row.
5267 (find_row_edges): If the row ends in a newline from a display
5268 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5269 Handle the case of a display string with multiple newlines.
5270 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5271 non-empty line. Fixes confusing cursor motion with arrow keys at
5272 the beginning of a line that starts with whitespace.
5274 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5276 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5279 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5281 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5284 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5286 * xdisp.c (display_line): Record maximum and minimum buffer
5287 positions even if no glyphs were produced (e.g., by a zero-width
5288 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5289 buffer positions that will be removed from the glyph row because
5291 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5292 column is beyond frame width: don't subtract 1 "pixel" when
5293 computing width of the stretch.
5294 (reseat_at_next_visible_line_start): Undo the change made on
5295 2011-09-17 that saved paragraph information and restored it after
5296 the call to `reseat'. (Bug#9545)
5298 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5300 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5301 and turn window cursor on if cleared (Bug#9415).
5303 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5305 * search.c (boyer_moore): Take unibyte characters from pattern
5306 literally. (Bug#9458)
5308 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5310 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5312 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5314 Fix minor problem found by static checking.
5315 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5316 initialized, to pacify gcc -Wuninitialized.
5318 * fileio.c: Report proper errno when syscall falls.
5319 (Finsert_file_contents): Save and restore errno,
5320 so that report_file_error outputs the correct diagnostic.
5321 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5323 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5325 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5327 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5329 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5332 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5334 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5335 about the current paragraph and restore it after the call to reseat.
5337 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5338 (bidi_find_paragraph_start): Search back for paragraph beginning
5339 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5340 (bidi_move_to_visually_next): Only trigger paragraph-related
5341 computations when the last character is a newline or at EOB, not
5342 just any NEUTRAL_B. (Bug#9470)
5344 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5345 truncated lines if point is covered by a display string. (Bug#9524)
5347 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5349 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5350 (cons_to_x_long): New function.
5351 (lisp_data_to_selection_data): Use it. Correct the test for
5352 short-versus-long data; it was negated. Break out of vector
5353 loop, for efficiency, when a long datum is discovered.
5355 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5357 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5359 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5361 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5362 GCC PR/17406) by declaring this function with external scope.
5364 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5366 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5367 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5369 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5371 * editfns.c (Fformat): Correctly handle text properties on "%%".
5373 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5375 * xterm.c (x_draw_composite_glyph_string_foreground):
5376 * w32term.c (x_draw_composite_glyph_string_foreground):
5377 * term.c (encode_terminal_code):
5378 * composite.c (composition_update_it, get_composition_id):
5379 * xdisp.c (get_next_display_element)
5380 (fill_composite_glyph_string): Add comments about special meaning
5381 of TAB characters in a composition.
5383 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5385 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5386 This occurs when processing a multibyte format.
5387 Problem reported by Wolfgang Jenker.
5389 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5391 * xdisp.c (try_cursor_movement): Only check for exact match if
5392 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5394 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5396 Remove unused external symbols.
5397 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5398 * xdisp.c (calc_pixel_width_or_height): Now static.
5399 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5400 * indent.c (check_display_width):
5401 * w32term.c: Fix comment to match code.
5402 * xterm.c, xterm.h (x_catching_errors): Remove.
5404 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5406 * xselect.c: Use signed conversions more consistently (Bug#9498).
5407 (selection_data_to_lisp_data): Assume incoming selection data are
5408 signed integers, not unsigned. This is to be consistent with
5409 outgoing selection data, which was modified to use signed integers
5410 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5411 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5412 expects long, not unsigned long.
5414 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5416 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5417 computation of loop end. Reported by Johan Bockgård
5420 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5422 * frame.c (Fother_visible_frames_p): Function deleted.
5424 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5426 * indent.c (compute_motion): Process display vector front to back
5427 rather than the other way around. (Bug#2496)
5429 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5431 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5433 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5435 * minibuf.c (Fread_from_minibuffer): Doc fix.
5437 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5439 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5442 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5444 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5445 value for non-existent files.
5447 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5449 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5450 set its "size" to -1. This will set the modtime_size field of
5451 the corresponding buffer to -1, which is what
5452 verify-visited-file-modtime expects for files that do not exist.
5455 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5457 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5459 * lisp.h: ... from here. push_key_description is no longer
5460 defined in keyboard.c, so its declaration should not be in
5461 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5462 logically belongs with push_key_description.
5464 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5466 * buffer.h: Include <sys/types.h> instead of <time.h>.
5467 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5468 Problem reported by Herbert J. Skuhra.
5470 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5472 * xml.c (parse_region): Make the parsing work for
5473 non-comment-starting XML files again (bug#9144).
5475 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5477 * image.c (gif_load): Fix calculation of bottom and right corner.
5480 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5482 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5483 redisplay in small windows.
5485 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5487 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5489 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5491 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5492 Operate on live windows only.
5494 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5496 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5498 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5500 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5501 only under bidi iteration.
5503 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5505 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5507 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5509 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5510 Without this fix, the command to link temacs failed due to an
5511 undefined symbol __builtin_isnan. This is because
5512 /usr/include/iso/math_c99.h #defines isnan(x) to
5513 __builtin_isnan(x), but the bundled gcc, which identifies itself
5514 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5516 * floatfns.c (isnan): #undef, and then #define to a clone of
5518 (Fisnan): Always define, since it's always available now.
5519 (syms_of_floatfns): Always define isnan at the Lisp level.
5521 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5523 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5525 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5527 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5528 The previous code assumed that file offsets (off_t values) fit in
5529 EMACS_INT variables, which is not true on typical 32-bit hosts.
5530 The code messed up by falsely reporting buffer overflow in cases
5531 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5532 when "big" contains more than 2**29 bytes, even though this
5533 inserts just one byte and does not overflow the buffer.
5534 (Finsert_file_contents): Store file offsets as off_t
5535 values, not as EMACS_INT values. Check for overflow when
5536 converting between EMACS_INT and off_t. When checking for
5537 buffer overflow or for overlap, take the offsets into account.
5538 Don't use EMACS_INT for small values where int suffices.
5539 When checking for overlap, fix a typo: ZV was used where
5540 ZV_BYTE was intended.
5541 (Fwrite_region): Don't assume off_t fits into 'long'.
5542 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5544 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5546 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5548 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5550 sprintf-related integer and memory overflow issues (Bug#9412).
5552 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5553 (esprintf, exprintf, evxprintf): New functions.
5554 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5555 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5556 (modify_event_symbol): Do not assume that the length of
5557 name_alist_or_stem is safe to alloca and fits in int.
5558 (Fexecute_extended_command): Likewise for function name and binding.
5559 (Frecursion_depth): Wrap around reliably on integer overflow.
5560 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5561 since some callers pass EMACS_INT values.
5562 (Fsingle_key_description): Don't crash if symbol name contains more
5563 than MAX_ALLOCA bytes.
5564 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5565 (get_minibuffer): Arg is now EMACS_INT, not int.
5566 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5567 (esprintf, exprintf, evxprintf): New decls.
5568 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5570 * dbusbind.c (signature_cat): New function.
5571 (xd_signature, Fdbus_register_signal):
5572 Do not overrun buffer; instead, report string overflow.
5574 * dispnew.c (add_window_display_history): Don't overrun buffer.
5575 Truncate instead; this is OK since it's just a log.
5577 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5578 even if the time zone offset is outlandishly large.
5579 Don't mishandle offset == INT_MIN.
5581 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5582 when creating daemon; the previous buffer-overflow check was incorrect.
5584 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5585 which has the guts of the old verror function.
5587 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5588 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5590 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5591 (font_unparse_xlfd): Don't blindly alloca long strings.
5592 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5593 fits in int, when using sprintf. Use single snprintf to count
5594 length of string rather than counting it via multiple sprintfs;
5595 that's simpler and more reliable.
5596 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5597 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5598 sprintf, in case result does not fit in int.
5600 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5601 (fontset_from_font): Print it.
5603 * frame.c (tty_frame_count): Now printmax_t, not int.
5604 (make_terminal_frame, set_term_frame_name): Print it.
5605 (x_report_frame_params): In X, window IDs are unsigned long,
5606 not signed long, so print them as unsigned.
5607 (validate_x_resource_name): Check for implausibly long names,
5608 and don't assume name length fits in 'int'.
5609 (x_get_resource_string): Don't blindly alloca invocation name;
5610 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5613 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5614 (xg_check_special_colors, xg_set_geometry):
5615 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5617 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5618 Use esprintf, not sprintf, in case result does not fit in int.
5620 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5621 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5622 it as a large positive number.
5623 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5624 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5626 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5627 in case result does not fit in int.
5629 * print.c (float_to_string): Detect width overflow more reliably.
5630 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5631 buffer overrun. Don't assume list length fits in 'int'. Treat
5632 print length of 0 as 0, not as infinity; to be consistent with other
5633 uses of print length in this function. Don't overflow print length
5634 index. Don't assume hash table size fits in 'long', or that
5635 vectorlike size fits in 'unsigned long'.
5637 * process.c (make_process): Use printmax_t, not int, to format
5638 process-name gensyms.
5640 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5642 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5643 to avoid potential buffer overrun.
5645 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5646 if X resource line is longer than 512 bytes.
5648 * xfns.c (x_window): Make sprintf buffer a bit bigger
5649 to avoid potential buffer overrun.
5651 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5653 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5655 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5657 Integer overflow fixes for scrolling, etc.
5658 Without these, Emacs silently mishandles large integers sometimes.
5659 For example, "C-u 4294967297 M-x recenter" was treated as if
5660 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5662 * xdisp.c (try_window_id): Check Emacs fixnum range before
5663 converting to 'int'.
5665 * window.c (window_scroll_line_based, Frecenter):
5666 Check that an Emacs fixnum is in range before assigning it to 'int'.
5667 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5668 values converted from Emacs fixnums.
5669 (Frecenter): Don't wrap around a line count if it is out of 'int'
5670 range; instead, treat it as an extreme value.
5671 (Fset_window_configuration, compare_window_configurations):
5672 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5674 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5675 that can exceed INT_MAX. Check that EMACS_INT value is in range
5676 before assigning it to the (possibly-narrower) index.
5677 (match_limit): Don't assume that a fixnum can fit in 'int'.
5679 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5682 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5683 (Fvertical_motion): Don't wrap around LINES values that don't fit
5684 in 'int'. Instead, treat them as extreme values. This is good
5685 enough for windows, which can't have more than INT_MAX lines anyway.
5687 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5689 * Require libxml/parser.h to avoid compilation warning.
5691 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5693 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5694 since this reportedly can destroy thread storage.
5696 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5698 * syntax.c (find_defun_start): Update all cache variables if
5699 exiting early (Bug#9401).
5701 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5703 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5705 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5706 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5707 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5709 * term.c (tty_append_glyph): New function.
5710 (produce_stretch_glyph): Static function and its prototype deleted.
5712 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5715 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5717 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5718 when checking :margin (Bug#9390).
5719 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5720 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5721 so that the name doesn't mislead. All uses changed.
5723 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5725 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5728 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5730 * xdisp.c (move_it_to): Don't bail out early when reaching
5731 position beyond to_charpos, if we are scanning backwards.
5732 (move_it_vertically_backward): When DY == 0, make sure we get to
5733 the first character in the line after the newline.
5735 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5737 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5738 (ccl_driver): Do not generate an out-of-range pointer.
5739 (Fccl_execute_on_string): Remove unnecessary check for
5740 integer overflow, noted by Stefan Monnier in
5741 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5742 Remove a FIXME that didn't need fixing.
5743 Simplify the newly-introduced buffer reallocation code.
5745 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5747 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5749 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5751 Integer and memory overflow issues (Bug#9196).
5753 * doc.c (get_doc_string): Rework so that
5754 get_doc_string_buffer_size is the actual buffer size, rather than
5755 being 1 less than the actual buffer size; this makes xpalloc more
5758 * image.c (x_allocate_bitmap_record, cache_image):
5759 * xselect.c (Fx_register_dnd_atom):
5760 Simplify previous changes by using xpalloc.
5762 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5763 since either will do and ptrdiff_t is convenient with xpalloc.
5765 * charset.c (charset_table_size)
5766 (struct charset_sort_data.priority): Now ptrdiff_t.
5767 (charset_compare): Don't overflow if priorities differ greatly.
5768 (Fsort_charsets): Don't assume list length fits in int.
5769 Check for size-calculation overflow when allocating sort data.
5770 (syms_of_charset): Allocate an initial charset table that is
5771 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5773 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5775 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5776 The actual value is always <= INT_MAX, and leaving it unsigned made
5777 overflow checking harder.
5779 * dispextern.h (struct glyph_matrix.rows_allocated)
5780 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5781 with xpalloc. The values are still always <= INT_MAX.
5783 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5785 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5786 (SAFE_NALLOCA): New macro.
5788 * region-cache.c (struct boundary.pos, find_cache_boundary)
5789 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5790 (set_cache_region, invalidate_region_cache)
5791 (revalidate_region_cache, know_region_cache, region_cache_forward)
5792 (region_cache_backward, pp_cache):
5793 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5794 so that ptrdiff_t * can be passed to xpalloc.
5795 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5796 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5797 (pp_cache): Don't assume cache_len fits in int.
5798 * region-cache.h: Adjust extern decls to match.
5800 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5801 EMACS_INT, since either will do, for xpalloc.
5803 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5804 (xnmalloc, xnrealloc, xpalloc): New functions.
5806 * bidi.c (bidi_shelve_header_size): New constant.
5807 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5808 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5810 * bidi.c (bidi_cache_shrink):
5811 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5813 Don't update size of array until after memory allocation succeeds,
5814 because xmalloc/xrealloc may not return.
5815 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5816 now that we have proper integer overflow checking.
5817 (record_overlay_string, overlay_strings): Catch overflows when
5818 calculating size of overlay_str_buf.
5820 * callproc.c (Fcall_process): Check for size overflow when
5821 calculating size of args2.
5822 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5823 Normally we prefer signed values, but sticking with ptrdiff_t would
5824 require adding more-complicated checks.
5826 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5827 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5828 Redo buffer-overflow calculations to avoid integer overflow.
5829 Add a FIXME comment where memory seems to be over-allocated.
5831 * character.c (Fstring): Check for size-calculation overflow.
5833 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5834 unnecessary integer overflow. Check for size overflow.
5835 (encode_coding_object): Don't update size until xmalloc succeeds.
5837 * composite.c (get_composition_id): Check for overflow in glyph
5838 length calculations.
5840 Integer and memory overflow fixes for display code.
5841 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5842 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5843 (scrolling_window): Check for overflow in size calculations.
5844 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5845 Don't assume glyph table len fits in int.
5846 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5847 (row_table_size): Now ptrdiff_t, not int.
5848 (scrolling_window): Avoid overflow in size calculations.
5849 Don't update size until allocation succeeds.
5850 * fns.c (concat): Check for overflow in size calculations.
5851 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5852 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5853 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5855 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5856 (get_doc_string): Check for size calculation overflow.
5857 Don't update size until allocation succeeds.
5858 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5859 EMACS_INT, where ptrdiff_t will do.
5860 (Fsubstitute_command_keys): Check for string overflow.
5862 * editfns.c (set_time_zone_rule): Don't assume environment length
5864 (message_length): Now ptrdiff_t, not int.
5865 (Fmessage_box): Don't update size until allocation succeeds.
5866 Don't assume message length fits in int.
5867 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5869 * emacs.c (main): Do not reallocate argv, since there is a null at
5870 the end that can be overwritten, and this way there's no need to
5871 worry about size-calculation overflow.
5872 (sort_args): Check for size-calculation overflow.
5874 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5876 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5878 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5879 (x_set_scroll_bar_width, x_figure_window_size):
5880 Check for integer overflow.
5881 (x_set_alpha): Do not assume XINT fits in int.
5883 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5884 This is for the members text_lines, text_cols, total_lines, total_cols,
5885 where the system imposes an 'int' limit.
5887 * fringe.c (Fdefine_fringe_bitmap):
5888 Don't update size until alloc works.
5890 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5891 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5893 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5894 Check for size-calculation overflow.
5895 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5896 do, as we prefer signed integers.
5897 (id_to_widget.max_size, id_to_widget.used)
5898 (xg_store_widget_in_map, xg_remove_widget_from_map)
5899 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5900 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5901 Use and return ptrdiff_t, not int.
5902 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5903 * gtkutil.h: Change prototypes to match the above.
5905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5906 are duplicate now that they've been promoted to lisp.h.
5907 (x_allocate_bitmap_record, x_alloc_image_color)
5908 (make_image_cache, cache_image, xpm_load):
5909 Don't update size until alloc is done.
5910 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5912 Check for size calculation overflow.
5913 (ct_colors_allocated_max): New constant.
5914 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5917 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5918 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5919 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5920 Use ptrdiff_t, not int, to count maps.
5921 (read_char_minibuf_menu_prompt): Check for overflow in size
5922 calculations. Don't update size until allocation succeeds.
5923 Redo calculations to avoid overflow.
5924 * keyboard.h: Change prototypes to match the above.
5926 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5928 (current_minor_maps): Check for size calculation overflow.
5929 * keymap.h: Change prototypes to match the above.
5931 * lread.c (read1, init_obarray): Don't update size until alloc done.
5933 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5934 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5936 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5937 Now ptrdiff_t, not int.
5938 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5939 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5941 * process.c (Fnetwork_interface_list): Check for overflow
5942 in size calculation.
5944 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5946 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5947 overflow. Don't bother calling xmalloc when xrealloc will do.
5949 * search.c (Freplace_match): Check for size calculation overflow.
5950 (Fset_match_data): Don't assume list lengths fit in 'int'.
5952 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5953 for command line length. Do not attempt to address one before the
5954 beginning of an array, as that's not portable.
5956 * term.c (max_frame_lines): Remove; unused.
5957 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5959 (encode_terminal_code, calculate_costs): Check for size
5960 calculation overflow.
5961 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5962 table lengths and related sizes. Don't update size until alloc
5963 done. Redo calculations to avoid overflow.
5964 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5966 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5967 subtracting pointers.
5968 (gobble_line): Check for overflow more carefully. Don't update size
5971 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5972 Don't update size until alloc done.
5973 Redo size calculations to avoid overflow.
5974 Check for size calculation overflow.
5975 (main) [DEBUG]: Fix typo in invoking tparam1.
5977 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5978 Use ptrdiff_t, not int, for sizes.
5979 (store_mode_line_noprop_char): Don't update size until alloc done.
5981 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5982 Use ptrdiff_t, not int, for sizes.
5983 (Finternal_make_lisp_face, cache_face):
5984 Check for size calculation overflow.
5985 (cache_face): Treat size calculation overflows as if they were
5986 memory exhaustion (the usual treatment), rather than aborting.
5988 * xfns.c (x_encode_text, x_set_name_internal)
5989 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5990 sizes, since they can exceed INT_MAX in size. Check for size
5991 calculation overflow.
5993 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5994 (xg_select): Check for size calculation overflow.
5995 Don't update size until alloc done.
5997 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5998 as sprintf is limited to int lengths.
6000 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6001 (X_LONG_MIN): New macros.
6002 Use them to make the following changes clearer.
6003 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6004 This change doesn't affect the value now, but it may help remind
6005 future maintainers not to raise the value too much later.
6006 (SELECTION_QUANTUM): Remove, replacing with ...
6007 (selection_quantum): ... new function, which avoids overflow.
6009 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6010 assumption that selection length fits in 'int'.
6011 (x_reply_selection_request, x_handle_selection_request)
6012 (x_get_window_property, receive_incremental_selection)
6013 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6014 (lisp_data_to_selection_data, clean_local_selection_data):
6015 Use ptrdiff_t, not int, to record length of selection.
6016 (x_reply_selection_request, x_get_window_property)
6017 (receive_incremental_selection, x_property_data_to_lisp):
6018 Redo calculations to avoid overflow.
6019 (x_reply_selection_request): When sending hint, ceiling it at
6020 X_LONG_MAX rather than relying on wraparound overflow to send
6022 (x_get_window_property, receive_incremental_selection)
6023 (lisp_data_to_selection_data, x_property_data_to_lisp):
6024 Check for size-calculation overflow.
6025 (x_get_window_property, receive_incremental_selection)
6026 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6027 Don't store size until memory allocation succeeds.
6028 (x_get_window_property): Plug memory leak on memory exhaustion.
6029 Don't double-block input; malloc is safe here. Don't assume 2**34
6030 - 4 fits in unsigned long. Add an xassert to check
6031 XGetWindowProperty overflow. Be more careful about overflow
6032 calculations, and distinguish size from memory overflow better.
6033 (receive_incremental_selection): When tracing, don't assume
6034 unsigned int is less than INT_MAX.
6035 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6036 harmful) conversions of unsigned short to int.
6037 (lisp_data_to_selection_data): Don't assume that integers
6038 in the range -65535 through -1 fit in an X unsigned short.
6039 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6040 result parameters unless successful. Rely on cons_to_unsigned
6041 to report problems with elements; the old code wasn't right anyway.
6042 (x_check_property_data): Check for int overflow; we cannot use
6043 a wider type due to X limits.
6044 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6046 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6048 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6049 (x_term_init): Check for size calculation overflow.
6050 (x_color_cells): Don't store size until memory allocation succeeds.
6051 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6052 Don't assume alloca size is less than MAX_ALLOCA.
6053 (x_term_init): Don't assume length fits in int (sprintf is limited
6056 Use ptrdiff_t for composition IDs.
6057 * character.c (lisp_string_width):
6058 * composite.c (composition_table_size, n_compositions)
6059 (get_composition_id, composition_gstring_from_id):
6060 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6062 * window.c (Frecenter):
6063 Use ptrdiff_t, not int, for composition IDs.
6064 * composite.c (get_composition_id): Check for integer overflow.
6065 * composite.h: Adjust prototypes to match the above changes.
6067 Use ptrdiff_t for hash table indexes.
6068 * category.c (hash_get_category_set):
6069 * ccl.c (ccl_driver):
6070 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6071 * coding.c (coding_system_charset_list, detect_coding_system):
6072 * coding.h (struct coding_system.id):
6073 * composite.c (get_composition_id, gstring_lookup_cache):
6074 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6075 * image.c (xpm_get_color_table_h):
6076 * lisp.h (hash_lookup, hash_put):
6077 * minibuf.c (Ftest_completion):
6078 Use ptrdiff_t for hash table indexes, not int (which is too
6079 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6080 32-bit --with-wide-int hosts).
6082 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6083 Add a FIXME comment about memory leaks.
6084 (syms_of_charset): Don't assume xmalloc returns.
6086 Don't assume that stated character widths fit in int.
6087 * character.c (Fchar_width, c_string_width, lisp_string_width):
6088 * character.h (CHAR_WIDTH):
6089 * indent.c (MULTIBYTE_BYTES_WIDTH):
6090 Use sanitize_char_width to avoid undefined and/or bad behavior
6091 with outlandish widths.
6092 * character.h (sanitize_tab_width): Rename from sanitize_width,
6093 now that we have two such functions. All uses changed.
6094 (sanitize_char_width): New inline function.
6096 Don't assume that tab-width fits in int.
6097 * character.h (sanitize_width): New inline function.
6098 (SANE_TAB_WIDTH): New macro.
6099 (ASCII_CHAR_WIDTH): Use it.
6100 * indent.c (sane_tab_width): Remove. All uses replaced by
6101 SANE_TAB_WIDTH (current_buffer).
6102 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6104 * fileio.c: Integer overflow issues with file modes.
6105 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6107 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6108 Remove unreachable code.
6109 (read_hex, load_charset_map_from_file): Check for integer overflow.
6111 * xterm.c: Don't go over XClientMessageEvent limit.
6112 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6113 (x_send_scroll_bar_event): Likewise. Check that the size does not
6114 exceed limits imposed by XClientMessageEvent, as well as the usual
6115 ptrdiff_t and size_t limits.
6117 * keyboard.c: Overflow, signedness and related fixes.
6118 (make_lispy_movement): Use same integer type in forward decl
6119 that is used in the definition.
6120 (read_key_sequence, keyremap_step):
6121 Change bufsize argument back to int, undoing my 2011-03-30 change.
6122 We prefer signed types, and int is wide enough here.
6123 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6124 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6125 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6126 length, not size_t. Use ptrdiff_t for index, not int.
6127 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6128 possibility of integer overflow.
6130 Overflow, signedness and related fixes for images.
6132 * dispextern.h (struct it.stack[0].u.image.image_id)
6133 (struct_it.image_id, struct image.id, struct image_cache.size)
6134 (struct image_cache.used, struct image_cache.ref_count):
6135 * gtkutil.c (update_frame_tool_bar):
6136 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6137 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6138 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6139 * nsmenu.m (update_frame_tool_bar):
6140 * xdisp.c (calc_pixel_width_or_height):
6141 * xfns.c (image_cache_refcount):
6142 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6143 on typical 64-bit hosts.
6145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6146 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6147 Omit unnecessary casts to int.
6148 (parse_image_spec): Check that integers fall into 'int' range
6149 when the callers expect that.
6150 (image_ascent): Redo ascent calculation to avoid int overflow.
6151 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6152 (lookup_image): Remove unnecessary tests.
6153 (xbm_image_p): Locals are now of int, not EMACS_INT,
6154 since parse_image_check makes sure they fit into int.
6155 (png_load, gif_load, svg_load_image):
6156 Prefer int to unsigned where either will do.
6157 (tiff_handler): New function, combining the cores of the
6158 old tiff_error_handler and tiff_warning_handler.
6159 This function is rewritten to use vsnprintf and thereby avoid
6160 stack buffer overflows. It uses only the features of vsnprintf
6161 that are common to both POSIX and native Microsoft.
6162 (tiff_error_handler, tiff_warning_handler): Use it.
6163 (tiff_load, gif_load, imagemagick_load_image):
6164 Don't assume :index value fits in 'int'.
6165 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6166 (imagemagick_load_image): Check that crop parameters fit into
6167 the integer types that MagickCropImage accepts. Don't assume
6168 Vimagemagick_render_type has a nonnegative value. Don't assume
6169 size_t fits in 'long'.
6170 (gs_load): Use printmax_t to print the widest integers possible.
6171 Check for integer overflow when computing image height and width.
6173 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6175 * xdisp.c (redisplay_window): Don't force window start if point
6176 will be invisible in the resulting window. (Bug#9324)
6178 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6180 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6181 the display spec is of the form `(space ...)'.
6182 (handle_display_spec): Return the value returned by
6183 handle_single_display_spec, not just 1 or zero.
6184 (handle_single_display_spec): If the display spec is of the form
6185 `(space ...)', and specifies display in the text area, return 2
6187 (try_cursor_movement): Check for the need to scroll more
6188 accurately, and prefer exact match for point under bidi.
6189 Don't advance `row' beyond the last row of the window.
6191 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6192 into disp_prop; all users changed.
6194 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6195 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6196 for the text covered by the display property.
6198 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6200 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6201 Change return value to nil.
6202 (Frecord_buffer): Delete unused function.
6204 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6206 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6207 buffers, return left-to-right.
6208 (set_cursor_from_row): Consider candidate row a win if its glyph
6209 represents a newline and point is on that newline. Fixes cursor
6210 positioning on the newline at EOL of R2L text within L2R
6211 paragraph, and vice versa.
6212 (try_cursor_movement): Check continued rows, in addition to
6213 continuation rows. Fixes unwarranted scroll when point enters a
6214 continued line of R2L text within an L2R paragraph, or vice versa.
6215 (cursor_row_p): Consider the case of point being equal to
6216 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6217 from the end of a short line to the beginning of a continued line
6218 of R2L text within L2R paragraph.
6219 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6220 composed characters.
6222 * bidi.c (bidi_check_type): Use xassert.
6223 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6226 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6228 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6231 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6233 * nsfont.m (ns_otf_to_script): Fix typo.
6235 2011-08-22 Kenichi Handa <handa@m17n.org>
6237 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6238 extra slot even if the purpose is char-code-property-table.
6240 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6242 * xdisp.c (redisplay_window): When computing centering_position,
6243 account for the height of the header line. (Bug#8874)
6245 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6246 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6247 candidate is selected by the mouse, and that candidate has a
6248 composed character under the mouse.
6250 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6251 coordinates reported by pos-visible-in-window-p for a composed
6252 character in column zero.
6254 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6256 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6258 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6260 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6261 consider it a hit if to_charpos is anywhere in the range of the
6262 composed buffer positions.
6264 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6266 * image.c (gif_load): Don't assume that each subimage has the same
6267 dimensions as the base image. Handle disposal method that is
6268 "undefined" by the gif spec (Bug#9335).
6270 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6272 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6273 (Fcondition_case): Document `debug' symbol in error handler.
6275 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6277 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6278 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6279 from an Org mode buffer to a Speedbar frame.
6281 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6282 a composition, take its buffer position from IT->cmp_it.charpos.
6283 Fixes cursor positioning at the beginning of a line that begins
6284 with a composed character.
6286 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6288 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6289 character bidirectional type, use STRONG_L instead. Fixes crashes
6290 in a buffer produced by `describe-categories'.
6292 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6293 members before the level stack, so they would be saved and
6294 restored when copying iterator state. Fixes incorrect reordering
6295 around TABs covered by display properties.
6297 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6299 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6301 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6303 * eval.c (internal_condition_case, internal_condition_case_1)
6304 (internal_condition_case_2, internal_condition_case_n):
6305 Remove unnecessary aborts (Bug#9081).
6307 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6309 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6310 has no `load' handler, try opening the file locally. (Bug#9311)
6312 2011-08-16 Ken Brown <kbrown@cornell.edu>
6314 * gmalloc.c: Expand comment.
6316 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6318 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6319 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6321 2011-08-16 Ken Brown <kbrown@cornell.edu>
6323 Fix memory allocation problems in Cygwin build (Bug#9273).
6325 * unexcw.c ( __malloc_initialized): Declare external variable.
6326 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6328 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6330 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6332 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6334 [CYGWIN] (special_realloc): New function.
6335 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6336 requests to realloc storage in the static heap.
6338 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6340 * bidi.c (bidi_initialize): Remove unused local.
6342 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6345 * biditype.h: Remove file.
6346 * makefile.w32-in ($(BLD)/bidi.$(O)):
6347 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6349 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6351 * chartab.c: Improve commentary for the uniprop_table API.
6353 * bidi.c (bidi_paragraph_init): Support zero value of
6354 bidi_ignore_explicit_marks_for_paragraph_level.
6355 (bidi_initialize): Use uniprop_table instead of including
6356 biditype.h and bidimirror.h.
6358 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6359 coordinates of the iterator when restoring from ppos_it.
6362 2011-08-14 Kenichi Handa <handa@m17n.org>
6364 * process.c (create_process): Call setup_process_coding_systems
6365 after the pid of the process is set to -1 (Bug#8162).
6367 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6369 * xdisp.c (move_it_in_display_line_to): Don't invoke
6370 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6371 ppos_it. Fixes vertical cursor motion when line beginning is
6372 covered by an image. (Bug#9296)
6374 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6376 * nsterm.h (ns_run_ascript): Declare.
6377 (NSAPP_DATA2_RUNASSCRIPT): Define.
6379 * nsfns.m (as_script, as_result, as_status): New static variables.
6380 (ns_run_ascript): New function.
6381 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6382 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6383 the event loop. Get status from as_status (Bug#7276).
6385 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6386 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6387 the event loop (Bug#7276).
6389 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6391 * gnutls.c (QCgnutls_bootprop_priority)
6392 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6393 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6394 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6395 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6396 (QCgnutls_bootprop_verify_hostname_error)
6397 (QCgnutls_bootprop_callbacks_verify): Rename from
6398 Qgnutls_bootprop_..., all uses changed.
6400 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6403 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6405 * xfaces.c (Qframe_set_background_mode): Now static.
6406 * dispextern.h (Qframe_set_background_mode): Remove decl.
6408 * process.c (Fnetwork_interface_info): Declare local only if needed.
6410 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6412 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6413 (Fnetwork_interface_list): Allocate in increments of bytes instead
6414 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6415 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6417 (struct ifflag_def): notrailers is smart on OSX.
6418 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6419 Get hardware address with getifaddrs if available.
6421 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6423 * xdisp.c (iterate_out_of_display_property): xassert that
6424 IT->position is set to within IT->object's boundaries. Break from
6425 the loop as soon as EOB is reached; avoids infloops in redisplay
6426 when IT->position is set up wrongly due to some bug.
6427 Set IT->current to match the bidi iterator unconditionally.
6428 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6429 entry. Force push_it to save on the stack the current
6430 buffer/string position, to be restored by pop_it. Fix flags in
6431 the iterator structure wrt the object coming from a display
6432 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6433 properties. (Bug#9284)
6435 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6437 * fontset.c (fontset_get_font_group): Add proper type checks.
6440 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6442 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6443 and LC_VERSION_MIN_MACOSX.
6444 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6445 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6447 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6449 * xdisp.c (forward_to_next_line_start): Allow to use the
6450 no-display-properties-and-no-overlays under bidi display.
6451 Set disp_pos in the bidi iterator to avoid searches for display
6452 properties and overlays.
6454 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6456 * editfns.c (Fset_time_zone_rule): Document relationship with the
6459 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6460 the font entity extracted from the cache (Bug#8109).
6462 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6464 * composite.c (autocmp_chars): Don't reset point. That is done by
6465 restore_point_unwind (Bug#5984).
6467 2011-08-07 Juri Linkov <juri@jurta.org>
6469 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6470 to show the arg `TIME' instead of `TIMEVAL'.
6472 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6474 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6475 display property strides EOL and includes a newline, as in
6476 longlines-mode. (Bug#9254)
6477 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6478 word-wrap under bidirectional display. (Bug#9224)
6480 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6481 is non-zero, even if the data buffer is NULL. Fixes a crash in
6482 vertical-motion with longlines-mode. (Bug#9254)
6484 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6486 * bidi.c <bidi_cache_total_alloc>: Now static.
6487 (bidi_initialize): Initialize bidi_cache_total_alloc.
6489 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6492 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6493 amount allocated this far in `bidi_cache_total_alloc'.
6494 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6495 non-zero, only free the data buffer without restoring the cache
6496 contents. All callers changed.
6498 * dispextern.h (bidi_unshelve_cache): Update prototype.
6500 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6501 (move_it_in_display_line, move_it_to)
6502 (move_it_vertically_backward, move_it_by_lines): Replace the call
6503 to xfree to an equivalent call to bidi_unshelve_cache.
6504 (move_it_in_display_line_to): Fix logic of returning
6505 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6507 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6509 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6510 came from a string character with a `cursor' property. (Bug#9229)
6512 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6514 * Makefile.in (LIB_PTHREAD): New variable.
6515 (LIBES): Add LIB_PTHREAD (Bug#9216).
6517 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6518 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6520 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6522 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6524 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6526 * xterm.c (x_find_topmost_parent): New function.
6527 (x_set_frame_alpha): Find topmost parent window with
6528 x_find_topmost_parent and set the property there also (bug#9181).
6529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6531 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6533 * callproc.c (Fcall_process): Avoid vfork clobbering
6534 the local vars buffer, coding_systems, current_dir.
6536 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6540 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6543 so that it is not optimized away.
6545 * xdisp.c (compute_display_string_pos): Remove unused local.
6547 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6549 Fix slow cursor motion and scrolling in large buffers with
6550 selective display, like Org Mode buffers. (Bug#9218)
6552 * dispextern.h (struct bidi_it): New member disp_prop_p.
6554 * xdisp.c: Remove one-slot cache of display string positions.
6555 (compute_display_string_pos): Accept an additional argument
6556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6557 for a display string or property. If found, set DISP_PROP_P
6560 * bidi.c (bidi_fetch_char): Accept an additional argument
6561 DISP_PROP_P, and pass it to compute_display_string_pos.
6562 Only handle text covered by a display string if DISP_PROP_P is returned
6563 non-zero. All callers of bidi_fetch_char changed.
6565 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6569 2010-12-03 Don March <don@ohspite.net>
6571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6572 last character M-[char] is translated to ESC [char] (bug#7541).
6574 2011-08-02 Kenichi Handa <handa@m17n.org>
6576 * lisp.h (uniprop_table): Extern it.
6578 * chartab.c (uniprop_table): Make it non-static.
6580 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6582 * xdisp.c (forward_to_next_line_start): Accept additional argument
6583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6585 (reseat_at_next_visible_line_start): Use the bidi iterator state
6586 returned by forward_to_next_line_start to restore the state of
6587 it->bidi_it after backing up to previous newline. (Bug#9212)
6589 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6591 * regex.c (re_comp): Protoize.
6592 (re_exec): Fix return type.
6593 (regexec): Fix type of `ret'. (Bug#9203)
6595 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6598 This is needed if max-image-size is a floating-point number.
6600 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6602 * print.c (print_object): Print empty symbol as ##.
6604 * lread.c (read1): Read ## as empty symbol.
6606 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6609 setting frame foreground color (Bug#9175).
6610 (x_set_background_color): Likewise.
6612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6613 contents (Bug#9176).
6614 (EmacsTooltip -init): Remove bezels and add shadows to
6617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6618 or scroll bar (Bug#8470).
6620 * nsfont.m (nsfont_open): Remove assignment to voffset and
6621 unnecessary vars hshink, expand, hd, full_height, min_height.
6622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6624 * nsterm.h (nsfont_info): Remove voffset field.
6626 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6628 Implement strike-through and overline on NextStep (Bug#8863).
6630 * nsfont.m (nsfont_open): Use underline position provided by font,
6631 instead of hard-coded value of 2.
6632 (nsfont_draw): Call ns_draw_text_decoration instead.
6634 * nsterm.h: Add declaration for ns_draw_text_decoration.
6636 * nsterm.m (ns_draw_text_decoration): New function for drawing
6637 underline, overline, and strike-through.
6638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6639 ns_draw_text_decoration. Change treatment of cursor drawing to
6640 accommodate underlining, etc.
6642 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6647 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6650 Without this fix, if a signal arrives just after memory fills up,
6651 'malloc' might be invoked reentrantly.
6653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6654 In other words, assume that every image size is allowed, on non-X
6655 hosts. This assumption is probably wrong, but it lets Emacs compile.
6657 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6659 * regex.c (re_iswctype): Convert return values to boolean.
6661 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6663 * xdisp.c (compute_display_string_pos): Don't use cached display
6664 string position if the buffer had its restriction changed.
6667 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6671 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6673 Integer signedness and overflow and related fixes. (Bug#9079)
6675 * bidi.c: Integer size and overflow fixes.
6676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6680 (bidi_find_other_level_edge):
6681 Use ptrdiff_t instead of EMACS_INT where either will do.
6682 This works better on 32-bit hosts configured --with-wide-int.
6683 (bidi_cache_ensure_space): Check for size-calculation overflow.
6684 Use % rather than repeated addition, for better worst-case speed.
6685 Don't set bidi_cache_size until after xrealloc returns, because it
6687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6688 (bidi_cache_ensure_space): Also check that the bidi cache size
6689 does not exceed that of the largest Lisp string or buffer. See Eli
6690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6692 * alloc.c (__malloc_size_t): Remove.
6693 All uses replaced by size_t. See Andreas Schwab's note
6694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6696 * image.c: Improve checking for integer overflow.
6697 (check_image_size): Assume that f is nonnull, since
6698 it is always nonnull in practice. This is one less thing to
6699 worry about when checking for integer overflow later.
6700 (x_check_image_size): New function, which checks for integer
6701 overflow issues inside X.
6702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6703 This removes the need for a memory_full check.
6704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6706 (xbm_read_bitmap_data): Change locals back to 'int', since
6707 their values must fit in 'int'.
6708 (xpm_load_image, png_load, tiff_load):
6709 Invoke x_create_x_image_and_pixmap earlier,
6710 to avoid much needless work if the image is too large.
6711 (tiff_load): Treat overly large images as if
6712 x_create_x_image_and_pixmap failed, not as malloc failures.
6713 (gs_load): Use x_check_image_size.
6715 * gtkutil.c: Omit integer casts.
6716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6723 would wrongly return t on a 64-bit host.
6725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6728 and therefore cause GCC to emit a bogus diagnostic in some cases.
6730 * image.c: Integer signedness and overflow and related fixes.
6731 This is not an exhaustive set of fixes, but it's time to
6732 record what I've got.
6733 (lookup_pixel_color, check_image_size): Remove redundant decls.
6734 (check_image_size): Don't assume that arbitrary EMACS_INT values
6735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6737 (tiff_load, imagemagick_load_image):
6738 Check for overflow in size calculations.
6739 (x_create_x_image_and_pixmap): Remove unnecessary test for
6740 xmalloc returning NULL; that can't happen.
6741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6742 (xpm_color_bucket): Use better integer hashing function.
6743 (xpm_cache_color): Don't possibly over-allocate memory.
6744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6745 (gif_memory_source):
6746 Use ptrdiff_t, not int or size_t, to record sizes.
6747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6749 either works, as we prefer signed integers.
6750 (tiff_read_from_memory, tiff_write_from_memory):
6751 Return tsize_t, not size_t, since that's what the TIFF API wants.
6752 (tiff_read_from_memory): Don't fail simply because the read would
6753 go past EOF; instead, return a short read.
6754 (tiff_load): Omit no-longer-needed casts.
6755 (Fimagemagick_types): Don't assume size fits into 'int'.
6757 Improve hashing quality when configured --with-wide-int.
6758 * fns.c (hash_string): New function, taken from sxhash_string.
6759 Do not discard information about ASCII character case; this
6760 discarding is no longer needed.
6761 (sxhash-string): Use it. Change sig to match it. Caller changed.
6762 * lisp.h: Declare it.
6763 * lread.c (hash_string): Remove, since we now use fns.c's version.
6764 The fns.c version returns a wider integer if --with-wide-int is
6765 specified, so this should help the quality of the hashing a bit.
6767 * emacs.c: Integer overflow minor fix.
6768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6769 Define only if GNU_LINUX.
6770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6772 * dispnew.c: Integer signedness and overflow fixes.
6773 Remove unnecessary forward decls, that were a maintenance hassle.
6774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6778 (prepare_desired_row, line_draw_cost):
6779 Use int, not unsigned, where either works.
6780 (save_current_matrix, restore_current_matrix):
6781 Use ptrdiff_t, not size_t, where either works.
6782 (init_display): Check for overflow more accurately, and without
6783 relying on undefined behavior.
6785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6786 Remove, replacing with the new symbols in lisp.h. All uses changed.
6787 * fileio.c (make_temp_name):
6788 * filelock.c (lock_file_1, lock_file):
6789 * xdisp.c (message_dolog):
6790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6791 Use pMd etc. instead.
6792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6793 replacing the pWIDE etc. symbols removed from editfns.c.
6795 * keyboard.h (num_input_events): Now uintmax_t.
6796 This is (very slightly) less likely to mess up due to wraparound.
6799 * buffer.c: Integer signedness fixes.
6800 (alloc_buffer_text, enlarge_buffer_text):
6801 Use ptrdiff_t rather than size_t when either will do, as we prefer
6804 * alloc.c: Integer signedness and overflow fixes.
6805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6806 (__malloc_size_t): Default to size_t, not to int.
6807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6809 Prefer ptrdiff_t to size_t when either would do, as we prefer
6811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6813 Now const. Initialize with values that are in range even if char
6815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6817 These functions do the right thing with sizes > 2**32.
6818 (check_depth): Now ptrdiff_t, not int.
6819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6820 Adjust to new way of storing sizes. Check for size overflow bugs
6822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6823 slightly wrong anyway, as it missed one instance of
6824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6825 (refill_memory_reserve): Omit needless cast to size_t.
6826 (mark_object_loop_halt): Mark as externally visible.
6828 * xselect.c: Integer signedness and overflow fixes.
6829 (Fx_register_dnd_atom, x_handle_dnd_message):
6830 Use ptrdiff_t, not size_t, since we prefer signed.
6831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6833 x_dnd_atoms_size and x_dnd_atoms_length.
6835 * doprnt.c: Prefer signed to unsigned when either works.
6837 * doprnt.c (doprnt):
6839 * xdisp.c (vmessage):
6840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6842 prefer signed arithmetic to avoid comparison confusion.
6843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6844 but is a bit tricky.
6846 Assume freestanding C89 headers, string.h, stdlib.h.
6847 * data.c, doprnt.c, floatfns.c, print.c:
6848 Include float.h unconditionally.
6849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6851 * regex.c: Likewise for stddef.h, string.h.
6852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6855 (STDC_HEADERS): Remove obsolete defines.
6856 * sysdep.c: Include limits.h unconditionally.
6858 Assume support for memcmp, memcpy, memmove, memset.
6859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6860 * regex.c (memcmp, memcpy):
6861 Remove; we assume C89 now.
6863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6864 (__malloc_safe_bcopy): Remove; no longer needed.
6866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6868 well either way, and we prefer signed to unsigned.
6870 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6873 closes the connection while we're reading (bug#9182).
6875 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6878 are specified (Bug#9168).
6880 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6883 Found by GCC static checking and --with-wide-int on a 32-bit host.
6885 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6887 * xdisp.c (compute_display_string_pos): Fix logic of caching
6888 previous display string position. Initialize cached_prev_pos to
6889 -1. Fixes slow-down at the beginning of a buffer.
6891 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6894 for attrs[LFACE_FONTSET_INDEX].
6896 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6898 * xml.c (parse_region): Remove unused local
6899 that was recently introduced.
6901 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6906 * xdisp.c (move_it_in_display_line_to): Record the best matching
6907 position for TO_CHARPOS while scanning the line, and restore it on
6908 exit if none of the characters scanned was an exact match.
6909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6910 when exact match is impossible due to invisible text, and the
6911 lines are truncated.
6913 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6918 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6920 Fix a significant slow-down of cursor motion with C-n, C-p,
6921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6922 auto-repeat under bidi redisplay in fontified buffers.
6923 * xdisp.c (compute_stop_pos_backwards): New function.
6924 (next_element_from_buffer): Call compute_stop_pos_backwards to
6925 find a suitable prev_stop when we find ourselves before
6927 (reseat): Don't look for prev_stop, as that could mean a very long
6929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6930 <cached_disp_overlay_modiff>: Cache for last found display string
6932 (compute_display_string_pos): Return the cached position if asked
6933 about the same buffer in the same area of character positions, and
6934 the buffer wasn't changed since the time the display string
6935 position was cached.
6937 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6940 is an integer, which is important for empty lines. (Bug#9149)
6942 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6944 * frame.c (Fmodify_frame_parameters): In tty case, update the
6945 default face if necessary (Bug#4238).
6947 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6949 * editfns.c (Fstring_to_char): No need to explain what a character
6950 is in the docstring (Bug#6576).
6952 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6954 * xml.c (parse_region): Make sure we always return a tree.
6956 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6958 * xml.c (parse_region): If a document contains only comments,
6961 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6963 * xml.c (make_dom): Return comments, too.
6965 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6969 and the surrounding thread.
6970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6974 * s/openbsd.h (BROKEN_SIGIO): Define.
6975 * unexelf.c (unexec) [__OpenBSD__]:
6976 Don't update the .mdebug section of the Alpha COFF symbol table.
6978 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6983 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6986 This fixes some race conditions on the permissions of any newly
6989 * alloc.c (valid_pointer_p): Use pipe, not open.
6990 This fixes some permissions issues when debugging.
6992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6993 If fchown fails to set both uid and gid, try to set just gid,
6994 as that is sometimes allowed. Adjust the file's mode to eliminate
6995 setuid or setgid bits that are inappropriate if fchown fails.
6997 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7000 to compare Lisp_Objects.
7001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7005 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7007 * lread.c (read_integer): Unread even EOF character.
7008 (read1): Likewise. Properly record start position of symbol.
7010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7011 symbol character follows.
7013 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7016 This works around a problem with the previous change to Fcopy_file.
7017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7018 and without this change, GCC might complain about discarding
7019 fchown's return value.
7021 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7025 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7029 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7032 it's used from the C level.
7034 * process.c: Use the same condition for POLL_FOR_INPUT in both
7035 keyboard.c and process.c (bug#1858).
7037 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7040 (Fgnutls_boot): Use it.
7042 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7044 * doc.c (Fsubstitute_command_keys): Revert last change.
7046 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7049 quotes the next character, and doesn't affect other longer
7050 sequences (bug#8935).
7052 * lread.c (syms_of_lread): Clarify that is isn't only
7053 `eval-buffer' and `eval-defun' that's affected by
7054 `lexical-binding' (bug#8460).
7056 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7059 bidi redisplay when a line includes both an image and is truncated.
7061 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7063 Fix minor problems found by static checking.
7064 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7065 (elsz): Now a signed constant, not a size_t var. We prefer signed
7066 types to unsigned, to avoid integer comparison confusion. Without
7067 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7068 "cannot optimize loop, the loop counter may overflow", a symptom
7070 * indent.c (Fvertical_motion): Mark locals as initialized.
7071 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7073 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7075 * search.c (Fre_search_backward): Mention `case-fold-search' in
7076 all the re_search_* functions (bug#8138).
7078 * keyboard.c (Fopen_dribble_file): Document when the file is
7081 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7083 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7086 Support bidi reordering of display and overlay strings.
7087 * xdisp.c (compute_display_string_pos)
7088 (compute_display_string_end): Accept additional argument STRING.
7089 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7090 (reseat_to_string): Initialize bidi_it->string.s and
7091 bidi_it->string.schars.
7092 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7093 NULL (avoids a crash in bidi_paragraph_init).
7094 Initialize itb.string.lstring.
7095 (init_iterator): Call bidi_init_it only of a valid
7096 buffer position was specified. Initialize paragraph_embedding to
7098 (reseat_to_string): Initialize the bidi iterator.
7099 (display_string): If we need to ignore text properties of
7100 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7101 original value of -1 will not work with bidi.)
7102 (compute_display_string_pos): First arg is now struct
7103 `text_pos *'; all callers changed. Support display properties on
7105 (compute_display_string_end): Support display properties on Lisp
7107 (init_iterator, reseat_1, reseat_to_string): Initialize the
7108 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7109 when iterating on a string not from display properties).
7110 (compute_display_string_pos, compute_display_string_end):
7111 Fix calculation of the object to scan. Fixes an error when using
7113 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7114 base_level_stop; instead, set base_level_stop to BEGV.
7115 Fixes crashes in vertical-motion.
7116 (next_element_from_buffer): Improve commentary for when
7117 the iterator is before prev_stop.
7118 (init_iterator): Initialize bidi_p from the default value of
7119 bidi-display-reordering, not from buffer-local value. Use the
7120 buffer-local value only if initializing for buffer iteration.
7121 (handle_invisible_prop): Support invisible properties on strings
7122 that are being bidi-reordered.
7123 (set_iterator_to_next): Support bidi reordering of C strings and
7125 (next_element_from_string): Support bidi reordering of Lisp
7127 (handle_stop_backwards): Support Lisp strings as well.
7128 (display_string): Support display of R2L glyph rows.
7129 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7130 (init_iterator): Don't initialize it->bidi_p for strings
7132 (reseat_to_string): Initialize it->bidi_p for strings here.
7133 (next_element_from_string, next_element_from_c_string)
7134 (next_element_from_buffer): Add xassert's for correspondence
7135 between IT's object being iterated and it->bidi_it.string
7137 (face_before_or_after_it_pos): Support bidi iteration.
7138 (next_element_from_c_string): Handle the case of the first string
7139 character that is not the first one in the visual order.
7140 (get_visually_first_element): New function, refactored from common
7141 parts of next_element_from_buffer, next_element_from_string, and
7142 next_element_from_c_string.
7143 (tool_bar_lines_needed, redisplay_tool_bar)
7144 (display_menu_bar): Force left-to-right direction. Add a FIXME
7145 comment for making that be controlled by a user option.
7146 (push_it, pop_it): Save and restore the state of the
7147 bidi iterator. Save and restore the bidi_p flag.
7148 (pop_it): Iterate out of display property for string iteration as
7150 (iterate_out_of_display_property): Support iteration over strings.
7151 (handle_single_display_spec): Set up it->bidi_it for iteration
7152 over a display string, and call bidi_init_it.
7153 (handle_single_display_spec, next_overlay_string)
7154 (get_overlay_strings_1, push_display_prop): Set up the bidi
7155 iterator for displaying display or overlay strings.
7156 (forward_to_next_line_start): Don't use the shortcut if
7158 (back_to_previous_visible_line_start): If handle_display_prop
7159 pushed the iterator stack, restore the internal state of the bidi
7160 iterator by calling bidi_pop_it same number of times.
7161 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7162 and we are bidi-iterating, don't decrement the iterator position;
7163 instead, set the first_elt flag in the bidi iterator, to produce
7165 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7166 (push_display_prop): xassert that we are iterating a buffer.
7167 (push_it, pop_it): Save and restore paragraph_embedding member.
7168 (handle_single_display_spec, next_overlay_string)
7169 (get_overlay_strings_1, reseat_1, reseat_to_string)
7170 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7171 correctly. Don't assume unibyte strings are not bidi-reordered.
7172 (compute_display_string_pos)
7173 (compute_display_string_end): Fix handling the case of C string.
7174 (push_it, pop_it): Save and restore from_disp_prop_p.
7175 (handle_single_display_spec, push_display_prop): Set the
7176 from_disp_prop_p flag.
7177 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7178 (pop_it): Call iterate_out_of_display_property only if we are
7179 popping after iteration over a string that came from a display
7180 property. Fix a typo in popping stretch info. Add an assertion
7181 for verifying that the iterator position is in sync with the bidi
7183 (handle_single_display_spec, get_overlay_strings_1)
7184 (push_display_prop): Fix initialization of paragraph direction for
7185 string when that of the parent object is not yet determined.
7186 (reseat_1): Call bidi_init_it to resync the bidi
7187 iterator with IT's position. (Bug#7616)
7188 (find_row_edges): If ROW->start.pos gives position
7189 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7190 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7191 Reset the from_disp_prop_p flag.
7192 (SAVE_IT, RESTORE_IT): New macros.
7193 (pos_visible_p, face_before_or_after_it_pos)
7194 (back_to_previous_visible_line_start)
7195 (move_it_in_display_line_to, move_it_in_display_line)
7196 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7197 (try_scrolling, redisplay_window, display_line): Use them when
7198 saving a temporary copy of the iterator and restoring it back.
7199 (back_to_previous_visible_line_start, reseat_1)
7200 (init_iterator): Empty the bidi cache "stack".
7201 (move_it_in_display_line_to): If iterator ended up at
7202 EOL, but we never saw any buffer positions smaller than
7203 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7204 motion in bidi-reordered lines.
7205 (move_it_in_display_line_to): Record prev_method and prev_pos
7206 immediately before the call to set_iterator_to_next. Fixes cursor
7207 motion in bidi-reordered lines with stretch glyphs and strings
7208 displayed in margins. (Bug#8133) (Bug#8867)
7209 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7211 (pos_visible_p): Support positions in bidi-reordered lines.
7212 Save and restore bidi cache.
7214 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7215 (bidi_paragraph_info): Delete unused struct.
7216 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7217 (bidi_cache_start): New variable.
7218 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7220 (bidi_cache_fetch_state, bidi_cache_search)
7221 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7222 (bidi_cache_find, bidi_peek_at_next_level)
7223 (bidi_level_of_next_char, bidi_find_other_level_edge)
7224 (bidi_move_to_visually_next): Compare cache index with
7225 bidi_cache_start rather than with zero.
7226 (bidi_fetch_char): Accept new argument STRING; all callers
7227 changed. Support iteration over a string. Support strings with
7228 display properties. Support unibyte strings. Fix the type of
7229 `len' according to what STRING_CHAR_AND_LENGTH expects.
7230 (bidi_paragraph_init, bidi_resolve_explicit_1)
7231 (bidi_resolve_explicit, bidi_resolve_weak)
7232 (bidi_level_of_next_char, bidi_move_to_visually_next):
7233 Support iteration over a string.
7234 (bidi_set_sor_type, bidi_resolve_explicit_1)
7235 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7236 can now be zero (for strings); special values 0 and -1 were
7237 changed to -1 and -2, respectively.
7238 (bidi_char_at_pos): New function.
7239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7240 Call it instead of FETCH_MULTIBYTE_CHAR.
7241 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7242 initialized to valid values.
7243 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7245 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7246 the test for valid cached positions. Fix the logic for looking up
7247 the sentinel state in the cache. GCPRO the Lisp string we are
7249 (bidi_push_it, bidi_pop_it): New functions.
7250 (bidi_initialize): Initialize the bidi cache start stack pointer.
7251 (bidi_cache_ensure_space): New function, refactored from part of
7252 bidi_cache_iterator_state. Don't assume the required size is just
7253 one BIDI_CACHE_CHUNK away.
7254 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7255 (bidi_count_bytes, bidi_char_at_pos): New functions.
7256 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7257 always valid if bidi_cache_idx is valid.
7258 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7259 is valid if it's going to be used.
7260 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7261 (bidi_cache_fetch_state, bidi_cache_search)
7262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7263 (bidi_cache_iterator_state, bidi_cache_find)
7264 (bidi_find_other_level_edge, bidi_cache_start_stack):
7265 All variables related to cache indices are now EMACS_INT.
7267 * dispextern.h (struct bidi_string_data): New structure.
7268 (struct bidi_it): New member `string'. Make flag members be 1-bit
7269 fields, and put them last in the struct.
7270 (compute_display_string_pos, compute_display_string_end):
7272 (bidi_push_it, bidi_pop_it): Add prototypes.
7273 (struct iterator_stack_entry): New members bidi_p,
7274 paragraph_embedding, and from_disp_prop_p.
7275 (struct it): Member bidi_p is now a bit field 1 bit wide.
7276 (bidi_shelve_cache, bidi_unshelve_cache):
7279 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7280 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7281 and vector-like objects.
7283 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7284 cache around display iteration.
7286 * window.c (Fwindow_end, window_scroll_pixel_based)
7287 (displayed_window_lines, Frecenter): Save and restore the bidi
7288 cache around display iteration.
7290 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7292 * editfns.c (Fdelete_region): Clarify the use of the named
7293 parameters (bug#6788).
7295 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7297 * indent.c (Fvertical_motion): Set and restore w->pointm when
7298 saving and restoring the window's buffer (Bug#9006).
7300 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7302 * editfns.c (Fstring_to_char): Clarify just what is returned
7303 (bug#6576). Text by Eli Zaretskii.
7305 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7307 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7309 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7311 * buffer.c (mmap_find): Fix a typo.
7313 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7315 Fix execution of x selection hooks.
7316 * xselect.c (Qx_lost_selection_functions)
7317 (Qx_sent_selection_functions): New vars.
7318 (syms_of_xselect): DEFSYM them.
7319 (x_handle_selection_request): Pass Qx_sent_selection_functions
7320 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7321 (x_handle_selection_clear,x_clear_frame_selections):
7322 Pass Qx_lost_selection_functions rather than
7323 Vx_lost_selection_functions to Frun_hook_with_args.
7325 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7327 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7328 The old code sometimes used this field without initializing it.
7330 * alloc.c (gc_sweep): Don't read past end of array.
7331 In theory, the old code could also have corrupted Emacs internals,
7332 though it'd be very unlikely.
7334 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7336 * character.c (Fcharacterp): Don't advertise optional ignored
7337 argument. (Bug#4026)
7339 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7341 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7344 * window.c (Fset_window_start): Doc fix (bug#4199).
7345 (Fset_window_hscroll): Ditto.
7347 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7349 Fix minor new problems caught by GCC 4.6.1.
7350 * term.c (init_tty): Remove unused local.
7351 * xsettings.c (store_monospaced_changed): Define this function only
7352 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7355 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7357 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7359 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7361 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7362 are the mini-buffer and the echo area (bug#3320).
7364 * term.c (init_tty): Remove support for supdup, c10 and perq
7365 terminals, which are no longer supported (bug#1482).
7367 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7369 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7371 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7373 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7374 for non-popups (Bug#3642).
7376 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7378 * alloc.c (reset_malloc_hooks): Protoize.
7379 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7380 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7381 * cm.c (losecursor): Likewise.
7382 * data.c (fmod): Likewise.
7383 * dispnew.c (swap_glyphs_in_rows): Likewise.
7384 * emacs.c (memory_warning_signal): Likewise.
7385 * floatfns.c (float_error): Likewise.
7386 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7387 (otf_open, font_otf_capability, generate_otf_features)
7388 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7390 * image.c (pbm_read_file): Likewise.
7391 * indent.c (string_display_width): Likewise.
7392 * intervals.c (check_for_interval, search_for_interval)
7393 (inc_interval_count, count_intervals, root_interval)
7394 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7395 * lread.c (defalias): Likewise.
7396 * ralloc.c (r_alloc_check): Likewise.
7397 * regex.c (set_image_of_range_1, set_image_of_range)
7398 (regex_grow_registers): Likewise.
7399 * sysdep.c (strerror): Likewise.
7400 * termcap.c (valid_filename_p, tprint, main): Likewise.
7401 * tparam.c (main): Likewise.
7402 * unexhp9k800.c (run_time_remap, save_data_space)
7403 (update_file_ptrs, read_header, write_header, calculate_checksum)
7404 (copy_file, copy_rest, display_header): Likewise.
7405 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7407 * xdisp.c (check_it): Likewise.
7408 * xfaces.c (register_color, unregister_color, unregister_colors):
7410 * xfns.c (print_fontset_result): Likewise.
7411 * xrdb.c (member, fatal, main): Likewise.
7413 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7415 Fix minor problems found by static checking (Bug#9031).
7416 * chartab.c (char_table_set_range, map_sub_char_table):
7417 Remove unused locals.
7418 (uniprop_table): Now static.
7419 * composite.c (_work_char): Remove unused static var.
7421 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7423 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7425 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7427 * gtkutil.c (qttip_cb): Remove code without function.
7429 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7431 * w32.c (pthread_sigmask): New stub.
7433 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7435 Use pthread_sigmask, not sigprocmask (Bug#9010).
7436 sigprocmask is portable only for single-threaded applications, and
7437 Emacs can be multi-threaded when it uses GTK.
7438 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7440 * callproc.c (Fcall_process):
7441 * process.c (create_process):
7442 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7443 Use pthread_sigmask, not sigprocmask.
7445 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7447 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7448 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7451 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7453 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7454 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7455 (xg_hide_tooltip): Fix comment.
7457 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7458 in registerServicesMenuSendTypes.
7459 (validRequestorForSendType): Don't check ns_return_types.
7461 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7464 2011-07-08 Jason Rumney <jasonr@gnu.org>
7466 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7467 SH_SHOW for hidden windows (Bug#5482).
7469 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7470 frame struct members of non-existent frames (Bug#6284).
7472 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7474 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7475 variable firstTime not needed on OSX >= 10.6.
7476 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7477 >= 10.5. Use setKnobProportion, setDoubleValue.
7479 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7480 (MAC_OS_X_VERSION_10_5): Define if not defined.
7481 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7482 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7483 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7485 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7486 cString and lossyCString on OSX >= 10.4
7488 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7489 sizeToFit on OSX >= 10.2.
7491 * nsimage.m (allocInitFromFile): Don't use deprecated method
7492 bestRepresentationForDevice on OSX >= 10.6.
7494 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7497 * emacs.c: Declare unexec_init_emacs_zone.
7499 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7501 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7503 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7504 on svcsMenu (Bug#8842).
7506 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7508 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7510 * nsterm.m (QUTF8_STRING): Declare.
7511 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7512 (validRequestorForSendType): Return type is (id).
7513 Change indexOfObjectIdenticalTo to indexOfObject.
7514 Check if we have local selection before returning self (Bug#8842).
7515 (writeSelectionToPasteboard): Put local selection into paste board
7516 if we have a local selection (Bug#8842).
7517 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7519 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7520 (ns_get_local_selection): Declare.
7522 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7524 * keymap.c (describe_map_tree): Don't insert a double newline at
7525 the end of the buffer (bug#1169) and return whether we inserted
7528 * callint.c (Fcall_interactively): Change "reading args" to
7529 "providing args" to try to clarify what it does (bug#1010).
7531 2011-07-07 Kenichi Handa <handa@m17n.org>
7533 * composite.c (composition_compute_stop_pos): Ignore a static
7534 composition starting before CHARPOS (Bug#8915).
7536 * xdisp.c (handle_composition_prop): Likewise.
7538 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7540 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7543 2011-07-07 Kenichi Handa <handa@m17n.org>
7545 * character.h (unicode_category_t): New enum type.
7547 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7548 (Qchar_code_property_table): New variable.
7549 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7550 (UNIPROP_COMPRESSED_FORM_P): New macros.
7551 (char_table_ascii): Uncompress the compressed values.
7552 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7553 Uncompress the compressed values.
7554 (sub_char_table_ref_and_range): Likewise.
7555 (char_table_ref_and_range): Uncompress the compressed values.
7556 (sub_char_table_set): New arg is_uniprop. Callers changed.
7557 Uncompress the compressed values.
7558 (sub_char_table_set_range): Args changed. Callers changed.
7559 (char_table_set_range): Adjuted for the above change.
7560 (map_sub_char_table): Delete args default_val and parent. Add arg
7561 top. Give decoded values to a Lisp function.
7562 (map_char_table): Adjust for the above change. Give decoded
7563 values to a Lisp function. Gcpro more variables.
7564 (uniprop_table_uncompress)
7565 (uniprop_decode_value_run_length): New functions.
7566 (uniprop_decoder, uniprop_decoder_count): New variables.
7567 (uniprop_get_decoder, uniprop_encode_value_character)
7568 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7570 (uniprop_encoder, uniprop_encoder_count): New variables.
7571 (uniprop_get_encoder, uniprop_table)
7572 (Funicode_property_table_internal, Fget_unicode_property_internal)
7573 (Fput_unicode_property_internal): New functions.
7574 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7575 Sunicode_property_table_internal, Sget_unicode_property_internal,
7576 and Sput_unicode_property_internal. Defvar_lisp
7577 char-code-property-alist.
7579 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7580 Vunicode_category_table.
7582 * font.c (font_range): Adjust for the change of
7583 Vunicode_category_table.
7585 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7587 * m/iris4d.h: Remove file, move contents ...
7588 * s/irix6-5.h: ... here.
7590 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7592 Remove unportable assumption about struct layout (Bug#8884).
7593 * alloc.c (mark_buffer):
7594 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7595 (clone_per_buffer_values): Don't assume that
7596 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7597 This isn't true in general, and it's particularly not true
7598 if Emacs is configured with --with-wide-int.
7599 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7600 New macros, used in the buffer.c change.
7602 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7604 * xsettings.c: Use both GConf and GSettings if both are available.
7605 (store_config_changed_event): Add comment.
7606 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7607 (store_tool_bar_style_changed): New functions.
7608 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7609 (struct xsettings): Move font inside HAVE_XFT.
7610 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7611 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7612 Move inside HAVE_XFT.
7613 (something_changed_gsettingsCB): Rename from something_changedCB.
7614 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7616 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7617 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7618 (something_changed_gconfCB): Rename from something_changedCB.
7619 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7620 (parse_settings): Move check for font inside HAVE_XFT.
7621 (read_settings, apply_xft_settings): Add comment.
7622 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7623 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7624 call store_font_name_changed.
7625 (xft_settings_event): Add comment.
7626 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7627 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7628 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7629 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7630 (xsettings_initialize): Call init_gsettings last.
7631 (xsettings_get_system_font, xsettings_get_system_normal_font):
7634 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7636 Random fixes. E.g., (random) never returned negative values.
7637 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7638 subseconds part to the entropy, as that's a bit more random.
7639 Prefer signed to unsigned, since the signedness doesn't matter and
7640 in general we prefer signed. When given a limit, use a
7641 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7642 latter isn't right if USE_2_TAGS_FOR_INTS.
7643 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7644 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7646 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7648 * textprop.c (text_property_stickiness):
7649 Obey Vtext_property_default_nonsticky.
7650 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7651 * w32fns.c (syms_of_w32fns):
7652 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7654 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7656 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7657 This is more efficient than Ffile_directory_p and avoids a minor race.
7659 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7661 * buffer.c (Foverlay_put): Say what the return value is
7664 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7665 is a directory before asking whether to use the file name
7667 (barf_or_query_if_file_exists): Make the "File is a directory"
7668 error be more correct.
7670 * fns.c (Frequire): Remove the mention of the .gz files, since
7671 that's installation-specific, but keep the mention of
7672 `get-load-suffixes'.
7674 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7676 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7677 Report string overflow if the output is too long.
7679 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7681 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7682 (syms_of_gnutls): Remove duplicate DEFSYM for
7683 Qgnutls_bootprop_verify_hostname_error, an error for
7684 Qgnutls_bootprop_verify_error (which is no longer used).
7686 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7687 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7688 Also (re)move comments that are misplaced or no longer relevant.
7690 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7692 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7694 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7696 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7697 and background color parameters if they have been changed.
7699 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7701 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7703 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7705 * xsettings.c (SYSTEM_FONT): Define only when used.
7706 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7708 * keymap.c (access_keymap_1): Now static.
7710 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7712 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7713 leave any prefix arg for the up event (Bug#1586).
7715 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7717 * lread.c (syms_of_lread): Mention single symbols defined by
7718 `defvar' or `defconst' (bug#7154).
7720 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7721 (Frequire): Mention get-load-suffixes.
7723 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7725 * window.h (window): Remove clone_number slot.
7726 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7728 (make_parent_window, make_window, saved_window)
7729 (Fset_window_configuration, save_window_save): Don't deal with
7731 * buffer.c (Qclone_number): Remove declaration.
7732 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7734 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7736 Add multiple inheritance to keymaps.
7737 * keymap.c (Fmake_composed_keymap): New function.
7738 (Fset_keymap_parent): Simplify.
7739 (fix_submap_inheritance): Remove.
7740 (access_keymap_1): New function extracted from access_keymap to handle
7741 embedded parents and handle lists of maps.
7742 (access_keymap): Use it.
7743 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7744 (Fcopy_keymap): Handle embedded parents.
7745 (Fcommand_remapping, define_as_prefix): Simplify.
7746 (Fkey_binding): Simplify.
7747 (syms_of_keymap): Move minibuffer-local-completion-map,
7748 minibuffer-local-filename-completion-map,
7749 minibuffer-local-must-match-map, and
7750 minibuffer-local-filename-must-match-map to Elisp.
7751 (syms_of_keymap): Defsubr make-composed-keymap.
7752 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7753 (parse_menu_item): Trivial simplification.
7755 2011-07-01 Glenn Morris <rgm@gnu.org>
7757 * Makefile.in (SETTINGS_LIBS): Fix typo.
7759 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7761 * coding.c (Fencode_coding_string): Record the last coding system
7762 used, as the function doc string says (bug#8738).
7764 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7766 * xsettings.c (store_monospaced_changed): Take new font as arg and
7767 check for change against current_mono_font.
7768 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7769 (emacs_settings_constructor, emacs_settings_get_property)
7770 (emacs_settings_set_property, emacs_settings_class_init)
7771 (emacs_settings_init, gsettings_obj): Remove.
7772 (something_changedCB): New function for HAVE_GSETTINGS.
7773 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7774 with value as argument.
7775 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7776 g_settings_new (Bug#8967). Do not create gsettings_obj.
7777 Remove calls to g_settings_bind. Connect something_changedCB to
7780 * xgselect.c: Add defined (HAVE_GSETTINGS).
7781 (xgselect_initialize): Ditto.
7783 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7784 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7787 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7789 * eval.c (struct backtrace): Simplify and port the data structure.
7790 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7791 signed bit field, as this assumption is not portable and it makes
7792 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7793 "char debug_on_exit : 1" as this is not portable either; instead,
7794 use the portable "unsigned int debug_on_exit : 1". Remove unused
7795 member evalargs. Remove obsolete comments about cc bombing out.
7797 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7799 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7800 Let HAVE_GSETTINGS override HAVE_GCONF.
7801 (store_monospaced_changed): New function.
7802 (EMACS_SETTINGS): A new type derived from GObject to handle
7803 GSettings notifications.
7804 (emacs_settings_constructor, emacs_settings_get_property)
7805 (emacs_settings_set_property, emacs_settings_class_init):
7807 (gsettings_client, gsettings_obj): New variables.
7808 (GSETTINGS_SCHEMA): New define.
7809 (something_changedCB): Call store_monospaced_changed.
7810 (init_gsettings): New function.
7811 (xsettings_initialize): Call init_gsettings.
7812 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7815 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7818 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7820 * window.c (resize_root_window, grow_mini_window)
7821 (shrink_mini_window): Rename Qresize_root_window to
7822 Qwindow_resize_root_window and Qresize_root_window_vertically to
7823 Qwindow_resize_root_window_vertically.
7825 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7827 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7829 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7831 * makefile.w32-in: Redesign dependencies so they reflect more
7832 clearly which files are directly included by each source file,
7833 and not through other includes.
7835 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7837 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7838 (sort_overlays, overlay_strings): When an overlay's clone number
7839 matches the window's clone number process the overlay even if
7840 the overlay's window property doesn't match the current window.
7842 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7843 (Fwindow_hchild): Rename to Fwindow_left_child.
7844 (Fwindow_next): Rename to Fwindow_next_sibling.
7845 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7846 (resize_window_check): Rename to window_resize_check.
7847 (resize_window_apply): Rename to window_resize_apply.
7848 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7849 (Fdelete_other_windows_internal, resize_frame_windows)
7850 (Fsplit_window_internal, Fdelete_window_internal)
7851 (grow_mini_window, shrink_mini_window)
7852 (Fresize_mini_window_internal): Fix callers accordingly.
7854 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7856 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7857 (emacs_fixed_set_min_size): Remove.
7858 (emacs_fixed_new): Take frame as argument.
7860 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7861 (_EmacsFixedPrivate): Remove minwidth/height.
7862 Add struct frame *f.
7863 (emacs_fixed_init): Initialize priv->f.
7864 (get_parent_class, emacs_fixed_set_min_size): Remove.
7865 (emacs_fixed_new): Set priv->f to argument.
7866 (emacs_fixed_get_preferred_width)
7867 (emacs_fixed_get_preferred_height): Use min_width/height from
7868 frames size_hint to set minimum and natural (Bug#8919).
7869 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7870 and use min_width/height from frames size_hint to set
7871 min_width/height (Bug#8919).
7873 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7874 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7877 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7879 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7880 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7883 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7885 * process.c (wait_reading_process_output): Bypass select if
7886 waiting for a cell while ignoring keyboard input, and input is
7887 pending. Suggested by Jan Djärv (Bug#8869).
7889 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7891 Use gnulib's dup2 module instead of rolling our own.
7892 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7894 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7896 * dispnew.c (scrolling_window): Before scrolling, turn off a
7897 mouse-highlight in the window being scrolled.
7899 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7901 Move DEFSYM to lisp.h and use everywhere.
7903 * character.h (DEFSYM): Move declaration...
7904 * lisp.h (DEFSYM): ...here.
7910 * w32select.c: Don't include character.h.
7912 * alloc.c (syms_of_alloc):
7913 * buffer.c (syms_of_buffer):
7914 * bytecode.c (syms_of_bytecode):
7915 * callint.c (syms_of_callint):
7916 * casefiddle.c (syms_of_casefiddle):
7917 * casetab.c (init_casetab_once):
7918 * category.c (init_category_once, syms_of_category):
7919 * ccl.c (syms_of_ccl):
7920 * cmds.c (syms_of_cmds):
7921 * composite.c (syms_of_composite):
7922 * dbusbind.c (syms_of_dbusbind):
7923 * dired.c (syms_of_dired):
7924 * dispnew.c (syms_of_display):
7925 * doc.c (syms_of_doc):
7926 * editfns.c (syms_of_editfns):
7927 * emacs.c (syms_of_emacs):
7928 * eval.c (syms_of_eval):
7929 * fileio.c (syms_of_fileio):
7930 * fns.c (syms_of_fns):
7931 * frame.c (syms_of_frame):
7932 * fringe.c (syms_of_fringe):
7933 * insdel.c (syms_of_insdel):
7934 * keymap.c (syms_of_keymap):
7935 * lread.c (init_obarray, syms_of_lread):
7936 * macros.c (syms_of_macros):
7937 * msdos.c (syms_of_msdos):
7938 * print.c (syms_of_print):
7939 * process.c (syms_of_process):
7940 * search.c (syms_of_search):
7941 * sound.c (syms_of_sound):
7942 * syntax.c (init_syntax_once, syms_of_syntax):
7943 * terminal.c (syms_of_terminal):
7944 * textprop.c (syms_of_textprop):
7945 * undo.c (syms_of_undo):
7946 * w32.c (globals_of_w32):
7947 * window.c (syms_of_window):
7948 * xdisp.c (syms_of_xdisp):
7949 * xfaces.c (syms_of_xfaces):
7950 * xfns.c (syms_of_xfns):
7951 * xmenu.c (syms_of_xmenu):
7952 * xsettings.c (syms_of_xsettings):
7953 * xterm.c (syms_of_xterm): Use DEFSYM.
7955 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7957 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7959 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7961 Integer and buffer overflow fixes (Bug#8873).
7963 * print.c (printchar, strout): Check for string overflow.
7964 (PRINTPREPARE, printchar, strout):
7965 Don't set size unless allocation succeeds.
7967 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7968 for sizes. Check for string overflow more accurately.
7969 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7971 * macros.c: Integer and buffer overflow fixes.
7972 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7973 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7974 Use ptrdiff_t, not int, for sizes.
7975 Don't increment bufsize until after realloc succeeds.
7976 Check for size-calculation overflow.
7977 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7979 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7981 * lread.c: Integer overflow fixes.
7982 (read_integer): Radix is now EMACS_INT, not int,
7983 to improve quality of diagnostics for out-of-range radices.
7984 Calculate buffer size correctly for out-of-range radices.
7985 (read1): Check for integer overflow in radices, and in
7986 read-circle numbers.
7987 (read_escape): Avoid int overflow.
7988 (Fload, openp, read_buffer_size, read1)
7989 (substitute_object_recurse, read_vector, read_list, map_obarray):
7990 Use ptrdiff_t, not int, for sizes.
7991 (read1): Use EMACS_INT, not int, for sizes.
7992 Check for size overflow.
7994 * image.c (cache_image): Check for size arithmetic overflow.
7996 * lread.c: Integer overflow issues.
7997 (saved_doc_string_size, saved_doc_string_length)
7998 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7999 Now ptrdiff_t, not int.
8000 (read1): Don't assume doc string length fits in int. Check for
8001 out-of-range doc string lengths.
8002 (read_list): Don't assume file position fits in int.
8003 (read_escape): Check for hex character overflow.
8005 2011-06-22 Leo Liu <sdl.web@gmail.com>
8007 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8008 Move to minibuffer.el.
8010 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8012 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8013 The following patches are for when GLYPH_DEBUG && !XASSERT.
8014 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8015 * dispnew.c (flush_stdout):
8016 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8017 Mark as externally visible.
8018 * dispnew.c (check_window_matrix_pointers): Now static.
8019 * dispnew.c (window_to_frame_vpos):
8020 * xfns.c (unwind_create_frame):
8021 * xterm.c (x_check_font): Remove unused local.
8022 * scroll.c (CHECK_BOUNDS):
8023 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8024 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8025 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8026 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8027 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8029 (debug_method_add): Use va_list and vsprintf rather than relying
8030 on undefined behavior with wrong number of arguments.
8031 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8032 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8033 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8034 since we're not interested in debugging glyphs with old libraries.
8035 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8036 GCC 4.6.0's static checking.
8038 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8040 Integer overflow and signedness fixes (Bug#8873).
8041 A few related buffer overrun fixes, too.
8043 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8045 * dispextern.h (struct face.stipple):
8046 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8047 (x_bitmap_mask, x_allocate_bitmap_record)
8048 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8049 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8050 (x_create_bitmap_from_xpm_data):
8051 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8052 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8054 * xfaces.c (load_pixmap):
8055 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8056 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8057 (.bitmaps_last, struct x_output.icon_bitmap):
8058 Use ptrdiff_t, not int, for bitmap indexes.
8059 (x_allocate_bitmap_record): Check for size overflow.
8060 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8062 Use ptrdiff_t, not int, for overlay counts.
8063 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8064 * editfns.c (overlays_around, get_pos_property):
8065 * textprop.c (get_char_property_and_overlay):
8066 * xdisp.c (next_overlay_change, note_mouse_highlight):
8067 * xfaces.c (face_at_buffer_position):
8068 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8069 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8070 (Fnext_overlay_change, Fprevious_overlay_change)
8071 (mouse_face_overlay_overlaps, Foverlays_in):
8072 Use ptrdiff_t, not int, for sizes.
8073 (overlays_at, overlays_in): Check for size-calculation overflow.
8075 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8077 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8078 (x_session_initialize): Do not assume string length fits in int.
8080 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8081 This is unlikely, but can occur if DPI is outlandish.
8083 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8084 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8086 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8087 * xrdb.c (magic_file_p, search_magic_path):
8088 Omit last arg SUFFIX; it was always 0. All callers changed.
8089 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8091 * xfont.c (xfont_match): Avoid need for strlen.
8093 * xfns.c: Don't assume strlen fits in int.
8094 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8096 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8097 not unsigned long, as we prefer signed integers. All callers changed.
8098 Detect integer overflow in repeat count.
8099 (message_dolog): Don't assume print length fits in 39 bytes.
8100 (display_mode_element): Don't assume strlen fits in int.
8102 * termcap.c: Don't assume sizes fit in int and never overflow.
8103 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8104 (gobble_line): Check for size-calculation overflow.
8106 * minibuf.c (Fread_buffer):
8107 * lread.c (intern, intern_c_string):
8108 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8109 Don't assume string length fits in int.
8111 * keyboard.c (parse_tool_bar_item):
8112 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8114 * font.c: Don't assume string length fits in int.
8115 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8116 Use ptrdiff_t, not int.
8117 (font_intern_prop): Don't assume string length fits in int.
8118 Don't assume integer property fits in fixnum.
8119 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8121 * filelock.c: Fix some buffer overrun and integer overflow issues.
8122 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8123 Reformulate so as not to need the command string.
8124 Invoke gzip -cd rather than gunzip, as it's more portable.
8125 (lock_info_type, lock_file_1, lock_file):
8126 Don't assume pid_t and time_t fit in unsigned long.
8127 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8128 (current_lock_owner): Prefer signed type for sizes.
8129 Use memcpy, not strncpy, where memcpy is what is really wanted.
8130 Don't assume (via atoi) that time_t and pid_t fit in int.
8131 Check for time_t and/or pid_t out of range, e.g., via a network share.
8132 Don't alloca where an auto var works fine.
8134 * fileio.c: Fix some integer overflow issues.
8135 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8136 Don't assume string length fits in int.
8137 (directory_file_name): Don't assume string length fits in long.
8138 (make_temp_name): Don't assume pid fits in int, or that its print
8139 length is less than 20.
8141 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8143 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8145 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8147 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8148 We prefer signed integers, even for size calculations.
8150 * emacs.c: Don't assume string length fits in 'int'.
8151 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8152 (main): Don't invoke strlen when not needed.
8154 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8155 (XD_DEBUG_MESSAGE): Don't waste a byte.
8157 * callproc.c (getenv_internal_1, getenv_internal)
8159 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8161 * lread.c (invalid_syntax): Omit length argument.
8162 All uses changed. This doesn't fix a bug, but it simplifies the
8163 code away from its former Hollerith-constant appearance, and it's
8164 one less 'int' to worry about when looking at integer-overflow issues.
8165 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8167 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8168 This didn't break anything, but it didn't help either.
8169 It's confusing to put a bogus integer in a place where the actual
8170 value does not matter.
8171 (LIST_END_P): Remove unused macro and its bogus comment.
8172 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8174 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8175 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8177 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8178 We prefer signed types, and the value cannot exceed the EMACS_INT
8179 range anyway (because otherwise the length would not be representable).
8180 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8181 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8182 This avoids a GCC warning when WIDE_EMACS_INT.
8184 * indent.c (sane_tab_width): New function.
8185 (current_column, scan_for_column, Findent_to, position_indentation)
8186 (compute_motion): Use it. This is just for clarity.
8187 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8189 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8191 * lisp.h (lint_assume): New macro.
8192 * composite.c (composition_gstring_put_cache):
8193 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8195 * editfns.c, insdel.c:
8196 Omit unnecessary forward decls, to simplify future changes.
8198 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8200 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8202 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8203 Use much-faster test for byte-length change.
8204 Don't assume string byte-length fits in 'int'.
8205 Check that character arg fits in 'int'.
8206 (mapcar1): Declare byte as byte, for clarity.
8208 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8210 * fns.c (concat): Catch string overflow earlier.
8211 Do not rely on integer wraparound.
8213 * dispextern.h (struct it.overlay_strings_charpos)
8214 (struct it.selective): Now EMACS_INT, not int.
8215 * xdisp.c (forward_to_next_line_start)
8216 (back_to_previous_visible_line_start)
8217 (reseat_at_next_visible_line_start, next_element_from_buffer):
8218 Don't arbitrarily truncate the value of 'selective' to int.
8220 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8222 * composite.c: Don't truncate sizes to 'int'.
8223 (composition_gstring_p, composition_reseat_it)
8224 (composition_adjust_point): Use EMACS_INT, not int.
8225 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8226 not EMACS_UINT, for indexes.
8228 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8230 * buffer.c: Include <verify.h>.
8231 (struct sortvec.priority, struct sortstr.priority):
8232 Now EMACS_INT, not int.
8233 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8234 (struct sortstr.size, record_overlay_string)
8235 (struct sortstrlist.size, struct sortlist.used):
8236 Don't truncate size to int.
8237 (record_overlay_string): Check for size-calculation overflow.
8238 (init_buffer_once): Check at compile-time, not run-time.
8240 2011-06-22 Jim Meyering <meyering@redhat.com>
8242 Don't leak an XBM-image-sized buffer
8243 * image.c (xbm_load): Free the image buffer after using it.
8245 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8248 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8249 that Sun C diagnosed.
8250 * fns.c (secure_hash): Fix pointer signedness issue.
8251 * intervals.c (static_offset_intervals): New function.
8252 (offset_intervals): Use it.
8254 2011-06-21 Leo Liu <sdl.web@gmail.com>
8257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8260 * fns.c (secure_hash): Rename from crypto_hash_function and change
8261 the first arg to accept symbols.
8262 (Fsecure_hash): New primitive.
8263 (syms_of_fns): New symbols.
8265 2011-06-20 Deniz Dogan <deniz@dogan.se>
8267 * process.c (Fset_process_buffer): Clarify return value in
8270 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8272 * dispnew.c (add_window_display_history): Use BVAR.
8274 * xdisp.c (debug_method_add): Use BVAR.
8275 (check_window_end, dump_glyph_matrix, dump_glyph)
8276 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8278 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8281 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8282 check till after the cache is created in init_frame_faces.
8284 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8286 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8288 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8290 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8291 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8292 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8294 Improve buffer-overflow checking (Bug#8873).
8295 * fileio.c (Finsert_file_contents):
8296 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8297 Remove the old (too-loose) buffer overflow checks.
8298 They weren't needed, since make_gap checks for buffer overflow.
8299 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8300 The old code merely checked for Emacs fixnum overflow, and relied
8301 on undefined (wraparound) behavior. The new code avoids undefined
8302 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8304 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8305 Tune. Don't use wider integers than needed. Don't use alloca.
8306 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8308 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8310 * insdel.c, lisp.h (buffer_overflow): New function.
8311 (insert_from_buffer_1, replace_range, replace_range_2):
8312 * insdel.c (make_gap_larger):
8313 * editfns.c (Finsert_char):
8314 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8316 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8318 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8320 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8322 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8323 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8325 * fileio.c: Don't assume EMACS_INT fits in off_t.
8326 (emacs_lseek): New static function.
8327 (Finsert_file_contents, Fwrite_region): Use it.
8328 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8330 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8332 * fns.c: Don't overflow int when computing a list length.
8333 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8334 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8335 truncation on 64-bit hosts. Check for QUIT every
8336 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8337 faster and is responsive enough.
8338 (Flength): Report an error instead of overflowing an integer.
8339 (Fsafe_length): Return a float if the value is not representable
8340 as a fixnum. This shouldn't happen except in contrived situations.
8341 (Fnthcdr, Fsort): Don't assume list length fits in int.
8342 (Fcopy_sequence): Don't assume vector length fits in int.
8344 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8345 (header_size, word_size): New constants.
8346 (allocate_vectorlike): Don't check size overflow here.
8347 (allocate_vector): Check it here instead, since this is the only
8348 caller of allocate_vectorlike that could cause overflow.
8349 Check that the new vector's length is representable as a fixnum.
8351 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8352 The previous code was bogus. For example, next_almost_prime (32)
8353 returned 39, which is undesirable as it is a multiple of 3; and
8354 next_almost_prime (24) returned 25, which is a multiple of 5 so
8355 why was the code bothering to check for multiples of 7?
8357 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8359 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8361 Variadic C functions now count arguments with ptrdiff_t.
8362 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8363 Back then I didn't know that the Emacs coding style prefers signed int.
8364 Also, in the meantime I found a few more instances where arguments
8365 were being counted with int, which may truncate counts on 64-bit
8366 machines, or EMACS_INT, which may be unnecessarily wide.
8367 * lisp.h (struct Lisp_Subr.function.aMANY)
8368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8369 Arg counts are now ptrdiff_t, not size_t.
8370 All variadic functions and their callers changed accordingly.
8371 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8372 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8373 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8374 * callint.c (Fcall_interactively): Check arg count for overflow,
8375 to avoid potential buffer overrun. Use signed char, not 'int',
8376 for 'varies' array, so that we needn't bother to check its size
8377 calculation for overflow.
8378 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8379 * eval.c (apply_lambda):
8380 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8381 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8382 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8384 * callint.c (Fcall_interactively): Don't use index var as event count.
8386 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8387 * mem-limits.h (SIZE): Remove; no longer used.
8389 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8391 Remove unnecessary casts.
8392 * xterm.c (x_term_init):
8393 * xfns.c (x_set_border_pixel):
8394 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8395 These aren't needed now that we assume ANSI C.
8397 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8398 It's more likely to cause problems (due to unsigned overflow)
8401 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8403 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8405 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8407 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8409 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8411 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8413 GLYPH_CODE_FACE returns EMACS_INT, not int.
8414 * dispextern.h (merge_faces):
8415 * xfaces.c (merge_faces):
8416 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8417 Don't assume EMACS_INT fits in int.
8419 * character.h (CHAR_VALID_P): Remove unused parameter.
8420 * fontset.c, lisp.h, xdisp.c: All uses changed.
8422 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8424 * fns.c (concat): Minor tuning based on overflow analysis.
8425 This doesn't fix any bugs. Use int to hold character, instead
8426 of constantly refetching from Emacs object. Use XFASTINT, not
8427 XINT, for value known to be a character. Don't bother comparing
8428 a single byte to 0400, as it's always less.
8430 * floatfns.c (Fexpt):
8431 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8433 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8436 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8438 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8439 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8440 incorrectly succeed when S was a string, because 4294967386 was
8441 truncated before it was used.
8443 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8444 Otherwise, an out-of-range integer could cause undefined behavior
8447 * composite.c: Use int, not EMACS_INT, for characters.
8448 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8449 EMACS_INT, for values that are known to be in character range.
8450 This doesn't fix any bugs but is the usual style inside Emacs and
8451 may generate better code on 32-bit machines.
8453 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8454 This is for reasons similar to the recent CHAR_STRING fix.
8455 * charset.c (Fencode_char): Check that character arg is actually
8456 a character. Pass an int to ENCODE_CHAR.
8457 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8458 wider than 'int', as a compile-time check to prevent future regressions
8461 * character.c (char_string): Remove unnecessary casts.
8463 Make sure a 64-bit char is never passed to CHAR_STRING.
8464 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8465 by silently ignoring the top 32 bits, allowing some values
8466 that were far too large to be valid characters.
8467 * character.h: Include <verify.h>.
8468 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8469 arguments are no wider than unsigned, as a compile-time check
8470 to prevent future regressions in this area.
8472 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8473 (Fsubst_char_in_region):
8475 * xdisp.c (decode_mode_spec_coding):
8476 Adjust to CHAR_STRING's new requirement.
8477 * editfns.c (Finsert_char, Fsubst_char_in_region):
8478 * fns.c (concat): Check that character args are actually
8479 characters. Without this test, these functions did the wrong
8480 thing with wildly out-of-range values on 64-bit hosts.
8482 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8483 These casts should not be needed on 32-bit hosts, either.
8484 * keyboard.c (read_char):
8485 * lread.c (Fload): Remove casts to unsigned.
8487 * lisp.h (UNSIGNED_CMP): New macro.
8488 This fixes comparison bugs on 64-bit hosts.
8489 (ASCII_CHAR_P): Use it.
8490 * casefiddle.c (casify_object):
8491 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8492 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8493 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8494 * dispextern.h (FACE_FROM_ID):
8495 * keyboard.c (read_char): Use UNSIGNED_CMP.
8497 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8498 not to EMACS_INT, to avoid GCC warning.
8500 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8502 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8503 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8504 isn't needed on 32-bit machines.
8506 * buffer.c (Fgenerate_new_buffer_name):
8507 Use EMACS_INT for count, not int.
8508 (advance_to_char_boundary): Return EMACS_INT, not int.
8510 * data.c (Qcompiled_function): Now static.
8512 * window.c (window_body_lines): Now static.
8514 * image.c (gif_load): Rename local to avoid shadowing.
8516 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8517 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8518 * alloc.c (make_save_value): Integer argument is now of type
8520 (mark_object): Use ptrdiff_t, not int.
8521 * lisp.h (pD): New macro.
8522 * print.c (print_object): Use it.
8524 * alloc.c: Use EMACS_INT, not int, to count objects.
8525 (total_conses, total_markers, total_symbols, total_vector_size)
8526 (total_free_conses, total_free_markers, total_free_symbols)
8527 (total_free_floats, total_floats, total_free_intervals)
8528 (total_intervals, total_strings, total_free_strings):
8529 Now EMACS_INT, not int. All uses changed.
8530 (Fgarbage_collect): Compute overall total using a double, so that
8531 integer overflow is less likely to be a problem. Check for overflow
8532 when converting back to an integer.
8533 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8534 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8535 These were 'int' variables that could overflow on 64-bit hosts;
8536 they were never used, so remove them instead of repairing them.
8537 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8538 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8539 Previously, this ceilinged at INT_MAX, but that doesn't work on
8541 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8543 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8544 (allocate_vectorlike): Check for ptrdiff_t overflow.
8545 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8546 when a (possibly-narrower) signed value would do just as well.
8547 We prefer using signed arithmetic, to avoid comparison confusion.
8549 * alloc.c: Catch some string size overflows that we were missing.
8550 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8551 for convenience in STRING_BYTES_MAX.
8552 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8553 The definition here is exact; the one in lisp.h was approximate.
8554 (allocate_string_data): Check for string overflow. This catches
8555 some instances we weren't catching before. Also, it catches
8556 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8557 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8558 and ptrdiff_t and EMACS_INT are both 64 bits.
8560 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8561 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8562 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8564 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8566 * alloc.c (Fmake_string): Check for out-of-range init.
8568 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8570 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8572 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8574 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8575 xg_get_default_scrollbar_width.
8577 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8578 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8579 (style_changed_cb): Call update_theme_scrollbar_width and call
8580 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8581 all frames (Bug#8505).
8582 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8583 Call gtk_window_set_resizable if HAVE_GTK3.
8584 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8585 and height if HAVE_GTK3 (Bug#8505).
8586 (scroll_bar_width_for_theme): New variable.
8587 (update_theme_scrollbar_width): New function.
8588 (xg_get_default_scrollbar_width): Move code to
8589 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8590 (xg_initialize): Call update_theme_scrollbar_width.
8592 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8594 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8596 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8598 * frame.c (make_frame): Call other_buffer_safely instead of
8601 * window.c (temp_output_buffer_show): Call display_buffer with
8602 second argument Vtemp_buffer_show_specifiers and reset latter
8603 immediately after the call.
8604 (Vtemp_buffer_show_specifiers): New variable.
8605 (auto_window_vscroll_p, next_screen_context_lines)
8606 (Vscroll_preserve_screen_position): Remove leading asterisks from
8609 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8611 Fix minor problems found by GCC 4.6.0 static checking.
8612 * buffer.c (Qclone_number): Remove for now, as it's unused.
8613 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8614 (record_buffer): Remove unused local.
8615 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8616 (set_frame_buffer_list): Remove; unused.
8617 * frame.h (other_visible_frames): Remove decl.
8618 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8619 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8620 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8622 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8623 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8624 Define only if HAVE_GPM.
8625 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8626 (update_hints_inhibit): Remove; never set. All uses removed.
8627 * widgetprv.h (emacsFrameClassRec): Remove decl.
8628 * window.c (delete_deletable_window): Now returns void, since it
8629 wasn't returning anything.
8630 (compare_window_configurations): Remove unused locals.
8631 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8632 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8633 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8634 the same widths as pointers. This follows up on the 2011-05-06 patch.
8635 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8636 * xterm.h: Likewise.
8637 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8639 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8641 * makefile.w32-in: Update dependencies.
8642 (LISP_H): Add lib/intprops.h.
8644 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8646 * image.c (gif_load): Add animation frame delay to the metadata.
8647 (syms_of_image): Use DEFSYM. New symbol `delay'.
8649 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8651 * window.c (delete_deletable_window): Re-add.
8652 (Fset_window_configuration): Rewrite to handle dead buffers and
8653 consequently deletable windows.
8654 (window_tree, Fwindow_tree): Remove. Supply functionality in
8656 (compare_window_configurations): Simplify code.
8658 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8660 * image.c (imagemagick_load_image): Fix type mismatch.
8661 (Fimagemagick_types): Likewise.
8663 * window.h (replace_buffer_in_windows): Declare.
8665 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8667 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8668 Qclone_number. Remove external declaration of Qdelete_window.
8669 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8671 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8672 Run Qbuffer_list_update_hook if allowed.
8673 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8674 buffer list implementation.
8675 (other_buffer_safely): New function.
8676 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8677 calls to replace_buffer_in_windows and
8678 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8680 (record_buffer): Inhibit quitting and rewrite using quittable
8681 functions. Run Qbuffer_list_update_hook if allowed.
8682 (Frecord_buffer, Funrecord_buffer): New functions.
8683 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8684 Move switch-to-buffer to window.el.
8685 (bury-buffer): Move to window.el.
8686 (Vbuffer_list_update_hook): New variable.
8688 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8691 * window.h (resize_frame_windows): Move up in code.
8692 (Fwindow_frame): Remove EXFUN.
8693 (replace_buffer_in_all_windows): Remove prototype.
8694 (replace_buffer_in_windows_safely): Add prototype.
8696 * window.c: Declare Qdelete_window static again. Move down
8697 declaration of select_count.
8698 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8699 (Fother_window): Move to window.el.
8700 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8701 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8702 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8704 (replace_buffer_in_windows): Implement by calling
8705 Qreplace_buffer_in_windows.
8706 (replace_buffer_in_all_windows): Remove with some functionality
8707 moved into replace_buffer_in_windows_safely.
8708 (replace_buffer_in_windows_safely): New function.
8709 (select_window_norecord, select_frame_norecord): Move in front
8710 of run_window_configuration_change_hook. Remove now obsolete
8712 (Fset_window_buffer): Rewrite doc-string.
8713 Call Qrecord_window_buffer.
8714 (keys_of_window): Move binding for other-window to window.el.
8716 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8718 * dispextern.h (struct image): Replace data member, whose int_val
8719 and ptr_val fields were not used by anything, with a single
8722 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8723 (gif_clear_image, gif_load, imagemagick_load_image)
8724 (gs_clear_image, gs_load): Callers changed.
8726 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8728 * buffer.h: Include <time.h>, for time_t.
8729 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8731 Fix minor problems found by static checking.
8733 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8735 Make identifiers static if they are not used in other modules.
8736 * data.c (Qcompiled_function, Qframe, Qvector):
8737 * image.c (QimageMagick, Qsvg):
8738 * minibuf.c (Qmetadata):
8739 * window.c (resize_window_check, resize_root_window): Now static.
8740 * window.h (resize_window_check, resize_root_window): Remove decls.
8742 * window.c (window_deletion_count, delete_deletable_window):
8744 (window_body_lines): Now static.
8745 (Fdelete_other_windows_internal): Mark vars as initialized.
8746 Make sure 'resize_failed' is initialized.
8747 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8748 (resize_window_apply): Remove unused local.
8749 * window.h (delete_deletable_window): Remove decl.
8751 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8752 (imagemagick_load_image): Fix pointer signedness problem by changing
8753 last arg from unsigned char * to char *. All uses changed.
8754 Also, fix a local for similar reasons.
8755 Remove unused locals. Remove locals to avoid shadowing.
8756 (fn_rsvg_handle_free): Remove; unused.
8757 (svg_load, svg_load_image): Fix pointer signedness problem.
8758 (imagemagick_load_image): Don't use garbage pointer image_wand.
8760 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8762 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8764 * image.c (gif_load): Fix omitted cast error introduced by
8767 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8769 * window.h (resize_proportionally, orig_total_lines)
8770 (orig_top_line): Remove from window structure.
8771 (set_window_height, set_window_width, change_window_heights)
8772 (Fdelete_window): Remove prototypes.
8773 (resize_frame_windows): Remove duplicate declaration.
8775 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8777 * window.h (resize_frame_windows, resize_window_check)
8778 (delete_deletable_window, resize_root_window)
8779 (resize_frame_windows): Declare prototypes.
8781 * window.c (resize_window_apply): Make definition be "static" to
8782 match the prototype.
8784 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8786 * window.c: Remove declarations of Qwindow_size_fixed,
8787 window_min_size_1, window_min_size_2, window_min_size,
8788 size_window, window_fixed_size_p, enlarge_window, delete_window.
8789 Remove static from declaration of Qdelete_window, it's
8790 temporarily needed by Fbury_buffer.
8791 (replace_window): Don't assign orig_top_line and
8793 (Fdelete_window, delete_window): Remove. Window deletion is
8794 handled by window.el.
8795 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8796 Replace Fdelete_window calls with calls to Qdelete_window.
8797 (Fdelete_other_windows): Remove. Deleting other windows is
8798 handled by window.el.
8799 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8800 handled in window.el.
8801 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8802 Window minimum sizes are handled in window.el.
8803 (shrink_windows, size_window, set_window_height)
8804 (set_window_width, change_window_heights, window_height)
8805 (window_width, CURBEG, CURSIZE, enlarge_window)
8806 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8807 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8808 handled in window.el.
8809 (make_dummy_parent): Rename to make_parent_window and give it a
8810 second argument horflag.
8811 (make_window): Don't set resize_proportionally any more.
8812 (Fsplit_window): Remove. Windows are split in window.el.
8813 (save_restore_action, save_restore_orig_size)
8814 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8815 Resize mini windows in window.el.
8816 (grow_mini_window, shrink_mini_window): Implement by calling
8817 Qresize_root_window_vertically, resize_window_check and
8818 resize_window_apply.
8819 (saved_window, Fset_window_configuration, save_window_save):
8820 Do not handle orig_top_line, orig_total_lines, and
8821 resize_proportionally.
8822 (window_min_height, window_min_width): Move to window.el.
8823 (keys_of_window): Move bindings for delete-other-windows,
8824 split-window, delete-window and enlarge-window to window.el.
8826 * buffer.c: Temporarily extern Qdelete_window.
8827 (Fbury_buffer): Temporarily call Qdelete_window instead of
8828 Fdelete_window (Fbury_buffer will move to window.el soon).
8830 * frame.c (set_menu_bar_lines_1): Remove code handling
8831 orig_top_line and orig_total_lines.
8833 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8834 set_window_height but set heights directly.
8835 (change_frame_size_1): Use resize_frame_windows.
8837 * xdisp.c (init_xdisp): Don't use set_window_height but set
8840 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8841 Use resize_frame_windows instead of change_window_heights and run
8842 run_window_configuration_change_hook.
8844 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8845 instead of change_window_heights and run
8846 run_window_configuration_change_hook.
8848 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8850 * window.c (replace_window): Rename second argument REPLACEMENT to
8851 NEW. New third argument SETFLAG. Rewrite.
8852 (delete_window, make_dummy_parent): Call replace_window with
8854 (window_list_1): Move down in code.
8855 (run_window_configuration_change_hook): Move set_buffer part
8856 before select_frame_norecord part in order to unwind correctly.
8857 Rename count1 to count.
8858 (recombine_windows, delete_deletable_window, resize_root_window)
8859 (Fdelete_other_windows_internal)
8860 (Frun_window_configuration_change_hook, make_parent_window)
8861 (resize_window_check, resize_window_apply, Fresize_window_apply)
8862 (resize_frame_windows, Fsplit_window_internal)
8863 (Fdelete_window_internal, Fresize_mini_window_internal):
8865 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8867 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8869 * window.h (window): Add some new members to window structure -
8870 normal_lines, normal_cols, new_total, new_normal, clone_number,
8871 splits, nest, prev_buffers, next_buffers.
8872 (WINDOW_TOTAL_SIZE): Move here from window.c.
8873 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8875 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8877 (make_dummy_parent): Set new members of windows structure.
8878 (make_window): Move down in code. Handle new members of window
8880 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8881 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8882 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8883 (Fset_window_prev_buffers, Fwindow_next_buffers)
8884 (Fset_window_next_buffers, Fset_window_clone_number):
8886 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8887 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8889 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8890 Argument WINDOW can be now internal window too.
8891 (Fwindow_use_time): Move up in code.
8892 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8894 (Fset_window_configuration, saved_window)
8895 (Fcurrent_window_configuration, save_window_save): Handle new
8896 members of window structure.
8897 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8898 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8899 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8900 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8901 Qget_mru_window, Qresize_root_window,
8902 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8903 Qauto_buffer_name; staticpro them.
8905 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8907 * window.c (Fwindow_total_size, Fwindow_left_column)
8908 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8909 (Fwindow_list_1): New functions.
8910 (window_box_text_cols): Replace with window_body_cols.
8911 (Fwindow_width, Fscroll_left, Fscroll_right):
8912 Use window_body_cols instead of window_box_text_cols.
8913 (delete_window, Fset_window_configuration):
8914 Call delete_all_subwindows with window as argument.
8915 (delete_all_subwindows): Take a window as argument and not a
8917 (window_loop): Remove handling of GET_LRU_WINDOW and
8919 (Fget_lru_window, Fget_largest_window): Move to window.el.
8921 * window.h: Extern window_body_cols instead of
8922 window_box_text_cols. delete_all_subwindows now takes a
8923 Lisp_Object as argument.
8925 * indent.c (compute_motion, Fcompute_motion):
8926 Use window_body_cols instead of window_box_text_cols.
8928 * frame.c (delete_frame): Call delete_all_subwindows with root
8931 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8933 * fns.c (Fputhash): Document return value.
8935 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8937 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8939 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8941 Cons<->int and similar integer overflow fixes (Bug#8794).
8943 Check for overflow when converting integer to cons and back.
8944 * charset.c (Fdefine_charset_internal, Fdecode_char):
8945 Use cons_to_unsigned to catch overflow.
8946 (Fencode_char): Use INTEGER_TO_CONS.
8947 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8948 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8949 * data.c (long_to_cons, cons_to_long): Remove.
8950 (cons_to_unsigned, cons_to_signed): New functions.
8951 These signal an error for invalid or out-of-range values.
8952 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8953 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8954 * font.c (Ffont_variation_glyphs):
8955 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8956 * lisp.h: Include <intprops.h>.
8957 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8958 (cons_to_signed, cons_to_unsigned): New decls.
8959 (long_to_cons, cons_to_long): Remove decls.
8960 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8961 (Fprimitive_undo): Use CONS_TO_INTEGER.
8962 * xfns.c (Fx_window_property): Likewise.
8963 * xselect.c: Include <limits.h>.
8964 (x_own_selection, selection_data_to_lisp_data):
8965 Use INTEGER_TO_CONS.
8966 (x_handle_selection_request, x_handle_selection_clear)
8967 (x_get_foreign_selection, Fx_disown_selection_internal)
8968 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8969 (lisp_data_to_selection_data): Use cons_to_unsigned.
8970 (x_fill_property_data): Use cons_to_signed.
8971 Report values out of range.
8973 Check for buffer and string overflow more precisely.
8974 * buffer.h (BUF_BYTES_MAX): New macro.
8975 * lisp.h (STRING_BYTES_MAX): New macro.
8976 * alloc.c (Fmake_string):
8977 * character.c (string_escape_byte8):
8978 * coding.c (coding_alloc_by_realloc):
8979 * doprnt.c (doprnt):
8980 * editfns.c (Fformat):
8982 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8983 since they may not be the same number.
8984 * editfns.c (Finsert_char):
8985 * fileio.c (Finsert_file_contents):
8986 Likewise for BUF_BYTES_MAX.
8988 * image.c: Use ptrdiff_t, not int, for sizes.
8989 (slurp_file): Switch from int to ptrdiff_t.
8991 (slurp_file): Check that file size fits in both size_t (for
8992 malloc) and ptrdiff_t (for sanity and safety).
8994 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8995 if b->modtime has its maximal value.
8997 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8999 Don't assume time_t can fit into int.
9000 * buffer.h (struct buffer.modtime): Now time_t, not int.
9001 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9002 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9004 Minor fixes for signed vs unsigned integers.
9005 * character.h (MAYBE_UNIFY_CHAR):
9006 * charset.c (maybe_unify_char):
9007 * keyboard.c (read_char, reorder_modifiers):
9008 XINT -> XFASTINT, since the integer must be nonnegative.
9009 * ftfont.c (ftfont_spec_pattern):
9010 * keymap.c (access_keymap, silly_event_symbol_error):
9011 XUINT -> XFASTINT, since the integer must be nonnegative.
9012 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9013 since it makes no difference and we prefer signed.
9014 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9015 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9018 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9020 * window.h (Fwindow_frame): Declare.
9022 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9024 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9025 (SPARE_MEMORY): Always define.
9026 (LARGE_REQUEST): Remove.
9027 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9029 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9031 * lisp.h: Move EXFUNS for Fframe_root_window,
9032 Fframe_first_window and Fset_frame_selected_window to window.h.
9034 * window.h: Move EXFUNS for Fframe_root_window,
9035 Fframe_first_window and Fset_frame_selected_window here from
9038 * frame.c (Fwindow_frame, Fframe_first_window)
9039 (Fframe_root_window, Fframe_selected_window)
9040 (Fset_frame_selected_window): Move to window.c.
9041 (Factive_minibuffer_window): Move to minibuf.c.
9042 (Fother_visible_frames_p): New function.
9044 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9046 * window.c (decode_window, decode_any_window): Move up in code.
9047 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9048 (inhibit_frame_unsplittable): Remove unused variable.
9049 (Fwindow_buffer): Move up and rewrite doc-string.
9050 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9051 (Fwindow_prev): New functions.
9052 (Fwindow_frame): Move here from frame.c. Accept any window as
9054 (Fframe_root_window, Fframe_first_window)
9055 (Fframe_selected_window): Move here from frame.c. Accept frame
9056 or arbitrary window as argument. Update doc-strings.
9057 (Fminibuffer_window): Move up in code.
9058 (Fwindow_minibuffer_p): Move up in code and simplify.
9059 (Fset_frame_selected_window): Move here from frame.c.
9061 (Fselected_window, select_window, Fselect_window): Move up in
9062 code. Minor doc-string fixes.
9064 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9066 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9067 Do not assume that spare memory exists; that assumption is valid
9068 only if SYSTEM_MALLOC.
9069 (LARGE_REQUEST): New macro, so that the issue of large requests
9070 is separated from the issue of spare memory.
9072 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9074 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9077 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9079 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9082 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9084 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9086 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9088 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9089 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9091 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9093 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9095 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9097 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9098 (x_clipboard_manager_save): Add return value.
9099 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9101 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9102 Obey Vx_select_enable_clipboard_manager. Catch errors in
9103 x_clipboard_manager_save (Bug#8779).
9104 (Vx_select_enable_clipboard_manager): New variable.
9105 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9107 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9109 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9111 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9113 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9114 in the current matrix if keep_current_p is non-zero.
9116 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9118 * bidi.c (bidi_level_of_next_char): Fix last change.
9120 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9122 Support bidi reordering of text covered by display properties.
9124 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9125 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9126 (bidi_cache_search, bidi_cache_iterator_state)
9127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9128 (bidi_level_of_next_char, bidi_move_to_visually_next):
9129 Support character positions inside a run of characters covered by a
9131 (bidi_paragraph_init, bidi_resolve_explicit_1)
9132 (bidi_level_of_next_char): Call bidi_fetch_char and
9133 bidi_fetch_char_advance instead of FETCH_CHAR and
9135 (bidi_init_it): Initialize new members.
9136 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9138 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9139 instead of using explicit *_CHAR codes.
9140 (bidi_resolve_explicit, bidi_resolve_weak):
9141 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9142 bidirectional text is supported only in multibyte buffers.
9143 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9144 it to initialize the frame_window_p member of struct bidi_it.
9145 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9146 (bidi_resolve_explicit, bidi_resolve_weak)
9147 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9148 bidi_it->nchars is non-positive.
9149 (bidi_level_of_next_char): Don't try to lookup the cache for the
9150 next/previous character if nothing is cached there yet, or if we
9151 were just reseat()'ed to a new position.
9153 * xdisp.c (set_cursor_from_row): Set start and stop points
9154 according to the row's direction when priming the loop that looks
9155 for the glyph on which to display cursor.
9156 (single_display_spec_intangible_p): Function deleted.
9157 (display_prop_intangible_p): Reimplement to call
9158 handle_display_spec instead of single_display_spec_intangible_p.
9159 Accept 3 additional arguments needed by handle_display_spec.
9160 This fixes incorrect cursor motion across display property with complex
9161 values: lists, `(when COND...)' forms, etc.
9162 (single_display_spec_string_p): Support property values that are
9163 lists with the argument STRING its top-level element.
9164 (display_prop_string_p): Fix the condition for processing a
9165 property that is a list to be consistent with handle_display_spec.
9166 (handle_display_spec): New function, refactored from the
9167 last portion of handle_display_prop.
9168 (compute_display_string_pos): Accept additional argument
9169 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9170 value of a `display' property is a "replacing spec".
9171 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9172 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9173 the display property, but just return a value indicating whether
9174 the display property will replace the characters it covers.
9175 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9176 frame_window_p members of struct bidi_it.
9177 (compute_display_string_pos, compute_display_string_end):
9179 (push_it): Accept second argument POSITION, where pop_it should
9180 jump to continue iteration.
9181 (reseat_1): Initialize bidi_it.disp_pos.
9183 * keyboard.c (adjust_point_for_property): Adjust the call to
9184 display_prop_intangible_p to its new signature.
9186 * dispextern.h (struct bidi_it): New member frame_window_p.
9187 (bidi_init_it): Update prototypes.
9188 (display_prop_intangible_p): Update prototype.
9189 (compute_display_string_pos, compute_display_string_end):
9191 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9194 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9196 Malloc failure behavior now depends on size of allocation.
9197 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9198 * lisp.h: Change signatures accordingly.
9199 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9200 All callers changed. (Bug#8762)
9202 * gnutls.c: Use Emacs's memory allocators.
9203 Without this change, the gnutls library would invoke malloc etc.
9204 directly, which causes problems on non-SYNC_INPUT hosts, and which
9205 runs afoul of improving memory_full behavior. (Bug#8761)
9206 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9207 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9208 xfree instead of the default malloc, realloc, free.
9209 (Fgnutls_boot): No need to check for memory allocation failure,
9210 since xmalloc does that for us.
9212 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9213 * category.c (hash_get_category_set):
9214 * ccl.c (ccl_driver):
9215 * charset.c (Fdefine_charset_internal):
9216 * charset.h (struct charset.hash_index):
9217 * composite.c (get_composition_id, gstring_lookup_cache)
9218 (composition_gstring_put_cache):
9219 * composite.h (struct composition.hash_index):
9220 * dispextern.h (struct image.hash):
9221 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9222 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9223 (hashfn_equal, hashfn_user_defined, make_hash_table)
9224 (maybe_resize_hash_table, hash_lookup, hash_put)
9225 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9227 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9228 * image.c (make_image, search_image_cache, lookup_image)
9229 (xpm_put_color_table_h):
9230 * lisp.h (struct Lisp_Hash_Table):
9231 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9232 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9233 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9234 * alloc.c (allocate_vectorlike):
9235 Check for overflow in vector size calculations.
9236 * ccl.c (ccl_driver):
9237 Check for overflow when converting EMACS_INT to int.
9238 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9239 need to be updated by these changes.
9240 * fns.c (make_hash_table, maybe_resize_hash_table):
9241 Check for integer overflow with large hash tables.
9242 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9243 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9244 (SXHASH_REDUCE): New macro.
9245 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9246 Use it instead of discarding useful hash info with large hash values.
9247 (sxhash_float): New function.
9248 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9249 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9250 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9251 Rewrite to use FIXNUM_BITS, as this simplifies things.
9252 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9253 Adjust signatures to match updated version of code.
9254 (consing_since_gc): Now EMACS_INT, since a single hash table can
9255 use more than INT_MAX bytes.
9257 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9259 Make it possible to build with GCC-4.6+ -O2 -flto.
9261 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9263 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9265 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9266 Call minibuffer-inactive-mode.
9268 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9270 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9271 Update dependencies.
9273 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9275 * data.c (init_data): Remove code for UTS, this system is not
9278 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9280 Don't force ./temacs to start in terminal mode.
9282 * frame.c (make_initial_frame): Initialize faces in all cases, not
9283 only when CANNOT_DUMP is defined.
9284 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9286 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9288 * dispnew.c (add_window_display_history): Use const for the string
9289 pointer. Remove declaration, not needed.
9291 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9293 Use 'inline', not 'INLINE'.
9294 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9295 * alloc.c, fontset.c (INLINE): Remove.
9296 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9297 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9298 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9299 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9300 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9302 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9304 Make it possible to run ./temacs.
9306 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9307 syms_of_callproc does the same thing. Remove test for
9308 "initialized", do it in the caller.
9309 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9311 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9313 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9314 (read_minibuf): Use get_minibuffer.
9315 (syms_of_minibuf): Use DEFSYM.
9316 (Qmetadata): New var.
9317 * data.c (Qbuffer): Don't make it static.
9318 (syms_of_data): Use DEFSYM.
9320 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9322 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9323 (CCL_CODE_MIN): New macro.
9325 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9327 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9329 * eval.c (Qdebug): Now static.
9330 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9331 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9332 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9334 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9336 * image.c: Various fixes to ImageMagick code comments.
9337 (Fimagemagick_types): Doc fix.
9339 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9341 Minor fixes prompted by GCC 4.6.0 warnings.
9343 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9345 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9346 (x_clipboard_manager_save_all): Move extern decl to ...
9347 * xterm.h: ... here, so that it can be checked for consistency.
9349 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9351 * xselect.c (x_clipboard_manager_save_frame)
9352 (x_clipboard_manager_save_all): New functions.
9353 (Fx_clipboard_manager_save): Lisp function deleted.
9355 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9356 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9358 * xterm.h: Update prototype.
9360 2011-05-28 William Xu <william.xwl@gmail.com>
9362 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9365 2011-05-28 Jim Meyering <meyering@redhat.com>
9367 Avoid a sign-extension bug in crypto_hash_function.
9368 * fns.c (to_uchar): Define.
9369 (crypto_hash_function): Use it to convert some newly-signed
9370 variables to unsigned, to avoid sign-extension bugs. For example,
9371 without this change, (md5 "truc") would evaluate to
9372 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9373 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9374 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9376 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9378 Integer overflow fixes.
9380 * dbusbind.c: Serial number integer overflow fixes.
9381 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9382 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9383 to hold a serial number that is too large for a fixnum.
9384 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9385 Check for serial numbers out of range. Decode any serial number
9386 that was so large that it became a float. (Bug#8722)
9388 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9389 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9390 Use XFASTINT rather than XUINT when numbers are nonnegative.
9391 (xd_append_arg, Fdbus_method_return_internal):
9392 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9393 arguments, check that Lisp number is nonnegative, rather than
9394 silently wrapping negative numbers around. (Bug#8722)
9395 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9398 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9400 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9402 ccl: Add integer overflow checks.
9403 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9404 (IN_INT_RANGE): New macros.
9405 (ccl_driver): Use them to check for integer overflow when
9406 decoding a CCL program. Many of the new checks are whether XINT (x)
9407 fits in int; it doesn't always, on 64-bit hosts. The new version
9408 doesn't catch all possible integer overflows, but it's an
9409 improvement. (Bug#8719)
9411 * alloc.c (make_event_array): Use XINT, not XUINT.
9412 There's no need for unsigned here.
9414 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9415 This follows up to the 2011-05-06 change that substituted uintptr_t
9416 for EMACS_INT. This case wasn't caught back then.
9418 Rework Fformat to avoid integer overflow issues.
9419 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9420 now (part of C89). Include <verify.h>.
9421 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9422 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9423 (Fformat): Avoid the prepass trying to compute sizes; it was only
9424 approximate and thus did not catch overflow reliably. Instead, walk
9425 through the format just once, formatting and computing sizes as we go,
9426 checking for integer overflow at every step, and allocating a larger
9427 buffer as needed. Keep track separately whether the format is
9428 multibyte. Keep only the most-recently calculated precision, rather
9429 than them all. Record whether each argument has been converted to
9430 string. Use EMACS_INT, not int, for byte and char and arg counts.
9431 Support field widths and precisions larger than INT_MAX. Avoid
9432 sprintf's undefined behavior with conversion specifications such as %#d
9433 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9434 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9435 formatting out-of-range floating point numbers with int
9438 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9440 * data.c: Avoid integer truncation in expressions involving floats.
9441 * data.c: Include <intprops.h>.
9442 (arith_driver): When there's an integer overflow in an expression
9443 involving floating point, convert the integers to floating point
9444 so that the resulting value does not suffer from catastrophic
9445 integer truncation. For example, on a 64-bit host (* 4
9446 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9447 Do not rely on undefined behavior after integer overflow.
9449 merge count_size_as_multibyte, parse_str_to_multibyte
9450 * character.c, character.h (count_size_as_multibyte):
9451 Rename from parse_str_to_multibyte; all uses changed.
9452 Check for integer overflow.
9453 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9454 since it's now a duplicate of the other. This is more of
9455 a character than a buffer op, so better that it's in character.c.
9456 * fns.c, print.c: Adjust to above changes.
9458 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9460 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9462 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9464 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9465 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9466 (x_clipboard_manager_save): Now static.
9467 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9469 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9470 (crypto_hash_function): Now static.
9471 Fix pointer signedness problems. Avoid unnecessary initializations.
9473 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9475 * termhooks.h (Vselection_alist): Make it terminal-local.
9477 * terminal.c (create_terminal): Initialize it.
9479 * xselect.c: Support for clipboard managers.
9480 (Vselection_alist): Move to termhooks.h as terminal-local var.
9481 (LOCAL_SELECTION): New macro.
9482 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9483 (symbol_to_x_atom): Remove gratuitous arg.
9484 (x_handle_selection_request, lisp_data_to_selection_data)
9485 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9486 (x_own_selection, x_get_local_selection, x_convert_selection):
9487 New arg, specifying work frame. Use terminal-local Vselection_alist.
9488 (some_frame_on_display): Delete unused function.
9489 (Fx_own_selection_internal, Fx_get_selection_internal)
9490 (Fx_disown_selection_internal, Fx_selection_owner_p)
9491 (Fx_selection_exists_p): New optional frame arg.
9492 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9493 (x_handle_selection_clear): Don't treat other terminals with the
9494 same keyboard specially. Use the terminal-local Vselection_alist.
9495 (x_clear_frame_selections): Use Frun_hook_with_args.
9497 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9499 * xterm.h: Add support for those atoms.
9501 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9503 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9504 (converted_selections, conversion_fail_tag): New global variables.
9505 (x_selection_request_lisp_error): Free the above.
9506 (x_get_local_selection): Remove unnecessary code.
9507 (x_reply_selection_request): Args changed; handle arbitrary array
9508 of converted selections stored in converted_selections.
9509 Separate the XChangeProperty and SelectionNotify steps.
9510 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9511 (x_convert_selection): New function.
9512 (x_handle_selection_event): Simplify.
9513 (x_get_foreign_selection): Don't ignore incoming requests while
9514 waiting for an answer; this will fail when we implement
9515 SAVE_TARGETS, and seems unnecessary anyway.
9516 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9517 (Vx_sent_selection_functions): Doc fix.
9519 2011-05-26 Leo Liu <sdl.web@gmail.com>
9521 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9523 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9525 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9527 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9528 for fringe update if it has periodic bitmap.
9529 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9530 and fringe_bitmap_periodic_p.
9532 * fringe.c (get_fringe_bitmap_data): New function.
9533 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9534 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9535 row. Mark glyph row for fringe update if periodicity changed.
9537 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9538 for fringe update unless it has periodic bitmap.
9540 2011-05-25 Kenichi Handa <handa@m17n.org>
9542 * xdisp.c (get_next_display_element): Set correct it->face_id for
9543 a static composition.
9545 2011-05-24 Leo Liu <sdl.web@gmail.com>
9548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9550 * fns.c (crypto_hash_function, Fsha1): New function.
9551 (Fmd5): Use crypto_hash_function.
9552 (syms_of_fns): Add Ssha1.
9554 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9556 * gnutls.c: Remove unused macros.
9557 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9558 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9559 Remove macros that are defined and never used.
9560 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9562 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9564 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9565 (Fx_get_selection_internal): Minor cleanup.
9566 (Fx_own_selection_internal): Rename arguments for consistency with
9569 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9571 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9573 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9575 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9577 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9579 * dispnew.c (scrolling_window): Don't exclude the case that the
9580 last enabled row in the desired matrix touches the bottom boundary.
9582 2011-05-21 Glenn Morris <rgm@gnu.org>
9584 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9585 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9586 and add some more files.
9588 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9590 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9591 report_file_error introduced by the change from 2011-05-07.
9593 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9595 * systime.h (Time): Define only if emacs is defined.
9596 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9597 where the include path doesn't have X11/X.h by default. See
9598 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9600 2011-05-20 Kenichi Handa <handa@m17n.org>
9602 * composite.c (find_automatic_composition): Fix previous change.
9604 2011-05-20 Glenn Morris <rgm@gnu.org>
9606 * lisp.mk: New file, split from Makefile.in.
9607 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9608 (shortlisp): Remove.
9609 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9611 2011-05-19 Glenn Morris <rgm@gnu.org>
9613 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9614 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9615 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9616 (lisp): Set the order to that of loadup.el.
9617 (shortlisp): Make it a copy of $lisp.
9618 (SOME_MACHINE_LISP): Remove.
9619 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9620 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9622 2011-05-18 Kenichi Handa <handa@m17n.org>
9624 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9625 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9626 (find_automatic_composition): Mostly rewrite for efficiency.
9628 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9630 * makefile.w32-in: Update dependencies.
9632 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9634 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9635 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9637 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9639 Fix some integer overflow issues, such as string length overflow.
9641 * insdel.c (count_size_as_multibyte): Check for string overflow.
9643 * character.c (lisp_string_width): Check for string overflow.
9644 Use EMACS_INT, not int, for string indexes and lengths; in
9645 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9646 the resulting string length overflows an EMACS_INT; instead,
9647 report a string overflow if no precision given. When checking for
9648 precision exhaustion, use a check that cannot possibly have
9649 integer overflow. (Bug#8675)
9650 * character.h (lisp_string_width): Adjust to new signature.
9652 * alloc.c (string_overflow): New function.
9653 (Fmake_string): Use it. This doesn't change behavior, but saves
9654 a few bytes and will simplify future changes.
9655 * character.c (string_escape_byte8): Likewise.
9656 * lisp.h (string_overflow): New decl.
9658 Fixups, following up to the user-interface timestamp change.
9659 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9660 for UI timestamps, instead of unsigned long.
9661 * msdos.c (mouse_get_pos): Likewise.
9662 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9663 * w32gui.h (Time): Define by including "systime.h" rather than by
9664 declaring it ourselves. (Bug#8664)
9666 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9667 * image.c (clear_image_cache): Likewise.
9669 * term.c (term_mouse_position): Don't assume time_t wraparound.
9671 Be more systematic about user-interface timestamps.
9672 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9673 and sometimes 'EMACS_UINT', to represent these timestamps.
9674 This change causes it to use 'Time' uniformly, as that's what X uses.
9675 This makes the code easier to follow, and makes it easier to catch
9676 integer overflow bugs such as Bug#8664.
9677 * frame.c (Fmouse_position, Fmouse_pixel_position):
9678 Use Time, not unsigned long, for user-interface timestamps.
9679 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9680 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9681 * keyboard.h (last_event_timestamp): Likewise.
9682 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9683 * menu.h (xmenu_show): Likewise.
9684 * term.c (term_mouse_position): Likewise.
9685 * termhooks.h (struct input_event.timestamp): Likewise.
9686 (struct terminal.mouse_position_hook): Likewise.
9687 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9688 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9689 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9690 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9692 * menu.h, termhooks.h: Include "systime.h", for Time.
9694 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9695 Don't assume that the difference between two unsigned long values
9696 can fit into an integer. At this point, we know button_down_time
9697 <= event->timestamp, so the difference must be nonnegative, so
9698 there's no need to cast the result if double-click-time is
9699 nonnegative, as it should be; check that it's nonnegative, just in
9700 case. This bug is triggered when events are more than 2**31 ms
9701 apart (about 25 days). (Bug#8664)
9703 * xselect.c (last_event_timestamp): Remove duplicate decl.
9704 (x_own_selection): Remove needless cast to unsigned long.
9706 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9707 that always fit in int. Use a sentinel instead of a counter, to
9708 avoid a temp and to allay GCC's concerns about possible int overflow.
9709 * frame.h (struct frame): Use int for menu_bar_items_used
9710 instead of EMACS_INT, since it always fits in int.
9712 * menu.c (grow_menu_items): Check for int overflow.
9714 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9716 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9717 Before, the code was not consistent. These values cannot exceed
9718 2**31 - 1 so there's no need to make them unsigned.
9719 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9720 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9721 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9723 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9725 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9726 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9727 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9728 presumably because the widths might not match.
9730 * window.c (size_window): Avoid needless test at loop start.
9732 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9734 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9736 2011-05-12 Drew Adams <drew.adams@oracle.com>
9738 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9740 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9742 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9743 `width' to `bar_area_x' and `bar_area_width', respectively.
9744 (x_scroll_run): Take account of fringe background extension.
9746 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9747 Rename local vars `left' and `width' to `bar_area_x' and
9748 `bar_area_width', respectively.
9749 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9750 background extension.
9752 2011-05-10 Jim Meyering <meyering@redhat.com>
9754 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9756 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9758 * image.c (Finit_image_library): Return t for built-in image types,
9759 like pbm and xbm. (Bug#8640)
9761 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9763 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9765 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9767 * w32console.c (Fset_screen_color): Doc fix.
9768 (Fget_screen_color): New function.
9769 (syms_of_ntterm): Defsubr it.
9771 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9772 unlink the temporary file if Fcall_process didn't create it in the
9774 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9775 child process will be redirected to a file specified with `:file'.
9776 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9777 cue to call_process_cleanup not to close that handle.
9779 2011-05-07 Ben Key <bkey76@gmail.com>
9781 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9782 one of two shell specific rules, either bootstrap-temacs-CMD or
9783 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9784 to the previous implementation of the bootstrap-temacs rule.
9785 The bootstrap-temacs-CMD rule is similar to the previous
9786 implementation of the bootstrap-temacs rule except that it
9787 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9790 These changes, along with some changes to nt/configure.bat,
9791 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9792 earlier fix to add support for --cflags and --ldflags options
9793 that include quotes so that it works whether make uses cmd or
9796 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9798 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9799 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9801 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9802 a string. Handle both cases.
9803 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9804 (Fdbus_register_method): Use Qinvalid_function.
9806 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9808 * makefile.w32-in: Update dependencies.
9809 (LISP_H): Add inttypes.h and stdin.h.
9810 (PROCESS_H): Add unistd.h.
9812 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9814 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9815 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9817 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9819 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9821 * term.c (vfatal): Remove stray call to va_end.
9822 It's not needed and the C Standard doesn't allow it here anyway.
9824 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9825 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9827 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9830 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9834 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9836 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9838 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9840 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9841 * charset.c (Fdefine_charset_internal): Don't initialize
9842 charset.code_space[15]. The value was garbage, on hosts with
9843 32-bit int (Bug#8600).
9845 * lread.c (read_integer): Be more consistent with string-to-number.
9846 Use string_to_number to do the actual conversion; this avoids
9847 rounding errors and fixes some other screwups. Without this fix,
9848 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9849 (digit_to_number): Move earlier, for benefit of read_integer.
9850 Return -1 if the digit is out of range for the base, -2 if it is
9851 not a digit in any supported base. (Bug#8602)
9853 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9855 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9856 to match comment at start of function. This also removes a
9857 GCC warning about overflow in a 32+64-bit port.
9859 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9861 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9862 Reported by Stefan Monnier in
9863 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9864 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9865 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9867 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9868 (EMACS_UINTPTR): Likewise, with uintptr_t.
9870 * lisp.h: Prefer 64-bit EMACS_INT if available.
9871 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9872 on 32-bit hosts that have 64-bit int, so that they can access
9874 However, temporarily disable this change unless the temporary
9875 symbol WIDE_EMACS_INT is defined.
9877 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9879 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9880 This removes an assumption that EMACS_INT and long are the same
9881 width as pointers. The assumption is true for Emacs porting targets
9882 now, but we want to make other targets possible.
9883 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9884 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9885 In the rest of the code, change types of integers that hold casted
9886 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9887 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9888 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9889 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9890 No need to cast type when ORing.
9891 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9892 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9893 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9894 assume EMACS_INT is the same width as char *.
9895 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9896 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9897 Remove no-longer-needed casts.
9898 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9899 (xg_tool_bar_help_callback, xg_make_tool_item):
9900 Use EMACS_INTPTR to hold an integer
9901 that will be cast to void *; this can avoid a GCC warning
9902 if EMACS_INT is not the same width as void *.
9903 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9904 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9905 (current_message_1, set_message_1):
9906 Use a local to convert to proper width without a cast.
9907 * xmenu.c (dialog_selection_callback): Likewise.
9909 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9910 Also, don't assume VALBITS / RAND_BITS is less than 5,
9911 and don't rely on undefined behavior when shifting a 1 left into
9913 * lisp.h (get_random): Change signature to match.
9915 * lread.c (hash_string): Use size_t, not int, for hash computation.
9916 Normally we prefer signed values; but hashing is special, because
9917 it's better to use unsigned division on hash table sizes so that
9918 the remainder is nonnegative. Also, size_t is the natural width
9919 for hashing into memory. The previous code used 'int', which doesn't
9920 retain enough info to hash well into very large tables.
9921 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9923 * dbusbind.c: Don't possibly lose pointer info when converting.
9924 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9925 Use XPNTR rather than XHASH, so that the high-order bits of
9926 the pointer aren't lost when converting through void *.
9928 * eval.c (Fautoload): Don't double-shift a pointer.
9930 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9932 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9934 * gnutls.c (DEF_GNUTLS_FN):
9935 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9937 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9939 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9942 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9944 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9945 New version that can reserve upto 2GB of heap space.
9947 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9949 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9951 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9953 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9954 `gnutls_certificate_set_x509_key_file'.
9956 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9958 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9959 Update dependencies.
9961 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9963 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9964 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9965 Remove unused parameter `fildes'.
9966 * process.c (read_process_output, send_process): Don't pass it.
9968 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9970 Fix previous change: the library cache is defined in w32.c.
9971 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9972 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9974 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9976 Implement dynamic loading of GnuTLS on Windows.
9978 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9979 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9983 * gnutls.c (Qgnutls_dll): Define.
9984 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9985 (gnutls_*): Declare function pointers.
9986 (init_gnutls_functions): New function to initialize function pointers.
9987 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9988 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9990 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9991 (emacs_gnutls_write, emacs_gnutls_read)
9992 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9993 (Fgnutls_available_p): New function.
9994 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9995 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9996 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9998 * image.c: Include w32.h.
9999 (Vimage_type_cache): Delete.
10000 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10001 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10002 (w32_delayed_load): Move to w32.c.
10004 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10006 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10007 (w32_delayed_load): Move from image.c. When loading a library, record
10008 its filename in the :loaded-from property of the library id.
10009 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10010 Initialize and staticpro them.
10011 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10013 * process.c: Include lisp.h before w32.h, not after.
10014 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10015 instead of gnutls_record_check_pending.
10017 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10019 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10021 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10022 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10025 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10027 * xterm.c (x_set_frame_alpha): Do not set property on anything
10028 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10030 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10032 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10034 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10036 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10037 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10038 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10039 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10040 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10041 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10042 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10043 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10044 (Qgnutls_bootprop_callbacks_verify): Make static.
10046 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10048 * callproc.c: Indentation fixup.
10050 * sysdep.c (wait_for_termination_1): Make static.
10051 (wait_for_termination, interruptible_wait_for_termination):
10052 Move after wait_for_termination_1.
10054 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10056 * sysdep.c (interruptible_wait_for_termination): New function
10057 which is like wait_for_termination, but allows keyboard
10060 * callproc.c (Fcall_process): Add (:file "file") as an option for
10062 (Fcall_process_region): Ditto.
10064 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10066 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10067 rather than `XVECTOR (FOO)->size'.
10069 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10070 inttypes.h, as a gnulib replacement is used if it not available in
10073 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10075 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10076 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10077 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10079 * coding.c (coding_alloc_by_realloc): Error out if destination
10080 will grow beyond MOST_POSITIVE_FIXNUM.
10081 (decode_coding_emacs_mule): Abort if there isn't enough place in
10082 charbuf for the composition carryover bytes. Reserve an extra
10083 space for up to 2 characters produced in a loop.
10084 (decode_coding_iso_2022): Abort if there isn't enough place in
10085 charbuf for the composition carryover bytes.
10087 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10089 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10090 aborting when %lld or %lll format is passed.
10091 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10092 %llo or %llx format is passed. (Bug#8545)
10094 * window.c (window_scroll_line_based): Use a marker instead of
10095 simple variables to record original value of point. (Bug#7952)
10097 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10098 produced by %s or %c overflows available buffer space. (Bug#8545)
10100 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10102 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10103 (SIZE_MAX): Move defn after all includes, as they might #define it.
10105 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10107 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10109 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10111 * keyboard.c (Qdelayed_warnings_hook): Define.
10112 (command_loop_1): Run `delayed-warnings-hook'
10113 if Vdelayed_warnings_list is non-nil.
10114 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10115 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10117 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10119 * doprnt.c (doprnt): Don't return value smaller than the buffer
10120 size if the message was truncated. (Bug#8545).
10122 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10124 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10125 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10127 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10129 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10131 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10133 * makefile.w32-in: Update dependencies.
10135 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10137 Improve `doprnt' and its usage. (Bug#8545)
10138 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10139 `format_end'. Remove support for %l as a conversion specifier.
10140 Don't use xrealloc. Improve diagnostics when the %l size modifier
10141 is used. Update the commentary.
10143 * eval.c (verror): Simplify calculation of size_t.
10145 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10148 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10150 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10153 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10155 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10156 This makes this file independent of the recent pseudovector change.
10158 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10160 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10162 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10163 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10164 Remove unused local.
10165 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10167 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10168 GCC 4.6.0 optimizes based on type-based alias analysis.
10169 For example, if b is of type struct buffer * and v of type struct
10170 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10171 != &v->size, and therefore "v->size = 1; b->size = 2; return
10172 v->size;" must therefore return 1. This assumption is incorrect
10173 for Emacs, since it type-puns struct Lisp_Vector * with many other
10174 types. To fix this problem, this patch adds a new type struct
10175 vectorlike_header that documents the constraints on layout of vectors
10176 and pseudovectors, and helps optimizing compilers not get fooled
10177 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10178 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10179 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10181 (XSETPVECTYPE): Rewrite in terms of new macro.
10182 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10183 This is a bit clearer, and further avoids the possibility of
10184 undesirable aliasing.
10185 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10186 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10187 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10188 since Lisp_Subr is a special case (no "next" field).
10189 (ASIZE): Now uses header.size rather than size.
10190 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10191 to avoid the hassle of writing XVECTOR (foo)->header.size.
10192 (struct vectorlike_header): New type.
10193 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10194 object, to help avoid aliasing.
10195 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10196 (SUBRP): Likewise, since Lisp_Subr is a special case.
10197 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10198 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10199 (struct Lisp_Hash_Table): Combine first two members into a single
10200 struct vectorlike_header member. All uses of "size" and "next" members
10201 changed to be "header.size" and "header.next".
10202 * buffer.h (struct buffer): Likewise.
10203 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10204 * frame.h (struct frame): Likewise.
10205 * process.h (struct Lisp_Process): Likewise.
10206 * termhooks.h (struct terminal): Likewise.
10207 * window.c (struct save_window_data, struct saved_window): Likewise.
10208 * window.h (struct window): Likewise.
10209 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10210 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10211 * buffer.c (init_buffer_once): Likewise.
10212 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10214 * process.c (Fformat_network_address): Use local var for size,
10217 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10219 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10220 * data.c (atof): Remove decl; no longer used or needed.
10221 (digit_to_number): Move to lread.c.
10222 (Fstring_to_number): Use new string_to_number function, to be
10223 consistent with how the Lisp reader treats infinities and NaNs.
10224 Do not assume that floating-point numbers represent EMACS_INT
10225 without losing information; this is not true on most 64-bit hosts.
10226 Avoid double-rounding errors, by insisting on integers when
10227 parsing non-base-10 numbers, as the documentation specifies.
10228 * lisp.h (string_to_number): New decl, replacing ...
10229 (isfloat_string): Remove.
10230 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10231 (read1): Do not accept +. and -. as integers; this
10232 appears to have been a coding error. Similarly, do not accept
10233 strings like +-1e0 as floating point numbers. Do not report
10234 overflow for integer overflows unless the base is not 10 which
10235 means we have no simple and reliable way to continue.
10236 Break out the floating-point parsing into a new
10237 function string_to_number, so that Fstring_to_number parses
10238 floating point numbers consistently with the Lisp reader.
10239 (digit_to_number): Move here from data.c. Make it static inline.
10240 (E_CHAR, EXP_INT): Remove, replacing with ...
10241 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10242 (string_to_number): New function, replacing isfloat_string.
10243 This function checks for valid syntax and produces the resulting
10244 Lisp float number too. Rework it so that string-to-number
10245 no longer mishandles examples like "1.0e+". Use strtoumax,
10246 so that overflow for non-base-10 numbers is reported only when
10247 there's no portable and simple way to convert to floating point.
10249 * textprop.c (set_text_properties_1): Rewrite for clarity,
10250 and to avoid GCC warning about integer overflow.
10252 * intervals.h (struct interval): Use EMACS_INT for members
10253 where EMACS_UINT might cause problems. See
10254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10255 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10256 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10258 (offset_intervals): Tell GCC not to worry about length overflow
10259 when negating a negative length.
10261 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10262 (overrun_check_free): Likewise.
10264 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10265 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10268 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10269 (gnutls_make_error): Rename local to avoid shadowing.
10270 (gnutls_emacs_global_deinit): ifdef out; not used.
10271 (Fgnutls_boot): Use const for pointer to readonly storage.
10272 Comment out unused local. Fix pointer signedness problems.
10274 * lread.c (openp): Don't stuff size_t into an 'int'.
10275 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10276 about possible signed overflow.
10278 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10279 (GDK_KEY_g): Don't define if already defined.
10280 (xg_prepare_tooltip): Avoid pointer signedness problem.
10281 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10283 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10284 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10286 * xfns.c (Fx_window_property): Simplify a bit,
10287 to make a bit faster and to avoid GCC 4.6.0 warning.
10288 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10290 * fns.c (internal_equal): Don't assume size_t fits in int.
10292 * alloc.c (compact_small_strings): Tighten assertion a little.
10294 Replace pEd with more-general pI, and fix some printf arg casts.
10295 * lisp.h (pI): New macro, generalizing old pEd macro to other
10296 conversion specifiers. For example, use "...%"pI"d..." rather
10297 than "...%"pEd"...".
10298 (pEd): Remove. All uses replaced with similar uses of pI.
10299 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10300 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10301 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10302 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10303 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10304 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10305 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10307 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10308 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10309 * print.c (safe_debug_print, print_object): Likewise.
10310 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10312 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10313 avoiding the 0 flag, which is not portable.
10314 * process.c (Fmake_network_process): Use pI to avoid cast.
10315 * region-cache.c (pp_cache): Likewise.
10316 * xdisp.c (decode_mode_spec): Likewise.
10317 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10318 behavior on 64-bit hosts with printf arg.
10319 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10320 (x_stop_queuing_selection_requests): Likewise.
10321 (x_get_window_property): Don't truncate byte count to an 'int'
10324 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10325 here, since it parses constructs like leading '-' and spaces,
10326 which are not wanted; and it overflows with large numbers.
10327 Instead, simply match F[0-9]+, which is what is wanted anyway.
10329 * alloc.c: Remove unportable assumptions about struct layout.
10330 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10331 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10332 (allocate_vectorlike, make_pure_vector): Use the new macros,
10333 plus offsetof, to remove unportable assumptions about struct layout.
10334 These assumptions hold on all porting targets that I know of, but
10335 they are not guaranteed, they're easy to remove, and removing them
10336 makes further changes easier.
10338 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10339 This doesn't fix a bug but makes the code clearer.
10340 (string_overrun_cookie): Now const. Use initializers that
10341 don't formally overflow signed char, to avoid warnings.
10342 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10343 can cause Emacs to crash when string overrun checking is enabled.
10344 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10345 multiple of sizeof (EMACS_INT); it need not be, if
10346 alignof(EMACS_INT) < sizeof (EMACS_INT).
10347 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10349 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10351 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10353 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10355 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10356 supposed to be handshaking. (Bug#8556)
10357 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10359 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10361 * lisp.h (Qdebug): List symbol.
10362 * eval.c (Qdebug): Restore global linkage.
10363 * keyboard.c (debug-on-event): New variable.
10364 (handle_user_signal): Break into debugger when debug-on-event
10365 matches the current signal symbol.
10367 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10369 * alloc.c (check_sblock, check_string_bytes)
10370 (check_string_free_list): Convert to standard C.
10372 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10374 * w32.c (emacs_gnutls_push): Fix typo.
10376 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10378 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10379 "cast to pointer from integer of different size".
10381 Improve doprnt and its use in verror. (Bug#8545)
10382 * doprnt.c (doprnt): Document the set of format control sequences
10383 supported by the function. Use SAFE_ALLOCA instead of always
10386 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10387 is one byte too soon. Don't use xrealloc; instead xfree and
10390 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10392 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10395 * gnutls.c: Renamed global_initialized to
10396 gnutls_global_initialized. Added internals for the
10397 :verify-hostname-error, :verify-error, and :verify-flags
10398 parameters of `gnutls-boot' and documented those parameters in the
10399 docstring. Start callback support.
10400 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10401 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10402 on error. Return error code.
10403 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10404 (emacs_gnutls_read): Likewise.
10405 (Fgnutls_boot): Return handshake error code.
10406 (emacs_gnutls_handle_error): New function.
10407 (wsaerror_to_errno): Likewise.
10409 * w32.h (emacs_gnutls_pull): Add prototype.
10410 (emacs_gnutls_push): Likewise.
10412 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10413 (emacs_gnutls_push): Likewise.
10415 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10417 * process.c (wait_reading_process_output): Check if GnuTLS
10418 buffered some data internally if no FDs are set for TLS
10421 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10422 (LIBS): Link to USER_LIBS.
10423 ($(BLD)/gnutls.$(0)): New target.
10425 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10427 * xdisp.c (handle_single_display_spec): Rename the
10428 display_replaced_before_p argument into display_replaced_p, to
10429 make it consistent with the commentary. Fix typos in the
10432 * textprop.c (syms_of_textprop): Remove dead code.
10433 (copy_text_properties): Delete obsolete commentary about an
10434 interface that was deleted long ago. Fix typos in the description
10437 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10438 to changes in oldXMenu/XMenu.h from 2011-04-16.
10439 <menu_help_message, prev_menu_help_message>: Constify.
10440 (IT_menu_make_room): menu->help_text is now `const char **';
10443 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10444 to changes in oldXMenu/XMenu.h from 2011-04-16.
10445 (struct XMenu): Declare `help_text' `const char **'.
10447 * xfaces.c <Qunspecified>: Make extern again.
10449 * syntax.c: Include sys/types.h before including regex.h, as
10452 * doc.c (get_doc_string): Improve the format passed to `error'.
10454 * doprnt.c (doprnt): Improve commentary.
10456 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10458 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10461 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10462 changes in globals.h immediately force recompilation.
10463 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10464 $(CURDIR)/s/ms-w32.h.
10465 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10467 * character.c (Fchar_direction): Function deleted.
10468 (syms_of_character): Don't defsubr it.
10469 <char-direction-table>: Deleted.
10471 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10473 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10474 * doprnt.c: Include limits.h.
10475 (SIZE_MAX): New macro.
10476 (doprnt): Return a size_t value. 2nd arg is now size_t.
10477 Many local variables are now size_t instead of int or unsigned.
10478 Improve overflow protection. Support `l' modifier for integer
10479 conversions. Support %l conversion. Don't assume an EMACS_INT
10480 argument for integer conversions and for %c.
10482 * lisp.h (doprnt): Restore prototype.
10484 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10485 $(SRC)/character.h.
10487 * Makefile.in (base_obj): Add back doprnt.o.
10489 * deps.mk (doprnt.o): Add back prerequisites.
10490 (callint.o): Depend on character.h.
10492 * eval.c (internal_lisp_condition_case): Include the handler
10493 representation in the error message.
10494 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10495 when breaking from the loop.
10497 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10499 * callint.c (Fcall_interactively): When displaying error message
10500 about invalid control letter, pass the character's codepoint, not
10501 a pointer to its multibyte form. Improve display of the character
10502 in octal and display also its hex code.
10504 * character.c (char_string): Use %x to display the (unsigned)
10505 codepoint of an invalid character, to avoid displaying a bogus
10508 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10509 `error', not SYMBOL_NAME itself.
10511 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10512 character arguments to `error'.
10514 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10515 to `error' in error message about FINAL_CHAR argument. Make sure
10516 FINAL_CHAR is a character, and use %c when it is passed as
10517 argument to `error'.
10519 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10521 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10523 * w32.c: Include <time.h>.
10524 (sys_localtime): New function.
10526 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10528 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10530 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10532 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10534 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10535 zombies (Bug#8467).
10537 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10539 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10540 gl_state.e_property when gl_state.object is Qt.
10542 * insdel.c (make_gap_larger): Remove limitation of buffer size
10545 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10547 * xdisp.c (lookup_glyphless_char_display)
10548 (produce_glyphless_glyph): Handle cons cell entry in
10549 glyphless-char-display.
10550 (Vglyphless_char_display): Document it.
10552 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10553 glyphless-char-display.
10555 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10557 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10559 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10562 definition for no-X builds.
10564 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10566 Static checks with GCC 4.6.0 and non-default toolkits.
10568 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10570 * process.c (keyboard_bit_set): Define only if SIGIO.
10571 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10572 (send_process): Repair possible setjmp clobbering.
10574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10576 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10578 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10580 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10581 Define only if needed.
10583 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10584 by pacifying GCC about it. Maybe it's time to retire it?
10585 * xfaces.c (USG, __TIMEVAL__): Likewise.
10587 * dispextern.h (struct redisplay_interface): Rename param
10588 to avoid shadowing.
10589 * termhooks.h (struct terminal): Likewise.
10590 * xterm.c (xembed_send_message): Likewise.
10592 * insdel.c (make_gap_smaller): Define only if
10593 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10595 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10598 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10599 so that we aren't warned about unused symbols.
10601 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10603 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10605 * xfns.c (x_real_positions): Mark locals as initialized.
10607 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10609 * xterm.c: Fix problems found by static analysis with other toolkits.
10610 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10611 (x_dispatch_event): Declare static if USE_GTK, and
10612 define if USE_GTK || USE_X_TOOLKIT.
10613 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10614 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10615 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10616 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10618 * xmenu.c (menu_help_callback): Pointer type fixes.
10619 Use const pointers when pointing at readonly data. Avoid pointer
10620 signedness clashes.
10621 (FALSE): Remove unused macro.
10622 (update_frame_menubar): Remove unused decl.
10624 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10626 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10627 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10628 (single_menu_item): Rename local to avoid shadowing.
10630 * keyboard.c (make_lispy_event): Remove unused local var.
10632 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10633 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10635 * bitmaps: Change bitmaps from unsigned char back to the X11
10636 compatible char. Avoid the old compiler warnings about
10637 out-of-range initializers by using, for example, '\xab' rather
10640 * xgselect.c (xgselect_initialize): Check vs interface
10641 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10643 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10645 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10646 to read-only memory.
10648 * fns.c (vector): Remove; this old hack is no longer needed.
10650 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10652 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10654 * xrdb.c (x_load_resources): Omit unused local.
10656 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10657 (x_window): Rename locals to avoid shadowing.
10658 (USG): Use the kludged USG macro, to pacify gcc.
10660 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10661 (x_term_init): Remove local to avoid shadowing.
10663 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10665 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10666 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10668 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10670 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10672 Fix regex.c, syntax.c and friends for buffers > 2GB.
10673 * syntax.h (struct gl_state_s): Declare character position members
10676 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10678 * textprop.c (verify_interval_modification, interval_of):
10679 Declare arguments EMACS_INT.
10681 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10684 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10686 * indent.c (Fvertical_motion): Local variable it_start is now
10689 * regex.c (re_match, re_match_2, re_match_2_internal)
10690 (bcmp_translate, regcomp, regexec, print_double_string)
10691 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10692 (re_compile_pattern, re_exec): Declare arguments and local
10693 variables `size_t' and `ssize_t' and return values `regoff_t', as
10695 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10696 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10697 <compile_stack_type>: `size' and `avail' are now `size_t'.
10699 * regex.h <regoff_t>: Use ssize_t, not int.
10700 (re_search, re_search_2, re_match, re_match_2): Arguments that
10701 specify buffer/string position and length are now ssize_t and
10702 size_t. Return type is regoff_t.
10704 2011-04-16 Ben Key <bkey76@gmail.com>
10706 * nsfont.m: Fixed bugs in ns_get_family and
10707 ns_descriptor_to_entity that were caused by using free to
10708 deallocate memory blocks that were allocated by xmalloc (via
10709 xstrdup). This caused Emacs to crash when compiled with
10710 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10711 --enable-checking=xmallocoverrun). xfree is now used to
10712 deallocate these memory blocks.
10714 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10716 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10718 emacs_write: Accept and return EMACS_INT for sizes.
10719 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10721 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10722 Accept and return EMACS_INT.
10723 (emacs_gnutls_write): Return the number of bytes written on
10725 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10726 (emacs_read, emacs_write): Remove check for negative size, as the
10727 Emacs source code has been audited now.
10728 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10729 (emacs_read, emacs_write): Use it.
10730 * process.c (send_process): Adjust to the new signatures of
10731 emacs_write and emacs_gnutls_write. Do not attempt to store
10732 a byte offset into an 'int'; it might overflow.
10733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10735 * sound.c: Don't assume sizes fit in 'int'.
10736 (struct sound_device.period_size, alsa_period_size):
10737 Return EMACS_INT, not int.
10738 (struct sound_device.write, vox_write, alsa_write):
10739 Accept EMACS_INT, not int.
10740 (wav_play, au_play): Use EMACS_INT to store sizes and to
10741 record read return values.
10743 2011-04-15 Ben Key <bkey76@gmail.com>
10745 * keyboard.c (Qundefined): Don't declare static since it is used
10747 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10748 static since they are used in nsfont.m.
10750 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10752 * process.c (Qprocessp): Don't declare static.
10753 * lisp.h (Qprocessp): Declare again.
10755 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10757 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10759 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10761 Improve C-level modularity by making more things 'static'.
10763 Don't publish debugger-only interfaces to other modules.
10764 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10765 (verify_bytepos, count_markers): Move decls to the only modules
10767 * region-cache.h (pp_cache): Likewise.
10768 * window.h (check_all_windows): Likewise.
10769 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10771 * sysdep.c (croak): Now static, if
10772 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10773 * syssignal.h (croak): Declare only if not static.
10775 * alloc.c (refill_memory_reserve): Now static if
10776 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10777 * lisp.h (refill_memory_reserve): Declare only if not static.
10779 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10780 Define only if USE_LUCID.
10782 * xrdb.c (x_customization_string, x_rm_string): Now static.
10784 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10785 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10787 * xdisp.c (draw_row_with_mouse_face): Now static.
10788 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10790 * window.h (check_all_windows): Mark externally visible.
10792 * window.c (window_deletion_count): Now static.
10794 * undo.c: Make symbols static if they're not exported.
10795 (last_undo_buffer, last_boundary_position, pending_boundary):
10798 * textprop.c (interval_insert_behind_hooks): Now static.
10799 (interval_insert_in_front_hooks): Likewise.
10801 * term.c: Make symbols static if they're not exported.
10802 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10803 (max_frame_lines, tty_set_terminal_modes):
10804 (tty_reset_terminal_modes, tty_turn_off_highlight):
10805 (get_tty_terminal): Now static.
10806 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10807 * termhooks.h (term_mouse_moveto): Do not declare if
10808 HAVE_WINDOW_SYSTEM.
10809 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10810 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10812 * sysdep.c: Make symbols static if they're not exported.
10813 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10815 (sigprocmask_set, full_mask): Remove; unused.
10816 (wait_debugging): Mark as visible.
10817 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10818 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10820 * syntax.c (syntax_temp): Define only if !__GNUC__.
10822 * sound.c (current_sound_device, current_sound): Now static.
10824 * search.c (searchbufs, searchbuf_head): Now static.
10826 * scroll.c (scroll_cost): Remove; unused.
10827 * dispextern.h (scroll_cost): Remove decl.
10829 * region-cache.h (pp_cache): Mark as externally visible.
10831 * process.c: Make symbols static if they're not exported.
10832 (process_tick, update_tick, create_process, chan_process):
10833 (Vprocess_alist, proc_buffered_char, datagram_access):
10834 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10835 (deactivate_process): Mark defn as static, as well as decl.
10836 * lisp.h (create_process): Remove decl.
10837 * process.h (chan_process, Vprocess_alist): Remove decls.
10839 * print.c: Make symbols static if they're not exported.
10840 (print_depth, new_backquote_output, being_printed, print_buffer):
10841 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10842 (print_interval, print_number_index, initial_stderr_stream):
10844 * lisp.h (Fprinc): Remove decl.
10845 (debug_output_compilation_hack): Mark as externally visible.
10847 * sysdep.c (croak): Move decl from here to syssignal.h.
10848 * syssignal.h (croak): Put it here, so the API can be checked when
10849 'croak' is called from dissociate_if_controlling_tty.
10851 * minibuf.c: Make symbols static if they're not exported.
10852 (minibuf_save_list, choose_minibuf_frame): Now static.
10853 * lisp.h (choose_minibuf_frame): Remove decl.
10855 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10857 * lread.c: Make symbols static if they're not exported.
10858 (read_objects, initial_obarray, oblookup_last_bucket_number):
10860 (make_symbol): Remove; unused.
10861 * lisp.h (initial_obarray, make_symbol): Remove decls.
10863 * keyboard.c: Make symbols static if they're not exported.
10864 (single_kboard, recent_keys_index, total_keys, recent_keys):
10865 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10866 (this_single_command_key_start, echoing, last_auto_save):
10867 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10868 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10869 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10870 (Vlispy_mouse_stem, double_click_count):
10872 (force_auto_save_soon): Define only if SIGDANGER.
10873 (ignore_mouse_drag_p): Now static if
10874 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10875 (print_help): Remove; unused.
10876 (stop_character, last_timer_event): Mark as externally visible.
10877 * keyboard.h (ignore_mouse_drag_p): Declare only if
10878 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10879 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10880 * lisp.h (echoing): Remove decl.
10881 (force_auto_save_soon): Declare only if SIGDANGER.
10882 * xdisp.c (redisplay_window): Simplify code, to make it more
10883 obvious that ignore_mouse_drag_p is not accessed if !defined
10884 USE_GTK && !defined HAVE_NS.
10886 * intervals.c: Make symbols static if they're not exported.
10887 (merge_properties_sticky, merge_interval_right, delete_interval):
10889 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10891 * insdel.c: Make symbols static if they're not exported.
10892 However, leave prepare_to_modify_buffer alone. It's never
10893 called from outside this function, but that appears to be a bug.
10894 (combine_after_change_list, combine_after_change_buffer):
10895 (adjust_after_replace, signal_before_change): Now static.
10896 (adjust_after_replace_noundo): Remove; unused.
10897 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10898 (signal_before_change): Remove decls.
10900 * indent.c (val_compute_motion, val_vmotion): Now static.
10902 * image.c: Make symbols static if they're not exported.
10903 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10905 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10906 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10908 * fringe.c (standard_bitmaps): Now static.
10909 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10911 * frame.c: Make symbols static if they're not exported.
10912 (x_report_frame_params, make_terminal_frame): Now static.
10913 (get_frame_param): Now static, unless HAVE_NS.
10914 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10915 (x_get_resource_string): Remove; not used.
10916 * frame.h (make_terminal_frame, x_report_frame_params):
10917 (x_get_resource_string); Remove decls.
10918 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10919 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10921 * font.c, fontset.c: Make symbols static if they're not exported.
10922 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10923 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10924 * font.c (font_close_object): Now static.
10925 * font.h (font_close_object): Remove.
10926 * fontset.c (FONTSET_OBJLIST): Remove.
10927 (free_realized_fontset) #if-0 the body, which does nothing.
10928 (face_suitable_for_char_p): #if-0, as it's never called.
10929 * fontset.h (face_suitable_for_char_p): Remove decl.
10930 * xfaces.c (face_at_string_position):
10931 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10932 since 0 is always ASCII.
10934 * fns.c (weak_hash_tables): Now static.
10936 * fileio.c: Make symbols static if they're not exported.
10937 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10938 (Vwrite_region_annotation_buffers): Now static.
10940 * eval.c: Make symbols static if they're not exported.
10941 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10942 * lisp.h (backtrace_list): Remove decl.
10944 * emacs.c: Make symbols static if they're not exported.
10945 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10946 (fatal_error_code, fatal_error_signal_hook, standard_args):
10948 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10949 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10950 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10951 * lisp.h (fatal_error_signal_hook): Remove decl.
10952 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10954 * editfns.c: Move a (normally-unused) function to its only use.
10955 * editfns.c, lisp.h (get_operating_system_release): Remove.
10956 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10957 worth the hassle of breaking this out.
10959 * xterm.c: Make symbols static if they're not exported.
10960 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10961 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10962 (x_destroy_window, x_delete_display):
10964 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10965 (x_mouse_leave): Remove; unused.
10966 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10967 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10968 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10970 (x_mouse_leave): Declare only if WINDOWSNT.
10971 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10972 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10975 * ftxfont.c: Make symbols static if they're not exported.
10976 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10978 * font.h (ftxfont_driver): Likewise.
10980 * xfns.c: Make symbols static if they're not exported.
10981 (x_last_font_name, x_display_info_for_name):
10982 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10983 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10984 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10985 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10986 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10987 (last_show_tip_args): Now static.
10988 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10989 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10990 (x_screen_planes): Remove; unused.
10991 * dispextern.h (x_screen_planes): Remove decl.
10993 * dispnew.c: Make symbols static if they're not exported.
10994 * dispextern.h (redraw_garbaged_frames, scrolling):
10995 (increment_row_positions): Remove.
10996 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10997 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10999 (redraw_garbaged_frames): Remove; unused.
11001 * xfaces.c: Make symbols static if they're not exported.
11002 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11004 * xterm.h (defined_color): Remove decls.
11005 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11006 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11007 (menu_face_changed_default, defined_color, free_realized_face):
11008 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11009 (ascii_face_of_lisp_face): Remove; unused.
11011 * xdisp.c: Make symbols static if they're not exported.
11012 * dispextern.h (scratch_glyph_row, window_box_edges):
11013 (glyph_to_pixel_coords, set_cursor_from_row):
11014 (get_next_display_element, set_iterator_to_next):
11015 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11016 (show_mouse_face): Remove decls
11017 * frame.h (message_buf_print): Likewise.
11018 * lisp.h (pop_message, set_message, check_point_in_composition):
11020 * xterm.h (set_vertical_scroll_bar): Likewise.
11021 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11022 (message_buf_print, scratch_glyph_row, displayed_buffer):
11023 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11024 (get_next_display_element, show_mouse_face, window_box_edges):
11025 (frame_to_window_pixel_xy, check_point_in_composition):
11026 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11027 (glyph_to_pixel_coords): Remove; unused.
11029 * dired.c (file_name_completion): Now static.
11031 * dbusbind.c (xd_in_read_queued_messages): Now static.
11033 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11034 * data.c (circular_list_error): Remove.
11036 * commands.h (last_point_position, last_point_position_buffer):
11037 (last_point_position_window): Remove decls.
11038 * keyboard.c: Make these variables static.
11040 * coding.h (coding, code_convert_region, encode_coding_gap):
11042 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11043 (iso_code_class, detect_coding, code_convert_region): Now static.
11044 (encode_coding_gap): Remove; unused.
11046 * chartab.c (chartab_chars, chartab_bits): Now static.
11048 * charset.h (charset_iso_8859_1): Remove decl.
11049 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11052 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11053 * ccl.c (Vccl_program_table): Now static.
11054 (check_ccl_update): Remove; unused.
11056 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11057 * category.h: ... from here.
11058 * category.c (check_category_table, set_category_set): Now static.
11060 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11061 * lisp.h: Remove these decls.
11063 * buffer.c (buffer_count): Remove unused var.
11065 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11066 so that it's not optimized away.
11067 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11068 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11069 exported only to the debugger.
11071 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11072 * atimer.h (run_all_atimers): Remove; not exported.
11074 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11075 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11076 was inaccessible from Lisp.
11077 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11078 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11080 alloc.c: Import and export fewer symbols, and remove unused items.
11081 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11083 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11084 it's not optimized away by whole-program optimization.
11085 (message_enable_multibyte, free_misc): Remove.
11086 (catchlist, handlerlist, mark_backtrace):
11087 Declare only if BYTE_MARK_STACK.
11088 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11089 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11090 (message_enable_multibyte): Remove decl.
11091 (free_misc, interval_free_list, float_block, float_block_index):
11092 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11093 (cons_free_list, last_marked_index):
11095 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11096 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11097 (mark_backtrace): Define only if BYTE_MARK_STACK.
11098 * xdisp.c (message_enable_multibyte): Now static.
11100 Declare Lisp_Object Q* variables to be 'static' if not exported.
11101 This makes it easier for human readers (and static analyzers)
11102 to see whether these variables are used from other modules.
11103 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11104 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11105 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11106 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11107 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11108 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11109 * xmenu.c, xselect.c:
11110 Declare Q* vars static if they are not used in other modules.
11111 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11112 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11113 Remove decls of unexported vars.
11114 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11116 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11118 Make Emacs functions such as Fatom 'static' by default.
11119 This makes it easier for human readers (and static analyzers)
11120 to see whether these functions can be called from other modules.
11121 DEFUN now defines a static function. To make the function external
11122 so that it can be used in other C modules, use the new macro DEFUE.
11123 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11124 (Finit_image_library):
11125 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11126 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11127 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11128 Remove decls, since these functions are now static.
11129 (Funintern, Fget_internal_run_time): New decls, since these functions
11130 were already external.
11132 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11133 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11134 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11135 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11136 * keyboard.c, keymap.c, lread.c:
11137 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11138 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11139 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11140 Mark functions with DEFUE instead of DEFUN,
11141 if they are used in other modules.
11142 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11143 decls for now-static functions.
11144 * buffer.h (Fdelete_overlay): Remove decl.
11145 * callproc.c (Fgetenv_internal): Mark as internal.
11146 * composite.c (Fremove_list_of_text_properties): Remove decl.
11147 (Fcomposition_get_gstring): New forward static decl.
11148 * composite.h (Fcomposite_get_gstring): Remove decl.
11149 * dired.c (Ffile_attributes): New forward static decl.
11150 * doc.c (Fdocumntation_property): New forward static decl.
11151 * eval.c (Ffetch_bytecode): New forward static decl.
11152 (Funintern): Remove extern decl; now in .h file where it belongs.
11153 * fileio.c (Fmake_symbolic_link): New forward static decl.
11154 * image.c (Finit_image_library): New forward static decl.
11155 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11156 * intervals.h (Fprevious_property_change):
11157 (Fremove_list_of_text_properties): Remove decls.
11158 * keyboard.c (Fthis_command_keys): Remove decl.
11159 (Fcommand_execute): New forward static decl.
11160 * keymap.c (Flookup_key): New forward static decl.
11161 (Fcopy_keymap): Now static.
11162 * keymap.h (Flookup_key): Remove decl.
11163 * process.c (Fget_process): New forward static decl.
11164 (Fprocess_datagram_address): Mark as internal.
11165 * syntax.c (Fsyntax_table_p): New forward static decl.
11166 (skip_chars): Remove duplicate decl.
11167 * textprop.c (Fprevious_property_change): New forward static decl.
11168 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11170 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11171 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11173 * editfns.c (Fformat): Remove unreachable code.
11175 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11177 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11180 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11182 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11183 when at ZV. (Bug#8487)
11185 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11187 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11189 * keyboard.c (parse_tool_bar_item): Likewise.
11190 * sound.c (sound_cleanup, alsa_close): Likewise.
11191 * termcap.c (tgetent): Likewise.
11192 * xfns.c (x_default_font_parameter): Likewise.
11193 * xsettings.c (read_and_apply_settings): Likewise.
11195 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11196 (overrun_check_free): Protoize.
11198 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11200 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11201 since callers should never pass a negative size.
11202 Change the signature to match that of plain 'read' and 'write'; see
11203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11204 * lisp.h: Update prototypes of emacs_write and emacs_read.
11206 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11208 * xdisp.c (redisplay_window): Don't try to determine the character
11209 position of the scroll margin if the window start point w->startp
11210 is outside the buffer's accessible region. (Bug#8468)
11212 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11214 Fix write-region and its subroutines for buffers > 2GB.
11215 * fileio.c (a_write, e_write): Modify declaration of arguments and
11216 local variables to support buffers larger than 2GB.
11217 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11219 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11220 argument, local variables, and return value.
11222 * lisp.h: Update prototypes of emacs_write and emacs_read.
11224 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11226 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11228 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11230 Fix more problems found by GCC 4.6.0's static checks.
11232 * xdisp.c (vmessage): Use a better test for character truncation.
11234 * charset.c (load_charset_map): <, not <=, for optimization,
11235 and to avoid potential problems with integer overflow.
11236 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11237 * casetab.c (set_identity, shuffle): Likewise.
11238 * editfns.c (Fformat): Likewise.
11239 * syntax.c (skip_chars): Likewise.
11241 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11242 This also lets GCC 4.6.0 generate slightly better loop code.
11244 * callint.c (Fcall_interactively): <, not <=, for optimization.
11245 (Fcall_interactively): Count the number of arguments produced,
11246 not the number of arguments given. This is simpler and lets GCC
11247 4.6.0 generate slightly better code.
11249 * ftfont.c: Distingish more carefully between FcChar8 and char.
11250 The previous code passed unsigned char * to a functions like
11251 strlen and xstrcasecmp that expect char *, which does not
11252 conform to the C standard.
11253 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11254 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11255 char * when the C standard requires it.
11257 * keyboard.c (read_char): Remove unused var.
11259 * eval.c: Port to Windows vsnprintf (Bug#8435).
11260 Include <limits.h>.
11261 (SIZE_MAX): Define if the headers do not.
11262 (verror): Do not give up if vsnprintf returns a negative count.
11263 Instead, grow the buffer. This ports to Windows vsnprintf, which
11264 does not conform to C99. Problem reported by Eli Zaretskii.
11265 Also, simplify the allocation scheme, by avoiding the need for
11266 calling realloc, and removing the ALLOCATED variable.
11268 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11270 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11271 But keep the doprint source code for now, as we might revamp it
11272 and use it again (Bug#8435).
11273 * lisp.h (doprnt): Remove.
11274 * Makefile.in (base_obj): Remove doprnt.o.
11275 * deps.mk (doprnt.o): Remove.
11277 error: Print 32- and 64-bit integers portably (Bug#8435).
11278 Without this change, on typical 64-bit hosts error ("...%d...", N)
11279 was used to print both 32- and 64-bit integers N, which relied on
11280 undefined behavior.
11281 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11282 * lisp.h (error, verror): Mark as printf-like functions.
11283 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11284 Report overflow in size calculations when allocating printf buffer.
11285 Do not truncate output string at its first null byte.
11286 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11287 Truncate the output at a character boundary, since vsnprintf does not
11289 * charset.c (check_iso_charset_parameter): Convert internal
11290 character to string before calling 'error', since %c now has the
11292 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11293 overflow when computing char to be passed to 'error'. Do not
11294 pass Lisp_Object to 'error'; pass the integer instead.
11295 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11296 formatted with plain %d.
11298 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11300 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11302 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11304 * xterm.c (x_catch_errors): Remove duplicate declaration.
11306 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11308 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11310 2011-04-10 Jim Meyering <meyering@redhat.com>
11312 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11313 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11314 return ssize_t not "int", and use size_t as the buffer length.
11315 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11316 * gnutls.h: Update declarations.
11317 * process.c (read_process_output): Use ssize_t, to match.
11318 (send_process): Likewise.
11320 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11322 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11324 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11326 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11327 Use unsigned char, to match FcChar8 type definition.
11329 * xterm.c (handle_one_xevent):
11330 * xmenu.c (create_and_show_popup_menu):
11331 * xselect.c (x_decline_selection_request)
11332 (x_reply_selection_request): Avoid type-punned deref of X events.
11334 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11336 Fix some uses of `int' instead of EMACS_INT.
11337 * search.c (string_match_1, fast_string_match)
11338 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11339 (scan_buffer, find_next_newline_no_quit)
11340 (find_before_next_newline, search_command, Freplace_match)
11341 (Fmatch_data): Make some `int' variables be EMACS_INT.
11343 * xdisp.c (display_count_lines): 3rd argument and return value now
11344 EMACS_INT. All callers changed.
11345 (pint2hrstr): Last argument is now EMACS_INT.
11347 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11348 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11349 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11350 (decode_coding_utf_16, decode_coding_emacs_mule)
11351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11352 (decode_coding_ccl, decode_coding_charset)
11353 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11354 (decode_coding_iso_2022, decode_coding_emacs_mule)
11355 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11356 <char_offset, last_offset>: Declare EMACS_INT.
11357 (encode_coding_utf_8, encode_coding_utf_16)
11358 (encode_coding_emacs_mule, encode_invocation_designation)
11359 (encode_designation_at_bol, encode_coding_iso_2022)
11360 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11361 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11363 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11364 (encode_invocation_designation): Last argument P_NCHARS is now
11366 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11367 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11369 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11372 * ccl.c (Fccl_execute_on_string): Declare some variables
11375 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11377 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11379 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11381 * process.c (Fformat_network_address): Doc fix.
11383 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11385 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11387 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11389 * keyboard.c (read_char): Call Lisp function help-form-show,
11390 instead of using internal_with_output_to_temp_buffer.
11391 (Qhelp_form_show): New var.
11392 (syms_of_keyboard): Use DEFSYM macro.
11394 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11396 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11398 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11400 * process.c (Flist_processes): Remove to Lisp.
11401 (list_processes_1): Delete.
11403 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11405 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11407 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11409 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11411 Fix more problems found by GCC 4.6.0's static checks.
11413 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11415 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11417 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11419 * xdisp.c (vmessage): Mark as a printf-like function.
11421 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11423 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11425 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11426 printf-like functions.
11427 (tiff_load): Add casts to remove these marks before passing them
11428 to system-supplied API.
11430 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11432 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11433 This avoids several warnings with gcc -Wstrict-overflow.
11434 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11435 directly, rather than having caller test rule sign. This avoids
11436 some unnecessary tests.
11437 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11438 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11439 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11441 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11442 (xfont_open): Avoid unnecessary tests.
11444 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11446 * composite.h, composite.c (composition_gstring_put_cache):
11447 Use EMACS_INT, not int, for length.
11449 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11450 breaking out part of COMPOSITION_DECODE_RULE.
11451 (COMPOSITION_DECODE_RULE): Use it.
11452 * composite.c (get_composition_id): Remove unused local vars,
11453 by using the new macro.
11455 * textprop.c (set_text_properties_1): Change while to do-while,
11456 since the condition is always true at first.
11458 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11459 (interval_deletion_adjustment): Return unsigned value.
11462 * process.c (list_processes_1, create_pty, read_process_output):
11463 (exec_sentinel): Remove vars that were set but not used.
11464 (create_pty): Remove unnecessary "volatile"s.
11465 (Fnetwork_interface_info): Avoid possibility of int overflow.
11466 (read_process_output): Do adaptive read buffering even if carryover.
11467 (read_process_output): Simplify nbytes computation if buffered.
11469 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11471 * syntax.c (scan_words): Remove var that was set but not used.
11472 (update_syntax_table): Use unsigned instead of int.
11474 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11475 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11476 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11478 * print.c (print_error_message): Avoid int overflow.
11480 * font.c (font_list_entities): Redo for clarity,
11481 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11483 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11484 (font_score): Avoid potential overflow in diff calculation.
11486 * fns.c (substring_both): Remove var that is set but not used.
11487 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11489 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11491 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11492 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11493 can always succeed if overflow has undefined behavior.
11495 * search.c (boyer_moore, wordify): Remove vars set but not used.
11496 (wordify): Omit three unnecessary tests.
11498 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11499 All callers changed. This avoids the need for an unused var.
11501 * casefiddle.c (casify_region): Remove var that is set but not used.
11503 * dired.c (file_name_completion): Remove var that is set but not used.
11505 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11507 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11508 (Finsert_file_contents): Remove unnecessary code checking fd.
11510 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11511 Check for integer overflow on size calculations.
11513 * buffer.c (Fprevious_overlay_change): Remove var that is set
11516 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11517 Remove vars that are set but not used.
11518 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11519 (timer_check_2): Mark vars as initialized.
11521 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11523 * image.c (lookup_image): Remove var that is set but not used.
11524 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11526 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11527 that are set but not used.
11529 * xfns.c (make_invisible_cursor): Don't return garbage
11530 if XCreateBitmapFromData fails (Bug#8410).
11532 * xselect.c (x_get_local_selection, x_handle_property_notify):
11533 Remove vars that are set but not used.
11535 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11536 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11538 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11539 Remove var that is set but not used.
11540 (scroll_bar_windows_size): Now size_t, not int.
11541 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11542 Check for overflow.
11544 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11545 (map_tty_color) [!defined MSDOS]: Likewise.
11547 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11549 * coding.c: Remove vars that are set but not used.
11550 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11551 All callers changed.
11552 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11553 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11554 (decode_coding_charset): Remove vars that are set but not used.
11556 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11557 that is set but not used.
11559 * print.c (print_object): Remove var that is set but not used.
11561 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11562 The gnulib version avoids calling malloc in the usual case,
11563 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11564 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11565 * filelock.c (current_lock_owner): Likewise.
11566 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11567 * sysdep.c: Include allocator.h, careadlinkat.h.
11568 (emacs_no_realloc_allocator): New static constant.
11569 (emacs_readlink): New function.
11570 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11571 ../lib/careadlinkat.h.
11573 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11575 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11576 first non-nil return value).
11578 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11580 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11581 if not defined (Bug#8403).
11583 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11585 * xdisp.c (display_count_lines): Remove parameter `start',
11586 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11587 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11588 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11589 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11590 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11591 and thereabouts. All callers changed.
11592 (get_per_char_metric): Remove parameter `f', unused since
11593 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11595 2011-04-02 Jim Meyering <meyering@redhat.com>
11597 do not dereference NULL upon failed strdup
11598 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11599 (ns_get_family): Likewise.
11601 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11603 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11605 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11607 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11610 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11612 Add lexical binding.
11614 * window.c (Ftemp_output_buffer_show): New fun.
11615 (Fsave_window_excursion):
11616 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11618 * lread.c (lisp_file_lexically_bound_p): New function.
11619 (Fload): Bind Qlexical_binding.
11620 (readevalloop): Remove `evalfun' arg.
11621 Bind Qinternal_interpreter_environment.
11622 (Feval_buffer): Bind Qlexical_binding.
11623 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11625 (syms_of_lread): Declare `lexical-binding'.
11627 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11629 * keyboard.c (eval_dyn): New fun.
11630 (menu_item_eval_property): Use it.
11632 * image.c (parse_image_spec): Use Ffunctionp.
11634 * fns.c (concat, mapcar1): Accept byte-code-functions.
11636 * eval.c (Fsetq): Handle lexical vars.
11637 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11638 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11639 (FletX, Flet): Obey lexical binding.
11640 (Fcommandp): Handle closures.
11641 (Feval): New `lexical' arg.
11642 (eval_sub): New function extracted from Feval. Use it almost
11643 everywhere where Feval was used. Look up vars in lexical env.
11645 (Ffunctionp): Move from subr.el.
11646 (Ffuncall): Handle closures.
11647 (apply_lambda): Remove `eval_flags'.
11648 (funcall_lambda): Handle closures and new byte-code-functions.
11649 (Fspecial_variable_p): New function.
11650 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11651 but without exporting it to Lisp.
11653 * doc.c (Fdocumentation, store_function_docstring):
11654 * data.c (Finteractive_form): Handle closures.
11656 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11659 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11661 (exec_byte_code): New function extracted from Fbyte_code to handle new
11662 calling convention for byte-code-functions. Add new byte-codes.
11664 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11666 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11668 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11670 * xdisp.c (redisplay_internal): Fix prototype.
11672 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11674 * xdisp.c (SCROLL_LIMIT): New macro.
11675 (try_scrolling): Use it when setting scroll_limit.
11676 Limit scrolling to 100 screen lines.
11677 (redisplay_window): Even when falling back on "recentering",
11678 position point in the window according to scroll-conservatively,
11679 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11681 (try_scrolling): When point is above the window, allow searching
11682 as far as scroll_max, or one screenful, to compute vertical
11683 distance from PT to the scroll margin position. This prevents
11684 try_scrolling from unnecessarily failing when
11685 scroll-conservatively is set to a value slightly larger than the
11686 window height. Clean up the case of PT below the margin at bottom
11687 of window: scroll_max can no longer be INT_MAX. When aggressive
11688 scrolling is in use, don't let point enter the opposite scroll
11689 margin as result of the scroll.
11690 (syms_of_xdisp) <scroll-conservatively>: Document the
11691 threshold of 100 lines for never-recentering scrolling.
11693 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11695 * dispextern.h (move_it_by_lines):
11696 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11697 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11698 (message_log_check_duplicate): Remove parameters `prev_bol' and
11699 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11700 (redisplay_internal): Remove parameter `preserve_echo_area',
11701 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11703 * indent.c (Fvertical_motion):
11704 * window.c (window_scroll_pixel_based, Frecenter):
11705 Don't pass `need_y_p' to `move_it_by_lines'.
11707 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11709 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11710 steal a few bits to be more compact.
11711 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11712 Remove unneeded casts.
11714 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11716 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11718 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11719 binding" message (bug#7967).
11721 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11723 Fix more problems found by GCC 4.6.0's static checks.
11725 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11726 Remove unused local var.
11728 * editfns.c (Fmessage_box): Remove unused local var.
11730 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11731 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11732 Omit unused local vars.
11733 * window.c (shrink_windows): Omit unused local var.
11734 * menu.c (digest_single_submenu): Omit unused local var.
11735 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11736 Omit unused local var.
11738 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11739 Don't assume string length fits in int.
11740 (keyremap_step, read_key_sequence): Use size_t for sizes.
11741 (read_key_sequence): Don't check last_real_key_start redundantly.
11743 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11744 instead of alloca (Bug#8344).
11746 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11747 (Fbacktrace_frame): Don't assume nframes fits in int.
11749 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11751 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11754 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11756 * cm.c (calccost): Turn while-do into do-while, for clarity.
11758 * keyboard.c (syms_of_keyboard): Use the same style as later
11759 in this function when indexing through an array. This also
11760 works around GCC bug 48267.
11762 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11764 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11766 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11767 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11769 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11770 This avoids undefined behavior on integer overflow, and is a bit
11771 more convenient anyway since it is compared to a size_t variable.
11773 Variadic C functions now count arguments with size_t, not int.
11774 This avoids an unnecessary limitation on 64-bit machines, which
11775 caused (substring ...) to crash on large vectors (Bug#8344).
11776 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11777 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11778 All variadic functions and their callers changed accordingly.
11779 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11780 * data.c (arith_driver, float_arith_driver): Likewise.
11781 * editfns.c (general_insert_function): Likewise.
11782 * eval.c (struct backtrace.nargs, interactive_p)
11783 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11784 (funcall_lambda, mark_backtrace): Likewise.
11785 * fns.c (concat): Likewise.
11786 * frame.c (x_set_frame_parameters): Likewise.
11787 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11788 0 if not found, not -1. All callers changed.
11790 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11791 (stack_copy_size): Now size_t, not int.
11792 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11794 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11796 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11797 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11798 All callers changed.
11800 * lisp.h (multibyte_char_to_unibyte):
11801 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11802 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11803 * character.h (CHAR_TO_BYTE8):
11804 * cmds.c (internal_self_insert):
11805 * editfns.c (general_insert_function):
11806 * keymap.c (push_key_description):
11807 * search.c (Freplace_match):
11808 * xdisp.c (message_dolog, set_message_1): All callers changed.
11810 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11812 * keyboard.c (safe_run_hook_funcall): New function.
11813 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11814 don't set the hook to nil, but remove the offending function instead.
11815 (Qcommand_hook_internal): Remove, unused.
11816 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11817 Vcommand_hook_internal.
11819 * eval.c (enum run_hooks_condition): Remove.
11820 (funcall_nil, funcall_not): New functions.
11821 (run_hook_with_args): Call each function through a `funcall' argument.
11822 Remove `cond' argument, now redundant.
11823 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11824 (Frun_hook_with_args_until_failure): Adjust accordingly.
11825 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11827 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11829 * dispextern.h (string_buffer_position): Remove declaration.
11831 * print.c (strout): Remove parameter `multibyte', unused since
11832 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11834 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11835 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11836 All callers changed.
11838 * w32.c (_wsa_errlist): Use braces for struct initializers.
11840 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11841 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11842 All callers changed.
11843 (string_buffer_position): Likewise. Also, make static (it's never
11844 used outside xdisp.c).
11845 (cursor_row_p): Remove parameter `w', unused since
11846 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11847 (decode_mode_spec): Remove parameter `precision', introduced during
11848 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11849 All callers changed.
11851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11853 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11855 2011-03-27 Anders Lindgren <andlind@gmail.com>
11857 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11858 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11859 (ns_update_auto_hide_menu_bar): New functions.
11860 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11861 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11862 ns_constrain_all_frames.
11863 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11864 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11866 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11868 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11870 2011-03-27 Glenn Morris <rgm@gnu.org>
11872 * syssignal.h: Replace RETSIGTYPE with void.
11873 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11874 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11875 Replace SIGTYPE with void everywhere.
11876 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11877 * s/template.h (SIGTYPE): Remove commented out definition.
11879 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11881 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11882 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11884 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11886 * w32.c (read_unc_volume): Use parameter `henum', instead of
11887 global variable `wget_enum_handle'.
11889 * keymap.c (describe_vector): Remove parameters `indices' and
11890 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11891 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11893 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11895 * keyboard.c (timer_check): Remove parameter `do_it_now',
11896 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11897 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11898 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11900 * keyboard.c (read_char):
11901 * w32menu.c (w32_menu_display_help):
11902 * xmenu.c (show_help_event, menu_help_callback):
11903 Adjust calls to `show_help_echo'.
11905 * gtkutil.c (xg_maybe_add_timer):
11906 * keyboard.c (readable_events):
11907 * process.c (wait_reading_process_output):
11908 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11910 * insdel.c (adjust_markers_gap_motion):
11911 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11912 (gap_left, gap_right): Don't call it.
11914 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11916 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11917 incurred during fontification.
11919 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11921 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11922 (DEFVAR_PER_BUFFER): Don't pass it.
11924 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11925 (scrolling_window): Don't pass it.
11927 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11929 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11931 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11933 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11934 of variables specific to SELinux and computation of `encoded_absname'.
11936 * image.c (XPutPixel): Remove unused variable `height'.
11938 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11940 * unexw32.c (get_section_info): Remove unused variable `section'.
11942 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11943 (system_process_attributes): Remove unused variable `sess'.
11944 (sys_read): Remove unused variable `err'.
11946 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11947 (w32_wnd_proc): Remove unused variable `isdead'.
11948 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11949 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11950 (x_create_tip_frame): Remove unused variable `tem'.
11952 * w32inevt.c (w32_console_read_socket):
11953 Remove unused variable `no_events'.
11955 * w32term.c (x_draw_composite_glyph_string_foreground):
11956 Remove unused variable `width'.
11958 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11960 * w32term.c (x_set_glyph_string_clipping):
11961 Don't pass uninitialized region to CombineRgn.
11963 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11965 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11966 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11967 (Fx_close_connection): Remove unused variable `i'.
11969 * w32font.c (w32font_draw): Return number of glyphs.
11970 (w32font_open_internal): Remove unused variable `i'.
11971 (w32font_driver): Add missing initializer.
11973 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11974 (fill_in_menu): Remove unused variable `items_added'.
11976 * w32term.c (last_mouse_press_frame): Remove static global variable.
11977 (w32_clip_to_row): Remove unused variable `f'.
11978 (x_delete_terminal): Remove unused variable `i'.
11980 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11981 (NOTHING): Remove unused static global variable.
11982 (uniscribe_check_otf): Remove unused variable `table'.
11983 (uniscribe_font_driver): Add missing initializers.
11985 2011-03-23 Julien Danjou <julien@danjou.info>
11987 * term.c (Fsuspend_tty, Fresume_tty):
11988 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11989 * window.c (temp_output_buffer_show):
11990 * insdel.c (signal_before_change):
11991 * frame.c (Fhandle_switch_frame):
11992 * fileio.c (Fdo_auto_save):
11993 * emacs.c (Fkill_emacs):
11994 * editfns.c (save_excursion_restore):
11995 * cmds.c (internal_self_insert):
11996 * callint.c (Fcall_interactively):
11997 * buffer.c (Fkill_all_local_variables):
11998 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12000 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12001 unconditionally since it does the check itself.
12003 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12005 Fix more problems found by GCC 4.5.2's static checks.
12007 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12008 the first time through the loop, since we know p0 < p1 then.
12009 This also avoids a gcc -Wstrict-overflow warning.
12011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12012 leading to a memory leak, possible in functions like
12013 load_charset_map_from_file that can allocate an unbounded number
12014 of objects (Bug#8318).
12016 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12017 that could (at least in theory) be that large.
12019 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12020 This is less likely to overflow, and avoids undefined behavior if
12021 overflow does occur. All callers changed. Use strtoul to scan
12022 for the unsigned long integer.
12023 (pint2hrstr): Simplify and tune code slightly.
12024 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12026 * scroll.c (do_scrolling): Work around GCC bug 48228.
12027 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12029 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12030 This also avoids a warning with gcc -Wstrict-overflow.
12031 (validate_x_resource_name): Simplify count usage.
12032 This also avoids a warning with gcc -Wstrict-overflow.
12034 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12037 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12039 * process.c (Fmake_network_process): Use socklen_t, not int,
12040 where POSIX says socklen_t is required in portable programs.
12041 This fixes a porting bug on hosts like 64-bit HP-UX, where
12042 socklen_t is wider than int (Bug#8277).
12043 (Fmake_network_process, server_accept_connection):
12044 (wait_reading_process_output, read_process_output):
12047 * process.c: Rename or move locals to avoid shadowing.
12048 (list_processes_1, Fmake_network_process):
12049 (read_process_output_error_handler, exec_sentinel_error_handler):
12050 Rename or move locals.
12051 (Fmake_network_process): Define label "retry_connect" only if needed.
12052 (Fnetwork_interface_info): Fix pointer signedness.
12053 (process_send_signal): Add cast to avoid pointer signedness problem.
12054 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12055 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12057 Make tparam.h and terminfo.c consistent.
12058 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12059 Include tparam.h instead, since it declares them.
12060 * cm.h (PC): Remove extern decl; tparam.h now does this.
12061 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12062 * terminfo.c: Include tparam.h, to check interfaces.
12063 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12064 (tparam): Adjust signature to match interface in tparam.h;
12065 this removes some undefined behavior. Check that outstring and len
12066 are zero, which they always are with Emacs.
12067 * tparam.h (PC, BC, UP): New extern decls.
12069 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12070 (xftfont_open): Rename locals to avoid shadowing.
12072 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12073 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12074 (OTF_TAG_SYM): Omit macro if not needed.
12075 (ftfont_list): Remove unused local.
12076 (get_adstyle_property, ftfont_pattern_entity):
12077 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12078 Rename locals to avoid shadowing.
12080 * xfont.c (xfont_list_family): Mark var as initialized.
12082 * xml.c (make_dom): Now static.
12084 * composite.c (composition_compute_stop_pos): Rename local to
12086 (composition_reseat_it): Remove unused locals.
12087 (find_automatic_composition, composition_adjust_point): Likewise.
12088 (composition_update_it): Mark var as initialized.
12089 (find_automatic_composition): Mark vars as initialized,
12090 with a FIXME (Bug#8290).
12092 character.h: Rename locals to avoid shadowing.
12093 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12094 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12095 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12096 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12097 to avoid shadowing.
12099 * textprop.c (property_change_between_p): Remove; unused.
12101 * intervals.c (interval_start_pos): Now static.
12103 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12105 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12106 Rename locals to avoid shadowing.
12108 * sound.c (wav_play, au_play, Fplay_sound_internal):
12109 Fix pointer signedness.
12110 (alsa_choose_format): Remove unused local var.
12111 (wav_play): Initialize a variable to 0, to prevent undefined
12112 behavior (Bug#8278).
12114 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12116 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12119 clobbering (Bug#8298).
12120 * sysdep.c (sys_subshell): Likewise.
12121 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12123 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12124 This should get cleaned up, so that child_setup has the
12125 same signature on all platforms.
12127 * callproc.c (call_process_cleanup): Now static.
12128 (relocate_fd): Rename locals to avoid shadowing.
12130 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12132 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12133 not to be necessary, and produces flickering.
12135 2011-03-20 Glenn Morris <rgm@gnu.org>
12137 * config.in: Remove file.
12139 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12141 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12142 are now in src/globals.h.
12143 (syms_of_minibuf): Remove spurious & from previous change.
12145 2011-03-20 Leo Liu <sdl.web@gmail.com>
12147 * minibuf.c (completing-read-function): New variable.
12148 (completing-read-default): Rename from completing-read.
12149 (completing-read): Call completing-read-function.
12151 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12153 * xfaces.c (Fx_load_color_file):
12154 Read color file from absolute filename (bug#8250).
12156 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12158 * makefile.w32-in: Update dependencies.
12160 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12162 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12164 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12166 Fix more problems found by GCC 4.5.2's static checks.
12168 * process.c (make_serial_process_unwind, send_process_trap):
12169 (sigchld_handler): Now static.
12171 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12172 That way, the code declares only the vars that it needs.
12173 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12174 * s/cygwin.h (PTY_ITERATION): Likewise.
12175 * s/darwin.h (PTY_ITERATION): Likewise.
12176 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12178 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12179 * process.c (allocate_pty): Don't declare stb unless it's needed.
12181 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12182 (CONSTANTLIM): Remove; unused.
12183 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12184 Define only if needed.
12186 * unexelf.c (unexec): Name an expression,
12187 to avoid gcc -Wbad-function-cast warning.
12188 Use a different way to cause a compilation error if anyone uses
12189 n rather than nn, a way that does not involve shadowing.
12190 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12192 * deps.mk (unexalpha.o): Remove; unused.
12194 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12195 * unexec.h: New file.
12196 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12197 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12198 Depend on unexec.h.
12199 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12200 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12201 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12202 Change as necessary to match prototype in unexec.h.
12204 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12206 (back_comment, skip_chars): Mark vars as initialized.
12208 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12209 Rename locals to avoid shadowing.
12211 * lread.c (read1): Rewrite so as not to use empty "else".
12212 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12214 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12216 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12217 warning when compiling print.c.
12219 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12220 instead of using an uninitialized var.
12221 (font_sort_entities): Mark var as initialized.
12223 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12225 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12226 pointers to constants.
12227 (font_parse_fcname): Remove unused vars.
12228 (font_delete_unmatched): Now static.
12229 (font_get_spec): Remove; unused.
12230 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12231 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12232 Rename or move locals to avoid shadowing.
12234 * fns.c (require_nesting_list, require_unwind): Now static.
12235 (Ffillarray): Rename locals to avoid shadowing.
12237 * floatfns.c (domain_error2): Define only if needed.
12238 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12240 * alloc.c (mark_backtrace): Move decl from here ...
12241 * lisp.h: ... to here, so that it can be checked.
12243 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12244 (Fdefvar): Rewrite so as not to use empty "else".
12245 (lisp_indirect_variable): Name an expression,
12246 to avoid gcc -Wbad-function-cast warning.
12247 (Fdefvar): Rename locals to avoid shadowing.
12249 * callint.c (quotify_arg, quotify_args): Now static.
12250 (Fcall_interactively): Rename locals to avoid shadowing.
12251 Use const pointer when appropriate.
12253 * lisp.h (get_system_name, get_operating_system_release):
12254 Move decls here, to check interfaces.
12255 * process.c (get_operating_system_release): Move decl to lisp.h.
12256 * xrdb.c (get_system_name): Likewise.
12257 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12258 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12259 some of which prompt warnings from gcc -Wbad-function-cast.
12260 (Fformat_time_string, Fencode_time, Finsert_char):
12261 (Ftranslate_region_internal, Fformat):
12262 Rename or remove local vars to avoid shadowing.
12263 (Ftranslate_region_internal): Mark var as initialized.
12265 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12268 * lisp.h (eassert): Check that the argument compiles, even if
12269 ENABLE_CHECKING is not defined.
12271 * data.c (Findirect_variable): Name an expression, to avoid
12272 gcc -Wbad-function-cast warning.
12273 (default_value, arithcompare, arith_driver, arith_error): Now static.
12274 (store_symval_forwarding): Rename local to avoid shadowing.
12275 (Fmake_variable_buffer_local, Fmake_local_variable):
12276 Mark variables as initialized.
12277 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12279 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12280 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12281 Rename locals to avoid shadowing.
12282 (mark_stack): Move local variables into the #ifdef region where
12284 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12285 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12287 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12288 (GC_STRING_CHARS): Remove; not used.
12289 (Fmemory_limit): Cast sbrk's returned value to char *.
12291 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12292 avoids undefined behavior in theory.
12294 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12296 Use functions, not macros, for up- and down-casing (Bug#8254).
12297 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12298 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12299 to use the following functions instead of these macros.
12300 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12301 EMACS_INT, since callers assume the returned value fits in int.
12302 (upcase1): Likewise, for UPCASE_TABLE.
12303 (uppercasep, lowercasep, upcase): New static inline functions.
12304 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12305 the race-condition problem in the old DOWNCASE.
12307 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12308 Rename locals to avoid shadowing.
12309 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12310 (regex_compile, re_search_2, re_match_2_internal):
12311 Remove unused local vars.
12312 (FREE_VAR): Rewrite so as not to use empty "else",
12313 which gcc can warn about.
12314 (regex_compile, re_match_2_internal): Mark locals as initialized.
12315 (RETALLOC_IF): Define only if needed.
12316 (WORDCHAR_P): Likewise. This one is never needed, but is used
12317 only in a comment talking about a compiler bug, so put inside
12318 the #if 0 of that comment.
12319 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12320 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12323 * search.c (boyer_moore): Rename locals to avoid shadowing.
12324 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12325 (PREV_CHAR_BOUNDARY): Likewise.
12327 * search.c (simple_search): Remove unused var.
12329 * dired.c (compile_pattern): Move decl from here ...
12330 * lisp.h: ... to here, so that it can be checked.
12331 (struct re_registers): New forward decl.
12333 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12335 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12337 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12338 Rename locals to avoid shadowing.
12339 (Fvertical_motion): Mark locals as initialized.
12341 * casefiddle.c (casify_object, casify_region): Now static.
12342 (casify_region): Mark local as initialized.
12344 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12346 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12347 New macros, so that the caller can use some names other than
12348 gcpro1, gcpro2, etc.
12349 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12351 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12352 argument, for consistency with GCPRO2_VAR, etc: it is now the
12353 prefix of the variable, not the variable itself. All uses
12355 * dired.c (directory_files_internal, file_name_completion):
12356 Rename locals to avoid shadowing.
12358 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12359 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12360 dired.c's scmp function, had undefined behavior.
12361 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12363 * buffer.h: ... to here, because these macros use current_buffer,
12364 and the new implementation with inline functions needs to have
12365 current_buffer in scope now, rather than later when the macros
12367 (downcase, upcase1): New static inline functions.
12368 (DOWNCASE, UPCASE1): Reimplement using these functions.
12369 This avoids undefined behavior in expressions like
12370 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12371 from race conditions in accessing the global variables
12372 case_temp1 and case_temp2.
12373 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12374 * lisp.h (case_temp1, case_temp2): Remove their decls.
12375 * character.h (ASCII_CHAR_P): Move from here ...
12376 * lisp.h: ... to here, so that the inline functions mentioned
12377 above can use them.
12379 * dired.c (directory_files_internal_unwind): Now static.
12381 * fileio.c (file_name_as_directory, directory_file_name):
12382 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12384 (file_name_as_directory): Use const pointers when appropriate.
12385 (Fexpand_file_name): Likewise. In particular, newdir might
12386 point at constant storage, so make it a const pointer.
12387 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12388 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12390 (Fset_file_times, Finsert_file_contents, auto_save_error):
12391 Rename locals to avoid shadowing.
12393 * minibuf.c (choose_minibuf_frame_1): Now static.
12394 (Ftry_completion, Fall_completions): Rename or remove locals
12395 to avoid shadowing.
12397 * marker.c (bytepos_to_charpos): Remove; unused.
12399 * lisp.h (verify_bytepos, count_markers): New decls,
12400 so that gcc does not warn that these functions aren't declared.
12402 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12403 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12404 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12405 (copy_text): Remove unused local var.
12407 * filelock.c (within_one_second): Now static.
12408 (lock_file_1): Rename local to avoid shadowing.
12410 * buffer.c (fix_overlays_before): Mark locals as initialized.
12411 (fix_start_end_in_overlays): Likewise. This function should be
12412 simplified by using pointers-to-pointers, but that's a different
12414 (switch_to_buffer_1): Now static.
12415 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12416 (report_overlay_modification): Rename locals to avoid shadowing.
12418 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12419 Fix pointer signedness issue.
12420 (sys_subshell): Mark local as volatile if checking for lint,
12421 to suppress a gcc -Wclobbered warning that does not seem to be right.
12422 (MAXPATHLEN): Define only if needed.
12424 * process.c (serial_open, serial_configure): Move decls from here ...
12425 * systty.h: ... to here, so that they can be checked.
12427 * fns.c (get_random, seed_random): Move extern decls from here ...
12428 * lisp.h: ... to here, so that they can be checked.
12430 * sysdep.c (reset_io): Now static.
12431 (wait_for_termination_signal): Remove; unused.
12433 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12434 (copy_keymap_item, append_key, push_text_char_description):
12436 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12437 (DENSE_TABLE_SIZE): Remove; unused.
12438 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12439 (describe_map_tree):
12440 Rename locals to avoid shadowing.
12442 * keyboard.c: Declare functions static if they are not used elsewhere.
12443 (echo_char, echo_dash, cmd_error, top_level_2):
12444 (poll_for_input, handle_async_input): Now static.
12445 (read_char, kbd_buffer_get_event, make_lispy_position):
12446 (make_lispy_event, make_lispy_movement, apply_modifiers):
12447 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12448 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12449 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12450 (read_key_sequence, read_char): Mark locals as initialized.
12451 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12453 * keyboard.h (make_ctrl_char): New decl.
12454 (mark_kboards): Move decl here ...
12455 * alloc.c (mark_kboards): ... from here.
12457 * lisp.h (force_auto_save_soon): New decl.
12459 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12460 (DEFINE_DUMMY_FUNCTION): New macro.
12461 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12463 (main): Add casts to avoid warnings
12464 if GCC considers string literals to be constants.
12466 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12468 * dbusbind.c: Pointer signedness fixes.
12469 (xd_signature, xd_append_arg, xd_initialize):
12470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12472 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12473 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12475 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12476 if GCC considers string literals to be constants.
12477 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12479 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12481 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12482 (print_preprocess, print_object): New macro to fix last change.
12484 * print.c (print_preprocess): Don't forget font objects.
12486 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12488 * emacs.c (USAGE3): Doc fixes.
12490 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12492 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12495 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12497 * lisp.h (VWindow_system, Qfile_name_history):
12498 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12499 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12500 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12502 * w32select.c: Don't #include "keyboard.h".
12503 (run_protected): Add extern declaration for waiting_for_input.
12505 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12506 * w32console.c (detect_input_pending, read_input_pending)
12507 (encode_terminal_code):
12508 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12509 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12510 (w32_system_caret_y, Qfile_name_history):
12511 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12512 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12513 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12514 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12515 * w32proc.c (Qlocal, report_file_error):
12516 * w32term.c (Vwindow_system, updating_frame):
12517 * w32uniscribe.c (initialized, uniscribe_font_driver):
12518 Remove unneeded extern declarations.
12520 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12522 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12524 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12526 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12527 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12528 These macros can no longer be used for assignment.
12530 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12531 Assign struct members directly, instead of using BUF_BEGV etc.
12532 (record_buffer_markers, fetch_buffer_markers): New functions for
12533 recording and fetching special buffer markers.
12534 (set_buffer_internal_1, set_buffer_temp): Use them.
12536 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12538 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12540 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12541 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12543 * xdisp.c (hscroll_window_tree):
12544 (reconsider_clip_changes): Use PT instead of BUF_PT.
12546 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12548 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12549 $(EMACS_ROOT)/lib/intprops.h.
12551 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12553 Fix more problems found by GCC 4.5.2's static checks.
12555 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12556 to unsigned char * to avoid compiler diagnostic.
12557 (xg_free_frame_widgets): Make it clear that a local variable is
12558 needed only if USE_GTK_TOOLTIP.
12559 (gdk_window_get_screen): Make it clear that this macro is needed
12560 only if USE_GTK_TOOLTIP.
12561 (int_gtk_range_get_value): New function, which avoids a diagnostic
12562 from gcc -Wbad-function-cast.
12563 (xg_set_toolkit_scroll_bar_thumb): Use it.
12564 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12565 diagnostic from gcc -Wbad-function-cast.
12566 (get_utf8_string, xg_get_file_with_chooser):
12567 Rename locals to avoid shadowing.
12568 (create_dialog): Move locals to avoid shadowing.
12570 * xgselect.c (xg_select): Remove unused var.
12572 * image.c (four_corners_best): Mark locals as initialized.
12573 (gif_load): Initialize transparent_p to zero (Bug#8238).
12574 Mark another local as initialized.
12575 (my_png_error, my_error_exit): Mark with NO_RETURN.
12577 * image.c (clear_image_cache): Now static.
12578 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12579 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12580 (x_edge_detection): Remove unnecessary cast that
12581 gcc -Wbad-function-cast diagnoses.
12582 (gif_load): Fix pointer signedness.
12583 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12584 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12586 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12588 Improve quality of tests for time stamp overflow.
12589 For example, without this patch (encode-time 0 0 0 1 1
12590 1152921504606846976) returns the obviously-bogus value (-948597
12591 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12592 reports time overflow. See
12593 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12594 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12595 * editfns.c: Include limits.h and intprops.h.
12596 (TIME_T_MIN, TIME_T_MAX): New macros.
12597 (time_overflow): Move earlier, to before first use.
12598 (hi_time, lo_time): New functions, for an accurate test for
12599 out-of-range times.
12600 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12601 (Fget_internal_run_time): Don't assume time_t fits in int.
12602 (make_time): Use list2 instead of Fcons twice.
12603 (Fdecode_time): More accurate test for out-of-range times.
12604 (check_tm_member): New function.
12605 (Fencode_time): Use it, to test for out-of-range times.
12606 (lisp_time_argument): Don't rely on undefined left-shift and
12607 right-shift behavior when checking for time stamp overflow.
12609 * editfns.c (time_overflow): New function, refactoring common code.
12610 (Fformat_time_string, Fdecode_time, Fencode_time):
12611 (Fcurrent_time_string): Use it.
12613 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12614 * dired.c (make_time): Move to ...
12615 * editfns.c (make_time): ... here.
12616 * systime.h: Note the move.
12618 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12620 * fringe.c (update_window_fringes): Remove unused variables.
12622 * unexmacosx.c (copy_data_segment): Also copy __got section.
12625 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12627 * termcap.c [MSDOS]: Include "msdos.h".
12628 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12629 Constify `char *' arguments and their references according to
12630 prototypes in tparam.h.
12632 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12634 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12635 Adapt all references accordingly.
12637 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12639 2011-03-11 Tom Tromey <tromey@redhat.com>
12641 * buffer.c (syms_of_buffer): Remove obsolete comment.
12643 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12645 * termhooks.h (encode_terminal_code): Declare prototype.
12647 * msdos.c (encode_terminal_code): Don't declare prototype.
12649 * term.c (encode_terminal_code): Now external again, used by
12650 w32console.c and msdos.c.
12652 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12653 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12655 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12657 Fix some minor problems found by GCC 4.5.2's static checks.
12659 * fringe.c (update_window_fringes): Mark locals as initialized
12661 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12663 * alloc.c (mark_fringe_data): Move decl from here ...
12664 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12665 to check its interface.
12666 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12668 * fontset.c (free_realized_fontset): Now static.
12669 (Fset_fontset_font): Rename local to avoid shadowing.
12670 (fontset_font): Mark local as initialized.
12671 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12673 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12675 * xselect.c (x_disown_buffer_selections): Remove; not used.
12676 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12677 (x_own_selection, Fx_disown_selection_internal): Rename locals
12678 to avoid shadowing.
12679 (x_handle_dnd_message): Remove local to avoid shadowing.
12681 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12682 so that the caller can use some name other than gcpro1.
12683 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12684 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12685 (Fx_backspace_delete_keys_p):
12686 Use them to avoid shadowing, and rename vars to avoid shadowing.
12687 (x_decode_color, x_set_name, x_window): Now static.
12688 (Fx_create_frame): Add braces to silence GCC warning.
12689 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12690 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12691 Remove unused locals.
12692 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12693 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12694 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12697 * xterm.h (x_mouse_leave): New decl.
12699 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12700 Remove unused functions.
12701 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12702 (x_calc_absolute_position): Now static.
12703 (XTread_socket): Don't define label "out" unless it's used.
12704 Don't declare local "event" unless it's used.
12705 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12706 unless they are used.
12707 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12708 (x_fatal_error_signal): Remove; not used.
12709 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12710 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12711 (x_error_catcher, x_connection_closed, x_error_handler):
12712 (x_error_quitter, xembed_send_message, x_iconify_frame):
12713 (my_log_handler): Rename locals to avoid shadowing.
12714 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12715 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12717 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12718 Rename or move locals to avoid shadowing.
12719 (tty_defined_color, merge_face_heights): Now static.
12720 (free_realized_faces_for_fontset): Remove; not used.
12721 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12722 does not deduce is never used uninitialized.
12723 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12724 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12726 * terminal.c (store_terminal_param): Now static.
12728 * xmenu.c (menu_highlight_callback): Now static.
12729 (set_frame_menubar): Remove unused local.
12730 (xmenu_show): Rename parameter to avoid shadowing.
12731 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12732 since they might point to immutable storage.
12733 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12734 since it's unused otherwise.
12736 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12737 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12738 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12739 avoids a gcc -Wuninitialized diagnostic.
12740 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12741 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12742 does not deduce are never used uninitialized.
12744 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12746 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12747 * window.c (window_loop, size_window):
12748 (run_window_configuration_change_hook, enlarge_window): Likewise.
12750 * window.c (display_buffer): Now static.
12751 (size_window): Mark variables that gcc -Wuninitialized
12752 does not deduce are never used uninitialized.
12753 * window.h (check_all_windows): New decl, to forestall
12754 gcc -Wmissing-prototypes diagnostic.
12755 * dispextern.h (bidi_dump_cached_states): Likewise.
12757 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12759 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12760 Include <limits.h>.
12761 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12762 and to avoid gcc -Wuninitialized warning.
12763 (load_charset_map): Mark variables that gcc -Wuninitialized
12764 does not deduce are never used uninitialized.
12765 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12767 * coding.c (coding_set_source, coding_set_destination):
12768 Use "else { /* comment */ }" rather than "else /* comment */;"
12769 for clarity, and to avoid gcc -Wempty-body warning.
12770 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12771 a block, when the outer 'i' will do.
12772 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12773 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12775 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12776 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12777 Rename locals to avoid shadowing.
12778 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12779 * coding.c (emacs_mule_char, encode_invocation_designation):
12780 Now static, since they're not used elsewhere.
12781 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12782 (decode_coding_object, encode_coding_object, detect_coding_system):
12783 (decode_coding_emacs_mule): Mark variables that gcc
12784 -Wuninitialized does not deduce are never used uninitialized.
12785 (detect_coding_iso_2022): Initialize a local variable that might
12786 be used uninitialized. Leave a FIXME because it's not clear that
12787 this initialization is needed. (Bug#8211)
12788 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12789 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12790 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12791 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12792 Remove unused macros.
12794 * category.c (hash_get_category_set): Remove unused local var.
12795 (copy_category_table): Now static, since it's not used elsewhere.
12796 * character.c (string_count_byte8): Likewise.
12798 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12799 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12801 * chartab.c (copy_sub_char_table): Now static, since it's not used
12803 (sub_char_table_ref_and_range, char_table_ref_and_range):
12804 Rename locals to avoid shadowing.
12805 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12807 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12808 (BIDI_BOB): Remove unused macro.
12810 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12811 deduce are never used uninitialized.
12812 * term.c (encode_terminal_code): Likewise.
12814 * term.c (encode_terminal_code): Now static. Remove unused local.
12816 * tparam.h: New file.
12817 * term.c, tparam.h: Include it.
12818 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12819 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12820 Move these decls to tparam.h, and make them agree with what
12821 is actually in tparam.c. The previous trick of using incompatible
12822 decls in different modules does not conform to the C standard.
12823 All callers of tparam changed to use tparam's actual API.
12824 * tparam.c (tparam1, tparam, tgoto):
12825 Use const pointers where appropriate.
12827 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12828 * cm.h (struct cm): Likewise.
12829 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12830 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12831 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12832 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12833 (turn_on_face, init_tty): Likewise.
12834 * termchar.h (struct tty_display_info): Likewise.
12836 * term.c (term_mouse_position): Rename local to avoid shadowing.
12838 * alloc.c (mark_ttys): Move decl from here ...
12839 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12841 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12843 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12845 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12847 * search.c (compile_pattern_1): Remove argument regp, unused since
12848 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12849 (compile_pattern): Don't pass it.
12851 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12853 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12854 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12856 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12858 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12860 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12861 gdk_window_get_screen, gdk_window_get_geometry,
12862 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12863 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12864 (xg_get_pixbuf_from_pixmap): New function.
12865 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12866 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12867 Call xg_get_pixbuf_from_pixmap instead of
12868 gdk_pixbuf_get_from_drawable.
12869 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12870 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12871 (xg_check_special_colors): Use GtkStyleContext and its functions
12873 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12874 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12875 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12876 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12877 Call gtk_widget_get_preferred_size.
12878 (xg_frame_resized): gdk_window_get_geometry only takes 5
12880 (xg_win_to_widget, xg_event_is_for_menubar):
12881 Call gdk_x11_window_lookup_for_display.
12882 (xg_set_widget_bg): New function.
12883 (delete_cb): New function.
12884 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12885 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12886 (xg_set_background_color): Call xg_set_widget_bg.
12887 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12888 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12889 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12890 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12892 (update_frame_tool_bar): Call gtk_widget_hide.
12893 (xg_initialize): Use GDK_KEY_g.
12895 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12897 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12899 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12900 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12901 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12903 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12905 * w32xfns.c (select_palette): Check success of RealizePalette against
12906 GDI_ERROR, not zero.
12908 See ChangeLog.11 for earlier changes.
12910 ;; Local Variables:
12914 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12916 This file is part of GNU Emacs.
12918 GNU Emacs is free software: you can redistribute it and/or modify
12919 it under the terms of the GNU General Public License as published by
12920 the Free Software Foundation, either version 3 of the License, or
12921 (at your option) any later version.
12923 GNU Emacs is distributed in the hope that it will be useful,
12924 but WITHOUT ANY WARRANTY; without even the implied warranty of
12925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12926 GNU General Public License for more details.
12928 You should have received a copy of the GNU General Public License
12929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.