* font.c (font_style_to_value, font_style_symbolic)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
af5a5a98
AS
12012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2
c5e4379c
AS
3 * font.c (font_style_to_value, font_style_symbolic)
4 (font_prop_validate_style): Add type checks for values in
5 font_style_table.
6
af5a5a98
AS
7 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
8 argument.
9 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
10 uses.
11
8d38f461
EZ
122012-06-29 Eli Zaretskii <eliz@gnu.org>
13
2e5a6631
EZ
14 * xdisp.c (try_window_id): Undo last change.
15
8d38f461
EZ
16 * w32.c (getwd): Adjust commentary about startup_dir.
17 (init_environment): Always call sys_access, even in non-MSVC
18 builds. Don't chdir to the directory of the Emacs executable.
19 This undoes code from 1997 which was justified by the need to
20 "avoid conflicts when removing and renaming directories". But its
21 downside was that every relative file name was being interpreted
22 relative to the directory of the Emacs executable, which can never
23 be TRT. In particular, it broke sys_access when called with
24 relative file names.
25 (sys_access): Map GetLastError to errno.
26
2af3565e
DA
272012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
28
29 * window.h (struct window): Change type of 'fringes_outside_margins'
30 to bitfield. Fix comment. Adjust users accordingly.
31 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
32 Adjust comment.
33 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
34 to ptrdiff_t.
35
c8d3a25c 362012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 37
c8d3a25c
GM
38 * gnutls.c (emacs_gnutls_handshake):
39 Add QUIT to make the loop interruptible.
57570cd3 40
c8d3a25c 412012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 42
c8d3a25c
GM
43 * charset.c (init_charset): Make lack of etc/charsets fatal.
44
3e984ee8
DA
452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
46
47 * editfns.c (region_limit): Fix type mismatch.
48
ef884f23
DA
492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
50
51 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
52 undefined. Convert from xassert to eassert.
53 * nsmenu.m: Convert from xassert to eassert.
54 * nsterm.m: Likewise.
55
7d7e0027
SM
562012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
57
58 * editfns.c (region_limit): Clip to narrowing (bug#11770).
59
aa754e6a
PE
602012-06-28 Paul Eggert <eggert@cs.ucla.edu>
61
62 Avoid integer overflow on scroll-left and scroll-right.
63 * window.c (HSCROLL_MAX): New macro.
64 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
65 overflow when requested scroll falls outside ptrdiff_t range.
66
80b00b08
DA
672012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
68
69 * window.h (struct window): Change type of 'hscroll',
70 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
71 'last_modified' and 'last_overlay_modified' to EMACS_INT.
72 Adjust users accordingly.
73 * xdisp.c (try_cursor_movement): Replace type check with eassert.
74 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
75 from EMACS_INT to ptrdiff_t.
76 (make_window): Omit redundant initialization.
77
62b2bcf6
JB
782012-06-28 Juanma Barranquero <lekktu@gmail.com>
79
80 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
81
45942c7d
DA
822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
83
84 * window.h (struct window): Change type of 'use_time' and
85 'sequence_number' from Lisp_Object to int.
86 * frame.c (make_frame): Adjust users accordingly.
87 * print.c (print_object): Likewise.
88 * window.c (select_window, Fwindow_use_time, make_parent_window)
89 (make_window): Likewise.
90
e509cfa6
DA
912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
92
93 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
94 enabled with --enable-checking=[all,glyphs] configure option.
95 Fix GLYPH_DEBUG usage assuming that it may be undefined,
96 adjust comments accordingly.
97 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
98 undefined, adjust comments accordingly.
99 * image.c: Likewise.
100 * scroll.c: Likewise.
101 * w32fns.c: Likewise.
102 * w32term.c: Likewise.
103 * xdisp.c: Likewise.
104 * xfaces.c: Likewise.
105 * xfns.c: Likewise.
106 * xterm.c: Likewise.
107
a54e2c05
DA
1082012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Generalize run-time debugging checks.
111 * dispextern.h (XASSERTS): Remove.
112 * fontset.c (xassert): Remove.
113 Convert from xassert to eassert.
114 * alloc.c: Convert from xassert to eassert.
115 * bidi.c: Likewise.
116 * dispnew.c: Likewise.
117 * fns.c: Likewise.
118 * fringe.c: Likewise.
119 * ftfont.c: Likewise.
120 * gtkutil.c: Likewise.
121 * image.c: Likewise.
122 * keyboard.c: Likewise.
123 * menu.c: Likewise.
124 * process.c: Likewise.
125 * scroll.c: Likewise.
126 * sound.c: Likewise.
127 * term.c: Likewise.
128 * w32console.c: Likewise.
129 * w32fns.c: Likewise.
130 * w32term.c: Likewise.
131 * window.c: Likewise.
132 * xdisp.c: Likewise.
133 * xfaces.c: Likewise.
134 * xfns.c: Likewise.
135 * xselect.c: Likewise.
136 * xterm.c: Likewise.
137
1ec4b7b2
SM
1382012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
139
140 * fns.c (maybe_resize_hash_table): Output message when growing the
141 purify-hashtable.
142
2014308a
DA
1432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
144
145 * alloc.c (allocate_string_data): Remove dead code.
146 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
147 avoid GCC warning about unused macro.
148
246155eb
DA
1492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
150
151 * alloc.c (allocate_string): Omit intervals initialization.
152 * alloc.c (make_uninit_multibyte_string): Initialize intervals
153 as in make_pure_string and make_pure_c_string.
154
43184b7b
DA
1552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
156
157 * alloc.c (allocate_string): Fix last change.
158
3fe6dd74
DA
1592012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * alloc.c (allocate_string): Remove two redundant calls
162 to memset, add explicit initialization where appropriate.
163
1ba6038a
GM
1642012-06-27 Glenn Morris <rgm@gnu.org>
165
166 * lisp.mk (lisp): Remove paths.elc.
167
c89926a5
CY
1682012-06-27 Chong Yidong <cyd@gnu.org>
169
170 * doc.c (Fsubstitute_command_keys): Fix punctuation.
171
ed6b3510
JW
1722012-06-26 John Wiegley <johnw@newartisans.com>
173
1ec4b7b2 174 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
175 on Mac OS X Lion: __mod_init_func and __mod_term_func.
176
ed6b3510
JW
177 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
178 when building with Clang.
179
8edd4a2b
SM
1802012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
181
182 * eval.c (Fapply): Allow calling it with a single argument.
183
f6f62d1b
EZ
1842012-06-26 Eli Zaretskii <eliz@gnu.org>
185
186 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
187 _stricmp and _strnicmp.
188 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
189
62efea5e
DA
1902012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
191
192 * alloc.c (allocate_window): Zero out non-Lisp part of newly
193 allocated window.
194 (allocate_process): Likewise for new process.
8edd4a2b 195 (allocate_terminal): Change to use offsetof.
62efea5e
DA
196 (allocate_frame): Likewise.
197 * frame.c (make_frame): Omit redundant initialization.
198 * window.c (make_parent_window): Use memset.
199 (make_window): Omit redundant initialization.
200 * process.c (make_process): Omit redundant initialization.
201 * terminal.c (create_terminal): Likewise.
202
42997f4d
DA
2032012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * term.c (delete_tty): Remove redundant call to memset.
206
1130ecfc
DA
2072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
208
209 * alloc.c: Remove build_string.
210 * lisp.h: Define build_string as static inline. This provides
211 a better opportunity to optimize away calls to strlen when the
212 function is called with compile-time constant argument.
213 * image.c (imagemagick_error): Convert to build_string.
214 * w32proc.c (sys_spawnve): Likewise.
215 * xterm.c (x_term_init): Likewise.
216
cf38a720
PE
2172012-06-26 Paul Eggert <eggert@cs.ucla.edu>
218
99027bdd
PE
219 Use sprintf return value instead of invoking strlen on result.
220 In the old days this wasn't portable, since some sprintf
221 implementations returned char *. But they died out years ago and
222 Emacs already assumes sprintf returns int.
223 Similarly for float_to_string.
224 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
225 * ccl.c (ccl_driver):
226 * character.c (string_escape_byte8):
227 * data.c (Fnumber_to_string):
228 * doprnt.c (doprnt):
229 * print.c (print_object):
230 * xdisp.c (message_dolog):
231 * xfns.c (syms_of_xfns):
232 Use sprintf or float_to_string result to avoid need to call strlen.
233 * data.c (Fnumber_to_string):
234 Use make_unibyte_string, since the string must be ASCII.
235 * lisp.h, print.c (float_to_string): Now returns int length.
236 * term.c (produce_glyphless_glyph):
237 Use sprintf result rather than recomputing it.
238
cf38a720
PE
239 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
240 * Makefile.in (ALL_CFLAGS):
241 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
242 * gmalloc.c, regex.c: Include <config.h> unconditionally.
243
3511c784
DA
2442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
245
0a08eb21 246 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
247 strcasecmp if available.
248 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
249
fb7da12e
AS
2502012-06-25 Andreas Schwab <schwab@linux-m68k.org>
251
252 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
253 Avoid comma operator.
254 * menu.c (push_submenu_start, push_submenu_end)
255 (push_left_right_boundary, push_menu_pane): Likewise.
256 * msdos.c (dos_rawgetc): Likewise.
257
afa2ffd8
DA
2582012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
259
260 * xfns.c (xic_create_fontsetname): Remove redundant calls
261 to memset.
262
b3b4476b
PE
2632012-06-25 Paul Eggert <eggert@cs.ucla.edu>
264
4495ff38
PE
265 * gtkutil.c (get_utf8_string): Remove redundant assignment.
266 sprintf already null-terminates its output.
267
b3b4476b
PE
268 * xfns.c (x_window): Remove redundant cast.
269
b00876c9
DA
2702012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
271
272 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
273 `const char *' to `char *' to avoid compiler warning.
274
d188e26b
PE
2752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
276
885d1d74
PE
277 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
278 instead of truncating it to 63 (admittedly a generous limit).
279
d188e26b
PE
280 * process.c: Fix spelling and caps in comments.
281
e2f560b1
DN
2822012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
283
e86db54b 284 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
285 * sysdep.c (setpgrp): Remove definition, not used in this file.
286
7583a3a1
JB
2872012-06-24 Juanma Barranquero <lekktu@gmail.com>
288
289 * makefile.w32-in: Update dependencies.
290
696056c2
EZ
2912012-06-24 Eli Zaretskii <eliz@gnu.org>
292
293 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
294 (SYSTIME_H): Add nt/inc/sys/time.h.
295
296 * systime.h [WINDOWSNT]: Include sys/time.h.
297
298 * s/ms-w32.h (struct timespec): Definition moved from
299 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
300
845ca893
PE
3012012-06-24 Paul Eggert <eggert@cs.ucla.edu>
302
303 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
304 * buffer.h (buffer_slot_type_mismatch):
305 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
306 * eval.c (unwind_to_catch):
307 * image.c (my_png_error, my_error_exit):
308 * keyboard.c (quit_throw_to_read_char, user_error)
309 (Fexit_recursive_edit, Fabort_recursive_edit):
310 * lisp.h (die, args_out_of_range, args_out_of_range_3)
311 (wrong_type_argument, buffer_overflow, __executable_start)
312 (memory_full, buffer_memory_full, string_overflow, Fthrow)
313 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
314 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
315 (fatal):
316 (child_setup) [!DOS_NT]:
317 * lread.c (end_of_file_error, invalid_syntax):
318 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
319 * puresize.h (pure_write_error):
320 * search.c (matcher_overflow):
321 * sound.c (sound_perror, alsa_sound_perror):
322 * sysdep.c, syssignal.h (croak):
323 * term.c (maybe_fatal, vfatal):
324 * textprop.c (text_read_only):
325 * undo.c (user_error):
326 * unexmacosx.c (unexec_error):
327 * xterm.c (x_ins_del_lines, x_delete_glyphs):
328 Use _Noreturn rather than NO_RETURN.
329 No need for separate decl merely because of _Noreturn.
330 * sound.c (sound_warning, parse_sound):
331 Remove unnecessary forward decls.
332
f1dd8073
PE
3332012-06-24 Paul Eggert <eggert@cs.ucla.edu>
334
335 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
336 * lisp.h (WAIT_READING_MAX): New macro.
337 * dispnew.c (Fsleep_for, sit_for):
338 * keyboard.c (kbd_buffer_get_event):
339 * process.c (Faccept_process_output):
340 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
341 This improves on the previous patch, which introduced a bug
342 when time_t is unsigned and as wide as intmax_t.
343 See <http://bugs.gnu.org/9000#51>.
344
b82c1755
EZ
3452012-06-23 Eli Zaretskii <eliz@gnu.org>
346
347 * dispnew.c (sit_for, Fsleep_for):
348 * keyboard.c (kbd_buffer_get_event):
349 * process.c (Faccept_process_output): Avoid compiler warnings when
350 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
351
ca300656
JB
3522012-06-23 Juanma Barranquero <lekktu@gmail.com>
353
049ec95b
JB
354 * makefile.w32-in: Update dependencies.
355
ca300656
JB
356 * w32.c (ltime): Add return type and declare static.
357 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
358
db7b8d06
PE
3592012-06-23 Paul Eggert <eggert@cs.ucla.edu>
360
361 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
362 Privately reported by Herbert J. Skuhra.
363 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
364 All uses changed.
365 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
366 not make_lisp_timeval, when the argument is of type EMACS_TIME.
367
0bd8297f
EZ
3682012-06-23 Eli Zaretskii <eliz@gnu.org>
369
96512555
EZ
370 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
371 last argument of make_unibyte_string.
372
0bd8297f
EZ
373 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
374 language ID in the event parameters.
375
376 * w32term.c (w32_read_socket): Put the new keyboard codepage into
377 event.code, not the obscure "character set ID".
378
63def6b6
CY
3792012-06-23 Chong Yidong <cyd@gnu.org>
380
381 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
382
e8a02204
EZ
3832012-06-23 Eli Zaretskii <eliz@gnu.org>
384
388cdec0
EZ
385 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
386 * w32.c (fdutimens): New function.
387
388 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
389
390 * s/ms-w32.h (pselect): Redirect to sys_select.
391
392 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
393
e8a02204
EZ
394 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
395 in the logic of incrementing and decrementing the value of
396 use_relocatable_buffers.
397
d054f3fb
PE
3982012-06-23 Paul Eggert <eggert@cs.ucla.edu>
399
400 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
401 Privately reported by Herbert J. Skuhra.
402 [__FreeBSD__]: Remove "*/" typo after "#include".
403 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
404 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
405 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
406 Don't assume EMACS_TIME and struct timeval are the same type.
407
d35af63c
PE
4082012-06-22 Paul Eggert <eggert@cs.ucla.edu>
409
410 Support higher-resolution time stamps (Bug#9000).
411 The time stamps are only nanosecond-resolution at the C level,
412 since that's the best that any real-world system supports now.
413 But they are picosecond-resolution at the Lisp level, as that's
414 easy, and leaves room for future OS improvements.
415
416 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
417 (LIBES): Use it.
418
419 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
420 Don't get current time unless it's needed.
421
422 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
423 now provides it if it's absent.
424 (start_atimer): Port to higher-res time stamps.
425 Check for time stamp overflow. Don't get current time more
426 often than is needed.
427
428 * buffer.h (struct buffer): Buffer modtime now has high resolution.
429 Include systime.h, not time.h.
430 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
431
432 * dired.c: Include stat-time.h.
433 (Ffile-attributes): File times now have higher resolution.
434
435 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
436 (struct image): Timestamp now has higher resolution.
437
438 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
439 has at least microseconds now. All uses removed.
440 (update_frame, update_single_window, update_window, update_frame_1)
441 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
442
443 * editfns.c (time_overflow): Now extern.
444 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
445 (float-time, Fformat_time_string, Fcurrent_time_string)
446 (Fcurrent_time_zone): Accept and generate higher-resolution
447 time stamps.
448 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
449 (decode_time_components, lisp_seconds_argument): New functions.
450 (make_time): Now static.
451 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
452 Report an error if the time is invalid, rather than having the caller
453 do that.
454
455 * fileio.c: Include <stat-time.h>
456 (Fcopy_file): Copy higher-resolution time stamps.
457 Prefer to set the time stamp via a file descriptor if that works.
458 (Fset_file_times, Finsert_file_contents, Fwrite_region)
459 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
460 (Fvisited_file_modtime, Fset_visited_file_modtime):
461 Support higher-resolution time stamps.
462
463 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
464
465 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
466
467 * image.c (prepare_image_for_display, clear_image_cache)
468 (lookup_image): Port to higer-resolution time stamps.
469
470 * keyboard.c (start_polling, bind_polling_period):
471 Check for time stamp overflow.
472 (read_char, kbd_buffer_get_event, timer_start_idle)
473 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
474 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
475 Port to higher-resolution time stamps. Do not assume time_t is signed.
476 (decode_timer): New function. Timers are now vectors of length 9,
477 not 8, to accommodate the picosecond component.
478 (timer_check_2): Use it.
479
480 * nsterm.m (select_timeout, timeval_subtract): Remove.
481 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
482 as they're a bit more accurate and handle overflow better.
483 (ns_select): Change prototype to be compatible with pselect.
484 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
485 * nsterm.h (ns_select): Adjust prototype.
486
487 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
488 us-resolution time stamps.
489 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
490
491 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
492
493 * lisp.h (time_overflow): New decl.
494 (wait_reading_process_output): First arg is now intmax_t, not int,
495 to accommodate larger waits.
496
497 * process.h (struct Lisp_Process.read_output_delay):
498 Now counts nanoseconds, not microseconds.
499 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
500 EMACS_HAS_USECS.
501 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
502 (wait_reading_process_output):
503 Port to ns-resolution time stamps.
504 (Faccept_process_output, wait_reading_process_output):
505 Check for time stamp overflow. Do not assume time_t is signed.
506 (select_wrapper): Remove; we now use pselect.
507 (Fprocess_attributes): Now generates ns-resolution time stamps.
508
509 * sysdep.c: Include utimens.h. Don't include utime.h
510 or worry about struct utimbuf; gnulib does that for us now.
511 (gettimeofday): Remove; gnulib provides a substitute.
512 (make_timeval): New function.
513 (set_file_times): Now sets ns-resolution time stamps.
514 New arg FD; all uses changed.
515 (time_from_jiffies, ltime_from_jiffies, get_up_time)
516 (system_process_attributes):
517 Now returns ns-resolution time stamp. All uses changed.
518 Check for time stamp overflow.
519
520 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
521 provides a substitute now.
522
523 * systime.h: Include timespec.h rather than sys/time.h and time.h,
524 since it guarantees struct timespec.
525 (EMACS_TIME): Now struct timespec, so that we can support
526 ns-resolution time stamps.
527 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
528 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
529 (EMACS_USECS): Remove.
530 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
531 so multiply the arg by 1000 before storing it.
532 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
533 New macros.
534 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
535 Port to ns-resolution time stamps.
536 (EMACS_TIME_NEG_P): Remove; replaced by....
537 (EMACS_TIME_SIGN): New macro.
538 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
539 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
540 (set_file_times, make_time, lisp_time_argument): Adjust signature.
541 (make_timeval, make_lisp_time, decode_time_components): New decls.
542 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
543 that it mishandled time_t overflow. You can't compare by subtracting!
544 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
545 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
546
547 * term.c: Include <sys/time.h>.
548 (timeval_to_Time): New function, for proper overflow wraparound.
549 (term_mouse_position, term_mouse_click): Use it.
550
551 * undo.c (record_first_change): Support higher-resolution time stamps
552 in the undo buffer.
553 (Fprimitive_undo): Use them when restoring time stamps.
554
555 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
556 (w32_get_internal_run_time):
557 Port to higher-resolution Emacs time stamps.
558 (ltime): Now accepts single 64-bit integer, as that's more convenient
559 for callers.
560
561 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
562
563 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
564 for compatibility with pselect. Support ns-resolution time stamps.
565
566 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
567
568 * xselect.c (wait_for_property_change, x_get_foreign_selection):
569 Check for time stamp overflow, and support ns-resolution time stamps.
570
571 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
572 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
573 (timeval_subtract): Remove; no longer needed.
574 (XTflash, XTring_bell, x_wait_for_event):
575 Port to ns-resolution time stamps. Don't assume time_t is signed.
576
b6a92dfe
CY
5772012-06-22 Chong Yidong <cyd@gnu.org>
578
579 * xdisp.c (x_consider_frame_title): Revert last change.
580
d251c37c
EZ
5812012-06-22 Eli Zaretskii <eliz@gnu.org>
582
583 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
584 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
585 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
586 staticidx goes up to 1597 out of 1600 = 0x640.)
587
f10deafb
PE
5882012-06-20 Paul Eggert <eggert@cs.ucla.edu>
589
590 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
591 Otherwise, the umask might be mistakenly 0 while handling input signals.
592
ec6de1e2
SM
5932012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
594
595 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
596
28be1ada
DA
5972012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
600 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
601 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
602 access to `contents' member of Lisp_Vector objects with AREF and ASET
603 where appropriate.
604
c6bf3022
CY
6052012-06-19 Chong Yidong <cyd@gnu.org>
606
607 * frame.c (delete_frame): When selecting a frame on a different
608 text terminal, do not alter the terminal's top-frame.
609
610 * xdisp.c (format_mode_line_unwind_data): Record the target
611 frame's selected window and its terminal's top-frame.
612 (unwind_format_mode_line): Restore them.
613 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
614 Callers changed.
615 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
616 since tty frames can be explicitly named.
617 (prepare_menu_bars): Likewise.
618
619 * term.c (Ftty_top_frame): New function.
620
defd4196
PE
6212012-06-18 Paul Eggert <eggert@cs.ucla.edu>
622
623 Port byte-code-meter to modern targets.
624 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
625 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 626 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
627 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
628 (METER_1, METER_2): Simplify.
629
1053a871
SM
6302012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
631
632 * data.c (Fdefalias): Return `symbol' (bug#11686).
633
b7e8d081
MR
6342012-06-18 Martin Rudalics <rudalics@gmx.at>
635
636 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
637 gets killed during executing of this function (Bug#11665).
638 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
639 (Vkill_buffer_query_functions): In doc-string say that functions
640 run by this hook should not change the current buffer.
641
7ea2b339
PE
6422012-06-18 Paul Eggert <eggert@cs.ucla.edu>
643
644 Fix recently-introduced process.c problems found by static checking.
645 * process.c (write_queue_push, write_queue_pop, send_process):
646 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
647 (write_queue_pop): Fix pointer signedness problem.
648 (send_process): Remove unused local.
649
96a313a1
CY
6502012-06-17 Chong Yidong <cyd@gnu.org>
651
652 * xdisp.c (redisplay_internal): No need to redisplay terminal
653 frames that are not on top.
654
20ca2e94
TN
6552012-06-17 Troels Nielsen <bn.troels@gmail.com>
656
657 * process.c (make_process): Initialize write_queue.
658 (write_queue_push, write_queue_pop): New functions.
659 (send_process): Use them to maintain correct ordering of process
660 writes (Bug#10815).
661
9a900ca9
PE
6622012-06-17 Paul Eggert <eggert@cs.ucla.edu>
663
310fbfa8
PE
664 * lisp.h (eassert): Assume C89 or later.
665 This removes the need for CHECK.
666 (CHECK): Remove. Its comments about always evaluating its
667 argument were confusing, as 'eassert' typically does not evaluate
668 its argument.
669
27bb1ca4
PE
670 * coding.c (produce_chars): Use ptrdiff_t, not int.
671
9a900ca9
PE
672 * xterm.c (x_draw_underwave): Check for integer overflow.
673 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
674
41b7f8bc 6752012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
676
677 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
678 referenced (Bug#11583).
679
9b0e3eba
AA
6802012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
681
682 Implement wave-style variant of underlining.
683 * dispextern.h (face_underline_type): New enum.
684 (face): Add field for underline type.
685 * nsterm.m (ns_draw_underwave): New function.
686 (ns_draw_text_decoration): Use it.
687 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
688 New functions.
689 (x_draw_glyph_string): Use them.
690 * xfaces.c (Qline, Qwave): New Lisp objects.
691 (check_lface_attrs, merge_face_ref)
1053a871
SM
692 (Finternal_set_lisp_face_attribute, realize_x_face):
693 Handle wave-style underline face attributes.
9b0e3eba
AA
694 * xterm.c (x_draw_underwave): New function.
695 (x_draw_glyph_string): Use it.
696
0fb52f11
JB
6972012-06-16 Juanma Barranquero <lekktu@gmail.com>
698
699 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
700 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
701 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
702 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
703 ($(BLD)/w32select.$(O)): Update dependencies.
704
e5560ff7
AS
7052012-06-16 Andreas Schwab <schwab@linux-m68k.org>
706
707 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
708 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
709 * character.c (_fetch_multibyte_char_p): Remove.
710 * alloc.c: Include "character.h" before "buffer.h".
711 * bidi.c: Likewise.
712 * buffer.c: Likewise.
713 * bytecode.c: Likewise.
714 * callint.c: Likewise.
715 * callproc.c: Likewise.
716 * casefiddle.c: Likewise.
717 * casetab.c: Likewise.
718 * category.c: Likewise.
719 * cmds.c: Likewise.
720 * coding.c: Likewise.
721 * composite.c: Likewise.
722 * dired.c: Likewise.
723 * dispnew.c: Likewise.
724 * doc.c: Likewise.
725 * dosfns.c: Likewise.
726 * editfns.c: Likewise.
727 * emacs.c: Likewise.
728 * fileio.c: Likewise.
729 * filelock.c: Likewise.
730 * font.c: Likewise.
731 * fontset.c: Likewise.
732 * fringe.c: Likewise.
733 * indent.c: Likewise.
734 * insdel.c: Likewise.
735 * intervals.c: Likewise.
736 * keyboard.c: Likewise.
737 * keymap.c: Likewise.
738 * lread.c: Likewise.
739 * macros.c: Likewise.
740 * marker.c: Likewise.
741 * minibuf.c: Likewise.
742 * nsfns.m: Likewise.
743 * nsmenu.m: Likewise.
744 * print.c: Likewise.
745 * process.c: Likewise.
746 * regex.c: Likewise.
747 * region-cache.c: Likewise.
748 * search.c: Likewise.
749 * syntax.c: Likewise.
750 * term.c: Likewise.
751 * textprop.c: Likewise.
752 * undo.c: Likewise.
753 * unexsol.c: Likewise.
754 * w16select.c: Likewise.
755 * w32fns.c: Likewise.
756 * w32menu.c: Likewise.
757 * window.c: Likewise.
758 * xdisp.c: Likewise.
759 * xfns.c: Likewise.
760 * xmenu.c: Likewise.
761 * xml.c: Likewise.
762 * xselect.c: Likewise.
763
2f07e6af
EZ
7642012-06-16 Eli Zaretskii <eliz@gnu.org>
765
1053a871
SM
766 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
767 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 768 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
769 row.
770 (handle_face_prop): Use chunk-relative overlay string index when
771 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
772 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
773 the rightmost. (Bug#11720)
2f07e6af 774
29b83cec
AS
7752012-06-16 Andreas Schwab <schwab@linux-m68k.org>
776
777 * category.h (CHAR_HAS_CATEGORY): Define as inline.
778 (CATEGORY_MEMBER): Enforce 1/0 value.
779 * category.c (_temp_category_set): Remove.
780
4c5501e9
EZ
7812012-06-16 Eli Zaretskii <eliz@gnu.org>
782
783 * window.c (Fdelete_other_windows_internal)
784 (Fdelete_window_internal): Don't access frame's mouse highlight
785 info of the initial frame. (Bug#11677)
786
2b570124
PE
7872012-06-14 Paul Eggert <eggert@cs.ucla.edu>
788
e93864f9
PE
789 * .gdbinit (xgetint): Fix recently-introduced paren typo.
790 Assume USE_2_TAGS_FOR_INTS.
791 (xreload): Adjust $tagmask width to match recent lisp.h change.
792
2b570124
PE
793 Simplify lisp.h in minor ways that should not affect code.
794 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
795 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
796 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
797 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
798 (INTTYPEBITS): New macro, for clarity.
799 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
800 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
801 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
802 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
803 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
804
81755f69
JB
8052012-06-13 Juanma Barranquero <lekktu@gmail.com>
806
807 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
808
16192a57
GM
8092012-06-13 Glenn Morris <rgm@gnu.org>
810
811 * s/bsd-common.h (BSD4_3):
812 * s/usg5-4-common.h (USG5_4): No longer define; unused.
813
646b5f55
AS
8142012-06-13 Andreas Schwab <schwab@linux-m68k.org>
815
816 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
817 instead of union.
818 (XLI, XIL): Define.
1053a871
SM
819 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
820 Use them.
821 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 822 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 823 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
824 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
825 * frame.c (delete_frame): Remove outdated comment.
826 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
827 USE_LISP_UNION_TYPE.
828 (Fw32_unregister_hot_key): Likewise.
829 (Fw32_toggle_lock_key): Likewise.
830 * w32menu.c (add_menu_item): Likewise.
831 (w32_menu_display_help): Use XIL instead of checking
832 USE_LISP_UNION_TYPE.
833 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
834 (init_heap): Likewise.
835 * w32term.c (w32_read_socket): Update comment.
836
1d3823c9
GM
8372012-06-13 Glenn Morris <rgm@gnu.org>
838
c62ff706
GM
839 * s/usg5-4-common.h, src/s/unixware.h:
840 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
841
1d3823c9
GM
842 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
843
bfe3e0a2
PE
8442012-06-13 Paul Eggert <eggert@cs.ucla.edu>
845
846 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
847 * alloc.c (make_number) [!defined make_number]:
848 Remove, as lisp.h always defines this now.
849 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
850 (roundup_size): Verify that it is a power of 2.
851 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
852 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
853 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
854 -DUSE_LSB_TAG=0, to override the automatically-selected default.
855 USE_LSB_TAG now is always defined to be either 0 or 1.
856 All uses changed.
857 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
858 code works fine either way, and efficiency is not a concern here,
859 as the union type is for debugging, not for production.
860 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
861 Use an inline function on all platforms when using the union type,
862 since this is simpler and 'static inline' can be used portably
863 within Emacs now.
864 (LISP_INITIALLY_ZERO): New macro.
865 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
866 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
867
45fa9c0f
GM
8682012-06-12 Glenn Morris <rgm@gnu.org>
869
b4492cba
GM
870 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
871
872 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 873
45fa9c0f
GM
874 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
875 Move BROKEN_SIGIO to configure.
876
877 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
878 Move NO_TERMIO to configure.
879
0e25d334
CY
8802012-06-12 Chong Yidong <cyd@gnu.org>
881
882 * image.c (imagemagick_load_image): Use MagickFlattenImage if
883 MagickMergeImageLayers is undefined. Use pixel pusher loop if
884 MagickExportImagePixels is undefined.
885
43682bb6
PE
8862012-06-12 Paul Eggert <eggert@cs.ucla.edu>
887
888 * image.c (imagemagick_load_image): Remove unused label.
889
a9be7d2b
GM
8902012-06-11 Glenn Morris <rgm@gnu.org>
891
892 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
893 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
894 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
895 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
896
3017f87f
SM
8972012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
898
899 * alloc.c (make_byte_code): New function.
900 (Fmake_byte_code): Use it. Don't purify here.
901 * lread.c (read1): Use it as well to avoid extra allocation.
902
1b9b4cf4
CY
9032012-06-11 Chong Yidong <cyd@gnu.org>
904
905 * image.c (imagemagick_load_image): Implement transparency.
906
95988fcf
AS
9072012-06-10 Andreas Schwab <schwab@linux-m68k.org>
908
909 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
910 account for preceding backslashes. (Bug#11663)
911
cd4eb164
CY
9122012-06-09 Chong Yidong <cyd@gnu.org>
913
914 * term.c: Support italics in capable terminals (Bug#9652).
915 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
916 (turn_on_face): Output using TS_enter_italic_mode if available.
917 Don't handle unused blinking and alt-charset cases.
918 (turn_off_face): Handle italic case; discard unused tty_blinking_p
919 and tty_alt_charset_p cases.
920 (tty_capable_p, init_tty): Support italics.
921
922 * termchar.h (struct tty_display_info): Add field for italics.
923 Remove unused blink field.
924
925 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
926 Handle slant.
927
928 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
929 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
930 tty_alt_charset_p. Add tty_italic_p.
931
ff88beb8
MA
9322012-06-09 Michael Albinus <michael.albinus@gmx.de>
933
934 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
935 dbus_type_is_basic if available.
936 (xd_extract_signed, xd_extract_unsigned): Rename from
937 extract_signed and extract_unsigned, respectively. Adapt callers.
938
44286096
CY
9392012-06-09 Chong Yidong <cyd@gnu.org>
940
1682701f
CY
941 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
942
44286096
CY
943 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
944 case (Bug#9752).
945
d86feb17
PE
9462012-06-08 Paul Eggert <eggert@cs.ucla.edu>
947
948 * xdisp.c (vmessage): Treat frame message as multibyte.
949 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
950 would generate the diagnostic "Making \302\247 buffer-local while
951 let-bound!".
952
d5c20fe8
EZ
9532012-06-08 Eli Zaretskii <eliz@gnu.org>
954
955 * dispnew.c (showing_window_margins_p): Undo last change, which
956 was done due to an inadvertent commit.
957 (adjust_frame_glyphs_for_frame_redisplay): Do call
958 showing_window_margins_p.
959
513749ee
SM
9602012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
961
962 * eval.c (Fmake_var_non_special): New primitive.
963 (syms_of_eval): Defsubr it.
964 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
965
d4a8f5c1
JB
9662012-06-08 Juanma Barranquero <lekktu@gmail.com>
967
968 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
969 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
970
8bbbc977
EZ
9712012-06-08 Eli Zaretskii <eliz@gnu.org>
972
973 * alloc.c (allocate_vectorlike): Fix last change.
974
f3372c87
DA
9752012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
976
977 Block-based vector allocation of small vectors.
978 * lisp.h (struct vectorlike_header): New field `nbytes',
979 adjust comment accordingly.
980 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
981 to denote vector blocks. Adjust users (live_vector_p,
982 mark_maybe_pointer, valid_lisp_object_p) accordingly.
983 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
984 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
985 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
986 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
987 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
988 (roundup_size): New constant.
989 (struct vector_block): New data type.
990 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 991 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
992 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
993 (sweep_vectors): New functions.
994 (allocate_vectorlike): Return `zero_vector' as the only vector of
995 0 items. Allocate new vector from block if vector size is less than
996 or equal to VBLOCK_BYTES_MAX.
997 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
998 (init_alloc_once): Add call to init_vectors.
999
4f18a4ed
SM
10002012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1001
1002 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1003
86f158bc
PE
10042012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * doprnt.c (doprnt): Truncate multibyte char correctly.
1007 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1008 would mishandle a string argument "Xc" if X was a multibyte
1009 character of length 2: it would truncate after X's first byte
1010 rather than including all of X.
1011
c5cfcbe0
CY
10122012-06-06 Chong Yidong <cyd@gnu.org>
1013
1014 * buffer.c (word_wrap): Doc fix.
1015
c05cf390
PE
10162012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1019
0c3461de
GM
10202012-06-03 Glenn Morris <rgm@gnu.org>
1021
1022 * xdisp.c (tool-bar-style): Doc fix.
1023
c71232db
UM
10242012-06-03 Ulrich Müller <ulm@gentoo.org>
1025
1026 * Makefile.in (PAXCTL): Define.
1027 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1028 binary via PaX flags if the paxctl utility is available.
1029 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1030 Restore PaX flags to their default. (Bug#11398)
1031
383f7350
CY
10322012-06-03 Chong Yidong <cyd@gnu.org>
1033
1034 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1035 buffer (Bug#11226).
1036
5f2c76c6
CY
10372012-06-03 Chong Yidong <cyd@gnu.org>
1038
1039 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1040 (note_mode_line_or_margin_highlight): If there is no help echo,
1041 use mode-line-default-help-echo. Handle the case where the mouse
1042 position is past the end of the mode line string.
1043
1044 * buffer.c (buffer_local_value_1): New function, split from
1045 Fbuffer_local_value; can return Qunbound.
1046 (Fbuffer_local_value): Use it.
1047 (Vmode_line_format): Docstring tweaks.
1048
773d47f6
PE
10492012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 * sysdep.c (system_process_attributes): Improve comment.
1052
f2d6a3df
SM
10532012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1054
1055 * keyboard.c: Export real-this-command to Elisp.
1056 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1057 and DEFVAR it. Update all users.
1058
63810350
PE
10592012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1060
7bd5c1f4
PE
1061 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1062
63810350
PE
1063 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1064 Convert pctcpu and pctmem to Lisp float properly.
1065 Let the compiler fold better, as 100.0/0x8000 is exact.
1066
a2821611
AS
10672012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1068
1069 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1070 cons_block.
1071
5fceba1d
PE
10722012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1075
c98ff5dd
DA
10762012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 For a 'struct window', replace some Lisp_Object fields to
1079 bitfields where appropriate, remove unused fields.
1080 * window.h (struct window): Remove unused 'last_mark_x' and
1081 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1082 change it's type from Lisp_Object to bitfield.
1083 Change type of 'force_start', 'optional_new_start',
1084 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1085 fields from Lisp_Object to bitfield. Adjust users accordingly.
1086
ca34e0be
PE
10872012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 Pacify gcc -Wdouble-precision when using Xaw.
1090 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1091 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1092 Use 'float' consistently, rather than 'float' in most places
1093 and 'double' in a couple of places.
1094
efc00ab1 10952012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1096
1097 * xdisp.c (handle_stop): Detect whether we have overlay strings
1098 loaded by testing it->current.overlay_string_index to be
1099 non-negative, instead of checking whether n_overlay_strings is
1100 positive. (Bug#11587)
1101
efc00ab1 11022012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1103
1104 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1105
1106 * doc.c (Fsubstitute_command_keys): Doc fix.
1107
efc00ab1 11082012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1109
1110 * search.c (search_buffer): Remove calls to
1111 r_alloc_inhibit_buffer_relocation, as it is now called by
1112 maybe_unify_char, which was the cause of relocation of buffer text
1113 in bug#11519.
1114
efc00ab1 11152012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1116
1117 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1118 for the duration of call to load_charset, to avoid problems with
1119 callers of maybe_unify_char that access buffer text through C
1120 pointers.
1121
1122 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1123 decrement the inhibition flag, instead of just setting or
1124 resetting it.
1125
ba93a187
PE
11262012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 Remove obsolete '#define static' cruft.
1129 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1130 This #undef was "temporary" in 2000; it is no longer needed
1131 now that '#define static' has gone away.
1132 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1133 (gray_bitmap_bits): Remove; no longer needed.
1134 All uses replaced with definiens.
1135 * xterm.c: Include "bitmaps/gray.xbm".
1136
9e4bf381
PE
11372012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Clean up __executable_start, monstartup when --enable-profiling.
1140 The following changes affect the code only when profiling.
1141 * dispnew.c (__executable_start): Rename from safe_bcopy.
1142 Define only on platforms that need it.
1143 * emacs.c: Include <sys/gmon.h> when profiling.
1144 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1145 (__executable_start): Remove decl, since lisp.h does it now.
1146 (safe_bcopy): Remove decl; no longer has that name.
1147 (main): Coalesce #if into single bit of code, for simplicity.
1148 Cast pointers to uintptr_t, since standard libraries want integers
1149 and not pointers.
1150 * lisp.h (__executable_start): New decl.
1151
32d72c2f
GM
11522012-05-31 Glenn Morris <rgm@gnu.org>
1153
1154 * image.c (Fimagemagick_types): Doc fix.
1155
baac5bc7
JM
11562012-05-30 Jim Meyering <meyering@redhat.com>
1157
1158 * callproc.c (Fcall_process_region): Include directory component
1159 in mkstemp error message (Bug#11586).
1160
72cb32cf
PE
11612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * alloc.c, lisp.h (make_pure_vector): Now static.
1164
61b108cc
SM
11652012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1168 Move to byte-run.el.
1169 (Fautoload): Do the hash-doc more carefully.
1170 * data.c (Fdefalias): Purify definition, except for keymaps.
1171 (Qdefun): Move from eval.c.
1172 * lisp.h (Qdefun): Remove.
1173 * lread.c (read1): Tiny simplification.
1174
471fe23d
TN
11752012-05-29 Troels Nielsen <bn.troels@gmail.com>
1176
934f3f58 1177 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1178 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1179 Bug#9642, but explicitly check that the buffer the overlay would
1180 be moved to is live and rearrange lines to make sure that errors
1181 will not put the overlay in an inconsistent state.
1182 (Fdelete_overlay): Cosmetics.
1183
85d0efd1
EZ
11842012-05-28 Eli Zaretskii <eliz@gnu.org>
1185
1186 * w32term.c (my_bring_window_to_top): New function.
1187 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1188 could be different from the original one.
1189 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1190 (Bug#11513)
1191
1192 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1193 by calling BringWindowToTop.
1194
1195 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1196 (WM_EMACS_END): Increase by one.
1197
da92a98c
PE
11982012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1201 This avoids undefined behavior that might cause the eassert
1202 to not catch an out-of-range value.
1203
74d1f848
JB
12042012-05-28 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1207 Update dependencies.
1208
9e1a06fc
EZ
12092012-05-27 Eli Zaretskii <eliz@gnu.org>
1210
1211 * bidi.c (bidi_mirror_char): Fix last change.
1212
f3dd7312
AS
12132012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1214
1215 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1216 when referring to sectname field in printf format.
1217
81899c91
PE
12182012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1219
57b81a9f
PE
1220 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1221 Only r_alloc_inhibit_buffer_relocation needed to be added;
1222 the others were already declared.
1223
81899c91
PE
1224 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1225 before checking whether it's out of range. Put the check inside
1226 eassert. See
1227 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1228
33017faf 12292012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1230
1231 * callproc.c (Fcall_process): Restore a line that was accidentally
1232 commented out in the 2011-02-13 change (bug#11547).
1233
33017faf 12342012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1235
1236 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1237 defined on ralloc.c.
1238
1239 * buffer.c [REL_ALLOC]: Remove prototypes of
1240 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1241 they are now on lisp.h.
1242
1243 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1244
1245 * search.c (search_buffer): Use it to inhibit relocation of buffer
1246 text while re_search_2 is doing its job, because re_search_2 is
1247 passed C pointers to buffer text. (Bug#11519)
1248
23415acf
EZ
1249 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1250 Update value to 24.
1251
44e27368
EZ
1252 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1253 state after an additional call to move_it_in_display_line_to, keep
1254 the values of it->max_ascent and it->max_descent found for the
1255 entire line.
1256 (pos_visible_p): Revert the comparison against bottom_y to what it
1257 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1258 (Bug#11464)
1259
c1892f11
PE
12602012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 Fix coding-related core dumps with gcc -ftrapv.
1263 The code was computing A - B, where A and B are pointers, and B is
1264 random garbage. This can lead to core dumps on platforms that
1265 have special pointer registers, and it also leads to core dumps on
1266 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1267 A - B only when B is initialized properly.
1268 * coding.c (coding_set_source, coding_set_destination): Return void.
1269 (coding_change_source, coding_change_destinations): New functions,
1270 with the old behaviors of coding_set_source and coding_set_destination.
1271 All callers that need an offset changed to use these new functions.
1272
eb7afdad
GM
12732012-05-26 Glenn Morris <rgm@gnu.org>
1274
1275 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1276
f12fdf02
EZ
12772012-05-26 Eli Zaretskii <eliz@gnu.org>
1278
53a63be6 1279 Extend mouse support on W32 text-mode console.
61b108cc
SM
1280 * xdisp.c (draw_row_with_mouse_face):
1281 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1282
eb3f6f01 1283 * w32console.c: Include window.h.
61b108cc
SM
1284 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1285 New functions.
eb3f6f01
EZ
1286 (initialize_w32_display): Initialize mouse-highlight data.
1287
53a63be6
EZ
1288 * w32inevt.c: Include termchar.h and window.h.
1289 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1290 moves, call note_mouse_highlight. If help_echo changed, call
1291 gen_help_event to produce help-echo message in the echo area.
1292 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1293 highlight info.
1294
4cfd81f6
PE
12952012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 * lread.c (read1): Simplify slightly to avoid an overflow warning
1298 with GCC 4.7.0 on x86-64.
1299
4446092a
EZ
13002012-05-26 Eli Zaretskii <eliz@gnu.org>
1301
1302 * bidi.c (bidi_mirror_char): Revert last change: an int is
1303 definitely wide enough here.
1304
42b2a986 13052012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1306
42b2a986 1307 Fix integer width and related bugs (Bug#9874).
eb106a49 1308 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1309 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1310 (string_bytes, check_sblock, allocate_string_data):
1311 (compact_small_strings, Fmake_bool_vector, make_string)
1312 (make_unibyte_string, make_multibyte_string)
1313 (make_string_from_bytes, make_specified_string)
1314 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1315 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1316 (mark_vectorlike):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 (allocate_pseudovector):
1319 Use int, not EMACS_INT, where int is wide enough.
1320 (inhibit_garbage_collection, Fgarbage_collect):
1321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1322 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1323 int might not be wide enough.
1324 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1325 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1326 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1327 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1328 (bidi_level_of_next_char, bidi_move_to_visually_next):
1329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1330 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1331 (Fkill_buffer, Fset_buffer_major_mode)
1332 (advance_to_char_boundary, Fbuffer_swap_text)
1333 (Fset_buffer_multibyte, overlays_at, overlays_in)
1334 (overlay_touches_p, struct sortvec, record_overlay_string)
1335 (overlay_strings, recenter_overlay_lists)
1336 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1337 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1338 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1339 (Foverlay_recenter, last_overlay_modification_hooks_used)
1340 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1342 (validate_region): Omit unnecessary test for b <= e,
1343 since that's guaranteed by the previous test.
d311d28c
PE
1344 (adjust_overlays_for_delete): Avoid pos + length overflow.
1345 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1346 (report_overlay_modification):
1347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1348 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1349 Omit pointer cast, which isn't needed anyway, and doesn't work
1350 after the EMACS_INT -> ptrdiff_t change.
02481186 1351 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1352 * buffer.h: Adjust decls to match defn changes elsewhere.
1353 (struct buffer_text, struct buffer):
1354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1355 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1356 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1357 not int, to avoid needless 32-bit limit on 64-bit hosts.
1358 (exec_byte_code): Use tighter memory-full test, one that checks
1359 for alloca overflow. Don't compute the address of the object just
1360 before an array, as that's not portable. Use EMACS_INT, not
1361 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1362 * callint.c (Fcall_interactively):
1363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1364 * callproc.c (call_process_kill, Fcall_process):
1365 Don't assume pid_t fits into an Emacs fixnum.
1366 (call_process_cleanup, Fcall_process, child_setup):
1367 Don't assume pid_t fits into int.
1368 (call_process_cleanup, Fcall_process, delete_temp_file)
1369 (Fcall_process_region):
1370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1371 (Fcall_process): Simplify handling of volatile integers.
1372 Use int, not EMACS_INT, where int will do.
1373 * casefiddle.c (casify_object, casify_region, operate_on_word)
1374 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 (casify_object): Avoid integer overflow when overallocating buffer.
1377 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1378 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1379 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1380 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1381 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1382 integers are now checked earlier. All uses replaced with XINT.
1383 (ccl_driver):
1384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1385 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1386 (ccl_driver, Fregister_code_conversion_map):
1387 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1388 (resolve_symbol_ccl_program): Check that vector header is in range.
1389 Always copy the vector, so that we can check its contents reliably
1390 now rather than having to recheck each instruction as it's being
1391 executed. Check that vector words fit in 'int'.
1392 (ccl_get_compiled_code, Fregister_ccl_program)
1393 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1394 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1395 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1396 contents are in range.
1397 (Fccl_execute_on_string): Check that status is in range.
1398 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1399 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1400 Accept and return EMACS_INT, not int, because callers can pass values
1401 out of 'int' range.
1402 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1403 (multibyte_chars_in_text, parse_str_as_multibyte)
1404 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1405 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1406 (string_escape_byte8, Fget_byte):
1407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1408 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1409 avoid mishandling large integers.
1410 * character.h: Adjust decls to match defn changes elsewhere.
1411 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1412 (Ffind_charset_region):
1413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1414 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1415 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1416 Don't assume fixnum fits in int.
d311d28c
PE
1417 (load_charset_map_from_vector, Fmap_charset_chars):
1418 Remove now-unnecessary CHECK_NATNUMs.
1419 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1420 Don't rely on undefined behavior with signed left shift overflow.
1421 Don't assume unsigned int fits into fixnum, or that fixnum fits
1422 into unsigned int. Don't require max_code to be a valid fixnum;
1423 that's not true for gb10830 4-byte on a 32-bit host. Allow
1424 invalid_code to be a cons, for the same reason. Require code_offset
1425 to be a character. Avoid int overflow if max_char is close
1426 to INT_MAX.
1427 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1428 this is intended anyway and avoids some undefined behavior.
1429 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1430 INDEX_TO_CODE_POINT, as that's what it expects.
1431 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1432 * charset.h (DECODE_CHAR): Return int, not unsigned;
1433 this is what was intended anyway, and it avoids undefined behavior.
1434 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1435 integer-overflow issues.
1436 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1437 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1438 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1439 * chartab.c (Fmake_char_table, Fset_char_table_range)
1440 (uniprop_get_decoder, uniprop_get_encoder):
1441 Don't assume fixnum fits in int.
1442 * cmds.c (move_point): New function, that does the gist of
1443 Fforward_char and Fbackward_char, but does so while checking
1444 for integer overflow more accurately.
c96e5d6a 1445 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1446 (Fforward_line, Fend_of_line, internal_self_insert)
1447 (internal_self_insert):
1448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1449 Fix a FIXME, by checking for integer overflow when calculating
1450 target_clm and actual_clm.
1451 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1452 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1453 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1454 (coding_alloc_by_making_gap, alloc_destination)
1455 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1456 (encode_coding_utf_16, detect_coding_emacs_mule)
1457 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1458 (detect_coding_iso_2022, decode_coding_iso_2022)
1459 (encode_invocation_designation, encode_designation_at_bol)
1460 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1461 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1462 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1463 (encode_coding_ccl, encode_coding_raw_text)
1464 (detect_coding_charset, decode_coding_charset)
1465 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1466 (produce_composition, produce_charset, produce_annotation)
1467 (decode_coding, handle_composition_annotation)
1468 (handle_charset_annotation, consume_chars, decode_coding_gap)
1469 (decode_coding_object, encode_coding_object, detect_coding_system)
1470 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1471 (code_convert_region, code_convert_string)
8f50130c
PE
1472 (Fdefine_coding_system_internal)
1473 (coding_set_source, coding_set_destination):
d311d28c
PE
1474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1475 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1476 (Fdefine_coding_system_internal):
1477 Don't assume fixnums fit in int.
1478 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1479 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1480 (Funencodable_char_position, Fcheck_coding_systems_region)
1481 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1483 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1484 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1485 Don't access memory outside of the args array.
d311d28c 1486 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1487 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1488 result of ENCODE_CHAR.
d311d28c
PE
1489 * coding.h: Adjust decls to match defn changes elsewhere.
1490 (struct coding_system):
1491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1492 * composite.c (get_composition_id, find_composition)
1493 (run_composition_function, update_compositions)
1494 (compose_text, composition_gstring_put_cache)
1495 (composition_gstring_p, composition_gstring_width)
1496 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1497 (composition_compute_stop_pos, composition_reseat_it)
1498 (composition_update_it, struct position_record)
1499 (find_automatic_composition, composition_adjust_point)
1500 (Fcomposition_get_gstring, Ffind_composition_internal):
1501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1502 (update_compositions):
1503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1504 * composite.h: Adjust decls to match defn changes elsewhere.
1505 (struct composition):
1506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1507 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1508 Do not attempt to compute the address of the object just before a
1509 buffer; this is not portable.
1510 (Faref, Faset):
1511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1512 (Faset): Use int, not EMACS_INT, where int is wide enough.
1513 (Fstring_to_number): Don't assume fixnums fit in int.
1514 (Frem): Don't assume arg is nonnegative.
1515 * dbusbind.c (xd_append_arg): Check for integers out of range.
1516 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1517 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1518 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1519 (xd_get_connection_references): Return ptrdiff_t, not int.
1520 All uses changed.
1521 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1522 (xd_read_message_1):
1523 Use int, not unsigned, where the dbus API uses int.
1524 (Fdbus_message_internal): Don't overflow mtype.
1525 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1526 * dired.c (directory_files_internal, file_name_completion, scmp)
1527 (file_name_completion_stat):
1528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1529 (file_name_completion): Don't overflow matchcount.
1530 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1531 * dispextern.h: Adjust decls to match defn changes elsewhere.
1532 (struct text_pos, struct glyph, struct bidi_saved_info)
1533 (struct bidi_string_data, struct bidi_it, struct composition_it)
1534 (struct it):
1535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1536 (struct display_pos, struct composition_it, struct it):
1537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1538 * dispnew.c (increment_matrix_positions)
1539 (increment_row_positions, mode_line_string)
1540 (marginal_area_string):
1541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1542 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (duration_to_sec_usec): New function, to check for overflow better.
1545 (Fsleep_for, sit_for): Use it.
1546 * doc.c (get_doc_string, store_function_docstring):
1547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1548 (get_doc_string, Fsnarf_documentation):
1549 Use int, not EMACS_INT, where int is wide enough.
1550 (get_doc_string):
1551 Use SAFE_ALLOCA, not alloca.
1552 Check for overflow when converting EMACS_INT to off_t.
1553 * doprnt.c (doprnt):
1554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1555 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1556 Don't assume uid_t fits into fixnum.
1557 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1558 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1559 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1560 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1561 (general_insert_function)
1562 (Finsert_char, make_buffer_string, make_buffer_string_both)
1563 (update_buffer_properties, Fbuffer_substring)
1564 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1565 (Fsubst_char_in_region, check_translation)
1566 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1567 (transpose_markers, Ftranspose_regions):
1568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1569 (clip_to_bounds): Move to lisp.h as an inline function).
1570 (Fconstrain_to_field): Don't assume integers are nonnegative.
1571 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1572 (Fsubst_char_in_region, Fsave_restriction):
1573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1574 (Femacs_pid): Don't assume pid_t fits into fixnum.
1575 (lo_time): Use int, not EMACS_INT, when int suffices.
1576 (lisp_time_argument): Check for usec out of range.
1577 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1578 (Fuser_login_name, Fuser_full_name): Signal an error
1579 if a uid argument is out of range, rather than relying on
1580 undefined behavior.
c8d5c857
PE
1581 (Fformat_time_string): Remove now-unnecessary check.
1582 lisp_time_argument checks for out-of-range usec now.
243e0530 1583 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1584 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1585 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1586 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1587 (init_cmdargs, Fdump_emacs):
1588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1589 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1590 the bottom (typically) 32 bits of the fixnum.
1591 * eval.c (specpdl_size, call_debugger):
1592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1593 (when_entered_debugger, Fbacktrace_debug):
1594 Don't assume fixnum can fit in int.
1595 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1596 the object just before a buffer; this is not portable.
1597 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1598 (grow_specpdl, unbind_to):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1601 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1602 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1603 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1604 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1606 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1607 (a_write, e_write):
1608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1609 (Fcopy_file, non_regular_nbytes, read_non_regular)
1610 (Finsert_file_contents):
1611 Use int, not EMACS_INT, where int is wide enough.
1612 (READ_BUF_SIZE): Verify that it fits in int.
1613 (Finsert_file_contents): Check that counts are in proper range,
1614 rather than assuming fixnums fit into ptrdiff_t etc.
1615 Don't assume fixnums fit into int.
125b3835 1616 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1617 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1618 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1619 (string_char_to_byte, string_byte_to_char)
1620 (string_make_multibyte, string_to_multibyte)
1621 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1622 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1623 (substring_both, Fdelete, internal_equal, Ffillarray)
1624 (Fclear_string, mapcar1)
1625 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1626 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1627 (larger_vector, make_hash_table, maybe_resize_hash_table)
1628 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1629 (Fmaphash, secure_hash):
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 (concat): Check for string index and length overflow.
1632 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1633 (Frequire):
1634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1635 (larger_vector): New API (vec, incr_min, size_max) replaces old
1636 one (vec, new_size, init). This catches size overflow.
1637 INIT was removed because it was always Qnil.
1638 All callers changed.
1639 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1640 the upper bound on a hash table index size.
1641 (make_hash_table, maybe_resize_hash_table): Use it.
1642 (secure_hash): Computer start_byte and end_byte only after
1643 they're known to be in ptrdiff_t range.
1644 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1645 (Ffont_get_glyphs, Ffont_at):
1646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1647 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1648 (Flist_fonts, Fopen_font):
1649 Don't assume fixnum can fit in int.
1650 (check_gstring): Don't assume index can fit in int.
1651 (font_match_p): Check that fixnum is a character, not a nonnegative
1652 fixnum, since the later code needs to stuff it into an int.
1653 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1654 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1655 conversion overflow issues.
1656 (Fopen_font): Check for integer out of range.
1657 (Ffont_get_glyphs): Don't assume index can fit in int.
1658 * font.h: Adjust decls to match defn changes elsewhere.
1659 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1660 integer overflow.
1661 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1662 printmax_t, where ptrdiff_t is wide enough.
1663 (Finternal_char_font):
1664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1665 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1666 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1667 (Fset_frame_position, x_set_frame_parameters)
1668 (x_set_line_spacing, x_set_border_width)
1669 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1670 Check that fixnums are in proper range for system types.
1671 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1673 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1674 Use SAFE_ALLOCA_LISP, not alloca.
1675 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1676 intptr_t is wide enough.
1677 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1678 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1679 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1680 Check for fixnum out of range.
1681 * ftfont.c (ftfont_list): Don't assume index fits in int.
1682 Check that fixnums are in proper range for system types.
1683 (ftfont_shape_by_flt):
1684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1685 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1687 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1688 Check that fixnums are in proper range for system types.
1689 * gnutls.h: Adjust decls to match defn changes elsewhere.
1690 * gtkutil.c (xg_dialog_run):
1691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1692 (update_frame_tool_bar):
1693 Check that fixnums are in proper range for system types.
1694 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1695 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1696 * indent.c (last_known_column, last_known_column_point):
1697 (current_column_bol_cache):
1698 (skip_invisible, current_column, check_display_width):
1699 (check_display_width, scan_for_column, current_column_1)
1700 (Findent_to, Fcurrent_indentation, position_indentation)
1701 (indented_beyond_p, Fmove_to_column, compute_motion):
1702 (Fcompute_motion, Fvertical_motion):
1703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1704 (last_known_column_modified): Use EMACS_INT, not int.
1705 (check_display_width):
1706 (Fcompute_motion):
1707 Check that fixnums and floats are in proper range for system types.
1708 (compute_motion): Don't assume index or fixnum fits in int.
1709 (compute_motion, Fcompute_motion):
1710 Use int, not EMACS_INT, when it is wide enough.
1711 (vmotion): Omit local var start_hpos that is always 0; that way
1712 we don't need to worry about overflow in expressions involving it.
1713 * indent.h: Adjust decls to match defn changes elsewhere.
1714 (struct position):
1715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1716 Use int, not EMACS_INT, where int is wide enough.
1717 Remove unused members ovstring_chars_done and tab_offset;
1718 all uses removed.
1719 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1720 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1721 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1722 (make_gap, copy_text, insert, insert_and_inherit)
1723 (insert_before_markers, insert_before_markers_and_inherit)
1724 (insert_1, count_combining_before, count_combining_after)
1725 (insert_1_both, insert_from_string)
1726 (insert_from_string_before_markers, insert_from_string_1)
1727 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1728 (adjust_after_replace, adjust_after_insert, replace_range)
1729 (replace_range_2, del_range, del_range_1, del_range_byte)
1730 (del_range_both, del_range_2, modify_region)
1731 (prepare_to_modify_buffer, signal_before_change)
1732 (signal_after_change, Fcombine_after_change_execute):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1735 (balance_an_interval, split_interval_right, split_interval_left)
1736 (find_interval, next_interval, update_interval)
1737 (adjust_intervals_for_insertion, delete_node, delete_interval)
1738 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1739 (static_offset_intervals, offset_intervals)
1740 (merge_interval_right, merge_interval_left, make_new_interval)
1741 (graft_intervals_into_buffer, temp_set_point_both)
1742 (temp_set_point, set_point, adjust_for_invis_intang)
1743 (set_point_both, move_if_not_intangible, get_property_and_range)
1744 (get_local_map, copy_intervals, copy_intervals_to_string)
1745 (compare_string_intervals, set_intervals_multibyte_1):
1746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1747 * intervals.h: Adjust decls to match defn changes elsewhere.
1748 (struct interval):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 * keyboard.c (this_command_key_count, this_single_command_key_start)
1751 (before_command_key_count, before_command_echo_length, echo_now)
1752 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1753 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1754 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1755 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1757 (last_non_minibuf_size, last_point_position, echo_truncate)
1758 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1759 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1760 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1761 (stuff_buffered_input):
1762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1763 (last_auto_save, command_loop_1, read_char):
1764 Use EMACS_INT, not int, to avoid integer overflow.
1765 (record_char): Avoid overflow in total_keys computation.
1766 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1767 * keyboard.h: Adjust decls to match defn changes elsewhere.
1768 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1769 (Fkey_description, Fdescribe_vector, Flookup_key):
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (click_position): New function, to check that positions are in range.
1772 (Fcurrent_active_maps):
1773 (describe_command):
1774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1775 (Faccessible_keymaps, Fkey_description):
1776 (preferred_sequence_p):
1777 Don't assume fixnum can fit into int.
1778 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1779 Check for integer overflow in size calculations.
1780 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1781 avoid mishandling large integers.
1782 * lisp.h: Adjust decls to match defn changes elsewhere.
1783 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1784 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1785 (struct Lisp_Marker):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1788 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1789 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1790 All callers changed.
1791 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1792 Assume the arg has valid form, since it always does.
1793 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1794 unsigned integer system type.
1795 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1796 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1798 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1799 (duration_to_sec_usec): New decl.
1800 * lread.c (read_from_string_index, read_from_string_index_byte)
1801 (read_from_string_limit, readchar, unreadchar, openp)
1802 (read_internal_start, read1, oblookup):
1803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1804 (Fload, readevalloop, Feval_buffer, Feval_region):
1805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1806 (openp): Check for out-of-range argument to 'access'.
1807 (read1): Use int, not EMACS_INT, where int is wide enough.
1808 Don't assume fixnum fits into int.
6efdadfd 1809 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1810 (read_filtered_event): Use duration_to_sec_usec
1811 to do proper overflow checking on durations.
d311d28c
PE
1812 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1813 in size calculation.
1814 (Fexecute_kbd_macro):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1817 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1818 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1819 (set_marker_both, set_marker_restricted_both, marker_position)
1820 (marker_byte_position, Fbuffer_has_markers_at):
1821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1822 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1823 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1824 It now merely ensures that the menu is large enough, without
1825 necessarily growing it, as this avoids some integer overflow issues.
1826 All callers changed.
1827 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1829 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1830 Use SAFE_ALLOCA_LISP, not alloca.
1831 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1832 to EMACS_INT. Check that fixnums are in proper range for system types.
1833 * minibuf.c (minibuf_prompt_width, string_to_object)
1834 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1835 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1837 (get_minibuffer, read_minibuf_unwind):
1838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1839 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1840 this simplifies overflow checking. All callers changed.
1841 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1842 (Ftest_completion):
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1845 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1846 Check that fixnums are in proper range for system types.
1847 (Fx_create_frame, Fx_show_tip):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 * nsfont.m (ns_findfonts, nsfont_list_family):
1850 Don't assume fixnum fits in long.
1851 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1853 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1854 wide enough.
17fdb222 1855 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1857 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1858 (PRINTDECLARE, PRINTPREPARE):
1859 (strout, print_string):
1860 (print, print_preprocess, print_check_string_charset_prop)
1861 (print_object):
1862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1863 (PRINTDECLARE):
1864 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1866 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1867 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1868 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1869 (print_error_message): Use SAFE_ALLOCA, not alloca.
1870 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1871 (print_depth, new_backquote_output, print_number_index):
1872 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1873 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1874 (Fset_process_window_size, Fformat_network_address)
1875 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1876 (sigchld_handler):
d311d28c 1877 Check that fixnums are in proper range for system types.
d44287d4 1878 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1879 Check for process-ids out of pid_t range rather than relying on
1880 undefined behavior.
e4d81efc 1881 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1882 (Fformat_network_address, read_process_output, send_process)
1883 (Fprocess_send_region, status_notify):
1884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1885 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1886 (wait_reading_process_output, read_process_output, exec_sentinel):
1887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1888 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1889 (Faccept_process_output): Use duration_to_sec_usec to do proper
1890 overflow checking on durations.
dde14581
PE
1891 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1892 Don't assume pid_t fits in int.
02481186
PE
1893 * process.h (struct Lisp_Process): Members tick and update_tick
1894 are now of type EMACS_INT, not int.
b62b53e8
PE
1895 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1896 configured --with-wide-int.
d311d28c
PE
1897 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1898 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1899 * search.c (looking_at_1, string_match_1):
1900 (fast_string_match, fast_c_string_match_ignore_case)
1901 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1902 (scan_newline, find_before_next_newline, search_command)
1903 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1904 (set_search_regs, wordify):
1905 (Freplace_match):
1906 (Fmatch_data):
1907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1908 (string_match_1, search_buffer, set_search_regs):
1909 (Fmatch_data):
1910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1911 (wordify): Check for overflow in size calculation.
1912 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1913 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1914 Check that fixnums are in proper range for system types.
1915 * sound.c (struct sound_device)
1916 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1918 (Fplay_sound_internal):
1919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1920 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1921 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1922 (Fparse_partial_sexp):
1923 Don't assume fixnums can fit in int.
1924 (struct lisp_parse_state, find_start_pos, find_start_value)
1925 (find_start_value_byte, find_start_begv)
1926 (update_syntax_table, char_quoted, dec_bytepos)
1927 (find_defun_start, prev_char_comend_first, back_comment):
1928 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1929 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1931 (Finternal_describe_syntax_value): Check that match_lisp is a
1932 character, not an integer, since the code stuffs it into int.
1933 (scan_words, scan_sexps_forward):
1934 Check that fixnums are in proper range for system types.
1935 (Fforward_word):
1936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1937 (scan_sexps_forward):
1938 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1939 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1940 * syntax.h: Adjust decls to match defn changes elsewhere.
1941 (struct gl_state_s):
1942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1943 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1944 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1945 * sysdep.c (wait_for_termination_1, wait_for_termination)
1946 (interruptible_wait_for_termination, mkdir):
1947 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1948 (emacs_read, emacs_write):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1950 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1951 and double all fit in int.
d311d28c
PE
1952 * term.c (set_tty_color_mode):
1953 Check that fixnums are in proper range for system types.
1954 * termhooks.h (struct input_event):
1955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1956 * textprop.c (validate_interval_range, interval_of)
1957 (Fadd_text_properties, set_text_properties_1)
1958 (Fremove_text_properties, Fremove_list_of_text_properties)
1959 (Ftext_property_any, Ftext_property_not_all)
1960 (copy_text_properties, text_property_list, extend_property_ranges)
1961 (verify_interval_modification):
1962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1963 (Fnext_single_char_property_change)
1964 (Fprevious_single_char_property_change):
1965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1966 (copy_text_properties):
1967 Check for integer overflow in index calculation.
d311d28c
PE
1968 * undo.c (last_boundary_position, record_point, record_insert)
1969 (record_delete, record_marker_adjustment, record_change)
1970 (record_property_change):
1971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1972 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1974 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1975 (Fx_hide_tip, Fx_file_dialog):
1976 * w32menu.c (set_frame_menubar):
1977 Use ptrdiff_t, not int, for consistency with rest of code.
1978 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1979 (select_window, Fdelete_other_windows_internal)
1980 (window_scroll_pixel_based, window_scroll_line_based)
1981 (Frecenter, Fset_window_configuration):
1982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1983 (Fset_window_hscroll, run_window_configuration_change_hook)
1984 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1985 (Fscroll_other_window, Frecenter):
d311d28c
PE
1986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1987 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1988 Don't assume fixnum fits in int.
1989 (Fset_window_scroll_bars):
1990 Check that fixnums are in proper range for system types.
1991 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1992 (string_pos, c_string_pos, number_of_chars, init_iterator)
1993 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1994 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1995 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1996 (face_before_or_after_it_pos, handle_invisible_prop)
1997 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1998 (display_prop_intangible_p, string_buffer_position_lim)
1999 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2000 (get_overlay_strings_1, get_overlay_strings)
2001 (iterate_out_of_display_property, forward_to_next_line_start)
2002 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2003 (get_next_display_element, set_iterator_to_next)
2004 (get_visually_first_element, compute_stop_pos_backwards)
2005 (handle_stop_backwards, next_element_from_buffer)
2006 (move_it_in_display_line_to, move_it_in_display_line)
2007 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2008 (add_to_log, message_dolog, message_log_check_duplicate)
2009 (message2, message2_nolog, message3, message3_nolog
2010 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2011 (current_message_1, truncate_echo_area, truncate_message_1)
2012 (set_message, set_message_1, store_mode_line_noprop)
2013 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2014 (text_outside_line_unchanged_p, check_point_in_composition)
2015 (reconsider_clip_changes)
2016 (redisplay_internal, set_cursor_from_row, try_scrolling)
2017 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2018 (redisplay_window, find_last_unchanged_at_beg_row)
2019 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2020 (trailing_whitespace_p, find_row_edges, display_line)
2021 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2022 (display_mode_element, store_mode_line_string)
2023 (pint2str, pint2hrstr, decode_mode_spec)
2024 (display_count_lines, display_string, draw_glyphs)
2025 (x_produce_glyphs, x_insert_glyphs)
2026 (rows_from_pos_range, mouse_face_from_buffer_pos)
2027 (fast_find_string_pos, mouse_face_from_string_pos)
2028 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2030 (safe_call, init_from_display_pos, handle_fontified_prop)
2031 (handle_single_display_spec, load_overlay_strings)
2032 (with_echo_area_buffer, setup_echo_area_for_printing)
2033 (display_echo_area, echo_area_display)
2034 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2035 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2036 (redisplay_window, dump_glyph_row, display_mode_line)
2037 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2038 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2040 (handle_single_display_spec, build_desired_tool_bar_string)
2041 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2042 (get_specified_cursor_type):
2043 Check that fixnums are in proper range for system types.
2044 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2045 (Flookup_image_map):
2046 Don't assume fixnums fit in int.
2047 (compare_overlay_entries):
2048 Avoid mishandling comparisons due to subtraction overflow.
2049 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2050 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2051 (handle_tool_bar_click):
2052 Use int, not unsigned, since we prefer signed and the signedness
2053 doesn't matter here.
2054 (get_next_display_element, next_element_from_display_vector):
2055 Use int, not EMACS_INT, when int is wide enough.
2056 (start_hourglass): Use duration_to_sec_usec to do proper
2057 overflow checking on durations.
2058 * xfaces.c (Fbitmap_spec_p):
2059 Check that fixnums are in proper range for system types.
2060 (compare_fonts_by_sort_order):
2061 Avoid mishandling comparisons due to subtraction overflow.
2062 (Fx_family_fonts, realize_basic_faces):
2063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2064 (Fx_family_fonts):
2065 Don't assume fixnum fits in int.
2066 Use SAFE_ALLOCA_LISP, not alloca.
2067 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2068 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2069 (face_at_buffer_position, face_for_overlay_string)
2070 (face_at_string_position):
2071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2072 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2073 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2074 (Fx_show_tip):
2075 Check that fixnums are in proper range for system types.
2076 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2077 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2079 (Fx_change_window_property): Don't assume fixnums fit in int.
2080 * xfont.c (xfont_chars_supported):
2081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2082 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2083 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2085 * xml.c (parse_region):
2086 * xrdb.c (magic_file_p):
2087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2088 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2089 (x_get_local_selection, x_reply_selection_request)
2090 (x_handle_selection_request, wait_for_property_change):
2091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2092 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2093 short is wide enough.
2094 (x_send_client_event): Don't assume fixnum fits in int.
2095 * xterm.c (x_x_to_emacs_modifiers):
2096 Don't assume EMACS_INT overflows nicely into int.
2097 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2098 may come from Lisp.
2099 (handle_one_xevent): NATNUMP can eval its arg twice.
2100 (x_connection_closed):
2101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2102 * xterm.h: Adjust decls to match defn changes elsewhere.
2103 (struct scroll_bar): Use struct vectorlike_header
2104 rather than rolling our own approximation.
2105 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2106
c6574eb5
GM
21072012-05-25 Glenn Morris <rgm@gnu.org>
2108
2109 * lisp.mk (lisp): Update for more files being compiled now.
2110
e8d32c7e
SM
21112012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2112
48def666
SM
2113 * lread.c: Remove `read_pure' which makes no difference.
2114 (read_pure): Remove var.
2115 (unreadpure): Remove function.
2116 (readevalloop): Don't call read_list with -1 flag.
2117 (read1, read_vector): Don't test read_pure any more.
2118 (read_list): Simplify.
2119
e8d32c7e
SM
2120 * fileio.c, character.h: Minor style tweaks.
2121
4b2addb7
DA
21222012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 * window.h (clip_changed): Remove useless declaration.
2125
584461b2
JB
21262012-05-22 Juanma Barranquero <lekktu@gmail.com>
2127
2128 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2129 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2130
34374650
PE
21312012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 Remove src/m/*.
2134 This directory predates autoconf and is no longer needed nowadays.
2135 Move its few remaining bits of functionality to where they're needed.
2136 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2137 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2138 * m/template.h: Remove.
2139 * Makefile.in (M_FILE): Remove. All uses removed.
2140 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2141 * lisp.h (USE_LSB_TAG):
2142 * mem-limits.h (EXCEEDS_LISP_PTR):
2143 Use VAL_MAX, not VALBITS, in #if.
2144 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2145 (EMACS_UINT): Define unconditionally now.
2146 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2147 (BITS_PER_EMACS_INT): New constants, replacing
2148 what used to be in config.h, but not useful in #if.
2149 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2150 define them any more.
2151 (VAL_MAX): New macro.
2152 (VALMASK): Use it.
2153 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2154 BITS_PER_EMACS_INT, in #if.
2155 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2156 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2157 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2158 * s/ms-w32.h (DATA_START):
2159 Move here from removed file m/intel386.h.
2160 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2161 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2162
261cb4bb
PE
21632012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Assume C89 or later.
2166 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2167 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2168 (xrealloc):
2169 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2170 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2171 * textprop.c, tparam.c (NULL): Remove.
2172 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2173 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2174 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2175 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2176 * xterm.c (input_signal_count): Assume volatile works.
2177
ff23cd9f
KB
21782012-05-21 Ken Brown <kbrown@cornell.edu>
2179
2180 * xgselect.c (xg_select): Fix first argument in call to 'select'
2181 (bug#11508).
2182
1b170bc6
KB
21832012-05-20 Ken Brown <kbrown@cornell.edu>
2184
2185 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2186 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2187
b2f4d39f
KB
21882012-05-19 Ken Brown <kbrown@cornell.edu>
2189
2190 * xfns.c (x_in_use): Remove `static' qualifier.
2191 * xterm.h (x_in_use): Declare.
2192 * xgselect.c: Include xterm.h.
2193 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2194 and `display_arg' (bug#9754).
2195
003fdae2
PE
21962012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2197
9232a6d9
PE
2198 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2199
003fdae2
PE
2200 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2201 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2202
784b56e2
EZ
22032012-05-18 Eli Zaretskii <eliz@gnu.org>
2204
2205 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2206
2207 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2208 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2209
2210 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2211 reference to image_cache->refcount.
2212 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2213
a0a79cde
JL
22142012-05-17 Juri Linkov <juri@jurta.org>
2215
2216 * search.c (Fword_search_regexp, Fword_search_backward)
2217 (Fword_search_forward, Fword_search_backward_lax)
2218 (Fword_search_forward_lax): Move functions to isearch.el
2219 (bug#10145, bug#11381).
2220
b0572523
PE
22212012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2224
9660f5fc
SM
22252012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2226
2227 * lread.c (init_obarray): Declare Qt and Qnil as special.
2228
4374de83
GM
22292012-05-14 Glenn Morris <rgm@gnu.org>
2230
2231 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2232 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2233
dc44c39a
PE
22342012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2235
078c97cb
PE
2236 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2237
dc44c39a
PE
2238 * unexaix.c: Port to more-recent AIX compilers.
2239 (report_error, report_error_1, make_hdr, copy_sym)
2240 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2241 Make arguments const char *, not char *, to avoid violations of C
2242 standard and to fix some AIX warnings reported by Gilles Pion.
2243
e18afed7 22442012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2245
2246 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2247 already have overlays loaded.
2248 (handle_single_display_spec): Before returning without displaying
2249 fringe bitmap, synchronize the bidi iterator with the main display
2250 iterator, by calling iterate_out_of_display_property.
2251 (iterate_out_of_display_property): Detect buffer iteration by
2252 testing that it->string is a Lisp string.
2253 (get_next_display_element): When the current object is exhausted,
2254 and there's something on it->stack, call set_iterator_to_next to
2255 proceed with what's on the stack, instead of returning zero.
2256 (set_iterator_to_next): If called at the end of a Lisp string,
2257 proceed to consider_string_end without incrementing string
2258 position. Don't increment display vector index past the end of
2259 the display vector. (Bug#11417)
c8fb9dc6
EZ
2260 (pos_visible_p): Don't report a position visible when move_it_to
2261 stopped at the last line of window, which happens to be scanned
2262 backwards by the bidi iteration. (Bug#11464)
ac268e67 2263
e18afed7 22642012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2265
2266 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2267 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2268 are on a TTY, and thus unable to display on the fringes.
2269 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2270 so we need to signal to the caller that this is a "replacing"
2271 display spec. This fixes display when the spec is invalid or we
2272 are on a TTY.
2273
e18afed7 22742012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2275
2276 * unexaix.c (make_hdr): Fix typo in prototype.
2277 This bug broke the build on AIX. Problem reported by Gilles Pion.
2278
9d0a235a
MA
22792012-05-14 Michael Albinus <michael.albinus@gmx.de>
2280
2281 * keyboard.c (kbd_buffer_get_event): Read special events also in
2282 batch mode. (Bug#11415)
2283
9e6b06ed
GM
22842012-05-12 Glenn Morris <rgm@gnu.org>
2285
2286 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2287
c1a1d7a3
EZ
22882012-05-12 Eli Zaretskii <eliz@gnu.org>
2289
2290 * lisp.mk (lisp): Add newcomment.elc.
2291
3fe7cdc8
GM
22922012-05-12 Glenn Morris <rgm@gnu.org>
2293
2294 * Makefile.in (MKDIR_P): New, set by configure.
2295 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2296
53f7d2c0
PE
22972012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 Remove unused function hourglass_started.
2300 * dispextern.h (hourglass_started):
2301 * w32fns.c (hourglass_started):
2302 * xdisp.c (hourglass_started): Remove.
2303
75aafb17
JB
23042012-05-10 Juanma Barranquero <lekktu@gmail.com>
2305
2306 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2307 Update dependencies.
2308
12959e8e
PE
23092012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2310
97107e2e
PE
2311 * xgselect.c (xg_select): Put maxfds+1 into a var.
2312 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2313
12959e8e
PE
2314 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2315
836d29b3
DA
23162012-05-10 Dave Abrahams <dave@boostpro.com>
2317
2318 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2319 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2320
5cb67954
MA
23212012-05-09 Michael Albinus <michael.albinus@gmx.de>
2322
2323 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2324 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2325 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2326 Initialize xd_registered_buses.
2327
3478ec45
PE
23282012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2329
b263a6b0
PE
2330 Untag more efficiently if USE_LSB_TAG.
2331 This is based on a proposal by YAMAMOTO Mitsuharu in
2332 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2333 For an admittedly artificial (nth 8000 longlist) benchmark on
2334 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2335 Emacs's overall text size by 1%.
2336 * lisp.h (XUNTAG): New macro.
2337 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2338 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2339 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2340 * eval.c (Fautoload):
2341 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2342 * frame.h (XFRAME): Use XUNTAG.
2343
3478ec45
PE
2344 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2345 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2346 Remove unportable assumptions about print widths of types like
2347 dbus_uint32_t.
2348 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2349 intptr_t when converting between pointer and integer, to avoid GCC
2350 warnings about wrong width.
2351
666b903b 23522012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2353
2354 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2355 stack for each reader_thread, instead of defaulting to 8MB
2356 determined by the linker. This avoids failures in creating
2357 subprocesses on Windows 7, see the discussion in this thread:
2358 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2359
b120cc17
JC
23602012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2361
2362 Fix up display of the *Minibuf-0* buffer in the mini window.
2363 * keyboard.c (read_char): Don't clear the echo area if there's no
2364 message to clear.
2365 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2366 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2367
9a4b36f8
MA
23682012-05-07 Michael Albinus <michael.albinus@gmx.de>
2369
2370 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2371 batch mode.
2372
e5f9458f
CY
23732012-05-06 Chong Yidong <cyd@gnu.org>
2374
2375 * lisp.mk (lisp): Update.
2376
eceeb5fc 23772012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2378
2379 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2380
71873e2b
SM
23812012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2382
2383 * data.c (PUT_ERROR): New macro.
2384 (syms_of_data): Use it. Add new error type `user-error'.
2385 * undo.c (user_error): New function.
2386 (Fprimitive_undo): Use it.
2387 * print.c (print_error_message): Adjust print style for `user-error'.
2388 * keyboard.c (user_error): New function.
2389 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2390
ab0fa4e4
PE
23912012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 Do not limit current-time-string to years 1000..9999.
2394 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2395 (Fcurrent_time_string): Support any year that is supported by the
2396 underlying localtime representation. Don't use asctime, as it
2397 has undefined behavior for years outside the range -999..9999.
2398
7ed806a7
PE
23992012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 Fix race conditions involving setenv, gmtime, localtime, asctime.
2402 Without this fix, interrupts could mess up code that uses these
2403 nonreentrant functions, since setting TZ invalidates existing
2404 tm_zone or tzname values, and since most of these functions return
2405 pointers to static storage.
2406 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2407 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2408 Grow the critical sections to include not just invoking
2409 localtime/gmtime, but also accessing these functions' results
2410 including their tm_zone values if any, and any related TZ setting.
2411 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2412 so that the struct tm is saved in the critical section.
2413 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2414 motivated by the fact that memory allocation needs to be outside
2415 the critical section.
2416
0c16dfed
DA
24172012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2418
2419 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2420 with RESET_INTERVAL.
2421
2422 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2423 Remove duplicated buffer name initialization.
2424
3f83ace8
JM
24252012-05-02 Jim Meyering <jim@meyering.net>
2426
2427 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2428
c7b8541e
JM
2429 * xfns.c (x_window): Use xstrdup (Bug#11375).
2430
90207a15 24312012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2432
2433 * xdisp.c (pos_visible_p): If already at a newline from the
2434 display string before the 'while' loop, don't walk back the glyphs
2435 from it3.glyph_row. Solves assertion violation when the display
2436 string begins with a newline (egg.el). (Bug#11367)
2437
b593d6a9
AH
24382012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2439
2440 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2441 Move to simple.el.
2442
4737362e
GM
24432012-05-01 Glenn Morris <rgm@gnu.org>
2444
99cf43f9
GM
2445 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2446 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2447 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2448 All were removed before 23.1.
2449
9311dcff
GM
2450 * dispnew.c: Remove HAVE_LIBNCURSES test;
2451 it is always true on relevant platforms.
2452
4d5c6349
GM
2453 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2454 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2455
4737362e
GM
2456 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2457
74dd3a6b
AS
24582012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2459
2460 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2461 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2462 Remove.
2463
13c379ee
PE
24642012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 Do not avoid creating empty evaporating overlays (Bug#9642).
2467 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2468 That is, do not delete an evaporating overlay if it becomes
2469 empty after its bounds are adjusted to fit within its buffer.
2470 This fix caused other problems, and I'm reverting it until we get
2471 to the bottom of them.
2472
a8e7d6d7 24732012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2474
2475 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2476
a8e7d6d7 24772012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2478
2479 * xdisp.c (pos_visible_p): If the window start position is beyond
2480 ZV, start the display from buffer beginning. Prevents assertion
2481 violation in init_iterator when the minibuffer window is scrolled
2482 via the scroll bar.
2483
2484 * window.c (window_scroll_pixel_based): Likewise.
2485
a8e7d6d7 24862012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2487
2488 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2489
a8e7d6d7 24902012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2491
2492 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2493 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2494
a8e7d6d7 24952012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2496
b593d6a9
AH
2497 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2498 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2499
1c6900d9
EZ
25002012-04-26 Eli Zaretskii <eliz@gnu.org>
2501
4c3fa1d9
EZ
2502 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2503 display element, check also the underlying string or buffer
2504 character. (Bug#11341)
2505
1c6900d9
EZ
2506 * w32menu.c: Include w32heap.h.
2507 (add_menu_item): If the call to AppendMenuW (via
2508 unicode_append_menu) fails, disable Unicode menus only if we are
2509 running on Windows 9X/Me.
2510
42bf8205
AS
25112012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2512
2513 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2514 (xgetint): Add missing shift for LSB tags.
2515
b1bac16e
MR
25162012-04-24 Martin Rudalics <rudalics@gmx.at>
2517
2518 * keyboard.c (read_char): Don't wipe echo area for select window
2519 events: These might get delayed via `mouse-autoselect-window'
2520 (Bug#11304).
2521
d69621cc
JB
25222012-04-24 Juanma Barranquero <lekktu@gmail.com>
2523
2524 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2525 manipulation of :loaded-from data.
2526
02fd101b
JB
25272012-04-23 Juanma Barranquero <lekktu@gmail.com>
2528
2529 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2530 now a cons (bug#11311).
2531
888bec30
PE
25322012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2533
89a438bd
PE
2534 Do not create empty overlays with the evaporate property (Bug#9642).
2535 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2536 if it becomes empty after its bounds are adjusted to fit within
2537 its buffer. Without this fix, in a nonempty buffer (let ((o
2538 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2539 yields an empty overlay that has the evaporate property, which is
2540 not supposed to happen.
2541
1068fe4d
PE
2542 Fix minor GTK3 problems found by static checking.
2543 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2544 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2545 (struct _EmacsFixedClass, emacs_fixed_get_type):
2546 Move decls here from emacsgtkfixed.h, since they needn't be public.
2547 (emacs_fixed_get_type): Now static.
2548 (emacs_fixed_class_init): Omit unused local.
2549 (emacs_fixed_child_type): Remove; unused.
2550 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2551 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2552 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2553 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2554 (EMACS_FIXED_GET_CLASS): Remove; unused.
2555 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2556
888bec30
PE
2557 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2558 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2559
de85e130
PE
25602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2561
d0baac98 2562 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2563 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2564 (__malloc_size_t, __malloc_ptrdiff_t):
2565 Remove. All uses removed, replaced by the definiens if needed,
2566 since we can assume C89 or better now.
2567 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2568 (protect_malloc_state, align, get_contiguous_space)
2569 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2570 (malloc_atfork_handler_child, malloc_enable_thread)
2571 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2572 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2573 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2574 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2575 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2576 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2577 Define using prototypes, not old style.
2578 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2579 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2580 (align): Don't assume that signed integer overflow wraps around.
2581 Omit unused local var.
2582 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2583 (_free_internal_nolock, memalign, mallochook, reallochook):
2584 Omit no-longer-needed casts.
2585 (valloc): Use getpagesize, not __getpagesize.
2586 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2587 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2588
de85e130
PE
2589 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2590
dcbf5805
MA
25912012-04-22 Michael Albinus <michael.albinus@gmx.de>
2592
2593 Move functions from C to Lisp. Make non-blocking method calls
2594 the default. Implement further D-Bus standard interfaces.
2595
2596 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2597 (QCdbus_request_name_allow_replacement)
2598 (QCdbus_request_name_replace_existing)
2599 (QCdbus_request_name_do_not_queue)
2600 (QCdbus_request_name_reply_primary_owner)
2601 (QCdbus_request_name_reply_in_queue)
2602 (QCdbus_request_name_reply_exists)
2603 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2604 (QCdbus_registered_serial, QCdbus_registered_method)
2605 (QCdbus_registered_signal): New Lisp objects.
2606 (XD_DEBUG_MESSAGE): Use sizeof.
2607 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2608 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2609 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2610 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2611 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2612 (xd_signature, xd_append_arg): Allow float for integer types.
2613 (xd_get_connection_references): New function.
b593d6a9
AH
2614 (xd_get_connection_address): Rename from xd_initialize.
2615 Return cached address.
dcbf5805
MA
2616 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2617 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2618 level.
2619 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2620 Return number of refcounts.
dcbf5805
MA
2621 (Fdbus_get_unique_name): Make stronger parameter check.
2622 (Fdbus_message_internal): New defun.
2623 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2624 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2625 (Fdbus_send_signal, Fdbus_register_service)
2626 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2627 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2628 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2629 (Vdbus_compiled_version, Vdbus_runtime_version)
2630 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2631 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2632 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2633 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2634 Adapt docstring.
dcbf5805 2635
52828e02
PE
26362012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2637
da05bc4c
PE
2638 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2639 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2640 Do not assume ptrdiff_t is the same width as 'int'.
2641
52828e02
PE
2642 * alloc.c: Handle unusual debugging option combinations.
2643 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2644 since the two debugging options are incompatible.
2645 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2646 is defined.
2647 (mem_init, mem_insert, mem_insert_fixup):
2648 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2649 (NEED_MEM_INSERT): Remove; no longer needed.
2650
f01769f9
LL
26512012-04-22 Leo Liu <sdl.web@gmail.com>
2652
2653 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2654
5790543d
PE
26552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * sysdep.c [__FreeBSD__]: Minor cleanups.
2658 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2659 Use Emacs indenting style more consistently. Avoid some casts.
2660 Use 'double' consistently rather than mixing 'float' and 'double'.
2661
b91b7e4d
EW
26622012-04-21 Eduard Wiebe <usenet@pusto.de>
2663
b593d6a9
AH
2664 * sysdep.c (list_system_processes, system_process_attributes):
2665 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2666
6114eb15
AS
26672012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2668
2669 * lisp.mk (lisp): Update.
2670
2f38dff7
PE
26712012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2674 It is never used otherwise.
2675
4ae29f89
SM
26762012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2677
2678 * print.c (print_preprocess): Only check print_depth if print-circle
2679 is nil.
2680 (print_object): Check for cycles even when print-circle is nil and
2681 print-gensym is t, but only check print_depth if print-circle is nil.
2682
f30d612a
CY
26832012-04-20 Chong Yidong <cyd@gnu.org>
2684
2685 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2686 set the status to "failed" and ensure that sentinel is run.
2687
c07a4c0b 26882012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2689
2690 * process.c (Fset_process_inherit_coding_system_flag)
2691 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2692 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2693
c07a4c0b 26942012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2695
2696 * xdisp.c (string_buffer_position_lim): Limit starting position to
2697 BEGV.
2698 (set_cursor_from_row): If called for a mode-line or header-line
2699 row, return zero immediately.
2700 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2701 farther than the first row after the header line, if any.
2702 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2703 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2704
c07a4c0b 27052012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2706
4ae29f89
SM
2707 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2708 (bug#11238).
ad3a2b41 2709
c07a4c0b 27102012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27112012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2712
2713 configure: new option --enable-gcc-warnings (Bug#11207)
2714 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2715 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2716 (ALL_CFLAGS): Use new macros rather than old.
2717 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2718 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2719 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2720 -Wunused-result, -Wunused-variable. This should go away once
2721 the Emacs and Gnulib regex code is merged.
2722 (xmalloc, xrealloc): Now static.
2723
aba027e8
PE
27242012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 * dired.c (Fsystem_groups): Remove unused local.
2727
e5a36063
GM
27282012-04-17 Glenn Morris <rgm@gnu.org>
2729
2730 * dired.c (Fsystem_users): Doc fix.
2731
316411f0
DA
27322012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2733
2734 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2735 (syms_of_dired): Add them.
2736
9426aba4
PE
27372012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2738
b62a57be
PE
2739 Fix minor alloc.c problems found by static checking.
2740 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2741 New extern decls, to avoid calling undeclared functions.
2742 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2743 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2744 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2745 (NEED_MEM_INSERT): New macro.
2746 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2747 Remove one incorrect comment and fix another.
b62a57be 2748
3539f31f
PE
2749 Fix minor ralloc.c problems found by static checking.
2750 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2751 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2752 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2753 (r_alloc_sbrk): Now static.
2754
a041960a
PE
2755 Improve ralloc.c interface checking.
2756 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2757 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2758 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2759 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2760 [REL_ALLOC]: ... to here, to check interface.
2761 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2762 Remove decls. This fixes an "It stinks!".
2763
9426aba4
PE
2764 * alloc.c (which_symbols): Fix alignment issue / type clash.
2765
d55c12ed
AS
27662012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2767
2768 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2769 (struct Lisp_Misc_Any): Likewise.
2770 (struct Lisp_Free): Likewise.
2771 * alloc.c (union aligned_Lisp_Symbol): Define.
2772 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2773 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2774 (union aligned_Lisp_Misc): Define.
2775 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2776 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2777 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2778
b948ce8b
PE
27792012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2782 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2783 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2784 * s/netbsd.h, s/sol2-6.h:
2785 Remove definition of GC_MARK_STACK, since the default now works.
2786 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2787 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2788 no longer the default.
2789 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2790
35dc09a1 27912012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2792
35dc09a1
GM
2793 * lread.c (lisp_file_lexically_bound_p):
2794 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2795
35dc09a1
GM
27962012-04-14 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2799 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2800
28012012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2802
2803 * nsterm.m (constrainFrameRect): Always constrain when there is only
2804 one screen (Bug#10962).
2805
bcd86815
KB
28062012-04-13 Ken Brown <kbrown@cornell.edu>
2807
2808 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2809
c25df26e
RT
28102012-04-13 Reuben Thomas <rrt@sc3d.org>
2811
2812 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2813
0fc59f1e
DC
28142012-04-11 Daniel Colascione <dancol@dancol.org>
2815
2816 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2817 against is gone. It's better to use vfork now so that when Cygwin
2818 gains a new, working vfork, we use it automatically (bug#10398).
2819
de8c03dc
SM
28202012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2821
2822 * window.c (save_window_save): Obey window-point-insertion-type.
2823
2f097256
GM
28242012-04-11 Glenn Morris <rgm@gnu.org>
2825
2826 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2827
453b951e
SM
28282012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2829
2830 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2831
75f1671a 28322012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2833
2834 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2835 (force_quit_count): New var.
2836 (handle_interrupt): Use it.
2837
2a8ce227
JB
28382012-04-10 Juanma Barranquero <lekktu@gmail.com>
2839
2840 * w32.c (w32_delayed_load): Record the full path of the library
2841 being loaded (bug#10424).
2842
935396c0
GM
28432012-04-09 Glenn Morris <rgm@gnu.org>
2844
05920a43
GM
2845 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2846 not just in the obarray, before snarfing them. (Bug#11036)
2847
935396c0
GM
2848 * Makefile.in ($(leimdir)/leim-list.el):
2849 Pass EMACS rather than BUILT_EMACS.
2850
a18ecafa
TZ
28512012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2852
2853 * process.c (make_process):
2854 * process.h: Add integer `gnutls_handshakes_tried' member to
2855 process struct.
2856
6bbef4e5
JC
2857 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2858 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2859
2860 * gnutls.c (gnutls_log_function2i): Convenience log function.
2861 (emacs_gnutls_read): Use new log functions,
2862 `gnutls_handshakes_tried' process member, and
2863 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2864 attempts per process (connection).
2865
b4d3bc10
CY
28662012-04-09 Chong Yidong <cyd@gnu.org>
2867
2868 * eval.c (Fuser_variable_p, user_variable_p_eh)
2869 (lisp_indirect_variable): Functions deleted.
2870 (Fdefvar): Caller changed.
2871
2872 * callint.c (Finteractive, Fcall_interactively):
2873 * minibuf.c (Fread_variable): Callers changed.
2874
70f4d973
EZ
28752012-04-09 Eli Zaretskii <eliz@gnu.org>
2876
2877 * xdisp.c (set_cursor_from_row): If the display string appears in
2878 the buffer at position that is closer to point than the position
2879 after the display string, display the cursor on the first glyph of
2880 the display string. Fixes cursor display when a 'display' text
2881 property immediately follows invisible text. (Bug#11094)
2882
cb3c2e3e
PE
28832012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 composite.c: use 'double' consistently
2886 * composite.c (get_composition_id): Use 'double' consistently
2887 instead of converting 'float' to 'double' and vice versa; this is
2888 easier to understand and avoids a GCC warning.
2889
fd06db5d
GM
28902012-04-09 Glenn Morris <rgm@gnu.org>
2891
50fe702a
GM
2892 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2893 preparation for dumping it with emacs. (Bug#4789)
2894 (leimdir): New variable.
2895 ($(leimdir)/leim-list.el): New rule.
2896 (emacs$(EXEEXT)): Depend on leim-list.el.
2897
fd06db5d
GM
2898 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2899 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2900 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2901
55c131ee
AS
29022012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2903
2904 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2905 proper alignment.
2906
9209588f
JB
29072012-04-07 Juanma Barranquero <lekktu@gmail.com>
2908
2909 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2910 Remove unused local variable.
2911
e3fb2efb
PE
29122012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2915 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2916 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2917 objects, as mark_maybe_pointer will catch them otherwise.
2918 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2919 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2920
b5385551
PE
29212012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 Fix typo that broke non-Windows builds.
2924 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2925
9078ead6
EZ
29262012-04-07 Eli Zaretskii <eliz@gnu.org>
2927
2928 Support building on MS-Windows with libxml2.
2929
2930 * makefile.w32-in (OBJ2): Add xml.$(O).
2931 (GLOBAL_SOURCES): Add xml.c.
2932 ($(BLD)/xml.$(O)): New dependency list.
2933
2934 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2935 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2936 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2937 [!WINDOWSNT]: New macros.
2938 (init_libxml2_functions, libxml2_loaded_p): New functions.
2939 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2940 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2941 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2942 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2943 linked in).
6bbef4e5
JC
2944 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2945 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2946 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2947
2948 * emacs.c: Don't include libxml/parser.h.
2949 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2950 xmlCleanupParser directly.
2951
2952 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2953
3811fdf3
EZ
29542012-04-07 Eli Zaretskii <eliz@gnu.org>
2955
2956 * indent.c (Fvertical_motion): If there is a display string at
2957 point, use it.vpos to compute how many lines to backtrack after
2958 move_it_to point. (Bug#11133)
2959
2f8e16b2
EZ
29602012-04-06 Eli Zaretskii <eliz@gnu.org>
2961
2962 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2963 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2964 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2965 macros related to unification of CJK characters. For the details,
2966 see the discussion following the message here:
2967 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2968
3d439cd1
CY
29692012-04-04 Chong Yidong <cyd@gnu.org>
2970
2971 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2972
8bc53d00
EZ
29732012-04-01 Eli Zaretskii <eliz@gnu.org>
2974
2975 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2976 instead of alloca. (Bug#11138)
2977
3b0512a3
AS
29782012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2979
2980 * w32menu.c (is_simple_dialog): Properly check lisp types.
2981 (Bug#11141)
2982
8427ddd2
EZ
29832012-03-31 Eli Zaretskii <eliz@gnu.org>
2984
979022ef
EZ
2985 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2986 position we get to after a call to move_it_to fails the
2987 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2988 only if we wind up in a string from display property. (Bug#11063)
2989
a6b1c7cc
EZ
2990 * window.c (Fdelete_other_windows_internal): Invalidate the row
2991 and column information about mouse highlight, so that redisplay
2992 restores it after reallocating the glyph matrices. (Bug#7464)
2993
8427ddd2
EZ
2994 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2995 string comes from a `display' text property, use the buffer
2996 position of that property as if we actually saw that position in
2997 the row's glyphs.
697ba24b
EZ
2998 (move_it_by_lines): Remove the assertion that
2999 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3000 violated when there's a before-string at the beginning of a line.
3001 (Bug#11063)
8427ddd2 3002
65a0a738
EZ
30032012-03-30 Eli Zaretskii <eliz@gnu.org>
3004
3005 * xdisp.c (append_space_for_newline): If the default face was
3006 remapped, use the remapped face for the appended newline.
3007 (extend_face_to_end_of_line): Use the remapped default face for
3008 extending the face to the end of the line.
3009 (display_line): Call extend_face_to_end_of_line when the default
3010 face was remapped. (Bug#11068)
3011
581355cc
EZ
30122012-03-29 Eli Zaretskii <eliz@gnu.org>
3013
3014 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3015
e8fc049f
SM
30162012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3017
3018 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3019
4fb9a543
GM
30202012-03-27 Glenn Morris <rgm@gnu.org>
3021
3022 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3023 Doc fixes.
3024
679910f1
KH
30252012-03-26 Kenichi Handa <handa@m17n.org>
3026
3027 * dispextern.h (struct glyph): Fix previous change. Change the
3028 bit length of glyphless.ch to 25 (Bug#11082).
3029
90d49b7f
CY
30302012-03-26 Chong Yidong <cyd@gnu.org>
3031
3032 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3033 (command_loop_1): Use it; inhibit selection update for
3034 handle-select-window too (Bug#8996).
3035
f514f6f0
FP
30362012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3037
e8fc049f 3038 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3039
bf43fa51
KH
30402012-03-25 Kenichi Handa <handa@m17n.org>
3041
3042 * dispextern.h (struct glyph): Change the bit length of
3043 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3044
8a0c01dd
EZ
30452012-03-24 Eli Zaretskii <eliz@gnu.org>
3046
3047 * s/ms-w32.h (tzname): Include time.h before redirecting to
3048 _tzname. Fixes the MSVC build. (Bug#9960)
3049
7d1c3a76
AS
30502012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3051
8ed79523
AS
3052 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3053 characters.
3054
7d1c3a76
AS
3055 * xterm.c (XTread_socket): Only modify handling_signal if
3056 !SYNC_INPUT. (Bug#11080)
3057
e99a9b8b
EZ
30582012-03-23 Eli Zaretskii <eliz@gnu.org>
3059
3060 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3061 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3062 when fetching a multibyte character consumes more bytes than
3063 CHAR_BYTES returns, due to unification of CJK characters in
3064 string_char. (Bug#11073)
3065
5063c0e1
TN
30662012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3067
3068 * process.c (wait_reading_process_output): Handle pty disconnect
3069 by refraining from sending oneself a SIGCHLD (bug#10933).
3070
9f851fbd
CY
30712012-03-22 Chong Yidong <cyd@gnu.org>
3072
3073 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3074
5063c0e1 3075 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3076 Mark string as coming from a prefix property.
3077 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3078 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3079
fb5b8aca
CY
30802012-03-21 Chong Yidong <cyd@gnu.org>
3081
3082 * xfaces.c (Vface_remapping_alist): Doc fix.
3083
62356a1b
EZ
30842012-03-20 Eli Zaretskii <eliz@gnu.org>
3085
3086 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3087 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3088 Doc fixes.
62356a1b 3089
025de85b
CY
30902012-03-20 Chong Yidong <cyd@gnu.org>
3091
3092 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3093 to reflect default non-nil value of redisplay-dont-pause.
3094
4827f94e
KH
30952012-03-19 Kenichi Handa <handa@m17n.org>
3096
3097 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3098 it fit in a valid range (Bug#11003).
3099
e50a24a2
EZ
31002012-03-18 Eli Zaretskii <eliz@gnu.org>
3101
3102 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3103 that is not from display property, accept the row as a "cursor
3104 row" if one of the string's character has a non-nil `cursor'
3105 property. Fixes cursor positioning when there are newlines in
3106 overlay strings, e.g. in icomplete.el. (Bug#11035)
3107
9af5ed87
PE
31082012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3111
d1f55f16
CY
31122012-03-12 Chong Yidong <cyd@gnu.org>
3113
3114 * eval.c (inhibit_lisp_code): Rename from
3115 inhibit_window_configuration_change_hook; move from window.c.
3116
3117 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3118 * window.c (run_window_configuration_change_hook)
3119 (syms_of_window): Callers changed.
3120
66c5eebd
CY
31212012-03-11 Chong Yidong <cyd@gnu.org>
3122
413df973
CY
3123 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3124
66c5eebd
CY
3125 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3126
1de11f56
CY
31272012-03-10 Chong Yidong <cyd@gnu.org>
3128
3129 * frame.c (other_visible_frames): Don't assume the selected frame
3130 is visible (Bug#10955).
3131
cae07000
SM
31322012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3133
3134 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3135
89c94350
JD
31362012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3137
3138 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3139 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3140 zero (Bug#10954).
3141
999dd333
GM
31422012-03-03 Glenn Morris <rgm@gnu.org>
3143
01a6dcc8 3144 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3145
de0100f2
EZ
31462012-03-02 Eli Zaretskii <eliz@gnu.org>
3147
3148 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3149 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3150 (redisplay_window, next_element_from_string): Fix typos in
3151 comments.
3e441275
EZ
3152 (redisplay_window): Pass to move_it_vertically the margin in
3153 pixels, not in screen lines.
de0100f2 3154
96a72ee9
GM
31552012-03-02 Glenn Morris <rgm@gnu.org>
3156
3157 * buffer.c (buffer-list-update-hook): Doc fix.
3158
312508d7
EZ
31592012-02-29 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3162 push_it before setting up the iterator for the first overlay
3163 string, even if we have an empty string loaded.
3164 (next_overlay_string): If there's an empty string on the iterator
3165 stack, pop the stack. (Bug#10903)
3166
27f3c637
PE
31672012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3168
3169 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3170 Suggested by Stefan Monnier in
3171 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3172 * alloc.c (widen_to_Lisp_Object): New static function.
3173 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3174 and widening them to Lisp_Objects. This would work even if
3175 USE_LSB_TAG is defined and wide integers are used, which might
3176 happen in a future version of Emacs.
3177
3c9dfce6
CY
31782012-02-25 Chong Yidong <cyd@gnu.org>
3179
fa74b241
CY
3180 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3181 Doc fix.
3182
3c9dfce6
CY
3183 * xselect.c (Fx_selection_exists_p): Doc fix.
3184 (x_clipboard_manager_save_all): Print an informative message
3185 before saving to clipboard manager.
3186
9486df08
CY
31872012-02-24 Chong Yidong <cyd@gnu.org>
3188
3189 * keyboard.c (process_special_events): Handle all X selection
3190 requests in kbd_buffer, not just the next one (Bug#8869).
3191
f01d3321
CY
31922012-02-23 Chong Yidong <cyd@gnu.org>
3193
3194 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3195 call when setting menu-bar-lines and tool-bar-lines parameters.
3196 (unwind_create_frame_1): New helper function.
3197
3198 * window.c (inhibit_window_configuration_change_hook): New var.
3199 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3200 (syms_of_window): Initialize it.
f01d3321 3201
86b847b6
CY
32022012-02-22 Chong Yidong <cyd@gnu.org>
3203
3204 * xterm.c (x_draw_image_relief): Add missing type check for
3205 Vtool_bar_button_margin (Bug#10743).
3206
a59225b1
CY
32072012-02-21 Chong Yidong <cyd@gnu.org>
3208
3209 * fileio.c (Vfile_name_handler_alist): Doc fix.
3210
3211 * buffer.c (Fget_file_buffer): Protect against invalid file
3212 handler return value.
3213
310f5bd4
PE
32142012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3215
cb3a28cc
PE
3216 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3217 when computing $valmask.
3218
310f5bd4
PE
3219 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3220 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3221 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3222 It's useless in that case, and it can cause problems on hosts
3223 that allocate halves of EMACS_INT values separately.
3224 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3225 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3226 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3227 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3228 it avoids undefined behavior on hosts where shifting right by more
3229 than the word width has undefined behavior.
3230
2375c96a
CY
32312012-02-19 Chong Yidong <cyd@gnu.org>
3232
3233 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3234 (Funhandled_file_name_directory, Ffile_name_as_directory)
3235 (Fdirectory_file_name, Fexpand_file_name)
3236 (Fsubstitute_in_file_name): Protect against invalid file handler
3237 return values (Bug#10845).
3238
3eb49e71
EZ
32392012-02-18 Eli Zaretskii <eliz@gnu.org>
3240
3241 * .gdbinit (pitx): Fix incorrect references to fields of the
3242 iterator stack.
3243
7b926f3f
CY
32442012-02-17 Chong Yidong <cyd@gnu.org>
3245
3246 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3247
11273115
PE
32482012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3251 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3252
c3a70e2b
CY
32532012-02-15 Chong Yidong <cyd@gnu.org>
3254
3255 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3256 marked as special. Also, starting docstrings with * is obsolete.
3257
0ca43699
AS
32582012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3259
3260 * gnutls.c (emacs_gnutls_write): Fix last change.
3261
2e8f3c56
LI
32622012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3263
3264 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3265 send_process.
3266
af70074f
SM
32672012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3268
3269 * keymap.c (Fsingle_key_description): Handle char ranges.
3270
95986d52
CY
32712012-02-12 Chong Yidong <cyd@gnu.org>
3272
afd83bd1
CY
3273 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3274 as that creates a dangerous corner case.
3275
95986d52
CY
3276 * window.c (Fdelete_window_internal): Invalidate the mouse
3277 highlight (Bug#9904).
3278
bd7da63e
GM
32792012-02-12 Glenn Morris <rgm@gnu.org>
3280
3281 * xselect.c (Fx_own_selection_internal)
3282 (Fx_get_selection_internal, Fx_disown_selection_internal)
3283 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3284 * nsselect.m (Fx_own_selection_internal)
3285 (Fx_disown_selection_internal, Fx_selection_exists_p)
3286 (Fx_selection_owner_p, Fx_get_selection_internal):
3287 Sync docs and argument specs with the xselect.c versions.
3288
77abcbc2
LI
32892012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3290
3291 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3292
90b671e2
EZ
32932012-02-11 Eli Zaretskii <eliz@gnu.org>
3294
1c0ca0b7
EZ
3295 * w32select.c (Fx_selection_exists_p): Sync doc string and
3296 argument list with xselect.c. (Bug#10783)
3297
3298 * w16select.c (Fx_selection_exists_p): Sync doc string and
3299 argument list with xselect.c. (Bug#10783)
90b671e2 3300
49241268
GM
33012012-02-10 Glenn Morris <rgm@gnu.org>
3302
3303 * fns.c (Fsecure_hash): Doc fix.
3304
f998bbe7 33052012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3306
3307 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3308
0992bd9c
CY
33092012-02-07 Chong Yidong <cyd@gnu.org>
3310
3311 * buffer.c (Fbuffer_local_variables)
3312 (buffer_lisp_local_variables): Handle unbound vars correctly;
3313 don't let Qunbound leak into Lisp.
3314
af008560
GM
33152012-02-07 Glenn Morris <rgm@gnu.org>
3316
dd605cc4
GM
3317 * image.c (Fimagemagick_types): Doc fix.
3318
af008560
GM
3319 * image.c (imagemagick-render-type): Change it from a lisp object
3320 to an integer. Move the doc here from the lisp manual.
3321 Treat all values not equal to 0 the same.
3322
1449fa1d
CY
33232012-02-06 Chong Yidong <cyd@gnu.org>
3324
3325 * doc.c (store_function_docstring): Avoid applying docstring of
3326 alias to base function (Bug#2603).
3327
3723ec07
AS
33282012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3329
3330 * .gdbinit (pp1, pv1): Remove redundant defines.
3331 (pr): Use pp.
3332
79c1cc1e
CY
33332012-02-04 Chong Yidong <cyd@gnu.org>
3334
3335 * nsterm.m: Declare a global (Bug#10694).
3336
d7f29f8e
EZ
33372012-02-04 Eli Zaretskii <eliz@gnu.org>
3338
cae07000
SM
3339 * w32.c (get_emacs_configuration_options):
3340 Include --enable-checking, if specified, in the return value.
d7f29f8e 3341
3b95a6f9
MR
33422012-02-04 Martin Rudalics <rudalics@gmx.at>
3343
3344 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3345 after rounding frame sizes. (Bug#9723)
3346
d6fa96a6
EZ
33472012-02-04 Eli Zaretskii <eliz@gnu.org>
3348
3349 * keyboard.c (adjust_point_for_property): Don't position point
3350 before BEGV. (Bug#10696)
3351
df0b2940
PE
33522012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3353
3354 Handle overflow when computing char display width (Bug#9496).
3355 * character.c (char_width): Return EMACS_INT, not int.
3356 (char_width, c_string_width): Check for overflow when
3357 computing the width; this is possible now that individual
3358 characters can have unbounded width. Problem introduced
3359 by merge from Emacs 23 on 2012-01-19.
3360
6bee44d6
MA
33612012-02-02 Michael Albinus <michael.albinus@gmx.de>
3362
3363 * dbusbind.c (Fdbus_register_method): Mention the return value
3364 :ignore in the docstring.
3365
44f92739
GM
33662012-02-02 Glenn Morris <rgm@gnu.org>
3367
1b9f60cc
GM
3368 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3369
44f92739
GM
3370 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3371 Unconditionally set to t. (Bug#10673)
3372 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3373 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3374 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3375
c5d3843c
KH
33762012-02-02 Kenichi Handa <handa@m17n.org>
3377
3378 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3379 0, do not call append_composite_glyph.
3380
159462d4 33812012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3382
3383 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3384 NULL (Bug#6988).
3385 (x_produce_glyphs): If the component of a composition is a null
3386 string, set it->pixel_width to 1 to avoid zero-width glyph.
3387
78cef877
EZ
33882012-02-01 Eli Zaretskii <eliz@gnu.org>
3389
3390 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3391 first 2 arguments are identical. This makes inserting large
3392 output from a subprocess an order of magnitude faster on
3393 MS-Windows, where all sbrk'ed memory is always contiguous.
3394
97897668
GM
33952012-01-31 Glenn Morris <rgm@gnu.org>
3396
3397 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3398 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3399 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3400
31fd3586
GM
34012012-01-29 Glenn Morris <rgm@gnu.org>
3402
3403 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3404
0e24a8b2
CY
34052012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3406
3407 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3408
cc0adcb0
CY
34092012-01-28 Chong Yidong <cyd@gnu.org>
3410
3411 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3412
acc28cb9
CY
34132012-01-26 Chong Yidong <cyd@gnu.org>
3414
9c69cfb7
CY
3415 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3416
acc28cb9
CY
3417 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3418 repeat counts (Bug#10507).
3419
48da7392
GM
34202012-01-26 Glenn Morris <rgm@gnu.org>
3421
3422 * lread.c (syms_of_lread): Doc fix.
3423
14af5f7f
CY
34242012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3425
3426 * coding.c (encode_designation_at_bol): Change return value to
3427 EMACS_INT.
3428
0b21c100
CY
34292012-01-25 Chong Yidong <cyd@gnu.org>
3430
3431 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3432
3c2907f7
CY
34332012-01-21 Chong Yidong <cyd@gnu.org>
3434
3435 * floatfns.c (Fcopysign): Make the second argument non-optional,
3436 since nil is not allowed anyway.
3437
959ad23f
AS
34382012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3439
3440 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3441 (send_process): Likewise.
3442
34a02f46
MR
34432012-01-19 Martin Rudalics <rudalics@gmx.at>
3444
3445 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3446 (Vwindow_persistent_parameters): Do not use Qstate.
3447 Rewrite doc-strings.
34a02f46 3448
1259009a 34492012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3450
3451 * character.c (char_width): New function.
70d4fdf6
GM
3452 (Fchar_width, c_string_width, lisp_string_width):
3453 Use char_width (Bug#9496).
25ed9e61 3454
6a6ee00d
MR
34552012-01-16 Martin Rudalics <rudalics@gmx.at>
3456
3457 * window.c (Vwindow_persistent_parameters): New variable.
3458 (Fset_window_configuration, save_window_save): Handle persistent
3459 window parameters.
3460
c85efaf7
EZ
34612012-01-14 Eli Zaretskii <eliz@gnu.org>
3462
3463 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3464 thrashing the stack of the thread. (Bug#9087)
3465
5944709e
PE
34662012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3469
e71f5d99
EZ
34702012-01-11 Eli Zaretskii <eliz@gnu.org>
3471
3472 * xdisp.c (rows_from_pos_range): Handle the case where the
3473 highlight ends on a newline. (Bug#10464)
3474 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3475 he end column for display of highlight that ends on a newline
3476 before a R2L line.
3477
ce316182
GM
34782012-01-11 Glenn Morris <rgm@gnu.org>
3479
3480 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3481 from load-path also when installation-directory is nil. (Bug#10208)
3482
5b43da69
GM
34832012-01-10 Glenn Morris <rgm@gnu.org>
3484
74cc8ff9
GM
3485 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3486
7d8d6e4e
GM
3487 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3488 Update template values to be closer to their typical values these days.
5b43da69 3489
a0db8d43
EZ
34902012-01-09 Eli Zaretskii <eliz@gnu.org>
3491
3492 * xdisp.c (rows_from_pos_range): Accept additional argument
3493 DISP_STRING, and accept any glyph in a row whose object is that
3494 string as eligible for mouse highlight. Fixes mouse highlight of
3495 display strings from overlays. (Bug#10464)
3496
9a0115ab 34972012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3498
b9110d6a 3499 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3500 * fileio.c (auto_saving_dir_umask): New static var.
3501 (Fmake_directory_internal): Use it.
3502 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3503 creating the directory. The old code temporarily assigns
3504 too-generous permissions to the directory.
3505 (do_auto_save_eh): Clear it.
b9110d6a 3506 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3507 that the var is always cleared.
3508
6c1bd3f3
EZ
35092012-01-07 Eli Zaretskii <eliz@gnu.org>
3510
3511 * search.c (scan_buffer): Pass character positions to
3512 know_region_cache, not byte positions. (Bug#6540)
3513
069d2b50
L
35142012-01-07 LynX <_LynX@bk.ru> (tiny change)
3515
3516 * w32.c (sys_rename): Report EXDEV when rename of a directory
3517 fails because the target is on another logical disk. (Bug#10284)
3518
75bf0d33
DB
35192012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3520
3521 * xterm.c (x_embed_request_focus): New function.
3522
3523 * xterm.h: Add prototype.
3524
3525 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3526
1c6e5a32
GM
35272012-01-05 Glenn Morris <rgm@gnu.org>
3528
3529 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3530
651e947e
EZ
35312012-01-01 Eli Zaretskii <eliz@gnu.org>
3532
3533 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3534 Load gnutls_transport_set_lowat only if GnuTLS version is below
3535 2.11.1.
3536 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3537 GnuTLS versions below 2.11.1.
3538
3778cdd8
AL
35392011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3540
3541 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3542 to the doc string advising against its use for altering the way
3543 windows are scrolled.
3544
0e5317f7
KH
35452011-12-28 Kenichi Handa <handa@m17n.org>
3546
3547 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3548 coding-system ASCII compatible only when it does not produce BOM
3549 on encoding (Bug#10383).
3550
93d5ca1f
JD
35512011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3554 can scroll.
3555 (create_and_show_popup_menu): Always use menu_position_func for
3556 Gtk3 (Bug#10361).
3557
ca22b785
AS
35582011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3559
3560 * callint.c (Fcall_interactively): Don't truncate prompt string.
3561
d048e1e6
EZ
35622011-12-23 Eli Zaretskii <eliz@gnu.org>
3563
3564 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3565 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3566 resumed from there (after widening). (Bug#10360)
d048e1e6 3567
5ccaba1f
JD
35682011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3569
3570 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3571
204ee57f
JD
35722011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3573
b81d40f0
JB
3574 * nsterm.m (x_free_frame_resources):
3575 Release f->output_data.ns->miniimage.
204ee57f
JD
3576 (ns_index_color): Fix indentation. Do not retain
3577 color_table->colors[i].
3578
3579 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3580 before returning.
3581
3582 * nsfns.m (x_set_background_color): Assign return value from
3583 ns_index_color to face-background instead of NSColor*.
3584 (ns_implicitly_set_icon_type): Fix indentation.
3585 Change assignment in for loop to comparison.
3586
3587 * emacs.c (ns_pool): New variable.
3588 (main): Assign ns_pool.
3589 (Fkill_emacs): Call ns_release_autorelease_pool.
3590
3591 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3592 autorelease fdesc, release fdAttrs and tdict.
3593 (ns_get_covering_families): Release charset.
3594 (ns_findfonts): Release NSFontDescriptor created with new.
3595 (ns_uni_to_glyphs): Fix indentation.
3596 (setString): Release attrStr before assigning new value.
3597
c803b2b7
JD
35982011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3599
678f4426
JD
3600 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3601 and NS_IMPL_COCOA.
3602 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3603 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3604
cd394be1 36052011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3606
5fecd5fc
JD
3607 * nsterm.m (ns_term_init): Subscribe for notifications
3608 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3609 to method trackingNotification in EmacsMenu.
3610
3611 * nsmenu.m (trackingMenu): New variable.
3771cb17 3612 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3613 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3614 from Aquamacs (Bug#7030).
678f4426
JD
3615
36162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3617
c803b2b7
JD
3618 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3619 (symbol_to_nsstring): Fix indentation.
3620 (ns_symbol_to_pb): New function.
cae07000
SM
3621 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3622 (Fns_rotate_cut_buffers_internal): Remove.
3623 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3624 Fns_store_cut_buffer_internal.
3625 (ns_get_foreign_selection, Fx_own_selection_internal)
3626 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3627 (Fns_get_selection_internal, Fns_store_selection_internal):
3628 Use ns_symbol_to_pb and check if return value is nil.
3629 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3630 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3631 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3632 renamed to Sns_store_selection_internal.
3633 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3634 and remove this function.
3635 (ns_handle_selection_clear): Remove, never used.
3636 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3637 here.
3638
e1b01a3a
KB
36392011-12-17 Ken Brown <kbrown@cornell.edu>
3640
3641 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3642 GID is unknown (Bug#10257).
3643
2adb6e85
PE
36442011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3647 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3648 which caused a build failure on GNU/Linux IA-64. This problem was
3649 introduced by my 2011-10-07 patch.
3650
d1d7b339
JL
36512011-12-15 Juri Linkov <juri@jurta.org>
3652
3653 * image.c (imagemagick_error): New function. (Bug#10112)
3654 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3655 Use `imagemagick_error' where ImageMagick functions return
3656 `MagickFalse'.
3657 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3658 proper order.
3659
100d5755
KH
36602011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3661
3662 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3663 fill background (Bug#8992).
3664
454592a6
MR
36652011-12-13 Martin Rudalics <rudalics@gmx.at>
3666
3667 * window.c (Vwindow_combination_resize)
3668 (Vwindow_combination_limit): Use t instead of non-nil in
3669 doc-strings.
61d4b438
MR
3670 (Vrecenter_redisplay): Add first sentence of doc-string on
3671 separate line.
53524d93 3672 (Frecenter): Fix doc-string typo.
454592a6 3673
3633e3aa
KH
36742011-12-11 Kenichi Handa <handa@m17n.org>
3675
3676 * coding.c (Funencodable_char_position): Pay attention to the
3677 buffer text relocation (Bug#9389).
3678
7b9d523a 36792011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3680
7b9d523a
JD
3681 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3682 gtk_init (Bug#10100).
3683
b73189c6
EZ
36842011-12-10 Eli Zaretskii <eliz@gnu.org>
3685
3686 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3687 IT->string is nil. (Bug#10263)
3688
f7dfe5d6
JD
36892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3690
83faebb4
JD
3691 * nsterm.h (x_free_frame_resources): Declare.
3692
f7dfe5d6
JD
3693 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3694 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3695
3696 * nsterm.h (ns_get_defaults_value): Declare.
3697
3698 * nsterm.m (ns_default): Call ns_get_defaults_value.
3699
7cd4e72c
EZ
37002011-12-09 Eli Zaretskii <eliz@gnu.org>
3701
3702 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3703 (Bug#10170)
3704
b34d7317
YM
37052011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3706
3707 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3708 that where the value of an _OBJC_* symbol points to is in the .bss
3709 section (Bug#10240).
3710
76470ad1
KH
37112011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3712
3713 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3714 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3715
745fff94
KH
37162011-12-08 Kenichi Handa <handa@m17n.org>
3717
3718 * ftfont.c (get_adstyle_property): Fix previous change
3719 (Bug#10233).
3720
6e44397c
JB
37212011-12-07 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3724 dirs from the default value of EMACSLOADPATH (bug#10208).
3725
7efa6272
GM
37262011-12-07 Glenn Morris <rgm@gnu.org>
3727
3728 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3729 installation and source directories as well. (Bug#10208)
3730
f6fc4d87
CY
37312011-12-06 Chong Yidong <cyd@gnu.org>
3732
3733 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3734
2bf26180
GM
37352011-12-06 Glenn Morris <rgm@gnu.org>
3736
3737 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3738 as an error, not just -1. (Bug#10217)
3739
3a6ad4f0
CY
37402011-12-05 Chong Yidong <cyd@gnu.org>
3741
3742 * keyboard.c (process_special_events): New function.
3743 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3744
75a3b399
PE
37452011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 * coding.c (encode_designation_at_bol): Don't use uninitialized
3748 local variable (Bug#9318).
3749
c3c9e25e
KH
37502011-12-05 Kenichi Handa <handa@m17n.org>
3751
3752 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3753 return Qnil (Bug#8046, Bug#10193).
3754
5eb05ea3
KH
37552011-12-05 Kenichi Handa <handa@m17n.org>
3756
3757 * coding.c (encode_designation_at_bol): New args charbuf_end and
3758 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3759 (coding_set_source): Return how many bytes coding->source was
3760 relocated.
3761 (coding_set_destination): Return how many bytes
3762 coding->destination was relocated.
3763 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3764 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3765
37662011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3767
3768 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3769 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3770 macro (Bug#9318).
3771
37722011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3773
3774 The following changes are to fix Bug#9318.
3775
a79703f5 3776 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3777 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3778 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3779 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3780
7dbda6df
JB
37812011-12-05 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * lisp.h (process_quit_flag): Fix external declaration.
3784
6d5eb5b0
SM
37852011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 Don't macro-inline non-performance-critical code.
3788 * eval.c (process_quit_flag): New function.
3789 * lisp.h (QUIT): Use it.
3790
a0c3fad0
JD
37912011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3792
3793 * nsfns.m (get_geometry_from_preferences): New function.
3794 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3795
6c07aac2
AS
37962011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3797
3798 * emacs.c (Qkill_emacs): Define.
3799 (syms_of_emacs): Initialize it.
3800 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3801 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3802 (quit_throw_to_read_char): Add parameter `from_signal'.
3803 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3804 * lisp.h (QUIT): Call Fkill_emacs if requested.
3805
c052ead4
JD
38062011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3807
3808 * widget.c (update_wm_hints): Return if wmshell is null.
3809 (widget_update_wm_size_hints): New function.
3810
3811 * widget.h (widget_update_wm_size_hints): Declare.
3812
3813 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3814 widget_update_wm_size_hints (Bug#10104).
3815
9e49252b
EZ
38162011-12-03 Eli Zaretskii <eliz@gnu.org>
3817
3818 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3819 before a newline, prepare the bidi iterator for consuming the
3820 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3821 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3822
02b16839
JL
38232011-12-02 Juri Linkov <juri@jurta.org>
3824
3825 * search.c (Fword_search_regexp): New Lisp function created from
3826 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3827 (Fword_search_backward, Fword_search_forward)
3828 (Fword_search_backward_lax, Fword_search_forward_lax):
3829 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3830 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3831
0068070e
SM
38322011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 * fileio.c (Finsert_file_contents): Move after-change-function call
3835 to before the "handled:" label, since all "goto handled" appear in
3836 cases where the *-change-functions have already been properly called
3837 (bug#10117).
3838
3360a3fc
AS
38392011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3842 waiting for input. (Bug#10169)
3843
73d6c093
EZ
38442011-11-30 Eli Zaretskii <eliz@gnu.org>
3845
3846 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3847 verifies glyph row's hash code--we have just reallocated the
3848 glyphs, so their contents can be complete garbage. (Bug#10164)
3849
febe6bea
JB
38502011-11-30 Juanma Barranquero <lekktu@gmail.com>
3851
3852 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3853
801a4313
EZ
38542011-11-30 Eli Zaretskii <eliz@gnu.org>
3855
3856 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3857 attributes are tested _before_ calling verify_row_hash, to protect
3858 against GCC re-ordering of the tests. (Bug#10164)
3859
2b56b87e
JD
38602011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3861
3862 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3863
3864 * xterm.c (handle_one_xevent): Only set async_visible and friends
3865 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3866 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3867 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3868
dbf31225
PE
38692011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3872 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3873 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3874 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3875 All uses changed to use GCPRO1 etc.
3876 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3877 Revert to old implementation (i.e., before 2011-03-11).
3878
1305621b
YM
38792011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3880
3881 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3882 of scroll runs so as to avoid assigning disabled bogus rows and
3883 unnecessary graphics copy operations.
3884
8c9afb46
EZ
38852011-11-27 Eli Zaretskii <eliz@gnu.org>
3886
3887 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3888 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3889 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3890 (malloc, free, realloc, calloc): Redirect to e_* only when
3891 compiling Emacs.
3892
3893 * lisp.h (GCTYPEBITS): Move before first use.
3894 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3895 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3896 this macro definition.
3897
3898 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3899 _MSC_VER.
3900
54e9e3bf
JD
39012011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3902
6d5eb5b0
SM
3903 * gtkutil.c (xg_create_frame_widgets):
3904 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3905 present with Gtk+ 2.0.
3906
83aca1cb
PE
39072011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * fileio.c (Finsert_file_contents): Undo previous change; see
3910 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3911
5b76caa4
PE
39122011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 Rename locals to avoid shadowing.
3915 * fileio.c (Finsert_file_contents):
3916 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3917 * process.c (wait_reading_process_output):
3918 Rename inner 'proc' to 'p' to avoid shadowing.
3919 Indent for consistency with usual Emacs style.
3920
8c535114
EZ
39212011-11-25 Eli Zaretskii <eliz@gnu.org>
3922
3923 * xdisp.c (redisplay_window): If cursor row is not fully visible
3924 after recentering, and scroll-conservatively is set to a large
3925 number, scroll window by a few more lines to make the cursor fully
3926 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3927 (start_display): Don't move to the next line if the display should
3928 start at a newline that is part of a display vector or an overlay
3929 string. (Bug#10119)
8c535114 3930
fa4fdb5c
JL
39312011-11-24 Juri Linkov <juri@jurta.org>
3932
3933 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3934 after the `MagickPingImage' call. (Bug#10112)
3935
90ec88df
CY
39362011-11-23 Chong Yidong <cyd@gnu.org>
3937
3938 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3939
56e2e794
MR
39402011-11-23 Martin Rudalics <rudalics@gmx.at>
3941
3942 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3943 making another buffer current. (Bug#10114)
3944
b6e64c41
GM
39452011-11-23 Glenn Morris <rgm@gnu.org>
3946
3947 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3948
6b21de18
CY
39492011-11-23 Chong Yidong <cyd@gnu.org>
3950
3951 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3952 using it (Bug#5984).
3953
b12cd789
EZ
39542011-11-22 Eli Zaretskii <eliz@gnu.org>
3955
3956 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3957 and header-lines, as they don't have one computed for them.
3958 (Bug#10098)
3959
3960 * .gdbinit (prow): Make displayed values more self-explaining.
3961 Add row's hash code.
3962
261b6fd4
LMI
39632011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3964
3965 * process.c (wait_reading_process_output): Fix asynchrounous
3966 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3967 (wait_reading_process_output): Add comment and URL.
261b6fd4 3968
e7cfd277
JD
39692011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3970
3971 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3972
a9b9b7f5
CY
39732011-11-21 Chong Yidong <cyd@gnu.org>
3974
3975 * window.c (Fnext_window, Fprevious_window): Doc fix.
3976
b0d15b4f
SM
39772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3978
3979 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3980
fe7a3057
JB
39812011-11-20 Juanma Barranquero <lekktu@gmail.com>
3982
3983 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3984
d2999b1a
MR
39852011-11-20 Martin Rudalics <rudalics@gmx.at>
3986
3987 * window.c (Fset_window_combination_limit): Rename argument
3988 STATUS to LIMIT.
3989 (Vwindow_combination_limit): Remove "status" from doc-string.
3990
d5ff9cd0
AS
39912011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3992
3993 * m/ibms390.h: Remove.
3994 * m/ibms390x.h: Don't include "ibms390.h".
3995
a5bb9bd3
SM
39962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3997
3998 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3999 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4000
cd1181db
JB
40012011-11-20 Juanma Barranquero <lekktu@gmail.com>
4002
4003 * casetab.c (Fset_case_table):
4004 * charset.c (Fcharset_after): Fix typos.
4005
615a3b8d 40062011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4007
17e845af
PE
4008 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4009 Otherwise, valgrind does not work on some platforms.
4010 Problem reported by Andreas Schwab in
6a0bf43d
PE
4011 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4012 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4013 is set, removing the need for VIRT_ADDRESS_VARIES.
4014 (PURE_P): Use a more-efficient implementation that needs just one
4015 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4016 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4017 to 4 (xorl, subq, cmpq, setbe).
4018 * alloc.c (pure): Always extern now, since that's the
4019 VIRT_ADDR_VARIES behavior.
4020 (PURE_POINTER_P): Use a single comparison, not two, for
4021 consistency with the new puresize.h.
4022 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4023 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4024 Remove VIRT_ADDR_VARIES no longer needed.
4025
f8fe6f96
EZ
40262011-11-19 Eli Zaretskii <eliz@gnu.org>
4027
4028 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4029 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4030 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4031 behave as if the cursor position were at the window margin.
4032
4033 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4034 and the cursor position is out of bounds, behave as if the cursor
4035 position were at the window margin. (Bug#10075)
4036
df05a53c
CY
40372011-11-18 Chong Yidong <cyd@gnu.org>
4038
4039 * window.c (Fwindow_combination_limit): Make first argument
4040 non-optional, since it is meaningless for live windows like the
4041 selected window.
61ccba97 4042
2071918e
DA
40432011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4044
4045 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4046
b50a28de
SM
40472011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4048
4049 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4050 (graft_intervals_into_buffer): Simplify.
4051
015137db
EZ
40522011-11-18 Eli Zaretskii <eliz@gnu.org>
4053
4054 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4055 hash values of the two rows.
4056 (copy_row_except_pointers): Preserve the used[] arrays and the
4057 hash values of the two rows. (Bug#10035)
68c95424 4058 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4059
4060 * xdisp.c (row_hash): New function, body extracted from
4061 compute_line_metrics.
4062 (compute_line_metrics): Call row_hash, instead of computing the
4063 hash code inline.
4064
4065 * dispnew.c (verify_row_hash): Call row_hash for computing the
4066 hash code of a row, instead of duplicating code from xdisp.c.
4067
4068 * dispextern.h (row_hash): Add prototype.
4069
a2addb04
TH
40702011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4071
4072 * frame.c (delete_frame): Don't delete the terminal when the last
4073 X frame is closed if emacs is built with GTK toolkit.
4074
df85d315
JB
40752011-11-17 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4078
a0c2d0ae
MR
40792011-11-17 Martin Rudalics <rudalics@gmx.at>
4080
4081 * window.c (Vwindow_splits): Rename to
4082 Vwindow_combination_resize. Suggested by Juri Linkov.
4083 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4084 of Vwindow_splits.
4085
58179cce
JB
40862011-11-16 Juanma Barranquero <lekktu@gmail.com>
4087
7877f373
JB
4088 * nsfns.m (Fns_font_name):
4089 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4090
b6f67890
MR
40912011-11-16 Martin Rudalics <rudalics@gmx.at>
4092
4093 * window.h (window): Rename slot "nest" to "combination_limit".
4094 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4095 (Fset_window_nest): Rename to Fset_window_combination_limit.
4096 (Vwindow_nest): Rename to Vwindow_combination_limit.
4097 (recombine_windows, make_parent_window, make_window)
4098 (Fsplit_window_internal, saved_window)
4099 (Fset_window_configuration, save_window_save): Rename all
4100 occurrences of window_nest to window_combination_limit.
4101
c7015153
JB
41022011-11-15 Juanma Barranquero <lekktu@gmail.com>
4103
4104 * image.c (imagemagick_load_image): Fix typo.
4105
322ad6ec
EZ
41062011-11-14 Eli Zaretskii <eliz@gnu.org>
4107
4108 * xdisp.c (display_line): Move the call to
4109 highlight_trailing_whitespace before the call to
4110 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4111 faces of all the glyphs to compute ROW's hash value.
4112 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4113
f067b8ec
JB
41142011-11-14 Juanma Barranquero <lekktu@gmail.com>
4115
4116 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4117 just return (bug#10044).
4118
1e5b2111
EZ
41192011-11-12 Eli Zaretskii <eliz@gnu.org>
4120
7ef3cbd5
EZ
4121 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4122 with user-defined heap size. Bump the default size of the temacs
4123 heap to 27MB, to avoid memory warning when running temacs.
4124 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4125
1e5b2111
EZ
4126 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4127 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4128 (verify_row_hash) [XASSERTS]: New function.
4129 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4130 that the hash value of glyph rows is correct.
1e5b2111 4131
89d61221
MR
41322011-11-12 Martin Rudalics <rudalics@gmx.at>
4133
4134 * window.h (window): Remove splits slot.
4135 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4136 (Fdelete_other_windows_internal, make_parent_window)
4137 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4138 (Fset_window_configuration, save_window_save): Don't deal with
4139 split status of windows.
4140 (saved_window): Remove splits slot.
4141 (Vwindow_splits): Rewrite doc-string.
4142
97f18cc8
JD
41432011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4144
4145 * xfns.c (unwind_create_frame):
4146 * nsfns.m (unwind_create_frame):
4147 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4148 Vframe_list (Bug#9999).
4149
22a648b4
DA
41502011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4151
0b381c7e 4152 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4153
659afede
KH
41542011-11-11 Kenichi Handa <handa@m17n.org>
4155
4156 * callproc.c (Fcall_process): Set the member dst_multibyte of
4157 process_coding.
4158
9ac0394b
KH
41592011-11-11 Johan Bockgård <bojohan@gnu.org>
4160
4161 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4162 avoid a crash (bug#9496).
4163
2fbdc249
CY
41642011-11-09 Chong Yidong <cyd@gnu.org>
4165
4166 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4167 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4168
ac6b1f81
PE
41692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4172
09db192c
PE
41732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 Avoid some portability problems by eschewing 'extern inline' functions.
4176 The trivial performance wins aren't worth the portability hassles; see
4177 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4178 et seq.
4179 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4180 (window_box_width, window_box_left, window_box_left_offset)
4181 (window_box_right, window_box_right_offset): Undo previous change,
4182 by removing the "extern"s.
4183 * intervals.c (adjust_intervals_for_insertion)
4184 (adjust_intervals_for_deletion): Undo previous change,
4185 making these static again.
4186 (offset_intervals, temp_set_point_both, temp_set_point)
4187 (copy_intervals_to_string): No longer inline.
4188 * xdisp.c (window_text_bottom_y, window_box_width)
4189 (window_box_height, window_box_left_offset)
4190 (window_box_right_offset, window_box_left, window_box_right)
4191 (window_box): No longer inline.
4192
105216ed
CY
41932011-11-08 Chong Yidong <cyd@gnu.org>
4194
4195 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4196 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4197 Signal an error if not a live window.
105216ed
CY
4198 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4199 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4200
ae9e237f
JB
42012011-11-07 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * lisp.h (syms_of_abbrev): Remove declaration.
4204 Reported by CHENG Gao <chenggao@royau.me>.
4205
c7aa8333
EZ
42062011-11-07 Eli Zaretskii <eliz@gnu.org>
4207
4208 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4209 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4210 of temacs in GUI mode.
4211
be7f5545
MR
42122011-11-07 Martin Rudalics <rudalics@gmx.at>
4213
4214 * window.h: Declare delete_all_child_windows instead of
4215 delete_all_subwindows.
4216 * window.c (Fwindow_nest, Fset_window_nest)
4217 (Fset_window_new_total, Fset_window_new_normal)
4218 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4219 (delete_all_subwindows): Rename to delete_all_child_windows.
4220 (Fdelete_other_windows_internal, Fset_window_configuration):
4221 Call delete_all_child_windows instead of delete_all_subwindows.
4222 * frame.c (delete_frame): Call delete_all_child_windows instead
4223 of delete_all_subwindows.
4224
ca78dc43
PE
42252011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4228 This is also needed for porting to any host where GC_MARK_STACK is
4229 not GC_MAKE_GCPROS_NOOPS.
4230 (which_symbols): Use it.
4231
a0241d01
KH
42322011-11-07 Kenichi Handa <handa@m17n.org>
4233
4234 * coding.c (coding_set_destination): Check coding->src_pos only
4235 when coding->src_object is a buffer (bug#9910).
4236
4237 * process.c (send_process): Set the member src_multibyte of coding
4238 to 0 (bug#9911) when sending a unibyte text.
4239
4240 * callproc.c (Fcall_process): Set the member src_multibyte of
4241 process_coding to 0 (bug#9912).
4242
a64bfdfa 42432011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4244
4245 * xmenu.c (cleanup_widget_value_tree): New function.
4246 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4247 calling free_menubar_widget_value_tree directly (Bug#9830).
4248
cb41b32a
PE
42492011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 Fix some portability problems with 'inline'.
4252 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4253 (window_box_width, window_box_left, window_box_left_offset)
4254 (window_box_right, window_box_right_offset): Declare extern.
4255 Otherwise, these inline functions do not conform to C99 and
4256 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4257 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4258 * intervals.c (adjust_intervals_for_insertion)
4259 (adjust_intervals_for_deletion): Now extern, because otherwise the
4260 extern inline functions 'offset_intervals' couldn't refer to it.
4261 (static_offset_intervals): Remove.
4262 (offset_intervals): Rewrite using the old contents of
4263 static_offset_intervals. The old version didn't conform to C99
4264 because an extern inline function contained a reference to an
4265 identifier with static linkage.
4266
b7041366
AS
42672011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4268
4269 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4270 GC.
4271
88a37c4d
EZ
42722011-11-06 Eli Zaretskii <eliz@gnu.org>
4273
4274 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4275 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4276 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4277 return Qleft_to_right.
4278
49745b39
CY
42792011-11-06 Chong Yidong <cyd@gnu.org>
4280
4281 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4282 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4283 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4284 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4285 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4286 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4287 (Fwindow_vscroll): Doc fix.
4288 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4289 argument, since it makes no sense to pass a live window and for
4290 consistency with window-child.
4291
1f05cd82
CS
42922011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4293
4294 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4295 support MSVC.
4296
22610910
JR
42972011-11-05 Jason Rumney <jasonr@gnu.org>
4298
4299 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4300 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4301 fonts (Bug#6029).
4302 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4303 bitwise arithmetic preventing use of unicode-sip and non-truetype
4304 opentype fonts.
4305
a06776b2
EZ
43062011-11-05 Eli Zaretskii <eliz@gnu.org>
4307
3ad924ba
EZ
4308 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4309 "emacs"-only part.
4310
a06776b2
EZ
4311 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4312 initialization code to keep similarity to xfns.c after changes
4313 from 2011-11-05.
4314
c9e7db78
JD
43152011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4316
a97f8f3f
JD
4317 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4318 (unwind_create_frame): New function (Bug#9943).
4319 (Fx_create_frame): Restructure code to be more similar to the one in
4320 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4321 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4322 Move terminal->reference_count++ just before making the frame official
4323 (Bug#9943).
4324
4325 * nsterm.m (x_free_frame_resources): New function.
4326 (x_destroy_window): Move code to x_free_frame_resources.
4327
c9e7db78 4328 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4329 (Fx_create_frame, x_create_tip_frame):
4330 Move terminal->reference_count++ just before making the frame
75f1671a 4331 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4332 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4333
a6fc3b5c
EZ
43342011-11-05 Eli Zaretskii <eliz@gnu.org>
4335
4336 Support MSVC build with newer versions of Visual Studio.
4337 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4338 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4339 nt/gmake.defs.
4340
4341 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4342 which are not supported by MSVC.
4343 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4344 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4345 bitfields.
4346 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4347 types in bitfields.
4348 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4349
4350 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4351
58179cce 43522011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4353
4354 Support MSVC build with newer versions of Visual Studio.
4355 * w32.c: Don't include w32api.h for MSVC.
4356 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4357
4358 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4359 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4360 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4361 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4362 e_* cousins.
4363 (alloca) [_MSC_VER]: Define to _alloca.
4364
4365 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4366
4367 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4368
a58c13ed
EZ
43692011-11-04 Eli Zaretskii <eliz@gnu.org>
4370
4371 * xdisp.c (note_mouse_highlight): If either of
4372 previous/next-single-property-change returns nil, treat that as
4373 the beginning or the end of the buffer. (Bug#9955)
4374
fe0b6370
JD
43752011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4376
a58c13ed 4377 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4378 label is not null (Bug#9951).
4379 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4380 may be NULL.
4381
89bd5ee1
EZ
43822011-11-04 Eli Zaretskii <eliz@gnu.org>
4383
4384 * window.c (Fwindow_body_size): Mention in the doc string that the
4385 return value is in frame's canonical units. (Bug#9949)
4386
84c3edb9
EZ
43872011-11-03 Eli Zaretskii <eliz@gnu.org>
4388
4e2fb5c7
EZ
4389 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4390
84c3edb9 4391 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4392 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4393 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4394
bc17a887
EZ
43952011-11-01 Eli Zaretskii <eliz@gnu.org>
4396
4397 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4398 Don't stop backward scan on the continuation glyph, even though
4399 its CHARPOS is positive.
6d5eb5b0
SM
4400 (mouse_face_from_buffer_pos, note_mouse_highlight):
4401 Rename cover_string to disp_string.
bc17a887 4402
4ee88440
MR
44032011-11-01 Martin Rudalics <rudalics@gmx.at>
4404
4405 * window.c (temp_output_buffer_show): Don't use
4406 Vtemp_buffer_show_specifiers.
4407 (Vtemp_buffer_show_specifiers): Remove unused variable.
4408
c2ff3c02
EZ
44092011-10-30 Eli Zaretskii <eliz@gnu.org>
4410
4411 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4412 past the beginning of the current glyph matrix.
4413
58179cce 44142011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4415
4416 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4417 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4418 HAVE_GTK3 (Bug#9869).
b77a6a7f 4419
3b574623
JD
4420 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4421 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4422
b77a6a7f
JD
4423 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4424
4425 * xterm.c: Declare x_handle_net_wm_state to return int.
4426 (handle_one_xevent): Check if we are iconified but don't have
4427 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4428 (get_current_wm_state): Return non-zero if not hidden,
4429 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4430 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4431 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4432 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4433
196e41e4
PE
44342011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4437 so that this new function doesn't get optimized away by a
4438 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4439
021f2e1a
AS
44402011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4441
4442 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4443
8b058d44
EZ
44442011-10-29 Eli Zaretskii <eliz@gnu.org>
4445
4446 Fix the `xbytecode' command.
4447 * .gdbinit (xprintbytestr): New command.
b50a28de 4448 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4449 (xbytecode): Print the byte-code string as well.
4450
4452fb80
EZ
44512011-10-29 Kim Storm <storm@cua.dk>
4452
8b058d44
EZ
4453 * alloc.c (which_symbols): New function.
4454
21b72067
AS
44552011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4456
4457 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4458 line. (Bug#9903)
4459
83ed7b5c
GM
44602011-10-29 Glenn Morris <rgm@gnu.org>
4461
4462 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4463 Not clear what it was for, and it causes various bugs. (Bug#9839)
4464
5a7a728b
EZ
44652011-10-28 Eli Zaretskii <eliz@gnu.org>
4466
4467 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4468 possible random value that matches one of those tested as
4469 condition to clear the mouse face.
4470
d3d0842f
CY
44712011-10-28 Chong Yidong <cyd@gnu.org>
4472
4473 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4474
31b39d13
DN
44752011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4476
4477 * window.c (make_window): Initialize phys_cursor_on_p.
4478
9aba6043
SM
44792011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4480
4481 * lisp.h (struct Lisp_Symbol): Update comments.
4482
c20992f4
JB
44832011-10-28 Juanma Barranquero <lekktu@gmail.com>
4484
4485 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4486
db4f02f2
EZ
44872011-10-28 Eli Zaretskii <eliz@gnu.org>
4488
4489 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4490 <oslsachem@gmail.com> for helping to debug this.
4491
4492 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4493 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4494 (g_b_init_get_glyph_outline_w): New static variables.
4495 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4496 (GetGlyphOutlineW_Proc): New typedefs.
4497 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4498 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4499 New functions.
4500 (w32font_open_internal, compute_metrics):
4501 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4502 instead of calling the "wide" APIs directly.
4503
4504 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4505
4506 * w32.h (syms_of_w32font): Add prototype.
4507
87e68db4
JB
45082011-10-27 Juanma Barranquero <lekktu@gmail.com>
4509
4510 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4511 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4512 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4513 (Fmove_to_window_line): Doc fix.
4514
435c1d67
CY
45152011-10-27 Chong Yidong <cyd@gnu.org>
4516
4517 * process.c (make_process): Set gnutls_state to NULL.
4518
4519 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4520 non-NULL, regardless of GNUTLS_INITSTAGE.
4521 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4522 an error. Set process slots as soon as we allocate them.
4523
4524 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4525
9c6c6f49
CY
45262011-10-27 Chong Yidong <cyd@gnu.org>
4527
9aba6043
SM
4528 * gnutls.c (emacs_gnutls_deinit): New function.
4529 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4530 (Fgnutls_deinit, Fgnutls_boot): Use it.
4531
4532 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4533 (deactivate_process): Call emacs_gnutls_deinit.
4534
657d08d3
JB
45352011-10-27 Juanma Barranquero <lekktu@gmail.com>
4536
4537 * image.c (x_create_x_image_and_pixmap):
4538 * w32.c (sys_rename, w32_delayed_load):
4539 * w32font.c (fill_in_logfont):
4540 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4541
5430d399
JB
45422011-10-26 Juanma Barranquero <lekktu@gmail.com>
4543
4544 * w32fns.c (w32_default_color_map): New function,
4545 extracted from Fw32_default_color_map.
a7ef684b 4546 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4547
fe0055fa
PE
45482011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4549
4550 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4551
e6346438
SM
45522011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4553
4554 * keyboard.c (test_undefined): New function (bug#9751).
4555 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4556
e112cc37
ET
45572011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4558
4559 * sysdep.c (init_sys_modes): Fix the check for the controlling
4560 terminal (Bug#6649).
4561
7b5d6677
EZ
45622011-10-20 Eli Zaretskii <eliz@gnu.org>
4563
4564 * dispextern.h (struct bidi_it): New member next_en_type.
4565
4566 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4567 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4568 current character, check also for next_en_type being WEAK_EN.
4569 (bidi_resolve_weak): Don't enter the expensive loop if the current
4570 position is before next_en_pos. Record the bidi type of the first
4571 non-ET, non-BN character we find, in addition to its position.
4572 (bidi_level_of_next_char): Invalidate next_en_type when
4573 next_en_pos is over-stepped.
4574
7da0b018
PE
45752011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4578 * editfns.c: Rewrite current-time-zone so that it invokes
4579 the equivalent of (format-time-string "%Z") to get the time zone name.
4580 This fixes a bug when the time zone name contains characters that
4581 need converting from the system time locale to Emacs internal format.
4582 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4583 that patch fixed format-time-string to do the conversion, but
4584 I forgot to fix current-time-zone.
4585 (format_time_string): New function, containing most of
4586 what Fformat_time_string used to contain.
4587 (Fformat_time_string): Rewrite in terms of format_time_string.
4588 This doesn't change this function's behavior.
4589 (current-time-zone): Rewrite to use format_time_string.
4590 This fixes the bug reported by Michael Schierl in
4591 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4592 Jason Rumney's 2007-06-07 change worked around this bug, but
4593 didn't fix it.
4594 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4595
8547b010
EZ
45962011-10-19 Eli Zaretskii <eliz@gnu.org>
4597
4598 * xdisp.c (start_display): If the character at POS is displayed
4599 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4600 (try_window_reusing_current_matrix): If a line ends in a display
4601 vector or the next line starts in a display vector, continue
4602 redrawing the window even though the character position of
4603 start_row was reached.
8547b010
EZ
4604 (Bug#9771, part 2)
4605
4e948d15
CY
46062011-10-18 Chong Yidong <cyd@gnu.org>
4607
4608 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4609 with nobreak-char-display too.
4610
4787455f
EZ
46112011-10-18 Eli Zaretskii <eliz@gnu.org>
4612
4613 Fix part 3 of bug#9771.
4614 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4615 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4616 non-neutral characters if the current character is a paragraph
4617 separator (a.k.a. Newline). This avoids running the same
4618 expensive loop twice, once when we consume the preceding newline
4619 and the other time when the line actually needs to be displayed.
4620 Avoid the loop when we see neutrals on the base embedding level
4621 following a character whose directionality is the same as the
4622 paragraph's. This avoids running the expensive loop when a line
4623 ends in a long sequence of neutrals, like control characters.
4624 Add assertion against STRONG_AL type. Slightly rearrange code
4625 that determines the type of a neutral given the first non-neutral
4626 that follows it.
4627 (bidi_level_of_next_char): Set next_en_pos to zero when
4628 invalidating its info.
4629
2c91f553
EZ
46302011-10-17 Eli Zaretskii <eliz@gnu.org>
4631
4632 * xdisp.c (push_display_prop): Determine whether to record string
4633 or buffer position by IT->string, not by IT->method. Allow
4634 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4635 (move_it_vertically_backward): Don't look for character position
4636 immediately after the newline when in a continuation line.
4637 (Bug#9771, part 1)
2c91f553 4638
c7b08b0d
MR
46392011-10-15 Martin Rudalics <rudalics@gmx.at>
4640
4641 * window.c (coordinates_in_window): Rewrite and delabelize
4642 vertical border check. (Bug#5357) (Bug#9618)
4643
6b02f655
SM
46442011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4645
4646 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4647 errors in XSetWindowBorder (bug#9310).
4648
81d40c92
DA
46492011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4650
4651 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4652 avoid crash when xmalloc overrun checking is enabled.
4653
d4172c3b
EZ
46542011-10-13 Eli Zaretskii <eliz@gnu.org>
4655
4656 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4657 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4658 cursor motion with <left> and <right> arrow keys.
4659
4660 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4661 some callers set that themselves.
4662
b00eea75
EZ
46632011-10-12 Eli Zaretskii <eliz@gnu.org>
4664
4665 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4666 display string and the previous row comes from the same string and
4667 is empty. (Bug#9739) (Bug#9738)
4668
8fe012c4
SM
46692011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4670
4671 * doc.c (get_doc_string): Encode file name (bug#9735).
4672
0074aef2
EZ
46732011-10-12 Eli Zaretskii <eliz@gnu.org>
4674
79beb178
EZ
4675 * bidi.c (bidi_level_of_next_char):
4676 * xdisp.c (get_visually_first_element): Remove old incorrect
4677 comments regarding the Unicode Line Separator character.
4678
0074aef2
EZ
4679 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4680
6e4b3fbe
DA
46812011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4682
4683 * alloc.c (Fgc_status): Do not access beyond zombies array
4684 boundary if nzombies > MAX_ZOMBIES.
4685 * alloc.c (dump_zombies): Add missing format specifier.
4686
0324f3af
PE
46872011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4688
b5525cac
PE
4689 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4690 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4691
0324f3af
PE
4692 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4693 Some packages use them to denote characters with modifiers.
4694
e9b5f888
AS
46952011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4696
4697 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4698 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4699 matching a pp-number. Rename parameter var to var1.
4700
127827c0
SM
47012011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4702
4703 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4704
c8fd3bd0
GM
47052011-10-08 Glenn Morris <rgm@gnu.org>
4706
4707 * callint.c (Fcall_interactively): Give a more explicit error for the
4708 'c' case with a non-character input. (Bug#8479)
4709
352ec8ff
EZ
47102011-10-08 Eli Zaretskii <eliz@gnu.org>
4711
03669ccb
EZ
4712 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4713 lines.
7061c986
EZ
4714 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4715 lines that are hscrolled on the left.
03669ccb 4716
352ec8ff
EZ
4717 * dispnew.c (buffer_posn_from_coords): Account for a possible
4718 presence of header-line. (Bug#4426)
4719
a66cfb1c
SM
47202011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4721
6b02f655
SM
4722 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4723 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4724
7c5ee88e
PE
47252011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4726
4727 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4728 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4729 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4730 this makes Emacs dump core during garbage collection on rare
4731 occasions. sizeof is obviously inferior to offsetof here, so
4732 stick with offsetof.
4733 (GC_POINTER_ALIGNMENT): New macro.
4734 (mark_memory): Omit 3rd (offset) arg; caller changed.
4735 Don't assume EMACS_INT alignment is the same as pointer alignment.
4736
df1bbe5b
SM
47372011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4738
4739 * keyboard.c (read_key_sequence_remapped): New var.
4740 (read_key_sequence): Compute remapping in the right buffer.
4741 (command_loop_1): Use read_key_sequence's remapping directly.
4742
51553db6
SM
47432011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4744
32c1fffd
SM
4745 * dired.c (file_name_completion): Don't expand file name.
4746 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4747 before checking file name handler.
4748
51553db6
SM
4749 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4750 they've been requested explicitly (bug#9591).
4751
b6bd1599 47522011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4753
4754 * keymap.c (Fsingle_key_description): Use make_specified_string
4755 instead of build_string to build string from push_key_description.
4756 (Bug#5193)
4757
f701dc2a
PE
47582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4759
4222c55d
PE
4760 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4761 This fixes a Y2038 bug on 64-bit hosts.
4762 * buffer.c (reset_buffer):
4763 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4764 (Fclear_buffer_auto_save_failure):
4765 Use 0, not -1, to represent an unset failure time, since time_t
4766 might not be signed.
4767
f701dc2a
PE
4768 Remove dependency on glibc malloc internals.
4769 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4770 Move back here from lisp.h, but with their new implementations.
4771 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4772 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4773 * charset.c (charset_table_init): New static var.
4774 (syms_of_charset): Use it instead of xmalloc. This removes a
4775 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4776 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4777 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4778 Move back to alloc.c.
4779 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4780 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4781
9ceebf39
JD
47822011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4783
4784 * nsterm.m (windowDidResize): Call x_set_window_size only when
4785 ns_in_resize is true. Otherwise set pixelwidth/height and
4786 call change_frame_size (Bug#9628).
4787
cb993c58
PE
47882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4789
3930c88b
PE
4790 Port --enable-checking=all to Fedora 14 x86-64.
4791 * charset.c (syms_of_charset): Also account for glibc malloc's
4792 internal overhead when calculating the initial malloc maximum.
4793
cb993c58
PE
4794 Port --enable-checking=all to Fedora 14 x86.
4795 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4796 Move to lisp.h.
4797 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4798 (overrun_check_realloc, overrun_check_free):
4799 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4800 That way, xmalloc returns a properly-aligned pointer even if
4801 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4802 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4803 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4804 into account when calculating the initial malloc maximum.
4805 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4806 Move here from alloc.c, so that charset.c can use it too.
4807 Properly align; the old code wasn't right for common 32-bit hosts
4808 when configured with --enable-checking=all.
4809 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4810 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4811
31bed486
EZ
48122011-09-29 Eli Zaretskii <eliz@gnu.org>
4813
04c70788 4814 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4815 use EDOM.
4816
fbcaa2f3
EZ
48172011-09-28 Eli Zaretskii <eliz@gnu.org>
4818
4819 * xdisp.c (compute_display_string_end): If there's no display
4820 string at CHARPOS, return -1.
4821
4822 * bidi.c (bidi_fetch_char): When compute_display_string_end
4823 returns a negative value, treat the character as a normal
4824 character not covered by a display string. (Bug#9624)
4825
a239d4e9
JB
48262011-09-28 Juanma Barranquero <lekktu@gmail.com>
4827
4828 * lread.c (Fread_from_string): Fix typo in docstring.
4829
88652fd5
EZ
48302011-09-27 Eli Zaretskii <eliz@gnu.org>
4831
4832 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4833 newline, reseat the iterator instead of bidi-iterating there one
4834 character at a time. (Bug#9610)
32c1fffd
SM
4835 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4836 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4837
ed497dd4
AS
48382011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4839
4840 * lread.c (readevalloop): Use correct code for NBSP.
4841 (read1): Likewise. (Bug#9608)
4842
b2bf61aa
MA
48432011-09-25 Michael Albinus <michael.albinus@gmx.de>
4844
4845 * dbusbind.c (Fdbus_register_signal): When service is not
4846 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4847
32bbb17c
GM
48482011-09-25 Glenn Morris <rgm@gnu.org>
4849
4850 * buffer.c (truncate-lines): Doc fix.
4851
94e0933e
CY
48522011-09-24 Chong Yidong <cyd@stupidchicken.com>
4853
4854 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4855 (Fset_window_next_buffers): Doc fix.
4856
cddde921
GM
48572011-09-24 Glenn Morris <rgm@gnu.org>
4858
4859 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4860
1260aef1
PE
48612011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4862
25b4bfa0
PE
4863 Fix minor problems found by static checking.
4864 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4865 * indent.c (Fvertical_motion): Fix == vs = typo.
4866
e3cbd34b
EZ
48672011-09-24 Eli Zaretskii <eliz@gnu.org>
4868
a66cfb1c
SM
4869 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4870 Default value is now t. Doc fix.
6bf7006f 4871
e3cbd34b 4872 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4873 logic when moving up, not only when moving down. Fix the
e3cbd34b 4874 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4875 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4876
4877 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4878 CHARPOS is covered by a display string which includes newlines.
4879 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4880 is covered by a display string with embedded newlines.
4881
a3de0cbd
MA
48822011-09-24 Michael Albinus <michael.albinus@gmx.de>
4883
4884 * dbusbind.c (Fdbus_register_signal): Add match rule to
4885 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4886 (Fdbus_register_method, Vdbus_registered_objects_table):
4887 Fix docstring.
a3de0cbd 4888
b260039d
JM
48892011-09-24 Jim Meyering <meyering@redhat.com>
4890
32c1fffd 4891 do not ignore write error for any output size
b260039d
JM
4892 The previous change was incomplete.
4893 While it makes emacs --batch detect the vast majority of stdout
4894 write failures, errors were still ignored whenever the output size is
4895 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4896 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4897 && echo FAIL: ignored write error
4898 FAIL: ignored write error
4899 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4900 && echo FAIL: ignored write error
4901 FAIL: ignored write error
4902 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4903
8eca8a7c
AS
49042011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4905
4906 * emacs.c (Fkill_emacs): In noninteractive mode exit
4907 non-successfully if a write error occurred on stdout. (Bug#9574)
4908
3341db62
EZ
49092011-09-21 Eli Zaretskii <eliz@gnu.org>
4910
4911 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4912 the xassert test.
4913
4914 * dispextern.h (struct it): Update the comment documenting what
4915 can it->OBJECT be.
4916
8c203dbf
EZ
49172011-09-20 Eli Zaretskii <eliz@gnu.org>
4918
4919 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4920 a display string, extend search for cursor position to end of row.
4921 (find_row_edges): If the row ends in a newline from a display
4922 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4923 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4924 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4925 non-empty line. Fixes confusing cursor motion with arrow keys at
4926 the beginning of a line that starts with whitespace.
8c203dbf 4927
a4824228
LMI
49282011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4929
4930 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4931 (bug#9493).
4932
33ed493b
CY
49332011-09-18 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4936 boolean (Bug#9154).
4937
56cd55c8
EZ
49382011-09-18 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (display_line): Record maximum and minimum buffer
4941 positions even if no glyphs were produced (e.g., by a zero-width
4942 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4943 buffer positions that will be removed from the glyph row because
4944 they don't fit.
c02dcedf
EZ
4945 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4946 column is beyond frame width: don't subtract 1 "pixel" when
4947 computing width of the stretch.
3e62b7e0
EZ
4948 (reseat_at_next_visible_line_start): Undo the change made on
4949 2011-09-17 that saved paragraph information and restored it after
4950 the call to `reseat'. (Bug#9545)
56cd55c8 4951
5ed99d36 49522011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4953
4954 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4955 and turn window cursor on if cleared (Bug#9415).
4956
5ed99d36 49572011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4958
4959 * search.c (boyer_moore): Take unibyte characters from pattern
4960 literally. (Bug#9458)
4961
9bade7b2
EZ
49622011-09-18 Eli Zaretskii <eliz@gnu.org>
4963
4964 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4965
e5e9d610
PE
49662011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4967
87e4427a
PE
4968 Fix minor problem found by static checking.
4969 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4970 initialized, to pacify gcc -Wuninitialized.
4971
e5e9d610
PE
4972 * fileio.c: Report proper errno when syscall falls.
4973 (Finsert_file_contents): Save and restore errno,
4974 so that report_file_error outputs the correct diagnostic.
4975 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4976
a1674f0b
EZ
49772011-09-18 Eli Zaretskii <eliz@gnu.org>
4978
4979 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4980
fbfb6dd4
EZ
49812011-09-17 Eli Zaretskii <eliz@gnu.org>
4982
4983 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4984 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4985
bb187662
EZ
49862011-09-17 Eli Zaretskii <eliz@gnu.org>
4987
1137e8b8 4988 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4989 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4990
4991 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4992 (bidi_find_paragraph_start): Search back for paragraph beginning
4993 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4994 (bidi_move_to_visually_next): Only trigger paragraph-related
4995 computations when the last character is a newline or at EOB, not
4996 just any NEUTRAL_B. (Bug#9470)
4997
bb187662
EZ
4998 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4999 truncated lines if point is covered by a display string. (Bug#9524)
5000
2e621251
PE
50012011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5002
5003 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5004 (cons_to_x_long): New function.
5005 (lisp_data_to_selection_data): Use it. Correct the test for
5006 short-versus-long data; it was negated. Break out of vector
5007 loop, for efficiency, when a long datum is discovered.
5008
91a15bc6
SM
50092011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5010
5011 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5012
b41c3a35
EZ
50132011-09-16 Eli Zaretskii <eliz@gnu.org>
5014
5015 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5016 GCC PR/17406) by declaring this function with external scope.
5017
7812ba2d
PE
50182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5021 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5022
cf7edc2a
AS
50232011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5024
5025 * editfns.c (Fformat): Correctly handle text properties on "%%".
5026
bd01620e
EZ
50272011-09-15 Eli Zaretskii <eliz@gnu.org>
5028
5029 * xterm.c (x_draw_composite_glyph_string_foreground):
5030 * w32term.c (x_draw_composite_glyph_string_foreground):
5031 * term.c (encode_terminal_code):
5032 * composite.c (composition_update_it, get_composition_id):
5033 * xdisp.c (get_next_display_element)
5034 (fill_composite_glyph_string): Add comments about special meaning
5035 of TAB characters in a composition.
5036
a02719a3
PE
50372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5040 This occurs when processing a multibyte format.
5041 Problem reported by Wolfgang Jenker.
a02719a3 5042
72589a3c
JB
50432011-09-15 Johan Bockgård <bojohan@gnu.org>
5044
5045 * xdisp.c (try_cursor_movement): Only check for exact match if
5046 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5047
1c14176c
PE
50482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5049
5050 Remove unused external symbols.
5051 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5052 * xdisp.c (calc_pixel_width_or_height): Now static.
5053 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5054 * indent.c (check_display_width):
5055 * w32term.c: Fix comment to match code.
5056 * xterm.c, xterm.h (x_catching_errors): Remove.
5057
d2eea5b5
PE
50582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5059
5060 * xselect.c: Use signed conversions more consistently (Bug#9498).
5061 (selection_data_to_lisp_data): Assume incoming selection data are
5062 signed integers, not unsigned. This is to be consistent with
5063 outgoing selection data, which was modified to use signed integers
5064 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5065 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5066 expects long, not unsigned long.
5067
46888499
EZ
50682011-09-14 Eli Zaretskii <eliz@gnu.org>
5069
5070 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5071 computation of loop end. Reported by Johan Bockgård
5072 <bojohan@gnu.org>.
5073
ef8ef9fb
CY
50742011-09-13 Chong Yidong <cyd@stupidchicken.com>
5075
5076 * frame.c (Fother_visible_frames_p): Function deleted.
5077
fa819fed
EZ
50782011-09-12 Eli Zaretskii <eliz@gnu.org>
5079
5080 * indent.c (compute_motion): Process display vector front to back
5081 rather than the other way around. (Bug#2496)
5082
2ba8e008
SM
50832011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5084
5085 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5086
20f53c69
CY
50872011-09-11 Chong Yidong <cyd@stupidchicken.com>
5088
5089 * minibuf.c (Fread_from_minibuffer): Doc fix.
5090
d562d7a4
EZ
50912011-09-11 Eli Zaretskii <eliz@gnu.org>
5092
5093 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5094 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5095
1c4d7f3d
LMI
50962011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5097
5098 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5099 value for non-existent files.
5100
b885bf36
EZ
51012011-09-11 Eli Zaretskii <eliz@gnu.org>
5102
5103 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5104 set its "size" to -1. This will set the modtime_size field of
5105 the corresponding buffer to -1, which is what
5106 verify-visited-file-modtime expects for files that do not exist.
5107 (Bug#9139)
5108
6612f0bf
PE
51092011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5112 here ...
5113 * lisp.h: ... from here. push_key_description is no longer
5114 defined in keyboard.c, so its declaration should not be in
5115 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5116 logically belongs with push_key_description.
5117
dfb3f755
PE
51182011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 * buffer.h: Include <sys/types.h> instead of <time.h>.
5121 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5122 Problem reported by Herbert J. Skuhra.
5123
3134906c
LMI
51242011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5125
5126 * xml.c (parse_region): Make the parsing work for
5127 non-comment-starting XML files again (bug#9144).
5128
8d903f4e
AS
51292011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5130
5131 * image.c (gif_load): Fix calculation of bottom and right corner.
5132 (Bug#9468)
5133
80ad64f4
EZ
51342011-09-10 Eli Zaretskii <eliz@gnu.org>
5135
5136 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5137 redisplay in small windows.
5138
208a048d
EZ
51392011-09-09 Eli Zaretskii <eliz@gnu.org>
5140
5141 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5142
9b1c252e
MR
51432011-09-08 Martin Rudalics <rudalics@gmx.at>
5144
5145 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5146 Operate on live windows only.
5147
2949f33b
JB
51482011-09-08 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5151
e08dcafd
EZ
51522011-09-07 Eli Zaretskii <eliz@gnu.org>
5153
5154 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5155 only under bidi iteration.
5156
115b96bd
JD
51572011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5158
5159 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5160
c8199d0f
PE
51612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5164 Without this fix, the command to link temacs failed due to an
5165 undefined symbol __builtin_isnan. This is because
5166 /usr/include/iso/math_c99.h #defines isnan(x) to
5167 __builtin_isnan(x), but the bundled gcc, which identifies itself
5168 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5169 a __builtin_isnan.
5170 * floatfns.c (isnan): #undef, and then #define to a clone of
5171 what's in data.c.
5172 (Fisnan): Always define, since it's always available now.
5173 (syms_of_floatfns): Always define isnan at the Lisp level.
5174
e39b275c 51752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5176
5177 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5178
b2db44d9 51792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5180
f4af5137 5181 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5182 The previous code assumed that file offsets (off_t values) fit in
5183 EMACS_INT variables, which is not true on typical 32-bit hosts.
5184 The code messed up by falsely reporting buffer overflow in cases
5185 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5186 when "big" contains more than 2**29 bytes, even though this
5187 inserts just one byte and does not overflow the buffer.
5188 (Finsert_file_contents): Store file offsets as off_t
5189 values, not as EMACS_INT values. Check for overflow when
5190 converting between EMACS_INT and off_t. When checking for
5191 buffer overflow or for overlap, take the offsets into account.
5192 Don't use EMACS_INT for small values where int suffices.
5193 When checking for overlap, fix a typo: ZV was used where
5194 ZV_BYTE was intended.
5195 (Fwrite_region): Don't assume off_t fits into 'long'.
5196 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5197
ecfc0a49
MA
51982011-09-05 Michael Albinus <michael.albinus@gmx.de>
5199
5200 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5201
6511acf2 52022011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5203
0999621a 5204 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5205
5206 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5207 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5208 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5209 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5210 (modify_event_symbol): Do not assume that the length of
5211 name_alist_or_stem is safe to alloca and fits in int.
5212 (Fexecute_extended_command): Likewise for function name and binding.
5213 (Frecursion_depth): Wrap around reliably on integer overflow.
5214 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5215 since some callers pass EMACS_INT values.
5216 (Fsingle_key_description): Don't crash if symbol name contains more
5217 than MAX_ALLOCA bytes.
5218 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5219 (get_minibuffer): Arg is now EMACS_INT, not int.
5220 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5221 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5222 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5223
2be7d702
PE
5224 * dbusbind.c (signature_cat): New function.
5225 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5226 Do not overrun buffer; instead, report string overflow.
5227
9d1df220
PE
5228 * dispnew.c (add_window_display_history): Don't overrun buffer.
5229 Truncate instead; this is OK since it's just a log.
5230
33ef5c64
PE
5231 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5232 even if the time zone offset is outlandishly large.
5233 Don't mishandle offset == INT_MIN.
5234
66c6fdd5
PE
5235 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5236 when creating daemon; the previous buffer-overflow check was incorrect.
5237
d749b01b
PE
5238 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5239 which has the guts of the old verror function.
5240
b5cd1905
PE
5241 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5242 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5243
6e1a67fb
PE
5244 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5245 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5246 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5247 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5248 length of string rather than counting it via multiple sprintfs;
5249 that's simpler and more reliable.
c21721cc
PE
5250 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5251 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5252 sprintf, in case result does not fit in int.
5253
c57b67fc
PE
5254 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5255 (fontset_from_font): Print it.
5256
8a401434
PE
5257 * frame.c (tty_frame_count): Now printmax_t, not int.
5258 (make_terminal_frame, set_term_frame_name): Print it.
5259 (x_report_frame_params): In X, window IDs are unsigned long,
5260 not signed long, so print them as unsigned.
5261 (validate_x_resource_name): Check for implausibly long names,
5262 and don't assume name length fits in 'int'.
5263 (x_get_resource_string): Don't blindly alloca invocation name;
5264 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5265 not fit in int.
5266
6e1a67fb
PE
5267 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5268 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5269 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5270
0df02bf3
PE
5271 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5272 Use esprintf, not sprintf, in case result does not fit in int.
5273
48e30793
PE
5274 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5275 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5276 it as a large positive number.
5277 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5278 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5279
a66ff6d8
PE
5280 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5281 in case result does not fit in int.
5282
aca216ff
PE
5283 * print.c (float_to_string): Detect width overflow more reliably.
5284 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5285 buffer overrun. Don't assume list length fits in 'int'. Treat
5286 print length of 0 as 0, not as infinity; to be consistent with other
5287 uses of print length in this function. Don't overflow print length
5288 index. Don't assume hash table size fits in 'long', or that
5289 vectorlike size fits in 'unsigned long'.
5290
31c286f7
PE
5291 * process.c (make_process): Use printmax_t, not int, to format
5292 process-name gensyms.
5293
55e5faa1
PE
5294 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5295
80f2e268
PE
5296 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5297 to avoid potential buffer overrun.
5298
670741ab
PE
5299 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5300 if X resource line is longer than 512 bytes.
5301
b7163a50
PE
5302 * xfns.c (x_window): Make sprintf buffer a bit bigger
5303 to avoid potential buffer overrun.
5304
ae58ff1f
PE
5305 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5306
c43c8a6a
PE
5307 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5308
3f8236f4
PE
53092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5310
53e9fe90 5311 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5312 Without these, Emacs silently mishandles large integers sometimes.
5313 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5314 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5315
6511acf2
PE
5316 * xdisp.c (try_window_id): Check Emacs fixnum range before
5317 converting to 'int'.
806add1d 5318
6511acf2 5319 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5320 Check that an Emacs fixnum is in range before assigning it to 'int'.
5321 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5322 values converted from Emacs fixnums.
5323 (Frecenter): Don't wrap around a line count if it is out of 'int'
5324 range; instead, treat it as an extreme value.
5325 (Fset_window_configuration, compare_window_configurations):
5326 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5327
6511acf2
PE
5328 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5329 that can exceed INT_MAX. Check that EMACS_INT value is in range
5330 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5331 (match_limit): Don't assume that a fixnum can fit in 'int'.
5332
6511acf2 5333 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5334 exceed INT_MAX.
5335
6511acf2 5336 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5337 (Fvertical_motion): Don't wrap around LINES values that don't fit
5338 in 'int'. Instead, treat them as extreme values. This is good
5339 enough for windows, which can't have more than INT_MAX lines anyway.
5340
fcb901a7
LMI
53412011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5342
0f2f6b6d
LMI
5343 * Require libxml/parser.h to avoid compilation warning.
5344
fcb901a7
LMI
5345 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5346
5347 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5348 since this reportedly can destroy thread storage.
5349
6e20a0d4
CY
53502011-08-30 Chong Yidong <cyd@stupidchicken.com>
5351
5352 * syntax.c (find_defun_start): Update all cache variables if
5353 exiting early (Bug#9401).
5354
148ae00e
EZ
53552011-08-30 Eli Zaretskii <eliz@gnu.org>
5356
f6cfbd8f
EZ
5357 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5358
148ae00e
EZ
5359 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5360 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5361 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5362
5363 * term.c (tty_append_glyph): New function.
5364 (produce_stretch_glyph): Static function and its prototype deleted.
5365
a66cfb1c
SM
5366 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5367 Add prototypes.
148ae00e 5368
c4a07a4c
PE
53692011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5372 when checking :margin (Bug#9390).
5373 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5374 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5375 so that the name doesn't mislead. All uses changed.
5376
6bc8cd65
JB
53772011-08-28 Johan Bockgård <bojohan@gnu.org>
5378
5379 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5380 set_tty_hooks.
5381
dca4927e
EZ
53822011-08-27 Eli Zaretskii <eliz@gnu.org>
5383
5384 * xdisp.c (move_it_to): Don't bail out early when reaching
5385 position beyond to_charpos, if we are scanning backwards.
5386 (move_it_vertically_backward): When DY == 0, make sure we get to
5387 the first character in the line after the newline.
5388
f2cad773
PE
53892011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5390
5391 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5392 (ccl_driver): Do not generate an out-of-range pointer.
5393 (Fccl_execute_on_string): Remove unnecessary check for
5394 integer overflow, noted by Stefan Monnier in
5395 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5396 Remove a FIXME that didn't need fixing.
5397 Simplify the newly-introduced buffer reallocation code.
5398
0cae2cdb
JB
53992011-08-27 Juanma Barranquero <lekktu@gmail.com>
5400
5401 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5402
5fc295a4 54032011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5404
70c60eb2 5405 Integer and memory overflow issues (Bug#9196).
726e0ab1 5406
d31850da
PE
5407 * doc.c (get_doc_string): Rework so that
5408 get_doc_string_buffer_size is the actual buffer size, rather than
5409 being 1 less than the actual buffer size; this makes xpalloc more
5410 convenient.
5411
a69fbedb
PE
5412 * image.c (x_allocate_bitmap_record, cache_image):
5413 * xselect.c (Fx_register_dnd_atom):
5414 Simplify previous changes by using xpalloc.
5415
fe5c5d37
PE
5416 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5417 since either will do and ptrdiff_t is convenient with xpalloc.
5418
0065d054
PE
5419 * charset.c (charset_table_size)
5420 (struct charset_sort_data.priority): Now ptrdiff_t.
5421 (charset_compare): Don't overflow if priorities differ greatly.
5422 (Fsort_charsets): Don't assume list length fits in int.
5423 Check for size-calculation overflow when allocating sort data.
5424 (syms_of_charset): Allocate an initial charset table that is
5425 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5426
5427 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5428
5429 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5430 The actual value is always <= INT_MAX, and leaving it unsigned made
5431 overflow checking harder.
5432
5433 * dispextern.h (struct glyph_matrix.rows_allocated)
5434 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5435 with xpalloc. The values are still always <= INT_MAX.
5436
5437 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5438
5439 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5440 (SAFE_NALLOCA): New macro.
5441
5442 * region-cache.c (struct boundary.pos, find_cache_boundary)
5443 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5444 (set_cache_region, invalidate_region_cache)
5445 (revalidate_region_cache, know_region_cache, region_cache_forward)
5446 (region_cache_backward, pp_cache):
5447 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5448 so that ptrdiff_t * can be passed to xpalloc.
5449 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5450 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5451 (pp_cache): Don't assume cache_len fits in int.
5452 * region-cache.h: Adjust extern decls to match.
5453
5454 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5455 EMACS_INT, since either will do, for xpalloc.
5456
5457 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5458 (xnmalloc, xnrealloc, xpalloc): New functions.
5459
726e0ab1
PE
5460 * bidi.c (bidi_shelve_header_size): New constant.
5461 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5462 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5463
51f30bc5 5464 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5465 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5466 (overlay_strings):
5467 Don't update size of array until after memory allocation succeeds,
5468 because xmalloc/xrealloc may not return.
0065d054
PE
5469 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5470 now that we have proper integer overflow checking.
5471 (record_overlay_string, overlay_strings): Catch overflows when
5472 calculating size of overlay_str_buf.
726e0ab1 5473
0065d054
PE
5474 * callproc.c (Fcall_process): Check for size overflow when
5475 calculating size of args2.
5476 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5477 Normally we prefer signed values, but sticking with ptrdiff_t would
5478 require adding more-complicated checks.
726e0ab1
PE
5479
5480 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5481 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5482 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5483 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5484
5485 * character.c (Fstring): Check for size-calculation overflow.
5486
5487 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5488 unnecessary integer overflow. Check for size overflow.
5489 (encode_coding_object): Don't update size until xmalloc succeeds.
5490
5491 * composite.c (get_composition_id): Check for overflow in glyph
5492 length calculations.
5493
5494 Integer and memory overflow fixes for display code.
5495 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5496 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5497 (scrolling_window): Check for overflow in size calculations.
5498 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5499 Don't assume glyph table len fits in int.
5500 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5501 (row_table_size): Now ptrdiff_t, not int.
5502 (scrolling_window): Avoid overflow in size calculations.
5503 Don't update size until allocation succeeds.
5504 * fns.c (concat): Check for overflow in size calculations.
5505 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5506 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5507 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5508
5509 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5510 (get_doc_string): Check for size calculation overflow.
5511 Don't update size until allocation succeeds.
5512 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5513 EMACS_INT, where ptrdiff_t will do.
5514 (Fsubstitute_command_keys): Check for string overflow.
5515
5516 * editfns.c (set_time_zone_rule): Don't assume environment length
5517 fits in int.
5518 (message_length): Now ptrdiff_t, not int.
5519 (Fmessage_box): Don't update size until allocation succeeds.
5520 Don't assume message length fits in int.
5521 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5522
0065d054
PE
5523 * emacs.c (main): Do not reallocate argv, since there is a null at
5524 the end that can be overwritten, and this way there's no need to
5525 worry about size-calculation overflow.
5526 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5527
5528 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5529 alloc succeeds.
5530 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5531
5532 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5533 (x_set_scroll_bar_width, x_figure_window_size):
5534 Check for integer overflow.
5535 (x_set_alpha): Do not assume XINT fits in int.
5536
5537 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5538 This is for the members text_lines, text_cols, total_lines, total_cols,
5539 where the system imposes an 'int' limit.
5540
5541 * fringe.c (Fdefine_fringe_bitmap):
5542 Don't update size until alloc works.
5543
5544 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5545 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5546
5547 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5548 Check for size-calculation overflow.
5549 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5550 do, as we prefer signed integers.
5551 (id_to_widget.max_size, id_to_widget.used)
5552 (xg_store_widget_in_map, xg_remove_widget_from_map)
5553 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5554 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5555 Use and return ptrdiff_t, not int.
5556 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5557 * gtkutil.h: Change prototypes to match the above.
5558
5559 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5560 are duplicate now that they've been promoted to lisp.h.
5561 (x_allocate_bitmap_record, x_alloc_image_color)
5562 (make_image_cache, cache_image, xpm_load):
5563 Don't update size until alloc is done.
5564 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5565 (x_detect_edges):
3256efce 5566 Check for size calculation overflow.
726e0ab1
PE
5567 (ct_colors_allocated_max): New constant.
5568 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5569 overflow.
3256efce 5570
726e0ab1
PE
5571 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5572 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5573 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5574 Use ptrdiff_t, not int, to count maps.
5575 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5576 calculations. Don't update size until allocation succeeds.
5577 Redo calculations to avoid overflow.
726e0ab1
PE
5578 * keyboard.h: Change prototypes to match the above.
5579
5580 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5581 to count maps.
5582 (current_minor_maps): Check for size calculation overflow.
5583 * keymap.h: Change prototypes to match the above.
5584
5585 * lread.c (read1, init_obarray): Don't update size until alloc done.
5586
5587 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5588 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5589
726e0ab1
PE
5590 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5591 Now ptrdiff_t, not int.
5592 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5593 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5594
5595 * process.c (Fnetwork_interface_list): Check for overflow
5596 in size calculation.
5597
5598 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5599
5600 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5601 overflow. Don't bother calling xmalloc when xrealloc will do.
5602
5603 * search.c (Freplace_match): Check for size calculation overflow.
5604 (Fset_match_data): Don't assume list lengths fit in 'int'.
5605
5606 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5607 for command line length. Do not attempt to address one before the
5608 beginning of an array, as that's not portable.
5609
5610 * term.c (max_frame_lines): Remove; unused.
5611 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5612 not int.
5613 (encode_terminal_code, calculate_costs): Check for size
5614 calculation overflow.
5615 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5616 table lengths and related sizes. Don't update size until alloc
5617 done. Redo calculations to avoid overflow.
5618 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5619
5620 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5621 subtracting pointers.
5622 (gobble_line): Check for overflow more carefully. Don't update size
5623 until alloc done.
5624
5625 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5626 Don't update size until alloc done.
5627 Redo size calculations to avoid overflow.
5628 Check for size calculation overflow.
0065d054 5629 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5630
5631 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5632 Use ptrdiff_t, not int, for sizes.
5633 (store_mode_line_noprop_char): Don't update size until alloc done.
5634
0065d054
PE
5635 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5636 Use ptrdiff_t, not int, for sizes.
5637 (Finternal_make_lisp_face, cache_face):
5638 Check for size calculation overflow.
5639 (cache_face): Treat size calculation overflows as if they were
5640 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5641
5642 * xfns.c (x_encode_text, x_set_name_internal)
5643 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5644 sizes, since they can exceed INT_MAX in size. Check for size
5645 calculation overflow.
5646
0065d054
PE
5647 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5648 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5649 Don't update size until alloc done.
5650
0065d054 5651 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5652 as sprintf is limited to int lengths.
1d526e2f 5653
252c5ee1
PE
5654 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5655 (X_LONG_MIN): New macros.
864d7ce7
PE
5656 Use them to make the following changes clearer.
5657 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5658 This change doesn't affect the value now, but it may help remind
5659 future maintainers not to raise the value too much later.
5660 (SELECTION_QUANTUM): Remove, replacing with ...
5661 (selection_quantum): ... new function, which avoids overflow.
5662 All uses changed.
5663 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5664 assumption that selection length fits in 'int'.
5665 (x_reply_selection_request, x_handle_selection_request)
5666 (x_get_window_property, receive_incremental_selection)
5667 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5668 (lisp_data_to_selection_data, clean_local_selection_data):
5669 Use ptrdiff_t, not int, to record length of selection.
5670 (x_reply_selection_request, x_get_window_property)
5671 (receive_incremental_selection, x_property_data_to_lisp):
5672 Redo calculations to avoid overflow.
5673 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5674 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5675 something.
5676 (x_get_window_property, receive_incremental_selection)
5677 (lisp_data_to_selection_data, x_property_data_to_lisp):
5678 Check for size-calculation overflow.
5679 (x_get_window_property, receive_incremental_selection)
5680 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5681 Don't store size until memory allocation succeeds.
5682 (x_get_window_property): Plug memory leak on memory exhaustion.
5683 Don't double-block input; malloc is safe here. Don't assume 2**34
5684 - 4 fits in unsigned long. Add an xassert to check
5685 XGetWindowProperty overflow. Be more careful about overflow
5686 calculations, and distinguish size from memory overflow better.
5687 (receive_incremental_selection): When tracing, don't assume
5688 unsigned int is less than INT_MAX.
5689 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5690 harmful) conversions of unsigned short to int.
5691 (lisp_data_to_selection_data): Don't assume that integers
5692 in the range -65535 through -1 fit in an X unsigned short.
5693 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5694 result parameters unless successful. Rely on cons_to_unsigned
5695 to report problems with elements; the old code wasn't right anyway.
5696 (x_check_property_data): Check for int overflow; we cannot use
5697 a wider type due to X limits.
5698 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5699
726e0ab1 5700 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5701
0065d054
PE
5702 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5703 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5704 (x_color_cells): Don't store size until memory allocation succeeds.
5705 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5706 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5707 (x_term_init): Don't assume length fits in int (sprintf is limited
5708 to int size).
bc18e09d 5709
ebfa62c0
PE
5710 Use ptrdiff_t for composition IDs.
5711 * character.c (lisp_string_width):
5712 * composite.c (composition_table_size, n_compositions)
5713 (get_composition_id, composition_gstring_from_id):
5714 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5715 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5716 * window.c (Frecenter):
5717 Use ptrdiff_t, not int, for composition IDs.
5718 * composite.c (get_composition_id): Check for integer overflow.
5719 * composite.h: Adjust prototypes to match the above changes.
5720
d3411f89
PE
5721 Use ptrdiff_t for hash table indexes.
5722 * category.c (hash_get_category_set):
5723 * ccl.c (ccl_driver):
5724 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5725 * coding.c (coding_system_charset_list, detect_coding_system):
5726 * coding.h (struct coding_system.id):
5727 * composite.c (get_composition_id, gstring_lookup_cache):
5728 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5729 * image.c (xpm_get_color_table_h):
5730 * lisp.h (hash_lookup, hash_put):
5731 * minibuf.c (Ftest_completion):
5732 Use ptrdiff_t for hash table indexes, not int (which is too
5733 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5734 32-bit --with-wide-int hosts).
5735
e097a6fa
PE
5736 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5737 Add a FIXME comment about memory leaks.
5738 (syms_of_charset): Don't assume xmalloc returns.
5739
5637687f
PE
5740 Don't assume that stated character widths fit in int.
5741 * character.c (Fchar_width, c_string_width, lisp_string_width):
5742 * character.h (CHAR_WIDTH):
5743 * indent.c (MULTIBYTE_BYTES_WIDTH):
5744 Use sanitize_char_width to avoid undefined and/or bad behavior
5745 with outlandish widths.
a66cfb1c 5746 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5747 now that we have two such functions. All uses changed.
5748 (sanitize_char_width): New inline function.
5749
a2271ba2
PE
5750 Don't assume that tab-width fits in int.
5751 * character.h (sanitize_width): New inline function.
5752 (SANE_TAB_WIDTH): New macro.
5753 (ASCII_CHAR_WIDTH): Use it.
5754 * indent.c (sane_tab_width): Remove. All uses replaced by
5755 SANE_TAB_WIDTH (current_buffer).
5756 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5757
18c52557
PE
5758 * fileio.c: Integer overflow issues with file modes.
5759 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5760
caeeedc1
PE
5761 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5762 Remove unreachable code.
5763 (read_hex, load_charset_map_from_file): Check for integer overflow.
5764
6df6ae42 5765 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5766 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5767 (x_send_scroll_bar_event): Likewise. Check that the size does not
5768 exceed limits imposed by XClientMessageEvent, as well as the usual
5769 ptrdiff_t and size_t limits.
5770
b13995db
PE
5771 * keyboard.c: Overflow, signedness and related fixes.
5772 (make_lispy_movement): Use same integer type in forward decl
5773 that is used in the definition.
5774 (read_key_sequence, keyremap_step):
5775 Change bufsize argument back to int, undoing my 2011-03-30 change.
5776 We prefer signed types, and int is wide enough here.
5777 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5778 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5779 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5780 length, not size_t. Use ptrdiff_t for index, not int.
5781 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5782 possibility of integer overflow.
5783
13464394
PE
5784 Overflow, signedness and related fixes for images.
5785
5786 * dispextern.h (struct it.stack[0].u.image.image_id)
5787 (struct_it.image_id, struct image.id, struct image_cache.size)
5788 (struct image_cache.used, struct image_cache.ref_count):
5789 * gtkutil.c (update_frame_tool_bar):
5790 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5791 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5792 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5793 * nsmenu.m (update_frame_tool_bar):
5794 * xdisp.c (calc_pixel_width_or_height):
5795 * xfns.c (image_cache_refcount):
5796 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5797 on typical 64-bit hosts.
5798
5799 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5800 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5801 Omit unnecessary casts to int.
5802 (parse_image_spec): Check that integers fall into 'int' range
5803 when the callers expect that.
5804 (image_ascent): Redo ascent calculation to avoid int overflow.
5805 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5806 (lookup_image): Remove unnecessary tests.
5807 (xbm_image_p): Locals are now of int, not EMACS_INT,
5808 since parse_image_check makes sure they fit into int.
5809 (png_load, gif_load, svg_load_image):
5810 Prefer int to unsigned where either will do.
5811 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5812 old tiff_error_handler and tiff_warning_handler.
5813 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5814 stack buffer overflows. It uses only the features of vsnprintf
5815 that are common to both POSIX and native Microsoft.
5816 (tiff_error_handler, tiff_warning_handler): Use it.
5817 (tiff_load, gif_load, imagemagick_load_image):
5818 Don't assume :index value fits in 'int'.
5819 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5820 (imagemagick_load_image): Check that crop parameters fit into
5821 the integer types that MagickCropImage accepts. Don't assume
5822 Vimagemagick_render_type has a nonnegative value. Don't assume
5823 size_t fits in 'long'.
5824 (gs_load): Use printmax_t to print the widest integers possible.
5825 Check for integer overflow when computing image height and width.
5826
c11821d4
EZ
58272011-08-26 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (redisplay_window): Don't force window start if point
5830 will be invisible in the resulting window. (Bug#9324)
5831
0c95fcf7
EZ
58322011-08-25 Eli Zaretskii <eliz@gnu.org>
5833
5834 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5835 the display spec is of the form `(space ...)'.
5836 (handle_display_spec): Return the value returned by
5837 handle_single_display_spec, not just 1 or zero.
5838 (handle_single_display_spec): If the display spec is of the form
5839 `(space ...)', and specifies display in the text area, return 2
5840 rather than 1.
fee65a97 5841 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5842 accurately, and prefer exact match for point under bidi.
5843 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5844
5845 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5846 into disp_prop; all users changed.
5847
5848 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5849 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5850 for the text covered by the display property.
5851
e4ed06f1
CY
58522011-08-25 Chong Yidong <cyd@stupidchicken.com>
5853
5854 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5855 Change return value to nil.
5856 (Frecord_buffer): Delete unused function.
5857
f67cdd7f
EZ
58582011-08-24 Eli Zaretskii <eliz@gnu.org>
5859
5980d4c6
EZ
5860 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5861 buffers, return left-to-right.
8610fe8b
EZ
5862 (set_cursor_from_row): Consider candidate row a win if its glyph
5863 represents a newline and point is on that newline. Fixes cursor
5864 positioning on the newline at EOL of R2L text within L2R
5865 paragraph, and vice versa.
5866 (try_cursor_movement): Check continued rows, in addition to
5867 continuation rows. Fixes unwarranted scroll when point enters a
5868 continued line of R2L text within an L2R paragraph, or vice versa.
5869 (cursor_row_p): Consider the case of point being equal to
5870 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5871 from the end of a short line to the beginning of a continued line
5872 of R2L text within L2R paragraph.
5873 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5874 composed characters.
5980d4c6 5875
f67cdd7f
EZ
5876 * bidi.c (bidi_check_type): Use xassert.
5877 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5878 members.
5879
bca633fb
EZ
58802011-08-23 Eli Zaretskii <eliz@gnu.org>
5881
5882 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5883 a character.
5884
4a5885a7
CY
58852011-08-23 Chong Yidong <cyd@stupidchicken.com>
5886
5887 * nsfont.m (ns_otf_to_script): Fix typo.
5888
0902a04e
KH
58892011-08-22 Kenichi Handa <handa@m17n.org>
5890
5891 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5892 extra slot even if the purpose is char-code-property-table.
5893
1a2e6670
EZ
58942011-08-23 Eli Zaretskii <eliz@gnu.org>
5895
8ddde651
EZ
5896 * xdisp.c (redisplay_window): When computing centering_position,
5897 account for the height of the header line. (Bug#8874)
5898
425cc014
EZ
5899 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5900 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5901 candidate is selected by the mouse, and that candidate has a
5902 composed character under the mouse.
5903
1a2e6670
EZ
5904 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5905 coordinates reported by pos-visible-in-window-p for a composed
5906 character in column zero.
5907
8b76d6f8
SM
59082011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5909
5910 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5911
dac347dd
EZ
59122011-08-22 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5915 consider it a hit if to_charpos is anywhere in the range of the
5916 composed buffer positions.
5917
e013fb34
CY
59182011-08-22 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * image.c (gif_load): Don't assume that each subimage has the same
5921 dimensions as the base image. Handle disposal method that is
5922 "undefined" by the gif spec (Bug#9335).
5923
bd1ba3e8
CY
59242011-08-20 Chong Yidong <cyd@stupidchicken.com>
5925
5926 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5927 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5928
54a1215b
EZ
59292011-08-19 Eli Zaretskii <eliz@gnu.org>
5930
823564e5
EZ
5931 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5932 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5933 from an Org mode buffer to a Speedbar frame.
5934
54a1215b
EZ
5935 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5936 a composition, take its buffer position from IT->cmp_it.charpos.
5937 Fixes cursor positioning at the beginning of a line that begins
5938 with a composed character.
5939
9778ebcc
EZ
59402011-08-18 Eli Zaretskii <eliz@gnu.org>
5941
0be6ee06
EZ
5942 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5943 character bidirectional type, use STRONG_L instead. Fixes crashes
5944 in a buffer produced by `describe-categories'.
5945
9778ebcc
EZ
5946 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5947 members before the level stack, so they would be saved and
5948 restored when copying iterator state. Fixes incorrect reordering
5949 around TABs covered by display properties.
5950
156bffbe
AS
59512011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5952
6b02f655 5953 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5954
72ad093b
CY
59552011-08-17 Chong Yidong <cyd@stupidchicken.com>
5956
5957 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5958 (internal_condition_case_2, internal_condition_case_n):
5959 Remove unnecessary aborts (Bug#9081).
72ad093b 5960
35774242
EZ
59612011-08-17 Eli Zaretskii <eliz@gnu.org>
5962
5963 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5964 has no `load' handler, try opening the file locally. (Bug#9311)
5965
db76dd85
KB
59662011-08-16 Ken Brown <kbrown@cornell.edu>
5967
5968 * gmalloc.c: Expand comment.
5969
b215eee5
EZ
59702011-08-16 Eli Zaretskii <eliz@gnu.org>
5971
5972 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5973 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5974
a4579d33
KB
59752011-08-16 Ken Brown <kbrown@cornell.edu>
5976
5977 Fix memory allocation problems in Cygwin build (Bug#9273).
5978
5979 * unexcw.c ( __malloc_initialized): Declare external variable.
5980 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5981
8b76d6f8
SM
5982 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5983 New variables.
a4579d33
KB
5984 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5985 dumped emacs.
5986 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5987 in the static heap.
5988 [CYGWIN] (special_realloc): New function.
5989 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5990 requests to realloc storage in the static heap.
5991
3ebec551
PE
59922011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 * bidi.c (bidi_initialize): Remove unused local.
5995
9fd8be00
EZ
59962011-08-15 Eli Zaretskii <eliz@gnu.org>
5997
6b02f655
SM
5998 * bidimirror.h:
5999 * biditype.h: Remove file.
6000 * makefile.w32-in ($(BLD)/bidi.$(O)):
6001 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6002
6003 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6004
6005 * chartab.c: Improve commentary for the uniprop_table API.
6006
32413314
EZ
6007 * bidi.c (bidi_paragraph_init): Support zero value of
6008 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6009 (bidi_initialize): Use uniprop_table instead of including
6010 biditype.h and bidimirror.h.
32413314 6011
9fd8be00
EZ
6012 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6013 coordinates of the iterator when restoring from ppos_it.
6014 (Bug#9296)
6015
5cf2b69b
KH
60162011-08-14 Kenichi Handa <handa@m17n.org>
6017
6018 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6019 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6020
daf17d00
EZ
60212011-08-14 Eli Zaretskii <eliz@gnu.org>
6022
6023 * xdisp.c (move_it_in_display_line_to): Don't invoke
6024 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6025 ppos_it. Fixes vertical cursor motion when line beginning is
6026 covered by an image. (Bug#9296)
6027
08e3161a
JD
60282011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6029
6030 * nsterm.h (ns_run_ascript): Declare.
6031 (NSAPP_DATA2_RUNASSCRIPT): Define.
6032
6033 * nsfns.m (as_script, as_result, as_status): New static variables.
6034 (ns_run_ascript): New function.
5e617bc2 6035 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6036 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6037 the event loop. Get status from as_status (Bug#7276).
6038
6039 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6040 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6041 the event loop (Bug#7276).
6042
a3720aa2
AS
60432011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6044
6045 * gnutls.c (QCgnutls_bootprop_priority)
6046 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6047 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6048 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6049 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6050 (QCgnutls_bootprop_verify_hostname_error)
6051 (QCgnutls_bootprop_callbacks_verify): Rename from
6052 Qgnutls_bootprop_..., all uses changed.
6053
6054 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6055 uses changed.
6056
0a0d27fb
PE
60572011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6058
19d5c50c
PE
6059 * xfaces.c (Qframe_set_background_mode): Now static.
6060 * dispextern.h (Qframe_set_background_mode): Remove decl.
6061
0a0d27fb
PE
6062 * process.c (Fnetwork_interface_info): Declare local only if needed.
6063
377538cb
JD
60642011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6065
6066 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6067 (Fnetwork_interface_list): Allocate in increments of bytes instead
6068 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6069 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6070 sockaddr.
6071 (struct ifflag_def): notrailers is smart on OSX.
6072 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6073 Get hardware address with getifaddrs if available.
6074
08fff70c
EZ
60752011-08-12 Eli Zaretskii <eliz@gnu.org>
6076
6077 * xdisp.c (iterate_out_of_display_property): xassert that
6078 IT->position is set to within IT->object's boundaries. Break from
6079 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6080 when IT->position is set up wrongly due to some bug.
6081 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6082 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6083 entry. Force push_it to save on the stack the current
6084 buffer/string position, to be restored by pop_it. Fix flags in
6085 the iterator structure wrt the object coming from a display
6086 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6087 properties. (Bug#9284)
6088
7be1c708 60892011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6090
7be1c708
CY
6091 * fontset.c (fontset_get_font_group): Add proper type checks.
6092 (Bug#9172)
aac0c6e3 6093
7be1c708 60942011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6095
7be1c708
CY
6096 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6097 and LC_VERSION_MIN_MACOSX.
6098 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6099 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6100
97bb72a6
EZ
61012011-08-08 Eli Zaretskii <eliz@gnu.org>
6102
6103 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6104 no-display-properties-and-no-overlays under bidi display.
6105 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6106 properties and overlays.
97bb72a6 6107
d5617611
CY
61082011-08-08 Chong Yidong <cyd@stupidchicken.com>
6109
37e11a63
CY
6110 * editfns.c (Fset_time_zone_rule): Document relationship with the
6111 setenv function.
6112
d5617611
CY
6113 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6114 the font entity extracted from the cache (Bug#8109).
6115
58872834
CY
61162011-08-07 Chong Yidong <cyd@stupidchicken.com>
6117
6118 * composite.c (autocmp_chars): Don't reset point. That is done by
6119 restore_point_unwind (Bug#5984).
6120
75bfc667
JL
61212011-08-07 Juri Linkov <juri@jurta.org>
6122
6123 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6124 to show the arg `TIME' instead of `TIMEVAL'.
6125
d1410150
EZ
61262011-08-06 Eli Zaretskii <eliz@gnu.org>
6127
6128 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6129 display property strides EOL and includes a newline, as in
6130 longlines-mode. (Bug#9254)
75b771e4
EZ
6131 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6132 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6133
6134 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6135 is non-zero, even if the data buffer is NULL. Fixes a crash in
6136 vertical-motion with longlines-mode. (Bug#9254)
6137
35928349
EZ
61382011-08-05 Eli Zaretskii <eliz@gnu.org>
6139
ec7cc85b
EZ
6140 * bidi.c <bidi_cache_total_alloc>: Now static.
6141 (bidi_initialize): Initialize bidi_cache_total_alloc.
6142
8b76d6f8 6143 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6144 cache. (Bug#9221)
6145
6146 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6147 amount allocated this far in `bidi_cache_total_alloc'.
6148 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6149 non-zero, only free the data buffer without restoring the cache
6150 contents. All callers changed.
6151
6152 * dispextern.h (bidi_unshelve_cache): Update prototype.
6153
6154 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6155 (move_it_in_display_line, move_it_to)
6156 (move_it_vertically_backward, move_it_by_lines): Replace the call
6157 to xfree to an equivalent call to bidi_unshelve_cache.
6158 (move_it_in_display_line_to): Fix logic of returning
412b6358 6159 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6160
e2e2423b
EZ
61612011-08-05 Eli Zaretskii <eliz@gnu.org>
6162
6163 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6164 came from a string character with a `cursor' property. (Bug#9229)
6165
ae9e757a
JD
61662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6167
6168 * Makefile.in (LIB_PTHREAD): New variable.
6169 (LIBES): Add LIB_PTHREAD (Bug#9216).
6170
6171 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6172 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6173
213bd7f2
AS
61742011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6175
6b02f655 6176 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6177
99aaf75f
JD
61782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6179
6180 * xterm.c (x_find_topmost_parent): New function.
6181 (x_set_frame_alpha): Find topmost parent window with
6182 x_find_topmost_parent and set the property there also (bug#9181).
6183 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6184
c74e9d86
PE
61852011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6186
6187 * callproc.c (Fcall_process): Avoid vfork clobbering
6188 the local vars buffer, coding_systems, current_dir.
6189
640c8776
SM
61902011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6191
6192 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6193
f26d0e4c
PE
61942011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6195
8a10d76c
PE
6196 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6197 so that it is not optimized away.
6198
f26d0e4c
PE
6199 * xdisp.c (compute_display_string_pos): Remove unused local.
6200
55439c61
EZ
62012011-08-02 Eli Zaretskii <eliz@gnu.org>
6202
6203 Fix slow cursor motion and scrolling in large buffers with
6204 selective display, like Org Mode buffers. (Bug#9218)
6205
6206 * dispextern.h (struct bidi_it): New member disp_prop_p.
6207
6208 * xdisp.c: Remove one-slot cache of display string positions.
6209 (compute_display_string_pos): Accept an additional argument
5e617bc2 6210 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6211 for a display string or property. If found, set DISP_PROP_P
6212 non-zero.
6213
6214 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6215 DISP_PROP_P, and pass it to compute_display_string_pos.
6216 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6217 non-zero. All callers of bidi_fetch_char changed.
6218
fb33fa43
SM
62192011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6220
6221 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6222
b099e063
DM
62232010-12-03 Don March <don@ohspite.net>
6224
6225 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6226 last character M-[char] is translated to ESC [char] (bug#7541).
6227
5cc7f7af
KH
62282011-08-02 Kenichi Handa <handa@m17n.org>
6229
d0fffa3f 6230 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6231
6232 * chartab.c (uniprop_table): Make it non-static.
6233
525d5e6e
EZ
62342011-08-01 Eli Zaretskii <eliz@gnu.org>
6235
6236 * xdisp.c (forward_to_next_line_start): Accept additional argument
6237 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6238 on the newline.
6239 (reseat_at_next_visible_line_start): Use the bidi iterator state
6240 returned by forward_to_next_line_start to restore the state of
6241 it->bidi_it after backing up to previous newline. (Bug#9212)
6242
31011111
AS
62432011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6244
6245 * regex.c (re_comp): Protoize.
6246 (re_exec): Fix return type.
6247 (regexec): Fix type of `ret'. (Bug#9203)
6248
476371c4
PE
62492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6250
e5d76069
PE
6251 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6252 This is needed if max-image-size is a floating-point number.
6253
9a79b20c
AS
62542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6255
6256 * print.c (print_object): Print empty symbol as ##.
6257
6258 * lread.c (read1): Read ## as empty symbol.
6259
d8c2fa78
AA
62602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6261
6262 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6263 setting frame foreground color (Bug#9175).
6264 (x_set_background_color): Likewise.
6265
ffe57a7a
AA
6266 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6267 contents (Bug#9176).
6268 (EmacsTooltip -init): Remove bezels and add shadows to
6269 tooltip windows.
6270
bf3492a5
AA
6271 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6272 or scroll bar (Bug#8470).
6273
d55e9c53
AA
6274 * nsfont.m (nsfont_open): Remove assignment to voffset and
6275 unnecessary vars hshink, expand, hd, full_height, min_height.
6276 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6277
6278 * nsterm.h (nsfont_info): Remove voffset field.
6279
d8c2fa78 62802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6281
6282 Implement strike-through and overline on NextStep (Bug#8863).
6283
6284 * nsfont.m (nsfont_open): Use underline position provided by font,
6285 instead of hard-coded value of 2.
6286 (nsfont_draw): Call ns_draw_text_decoration instead.
6287
6288 * nsterm.h: Add declaration for ns_draw_text_decoration.
6289
6290 * nsterm.m (ns_draw_text_decoration): New function for drawing
6291 underline, overline, and strike-through.
6292 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6293 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6294 accommodate underlining, etc.
4843aac3 6295
4cc60b9b
EZ
62962011-07-28 Eli Zaretskii <eliz@gnu.org>
6297
bc7ece87
EZ
6298 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6299 default.
4cc60b9b 6300
476371c4
PE
63012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6302
66606eea
PE
6303 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6304 Without this fix, if a signal arrives just after memory fills up,
6305 'malloc' might be invoked reentrantly.
6306
476371c4
PE
6307 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6308 In other words, assume that every image size is allowed, on non-X
6309 hosts. This assumption is probably wrong, but it lets Emacs compile.
6310
f3fcc40d
AS
63112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6312
6313 * regex.c (re_iswctype): Convert return values to boolean.
6314
350c992f
EZ
63152011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6316
6317 * xdisp.c (compute_display_string_pos): Don't use cached display
6318 string position if the buffer had its restriction changed.
6319 (Bug#9184)
6320
5266b4bb
PE
63212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6324
2573a837 63252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6326
41f55ccd 6327 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6328
39e378da
PE
6329 * bidi.c: Integer size and overflow fixes.
6330 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6331 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6332 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6333 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6334 (bidi_find_other_level_edge):
6335 Use ptrdiff_t instead of EMACS_INT where either will do.
6336 This works better on 32-bit hosts configured --with-wide-int.
6337 (bidi_cache_ensure_space): Check for size-calculation overflow.
6338 Use % rather than repeated addition, for better worst-case speed.
6339 Don't set bidi_cache_size until after xrealloc returns, because it
6340 might not return.
6341 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6342 (bidi_cache_ensure_space): Also check that the bidi cache size
6343 does not exceed that of the largest Lisp string or buffer. See Eli
6344 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6345
5e927815
PE
6346 * alloc.c (__malloc_size_t): Remove.
6347 All uses replaced by size_t. See Andreas Schwab's note
6348 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6349
ca4aa935
PE
6350 * image.c: Improve checking for integer overflow.
6351 (check_image_size): Assume that f is nonnull, since
6352 it is always nonnull in practice. This is one less thing to
6353 worry about when checking for integer overflow later.
6354 (x_check_image_size): New function, which checks for integer
6355 overflow issues inside X.
6356 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6357 This removes the need for a memory_full check.
6358 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6359 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6360 (xbm_read_bitmap_data): Change locals back to 'int', since
6361 their values must fit in 'int'.
6362 (xpm_load_image, png_load, tiff_load):
6363 Invoke x_create_x_image_and_pixmap earlier,
6364 to avoid much needless work if the image is too large.
6365 (tiff_load): Treat overly large images as if
6366 x_create_x_image_and_pixmap failed, not as malloc failures.
6367 (gs_load): Use x_check_image_size.
6368
5f8f9cc2
PE
6369 * gtkutil.c: Omit integer casts.
6370 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6371 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6372
5adf60bc
PE
6373 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6374
c8907a93
PE
6375 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6376 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6377 would wrongly return t on a 64-bit host.
6378
e3c25c68
PE
6379 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6380 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6381 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6382 and therefore cause GCC to emit a bogus diagnostic in some cases.
6383
3f791afe
PE
6384 * image.c: Integer signedness and overflow and related fixes.
6385 This is not an exhaustive set of fixes, but it's time to
6386 record what I've got.
6387 (lookup_pixel_color, check_image_size): Remove redundant decls.
6388 (check_image_size): Don't assume that arbitrary EMACS_INT values
6389 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6390 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6391 (tiff_load, imagemagick_load_image):
6392 Check for overflow in size calculations.
6393 (x_create_x_image_and_pixmap): Remove unnecessary test for
6394 xmalloc returning NULL; that can't happen.
6395 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6396 (xpm_color_bucket): Use better integer hashing function.
6397 (xpm_cache_color): Don't possibly over-allocate memory.
6398 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6399 (gif_memory_source):
6400 Use ptrdiff_t, not int or size_t, to record sizes.
6401 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6402 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6403 either works, as we prefer signed integers.
6404 (tiff_read_from_memory, tiff_write_from_memory):
6405 Return tsize_t, not size_t, since that's what the TIFF API wants.
6406 (tiff_read_from_memory): Don't fail simply because the read would
6407 go past EOF; instead, return a short read.
6408 (tiff_load): Omit no-longer-needed casts.
6409 (Fimagemagick_types): Don't assume size fits into 'int'.
6410
3cc5a532
PE
6411 Improve hashing quality when configured --with-wide-int.
6412 * fns.c (hash_string): New function, taken from sxhash_string.
6413 Do not discard information about ASCII character case; this
6414 discarding is no longer needed.
6415 (sxhash-string): Use it. Change sig to match it. Caller changed.
6416 * lisp.h: Declare it.
6417 * lread.c (hash_string): Remove, since we now use fns.c's version.
6418 The fns.c version returns a wider integer if --with-wide-int is
6419 specified, so this should help the quality of the hashing a bit.
6420
b312a492
PE
6421 * emacs.c: Integer overflow minor fix.
6422 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6423 Define only if GNU_LINUX.
6424 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6425
dfd153ae
PE
6426 * dispnew.c: Integer signedness and overflow fixes.
6427 Remove unnecessary forward decls, that were a maintenance hassle.
6428 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6429 All uses changed.
6430 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6431 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6432 (prepare_desired_row, line_draw_cost):
6433 Use int, not unsigned, where either works.
6434 (save_current_matrix, restore_current_matrix):
6435 Use ptrdiff_t, not size_t, where either works.
6436 (init_display): Check for overflow more accurately, and without
6437 relying on undefined behavior.
6438
a81d11a3
PE
6439 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6440 Remove, replacing with the new symbols in lisp.h. All uses changed.
6441 * fileio.c (make_temp_name):
6442 * filelock.c (lock_file_1, lock_file):
6443 * xdisp.c (message_dolog):
6444 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6445 Use pMd etc. instead.
6446 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6447 replacing the pWIDE etc. symbols removed from editfns.c.
6448
3300e6fd
PE
6449 * keyboard.h (num_input_events): Now uintmax_t.
6450 This is (very slightly) less likely to mess up due to wraparound.
6451 All uses changed.
6452
fd05c7e9
PE
6453 * buffer.c: Integer signedness fixes.
6454 (alloc_buffer_text, enlarge_buffer_text):
6455 Use ptrdiff_t rather than size_t when either will do, as we prefer
6456 signed integers.
6457
903fe15d
PE
6458 * alloc.c: Integer signedness and overflow fixes.
6459 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6460 (__malloc_size_t): Default to size_t, not to int.
6461 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6462 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6463 Prefer ptrdiff_t to size_t when either would do, as we prefer
6464 signed integers.
6465 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6466 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6467 Now const. Initialize with values that are in range even if char
6468 is signed.
6469 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6470 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6471 These functions do the right thing with sizes > 2**32.
6472 (check_depth): Now ptrdiff_t, not int.
6473 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6474 Adjust to new way of storing sizes. Check for size overflow bugs
6475 in rest of code.
6476 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6477 slightly wrong anyway, as it missed one instance of
6478 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6479 (refill_memory_reserve): Omit needless cast to size_t.
6480 (mark_object_loop_halt): Mark as externally visible.
6481
ac82cc6a
PE
6482 * xselect.c: Integer signedness and overflow fixes.
6483 (Fx_register_dnd_atom, x_handle_dnd_message):
6484 Use ptrdiff_t, not size_t, since we prefer signed.
6485 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6486 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6487 x_dnd_atoms_size and x_dnd_atoms_length.
6488
c2d1e36d
PE
6489 * doprnt.c: Prefer signed to unsigned when either works.
6490 * eval.c (verror):
6491 * doprnt.c (doprnt):
6492 * lisp.h (doprnt):
6493 * xdisp.c (vmessage):
6494 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6495 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6496 prefer signed arithmetic to avoid comparison confusion.
6497 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6498 but is a bit tricky.
6499
0e926e56
PE
6500 Assume freestanding C89 headers, string.h, stdlib.h.
6501 * data.c, doprnt.c, floatfns.c, print.c:
6502 Include float.h unconditionally.
6503 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6504 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6505 * regex.c: Likewise for stddef.h, string.h.
6506 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6507 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6508 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6509 (STDC_HEADERS): Remove obsolete defines.
6510 * sysdep.c: Include limits.h unconditionally.
6511
9cfdb3ec
PE
6512 Assume support for memcmp, memcpy, memmove, memset.
6513 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6514 * regex.c (memcmp, memcpy):
6515 Remove; we assume C89 now.
6516
6517 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6518 (__malloc_safe_bcopy): Remove; no longer needed.
6519
cf950e6b 6520 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6521 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6522 well either way, and we prefer signed to unsigned.
6523
dbf38e02
LMI
65242011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6525
6526 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6527 closes the connection while we're reading (bug#9182).
6528
d6f0886c 65292011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6530
d6f0886c
JD
6531 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6532 are specified (Bug#9168).
24e0f6b1 6533
2eb1f9e6
PE
65342011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6535
6536 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6537 Found by GCC static checking and --with-wide-int on a 32-bit host.
6538
22381272 65392011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6540
6541 * xdisp.c (compute_display_string_pos): Fix logic of caching
6542 previous display string position. Initialize cached_prev_pos to
6543 -1. Fixes slow-down at the beginning of a buffer.
6544
f25e39b4
EZ
65452011-07-24 Eli Zaretskii <eliz@gnu.org>
6546
6547 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6548 for attrs[LFACE_FONTSET_INDEX].
6549
04c4b52e
PE
65502011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6551
6552 * xml.c (parse_region): Remove unused local
6553 that was recently introduced.
6554
c1734fbd
EZ
65552011-07-23 Eli Zaretskii <eliz@gnu.org>
6556
be18c5a5
EZ
6557 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6558 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6559
c1734fbd
EZ
6560 * xdisp.c (move_it_in_display_line_to): Record the best matching
6561 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6562 exit if none of the characters scanned was an exact match.
6563 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6564 when exact match is impossible due to invisible text, and the
6565 lines are truncated.
6566
a258d627
JD
65672011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6568
6569 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6570 for OSX >= 10.7.
6571
b6d5a689
EZ
65722011-07-22 Eli Zaretskii <eliz@gnu.org>
6573
0f74f785
EZ
6574 Fix a significant slow-down of cursor motion with C-n, C-p,
6575 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6576 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6577 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6578 (next_element_from_buffer): Call compute_stop_pos_backwards to
6579 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6580 base_level_stop.
6581 (reseat): Don't look for prev_stop, as that could mean a very long
6582 run.
6583 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6584 <cached_disp_overlay_modiff>: Cache for last found display string
6585 position.
551918c1 6586 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6587 about the same buffer in the same area of character positions, and
6588 the buffer wasn't changed since the time the display string
6589 position was cached.
551918c1 6590
b2d0c91a
EZ
65912011-07-22 Eli Zaretskii <eliz@gnu.org>
6592
6593 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6594 is an integer, which is important for empty lines. (Bug#9149)
6595
043604ee
CY
65962011-07-22 Chong Yidong <cyd@stupidchicken.com>
6597
6598 * frame.c (Fmodify_frame_parameters): In tty case, update the
6599 default face if necessary (Bug#4238).
6600
da4adb04
CY
66012011-07-21 Chong Yidong <cyd@stupidchicken.com>
6602
6603 * editfns.c (Fstring_to_char): No need to explain what a character
6604 is in the docstring (Bug#6576).
6605
9abd0532
LMI
66062011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6607
6608 * xml.c (parse_region): Make sure we always return a tree.
6609
36881d16
HK
66102011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6611
6612 * xml.c (parse_region): If a document contains only comments,
6613 return that, too.
6614
1e98674d
LMI
66152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6616
6617 * xml.c (make_dom): Return comments, too.
6618
590bd467
PE
66192011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6620
6621 Port to OpenBSD.
6622 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6623 and the surrounding thread.
6624 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6625 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6626 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6627 timer goes off.
6628 * s/openbsd.h (BROKEN_SIGIO): Define.
6629 * unexelf.c (unexec) [__OpenBSD__]:
6630 Don't update the .mdebug section of the Alpha COFF symbol table.
6631
f41628b2
LMI
66322011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6633
6634 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6635 (bug#8460).
6636
b59b67c5
PE
66372011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6638
15e3a074
PE
6639 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6640 This fixes some race conditions on the permissions of any newly
6641 created file.
6642
41bed37d
PE
6643 * alloc.c (valid_pointer_p): Use pipe, not open.
6644 This fixes some permissions issues when debugging.
6645
b59b67c5
PE
6646 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6647 If fchown fails to set both uid and gid, try to set just gid,
6648 as that is sometimes allowed. Adjust the file's mode to eliminate
6649 setuid or setgid bits that are inappropriate if fchown fails.
6650
925a6be7
SM
66512011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6652
6653 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6654 to compare Lisp_Objects.
6655 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6656 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6657 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6658
52968808
AS
66592011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6660
0a6a104b
AS
6661 * lread.c (read_integer): Unread even EOF character.
6662 (read1): Likewise. Properly record start position of symbol.
6663
52968808
AS
6664 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6665 symbol character follows.
6666
9e381cdd
PE
66672011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6668
6669 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6670 This works around a problem with the previous change to Fcopy_file.
6671 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6672 and without this change, GCC might complain about discarding
6673 fchown's return value.
6674
b5641435
JB
66752011-07-16 Juanma Barranquero <lekktu@gmail.com>
6676
6677 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6678
a8031457
PE
66792011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6680
6681 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6682
dd889327
LMI
66832011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6684
750c33f7
LMI
6685 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6686 it's used from the C level.
6687
dd889327
LMI
6688 * process.c: Use the same condition for POLL_FOR_INPUT in both
6689 keyboard.c and process.c (bug#1858).
6690
87e86684
LM
66912011-07-09 Lawrence Mitchell <wence@gmx.li>
6692
6693 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6694 (Fgnutls_boot): Use it.
6695
64348f40
AS
66962011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6697
6698 * doc.c (Fsubstitute_command_keys): Revert last change.
6699
1d698799
LMI
67002011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6701
f863868c
LMI
6702 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6703 quotes the next character, and doesn't affect other longer
6704 sequences (bug#8935).
6705
1d698799
LMI
6706 * lread.c (syms_of_lread): Clarify that is isn't only
6707 `eval-buffer' and `eval-defun' that's affected by
6708 `lexical-binding' (bug#8460).
6709
aa4b6df6
EZ
67102011-07-15 Eli Zaretskii <eliz@gnu.org>
6711
6712 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6713 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6714
5d856da6
PE
67152011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6716
ad6042bb
PE
6717 Fix minor problems found by static checking.
6718 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6719 (elsz): Now a signed constant, not a size_t var. We prefer signed
6720 types to unsigned, to avoid integer comparison confusion. Without
6721 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6722 "cannot optimize loop, the loop counter may overflow", a symptom
6723 of the confusion.
f00bbb22 6724 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6725 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6726
6468f31c
LMI
67272011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6728
49080b10
LMI
6729 * search.c (Fre_search_backward): Mention `case-fold-search' in
6730 all the re_search_* functions (bug#8138).
6731
6468f31c
LMI
6732 * keyboard.c (Fopen_dribble_file): Document when the file is
6733 closed (bug#8056).
6734
c965adc5
EZ
67352011-07-14 Eli Zaretskii <eliz@gnu.org>
6736
df9733bf
EZ
6737 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6738 bidi_cache_idx.
6739
0bb23927
EZ
6740 Support bidi reordering of display and overlay strings.
6741 * xdisp.c (compute_display_string_pos)
6742 (compute_display_string_end): Accept additional argument STRING.
6743 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6744 (reseat_to_string): Initialize bidi_it->string.s and
6745 bidi_it->string.schars.
6746 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6747 NULL (avoids a crash in bidi_paragraph_init).
6748 Initialize itb.string.lstring.
0bb23927
EZ
6749 (init_iterator): Call bidi_init_it only of a valid
6750 buffer position was specified. Initialize paragraph_embedding to
6751 L2R.
6752 (reseat_to_string): Initialize the bidi iterator.
6753 (display_string): If we need to ignore text properties of
6754 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6755 original value of -1 will not work with bidi.)
6756 (compute_display_string_pos): First arg is now struct
6757 `text_pos *'; all callers changed. Support display properties on
6758 Lisp strings.
6759 (compute_display_string_end): Support display properties on Lisp
6760 strings.
6761 (init_iterator, reseat_1, reseat_to_string): Initialize the
6762 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6763 when iterating on a string not from display properties).
640c8776
SM
6764 (compute_display_string_pos, compute_display_string_end):
6765 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6766 arrow keys.
6767 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6768 base_level_stop; instead, set base_level_stop to BEGV.
6769 Fixes crashes in vertical-motion.
0bb23927
EZ
6770 (next_element_from_buffer): Improve commentary for when
6771 the iterator is before prev_stop.
6772 (init_iterator): Initialize bidi_p from the default value of
6773 bidi-display-reordering, not from buffer-local value. Use the
6774 buffer-local value only if initializing for buffer iteration.
6775 (handle_invisible_prop): Support invisible properties on strings
6776 that are being bidi-reordered.
6777 (set_iterator_to_next): Support bidi reordering of C strings and
6778 Lisp strings.
6779 (next_element_from_string): Support bidi reordering of Lisp
6780 strings.
6781 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6782 (display_string): Support display of R2L glyph rows.
6783 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6784 (init_iterator): Don't initialize it->bidi_p for strings
6785 here.
6786 (reseat_to_string): Initialize it->bidi_p for strings here.
6787 (next_element_from_string, next_element_from_c_string)
6788 (next_element_from_buffer): Add xassert's for correspondence
6789 between IT's object being iterated and it->bidi_it.string
6790 structure.
6791 (face_before_or_after_it_pos): Support bidi iteration.
6792 (next_element_from_c_string): Handle the case of the first string
6793 character that is not the first one in the visual order.
6794 (get_visually_first_element): New function, refactored from common
6795 parts of next_element_from_buffer, next_element_from_string, and
6796 next_element_from_c_string.
6797 (tool_bar_lines_needed, redisplay_tool_bar)
6798 (display_menu_bar): Force left-to-right direction. Add a FIXME
6799 comment for making that be controlled by a user option.
6800 (push_it, pop_it): Save and restore the state of the
6801 bidi iterator. Save and restore the bidi_p flag.
6802 (pop_it): Iterate out of display property for string iteration as
6803 well.
6804 (iterate_out_of_display_property): Support iteration over strings.
6805 (handle_single_display_spec): Set up it->bidi_it for iteration
6806 over a display string, and call bidi_init_it.
6807 (handle_single_display_spec, next_overlay_string)
6808 (get_overlay_strings_1, push_display_prop): Set up the bidi
6809 iterator for displaying display or overlay strings.
6810 (forward_to_next_line_start): Don't use the shortcut if
6811 bidi-iterating.
6812 (back_to_previous_visible_line_start): If handle_display_prop
6813 pushed the iterator stack, restore the internal state of the bidi
6814 iterator by calling bidi_pop_it same number of times.
6815 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6816 and we are bidi-iterating, don't decrement the iterator position;
6817 instead, set the first_elt flag in the bidi iterator, to produce
6818 the same effect.
6819 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6820 (push_display_prop): xassert that we are iterating a buffer.
6821 (push_it, pop_it): Save and restore paragraph_embedding member.
6822 (handle_single_display_spec, next_overlay_string)
6823 (get_overlay_strings_1, reseat_1, reseat_to_string)
6824 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6825 correctly. Don't assume unibyte strings are not bidi-reordered.
6826 (compute_display_string_pos)
6827 (compute_display_string_end): Fix handling the case of C string.
6828 (push_it, pop_it): Save and restore from_disp_prop_p.
6829 (handle_single_display_spec, push_display_prop): Set the
6830 from_disp_prop_p flag.
6831 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6832 (pop_it): Call iterate_out_of_display_property only if we are
6833 popping after iteration over a string that came from a display
6834 property. Fix a typo in popping stretch info. Add an assertion
6835 for verifying that the iterator position is in sync with the bidi
6836 iterator.
6837 (handle_single_display_spec, get_overlay_strings_1)
6838 (push_display_prop): Fix initialization of paragraph direction for
6839 string when that of the parent object is not yet determined.
6840 (reseat_1): Call bidi_init_it to resync the bidi
6841 iterator with IT's position. (Bug#7616)
6842 (find_row_edges): If ROW->start.pos gives position
6843 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6844 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6845 Reset the from_disp_prop_p flag.
6846 (SAVE_IT, RESTORE_IT): New macros.
6847 (pos_visible_p, face_before_or_after_it_pos)
6848 (back_to_previous_visible_line_start)
6849 (move_it_in_display_line_to, move_it_in_display_line)
6850 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6851 (try_scrolling, redisplay_window, display_line): Use them when
6852 saving a temporary copy of the iterator and restoring it back.
6853 (back_to_previous_visible_line_start, reseat_1)
6854 (init_iterator): Empty the bidi cache "stack".
6855 (move_it_in_display_line_to): If iterator ended up at
6856 EOL, but we never saw any buffer positions smaller than
6857 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6858 motion in bidi-reordered lines.
6859 (move_it_in_display_line_to): Record prev_method and prev_pos
6860 immediately before the call to set_iterator_to_next. Fixes cursor
6861 motion in bidi-reordered lines with stretch glyphs and strings
6862 displayed in margins. (Bug#8133) (Bug#8867)
6863 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6864 TO_CHARPOS.
640c8776
SM
6865 (pos_visible_p): Support positions in bidi-reordered lines.
6866 Save and restore bidi cache.
0bb23927
EZ
6867
6868 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6869 (bidi_paragraph_info): Delete unused struct.
6870 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6871 (bidi_cache_start): New variable.
6872 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6873 to zero.
6874 (bidi_cache_fetch_state, bidi_cache_search)
6875 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6876 (bidi_cache_find, bidi_peek_at_next_level)
6877 (bidi_level_of_next_char, bidi_find_other_level_edge)
6878 (bidi_move_to_visually_next): Compare cache index with
6879 bidi_cache_start rather than with zero.
6880 (bidi_fetch_char): Accept new argument STRING; all callers
6881 changed. Support iteration over a string. Support strings with
6882 display properties. Support unibyte strings. Fix the type of
6883 `len' according to what STRING_CHAR_AND_LENGTH expects.
6884 (bidi_paragraph_init, bidi_resolve_explicit_1)
6885 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6886 (bidi_level_of_next_char, bidi_move_to_visually_next):
6887 Support iteration over a string.
0bb23927
EZ
6888 (bidi_set_sor_type, bidi_resolve_explicit_1)
6889 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6890 can now be zero (for strings); special values 0 and -1 were
6891 changed to -1 and -2, respectively.
6892 (bidi_char_at_pos): New function.
6893 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6894 Call it instead of FETCH_MULTIBYTE_CHAR.
6895 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6896 initialized to valid values.
6897 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6898 values.
6899 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6900 the test for valid cached positions. Fix the logic for looking up
6901 the sentinel state in the cache. GCPRO the Lisp string we are
6902 iterating.
6903 (bidi_push_it, bidi_pop_it): New functions.
6904 (bidi_initialize): Initialize the bidi cache start stack pointer.
6905 (bidi_cache_ensure_space): New function, refactored from part of
6906 bidi_cache_iterator_state. Don't assume the required size is just
6907 one BIDI_CACHE_CHUNK away.
6908 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6909 (bidi_count_bytes, bidi_char_at_pos): New functions.
6910 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6911 always valid if bidi_cache_idx is valid.
6912 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6913 is valid if it's going to be used.
6914 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6915 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6916 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6917 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6918 (bidi_find_other_level_edge, bidi_cache_start_stack):
6919 All variables related to cache indices are now EMACS_INT.
c965adc5 6920
0bb23927
EZ
6921 * dispextern.h (struct bidi_string_data): New structure.
6922 (struct bidi_it): New member `string'. Make flag members be 1-bit
6923 fields, and put them last in the struct.
640c8776
SM
6924 (compute_display_string_pos, compute_display_string_end):
6925 Update prototypes.
0bb23927
EZ
6926 (bidi_push_it, bidi_pop_it): Add prototypes.
6927 (struct iterator_stack_entry): New members bidi_p,
6928 paragraph_embedding, and from_disp_prop_p.
6929 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6930 (bidi_shelve_cache, bidi_unshelve_cache):
6931 Declare prototypes.
0bb23927
EZ
6932
6933 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6934 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6935 and vector-like objects.
6936
6937 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6938 cache around display iteration.
6939
6940 * window.c (Fwindow_end, window_scroll_pixel_based)
6941 (displayed_window_lines, Frecenter): Save and restore the bidi
6942 cache around display iteration.
6943
3bbd2265
LMI
69442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6945
6946 * editfns.c (Fdelete_region): Clarify the use of the named
6947 parameters (bug#6788).
6948
adc47434
MR
69492011-07-14 Martin Rudalics <rudalics@gmx.at>
6950
6951 * indent.c (Fvertical_motion): Set and restore w->pointm when
6952 saving and restoring the window's buffer (Bug#9006).
6953
837c31f8
LMI
69542011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6955
6956 * editfns.c (Fstring_to_char): Clarify just what is returned
6957 (bug#6576). Text by Eli Zaretskii.
6958
ac389d0c
JB
69592011-07-13 Juanma Barranquero <lekktu@gmail.com>
6960
6961 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6962
0be0ce47
EZ
69632011-07-13 Eli Zaretskii <eliz@gnu.org>
6964
6965 * buffer.c (mmap_find): Fix a typo.
6966
cd18e7e3
JB
69672011-07-13 Johan Bockgård <bojohan@gnu.org>
6968
6969 Fix execution of x selection hooks.
6970 * xselect.c (Qx_lost_selection_functions)
6971 (Qx_sent_selection_functions): New vars.
6972 (syms_of_xselect): DEFSYM them.
6973 (x_handle_selection_request): Pass Qx_sent_selection_functions
6974 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6975 (x_handle_selection_clear,x_clear_frame_selections):
6976 Pass Qx_lost_selection_functions rather than
6977 Vx_lost_selection_functions to Frun_hook_with_args.
6978
47ea7f44
PE
69792011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6980
ac389d0c 6981 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6982 The old code sometimes used this field without initializing it.
6983
47ea7f44
PE
6984 * alloc.c (gc_sweep): Don't read past end of array.
6985 In theory, the old code could also have corrupted Emacs internals,
6986 though it'd be very unlikely.
6987
bc985c87
AS
69882011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6989
6990 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6991 argument. (Bug#4026)
bc985c87 6992
0cf34688
LMI
69932011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6994
b3dadd76
LMI
6995 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6996 key" (bug#4257).
6997
0cf34688
LMI
6998 * window.c (Fset_window_start): Doc fix (bug#4199).
6999 (Fset_window_hscroll): Ditto.
7000
270768cd
PE
70012011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7002
077e3dda 7003 Fix minor new problems caught by GCC 4.6.1.
270768cd 7004 * term.c (init_tty): Remove unused local.
490011a6 7005 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7006 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7007 not used otherwise.
270768cd 7008
b1f58454
CY
70092011-07-12 Chong Yidong <cyd@stupidchicken.com>
7010
7011 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7012
22b9578d
LMI
70132011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7014
6e70ab07
LMI
7015 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7016 are the mini-buffer and the echo area (bug#3320).
7017
22b9578d
LMI
7018 * term.c (init_tty): Remove support for supdup, c10 and perq
7019 terminals, which are no longer supported (bug#1482).
7020
8974cc9f
JB
70212011-07-10 Johan Bockgård <bojohan@gnu.org>
7022
7023 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7024
a560d974
JD
70252011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7026
7027 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7028 for non-popups (Bug#3642).
7029
1dae0f0a
AS
70302011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7031
268c2c36 7032 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7033 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7034 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7035 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7036 * data.c (fmod): Likewise.
7037 * dispnew.c (swap_glyphs_in_rows): Likewise.
7038 * emacs.c (memory_warning_signal): Likewise.
7039 * floatfns.c (float_error): Likewise.
7040 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7041 (otf_open, font_otf_capability, generate_otf_features)
7042 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7043 Likewise.
7044 * image.c (pbm_read_file): Likewise.
7045 * indent.c (string_display_width): Likewise.
7046 * intervals.c (check_for_interval, search_for_interval)
7047 (inc_interval_count, count_intervals, root_interval)
7048 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7049 * lread.c (defalias): Likewise.
268c2c36 7050 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7051 * regex.c (set_image_of_range_1, set_image_of_range)
7052 (regex_grow_registers): Likewise.
7053 * sysdep.c (strerror): Likewise.
7054 * termcap.c (valid_filename_p, tprint, main): Likewise.
7055 * tparam.c (main): Likewise.
7056 * unexhp9k800.c (run_time_remap, save_data_space)
7057 (update_file_ptrs, read_header, write_header, calculate_checksum)
7058 (copy_file, copy_rest, display_header): Likewise.
7059 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7060 Likewise.
7061 * xdisp.c (check_it): Likewise.
7062 * xfaces.c (register_color, unregister_color, unregister_colors):
7063 Likewise.
7064 * xfns.c (print_fontset_result): Likewise.
7065 * xrdb.c (member, fatal, main): Likewise.
7066
99033785
PE
70672011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7068
7069 Fix minor problems found by static checking (Bug#9031).
7070 * chartab.c (char_table_set_range, map_sub_char_table):
7071 Remove unused locals.
7072 (uniprop_table): Now static.
7073 * composite.c (_work_char): Remove unused static var.
7074
9cb2ac56
JB
70752011-07-09 Juanma Barranquero <lekktu@gmail.com>
7076
7077 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7078
f25661f0
JD
70792011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7080
7081 * gtkutil.c (qttip_cb): Remove code without function.
7082
8278c4fe
EZ
70832011-07-09 Eli Zaretskii <eliz@gnu.org>
7084
7085 * w32.c (pthread_sigmask): New stub.
7086
1692ae2d 70872011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7088
8a6ebd58 7089 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7090 sigprocmask is portable only for single-threaded applications, and
7091 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7092 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7093 (LIBES): Use it.
7094 * callproc.c (Fcall_process):
7095 * process.c (create_process):
7096 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7097 Use pthread_sigmask, not sigprocmask.
123403e4 7098
1b854618
JD
70992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7100
7101 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7102 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7103 wrong (Bug#8591).
7104
3fe4b549
JD
71052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7106
0ce7e563
JD
7107 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7108 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7109 (xg_hide_tooltip): Fix comment.
7110
3fe4b549
JD
7111 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7112 in registerServicesMenuSendTypes.
7113 (validRequestorForSendType): Don't check ns_return_types.
7114
7115 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7116 ns_return_type.
7117
5df75e47
JR
71182011-07-08 Jason Rumney <jasonr@gnu.org>
7119
22610910
JR
7120 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7121 SH_SHOW for hidden windows (Bug#5482).
7122
5df75e47
JR
7123 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7124 frame struct members of non-existent frames (Bug#6284).
7125
699c10bd
JD
71262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7127
4393663b
JD
7128 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7129 variable firstTime not needed on OSX >= 10.6.
7130 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7131 >= 10.5. Use setKnobProportion, setDoubleValue.
7132
7133 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7134 (MAC_OS_X_VERSION_10_5): Define if not defined.
7135 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7136 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7137 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7138
7139 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7140 cString and lossyCString on OSX >= 10.4
7141
58179cce 7142 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7143 sizeToFit on OSX >= 10.2.
7144
7145 * nsimage.m (allocInitFromFile): Don't use deprecated method
7146 bestRepresentationForDevice on OSX >= 10.6.
7147
7148 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7149 to avoid warning.
7150
7151 * emacs.c: Declare unexec_init_emacs_zone.
7152
a63e0781
JD
7153 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7154
699c10bd
JD
7155 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7156
7157 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7158 on svcsMenu (Bug#8842).
7159
7160 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7161 ns_return_types.
7162 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7163
7164 * nsterm.m (QUTF8_STRING): Declare.
7165 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7166 (validRequestorForSendType): Return type is (id).
7167 Change indexOfObjectIdenticalTo to indexOfObject.
7168 Check if we have local selection before returning self (Bug#8842).
7169 (writeSelectionToPasteboard): Put local selection into paste board
7170 if we have a local selection (Bug#8842).
7171 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7172
7173 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7174 (ns_get_local_selection): Declare.
7175
54e10184
LMI
71762011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7177
9888ff71
LMI
7178 * keymap.c (describe_map_tree): Don't insert a double newline at
7179 the end of the buffer (bug#1169) and return whether we inserted
7180 something.
7181
54e10184
LMI
7182 * callint.c (Fcall_interactively): Change "reading args" to
7183 "providing args" to try to clarify what it does (bug#1010).
7184
15fa4783
KH
71852011-07-07 Kenichi Handa <handa@m17n.org>
7186
7187 * composite.c (composition_compute_stop_pos): Ignore a static
7188 composition starting before CHARPOS (Bug#8915).
7189
7190 * xdisp.c (handle_composition_prop): Likewise.
7191
a8815b00
EZ
71922011-07-07 Eli Zaretskii <eliz@gnu.org>
7193
7194 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7195 (Bug#9015)
7196
ef7b981d 71972011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7198
7199 * character.h (unicode_category_t): New enum type.
7200
7201 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7202 (Qchar_code_property_table): New variable.
7203 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7204 (UNIPROP_COMPRESSED_FORM_P): New macros.
7205 (char_table_ascii): Uncompress the compressed values.
7206 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7207 Uncompress the compressed values.
ac389d0c 7208 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7209 (char_table_ref_and_range): Uncompress the compressed values.
7210 (sub_char_table_set): New arg is_uniprop. Callers changed.
7211 Uncompress the compressed values.
7212 (sub_char_table_set_range): Args changed. Callers changed.
7213 (char_table_set_range): Adjuted for the above change.
7214 (map_sub_char_table): Delete args default_val and parent. Add arg
7215 top. Give decoded values to a Lisp function.
640c8776 7216 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7217 values to a Lisp function. Gcpro more variables.
7218 (uniprop_table_uncompress)
7219 (uniprop_decode_value_run_length): New functions.
7220 (uniprop_decoder, uniprop_decoder_count): New variables.
7221 (uniprop_get_decoder, uniprop_encode_value_character)
7222 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7223 New functions.
7224 (uniprop_encoder, uniprop_encoder_count): New variables.
7225 (uniprop_get_encoder, uniprop_table)
7226 (Funicode_property_table_internal, Fget_unicode_property_internal)
7227 (Fput_unicode_property_internal): New functions.
7228 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7229 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7230 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7231 char-code-property-alist.
7232
640c8776 7233 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7234 Vunicode_category_table.
7235
640c8776 7236 * font.c (font_range): Adjust for the change of
c805dec0
KH
7237 Vunicode_category_table.
7238
76b397fb
DN
72392011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7240
7241 * m/iris4d.h: Remove file, move contents ...
7242 * s/irix6-5.h: ... here.
7243
22b4128e
PE
72442011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7245
7246 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7247 * alloc.c (mark_buffer):
7248 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7249 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7250 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7251 This isn't true in general, and it's particularly not true
7252 if Emacs is configured with --with-wide-int.
7253 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7254 New macros, used in the buffer.c change.
7255
869795d6
JD
72562011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7257
7258 * xsettings.c: Use both GConf and GSettings if both are available.
7259 (store_config_changed_event): Add comment.
7260 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7261 (store_tool_bar_style_changed): New functions.
5e617bc2 7262 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7263 (struct xsettings): Move font inside HAVE_XFT.
7264 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7265 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7266 Move inside HAVE_XFT.
640c8776 7267 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7268 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7269 also.
7270 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7271 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7272 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7273 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7274 (parse_settings): Move check for font inside HAVE_XFT.
7275 (read_settings, apply_xft_settings): Add comment.
7276 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7277 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7278 call store_font_name_changed.
7279 (xft_settings_event): Add comment.
7280 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7281 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7282 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7283 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7284 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7285 (xsettings_get_system_font, xsettings_get_system_normal_font):
7286 Add comment.
869795d6 7287
d8ed26bd
PE
72882011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7289
7290 Random fixes. E.g., (random) never returned negative values.
7291 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7292 subseconds part to the entropy, as that's a bit more random.
7293 Prefer signed to unsigned, since the signedness doesn't matter and
7294 in general we prefer signed. When given a limit, use a
7295 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7296 latter isn't right if USE_2_TAGS_FOR_INTS.
7297 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7298 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7299
cabf1cac
SM
73002011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7301
7302 * textprop.c (text_property_stickiness):
7303 Obey Vtext_property_default_nonsticky.
7304 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7305 * w32fns.c (syms_of_w32fns):
7306 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7307
6e9b2be9
PE
73082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7311 This is more efficient than Ffile_directory_p and avoids a minor race.
7312
90186c68
LMI
73132011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7314
7c301272
LMI
7315 * buffer.c (Foverlay_put): Say what the return value is
7316 (bug#7835).
7317
c4f2d8d4
LMI
7318 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7319 is a directory before asking whether to use the file name
7320 (bug#7564).
ad637907
LMI
7321 (barf_or_query_if_file_exists): Make the "File is a directory"
7322 error be more correct.
c4f2d8d4 7323
90186c68
LMI
7324 * fns.c (Frequire): Remove the mention of the .gz files, since
7325 that's installation-specific, but keep the mention of
7326 `get-load-suffixes'.
7327
da64016e
PE
73282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7329
7330 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7331 Report string overflow if the output is too long.
7332
7d47b580
JB
73332011-07-04 Juanma Barranquero <lekktu@gmail.com>
7334
a555cb87
JB
7335 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7336 (syms_of_gnutls): Remove duplicate DEFSYM for
7337 Qgnutls_bootprop_verify_hostname_error, an error for
7338 Qgnutls_bootprop_verify_error (which is no longer used).
7339
7d47b580
JB
7340 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7341 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7342 Also (re)move comments that are misplaced or no longer relevant.
7343
1e49bfab
LMI
73442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7345
7346 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7347
1485f4c0
CY
73482011-07-03 Chong Yidong <cyd@stupidchicken.com>
7349
7350 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7351 and background color parameters if they have been changed.
7352
a9ab721e
LMI
73532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7354
7355 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7356
cf7cff57
PE
73572011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7358
2e13213d
PE
7359 * xsettings.c (SYSTEM_FONT): Define only when used.
7360 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7361
cf7cff57
PE
7362 * keymap.c (access_keymap_1): Now static.
7363
7a8e04f7
CY
73642011-07-02 Chong Yidong <cyd@stupidchicken.com>
7365
7366 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7367 leave any prefix arg for the up event (Bug#1586).
7368
61352f62
LMI
73692011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7370
69bb1ef7
LMI
7371 * lread.c (syms_of_lread): Mention single symbols defined by
7372 `defvar' or `defconst' (bug#7154).
7373
61352f62 7374 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7375 (Frequire): Mention get-load-suffixes.
61352f62 7376
28545e04
MR
73772011-07-02 Martin Rudalics <rudalics@gmx.at>
7378
7379 * window.h (window): Remove clone_number slot.
7380 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7381 Remove.
7382 (make_parent_window, make_window, saved_window)
7383 (Fset_window_configuration, save_window_save): Don't deal with
7384 clone numbers.
7385 * buffer.c (Qclone_number): Remove declaration.
7386 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7387
3349e122
SM
73882011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7389
7390 Add multiple inheritance to keymaps.
7391 * keymap.c (Fmake_composed_keymap): New function.
7392 (Fset_keymap_parent): Simplify.
7393 (fix_submap_inheritance): Remove.
7394 (access_keymap_1): New function extracted from access_keymap to handle
7395 embedded parents and handle lists of maps.
7396 (access_keymap): Use it.
7397 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7398 (Fcopy_keymap): Handle embedded parents.
7399 (Fcommand_remapping, define_as_prefix): Simplify.
7400 (Fkey_binding): Simplify.
7401 (syms_of_keymap): Move minibuffer-local-completion-map,
7402 minibuffer-local-filename-completion-map,
7403 minibuffer-local-must-match-map, and
7404 minibuffer-local-filename-must-match-map to Elisp.
7405 (syms_of_keymap): Defsubr make-composed-keymap.
7406 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7407 (parse_menu_item): Trivial simplification.
7408
3279eb87
GM
74092011-07-01 Glenn Morris <rgm@gnu.org>
7410
7411 * Makefile.in (SETTINGS_LIBS): Fix typo.
7412
4550efdf
KI
74132011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7414
7415 * coding.c (Fencode_coding_string): Record the last coding system
7416 used, as the function doc string says (bug#8738).
7417
0949d2b6
JD
74182011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7419
7420 * xsettings.c (store_monospaced_changed): Take new font as arg and
7421 check for change against current_mono_font.
7422 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7423 (emacs_settings_constructor, emacs_settings_get_property)
7424 (emacs_settings_set_property, emacs_settings_class_init)
7425 (emacs_settings_init, gsettings_obj): Remove.
7426 (something_changedCB): New function for HAVE_GSETTINGS.
7427 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7428 with value as argument.
7429 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7430 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7431 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7432 "changed".
7433
7434 * xgselect.c: Add defined (HAVE_GSETTINGS).
7435 (xgselect_initialize): Ditto.
7436
7437 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7438 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7439 xg_select.
7440
bbc6b304
PE
74412011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7442
7443 * eval.c (struct backtrace): Simplify and port the data structure.
7444 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7445 signed bit field, as this assumption is not portable and it makes
7446 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7447 "char debug_on_exit : 1" as this is not portable either; instead,
7448 use the portable "unsigned int debug_on_exit : 1". Remove unused
7449 member evalargs. Remove obsolete comments about cc bombing out.
7450
9851bfc5
JD
74512011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7452
51bb811f 7453 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7454 Let HAVE_GSETTINGS override HAVE_GCONF.
7455 (store_monospaced_changed): New function.
7456 (EMACS_SETTINGS): A new type derived from GObject to handle
7457 GSettings notifications.
7458 (emacs_settings_constructor, emacs_settings_get_property)
7459 (emacs_settings_set_property, emacs_settings_class_init):
7460 New functions.
7461 (gsettings_client, gsettings_obj): New variables.
7462 (GSETTINGS_SCHEMA): New define.
7463 (something_changedCB): Call store_monospaced_changed.
7464 (init_gsettings): New function.
7465 (xsettings_initialize): Call init_gsettings.
7466 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7467 to NULL.
7468
640c8776 7469 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7470 GCONF_CFLAGS/LIBS.
7471
5386012d
MR
74722011-06-29 Martin Rudalics <rudalics@gmx.at>
7473
7474 * window.c (resize_root_window, grow_mini_window)
7475 (shrink_mini_window): Rename Qresize_root_window to
7476 Qwindow_resize_root_window and Qresize_root_window_vertically to
7477 Qwindow_resize_root_window_vertically.
7478
f13e0b08
PE
74792011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7480
7481 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7482
94515237
JB
74832011-06-27 Juanma Barranquero <lekktu@gmail.com>
7484
7485 * makefile.w32-in: Redesign dependencies so they reflect more
7486 clearly which files are directly included by each source file,
7487 and not through other includes.
7488
e43b6e43
MR
74892011-06-27 Martin Rudalics <rudalics@gmx.at>
7490
7491 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7492 (sort_overlays, overlay_strings): When an overlay's clone number
7493 matches the window's clone number process the overlay even if
7494 the overlay's window property doesn't match the current window.
7495
d68443dc
MR
7496 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7497 (Fwindow_hchild): Rename to Fwindow_left_child.
7498 (Fwindow_next): Rename to Fwindow_next_sibling.
7499 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7500 (resize_window_check): Rename to window_resize_check.
7501 (resize_window_apply): Rename to window_resize_apply.
7502 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7503 (Fdelete_other_windows_internal, resize_frame_windows)
7504 (Fsplit_window_internal, Fdelete_window_internal)
7505 (grow_mini_window, shrink_mini_window)
7506 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7507
c7e73be5
JD
75082011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7509
7510 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7511 (emacs_fixed_set_min_size): Remove.
7512 (emacs_fixed_new): Take frame as argument.
7513
7514 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7515 (_EmacsFixedPrivate): Remove minwidth/height.
7516 Add struct frame *f.
7517 (emacs_fixed_init): Initialize priv->f.
7518 (get_parent_class, emacs_fixed_set_min_size): Remove.
7519 (emacs_fixed_new): Set priv->f to argument.
7520 (emacs_fixed_get_preferred_width)
7521 (emacs_fixed_get_preferred_height): Use min_width/height from
7522 frames size_hint to set minimum and natural (Bug#8919).
7523 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7524 and use min_width/height from frames size_hint to set
7525 min_width/height (Bug#8919).
7526
7527 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7528 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7529 Fix indentation.
c7e73be5 7530
cf99dcf8
EZ
75312011-06-26 Eli Zaretskii <eliz@gnu.org>
7532
7533 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7534 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7535 called at ZV.
7536
029529ac
CY
75372011-06-26 Chong Yidong <cyd@stupidchicken.com>
7538
7539 * process.c (wait_reading_process_output): Bypass select if
7540 waiting for a cell while ignoring keyboard input, and input is
7541 pending. Suggested by Jan Djärv (Bug#8869).
7542
7a7ef429
PE
75432011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7544
7545 Use gnulib's dup2 module instead of rolling our own.
7546 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7547
11fdef7d 75482011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7549
7550 * dispnew.c (scrolling_window): Before scrolling, turn off a
7551 mouse-highlight in the window being scrolled.
7552
cd3520a4
JB
75532011-06-24 Juanma Barranquero <lekktu@gmail.com>
7554
7555 Move DEFSYM to lisp.h and use everywhere.
7556
7557 * character.h (DEFSYM): Move declaration...
7558 * lisp.h (DEFSYM): ...here.
7559
7560 * gnutls.c:
7561 * minibuf.c:
7562 * w32menu.c:
7563 * w32proc.c:
7564 * w32select.c: Don't include character.h.
7565
7566 * alloc.c (syms_of_alloc):
7567 * buffer.c (syms_of_buffer):
7568 * bytecode.c (syms_of_bytecode):
7569 * callint.c (syms_of_callint):
7570 * casefiddle.c (syms_of_casefiddle):
7571 * casetab.c (init_casetab_once):
7572 * category.c (init_category_once, syms_of_category):
7573 * ccl.c (syms_of_ccl):
7574 * cmds.c (syms_of_cmds):
7575 * composite.c (syms_of_composite):
7576 * dbusbind.c (syms_of_dbusbind):
7577 * dired.c (syms_of_dired):
7578 * dispnew.c (syms_of_display):
7579 * doc.c (syms_of_doc):
7580 * editfns.c (syms_of_editfns):
7581 * emacs.c (syms_of_emacs):
7582 * eval.c (syms_of_eval):
7583 * fileio.c (syms_of_fileio):
7584 * fns.c (syms_of_fns):
7585 * frame.c (syms_of_frame):
7586 * fringe.c (syms_of_fringe):
7587 * insdel.c (syms_of_insdel):
7588 * keymap.c (syms_of_keymap):
7589 * lread.c (init_obarray, syms_of_lread):
7590 * macros.c (syms_of_macros):
7591 * msdos.c (syms_of_msdos):
7592 * print.c (syms_of_print):
7593 * process.c (syms_of_process):
7594 * search.c (syms_of_search):
7595 * sound.c (syms_of_sound):
7596 * syntax.c (init_syntax_once, syms_of_syntax):
7597 * terminal.c (syms_of_terminal):
7598 * textprop.c (syms_of_textprop):
7599 * undo.c (syms_of_undo):
7600 * w32.c (globals_of_w32):
7601 * window.c (syms_of_window):
7602 * xdisp.c (syms_of_xdisp):
7603 * xfaces.c (syms_of_xfaces):
7604 * xfns.c (syms_of_xfns):
7605 * xmenu.c (syms_of_xmenu):
7606 * xsettings.c (syms_of_xsettings):
7607 * xterm.c (syms_of_xterm): Use DEFSYM.
7608
4228cf16
TZ
76092011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7610
cd3520a4 7611 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7612
7fcccf1e
PE
76132011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7614
7efb4e0e
PE
7615 Integer and buffer overflow fixes (Bug#8873).
7616
ff5844ad
PE
7617 * print.c (printchar, strout): Check for string overflow.
7618 (PRINTPREPARE, printchar, strout):
7619 Don't set size unless allocation succeeds.
7620
90532f02
PE
7621 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7622 for sizes. Check for string overflow more accurately.
7623 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7624
6d84508d
PE
7625 * macros.c: Integer and buffer overflow fixes.
7626 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7627 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7628 Use ptrdiff_t, not int, for sizes.
7629 Don't increment bufsize until after realloc succeeds.
7630 Check for size-calculation overflow.
7631 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7632
437b2cb4
PE
7633 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7634
8b9ac8b4
PE
7635 * lread.c: Integer overflow fixes.
7636 (read_integer): Radix is now EMACS_INT, not int,
7637 to improve quality of diagnostics for out-of-range radices.
7638 Calculate buffer size correctly for out-of-range radices.
7639 (read1): Check for integer overflow in radices, and in
7640 read-circle numbers.
82cb60d3
PE
7641 (read_escape): Avoid int overflow.
7642 (Fload, openp, read_buffer_size, read1)
7643 (substitute_object_recurse, read_vector, read_list, map_obarray):
7644 Use ptrdiff_t, not int, for sizes.
7645 (read1): Use EMACS_INT, not int, for sizes.
20270765 7646 Check for size overflow.
8b9ac8b4 7647
7fcccf1e
PE
7648 * image.c (cache_image): Check for size arithmetic overflow.
7649
bfbbd7e7
PE
7650 * lread.c: Integer overflow issues.
7651 (saved_doc_string_size, saved_doc_string_length)
7652 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7653 Now ptrdiff_t, not int.
7654 (read1): Don't assume doc string length fits in int. Check for
7655 out-of-range doc string lengths.
7656 (read_list): Don't assume file position fits in int.
39019e54 7657 (read_escape): Check for hex character overflow.
bfbbd7e7 7658
4e323265
LL
76592011-06-22 Leo Liu <sdl.web@gmail.com>
7660
7661 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7662 Move to minibuffer.el.
7663
85fece3e
PE
76642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7665
20b84ce9 7666 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7667 The following patches are for when GLYPH_DEBUG && !XASSERT.
7668 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7669 * dispnew.c (flush_stdout):
7670 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7671 Mark as externally visible.
7672 * dispnew.c (check_window_matrix_pointers): Now static.
7673 * dispnew.c (window_to_frame_vpos):
7674 * xfns.c (unwind_create_frame):
7675 * xterm.c (x_check_font): Remove unused local.
7676 * scroll.c (CHECK_BOUNDS):
7677 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7678 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7679 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7680 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7681 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7682 Now static.
7683 (debug_method_add): Use va_list and vsprintf rather than relying
7684 on undefined behavior with wrong number of arguments.
7685 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7686 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7687 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7688 since we're not interested in debugging glyphs with old libraries.
7689 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7690 GCC 4.6.0's static checking.
7691
0766b489
PE
76922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7693
31fd4b32
PE
7694 Integer overflow and signedness fixes (Bug#8873).
7695 A few related buffer overrun fixes, too.
7696
b79e8648
PE
7697 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7698
0766b489
PE
7699 * dispextern.h (struct face.stipple):
7700 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7701 (x_bitmap_mask, x_allocate_bitmap_record)
7702 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7703 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7704 (x_create_bitmap_from_xpm_data):
7705 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7706 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7707 (.bitmaps_last):
7708 * xfaces.c (load_pixmap):
7709 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7710 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7711 (.bitmaps_last, struct x_output.icon_bitmap):
7712 Use ptrdiff_t, not int, for bitmap indexes.
7713 (x_allocate_bitmap_record): Check for size overflow.
7714 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7715
b081724f
PE
7716 Use ptrdiff_t, not int, for overlay counts.
7717 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7718 * editfns.c (overlays_around, get_pos_property):
7719 * textprop.c (get_char_property_and_overlay):
7720 * xdisp.c (next_overlay_change, note_mouse_highlight):
7721 * xfaces.c (face_at_buffer_position):
21514da7
PE
7722 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7723 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7724 (Fnext_overlay_change, Fprevious_overlay_change)
7725 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7726 Use ptrdiff_t, not int, for sizes.
21514da7 7727 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7728
3de73e5e
PE
7729 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7730
2606c57b
PE
7731 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7732 (x_session_initialize): Do not assume string length fits in int.
7733
aaafe47a
PE
7734 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7735 This is unlikely, but can occur if DPI is outlandish.
7736
2674ddc8 7737 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7738 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7739
28154962
PE
7740 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7741 * xrdb.c (magic_file_p, search_magic_path):
7742 Omit last arg SUFFIX; it was always 0. All callers changed.
7743 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7744
7de51af5
PE
7745 * xfont.c (xfont_match): Avoid need for strlen.
7746
25ed6cc3
PE
7747 * xfns.c: Don't assume strlen fits in int.
7748 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7749
4eab31dd
PE
7750 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7751 not unsigned long, as we prefer signed integers. All callers changed.
7752 Detect integer overflow in repeat count.
7753 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7754 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7755
171e2a58
PE
7756 * termcap.c: Don't assume sizes fit in int and never overflow.
7757 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7758 (gobble_line): Check for size-calculation overflow.
7759
ad39faca 7760 * minibuf.c (Fread_buffer):
6e5bb2dc 7761 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7762 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7763 Don't assume string length fits in int.
7764
52c61c22 7765 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7766 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7767
b5b8c9e5
PE
7768 * font.c: Don't assume string length fits in int.
7769 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7770 Use ptrdiff_t, not int.
ccd6111c
PE
7771 (font_intern_prop): Don't assume string length fits in int.
7772 Don't assume integer property fits in fixnum.
7773 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7774
882f0d81 7775 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7776 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7777 Reformulate so as not to need the command string.
7778 Invoke gzip -cd rather than gunzip, as it's more portable.
7779 (lock_info_type, lock_file_1, lock_file):
7780 Don't assume pid_t and time_t fit in unsigned long.
7781 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7782 (current_lock_owner): Prefer signed type for sizes.
7783 Use memcpy, not strncpy, where memcpy is what is really wanted.
7784 Don't assume (via atoi) that time_t and pid_t fit in int.
7785 Check for time_t and/or pid_t out of range, e.g., via a network share.
7786 Don't alloca where an auto var works fine.
7787
93f4cf88
PE
7788 * fileio.c: Fix some integer overflow issues.
7789 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7790 Don't assume string length fits in int.
7791 (directory_file_name): Don't assume string length fits in long.
7792 (make_temp_name): Don't assume pid fits in int, or that its print
7793 length is less than 20.
7794
f3e92b69
PE
7795 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7796
1bfdaf10
PE
7797 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7798
35016e9a
PE
7799 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7800
3d1e65a1
PE
7801 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7802 We prefer signed integers, even for size calculations.
7803
0b963a93
PE
7804 * emacs.c: Don't assume string length fits in 'int'.
7805 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7806 (main): Don't invoke strlen when not needed.
7807
573f4b54
PE
7808 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7809 (XD_DEBUG_MESSAGE): Don't waste a byte.
7810
989f33ba
PE
7811 * callproc.c (getenv_internal_1, getenv_internal)
7812 (Fgetenv_internal):
965d34eb
PE
7813 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7814
e4d29b33
PE
7815 * lread.c (invalid_syntax): Omit length argument.
7816 All uses changed. This doesn't fix a bug, but it simplifies the
7817 code away from its former Hollerith-constant appearance, and it's
7818 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7819 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7820
eb49b136
PE
7821 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7822 This didn't break anything, but it didn't help either.
7823 It's confusing to put a bogus integer in a place where the actual
7824 value does not matter.
9f62aeb1 7825 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7826 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7827
15375a22
PE
7828 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7829 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7830 implementation.
b61cc01c
PE
7831 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7832 We prefer signed types, and the value cannot exceed the EMACS_INT
7833 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7834 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7835 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7836 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7837
53b2623d
PE
7838 * indent.c (sane_tab_width): New function.
7839 (current_column, scan_for_column, Findent_to, position_indentation)
7840 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7841 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7842
51cab52b 7843 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7844
f2ed8a70
PE
7845 * lisp.h (lint_assume): New macro.
7846 * composite.c (composition_gstring_put_cache):
7847 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7848
abe80cc6
PE
7849 * editfns.c, insdel.c:
7850 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7851
b02c740e
PE
7852 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7853
ebc96716
PE
7854 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7855
b4e50fa0 7856 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7857 Use much-faster test for byte-length change.
311d5d7c 7858 Don't assume string byte-length fits in 'int'.
a4cf38e4 7859 Check that character arg fits in 'int'.
85461888 7860 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7861
c0c1ee9f
PE
7862 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7863
a498d7f4
PE
7864 * fns.c (concat): Catch string overflow earlier.
7865 Do not rely on integer wraparound.
7866
51cab52b
PE
7867 * dispextern.h (struct it.overlay_strings_charpos)
7868 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7869 * xdisp.c (forward_to_next_line_start)
7870 (back_to_previous_visible_line_start)
7871 (reseat_at_next_visible_line_start, next_element_from_buffer):
7872 Don't arbitrarily truncate the value of 'selective' to int.
7873
76031fad
PE
7874 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7875
5eb55db9
PE
7876 * composite.c: Don't truncate sizes to 'int'.
7877 (composition_gstring_p, composition_reseat_it)
7878 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7879 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7880 not EMACS_UINT, for indexes.
5eb55db9 7881
0703a717
PE
7882 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7883
d6202519
PE
7884 * buffer.c: Include <verify.h>.
7885 (struct sortvec.priority, struct sortstr.priority):
8961a454 7886 Now EMACS_INT, not int.
c20998a7 7887 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7888 (struct sortstr.size, record_overlay_string)
7889 (struct sortstrlist.size, struct sortlist.used):
7890 Don't truncate size to int.
7891 (record_overlay_string): Check for size-calculation overflow.
d6202519 7892 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7893
d5a19415
JM
78942011-06-22 Jim Meyering <meyering@redhat.com>
7895
029529ac 7896 Don't leak an XBM-image-sized buffer
d5a19415
JM
7897 * image.c (xbm_load): Free the image buffer after using it.
7898
a9041e6c
PE
78992011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7900
7901 Port to Sun C.
7902 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7903 that Sun C diagnosed.
7904 * fns.c (secure_hash): Fix pointer signedness issue.
7905 * intervals.c (static_offset_intervals): New function.
7906 (offset_intervals): Use it.
7907
7f3f739f
LL
79082011-06-21 Leo Liu <sdl.web@gmail.com>
7909
7910 * deps.mk (fns.o):
7911 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7912 sha512.h.
7913
7914 * fns.c (secure_hash): Rename from crypto_hash_function and change
7915 the first arg to accept symbols.
5b66d427 7916 (Fsecure_hash): New primitive.
7f3f739f
LL
7917 (syms_of_fns): New symbols.
7918
76147d94
DD
79192011-06-20 Deniz Dogan <deniz@dogan.se>
7920
7921 * process.c (Fset_process_buffer): Clarify return value in
7922 docstring.
7923
7d7d0045
CY
79242011-06-18 Chong Yidong <cyd@stupidchicken.com>
7925
7926 * dispnew.c (add_window_display_history): Use BVAR.
7927
7928 * xdisp.c (debug_method_add): Use BVAR.
7929 (check_window_end, dump_glyph_matrix, dump_glyph)
7930 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7931
7932 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7933 Likewise.
7934
7935 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7936 check till after the cache is created in init_frame_faces.
7937
ff2bc410
SM
79382011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7939
7940 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7941
28177add
PE
79422011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7943
dd3482fe
PE
7944 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7945 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7946 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7947
393d71f3 7948 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7949 * fileio.c (Finsert_file_contents):
7950 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7951 Remove the old (too-loose) buffer overflow checks.
7952 They weren't needed, since make_gap checks for buffer overflow.
7953 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7954 The old code merely checked for Emacs fixnum overflow, and relied
7955 on undefined (wraparound) behavior. The new code avoids undefined
7956 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7957
2e6813b0 7958 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7959 Tune. Don't use wider integers than needed. Don't use alloca.
7960 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7961
599a9e4f
PE
7962 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7963
99561444
PE
7964 * insdel.c, lisp.h (buffer_overflow): New function.
7965 (insert_from_buffer_1, replace_range, replace_range_2):
7966 * insdel.c (make_gap_larger):
7967 * editfns.c (Finsert_char):
7968 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7969
28177add
PE
7970 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7971
e69dafad
PE
79722011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7973
4baa020d 7974 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7975
b1c46f02
PE
7976 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7977 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7978
e69dafad
PE
7979 * fileio.c: Don't assume EMACS_INT fits in off_t.
7980 (emacs_lseek): New static function.
7981 (Finsert_file_contents, Fwrite_region): Use it.
7982 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7983
566684ea
PE
7984 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7985
e6966cd6
PE
7986 * fns.c: Don't overflow int when computing a list length.
7987 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7988 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7989 truncation on 64-bit hosts. Check for QUIT every
7990 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7991 faster and is responsive enough.
7992 (Flength): Report an error instead of overflowing an integer.
7993 (Fsafe_length): Return a float if the value is not representable
7994 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7995 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7996 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7997
dd0b0efb
PE
7998 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7999 (header_size, word_size): New constants.
8000 (allocate_vectorlike): Don't check size overflow here.
8001 (allocate_vector): Check it here instead, since this is the only
8002 caller of allocate_vectorlike that could cause overflow.
8003 Check that the new vector's length is representable as a fixnum.
8004
86fe5cfe
PE
8005 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8006 The previous code was bogus. For example, next_almost_prime (32)
8007 returned 39, which is undesirable as it is a multiple of 3; and
8008 next_almost_prime (24) returned 25, which is a multiple of 5 so
8009 why was the code bothering to check for multiples of 7?
8010
80e88859
PE
8011 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8012
4a2f0ad6
PE
8013 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8014
f66c7cf8
PE
8015 Variadic C functions now count arguments with ptrdiff_t.
8016 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8017 Back then I didn't know that the Emacs coding style prefers signed int.
8018 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8019 were being counted with int, which may truncate counts on 64-bit
8020 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8021 * lisp.h (struct Lisp_Subr.function.aMANY)
8022 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8023 Arg counts are now ptrdiff_t, not size_t.
8024 All variadic functions and their callers changed accordingly.
8025 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8026 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8027 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8028 * callint.c (Fcall_interactively): Check arg count for overflow,
8029 to avoid potential buffer overrun. Use signed char, not 'int',
8030 for 'varies' array, so that we needn't bother to check its size
8031 calculation for overflow.
8032 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8033 * eval.c (apply_lambda):
8034 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8035 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8036 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8037
a1759b76
PE
8038 * callint.c (Fcall_interactively): Don't use index var as event count.
8039
d96be9fc
PE
8040 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8041 * mem-limits.h (SIZE): Remove; no longer used.
8042
a690a978 8043 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8044
578c21e6
PE
8045 Remove unnecessary casts.
8046 * xterm.c (x_term_init):
8047 * xfns.c (x_set_border_pixel):
8048 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8049 These aren't needed now that we assume ANSI C.
8050
96f53c6c
PE
8051 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8052 It's more likely to cause problems (due to unsigned overflow)
8053 than to cure them.
8054
83c77d31
PE
8055 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8056
ee2079f1
PE
8057 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8058
6da65536
PE
8059 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8060
7147c4a4
PE
8061 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8062
193e32d9
PE
8063 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8064
e5533da6
PE
8065 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8066
9910e595
PE
8067 GLYPH_CODE_FACE returns EMACS_INT, not int.
8068 * dispextern.h (merge_faces):
8069 * xfaces.c (merge_faces):
01103c44
PE
8070 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8071 Don't assume EMACS_INT fits in int.
9910e595 8072
2638320e
PE
8073 * character.h (CHAR_VALID_P): Remove unused parameter.
8074 * fontset.c, lisp.h, xdisp.c: All uses changed.
8075
045eb8d9
PE
8076 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8077
c1f134b5
PE
8078 * fns.c (concat): Minor tuning based on overflow analysis.
8079 This doesn't fix any bugs. Use int to hold character, instead
8080 of constantly refetching from Emacs object. Use XFASTINT, not
8081 XINT, for value known to be a character. Don't bother comparing
8082 a single byte to 0400, as it's always less.
8083
395fcb93 8084 * floatfns.c (Fexpt):
327eeec8
PE
8085 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8086
abbd3d23
PE
8087 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8088 for characters.
8089
684a03ef
PE
8090 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8091
0fed43f3
PE
8092 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8093 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8094 incorrectly succeed when S was a string, because 4294967386 was
8095 truncated before it was used.
8096
8fd02eb7
PE
8097 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8098 Otherwise, an out-of-range integer could cause undefined behavior
8099 on a 64-bit host.
8100
f8c86b69
PE
8101 * composite.c: Use int, not EMACS_INT, for characters.
8102 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8103 EMACS_INT, for values that are known to be in character range.
8104 This doesn't fix any bugs but is the usual style inside Emacs and
8105 may generate better code on 32-bit machines.
8106
34206dd2
PE
8107 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8108 This is for reasons similar to the recent CHAR_STRING fix.
8109 * charset.c (Fencode_char): Check that character arg is actually
8110 a character. Pass an int to ENCODE_CHAR.
8111 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8112 wider than 'int', as a compile-time check to prevent future regressions
8113 in this area.
8114
c5958d4c 8115 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8116
8117 Make sure a 64-bit char is never passed to CHAR_STRING.
8118 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8119 by silently ignoring the top 32 bits, allowing some values
8120 that were far too large to be valid characters.
8121 * character.h: Include <verify.h>.
8122 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8123 arguments are no wider than unsigned, as a compile-time check
8124 to prevent future regressions in this area.
8125 * data.c (Faset):
01103c44 8126 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8127 (Fsubst_char_in_region):
8128 * fns.c (concat):
8129 * xdisp.c (decode_mode_spec_coding):
8130 Adjust to CHAR_STRING's new requirement.
8131 * editfns.c (Finsert_char, Fsubst_char_in_region):
8132 * fns.c (concat): Check that character args are actually
8133 characters. Without this test, these functions did the wrong
8134 thing with wildly out-of-range values on 64-bit hosts.
8135
d37ca623
PE
8136 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8137 These casts should not be needed on 32-bit hosts, either.
8138 * keyboard.c (read_char):
8139 * lread.c (Fload): Remove casts to unsigned.
8140
ea204efb
PE
8141 * lisp.h (UNSIGNED_CMP): New macro.
8142 This fixes comparison bugs on 64-bit hosts.
8143 (ASCII_CHAR_P): Use it.
8144 * casefiddle.c (casify_object):
01103c44 8145 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8146 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8147 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8148 * dispextern.h (FACE_FROM_ID):
8149 * keyboard.c (read_char): Use UNSIGNED_CMP.
8150
41cb286c
PE
8151 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8152 not to EMACS_INT, to avoid GCC warning.
8153
4a1b9832
PE
8154 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8155
55daad71
PE
8156 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8157 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8158 isn't needed on 32-bit machines.
8f95c75c 8159
01103c44
PE
8160 * buffer.c (Fgenerate_new_buffer_name):
8161 Use EMACS_INT for count, not int.
0ceccced 8162 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8163
8164 * data.c (Qcompiled_function): Now static.
8165
c6f072e7
PE
8166 * window.c (window_body_lines): Now static.
8167
20ce5912
PE
8168 * image.c (gif_load): Rename local to avoid shadowing.
8169
9c4c5f81
PE
8170 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8171 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8172 * alloc.c (make_save_value): Integer argument is now of type
8173 ptrdiff_t, not int.
8174 (mark_object): Use ptrdiff_t, not int.
8175 * lisp.h (pD): New macro.
8176 * print.c (print_object): Use it.
8177
c0c5c8ae
PE
8178 * alloc.c: Use EMACS_INT, not int, to count objects.
8179 (total_conses, total_markers, total_symbols, total_vector_size)
8180 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8181 (total_free_floats, total_floats, total_free_intervals)
8182 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8183 Now EMACS_INT, not int. All uses changed.
8184 (Fgarbage_collect): Compute overall total using a double, so that
8185 integer overflow is less likely to be a problem. Check for overflow
8186 when converting back to an integer.
5a25e253
PE
8187 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8188 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8189 These were 'int' variables that could overflow on 64-bit hosts;
8190 they were never used, so remove them instead of repairing them.
211a0b2a 8191 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8192 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8193 Previously, this ceilinged at INT_MAX, but that doesn't work on
8194 64-bit machines.
e46bb31a 8195 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8196
c78baabf 8197 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8198 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8199 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8200 when a (possibly-narrower) signed value would do just as well.
8201 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8202
c9d624c6
PE
8203 * alloc.c: Catch some string size overflows that we were missing.
8204 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8205 for convenience in STRING_BYTES_MAX.
8206 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8207 The definition here is exact; the one in lisp.h was approximate.
8208 (allocate_string_data): Check for string overflow. This catches
8209 some instances we weren't catching before. Also, it catches
8210 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8211 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8212 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8213
c9d624c6
PE
8214 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8215 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8216 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8217
353032ce
PE
8218 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8219
2bccce07
PE
8220 * alloc.c (Fmake_string): Check for out-of-range init.
8221
0ac30604
SM
82222011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8223
8224 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8225
c195f2de
JD
82262011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8227
8228 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8229 xg_get_default_scrollbar_width.
8230
8231 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8232 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8233 (style_changed_cb): Call update_theme_scrollbar_width and call
8234 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8235 all frames (Bug#8505).
8236 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8237 Call gtk_window_set_resizable if HAVE_GTK3.
8238 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8239 and height if HAVE_GTK3 (Bug#8505).
8240 (scroll_bar_width_for_theme): New variable.
8241 (update_theme_scrollbar_width): New function.
8242 (xg_get_default_scrollbar_width): Move code to
8243 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8244 (xg_initialize): Call update_theme_scrollbar_width.
8245
8246 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8247
8248 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8249
e10ac9f1
MR
82502011-06-12 Martin Rudalics <rudalics@gmx.at>
8251
8252 * frame.c (make_frame): Call other_buffer_safely instead of
8253 other_buffer.
8254
8255 * window.c (temp_output_buffer_show): Call display_buffer with
8256 second argument Vtemp_buffer_show_specifiers and reset latter
8257 immediately after the call.
8258 (Vtemp_buffer_show_specifiers): New variable.
8259 (auto_window_vscroll_p, next_screen_context_lines)
8260 (Vscroll_preserve_screen_position): Remove leading asterisks from
8261 doc-strings.
8262
2d3c217e 82632011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8264
7b7f97e8 8265 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8266 * buffer.c (Qclone_number): Remove for now, as it's unused.
8267 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8268 (record_buffer): Remove unused local.
8269 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8270 (set_frame_buffer_list): Remove; unused.
8271 * frame.h (other_visible_frames): Remove decl.
8272 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8273 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8274 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8275 if HAVE_GPM.
8276 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8277 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8278 Define only if HAVE_GPM.
8279 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8280 (update_hints_inhibit): Remove; never set. All uses removed.
8281 * widgetprv.h (emacsFrameClassRec): Remove decl.
8282 * window.c (delete_deletable_window): Now returns void, since it
8283 wasn't returning anything.
8284 (compare_window_configurations): Remove unused locals.
8285 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8286 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8287 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8288 the same widths as pointers. This follows up on the 2011-05-06 patch.
8289 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8290 * xterm.h: Likewise.
8291 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8292
1384b89e
JB
82932011-06-12 Juanma Barranquero <lekktu@gmail.com>
8294
8295 * makefile.w32-in: Update dependencies.
8296 (LISP_H): Add lib/intprops.h.
8297
1100a63c
CY
82982011-06-11 Chong Yidong <cyd@stupidchicken.com>
8299
8300 * image.c (gif_load): Add animation frame delay to the metadata.
8301 (syms_of_image): Use DEFSYM. New symbol `delay'.
8302
6198ccd0
MR
83032011-06-11 Martin Rudalics <rudalics@gmx.at>
8304
8305 * window.c (delete_deletable_window): Re-add.
8306 (Fset_window_configuration): Rewrite to handle dead buffers and
8307 consequently deletable windows.
8308 (window_tree, Fwindow_tree): Remove. Supply functionality in
8309 window.el.
8310 (compare_window_configurations): Simplify code.
8311
b6e3633c
AS
83122011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8313
1ab0dee5
AS
8314 * image.c (imagemagick_load_image): Fix type mismatch.
8315 (Fimagemagick_types): Likewise.
8316
b6e3633c
AS
8317 * window.h (replace_buffer_in_windows): Declare.
8318
9397e56f
MR
83192011-06-11 Martin Rudalics <rudalics@gmx.at>
8320
8321 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8322 Qclone_number. Remove external declaration of Qdelete_window.
8323 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8324 code.
640c8776
SM
8325 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8326 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8327 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8328 buffer list implementation.
8329 (other_buffer_safely): New function.
8330 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8331 calls to replace_buffer_in_windows and
8332 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8333 if allowed.
8334 (record_buffer): Inhibit quitting and rewrite using quittable
8335 functions. Run Qbuffer_list_update_hook if allowed.
8336 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8337 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8338 Move switch-to-buffer to window.el.
9397e56f
MR
8339 (bury-buffer): Move to window.el.
8340 (Vbuffer_list_update_hook): New variable.
8341
8342 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8343 section.
8344
8345 * window.h (resize_frame_windows): Move up in code.
8346 (Fwindow_frame): Remove EXFUN.
8347 (replace_buffer_in_all_windows): Remove prototype.
8348 (replace_buffer_in_windows_safely): Add prototype.
8349
8350 * window.c: Declare Qdelete_window static again. Move down
8351 declaration of select_count.
8352 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8353 (Fother_window): Move to window.el.
8354 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8355 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8356 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8357 window.el.
8358 (replace_buffer_in_windows): Implement by calling
8359 Qreplace_buffer_in_windows.
8360 (replace_buffer_in_all_windows): Remove with some functionality
8361 moved into replace_buffer_in_windows_safely.
8362 (replace_buffer_in_windows_safely): New function.
8363 (select_window_norecord, select_frame_norecord): Move in front
8364 of run_window_configuration_change_hook. Remove now obsolete
8365 declarations.
640c8776
SM
8366 (Fset_window_buffer): Rewrite doc-string.
8367 Call Qrecord_window_buffer.
9397e56f
MR
8368 (keys_of_window): Move binding for other-window to window.el.
8369
b50691aa
CY
83702011-06-11 Chong Yidong <cyd@stupidchicken.com>
8371
8372 * dispextern.h (struct image): Replace data member, whose int_val
8373 and ptr_val fields were not used by anything, with a single
8374 lisp_val object.
8375
8376 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8377 (gif_clear_image, gif_load, imagemagick_load_image)
8378 (gs_clear_image, gs_load): Callers changed.
8379
3f754b86
PE
83802011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8381
cca69397
PE
8382 * buffer.h: Include <time.h>, for time_t.
8383 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8384
109e28d0
PE
8385 Fix minor problems found by static checking.
8386
60737f02
PE
8387 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8388
4b66faf3
PE
8389 Make identifiers static if they are not used in other modules.
8390 * data.c (Qcompiled_function, Qframe, Qvector):
8391 * image.c (QimageMagick, Qsvg):
8392 * minibuf.c (Qmetadata):
8393 * window.c (resize_window_check, resize_root_window): Now static.
8394 * window.h (resize_window_check, resize_root_window): Remove decls.
8395
109e28d0
PE
8396 * window.c (window_deletion_count, delete_deletable_window):
8397 Remove; unused.
46a4ce9e
PE
8398 (window_body_lines): Now static.
8399 (Fdelete_other_windows_internal): Mark vars as initialized.
8400 Make sure 'resize_failed' is initialized.
8401 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8402 (resize_window_apply): Remove unused local.
8403 * window.h (delete_deletable_window): Remove decl.
8404
109e28d0 8405 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8406 (imagemagick_load_image): Fix pointer signedness problem by changing
8407 last arg from unsigned char * to char *. All uses changed.
8408 Also, fix a local for similar reasons.
8409 Remove unused locals. Remove locals to avoid shadowing.
8410 (fn_rsvg_handle_free): Remove; unused.
8411 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8412 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8413
3f754b86
PE
8414 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8415
2547adb1
CY
84162011-06-10 Chong Yidong <cyd@stupidchicken.com>
8417
8418 * image.c (gif_load): Fix omitted cast error introduced by
8419 2011-06-06 change.
8420
2c8e37d4
MR
84212011-06-10 Martin Rudalics <rudalics@gmx.at>
8422
8423 * window.h (resize_proportionally, orig_total_lines)
8424 (orig_top_line): Remove from window structure.
8425 (set_window_height, set_window_width, change_window_heights)
8426 (Fdelete_window): Remove prototypes.
8427 (resize_frame_windows): Remove duplicate declaration.
8428
440a42e3
EZ
84292011-06-10 Eli Zaretskii <eliz@gnu.org>
8430
8431 * window.h (resize_frame_windows, resize_window_check)
8432 (delete_deletable_window, resize_root_window)
8433 (resize_frame_windows): Declare prototypes.
8434
8435 * window.c (resize_window_apply): Make definition be "static" to
8436 match the prototype.
8437
562dd5e9
MR
84382011-06-10 Martin Rudalics <rudalics@gmx.at>
8439
8440 * window.c: Remove declarations of Qwindow_size_fixed,
8441 window_min_size_1, window_min_size_2, window_min_size,
8442 size_window, window_fixed_size_p, enlarge_window, delete_window.
8443 Remove static from declaration of Qdelete_window, it's
8444 temporarily needed by Fbury_buffer.
8445 (replace_window): Don't assign orig_top_line and
8446 orig_total_lines.
8447 (Fdelete_window, delete_window): Remove. Window deletion is
8448 handled by window.el.
640c8776
SM
8449 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8450 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8451 (Fdelete_other_windows): Remove. Deleting other windows is
8452 handled by window.el.
8453 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8454 handled in window.el.
8455 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8456 Window minimum sizes are handled in window.el.
8457 (shrink_windows, size_window, set_window_height)
8458 (set_window_width, change_window_heights, window_height)
8459 (window_width, CURBEG, CURSIZE, enlarge_window)
8460 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8461 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8462 handled in window.el.
8463 (make_dummy_parent): Rename to make_parent_window and give it a
8464 second argument horflag.
8465 (make_window): Don't set resize_proportionally any more.
8466 (Fsplit_window): Remove. Windows are split in window.el.
8467 (save_restore_action, save_restore_orig_size)
8468 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8469 Resize mini windows in window.el.
8470 (grow_mini_window, shrink_mini_window): Implement by calling
8471 Qresize_root_window_vertically, resize_window_check and
8472 resize_window_apply.
640c8776
SM
8473 (saved_window, Fset_window_configuration, save_window_save):
8474 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8475 resize_proportionally.
8476 (window_min_height, window_min_width): Move to window.el.
8477 (keys_of_window): Move bindings for delete-other-windows,
8478 split-window, delete-window and enlarge-window to window.el.
8479
8480 * buffer.c: Temporarily extern Qdelete_window.
8481 (Fbury_buffer): Temporarily call Qdelete_window instead of
8482 Fdelete_window (Fbury_buffer will move to window.el soon).
8483
8484 * frame.c (set_menu_bar_lines_1): Remove code handling
8485 orig_top_line and orig_total_lines.
8486
8487 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8488 set_window_height but set heights directly.
8489 (change_frame_size_1): Use resize_frame_windows.
8490
8491 * xdisp.c (init_xdisp): Don't use set_window_height but set
8492 heights directly.
8493
640c8776
SM
8494 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8495 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8496 run_window_configuration_change_hook.
8497
8498 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8499 instead of change_window_heights and run
8500 run_window_configuration_change_hook.
8501
1a13852e
MR
85022011-06-09 Martin Rudalics <rudalics@gmx.at>
8503
8504 * window.c (replace_window): Rename second argument REPLACEMENT to
8505 NEW. New third argument SETFLAG. Rewrite.
8506 (delete_window, make_dummy_parent): Call replace_window with
8507 third argument 1.
8508 (window_list_1): Move down in code.
8509 (run_window_configuration_change_hook): Move set_buffer part
8510 before select_frame_norecord part in order to unwind correctly.
8511 Rename count1 to count.
8512 (recombine_windows, delete_deletable_window, resize_root_window)
8513 (Fdelete_other_windows_internal)
8514 (Frun_window_configuration_change_hook, make_parent_window)
8515 (resize_window_check, resize_window_apply, Fresize_window_apply)
8516 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8517 (Fdelete_window_internal, Fresize_mini_window_internal):
8518 New functions.
1a13852e
MR
8519 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8520
f3d1777e
MR
85212011-06-08 Martin Rudalics <rudalics@gmx.at>
8522
496e208e
MR
8523 * window.h (window): Add some new members to window structure -
8524 normal_lines, normal_cols, new_total, new_normal, clone_number,
8525 splits, nest, prev_buffers, next_buffers.
8526 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8527 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8528
f3d1777e
MR
8529 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8530 Remove.
496e208e
MR
8531 (make_dummy_parent): Set new members of windows structure.
8532 (make_window): Move down in code. Handle new members of window
8533 structure.
8534 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8535 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8536 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8537 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8538 (Fset_window_next_buffers, Fset_window_clone_number):
8539 New functions.
496e208e
MR
8540 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8541 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8542 Doc-string fixes.
8543 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8544 Argument WINDOW can be now internal window too.
8545 (Fwindow_use_time): Move up in code.
8546 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8547 Rewrite doc-string.
8548 (Fset_window_configuration, saved_window)
8549 (Fcurrent_window_configuration, save_window_save): Handle new
8550 members of window structure.
b9e809c2
MR
8551 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8552 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8553 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8554 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8555 Qget_mru_window, Qresize_root_window,
8556 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8557 Qauto_buffer_name; staticpro them.
f3d1777e 8558
abde8f8c
MR
85592011-06-07 Martin Rudalics <rudalics@gmx.at>
8560
8561 * window.c (Fwindow_total_size, Fwindow_left_column)
8562 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8563 (Fwindow_list_1): New functions.
8564 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8565 (Fwindow_width, Fscroll_left, Fscroll_right):
8566 Use window_body_cols instead of window_box_text_cols.
8567 (delete_window, Fset_window_configuration):
8568 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8569 (delete_all_subwindows): Take a window as argument and not a
8570 structure. Rewrite.
190b47e6
MR
8571 (window_loop): Remove handling of GET_LRU_WINDOW and
8572 GET_LARGEST_WINDOW.
8573 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8574
8575 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8576 window_box_text_cols. delete_all_subwindows now takes a
8577 Lisp_Object as argument.
abde8f8c 8578
640c8776
SM
8579 * indent.c (compute_motion, Fcompute_motion):
8580 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8581
fa8a67e6
MR
8582 * frame.c (delete_frame): Call delete_all_subwindows with root
8583 window as argument.
8584
a54e3482
DC
85852011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8586
8587 * fns.c (Fputhash): Document return value.
8588
60002bf5
CY
85892011-06-06 Chong Yidong <cyd@stupidchicken.com>
8590
8591 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8592
0c671da6 85932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8594
b862a52a 8595 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8596
be44ca6c
PE
8597 Check for overflow when converting integer to cons and back.
8598 * charset.c (Fdefine_charset_internal, Fdecode_char):
8599 Use cons_to_unsigned to catch overflow.
8600 (Fencode_char): Use INTEGER_TO_CONS.
8601 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8602 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8603 * data.c (long_to_cons, cons_to_long): Remove.
8604 (cons_to_unsigned, cons_to_signed): New functions.
8605 These signal an error for invalid or out-of-range values.
8606 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8607 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8608 * font.c (Ffont_variation_glyphs):
8609 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8610 * lisp.h: Include <intprops.h>.
8611 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8612 (cons_to_signed, cons_to_unsigned): New decls.
8613 (long_to_cons, cons_to_long): Remove decls.
8614 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8615 (Fprimitive_undo): Use CONS_TO_INTEGER.
8616 * xfns.c (Fx_window_property): Likewise.
8617 * xselect.c: Include <limits.h>.
8618 (x_own_selection, selection_data_to_lisp_data):
8619 Use INTEGER_TO_CONS.
8620 (x_handle_selection_request, x_handle_selection_clear)
8621 (x_get_foreign_selection, Fx_disown_selection_internal)
8622 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8623 (lisp_data_to_selection_data): Use cons_to_unsigned.
8624 (x_fill_property_data): Use cons_to_signed.
8625 Report values out of range.
8626
d1f3d2af
PE
8627 Check for buffer and string overflow more precisely.
8628 * buffer.h (BUF_BYTES_MAX): New macro.
8629 * lisp.h (STRING_BYTES_MAX): New macro.
8630 * alloc.c (Fmake_string):
8631 * character.c (string_escape_byte8):
8632 * coding.c (coding_alloc_by_realloc):
8633 * doprnt.c (doprnt):
8634 * editfns.c (Fformat):
8635 * eval.c (verror):
8636 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8637 since they may not be the same number.
8638 * editfns.c (Finsert_char):
8639 * fileio.c (Finsert_file_contents):
8640 Likewise for BUF_BYTES_MAX.
8641
dd52fcea
PE
8642 * image.c: Use ptrdiff_t, not int, for sizes.
8643 (slurp_file): Switch from int to ptrdiff_t.
8644 All uses changed.
8645 (slurp_file): Check that file size fits in both size_t (for
8646 malloc) and ptrdiff_t (for sanity and safety).
8647
7f9bbdbb
PE
8648 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8649 if b->modtime has its maximal value.
8650
dfe18f82
PE
8651 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8652
84acfcf0
PE
8653 Don't assume time_t can fit into int.
8654 * buffer.h (struct buffer.modtime): Now time_t, not int.
8655 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8656 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8657
ccd9a01a
PE
8658 Minor fixes for signed vs unsigned integers.
8659 * character.h (MAYBE_UNIFY_CHAR):
8660 * charset.c (maybe_unify_char):
8661 * keyboard.c (read_char, reorder_modifiers):
8662 XINT -> XFASTINT, since the integer must be nonnegative.
8663 * ftfont.c (ftfont_spec_pattern):
8664 * keymap.c (access_keymap, silly_event_symbol_error):
8665 XUINT -> XFASTINT, since the integer must be nonnegative.
8666 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8667 since it makes no difference and we prefer signed.
8668 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8669 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8670 nonnegative.
8671
d6d100dd
SM
86722011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8673
8674 * window.h (Fwindow_frame): Declare.
8675
2b6148e4
PE
86762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8677
8678 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8679 (SPARE_MEMORY): Always define.
8680 (LARGE_REQUEST): Remove.
8681 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8682
f230ecc9
MR
86832011-06-06 Martin Rudalics <rudalics@gmx.at>
8684
727e958e
MR
8685 * lisp.h: Move EXFUNS for Fframe_root_window,
8686 Fframe_first_window and Fset_frame_selected_window to window.h.
8687
8688 * window.h: Move EXFUNS for Fframe_root_window,
8689 Fframe_first_window and Fset_frame_selected_window here from
8690 lisp.h.
8691
8692 * frame.c (Fwindow_frame, Fframe_first_window)
8693 (Fframe_root_window, Fframe_selected_window)
8694 (Fset_frame_selected_window): Move to window.c.
8695 (Factive_minibuffer_window): Move to minibuf.c.
8696 (Fother_visible_frames_p): New function.
8697
8698 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8699
f230ecc9
MR
8700 * window.c (decode_window, decode_any_window): Move up in code.
8701 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8702 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8703 (Fwindow_buffer): Move up and rewrite doc-string.
8704 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8705 (Fwindow_prev): New functions.
727e958e
MR
8706 (Fwindow_frame): Move here from frame.c. Accept any window as
8707 argument.
8708 (Fframe_root_window, Fframe_first_window)
8709 (Fframe_selected_window): Move here from frame.c. Accept frame
8710 or arbitrary window as argument. Update doc-strings.
8711 (Fminibuffer_window): Move up in code.
8712 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8713 (Fset_frame_selected_window): Move here from frame.c.
8714 Marginal rewrite.
727e958e
MR
8715 (Fselected_window, select_window, Fselect_window): Move up in
8716 code. Minor doc-string fixes.
f230ecc9 8717
4d09bcf6
PE
87182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8719
8720 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8721 Do not assume that spare memory exists; that assumption is valid
8722 only if SYSTEM_MALLOC.
8723 (LARGE_REQUEST): New macro, so that the issue of large requests
8724 is separated from the issue of spare memory.
8725
810928a2
AS
87262011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8727
172418ad
AS
8728 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8729 format. (Bug#8806)
8730
43f862f7
AS
8731 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8732
810928a2
AS
8733 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8734 before statements.
8735
a059fe24
JD
87362011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8737
8738 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8739
8740 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8741
8742 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8743 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8744
989bf368
JB
87452011-06-05 Juanma Barranquero <lekktu@gmail.com>
8746
8747 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8748
4b80f674
CY
87492011-06-04 Chong Yidong <cyd@stupidchicken.com>
8750
8751 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8752 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8753 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8754 New error handlers.
4b80f674
CY
8755 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8756 Obey Vx_select_enable_clipboard_manager. Catch errors in
8757 x_clipboard_manager_save (Bug#8779).
8758 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8759 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8760
99a33b77 87612011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8762
8763 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8764
99a33b77 87652011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8766
8767 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8768 in the current matrix if keep_current_p is non-zero.
8769
8264569d
EZ
87702011-06-04 Eli Zaretskii <eliz@gnu.org>
8771
8772 * bidi.c (bidi_level_of_next_char): Fix last change.
8773
57f97249
EZ
87742011-06-03 Eli Zaretskii <eliz@gnu.org>
8775
fec2107c 8776 Support bidi reordering of text covered by display properties.
57f97249 8777
fec2107c
EZ
8778 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8779 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8780 (bidi_cache_search, bidi_cache_iterator_state)
8781 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8782 (bidi_level_of_next_char, bidi_move_to_visually_next):
8783 Support character positions inside a run of characters covered by a
fec2107c
EZ
8784 display string.
8785 (bidi_paragraph_init, bidi_resolve_explicit_1)
8786 (bidi_level_of_next_char): Call bidi_fetch_char and
8787 bidi_fetch_char_advance instead of FETCH_CHAR and
8788 FETCH_CHAR_ADVANCE.
8789 (bidi_init_it): Initialize new members.
8790 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8791 definitions.
8792 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8793 instead of using explicit *_CHAR codes.
d6d100dd
SM
8794 (bidi_resolve_explicit, bidi_resolve_weak):
8795 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8796 bidirectional text is supported only in multibyte buffers.
8797 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8798 it to initialize the frame_window_p member of struct bidi_it.
8799 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8800 (bidi_resolve_explicit, bidi_resolve_weak)
8801 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8802 bidi_it->nchars is non-positive.
8803 (bidi_level_of_next_char): Don't try to lookup the cache for the
8804 next/previous character if nothing is cached there yet, or if we
8805 were just reseat()'ed to a new position.
c40e2fb2 8806
0e14fe90
EZ
8807 * xdisp.c (set_cursor_from_row): Set start and stop points
8808 according to the row's direction when priming the loop that looks
8809 for the glyph on which to display cursor.
8810 (single_display_spec_intangible_p): Function deleted.
8811 (display_prop_intangible_p): Reimplement to call
8812 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8813 Accept 3 additional arguments needed by handle_display_spec.
8814 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8815 values: lists, `(when COND...)' forms, etc.
8816 (single_display_spec_string_p): Support property values that are
8817 lists with the argument STRING its top-level element.
8818 (display_prop_string_p): Fix the condition for processing a
8819 property that is a list to be consistent with handle_display_spec.
fec2107c 8820 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8821 last portion of handle_display_prop.
8822 (compute_display_string_pos): Accept additional argument
8823 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8824 value of a `display' property is a "replacing spec".
8825 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8826 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8827 the display property, but just return a value indicating whether
8828 the display property will replace the characters it covers.
8829 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8830 frame_window_p members of struct bidi_it.
d6d100dd
SM
8831 (compute_display_string_pos, compute_display_string_end):
8832 New functions.
fec2107c
EZ
8833 (push_it): Accept second argument POSITION, where pop_it should
8834 jump to continue iteration.
8835 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8836
fec2107c
EZ
8837 * keyboard.c (adjust_point_for_property): Adjust the call to
8838 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8839
8840 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8841 (bidi_init_it): Update prototypes.
8842 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8843 (compute_display_string_pos, compute_display_string_end):
8844 Declare prototypes.
fec2107c
EZ
8845 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8846 EMACS_INT.
fc6f18ce 8847
40087514 88482011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8849
57f53182
PE
8850 Malloc failure behavior now depends on size of allocation.
8851 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8852 * lisp.h: Change signatures accordingly.
8853 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8854 All callers changed. (Bug#8762)
8855
8856 * gnutls.c: Use Emacs's memory allocators.
8857 Without this change, the gnutls library would invoke malloc etc.
8858 directly, which causes problems on non-SYNC_INPUT hosts, and which
8859 runs afoul of improving memory_full behavior. (Bug#8761)
8860 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8861 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8862 xfree instead of the default malloc, realloc, free.
8863 (Fgnutls_boot): No need to check for memory allocation failure,
8864 since xmalloc does that for us.
8865
ac32cd99 8866 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8867 * category.c (hash_get_category_set):
8868 * ccl.c (ccl_driver):
8869 * charset.c (Fdefine_charset_internal):
8870 * charset.h (struct charset.hash_index):
8871 * composite.c (get_composition_id, gstring_lookup_cache)
8872 (composition_gstring_put_cache):
8873 * composite.h (struct composition.hash_index):
8874 * dispextern.h (struct image.hash):
8875 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8876 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8877 (hashfn_equal, hashfn_user_defined, make_hash_table)
8878 (maybe_resize_hash_table, hash_lookup, hash_put)
8879 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8880 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8881 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8882 * image.c (make_image, search_image_cache, lookup_image)
8883 (xpm_put_color_table_h):
8884 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8885 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8886 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8887 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8888 * alloc.c (allocate_vectorlike):
8889 Check for overflow in vector size calculations.
8890 * ccl.c (ccl_driver):
8891 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8892 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8893 need to be updated by these changes.
40087514
PE
8894 * fns.c (make_hash_table, maybe_resize_hash_table):
8895 Check for integer overflow with large hash tables.
0de4bb68
PE
8896 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8897 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8898 (SXHASH_REDUCE): New macro.
8899 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8900 Use it instead of discarding useful hash info with large hash values.
8901 (sxhash_float): New function.
8902 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8903 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8904 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8905 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8906 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8907 Adjust signatures to match updated version of code.
8908 (consing_since_gc): Now EMACS_INT, since a single hash table can
8909 use more than INT_MAX bytes.
8910
698d32e2
DN
89112011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8912
8913 Make it possible to build with GCC-4.6+ -O2 -flto.
8914
8915 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8916
fd6fa53f
SM
89172011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8918
8919 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8920 Call minibuffer-inactive-mode.
8921
864db017
JB
89222011-05-31 Juanma Barranquero <lekktu@gmail.com>
8923
8924 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8925 Update dependencies.
8926
2ad0baf4
DN
89272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8928
8929 * data.c (init_data): Remove code for UTS, this system is not
8930 supported anymore.
8931
4fcc2638
DN
89322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8933
8934 Don't force ./temacs to start in terminal mode.
8935
8936 * frame.c (make_initial_frame): Initialize faces in all cases, not
8937 only when CANNOT_DUMP is defined.
8938 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8939
c56e0fd5
DN
89402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8941
8942 * dispnew.c (add_window_display_history): Use const for the string
8943 pointer. Remove declaration, not needed.
8944
333d54da 89452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8946
55d4c1b2 8947 Use 'inline', not 'INLINE'.
333d54da 8948 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8949 * alloc.c, fontset.c (INLINE): Remove.
8950 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8951 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8952 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8953 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8954 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8955
738db178
DN
89562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8957
8958 Make it possible to run ./temacs.
8959
8960 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8961 syms_of_callproc does the same thing. Remove test for
8962 "initialized", do it in the caller.
8963 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8964
620c53a6
SM
89652011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8966
8967 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8968 (read_minibuf): Use get_minibuffer.
8969 (syms_of_minibuf): Use DEFSYM.
8970 (Qmetadata): New var.
8971 * data.c (Qbuffer): Don't make it static.
8972 (syms_of_data): Use DEFSYM.
8973
e003a292
PE
89742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8975
8976 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8977 (CCL_CODE_MIN): New macro.
8978
ed008a6d
PE
89792011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8980
3687c2ef
PE
8981 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8982
ed008a6d
PE
8983 * eval.c (Qdebug): Now static.
8984 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8985 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8986 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8987
d66c4c7c
CY
89882011-05-29 Chong Yidong <cyd@stupidchicken.com>
8989
8990 * image.c: Various fixes to ImageMagick code comments.
8991 (Fimagemagick_types): Doc fix.
8992
5fbc2025
PE
89932011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8994
0196f88a
PE
8995 Minor fixes prompted by GCC 4.6.0 warnings.
8996
8997 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8998
5fbc2025
PE
8999 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9000 (x_clipboard_manager_save_all): Move extern decl to ...
9001 * xterm.h: ... here, so that it can be checked for consistency.
9002
1dd3c2d9
CY
90032011-05-29 Chong Yidong <cyd@stupidchicken.com>
9004
9005 * xselect.c (x_clipboard_manager_save_frame)
9006 (x_clipboard_manager_save_all): New functions.
9007 (Fx_clipboard_manager_save): Lisp function deleted.
9008
9009 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9010 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9011
9012 * xterm.h: Update prototype.
9013
5ba6571d
WX
90142011-05-28 William Xu <william.xwl@gmail.com>
9015
9016 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9017 exiting (Bug#8239).
9018
3eaff834
JM
90192011-05-28 Jim Meyering <meyering@redhat.com>
9020
e1900994 9021 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9022 * fns.c (to_uchar): Define.
9023 (crypto_hash_function): Use it to convert some newly-signed
9024 variables to unsigned, to avoid sign-extension bugs. For example,
9025 without this change, (md5 "truc") would evaluate to
9026 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9027 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9028 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9029
0f6990a7
PE
90302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9031
9032 Integer overflow fixes.
c8a9ca5a 9033
08686060
PE
9034 * dbusbind.c: Serial number integer overflow fixes.
9035 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9036 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9037 to hold a serial number that is too large for a fixnum.
9038 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9039 Check for serial numbers out of range. Decode any serial number
59568bf0 9040 that was so large that it became a float. (Bug#8722)
08686060 9041
2d1fc3c7
PE
9042 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9043 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9044 Use XFASTINT rather than XUINT when numbers are nonnegative.
9045 (xd_append_arg, Fdbus_method_return_internal):
9046 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9047 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9048 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9049 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9050 (Bug#8722)
2d1fc3c7 9051
c8a9ca5a
PE
9052 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9053
519e1d69
PE
9054 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9055
6df6ae42 9056 ccl: Add integer overflow checks.
30569699
PE
9057 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9058 (IN_INT_RANGE): New macros.
9059 (ccl_driver): Use them to check for integer overflow when
9060 decoding a CCL program. Many of the new checks are whether XINT (x)
9061 fits in int; it doesn't always, on 64-bit hosts. The new version
9062 doesn't catch all possible integer overflows, but it's an
847044ea 9063 improvement. (Bug#8719)
30569699 9064
c11285dc
PE
9065 * alloc.c (make_event_array): Use XINT, not XUINT.
9066 There's no need for unsigned here.
9067
fdccd48e
PE
9068 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9069 This follows up to the 2011-05-06 change that substituted uintptr_t
9070 for EMACS_INT. This case wasn't caught back then.
9071
37910ab2
PE
9072 Rework Fformat to avoid integer overflow issues.
9073 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9074 now (part of C89). Include <verify.h>.
9075 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9076 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9077 (Fformat): Avoid the prepass trying to compute sizes; it was only
9078 approximate and thus did not catch overflow reliably. Instead, walk
9079 through the format just once, formatting and computing sizes as we go,
9080 checking for integer overflow at every step, and allocating a larger
9081 buffer as needed. Keep track separately whether the format is
9082 multibyte. Keep only the most-recently calculated precision, rather
9083 than them all. Record whether each argument has been converted to
9084 string. Use EMACS_INT, not int, for byte and char and arg counts.
9085 Support field widths and precisions larger than INT_MAX. Avoid
9086 sprintf's undefined behavior with conversion specifications such as %#d
9087 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9088 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9089 formatting out-of-range floating point numbers with int
9173deec 9090 formats. (Bug#8668)
37910ab2 9091
2e6578fb
PE
9092 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9093
0ae6bdee
PE
9094 * data.c: Avoid integer truncation in expressions involving floats.
9095 * data.c: Include <intprops.h>.
9096 (arith_driver): When there's an integer overflow in an expression
9097 involving floating point, convert the integers to floating point
9098 so that the resulting value does not suffer from catastrophic
9099 integer truncation. For example, on a 64-bit host (* 4
9100 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9101 Do not rely on undefined behavior after integer overflow.
9102
de883a70
PE
9103 merge count_size_as_multibyte, parse_str_to_multibyte
9104 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9105 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9106 Check for integer overflow.
9107 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9108 since it's now a duplicate of the other. This is more of
9109 a character than a buffer op, so better that it's in character.c.
9110 * fns.c, print.c: Adjust to above changes.
9111
2ff916cb
PE
91122011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9113
9114 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9115
f1b54466
PE
91162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9117
fb1ac845
PE
9118 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9119 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9120 (x_clipboard_manager_save): Now static.
9121 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9122
f1b54466
PE
9123 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9124 (crypto_hash_function): Now static.
9125 Fix pointer signedness problems. Avoid unnecessary initializations.
9126
a9f737ee
CY
91272011-05-27 Chong Yidong <cyd@stupidchicken.com>
9128
9129 * termhooks.h (Vselection_alist): Make it terminal-local.
9130
9131 * terminal.c (create_terminal): Initialize it.
9132
9133 * xselect.c: Support for clipboard managers.
9134 (Vselection_alist): Move to termhooks.h as terminal-local var.
9135 (LOCAL_SELECTION): New macro.
9136 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9137 (symbol_to_x_atom): Remove gratuitous arg.
9138 (x_handle_selection_request, lisp_data_to_selection_data)
9139 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9140 (x_own_selection, x_get_local_selection, x_convert_selection):
9141 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9142 (some_frame_on_display): Delete unused function.
9143 (Fx_own_selection_internal, Fx_get_selection_internal)
9144 (Fx_disown_selection_internal, Fx_selection_owner_p)
9145 (Fx_selection_exists_p): New optional frame arg.
9146 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9147 (x_handle_selection_clear): Don't treat other terminals with the
9148 same keyboard specially. Use the terminal-local Vselection_alist.
9149 (x_clear_frame_selections): Use Frun_hook_with_args.
9150
9151 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9152
9153 * xterm.h: Add support for those atoms.
9154
e067f0c1
CY
91552011-05-26 Chong Yidong <cyd@stupidchicken.com>
9156
9157 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9158 (converted_selections, conversion_fail_tag): New global variables.
9159 (x_selection_request_lisp_error): Free the above.
9160 (x_get_local_selection): Remove unnecessary code.
9161 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9162 of converted selections stored in converted_selections.
9163 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9164 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9165 (x_convert_selection): New function.
9166 (x_handle_selection_event): Simplify.
9167 (x_get_foreign_selection): Don't ignore incoming requests while
9168 waiting for an answer; this will fail when we implement
9169 SAVE_TARGETS, and seems unnecessary anyway.
9170 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9171 (Vx_sent_selection_functions): Doc fix.
9172
0f4aebc0
LL
91732011-05-26 Leo Liu <sdl.web@gmail.com>
9174
9175 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9176
e61124cd
YM
91772011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9178
9179 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9180
9181 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9182 for fringe update if it has periodic bitmap.
ac389d0c 9183 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9184 and fringe_bitmap_periodic_p.
9185
9186 * fringe.c (get_fringe_bitmap_data): New function.
9187 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9188 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9189 row. Mark glyph row for fringe update if periodicity changed.
9190
9191 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9192 for fringe update unless it has periodic bitmap.
9193
f16d9837
KH
91942011-05-25 Kenichi Handa <handa@m17n.org>
9195
9196 * xdisp.c (get_next_display_element): Set correct it->face_id for
9197 a static composition.
9198
e1b90ef6
LL
91992011-05-24 Leo Liu <sdl.web@gmail.com>
9200
9201 * deps.mk (fns.o):
9202 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9203
9204 * fns.c (crypto_hash_function, Fsha1): New function.
9205 (Fmd5): Use crypto_hash_function.
9206 (syms_of_fns): Add Ssha1.
9207
7400048f
PE
92082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9209
9210 * gnutls.c: Remove unused macros.
9211 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9212 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9213 Remove macros that are defined and never used.
9214 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9215
abb71cf4
CY
92162011-05-22 Chong Yidong <cyd@stupidchicken.com>
9217
9218 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9219 (Fx_get_selection_internal): Minor cleanup.
9220 (Fx_own_selection_internal): Rename arguments for consistency with
9221 select.el.
9222
6307db39
PE
92232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9224
9225 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9226
f3d4e0a4
CY
92272011-05-22 Chong Yidong <cyd@stupidchicken.com>
9228
9229 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9230
4d8ade89
YM
92312011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9232
9233 * dispnew.c (scrolling_window): Don't exclude the case that the
9234 last enabled row in the desired matrix touches the bottom boundary.
9235
32078c8d
GM
92362011-05-21 Glenn Morris <rgm@gnu.org>
9237
9238 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9239 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9240 and add some more files.
32078c8d 9241
7285dc67
EZ
92422011-05-20 Eli Zaretskii <eliz@gnu.org>
9243
9244 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9245 report_file_error introduced by the change from 2011-05-07.
9246
89d1bd22
PE
92472011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9248
9249 * systime.h (Time): Define only if emacs is defined.
9250 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9251 where the include path doesn't have X11/X.h by default. See
9252 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9253
cd394be1 92542011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9255
9256 * composite.c (find_automatic_composition): Fix previous change.
9257
b9704ad9
GM
92582011-05-20 Glenn Morris <rgm@gnu.org>
9259
9260 * lisp.mk: New file, split from Makefile.in.
9261 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9262 (shortlisp): Remove.
9263 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9264
4a720484
GM
92652011-05-19 Glenn Morris <rgm@gnu.org>
9266
9267 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9268 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9269 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9270 (lisp): Set the order to that of loadup.el.
9271 (shortlisp): Make it a copy of $lisp.
9272 (SOME_MACHINE_LISP): Remove.
9273 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9274 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9275
a28d4396
KH
92762011-05-18 Kenichi Handa <handa@m17n.org>
9277
9278 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9279 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9280 (find_automatic_composition): Mostly rewrite for efficiency.
9281
a2b1fa8e
JB
92822011-05-18 Juanma Barranquero <lekktu@gmail.com>
9283
9284 * makefile.w32-in: Update dependencies.
9285
8e1f5610
CS
92862011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9287
9288 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9289 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9290
7025ee00 92912011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9292
cdfa6eab
PE
9293 Fix some integer overflow issues, such as string length overflow.
9294
06d6db33
PE
9295 * insdel.c (count_size_as_multibyte): Check for string overflow.
9296
2b4560a8
PE
9297 * character.c (lisp_string_width): Check for string overflow.
9298 Use EMACS_INT, not int, for string indexes and lengths; in
9299 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9300 the resulting string length overflows an EMACS_INT; instead,
9301 report a string overflow if no precision given. When checking for
9302 precision exhaustion, use a check that cannot possibly have
9303 integer overflow. (Bug#8675)
9304 * character.h (lisp_string_width): Adjust to new signature.
9305
cb93f9be
PE
9306 * alloc.c (string_overflow): New function.
9307 (Fmake_string): Use it. This doesn't change behavior, but saves
9308 a few bytes and will simplify future changes.
9309 * character.c (string_escape_byte8): Likewise.
9310 * lisp.h (string_overflow): New decl.
9311
1a1f3366
PE
9312 Fixups, following up to the user-interface timestamp change.
9313 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9314 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9315 * msdos.c (mouse_get_pos): Likewise.
9316 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9317 * w32gui.h (Time): Define by including "systime.h" rather than by
9318 declaring it ourselves. (Bug#8664)
9319
d4e3e4d3
PE
9320 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9321 * image.c (clear_image_cache): Likewise.
9322
f6a24d19
PE
9323 * term.c (term_mouse_position): Don't assume time_t wraparound.
9324
08dc5ae6
PE
9325 Be more systematic about user-interface timestamps.
9326 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9327 and sometimes 'EMACS_UINT', to represent these timestamps.
9328 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9329 This makes the code easier to follow, and makes it easier to catch
9330 integer overflow bugs such as Bug#8664.
9331 * frame.c (Fmouse_position, Fmouse_pixel_position):
9332 Use Time, not unsigned long, for user-interface timestamps.
9333 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9334 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9335 * keyboard.h (last_event_timestamp): Likewise.
9336 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9337 * menu.h (xmenu_show): Likewise.
9338 * term.c (term_mouse_position): Likewise.
9339 * termhooks.h (struct input_event.timestamp): Likewise.
9340 (struct terminal.mouse_position_hook): Likewise.
9341 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9342 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9343 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9344 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9345 what it was before.
9346 * menu.h, termhooks.h: Include "systime.h", for Time.
9347
8e55734a
PE
9348 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9349 Don't assume that the difference between two unsigned long values
9350 can fit into an integer. At this point, we know button_down_time
9351 <= event->timestamp, so the difference must be nonnegative, so
9352 there's no need to cast the result if double-click-time is
9353 nonnegative, as it should be; check that it's nonnegative, just in
9354 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9355 apart (about 25 days). (Bug#8664)
8e55734a 9356
841f1b75 9357 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9358 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9359
3e26f69c
PE
9360 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9361 that always fit in int. Use a sentinel instead of a counter, to
9362 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9363 * frame.h (struct frame): Use int for menu_bar_items_used
9364 instead of EMACS_INT, since it always fits in int.
3e26f69c 9365
5cc152c0
PE
9366 * menu.c (grow_menu_items): Check for int overflow.
9367
d89eb65e
PE
9368 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9369
5235bd3e
PE
9370 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9371 Before, the code was not consistent. These values cannot exceed
9372 2**31 - 1 so there's no need to make them unsigned.
9373 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9374 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9375 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9376 as modifiers.
9377 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9378
bc827e23
PE
9379 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9380 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9381 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9382 presumably because the widths might not match.
9383
78eb494e
PE
9384 * window.c (size_window): Avoid needless test at loop start.
9385
04f2d78b
CB
93862011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9387
9388 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9389
d2fc7e3d 93902011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9391
9392 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9393
d2fc7e3d 93942011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9395
9396 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9397 `width' to `bar_area_x' and `bar_area_width', respectively.
9398 (x_scroll_run): Take account of fringe background extension.
9399
04f2d78b
CB
9400 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9401 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9402 `bar_area_width', respectively.
9403 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9404 background extension.
9405
79b70037
GM
94062011-05-10 Jim Meyering <meyering@redhat.com>
9407
9408 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9409
2f142cc5
JB
94102011-05-10 Juanma Barranquero <lekktu@gmail.com>
9411
9412 * image.c (Finit_image_library): Return t for built-in image types,
9413 like pbm and xbm. (Bug#8640)
9414
57679c86
AS
94152011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9416
9417 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9418
888c9e86
EZ
94192011-05-07 Eli Zaretskii <eliz@gnu.org>
9420
b0512a1d
EZ
9421 * w32console.c (Fset_screen_color): Doc fix.
9422 (Fget_screen_color): New function.
9423 (syms_of_ntterm): Defsubr it.
9424
7285dc67
EZ
9425 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9426 unlink the temporary file if Fcall_process didn't create it in the
9427 first place.
9428 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9429 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9430 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9431 cue to call_process_cleanup not to close that handle.
9432
4d3fcc8e
BK
94332011-05-07 Ben Key <bkey76@gmail.com>
9434
9435 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9436 one of two shell specific rules, either bootstrap-temacs-CMD or
9437 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9438 to the previous implementation of the bootstrap-temacs rule.
9439 The bootstrap-temacs-CMD rule is similar to the previous
9440 implementation of the bootstrap-temacs rule except that it
9441 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9442 variable.
9443
9444 These changes, along with some changes to nt/configure.bat,
9445 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9446 earlier fix to add support for --cflags and --ldflags options
9447 that include quotes so that it works whether make uses cmd or
9448 sh as the shell.
9449
b4289b64
MA
94502011-05-06 Michael Albinus <michael.albinus@gmx.de>
9451
9452 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9453 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9454 is a constant.
9455 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9456 a string. Handle both cases.
9457 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9458 (Fdbus_register_method): Use Qinvalid_function.
9459
af4c0e28
JB
94602011-05-06 Juanma Barranquero <lekktu@gmail.com>
9461
9462 * makefile.w32-in: Update dependencies.
9463 (LISP_H): Add inttypes.h and stdin.h.
9464 (PROCESS_H): Add unistd.h.
9465
c51453d9
EZ
94662011-05-06 Eli Zaretskii <eliz@gnu.org>
9467
9468 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9469 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9470
8ff0ac3c 94712011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9472
4c4b566b
PE
9473 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9474
aab2b9b5
PE
9475 * term.c (vfatal): Remove stray call to va_end.
9476 It's not needed and the C Standard doesn't allow it here anyway.
9477
c378da0b
PE
9478 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9479 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9480
288b08c7
PE
9481 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9482 bytes.
9483
e3601888
PE
9484 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9485
db6c0e74
PE
9486 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9487
dd5963ea
PE
9488 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9489
88c9450f
PE
9490 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9491
2f9442b8
PE
9492 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9493
c032b5f8
PE
9494 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9495 * charset.c (Fdefine_charset_internal): Don't initialize
9496 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9497 32-bit int (Bug#8600).
a108c10b
PE
9498
9499 * lread.c (read_integer): Be more consistent with string-to-number.
9500 Use string_to_number to do the actual conversion; this avoids
9501 rounding errors and fixes some other screwups. Without this fix,
9502 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9503 (digit_to_number): Move earlier, for benefit of read_integer.
9504 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9505 not a digit in any supported base. (Bug#8602)
a108c10b 9506
ad5f9eea
PE
9507 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9508
aec1708a
PE
9509 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9510 to match comment at start of function. This also removes a
9511 GCC warning about overflow in a 32+64-bit port.
9512
47be4ab5
PE
9513 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9514
371cac43
PE
9515 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9516 Reported by Stefan Monnier in
9517 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9518 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9519 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9520
d01a7826
PE
9521 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9522 (EMACS_UINTPTR): Likewise, with uintptr_t.
9523
7fd47d5c
PE
9524 * lisp.h: Prefer 64-bit EMACS_INT if available.
9525 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9526 on 32-bit hosts that have 64-bit int, so that they can access
9527 large files.
122b0c86
PE
9528 However, temporarily disable this change unless the temporary
9529 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9530
8727937b
PE
9531 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9532
8ac068ac
PE
9533 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9534 This removes an assumption that EMACS_INT and long are the same
9535 width as pointers. The assumption is true for Emacs porting targets
9536 now, but we want to make other targets possible.
9537 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9538 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9539 In the rest of the code, change types of integers that hold casted
9540 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9541 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9542 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9543 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9544 No need to cast type when ORing.
9545 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9546 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9547 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9548 assume EMACS_INT is the same width as char *.
9549 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9550 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9551 Remove no-longer-needed casts.
9552 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9553 (xg_tool_bar_help_callback, xg_make_tool_item):
9554 Use EMACS_INTPTR to hold an integer
9555 that will be cast to void *; this can avoid a GCC warning
9556 if EMACS_INT is not the same width as void *.
9557 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9558 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9559 (current_message_1, set_message_1):
9560 Use a local to convert to proper width without a cast.
9561 * xmenu.c (dialog_selection_callback): Likewise.
9562
ede49d71
PE
9563 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9564 Also, don't assume VALBITS / RAND_BITS is less than 5,
9565 and don't rely on undefined behavior when shifting a 1 left into
9566 the sign bit.
9567 * lisp.h (get_random): Change signature to match.
9568
2f30ecd0
PE
9569 * lread.c (hash_string): Use size_t, not int, for hash computation.
9570 Normally we prefer signed values; but hashing is special, because
9571 it's better to use unsigned division on hash table sizes so that
9572 the remainder is nonnegative. Also, size_t is the natural width
9573 for hashing into memory. The previous code used 'int', which doesn't
9574 retain enough info to hash well into very large tables.
9575 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9576
2a866e7b
PE
9577 * dbusbind.c: Don't possibly lose pointer info when converting.
9578 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9579 Use XPNTR rather than XHASH, so that the high-order bits of
9580 the pointer aren't lost when converting through void *.
9581
51639eac
PE
9582 * eval.c (Fautoload): Don't double-shift a pointer.
9583
92394119
PE
9584 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9585
dbdb9a7c
JB
95862011-05-06 Juanma Barranquero <lekktu@gmail.com>
9587
9588 * gnutls.c (DEF_GNUTLS_FN):
9589 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9590
db7a0b4f
AS
95912011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9592
9593 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9594 marker. (Bug#8610)
9595
cd394be1 95962011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9597
9598 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9599 New version that can reserve upto 2GB of heap space.
9600
f7ff1b0f 96012011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9602
9603 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9604
639c109b
TZ
96052011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9606
9607 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9608 `gnutls_certificate_set_x509_key_file'.
9609
d2127135
JB
96102011-05-05 Juanma Barranquero <lekktu@gmail.com>
9611
9612 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9613 Update dependencies.
9614
e968f4f3
JB
96152011-05-04 Juanma Barranquero <lekktu@gmail.com>
9616
9617 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9618 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9619 Remove unused parameter `fildes'.
9620 * process.c (read_process_output, send_process): Don't pass it.
9621
84d358f0
JB
96222011-05-04 Juanma Barranquero <lekktu@gmail.com>
9623
9624 Fix previous change: the library cache is defined in w32.c.
9625 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9626 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9627
0898ca10
JB
96282011-05-04 Juanma Barranquero <lekktu@gmail.com>
9629
9630 Implement dynamic loading of GnuTLS on Windows.
9631
9632 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9633 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9634 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9635 Declare.
9636
9637 * gnutls.c (Qgnutls_dll): Define.
9638 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9639 (gnutls_*): Declare function pointers.
9640 (init_gnutls_functions): New function to initialize function pointers.
9641 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9642 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9643 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9644 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9645 (emacs_gnutls_write, emacs_gnutls_read)
9646 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9647 (Fgnutls_available_p): New function.
9648 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9649 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9650 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9651
9652 * image.c: Include w32.h.
9653 (Vimage_type_cache): Delete.
9654 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9655 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9656 (w32_delayed_load): Move to w32.c.
9657
9658 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9659
9660 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9661 (w32_delayed_load): Move from image.c. When loading a library, record
9662 its filename in the :loaded-from property of the library id.
9663 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9664 Initialize and staticpro them.
9665 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9666
9667 * process.c: Include lisp.h before w32.h, not after.
9668 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9669 instead of gnutls_record_check_pending.
9670
9671 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9672
ff4de4aa
TZ
96732011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9674
9675 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9676 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9677 as passed in.
9678
abe95abb
JD
96792011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9680
9681 * xterm.c (x_set_frame_alpha): Do not set property on anything
9682 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9683
e16e55d4
JB
96842011-05-02 Juanma Barranquero <lekktu@gmail.com>
9685
9686 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9687
bafcf6a5
JB
96882011-05-02 Juanma Barranquero <lekktu@gmail.com>
9689
9690 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9691 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9692 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9693 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9694 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9695 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9696 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9697 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9698 (Qgnutls_bootprop_callbacks_verify): Make static.
9699
e7a6747f
AS
97002011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9701
19ed11ba
AS
9702 * callproc.c: Indentation fixup.
9703
e7a6747f 9704 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9705 (wait_for_termination, interruptible_wait_for_termination):
9706 Move after wait_for_termination_1.
e7a6747f 9707
1ef14cb4
LMI
97082011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9709
9710 * sysdep.c (interruptible_wait_for_termination): New function
9711 which is like wait_for_termination, but allows keyboard
9712 interruptions.
9713
9714 * callproc.c (Fcall_process): Add (:file "file") as an option for
9715 the STDOUT buffer.
9716 (Fcall_process_region): Ditto.
9717
330d880c
EZ
97182011-04-30 Eli Zaretskii <eliz@gnu.org>
9719
8db90b73
EZ
9720 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9721 rather than `XVECTOR (FOO)->size'.
9722
330d880c
EZ
9723 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9724 inttypes.h, as a gnulib replacement is used if it not available in
9725 system headers.
9726
15cbd324
EZ
97272011-04-21 Eli Zaretskii <eliz@gnu.org>
9728
9729 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9730 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9731 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9732
9733 * coding.c (coding_alloc_by_realloc): Error out if destination
9734 will grow beyond MOST_POSITIVE_FIXNUM.
9735 (decode_coding_emacs_mule): Abort if there isn't enough place in
9736 charbuf for the composition carryover bytes. Reserve an extra
9737 space for up to 2 characters produced in a loop.
9738 (decode_coding_iso_2022): Abort if there isn't enough place in
9739 charbuf for the composition carryover bytes.
9740
97412011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9742
ae940cca
EZ
9743 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9744 aborting when %lld or %lll format is passed.
9745 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9746 %llo or %llx format is passed. (Bug#8545)
9747
03ab8921
EZ
9748 * window.c (window_scroll_line_based): Use a marker instead of
9749 simple variables to record original value of point. (Bug#7952)
9750
afda1437
EZ
9751 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9752 produced by %s or %c overflows available buffer space. (Bug#8545)
9753
f76dee0c
PE
97542011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9755
9756 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9757 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9758
fdc5744d
JB
97592011-04-28 Juanma Barranquero <lekktu@gmail.com>
9760
9761 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9762
638f053a
JB
97632011-04-28 Juanma Barranquero <lekktu@gmail.com>
9764
9765 * keyboard.c (Qdelayed_warnings_hook): Define.
9766 (command_loop_1): Run `delayed-warnings-hook'
9767 if Vdelayed_warnings_list is non-nil.
9768 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9769 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9770
d178f871
EZ
97712011-04-28 Eli Zaretskii <eliz@gnu.org>
9772
9773 * doprnt.c (doprnt): Don't return value smaller than the buffer
9774 size if the message was truncated. (Bug#8545).
9775
b124fd93
JB
97762011-04-28 Juanma Barranquero <lekktu@gmail.com>
9777
9778 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9779 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9780
e810457d
PE
97812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9782
9783 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9784
ea51cceb
JB
97852011-04-27 Juanma Barranquero <lekktu@gmail.com>
9786
9787 * makefile.w32-in: Update dependencies.
9788
94dcfacf
EZ
97892011-04-27 Eli Zaretskii <eliz@gnu.org>
9790
9791 Improve `doprnt' and its usage. (Bug#8545)
9792 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9793 `format_end'. Remove support for %l as a conversion specifier.
9794 Don't use xrealloc. Improve diagnostics when the %l size modifier
9795 is used. Update the commentary.
9796
9797 * eval.c (verror): Simplify calculation of size_t.
9798
9799 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9800 messages.
9801
f61f41d7
PE
98022011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9803
9804 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9805 change.
9806
96fb4434
PE
98072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9808
9809 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9810 This makes this file independent of the recent pseudovector change.
9811
671875da 98122011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9813
69e9b5a3
PE
9814 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9815
b5f869a7 9816 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9817 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9818 Remove unused local.
c8926152 9819 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9820
841a1577 9821 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9822 GCC 4.6.0 optimizes based on type-based alias analysis.
9823 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9824 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9825 != &v->size, and therefore "v->size = 1; b->size = 2; return
9826 v->size;" must therefore return 1. This assumption is incorrect
9827 for Emacs, since it type-puns struct Lisp_Vector * with many other
9828 types. To fix this problem, this patch adds a new type struct
f904488f 9829 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9830 and pseudovectors, and helps optimizing compilers not get fooled
9831 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9832 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9833 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9834 the size member.
eab3844f
PE
9835 (XSETPVECTYPE): Rewrite in terms of new macro.
9836 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9837 This is a bit clearer, and further avoids the possibility of
9838 undesirable aliasing.
9839 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9840 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9841 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9842 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9843 (ASIZE): Now uses header.size rather than size.
9844 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9845 to avoid the hassle of writing XVECTOR (foo)->header.size.
9846 (struct vectorlike_header): New type.
eab3844f
PE
9847 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9848 object, to help avoid aliasing.
9849 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9850 (SUBRP): Likewise, since Lisp_Subr is a special case.
9851 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9852 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9853 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9854 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9855 changed to be "header.size" and "header.next".
9856 * buffer.h (struct buffer): Likewise.
9857 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9858 * frame.h (struct frame): Likewise.
9859 * process.h (struct Lisp_Process): Likewise.
9860 * termhooks.h (struct terminal): Likewise.
9861 * window.c (struct save_window_data, struct saved_window): Likewise.
9862 * window.h (struct window): Likewise.
9863 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9864 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9865 * buffer.c (init_buffer_once): Likewise.
9866 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9867 special case.
9868 * process.c (Fformat_network_address): Use local var for size,
9869 for brevity.
9870
0df1eac5
PE
9871 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9872
847ab9d1 9873 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9874 * data.c (atof): Remove decl; no longer used or needed.
9875 (digit_to_number): Move to lread.c.
9876 (Fstring_to_number): Use new string_to_number function, to be
9877 consistent with how the Lisp reader treats infinities and NaNs.
9878 Do not assume that floating-point numbers represent EMACS_INT
9879 without losing information; this is not true on most 64-bit hosts.
9880 Avoid double-rounding errors, by insisting on integers when
9881 parsing non-base-10 numbers, as the documentation specifies.
9882 * lisp.h (string_to_number): New decl, replacing ...
9883 (isfloat_string): Remove.
bc0a5c13 9884 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9885 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9886 appears to have been a coding error. Similarly, do not accept
9887 strings like +-1e0 as floating point numbers. Do not report
9888 overflow for integer overflows unless the base is not 10 which
9889 means we have no simple and reliable way to continue.
9890 Break out the floating-point parsing into a new
9891 function string_to_number, so that Fstring_to_number parses
9892 floating point numbers consistently with the Lisp reader.
04f2d78b 9893 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9894 (E_CHAR, EXP_INT): Remove, replacing with ...
9895 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9896 (string_to_number): New function, replacing isfloat_string.
9897 This function checks for valid syntax and produces the resulting
9898 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9899 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9900 so that overflow for non-base-10 numbers is reported only when
9901 there's no portable and simple way to convert to floating point.
452f4150 9902
67769ffc
PE
9903 * textprop.c (set_text_properties_1): Rewrite for clarity,
9904 and to avoid GCC warning about integer overflow.
9905
c20db43f
PE
9906 * intervals.h (struct interval): Use EMACS_INT for members
9907 where EMACS_UINT might cause problems. See
9908 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9909 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9910 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9911 All uses changed.
37aa2f85
PE
9912 (offset_intervals): Tell GCC not to worry about length overflow
9913 when negating a negative length.
c20db43f 9914
2538aa2f
PE
9915 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9916 (overrun_check_free): Likewise.
9917
f2d3008d
PE
9918 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9919 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9920 word size.
9921
ec8df744
PE
9922 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9923 (gnutls_make_error): Rename local to avoid shadowing.
9924 (gnutls_emacs_global_deinit): ifdef out; not used.
9925 (Fgnutls_boot): Use const for pointer to readonly storage.
9926 Comment out unused local. Fix pointer signedness problems.
9927
640ee02d
PE
9928 * lread.c (openp): Don't stuff size_t into an 'int'.
9929 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9930 about possible signed overflow.
9931
6048fb2a
PE
9932 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9933 (GDK_KEY_g): Don't define if already defined.
9934 (xg_prepare_tooltip): Avoid pointer signedness problem.
9935 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9936
fa3c87e1
PE
9937 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9938 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9939
2172544b
PE
9940 * xfns.c (Fx_window_property): Simplify a bit,
9941 to make a bit faster and to avoid GCC 4.6.0 warning.
9942 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9943
9b821a21
PE
9944 * fns.c (internal_equal): Don't assume size_t fits in int.
9945
3c616cfa
PE
9946 * alloc.c (compact_small_strings): Tighten assertion a little.
9947
c2982e87
PE
9948 Replace pEd with more-general pI, and fix some printf arg casts.
9949 * lisp.h (pI): New macro, generalizing old pEd macro to other
9950 conversion specifiers. For example, use "...%"pI"d..." rather
9951 than "...%"pEd"...".
9952 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9953 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9954 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9955 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9956 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9957 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9958 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9959 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9960 64-bit hosts.
9961 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9962 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9963 * print.c (safe_debug_print, print_object): Likewise.
9964 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9965 to int.
6f04d126
PE
9966 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9967 avoiding the 0 flag, which is not portable.
c2982e87
PE
9968 * process.c (Fmake_network_process): Use pI to avoid cast.
9969 * region-cache.c (pp_cache): Likewise.
9970 * xdisp.c (decode_mode_spec): Likewise.
9971 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9972 behavior on 64-bit hosts with printf arg.
6f04d126 9973 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9974 (x_stop_queuing_selection_requests): Likewise.
9975 (x_get_window_property): Don't truncate byte count to an 'int'
9976 when tracing.
0b432f21 9977
5e073ec7
PE
9978 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9979 here, since it parses constructs like leading '-' and spaces,
9980 which are not wanted; and it overflows with large numbers.
9981 Instead, simply match F[0-9]+, which is what is wanted anyway.
9982
36372bf9
PE
9983 * alloc.c: Remove unportable assumptions about struct layout.
9984 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9985 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9986 (allocate_vectorlike, make_pure_vector): Use the new macros,
9987 plus offsetof, to remove unportable assumptions about struct layout.
9988 These assumptions hold on all porting targets that I know of, but
9989 they are not guaranteed, they're easy to remove, and removing them
9990 makes further changes easier.
9991
0b432f21
PE
9992 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9993 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9994 (string_overrun_cookie): Now const. Use initializers that
9995 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9996 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9997 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9998 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9999 multiple of sizeof (EMACS_INT); it need not be, if
10000 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10001 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10002
895009e1
JB
100032011-04-26 Juanma Barranquero <lekktu@gmail.com>
10004
10005 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10006
6a7a1b0b
TZ
100072011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10008
10009 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10010 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10011 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10012
841a1577 100132011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10014
10015 * lisp.h (Qdebug): List symbol.
895009e1 10016 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10017 * keyboard.c (debug-on-event): New variable.
10018 (handle_user_signal): Break into debugger when debug-on-event
10019 matches the current signal symbol.
10020
f2d3ba6f
DN
100212011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10022
10023 * alloc.c (check_sblock, check_string_bytes)
10024 (check_string_free_list): Convert to standard C.
10025
42ce4c63
TZ
100262011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10027
10028 * w32.c (emacs_gnutls_push): Fix typo.
10029
825cd63c
EZ
100302011-04-25 Eli Zaretskii <eliz@gnu.org>
10031
fb11d64d
EZ
10032 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10033 "cast to pointer from integer of different size".
10034
825cd63c
EZ
10035 Improve doprnt and its use in verror. (Bug#8545)
10036 * doprnt.c (doprnt): Document the set of format control sequences
10037 supported by the function. Use SAFE_ALLOCA instead of always
10038 using `alloca'.
10039
10040 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10041 is one byte too soon. Don't use xrealloc; instead xfree and
10042 xmalloc anew.
10043
e061a11b
TZ
100442011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10045
10046 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10047 callbacks stage.
10048
10049 * gnutls.c: Renamed global_initialized to
10050 gnutls_global_initialized. Added internals for the
10051 :verify-hostname-error, :verify-error, and :verify-flags
10052 parameters of `gnutls-boot' and documented those parameters in the
10053 docstring. Start callback support.
9173deec
JB
10054 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10055 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10056 on error. Return error code.
e061a11b
TZ
10057 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10058 (emacs_gnutls_read): Likewise.
10059 (Fgnutls_boot): Return handshake error code.
10060 (emacs_gnutls_handle_error): New function.
10061 (wsaerror_to_errno): Likewise.
10062
10063 * w32.h (emacs_gnutls_pull): Add prototype.
10064 (emacs_gnutls_push): Likewise.
10065
10066 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10067 (emacs_gnutls_push): Likewise.
10068
100692011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10070
10071 * process.c (wait_reading_process_output): Check if GnuTLS
10072 buffered some data internally if no FDs are set for TLS
10073 connections.
10074
10075 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10076 (LIBS): Link to USER_LIBS.
10077 ($(BLD)/gnutls.$(0)): New target.
10078
fa6996bc
EZ
100792011-04-24 Eli Zaretskii <eliz@gnu.org>
10080
eb35682e
EZ
10081 * xdisp.c (handle_single_display_spec): Rename the
10082 display_replaced_before_p argument into display_replaced_p, to
10083 make it consistent with the commentary. Fix typos in the
10084 commentary.
10085
e2ad650c
EZ
10086 * textprop.c (syms_of_textprop): Remove dead code.
10087 (copy_text_properties): Delete obsolete commentary about an
10088 interface that was deleted long ago. Fix typos in the description
10089 of arguments.
10090
1b2de274
EZ
10091 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10092 to changes in oldXMenu/XMenu.h from 2011-04-16.
10093 <menu_help_message, prev_menu_help_message>: Constify.
10094 (IT_menu_make_room): menu->help_text is now `const char **';
10095 adjust.
10096
10097 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10098 to changes in oldXMenu/XMenu.h from 2011-04-16.
10099 (struct XMenu): Declare `help_text' `const char **'.
10100
10101 * xfaces.c <Qunspecified>: Make extern again.
10102
10103 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10104 required by POSIX.
1b2de274 10105
762b15be
EZ
10106 * doc.c (get_doc_string): Improve the format passed to `error'.
10107
10108 * doprnt.c (doprnt): Improve commentary.
10109
10110 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10111
10112 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10113 them with etags.
10114
f1052e5d
EZ
10115 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10116 changes in globals.h immediately force recompilation.
762b15be
EZ
10117 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10118 $(CURDIR)/s/ms-w32.h.
10119 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10120
fa6996bc
EZ
10121 * character.c (Fchar_direction): Function deleted.
10122 (syms_of_character): Don't defsubr it.
10123 <char-direction-table>: Deleted.
10124
e6c3da20
EZ
101252011-04-23 Eli Zaretskii <eliz@gnu.org>
10126
10127 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10128 * doprnt.c: Include limits.h.
10129 (SIZE_MAX): New macro.
04f2d78b
CB
10130 (doprnt): Return a size_t value. 2nd arg is now size_t.
10131 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10132 Improve overflow protection. Support `l' modifier for integer
10133 conversions. Support %l conversion. Don't assume an EMACS_INT
10134 argument for integer conversions and for %c.
10135
10136 * lisp.h (doprnt): Restore prototype.
10137
10138 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10139 $(SRC)/character.h.
10140
10141 * Makefile.in (base_obj): Add back doprnt.o.
10142
10143 * deps.mk (doprnt.o): Add back prerequisites.
10144 (callint.o): Depend on character.h.
10145
10146 * eval.c (internal_lisp_condition_case): Include the handler
10147 representation in the error message.
10148 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10149 when breaking from the loop.
10150
10151 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10152
10153 * callint.c (Fcall_interactively): When displaying error message
10154 about invalid control letter, pass the character's codepoint, not
10155 a pointer to its multibyte form. Improve display of the character
10156 in octal and display also its hex code.
10157
10158 * character.c (char_string): Use %x to display the (unsigned)
10159 codepoint of an invalid character, to avoid displaying a bogus
10160 negative value.
10161
10162 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10163 `error', not SYMBOL_NAME itself.
10164
10165 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10166 character arguments to `error'.
10167
10168 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10169 to `error' in error message about FINAL_CHAR argument. Make sure
10170 FINAL_CHAR is a character, and use %c when it is passed as
10171 argument to `error'.
10172
4ffd0d6b 101732011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10174
10175 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10176
10177 * w32.c: Include <time.h>.
10178 (sys_localtime): New function.
10179
4ffd0d6b 101802011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10181
10182 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10183
4ffd0d6b 10184 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10185
4ffd0d6b 101862011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10187
4ffd0d6b
GM
10188 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10189 zombies (Bug#8467).
aac0c6e3 10190
04c56954
EZ
101912011-04-19 Eli Zaretskii <eliz@gnu.org>
10192
10193 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10194 gl_state.e_property when gl_state.object is Qt.
10195
10196 * insdel.c (make_gap_larger): Remove limitation of buffer size
10197 to <= INT_MAX.
10198
16a43933
CY
101992011-04-18 Chong Yidong <cyd@stupidchicken.com>
10200
10201 * xdisp.c (lookup_glyphless_char_display)
10202 (produce_glyphless_glyph): Handle cons cell entry in
10203 glyphless-char-display.
10204 (Vglyphless_char_display): Document it.
10205
10206 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10207 glyphless-char-display.
10208
4581706e
CY
102092011-04-17 Chong Yidong <cyd@stupidchicken.com>
10210
10211 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10212
10213 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10214
10215 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10216 definition for no-X builds.
10217
4887c6e2 102182011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10219
fd35b6f9
PE
10220 Static checks with GCC 4.6.0 and non-default toolkits.
10221
5c1ccb01
PE
10222 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10223
006c5daa
PE
10224 * process.c (keyboard_bit_set): Define only if SIGIO.
10225 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10226 (send_process): Repair possible setjmp clobbering.
10227
efc736d3
PE
10228 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10229
4e2fe2e6
PE
10230 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10231
f97334a2
PE
10232 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10233
4e75f29d
PE
10234 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10235 Define only if needed.
10236
90efadd1
PE
10237 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10238 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10239 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10240
3c647824
PE
10241 * dispextern.h (struct redisplay_interface): Rename param
10242 to avoid shadowing.
e264f262 10243 * termhooks.h (struct terminal): Likewise.
761383f4 10244 * xterm.c (xembed_send_message): Likewise.
3c647824 10245
b58c5c4a
PE
10246 * insdel.c (make_gap_smaller): Define only if
10247 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10248
cad59032
PE
10249 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10250 it.
10251
c339dc2e
PE
10252 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10253 so that we aren't warned about unused symbols.
10254
91a3e27b
PE
10255 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10256
399c71d3 10257 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10258
8ffc96f5
PE
10259 * xfns.c (x_real_positions): Mark locals as initialized.
10260
eef9bc79
PE
10261 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10262
098db9dd
PE
10263 * xterm.c: Fix problems found by static analysis with other toolkits.
10264 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10265 (x_dispatch_event): Declare static if USE_GTK, and
10266 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10267 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10268 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10269 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10270 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10271
eb18f6cc
PE
10272 * xmenu.c (menu_help_callback): Pointer type fixes.
10273 Use const pointers when pointing at readonly data. Avoid pointer
10274 signedness clashes.
10275 (FALSE): Remove unused macro.
10276 (update_frame_menubar): Remove unused decl.
10277
1fe72bf8
PE
10278 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10279
60d9e1db
PE
10280 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10281 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10282 (single_menu_item): Rename local to avoid shadowing.
10283
39261c26
PE
10284 * keyboard.c (make_lispy_event): Remove unused local var.
10285
018c5e19
PE
10286 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10287 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10288
63d2b86e
PE
10289 * bitmaps: Change bitmaps from unsigned char back to the X11
10290 compatible char. Avoid the old compiler warnings about
10291 out-of-range initializers by using, for example, '\xab' rather
10292 than 0xab.
10293
aefd87e1
PE
10294 * xgselect.c (xgselect_initialize): Check vs interface
10295 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10296
bf501fb9
PE
10297 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10298
e9829fdf
PE
10299 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10300 to read-only memory.
10301
1086c095
PE
10302 * fns.c (vector): Remove; this old hack is no longer needed.
10303
2baccd04 10304 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10305 Remove unused var.
dde42981 10306 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10307
72391843 10308 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10309
436c16df 10310 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10311 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10312 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10313
92bb796d 10314 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10315 (x_term_init): Remove local to avoid shadowing.
92bb796d 10316
764430a3 10317 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10318
10319 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10320 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10321
d1dfb56c
EZ
103222011-04-16 Eli Zaretskii <eliz@gnu.org>
10323
c4354cb4
EZ
10324 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10325
d1dfb56c
EZ
10326 Fix regex.c, syntax.c and friends for buffers > 2GB.
10327 * syntax.h (struct gl_state_s): Declare character position members
10328 EMACS_INT.
10329
10330 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10331
04f2d78b
CB
10332 * textprop.c (verify_interval_modification, interval_of):
10333 Declare arguments EMACS_INT.
d1dfb56c
EZ
10334
10335 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10336 EMACS_INT.
10337
10338 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10339
10340 * indent.c (Fvertical_motion): Local variable it_start is now
10341 EMACS_INT.
10342
10343 * regex.c (re_match, re_match_2, re_match_2_internal)
10344 (bcmp_translate, regcomp, regexec, print_double_string)
10345 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10346 (re_compile_pattern, re_exec): Declare arguments and local
10347 variables `size_t' and `ssize_t' and return values `regoff_t', as
10348 appropriate.
10349 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10350 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10351 <compile_stack_type>: `size' and `avail' are now `size_t'.
10352
10353 * regex.h <regoff_t>: Use ssize_t, not int.
10354 (re_search, re_search_2, re_match, re_match_2): Arguments that
10355 specify buffer/string position and length are now ssize_t and
10356 size_t. Return type is regoff_t.
10357
613052cd
BK
103582011-04-16 Ben Key <bkey76@gmail.com>
10359
10360 * nsfont.m: Fixed bugs in ns_get_family and
10361 ns_descriptor_to_entity that were caused by using free to
10362 deallocate memory blocks that were allocated by xmalloc (via
10363 xstrdup). This caused Emacs to crash when compiled with
10364 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10365 --enable-checking=xmallocoverrun). xfree is now used to
10366 deallocate these memory blocks.
10367
4170f62f 103682011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10369
71b41406
PE
10370 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10371
9587a89d
PE
10372 emacs_write: Accept and return EMACS_INT for sizes.
10373 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10374 et seq.
10375 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10376 Accept and return EMACS_INT.
10377 (emacs_gnutls_write): Return the number of bytes written on
10378 partial writes.
10379 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10380 (emacs_read, emacs_write): Remove check for negative size, as the
10381 Emacs source code has been audited now.
9587a89d
PE
10382 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10383 (emacs_read, emacs_write): Use it.
273a5f82
PE
10384 * process.c (send_process): Adjust to the new signatures of
10385 emacs_write and emacs_gnutls_write. Do not attempt to store
10386 a byte offset into an 'int'; it might overflow.
9587a89d 10387 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10388
3e047f51
PE
10389 * sound.c: Don't assume sizes fit in 'int'.
10390 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10391 Return EMACS_INT, not int.
3e047f51 10392 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10393 Accept EMACS_INT, not int.
10394 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10395 record read return values.
10396
cc39a9db
BK
103972011-04-15 Ben Key <bkey76@gmail.com>
10398
c9d0ec6d
JB
10399 * keyboard.c (Qundefined): Don't declare static since it is used
10400 in nsfns.m.
10401 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10402 static since they are used in nsfont.m.
cc39a9db 10403
6c60eb9f
SM
104042011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10405
10406 * process.c (Qprocessp): Don't declare static.
10407 * lisp.h (Qprocessp): Declare again.
10408
7990b61a
JB
104092011-04-15 Juanma Barranquero <lekktu@gmail.com>
10410
10411 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10412
5d4cb038
PE
104132011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10414
8bd7b830 10415 Improve C-level modularity by making more things 'static'.
cd64ea1d 10416
e3b27b31
PE
10417 Don't publish debugger-only interfaces to other modules.
10418 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10419 (verify_bytepos, count_markers): Move decls to the only modules
10420 that need them.
10421 * region-cache.h (pp_cache): Likewise.
10422 * window.h (check_all_windows): Likewise.
10423 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10424
5d4cb038
PE
10425 * sysdep.c (croak): Now static, if
10426 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10427 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10428
10429 * alloc.c (refill_memory_reserve): Now static if
10430 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10431 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10432
e87b6180
PE
10433 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10434 Define only if USE_LUCID.
10435
ac64929e
PE
10436 * xrdb.c (x_customization_string, x_rm_string): Now static.
10437
6f37259d
PE
10438 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10439 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10440
1683e3ab
PE
10441 * xdisp.c (draw_row_with_mouse_face): Now static.
10442 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10443
de9c2632
PE
10444 * window.h (check_all_windows): Mark externally visible.
10445
2b96acb7
PE
10446 * window.c (window_deletion_count): Now static.
10447
10448 * undo.c: Make symbols static if they're not exported.
10449 (last_undo_buffer, last_boundary_position, pending_boundary):
10450 Now static.
10451
50436f33
PE
10452 * textprop.c (interval_insert_behind_hooks): Now static.
10453 (interval_insert_in_front_hooks): Likewise.
10454
64520e5c
PE
10455 * term.c: Make symbols static if they're not exported.
10456 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10457 (max_frame_lines, tty_set_terminal_modes):
10458 (tty_reset_terminal_modes, tty_turn_off_highlight):
10459 (get_tty_terminal): Now static.
10460 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10461 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10462 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10463 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10464 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10465
1fa53021
PE
10466 * sysdep.c: Make symbols static if they're not exported.
10467 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10468 Now static.
10469 (sigprocmask_set, full_mask): Remove; unused.
10470 (wait_debugging): Mark as visible.
10471 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10472 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10473
d4b43b22
PE
10474 * syntax.c (syntax_temp): Define only if !__GNUC__.
10475
b7c513d0
PE
10476 * sound.c (current_sound_device, current_sound): Now static.
10477
989b29ad
PE
10478 * search.c (searchbufs, searchbuf_head): Now static.
10479
13a55a78
PE
10480 * scroll.c (scroll_cost): Remove; unused.
10481 * dispextern.h (scroll_cost): Remove decl.
10482
de68a1fc
PE
10483 * region-cache.h (pp_cache): Mark as externally visible.
10484
40ccffa6
PE
10485 * process.c: Make symbols static if they're not exported.
10486 (process_tick, update_tick, create_process, chan_process):
10487 (Vprocess_alist, proc_buffered_char, datagram_access):
10488 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10489 (deactivate_process): Mark defn as static, as well as decl.
10490 * lisp.h (create_process): Remove decl.
10491 * process.h (chan_process, Vprocess_alist): Remove decls.
10492
ad64fc97
PE
10493 * print.c: Make symbols static if they're not exported.
10494 (print_depth, new_backquote_output, being_printed, print_buffer):
10495 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10496 (print_interval, print_number_index, initial_stderr_stream):
10497 Now static.
10498 * lisp.h (Fprinc): Remove decl.
10499 (debug_output_compilation_hack): Mark as externally visible.
10500
adddb265
PE
10501 * sysdep.c (croak): Move decl from here to syssignal.h.
10502 * syssignal.h (croak): Put it here, so the API can be checked when
10503 'croak' is called from dissociate_if_controlling_tty.
10504
1717ede2
PE
10505 * minibuf.c: Make symbols static if they're not exported.
10506 (minibuf_save_list, choose_minibuf_frame): Now static.
10507 * lisp.h (choose_minibuf_frame): Remove decl.
10508
fa5fb2bc
PE
10509 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10510
1e3890d1
PE
10511 * lread.c: Make symbols static if they're not exported.
10512 (read_objects, initial_obarray, oblookup_last_bucket_number):
10513 Now static.
10514 (make_symbol): Remove; unused.
10515 * lisp.h (initial_obarray, make_symbol): Remove decls.
10516
8a1414fa
PE
10517 * keyboard.c: Make symbols static if they're not exported.
10518 (single_kboard, recent_keys_index, total_keys, recent_keys):
10519 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10520 (this_single_command_key_start, echoing, last_auto_save):
10521 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10522 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10523 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10524 (Vlispy_mouse_stem, double_click_count):
10525 Now static.
10526 (force_auto_save_soon): Define only if SIGDANGER.
10527 (ignore_mouse_drag_p): Now static if
10528 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10529 (print_help): Remove; unused.
10530 (stop_character, last_timer_event): Mark as externally visible.
10531 * keyboard.h (ignore_mouse_drag_p): Declare only if
10532 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10533 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10534 * lisp.h (echoing): Remove decl.
10535 (force_auto_save_soon): Declare only if SIGDANGER.
10536 * xdisp.c (redisplay_window): Simplify code, to make it more
10537 obvious that ignore_mouse_drag_p is not accessed if !defined
10538 USE_GTK && !defined HAVE_NS.
10539
93ea6e8f
PE
10540 * intervals.c: Make symbols static if they're not exported.
10541 (merge_properties_sticky, merge_interval_right, delete_interval):
10542 Now static.
10543 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10544
77382fcc
PE
10545 * insdel.c: Make symbols static if they're not exported.
10546 However, leave prepare_to_modify_buffer alone. It's never
10547 called from outside this function, but that appears to be a bug.
10548 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10549 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10550 (adjust_after_replace_noundo): Remove; unused.
10551 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10552 (signal_before_change): Remove decls.
77382fcc 10553
9306c32e
PE
10554 * indent.c (val_compute_motion, val_vmotion): Now static.
10555
cd44d2eb
PE
10556 * image.c: Make symbols static if they're not exported.
10557 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10558 if USE_GTK.
10559 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10560 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10561
ad9a7a06
PE
10562 * fringe.c (standard_bitmaps): Now static.
10563 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10564
81626931
PE
10565 * frame.c: Make symbols static if they're not exported.
10566 (x_report_frame_params, make_terminal_frame): Now static.
10567 (get_frame_param): Now static, unless HAVE_NS.
10568 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10569 (x_get_resource_string): Remove; not used.
10570 * frame.h (make_terminal_frame, x_report_frame_params):
10571 (x_get_resource_string); Remove decls.
10572 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10573 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10574
239f9db9
PE
10575 * font.c, fontset.c: Make symbols static if they're not exported.
10576 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10577 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10578 * font.c (font_close_object): Now static.
10579 * font.h (font_close_object): Remove.
10580 * fontset.c (FONTSET_OBJLIST): Remove.
10581 (free_realized_fontset) #if-0 the body, which does nothing.
10582 (face_suitable_for_char_p): #if-0, as it's never called.
10583 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10584 * xfaces.c (face_at_string_position):
10585 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10586 since 0 is always ASCII.
10587
dfcf3579
PE
10588 * fns.c (weak_hash_tables): Now static.
10589
5045092b
PE
10590 * fileio.c: Make symbols static if they're not exported.
10591 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10592 (Vwrite_region_annotation_buffers): Now static.
10593
57a96f5c
PE
10594 * eval.c: Make symbols static if they're not exported.
10595 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10596 * lisp.h (backtrace_list): Remove decl.
10597
35f08c38
PE
10598 * emacs.c: Make symbols static if they're not exported.
10599 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10600 (fatal_error_code, fatal_error_signal_hook, standard_args):
10601 Now static.
10602 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10603 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10604 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10605 * lisp.h (fatal_error_signal_hook): Remove decl.
10606 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10607
f44bd759
PE
10608 * editfns.c: Move a (normally-unused) function to its only use.
10609 * editfns.c, lisp.h (get_operating_system_release): Remove.
10610 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10611 worth the hassle of breaking this out.
10612
b532497d
PE
10613 * xterm.c: Make symbols static if they're not exported.
10614 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10615 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10616 (x_destroy_window, x_delete_display):
10617 Now static.
10618 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10619 (x_mouse_leave): Remove; unused.
10620 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10621 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10622 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10623 Remove decls.
10624 (x_mouse_leave): Declare only if WINDOWSNT.
10625 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10626 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10627 USE_X_TOOLKIT.
10628
1675728f
PE
10629 * ftxfont.c: Make symbols static if they're not exported.
10630 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10631 HAVE_FREETYPE.
10632 * font.h (ftxfont_driver): Likewise.
10633
e4cebfca
PE
10634 * xfns.c: Make symbols static if they're not exported.
10635 (x_last_font_name, x_display_info_for_name):
10636 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10637 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10638 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10639 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10640 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10641 (last_show_tip_args): Now static.
10642 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10643 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10644 (x_screen_planes): Remove; unused.
10645 * dispextern.h (x_screen_planes): Remove decl.
10646
5bf46f05
PE
10647 * dispnew.c: Make symbols static if they're not exported.
10648 * dispextern.h (redraw_garbaged_frames, scrolling):
10649 (increment_row_positions): Remove.
10650 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10651 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10652 Now static.
10653 (redraw_garbaged_frames): Remove; unused.
10654
435f4c28
PE
10655 * xfaces.c: Make symbols static if they're not exported.
10656 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10657 Remove decls.
10658 * xterm.h (defined_color): Remove decls.
10659 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10660 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10661 (menu_face_changed_default, defined_color, free_realized_face):
10662 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10663 (ascii_face_of_lisp_face): Remove; unused.
10664
8524aef3
PE
10665 * xdisp.c: Make symbols static if they're not exported.
10666 * dispextern.h (scratch_glyph_row, window_box_edges):
10667 (glyph_to_pixel_coords, set_cursor_from_row):
10668 (get_next_display_element, set_iterator_to_next):
10669 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10670 (show_mouse_face): Remove decls
10671 * frame.h (message_buf_print): Likewise.
10672 * lisp.h (pop_message, set_message, check_point_in_composition):
10673 Likewise.
10674 * xterm.h (set_vertical_scroll_bar): Likewise.
10675 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10676 (message_buf_print, scratch_glyph_row, displayed_buffer):
10677 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10678 (get_next_display_element, show_mouse_face, window_box_edges):
10679 (frame_to_window_pixel_xy, check_point_in_composition):
10680 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10681 (glyph_to_pixel_coords): Remove; unused.
10682
16390cd2
PE
10683 * dired.c (file_name_completion): Now static.
10684
10685 * dbusbind.c (xd_in_read_queued_messages): Now static.
10686
a25f4dfa
PE
10687 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10688 * data.c (circular_list_error): Remove.
10689
14a9c8df
PE
10690 * commands.h (last_point_position, last_point_position_buffer):
10691 (last_point_position_window): Remove decls.
10692 * keyboard.c: Make these variables static.
10693
04f2d78b
CB
10694 * coding.h (coding, code_convert_region, encode_coding_gap):
10695 Remove decls.
74ab6df5
PE
10696 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10697 (iso_code_class, detect_coding, code_convert_region): Now static.
10698 (encode_coding_gap): Remove; unused.
10699
38dfbee1
PE
10700 * chartab.c (chartab_chars, chartab_bits): Now static.
10701
a2cb4e63
PE
10702 * charset.h (charset_iso_8859_1): Remove decl.
10703 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10704 Now static.
10705
127198fd
PE
10706 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10707 * ccl.c (Vccl_program_table): Now static.
10708 (check_ccl_update): Remove; unused.
10709
d85b608f
PE
10710 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10711 * category.h: ... from here.
10712 * category.c (check_category_table, set_category_set): Now static.
10713
31cd66f3
PE
10714 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10715 * lisp.h: Remove these decls.
10716
c358e587
PE
10717 * buffer.c (buffer_count): Remove unused var.
10718
e78aecca
PE
10719 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10720 so that it's not optimized away.
10721 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10722 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10723 exported only to the debugger.
10724
e192d7d3 10725 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10726 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10727
92470028
PE
10728 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10729 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10730 was inaccessible from Lisp.
10731 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10732 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10733
244ed907
PE
10734 alloc.c: Import and export fewer symbols, and remove unused items.
10735 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10736 is defined.
10737 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10738 it's not optimized away by whole-program optimization.
10739 (message_enable_multibyte, free_misc): Remove.
10740 (catchlist, handlerlist, mark_backtrace):
10741 Declare only if BYTE_MARK_STACK.
10742 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10743 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10744 (message_enable_multibyte): Remove decl.
10745 (free_misc, interval_free_list, float_block, float_block_index):
10746 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10747 (cons_free_list, last_marked_index):
10748 Now static.
10749 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10750 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10751 (mark_backtrace): Define only if BYTE_MARK_STACK.
10752 * xdisp.c (message_enable_multibyte): Now static.
10753
61c2b50e 10754 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10755 This makes it easier for human readers (and static analyzers)
10756 to see whether these variables are used from other modules.
10757 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10758 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10759 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10760 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10761 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10762 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10763 * xmenu.c, xselect.c:
10764 Declare Q* vars static if they are not used in other modules.
10765 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10766 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10767 Remove decls of unexported vars.
10768 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10769
95c82688
PE
10770 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10771
16a97296
PE
10772 Make Emacs functions such as Fatom 'static' by default.
10773 This makes it easier for human readers (and static analyzers)
10774 to see whether these functions can be called from other modules.
10775 DEFUN now defines a static function. To make the function external
10776 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10777 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10778 (Finit_image_library):
16a97296
PE
10779 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10780 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10781 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10782 Remove decls, since these functions are now static.
10783 (Funintern, Fget_internal_run_time): New decls, since these functions
10784 were already external.
95c82688 10785
16a97296
PE
10786 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10787 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10788 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10789 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10790 * keyboard.c, keymap.c, lread.c:
10791 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10792 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10793 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10794 Mark functions with DEFUE instead of DEFUN,
10795 if they are used in other modules.
10796 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10797 decls for now-static functions.
10798 * buffer.h (Fdelete_overlay): Remove decl.
10799 * callproc.c (Fgetenv_internal): Mark as internal.
10800 * composite.c (Fremove_list_of_text_properties): Remove decl.
10801 (Fcomposition_get_gstring): New forward static decl.
10802 * composite.h (Fcomposite_get_gstring): Remove decl.
10803 * dired.c (Ffile_attributes): New forward static decl.
10804 * doc.c (Fdocumntation_property): New forward static decl.
10805 * eval.c (Ffetch_bytecode): New forward static decl.
10806 (Funintern): Remove extern decl; now in .h file where it belongs.
10807 * fileio.c (Fmake_symbolic_link): New forward static decl.
10808 * image.c (Finit_image_library): New forward static decl.
10809 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10810 * intervals.h (Fprevious_property_change):
10811 (Fremove_list_of_text_properties): Remove decls.
10812 * keyboard.c (Fthis_command_keys): Remove decl.
10813 (Fcommand_execute): New forward static decl.
10814 * keymap.c (Flookup_key): New forward static decl.
10815 (Fcopy_keymap): Now static.
10816 * keymap.h (Flookup_key): Remove decl.
10817 * process.c (Fget_process): New forward static decl.
10818 (Fprocess_datagram_address): Mark as internal.
10819 * syntax.c (Fsyntax_table_p): New forward static decl.
10820 (skip_chars): Remove duplicate decl.
10821 * textprop.c (Fprevious_property_change): New forward static decl.
10822 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10823 Now internal.
10824 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10825 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10826
785bbd42
PE
10827 * editfns.c (Fformat): Remove unreachable code.
10828
8b913b57
AS
108292011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10830
10831 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10832 change. (Bug#8496)
10833
a6744a35
EZ
108342011-04-13 Eli Zaretskii <eliz@gnu.org>
10835
10836 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10837 when at ZV. (Bug#8487)
10838
e7974947
AS
108392011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10840
baad03f0
AS
10841 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10842 (Bug#8437)
10843 * keyboard.c (parse_tool_bar_item): Likewise.
10844 * sound.c (sound_cleanup, alsa_close): Likewise.
10845 * termcap.c (tgetent): Likewise.
10846 * xfns.c (x_default_font_parameter): Likewise.
10847 * xsettings.c (read_and_apply_settings): Likewise.
10848
e7974947
AS
10849 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10850 (overrun_check_free): Protoize.
10851
28272684
PE
108522011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10853
10854 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10855 since callers should never pass a negative size.
10856 Change the signature to match that of plain 'read' and 'write'; see
10857 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10858 * lisp.h: Update prototypes of emacs_write and emacs_read.
10859
11997c76
EZ
108602011-04-11 Eli Zaretskii <eliz@gnu.org>
10861
10862 * xdisp.c (redisplay_window): Don't try to determine the character
10863 position of the scroll margin if the window start point w->startp
e896f03c 10864 is outside the buffer's accessible region. (Bug#8468)
11997c76 10865
8a2cbd72
EZ
108662011-04-10 Eli Zaretskii <eliz@gnu.org>
10867
10868 Fix write-region and its subroutines for buffers > 2GB.
10869 * fileio.c (a_write, e_write): Modify declaration of arguments and
10870 local variables to support buffers larger than 2GB.
10871 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10872
10873 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10874 argument, local variables, and return value.
10875
10876 * lisp.h: Update prototypes of emacs_write and emacs_read.
10877
10878 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10879
4073e537 108802011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10881
1ebfdcb6
PE
10882 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10883
b2ded58d
PE
10884 Fix more problems found by GCC 4.6.0's static checks.
10885
7d66342c
PE
10886 * xdisp.c (vmessage): Use a better test for character truncation.
10887
bbf47d44
PE
10888 * charset.c (load_charset_map): <, not <=, for optimization,
10889 and to avoid potential problems with integer overflow.
9248994d 10890 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10891 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10892 * editfns.c (Fformat): Likewise.
1e69125e 10893 * syntax.c (skip_chars): Likewise.
3befa583 10894
e3019616
PE
10895 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10896 This also lets GCC 4.6.0 generate slightly better loop code.
10897
becfa255
PE
10898 * callint.c (Fcall_interactively): <, not <=, for optimization.
10899 (Fcall_interactively): Count the number of arguments produced,
10900 not the number of arguments given. This is simpler and lets GCC
10901 4.6.0 generate slightly better code.
10902
dae0cd48
PE
10903 * ftfont.c: Distingish more carefully between FcChar8 and char.
10904 The previous code passed unsigned char * to a functions like
10905 strlen and xstrcasecmp that expect char *, which does not
10906 conform to the C standard.
10907 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10908 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10909 char * when the C standard requires it.
10910
76032d70
PE
10911 * keyboard.c (read_char): Remove unused var.
10912
eb3f1cc8
PE
10913 * eval.c: Port to Windows vsnprintf (Bug#8435).
10914 Include <limits.h>.
10915 (SIZE_MAX): Define if the headers do not.
10916 (verror): Do not give up if vsnprintf returns a negative count.
10917 Instead, grow the buffer. This ports to Windows vsnprintf, which
10918 does not conform to C99. Problem reported by Eli Zaretskii.
10919 Also, simplify the allocation scheme, by avoiding the need for
10920 calling realloc, and removing the ALLOCATED variable.
10921
70476b54
PE
10922 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10923
12020a9e
PE
10924 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10925 But keep the doprint source code for now, as we might revamp it
10926 and use it again (Bug#8435).
ea6c7ae6
PE
10927 * lisp.h (doprnt): Remove.
10928 * Makefile.in (base_obj): Remove doprnt.o.
10929 * deps.mk (doprnt.o): Remove.
10930
5fdb398c
PE
10931 error: Print 32- and 64-bit integers portably (Bug#8435).
10932 Without this change, on typical 64-bit hosts error ("...%d...", N)
10933 was used to print both 32- and 64-bit integers N, which relied on
10934 undefined behavior.
61bdb816 10935 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10936 * lisp.h (error, verror): Mark as printf-like functions.
10937 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10938 Report overflow in size calculations when allocating printf buffer.
10939 Do not truncate output string at its first null byte.
10940 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10941 Truncate the output at a character boundary, since vsnprintf does not
10942 do that.
10943 * charset.c (check_iso_charset_parameter): Convert internal
10944 character to string before calling 'error', since %c now has the
10945 printf meaning.
10946 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10947 overflow when computing char to be passed to 'error'. Do not
10948 pass Lisp_Object to 'error'; pass the integer instead.
10949 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10950 formatted with plain %d.
10951
b189fa66
PE
10952 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10953
bff87ef0
PE
10954 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10955
7e2cac20
PE
10956 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10957
ce4d90b5
PE
10958 * xterm.c (x_catch_errors): Remove duplicate declaration.
10959
266c9547
PE
10960 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10961
79c49ad2
PE
10962 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10963
368f4090
JM
109642011-04-10 Jim Meyering <meyering@redhat.com>
10965
10966 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10967 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10968 return ssize_t not "int", and use size_t as the buffer length.
10969 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10970 * gnutls.h: Update declarations.
10971 * process.c (read_process_output): Use ssize_t, to match.
10972 (send_process): Likewise.
10973
a32d4040
CY
109742011-04-09 Chong Yidong <cyd@stupidchicken.com>
10975
10976 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10977
8546720e 109782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10979
04f2d78b
CB
10980 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10981 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10982
8546720e
GM
10983 * xterm.c (handle_one_xevent):
10984 * xmenu.c (create_and_show_popup_menu):
10985 * xselect.c (x_decline_selection_request)
10986 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10987
0a2f5c1a 109882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10989
10990 Fix some uses of `int' instead of EMACS_INT.
10991 * search.c (string_match_1, fast_string_match)
10992 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10993 (scan_buffer, find_next_newline_no_quit)
10994 (find_before_next_newline, search_command, Freplace_match)
10995 (Fmatch_data): Make some `int' variables be EMACS_INT.
10996
10997 * xdisp.c (display_count_lines): 3rd argument and return value now
10998 EMACS_INT. All callers changed.
10999 (pint2hrstr): Last argument is now EMACS_INT.
11000
11001 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11002 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11003 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11004 (decode_coding_utf_16, decode_coding_emacs_mule)
11005 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11006 (decode_coding_ccl, decode_coding_charset)
11007 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11008 (decode_coding_iso_2022, decode_coding_emacs_mule)
11009 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11010 <char_offset, last_offset>: Declare EMACS_INT.
11011 (encode_coding_utf_8, encode_coding_utf_16)
11012 (encode_coding_emacs_mule, encode_invocation_designation)
11013 (encode_designation_at_bol, encode_coding_iso_2022)
11014 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11015 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11016 Declare EMACS_INT.
11017 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11018 (encode_invocation_designation): Last argument P_NCHARS is now
11019 EMACS_INT.
11020 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11021 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11022
11023 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11024 All users changed.
11025
11026 * ccl.c (Fccl_execute_on_string): Declare some variables
11027 EMACS_INT.
11028
8546720e 110292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11030
11031 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11032
4e19a977
CS
110332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11034
11035 * process.c (Fformat_network_address): Doc fix.
11036
87302331
R
110372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11038
ee7683eb 11039 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11040
cbb59342
CY
110412011-04-08 Chong Yidong <cyd@stupidchicken.com>
11042
11043 * keyboard.c (read_char): Call Lisp function help-form-show,
11044 instead of using internal_with_output_to_temp_buffer.
11045 (Qhelp_form_show): New var.
e0d38eeb 11046 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11047
11048 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11049
11050 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11051
e67a13ab
CY
110522011-04-06 Chong Yidong <cyd@stupidchicken.com>
11053
04f2d78b
CB
11054 * process.c (Flist_processes): Remove to Lisp.
11055 (list_processes_1): Delete.
e67a13ab 11056
973f782d
EZ
110572011-04-06 Eli Zaretskii <eliz@gnu.org>
11058
7c106b1e
EZ
11059 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11060
973f782d
EZ
11061 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11062
41cf7d1a 110632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11064
ca23cc88
PE
11065 Fix more problems found by GCC 4.6.0's static checks.
11066
f390e2d5
PE
11067 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11068
42eea0d0
PE
11069 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11070
b69769da 11071 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11072
f9541e84
PE
11073 * xdisp.c (vmessage): Mark as a printf-like function.
11074
13841b55
PE
11075 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11076
c136c10f
PE
11077 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11078
5e2d4a30
PE
11079 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11080 printf-like functions.
11081 (tiff_load): Add casts to remove these marks before passing them
11082 to system-supplied API.
11083
583f48b9
PE
11084 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11085
b25d760e
PE
11086 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11087 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11088 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11089 directly, rather than having caller test rule sign. This avoids
11090 some unnecessary tests.
11091 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11092 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11093 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11094
bc7b6697 11095 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11096 (xfont_open): Avoid unnecessary tests.
bc7b6697 11097
27ccc379
PE
11098 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11099
dcd5c89a
PE
11100 * composite.h, composite.c (composition_gstring_put_cache):
11101 Use EMACS_INT, not int, for length.
11102
b13a45c6
PE
11103 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11104 breaking out part of COMPOSITION_DECODE_RULE.
11105 (COMPOSITION_DECODE_RULE): Use it.
11106 * composite.c (get_composition_id): Remove unused local vars,
11107 by using the new macro.
11108
1e792e4d
PE
11109 * textprop.c (set_text_properties_1): Change while to do-while,
11110 since the condition is always true at first.
11111
dc6c6455 11112 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11113 (interval_deletion_adjustment): Return unsigned value.
11114 All uses changed.
dc6c6455 11115
aba7731a
PE
11116 * process.c (list_processes_1, create_pty, read_process_output):
11117 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11118 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11119 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11120 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11121 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11122
fdfc4bf3
PE
11123 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11124
fca8fe46 11125 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11126 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11127
06a0259a 11128 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11129 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11130 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11131
e7b9e80f
PE
11132 * print.c (print_error_message): Avoid int overflow.
11133
56201685
PE
11134 * font.c (font_list_entities): Redo for clarity,
11135 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11136
78834453 11137 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11138 (font_score): Avoid potential overflow in diff calculation.
78834453 11139
0bc0b309 11140 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11141 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11142
e610eaca
PE
11143 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11144
b895abce
PE
11145 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11146 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11147 can always succeed if overflow has undefined behavior.
11148
1f1d9321 11149 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11150 (wordify): Omit three unnecessary tests.
1f1d9321 11151
c59478bc
PE
11152 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11153 All callers changed. This avoids the need for an unused var.
11154
79b73827
PE
11155 * casefiddle.c (casify_region): Remove var that is set but not used.
11156
a4db5dfe
PE
11157 * dired.c (file_name_completion): Remove var that is set but not used.
11158
43aae36e
PE
11159 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11160
2a47c44d 11161 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11162 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11163
a37c69bf
PE
11164 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11165 Check for integer overflow on size calculations.
11166
328ab8e7
PE
11167 * buffer.c (Fprevious_overlay_change): Remove var that is set
11168 but not used.
11169
e5a2a5cb
PE
11170 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11171 Remove vars that are set but not used.
8d84a6eb 11172 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11173 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11174
a60e5f68
PE
11175 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11176
f661cb61 11177 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11178 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11179
f0397f5a
PE
11180 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11181 that are set but not used.
11182
8664db06 11183 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11184 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11185
6abdaa4a
PE
11186 * xselect.c (x_get_local_selection, x_handle_property_notify):
11187 Remove vars that are set but not used.
11188
0ce7538d 11189 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11190 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11191
9ae848fc
PE
11192 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11193 Remove var that is set but not used.
0b918413
PE
11194 (scroll_bar_windows_size): Now size_t, not int.
11195 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11196 Check for overflow.
9ae848fc 11197
a5a62657
PE
11198 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11199 (map_tty_color) [!defined MSDOS]: Likewise.
11200
5c5cdd39
PE
11201 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11202
66ebf983
PE
11203 * coding.c: Remove vars that are set but not used.
11204 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11205 All callers changed.
11206 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11207 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11208 (decode_coding_charset): Remove vars that are set but not used.
11209
1be4d761
PE
11210 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11211 that is set but not used.
11212
47553fa8
PE
11213 * print.c (print_object): Remove var that is set but not used.
11214
1f7196bf 11215 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11216 The gnulib version avoids calling malloc in the usual case,
11217 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11218 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11219 * filelock.c (current_lock_owner): Likewise.
11220 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11221 * sysdep.c: Include allocator.h, careadlinkat.h.
11222 (emacs_no_realloc_allocator): New static constant.
11223 (emacs_readlink): New function.
fdb61804
PE
11224 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11225 ../lib/careadlinkat.h.
d1fdcab7 11226
f84c17c7
SM
112272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11228
11229 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11230 first non-nil return value).
11231
ef3862ad
JD
112322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11233
11234 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11235 if not defined (Bug#8403).
11236
376a7006
JB
112372011-04-02 Juanma Barranquero <lekktu@gmail.com>
11238
11239 * xdisp.c (display_count_lines): Remove parameter `start',
11240 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11241 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11242 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11243 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11244 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11245 and thereabouts. All callers changed.
11246 (get_per_char_metric): Remove parameter `f', unused since
11247 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11248
6ca3801d
JM
112492011-04-02 Jim Meyering <meyering@redhat.com>
11250
11251 do not dereference NULL upon failed strdup
11252 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11253 (ns_get_family): Likewise.
11254
d8e2b5ba
JB
112552011-04-02 Juanma Barranquero <lekktu@gmail.com>
11256
11257 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11258
8c74fcbd
JD
112592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11260
11261 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11262 later (Bug#8403).
11263
7200d79c
SM
112642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11265
03408648 11266 Add lexical binding.
7200d79c 11267
03408648
SM
11268 * window.c (Ftemp_output_buffer_show): New fun.
11269 (Fsave_window_excursion):
11270 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11271
11272 * lread.c (lisp_file_lexically_bound_p): New function.
11273 (Fload): Bind Qlexical_binding.
11274 (readevalloop): Remove `evalfun' arg.
11275 Bind Qinternal_interpreter_environment.
11276 (Feval_buffer): Bind Qlexical_binding.
11277 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11278 Mark as dynamic.
11279 (syms_of_lread): Declare `lexical-binding'.
11280
11281 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11282
11283 * keyboard.c (eval_dyn): New fun.
11284 (menu_item_eval_property): Use it.
ca105506
SM
11285
11286 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11287
03408648
SM
11288 * fns.c (concat, mapcar1): Accept byte-code-functions.
11289
11290 * eval.c (Fsetq): Handle lexical vars.
11291 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11292 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11293 (FletX, Flet): Obey lexical binding.
11294 (Fcommandp): Handle closures.
11295 (Feval): New `lexical' arg.
11296 (eval_sub): New function extracted from Feval. Use it almost
11297 everywhere where Feval was used. Look up vars in lexical env.
11298 Handle closures.
11299 (Ffunctionp): Move from subr.el.
11300 (Ffuncall): Handle closures.
11301 (apply_lambda): Remove `eval_flags'.
11302 (funcall_lambda): Handle closures and new byte-code-functions.
11303 (Fspecial_variable_p): New function.
11304 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11305 but without exporting it to Lisp.
23aba0ea 11306
23aba0ea 11307 * doc.c (Fdocumentation, store_function_docstring):
03408648 11308 * data.c (Finteractive_form): Handle closures.
23aba0ea 11309
03408648
SM
11310 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11311 interactive spec.
ba83908c 11312
04f2d78b
CB
11313 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11314 New byte-codes.
03408648
SM
11315 (exec_byte_code): New function extracted from Fbyte_code to handle new
11316 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11317
03408648 11318 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11319
03408648 11320 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11321
e2abce01
JB
113222011-03-31 Juanma Barranquero <lekktu@gmail.com>
11323
11324 * xdisp.c (redisplay_internal): Fix prototype.
11325
63696a73 113262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11327
63696a73 11328 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11329 (try_scrolling): Use it when setting scroll_limit.
11330 Limit scrolling to 100 screen lines.
63696a73
EZ
11331 (redisplay_window): Even when falling back on "recentering",
11332 position point in the window according to scroll-conservatively,
11333 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11334
11335 (try_scrolling): When point is above the window, allow searching
11336 as far as scroll_max, or one screenful, to compute vertical
11337 distance from PT to the scroll margin position. This prevents
11338 try_scrolling from unnecessarily failing when
11339 scroll-conservatively is set to a value slightly larger than the
11340 window height. Clean up the case of PT below the margin at bottom
11341 of window: scroll_max can no longer be INT_MAX. When aggressive
11342 scrolling is in use, don't let point enter the opposite scroll
11343 margin as result of the scroll.
11344 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11345 threshold of 100 lines for never-recentering scrolling.
11346
e4cc2dfc
JB
113472011-03-31 Juanma Barranquero <lekktu@gmail.com>
11348
11349 * dispextern.h (move_it_by_lines):
11350 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11351 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11352 (message_log_check_duplicate): Remove parameters `prev_bol' and
11353 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11354 (redisplay_internal): Remove parameter `preserve_echo_area',
11355 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11356
11357 * indent.c (Fvertical_motion):
11358 * window.c (window_scroll_pixel_based, Frecenter):
11359 Don't pass `need_y_p' to `move_it_by_lines'.
11360
1c470562
SM
113612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11362
44f230aa
SM
11363 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11364 steal a few bits to be more compact.
11365 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11366 Remove unneeded casts.
11367
1c470562
SM
11368 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11369
888adce9
ZK
113702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11371
11372 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11373 binding" message (bug#7967).
11374
f838ed7b
PE
113752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11376
77861b95
PE
11377 Fix more problems found by GCC 4.6.0's static checks.
11378
de6dbc14
PE
11379 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11380 Remove unused local var.
11381
f838ed7b
PE
11382 * editfns.c (Fmessage_box): Remove unused local var.
11383
792c7b2b
PE
11384 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11385 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11386 Omit unused local vars.
c499e557 11387 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11388 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11389 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11390 Omit unused local var.
11391
ba0165e1
PE
11392 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11393 Don't assume string length fits in int.
32ad8845 11394 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11395 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11396
3c59b4c9
PE
11397 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11398 instead of alloca (Bug#8344).
11399
a3eed478 11400 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11401 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11402
eb4d412d
PE
11403 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11404
1658b401
PE
11405 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11406 concerns.
11407
11408 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11409
11410 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11411
9a2c6e05
PE
11412 * keyboard.c (syms_of_keyboard): Use the same style as later
11413 in this function when indexing through an array. This also
11414 works around GCC bug 48267.
11415
03d0a109
PE
11416 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11417
44f730c8
PE
11418 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11419
fe75f926
PE
11420 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11421 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11422
ffa8c828
PE
11423 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11424 This avoids undefined behavior on integer overflow, and is a bit
11425 more convenient anyway since it is compared to a size_t variable.
11426
c5101a77
PE
11427 Variadic C functions now count arguments with size_t, not int.
11428 This avoids an unnecessary limitation on 64-bit machines, which
11429 caused (substring ...) to crash on large vectors (Bug#8344).
11430 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11431 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11432 All variadic functions and their callers changed accordingly.
c5101a77
PE
11433 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11434 * data.c (arith_driver, float_arith_driver): Likewise.
11435 * editfns.c (general_insert_function): Likewise.
11436 * eval.c (struct backtrace.nargs, interactive_p)
11437 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11438 (funcall_lambda, mark_backtrace): Likewise.
11439 * fns.c (concat): Likewise.
11440 * frame.c (x_set_frame_parameters): Likewise.
11441 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11442 0 if not found, not -1. All callers changed.
11443
dd3f25f7
PE
11444 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11445 (stack_copy_size): Now size_t, not int.
11446 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11447
461c2ab9
JB
114482011-03-28 Juanma Barranquero <lekktu@gmail.com>
11449
11450 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11451 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11452 All callers changed.
11453
11454 * lisp.h (multibyte_char_to_unibyte):
11455 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11456 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11457 * character.h (CHAR_TO_BYTE8):
11458 * cmds.c (internal_self_insert):
11459 * editfns.c (general_insert_function):
11460 * keymap.c (push_key_description):
11461 * search.c (Freplace_match):
11462 * xdisp.c (message_dolog, set_message_1): All callers changed.
11463
f6d62986
SM
114642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11465
11466 * keyboard.c (safe_run_hook_funcall): New function.
11467 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11468 don't set the hook to nil, but remove the offending function instead.
11469 (Qcommand_hook_internal): Remove, unused.
11470 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11471 Vcommand_hook_internal.
11472
11473 * eval.c (enum run_hooks_condition): Remove.
11474 (funcall_nil, funcall_not): New functions.
11475 (run_hook_with_args): Call each function through a `funcall' argument.
11476 Remove `cond' argument, now redundant.
11477 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11478 (Frun_hook_with_args_until_failure): Adjust accordingly.
11479 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11480
1db5b1ad
JB
114812011-03-28 Juanma Barranquero <lekktu@gmail.com>
11482
11483 * dispextern.h (string_buffer_position): Remove declaration.
11484
11485 * print.c (strout): Remove parameter `multibyte', unused since
11486 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11487
11488 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11489 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11490 All callers changed.
11491
11492 * w32.c (_wsa_errlist): Use braces for struct initializers.
11493
11494 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11495 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11496 All callers changed.
11497 (string_buffer_position): Likewise. Also, make static (it's never
11498 used outside xdisp.c).
11499 (cursor_row_p): Remove parameter `w', unused since
11500 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11501 (decode_mode_spec): Remove parameter `precision', introduced during
11502 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11503 All callers changed.
11504
5ffb62aa
JD
115052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11506
11507 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11508
461c2ab9 115092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11510
11511 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11512 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11513 (ns_update_auto_hide_menu_bar): New functions.
11514 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11515 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11516 ns_constrain_all_frames.
11517 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11518 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11519
5c380ffb
JD
115202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11521
11522 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11523
9af30bdf
GM
115242011-03-27 Glenn Morris <rgm@gnu.org>
11525
11526 * syssignal.h: Replace RETSIGTYPE with void.
11527 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11528 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11529 Replace SIGTYPE with void everywhere.
11530 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11531 * s/template.h (SIGTYPE): Remove commented out definition.
11532
e2abce01
JB
115332011-03-26 Eli Zaretskii <eliz@gnu.org>
11534
11535 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11536 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11537
f868cd8a
JB
115382011-03-26 Juanma Barranquero <lekktu@gmail.com>
11539
59eb0929
JB
11540 * w32.c (read_unc_volume): Use parameter `henum', instead of
11541 global variable `wget_enum_handle'.
11542
11543 * keymap.c (describe_vector): Remove parameters `indices' and
11544 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11545 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11546
f868cd8a
JB
11547 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11548
11549 * keyboard.c (timer_check): Remove parameter `do_it_now',
11550 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11551 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11552 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11553
11554 * keyboard.c (read_char):
11555 * w32menu.c (w32_menu_display_help):
11556 * xmenu.c (show_help_event, menu_help_callback):
11557 Adjust calls to `show_help_echo'.
11558
11559 * gtkutil.c (xg_maybe_add_timer):
11560 * keyboard.c (readable_events):
11561 * process.c (wait_reading_process_output):
11562 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11563
11564 * insdel.c (adjust_markers_gap_motion):
11565 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11566 (gap_left, gap_right): Don't call it.
11567
2ecf6fdb
CY
115682011-03-25 Chong Yidong <cyd@stupidchicken.com>
11569
11570 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11571 incurred during fontification.
11572
6b1f9ba4
JB
115732011-03-25 Juanma Barranquero <lekktu@gmail.com>
11574
11575 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11576 (DEFVAR_PER_BUFFER): Don't pass it.
11577
11578 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11579 (scrolling_window): Don't pass it.
11580
0f4a96b5
JB
115812011-03-25 Juanma Barranquero <lekktu@gmail.com>
11582
11583 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11584
11585 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11586 and `suffix'.
11587 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11588 of variables specific to SELinux and computation of `encoded_absname'.
11589
11590 * image.c (XPutPixel): Remove unused variable `height'.
11591
11592 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11593
11594 * unexw32.c (get_section_info): Remove unused variable `section'.
11595
11596 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11597 (system_process_attributes): Remove unused variable `sess'.
11598 (sys_read): Remove unused variable `err'.
11599
11600 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11601 (w32_wnd_proc): Remove unused variable `isdead'.
11602 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11603 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11604 (x_create_tip_frame): Remove unused variable `tem'.
11605
11606 * w32inevt.c (w32_console_read_socket):
11607 Remove unused variable `no_events'.
11608
11609 * w32term.c (x_draw_composite_glyph_string_foreground):
11610 Remove unused variable `width'.
11611
1149507c
JB
116122011-03-24 Juanma Barranquero <lekktu@gmail.com>
11613
11614 * w32term.c (x_set_glyph_string_clipping):
11615 Don't pass uninitialized region to CombineRgn.
11616
9c88f339
JB
116172011-03-23 Juanma Barranquero <lekktu@gmail.com>
11618
11619 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11620 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11621 (Fx_close_connection): Remove unused variable `i'.
11622
11623 * w32font.c (w32font_draw): Return number of glyphs.
11624 (w32font_open_internal): Remove unused variable `i'.
11625 (w32font_driver): Add missing initializer.
11626
11627 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11628 (fill_in_menu): Remove unused variable `items_added'.
11629
11630 * w32term.c (last_mouse_press_frame): Remove static global variable.
11631 (w32_clip_to_row): Remove unused variable `f'.
11632 (x_delete_terminal): Remove unused variable `i'.
11633
11634 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11635 (NOTHING): Remove unused static global variable.
11636 (uniscribe_check_otf): Remove unused variable `table'.
11637 (uniscribe_font_driver): Add missing initializers.
11638
dee091a3
JD
116392011-03-23 Julien Danjou <julien@danjou.info>
11640
11641 * term.c (Fsuspend_tty, Fresume_tty):
11642 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11643 * window.c (temp_output_buffer_show):
11644 * insdel.c (signal_before_change):
11645 * frame.c (Fhandle_switch_frame):
11646 * fileio.c (Fdo_auto_save):
11647 * emacs.c (Fkill_emacs):
11648 * editfns.c (save_excursion_restore):
11649 * cmds.c (internal_self_insert):
11650 * callint.c (Fcall_interactively):
11651 * buffer.c (Fkill_all_local_variables):
11652 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11653 Use Frun_hooks.
0f4a96b5 11654 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11655 unconditionally since it does the check itself.
dee091a3 11656
2c520ab5 116572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11658
c9c49752
PE
11659 Fix more problems found by GCC 4.5.2's static checks.
11660
8abc3f12
PE
11661 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11662 the first time through the loop, since we know p0 < p1 then.
11663 This also avoids a gcc -Wstrict-overflow warning.
11664
a2d26660
PE
11665 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11666 leading to a memory leak, possible in functions like
11667 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11668 of objects (Bug#8318).
a2d26660 11669
916c72e9
PE
11670 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11671 that could (at least in theory) be that large.
11672
19ab8a18
PE
11673 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11674 This is less likely to overflow, and avoids undefined behavior if
11675 overflow does occur. All callers changed. Use strtoul to scan
11676 for the unsigned long integer.
b7cbbd6f
PE
11677 (pint2hrstr): Simplify and tune code slightly.
11678 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11679
f0641eff
PE
11680 * scroll.c (do_scrolling): Work around GCC bug 48228.
11681 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11682
7f650bb9
PE
11683 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11684 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11685 (validate_x_resource_name): Simplify count usage.
11686 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11687
37dd57d1
PE
11688 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11689 fail (Bug#8306).
81e56e61 11690
699979fc 11691 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11692
401bf9b4
PE
11693 * process.c (Fmake_network_process): Use socklen_t, not int,
11694 where POSIX says socklen_t is required in portable programs.
11695 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11696 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11697 (Fmake_network_process, server_accept_connection):
11698 (wait_reading_process_output, read_process_output):
11699 Likewise.
11700
b93aacde
PE
11701 * process.c: Rename or move locals to avoid shadowing.
11702 (list_processes_1, Fmake_network_process):
11703 (read_process_output_error_handler, exec_sentinel_error_handler):
11704 Rename or move locals.
4dc343ee 11705 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11706 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11707 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11708 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11709 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11710
af8a867c 11711 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11712 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11713 Include tparam.h instead, since it declares them.
af8a867c
PE
11714 * cm.h (PC): Remove extern decl; tparam.h now does this.
11715 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11716 * terminfo.c: Include tparam.h, to check interfaces.
11717 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11718 (tparam): Adjust signature to match interface in tparam.h;
11719 this removes some undefined behavior. Check that outstring and len
11720 are zero, which they always are with Emacs.
11721 * tparam.h (PC, BC, UP): New extern decls.
11722
0248044d 11723 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11724 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11725
8ff096c1 11726 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11727 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11728 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11729 (ftfont_list): Remove unused local.
49eaafba
PE
11730 (get_adstyle_property, ftfont_pattern_entity):
11731 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11732 Rename locals to avoid shadowing.
8ff096c1 11733
e2be39f6
PE
11734 * xfont.c (xfont_list_family): Mark var as initialized.
11735
c9735e30
PE
11736 * xml.c (make_dom): Now static.
11737
8f5201ae
PE
11738 * composite.c (composition_compute_stop_pos): Rename local to
11739 avoid shadowing.
b246f932
PE
11740 (composition_reseat_it): Remove unused locals.
11741 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11742 (composition_update_it): Mark var as initialized.
11b61122
PE
11743 (find_automatic_composition): Mark vars as initialized,
11744 with a FIXME (Bug#8290).
8f5201ae 11745
760fbc2c
PE
11746 character.h: Rename locals to avoid shadowing.
11747 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11748 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11749 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11750 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11751 to avoid shadowing.
11752
ff08eb85
PE
11753 * textprop.c (property_change_between_p): Remove; unused.
11754
fc7bf025
PE
11755 * intervals.c (interval_start_pos): Now static.
11756
235d7abc
PE
11757 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11758
44f230aa
SM
11759 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11760 Rename locals to avoid shadowing.
3e7d6594 11761
50060332
PE
11762 * sound.c (wav_play, au_play, Fplay_sound_internal):
11763 Fix pointer signedness.
d01f234b 11764 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11765 (wav_play): Initialize a variable to 0, to prevent undefined
11766 behavior (Bug#8278).
50060332 11767
c4fc4e30
PE
11768 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11769
918436ed
PE
11770 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11771
c939f91b
PE
11772 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11773 clobbering (Bug#8298).
b9c7f648
PE
11774 * sysdep.c (sys_subshell): Likewise.
11775 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11776
6bd8c144
PE
11777 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11778 This should get cleaned up, so that child_setup has the
11779 same signature on all platforms.
11780
7710357c 11781 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11782 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11783
c59da222
CY
117842011-03-22 Chong Yidong <cyd@stupidchicken.com>
11785
11786 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11787 not to be necessary, and produces flickering.
11788
66b87493
GM
117892011-03-20 Glenn Morris <rgm@gnu.org>
11790
11791 * config.in: Remove file.
11792
45b6f6d5
JB
117932011-03-20 Juanma Barranquero <lekktu@gmail.com>
11794
11795 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11796 are now in src/globals.h.
11797 (syms_of_minibuf): Remove spurious & from previous change.
11798
cd394be1 117992011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11800
11801 * minibuf.c (completing-read-function): New variable.
11802 (completing-read-default): Rename from completing-read.
11803 (completing-read): Call completing-read-function.
11804
b14e3e21
CY
118052011-03-19 Juanma Barranquero <lekktu@gmail.com>
11806
11807 * xfaces.c (Fx_load_color_file):
11808 Read color file from absolute filename (bug#8250).
11809
f2b726e6
JB
118102011-03-19 Juanma Barranquero <lekktu@gmail.com>
11811
11812 * makefile.w32-in: Update dependencies.
11813
09f6ff02
EZ
118142011-03-17 Eli Zaretskii <eliz@gnu.org>
11815
11816 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11817
29a6015a
PE
118182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11819
a3a6c54e
PE
11820 Fix more problems found by GCC 4.5.2's static checks.
11821
b766f867
PE
11822 * process.c (make_serial_process_unwind, send_process_trap):
11823 (sigchld_handler): Now static.
11824
be02381c
PE
11825 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11826 That way, the code declares only the vars that it needs.
11827 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11828 * s/cygwin.h (PTY_ITERATION): Likewise.
11829 * s/darwin.h (PTY_ITERATION): Likewise.
11830 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11831
57048744
PE
11832 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11833 * process.c (allocate_pty): Don't declare stb unless it's needed.
11834
7914961c 11835 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11836 (CONSTANTLIM): Remove; unused.
11837 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11838 Define only if needed.
7914961c 11839
b3967b18
PE
11840 * unexelf.c (unexec): Name an expression,
11841 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11842 Use a different way to cause a compilation error if anyone uses
11843 n rather than nn, a way that does not involve shadowing.
73366a00 11844 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11845
29a6015a
PE
11846 * deps.mk (unexalpha.o): Remove; unused.
11847
43cfc33e 11848 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11849 * unexec.h: New file.
ce701a33
PE
11850 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11851 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11852 Depend on unexec.h.
11853 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11854 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11855 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11856 Change as necessary to match prototype in unexec.h.
ce701a33 11857
01f44d5a
PE
11858 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11859 shadowing.
4f63c6bb 11860 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11861
a6670b0b
PE
11862 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11863 Rename locals to avoid shadowing.
11864
cef2010d 11865 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11866 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11867
d4d7173a
PE
11868 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11869
f08b802a
PE
11870 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11871 warning when compiling print.c.
11872
3ddb0639
PE
11873 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11874 instead of using an uninitialized var.
5ad03b97 11875 (font_sort_entities): Mark var as initialized.
3ddb0639 11876
170a2692
PE
11877 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11878
e663c700
PE
11879 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11880 pointers to constants.
89bc529a 11881 (font_parse_fcname): Remove unused vars.
7b81e2d0 11882 (font_delete_unmatched): Now static.
ea838e10 11883 (font_get_spec): Remove; unused.
13a547c6
PE
11884 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11885 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11886 Rename or move locals to avoid shadowing.
e663c700 11887
2a80c887 11888 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11889 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11890
1384fa33 11891 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11892 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11893
8b2c52e9
PE
11894 * alloc.c (mark_backtrace): Move decl from here ...
11895 * lisp.h: ... to here, so that it can be checked.
11896
475545b5 11897 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11898 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11899 (lisp_indirect_variable): Name an expression,
11900 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11901 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11902
b1349114 11903 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11904 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11905 Use const pointer when appropriate.
b1349114 11906
a2928364
PE
11907 * lisp.h (get_system_name, get_operating_system_release):
11908 Move decls here, to check interfaces.
11909 * process.c (get_operating_system_release): Move decl to lisp.h.
11910 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11911 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11912 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11913 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11914 (Fformat_time_string, Fencode_time, Finsert_char):
11915 (Ftranslate_region_internal, Fformat):
11916 Rename or remove local vars to avoid shadowing.
9710023e 11917 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11918
a415e694
PE
11919 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11920 avoid shadowing.
11921
8ef4622d
PE
11922 * lisp.h (eassert): Check that the argument compiles, even if
11923 ENABLE_CHECKING is not defined.
11924
946f9a5b
PE
11925 * data.c (Findirect_variable): Name an expression, to avoid
11926 gcc -Wbad-function-cast warning.
112396d6 11927 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11928 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11929 (Fmake_variable_buffer_local, Fmake_local_variable):
11930 Mark variables as initialized.
52746918 11931 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11932
e5aab7e7 11933 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11934 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11935 Rename locals to avoid shadowing.
dff45157
PE
11936 (mark_stack): Move local variables into the #ifdef region where
11937 they're used.
7bc26fdb
PE
11938 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11939 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11940 needed otherwise.
11941 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11942 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11943 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11944
e5aab7e7
PE
11945 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11946 avoids undefined behavior in theory.
11947
4da60324
PE
11948 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11949
88043301
PE
11950 Use functions, not macros, for up- and down-casing (Bug#8254).
11951 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11952 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11953 to use the following functions instead of these macros.
11954 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11955 EMACS_INT, since callers assume the returned value fits in int.
11956 (upcase1): Likewise, for UPCASE_TABLE.
11957 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11958 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11959 the race-condition problem in the old DOWNCASE.
88043301 11960
19ed5445
PE
11961 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11962 Rename locals to avoid shadowing.
11963 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11964 (regex_compile, re_search_2, re_match_2_internal):
11965 Remove unused local vars.
952db0d7
PE
11966 (FREE_VAR): Rewrite so as not to use empty "else",
11967 which gcc can warn about.
da053e48 11968 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11969 (RETALLOC_IF): Define only if needed.
11970 (WORDCHAR_P): Likewise. This one is never needed, but is used
11971 only in a comment talking about a compiler bug, so put inside
11972 the #if 0 of that comment.
11973 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11974 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11975 Remove; unused.
19ed5445 11976
1f3561e4 11977 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11978 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11979 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11980
ded6f8f7
PE
11981 * search.c (simple_search): Remove unused var.
11982
dbd37a95
PE
11983 * dired.c (compile_pattern): Move decl from here ...
11984 * lisp.h: ... to here, so that it can be checked.
11985 (struct re_registers): New forward decl.
11986
7e47afad
PE
11987 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11988
85f24f61
PE
11989 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11990 All uses changed.
11991 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11992 Rename locals to avoid shadowing.
5671df8f 11993 (Fvertical_motion): Mark locals as initialized.
85f24f61 11994
181aa2be 11995 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11996 (casify_region): Mark local as initialized.
181aa2be 11997
930d429c
PE
11998 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11999
7082eac6
PE
12000 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12001 New macros, so that the caller can use some names other than
12002 gcpro1, gcpro2, etc.
12003 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12004 of the new macros.
12005 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12006 argument, for consistency with GCPRO2_VAR, etc: it is now the
12007 prefix of the variable, not the variable itself. All uses
12008 changed.
38b2c076
PE
12009 * dired.c (directory_files_internal, file_name_completion):
12010 Rename locals to avoid shadowing.
12011
15206ed9
PE
12012 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12013 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12014 dired.c's scmp function, had undefined behavior.
12015 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12016 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12017 * buffer.h: ... to here, because these macros use current_buffer,
12018 and the new implementation with inline functions needs to have
12019 current_buffer in scope now, rather than later when the macros
12020 are used.
12021 (downcase, upcase1): New static inline functions.
12022 (DOWNCASE, UPCASE1): Reimplement using these functions.
12023 This avoids undefined behavior in expressions like
12024 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12025 from race conditions in accessing the global variables
12026 case_temp1 and case_temp2.
12027 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12028 * lisp.h (case_temp1, case_temp2): Remove their decls.
12029 * character.h (ASCII_CHAR_P): Move from here ...
12030 * lisp.h: ... to here, so that the inline functions mentioned
12031 above can use them.
12032
4a6bea26
PE
12033 * dired.c (directory_files_internal_unwind): Now static.
12034
f14b7e14
PE
12035 * fileio.c (file_name_as_directory, directory_file_name):
12036 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12037 Now static.
2893f146
PE
12038 (file_name_as_directory): Use const pointers when appropriate.
12039 (Fexpand_file_name): Likewise. In particular, newdir might
12040 point at constant storage, so make it a const pointer.
fd4ead52 12041 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12042 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12043 signedness issues.
f839df0c
PE
12044 (Fset_file_times, Finsert_file_contents, auto_save_error):
12045 Rename locals to avoid shadowing.
f14b7e14 12046
5716756e 12047 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12048 (Ftry_completion, Fall_completions): Rename or remove locals
12049 to avoid shadowing.
5716756e 12050
b4c3046a
PE
12051 * marker.c (bytepos_to_charpos): Remove; unused.
12052
b45db522
PE
12053 * lisp.h (verify_bytepos, count_markers): New decls,
12054 so that gcc does not warn that these functions aren't declared.
12055
85876d07
PE
12056 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12057 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12058 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12059 (copy_text): Remove unused local var.
85876d07 12060
03d78a21 12061 * filelock.c (within_one_second): Now static.
b3dd38ab 12062 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12063
5df8f01b
PE
12064 * buffer.c (fix_overlays_before): Mark locals as initialized.
12065 (fix_start_end_in_overlays): Likewise. This function should be
12066 simplified by using pointers-to-pointers, but that's a different
12067 matter.
b1d876f1 12068 (switch_to_buffer_1): Now static.
8f54f30a
PE
12069 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12070 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12071
a70072c9 12072 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12073 Fix pointer signedness issue.
edced198
PE
12074 (sys_subshell): Mark local as volatile if checking for lint,
12075 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12076 (MAXPATHLEN): Define only if needed.
a70072c9 12077
a0977c44
PE
12078 * process.c (serial_open, serial_configure): Move decls from here ...
12079 * systty.h: ... to here, so that they can be checked.
12080
a884fdcc
PE
12081 * fns.c (get_random, seed_random): Move extern decls from here ...
12082 * lisp.h: ... to here, so that they can be checked.
12083
604efe86 12084 * sysdep.c (reset_io): Now static.
b8950c94 12085 (wait_for_termination_signal): Remove; unused.
604efe86 12086
38fc62d9
PE
12087 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12088 (copy_keymap_item, append_key, push_text_char_description):
12089 Now static.
1004a21a 12090 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12091 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12092 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12093 (describe_map_tree):
12094 Rename locals to avoid shadowing.
38fc62d9 12095
2f2650da
PE
12096 * keyboard.c: Declare functions static if they are not used elsewhere.
12097 (echo_char, echo_dash, cmd_error, top_level_2):
12098 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12099 (read_char, kbd_buffer_get_event, make_lispy_position):
12100 (make_lispy_event, make_lispy_movement, apply_modifiers):
12101 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12102 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12103 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12104 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12105 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12106
a053e86c 12107 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12108 (mark_kboards): Move decl here ...
12109 * alloc.c (mark_kboards): ... from here.
a053e86c 12110
4752793e
PE
12111 * lisp.h (force_auto_save_soon): New decl.
12112
74f10ca7 12113 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12114 (DEFINE_DUMMY_FUNCTION): New macro.
12115 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12116 Use it.
c03cd23f
PE
12117 (main): Add casts to avoid warnings
12118 if GCC considers string literals to be constants.
74f10ca7 12119
022e70d4
PE
12120 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12121
59d6fe83
PE
12122 * dbusbind.c: Pointer signedness fixes.
12123 (xd_signature, xd_append_arg, xd_initialize):
12124 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12125 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12126 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12127 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12128
78320123
PE
12129 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12130 if GCC considers string literals to be constants.
49cebcca 12131 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12132
35ac2a97
SM
121332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12134
fb103ca9
SM
12135 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12136 (print_preprocess, print_object): New macro to fix last change.
12137
35ac2a97
SM
12138 * print.c (print_preprocess): Don't forget font objects.
12139
62973b41
JB
121402011-03-16 Juanma Barranquero <lekktu@gmail.com>
12141
12142 * emacs.c (USAGE3): Doc fixes.
12143
0e48bb22
AS
121442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12145
12146 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12147 structure.
12148
7684e57b
JB
121492011-03-14 Juanma Barranquero <lekktu@gmail.com>
12150
12151 * lisp.h (VWindow_system, Qfile_name_history):
12152 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12153 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12154 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12155
12156 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12157 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12158
12159 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12160 * w32console.c (detect_input_pending, read_input_pending)
12161 (encode_terminal_code):
12162 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12163 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12164 (w32_system_caret_y, Qfile_name_history):
12165 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12166 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12167 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12168 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12169 * w32proc.c (Qlocal, report_file_error):
12170 * w32term.c (Vwindow_system, updating_frame):
12171 * w32uniscribe.c (initialized, uniscribe_font_driver):
12172 Remove unneeded extern declarations.
12173
2aa46d6c
CY
121742011-03-14 Chong Yidong <cyd@stupidchicken.com>
12175
c96bbc66 12176 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12177
cffc6f3b
CY
121782011-03-13 Chong Yidong <cyd@stupidchicken.com>
12179
12180 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12181 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12182 These macros can no longer be used for assignment.
12183
44f230aa
SM
12184 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12185 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12186 (record_buffer_markers, fetch_buffer_markers): New functions for
12187 recording and fetching special buffer markers.
12188 (set_buffer_internal_1, set_buffer_temp): Use them.
12189
12190 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12191
12192 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12193
12194 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12195 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12196
12197 * xdisp.c (hscroll_window_tree):
12198 (reconsider_clip_changes): Use PT instead of BUF_PT.
12199
d251f04b
EZ
122002011-03-13 Eli Zaretskii <eliz@gnu.org>
12201
12202 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12203 $(EMACS_ROOT)/lib/intprops.h.
12204
f0c77cd1
PE
122052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12206
3eca4629
PE
12207 Fix more problems found by GCC 4.5.2's static checks.
12208
7c86ee98
PE
12209 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12210 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12211 (xg_free_frame_widgets): Make it clear that a local variable is
12212 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12213 (gdk_window_get_screen): Make it clear that this macro is needed
12214 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12215 (int_gtk_range_get_value): New function, which avoids a diagnostic
12216 from gcc -Wbad-function-cast.
12217 (xg_set_toolkit_scroll_bar_thumb): Use it.
12218 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12219 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12220 (get_utf8_string, xg_get_file_with_chooser):
12221 Rename locals to avoid shadowing.
12222 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12223
41729b81
PE
12224 * xgselect.c (xg_select): Remove unused var.
12225
f0c77cd1
PE
12226 * image.c (four_corners_best): Mark locals as initialized.
12227 (gif_load): Initialize transparent_p to zero (Bug#8238).
12228 Mark another local as initialized.
ec6cf4c6 12229 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12230
ce0ad53d 12231 * image.c (clear_image_cache): Now static.
d5d5a617 12232 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12233 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12234 (x_edge_detection): Remove unnecessary cast that
12235 gcc -Wbad-function-cast diagnoses.
2037898d 12236 (gif_load): Fix pointer signedness.
6ae141d6
PE
12237 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12238 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12239
33383987 122402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12241
d32df629
PE
12242 Improve quality of tests for time stamp overflow.
12243 For example, without this patch (encode-time 0 0 0 1 1
12244 1152921504606846976) returns the obviously-bogus value (-948597
12245 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12246 reports time overflow. See
12247 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12248 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12249 * editfns.c: Include limits.h and intprops.h.
12250 (TIME_T_MIN, TIME_T_MAX): New macros.
12251 (time_overflow): Move earlier, to before first use.
12252 (hi_time, lo_time): New functions, for an accurate test for
12253 out-of-range times.
12254 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12255 (Fget_internal_run_time): Don't assume time_t fits in int.
12256 (make_time): Use list2 instead of Fcons twice.
12257 (Fdecode_time): More accurate test for out-of-range times.
12258 (check_tm_member): New function.
12259 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12260 (lisp_time_argument): Don't rely on undefined left-shift and
12261 right-shift behavior when checking for time stamp overflow.
8be6f318 12262
fe31d94c
PE
12263 * editfns.c (time_overflow): New function, refactoring common code.
12264 (Fformat_time_string, Fdecode_time, Fencode_time):
12265 (Fcurrent_time_string): Use it.
12266
8be6f318
PE
12267 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12268 * dired.c (make_time): Move to ...
12269 * editfns.c (make_time): ... here.
12270 * systime.h: Note the move.
12271
09d9db2c 122722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12273
126bc0dc
YM
12274 * fringe.c (update_window_fringes): Remove unused variables.
12275
c47cbdfd
YM
12276 * unexmacosx.c (copy_data_segment): Also copy __got section.
12277 (Bug#8223)
12278
7ac80be9
EZ
122792011-03-12 Eli Zaretskii <eliz@gnu.org>
12280
c96bbc66 12281 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12282 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12283 Constify `char *' arguments and their references according to
12284 prototypes in tparam.h.
12285
ecb0f94d 12286 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12287
7ac80be9
EZ
12288 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12289 Adapt all references accordingly.
12290
12291 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12292
ef1fd07e
TT
122932011-03-11 Tom Tromey <tromey@redhat.com>
12294
12295 * buffer.c (syms_of_buffer): Remove obsolete comment.
12296
7ef4b50c
EZ
122972011-03-11 Eli Zaretskii <eliz@gnu.org>
12298
12299 * termhooks.h (encode_terminal_code): Declare prototype.
12300
12301 * msdos.c (encode_terminal_code): Don't declare prototype.
12302
12303 * term.c (encode_terminal_code): Now external again, used by
12304 w32console.c and msdos.c.
12305
44f230aa
SM
12306 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12307 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12308
4b1ec863 123092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12310
1714f52b 12311 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12312
4b1ec863
PE
12313 * fringe.c (update_window_fringes): Mark locals as initialized
12314 (Bug#8227).
12315 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12316
524c7aa6
PE
12317 * alloc.c (mark_fringe_data): Move decl from here ...
12318 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12319 to check its interface.
12320 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12321
a5c0af81 12322 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12323 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12324 (fontset_font): Mark local as initialized.
a9a06e0b 12325 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12326
b4716021
PE
12327 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12328
811e9bac 12329 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12330 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12331 (x_own_selection, Fx_disown_selection_internal): Rename locals
12332 to avoid shadowing.
12333 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12334
7e3ab302
PE
12335 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12336 so that the caller can use some name other than gcpro1.
12337 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12338 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12339 (Fx_backspace_delete_keys_p):
12340 Use them to avoid shadowing, and rename vars to avoid shadowing.
12341 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12342 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12343 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12344 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12345 Remove unused locals.
7e3ab302
PE
12346 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12347 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12348 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12349 macros.
f78faa98 12350
e2b13473
PE
12351 * xterm.h (x_mouse_leave): New decl.
12352
77f23912
PE
12353 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12354 Remove unused functions.
cdf4ba58
PE
12355 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12356 (x_calc_absolute_position): Now static.
7411c686 12357 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12358 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12359 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12360 unless they are used.
38d0b34a
PE
12361 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12362 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12363 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12364 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12365 (x_error_catcher, x_connection_closed, x_error_handler):
12366 (x_error_quitter, xembed_send_message, x_iconify_frame):
12367 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12368 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12369 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12370
44f230aa
SM
12371 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12372 Rename or move locals to avoid shadowing.
6b463e58 12373 (tty_defined_color, merge_face_heights): Now static.
5967d051 12374 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12375 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12376 does not deduce is never used uninitialized.
73719eba
PE
12377 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12378 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12379
426994c3 12380 * terminal.c (store_terminal_param): Now static.
5489860b 12381
032f1620 12382 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12383 (set_frame_menubar): Remove unused local.
d4323972 12384 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12385 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12386 since they might point to immutable storage.
281585b0
PE
12387 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12388 since it's unused otherwise.
032f1620 12389
367c19e5 12390 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12391 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12392 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12393 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12394 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12395 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12396 does not deduce are never used uninitialized.
70739cbe 12397
07b48fa9
PE
12398 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12399
8868a238 12400 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12401 * window.c (window_loop, size_window):
12402 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12403
7e5cf297 12404 * window.c (display_buffer): Now static.
d6550a9f
PE
12405 (size_window): Mark variables that gcc -Wuninitialized
12406 does not deduce are never used uninitialized.
a586633d
PE
12407 * window.h (check_all_windows): New decl, to forestall
12408 gcc -Wmissing-prototypes diagnostic.
5b555da1 12409 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12410
f6095868
PE
12411 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12412 shadowing.
12413 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12414 Include <limits.h>.
12415 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12416 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12417 (load_charset_map): Mark variables that gcc -Wuninitialized
12418 does not deduce are never used uninitialized.
53df7c11 12419 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12420
f38b440c
PE
12421 * coding.c (coding_set_source, coding_set_destination):
12422 Use "else { /* comment */ }" rather than "else /* comment */;"
12423 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12424 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12425 a block, when the outer 'i' will do.
12426 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12427 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12428 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12429 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12430 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12431 Rename locals to avoid shadowing.
12432 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12433 * coding.c (emacs_mule_char, encode_invocation_designation):
12434 Now static, since they're not used elsewhere.
413bb2db 12435 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12436 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12437 (decode_coding_emacs_mule): Mark variables that gcc
12438 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12439 (detect_coding_iso_2022): Initialize a local variable that might
12440 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12441 this initialization is needed. (Bug#8211)
5f58e762
PE
12442 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12443 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12444 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12445 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12446 Remove unused macros.
f38b440c 12447
232b38b9 12448 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12449 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12450 * character.c (string_count_byte8): Likewise.
232b38b9 12451
fb90da1b
PE
12452 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12453 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12454
fb93dbc2
PE
12455 * chartab.c (copy_sub_char_table): Now static, since it's not used
12456 elsewhere.
5c156ace
PE
12457 (sub_char_table_ref_and_range, char_table_ref_and_range):
12458 Rename locals to avoid shadowing.
bbcd0949 12459 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12460
7d3b3862 12461 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12462 (BIDI_BOB): Remove unused macro.
7d3b3862 12463
6be7d3da
PE
12464 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12465 deduce are never used uninitialized.
c2ed9c8b 12466 * term.c (encode_terminal_code): Likewise.
6be7d3da 12467
75f8807f 12468 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12469
50938595
PE
12470 * tparam.h: New file.
12471 * term.c, tparam.h: Include it.
12472 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12473 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12474 Move these decls to tparam.h, and make them agree with what
12475 is actually in tparam.c. The previous trick of using incompatible
12476 decls in different modules does not conform to the C standard.
12477 All callers of tparam changed to use tparam's actual API.
12478 * tparam.c (tparam1, tparam, tgoto):
12479 Use const pointers where appropriate.
12480
fbceeba2
PE
12481 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12482 * cm.h (struct cm): Likewise.
12483 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12484 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12485 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12486 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12487 (turn_on_face, init_tty): Likewise.
12488 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12489
7f3f1250
PE
12490 * term.c (term_mouse_position): Rename local to avoid shadowing.
12491
e6ca6543
PE
12492 * alloc.c (mark_ttys): Move decl from here ...
12493 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12494
c40f8d15
AS
124952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12496
12497 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12498
cfe0661d
JB
124992011-03-09 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * search.c (compile_pattern_1): Remove argument regp, unused since
12502 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12503 (compile_pattern): Don't pass it.
12504
0afb4571
J
125052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12506
12507 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12508 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12509 for ! HAVE_GTK3.
12510 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12511
12512 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12513
12514 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12515 gdk_window_get_screen, gdk_window_get_geometry,
12516 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12517 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12518 (xg_get_pixbuf_from_pixmap): New function.
12519 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12520 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12521 Call xg_get_pixbuf_from_pixmap instead of
12522 gdk_pixbuf_get_from_drawable.
12523 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12524 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12525 (xg_check_special_colors): Use GtkStyleContext and its functions
12526 for HAVE_GTK3.
12527 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12528 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12529 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12530 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12531 Call gtk_widget_get_preferred_size.
0afb4571
J
12532 (xg_frame_resized): gdk_window_get_geometry only takes 5
12533 parameters.
44f230aa
SM
12534 (xg_win_to_widget, xg_event_is_for_menubar):
12535 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12536 (xg_set_widget_bg): New function.
12537 (delete_cb): New function.
895009e1 12538 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12539 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12540 (xg_set_background_color): Call xg_set_widget_bg.
12541 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12542 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12543 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12544 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12545 if ! HAVE_GTK3.
12546 (update_frame_tool_bar): Call gtk_widget_hide.
12547 (xg_initialize): Use GDK_KEY_g.
12548
12549 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12550 if ! HAVE_GTK3
12551 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12552
12553 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12554 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12555 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12556
1c2cc4ef
JB
125572011-03-08 Juanma Barranquero <lekktu@gmail.com>
12558
12559 * w32xfns.c (select_palette): Check success of RealizePalette against
12560 GDI_ERROR, not zero.
12561
33383987 12562See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12563
12564;; Local Variables:
12565;; coding: utf-8
aac0c6e3
MR
12566;; End:
12567
2f097256 12568 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12569
12570 This file is part of GNU Emacs.
12571
12572 GNU Emacs is free software: you can redistribute it and/or modify
12573 it under the terms of the GNU General Public License as published by
12574 the Free Software Foundation, either version 3 of the License, or
12575 (at your option) any later version.
12576
12577 GNU Emacs is distributed in the hope that it will be useful,
12578 but WITHOUT ANY WARRANTY; without even the implied warranty of
12579 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12580 GNU General Public License for more details.
12581
12582 You should have received a copy of the GNU General Public License
12583 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.